2842ff05ac831834cc1f1b3882392a760ece8409
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-26  Daniel Bates  <dabates@apple.com>
2
3         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
4         https://bugs.webkit.org/show_bug.cgi?id=184161
5         <rdar://problem/39051645>
6
7         Reviewed by Dan Bernstein.
8
9         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
10         dropping a PDF embedded using an HTML image element into the same web view.
11
12         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
13         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
14         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
15         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
16         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
17         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
18         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
19         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
20         image document when navigated to directly. Since we can support dragging PDF document images we need to
21         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
22         We need to do both such queries before falling back to using the main resource of the Web Archive as
23         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
24         not an image document.
25
26         * Misc/WebNSPasteboardExtras.mm:
27         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
28
29 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
30
31         Disable content filtering in minimal simulator mode
32         https://bugs.webkit.org/show_bug.cgi?id=185027
33         <rdar://problem/39736091>
34
35         Reviewed by Jer Noble.
36
37         * Configurations/FeatureDefines.xcconfig:
38
39 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
40
41         [INTL] Implement Intl.PluralRules
42         https://bugs.webkit.org/show_bug.cgi?id=184312
43
44         Reviewed by JF Bastien.
45
46         Added Intl.PluralRules feature flag.
47
48         * Configurations/FeatureDefines.xcconfig:
49
50 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
51
52         Remove access to keychain from the WebContent process
53         https://bugs.webkit.org/show_bug.cgi?id=184428
54         <rdar://problem/13150903>
55
56         Reviewed by Brent Fulgham.
57
58         This patch does the followings:
59         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
60         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
61         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
62
63         * WebCoreSupport/WebChromeClient.h:
64         * WebCoreSupport/WebChromeClient.mm:
65         (WebChromeClient::signedPublicKeyAndChallengeString const):
66         * WebView/WebUIDelegatePrivate.h:
67
68 2018-04-24  Jer Noble  <jer.noble@apple.com>
69
70         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
71         https://bugs.webkit.org/show_bug.cgi?id=184786
72
73         Reviewed by Tim Horton.
74
75         * Configurations/WebKitLegacy.xcconfig:
76         * MigrateHeaders.make:
77
78 2018-04-23  Daniel Bates  <dabates@apple.com>
79
80         Implement Same-Site cookies
81         https://bugs.webkit.org/show_bug.cgi?id=159464
82         <rdar://problem/27196358>
83
84         Reviewed by Brent Fulgham.
85
86         Pass the Same-Site info through the strategy.
87
88         * WebCoreSupport/WebPlatformStrategies.h:
89         * WebCoreSupport/WebPlatformStrategies.mm:
90         (WebPlatformStrategies::cookiesForDOM):
91         (WebPlatformStrategies::setCookiesFromDOM):
92         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
93         (WebPlatformStrategies::getRawCookies):
94
95 2018-04-23  Zalan Bujtas  <zalan@apple.com>
96
97         [LayoutFormattingContext] Initial commit.
98         https://bugs.webkit.org/show_bug.cgi?id=184896
99
100         Reviewed by Antti Koivisto.
101
102         * Configurations/FeatureDefines.xcconfig:
103
104 2018-04-23  Daniel Bates  <dabates@apple.com>
105
106         Implement Same-Site cookies
107         https://bugs.webkit.org/show_bug.cgi?id=159464
108         <rdar://problem/27196358>
109
110         Reviewed by Brent Fulgham.
111
112         Pass the Same-Site info through the strategy.
113
114         * WebCoreSupport/WebPlatformStrategies.h:
115         * WebCoreSupport/WebPlatformStrategies.mm:
116         (WebPlatformStrategies::cookiesForDOM):
117         (WebPlatformStrategies::setCookiesFromDOM):
118         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
119         (WebPlatformStrategies::getRawCookies):
120
121 2018-04-20  Timothy Hatcher  <timothy@apple.com>
122
123         NULL dereference crash sometimes under [super initWithCoder:] in WebView
124
125         https://bugs.webkit.org/show_bug.cgi?id=184851
126         rdar://problem/39611236
127
128         Reviewed by Tim Horton.
129
130         * WebView/WebView.mm:
131         (-[WebView _commonInitializationWithFrameName:groupName:]):
132         (-[WebView effectiveAppearanceDidChange]):
133         Added a null check and call the code later in initialization.
134
135 2018-04-20  Tim Horton  <timothy_horton@apple.com>
136
137         Adjust geolocation feature flag
138         https://bugs.webkit.org/show_bug.cgi?id=184856
139
140         Reviewed by Wenson Hsieh.
141
142         * Configurations/FeatureDefines.xcconfig:
143
144 2018-04-18  Jer Noble  <jer.noble@apple.com>
145
146         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
147         https://bugs.webkit.org/show_bug.cgi?id=184762
148
149         Reviewed by Dan Bernstein.
150
151         * Configurations/WebKitLegacy.xcconfig:
152
153 2018-04-20  Youenn Fablet  <youenn@apple.com>
154
155         Make PluginData cache its web visible plugins
156         https://bugs.webkit.org/show_bug.cgi?id=184421
157
158         Reviewed by Chris Dumez.
159
160         * WebCoreSupport/WebPluginInfoProvider.h:
161         * WebCoreSupport/WebPluginInfoProvider.mm:
162         (WebPluginInfoProvider::pluginInfo):
163         (WebPluginInfoProvider::webVisiblePluginInfo):
164
165 2018-04-19  Chris Dumez  <cdumez@apple.com>
166
167         Rename JSDOMWindowProxy to JSWindowProxy
168         https://bugs.webkit.org/show_bug.cgi?id=184797
169
170         Reviewed by Sam Weinig.
171
172         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
173
174         * DOM/DOMUtility.mm:
175         (createDOMWrapper):
176         * WebView/WebFrame.mm:
177         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
178
179 2018-04-19  David Kilzer  <ddkilzer@apple.com>
180
181         Enable Objective-C weak references
182         <https://webkit.org/b/184789>
183         <rdar://problem/39571716>
184
185         Reviewed by Dan Bernstein.
186
187         * Configurations/Base.xcconfig:
188         (CLANG_ENABLE_OBJC_WEAK): Enable.
189
190 2018-04-18  Chris Dumez  <cdumez@apple.com>
191
192         Rename WindowProxyController to WindowProxy
193         https://bugs.webkit.org/show_bug.cgi?id=184756
194
195         Reviewed by Sam Weinig.
196
197         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
198         needed use WindowProxyController type, which was a bit confusing.
199
200         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
201         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
202         * WebView/WebFrame.mm:
203         (-[WebFrame _attachScriptDebugger]):
204
205 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
206
207         Unreviewed rollout of r230632. Regression in memory usage.
208
209         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
210
211         * WebView/WebPreferences.mm:
212         (+[WebPreferences initialize]):
213
214 2018-04-17  Chris Dumez  <cdumez@apple.com>
215
216         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
217         https://bugs.webkit.org/show_bug.cgi?id=184678
218         <rdar://problem/39422122>
219
220         Reviewed by Alex Christensen.
221
222         Add new parameter to dispatchDecidePolicyForNavigationAction.
223
224         * WebCoreSupport/WebFrameLoaderClient.h:
225         * WebCoreSupport/WebFrameLoaderClient.mm:
226         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
227
228 2018-04-13  Chris Dumez  <cdumez@apple.com>
229
230         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
231         https://bugs.webkit.org/show_bug.cgi?id=184591
232
233         Reviewed by Sam Weinig.
234
235         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
236         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
237         This is work towards fixing Bug 184515.
238
239         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
240         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
241         * WebView/WebFrame.mm:
242         (-[WebFrame _attachScriptDebugger]):
243
244 2018-04-12  Antoine Quint  <graouts@apple.com>
245
246         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
247         https://bugs.webkit.org/show_bug.cgi?id=184569
248         <rdar://problem/38671301>
249
250         Reviewed by Jon Lee.
251
252         * WebView/WebPreferences.mm:
253
254 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
255
256         [WTF] Remove StaticLock
257         https://bugs.webkit.org/show_bug.cgi?id=184332
258
259         Reviewed by Mark Lam.
260
261         * DOM/DOMInternal.mm:
262         (getDOMWrapper):
263         (addDOMWrapper):
264         (removeDOMWrapper):
265
266 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
267
268         Failures from mach port reference handling should be fatal
269         https://bugs.webkit.org/show_bug.cgi?id=184202
270         <rdar://problem/37771114>
271
272         Reviewed by Anders Carlsson.
273
274         * Plugins/Hosted/NetscapePluginHostManager.mm:
275         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
276
277 2018-04-03  Andy Estes  <aestes@apple.com>
278
279         [Mac] Prioritize file promises over filenames during drag and drop
280         https://bugs.webkit.org/show_bug.cgi?id=184237
281         <rdar://problem/38278076>
282
283         Reviewed by Wenson Hsieh.
284
285         * WebView/WebView.mm:
286         (-[WebView performDragOperation:]):
287
288 2018-04-03  Chris Dumez  <cdumez@apple.com>
289
290         Drop MainFrame class
291         https://bugs.webkit.org/show_bug.cgi?id=184191
292
293         Reviewed by Darin Adler.
294
295         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
296         relationship between the Page and the MainFrame.
297
298         This is ground work for introducing LocalFrame / RemoteFrame concepts.
299
300         * WebCoreSupport/WebDragClient.mm:
301         * WebCoreSupport/WebFrameLoaderClient.mm:
302         * WebCoreSupport/WebInspectorClient.mm:
303         * WebCoreSupport/WebPlatformStrategies.mm:
304         * WebCoreSupport/WebPluginInfoProvider.mm:
305         * WebView/WebFrame.mm:
306         * WebView/WebFrameView.mm:
307         * WebView/WebHTMLView.mm:
308         * WebView/WebView.mm:
309
310 2018-04-02  Jer Noble  <jer.noble@apple.com>
311
312         Enable Legacy EME for all WebKit & WebKitLegacy clients
313         https://bugs.webkit.org/show_bug.cgi?id=184018
314         <rdar://problem/34887387>
315
316         Reviewed by Eric Carlson.
317
318         * WebView/WebPreferences.mm:
319         (+[WebPreferences initialize]):
320
321 2018-03-29  JF Bastien  <jfbastien@apple.com>
322
323         Use Forward.h instead of forward-declaring WTF::String
324         https://bugs.webkit.org/show_bug.cgi?id=184172
325         <rdar://problem/39026146>
326
327         Reviewed by Yusuke Suzuki.
328
329         As part of #184164 I'm changing WTF::String, and the forward
330         declarations are just wrong because I'm making it templated. We
331         should use Forward.h anyways, so do that instead.
332
333         * WebView/WebScriptDebugger.h:
334
335 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
336
337         Protect against invalid mach ports returned by mach_port_request_notification
338         https://bugs.webkit.org/show_bug.cgi?id=184106
339         <rdar://problem/37865316>
340
341         Reviewed by Chris Dumez.
342
343         * Plugins/Hosted/NetscapePluginHostProxy.mm:
344         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
345         and clean up if it experienced an error.
346         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
347
348 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
349
350         Avoid uninitialized mach ports
351         https://bugs.webkit.org/show_bug.cgi?id=184090
352         <rdar://problem/37261129>
353
354         Reviewed by Chris Dumez.
355
356         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
357         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
358         there is a potential for us to try to use invalid ports.
359
360         We should always check return values, and ensure that the mach port variables we seek to initialize are
361         kept in a valid state.
362
363         Reviewed by Chris Dumez.
364
365         * Plugins/Hosted/NetscapePluginHostManager.h:
366         * Plugins/Hosted/NetscapePluginHostManager.mm:
367         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
368         port is passed to an API function.
369         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
370         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
371         * Plugins/Hosted/NetscapePluginHostProxy.h:
372         * Plugins/Hosted/NetscapePluginHostProxy.mm:
373         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
374         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
375         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
376         (WKPCStatusText): Ditto.
377         (WKPCLoadURL): Ditto.
378         (WKPCCancelLoadURL): Ditto.
379         (WKPCInvalidateRect): Ditto.
380         (WKPCGetScriptableNPObjectReply): Ditto.
381         (WKPCBooleanReply): Ditto.
382         (WKPCBooleanAndDataReply): Ditto.
383         (WKPCInstantiatePluginReply): Ditto.
384         (WKPCGetWindowNPObject): Ditto.
385         (WKPCGetPluginElementNPObject): Ditto.
386         (WKPCForgetBrowserObject): Ditto.
387         (WKPCEvaluate): Ditto.
388         (WKPCGetStringIdentifier): Ditto.
389         (WKPCGetIntIdentifier): Ditto.
390         (WKPCInvoke): Ditto.
391         (WKPCInvokeDefault): Ditto.
392         (WKPCConstruct): Ditto.
393         (WKPCGetProperty): Ditto.
394         (WKPCSetProperty): Ditto.
395         (WKPCRemoveProperty): Ditto.
396         (WKPCHasProperty): Ditto.
397         (WKPCHasMethod): Ditto.
398         (WKPCIdentifierInfo): Ditto.
399         (WKPCEnumerate): Ditto.
400         (WKPCSetMenuBarVisible): Ditto.
401         (WKPCSetFullscreenWindowIsShowing): Ditto.
402         (WKPCSetModal): Ditto.
403         (WKPCGetCookies): Ditto.
404         (WKPCGetProxy): Ditto.
405         (WKPCSetCookies): Ditto.
406         (WKPCGetAuthenticationInfo): Ditto.
407         (WKPCConvertPoint): Ditto.
408         (WKPCLayerHostingModeChanged): Ditto.
409         (WKPCSetException): Ditto.
410
411 2018-03-26  Tim Horton  <timothy_horton@apple.com>
412
413         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
414         https://bugs.webkit.org/show_bug.cgi?id=184030
415         <rdar://problem/38895281>
416
417         Reviewed by Dan Bernstein.
418
419         * Configurations/Base.xcconfig:
420
421 2018-03-26  Chris Dumez  <cdumez@apple.com>
422
423         Use SecurityOriginData more consistently in Service Worker code
424         https://bugs.webkit.org/show_bug.cgi?id=183969
425
426         Reviewed by Darin Adler.
427
428         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
429
430         * Storage/WebDatabaseManager.mm:
431         (-[WebDatabaseManager databasesWithOrigin:]):
432         (-[WebDatabaseManager deleteOrigin:]):
433         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
434         * Storage/WebDatabaseQuotaManager.mm:
435         (-[WebDatabaseQuotaManager usage]):
436         (-[WebDatabaseQuotaManager quota]):
437         (-[WebDatabaseQuotaManager setQuota:]):
438         * Storage/WebStorageManager.mm:
439         (-[WebStorageManager deleteOrigin:]):
440         * WebCoreSupport/WebSecurityOrigin.mm:
441         (-[WebSecurityOrigin databaseIdentifier]):
442         (-[WebSecurityOrigin usage]):
443         (-[WebSecurityOrigin quota]):
444         (-[WebSecurityOrigin setQuota:]):
445
446 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
447
448         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
449         https://bugs.webkit.org/show_bug.cgi?id=183911
450         <rdar://problem/38762306>
451
452         Reviewed by Youenn Fablet.
453
454         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
455
456         * WebView/WebView.mm:
457         (+[WebView initialize]):
458
459 2018-03-26  Alex Christensen  <achristensen@webkit.org>
460
461         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
462         https://bugs.webkit.org/show_bug.cgi?id=183965
463
464         Reviewed by Chris Dumez.
465
466         * WebCoreSupport/WebFrameLoaderClient.h:
467         * WebCoreSupport/WebFrameLoaderClient.mm:
468         (WebFrameLoaderClient::willCacheResponse const):
469
470 2018-03-25  Commit Queue  <commit-queue@webkit.org>
471
472         Unreviewed, rolling out r229954.
473         https://bugs.webkit.org/show_bug.cgi?id=184000
474
475         Caused many layout tests to crash on Apple High Sierra,
476         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
477         by dydz on #webkit).
478
479         Reverted changeset:
480
481         "Use SecurityOriginData more consistently in Service Worker
482         code"
483         https://bugs.webkit.org/show_bug.cgi?id=183969
484         https://trac.webkit.org/changeset/229954
485
486 2018-03-24  Chris Dumez  <cdumez@apple.com>
487
488         Use SecurityOriginData more consistently in Service Worker code
489         https://bugs.webkit.org/show_bug.cgi?id=183969
490
491         Reviewed by Darin Adler.
492
493         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
494
495         * Storage/WebDatabaseManager.mm:
496         (-[WebDatabaseManager databasesWithOrigin:]):
497         (-[WebDatabaseManager deleteOrigin:]):
498         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
499         * Storage/WebDatabaseQuotaManager.mm:
500         (-[WebDatabaseQuotaManager usage]):
501         (-[WebDatabaseQuotaManager quota]):
502         (-[WebDatabaseQuotaManager setQuota:]):
503         * Storage/WebStorageManager.mm:
504         (-[WebStorageManager deleteOrigin:]):
505         * WebCoreSupport/WebSecurityOrigin.mm:
506         (-[WebSecurityOrigin databaseIdentifier]):
507         (-[WebSecurityOrigin usage]):
508         (-[WebSecurityOrigin quota]):
509         (-[WebSecurityOrigin setQuota:]):
510
511 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
512
513         Fix the build
514
515         * WebView/WebView.mm:
516
517 2018-03-23  Tim Horton  <timothy_horton@apple.com>
518
519         Fix the build with no pasteboard
520         https://bugs.webkit.org/show_bug.cgi?id=183973
521
522         Reviewed by Dan Bernstein.
523
524         * Configurations/FeatureDefines.xcconfig:
525         * WebView/WebView.mm:
526         (-[WebView _requestStartDataInteraction:globalPosition:]):
527         (-[WebView _getDataInteractionData]):
528         (-[WebView _dataOperationTextIndicator]):
529         (-[WebView _dragSourceAction]):
530         (-[WebView _draggedLinkTitle]):
531         (-[WebView _draggedLinkURL]):
532         (-[WebView _draggedElementBounds]):
533         (-[WebView _enteredDataInteraction:client:global:operation:]):
534         (-[WebView _updatedDataInteraction:client:global:operation:]):
535         (-[WebView _exitedDataInteraction:client:global:operation:]):
536         (-[WebView _performDataInteraction:client:global:operation:]):
537         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
538         (-[WebView _endedDataInteraction:global:]):
539         (-[WebView _dataInteractionCaretRect]):
540         * WebView/WebViewPrivate.h:
541
542 2018-03-23  Tim Horton  <timothy_horton@apple.com>
543
544         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
545         https://bugs.webkit.org/show_bug.cgi?id=183960
546         <rdar://problem/38812356>
547
548         Reviewed by Dan Bernstein.
549
550         * Configurations/WebKitLegacy.xcconfig:
551
552 2018-03-23  Tim Horton  <timothy_horton@apple.com>
553
554         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
555         https://bugs.webkit.org/show_bug.cgi?id=183954
556         <rdar://problem/38808858>
557
558         Reviewed by Dan Bernstein.
559
560         * WebView/WebPreferences.mm:
561         (-[WebPreferences setAudioSessionCategoryOverride:]):
562
563 2018-03-23  Tim Horton  <timothy_horton@apple.com>
564
565         Adopt WK_PLATFORM_NAME in WebKitLegacy
566         https://bugs.webkit.org/show_bug.cgi?id=183948
567         <rdar://problem/38803908>
568
569         Reviewed by Dan Bernstein.
570
571         * Configurations/WebKitLegacy.xcconfig:
572         * MigrateHeaders.make:
573         * postprocess-headers.sh:
574
575 2018-03-23  Brady Eidson  <beidson@apple.com>
576
577         Go to back/forward list items after a process-swapped navigation.
578         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
579
580         Reviewed by Andy Estes.
581
582         * WebView/WebView.mm:
583         (-[WebView _loadBackForwardListFromOtherView:]):
584         (-[WebView goToBackForwardItem:]):
585
586 2018-03-22  Tim Horton  <timothy_horton@apple.com>
587
588         Improve readability of WebCore's OTHER_LDFLAGS
589         https://bugs.webkit.org/show_bug.cgi?id=183909
590         <rdar://problem/38760992>
591
592         Reviewed by Dan Bernstein.
593
594         * Configurations/Base.xcconfig:
595         * Configurations/FeatureDefines.xcconfig:
596
597 2018-03-20  Tim Horton  <timothy_horton@apple.com>
598
599         Enable the minimal simulator feature flag when appropriate
600         https://bugs.webkit.org/show_bug.cgi?id=183807
601
602         Reviewed by Dan Bernstein.
603
604         * Configurations/FeatureDefines.xcconfig:
605
606 2018-03-20  Tim Horton  <timothy_horton@apple.com>
607
608         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
609         https://bugs.webkit.org/show_bug.cgi?id=183758
610         <rdar://problem/38017644>
611
612         Reviewed by Dan Bernstein.
613
614         * Configurations/FeatureDefines.xcconfig:
615
616 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
617
618         Clear style colors when setting default appearance
619         https://bugs.webkit.org/show_bug.cgi?id=183759
620
621         Reviewed by Tim Horton.
622
623         Colors are cached and need to be cleared and recalculated.
624         Refactor to do all style recalcs together.
625
626         * WebView/WebView.mm:
627         (-[WebView _setDefaultAppearanceAndClearStyle]):
628         (-[WebView _setUseSystemAppearance:]):
629         (-[WebView effectiveAppearanceDidChange]):
630
631 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
632
633         Unreviewed, another quick fix for r229699
634
635         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
636
637         * Configurations/FeatureDefines.xcconfig:
638
639 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
640
641         Ensure that style is updated when the effective appearance changes
642         https://bugs.webkit.org/show_bug.cgi?id=183690
643         <rdar://problem/38385900>
644
645         Reviewed by Tim Horton and Wenson Hsieh.
646
647         Respond to and respect the effective appearance changing.
648
649         * WebView/WebView.mm:
650         (-[WebView _setUseSystemAppearance:]):
651         (-[WebView effectiveAppearanceDidChange]):
652
653 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
654
655         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
656         https://bugs.webkit.org/show_bug.cgi?id=183677
657
658         Reviewed by Tim Horton.
659
660         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
661
662         * DOM/DOM.mm:
663         (-[DOMHTMLLinkElement _mediaQueryMatches]):
664
665 2018-03-14  Tim Horton  <timothy_horton@apple.com>
666
667         Fix the build after r229567
668
669         * Configurations/FeatureDefines.xcconfig:
670
671 2018-03-12  Tim Horton  <timothy_horton@apple.com>
672
673         Stop using SDK conditionals to control feature definitions
674         https://bugs.webkit.org/show_bug.cgi?id=183430
675         <rdar://problem/38251619>
676
677         Reviewed by Dan Bernstein.
678
679         * Configurations/FeatureDefines.xcconfig:
680         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
681
682 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
683
684         Runtime flag for link prefetch and remove link subresource.
685         https://bugs.webkit.org/show_bug.cgi?id=183540
686
687         Reviewed by Chris Dumez.
688
689         Remove the LINK_PREFETCH build time flag.
690
691         * Configurations/FeatureDefines.xcconfig:
692
693 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
694
695         Remove GridLayout runtime flag
696         https://bugs.webkit.org/show_bug.cgi?id=183484
697
698         Reviewed by Myles C. Maxfield.
699
700         The Grid Layout feature has been enabled by default for almost a
701         year, so I think it's time to remove the runtime flag and the
702
703         * WebView/WebPreferenceKeysPrivate.h:
704         * WebView/WebPreferences.mm:
705         (+[WebPreferences initialize]):
706         * WebView/WebPreferencesPrivate.h:
707         * WebView/WebView.mm:
708         (-[WebView _preferencesChanged:]):
709
710 2018-03-12  Antoine Quint  <graouts@apple.com>
711
712         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
713         https://bugs.webkit.org/show_bug.cgi?id=183504
714         <rdar://problem/38372965>
715
716         Reviewed by Dean Jackson and Jon Lee.
717
718         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
719         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
720
721         * WebView/WebPreferenceKeysPrivate.h:
722         * WebView/WebPreferences.mm:
723         (+[WebPreferences initialize]):
724         (-[WebPreferences setModernMediaControlsEnabled:]):
725         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
726         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
727         * WebView/WebPreferencesPrivate.h:
728         * WebView/WebView.mm:
729         (-[WebView _preferencesChanged:]):
730
731 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
732
733         Media query for default appearance
734         https://bugs.webkit.org/show_bug.cgi?id=183539
735         <rdar://problem/38326388>
736
737         Reviewed by Tim Horton.
738
739         Write a media query to evaluate appearance.
740
741         * WebView/WebView.mm:
742         (-[WebView _commonInitializationWithFrameName:groupName:]):
743         (-[WebView _setUseSystemAppearance:]):
744
745 2018-03-09  Andy Estes  <aestes@apple.com>
746
747         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
748         https://bugs.webkit.org/show_bug.cgi?id=183489
749         <rdar://problem/38267517>
750
751         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
752         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
753         to issue a sandbox extension for this directory, but for security reasons App Sandbox
754         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
755         block with a nil error and a valid file URL, but no file will actually exist at that URL.
756
757         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
758         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
759         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
760         drop destination.
761
762         Reviewed by Wenson Hsieh.
763
764         * WebView/WebView.mm:
765         (-[WebView performDragOperation:]):
766
767 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
768
769         Allow WebViews to disable system appearance
770         https://bugs.webkit.org/show_bug.cgi?id=183418
771         <rdar://problem/36975642>
772
773         Reviewed by Tim Horton.
774
775         Allow webviews to choose whether or not to follow the default system appearance.
776
777         * WebView/WebView.mm:
778         (-[WebView _setUseSystemAppearance:]):
779         (-[WebView _useSystemAppearance]):
780         * WebView/WebViewPrivate.h:
781
782 2018-03-08  Youenn Fablet  <youenn@apple.com>
783
784         libwebrtc update broke internal builds
785         https://bugs.webkit.org/show_bug.cgi?id=183454
786
787         Reviewed by Eric Carlson.
788
789         * Configurations/WebKitLegacy.xcconfig:
790
791 2018-03-08  Chris Dumez  <cdumez@apple.com>
792
793         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
794         https://bugs.webkit.org/show_bug.cgi?id=183455
795         <rdar://problem/38191749>
796
797         Reviewed by Youenn Fablet.
798
799         Add a null check for the page as we have evidence from crashes that it can be null.
800         Other functions in WebFrameNetworkingContext already null check the page as well,
801         not just the frame so this is consistent.
802
803         * WebCoreSupport/WebFrameNetworkingContext.mm:
804         (WebFrameNetworkingContext::storageSession const):
805
806 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
807
808         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
809         https://bugs.webkit.org/show_bug.cgi?id=183429
810
811         Reviewed by Mark Lam.
812
813         * DOM/DOM.mm:
814         (+[DOMNode _nodeFromJSWrapper:]):
815         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
816         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
817         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
818         * Plugins/Hosted/ProxyInstance.mm:
819         (WebKit::ProxyInstance::invokeMethod):
820         * WebView/WebView.mm:
821         (aeDescFromJSValue):
822
823 2018-03-08  Tim Horton  <timothy_horton@apple.com>
824
825         Stop linking ApplicationServices directly
826         https://bugs.webkit.org/show_bug.cgi?id=182867
827         <rdar://problem/38252142>
828
829         Reviewed by Alex Christensen.
830
831         The frameworks that we use that live inside ApplicationServices
832         have mostly moved out, so import them directly.
833
834         * Carbon/CarbonUtils.h:
835         * WebKitPrefix.h:
836         * WebView/WebHTMLView.mm:
837         * WebView/WebPDFView.mm:
838
839 2018-03-07  Tim Horton  <timothy_horton@apple.com>
840
841         Sort and separate FeatureDefines.xcconfig
842         https://bugs.webkit.org/show_bug.cgi?id=183427
843
844         Reviewed by Dan Bernstein.
845
846         * Configurations/FeatureDefines.xcconfig:
847         Sort and split FeatureDefines into paragraphs
848         (to make it easier to sort later).
849
850 2018-03-07  Youenn Fablet  <youenn@apple.com>
851
852         Match unsupported plugins based on domains and not origin
853         https://bugs.webkit.org/show_bug.cgi?id=183384
854
855         Reviewed by Chris Dumez.
856
857         * WebCoreSupport/WebPluginInfoProvider.h:
858         * WebCoreSupport/WebPluginInfoProvider.mm:
859         (WebPluginInfoProvider::getPluginInfo):
860         (WebPluginInfoProvider::getWebVisiblePluginInfo):
861
862 2018-03-05  Andy Estes  <aestes@apple.com>
863
864         [Mac] Teach WebCore::Pasteboard about file promise drags
865         https://bugs.webkit.org/show_bug.cgi?id=183314
866         <rdar://problem/38105493>
867
868         Reviewed by Darin Adler.
869
870         Added a FIXME comment.
871
872         * WebView/WebView.mm:
873         (-[WebView performDragOperation:]):
874
875 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
876
877         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
878         https://bugs.webkit.org/show_bug.cgi?id=183312
879
880         Reviewed by Mark Lam.
881
882         Remove wtf/CurrentTime.h include pragma.
883
884         * WebView/WebFrame.mm:
885         * WebView/WebPDFView.mm:
886
887 2018-03-04  Tim Horton  <timothy_horton@apple.com>
888
889         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
890         https://bugs.webkit.org/show_bug.cgi?id=183283
891         <rdar://problem/38062148>
892
893         Reviewed by Sam Weinig.
894
895         * Configurations/FeatureDefines.xcconfig:
896
897 2018-02-28  Alex Christensen  <achristensen@webkit.org>
898
899         Reduce use of NetworkingContext in WebKit
900         https://bugs.webkit.org/show_bug.cgi?id=183213
901
902         Reviewed by Brady Eidson.
903
904         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
905         (WebKit::NetscapePluginInstanceProxy::getProxy):
906         * Plugins/WebNetscapePluginView.mm:
907         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
908
909 2018-02-17  Darin Adler  <darin@apple.com>
910
911         Prepare for ExtendedColor changes (first step)
912         https://bugs.webkit.org/show_bug.cgi?id=182904
913
914         Reviewed by Sam Weinig.
915
916         * Misc/WebKitNSStringExtras.mm:
917         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
918
919 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
920
921         Remove currentTime() / currentTimeMS()
922         https://bugs.webkit.org/show_bug.cgi?id=183052
923
924         Reviewed by Mark Lam.
925
926         * WebCoreSupport/WebFrameLoaderClient.h:
927         * WebCoreSupport/WebFrameLoaderClient.mm:
928         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
929
930 2018-02-16  Youenn Fablet  <youenn@apple.com>
931
932         Allow specifying which plug-ins are supported
933         https://bugs.webkit.org/show_bug.cgi?id=182748
934
935         Reviewed by Chris Dumez.
936
937         * WebCoreSupport/WebPluginInfoProvider.h:
938         * WebCoreSupport/WebPluginInfoProvider.mm:
939         (WebPluginInfoProvider::getPluginInfo):
940         (WebPluginInfoProvider::getWebVisiblePluginInfo):
941
942 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
943
944         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
945         https://bugs.webkit.org/show_bug.cgi?id=182882
946         <rdar://problem/35672661>
947
948         Reviewed by Dan Bernstein.
949
950         Make sure the smart pointer hold the collection of subviews lives at least as
951         long as the loop using it.
952
953         * WebView/WebHTMLView.mm:
954         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
955
956 2018-02-14  Daniel Bates  <dabates@apple.com>
957
958         Disallow cross-origin subresources from asking for credentials
959         https://bugs.webkit.org/show_bug.cgi?id=182579
960         <rdar://problem/36162271>
961
962         Reviewed by Andy Estes.
963
964         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
965         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
966
967         * WebView/WebPreferenceKeysPrivate.h:
968         * WebView/WebPreferences.mm:
969         (+[WebPreferences initialize]):
970         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
971         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
972         * WebView/WebPreferencesPrivate.h:
973         * WebView/WebView.mm:
974         (-[WebView _preferencesChanged:]):
975
976 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
977
978         Remove ForwardingHeaders directory from WebKitLegacy/mac.
979         https://bugs.webkit.org/show_bug.cgi?id=182738
980
981         Reviewed by Darin Adler.
982
983         * ForwardingHeaders/collector/handles/Global.h: Removed.
984         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
985         * ForwardingHeaders/runtime/Completion.h: Removed.
986         * ForwardingHeaders/runtime/Error.h: Removed.
987         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
988         * ForwardingHeaders/runtime/JSFunction.h: Removed.
989         * ForwardingHeaders/runtime/JSLock.h: Removed.
990         * ForwardingHeaders/runtime/JSObject.h: Removed.
991         * ForwardingHeaders/runtime/JSString.h: Removed.
992         * ForwardingHeaders/runtime/Protect.h: Removed.
993         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
994
995 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
996
997         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
998         https://bugs.webkit.org/show_bug.cgi?id=182641
999
1000         Reviewed by Dan Bernstein.
1001
1002         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
1003         https://trac.webkit.org/changeset/228308.
1004
1005         * WebView/WebVideoFullscreenController.h:
1006         * WebView/WebVideoFullscreenHUDWindowController.mm:
1007         * WebView/WebWindowAnimation.h:
1008         * WebView/WebWindowAnimation.mm:
1009         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
1010         (WebCore::scaledRect): Deleted.
1011         (WebCore::squaredDistance): Deleted.
1012
1013 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
1014
1015         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
1016
1017         * WebView/WebWindowAnimation.mm:
1018         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
1019
1020 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
1021
1022         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
1023         https://bugs.webkit.org/show_bug.cgi?id=182615
1024
1025         Reviewed by Eric Carlson.
1026
1027         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
1028         Ideally, we should not reference NSApp in WebCore.
1029
1030         * WebView/WebFullScreenController.mm:
1031         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
1032         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
1033         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
1034         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
1035         * WebView/WebView.mm:
1036         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
1037         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
1038
1039 2018-01-13  Darin Adler  <darin@apple.com>
1040
1041         Event improvements
1042         https://bugs.webkit.org/show_bug.cgi?id=179591
1043
1044         Reviewed by Chris Dumez.
1045
1046         * DOM/DOMWheelEvent.mm:
1047         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
1048         Call initWebKitWheelEvent.
1049
1050         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
1051         * WebCoreSupport/WebInspectorClient.mm: Ditto.
1052         * WebView/WebFrame.mm: Ditto.
1053
1054         * WebView/WebHTMLView.mm:
1055         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
1056         underlyingPlatformEvent.
1057         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
1058
1059         * WebView/WebScriptWorld.mm:
1060         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
1061
1062         * WebView/WebView.mm: Removed include of ScriptValue.h.
1063
1064 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1065
1066         Remove WebCore/ForwardingHeaders directory
1067         https://bugs.webkit.org/show_bug.cgi?id=182347
1068
1069         Reviewed by Keith Miller.
1070
1071         * Carbon/CarbonWindowAdapter.mm:
1072         * DOM/WebDOMOperations.mm:
1073         * History/WebBackForwardList.mm:
1074         * History/WebHistoryItem.mm:
1075         * Misc/WebCache.mm:
1076         * Misc/WebElementDictionary.mm:
1077         * Misc/WebIconDatabase.mm:
1078         * Misc/WebStringTruncator.mm:
1079         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1080         * Plugins/Hosted/ProxyInstance.mm:
1081         * Plugins/Hosted/ProxyRuntimeObject.mm:
1082         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1083         * Plugins/WebBaseNetscapePluginView.mm:
1084         * Plugins/WebBasePluginPackage.mm:
1085         * Plugins/WebNetscapePluginStream.mm:
1086         * Plugins/WebNetscapePluginView.mm:
1087         * Plugins/WebPluginController.mm:
1088         * WebCoreSupport/WebEditorClient.mm:
1089         * WebCoreSupport/WebFrameLoaderClient.mm:
1090         * WebCoreSupport/WebInspectorClient.h:
1091         * WebCoreSupport/WebInspectorClient.mm:
1092         * WebView/WebDataSource.mm:
1093         * WebView/WebFrame.mm:
1094         * WebView/WebHTMLRepresentation.mm:
1095         * WebView/WebHTMLView.mm:
1096         * WebView/WebPreferences.mm:
1097         * WebView/WebScriptDebugDelegate.mm:
1098         * WebView/WebScriptDebugger.h:
1099         * WebView/WebTextIterator.mm:
1100         * WebView/WebView.mm:
1101         * WebView/WebViewData.mm:
1102
1103 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1104
1105         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1106         https://bugs.webkit.org/show_bug.cgi?id=182312
1107
1108         Reviewed by Michael Catanzaro.
1109
1110         * WebKitPrefix.h:
1111
1112 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1113
1114         [WebAuthN] Add a compile-time feature flag
1115         https://bugs.webkit.org/show_bug.cgi?id=182211
1116         <rdar://problem/36936365>
1117
1118         Reviewed by Brent Fulgham.
1119
1120         * Configurations/FeatureDefines.xcconfig:
1121
1122 2018-01-27  Dan Bernstein  <mitz@apple.com>
1123
1124         HaveInternalSDK includes should be "#include?"
1125         https://bugs.webkit.org/show_bug.cgi?id=179670
1126
1127         * Configurations/Base.xcconfig:
1128
1129 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1130
1131         Remove unused QTKit preference
1132         https://bugs.webkit.org/show_bug.cgi?id=181968
1133
1134         Reviewed by Alexey Proskuryakov.
1135
1136         * WebView/WebPreferenceKeysPrivate.h:
1137         * WebView/WebPreferences.mm:
1138         (+[WebPreferences initialize]):
1139         (-[WebPreferences setQTKitEnabled:]): Deleted.
1140         (-[WebPreferences isQTKitEnabled]): Deleted.
1141         * WebView/WebPreferencesPrivate.h:
1142         * WebView/WebView.mm:
1143         (-[WebView _preferencesChanged:]):
1144
1145 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1146
1147         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
1148         https://bugs.webkit.org/show_bug.cgi?id=182037
1149         <rdar://problem/36747812>
1150
1151         Reviewed by Ryosuke Niwa.
1152
1153         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
1154         for more details.
1155
1156         * WebView/WebHTMLRepresentation.mm:
1157         (-[WebHTMLRepresentation elementWithName:inForm:]):
1158         (-[WebHTMLRepresentation controlsInForm:]):
1159
1160 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1161
1162         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
1163         https://bugs.webkit.org/show_bug.cgi?id=181961
1164
1165         Reviewed by Michael Catanzaro.
1166
1167         * WebView/WebPreferences.mm:
1168
1169 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1170
1171         Unreviewed, rolling out r227437.
1172         https://bugs.webkit.org/show_bug.cgi?id=182011
1173
1174         broke build (Requested by alexchristensen on #webkit).
1175
1176         Reverted changeset:
1177
1178         "Remove unused QTKit preference"
1179         https://bugs.webkit.org/show_bug.cgi?id=181968
1180         https://trac.webkit.org/changeset/227437
1181
1182 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1183
1184         Remove unused QTKit preference
1185         https://bugs.webkit.org/show_bug.cgi?id=181968
1186
1187         Reviewed by Alexey Proskuryakov.
1188
1189         * WebView/WebPreferenceKeysPrivate.h:
1190         * WebView/WebPreferences.mm:
1191         (+[WebPreferences initialize]):
1192         (-[WebPreferences setQTKitEnabled:]): Deleted.
1193         (-[WebPreferences isQTKitEnabled]): Deleted.
1194         * WebView/WebPreferencesPrivate.h:
1195         * WebView/WebView.mm:
1196         (-[WebView _preferencesChanged:]):
1197
1198 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1199
1200         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
1201         https://bugs.webkit.org/show_bug.cgi?id=181960
1202         <rdar://problem/36431678>
1203
1204         Reviewed by Tim Horton.
1205
1206         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1207         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1208         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1209
1210         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1211         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1212         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1213
1214         * WebView/WebView.mm:
1215         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1216
1217 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1218
1219         Turning off custom pasteboard data doesn't actually turn it off in WK2
1220         https://bugs.webkit.org/show_bug.cgi?id=181920
1221         <rdar://problem/36686429>
1222
1223         Reviewed by Wenson Hsieh.
1224
1225         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1226
1227         * WebView/WebPreferences.mm:
1228         (+[WebPreferences initialize]):
1229         * WebView/WebView.mm:
1230         (-[WebView _preferencesChanged:]):
1231
1232 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1233
1234         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1235         https://bugs.webkit.org/show_bug.cgi?id=181918
1236
1237         Reviewed by Tim Horton.
1238
1239         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1240
1241         * Configurations/FeatureDefines.xcconfig:
1242
1243 2018-01-20  Andy Estes  <aestes@apple.com>
1244
1245         [Apple Pay] Stop eagerly loading PassKit.framework
1246         https://bugs.webkit.org/show_bug.cgi?id=181911
1247         <rdar://problem/36555369>
1248
1249         Reviewed by Tim Horton.
1250
1251         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1252         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1253         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1254
1255         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1256
1257 2018-01-19  Dean Jackson  <dino@apple.com>
1258
1259         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1260         https://bugs.webkit.org/show_bug.cgi?id=181817
1261         <rdar://problem/35274055>
1262
1263         Reviewed by Simon Fraser.
1264
1265         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1266
1267         * Misc/WebKitVersionChecks.h:
1268         * WebView/WebView.mm:
1269         (-[WebView _commonInitializationWithFrameName:groupName:]):
1270
1271 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1272
1273         Remove unused WebViewPrivate _allowCookies
1274         https://bugs.webkit.org/show_bug.cgi?id=181812
1275
1276         Reviewed by Tim Horton.
1277
1278         * WebView/WebView.mm:
1279         (+[WebView _setAllowCookies:]): Deleted.
1280         (+[WebView _allowCookies]): Deleted.
1281         * WebView/WebViewPrivate.h:
1282
1283 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1284
1285         Build fix, remove a call to -[NSWindow setOneShot:]
1286         https://bugs.webkit.org/show_bug.cgi?id=181809
1287
1288         Reviewed by Tim Horton.
1289
1290         * WebView/WebTextCompletionController.mm:
1291         (-[WebTextCompletionController _buildUI]):
1292
1293 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1294
1295         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1296
1297         * Carbon/HIWebView.mm:
1298         (overrideCGContext):
1299         (restoreCGContext):
1300
1301 2018-01-18  Dan Bernstein  <mitz@apple.com>
1302
1303         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1304         https://bugs.webkit.org/show_bug.cgi?id=181803
1305
1306         Reviewed by Tim Horton.
1307
1308         * Configurations/Base.xcconfig: Updated.
1309         * Configurations/DebugRelease.xcconfig: Ditto.
1310         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1311         * Configurations/Version.xcconfig: Updated.
1312         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1313           useful for defining settings that depend on the target macOS version.
1314
1315 2018-01-17  Youenn Fablet  <youenn@apple.com>
1316
1317         Put fetch Request.keepalive behind a runtime flag
1318         https://bugs.webkit.org/show_bug.cgi?id=181592
1319
1320         Reviewed by Chris Dumez.
1321
1322         * WebView/WebPreferenceKeysPrivate.h:
1323         * WebView/WebPreferences.mm:
1324         (+[WebPreferences initialize]):
1325         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1326         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1327         * WebView/WebPreferencesPrivate.h:
1328         * WebView/WebView.mm:
1329         (-[WebView _preferencesChanged:]):
1330
1331 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1332
1333         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1334         https://bugs.webkit.org/show_bug.cgi?id=181637
1335         <rdar://problem/36508471>
1336
1337         Reviewed by Tim Horton.
1338
1339         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1340
1341         * WebCoreSupport/WebEditorClient.h:
1342         * WebCoreSupport/WebEditorClient.mm:
1343         (WebEditorClient::replacementURLForResource):
1344
1345 2018-01-11  Keith Miller  <keith_miller@apple.com>
1346
1347         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1348         https://bugs.webkit.org/show_bug.cgi?id=181573
1349
1350         Reviewed by Simon Fraser.
1351
1352         * Configurations/FeatureDefines.xcconfig:
1353
1354 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1355
1356         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1357         https://bugs.webkit.org/show_bug.cgi?id=181497
1358
1359         Reviewed by Tim Horton.
1360
1361         See other ChangeLogs for more detail.
1362
1363         * WebCoreSupport/WebDragClient.h:
1364
1365 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1366
1367         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1368         https://bugs.webkit.org/show_bug.cgi?id=181523
1369         <rdar://problem/28959131>
1370
1371         Reviewed by Alex Christensen.
1372
1373         * WebView/WebImmediateActionController.mm:
1374         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1375         Apply the change made in r216652 to WebKit1's immediate action controller.
1376
1377         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1378         the startContainer of the range is in an anonymous node.
1379
1380 2018-01-11  Youenn Fablet  <youenn@apple.com>
1381
1382         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1383         https://bugs.webkit.org/show_bug.cgi?id=181480
1384
1385         Reviewed by Eric Carlson.
1386
1387         * WebView/WebPreferences.mm:
1388         (+[WebPreferences initialize]):
1389
1390 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1391
1392         Fix check-webkit-style issues with WebNSDataExtras.mm
1393         <https://webkit.org/b/181369>
1394
1395         Reviewed by Alex Christensen.
1396
1397         * Misc/WebNSDataExtras.mm:
1398         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1399         (-[NSData _webkit_guessedMIMETypeForXML]):
1400         (-[NSData _webkit_guessedMIMEType]):
1401         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1402         (_findEOL):
1403         (-[NSData _webkit_parseRFC822HeaderFields]):
1404         (-[NSData _web_locationAfterFirstBlankLine]):
1405         - Fix all the check-webkit-style warnings.
1406
1407 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1408
1409         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1410         <https://webkit.org/b/181256>
1411         <rdar://problem/36281730>
1412
1413         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1414         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1415         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1416           to avoid warnings from casting CFStringRef to NPNSString*.
1417           Note that CFMutableStringRef is the same as CFStringRef
1418           without the const modifier, hence its use in the const_cast<>
1419           above.
1420
1421 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1422
1423         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1424         <https://webkit.org/b/181256>
1425         <rdar://problem/36281730>
1426
1427         * Carbon/HIWebView.mm:
1428         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1429         checked_cf_cast<CFRunLoopRef>() to fix warning.
1430
1431 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1432
1433         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1434         <https://webkit.org/b/181256>
1435         <rdar://problem/36281730>
1436
1437         Reviewed by Darin Adler.
1438
1439         * Carbon/CarbonUtils.m:
1440         (PoolCleaner):
1441         - Use #pragmas to ignore -Wcast-qual warnings when using a
1442           C-style cast from CFTypeRef to CFRunloopRef.
1443         * Carbon/CarbonWindowFrame.m:
1444         (-[CarbonWindowFrame title]):
1445         - Use #pragmas to ignore -Wcast-qual warnings when using a
1446           C-style cast from CFStringRef to NSString *.
1447         * Carbon/HIViewAdapter.m:
1448         (+[HIViewAdapter getHIViewForNSView:]):
1449         - Use #pragmas to ignore -Wcast-qual warnings when using a
1450           C-style cast from CFTypeRef to HIViewRef.
1451         * Configurations/Base.xcconfig:
1452         (WARNING_CFLAGS): Add -Wcast-qual.
1453         * Misc/WebElementDictionary.mm:
1454         (-[WebElementDictionary objectForKey:]):
1455         - Use static_cast<SEL>(const_cast<void*>()) to fix
1456           warning.
1457         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1458         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1459         (-[NSData _webkit_guessedMIMETypeForXML]):
1460         (-[NSData _webkit_guessedMIMEType]):
1461         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1462         (_findEOL):
1463         (-[NSData _webkit_parseRFC822HeaderFields]):
1464         (-[NSData _web_startsWithBlankLine]):
1465         (-[NSData _web_locationAfterFirstBlankLine]):
1466         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1467           type to Objective-C++.  This fixes the warnings about
1468           discarding the `const` modifier when casing from CFStringRef
1469           to NSString * because in older clang versions, -Wcast-qual was
1470           completely broken when compiling C++ and Objective-C++ source
1471           files.  In newer clang versions, discarding the `const`
1472           modifier for toll-free bridged types is ignored when compiling
1473           Objective-C++ source.
1474         - Update copyright and license header.
1475         - Use reinterpret_cast<> and static_cast<> to fix warnings
1476           unrelated to (NSString *) C-style casts.
1477         - Replace use of MIN() macro with std::min<> template functions.
1478         - Fix location of `*` for local variables modified above.
1479         * Plugins/Hosted/NetscapePluginHostManager.mm:
1480         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1481         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1482         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1483         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1484           warnings.
1485         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1486         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1487         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1488           to fix warning.
1489         * Plugins/Hosted/ProxyInstance.mm:
1490         (WebKit::ProxyInstance::invoke):
1491         - Use static_cast<char*>(const_cast<void*>()) to fix
1492           warning when using -[NSData bytes].
1493         (WebKit::ProxyInstance::fieldValue const):
1494         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1495           to fix warning when using CFDataGetBytePtr().
1496         * Plugins/Hosted/WebTextInputWindowController.m:
1497         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1498         - Use #pragma to ignore -Wcast-qual warning since there
1499           is not a good way to avoid this warning in Objective-C.
1500         * Plugins/WebNetscapePluginStream.mm:
1501         (WebNetscapePluginStream::deliverData):
1502         - Use const_cast<void*>() to fix warning when using
1503           -[NSData bytes].
1504         * Plugins/WebNetscapePluginView.mm:
1505         (-[WebNetscapePluginView _createPlugin]):
1506         - Change C-style cast to const_cast<char*>() to fix
1507           warning.
1508         * WebCoreSupport/WebChromeClient.mm:
1509         (WebChromeClient::wrapCryptoKey const):
1510         (WebChromeClient::unwrapCryptoKey const):
1511         - Change C-style cast to
1512           static_cast<uint8_t*>(const_cast<void*>() to fix
1513           warning.
1514         * WebView/WebPDFView.mm:
1515         (_applicationInfoForMIMEType):
1516         - Change local variable type from 'NSURL *' to
1517           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1518           when calling -[NSURL path].
1519
1520 2018-01-05  Dan Bernstein  <mitz@apple.com>
1521
1522         Fixed the build following AppKit API deprecations in a recent SDKs
1523
1524         * WebView/WebFullScreenController.mm:
1525         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1526         (-[WebFullScreenController exitFullScreen]): Ditto.
1527         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1528         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1529         * WebView/WebHTMLView.mm:
1530         (-[WebHTMLView drawRect:]): Ditto.
1531         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1532         (-[WebHTMLView knowsPageRange:]): Ditto.
1533         * WebView/WebView.mm:
1534         (LayerFlushController::flushLayers): Ditto.
1535
1536 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1537
1538         [Attachment Support] Create attachment elements when dropping files on iOS
1539         https://bugs.webkit.org/show_bug.cgi?id=181192
1540         <rdar://problem/36280945>
1541
1542         Reviewed by Tim Horton.
1543
1544         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1545
1546         * WebCoreSupport/WebPlatformStrategies.h:
1547         * WebCoreSupport/WebPlatformStrategies.mm:
1548         (WebPlatformStrategies::informationForItemAtIndex):
1549         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1550
1551 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1552
1553         [Attachment Support] Add plumbing for starting a drag with promised blob data
1554         https://bugs.webkit.org/show_bug.cgi?id=181201
1555
1556         Reviewed by Tim Horton.
1557
1558         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1559
1560         * WebCoreSupport/WebDragClient.h:
1561
1562 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1563
1564         Add a WebAuthentication runtime feature flag
1565         https://bugs.webkit.org/show_bug.cgi?id=181220
1566         <rdar://problem/36055305>
1567
1568         Reviewed by Brent Fulgham.
1569
1570         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1571
1572         * WebView/WebPreferenceKeysPrivate.h:
1573         * WebView/WebPreferences.mm:
1574         (+[WebPreferences initialize]):
1575         (-[WebPreferences webAuthenticationEnabled]):
1576         (-[WebPreferences setWebAuthenticationEnabled:]):
1577         (-[WebPreferences credentialManagementEnabled]): Deleted.
1578         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1579         * WebView/WebPreferencesPrivate.h:
1580         * WebView/WebView.mm:
1581         (-[WebView _preferencesChanged:]):
1582
1583 2017-12-22  Jeff Miller  <jeffm@apple.com>
1584
1585         Update user-visible copyright strings to include 2018
1586         https://bugs.webkit.org/show_bug.cgi?id=181141
1587
1588         Reviewed by Dan Bernstein.
1589
1590         * Info.plist:
1591
1592 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1593
1594         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1595         https://bugs.webkit.org/show_bug.cgi?id=181188
1596
1597         Reviewed by Dan Bernstein.
1598
1599         See WebCore/ChangeLog for more detail.
1600
1601         * WebCoreSupport/WebDragClient.h:
1602         * WebCoreSupport/WebDragClient.mm:
1603         (WebDragClient::declareAndWriteAttachment): Deleted.
1604         * WebView/WebHTMLView.mm:
1605         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1606
1607 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1608
1609         Unreviewed, continue to fix build failures due to AppKit API deprecation
1610
1611         Wraps more code in -Wdeprecated-declarations.
1612
1613         * Carbon/HIWebView.mm:
1614         (overrideCGContext):
1615
1616 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1617
1618         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1619
1620         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1621
1622         * Carbon/CarbonWindowAdapter.mm:
1623         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1624         * Plugins/WebNetscapePluginView.mm:
1625         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1626         (-[WebNetscapePluginView sendDrawRectEvent:]):
1627         (-[WebNetscapePluginView drawRect:]):
1628
1629 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1630
1631         Fix build failures due to using deprecated AppKit symbols
1632         https://bugs.webkit.org/show_bug.cgi?id=181110
1633         <rdar://problem/36162865>
1634
1635         Reviewed by Dan Bernstein and Tim Horton.
1636
1637         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1638
1639         * Misc/WebKitNSStringExtras.mm:
1640         (-[NSString _web_drawAtPoint:font:textColor:]):
1641         * Misc/WebNSPasteboardExtras.h:
1642         * Misc/WebNSPasteboardExtras.mm:
1643         (+[NSPasteboard _web_writableTypesForURL]):
1644         (_createWritableTypesForImageWithoutArchive):
1645         (_createWritableTypesForImageWithArchive):
1646         (+[NSPasteboard _web_dragTypesForURL]):
1647         (-[NSPasteboard _web_bestURL]):
1648         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1649         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1650         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1651         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1652         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1653         * Panels/WebAuthenticationPanel.m:
1654         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1655         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1656         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1657         (-[WebHostedNetscapePluginView drawRect:]):
1658         * WebInspector/WebNodeHighlightView.mm:
1659         (-[WebNodeHighlightView drawRect:]):
1660         * WebView/WebFrame.mm:
1661         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1662         (-[WebFrame _drawRect:contentsOnly:]):
1663         * WebView/WebHTMLView.mm:
1664         (kit):
1665         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1666         (-[WebHTMLView _plainTextFromPasteboard:]):
1667         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1668         (+[WebHTMLView _insertablePasteboardTypes]):
1669         (+[WebHTMLView _selectionPasteboardTypes]):
1670         (-[WebHTMLView pasteboard:provideDataForType:]):
1671         (-[WebHTMLView _writeSelectionToPasteboard:]):
1672         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1673         (-[WebHTMLView validRequestorForSendType:returnType:]):
1674         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1675         (createMenuItem):
1676         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1677         (-[WebHTMLView _colorAsString:]):
1678         (-[WebHTMLView copyFont:]):
1679         * WebView/WebPDFView.mm:
1680         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1681         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1682         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1683         (-[WebPDFView pasteboardTypesForSelection]):
1684         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1685         * WebView/WebView.h:
1686         * WebView/WebView.mm:
1687         (-[WebView performDragOperation:]):
1688         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1689         (-[WebView _searchWithGoogleFromMenu:]):
1690
1691 2017-12-21  Youenn Fablet  <youenn@apple.com>
1692
1693         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1694         https://bugs.webkit.org/show_bug.cgi?id=181000
1695
1696         Reviewed by Chris Dumez.
1697
1698         * Misc/WebCache.mm:
1699         (+[WebCache addImageToCache:forURL:forFrame:]):
1700
1701 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1702
1703         Update FULLSCREEN_API feature defines.
1704         https://bugs.webkit.org/show_bug.cgi?id=181015
1705
1706         Reviewed by Tim Horton.
1707
1708         Change enabled iphone sdk for FULLSCREEN_API.
1709
1710         * Configurations/FeatureDefines.xcconfig:
1711
1712 2017-12-21  Jer Noble  <jer.noble@apple.com>
1713
1714         Add initial DOM support for Media Capabilities
1715         https://bugs.webkit.org/show_bug.cgi?id=181064
1716
1717         Reviewed by Eric Carlson.
1718
1719         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1720
1721         * WebView/WebPreferenceKeysPrivate.h:
1722         * WebView/WebPreferences.mm:
1723         (+[WebPreferences initialize]):
1724         (-[WebPreferences mediaCapabilitiesEnabled]):
1725         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1726         * WebView/WebPreferencesPrivate.h:
1727         * WebView/WebView.mm:
1728         (-[WebView _preferencesChanged:]):
1729
1730 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1731
1732         Enable picture-in-picture from inline element on suspend.
1733         https://bugs.webkit.org/show_bug.cgi?id=180942
1734         rdar://problem/34745234
1735
1736         Reviewed by Jer Noble.
1737
1738         Update signature of enterVideoFullscreenForVideoElement().
1739
1740         * WebCoreSupport/WebChromeClient.h:
1741         * WebCoreSupport/WebChromeClient.mm:
1742         (WebChromeClient::enterVideoFullscreenForVideoElement):
1743
1744 2017-12-20  Daniel Bates  <dabates@apple.com>
1745
1746         Remove Alternative Presentation Button
1747         https://bugs.webkit.org/show_bug.cgi?id=180500
1748         <rdar://problem/35891047>
1749
1750         Reviewed by Simon Fraser.
1751
1752         We no longer need the alternative presentation button.
1753
1754         * Configurations/FeatureDefines.xcconfig:
1755
1756 2017-12-19  Jer Noble  <jer.noble@apple.com>
1757
1758         Playing media elements which call "pause(); play()" will have the play promise rejected.
1759         https://bugs.webkit.org/show_bug.cgi?id=180781
1760         <rdar://problem/33191377>
1761
1762         Reviewed by Eric Carlson.
1763
1764         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1765
1766         * WebView/WebView.mm:
1767         (shouldRequireUserGestureToLoadVideo):
1768
1769 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1770
1771         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1772         https://bugs.webkit.org/show_bug.cgi?id=180977
1773
1774         Reviewed by Tim Horton.
1775
1776         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1777         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1778         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1779
1780         * WebCoreSupport/WebEditorClient.mm:
1781         (attributesForAttributedStringConversion):
1782         * WebView/WebHTMLView.mm:
1783         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1784
1785 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1786
1787         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1788
1789         Attempt to fix the following warnings:
1790
1791             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1792
1793         For the following instance variables:
1794
1795             _borderView
1796             _contentView
1797             _frame
1798             _wFlags
1799
1800         * Carbon/CarbonWindowAdapter.mm:
1801         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1802         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1803         (-[CarbonWindowAdapter _termWindowIfOwner]):
1804         (-[CarbonWindowAdapter _windowMovedToRect:]):
1805         (-[CarbonWindowAdapter setContentView:]):
1806         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1807         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1808
1809 2017-12-16  Dan Bernstein  <mitz@apple.com>
1810
1811         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1812         https://bugs.webkit.org/show_bug.cgi?id=180613
1813         <rdar://problem/35946124>
1814
1815         Reviewed by Geoff Garen.
1816
1817         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1818           clients.
1819         * WebView/WebDynamicScrollBarsView.h: Ditto.
1820         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1821
1822 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1823
1824         Enable -Wstrict-prototypes for WebKit
1825         <https://webkit.org/b/180757>
1826         <rdar://problem/36024132>
1827
1828         Rubber-stamped by Joseph Pecoraro.
1829
1830         * Configurations/Base.xcconfig:
1831         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1832
1833 2017-12-14  John Wilander  <wilander@apple.com>
1834
1835         Storage Access API: Implement frame-specific access in the document.cookie layer
1836         https://bugs.webkit.org/show_bug.cgi?id=180682
1837         <rdar://problem/35982257>
1838
1839         Reviewed by Alex Christensen.
1840
1841         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1842         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1843         CookiesStrategy::getRawCookies() now take optional parameters for
1844         frameID and pageID to allow frame-specific scoping of cookies.
1845
1846         This change makes the return values of FrameLoaderClient::frameID()
1847         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1848         WebCore can call those getters and get the right return values in
1849         WebKit and std:nullopt in WebKitLegacy.
1850
1851         * WebCoreSupport/WebFrameLoaderClient.h:
1852         * WebCoreSupport/WebFrameLoaderClient.mm:
1853         (WebFrameLoaderClient::pageID const):
1854         (WebFrameLoaderClient::frameID const):
1855         * WebCoreSupport/WebPlatformStrategies.h:
1856         * WebCoreSupport/WebPlatformStrategies.mm:
1857         (WebPlatformStrategies::cookiesForDOM):
1858         (WebPlatformStrategies::setCookiesFromDOM):
1859         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1860         (WebPlatformStrategies::getRawCookies):
1861
1862 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1863
1864         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1865         https://bugs.webkit.org/show_bug.cgi?id=180689
1866
1867         Reviewed by Tim Horton.
1868
1869         Use sRGBColorSpaceRef() from WebCore.
1870
1871         * WebView/WebHTMLView.mm:
1872         (imageFromRect):
1873
1874 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1875
1876         Stop using deprecated target conditional for simulator builds
1877         https://bugs.webkit.org/show_bug.cgi?id=180662
1878         <rdar://problem/35136156>
1879
1880         Reviewed by Simon Fraser.
1881
1882         * postprocess-headers.sh:
1883
1884 2017-12-11  David Quesada  <david_quesada@apple.com>
1885
1886         Turn on ENABLE_APPLICATION_MANIFEST
1887         https://bugs.webkit.org/show_bug.cgi?id=180562
1888         rdar://problem/35924737
1889
1890         Reviewed by Geoffrey Garen.
1891
1892         * Configurations/FeatureDefines.xcconfig:
1893
1894 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1895
1896         Remove pthread_once in favor of dispatch_once
1897         https://bugs.webkit.org/show_bug.cgi?id=180591
1898
1899         Reviewed by Saam Barati.
1900
1901         * Misc/WebKitErrors.m:
1902         (+[NSError _registerWebKitErrors]):
1903         (registerErrors): Deleted.
1904         * Storage/WebStorageManager.mm:
1905         (+[WebStorageManager _storageDirectoryPath]):
1906         (initializeLocalStoragePath): Deleted.
1907
1908 2017-12-07  Darin Adler  <darin@apple.com>
1909
1910         Remove some unused code from WebKitLegacy
1911         https://bugs.webkit.org/show_bug.cgi?id=180567
1912
1913         Reviewed by Anders Carlsson.
1914
1915         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1916         macOS (back a few versions) and iOS and removed unused
1917         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1918         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1919         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1920         _webkit_stringByCollapsingNonPrintingCharacters,
1921         _webkit_stringByCollapsingWhitespaceCharacters,
1922         _web_stringWithData:textEncodingName:, and
1923         _webkit_localStorageDirectoryWithBundleIdentifier:.
1924
1925         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1926         this source file.
1927         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1928         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1929         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1930         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1931         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1932         handle font smoothing options.
1933         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1934         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1935         from header and made it a little clearer.
1936         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1937         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1938         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1939         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1940         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1941         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1942         implementation a bit and used whole words instead of abbreviations.
1943         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1944
1945         * Misc/WebNSFileManagerExtras.mm:
1946         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1947         filenameByFixingIllegalCharacters function from WebCore directly instead of
1948         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1949
1950         * Plugins/WebBaseNetscapePluginView.mm:
1951         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1952         string replacements instead of _web_stringByStrippingReturnCharacters
1953         and to use NSString methods instead of CFString functions.
1954
1955 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1956
1957         Ignore deprecation warnings.
1958
1959         * WebView/WebHTMLView.mm:
1960         (-[NSWindow _web_borderView]):
1961         (-[WebHTMLView _setAsideSubviews]):
1962         * WebView/WebView.mm:
1963         (-[WebView encodeWithCoder:]):
1964
1965 2017-12-02  Darin Adler  <darin@apple.com>
1966
1967         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1968         https://bugs.webkit.org/show_bug.cgi?id=180009
1969
1970         Reviewed by Alex Christensen.
1971
1972         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1973
1974         * Plugins/WebBaseNetscapePluginView.mm:
1975         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1976         of strcasecmp.
1977
1978         * WebView/WebPreferences.mm:
1979         (contains): Ditto. Also made this a template so it's easier to call on an array.
1980         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1981
1982 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1983
1984         Limit user agent versioning to an upper bound
1985         https://bugs.webkit.org/show_bug.cgi?id=180365
1986         <rdar://problem/34550617>
1987
1988         Reviewed by Joseph Pecoraro.
1989
1990         * WebView/WebView.mm:
1991         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1992         creating the User Agent string.
1993         (webKitBundleVersionString): Deleted.
1994
1995 2017-12-05  Andy Estes  <aestes@apple.com>
1996
1997         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1998         https://bugs.webkit.org/show_bug.cgi?id=180457
1999         <rdar://problem/35143007>
2000
2001         Reviewed by Tim Horton.
2002
2003         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
2004         check for this macro during post-processing.
2005
2006         * postprocess-headers.sh:
2007
2008 2017-12-04  David Quesada  <david_quesada@apple.com>
2009
2010         Add a class for parsing application manifests
2011         https://bugs.webkit.org/show_bug.cgi?id=177973
2012         rdar://problem/34747949
2013
2014         Reviewed by Geoffrey Garen.
2015
2016         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
2017
2018 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
2019
2020         Make LegacyCustomProtocolManager optional for network process
2021         https://bugs.webkit.org/show_bug.cgi?id=176230
2022
2023         Reviewed by Alex Christensen.
2024
2025         * Configurations/FeatureDefines.xcconfig:
2026
2027 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
2028
2029         Fix some NSOperationQueue leaks
2030         https://bugs.webkit.org/show_bug.cgi?id=180221
2031
2032         Reviewed by Wenson Hsieh.
2033
2034         * WebView/WebView.mm:
2035         (-[WebView performDragOperation:]):
2036
2037 2017-11-30  Darin Adler  <darin@apple.com>
2038
2039         [Mac] remove unneeded RetainPtr use introduced in r225142
2040         https://bugs.webkit.org/show_bug.cgi?id=180202
2041
2042         Reviewed by Tim Horton.
2043
2044         * WebView/WebImmediateActionController.mm:
2045         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
2046         RetainPtr.
2047
2048 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
2049
2050         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
2051         https://bugs.webkit.org/show_bug.cgi?id=175595
2052
2053         Reviewed by Darin Adler.
2054
2055         * WebView/WebPreferences.mm:
2056
2057 2017-11-27  Tim Horton  <timothy_horton@apple.com>
2058
2059         One too many zeroes in macOS version number in FeatureDefines
2060         https://bugs.webkit.org/show_bug.cgi?id=180011
2061
2062         Reviewed by Dan Bernstein.
2063
2064         * Configurations/FeatureDefines.xcconfig:
2065
2066 2017-11-23  Darin Adler  <darin@apple.com>
2067
2068         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2069         https://bugs.webkit.org/show_bug.cgi?id=179981
2070
2071         Reviewed by Sam Weinig.
2072
2073         * WebView/WebImmediateActionController.mm:
2074         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
2075         * WebView/WebView.mm:
2076         (coreOptions): Use |= instead of | to build up FindOptions.
2077
2078 2017-11-23  Sam Weinig  <sam@webkit.org>
2079
2080         Remove unneeded ScriptController::processingUserGesture() forwarding functions
2081         https://bugs.webkit.org/show_bug.cgi?id=179954
2082
2083         Reviewed by Darin Adler.
2084
2085         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
2086         with direct calls to the corresponding UserGestureIndicator functions.
2087
2088         * Plugins/WebPluginController.mm:
2089         (-[WebPluginController processingUserGesture]):
2090         * WebView/WebView.mm:
2091         (-[WebView _isProcessingUserGesture]):
2092
2093 2017-11-23  Darin Adler  <darin@apple.com>
2094
2095         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2096         https://bugs.webkit.org/show_bug.cgi?id=179907
2097
2098         Reviewed by Sam Weinig.
2099
2100         * History/BinaryPropertyList.cpp:
2101         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
2102         (BinaryPropertyListSerializer::appendStringObject): Ditto.
2103         * WebView/WebHTMLRepresentation.mm:
2104         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
2105         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
2106
2107 2017-11-22  Ali Juma  <ajuma@chromium.org>
2108
2109         Implement VisualViewport API attributes
2110         https://bugs.webkit.org/show_bug.cgi?id=179385
2111
2112         Reviewed by Frédéric Wang.
2113
2114         Add a VisualViewportAPI preference.
2115
2116         * WebView/WebPreferenceKeysPrivate.h:
2117         * WebView/WebPreferences.mm:
2118         (+[WebPreferences initialize]):
2119         (-[WebPreferences visualViewportAPIEnabled]):
2120         (-[WebPreferences setVisualViewportAPIEnabled:]):
2121         * WebView/WebPreferencesPrivate.h:
2122         * WebView/WebView.mm:
2123         (-[WebView _preferencesChanged:]):
2124
2125 2017-11-22  Christopher Reid  <chris.reid@sony.com>
2126
2127         WebCoreObjCExtras.h is being included in too many places
2128         https://bugs.webkit.org/show_bug.cgi?id=179931
2129
2130         Reviewed by Darin Adler.
2131
2132         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2133         * Plugins/WebBaseNetscapePluginView.mm:
2134         * Plugins/WebBasePluginPackage.mm:
2135         * Plugins/WebNetscapePluginStream.mm:
2136         * Plugins/WebNetscapePluginView.mm:
2137         * WebView/WebTextIterator.mm:
2138         * WebView/WebViewData.mm:
2139
2140 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2141
2142         Unreviewed, rolling out r225093.
2143         https://bugs.webkit.org/show_bug.cgi?id=179938
2144
2145         Compilation failed on WinCairo 64-bit Release (Requested by
2146         fredw on #webkit).
2147
2148         Reverted changeset:
2149
2150         "Implement VisualViewport API attributes"
2151         https://bugs.webkit.org/show_bug.cgi?id=179385
2152         https://trac.webkit.org/changeset/225093
2153
2154 2017-11-21  Ali Juma  <ajuma@chromium.org>
2155
2156         Implement VisualViewport API attributes
2157         https://bugs.webkit.org/show_bug.cgi?id=179385
2158
2159         Reviewed by Frédéric Wang.
2160
2161         Add a VisualViewportAPI preference.
2162
2163         * WebView/WebPreferenceKeysPrivate.h:
2164         * WebView/WebPreferences.mm:
2165         (+[WebPreferences initialize]):
2166         (-[WebPreferences visualViewportAPIEnabled]):
2167         (-[WebPreferences setVisualViewportAPIEnabled:]):
2168         * WebView/WebPreferencesPrivate.h:
2169         * WebView/WebView.mm:
2170         (-[WebView _preferencesChanged:]):
2171
2172 2017-11-21  Christopher Reid  <chris.reid@sony.com>
2173
2174         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
2175         https://bugs.webkit.org/show_bug.cgi?id=179504
2176
2177         Reviewed by Darin Adler.
2178
2179         * Misc/WebKitNSStringExtras.mm:
2180         * Plugins/Hosted/NetscapePluginHostManager.mm:
2181         * Plugins/WebBasePluginPackage.mm:
2182
2183 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2184
2185         Remove unused TOUCH_ICON_LOADING feature flag
2186         https://bugs.webkit.org/show_bug.cgi?id=179873
2187
2188         Reviewed by Simon Fraser.
2189
2190         * Configurations/FeatureDefines.xcconfig:
2191
2192 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2193
2194         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2195         https://bugs.webkit.org/show_bug.cgi?id=179872
2196
2197         Reviewed by Darin Adler.
2198
2199         * Configurations/FeatureDefines.xcconfig:
2200
2201 2017-11-16  Daniel Bates  <dabates@apple.com>
2202
2203         Add feature define for alternative presentation button element
2204         https://bugs.webkit.org/show_bug.cgi?id=179692
2205         Part of <rdar://problem/34917108>
2206
2207         Reviewed by Andy Estes.
2208
2209         Only enabled on Cocoa platforms by default.
2210
2211         * Configurations/FeatureDefines.xcconfig:
2212
2213 2017-11-14  Nan Wang  <n_wang@apple.com>
2214
2215         AX: AOM: Implement AccessibleNode class and support label and role attributes
2216         https://bugs.webkit.org/show_bug.cgi?id=179494
2217
2218         Reviewed by Ryosuke Niwa.
2219
2220         * WebView/WebPreferenceKeysPrivate.h:
2221         * WebView/WebPreferences.mm:
2222         (+[WebPreferences initialize]):
2223         (-[WebPreferences accessibilityObjectModelEnabled]):
2224         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2225         * WebView/WebPreferencesPrivate.h:
2226         * WebView/WebView.mm:
2227         (-[WebView _preferencesChanged:]):
2228
2229 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2230
2231         Remove Cocoa CFURLConnection loading code
2232         https://bugs.webkit.org/show_bug.cgi?id=179688
2233
2234         Reviewed by Antti Koivisto.
2235
2236         * Misc/WebDownload.mm:
2237         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2238         * Misc/WebDownloadInternal.h:
2239         * Plugins/WebBaseNetscapePluginView.mm:
2240         * WebCoreSupport/WebFrameLoaderClient.mm:
2241         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2242         * WebView/WebView.mm:
2243         (-[WebView scheduleInRunLoop:forMode:]):
2244         (-[WebView unscheduleFromRunLoop:forMode:]):
2245
2246 2017-11-14  Daniel Bates  <dabates@apple.com>
2247
2248         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2249         for feature defines
2250
2251         Following r195498 and r201917 the Visual Studio property files for feature defines have
2252         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2253         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2254         files.
2255
2256         * Configurations/FeatureDefines.xcconfig:
2257
2258 2017-11-14  Jer Noble  <jer.noble@apple.com>
2259
2260         Enable Modern EME tests in DumpRenderTree
2261         https://bugs.webkit.org/show_bug.cgi?id=179544
2262
2263         Reviewed by Alex Christensen.
2264
2265         Add a WebPreferences property to enable the (modern) EME API.
2266
2267         * WebView/WebPreferenceKeysPrivate.h:
2268         * WebView/WebPreferences.mm:
2269         (+[WebPreferences initialize]):
2270         (-[WebPreferences encryptedMediaAPIEnabled]):
2271         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2272         * WebView/WebPreferencesPrivate.h:
2273         * WebView/WebView.mm:
2274         (-[WebView _preferencesChanged:]):
2275
2276 2017-11-14  Antti Koivisto  <antti@apple.com>
2277
2278         Enable display:contents by default
2279         https://bugs.webkit.org/show_bug.cgi?id=179655
2280
2281         Reviewed by Sam Weinig.
2282
2283         * WebView/WebPreferences.mm:
2284         (+[WebPreferences initialize]):
2285
2286 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2287
2288         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2289         https://bugs.webkit.org/show_bug.cgi?id=178751
2290
2291         Reviewed by Brady Eidson.
2292
2293         * WebCoreSupport/WebFrameNetworkingContext.mm:
2294         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2295
2296 2017-11-08  Keith Miller  <keith_miller@apple.com>
2297
2298         Async iteration should only fetch the next method once and add feature flag
2299         https://bugs.webkit.org/show_bug.cgi?id=179451
2300
2301         Reviewed by Geoffrey Garen.
2302
2303         Add feature flag for Async iteration.
2304
2305         * Configurations/FeatureDefines.xcconfig:
2306
2307 2017-11-13  Mark Lam  <mark.lam@apple.com>
2308
2309         Add more overflow check book-keeping for MarkedArgumentBuffer.
2310         https://bugs.webkit.org/show_bug.cgi?id=179634
2311         <rdar://problem/35492517>
2312
2313         Reviewed by Saam Barati.
2314
2315         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2316         (WebKit::NetscapePluginInstanceProxy::invoke):
2317         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2318         (WebKit::NetscapePluginInstanceProxy::construct):
2319
2320 2017-11-12  Darin Adler  <darin@apple.com>
2321
2322         More is<> and downcast<>, less static_cast<>
2323         https://bugs.webkit.org/show_bug.cgi?id=179600
2324
2325         Reviewed by Chris Dumez.
2326
2327         * DOM/DOM.mm:
2328         (kit): Use is/downcast.
2329         * WebCoreSupport/WebEditorClient.mm:
2330         (WebEditorClient::handleKeyboardEvent): Ditto.
2331         (WebEditorClient::handleInputMethodKeydown): Ditto.
2332         * WebView/WebHTMLView.mm:
2333         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2334
2335 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2336
2337         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2338         https://bugs.webkit.org/show_bug.cgi?id=179397
2339
2340         Reviewed by Wenson Hsieh.
2341
2342         * DOM/DOMHTMLInputElement.mm:
2343         (-[DOMHTMLInputElement insertTextSuggestion:]):
2344
2345 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2346
2347         HTMLMediaElement should not use element fullscreen on iOS
2348         https://bugs.webkit.org/show_bug.cgi?id=179418
2349         rdar://problem/35409277
2350
2351         Reviewed by Eric Carlson.
2352
2353         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2354
2355         * Configurations/FeatureDefines.xcconfig:
2356
2357 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2358
2359         Make ResourceLoader::willSendRequestInternal asynchronous
2360         https://bugs.webkit.org/show_bug.cgi?id=179251
2361
2362         Reviewed by Andy Estes.
2363
2364         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2365         (WebKit::HostedNetscapePluginStream::start):
2366         * Plugins/WebNetscapePluginStream.mm:
2367         (WebNetscapePluginStream::start):
2368
2369 2017-11-01  Darin Adler  <darin@apple.com>
2370
2371         Simplify event dispatch code and make it a bit more consistent
2372         https://bugs.webkit.org/show_bug.cgi?id=178991
2373
2374         Reviewed by Chris Dumez.
2375
2376         * DOM/DOMEvent.mm:
2377         (-[DOMEvent srcElement]): Call target instead of srcElement.
2378
2379 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2380
2381         [Touch Bar Web API] Add support for menuitem tag
2382         https://bugs.webkit.org/show_bug.cgi?id=179020
2383
2384         Reviewed by Ryosuke Niwa.
2385
2386         Adds in properties and methods that allow the menuitem runtime feature
2387         to be enabled or disabled.
2388
2389         * WebView/WebPreferenceKeysPrivate.h:
2390         * WebView/WebPreferences.mm:
2391         (-[WebPreferences menuItemElementEnabled]):
2392         (-[WebPreferences setMenuItemElementEnabled:]):
2393         * WebView/WebPreferencesPrivate.h:
2394         * WebView/WebView.mm:
2395         (-[WebView _preferencesChanged:]):
2396
2397 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2398
2399         Use CompletionHandlers for redirects
2400         https://bugs.webkit.org/show_bug.cgi?id=179163
2401
2402         Reviewed by Tim Horton.
2403
2404         * Plugins/Hosted/HostedNetscapePluginStream.h:
2405         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2406         (WebKit::HostedNetscapePluginStream::willSendRequest):
2407         * Plugins/WebNetscapePluginStream.h:
2408         * Plugins/WebNetscapePluginStream.mm:
2409         (WebNetscapePluginStream::willSendRequest):
2410
2411 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2412
2413         Add a FileSystem namespace to FileSystem.cpp
2414         https://bugs.webkit.org/show_bug.cgi?id=179063
2415
2416         Reviewed by Darin Adler.
2417
2418         * Misc/WebNSFileManagerExtras.mm:
2419         * Storage/WebDatabaseProvider.mm:
2420
2421 2017-11-02  Frederic Wang  <fwang@igalia.com>
2422
2423         Add references to bug 179167 in FIXME comments
2424         https://bugs.webkit.org/show_bug.cgi?id=179168
2425
2426         Reviewed by Daniel Bates.
2427
2428         * Configurations/FeatureDefines.xcconfig:
2429
2430 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2431
2432         Implement WKFullscreenWindowController for iOS.
2433         https://bugs.webkit.org/show_bug.cgi?id=178924
2434         rdar://problem/34697120
2435
2436         Reviewed by Simon Fraser.
2437
2438         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2439
2440         * Configurations/FeatureDefines.xcconfig:
2441         * WebView/WebView.mm:
2442         (-[WebView fullScreenPlaceholderView]):
2443
2444 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2445
2446         Clean up some drag and drop feature flags
2447         https://bugs.webkit.org/show_bug.cgi?id=179082
2448
2449         Reviewed by Simon Fraser.
2450
2451         * Configurations/FeatureDefines.xcconfig:
2452
2453 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2454
2455         Make it possible to test rubber-banding in overflow scroll
2456         https://bugs.webkit.org/show_bug.cgi?id=179078
2457
2458         Reviewed by Sam Weinig.
2459
2460         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2461         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2462
2463         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2464         functions, since most callers want clamped.
2465
2466         * DOM/DOMHTML.mm:
2467         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2468
2469 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2470
2471         Fix up some content filtering feature flags
2472         https://bugs.webkit.org/show_bug.cgi?id=179079
2473
2474         Reviewed by Simon Fraser.
2475
2476         * Configurations/FeatureDefines.xcconfig:
2477
2478 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2479
2480         [FrameView::layout cleanup] Move core layout logic to a separate class.
2481         https://bugs.webkit.org/show_bug.cgi?id=178771
2482         <rdar://problem/35166542>
2483
2484         Reviewed by Simon Fraser.
2485
2486         Move layout code out from FrameView to LayoutContext.
2487
2488         * WebView/WebClipView.mm:
2489         (-[WebClipView _immediateScrollToPoint:]):
2490         * WebView/WebFrame.mm:
2491         (-[WebFrame layoutCount]):
2492
2493 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2494
2495         Fix issues with WebView subframe painting
2496         https://bugs.webkit.org/show_bug.cgi?id=178842
2497         rdar://problem/34072253
2498
2499         Reviewed by Daniel Bates.
2500         
2501         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2502         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2503         High Sierra, so match the new signature.
2504
2505         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2506
2507         * WebView/WebHTMLView.mm:
2508         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2509         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2510
2511 2017-10-25  Youenn Fablet  <youenn@apple.com>
2512
2513         Enable ServiceWorker to fetch resources
2514         https://bugs.webkit.org/show_bug.cgi?id=178673
2515
2516         Reviewed by Brady Eidson.
2517
2518         * WebCoreSupport/WebFrameLoaderClient.mm:
2519         (WebFrameLoaderClient::pageID const):
2520         (WebFrameLoaderClient::frameID const):
2521         (WebFrameLoaderClient::sessionID const):
2522
2523         Added implementation to the new getters.
2524         They are noop in the context of WK1.
2525
2526 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2527
2528         Web Inspector: Enable WebKit logging configuration and display
2529         https://bugs.webkit.org/show_bug.cgi?id=177027
2530         <rdar://problem/33964767>
2531
2532         Reviewed by Joseph Pecoraro.
2533
2534         * WebCoreSupport/WebChromeClient.mm:
2535         (stringForMessageSource): Deal with Media and WebRTC message sources.
2536
2537 2017-10-20  Antoine Quint  <graouts@apple.com>
2538
2539         [Web Animations] Provide basic timeline and animation interfaces
2540         https://bugs.webkit.org/show_bug.cgi?id=178526
2541
2542         Reviewed by Dean Jackson.
2543
2544         Remove the WEB_ANIMATIONS compile-time flag.
2545
2546         * Configurations/FeatureDefines.xcconfig:
2547         * WebView/WebPreferences.mm:
2548         (+[WebPreferences initialize]):
2549         * WebView/WebView.mm:
2550         (-[WebView _preferencesChanged:]):
2551
2552 2017-10-19  Sam Weinig  <sam@webkit.org>
2553
2554         [Settings] Move global settings into their own file
2555         https://bugs.webkit.org/show_bug.cgi?id=178512
2556
2557         Reviewed by Darin Adler.
2558
2559         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2560
2561         * WebCoreSupport/WebChromeClient.mm:
2562         (WebChromeClient::supportsVideoFullscreen):
2563         * WebView/WebDynamicScrollBarsView.mm:
2564         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2565         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2566         * WebView/WebPreferences.mm:
2567         (+[WebPreferences initialize]):
2568         * WebView/WebView.mm:
2569         (-[WebView _commonInitializationWithFrameName:groupName:]):
2570         (-[WebView _preferencesChanged:]):
2571         (+[WebView _doNotStartObservingNetworkReachability]):
2572
2573 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2574
2575         Replace some stack raw pointers with RefPtrs within WebCore/html
2576         https://bugs.webkit.org/show_bug.cgi?id=178201
2577         <rdar://problem/34841692>
2578
2579         Reviewed by Ryosuke Niwa.
2580
2581         * DOM/DOM.mm:
2582         (kit):
2583         Change the type of node as toNode() is changed to return RefPtr.
2584
2585 2017-10-18  Chris Dumez  <cdumez@apple.com>
2586
2587         [Service Worker] Add stubs for Client / WindowClient / Clients
2588         https://bugs.webkit.org/show_bug.cgi?id=178469
2589
2590         Reviewed by Youenn Fablet.
2591
2592         Rename PageVisiblityState to VisibilityState.
2593
2594         * WebView/WebView.mm:
2595         (kit):
2596
2597 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2598
2599         Unreviewed, rolling out r223291.
2600
2601         See WebCore ChangeLog for more detail.
2602
2603         Reverted changeset:
2604
2605         "Remove Editor::simplifyMarkup"
2606         https://bugs.webkit.org/show_bug.cgi?id=178271
2607         https://trac.webkit.org/changeset/223291
2608
2609 2017-10-17  Keith Miller  <keith_miller@apple.com>
2610
2611         Change WebCore sources to work with unified source builds
2612         https://bugs.webkit.org/show_bug.cgi?id=178229
2613
2614         Rubber stamped by Tim Horton.
2615
2616         * Configurations/FeatureDefines.xcconfig:
2617
2618 2017-10-16  Sam Weinig  <sam@webkit.org>
2619
2620         [Settings] Remove all custom code from Settings.h/cpp
2621         https://bugs.webkit.org/show_bug.cgi?id=178330
2622
2623         Reviewed by Simon Fraser.
2624
2625         * WebView/WebPreferences.mm:
2626         (+[WebPreferences initialize]):
2627         
2628             Update for naming changes of FrameFlattening now that it is an enum class.
2629
2630 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2631
2632         Remove Editor::simplifyMarkup
2633         https://bugs.webkit.org/show_bug.cgi?id=178271
2634
2635         Reviewed by Wenson Hsieh.
2636
2637         * WebView/WebView.mm:
2638         (-[WebView _simplifyMarkup:endNode:]):
2639
2640 2017-10-12  Chris Dumez  <cdumez@apple.com>
2641
2642         [Mac] Add support for MouseEvent.buttons
2643         https://bugs.webkit.org/show_bug.cgi?id=178214
2644
2645         Reviewed by Ryosuke Niwa.
2646
2647         * WebView/WebPDFView.mm:
2648         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2649
2650 2017-10-11  Sam Weinig  <sam@webkit.org>
2651
2652         Remove out-parameter variants of copyToVector
2653         https://bugs.webkit.org/show_bug.cgi?id=178155
2654
2655         Reviewed by Tim Horton.
2656
2657         * Plugins/WebNetscapePluginView.mm:
2658         (-[WebNetscapePluginView destroyPlugin]):
2659         * WebView/WebHTMLRepresentation.mm:
2660         (newArrayWithStrings):
2661
2662             Replace out-parameter based copyToVector, with one that returns a Vector.
2663
2664 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2665
2666         Sanitize URL in pasteboard for other applications and cross origin content
2667         https://bugs.webkit.org/show_bug.cgi?id=178060
2668         <rdar://problem/34874518>
2669
2670         Reviewed by Wenson Hsieh.
2671
2672         * WebCoreSupport/WebPlatformStrategies.h:
2673         * WebCoreSupport/WebPlatformStrategies.mm:
2674         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2675
2676 2017-10-11  Chris Dumez  <cdumez@apple.com>
2677
2678         Modernize Geolocation code
2679         https://bugs.webkit.org/show_bug.cgi?id=178148
2680
2681         Reviewed by Ryosuke Niwa.
2682
2683         * WebCoreSupport/WebGeolocationClient.h:
2684         * WebCoreSupport/WebGeolocationClient.mm:
2685         (WebGeolocationClient::lastPosition):
2686         * WebView/WebGeolocationPosition.mm:
2687         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2688         (core):
2689         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2690         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2691         * WebView/WebGeolocationPositionInternal.h:
2692
2693 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2694
2695         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2696         https://bugs.webkit.org/show_bug.cgi?id=178154
2697
2698         Reviewed by Wenson Hsieh.
2699
2700         Enable custom pasteboard data by default.
2701
2702         * WebView/WebPreferenceKeysPrivate.h:
2703         * WebView/WebPreferences.mm:
2704         (+[WebPreferences initialize]):
2705         (-[WebPreferences customPasteboardDataEnabled]): Added.
2706         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2707         * WebView/WebPreferencesPrivate.h:
2708         * WebView/WebView.mm:
2709         (-[WebView _preferencesChanged:]):
2710
2711 2017-10-10  Sam Weinig  <sam@webkit.org>
2712
2713         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2714         https://bugs.webkit.org/show_bug.cgi?id=178102
2715
2716         Reviewed by Tim Horton.
2717
2718         * History/WebHistory.mm:
2719         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2720         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2721         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2722         * WebCoreSupport/WebUserMediaClient.mm:
2723         (WebUserMediaClient::pageDestroyed):
2724
2725 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2726
2727         Make the names of the options consistent
2728         https://bugs.webkit.org/show_bug.cgi?id=177933
2729
2730         Reviewed by Saam Barati.
2731
2732         * WebView/WebFrame.h:
2733         * WebView/WebHTMLView.mm:
2734         (-[WebHTMLView setMarkedText:selectedRange:]):
2735         * WebView/WebView.h:
2736
2737 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2738
2739         [iOS] Tweak support for classifying form controls (followup to r222487)
2740         https://bugs.webkit.org/show_bug.cgi?id=177917
2741         <rdar://problem/34820122>
2742
2743         Reviewed by Dean Jackson.
2744
2745         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2746
2747         * DOM/DOMHTMLInputElement.mm:
2748         (-[DOMHTMLInputElement _autofillContext]):
2749         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2750         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2751
2752 2017-10-05  Keith Miller  <keith_miller@apple.com>
2753
2754         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2755
2756         * Configurations/WebKitLegacy.xcconfig:
2757
2758 2017-10-05  Jer Noble  <jer.noble@apple.com>
2759
2760         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2761         https://bugs.webkit.org/show_bug.cgi?id=177261
2762
2763         Reviewed by Eric Carlson.
2764
2765         * Configurations/FeatureDefines.xcconfig:
2766
2767 2017-10-05  Chris Dumez  <cdumez@apple.com>
2768
2769         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2770         https://bugs.webkit.org/show_bug.cgi?id=177957
2771
2772         Reviewed by Alex Christensen.
2773
2774         * WebCoreSupport/WebPlatformStrategies.h:
2775         * WebCoreSupport/WebPlatformStrategies.mm:
2776         (WebPlatformStrategies::cookiesEnabled):
2777
2778 2017-10-05  Youenn Fablet  <youenn@apple.com>
2779
2780         Make LibWebRTCProvider port agnostic
2781         https://bugs.webkit.org/show_bug.cgi?id=177747
2782
2783         Reviewed by Alex Christensen & Alex Garcia.
2784
2785         * WebView/WebView.mm:
2786         (-[WebView _commonInitializationWithFrameName:groupName:]):
2787         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2788
2789 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2790
2791         Stop linking with WebKitSystemInterface
2792         https://bugs.webkit.org/show_bug.cgi?id=177915
2793
2794         Reviewed by Antti Koivisto.
2795
2796         * Configurations/DebugRelease.xcconfig:
2797         * Configurations/WebKitLegacy.xcconfig:
2798
2799 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2800
2801         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2802         https://bugs.webkit.org/show_bug.cgi?id=177912
2803
2804         Reviewed by Saam Barati.
2805
2806         * Carbon/CarbonUtils.m:
2807         * Carbon/CarbonWindowAdapter.mm:
2808         * Carbon/HIWebView.mm:
2809         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2810         * Misc/WebNSFileManagerExtras.mm:
2811         * Misc/WebNSPasteboardExtras.mm:
2812         * Misc/WebNSURLExtras.mm:
2813         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2814         * Plugins/Hosted/NetscapePluginHostManager.mm:
2815         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2816         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2817         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2818         * Plugins/Hosted/WebTextInputWindowController.m:
2819         * Plugins/WebBaseNetscapePluginView.mm:
2820         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2821         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2822         * Plugins/WebNetscapePluginStream.mm:
2823         * Plugins/WebNetscapePluginView.mm:
2824         * Plugins/WebPluginDatabase.mm:
2825         * WebCoreSupport/PopupMenuMac.mm:
2826         * WebCoreSupport/WebChromeClient.mm:
2827         * WebCoreSupport/WebFrameLoaderClient.mm:
2828         * WebCoreSupport/WebInspectorClient.mm:
2829         * WebCoreSupport/WebPlatformStrategies.mm:
2830         * WebCoreSupport/WebSystemInterface.mm:
2831         * WebView/WebDynamicScrollBarsView.mm:
2832         * WebView/WebFrame.mm:
2833         * WebView/WebFrameView.mm:
2834         * WebView/WebFullScreenController.mm:
2835         * WebView/WebHTMLView.mm:
2836         * WebView/WebPreferences.mm:
2837         * WebView/WebView.mm:
2838
2839 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2840
2841         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2842         rdar://problem/34705779
2843
2844         Addressing review comments that I somehow landed without.
2845
2846         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2847
2848 2017-09-29  Chris Dumez  <cdumez@apple.com>
2849
2850         Split some logic out of VisitedLinkStore and make it reusable
2851         https://bugs.webkit.org/show_bug.cgi?id=177575
2852
2853         Reviewed by Alex Christensen.
2854
2855         * WebCoreSupport/WebVisitedLinkStore.h:
2856         * WebCoreSupport/WebVisitedLinkStore.mm:
2857         (WebVisitedLinkStore::addVisitedLink):
2858         (WebVisitedLinkStore::removeVisitedLink):
2859         (WebVisitedLinkStore::isLinkVisited):
2860         (WebVisitedLinkStore::addVisitedLinkHash):
2861
2862 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2863
2864         Build fix for High Sierra 32 bit Mac
2865         https://bugs.webkit.org/show_bug.cgi?id=177551
2866         <rdar://problem/34690283>
2867
2868         Reviewed by Alexey Proskuryakov.
2869
2870         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2871         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2872         also made.
2873
2874         * Carbon/CarbonWindowAdapter.mm:
2875         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2876         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2877         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2878         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2879         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2880         (-[CarbonWindowAdapter dealloc]):
2881         (-[CarbonWindowAdapter windowRef]):
2882         (-[CarbonWindowAdapter _hasWindowRef]):
2883         (-[CarbonWindowAdapter _managesWindowRef]):
2884         (-[CarbonWindowAdapter _removeWindowRef]):
2885         (-[CarbonWindowAdapter _carbonWindowClass]):
2886         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2887         (-[CarbonWindowAdapter sendSuperEvent:]):
2888         (-[CarbonWindowAdapter relinquishFocus]):
2889         (-[CarbonWindowAdapter _cancelKey:]):
2890         (-[CarbonWindowAdapter _commonAwake]):
2891         (-[CarbonWindowAdapter _destroyRealWindow:]):
2892         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2893         (-[CarbonWindowAdapter _termWindowIfOwner]):
2894         (-[CarbonWindowAdapter _windowMovedToRect:]):
2895         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2896         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2897         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2898         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2899         (-[CarbonWindowAdapter canBecomeMainWindow]):
2900         (-[CarbonWindowAdapter encodeWithCoder:]):
2901         (-[CarbonWindowAdapter initWithCoder:]):
2902         (-[CarbonWindowAdapter setContentView:]):
2903         (-[CarbonWindowAdapter worksWhenModal]):
2904         (-[CarbonWindowAdapter _setModalWindowLevel]):
2905         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2906         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2907         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2908         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2909         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2910         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2911         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2912         (NSCarbonWindowHandleEvent):
2913         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2914         (-[CarbonWindowAdapter _growBoxRect]):
2915         * Carbon/HIWebView.mm:
2916         (HIWebViewGetWebView):
2917         (HIWebViewConstructor):
2918         (HIWebViewDestructor):
2919         (HIWebViewRegisterClass):
2920         (GetBehaviors):
2921         (Draw):
2922         (HitTest):
2923         (GetRegion):
2924         (GetWindowRef):
2925         (CreateNSEventAdoptingCGEvent):
2926         (CopyEventCGEvent):
2927         (CreateNSEventWithCarbonClickEvent):
2928         (Click):
2929         (CreateNSEventWithCarbonEvent):
2930         (MouseUp):
2931         (CreateNSEventWithCarbonMouseMoveEvent):
2932         (MouseMoved):
2933         (MouseDragged):
2934         (MouseWheelMoved):
2935         (ContextMenuClick):
2936         (GetKind):
2937         (BoundsChanged):
2938         (OwningWindowChanged):
2939         (WindowHandler):
2940         (SyncFrame):
2941         (SetFocusPart):
2942         (AdvanceFocus):
2943         (RelinquishFocus):
2944         (ActiveStateChanged):
2945         (ProcessCommand):
2946         (UpdateCommandStatus):
2947         (_NSSelectorForHICommand):
2948         (HIWebViewEventHandler):
2949         (StartUpdateObserver):
2950         (StopUpdateObserver):
2951         (UpdateObserver):
2952
2953 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2954
2955         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2956         https://bugs.webkit.org/show_bug.cgi?id=172526
2957         <rdar://problem/32396081>
2958
2959         Reviewed by Ryosuke Niwa.
2960
2961         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2962
2963         * WebCoreSupport/WebPlatformStrategies.h:
2964         * WebCoreSupport/WebPlatformStrategies.mm:
2965         (WebPlatformStrategies::webExposedTypes):
2966         (WebPlatformStrategies::writeCustomData):
2967
2968 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2969
2970         Unreviewed, rolling out r222567.
2971
2972         This broke and internal build.
2973
2974         Reverted changeset:
2975
2976         "Build fix for High Sierra 32 bit Mac"
2977         https://bugs.webkit.org/show_bug.cgi?id=177551
2978         http://trac.webkit.org/changeset/222567
2979
2980 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2981
2982         Build fix for High Sierra 32 bit Mac
2983         https://bugs.webkit.org/show_bug.cgi?id=177551
2984         <rdar://problem/34690283>
2985
2986         Reviewed by Alexey Proskuryakov.
2987
2988         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2989         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2990         also made.
2991
2992         * Carbon/CarbonWindowAdapter.mm:
2993         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2994         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2995         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2996         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2997         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2998         (-[CarbonWindowAdapter dealloc]):
2999         (-[CarbonWindowAdapter windowRef]):
3000         (-[CarbonWindowAdapter _hasWindowRef]):
3001         (-[CarbonWindowAdapter _managesWindowRef]):
3002         (-[CarbonWindowAdapter _removeWindowRef]):
3003         (-[CarbonWindowAdapter _carbonWindowClass]):
3004         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3005         (-[CarbonWindowAdapter sendSuperEvent:]):
3006         (-[CarbonWindowAdapter relinquishFocus]):
3007         (-[CarbonWindowAdapter _cancelKey:]):
3008         (-[CarbonWindowAdapter _commonAwake]):
3009         (-[CarbonWindowAdapter _destroyRealWindow:]):
3010         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3011         (-[CarbonWindowAdapter _termWindowIfOwner]):
3012         (-[CarbonWindowAdapter _windowMovedToRect:]):
3013         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
3014         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
3015         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
3016         (-[CarbonWindowAdapter canBecomeKeyWindow]):
3017         (-[CarbonWindowAdapter canBecomeMainWindow]):
3018         (-[CarbonWindowAdapter encodeWithCoder:]):
3019         (-[CarbonWindowAdapter initWithCoder:]):
3020         (-[CarbonWindowAdapter setContentView:]):
3021         (-[CarbonWindowAdapter worksWhenModal]):
3022         (-[CarbonWindowAdapter _setModalWindowLevel]):
3023         (-[CarbonWindowAdapter _clearModalWindowLevel]):
3024         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
3025         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
3026         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
3027         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3028         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3029         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
3030         (NSCarbonWindowHandleEvent):
3031         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
3032         (-[CarbonWindowAdapter _growBoxRect]):
3033         * Carbon/HIWebView.mm:
3034         (HIWebViewGetWebView):
3035         (HIWebViewConstructor):
3036         (HIWebViewDestructor):
3037         (HIWebViewRegisterClass):
3038         (GetBehaviors):
3039         (Draw):
3040         (HitTest):
3041         (GetRegion):
3042         (GetWindowRef):
3043         (CreateNSEventAdoptingCGEvent):
3044         (CopyEventCGEvent):
3045         (CreateNSEventWithCarbonClickEvent):
3046         (Click):
3047         (CreateNSEventWithCarbonEvent):
3048         (MouseUp):
3049         (CreateNSEventWithCarbonMouseMoveEvent):
3050         (MouseMoved):
3051         (MouseDragged):
3052         (MouseWheelMoved):
3053         (ContextMenuClick):
3054         (GetKind):
3055         (BoundsChanged):
3056         (OwningWindowChanged):
3057         (WindowHandler):
3058         (SyncFrame):
3059         (SetFocusPart):
3060         (AdvanceFocus):
3061         (RelinquishFocus):
3062         (ActiveStateChanged):
3063         (ProcessCommand):
3064         (UpdateCommandStatus):
3065         (_NSSelectorForHICommand):
3066         (HIWebViewEventHandler):
3067         (StartUpdateObserver):
3068         (StopUpdateObserver):
3069         (UpdateObserver):
3070
3071 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3072
3073         Make PolicyAction an encodable enum class
3074         https://bugs.webkit.org/show_bug.cgi?id=177480
3075
3076         Reviewed by Antti Koivisto.
3077
3078         * Plugins/WebPluginContainerCheck.mm:
3079         (-[WebPluginContainerCheck _continueWithPolicy:]):
3080         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3081         * WebCoreSupport/WebFrameLoaderClient.mm:
3082         (-[WebFramePolicyListener invalidate]):
3083         (-[WebFramePolicyListener ignore]):
3084         (-[WebFramePolicyListener download]):
3085         (-[WebFramePolicyListener use]):
3086         (-[WebFramePolicyListener continue]):
3087         * WebView/WebPolicyDelegate.mm:
3088         (-[WebPolicyDecisionListener use]):
3089         (-[WebPolicyDecisionListener ignore]):
3090         (-[WebPolicyDecisionListener download]):
3091
3092 2017-09-25  Frederik Riedel  <riedel@apple.com>
3093
3094         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
3095         https://bugs.webkit.org/show_bug.cgi?id=174394
3096         <rdar://problem/33183504>
3097
3098         Reviewed by Ryosuke Niwa.
3099
3100         * DOM/DOMHTMLInputElement.h:
3101         * DOM/DOMHTMLInputElement.mm:
3102         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
3103         Determines if this HTMLInputElement is part of a login screen.
3104         (-[DOMHTMLInputElement representingPageUrl]):
3105         Returns the webpage's URL that is currently displayed in the Web View.
3106         (-[DOMHTMLInputElement insertTextSuggestion:]):
3107         Inserts login credentials into the Web View.
3108
3109 2017-09-25  Sam Weinig  <sam@webkit.org>
3110
3111         Remove unused EditorClient functions
3112         https://bugs.webkit.org/show_bug.cgi?id=177463
3113
3114         Reviewed by Alex Christensen.
3115
3116         Remove unused EditorClient functions.
3117
3118         * WebCoreSupport/WebEditorClient.h:
3119         * WebCoreSupport/WebEditorClient.mm:
3120         (WebEditorClient::canonicalizeURL): Deleted.
3121         (WebEditorClient::canonicalizeURLString): Deleted.
3122         (WebEditorClient::writeDataToPasteboard): Deleted.
3123         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
3124         (WebEditorClient::readDataFromPasteboard): Deleted.
3125         (WebEditorClient::pasteboardChangeCount): Deleted.
3126
3127 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3128
3129         Stop using PolicyCallback
3130         https://bugs.webkit.org/show_bug.cgi?id=176088
3131
3132         Reviewed by Andy Estes.
3133
3134         * WebCoreSupport/WebFrameLoaderClient.mm:
3135         (-[WebFramePolicyListener invalidate]):
3136         (-[WebFramePolicyListener receivedPolicyDecision:]):
3137
3138 2017-09-25  Sam Weinig  <sam@webkit.org>
3139
3140         Remove unnecessary userVisibleString EditorClient function
3141         https://bugs.webkit.org/show_bug.cgi?id=177456
3142
3143         Reviewed by Dan Bernstein.
3144
3145         * WebCoreSupport/WebEditorClient.h:
3146         * WebCoreSupport/WebEditorClient.mm:
3147         (WebEditorClient::userVisibleString): Deleted.
3148
3149             Remove userVisibleString client function.
3150
3151 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3152
3153         Separate form submission from PolicyChecker infrastructure
3154         https://bugs.webkit.org/show_bug.cgi?id=177396
3155
3156         Reviewed by Geoffrey Garen.
3157
3158         * WebCoreSupport/WebFrameLoaderClient.h:
3159         * WebCoreSupport/WebFrameLoaderClient.mm:
3160         (WebFrameLoaderClient::dispatchWillSubmitForm):
3161
3162 2017-09-22  Zalan Bujtas  <zalan@apple.com>
3163
3164         WeakPtrFactory should populate m_ref lazily.
3165         https://bugs.webkit.org/show_bug.cgi?id=177375
3166
3167         Reviewed by Geoffrey Garen.
3168
3169         * WebCoreSupport/WebEditorClient.mm:
3170         (WebEditorClient::WebEditorClient):
3171         (WebEditorClient::requestCandidatesForSelection):
3172
3173 2017-09-22  Chris Dumez  <cdumez@apple.com>
3174
3175         Use high resolution timestamp for event time
3176         https://bugs.webkit.org/show_bug.cgi?id=154246
3177         <rdar://problem/34333304>
3178
3179         Reviewed by Ryosuke Niwa.
3180
3181         Use WallTime / MonotonicTime instead of double type for clarity.
3182
3183         * DOM/DOMEvent.mm:
3184         (-[DOMEvent timeStamp]):
3185         * WebView/WebFrame.mm:
3186         (-[WebFrame _dragSourceEndedAt:operation:]):
3187         * WebView/WebPDFView.mm:
3188         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3189
3190 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3191
3192         Enable dataTransfer.items on macOS and iOS
3193         https://bugs.webkit.org/show_bug.cgi?id=177335
3194
3195         Reviewed by Sam Weinig.
3196
3197         * WebView/WebPreferences.mm:
3198         (+[WebPreferences initialize]):
3199
3200 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
3201
3202         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
3203         https://bugs.webkit.org/show_bug.cgi?id=177101
3204         <rdar://problem/34500648>
3205
3206         Reviewed by Brian Burg.
3207
3208         * WebInspector/WebNodeHighlight.mm:
3209         Ensure we close the window that we have just removed.
3210
3211 2017-09-20  Antti Koivisto  <antti@apple.com>
3212
3213         Remove DOM and styling support for CSS Regions
3214         https://bugs.webkit.org/show_bug.cgi?id=177221
3215
3216         Reviewed by Andreas Kling.
3217
3218         * Configurations/FeatureDefines.xcconfig:
3219         * DOM/DOMCSS.mm:
3220         (kitClass):
3221         * DOM/DOMElement.mm:
3222         (-[DOMElement webkitRegionOverset]): Deleted.
3223
3224 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
3225
3226         Layering violation in Editor::createFragment
3227         https://bugs.webkit.org/show_bug.cgi?id=176123
3228
3229         Reviewed by Darin Adler.
3230
3231         * Misc/WebNSURLExtras.h:
3232         * Misc/WebNSURLExtras.mm:
3233         * WebView/WebFrame.mm:
3234         * WebView/WebHTMLView.mm:
3235         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
3236
3237         * WebCoreSupport/WebEditorClient.mm:
3238         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
3239         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
3240         way to avoid exporting the symbol just on newer OSes.
3241
3242 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
3243
3244         On iOS, getData can't get text set by setData during copy event
3245         https://bugs.webkit.org/show_bug.cgi?id=176980
3246         <rdar://problem/34453915>
3247
3248         Reviewed by Darin Adler.
3249
3250         * WebCoreSupport/WebPlatformStrategies.h:
3251         * WebCoreSupport/WebPlatformStrategies.mm:
3252         (WebPlatformStrategies::copy): Deleted.
3253
3254 2017-09-18  Andy Estes  <aestes@apple.com>
3255
3256         [Mac] Upstream miscellaneous WebKitSystemInterface functions
3257         https://bugs.webkit.org/show_bug.cgi?id=177029
3258
3259         Reviewed by Alex Christensen.
3260
3261         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3262         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3263         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3264         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3265         * WebCoreSupport/PopupMenuMac.mm:
3266         (PopupMenuMac::show):
3267         * WebCoreSupport/WebSystemInterface.mm:
3268         (InitWebCoreSystemInterface):
3269         * WebView/WebHTMLView.mm:
3270         (-[WebHTMLView setDataSource:]):
3271         (-[WebHTMLView attachRootLayer:]):
3272         * WebView/WebView.mm:
3273         (-[WebView _needsAdobeFrameReloadingQuirk]):
3274         (-[WebView _needsLinkElementTextCSSQuirk]):
3275         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3276         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3277         (-[WebView _preferencesChanged:]):
3278
3279 2017-09-15  Andy Estes  <aestes@apple.com>
3280
3281         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3282         https://bugs.webkit.org/show_bug.cgi?id=176953
3283
3284         Reviewed by Eric Carlson.
3285
3286         * WebCoreSupport/WebSystemInterface.mm:
3287         (InitWebCoreSystemInterface):
3288
3289 2017-09-14  Andy Estes  <aestes@apple.com>
3290
3291         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3292         https://bugs.webkit.org/show_bug.cgi?id=176931
3293
3294         Reviewed by Joseph Pecoraro.
3295
3296         * WebCoreSupport/WebSystemInterface.mm:
3297         (InitWebCoreSystemInterface):
3298
3299 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3300
3301         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3302         https://bugs.webkit.org/show_bug.cgi?id=176867
3303
3304         Reviewed by Sam Weinig.
3305
3306         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3307         (WebKit::NetscapePluginInstanceProxy::enumerate):
3308
3309 2017-09-13  Andy Estes  <aestes@apple.com>
3310
3311         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3312         https://bugs.webkit.org/show_bug.cgi?id=176729
3313
3314         Reviewed by Alex Christensen.
3315
3316         * WebCoreSupport/WebSystemInterface.mm:
3317         (InitWebCoreSystemInterface):
3318         * WebView/WebView.mm:
3319         (+[WebView _setCacheModel:]):
3320
3321 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3322
3323         Refactor WebContentReader out of EditorMac and EditorIOS
3324         https://bugs.webkit.org/show_bug.cgi?id=176770
3325
3326         Reviewed by Sam Weinig.
3327
3328         * WebCoreSupport/WebEditorClient.mm:
3329
3330 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3331
3332         Dragging & dropping a file creates an attachment element even when it's disabled
3333         https://bugs.webkit.org/show_bug.cgi?id=176769
3334
3335         Reviewed by Tim Horton.
3336
3337         * WebView/WebView.mm:
3338         (-[WebView _preferencesChanged:]):
3339
3340 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3341
3342         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3343         https://bugs.webkit.org/show_bug.cgi?id=176721
3344         <rdar://problem/34373660>
3345
3346         Reviewed by Tim Horton.
3347
3348         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3349         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3350
3351         * WebView/WebView.mm:
3352         (-[WebView _startDrag:]):
3353         (-[WebView _draggedElementBounds]):
3354         (-[WebView _endedDataInteraction:global:]):
3355         * WebView/WebViewData.h:
3356
3357 2017-09-11  Andy Estes  <aestes@apple.com>
3358
3359         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3360         https://bugs.webkit.org/show_bug.cgi?id=176472
3361
3362         Reviewed by Eric Carlson.
3363
3364         * WebCoreSupport/WebSystemInterface.mm:
3365         (InitWebCoreSystemInterface):
3366
3367 2017-09-09  Mark Lam  <mark.lam@apple.com>
3368
3369         Avoid duplicate computations of ExecState::vm().
3370         https://bugs.webkit.org/show_bug.cgi?id=176647
3371
3372         Reviewed by Saam Barati.
3373
3374         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3375         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3376         (WebKit::NetscapePluginInstanceProxy::construct):
3377         (WebKit::NetscapePluginInstanceProxy::setProperty):
3378         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3379         (WebKit::NetscapePluginInstanceProxy::enumerate):
3380         * Plugins/Hosted/ProxyInstance.mm:
3381         (WebKit::ProxyRuntimeMethod::create):
3382
3383 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3384
3385         Unreviewed, rolling out r221773.
3386         https://bugs.webkit.org/show_bug.cgi?id=176614
3387
3388         This caused build failures. (Requested by mlewis13 on
3389         #webkit).
3390
3391         Reverted changeset:
3392
3393         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3394         https://bugs.webkit.org/show_bug.cgi?id=176472
3395         http://trac.webkit.org/changeset/221773
3396
3397 2017-09-07  Andy Estes  <aestes@apple.com>
3398
3399         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3400         https://bugs.webkit.org/show_bug.cgi?id=176472
3401
3402         Reviewed by Eric Carlson.
3403
3404         * WebCoreSupport/WebSystemInterface.mm:
3405         (InitWebCoreSystemInterface):
3406
3407 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3408
3409         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3410         https://bugs.webkit.org/show_bug.cgi?id=176561
3411
3412         Reviewed by Brent Fulgham.
3413
3414         * Misc/WebNSUserDefaultsExtras.mm:
3415
3416 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3417
3418         Modernize Geolocation code
3419         https://bugs.webkit.org/show_bug.cgi?id=176496
3420
3421         Reviewed by Andy Estes.
3422
3423         * WebCoreSupport/WebGeolocationClient.h:
3424         * WebCoreSupport/WebGeolocationClient.mm:
3425         (WebGeolocationClient::requestPermission):
3426         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3427         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3428         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3429         * WebView/WebView.mm:
3430         (-[WebView _commonInitializationWithFrameName:groupName:]):
3431         (-[WebView _geolocationDidFailWithMessage:]):
3432
3433 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3434
3435         Remove some unused bits of code and resources
3436         https://bugs.webkit.org/show_bug.cgi?id=176275
3437
3438         Reviewed by Dan Bernstein.
3439
3440         * Misc/WebNSFileManagerExtras.mm:
3441         Include FileSystem instead of FileSystemIOS.
3442
3443 2017-09-03  Darin Adler  <darin@apple.com>
3444
3445         [Cocoa] Tidy a few things in legacy WebHTMLView
3446         https://bugs.webkit.org/show_bug.cgi?id=176280
3447
3448         Reviewed by Dan Bernstein.
3449
3450         * WebCoreSupport/WebChromeClient.mm:
3451         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3452         methods it calls on WebHTMLView were doing nothing on iOS.
3453
3454         * WebView/WebFrame.mm:
3455         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3456         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3457
3458         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3459         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3460         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3461         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3462         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3463         Use RetainPtr instead of writing retain/release wherever possible.
3464         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3465         initialization for it. Removed various unused methods and declarations of methods.
3466         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3467         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3468         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3469         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3470         and remove CFRetain no longer needed since we don't support garbage collection any more.
3471         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3472         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3473         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3474         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3475         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3476         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3477         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3478         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3479         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3480         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3481         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3482         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3483         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3484         debug flag; we haven't used it for years and it's not clearly helpful.
3485         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3486         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3487         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3488         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3489         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3490         two additional methods in the WebPrivate category and still be called by the two
3491         methods in the WebInternal category that were already using it.
3492         (-[WebHTMLView didAddSubview:]): Deleted.
3493         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3494         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3495         place this was called, the close method.
3496         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3497         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3498         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3499         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3500         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3501         Added helper method to make the one below simpler.
3502         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3503         Compared pasteboard type strings using isEqualToString: rather than using == since
3504