Move URL from WebCore to WTF
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-11-30  Alex Christensen  <achristensen@webkit.org>
2
3         Move URL from WebCore to WTF
4         https://bugs.webkit.org/show_bug.cgi?id=190234
5
6         Reviewed by Keith Miller.
7
8         * DOM/DOMAttr.mm:
9         * DOM/DOMBlob.mm:
10         * DOM/DOMCSSCharsetRule.mm:
11         * DOM/DOMCSSImportRule.mm:
12         * DOM/DOMCSSMediaRule.mm:
13         * DOM/DOMCSSPageRule.mm:
14         * DOM/DOMCSSPrimitiveValue.mm:
15         * DOM/DOMCSSRule.mm:
16         * DOM/DOMCSSStyleDeclaration.mm:
17         * DOM/DOMCSSStyleRule.mm:
18         * DOM/DOMCSSStyleSheet.mm:
19         * DOM/DOMCSSValue.mm:
20         * DOM/DOMCharacterData.mm:
21         * DOM/DOMCounter.mm:
22         * DOM/DOMDocument.mm:
23         * DOM/DOMDocumentFragment.mm:
24         * DOM/DOMDocumentType.mm:
25         * DOM/DOMEvent.mm:
26         * DOM/DOMFile.mm:
27         * DOM/DOMHTMLAnchorElement.mm:
28         * DOM/DOMHTMLAppletElement.mm:
29         * DOM/DOMHTMLAreaElement.mm:
30         * DOM/DOMHTMLBRElement.mm:
31         * DOM/DOMHTMLBaseElement.mm:
32         * DOM/DOMHTMLBaseFontElement.mm:
33         * DOM/DOMHTMLBodyElement.mm:
34         * DOM/DOMHTMLButtonElement.mm:
35         * DOM/DOMHTMLCanvasElement.mm:
36         * DOM/DOMHTMLCollection.mm:
37         * DOM/DOMHTMLDivElement.mm:
38         * DOM/DOMHTMLDocument.mm:
39         * DOM/DOMHTMLElement.mm:
40         * DOM/DOMHTMLEmbedElement.mm:
41         * DOM/DOMHTMLFieldSetElement.mm:
42         * DOM/DOMHTMLFontElement.mm:
43         * DOM/DOMHTMLFormElement.mm:
44         * DOM/DOMHTMLFrameElement.mm:
45         * DOM/DOMHTMLFrameSetElement.mm:
46         * DOM/DOMHTMLHRElement.mm:
47         * DOM/DOMHTMLHeadElement.mm:
48         * DOM/DOMHTMLHeadingElement.mm:
49         * DOM/DOMHTMLHtmlElement.mm:
50         * DOM/DOMHTMLIFrameElement.mm:
51         * DOM/DOMHTMLImageElement.mm:
52         * DOM/DOMHTMLInputElement.mm:
53         * DOM/DOMHTMLLIElement.mm:
54         * DOM/DOMHTMLLabelElement.mm:
55         * DOM/DOMHTMLLegendElement.mm:
56         * DOM/DOMHTMLLinkElement.mm:
57         * DOM/DOMHTMLMapElement.mm:
58         * DOM/DOMHTMLMarqueeElement.mm:
59         * DOM/DOMHTMLMediaElement.mm:
60         * DOM/DOMHTMLMetaElement.mm:
61         * DOM/DOMHTMLModElement.mm:
62         * DOM/DOMHTMLOListElement.mm:
63         * DOM/DOMHTMLObjectElement.mm:
64         * DOM/DOMHTMLOptGroupElement.mm:
65         * DOM/DOMHTMLOptionElement.mm:
66         * DOM/DOMHTMLOptionsCollection.mm:
67         * DOM/DOMHTMLParagraphElement.mm:
68         * DOM/DOMHTMLParamElement.mm:
69         * DOM/DOMHTMLQuoteElement.mm:
70         * DOM/DOMHTMLScriptElement.mm:
71         * DOM/DOMHTMLSelectElement.mm:
72         * DOM/DOMHTMLStyleElement.mm:
73         * DOM/DOMHTMLTableCaptionElement.mm:
74         * DOM/DOMHTMLTableCellElement.mm:
75         * DOM/DOMHTMLTableColElement.mm:
76         * DOM/DOMHTMLTableElement.mm:
77         * DOM/DOMHTMLTableRowElement.mm:
78         * DOM/DOMHTMLTableSectionElement.mm:
79         * DOM/DOMHTMLTitleElement.mm:
80         * DOM/DOMHTMLUListElement.mm:
81         * DOM/DOMHTMLVideoElement.mm:
82         * DOM/DOMKeyboardEvent.mm:
83         * DOM/DOMMediaList.mm:
84         * DOM/DOMMouseEvent.mm:
85         * DOM/DOMMutationEvent.mm:
86         * DOM/DOMNamedNodeMap.mm:
87         * DOM/DOMProcessingInstruction.mm:
88         * DOM/DOMRange.mm:
89         * DOM/DOMStyleSheet.mm:
90         * DOM/DOMText.mm:
91         * DOM/DOMTextEvent.mm:
92         * DOM/DOMTokenList.mm:
93         * DOM/DOMUIEvent.mm:
94         * DOM/DOMXPathResult.mm:
95         * History/WebHistoryItem.mm:
96         * Misc/WebNSURLExtras.mm:
97         (-[NSURL _web_userVisibleString]):
98         (-[NSURL _web_URLByRemovingUserInfo]):
99         (-[NSURL _web_dataForURLComponentType:]):
100         (-[NSURL _web_schemeData]):
101         (-[NSURL _web_hostData]):
102         * Misc/WebUserContentURLPattern.mm:
103         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
104         * Plugins/WebNetscapePluginStream.h:
105         (WebNetscapePluginStream::setRequestURL):
106         * WebCoreSupport/WebChromeClient.h:
107         * WebCoreSupport/WebChromeClient.mm:
108         (WebChromeClient::signedPublicKeyAndChallengeString const):
109         * WebCoreSupport/WebContextMenuClient.h:
110         * WebCoreSupport/WebContextMenuClient.mm:
111         * WebCoreSupport/WebDragClient.h:
112         * WebCoreSupport/WebFrameLoaderClient.h:
113         * WebCoreSupport/WebFrameLoaderClient.mm:
114         (WebFrameLoaderClient::updateGlobalHistory):
115         * WebCoreSupport/WebPaymentCoordinatorClient.h:
116         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
117         (WebPaymentCoordinatorClient::showPaymentUI):
118         * WebCoreSupport/WebPlatformStrategies.h:
119         * WebCoreSupport/WebPlatformStrategies.mm:
120         (WebPlatformStrategies::readURLFromPasteboard):
121         * WebCoreSupport/WebPluginInfoProvider.h:
122         * WebCoreSupport/WebPluginInfoProvider.mm:
123         (WebPluginInfoProvider::webVisiblePluginInfo):
124         * WebCoreSupport/WebSecurityOrigin.mm:
125         * WebCoreSupport/WebVisitedLinkStore.h:
126         * WebView/WebDataSource.mm:
127         * WebView/WebFrame.mm:
128         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
129         * WebView/WebImmediateActionController.mm:
130         (-[WebImmediateActionController _defaultAnimationController]):
131         * WebView/WebPDFView.mm:
132         * WebView/WebScriptDebugger.mm:
133         * WebView/WebViewInternal.h:
134
135 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
136
137         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
138         https://bugs.webkit.org/show_bug.cgi?id=192197
139
140         Reviewed by Jiewen Tan.
141
142         * Configurations/FeatureDefines.xcconfig:
143         * WebCoreSupport/WebChromeClient.h:
144         * WebCoreSupport/WebChromeClient.mm:
145
146 2018-11-28  Alex Christensen  <achristensen@webkit.org>
147
148         Remove dead code from an earlier attempt at implementing safe browsing
149         https://bugs.webkit.org/show_bug.cgi?id=192067
150
151         Reviewed by Chris Dumez.
152
153         * WebCoreSupport/WebFrameLoaderClient.h:
154         * WebCoreSupport/WebFrameLoaderClient.mm:
155         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
156
157 2018-11-27  Mark Lam  <mark.lam@apple.com>
158
159         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
160         https://bugs.webkit.org/show_bug.cgi?id=192055
161         <rdar://problem/46288783>
162
163         Reviewed by Saam Barati.
164
165         * Configurations/FeatureDefines.xcconfig:
166
167 2018-11-25  Tim Horton  <timothy_horton@apple.com>
168
169         Make it possible to insert editable images with a gesture
170         https://bugs.webkit.org/show_bug.cgi?id=191937
171
172         Reviewed by Wenson Hsieh.
173
174         * WebCoreSupport/WebEditorClient.mm:
175         (undoNameForEditAction):
176         Add a undo name.
177
178 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
179
180         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
181         https://bugs.webkit.org/show_bug.cgi?id=191945
182
183         Reviewed by Anders Carlsson.
184
185         * WebCoreSupport/WebEditorClient.mm:
186         (undoNameForEditAction):
187
188 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
189
190         Enable drag and drop support for iOSMac
191         https://bugs.webkit.org/show_bug.cgi?id=191818
192         <rdar://problem/43907454>
193
194         Reviewed by Dean Jackson.
195
196         * Configurations/FeatureDefines.xcconfig:
197
198 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
199
200         Address post-review feedback after r238438
201         https://bugs.webkit.org/show_bug.cgi?id=191913
202
203         Reviewed by Ryosuke Niwa.
204
205         * WebView/WebFrame.mm:
206         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
207         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
208         * WebView/WebView.mm:
209         (-[WebView setSelectedDOMRange:affinity:]):
210
211 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
212
213         Web Inspector: "Reload Web Inspector" button no longer partially works
214         https://bugs.webkit.org/show_bug.cgi?id=191773
215         <rdar://problem/46139932>
216
217         Reviewed by Devin Rousso.
218
219         * WebCoreSupport/WebInspectorClient.h:
220         * WebCoreSupport/WebInspectorClient.mm:
221         (WebInspectorFrontendClient::reopen):
222
223 2018-11-17  Devin Rousso  <drousso@apple.com>
224
225         Web Inspector: Network: add button to show system certificate dialog
226         https://bugs.webkit.org/show_bug.cgi?id=191458
227         <rdar://problem/45977019>
228
229         Reviewed by Joseph Pecoraro.
230
231         * WebCoreSupport/WebInspectorClient.h:
232         * WebCoreSupport/WebInspectorClient.mm:
233         (WebInspectorFrontendClient::showCertificate): Added.
234
235         * Configurations/WebKitLegacy.xcconfig:
236
237 2018-11-15  Truitt Savell  <tsavell@apple.com>
238
239         Unreviewed, rolling out r238244.
240
241         Caused High Sierra test runs to fail early with 50 crashes and
242         casued 25 API failures.
243
244         Reverted changeset:
245
246         "[css-logical] Implement flow-relative margin, padding and
247         border shorthands"
248         https://bugs.webkit.org/show_bug.cgi?id=188697
249         https://trac.webkit.org/changeset/238244
250
251 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
252
253         [css-logical] Implement flow-relative margin, padding and border shorthands
254         https://bugs.webkit.org/show_bug.cgi?id=188697
255
256         Reviewed by Simon Fraser and Antti Koivisto.
257
258         Add CSSLogicalEnabled runtime flag.
259
260         * WebView/WebPreferenceKeysPrivate.h:
261         * WebView/WebPreferences.mm:
262         (+[WebPreferences initialize]):
263         (-[WebPreferences cssLogicalEnabled]):
264         (-[WebPreferences setCSSLogicalEnabled:]):
265         * WebView/WebPreferencesPrivate.h:
266         * WebView/WebView.mm:
267         (-[WebView _preferencesChanged:]):
268
269 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
270
271         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
272         https://bugs.webkit.org/show_bug.cgi?id=191612
273
274         Reviewed by Matt Baker.
275
276         * WebCoreSupport/WebInspectorClient.mm:
277         (-[WebInspectorWindowController destroyInspectorView]):
278
279 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
280
281         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
282         https://bugs.webkit.org/show_bug.cgi?id=191494
283         <rdar://problem/45469854>
284
285         Reviewed by Devin Rousso.
286
287         * WebCoreSupport/WebInspectorClient.h:
288         WebKitLegacy will still have remote inspection of the Page directly.
289
290 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
291
292         Make compositing updates incremental
293         https://bugs.webkit.org/show_bug.cgi?id=90342
294
295         Reviewed by Antti Koivisto.
296
297         Fix spelling error.
298
299         * WebView/WebView.mm:
300         (-[WebView _setMediaLayer:forPluginView:]):
301
302 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
303
304         Implement a new edit command to change the enclosing list type
305         https://bugs.webkit.org/show_bug.cgi?id=191487
306         <rdar://problem/45955922>
307
308         Reviewed by Ryosuke Niwa.
309
310         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
311
312         * WebCoreSupport/WebEditorClient.mm:
313         (undoNameForEditAction):
314
315 2018-11-11  Daniel Bates  <dabates@apple.com>
316
317         [iOS] Draw caps lock indicator in password fields
318         https://bugs.webkit.org/show_bug.cgi?id=190565
319         <rdar://problem/45262343>
320
321         Reviewed by Dean Jackson.
322
323         Update the caps lock state when a hardware keyboard is attached or detached.
324
325         * WebView/WebHTMLView.mm:
326         (hardwareKeyboardAvailabilityChangedCallback): Added.
327         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
328         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
329
330 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
331
332         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
333         https://bugs.webkit.org/show_bug.cgi?id=191492
334
335         Reviewed by Alex Christensen.
336
337         * Carbon/HIWebView.mm:
338         * Misc/WebNSFileManagerExtras.mm:
339         * Misc/WebNSURLExtras.mm:
340         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
341         * Plugins/WebBasePluginPackage.mm:
342         * Plugins/WebPluginContainerCheck.mm:
343         * WebCoreSupport/WebCachedFramePlatformData.h:
344         * WebCoreSupport/WebDeviceOrientationClient.mm:
345         * WebView/WebDelegateImplementationCaching.mm:
346         * WebView/WebHTMLView.mm:
347         * WebView/WebPDFRepresentation.mm:
348         * WebView/WebPolicyDelegate.mm:
349         * WebView/WebView.mm:
350
351 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
352
353         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
354         https://bugs.webkit.org/show_bug.cgi?id=191492
355
356         Reviewed by Alex Christensen.
357
358         * Carbon/HIWebView.mm:
359         (UpdateCommandStatus):
360         * Misc/WebNSFileManagerExtras.mm:
361         * Misc/WebNSURLExtras.mm:
362         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
363         * Plugins/WebBasePluginPackage.mm:
364         * Plugins/WebPluginContainerCheck.mm:
365         (-[WebPluginContainerCheck _continueWithPolicy:]):
366         * WebCoreSupport/WebCachedFramePlatformData.h:
367         (WebCachedFramePlatformData::clear):
368         * WebCoreSupport/WebDeviceOrientationClient.mm:
369         (WebDeviceOrientationClient::getProvider const):
370         * WebView/WebDelegateImplementationCaching.mm:
371         (CallDelegate):
372         (CallDelegateReturningBoolean):
373         (CallResourceLoadDelegateReturningBoolean):
374         (CallFormDelegate):
375         (CallFormDelegateReturningBoolean):
376         * WebView/WebHTMLView.mm:
377         * WebView/WebPDFRepresentation.mm:
378         * WebView/WebPolicyDelegate.mm:
379         (-[WebPolicyDecisionListener _usePolicy:]):
380         * WebView/WebView.mm:
381
382 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
383
384         Unreviewed, rolling out r238047.
385
386         Introduced layout test failures on iOS simulator.
387
388         Reverted changeset:
389
390         "[iOS] Draw caps lock indicator in password fields"
391         https://bugs.webkit.org/show_bug.cgi?id=190565
392         https://trac.webkit.org/changeset/238047
393
394 2018-11-09  Antti Koivisto  <antti@apple.com>
395
396         Use OptionSet for layout milestones
397         https://bugs.webkit.org/show_bug.cgi?id=191470
398
399         Reviewed by Dean Jackson.
400
401         * WebCoreSupport/WebFrameLoaderClient.h:
402         * WebCoreSupport/WebFrameLoaderClient.mm:
403         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
404         * WebView/WebView.mm:
405         (coreLayoutMilestones):
406         (kitLayoutMilestones):
407         (-[WebView _cacheFrameLoadDelegateImplementations]):
408         * WebView/WebViewInternal.h:
409
410 2018-11-09  Daniel Bates  <dabates@apple.com>
411
412         [iOS] Draw caps lock indicator in password fields
413         https://bugs.webkit.org/show_bug.cgi?id=190565
414         <rdar://problem/45262343>
415
416         Reviewed by Dean Jackson.
417
418         Update the caps lock state when a hardware keyboard is attached or detached.
419
420         * WebView/WebHTMLView.mm:
421         (hardwareKeyboardAvailabilityChangedCallback): Added.
422         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
423         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
424
425 2018-11-09  Daniel Bates  <dabates@apple.com>
426
427         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
428         action when forward delete is pressed outside a text field
429         https://bugs.webkit.org/show_bug.cgi?id=190566
430         <rdar://problem/45262367>
431
432         Reviewed by Wenson Hsieh.
433
434         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
435         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
436         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
437
438         * WebView/WebHTMLView.mm:
439         (-[WebHTMLView _handleEditingKeyEvent:]):
440
441 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
442
443         Adopt Reveal Framework to replace Lookup
444         https://bugs.webkit.org/show_bug.cgi?id=191097
445         <rdar://problem/45924508>
446
447         Reviewed by Tim Horton.
448
449         Pass in what it needed to clear the textIndicators. This is better than
450         the current notification structure.
451
452         * WebView/WebView.mm:
453         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
454         (-[WebView _prepareForDictionaryLookup]):
455
456 2018-11-06  Justin Fan  <justin_fan@apple.com>
457
458         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
459         https://bugs.webkit.org/show_bug.cgi?id=191291
460
461         Reviewed by Myles Maxfield.
462
463         Properly disable WEBGPU on all non-Metal platforms for now.
464
465         * Configurations/FeatureDefines.xcconfig:
466
467 2018-11-02  Daniel Bates  <dabates@apple.com>
468
469         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
470         https://bugs.webkit.org/show_bug.cgi?id=190487
471
472         Reviewed by Tim Horton.
473
474         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
475         allow the default handling.
476
477         * WebView/WebHTMLView.mm:
478         (-[WebHTMLView _handleEditingKeyEvent:]):
479
480 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
481
482         Add a storage limit for IndexedDB
483         https://bugs.webkit.org/show_bug.cgi?id=190598
484         <rdar://problem/44654715>
485
486         Reviewed by Chris Dumez.
487
488         * Storage/WebDatabaseManager.mm:
489         (-[WebDatabaseManager setIDBPerOriginQuota:]):
490         * Storage/WebDatabaseManagerPrivate.h:
491
492 2018-10-31  Antti Koivisto  <antti@apple.com>
493
494         Remove LayerFlushScheduler
495         https://bugs.webkit.org/show_bug.cgi?id=191103
496
497         Reviewed by Anders Carlsson.
498
499         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
500         all the virtual cruft.
501
502         * WebView/WebViewData.h:
503         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
504         (): Deleted.
505         * WebView/WebViewData.mm:
506         (currentRunLoop):
507         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
508         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
509         (WebViewLayerFlushScheduler::schedule):
510         (WebViewLayerFlushScheduler::invalidate):
511         (WebViewLayerFlushScheduler::layerFlushCallback):
512
513 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
514
515         Enable InstallAPI for iOS unconditionally
516         https://bugs.webkit.org/show_bug.cgi?id=191043
517         rdar://problem/32728423
518
519         Reviewed by Dan Bernstein.
520
521         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
522         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
523         shouldn't be processed by InstallAPI.
524         * MigrateHeaders.make: Removed an obsolete workaround.
525         * Misc/NSURLDownloadSPI.h: Added.
526         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
527
528 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
529
530         Clean up some obsolete MAX_ALLOWED macros
531         https://bugs.webkit.org/show_bug.cgi?id=190916
532
533         Reviewed by Tim Horton.
534
535         * WebView/WebHTMLView.mm:
536         (-[WebHTMLView pressureChangeWithEvent:]):
537         * WebView/WebPDFView.h:
538
539 2018-10-30  Commit Queue  <commit-queue@webkit.org>
540
541         Unreviewed, rolling out r237600 and r237604.
542         https://bugs.webkit.org/show_bug.cgi?id=191086
543
544         Breaks internal iOS builds (Requested by ryanhadd_ on
545         #webkit).
546
547         Reverted changesets:
548
549         "Enable InstallAPI for iOS unconditionally"
550         https://bugs.webkit.org/show_bug.cgi?id=191043
551         https://trac.webkit.org/changeset/237600
552
553         "Build fix attempt after enabling InstallAPI for iOS."
554         https://bugs.webkit.org/show_bug.cgi?id=191043
555         https://trac.webkit.org/changeset/237604
556
557 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
558
559         Enable InstallAPI for iOS unconditionally
560         https://bugs.webkit.org/show_bug.cgi?id=191043
561         rdar://problem/32728423
562
563         Reviewed by Dan Bernstein.
564
565         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
566         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
567         shouldn't be processed by InstallAPI.
568         * MigrateHeaders.make: Removed an obsolete workaround.
569         * Misc/NSURLDownloadSPI.h: Added.
570         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
571
572 2018-10-29  Tim Horton  <timothy_horton@apple.com>
573
574         Modernize WebKit nibs and lprojs for localization's sake
575         https://bugs.webkit.org/show_bug.cgi?id=190911
576         <rdar://problem/45349466>
577
578         Reviewed by Dan Bernstein.
579
580         * Misc/WebNSControlExtras.m:
581         (-[NSControl sizeToFitAndAdjustWindowHeight]):
582         NSWindow and its contents are both in the same scale space these days; avoid
583         double-applying the scale factor, or you can't see the prompt.
584
585         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
586         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
587         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
588         NIB->XIB
589
590 2018-10-25  Antoine Quint  <graouts@apple.com>
591
592         [Web Animations] Turn Web Animations CSS Integration off by default
593         https://bugs.webkit.org/show_bug.cgi?id=190901
594
595         Reviewed by Dean Jackson.
596
597         * WebView/WebPreferences.mm:
598         (+[WebPreferences initialize]):
599
600 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
601
602         Clean up some obsolete macOS version guards
603         https://bugs.webkit.org/show_bug.cgi?id=190887
604
605         Reviewed by Dan Bernstein.
606
607         * Misc/WebNSPasteboardExtras.mm:
608         (+[NSPasteboard _web_dragTypesForURL]):
609         * WebCoreSupport/PopupMenuMac.mm:
610         (PopupMenuMac::show):
611         * WebCoreSupport/WebEditorClient.h:
612         * WebCoreSupport/WebEditorClient.mm:
613         (WebEditorClient::respondToChangedSelection):
614         * WebView/WebPDFView.mm:
615         (-[WebPDFView _clipViewForPDFDocumentView]):
616
617 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
618
619         Turn on Conic Gradients
620         https://bugs.webkit.org/show_bug.cgi?id=190810
621
622         Reviewed by Tim Horton.
623
624         * Configurations/FeatureDefines.xcconfig:
625
626 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
627
628         Cleanup: MIMETypeRegistry functions
629         https://bugs.webkit.org/show_bug.cgi?id=190838
630
631         Reviewed by Simon Fraser.
632
633         * Misc/WebNSPasteboardExtras.mm:
634         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
635         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
636         because they were identical.
637
638         * WebView/WebHTMLRepresentation.mm:
639         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
640         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
641         (+[WebHTMLRepresentation supportedImageMIMETypes]):
642         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
643         * WebView/WebView.mm:
644         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
645         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
646         (+[WebView registerViewClass:representationClass:forMIMEType:]):
647
648 2018-10-23  David Kilzer  <ddkilzer@apple.com>
649
650         Fix false positive leaks when using custom -init methods that don't start with -init
651         <https://webkit.org/b/190818>
652         <rdar://problem/45476042>
653
654         Reviewed by Dan Bernstein.
655
656         * Misc/WebKitErrors.m: Move `descriptions` static global so that
657         it is accessible by both categories.
658         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
659         NSError (WebKitInternal) category.  Add attribute to make this
660         behave like an -init method.
661         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
662         NSError (WebKitInternal) category.  Modernize method.  Replace
663         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
664
665 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
666
667         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
668         https://bugs.webkit.org/show_bug.cgi?id=190729
669
670         Reviewed by Tim Horton.
671
672         * DOM/DOM.mm:
673         (-[DOMNode boundingBox]):
674         * DOM/DOMElement.mm:
675         * DOM/DOMHTML.mm:
676         * DOM/DOMInternal.mm:
677         * DOM/DOMUIKitExtensions.mm:
678         * DOM/WebDOMOperations.mm:
679         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
680         * DefaultDelegates/WebDefaultEditingDelegate.m:
681         * DefaultDelegates/WebDefaultPolicyDelegate.m:
682         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
683         * DefaultDelegates/WebDefaultUIDelegate.h:
684         * DefaultDelegates/WebDefaultUIDelegate.mm:
685         (-[WebDefaultUIDelegate webViewClose:]):
686         (-[WebDefaultUIDelegate webViewFocus:]):
687         (-[WebDefaultUIDelegate webViewUnfocus:]):
688         (-[WebDefaultUIDelegate webViewIsResizable:]):
689         (-[WebDefaultUIDelegate webView:setResizable:]):
690         (-[WebDefaultUIDelegate webView:setFrame:]):
691         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
692         * History/BackForwardList.h:
693         * History/BackForwardList.mm:
694         * History/WebBackForwardList.mm:
695         (+[WebBackForwardList initialize]):
696         (bumperCarBackForwardHackNeeded):
697         * History/WebHistory.mm:
698         (-[WebHistoryPrivate addItem:discardDuplicate:]):
699         (-[WebHistory _sendNotification:entries:]):
700         (-[WebHistory loadFromURL:error:]):
701         (-[WebHistory saveToURL:error:]):
702         * History/WebHistoryItem.mm:
703         (WKNotifyHistoryItemChanged):
704         (+[WebHistoryItem initialize]):
705         (-[WebHistoryItem initFromDictionaryRepresentation:]):
706         * History/WebURLsWithTitles.m:
707         * Misc/WebCache.mm:
708         (+[WebCache initialize]):
709         * Misc/WebDownload.mm:
710         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
711         * Misc/WebElementDictionary.mm:
712         (+[WebElementDictionary initialize]):
713         (+[WebElementDictionary initializeLookupTable]):
714         * Misc/WebIconDatabase.mm:
715         * Misc/WebKitNSStringExtras.mm:
716         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
717         * Misc/WebKitVersionChecks.h:
718         * Misc/WebKitVersionChecks.mm:
719         (WebKitLinkedOnOrAfter):
720         (WebKitLinkTimeVersion):
721         * Misc/WebLocalizableStrings.mm:
722         * Misc/WebNSControlExtras.h:
723         * Misc/WebNSControlExtras.m:
724         * Misc/WebNSEventExtras.m:
725         * Misc/WebNSFileManagerExtras.mm:
726         * Misc/WebNSImageExtras.h:
727         * Misc/WebNSImageExtras.m:
728         * Misc/WebNSPasteboardExtras.mm:
729         * Misc/WebNSPrintOperationExtras.h:
730         * Misc/WebNSPrintOperationExtras.m:
731         * Misc/WebNSViewExtras.m:
732         * Misc/WebNSWindowExtras.m:
733         * Panels/WebAuthenticationPanel.h:
734         * Panels/WebAuthenticationPanel.m:
735         * Panels/WebPanelAuthenticationHandler.m:
736         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
737         (+[WebHostedNetscapePluginView initialize]):
738         * Plugins/WebBasePluginPackage.h:
739         * Plugins/WebBasePluginPackage.mm:
740         * Plugins/WebJavaPlugIn.h:
741         * Plugins/WebPluginContainerCheck.mm:
742         * Plugins/WebPluginController.h:
743         * Plugins/WebPluginController.mm:
744         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
745         (-[WebPluginController addPlugin:]):
746         (-[WebPluginController destroyPlugin:]):
747         (-[WebPluginController destroyAllPlugins]):
748         * Plugins/WebPluginDatabase.mm:
749         (+[WebPluginDatabase _defaultPlugInPaths]):
750         * Plugins/WebPluginPackage.mm:
751         (-[WebPluginPackage initWithPath:]):
752         * Storage/WebDatabaseManager.mm:
753         (-[WebDatabaseManager deleteAllDatabases]):
754         * Storage/WebDatabaseManagerClient.h:
755         * Storage/WebDatabaseManagerClient.mm:
756         (WebDatabaseManagerClient::WebDatabaseManagerClient):
757         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
758         * Storage/WebStorageManager.mm:
759         (-[WebStorageManager deleteAllOrigins]):
760         (WebKitInitializeStorageIfNecessary):
761         * WebCoreSupport/WebAlternativeTextClient.h:
762         * WebCoreSupport/WebApplicationCache.mm:
763         (applicationCacheBundleIdentifier):
764         * WebCoreSupport/WebChromeClient.h:
765         * WebCoreSupport/WebChromeClient.mm:
766         (WebChromeClient::setWindowRect):
767         (WebChromeClient::windowRect):
768         (WebChromeClient::takeFocus):
769         (WebChromeClient::addMessageToConsole):
770         (WebChromeClient::enableSuddenTermination):
771         (WebChromeClient::disableSuddenTermination):
772         (WebChromeClient::createPopupMenu const):
773         (WebChromeClient::createSearchPopupMenu const):
774         (WebChromeClient::shouldPaintEntireContents const):
775         (WebChromeClient::supportsVideoFullscreen):
776         (WebChromeClient::supportsFullScreenForElement):
777         (WebChromeClient::enterFullScreenForElement):
778         (WebChromeClient::exitFullScreenForElement):
779         * WebCoreSupport/WebContextMenuClient.mm:
780         * WebCoreSupport/WebDragClient.mm:
781         * WebCoreSupport/WebEditorClient.h:
782         * WebCoreSupport/WebEditorClient.mm:
783         (+[WebUndoStep initialize]):
784         (updateFontPanel):
785         (WebEditorClient::didBeginEditing):
786         (WebEditorClient::respondToChangedContents):
787         (WebEditorClient::respondToChangedSelection):
788         (WebEditorClient::canceledComposition):
789         (WebEditorClient::didEndEditing):
790         (WebEditorClient::didWriteSelectionToPasteboard):
791         (attributesForAttributedStringConversion):
792         (WebEditorClient::setInsertionPasteboard):
793         (WebEditorClient::registerUndoOrRedoStep):
794         (WebEditorClient::handleKeyboardEvent):
795         (WebEditorClient::handleInputMethodKeydown):
796         (WebEditorClient::textDidChangeInTextField):
797         (WebEditorClient::requestCheckingOfString):
798         * WebCoreSupport/WebFrameLoaderClient.h:
799         * WebCoreSupport/WebFrameLoaderClient.mm:
800         (WebFrameLoaderClient::detachedFromParent2):
801         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
802         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
803         (WebFrameLoaderClient::dispatchWillSendRequest):
804         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
805         (WebFrameLoaderClient::dispatchDidReceiveResponse):
806         (WebFrameLoaderClient::willCacheResponse const):
807         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
808         (WebFrameLoaderClient::dispatchDidFinishLoading):
809         (WebFrameLoaderClient::dispatchDidFailLoading):
810         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
811         (WebFrameLoaderClient::dispatchWillClose):
812         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
813         (WebFrameLoaderClient::dispatchDidCommitLoad):
814         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
815         (WebFrameLoaderClient::dispatchDidFailLoad):
816         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
817         (WebFrameLoaderClient::dispatchDidFinishLoad):
818         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
819         (WebFrameLoaderClient::willChangeTitle):
820         (WebFrameLoaderClient::didChangeTitle):
821         (WebFrameLoaderClient::didReplaceMultipartContent):
822         (WebFrameLoaderClient::updateGlobalHistory):
823         (WebFrameLoaderClient::saveViewStateToItem):
824         (WebFrameLoaderClient::restoreViewState):
825         (WebFrameLoaderClient::provisionalLoadStarted):
826         (WebFrameLoaderClient::prepareForDataSourceReplacement):
827         (WebFrameLoaderClient::setTitle):
828         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
829         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
830         (WebFrameLoaderClient::transitionToCommittedForNewPage):
831         (WebFrameLoaderClient::didRestoreFromPageCache):
832         (WebFrameLoaderClient::actionDictionary const):
833         (WebFrameLoaderClient::createPlugin):
834         (WebFrameLoaderClient::getLoadDecisionForIcons):
835         (WebFrameLoaderClient::finishedLoadingIcon):
836         (+[WebFramePolicyListener initialize]):
837         * WebCoreSupport/WebFrameNetworkingContext.mm:
838         * WebCoreSupport/WebGeolocationClient.h:
839         * WebCoreSupport/WebGeolocationClient.mm:
840         (WebGeolocationClient::requestPermission):
841         * WebCoreSupport/WebInspectorClient.h:
842         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
843         * WebCoreSupport/WebNotificationClient.mm:
844         * WebCoreSupport/WebOpenPanelResultListener.mm:
845         * WebCoreSupport/WebPlatformStrategies.h:
846         * WebCoreSupport/WebPlatformStrategies.mm:
847         * WebCoreSupport/WebProgressTrackerClient.h:
848         * WebCoreSupport/WebProgressTrackerClient.mm:
849         (WebProgressTrackerClient::progressStarted):
850         (WebProgressTrackerClient::progressEstimateChanged):
851         (WebProgressTrackerClient::progressFinished):
852         * WebCoreSupport/WebSecurityOrigin.mm:
853         * WebInspector/WebNodeHighlight.h:
854         * WebInspector/WebNodeHighlight.mm:
855         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
856         (-[WebNodeHighlight dealloc]):
857         (-[WebNodeHighlight attach]):
858         * WebInspector/WebNodeHighlightView.h:
859         * WebInspector/WebNodeHighlightView.mm:
860         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
861         (-[WebNodeHighlightView dealloc]):
862         * WebInspector/WebNodeHighlighter.mm:
863         (-[WebNodeHighlighter highlight]):
864         * WebView/WebArchive.mm:
865         (+[WebArchivePrivate initialize]):
866         * WebView/WebClipView.h:
867         * WebView/WebDataSource.mm:
868         (WebDataSourcePrivate::WebDataSourcePrivate):
869         (+[WebDataSource initialize]):
870         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
871         (-[WebDataSource _makeRepresentation]):
872         * WebView/WebDelegateImplementationCaching.h:
873         * WebView/WebDelegateImplementationCaching.mm:
874         (CallDelegate):
875         (CallDelegateReturningFloat):
876         (CallDelegateReturningBoolean):
877         (CallUIDelegate):
878         (CallUIDelegateReturningFloat):
879         (CallUIDelegateReturningBoolean):
880         (CallFrameLoadDelegate):
881         (CallFrameLoadDelegateReturningBoolean):
882         (CallResourceLoadDelegate):
883         (CallScriptDebugDelegate):
884         (CallFormDelegate):
885         (CallFormDelegateReturningBoolean):
886         * WebView/WebDeviceOrientation.mm:
887         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
888         * WebView/WebDocumentInternal.h:
889         * WebView/WebDocumentLoaderMac.mm:
890         (needsDataLoadWorkaround):
891         * WebView/WebDynamicScrollBarsViewInternal.h:
892         * WebView/WebFormDelegate.m:
893         * WebView/WebFrame.mm:
894         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
895         (-[WebFrame _unmarkAllMisspellings]):
896         (-[WebFrame _paintBehaviorForDestinationContext:]):
897         (-[WebFrame _drawRect:contentsOnly:]):
898         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
899         (-[WebFrame _scrollDOMRangeToVisible:]):
900         (-[WebFrame _bodyBackgroundColor]):
901         (-[WebFrame accessibilityRoot]):
902         (needsMicrosoftMessengerDOMDocumentWorkaround):
903         * WebView/WebFrameInternal.h:
904         * WebView/WebFrameView.mm:
905         (-[WebFrameView _setDocumentView:]):
906         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
907         (-[WebFrameView _viewClassForMIMEType:]):
908         (-[WebFrameView initWithFrame:]):
909         (-[WebFrameView drawRect:]):
910         (-[WebFrameView _firstResponderIsFormControl]):
911         (-[WebFrameView keyDown:keyDown:]):
912         (-[WebFrameView _isScrollable]):
913         * WebView/WebFullScreenController.h:
914         * WebView/WebFullScreenController.mm:
915         * WebView/WebHTMLRepresentation.mm:
916         * WebView/WebHTMLView.mm:
917         (-[WebHTMLView hitTest:]):
918         (-[WebHTMLView initWithFrame:]):
919         (-[WebHTMLView dealloc]):
920         (-[WebHTMLView addSubview:]):
921         (-[WebHTMLView mouseDown:]):
922         (-[WebHTMLView mouseUp:]):
923         (-[WebHTMLView resignFirstResponder]):
924         (-[WebHTMLView accessibilityHitTest:]):
925         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
926         * WebView/WebHTMLViewInternal.h:
927         * WebView/WebIndicateLayer.h:
928         * WebView/WebIndicateLayer.mm:
929         * WebView/WebMediaPlaybackTargetPicker.h:
930         * WebView/WebMediaPlaybackTargetPicker.mm:
931         * WebView/WebPDFDocumentExtras.h:
932         * WebView/WebPDFDocumentExtras.mm:
933         * WebView/WebPDFRepresentation.h:
934         * WebView/WebPDFRepresentation.mm:
935         * WebView/WebPDFView.h:
936         * WebView/WebPreferences.mm:
937         (cacheModelForMainBundle):
938         (WebPreferencesPrivate::WebPreferencesPrivate):
939         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
940         (-[WebPreferences encodeWithCoder:]):
941         (+[WebPreferences standardPreferences]):
942         (+[WebPreferences initialize]):
943         (-[WebPreferences _valueForKey:]):
944         (-[WebPreferences _setStringValue:forKey:]):
945         (-[WebPreferences _setIntegerValue:forKey:]):
946         (-[WebPreferences _setUnsignedIntValue:forKey:]):
947         (-[WebPreferences _setFloatValue:forKey:]):
948         (-[WebPreferences _setBoolValue:forKey:]):
949         (-[WebPreferences _setLongLongValue:forKey:]):
950         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
951         (-[WebPreferences _postCacheModelChangedNotification]):
952         (-[WebPreferences _postPreferencesChangedNotification]):
953         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
954         (-[WebPreferences setStorageBlockingPolicy:]):
955         * WebView/WebResource.mm:
956         (+[WebResourcePrivate initialize]):
957         * WebView/WebTextCompletionController.h:
958         * WebView/WebTextIterator.mm:
959         (+[WebTextIteratorPrivate initialize]):
960         * WebView/WebView.mm:
961         (shouldEnableLoadDeferring):
962         (shouldRestrictWindowFocus):
963         (shouldRespectPriorityInCSSAttributeSetters):
964         (shouldUseLegacyBackgroundSizeShorthandBehavior):
965         (shouldAllowPictureInPictureMediaPlayback):
966         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
967         (shouldAllowWindowOpenWithoutUserGesture):
968         (shouldConvertInvalidURLsToBlank):
969         (shouldRequireUserGestureToLoadVideo):
970         (-[WebView _commonInitializationWithFrameName:groupName:]):
971         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
972         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
973         (-[WebView _closePluginDatabases]):
974         (-[WebView _closeWithFastTeardown]):
975         (-[WebView _close]):
976         (+[WebView _MIMETypeForFile:]):
977         (-[WebView setShowingInspectorIndication:]):
978         (-[WebView _setFormDelegate:]):
979         (-[WebView _needsPreHTML5ParserQuirks]):
980         (-[WebView _preferencesChangedNotification:]):
981         (-[WebView _preferencesChanged:]):
982         (-[WebView _cacheResourceLoadDelegateImplementations]):
983         (-[WebView _cacheFrameLoadDelegateImplementations]):
984         (-[WebView _policyDelegateForwarder]):
985         (-[WebView _UIDelegateForwarder]):
986         (-[WebView _editingDelegateForwarder]):
987         (-[WebView _updateActiveState]):
988         (-[_WebSafeForwarder forwardInvocation:]):
989         (+[WebView initialize]):
990         (-[WebView _pluginForMIMEType:]):
991         (-[WebView _pluginForExtension:]):
992         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
993         (+[WebView canShowMIMETypeAsHTML:]):
994         (-[WebView _initWithArguments:]):
995         (-[WebView initWithFrame:frameName:groupName:]):
996         (-[WebView dealloc]):
997         (-[WebView close]):
998         (-[WebView viewDidMoveToWindow]):
999         (-[WebView setUIDelegate:]):
1000         (-[WebView setResourceLoadDelegate:]):
1001         (-[WebView setPolicyDelegate:]):
1002         (-[WebView setFrameLoadDelegate:]):
1003         (-[WebView goBack]):
1004         (-[WebView goForward]):
1005         (-[WebView stringByEvaluatingJavaScriptFromString:]):
1006         (-[WebView setHostWindow:]):
1007         (-[WebView becomeFirstResponder]):
1008         (+[WebView _cacheModelChangedNotification:]):
1009         (-[WebView _frameViewAtWindowPoint:]):
1010         (+[WebView _preflightSpellCheckerNow:]):
1011         (+[WebView _preflightSpellChecker]):
1012         (-[WebView canGoBack]):
1013         (-[WebView canGoForward]):
1014         (-[WebView stopLoading:]):
1015         (-[WebView reload:]):
1016         (-[WebView setMainFrameDocumentReady:]):
1017         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1018         (-[WebView setContinuousSpellCheckingEnabled:]):
1019         (-[WebView undoManager]):
1020         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
1021         (-[WebView isAutomaticLinkDetectionEnabled]):
1022         (-[WebView isAutomaticDashSubstitutionEnabled]):
1023         (-[WebView isAutomaticTextReplacementEnabled]):
1024         (-[WebView isAutomaticSpellingCorrectionEnabled]):
1025         (+[WebView _setCacheModel:]):
1026         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1027         (-[WebView _keyboardUIMode]):
1028         (LayerFlushController::flushLayers):
1029         (-[WebView _scheduleCompositingLayerFlush]):
1030         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1031         (-[WebView fullScreenPlaceholderView]):
1032         (WebInstallMemoryPressureHandler):
1033         * WebView/WebViewData.h:
1034         * WebView/WebViewData.mm:
1035         (+[WebViewPrivate initialize]):
1036         (-[WebViewPrivate init]):
1037         (-[WebViewPrivate dealloc]):
1038         * WebView/WebViewInternal.h:
1039
1040 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1041
1042         Clean up FrameLoader two-state enums
1043         https://bugs.webkit.org/show_bug.cgi?id=190731
1044
1045         Reviewed by Chris Dumez.
1046
1047         * WebCoreSupport/WebFrameLoaderClient.h:
1048         * WebCoreSupport/WebFrameLoaderClient.mm:
1049         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1050
1051 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1052
1053         Unreviewed, rolling out r237137.
1054
1055         SPI is actually used
1056
1057         Reverted changeset:
1058
1059         "Remove unused WebFrame._loadType"
1060         https://bugs.webkit.org/show_bug.cgi?id=190583
1061         https://trac.webkit.org/changeset/237137
1062
1063 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1064
1065         Enable the datalist element by default on iOS and macOS
1066         https://bugs.webkit.org/show_bug.cgi?id=190594
1067         <rdar://problem/45281159>
1068
1069         Reviewed by Ryosuke Niwa and Tim Horton.
1070
1071         * Configurations/FeatureDefines.xcconfig:
1072
1073 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1074
1075         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1076         https://bugs.webkit.org/show_bug.cgi?id=190675
1077
1078         Reviewed by Chris Dumez.
1079
1080         * History/BackForwardList.h:
1081         * History/BackForwardList.mm:
1082         (BackForwardList::backItem):
1083         (BackForwardList::currentItem):
1084         (BackForwardList::forwardItem):
1085         (BackForwardList::backListCount const):
1086         (BackForwardList::forwardListCount const):
1087         (BackForwardList::itemAtIndex):
1088         * History/WebBackForwardList.mm:
1089         (-[WebBackForwardList backItem]):
1090         (-[WebBackForwardList currentItem]):
1091         (-[WebBackForwardList forwardItem]):
1092         (-[WebBackForwardList itemAtIndex:]):
1093
1094 2018-10-16  Timothy Hatcher  <timothy@apple.com>
1095
1096         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
1097         https://bugs.webkit.org/show_bug.cgi?id=190526
1098         rdar://problem/45230140
1099
1100         Reviewed by Dean Jackson.
1101
1102         * WebCoreSupport/WebEditorClient.mm:
1103         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
1104
1105 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1106
1107         Implement feature flag and bindings for CSS Painting API
1108         https://bugs.webkit.org/show_bug.cgi?id=190237
1109
1110         Reviewed by Ryosuke Niwa.
1111
1112         * Configurations/FeatureDefines.xcconfig:
1113
1114 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1115
1116         Replace HistoryItem* with HistoryItem& where possible
1117         https://bugs.webkit.org/show_bug.cgi?id=190617
1118
1119         Reviewed by Chris Dumez.
1120
1121         * History/BackForwardList.h:
1122         * History/BackForwardList.mm:
1123         (BackForwardList::goToItem):
1124         * History/WebBackForwardList.mm:
1125         (-[WebBackForwardList goToItem:]):
1126         * History/WebHistoryItem.mm:
1127         (WKNotifyHistoryItemChanged):
1128         * History/WebHistoryItemInternal.h:
1129
1130 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1131
1132         Remove unused WebHistoryItem._transientPropertyForKey
1133         https://bugs.webkit.org/show_bug.cgi?id=190606
1134
1135         Reviewed by Chris Dumez.
1136
1137         * History/WebHistoryItem.mm:
1138         * History/WebHistoryItemPrivate.h:
1139
1140 2018-10-15  Justin Fan  <justin_fan@apple.com>
1141
1142         Add WebGPU 2018 feature flag and experimental feature flag
1143         https://bugs.webkit.org/show_bug.cgi?id=190509
1144
1145         Reviewed by Dean Jackson.
1146
1147         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1148         for the 2018 WebGPU prototype.
1149
1150         * Configurations/FeatureDefines.xcconfig:
1151         * WebView/WebPreferenceKeysPrivate.h:
1152         * WebView/WebPreferences.mm:
1153         (+[WebPreferences initialize]):
1154         (-[WebPreferences webGPUEnabled]):
1155         (-[WebPreferences setWebGPUEnabled:]):
1156         * WebView/WebPreferencesPrivate.h:
1157         * WebView/WebView.mm:
1158         (-[WebView _preferencesChanged:]):
1159
1160 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1161
1162         Fix iOS build after r237157
1163
1164         * WebView/WebView.mm:
1165         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1166
1167 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1168
1169         Modernize BackForwardClient.h
1170         https://bugs.webkit.org/show_bug.cgi?id=190610
1171
1172         Reviewed by Chris Dumez.
1173
1174         * History/BackForwardList.h:
1175         * History/BackForwardList.mm:
1176         (BackForwardList::backListCount const):
1177         (BackForwardList::forwardListCount const):
1178         (BackForwardList::backListCount): Deleted.
1179         (BackForwardList::forwardListCount): Deleted.
1180         * History/WebBackForwardList.mm:
1181         (-[WebBackForwardList init]):
1182         * WebCoreSupport/WebFrameLoaderClient.mm:
1183         (WebFrameLoaderClient::canCachePage const):
1184         * WebView/WebFrameView.mm:
1185         (-[WebFrameView keyDown:keyDown:]):
1186         * WebView/WebView.mm:
1187         (-[WebView _commonInitializationWithFrameName:groupName:]):
1188         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1189         (-[WebView _loadBackForwardListFromOtherView:]):
1190         (-[WebView initWithCoder:]):
1191         (-[WebView encodeWithCoder:]):
1192         (-[WebView backForwardList]):
1193         (-[WebView setMaintainsBackForwardList:]):
1194
1195 2018-10-15  Timothy Hatcher  <timothy@apple.com>
1196
1197         Add support for prefers-color-scheme media query
1198         https://bugs.webkit.org/show_bug.cgi?id=190499
1199         rdar://problem/45212025
1200
1201         Reviewed by Dean Jackson.
1202
1203         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1204
1205 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1206
1207         Remove unused WebView._globalHistoryItem
1208         https://bugs.webkit.org/show_bug.cgi?id=190601
1209
1210         Reviewed by Chris Dumez.
1211
1212         * WebCoreSupport/WebFrameLoaderClient.h:
1213         * WebCoreSupport/WebFrameLoaderClient.mm:
1214         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1215         * WebView/WebView.mm:
1216         (-[WebView _globalHistoryItem]): Deleted.
1217         (-[WebView _setGlobalHistoryItem:]): Deleted.
1218         * WebView/WebViewData.h:
1219         * WebView/WebViewInternal.h:
1220         * WebView/WebViewPrivate.h:
1221
1222 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1223
1224         Remove unused parameters from FrameLoaderClient::createFrame
1225         https://bugs.webkit.org/show_bug.cgi?id=190587
1226
1227         Reviewed by Chris Dumez.
1228
1229         * WebCoreSupport/WebFrameLoaderClient.h:
1230         * WebCoreSupport/WebFrameLoaderClient.mm:
1231         (WebFrameLoaderClient::createFrame):
1232
1233 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1234
1235         Remove unused WebFrame._loadType
1236         https://bugs.webkit.org/show_bug.cgi?id=190583
1237
1238         Reviewed by Chris Dumez.
1239
1240         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
1241
1242         * WebView/WebFrame.mm:
1243         (toWebFrameLoadType): Deleted.
1244         (-[WebFrame _loadType]): Deleted.
1245         * WebView/WebFramePrivate.h:
1246
1247 2018-10-15  Chris Dumez  <cdumez@apple.com>
1248
1249         Restrict browsing context lookup by name to frames that are related to one another
1250         https://bugs.webkit.org/show_bug.cgi?id=190475
1251
1252         Reviewed by Alex Christensen.
1253
1254         * WebView/WebFrame.mm:
1255         (-[WebFrame findFrameNamed:]):
1256
1257 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1258
1259         Remove InjectedBundle processing of back/forward lists
1260         https://bugs.webkit.org/show_bug.cgi?id=190459
1261
1262         Reviewed by Chris Dumez.
1263
1264         * WebCoreSupport/WebFrameLoaderClient.h:
1265         * WebCoreSupport/WebFrameLoaderClient.mm:
1266         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1267
1268 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1269
1270         [JSC] Remove Option::useAsyncIterator
1271         https://bugs.webkit.org/show_bug.cgi?id=190567
1272
1273         Reviewed by Saam Barati.
1274
1275         * Configurations/FeatureDefines.xcconfig:
1276
1277 2018-10-12  Alex Christensen  <achristensen@webkit.org>
1278
1279         Allow encoding of small enum classes
1280         https://bugs.webkit.org/show_bug.cgi?id=190531
1281
1282         Reviewed by Tim Horton.
1283
1284         * WebCoreSupport/WebFrameLoaderClient.mm:
1285         (-[WebFramePolicyListener dealloc]):
1286
1287 2018-10-11  Keith Rollin  <krollin@apple.com>
1288
1289         CURRENT_ARCH should not be used in Run Script phase.
1290         https://bugs.webkit.org/show_bug.cgi?id=190407
1291         <rdar://problem/45133556>
1292
1293         Reviewed by Alexey Proskuryakov.
1294
1295         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
1296         CURRENT_ARCH is not well-defined during this phase (and may even have
1297         the value "undefined") since this phase is run just once per build
1298         rather than once per supported architecture. Migrate away from
1299         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
1300         performing an operation for each value, or by picking the first entry
1301         in ARCHS and using that as a representative value.
1302
1303         * Configurations/WebKitLegacy.xcconfig: When generating
1304         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
1305         macosx platforms.
1306
1307         * MigrateHeaders.make:
1308         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
1309         generate one for each architecture in ARCHS.
1310
1311 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1312
1313         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
1314         https://bugs.webkit.org/show_bug.cgi?id=190429
1315
1316         Reviewed by Saam Barati.
1317
1318         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
1319
1320         * WebView/WebPDFRepresentation.mm:
1321         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
1322
1323 2018-10-08  Justin Fan  <justin_fan@apple.com>
1324
1325         WebGPU: Rename old WebGPU prototype to WebMetal
1326         https://bugs.webkit.org/show_bug.cgi?id=190325
1327         <rdar://problem/44990443>
1328
1329         Reviewed by Dean Jackson.
1330
1331         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
1332
1333         * Configurations/FeatureDefines.xcconfig:
1334         * WebView/WebPreferenceKeysPrivate.h:
1335         * WebView/WebPreferences.mm:
1336         (+[WebPreferences initialize]):
1337         (-[WebPreferences webMetalEnabled]):
1338         (-[WebPreferences setWebMetalEnabled:]):
1339         (-[WebPreferences webGPUEnabled]): Deleted.
1340         (-[WebPreferences setWebGPUEnabled:]): Deleted.
1341         * WebView/WebPreferencesPrivate.h:
1342         * WebView/WebView.mm:
1343         (-[WebView _preferencesChanged:]):
1344
1345 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
1346
1347         Make <input type=color> a runtime enabled (on-by-default) feature
1348         https://bugs.webkit.org/show_bug.cgi?id=189162
1349
1350         Reviewed by Wenson Hsieh and Tim Horton.
1351
1352         * Configurations/FeatureDefines.xcconfig:
1353
1354 2018-10-07  Dan Bernstein  <mitz@apple.com>
1355
1356         Fixed building with the latest macOS SDK
1357
1358         * Plugins/WebNetscapePluginPackage.mm:
1359         (-[WebNetscapePluginPackage openResourceFile]):
1360         (-[WebNetscapePluginPackage closeResourceFile:]):
1361
1362 2018-10-04  Dan Bernstein  <mitz@apple.com>
1363
1364         More Carbon build-fixing.
1365
1366         * Carbon/CarbonWindowAdapter.mm:
1367         (-[CarbonWindowAdapter _destroyRealWindow:]):
1368         (-[CarbonWindowAdapter _growBoxRect]):
1369
1370 2018-10-04  Dan Bernstein  <mitz@apple.com>
1371
1372         Retried to fix 32-bit macOS builds after r236846.
1373
1374         * WebView/WebHTMLView.mm:
1375         (-[WebHTMLView setMarkedText:selectedRange:]):
1376
1377 2018-10-04  Dan Bernstein  <mitz@apple.com>
1378
1379         Retried to fix 32-bit macOS builds after r236846.
1380
1381         * Carbon/HIWebView.mm:
1382         (ActiveStateChanged):
1383
1384 2018-10-04  Dan Bernstein  <mitz@apple.com>
1385
1386         Tried to fix 32-bit macOS builds after r236846.
1387
1388         * Carbon/HIWebView.mm:
1389         (_NSSelectorForHICommand):
1390
1391 2018-10-04  Dan Bernstein  <mitz@apple.com>
1392
1393         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
1394         https://bugs.webkit.org/show_bug.cgi?id=190250
1395
1396         Reviewed by Andy Estes.
1397
1398         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
1399           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
1400           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
1401           an earlier line set it to YES.
1402
1403         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
1404         changes below.
1405
1406         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
1407           provides some missing method declarations.
1408
1409         * Misc/WebDownload.mm:
1410         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
1411           a deprecated method.
1412
1413         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
1414
1415         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
1416           other code in the file uses a method from it.
1417
1418         * Plugins/WebBaseNetscapePluginView.mm:
1419         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
1420           a deprecated method.
1421
1422         * Plugins/WebPluginController.mm:
1423         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
1424           around use of a selector that may be present in some WebKit client.
1425
1426         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
1427           method declarations.
1428
1429         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
1430           from here.
1431
1432         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
1433           missing method declarations.
1434
1435         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
1436           from here.
1437
1438         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
1439           call from here.
1440         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
1441           an obsolete delegate method for binary compatibility.
1442         (pluginView): Ditto.
1443
1444         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
1445           call from here.
1446
1447         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
1448           WebDeviceOrientationProviderMock protocol.
1449
1450         * WebView/WebDeviceOrientationProviderMock.mm:
1451         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
1452           main @implementation.
1453
1454         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
1455           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
1456
1457         * WebView/WebDynamicScrollBarsView.mm:
1458         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
1459           of a deprecated method.
1460
1461         * WebView/WebHTMLView.mm:
1462         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
1463           selector warning around action methods that are not declared anywhere in WebKit.
1464
1465         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
1466           about implementing this deprecated method.
1467         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
1468         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1469         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1470         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1471         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1472         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1473         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1474         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1475         (-[WebHTMLView doCommandBySelector:]): Ditto.
1476         (-[WebHTMLView insertText:]): Ditto.
1477
1478         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
1479
1480         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
1481
1482         * WebView/WebPDFView.h: Removed previewView ivar.
1483
1484         * WebView/WebPDFView.mm:
1485           Removed declaration of FileInternal category and merged its implementation with the main
1486           implementation.
1487         (-[WebPDFView dealloc]): Removed previewView ivar.
1488         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
1489           exist in macOS versions we support.
1490         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
1491         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
1492           action methods internal to PDFKit.
1493         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
1494         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
1495
1496         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
1497           call on macOS, even though in r86988 we started calling different methods on iOS.
1498
1499         * WebView/WebView.mm:
1500         - Imported headers that declare delegate methods that we call.
1501         - Removed declaration of WebFileInternal category and merged its implementation with the
1502           main implementation.
1503         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
1504           category, which made them impossible to call from the main implementation. Moved those
1505           into the main implementation. One of those had to be declared in a class extension,
1506           because it is called from a method implemented in the WebPrivate category, and that
1507           category’s implementation appears first in the file.
1508
1509         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
1510           around use of obsolete delegate method for binary compatibility.
1511
1512         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
1513
1514 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
1515
1516         Runtime flag and IDL for MediaRecorder
1517         https://bugs.webkit.org/show_bug.cgi?id=190018
1518
1519         Reviewed by Youenn Fablet and Chris Dumez.
1520
1521         * WebView/WebPreferenceKeysPrivate.h:
1522         * WebView/WebPreferences.mm:
1523         (+[WebPreferences initialize]):
1524         (-[WebPreferences mediaRecorderEnabled]):
1525         (-[WebPreferences setMediaRecorderEnabled:]):
1526         * WebView/WebPreferencesPrivate.h:
1527         * WebView/WebView.mm:
1528         (-[WebView _preferencesChanged:]):
1529
1530 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1531
1532         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
1533         https://bugs.webkit.org/show_bug.cgi?id=190238
1534
1535         Reviewed by Antti Koivisto.
1536
1537         Enabled the feature by default.
1538
1539         * WebView/WebPreferences.mm:
1540         (+[WebPreferences initialize]):
1541
1542 2018-10-01  Dean Jackson  <dino@apple.com>
1543
1544         [macOS] Switching to discrete GPU should be done in the UI process
1545         https://bugs.webkit.org/show_bug.cgi?id=189361
1546         <rdar://problem/43949622>
1547
1548         Reviewed by Simon Fraser.
1549
1550         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
1551         not support swapping to the discrete GPU in this configuration.
1552
1553         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
1554         (WebKit::WebSwitchingGPUClient::singleton):
1555         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
1556         * WebView/WebView.mm:
1557         (-[WebView _commonInitializationWithFrameName:groupName:]):
1558
1559 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1560
1561         Remove ParsedURLString
1562         https://bugs.webkit.org/show_bug.cgi?id=190154
1563
1564         Reviewed by Chris Dumez.
1565
1566         * WebView/WebScriptDebugger.mm:
1567         (toNSURL):
1568
1569 2018-10-01  Dean Jackson  <dino@apple.com>
1570
1571         Remove CSS Animation Triggers
1572         https://bugs.webkit.org/show_bug.cgi?id=190175
1573         <rdar://problem/44925626>
1574
1575         Reviewed by Simon Fraser.
1576
1577         * Configurations/FeatureDefines.xcconfig:
1578
1579 2018-10-02  Commit Queue  <commit-queue@webkit.org>
1580
1581         Unreviewed, rolling out r236624 and r236671.
1582         https://bugs.webkit.org/show_bug.cgi?id=190207
1583
1584         The change in r236624 introduced crashes on the bots
1585         (Requested by ryanhaddad on #webkit).
1586
1587         Reverted changesets:
1588
1589         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1590         https://bugs.webkit.org/show_bug.cgi?id=188747
1591         https://trac.webkit.org/changeset/236624
1592
1593         "Unify implementation in VideoFullscreenInterfaceAVKit"
1594         https://bugs.webkit.org/show_bug.cgi?id=190091
1595         https://trac.webkit.org/changeset/236671
1596
1597 2018-10-01  Alex Christensen  <achristensen@webkit.org>
1598
1599         URL should not use TextEncoding internally
1600         https://bugs.webkit.org/show_bug.cgi?id=190111
1601
1602         Reviewed by Andy Estes.
1603
1604         * Misc/WebNSURLExtras.mm:
1605
1606 2018-09-28  Jer Noble  <jer.noble@apple.com>
1607
1608         Refactoring: eliminate raw pointer usage in Fullscreen code
1609         https://bugs.webkit.org/show_bug.cgi?id=188747
1610         <rdar://problem/43541164>
1611
1612         Reviewed by Alex Christensen.
1613
1614         PlaybackSessionInterface no longer has an invalidate() method.
1615
1616         * WebView/WebView.mm:
1617         (-[WebView _clearPlaybackControlsManager]):
1618
1619 2018-09-28  Chris Dumez  <cdumez@apple.com>
1620
1621         Drop support for cross-origin-window-policy header
1622         https://bugs.webkit.org/show_bug.cgi?id=190081
1623
1624         Reviewed by Ryosuke Niwa.
1625
1626         * WebView/WebPreferenceKeysPrivate.h:
1627         * WebView/WebPreferences.mm:
1628         (+[WebPreferences initialize]):
1629         * WebView/WebPreferencesPrivate.h:
1630         * WebView/WebView.mm:
1631         (-[WebView _preferencesChanged:]):
1632
1633 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
1634
1635         Rename createMarkup to serializePreservingVisualAppearance
1636         https://bugs.webkit.org/show_bug.cgi?id=190086
1637
1638         Reviewed by Wenson Hsieh.
1639
1640         * DOM/WebDOMOperations.mm:
1641         (-[DOMRange markupString]):
1642
1643 2018-09-28  Commit Queue  <commit-queue@webkit.org>
1644
1645         Unreviewed, rolling out r236605.
1646         https://bugs.webkit.org/show_bug.cgi?id=190087
1647
1648         caused three API test timeouts (Requested by jernoble on
1649         #webkit).
1650
1651         Reverted changeset:
1652
1653         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1654         https://bugs.webkit.org/show_bug.cgi?id=188747
1655         https://trac.webkit.org/changeset/236605
1656
1657 2018-09-28  Jer Noble  <jer.noble@apple.com>
1658
1659         Refactoring: eliminate raw pointer usage in Fullscreen code
1660         https://bugs.webkit.org/show_bug.cgi?id=188747
1661         <rdar://problem/43541164>
1662
1663         Reviewed by Alex Christensen.
1664
1665         PlaybackSessionInterface no longer has an invalidate() method.
1666
1667         * WebView/WebView.mm:
1668         (-[WebView _clearPlaybackControlsManager]):
1669
1670 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1671
1672         Use enum class in createMarkup arguments
1673         https://bugs.webkit.org/show_bug.cgi?id=190028
1674
1675         Reviewed by Wenson Hsieh.
1676
1677         * DOM/WebDOMOperations.mm:
1678         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
1679         (-[DOMRange markupString]): Ditto.
1680
1681 2018-09-27  Antoine Quint  <graouts@apple.com>
1682
1683         [Web Animations] Turn Web Animations with CSS integration on
1684         https://bugs.webkit.org/show_bug.cgi?id=184819
1685         <rdar://problem/39597337>
1686
1687         Reviewed by Dean Jackson.
1688
1689         * WebView/WebPreferences.mm:
1690         (+[WebPreferences initialize]):
1691
1692 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1693
1694         Selection should work across shadow boundary when initiated by a mouse drag
1695         https://bugs.webkit.org/show_bug.cgi?id=151380
1696         <rdar://problem/24363872>
1697
1698         Reviewed by Wenson Hsieh.
1699
1700         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
1701
1702         * WebView/WebPreferenceKeysPrivate.h:
1703         * WebView/WebPreferences.mm:
1704         (+[WebPreferences initialize]):
1705         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
1706         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
1707         * WebView/WebPreferencesPrivate.h:
1708         * WebView/WebView.mm:
1709         (-[WebView _preferencesChanged:]):
1710
1711 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1712
1713         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
1714         https://bugs.webkit.org/show_bug.cgi?id=189918
1715         Work towards <rdar://problem/44648705>
1716
1717         Reviewed by Tim Horton.
1718
1719         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
1720
1721         * WebView/WebHTMLView.mm:
1722         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1723         (-[WebHTMLView _updateFontPanel]):
1724         * WebView/WebView.mm:
1725         (-[WebView typingAttributes]):
1726
1727 2018-09-17  Darin Adler  <darin@apple.com>
1728
1729         Use OpaqueJSString rather than JSRetainPtr inside WebKit
1730         https://bugs.webkit.org/show_bug.cgi?id=189652
1731
1732         Reviewed by Saam Barati.
1733
1734         * WebView/WebPDFRepresentation.mm:
1735         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
1736
1737 2018-09-14  Jer Noble  <jer.noble@apple.com>
1738
1739         Turn SourceBufferChangeTypeEnabled on by default
1740         https://bugs.webkit.org/show_bug.cgi?id=189527
1741
1742         Reviewed by Eric Carlson.
1743
1744         * WebView/WebPreferences.mm:
1745         (+[WebPreferences initialize]):
1746
1747 2018-09-12  Alex Christensen  <achristensen@webkit.org>
1748
1749         Fix an internal build after r235935
1750         https://bugs.webkit.org/show_bug.cgi?id=188996
1751
1752         * Carbon/HIWebView.mm:
1753         (Draw):
1754         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
1755
1756 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
1757
1758         Add IGNORE_WARNING_.* macros
1759         https://bugs.webkit.org/show_bug.cgi?id=188996
1760
1761         Reviewed by Michael Catanzaro.
1762
1763         * Carbon/CarbonUtils.m:
1764         (PoolCleaner):
1765         * Carbon/CarbonWindowAdapter.mm:
1766         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1767         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1768         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1769         (-[CarbonWindowAdapter _termWindowIfOwner]):
1770         (-[CarbonWindowAdapter _windowMovedToRect:]):
1771         (-[CarbonWindowAdapter setContentView:]):
1772         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1773         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1774         * Carbon/CarbonWindowFrame.m:
1775         (-[CarbonWindowFrame title]):
1776         * Carbon/HIViewAdapter.m:
1777         (+[HIViewAdapter getHIViewForNSView:]):
1778         * Carbon/HIWebView.mm:
1779         (overrideCGContext):
1780         (restoreCGContext):
1781         (Draw):
1782         * DOM/DOM.mm:
1783         * History/WebHistory.mm:
1784         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1785         * History/WebHistoryItem.mm:
1786         (-[WebHistoryItem icon]):
1787         * Misc/WebKitNSStringExtras.mm:
1788         (-[NSString _web_drawAtPoint:font:textColor:]):
1789         * Misc/WebNSImageExtras.m:
1790         (-[NSImage _web_scaleToMaxSize:]):
1791         (-[NSImage _web_dissolveToFraction:]):
1792         * Misc/WebNSPasteboardExtras.mm:
1793         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1794         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1795         * Panels/WebAuthenticationPanel.m:
1796         (-[WebAuthenticationPanel loadNib]):
1797         * Plugins/Hosted/NetscapePluginHostManager.mm:
1798         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1799         (WebKit::NetscapePluginHostManager::didCreateWindow):
1800         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1801         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
1802         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
1803         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
1804         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1805         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
1806         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1807         (-[WebHostedNetscapePluginView drawRect:]):
1808         * Plugins/Hosted/WebTextInputWindowController.m:
1809         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1810         * Plugins/WebBaseNetscapePluginView.mm:
1811         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
1812         * Plugins/WebNetscapePluginPackage.mm:
1813         (-[WebNetscapePluginPackage _tryLoad]):
1814         * Plugins/WebNetscapePluginView.mm:
1815         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1816         (-[WebNetscapePluginView sendDrawRectEvent:]):
1817         (-[WebNetscapePluginView drawRect:]):
1818         * Plugins/WebPluginController.mm:
1819         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1820         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1821         * WebCoreSupport/PopupMenuMac.mm:
1822         (PopupMenuMac::populate):
1823         * WebCoreSupport/WebAlternativeTextClient.h:
1824         * WebCoreSupport/WebDragClient.mm:
1825         (WebDragClient::startDrag):
1826         * WebCoreSupport/WebFrameLoaderClient.mm:
1827         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1828         (webGetNSImage):
1829         * WebInspector/WebNodeHighlight.mm:
1830         * WebInspector/WebNodeHighlightView.mm:
1831         (-[WebNodeHighlightView drawRect:]):
1832         * WebView/WebClipView.mm:
1833         (-[WebClipView initWithFrame:]):
1834         * WebView/WebFrame.mm:
1835         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1836         (-[WebFrame _drawRect:contentsOnly:]):
1837         (-[WebFrame accessibilityRoot]):
1838         * WebView/WebFullScreenController.mm:
1839         (-[WebFullScreenController enterFullScreen:]):
1840         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1841         (-[WebFullScreenController exitFullScreen]):
1842         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1843         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1844         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1845         * WebView/WebHTMLView.mm:
1846         (-[NSWindow _web_borderView]):
1847         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1848         (-[WebHTMLView _setAsideSubviews]):
1849         (-[WebHTMLView _autoscroll]):
1850         (-[WebHTMLView drawRect:]):
1851         (-[WebHTMLView mouseDown:]):
1852         (-[WebHTMLView mouseDragged:]):
1853         (-[WebHTMLView mouseUp:]):
1854         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
1855         (-[WebHTMLView knowsPageRange:]):
1856         (-[WebHTMLView accessibilityHitTest:]):
1857         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1858         (-[WebHTMLView _colorAsString:]):
1859         (-[WebHTMLView copyFont:]):
1860         (-[WebHTMLView _executeSavedKeypressCommands]):
1861         (-[WebHTMLView attachRootLayer:]):
1862         (-[WebHTMLView textStorage]):
1863         (-[WebHTMLView _updateSelectionForInputManager]):
1864         * WebView/WebPDFView.mm:
1865         (_applicationInfoForMIMEType):
1866         (-[WebPDFView centerSelectionInVisibleArea:]):
1867         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1868         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1869         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1870         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1871         * WebView/WebTextCompletionController.mm:
1872         (-[WebTextCompletionController _buildUI]):
1873         (-[WebTextCompletionController _placePopupWindow:]):
1874         * WebView/WebVideoFullscreenController.mm:
1875         * WebView/WebVideoFullscreenHUDWindowController.mm:
1876         (createMediaUIBackgroundView):
1877         * WebView/WebView.mm:
1878         (-[WebTextListTouchBarViewController initWithWebView:]):
1879         (-[WebView _dispatchTileDidDraw:]):
1880         (-[WebView encodeWithCoder:]):
1881         (-[WebView mainFrameIcon]):
1882         (LayerFlushController::flushLayers):
1883         * WebView/WebWindowAnimation.mm:
1884         (setScaledFrameForWindow):
1885
1886 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1887
1888         Remove unused needsDestruction class variables from HashTraits
1889         https://bugs.webkit.org/show_bug.cgi?id=189490
1890
1891         Reviewed by Daniel Bates.
1892
1893         * History/BinaryPropertyList.cpp: Removed needsDestruction.
1894
1895 2018-09-07  Frederic Wang  <fwang@igalia.com>
1896
1897         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
1898         https://bugs.webkit.org/show_bug.cgi?id=182230
1899
1900         Reviewed by Simon Fraser.
1901
1902         * DOM/DOMDocument.mm:
1903         (-[DOMDocument scrollingElement]): Use the new name.
1904
1905 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1906
1907         Refactor WebCore::EditAction to be an 8-bit enum class
1908         https://bugs.webkit.org/show_bug.cgi?id=189383
1909
1910         Reviewed by Dan Bernstein.
1911
1912         * WebCoreSupport/WebEditorClient.mm:
1913         (undoNameForEditAction):
1914         * WebView/WebHTMLView.mm:
1915         (-[WebHTMLView pasteFont:]):
1916         (-[WebHTMLView changeFont:]):
1917         (-[WebHTMLView changeAttributes:]):
1918         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
1919         (-[WebHTMLView changeColor:]):
1920         * WebView/WebView.mm:
1921         (-[WebView setTypingStyle:]):
1922
1923 2018-09-06  Frederic Wang  <fwang@igalia.com>
1924
1925         Group options of scrollRectToVisible into a struct
1926         https://bugs.webkit.org/show_bug.cgi?id=189352
1927
1928         Reviewed by Simon Fraser.
1929
1930         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
1931         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
1932         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
1933
1934 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1935
1936         [macOS] Cannot change font size at selection until font panel is shown
1937         https://bugs.webkit.org/show_bug.cgi?id=189295
1938         <rdar://problem/35593389>
1939
1940         Reviewed by Ryosuke Niwa.
1941
1942         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
1943         WebCore ChangeLog for more details.
1944
1945         * WebView/WebHTMLView.mm:
1946         (-[WebHTMLView changeFont:]):
1947         (-[WebHTMLView changeAttributes:]):
1948         (-[WebHTMLView _originalFontA]): Deleted.
1949         (-[WebHTMLView _originalFontB]): Deleted.
1950         (fontNameForDescription): Deleted.
1951         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
1952         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
1953         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
1954
1955 2018-09-05  Jer Noble  <jer.noble@apple.com>
1956
1957         Add MediaCapabilities as an Experimental Feature
1958         https://bugs.webkit.org/show_bug.cgi?id=189209
1959
1960         Reviewed by Eric Carlson.
1961
1962         RuntimeEnabledFeature -> Setting.
1963
1964         * WebView/WebView.mm:
1965         (-[WebView _preferencesChanged:]):
1966
1967 2018-09-04  Frederic Wang  <fwang@igalia.com>
1968
1969         Add basic support for ScrollIntoViewOptions
1970         https://bugs.webkit.org/show_bug.cgi?id=189258
1971
1972         Reviewed by Simon Fraser.
1973
1974         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
1975         header so that this file can build despite the new scrollIntoView function.
1976
1977 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1978
1979         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
1980         https://bugs.webkit.org/show_bug.cgi?id=188890
1981         <rdar://problem/43648605>
1982
1983         Reviewed by Tim Horton.
1984
1985         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
1986         more detail.
1987
1988         * WebCoreSupport/WebPlatformStrategies.h:
1989         * WebCoreSupport/WebPlatformStrategies.mm:
1990         (WebPlatformStrategies::allStringsForType):
1991
1992 2018-09-01  Darin Adler  <darin@apple.com>
1993
1994         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
1995         https://bugs.webkit.org/show_bug.cgi?id=189072
1996         Reviewed by Dan Bernstein.
1997
1998         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
1999         and declarations for NSURLDownload init methods.
2000
2001         * Misc/WebDownloadInternal.h: Removed.
2002
2003         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
2004         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
2005         "-Wdeprecated-declarations" because the method used here is deprecated.
2006
2007         * WebView/WebView.mm:
2008         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
2009         used here is deprecated.
2010
2011 2018-08-31  Chris Dumez  <cdumez@apple.com>
2012
2013         Assertion hit in ~CompletionHandler() from ~WebFrame()
2014         https://bugs.webkit.org/show_bug.cgi?id=189199
2015         <rdar://problem/42657233>
2016
2017         Reviewed by Youenn Fablet.
2018
2019         * WebCoreSupport/WebFrameLoaderClient.h:
2020         * WebCoreSupport/WebFrameLoaderClient.mm:
2021         (WebFrameLoaderClient::dispatchWillSubmitForm):
2022
2023 2018-08-31  Antti Koivisto  <antti@apple.com>
2024
2025         Replace OptionSet |= and -= operators with add() and remove() functions
2026         https://bugs.webkit.org/show_bug.cgi?id=189169
2027
2028         Reviewed by Anders Carlsson.
2029
2030         * WebView/WebFrame.mm:
2031         (-[WebFrame _drawRect:contentsOnly:]):
2032         * WebView/WebView.mm:
2033         (coreOptions):
2034
2035 2018-08-31  Frederic Wang  <fwang@igalia.com>
2036
2037         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
2038         https://bugs.webkit.org/show_bug.cgi?id=182053
2039
2040         Reviewed by Simon Fraser.
2041
2042         Add developer flag to use standard behavior for scrolling* attributes.
2043
2044         * WebView/WebPreferenceKeysPrivate.h:
2045         * WebView/WebPreferences.mm:
2046         (+[WebPreferences initialize]):
2047         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
2048         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
2049         * WebView/WebPreferencesPrivate.h:
2050         * WebView/WebView.mm:
2051         (-[WebView _preferencesChanged:]):
2052
2053 2018-08-29  Olivia Barnett  <obarnett@apple.com>
2054
2055         Implement the Web Share API
2056         https://bugs.webkit.org/show_bug.cgi?id=171100
2057         <rdar://problem/31751734>
2058
2059         Reviewed by Tim Horton.
2060
2061         * WebCoreSupport/WebChromeClient.h:
2062         * WebCoreSupport/WebChromeClient.mm:
2063         (WebChromeClient::showShareSheet):
2064         Empty declaration of showShareSheet.
2065
2066 2018-08-29  Youenn Fablet  <youenn@apple.com>
2067
2068         Remove WebRTC legacy API implementation
2069         https://bugs.webkit.org/show_bug.cgi?id=189040
2070
2071         Reviewed by Eric Carlson.
2072
2073         * WebView/WebPreferenceKeysPrivate.h:
2074         * WebView/WebPreferences.mm:
2075         (+[WebPreferences initialize]):
2076         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
2077         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
2078         * WebView/WebPreferencesPrivate.h:
2079         * WebView/WebView.mm:
2080         (-[WebView _preferencesChanged:]):
2081
2082 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2083
2084         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
2085         https://bugs.webkit.org/show_bug.cgi?id=189054
2086
2087         Reviewed by Andy Estes.
2088
2089         Remove the pasteboard type argument from readURLFromPasteboard.
2090
2091         * WebCoreSupport/WebPlatformStrategies.h:
2092         * WebCoreSupport/WebPlatformStrategies.mm:
2093         (WebPlatformStrategies::readURLFromPasteboard):
2094
2095 2018-08-27  Keith Rollin  <krollin@apple.com>
2096
2097         Unreviewed build fix -- disable LTO for production builds
2098
2099         * Configurations/Base.xcconfig:
2100
2101 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
2102
2103         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
2104         https://bugs.webkit.org/show_bug.cgi?id=188931
2105
2106         Reviewed by Wenson Hsieh.
2107
2108         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
2109
2110 2018-08-27  Keith Rollin  <krollin@apple.com>
2111
2112         Build system support for LTO
2113         https://bugs.webkit.org/show_bug.cgi?id=187785
2114         <rdar://problem/42353132>
2115
2116         Reviewed by Dan Bernstein.
2117
2118         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
2119         LTO.
2120
2121         * Configurations/Base.xcconfig:
2122         * Configurations/DebugRelease.xcconfig:
2123
2124 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
2125
2126         Pass in IsComposed flag to Event constructors
2127         https://bugs.webkit.org/show_bug.cgi?id=188720
2128         <rdar://problem/43580387>
2129
2130         Reviewed by Simon Fraser.
2131
2132         * WebView/WebPDFView.mm:
2133         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
2134         whether it's simulated or not.
2135
2136 2018-08-23  Mark Lam  <mark.lam@apple.com>
2137
2138         Move vmEntryGlobalObject() to VM from CallFrame.
2139         https://bugs.webkit.org/show_bug.cgi?id=188900
2140         <rdar://problem/43655753>
2141
2142         Reviewed by Michael Saboff.
2143
2144         * WebView/WebScriptDebugger.mm:
2145         (WebScriptDebugger::sourceParsed):
2146
2147 2018-08-23  Andy Estes  <aestes@apple.com>
2148
2149         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
2150         https://bugs.webkit.org/show_bug.cgi?id=188829
2151
2152         Reviewed by Tim Horton.
2153
2154         * Configurations/FeatureDefines.xcconfig:
2155
2156 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2157
2158         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
2159         https://bugs.webkit.org/show_bug.cgi?id=188777
2160
2161         Reviewed by Simon Fraser.
2162
2163         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
2164         being "true" before the code change.
2165
2166         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
2167
2168         * WebView/WebPDFView.mm:
2169         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2170
2171 2018-08-21  Daniel Bates  <dabates@apple.com>
2172
2173         Replace TextCheckingTypeMask with OptionSet
2174         https://bugs.webkit.org/show_bug.cgi?id=188678
2175
2176         Reviewed by Antti Koivisto.
2177
2178         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
2179         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
2180         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
2181         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
2182
2183         * WebCoreSupport/WebEditorClient.h:
2184         * WebCoreSupport/WebEditorClient.mm:
2185         (WebEditorClient::checkTextOfParagraph):
2186         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
2187         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
2188         left as this is more readable and unncessary now that modern compilers like Clang have
2189         diagnostics to catch accidental assignments when equality was intended.
2190         (WebEditorClient::didCheckSucceed):
2191         * WebView/WebView.mm:
2192         (coreTextCheckingType):
2193         (textCheckingResultFromNSTextCheckingResult):
2194
2195 2018-08-21  Daniel Bates  <dabates@apple.com>
2196
2197         [iOS][WK1] Support toggling continuous spell checking from tests
2198         https://bugs.webkit.org/show_bug.cgi?id=188763
2199
2200         Reviewed by Simon Fraser.
2201
2202         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
2203         spell checking from tests in iOS WebKit Legacy.
2204
2205         * WebCoreSupport/WebEditorClient.h:
2206         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
2207         * WebCoreSupport/WebEditorClient.mm:
2208         * WebView/WebView.h:
2209         * WebView/WebView.mm:
2210         (-[WebView toggleContinuousSpellChecking:]):
2211         (-[WebView toggleSmartInsertDelete:]):
2212
2213 2018-08-17  Alex Christensen  <achristensen@webkit.org>
2214
2215         Add some plumbing for safe browsing
2216         https://bugs.webkit.org/show_bug.cgi?id=188709
2217
2218         Reviewed by Tim Horton.
2219
2220         * WebCoreSupport/WebFrameLoaderClient.h:
2221         * WebCoreSupport/WebFrameLoaderClient.mm:
2222         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2223
2224 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
2225
2226         Replace canBubble and cancelable booleans in Event by enum classes
2227         https://bugs.webkit.org/show_bug.cgi?id=188692
2228
2229         Reviewed by Alex Christensen.
2230
2231         * WebView/WebPDFView.mm:
2232         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2233         * WebView/WebView.mm:
2234         (-[WebView _dispatchUnloadEvent]):
2235
2236 2018-08-16  Jer Noble  <jer.noble@apple.com>
2237
2238         Add Experimental Feature support for SourceBuffer.changeType()
2239         https://bugs.webkit.org/show_bug.cgi?id=188626
2240         <rdar://problem/43356021>
2241
2242         Reviewed by Eric Carlson.
2243
2244         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
2245
2246         * WebView/WebPreferenceKeysPrivate.h:
2247         * WebView/WebPreferences.mm:
2248         (+[WebPreferences initialize]):
2249         (-[WebPreferences sourceBufferChangeTypeEnabled]):
2250         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
2251         * WebView/WebPreferencesPrivate.h:
2252         * WebView/WebView.mm:
2253         (-[WebView _preferencesChanged:]):
2254
2255 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
2256
2257         Support drag-and-drop for input[type=color]
2258         https://bugs.webkit.org/show_bug.cgi?id=188464
2259
2260         Reviewed by Wenson Hsieh.
2261
2262         * WebCoreSupport/WebPlatformStrategies.h:
2263         * WebCoreSupport/WebPlatformStrategies.mm:
2264         (WebPlatformStrategies::setColor):
2265
2266 2018-08-15  Tim Horton  <timothy_horton@apple.com>
2267
2268         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
2269         https://bugs.webkit.org/show_bug.cgi?id=188569
2270         <rdar://problem/34201095>
2271
2272         Reviewed by Megan Gardner.
2273
2274         * WebView/WebImmediateActionController.mm:
2275         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2276         Speculative fix; the crashes indicate font is null, but we just checked it,
2277         so it must be getting made null by convertFont:toSize:. Check again!
2278
2279 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2280
2281         Use a 1-byte enum class for TextDirection
2282         https://bugs.webkit.org/show_bug.cgi?id=188350
2283
2284         Reviewed by Simon Fraser.
2285
2286         * WebCoreSupport/PopupMenuMac.mm:
2287         (PopupMenuMac::populate):
2288         (PopupMenuMac::show):
2289         * WebCoreSupport/WebFrameLoaderClient.mm:
2290         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2291         * WebView/WebFrame.mm:
2292         (-[WebFrame _dispatchDidReceiveTitle:]):
2293
2294 2018-08-09  Ali Juma  <ajuma@chromium.org>
2295
2296         Import WPTs for IntersectionObserver
2297         https://bugs.webkit.org/show_bug.cgi?id=188416
2298
2299         Reviewed by Simon Fraser.
2300
2301         * WebView/WebPreferencesPrivate.h:
2302
2303 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
2304
2305         Follow-up build fix for r234685
2306         https://bugs.webkit.org/show_bug.cgi?id=188245
2307
2308         Unreviewed build fix.
2309
2310         * WebCoreSupport/WebSecurityOriginPrivate.h:
2311
2312 2018-08-05  Darin Adler  <darin@apple.com>
2313
2314         [Cocoa] More tweaks and refactoring to prepare for ARC
2315         https://bugs.webkit.org/show_bug.cgi?id=188245
2316
2317         Reviewed by Dan Bernstein.
2318
2319         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
2320
2321         * Carbon/CarbonWindowFrame.m:
2322         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
2323
2324         * DOM/DOM.mm:
2325         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
2326         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
2327         garbage collection so this method isn't useful.
2328
2329         * DOM/DOMXPath.mm:
2330         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
2331         Objective-C garbage collection so this method isn't useful.
2332
2333         * History/WebHistory.mm:
2334         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
2335
2336         * Misc/WebElementDictionary.mm:
2337         (addLookupKey): Use a bridging cast.
2338         (cacheValueForKey): Ditto.
2339         (-[WebElementDictionary _fillCache]): Ditto.
2340         (-[WebElementDictionary objectForKey:]): Ditto.
2341
2342         * Misc/WebKitNSStringExtras.mm:
2343         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
2344         (-[NSString _web_widthWithFont:]): Ditto.
2345         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
2346
2347         * Misc/WebLocalizableStrings.mm:
2348         (WebLocalizedString): Use a bridging cast.
2349
2350         * Misc/WebNSDataExtras.mm:
2351         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
2352         and use CFBridgingRelease instead of calling autorelease directly.
2353         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
2354         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
2355         on the amount of explicit release and autorelease.
2356
2357         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
2358         * Misc/WebNSDictionaryExtras.m:
2359         (-[NSDictionary _webkit_intForKey:]): Deleted.
2360         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
2361         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
2362         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
2363         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
2364         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
2365         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
2366
2367         * Misc/WebStringTruncator.mm:
2368         (fontFromNSFont): Use a bridging cast.
2369
2370         * Plugins/Hosted/NetscapePluginHostManager.mm:
2371         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
2372
2373         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2374         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
2375         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
2376         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
2377         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
2378         * Plugins/Hosted/ProxyInstance.mm:
2379         (WebKit::ProxyInstance::getPropertyNames): Ditto.
2380         * Plugins/WebBasePluginPackage.mm:
2381         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
2382         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2383         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
2384         * Plugins/WebNetscapePluginPackage.mm:
2385         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
2386
2387         * Plugins/WebNetscapePluginView.mm:
2388         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
2389         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
2390         (-[WebNetscapePluginView status:]): Use a bridging cast.
2391         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
2392
2393         * Plugins/WebPluginController.mm:
2394         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
2395
2396         * Plugins/WebPluginDatabase.mm:
2397         (checkCandidate): Use explicit __strong for out argument types.
2398
2399         * Plugins/npapi.mm:
2400         (pluginViewForInstance): Use a bridging cast.
2401
2402         * Storage/WebDatabaseManager.mm:
2403         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
2404         explicit NSNumber and NSDictionary calls.
2405
2406         * WebCoreSupport/WebContextMenuClient.mm:
2407         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
2408
2409         * WebCoreSupport/WebEditorClient.mm:
2410         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
2411         (WebEditorClient::handleInputMethodKeydown): Ditto.
2412
2413         * WebCoreSupport/WebFrameNetworkingContext.mm:
2414         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
2415
2416         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
2417         as a struct rather than an Objective-C class, since that's how it's defined.
2418
2419         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
2420
2421         * WebView/WebFullScreenController.mm:
2422         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
2423         * WebView/WebHTMLView.mm:
2424         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2425         Ditto.
2426         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2427
2428         * WebView/WebImmediateActionController.mm:
2429         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
2430         go down to the document and then back to the frame.
2431         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
2432         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
2433         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
2434
2435         * WebView/WebJSPDFDoc.mm:
2436         (jsPDFDocInitialize): Removed some unneeded type casting.
2437         (jsPDFDocFinalize): Ditto.
2438         (jsPDFDocPrint): Use a bridging cast.
2439
2440         * WebView/WebPDFView.mm:
2441         (_applicationInfoForMIMEType): Use bridging casts.
2442
2443         * WebView/WebPreferences.mm:
2444         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
2445         instead of methods from WebNSDictionaryExtras.
2446         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
2447         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
2448         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
2449         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
2450         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
2451
2452         * WebView/WebView.mm:
2453         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
2454         (-[WebView _addToAllWebViewsSet]): Ditto.
2455         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
2456         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
2457         so it can be called from WebViewData methods.
2458
2459         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
2460         method, _windowVisibilityChanged:.
2461
2462         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
2463         called from WebViewData methods.
2464
2465 2018-08-06  Alex Christensen  <achristensen@webkit.org>
2466
2467         Use enum classes and OptionSets for PaintPhase and PaintBehavior
2468         https://bugs.webkit.org/show_bug.cgi?id=188323
2469
2470         Reviewed by Simon Fraser.
2471
2472         * WebCoreSupport/WebContextMenuClient.mm:
2473         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2474         * WebView/WebFrame.mm:
2475         (-[WebFrame _paintBehaviorForDestinationContext:]):
2476         (-[WebFrame _drawRect:contentsOnly:]):
2477         * WebView/WebHTMLView.mm:
2478         (imageFromRect):
2479         (selectionImage):
2480
2481 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2482
2483         Add support for microtasks in workers
2484         https://bugs.webkit.org/show_bug.cgi?id=188246
2485
2486         Reviewed by Darin Adler.
2487
2488         Rename JSMainThreadExecState.h to JSExecState.h.
2489
2490         * DOM/DOMAttr.mm:
2491         * DOM/DOMBlob.mm:
2492         * DOM/DOMCDATASection.mm:
2493         * DOM/DOMCSSCharsetRule.mm:
2494         * DOM/DOMCSSFontFaceRule.mm:
2495         * DOM/DOMCSSImportRule.mm:
2496         * DOM/DOMCSSMediaRule.mm:
2497         * DOM/DOMCSSPageRule.mm:
2498         * DOM/DOMCSSPrimitiveValue.mm:
2499         * DOM/DOMCSSRule.mm:
2500         * DOM/DOMCSSRuleList.mm:
2501         * DOM/DOMCSSStyleDeclaration.mm:
2502         * DOM/DOMCSSStyleRule.mm:
2503         * DOM/DOMCSSStyleSheet.mm:
2504         * DOM/DOMCSSUnknownRule.mm:
2505         * DOM/DOMCSSValue.mm:
2506         * DOM/DOMCSSValueList.mm:
2507         * DOM/DOMCharacterData.mm:
2508         * DOM/DOMComment.mm:
2509         * DOM/DOMCounter.mm:
2510         * DOM/DOMDocument.mm:
2511         * DOM/DOMDocumentFragment.mm:
2512         * DOM/DOMDocumentType.mm:
2513         * DOM/DOMElement.mm:
2514         * DOM/DOMEvent.mm:
2515         * DOM/DOMFile.mm:
2516         * DOM/DOMFileList.mm:
2517         * DOM/DOMHTML.mm:
2518         * DOM/DOMHTMLAnchorElement.mm:
2519         * DOM/DOMHTMLAppletElement.mm:
2520         * DOM/DOMHTMLAreaElement.mm:
2521         * DOM/DOMHTMLBRElement.mm:
2522         * DOM/DOMHTMLBaseElement.mm:
2523         * DOM/DOMHTMLBaseFontElement.mm:
2524         * DOM/DOMHTMLBodyElement.mm:
2525         * DOM/DOMHTMLButtonElement.mm:
2526         * DOM/DOMHTMLCanvasElement.mm:
2527         * DOM/DOMHTMLCollection.mm:
2528         * DOM/DOMHTMLDListElement.mm:
2529         * DOM/DOMHTMLDirectoryElement.mm:
2530         * DOM/DOMHTMLDivElement.mm:
2531         * DOM/DOMHTMLDocument.mm:
2532         * DOM/DOMHTMLElement.mm:
2533         * DOM/DOMHTMLEmbedElement.mm:
2534         * DOM/DOMHTMLFieldSetElement.mm:
2535         * DOM/DOMHTMLFontElement.mm:
2536         * DOM/DOMHTMLFormElement.mm:
2537         * DOM/DOMHTMLFrameElement.mm:
2538         * DOM/DOMHTMLFrameSetElement.mm:
2539         * DOM/DOMHTMLHRElement.mm:
2540         * DOM/DOMHTMLHeadElement.mm:
2541         * DOM/DOMHTMLHeadingElement.mm:
2542         * DOM/DOMHTMLHtmlElement.mm:
2543         * DOM/DOMHTMLIFrameElement.mm:
2544         * DOM/DOMHTMLImageElement.mm:
2545         * DOM/DOMHTMLInputElement.mm:
2546         * DOM/DOMHTMLLIElement.mm:
2547         * DOM/DOMHTMLLabelElement.mm:
2548         * DOM/DOMHTMLLegendElement.mm:
2549         * DOM/DOMHTMLLinkElement.mm:
2550         * DOM/DOMHTMLMapElement.mm:
2551         * DOM/DOMHTMLMarqueeElement.mm:
2552         * DOM/DOMHTMLMediaElement.mm:
2553         * DOM/DOMHTMLMenuElement.mm:
2554         * DOM/DOMHTMLMetaElement.mm:
2555         * DOM/DOMHTMLModElement.mm:
2556         * DOM/DOMHTMLOListElement.mm:
2557         * DOM/DOMHTMLObjectElement.mm:
2558         * DOM/DOMHTMLOptGroupElement.mm:
2559         * DOM/DOMHTMLOptionElement.mm:
2560         * DOM/DOMHTMLOptionsCollection.mm:
2561         * DOM/DOMHTMLParagraphElement.mm:
2562         * DOM/DOMHTMLParamElement.mm:
2563         * DOM/DOMHTMLPreElement.mm:
2564         * DOM/DOMHTMLQuoteElement.mm:
2565         * DOM/DOMHTMLScriptElement.mm:
2566         * DOM/DOMHTMLSelectElement.mm:
2567         * DOM/DOMHTMLStyleElement.mm:
2568         * DOM/DOMHTMLTableCaptionElement.mm:
2569         * DOM/DOMHTMLTableCellElement.mm:
2570         * DOM/DOMHTMLTableColElement.mm:
2571         * DOM/DOMHTMLTableElement.mm:
2572         * DOM/DOMHTMLTableRowElement.mm:
2573         * DOM/DOMHTMLTableSectionElement.mm:
2574         * DOM/DOMHTMLTextAreaElement.mm:
2575         * DOM/DOMHTMLTitleElement.mm:
2576         * DOM/DOMHTMLUListElement.mm:
2577         * DOM/DOMHTMLVideoElement.mm:
2578         * DOM/DOMImplementation.mm:
2579         * DOM/DOMKeyboardEvent.mm:
2580         * DOM/DOMMediaError.mm:
2581         * DOM/DOMMediaList.mm:
2582         * DOM/DOMMouseEvent.mm:
2583         * DOM/DOMMutationEvent.mm:
2584         * DOM/DOMNamedNodeMap.mm:
2585         * DOM/DOMNode.mm:
2586         * DOM/DOMNodeIterator.mm:
2587         * DOM/DOMNodeList.mm:
2588         * DOM/DOMOverflowEvent.mm:
2589         * DOM/DOMProcessingInstruction.mm:
2590         * DOM/DOMProgressEvent.mm:
2591         * DOM/DOMRGBColor.mm:
2592         * DOM/DOMRange.mm:
2593         * DOM/DOMRect.mm:
2594         * DOM/DOMStyleSheet.mm:
2595         * DOM/DOMStyleSheetList.mm:
2596         * DOM/DOMText.mm:
2597         * DOM/DOMTextEvent.mm:
2598         * DOM/DOMTimeRanges.mm:
2599         * DOM/DOMTokenList.mm:
2600         * DOM/DOMTreeWalker.mm:
2601         * DOM/DOMUIEvent.mm:
2602         * DOM/DOMWheelEvent.mm:
2603         * DOM/DOMXPathExpression.mm:
2604         * DOM/DOMXPathResult.mm:
2605         * DOM/ObjCEventListener.mm:
2606
2607 2018-08-03  Alex Christensen  <achristensen@webkit.org>
2608
2609         Fix spelling of "overridden"
2610         https://bugs.webkit.org/show_bug.cgi?id=188315
2611
2612         Reviewed by Darin Adler.
2613
2614         * Misc/WebKitVersionChecks.mm:
2615         (setWebKitLinkTimeVersion):
2616         (WebKitLinkTimeVersion):
2617         * Plugins/WebBaseNetscapePluginView.mm:
2618         (-[WebBaseNetscapePluginView handleMouseMoved:]):
2619         * WebCoreSupport/PopupMenuMac.mm:
2620         (PopupMenuMac::populate):
2621
2622 2018-08-01  Nan Wang  <n_wang@apple.com>
2623
2624         AX: AOM: Add ARIA IDL Attribute Reflection
2625         https://bugs.webkit.org/show_bug.cgi?id=184676
2626         <rdar://problem/39476882>
2627
2628         Reviewed by Chris Fleizach.
2629
2630         * WebView/WebPreferenceKeysPrivate.h:
2631         * WebView/WebPreferences.mm:
2632         (+[WebPreferences initialize]):
2633         (-[WebPreferences ariaReflectionEnabled]):
2634         (-[WebPreferences setAriaReflectionEnabled:]):
2635         * WebView/WebPreferencesPrivate.h:
2636         * WebView/WebView.mm:
2637         (-[WebView _preferencesChanged:]):
2638
2639 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
2640
2641         Shrink GraphicsLayerCA
2642         https://bugs.webkit.org/show_bug.cgi?id=188141
2643
2644         Reviewed by Zalan Bujtas.
2645
2646         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
2647         * moving all the clone-related stuff into the lazily-allocated m_layerClones
2648         * moving all the animation-related stuff into the lazily-allocated m_animations
2649         * making enums be 8-bit
2650         * re-ordering data members
2651
2652         * WebView/WebView.mm:
2653         (-[WebView _setMediaLayer:forPluginView:]):
2654
2655 2018-07-30  Rob Buis  <rbuis@igalia.com>
2656
2657         Merge PlatformCookieJar functions into NetworkStorageSession
2658         https://bugs.webkit.org/show_bug.cgi?id=188137
2659
2660         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
2661
2662         Reviewed by Alex Christensen.
2663
2664         * WebCoreSupport/WebPlatformStrategies.mm:
2665         (WebPlatformStrategies::cookiesForDOM):
2666         (WebPlatformStrategies::setCookiesFromDOM):
2667         (WebPlatformStrategies::cookiesEnabled):
2668         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2669         (WebPlatformStrategies::getRawCookies):
2670         (WebPlatformStrategies::deleteCookie):
2671         * WebView/WebPreferences.mm:
2672         (+[WebPreferences _clearNetworkLoaderSession]):
2673
2674 2018-07-28  Darin Adler  <darin@apple.com>
2675
2676         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
2677         https://bugs.webkit.org/show_bug.cgi?id=188140
2678
2679         Reviewed by Sam Weinig.
2680
2681         * WebView/WebImmediateActionController.mm:
2682         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
2683         new DictionaryLookup function that returns a tuple instead of using an out argument.
2684
2685 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
2686
2687         [INTL] Remove INTL sub-feature compile flags
2688         https://bugs.webkit.org/show_bug.cgi?id=188081
2689
2690         Reviewed by Michael Catanzaro.
2691
2692         * Configurations/FeatureDefines.xcconfig:
2693
2694 2018-07-26  Commit Queue  <commit-queue@webkit.org>
2695
2696         Unreviewed, rolling out r234181 and r234189.
2697         https://bugs.webkit.org/show_bug.cgi?id=188075
2698
2699         These are not needed right now (Requested by thorton on
2700         #webkit).
2701
2702         Reverted changesets:
2703
2704         "Enable Web Content Filtering on watchOS"
2705         https://bugs.webkit.org/show_bug.cgi?id=187979
2706         https://trac.webkit.org/changeset/234181
2707
2708         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
2709         https://bugs.webkit.org/show_bug.cgi?id=187985
2710         https://trac.webkit.org/changeset/234189
2711
2712 2018-07-26  Timothy Hatcher  <timothy@apple.com>
2713
2714         Use the Page's appearance when converting pasteboard attributed strings.
2715         https://bugs.webkit.org/show_bug.cgi?id=188067
2716         rdar://problem/42632246
2717
2718         Reviewed by Wenson Hsieh.
2719
2720         * WebCoreSupport/WebEditorClient.mm:
2721         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
2722
2723 2018-07-25  Chris Dumez  <cdumez@apple.com>
2724
2725         navigator.userAgent may return outdated value after webView.customUserAgent is set
2726         https://bugs.webkit.org/show_bug.cgi?id=188009
2727         <rdar://problem/42566456>
2728
2729         Reviewed by Alex Christensen.
2730
2731         Let the page know when the user agent changes.
2732
2733         * WebView/WebView.mm:
2734         (-[WebView _preferencesChanged:]):
2735         (-[WebView setApplicationNameForUserAgent:]):
2736         (-[WebView _invalidateUserAgentCache]):
2737         (-[WebView setCustomUserAgent:]):
2738         * WebView/WebViewInternal.h:
2739
2740 2018-07-24  Tim Horton  <timothy_horton@apple.com>
2741
2742         Enable Web Content Filtering on watchOS
2743         https://bugs.webkit.org/show_bug.cgi?id=187979
2744         <rdar://problem/42559346>
2745
2746         Reviewed by Wenson Hsieh.
2747
2748         * Configurations/FeatureDefines.xcconfig:
2749
2750 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
2751
2752         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
2753         https://bugs.webkit.org/show_bug.cgi?id=187846
2754
2755         Reviewed by Simon Fraser.
2756
2757         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
2758
2759         * WebView/WebHTMLView.mm:
2760         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
2761         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
2762
2763 2018-07-11  Dean Jackson  <dino@apple.com>
2764
2765         Allow removal of white backgrounds
2766         https://bugs.webkit.org/show_bug.cgi?id=187574
2767         <rdar://problem/41146792>
2768
2769         Reviewed by Simon Fraser.
2770
2771         Add a new WebPreference for punching out white backgrounds.
2772
2773         * WebView/WebPreferenceKeysPrivate.h:
2774         * WebView/WebPreferences.mm:
2775         (+[WebPreferences initialize]):
2776         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
2777         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
2778         * WebView/WebPreferencesPrivate.h:
2779         * WebView/WebView.mm:
2780         (-[WebView _preferencesChanged:]):
2781
2782 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
2783
2784         Ensure WebKit stack is ad-hoc signed
2785         https://bugs.webkit.org/show_bug.cgi?id=187667
2786
2787         Reviewed by Alexey Proskuryakov.
2788
2789         * Configurations/Base.xcconfig:
2790
2791 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
2792
2793         REGRESSION (231276): Attempting to copy an image fails
2794         https://bugs.webkit.org/show_bug.cgi?id=187212
2795         <rdar://problem/41540074>
2796
2797         Reviewed by Ryosuke Niwa.
2798
2799         Renamed methods to make it clear that one URL and one title are being passed in.
2800
2801         * WebCoreSupport/WebPlatformStrategies.h:
2802         * WebCoreSupport/WebPlatformStrategies.mm:
2803         (WebPlatformStrategies::setURL):
2804
2805 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2806
2807         Disable cross-origin-window-policy by default
2808         https://bugs.webkit.org/show_bug.cgi?id=187509
2809
2810         Reviewed by Chris Dumez.
2811
2812         * WebView/WebPreferences.mm:
2813         (+[WebPreferences initialize]):
2814
2815 2018-07-09  Timothy Hatcher  <timothy@apple.com>
2816
2817         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2818         https://bugs.webkit.org/show_bug.cgi?id=187425
2819         rdar://problem/39948240
2820
2821         Reviewed by Tim Horton.
2822
2823         * WebView/WebView.mm:
2824         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
2825         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
2826         a call in this method to setUseDarkAppearance.
2827         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
2828         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
2829         (-[WebView _updateDefaultAppearance]): Deleted.
2830         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
2831
2832 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
2833
2834         Shrink various loading-related enums to shrink CachedResource
2835         https://bugs.webkit.org/show_bug.cgi?id=187443
2836
2837         Reviewed by Chris Dumez.
2838
2839         * WebCoreSupport/WebFrameLoaderClient.mm:
2840         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2841         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2842         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2843         (WebFrameLoaderClient::dispatchWillSendRequest):
2844         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2845         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2846         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2847         (WebFrameLoaderClient::updateGlobalHistory):
2848         (WebFrameLoaderClient::canHandleRequest const):
2849         * WebView/WebDataSource.mm:
2850         (-[WebDataSource initialRequest]):
2851         (-[WebDataSource request]):
2852
2853 2018-07-09  Commit Queue  <commit-queue@webkit.org>
2854
2855         Unreviewed, rolling out r233612.
2856         https://bugs.webkit.org/show_bug.cgi?id=187475
2857
2858         Revision caused the api test LinkColorWithSystemAppearance to
2859         fail on all systems. (Requested by Truitt on #webkit).
2860
2861         Reverted changeset:
2862
2863         "Semantic colors don't update when accessibility Increase
2864         Contrast mode is enabled."
2865         https://bugs.webkit.org/show_bug.cgi?id=187425
2866         https://trac.webkit.org/changeset/233612
2867
2868 2018-07-06  Timothy Hatcher  <timothy@apple.com>
2869
2870         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2871         https://bugs.webkit.org/show_bug.cgi?id=187425
2872         rdar://problem/39948240
2873
2874         Reviewed by Tim Horton.
2875
2876         * WebView/WebView.mm:
2877         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
2878         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
2879         a call in this method to setUseDarkAppearance.
2880         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
2881         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
2882         (-[WebView _updateDefaultAppearance]): Deleted.
2883         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
2884
2885 2018-07-05  Timothy Hatcher  <timothy@apple.com>
2886
2887         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
2888         https://bugs.webkit.org/show_bug.cgi?id=187369
2889         rdar://problem/41870420
2890
2891         Reviewed by Tim Horton.
2892
2893         * WebView/WebMediaPlaybackTargetPicker.mm:
2894         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
2895         * WebView/WebView.mm:
2896         (-[WebView _commonInitializationWithFrameName:groupName:]):
2897         (-[WebView _effectiveAppearanceIsDark]):
2898         (-[WebView _updateDefaultAppearance]):
2899         (-[WebView _defaultAppearance]): Deleted.
2900
2901 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
2902
2903         Youtube video pages crash after a couple of minutes
2904         https://bugs.webkit.org/show_bug.cgi?id=187316
2905
2906         Reviewed by Antti Koivisto.
2907
2908         * WebView/WebView.mm:
2909         (-[WebView _preferencesChanged:]):
2910
2911 2018-07-04  Tim Horton  <timothy_horton@apple.com>
2912
2913         Introduce PLATFORM(IOSMAC)
2914         https://bugs.webkit.org/show_bug.cgi?id=187315
2915
2916         Reviewed by Dan Bernstein.
2917
2918         * Configurations/Base.xcconfig:
2919         * Configurations/FeatureDefines.xcconfig:
2920
2921 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2922
2923         [iOS] DataTransfer.getData always returns the empty string when dropping text
2924         https://bugs.webkit.org/show_bug.cgi?id=187130
2925         <rdar://problem/41014117>
2926
2927         Reviewed by Ryosuke Niwa.
2928
2929         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
2930
2931         * WebCoreSupport/WebPlatformStrategies.h:
2932         * WebCoreSupport/WebPlatformStrategies.mm:
2933         (WebPlatformStrategies::allPasteboardItemInfo):
2934
2935 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
2936
2937         [Mac] AirPlay picker uses incorrect theme in Dark mode
2938         https://bugs.webkit.org/show_bug.cgi?id=187054
2939         <rdar://problem/41291093>
2940
2941         Reviewed by Timothy Hatcher.
2942
2943         * WebView/WebMediaPlaybackTargetPicker.mm:
2944         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
2945
2946 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2947
2948         [WTF] Add user-defined literal for ASCIILiteral
2949         https://bugs.webkit.org/show_bug.cgi?id=186839
2950
2951         Reviewed by Darin Adler.
2952
2953         * DOM/ExceptionHandlers.mm:
2954         (raiseDOMErrorException):
2955         * Plugins/Hosted/ProxyInstance.mm:
2956         (WebKit::ProxyInstance::invokeMethod):
2957         * Storage/WebDatabaseProvider.mm:
2958         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
2959
2960 2018-06-22  Timothy Hatcher  <timothy@apple.com>
2961
2962         Recalc styles every time defaultAppearance changes.
2963         https://bugs.webkit.org/show_bug.cgi?id=186866
2964         rdar://problem/41309805
2965
2966         Reviewed by Tim Horton.
2967
2968         * WebView/WebView.mm:
2969         (-[WebView _updateDefaultAppearance]):
2970         (-[WebView _setUseSystemAppearance:]):
2971         (-[WebView _useSystemAppearance]):
2972
2973 2018-06-20  Darin Adler  <darin@apple.com>
2974
2975         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
2976         https://bugs.webkit.org/show_bug.cgi?id=186875
2977
2978         Reviewed by Anders Carlsson.
2979
2980         * WebView/WebHTMLView.mm:
2981         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
2982         to write te file to.
2983         * WebView/WebPreferences.mm:
2984         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
2985         * WebView/WebView.mm:
2986         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
2987
2988 2018-06-12  Darin Adler  <darin@apple.com>
2989
2990         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
2991         https://bugs.webkit.org/show_bug.cgi?id=186526
2992
2993         Reviewed by Anders Carlsson.
2994
2995         * Plugins/Hosted/NetscapePluginHostManager.mm:
2996         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
2997
2998         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2999         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
3000         assignment rather than adoptNS/leakRef.
3001         * Plugins/WebNetscapePluginView.mm:
3002         (-[WebNetscapePluginView createPlugin]): Ditto.
3003
3004         * WebCoreSupport/WebContextMenuClient.mm:
3005         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
3006         RetainPtr::autorelease; no need to autorelease just to pass something as a function
3007         argument, so use RetainPtr::get instead.
3008
3009         * WebView/WebHTMLView.mm:
3010         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
3011         No need to autorelease the result when the return type is RetainPtr.
3012
3013         * WebView/WebPDFRepresentation.mm:
3014         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
3015
3016 2018-06-13  Youenn Fablet  <youenn@apple.com>
3017
3018         Supported plugin check should be based on plugin identifier
3019         https://bugs.webkit.org/show_bug.cgi?id=186578
3020         <rdar://problem/40523828>
3021
3022         Reviewed by Darin Adler.
3023
3024         * WebCoreSupport/WebPluginInfoProvider.h:
3025         * WebCoreSupport/WebPluginInfoProvider.mm:
3026         (WebPluginInfoProvider::pluginInfo):
3027         (WebPluginInfoProvider::webVisiblePluginInfo):
3028
3029 2018-06-13  Chris Dumez  <cdumez@apple.com>
3030
3031         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
3032         https://bugs.webkit.org/show_bug.cgi?id=186545
3033
3034         Reviewed by Brady Eidson.
3035
3036         Update client delegate now that parameter type has changed.
3037
3038         * WebCoreSupport/WebFrameLoaderClient.h:
3039         * WebCoreSupport/WebFrameLoaderClient.mm:
3040         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3041
3042 2018-06-11  Tim Horton  <timothy_horton@apple.com>
3043
3044         Link drag image is inconsistently unreadable in dark mode
3045         https://bugs.webkit.org/show_bug.cgi?id=186472
3046
3047         Reviewed by Timothy Hatcher.
3048
3049         * WebView/WebView.mm:
3050         (-[WebView _defaultAppearance]):
3051         Make defaultAppearance accurate even if useSystemAppearance is false.
3052         Some parts of WebKit (like the link drag image, but also context menus)
3053         want to be able to follow the system appearance regardless of whether
3054         the view or content has opted in.
3055
3056 2018-06-11  Chris Dumez  <cdumez@apple.com>
3057
3058         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
3059         https://bugs.webkit.org/show_bug.cgi?id=186441
3060
3061         Reviewed by Brady Eidson.
3062
3063         Rename existing flag to something a bit more generic, now that it is used for
3064         more things than bypassing the navigation policy check.
3065
3066         * WebView/WebView.mm:
3067         (-[WebView _loadBackForwardListFromOtherView:]):
3068         (-[WebView goToBackForwardItem:]):
3069
3070 2018-06-09  Dan Bernstein  <mitz@apple.com>
3071
3072         [Xcode] Clean up and modernize some build setting definitions
3073         https://bugs.webkit.org/show_bug.cgi?id=186463
3074
3075         Reviewed by Sam Weinig.
3076
3077         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
3078         * Configurations/DebugRelease.xcconfig: Ditto.
3079         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
3080           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
3081         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
3082         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
3083           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
3084         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
3085
3086 2018-06-08  Darin Adler  <darin@apple.com>
3087
3088         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
3089         https://bugs.webkit.org/show_bug.cgi?id=186436
3090
3091         Reviewed by Anders Carlsson.
3092
3093         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
3094         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
3095         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
3096         (PoolCleaner): Ditto.
3097
3098         * History/WebHistory.mm:
3099         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3100         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
3101         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
3102         now hardly used if at all.
3103         * WebView/WebView.mm:
3104         (-[WebView rectsForTextMatches]): Ditto.
3105
3106 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3107
3108         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
3109         https://bugs.webkit.org/show_bug.cgi?id=186442
3110         <rdar://problem/40879364>
3111
3112         Reviewed by Tim Horton.
3113
3114         * Configurations/FeatureDefines.xcconfig:
3115
3116 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
3117
3118         [Datalist] Allow TextFieldInputType to show and hide suggestions
3119         https://bugs.webkit.org/show_bug.cgi?id=186151
3120
3121         Reviewed by Tim Horton.
3122
3123         * WebCoreSupport/WebChromeClient.h:
3124         * WebCoreSupport/WebChromeClient.mm:
3125         (WebChromeClient::createDataListSuggestionPicker):
3126
3127 2018-06-07  Chris Dumez  <cdumez@apple.com>
3128
3129         Add base class to get WeakPtrFactory member and avoid some boilerplate code
3130         https://bugs.webkit.org/show_bug.cgi?id=186407
3131
3132         Reviewed by Brent Fulgham.
3133
3134         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
3135         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
3136         This also gets rid of old-style createWeakPtr() methods in favor of the newer
3137         makeWeakPtr().
3138
3139         * WebCoreSupport/WebEditorClient.h:
3140         * WebCoreSupport/WebEditorClient.mm:
3141         (WebEditorClient::requestCandidatesForSelection):
3142
3143 2018-06-05  Chris Dumez  <cdumez@apple.com>
3144
3145         Regression(r232082): Websites get loaded inside of Messages App chat transcript
3146         https://bugs.webkit.org/show_bug.cgi?id=186331
3147         <rdar://problem/40735446>
3148
3149         Reviewed by Darin Adler.
3150
3151         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
3152         but does not call use / ignore on the listener, then we would do "use" by default.
3153         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
3154         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
3155         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
3156         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
3157         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
3158         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
3159         and Box.app is still working properly.
3160
3161         * WebCoreSupport/WebFrameLoaderClient.h:
3162         * WebCoreSupport/WebFrameLoaderClient.mm:
3163         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3164         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3165         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3166         (WebFrameLoaderClient::dispatchWillSubmitForm):
3167         (WebFrameLoaderClient::setUpPolicyListener):
3168         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
3169         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
3170         (-[WebFramePolicyListener dealloc]):
3171         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
3172         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
3173
3174 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3175
3176         Adjust compile and runtime flags to match shippable state of features
3177         https://bugs.webkit.org/show_bug.cgi?id=186319
3178         <rdar://problem/40352045>
3179
3180         Reviewed by Maciej Stachowiak, Jon Lee, and others.
3181
3182         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
3183         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
3184         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
3185         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
3186         Cocoa builds.
3187
3188 2018-06-05  Timothy Hatcher  <timothy@apple.com>
3189
3190         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
3191
3192         https://bugs.webkit.org/show_bug.cgi?id=186323
3193         rdar://problem/38382252
3194
3195         Reviewed by Tim Horton.
3196
3197         * WebView/WebView.mm:
3198         (-[WebView _defaultAppearance]):
3199
3200 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3201
3202         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
3203         https://bugs.webkit.org/show_bug.cgi?id=186286
3204         <rdar://problem/40782992>
3205
3206         Reviewed by Dan Bernstein.
3207
3208         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
3209         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
3210         change this flag when preparing for a production release.
3211
3212         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
3213         whether experimental features should be enabled, and use it to properly define the
3214         feature flag.
3215
3216 2018-06-03  Darin Adler  <darin@apple.com>
3217
3218         Simplify and remove some unused video element code (helpful for ARC-compatibility)
3219         https://bugs.webkit.org/show_bug.cgi?id=186258
3220
3221         Reviewed by Daniel Bates.
3222
3223         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
3224         forward declarations. Removed methods that don't need to be public.
3225
3226         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
3227         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
3228         unnamed category in here and also replaced the HUDWindowControllerDelegate
3229         with the unnamed category. Removed unused NSWindow category defining the
3230         isOnActiveSpace, which is not called anywhere in this file at this time.
3231         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
3232         into setVideoElement.
3233         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
3234         and removed unneeded typecast.
3235         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
3236         using statement at the top of the file.
3237         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
3238         the many side effects and special considerations that this method that sounds
3239         like a setter has. Updated code to use the new
3240         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
3241         HTMLVideoElement::platformMedia function. Also straightened out the logic a
3242         bit and added some FIXME comments about small problems noticed but not fixed.
3243         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
3244         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
3245         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
3246         typecast. Removed call to updatePowerAssertions method.
3247         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
3248         updatePowerAssertions method.
3249         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
3250         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
3251         else, so this was dead code that did nothing.
3252         (-[WebVideoFullscreenController rateChanged:]): Removed call to
3253         updatePowerAssertions method.
3254
3255 2018-06-04  Chris Dumez  <cdumez@apple.com>
3256
3257         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
3258         https://bugs.webkit.org/show_bug.cgi?id=186287
3259         <rdar://problem/40783352>
3260
3261         Reviewed by Youenn Fablet.
3262
3263         * WebView/WebPreferenceKeysPrivate.h:
3264         * WebView/WebPreferences.mm:
3265         (+[WebPreferences initialize]):
3266         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
3267         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
3268         * WebView/WebPreferencesPrivate.h:
3269         * WebView/WebView.mm:
3270         (-[WebView _preferencesChanged:]):
3271
3272 2018-06-02  Darin Adler  <darin@apple.com>
3273
3274         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
3275         https://bugs.webkit.org/show_bug.cgi?id=186227
3276
3277         Reviewed by Dan Bernstein.
3278
3279         * Misc/WebKitErrors.m:
3280         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
3281         * Plugins/WebPluginDatabase.mm:
3282         (-[WebPluginDatabase refresh]): Ditto.
3283         * WebCoreSupport/WebChromeClient.mm:
3284         (WebChromeClient::setStatusbarText): Ditto.
3285
3286 2018-06-01  Chris Dumez  <cdumez@apple.com>
3287
3288         REGRESSION (r231456): Colloquy is broken
3289         https://bugs.webkit.org/show_bug.cgi?id=186197
3290         <rdar://problem/40722960>
3291
3292         Reviewed by Timothy Hatcher.
3293
3294         Restore pre-r231456 behavior for Colloquy app so that it works again.
3295
3296         * WebView/WebView.mm:
3297         (-[WebView _needsFrameNameFallbackToIdQuirk]):
3298         (-[WebView _preferencesChanged:]):
3299
3300 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3301
3302         [JSC] Pass VM& parameter as much as possible
3303         https://bugs.webkit.org/show_bug.cgi?id=186085
3304
3305         Reviewed by Saam Barati.
3306
3307         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3308         (WebKit::NetscapePluginInstanceProxy::invoke):
3309
3310 2018-05-30  Daniel Bates  <dabates@apple.com>
3311
3312         NavigationAction does not need to hold initiating DOM Event
3313         https://bugs.webkit.org/show_bug.cgi?id=185958
3314         <rdar://problem/40531539>
3315
3316         Reviewed by Simon Fraser.
3317
3318         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
3319
3320         * WebCoreSupport/WebFrameLoaderClient.mm:
3321         (WebFrameLoaderClient::actionDictionary const):
3322         (findMouseEvent): Deleted.
3323
3324 2018-05-27  Dan Bernstein  <mitz@apple.com>
3325
3326         Reverted the changes made for https://webkit.org/b/186016
3327
3328         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
3329
3330
3331 2018-05-27  David Kilzer  <ddkilzer@apple.com>
3332
3333         [iOS] Fix warnings about leaks found by clang static analyzer
3334         <https://webkit.org/b/186009>
3335         <rdar://problem/40574267>
3336
3337         Reviewed by Daniel Bates.
3338
3339         * WebView/WebHTMLView.mm:
3340         (-[WebHTMLView doCommandBySelector:]): Fix use of an
3341         uninitialized boolean variable (`eventWasHandled`) that only
3342         happened on iOS.
3343
3344 2018-05-27  Dan Bernstein  <mitz@apple.com>
3345
3346         [Cocoa] Avoid importing directly from subumbrella frameworks
3347         https://bugs.webkit.org/show_bug.cgi?id=186016
3348
3349         Reviewed by Sam Weinig.
3350
3351         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
3352         * Carbon/CarbonWindowAdapter.mm: Ditto.
3353         * Carbon/CarbonWindowFrame.m: Ditto.
3354         * Carbon/HIViewAdapter.h: Ditto.
3355         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
3356           OTHER_CPLUSPLUSFLAGS.
3357         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
3358         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
3359         * WebView/WebPDFView.h: Ditto.
3360
3361 2018-05-27  Sam Weinig  <sam@webkit.org>
3362
3363         Modernize RenderStyleConstants.h - Part 3
3364         https://bugs.webkit.org/show_bug.cgi?id=186015
3365
3366         Reviewed by Yusuke Suzuki.
3367
3368         * WebView/WebView.mm:
3369         (-[WebView updateTextTouchBar]):
3370         Update for new enum name.
3371
3372 2018-05-25  Chris Dumez  <cdumez@apple.com>
3373
3374         Minor ApplicationCacheStorage clean up
3375         https://bugs.webkit.org/show_bug.cgi?id=185984
3376
3377         Reviewed by Youenn Fablet.
3378
3379         * WebCoreSupport/WebApplicationCache.mm:
3380         (+[WebApplicationCache originsWithCache]):
3381
3382 2018-05-25  David Kilzer  <ddkilzer@apple.com>
3383
3384         Fix issues with -dealloc methods found by clang static analyzer
3385         <https://webkit.org/b/185887>
3386
3387         Reviewed by Joseph Pecoraro.
3388
3389         * WebView/WebView.mm:
3390         (-[WebUITextIndicatorData dealloc]):
3391         - Move method implementation from (WebUITextIndicatorInternal)
3392           category to the main category since this is public API.  This
3393           fixes the false positive warning about a missing -dealloc
3394           method.
3395
3396 2018-05-24  Sam Weinig  <sam@webkit.org>
3397
3398         Modernize RenderStyleConstants.h - Part 2
3399         https://bugs.webkit.org/show_bug.cgi?id=185901
3400
3401         Reviewed by Simon Fraser.
3402
3403         * WebView/WebHTMLRepresentation.mm:
3404         (searchForLabelsBeforeElement):
3405         * WebView/WebView.mm:
3406         (nsTextAlignmentFromRenderStyle):
3407         Update for new enum names.
3408
3409 2018-05-22  Chris Dumez  <cdumez@apple.com>
3410
3411         Regression(AsyncPolicyDelegates): Box.app login Window is blank
3412         https://bugs.webkit.org/show_bug.cgi?id=185832
3413         <rdar://problem/40307871>
3414
3415         Reviewed by Geoffrey Garen.
3416
3417         We used to have a bug where where we would fail to wait for the policy decision for
3418         the navigation response from the client and the load would keep going, racing with
3419         the client's policy decision. If the client did not respond in time, the behavior
3420         would be the same as "Use" policy action.
3421
3422         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
3423         but the load happened to proceed anyway due to our bug. Now that we've fixed the
3424         WebKit bug, however, the load would hang because the completion handler for the
3425         decidePolicyForNavigationResponse would never get called.
3426
3427         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
3428         instead of retaining it. If the policy listener object gets destroyed because getting
3429         resolved, we now use "Use" policy action in its dealloc function to maintain previous
3430         behavior.
3431
3432         * WebCoreSupport/WebFrameLoaderClient.h:
3433         * WebCoreSupport/WebFrameLoaderClient.mm:
3434         (WebFrameLoaderClient::cancelPolicyCheck):
3435         (WebFrameLoaderClient::setUpPolicyListener):
3436         (-[WebFramePolicyListener dealloc]):
3437
3438 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
3439
3440         Unreviewed, rolling out r232052.
3441
3442         Breaks internal builds.
3443
3444         Reverted changeset:
3445
3446         "Use more C++17"
3447         https://bugs.webkit.org/show_bug.cgi?id=185176
3448         https://trac.webkit.org/changeset/232052
3449
3450 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
3451
3452         Use more C++17
3453         https://bugs.webkit.org/show_bug.cgi?id=185176
3454
3455         Reviewed by JF Bastien.
3456
3457         * Configurations/Base.xcconfig:
3458         * Configurations/WebKitLegacy.xcconfig: