247391ed51a2dd829af5a4d85af79c363260c933
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-24  John Wilander  <wilander@apple.com>
2
3         Add Ad Click Attribution as an internal/experimental feature
4         https://bugs.webkit.org/show_bug.cgi?id=193685
5         <rdar://problem/47450399>
6
7         Reviewed by Brent Fulgham.
8
9         * WebView/WebPreferenceKeysPrivate.h:
10         * WebView/WebPreferences.mm:
11         (+[WebPreferences initialize]):
12         (-[WebPreferences adClickAttributionEnabled]):
13         (-[WebPreferences setAdClickAttributionEnabled:]):
14             Added support for experimental ad click attribution.
15         * WebView/WebPreferencesPrivate.h:
16         * WebView/WebView.mm:
17         (-[WebView _preferencesChanged:]):
18
19 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
20
21         Move FileSystem to WTF
22         https://bugs.webkit.org/show_bug.cgi?id=193602
23
24         Reviewed by Yusuke Suzuki.
25
26         * Misc/WebNSFileManagerExtras.mm:
27         * Storage/WebDatabaseProvider.mm:
28         * WebView/WebView.mm:
29
30 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
31
32         Fix the Apple Internal build. See <rdar://problem/47491383>.
33
34         Rubber-stamped by Tim Horton.
35
36         * WebCoreSupport/WebFrameLoaderClient.mm:
37
38 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
39
40         Clean up USE(WEB_THREAD)
41         https://bugs.webkit.org/show_bug.cgi?id=193698
42
43         Rubber-stamped by Tim Horton.
44
45         * Misc/WebCache.mm:
46         (+[WebCache emptyInMemoryResources]):
47         * WebCoreSupport/WebFrameLoaderClient.mm:
48         (-[WebFramePolicyListener use]):
49         * WebCoreSupport/WebGeolocationClient.mm:
50         (-[WebGeolocationPolicyListener allow]):
51         (-[WebGeolocationPolicyListener deny]):
52         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
53         * WebView/WebFrame.mm:
54         (-[WebFrame deviceOrientationChanged]):
55         * WebView/WebHTMLView.mm:
56         (hardwareKeyboardAvailabilityChangedCallback):
57         * WebView/WebView.mm:
58         (+[WebView _releaseMemoryNow]):
59         (+[WebView willEnterBackgroundWithCompletionHandler:]):
60         (-[WebView updateLayoutIgnorePendingStyleSheets]):
61         (-[WebView _dispatchUnloadEvent]):
62         (-[WebView _close]):
63         (-[WebView _preferencesChangedNotification:]):
64         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
65         (-[WebView goBack]):
66         (-[WebView goForward]):
67         (+[WebView _cacheModelChangedNotification:]):
68         (-[WebView stopLoading:]):
69         (-[WebView stopLoadingAndClear]):
70         (-[WebView reload:]):
71         (WebInstallMemoryPressureHandler):
72
73 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
74
75         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
76         https://bugs.webkit.org/show_bug.cgi?id=193706
77         <rdar://problem/44807048>
78
79         Reviewed by Ryosuke Niwa.
80
81         Use UndoStep::label().
82
83         * WebCoreSupport/WebEditorClient.h:
84         * WebCoreSupport/WebEditorClient.mm:
85         (-[WebUndoStep initWithUndoStep:]):
86         (+[WebUndoStep stepWithUndoStep:]):
87         (WebEditorClient::registerUndoOrRedoStep):
88         (WebEditorClient::registerUndoStep):
89         (WebEditorClient::registerRedoStep):
90
91 2019-01-22  Alex Christensen  <achristensen@webkit.org>
92
93         Move NetworkStorageSession ownership to NetworkProcess
94         https://bugs.webkit.org/show_bug.cgi?id=193580
95
96         Reviewed by Geoff Garen.
97
98         * Misc/WebCache.mm:
99         (+[WebCache clearCachedCredentials]):
100         * Misc/WebDownload.mm:
101         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
102         * Plugins/WebBaseNetscapePluginView.mm:
103         (WebKit::getAuthenticationInfo):
104         * WebCoreSupport/WebFrameNetworkingContext.mm:
105         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
106         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
107         (WebFrameNetworkingContext::storageSession const):
108         * WebView/WebPreferences.mm:
109         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
110         (+[WebPreferences _clearNetworkLoaderSession]):
111         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
112
113 2019-01-22  Daniel Bates  <dabates@apple.com>
114
115         [iOS] Interpret text key commands on keydown and app key commands on keypress
116         https://bugs.webkit.org/show_bug.cgi?id=192897
117         <rdar://problem/46857378>
118
119         Reviewed by Brent Fulgham.
120
121         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
122         is false) and keypress (isCharEvent is true), respectively.
123
124         * WebView/WebHTMLView.mm:
125         (-[WebHTMLView _handleEditingKeyEvent:]):
126
127 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
128
129         [css-logical] Implement flow-relative margin, padding and border shorthands
130         https://bugs.webkit.org/show_bug.cgi?id=188697
131
132         Reviewed by Simon Fraser and Antti Koivisto.
133
134         Add CSSLogicalEnabled runtime flag.
135
136         * WebView/WebPreferenceKeysPrivate.h:
137         * WebView/WebPreferences.mm:
138         (+[WebPreferences initialize]):
139         (-[WebPreferences cssLogicalEnabled]):
140         (-[WebPreferences setCSSLogicalEnabled:]):
141         * WebView/WebPreferencesPrivate.h:
142         * WebView/WebView.mm:
143         (-[WebView _preferencesChanged:]):
144
145 2019-01-15  Darin Adler  <darin@apple.com>
146
147         Use references rather than pointers for register/unregister functions, and more
148         https://bugs.webkit.org/show_bug.cgi?id=175028
149
150         Reviewed by Daniel Bates.
151
152         * WebCoreSupport/WebKitFullScreenListener.mm:
153         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
154         functions in Document; pass a reference.
155         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
156         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
157         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
158         * WebView/WebFullScreenController.mm:
159         (-[WebFullScreenController enterFullScreen:]): Ditto.
160         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
161         (-[WebFullScreenController exitFullScreen]): Ditto.
162         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
163         * WebView/WebFullScreenController.mm:
164         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
165
166 2019-01-12  Dan Bernstein  <mitz@apple.com>
167
168         [Cocoa] Avoid importing directly from subumbrella frameworks
169         https://bugs.webkit.org/show_bug.cgi?id=186016
170         <rdar://problem/40591038>
171
172         Reviewed by Sam Weinig.
173
174         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
175         * Carbon/CarbonWindowAdapter.mm: Ditto.
176         * Carbon/CarbonWindowFrame.m: Ditto.
177         * Carbon/HIViewAdapter.h: Ditto.
178         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
179           OTHER_CFLAGS_COCOA_TOUCH_NO.
180         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
181         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
182         * WebView/WebPDFView.h: Ditto.
183
184 2019-01-20  Antoine Quint  <graouts@apple.com>
185
186         Add a POINTER_EVENTS feature flag
187         https://bugs.webkit.org/show_bug.cgi?id=193577
188         <rdar://problem/47408511>
189
190         Unreviewed. Also enable Pointer Events for iosmac.
191
192         * Configurations/FeatureDefines.xcconfig:
193
194 2019-01-19  Antoine Quint  <graouts@apple.com>
195
196         Add a POINTER_EVENTS feature flag
197         https://bugs.webkit.org/show_bug.cgi?id=193577
198
199         Reviewed by Dean Jackson.
200
201         * Configurations/FeatureDefines.xcconfig:
202
203 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
204
205         Revert r238815, it broke WK1 video fullscreen on Mac
206         https://bugs.webkit.org/show_bug.cgi?id=193586
207         <rdar://problem/47358941>
208
209         Reviewed by Jer Noble.
210
211         * WebView/WebVideoFullscreenController.h: Added.
212         * WebView/WebVideoFullscreenController.mm: Added.
213         (SOFT_LINK_CLASS):
214         (-[WebVideoFullscreenController init]):
215         (-[WebVideoFullscreenController dealloc]):
216         (-[WebVideoFullscreenController fullscreenWindow]):
217         (-[WebVideoFullscreenController windowDidLoad]):
218         (-[WebVideoFullscreenController videoElement]):
219         (-[WebVideoFullscreenController setVideoElement:]):
220         (-[WebVideoFullscreenController clearFadeAnimation]):
221         (-[WebVideoFullscreenController windowDidExitFullscreen]):
222         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
223         (-[WebVideoFullscreenController videoElementRect]):
224         (-[WebVideoFullscreenController applicationDidResignActive:]):
225         (frameExpandedToRatioOfFrame):
226         (createBackgroundFullscreenWindow):
227         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
228         (-[WebVideoFullscreenController enterFullscreen:]):
229         (-[WebVideoFullscreenController exitFullscreen]):
230         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
231         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
232         (-[WebVideoFullscreenController _requestExit]):
233         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
234         (-[WebVideoFullscreenController requestExitFullscreen]):
235         (-[WebVideoFullscreenController fadeHUDIn]):
236         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
237         (-[WebVideoFullscreenController rateChanged:]):
238         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
239         (-[WebVideoFullscreenWindow dealloc]):
240         (-[WebVideoFullscreenWindow resignFirstResponder]):
241         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
242         (-[WebVideoFullscreenWindow mouseDown:]):
243         (-[WebVideoFullscreenWindow cancelOperation:]):
244         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
245         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
246         (-[WebVideoFullscreenWindow animationDidEnd:]):
247         (-[WebVideoFullscreenWindow mouseMoved:]):
248         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
249         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
250         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
251         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
252         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
253         (-[WebVideoFullscreenHUDWindow center]):
254         (-[WebVideoFullscreenHUDWindow keyDown:]):
255         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
256         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
257         (-[WebVideoFullscreenHUDWindowController init]):
258         (-[WebVideoFullscreenHUDWindowController dealloc]):
259         (-[WebVideoFullscreenHUDWindowController setArea:]):
260         (-[WebVideoFullscreenHUDWindowController keyDown:]):
261         (-[WebVideoFullscreenHUDWindowController delegate]):
262         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
263         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
264         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
265         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
266         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
267         (-[WebVideoFullscreenHUDWindowController closeWindow]):
268         (createMediaUIControl):
269         (createControlWithMediaUIControlType):
270         (createTimeTextField):
271         (createMediaUIBackgroundView):
272         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
273         (-[WebVideoFullscreenHUDWindowController updateVolume]):
274         (-[WebVideoFullscreenHUDWindowController updateTime]):
275         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
276         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
277         (-[WebVideoFullscreenHUDWindowController currentTime]):
278         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
279         (-[WebVideoFullscreenHUDWindowController duration]):
280         (-[WebVideoFullscreenHUDWindowController maxVolume]):
281         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
282         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
283         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
284         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
285         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
286         (-[WebVideoFullscreenHUDWindowController volume]):
287         (-[WebVideoFullscreenHUDWindowController setVolume:]):
288         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
289         (-[WebVideoFullscreenHUDWindowController updateRate]):
290         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
291         (-[WebVideoFullscreenHUDWindowController playing]):
292         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
293         (timeToString):
294         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
295         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
296         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
297         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
298         (-[WebVideoFullscreenHUDWindowController rewind:]):
299         (-[WebVideoFullscreenHUDWindowController fastForward:]):
300         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
301         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
302         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
303         * WebView/WebView.mm:
304         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
305         (-[WebView _exitVideoFullscreen]):
306
307 2019-01-18  Tim Horton  <timothy_horton@apple.com>
308
309         Get rid of ADVANCED_SPELL_CHECKING
310         https://bugs.webkit.org/show_bug.cgi?id=193592
311
312         Reviewed by Wenson Hsieh.
313
314         * WebCoreSupport/WebEditorClient.mm:
315         (insertionPointFromCurrentSelection):
316         (WebEditorClient::checkTextOfParagraph):
317         (WebEditorClient::getGuessesForWord):
318         (WebEditorClient::requestCandidatesForSelection):
319         (WebEditorClient::requestCheckingOfString):
320         * WebView/WebHTMLView.mm:
321         (-[WebHTMLView insertText:]):
322
323 2019-01-18  Jer Noble  <jer.noble@apple.com>
324
325         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
326         https://bugs.webkit.org/show_bug.cgi?id=189553
327
328         Reviewed by Tim Horton.
329
330         * Configurations/Base.xcconfig:
331         * Configurations/SDKVariant.xcconfig: Added.
332         * Configurations/WebKitLegacy.xcconfig:
333
334 2019-01-18  David Kilzer  <ddkilzer@apple.com>
335
336         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
337         <https://webkit.org/b/193568>
338         <rdar://problem/47381130>
339
340         Reviewed by Alex Christensen.
341
342         * WebView/WebView.mm:
343         - Remove unused soft-linking macros.
344         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
345         (-[WebUITextIndicatorData initWithImage:scale:]):
346         - Update to use exported PAL functions.
347
348 2019-01-17  Truitt Savell  <tsavell@apple.com>
349
350         Unreviewed, rolling out r240124.
351
352         This commit broke an internal build.
353
354         Reverted changeset:
355
356         "SDK_VARIANT build destinations should be separate from non-
357         SDK_VARIANT builds"
358         https://bugs.webkit.org/show_bug.cgi?id=189553
359         https://trac.webkit.org/changeset/240124
360
361 2019-01-17  Jer Noble  <jer.noble@apple.com>
362
363         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
364         https://bugs.webkit.org/show_bug.cgi?id=189553
365
366         Reviewed by Tim Horton.
367
368         * Configurations/Base.xcconfig:
369         * Configurations/SDKVariant.xcconfig: Added.
370         * Configurations/WebKitLegacy.xcconfig:
371
372 2019-01-17  Alex Christensen  <achristensen@webkit.org>
373
374         Stop using NetworkStorageSession::storageSession in WebCore
375         https://bugs.webkit.org/show_bug.cgi?id=193529
376
377         Reviewed by Tim Horton.
378
379         * Misc/WebCache.mm:
380         (+[WebCache addImageToCache:forURL:forFrame:]):
381         * WebView/WebView.mm:
382         (-[WebView _commonInitializationWithFrameName:groupName:]):
383         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
384
385 2019-01-15  Alex Christensen  <achristensen@webkit.org>
386
387         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
388         https://bugs.webkit.org/show_bug.cgi?id=193368
389
390         Reviewed by Geoff Garen.
391
392         * Misc/WebCache.mm:
393         (+[WebCache clearCachedCredentials]):
394         * Misc/WebDownload.mm:
395         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
396         * Plugins/WebBaseNetscapePluginView.mm:
397         (WebKit::getAuthenticationInfo):
398
399 2019-01-15  Alex Christensen  <achristensen@webkit.org>
400
401         Stop using CookiesStrategy
402         https://bugs.webkit.org/show_bug.cgi?id=161106
403
404         Reviewed by Don Olmstead and Antti Koivisto.
405
406         * Misc/WebCache.mm:
407         (+[WebCache addImageToCache:forURL:forFrame:]):
408         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
409         (WebKit::NetscapePluginInstanceProxy::getCookies):
410         (WebKit::NetscapePluginInstanceProxy::setCookies):
411         * Plugins/WebNetscapePluginView.mm:
412         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
413         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
414         * WebCoreSupport/WebPlatformStrategies.h:
415         * WebCoreSupport/WebPlatformStrategies.mm:
416         (WebPlatformStrategies::createCookiesStrategy): Deleted.
417         (WebPlatformStrategies::cookiesForDOM): Deleted.
418         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
419         (WebPlatformStrategies::cookiesEnabled): Deleted.
420         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
421         (WebPlatformStrategies::getRawCookies): Deleted.
422         (WebPlatformStrategies::deleteCookie): Deleted.
423         * WebView/WebView.mm:
424         (-[WebView _commonInitializationWithFrameName:groupName:]):
425         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
426
427 2019-01-15  Tim Horton  <timothy_horton@apple.com>
428
429         Cannot tab out of WKWebView on macOS
430         https://bugs.webkit.org/show_bug.cgi?id=161448
431         <rdar://problem/28100085>
432
433         Reviewed by Dean Jackson.
434
435         * WebCoreSupport/WebChromeClient.mm:
436         * WebView/WebView.mm:
437         Make use of SPI headers.
438
439 2019-01-14  Commit Queue  <commit-queue@webkit.org>
440
441         Unreviewed, rolling out r239901, r239909, r239910, r239912,
442         r239913, and r239914.
443         https://bugs.webkit.org/show_bug.cgi?id=193407
444
445         These revisions caused an internal failure (Requested by
446         Truitt on #webkit).
447
448         Reverted changesets:
449
450         "[Cocoa] Avoid importing directly from subumbrella frameworks"
451         https://bugs.webkit.org/show_bug.cgi?id=186016
452         https://trac.webkit.org/changeset/239901
453
454         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
455         https://trac.webkit.org/changeset/239909
456
457         "Tried to fix the build."
458         https://trac.webkit.org/changeset/239910
459
460         "Fixed iOS builds after r239910."
461         https://trac.webkit.org/changeset/239912
462
463         "More build fixing."
464         https://trac.webkit.org/changeset/239913
465
466         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
467         https://trac.webkit.org/changeset/239914
468
469 2019-01-14  Mark Lam  <mark.lam@apple.com>
470
471         Re-enable ability to build --cloop builds.
472         https://bugs.webkit.org/show_bug.cgi?id=192955
473         <rdar://problem/46882363>
474
475         Reviewed by Saam barati and Keith Miller.
476
477         * Configurations/FeatureDefines.xcconfig:
478
479 2019-01-13  Dan Bernstein  <mitz@apple.com>
480
481         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
482
483         Patch by Keith Rollin.
484
485         * WebView/PDFViewSPI.h:
486
487 2019-01-12  Timothy Hatcher  <timothy@apple.com>
488
489         Have prefers-color-scheme: light always match on macOS versions before Mojave.
490         https://bugs.webkit.org/show_bug.cgi?id=191655
491         rdar://problem/46074680
492
493         Reviewed by Megan Gardner.
494
495         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
496         * WebView/WebView.mm:
497         (-[WebView _effectiveAppearanceIsDark]):
498
499 2019-01-12  Dan Bernstein  <mitz@apple.com>
500
501         [Cocoa] Avoid importing directly from subumbrella frameworks
502         https://bugs.webkit.org/show_bug.cgi?id=186016
503         <rdar://problem/40591038>
504
505         Reviewed by Sam Weinig.
506
507         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
508         * Carbon/CarbonWindowAdapter.mm: Ditto.
509         * Carbon/CarbonWindowFrame.m: Ditto.
510         * Carbon/HIViewAdapter.h: Ditto.
511         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
512           OTHER_CFLAGS_COCOA_TOUCH_NO.
513         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
514         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
515         * WebView/WebPDFView.h: Ditto.
516
517 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
518
519         Enable visual viewport API by default
520         https://bugs.webkit.org/show_bug.cgi?id=193376
521
522         Reviewed by Simon Fraser.
523
524         * WebView/WebPreferences.mm:
525         (+[WebPreferences initialize]):
526
527 2019-01-11  John Wilander  <wilander@apple.com>
528
529         Compile out Web API Statistics Collection
530         https://bugs.webkit.org/show_bug.cgi?id=193370
531         <rdar://problem/45388584>
532
533         Reviewed by Brent Fulgham.
534
535         * Configurations/FeatureDefines.xcconfig:
536             Defined ENABLE_WEB_API_STATISTICS, off by default.
537
538 2019-01-08  Alex Christensen  <achristensen@webkit.org>
539
540         Stop using NetworkStorageSession in WebProcess
541         https://bugs.webkit.org/show_bug.cgi?id=193236
542
543         Reviewed by Don Olmstead.
544
545         * WebCoreSupport/WebFrameNetworkingContext.h:
546         * WebCoreSupport/WebFrameNetworkingContext.mm:
547         (WebFrameNetworkingContext::storageSession const):
548         * WebCoreSupport/WebPlatformStrategies.h:
549         * WebCoreSupport/WebPlatformStrategies.mm:
550         (WebPlatformStrategies::cookiesForDOM):
551         (WebPlatformStrategies::setCookiesFromDOM):
552         (WebPlatformStrategies::cookiesEnabled):
553         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
554         (WebPlatformStrategies::getRawCookies):
555         (WebPlatformStrategies::deleteCookie):
556         * WebView/WebView.mm:
557         (-[WebView _cachedResponseForURL:]):
558         (-[WebView _clearCredentials]):
559
560 2019-01-08  Alex Christensen  <achristensen@webkit.org>
561
562         Unreviewed, rolling out r239727.
563
564         Broke API tests
565
566         Reverted changeset:
567
568         "Stop using NetworkStorageSession in WebProcess"
569         https://bugs.webkit.org/show_bug.cgi?id=193236
570         https://trac.webkit.org/changeset/239727
571
572 2019-01-08  Alex Christensen  <achristensen@webkit.org>
573
574         Stop using NetworkStorageSession in WebProcess
575         https://bugs.webkit.org/show_bug.cgi?id=193236
576
577         Reviewed by Don Olmstead.
578
579         * WebCoreSupport/WebFrameNetworkingContext.h:
580         * WebCoreSupport/WebFrameNetworkingContext.mm:
581         (WebFrameNetworkingContext::storageSession const):
582         * WebView/WebView.mm:
583         (-[WebView _cachedResponseForURL:]):
584         (-[WebView _clearCredentials]):
585
586 2019-01-07  David Kilzer  <ddkilzer@apple.com>
587
588         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
589         <https://webkit.org/b/193056>
590
591         Reviewed by Alex Christensen.
592
593         * Plugins/Hosted/NetscapePluginHostProxy.h:
594         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
595         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
596         (WebKit::NetscapePluginInstanceProxy::enumerate):
597         (WebKit::NetscapePluginInstanceProxy::marshalValue):
598         (WebKit::NetscapePluginInstanceProxy::marshalValues):
599         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
600         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
601         * Plugins/Hosted/ProxyInstance.mm:
602         (WebKit::ProxyInstance::invoke):
603         * WebCoreSupport/WebGeolocationClient.mm:
604         * WebView/WebDataSource.mm:
605         (-[WebDataSource _receivedData:]):
606         * WebView/WebView.mm:
607         (-[WebView _cachedResponseForURL:]):
608         - Remove '*' from RetainPtr<> type.
609
610 2019-01-04  Alex Christensen  <achristensen@webkit.org>
611
612         Progress towards fixing Mac CMake build
613         https://bugs.webkit.org/show_bug.cgi?id=193105
614
615         Reviewed by Don Olmstead.
616
617         * WebKitPrefix.h:
618
619 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
620
621         Web Inspector: Use save sheet instead of dialog where possible
622         https://bugs.webkit.org/show_bug.cgi?id=193160
623         <rdar://problem/37399759>
624
625         Reviewed by Devin Rousso.
626
627         * WebCoreSupport/WebInspectorClient.mm:
628         (WebInspectorFrontendClient::save):
629
630 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
631
632         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
633         https://bugs.webkit.org/show_bug.cgi?id=193129
634
635         Reviewed by Tim Horton.
636
637         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
638
639         * WebCoreSupport/WebEditorClient.mm:
640         (WebEditorClient::registerUndoOrRedoStep):
641         (undoNameForEditAction): Deleted.
642
643 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
644
645         Add support for using the current text selection as the find string on iOS
646         https://bugs.webkit.org/show_bug.cgi?id=193034
647         <rdar://problem/45138739>
648
649         Reviewed by Tim Horton.
650
651         Add a method stub for WebKitLegacy.
652
653         * WebCoreSupport/WebEditorClient.h:
654
655 2019-01-01  Jeff Miller  <jeffm@apple.com>
656
657         Update user-visible copyright strings to include 2019
658         https://bugs.webkit.org/show_bug.cgi?id=192811
659
660         Reviewed by Mark Lam.
661
662         * Info.plist:
663
664 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
665
666         Use Ref<> as much as possible
667         https://bugs.webkit.org/show_bug.cgi?id=192808
668
669         Reviewed by Alex Christensen.
670
671         * DOM/DOM.mm:
672         (-[DOMNode getPreviewSnapshotImage:andRects:]):
673         * Plugins/Hosted/NetscapePluginHostManager.mm:
674         (WebKit::NetscapePluginHostManager::instantiatePlugin):
675         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
676         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
677         (WebKit::NetscapePluginInstanceProxy::loadRequest):
678         * Plugins/WebNetscapePluginView.mm:
679         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
680         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
681         * WebCoreSupport/WebContextMenuClient.mm:
682         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
683         * WebCoreSupport/WebFrameLoaderClient.mm:
684         (WebFrameLoaderClient::transitionToCommittedForNewPage):
685         * WebView/WebFrame.mm:
686         (-[WebFrame getDictationResultRanges:andMetadatas:]):
687         * WebView/WebHTMLView.mm:
688         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
689         * WebView/WebView.mm:
690         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
691         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
692
693 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
694
695         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
696         https://bugs.webkit.org/show_bug.cgi?id=192821
697
698         Reviewed by Chris Dumez.
699
700         When a window becomes occluded, the window server informs the application.
701         This should be used to suspend any work that is not visible by the user.
702
703         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
704         In some cases, that lead to performance impact (see radar).
705
706         This patch adds an observer for the occlusion notification. I tried to stick
707         with the same names used by WebKit2.
708
709         * WebView/WebView.mm:
710         (-[WebView _isViewVisible]):
711         (-[WebView addWindowObserversForWindow:]):
712         (-[WebView removeWindowObservers]):
713         (-[WebView _windowDidChangeOcclusionState:]):
714
715 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
716
717         [WebAuthN] Add a runtime flag for local authenticator
718         https://bugs.webkit.org/show_bug.cgi?id=192792
719         <rdar://problem/46798738>
720
721         Reviewed by Brent Fulgham.
722
723         * WebView/WebPreferenceKeysPrivate.h:
724         * WebView/WebPreferences.mm:
725         (+[WebPreferences initialize]):
726         (-[WebPreferences webAuthenticationEnabled]): Deleted.
727         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
728         * WebView/WebPreferencesPrivate.h:
729         * WebView/WebView.mm:
730         (-[WebView _preferencesChanged:]):
731
732 2018-12-20  Chris Dumez  <cdumez@apple.com>
733
734         Use Optional::valueOr() instead of Optional::value_or()
735         https://bugs.webkit.org/show_bug.cgi?id=192933
736
737         Reviewed by Geoffrey Garen.
738
739         * WebCoreSupport/WebSecurityOrigin.mm:
740         (-[WebSecurityOrigin port]):
741
742 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
743
744         Unreviewed, rolling out r239417.
745
746         Introduced two API test failures on macOS.
747
748         Reverted changeset:
749
750         "<rdar://problem/46194315> macOS: WebKit1 does not handle
751         occlusion changes"
752         https://bugs.webkit.org/show_bug.cgi?id=192821
753         https://trac.webkit.org/changeset/239417
754
755 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
756
757         WKWebView default UA doesn't freeze the build number
758         https://bugs.webkit.org/show_bug.cgi?id=192809
759         <rdar://problem/44687185>
760
761         Reviewed by Andy Estes.
762
763         Always reports the frozen build number.
764
765         * WebView/WebView.mm:
766         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
767         actual build number through this method call.
768         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
769
770 2018-12-19  Chris Dumez  <cdumez@apple.com>
771
772         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
773         https://bugs.webkit.org/show_bug.cgi?id=192728
774         <rdar://problem/46746779>
775
776         Reviewed by Geoff Garen.
777
778         * DOM/*:
779         * Plugins/*:
780         * WebCoreSupport/*:
781         * WebView/*:
782
783 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
784
785         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
786         https://bugs.webkit.org/show_bug.cgi?id=192821
787
788         Reviewed by Chris Dumez.
789
790         When a window becomes occluded, the window server informs the application.
791         This should be used to suspend any work that is not visible by the user.
792
793         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
794         In some cases, that lead to performance impact (see radar).
795
796         This patch adds an observer for the occlusion notification. I tried to stick
797         with the same names used by WebKit2.
798
799         * WebView/WebView.mm:
800         (-[WebView _isViewVisible]):
801         (-[WebView addWindowObserversForWindow:]):
802         (-[WebView removeWindowObservers]):
803         (-[WebView _windowDidChangeOcclusionState:]):
804
805 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
806
807         Allow clients to set the navigator platform
808         https://bugs.webkit.org/show_bug.cgi?id=192735
809
810         Reviewed by Tim Horton.
811
812         Add stubs to fill out the added functionality in FrameLoaderClient.
813
814         * WebCoreSupport/WebFrameLoaderClient.h:
815         * WebCoreSupport/WebFrameLoaderClient.mm:
816         (WebFrameLoaderClient::navigatorPlatform):
817
818 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
819
820         offsetLeft and offsetParent should adjust across shadow boundaries
821         https://bugs.webkit.org/show_bug.cgi?id=157437
822         <rdar://problem/26154021>
823
824         Reviewed by Simon Fraser.
825
826         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
827
828         * DOM/DOMElement.mm:
829         (-[DOMElement offsetLeft]):
830         (-[DOMElement offsetTop]):
831         (-[DOMElement offsetParent]):
832
833 2018-12-17  Zalan Bujtas  <zalan@apple.com>
834
835         Unreviewed build fix.
836
837         * WebView/WebFrame.mm:
838         (-[WebFrame getDictationResultRanges:andMetadatas:]):
839
840 2018-12-15  Darin Adler  <darin@apple.com>
841
842         Use warning-ignoring macros more consistently and simply
843         https://bugs.webkit.org/show_bug.cgi?id=192743
844
845         Reviewed by Mark Lam.
846
847         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
848         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
849         compilers in Objective-C++ code.
850
851         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
852         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
853         accomodate non-clang compilers here. Also use #pragma once, add a missing
854         "explicit" and fix conditionals.
855
856 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
857
858         Make TextInputController.legacyAttributedString take DOM nodes and offsets
859         https://bugs.webkit.org/show_bug.cgi?id=192653
860
861         Reviewed by Wenson Hsieh.
862
863         * WebView/WebHTMLView.mm:
864         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
865
866 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
867
868         Implement feature flag for CSS Typed OM
869         https://bugs.webkit.org/show_bug.cgi?id=192610
870
871         Reviewed by Ryosuke Niwa.
872
873         * Configurations/FeatureDefines.xcconfig:
874
875 2018-12-11  Tim Horton  <timothy_horton@apple.com>
876
877         WebCore shouldn't have a Objective-C class named NSCursor
878         https://bugs.webkit.org/show_bug.cgi?id=192602
879         <rdar://problem/46615532>
880
881         Reviewed by Wenson Hsieh.
882
883         * WebView/WebFrameView.mm:
884         (-[WebFrameView keyDown:keyDown:]):
885         * WebView/WebHTMLView.mm:
886         (-[WebHTMLView keyDown:]):
887         (-[WebHTMLView performKeyEquivalent:]):
888         Only use NSCursor on macOS.
889
890 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
891
892         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
893         https://bugs.webkit.org/show_bug.cgi?id=192573
894
895         Reviewed by Simon Fraser.
896
897         * Configurations/FeatureDefines.xcconfig:
898
899 2018-12-10  Antti Koivisto  <antti@apple.com>
900
901         Rename "forced style recalc" to "full style rebuild"
902         https://bugs.webkit.org/show_bug.cgi?id=192572
903
904         Reviewed by Zalan Bujtas.
905
906         * WebView/WebHTMLView.mm:
907         (-[WebHTMLView setNeedsToApplyStyles:]):
908
909 2018-12-10  Darin Adler  <darin@apple.com>
910
911         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
912         https://bugs.webkit.org/show_bug.cgi?id=192533
913         rdar://problem/45732710
914
915         Reviewed by Anders Carlsson.
916
917         * Plugins/Hosted/NetscapePluginHostProxy.mm:
918         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
919
920 2018-12-10  Darin Adler  <darin@apple.com>
921
922         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
923         https://bugs.webkit.org/show_bug.cgi?id=192532
924         rdar://problem/45731047
925
926         Reviewed by Chris Dumez.
927
928         * Plugins/Hosted/NetscapePluginHostManager.mm:
929         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
930         * Plugins/Hosted/NetscapePluginHostProxy.mm:
931         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
932
933 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
934
935         Turn WritingDirection into an enum class
936         https://bugs.webkit.org/show_bug.cgi?id=192401
937         Work towards <rdar://problem/42075638>
938
939         Reviewed by Dan Bernstein.
940
941         Change WritingDirection from an enum to an enum class. No change in behavior.
942
943         * WebView/WebHTMLView.mm:
944         (-[WebHTMLView toggleBaseWritingDirection:]):
945         (-[WebHTMLView changeBaseWritingDirection:]):
946         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
947
948 2018-12-03  Alex Christensen  <achristensen@webkit.org>
949
950         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
951         https://bugs.webkit.org/show_bug.cgi?id=192272
952
953         Reviewed by Brady Eidson.
954
955         * WebCoreSupport/WebFrameLoaderClient.h:
956         * WebCoreSupport/WebFrameLoaderClient.mm:
957         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
958
959 2018-12-03  Jer Noble  <jer.noble@apple.com>
960
961         Get rid of old, dead Mac video fullscreen code.
962         https://bugs.webkit.org/show_bug.cgi?id=192315
963
964         Reviewed by Eric Carlson.
965
966         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
967         is no longer supported in the Mac port.
968
969         * WebView/WebVideoFullscreenController.h: Removed.
970         * WebView/WebVideoFullscreenController.mm: Removed.
971         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
972         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
973         * WebView/WebView.mm:
974         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
975         (-[WebView _exitVideoFullscreen]):
976
977 2018-12-03  Daniel Bates  <dabates@apple.com>
978
979         [iOS] Do not handle key events that are key commands
980         https://bugs.webkit.org/show_bug.cgi?id=191608
981         <rdar://problem/46046013>
982
983         Reviewed by Ryosuke Niwa.
984
985         A key down event may be associated with a key command. If it is then we want to execute the
986         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
987         event as a key command to find out.
988
989         * WebView/WebHTMLView.mm:
990         (-[WebHTMLView _handleEditingKeyEvent:]):
991
992 2018-12-02  Zalan Bujtas  <zalan@apple.com>
993
994         Add a runtime feature flag for LayoutFormattingContext.
995         https://bugs.webkit.org/show_bug.cgi?id=192280
996
997         Reviewed by Simon Fraser.
998
999         * Configurations/FeatureDefines.xcconfig:
1000
1001 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1002
1003         Move URL from WebCore to WTF
1004         https://bugs.webkit.org/show_bug.cgi?id=190234
1005
1006         Reviewed by Keith Miller.
1007
1008         * DOM/DOMAttr.mm:
1009         * DOM/DOMBlob.mm:
1010         * DOM/DOMCSSCharsetRule.mm:
1011         * DOM/DOMCSSImportRule.mm:
1012         * DOM/DOMCSSMediaRule.mm:
1013         * DOM/DOMCSSPageRule.mm:
1014         * DOM/DOMCSSPrimitiveValue.mm:
1015         * DOM/DOMCSSRule.mm:
1016         * DOM/DOMCSSStyleDeclaration.mm:
1017         * DOM/DOMCSSStyleRule.mm:
1018         * DOM/DOMCSSStyleSheet.mm:
1019         * DOM/DOMCSSValue.mm:
1020         * DOM/DOMCharacterData.mm:
1021         * DOM/DOMCounter.mm:
1022         * DOM/DOMDocument.mm:
1023         * DOM/DOMDocumentFragment.mm:
1024         * DOM/DOMDocumentType.mm:
1025         * DOM/DOMEvent.mm:
1026         * DOM/DOMFile.mm:
1027         * DOM/DOMHTMLAnchorElement.mm:
1028         * DOM/DOMHTMLAppletElement.mm:
1029         * DOM/DOMHTMLAreaElement.mm:
1030         * DOM/DOMHTMLBRElement.mm:
1031         * DOM/DOMHTMLBaseElement.mm:
1032         * DOM/DOMHTMLBaseFontElement.mm:
1033         * DOM/DOMHTMLBodyElement.mm:
1034         * DOM/DOMHTMLButtonElement.mm:
1035         * DOM/DOMHTMLCanvasElement.mm:
1036         * DOM/DOMHTMLCollection.mm:
1037         * DOM/DOMHTMLDivElement.mm:
1038         * DOM/DOMHTMLDocument.mm:
1039         * DOM/DOMHTMLElement.mm:
1040         * DOM/DOMHTMLEmbedElement.mm:
1041         * DOM/DOMHTMLFieldSetElement.mm:
1042         * DOM/DOMHTMLFontElement.mm:
1043         * DOM/DOMHTMLFormElement.mm:
1044         * DOM/DOMHTMLFrameElement.mm:
1045         * DOM/DOMHTMLFrameSetElement.mm:
1046         * DOM/DOMHTMLHRElement.mm:
1047         * DOM/DOMHTMLHeadElement.mm:
1048         * DOM/DOMHTMLHeadingElement.mm:
1049         * DOM/DOMHTMLHtmlElement.mm:
1050         * DOM/DOMHTMLIFrameElement.mm:
1051         * DOM/DOMHTMLImageElement.mm:
1052         * DOM/DOMHTMLInputElement.mm:
1053         * DOM/DOMHTMLLIElement.mm:
1054         * DOM/DOMHTMLLabelElement.mm:
1055         * DOM/DOMHTMLLegendElement.mm:
1056         * DOM/DOMHTMLLinkElement.mm:
1057         * DOM/DOMHTMLMapElement.mm:
1058         * DOM/DOMHTMLMarqueeElement.mm:
1059         * DOM/DOMHTMLMediaElement.mm:
1060         * DOM/DOMHTMLMetaElement.mm:
1061         * DOM/DOMHTMLModElement.mm:
1062         * DOM/DOMHTMLOListElement.mm:
1063         * DOM/DOMHTMLObjectElement.mm:
1064         * DOM/DOMHTMLOptGroupElement.mm:
1065         * DOM/DOMHTMLOptionElement.mm:
1066         * DOM/DOMHTMLOptionsCollection.mm:
1067         * DOM/DOMHTMLParagraphElement.mm:
1068         * DOM/DOMHTMLParamElement.mm:
1069         * DOM/DOMHTMLQuoteElement.mm:
1070         * DOM/DOMHTMLScriptElement.mm:
1071         * DOM/DOMHTMLSelectElement.mm:
1072         * DOM/DOMHTMLStyleElement.mm:
1073         * DOM/DOMHTMLTableCaptionElement.mm:
1074         * DOM/DOMHTMLTableCellElement.mm:
1075         * DOM/DOMHTMLTableColElement.mm:
1076         * DOM/DOMHTMLTableElement.mm:
1077         * DOM/DOMHTMLTableRowElement.mm:
1078         * DOM/DOMHTMLTableSectionElement.mm:
1079         * DOM/DOMHTMLTitleElement.mm:
1080         * DOM/DOMHTMLUListElement.mm:
1081         * DOM/DOMHTMLVideoElement.mm:
1082         * DOM/DOMKeyboardEvent.mm:
1083         * DOM/DOMMediaList.mm:
1084         * DOM/DOMMouseEvent.mm:
1085         * DOM/DOMMutationEvent.mm:
1086         * DOM/DOMNamedNodeMap.mm:
1087         * DOM/DOMProcessingInstruction.mm:
1088         * DOM/DOMRange.mm:
1089         * DOM/DOMStyleSheet.mm:
1090         * DOM/DOMText.mm:
1091         * DOM/DOMTextEvent.mm:
1092         * DOM/DOMTokenList.mm:
1093         * DOM/DOMUIEvent.mm:
1094         * DOM/DOMXPathResult.mm:
1095         * History/WebHistoryItem.mm:
1096         * Misc/WebNSURLExtras.mm:
1097         (-[NSURL _web_userVisibleString]):
1098         (-[NSURL _web_URLByRemovingUserInfo]):
1099         (-[NSURL _web_dataForURLComponentType:]):
1100         (-[NSURL _web_schemeData]):
1101         (-[NSURL _web_hostData]):
1102         * Misc/WebUserContentURLPattern.mm:
1103         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1104         * Plugins/WebNetscapePluginStream.h:
1105         (WebNetscapePluginStream::setRequestURL):
1106         * WebCoreSupport/WebChromeClient.h:
1107         * WebCoreSupport/WebChromeClient.mm:
1108         (WebChromeClient::signedPublicKeyAndChallengeString const):
1109         * WebCoreSupport/WebContextMenuClient.h:
1110         * WebCoreSupport/WebContextMenuClient.mm:
1111         * WebCoreSupport/WebDragClient.h:
1112         * WebCoreSupport/WebFrameLoaderClient.h:
1113         * WebCoreSupport/WebFrameLoaderClient.mm:
1114         (WebFrameLoaderClient::updateGlobalHistory):
1115         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1116         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1117         (WebPaymentCoordinatorClient::showPaymentUI):
1118         * WebCoreSupport/WebPlatformStrategies.h:
1119         * WebCoreSupport/WebPlatformStrategies.mm:
1120         (WebPlatformStrategies::readURLFromPasteboard):
1121         * WebCoreSupport/WebPluginInfoProvider.h:
1122         * WebCoreSupport/WebPluginInfoProvider.mm:
1123         (WebPluginInfoProvider::webVisiblePluginInfo):
1124         * WebCoreSupport/WebSecurityOrigin.mm:
1125         * WebCoreSupport/WebVisitedLinkStore.h:
1126         * WebView/WebDataSource.mm:
1127         * WebView/WebFrame.mm:
1128         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1129         * WebView/WebImmediateActionController.mm:
1130         (-[WebImmediateActionController _defaultAnimationController]):
1131         * WebView/WebPDFView.mm:
1132         * WebView/WebScriptDebugger.mm:
1133         * WebView/WebViewInternal.h:
1134
1135 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1136
1137         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1138         https://bugs.webkit.org/show_bug.cgi?id=192197
1139
1140         Reviewed by Jiewen Tan.
1141
1142         * Configurations/FeatureDefines.xcconfig:
1143         * WebCoreSupport/WebChromeClient.h:
1144         * WebCoreSupport/WebChromeClient.mm:
1145
1146 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1147
1148         Remove dead code from an earlier attempt at implementing safe browsing
1149         https://bugs.webkit.org/show_bug.cgi?id=192067
1150
1151         Reviewed by Chris Dumez.
1152
1153         * WebCoreSupport/WebFrameLoaderClient.h:
1154         * WebCoreSupport/WebFrameLoaderClient.mm:
1155         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1156
1157 2018-11-27  Mark Lam  <mark.lam@apple.com>
1158
1159         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1160         https://bugs.webkit.org/show_bug.cgi?id=192055
1161         <rdar://problem/46288783>
1162
1163         Reviewed by Saam Barati.
1164
1165         * Configurations/FeatureDefines.xcconfig:
1166
1167 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1168
1169         Make it possible to insert editable images with a gesture
1170         https://bugs.webkit.org/show_bug.cgi?id=191937
1171
1172         Reviewed by Wenson Hsieh.
1173
1174         * WebCoreSupport/WebEditorClient.mm:
1175         (undoNameForEditAction):
1176         Add a undo name.
1177
1178 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1179
1180         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1181         https://bugs.webkit.org/show_bug.cgi?id=191945
1182
1183         Reviewed by Anders Carlsson.
1184
1185         * WebCoreSupport/WebEditorClient.mm:
1186         (undoNameForEditAction):
1187
1188 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1189
1190         Enable drag and drop support for iOSMac
1191         https://bugs.webkit.org/show_bug.cgi?id=191818
1192         <rdar://problem/43907454>
1193
1194         Reviewed by Dean Jackson.
1195
1196         * Configurations/FeatureDefines.xcconfig:
1197
1198 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1199
1200         Address post-review feedback after r238438
1201         https://bugs.webkit.org/show_bug.cgi?id=191913
1202
1203         Reviewed by Ryosuke Niwa.
1204
1205         * WebView/WebFrame.mm:
1206         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1207         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1208         * WebView/WebView.mm:
1209         (-[WebView setSelectedDOMRange:affinity:]):
1210
1211 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1212
1213         Web Inspector: "Reload Web Inspector" button no longer partially works
1214         https://bugs.webkit.org/show_bug.cgi?id=191773
1215         <rdar://problem/46139932>
1216
1217         Reviewed by Devin Rousso.
1218
1219         * WebCoreSupport/WebInspectorClient.h:
1220         * WebCoreSupport/WebInspectorClient.mm:
1221         (WebInspectorFrontendClient::reopen):
1222
1223 2018-11-17  Devin Rousso  <drousso@apple.com>
1224
1225         Web Inspector: Network: add button to show system certificate dialog
1226         https://bugs.webkit.org/show_bug.cgi?id=191458
1227         <rdar://problem/45977019>
1228
1229         Reviewed by Joseph Pecoraro.
1230
1231         * WebCoreSupport/WebInspectorClient.h:
1232         * WebCoreSupport/WebInspectorClient.mm:
1233         (WebInspectorFrontendClient::showCertificate): Added.
1234
1235         * Configurations/WebKitLegacy.xcconfig:
1236
1237 2018-11-15  Truitt Savell  <tsavell@apple.com>
1238
1239         Unreviewed, rolling out r238244.
1240
1241         Caused High Sierra test runs to fail early with 50 crashes and
1242         casued 25 API failures.
1243
1244         Reverted changeset:
1245
1246         "[css-logical] Implement flow-relative margin, padding and
1247         border shorthands"
1248         https://bugs.webkit.org/show_bug.cgi?id=188697
1249         https://trac.webkit.org/changeset/238244
1250
1251 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1252
1253         [css-logical] Implement flow-relative margin, padding and border shorthands
1254         https://bugs.webkit.org/show_bug.cgi?id=188697
1255
1256         Reviewed by Simon Fraser and Antti Koivisto.
1257
1258         Add CSSLogicalEnabled runtime flag.
1259
1260         * WebView/WebPreferenceKeysPrivate.h:
1261         * WebView/WebPreferences.mm:
1262         (+[WebPreferences initialize]):
1263         (-[WebPreferences cssLogicalEnabled]):
1264         (-[WebPreferences setCSSLogicalEnabled:]):
1265         * WebView/WebPreferencesPrivate.h:
1266         * WebView/WebView.mm:
1267         (-[WebView _preferencesChanged:]):
1268
1269 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1270
1271         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1272         https://bugs.webkit.org/show_bug.cgi?id=191612
1273
1274         Reviewed by Matt Baker.
1275
1276         * WebCoreSupport/WebInspectorClient.mm:
1277         (-[WebInspectorWindowController destroyInspectorView]):
1278
1279 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1280
1281         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1282         https://bugs.webkit.org/show_bug.cgi?id=191494
1283         <rdar://problem/45469854>
1284
1285         Reviewed by Devin Rousso.
1286
1287         * WebCoreSupport/WebInspectorClient.h:
1288         WebKitLegacy will still have remote inspection of the Page directly.
1289
1290 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1291
1292         Make compositing updates incremental
1293         https://bugs.webkit.org/show_bug.cgi?id=90342
1294
1295         Reviewed by Antti Koivisto.
1296
1297         Fix spelling error.
1298
1299         * WebView/WebView.mm:
1300         (-[WebView _setMediaLayer:forPluginView:]):
1301
1302 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1303
1304         Implement a new edit command to change the enclosing list type
1305         https://bugs.webkit.org/show_bug.cgi?id=191487
1306         <rdar://problem/45955922>
1307
1308         Reviewed by Ryosuke Niwa.
1309
1310         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1311
1312         * WebCoreSupport/WebEditorClient.mm:
1313         (undoNameForEditAction):
1314
1315 2018-11-11  Daniel Bates  <dabates@apple.com>
1316
1317         [iOS] Draw caps lock indicator in password fields
1318         https://bugs.webkit.org/show_bug.cgi?id=190565
1319         <rdar://problem/45262343>
1320
1321         Reviewed by Dean Jackson.
1322
1323         Update the caps lock state when a hardware keyboard is attached or detached.
1324
1325         * WebView/WebHTMLView.mm:
1326         (hardwareKeyboardAvailabilityChangedCallback): Added.
1327         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1328         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1329
1330 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1331
1332         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1333         https://bugs.webkit.org/show_bug.cgi?id=191492
1334
1335         Reviewed by Alex Christensen.
1336
1337         * Carbon/HIWebView.mm:
1338         * Misc/WebNSFileManagerExtras.mm:
1339         * Misc/WebNSURLExtras.mm:
1340         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1341         * Plugins/WebBasePluginPackage.mm:
1342         * Plugins/WebPluginContainerCheck.mm:
1343         * WebCoreSupport/WebCachedFramePlatformData.h:
1344         * WebCoreSupport/WebDeviceOrientationClient.mm:
1345         * WebView/WebDelegateImplementationCaching.mm:
1346         * WebView/WebHTMLView.mm:
1347         * WebView/WebPDFRepresentation.mm:
1348         * WebView/WebPolicyDelegate.mm:
1349         * WebView/WebView.mm:
1350
1351 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1352
1353         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1354         https://bugs.webkit.org/show_bug.cgi?id=191492
1355
1356         Reviewed by Alex Christensen.
1357
1358         * Carbon/HIWebView.mm:
1359         (UpdateCommandStatus):
1360         * Misc/WebNSFileManagerExtras.mm:
1361         * Misc/WebNSURLExtras.mm:
1362         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1363         * Plugins/WebBasePluginPackage.mm:
1364         * Plugins/WebPluginContainerCheck.mm:
1365         (-[WebPluginContainerCheck _continueWithPolicy:]):
1366         * WebCoreSupport/WebCachedFramePlatformData.h:
1367         (WebCachedFramePlatformData::clear):
1368         * WebCoreSupport/WebDeviceOrientationClient.mm:
1369         (WebDeviceOrientationClient::getProvider const):
1370         * WebView/WebDelegateImplementationCaching.mm:
1371         (CallDelegate):
1372         (CallDelegateReturningBoolean):
1373         (CallResourceLoadDelegateReturningBoolean):
1374         (CallFormDelegate):
1375         (CallFormDelegateReturningBoolean):
1376         * WebView/WebHTMLView.mm:
1377         * WebView/WebPDFRepresentation.mm:
1378         * WebView/WebPolicyDelegate.mm:
1379         (-[WebPolicyDecisionListener _usePolicy:]):
1380         * WebView/WebView.mm:
1381
1382 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1383
1384         Unreviewed, rolling out r238047.
1385
1386         Introduced layout test failures on iOS simulator.
1387
1388         Reverted changeset:
1389
1390         "[iOS] Draw caps lock indicator in password fields"
1391         https://bugs.webkit.org/show_bug.cgi?id=190565
1392         https://trac.webkit.org/changeset/238047
1393
1394 2018-11-09  Antti Koivisto  <antti@apple.com>
1395
1396         Use OptionSet for layout milestones
1397         https://bugs.webkit.org/show_bug.cgi?id=191470
1398
1399         Reviewed by Dean Jackson.
1400
1401         * WebCoreSupport/WebFrameLoaderClient.h:
1402         * WebCoreSupport/WebFrameLoaderClient.mm:
1403         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1404         * WebView/WebView.mm:
1405         (coreLayoutMilestones):
1406         (kitLayoutMilestones):
1407         (-[WebView _cacheFrameLoadDelegateImplementations]):
1408         * WebView/WebViewInternal.h:
1409
1410 2018-11-09  Daniel Bates  <dabates@apple.com>
1411
1412         [iOS] Draw caps lock indicator in password fields
1413         https://bugs.webkit.org/show_bug.cgi?id=190565
1414         <rdar://problem/45262343>
1415
1416         Reviewed by Dean Jackson.
1417
1418         Update the caps lock state when a hardware keyboard is attached or detached.
1419
1420         * WebView/WebHTMLView.mm:
1421         (hardwareKeyboardAvailabilityChangedCallback): Added.
1422         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1423         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1424
1425 2018-11-09  Daniel Bates  <dabates@apple.com>
1426
1427         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1428         action when forward delete is pressed outside a text field
1429         https://bugs.webkit.org/show_bug.cgi?id=190566
1430         <rdar://problem/45262367>
1431
1432         Reviewed by Wenson Hsieh.
1433
1434         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1435         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1436         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1437
1438         * WebView/WebHTMLView.mm:
1439         (-[WebHTMLView _handleEditingKeyEvent:]):
1440
1441 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1442
1443         Adopt Reveal Framework to replace Lookup
1444         https://bugs.webkit.org/show_bug.cgi?id=191097
1445         <rdar://problem/45924508>
1446
1447         Reviewed by Tim Horton.
1448
1449         Pass in what it needed to clear the textIndicators. This is better than
1450         the current notification structure.
1451
1452         * WebView/WebView.mm:
1453         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1454         (-[WebView _prepareForDictionaryLookup]):
1455
1456 2018-11-06  Justin Fan  <justin_fan@apple.com>
1457
1458         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1459         https://bugs.webkit.org/show_bug.cgi?id=191291
1460
1461         Reviewed by Myles Maxfield.
1462
1463         Properly disable WEBGPU on all non-Metal platforms for now.
1464
1465         * Configurations/FeatureDefines.xcconfig:
1466
1467 2018-11-02  Daniel Bates  <dabates@apple.com>
1468
1469         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1470         https://bugs.webkit.org/show_bug.cgi?id=190487
1471
1472         Reviewed by Tim Horton.
1473
1474         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1475         allow the default handling.
1476
1477         * WebView/WebHTMLView.mm:
1478         (-[WebHTMLView _handleEditingKeyEvent:]):
1479
1480 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1481
1482         Add a storage limit for IndexedDB
1483         https://bugs.webkit.org/show_bug.cgi?id=190598
1484         <rdar://problem/44654715>
1485
1486         Reviewed by Chris Dumez.
1487
1488         * Storage/WebDatabaseManager.mm:
1489         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1490         * Storage/WebDatabaseManagerPrivate.h:
1491
1492 2018-10-31  Antti Koivisto  <antti@apple.com>
1493
1494         Remove LayerFlushScheduler
1495         https://bugs.webkit.org/show_bug.cgi?id=191103
1496
1497         Reviewed by Anders Carlsson.
1498
1499         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1500         all the virtual cruft.
1501
1502         * WebView/WebViewData.h:
1503         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1504         (): Deleted.
1505         * WebView/WebViewData.mm:
1506         (currentRunLoop):
1507         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1508         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1509         (WebViewLayerFlushScheduler::schedule):
1510         (WebViewLayerFlushScheduler::invalidate):
1511         (WebViewLayerFlushScheduler::layerFlushCallback):
1512
1513 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1514
1515         Enable InstallAPI for iOS unconditionally
1516         https://bugs.webkit.org/show_bug.cgi?id=191043
1517         rdar://problem/32728423
1518
1519         Reviewed by Dan Bernstein.
1520
1521         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1522         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1523         shouldn't be processed by InstallAPI.
1524         * MigrateHeaders.make: Removed an obsolete workaround.
1525         * Misc/NSURLDownloadSPI.h: Added.
1526         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1527
1528 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1529
1530         Clean up some obsolete MAX_ALLOWED macros
1531         https://bugs.webkit.org/show_bug.cgi?id=190916
1532
1533         Reviewed by Tim Horton.
1534
1535         * WebView/WebHTMLView.mm:
1536         (-[WebHTMLView pressureChangeWithEvent:]):
1537         * WebView/WebPDFView.h:
1538
1539 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1540
1541         Unreviewed, rolling out r237600 and r237604.
1542         https://bugs.webkit.org/show_bug.cgi?id=191086
1543
1544         Breaks internal iOS builds (Requested by ryanhadd_ on
1545         #webkit).
1546
1547         Reverted changesets:
1548
1549         "Enable InstallAPI for iOS unconditionally"
1550         https://bugs.webkit.org/show_bug.cgi?id=191043
1551         https://trac.webkit.org/changeset/237600
1552
1553         "Build fix attempt after enabling InstallAPI for iOS."
1554         https://bugs.webkit.org/show_bug.cgi?id=191043
1555         https://trac.webkit.org/changeset/237604
1556
1557 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1558
1559         Enable InstallAPI for iOS unconditionally
1560         https://bugs.webkit.org/show_bug.cgi?id=191043
1561         rdar://problem/32728423
1562
1563         Reviewed by Dan Bernstein.
1564
1565         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1566         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1567         shouldn't be processed by InstallAPI.
1568         * MigrateHeaders.make: Removed an obsolete workaround.
1569         * Misc/NSURLDownloadSPI.h: Added.
1570         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1571
1572 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1573
1574         Modernize WebKit nibs and lprojs for localization's sake
1575         https://bugs.webkit.org/show_bug.cgi?id=190911
1576         <rdar://problem/45349466>
1577
1578         Reviewed by Dan Bernstein.
1579
1580         * Misc/WebNSControlExtras.m:
1581         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1582         NSWindow and its contents are both in the same scale space these days; avoid
1583         double-applying the scale factor, or you can't see the prompt.
1584
1585         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1586         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1587         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1588         NIB->XIB
1589
1590 2018-10-25  Antoine Quint  <graouts@apple.com>
1591
1592         [Web Animations] Turn Web Animations CSS Integration off by default
1593         https://bugs.webkit.org/show_bug.cgi?id=190901
1594
1595         Reviewed by Dean Jackson.
1596
1597         * WebView/WebPreferences.mm:
1598         (+[WebPreferences initialize]):
1599
1600 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1601
1602         Clean up some obsolete macOS version guards
1603         https://bugs.webkit.org/show_bug.cgi?id=190887
1604
1605         Reviewed by Dan Bernstein.
1606
1607         * Misc/WebNSPasteboardExtras.mm:
1608         (+[NSPasteboard _web_dragTypesForURL]):
1609         * WebCoreSupport/PopupMenuMac.mm:
1610         (PopupMenuMac::show):
1611         * WebCoreSupport/WebEditorClient.h:
1612         * WebCoreSupport/WebEditorClient.mm:
1613         (WebEditorClient::respondToChangedSelection):
1614         * WebView/WebPDFView.mm:
1615         (-[WebPDFView _clipViewForPDFDocumentView]):
1616
1617 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1618
1619         Turn on Conic Gradients
1620         https://bugs.webkit.org/show_bug.cgi?id=190810
1621
1622         Reviewed by Tim Horton.
1623
1624         * Configurations/FeatureDefines.xcconfig:
1625
1626 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1627
1628         Cleanup: MIMETypeRegistry functions
1629         https://bugs.webkit.org/show_bug.cgi?id=190838
1630
1631         Reviewed by Simon Fraser.
1632
1633         * Misc/WebNSPasteboardExtras.mm:
1634         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1635         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1636         because they were identical.
1637
1638         * WebView/WebHTMLRepresentation.mm:
1639         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1640         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1641         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1642         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1643         * WebView/WebView.mm:
1644         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1645         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1646         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1647
1648 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1649
1650         Fix false positive leaks when using custom -init methods that don't start with -init
1651         <https://webkit.org/b/190818>
1652         <rdar://problem/45476042>
1653
1654         Reviewed by Dan Bernstein.
1655
1656         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1657         it is accessible by both categories.
1658         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1659         NSError (WebKitInternal) category.  Add attribute to make this
1660         behave like an -init method.
1661         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1662         NSError (WebKitInternal) category.  Modernize method.  Replace
1663         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1664
1665 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1666
1667         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1668         https://bugs.webkit.org/show_bug.cgi?id=190729
1669
1670         Reviewed by Tim Horton.
1671
1672         * DOM/DOM.mm:
1673         (-[DOMNode boundingBox]):
1674         * DOM/DOMElement.mm:
1675         * DOM/DOMHTML.mm:
1676         * DOM/DOMInternal.mm:
1677         * DOM/DOMUIKitExtensions.mm:
1678         * DOM/WebDOMOperations.mm:
1679         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1680         * DefaultDelegates/WebDefaultEditingDelegate.m:
1681         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1682         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1683         * DefaultDelegates/WebDefaultUIDelegate.h:
1684         * DefaultDelegates/WebDefaultUIDelegate.mm:
1685         (-[WebDefaultUIDelegate webViewClose:]):
1686         (-[WebDefaultUIDelegate webViewFocus:]):
1687         (-[WebDefaultUIDelegate webViewUnfocus:]):
1688         (-[WebDefaultUIDelegate webViewIsResizable:]):
1689         (-[WebDefaultUIDelegate webView:setResizable:]):
1690         (-[WebDefaultUIDelegate webView:setFrame:]):
1691         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1692         * History/BackForwardList.h:
1693         * History/BackForwardList.mm:
1694         * History/WebBackForwardList.mm:
1695         (+[WebBackForwardList initialize]):
1696         (bumperCarBackForwardHackNeeded):
1697         * History/WebHistory.mm:
1698         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1699         (-[WebHistory _sendNotification:entries:]):
1700         (-[WebHistory loadFromURL:error:]):
1701         (-[WebHistory saveToURL:error:]):
1702         * History/WebHistoryItem.mm:
1703         (WKNotifyHistoryItemChanged):
1704         (+[WebHistoryItem initialize]):
1705         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1706         * History/WebURLsWithTitles.m:
1707         * Misc/WebCache.mm:
1708         (+[WebCache initialize]):
1709         * Misc/WebDownload.mm:
1710         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1711         * Misc/WebElementDictionary.mm:
1712         (+[WebElementDictionary initialize]):
1713         (+[WebElementDictionary initializeLookupTable]):
1714         * Misc/WebIconDatabase.mm:
1715         * Misc/WebKitNSStringExtras.mm:
1716         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1717         * Misc/WebKitVersionChecks.h:
1718         * Misc/WebKitVersionChecks.mm:
1719         (WebKitLinkedOnOrAfter):
1720         (WebKitLinkTimeVersion):
1721         * Misc/WebLocalizableStrings.mm:
1722         * Misc/WebNSControlExtras.h:
1723         * Misc/WebNSControlExtras.m:
1724         * Misc/WebNSEventExtras.m:
1725         * Misc/WebNSFileManagerExtras.mm:
1726         * Misc/WebNSImageExtras.h:
1727         * Misc/WebNSImageExtras.m:
1728         * Misc/WebNSPasteboardExtras.mm:
1729         * Misc/WebNSPrintOperationExtras.h:
1730         * Misc/WebNSPrintOperationExtras.m:
1731         * Misc/WebNSViewExtras.m:
1732         * Misc/WebNSWindowExtras.m:
1733         * Panels/WebAuthenticationPanel.h:
1734         * Panels/WebAuthenticationPanel.m:
1735         * Panels/WebPanelAuthenticationHandler.m:
1736         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1737         (+[WebHostedNetscapePluginView initialize]):
1738         * Plugins/WebBasePluginPackage.h:
1739         * Plugins/WebBasePluginPackage.mm:
1740         * Plugins/WebJavaPlugIn.h:
1741         * Plugins/WebPluginContainerCheck.mm:
1742         * Plugins/WebPluginController.h:
1743         * Plugins/WebPluginController.mm:
1744         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1745         (-[WebPluginController addPlugin:]):
1746         (-[WebPluginController destroyPlugin:]):
1747         (-[WebPluginController destroyAllPlugins]):
1748         * Plugins/WebPluginDatabase.mm:
1749         (+[WebPluginDatabase _defaultPlugInPaths]):
1750         * Plugins/WebPluginPackage.mm:
1751         (-[WebPluginPackage initWithPath:]):
1752         * Storage/WebDatabaseManager.mm:
1753         (-[WebDatabaseManager deleteAllDatabases]):
1754         * Storage/WebDatabaseManagerClient.h:
1755         * Storage/WebDatabaseManagerClient.mm:
1756         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1757         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1758         * Storage/WebStorageManager.mm:
1759         (-[WebStorageManager deleteAllOrigins]):
1760         (WebKitInitializeStorageIfNecessary):
1761         * WebCoreSupport/WebAlternativeTextClient.h:
1762         * WebCoreSupport/WebApplicationCache.mm:
1763         (applicationCacheBundleIdentifier):
1764         * WebCoreSupport/WebChromeClient.h:
1765         * WebCoreSupport/WebChromeClient.mm:
1766         (WebChromeClient::setWindowRect):
1767         (WebChromeClient::windowRect):
1768         (WebChromeClient::takeFocus):
1769         (WebChromeClient::addMessageToConsole):
1770         (WebChromeClient::enableSuddenTermination):
1771         (WebChromeClient::disableSuddenTermination):
1772         (WebChromeClient::createPopupMenu const):
1773         (WebChromeClient::createSearchPopupMenu const):
1774         (WebChromeClient::shouldPaintEntireContents const):
1775         (WebChromeClient::supportsVideoFullscreen):
1776         (WebChromeClient::supportsFullScreenForElement):
1777         (WebChromeClient::enterFullScreenForElement):
1778         (WebChromeClient::exitFullScreenForElement):
1779         * WebCoreSupport/WebContextMenuClient.mm:
1780         * WebCoreSupport/WebDragClient.mm:
1781         * WebCoreSupport/WebEditorClient.h:
1782         * WebCoreSupport/WebEditorClient.mm:
1783         (+[WebUndoStep initialize]):
1784         (updateFontPanel):
1785         (WebEditorClient::didBeginEditing):
1786         (WebEditorClient::respondToChangedContents):
1787         (WebEditorClient::respondToChangedSelection):
1788         (WebEditorClient::canceledComposition):
1789         (WebEditorClient::didEndEditing):
1790         (WebEditorClient::didWriteSelectionToPasteboard):
1791         (attributesForAttributedStringConversion):
1792         (WebEditorClient::setInsertionPasteboard):
1793         (WebEditorClient::registerUndoOrRedoStep):
1794         (WebEditorClient::handleKeyboardEvent):
1795         (WebEditorClient::handleInputMethodKeydown):
1796         (WebEditorClient::textDidChangeInTextField):
1797         (WebEditorClient::requestCheckingOfString):
1798         * WebCoreSupport/WebFrameLoaderClient.h:
1799         * WebCoreSupport/WebFrameLoaderClient.mm:
1800         (WebFrameLoaderClient::detachedFromParent2):
1801         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1802         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1803         (WebFrameLoaderClient::dispatchWillSendRequest):
1804         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1805         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1806         (WebFrameLoaderClient::willCacheResponse const):
1807         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1808         (WebFrameLoaderClient::dispatchDidFinishLoading):
1809         (WebFrameLoaderClient::dispatchDidFailLoading):
1810         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1811         (WebFrameLoaderClient::dispatchWillClose):
1812         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1813         (WebFrameLoaderClient::dispatchDidCommitLoad):
1814         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1815         (WebFrameLoaderClient::dispatchDidFailLoad):
1816         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1817         (WebFrameLoaderClient::dispatchDidFinishLoad):
1818         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1819         (WebFrameLoaderClient::willChangeTitle):
1820         (WebFrameLoaderClient::didChangeTitle):
1821         (WebFrameLoaderClient::didReplaceMultipartContent):
1822         (WebFrameLoaderClient::updateGlobalHistory):
1823         (WebFrameLoaderClient::saveViewStateToItem):
1824         (WebFrameLoaderClient::restoreViewState):
1825         (WebFrameLoaderClient::provisionalLoadStarted):
1826         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1827         (WebFrameLoaderClient::setTitle):
1828         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1829         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1830         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1831         (WebFrameLoaderClient::didRestoreFromPageCache):
1832         (WebFrameLoaderClient::actionDictionary const):
1833         (WebFrameLoaderClient::createPlugin):
1834         (WebFrameLoaderClient::getLoadDecisionForIcons):
1835         (WebFrameLoaderClient::finishedLoadingIcon):
1836         (+[WebFramePolicyListener initialize]):
1837         * WebCoreSupport/WebFrameNetworkingContext.mm:
1838         * WebCoreSupport/WebGeolocationClient.h:
1839         * WebCoreSupport/WebGeolocationClient.mm:
1840         (WebGeolocationClient::requestPermission):
1841         * WebCoreSupport/WebInspectorClient.h:
1842         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1843         * WebCoreSupport/WebNotificationClient.mm:
1844         * WebCoreSupport/WebOpenPanelResultListener.mm:
1845         * WebCoreSupport/WebPlatformStrategies.h:
1846         * WebCoreSupport/WebPlatformStrategies.mm:
1847         * WebCoreSupport/WebProgressTrackerClient.h:
1848         * WebCoreSupport/WebProgressTrackerClient.mm:
1849         (WebProgressTrackerClient::progressStarted):
1850         (WebProgressTrackerClient::progressEstimateChanged):
1851         (WebProgressTrackerClient::progressFinished):
1852         * WebCoreSupport/WebSecurityOrigin.mm:
1853         * WebInspector/WebNodeHighlight.h:
1854         * WebInspector/WebNodeHighlight.mm:
1855         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1856         (-[WebNodeHighlight dealloc]):
1857         (-[WebNodeHighlight attach]):
1858         * WebInspector/WebNodeHighlightView.h:
1859         * WebInspector/WebNodeHighlightView.mm:
1860         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1861         (-[WebNodeHighlightView dealloc]):
1862         * WebInspector/WebNodeHighlighter.mm:
1863         (-[WebNodeHighlighter highlight]):
1864         * WebView/WebArchive.mm:
1865         (+[WebArchivePrivate initialize]):
1866         * WebView/WebClipView.h:
1867         * WebView/WebDataSource.mm:
1868         (WebDataSourcePrivate::WebDataSourcePrivate):
1869         (+[WebDataSource initialize]):
1870         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1871         (-[WebDataSource _makeRepresentation]):
1872         * WebView/WebDelegateImplementationCaching.h:
1873         * WebView/WebDelegateImplementationCaching.mm:
1874         (CallDelegate):
1875         (CallDelegateReturningFloat):
1876         (CallDelegateReturningBoolean):
1877         (CallUIDelegate):
1878         (CallUIDelegateReturningFloat):
1879         (CallUIDelegateReturningBoolean):
1880         (CallFrameLoadDelegate):
1881         (CallFrameLoadDelegateReturningBoolean):
1882         (CallResourceLoadDelegate):
1883         (CallScriptDebugDelegate):
1884         (CallFormDelegate):
1885         (CallFormDelegateReturningBoolean):
1886         * WebView/WebDeviceOrientation.mm:
1887         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1888         * WebView/WebDocumentInternal.h:
1889         * WebView/WebDocumentLoaderMac.mm:
1890         (needsDataLoadWorkaround):
1891         * WebView/WebDynamicScrollBarsViewInternal.h:
1892         * WebView/WebFormDelegate.m:
1893         * WebView/WebFrame.mm:
1894         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1895         (-[WebFrame _unmarkAllMisspellings]):
1896         (-[WebFrame _paintBehaviorForDestinationContext:]):
1897         (-[WebFrame _drawRect:contentsOnly:]):
1898         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1899         (-[WebFrame _scrollDOMRangeToVisible:]):
1900         (-[WebFrame _bodyBackgroundColor]):
1901         (-[WebFrame accessibilityRoot]):
1902         (needsMicrosoftMessengerDOMDocumentWorkaround):
1903         * WebView/WebFrameInternal.h:
1904         * WebView/WebFrameView.mm:
1905         (-[WebFrameView _setDocumentView:]):
1906         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1907         (-[WebFrameView _viewClassForMIMEType:]):
1908         (-[WebFrameView initWithFrame:]):
1909         (-[WebFrameView drawRect:]):
1910         (-[WebFrameView _firstResponderIsFormControl]):
1911         (-[WebFrameView keyDown:keyDown:]):
1912         (-[WebFrameView _isScrollable]):
1913         * WebView/WebFullScreenController.h:
1914         * WebView/WebFullScreenController.mm:
1915         * WebView/WebHTMLRepresentation.mm:
1916         * WebView/WebHTMLView.mm:
1917         (-[WebHTMLView hitTest:]):
1918         (-[WebHTMLView initWithFrame:]):
1919         (-[WebHTMLView dealloc]):
1920         (-[WebHTMLView addSubview:]):
1921         (-[WebHTMLView mouseDown:]):
1922         (-[WebHTMLView mouseUp:]):
1923         (-[WebHTMLView resignFirstResponder]):
1924         (-[WebHTMLView accessibilityHitTest:]):
1925         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1926         * WebView/WebHTMLViewInternal.h:
1927         * WebView/WebIndicateLayer.h:
1928         * WebView/WebIndicateLayer.mm:
1929         * WebView/WebMediaPlaybackTargetPicker.h:
1930         * WebView/WebMediaPlaybackTargetPicker.mm:
1931         * WebView/WebPDFDocumentExtras.h:
1932         * WebView/WebPDFDocumentExtras.mm:
1933         * WebView/WebPDFRepresentation.h:
1934         * WebView/WebPDFRepresentation.mm:
1935         * WebView/WebPDFView.h:
1936         * WebView/WebPreferences.mm:
1937         (cacheModelForMainBundle):
1938         (WebPreferencesPrivate::WebPreferencesPrivate):
1939         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1940         (-[WebPreferences encodeWithCoder:]):
1941         (+[WebPreferences standardPreferences]):
1942         (+[WebPreferences initialize]):
1943         (-[WebPreferences _valueForKey:]):
1944         (-[WebPreferences _setStringValue:forKey:]):
1945         (-[WebPreferences _setIntegerValue:forKey:]):
1946         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1947         (-[WebPreferences _setFloatValue:forKey:]):
1948         (-[WebPreferences _setBoolValue:forKey:]):
1949         (-[WebPreferences _setLongLongValue:forKey:]):
1950         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1951         (-[WebPreferences _postCacheModelChangedNotification]):
1952         (-[WebPreferences _postPreferencesChangedNotification]):
1953         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1954         (-[WebPreferences setStorageBlockingPolicy:]):
1955         * WebView/WebResource.mm:
1956         (+[WebResourcePrivate initialize]):
1957         * WebView/WebTextCompletionController.h:
1958         * WebView/WebTextIterator.mm:
1959         (+[WebTextIteratorPrivate initialize]):
1960         * WebView/WebView.mm:
1961         (shouldEnableLoadDeferring):
1962         (shouldRestrictWindowFocus):
1963         (shouldRespectPriorityInCSSAttributeSetters):
1964         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1965         (shouldAllowPictureInPictureMediaPlayback):
1966         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1967         (shouldAllowWindowOpenWithoutUserGesture):
1968         (shouldConvertInvalidURLsToBlank):
1969         (shouldRequireUserGestureToLoadVideo):
1970         (-[WebView _commonInitializationWithFrameName:groupName:]):
1971         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1972         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1973         (-[WebView _closePluginDatabases]):
1974         (-[WebView _closeWithFastTeardown]):
1975         (-[WebView _close]):
1976         (+[WebView _MIMETypeForFile:]):
1977         (-[WebView setShowingInspectorIndication:]):
1978         (-[WebView _setFormDelegate:]):
1979         (-[WebView _needsPreHTML5ParserQuirks]):
1980         (-[WebView _preferencesChangedNotification:]):
1981         (-[WebView _preferencesChanged:]):
1982         (-[WebView _cacheResourceLoadDelegateImplementations]):
1983         (-[WebView _cacheFrameLoadDelegateImplementations]):
1984         (-[WebView _policyDelegateForwarder]):
1985         (-[WebView _UIDelegateForwarder]):
1986         (-[WebView _editingDelegateForwarder]):
1987         (-[WebView _updateActiveState]):
1988         (-[_WebSafeForwarder forwardInvocation:]):
1989         (+[WebView initialize]):
1990         (-[WebView _pluginForMIMEType:]):
1991         (-[WebView _pluginForExtension:]):
1992         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1993         (+[WebView canShowMIMETypeAsHTML:]):
1994         (-[WebView _initWithArguments:]):
1995         (-[WebView initWithFrame:frameName:groupName:]):
1996         (-[WebView dealloc]):
1997         (-[WebView close]):
1998         (-[WebView viewDidMoveToWindow]):
1999         (-[WebView setUIDelegate:]):
2000         (-[WebView setResourceLoadDelegate:]):
2001         (-[WebView setPolicyDelegate:]):
2002         (-[WebView setFrameLoadDelegate:]):
2003         (-[WebView goBack]):
2004         (-[WebView goForward]):
2005         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2006         (-[WebView setHostWindow:]):
2007         (-[WebView becomeFirstResponder]):
2008         (+[WebView _cacheModelChangedNotification:]):
2009         (-[WebView _frameViewAtWindowPoint:]):
2010         (+[WebView _preflightSpellCheckerNow:]):
2011         (+[WebView _preflightSpellChecker]):
2012         (-[WebView canGoBack]):
2013         (-[WebView canGoForward]):
2014         (-[WebView stopLoading:]):
2015         (-[WebView reload:]):
2016         (-[WebView setMainFrameDocumentReady:]):
2017         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2018         (-[WebView setContinuousSpellCheckingEnabled:]):
2019         (-[WebView undoManager]):
2020         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2021         (-[WebView isAutomaticLinkDetectionEnabled]):
2022         (-[WebView isAutomaticDashSubstitutionEnabled]):
2023         (-[WebView isAutomaticTextReplacementEnabled]):
2024         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2025         (+[WebView _setCacheModel:]):
2026         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2027         (-[WebView _keyboardUIMode]):
2028         (LayerFlushController::flushLayers):
2029         (-[WebView _scheduleCompositingLayerFlush]):
2030         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2031         (-[WebView fullScreenPlaceholderView]):
2032         (WebInstallMemoryPressureHandler):
2033         * WebView/WebViewData.h:
2034         * WebView/WebViewData.mm:
2035         (+[WebViewPrivate initialize]):
2036         (-[WebViewPrivate init]):
2037         (-[WebViewPrivate dealloc]):
2038         * WebView/WebViewInternal.h:
2039
2040 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2041
2042         Clean up FrameLoader two-state enums
2043         https://bugs.webkit.org/show_bug.cgi?id=190731
2044
2045         Reviewed by Chris Dumez.
2046
2047         * WebCoreSupport/WebFrameLoaderClient.h:
2048         * WebCoreSupport/WebFrameLoaderClient.mm:
2049         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2050
2051 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2052
2053         Unreviewed, rolling out r237137.
2054
2055         SPI is actually used
2056
2057         Reverted changeset:
2058
2059         "Remove unused WebFrame._loadType"
2060         https://bugs.webkit.org/show_bug.cgi?id=190583
2061         https://trac.webkit.org/changeset/237137
2062
2063 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2064
2065         Enable the datalist element by default on iOS and macOS
2066         https://bugs.webkit.org/show_bug.cgi?id=190594
2067         <rdar://problem/45281159>
2068
2069         Reviewed by Ryosuke Niwa and Tim Horton.
2070
2071         * Configurations/FeatureDefines.xcconfig:
2072
2073 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2074
2075         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2076         https://bugs.webkit.org/show_bug.cgi?id=190675
2077
2078         Reviewed by Chris Dumez.
2079
2080         * History/BackForwardList.h:
2081         * History/BackForwardList.mm:
2082         (BackForwardList::backItem):
2083         (BackForwardList::currentItem):
2084         (BackForwardList::forwardItem):
2085         (BackForwardList::backListCount const):
2086         (BackForwardList::forwardListCount const):
2087         (BackForwardList::itemAtIndex):
2088         * History/WebBackForwardList.mm:
2089         (-[WebBackForwardList backItem]):
2090         (-[WebBackForwardList currentItem]):
2091         (-[WebBackForwardList forwardItem]):
2092         (-[WebBackForwardList itemAtIndex:]):
2093
2094 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2095
2096         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2097         https://bugs.webkit.org/show_bug.cgi?id=190526
2098         rdar://problem/45230140
2099
2100         Reviewed by Dean Jackson.
2101
2102         * WebCoreSupport/WebEditorClient.mm:
2103         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2104
2105 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2106
2107         Implement feature flag and bindings for CSS Painting API
2108         https://bugs.webkit.org/show_bug.cgi?id=190237
2109
2110         Reviewed by Ryosuke Niwa.
2111
2112         * Configurations/FeatureDefines.xcconfig:
2113
2114 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2115
2116         Replace HistoryItem* with HistoryItem& where possible
2117         https://bugs.webkit.org/show_bug.cgi?id=190617
2118
2119         Reviewed by Chris Dumez.
2120
2121         * History/BackForwardList.h:
2122         * History/BackForwardList.mm:
2123         (BackForwardList::goToItem):
2124         * History/WebBackForwardList.mm:
2125         (-[WebBackForwardList goToItem:]):
2126         * History/WebHistoryItem.mm:
2127         (WKNotifyHistoryItemChanged):
2128         * History/WebHistoryItemInternal.h:
2129
2130 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2131
2132         Remove unused WebHistoryItem._transientPropertyForKey
2133         https://bugs.webkit.org/show_bug.cgi?id=190606
2134
2135         Reviewed by Chris Dumez.
2136
2137         * History/WebHistoryItem.mm:
2138         * History/WebHistoryItemPrivate.h:
2139
2140 2018-10-15  Justin Fan  <justin_fan@apple.com>
2141
2142         Add WebGPU 2018 feature flag and experimental feature flag
2143         https://bugs.webkit.org/show_bug.cgi?id=190509
2144
2145         Reviewed by Dean Jackson.
2146
2147         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2148         for the 2018 WebGPU prototype.
2149
2150         * Configurations/FeatureDefines.xcconfig:
2151         * WebView/WebPreferenceKeysPrivate.h:
2152         * WebView/WebPreferences.mm:
2153         (+[WebPreferences initialize]):
2154         (-[WebPreferences webGPUEnabled]):
2155         (-[WebPreferences setWebGPUEnabled:]):
2156         * WebView/WebPreferencesPrivate.h:
2157         * WebView/WebView.mm:
2158         (-[WebView _preferencesChanged:]):
2159
2160 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2161
2162         Fix iOS build after r237157
2163
2164         * WebView/WebView.mm:
2165         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2166
2167 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2168
2169         Modernize BackForwardClient.h
2170         https://bugs.webkit.org/show_bug.cgi?id=190610
2171
2172         Reviewed by Chris Dumez.
2173
2174         * History/BackForwardList.h:
2175         * History/BackForwardList.mm:
2176         (BackForwardList::backListCount const):
2177         (BackForwardList::forwardListCount const):
2178         (BackForwardList::backListCount): Deleted.
2179         (BackForwardList::forwardListCount): Deleted.
2180         * History/WebBackForwardList.mm:
2181         (-[WebBackForwardList init]):
2182         * WebCoreSupport/WebFrameLoaderClient.mm:
2183         (WebFrameLoaderClient::canCachePage const):
2184         * WebView/WebFrameView.mm:
2185         (-[WebFrameView keyDown:keyDown:]):
2186         * WebView/WebView.mm:
2187         (-[WebView _commonInitializationWithFrameName:groupName:]):
2188         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2189         (-[WebView _loadBackForwardListFromOtherView:]):
2190         (-[WebView initWithCoder:]):
2191         (-[WebView encodeWithCoder:]):
2192         (-[WebView backForwardList]):
2193         (-[WebView setMaintainsBackForwardList:]):
2194
2195 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2196
2197         Add support for prefers-color-scheme media query
2198         https://bugs.webkit.org/show_bug.cgi?id=190499
2199         rdar://problem/45212025
2200
2201         Reviewed by Dean Jackson.
2202
2203         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2204
2205 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2206
2207         Remove unused WebView._globalHistoryItem
2208         https://bugs.webkit.org/show_bug.cgi?id=190601
2209
2210         Reviewed by Chris Dumez.
2211
2212         * WebCoreSupport/WebFrameLoaderClient.h:
2213         * WebCoreSupport/WebFrameLoaderClient.mm:
2214         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2215         * WebView/WebView.mm:
2216         (-[WebView _globalHistoryItem]): Deleted.
2217         (-[WebView _setGlobalHistoryItem:]): Deleted.
2218         * WebView/WebViewData.h:
2219         * WebView/WebViewInternal.h:
2220         * WebView/WebViewPrivate.h:
2221
2222 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2223
2224         Remove unused parameters from FrameLoaderClient::createFrame
2225         https://bugs.webkit.org/show_bug.cgi?id=190587
2226
2227         Reviewed by Chris Dumez.
2228
2229         * WebCoreSupport/WebFrameLoaderClient.h:
2230         * WebCoreSupport/WebFrameLoaderClient.mm:
2231         (WebFrameLoaderClient::createFrame):
2232
2233 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2234
2235         Remove unused WebFrame._loadType
2236         https://bugs.webkit.org/show_bug.cgi?id=190583
2237
2238         Reviewed by Chris Dumez.
2239
2240         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2241
2242         * WebView/WebFrame.mm:
2243         (toWebFrameLoadType): Deleted.
2244         (-[WebFrame _loadType]): Deleted.
2245         * WebView/WebFramePrivate.h:
2246
2247 2018-10-15  Chris Dumez  <cdumez@apple.com>
2248
2249         Restrict browsing context lookup by name to frames that are related to one another
2250         https://bugs.webkit.org/show_bug.cgi?id=190475
2251
2252         Reviewed by Alex Christensen.
2253
2254         * WebView/WebFrame.mm:
2255         (-[WebFrame findFrameNamed:]):
2256
2257 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2258
2259         Remove InjectedBundle processing of back/forward lists
2260         https://bugs.webkit.org/show_bug.cgi?id=190459
2261
2262         Reviewed by Chris Dumez.
2263
2264         * WebCoreSupport/WebFrameLoaderClient.h:
2265         * WebCoreSupport/WebFrameLoaderClient.mm:
2266         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2267
2268 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2269
2270         [JSC] Remove Option::useAsyncIterator
2271         https://bugs.webkit.org/show_bug.cgi?id=190567
2272
2273         Reviewed by Saam Barati.
2274
2275         * Configurations/FeatureDefines.xcconfig:
2276
2277 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2278
2279         Allow encoding of small enum classes
2280         https://bugs.webkit.org/show_bug.cgi?id=190531
2281
2282         Reviewed by Tim Horton.
2283
2284         * WebCoreSupport/WebFrameLoaderClient.mm:
2285         (-[WebFramePolicyListener dealloc]):
2286
2287 2018-10-11  Keith Rollin  <krollin@apple.com>
2288
2289         CURRENT_ARCH should not be used in Run Script phase.
2290         https://bugs.webkit.org/show_bug.cgi?id=190407
2291         <rdar://problem/45133556>
2292
2293         Reviewed by Alexey Proskuryakov.
2294
2295         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2296         CURRENT_ARCH is not well-defined during this phase (and may even have
2297         the value "undefined") since this phase is run just once per build
2298         rather than once per supported architecture. Migrate away from
2299         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2300         performing an operation for each value, or by picking the first entry
2301         in ARCHS and using that as a representative value.
2302
2303         * Configurations/WebKitLegacy.xcconfig: When generating
2304         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2305         macosx platforms.
2306
2307         * MigrateHeaders.make:
2308         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2309         generate one for each architecture in ARCHS.
2310
2311 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2312
2313         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2314         https://bugs.webkit.org/show_bug.cgi?id=190429
2315
2316         Reviewed by Saam Barati.
2317
2318         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2319
2320         * WebView/WebPDFRepresentation.mm:
2321         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2322
2323 2018-10-08  Justin Fan  <justin_fan@apple.com>
2324
2325         WebGPU: Rename old WebGPU prototype to WebMetal
2326         https://bugs.webkit.org/show_bug.cgi?id=190325
2327         <rdar://problem/44990443>
2328
2329         Reviewed by Dean Jackson.
2330
2331         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2332
2333         * Configurations/FeatureDefines.xcconfig:
2334         * WebView/WebPreferenceKeysPrivate.h:
2335         * WebView/WebPreferences.mm:
2336         (+[WebPreferences initialize]):
2337         (-[WebPreferences webMetalEnabled]):
2338         (-[WebPreferences setWebMetalEnabled:]):
2339         (-[WebPreferences webGPUEnabled]): Deleted.
2340         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2341         * WebView/WebPreferencesPrivate.h:
2342         * WebView/WebView.mm:
2343         (-[WebView _preferencesChanged:]):
2344
2345 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2346
2347         Make <input type=color> a runtime enabled (on-by-default) feature
2348         https://bugs.webkit.org/show_bug.cgi?id=189162
2349
2350         Reviewed by Wenson Hsieh and Tim Horton.
2351
2352         * Configurations/FeatureDefines.xcconfig:
2353
2354 2018-10-07  Dan Bernstein  <mitz@apple.com>
2355
2356         Fixed building with the latest macOS SDK
2357
2358         * Plugins/WebNetscapePluginPackage.mm:
2359         (-[WebNetscapePluginPackage openResourceFile]):
2360         (-[WebNetscapePluginPackage closeResourceFile:]):
2361
2362 2018-10-04  Dan Bernstein  <mitz@apple.com>
2363
2364         More Carbon build-fixing.
2365
2366         * Carbon/CarbonWindowAdapter.mm:
2367         (-[CarbonWindowAdapter _destroyRealWindow:]):
2368         (-[CarbonWindowAdapter _growBoxRect]):
2369
2370 2018-10-04  Dan Bernstein  <mitz@apple.com>
2371
2372         Retried to fix 32-bit macOS builds after r236846.
2373
2374         * WebView/WebHTMLView.mm:
2375         (-[WebHTMLView setMarkedText:selectedRange:]):
2376
2377 2018-10-04  Dan Bernstein  <mitz@apple.com>
2378
2379         Retried to fix 32-bit macOS builds after r236846.
2380
2381         * Carbon/HIWebView.mm:
2382         (ActiveStateChanged):
2383
2384 2018-10-04  Dan Bernstein  <mitz@apple.com>
2385
2386         Tried to fix 32-bit macOS builds after r236846.
2387
2388         * Carbon/HIWebView.mm:
2389         (_NSSelectorForHICommand):
2390
2391 2018-10-04  Dan Bernstein  <mitz@apple.com>
2392
2393         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2394         https://bugs.webkit.org/show_bug.cgi?id=190250
2395
2396         Reviewed by Andy Estes.
2397
2398         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2399           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2400           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2401           an earlier line set it to YES.
2402
2403         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2404         changes below.
2405
2406         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2407           provides some missing method declarations.
2408
2409         * Misc/WebDownload.mm:
2410         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2411           a deprecated method.
2412
2413         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2414
2415         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2416           other code in the file uses a method from it.
2417
2418         * Plugins/WebBaseNetscapePluginView.mm:
2419         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2420           a deprecated method.
2421
2422         * Plugins/WebPluginController.mm:
2423         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2424           around use of a selector that may be present in some WebKit client.
2425
2426         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2427           method declarations.
2428
2429         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2430           from here.
2431
2432         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2433           missing method declarations.
2434
2435         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2436           from here.
2437
2438         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2439           call from here.
2440         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2441           an obsolete delegate method for binary compatibility.
2442         (pluginView): Ditto.
2443
2444         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2445           call from here.
2446
2447         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2448           WebDeviceOrientationProviderMock protocol.
2449
2450         * WebView/WebDeviceOrientationProviderMock.mm:
2451         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2452           main @implementation.
2453
2454         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2455           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2456
2457         * WebView/WebDynamicScrollBarsView.mm:
2458         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2459           of a deprecated method.
2460
2461         * WebView/WebHTMLView.mm:
2462         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2463           selector warning around action methods that are not declared anywhere in WebKit.
2464
2465         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2466           about implementing this deprecated method.
2467         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2468         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2469         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2470         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2471         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2472         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2473         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2474         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2475         (-[WebHTMLView doCommandBySelector:]): Ditto.
2476         (-[WebHTMLView insertText:]): Ditto.
2477
2478         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2479
2480         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2481
2482         * WebView/WebPDFView.h: Removed previewView ivar.
2483
2484         * WebView/WebPDFView.mm:
2485           Removed declaration of FileInternal category and merged its implementation with the main
2486           implementation.
2487         (-[WebPDFView dealloc]): Removed previewView ivar.
2488         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2489           exist in macOS versions we support.
2490         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2491         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2492           action methods internal to PDFKit.
2493         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2494         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2495
2496         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2497           call on macOS, even though in r86988 we started calling different methods on iOS.
2498
2499         * WebView/WebView.mm:
2500         - Imported headers that declare delegate methods that we call.
2501         - Removed declaration of WebFileInternal category and merged its implementation with the
2502           main implementation.
2503         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2504           category, which made them impossible to call from the main implementation. Moved those
2505           into the main implementation. One of those had to be declared in a class extension,
2506           because it is called from a method implemented in the WebPrivate category, and that
2507           category’s implementation appears first in the file.
2508
2509         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2510           around use of obsolete delegate method for binary compatibility.
2511
2512         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2513
2514 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2515
2516         Runtime flag and IDL for MediaRecorder
2517         https://bugs.webkit.org/show_bug.cgi?id=190018
2518
2519         Reviewed by Youenn Fablet and Chris Dumez.
2520
2521         * WebView/WebPreferenceKeysPrivate.h:
2522         * WebView/WebPreferences.mm:
2523         (+[WebPreferences initialize]):
2524         (-[WebPreferences mediaRecorderEnabled]):
2525         (-[WebPreferences setMediaRecorderEnabled:]):
2526         * WebView/WebPreferencesPrivate.h:
2527         * WebView/WebView.mm:
2528         (-[WebView _preferencesChanged:]):
2529
2530 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2531
2532         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2533         https://bugs.webkit.org/show_bug.cgi?id=190238
2534
2535         Reviewed by Antti Koivisto.
2536
2537         Enabled the feature by default.
2538
2539         * WebView/WebPreferences.mm:
2540         (+[WebPreferences initialize]):
2541
2542 2018-10-01  Dean Jackson  <dino@apple.com>
2543
2544         [macOS] Switching to discrete GPU should be done in the UI process
2545         https://bugs.webkit.org/show_bug.cgi?id=189361
2546         <rdar://problem/43949622>
2547
2548         Reviewed by Simon Fraser.
2549
2550         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2551         not support swapping to the discrete GPU in this configuration.
2552
2553         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2554         (WebKit::WebSwitchingGPUClient::singleton):
2555         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2556         * WebView/WebView.mm:
2557         (-[WebView _commonInitializationWithFrameName:groupName:]):
2558
2559 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2560
2561         Remove ParsedURLString
2562         https://bugs.webkit.org/show_bug.cgi?id=190154
2563
2564         Reviewed by Chris Dumez.
2565
2566         * WebView/WebScriptDebugger.mm:
2567         (toNSURL):
2568
2569 2018-10-01  Dean Jackson  <dino@apple.com>
2570
2571         Remove CSS Animation Triggers
2572         https://bugs.webkit.org/show_bug.cgi?id=190175
2573         <rdar://problem/44925626>
2574
2575         Reviewed by Simon Fraser.
2576
2577         * Configurations/FeatureDefines.xcconfig:
2578
2579 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2580
2581         Unreviewed, rolling out r236624 and r236671.
2582         https://bugs.webkit.org/show_bug.cgi?id=190207
2583
2584         The change in r236624 introduced crashes on the bots
2585         (Requested by ryanhaddad on #webkit).
2586
2587         Reverted changesets:
2588
2589         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2590         https://bugs.webkit.org/show_bug.cgi?id=188747
2591         https://trac.webkit.org/changeset/236624
2592
2593         "Unify implementation in VideoFullscreenInterfaceAVKit"
2594         https://bugs.webkit.org/show_bug.cgi?id=190091
2595         https://trac.webkit.org/changeset/236671
2596
2597 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2598
2599         URL should not use TextEncoding internally
2600         https://bugs.webkit.org/show_bug.cgi?id=190111
2601
2602         Reviewed by Andy Estes.
2603
2604         * Misc/WebNSURLExtras.mm:
2605
2606 2018-09-28  Jer Noble  <jer.noble@apple.com>
2607
2608         Refactoring: eliminate raw pointer usage in Fullscreen code
2609         https://bugs.webkit.org/show_bug.cgi?id=188747
2610         <rdar://problem/43541164>
2611
2612         Reviewed by Alex Christensen.
2613
2614         PlaybackSessionInterface no longer has an invalidate() method.
2615
2616         * WebView/WebView.mm:
2617         (-[WebView _clearPlaybackControlsManager]):
2618
2619 2018-09-28  Chris Dumez  <cdumez@apple.com>
2620
2621         Drop support for cross-origin-window-policy header
2622         https://bugs.webkit.org/show_bug.cgi?id=190081
2623
2624         Reviewed by Ryosuke Niwa.
2625
2626         * WebView/WebPreferenceKeysPrivate.h:
2627         * WebView/WebPreferences.mm:
2628         (+[WebPreferences initialize]):
2629         * WebView/WebPreferencesPrivate.h:
2630         * WebView/WebView.mm:
2631         (-[WebView _preferencesChanged:]):
2632
2633 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2634
2635         Rename createMarkup to serializePreservingVisualAppearance
2636         https://bugs.webkit.org/show_bug.cgi?id=190086
2637
2638         Reviewed by Wenson Hsieh.
2639
2640         * DOM/WebDOMOperations.mm:
2641         (-[DOMRange markupString]):
2642
2643 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2644
2645         Unreviewed, rolling out r236605.
2646         https://bugs.webkit.org/show_bug.cgi?id=190087
2647
2648         caused three API test timeouts (Requested by jernoble on
2649         #webkit).
2650
2651         Reverted changeset:
2652
2653         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2654         https://bugs.webkit.org/show_bug.cgi?id=188747
2655         https://trac.webkit.org/changeset/236605
2656
2657 2018-09-28  Jer Noble  <jer.noble@apple.com>
2658
2659         Refactoring: eliminate raw pointer usage in Fullscreen code
2660         https://bugs.webkit.org/show_bug.cgi?id=188747
2661         <rdar://problem/43541164>
2662
2663         Reviewed by Alex Christensen.
2664
2665         PlaybackSessionInterface no longer has an invalidate() method.
2666
2667         * WebView/WebView.mm:
2668         (-[WebView _clearPlaybackControlsManager]):
2669
2670 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2671
2672         Use enum class in createMarkup arguments
2673         https://bugs.webkit.org/show_bug.cgi?id=190028
2674
2675         Reviewed by Wenson Hsieh.
2676
2677         * DOM/WebDOMOperations.mm:
2678         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2679         (-[DOMRange markupString]): Ditto.
2680
2681 2018-09-27  Antoine Quint  <graouts@apple.com>
2682
2683         [Web Animations] Turn Web Animations with CSS integration on
2684         https://bugs.webkit.org/show_bug.cgi?id=184819
2685         <rdar://problem/39597337>
2686
2687         Reviewed by Dean Jackson.
2688
2689         * WebView/WebPreferences.mm:
2690         (+[WebPreferences initialize]):
2691
2692 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2693
2694         Selection should work across shadow boundary when initiated by a mouse drag
2695         https://bugs.webkit.org/show_bug.cgi?id=151380
2696         <rdar://problem/24363872>
2697
2698         Reviewed by Wenson Hsieh.
2699
2700         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2701
2702         * WebView/WebPreferenceKeysPrivate.h:
2703         * WebView/WebPreferences.mm:
2704         (+[WebPreferences initialize]):
2705         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2706         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2707         * WebView/WebPreferencesPrivate.h:
2708         * WebView/WebView.mm:
2709         (-[WebView _preferencesChanged:]):
2710
2711 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2712
2713         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2714         https://bugs.webkit.org/show_bug.cgi?id=189918
2715         Work towards <rdar://problem/44648705>
2716
2717         Reviewed by Tim Horton.
2718
2719         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2720
2721         * WebView/WebHTMLView.mm:
2722         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2723         (-[WebHTMLView _updateFontPanel]):
2724         * WebView/WebView.mm:
2725         (-[WebView typingAttributes]):
2726
2727 2018-09-17  Darin Adler  <darin@apple.com>
2728
2729         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2730         https://bugs.webkit.org/show_bug.cgi?id=189652
2731
2732         Reviewed by Saam Barati.
2733
2734         * WebView/WebPDFRepresentation.mm:
2735         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2736
2737 2018-09-14  Jer Noble  <jer.noble@apple.com>
2738
2739         Turn SourceBufferChangeTypeEnabled on by default
2740         https://bugs.webkit.org/show_bug.cgi?id=189527
2741
2742         Reviewed by Eric Carlson.
2743
2744         * WebView/WebPreferences.mm:
2745         (+[WebPreferences initialize]):
2746
2747 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2748
2749         Fix an internal build after r235935
2750         https://bugs.webkit.org/show_bug.cgi?id=188996
2751
2752         * Carbon/HIWebView.mm:
2753         (Draw):
2754         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2755
2756 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2757
2758         Add IGNORE_WARNING_.* macros
2759         https://bugs.webkit.org/show_bug.cgi?id=188996
2760
2761         Reviewed by Michael Catanzaro.
2762
2763         * Carbon/CarbonUtils.m:
2764         (PoolCleaner):
2765         * Carbon/CarbonWindowAdapter.mm:
2766         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2767         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2768         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2769         (-[CarbonWindowAdapter _termWindowIfOwner]):
2770         (-[CarbonWindowAdapter _windowMovedToRect:]):
2771         (-[CarbonWindowAdapter setContentView:]):
2772         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2773         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2774         * Carbon/CarbonWindowFrame.m:
2775         (-[CarbonWindowFrame title]):
2776         * Carbon/HIViewAdapter.m:
2777         (+[HIViewAdapter getHIViewForNSView:]):
2778         * Carbon/HIWebView.mm:
2779         (overrideCGContext):
2780         (restoreCGContext):
2781         (Draw):
2782         * DOM/DOM.mm:
2783         * History/WebHistory.mm:
2784         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2785         * History/WebHistoryItem.mm:
2786         (-[WebHistoryItem icon]):
2787         * Misc/WebKitNSStringExtras.mm:
2788         (-[NSString _web_drawAtPoint:font:textColor:]):
2789         * Misc/WebNSImageExtras.m:
2790         (-[NSImage _web_scaleToMaxSize:]):
2791         (-[NSImage _web_dissolveToFraction:]):
2792         * Misc/WebNSPasteboardExtras.mm:
2793         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2794         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2795         * Panels/WebAuthenticationPanel.m:
2796         (-[WebAuthenticationPanel loadNib]):
2797         * Plugins/Hosted/NetscapePluginHostManager.mm:
2798         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2799         (WebKit::NetscapePluginHostManager::didCreateWindow):
2800         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2801         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2802         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2803         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2804         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2805         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2806         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2807         (-[WebHostedNetscapePluginView drawRect:]):
2808         * Plugins/Hosted/WebTextInputWindowController.m:
2809         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2810         * Plugins/WebBaseNetscapePluginView.mm:
2811         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2812         * Plugins/WebNetscapePluginPackage.mm:
2813         (-[WebNetscapePluginPackage _tryLoad]):
2814         * Plugins/WebNetscapePluginView.mm:
2815         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2816         (-[WebNetscapePluginView sendDrawRectEvent:]):
2817         (-[WebNetscapePluginView drawRect:]):
2818         * Plugins/WebPluginController.mm:
2819         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2820         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2821         * WebCoreSupport/PopupMenuMac.mm:
2822         (PopupMenuMac::populate):
2823         * WebCoreSupport/WebAlternativeTextClient.h:
2824         * WebCoreSupport/WebDragClient.mm:
2825         (WebDragClient::startDrag):
2826         * WebCoreSupport/WebFrameLoaderClient.mm:
2827         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2828         (webGetNSImage):
2829         * WebInspector/WebNodeHighlight.mm:
2830         * WebInspector/WebNodeHighlightView.mm:
2831         (-[WebNodeHighlightView drawRect:]):
2832         * WebView/WebClipView.mm:
2833         (-[WebClipView initWithFrame:]):
2834         * WebView/WebFrame.mm:
2835         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2836         (-[WebFrame _drawRect:contentsOnly:]):
2837         (-[WebFrame accessibilityRoot]):
2838         * WebView/WebFullScreenController.mm:
2839         (-[WebFullScreenController enterFullScreen:]):
2840         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2841         (-[WebFullScreenController exitFullScreen]):
2842         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2843         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2844         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2845         * WebView/WebHTMLView.mm:
2846         (-[NSWindow _web_borderView]):
2847         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2848         (-[WebHTMLView _setAsideSubviews]):
2849         (-[WebHTMLView _autoscroll]):
2850         (-[WebHTMLView drawRect:]):
2851         (-[WebHTMLView mouseDown:]):
2852         (-[WebHTMLView mouseDragged:]):
2853         (-[WebHTMLView mouseUp:]):
2854         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2855         (-[WebHTMLView knowsPageRange:]):
2856         (-[WebHTMLView accessibilityHitTest:]):
2857         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2858         (-[WebHTMLView _colorAsString:]):
2859         (-[WebHTMLView copyFont:]):
2860         (-[WebHTMLView _executeSavedKeypressCommands]):
2861         (-[WebHTMLView attachRootLayer:]):
2862         (-[WebHTMLView textStorage]):
2863         (-[WebHTMLView _updateSelectionForInputManager]):
2864         * WebView/WebPDFView.mm:
2865         (_applicationInfoForMIMEType):
2866         (-[WebPDFView centerSelectionInVisibleArea:]):
2867         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2868         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2869         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2870         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2871         * WebView/WebTextCompletionController.mm:
2872         (-[WebTextCompletionController _buildUI]):
2873         (-[WebTextCompletionController _placePopupWindow:]):
2874         * WebView/WebVideoFullscreenController.mm:
2875         * WebView/WebVideoFullscreenHUDWindowController.mm:
2876         (createMediaUIBackgroundView):
2877         * WebView/WebView.mm:
2878         (-[WebTextListTouchBarViewController initWithWebView:]):
2879         (-[WebView _dispatchTileDidDraw:]):
2880         (-[WebView encodeWithCoder:]):
2881         (-[WebView mainFrameIcon]):
2882         (LayerFlushController::flushLayers):
2883         * WebView/WebWindowAnimation.mm:
2884         (setScaledFrameForWindow):
2885
2886 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2887
2888         Remove unused needsDestruction class variables from HashTraits
2889         https://bugs.webkit.org/show_bug.cgi?id=189490
2890
2891         Reviewed by Daniel Bates.
2892
2893         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2894
2895 2018-09-07  Frederic Wang  <fwang@igalia.com>
2896
2897         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2898         https://bugs.webkit.org/show_bug.cgi?id=182230
2899
2900         Reviewed by Simon Fraser.
2901
2902         * DOM/DOMDocument.mm:
2903         (-[DOMDocument scrollingElement]): Use the new name.
2904
2905 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2906
2907         Refactor WebCore::EditAction to be an 8-bit enum class
2908         https://bugs.webkit.org/show_bug.cgi?id=189383
2909
2910         Reviewed by Dan Bernstein.
2911
2912         * WebCoreSupport/WebEditorClient.mm:
2913         (undoNameForEditAction):
2914         * WebView/WebHTMLView.mm:
2915         (-[WebHTMLView pasteFont:]):
2916         (-[WebHTMLView changeFont:]):
2917         (-[WebHTMLView changeAttributes:]):
2918         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2919         (-[WebHTMLView changeColor:]):
2920         * WebView/WebView.mm:
2921         (-[WebView setTypingStyle:]):
2922
2923 2018-09-06  Frederic Wang  <fwang@igalia.com>
2924
2925         Group options of scrollRectToVisible into a struct
2926         https://bugs.webkit.org/show_bug.cgi?id=189352
2927
2928         Reviewed by Simon Fraser.
2929
2930         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2931         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2932         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2933
2934 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2935
2936         [macOS] Cannot change font size at selection until font panel is shown
2937         https://bugs.webkit.org/show_bug.cgi?id=189295
2938         <rdar://problem/35593389>
2939
2940         Reviewed by Ryosuke Niwa.
2941
2942         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2943         WebCore ChangeLog for more details.
2944
2945         * WebView/WebHTMLView.mm:
2946         (-[WebHTMLView changeFont:]):
2947         (-[WebHTMLView changeAttributes:]):
2948         (-[WebHTMLView _originalFontA]): Deleted.
2949         (-[WebHTMLView _originalFontB]): Deleted.
2950         (fontNameForDescription): Deleted.
2951         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2952         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2953         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2954
2955 2018-09-05  Jer Noble  <jer.noble@apple.com>
2956
2957         Add MediaCapabilities as an Experimental Feature
2958         https://bugs.webkit.org/show_bug.cgi?id=189209
2959
2960         Reviewed by Eric Carlson.
2961
2962         RuntimeEnabledFeature -> Setting.
2963
2964         * WebView/WebView.mm:
2965         (-[WebView _preferencesChanged:]):
2966
2967 2018-09-04  Frederic Wang  <fwang@igalia.com>
2968
2969         Add basic support for ScrollIntoViewOptions
2970         https://bugs.webkit.org/show_bug.cgi?id=189258
2971
2972         Reviewed by Simon Fraser.
2973
2974         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2975         header so that this file can build despite the new scrollIntoView function.
2976
2977 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2978
2979         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2980         https://bugs.webkit.org/show_bug.cgi?id=188890
2981         <rdar://problem/43648605>
2982
2983         Reviewed by Tim Horton.
2984
2985         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
2986         more detail.
2987
2988         * WebCoreSupport/WebPlatformStrategies.h:
2989         * WebCoreSupport/WebPlatformStrategies.mm:
2990         (WebPlatformStrategies::allStringsForType):
2991
2992 2018-09-01  Darin Adler  <darin@apple.com>
2993
2994         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2995         https://bugs.webkit.org/show_bug.cgi?id=189072
2996         Reviewed by Dan Bernstein.
2997
2998         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
2999         and declarations for NSURLDownload init methods.
3000
3001         * Misc/WebDownloadInternal.h: Removed.
3002
3003         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3004         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3005         "-Wdeprecated-declarations" because the method used here is deprecated.
3006
3007         * WebView/WebView.mm:
3008         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3009         used here is deprecated.
3010
3011 2018-08-31  Chris Dumez  <cdumez@apple.com>
3012
3013         Assertion hit in ~CompletionHandler() from ~WebFrame()
3014         https://bugs.webkit.org/show_bug.cgi?id=189199
3015         <rdar://problem/42657233>
3016
3017         Reviewed by Youenn Fablet.
3018
3019         * WebCoreSupport/WebFrameLoaderClient.h:
3020         * WebCoreSupport/WebFrameLoaderClient.mm:
3021         (WebFrameLoaderClient::dispatchWillSubmitForm):
3022
3023 2018-08-31  Antti Koivisto  <antti@apple.com>
3024
3025         Replace OptionSet |= and -= operators with add() and remove() functions
3026         https://bugs.webkit.org/show_bug.cgi?id=189169
3027
3028         Reviewed by Anders Carlsson.
3029
3030         * WebView/WebFrame.mm:
3031         (-[WebFrame _drawRect:contentsOnly:]):
3032         * WebView/WebView.mm:
3033         (coreOptions):
3034
3035 2018-08-31  Frederic Wang  <fwang@igalia.com>
3036
3037         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3038         https://bugs.webkit.org/show_bug.cgi?id=182053
3039
3040         Reviewed by Simon Fraser.
3041
3042         Add developer flag to use standard behavior for scrolling* attributes.
3043
3044         * WebView/WebPreferenceKeysPrivate.h:
3045         * WebView/WebPreferences.mm:
3046         (+[WebPreferences initialize]):
3047         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3048         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3049         * WebView/WebPreferencesPrivate.h:
3050         * WebView/WebView.mm:
3051         (-[WebView _preferencesChanged:]):
3052
3053 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3054
3055         Implement the Web Share API
3056         https://bugs.webkit.org/show_bug.cgi?id=171100
3057         <rdar://problem/31751734>
3058
3059         Reviewed by Tim Horton.
3060
3061         * WebCoreSupport/WebChromeClient.h:
3062         * WebCoreSupport/WebChromeClient.mm:
3063         (WebChromeClient::showShareSheet):
3064         Empty declaration of showShareSheet.
3065
3066 2018-08-29  Youenn Fablet  <youenn@apple.com>
3067
3068         Remove WebRTC legacy API implementation
3069         https://bugs.webkit.org/show_bug.cgi?id=189040
3070
3071         Reviewed by Eric Carlson.
3072
3073         * WebView/WebPreferenceKeysPrivate.h:
3074         * WebView/WebPreferences.mm:
3075         (+[WebPreferences initialize]):
3076         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3077         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3078         * WebView/WebPreferencesPrivate.h:
3079         * WebView/WebView.mm:
3080         (-[WebView _preferencesChanged:]):
3081
3082 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3083
3084         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3085         https://bugs.webkit.org/show_bug.cgi?id=189054
3086
3087         Reviewed by Andy Estes.
3088
3089         Remove the pasteboard type argument from readURLFromPasteboard.
3090
3091         * WebCoreSupport/WebPlatformStrategies.h:
3092         * WebCoreSupport/WebPlatformStrategies.mm:
3093         (WebPlatformStrategies::readURLFromPasteboard):
3094
3095 2018-08-27  Keith Rollin  <krollin@apple.com>
3096
3097         Unreviewed build fix -- disable LTO for production builds
3098
3099         * Configurations/Base.xcconfig:
3100
3101 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3102
3103         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3104         https://bugs.webkit.org/show_bug.cgi?id=188931
3105
3106         Reviewed by Wenson Hsieh.
3107
3108         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3109
3110 2018-08-27  Keith Rollin  <krollin@apple.com>
3111
3112         Build system support for LTO
3113         https://bugs.webkit.org/show_bug.cgi?id=187785
3114         <rdar://problem/42353132>
3115
3116         Reviewed by Dan Bernstein.
3117
3118         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3119         LTO.
3120
3121         * Configurations/Base.xcconfig:
3122         * Configurations/DebugRelease.xcconfig:
3123
3124 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3125
3126         Pass in IsComposed flag to Event constructors
3127         https://bugs.webkit.org/show_bug.cgi?id=188720
3128         <rdar://problem/43580387>
3129
3130         Reviewed by Simon Fraser.
3131
3132         * WebView/WebPDFView.mm:
3133         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3134         whether it's simulated or not.
3135
3136 2018-08-23  Mark Lam  <mark.lam@apple.com>
3137
3138         Move vmEntryGlobalObject() to VM from CallFrame.
3139         https://bugs.webkit.org/show_bug.cgi?id=188900
3140         <rdar://problem/43655753>
3141
3142         Reviewed by Michael Saboff.
3143
3144         * WebView/WebScriptDebugger.mm:
3145         (WebScriptDebugger::sourceParsed):
3146
3147 2018-08-23  Andy Estes  <aestes@apple.com>
3148
3149         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3150         https://bugs.webkit.org/show_bug.cgi?id=188829
3151
3152         Reviewed by Tim Horton.
3153
3154         * Configurations/FeatureDefines.xcconfig:
3155
3156 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3157
3158         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3159         https://bugs.webkit.org/show_bug.cgi?id=188777
3160
3161         Reviewed by Simon Fraser.
3162
3163         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3164         being "true" before the code change.
3165
3166         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3167
3168         * WebView/WebPDFView.mm:
3169         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3170
3171 2018-08-21  Daniel Bates  <dabates@apple.com>
3172
3173         Replace TextCheckingTypeMask with OptionSet
3174         https://bugs.webkit.org/show_bug.cgi?id=188678
3175
3176         Reviewed by Antti Koivisto.
3177
3178         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3179         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3180         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3181         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3182
3183         * WebCoreSupport/WebEditorClient.h:
3184         * WebCoreSupport/WebEditorClient.mm:
3185         (WebEditorClient::checkTextOfParagraph):
3186         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3187         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3188         left as this is more readable and unncessary now that modern compilers like Clang have
3189         diagnostics to catch accidental assignments when equality was intended.
3190         (WebEditorClient::didCheckSucceed):
3191         * WebView/WebView.mm:
3192         (coreTextCheckingType):
3193         (textCheckingResultFromNSTextCheckingResult):
3194
3195 2018-08-21  Daniel Bates  <dabates@apple.com>
3196
3197         [iOS][WK1] Support toggling continuous spell checking from tests
3198         https://bugs.webkit.org/show_bug.cgi?id=188763
3199
3200         Reviewed by Simon Fraser.
3201
3202         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3203         spell checking from tests in iOS WebKit Legacy.
3204
3205         * WebCoreSupport/WebEditorClient.h:
3206         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3207         * WebCoreSupport/WebEditorClient.mm:
3208         * WebView/WebView.h:
3209         * WebView/WebView.mm:
3210         (-[WebView toggleContinuousSpellChecking:]):
3211         (-[WebView toggleSmartInsertDelete:]):
3212
3213 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3214
3215         Add some plumbing for safe browsing
3216         https://bugs.webkit.org/show_bug.cgi?id=188709
3217
3218         Reviewed by Tim Horton.
3219
3220         * WebCoreSupport/WebFrameLoaderClient.h:
3221         * WebCoreSupport/WebFrameLoaderClient.mm:
3222         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3223
3224 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3225
3226         Replace canBubble and cancelable booleans in Event by enum classes
3227         https://bugs.webkit.org/show_bug.cgi?id=188692
3228
3229         Reviewed by Alex Christensen.
3230
3231         * WebView/WebPDFView.mm:
3232         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3233         * WebView/WebView.mm:
3234         (-[WebView _dispatchUnloadEvent]):
3235
3236 2018-08-16  Jer Noble  <jer.noble@apple.com>
3237
3238         Add Experimental Feature support for SourceBuffer.changeType()
3239         https://bugs.webkit.org/show_bug.cgi?id=188626
3240         <rdar://problem/43356021>
3241
3242         Reviewed by Eric Carlson.
3243
3244         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3245
3246         * WebView/WebPreferenceKeysPrivate.h:
3247         * WebView/WebPreferences.mm:
3248         (+[WebPreferences initialize]):
3249         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3250         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3251         * WebView/WebPreferencesPrivate.h:
3252         * WebView/WebView.mm:
3253         (-[WebView _preferencesChanged:]):
3254
3255 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3256
3257         Support drag-and-drop for input[type=color]
3258         https://bugs.webkit.org/show_bug.cgi?id=188464
3259
3260         Reviewed by Wenson Hsieh.
3261
3262         * WebCoreSupport/WebPlatformStrategies.h:
3263         * WebCoreSupport/WebPlatformStrategies.mm:
3264         (WebPlatformStrategies::setColor):
3265
3266 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3267
3268         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3269         https://bugs.webkit.org/show_bug.cgi?id=188569
3270         <rdar://problem/34201095>
3271
3272         Reviewed by Megan Gardner.
3273
3274         * WebView/WebImmediateActionController.mm:
3275         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3276         Speculative fix; the crashes indicate font is null, but we just checked it,
3277         so it must be getting made null by convertFont:toSize:. Check again!
3278
3279 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3280
3281         Use a 1-byte enum class for TextDirection
3282         https://bugs.webkit.org/show_bug.cgi?id=188350
3283
3284         Reviewed by Simon Fraser.
3285
3286         * WebCoreSupport/PopupMenuMac.mm:
3287         (PopupMenuMac::populate):
3288         (PopupMenuMac::show):
3289         * WebCoreSupport/WebFrameLoaderClient.mm:
3290         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3291         * WebView/WebFrame.mm:
3292         (-[WebFrame _dispatchDidReceiveTitle:]):
3293
3294 2018-08-09  Ali Juma  <ajuma@chromium.org>
3295
3296         Import WPTs for IntersectionObserver
3297         https://bugs.webkit.org/show_bug.cgi?id=188416
3298
3299         Reviewed by Simon Fraser.
3300
3301         * WebView/WebPreferencesPrivate.h:
3302
3303 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3304
3305         Follow-up build fix for r234685
3306         https://bugs.webkit.org/show_bug.cgi?id=188245
3307
3308         Unreviewed build fix.
3309
3310         * WebCoreSupport/WebSecurityOriginPrivate.h:
3311
3312 2018-08-05  Darin Adler  <darin@apple.com>
3313
3314         [Cocoa] More tweaks and refactoring to prepare for ARC
3315         https://bugs.webkit.org/show_bug.cgi?id=188245
3316
3317         Reviewed by Dan Bernstein.
3318
3319         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3320
3321         * Carbon/CarbonWindowFrame.m:
3322         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3323
3324         * DOM/DOM.mm:
3325         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3326         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3327         garbage collection so this method isn't useful.
3328
3329         * DOM/DOMXPath.mm:
3330         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3331         Objective-C garbage collection so this method isn't useful.
3332
3333         * History/WebHistory.mm:
3334         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3335
3336         * Misc/WebElementDictionary.mm:
3337         (addLookupKey): Use a bridging cast.
3338         (cacheValueForKey): Ditto.
3339         (-[WebElementDictionary _fillCache]): Ditto.
3340         (-[WebElementDictionary objectForKey:]): Ditto.
3341
3342         * Misc/WebKitNSStringExtras.mm:
3343         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3344         (-[NSString _web_widthWithFont:]): Ditto.
3345         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3346
3347         * Misc/WebLocalizableStrings.mm:
3348         (WebLocalizedString): Use a bridging cast.
3349
3350         * Misc/WebNSDataExtras.mm:
3351         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3352         and use CFBridgingRelease instead of calling autorelease directly.
3353         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3354         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3355         on the amount of explicit release and autorelease.
3356
3357         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3358         * Misc/WebNSDictionaryExtras.m:
3359         (-[NSDictionary _webkit_intForKey:]): Deleted.
3360         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3361         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3362         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3363         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3364         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3365         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3366
3367         * Misc/WebStringTruncator.mm:
3368         (fontFromNSFont): Use a bridging cast.
3369
3370         * Plugins/Hosted/NetscapePluginHostManager.mm:
3371         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3372
3373         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3374         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3375         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3376         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3377         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3378         * Plugins/Hosted/ProxyInstance.mm:
3379         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3380         * Plugins/WebBasePluginPackage.mm:
3381         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3382         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3383         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3384         * Plugins/WebNetscapePluginPackage.mm:
3385         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3386
3387         * Plugins/WebNetscapePluginView.mm:
3388         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3389         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3390         (-[WebNetscapePluginView status:]): Use a bridging cast.
3391         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3392
3393         * Plugins/WebPluginController.mm:
3394         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3395
3396         * Plugins/WebPluginDatabase.mm:
3397         (checkCandidate): Use explicit __strong for out argument types.
3398
3399         * Plugins/npapi.mm:
3400         (pluginViewForInstance): Use a bridging cast.
3401
3402         * Storage/WebDatabaseManager.mm:
3403         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3404         explicit NSNumber and NSDictionary calls.
3405
3406         * WebCoreSupport/WebContextMenuClient.mm:
3407         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3408
3409         * WebCoreSupport/WebEditorClient.mm:
3410         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3411         (WebEditorClient::handleInputMethodKeydown): Ditto.
3412
3413         * WebCoreSupport/WebFrameNetworkingContext.mm:
3414         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3415
3416         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3417         as a struct rather than an Objective-C class, since that's how it's defined.
3418
3419         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3420
3421         * WebView/WebFullScreenController.mm:
3422         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3423         * WebView/WebHTMLView.mm:
3424         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3425         Ditto.
3426         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3427
3428         * WebView/WebImmediateActionController.mm:
3429         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3430         go down to the document and then back to the frame.
3431         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3432         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3433         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3434
3435         * WebView/WebJSPDFDoc.mm:
3436         (jsPDFDocInitialize): Removed some unneeded type casting.
3437         (jsPDFDocFinalize): Ditto.
3438         (jsPDFDocPrint): Use a bridging cast.
3439
3440         * WebView/WebPDFView.mm:
3441         (_applicationInfoForMIMEType): Use bridging casts.
3442
3443         * WebView/WebPreferences.mm:
3444         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3445         instead of methods from WebNSDictionaryExtras.
3446         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3447         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3448         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3449         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3450         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3451
3452         * WebView/WebView.mm:
3453         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3454         (-[WebView _addToAllWebViewsSet]): Ditto.
3455         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3456         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3457         so it can be called from WebViewData methods.
3458
3459         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3460         method, _windowVisibilityChanged:.
3461
3462         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3463         called from WebViewData methods.
3464
3465 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3466
3467         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3468         https://bugs.webkit.org/show_bug.cgi?id=188323
3469
3470         Reviewed by Simon Fraser.
3471
3472         * WebCoreSupport/WebContextMenuClient.mm:
3473         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3474         * WebView/WebFrame.mm:
3475         (-[WebFrame _paintBehaviorForDestinationContext:]):
3476         (-[WebFrame _drawRect:contentsOnly:]):
3477         * WebView/WebHTMLView.mm:
3478         (imageFromRect):
3479         (selectionImage):
3480
3481 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3482
3483         Add support for microtasks in workers
3484         https://bugs.webkit.org/show_bug.cgi?id=188246
3485
3486         Reviewed by Darin Adler.
3487
3488         Rename JSMainThreadExecState.h to JSExecState.h.
3489
3490         * DOM/DOMAttr.mm:
3491         * DOM/DOMBlob.mm:
3492         * DOM/DOMCDATASection.mm:
3493         * DOM/DOMCSSCharsetRule.mm:
3494         * DOM/DOMCSSFontFaceRule.mm:
3495         * DOM/DOMCSSImportRule.mm:
3496         * DOM/DOMCSSMediaRule.mm:
3497         * DOM/DOMCSSPageRule.mm:
3498         * DOM/DOMCSSPrimitiveValue.mm:
3499         * DOM/DOMCSSRule.mm:
3500         * DOM/DOMCSSRuleList.mm:
3501         * DOM/DOMCSSStyleDeclaration.mm:
3502         * DOM/DOMCSSStyleRule.mm:
3503         * DOM/DOMCSSStyleSheet.mm:
3504         * DOM/DOMCSSUnknownRule.mm:
3505         * DOM/DOMCSSValue.mm:
3506         * DOM/DOMCSSValueList.mm:
3507         * DOM/DOMCharacterData.mm:
3508         * DOM/DOMComment.mm:
3509         * DOM/DOMCounter.mm:
3510         * DOM/DOMDocument.mm:
3511         * DOM/DOMDocumentFragment.mm:
3512         * DOM/DOMDocumentType.mm:
3513         * DOM/DOMElement.mm:
3514         * DOM/DOMEvent.mm:
3515         * DOM/DOMFile.mm:
3516         * DOM/DOMFileList.mm:
3517         * DOM/DOMHTML.mm:
3518         * DOM/DOMHTMLAnchorElement.mm:
3519         * DOM/DOMHTMLAppletElement.mm:
3520         * DOM/DOMHTMLAreaElement.mm:
3521         * DOM/DOMHTMLBRElement.mm:
3522         * DOM/DOMHTMLBaseElement.mm:
3523         * DOM/DOMHTMLBaseFontElement.mm:
3524         * DOM/DOMHTMLBodyElement.mm:
3525         * DOM/DOMHTMLButtonElement.mm:
3526         * DOM/DOMHTMLCanvasElement.mm:
3527         * DOM/DOMHTMLCollection.mm:
3528         * DOM/DOMHTMLDListElement.mm:
3529         * DOM/DOMHTMLDirectoryElement.mm:
3530         * DOM/DOMHTMLDivElement.mm:
3531         * DOM/DOMHTMLDocument.mm:
3532         * DOM/DOMHTMLElement.mm:
3533         * DOM/DOMHTMLEmbedElement.mm:
3534         * DOM/DOMHTMLFieldSetElement.mm:
3535         * DOM/DOMHTMLFontElement.mm:
3536         * DOM/DOMHTMLFormElement.mm:
3537         * DOM/DOMHTMLFrameElement.mm:
3538         * DOM/DOMHTMLFrameSetElement.mm:
3539         * DOM/DOMHTMLHRElement.mm:
3540         * DOM/DOMHTMLHeadElement.mm:
3541         * DOM/DOMHTMLHeadingElement.mm:
3542         * DOM/DOMHTMLHtmlElement.mm:
3543         * DOM/DOMHTMLIFrameElement.mm:
3544         * DOM/DOMHTMLImageElement.mm:
3545         * DOM/DOMHTMLInputElement.mm:
3546         * DOM/DOMHTMLLIElement.mm:
3547         * DOM/DOMHTMLLabelElement.mm:
3548         * DOM/DOMHTMLLegendElement.mm:
3549         * DOM/DOMHTMLLinkElement.mm:
3550         * DOM/DOMHTMLMapElement.mm:
3551         * DOM/DOMHTMLMarqueeElement.mm:
3552         * DOM/DOMHTMLMediaElement.mm:
3553         * DOM/DOMHTMLMenuElement.mm:
3554         * DOM/DOMHTMLMetaElement.mm:
3555         * DOM/DOMHTMLModElement.mm:
3556         * DOM/DOMHTMLOListElement.mm:
3557         * DOM/DOMHTMLObjectElement.mm:
3558         * DOM/DOMHTMLOptGroupElement.mm:
3559         * DOM/DOMHTMLOptionElement.mm:
3560         * DOM/DOMHTMLOptionsCollection.mm:
3561         * DOM/DOMHTMLParagraphElement.mm:
3562         * DOM/DOMHTMLParamElement.mm:
3563         * DOM/DOMHTMLPreElement.mm:
3564         * DOM/DOMHTMLQuoteElement.mm:
3565         * DOM/DOMHTMLScriptElement.mm:
3566         * DOM/DOMHTMLSelectElement.mm:
3567         * DOM/DOMHTMLStyleElement.mm:
3568         * DOM/DOMHTMLTableCaptionElement.mm:
3569         * DOM/DOMHTMLTableCellElement.mm:
3570         * DOM/DOMHTMLTableColElement.mm:
3571         * DOM/DOMHTMLTableElement.mm:
3572         * DOM/DOMHTMLTableRowElement.mm:
3573         * DOM/DOMHTMLTableSectionElement.mm:
3574         * DOM/DOMHTMLTextAreaElement.mm:
3575         * DOM/DOMHTMLTitleElement.mm:
3576         * DOM/DOMHTMLUListElement.mm:
3577         * DOM/DOMHTMLVideoElement.mm:
3578         * DOM/DOMImplementation.mm:
3579         * DOM/DOMKeyboardEvent.mm:
3580         * DOM/DOMMediaError.mm:
3581         * DOM/DOMMediaList.mm:
3582         * DOM/DOMMouseEvent.mm:
3583         * DOM/DOMMutationEvent.mm:
3584         * DOM/DOMNamedNodeMap.mm:
3585         * DOM/DOMNode.mm:
3586         * DOM/DOMNodeIterator.mm:
3587         * DOM/DOMNodeList.mm:
3588         * DOM/DOMOverflowEvent.mm:
3589         * DOM/DOMProcessingInstruction.mm:
3590         * DOM/DOMProgressEvent.mm:
3591         * DOM/DOMRGBColor.mm:
3592         * DOM/DOMRange.mm:
3593         * DOM/DOMRect.mm:
3594         * DOM/DOMStyleSheet.mm:
3595         * DOM/DOMStyleSheetList.mm:
3596         * DOM/DOMText.mm:
3597         * DOM/DOMTextEvent.mm:
3598         * DOM/DOMTimeRanges.mm:
3599         * DOM/DOMTokenList.mm:
3600         * DOM/DOMTreeWalker.mm:
3601         * DOM/DOMUIEvent.mm:
3602         * DOM/DOMWheelEvent.mm:
3603         * DOM/DOMXPathExpression.mm:
3604         * DOM/DOMXPathResult.mm:
3605         * DOM/ObjCEventListener.mm:
3606
3607 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3608
3609         Fix spelling of "overridden"
3610         https://bugs.webkit.org/show_bug.cgi?id=188315
3611
3612         Reviewed by Darin Adler.
3613
3614         * Misc/WebKitVersionChecks.mm:
3615         (setWebKitLinkTimeVersion):
3616         (WebKitLinkTimeVersion):
3617         * Plugins/WebBaseNetscapePluginView.mm:
3618         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3619         * WebCoreSupport/PopupMenuMac.mm:
3620         (PopupMenuMac::populate):
3621
3622 2018-08-01  Nan Wang  <n_wang@apple.com>
3623
3624         AX: AOM: Add ARIA IDL Attribute Reflection
3625         https://bugs.webkit.org/show_bug.cgi?id=184676
3626         <rdar://problem/39476882>
3627
3628         Reviewed by Chris Fleizach.
3629
3630         * WebView/WebPreferenceKeysPrivate.h:
3631         * WebView/WebPreferences.mm:
3632         (+[WebPreferences initialize]):
3633         (-[WebPreferences ariaReflectionEnabled]):
3634         (-[WebPreferences setAriaReflectionEnabled:]):
3635         * WebView/WebPreferencesPrivate.h:
3636         * WebView/WebView.mm:
3637         (-[WebView _preferencesChanged:]):
3638
3639 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3640
3641         Shrink GraphicsLayerCA
3642         https://bugs.webkit.org/show_bug.cgi?id=188141
3643
3644         Reviewed by Zalan Bujtas.
3645
3646         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3647         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3648         * moving all the animation-related stuff into the lazily-allocated m_animations
3649         * making enums be 8-bit
3650         * re-ordering data members
3651
3652         * WebView/WebView.mm:
3653         (-[WebView _setMediaLayer:forPluginView:]):
3654
3655 2018-07-30  Rob Buis  <rbuis@igalia.com>
3656
3657         Merge PlatformCookieJar functions into NetworkStorageSession
3658         https://bugs.webkit.org/show_bug.cgi?id=188137
3659
3660         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3661
3662         Reviewed by Alex Christensen.
3663
3664         * WebCoreSupport/WebPlatformStrategies.mm:
3665         (WebPlatformStrategies::cookiesForDOM):
3666         (WebPlatformStrategies::setCookiesFromDOM):
3667         (WebPlatformStrategies::cookiesEnabled):
3668         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3669         (WebPlatformStrategies::getRawCookies):
3670         (WebPlatformStrategies::deleteCookie):
3671         * WebView/WebPreferences.mm:
3672         (+[WebPreferences _clearNetworkLoaderSession]):
3673
3674 2018-07-28  Darin Adler  <darin@apple.com>
3675
3676         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3677         https://bugs.webkit.org/show_bug.cgi?id=188140
3678
3679         Reviewed by Sam Weinig.
3680
3681         * WebView/WebImmediateActionController.mm:
3682         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3683         new DictionaryLookup function that returns a tuple instead of using an out argument.
3684
3685 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3686
3687         [INTL] Remove INTL sub-feature compile flags
3688         https://bugs.webkit.org/show_bug.cgi?id=188081
3689
3690         Reviewed by Michael Catanzaro.
3691
3692         * Configurations/FeatureDefines.xcconfig:
3693
3694 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3695
3696         Unreviewed, rolling out r234181 and r234189.
3697         https://bugs.webkit.org/show_bug.cgi?id=188075
3698
3699         These are not needed right now (Requested by thorton on
3700         #webkit).
3701
3702         Reverted changesets:
3703
3704         "Enable Web Content Filtering on watchOS"
3705         https://bugs.webkit.org/show_bug.cgi?id=187979
3706         https://trac.webkit.org/changeset/234181
3707
3708         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3709         https://bugs.webkit.org/show_bug.cgi?id=187985
3710         https://trac.webkit.org/changeset/234189
3711
3712 2018-07-26  Timothy Hatcher  <timothy@apple.com>
3713
3714         Use the Page's appearance when converting pasteboard attributed strings.
3715         https://bugs.webkit.org/show_bug.cgi?id=188067
3716         rdar://problem/42632246
3717
3718         Reviewed by Wenson Hsieh.
3719
3720         * WebCoreSupport/WebEditorClient.mm:
3721         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
3722
3723 2018-07-25  Chris Dumez  <cdumez@apple.com>
3724
3725         navigator.userAgent may return outdated value after webView.customUserAgent is set
3726         https://bugs.webkit.org/show_bug.cgi?id=188009
3727         <rdar://problem/42566456>
3728
3729         Reviewed by Alex Christensen.
3730
3731         Let the page know when the user agent changes.
3732
3733         * WebView/WebView.mm:
3734         (-[WebView _preferencesChanged:]):
3735         (-[WebView setApplicationNameForUserAgent:]):
3736         (-[WebView _invalidateUserAgentCache]):
3737         (-[WebView setCustomUserAgent:]):
3738         * WebView/WebViewInternal.h:
3739
3740 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3741
3742         Enable Web Content Filtering on watchOS
3743         https://bugs.webkit.org/show_bug.cgi?id=187979
3744         <rdar://problem/42559346>
3745
3746         Reviewed by Wenson Hsieh.
3747
3748         * Configurations/FeatureDefines.xcconfig:
3749
3750 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3751
3752         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3753         https://bugs.webkit.org/show_bug.cgi?id=187846
3754
3755         Reviewed by Simon Fraser.
3756
3757         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3758
3759         * WebView/WebHTMLView.mm:
3760         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3761         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3762
3763 2018-07-11  Dean Jackson  <dino@apple.com>
3764
3765         Allow removal of white backgrounds
3766         https://bugs.webkit.org/show_bug.cgi?id=187574
3767         <rdar://problem/41146792>
3768
3769         Reviewed by Simon Fraser.
3770
3771         Add a new WebPreference for punching out white backgrounds.
3772
3773         * WebView/WebPreferenceKeysPrivate.h:
3774         * WebView/WebPreferences.mm:
3775         (+[WebPreferences initialize]):
3776         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
3777         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
3778         * WebView/WebPreferencesPrivate.h:
3779         * WebView/WebView.mm:
3780         (-[WebView _preferencesChanged:]):
3781
3782 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
3783
3784         Ensure WebKit stack is ad-hoc signed
3785         https://bugs.webkit.org/show_bug.cgi?id=187667
3786
3787         Reviewed by Alexey Proskuryakov.
3788
3789         * Configurations/Base.xcconfig:
3790
3791 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
3792
3793         REGRESSION (231276): Attempting to copy an image fails
3794         https://bugs.webkit.org/show_bug.cgi?id=187212
3795         <rdar://problem/41540074>
3796
3797         Reviewed by Ryosuke Niwa.
3798
3799         Renamed methods to make it clear that one URL and one title are being passed in.
3800
3801         * WebCoreSupport/WebPlatformStrategies.h:
3802         * WebCoreSupport/WebPlatformStrategies.mm:
3803         (WebPlatformStrategies::setURL):
3804
3805 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
3806
3807         Disable cross-origin-window-policy by default
3808         https://bugs.webkit.org/show_bug.cgi?id=187509
3809
3810         Reviewed by Chris Dumez.
3811
3812         * WebView/WebPreferences.mm:
3813         (+[WebPreferences initialize]):
3814
3815 2018-07-09  Timothy Hatcher  <timothy@apple.com>
3816
3817         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3818         https://bugs.webkit.org/show_bug.cgi?id=187425
3819         rdar://problem/39948240
3820
3821         Reviewed by Tim Horton.
3822
3823         * WebView/WebView.mm:
3824         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3825         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3826         a call in this method to setUseDarkAppearance.
3827         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3828         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3829         (-[WebView _updateDefaultAppearance]): Deleted.
3830         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3831
3832 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
3833
3834         Shrink various loading-related enums to shrink CachedResource
3835         https://bugs.webkit.org/show_bug.cgi?id=187443
3836
3837         Reviewed by Chris Dumez.
3838
3839         * WebCoreSupport/WebFrameLoaderClient.mm:
3840         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3841         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
3842         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3843         (WebFrameLoaderClient::dispatchWillSendRequest):
3844         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3845         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3846         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3847         (WebFrameLoaderClient::updateGlobalHistory):
3848         (WebFrameLoaderClient::canHandleRequest const):
3849         * WebView/WebDataSource.mm:
3850         (-[WebDataSource initialRequest]):
3851         (-[WebDataSource request]):
3852
3853 2018-07-09  Commit Queue  <commit-queue@webkit.org>
3854
3855         Unreviewed, rolling out r233612.
3856         https://bugs.webkit.org/show_bug.cgi?id=187475
3857
3858         Revision caused the api test LinkColorWithSystemAppearance to
3859         fail on all systems. (Requested by Truitt on #webkit).
3860
3861         Reverted changeset:
3862
3863         "Semantic colors don't update when accessibility Increase
3864         Contrast mode is enabled."
3865         https://bugs.webkit.org/show_bug.cgi?id=187425
3866         https://trac.webkit.org/changeset/233612
3867
3868 2018-07-06  Timothy Hatcher  <timothy@apple.com>
3869
3870         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3871         https://bugs.webkit.org/show_bug.cgi?id=187425
3872         rdar://problem/39948240
3873
3874         Reviewed by Tim Horton.
3875
3876         * WebView/WebView.mm:
3877         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3878         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3879         a call in this method to setUseDarkAppearance.
3880         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3881         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3882         (-[WebView _updateDefaultAppearance]): Deleted.
3883         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3884
3885 2018-07-05  Timothy Hatcher  <timothy@apple.com>
3886
3887         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
3888         https://bugs.webkit.org/show_bug.cgi?id=187369
3889         rdar://problem/41870420
3890
3891         Reviewed by Tim Horton.
3892
3893         * WebView/WebMediaPlaybackTargetPicker.mm:
3894         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3895         * WebView/WebView.mm:
3896         (-[WebView _commonInitializationWithFrameName:groupName:]):
3897         (-[WebView _effectiveAppearanceIsDark]):
3898         (-[WebView _updateDefaultAppearance]):
3899         (-[WebView _defaultAppearance]): Deleted.
3900
3901 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
3902
3903         Youtube video pages crash after a couple of minutes
3904         https://bugs.webkit.org/show_bug.cgi?id=187316
3905
3906         Reviewed by Antti Koivisto.
3907
3908         * WebView/WebView.mm:
3909         (-[WebView _preferencesChanged:]):
3910
3911 2018-07-04  Tim Horton  <timothy_horton@apple.com>
3912
3913         Introduce PLATFORM(IOSMAC)
3914         https://bugs.webkit.org/show_bug.cgi?id=187315
3915
3916         Reviewed by Dan Bernstein.
3917
3918         * Configurations/Base.xcconfig:
3919         * Configurations/FeatureDefines.xcconfig:
3920
3921 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3922
3923         [iOS] DataTransfer.getData always returns the empty string when dropping text
3924         https://bugs.webkit.org/show_bug.cgi?id=187130
3925         <rdar://problem/41014117>
3926
3927         Reviewed by Ryosuke Niwa.
3928
3929         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
3930
3931         * WebCoreSupport/WebPlatformStrategies.h:
3932         * WebCoreSupport/WebPlatformStrategies.mm:
3933         (WebPlatformStrategies::allPasteboardItemInfo):
3934
3935 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
3936
3937         [Mac] AirPlay picker uses incorrect theme in Dark mode
3938         https://bugs.webkit.org/show_bug.cgi?id=187054
3939         <rdar://problem/41291093>
3940
3941         Reviewed by Timothy Hatcher.
3942
3943         * WebView/WebMediaPlaybackTargetPicker.mm:
3944         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
3945
3946 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3947
3948         [WTF] Add user-defined literal for ASCIILiteral
3949         https://bugs.webkit.org/show_bug.cgi?id=186839
3950
3951         Reviewed by Darin Adler.
3952
3953         * DOM/ExceptionHandlers.mm:
3954         (raiseDOMErrorException):
3955         * Plugins/Hosted/ProxyInstance.mm:
3956         (WebKit::ProxyInstance::invokeMethod):
3957         * Storage/WebDatabaseProvider.mm:
3958         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
3959
3960 2018-06-22  Timothy Hatcher  <timothy@apple.com>
3961
3962         Recalc styles every time defaultAppearance changes.
3963         https://bugs.webkit.org/show_bug.cgi?id=186866
3964         rdar://problem/41309805
3965
3966         Reviewed by Tim Horton.
3967
3968         * WebView/WebView.mm:
3969         (-[WebView _updateDefaultAppearance]):
3970         (-[WebView _setUseSystemAppearance:]):
3971         (-[WebView _useSystemAppearance]):
3972
3973 2018-06-20  Darin Adler  <darin@apple.com>
3974
3975         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
3976         https://bugs.webkit.org/show_bug.cgi?id=186875
3977
3978         Reviewed by Anders Carlsson.
3979
3980         * WebView/WebHTMLView.mm:
3981         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
3982         to write te file to.
3983         * WebView/WebPreferences.mm:
3984         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
3985         * WebView/WebView.mm:
3986         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
3987
3988 2018-06-12  Darin Adler  <darin@apple.com>
3989
3990         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
3991         https://bugs.webkit.org/show_bug.cgi?id=186526
3992
3993         Reviewed by Anders Carlsson.
3994
3995         * Plugins/Hosted/NetscapePluginHostManager.mm:
3996         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
3997
3998         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3999         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
4000         assignment rather than adoptNS/leakRef.
4001         * Plugins/WebNetscapePluginView.mm:
4002         (-[WebNetscapePluginView createPlugin]): Ditto.
4003
4004         * WebCoreSupport/WebContextMenuClient.mm:
4005         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
4006         RetainPtr::autorelease; no need to autorelease just to pass something as a function
4007         argument, so use RetainPtr::get instead.
4008
4009         * WebView/WebHTMLView.mm:
4010         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
4011         No need to autorelease the result when the return type is RetainPtr.
4012
4013         * WebView/WebPDFRepresentation.mm:
4014         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
4015
4016 2018-06-13  Youenn Fablet  <youenn@apple.com>
4017
4018         Supported plugin check should be based on plugin identifier
4019         https://bugs.webkit.org/show_bug.cgi?id=186578
4020         <rdar://problem/40523828>
4021
4022         Reviewed by Darin Adler.
4023
4024         * WebCoreSupport/WebPluginInfoProvider.h:
4025         * WebCoreSupport/WebPluginInfoProvider.mm:
4026         (WebPluginInfoProvider::pluginInfo):
4027         (WebPluginInfoProvider::webVisiblePluginInfo):
4028
4029 2018-06-13  Chris Dumez  <cdumez@apple.com>
4030
4031         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
4032         https://bugs.webkit.org/show_bug.cgi?id=186545
4033
4034         Reviewed by Brady Eidson.
4035
4036         Update client delegate now that parameter type has changed.
4037
4038         * WebCoreSupport/WebFrameLoaderClient.h:
4039         * WebCoreSupport/WebFrameLoaderClient.mm:
4040         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
4041
4042 2018-06-11  Tim Horton  <timothy_horton@apple.com>
4043
4044         Link drag image is inconsistently unreadable in dark mode
4045         https://bugs.webkit.org/show_bug.cgi?id=186472
4046
4047         Reviewed by Timothy Hatcher.
4048
4049         * WebView/WebView.mm:
4050         (-[WebView _defaultAppearance]):
4051         Make defaultAppearance accurate even if useSystemAppearance is false.
4052         Some parts of WebKit (like the link drag image, but also context menus)
4053         want to be able to follow the system appearance regardless of whether
4054         the view or content has opted in.
4055
4056 2018-06-11  Chris Dumez  <cdumez@apple.com>
4057
4058         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
4059         https://bugs.webkit.org/show_bug.cgi?id=186441
4060
4061         Reviewed by Brady Eidson.
4062
4063         Rename existing flag to something a bit more generic, now that it is used for
4064         more things than bypassing the navigation policy check.
4065
4066         * WebView/WebView.mm:
4067         (-[WebView _loadBackForwardListFromOtherView:]):
4068         (-[WebView goToBackForwardItem:]):
4069
4070 2018-06-09  Dan Bernstein  <mitz@apple.com>
4071
4072         [Xcode] Clean up and modernize some build setting definitions
4073         https://bugs.webkit.org/show_bug.cgi?id=186463
4074