Stop using SDK conditionals to control feature definitions
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-12  Tim Horton  <timothy_horton@apple.com>
2
3         Stop using SDK conditionals to control feature definitions
4         https://bugs.webkit.org/show_bug.cgi?id=183430
5         <rdar://problem/38251619>
6
7         Reviewed by Dan Bernstein.
8
9         * Configurations/FeatureDefines.xcconfig:
10         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
11
12 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
13
14         Runtime flag for link prefetch and remove link subresource.
15         https://bugs.webkit.org/show_bug.cgi?id=183540
16
17         Reviewed by Chris Dumez.
18
19         Remove the LINK_PREFETCH build time flag.
20
21         * Configurations/FeatureDefines.xcconfig:
22
23 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
24
25         Remove GridLayout runtime flag
26         https://bugs.webkit.org/show_bug.cgi?id=183484
27
28         Reviewed by Myles C. Maxfield.
29
30         The Grid Layout feature has been enabled by default for almost a
31         year, so I think it's time to remove the runtime flag and the
32
33         * WebView/WebPreferenceKeysPrivate.h:
34         * WebView/WebPreferences.mm:
35         (+[WebPreferences initialize]):
36         * WebView/WebPreferencesPrivate.h:
37         * WebView/WebView.mm:
38         (-[WebView _preferencesChanged:]):
39
40 2018-03-12  Antoine Quint  <graouts@apple.com>
41
42         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
43         https://bugs.webkit.org/show_bug.cgi?id=183504
44         <rdar://problem/38372965>
45
46         Reviewed by Dean Jackson and Jon Lee.
47
48         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
49         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
50
51         * WebView/WebPreferenceKeysPrivate.h:
52         * WebView/WebPreferences.mm:
53         (+[WebPreferences initialize]):
54         (-[WebPreferences setModernMediaControlsEnabled:]):
55         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
56         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
57         * WebView/WebPreferencesPrivate.h:
58         * WebView/WebView.mm:
59         (-[WebView _preferencesChanged:]):
60
61 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
62
63         Media query for default appearance
64         https://bugs.webkit.org/show_bug.cgi?id=183539
65         <rdar://problem/38326388>
66
67         Reviewed by Tim Horton.
68
69         Write a media query to evaluate appearance.
70
71         * WebView/WebView.mm:
72         (-[WebView _commonInitializationWithFrameName:groupName:]):
73         (-[WebView _setUseSystemAppearance:]):
74
75 2018-03-09  Andy Estes  <aestes@apple.com>
76
77         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
78         https://bugs.webkit.org/show_bug.cgi?id=183489
79         <rdar://problem/38267517>
80
81         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
82         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
83         to issue a sandbox extension for this directory, but for security reasons App Sandbox
84         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
85         block with a nil error and a valid file URL, but no file will actually exist at that URL.
86
87         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
88         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
89         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
90         drop destination.
91
92         Reviewed by Wenson Hsieh.
93
94         * WebView/WebView.mm:
95         (-[WebView performDragOperation:]):
96
97 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
98
99         Allow WebViews to disable system appearance
100         https://bugs.webkit.org/show_bug.cgi?id=183418
101         <rdar://problem/36975642>
102
103         Reviewed by Tim Horton.
104
105         Allow webviews to choose whether or not to follow the default system appearance.
106
107         * WebView/WebView.mm:
108         (-[WebView _setUseSystemAppearance:]):
109         (-[WebView _useSystemAppearance]):
110         * WebView/WebViewPrivate.h:
111
112 2018-03-08  Youenn Fablet  <youenn@apple.com>
113
114         libwebrtc update broke internal builds
115         https://bugs.webkit.org/show_bug.cgi?id=183454
116
117         Reviewed by Eric Carlson.
118
119         * Configurations/WebKitLegacy.xcconfig:
120
121 2018-03-08  Chris Dumez  <cdumez@apple.com>
122
123         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
124         https://bugs.webkit.org/show_bug.cgi?id=183455
125         <rdar://problem/38191749>
126
127         Reviewed by Youenn Fablet.
128
129         Add a null check for the page as we have evidence from crashes that it can be null.
130         Other functions in WebFrameNetworkingContext already null check the page as well,
131         not just the frame so this is consistent.
132
133         * WebCoreSupport/WebFrameNetworkingContext.mm:
134         (WebFrameNetworkingContext::storageSession const):
135
136 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
137
138         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
139         https://bugs.webkit.org/show_bug.cgi?id=183429
140
141         Reviewed by Mark Lam.
142
143         * DOM/DOM.mm:
144         (+[DOMNode _nodeFromJSWrapper:]):
145         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
146         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
147         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
148         * Plugins/Hosted/ProxyInstance.mm:
149         (WebKit::ProxyInstance::invokeMethod):
150         * WebView/WebView.mm:
151         (aeDescFromJSValue):
152
153 2018-03-08  Tim Horton  <timothy_horton@apple.com>
154
155         Stop linking ApplicationServices directly
156         https://bugs.webkit.org/show_bug.cgi?id=182867
157         <rdar://problem/38252142>
158
159         Reviewed by Alex Christensen.
160
161         The frameworks that we use that live inside ApplicationServices
162         have mostly moved out, so import them directly.
163
164         * Carbon/CarbonUtils.h:
165         * WebKitPrefix.h:
166         * WebView/WebHTMLView.mm:
167         * WebView/WebPDFView.mm:
168
169 2018-03-07  Tim Horton  <timothy_horton@apple.com>
170
171         Sort and separate FeatureDefines.xcconfig
172         https://bugs.webkit.org/show_bug.cgi?id=183427
173
174         Reviewed by Dan Bernstein.
175
176         * Configurations/FeatureDefines.xcconfig:
177         Sort and split FeatureDefines into paragraphs
178         (to make it easier to sort later).
179
180 2018-03-07  Youenn Fablet  <youenn@apple.com>
181
182         Match unsupported plugins based on domains and not origin
183         https://bugs.webkit.org/show_bug.cgi?id=183384
184
185         Reviewed by Chris Dumez.
186
187         * WebCoreSupport/WebPluginInfoProvider.h:
188         * WebCoreSupport/WebPluginInfoProvider.mm:
189         (WebPluginInfoProvider::getPluginInfo):
190         (WebPluginInfoProvider::getWebVisiblePluginInfo):
191
192 2018-03-05  Andy Estes  <aestes@apple.com>
193
194         [Mac] Teach WebCore::Pasteboard about file promise drags
195         https://bugs.webkit.org/show_bug.cgi?id=183314
196         <rdar://problem/38105493>
197
198         Reviewed by Darin Adler.
199
200         Added a FIXME comment.
201
202         * WebView/WebView.mm:
203         (-[WebView performDragOperation:]):
204
205 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
206
207         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
208         https://bugs.webkit.org/show_bug.cgi?id=183312
209
210         Reviewed by Mark Lam.
211
212         Remove wtf/CurrentTime.h include pragma.
213
214         * WebView/WebFrame.mm:
215         * WebView/WebPDFView.mm:
216
217 2018-03-04  Tim Horton  <timothy_horton@apple.com>
218
219         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
220         https://bugs.webkit.org/show_bug.cgi?id=183283
221         <rdar://problem/38062148>
222
223         Reviewed by Sam Weinig.
224
225         * Configurations/FeatureDefines.xcconfig:
226
227 2018-02-28  Alex Christensen  <achristensen@webkit.org>
228
229         Reduce use of NetworkingContext in WebKit
230         https://bugs.webkit.org/show_bug.cgi?id=183213
231
232         Reviewed by Brady Eidson.
233
234         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
235         (WebKit::NetscapePluginInstanceProxy::getProxy):
236         * Plugins/WebNetscapePluginView.mm:
237         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
238
239 2018-02-17  Darin Adler  <darin@apple.com>
240
241         Prepare for ExtendedColor changes (first step)
242         https://bugs.webkit.org/show_bug.cgi?id=182904
243
244         Reviewed by Sam Weinig.
245
246         * Misc/WebKitNSStringExtras.mm:
247         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
248
249 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
250
251         Remove currentTime() / currentTimeMS()
252         https://bugs.webkit.org/show_bug.cgi?id=183052
253
254         Reviewed by Mark Lam.
255
256         * WebCoreSupport/WebFrameLoaderClient.h:
257         * WebCoreSupport/WebFrameLoaderClient.mm:
258         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
259
260 2018-02-16  Youenn Fablet  <youenn@apple.com>
261
262         Allow specifying which plug-ins are supported
263         https://bugs.webkit.org/show_bug.cgi?id=182748
264
265         Reviewed by Chris Dumez.
266
267         * WebCoreSupport/WebPluginInfoProvider.h:
268         * WebCoreSupport/WebPluginInfoProvider.mm:
269         (WebPluginInfoProvider::getPluginInfo):
270         (WebPluginInfoProvider::getWebVisiblePluginInfo):
271
272 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
273
274         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
275         https://bugs.webkit.org/show_bug.cgi?id=182882
276         <rdar://problem/35672661>
277
278         Reviewed by Dan Bernstein.
279
280         Make sure the smart pointer hold the collection of subviews lives at least as
281         long as the loop using it.
282
283         * WebView/WebHTMLView.mm:
284         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
285
286 2018-02-14  Daniel Bates  <dabates@apple.com>
287
288         Disallow cross-origin subresources from asking for credentials
289         https://bugs.webkit.org/show_bug.cgi?id=182579
290         <rdar://problem/36162271>
291
292         Reviewed by Andy Estes.
293
294         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
295         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
296
297         * WebView/WebPreferenceKeysPrivate.h:
298         * WebView/WebPreferences.mm:
299         (+[WebPreferences initialize]):
300         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
301         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
302         * WebView/WebPreferencesPrivate.h:
303         * WebView/WebView.mm:
304         (-[WebView _preferencesChanged:]):
305
306 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
307
308         Remove ForwardingHeaders directory from WebKitLegacy/mac.
309         https://bugs.webkit.org/show_bug.cgi?id=182738
310
311         Reviewed by Darin Adler.
312
313         * ForwardingHeaders/collector/handles/Global.h: Removed.
314         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
315         * ForwardingHeaders/runtime/Completion.h: Removed.
316         * ForwardingHeaders/runtime/Error.h: Removed.
317         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
318         * ForwardingHeaders/runtime/JSFunction.h: Removed.
319         * ForwardingHeaders/runtime/JSLock.h: Removed.
320         * ForwardingHeaders/runtime/JSObject.h: Removed.
321         * ForwardingHeaders/runtime/JSString.h: Removed.
322         * ForwardingHeaders/runtime/Protect.h: Removed.
323         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
324
325 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
326
327         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
328         https://bugs.webkit.org/show_bug.cgi?id=182641
329
330         Reviewed by Dan Bernstein.
331
332         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
333         https://trac.webkit.org/changeset/228308.
334
335         * WebView/WebVideoFullscreenController.h:
336         * WebView/WebVideoFullscreenHUDWindowController.mm:
337         * WebView/WebWindowAnimation.h:
338         * WebView/WebWindowAnimation.mm:
339         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
340         (WebCore::scaledRect): Deleted.
341         (WebCore::squaredDistance): Deleted.
342
343 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
344
345         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
346
347         * WebView/WebWindowAnimation.mm:
348         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
349
350 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
351
352         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
353         https://bugs.webkit.org/show_bug.cgi?id=182615
354
355         Reviewed by Eric Carlson.
356
357         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
358         Ideally, we should not reference NSApp in WebCore.
359
360         * WebView/WebFullScreenController.mm:
361         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
362         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
363         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
364         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
365         * WebView/WebView.mm:
366         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
367         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
368
369 2018-01-13  Darin Adler  <darin@apple.com>
370
371         Event improvements
372         https://bugs.webkit.org/show_bug.cgi?id=179591
373
374         Reviewed by Chris Dumez.
375
376         * DOM/DOMWheelEvent.mm:
377         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
378         Call initWebKitWheelEvent.
379
380         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
381         * WebCoreSupport/WebInspectorClient.mm: Ditto.
382         * WebView/WebFrame.mm: Ditto.
383
384         * WebView/WebHTMLView.mm:
385         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
386         underlyingPlatformEvent.
387         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
388
389         * WebView/WebScriptWorld.mm:
390         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
391
392         * WebView/WebView.mm: Removed include of ScriptValue.h.
393
394 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
395
396         Remove WebCore/ForwardingHeaders directory
397         https://bugs.webkit.org/show_bug.cgi?id=182347
398
399         Reviewed by Keith Miller.
400
401         * Carbon/CarbonWindowAdapter.mm:
402         * DOM/WebDOMOperations.mm:
403         * History/WebBackForwardList.mm:
404         * History/WebHistoryItem.mm:
405         * Misc/WebCache.mm:
406         * Misc/WebElementDictionary.mm:
407         * Misc/WebIconDatabase.mm:
408         * Misc/WebStringTruncator.mm:
409         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
410         * Plugins/Hosted/ProxyInstance.mm:
411         * Plugins/Hosted/ProxyRuntimeObject.mm:
412         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
413         * Plugins/WebBaseNetscapePluginView.mm:
414         * Plugins/WebBasePluginPackage.mm:
415         * Plugins/WebNetscapePluginStream.mm:
416         * Plugins/WebNetscapePluginView.mm:
417         * Plugins/WebPluginController.mm:
418         * WebCoreSupport/WebEditorClient.mm:
419         * WebCoreSupport/WebFrameLoaderClient.mm:
420         * WebCoreSupport/WebInspectorClient.h:
421         * WebCoreSupport/WebInspectorClient.mm:
422         * WebView/WebDataSource.mm:
423         * WebView/WebFrame.mm:
424         * WebView/WebHTMLRepresentation.mm:
425         * WebView/WebHTMLView.mm:
426         * WebView/WebPreferences.mm:
427         * WebView/WebScriptDebugDelegate.mm:
428         * WebView/WebScriptDebugger.h:
429         * WebView/WebTextIterator.mm:
430         * WebView/WebView.mm:
431         * WebView/WebViewData.mm:
432
433 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
434
435         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
436         https://bugs.webkit.org/show_bug.cgi?id=182312
437
438         Reviewed by Michael Catanzaro.
439
440         * WebKitPrefix.h:
441
442 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
443
444         [WebAuthN] Add a compile-time feature flag
445         https://bugs.webkit.org/show_bug.cgi?id=182211
446         <rdar://problem/36936365>
447
448         Reviewed by Brent Fulgham.
449
450         * Configurations/FeatureDefines.xcconfig:
451
452 2018-01-27  Dan Bernstein  <mitz@apple.com>
453
454         HaveInternalSDK includes should be "#include?"
455         https://bugs.webkit.org/show_bug.cgi?id=179670
456
457         * Configurations/Base.xcconfig:
458
459 2018-01-24  Alex Christensen  <achristensen@webkit.org>
460
461         Remove unused QTKit preference
462         https://bugs.webkit.org/show_bug.cgi?id=181968
463
464         Reviewed by Alexey Proskuryakov.
465
466         * WebView/WebPreferenceKeysPrivate.h:
467         * WebView/WebPreferences.mm:
468         (+[WebPreferences initialize]):
469         (-[WebPreferences setQTKitEnabled:]): Deleted.
470         (-[WebPreferences isQTKitEnabled]): Deleted.
471         * WebView/WebPreferencesPrivate.h:
472         * WebView/WebView.mm:
473         (-[WebView _preferencesChanged:]):
474
475 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
476
477         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
478         https://bugs.webkit.org/show_bug.cgi?id=182037
479         <rdar://problem/36747812>
480
481         Reviewed by Ryosuke Niwa.
482
483         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
484         for more details.
485
486         * WebView/WebHTMLRepresentation.mm:
487         (-[WebHTMLRepresentation elementWithName:inForm:]):
488         (-[WebHTMLRepresentation controlsInForm:]):
489
490 2018-01-23  Alex Christensen  <achristensen@webkit.org>
491
492         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
493         https://bugs.webkit.org/show_bug.cgi?id=181961
494
495         Reviewed by Michael Catanzaro.
496
497         * WebView/WebPreferences.mm:
498
499 2018-01-23  Commit Queue  <commit-queue@webkit.org>
500
501         Unreviewed, rolling out r227437.
502         https://bugs.webkit.org/show_bug.cgi?id=182011
503
504         broke build (Requested by alexchristensen on #webkit).
505
506         Reverted changeset:
507
508         "Remove unused QTKit preference"
509         https://bugs.webkit.org/show_bug.cgi?id=181968
510         https://trac.webkit.org/changeset/227437
511
512 2018-01-23  Alex Christensen  <achristensen@webkit.org>
513
514         Remove unused QTKit preference
515         https://bugs.webkit.org/show_bug.cgi?id=181968
516
517         Reviewed by Alexey Proskuryakov.
518
519         * WebView/WebPreferenceKeysPrivate.h:
520         * WebView/WebPreferences.mm:
521         (+[WebPreferences initialize]):
522         (-[WebPreferences setQTKitEnabled:]): Deleted.
523         (-[WebPreferences isQTKitEnabled]): Deleted.
524         * WebView/WebPreferencesPrivate.h:
525         * WebView/WebView.mm:
526         (-[WebView _preferencesChanged:]):
527
528 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
529
530         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
531         https://bugs.webkit.org/show_bug.cgi?id=181960
532         <rdar://problem/36431678>
533
534         Reviewed by Tim Horton.
535
536         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
537         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
538         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
539
540         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
541         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
542         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
543
544         * WebView/WebView.mm:
545         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
546
547 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
548
549         Turning off custom pasteboard data doesn't actually turn it off in WK2
550         https://bugs.webkit.org/show_bug.cgi?id=181920
551         <rdar://problem/36686429>
552
553         Reviewed by Wenson Hsieh.
554
555         Always disable custom pasteboard data in WebKit1. See r226156 for details.
556
557         * WebView/WebPreferences.mm:
558         (+[WebPreferences initialize]):
559         * WebView/WebView.mm:
560         (-[WebView _preferencesChanged:]):
561
562 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
563
564         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
565         https://bugs.webkit.org/show_bug.cgi?id=181918
566
567         Reviewed by Tim Horton.
568
569         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
570
571         * Configurations/FeatureDefines.xcconfig:
572
573 2018-01-20  Andy Estes  <aestes@apple.com>
574
575         [Apple Pay] Stop eagerly loading PassKit.framework
576         https://bugs.webkit.org/show_bug.cgi?id=181911
577         <rdar://problem/36555369>
578
579         Reviewed by Tim Horton.
580
581         * WebCoreSupport/WebPaymentCoordinatorClient.h:
582         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
583         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
584
585         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
586
587 2018-01-19  Dean Jackson  <dino@apple.com>
588
589         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
590         https://bugs.webkit.org/show_bug.cgi?id=181817
591         <rdar://problem/35274055>
592
593         Reviewed by Simon Fraser.
594
595         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
596
597         * Misc/WebKitVersionChecks.h:
598         * WebView/WebView.mm:
599         (-[WebView _commonInitializationWithFrameName:groupName:]):
600
601 2018-01-19  Alex Christensen  <achristensen@webkit.org>
602
603         Remove unused WebViewPrivate _allowCookies
604         https://bugs.webkit.org/show_bug.cgi?id=181812
605
606         Reviewed by Tim Horton.
607
608         * WebView/WebView.mm:
609         (+[WebView _setAllowCookies:]): Deleted.
610         (+[WebView _allowCookies]): Deleted.
611         * WebView/WebViewPrivate.h:
612
613 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
614
615         Build fix, remove a call to -[NSWindow setOneShot:]
616         https://bugs.webkit.org/show_bug.cgi?id=181809
617
618         Reviewed by Tim Horton.
619
620         * WebView/WebTextCompletionController.mm:
621         (-[WebTextCompletionController _buildUI]):
622
623 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
624
625         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
626
627         * Carbon/HIWebView.mm:
628         (overrideCGContext):
629         (restoreCGContext):
630
631 2018-01-18  Dan Bernstein  <mitz@apple.com>
632
633         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
634         https://bugs.webkit.org/show_bug.cgi?id=181803
635
636         Reviewed by Tim Horton.
637
638         * Configurations/Base.xcconfig: Updated.
639         * Configurations/DebugRelease.xcconfig: Ditto.
640         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
641         * Configurations/Version.xcconfig: Updated.
642         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
643           useful for defining settings that depend on the target macOS version.
644
645 2018-01-17  Youenn Fablet  <youenn@apple.com>
646
647         Put fetch Request.keepalive behind a runtime flag
648         https://bugs.webkit.org/show_bug.cgi?id=181592
649
650         Reviewed by Chris Dumez.
651
652         * WebView/WebPreferenceKeysPrivate.h:
653         * WebView/WebPreferences.mm:
654         (+[WebPreferences initialize]):
655         (-[WebPreferences fetchAPIKeepAliveEnabled]):
656         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
657         * WebView/WebPreferencesPrivate.h:
658         * WebView/WebView.mm:
659         (-[WebView _preferencesChanged:]):
660
661 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
662
663         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
664         https://bugs.webkit.org/show_bug.cgi?id=181637
665         <rdar://problem/36508471>
666
667         Reviewed by Tim Horton.
668
669         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
670
671         * WebCoreSupport/WebEditorClient.h:
672         * WebCoreSupport/WebEditorClient.mm:
673         (WebEditorClient::replacementURLForResource):
674
675 2018-01-11  Keith Miller  <keith_miller@apple.com>
676
677         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
678         https://bugs.webkit.org/show_bug.cgi?id=181573
679
680         Reviewed by Simon Fraser.
681
682         * Configurations/FeatureDefines.xcconfig:
683
684 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
685
686         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
687         https://bugs.webkit.org/show_bug.cgi?id=181497
688
689         Reviewed by Tim Horton.
690
691         See other ChangeLogs for more detail.
692
693         * WebCoreSupport/WebDragClient.h:
694
695 2018-01-11  Tim Horton  <timothy_horton@apple.com>
696
697         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
698         https://bugs.webkit.org/show_bug.cgi?id=181523
699         <rdar://problem/28959131>
700
701         Reviewed by Alex Christensen.
702
703         * WebView/WebImmediateActionController.mm:
704         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
705         Apply the change made in r216652 to WebKit1's immediate action controller.
706
707         Speculative (but successful in WebKit2) fix for non-reproducible crash when
708         the startContainer of the range is in an anonymous node.
709
710 2018-01-11  Youenn Fablet  <youenn@apple.com>
711
712         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
713         https://bugs.webkit.org/show_bug.cgi?id=181480
714
715         Reviewed by Eric Carlson.
716
717         * WebView/WebPreferences.mm:
718         (+[WebPreferences initialize]):
719
720 2018-01-08  David Kilzer  <ddkilzer@apple.com>
721
722         Fix check-webkit-style issues with WebNSDataExtras.mm
723         <https://webkit.org/b/181369>
724
725         Reviewed by Alex Christensen.
726
727         * Misc/WebNSDataExtras.mm:
728         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
729         (-[NSData _webkit_guessedMIMETypeForXML]):
730         (-[NSData _webkit_guessedMIMEType]):
731         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
732         (_findEOL):
733         (-[NSData _webkit_parseRFC822HeaderFields]):
734         (-[NSData _web_locationAfterFirstBlankLine]):
735         - Fix all the check-webkit-style warnings.
736
737 2018-01-08  David Kilzer  <ddkilzer@apple.com>
738
739         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
740         <https://webkit.org/b/181256>
741         <rdar://problem/36281730>
742
743         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
744         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
745         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
746           to avoid warnings from casting CFStringRef to NPNSString*.
747           Note that CFMutableStringRef is the same as CFStringRef
748           without the const modifier, hence its use in the const_cast<>
749           above.
750
751 2018-01-08  David Kilzer  <ddkilzer@apple.com>
752
753         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
754         <https://webkit.org/b/181256>
755         <rdar://problem/36281730>
756
757         * Carbon/HIWebView.mm:
758         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
759         checked_cf_cast<CFRunLoopRef>() to fix warning.
760
761 2018-01-07  David Kilzer  <ddkilzer@apple.com>
762
763         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
764         <https://webkit.org/b/181256>
765         <rdar://problem/36281730>
766
767         Reviewed by Darin Adler.
768
769         * Carbon/CarbonUtils.m:
770         (PoolCleaner):
771         - Use #pragmas to ignore -Wcast-qual warnings when using a
772           C-style cast from CFTypeRef to CFRunloopRef.
773         * Carbon/CarbonWindowFrame.m:
774         (-[CarbonWindowFrame title]):
775         - Use #pragmas to ignore -Wcast-qual warnings when using a
776           C-style cast from CFStringRef to NSString *.
777         * Carbon/HIViewAdapter.m:
778         (+[HIViewAdapter getHIViewForNSView:]):
779         - Use #pragmas to ignore -Wcast-qual warnings when using a
780           C-style cast from CFTypeRef to HIViewRef.
781         * Configurations/Base.xcconfig:
782         (WARNING_CFLAGS): Add -Wcast-qual.
783         * Misc/WebElementDictionary.mm:
784         (-[WebElementDictionary objectForKey:]):
785         - Use static_cast<SEL>(const_cast<void*>()) to fix
786           warning.
787         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
788         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
789         (-[NSData _webkit_guessedMIMETypeForXML]):
790         (-[NSData _webkit_guessedMIMEType]):
791         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
792         (_findEOL):
793         (-[NSData _webkit_parseRFC822HeaderFields]):
794         (-[NSData _web_startsWithBlankLine]):
795         (-[NSData _web_locationAfterFirstBlankLine]):
796         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
797           type to Objective-C++.  This fixes the warnings about
798           discarding the `const` modifier when casing from CFStringRef
799           to NSString * because in older clang versions, -Wcast-qual was
800           completely broken when compiling C++ and Objective-C++ source
801           files.  In newer clang versions, discarding the `const`
802           modifier for toll-free bridged types is ignored when compiling
803           Objective-C++ source.
804         - Update copyright and license header.
805         - Use reinterpret_cast<> and static_cast<> to fix warnings
806           unrelated to (NSString *) C-style casts.
807         - Replace use of MIN() macro with std::min<> template functions.
808         - Fix location of `*` for local variables modified above.
809         * Plugins/Hosted/NetscapePluginHostManager.mm:
810         (WebKit::NetscapePluginHostManager::spawnPluginHost):
811         (WebKit::NetscapePluginHostManager::initializeVendorPort):
812         (WebKit::NetscapePluginHostManager::instantiatePlugin):
813         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
814           warnings.
815         * Plugins/Hosted/NetscapePluginHostProxy.mm:
816         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
817         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
818           to fix warning.
819         * Plugins/Hosted/ProxyInstance.mm:
820         (WebKit::ProxyInstance::invoke):
821         - Use static_cast<char*>(const_cast<void*>()) to fix
822           warning when using -[NSData bytes].
823         (WebKit::ProxyInstance::fieldValue const):
824         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
825           to fix warning when using CFDataGetBytePtr().
826         * Plugins/Hosted/WebTextInputWindowController.m:
827         (-[WebTextInputPanel _interpretKeyEvent:string:]):
828         - Use #pragma to ignore -Wcast-qual warning since there
829           is not a good way to avoid this warning in Objective-C.
830         * Plugins/WebNetscapePluginStream.mm:
831         (WebNetscapePluginStream::deliverData):
832         - Use const_cast<void*>() to fix warning when using
833           -[NSData bytes].
834         * Plugins/WebNetscapePluginView.mm:
835         (-[WebNetscapePluginView _createPlugin]):
836         - Change C-style cast to const_cast<char*>() to fix
837           warning.
838         * WebCoreSupport/WebChromeClient.mm:
839         (WebChromeClient::wrapCryptoKey const):
840         (WebChromeClient::unwrapCryptoKey const):
841         - Change C-style cast to
842           static_cast<uint8_t*>(const_cast<void*>() to fix
843           warning.
844         * WebView/WebPDFView.mm:
845         (_applicationInfoForMIMEType):
846         - Change local variable type from 'NSURL *' to
847           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
848           when calling -[NSURL path].
849
850 2018-01-05  Dan Bernstein  <mitz@apple.com>
851
852         Fixed the build following AppKit API deprecations in a recent SDKs
853
854         * WebView/WebFullScreenController.mm:
855         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
856         (-[WebFullScreenController exitFullScreen]): Ditto.
857         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
858         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
859         * WebView/WebHTMLView.mm:
860         (-[WebHTMLView drawRect:]): Ditto.
861         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
862         (-[WebHTMLView knowsPageRange:]): Ditto.
863         * WebView/WebView.mm:
864         (LayerFlushController::flushLayers): Ditto.
865
866 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
867
868         [Attachment Support] Create attachment elements when dropping files on iOS
869         https://bugs.webkit.org/show_bug.cgi?id=181192
870         <rdar://problem/36280945>
871
872         Reviewed by Tim Horton.
873
874         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
875
876         * WebCoreSupport/WebPlatformStrategies.h:
877         * WebCoreSupport/WebPlatformStrategies.mm:
878         (WebPlatformStrategies::informationForItemAtIndex):
879         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
880
881 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
882
883         [Attachment Support] Add plumbing for starting a drag with promised blob data
884         https://bugs.webkit.org/show_bug.cgi?id=181201
885
886         Reviewed by Tim Horton.
887
888         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
889
890         * WebCoreSupport/WebDragClient.h:
891
892 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
893
894         Add a WebAuthentication runtime feature flag
895         https://bugs.webkit.org/show_bug.cgi?id=181220
896         <rdar://problem/36055305>
897
898         Reviewed by Brent Fulgham.
899
900         Renames the CredentialManagement runtime feature flag into WebAuthentication.
901
902         * WebView/WebPreferenceKeysPrivate.h:
903         * WebView/WebPreferences.mm:
904         (+[WebPreferences initialize]):
905         (-[WebPreferences webAuthenticationEnabled]):
906         (-[WebPreferences setWebAuthenticationEnabled:]):
907         (-[WebPreferences credentialManagementEnabled]): Deleted.
908         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
909         * WebView/WebPreferencesPrivate.h:
910         * WebView/WebView.mm:
911         (-[WebView _preferencesChanged:]):
912
913 2017-12-22  Jeff Miller  <jeffm@apple.com>
914
915         Update user-visible copyright strings to include 2018
916         https://bugs.webkit.org/show_bug.cgi?id=181141
917
918         Reviewed by Dan Bernstein.
919
920         * Info.plist:
921
922 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
923
924         [Attachment Support] Remove current macOS support for dragging file-backed attachments
925         https://bugs.webkit.org/show_bug.cgi?id=181188
926
927         Reviewed by Dan Bernstein.
928
929         See WebCore/ChangeLog for more detail.
930
931         * WebCoreSupport/WebDragClient.h:
932         * WebCoreSupport/WebDragClient.mm:
933         (WebDragClient::declareAndWriteAttachment): Deleted.
934         * WebView/WebHTMLView.mm:
935         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
936
937 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
938
939         Unreviewed, continue to fix build failures due to AppKit API deprecation
940
941         Wraps more code in -Wdeprecated-declarations.
942
943         * Carbon/HIWebView.mm:
944         (overrideCGContext):
945
946 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
947
948         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
949
950         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
951
952         * Carbon/CarbonWindowAdapter.mm:
953         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
954         * Plugins/WebNetscapePluginView.mm:
955         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
956         (-[WebNetscapePluginView sendDrawRectEvent:]):
957         (-[WebNetscapePluginView drawRect:]):
958
959 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
960
961         Fix build failures due to using deprecated AppKit symbols
962         https://bugs.webkit.org/show_bug.cgi?id=181110
963         <rdar://problem/36162865>
964
965         Reviewed by Dan Bernstein and Tim Horton.
966
967         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
968
969         * Misc/WebKitNSStringExtras.mm:
970         (-[NSString _web_drawAtPoint:font:textColor:]):
971         * Misc/WebNSPasteboardExtras.h:
972         * Misc/WebNSPasteboardExtras.mm:
973         (+[NSPasteboard _web_writableTypesForURL]):
974         (_createWritableTypesForImageWithoutArchive):
975         (_createWritableTypesForImageWithArchive):
976         (+[NSPasteboard _web_dragTypesForURL]):
977         (-[NSPasteboard _web_bestURL]):
978         (-[NSPasteboard _web_writeURL:andTitle:types:]):
979         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
980         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
981         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
982         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
983         * Panels/WebAuthenticationPanel.m:
984         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
985         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
986         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
987         (-[WebHostedNetscapePluginView drawRect:]):
988         * WebInspector/WebNodeHighlightView.mm:
989         (-[WebNodeHighlightView drawRect:]):
990         * WebView/WebFrame.mm:
991         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
992         (-[WebFrame _drawRect:contentsOnly:]):
993         * WebView/WebHTMLView.mm:
994         (kit):
995         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
996         (-[WebHTMLView _plainTextFromPasteboard:]):
997         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
998         (+[WebHTMLView _insertablePasteboardTypes]):
999         (+[WebHTMLView _selectionPasteboardTypes]):
1000         (-[WebHTMLView pasteboard:provideDataForType:]):
1001         (-[WebHTMLView _writeSelectionToPasteboard:]):
1002         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1003         (-[WebHTMLView validRequestorForSendType:returnType:]):
1004         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1005         (createMenuItem):
1006         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1007         (-[WebHTMLView _colorAsString:]):
1008         (-[WebHTMLView copyFont:]):
1009         * WebView/WebPDFView.mm:
1010         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1011         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1012         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1013         (-[WebPDFView pasteboardTypesForSelection]):
1014         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1015         * WebView/WebView.h:
1016         * WebView/WebView.mm:
1017         (-[WebView performDragOperation:]):
1018         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1019         (-[WebView _searchWithGoogleFromMenu:]):
1020
1021 2017-12-21  Youenn Fablet  <youenn@apple.com>
1022
1023         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1024         https://bugs.webkit.org/show_bug.cgi?id=181000
1025
1026         Reviewed by Chris Dumez.
1027
1028         * Misc/WebCache.mm:
1029         (+[WebCache addImageToCache:forURL:forFrame:]):
1030
1031 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1032
1033         Update FULLSCREEN_API feature defines.
1034         https://bugs.webkit.org/show_bug.cgi?id=181015
1035
1036         Reviewed by Tim Horton.
1037
1038         Change enabled iphone sdk for FULLSCREEN_API.
1039
1040         * Configurations/FeatureDefines.xcconfig:
1041
1042 2017-12-21  Jer Noble  <jer.noble@apple.com>
1043
1044         Add initial DOM support for Media Capabilities
1045         https://bugs.webkit.org/show_bug.cgi?id=181064
1046
1047         Reviewed by Eric Carlson.
1048
1049         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1050
1051         * WebView/WebPreferenceKeysPrivate.h:
1052         * WebView/WebPreferences.mm:
1053         (+[WebPreferences initialize]):
1054         (-[WebPreferences mediaCapabilitiesEnabled]):
1055         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1056         * WebView/WebPreferencesPrivate.h:
1057         * WebView/WebView.mm:
1058         (-[WebView _preferencesChanged:]):
1059
1060 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1061
1062         Enable picture-in-picture from inline element on suspend.
1063         https://bugs.webkit.org/show_bug.cgi?id=180942
1064         rdar://problem/34745234
1065
1066         Reviewed by Jer Noble.
1067
1068         Update signature of enterVideoFullscreenForVideoElement().
1069
1070         * WebCoreSupport/WebChromeClient.h:
1071         * WebCoreSupport/WebChromeClient.mm:
1072         (WebChromeClient::enterVideoFullscreenForVideoElement):
1073
1074 2017-12-20  Daniel Bates  <dabates@apple.com>
1075
1076         Remove Alternative Presentation Button
1077         https://bugs.webkit.org/show_bug.cgi?id=180500
1078         <rdar://problem/35891047>
1079
1080         Reviewed by Simon Fraser.
1081
1082         We no longer need the alternative presentation button.
1083
1084         * Configurations/FeatureDefines.xcconfig:
1085
1086 2017-12-19  Jer Noble  <jer.noble@apple.com>
1087
1088         Playing media elements which call "pause(); play()" will have the play promise rejected.
1089         https://bugs.webkit.org/show_bug.cgi?id=180781
1090         <rdar://problem/33191377>
1091
1092         Reviewed by Eric Carlson.
1093
1094         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1095
1096         * WebView/WebView.mm:
1097         (shouldRequireUserGestureToLoadVideo):
1098
1099 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1100
1101         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1102         https://bugs.webkit.org/show_bug.cgi?id=180977
1103
1104         Reviewed by Tim Horton.
1105
1106         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1107         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1108         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1109
1110         * WebCoreSupport/WebEditorClient.mm:
1111         (attributesForAttributedStringConversion):
1112         * WebView/WebHTMLView.mm:
1113         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1114
1115 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1116
1117         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1118
1119         Attempt to fix the following warnings:
1120
1121             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1122
1123         For the following instance variables:
1124
1125             _borderView
1126             _contentView
1127             _frame
1128             _wFlags
1129
1130         * Carbon/CarbonWindowAdapter.mm:
1131         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1132         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1133         (-[CarbonWindowAdapter _termWindowIfOwner]):
1134         (-[CarbonWindowAdapter _windowMovedToRect:]):
1135         (-[CarbonWindowAdapter setContentView:]):
1136         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1137         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1138
1139 2017-12-16  Dan Bernstein  <mitz@apple.com>
1140
1141         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1142         https://bugs.webkit.org/show_bug.cgi?id=180613
1143         <rdar://problem/35946124>
1144
1145         Reviewed by Geoff Garen.
1146
1147         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1148           clients.
1149         * WebView/WebDynamicScrollBarsView.h: Ditto.
1150         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1151
1152 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1153
1154         Enable -Wstrict-prototypes for WebKit
1155         <https://webkit.org/b/180757>
1156         <rdar://problem/36024132>
1157
1158         Rubber-stamped by Joseph Pecoraro.
1159
1160         * Configurations/Base.xcconfig:
1161         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1162
1163 2017-12-14  John Wilander  <wilander@apple.com>
1164
1165         Storage Access API: Implement frame-specific access in the document.cookie layer
1166         https://bugs.webkit.org/show_bug.cgi?id=180682
1167         <rdar://problem/35982257>
1168
1169         Reviewed by Alex Christensen.
1170
1171         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1172         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1173         CookiesStrategy::getRawCookies() now take optional parameters for
1174         frameID and pageID to allow frame-specific scoping of cookies.
1175
1176         This change makes the return values of FrameLoaderClient::frameID()
1177         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1178         WebCore can call those getters and get the right return values in
1179         WebKit and std:nullopt in WebKitLegacy.
1180
1181         * WebCoreSupport/WebFrameLoaderClient.h:
1182         * WebCoreSupport/WebFrameLoaderClient.mm:
1183         (WebFrameLoaderClient::pageID const):
1184         (WebFrameLoaderClient::frameID const):
1185         * WebCoreSupport/WebPlatformStrategies.h:
1186         * WebCoreSupport/WebPlatformStrategies.mm:
1187         (WebPlatformStrategies::cookiesForDOM):
1188         (WebPlatformStrategies::setCookiesFromDOM):
1189         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1190         (WebPlatformStrategies::getRawCookies):
1191
1192 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1193
1194         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1195         https://bugs.webkit.org/show_bug.cgi?id=180689
1196
1197         Reviewed by Tim Horton.
1198
1199         Use sRGBColorSpaceRef() from WebCore.
1200
1201         * WebView/WebHTMLView.mm:
1202         (imageFromRect):
1203
1204 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1205
1206         Stop using deprecated target conditional for simulator builds
1207         https://bugs.webkit.org/show_bug.cgi?id=180662
1208         <rdar://problem/35136156>
1209
1210         Reviewed by Simon Fraser.
1211
1212         * postprocess-headers.sh:
1213
1214 2017-12-11  David Quesada  <david_quesada@apple.com>
1215
1216         Turn on ENABLE_APPLICATION_MANIFEST
1217         https://bugs.webkit.org/show_bug.cgi?id=180562
1218         rdar://problem/35924737
1219
1220         Reviewed by Geoffrey Garen.
1221
1222         * Configurations/FeatureDefines.xcconfig:
1223
1224 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1225
1226         Remove pthread_once in favor of dispatch_once
1227         https://bugs.webkit.org/show_bug.cgi?id=180591
1228
1229         Reviewed by Saam Barati.
1230
1231         * Misc/WebKitErrors.m:
1232         (+[NSError _registerWebKitErrors]):
1233         (registerErrors): Deleted.
1234         * Storage/WebStorageManager.mm:
1235         (+[WebStorageManager _storageDirectoryPath]):
1236         (initializeLocalStoragePath): Deleted.
1237
1238 2017-12-07  Darin Adler  <darin@apple.com>
1239
1240         Remove some unused code from WebKitLegacy
1241         https://bugs.webkit.org/show_bug.cgi?id=180567
1242
1243         Reviewed by Anders Carlsson.
1244
1245         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1246         macOS (back a few versions) and iOS and removed unused
1247         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1248         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1249         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1250         _webkit_stringByCollapsingNonPrintingCharacters,
1251         _webkit_stringByCollapsingWhitespaceCharacters,
1252         _web_stringWithData:textEncodingName:, and
1253         _webkit_localStorageDirectoryWithBundleIdentifier:.
1254
1255         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1256         this source file.
1257         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1258         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1259         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1260         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1261         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1262         handle font smoothing options.
1263         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1264         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1265         from header and made it a little clearer.
1266         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1267         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1268         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1269         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1270         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1271         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1272         implementation a bit and used whole words instead of abbreviations.
1273         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1274
1275         * Misc/WebNSFileManagerExtras.mm:
1276         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1277         filenameByFixingIllegalCharacters function from WebCore directly instead of
1278         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1279
1280         * Plugins/WebBaseNetscapePluginView.mm:
1281         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1282         string replacements instead of _web_stringByStrippingReturnCharacters
1283         and to use NSString methods instead of CFString functions.
1284
1285 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1286
1287         Ignore deprecation warnings.
1288
1289         * WebView/WebHTMLView.mm:
1290         (-[NSWindow _web_borderView]):
1291         (-[WebHTMLView _setAsideSubviews]):
1292         * WebView/WebView.mm:
1293         (-[WebView encodeWithCoder:]):
1294
1295 2017-12-02  Darin Adler  <darin@apple.com>
1296
1297         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1298         https://bugs.webkit.org/show_bug.cgi?id=180009
1299
1300         Reviewed by Alex Christensen.
1301
1302         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1303
1304         * Plugins/WebBaseNetscapePluginView.mm:
1305         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1306         of strcasecmp.
1307
1308         * WebView/WebPreferences.mm:
1309         (contains): Ditto. Also made this a template so it's easier to call on an array.
1310         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1311
1312 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1313
1314         Limit user agent versioning to an upper bound
1315         https://bugs.webkit.org/show_bug.cgi?id=180365
1316         <rdar://problem/34550617>
1317
1318         Reviewed by Joseph Pecoraro.
1319
1320         * WebView/WebView.mm:
1321         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1322         creating the User Agent string.
1323         (webKitBundleVersionString): Deleted.
1324
1325 2017-12-05  Andy Estes  <aestes@apple.com>
1326
1327         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1328         https://bugs.webkit.org/show_bug.cgi?id=180457
1329         <rdar://problem/35143007>
1330
1331         Reviewed by Tim Horton.
1332
1333         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1334         check for this macro during post-processing.
1335
1336         * postprocess-headers.sh:
1337
1338 2017-12-04  David Quesada  <david_quesada@apple.com>
1339
1340         Add a class for parsing application manifests
1341         https://bugs.webkit.org/show_bug.cgi?id=177973
1342         rdar://problem/34747949
1343
1344         Reviewed by Geoffrey Garen.
1345
1346         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1347
1348 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1349
1350         Make LegacyCustomProtocolManager optional for network process
1351         https://bugs.webkit.org/show_bug.cgi?id=176230
1352
1353         Reviewed by Alex Christensen.
1354
1355         * Configurations/FeatureDefines.xcconfig:
1356
1357 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1358
1359         Fix some NSOperationQueue leaks
1360         https://bugs.webkit.org/show_bug.cgi?id=180221
1361
1362         Reviewed by Wenson Hsieh.
1363
1364         * WebView/WebView.mm:
1365         (-[WebView performDragOperation:]):
1366
1367 2017-11-30  Darin Adler  <darin@apple.com>
1368
1369         [Mac] remove unneeded RetainPtr use introduced in r225142
1370         https://bugs.webkit.org/show_bug.cgi?id=180202
1371
1372         Reviewed by Tim Horton.
1373
1374         * WebView/WebImmediateActionController.mm:
1375         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1376         RetainPtr.
1377
1378 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1379
1380         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1381         https://bugs.webkit.org/show_bug.cgi?id=175595
1382
1383         Reviewed by Darin Adler.
1384
1385         * WebView/WebPreferences.mm:
1386
1387 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1388
1389         One too many zeroes in macOS version number in FeatureDefines
1390         https://bugs.webkit.org/show_bug.cgi?id=180011
1391
1392         Reviewed by Dan Bernstein.
1393
1394         * Configurations/FeatureDefines.xcconfig:
1395
1396 2017-11-23  Darin Adler  <darin@apple.com>
1397
1398         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1399         https://bugs.webkit.org/show_bug.cgi?id=179981
1400
1401         Reviewed by Sam Weinig.
1402
1403         * WebView/WebImmediateActionController.mm:
1404         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1405         * WebView/WebView.mm:
1406         (coreOptions): Use |= instead of | to build up FindOptions.
1407
1408 2017-11-23  Sam Weinig  <sam@webkit.org>
1409
1410         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1411         https://bugs.webkit.org/show_bug.cgi?id=179954
1412
1413         Reviewed by Darin Adler.
1414
1415         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1416         with direct calls to the corresponding UserGestureIndicator functions.
1417
1418         * Plugins/WebPluginController.mm:
1419         (-[WebPluginController processingUserGesture]):
1420         * WebView/WebView.mm:
1421         (-[WebView _isProcessingUserGesture]):
1422
1423 2017-11-23  Darin Adler  <darin@apple.com>
1424
1425         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1426         https://bugs.webkit.org/show_bug.cgi?id=179907
1427
1428         Reviewed by Sam Weinig.
1429
1430         * History/BinaryPropertyList.cpp:
1431         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1432         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1433         * WebView/WebHTMLRepresentation.mm:
1434         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1435         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1436
1437 2017-11-22  Ali Juma  <ajuma@chromium.org>
1438
1439         Implement VisualViewport API attributes
1440         https://bugs.webkit.org/show_bug.cgi?id=179385
1441
1442         Reviewed by Frédéric Wang.
1443
1444         Add a VisualViewportAPI preference.
1445
1446         * WebView/WebPreferenceKeysPrivate.h:
1447         * WebView/WebPreferences.mm:
1448         (+[WebPreferences initialize]):
1449         (-[WebPreferences visualViewportAPIEnabled]):
1450         (-[WebPreferences setVisualViewportAPIEnabled:]):
1451         * WebView/WebPreferencesPrivate.h:
1452         * WebView/WebView.mm:
1453         (-[WebView _preferencesChanged:]):
1454
1455 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1456
1457         WebCoreObjCExtras.h is being included in too many places
1458         https://bugs.webkit.org/show_bug.cgi?id=179931
1459
1460         Reviewed by Darin Adler.
1461
1462         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1463         * Plugins/WebBaseNetscapePluginView.mm:
1464         * Plugins/WebBasePluginPackage.mm:
1465         * Plugins/WebNetscapePluginStream.mm:
1466         * Plugins/WebNetscapePluginView.mm:
1467         * WebView/WebTextIterator.mm:
1468         * WebView/WebViewData.mm:
1469
1470 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1471
1472         Unreviewed, rolling out r225093.
1473         https://bugs.webkit.org/show_bug.cgi?id=179938
1474
1475         Compilation failed on WinCairo 64-bit Release (Requested by
1476         fredw on #webkit).
1477
1478         Reverted changeset:
1479
1480         "Implement VisualViewport API attributes"
1481         https://bugs.webkit.org/show_bug.cgi?id=179385
1482         https://trac.webkit.org/changeset/225093
1483
1484 2017-11-21  Ali Juma  <ajuma@chromium.org>
1485
1486         Implement VisualViewport API attributes
1487         https://bugs.webkit.org/show_bug.cgi?id=179385
1488
1489         Reviewed by Frédéric Wang.
1490
1491         Add a VisualViewportAPI preference.
1492
1493         * WebView/WebPreferenceKeysPrivate.h:
1494         * WebView/WebPreferences.mm:
1495         (+[WebPreferences initialize]):
1496         (-[WebPreferences visualViewportAPIEnabled]):
1497         (-[WebPreferences setVisualViewportAPIEnabled:]):
1498         * WebView/WebPreferencesPrivate.h:
1499         * WebView/WebView.mm:
1500         (-[WebView _preferencesChanged:]):
1501
1502 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1503
1504         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1505         https://bugs.webkit.org/show_bug.cgi?id=179504
1506
1507         Reviewed by Darin Adler.
1508
1509         * Misc/WebKitNSStringExtras.mm:
1510         * Plugins/Hosted/NetscapePluginHostManager.mm:
1511         * Plugins/WebBasePluginPackage.mm:
1512
1513 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1514
1515         Remove unused TOUCH_ICON_LOADING feature flag
1516         https://bugs.webkit.org/show_bug.cgi?id=179873
1517
1518         Reviewed by Simon Fraser.
1519
1520         * Configurations/FeatureDefines.xcconfig:
1521
1522 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1523
1524         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1525         https://bugs.webkit.org/show_bug.cgi?id=179872
1526
1527         Reviewed by Darin Adler.
1528
1529         * Configurations/FeatureDefines.xcconfig:
1530
1531 2017-11-16  Daniel Bates  <dabates@apple.com>
1532
1533         Add feature define for alternative presentation button element
1534         https://bugs.webkit.org/show_bug.cgi?id=179692
1535         Part of <rdar://problem/34917108>
1536
1537         Reviewed by Andy Estes.
1538
1539         Only enabled on Cocoa platforms by default.
1540
1541         * Configurations/FeatureDefines.xcconfig:
1542
1543 2017-11-14  Nan Wang  <n_wang@apple.com>
1544
1545         AX: AOM: Implement AccessibleNode class and support label and role attributes
1546         https://bugs.webkit.org/show_bug.cgi?id=179494
1547
1548         Reviewed by Ryosuke Niwa.
1549
1550         * WebView/WebPreferenceKeysPrivate.h:
1551         * WebView/WebPreferences.mm:
1552         (+[WebPreferences initialize]):
1553         (-[WebPreferences accessibilityObjectModelEnabled]):
1554         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1555         * WebView/WebPreferencesPrivate.h:
1556         * WebView/WebView.mm:
1557         (-[WebView _preferencesChanged:]):
1558
1559 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1560
1561         Remove Cocoa CFURLConnection loading code
1562         https://bugs.webkit.org/show_bug.cgi?id=179688
1563
1564         Reviewed by Antti Koivisto.
1565
1566         * Misc/WebDownload.mm:
1567         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1568         * Misc/WebDownloadInternal.h:
1569         * Plugins/WebBaseNetscapePluginView.mm:
1570         * WebCoreSupport/WebFrameLoaderClient.mm:
1571         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1572         * WebView/WebView.mm:
1573         (-[WebView scheduleInRunLoop:forMode:]):
1574         (-[WebView unscheduleFromRunLoop:forMode:]):
1575
1576 2017-11-14  Daniel Bates  <dabates@apple.com>
1577
1578         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1579         for feature defines
1580
1581         Following r195498 and r201917 the Visual Studio property files for feature defines have
1582         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1583         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1584         files.
1585
1586         * Configurations/FeatureDefines.xcconfig:
1587
1588 2017-11-14  Jer Noble  <jer.noble@apple.com>
1589
1590         Enable Modern EME tests in DumpRenderTree
1591         https://bugs.webkit.org/show_bug.cgi?id=179544
1592
1593         Reviewed by Alex Christensen.
1594
1595         Add a WebPreferences property to enable the (modern) EME API.
1596
1597         * WebView/WebPreferenceKeysPrivate.h:
1598         * WebView/WebPreferences.mm:
1599         (+[WebPreferences initialize]):
1600         (-[WebPreferences encryptedMediaAPIEnabled]):
1601         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1602         * WebView/WebPreferencesPrivate.h:
1603         * WebView/WebView.mm:
1604         (-[WebView _preferencesChanged:]):
1605
1606 2017-11-14  Antti Koivisto  <antti@apple.com>
1607
1608         Enable display:contents by default
1609         https://bugs.webkit.org/show_bug.cgi?id=179655
1610
1611         Reviewed by Sam Weinig.
1612
1613         * WebView/WebPreferences.mm:
1614         (+[WebPreferences initialize]):
1615
1616 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1617
1618         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1619         https://bugs.webkit.org/show_bug.cgi?id=178751
1620
1621         Reviewed by Brady Eidson.
1622
1623         * WebCoreSupport/WebFrameNetworkingContext.mm:
1624         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1625
1626 2017-11-08  Keith Miller  <keith_miller@apple.com>
1627
1628         Async iteration should only fetch the next method once and add feature flag
1629         https://bugs.webkit.org/show_bug.cgi?id=179451
1630
1631         Reviewed by Geoffrey Garen.
1632
1633         Add feature flag for Async iteration.
1634
1635         * Configurations/FeatureDefines.xcconfig:
1636
1637 2017-11-13  Mark Lam  <mark.lam@apple.com>
1638
1639         Add more overflow check book-keeping for MarkedArgumentBuffer.
1640         https://bugs.webkit.org/show_bug.cgi?id=179634
1641         <rdar://problem/35492517>
1642
1643         Reviewed by Saam Barati.
1644
1645         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1646         (WebKit::NetscapePluginInstanceProxy::invoke):
1647         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1648         (WebKit::NetscapePluginInstanceProxy::construct):
1649
1650 2017-11-12  Darin Adler  <darin@apple.com>
1651
1652         More is<> and downcast<>, less static_cast<>
1653         https://bugs.webkit.org/show_bug.cgi?id=179600
1654
1655         Reviewed by Chris Dumez.
1656
1657         * DOM/DOM.mm:
1658         (kit): Use is/downcast.
1659         * WebCoreSupport/WebEditorClient.mm:
1660         (WebEditorClient::handleKeyboardEvent): Ditto.
1661         (WebEditorClient::handleInputMethodKeydown): Ditto.
1662         * WebView/WebHTMLView.mm:
1663         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1664
1665 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1666
1667         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1668         https://bugs.webkit.org/show_bug.cgi?id=179397
1669
1670         Reviewed by Wenson Hsieh.
1671
1672         * DOM/DOMHTMLInputElement.mm:
1673         (-[DOMHTMLInputElement insertTextSuggestion:]):
1674
1675 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1676
1677         HTMLMediaElement should not use element fullscreen on iOS
1678         https://bugs.webkit.org/show_bug.cgi?id=179418
1679         rdar://problem/35409277
1680
1681         Reviewed by Eric Carlson.
1682
1683         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1684
1685         * Configurations/FeatureDefines.xcconfig:
1686
1687 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1688
1689         Make ResourceLoader::willSendRequestInternal asynchronous
1690         https://bugs.webkit.org/show_bug.cgi?id=179251
1691
1692         Reviewed by Andy Estes.
1693
1694         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1695         (WebKit::HostedNetscapePluginStream::start):
1696         * Plugins/WebNetscapePluginStream.mm:
1697         (WebNetscapePluginStream::start):
1698
1699 2017-11-01  Darin Adler  <darin@apple.com>
1700
1701         Simplify event dispatch code and make it a bit more consistent
1702         https://bugs.webkit.org/show_bug.cgi?id=178991
1703
1704         Reviewed by Chris Dumez.
1705
1706         * DOM/DOMEvent.mm:
1707         (-[DOMEvent srcElement]): Call target instead of srcElement.
1708
1709 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1710
1711         [Touch Bar Web API] Add support for menuitem tag
1712         https://bugs.webkit.org/show_bug.cgi?id=179020
1713
1714         Reviewed by Ryosuke Niwa.
1715
1716         Adds in properties and methods that allow the menuitem runtime feature
1717         to be enabled or disabled.
1718
1719         * WebView/WebPreferenceKeysPrivate.h:
1720         * WebView/WebPreferences.mm:
1721         (-[WebPreferences menuItemElementEnabled]):
1722         (-[WebPreferences setMenuItemElementEnabled:]):
1723         * WebView/WebPreferencesPrivate.h:
1724         * WebView/WebView.mm:
1725         (-[WebView _preferencesChanged:]):
1726
1727 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1728
1729         Use CompletionHandlers for redirects
1730         https://bugs.webkit.org/show_bug.cgi?id=179163
1731
1732         Reviewed by Tim Horton.
1733
1734         * Plugins/Hosted/HostedNetscapePluginStream.h:
1735         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1736         (WebKit::HostedNetscapePluginStream::willSendRequest):
1737         * Plugins/WebNetscapePluginStream.h:
1738         * Plugins/WebNetscapePluginStream.mm:
1739         (WebNetscapePluginStream::willSendRequest):
1740
1741 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1742
1743         Add a FileSystem namespace to FileSystem.cpp
1744         https://bugs.webkit.org/show_bug.cgi?id=179063
1745
1746         Reviewed by Darin Adler.
1747
1748         * Misc/WebNSFileManagerExtras.mm:
1749         * Storage/WebDatabaseProvider.mm:
1750
1751 2017-11-02  Frederic Wang  <fwang@igalia.com>
1752
1753         Add references to bug 179167 in FIXME comments
1754         https://bugs.webkit.org/show_bug.cgi?id=179168
1755
1756         Reviewed by Daniel Bates.
1757
1758         * Configurations/FeatureDefines.xcconfig:
1759
1760 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1761
1762         Implement WKFullscreenWindowController for iOS.
1763         https://bugs.webkit.org/show_bug.cgi?id=178924
1764         rdar://problem/34697120
1765
1766         Reviewed by Simon Fraser.
1767
1768         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1769
1770         * Configurations/FeatureDefines.xcconfig:
1771         * WebView/WebView.mm:
1772         (-[WebView fullScreenPlaceholderView]):
1773
1774 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1775
1776         Clean up some drag and drop feature flags
1777         https://bugs.webkit.org/show_bug.cgi?id=179082
1778
1779         Reviewed by Simon Fraser.
1780
1781         * Configurations/FeatureDefines.xcconfig:
1782
1783 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1784
1785         Make it possible to test rubber-banding in overflow scroll
1786         https://bugs.webkit.org/show_bug.cgi?id=179078
1787
1788         Reviewed by Sam Weinig.
1789
1790         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1791         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1792
1793         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1794         functions, since most callers want clamped.
1795
1796         * DOM/DOMHTML.mm:
1797         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1798
1799 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1800
1801         Fix up some content filtering feature flags
1802         https://bugs.webkit.org/show_bug.cgi?id=179079
1803
1804         Reviewed by Simon Fraser.
1805
1806         * Configurations/FeatureDefines.xcconfig:
1807
1808 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1809
1810         [FrameView::layout cleanup] Move core layout logic to a separate class.
1811         https://bugs.webkit.org/show_bug.cgi?id=178771
1812         <rdar://problem/35166542>
1813
1814         Reviewed by Simon Fraser.
1815
1816         Move layout code out from FrameView to LayoutContext.
1817
1818         * WebView/WebClipView.mm:
1819         (-[WebClipView _immediateScrollToPoint:]):
1820         * WebView/WebFrame.mm:
1821         (-[WebFrame layoutCount]):
1822
1823 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1824
1825         Fix issues with WebView subframe painting
1826         https://bugs.webkit.org/show_bug.cgi?id=178842
1827         rdar://problem/34072253
1828
1829         Reviewed by Daniel Bates.
1830         
1831         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1832         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1833         High Sierra, so match the new signature.
1834
1835         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1836
1837         * WebView/WebHTMLView.mm:
1838         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1839         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1840
1841 2017-10-25  Youenn Fablet  <youenn@apple.com>
1842
1843         Enable ServiceWorker to fetch resources
1844         https://bugs.webkit.org/show_bug.cgi?id=178673
1845
1846         Reviewed by Brady Eidson.
1847
1848         * WebCoreSupport/WebFrameLoaderClient.mm:
1849         (WebFrameLoaderClient::pageID const):
1850         (WebFrameLoaderClient::frameID const):
1851         (WebFrameLoaderClient::sessionID const):
1852
1853         Added implementation to the new getters.
1854         They are noop in the context of WK1.
1855
1856 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1857
1858         Web Inspector: Enable WebKit logging configuration and display
1859         https://bugs.webkit.org/show_bug.cgi?id=177027
1860         <rdar://problem/33964767>
1861
1862         Reviewed by Joseph Pecoraro.
1863
1864         * WebCoreSupport/WebChromeClient.mm:
1865         (stringForMessageSource): Deal with Media and WebRTC message sources.
1866
1867 2017-10-20  Antoine Quint  <graouts@apple.com>
1868
1869         [Web Animations] Provide basic timeline and animation interfaces
1870         https://bugs.webkit.org/show_bug.cgi?id=178526
1871
1872         Reviewed by Dean Jackson.
1873
1874         Remove the WEB_ANIMATIONS compile-time flag.
1875
1876         * Configurations/FeatureDefines.xcconfig:
1877         * WebView/WebPreferences.mm:
1878         (+[WebPreferences initialize]):
1879         * WebView/WebView.mm:
1880         (-[WebView _preferencesChanged:]):
1881
1882 2017-10-19  Sam Weinig  <sam@webkit.org>
1883
1884         [Settings] Move global settings into their own file
1885         https://bugs.webkit.org/show_bug.cgi?id=178512
1886
1887         Reviewed by Darin Adler.
1888
1889         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1890
1891         * WebCoreSupport/WebChromeClient.mm:
1892         (WebChromeClient::supportsVideoFullscreen):
1893         * WebView/WebDynamicScrollBarsView.mm:
1894         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1895         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1896         * WebView/WebPreferences.mm:
1897         (+[WebPreferences initialize]):
1898         * WebView/WebView.mm:
1899         (-[WebView _commonInitializationWithFrameName:groupName:]):
1900         (-[WebView _preferencesChanged:]):
1901         (+[WebView _doNotStartObservingNetworkReachability]):
1902
1903 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1904
1905         Replace some stack raw pointers with RefPtrs within WebCore/html
1906         https://bugs.webkit.org/show_bug.cgi?id=178201
1907         <rdar://problem/34841692>
1908
1909         Reviewed by Ryosuke Niwa.
1910
1911         * DOM/DOM.mm:
1912         (kit):
1913         Change the type of node as toNode() is changed to return RefPtr.
1914
1915 2017-10-18  Chris Dumez  <cdumez@apple.com>
1916
1917         [Service Worker] Add stubs for Client / WindowClient / Clients
1918         https://bugs.webkit.org/show_bug.cgi?id=178469
1919
1920         Reviewed by Youenn Fablet.
1921
1922         Rename PageVisiblityState to VisibilityState.
1923
1924         * WebView/WebView.mm:
1925         (kit):
1926
1927 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1928
1929         Unreviewed, rolling out r223291.
1930
1931         See WebCore ChangeLog for more detail.
1932
1933         Reverted changeset:
1934
1935         "Remove Editor::simplifyMarkup"
1936         https://bugs.webkit.org/show_bug.cgi?id=178271
1937         https://trac.webkit.org/changeset/223291
1938
1939 2017-10-17  Keith Miller  <keith_miller@apple.com>
1940
1941         Change WebCore sources to work with unified source builds
1942         https://bugs.webkit.org/show_bug.cgi?id=178229
1943
1944         Rubber stamped by Tim Horton.
1945
1946         * Configurations/FeatureDefines.xcconfig:
1947
1948 2017-10-16  Sam Weinig  <sam@webkit.org>
1949
1950         [Settings] Remove all custom code from Settings.h/cpp
1951         https://bugs.webkit.org/show_bug.cgi?id=178330
1952
1953         Reviewed by Simon Fraser.
1954
1955         * WebView/WebPreferences.mm:
1956         (+[WebPreferences initialize]):
1957         
1958             Update for naming changes of FrameFlattening now that it is an enum class.
1959
1960 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1961
1962         Remove Editor::simplifyMarkup
1963         https://bugs.webkit.org/show_bug.cgi?id=178271
1964
1965         Reviewed by Wenson Hsieh.
1966
1967         * WebView/WebView.mm:
1968         (-[WebView _simplifyMarkup:endNode:]):
1969
1970 2017-10-12  Chris Dumez  <cdumez@apple.com>
1971
1972         [Mac] Add support for MouseEvent.buttons
1973         https://bugs.webkit.org/show_bug.cgi?id=178214
1974
1975         Reviewed by Ryosuke Niwa.
1976
1977         * WebView/WebPDFView.mm:
1978         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1979
1980 2017-10-11  Sam Weinig  <sam@webkit.org>
1981
1982         Remove out-parameter variants of copyToVector
1983         https://bugs.webkit.org/show_bug.cgi?id=178155
1984
1985         Reviewed by Tim Horton.
1986
1987         * Plugins/WebNetscapePluginView.mm:
1988         (-[WebNetscapePluginView destroyPlugin]):
1989         * WebView/WebHTMLRepresentation.mm:
1990         (newArrayWithStrings):
1991
1992             Replace out-parameter based copyToVector, with one that returns a Vector.
1993
1994 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1995
1996         Sanitize URL in pasteboard for other applications and cross origin content
1997         https://bugs.webkit.org/show_bug.cgi?id=178060
1998         <rdar://problem/34874518>
1999
2000         Reviewed by Wenson Hsieh.
2001
2002         * WebCoreSupport/WebPlatformStrategies.h:
2003         * WebCoreSupport/WebPlatformStrategies.mm:
2004         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2005
2006 2017-10-11  Chris Dumez  <cdumez@apple.com>
2007
2008         Modernize Geolocation code
2009         https://bugs.webkit.org/show_bug.cgi?id=178148
2010
2011         Reviewed by Ryosuke Niwa.
2012
2013         * WebCoreSupport/WebGeolocationClient.h:
2014         * WebCoreSupport/WebGeolocationClient.mm:
2015         (WebGeolocationClient::lastPosition):
2016         * WebView/WebGeolocationPosition.mm:
2017         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2018         (core):
2019         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2020         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2021         * WebView/WebGeolocationPositionInternal.h:
2022
2023 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2024
2025         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2026         https://bugs.webkit.org/show_bug.cgi?id=178154
2027
2028         Reviewed by Wenson Hsieh.
2029
2030         Enable custom pasteboard data by default.
2031
2032         * WebView/WebPreferenceKeysPrivate.h:
2033         * WebView/WebPreferences.mm:
2034         (+[WebPreferences initialize]):
2035         (-[WebPreferences customPasteboardDataEnabled]): Added.
2036         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2037         * WebView/WebPreferencesPrivate.h:
2038         * WebView/WebView.mm:
2039         (-[WebView _preferencesChanged:]):
2040
2041 2017-10-10  Sam Weinig  <sam@webkit.org>
2042
2043         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2044         https://bugs.webkit.org/show_bug.cgi?id=178102
2045
2046         Reviewed by Tim Horton.
2047
2048         * History/WebHistory.mm:
2049         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2050         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2051         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2052         * WebCoreSupport/WebUserMediaClient.mm:
2053         (WebUserMediaClient::pageDestroyed):
2054
2055 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2056
2057         Make the names of the options consistent
2058         https://bugs.webkit.org/show_bug.cgi?id=177933
2059
2060         Reviewed by Saam Barati.
2061
2062         * WebView/WebFrame.h:
2063         * WebView/WebHTMLView.mm:
2064         (-[WebHTMLView setMarkedText:selectedRange:]):
2065         * WebView/WebView.h:
2066
2067 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2068
2069         [iOS] Tweak support for classifying form controls (followup to r222487)
2070         https://bugs.webkit.org/show_bug.cgi?id=177917
2071         <rdar://problem/34820122>
2072
2073         Reviewed by Dean Jackson.
2074
2075         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2076
2077         * DOM/DOMHTMLInputElement.mm:
2078         (-[DOMHTMLInputElement _autofillContext]):
2079         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2080         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2081
2082 2017-10-05  Keith Miller  <keith_miller@apple.com>
2083
2084         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2085
2086         * Configurations/WebKitLegacy.xcconfig:
2087
2088 2017-10-05  Jer Noble  <jer.noble@apple.com>
2089
2090         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2091         https://bugs.webkit.org/show_bug.cgi?id=177261
2092
2093         Reviewed by Eric Carlson.
2094
2095         * Configurations/FeatureDefines.xcconfig:
2096
2097 2017-10-05  Chris Dumez  <cdumez@apple.com>
2098
2099         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2100         https://bugs.webkit.org/show_bug.cgi?id=177957
2101
2102         Reviewed by Alex Christensen.
2103
2104         * WebCoreSupport/WebPlatformStrategies.h:
2105         * WebCoreSupport/WebPlatformStrategies.mm:
2106         (WebPlatformStrategies::cookiesEnabled):
2107
2108 2017-10-05  Youenn Fablet  <youenn@apple.com>
2109
2110         Make LibWebRTCProvider port agnostic
2111         https://bugs.webkit.org/show_bug.cgi?id=177747
2112
2113         Reviewed by Alex Christensen & Alex Garcia.
2114
2115         * WebView/WebView.mm:
2116         (-[WebView _commonInitializationWithFrameName:groupName:]):
2117         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2118
2119 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2120
2121         Stop linking with WebKitSystemInterface
2122         https://bugs.webkit.org/show_bug.cgi?id=177915
2123
2124         Reviewed by Antti Koivisto.
2125
2126         * Configurations/DebugRelease.xcconfig:
2127         * Configurations/WebKitLegacy.xcconfig:
2128
2129 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2130
2131         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2132         https://bugs.webkit.org/show_bug.cgi?id=177912
2133
2134         Reviewed by Saam Barati.
2135
2136         * Carbon/CarbonUtils.m:
2137         * Carbon/CarbonWindowAdapter.mm:
2138         * Carbon/HIWebView.mm:
2139         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2140         * Misc/WebNSFileManagerExtras.mm:
2141         * Misc/WebNSPasteboardExtras.mm:
2142         * Misc/WebNSURLExtras.mm:
2143         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2144         * Plugins/Hosted/NetscapePluginHostManager.mm:
2145         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2146         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2147         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2148         * Plugins/Hosted/WebTextInputWindowController.m:
2149         * Plugins/WebBaseNetscapePluginView.mm:
2150         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2151         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2152         * Plugins/WebNetscapePluginStream.mm:
2153         * Plugins/WebNetscapePluginView.mm:
2154         * Plugins/WebPluginDatabase.mm:
2155         * WebCoreSupport/PopupMenuMac.mm:
2156         * WebCoreSupport/WebChromeClient.mm:
2157         * WebCoreSupport/WebFrameLoaderClient.mm:
2158         * WebCoreSupport/WebInspectorClient.mm:
2159         * WebCoreSupport/WebPlatformStrategies.mm:
2160         * WebCoreSupport/WebSystemInterface.mm:
2161         * WebView/WebDynamicScrollBarsView.mm:
2162         * WebView/WebFrame.mm:
2163         * WebView/WebFrameView.mm:
2164         * WebView/WebFullScreenController.mm:
2165         * WebView/WebHTMLView.mm:
2166         * WebView/WebPreferences.mm:
2167         * WebView/WebView.mm:
2168
2169 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2170
2171         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2172         rdar://problem/34705779
2173
2174         Addressing review comments that I somehow landed without.
2175
2176         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2177
2178 2017-09-29  Chris Dumez  <cdumez@apple.com>
2179
2180         Split some logic out of VisitedLinkStore and make it reusable
2181         https://bugs.webkit.org/show_bug.cgi?id=177575
2182
2183         Reviewed by Alex Christensen.
2184
2185         * WebCoreSupport/WebVisitedLinkStore.h:
2186         * WebCoreSupport/WebVisitedLinkStore.mm:
2187         (WebVisitedLinkStore::addVisitedLink):
2188         (WebVisitedLinkStore::removeVisitedLink):
2189         (WebVisitedLinkStore::isLinkVisited):
2190         (WebVisitedLinkStore::addVisitedLinkHash):
2191
2192 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2193
2194         Build fix for High Sierra 32 bit Mac
2195         https://bugs.webkit.org/show_bug.cgi?id=177551
2196         <rdar://problem/34690283>
2197
2198         Reviewed by Alexey Proskuryakov.
2199
2200         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2201         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2202         also made.
2203
2204         * Carbon/CarbonWindowAdapter.mm:
2205         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2206         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2207         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2208         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2209         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2210         (-[CarbonWindowAdapter dealloc]):
2211         (-[CarbonWindowAdapter windowRef]):
2212         (-[CarbonWindowAdapter _hasWindowRef]):
2213         (-[CarbonWindowAdapter _managesWindowRef]):
2214         (-[CarbonWindowAdapter _removeWindowRef]):
2215         (-[CarbonWindowAdapter _carbonWindowClass]):
2216         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2217         (-[CarbonWindowAdapter sendSuperEvent:]):
2218         (-[CarbonWindowAdapter relinquishFocus]):
2219         (-[CarbonWindowAdapter _cancelKey:]):
2220         (-[CarbonWindowAdapter _commonAwake]):
2221         (-[CarbonWindowAdapter _destroyRealWindow:]):
2222         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2223         (-[CarbonWindowAdapter _termWindowIfOwner]):
2224         (-[CarbonWindowAdapter _windowMovedToRect:]):
2225         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2226         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2227         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2228         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2229         (-[CarbonWindowAdapter canBecomeMainWindow]):
2230         (-[CarbonWindowAdapter encodeWithCoder:]):
2231         (-[CarbonWindowAdapter initWithCoder:]):
2232         (-[CarbonWindowAdapter setContentView:]):
2233         (-[CarbonWindowAdapter worksWhenModal]):
2234         (-[CarbonWindowAdapter _setModalWindowLevel]):
2235         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2236         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2237         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2238         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2239         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2240         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2241         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2242         (NSCarbonWindowHandleEvent):
2243         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2244         (-[CarbonWindowAdapter _growBoxRect]):
2245         * Carbon/HIWebView.mm:
2246         (HIWebViewGetWebView):
2247         (HIWebViewConstructor):
2248         (HIWebViewDestructor):
2249         (HIWebViewRegisterClass):
2250         (GetBehaviors):
2251         (Draw):
2252         (HitTest):
2253         (GetRegion):
2254         (GetWindowRef):
2255         (CreateNSEventAdoptingCGEvent):
2256         (CopyEventCGEvent):
2257         (CreateNSEventWithCarbonClickEvent):
2258         (Click):
2259         (CreateNSEventWithCarbonEvent):
2260         (MouseUp):
2261         (CreateNSEventWithCarbonMouseMoveEvent):
2262         (MouseMoved):
2263         (MouseDragged):
2264         (MouseWheelMoved):
2265         (ContextMenuClick):
2266         (GetKind):
2267         (BoundsChanged):
2268         (OwningWindowChanged):
2269         (WindowHandler):
2270         (SyncFrame):
2271         (SetFocusPart):
2272         (AdvanceFocus):
2273         (RelinquishFocus):
2274         (ActiveStateChanged):
2275         (ProcessCommand):
2276         (UpdateCommandStatus):
2277         (_NSSelectorForHICommand):
2278         (HIWebViewEventHandler):
2279         (StartUpdateObserver):
2280         (StopUpdateObserver):
2281         (UpdateObserver):
2282
2283 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2284
2285         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2286         https://bugs.webkit.org/show_bug.cgi?id=172526
2287         <rdar://problem/32396081>
2288
2289         Reviewed by Ryosuke Niwa.
2290
2291         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2292
2293         * WebCoreSupport/WebPlatformStrategies.h:
2294         * WebCoreSupport/WebPlatformStrategies.mm:
2295         (WebPlatformStrategies::webExposedTypes):
2296         (WebPlatformStrategies::writeCustomData):
2297
2298 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2299
2300         Unreviewed, rolling out r222567.
2301
2302         This broke and internal build.
2303
2304         Reverted changeset:
2305
2306         "Build fix for High Sierra 32 bit Mac"
2307         https://bugs.webkit.org/show_bug.cgi?id=177551
2308         http://trac.webkit.org/changeset/222567
2309
2310 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2311
2312         Build fix for High Sierra 32 bit Mac
2313         https://bugs.webkit.org/show_bug.cgi?id=177551
2314         <rdar://problem/34690283>
2315
2316         Reviewed by Alexey Proskuryakov.
2317
2318         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2319         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2320         also made.
2321
2322         * Carbon/CarbonWindowAdapter.mm:
2323         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2324         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2325         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2326         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2327         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2328         (-[CarbonWindowAdapter dealloc]):
2329         (-[CarbonWindowAdapter windowRef]):
2330         (-[CarbonWindowAdapter _hasWindowRef]):
2331         (-[CarbonWindowAdapter _managesWindowRef]):
2332         (-[CarbonWindowAdapter _removeWindowRef]):
2333         (-[CarbonWindowAdapter _carbonWindowClass]):
2334         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2335         (-[CarbonWindowAdapter sendSuperEvent:]):
2336         (-[CarbonWindowAdapter relinquishFocus]):
2337         (-[CarbonWindowAdapter _cancelKey:]):
2338         (-[CarbonWindowAdapter _commonAwake]):
2339         (-[CarbonWindowAdapter _destroyRealWindow:]):
2340         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2341         (-[CarbonWindowAdapter _termWindowIfOwner]):
2342         (-[CarbonWindowAdapter _windowMovedToRect:]):
2343         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2344         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2345         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2346         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2347         (-[CarbonWindowAdapter canBecomeMainWindow]):
2348         (-[CarbonWindowAdapter encodeWithCoder:]):
2349         (-[CarbonWindowAdapter initWithCoder:]):
2350         (-[CarbonWindowAdapter setContentView:]):
2351         (-[CarbonWindowAdapter worksWhenModal]):
2352         (-[CarbonWindowAdapter _setModalWindowLevel]):
2353         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2354         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2355         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2356         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2357         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2358         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2359         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2360         (NSCarbonWindowHandleEvent):
2361         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2362         (-[CarbonWindowAdapter _growBoxRect]):
2363         * Carbon/HIWebView.mm:
2364         (HIWebViewGetWebView):
2365         (HIWebViewConstructor):
2366         (HIWebViewDestructor):
2367         (HIWebViewRegisterClass):
2368         (GetBehaviors):
2369         (Draw):
2370         (HitTest):
2371         (GetRegion):
2372         (GetWindowRef):
2373         (CreateNSEventAdoptingCGEvent):
2374         (CopyEventCGEvent):
2375         (CreateNSEventWithCarbonClickEvent):
2376         (Click):
2377         (CreateNSEventWithCarbonEvent):
2378         (MouseUp):
2379         (CreateNSEventWithCarbonMouseMoveEvent):
2380         (MouseMoved):
2381         (MouseDragged):
2382         (MouseWheelMoved):
2383         (ContextMenuClick):
2384         (GetKind):
2385         (BoundsChanged):
2386         (OwningWindowChanged):
2387         (WindowHandler):
2388         (SyncFrame):
2389         (SetFocusPart):
2390         (AdvanceFocus):
2391         (RelinquishFocus):
2392         (ActiveStateChanged):
2393         (ProcessCommand):
2394         (UpdateCommandStatus):
2395         (_NSSelectorForHICommand):
2396         (HIWebViewEventHandler):
2397         (StartUpdateObserver):
2398         (StopUpdateObserver):
2399         (UpdateObserver):
2400
2401 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2402
2403         Make PolicyAction an encodable enum class
2404         https://bugs.webkit.org/show_bug.cgi?id=177480
2405
2406         Reviewed by Antti Koivisto.
2407
2408         * Plugins/WebPluginContainerCheck.mm:
2409         (-[WebPluginContainerCheck _continueWithPolicy:]):
2410         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2411         * WebCoreSupport/WebFrameLoaderClient.mm:
2412         (-[WebFramePolicyListener invalidate]):
2413         (-[WebFramePolicyListener ignore]):
2414         (-[WebFramePolicyListener download]):
2415         (-[WebFramePolicyListener use]):
2416         (-[WebFramePolicyListener continue]):
2417         * WebView/WebPolicyDelegate.mm:
2418         (-[WebPolicyDecisionListener use]):
2419         (-[WebPolicyDecisionListener ignore]):
2420         (-[WebPolicyDecisionListener download]):
2421
2422 2017-09-25  Frederik Riedel  <riedel@apple.com>
2423
2424         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2425         https://bugs.webkit.org/show_bug.cgi?id=174394
2426         <rdar://problem/33183504>
2427
2428         Reviewed by Ryosuke Niwa.
2429
2430         * DOM/DOMHTMLInputElement.h:
2431         * DOM/DOMHTMLInputElement.mm:
2432         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2433         Determines if this HTMLInputElement is part of a login screen.
2434         (-[DOMHTMLInputElement representingPageUrl]):
2435         Returns the webpage's URL that is currently displayed in the Web View.
2436         (-[DOMHTMLInputElement insertTextSuggestion:]):
2437         Inserts login credentials into the Web View.
2438
2439 2017-09-25  Sam Weinig  <sam@webkit.org>
2440
2441         Remove unused EditorClient functions
2442         https://bugs.webkit.org/show_bug.cgi?id=177463
2443
2444         Reviewed by Alex Christensen.
2445
2446         Remove unused EditorClient functions.
2447
2448         * WebCoreSupport/WebEditorClient.h:
2449         * WebCoreSupport/WebEditorClient.mm:
2450         (WebEditorClient::canonicalizeURL): Deleted.
2451         (WebEditorClient::canonicalizeURLString): Deleted.
2452         (WebEditorClient::writeDataToPasteboard): Deleted.
2453         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2454         (WebEditorClient::readDataFromPasteboard): Deleted.
2455         (WebEditorClient::pasteboardChangeCount): Deleted.
2456
2457 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2458
2459         Stop using PolicyCallback
2460         https://bugs.webkit.org/show_bug.cgi?id=176088
2461
2462         Reviewed by Andy Estes.
2463
2464         * WebCoreSupport/WebFrameLoaderClient.mm:
2465         (-[WebFramePolicyListener invalidate]):
2466         (-[WebFramePolicyListener receivedPolicyDecision:]):
2467
2468 2017-09-25  Sam Weinig  <sam@webkit.org>
2469
2470         Remove unnecessary userVisibleString EditorClient function
2471         https://bugs.webkit.org/show_bug.cgi?id=177456
2472
2473         Reviewed by Dan Bernstein.
2474
2475         * WebCoreSupport/WebEditorClient.h:
2476         * WebCoreSupport/WebEditorClient.mm:
2477         (WebEditorClient::userVisibleString): Deleted.
2478
2479             Remove userVisibleString client function.
2480
2481 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2482
2483         Separate form submission from PolicyChecker infrastructure
2484         https://bugs.webkit.org/show_bug.cgi?id=177396
2485
2486         Reviewed by Geoffrey Garen.
2487
2488         * WebCoreSupport/WebFrameLoaderClient.h:
2489         * WebCoreSupport/WebFrameLoaderClient.mm:
2490         (WebFrameLoaderClient::dispatchWillSubmitForm):
2491
2492 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2493
2494         WeakPtrFactory should populate m_ref lazily.
2495         https://bugs.webkit.org/show_bug.cgi?id=177375
2496
2497         Reviewed by Geoffrey Garen.
2498
2499         * WebCoreSupport/WebEditorClient.mm:
2500         (WebEditorClient::WebEditorClient):
2501         (WebEditorClient::requestCandidatesForSelection):
2502
2503 2017-09-22  Chris Dumez  <cdumez@apple.com>
2504
2505         Use high resolution timestamp for event time
2506         https://bugs.webkit.org/show_bug.cgi?id=154246
2507         <rdar://problem/34333304>
2508
2509         Reviewed by Ryosuke Niwa.
2510
2511         Use WallTime / MonotonicTime instead of double type for clarity.
2512
2513         * DOM/DOMEvent.mm:
2514         (-[DOMEvent timeStamp]):
2515         * WebView/WebFrame.mm:
2516         (-[WebFrame _dragSourceEndedAt:operation:]):
2517         * WebView/WebPDFView.mm:
2518         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2519
2520 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2521
2522         Enable dataTransfer.items on macOS and iOS
2523         https://bugs.webkit.org/show_bug.cgi?id=177335
2524
2525         Reviewed by Sam Weinig.
2526
2527         * WebView/WebPreferences.mm:
2528         (+[WebPreferences initialize]):
2529
2530 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2531
2532         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2533         https://bugs.webkit.org/show_bug.cgi?id=177101
2534         <rdar://problem/34500648>
2535
2536         Reviewed by Brian Burg.
2537
2538         * WebInspector/WebNodeHighlight.mm:
2539         Ensure we close the window that we have just removed.
2540
2541 2017-09-20  Antti Koivisto  <antti@apple.com>
2542
2543         Remove DOM and styling support for CSS Regions
2544         https://bugs.webkit.org/show_bug.cgi?id=177221
2545
2546         Reviewed by Andreas Kling.
2547
2548         * Configurations/FeatureDefines.xcconfig:
2549         * DOM/DOMCSS.mm:
2550         (kitClass):
2551         * DOM/DOMElement.mm:
2552         (-[DOMElement webkitRegionOverset]): Deleted.
2553
2554 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2555
2556         Layering violation in Editor::createFragment
2557         https://bugs.webkit.org/show_bug.cgi?id=176123
2558
2559         Reviewed by Darin Adler.
2560
2561         * Misc/WebNSURLExtras.h:
2562         * Misc/WebNSURLExtras.mm:
2563         * WebView/WebFrame.mm:
2564         * WebView/WebHTMLView.mm:
2565         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2566
2567         * WebCoreSupport/WebEditorClient.mm:
2568         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2569         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2570         way to avoid exporting the symbol just on newer OSes.
2571
2572 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2573
2574         On iOS, getData can't get text set by setData during copy event
2575         https://bugs.webkit.org/show_bug.cgi?id=176980
2576         <rdar://problem/34453915>
2577
2578         Reviewed by Darin Adler.
2579
2580         * WebCoreSupport/WebPlatformStrategies.h:
2581         * WebCoreSupport/WebPlatformStrategies.mm:
2582         (WebPlatformStrategies::copy): Deleted.
2583
2584 2017-09-18  Andy Estes  <aestes@apple.com>
2585
2586         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2587         https://bugs.webkit.org/show_bug.cgi?id=177029
2588
2589         Reviewed by Alex Christensen.
2590
2591         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2592         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2593         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2594         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2595         * WebCoreSupport/PopupMenuMac.mm:
2596         (PopupMenuMac::show):
2597         * WebCoreSupport/WebSystemInterface.mm:
2598         (InitWebCoreSystemInterface):
2599         * WebView/WebHTMLView.mm:
2600         (-[WebHTMLView setDataSource:]):
2601         (-[WebHTMLView attachRootLayer:]):
2602         * WebView/WebView.mm:
2603         (-[WebView _needsAdobeFrameReloadingQuirk]):
2604         (-[WebView _needsLinkElementTextCSSQuirk]):
2605         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2606         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2607         (-[WebView _preferencesChanged:]):
2608
2609 2017-09-15  Andy Estes  <aestes@apple.com>
2610
2611         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2612         https://bugs.webkit.org/show_bug.cgi?id=176953
2613
2614         Reviewed by Eric Carlson.
2615
2616         * WebCoreSupport/WebSystemInterface.mm:
2617         (InitWebCoreSystemInterface):
2618
2619 2017-09-14  Andy Estes  <aestes@apple.com>
2620
2621         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2622         https://bugs.webkit.org/show_bug.cgi?id=176931
2623
2624         Reviewed by Joseph Pecoraro.
2625
2626         * WebCoreSupport/WebSystemInterface.mm:
2627         (InitWebCoreSystemInterface):
2628
2629 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2630
2631         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2632         https://bugs.webkit.org/show_bug.cgi?id=176867
2633
2634         Reviewed by Sam Weinig.
2635
2636         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2637         (WebKit::NetscapePluginInstanceProxy::enumerate):
2638
2639 2017-09-13  Andy Estes  <aestes@apple.com>
2640
2641         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2642         https://bugs.webkit.org/show_bug.cgi?id=176729
2643
2644         Reviewed by Alex Christensen.
2645
2646         * WebCoreSupport/WebSystemInterface.mm:
2647         (InitWebCoreSystemInterface):
2648         * WebView/WebView.mm:
2649         (+[WebView _setCacheModel:]):
2650
2651 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2652
2653         Refactor WebContentReader out of EditorMac and EditorIOS
2654         https://bugs.webkit.org/show_bug.cgi?id=176770
2655
2656         Reviewed by Sam Weinig.
2657
2658         * WebCoreSupport/WebEditorClient.mm:
2659
2660 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2661
2662         Dragging & dropping a file creates an attachment element even when it's disabled
2663         https://bugs.webkit.org/show_bug.cgi?id=176769
2664
2665         Reviewed by Tim Horton.
2666
2667         * WebView/WebView.mm:
2668         (-[WebView _preferencesChanged:]):
2669
2670 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2671
2672         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2673         https://bugs.webkit.org/show_bug.cgi?id=176721
2674         <rdar://problem/34373660>
2675
2676         Reviewed by Tim Horton.
2677
2678         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2679         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2680
2681         * WebView/WebView.mm:
2682         (-[WebView _startDrag:]):
2683         (-[WebView _draggedElementBounds]):
2684         (-[WebView _endedDataInteraction:global:]):
2685         * WebView/WebViewData.h:
2686
2687 2017-09-11  Andy Estes  <aestes@apple.com>
2688
2689         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2690         https://bugs.webkit.org/show_bug.cgi?id=176472
2691
2692         Reviewed by Eric Carlson.
2693
2694         * WebCoreSupport/WebSystemInterface.mm:
2695         (InitWebCoreSystemInterface):
2696
2697 2017-09-09  Mark Lam  <mark.lam@apple.com>
2698
2699         Avoid duplicate computations of ExecState::vm().
2700         https://bugs.webkit.org/show_bug.cgi?id=176647
2701
2702         Reviewed by Saam Barati.
2703
2704         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2705         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2706         (WebKit::NetscapePluginInstanceProxy::construct):
2707         (WebKit::NetscapePluginInstanceProxy::setProperty):
2708         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2709         (WebKit::NetscapePluginInstanceProxy::enumerate):
2710         * Plugins/Hosted/ProxyInstance.mm:
2711         (WebKit::ProxyRuntimeMethod::create):
2712
2713 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2714
2715         Unreviewed, rolling out r221773.
2716         https://bugs.webkit.org/show_bug.cgi?id=176614
2717
2718         This caused build failures. (Requested by mlewis13 on
2719         #webkit).
2720
2721         Reverted changeset:
2722
2723         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2724         https://bugs.webkit.org/show_bug.cgi?id=176472
2725         http://trac.webkit.org/changeset/221773
2726
2727 2017-09-07  Andy Estes  <aestes@apple.com>
2728
2729         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2730         https://bugs.webkit.org/show_bug.cgi?id=176472
2731
2732         Reviewed by Eric Carlson.
2733
2734         * WebCoreSupport/WebSystemInterface.mm:
2735         (InitWebCoreSystemInterface):
2736
2737 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2738
2739         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2740         https://bugs.webkit.org/show_bug.cgi?id=176561
2741
2742         Reviewed by Brent Fulgham.
2743
2744         * Misc/WebNSUserDefaultsExtras.mm:
2745
2746 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2747
2748         Modernize Geolocation code
2749         https://bugs.webkit.org/show_bug.cgi?id=176496
2750
2751         Reviewed by Andy Estes.
2752
2753         * WebCoreSupport/WebGeolocationClient.h:
2754         * WebCoreSupport/WebGeolocationClient.mm:
2755         (WebGeolocationClient::requestPermission):
2756         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2757         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2758         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2759         * WebView/WebView.mm:
2760         (-[WebView _commonInitializationWithFrameName:groupName:]):
2761         (-[WebView _geolocationDidFailWithMessage:]):
2762
2763 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2764
2765         Remove some unused bits of code and resources
2766         https://bugs.webkit.org/show_bug.cgi?id=176275
2767
2768         Reviewed by Dan Bernstein.
2769
2770         * Misc/WebNSFileManagerExtras.mm:
2771         Include FileSystem instead of FileSystemIOS.
2772
2773 2017-09-03  Darin Adler  <darin@apple.com>
2774
2775         [Cocoa] Tidy a few things in legacy WebHTMLView
2776         https://bugs.webkit.org/show_bug.cgi?id=176280
2777
2778         Reviewed by Dan Bernstein.
2779
2780         * WebCoreSupport/WebChromeClient.mm:
2781         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2782         methods it calls on WebHTMLView were doing nothing on iOS.
2783
2784         * WebView/WebFrame.mm:
2785         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2786         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2787
2788         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2789         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2790         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2791         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2792         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2793         Use RetainPtr instead of writing retain/release wherever possible.
2794         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2795         initialization for it. Removed various unused methods and declarations of methods.
2796         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2797         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2798         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2799         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2800         and remove CFRetain no longer needed since we don't support garbage collection any more.
2801         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2802         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2803         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2804         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2805         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2806         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2807         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2808         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2809         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2810         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2811         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2812         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2813         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2814         debug flag; we haven't used it for years and it's not clearly helpful.
2815         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2816         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2817         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2818         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2819         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2820         two additional methods in the WebPrivate category and still be called by the two
2821         methods in the WebInternal category that were already using it.
2822         (-[WebHTMLView didAddSubview:]): Deleted.
2823         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2824         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2825         place this was called, the close method.
2826         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2827         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2828         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2829         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2830         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2831         Added helper method to make the one below simpler.
2832         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2833         Compared pasteboard type strings using isEqualToString: rather than using == since
2834         we want to actually compare the string contents. Also updated to use modern for loop,
2835         renamed a local variable from "s" to "localSubresources", and factored out the handling
2836         of three image types to use the helper method above.
2837         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2838         _web_makePluginSubviewsPerformSelector:withObject: method.
2839         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2840         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2841         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2842         not call the -[NSView subviews] method to make this identical on both platforms and used
2843         a modern for loop.
2844         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2845         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2846         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2847         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2848         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2849         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2850         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2851         of it is Mac-only.
2852         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2853         method did was call itself on the main thread, and do nothing if called on main thread.
2854         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2855         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2856         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2857         half of this method.
2858         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2859         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2860         Simplified using a modern for loop and RetainPtr.
2861         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2862         (-[WebHTMLView keyDown:]): Ditto.
2863         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2864         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2865         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2866         (-[WebHTMLView complete:]): Ditto.
2867         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2868         now macOS-only.
2869         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2870         iOS since that is now macOS-only.
2871         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2872         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2873         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2874         and reorganized to use early return.
2875         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2876         on iOS, but kept there so we don't have to do #if at every call site.
2877         (-[WebHTMLView _pluginController]): Moved into internal category.
2878         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2879         there only for GC, using C++ initialization, removing obsolete comment.
2880         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2881         peculiar iOS-only comment.
2882         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2883
2884         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2885         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2886         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2887         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2888         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2889
2890         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2891         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2892         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2893         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2894         them at this time.
2895
2896 2017-09-03  Sam Weinig  <sam@webkit.org>
2897
2898         Remove CanvasProxy
2899         https://bugs.webkit.org/show_bug.cgi?id=176288
2900
2901         Reviewed by Yusuke Suzuki.
2902
2903         CanvasProxy does not appear to be in any current HTML spec
2904         and was disabled and unimplemented in our tree. Time to 
2905         get rid of it.
2906
2907         * Configurations/FeatureDefines.xcconfig:
2908
2909 2017-09-02  Andy Estes  <aestes@apple.com>
2910
2911         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2912         https://bugs.webkit.org/show_bug.cgi?id=176270
2913
2914         Reviewed by Tim Horton.
2915
2916         * Plugins/Hosted/NetscapePluginHostManager.mm:
2917         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2918         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2919         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2920         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2921         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2922         (WebKit::SoftwareCARenderer::context const):
2923         (WebKit::SoftwareCARenderer::renderContext const):
2924         (WebKit::SoftwareCARenderer::render):
2925         (-[WebHostedNetscapePluginView createPlugin]):
2926         (-[WebHostedNetscapePluginView createPluginLayer]):
2927         (-[WebHostedNetscapePluginView destroyPlugin]):
2928         (-[WebHostedNetscapePluginView drawRect:]):
2929         * WebCoreSupport/WebSystemInterface.mm:
2930         (InitWebCoreSystemInterface):
2931
2932 2017-09-01  Andy Estes  <aestes@apple.com>
2933
2934         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2935         https://bugs.webkit.org/show_bug.cgi?id=176200
2936
2937         Reviewed by Tim Horton.
2938
2939         * Carbon/HIWebView.mm:
2940         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2941         (overrideCGContext):
2942         (restoreCGContext):
2943         (Draw):
2944         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2945         (+[WebHostedNetscapePluginView initialize]):
2946         * Plugins/WebBaseNetscapePluginView.h:
2947         * Plugins/WebBaseNetscapePluginView.mm:
2948         (WebKit::sendUserChangeNotifications):
2949         * Plugins/WebNetscapePluginView.mm:
2950         (+[WebNetscapePluginView initialize]):
2951         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2952         * WebCoreSupport/WebSystemInterface.mm:
2953         (InitWebCoreSystemInterface):
2954         * WebView/WebFrame.mm:
2955         (-[WebFrame _paintBehaviorForDestinationContext:]):
2956         * WebView/WebFullScreenController.mm:
2957         (setClipRectForWindow):
2958         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2959         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2960         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2961         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2962
2963 2017-08-31  Andy Estes  <aestes@apple.com>
2964
2965         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2966         https://bugs.webkit.org/show_bug.cgi?id=176175
2967
2968         Reviewed by Brady Eidson.
2969
2970         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2971         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2972         * Plugins/Hosted/WebTextInputWindowController.m:
2973         (-[WebTextInputPanel init]):
2974         * WebCoreSupport/WebSystemInterface.mm:
2975         (InitWebCoreSystemInterface):
2976         * WebView/WebDynamicScrollBarsView.mm:
2977         (-[WebDynamicScrollBarsView scrollWheel:]):
2978         * WebView/WebHTMLView.mm:
2979         (-[WebHTMLView _removeWindowObservers]):
2980         (-[WebHTMLView addWindowObservers]):
2981         * WebView/WebView.mm:
2982         (-[WebView addWindowObserversForWindow:]):
2983         (-[WebView removeWindowObservers]):
2984         (-[WebView viewWillMoveToWindow:]):
2985
2986 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2987
2988         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2989         https://bugs.webkit.org/show_bug.cgi?id=175779
2990         <rdar://problem/22367975>
2991
2992         Reviewed by Tim Horton.
2993
2994         * WebCoreSupport/WebFrameLoaderClient.h:
2995         * WebCoreSupport/WebFrameLoaderClient.mm:
2996         (WebFrameLoaderClient::webGLPolicyForURL const):
2997         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2998
2999 2017-08-30  Andy Estes  <aestes@apple.com>
3000
3001         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3002         https://bugs.webkit.org/show_bug.cgi?id=176093
3003
3004         Reviewed by Eric Carlson.
3005
3006         * WebCoreSupport/WebSystemInterface.mm:
3007         (InitWebCoreSystemInterface):
3008
3009 2017-08-30  Andy Estes  <aestes@apple.com>
3010
3011         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3012         https://bugs.webkit.org/show_bug.cgi?id=176087
3013
3014         Reviewed by Alex Christensen.
3015
3016         * Carbon/CarbonUtils.m:
3017         (getNSAutoreleasePoolCount):
3018         (WebInitForCarbon):
3019         (PoolCleaner):
3020         * Carbon/CarbonWindowAdapter.mm:
3021         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3022         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3023         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3024         (-[CarbonWindowAdapter _windowMovedToRect:]):
3025         * Carbon/HIViewAdapter.m:
3026         * Carbon/HIWebView.mm:
3027         (Draw):
3028         (CreateNSEventAdoptingCGEvent):
3029         (CopyEventCGEvent):
3030         (CreateNSEventWithCarbonClickEvent):
3031         (Click):
3032         (CreateNSEventWithCarbonEvent):
3033         (MouseUp):
3034         (CreateNSEventWithCarbonMouseMoveEvent):
3035         (MouseMoved):
3036         (MouseDragged):
3037         (MouseWheelMoved):
3038         (WindowHandler):
3039         (HIWebViewEventHandler):
3040         * Misc/QuickDrawCompatibility.h: Removed.
3041         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3042         (getCarbonEvent):
3043         (WebNetscapePluginEventHandlerCarbon::keyDown):
3044         (WebNetscapePluginEventHandlerCarbon::keyUp):
3045         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3046         (WebNetscapePluginEventHandlerCocoa::keyDown):
3047         * Plugins/WebNetscapePluginView.mm:
3048         (-[WebNetscapePluginView tellQuickTimeToChill]):
3049
3050 2017-08-29  Andy Estes  <aestes@apple.com>
3051
3052         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3053         https://bugs.webkit.org/show_bug.cgi?id=176046
3054
3055         Reviewed by Alex Christensen.
3056
3057         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3058         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3059
3060         * Misc/WebNSFileManagerExtras.mm:
3061         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3062         (setMetaData): Deleted.
3063         * WebCoreSupport/WebSystemInterface.mm:
3064         (InitWebCoreSystemInterface):
3065
3066 2017-08-28  Andy Estes  <aestes@apple.com>
3067
3068         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3069         https://bugs.webkit.org/show_bug.cgi?id=176039
3070
3071         Reviewed by Alex Christensen.
3072
3073         * WebCoreSupport/WebSystemInterface.mm:
3074         (InitWebCoreSystemInterface):
3075         * WebView/WebPreferences.mm:
3076         (+[WebPreferences _systemCFStringEncoding]):
3077
3078 2017-08-28  Andy Estes  <aestes@apple.com>
3079
3080         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3081         https://bugs.webkit.org/show_bug.cgi?id=176032
3082
3083         Reviewed by Alex Christensen.
3084
3085         * WebCoreSupport/WebSystemInterface.mm:
3086         (InitWebCoreSystemInterface):
3087         * WebView/WebView.mm:
3088         (-[WebView _cachedResponseForURL:]):
3089
3090 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3091
3092         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3093         https://bugs.webkit.org/show_bug.cgi?id=175992
3094         <rdar://problem/34086613>
3095
3096         Reviewed by Daniel Bates.
3097
3098         * WebCoreSupport/WebPlatformStrategies.h:
3099         * WebCoreSupport/WebPlatformStrategies.mm:
3100         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3101         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3102         indicating if secure cookies were accessed.
3103
3104 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3105
3106         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3107         https://bugs.webkit.org/show_bug.cgi?id=170955
3108         <rdar://problem/31697653>
3109
3110         Reviewed by Ryosuke Niwa.
3111
3112         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3113         text is being replaced.
3114
3115         * WebView/WebHTMLView.mm:
3116         (-[WebHTMLView insertText:]):
3117
3118 2017-08-24  Chris Dumez  <cdumez@apple.com>
3119
3120         [Directory Upload] Add basic support for input.webkitdirectory
3121         https://bugs.webkit.org/show_bug.cgi?id=175950
3122         <rdar://problem/33951915>
3123
3124         Reviewed by Geoffrey Garen.
3125
3126         Add private API to toggle Directory Upload support on Mac WebKit1.
3127
3128         * WebView/WebPreferenceKeysPrivate.h:
3129         * WebView/WebPreferences.mm:
3130         (+[WebPreferences initialize]):
3131         (-[WebPreferences setDirectoryUploadEnabled:]):
3132         (-[WebPreferences directoryUploadEnabled]):
3133         * WebView/WebPreferencesPrivate.h:
3134         * WebView/WebView.mm:
3135         (-[WebView _preferencesChanged:]):
3136
3137 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3138
3139         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3140         https://bugs.webkit.org/show_bug.cgi?id=175370
3141         <rdar://problem/33799806>
3142
3143         Reviewed by Ryosuke Niwa.
3144
3145         Adjust WebEditorClient for interface changes.
3146
3147         * WebCoreSupport/WebEditorClient.h:
3148
3149 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3150
3151         Remove ChromeClient::scrollbarsModeDidChange
3152         https://bugs.webkit.org/show_bug.cgi?id=175805
3153
3154         Reviewed by Daniel Bates.
3155
3156         * WebCoreSupport/WebChromeClient.h:
3157
3158 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3159
3160         Remove ChromeClient::hasOpenedPopup
3161         https://bugs.webkit.org/show_bug.cgi?id=175804
3162
3163         Reviewed by Sam Weinig.
3164
3165         * WebCoreSupport/WebChromeClient.h:
3166         * WebCoreSupport/WebChromeClient.mm:
3167         (WebChromeClient::hasOpenedPopup const): Deleted.
3168
3169 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3170
3171         Disable access to secure cookies if an HTTPS site loads mixed content
3172         https://bugs.webkit.org/show_bug.cgi?id=157053
3173         <rdar://problem/11290808>
3174
3175         Reviewed by Dan Bates.
3176
3177         * WebCoreSupport/WebPlatformStrategies.h:
3178         * WebCoreSupport/WebPlatformStrategies.mm:
3179         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3180         indicating whether secure cookies should be included in the response.
3181
3182 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3183
3184         [PAL] Move spi/mac directory into PAL
3185         https://bugs.webkit.org/show_bug.cgi?id=175649
3186
3187         Reviewed by Myles C. Maxfield.
3188
3189         * Misc/WebSharingServicePickerController.h:
3190         * WebCoreSupport/WebContextMenuClient.mm:
3191         * WebCoreSupport/WebEditorClient.mm:
3192         * WebCoreSupport/WebSelectionServiceController.mm:
3193         * WebView/WebHTMLView.mm:
3194         * WebView/WebImmediateActionController.h:
3195         * WebView/WebImmediateActionController.mm:
3196         * WebView/WebView.mm:
3197
3198 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3199
3200         [PAL] Relocate SessionID to root
3201         https://bugs.webkit.org/show_bug.cgi?id=175684
3202
3203         Reviewed by Alex Christensen.
3204
3205         * WebCoreSupport/WebFrameNetworkingContext.mm:
3206
3207 2017-08-17  Andreas Kling  <akling@apple.com>
3208
3209         Disable CSS regions at compile time
3210         https://bugs.webkit.org/show_bug.cgi?id=175630
3211
3212         Reviewed by Antti Koivisto.
3213
3214         * Configurations/FeatureDefines.xcconfig:
3215
3216 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3217
3218         [PAL] Move SessionID into PAL
3219         https://bugs.webkit.org/show_bug.cgi?id=174192
3220
3221         Reviewed by Antti Koivisto.
3222
3223         * Misc/WebCache.mm:
3224         (+[WebCache imageForURL:]):
3225         * WebCoreSupport/WebFrameLoaderClient.h:
3226         * WebCoreSupport/WebFrameLoaderClient.mm:
3227         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3228         * WebCoreSupport/WebFrameNetworkingContext.mm:
3229         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3230         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3231         (WebFrameNetworkingContext::storageSession const):
3232         * WebCoreSupport/WebPlatformStrategies.h:
3233         * WebCoreSupport/WebPlatformStrategies.mm:
3234         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3235         * WebKitPrefix.h:
3236
3237 2017-08-16  Andy Estes  <aestes@apple.com>
3238
3239         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3240         https://bugs.webkit.org/show_bug.cgi?id=175648
3241
3242         Reviewed by Tim Horton.
3243
3244         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3245         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3246         (WebPaymentCoordinatorClient::showPaymentUI):
3247
3248 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3249
3250         [PAL] Move spi/ios and spi/win directories into PAL
3251         https://bugs.webkit.org/show_bug.cgi?id=175171
3252
3253         Reviewed by Antti Koivisto.
3254
3255         * WebCoreSupport/WebFrameLoaderClient.mm:
3256         * WebView/WebView.mm:
3257
3258 2017-08-16  Andy Estes  <aestes@apple.com>
3259
3260         [Payment Request] Add an ENABLE flag and an experimental feature preference
3261         https://bugs.webkit.org/show_bug.cgi?id=175622
3262
3263         Reviewed by Tim Horton.
3264
3265         * Configurations/FeatureDefines.xcconfig:
3266
3267 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3268
3269         [PAL] Move Sleep classes into PAL
3270         https://bugs.webkit.org/show_bug.cgi?id=175456
3271
3272         Reviewed by Ryosuke Niwa.
3273
3274         * WebView/WebFullScreenController.h:
3275
3276 2017-08-15  Youenn Fablet  <youenn@apple.com>
3277
3278         [Cache API] Adding generic support for CacheStorage and Cache methods
3279         https://bugs.webkit.org/show_bug.cgi?id=175455
3280
3281         Reviewed by Chris Dumez.
3282
3283         * WebView/WebView.mm:
3284         (-[WebView _commonInitializationWithFrameName:groupName:]):
3285
3286 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3287
3288         Remove Proximity Events and related code
3289         https://bugs.webkit.org/show_bug.cgi?id=175545
3290
3291         Reviewed by Daniel Bates.
3292
3293         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3294         and other related code.
3295
3296         * Configurations/FeatureDefines.xcconfig:
3297
3298 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3299
3300         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3301         https://bugs.webkit.org/show_bug.cgi?id=175504
3302
3303         Reviewed by Sam Weinig.
3304
3305         * Configurations/FeatureDefines.xcconfig:
3306         * DOM/DOMHTMLFormElement.mm:
3307         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3308         * WebCoreSupport/WebFrameLoaderClient.h:
3309
3310 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3311
3312         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3313         https://bugs.webkit.org/show_bug.cgi?id=175557
3314
3315         Reviewed by Jon Lee.
3316
3317         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3318
3319         * Configurations/FeatureDefines.xcconfig:
3320
3321 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3322
3323         Composition underline color is always black
3324         https://bugs.webkit.org/show_bug.cgi?id=174675
3325
3326         Reviewed by Ryosuke Niwa.
3327
3328         * WebView/WebHTMLView.mm:
3329         (extractUnderlines): If NSUnderlineColorAttributeName
3330         is not present use text color for composition underline.
3331         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3332         for composition underline in the plain text case.
3333
3334 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3335
3336         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3337         https://bugs.webkit.org/show_bug.cgi?id=175474
3338         <rdar://problem/33844628>
3339
3340         Reviewed by Wenson Hsieh.
3341
3342         Replaced the build flag by a runtime flag and disabled the feature by default.
3343
3344         * Configurations/FeatureDefines.xcconfig:
3345         * WebView/WebPreferenceKeysPrivate.h:
3346         * WebView/WebPreferences.mm:
3347         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3348         (-[WebPreferences dataTransferItemsEnabled]): Added.
3349         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3350         * WebView/WebPreferencesPrivate.h:
3351         * WebView/WebView.mm:
3352         (-[WebView _preferencesChanged:]):
3353
3354 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3355
3356         Remove ENABLE_GAMEPAD_DEPRECATED
3357         https://bugs.webkit.org/show_bug.cgi?id=175361
3358
3359         Reviewed by Carlos Garcia Campos.
3360
3361         * Configurations/FeatureDefines.xcconfig:
3362
3363 2017-08-09  Chris Dumez  <cdumez@apple.com>
3364
3365         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3366         https://bugs.webkit.org/show_bug.cgi?id=175401
3367
3368         Reviewed by Brady Eidson.
3369
3370         * WebView/WebPreferenceKeysPrivate.h:
3371         * WebView/WebPreferences.mm:
3372         (+[WebPreferences initialize]):
3373         (-[WebPreferences beaconAPIEnabled]): Deleted.
3374         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3375         * WebView/WebPreferencesPrivate.h:
3376         * WebView/WebView.mm:
3377         (-[WebView _preferencesChanged:]):
3378
3379 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3380
3381         [PAL] Move spi/cocoa and spi/cg directories into PAL
3382         https://bugs.webkit.org/show_bug.cgi?id=175175
3383
3384         Reviewed by Myles C. Maxfield.
3385
3386         * History/WebHistory.mm:
3387         * Misc/WebDownload.mm:
3388         * Misc/WebKitNSStringExtras.mm:
3389         * Plugins/Hosted/NetscapePluginHostManager.mm:
3390         * Plugins/WebPluginDatabase.mm:
3391         * WebCoreSupport/WebFrameLoaderClient.mm:
3392         * WebInspector/WebNodeHighlight.mm:
3393         * WebView/WebHTMLView.mm:
3394         * WebView/WebIndicateLayer.mm:
3395         * WebView/WebView.mm:
3396         * WebView/WebViewData.h:
3397
3398 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3399
3400         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3401         https://bugs.webkit.org/show_bug.cgi?id=175392
3402         <rdar://problem/33783207>
3403
3404         Reviewed by Tim Horton and Megan Gardner.
3405
3406         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3407
3408         * Configurations/FeatureDefines.xcconfig:
3409
3410 2017-08-09  Daniel Bates  <dabates@apple.com>
3411
3412         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3413         https://bugs.webkit.org/show_bug.cgi?id=175247
3414         <rdar://problem/33679804>
3415
3416         Reviewed by Brady Eidson.
3417
3418         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3419         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3420         clients that need to make use of this information at this time. If such a needs comes up
3421         then we can expose API/SPI similar to what we do for WebKit.
3422
3423         * WebCoreSupport/WebFrameLoaderClient.h:
3424         * WebCoreSupport/WebFrameLoaderClient.mm:
3425         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3426
3427 2017-08-08  Brady Eidson  <beidson@apple.com>
3428
3429         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3430         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3431
3432         Reviewed by Andy Estes.
3433
3434         * Misc/WebKitVersionChecks.h:
3435         * WebCoreSupport/WebFrameLoaderClient.mm:
3436         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3437           the app is linked against new WebKit with the new behavior.
3438
3439 2017-08-07  Devin Rousso  <drousso@apple.com>
3440
3441         Web Inspector: Preview Canvas path when viewing a recording
3442         https://bugs.webkit.org/show_bug.cgi?id=174967
3443
3444         Reviewed by Brian Burg.
3445
3446         * WebView/WebPreferenceKeysPrivate.h:
3447         * WebView/WebPreferences.mm:
3448         (+[WebPreferences initialize]):
3449         (-[WebPreferences inspectorAdditionsEnabled]):
3450         (-[WebPreferences setInspectorAdditionsEnabled:]):
3451         * WebView/WebPreferencesPrivate.h:
3452         * WebView/WebView.mm:
3453         (-[WebView _preferencesChanged:]):
3454         Add plumbing for new InspectorAdditions runtime flag.
3455
3456 2017-08-07  Brian Burg  <bburg@apple.com>
3457
3458         Remove CANVAS_PATH compilation guard
3459         https://bugs.webkit.org/show_bug.cgi?id=175207
3460
3461         Reviewed by Sam Weinig.
3462
3463         * Configurations/FeatureDefines.xcconfig:
3464
3465 2017-08-04  Youenn Fablet  <youenn@apple.com>
3466
3467         [Cache API] Add Cache and CacheStorage IDL definitions
3468         https://bugs.webkit.org/show_bug.cgi?id=175201
3469
3470         Reviewed by Brady Eidson.
3471
3472         * WebView/WebPreferenceKeysPrivate.h:
3473         * WebView/WebPreferences.mm:
3474         (+[WebPreferences initialize]):
3475         (-[WebPreferences cacheAPIEnabled]):
3476         (-[WebPreferences setCacheAPIEnabled:]):
3477         * WebView/WebPreferencesPrivate.h:
3478         * WebView/WebView.mm:
3479         (-[WebView _preferencesChanged:]):
3480
3481 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3482
3483         Unreviewed, rolling out r220271.
3484
3485         Rolling out due to Layout Test failing on iOS Simulator.
3486
3487         Reverted changeset:
3488