18a0904f2d5b5bde70c802e273dfb45cc7d5a972
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-29  JF Bastien  <jfbastien@apple.com>
2
3         Use Forward.h instead of forward-declaring WTF::String
4         https://bugs.webkit.org/show_bug.cgi?id=184172
5         <rdar://problem/39026146>
6
7         Reviewed by Yusuke Suzuki.
8
9         As part of #184164 I'm changing WTF::String, and the forward
10         declarations are just wrong because I'm making it templated. We
11         should use Forward.h anyways, so do that instead.
12
13         * WebView/WebScriptDebugger.h:
14
15 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
16
17         Protect against invalid mach ports returned by mach_port_request_notification
18         https://bugs.webkit.org/show_bug.cgi?id=184106
19         <rdar://problem/37865316>
20
21         Reviewed by Chris Dumez.
22
23         * Plugins/Hosted/NetscapePluginHostProxy.mm:
24         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
25         and clean up if it experienced an error.
26         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
27
28 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
29
30         Avoid uninitialized mach ports
31         https://bugs.webkit.org/show_bug.cgi?id=184090
32         <rdar://problem/37261129>
33
34         Reviewed by Chris Dumez.
35
36         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
37         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
38         there is a potential for us to try to use invalid ports.
39
40         We should always check return values, and ensure that the mach port variables we seek to initialize are
41         kept in a valid state.
42
43         Reviewed by Chris Dumez.
44
45         * Plugins/Hosted/NetscapePluginHostManager.h:
46         * Plugins/Hosted/NetscapePluginHostManager.mm:
47         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
48         port is passed to an API function.
49         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
50         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
51         * Plugins/Hosted/NetscapePluginHostProxy.h:
52         * Plugins/Hosted/NetscapePluginHostProxy.mm:
53         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
54         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
55         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
56         (WKPCStatusText): Ditto.
57         (WKPCLoadURL): Ditto.
58         (WKPCCancelLoadURL): Ditto.
59         (WKPCInvalidateRect): Ditto.
60         (WKPCGetScriptableNPObjectReply): Ditto.
61         (WKPCBooleanReply): Ditto.
62         (WKPCBooleanAndDataReply): Ditto.
63         (WKPCInstantiatePluginReply): Ditto.
64         (WKPCGetWindowNPObject): Ditto.
65         (WKPCGetPluginElementNPObject): Ditto.
66         (WKPCForgetBrowserObject): Ditto.
67         (WKPCEvaluate): Ditto.
68         (WKPCGetStringIdentifier): Ditto.
69         (WKPCGetIntIdentifier): Ditto.
70         (WKPCInvoke): Ditto.
71         (WKPCInvokeDefault): Ditto.
72         (WKPCConstruct): Ditto.
73         (WKPCGetProperty): Ditto.
74         (WKPCSetProperty): Ditto.
75         (WKPCRemoveProperty): Ditto.
76         (WKPCHasProperty): Ditto.
77         (WKPCHasMethod): Ditto.
78         (WKPCIdentifierInfo): Ditto.
79         (WKPCEnumerate): Ditto.
80         (WKPCSetMenuBarVisible): Ditto.
81         (WKPCSetFullscreenWindowIsShowing): Ditto.
82         (WKPCSetModal): Ditto.
83         (WKPCGetCookies): Ditto.
84         (WKPCGetProxy): Ditto.
85         (WKPCSetCookies): Ditto.
86         (WKPCGetAuthenticationInfo): Ditto.
87         (WKPCConvertPoint): Ditto.
88         (WKPCLayerHostingModeChanged): Ditto.
89         (WKPCSetException): Ditto.
90
91 2018-03-26  Tim Horton  <timothy_horton@apple.com>
92
93         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
94         https://bugs.webkit.org/show_bug.cgi?id=184030
95         <rdar://problem/38895281>
96
97         Reviewed by Dan Bernstein.
98
99         * Configurations/Base.xcconfig:
100
101 2018-03-26  Chris Dumez  <cdumez@apple.com>
102
103         Use SecurityOriginData more consistently in Service Worker code
104         https://bugs.webkit.org/show_bug.cgi?id=183969
105
106         Reviewed by Darin Adler.
107
108         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
109
110         * Storage/WebDatabaseManager.mm:
111         (-[WebDatabaseManager databasesWithOrigin:]):
112         (-[WebDatabaseManager deleteOrigin:]):
113         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
114         * Storage/WebDatabaseQuotaManager.mm:
115         (-[WebDatabaseQuotaManager usage]):
116         (-[WebDatabaseQuotaManager quota]):
117         (-[WebDatabaseQuotaManager setQuota:]):
118         * Storage/WebStorageManager.mm:
119         (-[WebStorageManager deleteOrigin:]):
120         * WebCoreSupport/WebSecurityOrigin.mm:
121         (-[WebSecurityOrigin databaseIdentifier]):
122         (-[WebSecurityOrigin usage]):
123         (-[WebSecurityOrigin quota]):
124         (-[WebSecurityOrigin setQuota:]):
125
126 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
127
128         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
129         https://bugs.webkit.org/show_bug.cgi?id=183911
130         <rdar://problem/38762306>
131
132         Reviewed by Youenn Fablet.
133
134         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
135
136         * WebView/WebView.mm:
137         (+[WebView initialize]):
138
139 2018-03-26  Alex Christensen  <achristensen@webkit.org>
140
141         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
142         https://bugs.webkit.org/show_bug.cgi?id=183965
143
144         Reviewed by Chris Dumez.
145
146         * WebCoreSupport/WebFrameLoaderClient.h:
147         * WebCoreSupport/WebFrameLoaderClient.mm:
148         (WebFrameLoaderClient::willCacheResponse const):
149
150 2018-03-25  Commit Queue  <commit-queue@webkit.org>
151
152         Unreviewed, rolling out r229954.
153         https://bugs.webkit.org/show_bug.cgi?id=184000
154
155         Caused many layout tests to crash on Apple High Sierra,
156         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
157         by dydz on #webkit).
158
159         Reverted changeset:
160
161         "Use SecurityOriginData more consistently in Service Worker
162         code"
163         https://bugs.webkit.org/show_bug.cgi?id=183969
164         https://trac.webkit.org/changeset/229954
165
166 2018-03-24  Chris Dumez  <cdumez@apple.com>
167
168         Use SecurityOriginData more consistently in Service Worker code
169         https://bugs.webkit.org/show_bug.cgi?id=183969
170
171         Reviewed by Darin Adler.
172
173         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
174
175         * Storage/WebDatabaseManager.mm:
176         (-[WebDatabaseManager databasesWithOrigin:]):
177         (-[WebDatabaseManager deleteOrigin:]):
178         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
179         * Storage/WebDatabaseQuotaManager.mm:
180         (-[WebDatabaseQuotaManager usage]):
181         (-[WebDatabaseQuotaManager quota]):
182         (-[WebDatabaseQuotaManager setQuota:]):
183         * Storage/WebStorageManager.mm:
184         (-[WebStorageManager deleteOrigin:]):
185         * WebCoreSupport/WebSecurityOrigin.mm:
186         (-[WebSecurityOrigin databaseIdentifier]):
187         (-[WebSecurityOrigin usage]):
188         (-[WebSecurityOrigin quota]):
189         (-[WebSecurityOrigin setQuota:]):
190
191 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
192
193         Fix the build
194
195         * WebView/WebView.mm:
196
197 2018-03-23  Tim Horton  <timothy_horton@apple.com>
198
199         Fix the build with no pasteboard
200         https://bugs.webkit.org/show_bug.cgi?id=183973
201
202         Reviewed by Dan Bernstein.
203
204         * Configurations/FeatureDefines.xcconfig:
205         * WebView/WebView.mm:
206         (-[WebView _requestStartDataInteraction:globalPosition:]):
207         (-[WebView _getDataInteractionData]):
208         (-[WebView _dataOperationTextIndicator]):
209         (-[WebView _dragSourceAction]):
210         (-[WebView _draggedLinkTitle]):
211         (-[WebView _draggedLinkURL]):
212         (-[WebView _draggedElementBounds]):
213         (-[WebView _enteredDataInteraction:client:global:operation:]):
214         (-[WebView _updatedDataInteraction:client:global:operation:]):
215         (-[WebView _exitedDataInteraction:client:global:operation:]):
216         (-[WebView _performDataInteraction:client:global:operation:]):
217         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
218         (-[WebView _endedDataInteraction:global:]):
219         (-[WebView _dataInteractionCaretRect]):
220         * WebView/WebViewPrivate.h:
221
222 2018-03-23  Tim Horton  <timothy_horton@apple.com>
223
224         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
225         https://bugs.webkit.org/show_bug.cgi?id=183960
226         <rdar://problem/38812356>
227
228         Reviewed by Dan Bernstein.
229
230         * Configurations/WebKitLegacy.xcconfig:
231
232 2018-03-23  Tim Horton  <timothy_horton@apple.com>
233
234         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
235         https://bugs.webkit.org/show_bug.cgi?id=183954
236         <rdar://problem/38808858>
237
238         Reviewed by Dan Bernstein.
239
240         * WebView/WebPreferences.mm:
241         (-[WebPreferences setAudioSessionCategoryOverride:]):
242
243 2018-03-23  Tim Horton  <timothy_horton@apple.com>
244
245         Adopt WK_PLATFORM_NAME in WebKitLegacy
246         https://bugs.webkit.org/show_bug.cgi?id=183948
247         <rdar://problem/38803908>
248
249         Reviewed by Dan Bernstein.
250
251         * Configurations/WebKitLegacy.xcconfig:
252         * MigrateHeaders.make:
253         * postprocess-headers.sh:
254
255 2018-03-23  Brady Eidson  <beidson@apple.com>
256
257         Go to back/forward list items after a process-swapped navigation.
258         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
259
260         Reviewed by Andy Estes.
261
262         * WebView/WebView.mm:
263         (-[WebView _loadBackForwardListFromOtherView:]):
264         (-[WebView goToBackForwardItem:]):
265
266 2018-03-22  Tim Horton  <timothy_horton@apple.com>
267
268         Improve readability of WebCore's OTHER_LDFLAGS
269         https://bugs.webkit.org/show_bug.cgi?id=183909
270         <rdar://problem/38760992>
271
272         Reviewed by Dan Bernstein.
273
274         * Configurations/Base.xcconfig:
275         * Configurations/FeatureDefines.xcconfig:
276
277 2018-03-20  Tim Horton  <timothy_horton@apple.com>
278
279         Enable the minimal simulator feature flag when appropriate
280         https://bugs.webkit.org/show_bug.cgi?id=183807
281
282         Reviewed by Dan Bernstein.
283
284         * Configurations/FeatureDefines.xcconfig:
285
286 2018-03-20  Tim Horton  <timothy_horton@apple.com>
287
288         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
289         https://bugs.webkit.org/show_bug.cgi?id=183758
290         <rdar://problem/38017644>
291
292         Reviewed by Dan Bernstein.
293
294         * Configurations/FeatureDefines.xcconfig:
295
296 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
297
298         Clear style colors when setting default appearance
299         https://bugs.webkit.org/show_bug.cgi?id=183759
300
301         Reviewed by Tim Horton.
302
303         Colors are cached and need to be cleared and recalculated.
304         Refactor to do all style recalcs together.
305
306         * WebView/WebView.mm:
307         (-[WebView _setDefaultAppearanceAndClearStyle]):
308         (-[WebView _setUseSystemAppearance:]):
309         (-[WebView effectiveAppearanceDidChange]):
310
311 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
312
313         Unreviewed, another quick fix for r229699
314
315         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
316
317         * Configurations/FeatureDefines.xcconfig:
318
319 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
320
321         Ensure that style is updated when the effective appearance changes
322         https://bugs.webkit.org/show_bug.cgi?id=183690
323         <rdar://problem/38385900>
324
325         Reviewed by Tim Horton and Wenson Hsieh.
326
327         Respond to and respect the effective appearance changing.
328
329         * WebView/WebView.mm:
330         (-[WebView _setUseSystemAppearance:]):
331         (-[WebView effectiveAppearanceDidChange]):
332
333 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
334
335         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
336         https://bugs.webkit.org/show_bug.cgi?id=183677
337
338         Reviewed by Tim Horton.
339
340         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
341
342         * DOM/DOM.mm:
343         (-[DOMHTMLLinkElement _mediaQueryMatches]):
344
345 2018-03-14  Tim Horton  <timothy_horton@apple.com>
346
347         Fix the build after r229567
348
349         * Configurations/FeatureDefines.xcconfig:
350
351 2018-03-12  Tim Horton  <timothy_horton@apple.com>
352
353         Stop using SDK conditionals to control feature definitions
354         https://bugs.webkit.org/show_bug.cgi?id=183430
355         <rdar://problem/38251619>
356
357         Reviewed by Dan Bernstein.
358
359         * Configurations/FeatureDefines.xcconfig:
360         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
361
362 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
363
364         Runtime flag for link prefetch and remove link subresource.
365         https://bugs.webkit.org/show_bug.cgi?id=183540
366
367         Reviewed by Chris Dumez.
368
369         Remove the LINK_PREFETCH build time flag.
370
371         * Configurations/FeatureDefines.xcconfig:
372
373 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
374
375         Remove GridLayout runtime flag
376         https://bugs.webkit.org/show_bug.cgi?id=183484
377
378         Reviewed by Myles C. Maxfield.
379
380         The Grid Layout feature has been enabled by default for almost a
381         year, so I think it's time to remove the runtime flag and the
382
383         * WebView/WebPreferenceKeysPrivate.h:
384         * WebView/WebPreferences.mm:
385         (+[WebPreferences initialize]):
386         * WebView/WebPreferencesPrivate.h:
387         * WebView/WebView.mm:
388         (-[WebView _preferencesChanged:]):
389
390 2018-03-12  Antoine Quint  <graouts@apple.com>
391
392         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
393         https://bugs.webkit.org/show_bug.cgi?id=183504
394         <rdar://problem/38372965>
395
396         Reviewed by Dean Jackson and Jon Lee.
397
398         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
399         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
400
401         * WebView/WebPreferenceKeysPrivate.h:
402         * WebView/WebPreferences.mm:
403         (+[WebPreferences initialize]):
404         (-[WebPreferences setModernMediaControlsEnabled:]):
405         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
406         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
407         * WebView/WebPreferencesPrivate.h:
408         * WebView/WebView.mm:
409         (-[WebView _preferencesChanged:]):
410
411 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
412
413         Media query for default appearance
414         https://bugs.webkit.org/show_bug.cgi?id=183539
415         <rdar://problem/38326388>
416
417         Reviewed by Tim Horton.
418
419         Write a media query to evaluate appearance.
420
421         * WebView/WebView.mm:
422         (-[WebView _commonInitializationWithFrameName:groupName:]):
423         (-[WebView _setUseSystemAppearance:]):
424
425 2018-03-09  Andy Estes  <aestes@apple.com>
426
427         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
428         https://bugs.webkit.org/show_bug.cgi?id=183489
429         <rdar://problem/38267517>
430
431         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
432         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
433         to issue a sandbox extension for this directory, but for security reasons App Sandbox
434         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
435         block with a nil error and a valid file URL, but no file will actually exist at that URL.
436
437         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
438         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
439         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
440         drop destination.
441
442         Reviewed by Wenson Hsieh.
443
444         * WebView/WebView.mm:
445         (-[WebView performDragOperation:]):
446
447 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
448
449         Allow WebViews to disable system appearance
450         https://bugs.webkit.org/show_bug.cgi?id=183418
451         <rdar://problem/36975642>
452
453         Reviewed by Tim Horton.
454
455         Allow webviews to choose whether or not to follow the default system appearance.
456
457         * WebView/WebView.mm:
458         (-[WebView _setUseSystemAppearance:]):
459         (-[WebView _useSystemAppearance]):
460         * WebView/WebViewPrivate.h:
461
462 2018-03-08  Youenn Fablet  <youenn@apple.com>
463
464         libwebrtc update broke internal builds
465         https://bugs.webkit.org/show_bug.cgi?id=183454
466
467         Reviewed by Eric Carlson.
468
469         * Configurations/WebKitLegacy.xcconfig:
470
471 2018-03-08  Chris Dumez  <cdumez@apple.com>
472
473         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
474         https://bugs.webkit.org/show_bug.cgi?id=183455
475         <rdar://problem/38191749>
476
477         Reviewed by Youenn Fablet.
478
479         Add a null check for the page as we have evidence from crashes that it can be null.
480         Other functions in WebFrameNetworkingContext already null check the page as well,
481         not just the frame so this is consistent.
482
483         * WebCoreSupport/WebFrameNetworkingContext.mm:
484         (WebFrameNetworkingContext::storageSession const):
485
486 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
487
488         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
489         https://bugs.webkit.org/show_bug.cgi?id=183429
490
491         Reviewed by Mark Lam.
492
493         * DOM/DOM.mm:
494         (+[DOMNode _nodeFromJSWrapper:]):
495         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
496         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
497         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
498         * Plugins/Hosted/ProxyInstance.mm:
499         (WebKit::ProxyInstance::invokeMethod):
500         * WebView/WebView.mm:
501         (aeDescFromJSValue):
502
503 2018-03-08  Tim Horton  <timothy_horton@apple.com>
504
505         Stop linking ApplicationServices directly
506         https://bugs.webkit.org/show_bug.cgi?id=182867
507         <rdar://problem/38252142>
508
509         Reviewed by Alex Christensen.
510
511         The frameworks that we use that live inside ApplicationServices
512         have mostly moved out, so import them directly.
513
514         * Carbon/CarbonUtils.h:
515         * WebKitPrefix.h:
516         * WebView/WebHTMLView.mm:
517         * WebView/WebPDFView.mm:
518
519 2018-03-07  Tim Horton  <timothy_horton@apple.com>
520
521         Sort and separate FeatureDefines.xcconfig
522         https://bugs.webkit.org/show_bug.cgi?id=183427
523
524         Reviewed by Dan Bernstein.
525
526         * Configurations/FeatureDefines.xcconfig:
527         Sort and split FeatureDefines into paragraphs
528         (to make it easier to sort later).
529
530 2018-03-07  Youenn Fablet  <youenn@apple.com>
531
532         Match unsupported plugins based on domains and not origin
533         https://bugs.webkit.org/show_bug.cgi?id=183384
534
535         Reviewed by Chris Dumez.
536
537         * WebCoreSupport/WebPluginInfoProvider.h:
538         * WebCoreSupport/WebPluginInfoProvider.mm:
539         (WebPluginInfoProvider::getPluginInfo):
540         (WebPluginInfoProvider::getWebVisiblePluginInfo):
541
542 2018-03-05  Andy Estes  <aestes@apple.com>
543
544         [Mac] Teach WebCore::Pasteboard about file promise drags
545         https://bugs.webkit.org/show_bug.cgi?id=183314
546         <rdar://problem/38105493>
547
548         Reviewed by Darin Adler.
549
550         Added a FIXME comment.
551
552         * WebView/WebView.mm:
553         (-[WebView performDragOperation:]):
554
555 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
556
557         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
558         https://bugs.webkit.org/show_bug.cgi?id=183312
559
560         Reviewed by Mark Lam.
561
562         Remove wtf/CurrentTime.h include pragma.
563
564         * WebView/WebFrame.mm:
565         * WebView/WebPDFView.mm:
566
567 2018-03-04  Tim Horton  <timothy_horton@apple.com>
568
569         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
570         https://bugs.webkit.org/show_bug.cgi?id=183283
571         <rdar://problem/38062148>
572
573         Reviewed by Sam Weinig.
574
575         * Configurations/FeatureDefines.xcconfig:
576
577 2018-02-28  Alex Christensen  <achristensen@webkit.org>
578
579         Reduce use of NetworkingContext in WebKit
580         https://bugs.webkit.org/show_bug.cgi?id=183213
581
582         Reviewed by Brady Eidson.
583
584         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
585         (WebKit::NetscapePluginInstanceProxy::getProxy):
586         * Plugins/WebNetscapePluginView.mm:
587         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
588
589 2018-02-17  Darin Adler  <darin@apple.com>
590
591         Prepare for ExtendedColor changes (first step)
592         https://bugs.webkit.org/show_bug.cgi?id=182904
593
594         Reviewed by Sam Weinig.
595
596         * Misc/WebKitNSStringExtras.mm:
597         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
598
599 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
600
601         Remove currentTime() / currentTimeMS()
602         https://bugs.webkit.org/show_bug.cgi?id=183052
603
604         Reviewed by Mark Lam.
605
606         * WebCoreSupport/WebFrameLoaderClient.h:
607         * WebCoreSupport/WebFrameLoaderClient.mm:
608         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
609
610 2018-02-16  Youenn Fablet  <youenn@apple.com>
611
612         Allow specifying which plug-ins are supported
613         https://bugs.webkit.org/show_bug.cgi?id=182748
614
615         Reviewed by Chris Dumez.
616
617         * WebCoreSupport/WebPluginInfoProvider.h:
618         * WebCoreSupport/WebPluginInfoProvider.mm:
619         (WebPluginInfoProvider::getPluginInfo):
620         (WebPluginInfoProvider::getWebVisiblePluginInfo):
621
622 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
623
624         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
625         https://bugs.webkit.org/show_bug.cgi?id=182882
626         <rdar://problem/35672661>
627
628         Reviewed by Dan Bernstein.
629
630         Make sure the smart pointer hold the collection of subviews lives at least as
631         long as the loop using it.
632
633         * WebView/WebHTMLView.mm:
634         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
635
636 2018-02-14  Daniel Bates  <dabates@apple.com>
637
638         Disallow cross-origin subresources from asking for credentials
639         https://bugs.webkit.org/show_bug.cgi?id=182579
640         <rdar://problem/36162271>
641
642         Reviewed by Andy Estes.
643
644         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
645         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
646
647         * WebView/WebPreferenceKeysPrivate.h:
648         * WebView/WebPreferences.mm:
649         (+[WebPreferences initialize]):
650         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
651         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
652         * WebView/WebPreferencesPrivate.h:
653         * WebView/WebView.mm:
654         (-[WebView _preferencesChanged:]):
655
656 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
657
658         Remove ForwardingHeaders directory from WebKitLegacy/mac.
659         https://bugs.webkit.org/show_bug.cgi?id=182738
660
661         Reviewed by Darin Adler.
662
663         * ForwardingHeaders/collector/handles/Global.h: Removed.
664         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
665         * ForwardingHeaders/runtime/Completion.h: Removed.
666         * ForwardingHeaders/runtime/Error.h: Removed.
667         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
668         * ForwardingHeaders/runtime/JSFunction.h: Removed.
669         * ForwardingHeaders/runtime/JSLock.h: Removed.
670         * ForwardingHeaders/runtime/JSObject.h: Removed.
671         * ForwardingHeaders/runtime/JSString.h: Removed.
672         * ForwardingHeaders/runtime/Protect.h: Removed.
673         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
674
675 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
676
677         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
678         https://bugs.webkit.org/show_bug.cgi?id=182641
679
680         Reviewed by Dan Bernstein.
681
682         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
683         https://trac.webkit.org/changeset/228308.
684
685         * WebView/WebVideoFullscreenController.h:
686         * WebView/WebVideoFullscreenHUDWindowController.mm:
687         * WebView/WebWindowAnimation.h:
688         * WebView/WebWindowAnimation.mm:
689         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
690         (WebCore::scaledRect): Deleted.
691         (WebCore::squaredDistance): Deleted.
692
693 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
694
695         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
696
697         * WebView/WebWindowAnimation.mm:
698         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
699
700 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
701
702         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
703         https://bugs.webkit.org/show_bug.cgi?id=182615
704
705         Reviewed by Eric Carlson.
706
707         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
708         Ideally, we should not reference NSApp in WebCore.
709
710         * WebView/WebFullScreenController.mm:
711         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
712         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
713         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
714         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
715         * WebView/WebView.mm:
716         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
717         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
718
719 2018-01-13  Darin Adler  <darin@apple.com>
720
721         Event improvements
722         https://bugs.webkit.org/show_bug.cgi?id=179591
723
724         Reviewed by Chris Dumez.
725
726         * DOM/DOMWheelEvent.mm:
727         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
728         Call initWebKitWheelEvent.
729
730         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
731         * WebCoreSupport/WebInspectorClient.mm: Ditto.
732         * WebView/WebFrame.mm: Ditto.
733
734         * WebView/WebHTMLView.mm:
735         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
736         underlyingPlatformEvent.
737         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
738
739         * WebView/WebScriptWorld.mm:
740         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
741
742         * WebView/WebView.mm: Removed include of ScriptValue.h.
743
744 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
745
746         Remove WebCore/ForwardingHeaders directory
747         https://bugs.webkit.org/show_bug.cgi?id=182347
748
749         Reviewed by Keith Miller.
750
751         * Carbon/CarbonWindowAdapter.mm:
752         * DOM/WebDOMOperations.mm:
753         * History/WebBackForwardList.mm:
754         * History/WebHistoryItem.mm:
755         * Misc/WebCache.mm:
756         * Misc/WebElementDictionary.mm:
757         * Misc/WebIconDatabase.mm:
758         * Misc/WebStringTruncator.mm:
759         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
760         * Plugins/Hosted/ProxyInstance.mm:
761         * Plugins/Hosted/ProxyRuntimeObject.mm:
762         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
763         * Plugins/WebBaseNetscapePluginView.mm:
764         * Plugins/WebBasePluginPackage.mm:
765         * Plugins/WebNetscapePluginStream.mm:
766         * Plugins/WebNetscapePluginView.mm:
767         * Plugins/WebPluginController.mm:
768         * WebCoreSupport/WebEditorClient.mm:
769         * WebCoreSupport/WebFrameLoaderClient.mm:
770         * WebCoreSupport/WebInspectorClient.h:
771         * WebCoreSupport/WebInspectorClient.mm:
772         * WebView/WebDataSource.mm:
773         * WebView/WebFrame.mm:
774         * WebView/WebHTMLRepresentation.mm:
775         * WebView/WebHTMLView.mm:
776         * WebView/WebPreferences.mm:
777         * WebView/WebScriptDebugDelegate.mm:
778         * WebView/WebScriptDebugger.h:
779         * WebView/WebTextIterator.mm:
780         * WebView/WebView.mm:
781         * WebView/WebViewData.mm:
782
783 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
784
785         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
786         https://bugs.webkit.org/show_bug.cgi?id=182312
787
788         Reviewed by Michael Catanzaro.
789
790         * WebKitPrefix.h:
791
792 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
793
794         [WebAuthN] Add a compile-time feature flag
795         https://bugs.webkit.org/show_bug.cgi?id=182211
796         <rdar://problem/36936365>
797
798         Reviewed by Brent Fulgham.
799
800         * Configurations/FeatureDefines.xcconfig:
801
802 2018-01-27  Dan Bernstein  <mitz@apple.com>
803
804         HaveInternalSDK includes should be "#include?"
805         https://bugs.webkit.org/show_bug.cgi?id=179670
806
807         * Configurations/Base.xcconfig:
808
809 2018-01-24  Alex Christensen  <achristensen@webkit.org>
810
811         Remove unused QTKit preference
812         https://bugs.webkit.org/show_bug.cgi?id=181968
813
814         Reviewed by Alexey Proskuryakov.
815
816         * WebView/WebPreferenceKeysPrivate.h:
817         * WebView/WebPreferences.mm:
818         (+[WebPreferences initialize]):
819         (-[WebPreferences setQTKitEnabled:]): Deleted.
820         (-[WebPreferences isQTKitEnabled]): Deleted.
821         * WebView/WebPreferencesPrivate.h:
822         * WebView/WebView.mm:
823         (-[WebView _preferencesChanged:]):
824
825 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
826
827         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
828         https://bugs.webkit.org/show_bug.cgi?id=182037
829         <rdar://problem/36747812>
830
831         Reviewed by Ryosuke Niwa.
832
833         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
834         for more details.
835
836         * WebView/WebHTMLRepresentation.mm:
837         (-[WebHTMLRepresentation elementWithName:inForm:]):
838         (-[WebHTMLRepresentation controlsInForm:]):
839
840 2018-01-23  Alex Christensen  <achristensen@webkit.org>
841
842         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
843         https://bugs.webkit.org/show_bug.cgi?id=181961
844
845         Reviewed by Michael Catanzaro.
846
847         * WebView/WebPreferences.mm:
848
849 2018-01-23  Commit Queue  <commit-queue@webkit.org>
850
851         Unreviewed, rolling out r227437.
852         https://bugs.webkit.org/show_bug.cgi?id=182011
853
854         broke build (Requested by alexchristensen on #webkit).
855
856         Reverted changeset:
857
858         "Remove unused QTKit preference"
859         https://bugs.webkit.org/show_bug.cgi?id=181968
860         https://trac.webkit.org/changeset/227437
861
862 2018-01-23  Alex Christensen  <achristensen@webkit.org>
863
864         Remove unused QTKit preference
865         https://bugs.webkit.org/show_bug.cgi?id=181968
866
867         Reviewed by Alexey Proskuryakov.
868
869         * WebView/WebPreferenceKeysPrivate.h:
870         * WebView/WebPreferences.mm:
871         (+[WebPreferences initialize]):
872         (-[WebPreferences setQTKitEnabled:]): Deleted.
873         (-[WebPreferences isQTKitEnabled]): Deleted.
874         * WebView/WebPreferencesPrivate.h:
875         * WebView/WebView.mm:
876         (-[WebView _preferencesChanged:]):
877
878 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
879
880         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
881         https://bugs.webkit.org/show_bug.cgi?id=181960
882         <rdar://problem/36431678>
883
884         Reviewed by Tim Horton.
885
886         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
887         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
888         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
889
890         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
891         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
892         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
893
894         * WebView/WebView.mm:
895         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
896
897 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
898
899         Turning off custom pasteboard data doesn't actually turn it off in WK2
900         https://bugs.webkit.org/show_bug.cgi?id=181920
901         <rdar://problem/36686429>
902
903         Reviewed by Wenson Hsieh.
904
905         Always disable custom pasteboard data in WebKit1. See r226156 for details.
906
907         * WebView/WebPreferences.mm:
908         (+[WebPreferences initialize]):
909         * WebView/WebView.mm:
910         (-[WebView _preferencesChanged:]):
911
912 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
913
914         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
915         https://bugs.webkit.org/show_bug.cgi?id=181918
916
917         Reviewed by Tim Horton.
918
919         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
920
921         * Configurations/FeatureDefines.xcconfig:
922
923 2018-01-20  Andy Estes  <aestes@apple.com>
924
925         [Apple Pay] Stop eagerly loading PassKit.framework
926         https://bugs.webkit.org/show_bug.cgi?id=181911
927         <rdar://problem/36555369>
928
929         Reviewed by Tim Horton.
930
931         * WebCoreSupport/WebPaymentCoordinatorClient.h:
932         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
933         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
934
935         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
936
937 2018-01-19  Dean Jackson  <dino@apple.com>
938
939         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
940         https://bugs.webkit.org/show_bug.cgi?id=181817
941         <rdar://problem/35274055>
942
943         Reviewed by Simon Fraser.
944
945         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
946
947         * Misc/WebKitVersionChecks.h:
948         * WebView/WebView.mm:
949         (-[WebView _commonInitializationWithFrameName:groupName:]):
950
951 2018-01-19  Alex Christensen  <achristensen@webkit.org>
952
953         Remove unused WebViewPrivate _allowCookies
954         https://bugs.webkit.org/show_bug.cgi?id=181812
955
956         Reviewed by Tim Horton.
957
958         * WebView/WebView.mm:
959         (+[WebView _setAllowCookies:]): Deleted.
960         (+[WebView _allowCookies]): Deleted.
961         * WebView/WebViewPrivate.h:
962
963 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
964
965         Build fix, remove a call to -[NSWindow setOneShot:]
966         https://bugs.webkit.org/show_bug.cgi?id=181809
967
968         Reviewed by Tim Horton.
969
970         * WebView/WebTextCompletionController.mm:
971         (-[WebTextCompletionController _buildUI]):
972
973 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
974
975         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
976
977         * Carbon/HIWebView.mm:
978         (overrideCGContext):
979         (restoreCGContext):
980
981 2018-01-18  Dan Bernstein  <mitz@apple.com>
982
983         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
984         https://bugs.webkit.org/show_bug.cgi?id=181803
985
986         Reviewed by Tim Horton.
987
988         * Configurations/Base.xcconfig: Updated.
989         * Configurations/DebugRelease.xcconfig: Ditto.
990         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
991         * Configurations/Version.xcconfig: Updated.
992         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
993           useful for defining settings that depend on the target macOS version.
994
995 2018-01-17  Youenn Fablet  <youenn@apple.com>
996
997         Put fetch Request.keepalive behind a runtime flag
998         https://bugs.webkit.org/show_bug.cgi?id=181592
999
1000         Reviewed by Chris Dumez.
1001
1002         * WebView/WebPreferenceKeysPrivate.h:
1003         * WebView/WebPreferences.mm:
1004         (+[WebPreferences initialize]):
1005         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1006         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1007         * WebView/WebPreferencesPrivate.h:
1008         * WebView/WebView.mm:
1009         (-[WebView _preferencesChanged:]):
1010
1011 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1012
1013         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1014         https://bugs.webkit.org/show_bug.cgi?id=181637
1015         <rdar://problem/36508471>
1016
1017         Reviewed by Tim Horton.
1018
1019         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1020
1021         * WebCoreSupport/WebEditorClient.h:
1022         * WebCoreSupport/WebEditorClient.mm:
1023         (WebEditorClient::replacementURLForResource):
1024
1025 2018-01-11  Keith Miller  <keith_miller@apple.com>
1026
1027         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1028         https://bugs.webkit.org/show_bug.cgi?id=181573
1029
1030         Reviewed by Simon Fraser.
1031
1032         * Configurations/FeatureDefines.xcconfig:
1033
1034 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1035
1036         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1037         https://bugs.webkit.org/show_bug.cgi?id=181497
1038
1039         Reviewed by Tim Horton.
1040
1041         See other ChangeLogs for more detail.
1042
1043         * WebCoreSupport/WebDragClient.h:
1044
1045 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1046
1047         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1048         https://bugs.webkit.org/show_bug.cgi?id=181523
1049         <rdar://problem/28959131>
1050
1051         Reviewed by Alex Christensen.
1052
1053         * WebView/WebImmediateActionController.mm:
1054         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1055         Apply the change made in r216652 to WebKit1's immediate action controller.
1056
1057         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1058         the startContainer of the range is in an anonymous node.
1059
1060 2018-01-11  Youenn Fablet  <youenn@apple.com>
1061
1062         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1063         https://bugs.webkit.org/show_bug.cgi?id=181480
1064
1065         Reviewed by Eric Carlson.
1066
1067         * WebView/WebPreferences.mm:
1068         (+[WebPreferences initialize]):
1069
1070 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1071
1072         Fix check-webkit-style issues with WebNSDataExtras.mm
1073         <https://webkit.org/b/181369>
1074
1075         Reviewed by Alex Christensen.
1076
1077         * Misc/WebNSDataExtras.mm:
1078         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1079         (-[NSData _webkit_guessedMIMETypeForXML]):
1080         (-[NSData _webkit_guessedMIMEType]):
1081         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1082         (_findEOL):
1083         (-[NSData _webkit_parseRFC822HeaderFields]):
1084         (-[NSData _web_locationAfterFirstBlankLine]):
1085         - Fix all the check-webkit-style warnings.
1086
1087 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1088
1089         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1090         <https://webkit.org/b/181256>
1091         <rdar://problem/36281730>
1092
1093         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1094         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1095         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1096           to avoid warnings from casting CFStringRef to NPNSString*.
1097           Note that CFMutableStringRef is the same as CFStringRef
1098           without the const modifier, hence its use in the const_cast<>
1099           above.
1100
1101 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1102
1103         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1104         <https://webkit.org/b/181256>
1105         <rdar://problem/36281730>
1106
1107         * Carbon/HIWebView.mm:
1108         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1109         checked_cf_cast<CFRunLoopRef>() to fix warning.
1110
1111 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1112
1113         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1114         <https://webkit.org/b/181256>
1115         <rdar://problem/36281730>
1116
1117         Reviewed by Darin Adler.
1118
1119         * Carbon/CarbonUtils.m:
1120         (PoolCleaner):
1121         - Use #pragmas to ignore -Wcast-qual warnings when using a
1122           C-style cast from CFTypeRef to CFRunloopRef.
1123         * Carbon/CarbonWindowFrame.m:
1124         (-[CarbonWindowFrame title]):
1125         - Use #pragmas to ignore -Wcast-qual warnings when using a
1126           C-style cast from CFStringRef to NSString *.
1127         * Carbon/HIViewAdapter.m:
1128         (+[HIViewAdapter getHIViewForNSView:]):
1129         - Use #pragmas to ignore -Wcast-qual warnings when using a
1130           C-style cast from CFTypeRef to HIViewRef.
1131         * Configurations/Base.xcconfig:
1132         (WARNING_CFLAGS): Add -Wcast-qual.
1133         * Misc/WebElementDictionary.mm:
1134         (-[WebElementDictionary objectForKey:]):
1135         - Use static_cast<SEL>(const_cast<void*>()) to fix
1136           warning.
1137         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1138         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1139         (-[NSData _webkit_guessedMIMETypeForXML]):
1140         (-[NSData _webkit_guessedMIMEType]):
1141         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1142         (_findEOL):
1143         (-[NSData _webkit_parseRFC822HeaderFields]):
1144         (-[NSData _web_startsWithBlankLine]):
1145         (-[NSData _web_locationAfterFirstBlankLine]):
1146         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1147           type to Objective-C++.  This fixes the warnings about
1148           discarding the `const` modifier when casing from CFStringRef
1149           to NSString * because in older clang versions, -Wcast-qual was
1150           completely broken when compiling C++ and Objective-C++ source
1151           files.  In newer clang versions, discarding the `const`
1152           modifier for toll-free bridged types is ignored when compiling
1153           Objective-C++ source.
1154         - Update copyright and license header.
1155         - Use reinterpret_cast<> and static_cast<> to fix warnings
1156           unrelated to (NSString *) C-style casts.
1157         - Replace use of MIN() macro with std::min<> template functions.
1158         - Fix location of `*` for local variables modified above.
1159         * Plugins/Hosted/NetscapePluginHostManager.mm:
1160         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1161         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1162         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1163         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1164           warnings.
1165         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1166         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1167         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1168           to fix warning.
1169         * Plugins/Hosted/ProxyInstance.mm:
1170         (WebKit::ProxyInstance::invoke):
1171         - Use static_cast<char*>(const_cast<void*>()) to fix
1172           warning when using -[NSData bytes].
1173         (WebKit::ProxyInstance::fieldValue const):
1174         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1175           to fix warning when using CFDataGetBytePtr().
1176         * Plugins/Hosted/WebTextInputWindowController.m:
1177         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1178         - Use #pragma to ignore -Wcast-qual warning since there
1179           is not a good way to avoid this warning in Objective-C.
1180         * Plugins/WebNetscapePluginStream.mm:
1181         (WebNetscapePluginStream::deliverData):
1182         - Use const_cast<void*>() to fix warning when using
1183           -[NSData bytes].
1184         * Plugins/WebNetscapePluginView.mm:
1185         (-[WebNetscapePluginView _createPlugin]):
1186         - Change C-style cast to const_cast<char*>() to fix
1187           warning.
1188         * WebCoreSupport/WebChromeClient.mm:
1189         (WebChromeClient::wrapCryptoKey const):
1190         (WebChromeClient::unwrapCryptoKey const):
1191         - Change C-style cast to
1192           static_cast<uint8_t*>(const_cast<void*>() to fix
1193           warning.
1194         * WebView/WebPDFView.mm:
1195         (_applicationInfoForMIMEType):
1196         - Change local variable type from 'NSURL *' to
1197           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1198           when calling -[NSURL path].
1199
1200 2018-01-05  Dan Bernstein  <mitz@apple.com>
1201
1202         Fixed the build following AppKit API deprecations in a recent SDKs
1203
1204         * WebView/WebFullScreenController.mm:
1205         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1206         (-[WebFullScreenController exitFullScreen]): Ditto.
1207         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1208         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1209         * WebView/WebHTMLView.mm:
1210         (-[WebHTMLView drawRect:]): Ditto.
1211         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1212         (-[WebHTMLView knowsPageRange:]): Ditto.
1213         * WebView/WebView.mm:
1214         (LayerFlushController::flushLayers): Ditto.
1215
1216 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1217
1218         [Attachment Support] Create attachment elements when dropping files on iOS
1219         https://bugs.webkit.org/show_bug.cgi?id=181192
1220         <rdar://problem/36280945>
1221
1222         Reviewed by Tim Horton.
1223
1224         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1225
1226         * WebCoreSupport/WebPlatformStrategies.h:
1227         * WebCoreSupport/WebPlatformStrategies.mm:
1228         (WebPlatformStrategies::informationForItemAtIndex):
1229         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1230
1231 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1232
1233         [Attachment Support] Add plumbing for starting a drag with promised blob data
1234         https://bugs.webkit.org/show_bug.cgi?id=181201
1235
1236         Reviewed by Tim Horton.
1237
1238         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1239
1240         * WebCoreSupport/WebDragClient.h:
1241
1242 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1243
1244         Add a WebAuthentication runtime feature flag
1245         https://bugs.webkit.org/show_bug.cgi?id=181220
1246         <rdar://problem/36055305>
1247
1248         Reviewed by Brent Fulgham.
1249
1250         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1251
1252         * WebView/WebPreferenceKeysPrivate.h:
1253         * WebView/WebPreferences.mm:
1254         (+[WebPreferences initialize]):
1255         (-[WebPreferences webAuthenticationEnabled]):
1256         (-[WebPreferences setWebAuthenticationEnabled:]):
1257         (-[WebPreferences credentialManagementEnabled]): Deleted.
1258         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1259         * WebView/WebPreferencesPrivate.h:
1260         * WebView/WebView.mm:
1261         (-[WebView _preferencesChanged:]):
1262
1263 2017-12-22  Jeff Miller  <jeffm@apple.com>
1264
1265         Update user-visible copyright strings to include 2018
1266         https://bugs.webkit.org/show_bug.cgi?id=181141
1267
1268         Reviewed by Dan Bernstein.
1269
1270         * Info.plist:
1271
1272 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1273
1274         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1275         https://bugs.webkit.org/show_bug.cgi?id=181188
1276
1277         Reviewed by Dan Bernstein.
1278
1279         See WebCore/ChangeLog for more detail.
1280
1281         * WebCoreSupport/WebDragClient.h:
1282         * WebCoreSupport/WebDragClient.mm:
1283         (WebDragClient::declareAndWriteAttachment): Deleted.
1284         * WebView/WebHTMLView.mm:
1285         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1286
1287 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1288
1289         Unreviewed, continue to fix build failures due to AppKit API deprecation
1290
1291         Wraps more code in -Wdeprecated-declarations.
1292
1293         * Carbon/HIWebView.mm:
1294         (overrideCGContext):
1295
1296 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1297
1298         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1299
1300         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1301
1302         * Carbon/CarbonWindowAdapter.mm:
1303         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1304         * Plugins/WebNetscapePluginView.mm:
1305         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1306         (-[WebNetscapePluginView sendDrawRectEvent:]):
1307         (-[WebNetscapePluginView drawRect:]):
1308
1309 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1310
1311         Fix build failures due to using deprecated AppKit symbols
1312         https://bugs.webkit.org/show_bug.cgi?id=181110
1313         <rdar://problem/36162865>
1314
1315         Reviewed by Dan Bernstein and Tim Horton.
1316
1317         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1318
1319         * Misc/WebKitNSStringExtras.mm:
1320         (-[NSString _web_drawAtPoint:font:textColor:]):
1321         * Misc/WebNSPasteboardExtras.h:
1322         * Misc/WebNSPasteboardExtras.mm:
1323         (+[NSPasteboard _web_writableTypesForURL]):
1324         (_createWritableTypesForImageWithoutArchive):
1325         (_createWritableTypesForImageWithArchive):
1326         (+[NSPasteboard _web_dragTypesForURL]):
1327         (-[NSPasteboard _web_bestURL]):
1328         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1329         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1330         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1331         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1332         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1333         * Panels/WebAuthenticationPanel.m:
1334         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1335         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1336         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1337         (-[WebHostedNetscapePluginView drawRect:]):
1338         * WebInspector/WebNodeHighlightView.mm:
1339         (-[WebNodeHighlightView drawRect:]):
1340         * WebView/WebFrame.mm:
1341         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1342         (-[WebFrame _drawRect:contentsOnly:]):
1343         * WebView/WebHTMLView.mm:
1344         (kit):
1345         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1346         (-[WebHTMLView _plainTextFromPasteboard:]):
1347         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1348         (+[WebHTMLView _insertablePasteboardTypes]):
1349         (+[WebHTMLView _selectionPasteboardTypes]):
1350         (-[WebHTMLView pasteboard:provideDataForType:]):
1351         (-[WebHTMLView _writeSelectionToPasteboard:]):
1352         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1353         (-[WebHTMLView validRequestorForSendType:returnType:]):
1354         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1355         (createMenuItem):
1356         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1357         (-[WebHTMLView _colorAsString:]):
1358         (-[WebHTMLView copyFont:]):
1359         * WebView/WebPDFView.mm:
1360         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1361         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1362         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1363         (-[WebPDFView pasteboardTypesForSelection]):
1364         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1365         * WebView/WebView.h:
1366         * WebView/WebView.mm:
1367         (-[WebView performDragOperation:]):
1368         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1369         (-[WebView _searchWithGoogleFromMenu:]):
1370
1371 2017-12-21  Youenn Fablet  <youenn@apple.com>
1372
1373         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1374         https://bugs.webkit.org/show_bug.cgi?id=181000
1375
1376         Reviewed by Chris Dumez.
1377
1378         * Misc/WebCache.mm:
1379         (+[WebCache addImageToCache:forURL:forFrame:]):
1380
1381 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1382
1383         Update FULLSCREEN_API feature defines.
1384         https://bugs.webkit.org/show_bug.cgi?id=181015
1385
1386         Reviewed by Tim Horton.
1387
1388         Change enabled iphone sdk for FULLSCREEN_API.
1389
1390         * Configurations/FeatureDefines.xcconfig:
1391
1392 2017-12-21  Jer Noble  <jer.noble@apple.com>
1393
1394         Add initial DOM support for Media Capabilities
1395         https://bugs.webkit.org/show_bug.cgi?id=181064
1396
1397         Reviewed by Eric Carlson.
1398
1399         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1400
1401         * WebView/WebPreferenceKeysPrivate.h:
1402         * WebView/WebPreferences.mm:
1403         (+[WebPreferences initialize]):
1404         (-[WebPreferences mediaCapabilitiesEnabled]):
1405         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1406         * WebView/WebPreferencesPrivate.h:
1407         * WebView/WebView.mm:
1408         (-[WebView _preferencesChanged:]):
1409
1410 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1411
1412         Enable picture-in-picture from inline element on suspend.
1413         https://bugs.webkit.org/show_bug.cgi?id=180942
1414         rdar://problem/34745234
1415
1416         Reviewed by Jer Noble.
1417
1418         Update signature of enterVideoFullscreenForVideoElement().
1419
1420         * WebCoreSupport/WebChromeClient.h:
1421         * WebCoreSupport/WebChromeClient.mm:
1422         (WebChromeClient::enterVideoFullscreenForVideoElement):
1423
1424 2017-12-20  Daniel Bates  <dabates@apple.com>
1425
1426         Remove Alternative Presentation Button
1427         https://bugs.webkit.org/show_bug.cgi?id=180500
1428         <rdar://problem/35891047>
1429
1430         Reviewed by Simon Fraser.
1431
1432         We no longer need the alternative presentation button.
1433
1434         * Configurations/FeatureDefines.xcconfig:
1435
1436 2017-12-19  Jer Noble  <jer.noble@apple.com>
1437
1438         Playing media elements which call "pause(); play()" will have the play promise rejected.
1439         https://bugs.webkit.org/show_bug.cgi?id=180781
1440         <rdar://problem/33191377>
1441
1442         Reviewed by Eric Carlson.
1443
1444         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1445
1446         * WebView/WebView.mm:
1447         (shouldRequireUserGestureToLoadVideo):
1448
1449 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1450
1451         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1452         https://bugs.webkit.org/show_bug.cgi?id=180977
1453
1454         Reviewed by Tim Horton.
1455
1456         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1457         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1458         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1459
1460         * WebCoreSupport/WebEditorClient.mm:
1461         (attributesForAttributedStringConversion):
1462         * WebView/WebHTMLView.mm:
1463         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1464
1465 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1466
1467         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1468
1469         Attempt to fix the following warnings:
1470
1471             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1472
1473         For the following instance variables:
1474
1475             _borderView
1476             _contentView
1477             _frame
1478             _wFlags
1479
1480         * Carbon/CarbonWindowAdapter.mm:
1481         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1482         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1483         (-[CarbonWindowAdapter _termWindowIfOwner]):
1484         (-[CarbonWindowAdapter _windowMovedToRect:]):
1485         (-[CarbonWindowAdapter setContentView:]):
1486         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1487         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1488
1489 2017-12-16  Dan Bernstein  <mitz@apple.com>
1490
1491         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1492         https://bugs.webkit.org/show_bug.cgi?id=180613
1493         <rdar://problem/35946124>
1494
1495         Reviewed by Geoff Garen.
1496
1497         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1498           clients.
1499         * WebView/WebDynamicScrollBarsView.h: Ditto.
1500         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1501
1502 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1503
1504         Enable -Wstrict-prototypes for WebKit
1505         <https://webkit.org/b/180757>
1506         <rdar://problem/36024132>
1507
1508         Rubber-stamped by Joseph Pecoraro.
1509
1510         * Configurations/Base.xcconfig:
1511         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1512
1513 2017-12-14  John Wilander  <wilander@apple.com>
1514
1515         Storage Access API: Implement frame-specific access in the document.cookie layer
1516         https://bugs.webkit.org/show_bug.cgi?id=180682
1517         <rdar://problem/35982257>
1518
1519         Reviewed by Alex Christensen.
1520
1521         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1522         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1523         CookiesStrategy::getRawCookies() now take optional parameters for
1524         frameID and pageID to allow frame-specific scoping of cookies.
1525
1526         This change makes the return values of FrameLoaderClient::frameID()
1527         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1528         WebCore can call those getters and get the right return values in
1529         WebKit and std:nullopt in WebKitLegacy.
1530
1531         * WebCoreSupport/WebFrameLoaderClient.h:
1532         * WebCoreSupport/WebFrameLoaderClient.mm:
1533         (WebFrameLoaderClient::pageID const):
1534         (WebFrameLoaderClient::frameID const):
1535         * WebCoreSupport/WebPlatformStrategies.h:
1536         * WebCoreSupport/WebPlatformStrategies.mm:
1537         (WebPlatformStrategies::cookiesForDOM):
1538         (WebPlatformStrategies::setCookiesFromDOM):
1539         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1540         (WebPlatformStrategies::getRawCookies):
1541
1542 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1543
1544         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1545         https://bugs.webkit.org/show_bug.cgi?id=180689
1546
1547         Reviewed by Tim Horton.
1548
1549         Use sRGBColorSpaceRef() from WebCore.
1550
1551         * WebView/WebHTMLView.mm:
1552         (imageFromRect):
1553
1554 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1555
1556         Stop using deprecated target conditional for simulator builds
1557         https://bugs.webkit.org/show_bug.cgi?id=180662
1558         <rdar://problem/35136156>
1559
1560         Reviewed by Simon Fraser.
1561
1562         * postprocess-headers.sh:
1563
1564 2017-12-11  David Quesada  <david_quesada@apple.com>
1565
1566         Turn on ENABLE_APPLICATION_MANIFEST
1567         https://bugs.webkit.org/show_bug.cgi?id=180562
1568         rdar://problem/35924737
1569
1570         Reviewed by Geoffrey Garen.
1571
1572         * Configurations/FeatureDefines.xcconfig:
1573
1574 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1575
1576         Remove pthread_once in favor of dispatch_once
1577         https://bugs.webkit.org/show_bug.cgi?id=180591
1578
1579         Reviewed by Saam Barati.
1580
1581         * Misc/WebKitErrors.m:
1582         (+[NSError _registerWebKitErrors]):
1583         (registerErrors): Deleted.
1584         * Storage/WebStorageManager.mm:
1585         (+[WebStorageManager _storageDirectoryPath]):
1586         (initializeLocalStoragePath): Deleted.
1587
1588 2017-12-07  Darin Adler  <darin@apple.com>
1589
1590         Remove some unused code from WebKitLegacy
1591         https://bugs.webkit.org/show_bug.cgi?id=180567
1592
1593         Reviewed by Anders Carlsson.
1594
1595         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1596         macOS (back a few versions) and iOS and removed unused
1597         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1598         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1599         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1600         _webkit_stringByCollapsingNonPrintingCharacters,
1601         _webkit_stringByCollapsingWhitespaceCharacters,
1602         _web_stringWithData:textEncodingName:, and
1603         _webkit_localStorageDirectoryWithBundleIdentifier:.
1604
1605         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1606         this source file.
1607         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1608         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1609         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1610         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1611         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1612         handle font smoothing options.
1613         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1614         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1615         from header and made it a little clearer.
1616         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1617         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1618         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1619         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1620         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1621         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1622         implementation a bit and used whole words instead of abbreviations.
1623         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1624
1625         * Misc/WebNSFileManagerExtras.mm:
1626         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1627         filenameByFixingIllegalCharacters function from WebCore directly instead of
1628         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1629
1630         * Plugins/WebBaseNetscapePluginView.mm:
1631         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1632         string replacements instead of _web_stringByStrippingReturnCharacters
1633         and to use NSString methods instead of CFString functions.
1634
1635 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1636
1637         Ignore deprecation warnings.
1638
1639         * WebView/WebHTMLView.mm:
1640         (-[NSWindow _web_borderView]):
1641         (-[WebHTMLView _setAsideSubviews]):
1642         * WebView/WebView.mm:
1643         (-[WebView encodeWithCoder:]):
1644
1645 2017-12-02  Darin Adler  <darin@apple.com>
1646
1647         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1648         https://bugs.webkit.org/show_bug.cgi?id=180009
1649
1650         Reviewed by Alex Christensen.
1651
1652         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1653
1654         * Plugins/WebBaseNetscapePluginView.mm:
1655         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1656         of strcasecmp.
1657
1658         * WebView/WebPreferences.mm:
1659         (contains): Ditto. Also made this a template so it's easier to call on an array.
1660         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1661
1662 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1663
1664         Limit user agent versioning to an upper bound
1665         https://bugs.webkit.org/show_bug.cgi?id=180365
1666         <rdar://problem/34550617>
1667
1668         Reviewed by Joseph Pecoraro.
1669
1670         * WebView/WebView.mm:
1671         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1672         creating the User Agent string.
1673         (webKitBundleVersionString): Deleted.
1674
1675 2017-12-05  Andy Estes  <aestes@apple.com>
1676
1677         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1678         https://bugs.webkit.org/show_bug.cgi?id=180457
1679         <rdar://problem/35143007>
1680
1681         Reviewed by Tim Horton.
1682
1683         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1684         check for this macro during post-processing.
1685
1686         * postprocess-headers.sh:
1687
1688 2017-12-04  David Quesada  <david_quesada@apple.com>
1689
1690         Add a class for parsing application manifests
1691         https://bugs.webkit.org/show_bug.cgi?id=177973
1692         rdar://problem/34747949
1693
1694         Reviewed by Geoffrey Garen.
1695
1696         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1697
1698 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1699
1700         Make LegacyCustomProtocolManager optional for network process
1701         https://bugs.webkit.org/show_bug.cgi?id=176230
1702
1703         Reviewed by Alex Christensen.
1704
1705         * Configurations/FeatureDefines.xcconfig:
1706
1707 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1708
1709         Fix some NSOperationQueue leaks
1710         https://bugs.webkit.org/show_bug.cgi?id=180221
1711
1712         Reviewed by Wenson Hsieh.
1713
1714         * WebView/WebView.mm:
1715         (-[WebView performDragOperation:]):
1716
1717 2017-11-30  Darin Adler  <darin@apple.com>
1718
1719         [Mac] remove unneeded RetainPtr use introduced in r225142
1720         https://bugs.webkit.org/show_bug.cgi?id=180202
1721
1722         Reviewed by Tim Horton.
1723
1724         * WebView/WebImmediateActionController.mm:
1725         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1726         RetainPtr.
1727
1728 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1729
1730         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1731         https://bugs.webkit.org/show_bug.cgi?id=175595
1732
1733         Reviewed by Darin Adler.
1734
1735         * WebView/WebPreferences.mm:
1736
1737 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1738
1739         One too many zeroes in macOS version number in FeatureDefines
1740         https://bugs.webkit.org/show_bug.cgi?id=180011
1741
1742         Reviewed by Dan Bernstein.
1743
1744         * Configurations/FeatureDefines.xcconfig:
1745
1746 2017-11-23  Darin Adler  <darin@apple.com>
1747
1748         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1749         https://bugs.webkit.org/show_bug.cgi?id=179981
1750
1751         Reviewed by Sam Weinig.
1752
1753         * WebView/WebImmediateActionController.mm:
1754         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1755         * WebView/WebView.mm:
1756         (coreOptions): Use |= instead of | to build up FindOptions.
1757
1758 2017-11-23  Sam Weinig  <sam@webkit.org>
1759
1760         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1761         https://bugs.webkit.org/show_bug.cgi?id=179954
1762
1763         Reviewed by Darin Adler.
1764
1765         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1766         with direct calls to the corresponding UserGestureIndicator functions.
1767
1768         * Plugins/WebPluginController.mm:
1769         (-[WebPluginController processingUserGesture]):
1770         * WebView/WebView.mm:
1771         (-[WebView _isProcessingUserGesture]):
1772
1773 2017-11-23  Darin Adler  <darin@apple.com>
1774
1775         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1776         https://bugs.webkit.org/show_bug.cgi?id=179907
1777
1778         Reviewed by Sam Weinig.
1779
1780         * History/BinaryPropertyList.cpp:
1781         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1782         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1783         * WebView/WebHTMLRepresentation.mm:
1784         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1785         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1786
1787 2017-11-22  Ali Juma  <ajuma@chromium.org>
1788
1789         Implement VisualViewport API attributes
1790         https://bugs.webkit.org/show_bug.cgi?id=179385
1791
1792         Reviewed by Frédéric Wang.
1793
1794         Add a VisualViewportAPI preference.
1795
1796         * WebView/WebPreferenceKeysPrivate.h:
1797         * WebView/WebPreferences.mm:
1798         (+[WebPreferences initialize]):
1799         (-[WebPreferences visualViewportAPIEnabled]):
1800         (-[WebPreferences setVisualViewportAPIEnabled:]):
1801         * WebView/WebPreferencesPrivate.h:
1802         * WebView/WebView.mm:
1803         (-[WebView _preferencesChanged:]):
1804
1805 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1806
1807         WebCoreObjCExtras.h is being included in too many places
1808         https://bugs.webkit.org/show_bug.cgi?id=179931
1809
1810         Reviewed by Darin Adler.
1811
1812         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1813         * Plugins/WebBaseNetscapePluginView.mm:
1814         * Plugins/WebBasePluginPackage.mm:
1815         * Plugins/WebNetscapePluginStream.mm:
1816         * Plugins/WebNetscapePluginView.mm:
1817         * WebView/WebTextIterator.mm:
1818         * WebView/WebViewData.mm:
1819
1820 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1821
1822         Unreviewed, rolling out r225093.
1823         https://bugs.webkit.org/show_bug.cgi?id=179938
1824
1825         Compilation failed on WinCairo 64-bit Release (Requested by
1826         fredw on #webkit).
1827
1828         Reverted changeset:
1829
1830         "Implement VisualViewport API attributes"
1831         https://bugs.webkit.org/show_bug.cgi?id=179385
1832         https://trac.webkit.org/changeset/225093
1833
1834 2017-11-21  Ali Juma  <ajuma@chromium.org>
1835
1836         Implement VisualViewport API attributes
1837         https://bugs.webkit.org/show_bug.cgi?id=179385
1838
1839         Reviewed by Frédéric Wang.
1840
1841         Add a VisualViewportAPI preference.
1842
1843         * WebView/WebPreferenceKeysPrivate.h:
1844         * WebView/WebPreferences.mm:
1845         (+[WebPreferences initialize]):
1846         (-[WebPreferences visualViewportAPIEnabled]):
1847         (-[WebPreferences setVisualViewportAPIEnabled:]):
1848         * WebView/WebPreferencesPrivate.h:
1849         * WebView/WebView.mm:
1850         (-[WebView _preferencesChanged:]):
1851
1852 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1853
1854         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1855         https://bugs.webkit.org/show_bug.cgi?id=179504
1856
1857         Reviewed by Darin Adler.
1858
1859         * Misc/WebKitNSStringExtras.mm:
1860         * Plugins/Hosted/NetscapePluginHostManager.mm:
1861         * Plugins/WebBasePluginPackage.mm:
1862
1863 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1864
1865         Remove unused TOUCH_ICON_LOADING feature flag
1866         https://bugs.webkit.org/show_bug.cgi?id=179873
1867
1868         Reviewed by Simon Fraser.
1869
1870         * Configurations/FeatureDefines.xcconfig:
1871
1872 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1873
1874         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1875         https://bugs.webkit.org/show_bug.cgi?id=179872
1876
1877         Reviewed by Darin Adler.
1878
1879         * Configurations/FeatureDefines.xcconfig:
1880
1881 2017-11-16  Daniel Bates  <dabates@apple.com>
1882
1883         Add feature define for alternative presentation button element
1884         https://bugs.webkit.org/show_bug.cgi?id=179692
1885         Part of <rdar://problem/34917108>
1886
1887         Reviewed by Andy Estes.
1888
1889         Only enabled on Cocoa platforms by default.
1890
1891         * Configurations/FeatureDefines.xcconfig:
1892
1893 2017-11-14  Nan Wang  <n_wang@apple.com>
1894
1895         AX: AOM: Implement AccessibleNode class and support label and role attributes
1896         https://bugs.webkit.org/show_bug.cgi?id=179494
1897
1898         Reviewed by Ryosuke Niwa.
1899
1900         * WebView/WebPreferenceKeysPrivate.h:
1901         * WebView/WebPreferences.mm:
1902         (+[WebPreferences initialize]):
1903         (-[WebPreferences accessibilityObjectModelEnabled]):
1904         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1905         * WebView/WebPreferencesPrivate.h:
1906         * WebView/WebView.mm:
1907         (-[WebView _preferencesChanged:]):
1908
1909 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1910
1911         Remove Cocoa CFURLConnection loading code
1912         https://bugs.webkit.org/show_bug.cgi?id=179688
1913
1914         Reviewed by Antti Koivisto.
1915
1916         * Misc/WebDownload.mm:
1917         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1918         * Misc/WebDownloadInternal.h:
1919         * Plugins/WebBaseNetscapePluginView.mm:
1920         * WebCoreSupport/WebFrameLoaderClient.mm:
1921         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1922         * WebView/WebView.mm:
1923         (-[WebView scheduleInRunLoop:forMode:]):
1924         (-[WebView unscheduleFromRunLoop:forMode:]):
1925
1926 2017-11-14  Daniel Bates  <dabates@apple.com>
1927
1928         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1929         for feature defines
1930
1931         Following r195498 and r201917 the Visual Studio property files for feature defines have
1932         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1933         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1934         files.
1935
1936         * Configurations/FeatureDefines.xcconfig:
1937
1938 2017-11-14  Jer Noble  <jer.noble@apple.com>
1939
1940         Enable Modern EME tests in DumpRenderTree
1941         https://bugs.webkit.org/show_bug.cgi?id=179544
1942
1943         Reviewed by Alex Christensen.
1944
1945         Add a WebPreferences property to enable the (modern) EME API.
1946
1947         * WebView/WebPreferenceKeysPrivate.h:
1948         * WebView/WebPreferences.mm:
1949         (+[WebPreferences initialize]):
1950         (-[WebPreferences encryptedMediaAPIEnabled]):
1951         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1952         * WebView/WebPreferencesPrivate.h:
1953         * WebView/WebView.mm:
1954         (-[WebView _preferencesChanged:]):
1955
1956 2017-11-14  Antti Koivisto  <antti@apple.com>
1957
1958         Enable display:contents by default
1959         https://bugs.webkit.org/show_bug.cgi?id=179655
1960
1961         Reviewed by Sam Weinig.
1962
1963         * WebView/WebPreferences.mm:
1964         (+[WebPreferences initialize]):
1965
1966 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1967
1968         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1969         https://bugs.webkit.org/show_bug.cgi?id=178751
1970
1971         Reviewed by Brady Eidson.
1972
1973         * WebCoreSupport/WebFrameNetworkingContext.mm:
1974         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1975
1976 2017-11-08  Keith Miller  <keith_miller@apple.com>
1977
1978         Async iteration should only fetch the next method once and add feature flag
1979         https://bugs.webkit.org/show_bug.cgi?id=179451
1980
1981         Reviewed by Geoffrey Garen.
1982
1983         Add feature flag for Async iteration.
1984
1985         * Configurations/FeatureDefines.xcconfig:
1986
1987 2017-11-13  Mark Lam  <mark.lam@apple.com>
1988
1989         Add more overflow check book-keeping for MarkedArgumentBuffer.
1990         https://bugs.webkit.org/show_bug.cgi?id=179634
1991         <rdar://problem/35492517>
1992
1993         Reviewed by Saam Barati.
1994
1995         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1996         (WebKit::NetscapePluginInstanceProxy::invoke):
1997         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1998         (WebKit::NetscapePluginInstanceProxy::construct):
1999
2000 2017-11-12  Darin Adler  <darin@apple.com>
2001
2002         More is<> and downcast<>, less static_cast<>
2003         https://bugs.webkit.org/show_bug.cgi?id=179600
2004
2005         Reviewed by Chris Dumez.
2006
2007         * DOM/DOM.mm:
2008         (kit): Use is/downcast.
2009         * WebCoreSupport/WebEditorClient.mm:
2010         (WebEditorClient::handleKeyboardEvent): Ditto.
2011         (WebEditorClient::handleInputMethodKeydown): Ditto.
2012         * WebView/WebHTMLView.mm:
2013         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2014
2015 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2016
2017         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2018         https://bugs.webkit.org/show_bug.cgi?id=179397
2019
2020         Reviewed by Wenson Hsieh.
2021
2022         * DOM/DOMHTMLInputElement.mm:
2023         (-[DOMHTMLInputElement insertTextSuggestion:]):
2024
2025 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2026
2027         HTMLMediaElement should not use element fullscreen on iOS
2028         https://bugs.webkit.org/show_bug.cgi?id=179418
2029         rdar://problem/35409277
2030
2031         Reviewed by Eric Carlson.
2032
2033         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2034
2035         * Configurations/FeatureDefines.xcconfig:
2036
2037 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2038
2039         Make ResourceLoader::willSendRequestInternal asynchronous
2040         https://bugs.webkit.org/show_bug.cgi?id=179251
2041
2042         Reviewed by Andy Estes.
2043
2044         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2045         (WebKit::HostedNetscapePluginStream::start):
2046         * Plugins/WebNetscapePluginStream.mm:
2047         (WebNetscapePluginStream::start):
2048
2049 2017-11-01  Darin Adler  <darin@apple.com>
2050
2051         Simplify event dispatch code and make it a bit more consistent
2052         https://bugs.webkit.org/show_bug.cgi?id=178991
2053
2054         Reviewed by Chris Dumez.
2055
2056         * DOM/DOMEvent.mm:
2057         (-[DOMEvent srcElement]): Call target instead of srcElement.
2058
2059 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2060
2061         [Touch Bar Web API] Add support for menuitem tag
2062         https://bugs.webkit.org/show_bug.cgi?id=179020
2063
2064         Reviewed by Ryosuke Niwa.
2065
2066         Adds in properties and methods that allow the menuitem runtime feature
2067         to be enabled or disabled.
2068
2069         * WebView/WebPreferenceKeysPrivate.h:
2070         * WebView/WebPreferences.mm:
2071         (-[WebPreferences menuItemElementEnabled]):
2072         (-[WebPreferences setMenuItemElementEnabled:]):
2073         * WebView/WebPreferencesPrivate.h:
2074         * WebView/WebView.mm:
2075         (-[WebView _preferencesChanged:]):
2076
2077 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2078
2079         Use CompletionHandlers for redirects
2080         https://bugs.webkit.org/show_bug.cgi?id=179163
2081
2082         Reviewed by Tim Horton.
2083
2084         * Plugins/Hosted/HostedNetscapePluginStream.h:
2085         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2086         (WebKit::HostedNetscapePluginStream::willSendRequest):
2087         * Plugins/WebNetscapePluginStream.h:
2088         * Plugins/WebNetscapePluginStream.mm:
2089         (WebNetscapePluginStream::willSendRequest):
2090
2091 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2092
2093         Add a FileSystem namespace to FileSystem.cpp
2094         https://bugs.webkit.org/show_bug.cgi?id=179063
2095
2096         Reviewed by Darin Adler.
2097
2098         * Misc/WebNSFileManagerExtras.mm:
2099         * Storage/WebDatabaseProvider.mm:
2100
2101 2017-11-02  Frederic Wang  <fwang@igalia.com>
2102
2103         Add references to bug 179167 in FIXME comments
2104         https://bugs.webkit.org/show_bug.cgi?id=179168
2105
2106         Reviewed by Daniel Bates.
2107
2108         * Configurations/FeatureDefines.xcconfig:
2109
2110 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2111
2112         Implement WKFullscreenWindowController for iOS.
2113         https://bugs.webkit.org/show_bug.cgi?id=178924
2114         rdar://problem/34697120
2115
2116         Reviewed by Simon Fraser.
2117
2118         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2119
2120         * Configurations/FeatureDefines.xcconfig:
2121         * WebView/WebView.mm:
2122         (-[WebView fullScreenPlaceholderView]):
2123
2124 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2125
2126         Clean up some drag and drop feature flags
2127         https://bugs.webkit.org/show_bug.cgi?id=179082
2128
2129         Reviewed by Simon Fraser.
2130
2131         * Configurations/FeatureDefines.xcconfig:
2132
2133 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2134
2135         Make it possible to test rubber-banding in overflow scroll
2136         https://bugs.webkit.org/show_bug.cgi?id=179078
2137
2138         Reviewed by Sam Weinig.
2139
2140         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2141         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2142
2143         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2144         functions, since most callers want clamped.
2145
2146         * DOM/DOMHTML.mm:
2147         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2148
2149 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2150
2151         Fix up some content filtering feature flags
2152         https://bugs.webkit.org/show_bug.cgi?id=179079
2153
2154         Reviewed by Simon Fraser.
2155
2156         * Configurations/FeatureDefines.xcconfig:
2157
2158 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2159
2160         [FrameView::layout cleanup] Move core layout logic to a separate class.
2161         https://bugs.webkit.org/show_bug.cgi?id=178771
2162         <rdar://problem/35166542>
2163
2164         Reviewed by Simon Fraser.
2165
2166         Move layout code out from FrameView to LayoutContext.
2167
2168         * WebView/WebClipView.mm:
2169         (-[WebClipView _immediateScrollToPoint:]):
2170         * WebView/WebFrame.mm:
2171         (-[WebFrame layoutCount]):
2172
2173 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2174
2175         Fix issues with WebView subframe painting
2176         https://bugs.webkit.org/show_bug.cgi?id=178842
2177         rdar://problem/34072253
2178
2179         Reviewed by Daniel Bates.
2180         
2181         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2182         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2183         High Sierra, so match the new signature.
2184
2185         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2186
2187         * WebView/WebHTMLView.mm:
2188         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2189         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2190
2191 2017-10-25  Youenn Fablet  <youenn@apple.com>
2192
2193         Enable ServiceWorker to fetch resources
2194         https://bugs.webkit.org/show_bug.cgi?id=178673
2195
2196         Reviewed by Brady Eidson.
2197
2198         * WebCoreSupport/WebFrameLoaderClient.mm:
2199         (WebFrameLoaderClient::pageID const):
2200         (WebFrameLoaderClient::frameID const):
2201         (WebFrameLoaderClient::sessionID const):
2202
2203         Added implementation to the new getters.
2204         They are noop in the context of WK1.
2205
2206 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2207
2208         Web Inspector: Enable WebKit logging configuration and display
2209         https://bugs.webkit.org/show_bug.cgi?id=177027
2210         <rdar://problem/33964767>
2211
2212         Reviewed by Joseph Pecoraro.
2213
2214         * WebCoreSupport/WebChromeClient.mm:
2215         (stringForMessageSource): Deal with Media and WebRTC message sources.
2216
2217 2017-10-20  Antoine Quint  <graouts@apple.com>
2218
2219         [Web Animations] Provide basic timeline and animation interfaces
2220         https://bugs.webkit.org/show_bug.cgi?id=178526
2221
2222         Reviewed by Dean Jackson.
2223
2224         Remove the WEB_ANIMATIONS compile-time flag.
2225
2226         * Configurations/FeatureDefines.xcconfig:
2227         * WebView/WebPreferences.mm:
2228         (+[WebPreferences initialize]):
2229         * WebView/WebView.mm:
2230         (-[WebView _preferencesChanged:]):
2231
2232 2017-10-19  Sam Weinig  <sam@webkit.org>
2233
2234         [Settings] Move global settings into their own file
2235         https://bugs.webkit.org/show_bug.cgi?id=178512
2236
2237         Reviewed by Darin Adler.
2238
2239         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2240
2241         * WebCoreSupport/WebChromeClient.mm:
2242         (WebChromeClient::supportsVideoFullscreen):
2243         * WebView/WebDynamicScrollBarsView.mm:
2244         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2245         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2246         * WebView/WebPreferences.mm:
2247         (+[WebPreferences initialize]):
2248         * WebView/WebView.mm:
2249         (-[WebView _commonInitializationWithFrameName:groupName:]):
2250         (-[WebView _preferencesChanged:]):
2251         (+[WebView _doNotStartObservingNetworkReachability]):
2252
2253 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2254
2255         Replace some stack raw pointers with RefPtrs within WebCore/html
2256         https://bugs.webkit.org/show_bug.cgi?id=178201
2257         <rdar://problem/34841692>
2258
2259         Reviewed by Ryosuke Niwa.
2260
2261         * DOM/DOM.mm:
2262         (kit):
2263         Change the type of node as toNode() is changed to return RefPtr.
2264
2265 2017-10-18  Chris Dumez  <cdumez@apple.com>
2266
2267         [Service Worker] Add stubs for Client / WindowClient / Clients
2268         https://bugs.webkit.org/show_bug.cgi?id=178469
2269
2270         Reviewed by Youenn Fablet.
2271
2272         Rename PageVisiblityState to VisibilityState.
2273
2274         * WebView/WebView.mm:
2275         (kit):
2276
2277 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2278
2279         Unreviewed, rolling out r223291.
2280
2281         See WebCore ChangeLog for more detail.
2282
2283         Reverted changeset:
2284
2285         "Remove Editor::simplifyMarkup"
2286         https://bugs.webkit.org/show_bug.cgi?id=178271
2287         https://trac.webkit.org/changeset/223291
2288
2289 2017-10-17  Keith Miller  <keith_miller@apple.com>
2290
2291         Change WebCore sources to work with unified source builds
2292         https://bugs.webkit.org/show_bug.cgi?id=178229
2293
2294         Rubber stamped by Tim Horton.
2295
2296         * Configurations/FeatureDefines.xcconfig:
2297
2298 2017-10-16  Sam Weinig  <sam@webkit.org>
2299
2300         [Settings] Remove all custom code from Settings.h/cpp
2301         https://bugs.webkit.org/show_bug.cgi?id=178330
2302
2303         Reviewed by Simon Fraser.
2304
2305         * WebView/WebPreferences.mm:
2306         (+[WebPreferences initialize]):
2307         
2308             Update for naming changes of FrameFlattening now that it is an enum class.
2309
2310 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2311
2312         Remove Editor::simplifyMarkup
2313         https://bugs.webkit.org/show_bug.cgi?id=178271
2314
2315         Reviewed by Wenson Hsieh.
2316
2317         * WebView/WebView.mm:
2318         (-[WebView _simplifyMarkup:endNode:]):
2319
2320 2017-10-12  Chris Dumez  <cdumez@apple.com>
2321
2322         [Mac] Add support for MouseEvent.buttons
2323         https://bugs.webkit.org/show_bug.cgi?id=178214
2324
2325         Reviewed by Ryosuke Niwa.
2326
2327         * WebView/WebPDFView.mm:
2328         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2329
2330 2017-10-11  Sam Weinig  <sam@webkit.org>
2331
2332         Remove out-parameter variants of copyToVector
2333         https://bugs.webkit.org/show_bug.cgi?id=178155
2334
2335         Reviewed by Tim Horton.
2336
2337         * Plugins/WebNetscapePluginView.mm:
2338         (-[WebNetscapePluginView destroyPlugin]):
2339         * WebView/WebHTMLRepresentation.mm:
2340         (newArrayWithStrings):
2341
2342             Replace out-parameter based copyToVector, with one that returns a Vector.
2343
2344 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2345
2346         Sanitize URL in pasteboard for other applications and cross origin content
2347         https://bugs.webkit.org/show_bug.cgi?id=178060
2348         <rdar://problem/34874518>
2349
2350         Reviewed by Wenson Hsieh.
2351
2352         * WebCoreSupport/WebPlatformStrategies.h:
2353         * WebCoreSupport/WebPlatformStrategies.mm:
2354         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2355
2356 2017-10-11  Chris Dumez  <cdumez@apple.com>
2357
2358         Modernize Geolocation code
2359         https://bugs.webkit.org/show_bug.cgi?id=178148
2360
2361         Reviewed by Ryosuke Niwa.
2362
2363         * WebCoreSupport/WebGeolocationClient.h:
2364         * WebCoreSupport/WebGeolocationClient.mm:
2365         (WebGeolocationClient::lastPosition):
2366         * WebView/WebGeolocationPosition.mm:
2367         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2368         (core):
2369         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2370         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2371         * WebView/WebGeolocationPositionInternal.h:
2372
2373 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2374
2375         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2376         https://bugs.webkit.org/show_bug.cgi?id=178154
2377
2378         Reviewed by Wenson Hsieh.
2379
2380         Enable custom pasteboard data by default.
2381
2382         * WebView/WebPreferenceKeysPrivate.h:
2383         * WebView/WebPreferences.mm:
2384         (+[WebPreferences initialize]):
2385         (-[WebPreferences customPasteboardDataEnabled]): Added.
2386         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2387         * WebView/WebPreferencesPrivate.h:
2388         * WebView/WebView.mm:
2389         (-[WebView _preferencesChanged:]):
2390
2391 2017-10-10  Sam Weinig  <sam@webkit.org>
2392
2393         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2394         https://bugs.webkit.org/show_bug.cgi?id=178102
2395
2396         Reviewed by Tim Horton.
2397
2398         * History/WebHistory.mm:
2399         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2400         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2401         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2402         * WebCoreSupport/WebUserMediaClient.mm:
2403         (WebUserMediaClient::pageDestroyed):
2404
2405 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2406
2407         Make the names of the options consistent
2408         https://bugs.webkit.org/show_bug.cgi?id=177933
2409
2410         Reviewed by Saam Barati.
2411
2412         * WebView/WebFrame.h:
2413         * WebView/WebHTMLView.mm:
2414         (-[WebHTMLView setMarkedText:selectedRange:]):
2415         * WebView/WebView.h:
2416
2417 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2418
2419         [iOS] Tweak support for classifying form controls (followup to r222487)
2420         https://bugs.webkit.org/show_bug.cgi?id=177917
2421         <rdar://problem/34820122>
2422
2423         Reviewed by Dean Jackson.
2424
2425         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2426
2427         * DOM/DOMHTMLInputElement.mm:
2428         (-[DOMHTMLInputElement _autofillContext]):
2429         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2430         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2431
2432 2017-10-05  Keith Miller  <keith_miller@apple.com>
2433
2434         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2435
2436         * Configurations/WebKitLegacy.xcconfig:
2437
2438 2017-10-05  Jer Noble  <jer.noble@apple.com>
2439
2440         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2441         https://bugs.webkit.org/show_bug.cgi?id=177261
2442
2443         Reviewed by Eric Carlson.
2444
2445         * Configurations/FeatureDefines.xcconfig:
2446
2447 2017-10-05  Chris Dumez  <cdumez@apple.com>
2448
2449         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2450         https://bugs.webkit.org/show_bug.cgi?id=177957
2451
2452         Reviewed by Alex Christensen.
2453
2454         * WebCoreSupport/WebPlatformStrategies.h:
2455         * WebCoreSupport/WebPlatformStrategies.mm:
2456         (WebPlatformStrategies::cookiesEnabled):
2457
2458 2017-10-05  Youenn Fablet  <youenn@apple.com>
2459
2460         Make LibWebRTCProvider port agnostic
2461         https://bugs.webkit.org/show_bug.cgi?id=177747
2462
2463         Reviewed by Alex Christensen & Alex Garcia.
2464
2465         * WebView/WebView.mm:
2466         (-[WebView _commonInitializationWithFrameName:groupName:]):
2467         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2468
2469 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2470
2471         Stop linking with WebKitSystemInterface
2472         https://bugs.webkit.org/show_bug.cgi?id=177915
2473
2474         Reviewed by Antti Koivisto.
2475
2476         * Configurations/DebugRelease.xcconfig:
2477         * Configurations/WebKitLegacy.xcconfig:
2478
2479 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2480
2481         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2482         https://bugs.webkit.org/show_bug.cgi?id=177912
2483
2484         Reviewed by Saam Barati.
2485
2486         * Carbon/CarbonUtils.m:
2487         * Carbon/CarbonWindowAdapter.mm:
2488         * Carbon/HIWebView.mm:
2489         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2490         * Misc/WebNSFileManagerExtras.mm:
2491         * Misc/WebNSPasteboardExtras.mm:
2492         * Misc/WebNSURLExtras.mm:
2493         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2494         * Plugins/Hosted/NetscapePluginHostManager.mm:
2495         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2496         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2497         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2498         * Plugins/Hosted/WebTextInputWindowController.m:
2499         * Plugins/WebBaseNetscapePluginView.mm:
2500         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2501         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2502         * Plugins/WebNetscapePluginStream.mm:
2503         * Plugins/WebNetscapePluginView.mm:
2504         * Plugins/WebPluginDatabase.mm:
2505         * WebCoreSupport/PopupMenuMac.mm:
2506         * WebCoreSupport/WebChromeClient.mm:
2507         * WebCoreSupport/WebFrameLoaderClient.mm:
2508         * WebCoreSupport/WebInspectorClient.mm:
2509         * WebCoreSupport/WebPlatformStrategies.mm:
2510         * WebCoreSupport/WebSystemInterface.mm:
2511         * WebView/WebDynamicScrollBarsView.mm:
2512         * WebView/WebFrame.mm:
2513         * WebView/WebFrameView.mm:
2514         * WebView/WebFullScreenController.mm:
2515         * WebView/WebHTMLView.mm:
2516         * WebView/WebPreferences.mm:
2517         * WebView/WebView.mm:
2518
2519 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2520
2521         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2522         rdar://problem/34705779
2523
2524         Addressing review comments that I somehow landed without.
2525
2526         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2527
2528 2017-09-29  Chris Dumez  <cdumez@apple.com>
2529
2530         Split some logic out of VisitedLinkStore and make it reusable
2531         https://bugs.webkit.org/show_bug.cgi?id=177575
2532
2533         Reviewed by Alex Christensen.
2534
2535         * WebCoreSupport/WebVisitedLinkStore.h:
2536         * WebCoreSupport/WebVisitedLinkStore.mm:
2537         (WebVisitedLinkStore::addVisitedLink):
2538         (WebVisitedLinkStore::removeVisitedLink):
2539         (WebVisitedLinkStore::isLinkVisited):
2540         (WebVisitedLinkStore::addVisitedLinkHash):
2541
2542 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2543
2544         Build fix for High Sierra 32 bit Mac
2545         https://bugs.webkit.org/show_bug.cgi?id=177551
2546         <rdar://problem/34690283>
2547
2548         Reviewed by Alexey Proskuryakov.
2549
2550         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2551         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2552         also made.
2553
2554         * Carbon/CarbonWindowAdapter.mm:
2555         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2556         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2557         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2558         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2559         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2560         (-[CarbonWindowAdapter dealloc]):
2561         (-[CarbonWindowAdapter windowRef]):
2562         (-[CarbonWindowAdapter _hasWindowRef]):
2563         (-[CarbonWindowAdapter _managesWindowRef]):
2564         (-[CarbonWindowAdapter _removeWindowRef]):
2565         (-[CarbonWindowAdapter _carbonWindowClass]):
2566         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2567         (-[CarbonWindowAdapter sendSuperEvent:]):
2568         (-[CarbonWindowAdapter relinquishFocus]):
2569         (-[CarbonWindowAdapter _cancelKey:]):
2570         (-[CarbonWindowAdapter _commonAwake]):
2571         (-[CarbonWindowAdapter _destroyRealWindow:]):
2572         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2573         (-[CarbonWindowAdapter _termWindowIfOwner]):
2574         (-[CarbonWindowAdapter _windowMovedToRect:]):
2575         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2576         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2577         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2578         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2579         (-[CarbonWindowAdapter canBecomeMainWindow]):
2580         (-[CarbonWindowAdapter encodeWithCoder:]):
2581         (-[CarbonWindowAdapter initWithCoder:]):
2582         (-[CarbonWindowAdapter setContentView:]):
2583         (-[CarbonWindowAdapter worksWhenModal]):
2584         (-[CarbonWindowAdapter _setModalWindowLevel]):
2585         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2586         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2587         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2588         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2589         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2590         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2591         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2592         (NSCarbonWindowHandleEvent):
2593         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2594         (-[CarbonWindowAdapter _growBoxRect]):
2595         * Carbon/HIWebView.mm:
2596         (HIWebViewGetWebView):
2597         (HIWebViewConstructor):
2598         (HIWebViewDestructor):
2599         (HIWebViewRegisterClass):
2600         (GetBehaviors):
2601         (Draw):
2602         (HitTest):
2603         (GetRegion):
2604         (GetWindowRef):
2605         (CreateNSEventAdoptingCGEvent):
2606         (CopyEventCGEvent):
2607         (CreateNSEventWithCarbonClickEvent):
2608         (Click):
2609         (CreateNSEventWithCarbonEvent):
2610         (MouseUp):
2611         (CreateNSEventWithCarbonMouseMoveEvent):
2612         (MouseMoved):
2613         (MouseDragged):
2614         (MouseWheelMoved):
2615         (ContextMenuClick):
2616         (GetKind):
2617         (BoundsChanged):
2618         (OwningWindowChanged):
2619         (WindowHandler):
2620         (SyncFrame):
2621         (SetFocusPart):
2622         (AdvanceFocus):
2623         (RelinquishFocus):
2624         (ActiveStateChanged):
2625         (ProcessCommand):
2626         (UpdateCommandStatus):
2627         (_NSSelectorForHICommand):
2628         (HIWebViewEventHandler):
2629         (StartUpdateObserver):
2630         (StopUpdateObserver):
2631         (UpdateObserver):
2632
2633 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2634
2635         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2636         https://bugs.webkit.org/show_bug.cgi?id=172526
2637         <rdar://problem/32396081>
2638
2639         Reviewed by Ryosuke Niwa.
2640
2641         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2642
2643         * WebCoreSupport/WebPlatformStrategies.h:
2644         * WebCoreSupport/WebPlatformStrategies.mm:
2645         (WebPlatformStrategies::webExposedTypes):
2646         (WebPlatformStrategies::writeCustomData):
2647
2648 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2649
2650         Unreviewed, rolling out r222567.
2651
2652         This broke and internal build.
2653
2654         Reverted changeset:
2655
2656         "Build fix for High Sierra 32 bit Mac"
2657         https://bugs.webkit.org/show_bug.cgi?id=177551
2658         http://trac.webkit.org/changeset/222567
2659
2660 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2661
2662         Build fix for High Sierra 32 bit Mac
2663         https://bugs.webkit.org/show_bug.cgi?id=177551
2664         <rdar://problem/34690283>
2665
2666         Reviewed by Alexey Proskuryakov.
2667
2668         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2669         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2670         also made.
2671
2672         * Carbon/CarbonWindowAdapter.mm:
2673         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2674         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2675         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2676         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2677         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2678         (-[CarbonWindowAdapter dealloc]):
2679         (-[CarbonWindowAdapter windowRef]):
2680         (-[CarbonWindowAdapter _hasWindowRef]):
2681         (-[CarbonWindowAdapter _managesWindowRef]):
2682         (-[CarbonWindowAdapter _removeWindowRef]):
2683         (-[CarbonWindowAdapter _carbonWindowClass]):
2684         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2685         (-[CarbonWindowAdapter sendSuperEvent:]):
2686         (-[CarbonWindowAdapter relinquishFocus]):
2687         (-[CarbonWindowAdapter _cancelKey:]):
2688         (-[CarbonWindowAdapter _commonAwake]):
2689         (-[CarbonWindowAdapter _destroyRealWindow:]):
2690         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2691         (-[CarbonWindowAdapter _termWindowIfOwner]):
2692         (-[CarbonWindowAdapter _windowMovedToRect:]):
2693         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2694         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2695         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2696         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2697         (-[CarbonWindowAdapter canBecomeMainWindow]):
2698         (-[CarbonWindowAdapter encodeWithCoder:]):
2699         (-[CarbonWindowAdapter initWithCoder:]):
2700         (-[CarbonWindowAdapter setContentView:]):
2701         (-[CarbonWindowAdapter worksWhenModal]):
2702         (-[CarbonWindowAdapter _setModalWindowLevel]):
2703         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2704         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2705         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2706         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2707         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2708         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2709         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2710         (NSCarbonWindowHandleEvent):
2711         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2712         (-[CarbonWindowAdapter _growBoxRect]):
2713         * Carbon/HIWebView.mm:
2714         (HIWebViewGetWebView):
2715         (HIWebViewConstructor):
2716         (HIWebViewDestructor):
2717         (HIWebViewRegisterClass):
2718         (GetBehaviors):
2719         (Draw):
2720         (HitTest):
2721         (GetRegion):
2722         (GetWindowRef):
2723         (CreateNSEventAdoptingCGEvent):
2724         (CopyEventCGEvent):
2725         (CreateNSEventWithCarbonClickEvent):
2726         (Click):
2727         (CreateNSEventWithCarbonEvent):
2728         (MouseUp):
2729         (CreateNSEventWithCarbonMouseMoveEvent):
2730         (MouseMoved):
2731         (MouseDragged):
2732         (MouseWheelMoved):
2733         (ContextMenuClick):
2734         (GetKind):
2735         (BoundsChanged):
2736         (OwningWindowChanged):
2737         (WindowHandler):
2738         (SyncFrame):
2739         (SetFocusPart):
2740         (AdvanceFocus):
2741         (RelinquishFocus):
2742         (ActiveStateChanged):
2743         (ProcessCommand):
2744         (UpdateCommandStatus):
2745         (_NSSelectorForHICommand):
2746         (HIWebViewEventHandler):
2747         (StartUpdateObserver):
2748         (StopUpdateObserver):
2749         (UpdateObserver):
2750
2751 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2752
2753         Make PolicyAction an encodable enum class
2754         https://bugs.webkit.org/show_bug.cgi?id=177480
2755
2756         Reviewed by Antti Koivisto.
2757
2758         * Plugins/WebPluginContainerCheck.mm:
2759         (-[WebPluginContainerCheck _continueWithPolicy:]):
2760         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2761         * WebCoreSupport/WebFrameLoaderClient.mm:
2762         (-[WebFramePolicyListener invalidate]):
2763         (-[WebFramePolicyListener ignore]):
2764         (-[WebFramePolicyListener download]):
2765         (-[WebFramePolicyListener use]):
2766         (-[WebFramePolicyListener continue]):
2767         * WebView/WebPolicyDelegate.mm:
2768         (-[WebPolicyDecisionListener use]):
2769         (-[WebPolicyDecisionListener ignore]):
2770         (-[WebPolicyDecisionListener download]):
2771
2772 2017-09-25  Frederik Riedel  <riedel@apple.com>
2773
2774         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2775         https://bugs.webkit.org/show_bug.cgi?id=174394
2776         <rdar://problem/33183504>
2777
2778         Reviewed by Ryosuke Niwa.
2779
2780         * DOM/DOMHTMLInputElement.h:
2781         * DOM/DOMHTMLInputElement.mm:
2782         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2783         Determines if this HTMLInputElement is part of a login screen.
2784         (-[DOMHTMLInputElement representingPageUrl]):
2785         Returns the webpage's URL that is currently displayed in the Web View.
2786         (-[DOMHTMLInputElement insertTextSuggestion:]):
2787         Inserts login credentials into the Web View.
2788
2789 2017-09-25  Sam Weinig  <sam@webkit.org>
2790
2791         Remove unused EditorClient functions
2792         https://bugs.webkit.org/show_bug.cgi?id=177463
2793
2794         Reviewed by Alex Christensen.
2795
2796         Remove unused EditorClient functions.
2797
2798         * WebCoreSupport/WebEditorClient.h:
2799         * WebCoreSupport/WebEditorClient.mm:
2800         (WebEditorClient::canonicalizeURL): Deleted.
2801         (WebEditorClient::canonicalizeURLString): Deleted.
2802         (WebEditorClient::writeDataToPasteboard): Deleted.
2803         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2804         (WebEditorClient::readDataFromPasteboard): Deleted.
2805         (WebEditorClient::pasteboardChangeCount): Deleted.
2806
2807 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2808
2809         Stop using PolicyCallback
2810         https://bugs.webkit.org/show_bug.cgi?id=176088
2811
2812         Reviewed by Andy Estes.
2813
2814         * WebCoreSupport/WebFrameLoaderClient.mm:
2815         (-[WebFramePolicyListener invalidate]):
2816         (-[WebFramePolicyListener receivedPolicyDecision:]):
2817
2818 2017-09-25  Sam Weinig  <sam@webkit.org>
2819
2820         Remove unnecessary userVisibleString EditorClient function
2821         https://bugs.webkit.org/show_bug.cgi?id=177456
2822
2823         Reviewed by Dan Bernstein.
2824
2825         * WebCoreSupport/WebEditorClient.h:
2826         * WebCoreSupport/WebEditorClient.mm:
2827         (WebEditorClient::userVisibleString): Deleted.
2828
2829             Remove userVisibleString client function.
2830
2831 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2832
2833         Separate form submission from PolicyChecker infrastructure
2834         https://bugs.webkit.org/show_bug.cgi?id=177396
2835
2836         Reviewed by Geoffrey Garen.
2837
2838         * WebCoreSupport/WebFrameLoaderClient.h:
2839         * WebCoreSupport/WebFrameLoaderClient.mm:
2840         (WebFrameLoaderClient::dispatchWillSubmitForm):
2841
2842 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2843
2844         WeakPtrFactory should populate m_ref lazily.
2845         https://bugs.webkit.org/show_bug.cgi?id=177375
2846
2847         Reviewed by Geoffrey Garen.
2848
2849         * WebCoreSupport/WebEditorClient.mm:
2850         (WebEditorClient::WebEditorClient):
2851         (WebEditorClient::requestCandidatesForSelection):
2852
2853 2017-09-22  Chris Dumez  <cdumez@apple.com>
2854
2855         Use high resolution timestamp for event time
2856         https://bugs.webkit.org/show_bug.cgi?id=154246
2857         <rdar://problem/34333304>
2858
2859         Reviewed by Ryosuke Niwa.
2860
2861         Use WallTime / MonotonicTime instead of double type for clarity.
2862
2863         * DOM/DOMEvent.mm:
2864         (-[DOMEvent timeStamp]):
2865         * WebView/WebFrame.mm:
2866         (-[WebFrame _dragSourceEndedAt:operation:]):
2867         * WebView/WebPDFView.mm:
2868         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2869
2870 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2871
2872         Enable dataTransfer.items on macOS and iOS
2873         https://bugs.webkit.org/show_bug.cgi?id=177335
2874
2875         Reviewed by Sam Weinig.
2876
2877         * WebView/WebPreferences.mm:
2878         (+[WebPreferences initialize]):
2879
2880 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2881
2882         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2883         https://bugs.webkit.org/show_bug.cgi?id=177101
2884         <rdar://problem/34500648>
2885
2886         Reviewed by Brian Burg.
2887
2888         * WebInspector/WebNodeHighlight.mm:
2889         Ensure we close the window that we have just removed.
2890
2891 2017-09-20  Antti Koivisto  <antti@apple.com>
2892
2893         Remove DOM and styling support for CSS Regions
2894         https://bugs.webkit.org/show_bug.cgi?id=177221
2895
2896         Reviewed by Andreas Kling.
2897
2898         * Configurations/FeatureDefines.xcconfig:
2899         * DOM/DOMCSS.mm:
2900         (kitClass):
2901         * DOM/DOMElement.mm:
2902         (-[DOMElement webkitRegionOverset]): Deleted.
2903
2904 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2905
2906         Layering violation in Editor::createFragment
2907         https://bugs.webkit.org/show_bug.cgi?id=176123
2908
2909         Reviewed by Darin Adler.
2910
2911         * Misc/WebNSURLExtras.h:
2912         * Misc/WebNSURLExtras.mm:
2913         * WebView/WebFrame.mm:
2914         * WebView/WebHTMLView.mm:
2915         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2916
2917         * WebCoreSupport/WebEditorClient.mm:
2918         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2919         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2920         way to avoid exporting the symbol just on newer OSes.
2921
2922 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2923
2924         On iOS, getData can't get text set by setData during copy event
2925         https://bugs.webkit.org/show_bug.cgi?id=176980
2926         <rdar://problem/34453915>
2927
2928         Reviewed by Darin Adler.
2929
2930         * WebCoreSupport/WebPlatformStrategies.h:
2931         * WebCoreSupport/WebPlatformStrategies.mm:
2932         (WebPlatformStrategies::copy): Deleted.
2933
2934 2017-09-18  Andy Estes  <aestes@apple.com>
2935
2936         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2937         https://bugs.webkit.org/show_bug.cgi?id=177029
2938
2939         Reviewed by Alex Christensen.
2940
2941         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2942         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2943         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2944         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2945         * WebCoreSupport/PopupMenuMac.mm:
2946         (PopupMenuMac::show):
2947         * WebCoreSupport/WebSystemInterface.mm:
2948         (InitWebCoreSystemInterface):
2949         * WebView/WebHTMLView.mm:
2950         (-[WebHTMLView setDataSource:]):
2951         (-[WebHTMLView attachRootLayer:]):
2952         * WebView/WebView.mm:
2953         (-[WebView _needsAdobeFrameReloadingQuirk]):
2954         (-[WebView _needsLinkElementTextCSSQuirk]):
2955         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2956         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2957         (-[WebView _preferencesChanged:]):
2958
2959 2017-09-15  Andy Estes  <aestes@apple.com>
2960
2961         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2962         https://bugs.webkit.org/show_bug.cgi?id=176953
2963
2964         Reviewed by Eric Carlson.
2965
2966         * WebCoreSupport/WebSystemInterface.mm:
2967         (InitWebCoreSystemInterface):
2968
2969 2017-09-14  Andy Estes  <aestes@apple.com>
2970
2971         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2972         https://bugs.webkit.org/show_bug.cgi?id=176931
2973
2974         Reviewed by Joseph Pecoraro.
2975
2976         * WebCoreSupport/WebSystemInterface.mm:
2977         (InitWebCoreSystemInterface):
2978
2979 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2980
2981         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2982         https://bugs.webkit.org/show_bug.cgi?id=176867
2983
2984         Reviewed by Sam Weinig.
2985
2986         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2987         (WebKit::NetscapePluginInstanceProxy::enumerate):
2988
2989 2017-09-13  Andy Estes  <aestes@apple.com>
2990
2991         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2992         https://bugs.webkit.org/show_bug.cgi?id=176729
2993
2994         Reviewed by Alex Christensen.
2995
2996         * WebCoreSupport/WebSystemInterface.mm:
2997         (InitWebCoreSystemInterface):
2998         * WebView/WebView.mm:
2999         (+[WebView _setCacheModel:]):
3000
3001 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3002
3003         Refactor WebContentReader out of EditorMac and EditorIOS
3004         https://bugs.webkit.org/show_bug.cgi?id=176770
3005
3006         Reviewed by Sam Weinig.
3007
3008         * WebCoreSupport/WebEditorClient.mm:
3009
3010 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3011
3012         Dragging & dropping a file creates an attachment element even when it's disabled
3013         https://bugs.webkit.org/show_bug.cgi?id=176769
3014
3015         Reviewed by Tim Horton.
3016
3017         * WebView/WebView.mm:
3018         (-[WebView _preferencesChanged:]):
3019
3020 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3021
3022         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3023         https://bugs.webkit.org/show_bug.cgi?id=176721
3024         <rdar://problem/34373660>
3025
3026         Reviewed by Tim Horton.
3027
3028         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3029         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3030
3031         * WebView/WebView.mm:
3032         (-[WebView _startDrag:]):
3033         (-[WebView _draggedElementBounds]):
3034         (-[WebView _endedDataInteraction:global:]):
3035         * WebView/WebViewData.h:
3036
3037 2017-09-11  Andy Estes  <aestes@apple.com>
3038
3039         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3040         https://bugs.webkit.org/show_bug.cgi?id=176472
3041
3042         Reviewed by Eric Carlson.
3043
3044         * WebCoreSupport/WebSystemInterface.mm:
3045         (InitWebCoreSystemInterface):
3046
3047 2017-09-09  Mark Lam  <mark.lam@apple.com>
3048
3049         Avoid duplicate computations of ExecState::vm().
3050         https://bugs.webkit.org/show_bug.cgi?id=176647
3051
3052         Reviewed by Saam Barati.
3053
3054         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3055         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3056         (WebKit::NetscapePluginInstanceProxy::construct):
3057         (WebKit::NetscapePluginInstanceProxy::setProperty):
3058         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3059         (WebKit::NetscapePluginInstanceProxy::enumerate):
3060         * Plugins/Hosted/ProxyInstance.mm:
3061         (WebKit::ProxyRuntimeMethod::create):
3062
3063 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3064
3065         Unreviewed, rolling out r221773.
3066         https://bugs.webkit.org/show_bug.cgi?id=176614
3067
3068         This caused build failures. (Requested by mlewis13 on
3069         #webkit).
3070
3071         Reverted changeset:
3072
3073         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3074         https://bugs.webkit.org/show_bug.cgi?id=176472
3075         http://trac.webkit.org/changeset/221773
3076
3077 2017-09-07  Andy Estes  <aestes@apple.com>
3078
3079         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3080         https://bugs.webkit.org/show_bug.cgi?id=176472
3081
3082         Reviewed by Eric Carlson.
3083
3084         * WebCoreSupport/WebSystemInterface.mm:
3085         (InitWebCoreSystemInterface):
3086
3087 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3088
3089         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3090         https://bugs.webkit.org/show_bug.cgi?id=176561
3091
3092         Reviewed by Brent Fulgham.
3093
3094         * Misc/WebNSUserDefaultsExtras.mm:
3095
3096 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3097
3098         Modernize Geolocation code
3099         https://bugs.webkit.org/show_bug.cgi?id=176496
3100
3101         Reviewed by Andy Estes.
3102
3103         * WebCoreSupport/WebGeolocationClient.h:
3104         * WebCoreSupport/WebGeolocationClient.mm:
3105         (WebGeolocationClient::requestPermission):
3106         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3107         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3108         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3109         * WebView/WebView.mm:
3110         (-[WebView _commonInitializationWithFrameName:groupName:]):
3111         (-[WebView _geolocationDidFailWithMessage:]):
3112
3113 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3114
3115         Remove some unused bits of code and resources
3116         https://bugs.webkit.org/show_bug.cgi?id=176275
3117
3118         Reviewed by Dan Bernstein.
3119
3120         * Misc/WebNSFileManagerExtras.mm:
3121         Include FileSystem instead of FileSystemIOS.
3122
3123 2017-09-03  Darin Adler  <darin@apple.com>
3124
3125         [Cocoa] Tidy a few things in legacy WebHTMLView
3126         https://bugs.webkit.org/show_bug.cgi?id=176280
3127
3128         Reviewed by Dan Bernstein.
3129
3130         * WebCoreSupport/WebChromeClient.mm:
3131         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3132         methods it calls on WebHTMLView were doing nothing on iOS.
3133
3134         * WebView/WebFrame.mm:
3135         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3136         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3137
3138         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3139         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3140         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3141         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3142         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3143         Use RetainPtr instead of writing retain/release wherever possible.
3144         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3145         initialization for it. Removed various unused methods and declarations of methods.
3146         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3147         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3148         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3149         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3150         and remove CFRetain no longer needed since we don't support garbage collection any more.
3151         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3152         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3153         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3154         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3155         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3156         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3157         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3158         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3159         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3160         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3161         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3162         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3163         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3164         debug flag; we haven't used it for years and it's not clearly helpful.
3165         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3166         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3167         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3168         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3169         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3170         two additional methods in the WebPrivate category and still be called by the two
3171         methods in the WebInternal category that were already using it.
3172         (-[WebHTMLView didAddSubview:]): Deleted.
3173         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3174         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3175         place this was called, the close method.
3176         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3177         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3178         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3179         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3180         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3181         Added helper method to make the one below simpler.
3182         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3183         Compared pasteboard type strings using isEqualToString: rather than using == since
3184         we want to actually compare the string contents. Also updated to use modern for loop,
3185         renamed a local variable from "s" to "localSubresources", and factored out the handling
3186         of three image types to use the helper method above.
3187         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3188         _web_makePluginSubviewsPerformSelector:withObject: method.
3189         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3190         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3191         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3192         not call the -[NSView subviews] method to make this identical on both platforms and used
3193         a modern for loop.
3194         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3195         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3196         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3197         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3198         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3199         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3200         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3201         of it is Mac-only.
3202         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3203         method did was call itself on the main thread, and do nothing if called on main thread.
3204         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3205         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3206         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3207         half of this method.
3208         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3209         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3210         Simplified using a modern for loop and RetainPtr.
3211         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3212         (-[WebHTMLView keyDown:]): Ditto.
3213         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3214         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3215         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3216         (-[WebHTMLView complete:]): Ditto.
3217         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3218         now macOS-only.
3219         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3220         iOS since that is now macOS-only.
3221         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3222         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3223         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3224         and reorganized to use early return.
3225         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3226         on iOS, but kept there so we don't have to do #if at every call site.
3227         (-[WebHTMLView _pluginController]): Moved into internal category.
3228         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3229         there only for GC, using C++ initialization, removing obsolete comment.
3230         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3231         peculiar iOS-only comment.
3232         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3233
3234         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3235         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3236         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3237         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3238         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3239
3240         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3241         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3242         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3243         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3244         them at this time.
3245
3246 2017-09-03  Sam Weinig  <sam@webkit.org>
3247
3248         Remove CanvasProxy
3249         https://bugs.webkit.org/show_bug.cgi?id=176288
3250
3251         Reviewed by Yusuke Suzuki.
3252
3253         CanvasProxy does not appear to be in any current HTML spec
3254         and was disabled and unimplemented in our tree. Time to 
3255         get rid of it.
3256
3257         * Configurations/FeatureDefines.xcconfig:
3258
3259 2017-09-02  Andy Estes  <aestes@apple.com>
3260
3261         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3262         https://bugs.webkit.org/show_bug.cgi?id=176270
3263
3264         Reviewed by Tim Horton.
3265
3266         * Plugins/Hosted/NetscapePluginHostManager.mm:
3267         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3268         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3269         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3270         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3271         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3272         (WebKit::SoftwareCARenderer::context const):
3273         (WebKit::SoftwareCARenderer::renderContext const):
3274         (WebKit::SoftwareCARenderer::render):
3275         (-[WebHostedNetscapePluginView createPlugin]):
3276         (-[WebHostedNetscapePluginView createPluginLayer]):
3277         (-[WebHostedNetscapePluginView destroyPlugin]):
3278         (-[WebHostedNetscapePluginView drawRect:]):
3279         * WebCoreSupport/WebSystemInterface.mm:
3280         (InitWebCoreSystemInterface):
3281
3282 2017-09-01  Andy Estes  <aestes@apple.com>
3283
3284         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3285         https://bugs.webkit.org/show_bug.cgi?id=176200
3286
3287         Reviewed by Tim Horton.
3288
3289         * Carbon/HIWebView.mm:
3290         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3291         (overrideCGContext):
3292         (restoreCGContext):
3293         (Draw):
3294         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3295         (+[WebHostedNetscapePluginView initialize]):
3296         * Plugins/WebBaseNetscapePluginView.h:
3297         * Plugins/WebBaseNetscapePluginView.mm:
3298         (WebKit::sendUserChangeNotifications):
3299         * Plugins/WebNetscapePluginView.mm:
3300         (+[WebNetscapePluginView initialize]):
3301         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3302         * WebCoreSupport/WebSystemInterface.mm:
3303         (InitWebCoreSystemInterface):
3304         * WebView/WebFrame.mm:
3305         (-[WebFrame _paintBehaviorForDestinationContext:]):
3306         * WebView/WebFullScreenController.mm:
3307         (setClipRectForWindow):
3308         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3309         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3310         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3311         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3312
3313 2017-08-31  Andy Estes  <aestes@apple.com>
3314
3315         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3316         https://bugs.webkit.org/show_bug.cgi?id=176175
3317
3318         Reviewed by Brady Eidson.
3319
3320         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3321         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3322         * Plugins/Hosted/WebTextInputWindowController.m:
3323         (-[WebTextInputPanel init]):
3324         * WebCoreSupport/WebSystemInterface.mm:
3325         (InitWebCoreSystemInterface):
3326         * WebView/WebDynamicScrollBarsView.mm:
3327         (-[WebDynamicScrollBarsView scrollWheel:]):
3328         * WebView/WebHTMLView.mm:
3329         (-[WebHTMLView _removeWindowObservers]):
3330         (-[WebHTMLView addWindowObservers]):
3331         * WebView/WebView.mm:
3332         (-[WebView addWindowObserversForWindow:]):
3333         (-[WebView removeWindowObservers]):
3334         (-[WebView viewWillMoveToWindow:]):
3335
3336 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3337
3338         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3339         https://bugs.webkit.org/show_bug.cgi?id=175779
3340         <rdar://problem/22367975>
3341
3342         Reviewed by Tim Horton.
3343
3344         * WebCoreSupport/WebFrameLoaderClient.h:
3345         * WebCoreSupport/WebFrameLoaderClient.mm:
3346         (WebFrameLoaderClient::webGLPolicyForURL const):
3347         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3348
3349 2017-08-30  Andy Estes  <aestes@apple.com>
3350
3351         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3352         https://bugs.webkit.org/show_bug.cgi?id=176093
3353
3354         Reviewed by Eric Carlson.
3355
3356         * WebCoreSupport/WebSystemInterface.mm:
3357         (InitWebCoreSystemInterface):
3358
3359 2017-08-30  Andy Estes  <aestes@apple.com>
3360
3361         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3362         https://bugs.webkit.org/show_bug.cgi?id=176087
3363
3364         Reviewed by Alex Christensen.
3365
3366         * Carbon/CarbonUtils.m:
3367         (getNSAutoreleasePoolCount):
3368         (WebInitForCarbon):
3369         (PoolCleaner):
3370         * Carbon/CarbonWindowAdapter.mm:
3371         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3372         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3373         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3374         (-[CarbonWindowAdapter _windowMovedToRect:]):
3375         * Carbon/HIViewAdapter.m:
3376         * Carbon/HIWebView.mm:
3377         (Draw):
3378         (CreateNSEventAdoptingCGEvent):
3379         (CopyEventCGEvent):
3380         (CreateNSEventWithCarbonClickEvent):
3381         (Click):
3382         (CreateNSEventWithCarbonEvent):
3383         (MouseUp):
3384         (CreateNSEventWithCarbonMouseMoveEvent):
3385         (MouseMoved):
3386         (MouseDragged):
3387         (MouseWheelMoved):
3388         (WindowHandler):
3389         (HIWebViewEventHandler):
3390         * Misc/QuickDrawCompatibility.h: Removed.
3391         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3392         (getCarbonEvent):
3393         (WebNetscapePluginEventHandlerCarbon::keyDown):
3394         (WebNetscapePluginEventHandlerCarbon::keyUp):
3395         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3396         (WebNetscapePluginEventHandlerCocoa::keyDown):
3397         * Plugins/WebNetscapePluginView.mm:
3398         (-[WebNetscapePluginView tellQuickTimeToChill]):
3399
3400 2017-08-29  Andy Estes  <aestes@apple.com>
3401
3402         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3403         https://bugs.webkit.org/show_bug.cgi?id=176046
3404
3405         Reviewed by Alex Christensen.
3406
3407         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3408         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3409
3410         * Misc/WebNSFileManagerExtras.mm:
3411         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3412         (setMetaData): Deleted.
3413         * WebCoreSupport/WebSystemInterface.mm:
3414         (InitWebCoreSystemInterface):
3415
3416 2017-08-28  Andy Estes  <aestes@apple.com>
3417
3418         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3419         https://bugs.webkit.org/show_bug.cgi?id=176039
3420
3421         Reviewed by Alex Christensen.
3422
3423         * WebCoreSupport/WebSystemInterface.mm:
3424         (InitWebCoreSystemInterface):
3425         * WebView/WebPreferences.mm:
3426         (+[WebPreferences _systemCFStringEncoding]):
3427
3428 2017-08-28  Andy Estes  <aestes@apple.com>
3429
3430         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3431         https://bugs.webkit.org/show_bug.cgi?id=176032
3432
3433         Reviewed by Alex Christensen.
3434
3435         * WebCoreSupport/WebSystemInterface.mm:
3436         (InitWebCoreSystemInterface):
3437         * WebView/WebView.mm:
3438         (-[WebView _cachedResponseForURL:]):
3439
3440 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3441
3442         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3443         https://bugs.webkit.org/show_bug.cgi?id=175992
3444         <rdar://problem/34086613>
3445
3446         Reviewed by Daniel Bates.
3447
3448         * WebCoreSupport/WebPlatformStrategies.h:
3449         * WebCoreSupport/WebPlatformStrategies.mm:
3450         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3451         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3452         indicating if secure cookies were accessed.
3453
3454 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3455
3456         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3457         https://bugs.webkit.org/show_bug.cgi?id=170955
3458         <rdar://problem/31697653>
3459
3460         Reviewed by Ryosuke Niwa.
3461
3462         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3463         text is being replaced.
3464
3465         * WebView/WebHTMLView.mm:
3466         (-[WebHTMLView insertText:]):
3467
3468 2017-08-24  Chris Dumez  <cdumez@apple.com>
3469
3470         [Directory Upload] Add basic support for input.webkitdirectory
3471         https://bugs.webkit.org/show_bug.cgi?id=175950
3472         <rdar://problem/33951915>
3473
3474         Reviewed by Geoffrey Garen.
3475
3476         Add private API to toggle Directory Upload support on Mac WebKit1.
3477
3478         * WebView/WebPreferenceKeysPrivate.h:
3479         * WebView/WebPreferences.mm:
3480         (+[WebPreferences initialize]):
3481         (-[WebPreferences setDirectoryUploadEnabled:]):
3482         (-[WebPreferences directoryUploadEnabled]):
3483         * WebView/WebPreferencesPrivate.h:
3484         * WebView/WebView.mm:
3485         (-[WebView _preferencesChanged:]):
3486
3487 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3488
3489         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3490         https://bugs.webkit.org/show_bug.cgi?id=175370
3491         <rdar://problem/33799806>
3492
3493         Reviewed by Ryosuke Niwa.
3494
3495         Adjust WebEditorClient for interface changes.
3496
3497         * WebCoreSupport/WebEditorClient.h:
3498
3499 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3500
3501         Remove ChromeClient::scrollbarsModeDidChange
3502         https://bugs.webkit.org/show_bug.cgi?id=175805
3503
3504         Reviewed by Daniel Bates.
3505
3506         * WebCoreSupport/WebChromeClient.h:
3507
3508 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3509
3510         Remove ChromeClient::hasOpenedPopup
3511         https://bugs.webkit.org/show_bug.cgi?id=175804
3512
3513         Reviewed by Sam Weinig.
3514
3515         * WebCoreSupport/WebChromeClient.h:
3516         * WebCoreSupport/WebChromeClient.mm:
3517         (WebChromeClient::hasOpenedPopup const): Deleted.
3518
3519 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3520
3521         Disable access to secure cookies if an HTTPS site loads mixed content
3522         https://bugs.webkit.org/show_bug.cgi?id=157053
3523         <rdar://problem/11290808>
3524
3525         Reviewed by Dan Bates.
3526
3527         * WebCoreSupport/WebPlatformStrategies.h:
3528         * WebCoreSupport/WebPlatformStrategies.mm:
3529         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3530         indicating whether secure cookies should be included in the response.
3531
3532 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3533
3534         [PAL] Move spi/mac directory into PAL
3535         https://bugs.webkit.org/show_bug.cgi?id=175649
3536
3537         Reviewed by Myles C. Maxfield.
3538
3539         * Misc/WebSharingServicePickerController.h:
3540         * WebCoreSupport/WebContextMenuClient.mm:
3541         * WebCoreSupport/WebEditorClient.mm:
3542         * WebCoreSupport/WebSelectionServiceController.mm:
3543         * WebView/WebHTMLView.mm:
3544         * WebView/WebImmediateActionController.h:
3545         * WebView/WebImmediateActionController.mm:
3546         * WebView/WebView.mm:
3547
3548 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3549
3550         [PAL] Relocate SessionID to root
3551         https://bugs.webkit.org/show_bug.cgi?id=175684
3552
3553         Reviewed by Alex Christensen.
3554
3555         * WebCoreSupport/WebFrameNetworkingContext.mm:
3556
3557 2017-08-17  Andreas Kling  <akling@apple.com>
3558
3559         Disable CSS regions at compile time
3560         https://bugs.webkit.org/show_bug.cgi?id=175630
3561
3562         Reviewed by Antti Koivisto.
3563
3564         * Configurations/FeatureDefines.xcconfig:
3565
3566 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3567
3568         [PAL] Move SessionID into PAL
3569         https://bugs.webkit.org/show_bug.cgi?id=174192
3570
3571         Reviewed by Antti Koivisto.
3572
3573         * Misc/WebCache.mm:
3574         (+[WebCache imageForURL:]):
3575         * WebCoreSupport/WebFrameLoaderClient.h:
3576         * WebCoreSupport/WebFrameLoaderClient.mm:
3577         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3578         * WebCoreSupport/WebFrameNetworkingContext.mm:
3579         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3580         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3581         (WebFrameNetworkingContext::storageSession const):
3582         * WebCoreSupport/WebPlatformStrategies.h:
3583         * WebCoreSupport/WebPlatformStrategies.mm:
3584         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3585         * WebKitPrefix.h:
3586
3587 2017-08-16  Andy Estes  <aestes@apple.com>
3588
3589         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3590         https://bugs.webkit.org/show_bug.cgi?id=175648
3591
3592         Reviewed by Tim Horton.
3593
3594         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3595         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3596         (WebPaymentCoordinatorClient::showPaymentUI):
3597
3598 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3599
3600         [PAL] Move spi/ios and spi/win directories into PAL
3601         https://bugs.webkit.org/show_bug.cgi?id=175171
3602
3603         Reviewed by Antti Koivisto.
3604
3605         * WebCoreSupport/WebFrameLoaderClient.mm:
3606         * WebView/WebView.mm:
3607
3608 2017-08-16  Andy Estes  <aestes@apple.com>
3609
3610         [Payment Request] Add an ENABLE flag and an experimental feature preference
3611         https://bugs.webkit.org/show_bug.cgi?id=175622
3612
3613         Reviewed by Tim Horton.
3614
3615         * Configurations/FeatureDefines.xcconfig:
3616
3617 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3618
3619         [PAL] Move Sleep classes into PAL
3620         https://bugs.webkit.org/show_bug.cgi?id=175456
3621
3622         Reviewed by Ryosuke Niwa.
3623
3624         * WebView/WebFullScreenController.h:
3625
3626 2017-08-15  Youenn Fablet  <youenn@apple.com>
3627
3628         [Cache API] Adding generic support for CacheStorage and Cache methods
3629         https://bugs.webkit.org/show_bug.cgi?id=175455
3630
3631         Reviewed by Chris Dumez.
3632
3633         * WebView/WebView.mm:
3634         (-[WebView _commonInitializationWithFrameName:groupName:]):
3635
3636 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3637
3638         Remove Proximity Events and related code
3639         https://bugs.webkit.org/show_bug.cgi?id=175545
3640
3641         Reviewed by Daniel Bates.
3642
3643         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3644         and other related code.
3645
3646         * Configurations/FeatureDefines.xcconfig:
3647
3648 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3649
3650         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3651         https://bugs.webkit.org/show_bug.cgi?id=175504
3652
3653         Reviewed by Sam Weinig.
3654
3655         * Configurations/FeatureDefines.xcconfig:
3656         * DOM/DOMHTMLFormElement.mm:
3657         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3658         * WebCoreSupport/WebFrameLoaderClient.h:
3659
3660 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3661
3662         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3663         https://bugs.webkit.org/show_bug.cgi?id=175557
3664
3665         Reviewed by Jon Lee.
3666
3667         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3668
3669         * Configurations/FeatureDefines.xcconfig:
3670
3671 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3672
3673         Composition underline color is always black
3674         https://bugs.webkit.org/show_bug.cgi?id=174675
3675
3676         Reviewed by Ryosuke Niwa.
3677
3678         * WebView/WebHTMLView.mm:
3679         (extractUnderlines): If NSUnderlineColorAttributeName
3680         is not present use text color for composition underline.
3681         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3682         for composition underline in the plain text case.
3683
3684 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3685
3686         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3687         https://bugs.webkit.org/show_bug.cgi?id=175474
3688         <rdar://problem/33844628>
3689
3690         Reviewed by Wenson Hsieh.
3691
3692         Replaced the build flag by a runtime flag and disabled the feature by default.
3693
3694         * Configurations/FeatureDefines.xcconfig:
3695         * WebView/WebPreferenceKeysPrivate.h:
3696         * WebView/WebPreferences.mm:
3697         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3698         (-[WebPreferences dataTransferItemsEnabled]): Added.
3699         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3700         * WebView/WebPreferencesPrivate.h:
3701         * WebView/WebView.mm:
3702         (-[WebView _preferencesChanged:]):
3703
3704 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3705
3706         Remove ENABLE_GAMEPAD_DEPRECATED
3707         https://bugs.webkit.org/show_bug.cgi?id=175361
3708
3709         Reviewed by Carlos Garcia Campos.
3710
3711         * Configurations/FeatureDefines.xcconfig:
3712
3713 2017-08-09  Chris Dumez  <cdumez@apple.com>
3714
3715         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3716         https://bugs.webkit.org/show_bug.cgi?id=175401
3717
3718         Reviewed by Brady Eidson.
3719
3720         * WebView/WebPreferenceKeysPrivate.h:
3721         * WebView/WebPreferences.mm:
3722         (+[WebPreferences initialize]):
3723         (-[WebPreferences beaconAPIEnabled]): Deleted.
3724         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3725         * WebView/WebPreferencesPrivate.h:
3726         * WebView/WebView.mm:
3727         (-[WebView _preferencesChanged:]):
3728
3729 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3730
3731         [PAL] Move spi/cocoa and spi/cg directories into PAL
3732         https://bugs.webkit.org/show_bug.cgi?id=175175
3733
3734         Reviewed by Myles C. Maxfield.
3735
3736         * History/WebHistory.mm:
3737         * Misc/WebDownload.mm:
3738         * Misc/WebKitNSStringExtras.mm:
3739         * Plugins/Hosted/NetscapePluginHostManager.mm:
3740         * Plugins/WebPluginDatabase.mm:
3741         * WebCoreSupport/WebFrameLoaderClient.mm:
3742         * WebInspector/WebNodeHighlight.mm:
3743         * WebView/WebHTMLView.mm:
3744         * WebView/WebIndicateLayer.mm:
3745         * WebView/WebView.mm:
3746         * WebView/WebViewData.h:
3747
3748 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3749
3750         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3751         https://bugs.webkit.org/show_bug.cgi?id=175392
3752         <rdar://problem/33783207>
3753
3754         Reviewed by Tim Horton and Megan Gardner.
3755
3756         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3757
3758         * Configurations/FeatureDefines.xcconfig:
3759
3760 2017-08-09  Daniel Bates  <dabates@apple.com>
3761
3762         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3763         https://bugs.webkit.org/show_bug.cgi?id=175247
3764         <rdar://problem/33679804>
3765
3766         Reviewed by Brady Eidson.
3767
3768         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3769         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3770         clients that need to make use of this information at this time. If such a needs comes up
3771         then we can expose API/SPI similar to what we do for WebKit.
3772
3773         * WebCoreSupport/WebFrameLoaderClient.h:
3774         * WebCoreSupport/WebFrameLoaderClient.mm:
3775         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3776
3777 2017-08-08  Brady Eidson  <beidson@apple.com>
3778
3779         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3780         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3781
3782         Reviewed by Andy Estes.
3783
3784         * Misc/WebKitVersionChecks.h:
3785         * WebCoreSupport/WebFrameLoaderClient.mm:
3786         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3787           the app is linked against new WebKit with the new behavior.
3788
3789 2017-08-07  Devin Rousso  <drousso@apple.com>
3790
3791         Web Inspector: Preview Canvas path when viewing a recording
3792         https://bugs.webkit.org/show_bug.cgi?id=174967
3793
3794         Reviewed by Brian Burg.
3795
3796         * WebView/WebPreferenceKeysPrivate.h:
3797         * WebView/WebPreferences.mm:
3798         (+[WebPreferences initialize]):
3799         (-[WebPreferences inspectorAdditionsEnabled]):
3800         (-[WebPreferences setInspectorAdditionsEnabled:]):
3801         * WebView/WebPreferencesPrivate.h:
3802         * WebView/WebView.mm:
3803         (-[WebView _preferencesChanged:]):
3804         Add plumbing for new InspectorAdditions runtime flag.
3805
3806 2017-08-07  Brian Burg  <bburg@apple.com>
3807
3808         Remove CANVAS_PATH compilation guard
3809         https://bugs.webkit.org/show_bug.cgi?id=175207
3810
3811         Reviewed by Sam Weinig.
3812
3813         * Configurations/FeatureDefines.xcconfig:
3814
3815 2017-08-04  Youenn Fablet  <youenn@apple.com>
3816
3817         [Cache API] Add Cache and CacheStorage IDL definitions
3818         https://bugs.webkit.org/show_bug.cgi?id=175201
3819
3820         Reviewed by Brady Eidson.
3821
3822         * WebView/WebPreferenceKeysPrivate.h:
3823         * WebView/WebPreferences.mm:
3824         (+[WebPreferences initialize]):
3825         (-[WebPreferences cacheAPIEnabled]):
3826         (-[WebPreferences setCacheAPIEnabled:]):
3827         * WebView/WebPreferencesPrivate.h:
3828         * WebView/WebView.mm:
3829         (-[WebView _preferencesChanged:]):
3830
3831 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3832
3833         Unreviewed, rolling out r220271.
3834
3835         Rolling out due to Layout Test failing on iOS Simulator.
3836
3837         Reverted changeset:
3838
3839         "Remove STREAMS_API compilation guard"
3840         https://bugs.webkit.org/show_bug.cgi?id=175165
3841         http://trac.webkit.org/changeset/220271
3842
3843 2017-08-04  Youenn Fablet  <youenn@apple.com>
3844
3845         Remove STREAMS_API compilation guard
3846         https://bugs.webkit.org/show_bug.cgi?id=175165
3847
3848         Reviewed by Darin Adler.
3849
3850         * Configurations/FeatureDefines.xcconfig:
3851         * WebView/WebPreferences.mm:
3852         (+[WebPreferences initialize]):
3853         * WebView/WebView.mm:
3854         (-[WebView _preferencesChanged:]):
3855
3856 2017-08-03  Brian Burg  <bburg@apple.com>
3857
3858         Remove ENABLE(WEB_SOCKET) guards
3859         https://bugs.webkit.org/show_bug.cgi?id=167044
3860
3861         Reviewed by Joseph Pecoraro.
3862
3863         * Configurations/FeatureDefines.xcconfig:
3864         * WebView/WebPreferencesPrivate.h:
3865
3866 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3867
3868         [PAL] Move spi/cf directory into PAL
3869         https://bugs.webkit.org/show_bug.cgi?id=175057
3870
3871         Reviewed by Antti Koivisto.
3872
3873         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3874         * Plugins/WebNetscapePluginStream.mm:
3875         * WebCoreSupport/WebFrameNetworkingContext.mm:
3876         * WebView/WebPreferences.mm:
3877         * WebView/WebView.mm:
3878
3879 2017-08-03  Youenn Fablet  <youenn@apple.com>
3880
3881         Remove FETCH_API compilation guard
3882         https://bugs.webkit.org/show_bug.cgi?id=175154
3883
3884         Reviewed by Chris Dumez.
3885
3886         * Configurations/FeatureDefines.xcconfig:
3887         * WebView/WebPreferences.mm:
3888         (+[WebPreferences initialize]):
3889         * WebView/WebView.mm:
3890         (-[WebView _preferencesChanged:]):
3891
3892 2017-08-03  Brady Eidson  <beidson@apple.com>
3893
3894         Add SW IDLs and stub out basic functionality.
3895         https://bugs.webkit.org/show_bug.cgi?id=175115
3896
3897         Reviewed by Chris Dumez.
3898
3899         * Configurations/FeatureDefines.xcconfig:
3900
3901 2017-08-02  Sam Weinig  <sam@webkit.org>
3902
3903         [WebIDL] Convert MutationCallback to be a normal generated callback
3904         https://bugs.webkit.org/show_bug.cgi?id=174140
3905
3906         Reviewed by Darin Adler.
3907
3908         * DOM/DOMDocument.mm:
3909         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3910         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3911         Pass, now necessary, Document to NativeNodeFilter constructor.
3912
3913 2017-08-01  Chris Dumez  <cdumez@apple.com>
3914
3915         Add initial support for navigator.sendBeacon
3916         https://bugs.webkit.org/show_bug.cgi?id=175007
3917         <rdar://problem/33547728>
3918
3919         Reviewed by Sam Weinig.
3920
3921         Add setting to toggle support for the Beacon API (it is disabled by default).
3922
3923         * WebView/WebPreferenceKeysPrivate.h:
3924         * WebView/WebPreferences.mm:
3925         (+[WebPreferences initialize]):
3926         (-[WebPreferences beaconAPIEnabled]):
3927         (-[WebPreferences setBeaconAPIEnabled:]):
3928         * WebView/WebPreferencesPrivate.h:
3929         * WebView/WebView.mm:
3930         (-[WebView _preferencesChanged:]):
3931
3932 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3933
3934         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3935         https://bugs.webkit.org/show_bug.cgi?id=174437
3936
3937         Reviewed by Darin Adler.
3938
3939         Remove redundant Web- prefix from classes in WebKit namespace.
3940
3941         * WebView/WebView.mm:
3942         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3943         * WebView/WebViewData.h:
3944         * WebView/WebViewData.mm:
3945
3946 2017-07-26  Brian Burg  <bburg@apple.com>
3947
3948         Remove WEB_TIMING feature flag
3949         https://bugs.webkit.org/show_bug.cgi?id=174795
3950
3951         Reviewed by Alex Christensen.
3952
3953         * Configurations/FeatureDefines.xcconfig:
3954
3955 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3956
3957         Async image decoding for large images should be disabled after the first time a tile is painted
3958         https://bugs.webkit.org/show_bug.cgi?id=174451
3959         <rdar://problem/31246421>
3960
3961         Reviewed by Simon Fraser.
3962
3963         * WebView/WebFrame.mm:
3964         (-[WebFrame _paintBehaviorForDestinationContext:]):
3965         (-[WebFrame _drawRect:contentsOnly:]):
3966         * WebView/WebHTMLView.mm:
3967         (imageFromRect):
3968
3969 2017-07-23  Darin Adler  <darin@apple.com>
3970
3971         More NeverDestroyed and related cleanup
3972         https://bugs.webkit.org/show_bug.cgi?id=174745
3973
3974         Reviewed by Alex Christensen.
3975
3976         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3977         for names that aren't even used in this file.
3978         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3979         -[NSArray arrayWithObject:].
3980         (-[DOMNode absoluteQuads]): Ditto.
3981         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3982         of writing out various types.
3983         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3984         syntax instea of -[NSArray arrayWithObject:].
3985         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3986         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3987         of writing out various types.
3988         (-[DOMHTMLImageElement mimeType]): Ditto.
3989
3990 2017-07-24  Chris Dumez  <cdumez@apple.com>
3991
3992         ExceptionCode enumeration should use modern exception names
3993         https://bugs.webkit.org/show_bug.cgi?id=174794
3994
3995         Reviewed by Geoffrey Garen.
3996
3997         * DOM/ExceptionHandlers.mm:
3998         (raiseNotSupportedErrorException):
3999
4000 2017-07-23  Chris Dumez  <cdumez@apple.com>
4001
4002         Drop ExceptionCodeDescription class
4003         https://bugs.webkit.org/show_bug.cgi?id=174757
4004
4005         Reviewed by Darin Adler.
4006
4007         Stop using ExceptionCodeDescription.
4008
4009         * DOM/ExceptionHandlers.mm:
4010         (raiseDOMErrorException):
4011
4012 2017-07-21  Andreas Kling  <akling@apple.com>
4013
4014         Use more references in event dispatch code
4015         https://bugs.webkit.org/show_bug.cgi?id=174681
4016
4017         Reviewed by Geoffrey Garen.
4018
4019         * DOM/ObjCEventListener.h:
4020         * DOM/ObjCEventListener.mm:
4021         (WebCore::ObjCEventListener::handleEvent):
4022         * WebCoreSupport/WebFrameLoaderClient.mm:
4023         (NetscapePluginWidget::handleEvent):
4024
4025 2017-07-21  Brady Eidson  <beidson@apple.com>
4026
4027         Get rid of WebCore IconDatabase code.
4028         https://bugs.webkit.org/show_bug.cgi?id=174700
4029
4030         Reviewed by Tim Horton.
4031
4032         * Misc/WebCoreStatistics.mm:
4033         (+[WebCoreStatistics iconPageURLMappingCount]):
4034         (+[WebCoreStatistics iconRetainedPageURLCount]):
4035         (+[WebCoreStatistics iconRecordCount]):
4036         (+[WebCoreStatistics iconsWithDataCount]):
4037         * WebCoreSupport/WebFrameLoaderClient.h:
4038         * WebCoreSupport/WebFrameLoaderClient.mm:
4039         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
4040         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
4041         * WebView/WebView.mm:
4042         (-[WebView mainFrameIconURL]):
4043
4044 2017-07-20  Chris Dumez  <cdumez@apple.com>
4045
4046         Drop legacy XPathException type
4047         https://bugs.webkit.org/show_bug.cgi?id=174679
4048
4049         Reviewed by Sam Weinig.
4050
4051         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
4052         no longer expose XPathException.
4053
4054         * DOM/ExceptionHandlers.mm:
4055         (raiseDOMErrorException):
4056
4057 2017-07-20  Chris Dumez  <cdumez@apple.com>
4058
4059         Unreviewed, rolling out r219706.
4060
4061         Broke iOS build
4062
4063         Reverted changeset:
4064
4065         "Drop legacy XPathException type"
4066         https://bugs.webkit.org/show_bug.cgi?id=174679
4067         http://trac.webkit.org/changeset/219706
4068
4069 2017-07-20  Chris Dumez  <cdumez@apple.com>
4070
4071         Drop legacy XPathException type
4072         https://bugs.webkit.org/show_bug.cgi?id=174679
4073
4074         Reviewed by Sam Weinig.
4075
4076         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
4077         no longer expose XPathException.
4078
4079         * DOM/ExceptionHandlers.mm:
4080         (raiseDOMErrorException):
4081         * WebKit.exp:
4082
4083 2017-07-20  Chris Dumez  <cdumez@apple.com>
4084
4085         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
4086         https://bugs.webkit.org/show_bug.cgi?id=174660
4087
4088         Reviewed by Geoffrey Garen.
4089
4090         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
4091         This essentially replaces a branch to figure out if the new size is less or greater than the
4092         current size by an assertion.
4093
4094         * Plugins/WebNetscapePluginView.mm:
4095         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
4096
4097 2017-07-20  Brady Eidson  <beidson@apple.com>
4098
4099         Deprecate WebIconDatabase in WebKitLegacy/mac.
4100         https://bugs.webkit.org/show_bug.cgi?id=174607
4101
4102         Reviewed by Alex Christensen.
4103
4104         This patch:
4105         1 - Formally deprecates WebIconDatabase (which was never API anyways)
4106         2 - Guts the class to where it can only return the default icon at the small size