Fix iOS build after r237157
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2
3         Fix iOS build after r237157
4
5         * WebView/WebView.mm:
6         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
7
8 2018-10-15  Alex Christensen  <achristensen@webkit.org>
9
10         Modernize BackForwardClient.h
11         https://bugs.webkit.org/show_bug.cgi?id=190610
12
13         Reviewed by Chris Dumez.
14
15         * History/BackForwardList.h:
16         * History/BackForwardList.mm:
17         (BackForwardList::backListCount const):
18         (BackForwardList::forwardListCount const):
19         (BackForwardList::backListCount): Deleted.
20         (BackForwardList::forwardListCount): Deleted.
21         * History/WebBackForwardList.mm:
22         (-[WebBackForwardList init]):
23         * WebCoreSupport/WebFrameLoaderClient.mm:
24         (WebFrameLoaderClient::canCachePage const):
25         * WebView/WebFrameView.mm:
26         (-[WebFrameView keyDown:keyDown:]):
27         * WebView/WebView.mm:
28         (-[WebView _commonInitializationWithFrameName:groupName:]):
29         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
30         (-[WebView _loadBackForwardListFromOtherView:]):
31         (-[WebView initWithCoder:]):
32         (-[WebView encodeWithCoder:]):
33         (-[WebView backForwardList]):
34         (-[WebView setMaintainsBackForwardList:]):
35
36 2018-10-15  Timothy Hatcher  <timothy@apple.com>
37
38         Add support for prefers-color-scheme media query
39         https://bugs.webkit.org/show_bug.cgi?id=190499
40         rdar://problem/45212025
41
42         Reviewed by Dean Jackson.
43
44         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
45
46 2018-10-15  Alex Christensen  <achristensen@webkit.org>
47
48         Remove unused WebView._globalHistoryItem
49         https://bugs.webkit.org/show_bug.cgi?id=190601
50
51         Reviewed by Chris Dumez.
52
53         * WebCoreSupport/WebFrameLoaderClient.h:
54         * WebCoreSupport/WebFrameLoaderClient.mm:
55         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
56         * WebView/WebView.mm:
57         (-[WebView _globalHistoryItem]): Deleted.
58         (-[WebView _setGlobalHistoryItem:]): Deleted.
59         * WebView/WebViewData.h:
60         * WebView/WebViewInternal.h:
61         * WebView/WebViewPrivate.h:
62
63 2018-10-15  Alex Christensen  <achristensen@webkit.org>
64
65         Remove unused parameters from FrameLoaderClient::createFrame
66         https://bugs.webkit.org/show_bug.cgi?id=190587
67
68         Reviewed by Chris Dumez.
69
70         * WebCoreSupport/WebFrameLoaderClient.h:
71         * WebCoreSupport/WebFrameLoaderClient.mm:
72         (WebFrameLoaderClient::createFrame):
73
74 2018-10-15  Alex Christensen  <achristensen@webkit.org>
75
76         Remove unused WebFrame._loadType
77         https://bugs.webkit.org/show_bug.cgi?id=190583
78
79         Reviewed by Chris Dumez.
80
81         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
82
83         * WebView/WebFrame.mm:
84         (toWebFrameLoadType): Deleted.
85         (-[WebFrame _loadType]): Deleted.
86         * WebView/WebFramePrivate.h:
87
88 2018-10-15  Chris Dumez  <cdumez@apple.com>
89
90         Restrict browsing context lookup by name to frames that are related to one another
91         https://bugs.webkit.org/show_bug.cgi?id=190475
92
93         Reviewed by Alex Christensen.
94
95         * WebView/WebFrame.mm:
96         (-[WebFrame findFrameNamed:]):
97
98 2018-10-15  Alex Christensen  <achristensen@webkit.org>
99
100         Remove InjectedBundle processing of back/forward lists
101         https://bugs.webkit.org/show_bug.cgi?id=190459
102
103         Reviewed by Chris Dumez.
104
105         * WebCoreSupport/WebFrameLoaderClient.h:
106         * WebCoreSupport/WebFrameLoaderClient.mm:
107         (WebFrameLoaderClient::shouldGoToHistoryItem const):
108
109 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
110
111         [JSC] Remove Option::useAsyncIterator
112         https://bugs.webkit.org/show_bug.cgi?id=190567
113
114         Reviewed by Saam Barati.
115
116         * Configurations/FeatureDefines.xcconfig:
117
118 2018-10-12  Alex Christensen  <achristensen@webkit.org>
119
120         Allow encoding of small enum classes
121         https://bugs.webkit.org/show_bug.cgi?id=190531
122
123         Reviewed by Tim Horton.
124
125         * WebCoreSupport/WebFrameLoaderClient.mm:
126         (-[WebFramePolicyListener dealloc]):
127
128 2018-10-11  Keith Rollin  <krollin@apple.com>
129
130         CURRENT_ARCH should not be used in Run Script phase.
131         https://bugs.webkit.org/show_bug.cgi?id=190407
132         <rdar://problem/45133556>
133
134         Reviewed by Alexey Proskuryakov.
135
136         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
137         CURRENT_ARCH is not well-defined during this phase (and may even have
138         the value "undefined") since this phase is run just once per build
139         rather than once per supported architecture. Migrate away from
140         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
141         performing an operation for each value, or by picking the first entry
142         in ARCHS and using that as a representative value.
143
144         * Configurations/WebKitLegacy.xcconfig: When generating
145         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
146         macosx platforms.
147
148         * MigrateHeaders.make:
149         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
150         generate one for each architecture in ARCHS.
151
152 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
153
154         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
155         https://bugs.webkit.org/show_bug.cgi?id=190429
156
157         Reviewed by Saam Barati.
158
159         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
160
161         * WebView/WebPDFRepresentation.mm:
162         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
163
164 2018-10-08  Justin Fan  <justin_fan@apple.com>
165
166         WebGPU: Rename old WebGPU prototype to WebMetal
167         https://bugs.webkit.org/show_bug.cgi?id=190325
168         <rdar://problem/44990443>
169
170         Reviewed by Dean Jackson.
171
172         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
173
174         * Configurations/FeatureDefines.xcconfig:
175         * WebView/WebPreferenceKeysPrivate.h:
176         * WebView/WebPreferences.mm:
177         (+[WebPreferences initialize]):
178         (-[WebPreferences webMetalEnabled]):
179         (-[WebPreferences setWebMetalEnabled:]):
180         (-[WebPreferences webGPUEnabled]): Deleted.
181         (-[WebPreferences setWebGPUEnabled:]): Deleted.
182         * WebView/WebPreferencesPrivate.h:
183         * WebView/WebView.mm:
184         (-[WebView _preferencesChanged:]):
185
186 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
187
188         Make <input type=color> a runtime enabled (on-by-default) feature
189         https://bugs.webkit.org/show_bug.cgi?id=189162
190
191         Reviewed by Wenson Hsieh and Tim Horton.
192
193         * Configurations/FeatureDefines.xcconfig:
194
195 2018-10-07  Dan Bernstein  <mitz@apple.com>
196
197         Fixed building with the latest macOS SDK
198
199         * Plugins/WebNetscapePluginPackage.mm:
200         (-[WebNetscapePluginPackage openResourceFile]):
201         (-[WebNetscapePluginPackage closeResourceFile:]):
202
203 2018-10-04  Dan Bernstein  <mitz@apple.com>
204
205         More Carbon build-fixing.
206
207         * Carbon/CarbonWindowAdapter.mm:
208         (-[CarbonWindowAdapter _destroyRealWindow:]):
209         (-[CarbonWindowAdapter _growBoxRect]):
210
211 2018-10-04  Dan Bernstein  <mitz@apple.com>
212
213         Retried to fix 32-bit macOS builds after r236846.
214
215         * WebView/WebHTMLView.mm:
216         (-[WebHTMLView setMarkedText:selectedRange:]):
217
218 2018-10-04  Dan Bernstein  <mitz@apple.com>
219
220         Retried to fix 32-bit macOS builds after r236846.
221
222         * Carbon/HIWebView.mm:
223         (ActiveStateChanged):
224
225 2018-10-04  Dan Bernstein  <mitz@apple.com>
226
227         Tried to fix 32-bit macOS builds after r236846.
228
229         * Carbon/HIWebView.mm:
230         (_NSSelectorForHICommand):
231
232 2018-10-04  Dan Bernstein  <mitz@apple.com>
233
234         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
235         https://bugs.webkit.org/show_bug.cgi?id=190250
236
237         Reviewed by Andy Estes.
238
239         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
240           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
241           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
242           an earlier line set it to YES.
243
244         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
245         changes below.
246
247         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
248           provides some missing method declarations.
249
250         * Misc/WebDownload.mm:
251         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
252           a deprecated method.
253
254         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
255
256         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
257           other code in the file uses a method from it.
258
259         * Plugins/WebBaseNetscapePluginView.mm:
260         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
261           a deprecated method.
262
263         * Plugins/WebPluginController.mm:
264         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
265           around use of a selector that may be present in some WebKit client.
266
267         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
268           method declarations.
269
270         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
271           from here.
272
273         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
274           missing method declarations.
275
276         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
277           from here.
278
279         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
280           call from here.
281         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
282           an obsolete delegate method for binary compatibility.
283         (pluginView): Ditto.
284
285         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
286           call from here.
287
288         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
289           WebDeviceOrientationProviderMock protocol.
290
291         * WebView/WebDeviceOrientationProviderMock.mm:
292         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
293           main @implementation.
294
295         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
296           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
297
298         * WebView/WebDynamicScrollBarsView.mm:
299         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
300           of a deprecated method.
301
302         * WebView/WebHTMLView.mm:
303         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
304           selector warning around action methods that are not declared anywhere in WebKit.
305
306         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
307           about implementing this deprecated method.
308         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
309         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
310         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
311         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
312         (-[WebHTMLView characterIndexForPoint:]): Ditto.
313         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
314         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
315         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
316         (-[WebHTMLView doCommandBySelector:]): Ditto.
317         (-[WebHTMLView insertText:]): Ditto.
318
319         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
320
321         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
322
323         * WebView/WebPDFView.h: Removed previewView ivar.
324
325         * WebView/WebPDFView.mm:
326           Removed declaration of FileInternal category and merged its implementation with the main
327           implementation.
328         (-[WebPDFView dealloc]): Removed previewView ivar.
329         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
330           exist in macOS versions we support.
331         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
332         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
333           action methods internal to PDFKit.
334         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
335         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
336
337         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
338           call on macOS, even though in r86988 we started calling different methods on iOS.
339
340         * WebView/WebView.mm:
341         - Imported headers that declare delegate methods that we call.
342         - Removed declaration of WebFileInternal category and merged its implementation with the
343           main implementation.
344         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
345           category, which made them impossible to call from the main implementation. Moved those
346           into the main implementation. One of those had to be declared in a class extension,
347           because it is called from a method implemented in the WebPrivate category, and that
348           category’s implementation appears first in the file.
349
350         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
351           around use of obsolete delegate method for binary compatibility.
352
353         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
354
355 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
356
357         Runtime flag and IDL for MediaRecorder
358         https://bugs.webkit.org/show_bug.cgi?id=190018
359
360         Reviewed by Youenn Fablet and Chris Dumez.
361
362         * WebView/WebPreferenceKeysPrivate.h:
363         * WebView/WebPreferences.mm:
364         (+[WebPreferences initialize]):
365         (-[WebPreferences mediaRecorderEnabled]):
366         (-[WebPreferences setMediaRecorderEnabled:]):
367         * WebView/WebPreferencesPrivate.h:
368         * WebView/WebView.mm:
369         (-[WebView _preferencesChanged:]):
370
371 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
372
373         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
374         https://bugs.webkit.org/show_bug.cgi?id=190238
375
376         Reviewed by Antti Koivisto.
377
378         Enabled the feature by default.
379
380         * WebView/WebPreferences.mm:
381         (+[WebPreferences initialize]):
382
383 2018-10-01  Dean Jackson  <dino@apple.com>
384
385         [macOS] Switching to discrete GPU should be done in the UI process
386         https://bugs.webkit.org/show_bug.cgi?id=189361
387         <rdar://problem/43949622>
388
389         Reviewed by Simon Fraser.
390
391         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
392         not support swapping to the discrete GPU in this configuration.
393
394         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
395         (WebKit::WebSwitchingGPUClient::singleton):
396         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
397         * WebView/WebView.mm:
398         (-[WebView _commonInitializationWithFrameName:groupName:]):
399
400 2018-10-02  Alex Christensen  <achristensen@webkit.org>
401
402         Remove ParsedURLString
403         https://bugs.webkit.org/show_bug.cgi?id=190154
404
405         Reviewed by Chris Dumez.
406
407         * WebView/WebScriptDebugger.mm:
408         (toNSURL):
409
410 2018-10-01  Dean Jackson  <dino@apple.com>
411
412         Remove CSS Animation Triggers
413         https://bugs.webkit.org/show_bug.cgi?id=190175
414         <rdar://problem/44925626>
415
416         Reviewed by Simon Fraser.
417
418         * Configurations/FeatureDefines.xcconfig:
419
420 2018-10-02  Commit Queue  <commit-queue@webkit.org>
421
422         Unreviewed, rolling out r236624 and r236671.
423         https://bugs.webkit.org/show_bug.cgi?id=190207
424
425         The change in r236624 introduced crashes on the bots
426         (Requested by ryanhaddad on #webkit).
427
428         Reverted changesets:
429
430         "Refactoring: eliminate raw pointer usage in Fullscreen code"
431         https://bugs.webkit.org/show_bug.cgi?id=188747
432         https://trac.webkit.org/changeset/236624
433
434         "Unify implementation in VideoFullscreenInterfaceAVKit"
435         https://bugs.webkit.org/show_bug.cgi?id=190091
436         https://trac.webkit.org/changeset/236671
437
438 2018-10-01  Alex Christensen  <achristensen@webkit.org>
439
440         URL should not use TextEncoding internally
441         https://bugs.webkit.org/show_bug.cgi?id=190111
442
443         Reviewed by Andy Estes.
444
445         * Misc/WebNSURLExtras.mm:
446
447 2018-09-28  Jer Noble  <jer.noble@apple.com>
448
449         Refactoring: eliminate raw pointer usage in Fullscreen code
450         https://bugs.webkit.org/show_bug.cgi?id=188747
451         <rdar://problem/43541164>
452
453         Reviewed by Alex Christensen.
454
455         PlaybackSessionInterface no longer has an invalidate() method.
456
457         * WebView/WebView.mm:
458         (-[WebView _clearPlaybackControlsManager]):
459
460 2018-09-28  Chris Dumez  <cdumez@apple.com>
461
462         Drop support for cross-origin-window-policy header
463         https://bugs.webkit.org/show_bug.cgi?id=190081
464
465         Reviewed by Ryosuke Niwa.
466
467         * WebView/WebPreferenceKeysPrivate.h:
468         * WebView/WebPreferences.mm:
469         (+[WebPreferences initialize]):
470         * WebView/WebPreferencesPrivate.h:
471         * WebView/WebView.mm:
472         (-[WebView _preferencesChanged:]):
473
474 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
475
476         Rename createMarkup to serializePreservingVisualAppearance
477         https://bugs.webkit.org/show_bug.cgi?id=190086
478
479         Reviewed by Wenson Hsieh.
480
481         * DOM/WebDOMOperations.mm:
482         (-[DOMRange markupString]):
483
484 2018-09-28  Commit Queue  <commit-queue@webkit.org>
485
486         Unreviewed, rolling out r236605.
487         https://bugs.webkit.org/show_bug.cgi?id=190087
488
489         caused three API test timeouts (Requested by jernoble on
490         #webkit).
491
492         Reverted changeset:
493
494         "Refactoring: eliminate raw pointer usage in Fullscreen code"
495         https://bugs.webkit.org/show_bug.cgi?id=188747
496         https://trac.webkit.org/changeset/236605
497
498 2018-09-28  Jer Noble  <jer.noble@apple.com>
499
500         Refactoring: eliminate raw pointer usage in Fullscreen code
501         https://bugs.webkit.org/show_bug.cgi?id=188747
502         <rdar://problem/43541164>
503
504         Reviewed by Alex Christensen.
505
506         PlaybackSessionInterface no longer has an invalidate() method.
507
508         * WebView/WebView.mm:
509         (-[WebView _clearPlaybackControlsManager]):
510
511 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
512
513         Use enum class in createMarkup arguments
514         https://bugs.webkit.org/show_bug.cgi?id=190028
515
516         Reviewed by Wenson Hsieh.
517
518         * DOM/WebDOMOperations.mm:
519         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
520         (-[DOMRange markupString]): Ditto.
521
522 2018-09-27  Antoine Quint  <graouts@apple.com>
523
524         [Web Animations] Turn Web Animations with CSS integration on
525         https://bugs.webkit.org/show_bug.cgi?id=184819
526         <rdar://problem/39597337>
527
528         Reviewed by Dean Jackson.
529
530         * WebView/WebPreferences.mm:
531         (+[WebPreferences initialize]):
532
533 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
534
535         Selection should work across shadow boundary when initiated by a mouse drag
536         https://bugs.webkit.org/show_bug.cgi?id=151380
537         <rdar://problem/24363872>
538
539         Reviewed by Wenson Hsieh.
540
541         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
542
543         * WebView/WebPreferenceKeysPrivate.h:
544         * WebView/WebPreferences.mm:
545         (+[WebPreferences initialize]):
546         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
547         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
548         * WebView/WebPreferencesPrivate.h:
549         * WebView/WebView.mm:
550         (-[WebView _preferencesChanged:]):
551
552 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
553
554         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
555         https://bugs.webkit.org/show_bug.cgi?id=189918
556         Work towards <rdar://problem/44648705>
557
558         Reviewed by Tim Horton.
559
560         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
561
562         * WebView/WebHTMLView.mm:
563         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
564         (-[WebHTMLView _updateFontPanel]):
565         * WebView/WebView.mm:
566         (-[WebView typingAttributes]):
567
568 2018-09-17  Darin Adler  <darin@apple.com>
569
570         Use OpaqueJSString rather than JSRetainPtr inside WebKit
571         https://bugs.webkit.org/show_bug.cgi?id=189652
572
573         Reviewed by Saam Barati.
574
575         * WebView/WebPDFRepresentation.mm:
576         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
577
578 2018-09-14  Jer Noble  <jer.noble@apple.com>
579
580         Turn SourceBufferChangeTypeEnabled on by default
581         https://bugs.webkit.org/show_bug.cgi?id=189527
582
583         Reviewed by Eric Carlson.
584
585         * WebView/WebPreferences.mm:
586         (+[WebPreferences initialize]):
587
588 2018-09-12  Alex Christensen  <achristensen@webkit.org>
589
590         Fix an internal build after r235935
591         https://bugs.webkit.org/show_bug.cgi?id=188996
592
593         * Carbon/HIWebView.mm:
594         (Draw):
595         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
596
597 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
598
599         Add IGNORE_WARNING_.* macros
600         https://bugs.webkit.org/show_bug.cgi?id=188996
601
602         Reviewed by Michael Catanzaro.
603
604         * Carbon/CarbonUtils.m:
605         (PoolCleaner):
606         * Carbon/CarbonWindowAdapter.mm:
607         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
608         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
609         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
610         (-[CarbonWindowAdapter _termWindowIfOwner]):
611         (-[CarbonWindowAdapter _windowMovedToRect:]):
612         (-[CarbonWindowAdapter setContentView:]):
613         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
614         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
615         * Carbon/CarbonWindowFrame.m:
616         (-[CarbonWindowFrame title]):
617         * Carbon/HIViewAdapter.m:
618         (+[HIViewAdapter getHIViewForNSView:]):
619         * Carbon/HIWebView.mm:
620         (overrideCGContext):
621         (restoreCGContext):
622         (Draw):
623         * DOM/DOM.mm:
624         * History/WebHistory.mm:
625         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
626         * History/WebHistoryItem.mm:
627         (-[WebHistoryItem icon]):
628         * Misc/WebKitNSStringExtras.mm:
629         (-[NSString _web_drawAtPoint:font:textColor:]):
630         * Misc/WebNSImageExtras.m:
631         (-[NSImage _web_scaleToMaxSize:]):
632         (-[NSImage _web_dissolveToFraction:]):
633         * Misc/WebNSPasteboardExtras.mm:
634         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
635         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
636         * Panels/WebAuthenticationPanel.m:
637         (-[WebAuthenticationPanel loadNib]):
638         * Plugins/Hosted/NetscapePluginHostManager.mm:
639         (WebKit::NetscapePluginHostManager::spawnPluginHost):
640         (WebKit::NetscapePluginHostManager::didCreateWindow):
641         * Plugins/Hosted/NetscapePluginHostProxy.mm:
642         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
643         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
644         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
645         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
646         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
647         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
648         (-[WebHostedNetscapePluginView drawRect:]):
649         * Plugins/Hosted/WebTextInputWindowController.m:
650         (-[WebTextInputPanel _interpretKeyEvent:string:]):
651         * Plugins/WebBaseNetscapePluginView.mm:
652         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
653         * Plugins/WebNetscapePluginPackage.mm:
654         (-[WebNetscapePluginPackage _tryLoad]):
655         * Plugins/WebNetscapePluginView.mm:
656         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
657         (-[WebNetscapePluginView sendDrawRectEvent:]):
658         (-[WebNetscapePluginView drawRect:]):
659         * Plugins/WebPluginController.mm:
660         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
661         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
662         * WebCoreSupport/PopupMenuMac.mm:
663         (PopupMenuMac::populate):
664         * WebCoreSupport/WebAlternativeTextClient.h:
665         * WebCoreSupport/WebDragClient.mm:
666         (WebDragClient::startDrag):
667         * WebCoreSupport/WebFrameLoaderClient.mm:
668         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
669         (webGetNSImage):
670         * WebInspector/WebNodeHighlight.mm:
671         * WebInspector/WebNodeHighlightView.mm:
672         (-[WebNodeHighlightView drawRect:]):
673         * WebView/WebClipView.mm:
674         (-[WebClipView initWithFrame:]):
675         * WebView/WebFrame.mm:
676         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
677         (-[WebFrame _drawRect:contentsOnly:]):
678         (-[WebFrame accessibilityRoot]):
679         * WebView/WebFullScreenController.mm:
680         (-[WebFullScreenController enterFullScreen:]):
681         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
682         (-[WebFullScreenController exitFullScreen]):
683         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
684         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
685         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
686         * WebView/WebHTMLView.mm:
687         (-[NSWindow _web_borderView]):
688         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
689         (-[WebHTMLView _setAsideSubviews]):
690         (-[WebHTMLView _autoscroll]):
691         (-[WebHTMLView drawRect:]):
692         (-[WebHTMLView mouseDown:]):
693         (-[WebHTMLView mouseDragged:]):
694         (-[WebHTMLView mouseUp:]):
695         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
696         (-[WebHTMLView knowsPageRange:]):
697         (-[WebHTMLView accessibilityHitTest:]):
698         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
699         (-[WebHTMLView _colorAsString:]):
700         (-[WebHTMLView copyFont:]):
701         (-[WebHTMLView _executeSavedKeypressCommands]):
702         (-[WebHTMLView attachRootLayer:]):
703         (-[WebHTMLView textStorage]):
704         (-[WebHTMLView _updateSelectionForInputManager]):
705         * WebView/WebPDFView.mm:
706         (_applicationInfoForMIMEType):
707         (-[WebPDFView centerSelectionInVisibleArea:]):
708         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
709         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
710         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
711         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
712         * WebView/WebTextCompletionController.mm:
713         (-[WebTextCompletionController _buildUI]):
714         (-[WebTextCompletionController _placePopupWindow:]):
715         * WebView/WebVideoFullscreenController.mm:
716         * WebView/WebVideoFullscreenHUDWindowController.mm:
717         (createMediaUIBackgroundView):
718         * WebView/WebView.mm:
719         (-[WebTextListTouchBarViewController initWithWebView:]):
720         (-[WebView _dispatchTileDidDraw:]):
721         (-[WebView encodeWithCoder:]):
722         (-[WebView mainFrameIcon]):
723         (LayerFlushController::flushLayers):
724         * WebView/WebWindowAnimation.mm:
725         (setScaledFrameForWindow):
726
727 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
728
729         Remove unused needsDestruction class variables from HashTraits
730         https://bugs.webkit.org/show_bug.cgi?id=189490
731
732         Reviewed by Daniel Bates.
733
734         * History/BinaryPropertyList.cpp: Removed needsDestruction.
735
736 2018-09-07  Frederic Wang  <fwang@igalia.com>
737
738         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
739         https://bugs.webkit.org/show_bug.cgi?id=182230
740
741         Reviewed by Simon Fraser.
742
743         * DOM/DOMDocument.mm:
744         (-[DOMDocument scrollingElement]): Use the new name.
745
746 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
747
748         Refactor WebCore::EditAction to be an 8-bit enum class
749         https://bugs.webkit.org/show_bug.cgi?id=189383
750
751         Reviewed by Dan Bernstein.
752
753         * WebCoreSupport/WebEditorClient.mm:
754         (undoNameForEditAction):
755         * WebView/WebHTMLView.mm:
756         (-[WebHTMLView pasteFont:]):
757         (-[WebHTMLView changeFont:]):
758         (-[WebHTMLView changeAttributes:]):
759         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
760         (-[WebHTMLView changeColor:]):
761         * WebView/WebView.mm:
762         (-[WebView setTypingStyle:]):
763
764 2018-09-06  Frederic Wang  <fwang@igalia.com>
765
766         Group options of scrollRectToVisible into a struct
767         https://bugs.webkit.org/show_bug.cgi?id=189352
768
769         Reviewed by Simon Fraser.
770
771         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
772         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
773         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
774
775 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
776
777         [macOS] Cannot change font size at selection until font panel is shown
778         https://bugs.webkit.org/show_bug.cgi?id=189295
779         <rdar://problem/35593389>
780
781         Reviewed by Ryosuke Niwa.
782
783         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
784         WebCore ChangeLog for more details.
785
786         * WebView/WebHTMLView.mm:
787         (-[WebHTMLView changeFont:]):
788         (-[WebHTMLView changeAttributes:]):
789         (-[WebHTMLView _originalFontA]): Deleted.
790         (-[WebHTMLView _originalFontB]): Deleted.
791         (fontNameForDescription): Deleted.
792         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
793         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
794         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
795
796 2018-09-05  Jer Noble  <jer.noble@apple.com>
797
798         Add MediaCapabilities as an Experimental Feature
799         https://bugs.webkit.org/show_bug.cgi?id=189209
800
801         Reviewed by Eric Carlson.
802
803         RuntimeEnabledFeature -> Setting.
804
805         * WebView/WebView.mm:
806         (-[WebView _preferencesChanged:]):
807
808 2018-09-04  Frederic Wang  <fwang@igalia.com>
809
810         Add basic support for ScrollIntoViewOptions
811         https://bugs.webkit.org/show_bug.cgi?id=189258
812
813         Reviewed by Simon Fraser.
814
815         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
816         header so that this file can build despite the new scrollIntoView function.
817
818 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
819
820         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
821         https://bugs.webkit.org/show_bug.cgi?id=188890
822         <rdar://problem/43648605>
823
824         Reviewed by Tim Horton.
825
826         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
827         more detail.
828
829         * WebCoreSupport/WebPlatformStrategies.h:
830         * WebCoreSupport/WebPlatformStrategies.mm:
831         (WebPlatformStrategies::allStringsForType):
832
833 2018-09-01  Darin Adler  <darin@apple.com>
834
835         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
836         https://bugs.webkit.org/show_bug.cgi?id=189072
837         Reviewed by Dan Bernstein.
838
839         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
840         and declarations for NSURLDownload init methods.
841
842         * Misc/WebDownloadInternal.h: Removed.
843
844         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
845         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
846         "-Wdeprecated-declarations" because the method used here is deprecated.
847
848         * WebView/WebView.mm:
849         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
850         used here is deprecated.
851
852 2018-08-31  Chris Dumez  <cdumez@apple.com>
853
854         Assertion hit in ~CompletionHandler() from ~WebFrame()
855         https://bugs.webkit.org/show_bug.cgi?id=189199
856         <rdar://problem/42657233>
857
858         Reviewed by Youenn Fablet.
859
860         * WebCoreSupport/WebFrameLoaderClient.h:
861         * WebCoreSupport/WebFrameLoaderClient.mm:
862         (WebFrameLoaderClient::dispatchWillSubmitForm):
863
864 2018-08-31  Antti Koivisto  <antti@apple.com>
865
866         Replace OptionSet |= and -= operators with add() and remove() functions
867         https://bugs.webkit.org/show_bug.cgi?id=189169
868
869         Reviewed by Anders Carlsson.
870
871         * WebView/WebFrame.mm:
872         (-[WebFrame _drawRect:contentsOnly:]):
873         * WebView/WebView.mm:
874         (coreOptions):
875
876 2018-08-31  Frederic Wang  <fwang@igalia.com>
877
878         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
879         https://bugs.webkit.org/show_bug.cgi?id=182053
880
881         Reviewed by Simon Fraser.
882
883         Add developer flag to use standard behavior for scrolling* attributes.
884
885         * WebView/WebPreferenceKeysPrivate.h:
886         * WebView/WebPreferences.mm:
887         (+[WebPreferences initialize]):
888         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
889         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
890         * WebView/WebPreferencesPrivate.h:
891         * WebView/WebView.mm:
892         (-[WebView _preferencesChanged:]):
893
894 2018-08-29  Olivia Barnett  <obarnett@apple.com>
895
896         Implement the Web Share API
897         https://bugs.webkit.org/show_bug.cgi?id=171100
898         <rdar://problem/31751734>
899
900         Reviewed by Tim Horton.
901
902         * WebCoreSupport/WebChromeClient.h:
903         * WebCoreSupport/WebChromeClient.mm:
904         (WebChromeClient::showShareSheet):
905         Empty declaration of showShareSheet.
906
907 2018-08-29  Youenn Fablet  <youenn@apple.com>
908
909         Remove WebRTC legacy API implementation
910         https://bugs.webkit.org/show_bug.cgi?id=189040
911
912         Reviewed by Eric Carlson.
913
914         * WebView/WebPreferenceKeysPrivate.h:
915         * WebView/WebPreferences.mm:
916         (+[WebPreferences initialize]):
917         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
918         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
919         * WebView/WebPreferencesPrivate.h:
920         * WebView/WebView.mm:
921         (-[WebView _preferencesChanged:]):
922
923 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
924
925         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
926         https://bugs.webkit.org/show_bug.cgi?id=189054
927
928         Reviewed by Andy Estes.
929
930         Remove the pasteboard type argument from readURLFromPasteboard.
931
932         * WebCoreSupport/WebPlatformStrategies.h:
933         * WebCoreSupport/WebPlatformStrategies.mm:
934         (WebPlatformStrategies::readURLFromPasteboard):
935
936 2018-08-27  Keith Rollin  <krollin@apple.com>
937
938         Unreviewed build fix -- disable LTO for production builds
939
940         * Configurations/Base.xcconfig:
941
942 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
943
944         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
945         https://bugs.webkit.org/show_bug.cgi?id=188931
946
947         Reviewed by Wenson Hsieh.
948
949         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
950
951 2018-08-27  Keith Rollin  <krollin@apple.com>
952
953         Build system support for LTO
954         https://bugs.webkit.org/show_bug.cgi?id=187785
955         <rdar://problem/42353132>
956
957         Reviewed by Dan Bernstein.
958
959         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
960         LTO.
961
962         * Configurations/Base.xcconfig:
963         * Configurations/DebugRelease.xcconfig:
964
965 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
966
967         Pass in IsComposed flag to Event constructors
968         https://bugs.webkit.org/show_bug.cgi?id=188720
969         <rdar://problem/43580387>
970
971         Reviewed by Simon Fraser.
972
973         * WebView/WebPDFView.mm:
974         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
975         whether it's simulated or not.
976
977 2018-08-23  Mark Lam  <mark.lam@apple.com>
978
979         Move vmEntryGlobalObject() to VM from CallFrame.
980         https://bugs.webkit.org/show_bug.cgi?id=188900
981         <rdar://problem/43655753>
982
983         Reviewed by Michael Saboff.
984
985         * WebView/WebScriptDebugger.mm:
986         (WebScriptDebugger::sourceParsed):
987
988 2018-08-23  Andy Estes  <aestes@apple.com>
989
990         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
991         https://bugs.webkit.org/show_bug.cgi?id=188829
992
993         Reviewed by Tim Horton.
994
995         * Configurations/FeatureDefines.xcconfig:
996
997 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
998
999         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
1000         https://bugs.webkit.org/show_bug.cgi?id=188777
1001
1002         Reviewed by Simon Fraser.
1003
1004         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
1005         being "true" before the code change.
1006
1007         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
1008
1009         * WebView/WebPDFView.mm:
1010         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1011
1012 2018-08-21  Daniel Bates  <dabates@apple.com>
1013
1014         Replace TextCheckingTypeMask with OptionSet
1015         https://bugs.webkit.org/show_bug.cgi?id=188678
1016
1017         Reviewed by Antti Koivisto.
1018
1019         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
1020         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
1021         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
1022         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
1023
1024         * WebCoreSupport/WebEditorClient.h:
1025         * WebCoreSupport/WebEditorClient.mm:
1026         (WebEditorClient::checkTextOfParagraph):
1027         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
1028         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
1029         left as this is more readable and unncessary now that modern compilers like Clang have
1030         diagnostics to catch accidental assignments when equality was intended.
1031         (WebEditorClient::didCheckSucceed):
1032         * WebView/WebView.mm:
1033         (coreTextCheckingType):
1034         (textCheckingResultFromNSTextCheckingResult):
1035
1036 2018-08-21  Daniel Bates  <dabates@apple.com>
1037
1038         [iOS][WK1] Support toggling continuous spell checking from tests
1039         https://bugs.webkit.org/show_bug.cgi?id=188763
1040
1041         Reviewed by Simon Fraser.
1042
1043         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
1044         spell checking from tests in iOS WebKit Legacy.
1045
1046         * WebCoreSupport/WebEditorClient.h:
1047         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
1048         * WebCoreSupport/WebEditorClient.mm:
1049         * WebView/WebView.h:
1050         * WebView/WebView.mm:
1051         (-[WebView toggleContinuousSpellChecking:]):
1052         (-[WebView toggleSmartInsertDelete:]):
1053
1054 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1055
1056         Add some plumbing for safe browsing
1057         https://bugs.webkit.org/show_bug.cgi?id=188709
1058
1059         Reviewed by Tim Horton.
1060
1061         * WebCoreSupport/WebFrameLoaderClient.h:
1062         * WebCoreSupport/WebFrameLoaderClient.mm:
1063         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1064
1065 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
1066
1067         Replace canBubble and cancelable booleans in Event by enum classes
1068         https://bugs.webkit.org/show_bug.cgi?id=188692
1069
1070         Reviewed by Alex Christensen.
1071
1072         * WebView/WebPDFView.mm:
1073         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1074         * WebView/WebView.mm:
1075         (-[WebView _dispatchUnloadEvent]):
1076
1077 2018-08-16  Jer Noble  <jer.noble@apple.com>
1078
1079         Add Experimental Feature support for SourceBuffer.changeType()
1080         https://bugs.webkit.org/show_bug.cgi?id=188626
1081         <rdar://problem/43356021>
1082
1083         Reviewed by Eric Carlson.
1084
1085         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
1086
1087         * WebView/WebPreferenceKeysPrivate.h:
1088         * WebView/WebPreferences.mm:
1089         (+[WebPreferences initialize]):
1090         (-[WebPreferences sourceBufferChangeTypeEnabled]):
1091         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
1092         * WebView/WebPreferencesPrivate.h:
1093         * WebView/WebView.mm:
1094         (-[WebView _preferencesChanged:]):
1095
1096 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
1097
1098         Support drag-and-drop for input[type=color]
1099         https://bugs.webkit.org/show_bug.cgi?id=188464
1100
1101         Reviewed by Wenson Hsieh.
1102
1103         * WebCoreSupport/WebPlatformStrategies.h:
1104         * WebCoreSupport/WebPlatformStrategies.mm:
1105         (WebPlatformStrategies::setColor):
1106
1107 2018-08-15  Tim Horton  <timothy_horton@apple.com>
1108
1109         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
1110         https://bugs.webkit.org/show_bug.cgi?id=188569
1111         <rdar://problem/34201095>
1112
1113         Reviewed by Megan Gardner.
1114
1115         * WebView/WebImmediateActionController.mm:
1116         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1117         Speculative fix; the crashes indicate font is null, but we just checked it,
1118         so it must be getting made null by convertFont:toSize:. Check again!
1119
1120 2018-08-13  Alex Christensen  <achristensen@webkit.org>
1121
1122         Use a 1-byte enum class for TextDirection
1123         https://bugs.webkit.org/show_bug.cgi?id=188350
1124
1125         Reviewed by Simon Fraser.
1126
1127         * WebCoreSupport/PopupMenuMac.mm:
1128         (PopupMenuMac::populate):
1129         (PopupMenuMac::show):
1130         * WebCoreSupport/WebFrameLoaderClient.mm:
1131         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1132         * WebView/WebFrame.mm:
1133         (-[WebFrame _dispatchDidReceiveTitle:]):
1134
1135 2018-08-09  Ali Juma  <ajuma@chromium.org>
1136
1137         Import WPTs for IntersectionObserver
1138         https://bugs.webkit.org/show_bug.cgi?id=188416
1139
1140         Reviewed by Simon Fraser.
1141
1142         * WebView/WebPreferencesPrivate.h:
1143
1144 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
1145
1146         Follow-up build fix for r234685
1147         https://bugs.webkit.org/show_bug.cgi?id=188245
1148
1149         Unreviewed build fix.
1150
1151         * WebCoreSupport/WebSecurityOriginPrivate.h:
1152
1153 2018-08-05  Darin Adler  <darin@apple.com>
1154
1155         [Cocoa] More tweaks and refactoring to prepare for ARC
1156         https://bugs.webkit.org/show_bug.cgi?id=188245
1157
1158         Reviewed by Dan Bernstein.
1159
1160         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
1161
1162         * Carbon/CarbonWindowFrame.m:
1163         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
1164
1165         * DOM/DOM.mm:
1166         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
1167         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
1168         garbage collection so this method isn't useful.
1169
1170         * DOM/DOMXPath.mm:
1171         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
1172         Objective-C garbage collection so this method isn't useful.
1173
1174         * History/WebHistory.mm:
1175         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
1176
1177         * Misc/WebElementDictionary.mm:
1178         (addLookupKey): Use a bridging cast.
1179         (cacheValueForKey): Ditto.
1180         (-[WebElementDictionary _fillCache]): Ditto.
1181         (-[WebElementDictionary objectForKey:]): Ditto.
1182
1183         * Misc/WebKitNSStringExtras.mm:
1184         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
1185         (-[NSString _web_widthWithFont:]): Ditto.
1186         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
1187
1188         * Misc/WebLocalizableStrings.mm:
1189         (WebLocalizedString): Use a bridging cast.
1190
1191         * Misc/WebNSDataExtras.mm:
1192         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
1193         and use CFBridgingRelease instead of calling autorelease directly.
1194         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
1195         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
1196         on the amount of explicit release and autorelease.
1197
1198         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
1199         * Misc/WebNSDictionaryExtras.m:
1200         (-[NSDictionary _webkit_intForKey:]): Deleted.
1201         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
1202         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
1203         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
1204         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
1205         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
1206         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
1207
1208         * Misc/WebStringTruncator.mm:
1209         (fontFromNSFont): Use a bridging cast.
1210
1211         * Plugins/Hosted/NetscapePluginHostManager.mm:
1212         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
1213
1214         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1215         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
1216         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
1217         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
1218         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
1219         * Plugins/Hosted/ProxyInstance.mm:
1220         (WebKit::ProxyInstance::getPropertyNames): Ditto.
1221         * Plugins/WebBasePluginPackage.mm:
1222         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
1223         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1224         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
1225         * Plugins/WebNetscapePluginPackage.mm:
1226         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
1227
1228         * Plugins/WebNetscapePluginView.mm:
1229         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
1230         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
1231         (-[WebNetscapePluginView status:]): Use a bridging cast.
1232         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
1233
1234         * Plugins/WebPluginController.mm:
1235         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
1236
1237         * Plugins/WebPluginDatabase.mm:
1238         (checkCandidate): Use explicit __strong for out argument types.
1239
1240         * Plugins/npapi.mm:
1241         (pluginViewForInstance): Use a bridging cast.
1242
1243         * Storage/WebDatabaseManager.mm:
1244         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
1245         explicit NSNumber and NSDictionary calls.
1246
1247         * WebCoreSupport/WebContextMenuClient.mm:
1248         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
1249
1250         * WebCoreSupport/WebEditorClient.mm:
1251         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
1252         (WebEditorClient::handleInputMethodKeydown): Ditto.
1253
1254         * WebCoreSupport/WebFrameNetworkingContext.mm:
1255         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
1256
1257         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
1258         as a struct rather than an Objective-C class, since that's how it's defined.
1259
1260         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
1261
1262         * WebView/WebFullScreenController.mm:
1263         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
1264         * WebView/WebHTMLView.mm:
1265         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1266         Ditto.
1267         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1268
1269         * WebView/WebImmediateActionController.mm:
1270         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
1271         go down to the document and then back to the frame.
1272         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
1273         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
1274         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
1275
1276         * WebView/WebJSPDFDoc.mm:
1277         (jsPDFDocInitialize): Removed some unneeded type casting.
1278         (jsPDFDocFinalize): Ditto.
1279         (jsPDFDocPrint): Use a bridging cast.
1280
1281         * WebView/WebPDFView.mm:
1282         (_applicationInfoForMIMEType): Use bridging casts.
1283
1284         * WebView/WebPreferences.mm:
1285         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
1286         instead of methods from WebNSDictionaryExtras.
1287         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
1288         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
1289         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
1290         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
1291         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
1292
1293         * WebView/WebView.mm:
1294         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
1295         (-[WebView _addToAllWebViewsSet]): Ditto.
1296         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
1297         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
1298         so it can be called from WebViewData methods.
1299
1300         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
1301         method, _windowVisibilityChanged:.
1302
1303         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
1304         called from WebViewData methods.
1305
1306 2018-08-06  Alex Christensen  <achristensen@webkit.org>
1307
1308         Use enum classes and OptionSets for PaintPhase and PaintBehavior
1309         https://bugs.webkit.org/show_bug.cgi?id=188323
1310
1311         Reviewed by Simon Fraser.
1312
1313         * WebCoreSupport/WebContextMenuClient.mm:
1314         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1315         * WebView/WebFrame.mm:
1316         (-[WebFrame _paintBehaviorForDestinationContext:]):
1317         (-[WebFrame _drawRect:contentsOnly:]):
1318         * WebView/WebHTMLView.mm:
1319         (imageFromRect):
1320         (selectionImage):
1321
1322 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1323
1324         Add support for microtasks in workers
1325         https://bugs.webkit.org/show_bug.cgi?id=188246
1326
1327         Reviewed by Darin Adler.
1328
1329         Rename JSMainThreadExecState.h to JSExecState.h.
1330
1331         * DOM/DOMAttr.mm:
1332         * DOM/DOMBlob.mm:
1333         * DOM/DOMCDATASection.mm:
1334         * DOM/DOMCSSCharsetRule.mm:
1335         * DOM/DOMCSSFontFaceRule.mm:
1336         * DOM/DOMCSSImportRule.mm:
1337         * DOM/DOMCSSMediaRule.mm:
1338         * DOM/DOMCSSPageRule.mm:
1339         * DOM/DOMCSSPrimitiveValue.mm:
1340         * DOM/DOMCSSRule.mm:
1341         * DOM/DOMCSSRuleList.mm:
1342         * DOM/DOMCSSStyleDeclaration.mm:
1343         * DOM/DOMCSSStyleRule.mm:
1344         * DOM/DOMCSSStyleSheet.mm:
1345         * DOM/DOMCSSUnknownRule.mm:
1346         * DOM/DOMCSSValue.mm:
1347         * DOM/DOMCSSValueList.mm:
1348         * DOM/DOMCharacterData.mm:
1349         * DOM/DOMComment.mm:
1350         * DOM/DOMCounter.mm:
1351         * DOM/DOMDocument.mm:
1352         * DOM/DOMDocumentFragment.mm:
1353         * DOM/DOMDocumentType.mm:
1354         * DOM/DOMElement.mm:
1355         * DOM/DOMEvent.mm:
1356         * DOM/DOMFile.mm:
1357         * DOM/DOMFileList.mm:
1358         * DOM/DOMHTML.mm:
1359         * DOM/DOMHTMLAnchorElement.mm:
1360         * DOM/DOMHTMLAppletElement.mm:
1361         * DOM/DOMHTMLAreaElement.mm:
1362         * DOM/DOMHTMLBRElement.mm:
1363         * DOM/DOMHTMLBaseElement.mm:
1364         * DOM/DOMHTMLBaseFontElement.mm:
1365         * DOM/DOMHTMLBodyElement.mm:
1366         * DOM/DOMHTMLButtonElement.mm:
1367         * DOM/DOMHTMLCanvasElement.mm:
1368         * DOM/DOMHTMLCollection.mm:
1369         * DOM/DOMHTMLDListElement.mm:
1370         * DOM/DOMHTMLDirectoryElement.mm:
1371         * DOM/DOMHTMLDivElement.mm:
1372         * DOM/DOMHTMLDocument.mm:
1373         * DOM/DOMHTMLElement.mm:
1374         * DOM/DOMHTMLEmbedElement.mm:
1375         * DOM/DOMHTMLFieldSetElement.mm:
1376         * DOM/DOMHTMLFontElement.mm:
1377         * DOM/DOMHTMLFormElement.mm:
1378         * DOM/DOMHTMLFrameElement.mm:
1379         * DOM/DOMHTMLFrameSetElement.mm:
1380         * DOM/DOMHTMLHRElement.mm:
1381         * DOM/DOMHTMLHeadElement.mm:
1382         * DOM/DOMHTMLHeadingElement.mm:
1383         * DOM/DOMHTMLHtmlElement.mm:
1384         * DOM/DOMHTMLIFrameElement.mm:
1385         * DOM/DOMHTMLImageElement.mm:
1386         * DOM/DOMHTMLInputElement.mm:
1387         * DOM/DOMHTMLLIElement.mm:
1388         * DOM/DOMHTMLLabelElement.mm:
1389         * DOM/DOMHTMLLegendElement.mm:
1390         * DOM/DOMHTMLLinkElement.mm:
1391         * DOM/DOMHTMLMapElement.mm:
1392         * DOM/DOMHTMLMarqueeElement.mm:
1393         * DOM/DOMHTMLMediaElement.mm:
1394         * DOM/DOMHTMLMenuElement.mm:
1395         * DOM/DOMHTMLMetaElement.mm:
1396         * DOM/DOMHTMLModElement.mm:
1397         * DOM/DOMHTMLOListElement.mm:
1398         * DOM/DOMHTMLObjectElement.mm:
1399         * DOM/DOMHTMLOptGroupElement.mm:
1400         * DOM/DOMHTMLOptionElement.mm:
1401         * DOM/DOMHTMLOptionsCollection.mm:
1402         * DOM/DOMHTMLParagraphElement.mm:
1403         * DOM/DOMHTMLParamElement.mm:
1404         * DOM/DOMHTMLPreElement.mm:
1405         * DOM/DOMHTMLQuoteElement.mm:
1406         * DOM/DOMHTMLScriptElement.mm:
1407         * DOM/DOMHTMLSelectElement.mm:
1408         * DOM/DOMHTMLStyleElement.mm:
1409         * DOM/DOMHTMLTableCaptionElement.mm:
1410         * DOM/DOMHTMLTableCellElement.mm:
1411         * DOM/DOMHTMLTableColElement.mm:
1412         * DOM/DOMHTMLTableElement.mm:
1413         * DOM/DOMHTMLTableRowElement.mm:
1414         * DOM/DOMHTMLTableSectionElement.mm:
1415         * DOM/DOMHTMLTextAreaElement.mm:
1416         * DOM/DOMHTMLTitleElement.mm:
1417         * DOM/DOMHTMLUListElement.mm:
1418         * DOM/DOMHTMLVideoElement.mm:
1419         * DOM/DOMImplementation.mm:
1420         * DOM/DOMKeyboardEvent.mm:
1421         * DOM/DOMMediaError.mm:
1422         * DOM/DOMMediaList.mm:
1423         * DOM/DOMMouseEvent.mm:
1424         * DOM/DOMMutationEvent.mm:
1425         * DOM/DOMNamedNodeMap.mm:
1426         * DOM/DOMNode.mm:
1427         * DOM/DOMNodeIterator.mm:
1428         * DOM/DOMNodeList.mm:
1429         * DOM/DOMOverflowEvent.mm:
1430         * DOM/DOMProcessingInstruction.mm:
1431         * DOM/DOMProgressEvent.mm:
1432         * DOM/DOMRGBColor.mm:
1433         * DOM/DOMRange.mm:
1434         * DOM/DOMRect.mm:
1435         * DOM/DOMStyleSheet.mm:
1436         * DOM/DOMStyleSheetList.mm:
1437         * DOM/DOMText.mm:
1438         * DOM/DOMTextEvent.mm:
1439         * DOM/DOMTimeRanges.mm:
1440         * DOM/DOMTokenList.mm:
1441         * DOM/DOMTreeWalker.mm:
1442         * DOM/DOMUIEvent.mm:
1443         * DOM/DOMWheelEvent.mm:
1444         * DOM/DOMXPathExpression.mm:
1445         * DOM/DOMXPathResult.mm:
1446         * DOM/ObjCEventListener.mm:
1447
1448 2018-08-03  Alex Christensen  <achristensen@webkit.org>
1449
1450         Fix spelling of "overridden"
1451         https://bugs.webkit.org/show_bug.cgi?id=188315
1452
1453         Reviewed by Darin Adler.
1454
1455         * Misc/WebKitVersionChecks.mm:
1456         (setWebKitLinkTimeVersion):
1457         (WebKitLinkTimeVersion):
1458         * Plugins/WebBaseNetscapePluginView.mm:
1459         (-[WebBaseNetscapePluginView handleMouseMoved:]):
1460         * WebCoreSupport/PopupMenuMac.mm:
1461         (PopupMenuMac::populate):
1462
1463 2018-08-01  Nan Wang  <n_wang@apple.com>
1464
1465         AX: AOM: Add ARIA IDL Attribute Reflection
1466         https://bugs.webkit.org/show_bug.cgi?id=184676
1467         <rdar://problem/39476882>
1468
1469         Reviewed by Chris Fleizach.
1470
1471         * WebView/WebPreferenceKeysPrivate.h:
1472         * WebView/WebPreferences.mm:
1473         (+[WebPreferences initialize]):
1474         (-[WebPreferences ariaReflectionEnabled]):
1475         (-[WebPreferences setAriaReflectionEnabled:]):
1476         * WebView/WebPreferencesPrivate.h:
1477         * WebView/WebView.mm:
1478         (-[WebView _preferencesChanged:]):
1479
1480 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
1481
1482         Shrink GraphicsLayerCA
1483         https://bugs.webkit.org/show_bug.cgi?id=188141
1484
1485         Reviewed by Zalan Bujtas.
1486
1487         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
1488         * moving all the clone-related stuff into the lazily-allocated m_layerClones
1489         * moving all the animation-related stuff into the lazily-allocated m_animations
1490         * making enums be 8-bit
1491         * re-ordering data members
1492
1493         * WebView/WebView.mm:
1494         (-[WebView _setMediaLayer:forPluginView:]):
1495
1496 2018-07-30  Rob Buis  <rbuis@igalia.com>
1497
1498         Merge PlatformCookieJar functions into NetworkStorageSession
1499         https://bugs.webkit.org/show_bug.cgi?id=188137
1500
1501         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1502
1503         Reviewed by Alex Christensen.
1504
1505         * WebCoreSupport/WebPlatformStrategies.mm:
1506         (WebPlatformStrategies::cookiesForDOM):
1507         (WebPlatformStrategies::setCookiesFromDOM):
1508         (WebPlatformStrategies::cookiesEnabled):
1509         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1510         (WebPlatformStrategies::getRawCookies):
1511         (WebPlatformStrategies::deleteCookie):
1512         * WebView/WebPreferences.mm:
1513         (+[WebPreferences _clearNetworkLoaderSession]):
1514
1515 2018-07-28  Darin Adler  <darin@apple.com>
1516
1517         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
1518         https://bugs.webkit.org/show_bug.cgi?id=188140
1519
1520         Reviewed by Sam Weinig.
1521
1522         * WebView/WebImmediateActionController.mm:
1523         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
1524         new DictionaryLookup function that returns a tuple instead of using an out argument.
1525
1526 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
1527
1528         [INTL] Remove INTL sub-feature compile flags
1529         https://bugs.webkit.org/show_bug.cgi?id=188081
1530
1531         Reviewed by Michael Catanzaro.
1532
1533         * Configurations/FeatureDefines.xcconfig:
1534
1535 2018-07-26  Commit Queue  <commit-queue@webkit.org>
1536
1537         Unreviewed, rolling out r234181 and r234189.
1538         https://bugs.webkit.org/show_bug.cgi?id=188075
1539
1540         These are not needed right now (Requested by thorton on
1541         #webkit).
1542
1543         Reverted changesets:
1544
1545         "Enable Web Content Filtering on watchOS"
1546         https://bugs.webkit.org/show_bug.cgi?id=187979
1547         https://trac.webkit.org/changeset/234181
1548
1549         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
1550         https://bugs.webkit.org/show_bug.cgi?id=187985
1551         https://trac.webkit.org/changeset/234189
1552
1553 2018-07-26  Timothy Hatcher  <timothy@apple.com>
1554
1555         Use the Page's appearance when converting pasteboard attributed strings.
1556         https://bugs.webkit.org/show_bug.cgi?id=188067
1557         rdar://problem/42632246
1558
1559         Reviewed by Wenson Hsieh.
1560
1561         * WebCoreSupport/WebEditorClient.mm:
1562         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
1563
1564 2018-07-25  Chris Dumez  <cdumez@apple.com>
1565
1566         navigator.userAgent may return outdated value after webView.customUserAgent is set
1567         https://bugs.webkit.org/show_bug.cgi?id=188009
1568         <rdar://problem/42566456>
1569
1570         Reviewed by Alex Christensen.
1571
1572         Let the page know when the user agent changes.
1573
1574         * WebView/WebView.mm:
1575         (-[WebView _preferencesChanged:]):
1576         (-[WebView setApplicationNameForUserAgent:]):
1577         (-[WebView _invalidateUserAgentCache]):
1578         (-[WebView setCustomUserAgent:]):
1579         * WebView/WebViewInternal.h:
1580
1581 2018-07-24  Tim Horton  <timothy_horton@apple.com>
1582
1583         Enable Web Content Filtering on watchOS
1584         https://bugs.webkit.org/show_bug.cgi?id=187979
1585         <rdar://problem/42559346>
1586
1587         Reviewed by Wenson Hsieh.
1588
1589         * Configurations/FeatureDefines.xcconfig:
1590
1591 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
1592
1593         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
1594         https://bugs.webkit.org/show_bug.cgi?id=187846
1595
1596         Reviewed by Simon Fraser.
1597
1598         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
1599
1600         * WebView/WebHTMLView.mm:
1601         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
1602         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
1603
1604 2018-07-11  Dean Jackson  <dino@apple.com>
1605
1606         Allow removal of white backgrounds
1607         https://bugs.webkit.org/show_bug.cgi?id=187574
1608         <rdar://problem/41146792>
1609
1610         Reviewed by Simon Fraser.
1611
1612         Add a new WebPreference for punching out white backgrounds.
1613
1614         * WebView/WebPreferenceKeysPrivate.h:
1615         * WebView/WebPreferences.mm:
1616         (+[WebPreferences initialize]):
1617         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
1618         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
1619         * WebView/WebPreferencesPrivate.h:
1620         * WebView/WebView.mm:
1621         (-[WebView _preferencesChanged:]):
1622
1623 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
1624
1625         Ensure WebKit stack is ad-hoc signed
1626         https://bugs.webkit.org/show_bug.cgi?id=187667
1627
1628         Reviewed by Alexey Proskuryakov.
1629
1630         * Configurations/Base.xcconfig:
1631
1632 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
1633
1634         REGRESSION (231276): Attempting to copy an image fails
1635         https://bugs.webkit.org/show_bug.cgi?id=187212
1636         <rdar://problem/41540074>
1637
1638         Reviewed by Ryosuke Niwa.
1639
1640         Renamed methods to make it clear that one URL and one title are being passed in.
1641
1642         * WebCoreSupport/WebPlatformStrategies.h:
1643         * WebCoreSupport/WebPlatformStrategies.mm:
1644         (WebPlatformStrategies::setURL):
1645
1646 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1647
1648         Disable cross-origin-window-policy by default
1649         https://bugs.webkit.org/show_bug.cgi?id=187509
1650
1651         Reviewed by Chris Dumez.
1652
1653         * WebView/WebPreferences.mm:
1654         (+[WebPreferences initialize]):
1655
1656 2018-07-09  Timothy Hatcher  <timothy@apple.com>
1657
1658         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1659         https://bugs.webkit.org/show_bug.cgi?id=187425
1660         rdar://problem/39948240
1661
1662         Reviewed by Tim Horton.
1663
1664         * WebView/WebView.mm:
1665         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1666         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1667         a call in this method to setUseDarkAppearance.
1668         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1669         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1670         (-[WebView _updateDefaultAppearance]): Deleted.
1671         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1672
1673 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
1674
1675         Shrink various loading-related enums to shrink CachedResource
1676         https://bugs.webkit.org/show_bug.cgi?id=187443
1677
1678         Reviewed by Chris Dumez.
1679
1680         * WebCoreSupport/WebFrameLoaderClient.mm:
1681         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1682         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1683         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1684         (WebFrameLoaderClient::dispatchWillSendRequest):
1685         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1686         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1687         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1688         (WebFrameLoaderClient::updateGlobalHistory):
1689         (WebFrameLoaderClient::canHandleRequest const):
1690         * WebView/WebDataSource.mm:
1691         (-[WebDataSource initialRequest]):
1692         (-[WebDataSource request]):
1693
1694 2018-07-09  Commit Queue  <commit-queue@webkit.org>
1695
1696         Unreviewed, rolling out r233612.
1697         https://bugs.webkit.org/show_bug.cgi?id=187475
1698
1699         Revision caused the api test LinkColorWithSystemAppearance to
1700         fail on all systems. (Requested by Truitt on #webkit).
1701
1702         Reverted changeset:
1703
1704         "Semantic colors don't update when accessibility Increase
1705         Contrast mode is enabled."
1706         https://bugs.webkit.org/show_bug.cgi?id=187425
1707         https://trac.webkit.org/changeset/233612
1708
1709 2018-07-06  Timothy Hatcher  <timothy@apple.com>
1710
1711         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1712         https://bugs.webkit.org/show_bug.cgi?id=187425
1713         rdar://problem/39948240
1714
1715         Reviewed by Tim Horton.
1716
1717         * WebView/WebView.mm:
1718         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1719         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1720         a call in this method to setUseDarkAppearance.
1721         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1722         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1723         (-[WebView _updateDefaultAppearance]): Deleted.
1724         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1725
1726 2018-07-05  Timothy Hatcher  <timothy@apple.com>
1727
1728         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
1729         https://bugs.webkit.org/show_bug.cgi?id=187369
1730         rdar://problem/41870420
1731
1732         Reviewed by Tim Horton.
1733
1734         * WebView/WebMediaPlaybackTargetPicker.mm:
1735         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
1736         * WebView/WebView.mm:
1737         (-[WebView _commonInitializationWithFrameName:groupName:]):
1738         (-[WebView _effectiveAppearanceIsDark]):
1739         (-[WebView _updateDefaultAppearance]):
1740         (-[WebView _defaultAppearance]): Deleted.
1741
1742 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
1743
1744         Youtube video pages crash after a couple of minutes
1745         https://bugs.webkit.org/show_bug.cgi?id=187316
1746
1747         Reviewed by Antti Koivisto.
1748
1749         * WebView/WebView.mm:
1750         (-[WebView _preferencesChanged:]):
1751
1752 2018-07-04  Tim Horton  <timothy_horton@apple.com>
1753
1754         Introduce PLATFORM(IOSMAC)
1755         https://bugs.webkit.org/show_bug.cgi?id=187315
1756
1757         Reviewed by Dan Bernstein.
1758
1759         * Configurations/Base.xcconfig:
1760         * Configurations/FeatureDefines.xcconfig:
1761
1762 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1763
1764         [iOS] DataTransfer.getData always returns the empty string when dropping text
1765         https://bugs.webkit.org/show_bug.cgi?id=187130
1766         <rdar://problem/41014117>
1767
1768         Reviewed by Ryosuke Niwa.
1769
1770         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
1771
1772         * WebCoreSupport/WebPlatformStrategies.h:
1773         * WebCoreSupport/WebPlatformStrategies.mm:
1774         (WebPlatformStrategies::allPasteboardItemInfo):
1775
1776 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
1777
1778         [Mac] AirPlay picker uses incorrect theme in Dark mode
1779         https://bugs.webkit.org/show_bug.cgi?id=187054
1780         <rdar://problem/41291093>
1781
1782         Reviewed by Timothy Hatcher.
1783
1784         * WebView/WebMediaPlaybackTargetPicker.mm:
1785         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
1786
1787 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1788
1789         [WTF] Add user-defined literal for ASCIILiteral
1790         https://bugs.webkit.org/show_bug.cgi?id=186839
1791
1792         Reviewed by Darin Adler.
1793
1794         * DOM/ExceptionHandlers.mm:
1795         (raiseDOMErrorException):
1796         * Plugins/Hosted/ProxyInstance.mm:
1797         (WebKit::ProxyInstance::invokeMethod):
1798         * Storage/WebDatabaseProvider.mm:
1799         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
1800
1801 2018-06-22  Timothy Hatcher  <timothy@apple.com>
1802
1803         Recalc styles every time defaultAppearance changes.
1804         https://bugs.webkit.org/show_bug.cgi?id=186866
1805         rdar://problem/41309805
1806
1807         Reviewed by Tim Horton.
1808
1809         * WebView/WebView.mm:
1810         (-[WebView _updateDefaultAppearance]):
1811         (-[WebView _setUseSystemAppearance:]):
1812         (-[WebView _useSystemAppearance]):
1813
1814 2018-06-20  Darin Adler  <darin@apple.com>
1815
1816         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
1817         https://bugs.webkit.org/show_bug.cgi?id=186875
1818
1819         Reviewed by Anders Carlsson.
1820
1821         * WebView/WebHTMLView.mm:
1822         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
1823         to write te file to.
1824         * WebView/WebPreferences.mm:
1825         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
1826         * WebView/WebView.mm:
1827         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
1828
1829 2018-06-12  Darin Adler  <darin@apple.com>
1830
1831         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
1832         https://bugs.webkit.org/show_bug.cgi?id=186526
1833
1834         Reviewed by Anders Carlsson.
1835
1836         * Plugins/Hosted/NetscapePluginHostManager.mm:
1837         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
1838
1839         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1840         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
1841         assignment rather than adoptNS/leakRef.
1842         * Plugins/WebNetscapePluginView.mm:
1843         (-[WebNetscapePluginView createPlugin]): Ditto.
1844
1845         * WebCoreSupport/WebContextMenuClient.mm:
1846         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
1847         RetainPtr::autorelease; no need to autorelease just to pass something as a function
1848         argument, so use RetainPtr::get instead.
1849
1850         * WebView/WebHTMLView.mm:
1851         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
1852         No need to autorelease the result when the return type is RetainPtr.
1853
1854         * WebView/WebPDFRepresentation.mm:
1855         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
1856
1857 2018-06-13  Youenn Fablet  <youenn@apple.com>
1858
1859         Supported plugin check should be based on plugin identifier
1860         https://bugs.webkit.org/show_bug.cgi?id=186578
1861         <rdar://problem/40523828>
1862
1863         Reviewed by Darin Adler.
1864
1865         * WebCoreSupport/WebPluginInfoProvider.h:
1866         * WebCoreSupport/WebPluginInfoProvider.mm:
1867         (WebPluginInfoProvider::pluginInfo):
1868         (WebPluginInfoProvider::webVisiblePluginInfo):
1869
1870 2018-06-13  Chris Dumez  <cdumez@apple.com>
1871
1872         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1873         https://bugs.webkit.org/show_bug.cgi?id=186545
1874
1875         Reviewed by Brady Eidson.
1876
1877         Update client delegate now that parameter type has changed.
1878
1879         * WebCoreSupport/WebFrameLoaderClient.h:
1880         * WebCoreSupport/WebFrameLoaderClient.mm:
1881         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1882
1883 2018-06-11  Tim Horton  <timothy_horton@apple.com>
1884
1885         Link drag image is inconsistently unreadable in dark mode
1886         https://bugs.webkit.org/show_bug.cgi?id=186472
1887
1888         Reviewed by Timothy Hatcher.
1889
1890         * WebView/WebView.mm:
1891         (-[WebView _defaultAppearance]):
1892         Make defaultAppearance accurate even if useSystemAppearance is false.
1893         Some parts of WebKit (like the link drag image, but also context menus)
1894         want to be able to follow the system appearance regardless of whether
1895         the view or content has opted in.
1896
1897 2018-06-11  Chris Dumez  <cdumez@apple.com>
1898
1899         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1900         https://bugs.webkit.org/show_bug.cgi?id=186441
1901
1902         Reviewed by Brady Eidson.
1903
1904         Rename existing flag to something a bit more generic, now that it is used for
1905         more things than bypassing the navigation policy check.
1906
1907         * WebView/WebView.mm:
1908         (-[WebView _loadBackForwardListFromOtherView:]):
1909         (-[WebView goToBackForwardItem:]):
1910
1911 2018-06-09  Dan Bernstein  <mitz@apple.com>
1912
1913         [Xcode] Clean up and modernize some build setting definitions
1914         https://bugs.webkit.org/show_bug.cgi?id=186463
1915
1916         Reviewed by Sam Weinig.
1917
1918         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
1919         * Configurations/DebugRelease.xcconfig: Ditto.
1920         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
1921           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
1922         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
1923         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
1924           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
1925         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
1926
1927 2018-06-08  Darin Adler  <darin@apple.com>
1928
1929         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
1930         https://bugs.webkit.org/show_bug.cgi?id=186436
1931
1932         Reviewed by Anders Carlsson.
1933
1934         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
1935         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
1936         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
1937         (PoolCleaner): Ditto.
1938
1939         * History/WebHistory.mm:
1940         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1941         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
1942         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
1943         now hardly used if at all.
1944         * WebView/WebView.mm:
1945         (-[WebView rectsForTextMatches]): Ditto.
1946
1947 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1948
1949         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
1950         https://bugs.webkit.org/show_bug.cgi?id=186442
1951         <rdar://problem/40879364>
1952
1953         Reviewed by Tim Horton.
1954
1955         * Configurations/FeatureDefines.xcconfig:
1956
1957 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
1958
1959         [Datalist] Allow TextFieldInputType to show and hide suggestions
1960         https://bugs.webkit.org/show_bug.cgi?id=186151
1961
1962         Reviewed by Tim Horton.
1963
1964         * WebCoreSupport/WebChromeClient.h:
1965         * WebCoreSupport/WebChromeClient.mm:
1966         (WebChromeClient::createDataListSuggestionPicker):
1967
1968 2018-06-07  Chris Dumez  <cdumez@apple.com>
1969
1970         Add base class to get WeakPtrFactory member and avoid some boilerplate code
1971         https://bugs.webkit.org/show_bug.cgi?id=186407
1972
1973         Reviewed by Brent Fulgham.
1974
1975         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
1976         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
1977         This also gets rid of old-style createWeakPtr() methods in favor of the newer
1978         makeWeakPtr().
1979
1980         * WebCoreSupport/WebEditorClient.h:
1981         * WebCoreSupport/WebEditorClient.mm:
1982         (WebEditorClient::requestCandidatesForSelection):
1983
1984 2018-06-05  Chris Dumez  <cdumez@apple.com>
1985
1986         Regression(r232082): Websites get loaded inside of Messages App chat transcript
1987         https://bugs.webkit.org/show_bug.cgi?id=186331
1988         <rdar://problem/40735446>
1989
1990         Reviewed by Darin Adler.
1991
1992         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
1993         but does not call use / ignore on the listener, then we would do "use" by default.
1994         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
1995         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
1996         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
1997         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
1998         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
1999         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
2000         and Box.app is still working properly.
2001
2002         * WebCoreSupport/WebFrameLoaderClient.h:
2003         * WebCoreSupport/WebFrameLoaderClient.mm:
2004         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2005         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2006         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2007         (WebFrameLoaderClient::dispatchWillSubmitForm):
2008         (WebFrameLoaderClient::setUpPolicyListener):
2009         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
2010         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
2011         (-[WebFramePolicyListener dealloc]):
2012         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
2013         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
2014
2015 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2016
2017         Adjust compile and runtime flags to match shippable state of features
2018         https://bugs.webkit.org/show_bug.cgi?id=186319
2019         <rdar://problem/40352045>
2020
2021         Reviewed by Maciej Stachowiak, Jon Lee, and others.
2022
2023         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
2024         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
2025         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
2026         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
2027         Cocoa builds.
2028
2029 2018-06-05  Timothy Hatcher  <timothy@apple.com>
2030
2031         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
2032
2033         https://bugs.webkit.org/show_bug.cgi?id=186323
2034         rdar://problem/38382252
2035
2036         Reviewed by Tim Horton.
2037
2038         * WebView/WebView.mm:
2039         (-[WebView _defaultAppearance]):
2040
2041 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2042
2043         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
2044         https://bugs.webkit.org/show_bug.cgi?id=186286
2045         <rdar://problem/40782992>
2046
2047         Reviewed by Dan Bernstein.
2048
2049         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
2050         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
2051         change this flag when preparing for a production release.
2052
2053         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
2054         whether experimental features should be enabled, and use it to properly define the
2055         feature flag.
2056
2057 2018-06-03  Darin Adler  <darin@apple.com>
2058
2059         Simplify and remove some unused video element code (helpful for ARC-compatibility)
2060         https://bugs.webkit.org/show_bug.cgi?id=186258
2061
2062         Reviewed by Daniel Bates.
2063
2064         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
2065         forward declarations. Removed methods that don't need to be public.
2066
2067         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
2068         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
2069         unnamed category in here and also replaced the HUDWindowControllerDelegate
2070         with the unnamed category. Removed unused NSWindow category defining the
2071         isOnActiveSpace, which is not called anywhere in this file at this time.
2072         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
2073         into setVideoElement.
2074         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
2075         and removed unneeded typecast.
2076         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
2077         using statement at the top of the file.
2078         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
2079         the many side effects and special considerations that this method that sounds
2080         like a setter has. Updated code to use the new
2081         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
2082         HTMLVideoElement::platformMedia function. Also straightened out the logic a
2083         bit and added some FIXME comments about small problems noticed but not fixed.
2084         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
2085         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
2086         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
2087         typecast. Removed call to updatePowerAssertions method.
2088         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
2089         updatePowerAssertions method.
2090         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
2091         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
2092         else, so this was dead code that did nothing.
2093         (-[WebVideoFullscreenController rateChanged:]): Removed call to
2094         updatePowerAssertions method.
2095
2096 2018-06-04  Chris Dumez  <cdumez@apple.com>
2097
2098         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
2099         https://bugs.webkit.org/show_bug.cgi?id=186287
2100         <rdar://problem/40783352>
2101
2102         Reviewed by Youenn Fablet.
2103
2104         * WebView/WebPreferenceKeysPrivate.h:
2105         * WebView/WebPreferences.mm:
2106         (+[WebPreferences initialize]):
2107         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
2108         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
2109         * WebView/WebPreferencesPrivate.h:
2110         * WebView/WebView.mm:
2111         (-[WebView _preferencesChanged:]):
2112
2113 2018-06-02  Darin Adler  <darin@apple.com>
2114
2115         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
2116         https://bugs.webkit.org/show_bug.cgi?id=186227
2117
2118         Reviewed by Dan Bernstein.
2119
2120         * Misc/WebKitErrors.m:
2121         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
2122         * Plugins/WebPluginDatabase.mm:
2123         (-[WebPluginDatabase refresh]): Ditto.
2124         * WebCoreSupport/WebChromeClient.mm:
2125         (WebChromeClient::setStatusbarText): Ditto.
2126
2127 2018-06-01  Chris Dumez  <cdumez@apple.com>
2128
2129         REGRESSION (r231456): Colloquy is broken
2130         https://bugs.webkit.org/show_bug.cgi?id=186197
2131         <rdar://problem/40722960>
2132
2133         Reviewed by Timothy Hatcher.
2134
2135         Restore pre-r231456 behavior for Colloquy app so that it works again.
2136
2137         * WebView/WebView.mm:
2138         (-[WebView _needsFrameNameFallbackToIdQuirk]):
2139         (-[WebView _preferencesChanged:]):
2140
2141 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2142
2143         [JSC] Pass VM& parameter as much as possible
2144         https://bugs.webkit.org/show_bug.cgi?id=186085
2145
2146         Reviewed by Saam Barati.
2147
2148         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2149         (WebKit::NetscapePluginInstanceProxy::invoke):
2150
2151 2018-05-30  Daniel Bates  <dabates@apple.com>
2152
2153         NavigationAction does not need to hold initiating DOM Event
2154         https://bugs.webkit.org/show_bug.cgi?id=185958
2155         <rdar://problem/40531539>
2156
2157         Reviewed by Simon Fraser.
2158
2159         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
2160
2161         * WebCoreSupport/WebFrameLoaderClient.mm:
2162         (WebFrameLoaderClient::actionDictionary const):
2163         (findMouseEvent): Deleted.
2164
2165 2018-05-27  Dan Bernstein  <mitz@apple.com>
2166
2167         Reverted the changes made for https://webkit.org/b/186016
2168
2169         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
2170
2171
2172 2018-05-27  David Kilzer  <ddkilzer@apple.com>
2173
2174         [iOS] Fix warnings about leaks found by clang static analyzer
2175         <https://webkit.org/b/186009>
2176         <rdar://problem/40574267>
2177
2178         Reviewed by Daniel Bates.
2179
2180         * WebView/WebHTMLView.mm:
2181         (-[WebHTMLView doCommandBySelector:]): Fix use of an
2182         uninitialized boolean variable (`eventWasHandled`) that only
2183         happened on iOS.
2184
2185 2018-05-27  Dan Bernstein  <mitz@apple.com>
2186
2187         [Cocoa] Avoid importing directly from subumbrella frameworks
2188         https://bugs.webkit.org/show_bug.cgi?id=186016
2189
2190         Reviewed by Sam Weinig.
2191
2192         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
2193         * Carbon/CarbonWindowAdapter.mm: Ditto.
2194         * Carbon/CarbonWindowFrame.m: Ditto.
2195         * Carbon/HIViewAdapter.h: Ditto.
2196         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
2197           OTHER_CPLUSPLUSFLAGS.
2198         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
2199         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
2200         * WebView/WebPDFView.h: Ditto.
2201
2202 2018-05-27  Sam Weinig  <sam@webkit.org>
2203
2204         Modernize RenderStyleConstants.h - Part 3
2205         https://bugs.webkit.org/show_bug.cgi?id=186015
2206
2207         Reviewed by Yusuke Suzuki.
2208
2209         * WebView/WebView.mm:
2210         (-[WebView updateTextTouchBar]):
2211         Update for new enum name.
2212
2213 2018-05-25  Chris Dumez  <cdumez@apple.com>
2214
2215         Minor ApplicationCacheStorage clean up
2216         https://bugs.webkit.org/show_bug.cgi?id=185984
2217
2218         Reviewed by Youenn Fablet.
2219
2220         * WebCoreSupport/WebApplicationCache.mm:
2221         (+[WebApplicationCache originsWithCache]):
2222
2223 2018-05-25  David Kilzer  <ddkilzer@apple.com>
2224
2225         Fix issues with -dealloc methods found by clang static analyzer
2226         <https://webkit.org/b/185887>
2227
2228         Reviewed by Joseph Pecoraro.
2229
2230         * WebView/WebView.mm:
2231         (-[WebUITextIndicatorData dealloc]):
2232         - Move method implementation from (WebUITextIndicatorInternal)
2233           category to the main category since this is public API.  This
2234           fixes the false positive warning about a missing -dealloc
2235           method.
2236
2237 2018-05-24  Sam Weinig  <sam@webkit.org>
2238
2239         Modernize RenderStyleConstants.h - Part 2
2240         https://bugs.webkit.org/show_bug.cgi?id=185901
2241
2242         Reviewed by Simon Fraser.
2243
2244         * WebView/WebHTMLRepresentation.mm:
2245         (searchForLabelsBeforeElement):
2246         * WebView/WebView.mm:
2247         (nsTextAlignmentFromRenderStyle):
2248         Update for new enum names.
2249
2250 2018-05-22  Chris Dumez  <cdumez@apple.com>
2251
2252         Regression(AsyncPolicyDelegates): Box.app login Window is blank
2253         https://bugs.webkit.org/show_bug.cgi?id=185832
2254         <rdar://problem/40307871>
2255
2256         Reviewed by Geoffrey Garen.
2257
2258         We used to have a bug where where we would fail to wait for the policy decision for
2259         the navigation response from the client and the load would keep going, racing with
2260         the client's policy decision. If the client did not respond in time, the behavior
2261         would be the same as "Use" policy action.
2262
2263         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
2264         but the load happened to proceed anyway due to our bug. Now that we've fixed the
2265         WebKit bug, however, the load would hang because the completion handler for the
2266         decidePolicyForNavigationResponse would never get called.
2267
2268         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
2269         instead of retaining it. If the policy listener object gets destroyed because getting
2270         resolved, we now use "Use" policy action in its dealloc function to maintain previous
2271         behavior.
2272
2273         * WebCoreSupport/WebFrameLoaderClient.h:
2274         * WebCoreSupport/WebFrameLoaderClient.mm:
2275         (WebFrameLoaderClient::cancelPolicyCheck):
2276         (WebFrameLoaderClient::setUpPolicyListener):
2277         (-[WebFramePolicyListener dealloc]):
2278
2279 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
2280
2281         Unreviewed, rolling out r232052.
2282
2283         Breaks internal builds.
2284
2285         Reverted changeset:
2286
2287         "Use more C++17"
2288         https://bugs.webkit.org/show_bug.cgi?id=185176
2289         https://trac.webkit.org/changeset/232052
2290
2291 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2292
2293         Use more C++17
2294         https://bugs.webkit.org/show_bug.cgi?id=185176
2295
2296         Reviewed by JF Bastien.
2297
2298         * Configurations/Base.xcconfig:
2299         * Configurations/WebKitLegacy.xcconfig:
2300
2301 2018-05-21  Chris Nardi  <cnardi@chromium.org>
2302
2303         Remove dead exception in MediaList.appendMedium
2304         https://bugs.webkit.org/show_bug.cgi?id=185278
2305
2306         Reviewed by Chris Dumez.
2307
2308         Remove code pertaining to an exception being thrown by appendMedium().
2309
2310         * DOM/DOMMediaList.mm:
2311         (-[DOMMediaList appendMedium:]):
2312
2313 2018-05-21  Jer Noble  <jer.noble@apple.com>
2314
2315         Complete fix for enabling modern EME by default
2316         https://bugs.webkit.org/show_bug.cgi?id=185770
2317         <rdar://problem/40368220>
2318
2319         Reviewed by Eric Carlson.
2320
2321         * Configurations/FeatureDefines.xcconfig:
2322
2323 2018-05-21  Antti Koivisto  <antti@apple.com>
2324
2325         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
2326         https://bugs.webkit.org/show_bug.cgi?id=185815
2327         <rdar://problem/40310069>
2328
2329         Reviewed by Simon Fraser.
2330
2331         User stylesheet parsing may depend on the colorFilterEnabled preference.
2332
2333         * WebView/WebView.mm:
2334         (-[WebView _preferencesChanged:]):
2335
2336 2018-05-18  Commit Queue  <commit-queue@webkit.org>
2337
2338         Unreviewed, rolling out r231982.
2339         https://bugs.webkit.org/show_bug.cgi?id=185793
2340
2341         Caused layout test failures (Requested by realdawei on
2342         #webkit).
2343
2344         Reverted changeset:
2345
2346         "Complete fix for enabling modern EME by default"
2347         https://bugs.webkit.org/show_bug.cgi?id=185770
2348         https://trac.webkit.org/changeset/231982
2349
2350 2018-05-18  Jer Noble  <jer.noble@apple.com>
2351
2352         Complete fix for enabling modern EME by default
2353         https://bugs.webkit.org/show_bug.cgi?id=185770
2354         <rdar://problem/40368220>
2355
2356         Reviewed by Eric Carlson.
2357
2358         * Configurations/FeatureDefines.xcconfig:
2359
2360 2018-05-18  Chris Dumez  <cdumez@apple.com>
2361
2362         Avoid keeping the frame alive when ref'ing a WindowProxy
2363         https://bugs.webkit.org/show_bug.cgi?id=185737
2364         <rdar://problem/40004666>
2365
2366         Reviewed by Sam Weinig.
2367
2368         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2369         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2370
2371 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
2372
2373         Add support for Intl NumberFormat formatToParts
2374         https://bugs.webkit.org/show_bug.cgi?id=185375
2375
2376         Reviewed by Yusuke Suzuki.
2377
2378         Add flag for NumberFormat formatToParts.
2379
2380         * Configurations/FeatureDefines.xcconfig:
2381
2382 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2383
2384         Fixup after r231849: Do not mark Mac API methods as deprecated
2385         https://bugs.webkit.org/show_bug.cgi?id=185684
2386
2387         Reviewed by Darin Adler.
2388
2389         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2390         as the entire class is already marked as deprecated, so it is unnecessary.
2391
2392         * DOM/DOMDocument.h:
2393
2394 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2395
2396         Remove Document#selectedStylesheetSet/preferredStylesheetSet
2397         https://bugs.webkit.org/show_bug.cgi?id=185381
2398
2399         Reviewed by Darin Adler.
2400
2401         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2402         and make them do nothing.
2403
2404         * DOM/DOMDocument.h:
2405         * DOM/DOMDocument.mm:
2406         (-[DOMDocument preferredStylesheetSet]):
2407         (-[DOMDocument selectedStylesheetSet]):
2408         (-[DOMDocument setSelectedStylesheetSet:]):
2409
2410 2018-05-15  Antoine Quint  <graouts@apple.com>
2411
2412         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2413         https://bugs.webkit.org/show_bug.cgi?id=185647
2414
2415         Reviewed by Dean Jackson.
2416
2417         Rename the Web Animations CSS integration flag.
2418
2419         * WebView/WebPreferenceKeysPrivate.h:
2420         * WebView/WebPreferences.mm:
2421         (+[WebPreferences initialize]):
2422         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
2423         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
2424         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
2425         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
2426         * WebView/WebPreferencesPrivate.h:
2427         * WebView/WebView.mm:
2428         (-[WebView _preferencesChanged:]):
2429
2430 2018-05-14  Daniel Bates  <dabates@apple.com>
2431
2432         Fix the Apple Internal build
2433
2434         See <rdar://problem/40237873> for more details.
2435
2436         * WebView/WebFullScreenController.mm:
2437         (-[WebFullScreenController enterFullScreen:]):
2438         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2439         (-[WebFullScreenController exitFullScreen]):
2440         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2441         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2442         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2443
2444 2018-05-11  Timothy Hatcher  <timothy@apple.com>
2445
2446         WebHTMLView is not setting aside subviews when drawing.
2447
2448         https://bugs.webkit.org/show_bug.cgi?id=185561
2449         rdar://problem/40172894
2450
2451         Reviewed by Simon Fraser.
2452
2453         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
2454
2455         * WebView/WebHTMLView.mm:
2456         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
2457
2458 2018-05-07  Daniel Bates  <dabates@apple.com>
2459
2460         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
2461         https://bugs.webkit.org/show_bug.cgi?id=185170
2462
2463         Reviewed by Per Arne Vollan.
2464
2465         * Misc/WebCache.mm:
2466         (+[WebCache empty]):
2467
2468 2018-05-04  Timothy Hatcher  <timothy@apple.com>
2469
2470         Deprecate legacy WebView and friends
2471         https://bugs.webkit.org/show_bug.cgi?id=185279
2472         rdar://problem/33268700
2473
2474         Reviewed by Tim Horton.
2475
2476         Added deprecation macros to all the classes, extern strings, and enums.
2477
2478         * Configurations/WebKitLegacy.xcconfig:
2479         Added BUILDING_WEBKIT define to disable the deprecation macros.
2480         * DOM/DOMAbstractView.h:
2481         * DOM/DOMAttr.h:
2482         * DOM/DOMBlob.h:
2483         * DOM/DOMCDATASection.h:
2484         * DOM/DOMCSSCharsetRule.h:
2485         * DOM/DOMCSSFontFaceRule.h:
2486         * DOM/DOMCSSImportRule.h:
2487         * DOM/DOMCSSMediaRule.h:
2488         * DOM/DOMCSSPageRule.h:
2489         * DOM/DOMCSSPrimitiveValue.h:
2490         * DOM/DOMCSSRule.h:
2491         * DOM/DOMCSSRuleList.h:
2492         * DOM/DOMCSSStyleDeclaration.h:
2493         * DOM/DOMCSSStyleRule.h:
2494         * DOM/DOMCSSStyleSheet.h:
2495         * DOM/DOMCSSUnknownRule.h:
2496         * DOM/DOMCSSValue.h:
2497         * DOM/DOMCSSValueList.h:
2498         * DOM/DOMCharacterData.h:
2499         * DOM/DOMComment.h:
2500         * DOM/DOMCounter.h:
2501         * DOM/DOMDocument.h:
2502         * DOM/DOMDocumentFragment.h:
2503         * DOM/DOMDocumentType.h:
2504         * DOM/DOMElement.h:
2505         * DOM/DOMEntity.h:
2506         * DOM/DOMEntityReference.h:
2507         * DOM/DOMEvent.h:
2508         * DOM/DOMEventException.h:
2509         * DOM/DOMEventListener.h:
2510         * DOM/DOMEventTarget.h:
2511         * DOM/DOMException.h:
2512         * DOM/DOMFile.h:
2513         * DOM/DOMFileList.h:
2514         * DOM/DOMHTMLAnchorElement.h:
2515         * DOM/DOMHTMLAppletElement.h:
2516         * DOM/DOMHTMLAreaElement.h:
2517         * DOM/DOMHTMLBRElement.h:
2518         * DOM/DOMHTMLBaseElement.h:
2519         * DOM/DOMHTMLBaseFontElement.h:
2520         * DOM/DOMHTMLBodyElement.h:
2521         * DOM/DOMHTMLButtonElement.h:
2522         * DOM/DOMHTMLCanvasElement.h:
2523         * DOM/DOMHTMLCollection.h:
2524         * DOM/DOMHTMLDListElement.h:
2525         * DOM/DOMHTMLDirectoryElement.h:
2526         * DOM/DOMHTMLDivElement.h:
2527         * DOM/DOMHTMLDocument.h:
2528         * DOM/DOMHTMLElement.h:
2529         * DOM/DOMHTMLEmbedElement.h:
2530         * DOM/DOMHTMLFieldSetElement.h:
2531         * DOM/DOMHTMLFontElement.h:
2532         * DOM/DOMHTMLFormElement.h:
2533         * DOM/DOMHTMLFrameElement.h:
2534         * DOM/DOMHTMLFrameSetElement.h:
2535         * DOM/DOMHTMLHRElement.h:
2536         * DOM/DOMHTMLHeadElement.h:
2537         * DOM/DOMHTMLHeadingElement.h:
2538         * DOM/DOMHTMLHtmlElement.h:
2539         * DOM/DOMHTMLIFrameElement.h:
2540         * DOM/DOMHTMLImageElement.h:
2541         * DOM/DOMHTMLInputElement.h:
2542         * DOM/DOMHTMLLIElement.h:
2543         * DOM/DOMHTMLLabelElement.h:
2544         * DOM/DOMHTMLLegendElement.h:
2545         * DOM/DOMHTMLLinkElement.h:
2546         * DOM/DOMHTMLMapElement.h:
2547         * DOM/DOMHTMLMarqueeElement.h:
2548         * DOM/DOMHTMLMediaElement.h:
2549         * DOM/DOMHTMLMenuElement.h:
2550         * DOM/DOMHTMLMetaElement.h:
2551         * DOM/DOMHTMLModElement.h:
2552         * DOM/DOMHTMLOListElement.h:
2553         * DOM/DOMHTMLObjectElement.h:
2554         * DOM/DOMHTMLOptGroupElement.h:
2555         * DOM/DOMHTMLOptionElement.h:
2556         * DOM/DOMHTMLOptionsCollection.h:
2557         * DOM/DOMHTMLParagraphElement.h:
2558         * DOM/DOMHTMLParamElement.h:
2559         * DOM/DOMHTMLPreElement.h:
2560         * DOM/DOMHTMLQuoteElement.h:
2561         * DOM/DOMHTMLScriptElement.h:
2562         * DOM/DOMHTMLSelectElement.h:
2563         * DOM/DOMHTMLStyleElement.h:
2564         * DOM/DOMHTMLTableCaptionElement.h:
2565         * DOM/DOMHTMLTableCellElement.h:
2566         * DOM/DOMHTMLTableColElement.h:
2567         * DOM/DOMHTMLTableElement.h:
2568         * DOM/DOMHTMLTableRowElement.h:
2569         * DOM/DOMHTMLTableSectionElement.h:
2570         * DOM/DOMHTMLTextAreaElement.h:
2571         * DOM/DOMHTMLTitleElement.h:
2572         * DOM/DOMHTMLUListElement.h:
2573         * DOM/DOMHTMLVideoElement.h:
2574         * DOM/DOMImplementation.h:
2575         * DOM/DOMKeyboardEvent.h:
2576         * DOM/DOMMediaError.h:
2577         * DOM/DOMMediaList.h:
2578         * DOM/DOMMouseEvent.h:
2579         * DOM/DOMMutationEvent.h:
2580         * DOM/DOMNamedNodeMap.h:
2581         * DOM/DOMNode.h:
2582         * DOM/DOMNodeFilter.h:
2583         * DOM/DOMNodeIterator.h:
2584         * DOM/DOMNodeList.h:
2585         * DOM/DOMObject.h:
2586         * DOM/DOMOverflowEvent.h:
2587         * DOM/DOMProcessingInstruction.h:
2588         * DOM/DOMProgressEvent.h:
2589         * DOM/DOMRGBColor.h:
2590         * DOM/DOMRange.h:
2591         * DOM/DOMRangeException.h:
2592         * DOM/DOMRect.h:
2593         * DOM/DOMStyleSheet.h:
2594         * DOM/DOMStyleSheetList.h:
2595         * DOM/DOMText.h:
2596         * DOM/DOMTextEvent.h:
2597         * DOM/DOMTimeRanges.h:
2598         * DOM/DOMTokenList.h:
2599         * DOM/DOMTreeWalker.h:
2600         * DOM/DOMUIEvent.h:
2601         * DOM/DOMWheelEvent.h:
2602         * DOM/DOMXPathException.h:
2603         * DOM/DOMXPathExpression.h:
2604         * DOM/DOMXPathNSResolver.h:
2605         * DOM/DOMXPathResult.h:
2606         * History/WebBackForwardList.h:
2607         * History/WebHistory.h:
2608         * History/WebHistoryItem.h:
2609         * Misc/WebDownload.h:
2610         * Misc/WebKitErrors.h:
2611         * Plugins/WebPluginViewFactory.h:
2612         * WebView/WebArchive.h:
2613         * WebView/WebDataSource.h:
2614         * WebView/WebDocument.h:
2615         * WebView/WebEditingDelegate.h:
2616         * WebView/WebFormDelegate.h:
2617         * WebView/WebFrame.h:
2618         * WebView/WebFrameLoadDelegate.h:
2619         * WebView/WebFrameView.h:
2620         * WebView/WebPolicyDelegate.h:
2621         * WebView/WebPreferences.h:
2622         * WebView/WebPreferencesPrivate.h:
2623         * WebView/WebResourceLoadDelegate.h:
2624         * WebView/WebUIDelegate.h:
2625         * WebView/WebUIDelegatePrivate.h:
2626         * WebView/WebView.h:
2627         * WebView/WebViewPrivate.h:
2628         * postprocess-headers.sh:
2629         Remove step that converts WEBKIT macros to NS macros.
2630         Change it to just remove the macros on iOS builds.
2631
2632 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
2633
2634         [MediaStream] remove WK1 support
2635         https://bugs.webkit.org/show_bug.cgi?id=185136
2636
2637         Reviewed by Youenn Fablet.
2638
2639         * WebCoreSupport/WebUserMediaClient.h: Removed.
2640         * WebCoreSupport/WebUserMediaClient.mm: Removed.
2641         * WebView/WebView.mm:
2642         (-[WebView _commonInitializationWithFrameName:groupName:]):
2643         (-[WebView _preferencesChanged:]):
2644         (-[WebView _setUserMediaClient:]): Deleted.
2645         (-[WebView _userMediaClient]): Deleted.
2646         * WebView/WebViewData.h:
2647         * WebView/WebViewPrivate.h:
2648
2649 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
2650
2651         WebAssembly: add support for stream APIs - JavaScript API
2652         https://bugs.webkit.org/show_bug.cgi?id=183442
2653
2654         Reviewed by Yusuke Suzuki and JF Bastien.
2655
2656         Add WEBASSEMBLY_STREAMINNG_API feature flag
2657
2658         * Configurations/FeatureDefines.xcconfig:
2659
2660 2018-04-30  JF Bastien  <jfbastien@apple.com>
2661
2662         Use some C++17 features
2663         https://bugs.webkit.org/show_bug.cgi?id=185135
2664
2665         Reviewed by Alex Christensen.
2666
2667         * Configurations/WebKitLegacy.xcconfig:
2668
2669 2018-04-27  Chris Dumez  <cdumez@apple.com>
2670
2671         Use WindowProxy instead of DOMWindow in our IDL
2672         https://bugs.webkit.org/show_bug.cgi?id=185022
2673
2674         Reviewed by Sam Weinig.
2675
2676         * DOM/DOMAbstractView.mm:
2677         (kit):
2678         (toWindowProxy):
2679         * DOM/DOMAbstractViewInternal.h:
2680         * DOM/DOMDocument.mm:
2681         (-[DOMDocument defaultView]):
2682         (-[DOMDocument getComputedStyle:pseudoElement:]):
2683         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
2684         * DOM/DOMHTMLFrameElement.mm:
2685         (-[DOMHTMLFrameElement contentWindow]):
2686         * DOM/DOMHTMLIFrameElement.mm:
2687         (-[DOMHTMLIFrameElement contentWindow]):
2688         * DOM/DOMKeyboardEvent.mm:
2689         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2690         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
2691         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2692         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
2693         * DOM/DOMMouseEvent.mm:
2694         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
2695         * DOM/DOMTextEvent.mm:
2696         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
2697         * DOM/DOMUIEvent.mm:
2698         (-[DOMUIEvent view]):
2699         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
2700         * DOM/DOMWheelEvent.mm:
2701         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
2702
2703 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
2704
2705         Implement rendering support for the color-filter CSS property
2706         https://bugs.webkit.org/show_bug.cgi?id=185047
2707         rdar://problem/39664967
2708
2709         Reviewed by Tim Horton.
2710         
2711         The body background should reflect the filtered color.
2712
2713         * WebView/WebFrame.mm:
2714         (-[WebFrame _bodyBackgroundColor]):
2715         * WebView/WebView.mm:
2716         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
2717
2718 2018-04-26  Jer Noble  <jer.noble@apple.com>
2719
2720         WK_COCOA_TOUCH all the things.
2721         https://bugs.webkit.org/show_bug.cgi?id=185006
2722
2723         Reviewed by Tim Horton.
2724
2725         * Configurations/WebKitLegacy.xcconfig:
2726
2727 2018-04-26  Daniel Bates  <dabates@apple.com>
2728
2729         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
2730         https://bugs.webkit.org/show_bug.cgi?id=184161
2731         <rdar://problem/39051645>
2732
2733         Reviewed by Dan Bernstein.
2734
2735         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
2736         dropping a PDF embedded using an HTML image element into the same web view.
2737
2738         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
2739         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
2740         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
2741         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
2742         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
2743         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
2744         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
2745         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
2746         image document when navigated to directly. Since we can support dragging PDF document images we need to
2747         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
2748         We need to do both such queries before falling back to using the main resource of the Web Archive as
2749         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
2750         not an image document.
2751
2752         * Misc/WebNSPasteboardExtras.mm:
2753         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2754
2755 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
2756
2757         Disable content filtering in minimal simulator mode
2758         https://bugs.webkit.org/show_bug.cgi?id=185027
2759         <rdar://problem/39736091>
2760
2761         Reviewed by Jer Noble.
2762
2763         * Configurations/FeatureDefines.xcconfig:
2764
2765 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2766
2767         [INTL] Implement Intl.PluralRules
2768         https://bugs.webkit.org/show_bug.cgi?id=184312
2769
2770         Reviewed by JF Bastien.
2771
2772         Added Intl.PluralRules feature flag.
2773
2774         * Configurations/FeatureDefines.xcconfig:
2775
2776 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
2777
2778         Remove access to keychain from the WebContent process
2779         https://bugs.webkit.org/show_bug.cgi?id=184428
2780         <rdar://problem/13150903>
2781
2782         Reviewed by Brent Fulgham.
2783
2784         This patch does the followings:
2785         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
2786         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
2787         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
2788
2789         * WebCoreSupport/WebChromeClient.h:
2790         * WebCoreSupport/WebChromeClient.mm:
2791         (WebChromeClient::signedPublicKeyAndChallengeString const):
2792         * WebView/WebUIDelegatePrivate.h:
2793
2794 2018-04-24  Jer Noble  <jer.noble@apple.com>
2795
2796         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
2797         https://bugs.webkit.org/show_bug.cgi?id=184786
2798
2799         Reviewed by Tim Horton.
2800
2801         * Configurations/WebKitLegacy.xcconfig:
2802         * MigrateHeaders.make:
2803
2804 2018-04-23  Daniel Bates  <dabates@apple.com>
2805
2806         Implement Same-Site cookies
2807         https://bugs.webkit.org/show_bug.cgi?id=159464
2808         <rdar://problem/27196358>
2809
2810         Reviewed by Brent Fulgham.
2811
2812         Pass the Same-Site info through the strategy.
2813
2814         * WebCoreSupport/WebPlatformStrategies.h:
2815         * WebCoreSupport/WebPlatformStrategies.mm:
2816         (WebPlatformStrategies::cookiesForDOM):
2817         (WebPlatformStrategies::setCookiesFromDOM):
2818         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2819         (WebPlatformStrategies::getRawCookies):
2820
2821 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2822
2823         [LayoutFormattingContext] Initial commit.
2824         https://bugs.webkit.org/show_bug.cgi?id=184896
2825
2826         Reviewed by Antti Koivisto.
2827
2828         * Configurations/FeatureDefines.xcconfig:
2829
2830 2018-04-23  Daniel Bates  <dabates@apple.com>
2831
2832         Implement Same-Site cookies
2833         https://bugs.webkit.org/show_bug.cgi?id=159464
2834         <rdar://problem/27196358>
2835
2836         Reviewed by Brent Fulgham.
2837
2838         Pass the Same-Site info through the strategy.
2839
2840         * WebCoreSupport/WebPlatformStrategies.h:
2841         * WebCoreSupport/WebPlatformStrategies.mm:
2842         (WebPlatformStrategies::cookiesForDOM):
2843         (WebPlatformStrategies::setCookiesFromDOM):
2844         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2845         (WebPlatformStrategies::getRawCookies):
2846
2847 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2848
2849         NULL dereference crash sometimes under [super initWithCoder:] in WebView
2850
2851         https://bugs.webkit.org/show_bug.cgi?id=184851
2852         rdar://problem/39611236
2853
2854         Reviewed by Tim Horton.
2855
2856         * WebView/WebView.mm:
2857         (-[WebView _commonInitializationWithFrameName:groupName:]):
2858         (-[WebView effectiveAppearanceDidChange]):
2859         Added a null check and call the code later in initialization.
2860
2861 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2862
2863         Adjust geolocation feature flag
2864         https://bugs.webkit.org/show_bug.cgi?id=184856
2865
2866         Reviewed by Wenson Hsieh.
2867
2868         * Configurations/FeatureDefines.xcconfig:
2869
2870 2018-04-18  Jer Noble  <jer.noble@apple.com>
2871
2872         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
2873         https://bugs.webkit.org/show_bug.cgi?id=184762
2874
2875         Reviewed by Dan Bernstein.
2876
2877         * Configurations/WebKitLegacy.xcconfig:
2878
2879 2018-04-20  Youenn Fablet  <youenn@apple.com>
2880
2881         Make PluginData cache its web visible plugins
2882         https://bugs.webkit.org/show_bug.cgi?id=184421
2883
2884         Reviewed by Chris Dumez.
2885
2886         * WebCoreSupport/WebPluginInfoProvider.h:
2887         * WebCoreSupport/WebPluginInfoProvider.mm:
2888         (WebPluginInfoProvider::pluginInfo):
2889         (WebPluginInfoProvider::webVisiblePluginInfo):
2890
2891 2018-04-19  Chris Dumez  <cdumez@apple.com>
2892
2893         Rename JSDOMWindowProxy to JSWindowProxy
2894         https://bugs.webkit.org/show_bug.cgi?id=184797
2895
2896         Reviewed by Sam Weinig.
2897
2898         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2899
2900         * DOM/DOMUtility.mm:
2901         (createDOMWrapper):
2902         * WebView/WebFrame.mm:
2903         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2904
2905 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2906
2907         Enable Objective-C weak references
2908         <https://webkit.org/b/184789>
2909         <rdar://problem/39571716>
2910
2911         Reviewed by Dan Bernstein.
2912
2913         * Configurations/Base.xcconfig:
2914         (CLANG_ENABLE_OBJC_WEAK): Enable.
2915
2916 2018-04-18  Chris Dumez  <cdumez@apple.com>
2917
2918         Rename WindowProxyController to WindowProxy
2919         https://bugs.webkit.org/show_bug.cgi?id=184756
2920
2921         Reviewed by Sam Weinig.
2922
2923         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
2924         needed use WindowProxyController type, which was a bit confusing.
2925
2926         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2927         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2928         * WebView/WebFrame.mm:
2929         (-[WebFrame _attachScriptDebugger]):
2930
2931 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2932
2933         Unreviewed rollout of r230632. Regression in memory usage.
2934
2935         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2936
2937         * WebView/WebPreferences.mm:
2938         (+[WebPreferences initialize]):
2939
2940 2018-04-17  Chris Dumez  <cdumez@apple.com>
2941
2942         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2943         https://bugs.webkit.org/show_bug.cgi?id=184678
2944         <rdar://problem/39422122>
2945
2946         Reviewed by Alex Christensen.
2947
2948         Add new parameter to dispatchDecidePolicyForNavigationAction.
2949
2950         * WebCoreSupport/WebFrameLoaderClient.h:
2951         * WebCoreSupport/WebFrameLoaderClient.mm:
2952         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2953
2954 2018-04-13  Chris Dumez  <cdumez@apple.com>
2955
2956         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
2957         https://bugs.webkit.org/show_bug.cgi?id=184591
2958
2959         Reviewed by Sam Weinig.
2960
2961         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
2962         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
2963         This is work towards fixing Bug 184515.
2964
2965         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2966         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2967         * WebView/WebFrame.mm:
2968         (-[WebFrame _attachScriptDebugger]):
2969
2970 2018-04-12  Antoine Quint  <graouts@apple.com>
2971
2972         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2973         https://bugs.webkit.org/show_bug.cgi?id=184569
2974         <rdar://problem/38671301>
2975
2976         Reviewed by Jon Lee.
2977
2978         * WebView/WebPreferences.mm:
2979
2980 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2981
2982         [WTF] Remove StaticLock
2983         https://bugs.webkit.org/show_bug.cgi?id=184332
2984
2985         Reviewed by Mark Lam.
2986
2987         * DOM/DOMInternal.mm:
2988         (getDOMWrapper):
2989         (addDOMWrapper):
2990         (removeDOMWrapper):
2991
2992 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
2993
2994         Failures from mach port reference handling should be fatal
2995         https://bugs.webkit.org/show_bug.cgi?id=184202
2996         <rdar://problem/37771114>
2997
2998         Reviewed by Anders Carlsson.
2999
3000         * Plugins/Hosted/NetscapePluginHostManager.mm:
3001         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
3002
3003 2018-04-03  Andy Estes  <aestes@apple.com>
3004
3005         [Mac] Prioritize file promises over filenames during drag and drop
3006         https://bugs.webkit.org/show_bug.cgi?id=184237
3007         <rdar://problem/38278076>
3008
3009         Reviewed by Wenson Hsieh.
3010
3011         * WebView/WebView.mm:
3012         (-[WebView performDragOperation:]):
3013
3014 2018-04-03  Chris Dumez  <cdumez@apple.com>
3015
3016         Drop MainFrame class
3017         https://bugs.webkit.org/show_bug.cgi?id=184191
3018
3019         Reviewed by Darin Adler.
3020
3021         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
3022         relationship between the Page and the MainFrame.
3023
3024         This is ground work for introducing LocalFrame / RemoteFrame concepts.
3025
3026         * WebCoreSupport/WebDragClient.mm:
3027         * WebCoreSupport/WebFrameLoaderClient.mm:
3028         * WebCoreSupport/WebInspectorClient.mm:
3029         * WebCoreSupport/WebPlatformStrategies.mm:
3030         * WebCoreSupport/WebPluginInfoProvider.mm:
3031         * WebView/WebFrame.mm:
3032         * WebView/WebFrameView.mm:
3033         * WebView/WebHTMLView.mm:
3034         * WebView/WebView.mm:
3035
3036 2018-04-02  Jer Noble  <jer.noble@apple.com>
3037
3038         Enable Legacy EME for all WebKit & WebKitLegacy clients
3039         https://bugs.webkit.org/show_bug.cgi?id=184018
3040         <rdar://problem/34887387>
3041
3042         Reviewed by Eric Carlson.
3043
3044         * WebView/WebPreferences.mm:
3045         (+[WebPreferences initialize]):
3046
3047 2018-03-29  JF Bastien  <jfbastien@apple.com>
3048
3049         Use Forward.h instead of forward-declaring WTF::String
3050         https://bugs.webkit.org/show_bug.cgi?id=184172
3051         <rdar://problem/39026146>
3052
3053         Reviewed by Yusuke Suzuki.
3054
3055         As part of #184164 I'm changing WTF::String, and the forward
3056         declarations are just wrong because I'm making it templated. We
3057         should use Forward.h anyways, so do that instead.
3058
3059         * WebView/WebScriptDebugger.h:
3060
3061 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
3062
3063         Protect against invalid mach ports returned by mach_port_request_notification
3064         https://bugs.webkit.org/show_bug.cgi?id=184106
3065         <rdar://problem/37865316>
3066
3067         Reviewed by Chris Dumez.
3068
3069         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3070         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
3071         and clean up if it experienced an error.
3072         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
3073
3074 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
3075
3076         Avoid uninitialized mach ports
3077         https://bugs.webkit.org/show_bug.cgi?id=184090
3078         <rdar://problem/37261129>
3079
3080         Reviewed by Chris Dumez.
3081
3082         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
3083         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
3084         there is a potential for us to try to use invalid ports.
3085
3086         We should always check return values, and ensure that the mach port variables we seek to initialize are
3087         kept in a valid state.
3088
3089         Reviewed by Chris Dumez.
3090
3091         * Plugins/Hosted/NetscapePluginHostManager.h:
3092         * Plugins/Hosted/NetscapePluginHostManager.mm:
3093         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
3094         port is passed to an API function.
3095         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
3096         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
3097         * Plugins/Hosted/NetscapePluginHostProxy.h:
3098         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3099         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
3100         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
3101         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
3102         (WKPCStatusText): Ditto.
3103         (WKPCLoadURL): Ditto.
3104         (WKPCCancelLoadURL): Ditto.
3105         (WKPCInvalidateRect): Ditto.
3106         (WKPCGetScriptableNPObjectReply): Ditto.
3107         (WKPCBooleanReply): Ditto.
3108         (WKPCBooleanAndDataReply): Ditto.
3109         (WKPCInstantiatePluginReply): Ditto.
3110         (WKPCGetWindowNPObject): Ditto.
3111         (WKPCGetPluginElementNPObject): Ditto.
3112         (WKPCForgetBrowserObject): Ditto.
3113         (WKPCEvaluate): Ditto.
3114         (WKPCGetStringIdentifier): Ditto.
3115         (WKPCGetIntIdentifier): Ditto.
3116         (WKPCInvoke): Ditto.
3117         (WKPCInvokeDefault): Ditto.
3118         (WKPCConstruct): Ditto.
3119         (WKPCGetProperty): Ditto.
3120         (WKPCSetProperty): Ditto.
3121         (WKPCRemoveProperty): Ditto.
3122         (WKPCHasProperty): Ditto.
3123         (WKPCHasMethod): Ditto.
3124         (WKPCIdentifierInfo): Ditto.
3125         (WKPCEnumerate): Ditto.
3126         (WKPCSetMenuBarVisible): Ditto.
3127         (WKPCSetFullscreenWindowIsShowing): Ditto.
3128         (WKPCSetModal): Ditto.
3129         (WKPCGetCookies): Ditto.
3130         (WKPCGetProxy): Ditto.
3131         (WKPCSetCookies): Ditto.
3132         (WKPCGetAuthenticationInfo): Ditto.
3133         (WKPCConvertPoint): Ditto.
3134         (WKPCLayerHostingModeChanged): Ditto.
3135         (WKPCSetException): Ditto.
3136
3137 2018-03-26  Tim Horton  <timothy_horton@apple.com>
3138
3139         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
3140         https://bugs.webkit.org/show_bug.cgi?id=184030
3141         <rdar://problem/38895281>
3142
3143         Reviewed by Dan Bernstein.
3144
3145         * Configurations/Base.xcconfig:
3146
3147 2018-03-26  Chris Dumez  <cdumez@apple.com>
3148
3149         Use SecurityOriginData more consistently in Service Worker code
3150         https://bugs.webkit.org/show_bug.cgi?id=183969
3151
3152         Reviewed by Darin Adler.
3153
3154         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3155
3156         * Storage/WebDatabaseManager.mm:
3157         (-[WebDatabaseManager databasesWithOrigin:]):
3158         (-[WebDatabaseManager deleteOrigin:]):
3159         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3160         * Storage/WebDatabaseQuotaManager.mm:
3161         (-[WebDatabaseQuotaManager usage]):
3162         (-[WebDatabaseQuotaManager quota]):
3163         (-[WebDatabaseQuotaManager setQuota:]):
3164         * Storage/WebStorageManager.mm:
3165         (-[WebStorageManager deleteOrigin:]):
3166         * WebCoreSupport/WebSecurityOrigin.mm:
3167         (-[WebSecurityOrigin databaseIdentifier]):
3168         (-[WebSecurityOrigin usage]):
3169         (-[WebSecurityOrigin quota]):
3170         (-[WebSecurityOrigin setQuota:]):
3171
3172 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
3173
3174         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
3175         https://bugs.webkit.org/show_bug.cgi?id=183911
3176         <rdar://problem/38762306>
3177
3178         Reviewed by Youenn Fablet.
3179
3180         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
3181
3182         * WebView/WebView.mm:
3183         (+[WebView initialize]):
3184
3185 2018-03-26  Alex Christensen  <achristensen@webkit.org>
3186
3187         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
3188         https://bugs.webkit.org/show_bug.cgi?id=183965
3189
3190         Reviewed by Chris Dumez.
3191
3192         * WebCoreSupport/WebFrameLoaderClient.h:
3193         * WebCoreSupport/WebFrameLoaderClient.mm:
3194         (WebFrameLoaderClient::willCacheResponse const):
3195
3196 2018-03-25  Commit Queue  <commit-queue@webkit.org>
3197
3198         Unreviewed, rolling out r229954.
3199         https://bugs.webkit.org/show_bug.cgi?id=184000
3200
3201         Caused many layout tests to crash on Apple High Sierra,
3202         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
3203         by dydz on #webkit).
3204
3205         Reverted changeset:
3206
3207         "Use SecurityOriginData more consistently in Service Worker
3208         code"
3209         https://bugs.webkit.org/show_bug.cgi?id=183969
3210         https://trac.webkit.org/changeset/229954
3211
3212 2018-03-24  Chris Dumez  <cdumez@apple.com>
3213
3214         Use SecurityOriginData more consistently in Service Worker code
3215         https://bugs.webkit.org/show_bug.cgi?id=183969
3216
3217         Reviewed by Darin Adler.
3218
3219         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3220
3221         * Storage/WebDatabaseManager.mm:
3222         (-[WebDatabaseManager databasesWithOrigin:]):
3223         (-[WebDatabaseManager deleteOrigin:]):
3224         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3225         * Storage/WebDatabaseQuotaManager.mm:
3226         (-[WebDatabaseQuotaManager usage]):
3227         (-[WebDatabaseQuotaManager quota]):
3228         (-[WebDatabaseQuotaManager setQuota:]):
3229         * Storage/WebStorageManager.mm:
3230         (-[WebStorageManager deleteOrigin:]):
3231         * WebCoreSupport/WebSecurityOrigin.mm:
3232         (-[WebSecurityOrigin databaseIdentifier]):
3233         (-[WebSecurityOrigin usage]):
3234         (-[WebSecurityOrigin quota]):
3235         (-[WebSecurityOrigin setQuota:]):
3236
3237 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
3238
3239         Fix the build
3240
3241         * WebView/WebView.mm:
3242
3243 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3244
3245         Fix the build with no pasteboard
3246         https://bugs.webkit.org/show_bug.cgi?id=183973
3247
3248         Reviewed by Dan Bernstein.
3249
3250         * Configurations/FeatureDefines.xcconfig:
3251         * WebView/WebView.mm:
3252         (-[WebView _requestStartDataInteraction:globalPosition:]):
3253         (-[WebView _getDataInteractionData]):
3254         (-[WebView _dataOperationTextIndicator]):
3255         (-[WebView _dragSourceAction]):
3256         (-[WebView _draggedLinkTitle]):
3257         (-[WebView _draggedLinkURL]):
3258         (-[WebView _draggedElementBounds]):
3259         (-[WebView _enteredDataInteraction:client:global:operation:]):
3260         (-[WebView _updatedDataInteraction:client:global:operation:]):
3261         (-[WebView _exitedDataInteraction:client:global:operation:]):
3262         (-[WebView _performDataInteraction:client:global:operation:]):
3263         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3264         (-[WebView _endedDataInteraction:global:]):
3265         (-[WebView _dataInteractionCaretRect]):
3266         * WebView/WebViewPrivate.h:
3267
3268 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3269
3270         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
3271         https://bugs.webkit.org/show_bug.cgi?id=183960
3272         <rdar://problem/38812356>
3273
3274         Reviewed by Dan Bernstein.
3275
3276         * Configurations/WebKitLegacy.xcconfig:
3277
3278 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3279
3280         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
3281         https://bugs.webkit.org/show_bug.cgi?id=183954
3282         <rdar://problem/38808858>
3283
3284         Reviewed by Dan Bernstein.
3285
3286         * WebView/WebPreferences.mm:
3287         (-[WebPreferences setAudioSessionCategoryOverride:]):
3288
3289 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3290
3291         Adopt WK_PLATFORM_NAME in WebKitLegacy
3292         https://bugs.webkit.org/show_bug.cgi?id=183948
3293         <rdar://problem/38803908>
3294
3295         Reviewed by Dan Bernstein.
3296
3297         * Configurations/WebKitLegacy.xcconfig:
3298         * MigrateHeaders.make:
3299         * postprocess-headers.sh:
3300
3301 2018-03-23  Brady Eidson  <beidson@apple.com>
3302
3303         Go to back/forward list items after a process-swapped navigation.
3304         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
3305
3306         Reviewed by Andy Estes.
3307
3308         * WebView/WebView.mm:
3309         (-[WebView _loadBackForwardListFromOtherView:]):
3310         (-[WebView goToBackForwardItem:]):
3311
3312 2018-03-22  Tim Horton  <timothy_horton@apple.com>
3313
3314         Improve readability of WebCore's OTHER_LDFLAGS
3315         https://bugs.webkit.org/show_bug.cgi?id=183909
3316         <rdar://problem/38760992>
3317
3318         Reviewed by Dan Bernstein.
3319
3320         * Configurations/Base.xcconfig:
3321         * Configurations/FeatureDefines.xcconfig:
3322
3323 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3324
3325         Enable the minimal simulator feature flag when appropriate
3326         https://bugs.webkit.org/show_bug.cgi?id=183807
3327
3328         Reviewed by Dan Bernstein.
3329
3330         * Configurations/FeatureDefines.xcconfig:
3331
3332 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3333
3334         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
3335         https://bugs.webkit.org/show_bug.cgi?id=183758
3336         <rdar://problem/38017644>
3337
3338         Reviewed by Dan Bernstein.
3339
3340         * Configurations/FeatureDefines.xcconfig:
3341
3342 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
3343
3344         Clear style colors when setting default appearance
3345         https://bugs.webkit.org/show_bug.cgi?id=183759
3346
3347         Reviewed by Tim Horton.
3348
3349         Colors are cached and need to be cleared and recalculated.
3350         Refactor to do all style recalcs together.
3351
3352         * WebView/WebView.mm:
3353         (-[WebView _setDefaultAppearanceAndClearStyle]):
3354         (-[WebView _setUseSystemAppearance:]):
3355         (-[WebView effectiveAppearanceDidChange]):
3356
3357 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3358
3359         Unreviewed, another quick fix for r229699
3360
3361         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
3362
3363         * Configurations/FeatureDefines.xcconfig:
3364
3365 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
3366
3367         Ensure that style is updated when the effective appearance changes
3368         https://bugs.webkit.org/show_bug.cgi?id=183690
3369         <rdar://problem/38385900>
3370
3371         Reviewed by Tim Horton and Wenson Hsieh.
3372
3373         Respond to and respect the effective appearance changing.
3374
3375         * WebView/WebView.mm:
3376         (-[WebView _setUseSystemAppearance:]):
3377         (-[WebView effectiveAppearanceDidChange]):
3378
3379 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
3380
3381         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
3382         https://bugs.webkit.org/show_bug.cgi?id=183677
3383
3384         Reviewed by Tim Horton.
3385
3386         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
3387
3388         * DOM/DOM.mm:
3389         (-[DOMHTMLLinkElement _mediaQueryMatches]):
3390
3391 2018-03-14  Tim Horton  <timothy_horton@apple.com>
3392
3393         Fix the build after r229567
3394
3395         * Configurations/FeatureDefines.xcconfig:
3396
3397 2018-03-12  Tim Horton  <timothy_horton@apple.com>
3398
3399         Stop using SDK conditionals to control feature definitions
3400         https://bugs.webkit.org/show_bug.cgi?id=183430
3401         <rdar://problem/38251619>
3402
3403         Reviewed by Dan Bernstein.
3404
3405         * Configurations/FeatureDefines.xcconfig:
3406         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
3407
3408 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
3409
3410         Runtime flag for link prefetch and remove link subresource.
3411         https://bugs.webkit.org/show_bug.cgi?id=183540
3412
3413         Reviewed by Chris Dumez.
3414
3415         Remove the LINK_PREFETCH build time flag.
3416
3417         * Configurations/FeatureDefines.xcconfig:
3418
3419 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
3420
3421         Remove GridLayout runtime flag
3422         https://bugs.webkit.org/show_bug.cgi?id=183484
3423
3424         Reviewed by Myles C. Maxfield.
3425
3426         The Grid Layout feature has been enabled by default for almost a
3427         year, so I think it's time to remove the runtime flag and the
3428
3429         * WebView/WebPreferenceKeysPrivate.h:
3430         * WebView/WebPreferences.mm:
3431         (+[WebPreferences initialize]):
3432         * WebView/WebPreferencesPrivate.h:
3433         * WebView/WebView.mm:
3434         (-[WebView _preferencesChanged:]):
3435
3436 2018-03-12  Antoine Quint  <graouts@apple.com>
3437
3438         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
3439         https://bugs.webkit.org/show_bug.cgi?id=183504
3440         <rdar://problem/38372965>
3441
3442         Reviewed by Dean Jackson and Jon Lee.
3443
3444         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
3445         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
3446
3447         * WebView/WebPreferenceKeysPrivate.h:
3448         * WebView/WebPreferences.mm:
3449         (+[WebPreferences initialize]):
3450         (-[WebPreferences setModernMediaControlsEnabled:]):
3451         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
3452         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
3453         * WebView/WebPreferencesPrivate.h:
3454         * WebView/WebView.mm:
3455         (-[WebView _preferencesChanged:]):
3456
3457 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
3458
3459         Media query for default appearance
3460         https://bugs.webkit.org/show_bug.cgi?id=183539
3461         <rdar://problem/38326388>
3462
3463         Reviewed by Tim Horton.
3464
3465         Write a media query to evaluate appearance.
3466
3467         * WebView/WebView.mm:
3468         (-[WebView _commonInitializationWithFrameName:groupName:]):
3469         (-[WebView _setUseSystemAppearance:]):
3470
3471 2018-03-09  Andy Estes  <aestes@apple.com>
3472
3473         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
3474         https://bugs.webkit.org/show_bug.cgi?id=183489
3475         <rdar://problem/38267517>
3476
3477         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
3478         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
3479         to issue a sandbox extension for this directory, but for security reasons App Sandbox