[Web Animations] Expose Web Animations CSS integration as an experimental feature
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-05-15  Antoine Quint  <graouts@apple.com>
2
3         [Web Animations] Expose Web Animations CSS integration as an experimental feature
4         https://bugs.webkit.org/show_bug.cgi?id=185647
5
6         Reviewed by Dean Jackson.
7
8         Rename the Web Animations CSS integration flag.
9
10         * WebView/WebPreferenceKeysPrivate.h:
11         * WebView/WebPreferences.mm:
12         (+[WebPreferences initialize]):
13         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
14         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
15         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
16         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
17         * WebView/WebPreferencesPrivate.h:
18         * WebView/WebView.mm:
19         (-[WebView _preferencesChanged:]):
20
21 2018-05-14  Daniel Bates  <dabates@apple.com>
22
23         Fix the Apple Internal build
24
25         See <rdar://problem/40237873> for more details.
26
27         * WebView/WebFullScreenController.mm:
28         (-[WebFullScreenController enterFullScreen:]):
29         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
30         (-[WebFullScreenController exitFullScreen]):
31         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
32         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
33         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
34
35 2018-05-11  Timothy Hatcher  <timothy@apple.com>
36
37         WebHTMLView is not setting aside subviews when drawing.
38
39         https://bugs.webkit.org/show_bug.cgi?id=185561
40         rdar://problem/40172894
41
42         Reviewed by Simon Fraser.
43
44         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
45
46         * WebView/WebHTMLView.mm:
47         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
48
49 2018-05-07  Daniel Bates  <dabates@apple.com>
50
51         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
52         https://bugs.webkit.org/show_bug.cgi?id=185170
53
54         Reviewed by Per Arne Vollan.
55
56         * Misc/WebCache.mm:
57         (+[WebCache empty]):
58
59 2018-05-04  Timothy Hatcher  <timothy@apple.com>
60
61         Deprecate legacy WebView and friends
62         https://bugs.webkit.org/show_bug.cgi?id=185279
63         rdar://problem/33268700
64
65         Reviewed by Tim Horton.
66
67         Added deprecation macros to all the classes, extern strings, and enums.
68
69         * Configurations/WebKitLegacy.xcconfig:
70         Added BUILDING_WEBKIT define to disable the deprecation macros.
71         * DOM/DOMAbstractView.h:
72         * DOM/DOMAttr.h:
73         * DOM/DOMBlob.h:
74         * DOM/DOMCDATASection.h:
75         * DOM/DOMCSSCharsetRule.h:
76         * DOM/DOMCSSFontFaceRule.h:
77         * DOM/DOMCSSImportRule.h:
78         * DOM/DOMCSSMediaRule.h:
79         * DOM/DOMCSSPageRule.h:
80         * DOM/DOMCSSPrimitiveValue.h:
81         * DOM/DOMCSSRule.h:
82         * DOM/DOMCSSRuleList.h:
83         * DOM/DOMCSSStyleDeclaration.h:
84         * DOM/DOMCSSStyleRule.h:
85         * DOM/DOMCSSStyleSheet.h:
86         * DOM/DOMCSSUnknownRule.h:
87         * DOM/DOMCSSValue.h:
88         * DOM/DOMCSSValueList.h:
89         * DOM/DOMCharacterData.h:
90         * DOM/DOMComment.h:
91         * DOM/DOMCounter.h:
92         * DOM/DOMDocument.h:
93         * DOM/DOMDocumentFragment.h:
94         * DOM/DOMDocumentType.h:
95         * DOM/DOMElement.h:
96         * DOM/DOMEntity.h:
97         * DOM/DOMEntityReference.h:
98         * DOM/DOMEvent.h:
99         * DOM/DOMEventException.h:
100         * DOM/DOMEventListener.h:
101         * DOM/DOMEventTarget.h:
102         * DOM/DOMException.h:
103         * DOM/DOMFile.h:
104         * DOM/DOMFileList.h:
105         * DOM/DOMHTMLAnchorElement.h:
106         * DOM/DOMHTMLAppletElement.h:
107         * DOM/DOMHTMLAreaElement.h:
108         * DOM/DOMHTMLBRElement.h:
109         * DOM/DOMHTMLBaseElement.h:
110         * DOM/DOMHTMLBaseFontElement.h:
111         * DOM/DOMHTMLBodyElement.h:
112         * DOM/DOMHTMLButtonElement.h:
113         * DOM/DOMHTMLCanvasElement.h:
114         * DOM/DOMHTMLCollection.h:
115         * DOM/DOMHTMLDListElement.h:
116         * DOM/DOMHTMLDirectoryElement.h:
117         * DOM/DOMHTMLDivElement.h:
118         * DOM/DOMHTMLDocument.h:
119         * DOM/DOMHTMLElement.h:
120         * DOM/DOMHTMLEmbedElement.h:
121         * DOM/DOMHTMLFieldSetElement.h:
122         * DOM/DOMHTMLFontElement.h:
123         * DOM/DOMHTMLFormElement.h:
124         * DOM/DOMHTMLFrameElement.h:
125         * DOM/DOMHTMLFrameSetElement.h:
126         * DOM/DOMHTMLHRElement.h:
127         * DOM/DOMHTMLHeadElement.h:
128         * DOM/DOMHTMLHeadingElement.h:
129         * DOM/DOMHTMLHtmlElement.h:
130         * DOM/DOMHTMLIFrameElement.h:
131         * DOM/DOMHTMLImageElement.h:
132         * DOM/DOMHTMLInputElement.h:
133         * DOM/DOMHTMLLIElement.h:
134         * DOM/DOMHTMLLabelElement.h:
135         * DOM/DOMHTMLLegendElement.h:
136         * DOM/DOMHTMLLinkElement.h:
137         * DOM/DOMHTMLMapElement.h:
138         * DOM/DOMHTMLMarqueeElement.h:
139         * DOM/DOMHTMLMediaElement.h:
140         * DOM/DOMHTMLMenuElement.h:
141         * DOM/DOMHTMLMetaElement.h:
142         * DOM/DOMHTMLModElement.h:
143         * DOM/DOMHTMLOListElement.h:
144         * DOM/DOMHTMLObjectElement.h:
145         * DOM/DOMHTMLOptGroupElement.h:
146         * DOM/DOMHTMLOptionElement.h:
147         * DOM/DOMHTMLOptionsCollection.h:
148         * DOM/DOMHTMLParagraphElement.h:
149         * DOM/DOMHTMLParamElement.h:
150         * DOM/DOMHTMLPreElement.h:
151         * DOM/DOMHTMLQuoteElement.h:
152         * DOM/DOMHTMLScriptElement.h:
153         * DOM/DOMHTMLSelectElement.h:
154         * DOM/DOMHTMLStyleElement.h:
155         * DOM/DOMHTMLTableCaptionElement.h:
156         * DOM/DOMHTMLTableCellElement.h:
157         * DOM/DOMHTMLTableColElement.h:
158         * DOM/DOMHTMLTableElement.h:
159         * DOM/DOMHTMLTableRowElement.h:
160         * DOM/DOMHTMLTableSectionElement.h:
161         * DOM/DOMHTMLTextAreaElement.h:
162         * DOM/DOMHTMLTitleElement.h:
163         * DOM/DOMHTMLUListElement.h:
164         * DOM/DOMHTMLVideoElement.h:
165         * DOM/DOMImplementation.h:
166         * DOM/DOMKeyboardEvent.h:
167         * DOM/DOMMediaError.h:
168         * DOM/DOMMediaList.h:
169         * DOM/DOMMouseEvent.h:
170         * DOM/DOMMutationEvent.h:
171         * DOM/DOMNamedNodeMap.h:
172         * DOM/DOMNode.h:
173         * DOM/DOMNodeFilter.h:
174         * DOM/DOMNodeIterator.h:
175         * DOM/DOMNodeList.h:
176         * DOM/DOMObject.h:
177         * DOM/DOMOverflowEvent.h:
178         * DOM/DOMProcessingInstruction.h:
179         * DOM/DOMProgressEvent.h:
180         * DOM/DOMRGBColor.h:
181         * DOM/DOMRange.h:
182         * DOM/DOMRangeException.h:
183         * DOM/DOMRect.h:
184         * DOM/DOMStyleSheet.h:
185         * DOM/DOMStyleSheetList.h:
186         * DOM/DOMText.h:
187         * DOM/DOMTextEvent.h:
188         * DOM/DOMTimeRanges.h:
189         * DOM/DOMTokenList.h:
190         * DOM/DOMTreeWalker.h:
191         * DOM/DOMUIEvent.h:
192         * DOM/DOMWheelEvent.h:
193         * DOM/DOMXPathException.h:
194         * DOM/DOMXPathExpression.h:
195         * DOM/DOMXPathNSResolver.h:
196         * DOM/DOMXPathResult.h:
197         * History/WebBackForwardList.h:
198         * History/WebHistory.h:
199         * History/WebHistoryItem.h:
200         * Misc/WebDownload.h:
201         * Misc/WebKitErrors.h:
202         * Plugins/WebPluginViewFactory.h:
203         * WebView/WebArchive.h:
204         * WebView/WebDataSource.h:
205         * WebView/WebDocument.h:
206         * WebView/WebEditingDelegate.h:
207         * WebView/WebFormDelegate.h:
208         * WebView/WebFrame.h:
209         * WebView/WebFrameLoadDelegate.h:
210         * WebView/WebFrameView.h:
211         * WebView/WebPolicyDelegate.h:
212         * WebView/WebPreferences.h:
213         * WebView/WebPreferencesPrivate.h:
214         * WebView/WebResourceLoadDelegate.h:
215         * WebView/WebUIDelegate.h:
216         * WebView/WebUIDelegatePrivate.h:
217         * WebView/WebView.h:
218         * WebView/WebViewPrivate.h:
219         * postprocess-headers.sh:
220         Remove step that converts WEBKIT macros to NS macros.
221         Change it to just remove the macros on iOS builds.
222
223 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
224
225         [MediaStream] remove WK1 support
226         https://bugs.webkit.org/show_bug.cgi?id=185136
227
228         Reviewed by Youenn Fablet.
229
230         * WebCoreSupport/WebUserMediaClient.h: Removed.
231         * WebCoreSupport/WebUserMediaClient.mm: Removed.
232         * WebView/WebView.mm:
233         (-[WebView _commonInitializationWithFrameName:groupName:]):
234         (-[WebView _preferencesChanged:]):
235         (-[WebView _setUserMediaClient:]): Deleted.
236         (-[WebView _userMediaClient]): Deleted.
237         * WebView/WebViewData.h:
238         * WebView/WebViewPrivate.h:
239
240 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
241
242         WebAssembly: add support for stream APIs - JavaScript API
243         https://bugs.webkit.org/show_bug.cgi?id=183442
244
245         Reviewed by Yusuke Suzuki and JF Bastien.
246
247         Add WEBASSEMBLY_STREAMINNG_API feature flag
248
249         * Configurations/FeatureDefines.xcconfig:
250
251 2018-04-30  JF Bastien  <jfbastien@apple.com>
252
253         Use some C++17 features
254         https://bugs.webkit.org/show_bug.cgi?id=185135
255
256         Reviewed by Alex Christensen.
257
258         * Configurations/WebKitLegacy.xcconfig:
259
260 2018-04-27  Chris Dumez  <cdumez@apple.com>
261
262         Use WindowProxy instead of DOMWindow in our IDL
263         https://bugs.webkit.org/show_bug.cgi?id=185022
264
265         Reviewed by Sam Weinig.
266
267         * DOM/DOMAbstractView.mm:
268         (kit):
269         (toWindowProxy):
270         * DOM/DOMAbstractViewInternal.h:
271         * DOM/DOMDocument.mm:
272         (-[DOMDocument defaultView]):
273         (-[DOMDocument getComputedStyle:pseudoElement:]):
274         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
275         * DOM/DOMHTMLFrameElement.mm:
276         (-[DOMHTMLFrameElement contentWindow]):
277         * DOM/DOMHTMLIFrameElement.mm:
278         (-[DOMHTMLIFrameElement contentWindow]):
279         * DOM/DOMKeyboardEvent.mm:
280         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
281         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
282         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
283         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
284         * DOM/DOMMouseEvent.mm:
285         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
286         * DOM/DOMTextEvent.mm:
287         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
288         * DOM/DOMUIEvent.mm:
289         (-[DOMUIEvent view]):
290         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
291         * DOM/DOMWheelEvent.mm:
292         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
293
294 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
295
296         Implement rendering support for the color-filter CSS property
297         https://bugs.webkit.org/show_bug.cgi?id=185047
298         rdar://problem/39664967
299
300         Reviewed by Tim Horton.
301         
302         The body background should reflect the filtered color.
303
304         * WebView/WebFrame.mm:
305         (-[WebFrame _bodyBackgroundColor]):
306         * WebView/WebView.mm:
307         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
308
309 2018-04-26  Jer Noble  <jer.noble@apple.com>
310
311         WK_COCOA_TOUCH all the things.
312         https://bugs.webkit.org/show_bug.cgi?id=185006
313
314         Reviewed by Tim Horton.
315
316         * Configurations/WebKitLegacy.xcconfig:
317
318 2018-04-26  Daniel Bates  <dabates@apple.com>
319
320         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
321         https://bugs.webkit.org/show_bug.cgi?id=184161
322         <rdar://problem/39051645>
323
324         Reviewed by Dan Bernstein.
325
326         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
327         dropping a PDF embedded using an HTML image element into the same web view.
328
329         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
330         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
331         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
332         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
333         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
334         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
335         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
336         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
337         image document when navigated to directly. Since we can support dragging PDF document images we need to
338         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
339         We need to do both such queries before falling back to using the main resource of the Web Archive as
340         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
341         not an image document.
342
343         * Misc/WebNSPasteboardExtras.mm:
344         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
345
346 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
347
348         Disable content filtering in minimal simulator mode
349         https://bugs.webkit.org/show_bug.cgi?id=185027
350         <rdar://problem/39736091>
351
352         Reviewed by Jer Noble.
353
354         * Configurations/FeatureDefines.xcconfig:
355
356 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
357
358         [INTL] Implement Intl.PluralRules
359         https://bugs.webkit.org/show_bug.cgi?id=184312
360
361         Reviewed by JF Bastien.
362
363         Added Intl.PluralRules feature flag.
364
365         * Configurations/FeatureDefines.xcconfig:
366
367 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
368
369         Remove access to keychain from the WebContent process
370         https://bugs.webkit.org/show_bug.cgi?id=184428
371         <rdar://problem/13150903>
372
373         Reviewed by Brent Fulgham.
374
375         This patch does the followings:
376         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
377         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
378         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
379
380         * WebCoreSupport/WebChromeClient.h:
381         * WebCoreSupport/WebChromeClient.mm:
382         (WebChromeClient::signedPublicKeyAndChallengeString const):
383         * WebView/WebUIDelegatePrivate.h:
384
385 2018-04-24  Jer Noble  <jer.noble@apple.com>
386
387         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
388         https://bugs.webkit.org/show_bug.cgi?id=184786
389
390         Reviewed by Tim Horton.
391
392         * Configurations/WebKitLegacy.xcconfig:
393         * MigrateHeaders.make:
394
395 2018-04-23  Daniel Bates  <dabates@apple.com>
396
397         Implement Same-Site cookies
398         https://bugs.webkit.org/show_bug.cgi?id=159464
399         <rdar://problem/27196358>
400
401         Reviewed by Brent Fulgham.
402
403         Pass the Same-Site info through the strategy.
404
405         * WebCoreSupport/WebPlatformStrategies.h:
406         * WebCoreSupport/WebPlatformStrategies.mm:
407         (WebPlatformStrategies::cookiesForDOM):
408         (WebPlatformStrategies::setCookiesFromDOM):
409         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
410         (WebPlatformStrategies::getRawCookies):
411
412 2018-04-23  Zalan Bujtas  <zalan@apple.com>
413
414         [LayoutFormattingContext] Initial commit.
415         https://bugs.webkit.org/show_bug.cgi?id=184896
416
417         Reviewed by Antti Koivisto.
418
419         * Configurations/FeatureDefines.xcconfig:
420
421 2018-04-23  Daniel Bates  <dabates@apple.com>
422
423         Implement Same-Site cookies
424         https://bugs.webkit.org/show_bug.cgi?id=159464
425         <rdar://problem/27196358>
426
427         Reviewed by Brent Fulgham.
428
429         Pass the Same-Site info through the strategy.
430
431         * WebCoreSupport/WebPlatformStrategies.h:
432         * WebCoreSupport/WebPlatformStrategies.mm:
433         (WebPlatformStrategies::cookiesForDOM):
434         (WebPlatformStrategies::setCookiesFromDOM):
435         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
436         (WebPlatformStrategies::getRawCookies):
437
438 2018-04-20  Timothy Hatcher  <timothy@apple.com>
439
440         NULL dereference crash sometimes under [super initWithCoder:] in WebView
441
442         https://bugs.webkit.org/show_bug.cgi?id=184851
443         rdar://problem/39611236
444
445         Reviewed by Tim Horton.
446
447         * WebView/WebView.mm:
448         (-[WebView _commonInitializationWithFrameName:groupName:]):
449         (-[WebView effectiveAppearanceDidChange]):
450         Added a null check and call the code later in initialization.
451
452 2018-04-20  Tim Horton  <timothy_horton@apple.com>
453
454         Adjust geolocation feature flag
455         https://bugs.webkit.org/show_bug.cgi?id=184856
456
457         Reviewed by Wenson Hsieh.
458
459         * Configurations/FeatureDefines.xcconfig:
460
461 2018-04-18  Jer Noble  <jer.noble@apple.com>
462
463         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
464         https://bugs.webkit.org/show_bug.cgi?id=184762
465
466         Reviewed by Dan Bernstein.
467
468         * Configurations/WebKitLegacy.xcconfig:
469
470 2018-04-20  Youenn Fablet  <youenn@apple.com>
471
472         Make PluginData cache its web visible plugins
473         https://bugs.webkit.org/show_bug.cgi?id=184421
474
475         Reviewed by Chris Dumez.
476
477         * WebCoreSupport/WebPluginInfoProvider.h:
478         * WebCoreSupport/WebPluginInfoProvider.mm:
479         (WebPluginInfoProvider::pluginInfo):
480         (WebPluginInfoProvider::webVisiblePluginInfo):
481
482 2018-04-19  Chris Dumez  <cdumez@apple.com>
483
484         Rename JSDOMWindowProxy to JSWindowProxy
485         https://bugs.webkit.org/show_bug.cgi?id=184797
486
487         Reviewed by Sam Weinig.
488
489         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
490
491         * DOM/DOMUtility.mm:
492         (createDOMWrapper):
493         * WebView/WebFrame.mm:
494         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
495
496 2018-04-19  David Kilzer  <ddkilzer@apple.com>
497
498         Enable Objective-C weak references
499         <https://webkit.org/b/184789>
500         <rdar://problem/39571716>
501
502         Reviewed by Dan Bernstein.
503
504         * Configurations/Base.xcconfig:
505         (CLANG_ENABLE_OBJC_WEAK): Enable.
506
507 2018-04-18  Chris Dumez  <cdumez@apple.com>
508
509         Rename WindowProxyController to WindowProxy
510         https://bugs.webkit.org/show_bug.cgi?id=184756
511
512         Reviewed by Sam Weinig.
513
514         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
515         needed use WindowProxyController type, which was a bit confusing.
516
517         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
518         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
519         * WebView/WebFrame.mm:
520         (-[WebFrame _attachScriptDebugger]):
521
522 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
523
524         Unreviewed rollout of r230632. Regression in memory usage.
525
526         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
527
528         * WebView/WebPreferences.mm:
529         (+[WebPreferences initialize]):
530
531 2018-04-17  Chris Dumez  <cdumez@apple.com>
532
533         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
534         https://bugs.webkit.org/show_bug.cgi?id=184678
535         <rdar://problem/39422122>
536
537         Reviewed by Alex Christensen.
538
539         Add new parameter to dispatchDecidePolicyForNavigationAction.
540
541         * WebCoreSupport/WebFrameLoaderClient.h:
542         * WebCoreSupport/WebFrameLoaderClient.mm:
543         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
544
545 2018-04-13  Chris Dumez  <cdumez@apple.com>
546
547         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
548         https://bugs.webkit.org/show_bug.cgi?id=184591
549
550         Reviewed by Sam Weinig.
551
552         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
553         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
554         This is work towards fixing Bug 184515.
555
556         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
557         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
558         * WebView/WebFrame.mm:
559         (-[WebFrame _attachScriptDebugger]):
560
561 2018-04-12  Antoine Quint  <graouts@apple.com>
562
563         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
564         https://bugs.webkit.org/show_bug.cgi?id=184569
565         <rdar://problem/38671301>
566
567         Reviewed by Jon Lee.
568
569         * WebView/WebPreferences.mm:
570
571 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
572
573         [WTF] Remove StaticLock
574         https://bugs.webkit.org/show_bug.cgi?id=184332
575
576         Reviewed by Mark Lam.
577
578         * DOM/DOMInternal.mm:
579         (getDOMWrapper):
580         (addDOMWrapper):
581         (removeDOMWrapper):
582
583 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
584
585         Failures from mach port reference handling should be fatal
586         https://bugs.webkit.org/show_bug.cgi?id=184202
587         <rdar://problem/37771114>
588
589         Reviewed by Anders Carlsson.
590
591         * Plugins/Hosted/NetscapePluginHostManager.mm:
592         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
593
594 2018-04-03  Andy Estes  <aestes@apple.com>
595
596         [Mac] Prioritize file promises over filenames during drag and drop
597         https://bugs.webkit.org/show_bug.cgi?id=184237
598         <rdar://problem/38278076>
599
600         Reviewed by Wenson Hsieh.
601
602         * WebView/WebView.mm:
603         (-[WebView performDragOperation:]):
604
605 2018-04-03  Chris Dumez  <cdumez@apple.com>
606
607         Drop MainFrame class
608         https://bugs.webkit.org/show_bug.cgi?id=184191
609
610         Reviewed by Darin Adler.
611
612         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
613         relationship between the Page and the MainFrame.
614
615         This is ground work for introducing LocalFrame / RemoteFrame concepts.
616
617         * WebCoreSupport/WebDragClient.mm:
618         * WebCoreSupport/WebFrameLoaderClient.mm:
619         * WebCoreSupport/WebInspectorClient.mm:
620         * WebCoreSupport/WebPlatformStrategies.mm:
621         * WebCoreSupport/WebPluginInfoProvider.mm:
622         * WebView/WebFrame.mm:
623         * WebView/WebFrameView.mm:
624         * WebView/WebHTMLView.mm:
625         * WebView/WebView.mm:
626
627 2018-04-02  Jer Noble  <jer.noble@apple.com>
628
629         Enable Legacy EME for all WebKit & WebKitLegacy clients
630         https://bugs.webkit.org/show_bug.cgi?id=184018
631         <rdar://problem/34887387>
632
633         Reviewed by Eric Carlson.
634
635         * WebView/WebPreferences.mm:
636         (+[WebPreferences initialize]):
637
638 2018-03-29  JF Bastien  <jfbastien@apple.com>
639
640         Use Forward.h instead of forward-declaring WTF::String
641         https://bugs.webkit.org/show_bug.cgi?id=184172
642         <rdar://problem/39026146>
643
644         Reviewed by Yusuke Suzuki.
645
646         As part of #184164 I'm changing WTF::String, and the forward
647         declarations are just wrong because I'm making it templated. We
648         should use Forward.h anyways, so do that instead.
649
650         * WebView/WebScriptDebugger.h:
651
652 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
653
654         Protect against invalid mach ports returned by mach_port_request_notification
655         https://bugs.webkit.org/show_bug.cgi?id=184106
656         <rdar://problem/37865316>
657
658         Reviewed by Chris Dumez.
659
660         * Plugins/Hosted/NetscapePluginHostProxy.mm:
661         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
662         and clean up if it experienced an error.
663         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
664
665 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
666
667         Avoid uninitialized mach ports
668         https://bugs.webkit.org/show_bug.cgi?id=184090
669         <rdar://problem/37261129>
670
671         Reviewed by Chris Dumez.
672
673         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
674         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
675         there is a potential for us to try to use invalid ports.
676
677         We should always check return values, and ensure that the mach port variables we seek to initialize are
678         kept in a valid state.
679
680         Reviewed by Chris Dumez.
681
682         * Plugins/Hosted/NetscapePluginHostManager.h:
683         * Plugins/Hosted/NetscapePluginHostManager.mm:
684         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
685         port is passed to an API function.
686         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
687         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
688         * Plugins/Hosted/NetscapePluginHostProxy.h:
689         * Plugins/Hosted/NetscapePluginHostProxy.mm:
690         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
691         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
692         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
693         (WKPCStatusText): Ditto.
694         (WKPCLoadURL): Ditto.
695         (WKPCCancelLoadURL): Ditto.
696         (WKPCInvalidateRect): Ditto.
697         (WKPCGetScriptableNPObjectReply): Ditto.
698         (WKPCBooleanReply): Ditto.
699         (WKPCBooleanAndDataReply): Ditto.
700         (WKPCInstantiatePluginReply): Ditto.
701         (WKPCGetWindowNPObject): Ditto.
702         (WKPCGetPluginElementNPObject): Ditto.
703         (WKPCForgetBrowserObject): Ditto.
704         (WKPCEvaluate): Ditto.
705         (WKPCGetStringIdentifier): Ditto.
706         (WKPCGetIntIdentifier): Ditto.
707         (WKPCInvoke): Ditto.
708         (WKPCInvokeDefault): Ditto.
709         (WKPCConstruct): Ditto.
710         (WKPCGetProperty): Ditto.
711         (WKPCSetProperty): Ditto.
712         (WKPCRemoveProperty): Ditto.
713         (WKPCHasProperty): Ditto.
714         (WKPCHasMethod): Ditto.
715         (WKPCIdentifierInfo): Ditto.
716         (WKPCEnumerate): Ditto.
717         (WKPCSetMenuBarVisible): Ditto.
718         (WKPCSetFullscreenWindowIsShowing): Ditto.
719         (WKPCSetModal): Ditto.
720         (WKPCGetCookies): Ditto.
721         (WKPCGetProxy): Ditto.
722         (WKPCSetCookies): Ditto.
723         (WKPCGetAuthenticationInfo): Ditto.
724         (WKPCConvertPoint): Ditto.
725         (WKPCLayerHostingModeChanged): Ditto.
726         (WKPCSetException): Ditto.
727
728 2018-03-26  Tim Horton  <timothy_horton@apple.com>
729
730         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
731         https://bugs.webkit.org/show_bug.cgi?id=184030
732         <rdar://problem/38895281>
733
734         Reviewed by Dan Bernstein.
735
736         * Configurations/Base.xcconfig:
737
738 2018-03-26  Chris Dumez  <cdumez@apple.com>
739
740         Use SecurityOriginData more consistently in Service Worker code
741         https://bugs.webkit.org/show_bug.cgi?id=183969
742
743         Reviewed by Darin Adler.
744
745         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
746
747         * Storage/WebDatabaseManager.mm:
748         (-[WebDatabaseManager databasesWithOrigin:]):
749         (-[WebDatabaseManager deleteOrigin:]):
750         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
751         * Storage/WebDatabaseQuotaManager.mm:
752         (-[WebDatabaseQuotaManager usage]):
753         (-[WebDatabaseQuotaManager quota]):
754         (-[WebDatabaseQuotaManager setQuota:]):
755         * Storage/WebStorageManager.mm:
756         (-[WebStorageManager deleteOrigin:]):
757         * WebCoreSupport/WebSecurityOrigin.mm:
758         (-[WebSecurityOrigin databaseIdentifier]):
759         (-[WebSecurityOrigin usage]):
760         (-[WebSecurityOrigin quota]):
761         (-[WebSecurityOrigin setQuota:]):
762
763 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
764
765         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
766         https://bugs.webkit.org/show_bug.cgi?id=183911
767         <rdar://problem/38762306>
768
769         Reviewed by Youenn Fablet.
770
771         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
772
773         * WebView/WebView.mm:
774         (+[WebView initialize]):
775
776 2018-03-26  Alex Christensen  <achristensen@webkit.org>
777
778         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
779         https://bugs.webkit.org/show_bug.cgi?id=183965
780
781         Reviewed by Chris Dumez.
782
783         * WebCoreSupport/WebFrameLoaderClient.h:
784         * WebCoreSupport/WebFrameLoaderClient.mm:
785         (WebFrameLoaderClient::willCacheResponse const):
786
787 2018-03-25  Commit Queue  <commit-queue@webkit.org>
788
789         Unreviewed, rolling out r229954.
790         https://bugs.webkit.org/show_bug.cgi?id=184000
791
792         Caused many layout tests to crash on Apple High Sierra,
793         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
794         by dydz on #webkit).
795
796         Reverted changeset:
797
798         "Use SecurityOriginData more consistently in Service Worker
799         code"
800         https://bugs.webkit.org/show_bug.cgi?id=183969
801         https://trac.webkit.org/changeset/229954
802
803 2018-03-24  Chris Dumez  <cdumez@apple.com>
804
805         Use SecurityOriginData more consistently in Service Worker code
806         https://bugs.webkit.org/show_bug.cgi?id=183969
807
808         Reviewed by Darin Adler.
809
810         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
811
812         * Storage/WebDatabaseManager.mm:
813         (-[WebDatabaseManager databasesWithOrigin:]):
814         (-[WebDatabaseManager deleteOrigin:]):
815         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
816         * Storage/WebDatabaseQuotaManager.mm:
817         (-[WebDatabaseQuotaManager usage]):
818         (-[WebDatabaseQuotaManager quota]):
819         (-[WebDatabaseQuotaManager setQuota:]):
820         * Storage/WebStorageManager.mm:
821         (-[WebStorageManager deleteOrigin:]):
822         * WebCoreSupport/WebSecurityOrigin.mm:
823         (-[WebSecurityOrigin databaseIdentifier]):
824         (-[WebSecurityOrigin usage]):
825         (-[WebSecurityOrigin quota]):
826         (-[WebSecurityOrigin setQuota:]):
827
828 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
829
830         Fix the build
831
832         * WebView/WebView.mm:
833
834 2018-03-23  Tim Horton  <timothy_horton@apple.com>
835
836         Fix the build with no pasteboard
837         https://bugs.webkit.org/show_bug.cgi?id=183973
838
839         Reviewed by Dan Bernstein.
840
841         * Configurations/FeatureDefines.xcconfig:
842         * WebView/WebView.mm:
843         (-[WebView _requestStartDataInteraction:globalPosition:]):
844         (-[WebView _getDataInteractionData]):
845         (-[WebView _dataOperationTextIndicator]):
846         (-[WebView _dragSourceAction]):
847         (-[WebView _draggedLinkTitle]):
848         (-[WebView _draggedLinkURL]):
849         (-[WebView _draggedElementBounds]):
850         (-[WebView _enteredDataInteraction:client:global:operation:]):
851         (-[WebView _updatedDataInteraction:client:global:operation:]):
852         (-[WebView _exitedDataInteraction:client:global:operation:]):
853         (-[WebView _performDataInteraction:client:global:operation:]):
854         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
855         (-[WebView _endedDataInteraction:global:]):
856         (-[WebView _dataInteractionCaretRect]):
857         * WebView/WebViewPrivate.h:
858
859 2018-03-23  Tim Horton  <timothy_horton@apple.com>
860
861         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
862         https://bugs.webkit.org/show_bug.cgi?id=183960
863         <rdar://problem/38812356>
864
865         Reviewed by Dan Bernstein.
866
867         * Configurations/WebKitLegacy.xcconfig:
868
869 2018-03-23  Tim Horton  <timothy_horton@apple.com>
870
871         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
872         https://bugs.webkit.org/show_bug.cgi?id=183954
873         <rdar://problem/38808858>
874
875         Reviewed by Dan Bernstein.
876
877         * WebView/WebPreferences.mm:
878         (-[WebPreferences setAudioSessionCategoryOverride:]):
879
880 2018-03-23  Tim Horton  <timothy_horton@apple.com>
881
882         Adopt WK_PLATFORM_NAME in WebKitLegacy
883         https://bugs.webkit.org/show_bug.cgi?id=183948
884         <rdar://problem/38803908>
885
886         Reviewed by Dan Bernstein.
887
888         * Configurations/WebKitLegacy.xcconfig:
889         * MigrateHeaders.make:
890         * postprocess-headers.sh:
891
892 2018-03-23  Brady Eidson  <beidson@apple.com>
893
894         Go to back/forward list items after a process-swapped navigation.
895         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
896
897         Reviewed by Andy Estes.
898
899         * WebView/WebView.mm:
900         (-[WebView _loadBackForwardListFromOtherView:]):
901         (-[WebView goToBackForwardItem:]):
902
903 2018-03-22  Tim Horton  <timothy_horton@apple.com>
904
905         Improve readability of WebCore's OTHER_LDFLAGS
906         https://bugs.webkit.org/show_bug.cgi?id=183909
907         <rdar://problem/38760992>
908
909         Reviewed by Dan Bernstein.
910
911         * Configurations/Base.xcconfig:
912         * Configurations/FeatureDefines.xcconfig:
913
914 2018-03-20  Tim Horton  <timothy_horton@apple.com>
915
916         Enable the minimal simulator feature flag when appropriate
917         https://bugs.webkit.org/show_bug.cgi?id=183807
918
919         Reviewed by Dan Bernstein.
920
921         * Configurations/FeatureDefines.xcconfig:
922
923 2018-03-20  Tim Horton  <timothy_horton@apple.com>
924
925         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
926         https://bugs.webkit.org/show_bug.cgi?id=183758
927         <rdar://problem/38017644>
928
929         Reviewed by Dan Bernstein.
930
931         * Configurations/FeatureDefines.xcconfig:
932
933 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
934
935         Clear style colors when setting default appearance
936         https://bugs.webkit.org/show_bug.cgi?id=183759
937
938         Reviewed by Tim Horton.
939
940         Colors are cached and need to be cleared and recalculated.
941         Refactor to do all style recalcs together.
942
943         * WebView/WebView.mm:
944         (-[WebView _setDefaultAppearanceAndClearStyle]):
945         (-[WebView _setUseSystemAppearance:]):
946         (-[WebView effectiveAppearanceDidChange]):
947
948 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
949
950         Unreviewed, another quick fix for r229699
951
952         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
953
954         * Configurations/FeatureDefines.xcconfig:
955
956 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
957
958         Ensure that style is updated when the effective appearance changes
959         https://bugs.webkit.org/show_bug.cgi?id=183690
960         <rdar://problem/38385900>
961
962         Reviewed by Tim Horton and Wenson Hsieh.
963
964         Respond to and respect the effective appearance changing.
965
966         * WebView/WebView.mm:
967         (-[WebView _setUseSystemAppearance:]):
968         (-[WebView effectiveAppearanceDidChange]):
969
970 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
971
972         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
973         https://bugs.webkit.org/show_bug.cgi?id=183677
974
975         Reviewed by Tim Horton.
976
977         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
978
979         * DOM/DOM.mm:
980         (-[DOMHTMLLinkElement _mediaQueryMatches]):
981
982 2018-03-14  Tim Horton  <timothy_horton@apple.com>
983
984         Fix the build after r229567
985
986         * Configurations/FeatureDefines.xcconfig:
987
988 2018-03-12  Tim Horton  <timothy_horton@apple.com>
989
990         Stop using SDK conditionals to control feature definitions
991         https://bugs.webkit.org/show_bug.cgi?id=183430
992         <rdar://problem/38251619>
993
994         Reviewed by Dan Bernstein.
995
996         * Configurations/FeatureDefines.xcconfig:
997         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
998
999 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
1000
1001         Runtime flag for link prefetch and remove link subresource.
1002         https://bugs.webkit.org/show_bug.cgi?id=183540
1003
1004         Reviewed by Chris Dumez.
1005
1006         Remove the LINK_PREFETCH build time flag.
1007
1008         * Configurations/FeatureDefines.xcconfig:
1009
1010 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
1011
1012         Remove GridLayout runtime flag
1013         https://bugs.webkit.org/show_bug.cgi?id=183484
1014
1015         Reviewed by Myles C. Maxfield.
1016
1017         The Grid Layout feature has been enabled by default for almost a
1018         year, so I think it's time to remove the runtime flag and the
1019
1020         * WebView/WebPreferenceKeysPrivate.h:
1021         * WebView/WebPreferences.mm:
1022         (+[WebPreferences initialize]):
1023         * WebView/WebPreferencesPrivate.h:
1024         * WebView/WebView.mm:
1025         (-[WebView _preferencesChanged:]):
1026
1027 2018-03-12  Antoine Quint  <graouts@apple.com>
1028
1029         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
1030         https://bugs.webkit.org/show_bug.cgi?id=183504
1031         <rdar://problem/38372965>
1032
1033         Reviewed by Dean Jackson and Jon Lee.
1034
1035         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
1036         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
1037
1038         * WebView/WebPreferenceKeysPrivate.h:
1039         * WebView/WebPreferences.mm:
1040         (+[WebPreferences initialize]):
1041         (-[WebPreferences setModernMediaControlsEnabled:]):
1042         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
1043         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
1044         * WebView/WebPreferencesPrivate.h:
1045         * WebView/WebView.mm:
1046         (-[WebView _preferencesChanged:]):
1047
1048 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
1049
1050         Media query for default appearance
1051         https://bugs.webkit.org/show_bug.cgi?id=183539
1052         <rdar://problem/38326388>
1053
1054         Reviewed by Tim Horton.
1055
1056         Write a media query to evaluate appearance.
1057
1058         * WebView/WebView.mm:
1059         (-[WebView _commonInitializationWithFrameName:groupName:]):
1060         (-[WebView _setUseSystemAppearance:]):
1061
1062 2018-03-09  Andy Estes  <aestes@apple.com>
1063
1064         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
1065         https://bugs.webkit.org/show_bug.cgi?id=183489
1066         <rdar://problem/38267517>
1067
1068         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
1069         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
1070         to issue a sandbox extension for this directory, but for security reasons App Sandbox
1071         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
1072         block with a nil error and a valid file URL, but no file will actually exist at that URL.
1073
1074         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
1075         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
1076         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
1077         drop destination.
1078
1079         Reviewed by Wenson Hsieh.
1080
1081         * WebView/WebView.mm:
1082         (-[WebView performDragOperation:]):
1083
1084 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
1085
1086         Allow WebViews to disable system appearance
1087         https://bugs.webkit.org/show_bug.cgi?id=183418
1088         <rdar://problem/36975642>
1089
1090         Reviewed by Tim Horton.
1091
1092         Allow webviews to choose whether or not to follow the default system appearance.
1093
1094         * WebView/WebView.mm:
1095         (-[WebView _setUseSystemAppearance:]):
1096         (-[WebView _useSystemAppearance]):
1097         * WebView/WebViewPrivate.h:
1098
1099 2018-03-08  Youenn Fablet  <youenn@apple.com>
1100
1101         libwebrtc update broke internal builds
1102         https://bugs.webkit.org/show_bug.cgi?id=183454
1103
1104         Reviewed by Eric Carlson.
1105
1106         * Configurations/WebKitLegacy.xcconfig:
1107
1108 2018-03-08  Chris Dumez  <cdumez@apple.com>
1109
1110         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
1111         https://bugs.webkit.org/show_bug.cgi?id=183455
1112         <rdar://problem/38191749>
1113
1114         Reviewed by Youenn Fablet.
1115
1116         Add a null check for the page as we have evidence from crashes that it can be null.
1117         Other functions in WebFrameNetworkingContext already null check the page as well,
1118         not just the frame so this is consistent.
1119
1120         * WebCoreSupport/WebFrameNetworkingContext.mm:
1121         (WebFrameNetworkingContext::storageSession const):
1122
1123 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1124
1125         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
1126         https://bugs.webkit.org/show_bug.cgi?id=183429
1127
1128         Reviewed by Mark Lam.
1129
1130         * DOM/DOM.mm:
1131         (+[DOMNode _nodeFromJSWrapper:]):
1132         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1133         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
1134         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
1135         * Plugins/Hosted/ProxyInstance.mm:
1136         (WebKit::ProxyInstance::invokeMethod):
1137         * WebView/WebView.mm:
1138         (aeDescFromJSValue):
1139
1140 2018-03-08  Tim Horton  <timothy_horton@apple.com>
1141
1142         Stop linking ApplicationServices directly
1143         https://bugs.webkit.org/show_bug.cgi?id=182867
1144         <rdar://problem/38252142>
1145
1146         Reviewed by Alex Christensen.
1147
1148         The frameworks that we use that live inside ApplicationServices
1149         have mostly moved out, so import them directly.
1150
1151         * Carbon/CarbonUtils.h:
1152         * WebKitPrefix.h:
1153         * WebView/WebHTMLView.mm:
1154         * WebView/WebPDFView.mm:
1155
1156 2018-03-07  Tim Horton  <timothy_horton@apple.com>
1157
1158         Sort and separate FeatureDefines.xcconfig
1159         https://bugs.webkit.org/show_bug.cgi?id=183427
1160
1161         Reviewed by Dan Bernstein.
1162
1163         * Configurations/FeatureDefines.xcconfig:
1164         Sort and split FeatureDefines into paragraphs
1165         (to make it easier to sort later).
1166
1167 2018-03-07  Youenn Fablet  <youenn@apple.com>
1168
1169         Match unsupported plugins based on domains and not origin
1170         https://bugs.webkit.org/show_bug.cgi?id=183384
1171
1172         Reviewed by Chris Dumez.
1173
1174         * WebCoreSupport/WebPluginInfoProvider.h:
1175         * WebCoreSupport/WebPluginInfoProvider.mm:
1176         (WebPluginInfoProvider::getPluginInfo):
1177         (WebPluginInfoProvider::getWebVisiblePluginInfo):
1178
1179 2018-03-05  Andy Estes  <aestes@apple.com>
1180
1181         [Mac] Teach WebCore::Pasteboard about file promise drags
1182         https://bugs.webkit.org/show_bug.cgi?id=183314
1183         <rdar://problem/38105493>
1184
1185         Reviewed by Darin Adler.
1186
1187         Added a FIXME comment.
1188
1189         * WebView/WebView.mm:
1190         (-[WebView performDragOperation:]):
1191
1192 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1193
1194         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
1195         https://bugs.webkit.org/show_bug.cgi?id=183312
1196
1197         Reviewed by Mark Lam.
1198
1199         Remove wtf/CurrentTime.h include pragma.
1200
1201         * WebView/WebFrame.mm:
1202         * WebView/WebPDFView.mm:
1203
1204 2018-03-04  Tim Horton  <timothy_horton@apple.com>
1205
1206         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
1207         https://bugs.webkit.org/show_bug.cgi?id=183283
1208         <rdar://problem/38062148>
1209
1210         Reviewed by Sam Weinig.
1211
1212         * Configurations/FeatureDefines.xcconfig:
1213
1214 2018-02-28  Alex Christensen  <achristensen@webkit.org>
1215
1216         Reduce use of NetworkingContext in WebKit
1217         https://bugs.webkit.org/show_bug.cgi?id=183213
1218
1219         Reviewed by Brady Eidson.
1220
1221         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1222         (WebKit::NetscapePluginInstanceProxy::getProxy):
1223         * Plugins/WebNetscapePluginView.mm:
1224         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1225
1226 2018-02-17  Darin Adler  <darin@apple.com>
1227
1228         Prepare for ExtendedColor changes (first step)
1229         https://bugs.webkit.org/show_bug.cgi?id=182904
1230
1231         Reviewed by Sam Weinig.
1232
1233         * Misc/WebKitNSStringExtras.mm:
1234         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
1235
1236 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1237
1238         Remove currentTime() / currentTimeMS()
1239         https://bugs.webkit.org/show_bug.cgi?id=183052
1240
1241         Reviewed by Mark Lam.
1242
1243         * WebCoreSupport/WebFrameLoaderClient.h:
1244         * WebCoreSupport/WebFrameLoaderClient.mm:
1245         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1246
1247 2018-02-16  Youenn Fablet  <youenn@apple.com>
1248
1249         Allow specifying which plug-ins are supported
1250         https://bugs.webkit.org/show_bug.cgi?id=182748
1251
1252         Reviewed by Chris Dumez.
1253
1254         * WebCoreSupport/WebPluginInfoProvider.h:
1255         * WebCoreSupport/WebPluginInfoProvider.mm:
1256         (WebPluginInfoProvider::getPluginInfo):
1257         (WebPluginInfoProvider::getWebVisiblePluginInfo):
1258
1259 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
1260
1261         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
1262         https://bugs.webkit.org/show_bug.cgi?id=182882
1263         <rdar://problem/35672661>
1264
1265         Reviewed by Dan Bernstein.
1266
1267         Make sure the smart pointer hold the collection of subviews lives at least as
1268         long as the loop using it.
1269
1270         * WebView/WebHTMLView.mm:
1271         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
1272
1273 2018-02-14  Daniel Bates  <dabates@apple.com>
1274
1275         Disallow cross-origin subresources from asking for credentials
1276         https://bugs.webkit.org/show_bug.cgi?id=182579
1277         <rdar://problem/36162271>
1278
1279         Reviewed by Andy Estes.
1280
1281         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
1282         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
1283
1284         * WebView/WebPreferenceKeysPrivate.h:
1285         * WebView/WebPreferences.mm:
1286         (+[WebPreferences initialize]):
1287         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
1288         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
1289         * WebView/WebPreferencesPrivate.h:
1290         * WebView/WebView.mm:
1291         (-[WebView _preferencesChanged:]):
1292
1293 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1294
1295         Remove ForwardingHeaders directory from WebKitLegacy/mac.
1296         https://bugs.webkit.org/show_bug.cgi?id=182738
1297
1298         Reviewed by Darin Adler.
1299
1300         * ForwardingHeaders/collector/handles/Global.h: Removed.
1301         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
1302         * ForwardingHeaders/runtime/Completion.h: Removed.
1303         * ForwardingHeaders/runtime/Error.h: Removed.
1304         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
1305         * ForwardingHeaders/runtime/JSFunction.h: Removed.
1306         * ForwardingHeaders/runtime/JSLock.h: Removed.
1307         * ForwardingHeaders/runtime/JSObject.h: Removed.
1308         * ForwardingHeaders/runtime/JSString.h: Removed.
1309         * ForwardingHeaders/runtime/Protect.h: Removed.
1310         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
1311
1312 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
1313
1314         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
1315         https://bugs.webkit.org/show_bug.cgi?id=182641
1316
1317         Reviewed by Dan Bernstein.
1318
1319         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
1320         https://trac.webkit.org/changeset/228308.
1321
1322         * WebView/WebVideoFullscreenController.h:
1323         * WebView/WebVideoFullscreenHUDWindowController.mm:
1324         * WebView/WebWindowAnimation.h:
1325         * WebView/WebWindowAnimation.mm:
1326         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
1327         (WebCore::scaledRect): Deleted.
1328         (WebCore::squaredDistance): Deleted.
1329
1330 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
1331
1332         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
1333
1334         * WebView/WebWindowAnimation.mm:
1335         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
1336
1337 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
1338
1339         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
1340         https://bugs.webkit.org/show_bug.cgi?id=182615
1341
1342         Reviewed by Eric Carlson.
1343
1344         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
1345         Ideally, we should not reference NSApp in WebCore.
1346
1347         * WebView/WebFullScreenController.mm:
1348         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
1349         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
1350         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
1351         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
1352         * WebView/WebView.mm:
1353         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
1354         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
1355
1356 2018-01-13  Darin Adler  <darin@apple.com>
1357
1358         Event improvements
1359         https://bugs.webkit.org/show_bug.cgi?id=179591
1360
1361         Reviewed by Chris Dumez.
1362
1363         * DOM/DOMWheelEvent.mm:
1364         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
1365         Call initWebKitWheelEvent.
1366
1367         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
1368         * WebCoreSupport/WebInspectorClient.mm: Ditto.
1369         * WebView/WebFrame.mm: Ditto.
1370
1371         * WebView/WebHTMLView.mm:
1372         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
1373         underlyingPlatformEvent.
1374         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
1375
1376         * WebView/WebScriptWorld.mm:
1377         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
1378
1379         * WebView/WebView.mm: Removed include of ScriptValue.h.
1380
1381 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1382
1383         Remove WebCore/ForwardingHeaders directory
1384         https://bugs.webkit.org/show_bug.cgi?id=182347
1385
1386         Reviewed by Keith Miller.
1387
1388         * Carbon/CarbonWindowAdapter.mm:
1389         * DOM/WebDOMOperations.mm:
1390         * History/WebBackForwardList.mm:
1391         * History/WebHistoryItem.mm:
1392         * Misc/WebCache.mm:
1393         * Misc/WebElementDictionary.mm:
1394         * Misc/WebIconDatabase.mm:
1395         * Misc/WebStringTruncator.mm:
1396         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1397         * Plugins/Hosted/ProxyInstance.mm:
1398         * Plugins/Hosted/ProxyRuntimeObject.mm:
1399         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1400         * Plugins/WebBaseNetscapePluginView.mm:
1401         * Plugins/WebBasePluginPackage.mm:
1402         * Plugins/WebNetscapePluginStream.mm:
1403         * Plugins/WebNetscapePluginView.mm:
1404         * Plugins/WebPluginController.mm:
1405         * WebCoreSupport/WebEditorClient.mm:
1406         * WebCoreSupport/WebFrameLoaderClient.mm:
1407         * WebCoreSupport/WebInspectorClient.h:
1408         * WebCoreSupport/WebInspectorClient.mm:
1409         * WebView/WebDataSource.mm:
1410         * WebView/WebFrame.mm:
1411         * WebView/WebHTMLRepresentation.mm:
1412         * WebView/WebHTMLView.mm:
1413         * WebView/WebPreferences.mm:
1414         * WebView/WebScriptDebugDelegate.mm:
1415         * WebView/WebScriptDebugger.h:
1416         * WebView/WebTextIterator.mm:
1417         * WebView/WebView.mm:
1418         * WebView/WebViewData.mm:
1419
1420 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1421
1422         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1423         https://bugs.webkit.org/show_bug.cgi?id=182312
1424
1425         Reviewed by Michael Catanzaro.
1426
1427         * WebKitPrefix.h:
1428
1429 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1430
1431         [WebAuthN] Add a compile-time feature flag
1432         https://bugs.webkit.org/show_bug.cgi?id=182211
1433         <rdar://problem/36936365>
1434
1435         Reviewed by Brent Fulgham.
1436
1437         * Configurations/FeatureDefines.xcconfig:
1438
1439 2018-01-27  Dan Bernstein  <mitz@apple.com>
1440
1441         HaveInternalSDK includes should be "#include?"
1442         https://bugs.webkit.org/show_bug.cgi?id=179670
1443
1444         * Configurations/Base.xcconfig:
1445
1446 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1447
1448         Remove unused QTKit preference
1449         https://bugs.webkit.org/show_bug.cgi?id=181968
1450
1451         Reviewed by Alexey Proskuryakov.
1452
1453         * WebView/WebPreferenceKeysPrivate.h:
1454         * WebView/WebPreferences.mm:
1455         (+[WebPreferences initialize]):
1456         (-[WebPreferences setQTKitEnabled:]): Deleted.
1457         (-[WebPreferences isQTKitEnabled]): Deleted.
1458         * WebView/WebPreferencesPrivate.h:
1459         * WebView/WebView.mm:
1460         (-[WebView _preferencesChanged:]):
1461
1462 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1463
1464         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
1465         https://bugs.webkit.org/show_bug.cgi?id=182037
1466         <rdar://problem/36747812>
1467
1468         Reviewed by Ryosuke Niwa.
1469
1470         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
1471         for more details.
1472
1473         * WebView/WebHTMLRepresentation.mm:
1474         (-[WebHTMLRepresentation elementWithName:inForm:]):
1475         (-[WebHTMLRepresentation controlsInForm:]):
1476
1477 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1478
1479         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
1480         https://bugs.webkit.org/show_bug.cgi?id=181961
1481
1482         Reviewed by Michael Catanzaro.
1483
1484         * WebView/WebPreferences.mm:
1485
1486 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1487
1488         Unreviewed, rolling out r227437.
1489         https://bugs.webkit.org/show_bug.cgi?id=182011
1490
1491         broke build (Requested by alexchristensen on #webkit).
1492
1493         Reverted changeset:
1494
1495         "Remove unused QTKit preference"
1496         https://bugs.webkit.org/show_bug.cgi?id=181968
1497         https://trac.webkit.org/changeset/227437
1498
1499 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1500
1501         Remove unused QTKit preference
1502         https://bugs.webkit.org/show_bug.cgi?id=181968
1503
1504         Reviewed by Alexey Proskuryakov.
1505
1506         * WebView/WebPreferenceKeysPrivate.h:
1507         * WebView/WebPreferences.mm:
1508         (+[WebPreferences initialize]):
1509         (-[WebPreferences setQTKitEnabled:]): Deleted.
1510         (-[WebPreferences isQTKitEnabled]): Deleted.
1511         * WebView/WebPreferencesPrivate.h:
1512         * WebView/WebView.mm:
1513         (-[WebView _preferencesChanged:]):
1514
1515 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1516
1517         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
1518         https://bugs.webkit.org/show_bug.cgi?id=181960
1519         <rdar://problem/36431678>
1520
1521         Reviewed by Tim Horton.
1522
1523         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1524         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1525         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1526
1527         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1528         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1529         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1530
1531         * WebView/WebView.mm:
1532         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1533
1534 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1535
1536         Turning off custom pasteboard data doesn't actually turn it off in WK2
1537         https://bugs.webkit.org/show_bug.cgi?id=181920
1538         <rdar://problem/36686429>
1539
1540         Reviewed by Wenson Hsieh.
1541
1542         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1543
1544         * WebView/WebPreferences.mm:
1545         (+[WebPreferences initialize]):
1546         * WebView/WebView.mm:
1547         (-[WebView _preferencesChanged:]):
1548
1549 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1550
1551         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1552         https://bugs.webkit.org/show_bug.cgi?id=181918
1553
1554         Reviewed by Tim Horton.
1555
1556         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1557
1558         * Configurations/FeatureDefines.xcconfig:
1559
1560 2018-01-20  Andy Estes  <aestes@apple.com>
1561
1562         [Apple Pay] Stop eagerly loading PassKit.framework
1563         https://bugs.webkit.org/show_bug.cgi?id=181911
1564         <rdar://problem/36555369>
1565
1566         Reviewed by Tim Horton.
1567
1568         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1569         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1570         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1571
1572         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1573
1574 2018-01-19  Dean Jackson  <dino@apple.com>
1575
1576         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1577         https://bugs.webkit.org/show_bug.cgi?id=181817
1578         <rdar://problem/35274055>
1579
1580         Reviewed by Simon Fraser.
1581
1582         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1583
1584         * Misc/WebKitVersionChecks.h:
1585         * WebView/WebView.mm:
1586         (-[WebView _commonInitializationWithFrameName:groupName:]):
1587
1588 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1589
1590         Remove unused WebViewPrivate _allowCookies
1591         https://bugs.webkit.org/show_bug.cgi?id=181812
1592
1593         Reviewed by Tim Horton.
1594
1595         * WebView/WebView.mm:
1596         (+[WebView _setAllowCookies:]): Deleted.
1597         (+[WebView _allowCookies]): Deleted.
1598         * WebView/WebViewPrivate.h:
1599
1600 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1601
1602         Build fix, remove a call to -[NSWindow setOneShot:]
1603         https://bugs.webkit.org/show_bug.cgi?id=181809
1604
1605         Reviewed by Tim Horton.
1606
1607         * WebView/WebTextCompletionController.mm:
1608         (-[WebTextCompletionController _buildUI]):
1609
1610 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1611
1612         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1613
1614         * Carbon/HIWebView.mm:
1615         (overrideCGContext):
1616         (restoreCGContext):
1617
1618 2018-01-18  Dan Bernstein  <mitz@apple.com>
1619
1620         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1621         https://bugs.webkit.org/show_bug.cgi?id=181803
1622
1623         Reviewed by Tim Horton.
1624
1625         * Configurations/Base.xcconfig: Updated.
1626         * Configurations/DebugRelease.xcconfig: Ditto.
1627         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1628         * Configurations/Version.xcconfig: Updated.
1629         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1630           useful for defining settings that depend on the target macOS version.
1631
1632 2018-01-17  Youenn Fablet  <youenn@apple.com>
1633
1634         Put fetch Request.keepalive behind a runtime flag
1635         https://bugs.webkit.org/show_bug.cgi?id=181592
1636
1637         Reviewed by Chris Dumez.
1638
1639         * WebView/WebPreferenceKeysPrivate.h:
1640         * WebView/WebPreferences.mm:
1641         (+[WebPreferences initialize]):
1642         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1643         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1644         * WebView/WebPreferencesPrivate.h:
1645         * WebView/WebView.mm:
1646         (-[WebView _preferencesChanged:]):
1647
1648 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1649
1650         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1651         https://bugs.webkit.org/show_bug.cgi?id=181637
1652         <rdar://problem/36508471>
1653
1654         Reviewed by Tim Horton.
1655
1656         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1657
1658         * WebCoreSupport/WebEditorClient.h:
1659         * WebCoreSupport/WebEditorClient.mm:
1660         (WebEditorClient::replacementURLForResource):
1661
1662 2018-01-11  Keith Miller  <keith_miller@apple.com>
1663
1664         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1665         https://bugs.webkit.org/show_bug.cgi?id=181573
1666
1667         Reviewed by Simon Fraser.
1668
1669         * Configurations/FeatureDefines.xcconfig:
1670
1671 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1672
1673         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1674         https://bugs.webkit.org/show_bug.cgi?id=181497
1675
1676         Reviewed by Tim Horton.
1677
1678         See other ChangeLogs for more detail.
1679
1680         * WebCoreSupport/WebDragClient.h:
1681
1682 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1683
1684         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1685         https://bugs.webkit.org/show_bug.cgi?id=181523
1686         <rdar://problem/28959131>
1687
1688         Reviewed by Alex Christensen.
1689
1690         * WebView/WebImmediateActionController.mm:
1691         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1692         Apply the change made in r216652 to WebKit1's immediate action controller.
1693
1694         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1695         the startContainer of the range is in an anonymous node.
1696
1697 2018-01-11  Youenn Fablet  <youenn@apple.com>
1698
1699         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1700         https://bugs.webkit.org/show_bug.cgi?id=181480
1701
1702         Reviewed by Eric Carlson.
1703
1704         * WebView/WebPreferences.mm:
1705         (+[WebPreferences initialize]):
1706
1707 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1708
1709         Fix check-webkit-style issues with WebNSDataExtras.mm
1710         <https://webkit.org/b/181369>
1711
1712         Reviewed by Alex Christensen.
1713
1714         * Misc/WebNSDataExtras.mm:
1715         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1716         (-[NSData _webkit_guessedMIMETypeForXML]):
1717         (-[NSData _webkit_guessedMIMEType]):
1718         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1719         (_findEOL):
1720         (-[NSData _webkit_parseRFC822HeaderFields]):
1721         (-[NSData _web_locationAfterFirstBlankLine]):
1722         - Fix all the check-webkit-style warnings.
1723
1724 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1725
1726         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1727         <https://webkit.org/b/181256>
1728         <rdar://problem/36281730>
1729
1730         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1731         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1732         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1733           to avoid warnings from casting CFStringRef to NPNSString*.
1734           Note that CFMutableStringRef is the same as CFStringRef
1735           without the const modifier, hence its use in the const_cast<>
1736           above.
1737
1738 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1739
1740         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1741         <https://webkit.org/b/181256>
1742         <rdar://problem/36281730>
1743
1744         * Carbon/HIWebView.mm:
1745         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1746         checked_cf_cast<CFRunLoopRef>() to fix warning.
1747
1748 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1749
1750         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1751         <https://webkit.org/b/181256>
1752         <rdar://problem/36281730>
1753
1754         Reviewed by Darin Adler.
1755
1756         * Carbon/CarbonUtils.m:
1757         (PoolCleaner):
1758         - Use #pragmas to ignore -Wcast-qual warnings when using a
1759           C-style cast from CFTypeRef to CFRunloopRef.
1760         * Carbon/CarbonWindowFrame.m:
1761         (-[CarbonWindowFrame title]):
1762         - Use #pragmas to ignore -Wcast-qual warnings when using a
1763           C-style cast from CFStringRef to NSString *.
1764         * Carbon/HIViewAdapter.m:
1765         (+[HIViewAdapter getHIViewForNSView:]):
1766         - Use #pragmas to ignore -Wcast-qual warnings when using a
1767           C-style cast from CFTypeRef to HIViewRef.
1768         * Configurations/Base.xcconfig:
1769         (WARNING_CFLAGS): Add -Wcast-qual.
1770         * Misc/WebElementDictionary.mm:
1771         (-[WebElementDictionary objectForKey:]):
1772         - Use static_cast<SEL>(const_cast<void*>()) to fix
1773           warning.
1774         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1775         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1776         (-[NSData _webkit_guessedMIMETypeForXML]):
1777         (-[NSData _webkit_guessedMIMEType]):
1778         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1779         (_findEOL):
1780         (-[NSData _webkit_parseRFC822HeaderFields]):
1781         (-[NSData _web_startsWithBlankLine]):
1782         (-[NSData _web_locationAfterFirstBlankLine]):
1783         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1784           type to Objective-C++.  This fixes the warnings about
1785           discarding the `const` modifier when casing from CFStringRef
1786           to NSString * because in older clang versions, -Wcast-qual was
1787           completely broken when compiling C++ and Objective-C++ source
1788           files.  In newer clang versions, discarding the `const`
1789           modifier for toll-free bridged types is ignored when compiling
1790           Objective-C++ source.
1791         - Update copyright and license header.
1792         - Use reinterpret_cast<> and static_cast<> to fix warnings
1793           unrelated to (NSString *) C-style casts.
1794         - Replace use of MIN() macro with std::min<> template functions.
1795         - Fix location of `*` for local variables modified above.
1796         * Plugins/Hosted/NetscapePluginHostManager.mm:
1797         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1798         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1799         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1800         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1801           warnings.
1802         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1803         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1804         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1805           to fix warning.
1806         * Plugins/Hosted/ProxyInstance.mm:
1807         (WebKit::ProxyInstance::invoke):
1808         - Use static_cast<char*>(const_cast<void*>()) to fix
1809           warning when using -[NSData bytes].
1810         (WebKit::ProxyInstance::fieldValue const):
1811         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1812           to fix warning when using CFDataGetBytePtr().
1813         * Plugins/Hosted/WebTextInputWindowController.m:
1814         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1815         - Use #pragma to ignore -Wcast-qual warning since there
1816           is not a good way to avoid this warning in Objective-C.
1817         * Plugins/WebNetscapePluginStream.mm:
1818         (WebNetscapePluginStream::deliverData):
1819         - Use const_cast<void*>() to fix warning when using
1820           -[NSData bytes].
1821         * Plugins/WebNetscapePluginView.mm:
1822         (-[WebNetscapePluginView _createPlugin]):
1823         - Change C-style cast to const_cast<char*>() to fix
1824           warning.
1825         * WebCoreSupport/WebChromeClient.mm:
1826         (WebChromeClient::wrapCryptoKey const):
1827         (WebChromeClient::unwrapCryptoKey const):
1828         - Change C-style cast to
1829           static_cast<uint8_t*>(const_cast<void*>() to fix
1830           warning.
1831         * WebView/WebPDFView.mm:
1832         (_applicationInfoForMIMEType):
1833         - Change local variable type from 'NSURL *' to
1834           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1835           when calling -[NSURL path].
1836
1837 2018-01-05  Dan Bernstein  <mitz@apple.com>
1838
1839         Fixed the build following AppKit API deprecations in a recent SDKs
1840
1841         * WebView/WebFullScreenController.mm:
1842         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1843         (-[WebFullScreenController exitFullScreen]): Ditto.
1844         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1845         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1846         * WebView/WebHTMLView.mm:
1847         (-[WebHTMLView drawRect:]): Ditto.
1848         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1849         (-[WebHTMLView knowsPageRange:]): Ditto.
1850         * WebView/WebView.mm:
1851         (LayerFlushController::flushLayers): Ditto.
1852
1853 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1854
1855         [Attachment Support] Create attachment elements when dropping files on iOS
1856         https://bugs.webkit.org/show_bug.cgi?id=181192
1857         <rdar://problem/36280945>
1858
1859         Reviewed by Tim Horton.
1860
1861         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1862
1863         * WebCoreSupport/WebPlatformStrategies.h:
1864         * WebCoreSupport/WebPlatformStrategies.mm:
1865         (WebPlatformStrategies::informationForItemAtIndex):
1866         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1867
1868 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1869
1870         [Attachment Support] Add plumbing for starting a drag with promised blob data
1871         https://bugs.webkit.org/show_bug.cgi?id=181201
1872
1873         Reviewed by Tim Horton.
1874
1875         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1876
1877         * WebCoreSupport/WebDragClient.h:
1878
1879 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1880
1881         Add a WebAuthentication runtime feature flag
1882         https://bugs.webkit.org/show_bug.cgi?id=181220
1883         <rdar://problem/36055305>
1884
1885         Reviewed by Brent Fulgham.
1886
1887         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1888
1889         * WebView/WebPreferenceKeysPrivate.h:
1890         * WebView/WebPreferences.mm:
1891         (+[WebPreferences initialize]):
1892         (-[WebPreferences webAuthenticationEnabled]):
1893         (-[WebPreferences setWebAuthenticationEnabled:]):
1894         (-[WebPreferences credentialManagementEnabled]): Deleted.
1895         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1896         * WebView/WebPreferencesPrivate.h:
1897         * WebView/WebView.mm:
1898         (-[WebView _preferencesChanged:]):
1899
1900 2017-12-22  Jeff Miller  <jeffm@apple.com>
1901
1902         Update user-visible copyright strings to include 2018
1903         https://bugs.webkit.org/show_bug.cgi?id=181141
1904
1905         Reviewed by Dan Bernstein.
1906
1907         * Info.plist:
1908
1909 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1910
1911         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1912         https://bugs.webkit.org/show_bug.cgi?id=181188
1913
1914         Reviewed by Dan Bernstein.
1915
1916         See WebCore/ChangeLog for more detail.
1917
1918         * WebCoreSupport/WebDragClient.h:
1919         * WebCoreSupport/WebDragClient.mm:
1920         (WebDragClient::declareAndWriteAttachment): Deleted.
1921         * WebView/WebHTMLView.mm:
1922         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1923
1924 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1925
1926         Unreviewed, continue to fix build failures due to AppKit API deprecation
1927
1928         Wraps more code in -Wdeprecated-declarations.
1929
1930         * Carbon/HIWebView.mm:
1931         (overrideCGContext):
1932
1933 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1934
1935         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1936
1937         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1938
1939         * Carbon/CarbonWindowAdapter.mm:
1940         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1941         * Plugins/WebNetscapePluginView.mm:
1942         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1943         (-[WebNetscapePluginView sendDrawRectEvent:]):
1944         (-[WebNetscapePluginView drawRect:]):
1945
1946 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1947
1948         Fix build failures due to using deprecated AppKit symbols
1949         https://bugs.webkit.org/show_bug.cgi?id=181110
1950         <rdar://problem/36162865>
1951
1952         Reviewed by Dan Bernstein and Tim Horton.
1953
1954         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1955
1956         * Misc/WebKitNSStringExtras.mm:
1957         (-[NSString _web_drawAtPoint:font:textColor:]):
1958         * Misc/WebNSPasteboardExtras.h:
1959         * Misc/WebNSPasteboardExtras.mm:
1960         (+[NSPasteboard _web_writableTypesForURL]):
1961         (_createWritableTypesForImageWithoutArchive):
1962         (_createWritableTypesForImageWithArchive):
1963         (+[NSPasteboard _web_dragTypesForURL]):
1964         (-[NSPasteboard _web_bestURL]):
1965         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1966         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1967         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1968         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1969         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1970         * Panels/WebAuthenticationPanel.m:
1971         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1972         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1973         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1974         (-[WebHostedNetscapePluginView drawRect:]):
1975         * WebInspector/WebNodeHighlightView.mm:
1976         (-[WebNodeHighlightView drawRect:]):
1977         * WebView/WebFrame.mm:
1978         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1979         (-[WebFrame _drawRect:contentsOnly:]):
1980         * WebView/WebHTMLView.mm:
1981         (kit):
1982         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1983         (-[WebHTMLView _plainTextFromPasteboard:]):
1984         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1985         (+[WebHTMLView _insertablePasteboardTypes]):
1986         (+[WebHTMLView _selectionPasteboardTypes]):
1987         (-[WebHTMLView pasteboard:provideDataForType:]):
1988         (-[WebHTMLView _writeSelectionToPasteboard:]):
1989         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1990         (-[WebHTMLView validRequestorForSendType:returnType:]):
1991         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1992         (createMenuItem):
1993         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1994         (-[WebHTMLView _colorAsString:]):
1995         (-[WebHTMLView copyFont:]):
1996         * WebView/WebPDFView.mm:
1997         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1998         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1999         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2000         (-[WebPDFView pasteboardTypesForSelection]):
2001         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
2002         * WebView/WebView.h:
2003         * WebView/WebView.mm:
2004         (-[WebView performDragOperation:]):
2005         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
2006         (-[WebView _searchWithGoogleFromMenu:]):
2007
2008 2017-12-21  Youenn Fablet  <youenn@apple.com>
2009
2010         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
2011         https://bugs.webkit.org/show_bug.cgi?id=181000
2012
2013         Reviewed by Chris Dumez.
2014
2015         * Misc/WebCache.mm:
2016         (+[WebCache addImageToCache:forURL:forFrame:]):
2017
2018 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2019
2020         Update FULLSCREEN_API feature defines.
2021         https://bugs.webkit.org/show_bug.cgi?id=181015
2022
2023         Reviewed by Tim Horton.
2024
2025         Change enabled iphone sdk for FULLSCREEN_API.
2026
2027         * Configurations/FeatureDefines.xcconfig:
2028
2029 2017-12-21  Jer Noble  <jer.noble@apple.com>
2030
2031         Add initial DOM support for Media Capabilities
2032         https://bugs.webkit.org/show_bug.cgi?id=181064
2033
2034         Reviewed by Eric Carlson.
2035
2036         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
2037
2038         * WebView/WebPreferenceKeysPrivate.h:
2039         * WebView/WebPreferences.mm:
2040         (+[WebPreferences initialize]):
2041         (-[WebPreferences mediaCapabilitiesEnabled]):
2042         (-[WebPreferences setMediaCapabilitiesEnabled:]):
2043         * WebView/WebPreferencesPrivate.h:
2044         * WebView/WebView.mm:
2045         (-[WebView _preferencesChanged:]):
2046
2047 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2048
2049         Enable picture-in-picture from inline element on suspend.
2050         https://bugs.webkit.org/show_bug.cgi?id=180942
2051         rdar://problem/34745234
2052
2053         Reviewed by Jer Noble.
2054
2055         Update signature of enterVideoFullscreenForVideoElement().
2056
2057         * WebCoreSupport/WebChromeClient.h:
2058         * WebCoreSupport/WebChromeClient.mm:
2059         (WebChromeClient::enterVideoFullscreenForVideoElement):
2060
2061 2017-12-20  Daniel Bates  <dabates@apple.com>
2062
2063         Remove Alternative Presentation Button
2064         https://bugs.webkit.org/show_bug.cgi?id=180500
2065         <rdar://problem/35891047>
2066
2067         Reviewed by Simon Fraser.
2068
2069         We no longer need the alternative presentation button.
2070
2071         * Configurations/FeatureDefines.xcconfig:
2072
2073 2017-12-19  Jer Noble  <jer.noble@apple.com>
2074
2075         Playing media elements which call "pause(); play()" will have the play promise rejected.
2076         https://bugs.webkit.org/show_bug.cgi?id=180781
2077         <rdar://problem/33191377>
2078
2079         Reviewed by Eric Carlson.
2080
2081         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
2082
2083         * WebView/WebView.mm:
2084         (shouldRequireUserGestureToLoadVideo):
2085
2086 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2087
2088         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
2089         https://bugs.webkit.org/show_bug.cgi?id=180977
2090
2091         Reviewed by Tim Horton.
2092
2093         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
2094         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
2095         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
2096
2097         * WebCoreSupport/WebEditorClient.mm:
2098         (attributesForAttributedStringConversion):
2099         * WebView/WebHTMLView.mm:
2100         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
2101
2102 2017-12-18  David Kilzer  <ddkilzer@apple.com>
2103
2104         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
2105
2106         Attempt to fix the following warnings:
2107
2108             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
2109
2110         For the following instance variables:
2111
2112             _borderView
2113             _contentView
2114             _frame
2115             _wFlags
2116
2117         * Carbon/CarbonWindowAdapter.mm:
2118         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2119         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2120         (-[CarbonWindowAdapter _termWindowIfOwner]):
2121         (-[CarbonWindowAdapter _windowMovedToRect:]):
2122         (-[CarbonWindowAdapter setContentView:]):
2123         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2124         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2125
2126 2017-12-16  Dan Bernstein  <mitz@apple.com>
2127
2128         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
2129         https://bugs.webkit.org/show_bug.cgi?id=180613
2130         <rdar://problem/35946124>
2131
2132         Reviewed by Geoff Garen.
2133
2134         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
2135           clients.
2136         * WebView/WebDynamicScrollBarsView.h: Ditto.
2137         * WebView/WebDynamicScrollBarsView.mm: Ditto.
2138
2139 2017-12-14  David Kilzer  <ddkilzer@apple.com>
2140
2141         Enable -Wstrict-prototypes for WebKit
2142         <https://webkit.org/b/180757>
2143         <rdar://problem/36024132>
2144
2145         Rubber-stamped by Joseph Pecoraro.
2146
2147         * Configurations/Base.xcconfig:
2148         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
2149
2150 2017-12-14  John Wilander  <wilander@apple.com>
2151
2152         Storage Access API: Implement frame-specific access in the document.cookie layer
2153         https://bugs.webkit.org/show_bug.cgi?id=180682
2154         <rdar://problem/35982257>
2155
2156         Reviewed by Alex Christensen.
2157
2158         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2159         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2160         CookiesStrategy::getRawCookies() now take optional parameters for
2161         frameID and pageID to allow frame-specific scoping of cookies.
2162
2163         This change makes the return values of FrameLoaderClient::frameID()
2164         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2165         WebCore can call those getters and get the right return values in
2166         WebKit and std:nullopt in WebKitLegacy.
2167
2168         * WebCoreSupport/WebFrameLoaderClient.h:
2169         * WebCoreSupport/WebFrameLoaderClient.mm:
2170         (WebFrameLoaderClient::pageID const):
2171         (WebFrameLoaderClient::frameID const):
2172         * WebCoreSupport/WebPlatformStrategies.h:
2173         * WebCoreSupport/WebPlatformStrategies.mm:
2174         (WebPlatformStrategies::cookiesForDOM):
2175         (WebPlatformStrategies::setCookiesFromDOM):
2176         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2177         (WebPlatformStrategies::getRawCookies):
2178
2179 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
2180
2181         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
2182         https://bugs.webkit.org/show_bug.cgi?id=180689
2183
2184         Reviewed by Tim Horton.
2185
2186         Use sRGBColorSpaceRef() from WebCore.
2187
2188         * WebView/WebHTMLView.mm:
2189         (imageFromRect):
2190
2191 2017-12-11  Tim Horton  <timothy_horton@apple.com>
2192
2193         Stop using deprecated target conditional for simulator builds
2194         https://bugs.webkit.org/show_bug.cgi?id=180662
2195         <rdar://problem/35136156>
2196
2197         Reviewed by Simon Fraser.
2198
2199         * postprocess-headers.sh:
2200
2201 2017-12-11  David Quesada  <david_quesada@apple.com>
2202
2203         Turn on ENABLE_APPLICATION_MANIFEST
2204         https://bugs.webkit.org/show_bug.cgi?id=180562
2205         rdar://problem/35924737
2206
2207         Reviewed by Geoffrey Garen.
2208
2209         * Configurations/FeatureDefines.xcconfig:
2210
2211 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2212
2213         Remove pthread_once in favor of dispatch_once
2214         https://bugs.webkit.org/show_bug.cgi?id=180591
2215
2216         Reviewed by Saam Barati.
2217
2218         * Misc/WebKitErrors.m:
2219         (+[NSError _registerWebKitErrors]):
2220         (registerErrors): Deleted.
2221         * Storage/WebStorageManager.mm:
2222         (+[WebStorageManager _storageDirectoryPath]):
2223         (initializeLocalStoragePath): Deleted.
2224
2225 2017-12-07  Darin Adler  <darin@apple.com>
2226
2227         Remove some unused code from WebKitLegacy
2228         https://bugs.webkit.org/show_bug.cgi?id=180567
2229
2230         Reviewed by Anders Carlsson.
2231
2232         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
2233         macOS (back a few versions) and iOS and removed unused
2234         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
2235         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
2236         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
2237         _webkit_stringByCollapsingNonPrintingCharacters,
2238         _webkit_stringByCollapsingWhitespaceCharacters,
2239         _web_stringWithData:textEncodingName:, and
2240         _webkit_localStorageDirectoryWithBundleIdentifier:.
2241
2242         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
2243         this source file.
2244         (canUseFastRenderer): Made this faster by not calling u_charDirection for
2245         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
2246         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
2247         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
2248         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
2249         handle font smoothing options.
2250         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
2251         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
2252         from header and made it a little clearer.
2253         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
2254         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
2255         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
2256         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
2257         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
2258         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
2259         implementation a bit and used whole words instead of abbreviations.
2260         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
2261
2262         * Misc/WebNSFileManagerExtras.mm:
2263         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
2264         filenameByFixingIllegalCharacters function from WebCore directly instead of
2265         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
2266
2267         * Plugins/WebBaseNetscapePluginView.mm:
2268         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
2269         string replacements instead of _web_stringByStrippingReturnCharacters
2270         and to use NSString methods instead of CFString functions.
2271
2272 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
2273
2274         Ignore deprecation warnings.
2275
2276         * WebView/WebHTMLView.mm:
2277         (-[NSWindow _web_borderView]):
2278         (-[WebHTMLView _setAsideSubviews]):
2279         * WebView/WebView.mm:
2280         (-[WebView encodeWithCoder:]):
2281
2282 2017-12-02  Darin Adler  <darin@apple.com>
2283
2284         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
2285         https://bugs.webkit.org/show_bug.cgi?id=180009
2286
2287         Reviewed by Alex Christensen.
2288
2289         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
2290
2291         * Plugins/WebBaseNetscapePluginView.mm:
2292         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
2293         of strcasecmp.
2294
2295         * WebView/WebPreferences.mm:
2296         (contains): Ditto. Also made this a template so it's easier to call on an array.
2297         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
2298
2299 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
2300
2301         Limit user agent versioning to an upper bound
2302         https://bugs.webkit.org/show_bug.cgi?id=180365
2303         <rdar://problem/34550617>
2304
2305         Reviewed by Joseph Pecoraro.
2306
2307         * WebView/WebView.mm:
2308         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
2309         creating the User Agent string.
2310         (webKitBundleVersionString): Deleted.
2311
2312 2017-12-05  Andy Estes  <aestes@apple.com>
2313
2314         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
2315         https://bugs.webkit.org/show_bug.cgi?id=180457
2316         <rdar://problem/35143007>
2317
2318         Reviewed by Tim Horton.
2319
2320         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
2321         check for this macro during post-processing.
2322
2323         * postprocess-headers.sh:
2324
2325 2017-12-04  David Quesada  <david_quesada@apple.com>
2326
2327         Add a class for parsing application manifests
2328         https://bugs.webkit.org/show_bug.cgi?id=177973
2329         rdar://problem/34747949
2330
2331         Reviewed by Geoffrey Garen.
2332
2333         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
2334
2335 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
2336
2337         Make LegacyCustomProtocolManager optional for network process
2338         https://bugs.webkit.org/show_bug.cgi?id=176230
2339
2340         Reviewed by Alex Christensen.
2341
2342         * Configurations/FeatureDefines.xcconfig:
2343
2344 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
2345
2346         Fix some NSOperationQueue leaks
2347         https://bugs.webkit.org/show_bug.cgi?id=180221
2348
2349         Reviewed by Wenson Hsieh.
2350
2351         * WebView/WebView.mm:
2352         (-[WebView performDragOperation:]):
2353
2354 2017-11-30  Darin Adler  <darin@apple.com>
2355
2356         [Mac] remove unneeded RetainPtr use introduced in r225142
2357         https://bugs.webkit.org/show_bug.cgi?id=180202
2358
2359         Reviewed by Tim Horton.
2360
2361         * WebView/WebImmediateActionController.mm:
2362         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
2363         RetainPtr.
2364
2365 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
2366
2367         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
2368         https://bugs.webkit.org/show_bug.cgi?id=175595
2369
2370         Reviewed by Darin Adler.
2371
2372         * WebView/WebPreferences.mm:
2373
2374 2017-11-27  Tim Horton  <timothy_horton@apple.com>
2375
2376         One too many zeroes in macOS version number in FeatureDefines
2377         https://bugs.webkit.org/show_bug.cgi?id=180011
2378
2379         Reviewed by Dan Bernstein.
2380
2381         * Configurations/FeatureDefines.xcconfig:
2382
2383 2017-11-23  Darin Adler  <darin@apple.com>
2384
2385         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2386         https://bugs.webkit.org/show_bug.cgi?id=179981
2387
2388         Reviewed by Sam Weinig.
2389
2390         * WebView/WebImmediateActionController.mm:
2391         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
2392         * WebView/WebView.mm:
2393         (coreOptions): Use |= instead of | to build up FindOptions.
2394
2395 2017-11-23  Sam Weinig  <sam@webkit.org>
2396
2397         Remove unneeded ScriptController::processingUserGesture() forwarding functions
2398         https://bugs.webkit.org/show_bug.cgi?id=179954
2399
2400         Reviewed by Darin Adler.
2401
2402         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
2403         with direct calls to the corresponding UserGestureIndicator functions.
2404
2405         * Plugins/WebPluginController.mm:
2406         (-[WebPluginController processingUserGesture]):
2407         * WebView/WebView.mm:
2408         (-[WebView _isProcessingUserGesture]):
2409
2410 2017-11-23  Darin Adler  <darin@apple.com>
2411
2412         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2413         https://bugs.webkit.org/show_bug.cgi?id=179907
2414
2415         Reviewed by Sam Weinig.
2416
2417         * History/BinaryPropertyList.cpp:
2418         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
2419         (BinaryPropertyListSerializer::appendStringObject): Ditto.
2420         * WebView/WebHTMLRepresentation.mm:
2421         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
2422         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
2423
2424 2017-11-22  Ali Juma  <ajuma@chromium.org>
2425
2426         Implement VisualViewport API attributes
2427         https://bugs.webkit.org/show_bug.cgi?id=179385
2428
2429         Reviewed by Frédéric Wang.
2430
2431         Add a VisualViewportAPI preference.
2432
2433         * WebView/WebPreferenceKeysPrivate.h:
2434         * WebView/WebPreferences.mm:
2435         (+[WebPreferences initialize]):
2436         (-[WebPreferences visualViewportAPIEnabled]):
2437         (-[WebPreferences setVisualViewportAPIEnabled:]):
2438         * WebView/WebPreferencesPrivate.h:
2439         * WebView/WebView.mm:
2440         (-[WebView _preferencesChanged:]):
2441
2442 2017-11-22  Christopher Reid  <chris.reid@sony.com>
2443
2444         WebCoreObjCExtras.h is being included in too many places
2445         https://bugs.webkit.org/show_bug.cgi?id=179931
2446
2447         Reviewed by Darin Adler.
2448
2449         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2450         * Plugins/WebBaseNetscapePluginView.mm:
2451         * Plugins/WebBasePluginPackage.mm:
2452         * Plugins/WebNetscapePluginStream.mm:
2453         * Plugins/WebNetscapePluginView.mm:
2454         * WebView/WebTextIterator.mm:
2455         * WebView/WebViewData.mm:
2456
2457 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2458
2459         Unreviewed, rolling out r225093.
2460         https://bugs.webkit.org/show_bug.cgi?id=179938
2461
2462         Compilation failed on WinCairo 64-bit Release (Requested by
2463         fredw on #webkit).
2464
2465         Reverted changeset:
2466
2467         "Implement VisualViewport API attributes"
2468         https://bugs.webkit.org/show_bug.cgi?id=179385
2469         https://trac.webkit.org/changeset/225093
2470
2471 2017-11-21  Ali Juma  <ajuma@chromium.org>
2472
2473         Implement VisualViewport API attributes
2474         https://bugs.webkit.org/show_bug.cgi?id=179385
2475
2476         Reviewed by Frédéric Wang.
2477
2478         Add a VisualViewportAPI preference.
2479
2480         * WebView/WebPreferenceKeysPrivate.h:
2481         * WebView/WebPreferences.mm:
2482         (+[WebPreferences initialize]):
2483         (-[WebPreferences visualViewportAPIEnabled]):
2484         (-[WebPreferences setVisualViewportAPIEnabled:]):
2485         * WebView/WebPreferencesPrivate.h:
2486         * WebView/WebView.mm:
2487         (-[WebView _preferencesChanged:]):
2488
2489 2017-11-21  Christopher Reid  <chris.reid@sony.com>
2490
2491         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
2492         https://bugs.webkit.org/show_bug.cgi?id=179504
2493
2494         Reviewed by Darin Adler.
2495
2496         * Misc/WebKitNSStringExtras.mm:
2497         * Plugins/Hosted/NetscapePluginHostManager.mm:
2498         * Plugins/WebBasePluginPackage.mm:
2499
2500 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2501
2502         Remove unused TOUCH_ICON_LOADING feature flag
2503         https://bugs.webkit.org/show_bug.cgi?id=179873
2504
2505         Reviewed by Simon Fraser.
2506
2507         * Configurations/FeatureDefines.xcconfig:
2508
2509 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2510
2511         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2512         https://bugs.webkit.org/show_bug.cgi?id=179872
2513
2514         Reviewed by Darin Adler.
2515
2516         * Configurations/FeatureDefines.xcconfig:
2517
2518 2017-11-16  Daniel Bates  <dabates@apple.com>
2519
2520         Add feature define for alternative presentation button element
2521         https://bugs.webkit.org/show_bug.cgi?id=179692
2522         Part of <rdar://problem/34917108>
2523
2524         Reviewed by Andy Estes.
2525
2526         Only enabled on Cocoa platforms by default.
2527
2528         * Configurations/FeatureDefines.xcconfig:
2529
2530 2017-11-14  Nan Wang  <n_wang@apple.com>
2531
2532         AX: AOM: Implement AccessibleNode class and support label and role attributes
2533         https://bugs.webkit.org/show_bug.cgi?id=179494
2534
2535         Reviewed by Ryosuke Niwa.
2536
2537         * WebView/WebPreferenceKeysPrivate.h:
2538         * WebView/WebPreferences.mm:
2539         (+[WebPreferences initialize]):
2540         (-[WebPreferences accessibilityObjectModelEnabled]):
2541         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2542         * WebView/WebPreferencesPrivate.h:
2543         * WebView/WebView.mm:
2544         (-[WebView _preferencesChanged:]):
2545
2546 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2547
2548         Remove Cocoa CFURLConnection loading code
2549         https://bugs.webkit.org/show_bug.cgi?id=179688
2550
2551         Reviewed by Antti Koivisto.
2552
2553         * Misc/WebDownload.mm:
2554         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2555         * Misc/WebDownloadInternal.h:
2556         * Plugins/WebBaseNetscapePluginView.mm:
2557         * WebCoreSupport/WebFrameLoaderClient.mm:
2558         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2559         * WebView/WebView.mm:
2560         (-[WebView scheduleInRunLoop:forMode:]):
2561         (-[WebView unscheduleFromRunLoop:forMode:]):
2562
2563 2017-11-14  Daniel Bates  <dabates@apple.com>
2564
2565         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2566         for feature defines
2567
2568         Following r195498 and r201917 the Visual Studio property files for feature defines have
2569         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2570         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2571         files.
2572
2573         * Configurations/FeatureDefines.xcconfig:
2574
2575 2017-11-14  Jer Noble  <jer.noble@apple.com>
2576
2577         Enable Modern EME tests in DumpRenderTree
2578         https://bugs.webkit.org/show_bug.cgi?id=179544
2579
2580         Reviewed by Alex Christensen.
2581
2582         Add a WebPreferences property to enable the (modern) EME API.
2583
2584         * WebView/WebPreferenceKeysPrivate.h:
2585         * WebView/WebPreferences.mm:
2586         (+[WebPreferences initialize]):
2587         (-[WebPreferences encryptedMediaAPIEnabled]):
2588         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2589         * WebView/WebPreferencesPrivate.h:
2590         * WebView/WebView.mm:
2591         (-[WebView _preferencesChanged:]):
2592
2593 2017-11-14  Antti Koivisto  <antti@apple.com>
2594
2595         Enable display:contents by default
2596         https://bugs.webkit.org/show_bug.cgi?id=179655
2597
2598         Reviewed by Sam Weinig.
2599
2600         * WebView/WebPreferences.mm:
2601         (+[WebPreferences initialize]):
2602
2603 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2604
2605         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2606         https://bugs.webkit.org/show_bug.cgi?id=178751
2607
2608         Reviewed by Brady Eidson.
2609
2610         * WebCoreSupport/WebFrameNetworkingContext.mm:
2611         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2612
2613 2017-11-08  Keith Miller  <keith_miller@apple.com>
2614
2615         Async iteration should only fetch the next method once and add feature flag
2616         https://bugs.webkit.org/show_bug.cgi?id=179451
2617
2618         Reviewed by Geoffrey Garen.
2619
2620         Add feature flag for Async iteration.
2621
2622         * Configurations/FeatureDefines.xcconfig:
2623
2624 2017-11-13  Mark Lam  <mark.lam@apple.com>
2625
2626         Add more overflow check book-keeping for MarkedArgumentBuffer.
2627         https://bugs.webkit.org/show_bug.cgi?id=179634
2628         <rdar://problem/35492517>
2629
2630         Reviewed by Saam Barati.
2631
2632         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2633         (WebKit::NetscapePluginInstanceProxy::invoke):
2634         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2635         (WebKit::NetscapePluginInstanceProxy::construct):
2636
2637 2017-11-12  Darin Adler  <darin@apple.com>
2638
2639         More is<> and downcast<>, less static_cast<>
2640         https://bugs.webkit.org/show_bug.cgi?id=179600
2641
2642         Reviewed by Chris Dumez.
2643
2644         * DOM/DOM.mm:
2645         (kit): Use is/downcast.
2646         * WebCoreSupport/WebEditorClient.mm:
2647         (WebEditorClient::handleKeyboardEvent): Ditto.
2648         (WebEditorClient::handleInputMethodKeydown): Ditto.
2649         * WebView/WebHTMLView.mm:
2650         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2651
2652 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2653
2654         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2655         https://bugs.webkit.org/show_bug.cgi?id=179397
2656
2657         Reviewed by Wenson Hsieh.
2658
2659         * DOM/DOMHTMLInputElement.mm:
2660         (-[DOMHTMLInputElement insertTextSuggestion:]):
2661
2662 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2663
2664         HTMLMediaElement should not use element fullscreen on iOS
2665         https://bugs.webkit.org/show_bug.cgi?id=179418
2666         rdar://problem/35409277
2667
2668         Reviewed by Eric Carlson.
2669
2670         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2671
2672         * Configurations/FeatureDefines.xcconfig:
2673
2674 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2675
2676         Make ResourceLoader::willSendRequestInternal asynchronous
2677         https://bugs.webkit.org/show_bug.cgi?id=179251
2678
2679         Reviewed by Andy Estes.
2680
2681         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2682         (WebKit::HostedNetscapePluginStream::start):
2683         * Plugins/WebNetscapePluginStream.mm:
2684         (WebNetscapePluginStream::start):
2685
2686 2017-11-01  Darin Adler  <darin@apple.com>
2687
2688         Simplify event dispatch code and make it a bit more consistent
2689         https://bugs.webkit.org/show_bug.cgi?id=178991
2690
2691         Reviewed by Chris Dumez.
2692
2693         * DOM/DOMEvent.mm:
2694         (-[DOMEvent srcElement]): Call target instead of srcElement.
2695
2696 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2697
2698         [Touch Bar Web API] Add support for menuitem tag
2699         https://bugs.webkit.org/show_bug.cgi?id=179020
2700
2701         Reviewed by Ryosuke Niwa.
2702
2703         Adds in properties and methods that allow the menuitem runtime feature
2704         to be enabled or disabled.
2705
2706         * WebView/WebPreferenceKeysPrivate.h:
2707         * WebView/WebPreferences.mm:
2708         (-[WebPreferences menuItemElementEnabled]):
2709         (-[WebPreferences setMenuItemElementEnabled:]):
2710         * WebView/WebPreferencesPrivate.h:
2711         * WebView/WebView.mm:
2712         (-[WebView _preferencesChanged:]):
2713
2714 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2715
2716         Use CompletionHandlers for redirects
2717         https://bugs.webkit.org/show_bug.cgi?id=179163
2718
2719         Reviewed by Tim Horton.
2720
2721         * Plugins/Hosted/HostedNetscapePluginStream.h:
2722         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2723         (WebKit::HostedNetscapePluginStream::willSendRequest):
2724         * Plugins/WebNetscapePluginStream.h:
2725         * Plugins/WebNetscapePluginStream.mm:
2726         (WebNetscapePluginStream::willSendRequest):
2727
2728 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2729
2730         Add a FileSystem namespace to FileSystem.cpp
2731         https://bugs.webkit.org/show_bug.cgi?id=179063
2732
2733         Reviewed by Darin Adler.
2734
2735         * Misc/WebNSFileManagerExtras.mm:
2736         * Storage/WebDatabaseProvider.mm:
2737
2738 2017-11-02  Frederic Wang  <fwang@igalia.com>
2739
2740         Add references to bug 179167 in FIXME comments
2741         https://bugs.webkit.org/show_bug.cgi?id=179168
2742
2743         Reviewed by Daniel Bates.
2744
2745         * Configurations/FeatureDefines.xcconfig:
2746
2747 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2748
2749         Implement WKFullscreenWindowController for iOS.
2750         https://bugs.webkit.org/show_bug.cgi?id=178924
2751         rdar://problem/34697120
2752
2753         Reviewed by Simon Fraser.
2754
2755         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2756
2757         * Configurations/FeatureDefines.xcconfig:
2758         * WebView/WebView.mm:
2759         (-[WebView fullScreenPlaceholderView]):
2760
2761 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2762
2763         Clean up some drag and drop feature flags
2764         https://bugs.webkit.org/show_bug.cgi?id=179082
2765
2766         Reviewed by Simon Fraser.
2767
2768         * Configurations/FeatureDefines.xcconfig:
2769
2770 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2771
2772         Make it possible to test rubber-banding in overflow scroll
2773         https://bugs.webkit.org/show_bug.cgi?id=179078
2774
2775         Reviewed by Sam Weinig.
2776
2777         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2778         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2779
2780         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2781         functions, since most callers want clamped.
2782
2783         * DOM/DOMHTML.mm:
2784         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2785
2786 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2787
2788         Fix up some content filtering feature flags
2789         https://bugs.webkit.org/show_bug.cgi?id=179079
2790
2791         Reviewed by Simon Fraser.
2792
2793         * Configurations/FeatureDefines.xcconfig:
2794
2795 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2796
2797         [FrameView::layout cleanup] Move core layout logic to a separate class.
2798         https://bugs.webkit.org/show_bug.cgi?id=178771
2799         <rdar://problem/35166542>
2800
2801         Reviewed by Simon Fraser.
2802
2803         Move layout code out from FrameView to LayoutContext.
2804
2805         * WebView/WebClipView.mm:
2806         (-[WebClipView _immediateScrollToPoint:]):
2807         * WebView/WebFrame.mm:
2808         (-[WebFrame layoutCount]):
2809
2810 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2811
2812         Fix issues with WebView subframe painting
2813         https://bugs.webkit.org/show_bug.cgi?id=178842
2814         rdar://problem/34072253
2815
2816         Reviewed by Daniel Bates.
2817         
2818         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2819         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2820         High Sierra, so match the new signature.
2821
2822         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2823
2824         * WebView/WebHTMLView.mm:
2825         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2826         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2827
2828 2017-10-25  Youenn Fablet  <youenn@apple.com>
2829
2830         Enable ServiceWorker to fetch resources
2831         https://bugs.webkit.org/show_bug.cgi?id=178673
2832
2833         Reviewed by Brady Eidson.
2834
2835         * WebCoreSupport/WebFrameLoaderClient.mm:
2836         (WebFrameLoaderClient::pageID const):
2837         (WebFrameLoaderClient::frameID const):
2838         (WebFrameLoaderClient::sessionID const):
2839
2840         Added implementation to the new getters.
2841         They are noop in the context of WK1.
2842
2843 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2844
2845         Web Inspector: Enable WebKit logging configuration and display
2846         https://bugs.webkit.org/show_bug.cgi?id=177027
2847         <rdar://problem/33964767>
2848
2849         Reviewed by Joseph Pecoraro.
2850
2851         * WebCoreSupport/WebChromeClient.mm:
2852         (stringForMessageSource): Deal with Media and WebRTC message sources.
2853
2854 2017-10-20  Antoine Quint  <graouts@apple.com>
2855
2856         [Web Animations] Provide basic timeline and animation interfaces
2857         https://bugs.webkit.org/show_bug.cgi?id=178526
2858
2859         Reviewed by Dean Jackson.
2860
2861         Remove the WEB_ANIMATIONS compile-time flag.
2862
2863         * Configurations/FeatureDefines.xcconfig:
2864         * WebView/WebPreferences.mm:
2865         (+[WebPreferences initialize]):
2866         * WebView/WebView.mm:
2867         (-[WebView _preferencesChanged:]):
2868
2869 2017-10-19  Sam Weinig  <sam@webkit.org>
2870
2871         [Settings] Move global settings into their own file
2872         https://bugs.webkit.org/show_bug.cgi?id=178512
2873
2874         Reviewed by Darin Adler.
2875
2876         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2877
2878         * WebCoreSupport/WebChromeClient.mm:
2879         (WebChromeClient::supportsVideoFullscreen):
2880         * WebView/WebDynamicScrollBarsView.mm:
2881         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2882         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2883         * WebView/WebPreferences.mm:
2884         (+[WebPreferences initialize]):
2885         * WebView/WebView.mm:
2886         (-[WebView _commonInitializationWithFrameName:groupName:]):
2887         (-[WebView _preferencesChanged:]):
2888         (+[WebView _doNotStartObservingNetworkReachability]):
2889
2890 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2891
2892         Replace some stack raw pointers with RefPtrs within WebCore/html
2893         https://bugs.webkit.org/show_bug.cgi?id=178201
2894         <rdar://problem/34841692>
2895
2896         Reviewed by Ryosuke Niwa.
2897
2898         * DOM/DOM.mm:
2899         (kit):
2900         Change the type of node as toNode() is changed to return RefPtr.
2901
2902 2017-10-18  Chris Dumez  <cdumez@apple.com>
2903
2904         [Service Worker] Add stubs for Client / WindowClient / Clients
2905         https://bugs.webkit.org/show_bug.cgi?id=178469
2906
2907         Reviewed by Youenn Fablet.
2908
2909         Rename PageVisiblityState to VisibilityState.
2910
2911         * WebView/WebView.mm:
2912         (kit):
2913
2914 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2915
2916         Unreviewed, rolling out r223291.
2917
2918         See WebCore ChangeLog for more detail.
2919
2920         Reverted changeset:
2921
2922         "Remove Editor::simplifyMarkup"
2923         https://bugs.webkit.org/show_bug.cgi?id=178271
2924         https://trac.webkit.org/changeset/223291
2925
2926 2017-10-17  Keith Miller  <keith_miller@apple.com>
2927
2928         Change WebCore sources to work with unified source builds
2929         https://bugs.webkit.org/show_bug.cgi?id=178229
2930
2931         Rubber stamped by Tim Horton.
2932
2933         * Configurations/FeatureDefines.xcconfig:
2934
2935 2017-10-16  Sam Weinig  <sam@webkit.org>
2936
2937         [Settings] Remove all custom code from Settings.h/cpp
2938         https://bugs.webkit.org/show_bug.cgi?id=178330
2939
2940         Reviewed by Simon Fraser.
2941
2942         * WebView/WebPreferences.mm:
2943         (+[WebPreferences initialize]):
2944         
2945             Update for naming changes of FrameFlattening now that it is an enum class.
2946
2947 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2948
2949         Remove Editor::simplifyMarkup
2950         https://bugs.webkit.org/show_bug.cgi?id=178271
2951
2952         Reviewed by Wenson Hsieh.
2953
2954         * WebView/WebView.mm:
2955         (-[WebView _simplifyMarkup:endNode:]):
2956
2957 2017-10-12  Chris Dumez  <cdumez@apple.com>
2958
2959         [Mac] Add support for MouseEvent.buttons
2960         https://bugs.webkit.org/show_bug.cgi?id=178214
2961
2962         Reviewed by Ryosuke Niwa.
2963
2964         * WebView/WebPDFView.mm:
2965         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2966
2967 2017-10-11  Sam Weinig  <sam@webkit.org>
2968
2969         Remove out-parameter variants of copyToVector
2970         https://bugs.webkit.org/show_bug.cgi?id=178155
2971
2972         Reviewed by Tim Horton.
2973
2974         * Plugins/WebNetscapePluginView.mm:
2975         (-[WebNetscapePluginView destroyPlugin]):
2976         * WebView/WebHTMLRepresentation.mm:
2977         (newArrayWithStrings):
2978
2979             Replace out-parameter based copyToVector, with one that returns a Vector.
2980
2981 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2982
2983         Sanitize URL in pasteboard for other applications and cross origin content
2984         https://bugs.webkit.org/show_bug.cgi?id=178060
2985         <rdar://problem/34874518>
2986
2987         Reviewed by Wenson Hsieh.
2988
2989         * WebCoreSupport/WebPlatformStrategies.h:
2990         * WebCoreSupport/WebPlatformStrategies.mm:
2991         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2992
2993 2017-10-11  Chris Dumez  <cdumez@apple.com>
2994
2995         Modernize Geolocation code
2996         https://bugs.webkit.org/show_bug.cgi?id=178148
2997
2998         Reviewed by Ryosuke Niwa.
2999
3000         * WebCoreSupport/WebGeolocationClient.h:
3001         * WebCoreSupport/WebGeolocationClient.mm:
3002         (WebGeolocationClient::lastPosition):
3003         * WebView/WebGeolocationPosition.mm:
3004         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
3005         (core):
3006         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
3007         (-[WebGeolocationPosition initWithGeolocationPosition:]):
3008         * WebView/WebGeolocationPositionInternal.h:
3009
3010 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
3011
3012         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
3013         https://bugs.webkit.org/show_bug.cgi?id=178154
3014
3015         Reviewed by Wenson Hsieh.
3016
3017         Enable custom pasteboard data by default.
3018
3019         * WebView/WebPreferenceKeysPrivate.h:
3020         * WebView/WebPreferences.mm:
3021         (+[WebPreferences initialize]):
3022         (-[WebPreferences customPasteboardDataEnabled]): Added.
3023         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
3024         * WebView/WebPreferencesPrivate.h:
3025         * WebView/WebView.mm:
3026         (-[WebView _preferencesChanged:]):
3027
3028 2017-10-10  Sam Weinig  <sam@webkit.org>
3029
3030         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
3031         https://bugs.webkit.org/show_bug.cgi?id=178102
3032
3033         Reviewed by Tim Horton.
3034
3035         * History/WebHistory.mm:
3036         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
3037         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3038         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
3039         * WebCoreSupport/WebUserMediaClient.mm:
3040         (WebUserMediaClient::pageDestroyed):
3041
3042 2017-10-09  Robin Morisset  <rmorisset@apple.com>
3043
3044         Make the names of the options consistent
3045         https://bugs.webkit.org/show_bug.cgi?id=177933
3046
3047         Reviewed by Saam Barati.
3048
3049         * WebView/WebFrame.h:
3050         * WebView/WebHTMLView.mm:
3051         (-[WebHTMLView setMarkedText:selectedRange:]):
3052         * WebView/WebView.h:
3053
3054 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3055
3056         [iOS] Tweak support for classifying form controls (followup to r222487)
3057         https://bugs.webkit.org/show_bug.cgi?id=177917
3058         <rdar://problem/34820122>
3059
3060         Reviewed by Dean Jackson.
3061
3062         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
3063
3064         * DOM/DOMHTMLInputElement.mm:
3065         (-[DOMHTMLInputElement _autofillContext]):
3066         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
3067         (-[DOMHTMLInputElement representingPageURL]): Deleted.
3068
3069 2017-10-05  Keith Miller  <keith_miller@apple.com>
3070
3071         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
3072
3073         * Configurations/WebKitLegacy.xcconfig:
3074
3075 2017-10-05  Jer Noble  <jer.noble@apple.com>
3076
3077         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
3078         https://bugs.webkit.org/show_bug.cgi?id=177261
3079
3080         Reviewed by Eric Carlson.
3081
3082         * Configurations/FeatureDefines.xcconfig:
3083
3084 2017-10-05  Chris Dumez  <cdumez@apple.com>
3085
3086         Drop unused parameters for CookiesStrategy::cookiesEnabled()
3087         https://bugs.webkit.org/show_bug.cgi?id=177957
3088
3089         Reviewed by Alex Christensen.
3090
3091         * WebCoreSupport/WebPlatformStrategies.h:
3092         * WebCoreSupport/WebPlatformStrategies.mm:
3093         (WebPlatformStrategies::cookiesEnabled):
3094
3095 2017-10-05  Youenn Fablet  <youenn@apple.com>
3096
3097         Make LibWebRTCProvider port agnostic
3098         https://bugs.webkit.org/show_bug.cgi?id=177747
3099
3100         Reviewed by Alex Christensen & Alex Garcia.
3101
3102         * WebView/WebView.mm:
3103         (-[WebView _commonInitializationWithFrameName:groupName:]):
3104         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3105
3106 2017-10-04  Alex Christensen  <achristensen@webkit.org>
3107
3108         Stop linking with WebKitSystemInterface
3109         https://bugs.webkit.org/show_bug.cgi?id=177915
3110
3111         Reviewed by Antti Koivisto.
3112
3113         * Configurations/DebugRelease.xcconfig:
3114         * Configurations/WebKitLegacy.xcconfig:
3115
3116 2017-10-04  Alex Christensen  <achristensen@webkit.org>
3117
3118         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
3119         https://bugs.webkit.org/show_bug.cgi?id=177912
3120
3121         Reviewed by Saam Barati.
3122
3123         * Carbon/CarbonUtils.m:
3124         * Carbon/CarbonWindowAdapter.mm:
3125         * Carbon/HIWebView.mm:
3126         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3127         * Misc/WebNSFileManagerExtras.mm:
3128         * Misc/WebNSPasteboardExtras.mm:
3129         * Misc/WebNSURLExtras.mm:
3130         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3131         * Plugins/Hosted/NetscapePluginHostManager.mm:
3132         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3133         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3134         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3135         * Plugins/Hosted/WebTextInputWindowController.m:
3136         * Plugins/WebBaseNetscapePluginView.mm:
3137         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3138         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3139         * Plugins/WebNetscapePluginStream.mm:
3140         * Plugins/WebNetscapePluginView.mm:
3141         * Plugins/WebPluginDatabase.mm:
3142         * WebCoreSupport/PopupMenuMac.mm:
3143         * WebCoreSupport/WebChromeClient.mm:
3144         * WebCoreSupport/WebFrameLoaderClient.mm:
3145         * WebCoreSupport/WebInspectorClient.mm:
3146         * WebCoreSupport/WebPlatformStrategies.mm:
3147         * WebCoreSupport/WebSystemInterface.mm:
3148         * WebView/WebDynamicScrollBarsView.mm:
3149         * WebView/WebFrame.mm:
3150         * WebView/WebFrameView.mm:
3151         * WebView/WebFullScreenController.mm:
3152         * WebView/WebHTMLView.mm:
3153         * WebView/WebPreferences.mm:
3154         * WebView/WebView.mm:
3155
3156 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
3157
3158         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
3159         rdar://problem/34705779
3160
3161         Addressing review comments that I somehow landed without.
3162
3163         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
3164
3165 2017-09-29  Chris Dumez  <cdumez@apple.com>
3166
3167         Split some logic out of VisitedLinkStore and make it reusable
3168         https://bugs.webkit.org/show_bug.cgi?id=177575
3169
3170         Reviewed by Alex Christensen.
3171
3172         * WebCoreSupport/WebVisitedLinkStore.h:
3173         * WebCoreSupport/WebVisitedLinkStore.mm:
3174         (WebVisitedLinkStore::addVisitedLink):
3175         (WebVisitedLinkStore::removeVisitedLink):
3176         (WebVisitedLinkStore::isLinkVisited):
3177         (WebVisitedLinkStore::addVisitedLinkHash):
3178
3179 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
3180
3181         Build fix for High Sierra 32 bit Mac
3182         https://bugs.webkit.org/show_bug.cgi?id=177551
3183         <rdar://problem/34690283>
3184
3185         Reviewed by Alexey Proskuryakov.
3186
3187         Some assertions have been removed from the SDK. Replace these assertions with equivalent
3188         WTF assert code.  Since the files in this patch are using tabs, some style changes were
3189         also made.
3190
3191         * Carbon/CarbonWindowAdapter.mm:
3192         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3193         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
3194         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3195         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3196         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
3197         (-[CarbonWindowAdapter dealloc]):
3198         (-[CarbonWindowAdapter windowRef]):
3199         (-[CarbonWindowAdapter _hasWindowRef]):
3200         (-[CarbonWindowAdapter _managesWindowRef]):
3201         (-[CarbonWindowAdapter _removeWindowRef]):
3202         (-[CarbonWindowAdapter _carbonWindowClass]):
3203         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3204         (-[CarbonWindowAdapter sendSuperEvent:]):
3205         (-[CarbonWindowAdapter relinquishFocus]):
3206         (-[CarbonWindowAdapter _cancelKey:]):
3207         (-[CarbonWindowAdapter _commonAwake]):
3208         (-[CarbonWindowAdapter _destroyRealWindow:]):
3209         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3210         (-[CarbonWindowAdapter _termWindowIfOwner]):
3211         (-[CarbonWindowAdapter _windowMovedToRect:]):
3212         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
3213         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
3214         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
3215         (-[CarbonWindowAdapter canBecomeKeyWindow]):
3216         (-[CarbonWindowAdapter canBecomeMainWindow]):
3217         (-[CarbonWindowAdapter encodeWithCoder:]):
3218         (-[CarbonWindowAdapter initWithCoder:]):
3219         (-[CarbonWindowAdapter setContentView:]):
3220         (-[CarbonWindowAdapter worksWhenModal]):
3221         (-[CarbonWindowAdapter _setModalWindowLevel]):
3222         (-[CarbonWindowAdapter _clearModalWindowLevel]):
3223         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
3224         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
3225         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
3226         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3227         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3228         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
3229         (NSCarbonWindowHandleEvent):
3230         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
3231         (-[CarbonWindowAdapter _growBoxRect]):
3232         * Carbon/HIWebView.mm:
3233         (HIWebViewGetWebView):
3234         (HIWebViewConstructor):
3235         (HIWebViewDestructor):
3236         (HIWebViewRegisterClass):
3237         (GetBehaviors):
3238         (Draw):
3239         (HitTest):
3240         (GetRegion):
3241         (GetWindowRef):
3242         (CreateNSEventAdoptingCGEvent):
3243         (CopyEventCGEvent):
3244         (CreateNSEventWithCarbonClickEvent):
3245         (Click):
3246         (CreateNSEventWithCarbonEvent):
3247         (MouseUp):
3248         (CreateNSEventWithCarbonMouseMoveEvent):
3249         (MouseMoved):
3250         (MouseDragged):
3251         (MouseWheelMoved):
3252         (ContextMenuClick):
3253         (GetKind):
3254         (BoundsChanged):
3255         (OwningWindowChanged):
3256         (WindowHandler):
3257         (SyncFrame):
3258         (SetFocusPart):
3259         (AdvanceFocus):
3260         (RelinquishFocus):
3261         (ActiveStateChanged):
3262         (ProcessCommand):
3263         (UpdateCommandStatus):
3264         (_NSSelectorForHICommand):
3265         (HIWebViewEventHandler):
3266         (StartUpdateObserver):
3267         (StopUpdateObserver):
3268         (UpdateObserver):
3269
3270 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3271
3272         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
3273         https://bugs.webkit.org/show_bug.cgi?id=172526
3274         <rdar://problem/32396081>
3275
3276         Reviewed by Ryosuke Niwa.
3277
3278         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
3279
3280         * WebCoreSupport/WebPlatformStrategies.h:
3281         * WebCoreSupport/WebPlatformStrategies.mm:
3282         (WebPlatformStrategies::webExposedTypes):
3283         (WebPlatformStrategies::writeCustomData):
3284
3285 2017-09-27  Matt Lewis  <jlewis3@apple.com>
3286
3287         Unreviewed, rolling out r222567.
3288
3289         This broke and internal build.
3290
3291         Reverted changeset:
3292
3293         "Build fix for High Sierra 32 bit Mac"
3294         https://bugs.webkit.org/show_bug.cgi?id=177551
3295         http://trac.webkit.org/changeset/222567
3296
3297 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
3298
3299         Build fix for High Sierra 32 bit Mac
3300         https://bugs.webkit.org/show_bug.cgi?id=177551
3301         <rdar://problem/34690283>
3302
3303         Reviewed by Alexey Proskuryakov.
3304
3305         Some assertions have been removed from the SDK. Replace these assertions with equivalent
3306         WTF assert code.  Since the files in this patch are using tabs, some style changes were
3307         also made.
3308
3309         * Carbon/CarbonWindowAdapter.mm:
3310         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3311         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
3312         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3313         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3314         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
3315         (-[CarbonWindowAdapter dealloc]):
3316         (-[CarbonWindowAdapter windowRef]):
3317         (-[CarbonWindowAdapter _hasWindowRef]):
3318         (-[CarbonWindowAdapter _managesWindowRef]):
3319         (-[CarbonWindowAdapter _removeWindowRef]):
3320         (-[CarbonWindowAdapter _carbonWindowClass]):
3321         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3322         (-[CarbonWindowAdapter sendSuperEvent:]):
3323         (-[CarbonWindowAdapter relinquishFocus]):
3324         (-[CarbonWindowAdapter _cancelKey:]):
3325         (-[CarbonWindowAdapter _commonAwake]):
3326         (-[CarbonWindowAdapter _destroyRealWindow:]):
3327         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3328         (-[CarbonWindowAdapter _termWindowIfOwner]):
3329         (-[CarbonWindowAdapter _windowMovedToRect:]):
3330         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
3331         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
3332         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
3333         (-[CarbonWindowAdapter canBecomeKeyWindow]):
3334         (-[CarbonWindowAdapter canBecomeMainWindow]):
3335         (-[CarbonWindowAdapter encodeWithCoder:]):
3336         (-[CarbonWindowAdapter initWithCoder:]):
3337         (-[CarbonWindowAdapter setContentView:]):
3338         (-[CarbonWindowAdapter worksWhenModal]):
3339         (-[CarbonWindowAdapter _setModalWindowLevel]):
3340         (-[CarbonWindowAdapter _clearModalWindowLevel]):
3341         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
3342         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
3343         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
3344         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3345         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3346         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
3347         (NSCarbonWindowHandleEvent):
3348         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
3349         (-[CarbonWindowAdapter _growBoxRect]):
3350         * Carbon/HIWebView.mm:
3351         (HIWebViewGetWebView):
3352         (HIWebViewConstructor):
3353         (HIWebViewDestructor):
3354         (HIWebViewRegisterClass):
3355         (GetBehaviors):
3356         (Draw):
3357         (HitTest):
3358         (GetRegion):
3359         (GetWindowRef):
3360         (CreateNSEventAdoptingCGEvent):
3361         (CopyEventCGEvent):
3362         (CreateNSEventWithCarbonClickEvent):
3363         (Click):
3364         (CreateNSEventWithCarbonEvent):
3365         (MouseUp):
3366         (CreateNSEventWithCarbonMouseMoveEvent):
3367         (MouseMoved):
3368         (MouseDragged):
3369         (MouseWheelMoved):
3370         (ContextMenuClick):
3371         (GetKind):
3372         (BoundsChanged):
3373         (OwningWindowChanged):
3374         (WindowHandler):
3375         (SyncFrame):
3376         (SetFocusPart):
3377         (AdvanceFocus):
3378         (RelinquishFocus):
3379         (ActiveStateChanged):
3380         (ProcessCommand):
3381         (UpdateCommandStatus):
3382         (_NSSelectorForHICommand):
3383         (HIWebViewEventHandler):
3384         (StartUpdateObserver):
3385         (StopUpdateObserver):
3386         (UpdateObserver):
3387
3388 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3389
3390         Make PolicyAction an encodable enum class
3391         https://bugs.webkit.org/show_bug.cgi?id=177480
3392
3393         Reviewed by Antti Koivisto.
3394
3395         * Plugins/WebPluginContainerCheck.mm:
3396         (-[WebPluginContainerCheck _continueWithPolicy:]):
3397         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3398         * WebCoreSupport/WebFrameLoaderClient.mm:
3399         (-[WebFramePolicyListener invalidate]):
3400         (-[WebFramePolicyListener ignore]):
3401         (-[WebFramePolicyListener download]):
3402         (-[WebFramePolicyListener use]):
3403         (-[WebFramePolicyListener continue]):
3404         * WebView/WebPolicyDelegate.mm:
3405         (-[WebPolicyDecisionListener use]):
3406         (-[WebPolicyDecisionListener ignore]):
3407         (-[WebPolicyDecisionListener download]):
3408
3409 2017-09-25  Frederik Riedel  <riedel@apple.com>
3410
3411         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
3412         https://bugs.webkit.org/show_bug.cgi?id=174394
3413         <rdar://problem/33183504>
3414
3415         Reviewed by Ryosuke Niwa.
3416
3417         * DOM/DOMHTMLInputElement.h:
3418         * DOM/DOMHTMLInputElement.mm:
3419         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
3420         Determines if this HTMLInputElement is part of a login screen.
3421         (-[DOMHTMLInputElement representingPageUrl]):
3422         Returns the webpage's URL that is currently displayed in the Web View.
3423         (-[DOMHTMLInputElement insertTextSuggestion:]):
3424         Inserts login credentials into the Web View.
3425
3426 2017-09-25  Sam Weinig  <sam@webkit.org>
3427
3428         Remove unused EditorClient functions
3429         https://bugs.webkit.org/show_bug.cgi?id=177463
3430
3431         Reviewed by Alex Christensen.
3432
3433         Remove unused EditorClient functions.
3434
3435         * WebCoreSupport/WebEditorClient.h:
3436         * WebCoreSupport/WebEditorClient.mm:
3437         (WebEditorClient::canonicalizeURL): Deleted.
3438         (WebEditorClient::canonicalizeURLString): Deleted.
3439         (WebEditorClient::writeDataToPasteboard): Deleted.
3440         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
3441         (WebEditorClient::readDataFromPasteboard): Deleted.
3442         (WebEditorClient::pasteboardChangeCount): Deleted.
3443
3444 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3445
3446         Stop using PolicyCallback
3447         https://bugs.webkit.org/show_bug.cgi?id=176088
3448
3449         Reviewed by Andy Estes.
3450
3451         * WebCoreSupport/WebFrameLoaderClient.mm:
3452         (-[WebFramePolicyListener invalidate]):
3453         (-[WebFramePolicyListener receivedPolicyDecision:]):
3454
3455 2017-09-25  Sam Weinig  <sam@webkit.org>
3456
3457         Remove unnecessary userVisibleString EditorClient function
3458         https://bugs.webkit.org/show_bug.cgi?id=177456
3459
3460         Reviewed by Dan Bernstein.
3461
3462         * WebCoreSupport/WebEditorClient.h:
3463         * WebCoreSupport/WebEditorClient.mm:
3464         (WebEditorClient::userVisibleString): Deleted.
3465
3466             Remove userVisibleString client function.
3467
3468 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3469
3470         Separate form submission from PolicyChecker infrastructure
3471         https://bugs.webkit.org/show_bug.cgi?id=177396
3472
3473         Reviewed by Geoffrey Garen.
3474
3475         * WebCoreSupport/WebFrameLoaderClient.h:
3476         * WebCoreSupport/WebFrameLoaderClient.mm:
3477         (WebFrameLoaderClient::dispatchWillSubmitForm):
3478
3479 2017-09-22  Zalan Bujtas  <zalan@apple.com>
3480
3481         WeakPtrFactory should populate m_ref lazily.
3482         https://bugs.webkit.org/show_bug.cgi?id=177375
3483
3484         Reviewed by Geoffrey Garen.
3485
3486         * WebCoreSupport/WebEditorClient.mm:
3487         (WebEditorClient::WebEditorClient):
3488         (WebEditorClient::requestCandidatesForSelection):
3489
3490 2017-09-22  Chris Dumez  <cdumez@apple.com>
3491
3492         Use high resolution timestamp for event time
3493         https://bugs.webkit.org/show_bug.cgi?id=154246
3494         <rdar://problem/34333304>
3495
3496         Reviewed by Ryosuke Niwa.
3497
3498         Use WallTime / MonotonicTime instead of double type for clarity.
3499
3500         * DOM/DOMEvent.mm:
3501         (-[DOMEvent timeStamp]):
3502         * WebView/WebFrame.mm:
3503         (-[WebFrame _dragSourceEndedAt:operation:]):
3504         * WebView/WebPDFView.mm: