Use Optional::valueOr() instead of Optional::value_or()
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-12-20  Chris Dumez  <cdumez@apple.com>
2
3         Use Optional::valueOr() instead of Optional::value_or()
4         https://bugs.webkit.org/show_bug.cgi?id=192933
5
6         Reviewed by Geoffrey Garen.
7
8         * WebCoreSupport/WebSecurityOrigin.mm:
9         (-[WebSecurityOrigin port]):
10
11 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
12
13         Unreviewed, rolling out r239417.
14
15         Introduced two API test failures on macOS.
16
17         Reverted changeset:
18
19         "<rdar://problem/46194315> macOS: WebKit1 does not handle
20         occlusion changes"
21         https://bugs.webkit.org/show_bug.cgi?id=192821
22         https://trac.webkit.org/changeset/239417
23
24 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
25
26         WKWebView default UA doesn't freeze the build number
27         https://bugs.webkit.org/show_bug.cgi?id=192809
28         <rdar://problem/44687185>
29
30         Reviewed by Andy Estes.
31
32         Always reports the frozen build number.
33
34         * WebView/WebView.mm:
35         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
36         actual build number through this method call.
37         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
38
39 2018-12-19  Chris Dumez  <cdumez@apple.com>
40
41         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
42         https://bugs.webkit.org/show_bug.cgi?id=192728
43         <rdar://problem/46746779>
44
45         Reviewed by Geoff Garen.
46
47         * DOM/*:
48         * Plugins/*:
49         * WebCoreSupport/*:
50         * WebView/*:
51
52 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
53
54         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
55         https://bugs.webkit.org/show_bug.cgi?id=192821
56
57         Reviewed by Chris Dumez.
58
59         When a window becomes occluded, the window server informs the application.
60         This should be used to suspend any work that is not visible by the user.
61
62         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
63         In some cases, that lead to performance impact (see radar).
64
65         This patch adds an observer for the occlusion notification. I tried to stick
66         with the same names used by WebKit2.
67
68         * WebView/WebView.mm:
69         (-[WebView _isViewVisible]):
70         (-[WebView addWindowObserversForWindow:]):
71         (-[WebView removeWindowObservers]):
72         (-[WebView _windowDidChangeOcclusionState:]):
73
74 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
75
76         Allow clients to set the navigator platform
77         https://bugs.webkit.org/show_bug.cgi?id=192735
78
79         Reviewed by Tim Horton.
80
81         Add stubs to fill out the added functionality in FrameLoaderClient.
82
83         * WebCoreSupport/WebFrameLoaderClient.h:
84         * WebCoreSupport/WebFrameLoaderClient.mm:
85         (WebFrameLoaderClient::navigatorPlatform):
86
87 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
88
89         offsetLeft and offsetParent should adjust across shadow boundaries
90         https://bugs.webkit.org/show_bug.cgi?id=157437
91         <rdar://problem/26154021>
92
93         Reviewed by Simon Fraser.
94
95         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
96
97         * DOM/DOMElement.mm:
98         (-[DOMElement offsetLeft]):
99         (-[DOMElement offsetTop]):
100         (-[DOMElement offsetParent]):
101
102 2018-12-17  Zalan Bujtas  <zalan@apple.com>
103
104         Unreviewed build fix.
105
106         * WebView/WebFrame.mm:
107         (-[WebFrame getDictationResultRanges:andMetadatas:]):
108
109 2018-12-15  Darin Adler  <darin@apple.com>
110
111         Use warning-ignoring macros more consistently and simply
112         https://bugs.webkit.org/show_bug.cgi?id=192743
113
114         Reviewed by Mark Lam.
115
116         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
117         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
118         compilers in Objective-C++ code.
119
120         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
121         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
122         accomodate non-clang compilers here. Also use #pragma once, add a missing
123         "explicit" and fix conditionals.
124
125 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
126
127         Make TextInputController.legacyAttributedString take DOM nodes and offsets
128         https://bugs.webkit.org/show_bug.cgi?id=192653
129
130         Reviewed by Wenson Hsieh.
131
132         * WebView/WebHTMLView.mm:
133         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
134
135 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
136
137         Implement feature flag for CSS Typed OM
138         https://bugs.webkit.org/show_bug.cgi?id=192610
139
140         Reviewed by Ryosuke Niwa.
141
142         * Configurations/FeatureDefines.xcconfig:
143
144 2018-12-11  Tim Horton  <timothy_horton@apple.com>
145
146         WebCore shouldn't have a Objective-C class named NSCursor
147         https://bugs.webkit.org/show_bug.cgi?id=192602
148         <rdar://problem/46615532>
149
150         Reviewed by Wenson Hsieh.
151
152         * WebView/WebFrameView.mm:
153         (-[WebFrameView keyDown:keyDown:]):
154         * WebView/WebHTMLView.mm:
155         (-[WebHTMLView keyDown:]):
156         (-[WebHTMLView performKeyEquivalent:]):
157         Only use NSCursor on macOS.
158
159 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
160
161         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
162         https://bugs.webkit.org/show_bug.cgi?id=192573
163
164         Reviewed by Simon Fraser.
165
166         * Configurations/FeatureDefines.xcconfig:
167
168 2018-12-10  Antti Koivisto  <antti@apple.com>
169
170         Rename "forced style recalc" to "full style rebuild"
171         https://bugs.webkit.org/show_bug.cgi?id=192572
172
173         Reviewed by Zalan Bujtas.
174
175         * WebView/WebHTMLView.mm:
176         (-[WebHTMLView setNeedsToApplyStyles:]):
177
178 2018-12-10  Darin Adler  <darin@apple.com>
179
180         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
181         https://bugs.webkit.org/show_bug.cgi?id=192533
182         rdar://problem/45732710
183
184         Reviewed by Anders Carlsson.
185
186         * Plugins/Hosted/NetscapePluginHostProxy.mm:
187         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
188
189 2018-12-10  Darin Adler  <darin@apple.com>
190
191         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
192         https://bugs.webkit.org/show_bug.cgi?id=192532
193         rdar://problem/45731047
194
195         Reviewed by Chris Dumez.
196
197         * Plugins/Hosted/NetscapePluginHostManager.mm:
198         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
199         * Plugins/Hosted/NetscapePluginHostProxy.mm:
200         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
201
202 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
203
204         Turn WritingDirection into an enum class
205         https://bugs.webkit.org/show_bug.cgi?id=192401
206         Work towards <rdar://problem/42075638>
207
208         Reviewed by Dan Bernstein.
209
210         Change WritingDirection from an enum to an enum class. No change in behavior.
211
212         * WebView/WebHTMLView.mm:
213         (-[WebHTMLView toggleBaseWritingDirection:]):
214         (-[WebHTMLView changeBaseWritingDirection:]):
215         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
216
217 2018-12-03  Alex Christensen  <achristensen@webkit.org>
218
219         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
220         https://bugs.webkit.org/show_bug.cgi?id=192272
221
222         Reviewed by Brady Eidson.
223
224         * WebCoreSupport/WebFrameLoaderClient.h:
225         * WebCoreSupport/WebFrameLoaderClient.mm:
226         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
227
228 2018-12-03  Jer Noble  <jer.noble@apple.com>
229
230         Get rid of old, dead Mac video fullscreen code.
231         https://bugs.webkit.org/show_bug.cgi?id=192315
232
233         Reviewed by Eric Carlson.
234
235         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
236         is no longer supported in the Mac port.
237
238         * WebView/WebVideoFullscreenController.h: Removed.
239         * WebView/WebVideoFullscreenController.mm: Removed.
240         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
241         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
242         * WebView/WebView.mm:
243         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
244         (-[WebView _exitVideoFullscreen]):
245
246 2018-12-03  Daniel Bates  <dabates@apple.com>
247
248         [iOS] Do not handle key events that are key commands
249         https://bugs.webkit.org/show_bug.cgi?id=191608
250         <rdar://problem/46046013>
251
252         Reviewed by Ryosuke Niwa.
253
254         A key down event may be associated with a key command. If it is then we want to execute the
255         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
256         event as a key command to find out.
257
258         * WebView/WebHTMLView.mm:
259         (-[WebHTMLView _handleEditingKeyEvent:]):
260
261 2018-12-02  Zalan Bujtas  <zalan@apple.com>
262
263         Add a runtime feature flag for LayoutFormattingContext.
264         https://bugs.webkit.org/show_bug.cgi?id=192280
265
266         Reviewed by Simon Fraser.
267
268         * Configurations/FeatureDefines.xcconfig:
269
270 2018-11-30  Alex Christensen  <achristensen@webkit.org>
271
272         Move URL from WebCore to WTF
273         https://bugs.webkit.org/show_bug.cgi?id=190234
274
275         Reviewed by Keith Miller.
276
277         * DOM/DOMAttr.mm:
278         * DOM/DOMBlob.mm:
279         * DOM/DOMCSSCharsetRule.mm:
280         * DOM/DOMCSSImportRule.mm:
281         * DOM/DOMCSSMediaRule.mm:
282         * DOM/DOMCSSPageRule.mm:
283         * DOM/DOMCSSPrimitiveValue.mm:
284         * DOM/DOMCSSRule.mm:
285         * DOM/DOMCSSStyleDeclaration.mm:
286         * DOM/DOMCSSStyleRule.mm:
287         * DOM/DOMCSSStyleSheet.mm:
288         * DOM/DOMCSSValue.mm:
289         * DOM/DOMCharacterData.mm:
290         * DOM/DOMCounter.mm:
291         * DOM/DOMDocument.mm:
292         * DOM/DOMDocumentFragment.mm:
293         * DOM/DOMDocumentType.mm:
294         * DOM/DOMEvent.mm:
295         * DOM/DOMFile.mm:
296         * DOM/DOMHTMLAnchorElement.mm:
297         * DOM/DOMHTMLAppletElement.mm:
298         * DOM/DOMHTMLAreaElement.mm:
299         * DOM/DOMHTMLBRElement.mm:
300         * DOM/DOMHTMLBaseElement.mm:
301         * DOM/DOMHTMLBaseFontElement.mm:
302         * DOM/DOMHTMLBodyElement.mm:
303         * DOM/DOMHTMLButtonElement.mm:
304         * DOM/DOMHTMLCanvasElement.mm:
305         * DOM/DOMHTMLCollection.mm:
306         * DOM/DOMHTMLDivElement.mm:
307         * DOM/DOMHTMLDocument.mm:
308         * DOM/DOMHTMLElement.mm:
309         * DOM/DOMHTMLEmbedElement.mm:
310         * DOM/DOMHTMLFieldSetElement.mm:
311         * DOM/DOMHTMLFontElement.mm:
312         * DOM/DOMHTMLFormElement.mm:
313         * DOM/DOMHTMLFrameElement.mm:
314         * DOM/DOMHTMLFrameSetElement.mm:
315         * DOM/DOMHTMLHRElement.mm:
316         * DOM/DOMHTMLHeadElement.mm:
317         * DOM/DOMHTMLHeadingElement.mm:
318         * DOM/DOMHTMLHtmlElement.mm:
319         * DOM/DOMHTMLIFrameElement.mm:
320         * DOM/DOMHTMLImageElement.mm:
321         * DOM/DOMHTMLInputElement.mm:
322         * DOM/DOMHTMLLIElement.mm:
323         * DOM/DOMHTMLLabelElement.mm:
324         * DOM/DOMHTMLLegendElement.mm:
325         * DOM/DOMHTMLLinkElement.mm:
326         * DOM/DOMHTMLMapElement.mm:
327         * DOM/DOMHTMLMarqueeElement.mm:
328         * DOM/DOMHTMLMediaElement.mm:
329         * DOM/DOMHTMLMetaElement.mm:
330         * DOM/DOMHTMLModElement.mm:
331         * DOM/DOMHTMLOListElement.mm:
332         * DOM/DOMHTMLObjectElement.mm:
333         * DOM/DOMHTMLOptGroupElement.mm:
334         * DOM/DOMHTMLOptionElement.mm:
335         * DOM/DOMHTMLOptionsCollection.mm:
336         * DOM/DOMHTMLParagraphElement.mm:
337         * DOM/DOMHTMLParamElement.mm:
338         * DOM/DOMHTMLQuoteElement.mm:
339         * DOM/DOMHTMLScriptElement.mm:
340         * DOM/DOMHTMLSelectElement.mm:
341         * DOM/DOMHTMLStyleElement.mm:
342         * DOM/DOMHTMLTableCaptionElement.mm:
343         * DOM/DOMHTMLTableCellElement.mm:
344         * DOM/DOMHTMLTableColElement.mm:
345         * DOM/DOMHTMLTableElement.mm:
346         * DOM/DOMHTMLTableRowElement.mm:
347         * DOM/DOMHTMLTableSectionElement.mm:
348         * DOM/DOMHTMLTitleElement.mm:
349         * DOM/DOMHTMLUListElement.mm:
350         * DOM/DOMHTMLVideoElement.mm:
351         * DOM/DOMKeyboardEvent.mm:
352         * DOM/DOMMediaList.mm:
353         * DOM/DOMMouseEvent.mm:
354         * DOM/DOMMutationEvent.mm:
355         * DOM/DOMNamedNodeMap.mm:
356         * DOM/DOMProcessingInstruction.mm:
357         * DOM/DOMRange.mm:
358         * DOM/DOMStyleSheet.mm:
359         * DOM/DOMText.mm:
360         * DOM/DOMTextEvent.mm:
361         * DOM/DOMTokenList.mm:
362         * DOM/DOMUIEvent.mm:
363         * DOM/DOMXPathResult.mm:
364         * History/WebHistoryItem.mm:
365         * Misc/WebNSURLExtras.mm:
366         (-[NSURL _web_userVisibleString]):
367         (-[NSURL _web_URLByRemovingUserInfo]):
368         (-[NSURL _web_dataForURLComponentType:]):
369         (-[NSURL _web_schemeData]):
370         (-[NSURL _web_hostData]):
371         * Misc/WebUserContentURLPattern.mm:
372         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
373         * Plugins/WebNetscapePluginStream.h:
374         (WebNetscapePluginStream::setRequestURL):
375         * WebCoreSupport/WebChromeClient.h:
376         * WebCoreSupport/WebChromeClient.mm:
377         (WebChromeClient::signedPublicKeyAndChallengeString const):
378         * WebCoreSupport/WebContextMenuClient.h:
379         * WebCoreSupport/WebContextMenuClient.mm:
380         * WebCoreSupport/WebDragClient.h:
381         * WebCoreSupport/WebFrameLoaderClient.h:
382         * WebCoreSupport/WebFrameLoaderClient.mm:
383         (WebFrameLoaderClient::updateGlobalHistory):
384         * WebCoreSupport/WebPaymentCoordinatorClient.h:
385         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
386         (WebPaymentCoordinatorClient::showPaymentUI):
387         * WebCoreSupport/WebPlatformStrategies.h:
388         * WebCoreSupport/WebPlatformStrategies.mm:
389         (WebPlatformStrategies::readURLFromPasteboard):
390         * WebCoreSupport/WebPluginInfoProvider.h:
391         * WebCoreSupport/WebPluginInfoProvider.mm:
392         (WebPluginInfoProvider::webVisiblePluginInfo):
393         * WebCoreSupport/WebSecurityOrigin.mm:
394         * WebCoreSupport/WebVisitedLinkStore.h:
395         * WebView/WebDataSource.mm:
396         * WebView/WebFrame.mm:
397         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
398         * WebView/WebImmediateActionController.mm:
399         (-[WebImmediateActionController _defaultAnimationController]):
400         * WebView/WebPDFView.mm:
401         * WebView/WebScriptDebugger.mm:
402         * WebView/WebViewInternal.h:
403
404 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
405
406         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
407         https://bugs.webkit.org/show_bug.cgi?id=192197
408
409         Reviewed by Jiewen Tan.
410
411         * Configurations/FeatureDefines.xcconfig:
412         * WebCoreSupport/WebChromeClient.h:
413         * WebCoreSupport/WebChromeClient.mm:
414
415 2018-11-28  Alex Christensen  <achristensen@webkit.org>
416
417         Remove dead code from an earlier attempt at implementing safe browsing
418         https://bugs.webkit.org/show_bug.cgi?id=192067
419
420         Reviewed by Chris Dumez.
421
422         * WebCoreSupport/WebFrameLoaderClient.h:
423         * WebCoreSupport/WebFrameLoaderClient.mm:
424         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
425
426 2018-11-27  Mark Lam  <mark.lam@apple.com>
427
428         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
429         https://bugs.webkit.org/show_bug.cgi?id=192055
430         <rdar://problem/46288783>
431
432         Reviewed by Saam Barati.
433
434         * Configurations/FeatureDefines.xcconfig:
435
436 2018-11-25  Tim Horton  <timothy_horton@apple.com>
437
438         Make it possible to insert editable images with a gesture
439         https://bugs.webkit.org/show_bug.cgi?id=191937
440
441         Reviewed by Wenson Hsieh.
442
443         * WebCoreSupport/WebEditorClient.mm:
444         (undoNameForEditAction):
445         Add a undo name.
446
447 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
448
449         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
450         https://bugs.webkit.org/show_bug.cgi?id=191945
451
452         Reviewed by Anders Carlsson.
453
454         * WebCoreSupport/WebEditorClient.mm:
455         (undoNameForEditAction):
456
457 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
458
459         Enable drag and drop support for iOSMac
460         https://bugs.webkit.org/show_bug.cgi?id=191818
461         <rdar://problem/43907454>
462
463         Reviewed by Dean Jackson.
464
465         * Configurations/FeatureDefines.xcconfig:
466
467 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
468
469         Address post-review feedback after r238438
470         https://bugs.webkit.org/show_bug.cgi?id=191913
471
472         Reviewed by Ryosuke Niwa.
473
474         * WebView/WebFrame.mm:
475         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
476         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
477         * WebView/WebView.mm:
478         (-[WebView setSelectedDOMRange:affinity:]):
479
480 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
481
482         Web Inspector: "Reload Web Inspector" button no longer partially works
483         https://bugs.webkit.org/show_bug.cgi?id=191773
484         <rdar://problem/46139932>
485
486         Reviewed by Devin Rousso.
487
488         * WebCoreSupport/WebInspectorClient.h:
489         * WebCoreSupport/WebInspectorClient.mm:
490         (WebInspectorFrontendClient::reopen):
491
492 2018-11-17  Devin Rousso  <drousso@apple.com>
493
494         Web Inspector: Network: add button to show system certificate dialog
495         https://bugs.webkit.org/show_bug.cgi?id=191458
496         <rdar://problem/45977019>
497
498         Reviewed by Joseph Pecoraro.
499
500         * WebCoreSupport/WebInspectorClient.h:
501         * WebCoreSupport/WebInspectorClient.mm:
502         (WebInspectorFrontendClient::showCertificate): Added.
503
504         * Configurations/WebKitLegacy.xcconfig:
505
506 2018-11-15  Truitt Savell  <tsavell@apple.com>
507
508         Unreviewed, rolling out r238244.
509
510         Caused High Sierra test runs to fail early with 50 crashes and
511         casued 25 API failures.
512
513         Reverted changeset:
514
515         "[css-logical] Implement flow-relative margin, padding and
516         border shorthands"
517         https://bugs.webkit.org/show_bug.cgi?id=188697
518         https://trac.webkit.org/changeset/238244
519
520 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
521
522         [css-logical] Implement flow-relative margin, padding and border shorthands
523         https://bugs.webkit.org/show_bug.cgi?id=188697
524
525         Reviewed by Simon Fraser and Antti Koivisto.
526
527         Add CSSLogicalEnabled runtime flag.
528
529         * WebView/WebPreferenceKeysPrivate.h:
530         * WebView/WebPreferences.mm:
531         (+[WebPreferences initialize]):
532         (-[WebPreferences cssLogicalEnabled]):
533         (-[WebPreferences setCSSLogicalEnabled:]):
534         * WebView/WebPreferencesPrivate.h:
535         * WebView/WebView.mm:
536         (-[WebView _preferencesChanged:]):
537
538 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
539
540         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
541         https://bugs.webkit.org/show_bug.cgi?id=191612
542
543         Reviewed by Matt Baker.
544
545         * WebCoreSupport/WebInspectorClient.mm:
546         (-[WebInspectorWindowController destroyInspectorView]):
547
548 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
549
550         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
551         https://bugs.webkit.org/show_bug.cgi?id=191494
552         <rdar://problem/45469854>
553
554         Reviewed by Devin Rousso.
555
556         * WebCoreSupport/WebInspectorClient.h:
557         WebKitLegacy will still have remote inspection of the Page directly.
558
559 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
560
561         Make compositing updates incremental
562         https://bugs.webkit.org/show_bug.cgi?id=90342
563
564         Reviewed by Antti Koivisto.
565
566         Fix spelling error.
567
568         * WebView/WebView.mm:
569         (-[WebView _setMediaLayer:forPluginView:]):
570
571 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
572
573         Implement a new edit command to change the enclosing list type
574         https://bugs.webkit.org/show_bug.cgi?id=191487
575         <rdar://problem/45955922>
576
577         Reviewed by Ryosuke Niwa.
578
579         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
580
581         * WebCoreSupport/WebEditorClient.mm:
582         (undoNameForEditAction):
583
584 2018-11-11  Daniel Bates  <dabates@apple.com>
585
586         [iOS] Draw caps lock indicator in password fields
587         https://bugs.webkit.org/show_bug.cgi?id=190565
588         <rdar://problem/45262343>
589
590         Reviewed by Dean Jackson.
591
592         Update the caps lock state when a hardware keyboard is attached or detached.
593
594         * WebView/WebHTMLView.mm:
595         (hardwareKeyboardAvailabilityChangedCallback): Added.
596         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
597         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
598
599 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
600
601         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
602         https://bugs.webkit.org/show_bug.cgi?id=191492
603
604         Reviewed by Alex Christensen.
605
606         * Carbon/HIWebView.mm:
607         * Misc/WebNSFileManagerExtras.mm:
608         * Misc/WebNSURLExtras.mm:
609         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
610         * Plugins/WebBasePluginPackage.mm:
611         * Plugins/WebPluginContainerCheck.mm:
612         * WebCoreSupport/WebCachedFramePlatformData.h:
613         * WebCoreSupport/WebDeviceOrientationClient.mm:
614         * WebView/WebDelegateImplementationCaching.mm:
615         * WebView/WebHTMLView.mm:
616         * WebView/WebPDFRepresentation.mm:
617         * WebView/WebPolicyDelegate.mm:
618         * WebView/WebView.mm:
619
620 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
621
622         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
623         https://bugs.webkit.org/show_bug.cgi?id=191492
624
625         Reviewed by Alex Christensen.
626
627         * Carbon/HIWebView.mm:
628         (UpdateCommandStatus):
629         * Misc/WebNSFileManagerExtras.mm:
630         * Misc/WebNSURLExtras.mm:
631         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
632         * Plugins/WebBasePluginPackage.mm:
633         * Plugins/WebPluginContainerCheck.mm:
634         (-[WebPluginContainerCheck _continueWithPolicy:]):
635         * WebCoreSupport/WebCachedFramePlatformData.h:
636         (WebCachedFramePlatformData::clear):
637         * WebCoreSupport/WebDeviceOrientationClient.mm:
638         (WebDeviceOrientationClient::getProvider const):
639         * WebView/WebDelegateImplementationCaching.mm:
640         (CallDelegate):
641         (CallDelegateReturningBoolean):
642         (CallResourceLoadDelegateReturningBoolean):
643         (CallFormDelegate):
644         (CallFormDelegateReturningBoolean):
645         * WebView/WebHTMLView.mm:
646         * WebView/WebPDFRepresentation.mm:
647         * WebView/WebPolicyDelegate.mm:
648         (-[WebPolicyDecisionListener _usePolicy:]):
649         * WebView/WebView.mm:
650
651 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
652
653         Unreviewed, rolling out r238047.
654
655         Introduced layout test failures on iOS simulator.
656
657         Reverted changeset:
658
659         "[iOS] Draw caps lock indicator in password fields"
660         https://bugs.webkit.org/show_bug.cgi?id=190565
661         https://trac.webkit.org/changeset/238047
662
663 2018-11-09  Antti Koivisto  <antti@apple.com>
664
665         Use OptionSet for layout milestones
666         https://bugs.webkit.org/show_bug.cgi?id=191470
667
668         Reviewed by Dean Jackson.
669
670         * WebCoreSupport/WebFrameLoaderClient.h:
671         * WebCoreSupport/WebFrameLoaderClient.mm:
672         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
673         * WebView/WebView.mm:
674         (coreLayoutMilestones):
675         (kitLayoutMilestones):
676         (-[WebView _cacheFrameLoadDelegateImplementations]):
677         * WebView/WebViewInternal.h:
678
679 2018-11-09  Daniel Bates  <dabates@apple.com>
680
681         [iOS] Draw caps lock indicator in password fields
682         https://bugs.webkit.org/show_bug.cgi?id=190565
683         <rdar://problem/45262343>
684
685         Reviewed by Dean Jackson.
686
687         Update the caps lock state when a hardware keyboard is attached or detached.
688
689         * WebView/WebHTMLView.mm:
690         (hardwareKeyboardAvailabilityChangedCallback): Added.
691         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
692         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
693
694 2018-11-09  Daniel Bates  <dabates@apple.com>
695
696         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
697         action when forward delete is pressed outside a text field
698         https://bugs.webkit.org/show_bug.cgi?id=190566
699         <rdar://problem/45262367>
700
701         Reviewed by Wenson Hsieh.
702
703         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
704         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
705         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
706
707         * WebView/WebHTMLView.mm:
708         (-[WebHTMLView _handleEditingKeyEvent:]):
709
710 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
711
712         Adopt Reveal Framework to replace Lookup
713         https://bugs.webkit.org/show_bug.cgi?id=191097
714         <rdar://problem/45924508>
715
716         Reviewed by Tim Horton.
717
718         Pass in what it needed to clear the textIndicators. This is better than
719         the current notification structure.
720
721         * WebView/WebView.mm:
722         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
723         (-[WebView _prepareForDictionaryLookup]):
724
725 2018-11-06  Justin Fan  <justin_fan@apple.com>
726
727         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
728         https://bugs.webkit.org/show_bug.cgi?id=191291
729
730         Reviewed by Myles Maxfield.
731
732         Properly disable WEBGPU on all non-Metal platforms for now.
733
734         * Configurations/FeatureDefines.xcconfig:
735
736 2018-11-02  Daniel Bates  <dabates@apple.com>
737
738         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
739         https://bugs.webkit.org/show_bug.cgi?id=190487
740
741         Reviewed by Tim Horton.
742
743         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
744         allow the default handling.
745
746         * WebView/WebHTMLView.mm:
747         (-[WebHTMLView _handleEditingKeyEvent:]):
748
749 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
750
751         Add a storage limit for IndexedDB
752         https://bugs.webkit.org/show_bug.cgi?id=190598
753         <rdar://problem/44654715>
754
755         Reviewed by Chris Dumez.
756
757         * Storage/WebDatabaseManager.mm:
758         (-[WebDatabaseManager setIDBPerOriginQuota:]):
759         * Storage/WebDatabaseManagerPrivate.h:
760
761 2018-10-31  Antti Koivisto  <antti@apple.com>
762
763         Remove LayerFlushScheduler
764         https://bugs.webkit.org/show_bug.cgi?id=191103
765
766         Reviewed by Anders Carlsson.
767
768         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
769         all the virtual cruft.
770
771         * WebView/WebViewData.h:
772         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
773         (): Deleted.
774         * WebView/WebViewData.mm:
775         (currentRunLoop):
776         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
777         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
778         (WebViewLayerFlushScheduler::schedule):
779         (WebViewLayerFlushScheduler::invalidate):
780         (WebViewLayerFlushScheduler::layerFlushCallback):
781
782 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
783
784         Enable InstallAPI for iOS unconditionally
785         https://bugs.webkit.org/show_bug.cgi?id=191043
786         rdar://problem/32728423
787
788         Reviewed by Dan Bernstein.
789
790         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
791         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
792         shouldn't be processed by InstallAPI.
793         * MigrateHeaders.make: Removed an obsolete workaround.
794         * Misc/NSURLDownloadSPI.h: Added.
795         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
796
797 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
798
799         Clean up some obsolete MAX_ALLOWED macros
800         https://bugs.webkit.org/show_bug.cgi?id=190916
801
802         Reviewed by Tim Horton.
803
804         * WebView/WebHTMLView.mm:
805         (-[WebHTMLView pressureChangeWithEvent:]):
806         * WebView/WebPDFView.h:
807
808 2018-10-30  Commit Queue  <commit-queue@webkit.org>
809
810         Unreviewed, rolling out r237600 and r237604.
811         https://bugs.webkit.org/show_bug.cgi?id=191086
812
813         Breaks internal iOS builds (Requested by ryanhadd_ on
814         #webkit).
815
816         Reverted changesets:
817
818         "Enable InstallAPI for iOS unconditionally"
819         https://bugs.webkit.org/show_bug.cgi?id=191043
820         https://trac.webkit.org/changeset/237600
821
822         "Build fix attempt after enabling InstallAPI for iOS."
823         https://bugs.webkit.org/show_bug.cgi?id=191043
824         https://trac.webkit.org/changeset/237604
825
826 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
827
828         Enable InstallAPI for iOS unconditionally
829         https://bugs.webkit.org/show_bug.cgi?id=191043
830         rdar://problem/32728423
831
832         Reviewed by Dan Bernstein.
833
834         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
835         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
836         shouldn't be processed by InstallAPI.
837         * MigrateHeaders.make: Removed an obsolete workaround.
838         * Misc/NSURLDownloadSPI.h: Added.
839         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
840
841 2018-10-29  Tim Horton  <timothy_horton@apple.com>
842
843         Modernize WebKit nibs and lprojs for localization's sake
844         https://bugs.webkit.org/show_bug.cgi?id=190911
845         <rdar://problem/45349466>
846
847         Reviewed by Dan Bernstein.
848
849         * Misc/WebNSControlExtras.m:
850         (-[NSControl sizeToFitAndAdjustWindowHeight]):
851         NSWindow and its contents are both in the same scale space these days; avoid
852         double-applying the scale factor, or you can't see the prompt.
853
854         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
855         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
856         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
857         NIB->XIB
858
859 2018-10-25  Antoine Quint  <graouts@apple.com>
860
861         [Web Animations] Turn Web Animations CSS Integration off by default
862         https://bugs.webkit.org/show_bug.cgi?id=190901
863
864         Reviewed by Dean Jackson.
865
866         * WebView/WebPreferences.mm:
867         (+[WebPreferences initialize]):
868
869 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
870
871         Clean up some obsolete macOS version guards
872         https://bugs.webkit.org/show_bug.cgi?id=190887
873
874         Reviewed by Dan Bernstein.
875
876         * Misc/WebNSPasteboardExtras.mm:
877         (+[NSPasteboard _web_dragTypesForURL]):
878         * WebCoreSupport/PopupMenuMac.mm:
879         (PopupMenuMac::show):
880         * WebCoreSupport/WebEditorClient.h:
881         * WebCoreSupport/WebEditorClient.mm:
882         (WebEditorClient::respondToChangedSelection):
883         * WebView/WebPDFView.mm:
884         (-[WebPDFView _clipViewForPDFDocumentView]):
885
886 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
887
888         Turn on Conic Gradients
889         https://bugs.webkit.org/show_bug.cgi?id=190810
890
891         Reviewed by Tim Horton.
892
893         * Configurations/FeatureDefines.xcconfig:
894
895 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
896
897         Cleanup: MIMETypeRegistry functions
898         https://bugs.webkit.org/show_bug.cgi?id=190838
899
900         Reviewed by Simon Fraser.
901
902         * Misc/WebNSPasteboardExtras.mm:
903         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
904         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
905         because they were identical.
906
907         * WebView/WebHTMLRepresentation.mm:
908         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
909         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
910         (+[WebHTMLRepresentation supportedImageMIMETypes]):
911         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
912         * WebView/WebView.mm:
913         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
914         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
915         (+[WebView registerViewClass:representationClass:forMIMEType:]):
916
917 2018-10-23  David Kilzer  <ddkilzer@apple.com>
918
919         Fix false positive leaks when using custom -init methods that don't start with -init
920         <https://webkit.org/b/190818>
921         <rdar://problem/45476042>
922
923         Reviewed by Dan Bernstein.
924
925         * Misc/WebKitErrors.m: Move `descriptions` static global so that
926         it is accessible by both categories.
927         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
928         NSError (WebKitInternal) category.  Add attribute to make this
929         behave like an -init method.
930         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
931         NSError (WebKitInternal) category.  Modernize method.  Replace
932         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
933
934 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
935
936         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
937         https://bugs.webkit.org/show_bug.cgi?id=190729
938
939         Reviewed by Tim Horton.
940
941         * DOM/DOM.mm:
942         (-[DOMNode boundingBox]):
943         * DOM/DOMElement.mm:
944         * DOM/DOMHTML.mm:
945         * DOM/DOMInternal.mm:
946         * DOM/DOMUIKitExtensions.mm:
947         * DOM/WebDOMOperations.mm:
948         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
949         * DefaultDelegates/WebDefaultEditingDelegate.m:
950         * DefaultDelegates/WebDefaultPolicyDelegate.m:
951         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
952         * DefaultDelegates/WebDefaultUIDelegate.h:
953         * DefaultDelegates/WebDefaultUIDelegate.mm:
954         (-[WebDefaultUIDelegate webViewClose:]):
955         (-[WebDefaultUIDelegate webViewFocus:]):
956         (-[WebDefaultUIDelegate webViewUnfocus:]):
957         (-[WebDefaultUIDelegate webViewIsResizable:]):
958         (-[WebDefaultUIDelegate webView:setResizable:]):
959         (-[WebDefaultUIDelegate webView:setFrame:]):
960         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
961         * History/BackForwardList.h:
962         * History/BackForwardList.mm:
963         * History/WebBackForwardList.mm:
964         (+[WebBackForwardList initialize]):
965         (bumperCarBackForwardHackNeeded):
966         * History/WebHistory.mm:
967         (-[WebHistoryPrivate addItem:discardDuplicate:]):
968         (-[WebHistory _sendNotification:entries:]):
969         (-[WebHistory loadFromURL:error:]):
970         (-[WebHistory saveToURL:error:]):
971         * History/WebHistoryItem.mm:
972         (WKNotifyHistoryItemChanged):
973         (+[WebHistoryItem initialize]):
974         (-[WebHistoryItem initFromDictionaryRepresentation:]):
975         * History/WebURLsWithTitles.m:
976         * Misc/WebCache.mm:
977         (+[WebCache initialize]):
978         * Misc/WebDownload.mm:
979         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
980         * Misc/WebElementDictionary.mm:
981         (+[WebElementDictionary initialize]):
982         (+[WebElementDictionary initializeLookupTable]):
983         * Misc/WebIconDatabase.mm:
984         * Misc/WebKitNSStringExtras.mm:
985         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
986         * Misc/WebKitVersionChecks.h:
987         * Misc/WebKitVersionChecks.mm:
988         (WebKitLinkedOnOrAfter):
989         (WebKitLinkTimeVersion):
990         * Misc/WebLocalizableStrings.mm:
991         * Misc/WebNSControlExtras.h:
992         * Misc/WebNSControlExtras.m:
993         * Misc/WebNSEventExtras.m:
994         * Misc/WebNSFileManagerExtras.mm:
995         * Misc/WebNSImageExtras.h:
996         * Misc/WebNSImageExtras.m:
997         * Misc/WebNSPasteboardExtras.mm:
998         * Misc/WebNSPrintOperationExtras.h:
999         * Misc/WebNSPrintOperationExtras.m:
1000         * Misc/WebNSViewExtras.m:
1001         * Misc/WebNSWindowExtras.m:
1002         * Panels/WebAuthenticationPanel.h:
1003         * Panels/WebAuthenticationPanel.m:
1004         * Panels/WebPanelAuthenticationHandler.m:
1005         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1006         (+[WebHostedNetscapePluginView initialize]):
1007         * Plugins/WebBasePluginPackage.h:
1008         * Plugins/WebBasePluginPackage.mm:
1009         * Plugins/WebJavaPlugIn.h:
1010         * Plugins/WebPluginContainerCheck.mm:
1011         * Plugins/WebPluginController.h:
1012         * Plugins/WebPluginController.mm:
1013         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1014         (-[WebPluginController addPlugin:]):
1015         (-[WebPluginController destroyPlugin:]):
1016         (-[WebPluginController destroyAllPlugins]):
1017         * Plugins/WebPluginDatabase.mm:
1018         (+[WebPluginDatabase _defaultPlugInPaths]):
1019         * Plugins/WebPluginPackage.mm:
1020         (-[WebPluginPackage initWithPath:]):
1021         * Storage/WebDatabaseManager.mm:
1022         (-[WebDatabaseManager deleteAllDatabases]):
1023         * Storage/WebDatabaseManagerClient.h:
1024         * Storage/WebDatabaseManagerClient.mm:
1025         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1026         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1027         * Storage/WebStorageManager.mm:
1028         (-[WebStorageManager deleteAllOrigins]):
1029         (WebKitInitializeStorageIfNecessary):
1030         * WebCoreSupport/WebAlternativeTextClient.h:
1031         * WebCoreSupport/WebApplicationCache.mm:
1032         (applicationCacheBundleIdentifier):
1033         * WebCoreSupport/WebChromeClient.h:
1034         * WebCoreSupport/WebChromeClient.mm:
1035         (WebChromeClient::setWindowRect):
1036         (WebChromeClient::windowRect):
1037         (WebChromeClient::takeFocus):
1038         (WebChromeClient::addMessageToConsole):
1039         (WebChromeClient::enableSuddenTermination):
1040         (WebChromeClient::disableSuddenTermination):
1041         (WebChromeClient::createPopupMenu const):
1042         (WebChromeClient::createSearchPopupMenu const):
1043         (WebChromeClient::shouldPaintEntireContents const):
1044         (WebChromeClient::supportsVideoFullscreen):
1045         (WebChromeClient::supportsFullScreenForElement):
1046         (WebChromeClient::enterFullScreenForElement):
1047         (WebChromeClient::exitFullScreenForElement):
1048         * WebCoreSupport/WebContextMenuClient.mm:
1049         * WebCoreSupport/WebDragClient.mm:
1050         * WebCoreSupport/WebEditorClient.h:
1051         * WebCoreSupport/WebEditorClient.mm:
1052         (+[WebUndoStep initialize]):
1053         (updateFontPanel):
1054         (WebEditorClient::didBeginEditing):
1055         (WebEditorClient::respondToChangedContents):
1056         (WebEditorClient::respondToChangedSelection):
1057         (WebEditorClient::canceledComposition):
1058         (WebEditorClient::didEndEditing):
1059         (WebEditorClient::didWriteSelectionToPasteboard):
1060         (attributesForAttributedStringConversion):
1061         (WebEditorClient::setInsertionPasteboard):
1062         (WebEditorClient::registerUndoOrRedoStep):
1063         (WebEditorClient::handleKeyboardEvent):
1064         (WebEditorClient::handleInputMethodKeydown):
1065         (WebEditorClient::textDidChangeInTextField):
1066         (WebEditorClient::requestCheckingOfString):
1067         * WebCoreSupport/WebFrameLoaderClient.h:
1068         * WebCoreSupport/WebFrameLoaderClient.mm:
1069         (WebFrameLoaderClient::detachedFromParent2):
1070         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1071         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1072         (WebFrameLoaderClient::dispatchWillSendRequest):
1073         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1074         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1075         (WebFrameLoaderClient::willCacheResponse const):
1076         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1077         (WebFrameLoaderClient::dispatchDidFinishLoading):
1078         (WebFrameLoaderClient::dispatchDidFailLoading):
1079         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1080         (WebFrameLoaderClient::dispatchWillClose):
1081         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1082         (WebFrameLoaderClient::dispatchDidCommitLoad):
1083         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1084         (WebFrameLoaderClient::dispatchDidFailLoad):
1085         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1086         (WebFrameLoaderClient::dispatchDidFinishLoad):
1087         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1088         (WebFrameLoaderClient::willChangeTitle):
1089         (WebFrameLoaderClient::didChangeTitle):
1090         (WebFrameLoaderClient::didReplaceMultipartContent):
1091         (WebFrameLoaderClient::updateGlobalHistory):
1092         (WebFrameLoaderClient::saveViewStateToItem):
1093         (WebFrameLoaderClient::restoreViewState):
1094         (WebFrameLoaderClient::provisionalLoadStarted):
1095         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1096         (WebFrameLoaderClient::setTitle):
1097         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1098         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1099         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1100         (WebFrameLoaderClient::didRestoreFromPageCache):
1101         (WebFrameLoaderClient::actionDictionary const):
1102         (WebFrameLoaderClient::createPlugin):
1103         (WebFrameLoaderClient::getLoadDecisionForIcons):
1104         (WebFrameLoaderClient::finishedLoadingIcon):
1105         (+[WebFramePolicyListener initialize]):
1106         * WebCoreSupport/WebFrameNetworkingContext.mm:
1107         * WebCoreSupport/WebGeolocationClient.h:
1108         * WebCoreSupport/WebGeolocationClient.mm:
1109         (WebGeolocationClient::requestPermission):
1110         * WebCoreSupport/WebInspectorClient.h:
1111         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1112         * WebCoreSupport/WebNotificationClient.mm:
1113         * WebCoreSupport/WebOpenPanelResultListener.mm:
1114         * WebCoreSupport/WebPlatformStrategies.h:
1115         * WebCoreSupport/WebPlatformStrategies.mm:
1116         * WebCoreSupport/WebProgressTrackerClient.h:
1117         * WebCoreSupport/WebProgressTrackerClient.mm:
1118         (WebProgressTrackerClient::progressStarted):
1119         (WebProgressTrackerClient::progressEstimateChanged):
1120         (WebProgressTrackerClient::progressFinished):
1121         * WebCoreSupport/WebSecurityOrigin.mm:
1122         * WebInspector/WebNodeHighlight.h:
1123         * WebInspector/WebNodeHighlight.mm:
1124         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1125         (-[WebNodeHighlight dealloc]):
1126         (-[WebNodeHighlight attach]):
1127         * WebInspector/WebNodeHighlightView.h:
1128         * WebInspector/WebNodeHighlightView.mm:
1129         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1130         (-[WebNodeHighlightView dealloc]):
1131         * WebInspector/WebNodeHighlighter.mm:
1132         (-[WebNodeHighlighter highlight]):
1133         * WebView/WebArchive.mm:
1134         (+[WebArchivePrivate initialize]):
1135         * WebView/WebClipView.h:
1136         * WebView/WebDataSource.mm:
1137         (WebDataSourcePrivate::WebDataSourcePrivate):
1138         (+[WebDataSource initialize]):
1139         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1140         (-[WebDataSource _makeRepresentation]):
1141         * WebView/WebDelegateImplementationCaching.h:
1142         * WebView/WebDelegateImplementationCaching.mm:
1143         (CallDelegate):
1144         (CallDelegateReturningFloat):
1145         (CallDelegateReturningBoolean):
1146         (CallUIDelegate):
1147         (CallUIDelegateReturningFloat):
1148         (CallUIDelegateReturningBoolean):
1149         (CallFrameLoadDelegate):
1150         (CallFrameLoadDelegateReturningBoolean):
1151         (CallResourceLoadDelegate):
1152         (CallScriptDebugDelegate):
1153         (CallFormDelegate):
1154         (CallFormDelegateReturningBoolean):
1155         * WebView/WebDeviceOrientation.mm:
1156         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1157         * WebView/WebDocumentInternal.h:
1158         * WebView/WebDocumentLoaderMac.mm:
1159         (needsDataLoadWorkaround):
1160         * WebView/WebDynamicScrollBarsViewInternal.h:
1161         * WebView/WebFormDelegate.m:
1162         * WebView/WebFrame.mm:
1163         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1164         (-[WebFrame _unmarkAllMisspellings]):
1165         (-[WebFrame _paintBehaviorForDestinationContext:]):
1166         (-[WebFrame _drawRect:contentsOnly:]):
1167         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1168         (-[WebFrame _scrollDOMRangeToVisible:]):
1169         (-[WebFrame _bodyBackgroundColor]):
1170         (-[WebFrame accessibilityRoot]):
1171         (needsMicrosoftMessengerDOMDocumentWorkaround):
1172         * WebView/WebFrameInternal.h:
1173         * WebView/WebFrameView.mm:
1174         (-[WebFrameView _setDocumentView:]):
1175         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1176         (-[WebFrameView _viewClassForMIMEType:]):
1177         (-[WebFrameView initWithFrame:]):
1178         (-[WebFrameView drawRect:]):
1179         (-[WebFrameView _firstResponderIsFormControl]):
1180         (-[WebFrameView keyDown:keyDown:]):
1181         (-[WebFrameView _isScrollable]):
1182         * WebView/WebFullScreenController.h:
1183         * WebView/WebFullScreenController.mm:
1184         * WebView/WebHTMLRepresentation.mm:
1185         * WebView/WebHTMLView.mm:
1186         (-[WebHTMLView hitTest:]):
1187         (-[WebHTMLView initWithFrame:]):
1188         (-[WebHTMLView dealloc]):
1189         (-[WebHTMLView addSubview:]):
1190         (-[WebHTMLView mouseDown:]):
1191         (-[WebHTMLView mouseUp:]):
1192         (-[WebHTMLView resignFirstResponder]):
1193         (-[WebHTMLView accessibilityHitTest:]):
1194         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1195         * WebView/WebHTMLViewInternal.h:
1196         * WebView/WebIndicateLayer.h:
1197         * WebView/WebIndicateLayer.mm:
1198         * WebView/WebMediaPlaybackTargetPicker.h:
1199         * WebView/WebMediaPlaybackTargetPicker.mm:
1200         * WebView/WebPDFDocumentExtras.h:
1201         * WebView/WebPDFDocumentExtras.mm:
1202         * WebView/WebPDFRepresentation.h:
1203         * WebView/WebPDFRepresentation.mm:
1204         * WebView/WebPDFView.h:
1205         * WebView/WebPreferences.mm:
1206         (cacheModelForMainBundle):
1207         (WebPreferencesPrivate::WebPreferencesPrivate):
1208         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1209         (-[WebPreferences encodeWithCoder:]):
1210         (+[WebPreferences standardPreferences]):
1211         (+[WebPreferences initialize]):
1212         (-[WebPreferences _valueForKey:]):
1213         (-[WebPreferences _setStringValue:forKey:]):
1214         (-[WebPreferences _setIntegerValue:forKey:]):
1215         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1216         (-[WebPreferences _setFloatValue:forKey:]):
1217         (-[WebPreferences _setBoolValue:forKey:]):
1218         (-[WebPreferences _setLongLongValue:forKey:]):
1219         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1220         (-[WebPreferences _postCacheModelChangedNotification]):
1221         (-[WebPreferences _postPreferencesChangedNotification]):
1222         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1223         (-[WebPreferences setStorageBlockingPolicy:]):
1224         * WebView/WebResource.mm:
1225         (+[WebResourcePrivate initialize]):
1226         * WebView/WebTextCompletionController.h:
1227         * WebView/WebTextIterator.mm:
1228         (+[WebTextIteratorPrivate initialize]):
1229         * WebView/WebView.mm:
1230         (shouldEnableLoadDeferring):
1231         (shouldRestrictWindowFocus):
1232         (shouldRespectPriorityInCSSAttributeSetters):
1233         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1234         (shouldAllowPictureInPictureMediaPlayback):
1235         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1236         (shouldAllowWindowOpenWithoutUserGesture):
1237         (shouldConvertInvalidURLsToBlank):
1238         (shouldRequireUserGestureToLoadVideo):
1239         (-[WebView _commonInitializationWithFrameName:groupName:]):
1240         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1241         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1242         (-[WebView _closePluginDatabases]):
1243         (-[WebView _closeWithFastTeardown]):
1244         (-[WebView _close]):
1245         (+[WebView _MIMETypeForFile:]):
1246         (-[WebView setShowingInspectorIndication:]):
1247         (-[WebView _setFormDelegate:]):
1248         (-[WebView _needsPreHTML5ParserQuirks]):
1249         (-[WebView _preferencesChangedNotification:]):
1250         (-[WebView _preferencesChanged:]):
1251         (-[WebView _cacheResourceLoadDelegateImplementations]):
1252         (-[WebView _cacheFrameLoadDelegateImplementations]):
1253         (-[WebView _policyDelegateForwarder]):
1254         (-[WebView _UIDelegateForwarder]):
1255         (-[WebView _editingDelegateForwarder]):
1256         (-[WebView _updateActiveState]):
1257         (-[_WebSafeForwarder forwardInvocation:]):
1258         (+[WebView initialize]):
1259         (-[WebView _pluginForMIMEType:]):
1260         (-[WebView _pluginForExtension:]):
1261         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1262         (+[WebView canShowMIMETypeAsHTML:]):
1263         (-[WebView _initWithArguments:]):
1264         (-[WebView initWithFrame:frameName:groupName:]):
1265         (-[WebView dealloc]):
1266         (-[WebView close]):
1267         (-[WebView viewDidMoveToWindow]):
1268         (-[WebView setUIDelegate:]):
1269         (-[WebView setResourceLoadDelegate:]):
1270         (-[WebView setPolicyDelegate:]):
1271         (-[WebView setFrameLoadDelegate:]):
1272         (-[WebView goBack]):
1273         (-[WebView goForward]):
1274         (-[WebView stringByEvaluatingJavaScriptFromString:]):
1275         (-[WebView setHostWindow:]):
1276         (-[WebView becomeFirstResponder]):
1277         (+[WebView _cacheModelChangedNotification:]):
1278         (-[WebView _frameViewAtWindowPoint:]):
1279         (+[WebView _preflightSpellCheckerNow:]):
1280         (+[WebView _preflightSpellChecker]):
1281         (-[WebView canGoBack]):
1282         (-[WebView canGoForward]):
1283         (-[WebView stopLoading:]):
1284         (-[WebView reload:]):
1285         (-[WebView setMainFrameDocumentReady:]):
1286         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1287         (-[WebView setContinuousSpellCheckingEnabled:]):
1288         (-[WebView undoManager]):
1289         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
1290         (-[WebView isAutomaticLinkDetectionEnabled]):
1291         (-[WebView isAutomaticDashSubstitutionEnabled]):
1292         (-[WebView isAutomaticTextReplacementEnabled]):
1293         (-[WebView isAutomaticSpellingCorrectionEnabled]):
1294         (+[WebView _setCacheModel:]):
1295         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1296         (-[WebView _keyboardUIMode]):
1297         (LayerFlushController::flushLayers):
1298         (-[WebView _scheduleCompositingLayerFlush]):
1299         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1300         (-[WebView fullScreenPlaceholderView]):
1301         (WebInstallMemoryPressureHandler):
1302         * WebView/WebViewData.h:
1303         * WebView/WebViewData.mm:
1304         (+[WebViewPrivate initialize]):
1305         (-[WebViewPrivate init]):
1306         (-[WebViewPrivate dealloc]):
1307         * WebView/WebViewInternal.h:
1308
1309 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1310
1311         Clean up FrameLoader two-state enums
1312         https://bugs.webkit.org/show_bug.cgi?id=190731
1313
1314         Reviewed by Chris Dumez.
1315
1316         * WebCoreSupport/WebFrameLoaderClient.h:
1317         * WebCoreSupport/WebFrameLoaderClient.mm:
1318         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1319
1320 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1321
1322         Unreviewed, rolling out r237137.
1323
1324         SPI is actually used
1325
1326         Reverted changeset:
1327
1328         "Remove unused WebFrame._loadType"
1329         https://bugs.webkit.org/show_bug.cgi?id=190583
1330         https://trac.webkit.org/changeset/237137
1331
1332 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1333
1334         Enable the datalist element by default on iOS and macOS
1335         https://bugs.webkit.org/show_bug.cgi?id=190594
1336         <rdar://problem/45281159>
1337
1338         Reviewed by Ryosuke Niwa and Tim Horton.
1339
1340         * Configurations/FeatureDefines.xcconfig:
1341
1342 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1343
1344         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1345         https://bugs.webkit.org/show_bug.cgi?id=190675
1346
1347         Reviewed by Chris Dumez.
1348
1349         * History/BackForwardList.h:
1350         * History/BackForwardList.mm:
1351         (BackForwardList::backItem):
1352         (BackForwardList::currentItem):
1353         (BackForwardList::forwardItem):
1354         (BackForwardList::backListCount const):
1355         (BackForwardList::forwardListCount const):
1356         (BackForwardList::itemAtIndex):
1357         * History/WebBackForwardList.mm:
1358         (-[WebBackForwardList backItem]):
1359         (-[WebBackForwardList currentItem]):
1360         (-[WebBackForwardList forwardItem]):
1361         (-[WebBackForwardList itemAtIndex:]):
1362
1363 2018-10-16  Timothy Hatcher  <timothy@apple.com>
1364
1365         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
1366         https://bugs.webkit.org/show_bug.cgi?id=190526
1367         rdar://problem/45230140
1368
1369         Reviewed by Dean Jackson.
1370
1371         * WebCoreSupport/WebEditorClient.mm:
1372         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
1373
1374 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1375
1376         Implement feature flag and bindings for CSS Painting API
1377         https://bugs.webkit.org/show_bug.cgi?id=190237
1378
1379         Reviewed by Ryosuke Niwa.
1380
1381         * Configurations/FeatureDefines.xcconfig:
1382
1383 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1384
1385         Replace HistoryItem* with HistoryItem& where possible
1386         https://bugs.webkit.org/show_bug.cgi?id=190617
1387
1388         Reviewed by Chris Dumez.
1389
1390         * History/BackForwardList.h:
1391         * History/BackForwardList.mm:
1392         (BackForwardList::goToItem):
1393         * History/WebBackForwardList.mm:
1394         (-[WebBackForwardList goToItem:]):
1395         * History/WebHistoryItem.mm:
1396         (WKNotifyHistoryItemChanged):
1397         * History/WebHistoryItemInternal.h:
1398
1399 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1400
1401         Remove unused WebHistoryItem._transientPropertyForKey
1402         https://bugs.webkit.org/show_bug.cgi?id=190606
1403
1404         Reviewed by Chris Dumez.
1405
1406         * History/WebHistoryItem.mm:
1407         * History/WebHistoryItemPrivate.h:
1408
1409 2018-10-15  Justin Fan  <justin_fan@apple.com>
1410
1411         Add WebGPU 2018 feature flag and experimental feature flag
1412         https://bugs.webkit.org/show_bug.cgi?id=190509
1413
1414         Reviewed by Dean Jackson.
1415
1416         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1417         for the 2018 WebGPU prototype.
1418
1419         * Configurations/FeatureDefines.xcconfig:
1420         * WebView/WebPreferenceKeysPrivate.h:
1421         * WebView/WebPreferences.mm:
1422         (+[WebPreferences initialize]):
1423         (-[WebPreferences webGPUEnabled]):
1424         (-[WebPreferences setWebGPUEnabled:]):
1425         * WebView/WebPreferencesPrivate.h:
1426         * WebView/WebView.mm:
1427         (-[WebView _preferencesChanged:]):
1428
1429 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1430
1431         Fix iOS build after r237157
1432
1433         * WebView/WebView.mm:
1434         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1435
1436 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1437
1438         Modernize BackForwardClient.h
1439         https://bugs.webkit.org/show_bug.cgi?id=190610
1440
1441         Reviewed by Chris Dumez.
1442
1443         * History/BackForwardList.h:
1444         * History/BackForwardList.mm:
1445         (BackForwardList::backListCount const):
1446         (BackForwardList::forwardListCount const):
1447         (BackForwardList::backListCount): Deleted.
1448         (BackForwardList::forwardListCount): Deleted.
1449         * History/WebBackForwardList.mm:
1450         (-[WebBackForwardList init]):
1451         * WebCoreSupport/WebFrameLoaderClient.mm:
1452         (WebFrameLoaderClient::canCachePage const):
1453         * WebView/WebFrameView.mm:
1454         (-[WebFrameView keyDown:keyDown:]):
1455         * WebView/WebView.mm:
1456         (-[WebView _commonInitializationWithFrameName:groupName:]):
1457         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1458         (-[WebView _loadBackForwardListFromOtherView:]):
1459         (-[WebView initWithCoder:]):
1460         (-[WebView encodeWithCoder:]):
1461         (-[WebView backForwardList]):
1462         (-[WebView setMaintainsBackForwardList:]):
1463
1464 2018-10-15  Timothy Hatcher  <timothy@apple.com>
1465
1466         Add support for prefers-color-scheme media query
1467         https://bugs.webkit.org/show_bug.cgi?id=190499
1468         rdar://problem/45212025
1469
1470         Reviewed by Dean Jackson.
1471
1472         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1473
1474 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1475
1476         Remove unused WebView._globalHistoryItem
1477         https://bugs.webkit.org/show_bug.cgi?id=190601
1478
1479         Reviewed by Chris Dumez.
1480
1481         * WebCoreSupport/WebFrameLoaderClient.h:
1482         * WebCoreSupport/WebFrameLoaderClient.mm:
1483         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1484         * WebView/WebView.mm:
1485         (-[WebView _globalHistoryItem]): Deleted.
1486         (-[WebView _setGlobalHistoryItem:]): Deleted.
1487         * WebView/WebViewData.h:
1488         * WebView/WebViewInternal.h:
1489         * WebView/WebViewPrivate.h:
1490
1491 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1492
1493         Remove unused parameters from FrameLoaderClient::createFrame
1494         https://bugs.webkit.org/show_bug.cgi?id=190587
1495
1496         Reviewed by Chris Dumez.
1497
1498         * WebCoreSupport/WebFrameLoaderClient.h:
1499         * WebCoreSupport/WebFrameLoaderClient.mm:
1500         (WebFrameLoaderClient::createFrame):
1501
1502 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1503
1504         Remove unused WebFrame._loadType
1505         https://bugs.webkit.org/show_bug.cgi?id=190583
1506
1507         Reviewed by Chris Dumez.
1508
1509         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
1510
1511         * WebView/WebFrame.mm:
1512         (toWebFrameLoadType): Deleted.
1513         (-[WebFrame _loadType]): Deleted.
1514         * WebView/WebFramePrivate.h:
1515
1516 2018-10-15  Chris Dumez  <cdumez@apple.com>
1517
1518         Restrict browsing context lookup by name to frames that are related to one another
1519         https://bugs.webkit.org/show_bug.cgi?id=190475
1520
1521         Reviewed by Alex Christensen.
1522
1523         * WebView/WebFrame.mm:
1524         (-[WebFrame findFrameNamed:]):
1525
1526 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1527
1528         Remove InjectedBundle processing of back/forward lists
1529         https://bugs.webkit.org/show_bug.cgi?id=190459
1530
1531         Reviewed by Chris Dumez.
1532
1533         * WebCoreSupport/WebFrameLoaderClient.h:
1534         * WebCoreSupport/WebFrameLoaderClient.mm:
1535         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1536
1537 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1538
1539         [JSC] Remove Option::useAsyncIterator
1540         https://bugs.webkit.org/show_bug.cgi?id=190567
1541
1542         Reviewed by Saam Barati.
1543
1544         * Configurations/FeatureDefines.xcconfig:
1545
1546 2018-10-12  Alex Christensen  <achristensen@webkit.org>
1547
1548         Allow encoding of small enum classes
1549         https://bugs.webkit.org/show_bug.cgi?id=190531
1550
1551         Reviewed by Tim Horton.
1552
1553         * WebCoreSupport/WebFrameLoaderClient.mm:
1554         (-[WebFramePolicyListener dealloc]):
1555
1556 2018-10-11  Keith Rollin  <krollin@apple.com>
1557
1558         CURRENT_ARCH should not be used in Run Script phase.
1559         https://bugs.webkit.org/show_bug.cgi?id=190407
1560         <rdar://problem/45133556>
1561
1562         Reviewed by Alexey Proskuryakov.
1563
1564         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
1565         CURRENT_ARCH is not well-defined during this phase (and may even have
1566         the value "undefined") since this phase is run just once per build
1567         rather than once per supported architecture. Migrate away from
1568         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
1569         performing an operation for each value, or by picking the first entry
1570         in ARCHS and using that as a representative value.
1571
1572         * Configurations/WebKitLegacy.xcconfig: When generating
1573         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
1574         macosx platforms.
1575
1576         * MigrateHeaders.make:
1577         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
1578         generate one for each architecture in ARCHS.
1579
1580 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1581
1582         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
1583         https://bugs.webkit.org/show_bug.cgi?id=190429
1584
1585         Reviewed by Saam Barati.
1586
1587         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
1588
1589         * WebView/WebPDFRepresentation.mm:
1590         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
1591
1592 2018-10-08  Justin Fan  <justin_fan@apple.com>
1593
1594         WebGPU: Rename old WebGPU prototype to WebMetal
1595         https://bugs.webkit.org/show_bug.cgi?id=190325
1596         <rdar://problem/44990443>
1597
1598         Reviewed by Dean Jackson.
1599
1600         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
1601
1602         * Configurations/FeatureDefines.xcconfig:
1603         * WebView/WebPreferenceKeysPrivate.h:
1604         * WebView/WebPreferences.mm:
1605         (+[WebPreferences initialize]):
1606         (-[WebPreferences webMetalEnabled]):
1607         (-[WebPreferences setWebMetalEnabled:]):
1608         (-[WebPreferences webGPUEnabled]): Deleted.
1609         (-[WebPreferences setWebGPUEnabled:]): Deleted.
1610         * WebView/WebPreferencesPrivate.h:
1611         * WebView/WebView.mm:
1612         (-[WebView _preferencesChanged:]):
1613
1614 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
1615
1616         Make <input type=color> a runtime enabled (on-by-default) feature
1617         https://bugs.webkit.org/show_bug.cgi?id=189162
1618
1619         Reviewed by Wenson Hsieh and Tim Horton.
1620
1621         * Configurations/FeatureDefines.xcconfig:
1622
1623 2018-10-07  Dan Bernstein  <mitz@apple.com>
1624
1625         Fixed building with the latest macOS SDK
1626
1627         * Plugins/WebNetscapePluginPackage.mm:
1628         (-[WebNetscapePluginPackage openResourceFile]):
1629         (-[WebNetscapePluginPackage closeResourceFile:]):
1630
1631 2018-10-04  Dan Bernstein  <mitz@apple.com>
1632
1633         More Carbon build-fixing.
1634
1635         * Carbon/CarbonWindowAdapter.mm:
1636         (-[CarbonWindowAdapter _destroyRealWindow:]):
1637         (-[CarbonWindowAdapter _growBoxRect]):
1638
1639 2018-10-04  Dan Bernstein  <mitz@apple.com>
1640
1641         Retried to fix 32-bit macOS builds after r236846.
1642
1643         * WebView/WebHTMLView.mm:
1644         (-[WebHTMLView setMarkedText:selectedRange:]):
1645
1646 2018-10-04  Dan Bernstein  <mitz@apple.com>
1647
1648         Retried to fix 32-bit macOS builds after r236846.
1649
1650         * Carbon/HIWebView.mm:
1651         (ActiveStateChanged):
1652
1653 2018-10-04  Dan Bernstein  <mitz@apple.com>
1654
1655         Tried to fix 32-bit macOS builds after r236846.
1656
1657         * Carbon/HIWebView.mm:
1658         (_NSSelectorForHICommand):
1659
1660 2018-10-04  Dan Bernstein  <mitz@apple.com>
1661
1662         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
1663         https://bugs.webkit.org/show_bug.cgi?id=190250
1664
1665         Reviewed by Andy Estes.
1666
1667         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
1668           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
1669           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
1670           an earlier line set it to YES.
1671
1672         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
1673         changes below.
1674
1675         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
1676           provides some missing method declarations.
1677
1678         * Misc/WebDownload.mm:
1679         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
1680           a deprecated method.
1681
1682         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
1683
1684         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
1685           other code in the file uses a method from it.
1686
1687         * Plugins/WebBaseNetscapePluginView.mm:
1688         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
1689           a deprecated method.
1690
1691         * Plugins/WebPluginController.mm:
1692         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
1693           around use of a selector that may be present in some WebKit client.
1694
1695         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
1696           method declarations.
1697
1698         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
1699           from here.
1700
1701         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
1702           missing method declarations.
1703
1704         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
1705           from here.
1706
1707         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
1708           call from here.
1709         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
1710           an obsolete delegate method for binary compatibility.
1711         (pluginView): Ditto.
1712
1713         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
1714           call from here.
1715
1716         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
1717           WebDeviceOrientationProviderMock protocol.
1718
1719         * WebView/WebDeviceOrientationProviderMock.mm:
1720         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
1721           main @implementation.
1722
1723         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
1724           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
1725
1726         * WebView/WebDynamicScrollBarsView.mm:
1727         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
1728           of a deprecated method.
1729
1730         * WebView/WebHTMLView.mm:
1731         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
1732           selector warning around action methods that are not declared anywhere in WebKit.
1733
1734         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
1735           about implementing this deprecated method.
1736         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
1737         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1738         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1739         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1740         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1741         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1742         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1743         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1744         (-[WebHTMLView doCommandBySelector:]): Ditto.
1745         (-[WebHTMLView insertText:]): Ditto.
1746
1747         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
1748
1749         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
1750
1751         * WebView/WebPDFView.h: Removed previewView ivar.
1752
1753         * WebView/WebPDFView.mm:
1754           Removed declaration of FileInternal category and merged its implementation with the main
1755           implementation.
1756         (-[WebPDFView dealloc]): Removed previewView ivar.
1757         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
1758           exist in macOS versions we support.
1759         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
1760         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
1761           action methods internal to PDFKit.
1762         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
1763         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
1764
1765         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
1766           call on macOS, even though in r86988 we started calling different methods on iOS.
1767
1768         * WebView/WebView.mm:
1769         - Imported headers that declare delegate methods that we call.
1770         - Removed declaration of WebFileInternal category and merged its implementation with the
1771           main implementation.
1772         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
1773           category, which made them impossible to call from the main implementation. Moved those
1774           into the main implementation. One of those had to be declared in a class extension,
1775           because it is called from a method implemented in the WebPrivate category, and that
1776           category’s implementation appears first in the file.
1777
1778         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
1779           around use of obsolete delegate method for binary compatibility.
1780
1781         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
1782
1783 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
1784
1785         Runtime flag and IDL for MediaRecorder
1786         https://bugs.webkit.org/show_bug.cgi?id=190018
1787
1788         Reviewed by Youenn Fablet and Chris Dumez.
1789
1790         * WebView/WebPreferenceKeysPrivate.h:
1791         * WebView/WebPreferences.mm:
1792         (+[WebPreferences initialize]):
1793         (-[WebPreferences mediaRecorderEnabled]):
1794         (-[WebPreferences setMediaRecorderEnabled:]):
1795         * WebView/WebPreferencesPrivate.h:
1796         * WebView/WebView.mm:
1797         (-[WebView _preferencesChanged:]):
1798
1799 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1800
1801         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
1802         https://bugs.webkit.org/show_bug.cgi?id=190238
1803
1804         Reviewed by Antti Koivisto.
1805
1806         Enabled the feature by default.
1807
1808         * WebView/WebPreferences.mm:
1809         (+[WebPreferences initialize]):
1810
1811 2018-10-01  Dean Jackson  <dino@apple.com>
1812
1813         [macOS] Switching to discrete GPU should be done in the UI process
1814         https://bugs.webkit.org/show_bug.cgi?id=189361
1815         <rdar://problem/43949622>
1816
1817         Reviewed by Simon Fraser.
1818
1819         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
1820         not support swapping to the discrete GPU in this configuration.
1821
1822         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
1823         (WebKit::WebSwitchingGPUClient::singleton):
1824         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
1825         * WebView/WebView.mm:
1826         (-[WebView _commonInitializationWithFrameName:groupName:]):
1827
1828 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1829
1830         Remove ParsedURLString
1831         https://bugs.webkit.org/show_bug.cgi?id=190154
1832
1833         Reviewed by Chris Dumez.
1834
1835         * WebView/WebScriptDebugger.mm:
1836         (toNSURL):
1837
1838 2018-10-01  Dean Jackson  <dino@apple.com>
1839
1840         Remove CSS Animation Triggers
1841         https://bugs.webkit.org/show_bug.cgi?id=190175
1842         <rdar://problem/44925626>
1843
1844         Reviewed by Simon Fraser.
1845
1846         * Configurations/FeatureDefines.xcconfig:
1847
1848 2018-10-02  Commit Queue  <commit-queue@webkit.org>
1849
1850         Unreviewed, rolling out r236624 and r236671.
1851         https://bugs.webkit.org/show_bug.cgi?id=190207
1852
1853         The change in r236624 introduced crashes on the bots
1854         (Requested by ryanhaddad on #webkit).
1855
1856         Reverted changesets:
1857
1858         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1859         https://bugs.webkit.org/show_bug.cgi?id=188747
1860         https://trac.webkit.org/changeset/236624
1861
1862         "Unify implementation in VideoFullscreenInterfaceAVKit"
1863         https://bugs.webkit.org/show_bug.cgi?id=190091
1864         https://trac.webkit.org/changeset/236671
1865
1866 2018-10-01  Alex Christensen  <achristensen@webkit.org>
1867
1868         URL should not use TextEncoding internally
1869         https://bugs.webkit.org/show_bug.cgi?id=190111
1870
1871         Reviewed by Andy Estes.
1872
1873         * Misc/WebNSURLExtras.mm:
1874
1875 2018-09-28  Jer Noble  <jer.noble@apple.com>
1876
1877         Refactoring: eliminate raw pointer usage in Fullscreen code
1878         https://bugs.webkit.org/show_bug.cgi?id=188747
1879         <rdar://problem/43541164>
1880
1881         Reviewed by Alex Christensen.
1882
1883         PlaybackSessionInterface no longer has an invalidate() method.
1884
1885         * WebView/WebView.mm:
1886         (-[WebView _clearPlaybackControlsManager]):
1887
1888 2018-09-28  Chris Dumez  <cdumez@apple.com>
1889
1890         Drop support for cross-origin-window-policy header
1891         https://bugs.webkit.org/show_bug.cgi?id=190081
1892
1893         Reviewed by Ryosuke Niwa.
1894
1895         * WebView/WebPreferenceKeysPrivate.h:
1896         * WebView/WebPreferences.mm:
1897         (+[WebPreferences initialize]):
1898         * WebView/WebPreferencesPrivate.h:
1899         * WebView/WebView.mm:
1900         (-[WebView _preferencesChanged:]):
1901
1902 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
1903
1904         Rename createMarkup to serializePreservingVisualAppearance
1905         https://bugs.webkit.org/show_bug.cgi?id=190086
1906
1907         Reviewed by Wenson Hsieh.
1908
1909         * DOM/WebDOMOperations.mm:
1910         (-[DOMRange markupString]):
1911
1912 2018-09-28  Commit Queue  <commit-queue@webkit.org>
1913
1914         Unreviewed, rolling out r236605.
1915         https://bugs.webkit.org/show_bug.cgi?id=190087
1916
1917         caused three API test timeouts (Requested by jernoble on
1918         #webkit).
1919
1920         Reverted changeset:
1921
1922         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1923         https://bugs.webkit.org/show_bug.cgi?id=188747
1924         https://trac.webkit.org/changeset/236605
1925
1926 2018-09-28  Jer Noble  <jer.noble@apple.com>
1927
1928         Refactoring: eliminate raw pointer usage in Fullscreen code
1929         https://bugs.webkit.org/show_bug.cgi?id=188747
1930         <rdar://problem/43541164>
1931
1932         Reviewed by Alex Christensen.
1933
1934         PlaybackSessionInterface no longer has an invalidate() method.
1935
1936         * WebView/WebView.mm:
1937         (-[WebView _clearPlaybackControlsManager]):
1938
1939 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1940
1941         Use enum class in createMarkup arguments
1942         https://bugs.webkit.org/show_bug.cgi?id=190028
1943
1944         Reviewed by Wenson Hsieh.
1945
1946         * DOM/WebDOMOperations.mm:
1947         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
1948         (-[DOMRange markupString]): Ditto.
1949
1950 2018-09-27  Antoine Quint  <graouts@apple.com>
1951
1952         [Web Animations] Turn Web Animations with CSS integration on
1953         https://bugs.webkit.org/show_bug.cgi?id=184819
1954         <rdar://problem/39597337>
1955
1956         Reviewed by Dean Jackson.
1957
1958         * WebView/WebPreferences.mm:
1959         (+[WebPreferences initialize]):
1960
1961 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1962
1963         Selection should work across shadow boundary when initiated by a mouse drag
1964         https://bugs.webkit.org/show_bug.cgi?id=151380
1965         <rdar://problem/24363872>
1966
1967         Reviewed by Wenson Hsieh.
1968
1969         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
1970
1971         * WebView/WebPreferenceKeysPrivate.h:
1972         * WebView/WebPreferences.mm:
1973         (+[WebPreferences initialize]):
1974         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
1975         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
1976         * WebView/WebPreferencesPrivate.h:
1977         * WebView/WebView.mm:
1978         (-[WebView _preferencesChanged:]):
1979
1980 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1981
1982         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
1983         https://bugs.webkit.org/show_bug.cgi?id=189918
1984         Work towards <rdar://problem/44648705>
1985
1986         Reviewed by Tim Horton.
1987
1988         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
1989
1990         * WebView/WebHTMLView.mm:
1991         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1992         (-[WebHTMLView _updateFontPanel]):
1993         * WebView/WebView.mm:
1994         (-[WebView typingAttributes]):
1995
1996 2018-09-17  Darin Adler  <darin@apple.com>
1997
1998         Use OpaqueJSString rather than JSRetainPtr inside WebKit
1999         https://bugs.webkit.org/show_bug.cgi?id=189652
2000
2001         Reviewed by Saam Barati.
2002
2003         * WebView/WebPDFRepresentation.mm:
2004         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2005
2006 2018-09-14  Jer Noble  <jer.noble@apple.com>
2007
2008         Turn SourceBufferChangeTypeEnabled on by default
2009         https://bugs.webkit.org/show_bug.cgi?id=189527
2010
2011         Reviewed by Eric Carlson.
2012
2013         * WebView/WebPreferences.mm:
2014         (+[WebPreferences initialize]):
2015
2016 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2017
2018         Fix an internal build after r235935
2019         https://bugs.webkit.org/show_bug.cgi?id=188996
2020
2021         * Carbon/HIWebView.mm:
2022         (Draw):
2023         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2024
2025 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2026
2027         Add IGNORE_WARNING_.* macros
2028         https://bugs.webkit.org/show_bug.cgi?id=188996
2029
2030         Reviewed by Michael Catanzaro.
2031
2032         * Carbon/CarbonUtils.m:
2033         (PoolCleaner):
2034         * Carbon/CarbonWindowAdapter.mm:
2035         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2036         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2037         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2038         (-[CarbonWindowAdapter _termWindowIfOwner]):
2039         (-[CarbonWindowAdapter _windowMovedToRect:]):
2040         (-[CarbonWindowAdapter setContentView:]):
2041         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2042         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2043         * Carbon/CarbonWindowFrame.m:
2044         (-[CarbonWindowFrame title]):
2045         * Carbon/HIViewAdapter.m:
2046         (+[HIViewAdapter getHIViewForNSView:]):
2047         * Carbon/HIWebView.mm:
2048         (overrideCGContext):
2049         (restoreCGContext):
2050         (Draw):
2051         * DOM/DOM.mm:
2052         * History/WebHistory.mm:
2053         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2054         * History/WebHistoryItem.mm:
2055         (-[WebHistoryItem icon]):
2056         * Misc/WebKitNSStringExtras.mm:
2057         (-[NSString _web_drawAtPoint:font:textColor:]):
2058         * Misc/WebNSImageExtras.m:
2059         (-[NSImage _web_scaleToMaxSize:]):
2060         (-[NSImage _web_dissolveToFraction:]):
2061         * Misc/WebNSPasteboardExtras.mm:
2062         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2063         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2064         * Panels/WebAuthenticationPanel.m:
2065         (-[WebAuthenticationPanel loadNib]):
2066         * Plugins/Hosted/NetscapePluginHostManager.mm:
2067         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2068         (WebKit::NetscapePluginHostManager::didCreateWindow):
2069         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2070         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2071         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2072         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2073         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2074         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2075         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2076         (-[WebHostedNetscapePluginView drawRect:]):
2077         * Plugins/Hosted/WebTextInputWindowController.m:
2078         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2079         * Plugins/WebBaseNetscapePluginView.mm:
2080         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2081         * Plugins/WebNetscapePluginPackage.mm:
2082         (-[WebNetscapePluginPackage _tryLoad]):
2083         * Plugins/WebNetscapePluginView.mm:
2084         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2085         (-[WebNetscapePluginView sendDrawRectEvent:]):
2086         (-[WebNetscapePluginView drawRect:]):
2087         * Plugins/WebPluginController.mm:
2088         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2089         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2090         * WebCoreSupport/PopupMenuMac.mm:
2091         (PopupMenuMac::populate):
2092         * WebCoreSupport/WebAlternativeTextClient.h:
2093         * WebCoreSupport/WebDragClient.mm:
2094         (WebDragClient::startDrag):
2095         * WebCoreSupport/WebFrameLoaderClient.mm:
2096         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2097         (webGetNSImage):
2098         * WebInspector/WebNodeHighlight.mm:
2099         * WebInspector/WebNodeHighlightView.mm:
2100         (-[WebNodeHighlightView drawRect:]):
2101         * WebView/WebClipView.mm:
2102         (-[WebClipView initWithFrame:]):
2103         * WebView/WebFrame.mm:
2104         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2105         (-[WebFrame _drawRect:contentsOnly:]):
2106         (-[WebFrame accessibilityRoot]):
2107         * WebView/WebFullScreenController.mm:
2108         (-[WebFullScreenController enterFullScreen:]):
2109         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2110         (-[WebFullScreenController exitFullScreen]):
2111         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2112         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2113         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2114         * WebView/WebHTMLView.mm:
2115         (-[NSWindow _web_borderView]):
2116         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2117         (-[WebHTMLView _setAsideSubviews]):
2118         (-[WebHTMLView _autoscroll]):
2119         (-[WebHTMLView drawRect:]):
2120         (-[WebHTMLView mouseDown:]):
2121         (-[WebHTMLView mouseDragged:]):
2122         (-[WebHTMLView mouseUp:]):
2123         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2124         (-[WebHTMLView knowsPageRange:]):
2125         (-[WebHTMLView accessibilityHitTest:]):
2126         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2127         (-[WebHTMLView _colorAsString:]):
2128         (-[WebHTMLView copyFont:]):
2129         (-[WebHTMLView _executeSavedKeypressCommands]):
2130         (-[WebHTMLView attachRootLayer:]):
2131         (-[WebHTMLView textStorage]):
2132         (-[WebHTMLView _updateSelectionForInputManager]):
2133         * WebView/WebPDFView.mm:
2134         (_applicationInfoForMIMEType):
2135         (-[WebPDFView centerSelectionInVisibleArea:]):
2136         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2137         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2138         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2139         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2140         * WebView/WebTextCompletionController.mm:
2141         (-[WebTextCompletionController _buildUI]):
2142         (-[WebTextCompletionController _placePopupWindow:]):
2143         * WebView/WebVideoFullscreenController.mm:
2144         * WebView/WebVideoFullscreenHUDWindowController.mm:
2145         (createMediaUIBackgroundView):
2146         * WebView/WebView.mm:
2147         (-[WebTextListTouchBarViewController initWithWebView:]):
2148         (-[WebView _dispatchTileDidDraw:]):
2149         (-[WebView encodeWithCoder:]):
2150         (-[WebView mainFrameIcon]):
2151         (LayerFlushController::flushLayers):
2152         * WebView/WebWindowAnimation.mm:
2153         (setScaledFrameForWindow):
2154
2155 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2156
2157         Remove unused needsDestruction class variables from HashTraits
2158         https://bugs.webkit.org/show_bug.cgi?id=189490
2159
2160         Reviewed by Daniel Bates.
2161
2162         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2163
2164 2018-09-07  Frederic Wang  <fwang@igalia.com>
2165
2166         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2167         https://bugs.webkit.org/show_bug.cgi?id=182230
2168
2169         Reviewed by Simon Fraser.
2170
2171         * DOM/DOMDocument.mm:
2172         (-[DOMDocument scrollingElement]): Use the new name.
2173
2174 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2175
2176         Refactor WebCore::EditAction to be an 8-bit enum class
2177         https://bugs.webkit.org/show_bug.cgi?id=189383
2178
2179         Reviewed by Dan Bernstein.
2180
2181         * WebCoreSupport/WebEditorClient.mm:
2182         (undoNameForEditAction):
2183         * WebView/WebHTMLView.mm:
2184         (-[WebHTMLView pasteFont:]):
2185         (-[WebHTMLView changeFont:]):
2186         (-[WebHTMLView changeAttributes:]):
2187         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2188         (-[WebHTMLView changeColor:]):
2189         * WebView/WebView.mm:
2190         (-[WebView setTypingStyle:]):
2191
2192 2018-09-06  Frederic Wang  <fwang@igalia.com>
2193
2194         Group options of scrollRectToVisible into a struct
2195         https://bugs.webkit.org/show_bug.cgi?id=189352
2196
2197         Reviewed by Simon Fraser.
2198
2199         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2200         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2201         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2202
2203 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2204
2205         [macOS] Cannot change font size at selection until font panel is shown
2206         https://bugs.webkit.org/show_bug.cgi?id=189295
2207         <rdar://problem/35593389>
2208
2209         Reviewed by Ryosuke Niwa.
2210
2211         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2212         WebCore ChangeLog for more details.
2213
2214         * WebView/WebHTMLView.mm:
2215         (-[WebHTMLView changeFont:]):
2216         (-[WebHTMLView changeAttributes:]):
2217         (-[WebHTMLView _originalFontA]): Deleted.
2218         (-[WebHTMLView _originalFontB]): Deleted.
2219         (fontNameForDescription): Deleted.
2220         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2221         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2222         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2223
2224 2018-09-05  Jer Noble  <jer.noble@apple.com>
2225
2226         Add MediaCapabilities as an Experimental Feature
2227         https://bugs.webkit.org/show_bug.cgi?id=189209
2228
2229         Reviewed by Eric Carlson.
2230
2231         RuntimeEnabledFeature -> Setting.
2232
2233         * WebView/WebView.mm:
2234         (-[WebView _preferencesChanged:]):
2235
2236 2018-09-04  Frederic Wang  <fwang@igalia.com>
2237
2238         Add basic support for ScrollIntoViewOptions
2239         https://bugs.webkit.org/show_bug.cgi?id=189258
2240
2241         Reviewed by Simon Fraser.
2242
2243         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2244         header so that this file can build despite the new scrollIntoView function.
2245
2246 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2247
2248         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2249         https://bugs.webkit.org/show_bug.cgi?id=188890
2250         <rdar://problem/43648605>
2251
2252         Reviewed by Tim Horton.
2253
2254         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
2255         more detail.
2256
2257         * WebCoreSupport/WebPlatformStrategies.h:
2258         * WebCoreSupport/WebPlatformStrategies.mm:
2259         (WebPlatformStrategies::allStringsForType):
2260
2261 2018-09-01  Darin Adler  <darin@apple.com>
2262
2263         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2264         https://bugs.webkit.org/show_bug.cgi?id=189072
2265         Reviewed by Dan Bernstein.
2266
2267         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
2268         and declarations for NSURLDownload init methods.
2269
2270         * Misc/WebDownloadInternal.h: Removed.
2271
2272         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
2273         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
2274         "-Wdeprecated-declarations" because the method used here is deprecated.
2275
2276         * WebView/WebView.mm:
2277         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
2278         used here is deprecated.
2279
2280 2018-08-31  Chris Dumez  <cdumez@apple.com>
2281
2282         Assertion hit in ~CompletionHandler() from ~WebFrame()
2283         https://bugs.webkit.org/show_bug.cgi?id=189199
2284         <rdar://problem/42657233>
2285
2286         Reviewed by Youenn Fablet.
2287
2288         * WebCoreSupport/WebFrameLoaderClient.h:
2289         * WebCoreSupport/WebFrameLoaderClient.mm:
2290         (WebFrameLoaderClient::dispatchWillSubmitForm):
2291
2292 2018-08-31  Antti Koivisto  <antti@apple.com>
2293
2294         Replace OptionSet |= and -= operators with add() and remove() functions
2295         https://bugs.webkit.org/show_bug.cgi?id=189169
2296
2297         Reviewed by Anders Carlsson.
2298
2299         * WebView/WebFrame.mm:
2300         (-[WebFrame _drawRect:contentsOnly:]):
2301         * WebView/WebView.mm:
2302         (coreOptions):
2303
2304 2018-08-31  Frederic Wang  <fwang@igalia.com>
2305
2306         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
2307         https://bugs.webkit.org/show_bug.cgi?id=182053
2308
2309         Reviewed by Simon Fraser.
2310
2311         Add developer flag to use standard behavior for scrolling* attributes.
2312
2313         * WebView/WebPreferenceKeysPrivate.h:
2314         * WebView/WebPreferences.mm:
2315         (+[WebPreferences initialize]):
2316         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
2317         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
2318         * WebView/WebPreferencesPrivate.h:
2319         * WebView/WebView.mm:
2320         (-[WebView _preferencesChanged:]):
2321
2322 2018-08-29  Olivia Barnett  <obarnett@apple.com>
2323
2324         Implement the Web Share API
2325         https://bugs.webkit.org/show_bug.cgi?id=171100
2326         <rdar://problem/31751734>
2327
2328         Reviewed by Tim Horton.
2329
2330         * WebCoreSupport/WebChromeClient.h:
2331         * WebCoreSupport/WebChromeClient.mm:
2332         (WebChromeClient::showShareSheet):
2333         Empty declaration of showShareSheet.
2334
2335 2018-08-29  Youenn Fablet  <youenn@apple.com>
2336
2337         Remove WebRTC legacy API implementation
2338         https://bugs.webkit.org/show_bug.cgi?id=189040
2339
2340         Reviewed by Eric Carlson.
2341
2342         * WebView/WebPreferenceKeysPrivate.h:
2343         * WebView/WebPreferences.mm:
2344         (+[WebPreferences initialize]):
2345         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
2346         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
2347         * WebView/WebPreferencesPrivate.h:
2348         * WebView/WebView.mm:
2349         (-[WebView _preferencesChanged:]):
2350
2351 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2352
2353         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
2354         https://bugs.webkit.org/show_bug.cgi?id=189054
2355
2356         Reviewed by Andy Estes.
2357
2358         Remove the pasteboard type argument from readURLFromPasteboard.
2359
2360         * WebCoreSupport/WebPlatformStrategies.h:
2361         * WebCoreSupport/WebPlatformStrategies.mm:
2362         (WebPlatformStrategies::readURLFromPasteboard):
2363
2364 2018-08-27  Keith Rollin  <krollin@apple.com>
2365
2366         Unreviewed build fix -- disable LTO for production builds
2367
2368         * Configurations/Base.xcconfig:
2369
2370 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
2371
2372         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
2373         https://bugs.webkit.org/show_bug.cgi?id=188931
2374
2375         Reviewed by Wenson Hsieh.
2376
2377         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
2378
2379 2018-08-27  Keith Rollin  <krollin@apple.com>
2380
2381         Build system support for LTO
2382         https://bugs.webkit.org/show_bug.cgi?id=187785
2383         <rdar://problem/42353132>
2384
2385         Reviewed by Dan Bernstein.
2386
2387         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
2388         LTO.
2389
2390         * Configurations/Base.xcconfig:
2391         * Configurations/DebugRelease.xcconfig:
2392
2393 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
2394
2395         Pass in IsComposed flag to Event constructors
2396         https://bugs.webkit.org/show_bug.cgi?id=188720
2397         <rdar://problem/43580387>
2398
2399         Reviewed by Simon Fraser.
2400
2401         * WebView/WebPDFView.mm:
2402         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
2403         whether it's simulated or not.
2404
2405 2018-08-23  Mark Lam  <mark.lam@apple.com>
2406
2407         Move vmEntryGlobalObject() to VM from CallFrame.
2408         https://bugs.webkit.org/show_bug.cgi?id=188900
2409         <rdar://problem/43655753>
2410
2411         Reviewed by Michael Saboff.
2412
2413         * WebView/WebScriptDebugger.mm:
2414         (WebScriptDebugger::sourceParsed):
2415
2416 2018-08-23  Andy Estes  <aestes@apple.com>
2417
2418         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
2419         https://bugs.webkit.org/show_bug.cgi?id=188829
2420
2421         Reviewed by Tim Horton.
2422
2423         * Configurations/FeatureDefines.xcconfig:
2424
2425 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2426
2427         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
2428         https://bugs.webkit.org/show_bug.cgi?id=188777
2429
2430         Reviewed by Simon Fraser.
2431
2432         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
2433         being "true" before the code change.
2434
2435         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
2436
2437         * WebView/WebPDFView.mm:
2438         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2439
2440 2018-08-21  Daniel Bates  <dabates@apple.com>
2441
2442         Replace TextCheckingTypeMask with OptionSet
2443         https://bugs.webkit.org/show_bug.cgi?id=188678
2444
2445         Reviewed by Antti Koivisto.
2446
2447         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
2448         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
2449         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
2450         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
2451
2452         * WebCoreSupport/WebEditorClient.h:
2453         * WebCoreSupport/WebEditorClient.mm:
2454         (WebEditorClient::checkTextOfParagraph):
2455         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
2456         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
2457         left as this is more readable and unncessary now that modern compilers like Clang have
2458         diagnostics to catch accidental assignments when equality was intended.
2459         (WebEditorClient::didCheckSucceed):
2460         * WebView/WebView.mm:
2461         (coreTextCheckingType):
2462         (textCheckingResultFromNSTextCheckingResult):
2463
2464 2018-08-21  Daniel Bates  <dabates@apple.com>
2465
2466         [iOS][WK1] Support toggling continuous spell checking from tests
2467         https://bugs.webkit.org/show_bug.cgi?id=188763
2468
2469         Reviewed by Simon Fraser.
2470
2471         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
2472         spell checking from tests in iOS WebKit Legacy.
2473
2474         * WebCoreSupport/WebEditorClient.h:
2475         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
2476         * WebCoreSupport/WebEditorClient.mm:
2477         * WebView/WebView.h:
2478         * WebView/WebView.mm:
2479         (-[WebView toggleContinuousSpellChecking:]):
2480         (-[WebView toggleSmartInsertDelete:]):
2481
2482 2018-08-17  Alex Christensen  <achristensen@webkit.org>
2483
2484         Add some plumbing for safe browsing
2485         https://bugs.webkit.org/show_bug.cgi?id=188709
2486
2487         Reviewed by Tim Horton.
2488
2489         * WebCoreSupport/WebFrameLoaderClient.h:
2490         * WebCoreSupport/WebFrameLoaderClient.mm:
2491         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2492
2493 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
2494
2495         Replace canBubble and cancelable booleans in Event by enum classes
2496         https://bugs.webkit.org/show_bug.cgi?id=188692
2497
2498         Reviewed by Alex Christensen.
2499
2500         * WebView/WebPDFView.mm:
2501         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2502         * WebView/WebView.mm:
2503         (-[WebView _dispatchUnloadEvent]):
2504
2505 2018-08-16  Jer Noble  <jer.noble@apple.com>
2506
2507         Add Experimental Feature support for SourceBuffer.changeType()
2508         https://bugs.webkit.org/show_bug.cgi?id=188626
2509         <rdar://problem/43356021>
2510
2511         Reviewed by Eric Carlson.
2512
2513         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
2514
2515         * WebView/WebPreferenceKeysPrivate.h:
2516         * WebView/WebPreferences.mm:
2517         (+[WebPreferences initialize]):
2518         (-[WebPreferences sourceBufferChangeTypeEnabled]):
2519         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
2520         * WebView/WebPreferencesPrivate.h:
2521         * WebView/WebView.mm:
2522         (-[WebView _preferencesChanged:]):
2523
2524 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
2525
2526         Support drag-and-drop for input[type=color]
2527         https://bugs.webkit.org/show_bug.cgi?id=188464
2528
2529         Reviewed by Wenson Hsieh.
2530
2531         * WebCoreSupport/WebPlatformStrategies.h:
2532         * WebCoreSupport/WebPlatformStrategies.mm:
2533         (WebPlatformStrategies::setColor):
2534
2535 2018-08-15  Tim Horton  <timothy_horton@apple.com>
2536
2537         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
2538         https://bugs.webkit.org/show_bug.cgi?id=188569
2539         <rdar://problem/34201095>
2540
2541         Reviewed by Megan Gardner.
2542
2543         * WebView/WebImmediateActionController.mm:
2544         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2545         Speculative fix; the crashes indicate font is null, but we just checked it,
2546         so it must be getting made null by convertFont:toSize:. Check again!
2547
2548 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2549
2550         Use a 1-byte enum class for TextDirection
2551         https://bugs.webkit.org/show_bug.cgi?id=188350
2552
2553         Reviewed by Simon Fraser.
2554
2555         * WebCoreSupport/PopupMenuMac.mm:
2556         (PopupMenuMac::populate):
2557         (PopupMenuMac::show):
2558         * WebCoreSupport/WebFrameLoaderClient.mm:
2559         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2560         * WebView/WebFrame.mm:
2561         (-[WebFrame _dispatchDidReceiveTitle:]):
2562
2563 2018-08-09  Ali Juma  <ajuma@chromium.org>
2564
2565         Import WPTs for IntersectionObserver
2566         https://bugs.webkit.org/show_bug.cgi?id=188416
2567
2568         Reviewed by Simon Fraser.
2569
2570         * WebView/WebPreferencesPrivate.h:
2571
2572 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
2573
2574         Follow-up build fix for r234685
2575         https://bugs.webkit.org/show_bug.cgi?id=188245
2576
2577         Unreviewed build fix.
2578
2579         * WebCoreSupport/WebSecurityOriginPrivate.h:
2580
2581 2018-08-05  Darin Adler  <darin@apple.com>
2582
2583         [Cocoa] More tweaks and refactoring to prepare for ARC
2584         https://bugs.webkit.org/show_bug.cgi?id=188245
2585
2586         Reviewed by Dan Bernstein.
2587
2588         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
2589
2590         * Carbon/CarbonWindowFrame.m:
2591         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
2592
2593         * DOM/DOM.mm:
2594         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
2595         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
2596         garbage collection so this method isn't useful.
2597
2598         * DOM/DOMXPath.mm:
2599         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
2600         Objective-C garbage collection so this method isn't useful.
2601
2602         * History/WebHistory.mm:
2603         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
2604
2605         * Misc/WebElementDictionary.mm:
2606         (addLookupKey): Use a bridging cast.
2607         (cacheValueForKey): Ditto.
2608         (-[WebElementDictionary _fillCache]): Ditto.
2609         (-[WebElementDictionary objectForKey:]): Ditto.
2610
2611         * Misc/WebKitNSStringExtras.mm:
2612         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
2613         (-[NSString _web_widthWithFont:]): Ditto.
2614         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
2615
2616         * Misc/WebLocalizableStrings.mm:
2617         (WebLocalizedString): Use a bridging cast.
2618
2619         * Misc/WebNSDataExtras.mm:
2620         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
2621         and use CFBridgingRelease instead of calling autorelease directly.
2622         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
2623         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
2624         on the amount of explicit release and autorelease.
2625
2626         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
2627         * Misc/WebNSDictionaryExtras.m:
2628         (-[NSDictionary _webkit_intForKey:]): Deleted.
2629         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
2630         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
2631         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
2632         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
2633         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
2634         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
2635
2636         * Misc/WebStringTruncator.mm:
2637         (fontFromNSFont): Use a bridging cast.
2638
2639         * Plugins/Hosted/NetscapePluginHostManager.mm:
2640         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
2641
2642         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2643         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
2644         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
2645         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
2646         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
2647         * Plugins/Hosted/ProxyInstance.mm:
2648         (WebKit::ProxyInstance::getPropertyNames): Ditto.
2649         * Plugins/WebBasePluginPackage.mm:
2650         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
2651         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2652         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
2653         * Plugins/WebNetscapePluginPackage.mm:
2654         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
2655
2656         * Plugins/WebNetscapePluginView.mm:
2657         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
2658         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
2659         (-[WebNetscapePluginView status:]): Use a bridging cast.
2660         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
2661
2662         * Plugins/WebPluginController.mm:
2663         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
2664
2665         * Plugins/WebPluginDatabase.mm:
2666         (checkCandidate): Use explicit __strong for out argument types.
2667
2668         * Plugins/npapi.mm:
2669         (pluginViewForInstance): Use a bridging cast.
2670
2671         * Storage/WebDatabaseManager.mm:
2672         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
2673         explicit NSNumber and NSDictionary calls.
2674
2675         * WebCoreSupport/WebContextMenuClient.mm:
2676         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
2677
2678         * WebCoreSupport/WebEditorClient.mm:
2679         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
2680         (WebEditorClient::handleInputMethodKeydown): Ditto.
2681
2682         * WebCoreSupport/WebFrameNetworkingContext.mm:
2683         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
2684
2685         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
2686         as a struct rather than an Objective-C class, since that's how it's defined.
2687
2688         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
2689
2690         * WebView/WebFullScreenController.mm:
2691         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
2692         * WebView/WebHTMLView.mm:
2693         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2694         Ditto.
2695         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2696
2697         * WebView/WebImmediateActionController.mm:
2698         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
2699         go down to the document and then back to the frame.
2700         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
2701         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
2702         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
2703
2704         * WebView/WebJSPDFDoc.mm:
2705         (jsPDFDocInitialize): Removed some unneeded type casting.
2706         (jsPDFDocFinalize): Ditto.
2707         (jsPDFDocPrint): Use a bridging cast.
2708
2709         * WebView/WebPDFView.mm:
2710         (_applicationInfoForMIMEType): Use bridging casts.
2711
2712         * WebView/WebPreferences.mm:
2713         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
2714         instead of methods from WebNSDictionaryExtras.
2715         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
2716         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
2717         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
2718         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
2719         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
2720
2721         * WebView/WebView.mm:
2722         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
2723         (-[WebView _addToAllWebViewsSet]): Ditto.
2724         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
2725         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
2726         so it can be called from WebViewData methods.
2727
2728         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
2729         method, _windowVisibilityChanged:.
2730
2731         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
2732         called from WebViewData methods.
2733
2734 2018-08-06  Alex Christensen  <achristensen@webkit.org>
2735
2736         Use enum classes and OptionSets for PaintPhase and PaintBehavior
2737         https://bugs.webkit.org/show_bug.cgi?id=188323
2738
2739         Reviewed by Simon Fraser.
2740
2741         * WebCoreSupport/WebContextMenuClient.mm:
2742         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2743         * WebView/WebFrame.mm:
2744         (-[WebFrame _paintBehaviorForDestinationContext:]):
2745         (-[WebFrame _drawRect:contentsOnly:]):
2746         * WebView/WebHTMLView.mm:
2747         (imageFromRect):
2748         (selectionImage):
2749
2750 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2751
2752         Add support for microtasks in workers
2753         https://bugs.webkit.org/show_bug.cgi?id=188246
2754
2755         Reviewed by Darin Adler.
2756
2757         Rename JSMainThreadExecState.h to JSExecState.h.
2758
2759         * DOM/DOMAttr.mm:
2760         * DOM/DOMBlob.mm:
2761         * DOM/DOMCDATASection.mm:
2762         * DOM/DOMCSSCharsetRule.mm:
2763         * DOM/DOMCSSFontFaceRule.mm:
2764         * DOM/DOMCSSImportRule.mm:
2765         * DOM/DOMCSSMediaRule.mm:
2766         * DOM/DOMCSSPageRule.mm:
2767         * DOM/DOMCSSPrimitiveValue.mm:
2768         * DOM/DOMCSSRule.mm:
2769         * DOM/DOMCSSRuleList.mm:
2770         * DOM/DOMCSSStyleDeclaration.mm:
2771         * DOM/DOMCSSStyleRule.mm:
2772         * DOM/DOMCSSStyleSheet.mm:
2773         * DOM/DOMCSSUnknownRule.mm:
2774         * DOM/DOMCSSValue.mm:
2775         * DOM/DOMCSSValueList.mm:
2776         * DOM/DOMCharacterData.mm:
2777         * DOM/DOMComment.mm:
2778         * DOM/DOMCounter.mm:
2779         * DOM/DOMDocument.mm:
2780         * DOM/DOMDocumentFragment.mm:
2781         * DOM/DOMDocumentType.mm:
2782         * DOM/DOMElement.mm:
2783         * DOM/DOMEvent.mm:
2784         * DOM/DOMFile.mm:
2785         * DOM/DOMFileList.mm:
2786         * DOM/DOMHTML.mm:
2787         * DOM/DOMHTMLAnchorElement.mm:
2788         * DOM/DOMHTMLAppletElement.mm:
2789         * DOM/DOMHTMLAreaElement.mm:
2790         * DOM/DOMHTMLBRElement.mm:
2791         * DOM/DOMHTMLBaseElement.mm:
2792         * DOM/DOMHTMLBaseFontElement.mm:
2793         * DOM/DOMHTMLBodyElement.mm:
2794         * DOM/DOMHTMLButtonElement.mm:
2795         * DOM/DOMHTMLCanvasElement.mm:
2796         * DOM/DOMHTMLCollection.mm:
2797         * DOM/DOMHTMLDListElement.mm:
2798         * DOM/DOMHTMLDirectoryElement.mm:
2799         * DOM/DOMHTMLDivElement.mm:
2800         * DOM/DOMHTMLDocument.mm:
2801         * DOM/DOMHTMLElement.mm:
2802         * DOM/DOMHTMLEmbedElement.mm:
2803         * DOM/DOMHTMLFieldSetElement.mm:
2804         * DOM/DOMHTMLFontElement.mm:
2805         * DOM/DOMHTMLFormElement.mm:
2806         * DOM/DOMHTMLFrameElement.mm:
2807         * DOM/DOMHTMLFrameSetElement.mm:
2808         * DOM/DOMHTMLHRElement.mm:
2809         * DOM/DOMHTMLHeadElement.mm:
2810         * DOM/DOMHTMLHeadingElement.mm:
2811         * DOM/DOMHTMLHtmlElement.mm:
2812         * DOM/DOMHTMLIFrameElement.mm:
2813         * DOM/DOMHTMLImageElement.mm:
2814         * DOM/DOMHTMLInputElement.mm:
2815         * DOM/DOMHTMLLIElement.mm:
2816         * DOM/DOMHTMLLabelElement.mm:
2817         * DOM/DOMHTMLLegendElement.mm:
2818         * DOM/DOMHTMLLinkElement.mm:
2819         * DOM/DOMHTMLMapElement.mm:
2820         * DOM/DOMHTMLMarqueeElement.mm:
2821         * DOM/DOMHTMLMediaElement.mm:
2822         * DOM/DOMHTMLMenuElement.mm:
2823         * DOM/DOMHTMLMetaElement.mm:
2824         * DOM/DOMHTMLModElement.mm:
2825         * DOM/DOMHTMLOListElement.mm:
2826         * DOM/DOMHTMLObjectElement.mm:
2827         * DOM/DOMHTMLOptGroupElement.mm:
2828         * DOM/DOMHTMLOptionElement.mm:
2829         * DOM/DOMHTMLOptionsCollection.mm:
2830         * DOM/DOMHTMLParagraphElement.mm:
2831         * DOM/DOMHTMLParamElement.mm:
2832         * DOM/DOMHTMLPreElement.mm:
2833         * DOM/DOMHTMLQuoteElement.mm:
2834         * DOM/DOMHTMLScriptElement.mm:
2835         * DOM/DOMHTMLSelectElement.mm:
2836         * DOM/DOMHTMLStyleElement.mm:
2837         * DOM/DOMHTMLTableCaptionElement.mm:
2838         * DOM/DOMHTMLTableCellElement.mm:
2839         * DOM/DOMHTMLTableColElement.mm:
2840         * DOM/DOMHTMLTableElement.mm:
2841         * DOM/DOMHTMLTableRowElement.mm:
2842         * DOM/DOMHTMLTableSectionElement.mm:
2843         * DOM/DOMHTMLTextAreaElement.mm:
2844         * DOM/DOMHTMLTitleElement.mm:
2845         * DOM/DOMHTMLUListElement.mm:
2846         * DOM/DOMHTMLVideoElement.mm:
2847         * DOM/DOMImplementation.mm:
2848         * DOM/DOMKeyboardEvent.mm:
2849         * DOM/DOMMediaError.mm:
2850         * DOM/DOMMediaList.mm:
2851         * DOM/DOMMouseEvent.mm:
2852         * DOM/DOMMutationEvent.mm:
2853         * DOM/DOMNamedNodeMap.mm:
2854         * DOM/DOMNode.mm:
2855         * DOM/DOMNodeIterator.mm:
2856         * DOM/DOMNodeList.mm:
2857         * DOM/DOMOverflowEvent.mm:
2858         * DOM/DOMProcessingInstruction.mm:
2859         * DOM/DOMProgressEvent.mm:
2860         * DOM/DOMRGBColor.mm:
2861         * DOM/DOMRange.mm:
2862         * DOM/DOMRect.mm:
2863         * DOM/DOMStyleSheet.mm:
2864         * DOM/DOMStyleSheetList.mm:
2865         * DOM/DOMText.mm:
2866         * DOM/DOMTextEvent.mm:
2867         * DOM/DOMTimeRanges.mm:
2868         * DOM/DOMTokenList.mm:
2869         * DOM/DOMTreeWalker.mm:
2870         * DOM/DOMUIEvent.mm:
2871         * DOM/DOMWheelEvent.mm:
2872         * DOM/DOMXPathExpression.mm:
2873         * DOM/DOMXPathResult.mm:
2874         * DOM/ObjCEventListener.mm:
2875
2876 2018-08-03  Alex Christensen  <achristensen@webkit.org>
2877
2878         Fix spelling of "overridden"
2879         https://bugs.webkit.org/show_bug.cgi?id=188315
2880
2881         Reviewed by Darin Adler.
2882
2883         * Misc/WebKitVersionChecks.mm:
2884         (setWebKitLinkTimeVersion):
2885         (WebKitLinkTimeVersion):
2886         * Plugins/WebBaseNetscapePluginView.mm:
2887         (-[WebBaseNetscapePluginView handleMouseMoved:]):
2888         * WebCoreSupport/PopupMenuMac.mm:
2889         (PopupMenuMac::populate):
2890
2891 2018-08-01  Nan Wang  <n_wang@apple.com>
2892
2893         AX: AOM: Add ARIA IDL Attribute Reflection
2894         https://bugs.webkit.org/show_bug.cgi?id=184676
2895         <rdar://problem/39476882>
2896
2897         Reviewed by Chris Fleizach.
2898
2899         * WebView/WebPreferenceKeysPrivate.h:
2900         * WebView/WebPreferences.mm:
2901         (+[WebPreferences initialize]):
2902         (-[WebPreferences ariaReflectionEnabled]):
2903         (-[WebPreferences setAriaReflectionEnabled:]):
2904         * WebView/WebPreferencesPrivate.h:
2905         * WebView/WebView.mm:
2906         (-[WebView _preferencesChanged:]):
2907
2908 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
2909
2910         Shrink GraphicsLayerCA
2911         https://bugs.webkit.org/show_bug.cgi?id=188141
2912
2913         Reviewed by Zalan Bujtas.
2914
2915         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
2916         * moving all the clone-related stuff into the lazily-allocated m_layerClones
2917         * moving all the animation-related stuff into the lazily-allocated m_animations
2918         * making enums be 8-bit
2919         * re-ordering data members
2920
2921         * WebView/WebView.mm:
2922         (-[WebView _setMediaLayer:forPluginView:]):
2923
2924 2018-07-30  Rob Buis  <rbuis@igalia.com>
2925
2926         Merge PlatformCookieJar functions into NetworkStorageSession
2927         https://bugs.webkit.org/show_bug.cgi?id=188137
2928
2929         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
2930
2931         Reviewed by Alex Christensen.
2932
2933         * WebCoreSupport/WebPlatformStrategies.mm:
2934         (WebPlatformStrategies::cookiesForDOM):
2935         (WebPlatformStrategies::setCookiesFromDOM):
2936         (WebPlatformStrategies::cookiesEnabled):
2937         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2938         (WebPlatformStrategies::getRawCookies):
2939         (WebPlatformStrategies::deleteCookie):
2940         * WebView/WebPreferences.mm:
2941         (+[WebPreferences _clearNetworkLoaderSession]):
2942
2943 2018-07-28  Darin Adler  <darin@apple.com>
2944
2945         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
2946         https://bugs.webkit.org/show_bug.cgi?id=188140
2947
2948         Reviewed by Sam Weinig.
2949
2950         * WebView/WebImmediateActionController.mm:
2951         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
2952         new DictionaryLookup function that returns a tuple instead of using an out argument.
2953
2954 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
2955
2956         [INTL] Remove INTL sub-feature compile flags
2957         https://bugs.webkit.org/show_bug.cgi?id=188081
2958
2959         Reviewed by Michael Catanzaro.
2960
2961         * Configurations/FeatureDefines.xcconfig:
2962
2963 2018-07-26  Commit Queue  <commit-queue@webkit.org>
2964
2965         Unreviewed, rolling out r234181 and r234189.
2966         https://bugs.webkit.org/show_bug.cgi?id=188075
2967
2968         These are not needed right now (Requested by thorton on
2969         #webkit).
2970
2971         Reverted changesets:
2972
2973         "Enable Web Content Filtering on watchOS"
2974         https://bugs.webkit.org/show_bug.cgi?id=187979
2975         https://trac.webkit.org/changeset/234181
2976
2977         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
2978         https://bugs.webkit.org/show_bug.cgi?id=187985
2979         https://trac.webkit.org/changeset/234189
2980
2981 2018-07-26  Timothy Hatcher  <timothy@apple.com>
2982
2983         Use the Page's appearance when converting pasteboard attributed strings.
2984         https://bugs.webkit.org/show_bug.cgi?id=188067
2985         rdar://problem/42632246
2986
2987         Reviewed by Wenson Hsieh.
2988
2989         * WebCoreSupport/WebEditorClient.mm:
2990         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
2991
2992 2018-07-25  Chris Dumez  <cdumez@apple.com>
2993
2994         navigator.userAgent may return outdated value after webView.customUserAgent is set
2995         https://bugs.webkit.org/show_bug.cgi?id=188009
2996         <rdar://problem/42566456>
2997
2998         Reviewed by Alex Christensen.
2999
3000         Let the page know when the user agent changes.
3001
3002         * WebView/WebView.mm:
3003         (-[WebView _preferencesChanged:]):
3004         (-[WebView setApplicationNameForUserAgent:]):
3005         (-[WebView _invalidateUserAgentCache]):
3006         (-[WebView setCustomUserAgent:]):
3007         * WebView/WebViewInternal.h:
3008
3009 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3010
3011         Enable Web Content Filtering on watchOS
3012         https://bugs.webkit.org/show_bug.cgi?id=187979
3013         <rdar://problem/42559346>
3014
3015         Reviewed by Wenson Hsieh.
3016
3017         * Configurations/FeatureDefines.xcconfig:
3018
3019 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3020
3021         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3022         https://bugs.webkit.org/show_bug.cgi?id=187846
3023
3024         Reviewed by Simon Fraser.
3025
3026         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3027
3028         * WebView/WebHTMLView.mm:
3029         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3030         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3031
3032 2018-07-11  Dean Jackson  <dino@apple.com>
3033
3034         Allow removal of white backgrounds
3035         https://bugs.webkit.org/show_bug.cgi?id=187574
3036         <rdar://problem/41146792>
3037
3038         Reviewed by Simon Fraser.
3039
3040         Add a new WebPreference for punching out white backgrounds.
3041
3042         * WebView/WebPreferenceKeysPrivate.h:
3043         * WebView/WebPreferences.mm:
3044         (+[WebPreferences initialize]):
3045         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
3046         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
3047         * WebView/WebPreferencesPrivate.h:
3048         * WebView/WebView.mm:
3049         (-[WebView _preferencesChanged:]):
3050
3051 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
3052
3053         Ensure WebKit stack is ad-hoc signed
3054         https://bugs.webkit.org/show_bug.cgi?id=187667
3055
3056         Reviewed by Alexey Proskuryakov.
3057
3058         * Configurations/Base.xcconfig:
3059
3060 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
3061
3062         REGRESSION (231276): Attempting to copy an image fails
3063         https://bugs.webkit.org/show_bug.cgi?id=187212
3064         <rdar://problem/41540074>
3065
3066         Reviewed by Ryosuke Niwa.
3067
3068         Renamed methods to make it clear that one URL and one title are being passed in.
3069
3070         * WebCoreSupport/WebPlatformStrategies.h:
3071         * WebCoreSupport/WebPlatformStrategies.mm:
3072         (WebPlatformStrategies::setURL):
3073
3074 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
3075
3076         Disable cross-origin-window-policy by default
3077         https://bugs.webkit.org/show_bug.cgi?id=187509
3078
3079         Reviewed by Chris Dumez.
3080
3081         * WebView/WebPreferences.mm:
3082         (+[WebPreferences initialize]):
3083
3084 2018-07-09  Timothy Hatcher  <timothy@apple.com>
3085
3086         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3087         https://bugs.webkit.org/show_bug.cgi?id=187425
3088         rdar://problem/39948240
3089
3090         Reviewed by Tim Horton.
3091
3092         * WebView/WebView.mm:
3093         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3094         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3095         a call in this method to setUseDarkAppearance.
3096         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3097         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3098         (-[WebView _updateDefaultAppearance]): Deleted.
3099         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3100
3101 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
3102
3103         Shrink various loading-related enums to shrink CachedResource
3104         https://bugs.webkit.org/show_bug.cgi?id=187443
3105
3106         Reviewed by Chris Dumez.
3107
3108         * WebCoreSupport/WebFrameLoaderClient.mm:
3109         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3110         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
3111         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3112         (WebFrameLoaderClient::dispatchWillSendRequest):
3113         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3114         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3115         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3116         (WebFrameLoaderClient::updateGlobalHistory):
3117         (WebFrameLoaderClient::canHandleRequest const):
3118         * WebView/WebDataSource.mm:
3119         (-[WebDataSource initialRequest]):
3120         (-[WebDataSource request]):
3121
3122 2018-07-09  Commit Queue  <commit-queue@webkit.org>
3123
3124         Unreviewed, rolling out r233612.
3125         https://bugs.webkit.org/show_bug.cgi?id=187475
3126
3127         Revision caused the api test LinkColorWithSystemAppearance to
3128         fail on all systems. (Requested by Truitt on #webkit).
3129
3130         Reverted changeset:
3131
3132         "Semantic colors don't update when accessibility Increase
3133         Contrast mode is enabled."
3134         https://bugs.webkit.org/show_bug.cgi?id=187425
3135         https://trac.webkit.org/changeset/233612
3136
3137 2018-07-06  Timothy Hatcher  <timothy@apple.com>
3138
3139         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3140         https://bugs.webkit.org/show_bug.cgi?id=187425
3141         rdar://problem/39948240
3142
3143         Reviewed by Tim Horton.
3144
3145         * WebView/WebView.mm:
3146         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3147         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3148         a call in this method to setUseDarkAppearance.
3149         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3150         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3151         (-[WebView _updateDefaultAppearance]): Deleted.
3152         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3153
3154 2018-07-05  Timothy Hatcher  <timothy@apple.com>
3155
3156         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
3157         https://bugs.webkit.org/show_bug.cgi?id=187369
3158         rdar://problem/41870420
3159
3160         Reviewed by Tim Horton.
3161
3162         * WebView/WebMediaPlaybackTargetPicker.mm:
3163         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3164         * WebView/WebView.mm:
3165         (-[WebView _commonInitializationWithFrameName:groupName:]):
3166         (-[WebView _effectiveAppearanceIsDark]):
3167         (-[WebView _updateDefaultAppearance]):
3168         (-[WebView _defaultAppearance]): Deleted.
3169
3170 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
3171
3172         Youtube video pages crash after a couple of minutes
3173         https://bugs.webkit.org/show_bug.cgi?id=187316
3174
3175         Reviewed by Antti Koivisto.
3176
3177         * WebView/WebView.mm:
3178         (-[WebView _preferencesChanged:]):
3179
3180 2018-07-04  Tim Horton  <timothy_horton@apple.com>
3181
3182         Introduce PLATFORM(IOSMAC)
3183         https://bugs.webkit.org/show_bug.cgi?id=187315
3184
3185         Reviewed by Dan Bernstein.
3186
3187         * Configurations/Base.xcconfig:
3188         * Configurations/FeatureDefines.xcconfig:
3189
3190 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3191
3192         [iOS] DataTransfer.getData always returns the empty string when dropping text
3193         https://bugs.webkit.org/show_bug.cgi?id=187130
3194         <rdar://problem/41014117>
3195
3196         Reviewed by Ryosuke Niwa.
3197
3198         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
3199
3200         * WebCoreSupport/WebPlatformStrategies.h:
3201         * WebCoreSupport/WebPlatformStrategies.mm:
3202         (WebPlatformStrategies::allPasteboardItemInfo):
3203
3204 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
3205
3206         [Mac] AirPlay picker uses incorrect theme in Dark mode
3207         https://bugs.webkit.org/show_bug.cgi?id=187054
3208         <rdar://problem/41291093>
3209
3210         Reviewed by Timothy Hatcher.
3211
3212         * WebView/WebMediaPlaybackTargetPicker.mm:
3213         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
3214
3215 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3216
3217         [WTF] Add user-defined literal for ASCIILiteral
3218         https://bugs.webkit.org/show_bug.cgi?id=186839
3219
3220         Reviewed by Darin Adler.
3221
3222         * DOM/ExceptionHandlers.mm:
3223         (raiseDOMErrorException):
3224         * Plugins/Hosted/ProxyInstance.mm:
3225         (WebKit::ProxyInstance::invokeMethod):
3226         * Storage/WebDatabaseProvider.mm:
3227         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
3228
3229 2018-06-22  Timothy Hatcher  <timothy@apple.com>
3230
3231         Recalc styles every time defaultAppearance changes.
3232         https://bugs.webkit.org/show_bug.cgi?id=186866
3233         rdar://problem/41309805
3234
3235         Reviewed by Tim Horton.
3236
3237         * WebView/WebView.mm:
3238         (-[WebView _updateDefaultAppearance]):
3239         (-[WebView _setUseSystemAppearance:]):
3240         (-[WebView _useSystemAppearance]):
3241
3242 2018-06-20  Darin Adler  <darin@apple.com>
3243
3244         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
3245         https://bugs.webkit.org/show_bug.cgi?id=186875
3246
3247         Reviewed by Anders Carlsson.
3248
3249         * WebView/WebHTMLView.mm:
3250         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
3251         to write te file to.
3252         * WebView/WebPreferences.mm:
3253         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
3254         * WebView/WebView.mm:
3255         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
3256
3257 2018-06-12  Darin Adler  <darin@apple.com>
3258
3259         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
3260         https://bugs.webkit.org/show_bug.cgi?id=186526
3261
3262         Reviewed by Anders Carlsson.
3263
3264         * Plugins/Hosted/NetscapePluginHostManager.mm:
3265         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
3266
3267         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3268         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
3269         assignment rather than adoptNS/leakRef.
3270         * Plugins/WebNetscapePluginView.mm:
3271         (-[WebNetscapePluginView createPlugin]): Ditto.
3272
3273         * WebCoreSupport/WebContextMenuClient.mm:
3274         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
3275         RetainPtr::autorelease; no need to autorelease just to pass something as a function
3276         argument, so use RetainPtr::get instead.
3277
3278         * WebView/WebHTMLView.mm:
3279         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
3280         No need to autorelease the result when the return type is RetainPtr.
3281
3282         * WebView/WebPDFRepresentation.mm:
3283         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
3284
3285 2018-06-13  Youenn Fablet  <youenn@apple.com>
3286
3287         Supported plugin check should be based on plugin identifier
3288         https://bugs.webkit.org/show_bug.cgi?id=186578
3289         <rdar://problem/40523828>
3290
3291         Reviewed by Darin Adler.
3292
3293         * WebCoreSupport/WebPluginInfoProvider.h:
3294         * WebCoreSupport/WebPluginInfoProvider.mm:
3295         (WebPluginInfoProvider::pluginInfo):
3296         (WebPluginInfoProvider::webVisiblePluginInfo):
3297
3298 2018-06-13  Chris Dumez  <cdumez@apple.com>
3299
3300         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
3301         https://bugs.webkit.org/show_bug.cgi?id=186545
3302
3303         Reviewed by Brady Eidson.
3304
3305         Update client delegate now that parameter type has changed.
3306
3307         * WebCoreSupport/WebFrameLoaderClient.h:
3308         * WebCoreSupport/WebFrameLoaderClient.mm:
3309         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3310
3311 2018-06-11  Tim Horton  <timothy_horton@apple.com>
3312
3313         Link drag image is inconsistently unreadable in dark mode
3314         https://bugs.webkit.org/show_bug.cgi?id=186472
3315
3316         Reviewed by Timothy Hatcher.
3317
3318         * WebView/WebView.mm:
3319         (-[WebView _defaultAppearance]):
3320         Make defaultAppearance accurate even if useSystemAppearance is false.
3321         Some parts of WebKit (like the link drag image, but also context menus)
3322         want to be able to follow the system appearance regardless of whether
3323         the view or content has opted in.
3324
3325 2018-06-11  Chris Dumez  <cdumez@apple.com>
3326
3327         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
3328         https://bugs.webkit.org/show_bug.cgi?id=186441
3329
3330         Reviewed by Brady Eidson.
3331
3332         Rename existing flag to something a bit more generic, now that it is used for
3333         more things than bypassing the navigation policy check.
3334
3335         * WebView/WebView.mm:
3336         (-[WebView _loadBackForwardListFromOtherView:]):
3337         (-[WebView goToBackForwardItem:]):
3338
3339 2018-06-09  Dan Bernstein  <mitz@apple.com>
3340
3341         [Xcode] Clean up and modernize some build setting definitions
3342         https://bugs.webkit.org/show_bug.cgi?id=186463
3343
3344         Reviewed by Sam Weinig.
3345
3346         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
3347         * Configurations/DebugRelease.xcconfig: Ditto.
3348         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
3349           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
3350         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
3351         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
3352           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
3353         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
3354
3355 2018-06-08  Darin Adler  <darin@apple.com>
3356
3357         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
3358         https://bugs.webkit.org/show_bug.cgi?id=186436
3359
3360         Reviewed by Anders Carlsson.
3361
3362         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
3363         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
3364         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
3365         (PoolCleaner): Ditto.
3366
3367         * History/WebHistory.mm:
3368         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3369         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
3370         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
3371         now hardly used if at all.
3372         * WebView/WebView.mm:
3373         (-[WebView rectsForTextMatches]): Ditto.
3374
3375 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3376
3377         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
3378         https://bugs.webkit.org/show_bug.cgi?id=186442
3379         <rdar://problem/40879364>
3380
3381         Reviewed by Tim Horton.
3382
3383         * Configurations/FeatureDefines.xcconfig:
3384
3385 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
3386
3387         [Datalist] Allow TextFieldInputType to show and hide suggestions
3388         https://bugs.webkit.org/show_bug.cgi?id=186151
3389
3390         Reviewed by Tim Horton.
3391
3392         * WebCoreSupport/WebChromeClient.h:
3393         * WebCoreSupport/WebChromeClient.mm:
3394         (WebChromeClient::createDataListSuggestionPicker):
3395
3396 2018-06-07  Chris Dumez  <cdumez@apple.com>
3397
3398         Add base class to get WeakPtrFactory member and avoid some boilerplate code
3399         https://bugs.webkit.org/show_bug.cgi?id=186407
3400
3401         Reviewed by Brent Fulgham.
3402
3403         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
3404         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
3405         This also gets rid of old-style createWeakPtr() methods in favor of the newer
3406         makeWeakPtr().
3407
3408         * WebCoreSupport/WebEditorClient.h:
3409         * WebCoreSupport/WebEditorClient.mm:
3410         (WebEditorClient::requestCandidatesForSelection):
3411
3412 2018-06-05  Chris Dumez  <cdumez@apple.com>
3413
3414         Regression(r232082): Websites get loaded inside of Messages App chat transcript
3415         https://bugs.webkit.org/show_bug.cgi?id=186331
3416         <rdar://problem/40735446>
3417
3418         Reviewed by Darin Adler.
3419
3420         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
3421         but does not call use / ignore on the listener, then we would do "use" by default.
3422         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
3423         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
3424         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
3425         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
3426         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
3427         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
3428         and Box.app is still working properly.
3429
3430         * WebCoreSupport/WebFrameLoaderClient.h:
3431         * WebCoreSupport/WebFrameLoaderClient.mm:
3432         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3433         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3434         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3435         (WebFrameLoaderClient::dispatchWillSubmitForm):
3436         (WebFrameLoaderClient::setUpPolicyListener):
3437         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
3438         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
3439         (-[WebFramePolicyListener dealloc]):
3440         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
3441         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
3442
3443 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3444
3445         Adjust compile and runtime flags to match shippable state of features
3446         https://bugs.webkit.org/show_bug.cgi?id=186319
3447         <rdar://problem/40352045>
3448
3449         Reviewed by Maciej Stachowiak, Jon Lee, and others.
3450
3451         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
3452         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
3453         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
3454         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
3455         Cocoa builds.
3456
3457 2018-06-05  Timothy Hatcher  <timothy@apple.com>
3458
3459         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
3460
3461         https://bugs.webkit.org/show_bug.cgi?id=186323
3462         rdar://problem/38382252
3463
3464         Reviewed by Tim Horton.
3465
3466         * WebView/WebView.mm:
3467         (-[WebView _defaultAppearance]):
3468
3469 2018-06-05  Brent Fulgham  <bfulgham@appl