0fe6d8b3d62c18039f93de7e2ca8eb60a8a0a3c3
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
2
3         Protect against invalid mach ports returned by mach_port_request_notification
4         https://bugs.webkit.org/show_bug.cgi?id=184106
5         <rdar://problem/37865316>
6
7         Reviewed by Chris Dumez.
8
9         * Plugins/Hosted/NetscapePluginHostProxy.mm:
10         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
11         and clean up if it experienced an error.
12         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
13
14 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
15
16         Avoid uninitialized mach ports
17         https://bugs.webkit.org/show_bug.cgi?id=184090
18         <rdar://problem/37261129>
19
20         Reviewed by Chris Dumez.
21
22         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
23         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
24         there is a potential for us to try to use invalid ports.
25
26         We should always check return values, and ensure that the mach port variables we seek to initialize are
27         kept in a valid state.
28
29         Reviewed by Chris Dumez.
30
31         * Plugins/Hosted/NetscapePluginHostManager.h:
32         * Plugins/Hosted/NetscapePluginHostManager.mm:
33         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
34         port is passed to an API function.
35         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
36         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
37         * Plugins/Hosted/NetscapePluginHostProxy.h:
38         * Plugins/Hosted/NetscapePluginHostProxy.mm:
39         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
40         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
41         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
42         (WKPCStatusText): Ditto.
43         (WKPCLoadURL): Ditto.
44         (WKPCCancelLoadURL): Ditto.
45         (WKPCInvalidateRect): Ditto.
46         (WKPCGetScriptableNPObjectReply): Ditto.
47         (WKPCBooleanReply): Ditto.
48         (WKPCBooleanAndDataReply): Ditto.
49         (WKPCInstantiatePluginReply): Ditto.
50         (WKPCGetWindowNPObject): Ditto.
51         (WKPCGetPluginElementNPObject): Ditto.
52         (WKPCForgetBrowserObject): Ditto.
53         (WKPCEvaluate): Ditto.
54         (WKPCGetStringIdentifier): Ditto.
55         (WKPCGetIntIdentifier): Ditto.
56         (WKPCInvoke): Ditto.
57         (WKPCInvokeDefault): Ditto.
58         (WKPCConstruct): Ditto.
59         (WKPCGetProperty): Ditto.
60         (WKPCSetProperty): Ditto.
61         (WKPCRemoveProperty): Ditto.
62         (WKPCHasProperty): Ditto.
63         (WKPCHasMethod): Ditto.
64         (WKPCIdentifierInfo): Ditto.
65         (WKPCEnumerate): Ditto.
66         (WKPCSetMenuBarVisible): Ditto.
67         (WKPCSetFullscreenWindowIsShowing): Ditto.
68         (WKPCSetModal): Ditto.
69         (WKPCGetCookies): Ditto.
70         (WKPCGetProxy): Ditto.
71         (WKPCSetCookies): Ditto.
72         (WKPCGetAuthenticationInfo): Ditto.
73         (WKPCConvertPoint): Ditto.
74         (WKPCLayerHostingModeChanged): Ditto.
75         (WKPCSetException): Ditto.
76
77 2018-03-26  Tim Horton  <timothy_horton@apple.com>
78
79         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
80         https://bugs.webkit.org/show_bug.cgi?id=184030
81         <rdar://problem/38895281>
82
83         Reviewed by Dan Bernstein.
84
85         * Configurations/Base.xcconfig:
86
87 2018-03-26  Chris Dumez  <cdumez@apple.com>
88
89         Use SecurityOriginData more consistently in Service Worker code
90         https://bugs.webkit.org/show_bug.cgi?id=183969
91
92         Reviewed by Darin Adler.
93
94         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
95
96         * Storage/WebDatabaseManager.mm:
97         (-[WebDatabaseManager databasesWithOrigin:]):
98         (-[WebDatabaseManager deleteOrigin:]):
99         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
100         * Storage/WebDatabaseQuotaManager.mm:
101         (-[WebDatabaseQuotaManager usage]):
102         (-[WebDatabaseQuotaManager quota]):
103         (-[WebDatabaseQuotaManager setQuota:]):
104         * Storage/WebStorageManager.mm:
105         (-[WebStorageManager deleteOrigin:]):
106         * WebCoreSupport/WebSecurityOrigin.mm:
107         (-[WebSecurityOrigin databaseIdentifier]):
108         (-[WebSecurityOrigin usage]):
109         (-[WebSecurityOrigin quota]):
110         (-[WebSecurityOrigin setQuota:]):
111
112 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
113
114         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
115         https://bugs.webkit.org/show_bug.cgi?id=183911
116         <rdar://problem/38762306>
117
118         Reviewed by Youenn Fablet.
119
120         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
121
122         * WebView/WebView.mm:
123         (+[WebView initialize]):
124
125 2018-03-26  Alex Christensen  <achristensen@webkit.org>
126
127         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
128         https://bugs.webkit.org/show_bug.cgi?id=183965
129
130         Reviewed by Chris Dumez.
131
132         * WebCoreSupport/WebFrameLoaderClient.h:
133         * WebCoreSupport/WebFrameLoaderClient.mm:
134         (WebFrameLoaderClient::willCacheResponse const):
135
136 2018-03-25  Commit Queue  <commit-queue@webkit.org>
137
138         Unreviewed, rolling out r229954.
139         https://bugs.webkit.org/show_bug.cgi?id=184000
140
141         Caused many layout tests to crash on Apple High Sierra,
142         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
143         by dydz on #webkit).
144
145         Reverted changeset:
146
147         "Use SecurityOriginData more consistently in Service Worker
148         code"
149         https://bugs.webkit.org/show_bug.cgi?id=183969
150         https://trac.webkit.org/changeset/229954
151
152 2018-03-24  Chris Dumez  <cdumez@apple.com>
153
154         Use SecurityOriginData more consistently in Service Worker code
155         https://bugs.webkit.org/show_bug.cgi?id=183969
156
157         Reviewed by Darin Adler.
158
159         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
160
161         * Storage/WebDatabaseManager.mm:
162         (-[WebDatabaseManager databasesWithOrigin:]):
163         (-[WebDatabaseManager deleteOrigin:]):
164         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
165         * Storage/WebDatabaseQuotaManager.mm:
166         (-[WebDatabaseQuotaManager usage]):
167         (-[WebDatabaseQuotaManager quota]):
168         (-[WebDatabaseQuotaManager setQuota:]):
169         * Storage/WebStorageManager.mm:
170         (-[WebStorageManager deleteOrigin:]):
171         * WebCoreSupport/WebSecurityOrigin.mm:
172         (-[WebSecurityOrigin databaseIdentifier]):
173         (-[WebSecurityOrigin usage]):
174         (-[WebSecurityOrigin quota]):
175         (-[WebSecurityOrigin setQuota:]):
176
177 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
178
179         Fix the build
180
181         * WebView/WebView.mm:
182
183 2018-03-23  Tim Horton  <timothy_horton@apple.com>
184
185         Fix the build with no pasteboard
186         https://bugs.webkit.org/show_bug.cgi?id=183973
187
188         Reviewed by Dan Bernstein.
189
190         * Configurations/FeatureDefines.xcconfig:
191         * WebView/WebView.mm:
192         (-[WebView _requestStartDataInteraction:globalPosition:]):
193         (-[WebView _getDataInteractionData]):
194         (-[WebView _dataOperationTextIndicator]):
195         (-[WebView _dragSourceAction]):
196         (-[WebView _draggedLinkTitle]):
197         (-[WebView _draggedLinkURL]):
198         (-[WebView _draggedElementBounds]):
199         (-[WebView _enteredDataInteraction:client:global:operation:]):
200         (-[WebView _updatedDataInteraction:client:global:operation:]):
201         (-[WebView _exitedDataInteraction:client:global:operation:]):
202         (-[WebView _performDataInteraction:client:global:operation:]):
203         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
204         (-[WebView _endedDataInteraction:global:]):
205         (-[WebView _dataInteractionCaretRect]):
206         * WebView/WebViewPrivate.h:
207
208 2018-03-23  Tim Horton  <timothy_horton@apple.com>
209
210         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
211         https://bugs.webkit.org/show_bug.cgi?id=183960
212         <rdar://problem/38812356>
213
214         Reviewed by Dan Bernstein.
215
216         * Configurations/WebKitLegacy.xcconfig:
217
218 2018-03-23  Tim Horton  <timothy_horton@apple.com>
219
220         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
221         https://bugs.webkit.org/show_bug.cgi?id=183954
222         <rdar://problem/38808858>
223
224         Reviewed by Dan Bernstein.
225
226         * WebView/WebPreferences.mm:
227         (-[WebPreferences setAudioSessionCategoryOverride:]):
228
229 2018-03-23  Tim Horton  <timothy_horton@apple.com>
230
231         Adopt WK_PLATFORM_NAME in WebKitLegacy
232         https://bugs.webkit.org/show_bug.cgi?id=183948
233         <rdar://problem/38803908>
234
235         Reviewed by Dan Bernstein.
236
237         * Configurations/WebKitLegacy.xcconfig:
238         * MigrateHeaders.make:
239         * postprocess-headers.sh:
240
241 2018-03-23  Brady Eidson  <beidson@apple.com>
242
243         Go to back/forward list items after a process-swapped navigation.
244         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
245
246         Reviewed by Andy Estes.
247
248         * WebView/WebView.mm:
249         (-[WebView _loadBackForwardListFromOtherView:]):
250         (-[WebView goToBackForwardItem:]):
251
252 2018-03-22  Tim Horton  <timothy_horton@apple.com>
253
254         Improve readability of WebCore's OTHER_LDFLAGS
255         https://bugs.webkit.org/show_bug.cgi?id=183909
256         <rdar://problem/38760992>
257
258         Reviewed by Dan Bernstein.
259
260         * Configurations/Base.xcconfig:
261         * Configurations/FeatureDefines.xcconfig:
262
263 2018-03-20  Tim Horton  <timothy_horton@apple.com>
264
265         Enable the minimal simulator feature flag when appropriate
266         https://bugs.webkit.org/show_bug.cgi?id=183807
267
268         Reviewed by Dan Bernstein.
269
270         * Configurations/FeatureDefines.xcconfig:
271
272 2018-03-20  Tim Horton  <timothy_horton@apple.com>
273
274         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
275         https://bugs.webkit.org/show_bug.cgi?id=183758
276         <rdar://problem/38017644>
277
278         Reviewed by Dan Bernstein.
279
280         * Configurations/FeatureDefines.xcconfig:
281
282 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
283
284         Clear style colors when setting default appearance
285         https://bugs.webkit.org/show_bug.cgi?id=183759
286
287         Reviewed by Tim Horton.
288
289         Colors are cached and need to be cleared and recalculated.
290         Refactor to do all style recalcs together.
291
292         * WebView/WebView.mm:
293         (-[WebView _setDefaultAppearanceAndClearStyle]):
294         (-[WebView _setUseSystemAppearance:]):
295         (-[WebView effectiveAppearanceDidChange]):
296
297 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
298
299         Unreviewed, another quick fix for r229699
300
301         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
302
303         * Configurations/FeatureDefines.xcconfig:
304
305 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
306
307         Ensure that style is updated when the effective appearance changes
308         https://bugs.webkit.org/show_bug.cgi?id=183690
309         <rdar://problem/38385900>
310
311         Reviewed by Tim Horton and Wenson Hsieh.
312
313         Respond to and respect the effective appearance changing.
314
315         * WebView/WebView.mm:
316         (-[WebView _setUseSystemAppearance:]):
317         (-[WebView effectiveAppearanceDidChange]):
318
319 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
320
321         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
322         https://bugs.webkit.org/show_bug.cgi?id=183677
323
324         Reviewed by Tim Horton.
325
326         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
327
328         * DOM/DOM.mm:
329         (-[DOMHTMLLinkElement _mediaQueryMatches]):
330
331 2018-03-14  Tim Horton  <timothy_horton@apple.com>
332
333         Fix the build after r229567
334
335         * Configurations/FeatureDefines.xcconfig:
336
337 2018-03-12  Tim Horton  <timothy_horton@apple.com>
338
339         Stop using SDK conditionals to control feature definitions
340         https://bugs.webkit.org/show_bug.cgi?id=183430
341         <rdar://problem/38251619>
342
343         Reviewed by Dan Bernstein.
344
345         * Configurations/FeatureDefines.xcconfig:
346         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
347
348 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
349
350         Runtime flag for link prefetch and remove link subresource.
351         https://bugs.webkit.org/show_bug.cgi?id=183540
352
353         Reviewed by Chris Dumez.
354
355         Remove the LINK_PREFETCH build time flag.
356
357         * Configurations/FeatureDefines.xcconfig:
358
359 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
360
361         Remove GridLayout runtime flag
362         https://bugs.webkit.org/show_bug.cgi?id=183484
363
364         Reviewed by Myles C. Maxfield.
365
366         The Grid Layout feature has been enabled by default for almost a
367         year, so I think it's time to remove the runtime flag and the
368
369         * WebView/WebPreferenceKeysPrivate.h:
370         * WebView/WebPreferences.mm:
371         (+[WebPreferences initialize]):
372         * WebView/WebPreferencesPrivate.h:
373         * WebView/WebView.mm:
374         (-[WebView _preferencesChanged:]):
375
376 2018-03-12  Antoine Quint  <graouts@apple.com>
377
378         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
379         https://bugs.webkit.org/show_bug.cgi?id=183504
380         <rdar://problem/38372965>
381
382         Reviewed by Dean Jackson and Jon Lee.
383
384         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
385         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
386
387         * WebView/WebPreferenceKeysPrivate.h:
388         * WebView/WebPreferences.mm:
389         (+[WebPreferences initialize]):
390         (-[WebPreferences setModernMediaControlsEnabled:]):
391         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
392         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
393         * WebView/WebPreferencesPrivate.h:
394         * WebView/WebView.mm:
395         (-[WebView _preferencesChanged:]):
396
397 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
398
399         Media query for default appearance
400         https://bugs.webkit.org/show_bug.cgi?id=183539
401         <rdar://problem/38326388>
402
403         Reviewed by Tim Horton.
404
405         Write a media query to evaluate appearance.
406
407         * WebView/WebView.mm:
408         (-[WebView _commonInitializationWithFrameName:groupName:]):
409         (-[WebView _setUseSystemAppearance:]):
410
411 2018-03-09  Andy Estes  <aestes@apple.com>
412
413         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
414         https://bugs.webkit.org/show_bug.cgi?id=183489
415         <rdar://problem/38267517>
416
417         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
418         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
419         to issue a sandbox extension for this directory, but for security reasons App Sandbox
420         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
421         block with a nil error and a valid file URL, but no file will actually exist at that URL.
422
423         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
424         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
425         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
426         drop destination.
427
428         Reviewed by Wenson Hsieh.
429
430         * WebView/WebView.mm:
431         (-[WebView performDragOperation:]):
432
433 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
434
435         Allow WebViews to disable system appearance
436         https://bugs.webkit.org/show_bug.cgi?id=183418
437         <rdar://problem/36975642>
438
439         Reviewed by Tim Horton.
440
441         Allow webviews to choose whether or not to follow the default system appearance.
442
443         * WebView/WebView.mm:
444         (-[WebView _setUseSystemAppearance:]):
445         (-[WebView _useSystemAppearance]):
446         * WebView/WebViewPrivate.h:
447
448 2018-03-08  Youenn Fablet  <youenn@apple.com>
449
450         libwebrtc update broke internal builds
451         https://bugs.webkit.org/show_bug.cgi?id=183454
452
453         Reviewed by Eric Carlson.
454
455         * Configurations/WebKitLegacy.xcconfig:
456
457 2018-03-08  Chris Dumez  <cdumez@apple.com>
458
459         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
460         https://bugs.webkit.org/show_bug.cgi?id=183455
461         <rdar://problem/38191749>
462
463         Reviewed by Youenn Fablet.
464
465         Add a null check for the page as we have evidence from crashes that it can be null.
466         Other functions in WebFrameNetworkingContext already null check the page as well,
467         not just the frame so this is consistent.
468
469         * WebCoreSupport/WebFrameNetworkingContext.mm:
470         (WebFrameNetworkingContext::storageSession const):
471
472 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
473
474         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
475         https://bugs.webkit.org/show_bug.cgi?id=183429
476
477         Reviewed by Mark Lam.
478
479         * DOM/DOM.mm:
480         (+[DOMNode _nodeFromJSWrapper:]):
481         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
482         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
483         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
484         * Plugins/Hosted/ProxyInstance.mm:
485         (WebKit::ProxyInstance::invokeMethod):
486         * WebView/WebView.mm:
487         (aeDescFromJSValue):
488
489 2018-03-08  Tim Horton  <timothy_horton@apple.com>
490
491         Stop linking ApplicationServices directly
492         https://bugs.webkit.org/show_bug.cgi?id=182867
493         <rdar://problem/38252142>
494
495         Reviewed by Alex Christensen.
496
497         The frameworks that we use that live inside ApplicationServices
498         have mostly moved out, so import them directly.
499
500         * Carbon/CarbonUtils.h:
501         * WebKitPrefix.h:
502         * WebView/WebHTMLView.mm:
503         * WebView/WebPDFView.mm:
504
505 2018-03-07  Tim Horton  <timothy_horton@apple.com>
506
507         Sort and separate FeatureDefines.xcconfig
508         https://bugs.webkit.org/show_bug.cgi?id=183427
509
510         Reviewed by Dan Bernstein.
511
512         * Configurations/FeatureDefines.xcconfig:
513         Sort and split FeatureDefines into paragraphs
514         (to make it easier to sort later).
515
516 2018-03-07  Youenn Fablet  <youenn@apple.com>
517
518         Match unsupported plugins based on domains and not origin
519         https://bugs.webkit.org/show_bug.cgi?id=183384
520
521         Reviewed by Chris Dumez.
522
523         * WebCoreSupport/WebPluginInfoProvider.h:
524         * WebCoreSupport/WebPluginInfoProvider.mm:
525         (WebPluginInfoProvider::getPluginInfo):
526         (WebPluginInfoProvider::getWebVisiblePluginInfo):
527
528 2018-03-05  Andy Estes  <aestes@apple.com>
529
530         [Mac] Teach WebCore::Pasteboard about file promise drags
531         https://bugs.webkit.org/show_bug.cgi?id=183314
532         <rdar://problem/38105493>
533
534         Reviewed by Darin Adler.
535
536         Added a FIXME comment.
537
538         * WebView/WebView.mm:
539         (-[WebView performDragOperation:]):
540
541 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
542
543         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
544         https://bugs.webkit.org/show_bug.cgi?id=183312
545
546         Reviewed by Mark Lam.
547
548         Remove wtf/CurrentTime.h include pragma.
549
550         * WebView/WebFrame.mm:
551         * WebView/WebPDFView.mm:
552
553 2018-03-04  Tim Horton  <timothy_horton@apple.com>
554
555         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
556         https://bugs.webkit.org/show_bug.cgi?id=183283
557         <rdar://problem/38062148>
558
559         Reviewed by Sam Weinig.
560
561         * Configurations/FeatureDefines.xcconfig:
562
563 2018-02-28  Alex Christensen  <achristensen@webkit.org>
564
565         Reduce use of NetworkingContext in WebKit
566         https://bugs.webkit.org/show_bug.cgi?id=183213
567
568         Reviewed by Brady Eidson.
569
570         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
571         (WebKit::NetscapePluginInstanceProxy::getProxy):
572         * Plugins/WebNetscapePluginView.mm:
573         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
574
575 2018-02-17  Darin Adler  <darin@apple.com>
576
577         Prepare for ExtendedColor changes (first step)
578         https://bugs.webkit.org/show_bug.cgi?id=182904
579
580         Reviewed by Sam Weinig.
581
582         * Misc/WebKitNSStringExtras.mm:
583         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
584
585 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
586
587         Remove currentTime() / currentTimeMS()
588         https://bugs.webkit.org/show_bug.cgi?id=183052
589
590         Reviewed by Mark Lam.
591
592         * WebCoreSupport/WebFrameLoaderClient.h:
593         * WebCoreSupport/WebFrameLoaderClient.mm:
594         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
595
596 2018-02-16  Youenn Fablet  <youenn@apple.com>
597
598         Allow specifying which plug-ins are supported
599         https://bugs.webkit.org/show_bug.cgi?id=182748
600
601         Reviewed by Chris Dumez.
602
603         * WebCoreSupport/WebPluginInfoProvider.h:
604         * WebCoreSupport/WebPluginInfoProvider.mm:
605         (WebPluginInfoProvider::getPluginInfo):
606         (WebPluginInfoProvider::getWebVisiblePluginInfo):
607
608 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
609
610         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
611         https://bugs.webkit.org/show_bug.cgi?id=182882
612         <rdar://problem/35672661>
613
614         Reviewed by Dan Bernstein.
615
616         Make sure the smart pointer hold the collection of subviews lives at least as
617         long as the loop using it.
618
619         * WebView/WebHTMLView.mm:
620         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
621
622 2018-02-14  Daniel Bates  <dabates@apple.com>
623
624         Disallow cross-origin subresources from asking for credentials
625         https://bugs.webkit.org/show_bug.cgi?id=182579
626         <rdar://problem/36162271>
627
628         Reviewed by Andy Estes.
629
630         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
631         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
632
633         * WebView/WebPreferenceKeysPrivate.h:
634         * WebView/WebPreferences.mm:
635         (+[WebPreferences initialize]):
636         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
637         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
638         * WebView/WebPreferencesPrivate.h:
639         * WebView/WebView.mm:
640         (-[WebView _preferencesChanged:]):
641
642 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
643
644         Remove ForwardingHeaders directory from WebKitLegacy/mac.
645         https://bugs.webkit.org/show_bug.cgi?id=182738
646
647         Reviewed by Darin Adler.
648
649         * ForwardingHeaders/collector/handles/Global.h: Removed.
650         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
651         * ForwardingHeaders/runtime/Completion.h: Removed.
652         * ForwardingHeaders/runtime/Error.h: Removed.
653         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
654         * ForwardingHeaders/runtime/JSFunction.h: Removed.
655         * ForwardingHeaders/runtime/JSLock.h: Removed.
656         * ForwardingHeaders/runtime/JSObject.h: Removed.
657         * ForwardingHeaders/runtime/JSString.h: Removed.
658         * ForwardingHeaders/runtime/Protect.h: Removed.
659         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
660
661 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
662
663         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
664         https://bugs.webkit.org/show_bug.cgi?id=182641
665
666         Reviewed by Dan Bernstein.
667
668         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
669         https://trac.webkit.org/changeset/228308.
670
671         * WebView/WebVideoFullscreenController.h:
672         * WebView/WebVideoFullscreenHUDWindowController.mm:
673         * WebView/WebWindowAnimation.h:
674         * WebView/WebWindowAnimation.mm:
675         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
676         (WebCore::scaledRect): Deleted.
677         (WebCore::squaredDistance): Deleted.
678
679 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
680
681         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
682
683         * WebView/WebWindowAnimation.mm:
684         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
685
686 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
687
688         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
689         https://bugs.webkit.org/show_bug.cgi?id=182615
690
691         Reviewed by Eric Carlson.
692
693         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
694         Ideally, we should not reference NSApp in WebCore.
695
696         * WebView/WebFullScreenController.mm:
697         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
698         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
699         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
700         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
701         * WebView/WebView.mm:
702         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
703         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
704
705 2018-01-13  Darin Adler  <darin@apple.com>
706
707         Event improvements
708         https://bugs.webkit.org/show_bug.cgi?id=179591
709
710         Reviewed by Chris Dumez.
711
712         * DOM/DOMWheelEvent.mm:
713         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
714         Call initWebKitWheelEvent.
715
716         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
717         * WebCoreSupport/WebInspectorClient.mm: Ditto.
718         * WebView/WebFrame.mm: Ditto.
719
720         * WebView/WebHTMLView.mm:
721         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
722         underlyingPlatformEvent.
723         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
724
725         * WebView/WebScriptWorld.mm:
726         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
727
728         * WebView/WebView.mm: Removed include of ScriptValue.h.
729
730 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
731
732         Remove WebCore/ForwardingHeaders directory
733         https://bugs.webkit.org/show_bug.cgi?id=182347
734
735         Reviewed by Keith Miller.
736
737         * Carbon/CarbonWindowAdapter.mm:
738         * DOM/WebDOMOperations.mm:
739         * History/WebBackForwardList.mm:
740         * History/WebHistoryItem.mm:
741         * Misc/WebCache.mm:
742         * Misc/WebElementDictionary.mm:
743         * Misc/WebIconDatabase.mm:
744         * Misc/WebStringTruncator.mm:
745         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
746         * Plugins/Hosted/ProxyInstance.mm:
747         * Plugins/Hosted/ProxyRuntimeObject.mm:
748         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
749         * Plugins/WebBaseNetscapePluginView.mm:
750         * Plugins/WebBasePluginPackage.mm:
751         * Plugins/WebNetscapePluginStream.mm:
752         * Plugins/WebNetscapePluginView.mm:
753         * Plugins/WebPluginController.mm:
754         * WebCoreSupport/WebEditorClient.mm:
755         * WebCoreSupport/WebFrameLoaderClient.mm:
756         * WebCoreSupport/WebInspectorClient.h:
757         * WebCoreSupport/WebInspectorClient.mm:
758         * WebView/WebDataSource.mm:
759         * WebView/WebFrame.mm:
760         * WebView/WebHTMLRepresentation.mm:
761         * WebView/WebHTMLView.mm:
762         * WebView/WebPreferences.mm:
763         * WebView/WebScriptDebugDelegate.mm:
764         * WebView/WebScriptDebugger.h:
765         * WebView/WebTextIterator.mm:
766         * WebView/WebView.mm:
767         * WebView/WebViewData.mm:
768
769 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
770
771         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
772         https://bugs.webkit.org/show_bug.cgi?id=182312
773
774         Reviewed by Michael Catanzaro.
775
776         * WebKitPrefix.h:
777
778 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
779
780         [WebAuthN] Add a compile-time feature flag
781         https://bugs.webkit.org/show_bug.cgi?id=182211
782         <rdar://problem/36936365>
783
784         Reviewed by Brent Fulgham.
785
786         * Configurations/FeatureDefines.xcconfig:
787
788 2018-01-27  Dan Bernstein  <mitz@apple.com>
789
790         HaveInternalSDK includes should be "#include?"
791         https://bugs.webkit.org/show_bug.cgi?id=179670
792
793         * Configurations/Base.xcconfig:
794
795 2018-01-24  Alex Christensen  <achristensen@webkit.org>
796
797         Remove unused QTKit preference
798         https://bugs.webkit.org/show_bug.cgi?id=181968
799
800         Reviewed by Alexey Proskuryakov.
801
802         * WebView/WebPreferenceKeysPrivate.h:
803         * WebView/WebPreferences.mm:
804         (+[WebPreferences initialize]):
805         (-[WebPreferences setQTKitEnabled:]): Deleted.
806         (-[WebPreferences isQTKitEnabled]): Deleted.
807         * WebView/WebPreferencesPrivate.h:
808         * WebView/WebView.mm:
809         (-[WebView _preferencesChanged:]):
810
811 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
812
813         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
814         https://bugs.webkit.org/show_bug.cgi?id=182037
815         <rdar://problem/36747812>
816
817         Reviewed by Ryosuke Niwa.
818
819         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
820         for more details.
821
822         * WebView/WebHTMLRepresentation.mm:
823         (-[WebHTMLRepresentation elementWithName:inForm:]):
824         (-[WebHTMLRepresentation controlsInForm:]):
825
826 2018-01-23  Alex Christensen  <achristensen@webkit.org>
827
828         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
829         https://bugs.webkit.org/show_bug.cgi?id=181961
830
831         Reviewed by Michael Catanzaro.
832
833         * WebView/WebPreferences.mm:
834
835 2018-01-23  Commit Queue  <commit-queue@webkit.org>
836
837         Unreviewed, rolling out r227437.
838         https://bugs.webkit.org/show_bug.cgi?id=182011
839
840         broke build (Requested by alexchristensen on #webkit).
841
842         Reverted changeset:
843
844         "Remove unused QTKit preference"
845         https://bugs.webkit.org/show_bug.cgi?id=181968
846         https://trac.webkit.org/changeset/227437
847
848 2018-01-23  Alex Christensen  <achristensen@webkit.org>
849
850         Remove unused QTKit preference
851         https://bugs.webkit.org/show_bug.cgi?id=181968
852
853         Reviewed by Alexey Proskuryakov.
854
855         * WebView/WebPreferenceKeysPrivate.h:
856         * WebView/WebPreferences.mm:
857         (+[WebPreferences initialize]):
858         (-[WebPreferences setQTKitEnabled:]): Deleted.
859         (-[WebPreferences isQTKitEnabled]): Deleted.
860         * WebView/WebPreferencesPrivate.h:
861         * WebView/WebView.mm:
862         (-[WebView _preferencesChanged:]):
863
864 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
865
866         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
867         https://bugs.webkit.org/show_bug.cgi?id=181960
868         <rdar://problem/36431678>
869
870         Reviewed by Tim Horton.
871
872         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
873         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
874         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
875
876         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
877         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
878         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
879
880         * WebView/WebView.mm:
881         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
882
883 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
884
885         Turning off custom pasteboard data doesn't actually turn it off in WK2
886         https://bugs.webkit.org/show_bug.cgi?id=181920
887         <rdar://problem/36686429>
888
889         Reviewed by Wenson Hsieh.
890
891         Always disable custom pasteboard data in WebKit1. See r226156 for details.
892
893         * WebView/WebPreferences.mm:
894         (+[WebPreferences initialize]):
895         * WebView/WebView.mm:
896         (-[WebView _preferencesChanged:]):
897
898 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
899
900         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
901         https://bugs.webkit.org/show_bug.cgi?id=181918
902
903         Reviewed by Tim Horton.
904
905         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
906
907         * Configurations/FeatureDefines.xcconfig:
908
909 2018-01-20  Andy Estes  <aestes@apple.com>
910
911         [Apple Pay] Stop eagerly loading PassKit.framework
912         https://bugs.webkit.org/show_bug.cgi?id=181911
913         <rdar://problem/36555369>
914
915         Reviewed by Tim Horton.
916
917         * WebCoreSupport/WebPaymentCoordinatorClient.h:
918         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
919         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
920
921         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
922
923 2018-01-19  Dean Jackson  <dino@apple.com>
924
925         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
926         https://bugs.webkit.org/show_bug.cgi?id=181817
927         <rdar://problem/35274055>
928
929         Reviewed by Simon Fraser.
930
931         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
932
933         * Misc/WebKitVersionChecks.h:
934         * WebView/WebView.mm:
935         (-[WebView _commonInitializationWithFrameName:groupName:]):
936
937 2018-01-19  Alex Christensen  <achristensen@webkit.org>
938
939         Remove unused WebViewPrivate _allowCookies
940         https://bugs.webkit.org/show_bug.cgi?id=181812
941
942         Reviewed by Tim Horton.
943
944         * WebView/WebView.mm:
945         (+[WebView _setAllowCookies:]): Deleted.
946         (+[WebView _allowCookies]): Deleted.
947         * WebView/WebViewPrivate.h:
948
949 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
950
951         Build fix, remove a call to -[NSWindow setOneShot:]
952         https://bugs.webkit.org/show_bug.cgi?id=181809
953
954         Reviewed by Tim Horton.
955
956         * WebView/WebTextCompletionController.mm:
957         (-[WebTextCompletionController _buildUI]):
958
959 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
960
961         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
962
963         * Carbon/HIWebView.mm:
964         (overrideCGContext):
965         (restoreCGContext):
966
967 2018-01-18  Dan Bernstein  <mitz@apple.com>
968
969         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
970         https://bugs.webkit.org/show_bug.cgi?id=181803
971
972         Reviewed by Tim Horton.
973
974         * Configurations/Base.xcconfig: Updated.
975         * Configurations/DebugRelease.xcconfig: Ditto.
976         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
977         * Configurations/Version.xcconfig: Updated.
978         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
979           useful for defining settings that depend on the target macOS version.
980
981 2018-01-17  Youenn Fablet  <youenn@apple.com>
982
983         Put fetch Request.keepalive behind a runtime flag
984         https://bugs.webkit.org/show_bug.cgi?id=181592
985
986         Reviewed by Chris Dumez.
987
988         * WebView/WebPreferenceKeysPrivate.h:
989         * WebView/WebPreferences.mm:
990         (+[WebPreferences initialize]):
991         (-[WebPreferences fetchAPIKeepAliveEnabled]):
992         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
993         * WebView/WebPreferencesPrivate.h:
994         * WebView/WebView.mm:
995         (-[WebView _preferencesChanged:]):
996
997 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
998
999         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1000         https://bugs.webkit.org/show_bug.cgi?id=181637
1001         <rdar://problem/36508471>
1002
1003         Reviewed by Tim Horton.
1004
1005         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1006
1007         * WebCoreSupport/WebEditorClient.h:
1008         * WebCoreSupport/WebEditorClient.mm:
1009         (WebEditorClient::replacementURLForResource):
1010
1011 2018-01-11  Keith Miller  <keith_miller@apple.com>
1012
1013         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1014         https://bugs.webkit.org/show_bug.cgi?id=181573
1015
1016         Reviewed by Simon Fraser.
1017
1018         * Configurations/FeatureDefines.xcconfig:
1019
1020 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1021
1022         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1023         https://bugs.webkit.org/show_bug.cgi?id=181497
1024
1025         Reviewed by Tim Horton.
1026
1027         See other ChangeLogs for more detail.
1028
1029         * WebCoreSupport/WebDragClient.h:
1030
1031 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1032
1033         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1034         https://bugs.webkit.org/show_bug.cgi?id=181523
1035         <rdar://problem/28959131>
1036
1037         Reviewed by Alex Christensen.
1038
1039         * WebView/WebImmediateActionController.mm:
1040         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1041         Apply the change made in r216652 to WebKit1's immediate action controller.
1042
1043         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1044         the startContainer of the range is in an anonymous node.
1045
1046 2018-01-11  Youenn Fablet  <youenn@apple.com>
1047
1048         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1049         https://bugs.webkit.org/show_bug.cgi?id=181480
1050
1051         Reviewed by Eric Carlson.
1052
1053         * WebView/WebPreferences.mm:
1054         (+[WebPreferences initialize]):
1055
1056 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1057
1058         Fix check-webkit-style issues with WebNSDataExtras.mm
1059         <https://webkit.org/b/181369>
1060
1061         Reviewed by Alex Christensen.
1062
1063         * Misc/WebNSDataExtras.mm:
1064         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1065         (-[NSData _webkit_guessedMIMETypeForXML]):
1066         (-[NSData _webkit_guessedMIMEType]):
1067         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1068         (_findEOL):
1069         (-[NSData _webkit_parseRFC822HeaderFields]):
1070         (-[NSData _web_locationAfterFirstBlankLine]):
1071         - Fix all the check-webkit-style warnings.
1072
1073 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1074
1075         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1076         <https://webkit.org/b/181256>
1077         <rdar://problem/36281730>
1078
1079         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1080         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1081         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1082           to avoid warnings from casting CFStringRef to NPNSString*.
1083           Note that CFMutableStringRef is the same as CFStringRef
1084           without the const modifier, hence its use in the const_cast<>
1085           above.
1086
1087 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1088
1089         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1090         <https://webkit.org/b/181256>
1091         <rdar://problem/36281730>
1092
1093         * Carbon/HIWebView.mm:
1094         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1095         checked_cf_cast<CFRunLoopRef>() to fix warning.
1096
1097 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1098
1099         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1100         <https://webkit.org/b/181256>
1101         <rdar://problem/36281730>
1102
1103         Reviewed by Darin Adler.
1104
1105         * Carbon/CarbonUtils.m:
1106         (PoolCleaner):
1107         - Use #pragmas to ignore -Wcast-qual warnings when using a
1108           C-style cast from CFTypeRef to CFRunloopRef.
1109         * Carbon/CarbonWindowFrame.m:
1110         (-[CarbonWindowFrame title]):
1111         - Use #pragmas to ignore -Wcast-qual warnings when using a
1112           C-style cast from CFStringRef to NSString *.
1113         * Carbon/HIViewAdapter.m:
1114         (+[HIViewAdapter getHIViewForNSView:]):
1115         - Use #pragmas to ignore -Wcast-qual warnings when using a
1116           C-style cast from CFTypeRef to HIViewRef.
1117         * Configurations/Base.xcconfig:
1118         (WARNING_CFLAGS): Add -Wcast-qual.
1119         * Misc/WebElementDictionary.mm:
1120         (-[WebElementDictionary objectForKey:]):
1121         - Use static_cast<SEL>(const_cast<void*>()) to fix
1122           warning.
1123         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1124         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1125         (-[NSData _webkit_guessedMIMETypeForXML]):
1126         (-[NSData _webkit_guessedMIMEType]):
1127         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1128         (_findEOL):
1129         (-[NSData _webkit_parseRFC822HeaderFields]):
1130         (-[NSData _web_startsWithBlankLine]):
1131         (-[NSData _web_locationAfterFirstBlankLine]):
1132         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1133           type to Objective-C++.  This fixes the warnings about
1134           discarding the `const` modifier when casing from CFStringRef
1135           to NSString * because in older clang versions, -Wcast-qual was
1136           completely broken when compiling C++ and Objective-C++ source
1137           files.  In newer clang versions, discarding the `const`
1138           modifier for toll-free bridged types is ignored when compiling
1139           Objective-C++ source.
1140         - Update copyright and license header.
1141         - Use reinterpret_cast<> and static_cast<> to fix warnings
1142           unrelated to (NSString *) C-style casts.
1143         - Replace use of MIN() macro with std::min<> template functions.
1144         - Fix location of `*` for local variables modified above.
1145         * Plugins/Hosted/NetscapePluginHostManager.mm:
1146         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1147         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1148         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1149         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1150           warnings.
1151         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1152         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1153         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1154           to fix warning.
1155         * Plugins/Hosted/ProxyInstance.mm:
1156         (WebKit::ProxyInstance::invoke):
1157         - Use static_cast<char*>(const_cast<void*>()) to fix
1158           warning when using -[NSData bytes].
1159         (WebKit::ProxyInstance::fieldValue const):
1160         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1161           to fix warning when using CFDataGetBytePtr().
1162         * Plugins/Hosted/WebTextInputWindowController.m:
1163         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1164         - Use #pragma to ignore -Wcast-qual warning since there
1165           is not a good way to avoid this warning in Objective-C.
1166         * Plugins/WebNetscapePluginStream.mm:
1167         (WebNetscapePluginStream::deliverData):
1168         - Use const_cast<void*>() to fix warning when using
1169           -[NSData bytes].
1170         * Plugins/WebNetscapePluginView.mm:
1171         (-[WebNetscapePluginView _createPlugin]):
1172         - Change C-style cast to const_cast<char*>() to fix
1173           warning.
1174         * WebCoreSupport/WebChromeClient.mm:
1175         (WebChromeClient::wrapCryptoKey const):
1176         (WebChromeClient::unwrapCryptoKey const):
1177         - Change C-style cast to
1178           static_cast<uint8_t*>(const_cast<void*>() to fix
1179           warning.
1180         * WebView/WebPDFView.mm:
1181         (_applicationInfoForMIMEType):
1182         - Change local variable type from 'NSURL *' to
1183           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1184           when calling -[NSURL path].
1185
1186 2018-01-05  Dan Bernstein  <mitz@apple.com>
1187
1188         Fixed the build following AppKit API deprecations in a recent SDKs
1189
1190         * WebView/WebFullScreenController.mm:
1191         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1192         (-[WebFullScreenController exitFullScreen]): Ditto.
1193         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1194         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1195         * WebView/WebHTMLView.mm:
1196         (-[WebHTMLView drawRect:]): Ditto.
1197         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1198         (-[WebHTMLView knowsPageRange:]): Ditto.
1199         * WebView/WebView.mm:
1200         (LayerFlushController::flushLayers): Ditto.
1201
1202 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1203
1204         [Attachment Support] Create attachment elements when dropping files on iOS
1205         https://bugs.webkit.org/show_bug.cgi?id=181192
1206         <rdar://problem/36280945>
1207
1208         Reviewed by Tim Horton.
1209
1210         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1211
1212         * WebCoreSupport/WebPlatformStrategies.h:
1213         * WebCoreSupport/WebPlatformStrategies.mm:
1214         (WebPlatformStrategies::informationForItemAtIndex):
1215         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1216
1217 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1218
1219         [Attachment Support] Add plumbing for starting a drag with promised blob data
1220         https://bugs.webkit.org/show_bug.cgi?id=181201
1221
1222         Reviewed by Tim Horton.
1223
1224         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1225
1226         * WebCoreSupport/WebDragClient.h:
1227
1228 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1229
1230         Add a WebAuthentication runtime feature flag
1231         https://bugs.webkit.org/show_bug.cgi?id=181220
1232         <rdar://problem/36055305>
1233
1234         Reviewed by Brent Fulgham.
1235
1236         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1237
1238         * WebView/WebPreferenceKeysPrivate.h:
1239         * WebView/WebPreferences.mm:
1240         (+[WebPreferences initialize]):
1241         (-[WebPreferences webAuthenticationEnabled]):
1242         (-[WebPreferences setWebAuthenticationEnabled:]):
1243         (-[WebPreferences credentialManagementEnabled]): Deleted.
1244         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1245         * WebView/WebPreferencesPrivate.h:
1246         * WebView/WebView.mm:
1247         (-[WebView _preferencesChanged:]):
1248
1249 2017-12-22  Jeff Miller  <jeffm@apple.com>
1250
1251         Update user-visible copyright strings to include 2018
1252         https://bugs.webkit.org/show_bug.cgi?id=181141
1253
1254         Reviewed by Dan Bernstein.
1255
1256         * Info.plist:
1257
1258 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1259
1260         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1261         https://bugs.webkit.org/show_bug.cgi?id=181188
1262
1263         Reviewed by Dan Bernstein.
1264
1265         See WebCore/ChangeLog for more detail.
1266
1267         * WebCoreSupport/WebDragClient.h:
1268         * WebCoreSupport/WebDragClient.mm:
1269         (WebDragClient::declareAndWriteAttachment): Deleted.
1270         * WebView/WebHTMLView.mm:
1271         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1272
1273 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1274
1275         Unreviewed, continue to fix build failures due to AppKit API deprecation
1276
1277         Wraps more code in -Wdeprecated-declarations.
1278
1279         * Carbon/HIWebView.mm:
1280         (overrideCGContext):
1281
1282 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1283
1284         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1285
1286         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1287
1288         * Carbon/CarbonWindowAdapter.mm:
1289         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1290         * Plugins/WebNetscapePluginView.mm:
1291         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1292         (-[WebNetscapePluginView sendDrawRectEvent:]):
1293         (-[WebNetscapePluginView drawRect:]):
1294
1295 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1296
1297         Fix build failures due to using deprecated AppKit symbols
1298         https://bugs.webkit.org/show_bug.cgi?id=181110
1299         <rdar://problem/36162865>
1300
1301         Reviewed by Dan Bernstein and Tim Horton.
1302
1303         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1304
1305         * Misc/WebKitNSStringExtras.mm:
1306         (-[NSString _web_drawAtPoint:font:textColor:]):
1307         * Misc/WebNSPasteboardExtras.h:
1308         * Misc/WebNSPasteboardExtras.mm:
1309         (+[NSPasteboard _web_writableTypesForURL]):
1310         (_createWritableTypesForImageWithoutArchive):
1311         (_createWritableTypesForImageWithArchive):
1312         (+[NSPasteboard _web_dragTypesForURL]):
1313         (-[NSPasteboard _web_bestURL]):
1314         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1315         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1316         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1317         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1318         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1319         * Panels/WebAuthenticationPanel.m:
1320         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1321         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1322         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1323         (-[WebHostedNetscapePluginView drawRect:]):
1324         * WebInspector/WebNodeHighlightView.mm:
1325         (-[WebNodeHighlightView drawRect:]):
1326         * WebView/WebFrame.mm:
1327         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1328         (-[WebFrame _drawRect:contentsOnly:]):
1329         * WebView/WebHTMLView.mm:
1330         (kit):
1331         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1332         (-[WebHTMLView _plainTextFromPasteboard:]):
1333         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1334         (+[WebHTMLView _insertablePasteboardTypes]):
1335         (+[WebHTMLView _selectionPasteboardTypes]):
1336         (-[WebHTMLView pasteboard:provideDataForType:]):
1337         (-[WebHTMLView _writeSelectionToPasteboard:]):
1338         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1339         (-[WebHTMLView validRequestorForSendType:returnType:]):
1340         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1341         (createMenuItem):
1342         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1343         (-[WebHTMLView _colorAsString:]):
1344         (-[WebHTMLView copyFont:]):
1345         * WebView/WebPDFView.mm:
1346         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1347         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1348         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1349         (-[WebPDFView pasteboardTypesForSelection]):
1350         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1351         * WebView/WebView.h:
1352         * WebView/WebView.mm:
1353         (-[WebView performDragOperation:]):
1354         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1355         (-[WebView _searchWithGoogleFromMenu:]):
1356
1357 2017-12-21  Youenn Fablet  <youenn@apple.com>
1358
1359         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1360         https://bugs.webkit.org/show_bug.cgi?id=181000
1361
1362         Reviewed by Chris Dumez.
1363
1364         * Misc/WebCache.mm:
1365         (+[WebCache addImageToCache:forURL:forFrame:]):
1366
1367 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1368
1369         Update FULLSCREEN_API feature defines.
1370         https://bugs.webkit.org/show_bug.cgi?id=181015
1371
1372         Reviewed by Tim Horton.
1373
1374         Change enabled iphone sdk for FULLSCREEN_API.
1375
1376         * Configurations/FeatureDefines.xcconfig:
1377
1378 2017-12-21  Jer Noble  <jer.noble@apple.com>
1379
1380         Add initial DOM support for Media Capabilities
1381         https://bugs.webkit.org/show_bug.cgi?id=181064
1382
1383         Reviewed by Eric Carlson.
1384
1385         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1386
1387         * WebView/WebPreferenceKeysPrivate.h:
1388         * WebView/WebPreferences.mm:
1389         (+[WebPreferences initialize]):
1390         (-[WebPreferences mediaCapabilitiesEnabled]):
1391         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1392         * WebView/WebPreferencesPrivate.h:
1393         * WebView/WebView.mm:
1394         (-[WebView _preferencesChanged:]):
1395
1396 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1397
1398         Enable picture-in-picture from inline element on suspend.
1399         https://bugs.webkit.org/show_bug.cgi?id=180942
1400         rdar://problem/34745234
1401
1402         Reviewed by Jer Noble.
1403
1404         Update signature of enterVideoFullscreenForVideoElement().
1405
1406         * WebCoreSupport/WebChromeClient.h:
1407         * WebCoreSupport/WebChromeClient.mm:
1408         (WebChromeClient::enterVideoFullscreenForVideoElement):
1409
1410 2017-12-20  Daniel Bates  <dabates@apple.com>
1411
1412         Remove Alternative Presentation Button
1413         https://bugs.webkit.org/show_bug.cgi?id=180500
1414         <rdar://problem/35891047>
1415
1416         Reviewed by Simon Fraser.
1417
1418         We no longer need the alternative presentation button.
1419
1420         * Configurations/FeatureDefines.xcconfig:
1421
1422 2017-12-19  Jer Noble  <jer.noble@apple.com>
1423
1424         Playing media elements which call "pause(); play()" will have the play promise rejected.
1425         https://bugs.webkit.org/show_bug.cgi?id=180781
1426         <rdar://problem/33191377>
1427
1428         Reviewed by Eric Carlson.
1429
1430         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1431
1432         * WebView/WebView.mm:
1433         (shouldRequireUserGestureToLoadVideo):
1434
1435 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1436
1437         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1438         https://bugs.webkit.org/show_bug.cgi?id=180977
1439
1440         Reviewed by Tim Horton.
1441
1442         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1443         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1444         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1445
1446         * WebCoreSupport/WebEditorClient.mm:
1447         (attributesForAttributedStringConversion):
1448         * WebView/WebHTMLView.mm:
1449         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1450
1451 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1452
1453         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1454
1455         Attempt to fix the following warnings:
1456
1457             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1458
1459         For the following instance variables:
1460
1461             _borderView
1462             _contentView
1463             _frame
1464             _wFlags
1465
1466         * Carbon/CarbonWindowAdapter.mm:
1467         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1468         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1469         (-[CarbonWindowAdapter _termWindowIfOwner]):
1470         (-[CarbonWindowAdapter _windowMovedToRect:]):
1471         (-[CarbonWindowAdapter setContentView:]):
1472         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1473         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1474
1475 2017-12-16  Dan Bernstein  <mitz@apple.com>
1476
1477         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1478         https://bugs.webkit.org/show_bug.cgi?id=180613
1479         <rdar://problem/35946124>
1480
1481         Reviewed by Geoff Garen.
1482
1483         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1484           clients.
1485         * WebView/WebDynamicScrollBarsView.h: Ditto.
1486         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1487
1488 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1489
1490         Enable -Wstrict-prototypes for WebKit
1491         <https://webkit.org/b/180757>
1492         <rdar://problem/36024132>
1493
1494         Rubber-stamped by Joseph Pecoraro.
1495
1496         * Configurations/Base.xcconfig:
1497         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1498
1499 2017-12-14  John Wilander  <wilander@apple.com>
1500
1501         Storage Access API: Implement frame-specific access in the document.cookie layer
1502         https://bugs.webkit.org/show_bug.cgi?id=180682
1503         <rdar://problem/35982257>
1504
1505         Reviewed by Alex Christensen.
1506
1507         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1508         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1509         CookiesStrategy::getRawCookies() now take optional parameters for
1510         frameID and pageID to allow frame-specific scoping of cookies.
1511
1512         This change makes the return values of FrameLoaderClient::frameID()
1513         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1514         WebCore can call those getters and get the right return values in
1515         WebKit and std:nullopt in WebKitLegacy.
1516
1517         * WebCoreSupport/WebFrameLoaderClient.h:
1518         * WebCoreSupport/WebFrameLoaderClient.mm:
1519         (WebFrameLoaderClient::pageID const):
1520         (WebFrameLoaderClient::frameID const):
1521         * WebCoreSupport/WebPlatformStrategies.h:
1522         * WebCoreSupport/WebPlatformStrategies.mm:
1523         (WebPlatformStrategies::cookiesForDOM):
1524         (WebPlatformStrategies::setCookiesFromDOM):
1525         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1526         (WebPlatformStrategies::getRawCookies):
1527
1528 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1529
1530         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1531         https://bugs.webkit.org/show_bug.cgi?id=180689
1532
1533         Reviewed by Tim Horton.
1534
1535         Use sRGBColorSpaceRef() from WebCore.
1536
1537         * WebView/WebHTMLView.mm:
1538         (imageFromRect):
1539
1540 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1541
1542         Stop using deprecated target conditional for simulator builds
1543         https://bugs.webkit.org/show_bug.cgi?id=180662
1544         <rdar://problem/35136156>
1545
1546         Reviewed by Simon Fraser.
1547
1548         * postprocess-headers.sh:
1549
1550 2017-12-11  David Quesada  <david_quesada@apple.com>
1551
1552         Turn on ENABLE_APPLICATION_MANIFEST
1553         https://bugs.webkit.org/show_bug.cgi?id=180562
1554         rdar://problem/35924737
1555
1556         Reviewed by Geoffrey Garen.
1557
1558         * Configurations/FeatureDefines.xcconfig:
1559
1560 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1561
1562         Remove pthread_once in favor of dispatch_once
1563         https://bugs.webkit.org/show_bug.cgi?id=180591
1564
1565         Reviewed by Saam Barati.
1566
1567         * Misc/WebKitErrors.m:
1568         (+[NSError _registerWebKitErrors]):
1569         (registerErrors): Deleted.
1570         * Storage/WebStorageManager.mm:
1571         (+[WebStorageManager _storageDirectoryPath]):
1572         (initializeLocalStoragePath): Deleted.
1573
1574 2017-12-07  Darin Adler  <darin@apple.com>
1575
1576         Remove some unused code from WebKitLegacy
1577         https://bugs.webkit.org/show_bug.cgi?id=180567
1578
1579         Reviewed by Anders Carlsson.
1580
1581         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1582         macOS (back a few versions) and iOS and removed unused
1583         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1584         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1585         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1586         _webkit_stringByCollapsingNonPrintingCharacters,
1587         _webkit_stringByCollapsingWhitespaceCharacters,
1588         _web_stringWithData:textEncodingName:, and
1589         _webkit_localStorageDirectoryWithBundleIdentifier:.
1590
1591         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1592         this source file.
1593         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1594         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1595         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1596         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1597         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1598         handle font smoothing options.
1599         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1600         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1601         from header and made it a little clearer.
1602         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1603         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1604         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1605         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1606         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1607         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1608         implementation a bit and used whole words instead of abbreviations.
1609         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1610
1611         * Misc/WebNSFileManagerExtras.mm:
1612         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1613         filenameByFixingIllegalCharacters function from WebCore directly instead of
1614         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1615
1616         * Plugins/WebBaseNetscapePluginView.mm:
1617         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1618         string replacements instead of _web_stringByStrippingReturnCharacters
1619         and to use NSString methods instead of CFString functions.
1620
1621 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1622
1623         Ignore deprecation warnings.
1624
1625         * WebView/WebHTMLView.mm:
1626         (-[NSWindow _web_borderView]):
1627         (-[WebHTMLView _setAsideSubviews]):
1628         * WebView/WebView.mm:
1629         (-[WebView encodeWithCoder:]):
1630
1631 2017-12-02  Darin Adler  <darin@apple.com>
1632
1633         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1634         https://bugs.webkit.org/show_bug.cgi?id=180009
1635
1636         Reviewed by Alex Christensen.
1637
1638         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1639
1640         * Plugins/WebBaseNetscapePluginView.mm:
1641         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1642         of strcasecmp.
1643
1644         * WebView/WebPreferences.mm:
1645         (contains): Ditto. Also made this a template so it's easier to call on an array.
1646         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1647
1648 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1649
1650         Limit user agent versioning to an upper bound
1651         https://bugs.webkit.org/show_bug.cgi?id=180365
1652         <rdar://problem/34550617>
1653
1654         Reviewed by Joseph Pecoraro.
1655
1656         * WebView/WebView.mm:
1657         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1658         creating the User Agent string.
1659         (webKitBundleVersionString): Deleted.
1660
1661 2017-12-05  Andy Estes  <aestes@apple.com>
1662
1663         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1664         https://bugs.webkit.org/show_bug.cgi?id=180457
1665         <rdar://problem/35143007>
1666
1667         Reviewed by Tim Horton.
1668
1669         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1670         check for this macro during post-processing.
1671
1672         * postprocess-headers.sh:
1673
1674 2017-12-04  David Quesada  <david_quesada@apple.com>
1675
1676         Add a class for parsing application manifests
1677         https://bugs.webkit.org/show_bug.cgi?id=177973
1678         rdar://problem/34747949
1679
1680         Reviewed by Geoffrey Garen.
1681
1682         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1683
1684 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1685
1686         Make LegacyCustomProtocolManager optional for network process
1687         https://bugs.webkit.org/show_bug.cgi?id=176230
1688
1689         Reviewed by Alex Christensen.
1690
1691         * Configurations/FeatureDefines.xcconfig:
1692
1693 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1694
1695         Fix some NSOperationQueue leaks
1696         https://bugs.webkit.org/show_bug.cgi?id=180221
1697
1698         Reviewed by Wenson Hsieh.
1699
1700         * WebView/WebView.mm:
1701         (-[WebView performDragOperation:]):
1702
1703 2017-11-30  Darin Adler  <darin@apple.com>
1704
1705         [Mac] remove unneeded RetainPtr use introduced in r225142
1706         https://bugs.webkit.org/show_bug.cgi?id=180202
1707
1708         Reviewed by Tim Horton.
1709
1710         * WebView/WebImmediateActionController.mm:
1711         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1712         RetainPtr.
1713
1714 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1715
1716         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1717         https://bugs.webkit.org/show_bug.cgi?id=175595
1718
1719         Reviewed by Darin Adler.
1720
1721         * WebView/WebPreferences.mm:
1722
1723 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1724
1725         One too many zeroes in macOS version number in FeatureDefines
1726         https://bugs.webkit.org/show_bug.cgi?id=180011
1727
1728         Reviewed by Dan Bernstein.
1729
1730         * Configurations/FeatureDefines.xcconfig:
1731
1732 2017-11-23  Darin Adler  <darin@apple.com>
1733
1734         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1735         https://bugs.webkit.org/show_bug.cgi?id=179981
1736
1737         Reviewed by Sam Weinig.
1738
1739         * WebView/WebImmediateActionController.mm:
1740         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1741         * WebView/WebView.mm:
1742         (coreOptions): Use |= instead of | to build up FindOptions.
1743
1744 2017-11-23  Sam Weinig  <sam@webkit.org>
1745
1746         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1747         https://bugs.webkit.org/show_bug.cgi?id=179954
1748
1749         Reviewed by Darin Adler.
1750
1751         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1752         with direct calls to the corresponding UserGestureIndicator functions.
1753
1754         * Plugins/WebPluginController.mm:
1755         (-[WebPluginController processingUserGesture]):
1756         * WebView/WebView.mm:
1757         (-[WebView _isProcessingUserGesture]):
1758
1759 2017-11-23  Darin Adler  <darin@apple.com>
1760
1761         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1762         https://bugs.webkit.org/show_bug.cgi?id=179907
1763
1764         Reviewed by Sam Weinig.
1765
1766         * History/BinaryPropertyList.cpp:
1767         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1768         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1769         * WebView/WebHTMLRepresentation.mm:
1770         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1771         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1772
1773 2017-11-22  Ali Juma  <ajuma@chromium.org>
1774
1775         Implement VisualViewport API attributes
1776         https://bugs.webkit.org/show_bug.cgi?id=179385
1777
1778         Reviewed by Frédéric Wang.
1779
1780         Add a VisualViewportAPI preference.
1781
1782         * WebView/WebPreferenceKeysPrivate.h:
1783         * WebView/WebPreferences.mm:
1784         (+[WebPreferences initialize]):
1785         (-[WebPreferences visualViewportAPIEnabled]):
1786         (-[WebPreferences setVisualViewportAPIEnabled:]):
1787         * WebView/WebPreferencesPrivate.h:
1788         * WebView/WebView.mm:
1789         (-[WebView _preferencesChanged:]):
1790
1791 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1792
1793         WebCoreObjCExtras.h is being included in too many places
1794         https://bugs.webkit.org/show_bug.cgi?id=179931
1795
1796         Reviewed by Darin Adler.
1797
1798         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1799         * Plugins/WebBaseNetscapePluginView.mm:
1800         * Plugins/WebBasePluginPackage.mm:
1801         * Plugins/WebNetscapePluginStream.mm:
1802         * Plugins/WebNetscapePluginView.mm:
1803         * WebView/WebTextIterator.mm:
1804         * WebView/WebViewData.mm:
1805
1806 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1807
1808         Unreviewed, rolling out r225093.
1809         https://bugs.webkit.org/show_bug.cgi?id=179938
1810
1811         Compilation failed on WinCairo 64-bit Release (Requested by
1812         fredw on #webkit).
1813
1814         Reverted changeset:
1815
1816         "Implement VisualViewport API attributes"
1817         https://bugs.webkit.org/show_bug.cgi?id=179385
1818         https://trac.webkit.org/changeset/225093
1819
1820 2017-11-21  Ali Juma  <ajuma@chromium.org>
1821
1822         Implement VisualViewport API attributes
1823         https://bugs.webkit.org/show_bug.cgi?id=179385
1824
1825         Reviewed by Frédéric Wang.
1826
1827         Add a VisualViewportAPI preference.
1828
1829         * WebView/WebPreferenceKeysPrivate.h:
1830         * WebView/WebPreferences.mm:
1831         (+[WebPreferences initialize]):
1832         (-[WebPreferences visualViewportAPIEnabled]):
1833         (-[WebPreferences setVisualViewportAPIEnabled:]):
1834         * WebView/WebPreferencesPrivate.h:
1835         * WebView/WebView.mm:
1836         (-[WebView _preferencesChanged:]):
1837
1838 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1839
1840         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1841         https://bugs.webkit.org/show_bug.cgi?id=179504
1842
1843         Reviewed by Darin Adler.
1844
1845         * Misc/WebKitNSStringExtras.mm:
1846         * Plugins/Hosted/NetscapePluginHostManager.mm:
1847         * Plugins/WebBasePluginPackage.mm:
1848
1849 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1850
1851         Remove unused TOUCH_ICON_LOADING feature flag
1852         https://bugs.webkit.org/show_bug.cgi?id=179873
1853
1854         Reviewed by Simon Fraser.
1855
1856         * Configurations/FeatureDefines.xcconfig:
1857
1858 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1859
1860         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1861         https://bugs.webkit.org/show_bug.cgi?id=179872
1862
1863         Reviewed by Darin Adler.
1864
1865         * Configurations/FeatureDefines.xcconfig:
1866
1867 2017-11-16  Daniel Bates  <dabates@apple.com>
1868
1869         Add feature define for alternative presentation button element
1870         https://bugs.webkit.org/show_bug.cgi?id=179692
1871         Part of <rdar://problem/34917108>
1872
1873         Reviewed by Andy Estes.
1874
1875         Only enabled on Cocoa platforms by default.
1876
1877         * Configurations/FeatureDefines.xcconfig:
1878
1879 2017-11-14  Nan Wang  <n_wang@apple.com>
1880
1881         AX: AOM: Implement AccessibleNode class and support label and role attributes
1882         https://bugs.webkit.org/show_bug.cgi?id=179494
1883
1884         Reviewed by Ryosuke Niwa.
1885
1886         * WebView/WebPreferenceKeysPrivate.h:
1887         * WebView/WebPreferences.mm:
1888         (+[WebPreferences initialize]):
1889         (-[WebPreferences accessibilityObjectModelEnabled]):
1890         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1891         * WebView/WebPreferencesPrivate.h:
1892         * WebView/WebView.mm:
1893         (-[WebView _preferencesChanged:]):
1894
1895 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1896
1897         Remove Cocoa CFURLConnection loading code
1898         https://bugs.webkit.org/show_bug.cgi?id=179688
1899
1900         Reviewed by Antti Koivisto.
1901
1902         * Misc/WebDownload.mm:
1903         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1904         * Misc/WebDownloadInternal.h:
1905         * Plugins/WebBaseNetscapePluginView.mm:
1906         * WebCoreSupport/WebFrameLoaderClient.mm:
1907         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1908         * WebView/WebView.mm:
1909         (-[WebView scheduleInRunLoop:forMode:]):
1910         (-[WebView unscheduleFromRunLoop:forMode:]):
1911
1912 2017-11-14  Daniel Bates  <dabates@apple.com>
1913
1914         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1915         for feature defines
1916
1917         Following r195498 and r201917 the Visual Studio property files for feature defines have
1918         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1919         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1920         files.
1921
1922         * Configurations/FeatureDefines.xcconfig:
1923
1924 2017-11-14  Jer Noble  <jer.noble@apple.com>
1925
1926         Enable Modern EME tests in DumpRenderTree
1927         https://bugs.webkit.org/show_bug.cgi?id=179544
1928
1929         Reviewed by Alex Christensen.
1930
1931         Add a WebPreferences property to enable the (modern) EME API.
1932
1933         * WebView/WebPreferenceKeysPrivate.h:
1934         * WebView/WebPreferences.mm:
1935         (+[WebPreferences initialize]):
1936         (-[WebPreferences encryptedMediaAPIEnabled]):
1937         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1938         * WebView/WebPreferencesPrivate.h:
1939         * WebView/WebView.mm:
1940         (-[WebView _preferencesChanged:]):
1941
1942 2017-11-14  Antti Koivisto  <antti@apple.com>
1943
1944         Enable display:contents by default
1945         https://bugs.webkit.org/show_bug.cgi?id=179655
1946
1947         Reviewed by Sam Weinig.
1948
1949         * WebView/WebPreferences.mm:
1950         (+[WebPreferences initialize]):
1951
1952 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1953
1954         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1955         https://bugs.webkit.org/show_bug.cgi?id=178751
1956
1957         Reviewed by Brady Eidson.
1958
1959         * WebCoreSupport/WebFrameNetworkingContext.mm:
1960         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1961
1962 2017-11-08  Keith Miller  <keith_miller@apple.com>
1963
1964         Async iteration should only fetch the next method once and add feature flag
1965         https://bugs.webkit.org/show_bug.cgi?id=179451
1966
1967         Reviewed by Geoffrey Garen.
1968
1969         Add feature flag for Async iteration.
1970
1971         * Configurations/FeatureDefines.xcconfig:
1972
1973 2017-11-13  Mark Lam  <mark.lam@apple.com>
1974
1975         Add more overflow check book-keeping for MarkedArgumentBuffer.
1976         https://bugs.webkit.org/show_bug.cgi?id=179634
1977         <rdar://problem/35492517>
1978
1979         Reviewed by Saam Barati.
1980
1981         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1982         (WebKit::NetscapePluginInstanceProxy::invoke):
1983         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1984         (WebKit::NetscapePluginInstanceProxy::construct):
1985
1986 2017-11-12  Darin Adler  <darin@apple.com>
1987
1988         More is<> and downcast<>, less static_cast<>
1989         https://bugs.webkit.org/show_bug.cgi?id=179600
1990
1991         Reviewed by Chris Dumez.
1992
1993         * DOM/DOM.mm:
1994         (kit): Use is/downcast.
1995         * WebCoreSupport/WebEditorClient.mm:
1996         (WebEditorClient::handleKeyboardEvent): Ditto.
1997         (WebEditorClient::handleInputMethodKeydown): Ditto.
1998         * WebView/WebHTMLView.mm:
1999         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2000
2001 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2002
2003         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2004         https://bugs.webkit.org/show_bug.cgi?id=179397
2005
2006         Reviewed by Wenson Hsieh.
2007
2008         * DOM/DOMHTMLInputElement.mm:
2009         (-[DOMHTMLInputElement insertTextSuggestion:]):
2010
2011 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2012
2013         HTMLMediaElement should not use element fullscreen on iOS
2014         https://bugs.webkit.org/show_bug.cgi?id=179418
2015         rdar://problem/35409277
2016
2017         Reviewed by Eric Carlson.
2018
2019         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2020
2021         * Configurations/FeatureDefines.xcconfig:
2022
2023 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2024
2025         Make ResourceLoader::willSendRequestInternal asynchronous
2026         https://bugs.webkit.org/show_bug.cgi?id=179251
2027
2028         Reviewed by Andy Estes.
2029
2030         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2031         (WebKit::HostedNetscapePluginStream::start):
2032         * Plugins/WebNetscapePluginStream.mm:
2033         (WebNetscapePluginStream::start):
2034
2035 2017-11-01  Darin Adler  <darin@apple.com>
2036
2037         Simplify event dispatch code and make it a bit more consistent
2038         https://bugs.webkit.org/show_bug.cgi?id=178991
2039
2040         Reviewed by Chris Dumez.
2041
2042         * DOM/DOMEvent.mm:
2043         (-[DOMEvent srcElement]): Call target instead of srcElement.
2044
2045 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2046
2047         [Touch Bar Web API] Add support for menuitem tag
2048         https://bugs.webkit.org/show_bug.cgi?id=179020
2049
2050         Reviewed by Ryosuke Niwa.
2051
2052         Adds in properties and methods that allow the menuitem runtime feature
2053         to be enabled or disabled.
2054
2055         * WebView/WebPreferenceKeysPrivate.h:
2056         * WebView/WebPreferences.mm:
2057         (-[WebPreferences menuItemElementEnabled]):
2058         (-[WebPreferences setMenuItemElementEnabled:]):
2059         * WebView/WebPreferencesPrivate.h:
2060         * WebView/WebView.mm:
2061         (-[WebView _preferencesChanged:]):
2062
2063 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2064
2065         Use CompletionHandlers for redirects
2066         https://bugs.webkit.org/show_bug.cgi?id=179163
2067
2068         Reviewed by Tim Horton.
2069
2070         * Plugins/Hosted/HostedNetscapePluginStream.h:
2071         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2072         (WebKit::HostedNetscapePluginStream::willSendRequest):
2073         * Plugins/WebNetscapePluginStream.h:
2074         * Plugins/WebNetscapePluginStream.mm:
2075         (WebNetscapePluginStream::willSendRequest):
2076
2077 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2078
2079         Add a FileSystem namespace to FileSystem.cpp
2080         https://bugs.webkit.org/show_bug.cgi?id=179063
2081
2082         Reviewed by Darin Adler.
2083
2084         * Misc/WebNSFileManagerExtras.mm:
2085         * Storage/WebDatabaseProvider.mm:
2086
2087 2017-11-02  Frederic Wang  <fwang@igalia.com>
2088
2089         Add references to bug 179167 in FIXME comments
2090         https://bugs.webkit.org/show_bug.cgi?id=179168
2091
2092         Reviewed by Daniel Bates.
2093
2094         * Configurations/FeatureDefines.xcconfig:
2095
2096 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2097
2098         Implement WKFullscreenWindowController for iOS.
2099         https://bugs.webkit.org/show_bug.cgi?id=178924
2100         rdar://problem/34697120
2101
2102         Reviewed by Simon Fraser.
2103
2104         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2105
2106         * Configurations/FeatureDefines.xcconfig:
2107         * WebView/WebView.mm:
2108         (-[WebView fullScreenPlaceholderView]):
2109
2110 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2111
2112         Clean up some drag and drop feature flags
2113         https://bugs.webkit.org/show_bug.cgi?id=179082
2114
2115         Reviewed by Simon Fraser.
2116
2117         * Configurations/FeatureDefines.xcconfig:
2118
2119 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2120
2121         Make it possible to test rubber-banding in overflow scroll
2122         https://bugs.webkit.org/show_bug.cgi?id=179078
2123
2124         Reviewed by Sam Weinig.
2125
2126         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2127         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2128
2129         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2130         functions, since most callers want clamped.
2131
2132         * DOM/DOMHTML.mm:
2133         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2134
2135 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2136
2137         Fix up some content filtering feature flags
2138         https://bugs.webkit.org/show_bug.cgi?id=179079
2139
2140         Reviewed by Simon Fraser.
2141
2142         * Configurations/FeatureDefines.xcconfig:
2143
2144 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2145
2146         [FrameView::layout cleanup] Move core layout logic to a separate class.
2147         https://bugs.webkit.org/show_bug.cgi?id=178771
2148         <rdar://problem/35166542>
2149
2150         Reviewed by Simon Fraser.
2151
2152         Move layout code out from FrameView to LayoutContext.
2153
2154         * WebView/WebClipView.mm:
2155         (-[WebClipView _immediateScrollToPoint:]):
2156         * WebView/WebFrame.mm:
2157         (-[WebFrame layoutCount]):
2158
2159 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2160
2161         Fix issues with WebView subframe painting
2162         https://bugs.webkit.org/show_bug.cgi?id=178842
2163         rdar://problem/34072253
2164
2165         Reviewed by Daniel Bates.
2166         
2167         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2168         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2169         High Sierra, so match the new signature.
2170
2171         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2172
2173         * WebView/WebHTMLView.mm:
2174         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2175         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2176
2177 2017-10-25  Youenn Fablet  <youenn@apple.com>
2178
2179         Enable ServiceWorker to fetch resources
2180         https://bugs.webkit.org/show_bug.cgi?id=178673
2181
2182         Reviewed by Brady Eidson.
2183
2184         * WebCoreSupport/WebFrameLoaderClient.mm:
2185         (WebFrameLoaderClient::pageID const):
2186         (WebFrameLoaderClient::frameID const):
2187         (WebFrameLoaderClient::sessionID const):
2188
2189         Added implementation to the new getters.
2190         They are noop in the context of WK1.
2191
2192 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2193
2194         Web Inspector: Enable WebKit logging configuration and display
2195         https://bugs.webkit.org/show_bug.cgi?id=177027
2196         <rdar://problem/33964767>
2197
2198         Reviewed by Joseph Pecoraro.
2199
2200         * WebCoreSupport/WebChromeClient.mm:
2201         (stringForMessageSource): Deal with Media and WebRTC message sources.
2202
2203 2017-10-20  Antoine Quint  <graouts@apple.com>
2204
2205         [Web Animations] Provide basic timeline and animation interfaces
2206         https://bugs.webkit.org/show_bug.cgi?id=178526
2207
2208         Reviewed by Dean Jackson.
2209
2210         Remove the WEB_ANIMATIONS compile-time flag.
2211
2212         * Configurations/FeatureDefines.xcconfig:
2213         * WebView/WebPreferences.mm:
2214         (+[WebPreferences initialize]):
2215         * WebView/WebView.mm:
2216         (-[WebView _preferencesChanged:]):
2217
2218 2017-10-19  Sam Weinig  <sam@webkit.org>
2219
2220         [Settings] Move global settings into their own file
2221         https://bugs.webkit.org/show_bug.cgi?id=178512
2222
2223         Reviewed by Darin Adler.
2224
2225         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2226
2227         * WebCoreSupport/WebChromeClient.mm:
2228         (WebChromeClient::supportsVideoFullscreen):
2229         * WebView/WebDynamicScrollBarsView.mm:
2230         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2231         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2232         * WebView/WebPreferences.mm:
2233         (+[WebPreferences initialize]):
2234         * WebView/WebView.mm:
2235         (-[WebView _commonInitializationWithFrameName:groupName:]):
2236         (-[WebView _preferencesChanged:]):
2237         (+[WebView _doNotStartObservingNetworkReachability]):
2238
2239 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2240
2241         Replace some stack raw pointers with RefPtrs within WebCore/html
2242         https://bugs.webkit.org/show_bug.cgi?id=178201
2243         <rdar://problem/34841692>
2244
2245         Reviewed by Ryosuke Niwa.
2246
2247         * DOM/DOM.mm:
2248         (kit):
2249         Change the type of node as toNode() is changed to return RefPtr.
2250
2251 2017-10-18  Chris Dumez  <cdumez@apple.com>
2252
2253         [Service Worker] Add stubs for Client / WindowClient / Clients
2254         https://bugs.webkit.org/show_bug.cgi?id=178469
2255
2256         Reviewed by Youenn Fablet.
2257
2258         Rename PageVisiblityState to VisibilityState.
2259
2260         * WebView/WebView.mm:
2261         (kit):
2262
2263 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2264
2265         Unreviewed, rolling out r223291.
2266
2267         See WebCore ChangeLog for more detail.
2268
2269         Reverted changeset:
2270
2271         "Remove Editor::simplifyMarkup"
2272         https://bugs.webkit.org/show_bug.cgi?id=178271
2273         https://trac.webkit.org/changeset/223291
2274
2275 2017-10-17  Keith Miller  <keith_miller@apple.com>
2276
2277         Change WebCore sources to work with unified source builds
2278         https://bugs.webkit.org/show_bug.cgi?id=178229
2279
2280         Rubber stamped by Tim Horton.
2281
2282         * Configurations/FeatureDefines.xcconfig:
2283
2284 2017-10-16  Sam Weinig  <sam@webkit.org>
2285
2286         [Settings] Remove all custom code from Settings.h/cpp
2287         https://bugs.webkit.org/show_bug.cgi?id=178330
2288
2289         Reviewed by Simon Fraser.
2290
2291         * WebView/WebPreferences.mm:
2292         (+[WebPreferences initialize]):
2293         
2294             Update for naming changes of FrameFlattening now that it is an enum class.
2295
2296 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2297
2298         Remove Editor::simplifyMarkup
2299         https://bugs.webkit.org/show_bug.cgi?id=178271
2300
2301         Reviewed by Wenson Hsieh.
2302
2303         * WebView/WebView.mm:
2304         (-[WebView _simplifyMarkup:endNode:]):
2305
2306 2017-10-12  Chris Dumez  <cdumez@apple.com>
2307
2308         [Mac] Add support for MouseEvent.buttons
2309         https://bugs.webkit.org/show_bug.cgi?id=178214
2310
2311         Reviewed by Ryosuke Niwa.
2312
2313         * WebView/WebPDFView.mm:
2314         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2315
2316 2017-10-11  Sam Weinig  <sam@webkit.org>
2317
2318         Remove out-parameter variants of copyToVector
2319         https://bugs.webkit.org/show_bug.cgi?id=178155
2320
2321         Reviewed by Tim Horton.
2322
2323         * Plugins/WebNetscapePluginView.mm:
2324         (-[WebNetscapePluginView destroyPlugin]):
2325         * WebView/WebHTMLRepresentation.mm:
2326         (newArrayWithStrings):
2327
2328             Replace out-parameter based copyToVector, with one that returns a Vector.
2329
2330 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2331
2332         Sanitize URL in pasteboard for other applications and cross origin content
2333         https://bugs.webkit.org/show_bug.cgi?id=178060
2334         <rdar://problem/34874518>
2335
2336         Reviewed by Wenson Hsieh.
2337
2338         * WebCoreSupport/WebPlatformStrategies.h:
2339         * WebCoreSupport/WebPlatformStrategies.mm:
2340         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2341
2342 2017-10-11  Chris Dumez  <cdumez@apple.com>
2343
2344         Modernize Geolocation code
2345         https://bugs.webkit.org/show_bug.cgi?id=178148
2346
2347         Reviewed by Ryosuke Niwa.
2348
2349         * WebCoreSupport/WebGeolocationClient.h:
2350         * WebCoreSupport/WebGeolocationClient.mm:
2351         (WebGeolocationClient::lastPosition):
2352         * WebView/WebGeolocationPosition.mm:
2353         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2354         (core):
2355         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2356         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2357         * WebView/WebGeolocationPositionInternal.h:
2358
2359 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2360
2361         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2362         https://bugs.webkit.org/show_bug.cgi?id=178154
2363
2364         Reviewed by Wenson Hsieh.
2365
2366         Enable custom pasteboard data by default.
2367
2368         * WebView/WebPreferenceKeysPrivate.h:
2369         * WebView/WebPreferences.mm:
2370         (+[WebPreferences initialize]):
2371         (-[WebPreferences customPasteboardDataEnabled]): Added.
2372         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2373         * WebView/WebPreferencesPrivate.h:
2374         * WebView/WebView.mm:
2375         (-[WebView _preferencesChanged:]):
2376
2377 2017-10-10  Sam Weinig  <sam@webkit.org>
2378
2379         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2380         https://bugs.webkit.org/show_bug.cgi?id=178102
2381
2382         Reviewed by Tim Horton.
2383
2384         * History/WebHistory.mm:
2385         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2386         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2387         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2388         * WebCoreSupport/WebUserMediaClient.mm:
2389         (WebUserMediaClient::pageDestroyed):
2390
2391 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2392
2393         Make the names of the options consistent
2394         https://bugs.webkit.org/show_bug.cgi?id=177933
2395
2396         Reviewed by Saam Barati.
2397
2398         * WebView/WebFrame.h:
2399         * WebView/WebHTMLView.mm:
2400         (-[WebHTMLView setMarkedText:selectedRange:]):
2401         * WebView/WebView.h:
2402
2403 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2404
2405         [iOS] Tweak support for classifying form controls (followup to r222487)
2406         https://bugs.webkit.org/show_bug.cgi?id=177917
2407         <rdar://problem/34820122>
2408
2409         Reviewed by Dean Jackson.
2410
2411         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2412
2413         * DOM/DOMHTMLInputElement.mm:
2414         (-[DOMHTMLInputElement _autofillContext]):
2415         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2416         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2417
2418 2017-10-05  Keith Miller  <keith_miller@apple.com>
2419
2420         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2421
2422         * Configurations/WebKitLegacy.xcconfig:
2423
2424 2017-10-05  Jer Noble  <jer.noble@apple.com>
2425
2426         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2427         https://bugs.webkit.org/show_bug.cgi?id=177261
2428
2429         Reviewed by Eric Carlson.
2430
2431         * Configurations/FeatureDefines.xcconfig:
2432
2433 2017-10-05  Chris Dumez  <cdumez@apple.com>
2434
2435         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2436         https://bugs.webkit.org/show_bug.cgi?id=177957
2437
2438         Reviewed by Alex Christensen.
2439
2440         * WebCoreSupport/WebPlatformStrategies.h:
2441         * WebCoreSupport/WebPlatformStrategies.mm:
2442         (WebPlatformStrategies::cookiesEnabled):
2443
2444 2017-10-05  Youenn Fablet  <youenn@apple.com>
2445
2446         Make LibWebRTCProvider port agnostic
2447         https://bugs.webkit.org/show_bug.cgi?id=177747
2448
2449         Reviewed by Alex Christensen & Alex Garcia.
2450
2451         * WebView/WebView.mm:
2452         (-[WebView _commonInitializationWithFrameName:groupName:]):
2453         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2454
2455 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2456
2457         Stop linking with WebKitSystemInterface
2458         https://bugs.webkit.org/show_bug.cgi?id=177915
2459
2460         Reviewed by Antti Koivisto.
2461
2462         * Configurations/DebugRelease.xcconfig:
2463         * Configurations/WebKitLegacy.xcconfig:
2464
2465 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2466
2467         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2468         https://bugs.webkit.org/show_bug.cgi?id=177912
2469
2470         Reviewed by Saam Barati.
2471
2472         * Carbon/CarbonUtils.m:
2473         * Carbon/CarbonWindowAdapter.mm:
2474         * Carbon/HIWebView.mm:
2475         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2476         * Misc/WebNSFileManagerExtras.mm:
2477         * Misc/WebNSPasteboardExtras.mm:
2478         * Misc/WebNSURLExtras.mm:
2479         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2480         * Plugins/Hosted/NetscapePluginHostManager.mm:
2481         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2482         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2483         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2484         * Plugins/Hosted/WebTextInputWindowController.m:
2485         * Plugins/WebBaseNetscapePluginView.mm:
2486         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2487         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2488         * Plugins/WebNetscapePluginStream.mm:
2489         * Plugins/WebNetscapePluginView.mm:
2490         * Plugins/WebPluginDatabase.mm:
2491         * WebCoreSupport/PopupMenuMac.mm:
2492         * WebCoreSupport/WebChromeClient.mm:
2493         * WebCoreSupport/WebFrameLoaderClient.mm:
2494         * WebCoreSupport/WebInspectorClient.mm:
2495         * WebCoreSupport/WebPlatformStrategies.mm:
2496         * WebCoreSupport/WebSystemInterface.mm:
2497         * WebView/WebDynamicScrollBarsView.mm:
2498         * WebView/WebFrame.mm:
2499         * WebView/WebFrameView.mm:
2500         * WebView/WebFullScreenController.mm:
2501         * WebView/WebHTMLView.mm:
2502         * WebView/WebPreferences.mm:
2503         * WebView/WebView.mm:
2504
2505 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2506
2507         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2508         rdar://problem/34705779
2509
2510         Addressing review comments that I somehow landed without.
2511
2512         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2513
2514 2017-09-29  Chris Dumez  <cdumez@apple.com>
2515
2516         Split some logic out of VisitedLinkStore and make it reusable
2517         https://bugs.webkit.org/show_bug.cgi?id=177575
2518
2519         Reviewed by Alex Christensen.
2520
2521         * WebCoreSupport/WebVisitedLinkStore.h:
2522         * WebCoreSupport/WebVisitedLinkStore.mm:
2523         (WebVisitedLinkStore::addVisitedLink):
2524         (WebVisitedLinkStore::removeVisitedLink):
2525         (WebVisitedLinkStore::isLinkVisited):
2526         (WebVisitedLinkStore::addVisitedLinkHash):
2527
2528 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2529
2530         Build fix for High Sierra 32 bit Mac
2531         https://bugs.webkit.org/show_bug.cgi?id=177551
2532         <rdar://problem/34690283>
2533
2534         Reviewed by Alexey Proskuryakov.
2535
2536         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2537         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2538         also made.
2539
2540         * Carbon/CarbonWindowAdapter.mm:
2541         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2542         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2543         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2544         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2545         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2546         (-[CarbonWindowAdapter dealloc]):
2547         (-[CarbonWindowAdapter windowRef]):
2548         (-[CarbonWindowAdapter _hasWindowRef]):
2549         (-[CarbonWindowAdapter _managesWindowRef]):
2550         (-[CarbonWindowAdapter _removeWindowRef]):
2551         (-[CarbonWindowAdapter _carbonWindowClass]):
2552         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2553         (-[CarbonWindowAdapter sendSuperEvent:]):
2554         (-[CarbonWindowAdapter relinquishFocus]):
2555         (-[CarbonWindowAdapter _cancelKey:]):
2556         (-[CarbonWindowAdapter _commonAwake]):
2557         (-[CarbonWindowAdapter _destroyRealWindow:]):
2558         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2559         (-[CarbonWindowAdapter _termWindowIfOwner]):
2560         (-[CarbonWindowAdapter _windowMovedToRect:]):
2561         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2562         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2563         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2564         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2565         (-[CarbonWindowAdapter canBecomeMainWindow]):
2566         (-[CarbonWindowAdapter encodeWithCoder:]):
2567         (-[CarbonWindowAdapter initWithCoder:]):
2568         (-[CarbonWindowAdapter setContentView:]):
2569         (-[CarbonWindowAdapter worksWhenModal]):
2570         (-[CarbonWindowAdapter _setModalWindowLevel]):
2571         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2572         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2573         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2574         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2575         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2576         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2577         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2578         (NSCarbonWindowHandleEvent):
2579         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2580         (-[CarbonWindowAdapter _growBoxRect]):
2581         * Carbon/HIWebView.mm:
2582         (HIWebViewGetWebView):
2583         (HIWebViewConstructor):
2584         (HIWebViewDestructor):
2585         (HIWebViewRegisterClass):
2586         (GetBehaviors):
2587         (Draw):
2588         (HitTest):
2589         (GetRegion):
2590         (GetWindowRef):
2591         (CreateNSEventAdoptingCGEvent):
2592         (CopyEventCGEvent):
2593         (CreateNSEventWithCarbonClickEvent):
2594         (Click):
2595         (CreateNSEventWithCarbonEvent):
2596         (MouseUp):
2597         (CreateNSEventWithCarbonMouseMoveEvent):
2598         (MouseMoved):
2599         (MouseDragged):
2600         (MouseWheelMoved):
2601         (ContextMenuClick):
2602         (GetKind):
2603         (BoundsChanged):
2604         (OwningWindowChanged):
2605         (WindowHandler):
2606         (SyncFrame):
2607         (SetFocusPart):
2608         (AdvanceFocus):
2609         (RelinquishFocus):
2610         (ActiveStateChanged):
2611         (ProcessCommand):
2612         (UpdateCommandStatus):
2613         (_NSSelectorForHICommand):
2614         (HIWebViewEventHandler):
2615         (StartUpdateObserver):
2616         (StopUpdateObserver):
2617         (UpdateObserver):
2618
2619 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2620
2621         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2622         https://bugs.webkit.org/show_bug.cgi?id=172526
2623         <rdar://problem/32396081>
2624
2625         Reviewed by Ryosuke Niwa.
2626
2627         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2628
2629         * WebCoreSupport/WebPlatformStrategies.h:
2630         * WebCoreSupport/WebPlatformStrategies.mm:
2631         (WebPlatformStrategies::webExposedTypes):
2632         (WebPlatformStrategies::writeCustomData):
2633
2634 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2635
2636         Unreviewed, rolling out r222567.
2637
2638         This broke and internal build.
2639
2640         Reverted changeset:
2641
2642         "Build fix for High Sierra 32 bit Mac"
2643         https://bugs.webkit.org/show_bug.cgi?id=177551
2644         http://trac.webkit.org/changeset/222567
2645
2646 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2647
2648         Build fix for High Sierra 32 bit Mac
2649         https://bugs.webkit.org/show_bug.cgi?id=177551
2650         <rdar://problem/34690283>
2651
2652         Reviewed by Alexey Proskuryakov.
2653
2654         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2655         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2656         also made.
2657
2658         * Carbon/CarbonWindowAdapter.mm:
2659         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2660         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2661         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2662         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2663         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2664         (-[CarbonWindowAdapter dealloc]):
2665         (-[CarbonWindowAdapter windowRef]):
2666         (-[CarbonWindowAdapter _hasWindowRef]):
2667         (-[CarbonWindowAdapter _managesWindowRef]):
2668         (-[CarbonWindowAdapter _removeWindowRef]):
2669         (-[CarbonWindowAdapter _carbonWindowClass]):
2670         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2671         (-[CarbonWindowAdapter sendSuperEvent:]):
2672         (-[CarbonWindowAdapter relinquishFocus]):
2673         (-[CarbonWindowAdapter _cancelKey:]):
2674         (-[CarbonWindowAdapter _commonAwake]):
2675         (-[CarbonWindowAdapter _destroyRealWindow:]):
2676         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2677         (-[CarbonWindowAdapter _termWindowIfOwner]):
2678         (-[CarbonWindowAdapter _windowMovedToRect:]):
2679         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2680         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2681         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2682         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2683         (-[CarbonWindowAdapter canBecomeMainWindow]):
2684         (-[CarbonWindowAdapter encodeWithCoder:]):
2685         (-[CarbonWindowAdapter initWithCoder:]):
2686         (-[CarbonWindowAdapter setContentView:]):
2687         (-[CarbonWindowAdapter worksWhenModal]):
2688         (-[CarbonWindowAdapter _setModalWindowLevel]):
2689         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2690         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2691         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2692         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2693         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2694         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2695         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2696         (NSCarbonWindowHandleEvent):
2697         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2698         (-[CarbonWindowAdapter _growBoxRect]):
2699         * Carbon/HIWebView.mm:
2700         (HIWebViewGetWebView):
2701         (HIWebViewConstructor):
2702         (HIWebViewDestructor):
2703         (HIWebViewRegisterClass):
2704         (GetBehaviors):
2705         (Draw):
2706         (HitTest):
2707         (GetRegion):
2708         (GetWindowRef):
2709         (CreateNSEventAdoptingCGEvent):
2710         (CopyEventCGEvent):
2711         (CreateNSEventWithCarbonClickEvent):
2712         (Click):
2713         (CreateNSEventWithCarbonEvent):
2714         (MouseUp):
2715         (CreateNSEventWithCarbonMouseMoveEvent):
2716         (MouseMoved):
2717         (MouseDragged):
2718         (MouseWheelMoved):
2719         (ContextMenuClick):
2720         (GetKind):
2721         (BoundsChanged):
2722         (OwningWindowChanged):
2723         (WindowHandler):
2724         (SyncFrame):
2725         (SetFocusPart):
2726         (AdvanceFocus):
2727         (RelinquishFocus):
2728         (ActiveStateChanged):
2729         (ProcessCommand):
2730         (UpdateCommandStatus):
2731         (_NSSelectorForHICommand):
2732         (HIWebViewEventHandler):
2733         (StartUpdateObserver):
2734         (StopUpdateObserver):
2735         (UpdateObserver):
2736
2737 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2738
2739         Make PolicyAction an encodable enum class
2740         https://bugs.webkit.org/show_bug.cgi?id=177480
2741
2742         Reviewed by Antti Koivisto.
2743
2744         * Plugins/WebPluginContainerCheck.mm:
2745         (-[WebPluginContainerCheck _continueWithPolicy:]):
2746         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2747         * WebCoreSupport/WebFrameLoaderClient.mm:
2748         (-[WebFramePolicyListener invalidate]):
2749         (-[WebFramePolicyListener ignore]):
2750         (-[WebFramePolicyListener download]):
2751         (-[WebFramePolicyListener use]):
2752         (-[WebFramePolicyListener continue]):
2753         * WebView/WebPolicyDelegate.mm:
2754         (-[WebPolicyDecisionListener use]):
2755         (-[WebPolicyDecisionListener ignore]):
2756         (-[WebPolicyDecisionListener download]):
2757
2758 2017-09-25  Frederik Riedel  <riedel@apple.com>
2759
2760         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2761         https://bugs.webkit.org/show_bug.cgi?id=174394
2762         <rdar://problem/33183504>
2763
2764         Reviewed by Ryosuke Niwa.
2765
2766         * DOM/DOMHTMLInputElement.h:
2767         * DOM/DOMHTMLInputElement.mm:
2768         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2769         Determines if this HTMLInputElement is part of a login screen.
2770         (-[DOMHTMLInputElement representingPageUrl]):
2771         Returns the webpage's URL that is currently displayed in the Web View.
2772         (-[DOMHTMLInputElement insertTextSuggestion:]):
2773         Inserts login credentials into the Web View.
2774
2775 2017-09-25  Sam Weinig  <sam@webkit.org>
2776
2777         Remove unused EditorClient functions
2778         https://bugs.webkit.org/show_bug.cgi?id=177463
2779
2780         Reviewed by Alex Christensen.
2781
2782         Remove unused EditorClient functions.
2783
2784         * WebCoreSupport/WebEditorClient.h:
2785         * WebCoreSupport/WebEditorClient.mm:
2786         (WebEditorClient::canonicalizeURL): Deleted.
2787         (WebEditorClient::canonicalizeURLString): Deleted.
2788         (WebEditorClient::writeDataToPasteboard): Deleted.
2789         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2790         (WebEditorClient::readDataFromPasteboard): Deleted.
2791         (WebEditorClient::pasteboardChangeCount): Deleted.
2792
2793 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2794
2795         Stop using PolicyCallback
2796         https://bugs.webkit.org/show_bug.cgi?id=176088
2797
2798         Reviewed by Andy Estes.
2799
2800         * WebCoreSupport/WebFrameLoaderClient.mm:
2801         (-[WebFramePolicyListener invalidate]):
2802         (-[WebFramePolicyListener receivedPolicyDecision:]):
2803
2804 2017-09-25  Sam Weinig  <sam@webkit.org>
2805
2806         Remove unnecessary userVisibleString EditorClient function
2807         https://bugs.webkit.org/show_bug.cgi?id=177456
2808
2809         Reviewed by Dan Bernstein.
2810
2811         * WebCoreSupport/WebEditorClient.h:
2812         * WebCoreSupport/WebEditorClient.mm:
2813         (WebEditorClient::userVisibleString): Deleted.
2814
2815             Remove userVisibleString client function.
2816
2817 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2818
2819         Separate form submission from PolicyChecker infrastructure
2820         https://bugs.webkit.org/show_bug.cgi?id=177396
2821
2822         Reviewed by Geoffrey Garen.
2823
2824         * WebCoreSupport/WebFrameLoaderClient.h:
2825         * WebCoreSupport/WebFrameLoaderClient.mm:
2826         (WebFrameLoaderClient::dispatchWillSubmitForm):
2827
2828 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2829
2830         WeakPtrFactory should populate m_ref lazily.
2831         https://bugs.webkit.org/show_bug.cgi?id=177375
2832
2833         Reviewed by Geoffrey Garen.
2834
2835         * WebCoreSupport/WebEditorClient.mm:
2836         (WebEditorClient::WebEditorClient):
2837         (WebEditorClient::requestCandidatesForSelection):
2838
2839 2017-09-22  Chris Dumez  <cdumez@apple.com>
2840
2841         Use high resolution timestamp for event time
2842         https://bugs.webkit.org/show_bug.cgi?id=154246
2843         <rdar://problem/34333304>
2844
2845         Reviewed by Ryosuke Niwa.
2846
2847         Use WallTime / MonotonicTime instead of double type for clarity.
2848
2849         * DOM/DOMEvent.mm:
2850         (-[DOMEvent timeStamp]):
2851         * WebView/WebFrame.mm:
2852         (-[WebFrame _dragSourceEndedAt:operation:]):
2853         * WebView/WebPDFView.mm:
2854         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2855
2856 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2857
2858         Enable dataTransfer.items on macOS and iOS
2859         https://bugs.webkit.org/show_bug.cgi?id=177335
2860
2861         Reviewed by Sam Weinig.
2862
2863         * WebView/WebPreferences.mm:
2864         (+[WebPreferences initialize]):
2865
2866 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2867
2868         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2869         https://bugs.webkit.org/show_bug.cgi?id=177101
2870         <rdar://problem/34500648>
2871
2872         Reviewed by Brian Burg.
2873
2874         * WebInspector/WebNodeHighlight.mm:
2875         Ensure we close the window that we have just removed.
2876
2877 2017-09-20  Antti Koivisto  <antti@apple.com>
2878
2879         Remove DOM and styling support for CSS Regions
2880         https://bugs.webkit.org/show_bug.cgi?id=177221
2881
2882         Reviewed by Andreas Kling.
2883
2884         * Configurations/FeatureDefines.xcconfig:
2885         * DOM/DOMCSS.mm:
2886         (kitClass):
2887         * DOM/DOMElement.mm:
2888         (-[DOMElement webkitRegionOverset]): Deleted.
2889
2890 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2891
2892         Layering violation in Editor::createFragment
2893         https://bugs.webkit.org/show_bug.cgi?id=176123
2894
2895         Reviewed by Darin Adler.
2896
2897         * Misc/WebNSURLExtras.h:
2898         * Misc/WebNSURLExtras.mm:
2899         * WebView/WebFrame.mm:
2900         * WebView/WebHTMLView.mm:
2901         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2902
2903         * WebCoreSupport/WebEditorClient.mm:
2904         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2905         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2906         way to avoid exporting the symbol just on newer OSes.
2907
2908 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2909
2910         On iOS, getData can't get text set by setData during copy event
2911         https://bugs.webkit.org/show_bug.cgi?id=176980
2912         <rdar://problem/34453915>
2913
2914         Reviewed by Darin Adler.
2915
2916         * WebCoreSupport/WebPlatformStrategies.h:
2917         * WebCoreSupport/WebPlatformStrategies.mm:
2918         (WebPlatformStrategies::copy): Deleted.
2919
2920 2017-09-18  Andy Estes  <aestes@apple.com>
2921
2922         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2923         https://bugs.webkit.org/show_bug.cgi?id=177029
2924
2925         Reviewed by Alex Christensen.
2926
2927         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2928         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2929         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2930         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2931         * WebCoreSupport/PopupMenuMac.mm:
2932         (PopupMenuMac::show):
2933         * WebCoreSupport/WebSystemInterface.mm:
2934         (InitWebCoreSystemInterface):
2935         * WebView/WebHTMLView.mm:
2936         (-[WebHTMLView setDataSource:]):
2937         (-[WebHTMLView attachRootLayer:]):
2938         * WebView/WebView.mm:
2939         (-[WebView _needsAdobeFrameReloadingQuirk]):
2940         (-[WebView _needsLinkElementTextCSSQuirk]):
2941         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2942         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2943         (-[WebView _preferencesChanged:]):
2944
2945 2017-09-15  Andy Estes  <aestes@apple.com>
2946
2947         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2948         https://bugs.webkit.org/show_bug.cgi?id=176953
2949
2950         Reviewed by Eric Carlson.
2951
2952         * WebCoreSupport/WebSystemInterface.mm:
2953         (InitWebCoreSystemInterface):
2954
2955 2017-09-14  Andy Estes  <aestes@apple.com>
2956
2957         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2958         https://bugs.webkit.org/show_bug.cgi?id=176931
2959
2960         Reviewed by Joseph Pecoraro.
2961
2962         * WebCoreSupport/WebSystemInterface.mm:
2963         (InitWebCoreSystemInterface):
2964
2965 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2966
2967         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2968         https://bugs.webkit.org/show_bug.cgi?id=176867
2969
2970         Reviewed by Sam Weinig.
2971
2972         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2973         (WebKit::NetscapePluginInstanceProxy::enumerate):
2974
2975 2017-09-13  Andy Estes  <aestes@apple.com>
2976
2977         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2978         https://bugs.webkit.org/show_bug.cgi?id=176729
2979
2980         Reviewed by Alex Christensen.
2981
2982         * WebCoreSupport/WebSystemInterface.mm:
2983         (InitWebCoreSystemInterface):
2984         * WebView/WebView.mm:
2985         (+[WebView _setCacheModel:]):
2986
2987 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2988
2989         Refactor WebContentReader out of EditorMac and EditorIOS
2990         https://bugs.webkit.org/show_bug.cgi?id=176770
2991
2992         Reviewed by Sam Weinig.
2993
2994         * WebCoreSupport/WebEditorClient.mm:
2995
2996 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2997
2998         Dragging & dropping a file creates an attachment element even when it's disabled
2999         https://bugs.webkit.org/show_bug.cgi?id=176769
3000
3001         Reviewed by Tim Horton.
3002
3003         * WebView/WebView.mm:
3004         (-[WebView _preferencesChanged:]):
3005
3006 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3007
3008         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3009         https://bugs.webkit.org/show_bug.cgi?id=176721
3010         <rdar://problem/34373660>
3011
3012         Reviewed by Tim Horton.
3013
3014         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3015         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3016
3017         * WebView/WebView.mm:
3018         (-[WebView _startDrag:]):
3019         (-[WebView _draggedElementBounds]):
3020         (-[WebView _endedDataInteraction:global:]):
3021         * WebView/WebViewData.h:
3022
3023 2017-09-11  Andy Estes  <aestes@apple.com>
3024
3025         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3026         https://bugs.webkit.org/show_bug.cgi?id=176472
3027
3028         Reviewed by Eric Carlson.
3029
3030         * WebCoreSupport/WebSystemInterface.mm:
3031         (InitWebCoreSystemInterface):
3032
3033 2017-09-09  Mark Lam  <mark.lam@apple.com>
3034
3035         Avoid duplicate computations of ExecState::vm().
3036         https://bugs.webkit.org/show_bug.cgi?id=176647
3037
3038         Reviewed by Saam Barati.
3039
3040         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3041         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3042         (WebKit::NetscapePluginInstanceProxy::construct):
3043         (WebKit::NetscapePluginInstanceProxy::setProperty):
3044         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3045         (WebKit::NetscapePluginInstanceProxy::enumerate):
3046         * Plugins/Hosted/ProxyInstance.mm:
3047         (WebKit::ProxyRuntimeMethod::create):
3048
3049 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3050
3051         Unreviewed, rolling out r221773.
3052         https://bugs.webkit.org/show_bug.cgi?id=176614
3053
3054         This caused build failures. (Requested by mlewis13 on
3055         #webkit).
3056
3057         Reverted changeset:
3058
3059         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3060         https://bugs.webkit.org/show_bug.cgi?id=176472
3061         http://trac.webkit.org/changeset/221773
3062
3063 2017-09-07  Andy Estes  <aestes@apple.com>
3064
3065         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3066         https://bugs.webkit.org/show_bug.cgi?id=176472
3067
3068         Reviewed by Eric Carlson.
3069
3070         * WebCoreSupport/WebSystemInterface.mm:
3071         (InitWebCoreSystemInterface):
3072
3073 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3074
3075         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3076         https://bugs.webkit.org/show_bug.cgi?id=176561
3077
3078         Reviewed by Brent Fulgham.
3079
3080         * Misc/WebNSUserDefaultsExtras.mm:
3081
3082 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3083
3084         Modernize Geolocation code
3085         https://bugs.webkit.org/show_bug.cgi?id=176496
3086
3087         Reviewed by Andy Estes.
3088
3089         * WebCoreSupport/WebGeolocationClient.h:
3090         * WebCoreSupport/WebGeolocationClient.mm:
3091         (WebGeolocationClient::requestPermission):
3092         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3093         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3094         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3095         * WebView/WebView.mm:
3096         (-[WebView _commonInitializationWithFrameName:groupName:]):
3097         (-[WebView _geolocationDidFailWithMessage:]):
3098
3099 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3100
3101         Remove some unused bits of code and resources
3102         https://bugs.webkit.org/show_bug.cgi?id=176275
3103
3104         Reviewed by Dan Bernstein.
3105
3106         * Misc/WebNSFileManagerExtras.mm:
3107         Include FileSystem instead of FileSystemIOS.
3108
3109 2017-09-03  Darin Adler  <darin@apple.com>
3110
3111         [Cocoa] Tidy a few things in legacy WebHTMLView
3112         https://bugs.webkit.org/show_bug.cgi?id=176280
3113
3114         Reviewed by Dan Bernstein.
3115
3116         * WebCoreSupport/WebChromeClient.mm:
3117         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3118         methods it calls on WebHTMLView were doing nothing on iOS.
3119
3120         * WebView/WebFrame.mm:
3121         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3122         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3123
3124         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3125         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3126         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3127         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3128         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3129         Use RetainPtr instead of writing retain/release wherever possible.
3130         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3131         initialization for it. Removed various unused methods and declarations of methods.
3132         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3133         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3134         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3135         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3136         and remove CFRetain no longer needed since we don't support garbage collection any more.
3137         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3138         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3139         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3140         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3141         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3142         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3143         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3144         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3145         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3146         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3147         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3148         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3149         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3150         debug flag; we haven't used it for years and it's not clearly helpful.
3151         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3152         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3153         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3154         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3155         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3156         two additional methods in the WebPrivate category and still be called by the two
3157         methods in the WebInternal category that were already using it.
3158         (-[WebHTMLView didAddSubview:]): Deleted.
3159         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3160         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3161         place this was called, the close method.
3162         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3163         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3164         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3165         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3166         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3167         Added helper method to make the one below simpler.
3168         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3169         Compared pasteboard type strings using isEqualToString: rather than using == since
3170         we want to actually compare the string contents. Also updated to use modern for loop,
3171         renamed a local variable from "s" to "localSubresources", and factored out the handling
3172         of three image types to use the helper method above.
3173         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3174         _web_makePluginSubviewsPerformSelector:withObject: method.
3175         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3176         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3177         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3178         not call the -[NSView subviews] method to make this identical on both platforms and used
3179         a modern for loop.
3180         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3181         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3182         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3183         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3184         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3185         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3186         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3187         of it is Mac-only.
3188         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3189         method did was call itself on the main thread, and do nothing if called on main thread.
3190         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3191         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3192         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3193         half of this method.
3194         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3195         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3196         Simplified using a modern for loop and RetainPtr.
3197         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3198         (-[WebHTMLView keyDown:]): Ditto.
3199         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3200         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3201         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3202         (-[WebHTMLView complete:]): Ditto.
3203         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3204         now macOS-only.
3205         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3206         iOS since that is now macOS-only.
3207         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3208         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3209         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3210         and reorganized to use early return.
3211         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3212         on iOS, but kept there so we don't have to do #if at every call site.
3213         (-[WebHTMLView _pluginController]): Moved into internal category.
3214         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3215         there only for GC, using C++ initialization, removing obsolete comment.
3216         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3217         peculiar iOS-only comment.
3218         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3219
3220         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3221         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3222         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3223         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3224         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3225
3226         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3227         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3228         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3229         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3230         them at this time.
3231
3232 2017-09-03  Sam Weinig  <sam@webkit.org>
3233
3234         Remove CanvasProxy
3235         https://bugs.webkit.org/show_bug.cgi?id=176288
3236
3237         Reviewed by Yusuke Suzuki.
3238
3239         CanvasProxy does not appear to be in any current HTML spec
3240         and was disabled and unimplemented in our tree. Time to 
3241         get rid of it.
3242
3243         * Configurations/FeatureDefines.xcconfig:
3244
3245 2017-09-02  Andy Estes  <aestes@apple.com>
3246
3247         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3248         https://bugs.webkit.org/show_bug.cgi?id=176270
3249
3250         Reviewed by Tim Horton.
3251
3252         * Plugins/Hosted/NetscapePluginHostManager.mm:
3253         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3254         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3255         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3256         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3257         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3258         (WebKit::SoftwareCARenderer::context const):
3259         (WebKit::SoftwareCARenderer::renderContext const):
3260         (WebKit::SoftwareCARenderer::render):
3261         (-[WebHostedNetscapePluginView createPlugin]):
3262         (-[WebHostedNetscapePluginView createPluginLayer]):
3263         (-[WebHostedNetscapePluginView destroyPlugin]):
3264         (-[WebHostedNetscapePluginView drawRect:]):
3265         * WebCoreSupport/WebSystemInterface.mm:
3266         (InitWebCoreSystemInterface):
3267
3268 2017-09-01  Andy Estes  <aestes@apple.com>
3269
3270         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3271         https://bugs.webkit.org/show_bug.cgi?id=176200
3272
3273         Reviewed by Tim Horton.
3274
3275         * Carbon/HIWebView.mm:
3276         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3277         (overrideCGContext):
3278         (restoreCGContext):
3279         (Draw):
3280         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3281         (+[WebHostedNetscapePluginView initialize]):
3282         * Plugins/WebBaseNetscapePluginView.h:
3283         * Plugins/WebBaseNetscapePluginView.mm:
3284         (WebKit::sendUserChangeNotifications):
3285         * Plugins/WebNetscapePluginView.mm:
3286         (+[WebNetscapePluginView initialize]):
3287         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3288         * WebCoreSupport/WebSystemInterface.mm:
3289         (InitWebCoreSystemInterface):
3290         * WebView/WebFrame.mm:
3291         (-[WebFrame _paintBehaviorForDestinationContext:]):
3292         * WebView/WebFullScreenController.mm:
3293         (setClipRectForWindow):
3294         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3295         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3296         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3297         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3298
3299 2017-08-31  Andy Estes  <aestes@apple.com>
3300
3301         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3302         https://bugs.webkit.org/show_bug.cgi?id=176175
3303
3304         Reviewed by Brady Eidson.
3305
3306         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3307         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3308         * Plugins/Hosted/WebTextInputWindowController.m:
3309         (-[WebTextInputPanel init]):
3310         * WebCoreSupport/WebSystemInterface.mm:
3311         (InitWebCoreSystemInterface):
3312         * WebView/WebDynamicScrollBarsView.mm:
3313         (-[WebDynamicScrollBarsView scrollWheel:]):
3314         * WebView/WebHTMLView.mm:
3315         (-[WebHTMLView _removeWindowObservers]):
3316         (-[WebHTMLView addWindowObservers]):
3317         * WebView/WebView.mm:
3318         (-[WebView addWindowObserversForWindow:]):
3319         (-[WebView removeWindowObservers]):
3320         (-[WebView viewWillMoveToWindow:]):
3321
3322 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3323
3324         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3325         https://bugs.webkit.org/show_bug.cgi?id=175779
3326         <rdar://problem/22367975>
3327
3328         Reviewed by Tim Horton.
3329
3330         * WebCoreSupport/WebFrameLoaderClient.h:
3331         * WebCoreSupport/WebFrameLoaderClient.mm:
3332         (WebFrameLoaderClient::webGLPolicyForURL const):
3333         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3334
3335 2017-08-30  Andy Estes  <aestes@apple.com>
3336
3337         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3338         https://bugs.webkit.org/show_bug.cgi?id=176093
3339
3340         Reviewed by Eric Carlson.
3341
3342         * WebCoreSupport/WebSystemInterface.mm:
3343         (InitWebCoreSystemInterface):
3344
3345 2017-08-30  Andy Estes  <aestes@apple.com>
3346
3347         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3348         https://bugs.webkit.org/show_bug.cgi?id=176087
3349
3350         Reviewed by Alex Christensen.
3351
3352         * Carbon/CarbonUtils.m:
3353         (getNSAutoreleasePoolCount):
3354         (WebInitForCarbon):
3355         (PoolCleaner):
3356         * Carbon/CarbonWindowAdapter.mm:
3357         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3358         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3359         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3360         (-[CarbonWindowAdapter _windowMovedToRect:]):
3361         * Carbon/HIViewAdapter.m:
3362         * Carbon/HIWebView.mm:
3363         (Draw):
3364         (CreateNSEventAdoptingCGEvent):
3365         (CopyEventCGEvent):
3366         (CreateNSEventWithCarbonClickEvent):
3367         (Click):
3368         (CreateNSEventWithCarbonEvent):
3369         (MouseUp):
3370         (CreateNSEventWithCarbonMouseMoveEvent):
3371         (MouseMoved):
3372         (MouseDragged):
3373         (MouseWheelMoved):
3374         (WindowHandler):
3375         (HIWebViewEventHandler):
3376         * Misc/QuickDrawCompatibility.h: Removed.
3377         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3378         (getCarbonEvent):
3379         (WebNetscapePluginEventHandlerCarbon::keyDown):
3380         (WebNetscapePluginEventHandlerCarbon::keyUp):
3381         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3382         (WebNetscapePluginEventHandlerCocoa::keyDown):
3383         * Plugins/WebNetscapePluginView.mm:
3384         (-[WebNetscapePluginView tellQuickTimeToChill]):
3385
3386 2017-08-29  Andy Estes  <aestes@apple.com>
3387
3388         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3389         https://bugs.webkit.org/show_bug.cgi?id=176046
3390
3391         Reviewed by Alex Christensen.
3392
3393         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3394         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3395
3396         * Misc/WebNSFileManagerExtras.mm:
3397         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3398         (setMetaData): Deleted.
3399         * WebCoreSupport/WebSystemInterface.mm:
3400         (InitWebCoreSystemInterface):
3401
3402 2017-08-28  Andy Estes  <aestes@apple.com>
3403
3404         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3405         https://bugs.webkit.org/show_bug.cgi?id=176039
3406
3407         Reviewed by Alex Christensen.
3408
3409         * WebCoreSupport/WebSystemInterface.mm:
3410         (InitWebCoreSystemInterface):
3411         * WebView/WebPreferences.mm:
3412         (+[WebPreferences _systemCFStringEncoding]):
3413
3414 2017-08-28  Andy Estes  <aestes@apple.com>
3415
3416         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3417         https://bugs.webkit.org/show_bug.cgi?id=176032
3418
3419         Reviewed by Alex Christensen.
3420
3421         * WebCoreSupport/WebSystemInterface.mm:
3422         (InitWebCoreSystemInterface):
3423         * WebView/WebView.mm:
3424         (-[WebView _cachedResponseForURL:]):
3425
3426 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3427
3428         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3429         https://bugs.webkit.org/show_bug.cgi?id=175992
3430         <rdar://problem/34086613>
3431
3432         Reviewed by Daniel Bates.
3433
3434         * WebCoreSupport/WebPlatformStrategies.h:
3435         * WebCoreSupport/WebPlatformStrategies.mm:
3436         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3437         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3438         indicating if secure cookies were accessed.
3439
3440 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3441
3442         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3443         https://bugs.webkit.org/show_bug.cgi?id=170955
3444         <rdar://problem/31697653>
3445
3446         Reviewed by Ryosuke Niwa.
3447
3448         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3449         text is being replaced.
3450
3451         * WebView/WebHTMLView.mm:
3452         (-[WebHTMLView insertText:]):
3453
3454 2017-08-24  Chris Dumez  <cdumez@apple.com>
3455
3456         [Directory Upload] Add basic support for input.webkitdirectory
3457         https://bugs.webkit.org/show_bug.cgi?id=175950
3458         <rdar://problem/33951915>
3459
3460         Reviewed by Geoffrey Garen.
3461
3462         Add private API to toggle Directory Upload support on Mac WebKit1.
3463
3464         * WebView/WebPreferenceKeysPrivate.h:
3465         * WebView/WebPreferences.mm:
3466         (+[WebPreferences initialize]):
3467         (-[WebPreferences setDirectoryUploadEnabled:]):
3468         (-[WebPreferences directoryUploadEnabled]):
3469         * WebView/WebPreferencesPrivate.h:
3470         * WebView/WebView.mm:
3471         (-[WebView _preferencesChanged:]):
3472
3473 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3474
3475         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3476         https://bugs.webkit.org/show_bug.cgi?id=175370
3477         <rdar://problem/33799806>
3478
3479         Reviewed by Ryosuke Niwa.
3480
3481         Adjust WebEditorClient for interface changes.
3482
3483         * WebCoreSupport/WebEditorClient.h:
3484
3485 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3486
3487         Remove ChromeClient::scrollbarsModeDidChange
3488         https://bugs.webkit.org/show_bug.cgi?id=175805
3489
3490         Reviewed by Daniel Bates.
3491
3492         * WebCoreSupport/WebChromeClient.h:
3493
3494 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3495
3496         Remove ChromeClient::hasOpenedPopup
3497         https://bugs.webkit.org/show_bug.cgi?id=175804
3498
3499         Reviewed by Sam Weinig.
3500
3501         * WebCoreSupport/WebChromeClient.h:
3502         * WebCoreSupport/WebChromeClient.mm:
3503         (WebChromeClient::hasOpenedPopup const): Deleted.
3504
3505 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3506
3507         Disable access to secure cookies if an HTTPS site loads mixed content
3508         https://bugs.webkit.org/show_bug.cgi?id=157053
3509         <rdar://problem/11290808>
3510
3511         Reviewed by Dan Bates.
3512
3513         * WebCoreSupport/WebPlatformStrategies.h:
3514         * WebCoreSupport/WebPlatformStrategies.mm:
3515         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3516         indicating whether secure cookies should be included in the response.
3517
3518 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3519
3520         [PAL] Move spi/mac directory into PAL
3521         https://bugs.webkit.org/show_bug.cgi?id=175649
3522
3523         Reviewed by Myles C. Maxfield.
3524
3525         * Misc/WebSharingServicePickerController.h:
3526         * WebCoreSupport/WebContextMenuClient.mm:
3527         * WebCoreSupport/WebEditorClient.mm:
3528         * WebCoreSupport/WebSelectionServiceController.mm:
3529         * WebView/WebHTMLView.mm:
3530         * WebView/WebImmediateActionController.h:
3531         * WebView/WebImmediateActionController.mm:
3532         * WebView/WebView.mm:
3533
3534 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3535
3536         [PAL] Relocate SessionID to root
3537         https://bugs.webkit.org/show_bug.cgi?id=175684
3538
3539         Reviewed by Alex Christensen.
3540
3541         * WebCoreSupport/WebFrameNetworkingContext.mm:
3542
3543 2017-08-17  Andreas Kling  <akling@apple.com>
3544
3545         Disable CSS regions at compile time
3546         https://bugs.webkit.org/show_bug.cgi?id=175630
3547
3548         Reviewed by Antti Koivisto.
3549
3550         * Configurations/FeatureDefines.xcconfig:
3551
3552 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3553
3554         [PAL] Move SessionID into PAL
3555         https://bugs.webkit.org/show_bug.cgi?id=174192
3556
3557         Reviewed by Antti Koivisto.
3558
3559         * Misc/WebCache.mm:
3560         (+[WebCache imageForURL:]):
3561         * WebCoreSupport/WebFrameLoaderClient.h:
3562         * WebCoreSupport/WebFrameLoaderClient.mm:
3563         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3564         * WebCoreSupport/WebFrameNetworkingContext.mm:
3565         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3566         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3567         (WebFrameNetworkingContext::storageSession const):
3568         * WebCoreSupport/WebPlatformStrategies.h:
3569         * WebCoreSupport/WebPlatformStrategies.mm:
3570         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3571         * WebKitPrefix.h:
3572
3573 2017-08-16  Andy Estes  <aestes@apple.com>
3574
3575         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3576         https://bugs.webkit.org/show_bug.cgi?id=175648
3577
3578         Reviewed by Tim Horton.
3579
3580         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3581         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3582         (WebPaymentCoordinatorClient::showPaymentUI):
3583
3584 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3585
3586         [PAL] Move spi/ios and spi/win directories into PAL
3587         https://bugs.webkit.org/show_bug.cgi?id=175171
3588
3589         Reviewed by Antti Koivisto.
3590
3591         * WebCoreSupport/WebFrameLoaderClient.mm:
3592         * WebView/WebView.mm:
3593
3594 2017-08-16  Andy Estes  <aestes@apple.com>
3595
3596         [Payment Request] Add an ENABLE flag and an experimental feature preference
3597         https://bugs.webkit.org/show_bug.cgi?id=175622
3598
3599         Reviewed by Tim Horton.
3600
3601         * Configurations/FeatureDefines.xcconfig:
3602
3603 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3604
3605         [PAL] Move Sleep classes into PAL
3606         https://bugs.webkit.org/show_bug.cgi?id=175456
3607
3608         Reviewed by Ryosuke Niwa.
3609
3610         * WebView/WebFullScreenController.h:
3611
3612 2017-08-15  Youenn Fablet  <youenn@apple.com>
3613
3614         [Cache API] Adding generic support for CacheStorage and Cache methods
3615         https://bugs.webkit.org/show_bug.cgi?id=175455
3616
3617         Reviewed by Chris Dumez.
3618
3619         * WebView/WebView.mm:
3620         (-[WebView _commonInitializationWithFrameName:groupName:]):
3621
3622 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3623
3624         Remove Proximity Events and related code
3625         https://bugs.webkit.org/show_bug.cgi?id=175545
3626
3627         Reviewed by Daniel Bates.
3628
3629         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3630         and other related code.
3631
3632         * Configurations/FeatureDefines.xcconfig:
3633
3634 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3635
3636         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3637         https://bugs.webkit.org/show_bug.cgi?id=175504
3638
3639         Reviewed by Sam Weinig.
3640
3641         * Configurations/FeatureDefines.xcconfig:
3642         * DOM/DOMHTMLFormElement.mm:
3643         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3644         * WebCoreSupport/WebFrameLoaderClient.h:
3645
3646 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3647
3648         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3649         https://bugs.webkit.org/show_bug.cgi?id=175557
3650
3651         Reviewed by Jon Lee.
3652
3653         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3654
3655         * Configurations/FeatureDefines.xcconfig:
3656
3657 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3658
3659         Composition underline color is always black
3660         https://bugs.webkit.org/show_bug.cgi?id=174675
3661
3662         Reviewed by Ryosuke Niwa.
3663
3664         * WebView/WebHTMLView.mm:
3665         (extractUnderlines): If NSUnderlineColorAttributeName
3666         is not present use text color for composition underline.
3667         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3668         for composition underline in the plain text case.
3669
3670 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3671
3672         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3673         https://bugs.webkit.org/show_bug.cgi?id=175474
3674         <rdar://problem/33844628>
3675
3676         Reviewed by Wenson Hsieh.
3677
3678         Replaced the build flag by a runtime flag and disabled the feature by default.
3679
3680         * Configurations/FeatureDefines.xcconfig:
3681         * WebView/WebPreferenceKeysPrivate.h:
3682         * WebView/WebPreferences.mm:
3683         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3684         (-[WebPreferences dataTransferItemsEnabled]): Added.
3685         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3686         * WebView/WebPreferencesPrivate.h:
3687         * WebView/WebView.mm:
3688         (-[WebView _preferencesChanged:]):
3689
3690 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3691
3692         Remove ENABLE_GAMEPAD_DEPRECATED
3693         https://bugs.webkit.org/show_bug.cgi?id=175361
3694
3695         Reviewed by Carlos Garcia Campos.
3696
3697         * Configurations/FeatureDefines.xcconfig:
3698
3699 2017-08-09  Chris Dumez  <cdumez@apple.com>
3700
3701         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3702         https://bugs.webkit.org/show_bug.cgi?id=175401
3703
3704         Reviewed by Brady Eidson.
3705
3706         * WebView/WebPreferenceKeysPrivate.h:
3707         * WebView/WebPreferences.mm:
3708         (+[WebPreferences initialize]):
3709         (-[WebPreferences beaconAPIEnabled]): Deleted.
3710         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3711         * WebView/WebPreferencesPrivate.h:
3712         * WebView/WebView.mm:
3713         (-[WebView _preferencesChanged:]):
3714
3715 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3716
3717         [PAL] Move spi/cocoa and spi/cg directories into PAL
3718         https://bugs.webkit.org/show_bug.cgi?id=175175
3719
3720         Reviewed by Myles C. Maxfield.
3721
3722         * History/WebHistory.mm:
3723         * Misc/WebDownload.mm:
3724         * Misc/WebKitNSStringExtras.mm:
3725         * Plugins/Hosted/NetscapePluginHostManager.mm:
3726         * Plugins/WebPluginDatabase.mm:
3727         * WebCoreSupport/WebFrameLoaderClient.mm:
3728         * WebInspector/WebNodeHighlight.mm:
3729         * WebView/WebHTMLView.mm:
3730         * WebView/WebIndicateLayer.mm:
3731         * WebView/WebView.mm:
3732         * WebView/WebViewData.h:
3733
3734 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3735
3736         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3737         https://bugs.webkit.org/show_bug.cgi?id=175392
3738         <rdar://problem/33783207>
3739
3740         Reviewed by Tim Horton and Megan Gardner.
3741
3742         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3743
3744         * Configurations/FeatureDefines.xcconfig:
3745
3746 2017-08-09  Daniel Bates  <dabates@apple.com>
3747
3748         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3749         https://bugs.webkit.org/show_bug.cgi?id=175247
3750         <rdar://problem/33679804>
3751
3752         Reviewed by Brady Eidson.
3753
3754         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3755         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3756         clients that need to make use of this information at this time. If such a needs comes up
3757         then we can expose API/SPI similar to what we do for WebKit.
3758
3759         * WebCoreSupport/WebFrameLoaderClient.h:
3760         * WebCoreSupport/WebFrameLoaderClient.mm:
3761         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3762
3763 2017-08-08  Brady Eidson  <beidson@apple.com>
3764
3765         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3766         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3767
3768         Reviewed by Andy Estes.
3769
3770         * Misc/WebKitVersionChecks.h:
3771         * WebCoreSupport/WebFrameLoaderClient.mm:
3772         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3773           the app is linked against new WebKit with the new behavior.
3774
3775 2017-08-07  Devin Rousso  <drousso@apple.com>
3776
3777         Web Inspector: Preview Canvas path when viewing a recording
3778         https://bugs.webkit.org/show_bug.cgi?id=174967
3779
3780         Reviewed by Brian Burg.
3781
3782         * WebView/WebPreferenceKeysPrivate.h:
3783         * WebView/WebPreferences.mm:
3784         (+[WebPreferences initialize]):
3785         (-[WebPreferences inspectorAdditionsEnabled]):
3786         (-[WebPreferences setInspectorAdditionsEnabled:]):
3787         * WebView/WebPreferencesPrivate.h:
3788         * WebView/WebView.mm:
3789         (-[WebView _preferencesChanged:]):
3790         Add plumbing for new InspectorAdditions runtime flag.
3791
3792 2017-08-07  Brian Burg  <bburg@apple.com>
3793
3794         Remove CANVAS_PATH compilation guard
3795         https://bugs.webkit.org/show_bug.cgi?id=175207
3796
3797         Reviewed by Sam Weinig.
3798
3799         * Configurations/FeatureDefines.xcconfig:
3800
3801 2017-08-04  Youenn Fablet  <youenn@apple.com>
3802
3803         [Cache API] Add Cache and CacheStorage IDL definitions
3804         https://bugs.webkit.org/show_bug.cgi?id=175201
3805
3806         Reviewed by Brady Eidson.
3807
3808         * WebView/WebPreferenceKeysPrivate.h:
3809         * WebView/WebPreferences.mm:
3810         (+[WebPreferences initialize]):
3811         (-[WebPreferences cacheAPIEnabled]):
3812         (-[WebPreferences setCacheAPIEnabled:]):
3813         * WebView/WebPreferencesPrivate.h:
3814         * WebView/WebView.mm:
3815         (-[WebView _preferencesChanged:]):
3816
3817 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3818
3819         Unreviewed, rolling out r220271.
3820
3821         Rolling out due to Layout Test failing on iOS Simulator.
3822
3823         Reverted changeset:
3824
3825         "Remove STREAMS_API compilation guard"
3826         https://bugs.webkit.org/show_bug.cgi?id=175165
3827         http://trac.webkit.org/changeset/220271
3828
3829 2017-08-04  Youenn Fablet  <youenn@apple.com>
3830
3831         Remove STREAMS_API compilation guard
3832         https://bugs.webkit.org/show_bug.cgi?id=175165
3833
3834         Reviewed by Darin Adler.
3835
3836         * Configurations/FeatureDefines.xcconfig:
3837         * WebView/WebPreferences.mm:
3838         (+[WebPreferences initialize]):
3839         * WebView/WebView.mm:
3840         (-[WebView _preferencesChanged:]):
3841
3842 2017-08-03  Brian Burg  <bburg@apple.com>
3843
3844         Remove ENABLE(WEB_SOCKET) guards
3845         https://bugs.webkit.org/show_bug.cgi?id=167044
3846
3847         Reviewed by Joseph Pecoraro.
3848
3849         * Configurations/FeatureDefines.xcconfig:
3850         * WebView/WebPreferencesPrivate.h:
3851
3852 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3853
3854         [PAL] Move spi/cf directory into PAL
3855         https://bugs.webkit.org/show_bug.cgi?id=175057
3856
3857         Reviewed by Antti Koivisto.
3858
3859         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3860         * Plugins/WebNetscapePluginStream.mm:
3861         * WebCoreSupport/WebFrameNetworkingContext.mm:
3862         * WebView/WebPreferences.mm:
3863         * WebView/WebView.mm:
3864
3865 2017-08-03  Youenn Fablet  <youenn@apple.com>
3866
3867         Remove FETCH_API compilation guard
3868         https://bugs.webkit.org/show_bug.cgi?id=175154
3869
3870         Reviewed by Chris Dumez.
3871
3872         * Configurations/FeatureDefines.xcconfig:
3873         * WebView/WebPreferences.mm:
3874         (+[WebPreferences initialize]):
3875         * WebView/WebView.mm:
3876         (-[WebView _preferencesChanged:]):
3877
3878 2017-08-03  Brady Eidson  <beidson@apple.com>
3879
3880         Add SW IDLs and stub out basic functionality.
3881         https://bugs.webkit.org/show_bug.cgi?id=175115
3882
3883         Reviewed by Chris Dumez.
3884
3885         * Configurations/FeatureDefines.xcconfig:
3886
3887 2017-08-02  Sam Weinig  <sam@webkit.org>
3888
3889         [WebIDL] Convert MutationCallback to be a normal generated callback
3890         https://bugs.webkit.org/show_bug.cgi?id=174140
3891
3892         Reviewed by Darin Adler.
3893
3894         * DOM/DOMDocument.mm:
3895         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3896         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3897         Pass, now necessary, Document to NativeNodeFilter constructor.
3898
3899 2017-08-01  Chris Dumez  <cdumez@apple.com>
3900
3901         Add initial support for navigator.sendBeacon
3902         https://bugs.webkit.org/show_bug.cgi?id=175007
3903         <rdar://problem/33547728>
3904
3905         Reviewed by Sam Weinig.
3906
3907         Add setting to toggle support for the Beacon API (it is disabled by default).
3908
3909         * WebView/WebPreferenceKeysPrivate.h:
3910         * WebView/WebPreferences.mm:
3911         (+[WebPreferences initialize]):
3912         (-[WebPreferences beaconAPIEnabled]):
3913         (-[WebPreferences setBeaconAPIEnabled:]):
3914         * WebView/WebPreferencesPrivate.h:
3915         * WebView/WebView.mm:
3916         (-[WebView _preferencesChanged:]):
3917
3918 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3919
3920         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3921         https://bugs.webkit.org/show_bug.cgi?id=174437
3922
3923         Reviewed by Darin Adler.
3924
3925         Remove redundant Web- prefix from classes in WebKit namespace.
3926
3927         * WebView/WebView.mm:
3928         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3929         * WebView/WebViewData.h:
3930         * WebView/WebViewData.mm:
3931
3932 2017-07-26  Brian Burg  <bburg@apple.com>
3933
3934         Remove WEB_TIMING feature flag
3935         https://bugs.webkit.org/show_bug.cgi?id=174795
3936
3937         Reviewed by Alex Christensen.
3938
3939         * Configurations/FeatureDefines.xcconfig:
3940
3941 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3942
3943         Async image decoding for large images should be disabled after the first time a tile is painted
3944         https://bugs.webkit.org/show_bug.cgi?id=174451
3945         <rdar://problem/31246421>
3946
3947         Reviewed by Simon Fraser.
3948
3949         * WebView/WebFrame.mm:
3950         (-[WebFrame _paintBehaviorForDestinationContext:]):
3951         (-[WebFrame _drawRect:contentsOnly:]):
3952         * WebView/WebHTMLView.mm:
3953         (imageFromRect):
3954
3955 2017-07-23  Darin Adler  <darin@apple.com>
3956
3957         More NeverDestroyed and related cleanup
3958         https://bugs.webkit.org/show_bug.cgi?id=174745
3959
3960         Reviewed by Alex Christensen.
3961
3962         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3963         for names that aren't even used in this file.
3964         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3965         -[NSArray arrayWithObject:].
3966         (-[DOMNode absoluteQuads]): Ditto.
3967         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3968         of writing out various types.
3969         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3970         syntax instea of -[NSArray arrayWithObject:].
3971         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3972         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3973         of writing out various types.
3974         (-[DOMHTMLImageElement mimeType]): Ditto.
3975
3976 2017-07-24  Chris Dumez  <cdumez@apple.com>
3977
3978         ExceptionCode enumeration should use modern exception names
3979         https://bugs.webkit.org/show_bug.cgi?id=174794
3980
3981         Reviewed by Geoffrey Garen.
3982
3983         * DOM/ExceptionHandlers.mm:
3984         (raiseNotSupportedErrorException):
3985
3986 2017-07-23  Chris Dumez  <cdumez@apple.com>
3987
3988         Drop ExceptionCodeDescription class
3989         https://bugs.webkit.org/show_bug.cgi?id=174757
3990
3991         Reviewed by Darin Adler.
3992
3993         Stop using ExceptionCodeDescription.
3994
3995         * DOM/ExceptionHandlers.mm:
3996         (raiseDOMErrorException):
3997
3998 2017-07-21  Andreas Kling  <akling@apple.com>
3999
4000         Use more references in event dispatch code
4001         https://bugs.webkit.org/show_bug.cgi?id=174681
4002
4003         Reviewed by Geoffrey Garen.
4004
4005         * DOM/ObjCEventListener.h:
4006         * DOM/ObjCEventListener.mm:
4007         (WebCore::ObjCEventListener::handleEvent):
4008         * WebCoreSupport/WebFrameLoaderClient.mm:
4009         (NetscapePluginWidget::handleEvent):
4010
4011 2017-07-21  Brady Eidson  <beidson@apple.com>
4012
4013         Get rid of WebCore IconDatabase code.
4014         https://bugs.webkit.org/show_bug.cgi?id=174700
4015
4016         Reviewed by Tim Horton.
4017
4018         * Misc/WebCoreStatistics.mm:
4019         (+[WebCoreStatistics iconPageURLMappingCount]):
4020         (+[WebCoreStatistics iconRetainedPageURLCount]):
4021         (+[WebCoreStatistics iconRecordCount]):
4022         (+[WebCoreStatistics iconsWithDataCount]):
4023         * WebCoreSupport/WebFrameLoaderClient.h:
4024         * WebCoreSupport/WebFrameLoaderClient.mm:
4025         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
4026         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
4027         * WebView/WebView.mm:
4028         (-[WebView mainFrameIconURL]):
4029
4030 2017-07-20  Chris Dumez  <cdumez@apple.com>
4031
4032         Drop legacy XPathException type
4033         https://bugs.webkit.org/show_bug.cgi?id=174679
4034
4035         Reviewed by Sam Weinig.
4036
4037         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
4038         no longer expose XPathException.
4039
4040         * DOM/ExceptionHandlers.mm:
4041         (raiseDOMErrorException):
4042
4043 2017-07-20  Chris Dumez  <cdumez@apple.com>
4044
4045         Unreviewed, rolling out r219706.
4046
4047         Broke iOS build
4048
4049         Reverted changeset:
4050
4051         "Drop legacy XPathException type"
4052         https://bugs.webkit.org/show_bug.cgi?id=174679
4053         http://trac.webkit.org/changeset/219706
4054
4055 2017-07-20  Chris Dumez  <cdumez@apple.com>
4056
4057         Drop legacy XPathException type
4058         https://bugs.webkit.org/show_bug.cgi?id=174679
4059
4060         Reviewed by Sam Weinig.
4061
4062         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
4063         no longer expose XPathException.
4064
4065         * DOM/ExceptionHandlers.mm:
4066         (raiseDOMErrorException):
4067         * WebKit.exp:
4068
4069 2017-07-20  Chris Dumez  <cdumez@apple.com>
4070
4071         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
4072         https://bugs.webkit.org/show_bug.cgi?id=174660
4073
4074         Reviewed by Geoffrey Garen.
4075
4076         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
4077         This essentially replaces a branch to figure out if the new size is less or greater than the
4078         current size by an assertion.
4079
4080         * Plugins/WebNetscapePluginView.mm:
4081         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
4082
4083 2017-07-20  Brady Eidson  <beidson@apple.com>
4084
4085         Deprecate WebIconDatabase in WebKitLegacy/mac.
4086         https://bugs.webkit.org/show_bug.cgi?id=174607
4087
4088         Reviewed by Alex Christensen.
4089
4090         This patch:
4091         1 - Formally deprecates WebIconDatabase (which was never API anyways)
4092         2 - Guts the class to where it can only return the default icon at the small size
4093         3 - Reworks other parts of WebKitLegacy that used it for anything to either
4094             use something else or to not do anything.
4095         
4096         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
4097         and that patch will remove all of the last remnants of WebIconDatabase.
4098         
4099         * History/WebHistoryItem.mm:
4100         (-[WebHistoryItem icon]):
4101
4102         * Misc/WebIconDatabase.h:
4103         * Misc/WebIconDatabase.mm:
4104         (-[WebIconDatabase init]):
4105 &n