Allow clients to override their own hardware media requirements where no fallback...
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-07-14  Jer Noble  <jer.noble@apple.com>
2
3         Allow clients to override their own hardware media requirements where no fallback media exists.
4         https://bugs.webkit.org/show_bug.cgi?id=174426
5         <rdar://problem/32537704>
6
7         Reviewed by Eric Carlson.
8
9         Add a new WebPreferences property to control WebCore's new
10         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
11
12         * WebView/WebPreferenceKeysPrivate.h:
13         * WebView/WebPreferences.mm:
14         (+[WebPreferences initialize]):
15         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
16         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
17         * WebView/WebPreferencesPrivate.h:
18         * WebView/WebView.mm:
19         (-[WebView _preferencesChanged:]):
20
21 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
22
23         Async image decoding for large images should be disabled by default
24         https://bugs.webkit.org/show_bug.cgi?id=174432
25
26         Reviewed by Simon Fraser.
27
28         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
29         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
30         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
31            a child view instead of propagating PaintBehaviorSnapshotting.
32         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
33            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
34
35         * WebView/WebFrame.mm:
36         (-[WebFrame _paintBehaviorForDestinationContext:]):
37         (-[WebFrame _drawRect:contentsOnly:]):
38         * WebView/WebHTMLView.mm:
39         (imageFromRect):
40
41 2017-07-12  Daniel Bates  <dabates@apple.com>
42
43         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
44         https://bugs.webkit.org/show_bug.cgi?id=174427
45
46         Rubber-stamped by Brady Eidson.
47
48         * WebView/WebPDFView.mm:
49         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
50
51 2017-07-12  Matt Lewis  <jlewis3@apple.com>
52
53         Unreviewed, rolling out r219401.
54
55         This revision rolled out the previous patch, but after talking
56         with reviewer, a rebaseline is what was needed.Rolling back in
57         before rebaseline.
58
59         Reverted changeset:
60
61         "Unreviewed, rolling out r219379."
62         https://bugs.webkit.org/show_bug.cgi?id=174400
63         http://trac.webkit.org/changeset/219401
64
65 2017-07-12  Matt Lewis  <jlewis3@apple.com>
66
67         Unreviewed, rolling out r219379.
68
69         This revision caused a consistent failure in the test
70         fast/dom/Window/property-access-on-cached-window-after-frame-
71         removed.html.
72
73         Reverted changeset:
74
75         "Remove NAVIGATOR_HWCONCURRENCY"
76         https://bugs.webkit.org/show_bug.cgi?id=174400
77         http://trac.webkit.org/changeset/219379
78
79 2017-07-11  Dean Jackson  <dino@apple.com>
80
81         Remove NAVIGATOR_HWCONCURRENCY
82         https://bugs.webkit.org/show_bug.cgi?id=174400
83
84         * Configurations/FeatureDefines.xcconfig:
85
86 2017-07-11  Dean Jackson  <dino@apple.com>
87
88         Rolling out r219372.
89
90         * Configurations/FeatureDefines.xcconfig:
91
92 2017-07-11  Dean Jackson  <dino@apple.com>
93
94         Remove NAVIGATOR_HWCONCURRENCY
95         https://bugs.webkit.org/show_bug.cgi?id=174400
96
97         * Configurations/FeatureDefines.xcconfig:
98
99 2017-07-03  Brian Burg  <bburg@apple.com>
100
101         Web Replay: remove some unused code
102         https://bugs.webkit.org/show_bug.cgi?id=173903
103
104         Rubber-stamped by Joseph Pecoraro.
105
106         * Configurations/FeatureDefines.xcconfig:
107
108 2017-07-09  Brady Eidson  <beidson@apple.com>
109
110         Remove some obsolete WebKitVersionChecks.
111         https://bugs.webkit.org/show_bug.cgi?id=174294
112
113         Reviewed by Dan Bernstein.
114
115         * Misc/WebKitVersionChecks.h:
116
117         * WebView/WebHTMLView.mm:
118         (-[WebHTMLView hitTest:]):
119
120         * WebView/WebView.mm:
121         (shouldRespectPriorityInCSSAttributeSetters):
122         (-[WebView _commonInitializationWithFrameName:groupName:]):
123         (-[WebView _preferencesChanged:]):
124         (shouldTransformsAffectOverflow): Deleted.
125         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
126
127 2017-07-08  Brady Eidson  <beidson@apple.com>
128
129         Remove some obsolete RuntimeApplicationChecks.
130         https://bugs.webkit.org/show_bug.cgi?id=174293
131
132         Reviewed by Dan Bernstein.
133
134         * Misc/WebKitVersionChecks.h:
135         * WebView/WebView.mm:
136         (+[WebView enableWebThread]):
137         (-[WebView _needsPreHTML5ParserQuirks]):
138
139 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
140
141         Drop NOSNIFF compile flag
142         https://bugs.webkit.org/show_bug.cgi?id=174289
143
144         Reviewed by Michael Catanzaro.
145
146         * Configurations/FeatureDefines.xcconfig:
147
148 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
149
150         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
151         https://bugs.webkit.org/show_bug.cgi?id=174150
152
153         Reviewed by Mark Lam.
154
155         * DOM/DOM.mm:
156         (lookupElementClass):
157
158 2017-07-06  Brady Eidson  <beidson@apple.com>
159
160         Add logging to first attempt to use the WebIconDatabase class.
161         https://bugs.webkit.org/show_bug.cgi?id=174190
162
163         Reviewed by Andy Estes.
164
165         * Misc/WebIconDatabase.mm:
166         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
167         * Misc/WebKitVersionChecks.h:
168
169 2017-07-06  Matt Lewis  <jlewis3@apple.com>
170
171         Unreviewed, rolling out r219178.
172
173         This caused a consistent failure with the API test
174         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
175
176         Reverted changeset:
177
178         "[WTF] Clean up StringStatics.cpp by using
179         LazyNeverDestroyed<> for Atoms"
180         https://bugs.webkit.org/show_bug.cgi?id=174150
181         http://trac.webkit.org/changeset/219178
182
183 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
184
185         [WTF] Move SoftLinking.h into WTF
186         https://bugs.webkit.org/show_bug.cgi?id=174000
187
188         Reviewed by Alex Christensen.
189
190         * Plugins/WebNetscapePluginView.mm:
191         * Plugins/WebPluginController.mm:
192         * WebCoreSupport/WebInspectorClient.mm:
193         * WebView/WebFullScreenController.mm:
194         * WebView/WebImmediateActionController.mm:
195         * WebView/WebView.mm:
196
197 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
198
199         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
200         https://bugs.webkit.org/show_bug.cgi?id=174150
201
202         Reviewed by Mark Lam.
203
204         * DOM/DOM.mm:
205         (lookupElementClass):
206
207 2017-07-05  Brady Eidson  <beidson@apple.com>
208
209         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
210         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
211
212         Reviewed by Alex Christensen.
213
214         Adopt to the new constructor for FrameLoadRequest.
215
216         * WebView/WebPDFView.mm:
217         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
218
219 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
220
221         Make WebKit's public headers on Mac and iOS C++ module safe
222         https://bugs.webkit.org/show_bug.cgi?id=174175
223
224         Reviewed by Alex Christensen.
225
226         Fixed the header files.
227
228         * Misc/WebDownload.h:
229         * Misc/WebKitErrors.h:
230         * Plugins/WebPluginContainer.h:
231         * WebView/WebResourceLoadDelegate.h:
232
233 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
234
235         Remove copy of ICU headers from WebKit
236         https://bugs.webkit.org/show_bug.cgi?id=116407
237
238         Reviewed by Alex Christensen.
239
240         Use WTF's copy of ICU headers.
241
242         * Configurations/WebKitLegacy.xcconfig:
243         * icu/unicode/localpointer.h: Removed.
244         * icu/unicode/parseerr.h: Removed.
245         * icu/unicode/platform.h: Removed.
246         * icu/unicode/ptypes.h: Removed.
247         * icu/unicode/putil.h: Removed.
248         * icu/unicode/uchar.h: Removed.
249         * icu/unicode/uconfig.h: Removed.
250         * icu/unicode/ucurr.h: Removed.
251         * icu/unicode/uidna.h: Removed.
252         * icu/unicode/uiter.h: Removed.
253         * icu/unicode/umachine.h: Removed.
254         * icu/unicode/unorm.h: Removed.
255         * icu/unicode/unorm2.h: Removed.
256         * icu/unicode/urename.h: Removed.
257         * icu/unicode/uscript.h: Removed.
258         * icu/unicode/ustring.h: Removed.
259         * icu/unicode/utf.h: Removed.
260         * icu/unicode/utf16.h: Removed.
261         * icu/unicode/utf8.h: Removed.
262         * icu/unicode/utf_old.h: Removed.
263         * icu/unicode/utypes.h: Removed.
264         * icu/unicode/uvernum.h: Removed.
265         * icu/unicode/uversion.h: Removed.
266
267 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
268
269         Add WebKitPrivateFrameworkStubs for iOS 11
270         https://bugs.webkit.org/show_bug.cgi?id=173988
271
272         Reviewed by David Kilzer.
273
274         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
275         use the same directory for private framework stubs.
276
277 2017-07-03  Matt Lewis  <jlewis3@apple.com>
278
279         Unreviewed, rolling out r219103.
280
281         Caused multiple build failures.
282
283         Reverted changeset:
284
285         "Remove copy of ICU headers from WebKit"
286         https://bugs.webkit.org/show_bug.cgi?id=116407
287         http://trac.webkit.org/changeset/219103
288
289 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
290
291         Remove copy of ICU headers from WebKit
292         https://bugs.webkit.org/show_bug.cgi?id=116407
293
294         Reviewed by Alex Christensen.
295
296         Use WTF's copy of ICU headers.
297
298         * Configurations/WebKitLegacy.xcconfig:
299         * icu/unicode/localpointer.h: Removed.
300         * icu/unicode/parseerr.h: Removed.
301         * icu/unicode/platform.h: Removed.
302         * icu/unicode/ptypes.h: Removed.
303         * icu/unicode/putil.h: Removed.
304         * icu/unicode/uchar.h: Removed.
305         * icu/unicode/uconfig.h: Removed.
306         * icu/unicode/ucurr.h: Removed.
307         * icu/unicode/uidna.h: Removed.
308         * icu/unicode/uiter.h: Removed.
309         * icu/unicode/umachine.h: Removed.
310         * icu/unicode/unorm.h: Removed.
311         * icu/unicode/unorm2.h: Removed.
312         * icu/unicode/urename.h: Removed.
313         * icu/unicode/uscript.h: Removed.
314         * icu/unicode/ustring.h: Removed.
315         * icu/unicode/utf.h: Removed.
316         * icu/unicode/utf16.h: Removed.
317         * icu/unicode/utf8.h: Removed.
318         * icu/unicode/utf_old.h: Removed.
319         * icu/unicode/utypes.h: Removed.
320         * icu/unicode/uvernum.h: Removed.
321         * icu/unicode/uversion.h: Removed.
322
323 2017-07-03  Brady Eidson  <beidson@apple.com>
324
325         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
326         https://bugs.webkit.org/show_bug.cgi?id=174073
327
328         Reviewed by Andy Estes.
329
330         WebView now keeps a direct copy of its main frame icon as a member variable.
331         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
332         
333         This change causes a progression in KVO observation of the mainFrameIcon property as we now
334         have both the old icon and new icon at the time it changes.
335
336         * WebCoreSupport/WebFrameLoaderClient.h:
337         * WebCoreSupport/WebFrameLoaderClient.mm:
338         (WebFrameLoaderClient::prepareForDataSourceReplacement):
339         (WebFrameLoaderClient::getLoadDecisionForIcons):
340         (WebFrameLoaderClient::finishedLoadingIcon):
341         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
342         (WebFrameLoaderClient::registerForIconNotification): Deleted.
343
344         * WebView/WebView.mm:
345         (+[WebView _setIconLoadingEnabled:]):
346         (+[WebView _isIconLoadingEnabled]):
347         (-[WebView mainFrameIcon]):
348         (-[WebView _setMainFrameIcon:]):
349         (-[WebView _receivedIconChangedNotification:]): Deleted.
350         (-[WebView _registerForIconNotification:]): Deleted.
351         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
352         * WebView/WebViewData.h:
353         * WebView/WebViewInternal.h:
354         * WebView/WebViewPrivate.h:
355
356 2017-07-03  Sam Weinig  <sam@webkit.org>
357
358         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
359         https://bugs.webkit.org/show_bug.cgi?id=174083
360
361         Reviewed by Alex Christensen.
362
363         * Configurations/FeatureDefines.xcconfig:
364         Add ENABLE_NAVIGATOR_STANDALONE.
365
366 2017-07-03  Tim Horton  <timothy_horton@apple.com>
367
368         Expose unobscuredSafeAreaInsets on WebView
369         https://bugs.webkit.org/show_bug.cgi?id=174075
370         <rdar://problem/33096997>
371
372         Reviewed by Beth Dakin.
373
374         * WebView/WebView.mm:
375         (-[WebView _setUnobscuredSafeAreaInsets:]):
376         (-[WebView _unobscuredSafeAreaInsets]):
377         * WebView/WebViewPrivate.h:
378         Expose unobscuredSafeAreaInsets as a new private property on WebView,
379         similar to how it is exposed in WebKit2.
380
381 2017-07-03  Andy Estes  <aestes@apple.com>
382
383         [Xcode] Add an experimental setting to build with ccache
384         https://bugs.webkit.org/show_bug.cgi?id=173875
385
386         Reviewed by Tim Horton.
387
388         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
389
390 2017-07-03  Tim Horton  <timothy_horton@apple.com>
391
392         Expose WebPreferences for viewport-fit and constant() properties
393         https://bugs.webkit.org/show_bug.cgi?id=174072
394         <rdar://problem/33096639>
395
396         Reviewed by Ryosuke Niwa.
397
398         * WebView/WebPreferenceKeysPrivate.h:
399         * WebView/WebPreferences.mm:
400         (-[WebPreferences viewportFitEnabled]):
401         (-[WebPreferences setViewportFitEnabled:]):
402         (-[WebPreferences constantPropertiesEnabled]):
403         (-[WebPreferences setConstantPropertiesEnabled:]):
404         * WebView/WebPreferencesPrivate.h:
405         * WebView/WebView.mm:
406         (-[WebView _preferencesChanged:]):
407
408 2017-07-01  Tim Horton  <timothy_horton@apple.com>
409
410         Expose viewport-fit value to UIKit via viewport arguments dictionary
411         https://bugs.webkit.org/show_bug.cgi?id=174071
412         <rdar://problem/33096620>
413
414         Reviewed by Wenson Hsieh.
415
416         * History/WebHistoryItem.mm:
417         * History/WebHistoryItemPrivate.h:
418         Add another dictionary key and three values.
419
420 2017-07-01  Dan Bernstein  <mitz@apple.com>
421
422         [iOS] Remove code only needed when building for iOS 9.x
423         https://bugs.webkit.org/show_bug.cgi?id=174068
424
425         Reviewed by Tim Horton.
426
427         * Configurations/FeatureDefines.xcconfig:
428
429 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
430
431         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
432         https://bugs.webkit.org/show_bug.cgi?id=174004
433
434         Reviewed by Simon Fraser.
435
436         * WebCoreSupport/WebPluginInfoProvider.mm:
437
438 2017-07-01  Dan Bernstein  <mitz@apple.com>
439
440         [macOS] Remove code only needed when building for OS X Yosemite
441         https://bugs.webkit.org/show_bug.cgi?id=174067
442
443         Reviewed by Tim Horton.
444
445         * Configurations/Base.xcconfig:
446         * Configurations/DebugRelease.xcconfig:
447         * Configurations/FeatureDefines.xcconfig:
448         * Configurations/Version.xcconfig:
449         * Plugins/WebBasePluginPackage.mm:
450         (-[WebBasePluginPackage getPluginInfoFromPLists]):
451         * WebCoreSupport/PopupMenuMac.mm:
452         (PopupMenuMac::show):
453         * WebCoreSupport/WebInspectorClient.mm:
454         (WebInspectorFrontendClient::startWindowDrag):
455         (-[WebInspectorWindowController window]):
456         * WebView/WebView.mm:
457         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
458
459 2017-06-30  Daniel Bates  <dabates@apple.com>
460
461         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
462         https://bugs.webkit.org/show_bug.cgi?id=165160
463         <rdar://problem/29451999>
464
465         Reviewed by Brady Eidson.
466
467         Pass the document that is requesting the load to the loader.
468
469         * WebView/WebPDFView.mm:
470         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
471
472 2017-06-29  Jer Noble  <jer.noble@apple.com>
473
474         Make Legacy EME API controlled by RuntimeEnabled setting.
475         https://bugs.webkit.org/show_bug.cgi?id=173994
476
477         Reviewed by Sam Weinig.
478
479         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
480
481         * Configurations/FeatureDefines.xcconfig:
482         * WebView/WebPreferenceKeysPrivate.h:
483         * WebView/WebPreferences.mm:
484         (+[WebPreferences initialize]):
485         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
486         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
487         * WebView/WebPreferencesPrivate.h:
488         * WebView/WebView.mm:
489         (-[WebView _preferencesChanged:]):
490
491 2017-06-30  Chris Dumez  <cdumez@apple.com>
492
493         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
494         https://bugs.webkit.org/show_bug.cgi?id=174013
495
496         Reviewed by Brent Fulgham.
497
498         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
499         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
500
501         * WebView/WebView.mm:
502         (-[WebView _commonInitializationWithFrameName:groupName:]):
503
504 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
505
506         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
507         https://bugs.webkit.org/show_bug.cgi?id=174017
508         <rdar://problem/32959782>
509
510         Reviewed by Simon Fraser.
511
512         Use root view coordinates when computing the drag caret rect.
513
514         * WebView/WebView.mm:
515         (-[WebView _dataInteractionCaretRect]):
516
517 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
518
519         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
520         https://bugs.webkit.org/show_bug.cgi?id=173899
521         rdar://problem/32994474
522
523         Reviewed by Tim Horton.
524
525         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
526         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
527         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
528
529         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
530         documentView is a WebHTMLView.
531
532         * WebView/WebFrame.mm:
533         (-[WebFrame _webHTMLDocumentView]):
534         (-[WebFrame _paintBehaviorForDestinationContext:]):
535         (-[WebFrame _drawRect:contentsOnly:]):
536         (-[WebFrame setTimeoutsPaused:]):
537         (-[WebFrame prepareForPause]):
538         (-[WebFrame resumeFromPause]):
539         (-[WebFrame resetTextAutosizingBeforeLayout]):
540         * WebView/WebHTMLView.mm:
541         (-[WebHTMLView drawLayer:inContext:]):
542         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
543         * WebView/WebHTMLViewInternal.h:
544
545 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
546
547         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
548         https://bugs.webkit.org/show_bug.cgi?id=173854
549         <rdar://problem/32236827>
550
551         Reviewed by Ryosuke Niwa and Tim Horton.
552
553         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
554         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
555
556         * WebView/WebView.mm:
557         (-[WebView _startDrag:]):
558         (-[WebView _dragSourceAction]):
559         (-[WebView _draggedLinkTitle]):
560         (-[WebView _draggedLinkURL]):
561         (-[WebView _draggedElementBounds]):
562         (-[WebView _endedDataInteraction:global:]):
563         * WebView/WebViewData.h:
564         * WebView/WebViewPrivate.h:
565
566 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
567
568         Refactor drag start codepaths to plumb a DragItem to client layers
569         https://bugs.webkit.org/show_bug.cgi?id=173832
570         Work towards <rdar://problem/32236827>
571
572         Reviewed by Ryosuke Niwa and Tim Horton.
573
574         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
575         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
576         to _startDrag: to match logic used to start a drag on other platforms.
577
578         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
579         through the DragItem struct.
580
581         * WebCoreSupport/WebDragClient.h:
582         * WebCoreSupport/WebDragClient.mm:
583         (WebDragClient::startDrag):
584         (WebDragClient::dragSourceActionMaskForPoint):
585         (WebDragClient::willPerformDragSourceAction):
586         (WebDragClient::beginDrag):
587         * WebView/WebView.mm:
588         (-[WebView _startDrag:]):
589         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
590         * WebView/WebViewInternal.h:
591
592 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
593
594         Remove excessive headers from JavaScriptCore
595         https://bugs.webkit.org/show_bug.cgi?id=173812
596
597         Reviewed by Darin Adler.
598
599         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
600         * WebView/WebView.mm:
601
602 2017-06-23  Tim Horton  <timothy_horton@apple.com>
603
604         Remove an unused typedef from WebFrameLoaderClient
605         https://bugs.webkit.org/show_bug.cgi?id=173795
606
607         Reviewed by Simon Fraser.
608
609         * WebCoreSupport/WebFrameLoaderClient.h:
610         This unused typedef in the global namespace conflicts with one in a macOS system header.
611         Also... it's unused.
612         Remove it.
613
614 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
615
616         Remove excessive headers from WebCore/{bindings,css,dom}
617         https://bugs.webkit.org/show_bug.cgi?id=173766
618
619         Reviewed by Simon Fraser.
620
621         * DOM/DOMInternal.mm:
622
623 2017-06-22  Daniel Bates  <dabates@apple.com>
624
625         Make FrameLoadRequest a move-only type
626         https://bugs.webkit.org/show_bug.cgi?id=173682
627
628         Reviewed by Alex Christensen and Darin Adler.
629
630         A FrameLoadRequest groups together the information to perform a load into a single object
631         that is more manageable to pass around than its constituent parts. Code that receives a
632         FrameLoadRequest is expected to extract out the information it needs to complete its task.
633         And it does not make sense to re-use the same FrameLoadRequest object for more than one
634         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
635
636         * Plugins/WebPluginController.mm:
637         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
638         * WebView/WebPDFView.mm:
639         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
640
641 2017-06-21  Antoine Quint  <graouts@apple.com>
642
643         Ensure DRT always logs rAF suspension debugging code
644         https://bugs.webkit.org/show_bug.cgi?id=173681
645
646         Reviewed by Tim "Mr. T" Horton.
647
648         * WebView/WebPreferenceKeysPrivate.h:
649         * WebView/WebPreferences.mm:
650         (+[WebPreferences initialize]):
651         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
652         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
653         * WebView/WebPreferencesPrivate.h:
654         * WebView/WebView.mm:
655         (-[WebView _preferencesChanged:]):
656
657 2017-06-21  Daniel Bates  <dabates@apple.com>
658
659         Cleanup FrameLoadRequest
660         https://bugs.webkit.org/show_bug.cgi?id=173564
661         <rdar://problem/32903570>
662
663         Reviewed by Brent Fulgham.
664
665         * WebView/WebPDFView.mm:
666         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
667         into a local variable and use C++11 brace initialization syntax to make it easier to identify
668         the arguments passed to FrameLoader::loadFrameRequest().
669
670 2017-06-21  Antoine Quint  <graouts@apple.com>
671
672         Add logging to identify when the Page suspends scripted animations
673         https://bugs.webkit.org/show_bug.cgi?id=173626
674
675         Reviewed by Tim Horton.
676
677         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
678         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
679
680         * WebView/WebPreferenceKeysPrivate.h:
681         * WebView/WebPreferences.mm:
682         (+[WebPreferences initialize]):
683         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
684         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
685         * WebView/WebPreferencesPrivate.h:
686         * WebView/WebView.mm:
687         (-[WebView _preferencesChanged:]):
688
689 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
690
691         Disable font variations on macOS Sierra and iOS 10
692         https://bugs.webkit.org/show_bug.cgi?id=173618
693         <rdar://problem/32879164>
694
695         Reviewed by Jon Lee.
696
697         * Configurations/FeatureDefines.xcconfig:
698
699 2017-06-20  Daniel Bates  <dabates@apple.com>
700
701         Have FrameLoadRequest takes a Frame& instead of a Frame*
702         https://bugs.webkit.org/show_bug.cgi?id=173614
703         <rdar://problem/32884890>
704
705         Reviewed by Brent Fulgham.
706
707         * Plugins/WebPluginController.mm:
708         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
709         * WebView/WebFrame.mm:
710         (-[WebFrame loadRequest:]):
711         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
712
713 2017-06-19  Frederic Wang  <fwang@igalia.com>
714
715         [Mac] Add an experimental feature setting for async frame scrolling
716         https://bugs.webkit.org/show_bug.cgi?id=173359
717
718         Reviewed by Simon Fraser.
719
720         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
721         * WebView/WebPreferences.mm:
722         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
723         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
724         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
725         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
726         * WebView/WebView.mm:
727         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
728         scrolling.
729
730 2017-06-19  Chris Dumez  <cdumez@apple.com>
731
732         Use WTF::Function instead of std::function in more places in WebCore/
733         https://bugs.webkit.org/show_bug.cgi?id=173535
734
735         Reviewed by Antti Koivisto.
736
737         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
738
739         * WebCoreSupport/WebFrameLoaderClient.h:
740         * WebCoreSupport/WebFrameLoaderClient.mm:
741         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
742         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
743         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
744         (WebFrameLoaderClient::dispatchWillSubmitForm):
745         (WebFrameLoaderClient::setUpPolicyListener):
746         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
747         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
748
749 2017-05-14 Frederic Wang  <fwang@igalia.com>
750
751         Add heuristic to avoid flattening "fullscreen" iframes
752         https://bugs.webkit.org/show_bug.cgi?id=171914
753
754         Reviewed by Simon Fraser.
755
756         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
757
758         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
759         * WebView/WebPreferences.mm:
760         (+[WebPreferences initialize]): Handle frame flattening as an enum.
761         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
762         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
763         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
764         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
765         * WebView/WebPreferencesPrivate.h: Ditto.
766         * WebView/WebView.mm:
767         (-[WebView _preferencesChanged:]): Ditto.
768         * WebView/WebPreferencesPrivate.h: Add new enum definition.
769
770 2017-06-17  Chris Dumez  <cdumez@apple.com>
771
772         Use WTF::Function instead of std::function in WebKit2/
773         https://bugs.webkit.org/show_bug.cgi?id=173504
774
775         Reviewed by Darin Adler.
776
777         Use WTF::Function instead of std::function in WebKit2/ to avoid
778         unnecessary copying.
779
780         * Plugins/Hosted/HostedNetscapePluginStream.h:
781         * Plugins/Hosted/HostedNetscapePluginStream.mm:
782         (WebKit::HostedNetscapePluginStream::willSendRequest):
783         * Plugins/WebNetscapePluginStream.h:
784         * Plugins/WebNetscapePluginStream.mm:
785         (WebNetscapePluginStream::willSendRequest):
786         * WebCoreSupport/WebPaymentCoordinatorClient.h:
787         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
788         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
789         (WebPaymentCoordinatorClient::openPaymentSetup):
790
791 2017-06-16  Sam Weinig  <sam@webkit.org>
792
793         [WebIDL] Remove custom bindings for HTMLDocument
794         https://bugs.webkit.org/show_bug.cgi?id=173444
795
796         Reviewed by Darin Adler.
797
798         * DOM/DOMHTMLDocument.mm:
799         (-[DOMHTMLDocument linkColor]):
800         (-[DOMHTMLDocument setLinkColor:]):
801         (-[DOMHTMLDocument write:]):
802         (-[DOMHTMLDocument writeln:]):
803         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
804
805 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
806
807         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
808         https://bugs.webkit.org/show_bug.cgi?id=173366
809         <rdar://problem/32767014>
810
811         Reviewed by Tim Horton.
812
813         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
814
815         * Configurations/FeatureDefines.xcconfig:
816         * WebCoreSupport/WebDragClient.mm:
817         (WebDragClient::useLegacyDragClient):
818         (WebDragClient::willPerformDragDestinationAction):
819         (WebDragClient::dragSourceActionMaskForPoint):
820         (WebDragClient::willPerformDragSourceAction):
821         (WebDragClient::startDrag):
822         (WebDragClient::beginDrag):
823         (WebDragClient::declareAndWriteDragImage):
824         (WebDragClient::declareAndWriteAttachment):
825         (WebDragClient::didConcludeEditDrag):
826         * WebView/WebView.mm:
827         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
828         (-[WebView _getDataInteractionData]):
829         (-[WebView dragDataForSession:client:global:operation:]):
830         (-[WebView _enteredDataInteraction:client:global:operation:]):
831         (-[WebView _updatedDataInteraction:client:global:operation:]):
832         (-[WebView _exitedDataInteraction:client:global:operation:]):
833         (-[WebView _performDataInteraction:client:global:operation:]):
834         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
835         (-[WebView _endedDataInteraction:global:]):
836         (-[WebView _didConcludeEditDataInteraction]):
837         (floatRectsForCGRectArray): Deleted.
838         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
839         * WebView/WebViewData.h:
840         * WebView/WebViewData.mm:
841         (-[WebViewPrivate dealloc]):
842         * WebView/WebViewPrivate.h:
843
844 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
845
846         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
847         https://bugs.webkit.org/show_bug.cgi?id=173454
848         <rdar://problem/31720671>
849
850         Reviewed by Tim Horton.
851
852         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
853         If unimplemented, the default UI delegate allows all actions except for URL loading.
854
855         * DefaultDelegates/WebDefaultUIDelegate.mm:
856         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
857         * WebView/WebUIDelegatePrivate.h:
858         * WebView/WebView.mm:
859         (-[WebView dragDestinationActionMaskForSession:]):
860
861 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
862
863         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
864         https://bugs.webkit.org/show_bug.cgi?id=173338
865         <rdar://problem/32777720>
866
867         Reviewed by Tim Horton.
868
869         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
870
871         * WebCoreSupport/WebPlatformStrategies.h:
872         * WebCoreSupport/WebPlatformStrategies.mm:
873         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
874         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
875
876 2017-06-13  Daniel Bates  <dabates@apple.com>
877
878         Implement W3C Secure Contexts Draft Specification
879         https://bugs.webkit.org/show_bug.cgi?id=158121
880         <rdar://problem/26012994>
881
882         Reviewed by Brent Fulgham.
883
884         Part 4
885
886         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
887
888         * WebView/WebPreferenceKeysPrivate.h:
889         * WebView/WebPreferences.mm:
890         (+[WebPreferences initialize]):
891         (-[WebPreferences isSecureContextAttributeEnabled]):
892         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
893         * WebView/WebPreferencesPrivate.h:
894         * WebView/WebView.mm:
895         (-[WebView _preferencesChanged:]):
896
897 2017-06-13  Sam Weinig  <sam@webkit.org>
898
899         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
900         https://bugs.webkit.org/show_bug.cgi?id=80733
901
902         Reviewed by Chris Dumez.
903
904         * DOM/DOMUtility.mm:
905         (createDOMWrapper):
906         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
907         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
908         * WebView/WebFrame.mm:
909         (-[WebFrame _attachScriptDebugger]):
910         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
911
912 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
913
914         [WebCrypto] Remove experimental feature flag of SubtleCrypto
915         https://bugs.webkit.org/show_bug.cgi?id=173197
916         <rdar://problem/32688148>
917
918         Reviewed by Brent Fulgham.
919
920         * WebView/WebPreferences.mm:
921         (+[WebPreferences initialize]):
922         (-[WebPreferences subtleCryptoEnabled]): Deleted.
923         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
924         * WebView/WebPreferencesPrivate.h:
925         * WebView/WebView.mm:
926         (-[WebView _preferencesChanged:]):
927
928 2017-06-10  Dan Bernstein  <mitz@apple.com>
929
930         Reverted r218056 because it made the IDE reindex constantly.
931
932         * Configurations/DebugRelease.xcconfig:
933
934 2017-06-10  Dan Bernstein  <mitz@apple.com>
935
936         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
937         https://bugs.webkit.org/show_bug.cgi?id=173223
938
939         Reviewed by Sam Weinig.
940
941         The rebuilds were happening due to a difference in the compiler options that the IDE and
942         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
943         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
944         specify an appropriate path in CLANG_INDEX_STORE_PATH.
945
946         * Configurations/DebugRelease.xcconfig:
947
948 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
949
950         [iOS DnD] Add a hook to perform two-step drops in editable content
951         https://bugs.webkit.org/show_bug.cgi?id=172992
952         <rdar://problem/32590174>
953
954         Reviewed by Tim Horton.
955
956         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
957         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
958         returning NO will continue with default WebKit behavior.
959
960         * WebCoreSupport/WebEditorClient.h:
961         * WebCoreSupport/WebEditorClient.mm:
962         (WebEditorClient::performTwoStepDrop):
963
964 2017-06-08  Jer Noble  <jer.noble@apple.com>
965
966         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
967         https://bugs.webkit.org/show_bug.cgi?id=173091
968
969         Reviewed by Eric Carlson.
970
971         * WebView/WebPreferences.mm:
972         (+[WebPreferences initialize]):
973
974 2017-06-07  Jer Noble  <jer.noble@apple.com>
975
976         Clean-up: RenderElement.h includes headers it doesn't use
977         https://bugs.webkit.org/show_bug.cgi?id=173046
978
979         Reviewed by Andy Estes.
980
981         * WebView/WebImmediateActionController.mm:
982
983 2017-06-07  Zalan Bujtas  <zalan@apple.com>
984
985         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
986         https://bugs.webkit.org/show_bug.cgi?id=173044
987         <rdar://problem/32449338>
988
989         Reviewed by Tim Horton.
990
991         Cache the current device orientation so that we don't have to lift the WebThread lock
992         to collect it.
993
994         * WebView/WebFrame.mm:
995         (-[WebFrame deviceOrientationChanged]):
996         * WebView/WebView.mm:
997         (-[WebView _commonInitializationWithFrameName:groupName:]):
998         (-[WebView _setDeviceOrientation:]):
999         (-[WebView _deviceOrientation]):
1000         * WebView/WebViewData.h:
1001         * WebView/WebViewInternal.h:
1002
1003 2017-06-06  Jer Noble  <jer.noble@apple.com>
1004
1005         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
1006         https://bugs.webkit.org/show_bug.cgi?id=173008
1007
1008         Reviewed by Eric Carlson.
1009
1010         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
1011
1012         * WebView/WebPreferenceKeysPrivate.h:
1013         * WebView/WebPreferences.mm:
1014         (+[WebPreferences initialize]):
1015         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
1016         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
1017         * WebView/WebPreferencesPrivate.h:
1018         * WebView/WebView.mm:
1019         (-[WebView _preferencesChanged:]):
1020
1021 2017-06-06  Youenn Fablet  <youenn@apple.com>
1022
1023         Add an option to disable getUserMedia prompt in case of mock capture sources
1024         https://bugs.webkit.org/show_bug.cgi?id=172981
1025         <rdar://problem/32580325>
1026
1027         Reviewed by Eric Carlson.
1028
1029         Defining the option, getter and setter.
1030
1031         * WebView/WebPreferences.mm:
1032         (+[WebPreferences initialize]):
1033         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
1034         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
1035         * WebView/WebPreferencesPrivate.h:
1036
1037 2017-06-05  Dan Bernstein  <mitz@apple.com>
1038
1039         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
1040
1041         * WebView/WebView.mm:
1042         (-[WebView updateMediaTouchBar]):
1043         * WebView/WebViewData.h:
1044
1045 2017-06-03  Darin Adler  <darin@apple.com>
1046
1047         Streamline handling of attributes, using references as much as possible
1048         https://bugs.webkit.org/show_bug.cgi?id=172899
1049
1050         Reviewed by Chris Dumez.
1051
1052         * WebView/WebHTMLRepresentation.mm:
1053         (matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
1054         passed in element can't be null. Removed unnecessary conversion from NSString to String
1055         and then back to NSString.
1056
1057 2017-06-01  Andy Estes  <aestes@apple.com>
1058
1059         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
1060         https://bugs.webkit.org/show_bug.cgi?id=172828
1061
1062         Reviewed by Beth Dakin.
1063
1064         * Configurations/FeatureDefines.xcconfig:
1065
1066 2017-05-31  Andy Estes  <aestes@apple.com>
1067
1068         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
1069         https://bugs.webkit.org/show_bug.cgi?id=172366
1070
1071         Reviewed by Daniel Bates.
1072
1073         * Configurations/FeatureDefines.xcconfig:
1074
1075 2017-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1076
1077         Only include DataDetectorsUI headers in iOS
1078         https://bugs.webkit.org/show_bug.cgi?id=172633
1079
1080         Reviewed by David Kilzer.
1081
1082         Enable data detectors only on iOS and not other variants of iOS.
1083
1084         * WebCoreSupport/WebFrameLoaderClient.mm:
1085
1086 2017-05-30  Alex Christensen  <achristensen@webkit.org>
1087
1088         Update libwebrtc configuration
1089         https://bugs.webkit.org/show_bug.cgi?id=172727
1090
1091         Reviewed by Geoffrey Garen.
1092
1093         * Configurations/FeatureDefines.xcconfig:
1094
1095 2017-05-28  Dan Bernstein  <mitz@apple.com>
1096
1097         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
1098         https://bugs.webkit.org/show_bug.cgi?id=172691
1099
1100         Reviewed by Tim Horton.
1101
1102         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
1103
1104 2017-05-26  Brent Fulgham  <bfulgham@apple.com>
1105
1106         [WK2] Address thread safety issues with ResourceLoadStatistics
1107         https://bugs.webkit.org/show_bug.cgi?id=172519
1108         <rdar://problem/31707642>
1109
1110         Reviewed by Chris Dumez.
1111
1112         Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
1113
1114         * WebView/WebView.mm:
1115         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
1116
1117 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
1118
1119         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
1120         https://bugs.webkit.org/show_bug.cgi?id=172554
1121         <rdar://problem/31247133>
1122
1123         Reviewed by Simon Fraser.
1124
1125         Update an overridden internal AppKit function to the new signature.
1126
1127         * WebView/WebHTMLView.mm:
1128         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
1129         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1130         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
1131         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1132
1133 2017-05-24  Jer Noble  <jer.noble@apple.com>
1134
1135         Rename DisplaySleepDisabler -> SleepDisabler
1136         https://bugs.webkit.org/show_bug.cgi?id=172478
1137
1138         Reviewed by Sam Weinig.
1139
1140         * WebView/WebFullScreenController.h:
1141
1142 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
1143
1144         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
1145         https://bugs.webkit.org/show_bug.cgi?id=172522
1146         rdar://problem/31071812
1147
1148         Reviewed by Tim Horton.
1149
1150         There's no need to consult -[NSWindow viewsNeedDisplay] on newer OSes. It was
1151         added in r58623, and modified in r61204 for Carbon apps, but with more recent AppKit
1152         versions this synchronization is no longer required.
1153
1154         * WebView/WebView.mm:
1155         (LayerFlushController::flushLayers):
1156
1157 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
1158
1159         Snapshotting via -renderInContext: should do synchronous image decodes
1160         https://bugs.webkit.org/show_bug.cgi?id=172485
1161         rdar://problem/32276146
1162
1163         Reviewed by Tim Horton.
1164
1165         Remove the _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap: SPI that no longer
1166         has any callers.
1167
1168         * Plugins/WebBaseNetscapePluginView.h:
1169         * Plugins/WebBaseNetscapePluginView.mm:
1170         (-[WebBaseNetscapePluginView inFlatteningPaint]): Deleted.
1171         * WebView/WebFrame.mm:
1172         (-[WebFrame _paintBehaviorForDestinationContext:]):
1173         (-[WebFrame _drawRect:contentsOnly:]):
1174         (-[WebFrame _shouldFlattenCompositingLayers:]): Deleted.
1175         * WebView/WebHTMLView.mm:
1176         (imageFromRect):
1177         * WebView/WebView.mm:
1178         (-[WebView _commonInitializationWithFrameName:groupName:]):
1179         (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): Deleted.
1180         (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): Deleted.
1181         * WebView/WebViewData.h:
1182         * WebView/WebViewPrivate.h:
1183
1184 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
1185
1186         Remove dead ENABLE(FONT_LOAD_EVENTS) code
1187         https://bugs.webkit.org/show_bug.cgi?id=172517
1188
1189         Rubber-stamped by Simon Fraser.
1190
1191         * Configurations/FeatureDefines.xcconfig:
1192
1193 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
1194
1195         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1196         https://bugs.webkit.org/show_bug.cgi?id=171984
1197
1198         Reviewed by Antti Koivisto.
1199
1200         * WebView/WebPreferenceKeysPrivate.h:
1201         * WebView/WebPreferences.mm:
1202         (+[WebPreferences initialize]):
1203         (-[WebPreferences displayContentsEnabled]):
1204         (-[WebPreferences setDisplayContentsEnabled:]):
1205         * WebView/WebPreferencesPrivate.h:
1206         * WebView/WebView.mm:
1207         (-[WebView _preferencesChanged:]):
1208
1209 2017-05-22  Youenn Fablet  <youenn@apple.com>
1210
1211         Remove AVAudioCaptureSource
1212         https://bugs.webkit.org/show_bug.cgi?id=172360
1213
1214         Reviewed by Sam Weinig.
1215
1216         Removing the handling of AVAudio/CoreAudio capture source dynamic switch.
1217
1218         * WebView/WebPreferenceKeysPrivate.h:
1219         * WebView/WebPreferences.mm:
1220         (+[WebPreferences initialize]):
1221         (-[WebPreferences useAVFoundationAudioCapture]): Deleted.
1222         (-[WebPreferences setUseAVFoundationAudioCapture:]): Deleted.
1223         * WebView/WebPreferencesPrivate.h:
1224         * WebView/WebView.mm:
1225         (-[WebView _preferencesChanged:]):
1226
1227 2017-05-22  Sam Weinig  <sam@webkit.org>
1228
1229         [WebIDL] Support callbacks with arbitrary return types
1230         https://bugs.webkit.org/show_bug.cgi?id=172407
1231
1232         Reviewed by Chris Dumez.
1233
1234         * DOM/DOM.mm:
1235         (-[DOMNodeFilter acceptNode:]):
1236         Update for CallbackResult adoption in the base class.
1237
1238         * DOM/DOMNodeIterator.mm:
1239         * DOM/DOMTreeWalker.mm:
1240         Update to account for new WebCore implementation return types. We return nil
1241         if there was an exception, since retains the existing behavior if a javascript
1242         NodeFilter had been used (an exception would cause all nodes to be rejected,
1243         thus returning nullptr).
1244
1245         * DOM/ObjCNodeFilterCondition.h:
1246         * DOM/ObjCNodeFilterCondition.mm:
1247         Update to match new interface of NodeFilterCondition.
1248
1249 2017-05-18  Sam Weinig  <sam@webkit.org>
1250
1251         [WebIDL] Remove the need for the generator to know about native type mapping
1252         https://bugs.webkit.org/show_bug.cgi?id=172310
1253
1254         Reviewed by Darin Adler.
1255
1256         * DOM/DOM.mm:
1257         (-[DOMNodeFilter acceptNode:]):
1258         Update to pass Node by reference.
1259
1260 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1261
1262         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
1263         https://bugs.webkit.org/show_bug.cgi?id=172098
1264
1265         Reviewed by Saam Barati.
1266
1267         * Plugins/Hosted/ProxyInstance.mm:
1268         * Plugins/Hosted/ProxyRuntimeObject.mm:
1269
1270 2017-05-18  Andy Estes  <aestes@apple.com>
1271
1272         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
1273         https://bugs.webkit.org/show_bug.cgi?id=172305
1274
1275         Reviewed by Anders Carlsson.
1276
1277         * Configurations/FeatureDefines.xcconfig:
1278
1279 2017-05-18  Commit Queue  <commit-queue@webkit.org>
1280
1281         Unreviewed, rolling out r217031, r217032, and r217037.
1282         https://bugs.webkit.org/show_bug.cgi?id=172293
1283
1284         cause linking errors in Windows (Requested by yusukesuzuki on
1285         #webkit).
1286
1287         Reverted changesets:
1288
1289         "[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass"
1290         https://bugs.webkit.org/show_bug.cgi?id=172098
1291         http://trac.webkit.org/changeset/217031
1292
1293         "Unreviewed, rebaseline for newly added ClassInfo"
1294         https://bugs.webkit.org/show_bug.cgi?id=172098
1295         http://trac.webkit.org/changeset/217032
1296
1297         "Unreviewed, fix debug and non-JIT build"
1298         https://bugs.webkit.org/show_bug.cgi?id=172098
1299         http://trac.webkit.org/changeset/217037
1300
1301 2017-05-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1302
1303         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
1304         https://bugs.webkit.org/show_bug.cgi?id=172098
1305
1306         Reviewed by Saam Barati.
1307
1308         * Plugins/Hosted/ProxyInstance.mm:
1309         * Plugins/Hosted/ProxyRuntimeObject.mm:
1310
1311 2017-05-17  Matt Lewis  <jlewis3@apple.com>
1312
1313         Unreviewed, rolling out r216974.
1314
1315         Revision caused consistent timeouts on all platforms.
1316
1317         Reverted changeset:
1318
1319         "Add a RuntimeEnabledFeature for display: contents, defaulted
1320         to false."
1321         https://bugs.webkit.org/show_bug.cgi?id=171984
1322         http://trac.webkit.org/changeset/216974
1323
1324 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
1325
1326         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1327         https://bugs.webkit.org/show_bug.cgi?id=171984
1328
1329         Reviewed by Antti Koivisto.
1330
1331         * WebView/WebPreferenceKeysPrivate.h:
1332         * WebView/WebPreferences.mm:
1333         (+[WebPreferences initialize]):
1334         (-[WebPreferences displayContentsEnabled]):
1335         (-[WebPreferences setDisplayContentsEnabled:]):
1336         * WebView/WebPreferencesPrivate.h:
1337         * WebView/WebView.mm:
1338         (-[WebView _preferencesChanged:]):
1339
1340 2017-05-16  Sam Weinig  <sam@webkit.org>
1341
1342         Bring Notification.idl up to spec
1343         https://bugs.webkit.org/show_bug.cgi?id=172156
1344
1345         Reviewed by Chris Dumez.
1346
1347         * WebCoreSupport/WebNotificationClient.h:
1348         * WebCoreSupport/WebNotificationClient.mm:
1349         (generateNotificationID):
1350         (WebNotificationClient::show):
1351         (WebNotificationClient::cancel):
1352         (WebNotificationClient::clearNotifications):
1353         (WebNotificationClient::notificationObjectDestroyed):
1354         (WebNotificationClient::requestPermission):
1355         (WebNotificationClient::hasPendingPermissionRequests):
1356         (WebNotificationClient::checkPermission):
1357         (-[WebNotificationPolicyListener allow]):
1358         (-[WebNotificationPolicyListener deny]):
1359         * WebView/WebNotification.mm:
1360         (-[WebNotification iconURL]):
1361         (-[WebNotification dir]):
1362         Simplify #ifdefs and update for enum vs String usage.
1363
1364 2017-05-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
1365
1366         Do not delete asynchronously decoded frames for large images if their clients are in the viewport
1367         https://bugs.webkit.org/show_bug.cgi?id=170640
1368
1369         Reviewed by Simon Fraser.
1370
1371         Enable the async decoding for large images.
1372
1373         * WebView/WebView.mm:
1374         (-[WebView _preferencesChanged:]):
1375
1376 2017-05-15  Jer Noble  <jer.noble@apple.com>
1377
1378         Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement
1379         https://bugs.webkit.org/show_bug.cgi?id=172131
1380
1381         Reviewed by Eric Carlson.
1382
1383         * WebView/WebPreferenceKeysPrivate.h:
1384         * WebView/WebPreferences.mm:
1385         (+[WebPreferences initialize]):
1386         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
1387         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
1388         * WebView/WebPreferencesPrivate.h:
1389
1390 2017-05-12  Chris Dumez  <cdumez@apple.com>
1391
1392         Drop uses of PassRefPtr in WebKit/mac
1393         https://bugs.webkit.org/show_bug.cgi?id=172066
1394
1395         Reviewed by Sam Weinig.
1396
1397         * History/WebBackForwardListInternal.h:
1398         * History/WebHistoryItem.mm:
1399         (kit):
1400         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
1401         * History/WebHistoryItemInternal.h:
1402         * Plugins/Hosted/HostedNetscapePluginStream.h:
1403         (WebKit::HostedNetscapePluginStream::create):
1404         * Plugins/Hosted/NetscapePluginHostManager.h:
1405         * Plugins/Hosted/NetscapePluginHostManager.mm:
1406         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1407         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1408         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1409         (WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
1410         (WebKit::NetscapePluginInstanceProxy::create):
1411         (WebKit::NetscapePluginInstanceProxy::setManualStream):
1412         * Plugins/Hosted/ProxyInstance.h:
1413         (WebKit::ProxyInstance::create):
1414         * Plugins/Hosted/ProxyInstance.mm:
1415         (WebKit::ProxyInstance::ProxyInstance):
1416         (WebKit::ProxyInstance::newRuntimeObject):
1417         * Plugins/Hosted/ProxyRuntimeObject.h:
1418         (WebKit::ProxyRuntimeObject::create):
1419         * Plugins/Hosted/ProxyRuntimeObject.mm:
1420         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
1421         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1422         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1423         (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1424         * Plugins/WebBaseNetscapePluginView.h:
1425         * Plugins/WebBaseNetscapePluginView.mm:
1426         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1427         * Plugins/WebNetscapePluginStream.h:
1428         (WebNetscapePluginStream::create):
1429         * Plugins/WebNetscapePluginView.h:
1430         * Plugins/WebNetscapePluginView.mm:
1431         (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1432         * WebCoreSupport/WebChromeClient.mm:
1433         * WebCoreSupport/WebEditorClient.mm:
1434         * WebCoreSupport/WebNotificationClient.mm:
1435         (WebNotificationClient::requestPermission):
1436         (-[WebNotificationPolicyListener initWithCallback:]):
1437         * WebCoreSupport/WebOpenPanelResultListener.mm:
1438         * WebCoreSupport/WebUserMediaClient.mm:
1439         (WebUserMediaClient::requestUserMediaAccess):
1440         (WebUserMediaClient::enumerateMediaDevices):
1441         (-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
1442         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
1443         * WebView/WebArchive.mm:
1444         (-[WebArchivePrivate initWithCoreArchive:]):
1445         (-[WebArchivePrivate setCoreArchive:]):
1446         (-[WebArchive initWithData:]):
1447         (-[WebArchive subframeArchives]):
1448         (-[WebArchive _initWithCoreLegacyWebArchive:]):
1449         * WebView/WebArchiveInternal.h:
1450         * WebView/WebDataSource.mm:
1451         (WebDataSourcePrivate::WebDataSourcePrivate):
1452         (WebDataSourcePrivate::~WebDataSourcePrivate):
1453         (-[WebDataSource _initWithDocumentLoader:]):
1454         * WebView/WebDataSourceInternal.h:
1455         * WebView/WebDeviceOrientation.mm:
1456         (-[WebDeviceOrientation initWithCoreDeviceOrientation:]):
1457         * WebView/WebDeviceOrientationInternal.h:
1458         * WebView/WebFrame.mm:
1459         (-[WebFrame _convertToDOMRange:]):
1460         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
1461         * WebView/WebFrameInternal.h:
1462         * WebView/WebFullScreenController.h:
1463         * WebView/WebFullScreenController.mm:
1464         (-[WebFullScreenController setElement:]):
1465         * WebView/WebGeolocationPosition.mm:
1466         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1467         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1468         * WebView/WebHTMLView.mm:
1469         (currentKeyboardEvent):
1470         * WebView/WebResource.mm:
1471         * WebView/WebScriptWorld.mm:
1472         (-[WebScriptWorld initWithWorld:]):
1473         (+[WebScriptWorld standardWorld]):
1474         (+[WebScriptWorld findOrCreateWorld:]):
1475         * WebView/WebViewData.h:
1476         (LayerFlushController::create):
1477
1478 2017-05-11  Chris Dumez  <cdumez@apple.com>
1479
1480         Drop remaining uses of PassRefPtr in WebCore
1481         https://bugs.webkit.org/show_bug.cgi?id=172013
1482
1483         Reviewed by Yusuke Suzuki.
1484
1485         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1486         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1487         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
1488         (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
1489         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1490         (-[WebHostedNetscapePluginView createPluginBindingsInstance:]):
1491
1492 2017-05-11  Tim Horton  <timothy_horton@apple.com>
1493
1494         Mail spins launching spell checker when typing
1495         https://bugs.webkit.org/show_bug.cgi?id=171986
1496         <rdar://problem/26305327>
1497
1498         Reviewed by Beth Dakin.
1499
1500         * WebView/WebView.mm:
1501         (-[WebView setEditable:]):
1502         Asynchronously pre-warm the spell checker when a WebView becomes editable.
1503
1504 2017-05-09  Sam Weinig  <sam@webkit.org>
1505
1506         Remove support for legacy Notifications
1507         https://bugs.webkit.org/show_bug.cgi?id=171487
1508
1509         Reviewed by Jon Lee.
1510
1511         * Configurations/FeatureDefines.xcconfig:
1512         * WebCoreSupport/WebNotificationClient.h:
1513         * WebCoreSupport/WebNotificationClient.mm:
1514         * WebView/WebNotification.mm:
1515         * WebView/WebNotificationInternal.h:
1516         * WebView/WebView.mm:
1517         (-[WebView _commonInitializationWithFrameName:groupName:]):
1518         (-[WebView _notificationIDForTesting:]):
1519         Remove legacy notification specific code.
1520
1521 2017-05-10  Chris Dumez  <cdumez@apple.com>
1522
1523         Simplify relationship between Attr and Element now that Attr is childless
1524         https://bugs.webkit.org/show_bug.cgi?id=171909
1525
1526         Reviewed by Ryosuke Niwa.
1527
1528         Build fix.
1529
1530         * DOM/DOMAttr.mm:
1531         (-[DOMAttr value]):
1532         (-[DOMAttr setValue:]):
1533
1534 2017-05-08  Chris Dumez  <cdumez@apple.com>
1535
1536         Move 'style' from Element to HTMLElement / SVGElement and make it settable
1537         https://bugs.webkit.org/show_bug.cgi?id=171795
1538
1539         Reviewed by Alex Christensen.
1540
1541         Build fix.
1542
1543         * DOM/DOMElement.mm:
1544         (-[DOMElement style]):
1545         * WebCoreSupport/WebEditorClient.mm:
1546         (WebEditorClient::shouldApplyStyle):
1547         * WebView/WebFrame.mm:
1548         (-[WebFrame _typingStyle]):
1549
1550 2017-05-06  Chris Dumez  <cdumez@apple.com>
1551
1552         Align our IDL files with the latest DOM specification
1553         https://bugs.webkit.org/show_bug.cgi?id=171777
1554
1555         Reviewed by Sam Weinig.
1556
1557         Build fix.
1558
1559         * DOM/DOMDocument.mm:
1560         (-[DOMDocument readyState]):
1561
1562 2017-05-05  Jeremy Jones  <jeremyj@apple.com>
1563
1564         REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
1565         https://bugs.webkit.org/show_bug.cgi?id=171610
1566         <rdar://problem/31976820>
1567
1568         Reviewed by Eric Carlson.
1569
1570         Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
1571
1572         * WebCoreSupport/WebChromeClient.h:
1573         * WebCoreSupport/WebChromeClient.mm:
1574         (WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
1575
1576 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1577
1578         Unreviewed, rolling out r216206.
1579         https://bugs.webkit.org/show_bug.cgi?id=171714
1580
1581         Multiple LayoutTests crashing in Document::page() (Requested
1582         by ap on #webkit).
1583
1584         Reverted changeset:
1585
1586         "Remove support for legacy Notifications"
1587         https://bugs.webkit.org/show_bug.cgi?id=171487
1588         http://trac.webkit.org/changeset/216206
1589
1590 2017-05-04  Jeremy Jones  <jeremyj@apple.com>
1591
1592         UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
1593         https://bugs.webkit.org/show_bug.cgi?id=171704
1594
1595         Reviewed by Jer Noble.
1596
1597         Fix build by casting result of +whiteColor to UIColor.
1598
1599         * WebView/WebView.mm:
1600         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
1601
1602 2017-05-04  Sam Weinig  <sam@webkit.org>
1603
1604         Remove support for legacy Notifications
1605         https://bugs.webkit.org/show_bug.cgi?id=171487
1606
1607         Reviewed by Jon Lee.
1608
1609         * Configurations/FeatureDefines.xcconfig:
1610         * WebCoreSupport/WebNotificationClient.h:
1611         * WebCoreSupport/WebNotificationClient.mm:
1612         * WebView/WebNotification.mm:
1613         * WebView/WebNotificationInternal.h:
1614         * WebView/WebView.mm:
1615         (-[WebView _commonInitializationWithFrameName:groupName:]):
1616         (-[WebView _notificationIDForTesting:]):
1617         Remove legacy notification specific code.
1618
1619 2017-05-03  Joseph Pecoraro  <pecoraro@apple.com>
1620
1621         [Cocoa] Stop exporting symbols for ivars that were made private
1622         https://bugs.webkit.org/show_bug.cgi?id=171631
1623
1624         Reviewed by Dan Bernstein.
1625
1626         * WebKit.exp:
1627
1628 2017-05-01  Chris Dumez  <cdumez@apple.com>
1629
1630         Remove some usage of PassRefPtr in editing code
1631         https://bugs.webkit.org/show_bug.cgi?id=171490
1632
1633         Reviewed by Darin Adler.
1634
1635         * WebView/WebFrame.mm:
1636         (-[WebFrame dictationResultMetadataForRange:]):
1637         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1638
1639 2017-05-01  Beth Dakin  <bdakin@apple.com>
1640
1641         On-screen panel for candidate bar is in the wrong place when the caret is at the 
1642         start of a paragraph
1643         https://bugs.webkit.org/show_bug.cgi?id=171453
1644         -and corresponding-
1645         rdar://problem/29779764
1646
1647         Reviewed by Tim Horton.
1648
1649         This bug only happens when the caret is at the beginning of the paragraph, and it 
1650         is because Range::absoluteTextQuads() returns no quads in this case. I think it 
1651         might be correct that absoluteTextQuads() returns no quads in this case, so this 
1652         patch fixes the bug at the call site by using absoluteCaretBounds() in this case.
1653
1654         * WebCoreSupport/WebEditorClient.mm:
1655         (WebEditorClient::handleRequestedCandidates):
1656
1657 2017-04-30  Dan Bernstein  <mitz@apple.com>
1658
1659         [Cocoa] Replaces uses of [get…() alloc] with alloc…Instance()
1660         https://bugs.webkit.org/show_bug.cgi?id=171485
1661
1662         Reviewed by Geoffrey Garen.
1663
1664         * WebView/WebView.mm:
1665         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1666         (-[WebUITextIndicatorData initWithImage:scale:]):
1667
1668 2017-04-28  Youenn Fablet  <youenn@apple.com>
1669
1670         Adding a runtime flag specific to MediaDevices
1671         https://bugs.webkit.org/show_bug.cgi?id=171433
1672
1673         Reviewed by Geoffrey Garen.
1674
1675         Adding a preference for MediaDevices.
1676         Setting media devices runtime flag to false by default.
1677         Setting peer connection and media stream flags to true by default.
1678
1679         * WebView/WebPreferenceKeysPrivate.h:
1680         * WebView/WebPreferences.mm:
1681         (+[WebPreferences initialize]):
1682         (-[WebPreferences mediaDevicesEnabled]):
1683         (-[WebPreferences setMediaDevicesEnabled:]):
1684         * WebView/WebPreferencesPrivate.h:
1685         * WebView/WebView.mm:
1686         (-[WebView _preferencesChanged:]):
1687
1688 2017-04-27  Chris Dumez  <cdumez@apple.com>
1689
1690         Align colspan/rowspan limits with the latest HTML specification
1691         https://bugs.webkit.org/show_bug.cgi?id=171322
1692
1693         Reviewed by Darin Adler.
1694
1695         ObjC bindings build fix.
1696
1697         * DOM/DOMHTMLTableCellElement.mm:
1698         (-[DOMHTMLTableCellElement colSpan]):
1699         (-[DOMHTMLTableCellElement setColSpan:]):
1700
1701 2017-04-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
1702
1703         REGRESSION(r213764): Async decoding of animated images is disabled for ImageDocument
1704         https://bugs.webkit.org/show_bug.cgi?id=170333
1705
1706         Reviewed by Simon Fraser.
1707
1708         Disbale the async decoding for large images for now.
1709
1710         * WebView/WebView.mm:
1711         (-[WebView _preferencesChanged:]):
1712
1713 2017-04-27  Alex Christensen  <achristensen@webkit.org>
1714
1715         Modernize Frame.h
1716         https://bugs.webkit.org/show_bug.cgi?id=171357
1717
1718         Reviewed by Andy Estes.
1719
1720         * WebCoreSupport/WebEditorClient.h:
1721         * WebCoreSupport/WebEditorClient.mm:
1722         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
1723
1724 2017-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1725
1726         [WK1] Tweak the data interaction SPI to indicate whether or not a data interaction was handled
1727         https://bugs.webkit.org/show_bug.cgi?id=171369
1728         <rdar://problem/31858853>
1729
1730         Reviewed by Dan Bernstein.
1731
1732         Introduce a new SPI hook intended to replace performDataInteraction:client:global:operation: that
1733         returns whether or not the data interaction was handled. Due to the difference only in return type
1734         and some staging constraints, this version is prefixed with "_tryTo".
1735
1736         * WebView/WebView.mm:
1737         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
1738         * WebView/WebViewPrivate.h:
1739
1740 2017-04-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1741
1742         WebItemProviderPasteboard should not synchronously load provided data
1743         https://bugs.webkit.org/show_bug.cgi?id=171341
1744         <rdar://problem/31614010>
1745
1746         Reviewed by Tim Horton.
1747
1748         Adds client-layer plumbing for updatePreferredTypeIdentifiers. See WebCore ChangeLog for more details.
1749
1750         * WebCoreSupport/WebPlatformStrategies.h:
1751         * WebCoreSupport/WebPlatformStrategies.mm:
1752         (WebPlatformStrategies::updatePreferredTypeIdentifiers):
1753
1754 2017-04-26  Zalan Bujtas  <zalan@apple.com>
1755
1756         RTL: recent searches popover is displayed in incorrect location
1757         https://bugs.webkit.org/show_bug.cgi?id=171338
1758         <rdar://problem/31377807>
1759
1760         Reviewed by Dean Jackson.
1761
1762         Add RTL support for the pop-under branch.
1763
1764         * WebCoreSupport/PopupMenuMac.mm:
1765         (PopupMenuMac::show):
1766
1767 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
1768
1769         Limit allowed size of document.title to avoid locking WebKit clients
1770         https://bugs.webkit.org/show_bug.cgi?id=165113
1771         <rdar://problem/28324389>
1772
1773         Reviewed by Darin Adler.
1774
1775         When a web application attempts to set an extremely long title, truncate the
1776         title to a more reasonable size.
1777
1778         We do this at at the presentation layer, rather than in the DOM, so that we do
1779         not affect script function. Instead, we merely limit display to a level that is
1780         reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
1781         layer, so it is a waste of effort to send across IPC.
1782
1783         * WebCoreSupport/WebFrameLoaderClient.h:
1784         * WebCoreSupport/WebFrameLoaderClient.mm:
1785         (WebFrameLoaderClient::dispatchDidReceiveTitle):
1786
1787 2017-04-25  Daniel Bates  <dabates@apple.com>
1788
1789         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
1790         https://bugs.webkit.org/show_bug.cgi?id=136452
1791         <rdar://problem/23412620>
1792
1793         Reviewed by Brent Fulgham.
1794
1795         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
1796
1797         * Configurations/FeatureDefines.xcconfig:
1798
1799 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1800
1801         Support reading NSURL titles from the pasteboard when performing data interaction
1802         https://bugs.webkit.org/show_bug.cgi?id=171156
1803         <rdar://problem/31356937>
1804
1805         Reviewed by Tim Horton.
1806
1807         Add a new WK1 SPI property, -[WebFrame hasRichlyEditableDragCaret].
1808
1809         * WebCoreSupport/WebPlatformStrategies.h:
1810         * WebCoreSupport/WebPlatformStrategies.mm:
1811         (WebPlatformStrategies::readURLFromPasteboard):
1812         * WebView/WebFrame.mm:
1813         (-[WebFrame hasRichlyEditableDragCaret]):
1814         * WebView/WebFramePrivate.h:
1815
1816 2017-04-24  Andy VanWagoner  <thetalecrafter@gmail.com>
1817
1818         Clean up ICU headers
1819         https://bugs.webkit.org/show_bug.cgi?id=170997
1820
1821         Reviewed by JF Bastien.
1822
1823         Update all icu headers to 55.1
1824
1825         * icu/README: Explain ICU headers for OS X better
1826         * icu/unicode/localpointer.h:
1827         (LocalPointer::LocalPointer):
1828         (LocalPointer::adoptInsteadAndCheckErrorCode):
1829         * icu/unicode/platform.h:
1830         * icu/unicode/putil.h:
1831         * icu/unicode/uchar.h:
1832         * icu/unicode/uconfig.h:
1833         * icu/unicode/ucurr.h:
1834         * icu/unicode/uidna.h:
1835         * icu/unicode/umachine.h:
1836         * icu/unicode/urename.h:
1837         * icu/unicode/uscript.h:
1838         * icu/unicode/ustring.h:
1839         * icu/unicode/utf8.h:
1840         * icu/unicode/utypes.h:
1841         * icu/unicode/uvernum.h:
1842
1843 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1844
1845         Respect fidelity order when reading web content from item providers
1846         https://bugs.webkit.org/show_bug.cgi?id=171155
1847         <rdar://problem/31356937>
1848
1849         Reviewed by Tim Horton.
1850
1851         Adjusts for changes in WebCore (see WebCore/ChangeLog for more details).
1852
1853         * WebCoreSupport/WebPlatformStrategies.h:
1854         * WebCoreSupport/WebPlatformStrategies.mm:
1855         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex):
1856
1857 2017-04-24  Alex Christensen  <achristensen@webkit.org>
1858
1859         Reduce copies and allocations in SharedBuffer::append
1860         https://bugs.webkit.org/show_bug.cgi?id=170956
1861
1862         Reviewed by Andreas Kling.
1863
1864         * WebView/WebArchive.mm:
1865         (-[WebArchive initWithData:]):
1866         * WebView/WebFrame.mm:
1867         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1868         * WebView/WebResource.mm:
1869         (-[WebResource initWithCoder:]):
1870         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1871
1872 2017-04-24  Dan Bernstein  <mitz@apple.com>
1873
1874         [Cocoa] Some ivars are needlessly @protected
1875         https://bugs.webkit.org/show_bug.cgi?id=171208
1876
1877         Reviewed by Anders Carlsson
1878
1879         Made ivars @private where possible.
1880
1881         * Misc/WebUserContentURLPattern.h:
1882         * Plugins/WebPluginDatabase.h:
1883         * Storage/WebDatabaseQuotaManager.h:
1884         * WebCoreSupport/WebSecurityOriginPrivate.h:
1885         * WebInspector/WebInspector.h:
1886         * WebView/WebDeviceOrientation.h:
1887         * WebView/WebDeviceOrientationProviderMock.h:
1888         * WebView/WebGeolocationPosition.h:
1889         * WebView/WebHTMLRepresentation.h:
1890         * WebView/WebNotification.h:
1891
1892 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1893
1894         Support writing link titles to the pasteboard when beginning data interaction on a link
1895         https://bugs.webkit.org/show_bug.cgi?id=171154
1896         <rdar://problem/31356937>
1897
1898         Reviewed by Andy Estes.
1899
1900         Adjust for some changes in WebCore to introduce a separate codepath for writing PasteboardURLs. See WebCore
1901         and WebKit2 ChangeLogs for more details.
1902
1903         * WebCoreSupport/WebPlatformStrategies.h:
1904         * WebCoreSupport/WebPlatformStrategies.mm:
1905         (WebPlatformStrategies::writeToPasteboard):
1906
1907 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1908
1909         Unreviewed, rolling out r215608.
1910
1911         Hundreds of test failures on GTK bot
1912
1913         Reverted changeset:
1914
1915         "Reduce copies and allocations in SharedBuffer::append"
1916         https://bugs.webkit.org/show_bug.cgi?id=170956
1917         http://trac.webkit.org/changeset/215608
1918
1919 2017-04-21  Alex Christensen  <achristensen@webkit.org>
1920
1921         Reduce copies and allocations in SharedBuffer::append
1922         https://bugs.webkit.org/show_bug.cgi?id=170956
1923
1924         Reviewed by Andreas Kling.
1925
1926         * WebView/WebArchive.mm:
1927         (-[WebArchive initWithData:]):
1928         * WebView/WebFrame.mm:
1929         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1930         * WebView/WebResource.mm:
1931         (-[WebResource initWithCoder:]):
1932         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1933
1934 2017-04-20  Dewei Zhu  <dewei_zhu@apple.com>
1935
1936         Build fix to start using C++14.
1937         https://bugs.webkit.org/show_bug.cgi?id=171038
1938
1939         Reviewed by Alex Christensen.
1940
1941         Use 'c++14' instead of 'c++11' in order to use 'auto' in lambda.
1942
1943         * Configurations/WebKitLegacy.xcconfig:
1944
1945 2017-04-19  Youenn Fablet  <youenn@apple.com>
1946
1947         [Mac] Allow customizing H264 encoder
1948         https://bugs.webkit.org/show_bug.cgi?id=170829
1949
1950         Reviewed by Alex Christensen.
1951
1952         * Configurations/FeatureDefines.xcconfig:
1953
1954 2017-04-19  Anders Carlsson  <andersca@apple.com>
1955
1956         Stop using deprecated APIs, part 3
1957         https://bugs.webkit.org/show_bug.cgi?id=171003
1958         rdar://problem/31589635
1959
1960         Reviewed by Tim Horton.
1961
1962         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1963         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1964         (WebPaymentCoordinatorClient::cancelPaymentSession):
1965         Update for WebCore changes.
1966
1967 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1968
1969         [WK2] Support DataTransfer::files() when performing a DHTML data interaction
1970         https://bugs.webkit.org/show_bug.cgi?id=170880
1971         <rdar://problem/31314689>
1972
1973         Reviewed by Tim Horton.
1974
1975         Adjust for a change in PasteboardStrategy. See WebCore ChangeLog for more details.
1976
1977         * WebCoreSupport/WebPlatformStrategies.h:
1978         * WebCoreSupport/WebPlatformStrategies.mm:
1979         (WebPlatformStrategies::getFilenamesForDataInteraction):
1980
1981 2017-04-17  Youenn Fablet  <youenn@apple.com>
1982
1983         Disable outdated WritableStream API
1984         https://bugs.webkit.org/show_bug.cgi?id=170749
1985         <rdar://problem/31446233>
1986
1987         Reviewed by Alex Christensen.
1988
1989         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
1990         - A STREAMS_API compilation flag.
1991         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
1992
1993         * Configurations/FeatureDefines.xcconfig:
1994         * WebView/WebPreferenceKeysPrivate.h:
1995         * WebView/WebPreferences.mm:
1996         (+[WebPreferences initialize]):
1997         (-[WebPreferences readableByteStreamAPIEnabled]):
1998         (-[WebPreferences setReadableByteStreamAPIEnabled:]):
1999         (-[WebPreferences writableStreamAPIEnabled]):
2000         (-[WebPreferences setWritableStreamAPIEnabled:]):
2001         * WebView/WebPreferencesPrivate.h:
2002         * WebView/WebView.mm:
2003         (-[WebView _preferencesChanged:]):
2004
2005 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2006
2007         [WK2] Support data interaction of files into file inputs
2008         https://bugs.webkit.org/show_bug.cgi?id=170803
2009         <rdar://problem/31286130>
2010
2011         Reviewed by Tim Horton.
2012
2013         Add boilerplate plumbing for fetching the number of files in the pasteboard.
2014
2015         * WebCoreSupport/WebPlatformStrategies.h:
2016         * WebCoreSupport/WebPlatformStrategies.mm:
2017         (WebPlatformStrategies::getNumberOfFiles):
2018
2019 2017-04-14  Mark Lam  <mark.lam@apple.com>
2020
2021         Update architectures in xcconfig files.
2022         https://bugs.webkit.org/show_bug.cgi?id=170867
2023         <rdar://problem/31628104>
2024
2025         Reviewed by Joseph Pecoraro.
2026
2027         * Configurations/FeatureDefines.xcconfig:
2028
2029 2017-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2030
2031         [WK2] Support Icon creation from file URLs on iOS
2032         https://bugs.webkit.org/show_bug.cgi?id=170809
2033         <rdar://problem/31286130>
2034
2035         Reviewed by Tim Horton.
2036
2037         Adjust for changes in the ChromeClient in WebCore.
2038
2039         * WebCoreSupport/WebChromeClient.h:
2040         * WebCoreSupport/WebChromeClient.mm:
2041         (WebChromeClient::loadIconForFiles):
2042         (WebChromeClient::createIconForFiles):
2043
2044 2017-04-12  Dan Bernstein  <mitz@apple.com>
2045
2046         [Mac] Future-proof .xcconfig files
2047         https://bugs.webkit.org/show_bug.cgi?id=170802
2048
2049         Reviewed by Tim Horton.
2050
2051         * Configurations/Base.xcconfig:
2052         * Configurations/DebugRelease.xcconfig:
2053         * Configurations/FeatureDefines.xcconfig:
2054         * Configurations/Version.xcconfig:
2055
2056 2017-04-12  Beth Dakin  <bdakin@apple.com>
2057
2058         Build fix.
2059
2060         * WebView/WebViewData.h:
2061
2062 2017-04-12  Brian Weinstein  <bweinstein@apple.com>
2063
2064         Should always override -[WebStorageManager init].
2065         https://bugs.webkit.org/show_bug.cgi?id=170787
2066         -and corresponding-
2067         rdar://problem/31371835
2068
2069         Reviewed by Anders Carlsson.
2070
2071         * Storage/WebStorageManager.mm:
2072         (-[WebStorageManager init]):
2073
2074 2017-04-12  Beth Dakin  <bdakin@apple.com>
2075
2076         Speculative build fix. 
2077
2078         * WebView/WebViewData.h:
2079
2080 2017-04-12  Beth Dakin  <bdakin@apple.com>
2081
2082         Adopt AVKit name change from AVFunctionBar* to AVTouchBar*
2083         https://bugs.webkit.org/show_bug.cgi?id=170693
2084         -and corresponding-
2085         rdar://problem/31230018
2086
2087         Reviewed by Sam Weinig.
2088
2089         Since the new names only apply to some versions of macOS, this patch uses typedefs 
2090         for the older OS’s. SO:
2091
2092         AVFunctionBarScrubber is now AVTouchBarScrubber
2093
2094         AVFunctionBarPlaybackControlsProvider is now AVTouchBarPlaybackControlsProvider
2095
2096         AVFunctionBarMediaSelectionOption is now AVTouchBarMediaSelectionOption
2097
2098         And the protocol AVFunctionBarPlaybackControlsControlling is now 
2099         AVTouchBarPlaybackControlsControlling
2100
2101         Soft links and allocations cannot use the typedefs.
2102         * WebView/WebView.mm:
2103         (-[WebView updateMediaTouchBar]):
2104         * WebView/WebViewData.h:
2105
2106 2017-04-11  Dean Jackson  <dino@apple.com>
2107
2108         Disable outdated WritableStream API
2109         https://bugs.webkit.org/show_bug.cgi?id=170749
2110         <rdar://problem/31446233>
2111
2112         Reviewed by Tim Horton.
2113
2114         The API we implement is no longer accurate. Disable it until we
2115         are compatible with the new specification
2116
2117         * Configurations/FeatureDefines.xcconfig:
2118
2119 2017-04-11  Dan Bernstein  <mitz@apple.com>
2120
2121         [iOS] Simple HTML documents should allow non-markup JavaScript
2122         https://bugs.webkit.org/show_bug.cgi?id=170734
2123
2124         Reviewed by Sam Weinig.
2125
2126         * WebView/WebView.mm:
2127         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Enabled scripting
2128           but disabled scripting markup.
2129
2130 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2131
2132         Revert r215217
2133         https://bugs.webkit.org/show_bug.cgi?id=170703
2134
2135         * Configurations/FeatureDefines.xcconfig:
2136
2137 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2138
2139         Continue enabling WebRTC
2140         https://bugs.webkit.org/show_bug.cgi?id=170703
2141
2142         Reviewed by Youenn Fablet.
2143
2144         * Configurations/FeatureDefines.xcconfig:
2145
2146 2017-04-10  Anders Carlsson  <andersca@apple.com>
2147
2148         Remove call to WKShowKeyAndMain
2149         https://bugs.webkit.org/show_bug.cgi?id=170691
2150         rdar://problem/31050032
2151
2152         Reviewed by Beth Dakin.
2153
2154         * Carbon/CarbonWindowAdapter.mm:
2155         (-[CarbonWindowAdapter makeKeyWindow]):
2156
2157 2017-04-10  Jeremy Jones  <jeremyj@apple.com>
2158
2159         Add CoreAudioCaptureSource.
2160         https://bugs.webkit.org/show_bug.cgi?id=170112
2161         rdar://problem/30293338
2162
2163         Reviewed by Eric Carlson.
2164
2165         Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.
2166
2167         * WebView/WebPreferenceKeysPrivate.h:
2168         * WebView/WebPreferences.mm:
2169         (+[WebPreferences initialize]):
2170         (-[WebPreferences useAVFoundationAudioCapture]):
2171         (-[WebPreferences setUseAVFoundationAudioCapture:]):
2172         * WebView/WebPreferencesPrivate.h:
2173         * WebView/WebView.mm:
2174         (-[WebView _preferencesChanged:]):
2175
2176 2017-04-10  Chris Dumez  <cdumez@apple.com>
2177
2178         Drop Timer::startOneShot() overload taking a double
2179         https://bugs.webkit.org/show_bug.cgi?id=170659
2180
2181         Reviewed by Yusuke Suzuki.
2182
2183         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
2184
2185         * Plugins/WebNetscapePluginView.mm:
2186         (PluginTimer::start):
2187         * Storage/WebStorageManager.mm:
2188         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
2189
2190 2017-04-09  Chris Dumez  <cdumez@apple.com>
2191
2192         Drop Timer::startRepeating() overload taking a double
2193         https://bugs.webkit.org/show_bug.cgi?id=170656
2194
2195         Reviewed by Yusuke Suzuki.
2196
2197         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
2198
2199         * Plugins/WebNetscapePluginView.mm:
2200         (PluginTimer::start):
2201
2202 2017-04-09  Chris Dumez  <cdumez@apple.com>
2203
2204         Start dropping Timer API dealing with double
2205         https://bugs.webkit.org/show_bug.cgi?id=170649
2206
2207         Reviewed by Yusuke Suzuki.
2208
2209         Start dropping Timer API dealing with double as people should use Seconds now.
2210
2211         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2212         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2213         (WebKit::NetscapePluginInstanceProxy::loadRequest):
2214         * Plugins/WebNetscapePluginStream.mm:
2215         (WebNetscapePluginStream::deliverData):
2216
2217 2017-04-08  Chris Dumez  <cdumez@apple.com>
2218
2219         Drop std::chrono support from Timer class
2220         https://bugs.webkit.org/show_bug.cgi?id=170645
2221
2222         Reviewed by Sam Weinig.
2223
2224         Drop std::chrono support from Timer class now that we prefer using Seconds type.
2225
2226         * WebView/WebView.mm:
2227         (+[WebView _setCacheModel:]):
2228
2229 2017-04-08  Youenn Fablet  <youenn@apple.com>
2230
2231         WebRTC tests gardening
2232         https://bugs.webkit.org/show_bug.cgi?id=170508
2233
2234         Reviewed by Eric Carlson.
2235
2236         * Configurations/FeatureDefines.xcconfig:
2237
2238 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
2239
2240         Unreviewed, rolling out r215046.
2241
2242         This change broke internal builds.
2243
2244         Reverted changeset:
2245
2246         "WebRTC tests gardening"
2247         https://bugs.webkit.org/show_bug.cgi?id=170508
2248         http://trac.webkit.org/changeset/215046
2249
2250 2017-04-06  Tim Horton  <timothy_horton@apple.com>
2251
2252         Obj-C bindings build fails with CSS_DEVICE_ADAPTATION turned on
2253         https://bugs.webkit.org/show_bug.cgi?id=170566
2254
2255         Reviewed by Simon Fraser.
2256
2257         * DOM/DOMCSS.mm:
2258         (kitClass):
2259         Use the WebCore-side enum for this, since that's actually what we're switching over.
2260         This allows us to handle values here without adding them to the API header.
2261         All of the other kitClass() functions work the same way.
2262         Also, unindent for style purposes.
2263
2264 2017-04-06  Youenn Fablet  <youenn@apple.com>
2265
2266         WebRTC tests gardening
2267         https://bugs.webkit.org/show_bug.cgi?id=170508
2268
2269         Reviewed by Eric Carlson.
2270
2271         * Configurations/FeatureDefines.xcconfig:
2272
2273 2017-04-04  Megan Gardner  <megan_gardner@apple.com>
2274
2275         Fix leaks in WebUITextIndicatorData
2276         https://bugs.webkit.org/show_bug.cgi?id=170480
2277
2278         Reviewed by Wenson Hsieh.
2279
2280         Removes extraneous retains.
2281
2282         * WebView/WebView.mm:
2283         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2284
2285 2017-04-04  Tim Horton  <timothy_horton@apple.com>
2286
2287         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
2288         https://bugs.webkit.org/show_bug.cgi?id=165801
2289         <rdar://problem/29649535>
2290
2291         Reviewed by Wenson Hsieh.
2292
2293         * WebView/WebView.mm:
2294         (incrementFrame):
2295         Adjust to the new CanWrap enum.
2296
2297 2017-03-27  Joseph Pecoraro  <pecoraro@apple.com>
2298
2299         Web Inspector: Saving files should not suggest the top level directory
2300         https://bugs.webkit.org/show_bug.cgi?id=170085
2301         <rdar://problem/30197794>
2302
2303         Reviewed by Matt Baker.
2304
2305         * WebCoreSupport/WebInspectorClient.mm:
2306         (WebInspectorFrontendClient::save):
2307         Don't set panel.directoryURL unless we have a good suggestion.
2308
2309 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2310
2311         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
2312         https://bugs.webkit.org/show_bug.cgi?id=169168
2313         <rdar://problem/30688374>
2314
2315         Reviewed by Tim Horton.
2316
2317         Refactors WebDragClient::actionMaskForDrag to take platform data only, rather than the entire DragData. See the
2318         WebCore ChangeLog entry for more details. Also renames WebDefaultUIDelegate.m to WebDefaultUIDelegate.mm, since
2319         we need to import a C++ header for linkedOnOrAfter().
2320
2321         The default delegate implementation of webView:dragDestinationActionMaskForDraggingInfo: now checks if the current
2322         application is linking against 10.12 or earlier, and if so, will allow any drag destination action instead of
2323         the new default value of everything but DragDestinationActionLoad.
2324
2325         * DefaultDelegates/WebDefaultUIDelegate.mm: Renamed from Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.m.
2326         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
2327         * Misc/WebKitVersionChecks.h:
2328         * WebCoreSupport/WebDragClient.h:
2329         * WebCoreSupport/WebDragClient.mm:
2330         (WebDragClient::actionMaskForDrag): Deleted.
2331         * WebView/WebView.mm:
2332         (-[WebView draggingEntered:]):
2333         (-[WebView draggingUpdated:]):
2334
2335 2017-03-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2336
2337         Add support for showing the platform data interaction caret
2338         https://bugs.webkit.org/show_bug.cgi?id=169898
2339         <rdar://problem/31146295>
2340
2341         Reviewed by Beth Dakin.
2342
2343         Plumb the dataInteractionCaretRect through WebView SPI to WebKit1 clients.
2344
2345         * WebView/WebView.mm:
2346         (-[WebView _dataInteractionCaretRect]):
2347         * WebView/WebViewPrivate.h:
2348
2349 2017-03-22  Dan Bernstein  <mitz@apple.com>
2350
2351         [iOS] downloadableBinaryFontsEnabled is set to false in -initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:
2352         https://bugs.webkit.org/show_bug.cgi?id=169967
2353         <rdar://problem/30406898>
2354
2355         Reviewed by Anders Carlsson.
2356
2357         * WebView/WebView.mm:
2358         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Removed call to
2359           Settings::downloadableBinaryFontsEnabled. The default is true.
2360
2361 2017-03-22  Andy Estes  <aestes@apple.com>
2362
2363         [QuickLook] Rename QuickLookHandle to PreviewLoader
2364         https://bugs.webkit.org/show_bug.cgi?id=169961
2365
2366         Reviewed by Andreas Kling.
2367
2368         * WebCoreSupport/WebFrameLoaderClient.h:
2369         * WebCoreSupport/WebFrameLoaderClient.mm:
2370         (WebFrameLoaderClient::createPreviewLoaderClient):
2371         (WebFrameLoaderClient::createQuickLookHandleClient): Deleted.
2372
2373 2017-03-21  Anders Carlsson  <andersca@apple.com>
2374
2375         Remove bogus availability annotations from DOM SPI headers.
2376         rdar://problem/31015675
2377
2378         Rubber-stamped by Dan Bernstein.
2379
2380         * DOM/DOMHTMLMediaElement.h:
2381         * DOM/DOMHTMLVideoElement.h:
2382         * DOM/DOMMediaError.h:
2383         * DOM/DOMTextEvent.h:
2384         * DOM/DOMTimeRanges.h:
2385         * DOM/DOMTokenList.h:
2386
2387 2017-03-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2388
2389         Teach TextIndicator to estimate the background color of the given Range
2390         https://bugs.webkit.org/show_bug.cgi?id=169869
2391         <rdar://problem/31127272>
2392
2393         Reviewed by Anders Carlsson and Simon Fraser.
2394
2395         Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.
2396
2397         * WebView/WebView.mm:
2398         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2399         (-[WebUITextIndicatorData dealloc]):
2400         * WebView/WebViewPrivate.h:
2401
2402 2017-03-20  Dan Bernstein  <mitz@apple.com>
2403
2404         [Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
2405         https://bugs.webkit.org/show_bug.cgi?id=169861
2406
2407         Reviewed by Sam Weinig.
2408
2409         * MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
2410         * postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the
2411           timestamp file used by the Xcode project to determine whether to run the script.
2412
2413 2017-03-19  Alexey Proskuryakov  <ap@apple.com>
2414
2415         WebHTMLView is useless as WebResourceHandler
2416         https://bugs.webkit.org/show_bug.cgi?id=169857
2417
2418         Reviewed by Dan Bernstein.
2419
2420         * WebView/WebHTMLView.mm:
2421         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2422         WebHTMLView doesnt implement any of WebResourceHandler methods.
2423
2424 2017-03-17  Michael Saboff  <msaboff@apple.com>
2425
2426         Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
2427         https://bugs.webkit.org/show_bug.cgi?id=169817
2428
2429         Reviewed by Filip Pizlo.
2430
2431         * Configurations/FeatureDefines.xcconfig:
2432
2433 2017-03-17  Antti Koivisto  <antti@apple.com>
2434
2435         Add a reload policy where only expired subresources are revalidated
2436         https://bugs.webkit.org/show_bug.cgi?id=169756
2437
2438         Reviewed by Andreas Kling.
2439
2440         * WebView/WebFrame.mm:
2441         (toWebFrameLoadType):
2442         (-[WebFrame reload]):
2443         (-[WebFrame reloadFromOrigin]):
2444
2445 2017-03-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2446
2447         [WK1] Support animated transitions when performing a data interaction operation
2448         https://bugs.webkit.org/show_bug.cgi?id=169805
2449         <rdar://problem/31045767>
2450
2451         Reviewed by Beth Dakin and Megan Gardner.
2452
2453         Adds WebKit1 support for animated transitions when performing a data interaction operation. See per-method changes
2454         for more details.
2455
2456         * DOM/DOMElement.h:
2457         * DOM/DOMElement.mm:
2458         (-[DOMElement boundsInRootViewSpace]):
2459
2460         Introduce -[DOMElement boundsInRootViewSpace], which returns the bounds of the element in root view coordinates.
2461
2462         * WebCoreSupport/WebDragClient.h:
2463         (): Deleted.
2464         * WebCoreSupport/WebDragClient.mm:
2465         (WebDragClient::didConcludeEditDrag):
2466
2467         Add boilerplate plumbing.
2468
2469         * WebView/WebView.mm:
2470         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2471
2472         Add contentImageWithoutSelection and contentImageWithoutSelectionRectInRootViewCoordinates to WebUITextIndicatorData.
2473
2474         (floatRectsForCGRectArray):
2475         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
2476
2477         Introduces a SPI helper method in WebView that clients can use to generate an image of a text platter given an
2478         image of some text, as well as clipping rects to apply to the image.
2479
2480         (-[WebView _dataOperationTextIndicator]):
2481
2482         Add SPI to fetch the text indicator used to drive animations for the current data operation.
2483
2484         (-[WebView _didConcludeEditDataInteraction]):
2485         * WebView/WebViewData.h:
2486         * WebView/WebViewInternal.h:
2487         * WebView/WebViewPrivate.h:
2488
2489 2017-03-16  Simon Fraser  <simon.fraser@apple.com>
2490
2491         Improve the system tracing points
2492         https://bugs.webkit.org/show_bug.cgi?id=169790
2493
2494         Reviewed by Zalan Bujtas.
2495
2496         Use a more cohesive set of system trace points that give a good overview of what
2497         WebKit is doing. Added points for resource loading, render tree building, sync messages
2498         to the web process, async image decode, WASM and fetching cookies.
2499
2500         * WebView/WebHTMLView.mm:
2501         (-[WebHTMLView drawRect:]):
2502
2503 2017-03-16  Youenn Fablet  <youenn@apple.com>
2504
2505         Wrap legacy WebRTC API in runtime flag
2506         https://bugs.webkit.org/show_bug.cgi?id=169646
2507
2508         Reviewed by Alex Christensen.
2509
2510         * WebView/WebPreferenceKeysPrivate.h:
2511         * WebView/WebPreferences.mm:
2512         (+[WebPreferences initialize]):
2513         (-[WebPreferences webRTCLegacyAPIEnabled]):
2514         (-[WebPreferences setWebRTCLegacyAPIEnabled:]):
2515         * WebView/WebPreferencesPrivate.h:
2516         * WebView/WebView.mm:
2517         (-[WebView _preferencesChanged:]):
2518
2519 2017-03-14  Megan Gardner  <megan_gardner@apple.com>
2520
2521         Correctly export WebItemProviderPasteboard
2522         https://bugs.webkit.org/show_bug.cgi?id=169578
2523
2524         Reviewed by Tim Horton.
2525
2526         * MigrateHeaders.make:
2527
2528 2017-03-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2529
2530         [WK2] Data interaction tests occasionally hit assertions in debug builds
2531         https://bugs.webkit.org/show_bug.cgi?id=169002
2532         <rdar://problem/30994806>
2533
2534         Reviewed by Tim Horton.
2535
2536         Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.
2537
2538         * WebView/WebHTMLView.mm:
2539         (-[WebHTMLView _updateSelectionForInputManager]):
2540         * WebView/WebView.mm:
2541         (-[WebView updateTextTouchBar]):
2542
2543 2017-03-13  Anders Carlsson  <andersca@apple.com>
2544
2545         Fix build warnings.
2546
2547         * WebCoreSupport/WebInspectorClient.mm:
2548         (WebInspectorFrontendClient::save):
2549         (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2550
2551 2017-03-11  Brady Eidson  <beidson@apple.com>
2552
2553         Cleanup "addCookie" and its sole user.
2554         https://bugs.webkit.org/show_bug.cgi?id=169486
2555
2556         Reviewed by Brian Burg.
2557
2558         * WebCoreSupport/WebPlatformStrategies.h:
2559         * WebCoreSupport/WebPlatformStrategies.mm:
2560         (WebPlatformStrategies::addCookie): Deleted.
2561
2562 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2563
2564         Fix watch and tv builds after r213294
2565         https://bugs.webkit.org/show_bug.cgi?id=169508
2566
2567         Reviewed by Dan Bernstein.
2568
2569         * Configurations/FeatureDefines.xcconfig:
2570
2571 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2572
2573         Fix CMake build.
2574
2575         * WebView/WebNotification.h:
2576         Don't assume we have already included something that includes NSObject.h.
2577
2578 2017-03-09  Daniel Bates  <dabates@apple.com>
2579
2580         Guard Credential Management implementation behind a runtime enabled feature flag
2581         https://bugs.webkit.org/show_bug.cgi?id=169364
2582         <rdar://problem/30957425>
2583
2584         Reviewed by Brent Fulgham.
2585
2586         Add WebKit preference for Credential Management (disabled by default).
2587
2588         * WebView/WebPreferenceKeysPrivate.h:
2589         * WebView/WebPreferences.mm:
2590         (+[WebPreferences initialize]):
2591         (-[WebPreferences credentialManagementEnabled]): Added.
2592         (-[WebPreferences setCredentialManagementEnabled:]): Added.
2593         * WebView/WebPreferencesPrivate.h:
2594         * WebView/WebView.mm:
2595         (-[WebView _preferencesChanged:]):
2596
2597 2017-03-09  Anders Carlsson  <andersca@apple.com>
2598
2599         Add delegate support to WebCore
2600         https://bugs.webkit.org/show_bug.cgi?id=169427
2601         Part of rdar://problem/28880714.
2602
2603         Reviewed by Geoffrey Garen.
2604
2605         * Configurations/FeatureDefines.xcconfig:
2606         Add feature define.
2607
2608 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
2609
2610         Fix DataInteraction guards
2611         https://bugs.webkit.org/show_bug.cgi?id=169404
2612
2613         Reviewed by Wenson Hsieh.
2614
2615         * WebCoreSupport/WebDragClient.mm:
2616
2617 2017-03-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2618
2619         Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
2620         https://bugs.webkit.org/show_bug.cgi?id=169392
2621         <rdar://problem/30882974>
2622
2623         Reviewed by Tim Horton.
2624
2625         Add a stub implementation of WebDragClient::didConcludeEditDrag.
2626
2627         * WebCoreSupport/WebDragClient.h:
2628
2629 2017-03-08  Anders Carlsson  <andersca@apple.com>
2630
2631         Simplify the PaymentCoordinator interface
2632         https://bugs.webkit.org/show_bug.cgi?id=169382
2633         Part of rdar://problem/28880714.
2634
2635         Reviewed by Tim Horton.
2636
2637         Update for PaymentCoordinatorClient changes.
2638
2639         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2640         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2641         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
2642         (WebPaymentCoordinatorClient::completeShippingContactSelection):
2643         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
2644         (WebPaymentCoordinatorClient::completePaymentSession):
2645
2646 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
2647
2648         Fix for dependency fix
2649         https://bugs.webkit.org/show_bug.cgi?id=169369
2650
2651         Reviewed by Beth Dakin.
2652
2653         * WebView/WebViewPrivate.h:
2654
2655 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
2656
2657         Fix Project Dependency
2658         https://bugs.webkit.org/show_bug.cgi?id=169340
2659
2660         Unreviewed Dependency Fix.
2661
2662         * WebView/WebViewPrivate.h:
2663
2664 2017-03-07  Alexey Proskuryakov  <ap@apple.com>
2665
2666         WebKitLegacy should re-export symbols from WebCore on watchos and tvos
2667         https://bugs.webkit.org/show_bug.cgi?id=169341
2668         <rdar://problem/30913788>
2669
2670         Reviewed by Dan Bernstein.
2671
2672         * MigrateHeaders.make:
2673
2674 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
2675
2676         Have fixedPositionCreatesStackingContext be on by default everywhere
2677         https://bugs.webkit.org/show_bug.cgi?id=169334
2678
2679         Reviewed by Zalan Bujtas.
2680
2681         It makes no sense to have web-exposed CSS functionality be different based on setting,
2682         and other browser are now aligned with having position:fixed create stacking context.
2683
2684         So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
2685         always force stacking context for position:fixed.
2686
2687         * WebView/WebView.mm:
2688         (-[WebView _preferencesChanged:]):
2689
2690 2017-03-06  Simon Fraser  <simon.fraser@apple.com>
2691
2692         Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
2693         https://bugs.webkit.org/show_bug.cgi?id=169230
2694
2695         Reviewed by Tim Horton.
2696
2697         * WebView/WebView.mm:
2698         (-[WebView _preferencesChanged:]):
2699
2700 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
2701
2702         Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
2703         https://bugs.webkit.org/show_bug.cgi?id=169329
2704
2705         Reviewed by Tim Horton.
2706
2707         If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.
2708
2709         * WebView/WebPreferences.mm:
2710         (+[WebPreferences initialize]):
2711
2712 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
2713
2714         Additional DataInteraction Support
2715         https://bugs.webkit.org/show_bug.cgi?id=169316
2716         <rdar://problem/30884234>
2717
2718         Reviewed by Wenson Hsieh.
2719
2720         Add stub implementations to WebView for methods that handle data interaction
2721
2722         * WebView/WebView.mm:
2723         (-[WebView _enteredDataInteraction:client:global:operation:]):
2724         (-[WebView _updatedDataInteraction:client:global:operation:]):
2725         (-[WebView _exitedDataInteraction:client:global:operation:]):
2726         (-[WebView _performDataInteraction:client:global:operation:]):
2727         (-[WebView _endedDataInteraction:global:]):
2728         * WebView/WebViewPrivate.h:
2729
2730 2017-03-07  Dean Jackson  <dino@apple.com>
2731
2732         Some platforms won't be able to create a GPUDevice
2733         https://bugs.webkit.org/show_bug.cgi?id=169314
2734         <rdar://problems/30907521>
2735
2736         Reviewed by Jon Lee.
2737
2738         Disable WEB_GPU on the iOS Simulator.
2739
2740         * Configurations/FeatureDefines.xcconfig:
2741
2742 2017-03-07  Maureen Daum  <mdaum@apple.com>
2743
2744         Correctly check for an empty database file.
2745         <rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
2746         https://bugs.webkit.org/show_bug.cgi?id=169256
2747
2748         Reviewed by Brady Eidson.
2749
2750         Check if the folder for an origin's WebSQL databases is empty after trying to delete
2751         all of its files. Currently we check if the deletedDatabaseFileCount matches the number
2752         of files that were in the folder. However, when we delete the actual database file in
2753         DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
2754         the database file, but deletedDatabaseFileCount only gets incremented once.
2755
2756         * Storage/WebDatabaseManager.mm:
2757         (+[WebDatabaseManager removeEmptyDatabaseFiles]):
2758         Delete the folder if it is empty.
2759
2760 2017-03-06  Michael Saboff  <msaboff@apple.com>
2761
2762         Unreviewed build fix to add
2763         -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
2764         for objective C++ files.
2765
2766         * Configurations/WebKitLegacy.xcconfig:
2767
2768 2017-03-06  Michael Saboff  <msaboff@apple.com>
2769
2770         Take advantage of fast permissions switching of JIT memory for devices that support it
2771         https://bugs.webkit.org/show_bug.cgi?id=169155
2772
2773         Reviewed by Saam Barati.
2774
2775         Updated the Xcode config files to match what is in the JavaScriptCore ones.
2776
2777         * Configurations/FeatureDefines.xcconfig:
2778
2779 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
2780
2781         Expand font-weight and font-stretch to take any number
2782         https://bugs.webkit.org/show_bug.cgi?id=168889
2783
2784         Reviewed by Simon Fraser.
2785
2786         Migrate off old enum types.
2787
2788         * WebCoreSupport/PopupMenuMac.mm:
2789         (PopupMenuMac::populate):
2790         * WebView/WebHTMLView.mm:
2791         (fontNameForDescription):
2792         * WebView/WebView.mm:
2793         (-[WebView updateTextTouchBar]):
2794
2795 2017-03-03  Dean Jackson  <dino@apple.com>
2796
2797         Add WebGPU compile flag and experimental feature flag
2798         https://bugs.webkit.org/show_bug.cgi?id=169161
2799         <rdar://problem/30846689>
2800
2801         Reviewed by Tim Horton.
2802
2803         Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
2804         and an InternalSetting.
2805
2806         * Configurations/FeatureDefines.xcconfig:
2807         * WebView/WebPreferenceKeysPrivate.h:
2808         * WebView/WebPreferences.mm:
2809         (+[WebPreferences initialize]):
2810         (-[WebPreferences webGPUEnabled]):
2811         (-[WebPreferences setWebGPUEnabled:]):
2812         * WebView/WebPreferencesPrivate.h:
2813         * WebView/WebView.mm:
2814         (-[WebView _preferencesChanged:]):
2815
2816 2017-03-03  Alexey Proskuryakov  <ap@apple.com>
2817
2818         Build fix
2819         rdar://problem/30825660
2820
2821         Suggested by Dan Bernstein.
2822
2823         * Configurations/WebKitLegacy.xcconfig:
2824
2825 2017-03-02  Sam Weinig  <sam@webkit.org>
2826
2827         Rename htmlediting.h/cpp to Editing.h/cpp
2828         https://bugs.webkit.org/show_bug.cgi?id=169103
2829
2830         Reviewed by Alex Christensen.
2831
2832         * DOM/DOMUIKitExtensions.mm:
2833         * WebView/WebFrame.mm:
2834         * WebView/WebView.mm:
2835
2836 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2837
2838         Fix 32-bit
2839         https://bugs.webkit.org/show_bug.cgi?id=169114
2840
2841         Reviewed by Alex Christensen.
2842
2843         * WebView/WebView.mm:
2844
2845 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2846
2847         More guard fixing
2848         https://bugs.webkit.org/show_bug.cgi?id=169112
2849
2850         Reviewed by Alex Christensen.
2851
2852         Fixed an internal build.
2853
2854         * WebView/WebView.mm:
2855         * WebView/WebViewPrivate.h:
2856
2857 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2858
2859         Data Interaction build fixes
2860         https://bugs.webkit.org/show_bug.cgi?id=169096
2861
2862         Reviewed by Tim Horton.
2863
2864         Guards weren't all correct, also missed a selector name change.
2865
2866         * WebView/WebView.mm:
2867         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
2868         * WebView/WebViewData.h:
2869         * WebView/WebViewData.mm:
2870         (-[WebViewPrivate dealloc]):
2871
2872 2017-03-02  Alex Christensen  <achristensen@webkit.org>
2873
2874         Continue enabling WebRTC
2875         https://bugs.webkit.org/show_bug.cgi?id=169056
2876
2877         Reviewed by Jon Lee.
2878
2879         * Configurations/FeatureDefines.xcconfig:
2880
2881 2017-03-01  Megan Gardner  <megan_gardner@apple.com>
2882
2883         Data interaction support for WK1
2884         https://bugs.webkit.org/show_bug.cgi?id=169062
2885
2886         Reviewed by Wenson Hsieh.
2887
2888         Support for data interaction in WebKit1
2889
2890         * WebCoreSupport/WebDragClient.mm:
2891         * WebView/WebView.mm:
2892         (-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
2893         (-[WebUITextIndicatorData initWithImage:scale:]):
2894         (-[WebUITextIndicatorData dealloc]):
2895         (-[WebView _requestStartDataInteraction:globalPosition:]):
2896         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
2897         (-[WebView _getDataInteractionData]):
2898         * WebView/WebViewData.h:
2899         * WebView/WebViewData.mm:
2900         (-[WebViewPrivate dealloc]):
2901         * WebView/WebViewInternal.h:
2902         * WebView/WebViewPrivate.h:
2903
2904 2017-03-02  Youenn Fablet  <youenn@apple.com>
2905
2906         [WebRTC] Activate ICE candidate privacy policy
2907         https://bugs.webkit.org/show_bug.cgi?id=168975
2908
2909         Reviewed by Alex Christensen.
2910
2911         * WebView/WebPreferenceKeysPrivate.h:
2912         * WebView/WebPreferences.mm:
2913         (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
2914         (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
2915         (-[WebPreferences iceCandidateFilteringEnabled]):
2916         (-[WebPreferences setIceCandidateFilteringEnabled:]):
2917         * WebView/WebPreferencesPrivate.h:
2918
2919 2017-03-01  Alex Christensen  <achristensen@webkit.org>
2920
2921         Unreviewed, rolling out r213259.
2922
2923         Broke an internal build
2924
2925         Reverted changeset:
2926
2927         "Continue enabling WebRTC"
2928         https://bugs.webkit.org/show_bug.cgi?id=169056
2929         http://trac.webkit.org/changeset/213259
2930
2931 2017-03-01  Alex Christensen  <achristensen@webkit.org>
2932
2933         Continue enabling WebRTC
2934         https://bugs.webkit.org/show_bug.cgi?id=169056
2935
2936         Reviewed by Jon Lee.
2937
2938         * Configurations/FeatureDefines.xcconfig:
2939
2940 2017-02-27  Alex Christensen  <achristensen@webkit.org>
2941
2942         Begin enabling WebRTC on 64-bit
2943         https://bugs.webkit.org/show_bug.cgi?id=168915
2944
2945         Reviewed by Eric Carlson.
2946
2947         * Configurations/FeatureDefines.xcconfig:
2948
2949 2017-02-27  Aakash Jain  <aakash_jain@apple.com>
2950
2951         Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
2952         https://bugs.webkit.org/show_bug.cgi?id=168919
2953
2954         Reviewed by Tim Horton.
2955
2956         * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
2957         * migrate-headers.sh: Run the migrate-headers script for installapi phase.
2958
2959 2017-02-27  Alex Christensen  <achristensen@webkit.org>
2960
2961         [libwebrtc] Enable WebRTC in some Production Builds
2962         https://bugs.webkit.org/show_bug.cgi?id=168858
2963
2964         * Configurations/FeatureDefines.xcconfig:
2965
2966 2017-02-26  Alexey Proskuryakov  <ap@apple.com>
2967
2968         Don't import RetainPtr in WebNotification.h
2969         https://bugs.webkit.org/show_bug.cgi?id=168876
2970
2971         Reviewed by Dan Bernstein.
2972
2973         This is an Objective-C SPI header.
2974
2975         * WebView/WebNotification.h:
2976         * WebView/WebNotification.mm:
2977         (-[WebNotification initWithCoreNotification:notificationID:]):
2978         (-[WebNotification dealloc]):
2979
2980 2017-02-26  Aakash Jain  <aakash_jain@apple.com>
2981
2982         Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
2983         https://bugs.webkit.org/show_bug.cgi?id=168819
2984
2985         Reviewed by Dan Bernstein.
2986
2987         * Configurations/WebKitLegacy.xcconfig:
2988
2989 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
2990
2991         Export Objective-C symbols for variables in Webkit SPI
2992         https://bugs.webkit.org/show_bug.cgi?id=168758
2993
2994         Reviewed by Alexey Proskuryakov.
2995
2996         * Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
2997         * WebKit.exp: Added various Objective-C symbols.
2998
2999 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
3000
3001         Move instance members from WKQuadObject to implementation file
3002         https://bugs.webkit.org/show_bug.cgi?id=168740
3003
3004         Reviewed by Tim Horton.
3005
3006         * DOM/DOM.mm: Moving instance member to implementation file.
3007         * DOM/DOMExtensions.h: Ditto.
3008
3009 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
3010
3011         Move iOS specific symbols to WebKit.ios.exp
3012         https://bugs.webkit.org/show_bug.cgi?id=168726
3013
3014         Reviewed by Alexey Proskuryakov.
3015
3016         * WebKit.exp:
3017
3018 2017-02-21  Youenn Fablet  <youenn@apple.com>
3019
3020         [WebRTC][Mac] Activate libwebrtc
3021         https://bugs.webkit.org/show_bug.cgi?id=167293
3022         <rdar://problem/30401864>
3023
3024         Reviewed by Alex Christensen.
3025
3026         * Configurations/FeatureDefines.xcconfig:
3027
3028 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3029
3030         Export various NSString symbols from WebFramePrivate.h
3031         https://bugs.webkit.org/show_bug.cgi?id=168702
3032
3033         Reviewed by Alexey Proskuryakov.
3034
3035         * WebKit.exp:
3036
3037 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3038
3039         Export various NSString symbols from WebPreferencesPrivate.h
3040         https://bugs.webkit.org/show_bug.cgi?id=168701
3041
3042         Reviewed by Alexey Proskuryakov.
3043
3044         * WebKit.exp:
3045
3046 2017-02-21  Joseph Pecoraro  <pecoraro@apple.com>
3047
3048         Add missing WebConsoleMessage string key
3049         https://bugs.webkit.org/show_bug.cgi?id=168690
3050
3051         Reviewed by Alexey Proskuryakov.
3052
3053         * WebKit.exp:
3054         * WebView/WebUIDelegatePrivate.h:
3055         This key has an implementation but was not extern / exported like the others.
3056
3057 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3058
3059         Export various NSString symbols from WebViewPrivate.h
3060         https://bugs.webkit.org/show_bug.cgi?id=168689
3061
3062         Reviewed by Alexey Proskuryakov.
3063
3064         * WebKit.exp:
3065
3066 2017-02-21  Commit Queue  <commit-queue@webkit.org>
3067
3068         Unreviewed, rolling out r212768.
3069         https://bugs.webkit.org/show_bug.cgi?id=168698
3070
3071         Rolling out since this would break other projects. (Requested
3072         by aakashjain on #webkit).
3073
3074         Reverted changeset:
3075
3076         "[iOS] Remove old WebKit1 MemoryMeasure helper."
3077         https://bugs.webkit.org/show_bug.cgi?id=168675
3078         http://trac.webkit.org/changeset/212768
3079
3080 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
3081
3082         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
3083         https://bugs.webkit.org/show_bug.cgi?id=168620
3084         <rdar://problem/30617772>
3085
3086         Reviewed by Tim Horton.
3087
3088         * WebView/WebPreferenceKeysPrivate.h:
3089         * WebView/WebPreferences.mm:
3090         (+[WebPreferences initialize]):
3091         (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
3092         (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
3093         * WebView/WebPreferencesPrivate.h:
3094
3095 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3096
3097         Export various NSString symbols from WebUIDelegatePrivate.h
3098         https://bugs.webkit.org/show_bug.cgi?id=168679
3099
3100         Reviewed by Joseph Pecoraro.
3101
3102         * WebKit.exp:
3103
3104 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3105
3106         Export symbols for various classes present in webkit SPI
3107         https://bugs.webkit.org/show_bug.cgi?id=168674
3108
3109         Reviewed by Dan Bernstein.
3110
3111         * WebKit.exp:
3112
3113 2017-02-21  Andreas Kling  <akling@apple.com>
3114
3115         [iOS] Remove old WebKit1 MemoryMeasure helper.
3116         <https://webkit.org/b/168675>
3117
3118         Reviewed by Sam Weinig.
3119
3120         * Configurations/WebKitLegacy.xcconfig:
3121         * Misc/WebCache.mm:
3122         (+[WebCache emptyInMemoryResources]):
3123         * WebView/WebView.mm:
3124
3125 2017-02-21  Andreas Kling  <akling@apple.com>
3126
3127         [iOS] WebKit1 should use shared memory pressure handler code.
3128         <https://webkit.org/b/168653>
3129
3130         Reviewed by Antti Koivisto.
3131
3132         Register a WebThread-aware memory callback with the shared MemoryPressureHandler
3133         and get rid of the old iOS WebKit1 specific implementation. Some of it was even
3134         dead code since MobileSafari has been using WebKit2 for quite a while.
3135
3136         * WebView/WebView.h:
3137         * WebView/WebView.mm:
3138         (WebInstallMemoryPressureHandler):
3139         (+[WebView _handleMemoryWarning]): Deleted.
3140         (+[WebView registerForMemoryNotifications]): Deleted.
3141         (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
3142         (+[WebView garbageCollectNow]): Deleted.
3143         (+[WebView purgeInactiveFontData]): Deleted.
3144         (+[WebView drainLayerPool]): Deleted.
3145         (+[WebView discardAllCompiledCode]): Deleted.
3146         (+[WebView _clearMemoryPressure]): Deleted.
3147         (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
3148         * WebView/WebViewPrivate.h:
3149
3150 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3151
3152         Stop exporting interface WebCoreScrollView on iOS
3153         https://bugs.webkit.org/show_bug.cgi?id=168536
3154
3155         Reviewed by Dan Bernstein.
3156
3157         * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
3158         * WebKit.mac.exp: Ditto.
3159         * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
3160
3161 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3162
3163         Exclude various mac-specific header files from iOS build
3164         https://bugs.webkit.org/show_bug.cgi?id=168621
3165
3166         Reviewed by Dan Bernstein.
3167
3168         * Configurations/WebKitLegacy.xcconfig:
3169
3170 2017-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3171
3172         Add plumbing to the UI process for TextIndicatorData when computing the drag image
3173         https://bugs.webkit.org/show_bug.cgi?id=168583
3174         Work towards <rdar://problem/30313681>
3175
3176         Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
3177
3178         Reviewed by Tim Horton.
3179
3180         * WebView/WebHTMLView.mm:
3181         (-[WebHTMLView _selectionDraggingImage]):
3182         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
3183
3184 2017-02-17  Anders Carlsson  <andersca@apple.com>
3185
3186         Add a new drag code path and use it for dragging plain text
3187         https://bugs.webkit.org/show_bug.cgi?id=168534
3188
3189         Reviewed by Geoffrey Garen.
3190
3191         * WebCoreSupport/WebDragClient.h:
3192         Add new members.
3193
3194         * WebCoreSupport/WebDragClient.mm:
3195         (WebDragClient::useLegacyDragClient):
3196         Return false here.
3197
3198         (WebDragClient::beginDrag):
3199         New client member function. Create an NSDraggingItem and use it to begin a dragging session.
3200
3201         * WebView/WebHTMLView.mm:
3202         (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
3203         Get the source operation mask from WebCore.
3204
3205         (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
3206         Send a fake mouse up event.
3207
3208         * WebView/WebHTMLViewInternal.h:
3209         Declare that WebHTMLView conforms to NSDraggingSource.
3210
3211 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
3212
3213         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
3214         https://bugs.webkit.org/show_bug.cgi?id=168342
3215         rdar://problem/26182266
3216
3217         Reviewed by Tim Horton.
3218
3219         * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
3220         symbols to re-export.
3221
3222 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3223
3224         Stop exporting DOMTokenList from WebKit
3225         https://bugs.webkit.org/show_bug.cgi?id=168544
3226
3227         Reviewed by Alexey Proskuryakov.
3228
3229         * WebKit.exp:
3230
3231 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
3232
3233         Clean up how WebKit exports _WebCreateFragment
3234         https://bugs.webkit.org/show_bug.cgi?id=168579
3235
3236         Reviewed by Dan Bernstein.
3237
3238         * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
3239         * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
3240
3241 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3242
3243         Stop exporting DOMNodeFilter
3244         https://bugs.webkit.org/show_bug.cgi?id=168542
3245
3246         Reviewed by Alexey Proskuryakov.
3247
3248         * WebKit.exp:
3249
3250 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
3251
3252         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
3253         https://bugs.webkit.org/show_bug.cgi?id=167693
3254
3255         Reviewed by Sergio Villar Senin.
3256
3257         * Configurations/FeatureDefines.xcconfig:
3258         * WebView/WebPreferences.mm:
3259         (+[WebPreferences initialize]):
3260         * WebView/WebView.mm:
3261         (-[WebView _preferencesChanged:]):
3262
3263 2017-02-15  Brady Eidson  <beidson@apple.com>
3264
3265         Stop backing up localStorage databases to iCloud by default.
3266         <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
3267
3268         Reviewed by Geoffrey Garen.
3269
3270         * Misc/WebKitVersionChecks.h:
3271         * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
3272         (WebKitLinkedOnOrAfter):
3273         (setWebKitLinkTimeVersion):
3274         (WebKitLinkTimeVersion):
3275         (linkedOnOrAfter):
3276
3277         * Storage/WebStorageManager.mm:
3278         (WebKitInitializeStorageIfNecessary):
3279
3280 2017-02-16  Daniel Bates  <dabates@apple.com>
3281
3282         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
3283         https://bugs.webkit.org/show_bug.cgi?id=168417
3284         <rdar://problem/30541748>
3285
3286         Reviewed by Brent Fulgham.
3287
3288         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
3289         Widget* as it is always called with a valid Widget.
3290
3291         * WebCoreSupport/WebFrameLoaderClient.h:
3292         * WebCoreSupport/WebFrameLoaderClient.mm:
3293         (WebFrameLoaderClient::redirectDataToPlugin):
3294         * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
3295         as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
3296         r180570 (2 years ago) though Xcode still references this ordering file (why?).
3297
3298 2017-02-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3299
3300         [JSC] Drop PassRefPtr in inspector/
3301         https://bugs.webkit.org/show_bug.cgi?id=168420
3302
3303         Reviewed by Alex Christensen.
3304
3305         * WebView/WebScriptDebugger.mm:
3306         (WebScriptDebugger::handlePause):
3307
3308 2017-02-16  Simon Fraser  <simon.fraser@apple.com>
3309
3310         Clean up use of some CALayer-related SPI
3311         https://bugs.webkit.org/show_bug.cgi?id=168401
3312
3313         Reviewed by Tim Horton.
3314
3315         Include CALayer.h not CATiledLayer.h.
3316
3317         * WebInspector/WebNodeHighlight.h:
3318
3319 2017-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3320
3321         Fix the build after r212379
3322
3323         Rubber-stamped by Anders Carlsson.
3324
3325         * WebCoreSupport/WebDragClient.mm:
3326         (WebDragClient::startDrag):
3327
3328 2017-02-15  Anders Carlsson  <andersca@apple.com>
3329
3330         Modernize DragClient::startDrag somewhat
3331         https://bugs.webkit.org/show_bug.cgi?id=168379
3332
3333         Reviewed by Tim Horton.
3334
3335         Update for WebCore changes.
3336
3337         * WebCoreSupport/WebDragClient.h:
3338         * WebCoreSupport/WebDragClient.mm:
3339         (WebDragClient::startDrag):
3340
3341 2017-02-14  Dean Jackson  <dino@apple.com>
3342
3343         Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
3344         https://bugs.webkit.org/show_bug.cgi?id=168339
3345
3346         Reviewed by Simon Fraser.
3347
3348         Use a better name.
3349
3350         * WebView/WebPreferenceKeysPrivate.h:
3351         * WebView/WebPreferences.mm:
3352         (+[WebPreferences initialize]):
3353         (-[WebPreferences forceLowPowerGPUForWebGL]):
3354         (-[WebPreferences setForceLowPowerGPUForWebGL:]):
3355         (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
3356         (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
3357         * WebView/WebPreferencesPrivate.h:
3358         * WebView/WebView.mm:
3359         (-[WebView _preferencesChanged:]):
3360
3361 2017-02-14  Chris Dumez  <cdumez@apple.com>
3362
3363         HTML Form Validation bubble should take minimum font size setting into consideration
3364         https://bugs.webkit.org/show_bug.cgi?id=168271
3365         <rdar://problem/29869869>
3366
3367         Reviewed by Simon Fraser.
3368
3369         * WebView/WebView.mm:
3370         (-[WebView _contentsOfUserInterfaceItem:]):
3371         Return font size used in the validation bubble.
3372
3373         (-[WebView showFormValidationMessage:withAnchorRect:]):
3374         Pass minimum font size setting when constructing the validation bubble.
3375
3376 2017-02-14  Anders Carlsson  <andersca@apple.com>
3377
3378         Remove an unused delegate method
3379         https://bugs.webkit.org/show_bug.cgi?id=168328
3380
3381         Reviewed by Wenson Hsieh.
3382
3383         * DefaultDelegates/WebDefaultUIDelegate.m:
3384         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
3385
3386 2017-02-14  Alexey Proskuryakov  <ap@apple.com>
3387
3388         WebCore shouldn't export SystemMemory.h
3389         https://bugs.webkit.org/show_bug.cgi?id=168285
3390
3391         Reviewed by Alex Christensen.
3392
3393         * MigrateHeaders.make: And WebKit shouldn't re-export it.
3394
3395 2017-02-13  Alexey Proskuryakov  <ap@apple.com>
3396
3397         WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
3398         https://bugs.webkit.org/show_bug.cgi?id=168282
3399
3400         Reviewed by Dan Bernstein.
3401
3402         * MigrateHeaders.make:
3403
3404 2017-02-12  Dan Bernstein  <mitz@apple.com>
3405
3406         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
3407
3408         * WebView/WebHTMLView.mm:
3409         (createShareMenuItem): Use non-deprecated method.
3410
3411 2017-02-12  Dan Bernstein  <mitz@apple.com>
3412
3413         [Cocoa] Some -respondsToSelector: checks are unnecessary
3414         https://bugs.webkit.org/show_bug.cgi?id=168183
3415
3416         Reviewed by Tim Horton.
3417
3418         * WebView/WebFullScreenController.mm:
3419         (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
3420           responds to -isOnActiveSpace.
3421         (-[WebFullScreenController exitFullScreen]): Ditto.
3422         (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
3423           NSApplication responds to -setPresentationOptions.
3424
3425         * WebView/WebHTMLView.mm:
3426         (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
3427         (-[WebHTMLView otherMouseDown:]): Ditto.
3428
3429         * WebView/WebImmediateActionController.mm:
3430         (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
3431         (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
3432
3433         * WebView/WebView.mm:
3434         (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
3435         (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
3436
3437 2017-02-10  Daniel Bates  <dabates@apple.com>
3438
3439         Detach frame from document when entering page cache
3440         https://bugs.webkit.org/show_bug.cgi?id=166774
3441         <rdar://problem/29904368>
3442
3443         Reviewed by Chris Dumez.
3444
3445         * WebView/WebPreferenceKeysPrivate.h:
3446         * WebView/WebPreferences.mm:
3447         (+[WebPreferences initialize]):
3448         (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
3449         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
3450         * WebView/WebPreferencesPrivate.h:
3451         * WebView/WebView.mm:
3452         (-[WebView _preferencesChanged:]):
3453
3454 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
3455
3456         [Resource Timing] Enable Resource Timing by default in Tests
3457         https://bugs.webkit.org/show_bug.cgi?id=168145
3458
3459         Reviewed by Ryosuke Niwa.
3460
3461         * WebView/WebPreferenceKeysPrivate.h:
3462         * WebView/WebPreferences.mm:
3463         (+[WebPreferences initialize]):
3464         (-[WebPreferences resourceTimingEnabled]):
3465         (-[WebPreferences setResourceTimingEnabled:]):
3466         * WebView/WebPreferencesPrivate.h:
3467         * WebView/WebView.mm:
3468         (-[WebView _preferencesChanged:]):
3469
3470 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
3471
3472         cleanup WebLocalizableStrings.
3473         https://bugs.webkit.org/show_bug.cgi?id=168078
3474
3475         Reviewed by Alexey Proskuryakov.
3476
3477         * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
3478         as it's for each framework's own consumption, and never needs to be exported.
3479
3480 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
3481
3482         WebResourceLoadDelegatePrivate.h cannot be imported standalone
3483         https://bugs.webkit.org/show_bug.cgi?id=168096
3484
3485         Reviewed by Alexey Proskuryakov.
3486
3487         * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
3488
3489 2017-02-09  Antti Koivisto  <antti@apple.com>
3490
3491         Remove most cases of #if ENABLE(CACHE_PARTITIONING)
3492         https://bugs.webkit.org/show_bug.cgi?id=167990
3493
3494         Reviewed by Sam Weinig.
3495
3496         * Misc/WebCache.mm:
3497         (+[WebCache addImageToCache:forURL:forFrame:]):
3498         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3499         * WebCoreSupport/WebSystemInterface.mm:
3500         (InitWebCoreSystemInterface):
3501
3502 2017-02-07  Alexey Proskuryakov  <ap@apple.com>
3503
3504         Don't migrate WebKit DOM headers in MigrateHeaders.make
3505         https://bugs.webkit.org/show_bug.cgi?id=167608
3506
3507         Reviewed by Darin Adler.
3508
3509         Stop migrating DOM headers that are now in WebKit.
3510
3511         * DOM/DOMDOMImplementation.h: Removed.
3512         * DOM/DOMDOMImplementation.mm: Removed.
3513         * DOM/DOMDOMImplementationInternal.h: Removed.
3514         * DOM/DOMDOMTokenList.h: Removed.
3515         * DOM/DOMDOMTokenList.mm: Removed.
3516         * DOM/DOMDOMTokenListInternal.h: Removed.
3517         * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
3518         * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
3519         * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
3520         * DOM/DOMTokenList.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.h.
3521         * DOM/DOMTokenList.mm: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.mm.
3522         * DOM/DOMTokenListInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenListInternal.h.
3523         As the files are not in WebCore any more, there is no need to differentiate from
3524         WebCore internal headers with the same name. This makes it possible to make these
3525         headers private using Xcode mechanisms, as opposed to copying with a shell script.
3526
3527         * DOM/DOMElement.mm: Removed "using namespace WebCore". Other DOM implementation
3528         files don't have it.
3529
3530         * DOM/DOMCore.h:
3531         * DOM/DOMDocument.mm:
3532         * DOM/DOMHTMLAnchorElement.mm:
3533         * DOM/DOMHTMLAreaElement.mm:
3534         * DOM/DOMHTMLLinkElement.mm:
3535         * DOM/DOMUtility.mm:
3536         No more "DOMDOM".
3537
3538         * WebKit.exp:
3539         No more "DOMDOM". DOMDOMTokenList was not directly expos