Unreviewed, rolling out r241559 and r241566.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-02-15  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r241559 and r241566.
4         https://bugs.webkit.org/show_bug.cgi?id=194710
5
6         Causes layout test crashes under GuardMalloc (Requested by
7         ryanhaddad on #webkit).
8
9         Reverted changesets:
10
11         "[WTF] Add environment variable helpers"
12         https://bugs.webkit.org/show_bug.cgi?id=192405
13         https://trac.webkit.org/changeset/241559
14
15         "Unreviewed build fix for WinCairo Debug after r241559."
16         https://trac.webkit.org/changeset/241566
17
18 2019-02-15  Truitt Savell  <tsavell@apple.com>
19
20         Unreviewed, rolling out r241564.
21
22         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
23
24         Reverted changeset:
25
26         "[Mac] WebInspectorUI.framework does not need to be soft-
27         linked anymore"
28         https://bugs.webkit.org/show_bug.cgi?id=194411
29         https://trac.webkit.org/changeset/241564
30
31 2019-02-14  Brian Burg  <bburg@apple.com>
32
33         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
34         https://bugs.webkit.org/show_bug.cgi?id=194411
35         <rdar://problem/47787614>
36
37         Reviewed by Joseph Pecoraro.
38
39         * Configurations/WebKitLegacy.xcconfig:
40         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
41
42         * WebCoreSupport/WebInspectorClient.mm:
43         (WebInspectorFrontendClient::localizedStringsURL):
44         (-[WebInspectorWindowController inspectorPagePath]):
45         (-[WebInspectorWindowController inspectorTestPagePath]):
46         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
47
48 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
49
50         [WTF] Add environment variable helpers
51         https://bugs.webkit.org/show_bug.cgi?id=192405
52
53         Reviewed by Michael Catanzaro.
54
55         * WebView/WebView.mm:
56         (-[WebView _initWithFrame:frameName:groupName:]):
57         Utilize WTF::Environment where possible.
58
59 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
60
61         Allow pages to trigger programmatic paste from script on iOS
62         https://bugs.webkit.org/show_bug.cgi?id=194271
63         <rdar://problem/47808810>
64
65         Reviewed by Ryosuke Niwa.
66
67         See WebCore and WebKit ChangeLogs for more details.
68
69         * WebCoreSupport/WebEditorClient.h:
70
71 2019-02-12  Andy Estes  <aestes@apple.com>
72
73         [iOSMac] Enable Parental Controls Content Filtering
74         https://bugs.webkit.org/show_bug.cgi?id=194521
75         <rdar://39732376>
76
77         Reviewed by Tim Horton.
78
79         * Configurations/FeatureDefines.xcconfig:
80
81 2019-02-06  Andy Estes  <aestes@apple.com>
82
83         [Payment Request] It should be possible to require a phonetic name for shipping contacts
84         https://bugs.webkit.org/show_bug.cgi?id=194311
85         <rdar://46733045>
86
87         Reviewed by Alex Christensen.
88
89         * WebCoreSupport/WebPaymentCoordinatorClient.h:
90         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
91         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
92
93 2019-02-04  Said Abou-Hallawa  <said@apple.com>
94
95         [CG] Enable setAdditionalSupportedImageTypes for WK1
96         https://bugs.webkit.org/show_bug.cgi?id=194190
97
98         Reviewed by Tim Horton.
99
100         1. Define the preferences key AdditionalSupportedImageTypes.
101         2. Add additionalSupportedImageTypes as a private preference property.
102         3. Define the setter and the getter of the property.
103         4. Add function to convert from an id to an array of strings.
104         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
105
106         * WebView/WebPreferenceKeysPrivate.h:
107         * WebView/WebPreferences.mm:
108         (-[WebPreferences _stringArrayValueForKey:]):
109         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
110         (-[WebPreferences setAdditionalSupportedImageTypes:]):
111         (-[WebPreferences additionalSupportedImageTypes]):
112         * WebView/WebPreferencesPrivate.h:
113         * WebView/WebView.mm:
114         (-[WebView _preferencesChanged:]):
115
116 2019-02-04  Timothy Hatcher  <timothy@apple.com>
117
118         Add WebView SPI to temporarily force light or dark appearance on a page.
119         https://bugs.webkit.org/show_bug.cgi?id=194230
120
121         Reviewed by Tim Horton.
122
123         * WebView/WebView.mm:
124         (-[WebView _useDarkAppearance:]): Added.
125         (-[WebView _setUseDarkAppearance:]): Added.
126         * WebView/WebViewPrivate.h:
127
128 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
129
130         PageOverlayController's layers should be created lazily
131         https://bugs.webkit.org/show_bug.cgi?id=194199
132         rdar://problem/46571593
133
134         Reviewed by Tim Horton.
135
136         * WebCoreSupport/WebChromeClient.h:
137         * WebCoreSupport/WebChromeClient.mm:
138         (WebChromeClient::attachViewOverlayGraphicsLayer):
139
140 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
141
142         Make setNeedsLayout on the root more explicitly about triggering its side-effects
143         https://bugs.webkit.org/show_bug.cgi?id=194198
144
145         Reviewed by Antti Koivisto.
146
147         Call the newly named functions.
148
149         * WebView/WebFrame.mm:
150         (-[WebFrame setNeedsLayout]):
151         * WebView/WebHTMLView.mm:
152         (-[WebHTMLView setNeedsLayout:]):
153
154 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
155
156         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
157         https://bugs.webkit.org/show_bug.cgi?id=194189
158
159         Reviewed by Geoffrey Garen.
160
161         Pass the policy check identifier around functions and store it in WebFramePolicyListener
162         so that we can send it back to WebCore with the navigation policy decision.
163
164         * WebCoreSupport/WebFrameLoaderClient.h:
165         * WebCoreSupport/WebFrameLoaderClient.mm:
166         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
167         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
168         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
169         (WebFrameLoaderClient::dispatchWillSubmitForm):
170         (WebFrameLoaderClient::setUpPolicyListener):
171         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
172         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
173         (-[WebFramePolicyListener invalidate]):
174         (-[WebFramePolicyListener dealloc]):
175         (-[WebFramePolicyListener receivedPolicyDecision:]):
176         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
177         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
178
179 2019-01-31  Alex Christensen  <achristensen@webkit.org>
180
181         Revert r238819 which is unneeded and caused a performance regression.
182         https://bugs.webkit.org/show_bug.cgi?id=192272
183         <rdar://problem/46664625>
184
185         * WebCoreSupport/WebFrameLoaderClient.h:
186         * WebCoreSupport/WebFrameLoaderClient.mm:
187         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
188
189 2019-01-28  Devin Rousso  <drousso@apple.com>
190
191         Web Inspector: provide a way to edit page WebRTC settings on a remote target
192         https://bugs.webkit.org/show_bug.cgi?id=193863
193         <rdar://problem/47572764>
194
195         Reviewed by Joseph Pecoraro.
196
197         * WebView/WebView.mm:
198         (-[WebView _preferencesChanged:]):
199         Add page-level settings for WebRTC preferences.
200
201 2019-01-28  Andy Estes  <aestes@apple.com>
202
203         [watchOS] Enable Parental Controls content filtering
204         https://bugs.webkit.org/show_bug.cgi?id=193939
205         <rdar://problem/46641912>
206
207         Reviewed by Ryosuke Niwa.
208
209         * Configurations/FeatureDefines.xcconfig:
210
211 2019-01-28  Timothy Hatcher  <timothy@apple.com>
212
213         Make it easier for non-Apple ports to enable dark mode CSS support.
214         https://bugs.webkit.org/show_bug.cgi?id=193882
215
216         Reviewed by Megan Gardner.
217
218         * WebView/WebView.mm:
219         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
220         (-[WebView _effectiveAppearanceIsDark]): Ditto.
221
222 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
223
224         AX: Introduce a static accessibility tree
225         https://bugs.webkit.org/show_bug.cgi?id=193348
226         <rdar://problem/47203295>
227
228         Reviewed by Ryosuke Niwa.
229
230         * Configurations/FeatureDefines.xcconfig:
231
232 2019-01-25  Keith Rollin  <krollin@apple.com>
233
234         Update WebKitAdditions.xcconfig with correct order of variable definitions
235         https://bugs.webkit.org/show_bug.cgi?id=193793
236         <rdar://problem/47532439>
237
238         Reviewed by Alex Christensen.
239
240         XCBuild changes the way xcconfig variables are evaluated. In short,
241         all config file assignments are now considered in part of the
242         evaluation. When using the new build system and an .xcconfig file
243         contains multiple assignments of the same build setting:
244
245         - Later assignments using $(inherited) will inherit from earlier
246           assignments in the xcconfig file.
247         - Later assignments not using $(inherited) will take precedence over
248           earlier assignments. An assignment to a more general setting will
249           mask an earlier assignment to a less general setting. For example,
250           an assignment without a condition ('FOO = bar') will completely mask
251           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
252
253         This affects some of our .xcconfig files, in that sometimes platform-
254         or sdk-specific definitions appear before the general definitions.
255         Under the new evaluations rules, the general definitions alway take
256         effect because they always overwrite the more-specific definitions. The
257         solution is to swap the order, so that the general definitions are
258         established first, and then conditionally overwritten by the
259         more-specific definitions.
260
261         * Configurations/Version.xcconfig:
262         * Configurations/WebKitLegacy.xcconfig:
263
264 2019-01-25  David Kilzer  <ddkilzer@apple.com>
265
266         Move soft-linking of Lookup.framework out of LookupSPI.h
267         <https://webkit.org/b/193815>
268
269         Reviewed by Tim Horton.
270
271         * WebView/WebImmediateActionController.mm:
272         (-[WebImmediateActionController _animationControllerForText]):
273         * WebView/WebView.mm:
274         (-[WebView _prepareForDictionaryLookup]):
275         - Move soft-linking to LookupSoftLink.{h,mm}.
276
277 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
278
279         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
280         https://bugs.webkit.org/show_bug.cgi?id=193829
281
282         Reviewed by Tim Horton.
283
284         * WebCoreSupport/WebDragClient.mm:
285         (WebDragClient::didConcludeEditDrag):
286         * WebView/WebView.mm:
287         (-[WebView _requestStartDataInteraction:globalPosition:]):
288         (-[WebView _didConcludeEditDrag]):
289         (-[WebView _didConcludeEditDataInteraction]): Deleted.
290         * WebView/WebViewInternal.h:
291
292 2019-01-24  John Wilander  <wilander@apple.com>
293
294         Add Ad Click Attribution as an internal/experimental feature
295         https://bugs.webkit.org/show_bug.cgi?id=193685
296         <rdar://problem/47450399>
297
298         Reviewed by Brent Fulgham.
299
300         * WebView/WebPreferenceKeysPrivate.h:
301         * WebView/WebPreferences.mm:
302         (+[WebPreferences initialize]):
303         (-[WebPreferences adClickAttributionEnabled]):
304         (-[WebPreferences setAdClickAttributionEnabled:]):
305             Added support for experimental ad click attribution.
306         * WebView/WebPreferencesPrivate.h:
307         * WebView/WebView.mm:
308         (-[WebView _preferencesChanged:]):
309
310 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
311
312         Move FileSystem to WTF
313         https://bugs.webkit.org/show_bug.cgi?id=193602
314
315         Reviewed by Yusuke Suzuki.
316
317         * Misc/WebNSFileManagerExtras.mm:
318         * Storage/WebDatabaseProvider.mm:
319         * WebView/WebView.mm:
320
321 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
322
323         Fix the Apple Internal build. See <rdar://problem/47491383>.
324
325         Rubber-stamped by Tim Horton.
326
327         * WebCoreSupport/WebFrameLoaderClient.mm:
328
329 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
330
331         Clean up USE(WEB_THREAD)
332         https://bugs.webkit.org/show_bug.cgi?id=193698
333
334         Rubber-stamped by Tim Horton.
335
336         * Misc/WebCache.mm:
337         (+[WebCache emptyInMemoryResources]):
338         * WebCoreSupport/WebFrameLoaderClient.mm:
339         (-[WebFramePolicyListener use]):
340         * WebCoreSupport/WebGeolocationClient.mm:
341         (-[WebGeolocationPolicyListener allow]):
342         (-[WebGeolocationPolicyListener deny]):
343         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
344         * WebView/WebFrame.mm:
345         (-[WebFrame deviceOrientationChanged]):
346         * WebView/WebHTMLView.mm:
347         (hardwareKeyboardAvailabilityChangedCallback):
348         * WebView/WebView.mm:
349         (+[WebView _releaseMemoryNow]):
350         (+[WebView willEnterBackgroundWithCompletionHandler:]):
351         (-[WebView updateLayoutIgnorePendingStyleSheets]):
352         (-[WebView _dispatchUnloadEvent]):
353         (-[WebView _close]):
354         (-[WebView _preferencesChangedNotification:]):
355         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
356         (-[WebView goBack]):
357         (-[WebView goForward]):
358         (+[WebView _cacheModelChangedNotification:]):
359         (-[WebView stopLoading:]):
360         (-[WebView stopLoadingAndClear]):
361         (-[WebView reload:]):
362         (WebInstallMemoryPressureHandler):
363
364 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
365
366         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
367         https://bugs.webkit.org/show_bug.cgi?id=193706
368         <rdar://problem/44807048>
369
370         Reviewed by Ryosuke Niwa.
371
372         Use UndoStep::label().
373
374         * WebCoreSupport/WebEditorClient.h:
375         * WebCoreSupport/WebEditorClient.mm:
376         (-[WebUndoStep initWithUndoStep:]):
377         (+[WebUndoStep stepWithUndoStep:]):
378         (WebEditorClient::registerUndoOrRedoStep):
379         (WebEditorClient::registerUndoStep):
380         (WebEditorClient::registerRedoStep):
381
382 2019-01-22  Alex Christensen  <achristensen@webkit.org>
383
384         Move NetworkStorageSession ownership to NetworkProcess
385         https://bugs.webkit.org/show_bug.cgi?id=193580
386
387         Reviewed by Geoff Garen.
388
389         * Misc/WebCache.mm:
390         (+[WebCache clearCachedCredentials]):
391         * Misc/WebDownload.mm:
392         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
393         * Plugins/WebBaseNetscapePluginView.mm:
394         (WebKit::getAuthenticationInfo):
395         * WebCoreSupport/WebFrameNetworkingContext.mm:
396         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
397         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
398         (WebFrameNetworkingContext::storageSession const):
399         * WebView/WebPreferences.mm:
400         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
401         (+[WebPreferences _clearNetworkLoaderSession]):
402         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
403
404 2019-01-22  Daniel Bates  <dabates@apple.com>
405
406         [iOS] Interpret text key commands on keydown and app key commands on keypress
407         https://bugs.webkit.org/show_bug.cgi?id=192897
408         <rdar://problem/46857378>
409
410         Reviewed by Brent Fulgham.
411
412         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
413         is false) and keypress (isCharEvent is true), respectively.
414
415         * WebView/WebHTMLView.mm:
416         (-[WebHTMLView _handleEditingKeyEvent:]):
417
418 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
419
420         [css-logical] Implement flow-relative margin, padding and border shorthands
421         https://bugs.webkit.org/show_bug.cgi?id=188697
422
423         Reviewed by Simon Fraser and Antti Koivisto.
424
425         Add CSSLogicalEnabled runtime flag.
426
427         * WebView/WebPreferenceKeysPrivate.h:
428         * WebView/WebPreferences.mm:
429         (+[WebPreferences initialize]):
430         (-[WebPreferences cssLogicalEnabled]):
431         (-[WebPreferences setCSSLogicalEnabled:]):
432         * WebView/WebPreferencesPrivate.h:
433         * WebView/WebView.mm:
434         (-[WebView _preferencesChanged:]):
435
436 2019-01-15  Darin Adler  <darin@apple.com>
437
438         Use references rather than pointers for register/unregister functions, and more
439         https://bugs.webkit.org/show_bug.cgi?id=175028
440
441         Reviewed by Daniel Bates.
442
443         * WebCoreSupport/WebKitFullScreenListener.mm:
444         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
445         functions in Document; pass a reference.
446         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
447         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
448         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
449         * WebView/WebFullScreenController.mm:
450         (-[WebFullScreenController enterFullScreen:]): Ditto.
451         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
452         (-[WebFullScreenController exitFullScreen]): Ditto.
453         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
454         * WebView/WebFullScreenController.mm:
455         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
456
457 2019-01-12  Dan Bernstein  <mitz@apple.com>
458
459         [Cocoa] Avoid importing directly from subumbrella frameworks
460         https://bugs.webkit.org/show_bug.cgi?id=186016
461         <rdar://problem/40591038>
462
463         Reviewed by Sam Weinig.
464
465         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
466         * Carbon/CarbonWindowAdapter.mm: Ditto.
467         * Carbon/CarbonWindowFrame.m: Ditto.
468         * Carbon/HIViewAdapter.h: Ditto.
469         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
470           OTHER_CFLAGS_COCOA_TOUCH_NO.
471         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
472         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
473         * WebView/WebPDFView.h: Ditto.
474
475 2019-01-20  Antoine Quint  <graouts@apple.com>
476
477         Add a POINTER_EVENTS feature flag
478         https://bugs.webkit.org/show_bug.cgi?id=193577
479         <rdar://problem/47408511>
480
481         Unreviewed. Also enable Pointer Events for iosmac.
482
483         * Configurations/FeatureDefines.xcconfig:
484
485 2019-01-19  Antoine Quint  <graouts@apple.com>
486
487         Add a POINTER_EVENTS feature flag
488         https://bugs.webkit.org/show_bug.cgi?id=193577
489
490         Reviewed by Dean Jackson.
491
492         * Configurations/FeatureDefines.xcconfig:
493
494 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
495
496         Revert r238815, it broke WK1 video fullscreen on Mac
497         https://bugs.webkit.org/show_bug.cgi?id=193586
498         <rdar://problem/47358941>
499
500         Reviewed by Jer Noble.
501
502         * WebView/WebVideoFullscreenController.h: Added.
503         * WebView/WebVideoFullscreenController.mm: Added.
504         (SOFT_LINK_CLASS):
505         (-[WebVideoFullscreenController init]):
506         (-[WebVideoFullscreenController dealloc]):
507         (-[WebVideoFullscreenController fullscreenWindow]):
508         (-[WebVideoFullscreenController windowDidLoad]):
509         (-[WebVideoFullscreenController videoElement]):
510         (-[WebVideoFullscreenController setVideoElement:]):
511         (-[WebVideoFullscreenController clearFadeAnimation]):
512         (-[WebVideoFullscreenController windowDidExitFullscreen]):
513         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
514         (-[WebVideoFullscreenController videoElementRect]):
515         (-[WebVideoFullscreenController applicationDidResignActive:]):
516         (frameExpandedToRatioOfFrame):
517         (createBackgroundFullscreenWindow):
518         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
519         (-[WebVideoFullscreenController enterFullscreen:]):
520         (-[WebVideoFullscreenController exitFullscreen]):
521         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
522         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
523         (-[WebVideoFullscreenController _requestExit]):
524         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
525         (-[WebVideoFullscreenController requestExitFullscreen]):
526         (-[WebVideoFullscreenController fadeHUDIn]):
527         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
528         (-[WebVideoFullscreenController rateChanged:]):
529         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
530         (-[WebVideoFullscreenWindow dealloc]):
531         (-[WebVideoFullscreenWindow resignFirstResponder]):
532         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
533         (-[WebVideoFullscreenWindow mouseDown:]):
534         (-[WebVideoFullscreenWindow cancelOperation:]):
535         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
536         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
537         (-[WebVideoFullscreenWindow animationDidEnd:]):
538         (-[WebVideoFullscreenWindow mouseMoved:]):
539         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
540         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
541         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
542         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
543         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
544         (-[WebVideoFullscreenHUDWindow center]):
545         (-[WebVideoFullscreenHUDWindow keyDown:]):
546         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
547         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
548         (-[WebVideoFullscreenHUDWindowController init]):
549         (-[WebVideoFullscreenHUDWindowController dealloc]):
550         (-[WebVideoFullscreenHUDWindowController setArea:]):
551         (-[WebVideoFullscreenHUDWindowController keyDown:]):
552         (-[WebVideoFullscreenHUDWindowController delegate]):
553         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
554         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
555         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
556         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
557         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
558         (-[WebVideoFullscreenHUDWindowController closeWindow]):
559         (createMediaUIControl):
560         (createControlWithMediaUIControlType):
561         (createTimeTextField):
562         (createMediaUIBackgroundView):
563         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
564         (-[WebVideoFullscreenHUDWindowController updateVolume]):
565         (-[WebVideoFullscreenHUDWindowController updateTime]):
566         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
567         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
568         (-[WebVideoFullscreenHUDWindowController currentTime]):
569         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
570         (-[WebVideoFullscreenHUDWindowController duration]):
571         (-[WebVideoFullscreenHUDWindowController maxVolume]):
572         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
573         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
574         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
575         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
576         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
577         (-[WebVideoFullscreenHUDWindowController volume]):
578         (-[WebVideoFullscreenHUDWindowController setVolume:]):
579         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
580         (-[WebVideoFullscreenHUDWindowController updateRate]):
581         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
582         (-[WebVideoFullscreenHUDWindowController playing]):
583         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
584         (timeToString):
585         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
586         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
587         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
588         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
589         (-[WebVideoFullscreenHUDWindowController rewind:]):
590         (-[WebVideoFullscreenHUDWindowController fastForward:]):
591         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
592         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
593         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
594         * WebView/WebView.mm:
595         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
596         (-[WebView _exitVideoFullscreen]):
597
598 2019-01-18  Tim Horton  <timothy_horton@apple.com>
599
600         Get rid of ADVANCED_SPELL_CHECKING
601         https://bugs.webkit.org/show_bug.cgi?id=193592
602
603         Reviewed by Wenson Hsieh.
604
605         * WebCoreSupport/WebEditorClient.mm:
606         (insertionPointFromCurrentSelection):
607         (WebEditorClient::checkTextOfParagraph):
608         (WebEditorClient::getGuessesForWord):
609         (WebEditorClient::requestCandidatesForSelection):
610         (WebEditorClient::requestCheckingOfString):
611         * WebView/WebHTMLView.mm:
612         (-[WebHTMLView insertText:]):
613
614 2019-01-18  Jer Noble  <jer.noble@apple.com>
615
616         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
617         https://bugs.webkit.org/show_bug.cgi?id=189553
618
619         Reviewed by Tim Horton.
620
621         * Configurations/Base.xcconfig:
622         * Configurations/SDKVariant.xcconfig: Added.
623         * Configurations/WebKitLegacy.xcconfig:
624
625 2019-01-18  David Kilzer  <ddkilzer@apple.com>
626
627         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
628         <https://webkit.org/b/193568>
629         <rdar://problem/47381130>
630
631         Reviewed by Alex Christensen.
632
633         * WebView/WebView.mm:
634         - Remove unused soft-linking macros.
635         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
636         (-[WebUITextIndicatorData initWithImage:scale:]):
637         - Update to use exported PAL functions.
638
639 2019-01-17  Truitt Savell  <tsavell@apple.com>
640
641         Unreviewed, rolling out r240124.
642
643         This commit broke an internal build.
644
645         Reverted changeset:
646
647         "SDK_VARIANT build destinations should be separate from non-
648         SDK_VARIANT builds"
649         https://bugs.webkit.org/show_bug.cgi?id=189553
650         https://trac.webkit.org/changeset/240124
651
652 2019-01-17  Jer Noble  <jer.noble@apple.com>
653
654         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
655         https://bugs.webkit.org/show_bug.cgi?id=189553
656
657         Reviewed by Tim Horton.
658
659         * Configurations/Base.xcconfig:
660         * Configurations/SDKVariant.xcconfig: Added.
661         * Configurations/WebKitLegacy.xcconfig:
662
663 2019-01-17  Alex Christensen  <achristensen@webkit.org>
664
665         Stop using NetworkStorageSession::storageSession in WebCore
666         https://bugs.webkit.org/show_bug.cgi?id=193529
667
668         Reviewed by Tim Horton.
669
670         * Misc/WebCache.mm:
671         (+[WebCache addImageToCache:forURL:forFrame:]):
672         * WebView/WebView.mm:
673         (-[WebView _commonInitializationWithFrameName:groupName:]):
674         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
675
676 2019-01-15  Alex Christensen  <achristensen@webkit.org>
677
678         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
679         https://bugs.webkit.org/show_bug.cgi?id=193368
680
681         Reviewed by Geoff Garen.
682
683         * Misc/WebCache.mm:
684         (+[WebCache clearCachedCredentials]):
685         * Misc/WebDownload.mm:
686         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
687         * Plugins/WebBaseNetscapePluginView.mm:
688         (WebKit::getAuthenticationInfo):
689
690 2019-01-15  Alex Christensen  <achristensen@webkit.org>
691
692         Stop using CookiesStrategy
693         https://bugs.webkit.org/show_bug.cgi?id=161106
694
695         Reviewed by Don Olmstead and Antti Koivisto.
696
697         * Misc/WebCache.mm:
698         (+[WebCache addImageToCache:forURL:forFrame:]):
699         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
700         (WebKit::NetscapePluginInstanceProxy::getCookies):
701         (WebKit::NetscapePluginInstanceProxy::setCookies):
702         * Plugins/WebNetscapePluginView.mm:
703         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
704         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
705         * WebCoreSupport/WebPlatformStrategies.h:
706         * WebCoreSupport/WebPlatformStrategies.mm:
707         (WebPlatformStrategies::createCookiesStrategy): Deleted.
708         (WebPlatformStrategies::cookiesForDOM): Deleted.
709         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
710         (WebPlatformStrategies::cookiesEnabled): Deleted.
711         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
712         (WebPlatformStrategies::getRawCookies): Deleted.
713         (WebPlatformStrategies::deleteCookie): Deleted.
714         * WebView/WebView.mm:
715         (-[WebView _commonInitializationWithFrameName:groupName:]):
716         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
717
718 2019-01-15  Tim Horton  <timothy_horton@apple.com>
719
720         Cannot tab out of WKWebView on macOS
721         https://bugs.webkit.org/show_bug.cgi?id=161448
722         <rdar://problem/28100085>
723
724         Reviewed by Dean Jackson.
725
726         * WebCoreSupport/WebChromeClient.mm:
727         * WebView/WebView.mm:
728         Make use of SPI headers.
729
730 2019-01-14  Commit Queue  <commit-queue@webkit.org>
731
732         Unreviewed, rolling out r239901, r239909, r239910, r239912,
733         r239913, and r239914.
734         https://bugs.webkit.org/show_bug.cgi?id=193407
735
736         These revisions caused an internal failure (Requested by
737         Truitt on #webkit).
738
739         Reverted changesets:
740
741         "[Cocoa] Avoid importing directly from subumbrella frameworks"
742         https://bugs.webkit.org/show_bug.cgi?id=186016
743         https://trac.webkit.org/changeset/239901
744
745         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
746         https://trac.webkit.org/changeset/239909
747
748         "Tried to fix the build."
749         https://trac.webkit.org/changeset/239910
750
751         "Fixed iOS builds after r239910."
752         https://trac.webkit.org/changeset/239912
753
754         "More build fixing."
755         https://trac.webkit.org/changeset/239913
756
757         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
758         https://trac.webkit.org/changeset/239914
759
760 2019-01-14  Mark Lam  <mark.lam@apple.com>
761
762         Re-enable ability to build --cloop builds.
763         https://bugs.webkit.org/show_bug.cgi?id=192955
764         <rdar://problem/46882363>
765
766         Reviewed by Saam barati and Keith Miller.
767
768         * Configurations/FeatureDefines.xcconfig:
769
770 2019-01-13  Dan Bernstein  <mitz@apple.com>
771
772         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
773
774         Patch by Keith Rollin.
775
776         * WebView/PDFViewSPI.h:
777
778 2019-01-12  Timothy Hatcher  <timothy@apple.com>
779
780         Have prefers-color-scheme: light always match on macOS versions before Mojave.
781         https://bugs.webkit.org/show_bug.cgi?id=191655
782         rdar://problem/46074680
783
784         Reviewed by Megan Gardner.
785
786         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
787         * WebView/WebView.mm:
788         (-[WebView _effectiveAppearanceIsDark]):
789
790 2019-01-12  Dan Bernstein  <mitz@apple.com>
791
792         [Cocoa] Avoid importing directly from subumbrella frameworks
793         https://bugs.webkit.org/show_bug.cgi?id=186016
794         <rdar://problem/40591038>
795
796         Reviewed by Sam Weinig.
797
798         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
799         * Carbon/CarbonWindowAdapter.mm: Ditto.
800         * Carbon/CarbonWindowFrame.m: Ditto.
801         * Carbon/HIViewAdapter.h: Ditto.
802         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
803           OTHER_CFLAGS_COCOA_TOUCH_NO.
804         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
805         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
806         * WebView/WebPDFView.h: Ditto.
807
808 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
809
810         Enable visual viewport API by default
811         https://bugs.webkit.org/show_bug.cgi?id=193376
812
813         Reviewed by Simon Fraser.
814
815         * WebView/WebPreferences.mm:
816         (+[WebPreferences initialize]):
817
818 2019-01-11  John Wilander  <wilander@apple.com>
819
820         Compile out Web API Statistics Collection
821         https://bugs.webkit.org/show_bug.cgi?id=193370
822         <rdar://problem/45388584>
823
824         Reviewed by Brent Fulgham.
825
826         * Configurations/FeatureDefines.xcconfig:
827             Defined ENABLE_WEB_API_STATISTICS, off by default.
828
829 2019-01-08  Alex Christensen  <achristensen@webkit.org>
830
831         Stop using NetworkStorageSession in WebProcess
832         https://bugs.webkit.org/show_bug.cgi?id=193236
833
834         Reviewed by Don Olmstead.
835
836         * WebCoreSupport/WebFrameNetworkingContext.h:
837         * WebCoreSupport/WebFrameNetworkingContext.mm:
838         (WebFrameNetworkingContext::storageSession const):
839         * WebCoreSupport/WebPlatformStrategies.h:
840         * WebCoreSupport/WebPlatformStrategies.mm:
841         (WebPlatformStrategies::cookiesForDOM):
842         (WebPlatformStrategies::setCookiesFromDOM):
843         (WebPlatformStrategies::cookiesEnabled):
844         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
845         (WebPlatformStrategies::getRawCookies):
846         (WebPlatformStrategies::deleteCookie):
847         * WebView/WebView.mm:
848         (-[WebView _cachedResponseForURL:]):
849         (-[WebView _clearCredentials]):
850
851 2019-01-08  Alex Christensen  <achristensen@webkit.org>
852
853         Unreviewed, rolling out r239727.
854
855         Broke API tests
856
857         Reverted changeset:
858
859         "Stop using NetworkStorageSession in WebProcess"
860         https://bugs.webkit.org/show_bug.cgi?id=193236
861         https://trac.webkit.org/changeset/239727
862
863 2019-01-08  Alex Christensen  <achristensen@webkit.org>
864
865         Stop using NetworkStorageSession in WebProcess
866         https://bugs.webkit.org/show_bug.cgi?id=193236
867
868         Reviewed by Don Olmstead.
869
870         * WebCoreSupport/WebFrameNetworkingContext.h:
871         * WebCoreSupport/WebFrameNetworkingContext.mm:
872         (WebFrameNetworkingContext::storageSession const):
873         * WebView/WebView.mm:
874         (-[WebView _cachedResponseForURL:]):
875         (-[WebView _clearCredentials]):
876
877 2019-01-07  David Kilzer  <ddkilzer@apple.com>
878
879         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
880         <https://webkit.org/b/193056>
881
882         Reviewed by Alex Christensen.
883
884         * Plugins/Hosted/NetscapePluginHostProxy.h:
885         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
886         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
887         (WebKit::NetscapePluginInstanceProxy::enumerate):
888         (WebKit::NetscapePluginInstanceProxy::marshalValue):
889         (WebKit::NetscapePluginInstanceProxy::marshalValues):
890         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
891         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
892         * Plugins/Hosted/ProxyInstance.mm:
893         (WebKit::ProxyInstance::invoke):
894         * WebCoreSupport/WebGeolocationClient.mm:
895         * WebView/WebDataSource.mm:
896         (-[WebDataSource _receivedData:]):
897         * WebView/WebView.mm:
898         (-[WebView _cachedResponseForURL:]):
899         - Remove '*' from RetainPtr<> type.
900
901 2019-01-04  Alex Christensen  <achristensen@webkit.org>
902
903         Progress towards fixing Mac CMake build
904         https://bugs.webkit.org/show_bug.cgi?id=193105
905
906         Reviewed by Don Olmstead.
907
908         * WebKitPrefix.h:
909
910 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
911
912         Web Inspector: Use save sheet instead of dialog where possible
913         https://bugs.webkit.org/show_bug.cgi?id=193160
914         <rdar://problem/37399759>
915
916         Reviewed by Devin Rousso.
917
918         * WebCoreSupport/WebInspectorClient.mm:
919         (WebInspectorFrontendClient::save):
920
921 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
922
923         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
924         https://bugs.webkit.org/show_bug.cgi?id=193129
925
926         Reviewed by Tim Horton.
927
928         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
929
930         * WebCoreSupport/WebEditorClient.mm:
931         (WebEditorClient::registerUndoOrRedoStep):
932         (undoNameForEditAction): Deleted.
933
934 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
935
936         Add support for using the current text selection as the find string on iOS
937         https://bugs.webkit.org/show_bug.cgi?id=193034
938         <rdar://problem/45138739>
939
940         Reviewed by Tim Horton.
941
942         Add a method stub for WebKitLegacy.
943
944         * WebCoreSupport/WebEditorClient.h:
945
946 2019-01-01  Jeff Miller  <jeffm@apple.com>
947
948         Update user-visible copyright strings to include 2019
949         https://bugs.webkit.org/show_bug.cgi?id=192811
950
951         Reviewed by Mark Lam.
952
953         * Info.plist:
954
955 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
956
957         Use Ref<> as much as possible
958         https://bugs.webkit.org/show_bug.cgi?id=192808
959
960         Reviewed by Alex Christensen.
961
962         * DOM/DOM.mm:
963         (-[DOMNode getPreviewSnapshotImage:andRects:]):
964         * Plugins/Hosted/NetscapePluginHostManager.mm:
965         (WebKit::NetscapePluginHostManager::instantiatePlugin):
966         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
967         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
968         (WebKit::NetscapePluginInstanceProxy::loadRequest):
969         * Plugins/WebNetscapePluginView.mm:
970         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
971         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
972         * WebCoreSupport/WebContextMenuClient.mm:
973         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
974         * WebCoreSupport/WebFrameLoaderClient.mm:
975         (WebFrameLoaderClient::transitionToCommittedForNewPage):
976         * WebView/WebFrame.mm:
977         (-[WebFrame getDictationResultRanges:andMetadatas:]):
978         * WebView/WebHTMLView.mm:
979         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
980         * WebView/WebView.mm:
981         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
982         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
983
984 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
985
986         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
987         https://bugs.webkit.org/show_bug.cgi?id=192821
988
989         Reviewed by Chris Dumez.
990
991         When a window becomes occluded, the window server informs the application.
992         This should be used to suspend any work that is not visible by the user.
993
994         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
995         In some cases, that lead to performance impact (see radar).
996
997         This patch adds an observer for the occlusion notification. I tried to stick
998         with the same names used by WebKit2.
999
1000         * WebView/WebView.mm:
1001         (-[WebView _isViewVisible]):
1002         (-[WebView addWindowObserversForWindow:]):
1003         (-[WebView removeWindowObservers]):
1004         (-[WebView _windowDidChangeOcclusionState:]):
1005
1006 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1007
1008         [WebAuthN] Add a runtime flag for local authenticator
1009         https://bugs.webkit.org/show_bug.cgi?id=192792
1010         <rdar://problem/46798738>
1011
1012         Reviewed by Brent Fulgham.
1013
1014         * WebView/WebPreferenceKeysPrivate.h:
1015         * WebView/WebPreferences.mm:
1016         (+[WebPreferences initialize]):
1017         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1018         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1019         * WebView/WebPreferencesPrivate.h:
1020         * WebView/WebView.mm:
1021         (-[WebView _preferencesChanged:]):
1022
1023 2018-12-20  Chris Dumez  <cdumez@apple.com>
1024
1025         Use Optional::valueOr() instead of Optional::value_or()
1026         https://bugs.webkit.org/show_bug.cgi?id=192933
1027
1028         Reviewed by Geoffrey Garen.
1029
1030         * WebCoreSupport/WebSecurityOrigin.mm:
1031         (-[WebSecurityOrigin port]):
1032
1033 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1034
1035         Unreviewed, rolling out r239417.
1036
1037         Introduced two API test failures on macOS.
1038
1039         Reverted changeset:
1040
1041         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1042         occlusion changes"
1043         https://bugs.webkit.org/show_bug.cgi?id=192821
1044         https://trac.webkit.org/changeset/239417
1045
1046 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1047
1048         WKWebView default UA doesn't freeze the build number
1049         https://bugs.webkit.org/show_bug.cgi?id=192809
1050         <rdar://problem/44687185>
1051
1052         Reviewed by Andy Estes.
1053
1054         Always reports the frozen build number.
1055
1056         * WebView/WebView.mm:
1057         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1058         actual build number through this method call.
1059         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1060
1061 2018-12-19  Chris Dumez  <cdumez@apple.com>
1062
1063         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1064         https://bugs.webkit.org/show_bug.cgi?id=192728
1065         <rdar://problem/46746779>
1066
1067         Reviewed by Geoff Garen.
1068
1069         * DOM/*:
1070         * Plugins/*:
1071         * WebCoreSupport/*:
1072         * WebView/*:
1073
1074 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1075
1076         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1077         https://bugs.webkit.org/show_bug.cgi?id=192821
1078
1079         Reviewed by Chris Dumez.
1080
1081         When a window becomes occluded, the window server informs the application.
1082         This should be used to suspend any work that is not visible by the user.
1083
1084         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1085         In some cases, that lead to performance impact (see radar).
1086
1087         This patch adds an observer for the occlusion notification. I tried to stick
1088         with the same names used by WebKit2.
1089
1090         * WebView/WebView.mm:
1091         (-[WebView _isViewVisible]):
1092         (-[WebView addWindowObserversForWindow:]):
1093         (-[WebView removeWindowObservers]):
1094         (-[WebView _windowDidChangeOcclusionState:]):
1095
1096 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1097
1098         Allow clients to set the navigator platform
1099         https://bugs.webkit.org/show_bug.cgi?id=192735
1100
1101         Reviewed by Tim Horton.
1102
1103         Add stubs to fill out the added functionality in FrameLoaderClient.
1104
1105         * WebCoreSupport/WebFrameLoaderClient.h:
1106         * WebCoreSupport/WebFrameLoaderClient.mm:
1107         (WebFrameLoaderClient::navigatorPlatform):
1108
1109 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1110
1111         offsetLeft and offsetParent should adjust across shadow boundaries
1112         https://bugs.webkit.org/show_bug.cgi?id=157437
1113         <rdar://problem/26154021>
1114
1115         Reviewed by Simon Fraser.
1116
1117         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1118
1119         * DOM/DOMElement.mm:
1120         (-[DOMElement offsetLeft]):
1121         (-[DOMElement offsetTop]):
1122         (-[DOMElement offsetParent]):
1123
1124 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1125
1126         Unreviewed build fix.
1127
1128         * WebView/WebFrame.mm:
1129         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1130
1131 2018-12-15  Darin Adler  <darin@apple.com>
1132
1133         Use warning-ignoring macros more consistently and simply
1134         https://bugs.webkit.org/show_bug.cgi?id=192743
1135
1136         Reviewed by Mark Lam.
1137
1138         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1139         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1140         compilers in Objective-C++ code.
1141
1142         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1143         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1144         accomodate non-clang compilers here. Also use #pragma once, add a missing
1145         "explicit" and fix conditionals.
1146
1147 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1148
1149         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1150         https://bugs.webkit.org/show_bug.cgi?id=192653
1151
1152         Reviewed by Wenson Hsieh.
1153
1154         * WebView/WebHTMLView.mm:
1155         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1156
1157 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1158
1159         Implement feature flag for CSS Typed OM
1160         https://bugs.webkit.org/show_bug.cgi?id=192610
1161
1162         Reviewed by Ryosuke Niwa.
1163
1164         * Configurations/FeatureDefines.xcconfig:
1165
1166 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1167
1168         WebCore shouldn't have a Objective-C class named NSCursor
1169         https://bugs.webkit.org/show_bug.cgi?id=192602
1170         <rdar://problem/46615532>
1171
1172         Reviewed by Wenson Hsieh.
1173
1174         * WebView/WebFrameView.mm:
1175         (-[WebFrameView keyDown:keyDown:]):
1176         * WebView/WebHTMLView.mm:
1177         (-[WebHTMLView keyDown:]):
1178         (-[WebHTMLView performKeyEquivalent:]):
1179         Only use NSCursor on macOS.
1180
1181 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1182
1183         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1184         https://bugs.webkit.org/show_bug.cgi?id=192573
1185
1186         Reviewed by Simon Fraser.
1187
1188         * Configurations/FeatureDefines.xcconfig:
1189
1190 2018-12-10  Antti Koivisto  <antti@apple.com>
1191
1192         Rename "forced style recalc" to "full style rebuild"
1193         https://bugs.webkit.org/show_bug.cgi?id=192572
1194
1195         Reviewed by Zalan Bujtas.
1196
1197         * WebView/WebHTMLView.mm:
1198         (-[WebHTMLView setNeedsToApplyStyles:]):
1199
1200 2018-12-10  Darin Adler  <darin@apple.com>
1201
1202         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1203         https://bugs.webkit.org/show_bug.cgi?id=192533
1204         rdar://problem/45732710
1205
1206         Reviewed by Anders Carlsson.
1207
1208         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1209         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1210
1211 2018-12-10  Darin Adler  <darin@apple.com>
1212
1213         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1214         https://bugs.webkit.org/show_bug.cgi?id=192532
1215         rdar://problem/45731047
1216
1217         Reviewed by Chris Dumez.
1218
1219         * Plugins/Hosted/NetscapePluginHostManager.mm:
1220         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1221         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1222         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1223
1224 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1225
1226         Turn WritingDirection into an enum class
1227         https://bugs.webkit.org/show_bug.cgi?id=192401
1228         Work towards <rdar://problem/42075638>
1229
1230         Reviewed by Dan Bernstein.
1231
1232         Change WritingDirection from an enum to an enum class. No change in behavior.
1233
1234         * WebView/WebHTMLView.mm:
1235         (-[WebHTMLView toggleBaseWritingDirection:]):
1236         (-[WebHTMLView changeBaseWritingDirection:]):
1237         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1238
1239 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1240
1241         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1242         https://bugs.webkit.org/show_bug.cgi?id=192272
1243
1244         Reviewed by Brady Eidson.
1245
1246         * WebCoreSupport/WebFrameLoaderClient.h:
1247         * WebCoreSupport/WebFrameLoaderClient.mm:
1248         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1249
1250 2018-12-03  Jer Noble  <jer.noble@apple.com>
1251
1252         Get rid of old, dead Mac video fullscreen code.
1253         https://bugs.webkit.org/show_bug.cgi?id=192315
1254
1255         Reviewed by Eric Carlson.
1256
1257         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1258         is no longer supported in the Mac port.
1259
1260         * WebView/WebVideoFullscreenController.h: Removed.
1261         * WebView/WebVideoFullscreenController.mm: Removed.
1262         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1263         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1264         * WebView/WebView.mm:
1265         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1266         (-[WebView _exitVideoFullscreen]):
1267
1268 2018-12-03  Daniel Bates  <dabates@apple.com>
1269
1270         [iOS] Do not handle key events that are key commands
1271         https://bugs.webkit.org/show_bug.cgi?id=191608
1272         <rdar://problem/46046013>
1273
1274         Reviewed by Ryosuke Niwa.
1275
1276         A key down event may be associated with a key command. If it is then we want to execute the
1277         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1278         event as a key command to find out.
1279
1280         * WebView/WebHTMLView.mm:
1281         (-[WebHTMLView _handleEditingKeyEvent:]):
1282
1283 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1284
1285         Add a runtime feature flag for LayoutFormattingContext.
1286         https://bugs.webkit.org/show_bug.cgi?id=192280
1287
1288         Reviewed by Simon Fraser.
1289
1290         * Configurations/FeatureDefines.xcconfig:
1291
1292 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1293
1294         Move URL from WebCore to WTF
1295         https://bugs.webkit.org/show_bug.cgi?id=190234
1296
1297         Reviewed by Keith Miller.
1298
1299         * DOM/DOMAttr.mm:
1300         * DOM/DOMBlob.mm:
1301         * DOM/DOMCSSCharsetRule.mm:
1302         * DOM/DOMCSSImportRule.mm:
1303         * DOM/DOMCSSMediaRule.mm:
1304         * DOM/DOMCSSPageRule.mm:
1305         * DOM/DOMCSSPrimitiveValue.mm:
1306         * DOM/DOMCSSRule.mm:
1307         * DOM/DOMCSSStyleDeclaration.mm:
1308         * DOM/DOMCSSStyleRule.mm:
1309         * DOM/DOMCSSStyleSheet.mm:
1310         * DOM/DOMCSSValue.mm:
1311         * DOM/DOMCharacterData.mm:
1312         * DOM/DOMCounter.mm:
1313         * DOM/DOMDocument.mm:
1314         * DOM/DOMDocumentFragment.mm:
1315         * DOM/DOMDocumentType.mm:
1316         * DOM/DOMEvent.mm:
1317         * DOM/DOMFile.mm:
1318         * DOM/DOMHTMLAnchorElement.mm:
1319         * DOM/DOMHTMLAppletElement.mm:
1320         * DOM/DOMHTMLAreaElement.mm:
1321         * DOM/DOMHTMLBRElement.mm:
1322         * DOM/DOMHTMLBaseElement.mm:
1323         * DOM/DOMHTMLBaseFontElement.mm:
1324         * DOM/DOMHTMLBodyElement.mm:
1325         * DOM/DOMHTMLButtonElement.mm:
1326         * DOM/DOMHTMLCanvasElement.mm:
1327         * DOM/DOMHTMLCollection.mm:
1328         * DOM/DOMHTMLDivElement.mm:
1329         * DOM/DOMHTMLDocument.mm:
1330         * DOM/DOMHTMLElement.mm:
1331         * DOM/DOMHTMLEmbedElement.mm:
1332         * DOM/DOMHTMLFieldSetElement.mm:
1333         * DOM/DOMHTMLFontElement.mm:
1334         * DOM/DOMHTMLFormElement.mm:
1335         * DOM/DOMHTMLFrameElement.mm:
1336         * DOM/DOMHTMLFrameSetElement.mm:
1337         * DOM/DOMHTMLHRElement.mm:
1338         * DOM/DOMHTMLHeadElement.mm:
1339         * DOM/DOMHTMLHeadingElement.mm:
1340         * DOM/DOMHTMLHtmlElement.mm:
1341         * DOM/DOMHTMLIFrameElement.mm:
1342         * DOM/DOMHTMLImageElement.mm:
1343         * DOM/DOMHTMLInputElement.mm:
1344         * DOM/DOMHTMLLIElement.mm:
1345         * DOM/DOMHTMLLabelElement.mm:
1346         * DOM/DOMHTMLLegendElement.mm:
1347         * DOM/DOMHTMLLinkElement.mm:
1348         * DOM/DOMHTMLMapElement.mm:
1349         * DOM/DOMHTMLMarqueeElement.mm:
1350         * DOM/DOMHTMLMediaElement.mm:
1351         * DOM/DOMHTMLMetaElement.mm:
1352         * DOM/DOMHTMLModElement.mm:
1353         * DOM/DOMHTMLOListElement.mm:
1354         * DOM/DOMHTMLObjectElement.mm:
1355         * DOM/DOMHTMLOptGroupElement.mm:
1356         * DOM/DOMHTMLOptionElement.mm:
1357         * DOM/DOMHTMLOptionsCollection.mm:
1358         * DOM/DOMHTMLParagraphElement.mm:
1359         * DOM/DOMHTMLParamElement.mm:
1360         * DOM/DOMHTMLQuoteElement.mm:
1361         * DOM/DOMHTMLScriptElement.mm:
1362         * DOM/DOMHTMLSelectElement.mm:
1363         * DOM/DOMHTMLStyleElement.mm:
1364         * DOM/DOMHTMLTableCaptionElement.mm:
1365         * DOM/DOMHTMLTableCellElement.mm:
1366         * DOM/DOMHTMLTableColElement.mm:
1367         * DOM/DOMHTMLTableElement.mm:
1368         * DOM/DOMHTMLTableRowElement.mm:
1369         * DOM/DOMHTMLTableSectionElement.mm:
1370         * DOM/DOMHTMLTitleElement.mm:
1371         * DOM/DOMHTMLUListElement.mm:
1372         * DOM/DOMHTMLVideoElement.mm:
1373         * DOM/DOMKeyboardEvent.mm:
1374         * DOM/DOMMediaList.mm:
1375         * DOM/DOMMouseEvent.mm:
1376         * DOM/DOMMutationEvent.mm:
1377         * DOM/DOMNamedNodeMap.mm:
1378         * DOM/DOMProcessingInstruction.mm:
1379         * DOM/DOMRange.mm:
1380         * DOM/DOMStyleSheet.mm:
1381         * DOM/DOMText.mm:
1382         * DOM/DOMTextEvent.mm:
1383         * DOM/DOMTokenList.mm:
1384         * DOM/DOMUIEvent.mm:
1385         * DOM/DOMXPathResult.mm:
1386         * History/WebHistoryItem.mm:
1387         * Misc/WebNSURLExtras.mm:
1388         (-[NSURL _web_userVisibleString]):
1389         (-[NSURL _web_URLByRemovingUserInfo]):
1390         (-[NSURL _web_dataForURLComponentType:]):
1391         (-[NSURL _web_schemeData]):
1392         (-[NSURL _web_hostData]):
1393         * Misc/WebUserContentURLPattern.mm:
1394         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1395         * Plugins/WebNetscapePluginStream.h:
1396         (WebNetscapePluginStream::setRequestURL):
1397         * WebCoreSupport/WebChromeClient.h:
1398         * WebCoreSupport/WebChromeClient.mm:
1399         (WebChromeClient::signedPublicKeyAndChallengeString const):
1400         * WebCoreSupport/WebContextMenuClient.h:
1401         * WebCoreSupport/WebContextMenuClient.mm:
1402         * WebCoreSupport/WebDragClient.h:
1403         * WebCoreSupport/WebFrameLoaderClient.h:
1404         * WebCoreSupport/WebFrameLoaderClient.mm:
1405         (WebFrameLoaderClient::updateGlobalHistory):
1406         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1407         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1408         (WebPaymentCoordinatorClient::showPaymentUI):
1409         * WebCoreSupport/WebPlatformStrategies.h:
1410         * WebCoreSupport/WebPlatformStrategies.mm:
1411         (WebPlatformStrategies::readURLFromPasteboard):
1412         * WebCoreSupport/WebPluginInfoProvider.h:
1413         * WebCoreSupport/WebPluginInfoProvider.mm:
1414         (WebPluginInfoProvider::webVisiblePluginInfo):
1415         * WebCoreSupport/WebSecurityOrigin.mm:
1416         * WebCoreSupport/WebVisitedLinkStore.h:
1417         * WebView/WebDataSource.mm:
1418         * WebView/WebFrame.mm:
1419         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1420         * WebView/WebImmediateActionController.mm:
1421         (-[WebImmediateActionController _defaultAnimationController]):
1422         * WebView/WebPDFView.mm:
1423         * WebView/WebScriptDebugger.mm:
1424         * WebView/WebViewInternal.h:
1425
1426 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1427
1428         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1429         https://bugs.webkit.org/show_bug.cgi?id=192197
1430
1431         Reviewed by Jiewen Tan.
1432
1433         * Configurations/FeatureDefines.xcconfig:
1434         * WebCoreSupport/WebChromeClient.h:
1435         * WebCoreSupport/WebChromeClient.mm:
1436
1437 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1438
1439         Remove dead code from an earlier attempt at implementing safe browsing
1440         https://bugs.webkit.org/show_bug.cgi?id=192067
1441
1442         Reviewed by Chris Dumez.
1443
1444         * WebCoreSupport/WebFrameLoaderClient.h:
1445         * WebCoreSupport/WebFrameLoaderClient.mm:
1446         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1447
1448 2018-11-27  Mark Lam  <mark.lam@apple.com>
1449
1450         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1451         https://bugs.webkit.org/show_bug.cgi?id=192055
1452         <rdar://problem/46288783>
1453
1454         Reviewed by Saam Barati.
1455
1456         * Configurations/FeatureDefines.xcconfig:
1457
1458 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1459
1460         Make it possible to insert editable images with a gesture
1461         https://bugs.webkit.org/show_bug.cgi?id=191937
1462
1463         Reviewed by Wenson Hsieh.
1464
1465         * WebCoreSupport/WebEditorClient.mm:
1466         (undoNameForEditAction):
1467         Add a undo name.
1468
1469 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1470
1471         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1472         https://bugs.webkit.org/show_bug.cgi?id=191945
1473
1474         Reviewed by Anders Carlsson.
1475
1476         * WebCoreSupport/WebEditorClient.mm:
1477         (undoNameForEditAction):
1478
1479 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1480
1481         Enable drag and drop support for iOSMac
1482         https://bugs.webkit.org/show_bug.cgi?id=191818
1483         <rdar://problem/43907454>
1484
1485         Reviewed by Dean Jackson.
1486
1487         * Configurations/FeatureDefines.xcconfig:
1488
1489 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1490
1491         Address post-review feedback after r238438
1492         https://bugs.webkit.org/show_bug.cgi?id=191913
1493
1494         Reviewed by Ryosuke Niwa.
1495
1496         * WebView/WebFrame.mm:
1497         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1498         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1499         * WebView/WebView.mm:
1500         (-[WebView setSelectedDOMRange:affinity:]):
1501
1502 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1503
1504         Web Inspector: "Reload Web Inspector" button no longer partially works
1505         https://bugs.webkit.org/show_bug.cgi?id=191773
1506         <rdar://problem/46139932>
1507
1508         Reviewed by Devin Rousso.
1509
1510         * WebCoreSupport/WebInspectorClient.h:
1511         * WebCoreSupport/WebInspectorClient.mm:
1512         (WebInspectorFrontendClient::reopen):
1513
1514 2018-11-17  Devin Rousso  <drousso@apple.com>
1515
1516         Web Inspector: Network: add button to show system certificate dialog
1517         https://bugs.webkit.org/show_bug.cgi?id=191458
1518         <rdar://problem/45977019>
1519
1520         Reviewed by Joseph Pecoraro.
1521
1522         * WebCoreSupport/WebInspectorClient.h:
1523         * WebCoreSupport/WebInspectorClient.mm:
1524         (WebInspectorFrontendClient::showCertificate): Added.
1525
1526         * Configurations/WebKitLegacy.xcconfig:
1527
1528 2018-11-15  Truitt Savell  <tsavell@apple.com>
1529
1530         Unreviewed, rolling out r238244.
1531
1532         Caused High Sierra test runs to fail early with 50 crashes and
1533         casued 25 API failures.
1534
1535         Reverted changeset:
1536
1537         "[css-logical] Implement flow-relative margin, padding and
1538         border shorthands"
1539         https://bugs.webkit.org/show_bug.cgi?id=188697
1540         https://trac.webkit.org/changeset/238244
1541
1542 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1543
1544         [css-logical] Implement flow-relative margin, padding and border shorthands
1545         https://bugs.webkit.org/show_bug.cgi?id=188697
1546
1547         Reviewed by Simon Fraser and Antti Koivisto.
1548
1549         Add CSSLogicalEnabled runtime flag.
1550
1551         * WebView/WebPreferenceKeysPrivate.h:
1552         * WebView/WebPreferences.mm:
1553         (+[WebPreferences initialize]):
1554         (-[WebPreferences cssLogicalEnabled]):
1555         (-[WebPreferences setCSSLogicalEnabled:]):
1556         * WebView/WebPreferencesPrivate.h:
1557         * WebView/WebView.mm:
1558         (-[WebView _preferencesChanged:]):
1559
1560 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1561
1562         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1563         https://bugs.webkit.org/show_bug.cgi?id=191612
1564
1565         Reviewed by Matt Baker.
1566
1567         * WebCoreSupport/WebInspectorClient.mm:
1568         (-[WebInspectorWindowController destroyInspectorView]):
1569
1570 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1571
1572         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1573         https://bugs.webkit.org/show_bug.cgi?id=191494
1574         <rdar://problem/45469854>
1575
1576         Reviewed by Devin Rousso.
1577
1578         * WebCoreSupport/WebInspectorClient.h:
1579         WebKitLegacy will still have remote inspection of the Page directly.
1580
1581 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1582
1583         Make compositing updates incremental
1584         https://bugs.webkit.org/show_bug.cgi?id=90342
1585
1586         Reviewed by Antti Koivisto.
1587
1588         Fix spelling error.
1589
1590         * WebView/WebView.mm:
1591         (-[WebView _setMediaLayer:forPluginView:]):
1592
1593 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1594
1595         Implement a new edit command to change the enclosing list type
1596         https://bugs.webkit.org/show_bug.cgi?id=191487
1597         <rdar://problem/45955922>
1598
1599         Reviewed by Ryosuke Niwa.
1600
1601         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1602
1603         * WebCoreSupport/WebEditorClient.mm:
1604         (undoNameForEditAction):
1605
1606 2018-11-11  Daniel Bates  <dabates@apple.com>
1607
1608         [iOS] Draw caps lock indicator in password fields
1609         https://bugs.webkit.org/show_bug.cgi?id=190565
1610         <rdar://problem/45262343>
1611
1612         Reviewed by Dean Jackson.
1613
1614         Update the caps lock state when a hardware keyboard is attached or detached.
1615
1616         * WebView/WebHTMLView.mm:
1617         (hardwareKeyboardAvailabilityChangedCallback): Added.
1618         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1619         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1620
1621 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1622
1623         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1624         https://bugs.webkit.org/show_bug.cgi?id=191492
1625
1626         Reviewed by Alex Christensen.
1627
1628         * Carbon/HIWebView.mm:
1629         * Misc/WebNSFileManagerExtras.mm:
1630         * Misc/WebNSURLExtras.mm:
1631         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1632         * Plugins/WebBasePluginPackage.mm:
1633         * Plugins/WebPluginContainerCheck.mm:
1634         * WebCoreSupport/WebCachedFramePlatformData.h:
1635         * WebCoreSupport/WebDeviceOrientationClient.mm:
1636         * WebView/WebDelegateImplementationCaching.mm:
1637         * WebView/WebHTMLView.mm:
1638         * WebView/WebPDFRepresentation.mm:
1639         * WebView/WebPolicyDelegate.mm:
1640         * WebView/WebView.mm:
1641
1642 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1643
1644         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1645         https://bugs.webkit.org/show_bug.cgi?id=191492
1646
1647         Reviewed by Alex Christensen.
1648
1649         * Carbon/HIWebView.mm:
1650         (UpdateCommandStatus):
1651         * Misc/WebNSFileManagerExtras.mm:
1652         * Misc/WebNSURLExtras.mm:
1653         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1654         * Plugins/WebBasePluginPackage.mm:
1655         * Plugins/WebPluginContainerCheck.mm:
1656         (-[WebPluginContainerCheck _continueWithPolicy:]):
1657         * WebCoreSupport/WebCachedFramePlatformData.h:
1658         (WebCachedFramePlatformData::clear):
1659         * WebCoreSupport/WebDeviceOrientationClient.mm:
1660         (WebDeviceOrientationClient::getProvider const):
1661         * WebView/WebDelegateImplementationCaching.mm:
1662         (CallDelegate):
1663         (CallDelegateReturningBoolean):
1664         (CallResourceLoadDelegateReturningBoolean):
1665         (CallFormDelegate):
1666         (CallFormDelegateReturningBoolean):
1667         * WebView/WebHTMLView.mm:
1668         * WebView/WebPDFRepresentation.mm:
1669         * WebView/WebPolicyDelegate.mm:
1670         (-[WebPolicyDecisionListener _usePolicy:]):
1671         * WebView/WebView.mm:
1672
1673 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1674
1675         Unreviewed, rolling out r238047.
1676
1677         Introduced layout test failures on iOS simulator.
1678
1679         Reverted changeset:
1680
1681         "[iOS] Draw caps lock indicator in password fields"
1682         https://bugs.webkit.org/show_bug.cgi?id=190565
1683         https://trac.webkit.org/changeset/238047
1684
1685 2018-11-09  Antti Koivisto  <antti@apple.com>
1686
1687         Use OptionSet for layout milestones
1688         https://bugs.webkit.org/show_bug.cgi?id=191470
1689
1690         Reviewed by Dean Jackson.
1691
1692         * WebCoreSupport/WebFrameLoaderClient.h:
1693         * WebCoreSupport/WebFrameLoaderClient.mm:
1694         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1695         * WebView/WebView.mm:
1696         (coreLayoutMilestones):
1697         (kitLayoutMilestones):
1698         (-[WebView _cacheFrameLoadDelegateImplementations]):
1699         * WebView/WebViewInternal.h:
1700
1701 2018-11-09  Daniel Bates  <dabates@apple.com>
1702
1703         [iOS] Draw caps lock indicator in password fields
1704         https://bugs.webkit.org/show_bug.cgi?id=190565
1705         <rdar://problem/45262343>
1706
1707         Reviewed by Dean Jackson.
1708
1709         Update the caps lock state when a hardware keyboard is attached or detached.
1710
1711         * WebView/WebHTMLView.mm:
1712         (hardwareKeyboardAvailabilityChangedCallback): Added.
1713         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1714         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1715
1716 2018-11-09  Daniel Bates  <dabates@apple.com>
1717
1718         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1719         action when forward delete is pressed outside a text field
1720         https://bugs.webkit.org/show_bug.cgi?id=190566
1721         <rdar://problem/45262367>
1722
1723         Reviewed by Wenson Hsieh.
1724
1725         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1726         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1727         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1728
1729         * WebView/WebHTMLView.mm:
1730         (-[WebHTMLView _handleEditingKeyEvent:]):
1731
1732 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1733
1734         Adopt Reveal Framework to replace Lookup
1735         https://bugs.webkit.org/show_bug.cgi?id=191097
1736         <rdar://problem/45924508>
1737
1738         Reviewed by Tim Horton.
1739
1740         Pass in what it needed to clear the textIndicators. This is better than
1741         the current notification structure.
1742
1743         * WebView/WebView.mm:
1744         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1745         (-[WebView _prepareForDictionaryLookup]):
1746
1747 2018-11-06  Justin Fan  <justin_fan@apple.com>
1748
1749         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1750         https://bugs.webkit.org/show_bug.cgi?id=191291
1751
1752         Reviewed by Myles Maxfield.
1753
1754         Properly disable WEBGPU on all non-Metal platforms for now.
1755
1756         * Configurations/FeatureDefines.xcconfig:
1757
1758 2018-11-02  Daniel Bates  <dabates@apple.com>
1759
1760         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1761         https://bugs.webkit.org/show_bug.cgi?id=190487
1762
1763         Reviewed by Tim Horton.
1764
1765         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1766         allow the default handling.
1767
1768         * WebView/WebHTMLView.mm:
1769         (-[WebHTMLView _handleEditingKeyEvent:]):
1770
1771 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1772
1773         Add a storage limit for IndexedDB
1774         https://bugs.webkit.org/show_bug.cgi?id=190598
1775         <rdar://problem/44654715>
1776
1777         Reviewed by Chris Dumez.
1778
1779         * Storage/WebDatabaseManager.mm:
1780         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1781         * Storage/WebDatabaseManagerPrivate.h:
1782
1783 2018-10-31  Antti Koivisto  <antti@apple.com>
1784
1785         Remove LayerFlushScheduler
1786         https://bugs.webkit.org/show_bug.cgi?id=191103
1787
1788         Reviewed by Anders Carlsson.
1789
1790         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1791         all the virtual cruft.
1792
1793         * WebView/WebViewData.h:
1794         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1795         (): Deleted.
1796         * WebView/WebViewData.mm:
1797         (currentRunLoop):
1798         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1799         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1800         (WebViewLayerFlushScheduler::schedule):
1801         (WebViewLayerFlushScheduler::invalidate):
1802         (WebViewLayerFlushScheduler::layerFlushCallback):
1803
1804 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1805
1806         Enable InstallAPI for iOS unconditionally
1807         https://bugs.webkit.org/show_bug.cgi?id=191043
1808         rdar://problem/32728423
1809
1810         Reviewed by Dan Bernstein.
1811
1812         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1813         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1814         shouldn't be processed by InstallAPI.
1815         * MigrateHeaders.make: Removed an obsolete workaround.
1816         * Misc/NSURLDownloadSPI.h: Added.
1817         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1818
1819 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1820
1821         Clean up some obsolete MAX_ALLOWED macros
1822         https://bugs.webkit.org/show_bug.cgi?id=190916
1823
1824         Reviewed by Tim Horton.
1825
1826         * WebView/WebHTMLView.mm:
1827         (-[WebHTMLView pressureChangeWithEvent:]):
1828         * WebView/WebPDFView.h:
1829
1830 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1831
1832         Unreviewed, rolling out r237600 and r237604.
1833         https://bugs.webkit.org/show_bug.cgi?id=191086
1834
1835         Breaks internal iOS builds (Requested by ryanhadd_ on
1836         #webkit).
1837
1838         Reverted changesets:
1839
1840         "Enable InstallAPI for iOS unconditionally"
1841         https://bugs.webkit.org/show_bug.cgi?id=191043
1842         https://trac.webkit.org/changeset/237600
1843
1844         "Build fix attempt after enabling InstallAPI for iOS."
1845         https://bugs.webkit.org/show_bug.cgi?id=191043
1846         https://trac.webkit.org/changeset/237604
1847
1848 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1849
1850         Enable InstallAPI for iOS unconditionally
1851         https://bugs.webkit.org/show_bug.cgi?id=191043
1852         rdar://problem/32728423
1853
1854         Reviewed by Dan Bernstein.
1855
1856         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1857         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1858         shouldn't be processed by InstallAPI.
1859         * MigrateHeaders.make: Removed an obsolete workaround.
1860         * Misc/NSURLDownloadSPI.h: Added.
1861         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1862
1863 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1864
1865         Modernize WebKit nibs and lprojs for localization's sake
1866         https://bugs.webkit.org/show_bug.cgi?id=190911
1867         <rdar://problem/45349466>
1868
1869         Reviewed by Dan Bernstein.
1870
1871         * Misc/WebNSControlExtras.m:
1872         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1873         NSWindow and its contents are both in the same scale space these days; avoid
1874         double-applying the scale factor, or you can't see the prompt.
1875
1876         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1877         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1878         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1879         NIB->XIB
1880
1881 2018-10-25  Antoine Quint  <graouts@apple.com>
1882
1883         [Web Animations] Turn Web Animations CSS Integration off by default
1884         https://bugs.webkit.org/show_bug.cgi?id=190901
1885
1886         Reviewed by Dean Jackson.
1887
1888         * WebView/WebPreferences.mm:
1889         (+[WebPreferences initialize]):
1890
1891 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1892
1893         Clean up some obsolete macOS version guards
1894         https://bugs.webkit.org/show_bug.cgi?id=190887
1895
1896         Reviewed by Dan Bernstein.
1897
1898         * Misc/WebNSPasteboardExtras.mm:
1899         (+[NSPasteboard _web_dragTypesForURL]):
1900         * WebCoreSupport/PopupMenuMac.mm:
1901         (PopupMenuMac::show):
1902         * WebCoreSupport/WebEditorClient.h:
1903         * WebCoreSupport/WebEditorClient.mm:
1904         (WebEditorClient::respondToChangedSelection):
1905         * WebView/WebPDFView.mm:
1906         (-[WebPDFView _clipViewForPDFDocumentView]):
1907
1908 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1909
1910         Turn on Conic Gradients
1911         https://bugs.webkit.org/show_bug.cgi?id=190810
1912
1913         Reviewed by Tim Horton.
1914
1915         * Configurations/FeatureDefines.xcconfig:
1916
1917 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1918
1919         Cleanup: MIMETypeRegistry functions
1920         https://bugs.webkit.org/show_bug.cgi?id=190838
1921
1922         Reviewed by Simon Fraser.
1923
1924         * Misc/WebNSPasteboardExtras.mm:
1925         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1926         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1927         because they were identical.
1928
1929         * WebView/WebHTMLRepresentation.mm:
1930         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1931         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1932         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1933         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1934         * WebView/WebView.mm:
1935         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1936         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1937         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1938
1939 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1940
1941         Fix false positive leaks when using custom -init methods that don't start with -init
1942         <https://webkit.org/b/190818>
1943         <rdar://problem/45476042>
1944
1945         Reviewed by Dan Bernstein.
1946
1947         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1948         it is accessible by both categories.
1949         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1950         NSError (WebKitInternal) category.  Add attribute to make this
1951         behave like an -init method.
1952         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1953         NSError (WebKitInternal) category.  Modernize method.  Replace
1954         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1955
1956 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1957
1958         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1959         https://bugs.webkit.org/show_bug.cgi?id=190729
1960
1961         Reviewed by Tim Horton.
1962
1963         * DOM/DOM.mm:
1964         (-[DOMNode boundingBox]):
1965         * DOM/DOMElement.mm:
1966         * DOM/DOMHTML.mm:
1967         * DOM/DOMInternal.mm:
1968         * DOM/DOMUIKitExtensions.mm:
1969         * DOM/WebDOMOperations.mm:
1970         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1971         * DefaultDelegates/WebDefaultEditingDelegate.m:
1972         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1973         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1974         * DefaultDelegates/WebDefaultUIDelegate.h:
1975         * DefaultDelegates/WebDefaultUIDelegate.mm:
1976         (-[WebDefaultUIDelegate webViewClose:]):
1977         (-[WebDefaultUIDelegate webViewFocus:]):
1978         (-[WebDefaultUIDelegate webViewUnfocus:]):
1979         (-[WebDefaultUIDelegate webViewIsResizable:]):
1980         (-[WebDefaultUIDelegate webView:setResizable:]):
1981         (-[WebDefaultUIDelegate webView:setFrame:]):
1982         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1983         * History/BackForwardList.h:
1984         * History/BackForwardList.mm:
1985         * History/WebBackForwardList.mm:
1986         (+[WebBackForwardList initialize]):
1987         (bumperCarBackForwardHackNeeded):
1988         * History/WebHistory.mm:
1989         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1990         (-[WebHistory _sendNotification:entries:]):
1991         (-[WebHistory loadFromURL:error:]):
1992         (-[WebHistory saveToURL:error:]):
1993         * History/WebHistoryItem.mm:
1994         (WKNotifyHistoryItemChanged):
1995         (+[WebHistoryItem initialize]):
1996         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1997         * History/WebURLsWithTitles.m:
1998         * Misc/WebCache.mm:
1999         (+[WebCache initialize]):
2000         * Misc/WebDownload.mm:
2001         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2002         * Misc/WebElementDictionary.mm:
2003         (+[WebElementDictionary initialize]):
2004         (+[WebElementDictionary initializeLookupTable]):
2005         * Misc/WebIconDatabase.mm:
2006         * Misc/WebKitNSStringExtras.mm:
2007         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2008         * Misc/WebKitVersionChecks.h:
2009         * Misc/WebKitVersionChecks.mm:
2010         (WebKitLinkedOnOrAfter):
2011         (WebKitLinkTimeVersion):
2012         * Misc/WebLocalizableStrings.mm:
2013         * Misc/WebNSControlExtras.h:
2014         * Misc/WebNSControlExtras.m:
2015         * Misc/WebNSEventExtras.m:
2016         * Misc/WebNSFileManagerExtras.mm:
2017         * Misc/WebNSImageExtras.h:
2018         * Misc/WebNSImageExtras.m:
2019         * Misc/WebNSPasteboardExtras.mm:
2020         * Misc/WebNSPrintOperationExtras.h:
2021         * Misc/WebNSPrintOperationExtras.m:
2022         * Misc/WebNSViewExtras.m:
2023         * Misc/WebNSWindowExtras.m:
2024         * Panels/WebAuthenticationPanel.h:
2025         * Panels/WebAuthenticationPanel.m:
2026         * Panels/WebPanelAuthenticationHandler.m:
2027         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2028         (+[WebHostedNetscapePluginView initialize]):
2029         * Plugins/WebBasePluginPackage.h:
2030         * Plugins/WebBasePluginPackage.mm:
2031         * Plugins/WebJavaPlugIn.h:
2032         * Plugins/WebPluginContainerCheck.mm:
2033         * Plugins/WebPluginController.h:
2034         * Plugins/WebPluginController.mm:
2035         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2036         (-[WebPluginController addPlugin:]):
2037         (-[WebPluginController destroyPlugin:]):
2038         (-[WebPluginController destroyAllPlugins]):
2039         * Plugins/WebPluginDatabase.mm:
2040         (+[WebPluginDatabase _defaultPlugInPaths]):
2041         * Plugins/WebPluginPackage.mm:
2042         (-[WebPluginPackage initWithPath:]):
2043         * Storage/WebDatabaseManager.mm:
2044         (-[WebDatabaseManager deleteAllDatabases]):
2045         * Storage/WebDatabaseManagerClient.h:
2046         * Storage/WebDatabaseManagerClient.mm:
2047         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2048         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2049         * Storage/WebStorageManager.mm:
2050         (-[WebStorageManager deleteAllOrigins]):
2051         (WebKitInitializeStorageIfNecessary):
2052         * WebCoreSupport/WebAlternativeTextClient.h:
2053         * WebCoreSupport/WebApplicationCache.mm:
2054         (applicationCacheBundleIdentifier):
2055         * WebCoreSupport/WebChromeClient.h:
2056         * WebCoreSupport/WebChromeClient.mm:
2057         (WebChromeClient::setWindowRect):
2058         (WebChromeClient::windowRect):
2059         (WebChromeClient::takeFocus):
2060         (WebChromeClient::addMessageToConsole):
2061         (WebChromeClient::enableSuddenTermination):
2062         (WebChromeClient::disableSuddenTermination):
2063         (WebChromeClient::createPopupMenu const):
2064         (WebChromeClient::createSearchPopupMenu const):
2065         (WebChromeClient::shouldPaintEntireContents const):
2066         (WebChromeClient::supportsVideoFullscreen):
2067         (WebChromeClient::supportsFullScreenForElement):
2068         (WebChromeClient::enterFullScreenForElement):
2069         (WebChromeClient::exitFullScreenForElement):
2070         * WebCoreSupport/WebContextMenuClient.mm:
2071         * WebCoreSupport/WebDragClient.mm:
2072         * WebCoreSupport/WebEditorClient.h:
2073         * WebCoreSupport/WebEditorClient.mm:
2074         (+[WebUndoStep initialize]):
2075         (updateFontPanel):
2076         (WebEditorClient::didBeginEditing):
2077         (WebEditorClient::respondToChangedContents):
2078         (WebEditorClient::respondToChangedSelection):
2079         (WebEditorClient::canceledComposition):
2080         (WebEditorClient::didEndEditing):
2081         (WebEditorClient::didWriteSelectionToPasteboard):
2082         (attributesForAttributedStringConversion):
2083         (WebEditorClient::setInsertionPasteboard):
2084         (WebEditorClient::registerUndoOrRedoStep):
2085         (WebEditorClient::handleKeyboardEvent):
2086         (WebEditorClient::handleInputMethodKeydown):
2087         (WebEditorClient::textDidChangeInTextField):
2088         (WebEditorClient::requestCheckingOfString):
2089         * WebCoreSupport/WebFrameLoaderClient.h:
2090         * WebCoreSupport/WebFrameLoaderClient.mm:
2091         (WebFrameLoaderClient::detachedFromParent2):
2092         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2093         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2094         (WebFrameLoaderClient::dispatchWillSendRequest):
2095         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2096         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2097         (WebFrameLoaderClient::willCacheResponse const):
2098         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2099         (WebFrameLoaderClient::dispatchDidFinishLoading):
2100         (WebFrameLoaderClient::dispatchDidFailLoading):
2101         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2102         (WebFrameLoaderClient::dispatchWillClose):
2103         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2104         (WebFrameLoaderClient::dispatchDidCommitLoad):
2105         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2106         (WebFrameLoaderClient::dispatchDidFailLoad):
2107         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2108         (WebFrameLoaderClient::dispatchDidFinishLoad):
2109         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2110         (WebFrameLoaderClient::willChangeTitle):
2111         (WebFrameLoaderClient::didChangeTitle):
2112         (WebFrameLoaderClient::didReplaceMultipartContent):
2113         (WebFrameLoaderClient::updateGlobalHistory):
2114         (WebFrameLoaderClient::saveViewStateToItem):
2115         (WebFrameLoaderClient::restoreViewState):
2116         (WebFrameLoaderClient::provisionalLoadStarted):
2117         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2118         (WebFrameLoaderClient::setTitle):
2119         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2120         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2121         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2122         (WebFrameLoaderClient::didRestoreFromPageCache):
2123         (WebFrameLoaderClient::actionDictionary const):
2124         (WebFrameLoaderClient::createPlugin):
2125         (WebFrameLoaderClient::getLoadDecisionForIcons):
2126         (WebFrameLoaderClient::finishedLoadingIcon):
2127         (+[WebFramePolicyListener initialize]):
2128         * WebCoreSupport/WebFrameNetworkingContext.mm:
2129         * WebCoreSupport/WebGeolocationClient.h:
2130         * WebCoreSupport/WebGeolocationClient.mm:
2131         (WebGeolocationClient::requestPermission):
2132         * WebCoreSupport/WebInspectorClient.h:
2133         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2134         * WebCoreSupport/WebNotificationClient.mm:
2135         * WebCoreSupport/WebOpenPanelResultListener.mm:
2136         * WebCoreSupport/WebPlatformStrategies.h:
2137         * WebCoreSupport/WebPlatformStrategies.mm:
2138         * WebCoreSupport/WebProgressTrackerClient.h:
2139         * WebCoreSupport/WebProgressTrackerClient.mm:
2140         (WebProgressTrackerClient::progressStarted):
2141         (WebProgressTrackerClient::progressEstimateChanged):
2142         (WebProgressTrackerClient::progressFinished):
2143         * WebCoreSupport/WebSecurityOrigin.mm:
2144         * WebInspector/WebNodeHighlight.h:
2145         * WebInspector/WebNodeHighlight.mm:
2146         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2147         (-[WebNodeHighlight dealloc]):
2148         (-[WebNodeHighlight attach]):
2149         * WebInspector/WebNodeHighlightView.h:
2150         * WebInspector/WebNodeHighlightView.mm:
2151         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2152         (-[WebNodeHighlightView dealloc]):
2153         * WebInspector/WebNodeHighlighter.mm:
2154         (-[WebNodeHighlighter highlight]):
2155         * WebView/WebArchive.mm:
2156         (+[WebArchivePrivate initialize]):
2157         * WebView/WebClipView.h:
2158         * WebView/WebDataSource.mm:
2159         (WebDataSourcePrivate::WebDataSourcePrivate):
2160         (+[WebDataSource initialize]):
2161         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2162         (-[WebDataSource _makeRepresentation]):
2163         * WebView/WebDelegateImplementationCaching.h:
2164         * WebView/WebDelegateImplementationCaching.mm:
2165         (CallDelegate):
2166         (CallDelegateReturningFloat):
2167         (CallDelegateReturningBoolean):
2168         (CallUIDelegate):
2169         (CallUIDelegateReturningFloat):
2170         (CallUIDelegateReturningBoolean):
2171         (CallFrameLoadDelegate):
2172         (CallFrameLoadDelegateReturningBoolean):
2173         (CallResourceLoadDelegate):
2174         (CallScriptDebugDelegate):
2175         (CallFormDelegate):
2176         (CallFormDelegateReturningBoolean):
2177         * WebView/WebDeviceOrientation.mm:
2178         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2179         * WebView/WebDocumentInternal.h:
2180         * WebView/WebDocumentLoaderMac.mm:
2181         (needsDataLoadWorkaround):
2182         * WebView/WebDynamicScrollBarsViewInternal.h:
2183         * WebView/WebFormDelegate.m:
2184         * WebView/WebFrame.mm:
2185         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2186         (-[WebFrame _unmarkAllMisspellings]):
2187         (-[WebFrame _paintBehaviorForDestinationContext:]):
2188         (-[WebFrame _drawRect:contentsOnly:]):
2189         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2190         (-[WebFrame _scrollDOMRangeToVisible:]):
2191         (-[WebFrame _bodyBackgroundColor]):
2192         (-[WebFrame accessibilityRoot]):
2193         (needsMicrosoftMessengerDOMDocumentWorkaround):
2194         * WebView/WebFrameInternal.h:
2195         * WebView/WebFrameView.mm:
2196         (-[WebFrameView _setDocumentView:]):
2197         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2198         (-[WebFrameView _viewClassForMIMEType:]):
2199         (-[WebFrameView initWithFrame:]):
2200         (-[WebFrameView drawRect:]):
2201         (-[WebFrameView _firstResponderIsFormControl]):
2202         (-[WebFrameView keyDown:keyDown:]):
2203         (-[WebFrameView _isScrollable]):
2204         * WebView/WebFullScreenController.h:
2205         * WebView/WebFullScreenController.mm:
2206         * WebView/WebHTMLRepresentation.mm:
2207         * WebView/WebHTMLView.mm:
2208         (-[WebHTMLView hitTest:]):
2209         (-[WebHTMLView initWithFrame:]):
2210         (-[WebHTMLView dealloc]):
2211         (-[WebHTMLView addSubview:]):
2212         (-[WebHTMLView mouseDown:]):
2213         (-[WebHTMLView mouseUp:]):
2214         (-[WebHTMLView resignFirstResponder]):
2215         (-[WebHTMLView accessibilityHitTest:]):
2216         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2217         * WebView/WebHTMLViewInternal.h:
2218         * WebView/WebIndicateLayer.h:
2219         * WebView/WebIndicateLayer.mm:
2220         * WebView/WebMediaPlaybackTargetPicker.h:
2221         * WebView/WebMediaPlaybackTargetPicker.mm:
2222         * WebView/WebPDFDocumentExtras.h:
2223         * WebView/WebPDFDocumentExtras.mm:
2224         * WebView/WebPDFRepresentation.h:
2225         * WebView/WebPDFRepresentation.mm:
2226         * WebView/WebPDFView.h:
2227         * WebView/WebPreferences.mm:
2228         (cacheModelForMainBundle):
2229         (WebPreferencesPrivate::WebPreferencesPrivate):
2230         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2231         (-[WebPreferences encodeWithCoder:]):
2232         (+[WebPreferences standardPreferences]):
2233         (+[WebPreferences initialize]):
2234         (-[WebPreferences _valueForKey:]):
2235         (-[WebPreferences _setStringValue:forKey:]):
2236         (-[WebPreferences _setIntegerValue:forKey:]):
2237         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2238         (-[WebPreferences _setFloatValue:forKey:]):
2239         (-[WebPreferences _setBoolValue:forKey:]):
2240         (-[WebPreferences _setLongLongValue:forKey:]):
2241         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2242         (-[WebPreferences _postCacheModelChangedNotification]):
2243         (-[WebPreferences _postPreferencesChangedNotification]):
2244         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2245         (-[WebPreferences setStorageBlockingPolicy:]):
2246         * WebView/WebResource.mm:
2247         (+[WebResourcePrivate initialize]):
2248         * WebView/WebTextCompletionController.h:
2249         * WebView/WebTextIterator.mm:
2250         (+[WebTextIteratorPrivate initialize]):
2251         * WebView/WebView.mm:
2252         (shouldEnableLoadDeferring):
2253         (shouldRestrictWindowFocus):
2254         (shouldRespectPriorityInCSSAttributeSetters):
2255         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2256         (shouldAllowPictureInPictureMediaPlayback):
2257         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2258         (shouldAllowWindowOpenWithoutUserGesture):
2259         (shouldConvertInvalidURLsToBlank):
2260         (shouldRequireUserGestureToLoadVideo):
2261         (-[WebView _commonInitializationWithFrameName:groupName:]):
2262         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2263         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2264         (-[WebView _closePluginDatabases]):
2265         (-[WebView _closeWithFastTeardown]):
2266         (-[WebView _close]):
2267         (+[WebView _MIMETypeForFile:]):
2268         (-[WebView setShowingInspectorIndication:]):
2269         (-[WebView _setFormDelegate:]):
2270         (-[WebView _needsPreHTML5ParserQuirks]):
2271         (-[WebView _preferencesChangedNotification:]):
2272         (-[WebView _preferencesChanged:]):
2273         (-[WebView _cacheResourceLoadDelegateImplementations]):
2274         (-[WebView _cacheFrameLoadDelegateImplementations]):
2275         (-[WebView _policyDelegateForwarder]):
2276         (-[WebView _UIDelegateForwarder]):
2277         (-[WebView _editingDelegateForwarder]):
2278         (-[WebView _updateActiveState]):
2279         (-[_WebSafeForwarder forwardInvocation:]):
2280         (+[WebView initialize]):
2281         (-[WebView _pluginForMIMEType:]):
2282         (-[WebView _pluginForExtension:]):
2283         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2284         (+[WebView canShowMIMETypeAsHTML:]):
2285         (-[WebView _initWithArguments:]):
2286         (-[WebView initWithFrame:frameName:groupName:]):
2287         (-[WebView dealloc]):
2288         (-[WebView close]):
2289         (-[WebView viewDidMoveToWindow]):
2290         (-[WebView setUIDelegate:]):
2291         (-[WebView setResourceLoadDelegate:]):
2292         (-[WebView setPolicyDelegate:]):
2293         (-[WebView setFrameLoadDelegate:]):
2294         (-[WebView goBack]):
2295         (-[WebView goForward]):
2296         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2297         (-[WebView setHostWindow:]):
2298         (-[WebView becomeFirstResponder]):
2299         (+[WebView _cacheModelChangedNotification:]):
2300         (-[WebView _frameViewAtWindowPoint:]):
2301         (+[WebView _preflightSpellCheckerNow:]):
2302         (+[WebView _preflightSpellChecker]):
2303         (-[WebView canGoBack]):
2304         (-[WebView canGoForward]):
2305         (-[WebView stopLoading:]):
2306         (-[WebView reload:]):
2307         (-[WebView setMainFrameDocumentReady:]):
2308         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2309         (-[WebView setContinuousSpellCheckingEnabled:]):
2310         (-[WebView undoManager]):
2311         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2312         (-[WebView isAutomaticLinkDetectionEnabled]):
2313         (-[WebView isAutomaticDashSubstitutionEnabled]):
2314         (-[WebView isAutomaticTextReplacementEnabled]):
2315         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2316         (+[WebView _setCacheModel:]):
2317         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2318         (-[WebView _keyboardUIMode]):
2319         (LayerFlushController::flushLayers):
2320         (-[WebView _scheduleCompositingLayerFlush]):
2321         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2322         (-[WebView fullScreenPlaceholderView]):
2323         (WebInstallMemoryPressureHandler):
2324         * WebView/WebViewData.h:
2325         * WebView/WebViewData.mm:
2326         (+[WebViewPrivate initialize]):
2327         (-[WebViewPrivate init]):
2328         (-[WebViewPrivate dealloc]):
2329         * WebView/WebViewInternal.h:
2330
2331 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2332
2333         Clean up FrameLoader two-state enums
2334         https://bugs.webkit.org/show_bug.cgi?id=190731
2335
2336         Reviewed by Chris Dumez.
2337
2338         * WebCoreSupport/WebFrameLoaderClient.h:
2339         * WebCoreSupport/WebFrameLoaderClient.mm:
2340         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2341
2342 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2343
2344         Unreviewed, rolling out r237137.
2345
2346         SPI is actually used
2347
2348         Reverted changeset:
2349
2350         "Remove unused WebFrame._loadType"
2351         https://bugs.webkit.org/show_bug.cgi?id=190583
2352         https://trac.webkit.org/changeset/237137
2353
2354 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2355
2356         Enable the datalist element by default on iOS and macOS
2357         https://bugs.webkit.org/show_bug.cgi?id=190594
2358         <rdar://problem/45281159>
2359
2360         Reviewed by Ryosuke Niwa and Tim Horton.
2361
2362         * Configurations/FeatureDefines.xcconfig:
2363
2364 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2365
2366         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2367         https://bugs.webkit.org/show_bug.cgi?id=190675
2368
2369         Reviewed by Chris Dumez.
2370
2371         * History/BackForwardList.h:
2372         * History/BackForwardList.mm:
2373         (BackForwardList::backItem):
2374         (BackForwardList::currentItem):
2375         (BackForwardList::forwardItem):
2376         (BackForwardList::backListCount const):
2377         (BackForwardList::forwardListCount const):
2378         (BackForwardList::itemAtIndex):
2379         * History/WebBackForwardList.mm:
2380         (-[WebBackForwardList backItem]):
2381         (-[WebBackForwardList currentItem]):
2382         (-[WebBackForwardList forwardItem]):
2383         (-[WebBackForwardList itemAtIndex:]):
2384
2385 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2386
2387         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2388         https://bugs.webkit.org/show_bug.cgi?id=190526
2389         rdar://problem/45230140
2390
2391         Reviewed by Dean Jackson.
2392
2393         * WebCoreSupport/WebEditorClient.mm:
2394         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2395
2396 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2397
2398         Implement feature flag and bindings for CSS Painting API
2399         https://bugs.webkit.org/show_bug.cgi?id=190237
2400
2401         Reviewed by Ryosuke Niwa.
2402
2403         * Configurations/FeatureDefines.xcconfig:
2404
2405 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2406
2407         Replace HistoryItem* with HistoryItem& where possible
2408         https://bugs.webkit.org/show_bug.cgi?id=190617
2409
2410         Reviewed by Chris Dumez.
2411
2412         * History/BackForwardList.h:
2413         * History/BackForwardList.mm:
2414         (BackForwardList::goToItem):
2415         * History/WebBackForwardList.mm:
2416         (-[WebBackForwardList goToItem:]):
2417         * History/WebHistoryItem.mm:
2418         (WKNotifyHistoryItemChanged):
2419         * History/WebHistoryItemInternal.h:
2420
2421 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2422
2423         Remove unused WebHistoryItem._transientPropertyForKey
2424         https://bugs.webkit.org/show_bug.cgi?id=190606
2425
2426         Reviewed by Chris Dumez.
2427
2428         * History/WebHistoryItem.mm:
2429         * History/WebHistoryItemPrivate.h:
2430
2431 2018-10-15  Justin Fan  <justin_fan@apple.com>
2432
2433         Add WebGPU 2018 feature flag and experimental feature flag
2434         https://bugs.webkit.org/show_bug.cgi?id=190509
2435
2436         Reviewed by Dean Jackson.
2437
2438         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2439         for the 2018 WebGPU prototype.
2440
2441         * Configurations/FeatureDefines.xcconfig:
2442         * WebView/WebPreferenceKeysPrivate.h:
2443         * WebView/WebPreferences.mm:
2444         (+[WebPreferences initialize]):
2445         (-[WebPreferences webGPUEnabled]):
2446         (-[WebPreferences setWebGPUEnabled:]):
2447         * WebView/WebPreferencesPrivate.h:
2448         * WebView/WebView.mm:
2449         (-[WebView _preferencesChanged:]):
2450
2451 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2452
2453         Fix iOS build after r237157
2454
2455         * WebView/WebView.mm:
2456         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2457
2458 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2459
2460         Modernize BackForwardClient.h
2461         https://bugs.webkit.org/show_bug.cgi?id=190610
2462
2463         Reviewed by Chris Dumez.
2464
2465         * History/BackForwardList.h:
2466         * History/BackForwardList.mm:
2467         (BackForwardList::backListCount const):
2468         (BackForwardList::forwardListCount const):
2469         (BackForwardList::backListCount): Deleted.
2470         (BackForwardList::forwardListCount): Deleted.
2471         * History/WebBackForwardList.mm:
2472         (-[WebBackForwardList init]):
2473         * WebCoreSupport/WebFrameLoaderClient.mm:
2474         (WebFrameLoaderClient::canCachePage const):
2475         * WebView/WebFrameView.mm:
2476         (-[WebFrameView keyDown:keyDown:]):
2477         * WebView/WebView.mm:
2478         (-[WebView _commonInitializationWithFrameName:groupName:]):
2479         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2480         (-[WebView _loadBackForwardListFromOtherView:]):
2481         (-[WebView initWithCoder:]):
2482         (-[WebView encodeWithCoder:]):
2483         (-[WebView backForwardList]):
2484         (-[WebView setMaintainsBackForwardList:]):
2485
2486 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2487
2488         Add support for prefers-color-scheme media query
2489         https://bugs.webkit.org/show_bug.cgi?id=190499
2490         rdar://problem/45212025
2491
2492         Reviewed by Dean Jackson.
2493
2494         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2495
2496 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2497
2498         Remove unused WebView._globalHistoryItem
2499         https://bugs.webkit.org/show_bug.cgi?id=190601
2500
2501         Reviewed by Chris Dumez.
2502
2503         * WebCoreSupport/WebFrameLoaderClient.h:
2504         * WebCoreSupport/WebFrameLoaderClient.mm:
2505         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2506         * WebView/WebView.mm:
2507         (-[WebView _globalHistoryItem]): Deleted.
2508         (-[WebView _setGlobalHistoryItem:]): Deleted.
2509         * WebView/WebViewData.h:
2510         * WebView/WebViewInternal.h:
2511         * WebView/WebViewPrivate.h:
2512
2513 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2514
2515         Remove unused parameters from FrameLoaderClient::createFrame
2516         https://bugs.webkit.org/show_bug.cgi?id=190587
2517
2518         Reviewed by Chris Dumez.
2519
2520         * WebCoreSupport/WebFrameLoaderClient.h:
2521         * WebCoreSupport/WebFrameLoaderClient.mm:
2522         (WebFrameLoaderClient::createFrame):
2523
2524 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2525
2526         Remove unused WebFrame._loadType
2527         https://bugs.webkit.org/show_bug.cgi?id=190583
2528
2529         Reviewed by Chris Dumez.
2530
2531         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2532
2533         * WebView/WebFrame.mm:
2534         (toWebFrameLoadType): Deleted.
2535         (-[WebFrame _loadType]): Deleted.
2536         * WebView/WebFramePrivate.h:
2537
2538 2018-10-15  Chris Dumez  <cdumez@apple.com>
2539
2540         Restrict browsing context lookup by name to frames that are related to one another
2541         https://bugs.webkit.org/show_bug.cgi?id=190475
2542
2543         Reviewed by Alex Christensen.
2544
2545         * WebView/WebFrame.mm:
2546         (-[WebFrame findFrameNamed:]):
2547
2548 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2549
2550         Remove InjectedBundle processing of back/forward lists
2551         https://bugs.webkit.org/show_bug.cgi?id=190459
2552
2553         Reviewed by Chris Dumez.
2554
2555         * WebCoreSupport/WebFrameLoaderClient.h:
2556         * WebCoreSupport/WebFrameLoaderClient.mm:
2557         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2558
2559 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2560
2561         [JSC] Remove Option::useAsyncIterator
2562         https://bugs.webkit.org/show_bug.cgi?id=190567
2563
2564         Reviewed by Saam Barati.
2565
2566         * Configurations/FeatureDefines.xcconfig:
2567
2568 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2569
2570         Allow encoding of small enum classes
2571         https://bugs.webkit.org/show_bug.cgi?id=190531
2572
2573         Reviewed by Tim Horton.
2574
2575         * WebCoreSupport/WebFrameLoaderClient.mm:
2576         (-[WebFramePolicyListener dealloc]):
2577
2578 2018-10-11  Keith Rollin  <krollin@apple.com>
2579
2580         CURRENT_ARCH should not be used in Run Script phase.
2581         https://bugs.webkit.org/show_bug.cgi?id=190407
2582         <rdar://problem/45133556>
2583
2584         Reviewed by Alexey Proskuryakov.
2585
2586         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2587         CURRENT_ARCH is not well-defined during this phase (and may even have
2588         the value "undefined") since this phase is run just once per build
2589         rather than once per supported architecture. Migrate away from
2590         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2591         performing an operation for each value, or by picking the first entry
2592         in ARCHS and using that as a representative value.
2593
2594         * Configurations/WebKitLegacy.xcconfig: When generating
2595         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2596         macosx platforms.
2597
2598         * MigrateHeaders.make:
2599         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2600         generate one for each architecture in ARCHS.
2601
2602 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2603
2604         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2605         https://bugs.webkit.org/show_bug.cgi?id=190429
2606
2607         Reviewed by Saam Barati.
2608
2609         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2610
2611         * WebView/WebPDFRepresentation.mm:
2612         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2613
2614 2018-10-08  Justin Fan  <justin_fan@apple.com>
2615
2616         WebGPU: Rename old WebGPU prototype to WebMetal
2617         https://bugs.webkit.org/show_bug.cgi?id=190325
2618         <rdar://problem/44990443>
2619
2620         Reviewed by Dean Jackson.
2621
2622         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2623
2624         * Configurations/FeatureDefines.xcconfig:
2625         * WebView/WebPreferenceKeysPrivate.h:
2626         * WebView/WebPreferences.mm:
2627         (+[WebPreferences initialize]):
2628         (-[WebPreferences webMetalEnabled]):
2629         (-[WebPreferences setWebMetalEnabled:]):
2630         (-[WebPreferences webGPUEnabled]): Deleted.
2631         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2632         * WebView/WebPreferencesPrivate.h:
2633         * WebView/WebView.mm:
2634         (-[WebView _preferencesChanged:]):
2635
2636 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2637
2638         Make <input type=color> a runtime enabled (on-by-default) feature
2639         https://bugs.webkit.org/show_bug.cgi?id=189162
2640
2641         Reviewed by Wenson Hsieh and Tim Horton.
2642
2643         * Configurations/FeatureDefines.xcconfig:
2644
2645 2018-10-07  Dan Bernstein  <mitz@apple.com>
2646
2647         Fixed building with the latest macOS SDK
2648
2649         * Plugins/WebNetscapePluginPackage.mm:
2650         (-[WebNetscapePluginPackage openResourceFile]):
2651         (-[WebNetscapePluginPackage closeResourceFile:]):
2652
2653 2018-10-04  Dan Bernstein  <mitz@apple.com>
2654
2655         More Carbon build-fixing.
2656
2657         * Carbon/CarbonWindowAdapter.mm:
2658         (-[CarbonWindowAdapter _destroyRealWindow:]):
2659         (-[CarbonWindowAdapter _growBoxRect]):
2660
2661 2018-10-04  Dan Bernstein  <mitz@apple.com>
2662
2663         Retried to fix 32-bit macOS builds after r236846.
2664
2665         * WebView/WebHTMLView.mm:
2666         (-[WebHTMLView setMarkedText:selectedRange:]):
2667
2668 2018-10-04  Dan Bernstein  <mitz@apple.com>
2669
2670         Retried to fix 32-bit macOS builds after r236846.
2671
2672         * Carbon/HIWebView.mm:
2673         (ActiveStateChanged):
2674
2675 2018-10-04  Dan Bernstein  <mitz@apple.com>
2676
2677         Tried to fix 32-bit macOS builds after r236846.
2678
2679         * Carbon/HIWebView.mm:
2680         (_NSSelectorForHICommand):
2681
2682 2018-10-04  Dan Bernstein  <mitz@apple.com>
2683
2684         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2685         https://bugs.webkit.org/show_bug.cgi?id=190250
2686
2687         Reviewed by Andy Estes.
2688
2689         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2690           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2691           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2692           an earlier line set it to YES.
2693
2694         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2695         changes below.
2696
2697         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2698           provides some missing method declarations.
2699
2700         * Misc/WebDownload.mm:
2701         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2702           a deprecated method.
2703
2704         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2705
2706         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2707           other code in the file uses a method from it.
2708
2709         * Plugins/WebBaseNetscapePluginView.mm:
2710         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2711           a deprecated method.
2712
2713         * Plugins/WebPluginController.mm:
2714         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2715           around use of a selector that may be present in some WebKit client.
2716
2717         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2718           method declarations.
2719
2720         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2721           from here.
2722
2723         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2724           missing method declarations.
2725
2726         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2727           from here.
2728
2729         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2730           call from here.
2731         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2732           an obsolete delegate method for binary compatibility.
2733         (pluginView): Ditto.
2734
2735         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2736           call from here.
2737
2738         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2739           WebDeviceOrientationProviderMock protocol.
2740
2741         * WebView/WebDeviceOrientationProviderMock.mm:
2742         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2743           main @implementation.
2744
2745         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2746           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2747
2748         * WebView/WebDynamicScrollBarsView.mm:
2749         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2750           of a deprecated method.
2751
2752         * WebView/WebHTMLView.mm:
2753         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2754           selector warning around action methods that are not declared anywhere in WebKit.
2755
2756         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2757           about implementing this deprecated method.
2758         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2759         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2760         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2761         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2762         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2763         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2764         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2765         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2766         (-[WebHTMLView doCommandBySelector:]): Ditto.
2767         (-[WebHTMLView insertText:]): Ditto.
2768
2769         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2770
2771         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2772
2773         * WebView/WebPDFView.h: Removed previewView ivar.
2774
2775         * WebView/WebPDFView.mm:
2776           Removed declaration of FileInternal category and merged its implementation with the main
2777           implementation.
2778         (-[WebPDFView dealloc]): Removed previewView ivar.
2779         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2780           exist in macOS versions we support.
2781         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2782         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2783           action methods internal to PDFKit.
2784         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2785         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2786
2787         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2788           call on macOS, even though in r86988 we started calling different methods on iOS.
2789
2790         * WebView/WebView.mm:
2791         - Imported headers that declare delegate methods that we call.
2792         - Removed declaration of WebFileInternal category and merged its implementation with the
2793           main implementation.
2794         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2795           category, which made them impossible to call from the main implementation. Moved those
2796           into the main implementation. One of those had to be declared in a class extension,
2797           because it is called from a method implemented in the WebPrivate category, and that
2798           category’s implementation appears first in the file.
2799
2800         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2801           around use of obsolete delegate method for binary compatibility.
2802
2803         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2804
2805 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2806
2807         Runtime flag and IDL for MediaRecorder
2808         https://bugs.webkit.org/show_bug.cgi?id=190018
2809
2810         Reviewed by Youenn Fablet and Chris Dumez.
2811
2812         * WebView/WebPreferenceKeysPrivate.h:
2813         * WebView/WebPreferences.mm:
2814         (+[WebPreferences initialize]):
2815         (-[WebPreferences mediaRecorderEnabled]):
2816         (-[WebPreferences setMediaRecorderEnabled:]):
2817         * WebView/WebPreferencesPrivate.h:
2818         * WebView/WebView.mm:
2819         (-[WebView _preferencesChanged:]):
2820
2821 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2822
2823         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2824         https://bugs.webkit.org/show_bug.cgi?id=190238
2825
2826         Reviewed by Antti Koivisto.
2827
2828         Enabled the feature by default.
2829
2830         * WebView/WebPreferences.mm:
2831         (+[WebPreferences initialize]):
2832
2833 2018-10-01  Dean Jackson  <dino@apple.com>
2834
2835         [macOS] Switching to discrete GPU should be done in the UI process
2836         https://bugs.webkit.org/show_bug.cgi?id=189361
2837         <rdar://problem/43949622>
2838
2839         Reviewed by Simon Fraser.
2840
2841         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2842         not support swapping to the discrete GPU in this configuration.
2843
2844         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2845         (WebKit::WebSwitchingGPUClient::singleton):
2846         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2847         * WebView/WebView.mm:
2848         (-[WebView _commonInitializationWithFrameName:groupName:]):
2849
2850 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2851
2852         Remove ParsedURLString
2853         https://bugs.webkit.org/show_bug.cgi?id=190154
2854
2855         Reviewed by Chris Dumez.
2856
2857         * WebView/WebScriptDebugger.mm:
2858         (toNSURL):
2859
2860 2018-10-01  Dean Jackson  <dino@apple.com>
2861
2862         Remove CSS Animation Triggers
2863         https://bugs.webkit.org/show_bug.cgi?id=190175
2864         <rdar://problem/44925626>
2865
2866         Reviewed by Simon Fraser.
2867
2868         * Configurations/FeatureDefines.xcconfig:
2869
2870 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2871
2872         Unreviewed, rolling out r236624 and r236671.
2873         https://bugs.webkit.org/show_bug.cgi?id=190207
2874
2875         The change in r236624 introduced crashes on the bots
2876         (Requested by ryanhaddad on #webkit).
2877
2878         Reverted changesets:
2879
2880         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2881         https://bugs.webkit.org/show_bug.cgi?id=188747
2882         https://trac.webkit.org/changeset/236624
2883
2884         "Unify implementation in VideoFullscreenInterfaceAVKit"
2885         https://bugs.webkit.org/show_bug.cgi?id=190091
2886         https://trac.webkit.org/changeset/236671
2887
2888 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2889
2890         URL should not use TextEncoding internally
2891         https://bugs.webkit.org/show_bug.cgi?id=190111
2892
2893         Reviewed by Andy Estes.
2894
2895         * Misc/WebNSURLExtras.mm:
2896
2897 2018-09-28  Jer Noble  <jer.noble@apple.com>
2898
2899         Refactoring: eliminate raw pointer usage in Fullscreen code
2900         https://bugs.webkit.org/show_bug.cgi?id=188747
2901         <rdar://problem/43541164>
2902
2903         Reviewed by Alex Christensen.
2904
2905         PlaybackSessionInterface no longer has an invalidate() method.
2906
2907         * WebView/WebView.mm:
2908         (-[WebView _clearPlaybackControlsManager]):
2909
2910 2018-09-28  Chris Dumez  <cdumez@apple.com>
2911
2912         Drop support for cross-origin-window-policy header
2913         https://bugs.webkit.org/show_bug.cgi?id=190081
2914
2915         Reviewed by Ryosuke Niwa.
2916
2917         * WebView/WebPreferenceKeysPrivate.h:
2918         * WebView/WebPreferences.mm:
2919         (+[WebPreferences initialize]):
2920         * WebView/WebPreferencesPrivate.h:
2921         * WebView/WebView.mm:
2922         (-[WebView _preferencesChanged:]):
2923
2924 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2925
2926         Rename createMarkup to serializePreservingVisualAppearance
2927         https://bugs.webkit.org/show_bug.cgi?id=190086
2928
2929         Reviewed by Wenson Hsieh.
2930
2931         * DOM/WebDOMOperations.mm:
2932         (-[DOMRange markupString]):
2933
2934 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2935
2936         Unreviewed, rolling out r236605.
2937         https://bugs.webkit.org/show_bug.cgi?id=190087
2938
2939         caused three API test timeouts (Requested by jernoble on
2940         #webkit).
2941
2942         Reverted changeset:
2943
2944         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2945         https://bugs.webkit.org/show_bug.cgi?id=188747
2946         https://trac.webkit.org/changeset/236605
2947
2948 2018-09-28  Jer Noble  <jer.noble@apple.com>
2949
2950         Refactoring: eliminate raw pointer usage in Fullscreen code
2951         https://bugs.webkit.org/show_bug.cgi?id=188747
2952         <rdar://problem/43541164>
2953
2954         Reviewed by Alex Christensen.
2955
2956         PlaybackSessionInterface no longer has an invalidate() method.
2957
2958         * WebView/WebView.mm:
2959         (-[WebView _clearPlaybackControlsManager]):
2960
2961 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2962
2963         Use enum class in createMarkup arguments
2964         https://bugs.webkit.org/show_bug.cgi?id=190028
2965
2966         Reviewed by Wenson Hsieh.
2967
2968         * DOM/WebDOMOperations.mm:
2969         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2970         (-[DOMRange markupString]): Ditto.
2971
2972 2018-09-27  Antoine Quint  <graouts@apple.com>
2973
2974         [Web Animations] Turn Web Animations with CSS integration on
2975         https://bugs.webkit.org/show_bug.cgi?id=184819
2976         <rdar://problem/39597337>
2977
2978         Reviewed by Dean Jackson.
2979
2980         * WebView/WebPreferences.mm:
2981         (+[WebPreferences initialize]):
2982
2983 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2984
2985         Selection should work across shadow boundary when initiated by a mouse drag
2986         https://bugs.webkit.org/show_bug.cgi?id=151380
2987         <rdar://problem/24363872>
2988
2989         Reviewed by Wenson Hsieh.
2990
2991         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2992
2993         * WebView/WebPreferenceKeysPrivate.h:
2994         * WebView/WebPreferences.mm:
2995         (+[WebPreferences initialize]):
2996         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2997         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2998         * WebView/WebPreferencesPrivate.h:
2999         * WebView/WebView.mm:
3000         (-[WebView _preferencesChanged:]):
3001
3002 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3003
3004         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3005         https://bugs.webkit.org/show_bug.cgi?id=189918
3006         Work towards <rdar://problem/44648705>
3007
3008         Reviewed by Tim Horton.
3009
3010         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3011
3012         * WebView/WebHTMLView.mm:
3013         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3014         (-[WebHTMLView _updateFontPanel]):
3015         * WebView/WebView.mm:
3016         (-[WebView typingAttributes]):
3017
3018 2018-09-17  Darin Adler  <darin@apple.com>
3019
3020         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3021         https://bugs.webkit.org/show_bug.cgi?id=189652
3022
3023         Reviewed by Saam Barati.
3024
3025         * WebView/WebPDFRepresentation.mm:
3026         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3027
3028 2018-09-14  Jer Noble  <jer.noble@apple.com>
3029
3030         Turn SourceBufferChangeTypeEnabled on by default
3031         https://bugs.webkit.org/show_bug.cgi?id=189527
3032
3033         Reviewed by Eric Carlson.
3034
3035         * WebView/WebPreferences.mm:
3036         (+[WebPreferences initialize]):
3037
3038 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3039
3040         Fix an internal build after r235935
3041         https://bugs.webkit.org/show_bug.cgi?id=188996
3042
3043         * Carbon/HIWebView.mm:
3044         (Draw):
3045         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3046
3047 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3048
3049         Add IGNORE_WARNING_.* macros
3050         https://bugs.webkit.org/show_bug.cgi?id=188996
3051
3052         Reviewed by Michael Catanzaro.
3053
3054         * Carbon/CarbonUtils.m:
3055         (PoolCleaner):
3056         * Carbon/CarbonWindowAdapter.mm:
3057         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3058         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3059         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3060         (-[CarbonWindowAdapter _termWindowIfOwner]):
3061         (-[CarbonWindowAdapter _windowMovedToRect:]):
3062         (-[CarbonWindowAdapter setContentView:]):
3063         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3064         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3065         * Carbon/CarbonWindowFrame.m:
3066         (-[CarbonWindowFrame title]):
3067         * Carbon/HIViewAdapter.m:
3068         (+[HIViewAdapter getHIViewForNSView:]):
3069         * Carbon/HIWebView.mm:
3070         (overrideCGContext):
3071         (restoreCGContext):
3072         (Draw):
3073         * DOM/DOM.mm:
3074         * History/WebHistory.mm:
3075         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3076         * History/WebHistoryItem.mm:
3077         (-[WebHistoryItem icon]):
3078         * Misc/WebKitNSStringExtras.mm:
3079         (-[NSString _web_drawAtPoint:font:textColor:]):
3080         * Misc/WebNSImageExtras.m:
3081         (-[NSImage _web_scaleToMaxSize:]):
3082         (-[NSImage _web_dissolveToFraction:]):
3083         * Misc/WebNSPasteboardExtras.mm:
3084         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3085         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3086         * Panels/WebAuthenticationPanel.m:
3087         (-[WebAuthenticationPanel loadNib]):
3088         * Plugins/Hosted/NetscapePluginHostManager.mm:
3089         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3090         (WebKit::NetscapePluginHostManager::didCreateWindow):
3091         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3092         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3093         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3094         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3095         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3096         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3097         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3098         (-[WebHostedNetscapePluginView drawRect:]):
3099         * Plugins/Hosted/WebTextInputWindowController.m:
3100         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3101         * Plugins/WebBaseNetscapePluginView.mm:
3102         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3103         * Plugins/WebNetscapePluginPackage.mm:
3104         (-[WebNetscapePluginPackage _tryLoad]):
3105         * Plugins/WebNetscapePluginView.mm:
3106         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3107         (-[WebNetscapePluginView sendDrawRectEvent:]):
3108         (-[WebNetscapePluginView drawRect:]):
3109         * Plugins/WebPluginController.mm:
3110         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3111         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3112         * WebCoreSupport/PopupMenuMac.mm:
3113         (PopupMenuMac::populate):
3114         * WebCoreSupport/WebAlternativeTextClient.h:
3115         * WebCoreSupport/WebDragClient.mm:
3116         (WebDragClient::startDrag):
3117         * WebCoreSupport/WebFrameLoaderClient.mm:
3118         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3119         (webGetNSImage):
3120         * WebInspector/WebNodeHighlight.mm:
3121         * WebInspector/WebNodeHighlightView.mm:
3122         (-[WebNodeHighlightView drawRect:]):
3123         * WebView/WebClipView.mm:
3124         (-[WebClipView initWithFrame:]):
3125         * WebView/WebFrame.mm:
3126         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3127         (-[WebFrame _drawRect:contentsOnly:]):
3128         (-[WebFrame accessibilityRoot]):
3129         * WebView/WebFullScreenController.mm:
3130         (-[WebFullScreenController enterFullScreen:]):
3131         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3132         (-[WebFullScreenController exitFullScreen]):
3133         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3134         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3135         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3136         * WebView/WebHTMLView.mm:
3137         (-[NSWindow _web_borderView]):
3138         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3139         (-[WebHTMLView _setAsideSubviews]):
3140         (-[WebHTMLView _autoscroll]):
3141         (-[WebHTMLView drawRect:]):
3142         (-[WebHTMLView mouseDown:]):
3143         (-[WebHTMLView mouseDragged:]):
3144         (-[WebHTMLView mouseUp:]):
3145         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3146         (-[WebHTMLView knowsPageRange:]):
3147         (-[WebHTMLView accessibilityHitTest:]):
3148         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3149         (-[WebHTMLView _colorAsString:]):
3150         (-[WebHTMLView copyFont:]):
3151         (-[WebHTMLView _executeSavedKeypressCommands]):
3152         (-[WebHTMLView attachRootLayer:]):
3153         (-[WebHTMLView textStorage]):
3154         (-[WebHTMLView _updateSelectionForInputManager]):
3155         * WebView/WebPDFView.mm:
3156         (_applicationInfoForMIMEType):
3157         (-[WebPDFView centerSelectionInVisibleArea:]):
3158         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3159         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3160         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3161         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3162         * WebView/WebTextCompletionController.mm:
3163         (-[WebTextCompletionController _buildUI]):
3164         (-[WebTextCompletionController _placePopupWindow:]):
3165         * WebView/WebVideoFullscreenController.mm:
3166         * WebView/WebVideoFullscreenHUDWindowController.mm:
3167         (createMediaUIBackgroundView):
3168         * WebView/WebView.mm:
3169         (-[WebTextListTouchBarViewController initWithWebView:]):
3170         (-[WebView _dispatchTileDidDraw:]):
3171         (-[WebView encodeWithCoder:]):
3172         (-[WebView mainFrameIcon]):
3173         (LayerFlushController::flushLayers):
3174         * WebView/WebWindowAnimation.mm:
3175         (setScaledFrameForWindow):
3176
3177 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3178
3179         Remove unused needsDestruction class variables from HashTraits
3180         https://bugs.webkit.org/show_bug.cgi?id=189490
3181
3182         Reviewed by Daniel Bates.
3183
3184         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3185
3186 2018-09-07  Frederic Wang  <fwang@igalia.com>
3187
3188         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3189         https://bugs.webkit.org/show_bug.cgi?id=182230
3190
3191         Reviewed by Simon Fraser.
3192
3193         * DOM/DOMDocument.mm:
3194         (-[DOMDocument scrollingElement]): Use the new name.
3195
3196 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3197
3198         Refactor WebCore::EditAction to be an 8-bit enum class
3199         https://bugs.webkit.org/show_bug.cgi?id=189383
3200
3201         Reviewed by Dan Bernstein.
3202
3203         * WebCoreSupport/WebEditorClient.mm:
3204         (undoNameForEditAction):
3205         * WebView/WebHTMLView.mm:
3206         (-[WebHTMLView pasteFont:]):
3207         (-[WebHTMLView changeFont:]):
3208         (-[WebHTMLView changeAttributes:]):
3209         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3210         (-[WebHTMLView changeColor:]):
3211         * WebView/WebView.mm:
3212         (-[WebView setTypingStyle:]):
3213
3214 2018-09-06  Frederic Wang  <fwang@igalia.com>
3215
3216         Group options of scrollRectToVisible into a struct
3217         https://bugs.webkit.org/show_bug.cgi?id=189352
3218
3219         Reviewed by Simon Fraser.
3220
3221         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3222         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3223         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3224
3225 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3226
3227         [macOS] Cannot change font size at selection until font panel is shown
3228         https://bugs.webkit.org/show_bug.cgi?id=189295
3229         <rdar://problem/35593389>
3230
3231         Reviewed by Ryosuke Niwa.
3232
3233         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3234         WebCore ChangeLog for more details.
3235
3236         * WebView/WebHTMLView.mm:
3237         (-[WebHTMLView changeFont:]):
3238         (-[WebHTMLView changeAttributes:]):
3239         (-[WebHTMLView _originalFontA]): Deleted.
3240         (-[WebHTMLView _originalFontB]): Deleted.
3241         (fontNameForDescription): Deleted.
3242         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3243         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3244         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3245
3246 2018-09-05  Jer Noble  <jer.noble@apple.com>
3247
3248         Add MediaCapabilities as an Experimental Feature
3249         https://bugs.webkit.org/show_bug.cgi?id=189209
3250
3251         Reviewed by Eric Carlson.
3252
3253         RuntimeEnabledFeature -> Setting.
3254
3255         * WebView/WebView.mm:
3256         (-[WebView _preferencesChanged:]):
3257
3258 2018-09-04  Frederic Wang  <fwang@igalia.com>
3259
3260         Add basic support for ScrollIntoViewOptions
3261         https://bugs.webkit.org/show_bug.cgi?id=189258
3262
3263         Reviewed by Simon Fraser.
3264
3265         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3266         header so that this file can build despite the new scrollIntoView function.
3267
3268 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3269
3270         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3271         https://bugs.webkit.org/show_bug.cgi?id=188890
3272         <rdar://problem/43648605>
3273
3274         Reviewed by Tim Horton.
3275
3276         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3277         more detail.
3278
3279         * WebCoreSupport/WebPlatformStrategies.h:
3280         * WebCoreSupport/WebPlatformStrategies.mm:
3281         (WebPlatformStrategies::allStringsForType):
3282
3283 2018-09-01  Darin Adler  <darin@apple.com>
3284
3285         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3286         https://bugs.webkit.org/show_bug.cgi?id=189072
3287         Reviewed by Dan Bernstein.
3288
3289         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3290         and declarations for NSURLDownload init methods.
3291
3292         * Misc/WebDownloadInternal.h: Removed.
3293
3294         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3295         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3296         "-Wdeprecated-declarations" because the method used here is deprecated.
3297
3298         * WebView/WebView.mm:
3299         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3300         used here is deprecated.
3301
3302 2018-08-31  Chris Dumez  <cdumez@apple.com>
3303
3304         Assertion hit in ~CompletionHandler() from ~WebFrame()
3305         https://bugs.webkit.org/show_bug.cgi?id=189199
3306         <rdar://problem/42657233>
3307
3308         Reviewed by Youenn Fablet.
3309
3310         * WebCoreSupport/WebFrameLoaderClient.h:
3311         * WebCoreSupport/WebFrameLoaderClient.mm:
3312         (WebFrameLoaderClient::dispatchWillSubmitForm):
3313
3314 2018-08-31  Antti Koivisto  <antti@apple.com>
3315
3316         Replace OptionSet |= and -= operators with add() and remove() functions
3317         https://bugs.webkit.org/show_bug.cgi?id=189169
3318
3319         Reviewed by Anders Carlsson.
3320
3321         * WebView/WebFrame.mm:
3322         (-[WebFrame _drawRect:contentsOnly:]):
3323         * WebView/WebView.mm:
3324         (coreOptions):
3325
3326 2018-08-31  Frederic Wang  <fwang@igalia.com>
3327
3328         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3329         https://bugs.webkit.org/show_bug.cgi?id=182053
3330
3331         Reviewed by Simon Fraser.
3332
3333         Add developer flag to use standard behavior for scrolling* attributes.
3334
3335         * WebView/WebPreferenceKeysPrivate.h:
3336         * WebView/WebPreferences.mm:
3337         (+[WebPreferences initialize]):
3338         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3339         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3340         * WebView/WebPreferencesPrivate.h:
3341         * WebView/WebView.mm:
3342         (-[WebView _preferencesChanged:]):
3343
3344 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3345
3346         Implement the Web Share API
3347         https://bugs.webkit.org/show_bug.cgi?id=171100
3348         <rdar://problem/31751734>
3349
3350         Reviewed by Tim Horton.
3351
3352         * WebCoreSupport/WebChromeClient.h:
3353         * WebCoreSupport/WebChromeClient.mm:
3354         (WebChromeClient::showShareSheet):
3355         Empty declaration of showShareSheet.
3356
3357 2018-08-29  Youenn Fablet  <youenn@apple.com>
3358
3359         Remove WebRTC legacy API implementation
3360         https://bugs.webkit.org/show_bug.cgi?id=189040
3361
3362         Reviewed by Eric Carlson.
3363
3364         * WebView/WebPreferenceKeysPrivate.h:
3365         * WebView/WebPreferences.mm:
3366         (+[WebPreferences initialize]):
3367         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3368         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3369         * WebView/WebPreferencesPrivate.h:
3370         * WebView/WebView.mm:
3371         (-[WebView _preferencesChanged:]):
3372
3373 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3374
3375         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3376         https://bugs.webkit.org/show_bug.cgi?id=189054
3377
3378         Reviewed by Andy Estes.
3379
3380         Remove the pasteboard type argument from readURLFromPasteboard.
3381
3382         * WebCoreSupport/WebPlatformStrategies.h:
3383         * WebCoreSupport/WebPlatformStrategies.mm:
3384         (WebPlatformStrategies::readURLFromPasteboard):
3385
3386 2018-08-27  Keith Rollin  <krollin@apple.com>
3387
3388         Unreviewed build fix -- disable LTO for production builds
3389
3390         * Configurations/Base.xcconfig:
3391
3392 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3393
3394         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3395         https://bugs.webkit.org/show_bug.cgi?id=188931
3396
3397         Reviewed by Wenson Hsieh.
3398
3399         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3400
3401 2018-08-27  Keith Rollin  <krollin@apple.com>
3402
3403         Build system support for LTO
3404         https://bugs.webkit.org/show_bug.cgi?id=187785
3405         <rdar://problem/42353132>
3406
3407         Reviewed by Dan Bernstein.
3408
3409         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3410         LTO.
3411
3412         * Configurations/Base.xcconfig:
3413         * Configurations/DebugRelease.xcconfig:
3414
3415 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3416
3417         Pass in IsComposed flag to Event constructors
3418         https://bugs.webkit.org/show_bug.cgi?id=188720
3419         <rdar://problem/43580387>
3420
3421         Reviewed by Simon Fraser.
3422
3423         * WebView/WebPDFView.mm:
3424         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3425         whether it's simulated or not.
3426
3427 2018-08-23  Mark Lam  <mark.lam@apple.com>
3428
3429         Move vmEntryGlobalObject() to VM from CallFrame.
3430         https://bugs.webkit.org/show_bug.cgi?id=188900
3431         <rdar://problem/43655753>
3432
3433         Reviewed by Michael Saboff.
3434
3435         * WebView/WebScriptDebugger.mm:
3436         (WebScriptDebugger::sourceParsed):
3437
3438 2018-08-23  Andy Estes  <aestes@apple.com>
3439
3440         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3441         https://bugs.webkit.org/show_bug.cgi?id=188829
3442
3443         Reviewed by Tim Horton.
3444
3445         * Configurations/FeatureDefines.xcconfig:
3446
3447 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3448
3449         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3450         https://bugs.webkit.org/show_bug.cgi?id=188777
3451
3452         Reviewed by Simon Fraser.
3453
3454         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3455         being "true" before the code change.
3456
3457         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3458
3459         * WebView/WebPDFView.mm:
3460         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3461
3462 2018-08-21  Daniel Bates  <dabates@apple.com>
3463
3464         Replace TextCheckingTypeMask with OptionSet
3465         https://bugs.webkit.org/show_bug.cgi?id=188678
3466
3467         Reviewed by Antti Koivisto.
3468
3469         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3470         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3471         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3472         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3473
3474         * WebCoreSupport/WebEditorClient.h:
3475         * WebCoreSupport/WebEditorClient.mm:
3476         (WebEditorClient::checkTextOfParagraph):
3477         (WebEditorClient::shouldEraseMarkersAfterChangeSelection co