Drop FrameLoaderClient::sessionID()
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-09-18  Chris Dumez  <cdumez@apple.com>
2
3         Drop FrameLoaderClient::sessionID()
4         https://bugs.webkit.org/show_bug.cgi?id=201916
5
6         Reviewed by Geoffrey Garen.
7
8         Drop FrameLoaderClient::sessionID(). The Frame can get the sessionID from its page (Which is
9         what the FrameLoaderClient::sessionID() ended up doing) and other call sites at WebKit2 layer
10         can get the sessionID from the WebProcess singleton.
11
12         * WebCoreSupport/WebFrameLoaderClient.h:
13         * WebCoreSupport/WebFrameLoaderClient.mm:
14
15 2019-09-17  Chris Dumez  <cdumez@apple.com>
16
17         Stop calling Page::setSessionID() from WebKit2
18         https://bugs.webkit.org/show_bug.cgi?id=201888
19
20         Reviewed by Alex Christensen.
21
22         Stop calling Page::setSessionID() from WebKit2 since Page's sessionID can never change when
23         using WebKit2 (We process-swap and create a new Page in a new process when changing data
24         store). Instead, we now pass the sessionID ID when constructing the Page, as part of the
25         PageConfiguration structure.
26
27         * WebView/WebView.mm:
28         (-[WebView _commonInitializationWithFrameName:groupName:]):
29
30 2019-09-09  Alex Christensen  <achristensen@webkit.org>
31
32         Disable TLS 1.0 and 1.1 in WebSockets
33         https://bugs.webkit.org/show_bug.cgi?id=201573
34
35         Reviewed by Youenn Fablet.
36
37         * WebView/WebView.mm:
38         (-[WebView _commonInitializationWithFrameName:groupName:]):
39
40 2019-09-06  Alex Christensen  <achristensen@webkit.org>
41
42         When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
43         https://bugs.webkit.org/show_bug.cgi?id=201480
44
45         Reviewed by Youenn Fablet.
46
47         * WebView/WebView.mm:
48         (-[WebView _preferencesChanged:]):
49
50 2019-09-06  Rob Buis  <rbuis@igalia.com>
51
52         Add runtime flag for lazy image loading
53         https://bugs.webkit.org/show_bug.cgi?id=199794
54
55         Reviewed by Frédéric Wang.
56
57         Remove parts of r248409 that were meant for WK1 since
58         lazy image loading is WK2 only.
59
60         * WebView/WebPreferenceKeysPrivate.h:
61         * WebView/WebPreferences.mm:
62         (+[WebPreferences initialize]):
63         (-[WebPreferences lazyImageLoadingEnabled]): Deleted.
64         (-[WebPreferences setLazyImageLoadingEnabled:]): Deleted.
65         * WebView/WebPreferencesPrivate.h:
66         * WebView/WebView.mm:
67         (-[WebView _preferencesChanged:]):
68
69 2019-09-04  Alex Christensen  <achristensen@webkit.org>
70
71         Remove unused SPI that accesses MemoryCache directly
72         https://bugs.webkit.org/show_bug.cgi?id=201468
73
74         Reviewed by Tim Horton.
75
76         * Misc/WebCache.h:
77         * Misc/WebCache.mm:
78         (+[WebCache addImageToCache:forURL:]): Deleted.
79         (+[WebCache addImageToCache:forURL:forFrame:]): Deleted.
80         (+[WebCache removeImageFromCacheForURL:]): Deleted.
81         (+[WebCache removeImageFromCacheForURL:forFrame:]): Deleted.
82
83 2019-08-30  Keith Rollin  <krollin@apple.com>
84
85         Remove AppKitCompatibilityDeclarations.h
86         https://bugs.webkit.org/show_bug.cgi?id=201283
87         <rdar://problem/54822042>
88
89         Reviewed by Alexey Proskuryakov.
90
91         The two copies of these files -- on in WTF, one in MiniBrowser -- are
92         empty and can be removed.
93
94         * Misc/WebNSEventExtras.m:
95         * Misc/WebNSViewExtras.m:
96         * WebKitPrefix.h:
97
98 2019-08-30  Keith Rollin  <krollin@apple.com>
99
100         Remove extra braces
101         https://bugs.webkit.org/show_bug.cgi?id=201285
102
103         Reviewed by Alexey Proskuryakov.
104
105         Some code evolved such that there was only a single statement under an
106         'if' statement. The braces surrounding the single-line block can now
107         be removed.
108
109         * WebView/WebView.mm:
110         (-[WebView updateMediaTouchBar]):
111
112 2019-08-29  Keith Rollin  <krollin@apple.com>
113
114         Update .xcconfig symbols to reflect the current set of past and future product versions.
115         https://bugs.webkit.org/show_bug.cgi?id=200720
116         <rdar://problem/54305032>
117
118         Reviewed by Alex Christensen.
119
120         Remove version symbols related to old OS's we no longer support,
121         ensure that version symbols are defined for OS's we do support.
122
123         * Configurations/Base.xcconfig:
124         * Configurations/DebugRelease.xcconfig:
125         * Configurations/Version.xcconfig:
126
127 2019-08-29  Keith Rollin  <krollin@apple.com>
128
129         Remove support for macOS < 10.13 (part 3)
130         https://bugs.webkit.org/show_bug.cgi?id=201224
131         <rdar://problem/54795934>
132
133         Reviewed by Darin Adler.
134
135         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
136         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
137         like _MACOS_SINCE_1013.
138
139         * Configurations/WebKitTargetConditionals.xcconfig:
140
141 2019-08-29  Dean Jackson  <dino@apple.com>
142
143         GenerateTAPI WebKitLegacy.tbd fails on internal iOS Simulator builds
144         https://bugs.webkit.org/show_bug.cgi?id=201200
145
146         Reverting r249211 after Dan Bernstein pointed out it will cause
147         an error with the public iOS 13 SDK.
148
149         * Misc/WebDownload.h:
150
151 2019-08-28  Dean Jackson  <dino@apple.com>
152
153         GenerateTAPI WebKitLegacy.tbd fails on internal iOS Simulator builds
154         https://bugs.webkit.org/show_bug.cgi?id=201200
155
156         Reviewed by Simon Fraser.
157
158         We want to include Foundation/NSURLDownload.h if we're on
159         a newer iOS.
160
161         * Misc/WebDownload.h:
162
163 2019-08-28  Keith Rollin  <krollin@apple.com>
164
165         Remove support for macOS < 10.13 (part 2)
166         https://bugs.webkit.org/show_bug.cgi?id=201197
167         <rdar://problem/54759985>
168
169         Reviewed by Darin Adler.
170
171         Update conditionals that reference WK_MACOS_1013 and suffixes like
172         _MACOS_SINCE_1013, assuming that we're always building on 10.13 or
173         later and that these conditionals are always True or False.
174
175         See Bug 200694 for earlier changes in this area.
176
177         * Configurations/FeatureDefines.xcconfig:
178
179 2019-08-27  Mark Lam  <mark.lam@apple.com>
180
181         Refactor to use VM& instead of VM* at as many places as possible.
182         https://bugs.webkit.org/show_bug.cgi?id=201172
183
184         Reviewed by Yusuke Suzuki.
185
186         * DOM/DOM.mm:
187         (+[DOMNode _nodeFromJSWrapper:]):
188         * DOM/DOMUtility.mm:
189         (createDOMWrapper):
190         * Plugins/Hosted/NetscapePluginHostProxy.mm:
191         (identifierFromIdentifierRep):
192         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
193         (WebKit::NetscapePluginInstanceProxy::enumerate):
194         (WebKit::getObjectID):
195         (WebKit::NetscapePluginInstanceProxy::addValueToArray):
196         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
197         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
198         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
199         * Plugins/Hosted/ProxyInstance.mm:
200         (WebKit::ProxyInstance::stringValue const):
201         (WebKit::ProxyInstance::getPropertyNames):
202         * WebView/WebFrame.mm:
203         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
204
205 2019-08-23  Chris Dumez  <cdumez@apple.com>
206
207         [geolocation] Rename interfaces and remove [NoInterfaceObject]
208         https://bugs.webkit.org/show_bug.cgi?id=200885
209
210         Reviewed by Alex Christensen.
211
212         * WebCoreSupport/WebGeolocationClient.h:
213         * WebCoreSupport/WebGeolocationClient.mm:
214         (WebGeolocationClient::lastPosition):
215         * WebView/WebGeolocationPosition.mm:
216         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
217         (core):
218         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
219         (-[WebGeolocationPosition initWithGeolocationPosition:]):
220         * WebView/WebGeolocationPositionInternal.h:
221
222 2019-08-22  Andy Estes  <aestes@apple.com>
223
224         [watchOS] Disable Content Filtering in the simulator build
225         https://bugs.webkit.org/show_bug.cgi?id=201047
226
227         Reviewed by Tim Horton.
228
229         * Configurations/FeatureDefines.xcconfig:
230
231 2019-08-21  Tim Horton  <timothy_horton@apple.com>
232
233         [Mail] Tapping top of message scrolls back to copied text instead of top of the message
234         https://bugs.webkit.org/show_bug.cgi?id=200999
235         <rdar://problem/54564878>
236
237         Reviewed by Wenson Hsieh.
238
239         * WebCoreSupport/WebEditorClient.h:
240         * WebCoreSupport/WebEditorClient.mm:
241         (WebEditorClient::shouldAllowSingleClickToChangeSelection const):
242         Copy the existing behavior from EventHandler.
243         We do not fix the bug in WebKitLegacy for a multitude of reasons, primarily
244         because we do not know of any user impact.
245
246 2019-08-21  Ryosuke Niwa  <rniwa@webkit.org>
247
248         Put keygen element behind a runtime flag and disable it by default
249         https://bugs.webkit.org/show_bug.cgi?id=200850
250
251         Reviewed by Antti Koivisto.
252
253         * WebView/WebPreferenceKeysPrivate.h:
254         * WebView/WebPreferences.mm:
255         (-[WebPreferences keygenElementEnabled]):
256         (-[WebPreferences setKeygenElementEnabled:]):
257         * WebView/WebPreferencesPrivate.h:
258         * WebView/WebView.mm:
259         (-[WebView _preferencesChanged:]):
260
261 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
262
263         Remove IDB-specific quota
264         https://bugs.webkit.org/show_bug.cgi?id=196545
265         <rdar://problem/54201783>
266
267         Reviewed by Youenn Fablet.
268
269         * Storage/WebDatabaseManager.mm:
270         (-[WebDatabaseManager setIDBPerOriginQuota:]): Deleted.
271         * Storage/WebDatabaseManagerPrivate.h:
272
273 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
274
275         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
276         https://bugs.webkit.org/show_bug.cgi?id=200620
277
278         Reviewed by Geoffrey Garen.
279
280         * History/WebHistory.mm:
281         (-[WebHistoryPrivate init]):
282         * History/WebHistoryItem.mm:
283         (-[WebHistoryItem initFromDictionaryRepresentation:]):
284         * Plugins/Hosted/NetscapePluginHostProxy.mm:
285         (WKPCGetScriptableNPObjectReply):
286         (WKPCBooleanReply):
287         (WKPCBooleanAndDataReply):
288         (WKPCInstantiatePluginReply):
289         * Plugins/Hosted/ProxyInstance.mm:
290         (WebKit::ProxyInstance::methodNamed):
291         (WebKit::ProxyInstance::fieldNamed):
292         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
293         (-[WebHostedNetscapePluginView createPlugin]):
294         * Plugins/WebNetscapePluginEventHandler.mm:
295         (WebNetscapePluginEventHandler::create):
296         * Plugins/WebNetscapePluginView.mm:
297         (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
298         * Storage/WebDatabaseManagerClient.mm:
299         (DidModifyOriginData::dispatchToMainThread):
300         * WebCoreSupport/WebFrameLoaderClient.mm:
301         (addRedirectURL):
302         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
303         * WebCoreSupport/WebInspectorClient.mm:
304         (WebInspectorClient::openLocalFrontend):
305         * WebView/WebDeviceOrientationProviderMock.mm:
306         * WebView/WebFrame.mm:
307         (-[WebFrame _attachScriptDebugger]):
308         * WebView/WebMediaPlaybackTargetPicker.mm:
309         (WebMediaPlaybackTargetPicker::create):
310         * WebView/WebTextIterator.mm:
311         (-[WebTextIterator initWithRange:]):
312         * WebView/WebView.mm:
313         (-[WebView _injectOutlookQuirksScript]):
314         (-[WebView _commonInitializationWithFrameName:groupName:]):
315         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
316         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
317         (-[WebView _selectionServiceController]):
318         (-[WebView _setTextIndicator:withLifetime:]):
319         * WebView/WebViewData.mm:
320         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
321         (-[WebViewPrivate init]):
322
323 2019-08-17  Darin Adler  <darin@apple.com>
324
325         Tidy up checks to see if a character is in the Latin-1 range by using isLatin1 consistently
326         https://bugs.webkit.org/show_bug.cgi?id=200861
327
328         Reviewed by Ross Kirsling.
329
330         * Misc/WebKitNSStringExtras.mm:
331         (canUseFastRenderer): Use isLatin1.
332
333 2019-08-16  Chris Dumez  <cdumez@apple.com>
334
335         LocalStorageDatabaseTracker does not need to subclass ThreadSafeRefCounted
336         https://bugs.webkit.org/show_bug.cgi?id=200825
337
338         Reviewed by Alex Christensen.
339
340         * Misc/WebKitVersionChecks.h:
341         * Storage/WebStorageManager.mm:
342         (WebKitInitializeStorageIfNecessary):
343
344 2019-08-16  Ryosuke Niwa  <rniwa@webkit.org>
345
346         Split tabIndex computation for DOM and the rest of WebCore
347         https://bugs.webkit.org/show_bug.cgi?id=200806
348
349         Reviewed by Chris Dumez.
350
351         * DOM/DOMHTMLElement.mm:
352         (-[DOMHTMLElement tabIndex]):
353         (-[DOMHTMLElement setTabIndex:]):
354
355 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
356
357         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
358         https://bugs.webkit.org/show_bug.cgi?id=200620
359
360         Reviewed by Geoffrey Garen.
361
362         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
363         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
364         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
365         * Storage/WebDatabaseManagerClient.mm:
366         * WebCoreSupport/WebAlternativeTextClient.h:
367         * WebCoreSupport/WebCachedFramePlatformData.h:
368         * WebCoreSupport/WebChromeClient.h:
369         * WebCoreSupport/WebContextMenuClient.h:
370         * WebCoreSupport/WebDragClient.h:
371         * WebCoreSupport/WebEditorClient.h:
372         * WebCoreSupport/WebGeolocationClient.h:
373         * WebCoreSupport/WebInspectorClient.h:
374         * WebCoreSupport/WebNotificationClient.h:
375         * WebCoreSupport/WebSelectionServiceController.h:
376         * WebView/WebMediaPlaybackTargetPicker.h:
377
378 2019-08-15  Tim Horton  <timothy_horton@apple.com>
379
380         Yellow Lookup highlight gets stuck over Mail messages
381         https://bugs.webkit.org/show_bug.cgi?id=200778
382         <rdar://problem/53868514>
383
384         Reviewed by Wenson Hsieh.
385
386         * WebView/WebView.mm:
387         (-[WebView _showDictionaryLookupPopup:]):
388         Add a dismissal callback so that when Reveal hides the panel, it also
389         dismisses the yellow indicator. This matches the behavior in modern WebKit.
390
391 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
392
393         Some improvements on web storage
394         https://bugs.webkit.org/show_bug.cgi?id=200373
395
396         Reviewed by Geoffrey Garen.
397
398         * WebView/WebView.mm:
399         (-[WebView _preferencesChanged:]): notify storageNamespaceProvider about session change.
400
401 2019-08-15  Youenn Fablet  <youenn@apple.com>
402
403         Always create a Document with a valid SessionID
404         https://bugs.webkit.org/show_bug.cgi?id=200727
405
406         Reviewed by Alex Christensen.
407
408         Implement WebKit1 sessionID getter like done for WebKit2.
409         Either the loader client has a page in which case the page session ID is used
410         or the client has no page, in which case the default session ID is used.
411         This is the same behavior as CachedResourceLoader.
412
413         * WebCoreSupport/WebFrameLoaderClient.mm:
414         (WebFrameLoaderClient::sessionID const):
415
416 2019-08-15  Simon Fraser  <simon.fraser@apple.com>
417
418         Use ObjectIdentifier<FrameIdentifierType> for frameIDs
419         https://bugs.webkit.org/show_bug.cgi?id=199986
420
421         Reviewed by Ryosuke Niwa.
422
423         Use the strongly-typed FrameIdentifier instead of uint64_t as frame identifiers everywhere.
424
425         * WebCoreSupport/WebFrameLoaderClient.h:
426         * WebCoreSupport/WebFrameLoaderClient.mm:
427         (WebFrameLoaderClient::frameID const):
428
429 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
430
431         Unreviewed, rolling out r248526.
432
433         Caused two IndexedDB perf tests to fail
434
435         Reverted changeset:
436
437         "Remove IDB-specific quota"
438         https://bugs.webkit.org/show_bug.cgi?id=196545
439         https://trac.webkit.org/changeset/248526
440
441 2019-08-14  Keith Rollin  <krollin@apple.com>
442
443         Remove support for macOS < 10.13
444         https://bugs.webkit.org/show_bug.cgi?id=200694
445         <rdar://problem/54278851>
446
447         Reviewed by Youenn Fablet.
448
449         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
450         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
451         101300. This means that expressions like
452         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
453         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
454
455         * WebCoreSupport/WebEditorClient.mm:
456         * WebView/PDFViewSPI.h:
457         * WebView/WebHTMLView.mm:
458         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:]):
459         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:]):
460         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
461         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
462         * WebView/WebPreferences.mm:
463         (+[WebPreferences initialize]):
464         * WebView/WebView.mm:
465         (-[WebView performDragOperation:]):
466         (LayerFlushController::flushLayers):
467         (-[WebView updateMediaTouchBar]):
468         * WebView/WebViewData.h:
469
470 2019-08-14  Youenn Fablet  <youenn@apple.com>
471
472         ThreadableBlobRegistry::blobSize should take a SessionID as parameter
473         https://bugs.webkit.org/show_bug.cgi?id=200671
474
475         Reviewed by ALex Christensen.
476
477         * WebCoreSupport/WebPlatformStrategies.mm:
478
479 2019-08-13  Youenn Fablet  <youenn@apple.com>
480
481         Blob registries should be keyed by session IDs
482         https://bugs.webkit.org/show_bug.cgi?id=200567
483
484         Reviewed by Alex Christensen.
485
486         * WebCoreSupport/WebPlatformStrategies.mm:
487         (WebPlatformStrategies::createBlobRegistry):
488         Ignore sessionID parameter for WK1.
489
490 2019-08-12  Chris Dumez  <cdumez@apple.com>
491
492         Add threading assertions to RefCounted
493         https://bugs.webkit.org/show_bug.cgi?id=200507
494
495         Reviewed by Ryosuke Niwa.
496
497         * WebView/WebView.mm:
498         (+[WebView initialize]):
499         Enable new RefCounted threading assertions for WebKitLegacy.
500
501 2019-08-12  Chris Dumez  <cdumez@apple.com>
502
503         Unreviewed, rolling out r248525.
504
505         Revert new threading assertions while I work on fixing the
506         issues they exposed
507
508         Reverted changeset:
509
510         "Add threading assertions to RefCounted"
511         https://bugs.webkit.org/show_bug.cgi?id=200507
512         https://trac.webkit.org/changeset/248525
513
514 2019-08-12  Youenn Fablet  <youenn@apple.com>
515
516         Remove IDB-specific quota
517         https://bugs.webkit.org/show_bug.cgi?id=196545
518
519         Reviewed by Alex Christensen.
520
521         * Storage/WebDatabaseManager.mm:
522         (-[WebDatabaseManager setIDBPerOriginQuota:]): Deleted.
523         * Storage/WebDatabaseManagerPrivate.h:
524
525 2019-08-11  Chris Dumez  <cdumez@apple.com>
526
527         Add threading assertions to RefCounted
528         https://bugs.webkit.org/show_bug.cgi?id=200507
529
530         Reviewed by Ryosuke Niwa.
531
532         * WebView/WebView.mm:
533         (+[WebView initialize]):
534         Enable new RefCounted threading assertions for WebKitLegacy.
535
536 2019-08-10  Tim Horton  <timothy_horton@apple.com>
537
538         Remove some more unused 32-bit code
539         https://bugs.webkit.org/show_bug.cgi?id=200607
540
541         Reviewed by Alexey Proskuryakov.
542
543         * Configurations/WebKitLegacy.xcconfig:
544         * Misc/WebSharingServicePickerController.mm:
545         (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]):
546         (-[WebSharingServicePickerController initWithSharingServicePicker:client:]):
547         (-[WebSharingServicePickerController sharingService:didShareItems:]):
548         * Plugins/WebNetscapePluginEventHandler.mm:
549         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Removed.
550         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Removed.
551         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
552         (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): Deleted.
553         (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler): Deleted.
554         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
555         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
556         (WebNetscapePluginEventHandlerCocoa::keyDown):
557         (WebNetscapePluginEventHandlerCocoa::focusChanged):
558         (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): Deleted.
559         (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler): Deleted.
560         (WebNetscapePluginEventHandlerCocoa::TSMEventHandler): Deleted.
561         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent): Deleted.
562         * WebCoreSupport/WebContextMenuClient.mm:
563         (WebContextMenuClient::contextMenuForEvent):
564         * WebView/WebHTMLView.mm:
565         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
566         (-[WebHTMLView pressureChangeWithEvent:]):
567         * WebView/WebView.mm:
568         (LayerFlushController::flushLayers):
569
570 2019-08-08  Rob Buis  <rbuis@igalia.com>
571
572         Add runtime flag for lazy image loading
573         https://bugs.webkit.org/show_bug.cgi?id=199794
574
575         Reviewed by Darin Adler.
576
577         Set lazyImageLoading runtime flag if preference is set.
578
579         * WebView/WebPreferenceKeysPrivate.h:
580         * WebView/WebPreferences.mm:
581         (+[WebPreferences initialize]):
582         (-[WebPreferences lazyImageLoadingEnabled]):
583         (-[WebPreferences setLazyImageLoadingEnabled:]):
584         * WebView/WebPreferencesPrivate.h:
585         * WebView/WebView.mm:
586         (-[WebView _preferencesChanged:]):
587
588 2019-08-07  Priyanka Agarwal  <pagarwal999@apple.com>
589
590         Allow clients to toggle a text input field between being viewable and having characters hidden while maintaining 
591         a yellow auto-filled appearance
592         https://bugs.webkit.org/show_bug.cgi?id=200037
593         rdar://problem/51900961
594
595         Reviewed by Daniel Bates.
596
597         * DOM/WebDOMOperations.mm:
598         (-[DOMHTMLInputElement _isAutoFilledAndViewable]):
599         (-[DOMHTMLInputElement _setAutoFilledAndViewable:]):
600         * DOM/WebDOMOperationsPrivate.h:
601
602 2019-08-02  Keith Rollin  <krollin@apple.com>
603
604         Consistently use Obj-C boolean literals
605         https://bugs.webkit.org/show_bug.cgi?id=200405
606         <rdar://problem/53880043>
607
608         Reviewed by Simon Fraser, Joseph Pecoraro.
609
610         There are places where we use equivalent but different expressions for
611         Obj-C boolean objects. For example, we use both [NSNumber
612         numberWithBool:YES] and @YES. There are places where both are used in
613         the same function, such as -[WebPreferences initialize]. The boolean
614         literal is in greater use and is more succinct, so standardize on
615         that. Also, change @(YES/NO) to @YES/NO.
616
617         * History/WebHistoryItem.mm:
618         * WebView/WebFrame.mm:
619         (-[WebFrame _cacheabilityDictionary]):
620         * WebView/WebPreferences.mm:
621         (+[WebPreferences initialize]):
622
623 2019-08-01  Alex Christensen  <achristensen@webkit.org>
624
625         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
626         https://bugs.webkit.org/show_bug.cgi?id=200102
627         <rdar://problem/53275114>
628
629         Reviewed by Darin Adler.
630
631         * DefaultDelegates/WebDefaultUIDelegate.mm:
632         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]): Deleted.
633         (-[WebDefaultUIDelegate webView:generateReplacementFile:]): Deleted.
634         * WebCoreSupport/WebChromeClient.h:
635         * WebCoreSupport/WebChromeClient.mm:
636         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload): Deleted.
637         (WebChromeClient::generateReplacementFile): Deleted.
638         * WebView/WebUIDelegatePrivate.h:
639
640 2019-07-25  Dean Jackson  <dino@apple.com>
641
642         Add helper for ignoring deprecated implementation warnings
643         https://bugs.webkit.org/show_bug.cgi?id=200135
644
645         Reviewed by Wenson Hsieh.
646
647         Add ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN/END macro which
648         is IGNORE_WARNINGS_BEGIN("deprecated-implementations")
649
650         * Misc/WebDownload.mm:
651         (-[WebDownload initWithRequest:delegate:]):
652         * Misc/WebIconDatabase.mm:
653         * Plugins/WebBaseNetscapePluginView.mm:
654         (-[WebBaseNetscapePluginView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
655         (-[WebBaseNetscapePluginView IGNORE_WARNINGS_END]): Deleted.
656         * WebView/WebDynamicScrollBarsView.mm:
657         (-[WebDynamicScrollBarsView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
658         (-[WebDynamicScrollBarsView IGNORE_WARNINGS_END]): Deleted.
659         * WebView/WebHTMLView.mm:
660         (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
661         (-[WebHTMLView draggedImage:endedAt:operation:]):
662         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
663         (-[WebHTMLView accessibilityAttributeValue:]):
664         (-[WebHTMLView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
665         (-[WebHTMLView characterIndexForPoint:]):
666         (-[WebHTMLView firstRectForCharacterRange:]):
667         (-[WebHTMLView attributedSubstringFromRange:]):
668         (-[WebHTMLView setMarkedText:selectedRange:]):
669         (-[WebHTMLView doCommandBySelector:]):
670         (-[WebHTMLView insertText:]):
671         (-[WebHTMLView IGNORE_WARNINGS_END]): Deleted.
672
673 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
674
675         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
676         https://bugs.webkit.org/show_bug.cgi?id=200021
677         <rdar://problem/53301325>
678
679         Reviewed by Ryosuke Niwa.
680
681         Implement a new editing client hook. In WebKit1, this always returns true on macOS and false on iOS.
682
683         * WebCoreSupport/WebEditorClient.h:
684
685 2019-07-22  Simon Fraser  <simon.fraser@apple.com>
686
687         Fix WebView iframe rendering in macOS Catalina
688         https://bugs.webkit.org/show_bug.cgi?id=200022
689         rdar://problem/49102040
690
691         Reviewed by Darin Adler.
692
693         Adapt to internal NSView method renames in Catalina.
694
695         * WebView/WebHTMLView.mm:
696         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
697         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:_recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
698
699 2019-07-22  Simon Fraser  <simon.fraser@apple.com>
700
701         Enable CSSOMViewScrollingAPIEnabled in WebKit1
702         https://bugs.webkit.org/show_bug.cgi?id=200008
703         rdar://problem/53409062
704
705         Reviewed by Tim Horton.
706
707         Default WebKitCSSOMViewScrollingAPIEnabledPreferenceKey to YES, so that 
708         CSSOMViewScrollingAPIEnabled is on for both WebKit1 and WebKit2.
709
710         DumpRenderTree already turns this preference on, so this change is not
711         detected by tests.
712
713         * WebView/WebPreferences.mm:
714         (+[WebPreferences initialize]):
715
716 2019-07-22  Youenn Fablet  <youenn@apple.com>
717
718         Disable MediaRecorder for legacy WebKit
719         https://bugs.webkit.org/show_bug.cgi?id=200001
720         <rdar://problem/53400030>
721
722         Reviewed by Eric Carlson.
723
724         Disable MediaRecorder by default in legacy WebKit.
725         Add SPI to set/get this preference.
726
727         * WebView/WebPreferences.mm:
728         (+[WebPreferences initialize]):
729         (-[WebPreferences _mediaRecorderEnabled]):
730         (-[WebPreferences _setMediaRecorderEnabled:]):
731         * WebView/WebPreferencesPrivate.h:
732
733 2019-07-18  Alex Christensen  <achristensen@webkit.org>
734
735         Unify builds in WebKitLegacy/mac/DOM
736         https://bugs.webkit.org/show_bug.cgi?id=199771
737
738         Reviewed by Geoffrey Garen.
739
740         * DOM/DOMAbstractView.mm:
741         * DOM/DOMAttr.mm:
742         * DOM/DOMBlob.mm:
743         * DOM/DOMCDATASection.mm:
744         * DOM/DOMCSSFontFaceRule.mm:
745         * DOM/DOMCSSImportRule.mm:
746         * DOM/DOMCSSMediaRule.mm:
747         * DOM/DOMCSSPageRule.mm:
748         * DOM/DOMCSSPrimitiveValue.mm:
749         * DOM/DOMCSSRule.mm:
750         * DOM/DOMCSSRuleList.mm:
751         * DOM/DOMCSSStyleDeclaration.mm:
752         * DOM/DOMCSSStyleRule.mm:
753         * DOM/DOMCSSStyleSheet.mm:
754         * DOM/DOMCSSUnknownRule.mm:
755         * DOM/DOMCSSValue.mm:
756         * DOM/DOMCSSValueList.mm:
757         * DOM/DOMCharacterData.mm:
758         * DOM/DOMComment.mm:
759         * DOM/DOMCounter.mm:
760         * DOM/DOMDocument.mm:
761         * DOM/DOMDocumentFragment.mm:
762         * DOM/DOMDocumentType.mm:
763         * DOM/DOMEvent.mm:
764         * DOM/DOMFile.mm:
765         * DOM/DOMFileList.mm:
766         * DOM/DOMHTMLAnchorElement.mm:
767         * DOM/DOMHTMLAppletElement.mm:
768         * DOM/DOMHTMLAreaElement.mm:
769         * DOM/DOMHTMLBRElement.mm:
770         * DOM/DOMHTMLBaseElement.mm:
771         * DOM/DOMHTMLBaseFontElement.mm:
772         * DOM/DOMHTMLBodyElement.mm:
773         * DOM/DOMHTMLButtonElement.mm:
774         * DOM/DOMHTMLCanvasElement.mm:
775         * DOM/DOMHTMLCollection.mm:
776         * DOM/DOMHTMLDListElement.mm:
777         * DOM/DOMHTMLDirectoryElement.mm:
778         * DOM/DOMHTMLDivElement.mm:
779         * DOM/DOMHTMLDocument.mm:
780         * DOM/DOMHTMLElement.mm:
781         * DOM/DOMHTMLEmbedElement.mm:
782         * DOM/DOMHTMLFieldSetElement.mm:
783         * DOM/DOMHTMLFontElement.mm:
784         * DOM/DOMHTMLFormElement.mm:
785         * DOM/DOMHTMLFrameElement.mm:
786         * DOM/DOMHTMLFrameSetElement.mm:
787         * DOM/DOMHTMLHRElement.mm:
788         * DOM/DOMHTMLHeadElement.mm:
789         * DOM/DOMHTMLHeadingElement.mm:
790         * DOM/DOMHTMLHtmlElement.mm:
791         * DOM/DOMHTMLIFrameElement.mm:
792         * DOM/DOMHTMLImageElement.mm:
793         * DOM/DOMHTMLInputElement.mm:
794         * DOM/DOMHTMLLIElement.mm:
795         * DOM/DOMHTMLLabelElement.mm:
796         * DOM/DOMHTMLLegendElement.mm:
797         * DOM/DOMHTMLLinkElement.mm:
798         * DOM/DOMHTMLMapElement.mm:
799         * DOM/DOMHTMLMarqueeElement.mm:
800         * DOM/DOMHTMLMediaElement.mm:
801         * DOM/DOMHTMLMenuElement.mm:
802         * DOM/DOMHTMLMetaElement.mm:
803         * DOM/DOMHTMLModElement.mm:
804         * DOM/DOMHTMLOListElement.mm:
805         * DOM/DOMHTMLObjectElement.mm:
806         * DOM/DOMHTMLOptGroupElement.mm:
807         * DOM/DOMHTMLOptionElement.mm:
808         * DOM/DOMHTMLOptionsCollection.mm:
809         * DOM/DOMHTMLParagraphElement.mm:
810         * DOM/DOMHTMLParamElement.mm:
811         * DOM/DOMHTMLPreElement.mm:
812         * DOM/DOMHTMLQuoteElement.mm:
813         * DOM/DOMHTMLScriptElement.mm:
814         * DOM/DOMHTMLSelectElement.mm:
815         * DOM/DOMHTMLStyleElement.mm:
816         * DOM/DOMHTMLTableCaptionElement.mm:
817         * DOM/DOMHTMLTableCellElement.mm:
818         * DOM/DOMHTMLTableColElement.mm:
819         * DOM/DOMHTMLTableElement.mm:
820         * DOM/DOMHTMLTableRowElement.mm:
821         * DOM/DOMHTMLTableSectionElement.mm:
822         * DOM/DOMHTMLTitleElement.mm:
823         * DOM/DOMHTMLUListElement.mm:
824         * DOM/DOMHTMLVideoElement.mm:
825         * DOM/DOMKeyboardEvent.mm:
826         * DOM/DOMMediaError.mm:
827         * DOM/DOMMediaList.mm:
828         * DOM/DOMMouseEvent.mm:
829         * DOM/DOMMutationEvent.mm:
830         * DOM/DOMNamedNodeMap.mm:
831         * DOM/DOMNodeIterator.mm:
832         * DOM/DOMNodeList.mm:
833         * DOM/DOMOverflowEvent.mm:
834         * DOM/DOMProcessingInstruction.mm:
835         * DOM/DOMProgressEvent.mm:
836         * DOM/DOMRGBColor.mm:
837         * DOM/DOMRange.mm:
838         * DOM/DOMRect.mm:
839         * DOM/DOMStyleSheet.mm:
840         * DOM/DOMStyleSheetList.mm:
841         * DOM/DOMText.mm:
842         * DOM/DOMTextEvent.mm:
843         * DOM/DOMTimeRanges.mm:
844         * DOM/DOMTokenList.mm:
845         * DOM/DOMTreeWalker.mm:
846         * DOM/DOMUIEvent.mm:
847         * DOM/DOMWheelEvent.mm:
848         * DOM/DOMXPath.mm:
849         * DOM/DOMXPathExpression.mm:
850         * DOM/DOMXPathResult.mm:
851
852 2019-07-17  Antoine Quint  <graouts@apple.com>
853
854         Disable Pointer Events prior to watchOS 6
855         https://bugs.webkit.org/show_bug.cgi?id=199890
856         <rdar://problem/53206113>
857
858         Reviewed by Dean Jackson.
859
860         * Configurations/FeatureDefines.xcconfig:
861
862 2019-07-17  Zalan Bujtas  <zalan@apple.com>
863
864         Unable to tap buttons at top of Wells Fargo app’s Payees screen
865         https://bugs.webkit.org/show_bug.cgi?id=199846
866         <rdar://problem/48112220>
867
868         Reviewed by Simon Fraser.
869
870         * WebView/WebFrame.mm:
871         (-[WebFrame approximateNodeAtViewportLocation:]):
872
873 2019-07-17  Alex Christensen  <achristensen@webkit.org>
874
875         Add a runtime-disabled dialog element skeleton
876         https://bugs.webkit.org/show_bug.cgi?id=199839
877
878         Reviewed by Ryosuke Niwa.
879
880         * WebView/WebPreferenceKeysPrivate.h:
881         * WebView/WebPreferences.mm:
882         (+[WebPreferences initialize]):
883         (-[WebPreferences dialogElementEnabled]):
884         (-[WebPreferences setDialogElementEnabled:]):
885         * WebView/WebPreferencesPrivate.h:
886         * WebView/WebView.mm:
887         (-[WebView _preferencesChanged:]):
888         Add SPI to enable the dialog element for tests.
889
890 2019-07-15  Dean Jackson  <dino@apple.com>
891
892         [WebGL] Remove software rendering and simplify context creation on macOS
893         https://bugs.webkit.org/show_bug.cgi?id=199789
894
895         Reviewed by Sam Weinig.
896
897         Remove force software WebGL setting.
898
899         * WebView/WebPreferenceKeysPrivate.h:
900         * WebView/WebPreferences.mm:
901         (+[WebPreferences initialize]):
902         (-[WebPreferences forceSoftwareWebGLRendering]): Deleted.
903         (-[WebPreferences setForceSoftwareWebGLRendering:]): Deleted.
904         * WebView/WebPreferencesPrivate.h:
905         * WebView/WebView.mm:
906         (-[WebView _preferencesChanged:]):
907
908 2019-07-13  Zalan Bujtas  <zalan@apple.com>
909
910         Cannot bring up custom media controls at all on v.youku.com
911         https://bugs.webkit.org/show_bug.cgi?id=199699
912         <rdar://problem/51835327>
913
914         Reviewed by Simon Fraser.
915
916         * WebCoreSupport/WebFrameLoaderClient.mm:
917         (WebFrameLoaderClient::actionDictionary const):
918         * WebView/WebFrame.mm:
919         (-[WebFrame elementAtPoint:]):
920         * WebView/WebHTMLView.mm:
921         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
922         * WebView/WebImmediateActionController.mm:
923         (-[WebImmediateActionController performHitTestAtPoint:]):
924
925 2019-07-12  Alex Christensen  <achristensen@webkit.org>
926
927         Begin unifying WebKitLegacy sources
928         https://bugs.webkit.org/show_bug.cgi?id=199730
929
930         Reviewed by Keith Miller.
931
932         * Configurations/WebKitLegacy.xcconfig:
933
934 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
935
936         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
937         https://bugs.webkit.org/show_bug.cgi?id=199625
938
939         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
940         with ENABLE(ACCESSIBILITY) in the code.
941
942         Additionally, the TestRunner code generator now honors the
943         Conditional IDL format.
944
945         Reviewed by Konstantin Tokarev.
946
947         * WebView/WebFrame.mm:
948         (-[WebFrame setAccessibleName:]):
949         (-[WebFrame enhancedAccessibilityEnabled]):
950         (-[WebFrame setEnhancedAccessibility:]):
951         (-[WebFrame accessibilityRoot]):
952
953 2019-07-08  Antoine Quint  <graouts@apple.com>
954
955         [Pointer Events] Enable only on the most recent version of the supported iOS family
956         https://bugs.webkit.org/show_bug.cgi?id=199562
957         <rdar://problem/52766511>
958
959         Reviewed by Dean Jackson.
960
961         * Configurations/FeatureDefines.xcconfig:
962
963 2019-07-03  Sam Weinig  <weinig@apple.com>
964
965         Adopt simple structured bindings in more places
966         https://bugs.webkit.org/show_bug.cgi?id=199247
967
968         Reviewed by Alex Christensen.
969
970         Replaces simple uses of std::tie() with structured bindings. Does not touch
971         uses of std::tie() that are not initial declarations, use std::ignore or in
972         case where the binding is captured by a lambda, as structured bindings don't
973         work for those cases yet.
974
975         * WebView/WebImmediateActionController.mm:
976         (-[WebImmediateActionController _animationControllerForText]):
977
978 2019-07-02  Devin Rousso  <drousso@apple.com>
979
980         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
981         https://bugs.webkit.org/show_bug.cgi?id=198956
982
983         Reviewed by Matt Baker.
984
985         * WebCoreSupport/WebInspectorClient.h:
986         * WebCoreSupport/WebInspectorClient.mm:
987         (WebInspectorFrontendClient::resetWindowState): Added.
988
989 2019-06-28  Timothy Hatcher  <timothy@apple.com>
990
991         Rename effectiveAppearanceIsInactive and useInactiveAppearance to better match UIUserInterfaceLevel.
992         https://bugs.webkit.org/show_bug.cgi?id=199336
993         rdar://problem/52348938
994
995         Reviewed by Tim Horton.
996
997         * WebView/WebView.mm:
998         (-[WebView _commonInitializationWithFrameName:groupName:]):
999         (-[WebView _setUseDarkAppearance:]):
1000         (-[WebView _useElevatedUserInterfaceLevel]):
1001         (-[WebView _setUseElevatedUserInterfaceLevel:]):
1002         (-[WebView _setUseDarkAppearance:useInactiveAppearance:]):
1003         (-[WebView _setUseDarkAppearance:useElevatedUserInterfaceLevel:]):
1004         (-[WebView _effectiveUserInterfaceLevelIsElevated]):
1005         (-[WebView viewDidChangeEffectiveAppearance]):
1006         (-[WebView _useInactiveAppearance]): Deleted.
1007         (-[WebView _setUseInactiveAppearance:]): Deleted.
1008         (-[WebView _effectiveAppearanceIsInactive]): Deleted.
1009         * WebView/WebViewPrivate.h:
1010
1011 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
1012
1013         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
1014         https://bugs.webkit.org/show_bug.cgi?id=199317
1015
1016         Reviewed by Michael Catanzaro.
1017
1018         While IconDatabase and all code using it was removed,
1019         ENABLE_ICONDATABASE still exists as build option and C++ macro.
1020
1021         * Configurations/FeatureDefines.xcconfig:
1022         * WebView/WebView.mm:
1023         (-[WebView _cacheFrameLoadDelegateImplementations]): Use PLATFORM(MAC)
1024         guard instead of ENABLE_ICONDATABASE, because ENABLE_ICONDATABASE was
1025         enabled for macOS only.
1026
1027 2019-06-27  Timothy Hatcher  <timothy@apple.com>
1028
1029         Move WebKitLegacy off of a couple AppKit ivars.
1030         https://bugs.webkit.org/show_bug.cgi?id=199279
1031         rdar://problem/34983438
1032
1033         Reviewed by Tim Horton.
1034
1035         * WebView/WebHTMLView.mm:
1036         (-[NSView _setSubviewsIvar:]): Added. Implement on older systems.
1037         (-[NSView _subviewsIvar]): Added. Ditto.
1038         (needsCursorRectsSupportAtPoint): Use _borderView property.
1039         (-[WebHTMLView _setAsideSubviews]): Use _subviewsIvar property.
1040         (-[NSWindow _web_borderView]): Deleted.
1041
1042 2019-06-27  Beth Dakin  <bdakin@apple.com>
1043
1044         Upstream use of MACCATALYST
1045         https://bugs.webkit.org/show_bug.cgi?id=199245
1046         rdar://problem/51687723
1047
1048         Reviewed by Tim Horton.
1049
1050         * Configurations/Base.xcconfig:
1051         * Configurations/FeatureDefines.xcconfig:
1052         * Configurations/SDKVariant.xcconfig:
1053
1054 2019-06-27  Saam Barati  <sbarati@apple.com>
1055
1056         Make WEBGPU enabled only on Mojave and later.
1057
1058         Rubber-stamped by Myles C. Maxfield.
1059
1060         * Configurations/FeatureDefines.xcconfig:
1061
1062 2019-06-16  Darin Adler  <darin@apple.com>
1063
1064         Rename AtomicString to AtomString
1065         https://bugs.webkit.org/show_bug.cgi?id=195276
1066
1067         Reviewed by Michael Catanzaro.
1068
1069         * many files: Let do-webcore-rename do the renaming.
1070
1071 2019-06-14  Megan Gardner  <megan_gardner@apple.com>
1072
1073         Move Synthetic Editing Commands to behind an experimental feature flag
1074         https://bugs.webkit.org/show_bug.cgi?id=198842
1075         <rdar://problem/50594700>
1076
1077         Reviewed by Simon Fraser.
1078
1079         Add plumbing for synthetic editing command feature flag.
1080
1081         * WebView/WebPreferenceKeysPrivate.h:
1082         * WebView/WebPreferences.mm:
1083         (+[WebPreferences initialize]):
1084         (-[WebPreferences syntheticEditingCommandsEnabled]):
1085         (-[WebPreferences setSyntheticEditingCommandsEnabled:]):
1086         * WebView/WebPreferencesPrivate.h:
1087         * WebView/WebView.mm:
1088         (-[WebView _preferencesChanged:]):
1089
1090 2019-06-13  Antoine Quint  <graouts@apple.com>
1091
1092         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
1093         https://bugs.webkit.org/show_bug.cgi?id=198800
1094         <rdar://problem/51679634>
1095
1096         Reviewed by Tim Horton.
1097
1098         Expose a private method that we need to use from DumpRenderTree.
1099
1100         * WebView/WebHTMLView.mm:
1101         (-[WebHTMLView _hitViewForEvent:]):
1102         * WebView/WebHTMLViewPrivate.h:
1103
1104 2019-06-10  Sam Weinig  <weinig@apple.com>
1105
1106         Remove Dashboard support
1107         https://bugs.webkit.org/show_bug.cgi?id=198615
1108
1109         Reviewed by Ryosuke Niwa.
1110
1111         Removes implementation, but keeps privatly exported interfaces and enums
1112         around until we can confirm there are no more users of them. 
1113
1114         * Configurations/FeatureDefines.xcconfig:
1115         * Plugins/WebBaseNetscapePluginView.mm:
1116         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1117         * WebCoreSupport/WebChromeClient.h:
1118         * WebCoreSupport/WebChromeClient.mm:
1119         (WebChromeClient::annotatedRegionsChanged): Deleted.
1120         * WebView/WebClipView.mm:
1121         (-[WebClipView _focusRingVisibleRect]):
1122         (-[WebClipView scrollWheel:]):
1123         * WebView/WebDashboardRegion.h:
1124         * WebView/WebDashboardRegion.mm:
1125         * WebView/WebHTMLView.mm:
1126         (-[WebHTMLView _updateMouseoverWithEvent:]):
1127         (-[WebHTMLView acceptsFirstMouse:]):
1128         (-[WebHTMLView setDataSource:]):
1129         * WebView/WebPreferences.mm:
1130         (cacheModelForMainBundle):
1131         * WebView/WebUIDelegatePrivate.h:
1132         * WebView/WebView.mm:
1133         (-[WebView _needsPreHTML5ParserQuirks]):
1134         (-[WebView _preferencesChanged:]):
1135         (-[WebView _addScrollerDashboardRegions:]):
1136         (-[WebView _dashboardRegions]):
1137         (-[WebView _setDashboardBehavior:to:]):
1138         (-[WebView _dashboardBehavior:]):
1139         (-[WebView _addControlRect:clip:fromView:toDashboardRegions:]): Deleted.
1140         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]): Deleted.
1141         (-[WebView _addScrollerDashboardRegions:from:]): Deleted.
1142         * WebView/WebViewData.h:
1143         * WebView/WebViewData.mm:
1144         (-[WebViewPrivate init]):
1145         * WebView/WebViewPrivate.h:
1146
1147 2019-06-10  Timothy Hatcher  <timothy@apple.com>
1148
1149         Integrate dark mode support for iOS.
1150         https://bugs.webkit.org/show_bug.cgi?id=198687
1151         rdar://problem/51545643
1152
1153         Reviewed by Tim Horton.
1154
1155         * Configurations/FeatureDefines.xcconfig:
1156
1157 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1158
1159         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
1160         https://bugs.webkit.org/show_bug.cgi?id=198664
1161
1162         Reviewed by Simon Fraser.
1163
1164         WK1 has to skip using DisplayRefreshMonitor when layers need to be updated.
1165
1166         * WebCoreSupport/WebChromeClient.h:
1167         (WebChromeClient::needsImmediateScheduleCompositingLayerFlush):
1168
1169 == Rolled over to ChangeLog-2019-06-05 ==