Source/JavaScriptCore:
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2
3         AX: Introduce a static accessibility tree
4         https://bugs.webkit.org/show_bug.cgi?id=193348
5         <rdar://problem/47203295>
6
7         Reviewed by Ryosuke Niwa.
8
9         * Configurations/FeatureDefines.xcconfig:
10
11 2019-01-25  Keith Rollin  <krollin@apple.com>
12
13         Update WebKitAdditions.xcconfig with correct order of variable definitions
14         https://bugs.webkit.org/show_bug.cgi?id=193793
15         <rdar://problem/47532439>
16
17         Reviewed by Alex Christensen.
18
19         XCBuild changes the way xcconfig variables are evaluated. In short,
20         all config file assignments are now considered in part of the
21         evaluation. When using the new build system and an .xcconfig file
22         contains multiple assignments of the same build setting:
23
24         - Later assignments using $(inherited) will inherit from earlier
25           assignments in the xcconfig file.
26         - Later assignments not using $(inherited) will take precedence over
27           earlier assignments. An assignment to a more general setting will
28           mask an earlier assignment to a less general setting. For example,
29           an assignment without a condition ('FOO = bar') will completely mask
30           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
31
32         This affects some of our .xcconfig files, in that sometimes platform-
33         or sdk-specific definitions appear before the general definitions.
34         Under the new evaluations rules, the general definitions alway take
35         effect because they always overwrite the more-specific definitions. The
36         solution is to swap the order, so that the general definitions are
37         established first, and then conditionally overwritten by the
38         more-specific definitions.
39
40         * Configurations/Version.xcconfig:
41         * Configurations/WebKitLegacy.xcconfig:
42
43 2019-01-25  David Kilzer  <ddkilzer@apple.com>
44
45         Move soft-linking of Lookup.framework out of LookupSPI.h
46         <https://webkit.org/b/193815>
47
48         Reviewed by Tim Horton.
49
50         * WebView/WebImmediateActionController.mm:
51         (-[WebImmediateActionController _animationControllerForText]):
52         * WebView/WebView.mm:
53         (-[WebView _prepareForDictionaryLookup]):
54         - Move soft-linking to LookupSoftLink.{h,mm}.
55
56 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
57
58         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
59         https://bugs.webkit.org/show_bug.cgi?id=193829
60
61         Reviewed by Tim Horton.
62
63         * WebCoreSupport/WebDragClient.mm:
64         (WebDragClient::didConcludeEditDrag):
65         * WebView/WebView.mm:
66         (-[WebView _requestStartDataInteraction:globalPosition:]):
67         (-[WebView _didConcludeEditDrag]):
68         (-[WebView _didConcludeEditDataInteraction]): Deleted.
69         * WebView/WebViewInternal.h:
70
71 2019-01-24  John Wilander  <wilander@apple.com>
72
73         Add Ad Click Attribution as an internal/experimental feature
74         https://bugs.webkit.org/show_bug.cgi?id=193685
75         <rdar://problem/47450399>
76
77         Reviewed by Brent Fulgham.
78
79         * WebView/WebPreferenceKeysPrivate.h:
80         * WebView/WebPreferences.mm:
81         (+[WebPreferences initialize]):
82         (-[WebPreferences adClickAttributionEnabled]):
83         (-[WebPreferences setAdClickAttributionEnabled:]):
84             Added support for experimental ad click attribution.
85         * WebView/WebPreferencesPrivate.h:
86         * WebView/WebView.mm:
87         (-[WebView _preferencesChanged:]):
88
89 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
90
91         Move FileSystem to WTF
92         https://bugs.webkit.org/show_bug.cgi?id=193602
93
94         Reviewed by Yusuke Suzuki.
95
96         * Misc/WebNSFileManagerExtras.mm:
97         * Storage/WebDatabaseProvider.mm:
98         * WebView/WebView.mm:
99
100 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
101
102         Fix the Apple Internal build. See <rdar://problem/47491383>.
103
104         Rubber-stamped by Tim Horton.
105
106         * WebCoreSupport/WebFrameLoaderClient.mm:
107
108 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
109
110         Clean up USE(WEB_THREAD)
111         https://bugs.webkit.org/show_bug.cgi?id=193698
112
113         Rubber-stamped by Tim Horton.
114
115         * Misc/WebCache.mm:
116         (+[WebCache emptyInMemoryResources]):
117         * WebCoreSupport/WebFrameLoaderClient.mm:
118         (-[WebFramePolicyListener use]):
119         * WebCoreSupport/WebGeolocationClient.mm:
120         (-[WebGeolocationPolicyListener allow]):
121         (-[WebGeolocationPolicyListener deny]):
122         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
123         * WebView/WebFrame.mm:
124         (-[WebFrame deviceOrientationChanged]):
125         * WebView/WebHTMLView.mm:
126         (hardwareKeyboardAvailabilityChangedCallback):
127         * WebView/WebView.mm:
128         (+[WebView _releaseMemoryNow]):
129         (+[WebView willEnterBackgroundWithCompletionHandler:]):
130         (-[WebView updateLayoutIgnorePendingStyleSheets]):
131         (-[WebView _dispatchUnloadEvent]):
132         (-[WebView _close]):
133         (-[WebView _preferencesChangedNotification:]):
134         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
135         (-[WebView goBack]):
136         (-[WebView goForward]):
137         (+[WebView _cacheModelChangedNotification:]):
138         (-[WebView stopLoading:]):
139         (-[WebView stopLoadingAndClear]):
140         (-[WebView reload:]):
141         (WebInstallMemoryPressureHandler):
142
143 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
144
145         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
146         https://bugs.webkit.org/show_bug.cgi?id=193706
147         <rdar://problem/44807048>
148
149         Reviewed by Ryosuke Niwa.
150
151         Use UndoStep::label().
152
153         * WebCoreSupport/WebEditorClient.h:
154         * WebCoreSupport/WebEditorClient.mm:
155         (-[WebUndoStep initWithUndoStep:]):
156         (+[WebUndoStep stepWithUndoStep:]):
157         (WebEditorClient::registerUndoOrRedoStep):
158         (WebEditorClient::registerUndoStep):
159         (WebEditorClient::registerRedoStep):
160
161 2019-01-22  Alex Christensen  <achristensen@webkit.org>
162
163         Move NetworkStorageSession ownership to NetworkProcess
164         https://bugs.webkit.org/show_bug.cgi?id=193580
165
166         Reviewed by Geoff Garen.
167
168         * Misc/WebCache.mm:
169         (+[WebCache clearCachedCredentials]):
170         * Misc/WebDownload.mm:
171         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
172         * Plugins/WebBaseNetscapePluginView.mm:
173         (WebKit::getAuthenticationInfo):
174         * WebCoreSupport/WebFrameNetworkingContext.mm:
175         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
176         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
177         (WebFrameNetworkingContext::storageSession const):
178         * WebView/WebPreferences.mm:
179         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
180         (+[WebPreferences _clearNetworkLoaderSession]):
181         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
182
183 2019-01-22  Daniel Bates  <dabates@apple.com>
184
185         [iOS] Interpret text key commands on keydown and app key commands on keypress
186         https://bugs.webkit.org/show_bug.cgi?id=192897
187         <rdar://problem/46857378>
188
189         Reviewed by Brent Fulgham.
190
191         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
192         is false) and keypress (isCharEvent is true), respectively.
193
194         * WebView/WebHTMLView.mm:
195         (-[WebHTMLView _handleEditingKeyEvent:]):
196
197 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
198
199         [css-logical] Implement flow-relative margin, padding and border shorthands
200         https://bugs.webkit.org/show_bug.cgi?id=188697
201
202         Reviewed by Simon Fraser and Antti Koivisto.
203
204         Add CSSLogicalEnabled runtime flag.
205
206         * WebView/WebPreferenceKeysPrivate.h:
207         * WebView/WebPreferences.mm:
208         (+[WebPreferences initialize]):
209         (-[WebPreferences cssLogicalEnabled]):
210         (-[WebPreferences setCSSLogicalEnabled:]):
211         * WebView/WebPreferencesPrivate.h:
212         * WebView/WebView.mm:
213         (-[WebView _preferencesChanged:]):
214
215 2019-01-15  Darin Adler  <darin@apple.com>
216
217         Use references rather than pointers for register/unregister functions, and more
218         https://bugs.webkit.org/show_bug.cgi?id=175028
219
220         Reviewed by Daniel Bates.
221
222         * WebCoreSupport/WebKitFullScreenListener.mm:
223         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
224         functions in Document; pass a reference.
225         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
226         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
227         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
228         * WebView/WebFullScreenController.mm:
229         (-[WebFullScreenController enterFullScreen:]): Ditto.
230         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
231         (-[WebFullScreenController exitFullScreen]): Ditto.
232         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
233         * WebView/WebFullScreenController.mm:
234         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
235
236 2019-01-12  Dan Bernstein  <mitz@apple.com>
237
238         [Cocoa] Avoid importing directly from subumbrella frameworks
239         https://bugs.webkit.org/show_bug.cgi?id=186016
240         <rdar://problem/40591038>
241
242         Reviewed by Sam Weinig.
243
244         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
245         * Carbon/CarbonWindowAdapter.mm: Ditto.
246         * Carbon/CarbonWindowFrame.m: Ditto.
247         * Carbon/HIViewAdapter.h: Ditto.
248         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
249           OTHER_CFLAGS_COCOA_TOUCH_NO.
250         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
251         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
252         * WebView/WebPDFView.h: Ditto.
253
254 2019-01-20  Antoine Quint  <graouts@apple.com>
255
256         Add a POINTER_EVENTS feature flag
257         https://bugs.webkit.org/show_bug.cgi?id=193577
258         <rdar://problem/47408511>
259
260         Unreviewed. Also enable Pointer Events for iosmac.
261
262         * Configurations/FeatureDefines.xcconfig:
263
264 2019-01-19  Antoine Quint  <graouts@apple.com>
265
266         Add a POINTER_EVENTS feature flag
267         https://bugs.webkit.org/show_bug.cgi?id=193577
268
269         Reviewed by Dean Jackson.
270
271         * Configurations/FeatureDefines.xcconfig:
272
273 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
274
275         Revert r238815, it broke WK1 video fullscreen on Mac
276         https://bugs.webkit.org/show_bug.cgi?id=193586
277         <rdar://problem/47358941>
278
279         Reviewed by Jer Noble.
280
281         * WebView/WebVideoFullscreenController.h: Added.
282         * WebView/WebVideoFullscreenController.mm: Added.
283         (SOFT_LINK_CLASS):
284         (-[WebVideoFullscreenController init]):
285         (-[WebVideoFullscreenController dealloc]):
286         (-[WebVideoFullscreenController fullscreenWindow]):
287         (-[WebVideoFullscreenController windowDidLoad]):
288         (-[WebVideoFullscreenController videoElement]):
289         (-[WebVideoFullscreenController setVideoElement:]):
290         (-[WebVideoFullscreenController clearFadeAnimation]):
291         (-[WebVideoFullscreenController windowDidExitFullscreen]):
292         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
293         (-[WebVideoFullscreenController videoElementRect]):
294         (-[WebVideoFullscreenController applicationDidResignActive:]):
295         (frameExpandedToRatioOfFrame):
296         (createBackgroundFullscreenWindow):
297         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
298         (-[WebVideoFullscreenController enterFullscreen:]):
299         (-[WebVideoFullscreenController exitFullscreen]):
300         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
301         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
302         (-[WebVideoFullscreenController _requestExit]):
303         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
304         (-[WebVideoFullscreenController requestExitFullscreen]):
305         (-[WebVideoFullscreenController fadeHUDIn]):
306         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
307         (-[WebVideoFullscreenController rateChanged:]):
308         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
309         (-[WebVideoFullscreenWindow dealloc]):
310         (-[WebVideoFullscreenWindow resignFirstResponder]):
311         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
312         (-[WebVideoFullscreenWindow mouseDown:]):
313         (-[WebVideoFullscreenWindow cancelOperation:]):
314         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
315         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
316         (-[WebVideoFullscreenWindow animationDidEnd:]):
317         (-[WebVideoFullscreenWindow mouseMoved:]):
318         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
319         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
320         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
321         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
322         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
323         (-[WebVideoFullscreenHUDWindow center]):
324         (-[WebVideoFullscreenHUDWindow keyDown:]):
325         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
326         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
327         (-[WebVideoFullscreenHUDWindowController init]):
328         (-[WebVideoFullscreenHUDWindowController dealloc]):
329         (-[WebVideoFullscreenHUDWindowController setArea:]):
330         (-[WebVideoFullscreenHUDWindowController keyDown:]):
331         (-[WebVideoFullscreenHUDWindowController delegate]):
332         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
333         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
334         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
335         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
336         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
337         (-[WebVideoFullscreenHUDWindowController closeWindow]):
338         (createMediaUIControl):
339         (createControlWithMediaUIControlType):
340         (createTimeTextField):
341         (createMediaUIBackgroundView):
342         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
343         (-[WebVideoFullscreenHUDWindowController updateVolume]):
344         (-[WebVideoFullscreenHUDWindowController updateTime]):
345         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
346         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
347         (-[WebVideoFullscreenHUDWindowController currentTime]):
348         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
349         (-[WebVideoFullscreenHUDWindowController duration]):
350         (-[WebVideoFullscreenHUDWindowController maxVolume]):
351         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
352         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
353         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
354         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
355         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
356         (-[WebVideoFullscreenHUDWindowController volume]):
357         (-[WebVideoFullscreenHUDWindowController setVolume:]):
358         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
359         (-[WebVideoFullscreenHUDWindowController updateRate]):
360         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
361         (-[WebVideoFullscreenHUDWindowController playing]):
362         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
363         (timeToString):
364         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
365         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
366         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
367         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
368         (-[WebVideoFullscreenHUDWindowController rewind:]):
369         (-[WebVideoFullscreenHUDWindowController fastForward:]):
370         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
371         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
372         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
373         * WebView/WebView.mm:
374         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
375         (-[WebView _exitVideoFullscreen]):
376
377 2019-01-18  Tim Horton  <timothy_horton@apple.com>
378
379         Get rid of ADVANCED_SPELL_CHECKING
380         https://bugs.webkit.org/show_bug.cgi?id=193592
381
382         Reviewed by Wenson Hsieh.
383
384         * WebCoreSupport/WebEditorClient.mm:
385         (insertionPointFromCurrentSelection):
386         (WebEditorClient::checkTextOfParagraph):
387         (WebEditorClient::getGuessesForWord):
388         (WebEditorClient::requestCandidatesForSelection):
389         (WebEditorClient::requestCheckingOfString):
390         * WebView/WebHTMLView.mm:
391         (-[WebHTMLView insertText:]):
392
393 2019-01-18  Jer Noble  <jer.noble@apple.com>
394
395         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
396         https://bugs.webkit.org/show_bug.cgi?id=189553
397
398         Reviewed by Tim Horton.
399
400         * Configurations/Base.xcconfig:
401         * Configurations/SDKVariant.xcconfig: Added.
402         * Configurations/WebKitLegacy.xcconfig:
403
404 2019-01-18  David Kilzer  <ddkilzer@apple.com>
405
406         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
407         <https://webkit.org/b/193568>
408         <rdar://problem/47381130>
409
410         Reviewed by Alex Christensen.
411
412         * WebView/WebView.mm:
413         - Remove unused soft-linking macros.
414         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
415         (-[WebUITextIndicatorData initWithImage:scale:]):
416         - Update to use exported PAL functions.
417
418 2019-01-17  Truitt Savell  <tsavell@apple.com>
419
420         Unreviewed, rolling out r240124.
421
422         This commit broke an internal build.
423
424         Reverted changeset:
425
426         "SDK_VARIANT build destinations should be separate from non-
427         SDK_VARIANT builds"
428         https://bugs.webkit.org/show_bug.cgi?id=189553
429         https://trac.webkit.org/changeset/240124
430
431 2019-01-17  Jer Noble  <jer.noble@apple.com>
432
433         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
434         https://bugs.webkit.org/show_bug.cgi?id=189553
435
436         Reviewed by Tim Horton.
437
438         * Configurations/Base.xcconfig:
439         * Configurations/SDKVariant.xcconfig: Added.
440         * Configurations/WebKitLegacy.xcconfig:
441
442 2019-01-17  Alex Christensen  <achristensen@webkit.org>
443
444         Stop using NetworkStorageSession::storageSession in WebCore
445         https://bugs.webkit.org/show_bug.cgi?id=193529
446
447         Reviewed by Tim Horton.
448
449         * Misc/WebCache.mm:
450         (+[WebCache addImageToCache:forURL:forFrame:]):
451         * WebView/WebView.mm:
452         (-[WebView _commonInitializationWithFrameName:groupName:]):
453         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
454
455 2019-01-15  Alex Christensen  <achristensen@webkit.org>
456
457         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
458         https://bugs.webkit.org/show_bug.cgi?id=193368
459
460         Reviewed by Geoff Garen.
461
462         * Misc/WebCache.mm:
463         (+[WebCache clearCachedCredentials]):
464         * Misc/WebDownload.mm:
465         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
466         * Plugins/WebBaseNetscapePluginView.mm:
467         (WebKit::getAuthenticationInfo):
468
469 2019-01-15  Alex Christensen  <achristensen@webkit.org>
470
471         Stop using CookiesStrategy
472         https://bugs.webkit.org/show_bug.cgi?id=161106
473
474         Reviewed by Don Olmstead and Antti Koivisto.
475
476         * Misc/WebCache.mm:
477         (+[WebCache addImageToCache:forURL:forFrame:]):
478         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
479         (WebKit::NetscapePluginInstanceProxy::getCookies):
480         (WebKit::NetscapePluginInstanceProxy::setCookies):
481         * Plugins/WebNetscapePluginView.mm:
482         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
483         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
484         * WebCoreSupport/WebPlatformStrategies.h:
485         * WebCoreSupport/WebPlatformStrategies.mm:
486         (WebPlatformStrategies::createCookiesStrategy): Deleted.
487         (WebPlatformStrategies::cookiesForDOM): Deleted.
488         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
489         (WebPlatformStrategies::cookiesEnabled): Deleted.
490         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
491         (WebPlatformStrategies::getRawCookies): Deleted.
492         (WebPlatformStrategies::deleteCookie): Deleted.
493         * WebView/WebView.mm:
494         (-[WebView _commonInitializationWithFrameName:groupName:]):
495         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
496
497 2019-01-15  Tim Horton  <timothy_horton@apple.com>
498
499         Cannot tab out of WKWebView on macOS
500         https://bugs.webkit.org/show_bug.cgi?id=161448
501         <rdar://problem/28100085>
502
503         Reviewed by Dean Jackson.
504
505         * WebCoreSupport/WebChromeClient.mm:
506         * WebView/WebView.mm:
507         Make use of SPI headers.
508
509 2019-01-14  Commit Queue  <commit-queue@webkit.org>
510
511         Unreviewed, rolling out r239901, r239909, r239910, r239912,
512         r239913, and r239914.
513         https://bugs.webkit.org/show_bug.cgi?id=193407
514
515         These revisions caused an internal failure (Requested by
516         Truitt on #webkit).
517
518         Reverted changesets:
519
520         "[Cocoa] Avoid importing directly from subumbrella frameworks"
521         https://bugs.webkit.org/show_bug.cgi?id=186016
522         https://trac.webkit.org/changeset/239901
523
524         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
525         https://trac.webkit.org/changeset/239909
526
527         "Tried to fix the build."
528         https://trac.webkit.org/changeset/239910
529
530         "Fixed iOS builds after r239910."
531         https://trac.webkit.org/changeset/239912
532
533         "More build fixing."
534         https://trac.webkit.org/changeset/239913
535
536         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
537         https://trac.webkit.org/changeset/239914
538
539 2019-01-14  Mark Lam  <mark.lam@apple.com>
540
541         Re-enable ability to build --cloop builds.
542         https://bugs.webkit.org/show_bug.cgi?id=192955
543         <rdar://problem/46882363>
544
545         Reviewed by Saam barati and Keith Miller.
546
547         * Configurations/FeatureDefines.xcconfig:
548
549 2019-01-13  Dan Bernstein  <mitz@apple.com>
550
551         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
552
553         Patch by Keith Rollin.
554
555         * WebView/PDFViewSPI.h:
556
557 2019-01-12  Timothy Hatcher  <timothy@apple.com>
558
559         Have prefers-color-scheme: light always match on macOS versions before Mojave.
560         https://bugs.webkit.org/show_bug.cgi?id=191655
561         rdar://problem/46074680
562
563         Reviewed by Megan Gardner.
564
565         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
566         * WebView/WebView.mm:
567         (-[WebView _effectiveAppearanceIsDark]):
568
569 2019-01-12  Dan Bernstein  <mitz@apple.com>
570
571         [Cocoa] Avoid importing directly from subumbrella frameworks
572         https://bugs.webkit.org/show_bug.cgi?id=186016
573         <rdar://problem/40591038>
574
575         Reviewed by Sam Weinig.
576
577         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
578         * Carbon/CarbonWindowAdapter.mm: Ditto.
579         * Carbon/CarbonWindowFrame.m: Ditto.
580         * Carbon/HIViewAdapter.h: Ditto.
581         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
582           OTHER_CFLAGS_COCOA_TOUCH_NO.
583         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
584         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
585         * WebView/WebPDFView.h: Ditto.
586
587 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
588
589         Enable visual viewport API by default
590         https://bugs.webkit.org/show_bug.cgi?id=193376
591
592         Reviewed by Simon Fraser.
593
594         * WebView/WebPreferences.mm:
595         (+[WebPreferences initialize]):
596
597 2019-01-11  John Wilander  <wilander@apple.com>
598
599         Compile out Web API Statistics Collection
600         https://bugs.webkit.org/show_bug.cgi?id=193370
601         <rdar://problem/45388584>
602
603         Reviewed by Brent Fulgham.
604
605         * Configurations/FeatureDefines.xcconfig:
606             Defined ENABLE_WEB_API_STATISTICS, off by default.
607
608 2019-01-08  Alex Christensen  <achristensen@webkit.org>
609
610         Stop using NetworkStorageSession in WebProcess
611         https://bugs.webkit.org/show_bug.cgi?id=193236
612
613         Reviewed by Don Olmstead.
614
615         * WebCoreSupport/WebFrameNetworkingContext.h:
616         * WebCoreSupport/WebFrameNetworkingContext.mm:
617         (WebFrameNetworkingContext::storageSession const):
618         * WebCoreSupport/WebPlatformStrategies.h:
619         * WebCoreSupport/WebPlatformStrategies.mm:
620         (WebPlatformStrategies::cookiesForDOM):
621         (WebPlatformStrategies::setCookiesFromDOM):
622         (WebPlatformStrategies::cookiesEnabled):
623         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
624         (WebPlatformStrategies::getRawCookies):
625         (WebPlatformStrategies::deleteCookie):
626         * WebView/WebView.mm:
627         (-[WebView _cachedResponseForURL:]):
628         (-[WebView _clearCredentials]):
629
630 2019-01-08  Alex Christensen  <achristensen@webkit.org>
631
632         Unreviewed, rolling out r239727.
633
634         Broke API tests
635
636         Reverted changeset:
637
638         "Stop using NetworkStorageSession in WebProcess"
639         https://bugs.webkit.org/show_bug.cgi?id=193236
640         https://trac.webkit.org/changeset/239727
641
642 2019-01-08  Alex Christensen  <achristensen@webkit.org>
643
644         Stop using NetworkStorageSession in WebProcess
645         https://bugs.webkit.org/show_bug.cgi?id=193236
646
647         Reviewed by Don Olmstead.
648
649         * WebCoreSupport/WebFrameNetworkingContext.h:
650         * WebCoreSupport/WebFrameNetworkingContext.mm:
651         (WebFrameNetworkingContext::storageSession const):
652         * WebView/WebView.mm:
653         (-[WebView _cachedResponseForURL:]):
654         (-[WebView _clearCredentials]):
655
656 2019-01-07  David Kilzer  <ddkilzer@apple.com>
657
658         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
659         <https://webkit.org/b/193056>
660
661         Reviewed by Alex Christensen.
662
663         * Plugins/Hosted/NetscapePluginHostProxy.h:
664         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
665         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
666         (WebKit::NetscapePluginInstanceProxy::enumerate):
667         (WebKit::NetscapePluginInstanceProxy::marshalValue):
668         (WebKit::NetscapePluginInstanceProxy::marshalValues):
669         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
670         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
671         * Plugins/Hosted/ProxyInstance.mm:
672         (WebKit::ProxyInstance::invoke):
673         * WebCoreSupport/WebGeolocationClient.mm:
674         * WebView/WebDataSource.mm:
675         (-[WebDataSource _receivedData:]):
676         * WebView/WebView.mm:
677         (-[WebView _cachedResponseForURL:]):
678         - Remove '*' from RetainPtr<> type.
679
680 2019-01-04  Alex Christensen  <achristensen@webkit.org>
681
682         Progress towards fixing Mac CMake build
683         https://bugs.webkit.org/show_bug.cgi?id=193105
684
685         Reviewed by Don Olmstead.
686
687         * WebKitPrefix.h:
688
689 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
690
691         Web Inspector: Use save sheet instead of dialog where possible
692         https://bugs.webkit.org/show_bug.cgi?id=193160
693         <rdar://problem/37399759>
694
695         Reviewed by Devin Rousso.
696
697         * WebCoreSupport/WebInspectorClient.mm:
698         (WebInspectorFrontendClient::save):
699
700 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
701
702         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
703         https://bugs.webkit.org/show_bug.cgi?id=193129
704
705         Reviewed by Tim Horton.
706
707         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
708
709         * WebCoreSupport/WebEditorClient.mm:
710         (WebEditorClient::registerUndoOrRedoStep):
711         (undoNameForEditAction): Deleted.
712
713 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
714
715         Add support for using the current text selection as the find string on iOS
716         https://bugs.webkit.org/show_bug.cgi?id=193034
717         <rdar://problem/45138739>
718
719         Reviewed by Tim Horton.
720
721         Add a method stub for WebKitLegacy.
722
723         * WebCoreSupport/WebEditorClient.h:
724
725 2019-01-01  Jeff Miller  <jeffm@apple.com>
726
727         Update user-visible copyright strings to include 2019
728         https://bugs.webkit.org/show_bug.cgi?id=192811
729
730         Reviewed by Mark Lam.
731
732         * Info.plist:
733
734 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
735
736         Use Ref<> as much as possible
737         https://bugs.webkit.org/show_bug.cgi?id=192808
738
739         Reviewed by Alex Christensen.
740
741         * DOM/DOM.mm:
742         (-[DOMNode getPreviewSnapshotImage:andRects:]):
743         * Plugins/Hosted/NetscapePluginHostManager.mm:
744         (WebKit::NetscapePluginHostManager::instantiatePlugin):
745         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
746         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
747         (WebKit::NetscapePluginInstanceProxy::loadRequest):
748         * Plugins/WebNetscapePluginView.mm:
749         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
750         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
751         * WebCoreSupport/WebContextMenuClient.mm:
752         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
753         * WebCoreSupport/WebFrameLoaderClient.mm:
754         (WebFrameLoaderClient::transitionToCommittedForNewPage):
755         * WebView/WebFrame.mm:
756         (-[WebFrame getDictationResultRanges:andMetadatas:]):
757         * WebView/WebHTMLView.mm:
758         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
759         * WebView/WebView.mm:
760         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
761         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
762
763 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
764
765         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
766         https://bugs.webkit.org/show_bug.cgi?id=192821
767
768         Reviewed by Chris Dumez.
769
770         When a window becomes occluded, the window server informs the application.
771         This should be used to suspend any work that is not visible by the user.
772
773         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
774         In some cases, that lead to performance impact (see radar).
775
776         This patch adds an observer for the occlusion notification. I tried to stick
777         with the same names used by WebKit2.
778
779         * WebView/WebView.mm:
780         (-[WebView _isViewVisible]):
781         (-[WebView addWindowObserversForWindow:]):
782         (-[WebView removeWindowObservers]):
783         (-[WebView _windowDidChangeOcclusionState:]):
784
785 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
786
787         [WebAuthN] Add a runtime flag for local authenticator
788         https://bugs.webkit.org/show_bug.cgi?id=192792
789         <rdar://problem/46798738>
790
791         Reviewed by Brent Fulgham.
792
793         * WebView/WebPreferenceKeysPrivate.h:
794         * WebView/WebPreferences.mm:
795         (+[WebPreferences initialize]):
796         (-[WebPreferences webAuthenticationEnabled]): Deleted.
797         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
798         * WebView/WebPreferencesPrivate.h:
799         * WebView/WebView.mm:
800         (-[WebView _preferencesChanged:]):
801
802 2018-12-20  Chris Dumez  <cdumez@apple.com>
803
804         Use Optional::valueOr() instead of Optional::value_or()
805         https://bugs.webkit.org/show_bug.cgi?id=192933
806
807         Reviewed by Geoffrey Garen.
808
809         * WebCoreSupport/WebSecurityOrigin.mm:
810         (-[WebSecurityOrigin port]):
811
812 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
813
814         Unreviewed, rolling out r239417.
815
816         Introduced two API test failures on macOS.
817
818         Reverted changeset:
819
820         "<rdar://problem/46194315> macOS: WebKit1 does not handle
821         occlusion changes"
822         https://bugs.webkit.org/show_bug.cgi?id=192821
823         https://trac.webkit.org/changeset/239417
824
825 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
826
827         WKWebView default UA doesn't freeze the build number
828         https://bugs.webkit.org/show_bug.cgi?id=192809
829         <rdar://problem/44687185>
830
831         Reviewed by Andy Estes.
832
833         Always reports the frozen build number.
834
835         * WebView/WebView.mm:
836         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
837         actual build number through this method call.
838         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
839
840 2018-12-19  Chris Dumez  <cdumez@apple.com>
841
842         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
843         https://bugs.webkit.org/show_bug.cgi?id=192728
844         <rdar://problem/46746779>
845
846         Reviewed by Geoff Garen.
847
848         * DOM/*:
849         * Plugins/*:
850         * WebCoreSupport/*:
851         * WebView/*:
852
853 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
854
855         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
856         https://bugs.webkit.org/show_bug.cgi?id=192821
857
858         Reviewed by Chris Dumez.
859
860         When a window becomes occluded, the window server informs the application.
861         This should be used to suspend any work that is not visible by the user.
862
863         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
864         In some cases, that lead to performance impact (see radar).
865
866         This patch adds an observer for the occlusion notification. I tried to stick
867         with the same names used by WebKit2.
868
869         * WebView/WebView.mm:
870         (-[WebView _isViewVisible]):
871         (-[WebView addWindowObserversForWindow:]):
872         (-[WebView removeWindowObservers]):
873         (-[WebView _windowDidChangeOcclusionState:]):
874
875 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
876
877         Allow clients to set the navigator platform
878         https://bugs.webkit.org/show_bug.cgi?id=192735
879
880         Reviewed by Tim Horton.
881
882         Add stubs to fill out the added functionality in FrameLoaderClient.
883
884         * WebCoreSupport/WebFrameLoaderClient.h:
885         * WebCoreSupport/WebFrameLoaderClient.mm:
886         (WebFrameLoaderClient::navigatorPlatform):
887
888 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
889
890         offsetLeft and offsetParent should adjust across shadow boundaries
891         https://bugs.webkit.org/show_bug.cgi?id=157437
892         <rdar://problem/26154021>
893
894         Reviewed by Simon Fraser.
895
896         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
897
898         * DOM/DOMElement.mm:
899         (-[DOMElement offsetLeft]):
900         (-[DOMElement offsetTop]):
901         (-[DOMElement offsetParent]):
902
903 2018-12-17  Zalan Bujtas  <zalan@apple.com>
904
905         Unreviewed build fix.
906
907         * WebView/WebFrame.mm:
908         (-[WebFrame getDictationResultRanges:andMetadatas:]):
909
910 2018-12-15  Darin Adler  <darin@apple.com>
911
912         Use warning-ignoring macros more consistently and simply
913         https://bugs.webkit.org/show_bug.cgi?id=192743
914
915         Reviewed by Mark Lam.
916
917         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
918         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
919         compilers in Objective-C++ code.
920
921         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
922         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
923         accomodate non-clang compilers here. Also use #pragma once, add a missing
924         "explicit" and fix conditionals.
925
926 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
927
928         Make TextInputController.legacyAttributedString take DOM nodes and offsets
929         https://bugs.webkit.org/show_bug.cgi?id=192653
930
931         Reviewed by Wenson Hsieh.
932
933         * WebView/WebHTMLView.mm:
934         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
935
936 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
937
938         Implement feature flag for CSS Typed OM
939         https://bugs.webkit.org/show_bug.cgi?id=192610
940
941         Reviewed by Ryosuke Niwa.
942
943         * Configurations/FeatureDefines.xcconfig:
944
945 2018-12-11  Tim Horton  <timothy_horton@apple.com>
946
947         WebCore shouldn't have a Objective-C class named NSCursor
948         https://bugs.webkit.org/show_bug.cgi?id=192602
949         <rdar://problem/46615532>
950
951         Reviewed by Wenson Hsieh.
952
953         * WebView/WebFrameView.mm:
954         (-[WebFrameView keyDown:keyDown:]):
955         * WebView/WebHTMLView.mm:
956         (-[WebHTMLView keyDown:]):
957         (-[WebHTMLView performKeyEquivalent:]):
958         Only use NSCursor on macOS.
959
960 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
961
962         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
963         https://bugs.webkit.org/show_bug.cgi?id=192573
964
965         Reviewed by Simon Fraser.
966
967         * Configurations/FeatureDefines.xcconfig:
968
969 2018-12-10  Antti Koivisto  <antti@apple.com>
970
971         Rename "forced style recalc" to "full style rebuild"
972         https://bugs.webkit.org/show_bug.cgi?id=192572
973
974         Reviewed by Zalan Bujtas.
975
976         * WebView/WebHTMLView.mm:
977         (-[WebHTMLView setNeedsToApplyStyles:]):
978
979 2018-12-10  Darin Adler  <darin@apple.com>
980
981         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
982         https://bugs.webkit.org/show_bug.cgi?id=192533
983         rdar://problem/45732710
984
985         Reviewed by Anders Carlsson.
986
987         * Plugins/Hosted/NetscapePluginHostProxy.mm:
988         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
989
990 2018-12-10  Darin Adler  <darin@apple.com>
991
992         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
993         https://bugs.webkit.org/show_bug.cgi?id=192532
994         rdar://problem/45731047
995
996         Reviewed by Chris Dumez.
997
998         * Plugins/Hosted/NetscapePluginHostManager.mm:
999         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1000         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1001         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1002
1003 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1004
1005         Turn WritingDirection into an enum class
1006         https://bugs.webkit.org/show_bug.cgi?id=192401
1007         Work towards <rdar://problem/42075638>
1008
1009         Reviewed by Dan Bernstein.
1010
1011         Change WritingDirection from an enum to an enum class. No change in behavior.
1012
1013         * WebView/WebHTMLView.mm:
1014         (-[WebHTMLView toggleBaseWritingDirection:]):
1015         (-[WebHTMLView changeBaseWritingDirection:]):
1016         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1017
1018 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1019
1020         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1021         https://bugs.webkit.org/show_bug.cgi?id=192272
1022
1023         Reviewed by Brady Eidson.
1024
1025         * WebCoreSupport/WebFrameLoaderClient.h:
1026         * WebCoreSupport/WebFrameLoaderClient.mm:
1027         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1028
1029 2018-12-03  Jer Noble  <jer.noble@apple.com>
1030
1031         Get rid of old, dead Mac video fullscreen code.
1032         https://bugs.webkit.org/show_bug.cgi?id=192315
1033
1034         Reviewed by Eric Carlson.
1035
1036         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1037         is no longer supported in the Mac port.
1038
1039         * WebView/WebVideoFullscreenController.h: Removed.
1040         * WebView/WebVideoFullscreenController.mm: Removed.
1041         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1042         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1043         * WebView/WebView.mm:
1044         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1045         (-[WebView _exitVideoFullscreen]):
1046
1047 2018-12-03  Daniel Bates  <dabates@apple.com>
1048
1049         [iOS] Do not handle key events that are key commands
1050         https://bugs.webkit.org/show_bug.cgi?id=191608
1051         <rdar://problem/46046013>
1052
1053         Reviewed by Ryosuke Niwa.
1054
1055         A key down event may be associated with a key command. If it is then we want to execute the
1056         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1057         event as a key command to find out.
1058
1059         * WebView/WebHTMLView.mm:
1060         (-[WebHTMLView _handleEditingKeyEvent:]):
1061
1062 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1063
1064         Add a runtime feature flag for LayoutFormattingContext.
1065         https://bugs.webkit.org/show_bug.cgi?id=192280
1066
1067         Reviewed by Simon Fraser.
1068
1069         * Configurations/FeatureDefines.xcconfig:
1070
1071 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1072
1073         Move URL from WebCore to WTF
1074         https://bugs.webkit.org/show_bug.cgi?id=190234
1075
1076         Reviewed by Keith Miller.
1077
1078         * DOM/DOMAttr.mm:
1079         * DOM/DOMBlob.mm:
1080         * DOM/DOMCSSCharsetRule.mm:
1081         * DOM/DOMCSSImportRule.mm:
1082         * DOM/DOMCSSMediaRule.mm:
1083         * DOM/DOMCSSPageRule.mm:
1084         * DOM/DOMCSSPrimitiveValue.mm:
1085         * DOM/DOMCSSRule.mm:
1086         * DOM/DOMCSSStyleDeclaration.mm:
1087         * DOM/DOMCSSStyleRule.mm:
1088         * DOM/DOMCSSStyleSheet.mm:
1089         * DOM/DOMCSSValue.mm:
1090         * DOM/DOMCharacterData.mm:
1091         * DOM/DOMCounter.mm:
1092         * DOM/DOMDocument.mm:
1093         * DOM/DOMDocumentFragment.mm:
1094         * DOM/DOMDocumentType.mm:
1095         * DOM/DOMEvent.mm:
1096         * DOM/DOMFile.mm:
1097         * DOM/DOMHTMLAnchorElement.mm:
1098         * DOM/DOMHTMLAppletElement.mm:
1099         * DOM/DOMHTMLAreaElement.mm:
1100         * DOM/DOMHTMLBRElement.mm:
1101         * DOM/DOMHTMLBaseElement.mm:
1102         * DOM/DOMHTMLBaseFontElement.mm:
1103         * DOM/DOMHTMLBodyElement.mm:
1104         * DOM/DOMHTMLButtonElement.mm:
1105         * DOM/DOMHTMLCanvasElement.mm:
1106         * DOM/DOMHTMLCollection.mm:
1107         * DOM/DOMHTMLDivElement.mm:
1108         * DOM/DOMHTMLDocument.mm:
1109         * DOM/DOMHTMLElement.mm:
1110         * DOM/DOMHTMLEmbedElement.mm:
1111         * DOM/DOMHTMLFieldSetElement.mm:
1112         * DOM/DOMHTMLFontElement.mm:
1113         * DOM/DOMHTMLFormElement.mm:
1114         * DOM/DOMHTMLFrameElement.mm:
1115         * DOM/DOMHTMLFrameSetElement.mm:
1116         * DOM/DOMHTMLHRElement.mm:
1117         * DOM/DOMHTMLHeadElement.mm:
1118         * DOM/DOMHTMLHeadingElement.mm:
1119         * DOM/DOMHTMLHtmlElement.mm:
1120         * DOM/DOMHTMLIFrameElement.mm:
1121         * DOM/DOMHTMLImageElement.mm:
1122         * DOM/DOMHTMLInputElement.mm:
1123         * DOM/DOMHTMLLIElement.mm:
1124         * DOM/DOMHTMLLabelElement.mm:
1125         * DOM/DOMHTMLLegendElement.mm:
1126         * DOM/DOMHTMLLinkElement.mm:
1127         * DOM/DOMHTMLMapElement.mm:
1128         * DOM/DOMHTMLMarqueeElement.mm:
1129         * DOM/DOMHTMLMediaElement.mm:
1130         * DOM/DOMHTMLMetaElement.mm:
1131         * DOM/DOMHTMLModElement.mm:
1132         * DOM/DOMHTMLOListElement.mm:
1133         * DOM/DOMHTMLObjectElement.mm:
1134         * DOM/DOMHTMLOptGroupElement.mm:
1135         * DOM/DOMHTMLOptionElement.mm:
1136         * DOM/DOMHTMLOptionsCollection.mm:
1137         * DOM/DOMHTMLParagraphElement.mm:
1138         * DOM/DOMHTMLParamElement.mm:
1139         * DOM/DOMHTMLQuoteElement.mm:
1140         * DOM/DOMHTMLScriptElement.mm:
1141         * DOM/DOMHTMLSelectElement.mm:
1142         * DOM/DOMHTMLStyleElement.mm:
1143         * DOM/DOMHTMLTableCaptionElement.mm:
1144         * DOM/DOMHTMLTableCellElement.mm:
1145         * DOM/DOMHTMLTableColElement.mm:
1146         * DOM/DOMHTMLTableElement.mm:
1147         * DOM/DOMHTMLTableRowElement.mm:
1148         * DOM/DOMHTMLTableSectionElement.mm:
1149         * DOM/DOMHTMLTitleElement.mm:
1150         * DOM/DOMHTMLUListElement.mm:
1151         * DOM/DOMHTMLVideoElement.mm:
1152         * DOM/DOMKeyboardEvent.mm:
1153         * DOM/DOMMediaList.mm:
1154         * DOM/DOMMouseEvent.mm:
1155         * DOM/DOMMutationEvent.mm:
1156         * DOM/DOMNamedNodeMap.mm:
1157         * DOM/DOMProcessingInstruction.mm:
1158         * DOM/DOMRange.mm:
1159         * DOM/DOMStyleSheet.mm:
1160         * DOM/DOMText.mm:
1161         * DOM/DOMTextEvent.mm:
1162         * DOM/DOMTokenList.mm:
1163         * DOM/DOMUIEvent.mm:
1164         * DOM/DOMXPathResult.mm:
1165         * History/WebHistoryItem.mm:
1166         * Misc/WebNSURLExtras.mm:
1167         (-[NSURL _web_userVisibleString]):
1168         (-[NSURL _web_URLByRemovingUserInfo]):
1169         (-[NSURL _web_dataForURLComponentType:]):
1170         (-[NSURL _web_schemeData]):
1171         (-[NSURL _web_hostData]):
1172         * Misc/WebUserContentURLPattern.mm:
1173         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1174         * Plugins/WebNetscapePluginStream.h:
1175         (WebNetscapePluginStream::setRequestURL):
1176         * WebCoreSupport/WebChromeClient.h:
1177         * WebCoreSupport/WebChromeClient.mm:
1178         (WebChromeClient::signedPublicKeyAndChallengeString const):
1179         * WebCoreSupport/WebContextMenuClient.h:
1180         * WebCoreSupport/WebContextMenuClient.mm:
1181         * WebCoreSupport/WebDragClient.h:
1182         * WebCoreSupport/WebFrameLoaderClient.h:
1183         * WebCoreSupport/WebFrameLoaderClient.mm:
1184         (WebFrameLoaderClient::updateGlobalHistory):
1185         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1186         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1187         (WebPaymentCoordinatorClient::showPaymentUI):
1188         * WebCoreSupport/WebPlatformStrategies.h:
1189         * WebCoreSupport/WebPlatformStrategies.mm:
1190         (WebPlatformStrategies::readURLFromPasteboard):
1191         * WebCoreSupport/WebPluginInfoProvider.h:
1192         * WebCoreSupport/WebPluginInfoProvider.mm:
1193         (WebPluginInfoProvider::webVisiblePluginInfo):
1194         * WebCoreSupport/WebSecurityOrigin.mm:
1195         * WebCoreSupport/WebVisitedLinkStore.h:
1196         * WebView/WebDataSource.mm:
1197         * WebView/WebFrame.mm:
1198         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1199         * WebView/WebImmediateActionController.mm:
1200         (-[WebImmediateActionController _defaultAnimationController]):
1201         * WebView/WebPDFView.mm:
1202         * WebView/WebScriptDebugger.mm:
1203         * WebView/WebViewInternal.h:
1204
1205 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1206
1207         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1208         https://bugs.webkit.org/show_bug.cgi?id=192197
1209
1210         Reviewed by Jiewen Tan.
1211
1212         * Configurations/FeatureDefines.xcconfig:
1213         * WebCoreSupport/WebChromeClient.h:
1214         * WebCoreSupport/WebChromeClient.mm:
1215
1216 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1217
1218         Remove dead code from an earlier attempt at implementing safe browsing
1219         https://bugs.webkit.org/show_bug.cgi?id=192067
1220
1221         Reviewed by Chris Dumez.
1222
1223         * WebCoreSupport/WebFrameLoaderClient.h:
1224         * WebCoreSupport/WebFrameLoaderClient.mm:
1225         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1226
1227 2018-11-27  Mark Lam  <mark.lam@apple.com>
1228
1229         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1230         https://bugs.webkit.org/show_bug.cgi?id=192055
1231         <rdar://problem/46288783>
1232
1233         Reviewed by Saam Barati.
1234
1235         * Configurations/FeatureDefines.xcconfig:
1236
1237 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1238
1239         Make it possible to insert editable images with a gesture
1240         https://bugs.webkit.org/show_bug.cgi?id=191937
1241
1242         Reviewed by Wenson Hsieh.
1243
1244         * WebCoreSupport/WebEditorClient.mm:
1245         (undoNameForEditAction):
1246         Add a undo name.
1247
1248 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1249
1250         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1251         https://bugs.webkit.org/show_bug.cgi?id=191945
1252
1253         Reviewed by Anders Carlsson.
1254
1255         * WebCoreSupport/WebEditorClient.mm:
1256         (undoNameForEditAction):
1257
1258 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1259
1260         Enable drag and drop support for iOSMac
1261         https://bugs.webkit.org/show_bug.cgi?id=191818
1262         <rdar://problem/43907454>
1263
1264         Reviewed by Dean Jackson.
1265
1266         * Configurations/FeatureDefines.xcconfig:
1267
1268 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1269
1270         Address post-review feedback after r238438
1271         https://bugs.webkit.org/show_bug.cgi?id=191913
1272
1273         Reviewed by Ryosuke Niwa.
1274
1275         * WebView/WebFrame.mm:
1276         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1277         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1278         * WebView/WebView.mm:
1279         (-[WebView setSelectedDOMRange:affinity:]):
1280
1281 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1282
1283         Web Inspector: "Reload Web Inspector" button no longer partially works
1284         https://bugs.webkit.org/show_bug.cgi?id=191773
1285         <rdar://problem/46139932>
1286
1287         Reviewed by Devin Rousso.
1288
1289         * WebCoreSupport/WebInspectorClient.h:
1290         * WebCoreSupport/WebInspectorClient.mm:
1291         (WebInspectorFrontendClient::reopen):
1292
1293 2018-11-17  Devin Rousso  <drousso@apple.com>
1294
1295         Web Inspector: Network: add button to show system certificate dialog
1296         https://bugs.webkit.org/show_bug.cgi?id=191458
1297         <rdar://problem/45977019>
1298
1299         Reviewed by Joseph Pecoraro.
1300
1301         * WebCoreSupport/WebInspectorClient.h:
1302         * WebCoreSupport/WebInspectorClient.mm:
1303         (WebInspectorFrontendClient::showCertificate): Added.
1304
1305         * Configurations/WebKitLegacy.xcconfig:
1306
1307 2018-11-15  Truitt Savell  <tsavell@apple.com>
1308
1309         Unreviewed, rolling out r238244.
1310
1311         Caused High Sierra test runs to fail early with 50 crashes and
1312         casued 25 API failures.
1313
1314         Reverted changeset:
1315
1316         "[css-logical] Implement flow-relative margin, padding and
1317         border shorthands"
1318         https://bugs.webkit.org/show_bug.cgi?id=188697
1319         https://trac.webkit.org/changeset/238244
1320
1321 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1322
1323         [css-logical] Implement flow-relative margin, padding and border shorthands
1324         https://bugs.webkit.org/show_bug.cgi?id=188697
1325
1326         Reviewed by Simon Fraser and Antti Koivisto.
1327
1328         Add CSSLogicalEnabled runtime flag.
1329
1330         * WebView/WebPreferenceKeysPrivate.h:
1331         * WebView/WebPreferences.mm:
1332         (+[WebPreferences initialize]):
1333         (-[WebPreferences cssLogicalEnabled]):
1334         (-[WebPreferences setCSSLogicalEnabled:]):
1335         * WebView/WebPreferencesPrivate.h:
1336         * WebView/WebView.mm:
1337         (-[WebView _preferencesChanged:]):
1338
1339 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1340
1341         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1342         https://bugs.webkit.org/show_bug.cgi?id=191612
1343
1344         Reviewed by Matt Baker.
1345
1346         * WebCoreSupport/WebInspectorClient.mm:
1347         (-[WebInspectorWindowController destroyInspectorView]):
1348
1349 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1350
1351         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1352         https://bugs.webkit.org/show_bug.cgi?id=191494
1353         <rdar://problem/45469854>
1354
1355         Reviewed by Devin Rousso.
1356
1357         * WebCoreSupport/WebInspectorClient.h:
1358         WebKitLegacy will still have remote inspection of the Page directly.
1359
1360 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1361
1362         Make compositing updates incremental
1363         https://bugs.webkit.org/show_bug.cgi?id=90342
1364
1365         Reviewed by Antti Koivisto.
1366
1367         Fix spelling error.
1368
1369         * WebView/WebView.mm:
1370         (-[WebView _setMediaLayer:forPluginView:]):
1371
1372 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1373
1374         Implement a new edit command to change the enclosing list type
1375         https://bugs.webkit.org/show_bug.cgi?id=191487
1376         <rdar://problem/45955922>
1377
1378         Reviewed by Ryosuke Niwa.
1379
1380         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1381
1382         * WebCoreSupport/WebEditorClient.mm:
1383         (undoNameForEditAction):
1384
1385 2018-11-11  Daniel Bates  <dabates@apple.com>
1386
1387         [iOS] Draw caps lock indicator in password fields
1388         https://bugs.webkit.org/show_bug.cgi?id=190565
1389         <rdar://problem/45262343>
1390
1391         Reviewed by Dean Jackson.
1392
1393         Update the caps lock state when a hardware keyboard is attached or detached.
1394
1395         * WebView/WebHTMLView.mm:
1396         (hardwareKeyboardAvailabilityChangedCallback): Added.
1397         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1398         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1399
1400 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1401
1402         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1403         https://bugs.webkit.org/show_bug.cgi?id=191492
1404
1405         Reviewed by Alex Christensen.
1406
1407         * Carbon/HIWebView.mm:
1408         * Misc/WebNSFileManagerExtras.mm:
1409         * Misc/WebNSURLExtras.mm:
1410         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1411         * Plugins/WebBasePluginPackage.mm:
1412         * Plugins/WebPluginContainerCheck.mm:
1413         * WebCoreSupport/WebCachedFramePlatformData.h:
1414         * WebCoreSupport/WebDeviceOrientationClient.mm:
1415         * WebView/WebDelegateImplementationCaching.mm:
1416         * WebView/WebHTMLView.mm:
1417         * WebView/WebPDFRepresentation.mm:
1418         * WebView/WebPolicyDelegate.mm:
1419         * WebView/WebView.mm:
1420
1421 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1422
1423         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1424         https://bugs.webkit.org/show_bug.cgi?id=191492
1425
1426         Reviewed by Alex Christensen.
1427
1428         * Carbon/HIWebView.mm:
1429         (UpdateCommandStatus):
1430         * Misc/WebNSFileManagerExtras.mm:
1431         * Misc/WebNSURLExtras.mm:
1432         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1433         * Plugins/WebBasePluginPackage.mm:
1434         * Plugins/WebPluginContainerCheck.mm:
1435         (-[WebPluginContainerCheck _continueWithPolicy:]):
1436         * WebCoreSupport/WebCachedFramePlatformData.h:
1437         (WebCachedFramePlatformData::clear):
1438         * WebCoreSupport/WebDeviceOrientationClient.mm:
1439         (WebDeviceOrientationClient::getProvider const):
1440         * WebView/WebDelegateImplementationCaching.mm:
1441         (CallDelegate):
1442         (CallDelegateReturningBoolean):
1443         (CallResourceLoadDelegateReturningBoolean):
1444         (CallFormDelegate):
1445         (CallFormDelegateReturningBoolean):
1446         * WebView/WebHTMLView.mm:
1447         * WebView/WebPDFRepresentation.mm:
1448         * WebView/WebPolicyDelegate.mm:
1449         (-[WebPolicyDecisionListener _usePolicy:]):
1450         * WebView/WebView.mm:
1451
1452 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1453
1454         Unreviewed, rolling out r238047.
1455
1456         Introduced layout test failures on iOS simulator.
1457
1458         Reverted changeset:
1459
1460         "[iOS] Draw caps lock indicator in password fields"
1461         https://bugs.webkit.org/show_bug.cgi?id=190565
1462         https://trac.webkit.org/changeset/238047
1463
1464 2018-11-09  Antti Koivisto  <antti@apple.com>
1465
1466         Use OptionSet for layout milestones
1467         https://bugs.webkit.org/show_bug.cgi?id=191470
1468
1469         Reviewed by Dean Jackson.
1470
1471         * WebCoreSupport/WebFrameLoaderClient.h:
1472         * WebCoreSupport/WebFrameLoaderClient.mm:
1473         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1474         * WebView/WebView.mm:
1475         (coreLayoutMilestones):
1476         (kitLayoutMilestones):
1477         (-[WebView _cacheFrameLoadDelegateImplementations]):
1478         * WebView/WebViewInternal.h:
1479
1480 2018-11-09  Daniel Bates  <dabates@apple.com>
1481
1482         [iOS] Draw caps lock indicator in password fields
1483         https://bugs.webkit.org/show_bug.cgi?id=190565
1484         <rdar://problem/45262343>
1485
1486         Reviewed by Dean Jackson.
1487
1488         Update the caps lock state when a hardware keyboard is attached or detached.
1489
1490         * WebView/WebHTMLView.mm:
1491         (hardwareKeyboardAvailabilityChangedCallback): Added.
1492         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1493         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1494
1495 2018-11-09  Daniel Bates  <dabates@apple.com>
1496
1497         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1498         action when forward delete is pressed outside a text field
1499         https://bugs.webkit.org/show_bug.cgi?id=190566
1500         <rdar://problem/45262367>
1501
1502         Reviewed by Wenson Hsieh.
1503
1504         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1505         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1506         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1507
1508         * WebView/WebHTMLView.mm:
1509         (-[WebHTMLView _handleEditingKeyEvent:]):
1510
1511 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1512
1513         Adopt Reveal Framework to replace Lookup
1514         https://bugs.webkit.org/show_bug.cgi?id=191097
1515         <rdar://problem/45924508>
1516
1517         Reviewed by Tim Horton.
1518
1519         Pass in what it needed to clear the textIndicators. This is better than
1520         the current notification structure.
1521
1522         * WebView/WebView.mm:
1523         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1524         (-[WebView _prepareForDictionaryLookup]):
1525
1526 2018-11-06  Justin Fan  <justin_fan@apple.com>
1527
1528         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1529         https://bugs.webkit.org/show_bug.cgi?id=191291
1530
1531         Reviewed by Myles Maxfield.
1532
1533         Properly disable WEBGPU on all non-Metal platforms for now.
1534
1535         * Configurations/FeatureDefines.xcconfig:
1536
1537 2018-11-02  Daniel Bates  <dabates@apple.com>
1538
1539         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1540         https://bugs.webkit.org/show_bug.cgi?id=190487
1541
1542         Reviewed by Tim Horton.
1543
1544         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1545         allow the default handling.
1546
1547         * WebView/WebHTMLView.mm:
1548         (-[WebHTMLView _handleEditingKeyEvent:]):
1549
1550 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1551
1552         Add a storage limit for IndexedDB
1553         https://bugs.webkit.org/show_bug.cgi?id=190598
1554         <rdar://problem/44654715>
1555
1556         Reviewed by Chris Dumez.
1557
1558         * Storage/WebDatabaseManager.mm:
1559         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1560         * Storage/WebDatabaseManagerPrivate.h:
1561
1562 2018-10-31  Antti Koivisto  <antti@apple.com>
1563
1564         Remove LayerFlushScheduler
1565         https://bugs.webkit.org/show_bug.cgi?id=191103
1566
1567         Reviewed by Anders Carlsson.
1568
1569         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1570         all the virtual cruft.
1571
1572         * WebView/WebViewData.h:
1573         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1574         (): Deleted.
1575         * WebView/WebViewData.mm:
1576         (currentRunLoop):
1577         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1578         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1579         (WebViewLayerFlushScheduler::schedule):
1580         (WebViewLayerFlushScheduler::invalidate):
1581         (WebViewLayerFlushScheduler::layerFlushCallback):
1582
1583 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1584
1585         Enable InstallAPI for iOS unconditionally
1586         https://bugs.webkit.org/show_bug.cgi?id=191043
1587         rdar://problem/32728423
1588
1589         Reviewed by Dan Bernstein.
1590
1591         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1592         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1593         shouldn't be processed by InstallAPI.
1594         * MigrateHeaders.make: Removed an obsolete workaround.
1595         * Misc/NSURLDownloadSPI.h: Added.
1596         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1597
1598 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1599
1600         Clean up some obsolete MAX_ALLOWED macros
1601         https://bugs.webkit.org/show_bug.cgi?id=190916
1602
1603         Reviewed by Tim Horton.
1604
1605         * WebView/WebHTMLView.mm:
1606         (-[WebHTMLView pressureChangeWithEvent:]):
1607         * WebView/WebPDFView.h:
1608
1609 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1610
1611         Unreviewed, rolling out r237600 and r237604.
1612         https://bugs.webkit.org/show_bug.cgi?id=191086
1613
1614         Breaks internal iOS builds (Requested by ryanhadd_ on
1615         #webkit).
1616
1617         Reverted changesets:
1618
1619         "Enable InstallAPI for iOS unconditionally"
1620         https://bugs.webkit.org/show_bug.cgi?id=191043
1621         https://trac.webkit.org/changeset/237600
1622
1623         "Build fix attempt after enabling InstallAPI for iOS."
1624         https://bugs.webkit.org/show_bug.cgi?id=191043
1625         https://trac.webkit.org/changeset/237604
1626
1627 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1628
1629         Enable InstallAPI for iOS unconditionally
1630         https://bugs.webkit.org/show_bug.cgi?id=191043
1631         rdar://problem/32728423
1632
1633         Reviewed by Dan Bernstein.
1634
1635         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1636         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1637         shouldn't be processed by InstallAPI.
1638         * MigrateHeaders.make: Removed an obsolete workaround.
1639         * Misc/NSURLDownloadSPI.h: Added.
1640         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1641
1642 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1643
1644         Modernize WebKit nibs and lprojs for localization's sake
1645         https://bugs.webkit.org/show_bug.cgi?id=190911
1646         <rdar://problem/45349466>
1647
1648         Reviewed by Dan Bernstein.
1649
1650         * Misc/WebNSControlExtras.m:
1651         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1652         NSWindow and its contents are both in the same scale space these days; avoid
1653         double-applying the scale factor, or you can't see the prompt.
1654
1655         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1656         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1657         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1658         NIB->XIB
1659
1660 2018-10-25  Antoine Quint  <graouts@apple.com>
1661
1662         [Web Animations] Turn Web Animations CSS Integration off by default
1663         https://bugs.webkit.org/show_bug.cgi?id=190901
1664
1665         Reviewed by Dean Jackson.
1666
1667         * WebView/WebPreferences.mm:
1668         (+[WebPreferences initialize]):
1669
1670 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1671
1672         Clean up some obsolete macOS version guards
1673         https://bugs.webkit.org/show_bug.cgi?id=190887
1674
1675         Reviewed by Dan Bernstein.
1676
1677         * Misc/WebNSPasteboardExtras.mm:
1678         (+[NSPasteboard _web_dragTypesForURL]):
1679         * WebCoreSupport/PopupMenuMac.mm:
1680         (PopupMenuMac::show):
1681         * WebCoreSupport/WebEditorClient.h:
1682         * WebCoreSupport/WebEditorClient.mm:
1683         (WebEditorClient::respondToChangedSelection):
1684         * WebView/WebPDFView.mm:
1685         (-[WebPDFView _clipViewForPDFDocumentView]):
1686
1687 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1688
1689         Turn on Conic Gradients
1690         https://bugs.webkit.org/show_bug.cgi?id=190810
1691
1692         Reviewed by Tim Horton.
1693
1694         * Configurations/FeatureDefines.xcconfig:
1695
1696 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1697
1698         Cleanup: MIMETypeRegistry functions
1699         https://bugs.webkit.org/show_bug.cgi?id=190838
1700
1701         Reviewed by Simon Fraser.
1702
1703         * Misc/WebNSPasteboardExtras.mm:
1704         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1705         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1706         because they were identical.
1707
1708         * WebView/WebHTMLRepresentation.mm:
1709         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1710         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1711         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1712         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1713         * WebView/WebView.mm:
1714         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1715         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1716         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1717
1718 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1719
1720         Fix false positive leaks when using custom -init methods that don't start with -init
1721         <https://webkit.org/b/190818>
1722         <rdar://problem/45476042>
1723
1724         Reviewed by Dan Bernstein.
1725
1726         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1727         it is accessible by both categories.
1728         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1729         NSError (WebKitInternal) category.  Add attribute to make this
1730         behave like an -init method.
1731         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1732         NSError (WebKitInternal) category.  Modernize method.  Replace
1733         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1734
1735 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1736
1737         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1738         https://bugs.webkit.org/show_bug.cgi?id=190729
1739
1740         Reviewed by Tim Horton.
1741
1742         * DOM/DOM.mm:
1743         (-[DOMNode boundingBox]):
1744         * DOM/DOMElement.mm:
1745         * DOM/DOMHTML.mm:
1746         * DOM/DOMInternal.mm:
1747         * DOM/DOMUIKitExtensions.mm:
1748         * DOM/WebDOMOperations.mm:
1749         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1750         * DefaultDelegates/WebDefaultEditingDelegate.m:
1751         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1752         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1753         * DefaultDelegates/WebDefaultUIDelegate.h:
1754         * DefaultDelegates/WebDefaultUIDelegate.mm:
1755         (-[WebDefaultUIDelegate webViewClose:]):
1756         (-[WebDefaultUIDelegate webViewFocus:]):
1757         (-[WebDefaultUIDelegate webViewUnfocus:]):
1758         (-[WebDefaultUIDelegate webViewIsResizable:]):
1759         (-[WebDefaultUIDelegate webView:setResizable:]):
1760         (-[WebDefaultUIDelegate webView:setFrame:]):
1761         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1762         * History/BackForwardList.h:
1763         * History/BackForwardList.mm:
1764         * History/WebBackForwardList.mm:
1765         (+[WebBackForwardList initialize]):
1766         (bumperCarBackForwardHackNeeded):
1767         * History/WebHistory.mm:
1768         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1769         (-[WebHistory _sendNotification:entries:]):
1770         (-[WebHistory loadFromURL:error:]):
1771         (-[WebHistory saveToURL:error:]):
1772         * History/WebHistoryItem.mm:
1773         (WKNotifyHistoryItemChanged):
1774         (+[WebHistoryItem initialize]):
1775         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1776         * History/WebURLsWithTitles.m:
1777         * Misc/WebCache.mm:
1778         (+[WebCache initialize]):
1779         * Misc/WebDownload.mm:
1780         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1781         * Misc/WebElementDictionary.mm:
1782         (+[WebElementDictionary initialize]):
1783         (+[WebElementDictionary initializeLookupTable]):
1784         * Misc/WebIconDatabase.mm:
1785         * Misc/WebKitNSStringExtras.mm:
1786         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1787         * Misc/WebKitVersionChecks.h:
1788         * Misc/WebKitVersionChecks.mm:
1789         (WebKitLinkedOnOrAfter):
1790         (WebKitLinkTimeVersion):
1791         * Misc/WebLocalizableStrings.mm:
1792         * Misc/WebNSControlExtras.h:
1793         * Misc/WebNSControlExtras.m:
1794         * Misc/WebNSEventExtras.m:
1795         * Misc/WebNSFileManagerExtras.mm:
1796         * Misc/WebNSImageExtras.h:
1797         * Misc/WebNSImageExtras.m:
1798         * Misc/WebNSPasteboardExtras.mm:
1799         * Misc/WebNSPrintOperationExtras.h:
1800         * Misc/WebNSPrintOperationExtras.m:
1801         * Misc/WebNSViewExtras.m:
1802         * Misc/WebNSWindowExtras.m:
1803         * Panels/WebAuthenticationPanel.h:
1804         * Panels/WebAuthenticationPanel.m:
1805         * Panels/WebPanelAuthenticationHandler.m:
1806         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1807         (+[WebHostedNetscapePluginView initialize]):
1808         * Plugins/WebBasePluginPackage.h:
1809         * Plugins/WebBasePluginPackage.mm:
1810         * Plugins/WebJavaPlugIn.h:
1811         * Plugins/WebPluginContainerCheck.mm:
1812         * Plugins/WebPluginController.h:
1813         * Plugins/WebPluginController.mm:
1814         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1815         (-[WebPluginController addPlugin:]):
1816         (-[WebPluginController destroyPlugin:]):
1817         (-[WebPluginController destroyAllPlugins]):
1818         * Plugins/WebPluginDatabase.mm:
1819         (+[WebPluginDatabase _defaultPlugInPaths]):
1820         * Plugins/WebPluginPackage.mm:
1821         (-[WebPluginPackage initWithPath:]):
1822         * Storage/WebDatabaseManager.mm:
1823         (-[WebDatabaseManager deleteAllDatabases]):
1824         * Storage/WebDatabaseManagerClient.h:
1825         * Storage/WebDatabaseManagerClient.mm:
1826         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1827         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1828         * Storage/WebStorageManager.mm:
1829         (-[WebStorageManager deleteAllOrigins]):
1830         (WebKitInitializeStorageIfNecessary):
1831         * WebCoreSupport/WebAlternativeTextClient.h:
1832         * WebCoreSupport/WebApplicationCache.mm:
1833         (applicationCacheBundleIdentifier):
1834         * WebCoreSupport/WebChromeClient.h:
1835         * WebCoreSupport/WebChromeClient.mm:
1836         (WebChromeClient::setWindowRect):
1837         (WebChromeClient::windowRect):
1838         (WebChromeClient::takeFocus):
1839         (WebChromeClient::addMessageToConsole):
1840         (WebChromeClient::enableSuddenTermination):
1841         (WebChromeClient::disableSuddenTermination):
1842         (WebChromeClient::createPopupMenu const):
1843         (WebChromeClient::createSearchPopupMenu const):
1844         (WebChromeClient::shouldPaintEntireContents const):
1845         (WebChromeClient::supportsVideoFullscreen):
1846         (WebChromeClient::supportsFullScreenForElement):
1847         (WebChromeClient::enterFullScreenForElement):
1848         (WebChromeClient::exitFullScreenForElement):
1849         * WebCoreSupport/WebContextMenuClient.mm:
1850         * WebCoreSupport/WebDragClient.mm:
1851         * WebCoreSupport/WebEditorClient.h:
1852         * WebCoreSupport/WebEditorClient.mm:
1853         (+[WebUndoStep initialize]):
1854         (updateFontPanel):
1855         (WebEditorClient::didBeginEditing):
1856         (WebEditorClient::respondToChangedContents):
1857         (WebEditorClient::respondToChangedSelection):
1858         (WebEditorClient::canceledComposition):
1859         (WebEditorClient::didEndEditing):
1860         (WebEditorClient::didWriteSelectionToPasteboard):
1861         (attributesForAttributedStringConversion):
1862         (WebEditorClient::setInsertionPasteboard):
1863         (WebEditorClient::registerUndoOrRedoStep):
1864         (WebEditorClient::handleKeyboardEvent):
1865         (WebEditorClient::handleInputMethodKeydown):
1866         (WebEditorClient::textDidChangeInTextField):
1867         (WebEditorClient::requestCheckingOfString):
1868         * WebCoreSupport/WebFrameLoaderClient.h:
1869         * WebCoreSupport/WebFrameLoaderClient.mm:
1870         (WebFrameLoaderClient::detachedFromParent2):
1871         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1872         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1873         (WebFrameLoaderClient::dispatchWillSendRequest):
1874         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1875         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1876         (WebFrameLoaderClient::willCacheResponse const):
1877         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1878         (WebFrameLoaderClient::dispatchDidFinishLoading):
1879         (WebFrameLoaderClient::dispatchDidFailLoading):
1880         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1881         (WebFrameLoaderClient::dispatchWillClose):
1882         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1883         (WebFrameLoaderClient::dispatchDidCommitLoad):
1884         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1885         (WebFrameLoaderClient::dispatchDidFailLoad):
1886         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1887         (WebFrameLoaderClient::dispatchDidFinishLoad):
1888         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1889         (WebFrameLoaderClient::willChangeTitle):
1890         (WebFrameLoaderClient::didChangeTitle):
1891         (WebFrameLoaderClient::didReplaceMultipartContent):
1892         (WebFrameLoaderClient::updateGlobalHistory):
1893         (WebFrameLoaderClient::saveViewStateToItem):
1894         (WebFrameLoaderClient::restoreViewState):
1895         (WebFrameLoaderClient::provisionalLoadStarted):
1896         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1897         (WebFrameLoaderClient::setTitle):
1898         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1899         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1900         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1901         (WebFrameLoaderClient::didRestoreFromPageCache):
1902         (WebFrameLoaderClient::actionDictionary const):
1903         (WebFrameLoaderClient::createPlugin):
1904         (WebFrameLoaderClient::getLoadDecisionForIcons):
1905         (WebFrameLoaderClient::finishedLoadingIcon):
1906         (+[WebFramePolicyListener initialize]):
1907         * WebCoreSupport/WebFrameNetworkingContext.mm:
1908         * WebCoreSupport/WebGeolocationClient.h:
1909         * WebCoreSupport/WebGeolocationClient.mm:
1910         (WebGeolocationClient::requestPermission):
1911         * WebCoreSupport/WebInspectorClient.h:
1912         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1913         * WebCoreSupport/WebNotificationClient.mm:
1914         * WebCoreSupport/WebOpenPanelResultListener.mm:
1915         * WebCoreSupport/WebPlatformStrategies.h:
1916         * WebCoreSupport/WebPlatformStrategies.mm:
1917         * WebCoreSupport/WebProgressTrackerClient.h:
1918         * WebCoreSupport/WebProgressTrackerClient.mm:
1919         (WebProgressTrackerClient::progressStarted):
1920         (WebProgressTrackerClient::progressEstimateChanged):
1921         (WebProgressTrackerClient::progressFinished):
1922         * WebCoreSupport/WebSecurityOrigin.mm:
1923         * WebInspector/WebNodeHighlight.h:
1924         * WebInspector/WebNodeHighlight.mm:
1925         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1926         (-[WebNodeHighlight dealloc]):
1927         (-[WebNodeHighlight attach]):
1928         * WebInspector/WebNodeHighlightView.h:
1929         * WebInspector/WebNodeHighlightView.mm:
1930         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1931         (-[WebNodeHighlightView dealloc]):
1932         * WebInspector/WebNodeHighlighter.mm:
1933         (-[WebNodeHighlighter highlight]):
1934         * WebView/WebArchive.mm:
1935         (+[WebArchivePrivate initialize]):
1936         * WebView/WebClipView.h:
1937         * WebView/WebDataSource.mm:
1938         (WebDataSourcePrivate::WebDataSourcePrivate):
1939         (+[WebDataSource initialize]):
1940         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1941         (-[WebDataSource _makeRepresentation]):
1942         * WebView/WebDelegateImplementationCaching.h:
1943         * WebView/WebDelegateImplementationCaching.mm:
1944         (CallDelegate):
1945         (CallDelegateReturningFloat):
1946         (CallDelegateReturningBoolean):
1947         (CallUIDelegate):
1948         (CallUIDelegateReturningFloat):
1949         (CallUIDelegateReturningBoolean):
1950         (CallFrameLoadDelegate):
1951         (CallFrameLoadDelegateReturningBoolean):
1952         (CallResourceLoadDelegate):
1953         (CallScriptDebugDelegate):
1954         (CallFormDelegate):
1955         (CallFormDelegateReturningBoolean):
1956         * WebView/WebDeviceOrientation.mm:
1957         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1958         * WebView/WebDocumentInternal.h:
1959         * WebView/WebDocumentLoaderMac.mm:
1960         (needsDataLoadWorkaround):
1961         * WebView/WebDynamicScrollBarsViewInternal.h:
1962         * WebView/WebFormDelegate.m:
1963         * WebView/WebFrame.mm:
1964         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1965         (-[WebFrame _unmarkAllMisspellings]):
1966         (-[WebFrame _paintBehaviorForDestinationContext:]):
1967         (-[WebFrame _drawRect:contentsOnly:]):
1968         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1969         (-[WebFrame _scrollDOMRangeToVisible:]):
1970         (-[WebFrame _bodyBackgroundColor]):
1971         (-[WebFrame accessibilityRoot]):
1972         (needsMicrosoftMessengerDOMDocumentWorkaround):
1973         * WebView/WebFrameInternal.h:
1974         * WebView/WebFrameView.mm:
1975         (-[WebFrameView _setDocumentView:]):
1976         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1977         (-[WebFrameView _viewClassForMIMEType:]):
1978         (-[WebFrameView initWithFrame:]):
1979         (-[WebFrameView drawRect:]):
1980         (-[WebFrameView _firstResponderIsFormControl]):
1981         (-[WebFrameView keyDown:keyDown:]):
1982         (-[WebFrameView _isScrollable]):
1983         * WebView/WebFullScreenController.h:
1984         * WebView/WebFullScreenController.mm:
1985         * WebView/WebHTMLRepresentation.mm:
1986         * WebView/WebHTMLView.mm:
1987         (-[WebHTMLView hitTest:]):
1988         (-[WebHTMLView initWithFrame:]):
1989         (-[WebHTMLView dealloc]):
1990         (-[WebHTMLView addSubview:]):
1991         (-[WebHTMLView mouseDown:]):
1992         (-[WebHTMLView mouseUp:]):
1993         (-[WebHTMLView resignFirstResponder]):
1994         (-[WebHTMLView accessibilityHitTest:]):
1995         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1996         * WebView/WebHTMLViewInternal.h:
1997         * WebView/WebIndicateLayer.h:
1998         * WebView/WebIndicateLayer.mm:
1999         * WebView/WebMediaPlaybackTargetPicker.h:
2000         * WebView/WebMediaPlaybackTargetPicker.mm:
2001         * WebView/WebPDFDocumentExtras.h:
2002         * WebView/WebPDFDocumentExtras.mm:
2003         * WebView/WebPDFRepresentation.h:
2004         * WebView/WebPDFRepresentation.mm:
2005         * WebView/WebPDFView.h:
2006         * WebView/WebPreferences.mm:
2007         (cacheModelForMainBundle):
2008         (WebPreferencesPrivate::WebPreferencesPrivate):
2009         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2010         (-[WebPreferences encodeWithCoder:]):
2011         (+[WebPreferences standardPreferences]):
2012         (+[WebPreferences initialize]):
2013         (-[WebPreferences _valueForKey:]):
2014         (-[WebPreferences _setStringValue:forKey:]):
2015         (-[WebPreferences _setIntegerValue:forKey:]):
2016         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2017         (-[WebPreferences _setFloatValue:forKey:]):
2018         (-[WebPreferences _setBoolValue:forKey:]):
2019         (-[WebPreferences _setLongLongValue:forKey:]):
2020         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2021         (-[WebPreferences _postCacheModelChangedNotification]):
2022         (-[WebPreferences _postPreferencesChangedNotification]):
2023         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2024         (-[WebPreferences setStorageBlockingPolicy:]):
2025         * WebView/WebResource.mm:
2026         (+[WebResourcePrivate initialize]):
2027         * WebView/WebTextCompletionController.h:
2028         * WebView/WebTextIterator.mm:
2029         (+[WebTextIteratorPrivate initialize]):
2030         * WebView/WebView.mm:
2031         (shouldEnableLoadDeferring):
2032         (shouldRestrictWindowFocus):
2033         (shouldRespectPriorityInCSSAttributeSetters):
2034         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2035         (shouldAllowPictureInPictureMediaPlayback):
2036         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2037         (shouldAllowWindowOpenWithoutUserGesture):
2038         (shouldConvertInvalidURLsToBlank):
2039         (shouldRequireUserGestureToLoadVideo):
2040         (-[WebView _commonInitializationWithFrameName:groupName:]):
2041         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2042         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2043         (-[WebView _closePluginDatabases]):
2044         (-[WebView _closeWithFastTeardown]):
2045         (-[WebView _close]):
2046         (+[WebView _MIMETypeForFile:]):
2047         (-[WebView setShowingInspectorIndication:]):
2048         (-[WebView _setFormDelegate:]):
2049         (-[WebView _needsPreHTML5ParserQuirks]):
2050         (-[WebView _preferencesChangedNotification:]):
2051         (-[WebView _preferencesChanged:]):
2052         (-[WebView _cacheResourceLoadDelegateImplementations]):
2053         (-[WebView _cacheFrameLoadDelegateImplementations]):
2054         (-[WebView _policyDelegateForwarder]):
2055         (-[WebView _UIDelegateForwarder]):
2056         (-[WebView _editingDelegateForwarder]):
2057         (-[WebView _updateActiveState]):
2058         (-[_WebSafeForwarder forwardInvocation:]):
2059         (+[WebView initialize]):
2060         (-[WebView _pluginForMIMEType:]):
2061         (-[WebView _pluginForExtension:]):
2062         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2063         (+[WebView canShowMIMETypeAsHTML:]):
2064         (-[WebView _initWithArguments:]):
2065         (-[WebView initWithFrame:frameName:groupName:]):
2066         (-[WebView dealloc]):
2067         (-[WebView close]):
2068         (-[WebView viewDidMoveToWindow]):
2069         (-[WebView setUIDelegate:]):
2070         (-[WebView setResourceLoadDelegate:]):
2071         (-[WebView setPolicyDelegate:]):
2072         (-[WebView setFrameLoadDelegate:]):
2073         (-[WebView goBack]):
2074         (-[WebView goForward]):
2075         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2076         (-[WebView setHostWindow:]):
2077         (-[WebView becomeFirstResponder]):
2078         (+[WebView _cacheModelChangedNotification:]):
2079         (-[WebView _frameViewAtWindowPoint:]):
2080         (+[WebView _preflightSpellCheckerNow:]):
2081         (+[WebView _preflightSpellChecker]):
2082         (-[WebView canGoBack]):
2083         (-[WebView canGoForward]):
2084         (-[WebView stopLoading:]):
2085         (-[WebView reload:]):
2086         (-[WebView setMainFrameDocumentReady:]):
2087         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2088         (-[WebView setContinuousSpellCheckingEnabled:]):
2089         (-[WebView undoManager]):
2090         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2091         (-[WebView isAutomaticLinkDetectionEnabled]):
2092         (-[WebView isAutomaticDashSubstitutionEnabled]):
2093         (-[WebView isAutomaticTextReplacementEnabled]):
2094         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2095         (+[WebView _setCacheModel:]):
2096         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2097         (-[WebView _keyboardUIMode]):
2098         (LayerFlushController::flushLayers):
2099         (-[WebView _scheduleCompositingLayerFlush]):
2100         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2101         (-[WebView fullScreenPlaceholderView]):
2102         (WebInstallMemoryPressureHandler):
2103         * WebView/WebViewData.h:
2104         * WebView/WebViewData.mm:
2105         (+[WebViewPrivate initialize]):
2106         (-[WebViewPrivate init]):
2107         (-[WebViewPrivate dealloc]):
2108         * WebView/WebViewInternal.h:
2109
2110 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2111
2112         Clean up FrameLoader two-state enums
2113         https://bugs.webkit.org/show_bug.cgi?id=190731
2114
2115         Reviewed by Chris Dumez.
2116
2117         * WebCoreSupport/WebFrameLoaderClient.h:
2118         * WebCoreSupport/WebFrameLoaderClient.mm:
2119         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2120
2121 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2122
2123         Unreviewed, rolling out r237137.
2124
2125         SPI is actually used
2126
2127         Reverted changeset:
2128
2129         "Remove unused WebFrame._loadType"
2130         https://bugs.webkit.org/show_bug.cgi?id=190583
2131         https://trac.webkit.org/changeset/237137
2132
2133 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2134
2135         Enable the datalist element by default on iOS and macOS
2136         https://bugs.webkit.org/show_bug.cgi?id=190594
2137         <rdar://problem/45281159>
2138
2139         Reviewed by Ryosuke Niwa and Tim Horton.
2140
2141         * Configurations/FeatureDefines.xcconfig:
2142
2143 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2144
2145         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2146         https://bugs.webkit.org/show_bug.cgi?id=190675
2147
2148         Reviewed by Chris Dumez.
2149
2150         * History/BackForwardList.h:
2151         * History/BackForwardList.mm:
2152         (BackForwardList::backItem):
2153         (BackForwardList::currentItem):
2154         (BackForwardList::forwardItem):
2155         (BackForwardList::backListCount const):
2156         (BackForwardList::forwardListCount const):
2157         (BackForwardList::itemAtIndex):
2158         * History/WebBackForwardList.mm:
2159         (-[WebBackForwardList backItem]):
2160         (-[WebBackForwardList currentItem]):
2161         (-[WebBackForwardList forwardItem]):
2162         (-[WebBackForwardList itemAtIndex:]):
2163
2164 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2165
2166         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2167         https://bugs.webkit.org/show_bug.cgi?id=190526
2168         rdar://problem/45230140
2169
2170         Reviewed by Dean Jackson.
2171
2172         * WebCoreSupport/WebEditorClient.mm:
2173         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2174
2175 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2176
2177         Implement feature flag and bindings for CSS Painting API
2178         https://bugs.webkit.org/show_bug.cgi?id=190237
2179
2180         Reviewed by Ryosuke Niwa.
2181
2182         * Configurations/FeatureDefines.xcconfig:
2183
2184 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2185
2186         Replace HistoryItem* with HistoryItem& where possible
2187         https://bugs.webkit.org/show_bug.cgi?id=190617
2188
2189         Reviewed by Chris Dumez.
2190
2191         * History/BackForwardList.h:
2192         * History/BackForwardList.mm:
2193         (BackForwardList::goToItem):
2194         * History/WebBackForwardList.mm:
2195         (-[WebBackForwardList goToItem:]):
2196         * History/WebHistoryItem.mm:
2197         (WKNotifyHistoryItemChanged):
2198         * History/WebHistoryItemInternal.h:
2199
2200 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2201
2202         Remove unused WebHistoryItem._transientPropertyForKey
2203         https://bugs.webkit.org/show_bug.cgi?id=190606
2204
2205         Reviewed by Chris Dumez.
2206
2207         * History/WebHistoryItem.mm:
2208         * History/WebHistoryItemPrivate.h:
2209
2210 2018-10-15  Justin Fan  <justin_fan@apple.com>
2211
2212         Add WebGPU 2018 feature flag and experimental feature flag
2213         https://bugs.webkit.org/show_bug.cgi?id=190509
2214
2215         Reviewed by Dean Jackson.
2216
2217         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2218         for the 2018 WebGPU prototype.
2219
2220         * Configurations/FeatureDefines.xcconfig:
2221         * WebView/WebPreferenceKeysPrivate.h:
2222         * WebView/WebPreferences.mm:
2223         (+[WebPreferences initialize]):
2224         (-[WebPreferences webGPUEnabled]):
2225         (-[WebPreferences setWebGPUEnabled:]):
2226         * WebView/WebPreferencesPrivate.h:
2227         * WebView/WebView.mm:
2228         (-[WebView _preferencesChanged:]):
2229
2230 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2231
2232         Fix iOS build after r237157
2233
2234         * WebView/WebView.mm:
2235         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2236
2237 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2238
2239         Modernize BackForwardClient.h
2240         https://bugs.webkit.org/show_bug.cgi?id=190610
2241
2242         Reviewed by Chris Dumez.
2243
2244         * History/BackForwardList.h:
2245         * History/BackForwardList.mm:
2246         (BackForwardList::backListCount const):
2247         (BackForwardList::forwardListCount const):
2248         (BackForwardList::backListCount): Deleted.
2249         (BackForwardList::forwardListCount): Deleted.
2250         * History/WebBackForwardList.mm:
2251         (-[WebBackForwardList init]):
2252         * WebCoreSupport/WebFrameLoaderClient.mm:
2253         (WebFrameLoaderClient::canCachePage const):
2254         * WebView/WebFrameView.mm:
2255         (-[WebFrameView keyDown:keyDown:]):
2256         * WebView/WebView.mm:
2257         (-[WebView _commonInitializationWithFrameName:groupName:]):
2258         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2259         (-[WebView _loadBackForwardListFromOtherView:]):
2260         (-[WebView initWithCoder:]):
2261         (-[WebView encodeWithCoder:]):
2262         (-[WebView backForwardList]):
2263         (-[WebView setMaintainsBackForwardList:]):
2264
2265 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2266
2267         Add support for prefers-color-scheme media query
2268         https://bugs.webkit.org/show_bug.cgi?id=190499
2269         rdar://problem/45212025
2270
2271         Reviewed by Dean Jackson.
2272
2273         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2274
2275 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2276
2277         Remove unused WebView._globalHistoryItem
2278         https://bugs.webkit.org/show_bug.cgi?id=190601
2279
2280         Reviewed by Chris Dumez.
2281
2282         * WebCoreSupport/WebFrameLoaderClient.h:
2283         * WebCoreSupport/WebFrameLoaderClient.mm:
2284         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2285         * WebView/WebView.mm:
2286         (-[WebView _globalHistoryItem]): Deleted.
2287         (-[WebView _setGlobalHistoryItem:]): Deleted.
2288         * WebView/WebViewData.h:
2289         * WebView/WebViewInternal.h:
2290         * WebView/WebViewPrivate.h:
2291
2292 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2293
2294         Remove unused parameters from FrameLoaderClient::createFrame
2295         https://bugs.webkit.org/show_bug.cgi?id=190587
2296
2297         Reviewed by Chris Dumez.
2298
2299         * WebCoreSupport/WebFrameLoaderClient.h:
2300         * WebCoreSupport/WebFrameLoaderClient.mm:
2301         (WebFrameLoaderClient::createFrame):
2302
2303 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2304
2305         Remove unused WebFrame._loadType
2306         https://bugs.webkit.org/show_bug.cgi?id=190583
2307
2308         Reviewed by Chris Dumez.
2309
2310         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2311
2312         * WebView/WebFrame.mm:
2313         (toWebFrameLoadType): Deleted.
2314         (-[WebFrame _loadType]): Deleted.
2315         * WebView/WebFramePrivate.h:
2316
2317 2018-10-15  Chris Dumez  <cdumez@apple.com>
2318
2319         Restrict browsing context lookup by name to frames that are related to one another
2320         https://bugs.webkit.org/show_bug.cgi?id=190475
2321
2322         Reviewed by Alex Christensen.
2323
2324         * WebView/WebFrame.mm:
2325         (-[WebFrame findFrameNamed:]):
2326
2327 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2328
2329         Remove InjectedBundle processing of back/forward lists
2330         https://bugs.webkit.org/show_bug.cgi?id=190459
2331
2332         Reviewed by Chris Dumez.
2333
2334         * WebCoreSupport/WebFrameLoaderClient.h:
2335         * WebCoreSupport/WebFrameLoaderClient.mm:
2336         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2337
2338 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2339
2340         [JSC] Remove Option::useAsyncIterator
2341         https://bugs.webkit.org/show_bug.cgi?id=190567
2342
2343         Reviewed by Saam Barati.
2344
2345         * Configurations/FeatureDefines.xcconfig:
2346
2347 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2348
2349         Allow encoding of small enum classes
2350         https://bugs.webkit.org/show_bug.cgi?id=190531
2351
2352         Reviewed by Tim Horton.
2353
2354         * WebCoreSupport/WebFrameLoaderClient.mm:
2355         (-[WebFramePolicyListener dealloc]):
2356
2357 2018-10-11  Keith Rollin  <krollin@apple.com>
2358
2359         CURRENT_ARCH should not be used in Run Script phase.
2360         https://bugs.webkit.org/show_bug.cgi?id=190407
2361         <rdar://problem/45133556>
2362
2363         Reviewed by Alexey Proskuryakov.
2364
2365         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2366         CURRENT_ARCH is not well-defined during this phase (and may even have
2367         the value "undefined") since this phase is run just once per build
2368         rather than once per supported architecture. Migrate away from
2369         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2370         performing an operation for each value, or by picking the first entry
2371         in ARCHS and using that as a representative value.
2372
2373         * Configurations/WebKitLegacy.xcconfig: When generating
2374         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2375         macosx platforms.
2376
2377         * MigrateHeaders.make:
2378         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2379         generate one for each architecture in ARCHS.
2380
2381 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2382
2383         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2384         https://bugs.webkit.org/show_bug.cgi?id=190429
2385
2386         Reviewed by Saam Barati.
2387
2388         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2389
2390         * WebView/WebPDFRepresentation.mm:
2391         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2392
2393 2018-10-08  Justin Fan  <justin_fan@apple.com>
2394
2395         WebGPU: Rename old WebGPU prototype to WebMetal
2396         https://bugs.webkit.org/show_bug.cgi?id=190325
2397         <rdar://problem/44990443>
2398
2399         Reviewed by Dean Jackson.
2400
2401         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2402
2403         * Configurations/FeatureDefines.xcconfig:
2404         * WebView/WebPreferenceKeysPrivate.h:
2405         * WebView/WebPreferences.mm:
2406         (+[WebPreferences initialize]):
2407         (-[WebPreferences webMetalEnabled]):
2408         (-[WebPreferences setWebMetalEnabled:]):
2409         (-[WebPreferences webGPUEnabled]): Deleted.
2410         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2411         * WebView/WebPreferencesPrivate.h:
2412         * WebView/WebView.mm:
2413         (-[WebView _preferencesChanged:]):
2414
2415 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2416
2417         Make <input type=color> a runtime enabled (on-by-default) feature
2418         https://bugs.webkit.org/show_bug.cgi?id=189162
2419
2420         Reviewed by Wenson Hsieh and Tim Horton.
2421
2422         * Configurations/FeatureDefines.xcconfig:
2423
2424 2018-10-07  Dan Bernstein  <mitz@apple.com>
2425
2426         Fixed building with the latest macOS SDK
2427
2428         * Plugins/WebNetscapePluginPackage.mm:
2429         (-[WebNetscapePluginPackage openResourceFile]):
2430         (-[WebNetscapePluginPackage closeResourceFile:]):
2431
2432 2018-10-04  Dan Bernstein  <mitz@apple.com>
2433
2434         More Carbon build-fixing.
2435
2436         * Carbon/CarbonWindowAdapter.mm:
2437         (-[CarbonWindowAdapter _destroyRealWindow:]):
2438         (-[CarbonWindowAdapter _growBoxRect]):
2439
2440 2018-10-04  Dan Bernstein  <mitz@apple.com>
2441
2442         Retried to fix 32-bit macOS builds after r236846.
2443
2444         * WebView/WebHTMLView.mm:
2445         (-[WebHTMLView setMarkedText:selectedRange:]):
2446
2447 2018-10-04  Dan Bernstein  <mitz@apple.com>
2448
2449         Retried to fix 32-bit macOS builds after r236846.
2450
2451         * Carbon/HIWebView.mm:
2452         (ActiveStateChanged):
2453
2454 2018-10-04  Dan Bernstein  <mitz@apple.com>
2455
2456         Tried to fix 32-bit macOS builds after r236846.
2457
2458         * Carbon/HIWebView.mm:
2459         (_NSSelectorForHICommand):
2460
2461 2018-10-04  Dan Bernstein  <mitz@apple.com>
2462
2463         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2464         https://bugs.webkit.org/show_bug.cgi?id=190250
2465
2466         Reviewed by Andy Estes.
2467
2468         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2469           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2470           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2471           an earlier line set it to YES.
2472
2473         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2474         changes below.
2475
2476         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2477           provides some missing method declarations.
2478
2479         * Misc/WebDownload.mm:
2480         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2481           a deprecated method.
2482
2483         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2484
2485         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2486           other code in the file uses a method from it.
2487
2488         * Plugins/WebBaseNetscapePluginView.mm:
2489         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2490           a deprecated method.
2491
2492         * Plugins/WebPluginController.mm:
2493         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2494           around use of a selector that may be present in some WebKit client.
2495
2496         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2497           method declarations.
2498
2499         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2500           from here.
2501
2502         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2503           missing method declarations.
2504
2505         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2506           from here.
2507
2508         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2509           call from here.
2510         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2511           an obsolete delegate method for binary compatibility.
2512         (pluginView): Ditto.
2513
2514         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2515           call from here.
2516
2517         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2518           WebDeviceOrientationProviderMock protocol.
2519
2520         * WebView/WebDeviceOrientationProviderMock.mm:
2521         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2522           main @implementation.
2523
2524         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2525           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2526
2527         * WebView/WebDynamicScrollBarsView.mm:
2528         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2529           of a deprecated method.
2530
2531         * WebView/WebHTMLView.mm:
2532         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2533           selector warning around action methods that are not declared anywhere in WebKit.
2534
2535         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2536           about implementing this deprecated method.
2537         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2538         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2539         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2540         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2541         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2542         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2543         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2544         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2545         (-[WebHTMLView doCommandBySelector:]): Ditto.
2546         (-[WebHTMLView insertText:]): Ditto.
2547
2548         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2549
2550         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2551
2552         * WebView/WebPDFView.h: Removed previewView ivar.
2553
2554         * WebView/WebPDFView.mm:
2555           Removed declaration of FileInternal category and merged its implementation with the main
2556           implementation.
2557         (-[WebPDFView dealloc]): Removed previewView ivar.
2558         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2559           exist in macOS versions we support.
2560         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2561         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2562           action methods internal to PDFKit.
2563         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2564         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2565
2566         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2567           call on macOS, even though in r86988 we started calling different methods on iOS.
2568
2569         * WebView/WebView.mm:
2570         - Imported headers that declare delegate methods that we call.
2571         - Removed declaration of WebFileInternal category and merged its implementation with the
2572           main implementation.
2573         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2574           category, which made them impossible to call from the main implementation. Moved those
2575           into the main implementation. One of those had to be declared in a class extension,
2576           because it is called from a method implemented in the WebPrivate category, and that
2577           category’s implementation appears first in the file.
2578
2579         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2580           around use of obsolete delegate method for binary compatibility.
2581
2582         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2583
2584 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2585
2586         Runtime flag and IDL for MediaRecorder
2587         https://bugs.webkit.org/show_bug.cgi?id=190018
2588
2589         Reviewed by Youenn Fablet and Chris Dumez.
2590
2591         * WebView/WebPreferenceKeysPrivate.h:
2592         * WebView/WebPreferences.mm:
2593         (+[WebPreferences initialize]):
2594         (-[WebPreferences mediaRecorderEnabled]):
2595         (-[WebPreferences setMediaRecorderEnabled:]):
2596         * WebView/WebPreferencesPrivate.h:
2597         * WebView/WebView.mm:
2598         (-[WebView _preferencesChanged:]):
2599
2600 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2601
2602         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2603         https://bugs.webkit.org/show_bug.cgi?id=190238
2604
2605         Reviewed by Antti Koivisto.
2606
2607         Enabled the feature by default.
2608
2609         * WebView/WebPreferences.mm:
2610         (+[WebPreferences initialize]):
2611
2612 2018-10-01  Dean Jackson  <dino@apple.com>
2613
2614         [macOS] Switching to discrete GPU should be done in the UI process
2615         https://bugs.webkit.org/show_bug.cgi?id=189361
2616         <rdar://problem/43949622>
2617
2618         Reviewed by Simon Fraser.
2619
2620         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2621         not support swapping to the discrete GPU in this configuration.
2622
2623         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2624         (WebKit::WebSwitchingGPUClient::singleton):
2625         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2626         * WebView/WebView.mm:
2627         (-[WebView _commonInitializationWithFrameName:groupName:]):
2628
2629 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2630
2631         Remove ParsedURLString
2632         https://bugs.webkit.org/show_bug.cgi?id=190154
2633
2634         Reviewed by Chris Dumez.
2635
2636         * WebView/WebScriptDebugger.mm:
2637         (toNSURL):
2638
2639 2018-10-01  Dean Jackson  <dino@apple.com>
2640
2641         Remove CSS Animation Triggers
2642         https://bugs.webkit.org/show_bug.cgi?id=190175
2643         <rdar://problem/44925626>
2644
2645         Reviewed by Simon Fraser.
2646
2647         * Configurations/FeatureDefines.xcconfig:
2648
2649 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2650
2651         Unreviewed, rolling out r236624 and r236671.
2652         https://bugs.webkit.org/show_bug.cgi?id=190207
2653
2654         The change in r236624 introduced crashes on the bots
2655         (Requested by ryanhaddad on #webkit).
2656
2657         Reverted changesets:
2658
2659         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2660         https://bugs.webkit.org/show_bug.cgi?id=188747
2661         https://trac.webkit.org/changeset/236624
2662
2663         "Unify implementation in VideoFullscreenInterfaceAVKit"
2664         https://bugs.webkit.org/show_bug.cgi?id=190091
2665         https://trac.webkit.org/changeset/236671
2666
2667 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2668
2669         URL should not use TextEncoding internally
2670         https://bugs.webkit.org/show_bug.cgi?id=190111
2671
2672         Reviewed by Andy Estes.
2673
2674         * Misc/WebNSURLExtras.mm:
2675
2676 2018-09-28  Jer Noble  <jer.noble@apple.com>
2677
2678         Refactoring: eliminate raw pointer usage in Fullscreen code
2679         https://bugs.webkit.org/show_bug.cgi?id=188747
2680         <rdar://problem/43541164>
2681
2682         Reviewed by Alex Christensen.
2683
2684         PlaybackSessionInterface no longer has an invalidate() method.
2685
2686         * WebView/WebView.mm:
2687         (-[WebView _clearPlaybackControlsManager]):
2688
2689 2018-09-28  Chris Dumez  <cdumez@apple.com>
2690
2691         Drop support for cross-origin-window-policy header
2692         https://bugs.webkit.org/show_bug.cgi?id=190081
2693
2694         Reviewed by Ryosuke Niwa.
2695
2696         * WebView/WebPreferenceKeysPrivate.h:
2697         * WebView/WebPreferences.mm:
2698         (+[WebPreferences initialize]):
2699         * WebView/WebPreferencesPrivate.h:
2700         * WebView/WebView.mm:
2701         (-[WebView _preferencesChanged:]):
2702
2703 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2704
2705         Rename createMarkup to serializePreservingVisualAppearance
2706         https://bugs.webkit.org/show_bug.cgi?id=190086
2707
2708         Reviewed by Wenson Hsieh.
2709
2710         * DOM/WebDOMOperations.mm:
2711         (-[DOMRange markupString]):
2712
2713 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2714
2715         Unreviewed, rolling out r236605.
2716         https://bugs.webkit.org/show_bug.cgi?id=190087
2717
2718         caused three API test timeouts (Requested by jernoble on
2719         #webkit).
2720
2721         Reverted changeset:
2722
2723         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2724         https://bugs.webkit.org/show_bug.cgi?id=188747
2725         https://trac.webkit.org/changeset/236605
2726
2727 2018-09-28  Jer Noble  <jer.noble@apple.com>
2728
2729         Refactoring: eliminate raw pointer usage in Fullscreen code
2730         https://bugs.webkit.org/show_bug.cgi?id=188747
2731         <rdar://problem/43541164>
2732
2733         Reviewed by Alex Christensen.
2734
2735         PlaybackSessionInterface no longer has an invalidate() method.
2736
2737         * WebView/WebView.mm:
2738         (-[WebView _clearPlaybackControlsManager]):
2739
2740 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2741
2742         Use enum class in createMarkup arguments
2743         https://bugs.webkit.org/show_bug.cgi?id=190028
2744
2745         Reviewed by Wenson Hsieh.
2746
2747         * DOM/WebDOMOperations.mm:
2748         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2749         (-[DOMRange markupString]): Ditto.
2750
2751 2018-09-27  Antoine Quint  <graouts@apple.com>
2752
2753         [Web Animations] Turn Web Animations with CSS integration on
2754         https://bugs.webkit.org/show_bug.cgi?id=184819
2755         <rdar://problem/39597337>
2756
2757         Reviewed by Dean Jackson.
2758
2759         * WebView/WebPreferences.mm:
2760         (+[WebPreferences initialize]):
2761
2762 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2763
2764         Selection should work across shadow boundary when initiated by a mouse drag
2765         https://bugs.webkit.org/show_bug.cgi?id=151380
2766         <rdar://problem/24363872>
2767
2768         Reviewed by Wenson Hsieh.
2769
2770         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2771
2772         * WebView/WebPreferenceKeysPrivate.h:
2773         * WebView/WebPreferences.mm:
2774         (+[WebPreferences initialize]):
2775         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2776         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2777         * WebView/WebPreferencesPrivate.h:
2778         * WebView/WebView.mm:
2779         (-[WebView _preferencesChanged:]):
2780
2781 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2782
2783         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2784         https://bugs.webkit.org/show_bug.cgi?id=189918
2785         Work towards <rdar://problem/44648705>
2786
2787         Reviewed by Tim Horton.
2788
2789         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2790
2791         * WebView/WebHTMLView.mm:
2792         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2793         (-[WebHTMLView _updateFontPanel]):
2794         * WebView/WebView.mm:
2795         (-[WebView typingAttributes]):
2796
2797 2018-09-17  Darin Adler  <darin@apple.com>
2798
2799         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2800         https://bugs.webkit.org/show_bug.cgi?id=189652
2801
2802         Reviewed by Saam Barati.
2803
2804         * WebView/WebPDFRepresentation.mm:
2805         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2806
2807 2018-09-14  Jer Noble  <jer.noble@apple.com>
2808
2809         Turn SourceBufferChangeTypeEnabled on by default
2810         https://bugs.webkit.org/show_bug.cgi?id=189527
2811
2812         Reviewed by Eric Carlson.
2813
2814         * WebView/WebPreferences.mm:
2815         (+[WebPreferences initialize]):
2816
2817 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2818
2819         Fix an internal build after r235935
2820         https://bugs.webkit.org/show_bug.cgi?id=188996
2821
2822         * Carbon/HIWebView.mm:
2823         (Draw):
2824         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2825
2826 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2827
2828         Add IGNORE_WARNING_.* macros
2829         https://bugs.webkit.org/show_bug.cgi?id=188996
2830
2831         Reviewed by Michael Catanzaro.
2832
2833         * Carbon/CarbonUtils.m:
2834         (PoolCleaner):
2835         * Carbon/CarbonWindowAdapter.mm:
2836         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2837         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2838         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2839         (-[CarbonWindowAdapter _termWindowIfOwner]):
2840         (-[CarbonWindowAdapter _windowMovedToRect:]):
2841         (-[CarbonWindowAdapter setContentView:]):
2842         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2843         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2844         * Carbon/CarbonWindowFrame.m:
2845         (-[CarbonWindowFrame title]):
2846         * Carbon/HIViewAdapter.m:
2847         (+[HIViewAdapter getHIViewForNSView:]):
2848         * Carbon/HIWebView.mm:
2849         (overrideCGContext):
2850         (restoreCGContext):
2851         (Draw):
2852         * DOM/DOM.mm:
2853         * History/WebHistory.mm:
2854         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2855         * History/WebHistoryItem.mm:
2856         (-[WebHistoryItem icon]):
2857         * Misc/WebKitNSStringExtras.mm:
2858         (-[NSString _web_drawAtPoint:font:textColor:]):
2859         * Misc/WebNSImageExtras.m:
2860         (-[NSImage _web_scaleToMaxSize:]):
2861         (-[NSImage _web_dissolveToFraction:]):
2862         * Misc/WebNSPasteboardExtras.mm:
2863         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2864         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2865         * Panels/WebAuthenticationPanel.m:
2866         (-[WebAuthenticationPanel loadNib]):
2867         * Plugins/Hosted/NetscapePluginHostManager.mm:
2868         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2869         (WebKit::NetscapePluginHostManager::didCreateWindow):
2870         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2871         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2872         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2873         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2874         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2875         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2876         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2877         (-[WebHostedNetscapePluginView drawRect:]):
2878         * Plugins/Hosted/WebTextInputWindowController.m:
2879         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2880         * Plugins/WebBaseNetscapePluginView.mm:
2881         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2882         * Plugins/WebNetscapePluginPackage.mm:
2883         (-[WebNetscapePluginPackage _tryLoad]):
2884         * Plugins/WebNetscapePluginView.mm:
2885         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2886         (-[WebNetscapePluginView sendDrawRectEvent:]):
2887         (-[WebNetscapePluginView drawRect:]):
2888         * Plugins/WebPluginController.mm:
2889         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2890         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2891         * WebCoreSupport/PopupMenuMac.mm:
2892         (PopupMenuMac::populate):
2893         * WebCoreSupport/WebAlternativeTextClient.h:
2894         * WebCoreSupport/WebDragClient.mm:
2895         (WebDragClient::startDrag):
2896         * WebCoreSupport/WebFrameLoaderClient.mm:
2897         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2898         (webGetNSImage):
2899         * WebInspector/WebNodeHighlight.mm:
2900         * WebInspector/WebNodeHighlightView.mm:
2901         (-[WebNodeHighlightView drawRect:]):
2902         * WebView/WebClipView.mm:
2903         (-[WebClipView initWithFrame:]):
2904         * WebView/WebFrame.mm:
2905         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2906         (-[WebFrame _drawRect:contentsOnly:]):
2907         (-[WebFrame accessibilityRoot]):
2908         * WebView/WebFullScreenController.mm:
2909         (-[WebFullScreenController enterFullScreen:]):
2910         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2911         (-[WebFullScreenController exitFullScreen]):
2912         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2913         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2914         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2915         * WebView/WebHTMLView.mm:
2916         (-[NSWindow _web_borderView]):
2917         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2918         (-[WebHTMLView _setAsideSubviews]):
2919         (-[WebHTMLView _autoscroll]):
2920         (-[WebHTMLView drawRect:]):
2921         (-[WebHTMLView mouseDown:]):
2922         (-[WebHTMLView mouseDragged:]):
2923         (-[WebHTMLView mouseUp:]):
2924         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2925         (-[WebHTMLView knowsPageRange:]):
2926         (-[WebHTMLView accessibilityHitTest:]):
2927         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2928         (-[WebHTMLView _colorAsString:]):
2929         (-[WebHTMLView copyFont:]):
2930         (-[WebHTMLView _executeSavedKeypressCommands]):
2931         (-[WebHTMLView attachRootLayer:]):
2932         (-[WebHTMLView textStorage]):
2933         (-[WebHTMLView _updateSelectionForInputManager]):
2934         * WebView/WebPDFView.mm:
2935         (_applicationInfoForMIMEType):
2936         (-[WebPDFView centerSelectionInVisibleArea:]):
2937         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2938         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2939         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2940         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2941         * WebView/WebTextCompletionController.mm:
2942         (-[WebTextCompletionController _buildUI]):
2943         (-[WebTextCompletionController _placePopupWindow:]):
2944         * WebView/WebVideoFullscreenController.mm:
2945         * WebView/WebVideoFullscreenHUDWindowController.mm:
2946         (createMediaUIBackgroundView):
2947         * WebView/WebView.mm:
2948         (-[WebTextListTouchBarViewController initWithWebView:]):
2949         (-[WebView _dispatchTileDidDraw:]):
2950         (-[WebView encodeWithCoder:]):
2951         (-[WebView mainFrameIcon]):
2952         (LayerFlushController::flushLayers):
2953         * WebView/WebWindowAnimation.mm:
2954         (setScaledFrameForWindow):
2955
2956 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2957
2958         Remove unused needsDestruction class variables from HashTraits
2959         https://bugs.webkit.org/show_bug.cgi?id=189490
2960
2961         Reviewed by Daniel Bates.
2962
2963         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2964
2965 2018-09-07  Frederic Wang  <fwang@igalia.com>
2966
2967         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2968         https://bugs.webkit.org/show_bug.cgi?id=182230
2969
2970         Reviewed by Simon Fraser.
2971
2972         * DOM/DOMDocument.mm:
2973         (-[DOMDocument scrollingElement]): Use the new name.
2974
2975 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2976
2977         Refactor WebCore::EditAction to be an 8-bit enum class
2978         https://bugs.webkit.org/show_bug.cgi?id=189383
2979
2980         Reviewed by Dan Bernstein.
2981
2982         * WebCoreSupport/WebEditorClient.mm:
2983         (undoNameForEditAction):
2984         * WebView/WebHTMLView.mm:
2985         (-[WebHTMLView pasteFont:]):
2986         (-[WebHTMLView changeFont:]):
2987         (-[WebHTMLView changeAttributes:]):
2988         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2989         (-[WebHTMLView changeColor:]):
2990         * WebView/WebView.mm:
2991         (-[WebView setTypingStyle:]):
2992
2993 2018-09-06  Frederic Wang  <fwang@igalia.com>
2994
2995         Group options of scrollRectToVisible into a struct
2996         https://bugs.webkit.org/show_bug.cgi?id=189352
2997
2998         Reviewed by Simon Fraser.
2999
3000         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3001         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3002         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3003
3004 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3005
3006         [macOS] Cannot change font size at selection until font panel is shown
3007         https://bugs.webkit.org/show_bug.cgi?id=189295
3008         <rdar://problem/35593389>
3009
3010         Reviewed by Ryosuke Niwa.
3011
3012         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3013         WebCore ChangeLog for more details.
3014
3015         * WebView/WebHTMLView.mm:
3016         (-[WebHTMLView changeFont:]):
3017         (-[WebHTMLView changeAttributes:]):
3018         (-[WebHTMLView _originalFontA]): Deleted.
3019         (-[WebHTMLView _originalFontB]): Deleted.
3020         (fontNameForDescription): Deleted.
3021         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3022         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3023         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3024
3025 2018-09-05  Jer Noble  <jer.noble@apple.com>
3026
3027         Add MediaCapabilities as an Experimental Feature
3028         https://bugs.webkit.org/show_bug.cgi?id=189209
3029
3030         Reviewed by Eric Carlson.
3031
3032         RuntimeEnabledFeature -> Setting.
3033
3034         * WebView/WebView.mm:
3035         (-[WebView _preferencesChanged:]):
3036
3037 2018-09-04  Frederic Wang  <fwang@igalia.com>
3038
3039         Add basic support for ScrollIntoViewOptions
3040         https://bugs.webkit.org/show_bug.cgi?id=189258
3041
3042         Reviewed by Simon Fraser.
3043
3044         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3045         header so that this file can build despite the new scrollIntoView function.
3046
3047 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3048
3049         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3050         https://bugs.webkit.org/show_bug.cgi?id=188890
3051         <rdar://problem/43648605>
3052
3053         Reviewed by Tim Horton.
3054
3055         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3056         more detail.
3057
3058         * WebCoreSupport/WebPlatformStrategies.h:
3059         * WebCoreSupport/WebPlatformStrategies.mm:
3060         (WebPlatformStrategies::allStringsForType):
3061
3062 2018-09-01  Darin Adler  <darin@apple.com>
3063
3064         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3065         https://bugs.webkit.org/show_bug.cgi?id=189072
3066         Reviewed by Dan Bernstein.
3067
3068         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3069         and declarations for NSURLDownload init methods.
3070
3071         * Misc/WebDownloadInternal.h: Removed.
3072
3073         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3074         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3075         "-Wdeprecated-declarations" because the method used here is deprecated.
3076
3077         * WebView/WebView.mm:
3078         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3079         used here is deprecated.
3080
3081 2018-08-31  Chris Dumez  <cdumez@apple.com>
3082
3083         Assertion hit in ~CompletionHandler() from ~WebFrame()
3084         https://bugs.webkit.org/show_bug.cgi?id=189199
3085         <rdar://problem/42657233>
3086
3087         Reviewed by Youenn Fablet.
3088
3089         * WebCoreSupport/WebFrameLoaderClient.h:
3090         * WebCoreSupport/WebFrameLoaderClient.mm:
3091         (WebFrameLoaderClient::dispatchWillSubmitForm):
3092
3093 2018-08-31  Antti Koivisto  <antti@apple.com>
3094
3095         Replace OptionSet |= and -= operators with add() and remove() functions
3096         https://bugs.webkit.org/show_bug.cgi?id=189169
3097
3098         Reviewed by Anders Carlsson.
3099
3100         * WebView/WebFrame.mm:
3101         (-[WebFrame _drawRect:contentsOnly:]):
3102         * WebView/WebView.mm:
3103         (coreOptions):
3104
3105 2018-08-31  Frederic Wang  <fwang@igalia.com>
3106
3107         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3108         https://bugs.webkit.org/show_bug.cgi?id=182053
3109
3110         Reviewed by Simon Fraser.
3111
3112         Add developer flag to use standard behavior for scrolling* attributes.
3113
3114         * WebView/WebPreferenceKeysPrivate.h:
3115         * WebView/WebPreferences.mm:
3116         (+[WebPreferences initialize]):
3117         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3118         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3119         * WebView/WebPreferencesPrivate.h:
3120         * WebView/WebView.mm:
3121         (-[WebView _preferencesChanged:]):
3122
3123 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3124
3125         Implement the Web Share API
3126         https://bugs.webkit.org/show_bug.cgi?id=171100
3127         <rdar://problem/31751734>
3128
3129         Reviewed by Tim Horton.
3130
3131         * WebCoreSupport/WebChromeClient.h:
3132         * WebCoreSupport/WebChromeClient.mm:
3133         (WebChromeClient::showShareSheet):
3134         Empty declaration of showShareSheet.
3135
3136 2018-08-29  Youenn Fablet  <youenn@apple.com>
3137
3138         Remove WebRTC legacy API implementation
3139         https://bugs.webkit.org/show_bug.cgi?id=189040
3140
3141         Reviewed by Eric Carlson.
3142
3143         * WebView/WebPreferenceKeysPrivate.h:
3144         * WebView/WebPreferences.mm:
3145         (+[WebPreferences initialize]):
3146         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3147         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3148         * WebView/WebPreferencesPrivate.h:
3149         * WebView/WebView.mm:
3150         (-[WebView _preferencesChanged:]):
3151
3152 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3153
3154         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3155         https://bugs.webkit.org/show_bug.cgi?id=189054
3156
3157         Reviewed by Andy Estes.
3158
3159         Remove the pasteboard type argument from readURLFromPasteboard.
3160
3161         * WebCoreSupport/WebPlatformStrategies.h:
3162         * WebCoreSupport/WebPlatformStrategies.mm:
3163         (WebPlatformStrategies::readURLFromPasteboard):
3164
3165 2018-08-27  Keith Rollin  <krollin@apple.com>
3166
3167         Unreviewed build fix -- disable LTO for production builds
3168
3169         * Configurations/Base.xcconfig:
3170
3171 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3172
3173         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3174         https://bugs.webkit.org/show_bug.cgi?id=188931
3175
3176         Reviewed by Wenson Hsieh.
3177
3178         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3179
3180 2018-08-27  Keith Rollin  <krollin@apple.com>
3181
3182         Build system support for LTO
3183         https://bugs.webkit.org/show_bug.cgi?id=187785
3184         <rdar://problem/42353132>
3185
3186         Reviewed by Dan Bernstein.
3187
3188         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3189         LTO.
3190
3191         * Configurations/Base.xcconfig:
3192         * Configurations/DebugRelease.xcconfig:
3193
3194 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3195
3196         Pass in IsComposed flag to Event constructors
3197         https://bugs.webkit.org/show_bug.cgi?id=188720
3198         <rdar://problem/43580387>
3199
3200         Reviewed by Simon Fraser.
3201
3202         * WebView/WebPDFView.mm:
3203         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3204         whether it's simulated or not.
3205
3206 2018-08-23  Mark Lam  <mark.lam@apple.com>
3207
3208         Move vmEntryGlobalObject() to VM from CallFrame.
3209         https://bugs.webkit.org/show_bug.cgi?id=188900
3210         <rdar://problem/43655753>
3211
3212         Reviewed by Michael Saboff.
3213
3214         * WebView/WebScriptDebugger.mm:
3215         (WebScriptDebugger::sourceParsed):
3216
3217 2018-08-23  Andy Estes  <aestes@apple.com>
3218
3219         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3220         https://bugs.webkit.org/show_bug.cgi?id=188829
3221
3222         Reviewed by Tim Horton.
3223
3224         * Configurations/FeatureDefines.xcconfig:
3225
3226 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3227
3228         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3229         https://bugs.webkit.org/show_bug.cgi?id=188777
3230
3231         Reviewed by Simon Fraser.
3232
3233         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3234         being "true" before the code change.
3235
3236         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3237
3238         * WebView/WebPDFView.mm:
3239         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3240
3241 2018-08-21  Daniel Bates  <dabates@apple.com>
3242
3243         Replace TextCheckingTypeMask with OptionSet
3244         https://bugs.webkit.org/show_bug.cgi?id=188678
3245
3246         Reviewed by Antti Koivisto.
3247
3248         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3249         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3250         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3251         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3252
3253         * WebCoreSupport/WebEditorClient.h:
3254         * WebCoreSupport/WebEditorClient.mm:
3255         (WebEditorClient::checkTextOfParagraph):
3256         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3257         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3258         left as this is more readable and unncessary now that modern compilers like Clang have
3259         diagnostics to catch accidental assignments when equality was intended.
3260         (WebEditorClient::didCheckSucceed):
3261         * WebView/WebView.mm:
3262         (coreTextCheckingType):
3263         (textCheckingResultFromNSTextCheckingResult):
3264
3265 2018-08-21  Daniel Bates  <dabates@apple.com>
3266
3267         [iOS][WK1] Support toggling continuous spell checking from tests
3268         https://bugs.webkit.org/show_bug.cgi?id=188763
3269
3270         Reviewed by Simon Fraser.
3271
3272         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3273         spell checking from tests in iOS WebKit Legacy.
3274
3275         * WebCoreSupport/WebEditorClient.h:
3276         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3277         * WebCoreSupport/WebEditorClient.mm:
3278         * WebView/WebView.h:
3279         * WebView/WebView.mm:
3280         (-[WebView toggleContinuousSpellChecking:]):
3281         (-[WebView toggleSmartInsertDelete:]):
3282
3283 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3284
3285         Add some plumbing for safe browsing
3286         https://bugs.webkit.org/show_bug.cgi?id=188709
3287
3288         Reviewed by Tim Horton.
3289
3290         * WebCoreSupport/WebFrameLoaderClient.h:
3291         * WebCoreSupport/WebFrameLoaderClient.mm:
3292         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3293
3294 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3295
3296         Replace canBubble and cancelable booleans in Event by enum classes
3297         https://bugs.webkit.org/show_bug.cgi?id=188692
3298
3299         Reviewed by Alex Christensen.
3300
3301         * WebView/WebPDFView.mm:
3302         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3303         * WebView/WebView.mm:
3304         (-[WebView _dispatchUnloadEvent]):
3305
3306 2018-08-16  Jer Noble  <jer.noble@apple.com>
3307
3308         Add Experimental Feature support for SourceBuffer.changeType()
3309         https://bugs.webkit.org/show_bug.cgi?id=188626
3310         <rdar://problem/43356021>
3311
3312         Reviewed by Eric Carlson.
3313
3314         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3315
3316         * WebView/WebPreferenceKeysPrivate.h:
3317         * WebView/WebPreferences.mm:
3318         (+[WebPreferences initialize]):
3319         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3320         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3321         * WebView/WebPreferencesPrivate.h:
3322         * WebView/WebView.mm:
3323         (-[WebView _preferencesChanged:]):
3324
3325 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3326
3327         Support drag-and-drop for input[type=color]
3328         https://bugs.webkit.org/show_bug.cgi?id=188464
3329
3330         Reviewed by Wenson Hsieh.
3331
3332         * WebCoreSupport/WebPlatformStrategies.h:
3333         * WebCoreSupport/WebPlatformStrategies.mm:
3334         (WebPlatformStrategies::setColor):
3335
3336 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3337
3338         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3339         https://bugs.webkit.org/show_bug.cgi?id=188569
3340         <rdar://problem/34201095>
3341
3342         Reviewed by Megan Gardner.
3343
3344         * WebView/WebImmediateActionController.mm:
3345         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3346         Speculative fix; the crashes indicate font is null, but we just checked it,
3347         so it must be getting made null by convertFont:toSize:. Check again!
3348
3349 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3350
3351         Use a 1-byte enum class for TextDirection
3352         https://bugs.webkit.org/show_bug.cgi?id=188350
3353
3354         Reviewed by Simon Fraser.
3355
3356         * WebCoreSupport/PopupMenuMac.mm:
3357         (PopupMenuMac::populate):
3358         (PopupMenuMac::show):
3359         * WebCoreSupport/WebFrameLoaderClient.mm:
3360         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3361         * WebView/WebFrame.mm:
3362         (-[WebFrame _dispatchDidReceiveTitle:]):
3363
3364 2018-08-09  Ali Juma  <ajuma@chromium.org>
3365
3366         Import WPTs for IntersectionObserver
3367         https://bugs.webkit.org/show_bug.cgi?id=188416
3368
3369         Reviewed by Simon Fraser.
3370
3371         * WebView/WebPreferencesPrivate.h:
3372
3373 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3374
3375         Follow-up build fix for r234685
3376         https://bugs.webkit.org/show_bug.cgi?id=188245
3377
3378         Unreviewed build fix.
3379
3380         * WebCoreSupport/WebSecurityOriginPrivate.h:
3381
3382 2018-08-05  Darin Adler  <darin@apple.com>
3383
3384         [Cocoa] More tweaks and refactoring to prepare for ARC
3385         https://bugs.webkit.org/show_bug.cgi?id=188245
3386
3387         Reviewed by Dan Bernstein.
3388
3389         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3390
3391         * Carbon/CarbonWindowFrame.m:
3392         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3393
3394         * DOM/DOM.mm:
3395         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3396         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3397         garbage collection so this method isn't useful.
3398
3399         * DOM/DOMXPath.mm:
3400         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3401         Objective-C garbage collection so this method isn't useful.
3402
3403         * History/WebHistory.mm:
3404         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3405
3406         * Misc/WebElementDictionary.mm:
3407         (addLookupKey): Use a bridging cast.
3408         (cacheValueForKey): Ditto.
3409         (-[WebElementDictionary _fillCache]): Ditto.
3410         (-[WebElementDictionary objectForKey:]): Ditto.
3411
3412         * Misc/WebKitNSStringExtras.mm:
3413         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3414         (-[NSString _web_widthWithFont:]): Ditto.
3415         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3416
3417         * Misc/WebLocalizableStrings.mm:
3418         (WebLocalizedString): Use a bridging cast.
3419
3420         * Misc/WebNSDataExtras.mm:
3421         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3422         and use CFBridgingRelease instead of calling autorelease directly.
3423         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3424         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3425         on the amount of explicit release and autorelease.
3426
3427         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3428         * Misc/WebNSDictionaryExtras.m:
3429         (-[NSDictionary _webkit_intForKey:]): Deleted.
3430         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3431         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3432         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3433         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3434         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3435         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3436
3437         * Misc/WebStringTruncator.mm:
3438         (fontFromNSFont): Use a bridging cast.
3439
3440         * Plugins/Hosted/NetscapePluginHostManager.mm:
3441         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3442
3443         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3444         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3445         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3446         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3447         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3448         * Plugins/Hosted/ProxyInstance.mm:
3449         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3450         * Plugins/WebBasePluginPackage.mm:
3451         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3452         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3453         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3454         * Plugins/WebNetscapePluginPackage.mm:
3455         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3456
3457         * Plugins/WebNetscapePluginView.mm:
3458         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3459         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3460         (-[WebNetscapePluginView status:]): Use a bridging cast.
3461         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3462
3463         * Plugins/WebPluginController.mm:
3464         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3465
3466         * Plugins/WebPluginDatabase.mm:
3467         (checkCandidate): Use explicit __strong for out argument types.
3468
3469         * Plugins/npapi.mm:
3470         (pluginViewForInstance): Use a bridging cast.
3471
3472