Use is<>() / downcast<>() for GraphicsLayer subclasses
[WebKit-https.git] / Source / WebKit2 / ChangeLog
1 2014-10-10  Chris Dumez  <cdumez@apple.com>
2
3         Use is<>() / downcast<>() for GraphicsLayer subclasses
4         https://bugs.webkit.org/show_bug.cgi?id=137595
5
6         Reviewed by Darin Adler.
7
8         Use is<>() / downcast<>() for GraphicsLayer subclasses and clean up the
9         surrounding code.
10
11         * WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
12         * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
13         (WebKit::RemoteLayerTreeDrawingArea::flushLayers):
14         * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
15         (WebKit::TiledCoreAnimationDrawingArea::layerForTransientZoom):
16         (WebKit::TiledCoreAnimationDrawingArea::shadowLayerForTransientZoom):
17
18 2014-10-10  Pascal Jacquemart  <p.jacquemart@samsung.com>
19
20         Fix debug build on EFL after r174584
21         https://bugs.webkit.org/show_bug.cgi?id=137613
22
23         Reviewed by Christophe Dumez.
24
25         * UIProcess/efl/RequestManagerClientEfl.cpp:
26         (WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
27
28 2014-10-10  Chris Dumez  <cdumez@apple.com>
29
30         Use is<>() / downcast<>() for RenderBoxModelObject
31         https://bugs.webkit.org/show_bug.cgi?id=137587
32
33         Reviewed by Mihnea Ovidenie.
34
35         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
36         surrounding code.
37
38         * WebProcess/Plugins/PluginView.cpp:
39         (WebKit::PluginView::renderer):
40         (WebKit::PluginView::invalidateRect):
41
42 2014-10-10  Pascal Jacquemart  <p.jacquemart@samsung.com>
43
44         [SOUP] Remove custom URI schemes implementation
45         https://bugs.webkit.org/show_bug.cgi?id=128169
46
47         Reviewed by Carlos Garcia Campos.
48
49         * Shared/WebProcessCreationParameters.cpp:
50         (WebKit::WebProcessCreationParameters::encode):
51         (WebKit::WebProcessCreationParameters::decode):
52         * Shared/WebProcessCreationParameters.h:
53         * UIProcess/API/C/soup/WKAPICastSoup.h:
54         * UIProcess/API/C/soup/WKContextSoup.cpp: Removed.
55         * UIProcess/API/C/soup/WKSoupRequestManager.cpp: Removed.
56         * UIProcess/WebContext.cpp:
57         (WebKit::WebContext::WebContext):
58         * UIProcess/WebPageProxy.cpp:
59         (WebKit::WebPageProxy::didReceiveURIRequest): Deleted.
60         * UIProcess/WebPageProxy.h:
61         * UIProcess/WebPageProxy.messages.in:
62         * UIProcess/soup/WebSoupRequestManagerClient.cpp: Removed.
63         * UIProcess/soup/WebSoupRequestManagerProxy.cpp: Removed.
64         * UIProcess/soup/WebSoupRequestManagerProxy.messages.in: Removed.
65         * WebProcess/WebProcess.cpp:
66         (WebKit::WebProcess::WebProcess):
67         * WebProcess/soup/WebKitSoupRequestGeneric.cpp:
68         (webkitSoupRequestGenericSendAsync):
69         (webkitSoupRequestGenericSendFinish):
70         * WebProcess/soup/WebProcessSoup.cpp:
71         (WebKit::WebProcess::platformInitializeWebProcess):
72         * WebProcess/soup/WebSoupRequestManager.cpp: Removed.
73         * WebProcess/soup/WebSoupRequestManager.messages.in: Removed.
74
75 2014-10-09  Dean Jackson  <dino@apple.com>
76
77         Remove ENABLE_CSS3_CONDITIONAL_RULES
78         https://bugs.webkit.org/show_bug.cgi?id=137571
79
80         Reviewed by Simon Fraser.
81
82         * Configurations/FeatureDefines.xcconfig:
83
84 2014-10-09  Tim Horton  <timothy_horton@apple.com>
85
86         Move ServicesOverlayController to WebCore
87         https://bugs.webkit.org/show_bug.cgi?id=137416
88         <rdar://problem/18546283>
89
90         Reviewed by Anders Carlsson.
91
92         * Platform/Logging.h:
93         Move Services logging channel to WebCore.
94
95         * WebKit2.xcodeproj/project.pbxproj:
96         * WebProcess/WebCoreSupport/WebChromeClient.cpp:
97         (WebKit::WebChromeClient::handleTelephoneNumberClick):
98         (WebKit::WebChromeClient::handleSelectionServiceClick):
99         (WebKit::WebChromeClient::hasRelevantSelectionServices):
100         Implement services-related ChromeClient callbacks.
101         Clicks are forwarded to WebPageMac where they do what they used to;
102         hasRelevantSelectionServices is implemented as it was when it lived
103         inside ServicesOverlayController.
104
105         * WebProcess/WebCoreSupport/WebChromeClient.h:
106         * WebProcess/WebCoreSupport/WebEditorClient.cpp:
107         (WebKit::WebEditorClient::selectedTelephoneNumberRangesChanged): Deleted.
108         (WebKit::WebEditorClient::selectionRectsDidChange): Deleted.
109         * WebProcess/WebCoreSupport/WebEditorClient.h:
110         Remove WebEditorClient overrides for now-removed functions.
111
112         * WebProcess/WebPage/WebPage.cpp:
113         (WebKit::WebPage::WebPage):
114         (WebKit::WebPage::updatePreferences):
115         Forward serviceControlsEnabled setting to WebCore.
116
117         (WebKit::WebPage::servicesOverlayController): Deleted.
118         * WebProcess/WebPage/WebPage.h:
119         (WebKit::WebPage::serviceControlsEnabled): Deleted.
120
121 2014-10-09  Andy Estes  <aestes@apple.com>
122
123         [iOS] Crash in CFURLDownloadClient.didFail if the download has a null resumeData
124         https://bugs.webkit.org/show_bug.cgi?id=137551
125
126         Reviewed by David Kilzer.
127
128         CFDataGetBytePtr() and CFDataGetLength() crash if passed a null value.
129
130         * Shared/Downloads/ios/DownloadIOS.mm:
131         (WebKit::setUpDownloadClient):
132
133 2014-10-09  Carlos Garcia Campos  <cgarcia@igalia.com>
134
135         [X11] Plugin process crashes in NetscapePlugin::platformPostInitialize()
136         https://bugs.webkit.org/show_bug.cgi?id=137426
137
138         Reviewed by Darin Adler.
139
140         For some reason flash crashes when NPP_GetValue is called with
141         NPPVpluginCancelSrcStream, but only in windowed mode. Not calling
142         NPP_GetValue and unconditionally loading the source URL in the
143         browser fixes the crash and plugins work normally. We can handle
144         this particular case with a new quirk.
145
146         * Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
147         (WebKit::NetscapePluginModule::determineQuirks): Add
148         DoNotCancelSrcStreamInWindowedMode quirk if it's flash plugin.
149         * Shared/Plugins/PluginQuirks.h: Add
150         DoNotCancelSrcStreamInWindowedMode quirk.
151         * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
152         (WebKit::NetscapePlugin::shouldLoadSrcURL): Return early if plugin
153         is windowed and DoNotCancelSrcStreamInWindowedMode quirk is present.
154
155 2014-10-09  Chris Dumez  <cdumez@apple.com>
156
157         Use is<>() / downcast<>() for Widget subclasses
158         https://bugs.webkit.org/show_bug.cgi?id=137549
159
160         Reviewed by Darin Adler.
161
162         Use is<>() / downcast<>() for Widget subclasses and clean up the
163         surrounding code.
164
165         * Shared/WebRenderObject.cpp:
166         (WebKit::WebRenderObject::WebRenderObject):
167
168 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
169
170         [GTK] Use the PageLoadState observer also to monitor title and estimated load progress
171         https://bugs.webkit.org/show_bug.cgi?id=136997
172
173         Reviewed by Gustavo Noronha Silva.
174
175         * UIProcess/API/gtk/WebKitLoaderClient.cpp:
176         (attachLoaderClientToView): Remove implementation of
177         didReceiveTitleForFrame, didStartProgress, didChangeProgress and
178         didFinishProgress.
179         (didReceiveTitleForFrame): Deleted.
180         (didChangeProgress): Deleted.
181         * UIProcess/API/gtk/WebKitWebView.cpp:
182         (webkit_web_view_get_estimated_load_progress): Return the value
183         directly from the PageLoadState object, since we don't need to
184         cache the value anymore.
185         (webkitWebViewSetTitle): Deleted.
186         (webkitWebViewSetEstimatedLoadProgress): Deleted.
187         * UIProcess/API/gtk/WebKitWebViewPrivate.h:
188
189 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
190
191         Race condition with WebKitWebView:is-loading after starting page load
192         https://bugs.webkit.org/show_bug.cgi?id=136692
193
194         Reviewed by Gustavo Noronha Silva.
195
196         Use PageLoadState::Observer to update both is-loading and uri
197         properties, instead of manually update them. This ensures that our
198         web view is always in sync with the WebPageProxy so that
199         webkit_web_view_is_loading() returns true right after requesting
200         any load. We still need to manually set the is-loading property
201         only in the case where we delay the emission of the load-changed
202         signals when waiting for the main resource. The bahaviour is a bit
203         different but still consistent with what our API documentation says.
204
205         * UIProcess/API/gtk/WebKitLoaderClient.cpp:
206         (attachLoaderClientToView): Remove
207         didSameDocumentNavigationForFrame implementation, since we are
208         already notified about the URL change by the PageLoadState::Observer.
209         (didSameDocumentNavigationForFrame): Deleted.
210         * UIProcess/API/gtk/WebKitWebView.cpp:
211         (webkitWebViewSetIsLoading): No longer update the URI when
212         changing the is-loading property.
213         (webkitWebViewConstructed): Crate a PageLoadStateObserver and add
214         it to the PageLoadState.
215         (webkitWebViewDispose): Remove the PageLoadStateObserver from the PageLoadState.
216         (webkitWebViewEmitLoadChanged): Add isDelayedEvent parameter to
217         update the is-loading property accordingly when emitting the
218         delayed events.
219         (webkitWebViewEmitDelayedLoadEvents): Pass true as isDelayedEvent
220         parameter of webkitWebViewEmitLoadChanged().
221         (webkitWebViewLoadChanged): Pass false as isDelayedEvent parameter
222         of webkitWebViewEmitLoadChanged().
223         (webkitWebViewLoadFailed):
224         (webkitWebViewLoadFailedWithTLSErrors):
225         (webkitWebViewUpdateURI): Deleted.
226         * UIProcess/API/gtk/WebKitWebViewPrivate.h:
227
228 2014-10-08  Christophe Dumez  <cdumez@apple.com>
229
230         Use is<>() / downcast<>() for RenderBlock objects
231         https://bugs.webkit.org/show_bug.cgi?id=137512
232
233         Reviewed by Darin Adler.
234
235         Use is<>() / downcast<>() for RenderBlock objects and clean up the 
236         surrounding code.
237
238         * WebProcess/WebPage/ios/WebPageIOS.mm:
239         (WebKit::WebPage::rangeForWebSelectionAtPosition):
240         (WebKit::WebPage::contractedRangeFromHandle):
241
242 2014-10-08  Ada Chan  <adachan@apple.com>
243
244         Implement WKPageIsPlayingAudio().
245         https://bugs.webkit.org/show_bug.cgi?id=137048
246
247         Reviewed by Darin Adler.
248
249         * UIProcess/API/C/WKPage.cpp:
250         (WKPageIsPlayingAudio):
251
252 2014-10-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
253
254         [EFL][CoordinatedGraphics] All EFL layout tests are broken since r174231
255         https://bugs.webkit.org/show_bug.cgi?id=137443
256
257         Reviewed by Zoltan Herczeg.
258
259         EFL layout test and MiniBrowser have broken since r174231. r174231 was to move PageOverlay implementation
260         from WebKit2 to WebCore with lazy initializing of PageOverlayController. It caused all EFL layout tests
261         crash and build break. To restore EFL layout test, this patch sets viewOverlayRootLayer through
262         attachViewOverlayGraphicsLayer() as mac port's one in r174231.
263
264         * WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
265         (WebKit::CoordinatedDrawingArea::attachViewOverlayGraphicsLayer):
266         * WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
267         * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
268         (WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
269         (WebKit::CoordinatedLayerTreeHost::updateRootLayers):
270         (WebKit::CoordinatedLayerTreeHost::setViewOverlayRootLayer):
271         (WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
272         (WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
273         * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
274
275 2014-10-08  Commit Queue  <commit-queue@webkit.org>
276
277         Unreviewed, rolling out r174335.
278         https://bugs.webkit.org/show_bug.cgi?id=137515
279
280         It broke EFL layout test totally (Requested by gyuyoung on
281         #webkit).
282
283         Reverted changeset:
284
285         "[EFL] Introduce EWebKit_Extension"
286         https://bugs.webkit.org/show_bug.cgi?id=134921
287         http://trac.webkit.org/changeset/174335
288
289 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
290
291         [GTK] Make forwarding headers generation depend on source code
292         https://bugs.webkit.org/show_bug.cgi?id=137394
293
294         Reviewed by Philippe Normand.
295
296         Only run generate-forwarding-headers.pl when source code changes
297         and use a different target for the symlinks.
298
299         * PlatformGTK.cmake:
300
301 2014-10-07  Pascal Jacquemart  <p.jacquemart@samsung.com>
302
303         [EFL] Enable custom URI schemes with CustomProtocols
304         https://bugs.webkit.org/show_bug.cgi?id=128177
305
306         Reviewed by Gyuyoung Kim.
307
308         Fixing ewk_context_url_scheme_register() ewebkit2 API
309         rely on r162449 - CustomProtocols implementation from Carlos Garcia Campos
310
311         * PlatformEfl.cmake:
312         * UIProcess/API/efl/ewk_context.h:
313         * UIProcess/API/efl/ewk_url_scheme_request.cpp:
314         (EwkUrlSchemeRequest::EwkUrlSchemeRequest):
315         (EwkUrlSchemeRequest::finish):
316         * UIProcess/API/efl/ewk_url_scheme_request_private.h:
317         (EwkUrlSchemeRequest::create):
318         * UIProcess/API/efl/tests/test_ewk2_context.cpp:
319         (TEST_F):
320         * UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp:
321         * UIProcess/efl/RequestManagerClientEfl.cpp:
322         (WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
323         (WebKit::RequestManagerClientEfl::startLoading):
324         (WebKit::RequestManagerClientEfl::stopLoading):
325         (WebKit::RequestManagerClientEfl::registerURLSchemeHandler):
326         (WebKit::EwkUrlSchemeHandler::EwkUrlSchemeHandler): Deleted.
327         (WebKit::RequestManagerClientEfl::didReceiveURIRequest): Deleted.
328         * UIProcess/efl/RequestManagerClientEfl.h:
329         * UIProcess/efl/WebContextEfl.cpp:
330         (WebKit::WebContext::platformInitializeWebProcess):
331         * UIProcess/soup/WebContextSoup.cpp:
332         (WebKit::WebContext::platformInitializeNetworkProcess):
333
334 2014-10-07  Sungmann Cho  <sungmann.cho@navercorp.com>
335
336         Remove WKPageCreateSnapshotOfVisibleContent API.
337         https://bugs.webkit.org/show_bug.cgi?id=66979
338
339         Reviewed by Darin Adler.
340
341         After the landing of the first patch of webkit.org/b/66979,
342         WKPageCreateSnapshotOfVisibleContent API has been neglected for years.
343         Currently, this is not used anywhere and does not break the nightlies.
344         So we can remove this.
345
346         * UIProcess/API/C/WKPage.cpp:
347         (WKPageCreateSnapshotOfVisibleContent): Deleted.
348         * UIProcess/API/C/WKPagePrivate.h:
349
350 2014-10-07  Sungmann Cho  <sungmann.cho@navercorp.com>
351
352         Remove WKPageSetInvalidMessageFunction.
353         https://bugs.webkit.org/show_bug.cgi?id=137509
354
355         Reviewed by Benjamin Poulain.
356
357         According to the FIXME comment in WKPageSetInvalidMessageFunction,
358         we can remove this function when doing so won't break the nightlies.
359         Currently, this is not used anywhere and does not break the nightlies.
360         So we can remove this.
361
362         * UIProcess/API/C/WKPage.cpp:
363         (WKPageSetInvalidMessageFunction): Deleted.
364         * UIProcess/API/C/WKPagePrivate.h:
365
366 2014-10-07  Christophe Dumez  <cdumez@apple.com>
367
368         [WK2] Use is<>() / downcast<>() for DrawingArea subclasses
369         https://bugs.webkit.org/show_bug.cgi?id=137497
370
371         Reviewed by Benjamin Poulain.
372
373         Use is<>() / downcast<>() for DrawingArea subclasses.
374
375         * WebProcess/WebPage/DrawingArea.h:
376         * WebProcess/WebPage/WebPage.cpp:
377         (WebKit::WebPage::didCommitLoad):
378         * WebProcess/WebPage/ios/WebPageIOS.mm:
379         (WebKit::WebPage::synchronizeDynamicViewportUpdate):
380         * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
381         * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
382
383 2014-10-07  Simon Fraser  <simon.fraser@apple.com>
384
385         Roll-over Changelogs.
386
387         * ChangeLog-2014-10-07: Copied from Source/WebKit2/ChangeLog.
388
389 == Rolled over to ChangeLog-2014-10-07 ==