[Win] Add null pointer check in gesture handling.
[WebKit-https.git] / Source / WebKit / win / ChangeLog
1 2016-07-06  Per Arne Vollan  <pvollan@apple.com>
2
3         [Win] Add null pointer check in gesture handling.
4         https://bugs.webkit.org/show_bug.cgi?id=159454
5
6         Reviewed by Brent Fulgham.
7
8         * WebView.cpp:
9         (WebView::gesture):
10
11 2016-07-01  Per Arne Vollan  <pvollan@apple.com>
12
13         ASSERTION FAILED: info.bmBitsPixel == 32
14         https://bugs.webkit.org/show_bug.cgi?id=17737
15
16         Reviewed by Brent Fulgham.
17
18         The ::SelectObject call will fail if m_backingStoreBitmap is already selected into a device context.
19         This happens when this method is called indirectly from WebView::updateBackingStore during normal
20         painting. There is no point continuing, since we would just be scrolling a 1x1 bitmap which is
21         selected into the device context by default. We can just scroll by repainting the scroll rectangle.
22
23         * WebView.cpp:
24         (WebView::scrollBackingStore): Invalidate the scroll rectangle if the ::SelectObject call fails.
25
26 2016-07-01  Youenn Fablet  <youennf@gmail.com>
27
28         Add a runtime flag for DOM iterators
29         https://bugs.webkit.org/show_bug.cgi?id=159300
30
31         Reviewed by Alex Christensen.
32
33         * WebPreferenceKeysPrivate.h:
34         * WebPreferences.cpp:
35         (WebPreferences::domIteratorEnabled):
36         (WebPreferences::setDOMIteratorEnabled):
37         (WebView::notifyPreferencesChanged):
38         * WebPreferencesreferences.h:
39         * WebView.cpp:
40         (WebView::notifyPreferencesChanged):
41
42 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
43
44         [Win] Custom elements tests are failing.
45         https://bugs.webkit.org/show_bug.cgi?id=159139
46
47         Reviewed by Alex Christensen.
48
49         Add preference for enabling custom element API.
50
51         * Interfaces/IWebPreferencesPrivate.idl:
52         * WebPreferenceKeysPrivate.h:
53         * WebPreferences.cpp:
54         (WebPreferences::initializeDefaultSettings):
55         (WebPreferences::customElementsEnabled):
56         (WebPreferences::setCustomElementsEnabled):
57         * WebPreferences.h:
58         * WebView.cpp:
59         (WebView::notifyPreferencesChanged):
60
61 2016-06-23  Per Arne Vollan  <pvollan@apple.com>
62
63         [Win] The test accessibility/aria-labelledby-overrides-label.html is failing.
64         https://bugs.webkit.org/show_bug.cgi?id=159057
65
66         Reviewed by Brent Fulgham.
67
68         The test expects the label to have a static text role, but currently it has a
69         group role.
70  
71         * AccessibleBase.cpp:
72         (MSAARole): Change the role of labels to static text.
73
74 2016-06-23  Alex Christensen  <achristensen@webkit.org>
75
76         Remove unused didCancelAuthenticationChallenge
77         https://bugs.webkit.org/show_bug.cgi?id=158819
78
79         Reviewed by David Kilzer.
80
81         * WebCoreSupport/WebFrameLoaderClient.cpp:
82         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.
83         * WebCoreSupport/WebFrameLoaderClient.h:
84
85 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
86
87         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
88         https://bugs.webkit.org/show_bug.cgi?id=158934
89
90         Reviewed by Brent Fulgham.
91
92         Add a method to delete all indexed databases.
93
94         * Interfaces/IWebDatabaseManager.idl:
95         * WebDatabaseManager.cpp:
96         (WebDatabaseManager::QueryInterface):
97         (WebDatabaseManager::deleteAllIndexedDatabases):
98         * WebDatabaseManager.h:
99
100 2016-06-17  Per Arne Vollan  <pvollan@apple.com>
101
102         [Win] Rendering is not scaled correctly if process is DPI aware.
103         https://bugs.webkit.org/show_bug.cgi?id=158781
104
105         Reviewed by Brent Fulgham.
106
107         Scale the root graphics layer with the device scale factor.
108
109         * WebView.cpp:
110         (WebView::setAcceleratedCompositing):
111
112 2016-06-15  Chris Dumez  <cdumez@apple.com>
113
114         Drop some unnecessary header includes
115         https://bugs.webkit.org/show_bug.cgi?id=158788
116
117         Reviewed by Alexey Proskuryakov.
118
119         Drop some unnecessary header includes in headers to speed up build time.
120
121         * Plugins/PluginView.cpp:
122
123 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
124
125         Enabling Shadow DOM for all platforms
126         https://bugs.webkit.org/show_bug.cgi?id=158738
127
128         Reviewed by Ryosuke Niwa.
129
130         Removed Shadow DOM from options (enabled by default)
131         (comprises removal of corresponding preprocessor directives)
132
133         * WebView.cpp:
134
135 2016-06-13  Alex Christensen  <achristensen@webkit.org>
136
137         Add WebSocketProvider stub
138         https://bugs.webkit.org/show_bug.cgi?id=158702
139
140         Reviewed by Brady Eidson.
141
142         * WebSocketProvider.h: Added.
143         * WebView.cpp:
144         (WebView::initWithFrame):
145
146 2016-06-10  Alex Christensen  <achristensen@webkit.org>
147
148         Introduce WTF::UniqueRef
149         https://bugs.webkit.org/show_bug.cgi?id=158596
150
151         Reviewed by Brady Eidson.
152
153         * WebView.cpp:
154         (WebView::initWithFrame):
155
156 2016-06-09  Alex Christensen  <achristensen@webkit.org>
157
158         Fix Windows build.
159
160         * WebKit.resources/resource.h: Removed.
161         * resource.h: Copied from WebKit.resources/resource.h.
162
163 2016-06-09  Alex Christensen  <achristensen@webkit.org>
164
165         Actually fix Windows build after r201894
166         https://bugs.webkit.org/show_bug.cgi?id=158588
167
168         * WebView.cpp:
169         (WebView::initWithFrame):
170
171 2016-06-09  Alex Christensen  <achristensen@webkit.org>
172
173         Clean up WebKit.vcxproj directory after switching to CMake.
174
175         * WebKit.resources/resource.h: Copied from WebKit.vcxproj/WebKit/resource.h.
176
177 2016-06-09  Alex Christensen  <achristensen@webkit.org>
178
179         Unreviewed build fix after r201894
180         https://bugs.webkit.org/show_bug.cgi?id=158588
181
182         * WebCoreSupport/WebEditorClient.cpp:
183         (WebEditorClient::~WebEditorClient):
184         (WebEditorClient::isContinuousSpellCheckingEnabled):
185         (WebEditorClient::pageDestroyed): Deleted.
186         * WebCoreSupport/WebEditorClient.h:
187         * WebView.cpp:
188         (WebView::initWithFrame):
189
190 2016-06-08  Per Arne Vollan  <pvollan@apple.com>
191
192         [Win] Shadow DOM tests are failing.
193         https://bugs.webkit.org/show_bug.cgi?id=158524
194
195         Reviewed by Brent Fulgham.
196
197         Add preference for enabling Shadow DOM.
198
199         * Interfaces/IWebPreferencesPrivate.idl:
200         * WebPreferenceKeysPrivate.h:
201         * WebPreferences.cpp:
202         (WebPreferences::initializeDefaultSettings):
203         (WebPreferences::shadowDOMEnabled):
204         (WebPreferences::setShadowDOMEnabled):
205         * WebPreferences.h:
206         * WebView.cpp:
207         (WebView::notifyPreferencesChanged):
208
209 2016-06-07  Per Arne Vollan  <pvollan@apple.com>
210
211         [Win][IndexedDB] Crash when running worker test.
212         https://bugs.webkit.org/show_bug.cgi?id=158434
213
214         Reviewed by Alex Christensen.
215
216         Initialize main runloop, otherwise RunLoop::main() will return nullptr.
217
218         * WebView.cpp:
219         (WebView::WebView):
220
221 2016-06-03  Chris Dumez  <cdumez@apple.com>
222
223         Unreviewed, roll out r196633 as it broke PageCache on iOS for WebKit.org
224         <rdar://problem/26521101>
225
226         * WebCoreSupport/WebVisitedLinkStore.cpp:
227         (WebVisitedLinkStore::removeAllVisitedLinks):
228         (WebVisitedLinkStore::addVisitedLinkHash):
229
230 2016-06-03  Per Arne Vollan  <pvollan@apple.com>
231
232         [Win] Implement WebView::removeAllUserContentFromGroup
233         https://bugs.webkit.org/show_bug.cgi?id=158343
234
235         Reviewed by Brent Fulgham.
236
237         * WebView.cpp:
238         (WebView::removeAllUserContentFromGroup):
239
240 2016-06-02  Per Arne Vollan  <pvollan@apple.com>
241
242         [Win] Fetch API tests are failing.
243         https://bugs.webkit.org/show_bug.cgi?id=158296
244
245         Reviewed by Alex Christensen.
246
247         Add preference for enabling Fetch API.
248
249         * Interfaces/IWebPreferencesPrivate.idl:
250         * WebPreferenceKeysPrivate.h:
251         * WebPreferences.cpp:
252         (WebPreferences::initializeDefaultSettings):
253         (WebPreferences::fetchAPIEnabled):
254         (WebPreferences::setFetchAPIEnabled):
255         * WebPreferences.h:
256         * WebView.cpp:
257         (WebView::notifyPreferencesChanged):
258
259 2016-06-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
260
261         Use more references in ResourceLoader related code
262         https://bugs.webkit.org/show_bug.cgi?id=158222
263
264         Reviewed by Darin Adler.
265
266         * Plugins/PluginStream.cpp:
267         (WebCore::PluginStream::start):
268
269 2016-06-01  Per Arne Vollan  <pvollan@apple.com>
270
271         [Win] Potential null pointer crash when setting cursor.
272         https://bugs.webkit.org/show_bug.cgi?id=158225
273
274         Reviewed by Alex Christensen.
275
276         Check return value of Cursor::platformCursor().
277
278         * WebCoreSupport/WebChromeClient.cpp:
279         (WebChromeClient::setCursor):
280
281 2016-05-31  Yusuke Suzuki  <utatane.tea@gmail.com>
282
283         Unreviewed, roll out r201481, r201523: 0.3% regression in Octane code-load
284         https://bugs.webkit.org/show_bug.cgi?id=158249
285
286         * Interfaces/IWebPreferencesPrivate.idl:
287
288 2016-05-27  Caitlin Potter  <caitp@igalia.com>
289
290         [JSC] implement async functions proposal
291         https://bugs.webkit.org/show_bug.cgi?id=156147
292
293         Reviewed by Yusuke Suzuki.
294
295         * Interfaces/IWebPreferencesPrivate.idl:
296
297 2016-05-23  Chris Dumez  <cdumez@apple.com>
298
299         Generate bindings code for EventTarget.addEventListener() / removeEventListener()
300         https://bugs.webkit.org/show_bug.cgi?id=157882
301
302         Reviewed by Darin Adler.
303
304         Generate bindings code for EventTarget.addEventListener() / removeEventListener()
305         instead of hardcoding them in the bindings generator.
306
307         * DOMEventsClasses.cpp:
308         (WebEventListener::operator==):
309         * DOMEventsClasses.h:
310
311 2016-05-20  Joseph Pecoraro  <pecoraro@apple.com>
312
313         Remove LegacyProfiler
314         https://bugs.webkit.org/show_bug.cgi?id=153565
315
316         Reviewed by Saam Barati.
317
318         * Interfaces/IWebInspector.idl:
319         * WebCoreStatistics.cpp:
320         * WebInspector.cpp:
321         (WebInspector::isJavaScriptProfilingEnabled): Deleted.
322         (WebInspector::setJavaScriptProfilingEnabled): Deleted.
323         * WebInspector.h:
324         * WebView.cpp:
325
326 2016-05-16  Joseph Pecoraro  <pecoraro@apple.com>
327
328         Unreviewed rollout r200924. Caused js/regress/string-replace-generic.html to fail.
329
330         * Interfaces/IWebInspector.idl:
331         * WebCoreStatistics.cpp:
332         * WebInspector.cpp:
333         (WebInspector::isJavaScriptProfilingEnabled):
334         (WebInspector::setJavaScriptProfilingEnabled):
335         * WebInspector.h:
336         * WebView.cpp:
337
338 2016-05-14  Joseph Pecoraro  <pecoraro@apple.com>
339
340         Remove LegacyProfiler
341         https://bugs.webkit.org/show_bug.cgi?id=153565
342
343         Reviewed by Mark Lam.
344
345         * Interfaces/IWebInspector.idl:
346         * WebView.cpp:
347         * WebInspector.cpp:
348         (WebInspector::isJavaScriptProfilingEnabled): Deleted.
349         (WebInspector::setJavaScriptProfilingEnabled): Deleted.
350         * WebInspector.h:
351
352 2016-05-12  Konstantin Tokarev  <annulen@yandex.ru>
353
354         Use reference instead of pointer in FrameLoaderClient::saveViewStateToItem.
355         https://bugs.webkit.org/show_bug.cgi?id=157624
356
357         Reviewed by Darin Adler.
358
359         * WebCoreSupport/WebFrameLoaderClient.cpp:
360         (WebFrameLoaderClient::saveViewStateToItem):
361         * WebCoreSupport/WebFrameLoaderClient.h:
362
363 2016-05-11  Chris Dumez  <cdumez@apple.com>
364
365         Update Node::appendChild() / replaceChild() / removeChild() / insertBefore() to take references instead of pointers
366         https://bugs.webkit.org/show_bug.cgi?id=157556
367
368         Reviewed by Darin Adler.
369
370         * DOMCoreClasses.cpp:
371         (DOMNode::insertBefore):
372         (DOMNode::removeChild):
373
374 2016-05-11  Joanmarie Diggs  <jdiggs@igalia.com>
375
376         [GTK] accessibility/aria-readonly.html is failing
377         https://bugs.webkit.org/show_bug.cgi?id=98357
378
379         Reviewed by Chris Fleizach.
380
381         Call AccessibilityNode::canSetValueAttribute() to determine if STATE_SYSTEM_READONLY
382         should be added and if editable text should be supported.
383
384         * AccessibleBase.cpp:
385         (AccessibleBase::state):
386         * AccessibleTextImpl.cpp:
387         (AccessibleText::deleteText):
388         (AccessibleText::insertText):
389         (AccessibleText::cutText):
390         (AccessibleText::pasteText):
391         (AccessibleText::replaceText):
392
393 2016-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
394
395         [wincairo] web inspector failed to launch in MiniBrowser
396         https://bugs.webkit.org/show_bug.cgi?id=156184
397         <rdar://problem/25539297>
398
399         Reviewed by Alex Christensen.
400
401         * WebCoreSupport/WebInspectorClient.cpp:
402         (WebInspectorClient::openLocalFrontend): Enable
403         AllowFileAccessFromFileURLs and AllowUniversalAccessFromFileURLs
404         of WebPreferences for Web Inspector.
405
406 2016-05-06  Joseph Pecoraro  <pecoraro@apple.com>
407
408         Rename HitTestRequest DisallowShadowContent to DisallowUserAgentShadowContent
409         https://bugs.webkit.org/show_bug.cgi?id=157447
410
411         Reviewed by Ryosuke Niwa.
412
413         * WebView.cpp:
414         (WebView::gestureNotify):
415
416 2016-05-04  Joanmarie Diggs  <jdiggs@igalia.com>
417
418         AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
419         https://bugs.webkit.org/show_bug.cgi?id=157331
420
421         Reviewed by Chris Fleizach.
422
423         As part of this change, the WebCore DocumentRegionRole AccessibilityRole has
424         been renamed to LandmarkRegionRole. Update MSAARole() to use the new name.
425
426         * AccessibleBase.cpp:
427         (MSAARole):
428
429 2016-04-25  Per Arne Vollan  <peavo@outlook.com>
430
431         [Win][IndexedDB] Fix build errors.
432         https://bugs.webkit.org/show_bug.cgi?id=156713
433
434         Reviewed by Alex Christensen.
435
436         Fix compile and link errors when building with IndexedDB enabled.
437
438         * WebView.cpp:
439         (WebView::notifyPreferencesChanged):
440         * storage: Added.
441         * storage/WebDatabaseProvider.cpp: Added.
442         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
443
444 2016-04-22  Brent Fulgham  <bfulgham@apple.com>
445
446         Unreviewed build fix after 4199841.
447
448         * WebApplicationCache.cpp:
449         (WebApplicationCache::WebApplicationCache): Provide missing preference key definition.
450
451 2016-04-21  Anders Carlsson  <andersca@apple.com>
452
453         Add a missing space, as noticed by Darin.
454
455         * WebApplicationCache.cpp:
456         (applicationCachePath):
457
458 2016-04-21  Anders Carlsson  <andersca@apple.com>
459
460         Stop using ApplicationCacheStorage::singleton() on Windows
461         https://bugs.webkit.org/show_bug.cgi?id=156861
462
463         Reviewed by Darin Adler.
464
465         * WebApplicationCache.cpp:
466         (applicationCachePath):
467         (WebApplicationCache::storage):
468         * WebApplicationCache.h:
469         * WebCache.cpp:
470         (WebCache::empty):
471         * WebView.cpp:
472         (WebView::initWithFrame):
473         (WebKitSetApplicationCachePathIfNecessary): Deleted.
474
475 2016-04-15  Brent Fulgham  <bfulgham@apple.com>
476
477         CSP: Make dynamically-added favicons (via link rel="icon") obey Content-Security-Policy
478         https://bugs.webkit.org/show_bug.cgi?id=153151
479         <rdar://problem/24383176>
480
481         Reviewed by Darin Adler.
482
483         Remove the unused dynamic favicon code and tests.
484
485         * WebCoreSupport/WebFrameLoaderClient.cpp:
486         (WebFrameLoaderClient::dispatchDidChangeIcons): Deleted.
487         * WebCoreSupport/WebFrameLoaderClient.h:
488
489 2016-04-15  Darin Adler  <darin@apple.com>
490
491         Reduce use of Deprecated::ScriptXXX classes
492         https://bugs.webkit.org/show_bug.cgi?id=156632
493
494         Reviewed by Alex Christensen.
495
496         * Plugins/PluginView.cpp:
497         (WebCore::PluginView::performRequest): Use JSValue.
498         * WebFrame.cpp:
499         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): Ditto.
500         * WebView.cpp:
501         (WebView::stringByEvaluatingJavaScriptFromString): Ditto.
502
503 2016-04-11  Darin Adler  <darin@apple.com>
504
505         Remove UsePointersEvenForNonNullableObjectArguments from HTMLSelectElement
506         https://bugs.webkit.org/show_bug.cgi?id=156458
507
508         Reviewed by Chris Dumez.
509
510         * DOMCoreClasses.cpp: Added now-needed include.
511
512 2016-04-11  Gavin Barraclough  <barraclough@apple.com>
513
514         WebKit should adopt journal_mode=wal for all SQLite databases.
515         https://bugs.webkit.org/show_bug.cgi?id=133496
516
517         Reviewed by Darin Adler.
518
519         * WebDatabaseManager.cpp:
520         (WebDatabaseManager::deleteAllDatabases):
521             - renamed deleteAllDatabases -> deleteAllDatabasesImmediately.
522
523 2016-04-08  Joanmarie Diggs  <jdiggs@igalia.com>
524
525         AX: "AXLandmarkApplication" is an inappropriate subrole for ARIA "application" since it's no longer a landmark
526         https://bugs.webkit.org/show_bug.cgi?id=155403
527
528         Reviewed by Chris Fleizach.
529
530         The new subrole is AXWebApplication and the new role description is "web application".
531         As part of the fix, the WebCore AccessibilityRole for ARIA's "application" role was
532         renamed from LandmarkApplicationRole to WebApplicationRole.
533
534         The roles-exposed.html and aria-grouping-roles.html test expectations were also updated.
535
536         * AccessibleBase.cpp: Update the rolename
537         (MSAARole):
538
539 2016-04-07  Brian Burg  <bburg@apple.com>
540
541         CookieJar should support adding synthetic cookies for developer tools
542         https://bugs.webkit.org/show_bug.cgi?id=156091
543         <rdar://problem/25581340>
544
545         Reviewed by Timothy Hatcher.
546
547         * WebCoreSupport/WebPlatformStrategies.h:
548         * WebCoreSupport/WebPlatformStrategies.cpp:
549         Add new method override.
550
551 2016-03-24  Said Abou-Hallawa  <sabouhallawa@apple,com>
552
553         Change NativeImagePtr for CG to be RetainPtr<CGImageRef>
554         https://bugs.webkit.org/show_bug.cgi?id=155412
555
556         Reviewed by Darin Adler.
557
558         * Plugins/PluginView.h:
559         * Plugins/PluginViewWin.cpp:
560         (WebCore::PluginView::snapshot):
561         Replace PassRefPtr with RefPtr.
562
563 2016-03-22  Per Arne Vollan  <peavo@outlook.com>
564
565         [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
566         https://bugs.webkit.org/show_bug.cgi?id=141499
567
568         Reviewed by Brent Fulgham.
569
570         As we have moved on to VS2015, this workaround is no longer needed.
571
572         * WebKitDLL.cpp:
573         (DllMain):
574
575 2016-03-21  Hyungwook Lee  <hyungwook.lee@navercorp.com> 
576
577         [Win] Connect layoutTestController.findString() to support testing 
578         https://bugs.webkit.org/show_bug.cgi?id=50234
579
580         Reviewed by Alex Christensen.
581
582         Implement WebView::findString to support testing efforts.
583
584         * Interfaces/IWebViewPrivate.idl: Add API declaration.
585         * WebView.cpp:
586         * WebView.h:
587
588 2016-03-16  Carlos Garcia Campos  <cgarcia@igalia.com>
589
590         Unreviewed, rolling out r196951 and r197031.
591
592         Revert also WinCairo follow ups after r196803
593
594         Reverted changesets:
595
596         "[WinCairo] Compile fix."
597         https://bugs.webkit.org/show_bug.cgi?id=154545
598         http://trac.webkit.org/changeset/196951
599
600         "[WinCairo] Mark layer as non composited."
601         https://bugs.webkit.org/show_bug.cgi?id=154640
602         http://trac.webkit.org/changeset/197031
603
604 2016-03-16  Carlos Garcia Campos  <cgarcia@igalia.com>
605
606         Unreviewed, rolling out r197693.
607
608         197031
609
610         Reverted changeset:
611
612         "[WinCairo][AcceleratedCompositing] Rendering issues on
613         www.bbc.com."
614         https://bugs.webkit.org/show_bug.cgi?id=154912
615         http://trac.webkit.org/changeset/197693
616
617 2016-03-15  Brent Fulgham  <bfulgham@apple.com>
618
619         [Win] Correct double-release of CFURLConnectionRef
620         https://bugs.webkit.org/show_bug.cgi?id=155515
621         <rdar://problem/25159143>
622
623         Reviewed by Tim Horton.
624
625         Tested by http/tests/download suite.
626
627         * WebDownloadCFNet.cpp: Remove extra CFRelease.
628
629 2016-03-14  Per Arne Vollan  <peavo@outlook.com>
630
631         [WinCairo] Compile fix.
632         https://bugs.webkit.org/show_bug.cgi?id=155463
633
634         Reviewed by Alex Christensen.
635
636         Get the NetworkStorageSession object from the document in the same way as other platforms do.
637
638         * WebCoreSupport/WebFrameNetworkingContext.cpp:
639         (WebFrameNetworkingContext::storageSession):
640         * WebCoreSupport/WebFrameNetworkingContext.h:
641         (WebFrameNetworkingContext::storageSession):
642
643 2016-03-14  Joonghun Park  <jh718.park@samsung.com>
644
645         Purge PassRefPtr from ArrayBuffer, ArchiveResource, Pasteboard, LegacyWebArchive and DataObjectGtk
646         https://bugs.webkit.org/show_bug.cgi?id=150497
647
648         Reviewed by Darin Adler.
649
650         * WebArchive.cpp:
651         (WebArchive::initWithNode):
652
653 2016-03-12  Sam Weinig  <sam@webkit.org>
654
655         WebKit can easily crash below NetworkSession::dataTaskForIdentifier() with NSURLSession enabled
656         <rdar://problem/25129946>
657         https://bugs.webkit.org/show_bug.cgi?id=155401
658
659         Reviewed by Alex Christensen.
660
661         * WebCoreSupport/WebFrameNetworkingContext.cpp:
662         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
663         Pass a SessionID to NetworkStorageSession::createPrivateBrowsingSession().
664
665 2016-03-10  Jer Noble  <jer.noble@apple.com>
666
667         Unreviewed build fix after r197953; correct the settings added in r197953.
668
669         * WebView.cpp:
670         (WebView::notifyPreferencesChanged):
671
672 2016-03-10  Jer Noble  <jer.noble@apple.com>
673
674         Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally
675         https://bugs.webkit.org/show_bug.cgi?id=155141
676
677         Reviewed by Beth Dakin.
678
679         * WebView.cpp:
680         (WebView::notifyPreferencesChanged):
681
682 2016-03-07  Per Arne Vollan  <peavo@outlook.com>
683
684         [WinCairo][AcceleratedCompositing] Rendering issues on www.bbc.com.
685         https://bugs.webkit.org/show_bug.cgi?id=154912
686
687         Reviewed by Michael Catanzaro.
688
689         If we have a scroll layer, we should not include the scroll position in the visible rectangle,
690         since the scroll position is already reflected in the position of the scroll layer.
691
692         * WebCoreSupport/AcceleratedCompositingContext.cpp:
693         (AcceleratedCompositingContext::flushPendingLayerChanges):
694
695 2016-03-06  Gavin Barraclough  <barraclough@apple.com>
696
697         Convert DOMTimer to std::chrono::milliseconds
698         https://bugs.webkit.org/show_bug.cgi?id=155085
699
700         Reviewed by Andreas Kling.
701
702         DOMTimer currently uses a mix of millisecond (was int, now std::chrono) and second (as double)
703         time values. Constant conversion back and forth is a complete mess. Stop that.
704
705         * WebView.cpp:
706         (WebView::setMinimumTimerInterval):
707             - Convert double argument into std::chrono::milliseconds.
708
709 2016-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
710
711         [ES6] Support Reflect.construct
712         https://bugs.webkit.org/show_bug.cgi?id=147330
713
714         Reviewed by Saam Barati.
715
716         * Plugins/PluginPackage.cpp:
717         (WebCore::NPN_Invoke):
718
719 2016-02-24  Per Arne Vollan  <peavo@outlook.com>
720
721         [WinCairo] Mark layer as non composited.
722         https://bugs.webkit.org/show_bug.cgi?id=154640
723
724         Reviewed by Alex Christensen.
725
726         We need to mark the non composited layer as being non composited.
727
728         * WebCoreSupport/AcceleratedCompositingContext.cpp:
729         (AcceleratedCompositingContext::initialize):
730         (AcceleratedCompositingContext::flushPendingLayerChanges):
731
732 2016-02-22  Per Arne Vollan  <peavo@outlook.com>
733
734         [WinCairo] Compile fix.
735         https://bugs.webkit.org/show_bug.cgi?id=154545
736
737         Reviewed by Alex Christensen.
738
739         Add missing parameter to GraphicsLayerTextureMapper::updateBackingStoreIncludingSubLayers().
740
741         * WebCoreSupport/AcceleratedCompositingContext.cpp:
742         (AcceleratedCompositingContext::flushPendingLayerChanges):
743
744 2016-02-21  Darin Adler  <darin@apple.com>
745
746         Refactor LazyEventListener creation to separate Element and Document cases
747         https://bugs.webkit.org/show_bug.cgi?id=154231
748
749         Reviewed by Andreas Kling.
750
751         * WebView.h: Forward declare KeyboardEvent.
752
753 2016-02-16  Andreas Kling  <akling@apple.com>
754
755         Drop StyleResolver and SelectorQueryCache when entering PageCache.
756         <https://webkit.org/b/154238>
757
758         Reviewed by Antti Koivisto.
759
760         * WebCoreSupport/WebVisitedLinkStore.cpp:
761         (WebVisitedLinkStore::removeAllVisitedLinks): Deleted.
762         (WebVisitedLinkStore::addVisitedLinkHash): Deleted.
763
764 2016-02-14  Chris Dumez  <cdumez@apple.com>
765
766         Unreviewed Window build fix.
767
768         * WebCoreStatistics.cpp:
769         * WebJavaScriptCollector.cpp:
770
771 2016-02-12  Jiewen Tan  <jiewen_tan@apple.com>
772
773         WebKit should expose the DOM 4 Event.isTrusted property
774         https://bugs.webkit.org/show_bug.cgi?id=76121
775         <rdar://problem/22558494>
776
777         Reviewed by Darin Adler.
778
779         * DOMCoreClasses.cpp:
780         (DOMNode::dispatchEvent):
781         (DOMWindow::dispatchEvent):
782
783 2016-02-11  Antti Koivisto  <antti@apple.com>
784
785         Try to fix windows build.
786
787         * DOMCoreClasses.cpp:
788         (DOMElement::style):
789         (DOMElement::offsetLeft):
790
791 2016-02-06  Darin Adler  <darin@apple.com>
792
793         Finish auditing call sites of upper() and lower(), eliminate many, and rename the functions
794         https://bugs.webkit.org/show_bug.cgi?id=153905
795
796         Reviewed by Sam Weinig.
797
798         * Plugins/PluginDatabase.cpp:
799         (WebCore::PluginDatabase::pluginForMIMEType): Use ASCII case-insensitive map rather
800         than lowercasing the MIME type.
801         (WebCore::PluginDatabase::setPreferredPluginForMIMEType): Ditto.
802
803         * Plugins/PluginDatabase.h: Make m_preferredPlugins use an ASCII case-insensitive hash.
804
805         * Plugins/PluginPackage.h: Use ASCII case-insensitive hash for maps keyed by MIME type.
806
807         * Plugins/PluginPackageWin.cpp:
808         (WebCore::PluginPackage::fetchInfo): Use convertToASCIILowercase to lowercase a MIME type.
809
810 2016-02-04  Joseph Pecoraro  <pecoraro@apple.com>
811
812         Web Inspector: InspectorTimelineAgent doesn't need to recompile functions because it now uses the sampling profiler
813         https://bugs.webkit.org/show_bug.cgi?id=153500
814         <rdar://problem/24352458>
815
816         Reviewed by Timothy Hatcher.
817
818         * WebInspector.cpp:
819         (WebInspector::isJavaScriptProfilingEnabled):
820         (WebInspector::setJavaScriptProfilingEnabled):
821         Switch to the new API names.
822
823 2016-01-31  Darin Adler  <darin@apple.com>
824
825         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
826         https://bugs.webkit.org/show_bug.cgi?id=153639
827
828         Reviewed by Filip Pizlo.
829
830         * WebCoreStatistics.cpp:
831         (WebCoreStatistics::memoryStatistics): Use ASCIICaseInsensitiveHash for field names.
832         These names are all ASCII.
833
834         * WebURLResponse.cpp:
835         (WebURLResponse::allHeaderFields): Use ASCIICaseInsensitiveHash for HTTP header
836         field names. These names are all ASCII.
837
838 2016-01-30  Commit Queue  <commit-queue@webkit.org>
839
840         Unreviewed, rolling out r195911.
841         https://bugs.webkit.org/show_bug.cgi?id=153723
842
843         Caused frequent assertion failures on bots (Requested by ap on
844         #webkit).
845
846         Reverted changeset:
847
848         "Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
849         https://bugs.webkit.org/show_bug.cgi?id=153639
850         http://trac.webkit.org/changeset/195911
851
852 2016-01-30  Commit Queue  <commit-queue@webkit.org>
853
854         Unreviewed, rolling out r195799 and r195828.
855         https://bugs.webkit.org/show_bug.cgi?id=153722
856
857         Caused assertion failures, severely affecting EWS (Requested
858         by ap on #webkit).
859
860         Reverted changesets:
861
862         "Web Inspector: InspectorTimelineAgent doesn't need to
863         recompile functions because it now uses the sampling profiler"
864         https://bugs.webkit.org/show_bug.cgi?id=153500
865         http://trac.webkit.org/changeset/195799
866
867         "Attempt to fix the Windows build after r195799"
868         http://trac.webkit.org/changeset/195828
869
870 2016-01-30  Darin Adler  <darin@apple.com>
871
872         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
873         https://bugs.webkit.org/show_bug.cgi?id=153639
874
875         Reviewed by Filip Pizlo.
876
877         * WebCoreStatistics.cpp:
878         (WebCoreStatistics::memoryStatistics): Use ASCIICaseInsensitiveHash for field names.
879         These names are all ASCII.
880
881         * WebURLResponse.cpp:
882         (WebURLResponse::allHeaderFields): Use ASCIICaseInsensitiveHash for HTTP header
883         field names. These names are all ASCII.
884
885 2016-01-29  Ryan Haddad  <ryanhaddad@apple.com>
886
887         Attempt to fix the Windows build after r195799
888
889         Unreviewed build fix.
890
891         * WebInspector.cpp:
892         (WebInspector::isJavaScriptProfilingEnabled):
893         (WebInspector::setJavaScriptProfilingEnabled):
894
895 2016-01-28  Darin Adler  <darin@apple.com>
896
897         Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
898         https://bugs.webkit.org/show_bug.cgi?id=153411
899
900         Reviewed by Ryosuke Niwa.
901
902         * Plugins/PluginDatabase.cpp:
903         (WebCore::PluginDatabase::MIMETypeForExtension): Use equalIgnoringASCIICase to compare
904         file extensions.
905         * Plugins/PluginDatabaseWin.cpp:
906         (WebCore::PluginDatabase::getPluginPathsInDirectories): Use equalLettersIgnoringASCIICase
907         to compare filenames.
908         * Plugins/PluginPackageWin.cpp:
909         (WebCore::PluginPackage::isPluginBlacklisted): Use equalLettersIgnoringASCIICase to
910         compare DLL filenames.
911         * Plugins/PluginStream.cpp:
912         (WebCore::PluginStream::destroyStream): Use equalLettersIgnoringASCIICase to check HTTP method.
913         * Plugins/PluginView.cpp:
914         (WebCore::PluginView::setParameters): Use equalLettersIgnoringASCIICase to check
915         plug-in parameter name.
916         * WebView.cpp:
917         (WebView::canHandleRequest): Use URL::protocolIs instead of equalIgnoringCase.
918
919 2016-01-22  Ryosuke Niwa  <rniwa@webkit.org>
920
921         document.createElement should be able to create a custom element
922         https://bugs.webkit.org/show_bug.cgi?id=153173
923
924         Reviewed by Darin Adler.
925
926         Use createElementForBindings here since this is a C++ binding for Windows.
927
928         * DOMCoreClasses.cpp:
929         (DOMDocument::createElement):
930
931 2016-01-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
932
933         Reduce PassRefPtr uses in dom - 4
934         https://bugs.webkit.org/show_bug.cgi?id=153270
935
936         Reviewed by Darin Adler.
937
938         As a step to remove PassRefPtr uses, this patch reduces the uses in WebCore/dom.
939
940         * Plugins/PluginView.cpp:
941         (WebCore::PluginView::focusPluginElement):
942
943 2016-01-17  Ada Chan  <adachan@apple.com>
944
945         Add a mode parameter to MediaControllerInterface::supportsFullscreen() and ChromeClient::supportsVideoFullscreen().
946         https://bugs.webkit.org/show_bug.cgi?id=153220
947
948         Reviewed by Eric Carlson.
949
950         * WebCoreSupport/WebChromeClient.cpp:
951         (WebChromeClient::supportsVideoFullscreen):
952         * WebCoreSupport/WebChromeClient.h:
953
954 2016-01-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
955
956         Remove PassRefPtr from ResourceRequest and FormData
957         https://bugs.webkit.org/show_bug.cgi?id=153229
958
959         Reviewed by Chris Dumez.
960
961         * WebMutableURLRequest.cpp:
962         (WebMutableURLRequest::setHTTPBody):
963
964 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
965
966         Remove GraphicsContext::drawConvexPolygon() and GraphicsContext::clipConvexPolygon()
967         https://bugs.webkit.org/show_bug.cgi?id=153174
968
969         Reviewed by Zalan Bujtas.
970
971         GraphicsContext::drawConvexPolygon() and GraphicsContext::clipConvexPolygon() were
972         poorly named (non-convex polygons are allowed), and just syntactic sugar over
973         clipPath() and drawPath().
974         
975         Remove them, but add a convenience function to create a Path from a Vector of 
976         points. For CG, we can use the more efficient CGPathAddLines().
977
978         * FullscreenVideoController.cpp:
979         (HUDSlider::draw):
980
981 2016-01-05  Per Arne Vollan  <peavo@outlook.com>
982
983         [WinCairo] Download should use header values from provided request object.
984         https://bugs.webkit.org/show_bug.cgi?id=152694
985
986         Reviewed by Alex Christensen.
987
988         Copy header values from request object parameter.
989
990         * WebDownloadCurl.cpp:
991         (WebDownload::initWithRequest):
992
993 2015-12-31  Andy Estes  <aestes@apple.com>
994
995         Replace WTF::move with WTFMove
996         https://bugs.webkit.org/show_bug.cgi?id=152601
997
998         Reviewed by Brady Eidson.
999
1000         * Plugins/PluginStream.cpp:
1001         (WebCore::PluginStream::willSendRequest):
1002         * Plugins/PluginView.cpp:
1003         (WebCore::PluginView::requestTimerFired):
1004         (WebCore::PluginView::scheduleRequest):
1005         (WebCore::PluginView::handlePost):
1006         * WebCoreSupport/WebFrameLoaderClient.cpp:
1007         (WebFrameLoaderClient::createDocumentLoader):
1008         * WebCoreSupport/WebInspectorClient.cpp:
1009         (WebInspectorFrontendClient::WebInspectorFrontendClient):
1010         * WebHistory.cpp:
1011         (createUserInfoFromArray):
1012         * WebHistoryItem.cpp:
1013         (WebHistoryItem::initFromDictionaryRepresentation):
1014         * WebView.cpp:
1015         (WebView::addToDirtyRegion):
1016         (WebView::scrollBackingStore):
1017         (WebView::loadBackForwardListFromOtherView):
1018         (WebView::addUserScriptToGroup):
1019         (WebView::addUserStyleSheetToGroup):
1020
1021 2015-12-29  Simon Fraser  <simon.fraser@apple.com>
1022
1023         Fix Windows build.
1024
1025         * WebView.cpp:
1026         (WebView::scrollOffset):
1027
1028 2015-12-25  David Kilzer  <ddkilzer@apple.com>
1029
1030         ResourceError should store failingURL as URL instead of String to avoid reparsing and to address FIXME comments in ResourceErrorCF.cpp and ResourceErrorMac.mm
1031         <http://webkit.org/b/146391>
1032
1033         Reviewed by Antti Koivisto.
1034
1035         * WebCoreSupport/WebFrameLoaderClient.cpp:
1036         (WebFrameLoaderClient::cancelledError):
1037         (WebFrameLoaderClient::blockedError):
1038         (WebFrameLoaderClient::cannotShowURLError):
1039         (WebFrameLoaderClient::interruptedForPolicyChangeError):
1040         (WebFrameLoaderClient::cannotShowMIMETypeError):
1041         (WebFrameLoaderClient::fileDoesNotExistError):
1042         (WebFrameLoaderClient::pluginWillHandleLoadError):
1043         (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
1044         (WebFrameLoaderClient::createJavaAppletWidget):
1045         * WebDownloadCFNet.cpp:
1046         (WebDownload::cancelAuthenticationChallenge):
1047         * WebError.cpp:
1048         (WebError::init):
1049         - Update for type change of 'failingURL' argument to
1050           ResourceError().
1051
1052 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1053
1054         Web Inspector: add support for running protocol-test.js tests on Windows
1055         https://bugs.webkit.org/show_bug.cgi?id=148037
1056         <rdar://problem/22292237>
1057
1058         Reviewed by Simon Fraser.
1059
1060         Provide API for WebKit.dll clients to request its CFBundleRef.
1061         
1062         * WebKitCOMAPI.cpp:
1063         (webKitBundle): Added.
1064         * WebKitCOMAPI.h:
1065
1066 2015-12-20  Dan Bernstein  <mitz@apple.com>
1067
1068         Remove unused setToolbarHeight
1069         https://bugs.webkit.org/show_bug.cgi?id=152466
1070
1071         Reviewed by Darin Adler.
1072
1073         * WebCoreSupport/WebInspectorClient.cpp:
1074         (WebInspectorFrontendClient::setToolbarHeight): Deleted.
1075         * WebCoreSupport/WebInspectorClient.h:
1076
1077 2015-12-15  Zan Dobersek  <zdobersek@igalia.com>
1078
1079         [TexMap] Operate with a reference to the TextureMapper wherever possible
1080         https://bugs.webkit.org/show_bug.cgi?id=152118
1081
1082         Reviewed by Martin Robinson.
1083
1084         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1085         (AcceleratedCompositingContext::compositeLayersToContext): TextureMapper object
1086         is now operated with through a reference.
1087
1088 2015-12-01  Darin Adler  <darin@apple.com>
1089
1090         Fix anomaly where isMouseEvent returns false for wheel events
1091         https://bugs.webkit.org/show_bug.cgi?id=151685
1092
1093         Reviewed by Alexey Proskuryakov.
1094
1095         * DOMEventsClasses.cpp:
1096         (DOMEvent::createInstance): Use eventInterface instead of isMouseEvent to create the appropriate
1097         wrapper class.
1098
1099 2015-11-24  Per Arne Vollan  <peavo@outlook.com>
1100
1101         [Win] Implement methods to get and set inner html.
1102         https://bugs.webkit.org/show_bug.cgi?id=151569
1103
1104         Reviewed by Alex Christensen.
1105
1106         * DOMHTMLClasses.cpp:
1107         (DOMHTMLElement::innerHTML):
1108         (DOMHTMLElement::setInnerHTML):
1109         (DOMHTMLElement::innerText):
1110
1111 == Rolled over to ChangeLog-2015-11-21 ==