[Qt] Add more tests to cover the behavior of loadFinished() signal
[WebKit-https.git] / Source / WebKit / qt / ChangeLog
1 2011-07-25  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2
3         [Qt] Add more tests to cover the behavior of loadFinished() signal
4         https://bugs.webkit.org/show_bug.cgi?id=63490
5
6         Reviewed by Benjamin Poulain.
7
8         * tests/qwebframe/tst_qwebframe.cpp:
9         (FakeReply::FakeReply):
10         (FakeNetworkManager::createRequest): Add a fake reply that gives 404 error code.
11
12         (tst_QWebFrame::loadFinishedAfterNotFoundError): Verify that we get loadFinished(false)
13         after a 404 error without contents.
14
15         * tests/qwebpage/tst_qwebpage.cpp:
16         (tst_QWebPage::errorPageExtensionLoadFinished): Verify if the argument of loadFinished()
17         is true when we use error page extension to produce our own error pages.
18
19 2011-07-19  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
20
21         [Qt] Improve documentation of QWebView::setPage()
22         https://bugs.webkit.org/show_bug.cgi?id=64827
23
24         Reviewed by Noam Rosenthal.
25
26         * Api/qwebview.cpp: Use the word 'page' to refer to a QWebPage instead of 'document'.
27
28 2011-07-19  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
29
30         [Qt] Fix leak of QWebPage in errorPageExtension tests
31         https://bugs.webkit.org/show_bug.cgi?id=64814
32
33         Reviewed by Noam Rosenthal.
34
35         QWebView::setPage() doesn't take ownership, so the ErrorPages were leaking. So now
36         allocate them on the stack. This shouldn't change any behavior.
37
38         * tests/qwebpage/tst_qwebpage.cpp:
39         (tst_QWebPage::errorPageExtension):
40         (tst_QWebPage::errorPageExtensionInIFrames):
41         (tst_QWebPage::errorPageExtensionInFrameset):
42
43 2011-07-18  Hui Huang  <hui.2.huang@nokia.com>
44
45         [Qt] Compiling error in Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp with Qt 4.7 or older
46         https://bugs.webkit.org/show_bug.cgi?id=64560
47
48         Reviewed by Noam Rosenthal.
49
50         * tests/qwebelement/tst_qwebelement.cpp:
51         (tst_QWebElement::render):
52
53 2011-07-15  Dan Bernstein  <mitz@apple.com>
54
55         REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
56         https://bugs.webkit.org/show_bug.cgi?id=64615
57
58         Reviewed by Anders Carlsson.
59
60         * WebCoreSupport/ChromeClientQt.h:
61         (WebCore::ChromeClientQt::setCursorHiddenUntilMouseMoves): Added this stub.
62
63 2011-07-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
64
65         REGRESSION(91064): Upstream QtWebKit/N9 changes related tovisibleContentRect
66
67         Reviewed by Antonio Gomes.
68
69         Only set setFixedVisibleContentRect when in resizesToContents mode.
70
71         * WebCoreSupport/FrameLoaderClientQt.cpp:
72         (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
73
74 2011-07-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
75
76         Upstream QtWebKit/N9 changes related to visibleContentRect
77         https://bugs.webkit.org/show_bug.cgi?id=64589
78
79         Reviewed by Simon Hausmann.
80
81         * Api/qwebpage.cpp:
82         (QWebPage::setActualVisibleContentRect):
83         Change to use setFixedVisibleContentRect.
84         * WebCoreSupport/FrameLoaderClientQt.cpp:
85         (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
86         Only set fixedVisibleContentRect for the mainframe.
87         * symbian/eabi/QtWebKitu.def:
88
89 2011-07-13  Joseph Pecoraro  <joepeck@webkit.org>
90
91         Improve names of some ApplicationCacheStorage accessor methods
92         https://bugs.webkit.org/show_bug.cgi?id=64433
93
94         Reviewed by Alexey Proskuryakov.
95
96         * WebCoreSupport/ChromeClientQt.cpp:
97         (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
98         Renamed method.
99
100 2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
101
102         ApplicationCache update should not immediately fail when reaching per-origin quota
103         https://bugs.webkit.org/show_bug.cgi?id=64177
104
105         Reviewed by Alexey Proskuryakov.
106
107         * Api/qwebpage.cpp:
108         * Api/qwebpage.h:
109         * WebCoreSupport/ChromeClientQt.cpp:
110         (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
111         * WebCoreSupport/ChromeClientQt.h:
112         Pass the spaceNeeded value through to the applicationCacheQuotaExceeded signal.
113
114 2011-07-11  Ryosuke Niwa  <rniwa@webkit.org>
115
116         Move selection related code from RenderTextControl to HTMLTextFormControlElement
117         https://bugs.webkit.org/show_bug.cgi?id=64133
118
119         Reviewed by Dimitri Glazkov.
120
121         Replaced calls to WebCore::setSelectionRange by calls to HTMLTextFormControlElement::setSelectionRange.
122
123         * Api/qwebpage.cpp:
124         (QWebPagePrivate::inputMethodEvent):
125
126 2011-07-08  Adam Barth  <abarth@webkit.org>
127
128         Unreviewed, rolling out r90662.
129         http://trac.webkit.org/changeset/90662
130         https://bugs.webkit.org/show_bug.cgi?id=64210
131
132         Introduced regressions in Chromium browser tests (Requested by
133         rniwa on #webkit).
134
135         * Api/qwebpage.cpp:
136         (QWebPagePrivate::inputMethodEvent):
137
138 2011-07-08  Ryosuke Niwa  <rniwa@webkit.org>
139
140         Move selection related code from RenderTextControl to HTMLTextFormControlElement
141         https://bugs.webkit.org/show_bug.cgi?id=64133
142
143         Reviewed by Dimitri Glazkov.
144
145         Replaced calls to WebCore::setSelectionRange by calls to HTMLTextFormControlElement::setSelectionRange.
146
147         * Api/qwebpage.cpp:
148         (QWebPagePrivate::inputMethodEvent):
149
150 2011-07-05  Rafael Brandao  <rafael.lobo@openbossa.org>
151
152         [Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
153         https://bugs.webkit.org/show_bug.cgi?id=63235
154
155         Modified baseUrl to be a local file in order to get a security origin
156         that is allowed to request local resources. Removed QSignalSpy from it
157         as loadFinished always happens, and the original test was split into two.
158
159         Reviewed by Benjamin Poulain.
160
161         * tests/qwebframe/tst_qwebframe.cpp:
162         (tst_QWebFrame::setHtmlWithImageResource):
163         (tst_QWebFrame::setHtmlWithStylesheetResource):
164         (tst_QWebFrame::setHtmlWithBaseURL):
165
166 2011-04-02  Robert Hogan  <robert@webkit.org>
167
168         Reviewed by Benjamin Poulain.
169
170         [Qt] Support third-party cookie policy for Qt clients
171
172         This adds new API to QWebSettings that allows clients to
173         select one of three third-party cookie blocking policies:
174
175           AlwaysAllowThirdPartyCookies
176           AlwaysBlockThirdPartyCookies
177           AllowThirdPartyWithExistingCookies
178
179         The first two are self-explanatory, the third mimics Safari's
180         default behaviour of permitting third-party cookies when the user
181         already has cookies from the third-party site. This was
182         introduced to allow third-party cookie blocking to play well with
183         facebook sharing etc. AlwaysAllowThirdPartyCookies is the default.
184
185         There is scope for adding an 'exceptions' list API and clients would
186         struggle to implement it themselves given the paucity of information
187         available from setCookiesForUrl().
188
189         See also: http://gitorious.org/qt/qt/merge_requests/1205
190                    (commit 154402f56dcf8303a6ce601a52215226af8d31ba)
191                   http://bugreports.qt.nokia.com/browse/QTBUG-13601
192
193         https://bugs.webkit.org/show_bug.cgi?id=45455
194
195         * Api/qwebsettings.cpp:
196         (QWebSettings::QWebSettings):
197         (QWebSettings::setThirdPartyCookiePolicy):
198         (QWebSettings::thirdPartyCookiePolicy):
199         * Api/qwebsettings.h:
200
201 2011-07-01  Jade Han  <jade.han@nokia.com>
202
203         [Qt][Symbian] Update .def file for Symbian to build Tools
204         https://bugs.webkit.org/show_bug.cgi?id=61200
205
206         Reviewed by Laszlo Gombos.
207
208         Add newly introduced symbols to fix building the Tools directory for Symbian.
209
210         * symbian/eabi/QtWebKitu.def:
211
212 2011-07-01  Jade Han  <jade.han@nokia.com>
213
214         Reviewed by Laszlo Gombos.
215
216         [Qt][Symbian] Update .def file for Symbian
217         https://bugs.webkit.org/show_bug.cgi?id=61200
218
219         Add newly introduced symbols to fix the Symbian build.
220
221         * symbian/eabi/QtWebKitu.def:
222
223 2011-06-30  Rafael Brandao  <rafael.lobo@openbossa.org>
224
225         Reviewed by Benjamin Poulain.
226
227         [Qt] Fix tst_QWebFrame::renderGeometry() API test
228         https://bugs.webkit.org/show_bug.cgi?id=63236
229         
230         This test required a security origin with granted permission to request local resources.
231         By default, only local files can load local resources. So modified baseUrl to be a local file.
232
233         * tests/qwebframe/tst_qwebframe.cpp:
234         (tst_QWebFrame::renderGeometry):
235
236 2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>
237
238         Reviewed by Antonio Gomes.
239
240         [Qt] DRT: Provide LayoutTestController::setDefersLoading and ::goBack support
241         https://bugs.webkit.org/show_bug.cgi?id=63489
242
243         Unskipped:
244             loader/navigation-while-deferring-loads.html
245
246         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
247         (DumpRenderTreeSupportQt::setDefersLoading):
248         (DumpRenderTreeSupportQt::goBack):
249         * WebCoreSupport/DumpRenderTreeSupportQt.h:
250
251 2011-06-30  Fabrizio Machado  <fabrizio.machado@nokia.com>
252
253         Reviewed by Benjamin Poulain.
254         
255         [Qt] QML Webview causes performance drops
256         https://bugs.webkit.org/show_bug.cgi?id=57554
257
258         Remove tiledBackingStoreEnabled from QML WebView.
259         
260         * declarative/qdeclarativewebview.cpp:
261         (QDeclarativeWebView::setPage):
262
263 2011-06-30  Kentaro Hara  <haraken@google.com>
264
265         Reviewed by Kent Tamura.
266
267         Change the label of an HTML5 file chooser button to "Choose Files"
268         https://bugs.webkit.org/show_bug.cgi?id=49245
269
270         We should notify capability of multiple files to users.
271
272         Test: fast/forms/input-file-label.html
273
274         * WebCoreSupport/WebPlatformStrategies.cpp:
275         (WebPlatformStrategies::fileButtonChooseFileLabel): Updated the description for "Choose File".
276         (WebPlatformStrategies::fileButtonChooseMultipleFilesLabel):  Returns a "Choose Files" label.
277         * WebCoreSupport/WebPlatformStrategies.h:
278
279 2011-06-29  Alexis Menard  <alexis.menard@openbossa.org>
280
281         Reviewed by Benjamin Poulain.
282
283         [Qt] Add Qt dependencies in QtWebKit's main pro file.
284         https://bugs.webkit.org/show_bug.cgi?id=63639
285
286         syncqt, the script which generates the headers inside Qt parses
287         the main pro file of QtWebKit to check the Qt dependencies. It used
288         to be WebCore.pro but after the build reorganization QtWebKit.pro is
289         the new main pro file so we need to add the network dependency just like
290         we did in WebCore.pro.
291
292         * QtWebKit.pro:
293
294 2011-06-28  Ilya Sherman  <isherman@chromium.org>
295
296         Reviewed by Adam Barth.
297
298         form.autocomplete="off" does not work
299         https://bugs.webkit.org/show_bug.cgi?id=35823
300
301         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
302         (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId): Update callsite.
303
304 2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>
305
306         Reviewed by Kenneth Rohde Christiansen.
307
308         [Qt] DRT support for setInteractiveFormValidationEnabled
309         https://bugs.webkit.org/show_bug.cgi?id=63496
310
311         Unskipped:
312             fast/forms/interactive-validation-prevented.html
313             fast/forms/interactive-validation-attach-assertion.html
314             fast/forms/interactive-validation-assertion-by-validate-twice.html
315             fast/forms/interactive-validation-select-crash.html
316             fast/forms/interactive-validation-crash-by-style-override.html
317
318         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
319         (DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled):
320         * WebCoreSupport/DumpRenderTreeSupportQt.h:
321
322 2011-06-28  Alexis Menard  <alexis.menard@openbossa.org>
323
324         Reviewed by Andreas Kling.
325
326         [Qt] Use <QtX/x.h> style of headers for Qt tests which rely on it.
327         https://bugs.webkit.org/show_bug.cgi?id=63562
328
329         Some Qt auto-tests rely on <QtX/x.h> types of includes.
330
331         * Api/qwebkitplatformplugin.h:
332         * symbian/platformplugin/qwebkitplatformplugin.h:
333
334 2011-06-28  Alexis Menard  <alexis.menard@openbossa.org>
335
336         Reviewed by Andreas Kling.
337
338         [Qt] Use QtQuick imports in Api tests rather than old deprecated Qt 4.x imports.
339         https://bugs.webkit.org/show_bug.cgi?id=63533
340
341         We need to use the new QtQuick 1.x imports rather than the old deprecated
342         version.
343
344         * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml:
345         * tests/qdeclarativewebview/resources/webviewtest.qml:
346         * tests/qdeclarativewebview/resources/webviewtestdefault.qml:
347
348 2011-06-27  Alexis Menard  <alexis.menard@openbossa.org>
349
350         Reviewed by Darin Adler.
351
352         Use specific headers includes rather than full system headers.
353         https://bugs.webkit.org/show_bug.cgi?id=63475
354
355         Use only needed headers rather than system headers.
356
357         * WebCoreSupport/QTKitFullScreenVideoHandler.mm:
358
359 2011-06-27  Alexis Menard  <alexis.menard@openbossa.org>
360
361         Reviewed by Kenneth Rohde Christiansen.
362
363         [Qt] Remove Phonon MediaPlayer from the tree.
364         https://bugs.webkit.org/show_bug.cgi?id=63448
365
366         Remove Phonon related stuff.
367
368         * docs/qtwebkit.qdocconf:
369         * qt_webkit_version.pri:
370
371 2011-06-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
372
373         Reviewed by Andreas Kling.
374
375         [Qt] tst_QWebFrame::overloadedSlots() fails
376         https://bugs.webkit.org/show_bug.cgi?id=37319
377
378         * tests/qwebframe/tst_qwebframe.cpp:
379         (tst_QWebFrame::overloadedSlots): Remove expected failure and
380         fix the comment.
381
382 2011-06-20  Robert Hogan  <robert@webkit.org>
383
384         Reviewed by Antonio Gomes.
385
386         [Qt] Duplicate entry in context menu
387         https://bugs.webkit.org/show_bug.cgi?id=62139
388
389         contextMenuController()->populate() is called from
390         ContextMenuController::handleContextMenuEvent() so
391         QWebPage::updatePositionDependentActions() does not need
392         to call it independently.
393
394         Related changesets: 
395          http://trac.webkit.org/changeset/73535
396          http://trac.webkit.org/changeset/32389
397
398         * Api/qwebpage.cpp:
399         (QWebPage::updatePositionDependentActions):
400         * tests/qwebpage/tst_qwebpage.cpp:
401         (tst_QWebPage::contextMenuCopy):
402         (tst_QWebPage::contextMenuPopulatedOnce):
403
404 2011-06-24  Dominic Cooney  <dominicc@chromium.org>
405
406         Reviewed by Dimitri Glazkov.
407
408         Convert shadow-DOM related tests to use window.internals
409         https://bugs.webkit.org/show_bug.cgi?id=61671
410
411         Remove shadow-DOM related methods from Qt DRT API. These are not
412         required any more.
413
414         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
415         * WebCoreSupport/DumpRenderTreeSupportQt.h:
416
417 2011-06-23  Joe Wild  <joseph.wild@nokia.com>
418
419         Reviewed by Laszlo Gombos.
420
421         [Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
422         https://bugs.webkit.org/show_bug.cgi?id=61200
423
424         Revert r87060 as it broke compatibility with QtWebKit 2.1 release
425         and add some newly introduce symbols.
426
427         * symbian/eabi/QtWebKitu.def:
428
429 2011-06-23  Alexis Menard  <alexis.menard@openbossa.org>
430
431         Reviewed by Eric Carlson.
432
433         [Qt] Implement fullscreen support on Mac with the QuickTime backend.
434         https://bugs.webkit.org/show_bug.cgi?id=61728
435
436         Implement fullscreen support for Qt when using the QuickTime backend.
437         We mostly use what is already done for the Mac port.
438
439         * QtWebKit.pro:
440         * WebCoreSupport/ChromeClientQt.cpp:
441         (WebCore::ChromeClientQt::ChromeClientQt):
442         (WebCore::ChromeClientQt::~ChromeClientQt):
443         * WebCoreSupport/ChromeClientQt.h:
444         * WebCoreSupport/FullScreenVideoQt.cpp:
445         (WebCore::FullScreenVideoQt::FullScreenVideoQt):
446         (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
447         (WebCore::FullScreenVideoQt::enterFullScreenForNode):
448         (WebCore::FullScreenVideoQt::exitFullScreenForNode):
449         (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
450         (WebCore::FullScreenVideoQt::isValid):
451         * WebCoreSupport/FullScreenVideoQt.h:
452         * WebCoreSupport/QTKitFullScreenVideoHandler.h: Added.
453         * WebCoreSupport/QTKitFullScreenVideoHandler.mm: Added.
454         (QTKitFullScreenVideoHandler::QTKitFullScreenVideoHandler):
455         (QTKitFullScreenVideoHandler::~QTKitFullScreenVideoHandler):
456         (QTKitFullScreenVideoHandler::enterFullScreen):
457         (QTKitFullScreenVideoHandler::exitFullScreen):
458         * WebCoreSupport/WebSystemInterface.mm:
459         (InitWebCoreSystemInterface):
460
461 2011-06-23  Yael Aharon  <yael.aharon@nokia.com>
462
463         Reviewed by Andreas Kling.
464
465         [Qt] [WK2] Add drag and drop support
466         https://bugs.webkit.org/show_bug.cgi?id=62838
467
468         Call dragEnded from the DragClient to make WebKit1 and WebKit2 consistent.
469
470         * WebCoreSupport/DragClientQt.cpp:
471         (WebCore::DragClientQt::startDrag):
472
473 2011-06-23  Joe Wild  <joseph.wild@nokia.com>
474
475         Reviewed by Laszlo Gombos.
476
477         [Qt] Export files under Symbian Qt WebKit build
478         https://bugs.webkit.org/show_bug.cgi?id=61207
479
480         Export files for the Symbian platform as this is needed by the
481         production build system.
482
483         Janne Koskinen provided the suggestion to use target_predeps,
484         which is an improvement over the originally suggested patch.
485
486         * QtWebKit.pro:
487
488 2011-06-23  Csaba Osztrogonác  <ossy@webkit.org>
489
490         Rubber-stamped by Andreas Kling.
491
492         [Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
493         https://bugs.webkit.org/show_bug.cgi?id=63235
494
495         [Qt] Fix tst_QWebFrame::renderGeometry() API test
496         https://bugs.webkit.org/show_bug.cgi?id=63236
497
498         [Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
499         https://bugs.webkit.org/show_bug.cgi?id=63237
500
501         * tests/qwebframe/tst_qwebframe.cpp: Mark failing test cases as expected fails until real fix.
502         (tst_QWebFrame::setHtmlWithResource):
503         (tst_QWebFrame::renderGeometry):
504
505 2011-06-23  Csaba Osztrogonác  <ossy@webkit.org>
506
507         Rubber-stamped by Andreas Kling.
508
509         [Qt] Fix tst_QWebPage::showModalDialog() API test
510         https://bugs.webkit.org/show_bug.cgi?id=63244
511
512         [Qt] Fix tst_QWebPage::testStopScheduledPageRefresh() API test
513         https://bugs.webkit.org/show_bug.cgi?id=63245
514
515         * tests/qwebpage/tst_qwebpage.cpp: Mark failing test cases as expected fails.
516         (tst_QWebPage::showModalDialog):
517         (tst_QWebPage::testStopScheduledPageRefresh):
518
519 2011-06-22  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
520
521         Reviewed by Holger Freyther.
522
523         [Qt] Fix Qt namespace on QDeclarativeWebView autotest
524         https://bugs.webkit.org/show_bug.cgi?id=63147
525
526         Applications (such as the test runner) are not supposed to be wrapped
527         by {QT_BEGIN,QT_END}_NAMESPACE macros, otherwise building Qt (or
528         QtWebKit) with a specific namespace won't work (will result in main
529         being undefined).
530
531         This was the only test wrapped by these macros, all others are fine.
532
533         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: remove
534         namespace macros.
535
536 2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
537
538         Reviewed by Kent Tamura.
539
540         FileChooser should be only created when we need to choose files.
541         https://bugs.webkit.org/show_bug.cgi?id=63039
542
543         * WebCoreSupport/ChromeClientQt.cpp:
544         (WebCore::ChromeClientQt::runOpenPanel): Changed to use settings.
545
546 2011-06-21  Yael Aharon  <yael.aharon@nokia.com>
547
548         Reviewed by Andreas Kling.
549
550         [Qt] Regression(60942) wrong default action for drag-and-drop.
551         https://bugs.webkit.org/show_bug.cgi?id=63004
552
553         Added special handling for the case that dragOperation is not initialized.
554         Save the last dropOperation and pass it to the dropEvent, so that it can 
555         be accepted by QDrag.
556         Call event->accepted() and not event->acceptProposedAction(), because the
557         later ignores the dropAction specified in JavaScript.
558
559         Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401
560         and did not see any issue.
561         Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html
562         and they all pass.
563
564         * Api/qwebpage.cpp:
565         (dropActionToDragOp):
566         (QWebPagePrivate::dragMoveEvent):
567         (QWebPagePrivate::dropEvent):
568
569 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
570
571         Reviewed by Yury Semikhatsky.
572
573         Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
574         https://bugs.webkit.org/show_bug.cgi?id=62994
575
576         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
577         * WebCoreSupport/DumpRenderTreeSupportQt.h:
578
579 2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
580
581         Reviewed by Darin Adler.
582
583         Separate concerns of loading file icons and choosing files.
584         https://bugs.webkit.org/show_bug.cgi?id=62931
585
586         * WebCoreSupport/ChromeClientQt.cpp:
587         (WebCore::ChromeClientQt::loadIconForFiles): Renamed.
588         * WebCoreSupport/ChromeClientQt.h:
589
590 2011-06-17  Alexis Menard  <alexis.menard@openbossa.org>
591
592         Reviewed by Andreas Kling.
593
594         [Qt] Fix wrong framework generation on MacOS when inside Qt 4.8.
595         https://bugs.webkit.org/show_bug.cgi?id=62815
596
597         Partially revert r85870 which assumed that QtWebKit will never be build inside Qt
598         anymore. Everything inside !QTDIR_build condition is not needed in the Qt tree because
599         qbase.pri is doing the job for us, i.e. using includes generated by syncqt to
600         setup the mac framework. It also use a correct QMAKE_LFLAGS_SONAME making possible
601         to actually run an application linked against QtWebKit.
602
603         * QtWebKit.pro:
604
605 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
606
607         Unreviewed, rolling out r88796.
608         http://trac.webkit.org/changeset/88796
609         https://bugs.webkit.org/show_bug.cgi?id=62790
610
611         It made fast/dom/nodesFromRect-basic.html time out on Qt,
612         64-bit, debug mode (Requested by Ossy on #webkit).
613
614         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
615         (DumpRenderTreeSupportQt::plainText):
616         (DumpRenderTreeSupportQt::nodesFromRect):
617         * WebCoreSupport/DumpRenderTreeSupportQt.h:
618         * tests/qwebframe/tst_qwebframe.cpp:
619         (tst_QWebFrame::overloadedSlots):
620         (tst_QWebFrame::domCycles):
621
622 2011-06-15  Diego Gonzalez  <diegohcg@webkit.org>
623
624         Reviewed by Kenneth Rohde Christiansen.
625
626         [Qt] Inconsistent behavior on a form submit request...
627         https://bugs.webkit.org/show_bug.cgi?id=45523
628
629         The inconsistency occurs when a form submission requests a new window.
630         Two windows are opened (instead of only one) and the first window is opened
631         as a blank page.
632
633         By default each page is put into their own unique page group, which affects popup windows
634         and visited links. Page groups (per process only) is a feature making it possible to use
635         separate settings for each group, so that for instance an integrated browser/email reader
636         can use different settings for displaying HTML pages and HTML email. To make QtWebKit work
637         as expected out of the box, we use a default group similar to what other ports are doing.
638
639         * Api/qwebpage.cpp:
640
641 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
642
643         Reviewed by Andreas Kling.
644
645         [Qt] tst_QWebFrame::overloadedSlots() fails
646         https://bugs.webkit.org/show_bug.cgi?id=37319
647
648         Since the implicit conversion was removed, change support functions of DRT to
649         expect a QVariantMap instead of a QWebElement. This matches the exposed function
650         in the controller, which takes 'document' and not 'document.documentElement'.
651
652         And now that Element -> QWebElement is a perfect match, we must use QWebElement
653         instead of QVariantMap, like in plainText().
654
655         * WebCoreSupport/DumpRenderTreeSupportQt.h:
656         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
657         (DumpRenderTreeSupportQt::plainText): Fix to use QWebElement instead of
658         QVariantMap when getting the startContainer. Also use QVariantMap directly,
659         bridge will do conversion for us now.
660
661         (getCoreDocumentFromVariantMap): Extracts the WebCore::Document* from the
662         QVariantMap that Qt bridge gives us when 'document' is passed from JS.
663
664         (DumpRenderTreeSupportQt::nodesFromRect): Use helper function.
665
666         * tests/qwebframe/tst_qwebframe.cpp: Splitted the test domCycles() into two
667         different tests. In practice, the original test just checked whether we could
668         create a QVariantMap representing 'document' without infinite looping due to
669         cycles in the DOM. This was more evident before since we haven't a conversion
670         from JSElement to QWebElement, but from JSElement to QVariantMap.
671
672         (tst_QWebFrame::documentHasDocumentElement): Evaluates 'document' and extracts
673         'documentElement' from it. Compares to QWebFrame::documentElement().
674
675         (tst_QWebFrame::documentAllHasDocumentElement): Look inside 'document.all' for
676         the documentElement.
677
678         (tst_QWebFrame::overloadedSlots): Remove expected failure and fix wrong comment.
679
680 2011-06-14  Andreas Kling  <kling@webkit.org>
681
682         Reviewed by Benjamin Poulain.
683
684         [Qt] Don't include convenience "QWebFoo" headers in WebKit code.
685         https://bugs.webkit.org/show_bug.cgi?id=62632
686
687         * WebCoreSupport/FrameNetworkingContextQt.cpp:
688
689 2011-06-12  Adam Barth  <abarth@webkit.org>
690
691         Reviewed by Alexey Proskuryakov.
692
693         Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
694         https://bugs.webkit.org/show_bug.cgi?id=62516
695
696         * WebCoreSupport/FrameLoaderClientQt.cpp:
697         (WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
698         * WebCoreSupport/FrameLoaderClientQt.h:
699
700 2011-06-12  Adam Barth  <abarth@webkit.org>
701
702         Attempt to fix Qt build.
703
704         * WebCoreSupport/FrameLoaderClientQt.cpp:
705         (drtPrintFrameUserGestureStatus):
706
707 2011-06-12  Adam Barth  <abarth@webkit.org>
708
709         Reviewed by Eric Seidel.
710
711         Remove FrameLoader::isProcessingUserGesture
712         https://bugs.webkit.org/show_bug.cgi?id=62519
713
714         * WebCoreSupport/FrameLoaderClientQt.cpp:
715         (drtPrintFrameUserGestureStatus):
716
717 2011-06-10  Andreas Kling  <kling@webkit.org>
718
719         Reviewed by Benjamin Poulain.
720
721         [Qt] Fix 'headers' autotest when building inside Qt.
722         https://bugs.webkit.org/show_bug.cgi?id=62449
723
724         * Api/qwebkitplatformplugin.h:
725
726 2011-06-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
727
728         Reviewed by Kenneth Rohde Christiansen.
729
730         [Qt] Keep ORIENTATION_EVENTS independent from DEVICE_ORIENTATION
731         https://bugs.webkit.org/show_bug.cgi?id=62420
732
733         ORIENTATION_EVENTS and DEVICE_ORIENTATION features are very similar
734         but they meant to be independent.
735
736         * Api/qwebframe.cpp:
737         (QWebFramePrivate::_q_orientationChanged):
738         (QWebFrame::QWebFrame):
739         * Api/qwebframe_p.h:
740
741 2011-06-09  Andras Becsi  <abecsi@webkit.org>
742
743         Reviewed by Andreas Kling.
744
745         [Qt] Fix the in-tree build on Linux
746         https://bugs.webkit.org/show_bug.cgi?id=62378
747
748         In case of an in-tree build qmake generates defect prl dependencies for
749         the QtWebKit library, because the inclusion of qtbase.pri adds explicitlib to CONFIG.
750
751         * QtWebKit.pro: Remove explicitlib and staticlib from CONFIG.
752
753 2011-06-09  Robert Hogan  <robert@webkit.org>
754
755         Reviewed by Andreas Kling.
756
757         Teach Qt about window.internals
758         https://bugs.webkit.org/show_bug.cgi?id=61074
759
760         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
761         (DumpRenderTreeSupportQt::injectInternalsObject):
762         * WebCoreSupport/DumpRenderTreeSupportQt.h:
763
764 2011-06-08  Andreas Kling  <kling@webkit.org>
765
766         Reviewed by Benjamin Poulain.
767
768         [Qt] FrameLoaderClient: Check Vector::find() return value for WTF::notFound.
769         https://bugs.webkit.org/show_bug.cgi?id=62274
770
771         Vector::find() returns size_t (which is unsigned), so we should check
772         for WTF::notFound instead of -1.
773
774         * WebCoreSupport/FrameLoaderClientQt.cpp:
775         (WebCore::FrameLoaderClientQt::createPlugin):
776
777 2011-06-07  Noam Rosenthal  <noam.rosenthal@nokia.com>
778
779         Reviewed by Andreas Kling.
780
781         [Texmap][Qt] Enable TextureMapper by default
782         https://bugs.webkit.org/show_bug.cgi?id=61740
783
784         Enable TextureMapper on Windows+Symbian, disabling the direct OpenGL path. This would mean that
785         for now QtWebKit on Windows/Symbian would use the Qt backend for TextureMapper.
786
787         * WebCoreSupport/PageClientQt.cpp:
788         (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
789
790 2011-06-07  Aravind Akella  <aravind.akella@nokia.com>
791
792         Reviewed by Laszlo Gombos.
793
794         [Qt][Symbian] API test failure qdeclarativewebview
795         https://bugs.webkit.org/show_bug.cgi?id=59481
796
797         QML files cannot be loaded on Symbian due to difference 
798         in capabilities between qmlwebkitplugin.dll and Qtwebkit.dll.  
799         A PlatSec error that Qtwebkit.dll has "DRM AllFiles" capabilities 
800         missing is observed when dynamically loading the QML plugin. 
801
802         * declarative/declarative.pro: Match capabilities in QtWebKit.pro.
803         * symbian/platformplugin/platformplugin.pro: Match capabilities with the other 2 DLLs. 
804         Also remove TARGET.VID from platformplugin, as it's not used in any other Qt WebKit DLL,
805         and causes build warnings about undefined VENDOR_VID. 
806         * tests/tests.pri: Add WriteDeviceData capability for API tests. 
807
808 2011-06-04  Robert Hogan  <robert@webkit.org>
809
810         Reviewed by Andreas Kling.
811
812         [Qt] Fix and unskip acid2
813         https://bugs.webkit.org/show_bug.cgi?id=62089
814
815         shouldFallBack() tells the DOM if it should attempt to render
816         the next nested <object> if its parent fails to load.
817
818         This fix is only required for the fast/css version of the ACID2
819         test, which loads a non-existent file:// url. The HTTP version of the
820         test already passes because the loader will render fallback content
821         on a failed HTTP load without delegating the decision to the client
822         ( see MainResourceLoader::continueAfterContentPolicy).
823
824         Some ports also check for WebKitErrorPluginWillHandleLoad when deciding
825         what to return. This error isn't currently set by Qt so we don't check
826         it. (Other ports set it when the erring document is a MediaDocument, maybe
827         we should do that too at some point).
828
829         * WebCoreSupport/FrameLoaderClientQt.cpp:
830         (WebCore::FrameLoaderClientQt::shouldFallBack):
831
832 2011-06-03  Rafael Brandao  <rafael.lobo@openbossa.org>
833
834         Reviewed by Andreas Kling.
835
836         [Qt] It made two Qt API tests fail
837         https://bugs.webkit.org/show_bug.cgi?id=58847
838
839         Modified failing test's base url so it could get a valid origin
840         and make use of local storage. Also added another test that checks
841         local storage visibility in both scenarios.
842
843         * tests/qwebpage/tst_qwebpage.cpp:
844         (tst_QWebPage::testOptionalJSObjects):
845         (checkLocalStorageVisibility):
846         (tst_QWebPage::testLocalStorageVisibility):
847
848 2011-06-03  Alexis Menard  <alexis.menard@openbossa.org>
849
850         Reviewed by Andreas Kling.
851
852         [Qt] Warning fixes on comparisons between a signed and an unsigned.
853
854         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
855         (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
856         (DumpRenderTreeSupportQt::nodesFromRect):
857
858 2011-06-03  Alexis Menard  <alexis.menard@openbossa.org>
859
860         Reviewed by Andreas Kling.
861
862         To support building namespaced Qt, we require that forward-declarations
863         of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
864
865         * WebCoreSupport/FrameLoaderClientQt.h:
866
867 2011-06-03  Alexis Menard  <alexis.menard@openbossa.org>
868
869         Unreviewed build fix after r87902.
870
871         To support building namespaced Qt, we require that forward-declarations
872         of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE but
873         only on classes inside Qt.
874         
875         * WebCoreSupport/DumpRenderTreeSupportQt.h:
876
877 2011-06-03  Alexis Menard  <alexis.menard@openbossa.org>
878
879         Reviewed by Benjamin Poulain.
880
881         Some warning fixes. Values in switch not handled, and
882         a comparison between a signed and an unsigned.
883
884         * Api/qwebpage.cpp:
885         (QWebPagePrivate::inputMethodEvent):
886         (QWebPagePrivate::dynamicPropertyChangeEvent):
887         (QWebPage::action):
888
889 2011-06-02  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
890
891         Reviewed by Andreas Kling.
892
893         [Qt] Fix enum order in qwebpage.h public API header
894         https://bugs.webkit.org/show_bug.cgi?id=61959
895
896         Since qwebpage.h is a public header, we can't change the values of
897         the enumerations. This patch moves the new enumeration to the end
898         of the list. As a bonus, adds a missing entry in
899         editorCommandWebActions table.
900
901         * Api/qwebpage.cpp:
902         * Api/qwebpage.h:
903
904 2011-06-02  Andreas Kling  <kling@webkit.org>
905
906         Rubber-stamped by Simon Hausmann.
907
908         Remove Qt's precompiled header hack as it was broken, and was not even
909         used unless building WebKit inside a Qt tree.
910
911         * WebKit_pch.h: Removed.
912
913 2011-06-02  Andreas Kling  <kling@webkit.org>
914
915         Unreviewed build fix.
916
917         To support building namespaced Qt, we require that forward-declarations
918         of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
919
920         * WebCoreSupport/DumpRenderTreeSupportQt.h:
921
922 2011-06-01  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
923
924         Reviewed by Kenneth Rohde Christiansen.
925
926         [Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
927         https://bugs.webkit.org/show_bug.cgi?id=59345
928
929         KURL and QUrl disagree whether certain URLs are valid or not. The regression here
930         was caused by the fact that now KURL accepts "http:/example.com" (note only one
931         slash) and our test case used a strange edge case that's transformed into a
932         "one-slash" URL that now KURL can handle.
933
934         QtWebKit approach in this case is to do a best effort and accept the QUrl if KURL
935         can understand it. So I've updated the test to use a more meaningful example and
936         show that an invalid URL gets converted to a valid URL if possible.
937
938         * tests/qwebframe/tst_qwebframe.cpp:
939         (tst_QWebFrame::setUrlToInvalid):
940
941 2011-06-01  Andreas Kling  <kling@webkit.org>
942
943         Reviewed by Benjamin Poulain.
944
945         REGRESSION: [Qt] QNetworkReply delivered by the unsupportedContent() signal does not contain downloaded data
946         https://bugs.webkit.org/show_bug.cgi?id=49650
947
948         Defer emission of QWebPage::unsupportedContent() until we're back in the event loop.
949         This lets the QNAM backend finish with the reply without handing over ownership to the user code.
950
951         No new tests since this doesn't fail for qrc:// or file:// URLs and our tests can't depend on http:// URLs.
952
953         To correctly solve this issue, we need changes to Qt, tracked here:
954         http://bugreports.qt.nokia.com/browse/QTBUG-18718
955
956         * WebCoreSupport/FrameLoaderClientQt.cpp:
957         (WebCore::FrameLoaderClientQt::setFrame):
958         (WebCore::FrameLoaderClientQt::download):
959         * WebCoreSupport/FrameLoaderClientQt.h:
960
961 2011-06-01  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
962
963         Reviewed by Tor Arne Vestbø.
964
965         [Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals
966         https://bugs.webkit.org/show_bug.cgi?id=61739
967
968         The skipped test was imported from Qt source repository, and used private headers
969         to peek in the QML Grid element. This patch changes the QML used to expose the
970         information we want to test: number of pages opened and the first page opened.
971
972         * tests/qdeclarativewebview/resources/newwindows.html:
973         Added <body> tags. We have no reason to not use them in the test.
974
975         * tests/qdeclarativewebview/resources/newwindows.qml:
976         Moved the timer out of the page component, used anchors for setting webview size,
977         changed the way we count pages opened. Also changed coding style a bit.
978
979         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
980         (tst_QDeclarativeWebView::multipleWindows):
981         We now look for properties with the information we want in the rootItem: pagesOpened and
982         firstPageOpened.
983
984 2011-05-31  Rafael Brandao  <rafael.lobo@openbossa.org>
985
986         Reviewed by Andreas Kling.
987
988         [Qt] tst_QWebFrame::render() failing
989         https://bugs.webkit.org/show_bug.cgi?id=60893
990         
991         The test was expecting the frame contents to be already loaded
992         before rendering it into a QPicture. Renamed the test to fit
993         its real purpose more accordingly.
994
995         * tests/qwebframe/tst_qwebframe.cpp:
996         (tst_QWebFrame::renderGeometry):
997
998 2011-05-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
999
1000         Reviewed by Andreas Kling.
1001
1002         [Qt] Fix unnecessary wait in API autotest tst_QWebFrame::scrollbarsOff
1003         https://bugs.webkit.org/show_bug.cgi?id=61711
1004
1005         The loadFinished() signal was emitted directly inside the call for setHtml, so
1006         the test was waiting the loadFinished() signal with a big timeout. Change this by
1007         a very small timeout and a verification with signal spy.
1008
1009         In practice, setHtml() will either directly call loadFinished() or queue it to
1010         the next event loop run, and test will work for both situations.
1011
1012         * tests/qwebframe/tst_qwebframe.cpp:
1013         (tst_QWebFrame::scrollbarsOff):
1014
1015 2011-05-30  Noam Rosenthal  <noam.rosenthal@nokia.com>
1016
1017         Reviewed by Kenneth Rohde Christiansen.
1018
1019         [Texmap][Qt] Disable accelerated plugins/media in until they're working.
1020         https://bugs.webkit.org/show_bug.cgi?id=61687
1021
1022         Turn off accelerated compositing for media and plugins when in texture-mapper.
1023
1024         * Api/qwebsettings.cpp:
1025         (QWebSettingsPrivate::apply):
1026
1027 2011-05-28  Adam Barth  <abarth@webkit.org>
1028
1029         Reviewed by Alexey Proskuryakov.
1030
1031         Audit all uses of KURL::prettyURL
1032         https://bugs.webkit.org/show_bug.cgi?id=61201
1033
1034         Update callers of prettyURL to just call string.
1035
1036         * WebCoreSupport/ChromeClientQt.cpp:
1037         (WebCore::ChromeClientQt::mouseDidMoveOverElement):
1038         * WebCoreSupport/FrameLoaderClientQt.cpp:
1039         (WebCore::FrameLoaderClientQt::updateGlobalHistory):
1040         (WebCore::FrameLoaderClientQt::cancelledError):
1041         (WebCore::FrameLoaderClientQt::blockedError):
1042         (WebCore::FrameLoaderClientQt::objectContentType):
1043         (WebCore::FrameLoaderClientQt::createPlugin):
1044
1045 2011-05-27  Alexis Menard  <alexis.menard@openbossa.org>
1046
1047         Reviewed by Csaba Osztrogonác.
1048
1049         [Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
1050         https://bugs.webkit.org/show_bug.cgi?id=61044
1051
1052         Make sure to set the active window on the application too.
1053
1054         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1055         (tst_QGraphicsWebView::setPalette):
1056
1057 2011-05-26  Alexis Menard  <alexis.menard@openbossa.org>
1058
1059         Unreviewed build fix for Qt and QuickTime backend.
1060
1061         r87328 added a new system interface, we need to add it too.
1062
1063         * WebCoreSupport/WebSystemInterface.mm:
1064         (InitWebCoreSystemInterface):
1065
1066 2011-05-25  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1067
1068         Reviewed by Andreas Kling.
1069
1070         [Qt] JSC bridge: implement __qt_sender__ without using Scope Chain
1071         https://bugs.webkit.org/show_bug.cgi?id=61343
1072
1073         Create a '__qt_sender__' property in the global object, that returns the top of
1074         the qtSenderStack. This is an alternative implementation for the feature of
1075         providing a way for a function (acting as a Qt 'slot') discover which object
1076         emitted the signal that caused it to be executed.
1077
1078         This reduces the coupling of the Qt bridge and JSC internal implementation. The
1079         patch tries to use as much JSC public API as possible.
1080
1081         This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.
1082
1083         * WebCoreSupport/FrameLoaderClientQt.cpp:
1084         (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
1085         Instead of emitting the QWebPage::javaScriptWindowObjectCleared() directly, calls
1086         a QWebPagePrivate function to do it.
1087
1088         * Api/qwebframe_p.h:
1089         * Api/qwebframe.cpp:
1090         (QWebFramePrivate::didClearedWindowObject):
1091         Before emitting the signal mentioned, adds the '__qt_sender__' to the fresh
1092         global object.
1093
1094         (qtSenderCallback):
1095         Returns the JSObjectRef corresponding to the top of qtSenderStack.
1096
1097         (QWebFramePrivate::addQtSenderToGlobalObject):
1098         Create a property with a qtSenderCallback as getter function in the global object.
1099
1100 2011-05-25  Alexis Menard  <alexis.menard@openbossa.org>
1101
1102         Reviewed by Eric Carlson.
1103
1104         [Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
1105         https://bugs.webkit.org/show_bug.cgi?id=61279
1106
1107         Enable the usage of QuickTime backend for the Qt port. It can be enabled by
1108         passing DEFINES+=USE_QTKIT=1 when calling build-webkit.
1109
1110         * Api/qwebpage.cpp:
1111         (QWebPagePrivate::QWebPagePrivate):
1112         * QtWebKit.pro:
1113         * WebCoreSupport/FullScreenVideoQt.cpp:
1114         (WebCore::FullScreenVideoQt::enterFullScreenForNode):
1115         (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
1116         (WebCore::FullScreenVideoQt::isValid):
1117         * WebCoreSupport/WebSystemInterface.h: Added.
1118         * WebCoreSupport/WebSystemInterface.mm: Added.
1119         (InitWebCoreSystemInterface):
1120
1121 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1122
1123         Reviewed by Andreas Kling.
1124
1125         [Qt] fast/css/disabled-author-styles.html failed
1126         https://bugs.webkit.org/show_bug.cgi?id=61438
1127
1128         Provided API setAuthorAndUserStylesEnabled for DumpRenderTree.
1129
1130         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1131         (DumpRenderTreeSupportQt::setAuthorAndUserStylesEnabled):
1132         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1133
1134 2011-05-24  Adam Barth  <abarth@webkit.org>
1135
1136         Reviewed by Eric Seidel.
1137
1138         Add FIXME comments about removing FrameLoader::isProcessingUserGesture
1139         https://bugs.webkit.org/show_bug.cgi?id=61395
1140
1141         * WebCoreSupport/FrameLoaderClientQt.cpp:
1142         (drtPrintFrameUserGestureStatus):
1143
1144 2011-05-23  Luiz Agostini  <luiz.agostini@openbossa.org>
1145
1146         Reviewed by Andreas Kling.
1147
1148         [Qt] When opening a combo-box the popup renders badly.
1149         https://bugs.webkit.org/show_bug.cgi?id=61288
1150
1151         Removing combobox palette changes from QtFallbackWebPopup::show() because they
1152         are causing rendering problems for some styles.
1153
1154         The changes in palette are not needed because the background and foreground
1155         colors are already set by QStandardItem::setBackground() and QStandardItem::setForeground()
1156         in method QtFallbackWebPopup::populate().
1157
1158         * WebCoreSupport/QtFallbackWebPopup.cpp:
1159         (WebCore::QtFallbackWebPopup::show):
1160
1161 2011-05-23  Joe Wild  <joseph.wild@nokia.com>
1162
1163         Reviewed by Andreas Kling.
1164
1165         [Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
1166         https://bugs.webkit.org/show_bug.cgi?id=61200
1167
1168         * symbian/eabi/QtWebKitu.def:
1169
1170 2011-05-22  Hui Huang  <hui.2.huang@nokia.com>, Yi Shen  <yi.4.shen@nokia.com>
1171
1172         Reviewed by Laszlo Gombos.
1173
1174         [Qt] Upstream Symbian platform plugin
1175         https://bugs.webkit.org/show_bug.cgi?id=58435
1176
1177         Upstream Symbian platform plugin with html5 video player.
1178
1179         * symbian/platformplugin/HTML5VideoPlugin.cpp: Added.
1180         (HTML5FullScreenVideoHandler::HTML5FullScreenVideoHandler):
1181         (HTML5FullScreenVideoHandler::enterFullScreen):
1182         (HTML5FullScreenVideoHandler::exitFullScreen):
1183         (HTML5FullScreenVideoHandler::onPlayerError):
1184         (HTML5FullScreenVideoHandler::onPlayerStateChanged):
1185         (HTML5FullScreenVideoHandler::onMediaStatusChanged):
1186         (HTML5VideoPlugin::supportsExtension):
1187         (HTML5VideoPlugin::createExtension):
1188         * symbian/platformplugin/HTML5VideoPlugin.h: Added.
1189         (HTML5FullScreenVideoHandler::requiresFullScreenForVideoPlayback):
1190         (HTML5FullScreenVideoHandler::isFullScreen):
1191         (HTML5FullScreenVideoHandler::updateScreenRect):
1192         * symbian/platformplugin/HTML5VideoWidget.cpp: Added.
1193         (HTML5VideoWidget::HTML5VideoWidget):
1194         (HTML5VideoWidget::setDuration):
1195         (HTML5VideoWidget::mousePressEvent):
1196         (HTML5VideoWidget::onPlayerStopped):
1197         (HTML5VideoWidget::onPlayerError):
1198         (HTML5VideoWidget::onEndOfMedia):
1199         (HTML5VideoWidget::onBufferingMedia):
1200         (HTML5VideoWidget::onBufferedMedia):
1201         (HTML5VideoWidget::onControlClicked):
1202         (HTML5VideoWidget::onPositionChanged):
1203         (HTML5VideoWidget::onSliderMoved):
1204         (HTML5VideoWidget::onCloseClicked):
1205         (HTML5VideoWidget::showFullScreen):
1206         (HTML5VideoWidget::setVolume):
1207         * symbian/platformplugin/HTML5VideoWidget.h: Added.
1208         * symbian/platformplugin/OverlayWidget.cpp: Added.
1209         (OverlayWidget::OverlayWidget):
1210         (OverlayWidget::~OverlayWidget):
1211         (OverlayWidget::setDuration):
1212         (OverlayWidget::setPosition):
1213         (OverlayWidget::setVolume):
1214         (OverlayWidget::mousePressEvent):
1215         (OverlayWidget::onPlayerStopped):
1216         (OverlayWidget::onPlayerError):
1217         (OverlayWidget::onEndOfMedia):
1218         (OverlayWidget::onBufferingMedia):
1219         (OverlayWidget::onBufferedMedia):
1220         (OverlayWidget::timeToString):
1221         (OverlayWidget::applyStyleSheet):
1222         (OverlayWidget::onControlClicked):
1223         (OverlayWidget::onSliderMoved):
1224         (OverlayWidget::onSoundClicked):
1225         (OverlayWidget::onCloseClicked):
1226         (OverlayWidget::onVolumeSliderReleased):
1227         (OverlayWidget::onVolumeSliderMoved):
1228         (OverlayWidget::onTimerTimeout):
1229         (OverlayWidget::showFullScreen):
1230         * symbian/platformplugin/OverlayWidget.h: Added.
1231         * symbian/platformplugin/PlayerButton.cpp: Added.
1232         (PlayerButton::PlayerButton):
1233         (PlayerButton::event):
1234         * symbian/platformplugin/PlayerButton.h: Added.
1235         * symbian/platformplugin/PlayerLabel.cpp: Added.
1236         (PlayerLabel::PlayerLabel):
1237         (PlayerLabel::onPlayerError):
1238         (PlayerLabel::startBufferingAnimation):
1239         (PlayerLabel::stopBufferingAnimation):
1240         (PlayerLabel::onAnimationTimeout):
1241         * symbian/platformplugin/PlayerLabel.h: Added.
1242         * symbian/platformplugin/WebPlugin.cpp:
1243         (WebPlugin::createExtension):
1244         * symbian/platformplugin/images: Added.
1245         * symbian/platformplugin/images/button_cannotplay.png: Added.
1246         * symbian/platformplugin/images/button_close.png: Added.
1247         * symbian/platformplugin/images/button_pause.png: Added.
1248         * symbian/platformplugin/images/button_play.png: Added.
1249         * symbian/platformplugin/images/button_sound_off.png: Added.
1250         * symbian/platformplugin/images/button_sound_on.png: Added.
1251         * symbian/platformplugin/images/loading_buffering_1.png: Added.
1252         * symbian/platformplugin/images/loading_buffering_2.png: Added.
1253         * symbian/platformplugin/images/loading_buffering_3.png: Added.
1254         * symbian/platformplugin/images/loading_buffering_4.png: Added.
1255         * symbian/platformplugin/platformplugin.pro:
1256         * symbian/platformplugin/platformplugin.qrc: Added.
1257         * symbian/platformplugin/qss: Added.
1258         * symbian/platformplugin/qss/OverlayWidget.qss: Added.
1259
1260 2011-05-22  Robert Hogan  <robert@webkit.org>
1261
1262         Reviewed by Kenneth Rohde Christiansen.
1263
1264         Fix policyDelegate in Qt DRT
1265
1266         https://bugs.webkit.org/show_bug.cgi?id=61247
1267         
1268         Use the 'policy delegate' implemented in FrameLoaderClient
1269         for layout tests. The partial implementation in DumpRenderTreeQt
1270         is redundant.
1271
1272         * WebCoreSupport/FrameLoaderClientQt.cpp:
1273         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
1274
1275 2011-05-22  Andrew Wason  <rectalogic@rectalogic.com>
1276
1277         Reviewed by Benjamin Poulain.
1278
1279         [Qt] Implement toImageData() in QtWebKit Bridge
1280         https://bugs.webkit.org/show_bug.cgi?id=60897
1281
1282         * docs/qtwebkit-bridge.qdoc:
1283         * docs/webkitsnippets/qtwebkit_bridge_snippets.cpp:
1284         (wrapInFunction):
1285          Document Qt bridge toImageData() feature.
1286         * tests/hybridPixmap/test.html:
1287         * tests/hybridPixmap/widget.cpp:
1288         (Widget::Widget):
1289         (Widget::abcImage):
1290         * tests/hybridPixmap/widget.h:
1291          Add tests for Qt bridge toImageData() feature.
1292
1293 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
1294
1295         Reviewed by Sam Weinig.
1296
1297         numberOfActiveAnimations() can include animations from documents in the page cache
1298         https://bugs.webkit.org/show_bug.cgi?id=53641
1299
1300         Pass the Frame's document as the one to count animations on.
1301
1302         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1303         (DumpRenderTreeSupportQt::numberOfActiveAnimations):
1304
1305 2011-05-20  Csaba Osztrogonác  <ossy@webkit.org>
1306
1307         Reviewed by Benjamin Poulain.
1308
1309         [Qt] tst_QWebElement::style() fails because QWebElement::InlineStyle doesn't work as expected
1310         https://bugs.webkit.org/show_bug.cgi?id=60372
1311
1312         * tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail.
1313         (tst_QWebElement::style):
1314
1315 2011-05-20  Csaba Osztrogonác  <ossy@webkit.org>
1316
1317         Reviewed by Benjamin Poulain.
1318
1319         [Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
1320         https://bugs.webkit.org/show_bug.cgi?id=61042
1321
1322         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Mark failing test cases as expected fails.
1323         (tst_QDeclarativeWebView::basicProperties):
1324         (tst_QDeclarativeWebView::historyNav):
1325
1326 2011-05-20  Csaba Osztrogonác  <ossy@webkit.org>
1327
1328         Reviewed by Benjamin Poulain.
1329
1330         [Qt] Fix tst_QWebPage::testOptionalJSObjects() autotest
1331         https://bugs.webkit.org/show_bug.cgi?id=61045
1332
1333         * tests/qwebpage/tst_qwebpage.cpp:
1334         (tst_QWebPage::testOptionalJSObjects): Mark failing test cases as expected fails.
1335
1336 2011-05-20  Peter Varga  <pvarga@webkit.org>
1337
1338         Reviewed by Simon Hausmann.
1339
1340         [Qt][V8] Use qtscript-staging's shipped version of V8 when building with --v8
1341         https://bugs.webkit.org/show_bug.cgi?id=56649
1342
1343         Use the provided V8 and functionality of
1344         http://qt.gitorious.org/+qt-developers/qt/qtscript-staging to build QtWebKit+V8.
1345         Based on the original patch of Andras Becsi <abecsi@webkit.org>.
1346
1347         * Api/qwebframe.cpp:
1348         (QWebFrame::addToJavaScriptWindowObject): Fix QString deprecated
1349         warning.
1350         * QtWebKit.pro: Adding the V8 library should happen in the final build
1351         step.
1352         * WebCoreSupport/ChromeClientQt.cpp: Add missing head.
1353         * WebCoreSupport/DumpRenderTreeSupportQt.cpp: Ditto.
1354
1355 2011-05-20  Csaba Osztrogonác  <ossy@webkit.org>
1356
1357         Reviewed by Benjamin Poulain.
1358
1359         [Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
1360         https://bugs.webkit.org/show_bug.cgi?id=59345
1361
1362         * tests/qwebframe/tst_qwebframe.cpp:
1363         (tst_QWebFrame::setUrlToInvalid): Mark failing test cases as expected fails.
1364
1365 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
1366
1367         Reviewed by Csaba Osztrogonác.
1368
1369         [Qt] Implement eventSender.scalePageBy
1370         https://bugs.webkit.org/show_bug.cgi?id=60015
1371
1372         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1373         (DumpRenderTreeSupportQt::scalePageBy):
1374         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1375
1376 2011-05-18  Yi Shen  <yi.4.shen@nokia.com>
1377
1378         Reviewed by Andreas Kling.
1379
1380         [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
1381         https://bugs.webkit.org/show_bug.cgi?id=33179
1382
1383         Remove the implementation of the handleInputMethodKeydown, which introduces
1384         a regression(r82243) on Linux. Also, add more Api tests for the EnterKey event.
1385
1386         * WebCoreSupport/EditorClientQt.cpp:
1387         (WebCore::EditorClientQt::handleInputMethodKeydown): Remove implementation.
1388         * tests/qwebpage/tst_qwebpage.cpp:
1389         (tst_QWebPage::inputMethods): Add more tests.
1390
1391 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1392
1393         Reviewed by Csaba Osztrogonác.
1394
1395         [Qt] Implement layoutTestController.setValueForUser()
1396         https://bugs.webkit.org/show_bug.cgi?id=60956
1397
1398         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1399         (DumpRenderTreeSupportQt::setValueForUser):
1400         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1401
1402 2011-05-16  Robert Hogan  <robert@webkit.org>
1403
1404         Reviewed by Kenneth Rohde Christiansen.
1405
1406         plugins/invalidate_rect.html fails on linux ports
1407
1408         Add ChromeClientQt::allowsAcceleratedCompositing().
1409
1410         https://bugs.webkit.org/show_bug.cgi?id=54051
1411
1412         * WebCoreSupport/ChromeClientQt.cpp:
1413         (WebCore::ChromeClientQt::allowsAcceleratedCompositing):
1414         * WebCoreSupport/ChromeClientQt.h:
1415
1416 2011-05-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1417
1418         Reviewed by Andreas Kling.
1419
1420         [Qt] Simplify syntax in test code to make prepare-ChangeLog less confused
1421         https://bugs.webkit.org/show_bug.cgi?id=60978
1422
1423         Backslash to escape newlines was confusing both prepare-ChangeLog and the
1424         QtCreator highlight system.
1425
1426         * tests/qwebframe/tst_qwebframe.cpp:
1427         (tst_QWebFrame::evalJSV):
1428         Remove usage of backslash to escape newlines in string literal.
1429
1430 2011-05-17  Young Han Lee  <joybro@company100.net>
1431
1432         Reviewed by Csaba Osztrogonác.
1433
1434         [Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
1435         https://bugs.webkit.org/show_bug.cgi?id=60947
1436
1437         * WebCoreSupport/PageClientQt.cpp:
1438         (WebCore::PageClientQWidget::setRootGraphicsLayer):
1439
1440 2011-05-16  Jon Lee  <jonlee@apple.com>
1441
1442         Reviewed by Simon Fraser.
1443
1444         Can't horizontally scroll iframes and overflow because wheel events are always accepted
1445         https://bugs.webkit.org/show_bug.cgi?id=60779
1446
1447         * WebCoreSupport/ChromeClientQt.h:
1448         (WebCore::ChromeClientQt::shouldRubberBandInDirection): Default impl of new ChromeClient method
1449         (WebCore::ChromeClientQt::numWheelEventHandlersChanged): Default impl of new ChromeClient method
1450
1451 2011-05-16  Andreas Kling  <kling@webkit.org>
1452
1453         Reviewed by Kenneth Rohde Christiansen.
1454
1455         REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView.
1456         https://bugs.webkit.org/show_bug.cgi?id=60892
1457
1458         Don't set the ItemClipsChildrenToShape flag for the root platform layer,
1459         since that is now the overflow controls layer. The clip layer, which was
1460         previously the root platform layer, already gets the flag by way of
1461         the GraphicsLayer mask-to-bounds flag.
1462
1463         * WebCoreSupport/PageClientQt.cpp:
1464         (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
1465
1466 2011-05-16  Adam Barth  <abarth@webkit.org>
1467
1468         Partial revert of r86537.  FullScreenVideoQt.h can't depend on OwnPtr.h
1469         because moc_FullScreenVideoQt.cpp fails to include config.h.
1470         Apparently, having moc_FullScreenVideoQt.cpp properly include config.h
1471         is hard, so we're going back to manual new and delete for this class.
1472         Bad times.
1473
1474         * WebCoreSupport/FullScreenVideoQt.cpp:
1475         (WebCore::FullScreenVideoQt::FullScreenVideoQt):
1476         (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
1477         * WebCoreSupport/FullScreenVideoQt.h:
1478
1479 2011-05-16  Adam Barth  <abarth@webkit.org>
1480
1481         Sigh.  This code is somewhat crazy.
1482
1483         * WebCoreSupport/InspectorClientQt.cpp:
1484         (WebCore::InspectorClientQt::openInspectorFrontend):
1485
1486 2011-05-16  Adam Barth  <abarth@webkit.org>
1487
1488         Attempt to fix Qt build.  (Strict PassOwnPtr fix.)
1489
1490         This patch requires some slightly fancy footwork.
1491
1492         * WebCoreSupport/InspectorClientQt.cpp:
1493         (WebCore::InspectorClientQt::openInspectorFrontend):
1494         (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
1495
1496 2011-05-16  Adam Barth  <abarth@webkit.org>
1497
1498         Missing include.
1499
1500         * WebCoreSupport/PopupMenuQt.h:
1501
1502 2011-05-16  Adam Barth  <abarth@webkit.org>
1503
1504         [Qt] QtPlatformPlugin create methods should use PassOwnPtr
1505         https://bugs.webkit.org/show_bug.cgi?id=60873
1506
1507         This change is slightly more than a build fix because the patch kind of
1508         spidered a bit while I was trying to fix the build the "right way."
1509         Hopefully nothing here is controversial.
1510
1511         * Api/qwebpage.cpp:
1512         (QWebPagePrivate::adjustPointForClicking):
1513         * WebCoreSupport/ChromeClientQt.cpp:
1514         (WebCore::ChromeClientQt::createSelectPopup):
1515         * WebCoreSupport/FullScreenVideoQt.cpp:
1516         (WebCore::FullScreenVideoQt::FullScreenVideoQt):
1517         (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
1518         * WebCoreSupport/FullScreenVideoQt.h:
1519         * WebCoreSupport/NotificationPresenterClientQt.cpp:
1520         (WebCore::NotificationWrapper::NotificationWrapper):
1521         (WebCore::NotificationPresenterClientQt::displayNotification):
1522         * WebCoreSupport/PopupMenuQt.cpp:
1523         (WebCore::PopupMenuQt::PopupMenuQt):
1524         (WebCore::PopupMenuQt::~PopupMenuQt):
1525         (WebCore::PopupMenuQt::show):
1526         * WebCoreSupport/PopupMenuQt.h:
1527         * WebCoreSupport/QtPlatformPlugin.cpp:
1528         (WebCore::QtPlatformPlugin::createSelectInputMethod):
1529         (WebCore::QtPlatformPlugin::createNotificationPresenter):
1530         (WebCore::QtPlatformPlugin::createHapticFeedbackPlayer):
1531         (WebCore::QtPlatformPlugin::createTouchModifier):
1532         (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
1533         * WebCoreSupport/QtPlatformPlugin.h:
1534         (WebCore::QtPlatformPlugin::QtPlatformPlugin):
1535
1536 2011-05-15  Adam Barth  <abarth@webkit.org>
1537
1538         Attempt to fix the Qt build.  (Strict PassOwnPtr fix.)
1539
1540         * Api/qgraphicswebview.cpp:
1541         (QGraphicsWebViewPrivate::detachCurrentPage):
1542         (QGraphicsWebView::setPage):
1543         * Api/qwebpage.cpp:
1544         (QWebPage::setView):
1545
1546 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1547
1548         Unreviewed, rolling out r86504.
1549         http://trac.webkit.org/changeset/86504
1550         https://bugs.webkit.org/show_bug.cgi?id=60853
1551
1552         "Broke Qt EventSender in editing/selection tests" (Requested
1553         by mwenge on #webkit).
1554
1555         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1556         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1557
1558 2011-05-12  Robert Hogan  <robert@webkit.org>
1559
1560         Reviewed by Benjamin Poulain.
1561
1562         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1563         https://bugs.webkit.org/show_bug.cgi?id=60722
1564
1565         QWebPage::setView() will display the browser window, so
1566         implement a private version that does just enough to 
1567         satisfy EventSender's requirement to install an event
1568         filter on a page's web view.
1569
1570         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1571         (DumpRenderTreeSupportQt::setView):
1572         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1573
1574 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1575
1576         Unreviewed, rolling out r86447.
1577         http://trac.webkit.org/changeset/86447
1578         https://bugs.webkit.org/show_bug.cgi?id=60809
1579
1580         "Broke some uses of EventSender object on Qt" (Requested by
1581         mwenge on #webkit).
1582
1583         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1584         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1585
1586 2011-05-13  Sam Weinig  <sam@webkit.org>
1587
1588         Reviewed by Anders Carlsson.
1589
1590         Prune #includes from FrameView.h (Part 2)
1591         https://bugs.webkit.org/show_bug.cgi?id=60748
1592
1593         - Update files that were depending on FrameView.h #including Frame.h or
1594           Page.h.
1595
1596         * Api/qgraphicswebview.cpp:
1597         * WebCoreSupport/ChromeClientQt.cpp:
1598
1599 2011-05-13  Robert Hogan  <robert@webkit.org>
1600
1601         Reviewed by Benjamin Poulain.
1602
1603         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1604         https://bugs.webkit.org/show_bug.cgi?id=60722
1605
1606         QWebPage::setView() will display the browser window, so
1607         implement a private version that does just enough to 
1608         satisfy EventSender's requirement to install an event
1609         filter on a page's web view.
1610
1611         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1612         (DumpRenderTreeSupportQt::setView):
1613         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1614
1615 2011-05-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1616
1617         Reviewed by nobody, build fix.
1618
1619         [Qt] Fix build on MSVC.
1620
1621         qobject_cast<> requires the class to be exported on MSVC,
1622         removing it since the code that needs it is commented out for
1623         the same reason.
1624
1625         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
1626         (tst_QDeclarativeWebView::elementAreaAt):
1627
1628 2011-05-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1629
1630         Reviewed by nobody, build fix.
1631
1632         [Qt] Fix build on MSVC by only enabling tst_MIMESniffing on linux.
1633
1634         * tests/tests.pro:
1635
1636 2011-05-12  Young Han Lee  <joybro@company100.net>
1637
1638         Reviewed by Kenneth Rohde Christiansen.
1639
1640         [Qt] Implement layoutTestController.layerTreeAsText()
1641         https://bugs.webkit.org/show_bug.cgi?id=60367
1642
1643         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1644         (DumpRenderTreeSupportQt::layerTreeAsText):
1645         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1646
1647 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
1648
1649         Reviewed by Kenneth Rohde Christiansen.
1650
1651         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
1652         https://bugs.webkit.org/show_bug.cgi?id=60439
1653
1654         Patch 10/12: Glue the TextureMapper refactoring into Webkit(1).
1655         1. Pass a GraphicsLayer* instead of a PlatformLayer* to the QWebPageClient.
1656         2. Set parameters in TextureMapper/TextureMapperNode instead of passing them in an options argument.
1657         3. Rename PlatformLayerProxyQt to TextureMapperNodeClient
1658
1659         * Api/qwebframe.cpp:
1660         (QWebFramePrivate::renderCompositedLayers):
1661         * Api/qwebframe.h:
1662         * Api/qwebframe_p.h:
1663         (QWebFramePrivate::QWebFramePrivate):
1664         * WebCoreSupport/ChromeClientQt.cpp:
1665         (WebCore::ChromeClientQt::attachRootGraphicsLayer):
1666         * WebCoreSupport/PageClientQt.cpp:
1667         (WebCore::TextureMapperNodeClientQt::TextureMapperNodeClientQt):
1668         (WebCore::TextureMapperNodeClientQt::scroll):
1669         (WebCore::TextureMapperNodeClientQt::setTextureMapper):
1670         (WebCore::TextureMapperNodeClientQt::~TextureMapperNodeClientQt):
1671         (WebCore::TextureMapperNodeClientQt::computeLastModifiedRect):
1672         (WebCore::TextureMapperNodeClientQt::syncRootLayer):
1673         (WebCore::TextureMapperNodeClientQt::rootNode):
1674         (WebCore::PageClientQWidget::setRootGraphicsLayer):
1675         (WebCore::PageClientQWidget::syncLayers):
1676         (WebCore::PageClientQWidget::~PageClientQWidget):
1677         (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget):
1678         (WebCore::PageClientQGraphicsWidget::update):
1679         (WebCore::PageClientQGraphicsWidget::syncLayers):
1680         (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
1681         (WebCore::PageClientQGraphicsWidget::markForSync):
1682         * WebCoreSupport/PageClientQt.h:
1683         (WebCore::PageClientQWidget::PageClientQWidget):
1684         (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
1685         (WebCore::PageClientQGraphicsWidget::syncLayersTimeout):
1686
1687
1688 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
1689
1690         Reviewed by Kenneth Rohde Christiansen.
1691
1692         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
1693         https://bugs.webkit.org/show_bug.cgi?id=60439
1694
1695         Patch 4/12: Update the settings to enable accelerated compositing for all the relevant settings
1696         attributes.
1697
1698         * Api/qwebsettings.cpp:
1699         (qt_networkAccessAllowed):
1700         (QWebSettingsPrivate::apply):
1701
1702 2011-05-11  Sam Weinig  <sam@webkit.org>
1703
1704         Reviewed by Eric Seidel.
1705
1706         Stop including Console.h just to get Console enum types
1707         https://bugs.webkit.org/show_bug.cgi?id=60607
1708
1709         Move MessageSource, MessageType and MessageLevel into its own
1710         header and cleanup surrounding classes.
1711
1712         * Api/qwebelement.cpp:
1713
1714 2011-05-10  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1715
1716         Reviewed by Csaba Osztrogonác.
1717
1718         [Qt] Increment QtWebKit trunk version to 4.10.0
1719         https://bugs.webkit.org/show_bug.cgi?id=60549
1720
1721         QtWebKit-2.2 (branched) will be 4.9.0, so we need to
1722         increase the trunk version by 1.
1723
1724         * qt_webkit_version.pri:
1725
1726 2011-05-10  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1727
1728         Reviewed by Csaba Osztrogonác.
1729
1730         [Qt] tst_QWebPage creates temporary files in the current working dir
1731         https://bugs.webkit.org/show_bug.cgi?id=60497
1732
1733         tst_QWebPage was using QDir::currentPath when creating temporary dirs
1734         and leaving them after the test was run. I basically borrowed the fix
1735         from tst_QDeclarativeWebView.
1736
1737         * tests/qwebpage/tst_qwebpage.cpp:
1738         (removeRecursive):
1739         (tst_QWebPage::tmpDirPath):
1740         (tst_QWebPage::cleanupFiles):
1741         (tst_QWebPage::database):
1742         (tst_QWebPage::multiplePageGroupsAndLocalStorage):
1743
1744 2011-05-09  Chang Shu  <cshu@webkit.org>
1745
1746         Reviewed by Kenneth Rohde Christiansen.
1747
1748         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
1749         https://bugs.webkit.org/show_bug.cgi?id=60499
1750
1751         The implementation is similar to gtk.
1752
1753         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1754         (DumpRenderTreeSupportQt::confirmComposition):
1755         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1756
1757 2011-05-07  Joe Mason  <jmason@rim.com>
1758
1759         Reviewed by Daniel Bates.
1760
1761         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
1762         https://bugs.webkit.org/show_bug.cgi?id=52211
1763
1764         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
1765
1766         * WebCoreSupport/FrameLoaderClientQt.cpp:
1767         (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
1768
1769 2011-05-06  Kent Tamura  <tkent@chromium.org>
1770
1771         Reviewed by Ryosuke Niwa.
1772
1773         Eliminate WebCore/dom/InputElement.{cpp,h}
1774         https://bugs.webkit.org/show_bug.cgi?id=60262
1775
1776         * Api/qwebpage.cpp:
1777         (QWebPage::inputMethodQuery):
1778           Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength.
1779         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1780         (DumpRenderTreeSupportQt::setAutofilled):
1781           Follow the return type change of Node::toInputElement().
1782
1783 2011-05-04  Philippe Normand  <pnormand@igalia.com>
1784
1785         Reviewed by Dimitri Glazkov.
1786
1787         Implement LayoutTestController::pseudoShadowId()
1788         https://bugs.webkit.org/show_bug.cgi?id=60034
1789
1790         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1791         (DumpRenderTreeSupportQt::shadowPseudoId):
1792         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1793
1794 2011-05-05  Prasanth Ullattil  <prasanth.ullattil@nokia.com>
1795
1796         Reviewed by Simon Hausmann.
1797
1798         Install correct header files for webkit.
1799
1800         Since WebKit is no longer inside Qt, we can remove the detection for
1801         that.
1802
1803         [Qt] Install targets are not working correctly for modularized Qt and QtWebkit
1804         https://bugs.webkit.org/show_bug.cgi?id=57621
1805
1806         * QtWebKit.pro:
1807
1808 2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
1809
1810         Reviewed by Eric Seidel.
1811
1812         Rename SelectionController to FrameSelection
1813         https://bugs.webkit.org/show_bug.cgi?id=60234
1814
1815         * Api/qwebframe.cpp:
1816
1817 2011-05-05  Alexis Menard  <alexis.menard@openbossa.org>
1818
1819         Reviewed by Andreas Kling.
1820
1821         [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
1822         https://bugs.webkit.org/show_bug.cgi?id=60224
1823
1824         We should use nullptr rather than 0. nullptr will be added in the new C++ standard
1825         but WebKit already has a nullptr class if there is no c++0x support.
1826
1827         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1828         (DumpRenderTreeSupportQt::addUserStyleSheet):
1829
1830 2011-05-04  Cris Neckar  <cdn@chromium.org>
1831
1832         Reviewed by Adam Barth.
1833
1834         Expose WebView directly through ChromeClient.
1835         https://bugs.webkit.org/show_bug.cgi?id=49902
1836
1837         * WebCoreSupport/ChromeClientQt.h:
1838         (WebCore::ChromeClientQt::webView):
1839
1840 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
1841
1842         Unreviewed warning fix.
1843
1844         The variable is just unused.
1845
1846         * tests/qwebpage/tst_qwebpage.cpp:
1847         (tst_QWebPage::inputMethods):
1848
1849 2011-05-04  Tao Bai  <michaelbai@chromium.org>
1850
1851         Reviewed by David Kilzer.
1852
1853         Populate touch-icon url to FrameLoaderClient
1854         https://bugs.webkit.org/show_bug.cgi?id=59143
1855
1856         Respect the interface change in FrameLoaderClient.
1857
1858         * WebCoreSupport/FrameLoaderClientQt.cpp:
1859         (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
1860         * WebCoreSupport/FrameLoaderClientQt.h:
1861
1862 2011-03-31  Luiz Agostini  <luiz.agostini@openbossa.org>
1863
1864         Reviewed by Kenneth Rohde Christiansen.
1865
1866         [Qt] Qt WebKit updates view on HTTP 204 response
1867         https://bugs.webkit.org/show_bug.cgi?id=42529
1868
1869         Ignoring http responses which have status code equal to 204 (No Content)
1870         or 205 (Reset Content).
1871
1872         * WebCoreSupport/FrameLoaderClientQt.cpp:
1873         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
1874
1875 2011-05-04  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1876
1877         Reviewed by Benjamin Poulain.
1878
1879         [Qt] Fix signals emitted in FakeReply used in autotests
1880         https://bugs.webkit.org/show_bug.cgi?id=60049
1881
1882         The signals emitted for each case of FakeReply were swapped (error case
1883         emitting metaDataChanged() and redirect case emitting error()). Emitting
1884         readyRead() is not necessary.
1885
1886         * tests/qwebframe/tst_qwebframe.cpp:
1887         (FakeReply::FakeReply):
1888         Choose the different continue function for each case of FakeReply. This removes
1889         the need of the if-statement in timeout() and let us replace timeout() with two
1890         simpler functions.
1891
1892         (FakeReply::continueRedirect):
1893         (FakeReply::continueError):
1894         Continuation cases, emitting the minimal set of signals needed for each case.
1895
1896 2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>
1897
1898         Reviewed by Dimitri Glazkov.
1899
1900         Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
1901         https://bugs.webkit.org/show_bug.cgi?id=58703
1902
1903         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1904         (DumpRenderTreeSupportQt::shadowRoot): Added #include for ShadowRoot.h.
1905
1906 2011-05-03  Keith Kyzivat  <keith.kyzivat@nokia.com>
1907
1908         Reviewed by Andreas Kling.
1909
1910         [Qt] QtDeclarative Webview element has a fixed white background
1911         https://bugs.webkit.org/show_bug.cgi?id=40918
1912
1913         QProperty REVISION feature is not present in certain Qt Trunk clones.
1914         These builds report their version as 4.8.0, and therefore break on the
1915         prior #if QT_VERSION >= 0x040704.  The proper fix is to check based on
1916         the existance of Q_REVISION.
1917
1918         * declarative/plugin.cpp:
1919         (WebKitQmlPlugin::registerTypes):
1920         * declarative/qdeclarativewebview.cpp:
1921         * declarative/qdeclarativewebview_p.h:
1922
1923 2011-05-01  Sam Weinig  <sam@webkit.org>
1924
1925         Reviewed by Anders Carlsson.
1926
1927         Prune some unnecessary #includes
1928         https://bugs.webkit.org/show_bug.cgi?id=59895
1929
1930         Start getting rid of unnecessary #includes and forward declares.
1931
1932         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1933
1934 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
1935
1936         Reviewed by Adam Barth.
1937
1938         Enable strict OwnPtr for Qt
1939         https://bugs.webkit.org/show_bug.cgi?id=59667
1940
1941         * Api/qwebpage.cpp:
1942         (QWebPagePrivate::QWebPagePrivate):
1943
1944 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1945
1946         Reviewed by Simon Hausmann.
1947
1948         ENABLE(QT_BEARER) -> USE(QT_BEARER)
1949
1950         * Api/qwebsettings.cpp:
1951
1952 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1953
1954         Reviewed by Simon Hausmann.
1955
1956         ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
1957
1958         * Api/qwebpage.cpp:
1959
1960 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
1961
1962         Reviewed by Andreas Kling.
1963
1964         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
1965         https://bugs.webkit.org/show_bug.cgi?id=59704
1966
1967         * WebCoreSupport/QtFallbackWebPopup.cpp:
1968         (WebCore::QtFallbackWebPopup::show):
1969         * WebCoreSupport/QtFallbackWebPopup.h:
1970
1971 2011-04-27  Yi Shen  <yi.4.shen@nokia.com>
1972
1973         Reviewed by Kenneth Rohde Christiansen.
1974
1975         [Qt] Upstream Symbian platform plugin
1976         https://bugs.webkit.org/show_bug.cgi?id=58435
1977
1978         Upstream Symbian platform plugin.
1979
1980         * QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
1981         * symbian/platformplugin: Added.
1982         * symbian/platformplugin/WebPlugin.cpp: Added.
1983         (ItemListDelegate::ItemListDelegate):
1984         (ItemListDelegate::paint):
1985         (Popup::Popup):
1986         (Popup::resizeEvent):
1987         (Popup::populateList):
1988         (Popup::onItemSelected):
1989         (Popup::updateSelectionsBeforeDialogClosing):
1990         (Popup::updateAndClose):
1991         (WebPopup::WebPopup):
1992         (WebPopup::~WebPopup):
1993         (WebPopup::createSingleSelectionPopup):
1994         (WebPopup::createMultipleSelectionPopup):
1995         (WebPopup::createPopup):
1996         (WebPopup::show):
1997         (WebPopup::hide):
1998         (WebPopup::popupClosed):
1999         (WebPopup::itemClicked):
2000         (SingleSelectionPopup::SingleSelectionPopup):
2001         (MultipleSelectionPopup::MultipleSelectionPopup):
2002         (WebNotificationPresenter::showNotification):
2003         (WebPlugin::supportsExtension):
2004         (WebPlugin::createExtension):
2005         * symbian/platformplugin/WebPlugin.h: Added.
2006         (Popup::preSelectedIndices):
2007         (Popup::listWidget):
2008         (WebNotificationPresenter::WebNotificationPresenter):
2009         (WebNotificationPresenter::~WebNotificationPresenter):
2010         * symbian/platformplugin/platformplugin.pro: Added.
2011         * symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
2012         (QWebSelectData::~QWebSelectData):
2013         (QWebSelectMethod::~QWebSelectMethod):
2014         (QWebNotificationData::~QWebNotificationData):
2015         (QWebNotificationPresenter::QWebNotificationPresenter):
2016         (QWebNotificationPresenter::~QWebNotificationPresenter):
2017         (QWebTouchModifier::~QWebTouchModifier):
2018         (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
2019         (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
2020         (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
2021
2022 2011-04-26  Yi Shen  <yi.4.shen@nokia.com>
2023
2024         Reviewed by Tor Arne Vestbø.
2025
2026         [Qt][Symbian] Fix Api test failure -- tst_QWebFrame::setHtmlWithBaseURL  
2027         https://bugs.webkit.org/show_bug.cgi?id=56946
2028
2029         Deployed the missing resource for Symbian platform.
2030
2031         * tests/qwebframe/qwebframe.pro:
2032
2033 2011-04-26  Siddharth Mathur  <siddharth.mathur@nokia.com>
2034
2035         Reviewed by Andreas Kling.
2036
2037         [Qt] Build fix: QtDeclarative Webview element has a fixed white background
2038         https://bugs.webkit.org/show_bug.cgi?id=40918
2039
2040         Macro Q_REVISION and associated qdeclarativeitem.h signals are not available in 4.7.3 headers in Nokia Qt SDK.
2041
2042         * declarative/plugin.cpp: Bump up required version to 4.7.4+
2043         (WebKitQmlPlugin::registerTypes):
2044         * declarative/qdeclarativewebview.cpp: ditto
2045         * declarative/qdeclarativewebview_p.h: ditto
2046         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: ditto
2047
2048 2011-04-26  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2049
2050         Reviewed by Csaba Osztrogonác.
2051
2052         [Qt] Implement LayoutTestController::setAutofilled
2053         https://bugs.webkit.org/show_bug.cgi?id=59439
2054
2055         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2056         (DumpRenderTreeSupportQt::setAutofilled):
2057         * WebCoreSupport/DumpRenderTreeSupportQt.h:
2058
2059 2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>
2060
2061         Unreviewed, rolling out r84627.
2062         http://trac.webkit.org/changeset/84627
2063         https://bugs.webkit.org/show_bug.cgi?id=59271
2064
2065         It broke Symbian build (Requested by Ossy on #webkit).
2066
2067         * QtWebKit.pro:
2068         * symbian/platformplugin/WebPlugin.cpp: Removed.
2069         * symbian/platformplugin/WebPlugin.h: Removed.
2070         * symbian/platformplugin/platformplugin.pro: Removed.
2071         * symbian/platformplugin/qwebkitplatformplugin.h: Removed.
2072
2073 2011-04-22  Sam Weinig  <sam@webkit.org>
2074
2075         Fix qt build.
2076
2077         * Api/qwebelement.cpp:
2078         (setupScriptContext):
2079
2080 2011-04-22  Yi Shen  <yi.4.shen@nokia.com>
2081
2082         Reviewed by Kenneth Rohde Christiansen.
2083
2084         [Qt] Upstream Symbian platform plugin
2085         https://bugs.webkit.org/show_bug.cgi?id=58435
2086
2087         Upstream Symbian platform plugin.
2088
2089         * QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
2090         * symbian/platformplugin: Added.
2091         * symbian/platformplugin/WebPlugin.cpp: Added.
2092         (ItemListDelegate::ItemListDelegate):
2093         (ItemListDelegate::paint):
2094         (Popup::Popup):
2095         (Popup::resizeEvent):
2096         (Popup::populateList):
2097         (Popup::onItemSelected):
2098         (Popup::updateSelectionsBeforeDialogClosing):
2099         (Popup::updateAndClose):
2100         (WebPopup::WebPopup):
2101         (WebPopup::~WebPopup):
2102         (WebPopup::createSingleSelectionPopup):
2103         (WebPopup::createMultipleSelectionPopup):
2104         (WebPopup::createPopup):
2105         (WebPopup::show):
2106         (WebPopup::hide):
2107         (WebPopup::popupClosed):
2108         (WebPopup::itemClicked):
2109         (SingleSelectionPopup::SingleSelectionPopup):
2110         (MultipleSelectionPopup::MultipleSelectionPopup):
2111         (WebNotificationPresenter::showNotification):
2112         (WebPlugin::supportsExtension):
2113         (WebPlugin::createExtension):
2114         * symbian/platformplugin/WebPlugin.h: Added.
2115         (Popup::preSelectedIndices):
2116         (Popup::listWidget):
2117         (WebNotificationPresenter::WebNotificationPresenter):
2118         (WebNotificationPresenter::~WebNotificationPresenter):
2119         * symbian/platformplugin/platformplugin.pro: Added.
2120         * symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
2121         (QWebSelectData::~QWebSelectData):
2122         (QWebSelectMethod::~QWebSelectMethod):
2123         (QWebNotificationData::~QWebNotificationData):
2124         (QWebNotificationPresenter::QWebNotificationPresenter):
2125         (QWebNotificationPresenter::~QWebNotificationPresenter):
2126         (QWebTouchModifier::~QWebTouchModifier):
2127         (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
2128         (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
2129         (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
2130
2131 2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
2132
2133         Reviewed by Sam Weinig.
2134
2135         Add Frame* to the argument lists of canCopyCut and canPaste
2136         https://bugs.webkit.org/show_bug.cgi?id=59153
2137
2138         * WebCoreSupport/EditorClientQt.cpp:
2139         (WebCore::EditorClientQt::canCopyCut):
2140         (WebCore::EditorClientQt::canPaste):
2141         * WebCoreSupport/EditorClientQt.h:
2142
2143 2011-04-21  Yi Shen  <yi.4.shen@nokia.com>
2144
2145         Reviewed by Antonio Gomes.
2146
2147         [Qt] Fix the style issue for Api/qwebkitplatformplugin.h
2148         https://bugs.webkit.org/show_bug.cgi?id=59097
2149
2150         Fix the style issues for Api/qwebkitplatformplugin.h found by the webkit-check-style.
2151
2152         * Api/qwebkitplatformplugin.h:
2153
2154 2011-04-21  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2155
2156         Reviewed by Csaba Osztrogonác.
2157
2158         [Qt] REGRESSION(84057): It made 4 API tests fail
2159         https://bugs.webkit.org/show_bug.cgi?id=58848
2160
2161         After MIME sniffing support was added, some autotests are failing because
2162         the sniffer doesn't recognize our HTML pages.
2163
2164         This fixes tst_QWebPage::backActionUpdate(), tst_QWebPage::errorPageExtensionInFrameset()
2165         and tst_QWebFrame::horizontalScrollAfterBack().
2166
2167         * tests/qwebframe/resources/testiframe.html:
2168         * tests/qwebframe/resources/testiframe2.html:
2169         Remove spurious </html> in beginning of the document.
2170
2171         * tests/qwebpage/resources/framedindex.html:
2172         * tests/qwebpage/resources/index.html:
2173         Add <html> (and </html>) tags, <frameset> is not recognized by the sniffer as a
2174         possible starting tag for HTML document.
2175
2176         * tests/qwebpage/tst_qwebpage.cpp:
2177         (tst_QWebPage::errorPageExtensionInFrameset):
2178         Verify if we do have a main frame and the main frame has the children frames we
2179         expect. This will avoid crashing if for some reason children frames are not
2180         loaded.
2181
2182 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
2183
2184         Reviewed by Dimitri Glazkov.
2185
2186         layoutTestController can create and destroy shadow DOM
2187         https://bugs.webkit.org/show_bug.cgi?id=59058
2188
2189         Support for new methods in Qt DRT.
2190
2191         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2192         (DumpRenderTreeSupportQt::ensureShadowRoot):
2193         (DumpRenderTreeSupportQt::removeShadowRoot):
2194         * WebCoreSupport/DumpRenderTreeSupportQt.h:
2195
2196 2011-04-20  Balazs Kelemen  <kbalazs@webkit.org>
2197
2198         Reviewed by Csaba Osztrogonác.
2199
2200         [Qt] Cleanup includepath adjustment for generated files
2201         https://bugs.webkit.org/show_bug.cgi?id=58869
2202
2203         * QtWebKit.pro: Revert the hacky fix in r84174. Remove
2204         unnecessary logic.
2205
2206 2011-04-19  Yi Shen  <yi.4.shen@nokia.com>
2207
2208         Reviewed by Andreas Kling.
2209
2210         [Qt][Symbian] Fix Api test failure -- tst_QWebView::setPalette()
2211         https://bugs.webkit.org/show_bug.cgi?id=57254
2212
2213         Skip test for setPalette() which doesn't work 
2214         when WTF_USE_QT_MOBILE_THEME is defined.
2215
2216         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
2217         * tests/qwebview/tst_qwebview.cpp:
2218         * tests/tests.pri:
2219
2220 2011-04-19  Yi Shen  <yi.4.shen@nokia.com>
2221
2222         Reviewed by Laszlo Gombos.
2223
2224         [Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache
2225         https://bugs.webkit.org/show_bug.cgi?id=58044
2226
2227         Fixing this test by disabling the scrollbars on the graphics view 
2228         since QtWebKit handles scrolling and scrollbar automatically and correctly.
2229
2230         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
2231         (tst_QGraphicsWebView::widgetsRenderingThroughCache):
2232
2233 2011-04-19  Igor Oliveira  <igor.oliveira@openbossa.org>
2234
2235         Reviewed by Andreas Kling.
2236
2237         [Qt] X11: Text selection is causing oncopy event to be called
2238         https://bugs.webkit.org/show_bug.cgi?id=58656
2239
2240         Always when text is selected the oncopy event is fired, this behavior does
2241         not exist in Firefox or Chrome. Now, when selecting a text, QtWebKit
2242         is making multi part-copies (with rich text metadata), the multi-part
2243         data can be obtained by data transfer items interface when supported by QtWebKit.
2244         Also, copies to the clipboard of a selected image, is not supported by Chrome and
2245         Firefox and was removed from QtWebKit.
2246
2247
2248         * Api/qwebpage.cpp:
2249         (QWebPagePrivate::handleClipboard):
2250
2251 2011-04-18  Csaba Osztrogonác  <ossy@webkit.org>
2252
2253         [Qt][WK2] Unreviewed buildfix after r84174.
2254
2255         * QtWebKit.pro: Missing includepath added.
2256
2257 2011-04-18  Yi Shen  <yi.4.shen@nokia.com>
2258
2259         Reviewed by Laszlo Gombos.
2260
2261         [Qt][Symbian] Fix Api test failure -- tst_QWebFrame::inputFieldFocus
2262         https://bugs.webkit.org/show_bug.cgi?id=57546
2263
2264         Disable the fullscreen VKB when testing inputFieldFocus().
2265
2266         * tests/qwebframe/tst_qwebframe.cpp:
2267
2268 2011-04-18  Andreas Kling  <kling@webkit.org>
2269
2270         [Qt] DRT: Unreviewed test fix after r84168.
2271         
2272         Dump the original request KURL for blocked access attempts.
2273         Turns out converting it to a QUrl lower-cases the hostname.
2274
2275         * WebCoreSupport/FrameLoaderClientQt.cpp:
2276         (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
2277
2278 2011-04-18  Yi Shen  <yi.4.shen@nokia.com>
2279
2280         Reviewed by Laszlo Gombos.
2281
2282         [Qt] Fix Api tests for QWebPage on Symbian
2283         https://bugs.webkit.org/show_bug.cgi?id=56924
2284
2285         Ignores the style attribute that selectedHtml() returns.
2286
2287         * tests/qwebpage/tst_qwebpage.cpp:
2288         (tst_QWebPage::cursorMovements):
2289         (tst_QWebPage::textSelection):
2290         (tst_QWebPage::findText):
2291
2292 2011-04-18  Andreas Kling  <kling@webkit.org>
2293
2294         Reviewed by Adam Barth.
2295
2296         REGRESSION (r84010): [Qt] DRT: Unbreak redirection of http:/ URLs.
2297         https://bugs.webkit.org/show_bug.cgi?id=58779
2298
2299         KURL::host() doesn't return the host part of [broken] http:/ URLs, so use
2300         QUrl instead to match the behavior of other ports.
2301
2302         * WebCoreSupport/FrameLoaderClientQt.cpp:
2303         (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
2304
2305 2011-04-18  Dominic Cooney  <dominicc@chromium.org>
2306
2307         Reviewed by Andreas Kling.
2308
2309         Add layoutTestController.shadowRoot to Qt DRT.
2310         https://bugs.webkit.org/show_bug.cgi?id=58759
2311
2312         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2313         (DumpRenderTreeSupportQt::shadowRoot): Added.
2314         * WebCoreSupport/DumpRenderTreeSupportQt.h:
2315
2316 2011-04-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2317
2318         Reviewed by Andreas Kling.
2319
2320         [Qt] Autotest got missed in the handover of the QML WebView element
2321         https://bugs.webkit.org/show_bug.cgi?id=41449
2322
2323         Importing WebView QML element test cases from Qt repository. I did some
2324         style modifications and simplifications in the original code but hopefully
2325         without changing the behavior.
2326
2327         Tests that do not pass are marked with QEXPECT_FAIL or QSKIP. The two major
2328         issues currently are:
2329
2330         - pixelCache() test checked the usage of pixel cache by using a subclass of
2331           QDeclarativeWebView. We can't do that right now because this class is not
2332           exported. We may need a Q_AUTOTEST_EXPORT thing for QtWebKit if we want
2333           this kind of test.
2334         - elementAtArea() test uses a function that is not exported. But in this case
2335           I think we should test it's user, the public method "heuristicZoom".
2336
2337         * tests/qdeclarativewebview/resources/basic.html: Added.
2338         * tests/qdeclarativewebview/resources/basic.png: Added.
2339         * tests/qdeclarativewebview/resources/basic.qml: Added.
2340         * tests/qdeclarativewebview/resources/elements.html: Added.
2341         * tests/qdeclarativewebview/resources/elements.qml: Added.
2342         * tests/qdeclarativewebview/resources/forward.html: Added.
2343         * tests/qdeclarativewebview/resources/forward.png: Added.
2344         * tests/qdeclarativewebview/resources/javaScript.html: Added.
2345         * tests/qdeclarativewebview/resources/javaScript.qml: Added.
2346         * tests/qdeclarativewebview/resources/loadError.qml: Added.
2347         * tests/qdeclarativewebview/resources/newwindows.html: Added.
2348         * tests/qdeclarativewebview/resources/newwindows.qml: Added.
2349         * tests/qdeclarativewebview/resources/propertychanges.qml: Added.
2350         * tests/qdeclarativewebview/resources/sethtml.qml: Added.
2351         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
2352         (tst_QDeclarativeWebView::tmpDir):
2353         (strippedHtml):
2354         (fileContents):
2355         (removeRecursive):
2356         (tst_QDeclarativeWebView::cleanupTestCase):
2357         (tst_QDeclarativeWebView::basicProperties):
2358         (tst_QDeclarativeWebView::elementAreaAt):
2359         (tst_QDeclarativeWebView::historyNav):
2360         (callEvaluateJavaScript):
2361         (tst_QDeclarativeWebView::javaScript):
2362         (tst_QDeclarativeWebView::loadError):
2363         (tst_QDeclarativeWebView::multipleWindows):
2364         (tst_QDeclarativeWebView::newWindowComponent):
2365         (tst_QDeclarativeWebView::newWindowParent):
2366         (tst_QDeclarativeWebView::pressGrabTime):
2367         (tst_QDeclarativeWebView::renderingEnabled):
2368         (tst_QDeclarativeWebView::setHtml):
2369         (tst_QDeclarativeWebView::settings):
2370         (tst_QDeclarativeWebView::checkNoErrors):
2371         * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
2372
2373 2011-04-08  Luiz Agostini  <luiz.agostini@openbossa.org>
2374
2375         Reviewed by Kenneth Rohde Christiansen.
2376
2377         [Qt] QWebPage MIME type handling inconsistency with other web browsers
2378         https://bugs.webkit.org/show_bug.cgi?id=46968
2379
2380         Implementing mime type sniffing based on
2381         http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
2382
2383         * WebCoreSupport/FrameLoaderClientQt.cpp:
2384         (WebCore::FrameLoaderClientQt::createNetworkingContext):
2385         * WebCoreSupport/FrameNetworkingContextQt.cpp:
2386         (WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
2387         (WebCore::FrameNetworkingContextQt::create):
2388         (WebCore::FrameNetworkingContextQt::MIMESniffingEnabled):
2389         * WebCoreSupport/FrameNetworkingContextQt.h:
2390         * tests/MIMESniffing/MIMESniffing.pro: Added.
2391         * tests/MIMESniffing/TestData.h: Added.
2392         * tests/MIMESniffing/resources.qrc: Added.
2393         * tests/MIMESniffing/resources/application_atom+xml: Added.
2394         * tests/MIMESniffing/resources/application_ogg: Added.
2395         * tests/MIMESniffing/resources/application_pdf: Added.
2396         * tests/MIMESniffing/resources/application_postscript: Added.
2397         * tests/MIMESniffing/resources/application_rdf+xml: Added.
2398         * tests/MIMESniffing/resources/application_rss+xml: Added.
2399         * tests/MIMESniffing/resources/application_x-gzip: Added.
2400         * tests/MIMESniffing/resources/application_x-rar-compressed: Added.
2401         * tests/MIMESniffing/resources/application_zip: Added.
2402         * tests/MIMESniffing/resources/audio_x-wave: Added.
2403         * tests/MIMESniffing/resources/image_bmp: Added.
2404         * tests/MIMESniffing/resources/image_gif: Added.
2405         * tests/MIMESniffing/resources/image_jpeg: Added.
2406         * tests/MIMESniffing/resources/image_png: Added.
2407         * tests/MIMESniffing/resources/image_vnd.microsoft.icon: Added.
2408         * tests/MIMESniffing/resources/image_webp: Added.
2409         * tests/MIMESniffing/resources/text_html: Added.
2410         * tests/MIMESniffing/resources/text_xml: Added.
2411         * tests/MIMESniffing/resources/video_webm: Added.
2412         * tests/MIMESniffing/tst_MIMESniffing.cpp: Added.
2413         (tst_MIMESniffing::tst_MIMESniffing):
2414         (errorText):
2415         (tst_MIMESniffing::testCase1):
2416         * tests/tests.pro:
2417
2418 2011-04-15  Andreas Kling  <kling@webkit.org>
2419
2420         Reviewed by Antonio Gomes.
2421
2422         [Qt] DRT: Block access to external URLs.
2423
2424         Implement the "Blocked access to external URL" behavior for Qt's DRT,
2425         based on what other ports are doing.
2426
2427         Fixes <http://webkit.org/b/57306> and <http://webkit.org/b/58523>.
2428
2429         * WebCoreSupport/FrameLoaderClientQt.cpp:
2430         (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
2431
2432 2011-01-26  Ragner Magalhaes  <ragner.magalhaes@openbossa.org>
2433
2434         Reviewed by Antonio Gomes.
2435
2436         [Qt] Web Inspector does not highlight elements
2437         https://bugs.webkit.org/show_bug.cgi?id=35125
2438
2439         Adjust Web inspector to highlight elements on the page when the mouse
2440         hovers the element on DOM inspector.
2441
2442         * Api/qwebframe.cpp:
2443         (QWebFramePrivate::renderRelativeCoords):
2444         * WebCoreSupport/InspectorClientQt.cpp:
2445         (WebCore::InspectorClientQt::highlight):
2446         (WebCore::InspectorClientQt::hideHighlight):
2447
2448 2011-04-12  George Guo  <George.Guo@nokia.com>
2449
2450         Reviewed by Laszlo Gombos.
2451
2452         [Qt] On Symbian got "Update Error" when installing QtWebkit.sis
2453         http://bugs.webkit.org/show_bug.cgi?id=58141
2454
2455         If QtWebKit is already in Symbian ROM, we need package to be
2456         both SA and RU type
2457
2458         * QtWebKit.pro:
2459
2460 2011-04-12  Alexis Menard  <alexis.menard@openbossa.org>
2461
2462         Reviewed by Andreas Kling.
2463
2464         [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
2465         https://bugs.webkit.org/show_bug.cgi?id=58251
2466
2467         Fix an issue with slot names after http://trac.webkit.org/changeset/83512.
2468
2469         * Api/qwebframe.cpp:
2470         (QWebFrame::QWebFrame):
2471
2472 2011-04-11  Alexis Menard  <alexis.menard@openbossa.org>
2473
2474         Reviewed by Benjamin Poulain.
2475
2476         [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
2477         https://bugs.webkit.org/show_bug.cgi?id=58251
2478
2479         Qt coding conventions states that private slots should be located in private implementation of
2480         the class. This allows us to rename/delete the slots in the future without breaking anything.
2481
2482         No new tests added, just a simple refactoring.
2483
2484         * Api/qwebframe.cpp:
2485         (QWebFramePrivate::_q_orientationChanged):
2486         * Api/qwebframe.h:
2487         * Api/qwebframe_p.h:
2488
2489 2011-04-11  Alexis Menard  <alexis.menard@openbossa.org>
2490
2491         Reviewed by Kenneth Rohde Christiansen.
2492
2493         [Qt] Sub-Frame content is not updated when scrolling in certain circumstances
2494         https://bugs.webkit.org/show_bug.cgi?id=50373
2495
2496         Make sure that we invalidate the backing store when using TILED_BACKING_STORE
2497         and the page contains sub frames. This bug appears only when frame flattening is
2498         disabled and scrollable subframes.
2499
2500         Original patch from Thomas Thrainer.
2501
2502         * WebCoreSupport/ChromeClientQt.cpp:
2503         (WebCore::ChromeClientQt::invalidateWindow):
2504
2505 2011-04-11  Benjamin Poulain  <benjamin.poulain@nokia.com>
2506
2507         Reviewed by Andreas Kling.
2508
2509         [Qt] HTML5 Drag and Drop demos not working
2510         https://bugs.webkit.org/show_bug.cgi?id=56486
2511
2512         Handling the drop with JavaScript was not working with Qt because if the action is ignored
2513         in response to DragEnter, no further events are sent to the view.
2514
2515         Drag and drop is defined and used differently by webpages. The drag move events are determining
2516         what action should take place. To adopt this behavior for Qt, we always accept drag enter events
2517         on the widget.
2518
2519         * Api/qwebpage.cpp:
2520         (QWebPagePrivate::dragEnterEvent):
2521
2522 2011-04-11  Andras Becsi  <abecsi@webkit.org>
2523
2524         Reviewed by Andreas Kling.
2525
2526         [Qt] REGRESSION(83122): tst_QWebElement::style() fails
2527         https://bugs.webkit.org/show_bug.cgi?id=58032
2528
2529         According to the documentation of QWebElement the styleProperty method should
2530         not respect style inheritance and other CSS rules for the InlineStyle enum.
2531
2532         r83122 fixed this behaviour.
2533
2534         * tests/qwebelement/tst_qwebelement.cpp:
2535         (tst_QWebElement::style): Fix the expected color for QWebElement::InlineStyle.
2536
2537 2011-04-11  Andreas Kling  <andreas.kling@nokia.com>
2538
2539         Build fix after r83436.
2540
2541         * WebCoreSupport/FrameLoaderClientQt.cpp:
2542         (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
2543
2544 2011-04-11  Andreas Kling  <andreas.kling@nokia.com>
2545
2546         Reviewed by Benjamin Poulain.
2547
2548         [Qt] dumpResourceResponseMIMETypes shouldn't strip URL query string.
2549
2550         * WebCoreSupport/FrameLoaderClientQt.cpp:
2551         (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): Use KURL::lastPathComponent()
2552         for the dumpResourceResponseMIMETypes display string instead of QFileInfo::fileName().
2553         This is in line with the Mac port.
2554
2555 2011-04-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2556
2557         Unreviewed, rolling out r83295.
2558         http://trac.webkit.org/changeset/83295
2559         https://bugs.webkit.org/show_bug.cgi?id=58144
2560
2561         Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
2562
2563         * WebCoreSupport/EditorClientQt.cpp:
2564         (WebCore::EditorClientQt::handleInputMethodKeydown):
2565
2566 2011-04-08  Yi Shen  <yi.4.shen@nokia.com>
2567
2568         Reviewed by Antonio Gomes.
2569
2570         [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
2571         https://bugs.webkit.org/show_bug.cgi?id=57472
2572
2573         Avoid to insert new line for both keydown event & keypress event.
2574
2575         * WebCoreSupport/EditorClientQt.cpp:
2576         (WebCore::EditorClientQt::handleInputMethodKeydown):
2577
2578 2011-04-07  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2579
2580         Reviewed by Benjamin Poulain.
2581
2582         [Qt] QWebFrame::setUrl works only from second time if url fragment is present
2583         https://bugs.webkit.org/show_bug.cgi?id=32723
2584
2585         When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(),
2586         use an invalid URL (the begin() without arguments). Clearing the document
2587         with the same URL was causing problems when we had a fragment because it assume that
2588         only scrolling was enough and did not loaded the document again.
2589
2590         When setUrl() is called but fails, url() is expected to return the requested value. The
2591         begin(url) guaranteed that before. This patch adds a member to track the URL, which is
2592         updated when the URL changes and also when setUrl() is called.
2593
2594         KURL was used for the member so that when setUrl() is called, and then url() is checked
2595         before the page gets loaded, we perform the same conversion that will be performed by a
2596         successful load, e.g. add trailing '/' to an address. This behavior is checked by
2597         tst_QWebFrame::requestedUrl() test.
2598
2599         For the record: the second QWebPage::setUrl() worked because the load was considered a
2600         FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was
2601         needed. See FrameLoader::shouldScrollToAnchor() for details on this classification.
2602
2603         * Api/qwebframe.cpp:
2604         (QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal.
2605         (clearCoreFrame):
2606         (isCoreFrameClear):
2607         (QWebFrame::setUrl):
2608         (QWebFrame::url):
2609         (QWebFrame::baseUrl): look in the document for the baseURL since its contents can change
2610         the baseURL, e.g. by using the <base> tag.
2611         * Api/qwebframe_p.h:
2612
2613         * WebCoreSupport/FrameLoaderClientQt.cpp:
2614         (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
2615         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
2616
2617         * tests/qwebframe/tst_qwebframe.cpp:
2618         (tst_QWebFrame::setUrlWithFragment): unskip test.
2619
2620 2011-04-07  Alexis Menard  <alexis.menard@openbossa.org>
2621
2622         Reviewed by Kenneth Rohde Christiansen.
2623
2624         Build fix when using Phonon as a backend for the multimedia support.
2625
2626         * WebCoreSupport/ChromeClientQt.cpp:
2627         (WebCore::ChromeClientQt::ChromeClientQt):
2628         (WebCore::ChromeClientQt::~ChromeClientQt):
2629         * WebCoreSupport/ChromeClientQt.h:
2630
2631 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
2632
2633         Reviewed by Kenneth Rohde Christiansen.
2634
2635         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
2636         https://bugs.webkit.org/show_bug.cgi?id=56086
2637
2638         Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
2639         from the LayoutTestController.
2640
2641         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2642         (DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
2643         * WebCoreSupport/DumpRenderTreeSupportQt.h:
2644
2645 2011-04-06  Anders Bakken  <agbakken@gmail.com>
2646
2647         Reviewed by Kenneth Rohde Christiansen.
2648
2649         [Qt] FrameLoaderClientQt.cpp has coding-style errors
2650         https://bugs.webkit.org/show_bug.cgi?id=40254
2651
2652         * WebCoreSupport/FrameLoaderClientQt.cpp:
2653         (drtDescriptionSuitableForTestResult):
2654         (WebCore::FrameLoaderClientQt::hasWebView):
2655         (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
2656         (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
2657         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
2658         (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
2659         (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
2660         (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
2661         (WebCore::FrameLoaderClientQt::postProgressStartedNotification):
2662         (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
2663         (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
2664         (WebCore::FrameLoaderClientQt::willChangeTitle):
2665         (WebCore::FrameLoaderClientQt::didChangeTitle):
2666         (WebCore::FrameLoaderClientQt::finishedLoading):
2667         (WebCore::FrameLoaderClientQt::frameLoadCompleted):
2668         (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
2669         (WebCore::FrameLoaderClientQt::didFinishLoad):
2670         (WebCore::FrameLoaderClientQt::setTitle):
2671         (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
2672         (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
2673         (WebCore::FrameLoaderClientQt::updateGlobalHistory):
2674         (WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
2675         (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem):
2676         (WebCore::FrameLoaderClientQt::committedLoad):
2677         (WebCore::FrameLoaderClientQt::download):
2678         (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
2679         (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
2680         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
2681         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
2682         (WebCore::FrameLoaderClientQt::createFrame):
2683         (WebCore::FrameLoaderClientQt::objectContentType):
2684         (WebCore::FrameLoaderClientQt::createPlugin):
2685
2686 2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>
2687
2688         Reviewed by Andreas Kling.
2689
2690         [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
2691         https://bugs.webkit.org/show_bug.cgi?id=57974
2692
2693         We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
2694
2695         No new tests needed, just a config flag rename.
2696
2697         * Api/qwebkitplatformplugin.h:
2698         * WebCoreSupport/ChromeClientQt.cpp:
2699         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2700         (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
2701         * WebCoreSupport/FullScreenVideoQt.cpp:
2702         (WebCore::FullScreenVideoQt::FullScreenVideoQt):
2703         (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
2704         (WebCore::FullScreenVideoQt::enterFullScreenForNode):
2705         (WebCore::FullScreenVideoQt::exitFullScreenForNode):
2706         (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
2707         (WebCore::FullScreenVideoQt::isValid):
2708         * WebCoreSupport/FullScreenVideoQt.h:
2709         * WebCoreSupport/QtPlatformPlugin.cpp:
2710         * WebCoreSupport/QtPlatformPlugin.h:
2711         * examples/platformplugin/WebPlugin.cpp:
2712         (WebPlugin::supportsExtension):
2713         (WebPlugin::createExtension):
2714         * examples/platformplugin/WebPlugin.h:
2715         * examples/platformplugin/platformplugin.pro:
2716         * examples/platformplugin/qwebkitplatformplugin.h:
2717         * tests/qwebpage/tst_qwebpage.cpp:
2718         (tst_QWebPage::loadHtml5Video):
2719         * tests/tests.pri:
2720
2721 2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>
2722
2723         Reviewed by Andreas Kling.
2724
2725         [Qt] Implement fullscreen playback for the GStreamer backend.
2726         https://bugs.webkit.org/show_bug.cgi?id=56826
2727
2728         Implement support for fullscreen playback when building the
2729         Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
2730         The implementation is done in FullScreenVideoQt alongside with
2731         the Qt Multimedia support.
2732
2733         No new tests because layout tests cover it. They are not yet activated
2734         but will be any time soon.
2735
2736         * QtWebKit.pro:
2737         * WebCoreSupport/ChromeClientQt.cpp:
2738         (WebCore::ChromeClientQt::ChromeClientQt):
2739         (WebCore::ChromeClientQt::~ChromeClientQt):
2740         (WebCore::ChromeClientQt::enterFullscreenForNode):
2741         (WebCore::ChromeClientQt::exitFullscreenForNode):
2742         * WebCoreSupport/ChromeClientQt.h:
2743         * WebCoreSupport/FullScreenVideoQt.cpp:
2744         (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
2745         (WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
2746         (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
2747         (WebCore::GStreamerFullScreenVideoHandler::windowClosed):
2748         (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
2749         (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
2750         (WebCore::FullScreenVideoQt::FullScreenVideoQt):
2751         (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
2752         (WebCore::FullScreenVideoQt::enterFullScreenForNode):
2753         (WebCore::FullScreenVideoQt::exitFullScreenForNode):
2754         (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
2755         (WebCore::FullScreenVideoQt::isValid):
2756         * WebCoreSupport/FullScreenVideoQt.h:
2757         (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):
2758
2759 2011-04-06  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2760
2761         Reviewed by Kenneth Rohde Christiansen.
2762
2763         [Qt] Improve tests for QWebFrame::url() and related methods
2764         https://bugs.webkit.org/show_bug.cgi?id=57865
2765
2766         * tests/qwebframe/tst_qwebframe.cpp:
2767         (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
2768         (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
2769         that fails and a load() that fails (for a different URL).
2770
2771         (tst_QWebFrame::setUrlWithFragment_data):
2772         (tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
2773         the URL in the frame before the test starts.
2774
2775         (tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
2776         the same URL as argument.
2777
2778         (extractBaseUrl):
2779         (tst_QWebFrame::setUrlThenLoads_data):
2780         (tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
2781         sequence of set and loads. Those tests are interesting because the properties
2782         react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
2783         is used or after the load() is committed and baseUrl() is similar to url() but also depends
2784         on the contents of the page when it loads.
2785
2786 2011-04-04  MORITA Hajime  <morrita@google.com>
2787
2788         Reviewed by Ryosuke Niwa.
2789
2790         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
2791         https://bugs.webkit.org/show_bug.cgi?id=56085
2792         
2793         * WebCoreSupport/EditorClientQt.h:
2794         (WebCore::EditorClientQt::requestCheckingOfString):
2795
2796 2011-04-04  Chang Shu  <cshu@webkit.org>
2797
2798         Reviewed by Ryosuke Niwa.
2799
2800         setContentEditable with true/false/inherit string is not working properly
2801         https://bugs.webkit.org/show_bug.cgi?id=52058
2802
2803         Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
2804         as rendererIsEditable is for WebCore internal use.
2805
2806         * WebCoreSupport/EditorClientQt.cpp:
2807         (WebCore::EditorClientQt::handleKeyboardEvent):
2808
2809 2011-04-01  Carol Szabo  <carol.szabo@nokia.com>
2810
2811         Reviewed by Benjamin Poulain.
2812
2813         Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
2814         Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.
2815
2816         Tiled painting still causes synchronous layout when
2817         accelerated compositing and texture mapper are enabled
2818         https://bugs.webkit.org/show_bug.cgi?id=56929
2819
2820         * Api/qwebframe.cpp:
2821         (QWebFramePrivate::renderFromTiledBackingStore):
2822         (QWebFramePrivate::renderRelativeCoords):
2823         (QWebFramePrivate::renderFrameWidgets):
2824         * Api/qwebframe_p.h:
2825
2826 2011-04-01  Nancy Piedra  <nancy.piedra@nokia.com>
2827
2828         Reviewed by Benjamin Poulain.
2829
2830         [Qt] DragClientQt.h has coding-style errors
2831         https://bugs.webkit.org/show_bug.cgi?id=40425
2832
2833         * WebCoreSupport/DragClientQt.h:
2834
2835 2011-03-31  Marius Storm-Olsen  <marius.storm-olsen@nokia.com>
2836
2837         Reviewed by Kenneth Rohde Christiansen.
2838
2839         [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
2840         https://bugs.webkit.org/show_bug.cgi?id=57017
2841
2842         Build fix. No new tests.
2843
2844         * QtWebKit.pro:
2845
2846 2011-03-31  Evan Martin  <evan@chromium.org>
2847
2848         Another build fix.
2849
2850         * WebCoreSupport/FrameLoaderClientQt.cpp:
2851         (WebCore::FrameLoaderClientQt::updateGlobalHistory):
2852
2853 2011-03-31  Nancy Piedra  <nancy.piedra@nokia.com>
2854
2855         Reviewed by Benjamin Poulain.
2856
2857         [Qt] ChromeClientQt.h has coding-style errors
2858         https://bugs.webkit.org/show_bug.cgi?id=40239
2859
2860         * WebCoreSupport/ChromeClientQt.h:
2861         (WebCore::ChromeClientQt::scrollbarsModeDidChange):
2862         (WebCore::ChromeClientQt::needTouchEvents):
2863         (WebCore::ChromeClientQt::formStateDidChange):
2864         (WebCore::ChromeClientQt::scrollRectIntoView):
2865         (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
2866         (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
2867
2868 2011-03-31  Evan Martin  <evan@chromium.org>
2869
2870         Build fix from previous change.
2871
2872         * Api/qwebframe.cpp:
2873         (QWebFrame::title):
2874
2875 2011-03-31  Evan Martin  <evan@chromium.org>
2876
2877         Reviewed by Eric Seidel.
2878
2879         <title> should support dir attribute
2880         https://bugs.webkit.org/show_bug.cgi?id=50961
2881
2882         Update to new FrameLoaderClient interface.
2883
2884         * WebCoreSupport/FrameLoaderClientQt.cpp:
2885         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
2886         (WebCore::FrameLoaderClientQt::setTitle):
2887         * WebCoreSupport/FrameLoaderClientQt.h:
2888
2889 2011-03-30  Yi Shen  <yi.4.shen@nokia.com>
2890
2891         Reviewed by Kenneth Rohde Christiansen.
2892
2893         [Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
2894         https://bugs.webkit.org/show_bug.cgi?id=57020
2895
2896         Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().
2897
2898         * tests/qwebview/tst_qwebview.cpp:
2899         (tst_QWebView::focusInputTypes):
2900
2901 2011-03-30  Robert Hogan  <robert@webkit.org>
2902
2903         Reviewed by Antonio Gomes.
2904
2905         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
2906
2907         Add DRT support for loading an alternate HTML string
2908         for error pages. This allows Qt to unskip
2909         http/tests/navigation/go-back-to-error-page.html.
2910
2911         https://bugs.webkit.org/show_bug.cgi?id=52614
2912
2913         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2914         (DumpRenderTreeSupportQt::setAlternateHtml):
2915         * WebCoreSupport/DumpRenderTreeSupportQt.h:
2916
2917 2011-03-29  Alexis Menard  <alexis.menard@openbossa.org>
2918
2919         Unreviewed build fix for build-webkit -minimal.
2920
2921         Breakage introduced by http://trac.webkit.org/changeset/82238.
2922         The minimal option has no support for shortcuts.
2923
2924         * WebCoreSupport/EditorClientQt.cpp:
2925         (WebCore::EditorClientQt::handleInputMethodKeydown):
2926
2927 2011-03-29  Janne Koskinen  <janne.p.koskinen@digia.com>
2928
2929         Reviewed by Kenneth Rohde Christiansen.
2930
2931         [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
2932         https://bugs.webkit.org/show_bug.cgi?id=33179
2933
2934         Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.
2935
2936         * WebCoreSupport/EditorClientQt.cpp:
2937         (WebCore::EditorClientQt::handleInputMethodKeydown):
2938         * tests/qwebpage/tst_qwebpage.cpp:
2939         (tst_QWebPage::inputMethods):
2940
2941 2011-03-29  Andreas Kling  <kling@webkit.org>
2942
2943         Reviewed by Simon Hausmann.
2944
2945         [Qt] Fix documentation for QWebPage::repaintRequested()
2946
2947         This signal is always emitted when the page is dirtied, so remove
2948         reference to old behavior where we would only emit the signal for
2949         headless QWebPages.
2950
2951         * Api/qwebpage.cpp:
2952
2953 2011-03-28  Andreas Kling  <kling@webkit.org>
2954
2955         Reviewed by Benjamin Poulain.
2956
2957         [Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.
2958
2959         * WebCoreSupport/FrameLoaderClientQt.cpp:
2960         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
2961
2962 2011-03-28  Andreas Kling  <kling@webkit.org>
2963
2964         Reviewed by Benjamin Poulain.
2965
2966         [Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
2967         https://bugs.webkit.org/show_bug.cgi?id=52629
2968
2969         * WebCoreSupport/ChromeClientQt.cpp:
2970         (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
2971         QWebPage::repaintRequested() use a Qt::QueuedConnection.
2972
2973         * tests/qwebpage/tst_qwebpage.cpp:
2974         (RepaintRequestedRenderer::RepaintRequestedRenderer):
2975         (RepaintRequestedRenderer::onRepaintRequested):
2976         (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
2977         QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
2978         doesn't cause recursive signal emissions.
2979
2980 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2981
2982         Reviewed by Andreas Kling.
2983
2984         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2985         https://bugs.webkit.org/show_bug.cgi?id=57087
2986
2987         * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
2988         * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
2989         since they are applications, not libraries.
2990
2991 2011-03-28  Andras Becsi  <abecsi@webkit.org>
2992
2993         Reviewed by Csaba Osztrogonác.
2994
2995         [Qt] QtWebKit does not link with --3d-canvas using MinGW
2996         https://bugs.webkit.org/show_bug.cgi?id=57225
2997
2998         * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
2999
3000 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3001
3002         Reviewed by Andreas Kling.
3003
3004         REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
3005         https://bugs.webkit.org/show_bug.cgi?id=57183
3006
3007         Windows buildfix after r82065.
3008
3009         * Api/DerivedSources.pro: Readding escaping on Windows platforms.
3010
3011 2011-03-27  Andreas Kling  <kling@webkit.org>
3012
3013         Fix build warning about IconDatabaseClient.h (wrong path.)
3014
3015         * QtWebKit.pro:
3016
3017 2011-03-27  Andreas Kling  <kling@webkit.org>
3018
3019         Reviewed by Kenneth Rohde Christiansen.
3020
3021         [Qt] Support for CSS color and background-color properties on select element's dropdown list
3022         https://bugs.webkit.org/show_bug.cgi?id=51627
3023
3024         Extend the QWebSelectData interface with background and foreground colors
3025         for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
3026         getters in RenderMenuList.
3027
3028         * Api/qwebkitplatformplugin.h:
3029         * WebCoreSupport/PopupMenuQt.cpp:
3030         (SelectData::backgroundColor):
3031         (SelectData::foregroundColor):
3032         (SelectData::itemBackgroundColor):
3033         (SelectData::itemForegroundColor):
3034         * WebCoreSupport/QtFallbackWebPopup.cpp:
3035         (WebCore::QtFallbackWebPopup::show):
3036         (WebCore::QtFallbackWebPopup::populate):
3037
3038 2011-03-27  Yi Shen  <yi.4.shen@nokia.com>
3039
3040         Reviewed by Andreas Kling.
3041
3042         [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
3043         https://bugs.webkit.org/show_bug.cgi?id=57108
3044
3045         Since the canvas is not self-closing tag, we need to add '</canvas>'. 
3046
3047         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
3048         (tst_QGraphicsWebView::microFocusCoordinates):
3049         * tests/qwebview/tst_qwebview.cpp:
3050         (tst_QWebView::microFocusCoordinates):
3051
3052 2011-03-27  Kwang Yul Seo  <skyul@company100.net>
3053
3054         Reviewed by Eric Seidel.
3055
3056         [Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
3057         https://bugs.webkit.org/show_bug.cgi?id=57143
3058
3059         Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
3060         define WTF_USE_TEXTURE_MAPPER=1.
3061
3062         * QtWebKit.pro:
3063
3064 2011-03-27  Andreas Kling  <kling@webkit.org>
3065
3066         Reviewed by Benjamin Poulain.
3067
3068         REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
3069         https://bugs.webkit.org/show_bug.cgi?id=57183
3070
3071         The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
3072         which was due to the outputting code previously being wrapped in eval().
3073
3074         * Api/DerivedSources.pro:
3075
3076 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
3077
3078         Reviewed by Andreas Kling.
3079
3080         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
3081         https://bugs.webkit.org/show_bug.cgi?id=57087
3082
3083         Use explicit conversion for string to avoid depending on the default codec
3084         installed by the user code.
3085
3086         * Api/qwebkitversion.cpp:
3087         (qWebKitVersion):
3088         * Api/qwebpage.cpp:
3089         (QWebPagePrivate::dynamicPropertyChangeEvent):
3090         (QWebPage::javaScriptConsoleMessage):
3091         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3092         (convertToPropertyName):
3093         (DumpRenderTreeSupportQt::setEditingBehavior):
3094         (DumpRenderTreeSupportQt::plainText):
3095         * WebCoreSupport/EditorClientQt.cpp:
3096         (dumpRange):
3097         * WebCoreSupport/FrameLoaderClientQt.cpp:
3098         (drtDescriptionSuitableForTestResult):
3099         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
3100         * WebCoreSupport/InspectorClientQt.cpp:
3101         (WebCore::InspectorClientQt::openInspectorFrontend):
3102         * WebCoreSupport/InspectorServerQt.cpp:
3103         (WebCore::parseWebSocketChallengeNumber):
3104         (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
3105
3106 2011-03-26  Andreas Kling  <kling@webkit.org>
3107
3108         Reviewed by Kenneth Rohde Christiansen.
3109
3110         [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
3111         https://bugs.webkit.org/show_bug.cgi?id=57157
3112
3113         Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
3114         is always emitted when appropriate.
3115
3116         * QtWebKit.pro: Add new files.
3117
3118         * WebCoreSupport/IconDatabaseClientQt.h: Added.
3119         * WebCoreSupport/IconDatabaseClientQt.cpp: Added.
3120         (WebCore::IconDatabaseClientQt::instance):
3121         (WebCore::IconDatabaseClientQt::IconDatabaseClientQt):
3122         (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt):
3123         (WebCore::IconDatabaseClientQt::performImport):
3124         (WebCore::IconDatabaseClientQt::didRemoveAllIcons):
3125         (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL):
3126         (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL):
3127         (WebCore::IconDatabaseClientQt::didChangeIconForPageURL):
3128         (WebCore::IconDatabaseClientQt::didFinishURLImport):
3129
3130         * WebCoreSupport/FrameLoaderClientQt.h:
3131         * WebCoreSupport/FrameLoaderClientQt.cpp:
3132         (WebCore::FrameLoaderClientQt::registerForIconNotification):
3133         (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected
3134         to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the
3135         QWebFrame::iconChanged() signal when the IconDatabases finishes loading
3136         a cached favicon for the frame's URL.
3137
3138         * Api/qwebsettings.cpp:
3139         (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is
3140         instantiated. An IconDatabaseClient has to be registered before the IconDatabase
3141         spawns its reader thread.
3142
3143 2011-03-25  Andy Estes  <aestes@apple.com>
3144
3145         Reviewed by Adele Peterson.
3146
3147         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
3148         https://bugs.webkit.org/show_bug.cgi?id=49016
3149
3150         Update objectContentType() implementation to handle the
3151         shouldPreferPlugInsForImages flag.
3152
3153         * WebCoreSupport/FrameLoaderClientQt.cpp:
3154         (WebCore::FrameLoaderClientQt::objectContentType):
3155         * WebCoreSupport/FrameLoaderClientQt.h:
3156
3157 2011-03-25  Chang Shu  <cshu@webkit.org>
3158
3159         Reviewed by Ryosuke Niwa.
3160
3161         rename Node::isContentEditable and all call sites to rendererIsEditable
3162         https://bugs.webkit.org/show_bug.cgi?id=54290
3163
3164         This is part of the effort to separate JS API HTMLElement isContentEditable from
3165         internal Node::rendererIsEditable.
3166
3167         * WebCoreSupport/EditorClientQt.cpp:
3168         (WebCore::EditorClientQt::handleKeyboardEvent):
3169
3170 2011-03-25  Alexis Menard  <alexis.menard@openbossa.org>
3171
3172         Reviewed by Andreas Kling.
3173
3174         [Qt] The keyboard shortcuts during fullscreen playback do not work.
3175         https://bugs.webkit.org/show_bug.cgi?id=57095
3176
3177         We need to explicitely set the focus on the widget in order to receive the keyboard events.
3178
3179         * WebCoreSupport/FullScreenVideoWidget.cpp:
3180         (WebCore::FullScreenVideoWidget::show):
3181
3182 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3183
3184         Unreviewed, rolling out r81916 and r81917.
3185         http://trac.webkit.org/changeset/81916
3186         http://trac.webkit.org/changeset/81917
3187         https://bugs.webkit.org/show_bug.cgi?id=57071
3188
3189         broke a test on platforms that do not have QuickTime installed
3190         (Requested by estes on #webkit).
3191
3192         * WebCoreSupport/FrameLoaderClientQt.cpp:
3193         (WebCore::FrameLoaderClientQt::objectContentType):
3194         * WebCoreSupport/FrameLoaderClientQt.h:
3195
3196 2011-03-24  Andy Estes  <aestes@apple.com>
3197
3198         Reviewed by Darin Adler.
3199
3200         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
3201         https://bugs.webkit.org/show_bug.cgi?id=49016
3202
3203         Update objectContentType() implementation to handle the
3204         shouldPreferPlugInsForImages flag.
3205
3206         * WebCoreSupport/FrameLoaderClientQt.cpp:
3207         (WebCore::FrameLoaderClientQt::objectContentType):
3208         * WebCoreSupport/FrameLoaderClientQt.h:
3209
3210 2011-03-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
3211
3212         Reviewed by Kenneth Rohde Christiansen.
3213
3214         [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
3215         https://bugs.webkit.org/show_bug.cgi?id=40884
3216
3217         Add tests and benchmarks for the software fallback of WebGL.
3218
3219         * tests/benchmarks/webgl/10000_triangles.html: Added.
3220         * tests/benchmarks/webgl/tst_webgl.cpp: Added.
3221         (GraphicsView::GraphicsView):
3222         (GraphicsView::resizeEvent):
3223         (tst_WebGlPerformance::init):
3224         (tst_WebGlPerformance::cleanup):
3225         (tst_WebGlPerformance::benchSoftwareFallbackRgb16):
3226         (tst_WebGlPerformance::benchSoftwareFallbackRgb32):
3227         (tst_WebGlPerformance::benchSoftwareFallbackArgb32):
3228         (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
3229         (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
3230         * tests/benchmarks/webgl/tst_webgl.qrc: Added.
3231         * tests/benchmarks/webgl/webgl.pro: Added.
3232         * tests/qgraphicswebview/qgraphicswebview.pro:
3233         * tests/qgraphicswebview/resources/pointing_right.html: Added.
3234         * tests/qgraphicswebview/resources/pointing_up.html: Added.
3235         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
3236         (compareImagesFuzzyPixelCount):
3237         (GraphicsView::GraphicsView):
3238         (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
3239         (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
3240         (tst_QGraphicsWebView::compareCanvasToImage):
3241         * tests/qgraphicswebview/tst_qgraphicswebview.qrc:
3242         * tests/tests.pro:
3243
3244 2011-03-24  Kristian Amlie  <kristian.amlie@nokia.com>
3245
3246         Reviewed by Benjamin Poulain.
3247
3248         Avoided ASCII-cast warnings for WebKit.
3249
3250         Normally they won't be enabled anyway, but if you build webkit from
3251         within the Qt mother repository it will pick up Qt's default build
3252         settings, which do enable it. We need to disable them because
3253         warnings are treated as errors and there are way too many of them in
3254         the WebKit code.
3255
3256         [Qt] Avoid ASCII-cast warnings for WebKit.
3257         https://bugs.webkit.org/show_bug.cgi?id=57016
3258
3259         * QtWebKit.pro:
3260
3261 2011-03-24  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3262
3263         Reviewed by Benjamin Poulain.
3264
3265         [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
3266         https://bugs.webkit.org/show_bug.cgi?id=29595
3267
3268         Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
3269         ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
3270         prepending the current directory.
3271
3272         By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
3273         will end up loading "about:blank", but keeping it as a requested URL.
3274
3275         This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
3276         is filled for the loaded URLs as well, we can use it in every case.
3277
3278         Three new autotests were added, to better cover the expected behavior of setting
3279         the QUrl() in a QWebFrame.
3280
3281         * Api/qwebframe.cpp:
3282         (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
3283         (QWebFrame::requestedUrl): always use m_lastRequestedUrl.
3284
3285         * WebCoreSupport/FrameLoaderClientQt.cpp:
3286         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
3287         anymore, since we always rely on it even for loaded frames.
3288
3289         * tests/qwebframe/tst_qwebframe.cpp:
3290         (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
3291         the reduction of the bug report.
3292         (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
3293         (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
3294
3295 2011-03-23  Brady Eidson  <beidson@apple.com>
3296
3297         Reviewed by Sam Weinig.
3298
3299         Change IconDatabase opening to allow for arbitrary filenames
3300         https://bugs.webkit.org/show_bug.cgi?id=56977
3301
3302         * Api/qwebsettings.cpp:
3303         (QWebSettings::setIconDatabasePath):
3304
3305 2011-03-23  Aparna Nandyal  <aparna.nand@wipro.com>
3306
3307         Reviewed by Andreas Kling.
3308
3309         [Qt] QtWebKit rendering problem when maximizing and doing a back
3310         https://bugs.webkit.org/show_bug.cgi?id=56669
3311
3312         Added an auto test.
3313         Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21
3314  
3315         * tests/qwebview/tst_qwebview.cpp:
3316         (tst_QWebView::rendering):
3317
3318 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
3319
3320         Reviewed by Pavel Feldman.
3321
3322         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
3323         https://bugs.webkit.org/show_bug.cgi?id=56843
3324
3325         * WebCoreSupport/InspectorClientQt.cpp:
3326         (WebCore::InspectorClientQt::openInspectorFrontend):
3327
3328 2011-03-22  Andrew Wason  <rectalogic@rectalogic.com>
3329
3330         Reviewed by Benjamin Poulain.
3331
3332         [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
3333         https://bugs.webkit.org/show_bug.cgi?id=54138
3334
3335         * tests/qwebpage/tst_qwebpage.cpp:
3336         (webGLScreenshotWithoutView):
3337         (tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
3338         (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
3339          Render a QWebPage (with and without accelerated compositing)
3340          with a WebGL context that has no owning view.  Shouldn't crash.
3341
3342 2011-03-21  Chang Shu  <cshu@webkit.org>
3343
3344         Reviewed by Alexey Proskuryakov.
3345
3346         REGRESSION (r79953): Can't type in MS Outlook 2011
3347         https://bugs.webkit.org/show_bug.cgi?id=56665
3348
3349         r79953 removed the WebView level editablity which is persistent no matter whether
3350         underlying document itself is changed and editability gets lost. The resolution is to
3351         set this WebView editable value to WebCore. This avoids the callback from WebCore to
3352         WebKit which was the main goal in r79953 to improve performance.
3353
3354         * Api/qwebpage.cpp:
3355         (QWebPage::setContentEditable):
3356         (QWebPage::isContentEditable):
3357
3358 2011-03-19  Andreas Kling  <kling@webkit.org>
3359
3360         Reviewed by Benjamin Poulain.
3361
3362         [Qt] Remove support for Qt 4.6
3363         https://bugs.webkit.org/show_bug.cgi?id=56712
3364
3365         * Api/qwebframe.cpp:
3366         (QWebFrame::load):
3367         * Api/qwebpage.cpp:
3368         (QWebPagePrivate::QWebPagePrivate):
3369         * Api/qwebsettings.cpp:
3370         (QWebSettings::QWebSettings):
3371         * WebCoreSupport/GeolocationClientQt.cpp:
3372         (WebCore::GeolocationClientQt::positionUpdated):
3373
3374 2011-03-19  Andreas Kling  <kling@webkit.org>
3375
3376         Reviewed by Antonio Gomes.
3377
3378         [Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
3379         https://bugs.webkit.org/show_bug.cgi?id=56711
3380
3381         Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
3382         ownership of the reply is transferred to the receiving slot.
3383
3384         * Api/qwebpage.cpp:
3385
3386 2011-03-17  Brady Eidson  <beidson@apple.com>
3387
3388         Reviewed by Sam Weinig.
3389
3390         https://bugs.webkit.org/show_bug.cgi?id=56425
3391         More groundwork for WebKit2 IconDatabase
3392
3393         Update already-used function names:
3394         * Api/qwebhistory.cpp:
3395         (QWebHistoryItem::icon):
3396         * Api/qwebsettings.cpp:
3397         (QWebSettings::iconForUrl):
3398
3399 2011-03-18  Alexis Menard  <alexis.menard@openbossa.org>
3400
3401         Reviewed by Benjamin Poulain.
3402
3403         [Qt] console.log not being exposed to QmlViewer
3404         https://bugs.webkit.org/show_bug.cgi?id=56536
3405
3406         The documentation is bogus the feature does not exist.
3407
3408         * declarative/qdeclarativewebview.cpp:
3409
3410 2011-03-17  Andreas Kling  <kling@webkit.org>
3411
3412         Reviewed by Kenneth Rohde Christiansen.
3413
3414         [Qt] QML WebView emits iconChanged() when the page title changes
3415         https://bugs.webkit.org/show_bug.cgi?id=56570
3416
3417         * declarative/qdeclarativewebview.cpp:
3418         (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
3419         signal to the view's iconChanged signal.
3420
3421 2011-03-17  Alexis Menard  <alexis.menard@openbossa.org>
3422
3423         Reviewed by Benjamin Poulain.
3424
3425         [Qt] Videos look ugly when using QGraphicsWebView.
3426         https://bugs.webkit.org/show_bug.cgi?id=56580
3427
3428         We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
3429         QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
3430         by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
3431         QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
3432         ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
3433         in addition of what could be set on the painter. In order to not break the rendering of all the items in the
3434         scene we set back the painter to its original state when QGraphicsWebView is rendered.
3435
3436         * Api/qgraphicswebview.cpp:
3437         (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
3438         (QGraphicsWebView::paint):
3439         (QGraphicsWebView::renderHints):
3440         (QGraphicsWebView::setRenderHints):
3441         (QGraphicsWebView::setRenderHint):
3442         * Api/qgraphicswebview.h:
3443         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
3444         (tst_QGraphicsWebView::renderHints):
3445
3446 2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>
3447
3448         Reviewed by Kenneth Rohde Christiansen.
3449
3450         Viewport no longer allows an auto value for "user-scalable"
3451         https://bugs.webkit.org/show_bug.cgi?id=55416
3452
3453         Make the default value for userScalable be true.
3454
3455         * Api/qwebpage.cpp:
3456         (QWebPage::viewportAttributesForSize):
3457         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3458         (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.
3459
3460 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3461
3462         Reviewed by Darin Adler.
3463
3464         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
3465         info into the headers rather than in export symbol definition files, but disable it on 
3466         all platforms initially so we can deal with port build issues one port at a time.
3467         
3468         https://bugs.webkit.org/show_bug.cgi?id=27551
3469
3470         * WebCoreSupport/GeolocationClientQt.cpp:
3471         * WebCoreSupport/PopupMenuQt.cpp:
3472
3473 2011-03-14  Brady Eidson  <beidson@apple.com>
3474
3475         Reviewed by Anders Carlsson.
3476
3477         https://bugs.webkit.org/show_bug.cgi?id=56320
3478         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
3479
3480         * Api/qwebhistory.cpp:
3481         (QWebHistoryItem::icon): Use IconDatabase directly.
3482
3483 2011-03-11  Brady Eidson  <beidson@apple.com>
3484
3485         Reviewed by attempt at build fix!
3486
3487         https://bugs.webkit.org/show_bug.cgi?id=56216
3488         Fix the Qt build following the same pattern of the patch.
3489
3490         * Api/qwebsettings.cpp:
3491         (QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
3492
3493 2011-03-11  Alexis Menard  <alexis.menard@openbossa.org>
3494
3495         Reviewed by Ariya Hidayat.
3496
3497         [Qt] Entering fullscreen and leaving it may hide the cursor of the application.
3498         https://bugs.webkit.org/show_bug.cgi?id=56181
3499
3500         We need to stop the auto hide cursor timer when closing the widget otherwise the timer
3501         might get fired and therefore hide the cursor even when the fullscreen widget is closed.
3502
3503         * WebCoreSupport/FullScreenVideoWidget.cpp:
3504         (WebCore::FullScreenVideoWidget::closeEvent):
3505
3506 2011-03-10  David Boddie <david.boddie@nokia.com>
3507
3508         Reviewed by Andreas Kling.
3509
3510         Fixed a qdoc warning and terminology (WebKit instead of Webkit).
3511         https://bugs.webkit.org/show_bug.cgi?id=55756
3512
3513         * Api/qwebhistoryinterface.cpp:
3514
3515 2011-03-10  Andreas Kling  <kling@webkit.org>
3516
3517         Unreviewed build fix after r80774.
3518
3519         QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
3520         See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451
3521
3522         * declarative/plugin.cpp:
3523         (WebKitQmlPlugin::registerTypes):
3524         * declarative/qdeclarativewebview.cpp:
3525         * declarative/qdeclarativewebview_p.h:
3526         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
3527
3528 2011-03-10  Alexis Menard  <alexis.menard@openbossa.org>
3529
3530         Reviewed by Andreas Kling.
3531
3532         [Qt] QtDeclarative Webview element has a fixed white background
3533         https://bugs.webkit.org/show_bug.cgi?id=40918
3534
3535         Implement a way to change the background color of the WebView QML element.
3536         This feature is activated for QtWebKit 1.1 version of the plugin.
3537
3538         * declarative/plugin.cpp:
3539         (WebKitQmlPlugin::registerTypes):
3540         * declarative/qdeclarativewebview.cpp:
3541         (QDeclarativeWebView::backgroundColor):
3542         (QDeclarativeWebView::setBackgroundColor):
3543         * declarative/qdeclarativewebview_p.h:
3544         * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
3545         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
3546         (tst_QDeclarativeWebView::backgroundColor):
3547         * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
3548
3549 2011-03-10  Stanislav Paltis  <Stanislav.Paltis@nokia.com>
3550
3551         Reviewed by Laszlo Gombos.
3552
3553         [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
3554         https://bugs.webkit.org/show_bug.cgi?id=55945
3555         
3556         Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to 
3557         set interval used to trigger when decoded data in dead list of object cache will 
3558         be purged from object cache. 
3559
3560         * Api/qwebpage.cpp:
3561         (QWebPagePrivate::dynamicPropertyChangeEvent):