c22446b422e0fc317455106e335c5d0179f82e1c
[WebKit-https.git] / Source / WebKit / qt / ChangeLog
1 2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>
2
3         Reviewed by Andreas Kling.
4
5         [Qt] Implement fullscreen playback for the GStreamer backend.
6         https://bugs.webkit.org/show_bug.cgi?id=56826
7
8         Implement support for fullscreen playback when building the
9         Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
10         The implementation is done in FullScreenVideoQt alongside with
11         the Qt Multimedia support.
12
13         No new tests because layout tests cover it. They are not yet activated
14         but will be any time soon.
15
16         * QtWebKit.pro:
17         * WebCoreSupport/ChromeClientQt.cpp:
18         (WebCore::ChromeClientQt::ChromeClientQt):
19         (WebCore::ChromeClientQt::~ChromeClientQt):
20         (WebCore::ChromeClientQt::enterFullscreenForNode):
21         (WebCore::ChromeClientQt::exitFullscreenForNode):
22         * WebCoreSupport/ChromeClientQt.h:
23         * WebCoreSupport/FullScreenVideoQt.cpp:
24         (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
25         (WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
26         (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
27         (WebCore::GStreamerFullScreenVideoHandler::windowClosed):
28         (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
29         (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
30         (WebCore::FullScreenVideoQt::FullScreenVideoQt):
31         (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
32         (WebCore::FullScreenVideoQt::enterFullScreenForNode):
33         (WebCore::FullScreenVideoQt::exitFullScreenForNode):
34         (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
35         (WebCore::FullScreenVideoQt::isValid):
36         * WebCoreSupport/FullScreenVideoQt.h:
37         (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):
38
39 2011-04-06  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
40
41         Reviewed by Kenneth Rohde Christiansen.
42
43         [Qt] Improve tests for QWebFrame::url() and related methods
44         https://bugs.webkit.org/show_bug.cgi?id=57865
45
46         * tests/qwebframe/tst_qwebframe.cpp:
47         (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
48         (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
49         that fails and a load() that fails (for a different URL).
50
51         (tst_QWebFrame::setUrlWithFragment_data):
52         (tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
53         the URL in the frame before the test starts.
54
55         (tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
56         the same URL as argument.
57
58         (extractBaseUrl):
59         (tst_QWebFrame::setUrlThenLoads_data):
60         (tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
61         sequence of set and loads. Those tests are interesting because the properties
62         react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
63         is used or after the load() is committed and baseUrl() is similar to url() but also depends
64         on the contents of the page when it loads.
65
66 2011-04-04  MORITA Hajime  <morrita@google.com>
67
68         Reviewed by Ryosuke Niwa.
69
70         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
71         https://bugs.webkit.org/show_bug.cgi?id=56085
72         
73         * WebCoreSupport/EditorClientQt.h:
74         (WebCore::EditorClientQt::requestCheckingOfString):
75
76 2011-04-04  Chang Shu  <cshu@webkit.org>
77
78         Reviewed by Ryosuke Niwa.
79
80         setContentEditable with true/false/inherit string is not working properly
81         https://bugs.webkit.org/show_bug.cgi?id=52058
82
83         Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
84         as rendererIsEditable is for WebCore internal use.
85
86         * WebCoreSupport/EditorClientQt.cpp:
87         (WebCore::EditorClientQt::handleKeyboardEvent):
88
89 2011-04-01  Carol Szabo  <carol.szabo@nokia.com>
90
91         Reviewed by Benjamin Poulain.
92
93         Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
94         Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.
95
96         Tiled painting still causes synchronous layout when
97         accelerated compositing and texture mapper are enabled
98         https://bugs.webkit.org/show_bug.cgi?id=56929
99
100         * Api/qwebframe.cpp:
101         (QWebFramePrivate::renderFromTiledBackingStore):
102         (QWebFramePrivate::renderRelativeCoords):
103         (QWebFramePrivate::renderFrameWidgets):
104         * Api/qwebframe_p.h:
105
106 2011-04-01  Nancy Piedra  <nancy.piedra@nokia.com>
107
108         Reviewed by Benjamin Poulain.
109
110         [Qt] DragClientQt.h has coding-style errors
111         https://bugs.webkit.org/show_bug.cgi?id=40425
112
113         * WebCoreSupport/DragClientQt.h:
114
115 2011-03-31  Marius Storm-Olsen  <marius.storm-olsen@nokia.com>
116
117         Reviewed by Kenneth Rohde Christiansen.
118
119         [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
120         https://bugs.webkit.org/show_bug.cgi?id=57017
121
122         Build fix. No new tests.
123
124         * QtWebKit.pro:
125
126 2011-03-31  Evan Martin  <evan@chromium.org>
127
128         Another build fix.
129
130         * WebCoreSupport/FrameLoaderClientQt.cpp:
131         (WebCore::FrameLoaderClientQt::updateGlobalHistory):
132
133 2011-03-31  Nancy Piedra  <nancy.piedra@nokia.com>
134
135         Reviewed by Benjamin Poulain.
136
137         [Qt] ChromeClientQt.h has coding-style errors
138         https://bugs.webkit.org/show_bug.cgi?id=40239
139
140         * WebCoreSupport/ChromeClientQt.h:
141         (WebCore::ChromeClientQt::scrollbarsModeDidChange):
142         (WebCore::ChromeClientQt::needTouchEvents):
143         (WebCore::ChromeClientQt::formStateDidChange):
144         (WebCore::ChromeClientQt::scrollRectIntoView):
145         (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
146         (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
147
148 2011-03-31  Evan Martin  <evan@chromium.org>
149
150         Build fix from previous change.
151
152         * Api/qwebframe.cpp:
153         (QWebFrame::title):
154
155 2011-03-31  Evan Martin  <evan@chromium.org>
156
157         Reviewed by Eric Seidel.
158
159         <title> should support dir attribute
160         https://bugs.webkit.org/show_bug.cgi?id=50961
161
162         Update to new FrameLoaderClient interface.
163
164         * WebCoreSupport/FrameLoaderClientQt.cpp:
165         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
166         (WebCore::FrameLoaderClientQt::setTitle):
167         * WebCoreSupport/FrameLoaderClientQt.h:
168
169 2011-03-30  Yi Shen  <yi.4.shen@nokia.com>
170
171         Reviewed by Kenneth Rohde Christiansen.
172
173         [Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
174         https://bugs.webkit.org/show_bug.cgi?id=57020
175
176         Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().
177
178         * tests/qwebview/tst_qwebview.cpp:
179         (tst_QWebView::focusInputTypes):
180
181 2011-03-30  Robert Hogan  <robert@webkit.org>
182
183         Reviewed by Antonio Gomes.
184
185         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
186
187         Add DRT support for loading an alternate HTML string
188         for error pages. This allows Qt to unskip
189         http/tests/navigation/go-back-to-error-page.html.
190
191         https://bugs.webkit.org/show_bug.cgi?id=52614
192
193         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
194         (DumpRenderTreeSupportQt::setAlternateHtml):
195         * WebCoreSupport/DumpRenderTreeSupportQt.h:
196
197 2011-03-29  Alexis Menard  <alexis.menard@openbossa.org>
198
199         Unreviewed build fix for build-webkit -minimal.
200
201         Breakage introduced by http://trac.webkit.org/changeset/82238.
202         The minimal option has no support for shortcuts.
203
204         * WebCoreSupport/EditorClientQt.cpp:
205         (WebCore::EditorClientQt::handleInputMethodKeydown):
206
207 2011-03-29  Janne Koskinen  <janne.p.koskinen@digia.com>
208
209         Reviewed by Kenneth Rohde Christiansen.
210
211         [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
212         https://bugs.webkit.org/show_bug.cgi?id=33179
213
214         Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.
215
216         * WebCoreSupport/EditorClientQt.cpp:
217         (WebCore::EditorClientQt::handleInputMethodKeydown):
218         * tests/qwebpage/tst_qwebpage.cpp:
219         (tst_QWebPage::inputMethods):
220
221 2011-03-29  Andreas Kling  <kling@webkit.org>
222
223         Reviewed by Simon Hausmann.
224
225         [Qt] Fix documentation for QWebPage::repaintRequested()
226
227         This signal is always emitted when the page is dirtied, so remove
228         reference to old behavior where we would only emit the signal for
229         headless QWebPages.
230
231         * Api/qwebpage.cpp:
232
233 2011-03-28  Andreas Kling  <kling@webkit.org>
234
235         Reviewed by Benjamin Poulain.
236
237         [Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.
238
239         * WebCoreSupport/FrameLoaderClientQt.cpp:
240         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
241
242 2011-03-28  Andreas Kling  <kling@webkit.org>
243
244         Reviewed by Benjamin Poulain.
245
246         [Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
247         https://bugs.webkit.org/show_bug.cgi?id=52629
248
249         * WebCoreSupport/ChromeClientQt.cpp:
250         (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
251         QWebPage::repaintRequested() use a Qt::QueuedConnection.
252
253         * tests/qwebpage/tst_qwebpage.cpp:
254         (RepaintRequestedRenderer::RepaintRequestedRenderer):
255         (RepaintRequestedRenderer::onRepaintRequested):
256         (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
257         QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
258         doesn't cause recursive signal emissions.
259
260 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
261
262         Reviewed by Andreas Kling.
263
264         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
265         https://bugs.webkit.org/show_bug.cgi?id=57087
266
267         * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
268         * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
269         since they are applications, not libraries.
270
271 2011-03-28  Andras Becsi  <abecsi@webkit.org>
272
273         Reviewed by Csaba Osztrogonác.
274
275         [Qt] QtWebKit does not link with --3d-canvas using MinGW
276         https://bugs.webkit.org/show_bug.cgi?id=57225
277
278         * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
279
280 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
281
282         Reviewed by Andreas Kling.
283
284         REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
285         https://bugs.webkit.org/show_bug.cgi?id=57183
286
287         Windows buildfix after r82065.
288
289         * Api/DerivedSources.pro: Readding escaping on Windows platforms.
290
291 2011-03-27  Andreas Kling  <kling@webkit.org>
292
293         Fix build warning about IconDatabaseClient.h (wrong path.)
294
295         * QtWebKit.pro:
296
297 2011-03-27  Andreas Kling  <kling@webkit.org>
298
299         Reviewed by Kenneth Rohde Christiansen.
300
301         [Qt] Support for CSS color and background-color properties on select element's dropdown list
302         https://bugs.webkit.org/show_bug.cgi?id=51627
303
304         Extend the QWebSelectData interface with background and foreground colors
305         for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
306         getters in RenderMenuList.
307
308         * Api/qwebkitplatformplugin.h:
309         * WebCoreSupport/PopupMenuQt.cpp:
310         (SelectData::backgroundColor):
311         (SelectData::foregroundColor):
312         (SelectData::itemBackgroundColor):
313         (SelectData::itemForegroundColor):
314         * WebCoreSupport/QtFallbackWebPopup.cpp:
315         (WebCore::QtFallbackWebPopup::show):
316         (WebCore::QtFallbackWebPopup::populate):
317
318 2011-03-27  Yi Shen  <yi.4.shen@nokia.com>
319
320         Reviewed by Andreas Kling.
321
322         [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
323         https://bugs.webkit.org/show_bug.cgi?id=57108
324
325         Since the canvas is not self-closing tag, we need to add '</canvas>'. 
326
327         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
328         (tst_QGraphicsWebView::microFocusCoordinates):
329         * tests/qwebview/tst_qwebview.cpp:
330         (tst_QWebView::microFocusCoordinates):
331
332 2011-03-27  Kwang Yul Seo  <skyul@company100.net>
333
334         Reviewed by Eric Seidel.
335
336         [Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
337         https://bugs.webkit.org/show_bug.cgi?id=57143
338
339         Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
340         define WTF_USE_TEXTURE_MAPPER=1.
341
342         * QtWebKit.pro:
343
344 2011-03-27  Andreas Kling  <kling@webkit.org>
345
346         Reviewed by Benjamin Poulain.
347
348         REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
349         https://bugs.webkit.org/show_bug.cgi?id=57183
350
351         The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
352         which was due to the outputting code previously being wrapped in eval().
353
354         * Api/DerivedSources.pro:
355
356 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
357
358         Reviewed by Andreas Kling.
359
360         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
361         https://bugs.webkit.org/show_bug.cgi?id=57087
362
363         Use explicit conversion for string to avoid depending on the default codec
364         installed by the user code.
365
366         * Api/qwebkitversion.cpp:
367         (qWebKitVersion):
368         * Api/qwebpage.cpp:
369         (QWebPagePrivate::dynamicPropertyChangeEvent):
370         (QWebPage::javaScriptConsoleMessage):
371         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
372         (convertToPropertyName):
373         (DumpRenderTreeSupportQt::setEditingBehavior):
374         (DumpRenderTreeSupportQt::plainText):
375         * WebCoreSupport/EditorClientQt.cpp:
376         (dumpRange):
377         * WebCoreSupport/FrameLoaderClientQt.cpp:
378         (drtDescriptionSuitableForTestResult):
379         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
380         * WebCoreSupport/InspectorClientQt.cpp:
381         (WebCore::InspectorClientQt::openInspectorFrontend):
382         * WebCoreSupport/InspectorServerQt.cpp:
383         (WebCore::parseWebSocketChallengeNumber):
384         (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
385
386 2011-03-26  Andreas Kling  <kling@webkit.org>
387
388         Reviewed by Kenneth Rohde Christiansen.
389
390         [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
391         https://bugs.webkit.org/show_bug.cgi?id=57157
392
393         Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
394         is always emitted when appropriate.
395
396         * QtWebKit.pro: Add new files.
397
398         * WebCoreSupport/IconDatabaseClientQt.h: Added.
399         * WebCoreSupport/IconDatabaseClientQt.cpp: Added.
400         (WebCore::IconDatabaseClientQt::instance):
401         (WebCore::IconDatabaseClientQt::IconDatabaseClientQt):
402         (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt):
403         (WebCore::IconDatabaseClientQt::performImport):
404         (WebCore::IconDatabaseClientQt::didRemoveAllIcons):
405         (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL):
406         (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL):
407         (WebCore::IconDatabaseClientQt::didChangeIconForPageURL):
408         (WebCore::IconDatabaseClientQt::didFinishURLImport):
409
410         * WebCoreSupport/FrameLoaderClientQt.h:
411         * WebCoreSupport/FrameLoaderClientQt.cpp:
412         (WebCore::FrameLoaderClientQt::registerForIconNotification):
413         (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected
414         to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the
415         QWebFrame::iconChanged() signal when the IconDatabases finishes loading
416         a cached favicon for the frame's URL.
417
418         * Api/qwebsettings.cpp:
419         (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is
420         instantiated. An IconDatabaseClient has to be registered before the IconDatabase
421         spawns its reader thread.
422
423 2011-03-25  Andy Estes  <aestes@apple.com>
424
425         Reviewed by Adele Peterson.
426
427         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
428         https://bugs.webkit.org/show_bug.cgi?id=49016
429
430         Update objectContentType() implementation to handle the
431         shouldPreferPlugInsForImages flag.
432
433         * WebCoreSupport/FrameLoaderClientQt.cpp:
434         (WebCore::FrameLoaderClientQt::objectContentType):
435         * WebCoreSupport/FrameLoaderClientQt.h:
436
437 2011-03-25  Chang Shu  <cshu@webkit.org>
438
439         Reviewed by Ryosuke Niwa.
440
441         rename Node::isContentEditable and all call sites to rendererIsEditable
442         https://bugs.webkit.org/show_bug.cgi?id=54290
443
444         This is part of the effort to separate JS API HTMLElement isContentEditable from
445         internal Node::rendererIsEditable.
446
447         * WebCoreSupport/EditorClientQt.cpp:
448         (WebCore::EditorClientQt::handleKeyboardEvent):
449
450 2011-03-25  Alexis Menard  <alexis.menard@openbossa.org>
451
452         Reviewed by Andreas Kling.
453
454         [Qt] The keyboard shortcuts during fullscreen playback do not work.
455         https://bugs.webkit.org/show_bug.cgi?id=57095
456
457         We need to explicitely set the focus on the widget in order to receive the keyboard events.
458
459         * WebCoreSupport/FullScreenVideoWidget.cpp:
460         (WebCore::FullScreenVideoWidget::show):
461
462 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
463
464         Unreviewed, rolling out r81916 and r81917.
465         http://trac.webkit.org/changeset/81916
466         http://trac.webkit.org/changeset/81917
467         https://bugs.webkit.org/show_bug.cgi?id=57071
468
469         broke a test on platforms that do not have QuickTime installed
470         (Requested by estes on #webkit).
471
472         * WebCoreSupport/FrameLoaderClientQt.cpp:
473         (WebCore::FrameLoaderClientQt::objectContentType):
474         * WebCoreSupport/FrameLoaderClientQt.h:
475
476 2011-03-24  Andy Estes  <aestes@apple.com>
477
478         Reviewed by Darin Adler.
479
480         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
481         https://bugs.webkit.org/show_bug.cgi?id=49016
482
483         Update objectContentType() implementation to handle the
484         shouldPreferPlugInsForImages flag.
485
486         * WebCoreSupport/FrameLoaderClientQt.cpp:
487         (WebCore::FrameLoaderClientQt::objectContentType):
488         * WebCoreSupport/FrameLoaderClientQt.h:
489
490 2011-03-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
491
492         Reviewed by Kenneth Rohde Christiansen.
493
494         [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
495         https://bugs.webkit.org/show_bug.cgi?id=40884
496
497         Add tests and benchmarks for the software fallback of WebGL.
498
499         * tests/benchmarks/webgl/10000_triangles.html: Added.
500         * tests/benchmarks/webgl/tst_webgl.cpp: Added.
501         (GraphicsView::GraphicsView):
502         (GraphicsView::resizeEvent):
503         (tst_WebGlPerformance::init):
504         (tst_WebGlPerformance::cleanup):
505         (tst_WebGlPerformance::benchSoftwareFallbackRgb16):
506         (tst_WebGlPerformance::benchSoftwareFallbackRgb32):
507         (tst_WebGlPerformance::benchSoftwareFallbackArgb32):
508         (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
509         (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
510         * tests/benchmarks/webgl/tst_webgl.qrc: Added.
511         * tests/benchmarks/webgl/webgl.pro: Added.
512         * tests/qgraphicswebview/qgraphicswebview.pro:
513         * tests/qgraphicswebview/resources/pointing_right.html: Added.
514         * tests/qgraphicswebview/resources/pointing_up.html: Added.
515         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
516         (compareImagesFuzzyPixelCount):
517         (GraphicsView::GraphicsView):
518         (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
519         (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
520         (tst_QGraphicsWebView::compareCanvasToImage):
521         * tests/qgraphicswebview/tst_qgraphicswebview.qrc:
522         * tests/tests.pro:
523
524 2011-03-24  Kristian Amlie  <kristian.amlie@nokia.com>
525
526         Reviewed by Benjamin Poulain.
527
528         Avoided ASCII-cast warnings for WebKit.
529
530         Normally they won't be enabled anyway, but if you build webkit from
531         within the Qt mother repository it will pick up Qt's default build
532         settings, which do enable it. We need to disable them because
533         warnings are treated as errors and there are way too many of them in
534         the WebKit code.
535
536         [Qt] Avoid ASCII-cast warnings for WebKit.
537         https://bugs.webkit.org/show_bug.cgi?id=57016
538
539         * QtWebKit.pro:
540
541 2011-03-24  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
542
543         Reviewed by Benjamin Poulain.
544
545         [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
546         https://bugs.webkit.org/show_bug.cgi?id=29595
547
548         Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
549         ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
550         prepending the current directory.
551
552         By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
553         will end up loading "about:blank", but keeping it as a requested URL.
554
555         This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
556         is filled for the loaded URLs as well, we can use it in every case.
557
558         Three new autotests were added, to better cover the expected behavior of setting
559         the QUrl() in a QWebFrame.
560
561         * Api/qwebframe.cpp:
562         (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
563         (QWebFrame::requestedUrl): always use m_lastRequestedUrl.
564
565         * WebCoreSupport/FrameLoaderClientQt.cpp:
566         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
567         anymore, since we always rely on it even for loaded frames.
568
569         * tests/qwebframe/tst_qwebframe.cpp:
570         (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
571         the reduction of the bug report.
572         (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
573         (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
574
575 2011-03-23  Brady Eidson  <beidson@apple.com>
576
577         Reviewed by Sam Weinig.
578
579         Change IconDatabase opening to allow for arbitrary filenames
580         https://bugs.webkit.org/show_bug.cgi?id=56977
581
582         * Api/qwebsettings.cpp:
583         (QWebSettings::setIconDatabasePath):
584
585 2011-03-23  Aparna Nandyal  <aparna.nand@wipro.com>
586
587         Reviewed by Andreas Kling.
588
589         [Qt] QtWebKit rendering problem when maximizing and doing a back
590         https://bugs.webkit.org/show_bug.cgi?id=56669
591
592         Added an auto test.
593         Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21
594  
595         * tests/qwebview/tst_qwebview.cpp:
596         (tst_QWebView::rendering):
597
598 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
599
600         Reviewed by Pavel Feldman.
601
602         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
603         https://bugs.webkit.org/show_bug.cgi?id=56843
604
605         * WebCoreSupport/InspectorClientQt.cpp:
606         (WebCore::InspectorClientQt::openInspectorFrontend):
607
608 2011-03-22  Andrew Wason  <rectalogic@rectalogic.com>
609
610         Reviewed by Benjamin Poulain.
611
612         [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
613         https://bugs.webkit.org/show_bug.cgi?id=54138
614
615         * tests/qwebpage/tst_qwebpage.cpp:
616         (webGLScreenshotWithoutView):
617         (tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
618         (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
619          Render a QWebPage (with and without accelerated compositing)
620          with a WebGL context that has no owning view.  Shouldn't crash.
621
622 2011-03-21  Chang Shu  <cshu@webkit.org>
623
624         Reviewed by Alexey Proskuryakov.
625
626         REGRESSION (r79953): Can't type in MS Outlook 2011
627         https://bugs.webkit.org/show_bug.cgi?id=56665
628
629         r79953 removed the WebView level editablity which is persistent no matter whether
630         underlying document itself is changed and editability gets lost. The resolution is to
631         set this WebView editable value to WebCore. This avoids the callback from WebCore to
632         WebKit which was the main goal in r79953 to improve performance.
633
634         * Api/qwebpage.cpp:
635         (QWebPage::setContentEditable):
636         (QWebPage::isContentEditable):
637
638 2011-03-19  Andreas Kling  <kling@webkit.org>
639
640         Reviewed by Benjamin Poulain.
641
642         [Qt] Remove support for Qt 4.6
643         https://bugs.webkit.org/show_bug.cgi?id=56712
644
645         * Api/qwebframe.cpp:
646         (QWebFrame::load):
647         * Api/qwebpage.cpp:
648         (QWebPagePrivate::QWebPagePrivate):
649         * Api/qwebsettings.cpp:
650         (QWebSettings::QWebSettings):
651         * WebCoreSupport/GeolocationClientQt.cpp:
652         (WebCore::GeolocationClientQt::positionUpdated):
653
654 2011-03-19  Andreas Kling  <kling@webkit.org>
655
656         Reviewed by Antonio Gomes.
657
658         [Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
659         https://bugs.webkit.org/show_bug.cgi?id=56711
660
661         Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
662         ownership of the reply is transferred to the receiving slot.
663
664         * Api/qwebpage.cpp:
665
666 2011-03-17  Brady Eidson  <beidson@apple.com>
667
668         Reviewed by Sam Weinig.
669
670         https://bugs.webkit.org/show_bug.cgi?id=56425
671         More groundwork for WebKit2 IconDatabase
672
673         Update already-used function names:
674         * Api/qwebhistory.cpp:
675         (QWebHistoryItem::icon):
676         * Api/qwebsettings.cpp:
677         (QWebSettings::iconForUrl):
678
679 2011-03-18  Alexis Menard  <alexis.menard@openbossa.org>
680
681         Reviewed by Benjamin Poulain.
682
683         [Qt] console.log not being exposed to QmlViewer
684         https://bugs.webkit.org/show_bug.cgi?id=56536
685
686         The documentation is bogus the feature does not exist.
687
688         * declarative/qdeclarativewebview.cpp:
689
690 2011-03-17  Andreas Kling  <kling@webkit.org>
691
692         Reviewed by Kenneth Rohde Christiansen.
693
694         [Qt] QML WebView emits iconChanged() when the page title changes
695         https://bugs.webkit.org/show_bug.cgi?id=56570
696
697         * declarative/qdeclarativewebview.cpp:
698         (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
699         signal to the view's iconChanged signal.
700
701 2011-03-17  Alexis Menard  <alexis.menard@openbossa.org>
702
703         Reviewed by Benjamin Poulain.
704
705         [Qt] Videos look ugly when using QGraphicsWebView.
706         https://bugs.webkit.org/show_bug.cgi?id=56580
707
708         We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
709         QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
710         by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
711         QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
712         ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
713         in addition of what could be set on the painter. In order to not break the rendering of all the items in the
714         scene we set back the painter to its original state when QGraphicsWebView is rendered.
715
716         * Api/qgraphicswebview.cpp:
717         (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
718         (QGraphicsWebView::paint):
719         (QGraphicsWebView::renderHints):
720         (QGraphicsWebView::setRenderHints):
721         (QGraphicsWebView::setRenderHint):
722         * Api/qgraphicswebview.h:
723         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
724         (tst_QGraphicsWebView::renderHints):
725
726 2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>
727
728         Reviewed by Kenneth Rohde Christiansen.
729
730         Viewport no longer allows an auto value for "user-scalable"
731         https://bugs.webkit.org/show_bug.cgi?id=55416
732
733         Make the default value for userScalable be true.
734
735         * Api/qwebpage.cpp:
736         (QWebPage::viewportAttributesForSize):
737         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
738         (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.
739
740 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
741
742         Reviewed by Darin Adler.
743
744         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
745         info into the headers rather than in export symbol definition files, but disable it on 
746         all platforms initially so we can deal with port build issues one port at a time.
747         
748         https://bugs.webkit.org/show_bug.cgi?id=27551
749
750         * WebCoreSupport/GeolocationClientQt.cpp:
751         * WebCoreSupport/PopupMenuQt.cpp:
752
753 2011-03-14  Brady Eidson  <beidson@apple.com>
754
755         Reviewed by Anders Carlsson.
756
757         https://bugs.webkit.org/show_bug.cgi?id=56320
758         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
759
760         * Api/qwebhistory.cpp:
761         (QWebHistoryItem::icon): Use IconDatabase directly.
762
763 2011-03-11  Brady Eidson  <beidson@apple.com>
764
765         Reviewed by attempt at build fix!
766
767         https://bugs.webkit.org/show_bug.cgi?id=56216
768         Fix the Qt build following the same pattern of the patch.
769
770         * Api/qwebsettings.cpp:
771         (QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
772
773 2011-03-11  Alexis Menard  <alexis.menard@openbossa.org>
774
775         Reviewed by Ariya Hidayat.
776
777         [Qt] Entering fullscreen and leaving it may hide the cursor of the application.
778         https://bugs.webkit.org/show_bug.cgi?id=56181
779
780         We need to stop the auto hide cursor timer when closing the widget otherwise the timer
781         might get fired and therefore hide the cursor even when the fullscreen widget is closed.
782
783         * WebCoreSupport/FullScreenVideoWidget.cpp:
784         (WebCore::FullScreenVideoWidget::closeEvent):
785
786 2011-03-10  David Boddie <david.boddie@nokia.com>
787
788         Reviewed by Andreas Kling.
789
790         Fixed a qdoc warning and terminology (WebKit instead of Webkit).
791         https://bugs.webkit.org/show_bug.cgi?id=55756
792
793         * Api/qwebhistoryinterface.cpp:
794
795 2011-03-10  Andreas Kling  <kling@webkit.org>
796
797         Unreviewed build fix after r80774.
798
799         QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
800         See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451
801
802         * declarative/plugin.cpp:
803         (WebKitQmlPlugin::registerTypes):
804         * declarative/qdeclarativewebview.cpp:
805         * declarative/qdeclarativewebview_p.h:
806         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
807
808 2011-03-10  Alexis Menard  <alexis.menard@openbossa.org>
809
810         Reviewed by Andreas Kling.
811
812         [Qt] QtDeclarative Webview element has a fixed white background
813         https://bugs.webkit.org/show_bug.cgi?id=40918
814
815         Implement a way to change the background color of the WebView QML element.
816         This feature is activated for QtWebKit 1.1 version of the plugin.
817
818         * declarative/plugin.cpp:
819         (WebKitQmlPlugin::registerTypes):
820         * declarative/qdeclarativewebview.cpp:
821         (QDeclarativeWebView::backgroundColor):
822         (QDeclarativeWebView::setBackgroundColor):
823         * declarative/qdeclarativewebview_p.h:
824         * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
825         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
826         (tst_QDeclarativeWebView::backgroundColor):
827         * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
828
829 2011-03-10  Stanislav Paltis  <Stanislav.Paltis@nokia.com>
830
831         Reviewed by Laszlo Gombos.
832
833         [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
834         https://bugs.webkit.org/show_bug.cgi?id=55945
835         
836         Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to 
837         set interval used to trigger when decoded data in dead list of object cache will 
838         be purged from object cache. 
839
840         * Api/qwebpage.cpp:
841         (QWebPagePrivate::dynamicPropertyChangeEvent):
842
843 2011-03-10  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
844
845         Reviewed by Antonio Gomes.
846
847         Simplify how QWebFrame::requestedUrl() is obtained
848         https://bugs.webkit.org/show_bug.cgi?id=55842
849
850         When a load starts, store the requested URL until we know that it'll be
851         available for us in the document loader -- after load finished.
852
853         The existing auto tests cover the three different code paths in
854         requestedUrl() and the new code passes the autotests. In each of those
855         cases, we looked for the information in a different place, but in all
856         of them, dispatchDidStartProvisionalLoad was called.
857
858         This simplification will be useful to fix bug 32723. The way requestedUrl()
859         is implementent, we can't use it as a fallback for url() when the setUrl()
860         was called with an invalid URL.
861
862         * Api/qwebframe.cpp:
863         (QWebFrame::requestedUrl):
864         * WebCoreSupport/FrameLoaderClientQt.cpp:
865         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
866         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
867         * WebCoreSupport/FrameLoaderClientQt.h:
868         (WebCore::FrameLoaderClientQt::lastRequestedUrl):
869
870 2011-03-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
871
872         Reviewed by Kenneth Rohde Christiansen.
873
874         Tiled backing store's delegated scroll request uses incorrect convention
875         https://bugs.webkit.org/show_bug.cgi?id=56011
876
877         Adapt internal API to match the change from delta to point on the
878         WebCore side, and convert the point to a delta for the public API.
879
880         * WebCoreSupport/ChromeClientQt.cpp:
881         (WebCore::ChromeClientQt::delegatedScrollRequested):
882         * WebCoreSupport/ChromeClientQt.h:
883
884 2011-03-09  Peter Kasting  <pkasting@google.com>
885
886         Reviewed by Mihai Parparita.
887
888         Unify Windows version checks.
889         https://bugs.webkit.org/show_bug.cgi?id=55979
890
891         * Api/qwebpage.cpp:
892         (QWebPage::userAgentForUrl):
893
894 2011-03-07  Sam Weinig  <sam@webkit.org>
895
896         Reviewed by Anders Carlsson.
897
898         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
899         https://bugs.webkit.org/show_bug.cgi?id=55827
900
901         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
902         and pass the entire response, instead of just the MIMEType.
903
904         * WebCoreSupport/FrameLoaderClientQt.cpp:
905         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
906         * WebCoreSupport/FrameLoaderClientQt.h:
907
908 2011-03-05  Qi Zhang  <qi.2.zhang@nokia.com>
909
910         Reviewed by Laszlo Gombos.
911
912         [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
913         https://bugs.webkit.org/show_bug.cgi?id=48636
914
915         Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
916
917         * Api/qwebpage.cpp:
918         (QWebPage::userAgentForUrl):
919
920 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
921
922         Reviewed by Kenneth Rohde Christiansen.
923
924         [QT] Implement mock client-based geolocation for layout testing
925         https://bugs.webkit.org/show_bug.cgi?id=54334
926
927         Implement layout testing for Client-Based geolocation. If drt_run is set 
928         then create mock geolocationClient and update the same with controller.
929
930         * Api/qwebpage.cpp:
931         (QWebPagePrivate::QWebPagePrivate):
932         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
933         (DumpRenderTreeSupportQt::mockGeolocationReset):
934         (DumpRenderTreeSupportQt::setMockGeolocationPermission):
935         (DumpRenderTreeSupportQt::setMockGeolocationPosition):
936         (DumpRenderTreeSupportQt::setMockGeolocationError):
937         * WebCoreSupport/DumpRenderTreeSupportQt.h:
938         * WebCoreSupport/GeolocationClientQt.cpp:
939         (WebCore::GeolocationClientQt::GeolocationClientQt):
940         * WebCoreSupport/GeolocationClientQt.h:
941
942 2011-03-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
943
944         Reviewed by Kenneth Rohde Christiansen.
945
946         [Qt] QWebFrame::setUrl works only from second time if url fragment is present
947         https://bugs.webkit.org/show_bug.cgi?id=32723
948
949         Create an auto-test for Qt based on the bug description.
950
951         * tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
952
953 2011-03-03  Brady Eidson  <beidson@apple.com>
954
955         Reviewed by Darin Adler.
956
957         https://bugs.webkit.org/show_bug.cgi?id=55721
958         Global IconDatabase should be returned by reference, not as a pointer
959
960         * Api/qwebsettings.cpp:
961         (QWebSettings::setIconDatabasePath):
962         (QWebSettings::iconDatabasePath):
963         (QWebSettings::clearIconDatabase):
964         (QWebSettings::iconForUrl):
965
966 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
967
968         Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
969         via ChromeClient.h
970
971         * WebCoreSupport/ChromeClientQt.h:
972
973 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
974
975         Reviewed by Darin Adler.
976
977         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
978         https://bugs.webkit.org/show_bug.cgi?id=55633
979         <rdar://problem/8963023>
980
981         * WebCoreSupport/ChromeClientQt.cpp (WebCore::ChromeClientQt::keyboardUIMode):
982         * WebCoreSupport/ChromeClientQt.h:
983         Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
984         this platform doesn't observe or have full keyboard access state.
985
986 2011-03-03  Alexis Menard  <alexis.menard@openbossa.org>
987
988         Reviewed by Andreas Kling.
989
990         [Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
991         https://bugs.webkit.org/show_bug.cgi?id=55568
992
993         We should use updateMicroFocus() from QGraphicsItem rather than the implementation
994         in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
995         In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
996         in QGraphicsItem.
997
998         * Api/qgraphicswebview.cpp:
999         (QGraphicsWebView::setPage):
1000         * Api/qgraphicswebview.h:
1001
1002 2011-03-03  Peter Kasting  <pkasting@google.com>
1003
1004         Reviewed by James Robinson.
1005
1006         Drop redundant "Windows; " from the Windows-specific User Agent string.
1007         https://bugs.webkit.org/show_bug.cgi?id=54567
1008
1009         * Api/qwebpage.cpp:
1010         (QWebPage::userAgentForUrl):
1011
1012 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
1013
1014         Reviewed by Adam Roben.
1015
1016         Part of WebKit2: Need a way to send notifications to client when cookies change
1017         https://bugs.webkit.org/show_bug.cgi?id=55427
1018         <rdar://problem/9056027>
1019         
1020         Add stubs for CookiesStrategy on Qt WebKit1.
1021
1022         * WebCoreSupport/WebPlatformStrategies.cpp:
1023         (WebPlatformStrategies::createCookiesStrategy):
1024         (WebPlatformStrategies::notifyCookiesChanged):
1025         * WebCoreSupport/WebPlatformStrategies.h:
1026
1027 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
1028
1029         Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
1030
1031         * Api/qwebpage.cpp:
1032         (QWebPage::viewportAttributesForSize):
1033         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1034         (DumpRenderTreeSupportQt::viewportAsText):
1035
1036 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
1037
1038         Reviewed by Kenneth Rohde Christiansen.
1039
1040         Viewport Warning/Error Messages Are Now Inaccurate
1041         https://bugs.webkit.org/show_bug.cgi?id=53707
1042
1043         * Api/qwebpage.cpp:
1044         (QWebPage::viewportAttributesForSize): pass a Document into computeViewportAttributes for warnings to be reported to.
1045         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1046         (DumpRenderTreeSupportQt::viewportAsText): pass a Document into computeViewportAttributes for warnings to be reported to.
1047
1048 2011-03-01  Andras Becsi  <abecsi@webkit.org>
1049
1050         Reviewed by Csaba Osztrogonác.
1051
1052         [Qt] Clean up the project files and move common options to WebKit.pri.
1053
1054         * QtWebKit.pro: Move common options to WebKit.pri.
1055
1056 2011-03-01  Aparna Nandyal  <aparna.nand@wipro.com>
1057
1058         Reviewed by Simon Hausmann.
1059
1060         [Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
1061         https://bugs.webkit.org/show_bug.cgi?id=55319
1062
1063         The test case required internet connection to be able to connect to
1064         google.com. Added new html file which refers to local html file.
1065
1066         * tests/qwebpage/resources/content.html: Added.
1067         * tests/qwebpage/resources/frame_c.html: Added.
1068         * tests/qwebpage/resources/framedindex.html: Added.
1069         * tests/qwebpage/tst_qwebpage.cpp:
1070         (tst_QWebPage::backActionUpdate):
1071         * tests/qwebpage/tst_qwebpage.qrc:
1072
1073 2011-02-25 Steve Block <steveblock@google.com>
1074
1075         Reviewed by Jeremy Orlow.
1076
1077         Bridge.h should not include BridgeJSC.h
1078         https://bugs.webkit.org/show_bug.cgi?id=55212
1079
1080         Include BridgeJSC.h directly instead.
1081
1082         * Api/qwebframe.cpp:
1083
1084 2011-02-28  Chang Shu  <cshu@webkit.org>
1085
1086         Reviewed by Ryosuke Niwa.
1087
1088         Remove the support of Frame::isContentEditable and its dependencies.
1089         https://bugs.webkit.org/show_bug.cgi?id=54292
1090
1091         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
1092
1093         * Api/qwebpage.cpp:
1094         (QWebPagePrivate::QWebPagePrivate):
1095         (QWebPage::setContentEditable):
1096         (QWebPage::isContentEditable):
1097         * Api/qwebpage_p.h:
1098         * WebCoreSupport/EditorClientQt.cpp:
1099         * WebCoreSupport/EditorClientQt.h:
1100
1101 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
1102
1103         Reviewed by Oliver Hunt.
1104
1105         Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
1106
1107         * Api/qwebelement.cpp:
1108         (QWebElement::evaluateJavaScript):
1109
1110 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
1111
1112         Reviewed by Andreas Kling.
1113
1114         [Qt]tst_QDeclarativeWebView - 8 test cases fail
1115         https://bugs.webkit.org/show_bug.cgi?id=55214
1116
1117         Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
1118         if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
1119         I also refactored the tests so we don't use the network but instead a local html file.
1120         QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.
1121
1122         * tests/qdeclarativewebview/resources/sample.html: Added.
1123         * tests/qdeclarativewebview/resources/webviewtest.qml:
1124         * tests/qdeclarativewebview/resources/webviewtestdefault.qml:
1125         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
1126         (tst_QDeclarativeWebView::preferredWidthTest):
1127         (tst_QDeclarativeWebView::preferredHeightTest):
1128         (tst_QDeclarativeWebView::preferredWidthDefaultTest):
1129         (tst_QDeclarativeWebView::preferredHeightDefaultTest):
1130         * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
1131
1132 2011-02-28  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1133
1134         Reviewed by Andreas Kling.
1135
1136         [Qt] Add clipped version of QWebElement::render method.
1137         Allows faster rendering of web element part.
1138         https://bugs.webkit.org/show_bug.cgi?id=50311
1139
1140         * Api/qwebelement.cpp:
1141         (QWebElement::render):
1142         * Api/qwebelement.h:
1143         * tests/qwebelement/tst_qwebelement.cpp:
1144         (tst_QWebElement::render):
1145
1146 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
1147
1148         Reviewed by Andreas Kling.
1149
1150         Added full webkit module profile and a syncqt profile.
1151
1152         This is for modularized Qt.
1153
1154         [Qt] WebKit patches required to work with a modularized version of Qt
1155         https://bugs.webkit.org/show_bug.cgi?id=53916
1156
1157         * qt_webkit_version.pri:
1158
1159 2011-02-27  Aparna Nandyal  <aparna.nand@wipro.com>
1160
1161         Reviewed by Antonio Gomes.
1162
1163         [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
1164         https://bugs.webkit.org/show_bug.cgi?id=53917
1165
1166         Adding test case to check the scenario to avoid regressions in the
1167         future. 
1168
1169         * tests/qwebframe/tst_qwebframe.cpp:
1170
1171 2011-02-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1172
1173         Reviewed by Andreas Kling.
1174
1175         [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
1176         https://bugs.webkit.org/show_bug.cgi?id=55322
1177
1178         Documentation update, add a reference to the QtWebKit bridge page.
1179
1180         * Api/qwebframe.cpp:
1181
1182 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
1183
1184         Reviewed by Pavel Feldman.
1185
1186         DumpRenderTree should reset frame opener between tests.
1187         https://bugs.webkit.org/show_bug.cgi?id=54874
1188
1189         Added clearOpener method to DumpRenderTreeSupportQT.
1190
1191         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1192         (DumpRenderTreeSupportQt::clearOpener):
1193         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1194
1195 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1196
1197         Reviewed by Andreas Kling.
1198
1199         Make it possible to test the targetdensity-dpi support
1200         https://bugs.webkit.org/show_bug.cgi?id=55142
1201
1202         Test the viewport meta tag feature targetdensity-dpi by
1203         adding extra arguments to dumpConfigurationForViewport
1204
1205         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1206         (DumpRenderTreeSupportQt::viewportAsText):
1207         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1208
1209 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1210
1211         Unreviewed, rolling out r79764.
1212         http://trac.webkit.org/changeset/79764
1213         https://bugs.webkit.org/show_bug.cgi?id=55295
1214
1215         "broke Chromium builds" (Requested by rniwa on #webkit).
1216
1217         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1218         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1219
1220 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
1221
1222         Reviewed by Pavel Feldman.
1223
1224         DumpRenderTree should reset frame opener between tests.
1225         https://bugs.webkit.org/show_bug.cgi?id=54874
1226
1227         Added clearOpener method to DumpRenderTreeSupportQT.
1228
1229         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1230         (DumpRenderTreeSupportQt::clearOpener):
1231         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1232
1233 2011-02-25  Andras Becsi  <abecsi@webkit.org>
1234
1235         Reviewed by Csaba Osztrogonác.
1236
1237         [Qt] Make the WebKit2 build system less confusing for non-Qt developers
1238         https://bugs.webkit.org/show_bug.cgi?id=55213
1239
1240         * QtWebKit.pro: Move the WebKit2 API into a project include file
1241         in the WebKit2 directory and include the pri file here.
1242
1243 2011-02-25  Alexis Menard  <alexis.menard@openbossa.org>
1244
1245         Unreviewed build fix for Intel ICC and MSVC.
1246
1247         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1248         (tst_QGraphicsWebView::setPalette):
1249         * tests/qwebview/tst_qwebview.cpp:
1250         (tst_QWebView::setPalette):
1251
1252 2011-02-25  Alexis Menard  <alexis.menard@openbossa.org>
1253
1254         Reviewed by Kenneth Rohde Christiansen.
1255
1256         [Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
1257         https://bugs.webkit.org/show_bug.cgi?id=31742
1258
1259         Discovered while looking at 31742. When we set a palette on the
1260         QGraphicsWebView we need to propagate it to the page like QWebView.
1261         I have added the same tests as QWebView to be sure to catch potential
1262         regressions as well as two extras QVERIFY to check the palette propagation.
1263
1264         * Api/qgraphicswebview.cpp:
1265         (QGraphicsWebView::event):
1266         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1267         (tst_QGraphicsWebView::setPalette_data):
1268         (tst_QGraphicsWebView::setPalette):
1269
1270 2011-02-25  Csaba Osztrogonác  <ossy@webkit.org>
1271
1272         Unreviewed buildfix after r79672.
1273
1274         [Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.
1275
1276         * tests/tests.pri:
1277         * tests/tests.pro:
1278
1279 2011-02-25  Gopal Raghavan  <gopal.1.raghavan@nokia.com>
1280
1281         Reviewed by Kenneth Rohde Christiansen.
1282
1283         [Qt] QML WebView inside a Flickable shows checkers pattern at startup
1284         https://bugs.webkit.org/show_bug.cgi?id=50222.
1285
1286         This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.
1287
1288         * declarative/qdeclarativewebview.cpp:
1289         (QDeclarativeWebView::init):
1290         * tests/qdeclarativewebview: Added.
1291         * tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
1292         * tests/qdeclarativewebview/resources: Added.
1293         * tests/qdeclarativewebview/resources/webviewtest.qml: Added.
1294         * tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
1295         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added.
1296         (tst_QDeclarativeWebView::initTestCase):
1297         (tst_QDeclarativeWebView::cleanupTestCase):
1298         (tst_QDeclarativeWebView::init):
1299         (tst_QDeclarativeWebView::cleanup):
1300         (tst_QDeclarativeWebView::preferredWidthTest):
1301         (tst_QDeclarativeWebView::preferredHeightTest):
1302         (tst_QDeclarativeWebView::preferredWidthDefaultTest):
1303         (tst_QDeclarativeWebView::preferredHeightDefaultTest):
1304         (tst_QDeclarativeWebView::checkNoErrors):
1305         * tests/tests.pri:
1306         * tests/tests.pro:
1307
1308 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1309
1310         Reviewed by Andreas Kling.
1311
1312         [Qt] Revert the support for QNAM affined to a different thread.
1313         https://bugs.webkit.org/show_bug.cgi?id=55149
1314
1315         Qt 4.8 will have QNAM use its own thread internally by default,
1316         no need to keep this complexity in WebKit.
1317
1318         This mainly reverts:
1319         http://trac.webkit.org/changeset/73710
1320         http://trac.webkit.org/changeset/73712
1321
1322         * WebCoreSupport/FrameLoaderClientQt.cpp:
1323         (WebCore::FrameLoaderClientQt::download):
1324         * tests/qwebpage/tst_qwebpage.cpp:
1325
1326 2011-02-24  Sam Weinig  <sam@webkit.org>
1327
1328         Try to fix the Qt build.
1329
1330         * QtWebKit.pro:
1331
1332 2011-02-24  Peter Kasting  <pkasting@google.com>
1333
1334         Reviewed by Eric Seidel.
1335
1336         Drop the "U; " encryption level from the User Agent string.
1337         https://bugs.webkit.org/show_bug.cgi?id=54566
1338
1339         * Api/qwebpage.cpp:
1340         (QWebPage::userAgentForUrl):
1341
1342 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
1343
1344         Unreviewed, rolling out r79570.
1345         http://trac.webkit.org/changeset/79570
1346         https://bugs.webkit.org/show_bug.cgi?id=54874
1347
1348         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
1349         was not updated
1350
1351         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1352         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1353
1354 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
1355
1356         Reviewed by Alexey Proskuryakov.
1357
1358         DumpRenderTree should reset frame opener between tests.
1359         https://bugs.webkit.org/show_bug.cgi?id=54874
1360
1361         Added clearOpener method to DumpRenderTreeSupportQT.
1362
1363         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1364         (DumpRenderTreeSupportQt::clearOpener):
1365         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1366
1367 2011-02-24  Alexis Menard  <alexis.menard@openbossa.org>
1368
1369         Reviewed by Andreas Kling.
1370
1371         [Qt] tst_QWebView::setPalette(activeFG) fails
1372         https://bugs.webkit.org/show_bug.cgi?id=55029
1373
1374         This time it should be the proper fix. The window needs to be shown before we
1375         call activateWindow() otherwise there is no active windows for the application.
1376
1377         * tests/qwebview/tst_qwebview.cpp:
1378         (tst_QWebView::setPalette):
1379
1380 2011-02-24  Andras Becsi  <abecsi@webkit.org>
1381
1382         Reviewed by Laszlo Gombos.
1383
1384         [Qt] MinGW build fails to link
1385         https://bugs.webkit.org/show_bug.cgi?id=55050
1386
1387         Prepend the libraries of subcomponents instead of appending them
1388         to fix the library order according to the dependency of the libraries
1389
1390         * QtWebKit.pro: prepend libraries in the correct order
1391
1392 2011-02-23  Alexis Menard  <alexis.menard@openbossa.org>
1393
1394         Reviewed by Ariya Hidayat.
1395
1396         [Qt] tst_QWebView::setPalette(activeFG) fails
1397         https://bugs.webkit.org/show_bug.cgi?id=55029
1398
1399         Attempt to make the test more robust. By investigating with the bot virtual machine
1400         I discovered that the activation can take some time. In this patch we make sure that
1401         the active window we want to have is the same as the QApplication.
1402
1403         * tests/qwebview/tst_qwebview.cpp:
1404         (tst_QWebView::setPalette):
1405
1406 2011-02-23  Alexis Menard  <alexis.menard@openbossa.org>
1407
1408         Reviewed by Dan Bernstein.
1409
1410         [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
1411         http://trac.webkit.org/changeset/79167 refactored the way the bound size of
1412         the frame is handled. A new API setBoundsSize was added, we need to call it
1413         in addition to setFrameRect. I could call setBoundSize after setFrameRect but
1414         I thought It would be more elegant to use the resize method.
1415
1416         * Api/qwebpage.cpp:
1417         (QWebPage::setViewportSize):
1418
1419 2011-02-22  Fabrizio Machado  <fabrizio.machado@nokia.com>
1420
1421         Reviewed by Laszlo Gombos.
1422
1423         [Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
1424         https://bugs.webkit.org/show_bug.cgi?id=54976
1425
1426         Test not needed.
1427         
1428         * WebCoreSupport/InspectorClientQt.cpp:
1429
1430 2011-02-22  Alexis Menard  <alexis.menard@openbossa.org>
1431
1432         Reviewed by Andreas Kling.
1433
1434         [Qt] QWebView ignores a palette set with QWebView::setPalette()
1435         https://bugs.webkit.org/show_bug.cgi?id=31742
1436
1437         Test case to check that the palette sets on the QWebView is taken
1438         into account.
1439
1440         * tests/qwebview/tst_qwebview.cpp:
1441         (tst_QWebView::setPalette_data):
1442         (tst_QWebView::setPalette):
1443
1444 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1445
1446         Reviewed by Alexey Proskuryakov.
1447
1448         Drop the language tag part from the User Agent string
1449         https://bugs.webkit.org/show_bug.cgi?id=54560
1450
1451         * Api/qwebpage.cpp:
1452         (QWebPage::userAgentForUrl):
1453
1454         * tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange
1455         test.
1456
1457 2011-02-22  Chang Shu  <cshu@webkit.org>
1458
1459         Reviewed by Csaba Osztrogonác.
1460
1461         [Qt] editing/deleting/5408255.html fails
1462         https://bugs.webkit.org/show_bug.cgi?id=54964
1463
1464         Move WebCore resource file to QtWebKit since they are referred in WebKit.
1465
1466         * QtWebKit.pro:
1467
1468 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1469
1470         Reviewed by Csaba Osztrogonác.
1471
1472         [Qt] Redesign the build system
1473         https://bugs.webkit.org/show_bug.cgi?id=51339
1474
1475         Move inspector's resource files into the final build step to fix the layout test regression.
1476
1477         * QtWebKit.pro: Add inspector's reaource files.
1478
1479 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1480
1481         Reviewed by Laszlo Gombos.
1482         Rubber-stamped by Csaba Osztrogonác.
1483
1484         [Qt] Redesign the build system
1485         https://bugs.webkit.org/show_bug.cgi?id=51339
1486
1487         The patch landed in r79320 didn't contain the cleanup
1488         which was already addressed in the last attachment.
1489
1490         * QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
1491
1492 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1493
1494         Reviewed by Laszlo Gombos.
1495
1496         [Qt] Redesign the build system
1497         https://bugs.webkit.org/show_bug.cgi?id=51339
1498
1499         Part 2.
1500
1501         Build WebCore as a static library, compile the WebKit API and WebKit2 API
1502         in a final step and link to WebKit2, WebCore and JSC libraries to fix
1503         linking issues resulting from stripped away symbols.
1504
1505         * QtWebKit.pro: Added.
1506         Project file for the final build step.
1507
1508 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
1509
1510         Reviewed by Kent Tamura.
1511
1512         Rename Position::node() to Position::deprecatedNode()
1513         https://bugs.webkit.org/show_bug.cgi?id=54622
1514
1515         Replaced the call to node() by a call to containerNode() because the returned node is
1516         used to determine whether or not the selected contents are editable and such a check
1517         must be done against the container node.
1518
1519         * WebCoreSupport/EditorClientQt.cpp:
1520         (WebCore::EditorClientQt::handleKeyboardEvent):
1521
1522 2011-02-19  Charlie Reis  <creis@chromium.org>
1523
1524         Reviewed by Mihai Parparita.
1525
1526         Ensure loading has stopped in HistoryController::goToItem
1527         https://bugs.webkit.org/show_bug.cgi?id=54517
1528
1529         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
1530
1531         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
1532
1533         * WebCoreSupport/FrameLoaderClientQt.cpp:
1534         (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
1535         * WebCoreSupport/FrameLoaderClientQt.h:
1536
1537 2011-02-18  Fabrizio Machado  <fabrizio.machado@nokia.com>
1538
1539         Reviewed by Eric Seidel.
1540
1541         Remove reduntant checks.
1542         https://bugs.webkit.org/show_bug.cgi?id=54764
1543         
1544
1545         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1546         (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
1547         * WebCoreSupport/NotificationPresenterClientQt.cpp:
1548         (WebCore::NotificationPresenterClientQt::toPage):
1549
1550 2011-02-18  Csaba Osztrogonác  <ossy@webkit.org>
1551
1552         Unreviewed.
1553
1554         [Qt] Buildfix for platforms with geolocation disabled.
1555
1556         * Api/qwebpage.cpp: Add the missing guard.
1557
1558 2011-02-18  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1559
1560         Reviewed by Kenneth Rohde Christiansen.
1561
1562         [Qt] Implement client based geolocation for qtport
1563         https://bugs.webkit.org/show_bug.cgi?id=42629
1564
1565         Implements client based geolocation for qtwebkit.
1566         New client based geolocation contains permission API's as well,
1567         so removed the implementation from ChromeClientQt.cpp. 
1568
1569         * Api/qwebpage.cpp:
1570         (QWebPagePrivate::QWebPagePrivate):
1571         * WebCoreSupport/ChromeClientQt.cpp:
1572         * WebCoreSupport/ChromeClientQt.h:
1573         (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
1574         (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
1575         * WebCoreSupport/GeolocationClientQt.cpp: Added.
1576         (WebCore::GeolocationClientQt::GeolocationClientQt):
1577         (WebCore::GeolocationClientQt::~GeolocationClientQt):
1578         (WebCore::GeolocationClientQt::geolocationDestroyed):
1579         (WebCore::GeolocationClientQt::positionUpdated):
1580         (WebCore::GeolocationClientQt::startUpdating):
1581         (WebCore::GeolocationClientQt::stopUpdating):
1582         (WebCore::GeolocationClientQt::setEnableHighAccuracy):
1583         (WebCore::GeolocationClientQt::requestPermission):
1584         (WebCore::GeolocationClientQt::cancelPermissionRequest):
1585         * WebCoreSupport/GeolocationClientQt.h: Added.
1586         (WebCore::GeolocationClientQt::lastPosition):
1587
1588 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
1589
1590         Reviewed by Adam Roben.
1591
1592         HTML5 <details> and <summary>: localized text
1593         https://bugs.webkit.org/show_bug.cgi?id=54260
1594
1595         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
1596         provide the default label to be used by a <details> tag that has no <summary> child.
1597
1598         * WebCoreSupport/WebPlatformStrategies.cpp:
1599         (WebPlatformStrategies::defaultDetailsSummaryText):
1600         * WebCoreSupport/WebPlatformStrategies.h:
1601
1602 2011-02-17  Hui Huang  <hui.2.huang@nokia.com>
1603
1604         Reviewed by Laszlo Gombos.
1605
1606         The URL of HTML5 Video Element is percent encoded at websites such as youtube.
1607         It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
1608         the HTTP GET request for the video to be rejected by the service provider. 
1609         https://bugs.webkit.org/show_bug.cgi?id=53973.
1610
1611         The bug is fixed by constructing QUrl from the encoded URL in 
1612         MediaPlayerPrivateQt::commitLoad. 
1613
1614         New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
1615         HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
1616         is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
1617         A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
1618         is skipped if Qt Multimedia is not available.
1619
1620         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1621         (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
1622         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1623         * tests/qwebpage/tst_qwebpage.cpp:
1624         (tst_QWebPage::loadHtml5Video):
1625         * tests/tests.pri:
1626
1627 2011-02-17  Andreas Kling  <kling@webkit.org>
1628
1629         Reviewed by Antti Koivisto.
1630
1631         [Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
1632         https://bugs.webkit.org/show_bug.cgi?id=49216
1633
1634         * tests/qwebframe/tst_qwebframe.cpp:
1635
1636 == Rolled over to ChangeLog-2011-02-16 ==