1 2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
3 Reviewed by Andreas Kling.
5 [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
6 https://bugs.webkit.org/show_bug.cgi?id=57974
8 We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
10 No new tests needed, just a config flag rename.
12 * Api/qwebkitplatformplugin.h:
13 * WebCoreSupport/ChromeClientQt.cpp:
14 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
15 (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
16 * WebCoreSupport/FullScreenVideoQt.cpp:
17 (WebCore::FullScreenVideoQt::FullScreenVideoQt):
18 (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
19 (WebCore::FullScreenVideoQt::enterFullScreenForNode):
20 (WebCore::FullScreenVideoQt::exitFullScreenForNode):
21 (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
22 (WebCore::FullScreenVideoQt::isValid):
23 * WebCoreSupport/FullScreenVideoQt.h:
24 * WebCoreSupport/QtPlatformPlugin.cpp:
25 * WebCoreSupport/QtPlatformPlugin.h:
26 * examples/platformplugin/WebPlugin.cpp:
27 (WebPlugin::supportsExtension):
28 (WebPlugin::createExtension):
29 * examples/platformplugin/WebPlugin.h:
30 * examples/platformplugin/platformplugin.pro:
31 * examples/platformplugin/qwebkitplatformplugin.h:
32 * tests/qwebpage/tst_qwebpage.cpp:
33 (tst_QWebPage::loadHtml5Video):
36 2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
38 Reviewed by Andreas Kling.
40 [Qt] Implement fullscreen playback for the GStreamer backend.
41 https://bugs.webkit.org/show_bug.cgi?id=56826
43 Implement support for fullscreen playback when building the
44 Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
45 The implementation is done in FullScreenVideoQt alongside with
46 the Qt Multimedia support.
48 No new tests because layout tests cover it. They are not yet activated
49 but will be any time soon.
52 * WebCoreSupport/ChromeClientQt.cpp:
53 (WebCore::ChromeClientQt::ChromeClientQt):
54 (WebCore::ChromeClientQt::~ChromeClientQt):
55 (WebCore::ChromeClientQt::enterFullscreenForNode):
56 (WebCore::ChromeClientQt::exitFullscreenForNode):
57 * WebCoreSupport/ChromeClientQt.h:
58 * WebCoreSupport/FullScreenVideoQt.cpp:
59 (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
60 (WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
61 (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
62 (WebCore::GStreamerFullScreenVideoHandler::windowClosed):
63 (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
64 (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
65 (WebCore::FullScreenVideoQt::FullScreenVideoQt):
66 (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
67 (WebCore::FullScreenVideoQt::enterFullScreenForNode):
68 (WebCore::FullScreenVideoQt::exitFullScreenForNode):
69 (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
70 (WebCore::FullScreenVideoQt::isValid):
71 * WebCoreSupport/FullScreenVideoQt.h:
72 (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):
74 2011-04-06 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
76 Reviewed by Kenneth Rohde Christiansen.
78 [Qt] Improve tests for QWebFrame::url() and related methods
79 https://bugs.webkit.org/show_bug.cgi?id=57865
81 * tests/qwebframe/tst_qwebframe.cpp:
82 (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
83 (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
84 that fails and a load() that fails (for a different URL).
86 (tst_QWebFrame::setUrlWithFragment_data):
87 (tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
88 the URL in the frame before the test starts.
90 (tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
91 the same URL as argument.
94 (tst_QWebFrame::setUrlThenLoads_data):
95 (tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
96 sequence of set and loads. Those tests are interesting because the properties
97 react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
98 is used or after the load() is committed and baseUrl() is similar to url() but also depends
99 on the contents of the page when it loads.
101 2011-04-04 MORITA Hajime <morrita@google.com>
103 Reviewed by Ryosuke Niwa.
105 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
106 https://bugs.webkit.org/show_bug.cgi?id=56085
108 * WebCoreSupport/EditorClientQt.h:
109 (WebCore::EditorClientQt::requestCheckingOfString):
111 2011-04-04 Chang Shu <cshu@webkit.org>
113 Reviewed by Ryosuke Niwa.
115 setContentEditable with true/false/inherit string is not working properly
116 https://bugs.webkit.org/show_bug.cgi?id=52058
118 Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
119 as rendererIsEditable is for WebCore internal use.
121 * WebCoreSupport/EditorClientQt.cpp:
122 (WebCore::EditorClientQt::handleKeyboardEvent):
124 2011-04-01 Carol Szabo <carol.szabo@nokia.com>
126 Reviewed by Benjamin Poulain.
128 Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
129 Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.
131 Tiled painting still causes synchronous layout when
132 accelerated compositing and texture mapper are enabled
133 https://bugs.webkit.org/show_bug.cgi?id=56929
136 (QWebFramePrivate::renderFromTiledBackingStore):
137 (QWebFramePrivate::renderRelativeCoords):
138 (QWebFramePrivate::renderFrameWidgets):
141 2011-04-01 Nancy Piedra <nancy.piedra@nokia.com>
143 Reviewed by Benjamin Poulain.
145 [Qt] DragClientQt.h has coding-style errors
146 https://bugs.webkit.org/show_bug.cgi?id=40425
148 * WebCoreSupport/DragClientQt.h:
150 2011-03-31 Marius Storm-Olsen <marius.storm-olsen@nokia.com>
152 Reviewed by Kenneth Rohde Christiansen.
154 [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
155 https://bugs.webkit.org/show_bug.cgi?id=57017
157 Build fix. No new tests.
161 2011-03-31 Evan Martin <evan@chromium.org>
165 * WebCoreSupport/FrameLoaderClientQt.cpp:
166 (WebCore::FrameLoaderClientQt::updateGlobalHistory):
168 2011-03-31 Nancy Piedra <nancy.piedra@nokia.com>
170 Reviewed by Benjamin Poulain.
172 [Qt] ChromeClientQt.h has coding-style errors
173 https://bugs.webkit.org/show_bug.cgi?id=40239
175 * WebCoreSupport/ChromeClientQt.h:
176 (WebCore::ChromeClientQt::scrollbarsModeDidChange):
177 (WebCore::ChromeClientQt::needTouchEvents):
178 (WebCore::ChromeClientQt::formStateDidChange):
179 (WebCore::ChromeClientQt::scrollRectIntoView):
180 (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
181 (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
183 2011-03-31 Evan Martin <evan@chromium.org>
185 Build fix from previous change.
190 2011-03-31 Evan Martin <evan@chromium.org>
192 Reviewed by Eric Seidel.
194 <title> should support dir attribute
195 https://bugs.webkit.org/show_bug.cgi?id=50961
197 Update to new FrameLoaderClient interface.
199 * WebCoreSupport/FrameLoaderClientQt.cpp:
200 (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
201 (WebCore::FrameLoaderClientQt::setTitle):
202 * WebCoreSupport/FrameLoaderClientQt.h:
204 2011-03-30 Yi Shen <yi.4.shen@nokia.com>
206 Reviewed by Kenneth Rohde Christiansen.
208 [Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
209 https://bugs.webkit.org/show_bug.cgi?id=57020
211 Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().
213 * tests/qwebview/tst_qwebview.cpp:
214 (tst_QWebView::focusInputTypes):
216 2011-03-30 Robert Hogan <robert@webkit.org>
218 Reviewed by Antonio Gomes.
220 [Qt] Fix LoadHTMLStringItem::invoke() after r75966
222 Add DRT support for loading an alternate HTML string
223 for error pages. This allows Qt to unskip
224 http/tests/navigation/go-back-to-error-page.html.
226 https://bugs.webkit.org/show_bug.cgi?id=52614
228 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
229 (DumpRenderTreeSupportQt::setAlternateHtml):
230 * WebCoreSupport/DumpRenderTreeSupportQt.h:
232 2011-03-29 Alexis Menard <alexis.menard@openbossa.org>
234 Unreviewed build fix for build-webkit -minimal.
236 Breakage introduced by http://trac.webkit.org/changeset/82238.
237 The minimal option has no support for shortcuts.
239 * WebCoreSupport/EditorClientQt.cpp:
240 (WebCore::EditorClientQt::handleInputMethodKeydown):
242 2011-03-29 Janne Koskinen <janne.p.koskinen@digia.com>
244 Reviewed by Kenneth Rohde Christiansen.
246 [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
247 https://bugs.webkit.org/show_bug.cgi?id=33179
249 Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.
251 * WebCoreSupport/EditorClientQt.cpp:
252 (WebCore::EditorClientQt::handleInputMethodKeydown):
253 * tests/qwebpage/tst_qwebpage.cpp:
254 (tst_QWebPage::inputMethods):
256 2011-03-29 Andreas Kling <kling@webkit.org>
258 Reviewed by Simon Hausmann.
260 [Qt] Fix documentation for QWebPage::repaintRequested()
262 This signal is always emitted when the page is dirtied, so remove
263 reference to old behavior where we would only emit the signal for
268 2011-03-28 Andreas Kling <kling@webkit.org>
270 Reviewed by Benjamin Poulain.
272 [Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.
274 * WebCoreSupport/FrameLoaderClientQt.cpp:
275 (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
277 2011-03-28 Andreas Kling <kling@webkit.org>
279 Reviewed by Benjamin Poulain.
281 [Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
282 https://bugs.webkit.org/show_bug.cgi?id=52629
284 * WebCoreSupport/ChromeClientQt.cpp:
285 (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
286 QWebPage::repaintRequested() use a Qt::QueuedConnection.
288 * tests/qwebpage/tst_qwebpage.cpp:
289 (RepaintRequestedRenderer::RepaintRequestedRenderer):
290 (RepaintRequestedRenderer::onRepaintRequested):
291 (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
292 QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
293 doesn't cause recursive signal emissions.
295 2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>
297 Reviewed by Andreas Kling.
299 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
300 https://bugs.webkit.org/show_bug.cgi?id=57087
302 * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
303 * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
304 since they are applications, not libraries.
306 2011-03-28 Andras Becsi <abecsi@webkit.org>
308 Reviewed by Csaba Osztrogonác.
310 [Qt] QtWebKit does not link with --3d-canvas using MinGW
311 https://bugs.webkit.org/show_bug.cgi?id=57225
313 * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
315 2011-03-28 Csaba Osztrogonác <ossy@webkit.org>
317 Reviewed by Andreas Kling.
319 REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
320 https://bugs.webkit.org/show_bug.cgi?id=57183
322 Windows buildfix after r82065.
324 * Api/DerivedSources.pro: Readding escaping on Windows platforms.
326 2011-03-27 Andreas Kling <kling@webkit.org>
328 Fix build warning about IconDatabaseClient.h (wrong path.)
332 2011-03-27 Andreas Kling <kling@webkit.org>
334 Reviewed by Kenneth Rohde Christiansen.
336 [Qt] Support for CSS color and background-color properties on select element's dropdown list
337 https://bugs.webkit.org/show_bug.cgi?id=51627
339 Extend the QWebSelectData interface with background and foreground colors
340 for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
341 getters in RenderMenuList.
343 * Api/qwebkitplatformplugin.h:
344 * WebCoreSupport/PopupMenuQt.cpp:
345 (SelectData::backgroundColor):
346 (SelectData::foregroundColor):
347 (SelectData::itemBackgroundColor):
348 (SelectData::itemForegroundColor):
349 * WebCoreSupport/QtFallbackWebPopup.cpp:
350 (WebCore::QtFallbackWebPopup::show):
351 (WebCore::QtFallbackWebPopup::populate):
353 2011-03-27 Yi Shen <yi.4.shen@nokia.com>
355 Reviewed by Andreas Kling.
357 [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
358 https://bugs.webkit.org/show_bug.cgi?id=57108
360 Since the canvas is not self-closing tag, we need to add '</canvas>'.
362 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
363 (tst_QGraphicsWebView::microFocusCoordinates):
364 * tests/qwebview/tst_qwebview.cpp:
365 (tst_QWebView::microFocusCoordinates):
367 2011-03-27 Kwang Yul Seo <skyul@company100.net>
369 Reviewed by Eric Seidel.
371 [Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
372 https://bugs.webkit.org/show_bug.cgi?id=57143
374 Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
375 define WTF_USE_TEXTURE_MAPPER=1.
379 2011-03-27 Andreas Kling <kling@webkit.org>
381 Reviewed by Benjamin Poulain.
383 REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
384 https://bugs.webkit.org/show_bug.cgi?id=57183
386 The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
387 which was due to the outputting code previously being wrapped in eval().
389 * Api/DerivedSources.pro:
391 2011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com>
393 Reviewed by Andreas Kling.
395 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
396 https://bugs.webkit.org/show_bug.cgi?id=57087
398 Use explicit conversion for string to avoid depending on the default codec
399 installed by the user code.
401 * Api/qwebkitversion.cpp:
404 (QWebPagePrivate::dynamicPropertyChangeEvent):
405 (QWebPage::javaScriptConsoleMessage):
406 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
407 (convertToPropertyName):
408 (DumpRenderTreeSupportQt::setEditingBehavior):
409 (DumpRenderTreeSupportQt::plainText):
410 * WebCoreSupport/EditorClientQt.cpp:
412 * WebCoreSupport/FrameLoaderClientQt.cpp:
413 (drtDescriptionSuitableForTestResult):
414 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
415 * WebCoreSupport/InspectorClientQt.cpp:
416 (WebCore::InspectorClientQt::openInspectorFrontend):
417 * WebCoreSupport/InspectorServerQt.cpp:
418 (WebCore::parseWebSocketChallengeNumber):
419 (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
421 2011-03-26 Andreas Kling <kling@webkit.org>
423 Reviewed by Kenneth Rohde Christiansen.
425 [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
426 https://bugs.webkit.org/show_bug.cgi?id=57157
428 Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
429 is always emitted when appropriate.
431 * QtWebKit.pro: Add new files.
433 * WebCoreSupport/IconDatabaseClientQt.h: Added.
434 * WebCoreSupport/IconDatabaseClientQt.cpp: Added.
435 (WebCore::IconDatabaseClientQt::instance):
436 (WebCore::IconDatabaseClientQt::IconDatabaseClientQt):
437 (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt):
438 (WebCore::IconDatabaseClientQt::performImport):
439 (WebCore::IconDatabaseClientQt::didRemoveAllIcons):
440 (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL):
441 (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL):
442 (WebCore::IconDatabaseClientQt::didChangeIconForPageURL):
443 (WebCore::IconDatabaseClientQt::didFinishURLImport):
445 * WebCoreSupport/FrameLoaderClientQt.h:
446 * WebCoreSupport/FrameLoaderClientQt.cpp:
447 (WebCore::FrameLoaderClientQt::registerForIconNotification):
448 (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected
449 to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the
450 QWebFrame::iconChanged() signal when the IconDatabases finishes loading
451 a cached favicon for the frame's URL.
453 * Api/qwebsettings.cpp:
454 (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is
455 instantiated. An IconDatabaseClient has to be registered before the IconDatabase
456 spawns its reader thread.
458 2011-03-25 Andy Estes <aestes@apple.com>
460 Reviewed by Adele Peterson.
462 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
463 https://bugs.webkit.org/show_bug.cgi?id=49016
465 Update objectContentType() implementation to handle the
466 shouldPreferPlugInsForImages flag.
468 * WebCoreSupport/FrameLoaderClientQt.cpp:
469 (WebCore::FrameLoaderClientQt::objectContentType):
470 * WebCoreSupport/FrameLoaderClientQt.h:
472 2011-03-25 Chang Shu <cshu@webkit.org>
474 Reviewed by Ryosuke Niwa.
476 rename Node::isContentEditable and all call sites to rendererIsEditable
477 https://bugs.webkit.org/show_bug.cgi?id=54290
479 This is part of the effort to separate JS API HTMLElement isContentEditable from
480 internal Node::rendererIsEditable.
482 * WebCoreSupport/EditorClientQt.cpp:
483 (WebCore::EditorClientQt::handleKeyboardEvent):
485 2011-03-25 Alexis Menard <alexis.menard@openbossa.org>
487 Reviewed by Andreas Kling.
489 [Qt] The keyboard shortcuts during fullscreen playback do not work.
490 https://bugs.webkit.org/show_bug.cgi?id=57095
492 We need to explicitely set the focus on the widget in order to receive the keyboard events.
494 * WebCoreSupport/FullScreenVideoWidget.cpp:
495 (WebCore::FullScreenVideoWidget::show):
497 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
499 Unreviewed, rolling out r81916 and r81917.
500 http://trac.webkit.org/changeset/81916
501 http://trac.webkit.org/changeset/81917
502 https://bugs.webkit.org/show_bug.cgi?id=57071
504 broke a test on platforms that do not have QuickTime installed
505 (Requested by estes on #webkit).
507 * WebCoreSupport/FrameLoaderClientQt.cpp:
508 (WebCore::FrameLoaderClientQt::objectContentType):
509 * WebCoreSupport/FrameLoaderClientQt.h:
511 2011-03-24 Andy Estes <aestes@apple.com>
513 Reviewed by Darin Adler.
515 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
516 https://bugs.webkit.org/show_bug.cgi?id=49016
518 Update objectContentType() implementation to handle the
519 shouldPreferPlugInsForImages flag.
521 * WebCoreSupport/FrameLoaderClientQt.cpp:
522 (WebCore::FrameLoaderClientQt::objectContentType):
523 * WebCoreSupport/FrameLoaderClientQt.h:
525 2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>
527 Reviewed by Kenneth Rohde Christiansen.
529 [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
530 https://bugs.webkit.org/show_bug.cgi?id=40884
532 Add tests and benchmarks for the software fallback of WebGL.
534 * tests/benchmarks/webgl/10000_triangles.html: Added.
535 * tests/benchmarks/webgl/tst_webgl.cpp: Added.
536 (GraphicsView::GraphicsView):
537 (GraphicsView::resizeEvent):
538 (tst_WebGlPerformance::init):
539 (tst_WebGlPerformance::cleanup):
540 (tst_WebGlPerformance::benchSoftwareFallbackRgb16):
541 (tst_WebGlPerformance::benchSoftwareFallbackRgb32):
542 (tst_WebGlPerformance::benchSoftwareFallbackArgb32):
543 (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
544 (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
545 * tests/benchmarks/webgl/tst_webgl.qrc: Added.
546 * tests/benchmarks/webgl/webgl.pro: Added.
547 * tests/qgraphicswebview/qgraphicswebview.pro:
548 * tests/qgraphicswebview/resources/pointing_right.html: Added.
549 * tests/qgraphicswebview/resources/pointing_up.html: Added.
550 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
551 (compareImagesFuzzyPixelCount):
552 (GraphicsView::GraphicsView):
553 (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
554 (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
555 (tst_QGraphicsWebView::compareCanvasToImage):
556 * tests/qgraphicswebview/tst_qgraphicswebview.qrc:
559 2011-03-24 Kristian Amlie <kristian.amlie@nokia.com>
561 Reviewed by Benjamin Poulain.
563 Avoided ASCII-cast warnings for WebKit.
565 Normally they won't be enabled anyway, but if you build webkit from
566 within the Qt mother repository it will pick up Qt's default build
567 settings, which do enable it. We need to disable them because
568 warnings are treated as errors and there are way too many of them in
571 [Qt] Avoid ASCII-cast warnings for WebKit.
572 https://bugs.webkit.org/show_bug.cgi?id=57016
576 2011-03-24 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
578 Reviewed by Benjamin Poulain.
580 [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
581 https://bugs.webkit.org/show_bug.cgi?id=29595
583 Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
584 ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
585 prepending the current directory.
587 By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
588 will end up loading "about:blank", but keeping it as a requested URL.
590 This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
591 is filled for the loaded URLs as well, we can use it in every case.
593 Three new autotests were added, to better cover the expected behavior of setting
594 the QUrl() in a QWebFrame.
597 (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
598 (QWebFrame::requestedUrl): always use m_lastRequestedUrl.
600 * WebCoreSupport/FrameLoaderClientQt.cpp:
601 (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
602 anymore, since we always rely on it even for loaded frames.
604 * tests/qwebframe/tst_qwebframe.cpp:
605 (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
606 the reduction of the bug report.
607 (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
608 (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
610 2011-03-23 Brady Eidson <beidson@apple.com>
612 Reviewed by Sam Weinig.
614 Change IconDatabase opening to allow for arbitrary filenames
615 https://bugs.webkit.org/show_bug.cgi?id=56977
617 * Api/qwebsettings.cpp:
618 (QWebSettings::setIconDatabasePath):
620 2011-03-23 Aparna Nandyal <aparna.nand@wipro.com>
622 Reviewed by Andreas Kling.
624 [Qt] QtWebKit rendering problem when maximizing and doing a back
625 https://bugs.webkit.org/show_bug.cgi?id=56669
628 Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21
630 * tests/qwebview/tst_qwebview.cpp:
631 (tst_QWebView::rendering):
633 2011-03-23 Yury Semikhatsky <yurys@chromium.org>
635 Reviewed by Pavel Feldman.
637 [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
638 https://bugs.webkit.org/show_bug.cgi?id=56843
640 * WebCoreSupport/InspectorClientQt.cpp:
641 (WebCore::InspectorClientQt::openInspectorFrontend):
643 2011-03-22 Andrew Wason <rectalogic@rectalogic.com>
645 Reviewed by Benjamin Poulain.
647 [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
648 https://bugs.webkit.org/show_bug.cgi?id=54138
650 * tests/qwebpage/tst_qwebpage.cpp:
651 (webGLScreenshotWithoutView):
652 (tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
653 (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
654 Render a QWebPage (with and without accelerated compositing)
655 with a WebGL context that has no owning view. Shouldn't crash.
657 2011-03-21 Chang Shu <cshu@webkit.org>
659 Reviewed by Alexey Proskuryakov.
661 REGRESSION (r79953): Can't type in MS Outlook 2011
662 https://bugs.webkit.org/show_bug.cgi?id=56665
664 r79953 removed the WebView level editablity which is persistent no matter whether
665 underlying document itself is changed and editability gets lost. The resolution is to
666 set this WebView editable value to WebCore. This avoids the callback from WebCore to
667 WebKit which was the main goal in r79953 to improve performance.
670 (QWebPage::setContentEditable):
671 (QWebPage::isContentEditable):
673 2011-03-19 Andreas Kling <kling@webkit.org>
675 Reviewed by Benjamin Poulain.
677 [Qt] Remove support for Qt 4.6
678 https://bugs.webkit.org/show_bug.cgi?id=56712
683 (QWebPagePrivate::QWebPagePrivate):
684 * Api/qwebsettings.cpp:
685 (QWebSettings::QWebSettings):
686 * WebCoreSupport/GeolocationClientQt.cpp:
687 (WebCore::GeolocationClientQt::positionUpdated):
689 2011-03-19 Andreas Kling <kling@webkit.org>
691 Reviewed by Antonio Gomes.
693 [Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
694 https://bugs.webkit.org/show_bug.cgi?id=56711
696 Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
697 ownership of the reply is transferred to the receiving slot.
701 2011-03-17 Brady Eidson <beidson@apple.com>
703 Reviewed by Sam Weinig.
705 https://bugs.webkit.org/show_bug.cgi?id=56425
706 More groundwork for WebKit2 IconDatabase
708 Update already-used function names:
709 * Api/qwebhistory.cpp:
710 (QWebHistoryItem::icon):
711 * Api/qwebsettings.cpp:
712 (QWebSettings::iconForUrl):
714 2011-03-18 Alexis Menard <alexis.menard@openbossa.org>
716 Reviewed by Benjamin Poulain.
718 [Qt] console.log not being exposed to QmlViewer
719 https://bugs.webkit.org/show_bug.cgi?id=56536
721 The documentation is bogus the feature does not exist.
723 * declarative/qdeclarativewebview.cpp:
725 2011-03-17 Andreas Kling <kling@webkit.org>
727 Reviewed by Kenneth Rohde Christiansen.
729 [Qt] QML WebView emits iconChanged() when the page title changes
730 https://bugs.webkit.org/show_bug.cgi?id=56570
732 * declarative/qdeclarativewebview.cpp:
733 (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
734 signal to the view's iconChanged signal.
736 2011-03-17 Alexis Menard <alexis.menard@openbossa.org>
738 Reviewed by Benjamin Poulain.
740 [Qt] Videos look ugly when using QGraphicsWebView.
741 https://bugs.webkit.org/show_bug.cgi?id=56580
743 We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
744 QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
745 by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
746 QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
747 ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
748 in addition of what could be set on the painter. In order to not break the rendering of all the items in the
749 scene we set back the painter to its original state when QGraphicsWebView is rendered.
751 * Api/qgraphicswebview.cpp:
752 (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
753 (QGraphicsWebView::paint):
754 (QGraphicsWebView::renderHints):
755 (QGraphicsWebView::setRenderHints):
756 (QGraphicsWebView::setRenderHint):
757 * Api/qgraphicswebview.h:
758 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
759 (tst_QGraphicsWebView::renderHints):
761 2011-03-16 Joseph Pecoraro <joepeck@webkit.org>
763 Reviewed by Kenneth Rohde Christiansen.
765 Viewport no longer allows an auto value for "user-scalable"
766 https://bugs.webkit.org/show_bug.cgi?id=55416
768 Make the default value for userScalable be true.
771 (QWebPage::viewportAttributesForSize):
772 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
773 (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.
775 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
777 Reviewed by Darin Adler.
779 Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
780 info into the headers rather than in export symbol definition files, but disable it on
781 all platforms initially so we can deal with port build issues one port at a time.
783 https://bugs.webkit.org/show_bug.cgi?id=27551
785 * WebCoreSupport/GeolocationClientQt.cpp:
786 * WebCoreSupport/PopupMenuQt.cpp:
788 2011-03-14 Brady Eidson <beidson@apple.com>
790 Reviewed by Anders Carlsson.
792 https://bugs.webkit.org/show_bug.cgi?id=56320
793 Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
795 * Api/qwebhistory.cpp:
796 (QWebHistoryItem::icon): Use IconDatabase directly.
798 2011-03-11 Brady Eidson <beidson@apple.com>
800 Reviewed by attempt at build fix!
802 https://bugs.webkit.org/show_bug.cgi?id=56216
803 Fix the Qt build following the same pattern of the patch.
805 * Api/qwebsettings.cpp:
806 (QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
808 2011-03-11 Alexis Menard <alexis.menard@openbossa.org>
810 Reviewed by Ariya Hidayat.
812 [Qt] Entering fullscreen and leaving it may hide the cursor of the application.
813 https://bugs.webkit.org/show_bug.cgi?id=56181
815 We need to stop the auto hide cursor timer when closing the widget otherwise the timer
816 might get fired and therefore hide the cursor even when the fullscreen widget is closed.
818 * WebCoreSupport/FullScreenVideoWidget.cpp:
819 (WebCore::FullScreenVideoWidget::closeEvent):
821 2011-03-10 David Boddie <david.boddie@nokia.com>
823 Reviewed by Andreas Kling.
825 Fixed a qdoc warning and terminology (WebKit instead of Webkit).
826 https://bugs.webkit.org/show_bug.cgi?id=55756
828 * Api/qwebhistoryinterface.cpp:
830 2011-03-10 Andreas Kling <kling@webkit.org>
832 Unreviewed build fix after r80774.
834 QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
835 See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451
837 * declarative/plugin.cpp:
838 (WebKitQmlPlugin::registerTypes):
839 * declarative/qdeclarativewebview.cpp:
840 * declarative/qdeclarativewebview_p.h:
841 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
843 2011-03-10 Alexis Menard <alexis.menard@openbossa.org>
845 Reviewed by Andreas Kling.
847 [Qt] QtDeclarative Webview element has a fixed white background
848 https://bugs.webkit.org/show_bug.cgi?id=40918
850 Implement a way to change the background color of the WebView QML element.
851 This feature is activated for QtWebKit 1.1 version of the plugin.
853 * declarative/plugin.cpp:
854 (WebKitQmlPlugin::registerTypes):
855 * declarative/qdeclarativewebview.cpp:
856 (QDeclarativeWebView::backgroundColor):
857 (QDeclarativeWebView::setBackgroundColor):
858 * declarative/qdeclarativewebview_p.h:
859 * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
860 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
861 (tst_QDeclarativeWebView::backgroundColor):
862 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
864 2011-03-10 Stanislav Paltis <Stanislav.Paltis@nokia.com>
866 Reviewed by Laszlo Gombos.
868 [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
869 https://bugs.webkit.org/show_bug.cgi?id=55945
871 Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to
872 set interval used to trigger when decoded data in dead list of object cache will
873 be purged from object cache.
876 (QWebPagePrivate::dynamicPropertyChangeEvent):
878 2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
880 Reviewed by Antonio Gomes.
882 Simplify how QWebFrame::requestedUrl() is obtained
883 https://bugs.webkit.org/show_bug.cgi?id=55842
885 When a load starts, store the requested URL until we know that it'll be
886 available for us in the document loader -- after load finished.
888 The existing auto tests cover the three different code paths in
889 requestedUrl() and the new code passes the autotests. In each of those
890 cases, we looked for the information in a different place, but in all
891 of them, dispatchDidStartProvisionalLoad was called.
893 This simplification will be useful to fix bug 32723. The way requestedUrl()
894 is implementent, we can't use it as a fallback for url() when the setUrl()
895 was called with an invalid URL.
898 (QWebFrame::requestedUrl):
899 * WebCoreSupport/FrameLoaderClientQt.cpp:
900 (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
901 (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
902 * WebCoreSupport/FrameLoaderClientQt.h:
903 (WebCore::FrameLoaderClientQt::lastRequestedUrl):
905 2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
907 Reviewed by Kenneth Rohde Christiansen.
909 Tiled backing store's delegated scroll request uses incorrect convention
910 https://bugs.webkit.org/show_bug.cgi?id=56011
912 Adapt internal API to match the change from delta to point on the
913 WebCore side, and convert the point to a delta for the public API.
915 * WebCoreSupport/ChromeClientQt.cpp:
916 (WebCore::ChromeClientQt::delegatedScrollRequested):
917 * WebCoreSupport/ChromeClientQt.h:
919 2011-03-09 Peter Kasting <pkasting@google.com>
921 Reviewed by Mihai Parparita.
923 Unify Windows version checks.
924 https://bugs.webkit.org/show_bug.cgi?id=55979
927 (QWebPage::userAgentForUrl):
929 2011-03-07 Sam Weinig <sam@webkit.org>
931 Reviewed by Anders Carlsson.
933 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
934 https://bugs.webkit.org/show_bug.cgi?id=55827
936 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
937 and pass the entire response, instead of just the MIMEType.
939 * WebCoreSupport/FrameLoaderClientQt.cpp:
940 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
941 * WebCoreSupport/FrameLoaderClientQt.h:
943 2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>
945 Reviewed by Laszlo Gombos.
947 [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
948 https://bugs.webkit.org/show_bug.cgi?id=48636
950 Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
953 (QWebPage::userAgentForUrl):
955 2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
957 Reviewed by Kenneth Rohde Christiansen.
959 [QT] Implement mock client-based geolocation for layout testing
960 https://bugs.webkit.org/show_bug.cgi?id=54334
962 Implement layout testing for Client-Based geolocation. If drt_run is set
963 then create mock geolocationClient and update the same with controller.
966 (QWebPagePrivate::QWebPagePrivate):
967 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
968 (DumpRenderTreeSupportQt::mockGeolocationReset):
969 (DumpRenderTreeSupportQt::setMockGeolocationPermission):
970 (DumpRenderTreeSupportQt::setMockGeolocationPosition):
971 (DumpRenderTreeSupportQt::setMockGeolocationError):
972 * WebCoreSupport/DumpRenderTreeSupportQt.h:
973 * WebCoreSupport/GeolocationClientQt.cpp:
974 (WebCore::GeolocationClientQt::GeolocationClientQt):
975 * WebCoreSupport/GeolocationClientQt.h:
977 2011-03-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
979 Reviewed by Kenneth Rohde Christiansen.
981 [Qt] QWebFrame::setUrl works only from second time if url fragment is present
982 https://bugs.webkit.org/show_bug.cgi?id=32723
984 Create an auto-test for Qt based on the bug description.
986 * tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
988 2011-03-03 Brady Eidson <beidson@apple.com>
990 Reviewed by Darin Adler.
992 https://bugs.webkit.org/show_bug.cgi?id=55721
993 Global IconDatabase should be returned by reference, not as a pointer
995 * Api/qwebsettings.cpp:
996 (QWebSettings::setIconDatabasePath):
997 (QWebSettings::iconDatabasePath):
998 (QWebSettings::clearIconDatabase):
999 (QWebSettings::iconForUrl):
1001 2011-03-03 Alexey Proskuryakov <ap@apple.com>
1003 Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
1006 * WebCoreSupport/ChromeClientQt.h:
1008 2011-03-02 Alexey Proskuryakov <ap@apple.com>
1010 Reviewed by Darin Adler.
1012 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
1013 https://bugs.webkit.org/show_bug.cgi?id=55633
1014 <rdar://problem/8963023>
1016 * WebCoreSupport/ChromeClientQt.cpp (WebCore::ChromeClientQt::keyboardUIMode):
1017 * WebCoreSupport/ChromeClientQt.h:
1018 Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
1019 this platform doesn't observe or have full keyboard access state.
1021 2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
1023 Reviewed by Andreas Kling.
1025 [Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
1026 https://bugs.webkit.org/show_bug.cgi?id=55568
1028 We should use updateMicroFocus() from QGraphicsItem rather than the implementation
1029 in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
1030 In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
1033 * Api/qgraphicswebview.cpp:
1034 (QGraphicsWebView::setPage):
1035 * Api/qgraphicswebview.h:
1037 2011-03-03 Peter Kasting <pkasting@google.com>
1039 Reviewed by James Robinson.
1041 Drop redundant "Windows; " from the Windows-specific User Agent string.
1042 https://bugs.webkit.org/show_bug.cgi?id=54567
1045 (QWebPage::userAgentForUrl):
1047 2011-03-01 Brian Weinstein <bweinstein@apple.com>
1049 Reviewed by Adam Roben.
1051 Part of WebKit2: Need a way to send notifications to client when cookies change
1052 https://bugs.webkit.org/show_bug.cgi?id=55427
1053 <rdar://problem/9056027>
1055 Add stubs for CookiesStrategy on Qt WebKit1.
1057 * WebCoreSupport/WebPlatformStrategies.cpp:
1058 (WebPlatformStrategies::createCookiesStrategy):
1059 (WebPlatformStrategies::notifyCookiesChanged):
1060 * WebCoreSupport/WebPlatformStrategies.h:
1062 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
1064 Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
1067 (QWebPage::viewportAttributesForSize):
1068 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1069 (DumpRenderTreeSupportQt::viewportAsText):
1071 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
1073 Reviewed by Kenneth Rohde Christiansen.
1075 Viewport Warning/Error Messages Are Now Inaccurate
1076 https://bugs.webkit.org/show_bug.cgi?id=53707
1079 (QWebPage::viewportAttributesForSize): pass a Document into computeViewportAttributes for warnings to be reported to.
1080 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1081 (DumpRenderTreeSupportQt::viewportAsText): pass a Document into computeViewportAttributes for warnings to be reported to.
1083 2011-03-01 Andras Becsi <abecsi@webkit.org>
1085 Reviewed by Csaba Osztrogonác.
1087 [Qt] Clean up the project files and move common options to WebKit.pri.
1089 * QtWebKit.pro: Move common options to WebKit.pri.
1091 2011-03-01 Aparna Nandyal <aparna.nand@wipro.com>
1093 Reviewed by Simon Hausmann.
1095 [Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
1096 https://bugs.webkit.org/show_bug.cgi?id=55319
1098 The test case required internet connection to be able to connect to
1099 google.com. Added new html file which refers to local html file.
1101 * tests/qwebpage/resources/content.html: Added.
1102 * tests/qwebpage/resources/frame_c.html: Added.
1103 * tests/qwebpage/resources/framedindex.html: Added.
1104 * tests/qwebpage/tst_qwebpage.cpp:
1105 (tst_QWebPage::backActionUpdate):
1106 * tests/qwebpage/tst_qwebpage.qrc:
1108 2011-02-25 Steve Block <steveblock@google.com>
1110 Reviewed by Jeremy Orlow.
1112 Bridge.h should not include BridgeJSC.h
1113 https://bugs.webkit.org/show_bug.cgi?id=55212
1115 Include BridgeJSC.h directly instead.
1117 * Api/qwebframe.cpp:
1119 2011-02-28 Chang Shu <cshu@webkit.org>
1121 Reviewed by Ryosuke Niwa.
1123 Remove the support of Frame::isContentEditable and its dependencies.
1124 https://bugs.webkit.org/show_bug.cgi?id=54292
1126 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
1129 (QWebPagePrivate::QWebPagePrivate):
1130 (QWebPage::setContentEditable):
1131 (QWebPage::isContentEditable):
1133 * WebCoreSupport/EditorClientQt.cpp:
1134 * WebCoreSupport/EditorClientQt.h:
1136 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
1138 Reviewed by Oliver Hunt.
1140 Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
1142 * Api/qwebelement.cpp:
1143 (QWebElement::evaluateJavaScript):
1145 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
1147 Reviewed by Andreas Kling.
1149 [Qt]tst_QDeclarativeWebView - 8 test cases fail
1150 https://bugs.webkit.org/show_bug.cgi?id=55214
1152 Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
1153 if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
1154 I also refactored the tests so we don't use the network but instead a local html file.
1155 QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.
1157 * tests/qdeclarativewebview/resources/sample.html: Added.
1158 * tests/qdeclarativewebview/resources/webviewtest.qml:
1159 * tests/qdeclarativewebview/resources/webviewtestdefault.qml:
1160 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
1161 (tst_QDeclarativeWebView::preferredWidthTest):
1162 (tst_QDeclarativeWebView::preferredHeightTest):
1163 (tst_QDeclarativeWebView::preferredWidthDefaultTest):
1164 (tst_QDeclarativeWebView::preferredHeightDefaultTest):
1165 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
1167 2011-02-28 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
1169 Reviewed by Andreas Kling.
1171 [Qt] Add clipped version of QWebElement::render method.
1172 Allows faster rendering of web element part.
1173 https://bugs.webkit.org/show_bug.cgi?id=50311
1175 * Api/qwebelement.cpp:
1176 (QWebElement::render):
1177 * Api/qwebelement.h:
1178 * tests/qwebelement/tst_qwebelement.cpp:
1179 (tst_QWebElement::render):
1181 2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
1183 Reviewed by Andreas Kling.
1185 Added full webkit module profile and a syncqt profile.
1187 This is for modularized Qt.
1189 [Qt] WebKit patches required to work with a modularized version of Qt
1190 https://bugs.webkit.org/show_bug.cgi?id=53916
1192 * qt_webkit_version.pri:
1194 2011-02-27 Aparna Nandyal <aparna.nand@wipro.com>
1196 Reviewed by Antonio Gomes.
1198 [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
1199 https://bugs.webkit.org/show_bug.cgi?id=53917
1201 Adding test case to check the scenario to avoid regressions in the
1204 * tests/qwebframe/tst_qwebframe.cpp:
1206 2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
1208 Reviewed by Andreas Kling.
1210 [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
1211 https://bugs.webkit.org/show_bug.cgi?id=55322
1213 Documentation update, add a reference to the QtWebKit bridge page.
1215 * Api/qwebframe.cpp:
1217 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
1219 Reviewed by Pavel Feldman.
1221 DumpRenderTree should reset frame opener between tests.
1222 https://bugs.webkit.org/show_bug.cgi?id=54874
1224 Added clearOpener method to DumpRenderTreeSupportQT.
1226 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1227 (DumpRenderTreeSupportQt::clearOpener):
1228 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1230 2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
1232 Reviewed by Andreas Kling.
1234 Make it possible to test the targetdensity-dpi support
1235 https://bugs.webkit.org/show_bug.cgi?id=55142
1237 Test the viewport meta tag feature targetdensity-dpi by
1238 adding extra arguments to dumpConfigurationForViewport
1240 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1241 (DumpRenderTreeSupportQt::viewportAsText):
1242 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1244 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
1246 Unreviewed, rolling out r79764.
1247 http://trac.webkit.org/changeset/79764
1248 https://bugs.webkit.org/show_bug.cgi?id=55295
1250 "broke Chromium builds" (Requested by rniwa on #webkit).
1252 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1253 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1255 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
1257 Reviewed by Pavel Feldman.
1259 DumpRenderTree should reset frame opener between tests.
1260 https://bugs.webkit.org/show_bug.cgi?id=54874
1262 Added clearOpener method to DumpRenderTreeSupportQT.
1264 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1265 (DumpRenderTreeSupportQt::clearOpener):
1266 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1268 2011-02-25 Andras Becsi <abecsi@webkit.org>
1270 Reviewed by Csaba Osztrogonác.
1272 [Qt] Make the WebKit2 build system less confusing for non-Qt developers
1273 https://bugs.webkit.org/show_bug.cgi?id=55213
1275 * QtWebKit.pro: Move the WebKit2 API into a project include file
1276 in the WebKit2 directory and include the pri file here.
1278 2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
1280 Unreviewed build fix for Intel ICC and MSVC.
1282 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1283 (tst_QGraphicsWebView::setPalette):
1284 * tests/qwebview/tst_qwebview.cpp:
1285 (tst_QWebView::setPalette):
1287 2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
1289 Reviewed by Kenneth Rohde Christiansen.
1291 [Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
1292 https://bugs.webkit.org/show_bug.cgi?id=31742
1294 Discovered while looking at 31742. When we set a palette on the
1295 QGraphicsWebView we need to propagate it to the page like QWebView.
1296 I have added the same tests as QWebView to be sure to catch potential
1297 regressions as well as two extras QVERIFY to check the palette propagation.
1299 * Api/qgraphicswebview.cpp:
1300 (QGraphicsWebView::event):
1301 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1302 (tst_QGraphicsWebView::setPalette_data):
1303 (tst_QGraphicsWebView::setPalette):
1305 2011-02-25 Csaba Osztrogonác <ossy@webkit.org>
1307 Unreviewed buildfix after r79672.
1309 [Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.
1314 2011-02-25 Gopal Raghavan <gopal.1.raghavan@nokia.com>
1316 Reviewed by Kenneth Rohde Christiansen.
1318 [Qt] QML WebView inside a Flickable shows checkers pattern at startup
1319 https://bugs.webkit.org/show_bug.cgi?id=50222.
1321 This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.
1323 * declarative/qdeclarativewebview.cpp:
1324 (QDeclarativeWebView::init):
1325 * tests/qdeclarativewebview: Added.
1326 * tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
1327 * tests/qdeclarativewebview/resources: Added.
1328 * tests/qdeclarativewebview/resources/webviewtest.qml: Added.
1329 * tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
1330 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added.
1331 (tst_QDeclarativeWebView::initTestCase):
1332 (tst_QDeclarativeWebView::cleanupTestCase):
1333 (tst_QDeclarativeWebView::init):
1334 (tst_QDeclarativeWebView::cleanup):
1335 (tst_QDeclarativeWebView::preferredWidthTest):
1336 (tst_QDeclarativeWebView::preferredHeightTest):
1337 (tst_QDeclarativeWebView::preferredWidthDefaultTest):
1338 (tst_QDeclarativeWebView::preferredHeightDefaultTest):
1339 (tst_QDeclarativeWebView::checkNoErrors):
1343 2011-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
1345 Reviewed by Andreas Kling.
1347 [Qt] Revert the support for QNAM affined to a different thread.
1348 https://bugs.webkit.org/show_bug.cgi?id=55149
1350 Qt 4.8 will have QNAM use its own thread internally by default,
1351 no need to keep this complexity in WebKit.
1353 This mainly reverts:
1354 http://trac.webkit.org/changeset/73710
1355 http://trac.webkit.org/changeset/73712
1357 * WebCoreSupport/FrameLoaderClientQt.cpp:
1358 (WebCore::FrameLoaderClientQt::download):
1359 * tests/qwebpage/tst_qwebpage.cpp:
1361 2011-02-24 Sam Weinig <sam@webkit.org>
1363 Try to fix the Qt build.
1367 2011-02-24 Peter Kasting <pkasting@google.com>
1369 Reviewed by Eric Seidel.
1371 Drop the "U; " encryption level from the User Agent string.
1372 https://bugs.webkit.org/show_bug.cgi?id=54566
1375 (QWebPage::userAgentForUrl):
1377 2011-02-24 Andrew Wilson <atwilson@chromium.org>
1379 Unreviewed, rolling out r79570.
1380 http://trac.webkit.org/changeset/79570
1381 https://bugs.webkit.org/show_bug.cgi?id=54874
1383 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
1386 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1387 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1389 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
1391 Reviewed by Alexey Proskuryakov.
1393 DumpRenderTree should reset frame opener between tests.
1394 https://bugs.webkit.org/show_bug.cgi?id=54874
1396 Added clearOpener method to DumpRenderTreeSupportQT.
1398 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1399 (DumpRenderTreeSupportQt::clearOpener):
1400 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1402 2011-02-24 Alexis Menard <alexis.menard@openbossa.org>
1404 Reviewed by Andreas Kling.
1406 [Qt] tst_QWebView::setPalette(activeFG) fails
1407 https://bugs.webkit.org/show_bug.cgi?id=55029
1409 This time it should be the proper fix. The window needs to be shown before we
1410 call activateWindow() otherwise there is no active windows for the application.
1412 * tests/qwebview/tst_qwebview.cpp:
1413 (tst_QWebView::setPalette):
1415 2011-02-24 Andras Becsi <abecsi@webkit.org>
1417 Reviewed by Laszlo Gombos.
1419 [Qt] MinGW build fails to link
1420 https://bugs.webkit.org/show_bug.cgi?id=55050
1422 Prepend the libraries of subcomponents instead of appending them
1423 to fix the library order according to the dependency of the libraries
1425 * QtWebKit.pro: prepend libraries in the correct order
1427 2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
1429 Reviewed by Ariya Hidayat.
1431 [Qt] tst_QWebView::setPalette(activeFG) fails
1432 https://bugs.webkit.org/show_bug.cgi?id=55029
1434 Attempt to make the test more robust. By investigating with the bot virtual machine
1435 I discovered that the activation can take some time. In this patch we make sure that
1436 the active window we want to have is the same as the QApplication.
1438 * tests/qwebview/tst_qwebview.cpp:
1439 (tst_QWebView::setPalette):
1441 2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
1443 Reviewed by Dan Bernstein.
1445 [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
1446 http://trac.webkit.org/changeset/79167 refactored the way the bound size of
1447 the frame is handled. A new API setBoundsSize was added, we need to call it
1448 in addition to setFrameRect. I could call setBoundSize after setFrameRect but
1449 I thought It would be more elegant to use the resize method.
1452 (QWebPage::setViewportSize):
1454 2011-02-22 Fabrizio Machado <fabrizio.machado@nokia.com>
1456 Reviewed by Laszlo Gombos.
1458 [Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
1459 https://bugs.webkit.org/show_bug.cgi?id=54976
1463 * WebCoreSupport/InspectorClientQt.cpp:
1465 2011-02-22 Alexis Menard <alexis.menard@openbossa.org>
1467 Reviewed by Andreas Kling.
1469 [Qt] QWebView ignores a palette set with QWebView::setPalette()
1470 https://bugs.webkit.org/show_bug.cgi?id=31742
1472 Test case to check that the palette sets on the QWebView is taken
1475 * tests/qwebview/tst_qwebview.cpp:
1476 (tst_QWebView::setPalette_data):
1477 (tst_QWebView::setPalette):
1479 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
1481 Reviewed by Alexey Proskuryakov.
1483 Drop the language tag part from the User Agent string
1484 https://bugs.webkit.org/show_bug.cgi?id=54560
1487 (QWebPage::userAgentForUrl):
1489 * tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange
1492 2011-02-22 Chang Shu <cshu@webkit.org>
1494 Reviewed by Csaba Osztrogonác.
1496 [Qt] editing/deleting/5408255.html fails
1497 https://bugs.webkit.org/show_bug.cgi?id=54964
1499 Move WebCore resource file to QtWebKit since they are referred in WebKit.
1503 2011-02-22 Andras Becsi <abecsi@webkit.org>
1505 Reviewed by Csaba Osztrogonác.
1507 [Qt] Redesign the build system
1508 https://bugs.webkit.org/show_bug.cgi?id=51339
1510 Move inspector's resource files into the final build step to fix the layout test regression.
1512 * QtWebKit.pro: Add inspector's reaource files.
1514 2011-02-22 Andras Becsi <abecsi@webkit.org>
1516 Reviewed by Laszlo Gombos.
1517 Rubber-stamped by Csaba Osztrogonác.
1519 [Qt] Redesign the build system
1520 https://bugs.webkit.org/show_bug.cgi?id=51339
1522 The patch landed in r79320 didn't contain the cleanup
1523 which was already addressed in the last attachment.
1525 * QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
1527 2011-02-22 Andras Becsi <abecsi@webkit.org>
1529 Reviewed by Laszlo Gombos.
1531 [Qt] Redesign the build system
1532 https://bugs.webkit.org/show_bug.cgi?id=51339
1536 Build WebCore as a static library, compile the WebKit API and WebKit2 API
1537 in a final step and link to WebKit2, WebCore and JSC libraries to fix
1538 linking issues resulting from stripped away symbols.
1540 * QtWebKit.pro: Added.
1541 Project file for the final build step.
1543 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
1545 Reviewed by Kent Tamura.
1547 Rename Position::node() to Position::deprecatedNode()
1548 https://bugs.webkit.org/show_bug.cgi?id=54622
1550 Replaced the call to node() by a call to containerNode() because the returned node is
1551 used to determine whether or not the selected contents are editable and such a check
1552 must be done against the container node.
1554 * WebCoreSupport/EditorClientQt.cpp:
1555 (WebCore::EditorClientQt::handleKeyboardEvent):
1557 2011-02-19 Charlie Reis <creis@chromium.org>
1559 Reviewed by Mihai Parparita.
1561 Ensure loading has stopped in HistoryController::goToItem
1562 https://bugs.webkit.org/show_bug.cgi?id=54517
1564 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
1566 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
1568 * WebCoreSupport/FrameLoaderClientQt.cpp:
1569 (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
1570 * WebCoreSupport/FrameLoaderClientQt.h:
1572 2011-02-18 Fabrizio Machado <fabrizio.machado@nokia.com>
1574 Reviewed by Eric Seidel.
1576 Remove reduntant checks.
1577 https://bugs.webkit.org/show_bug.cgi?id=54764
1580 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1581 (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
1582 * WebCoreSupport/NotificationPresenterClientQt.cpp:
1583 (WebCore::NotificationPresenterClientQt::toPage):
1585 2011-02-18 Csaba Osztrogonác <ossy@webkit.org>
1589 [Qt] Buildfix for platforms with geolocation disabled.
1591 * Api/qwebpage.cpp: Add the missing guard.
1593 2011-02-18 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
1595 Reviewed by Kenneth Rohde Christiansen.
1597 [Qt] Implement client based geolocation for qtport
1598 https://bugs.webkit.org/show_bug.cgi?id=42629
1600 Implements client based geolocation for qtwebkit.
1601 New client based geolocation contains permission API's as well,
1602 so removed the implementation from ChromeClientQt.cpp.
1605 (QWebPagePrivate::QWebPagePrivate):
1606 * WebCoreSupport/ChromeClientQt.cpp:
1607 * WebCoreSupport/ChromeClientQt.h:
1608 (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
1609 (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
1610 * WebCoreSupport/GeolocationClientQt.cpp: Added.
1611 (WebCore::GeolocationClientQt::GeolocationClientQt):
1612 (WebCore::GeolocationClientQt::~GeolocationClientQt):
1613 (WebCore::GeolocationClientQt::geolocationDestroyed):
1614 (WebCore::GeolocationClientQt::positionUpdated):
1615 (WebCore::GeolocationClientQt::startUpdating):
1616 (WebCore::GeolocationClientQt::stopUpdating):
1617 (WebCore::GeolocationClientQt::setEnableHighAccuracy):
1618 (WebCore::GeolocationClientQt::requestPermission):
1619 (WebCore::GeolocationClientQt::cancelPermissionRequest):
1620 * WebCoreSupport/GeolocationClientQt.h: Added.
1621 (WebCore::GeolocationClientQt::lastPosition):
1623 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
1625 Reviewed by Adam Roben.
1627 HTML5 <details> and <summary>: localized text
1628 https://bugs.webkit.org/show_bug.cgi?id=54260
1630 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
1631 provide the default label to be used by a <details> tag that has no <summary> child.
1633 * WebCoreSupport/WebPlatformStrategies.cpp:
1634 (WebPlatformStrategies::defaultDetailsSummaryText):
1635 * WebCoreSupport/WebPlatformStrategies.h:
1637 2011-02-17 Hui Huang <hui.2.huang@nokia.com>
1639 Reviewed by Laszlo Gombos.
1641 The URL of HTML5 Video Element is percent encoded at websites such as youtube.
1642 It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
1643 the HTTP GET request for the video to be rejected by the service provider.
1644 https://bugs.webkit.org/show_bug.cgi?id=53973.
1646 The bug is fixed by constructing QUrl from the encoded URL in
1647 MediaPlayerPrivateQt::commitLoad.
1649 New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
1650 HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
1651 is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
1652 A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
1653 is skipped if Qt Multimedia is not available.
1655 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1656 (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
1657 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1658 * tests/qwebpage/tst_qwebpage.cpp:
1659 (tst_QWebPage::loadHtml5Video):
1662 2011-02-17 Andreas Kling <kling@webkit.org>
1664 Reviewed by Antti Koivisto.
1666 [Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
1667 https://bugs.webkit.org/show_bug.cgi?id=49216
1669 * tests/qwebframe/tst_qwebframe.cpp:
1671 == Rolled over to ChangeLog-2011-02-16 ==