09cde597f0b26939f8595a9b66e0c9984ffa8eaf
[WebKit-https.git] / Source / WebKit / qt / ChangeLog
1 2011-04-11  Benjamin Poulain  <benjamin.poulain@nokia.com>
2
3         Reviewed by Andreas Kling.
4
5         [Qt] HTML5 Drag and Drop demos not working
6         https://bugs.webkit.org/show_bug.cgi?id=56486
7
8         Handling the drop with JavaScript was not working with Qt because if the action is ignored
9         in response to DragEnter, no further events are sent to the view.
10
11         Drag and drop is defined and used differently by webpages. The drag move events are determining
12         what action should take place. To adopt this behavior for Qt, we always accept drag enter events
13         on the widget.
14
15         * Api/qwebpage.cpp:
16         (QWebPagePrivate::dragEnterEvent):
17
18 2011-04-11  Andras Becsi  <abecsi@webkit.org>
19
20         Reviewed by Andreas Kling.
21
22         [Qt] REGRESSION(83122): tst_QWebElement::style() fails
23         https://bugs.webkit.org/show_bug.cgi?id=58032
24
25         According to the documentation of QWebElement the styleProperty method should
26         not respect style inheritance and other CSS rules for the InlineStyle enum.
27
28         r83122 fixed this behaviour.
29
30         * tests/qwebelement/tst_qwebelement.cpp:
31         (tst_QWebElement::style): Fix the expected color for QWebElement::InlineStyle.
32
33 2011-04-11  Andreas Kling  <andreas.kling@nokia.com>
34
35         Build fix after r83436.
36
37         * WebCoreSupport/FrameLoaderClientQt.cpp:
38         (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
39
40 2011-04-11  Andreas Kling  <andreas.kling@nokia.com>
41
42         Reviewed by Benjamin Poulain.
43
44         [Qt] dumpResourceResponseMIMETypes shouldn't strip URL query string.
45
46         * WebCoreSupport/FrameLoaderClientQt.cpp:
47         (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): Use KURL::lastPathComponent()
48         for the dumpResourceResponseMIMETypes display string instead of QFileInfo::fileName().
49         This is in line with the Mac port.
50
51 2011-04-08  Sheriff Bot  <webkit.review.bot@gmail.com>
52
53         Unreviewed, rolling out r83295.
54         http://trac.webkit.org/changeset/83295
55         https://bugs.webkit.org/show_bug.cgi?id=58144
56
57         Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
58
59         * WebCoreSupport/EditorClientQt.cpp:
60         (WebCore::EditorClientQt::handleInputMethodKeydown):
61
62 2011-04-08  Yi Shen  <yi.4.shen@nokia.com>
63
64         Reviewed by Antonio Gomes.
65
66         [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
67         https://bugs.webkit.org/show_bug.cgi?id=57472
68
69         Avoid to insert new line for both keydown event & keypress event.
70
71         * WebCoreSupport/EditorClientQt.cpp:
72         (WebCore::EditorClientQt::handleInputMethodKeydown):
73
74 2011-04-07  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
75
76         Reviewed by Benjamin Poulain.
77
78         [Qt] QWebFrame::setUrl works only from second time if url fragment is present
79         https://bugs.webkit.org/show_bug.cgi?id=32723
80
81         When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(),
82         use an invalid URL (the begin() without arguments). Clearing the document
83         with the same URL was causing problems when we had a fragment because it assume that
84         only scrolling was enough and did not loaded the document again.
85
86         When setUrl() is called but fails, url() is expected to return the requested value. The
87         begin(url) guaranteed that before. This patch adds a member to track the URL, which is
88         updated when the URL changes and also when setUrl() is called.
89
90         KURL was used for the member so that when setUrl() is called, and then url() is checked
91         before the page gets loaded, we perform the same conversion that will be performed by a
92         successful load, e.g. add trailing '/' to an address. This behavior is checked by
93         tst_QWebFrame::requestedUrl() test.
94
95         For the record: the second QWebPage::setUrl() worked because the load was considered a
96         FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was
97         needed. See FrameLoader::shouldScrollToAnchor() for details on this classification.
98
99         * Api/qwebframe.cpp:
100         (QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal.
101         (clearCoreFrame):
102         (isCoreFrameClear):
103         (QWebFrame::setUrl):
104         (QWebFrame::url):
105         (QWebFrame::baseUrl): look in the document for the baseURL since its contents can change
106         the baseURL, e.g. by using the <base> tag.
107         * Api/qwebframe_p.h:
108
109         * WebCoreSupport/FrameLoaderClientQt.cpp:
110         (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
111         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
112
113         * tests/qwebframe/tst_qwebframe.cpp:
114         (tst_QWebFrame::setUrlWithFragment): unskip test.
115
116 2011-04-07  Alexis Menard  <alexis.menard@openbossa.org>
117
118         Reviewed by Kenneth Rohde Christiansen.
119
120         Build fix when using Phonon as a backend for the multimedia support.
121
122         * WebCoreSupport/ChromeClientQt.cpp:
123         (WebCore::ChromeClientQt::ChromeClientQt):
124         (WebCore::ChromeClientQt::~ChromeClientQt):
125         * WebCoreSupport/ChromeClientQt.h:
126
127 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
128
129         Reviewed by Kenneth Rohde Christiansen.
130
131         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
132         https://bugs.webkit.org/show_bug.cgi?id=56086
133
134         Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
135         from the LayoutTestController.
136
137         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
138         (DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
139         * WebCoreSupport/DumpRenderTreeSupportQt.h:
140
141 2011-04-06  Anders Bakken  <agbakken@gmail.com>
142
143         Reviewed by Kenneth Rohde Christiansen.
144
145         [Qt] FrameLoaderClientQt.cpp has coding-style errors
146         https://bugs.webkit.org/show_bug.cgi?id=40254
147
148         * WebCoreSupport/FrameLoaderClientQt.cpp:
149         (drtDescriptionSuitableForTestResult):
150         (WebCore::FrameLoaderClientQt::hasWebView):
151         (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
152         (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
153         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
154         (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
155         (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
156         (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
157         (WebCore::FrameLoaderClientQt::postProgressStartedNotification):
158         (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
159         (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
160         (WebCore::FrameLoaderClientQt::willChangeTitle):
161         (WebCore::FrameLoaderClientQt::didChangeTitle):
162         (WebCore::FrameLoaderClientQt::finishedLoading):
163         (WebCore::FrameLoaderClientQt::frameLoadCompleted):
164         (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
165         (WebCore::FrameLoaderClientQt::didFinishLoad):
166         (WebCore::FrameLoaderClientQt::setTitle):
167         (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
168         (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
169         (WebCore::FrameLoaderClientQt::updateGlobalHistory):
170         (WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
171         (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem):
172         (WebCore::FrameLoaderClientQt::committedLoad):
173         (WebCore::FrameLoaderClientQt::download):
174         (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
175         (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
176         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
177         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
178         (WebCore::FrameLoaderClientQt::createFrame):
179         (WebCore::FrameLoaderClientQt::objectContentType):
180         (WebCore::FrameLoaderClientQt::createPlugin):
181
182 2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>
183
184         Reviewed by Andreas Kling.
185
186         [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
187         https://bugs.webkit.org/show_bug.cgi?id=57974
188
189         We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
190
191         No new tests needed, just a config flag rename.
192
193         * Api/qwebkitplatformplugin.h:
194         * WebCoreSupport/ChromeClientQt.cpp:
195         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
196         (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
197         * WebCoreSupport/FullScreenVideoQt.cpp:
198         (WebCore::FullScreenVideoQt::FullScreenVideoQt):
199         (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
200         (WebCore::FullScreenVideoQt::enterFullScreenForNode):
201         (WebCore::FullScreenVideoQt::exitFullScreenForNode):
202         (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
203         (WebCore::FullScreenVideoQt::isValid):
204         * WebCoreSupport/FullScreenVideoQt.h:
205         * WebCoreSupport/QtPlatformPlugin.cpp:
206         * WebCoreSupport/QtPlatformPlugin.h:
207         * examples/platformplugin/WebPlugin.cpp:
208         (WebPlugin::supportsExtension):
209         (WebPlugin::createExtension):
210         * examples/platformplugin/WebPlugin.h:
211         * examples/platformplugin/platformplugin.pro:
212         * examples/platformplugin/qwebkitplatformplugin.h:
213         * tests/qwebpage/tst_qwebpage.cpp:
214         (tst_QWebPage::loadHtml5Video):
215         * tests/tests.pri:
216
217 2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>
218
219         Reviewed by Andreas Kling.
220
221         [Qt] Implement fullscreen playback for the GStreamer backend.
222         https://bugs.webkit.org/show_bug.cgi?id=56826
223
224         Implement support for fullscreen playback when building the
225         Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
226         The implementation is done in FullScreenVideoQt alongside with
227         the Qt Multimedia support.
228
229         No new tests because layout tests cover it. They are not yet activated
230         but will be any time soon.
231
232         * QtWebKit.pro:
233         * WebCoreSupport/ChromeClientQt.cpp:
234         (WebCore::ChromeClientQt::ChromeClientQt):
235         (WebCore::ChromeClientQt::~ChromeClientQt):
236         (WebCore::ChromeClientQt::enterFullscreenForNode):
237         (WebCore::ChromeClientQt::exitFullscreenForNode):
238         * WebCoreSupport/ChromeClientQt.h:
239         * WebCoreSupport/FullScreenVideoQt.cpp:
240         (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
241         (WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
242         (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
243         (WebCore::GStreamerFullScreenVideoHandler::windowClosed):
244         (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
245         (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
246         (WebCore::FullScreenVideoQt::FullScreenVideoQt):
247         (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
248         (WebCore::FullScreenVideoQt::enterFullScreenForNode):
249         (WebCore::FullScreenVideoQt::exitFullScreenForNode):
250         (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
251         (WebCore::FullScreenVideoQt::isValid):
252         * WebCoreSupport/FullScreenVideoQt.h:
253         (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):
254
255 2011-04-06  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
256
257         Reviewed by Kenneth Rohde Christiansen.
258
259         [Qt] Improve tests for QWebFrame::url() and related methods
260         https://bugs.webkit.org/show_bug.cgi?id=57865
261
262         * tests/qwebframe/tst_qwebframe.cpp:
263         (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
264         (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
265         that fails and a load() that fails (for a different URL).
266
267         (tst_QWebFrame::setUrlWithFragment_data):
268         (tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
269         the URL in the frame before the test starts.
270
271         (tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
272         the same URL as argument.
273
274         (extractBaseUrl):
275         (tst_QWebFrame::setUrlThenLoads_data):
276         (tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
277         sequence of set and loads. Those tests are interesting because the properties
278         react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
279         is used or after the load() is committed and baseUrl() is similar to url() but also depends
280         on the contents of the page when it loads.
281
282 2011-04-04  MORITA Hajime  <morrita@google.com>
283
284         Reviewed by Ryosuke Niwa.
285
286         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
287         https://bugs.webkit.org/show_bug.cgi?id=56085
288         
289         * WebCoreSupport/EditorClientQt.h:
290         (WebCore::EditorClientQt::requestCheckingOfString):
291
292 2011-04-04  Chang Shu  <cshu@webkit.org>
293
294         Reviewed by Ryosuke Niwa.
295
296         setContentEditable with true/false/inherit string is not working properly
297         https://bugs.webkit.org/show_bug.cgi?id=52058
298
299         Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
300         as rendererIsEditable is for WebCore internal use.
301
302         * WebCoreSupport/EditorClientQt.cpp:
303         (WebCore::EditorClientQt::handleKeyboardEvent):
304
305 2011-04-01  Carol Szabo  <carol.szabo@nokia.com>
306
307         Reviewed by Benjamin Poulain.
308
309         Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
310         Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.
311
312         Tiled painting still causes synchronous layout when
313         accelerated compositing and texture mapper are enabled
314         https://bugs.webkit.org/show_bug.cgi?id=56929
315
316         * Api/qwebframe.cpp:
317         (QWebFramePrivate::renderFromTiledBackingStore):
318         (QWebFramePrivate::renderRelativeCoords):
319         (QWebFramePrivate::renderFrameWidgets):
320         * Api/qwebframe_p.h:
321
322 2011-04-01  Nancy Piedra  <nancy.piedra@nokia.com>
323
324         Reviewed by Benjamin Poulain.
325
326         [Qt] DragClientQt.h has coding-style errors
327         https://bugs.webkit.org/show_bug.cgi?id=40425
328
329         * WebCoreSupport/DragClientQt.h:
330
331 2011-03-31  Marius Storm-Olsen  <marius.storm-olsen@nokia.com>
332
333         Reviewed by Kenneth Rohde Christiansen.
334
335         [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
336         https://bugs.webkit.org/show_bug.cgi?id=57017
337
338         Build fix. No new tests.
339
340         * QtWebKit.pro:
341
342 2011-03-31  Evan Martin  <evan@chromium.org>
343
344         Another build fix.
345
346         * WebCoreSupport/FrameLoaderClientQt.cpp:
347         (WebCore::FrameLoaderClientQt::updateGlobalHistory):
348
349 2011-03-31  Nancy Piedra  <nancy.piedra@nokia.com>
350
351         Reviewed by Benjamin Poulain.
352
353         [Qt] ChromeClientQt.h has coding-style errors
354         https://bugs.webkit.org/show_bug.cgi?id=40239
355
356         * WebCoreSupport/ChromeClientQt.h:
357         (WebCore::ChromeClientQt::scrollbarsModeDidChange):
358         (WebCore::ChromeClientQt::needTouchEvents):
359         (WebCore::ChromeClientQt::formStateDidChange):
360         (WebCore::ChromeClientQt::scrollRectIntoView):
361         (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
362         (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
363
364 2011-03-31  Evan Martin  <evan@chromium.org>
365
366         Build fix from previous change.
367
368         * Api/qwebframe.cpp:
369         (QWebFrame::title):
370
371 2011-03-31  Evan Martin  <evan@chromium.org>
372
373         Reviewed by Eric Seidel.
374
375         <title> should support dir attribute
376         https://bugs.webkit.org/show_bug.cgi?id=50961
377
378         Update to new FrameLoaderClient interface.
379
380         * WebCoreSupport/FrameLoaderClientQt.cpp:
381         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
382         (WebCore::FrameLoaderClientQt::setTitle):
383         * WebCoreSupport/FrameLoaderClientQt.h:
384
385 2011-03-30  Yi Shen  <yi.4.shen@nokia.com>
386
387         Reviewed by Kenneth Rohde Christiansen.
388
389         [Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
390         https://bugs.webkit.org/show_bug.cgi?id=57020
391
392         Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().
393
394         * tests/qwebview/tst_qwebview.cpp:
395         (tst_QWebView::focusInputTypes):
396
397 2011-03-30  Robert Hogan  <robert@webkit.org>
398
399         Reviewed by Antonio Gomes.
400
401         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
402
403         Add DRT support for loading an alternate HTML string
404         for error pages. This allows Qt to unskip
405         http/tests/navigation/go-back-to-error-page.html.
406
407         https://bugs.webkit.org/show_bug.cgi?id=52614
408
409         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
410         (DumpRenderTreeSupportQt::setAlternateHtml):
411         * WebCoreSupport/DumpRenderTreeSupportQt.h:
412
413 2011-03-29  Alexis Menard  <alexis.menard@openbossa.org>
414
415         Unreviewed build fix for build-webkit -minimal.
416
417         Breakage introduced by http://trac.webkit.org/changeset/82238.
418         The minimal option has no support for shortcuts.
419
420         * WebCoreSupport/EditorClientQt.cpp:
421         (WebCore::EditorClientQt::handleInputMethodKeydown):
422
423 2011-03-29  Janne Koskinen  <janne.p.koskinen@digia.com>
424
425         Reviewed by Kenneth Rohde Christiansen.
426
427         [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
428         https://bugs.webkit.org/show_bug.cgi?id=33179
429
430         Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.
431
432         * WebCoreSupport/EditorClientQt.cpp:
433         (WebCore::EditorClientQt::handleInputMethodKeydown):
434         * tests/qwebpage/tst_qwebpage.cpp:
435         (tst_QWebPage::inputMethods):
436
437 2011-03-29  Andreas Kling  <kling@webkit.org>
438
439         Reviewed by Simon Hausmann.
440
441         [Qt] Fix documentation for QWebPage::repaintRequested()
442
443         This signal is always emitted when the page is dirtied, so remove
444         reference to old behavior where we would only emit the signal for
445         headless QWebPages.
446
447         * Api/qwebpage.cpp:
448
449 2011-03-28  Andreas Kling  <kling@webkit.org>
450
451         Reviewed by Benjamin Poulain.
452
453         [Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.
454
455         * WebCoreSupport/FrameLoaderClientQt.cpp:
456         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
457
458 2011-03-28  Andreas Kling  <kling@webkit.org>
459
460         Reviewed by Benjamin Poulain.
461
462         [Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
463         https://bugs.webkit.org/show_bug.cgi?id=52629
464
465         * WebCoreSupport/ChromeClientQt.cpp:
466         (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
467         QWebPage::repaintRequested() use a Qt::QueuedConnection.
468
469         * tests/qwebpage/tst_qwebpage.cpp:
470         (RepaintRequestedRenderer::RepaintRequestedRenderer):
471         (RepaintRequestedRenderer::onRepaintRequested):
472         (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
473         QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
474         doesn't cause recursive signal emissions.
475
476 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
477
478         Reviewed by Andreas Kling.
479
480         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
481         https://bugs.webkit.org/show_bug.cgi?id=57087
482
483         * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
484         * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
485         since they are applications, not libraries.
486
487 2011-03-28  Andras Becsi  <abecsi@webkit.org>
488
489         Reviewed by Csaba Osztrogonác.
490
491         [Qt] QtWebKit does not link with --3d-canvas using MinGW
492         https://bugs.webkit.org/show_bug.cgi?id=57225
493
494         * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
495
496 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
497
498         Reviewed by Andreas Kling.
499
500         REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
501         https://bugs.webkit.org/show_bug.cgi?id=57183
502
503         Windows buildfix after r82065.
504
505         * Api/DerivedSources.pro: Readding escaping on Windows platforms.
506
507 2011-03-27  Andreas Kling  <kling@webkit.org>
508
509         Fix build warning about IconDatabaseClient.h (wrong path.)
510
511         * QtWebKit.pro:
512
513 2011-03-27  Andreas Kling  <kling@webkit.org>
514
515         Reviewed by Kenneth Rohde Christiansen.
516
517         [Qt] Support for CSS color and background-color properties on select element's dropdown list
518         https://bugs.webkit.org/show_bug.cgi?id=51627
519
520         Extend the QWebSelectData interface with background and foreground colors
521         for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
522         getters in RenderMenuList.
523
524         * Api/qwebkitplatformplugin.h:
525         * WebCoreSupport/PopupMenuQt.cpp:
526         (SelectData::backgroundColor):
527         (SelectData::foregroundColor):
528         (SelectData::itemBackgroundColor):
529         (SelectData::itemForegroundColor):
530         * WebCoreSupport/QtFallbackWebPopup.cpp:
531         (WebCore::QtFallbackWebPopup::show):
532         (WebCore::QtFallbackWebPopup::populate):
533
534 2011-03-27  Yi Shen  <yi.4.shen@nokia.com>
535
536         Reviewed by Andreas Kling.
537
538         [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
539         https://bugs.webkit.org/show_bug.cgi?id=57108
540
541         Since the canvas is not self-closing tag, we need to add '</canvas>'. 
542
543         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
544         (tst_QGraphicsWebView::microFocusCoordinates):
545         * tests/qwebview/tst_qwebview.cpp:
546         (tst_QWebView::microFocusCoordinates):
547
548 2011-03-27  Kwang Yul Seo  <skyul@company100.net>
549
550         Reviewed by Eric Seidel.
551
552         [Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
553         https://bugs.webkit.org/show_bug.cgi?id=57143
554
555         Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
556         define WTF_USE_TEXTURE_MAPPER=1.
557
558         * QtWebKit.pro:
559
560 2011-03-27  Andreas Kling  <kling@webkit.org>
561
562         Reviewed by Benjamin Poulain.
563
564         REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
565         https://bugs.webkit.org/show_bug.cgi?id=57183
566
567         The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
568         which was due to the outputting code previously being wrapped in eval().
569
570         * Api/DerivedSources.pro:
571
572 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
573
574         Reviewed by Andreas Kling.
575
576         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
577         https://bugs.webkit.org/show_bug.cgi?id=57087
578
579         Use explicit conversion for string to avoid depending on the default codec
580         installed by the user code.
581
582         * Api/qwebkitversion.cpp:
583         (qWebKitVersion):
584         * Api/qwebpage.cpp:
585         (QWebPagePrivate::dynamicPropertyChangeEvent):
586         (QWebPage::javaScriptConsoleMessage):
587         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
588         (convertToPropertyName):
589         (DumpRenderTreeSupportQt::setEditingBehavior):
590         (DumpRenderTreeSupportQt::plainText):
591         * WebCoreSupport/EditorClientQt.cpp:
592         (dumpRange):
593         * WebCoreSupport/FrameLoaderClientQt.cpp:
594         (drtDescriptionSuitableForTestResult):
595         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
596         * WebCoreSupport/InspectorClientQt.cpp:
597         (WebCore::InspectorClientQt::openInspectorFrontend):
598         * WebCoreSupport/InspectorServerQt.cpp:
599         (WebCore::parseWebSocketChallengeNumber):
600         (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
601
602 2011-03-26  Andreas Kling  <kling@webkit.org>
603
604         Reviewed by Kenneth Rohde Christiansen.
605
606         [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
607         https://bugs.webkit.org/show_bug.cgi?id=57157
608
609         Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
610         is always emitted when appropriate.
611
612         * QtWebKit.pro: Add new files.
613
614         * WebCoreSupport/IconDatabaseClientQt.h: Added.
615         * WebCoreSupport/IconDatabaseClientQt.cpp: Added.
616         (WebCore::IconDatabaseClientQt::instance):
617         (WebCore::IconDatabaseClientQt::IconDatabaseClientQt):
618         (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt):
619         (WebCore::IconDatabaseClientQt::performImport):
620         (WebCore::IconDatabaseClientQt::didRemoveAllIcons):
621         (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL):
622         (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL):
623         (WebCore::IconDatabaseClientQt::didChangeIconForPageURL):
624         (WebCore::IconDatabaseClientQt::didFinishURLImport):
625
626         * WebCoreSupport/FrameLoaderClientQt.h:
627         * WebCoreSupport/FrameLoaderClientQt.cpp:
628         (WebCore::FrameLoaderClientQt::registerForIconNotification):
629         (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected
630         to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the
631         QWebFrame::iconChanged() signal when the IconDatabases finishes loading
632         a cached favicon for the frame's URL.
633
634         * Api/qwebsettings.cpp:
635         (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is
636         instantiated. An IconDatabaseClient has to be registered before the IconDatabase
637         spawns its reader thread.
638
639 2011-03-25  Andy Estes  <aestes@apple.com>
640
641         Reviewed by Adele Peterson.
642
643         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
644         https://bugs.webkit.org/show_bug.cgi?id=49016
645
646         Update objectContentType() implementation to handle the
647         shouldPreferPlugInsForImages flag.
648
649         * WebCoreSupport/FrameLoaderClientQt.cpp:
650         (WebCore::FrameLoaderClientQt::objectContentType):
651         * WebCoreSupport/FrameLoaderClientQt.h:
652
653 2011-03-25  Chang Shu  <cshu@webkit.org>
654
655         Reviewed by Ryosuke Niwa.
656
657         rename Node::isContentEditable and all call sites to rendererIsEditable
658         https://bugs.webkit.org/show_bug.cgi?id=54290
659
660         This is part of the effort to separate JS API HTMLElement isContentEditable from
661         internal Node::rendererIsEditable.
662
663         * WebCoreSupport/EditorClientQt.cpp:
664         (WebCore::EditorClientQt::handleKeyboardEvent):
665
666 2011-03-25  Alexis Menard  <alexis.menard@openbossa.org>
667
668         Reviewed by Andreas Kling.
669
670         [Qt] The keyboard shortcuts during fullscreen playback do not work.
671         https://bugs.webkit.org/show_bug.cgi?id=57095
672
673         We need to explicitely set the focus on the widget in order to receive the keyboard events.
674
675         * WebCoreSupport/FullScreenVideoWidget.cpp:
676         (WebCore::FullScreenVideoWidget::show):
677
678 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
679
680         Unreviewed, rolling out r81916 and r81917.
681         http://trac.webkit.org/changeset/81916
682         http://trac.webkit.org/changeset/81917
683         https://bugs.webkit.org/show_bug.cgi?id=57071
684
685         broke a test on platforms that do not have QuickTime installed
686         (Requested by estes on #webkit).
687
688         * WebCoreSupport/FrameLoaderClientQt.cpp:
689         (WebCore::FrameLoaderClientQt::objectContentType):
690         * WebCoreSupport/FrameLoaderClientQt.h:
691
692 2011-03-24  Andy Estes  <aestes@apple.com>
693
694         Reviewed by Darin Adler.
695
696         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
697         https://bugs.webkit.org/show_bug.cgi?id=49016
698
699         Update objectContentType() implementation to handle the
700         shouldPreferPlugInsForImages flag.
701
702         * WebCoreSupport/FrameLoaderClientQt.cpp:
703         (WebCore::FrameLoaderClientQt::objectContentType):
704         * WebCoreSupport/FrameLoaderClientQt.h:
705
706 2011-03-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
707
708         Reviewed by Kenneth Rohde Christiansen.
709
710         [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
711         https://bugs.webkit.org/show_bug.cgi?id=40884
712
713         Add tests and benchmarks for the software fallback of WebGL.
714
715         * tests/benchmarks/webgl/10000_triangles.html: Added.
716         * tests/benchmarks/webgl/tst_webgl.cpp: Added.
717         (GraphicsView::GraphicsView):
718         (GraphicsView::resizeEvent):
719         (tst_WebGlPerformance::init):
720         (tst_WebGlPerformance::cleanup):
721         (tst_WebGlPerformance::benchSoftwareFallbackRgb16):
722         (tst_WebGlPerformance::benchSoftwareFallbackRgb32):
723         (tst_WebGlPerformance::benchSoftwareFallbackArgb32):
724         (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
725         (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
726         * tests/benchmarks/webgl/tst_webgl.qrc: Added.
727         * tests/benchmarks/webgl/webgl.pro: Added.
728         * tests/qgraphicswebview/qgraphicswebview.pro:
729         * tests/qgraphicswebview/resources/pointing_right.html: Added.
730         * tests/qgraphicswebview/resources/pointing_up.html: Added.
731         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
732         (compareImagesFuzzyPixelCount):
733         (GraphicsView::GraphicsView):
734         (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
735         (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
736         (tst_QGraphicsWebView::compareCanvasToImage):
737         * tests/qgraphicswebview/tst_qgraphicswebview.qrc:
738         * tests/tests.pro:
739
740 2011-03-24  Kristian Amlie  <kristian.amlie@nokia.com>
741
742         Reviewed by Benjamin Poulain.
743
744         Avoided ASCII-cast warnings for WebKit.
745
746         Normally they won't be enabled anyway, but if you build webkit from
747         within the Qt mother repository it will pick up Qt's default build
748         settings, which do enable it. We need to disable them because
749         warnings are treated as errors and there are way too many of them in
750         the WebKit code.
751
752         [Qt] Avoid ASCII-cast warnings for WebKit.
753         https://bugs.webkit.org/show_bug.cgi?id=57016
754
755         * QtWebKit.pro:
756
757 2011-03-24  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
758
759         Reviewed by Benjamin Poulain.
760
761         [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
762         https://bugs.webkit.org/show_bug.cgi?id=29595
763
764         Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
765         ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
766         prepending the current directory.
767
768         By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
769         will end up loading "about:blank", but keeping it as a requested URL.
770
771         This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
772         is filled for the loaded URLs as well, we can use it in every case.
773
774         Three new autotests were added, to better cover the expected behavior of setting
775         the QUrl() in a QWebFrame.
776
777         * Api/qwebframe.cpp:
778         (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
779         (QWebFrame::requestedUrl): always use m_lastRequestedUrl.
780
781         * WebCoreSupport/FrameLoaderClientQt.cpp:
782         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
783         anymore, since we always rely on it even for loaded frames.
784
785         * tests/qwebframe/tst_qwebframe.cpp:
786         (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
787         the reduction of the bug report.
788         (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
789         (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
790
791 2011-03-23  Brady Eidson  <beidson@apple.com>
792
793         Reviewed by Sam Weinig.
794
795         Change IconDatabase opening to allow for arbitrary filenames
796         https://bugs.webkit.org/show_bug.cgi?id=56977
797
798         * Api/qwebsettings.cpp:
799         (QWebSettings::setIconDatabasePath):
800
801 2011-03-23  Aparna Nandyal  <aparna.nand@wipro.com>
802
803         Reviewed by Andreas Kling.
804
805         [Qt] QtWebKit rendering problem when maximizing and doing a back
806         https://bugs.webkit.org/show_bug.cgi?id=56669
807
808         Added an auto test.
809         Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21
810  
811         * tests/qwebview/tst_qwebview.cpp:
812         (tst_QWebView::rendering):
813
814 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
815
816         Reviewed by Pavel Feldman.
817
818         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
819         https://bugs.webkit.org/show_bug.cgi?id=56843
820
821         * WebCoreSupport/InspectorClientQt.cpp:
822         (WebCore::InspectorClientQt::openInspectorFrontend):
823
824 2011-03-22  Andrew Wason  <rectalogic@rectalogic.com>
825
826         Reviewed by Benjamin Poulain.
827
828         [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
829         https://bugs.webkit.org/show_bug.cgi?id=54138
830
831         * tests/qwebpage/tst_qwebpage.cpp:
832         (webGLScreenshotWithoutView):
833         (tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
834         (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
835          Render a QWebPage (with and without accelerated compositing)
836          with a WebGL context that has no owning view.  Shouldn't crash.
837
838 2011-03-21  Chang Shu  <cshu@webkit.org>
839
840         Reviewed by Alexey Proskuryakov.
841
842         REGRESSION (r79953): Can't type in MS Outlook 2011
843         https://bugs.webkit.org/show_bug.cgi?id=56665
844
845         r79953 removed the WebView level editablity which is persistent no matter whether
846         underlying document itself is changed and editability gets lost. The resolution is to
847         set this WebView editable value to WebCore. This avoids the callback from WebCore to
848         WebKit which was the main goal in r79953 to improve performance.
849
850         * Api/qwebpage.cpp:
851         (QWebPage::setContentEditable):
852         (QWebPage::isContentEditable):
853
854 2011-03-19  Andreas Kling  <kling@webkit.org>
855
856         Reviewed by Benjamin Poulain.
857
858         [Qt] Remove support for Qt 4.6
859         https://bugs.webkit.org/show_bug.cgi?id=56712
860
861         * Api/qwebframe.cpp:
862         (QWebFrame::load):
863         * Api/qwebpage.cpp:
864         (QWebPagePrivate::QWebPagePrivate):
865         * Api/qwebsettings.cpp:
866         (QWebSettings::QWebSettings):
867         * WebCoreSupport/GeolocationClientQt.cpp:
868         (WebCore::GeolocationClientQt::positionUpdated):
869
870 2011-03-19  Andreas Kling  <kling@webkit.org>
871
872         Reviewed by Antonio Gomes.
873
874         [Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
875         https://bugs.webkit.org/show_bug.cgi?id=56711
876
877         Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
878         ownership of the reply is transferred to the receiving slot.
879
880         * Api/qwebpage.cpp:
881
882 2011-03-17  Brady Eidson  <beidson@apple.com>
883
884         Reviewed by Sam Weinig.
885
886         https://bugs.webkit.org/show_bug.cgi?id=56425
887         More groundwork for WebKit2 IconDatabase
888
889         Update already-used function names:
890         * Api/qwebhistory.cpp:
891         (QWebHistoryItem::icon):
892         * Api/qwebsettings.cpp:
893         (QWebSettings::iconForUrl):
894
895 2011-03-18  Alexis Menard  <alexis.menard@openbossa.org>
896
897         Reviewed by Benjamin Poulain.
898
899         [Qt] console.log not being exposed to QmlViewer
900         https://bugs.webkit.org/show_bug.cgi?id=56536
901
902         The documentation is bogus the feature does not exist.
903
904         * declarative/qdeclarativewebview.cpp:
905
906 2011-03-17  Andreas Kling  <kling@webkit.org>
907
908         Reviewed by Kenneth Rohde Christiansen.
909
910         [Qt] QML WebView emits iconChanged() when the page title changes
911         https://bugs.webkit.org/show_bug.cgi?id=56570
912
913         * declarative/qdeclarativewebview.cpp:
914         (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
915         signal to the view's iconChanged signal.
916
917 2011-03-17  Alexis Menard  <alexis.menard@openbossa.org>
918
919         Reviewed by Benjamin Poulain.
920
921         [Qt] Videos look ugly when using QGraphicsWebView.
922         https://bugs.webkit.org/show_bug.cgi?id=56580
923
924         We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
925         QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
926         by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
927         QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
928         ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
929         in addition of what could be set on the painter. In order to not break the rendering of all the items in the
930         scene we set back the painter to its original state when QGraphicsWebView is rendered.
931
932         * Api/qgraphicswebview.cpp:
933         (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
934         (QGraphicsWebView::paint):
935         (QGraphicsWebView::renderHints):
936         (QGraphicsWebView::setRenderHints):
937         (QGraphicsWebView::setRenderHint):
938         * Api/qgraphicswebview.h:
939         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
940         (tst_QGraphicsWebView::renderHints):
941
942 2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>
943
944         Reviewed by Kenneth Rohde Christiansen.
945
946         Viewport no longer allows an auto value for "user-scalable"
947         https://bugs.webkit.org/show_bug.cgi?id=55416
948
949         Make the default value for userScalable be true.
950
951         * Api/qwebpage.cpp:
952         (QWebPage::viewportAttributesForSize):
953         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
954         (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.
955
956 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
957
958         Reviewed by Darin Adler.
959
960         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
961         info into the headers rather than in export symbol definition files, but disable it on 
962         all platforms initially so we can deal with port build issues one port at a time.
963         
964         https://bugs.webkit.org/show_bug.cgi?id=27551
965
966         * WebCoreSupport/GeolocationClientQt.cpp:
967         * WebCoreSupport/PopupMenuQt.cpp:
968
969 2011-03-14  Brady Eidson  <beidson@apple.com>
970
971         Reviewed by Anders Carlsson.
972
973         https://bugs.webkit.org/show_bug.cgi?id=56320
974         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
975
976         * Api/qwebhistory.cpp:
977         (QWebHistoryItem::icon): Use IconDatabase directly.
978
979 2011-03-11  Brady Eidson  <beidson@apple.com>
980
981         Reviewed by attempt at build fix!
982
983         https://bugs.webkit.org/show_bug.cgi?id=56216
984         Fix the Qt build following the same pattern of the patch.
985
986         * Api/qwebsettings.cpp:
987         (QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
988
989 2011-03-11  Alexis Menard  <alexis.menard@openbossa.org>
990
991         Reviewed by Ariya Hidayat.
992
993         [Qt] Entering fullscreen and leaving it may hide the cursor of the application.
994         https://bugs.webkit.org/show_bug.cgi?id=56181
995
996         We need to stop the auto hide cursor timer when closing the widget otherwise the timer
997         might get fired and therefore hide the cursor even when the fullscreen widget is closed.
998
999         * WebCoreSupport/FullScreenVideoWidget.cpp:
1000         (WebCore::FullScreenVideoWidget::closeEvent):
1001
1002 2011-03-10  David Boddie <david.boddie@nokia.com>
1003
1004         Reviewed by Andreas Kling.
1005
1006         Fixed a qdoc warning and terminology (WebKit instead of Webkit).
1007         https://bugs.webkit.org/show_bug.cgi?id=55756
1008
1009         * Api/qwebhistoryinterface.cpp:
1010
1011 2011-03-10  Andreas Kling  <kling@webkit.org>
1012
1013         Unreviewed build fix after r80774.
1014
1015         QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
1016         See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451
1017
1018         * declarative/plugin.cpp:
1019         (WebKitQmlPlugin::registerTypes):
1020         * declarative/qdeclarativewebview.cpp:
1021         * declarative/qdeclarativewebview_p.h:
1022         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
1023
1024 2011-03-10  Alexis Menard  <alexis.menard@openbossa.org>
1025
1026         Reviewed by Andreas Kling.
1027
1028         [Qt] QtDeclarative Webview element has a fixed white background
1029         https://bugs.webkit.org/show_bug.cgi?id=40918
1030
1031         Implement a way to change the background color of the WebView QML element.
1032         This feature is activated for QtWebKit 1.1 version of the plugin.
1033
1034         * declarative/plugin.cpp:
1035         (WebKitQmlPlugin::registerTypes):
1036         * declarative/qdeclarativewebview.cpp:
1037         (QDeclarativeWebView::backgroundColor):
1038         (QDeclarativeWebView::setBackgroundColor):
1039         * declarative/qdeclarativewebview_p.h:
1040         * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
1041         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
1042         (tst_QDeclarativeWebView::backgroundColor):
1043         * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
1044
1045 2011-03-10  Stanislav Paltis  <Stanislav.Paltis@nokia.com>
1046
1047         Reviewed by Laszlo Gombos.
1048
1049         [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
1050         https://bugs.webkit.org/show_bug.cgi?id=55945
1051         
1052         Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to 
1053         set interval used to trigger when decoded data in dead list of object cache will 
1054         be purged from object cache. 
1055
1056         * Api/qwebpage.cpp:
1057         (QWebPagePrivate::dynamicPropertyChangeEvent):
1058
1059 2011-03-10  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1060
1061         Reviewed by Antonio Gomes.
1062
1063         Simplify how QWebFrame::requestedUrl() is obtained
1064         https://bugs.webkit.org/show_bug.cgi?id=55842
1065
1066         When a load starts, store the requested URL until we know that it'll be
1067         available for us in the document loader -- after load finished.
1068
1069         The existing auto tests cover the three different code paths in
1070         requestedUrl() and the new code passes the autotests. In each of those
1071         cases, we looked for the information in a different place, but in all
1072         of them, dispatchDidStartProvisionalLoad was called.
1073
1074         This simplification will be useful to fix bug 32723. The way requestedUrl()
1075         is implementent, we can't use it as a fallback for url() when the setUrl()
1076         was called with an invalid URL.
1077
1078         * Api/qwebframe.cpp:
1079         (QWebFrame::requestedUrl):
1080         * WebCoreSupport/FrameLoaderClientQt.cpp:
1081         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
1082         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
1083         * WebCoreSupport/FrameLoaderClientQt.h:
1084         (WebCore::FrameLoaderClientQt::lastRequestedUrl):
1085
1086 2011-03-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1087
1088         Reviewed by Kenneth Rohde Christiansen.
1089
1090         Tiled backing store's delegated scroll request uses incorrect convention
1091         https://bugs.webkit.org/show_bug.cgi?id=56011
1092
1093         Adapt internal API to match the change from delta to point on the
1094         WebCore side, and convert the point to a delta for the public API.
1095
1096         * WebCoreSupport/ChromeClientQt.cpp:
1097         (WebCore::ChromeClientQt::delegatedScrollRequested):
1098         * WebCoreSupport/ChromeClientQt.h:
1099
1100 2011-03-09  Peter Kasting  <pkasting@google.com>
1101
1102         Reviewed by Mihai Parparita.
1103
1104         Unify Windows version checks.
1105         https://bugs.webkit.org/show_bug.cgi?id=55979
1106
1107         * Api/qwebpage.cpp:
1108         (QWebPage::userAgentForUrl):
1109
1110 2011-03-07  Sam Weinig  <sam@webkit.org>
1111
1112         Reviewed by Anders Carlsson.
1113
1114         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1115         https://bugs.webkit.org/show_bug.cgi?id=55827
1116
1117         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
1118         and pass the entire response, instead of just the MIMEType.
1119
1120         * WebCoreSupport/FrameLoaderClientQt.cpp:
1121         (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
1122         * WebCoreSupport/FrameLoaderClientQt.h:
1123
1124 2011-03-05  Qi Zhang  <qi.2.zhang@nokia.com>
1125
1126         Reviewed by Laszlo Gombos.
1127
1128         [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
1129         https://bugs.webkit.org/show_bug.cgi?id=48636
1130
1131         Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
1132
1133         * Api/qwebpage.cpp:
1134         (QWebPage::userAgentForUrl):
1135
1136 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1137
1138         Reviewed by Kenneth Rohde Christiansen.
1139
1140         [QT] Implement mock client-based geolocation for layout testing
1141         https://bugs.webkit.org/show_bug.cgi?id=54334
1142
1143         Implement layout testing for Client-Based geolocation. If drt_run is set 
1144         then create mock geolocationClient and update the same with controller.
1145
1146         * Api/qwebpage.cpp:
1147         (QWebPagePrivate::QWebPagePrivate):
1148         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1149         (DumpRenderTreeSupportQt::mockGeolocationReset):
1150         (DumpRenderTreeSupportQt::setMockGeolocationPermission):
1151         (DumpRenderTreeSupportQt::setMockGeolocationPosition):
1152         (DumpRenderTreeSupportQt::setMockGeolocationError):
1153         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1154         * WebCoreSupport/GeolocationClientQt.cpp:
1155         (WebCore::GeolocationClientQt::GeolocationClientQt):
1156         * WebCoreSupport/GeolocationClientQt.h:
1157
1158 2011-03-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1159
1160         Reviewed by Kenneth Rohde Christiansen.
1161
1162         [Qt] QWebFrame::setUrl works only from second time if url fragment is present
1163         https://bugs.webkit.org/show_bug.cgi?id=32723
1164
1165         Create an auto-test for Qt based on the bug description.
1166
1167         * tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
1168
1169 2011-03-03  Brady Eidson  <beidson@apple.com>
1170
1171         Reviewed by Darin Adler.
1172
1173         https://bugs.webkit.org/show_bug.cgi?id=55721
1174         Global IconDatabase should be returned by reference, not as a pointer
1175
1176         * Api/qwebsettings.cpp:
1177         (QWebSettings::setIconDatabasePath):
1178         (QWebSettings::iconDatabasePath):
1179         (QWebSettings::clearIconDatabase):
1180         (QWebSettings::iconForUrl):
1181
1182 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
1183
1184         Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
1185         via ChromeClient.h
1186
1187         * WebCoreSupport/ChromeClientQt.h:
1188
1189 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
1190
1191         Reviewed by Darin Adler.
1192
1193         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
1194         https://bugs.webkit.org/show_bug.cgi?id=55633
1195         <rdar://problem/8963023>
1196
1197         * WebCoreSupport/ChromeClientQt.cpp (WebCore::ChromeClientQt::keyboardUIMode):
1198         * WebCoreSupport/ChromeClientQt.h:
1199         Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
1200         this platform doesn't observe or have full keyboard access state.
1201
1202 2011-03-03  Alexis Menard  <alexis.menard@openbossa.org>
1203
1204         Reviewed by Andreas Kling.
1205
1206         [Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
1207         https://bugs.webkit.org/show_bug.cgi?id=55568
1208
1209         We should use updateMicroFocus() from QGraphicsItem rather than the implementation
1210         in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
1211         In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
1212         in QGraphicsItem.
1213
1214         * Api/qgraphicswebview.cpp:
1215         (QGraphicsWebView::setPage):
1216         * Api/qgraphicswebview.h:
1217
1218 2011-03-03  Peter Kasting  <pkasting@google.com>
1219
1220         Reviewed by James Robinson.
1221
1222         Drop redundant "Windows; " from the Windows-specific User Agent string.
1223         https://bugs.webkit.org/show_bug.cgi?id=54567
1224
1225         * Api/qwebpage.cpp:
1226         (QWebPage::userAgentForUrl):
1227
1228 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
1229
1230         Reviewed by Adam Roben.
1231
1232         Part of WebKit2: Need a way to send notifications to client when cookies change
1233         https://bugs.webkit.org/show_bug.cgi?id=55427
1234         <rdar://problem/9056027>
1235         
1236         Add stubs for CookiesStrategy on Qt WebKit1.
1237
1238         * WebCoreSupport/WebPlatformStrategies.cpp:
1239         (WebPlatformStrategies::createCookiesStrategy):
1240         (WebPlatformStrategies::notifyCookiesChanged):
1241         * WebCoreSupport/WebPlatformStrategies.h:
1242
1243 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
1244
1245         Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
1246
1247         * Api/qwebpage.cpp:
1248         (QWebPage::viewportAttributesForSize):
1249         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1250         (DumpRenderTreeSupportQt::viewportAsText):
1251
1252 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
1253
1254         Reviewed by Kenneth Rohde Christiansen.
1255
1256         Viewport Warning/Error Messages Are Now Inaccurate
1257         https://bugs.webkit.org/show_bug.cgi?id=53707
1258
1259         * Api/qwebpage.cpp:
1260         (QWebPage::viewportAttributesForSize): pass a Document into computeViewportAttributes for warnings to be reported to.
1261         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1262         (DumpRenderTreeSupportQt::viewportAsText): pass a Document into computeViewportAttributes for warnings to be reported to.
1263
1264 2011-03-01  Andras Becsi  <abecsi@webkit.org>
1265
1266         Reviewed by Csaba Osztrogonác.
1267
1268         [Qt] Clean up the project files and move common options to WebKit.pri.
1269
1270         * QtWebKit.pro: Move common options to WebKit.pri.
1271
1272 2011-03-01  Aparna Nandyal  <aparna.nand@wipro.com>
1273
1274         Reviewed by Simon Hausmann.
1275
1276         [Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
1277         https://bugs.webkit.org/show_bug.cgi?id=55319
1278
1279         The test case required internet connection to be able to connect to
1280         google.com. Added new html file which refers to local html file.
1281
1282         * tests/qwebpage/resources/content.html: Added.
1283         * tests/qwebpage/resources/frame_c.html: Added.
1284         * tests/qwebpage/resources/framedindex.html: Added.
1285         * tests/qwebpage/tst_qwebpage.cpp:
1286         (tst_QWebPage::backActionUpdate):
1287         * tests/qwebpage/tst_qwebpage.qrc:
1288
1289 2011-02-25 Steve Block <steveblock@google.com>
1290
1291         Reviewed by Jeremy Orlow.
1292
1293         Bridge.h should not include BridgeJSC.h
1294         https://bugs.webkit.org/show_bug.cgi?id=55212
1295
1296         Include BridgeJSC.h directly instead.
1297
1298         * Api/qwebframe.cpp:
1299
1300 2011-02-28  Chang Shu  <cshu@webkit.org>
1301
1302         Reviewed by Ryosuke Niwa.
1303
1304         Remove the support of Frame::isContentEditable and its dependencies.
1305         https://bugs.webkit.org/show_bug.cgi?id=54292
1306
1307         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
1308
1309         * Api/qwebpage.cpp:
1310         (QWebPagePrivate::QWebPagePrivate):
1311         (QWebPage::setContentEditable):
1312         (QWebPage::isContentEditable):
1313         * Api/qwebpage_p.h:
1314         * WebCoreSupport/EditorClientQt.cpp:
1315         * WebCoreSupport/EditorClientQt.h:
1316
1317 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
1318
1319         Reviewed by Oliver Hunt.
1320
1321         Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
1322
1323         * Api/qwebelement.cpp:
1324         (QWebElement::evaluateJavaScript):
1325
1326 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
1327
1328         Reviewed by Andreas Kling.
1329
1330         [Qt]tst_QDeclarativeWebView - 8 test cases fail
1331         https://bugs.webkit.org/show_bug.cgi?id=55214
1332
1333         Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
1334         if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
1335         I also refactored the tests so we don't use the network but instead a local html file.
1336         QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.
1337
1338         * tests/qdeclarativewebview/resources/sample.html: Added.
1339         * tests/qdeclarativewebview/resources/webviewtest.qml:
1340         * tests/qdeclarativewebview/resources/webviewtestdefault.qml:
1341         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
1342         (tst_QDeclarativeWebView::preferredWidthTest):
1343         (tst_QDeclarativeWebView::preferredHeightTest):
1344         (tst_QDeclarativeWebView::preferredWidthDefaultTest):
1345         (tst_QDeclarativeWebView::preferredHeightDefaultTest):
1346         * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
1347
1348 2011-02-28  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1349
1350         Reviewed by Andreas Kling.
1351
1352         [Qt] Add clipped version of QWebElement::render method.
1353         Allows faster rendering of web element part.
1354         https://bugs.webkit.org/show_bug.cgi?id=50311
1355
1356         * Api/qwebelement.cpp:
1357         (QWebElement::render):
1358         * Api/qwebelement.h:
1359         * tests/qwebelement/tst_qwebelement.cpp:
1360         (tst_QWebElement::render):
1361
1362 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
1363
1364         Reviewed by Andreas Kling.
1365
1366         Added full webkit module profile and a syncqt profile.
1367
1368         This is for modularized Qt.
1369
1370         [Qt] WebKit patches required to work with a modularized version of Qt
1371         https://bugs.webkit.org/show_bug.cgi?id=53916
1372
1373         * qt_webkit_version.pri:
1374
1375 2011-02-27  Aparna Nandyal  <aparna.nand@wipro.com>
1376
1377         Reviewed by Antonio Gomes.
1378
1379         [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
1380         https://bugs.webkit.org/show_bug.cgi?id=53917
1381
1382         Adding test case to check the scenario to avoid regressions in the
1383         future. 
1384
1385         * tests/qwebframe/tst_qwebframe.cpp:
1386
1387 2011-02-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1388
1389         Reviewed by Andreas Kling.
1390
1391         [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
1392         https://bugs.webkit.org/show_bug.cgi?id=55322
1393
1394         Documentation update, add a reference to the QtWebKit bridge page.
1395
1396         * Api/qwebframe.cpp:
1397
1398 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
1399
1400         Reviewed by Pavel Feldman.
1401
1402         DumpRenderTree should reset frame opener between tests.
1403         https://bugs.webkit.org/show_bug.cgi?id=54874
1404
1405         Added clearOpener method to DumpRenderTreeSupportQT.
1406
1407         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1408         (DumpRenderTreeSupportQt::clearOpener):
1409         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1410
1411 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1412
1413         Reviewed by Andreas Kling.
1414
1415         Make it possible to test the targetdensity-dpi support
1416         https://bugs.webkit.org/show_bug.cgi?id=55142
1417
1418         Test the viewport meta tag feature targetdensity-dpi by
1419         adding extra arguments to dumpConfigurationForViewport
1420
1421         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1422         (DumpRenderTreeSupportQt::viewportAsText):
1423         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1424
1425 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1426
1427         Unreviewed, rolling out r79764.
1428         http://trac.webkit.org/changeset/79764
1429         https://bugs.webkit.org/show_bug.cgi?id=55295
1430
1431         "broke Chromium builds" (Requested by rniwa on #webkit).
1432
1433         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1434         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1435
1436 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
1437
1438         Reviewed by Pavel Feldman.
1439
1440         DumpRenderTree should reset frame opener between tests.
1441         https://bugs.webkit.org/show_bug.cgi?id=54874
1442
1443         Added clearOpener method to DumpRenderTreeSupportQT.
1444
1445         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1446         (DumpRenderTreeSupportQt::clearOpener):
1447         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1448
1449 2011-02-25  Andras Becsi  <abecsi@webkit.org>
1450
1451         Reviewed by Csaba Osztrogonác.
1452
1453         [Qt] Make the WebKit2 build system less confusing for non-Qt developers
1454         https://bugs.webkit.org/show_bug.cgi?id=55213
1455
1456         * QtWebKit.pro: Move the WebKit2 API into a project include file
1457         in the WebKit2 directory and include the pri file here.
1458
1459 2011-02-25  Alexis Menard  <alexis.menard@openbossa.org>
1460
1461         Unreviewed build fix for Intel ICC and MSVC.
1462
1463         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1464         (tst_QGraphicsWebView::setPalette):
1465         * tests/qwebview/tst_qwebview.cpp:
1466         (tst_QWebView::setPalette):
1467
1468 2011-02-25  Alexis Menard  <alexis.menard@openbossa.org>
1469
1470         Reviewed by Kenneth Rohde Christiansen.
1471
1472         [Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
1473         https://bugs.webkit.org/show_bug.cgi?id=31742
1474
1475         Discovered while looking at 31742. When we set a palette on the
1476         QGraphicsWebView we need to propagate it to the page like QWebView.
1477         I have added the same tests as QWebView to be sure to catch potential
1478         regressions as well as two extras QVERIFY to check the palette propagation.
1479
1480         * Api/qgraphicswebview.cpp:
1481         (QGraphicsWebView::event):
1482         * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1483         (tst_QGraphicsWebView::setPalette_data):
1484         (tst_QGraphicsWebView::setPalette):
1485
1486 2011-02-25  Csaba Osztrogonác  <ossy@webkit.org>
1487
1488         Unreviewed buildfix after r79672.
1489
1490         [Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.
1491
1492         * tests/tests.pri:
1493         * tests/tests.pro:
1494
1495 2011-02-25  Gopal Raghavan  <gopal.1.raghavan@nokia.com>
1496
1497         Reviewed by Kenneth Rohde Christiansen.
1498
1499         [Qt] QML WebView inside a Flickable shows checkers pattern at startup
1500         https://bugs.webkit.org/show_bug.cgi?id=50222.
1501
1502         This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.
1503
1504         * declarative/qdeclarativewebview.cpp:
1505         (QDeclarativeWebView::init):
1506         * tests/qdeclarativewebview: Added.
1507         * tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
1508         * tests/qdeclarativewebview/resources: Added.
1509         * tests/qdeclarativewebview/resources/webviewtest.qml: Added.
1510         * tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
1511         * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added.
1512         (tst_QDeclarativeWebView::initTestCase):
1513         (tst_QDeclarativeWebView::cleanupTestCase):
1514         (tst_QDeclarativeWebView::init):
1515         (tst_QDeclarativeWebView::cleanup):
1516         (tst_QDeclarativeWebView::preferredWidthTest):
1517         (tst_QDeclarativeWebView::preferredHeightTest):
1518         (tst_QDeclarativeWebView::preferredWidthDefaultTest):
1519         (tst_QDeclarativeWebView::preferredHeightDefaultTest):
1520         (tst_QDeclarativeWebView::checkNoErrors):
1521         * tests/tests.pri:
1522         * tests/tests.pro:
1523
1524 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1525
1526         Reviewed by Andreas Kling.
1527
1528         [Qt] Revert the support for QNAM affined to a different thread.
1529         https://bugs.webkit.org/show_bug.cgi?id=55149
1530
1531         Qt 4.8 will have QNAM use its own thread internally by default,
1532         no need to keep this complexity in WebKit.
1533
1534         This mainly reverts:
1535         http://trac.webkit.org/changeset/73710
1536         http://trac.webkit.org/changeset/73712
1537
1538         * WebCoreSupport/FrameLoaderClientQt.cpp:
1539         (WebCore::FrameLoaderClientQt::download):
1540         * tests/qwebpage/tst_qwebpage.cpp:
1541
1542 2011-02-24  Sam Weinig  <sam@webkit.org>
1543
1544         Try to fix the Qt build.
1545
1546         * QtWebKit.pro:
1547
1548 2011-02-24  Peter Kasting  <pkasting@google.com>
1549
1550         Reviewed by Eric Seidel.
1551
1552         Drop the "U; " encryption level from the User Agent string.
1553         https://bugs.webkit.org/show_bug.cgi?id=54566
1554
1555         * Api/qwebpage.cpp:
1556         (QWebPage::userAgentForUrl):
1557
1558 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
1559
1560         Unreviewed, rolling out r79570.
1561         http://trac.webkit.org/changeset/79570
1562         https://bugs.webkit.org/show_bug.cgi?id=54874
1563
1564         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
1565         was not updated
1566
1567         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1568         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1569
1570 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
1571
1572         Reviewed by Alexey Proskuryakov.
1573
1574         DumpRenderTree should reset frame opener between tests.
1575         https://bugs.webkit.org/show_bug.cgi?id=54874
1576
1577         Added clearOpener method to DumpRenderTreeSupportQT.
1578
1579         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1580         (DumpRenderTreeSupportQt::clearOpener):
1581         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1582
1583 2011-02-24  Alexis Menard  <alexis.menard@openbossa.org>
1584
1585         Reviewed by Andreas Kling.
1586
1587         [Qt] tst_QWebView::setPalette(activeFG) fails
1588         https://bugs.webkit.org/show_bug.cgi?id=55029
1589
1590         This time it should be the proper fix. The window needs to be shown before we
1591         call activateWindow() otherwise there is no active windows for the application.
1592
1593         * tests/qwebview/tst_qwebview.cpp:
1594         (tst_QWebView::setPalette):
1595
1596 2011-02-24  Andras Becsi  <abecsi@webkit.org>
1597
1598         Reviewed by Laszlo Gombos.
1599
1600         [Qt] MinGW build fails to link
1601         https://bugs.webkit.org/show_bug.cgi?id=55050
1602
1603         Prepend the libraries of subcomponents instead of appending them
1604         to fix the library order according to the dependency of the libraries
1605
1606         * QtWebKit.pro: prepend libraries in the correct order
1607
1608 2011-02-23  Alexis Menard  <alexis.menard@openbossa.org>
1609
1610         Reviewed by Ariya Hidayat.
1611
1612         [Qt] tst_QWebView::setPalette(activeFG) fails
1613         https://bugs.webkit.org/show_bug.cgi?id=55029
1614
1615         Attempt to make the test more robust. By investigating with the bot virtual machine
1616         I discovered that the activation can take some time. In this patch we make sure that
1617         the active window we want to have is the same as the QApplication.
1618
1619         * tests/qwebview/tst_qwebview.cpp:
1620         (tst_QWebView::setPalette):
1621
1622 2011-02-23  Alexis Menard  <alexis.menard@openbossa.org>
1623
1624         Reviewed by Dan Bernstein.
1625
1626         [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
1627         http://trac.webkit.org/changeset/79167 refactored the way the bound size of
1628         the frame is handled. A new API setBoundsSize was added, we need to call it
1629         in addition to setFrameRect. I could call setBoundSize after setFrameRect but
1630         I thought It would be more elegant to use the resize method.
1631
1632         * Api/qwebpage.cpp:
1633         (QWebPage::setViewportSize):
1634
1635 2011-02-22  Fabrizio Machado  <fabrizio.machado@nokia.com>
1636
1637         Reviewed by Laszlo Gombos.
1638
1639         [Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
1640         https://bugs.webkit.org/show_bug.cgi?id=54976
1641
1642         Test not needed.
1643         
1644         * WebCoreSupport/InspectorClientQt.cpp:
1645
1646 2011-02-22  Alexis Menard  <alexis.menard@openbossa.org>
1647
1648         Reviewed by Andreas Kling.
1649
1650         [Qt] QWebView ignores a palette set with QWebView::setPalette()
1651         https://bugs.webkit.org/show_bug.cgi?id=31742
1652
1653         Test case to check that the palette sets on the QWebView is taken
1654         into account.
1655
1656         * tests/qwebview/tst_qwebview.cpp:
1657         (tst_QWebView::setPalette_data):
1658         (tst_QWebView::setPalette):
1659
1660 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1661
1662         Reviewed by Alexey Proskuryakov.
1663
1664         Drop the language tag part from the User Agent string
1665         https://bugs.webkit.org/show_bug.cgi?id=54560
1666
1667         * Api/qwebpage.cpp:
1668         (QWebPage::userAgentForUrl):
1669
1670         * tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange
1671         test.
1672
1673 2011-02-22  Chang Shu  <cshu@webkit.org>
1674
1675         Reviewed by Csaba Osztrogonác.
1676
1677         [Qt] editing/deleting/5408255.html fails
1678         https://bugs.webkit.org/show_bug.cgi?id=54964
1679
1680         Move WebCore resource file to QtWebKit since they are referred in WebKit.
1681
1682         * QtWebKit.pro:
1683
1684 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1685
1686         Reviewed by Csaba Osztrogonác.
1687
1688         [Qt] Redesign the build system
1689         https://bugs.webkit.org/show_bug.cgi?id=51339
1690
1691         Move inspector's resource files into the final build step to fix the layout test regression.
1692
1693         * QtWebKit.pro: Add inspector's reaource files.
1694
1695 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1696
1697         Reviewed by Laszlo Gombos.
1698         Rubber-stamped by Csaba Osztrogonác.
1699
1700         [Qt] Redesign the build system
1701         https://bugs.webkit.org/show_bug.cgi?id=51339
1702
1703         The patch landed in r79320 didn't contain the cleanup
1704         which was already addressed in the last attachment.
1705
1706         * QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
1707
1708 2011-02-22  Andras Becsi  <abecsi@webkit.org>
1709
1710         Reviewed by Laszlo Gombos.
1711
1712         [Qt] Redesign the build system
1713         https://bugs.webkit.org/show_bug.cgi?id=51339
1714
1715         Part 2.
1716
1717         Build WebCore as a static library, compile the WebKit API and WebKit2 API
1718         in a final step and link to WebKit2, WebCore and JSC libraries to fix
1719         linking issues resulting from stripped away symbols.
1720
1721         * QtWebKit.pro: Added.
1722         Project file for the final build step.
1723
1724 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
1725
1726         Reviewed by Kent Tamura.
1727
1728         Rename Position::node() to Position::deprecatedNode()
1729         https://bugs.webkit.org/show_bug.cgi?id=54622
1730
1731         Replaced the call to node() by a call to containerNode() because the returned node is
1732         used to determine whether or not the selected contents are editable and such a check
1733         must be done against the container node.
1734
1735         * WebCoreSupport/EditorClientQt.cpp:
1736         (WebCore::EditorClientQt::handleKeyboardEvent):
1737
1738 2011-02-19  Charlie Reis  <creis@chromium.org>
1739
1740         Reviewed by Mihai Parparita.
1741
1742         Ensure loading has stopped in HistoryController::goToItem
1743         https://bugs.webkit.org/show_bug.cgi?id=54517
1744
1745         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
1746
1747         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
1748
1749         * WebCoreSupport/FrameLoaderClientQt.cpp:
1750         (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
1751         * WebCoreSupport/FrameLoaderClientQt.h:
1752
1753 2011-02-18  Fabrizio Machado  <fabrizio.machado@nokia.com>
1754
1755         Reviewed by Eric Seidel.
1756
1757         Remove reduntant checks.
1758         https://bugs.webkit.org/show_bug.cgi?id=54764
1759         
1760
1761         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1762         (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
1763         * WebCoreSupport/NotificationPresenterClientQt.cpp:
1764         (WebCore::NotificationPresenterClientQt::toPage):
1765
1766 2011-02-18  Csaba Osztrogonác  <ossy@webkit.org>
1767
1768         Unreviewed.
1769
1770         [Qt] Buildfix for platforms with geolocation disabled.
1771
1772         * Api/qwebpage.cpp: Add the missing guard.
1773
1774 2011-02-18  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1775
1776         Reviewed by Kenneth Rohde Christiansen.
1777
1778         [Qt] Implement client based geolocation for qtport
1779         https://bugs.webkit.org/show_bug.cgi?id=42629
1780
1781         Implements client based geolocation for qtwebkit.
1782         New client based geolocation contains permission API's as well,
1783         so removed the implementation from ChromeClientQt.cpp. 
1784
1785         * Api/qwebpage.cpp:
1786         (QWebPagePrivate::QWebPagePrivate):
1787         * WebCoreSupport/ChromeClientQt.cpp:
1788         * WebCoreSupport/ChromeClientQt.h:
1789         (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
1790         (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
1791         * WebCoreSupport/GeolocationClientQt.cpp: Added.
1792         (WebCore::GeolocationClientQt::GeolocationClientQt):
1793         (WebCore::GeolocationClientQt::~GeolocationClientQt):
1794         (WebCore::GeolocationClientQt::geolocationDestroyed):
1795         (WebCore::GeolocationClientQt::positionUpdated):
1796         (WebCore::GeolocationClientQt::startUpdating):
1797         (WebCore::GeolocationClientQt::stopUpdating):
1798         (WebCore::GeolocationClientQt::setEnableHighAccuracy):
1799         (WebCore::GeolocationClientQt::requestPermission):
1800         (WebCore::GeolocationClientQt::cancelPermissionRequest):
1801         * WebCoreSupport/GeolocationClientQt.h: Added.
1802         (WebCore::GeolocationClientQt::lastPosition):
1803
1804 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
1805
1806         Reviewed by Adam Roben.
1807
1808         HTML5 <details> and <summary>: localized text
1809         https://bugs.webkit.org/show_bug.cgi?id=54260
1810
1811         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
1812         provide the default label to be used by a <details> tag that has no <summary> child.
1813
1814         * WebCoreSupport/WebPlatformStrategies.cpp:
1815         (WebPlatformStrategies::defaultDetailsSummaryText):
1816         * WebCoreSupport/WebPlatformStrategies.h:
1817
1818 2011-02-17  Hui Huang  <hui.2.huang@nokia.com>
1819
1820         Reviewed by Laszlo Gombos.
1821
1822         The URL of HTML5 Video Element is percent encoded at websites such as youtube.
1823         It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
1824         the HTTP GET request for the video to be rejected by the service provider. 
1825         https://bugs.webkit.org/show_bug.cgi?id=53973.
1826
1827         The bug is fixed by constructing QUrl from the encoded URL in 
1828         MediaPlayerPrivateQt::commitLoad. 
1829
1830         New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
1831         HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
1832         is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
1833         A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
1834         is skipped if Qt Multimedia is not available.
1835
1836         * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1837         (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
1838         * WebCoreSupport/DumpRenderTreeSupportQt.h:
1839         * tests/qwebpage/tst_qwebpage.cpp:
1840         (tst_QWebPage::loadHtml5Video):
1841         * tests/tests.pri:
1842
1843 2011-02-17  Andreas Kling  <kling@webkit.org>
1844
1845         Reviewed by Antti Koivisto.
1846
1847         [Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
1848         https://bugs.webkit.org/show_bug.cgi?id=49216
1849
1850         * tests/qwebframe/tst_qwebframe.cpp:
1851
1852 == Rolled over to ChangeLog-2011-02-16 ==