JSC should support SharedArrayBuffer
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
2
3         JSC should support SharedArrayBuffer
4         https://bugs.webkit.org/show_bug.cgi?id=163986
5
6         Reviewed by Keith Miller.
7         
8         Support the RuntimeFlag.
9
10         * WebView/WebPreferencesPrivate.h:
11
12 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
13
14         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
15         https://bugs.webkit.org/show_bug.cgi?id=164236
16         <rdar://problem/28747712>
17
18         Reviewed by Beth Dakin.
19
20         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
21         dictionary lookup.
22
23         * WebCoreSupport/WebEditorClient.mm:
24         (WebEditorClient::respondToChangedSelection):
25         * WebView/WebImmediateActionController.mm:
26         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
27
28 2016-10-31  Darin Adler  <darin@apple.com>
29
30         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
31         https://bugs.webkit.org/show_bug.cgi?id=164214
32
33         Reviewed by Alex Christensen.
34
35         * DOM/DOMCSSPrimitiveValue.mm:
36         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
37         is a reference now.
38         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
39
40         * DOM/DOMDocument.mm:
41         (-[DOMDocument querySelector:]): Updated exception handling.
42         (-[DOMDocument querySelectorAll:]): Ditto.
43         * DOM/DOMDocumentFragment.mm:
44         (-[DOMDocumentFragment querySelector:]): Ditto.
45         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
46         * DOM/DOMElement.mm:
47         (-[DOMElement querySelector:]): Ditto.
48         (-[DOMElement querySelectorAll:]): Ditto.
49
50 2016-10-31  Darin Adler  <darin@apple.com>
51
52         Convert Document from ExceptionCode to Exception
53         https://bugs.webkit.org/show_bug.cgi?id=164212
54
55         Reviewed by Alex Christensen.
56
57         * DOM/DOMDocument.mm:
58         (-[DOMDocument setXmlVersion:]): Updated exception handling.
59         (-[DOMDocument cookie]): Ditto.
60         (-[DOMDocument setCookie:]): Ditto.
61         (-[DOMDocument setBody:]): Ditto.
62         (-[DOMDocument createElement:]): Ditto.
63         (-[DOMDocument createCDATASection:]): Ditto.
64         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
65         (-[DOMDocument createAttribute:]): Ditto.
66         (-[DOMDocument createEntityReference:]): Ditto.
67         (-[DOMDocument importNode:deep:]): Ditto.
68         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
69         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
70         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
71         (-[DOMDocument adoptNode:]): Ditto.
72         (-[DOMDocument createEvent:]): Ditto.
73
74 2016-10-30  Darin Adler  <darin@apple.com>
75
76         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
77         https://bugs.webkit.org/show_bug.cgi?id=164206
78
79         Reviewed by Chris Dumez.
80
81         * DOM/DOMElement.mm:
82         (-[DOMElement setInnerHTML:]): Updated exception handling.
83         (-[DOMElement setOuterHTML:]): Ditto.
84         (-[DOMElement setAttribute:value:]): Ditto.
85         (-[DOMElement setAttributeNode:]): Ditto.
86         (-[DOMElement removeAttributeNode:]): Ditto.
87         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
88         (-[DOMElement setAttributeNodeNS:]): Ditto.
89         (-[DOMElement matches:]): Ditto.
90         (-[DOMElement closest:]): Ditto.
91         (-[DOMElement webkitMatchesSelector:]): Ditto.
92         * DOM/DOMHTMLElement.mm:
93         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
94         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
95         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
96         * DOM/DOMNamedNodeMap.mm:
97         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
98         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
99         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
100         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
101
102 2016-10-29  Darin Adler  <darin@apple.com>
103
104         Convert more of DOM from ExceptionCode to Exception
105         https://bugs.webkit.org/show_bug.cgi?id=164173
106
107         Reviewed by Ryosuke Niwa.
108
109         * DOM/DOMCharacterData.mm:
110         (-[DOMCharacterData substringData:length:]): Updated since this
111         now uses ExceptionOr.
112         (-[DOMCharacterData insertData:data:]): Ditto.
113         (-[DOMCharacterData deleteData:length:]): Ditto.
114         (-[DOMCharacterData replaceData:length:data:]): Ditto.
115         * DOM/DOMText.mm:
116         (-[DOMText splitText:]): Ditto.
117         (-[DOMText replaceWholeText:]): Removed unneeded exception code
118         handling from function that does not throw an exception.
119
120 2016-10-28  Darin Adler  <darin@apple.com>
121
122         Move all classes in the HTML directory from ExceptionCode to Exception
123         https://bugs.webkit.org/show_bug.cgi?id=163876
124
125         Reviewed by Sam Weinig.
126
127         * DOM/DOMCharacterData.mm:
128         (-[DOMCharacterData remove]): Updated exception handling.
129         * DOM/DOMDOMTokenList.mm:
130         (-[DOMDOMTokenList toggle:force:]): Ditto.
131         * DOM/DOMDocumentType.mm:
132         (-[DOMDocumentType remove]): Ditto.
133         * DOM/DOMElement.mm:
134         (-[DOMElement remove]): Ditto.
135         * DOM/DOMHTML.mm:
136         (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
137         * DOM/DOMHTMLCanvasElement.mm:
138         (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
139         * DOM/DOMHTMLElement.mm:
140         (-[DOMHTMLElement setInnerText:]): Ditto.
141         (-[DOMHTMLElement setOuterText:]): Ditto.
142         (-[DOMHTMLElement setContentEditable:]): Ditto.
143         * DOM/DOMHTMLInputElement.mm:
144         (-[DOMHTMLInputElement setMaxLength:]): Ditto.
145         (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
146         (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
147         (-[DOMHTMLInputElement stepUp:]): Ditto.
148         (-[DOMHTMLInputElement stepDown:]): Ditto.
149         (-[DOMHTMLInputElement setRangeText:]): Ditto.
150         (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
151         * DOM/DOMHTMLMarqueeElement.mm:
152         (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
153         * DOM/DOMHTMLMediaElement.mm:
154         (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
155         (-[DOMHTMLMediaElement setVolume:]): Ditto.
156         * DOM/DOMHTMLOptionsCollection.mm:
157         (-[DOMHTMLOptionsCollection setLength:]): Ditto.
158         * DOM/DOMHTMLTableElement.mm:
159         (-[DOMHTMLTableElement setCaption:]): Ditto.
160         (-[DOMHTMLTableElement setTHead:]): Ditto.
161         (-[DOMHTMLTableElement setTFoot:]): Ditto.
162         (-[DOMHTMLTableElement insertRow:]): Ditto.
163         (-[DOMHTMLTableElement deleteRow:]): Ditto.
164         * DOM/DOMHTMLTableRowElement.mm:
165         (-[DOMHTMLTableRowElement insertCell:]): Ditto.
166         (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
167         * DOM/DOMHTMLTableSectionElement.mm:
168         (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
169         (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
170         * DOM/DOMHTMLTextAreaElement.mm:
171         (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
172         (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
173         (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
174         * DOM/DOMHTMLVideoElement.mm:
175         (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
176         (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
177         version (lowercase S) instead of repeating the logic from that method.
178         (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
179         * DOM/DOMTimeRanges.mm:
180         (-[DOMTimeRanges start:]): Updated exception handling.
181         (-[DOMTimeRanges end:]): Ditto.
182
183 2016-10-27  Chris Dumez  <cdumez@apple.com>
184
185         Regression(r203601): Caused crashes in iBooks
186         https://bugs.webkit.org/show_bug.cgi?id=164093
187         <rdar://problem/28745634>
188
189         Reviewed by Darin Adler.
190
191         Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
192         which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
193
194         * DOM/DOMNode.mm:
195         (-[DOMNode compareDocumentPosition:]):
196
197 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
198
199         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
200         https://bugs.webkit.org/show_bug.cgi?id=163948
201         <rdar://problem/28921433>
202
203         Reviewed by Darin Adler.
204
205         Add support for new drag and drop-related EditAction enum values.
206
207         * WebCoreSupport/WebEditorClient.mm:
208         (undoNameForEditAction):
209
210 2016-10-27  Dan Bernstein  <mitz@apple.com>
211
212         Reapplied the configuration changes from r207934 without breaking iOS builds.
213
214         * Configurations/Base.xcconfig:
215         * Configurations/WebKitLegacy.xcconfig:
216
217 2016-10-27  Dan Bernstein  <mitz@apple.com>
218
219         Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
220
221         * Configurations/Base.xcconfig:
222         * Configurations/WebKitLegacy.xcconfig:
223
224 2016-10-26  Dan Bernstein  <mitz@apple.com>
225
226         [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
227         https://bugs.webkit.org/show_bug.cgi?id=164048
228
229         Reviewed by Tim Horton.
230
231         * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
232         * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
233           headers.
234
235         * History/WebBackForwardList.h: Fixed parameter name in @param entry.
236         * Misc/WebDownload.h: Removed empty entries.
237         * Misc/WebIconDatabase.h: Remove incorrect @param entries.
238         * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
239         * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
240         * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
241         * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
242         * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
243         * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
244         * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
245           Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
246         * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
247         * WebView/WebView.h: Changed @method to @property in a couple of places.
248         * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
249
250 2016-10-26  Brian Burg  <bburg@apple.com>
251
252         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
253         https://bugs.webkit.org/show_bug.cgi?id=164046
254
255         Reviewed by Joseph Pecoraro.
256
257         * WebCoreSupport/WebInspectorClient.h:
258
259 2016-10-21  Alex Christensen  <achristensen@webkit.org>
260
261         URL::port should return Optional<uint16_t>
262         https://bugs.webkit.org/show_bug.cgi?id=163806
263
264         Reviewed by Darin Adler.
265
266         * WebCoreSupport/WebSecurityOrigin.mm:
267         (-[WebSecurityOrigin port]):
268
269 2016-10-24  Dave Hyatt  <hyatt@apple.com>
270
271         Remove CSSCharsetRule from the CSS OM
272         https://bugs.webkit.org/show_bug.cgi?id=163891
273
274         Reviewed by Darin Adler.
275
276         * DOM/DOMCSSCharsetRule.mm:
277         (-[DOMCSSCharsetRule encoding]):
278
279 2016-10-24  Youenn Fablet  <youenn@apple.com>
280
281         Activate WEB_RTC compilation flags for Mac bots
282         https://bugs.webkit.org/show_bug.cgi?id=163886
283
284         Reviewed by Eric Carlson.
285
286         * Configurations/FeatureDefines.xcconfig:
287
288 2016-10-23  Chris Dumez  <cdumez@apple.com>
289
290         addEventListener() / removeEventListener() should use a union for last parameter
291         https://bugs.webkit.org/show_bug.cgi?id=163863
292
293         Reviewed by Darin Adler.
294
295         Cast BOOL to bool to help to compiler construct the new variant-type parameter.
296
297         * DOM/DOMNode.mm:
298         (-[DOMNode addEventListener:listener:useCapture:]):
299         (-[DOMNode addEventListener:::]):
300         (-[DOMNode removeEventListener:listener:useCapture:]):
301         (-[DOMNode removeEventListener:::]):
302
303 2016-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
304
305         Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
306         https://bugs.webkit.org/show_bug.cgi?id=163460
307         <rdar://problem/28784142>
308
309         Reviewed by Darin Adler.
310
311         Handle new EditAction types for inserting/deleting pending/final compositions.
312
313         * WebCoreSupport/WebEditorClient.mm:
314         (undoNameForEditAction):
315
316 2016-10-21  Jeremy Jones  <jeremyj@apple.com>
317
318         Implement basic pointer lock behavior for WebKit and WebKit2.
319         https://bugs.webkit.org/show_bug.cgi?id=162745
320
321         Reviewed by Simon Fraser.
322
323         Add basic pointer lock functionality. User permission is not yet implemented.
324
325         * WebCoreSupport/WebChromeClient.h:
326         * WebCoreSupport/WebChromeClient.mm:
327         (WebChromeClient::requestPointerLock):
328         (WebChromeClient::requestPointerUnlock):
329
330 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
331
332         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
333         https://bugs.webkit.org/show_bug.cgi?id=163374
334
335         Reviewed by Darin Adler.
336
337         * Configurations/FeatureDefines.xcconfig:
338
339 2016-10-19  Alex Christensen  <achristensen@webkit.org>
340
341         Revert r207151
342         https://bugs.webkit.org/show_bug.cgi?id=163675
343
344         Reviewed by Brent Fulgham.
345
346         * Misc/WebDownload.mm:
347         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
348         * Misc/WebDownloadInternal.h:
349         * WebCoreSupport/WebFrameLoaderClient.mm:
350         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
351         * WebView/WebPreferences.mm:
352         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
353         * WebView/WebView.mm:
354         (-[WebView scheduleInRunLoop:forMode:]):
355         (-[WebView unscheduleFromRunLoop:forMode:]):
356
357 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
358
359         Unreviewed, rolling out r207557.
360
361         This change caused animations/font-variations tests to time
362         out on pre-Sierra Macs.
363
364         Reverted changeset:
365
366         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
367         iOS 9"
368         https://bugs.webkit.org/show_bug.cgi?id=163374
369         http://trac.webkit.org/changeset/207557
370
371 2016-10-19  Chris Dumez  <cdumez@apple.com>
372
373         Move HTML Interactive Form Validation behind an experimental flag
374         https://bugs.webkit.org/show_bug.cgi?id=163673
375
376         Reviewed by Daniel Bates.
377
378         Re-disable HTML Interactive Form Validation by default on Mac WK1.
379
380         * WebView/WebViewData.mm:
381         (-[WebViewPrivate init]):
382
383 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
384
385         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
386         https://bugs.webkit.org/show_bug.cgi?id=163374
387
388         Reviewed by Darin Adler.
389
390         * Configurations/FeatureDefines.xcconfig:
391
392 2016-10-19  Simon Fraser  <simon.fraser@apple.com>
393
394         WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
395         https://bugs.webkit.org/show_bug.cgi?id=163680
396
397         Reviewed by Dean Jackson.
398
399         Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
400
401         * WebView/WebView.mm:
402         (-[WebView _preferencesChanged:]):
403
404 2016-10-19  Darin Adler  <darin@apple.com>
405
406         Move XPath from ExceptionCode to Exception
407         https://bugs.webkit.org/show_bug.cgi?id=163656
408
409         Reviewed by Chris Dumez.
410
411         * DOM/DOMDocument.mm:
412         (wrap): Added. Helper function for wrapping a resolver.
413         (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
414         (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
415         * DOM/DOMXPathExpression.mm:
416         (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
417         * DOM/DOMXPathResult.mm:
418         (-[DOMXPathResult numberValue]): Ditto.
419         (-[DOMXPathResult stringValue]): Ditto.
420         (-[DOMXPathResult booleanValue]): Ditto.
421         (-[DOMXPathResult singleNodeValue]): Ditto.
422         (-[DOMXPathResult snapshotLength]): Ditto.
423         (-[DOMXPathResult iterateNext]): Ditto.
424         (-[DOMXPathResult snapshotItem:]): Ditto.
425
426 2016-10-18  Sam Weinig  <sam@webkit.org>
427
428         Replace std::experimental::variant with WTF::Variant (or similar)
429         https://bugs.webkit.org/show_bug.cgi?id=163626
430
431         Reviewed by Chris Dumez.
432
433         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
434         into the WTF namespace.
435
436         * DOM/DOMHTMLSelectElement.mm:
437         (-[DOMHTMLSelectElement add:before:]):
438
439 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
440
441         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
442         https://bugs.webkit.org/show_bug.cgi?id=163627
443
444         Reviewed by Dean Jackson.
445
446         Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
447
448         * WebView/WebViewPrivate.h:
449
450 2016-10-18  Dean Jackson  <dino@apple.com>
451
452         Remove CSS_SHAPES feature definition. This should always be on.
453         https://bugs.webkit.org/show_bug.cgi?id=163628
454         <rdar://problem/28834613>
455
456         Reviewed by Tim Horton.
457
458         * Configurations/FeatureDefines.xcconfig:
459
460 2016-10-18  Chris Dumez  <cdumez@apple.com>
461
462         Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
463         https://bugs.webkit.org/show_bug.cgi?id=163608
464
465         Reviewed by Ryosuke Niwa.
466
467         Update add() call sites now that it takes std::variant types in.
468
469         * DOM/DOMHTMLOptionsCollection.mm:
470         (-[DOMHTMLOptionsCollection add:index:]):
471         * DOM/DOMHTMLSelectElement.mm:
472         (-[DOMHTMLSelectElement add:before:]):
473
474 2016-10-18  Anders Carlsson  <andersca@apple.com>
475
476         Get rid of more WebHistoryItem cruft
477         https://bugs.webkit.org/show_bug.cgi?id=163623
478
479         Reviewed by Tim Horton.
480
481         * History/WebHistoryItem.mm:
482         (-[WebHistoryItem initFromDictionaryRepresentation:]):
483         * History/WebHistoryItemPrivate.h:
484
485 2016-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
486
487         Showing and hiding candidates list is very distracting after selecting word
488         https://bugs.webkit.org/show_bug.cgi?id=163609
489         <rdar://problem/28747712>
490
491         Reviewed by Tim Horton.
492
493         Introduce WebView hooks for mousedown and mouseup. See radar for more details.
494
495         * WebView/WebHTMLView.mm:
496         (-[WebHTMLView mouseDown:mouseDown:]):
497         (-[WebHTMLView mouseUp:mouseUp:]):
498         * WebView/WebView.mm:
499         (-[WebView prepareForMouseDown]):
500         (-[WebView prepareForMouseUp]):
501         * WebView/WebViewInternal.h:
502
503 2016-10-17  Anders Carlsson  <andersca@apple.com>
504
505         Move some history specific HistoryItem code to WebHistoryItem
506         https://bugs.webkit.org/show_bug.cgi?id=163567
507
508         Reviewed by Tim Horton.
509
510         * History/HistoryPropertyList.mm:
511         (HistoryPropertyListWriter::writeHistoryItem):
512         * History/WebHistory.mm:
513         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
514         * History/WebHistoryItem.mm:
515         (-[WebHistoryItem initFromDictionaryRepresentation:]):
516         * History/WebHistoryItemInternal.h:
517         * WebCoreSupport/WebFrameLoaderClient.mm:
518         (addRedirectURL):
519         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
520
521 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
522
523         [MediaStream] Resolve constraints and enumerate devices in the UI process
524         https://bugs.webkit.org/show_bug.cgi?id=162147
525         <rdar://problem/28803569>
526
527         Reviewed by Darin Adler.
528
529         * WebCoreSupport/WebUserMediaClient.h:
530         * WebCoreSupport/WebUserMediaClient.mm:
531         (AddPermissionCheckToMap):
532         (RemovePermissionCheckFromMap):
533         (WebUserMediaClient::pageDestroyed):
534         (WebUserMediaClient::requestUserMediaAccess):
535         (WebUserMediaClient::enumerateMediaDevices):
536         (WebUserMediaClient::cancelMediaDevicesEnumerationRequest):
537         (-[WebUserMediaPolicyListener allow]):
538         (-[WebUserMediaPolicyListener deny]):
539         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
540         (-[WebUserMediaPolicyCheckerListener cancelMediaDevicesEnumerationRequest]):
541         (-[WebUserMediaPolicyCheckerListener allow]):
542         (-[WebUserMediaPolicyCheckerListener deny]):
543         (WebUserMediaClient::checkUserMediaPermission): Deleted.
544         (WebUserMediaClient::cancelUserMediaPermissionCheck): Deleted.
545         (-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]): Deleted.
546         (-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]): Deleted.
547
548 2016-10-17  Antti Koivisto  <antti@apple.com>
549
550         Rename setNeedsStyleRecalc to invalidateStyle
551         https://bugs.webkit.org/show_bug.cgi?id=163542
552
553         Reviewed by Darin Adler.
554
555         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
556         (-[WebHostedNetscapePluginView createPluginLayer]):
557         * Plugins/WebNetscapePluginView.mm:
558         (-[WebNetscapePluginView createPlugin]):
559
560 2016-10-17  Jeremy Jones  <jeremyj@apple.com>
561
562         Enable keyboard in fullscreen.
563         https://bugs.webkit.org/show_bug.cgi?id=163146
564
565         Reviewed by Jer Noble.
566
567         Allow keyboard in fullscreen.
568
569         * WebView/WebView.mm:
570         (-[WebView _supportsFullScreenForElement:withKeyboard:]):
571
572 2016-10-17  Chris Dumez  <cdumez@apple.com>
573
574         Move form.reportValidity() behind InteractiveFormValidation setting
575         https://bugs.webkit.org/show_bug.cgi?id=163550
576
577         Reviewed by Darin Adler.
578
579         Enable InteractiveFormValidation setting by default and link it to
580         RuntimeEnabledFeatures so we can use it in the IDL.
581
582         * WebView/WebView.mm:
583         (-[WebView _preferencesChanged:]):
584         * WebView/WebViewData.mm:
585         (-[WebViewPrivate init]):
586
587 2016-10-17  Anders Carlsson  <andersca@apple.com>
588
589         Fix iOS build.
590
591         * History/WebBackForwardList.mm:
592         (-[WebBackForwardList dictionaryRepresentation]):
593
594 2016-10-17  Anders Carlsson  <andersca@apple.com>
595
596         CTTE some of the BackForwardList member functions
597         https://bugs.webkit.org/show_bug.cgi?id=163555
598
599         Reviewed by Dan Bernstein.
600
601         * History/BackForwardList.h:
602         (BackForwardList::entries):
603         * History/BackForwardList.mm:
604         (BackForwardList::removeItem):
605         (BackForwardList::containsItem):
606         (BackForwardList::entries): Deleted.
607         * History/WebBackForwardList.mm:
608         (-[WebBackForwardList removeItem:]):
609         (-[WebBackForwardList containsItem:]):
610         (-[WebBackForwardList description]):
611
612 2016-10-17  Anders Carlsson  <andersca@apple.com>
613
614         Remove WEBCORE_EXPORT from BackForwardList, it lives in WebKit now
615         https://bugs.webkit.org/show_bug.cgi?id=163551
616
617         Reviewed by Tim Horton.
618
619         * History/BackForwardList.h:
620
621 2016-10-16  Darin Adler  <darin@apple.com>
622
623         Move CSS classes from ExceptionCode to Exception
624         https://bugs.webkit.org/show_bug.cgi?id=163494
625
626         Reviewed by Sam Weinig.
627
628         * DOM/DOMCSSMediaRule.mm:
629         (-[DOMCSSMediaRule insertRule:index:]): Use raiseOnDOMError
630         the new way to handle ExceptionOr instead of ExceptionCode.
631         (-[DOMCSSMediaRule deleteRule:]): Ditto.
632         * DOM/DOMCSSPrimitiveValue.mm:
633         (-[DOMCSSPrimitiveValue setFloatValue:floatValue:]): Ditto.
634         (-[DOMCSSPrimitiveValue getFloatValue:]): Ditto.
635         (-[DOMCSSPrimitiveValue setStringValue:stringValue:]): Ditto.
636         (-[DOMCSSPrimitiveValue getStringValue]): Ditto.
637         (-[DOMCSSPrimitiveValue getCounterValue]): Ditto.
638         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
639         (-[DOMCSSPrimitiveValue getRGBColorValue]): Ditto.
640         * DOM/DOMCSSRule.mm:
641         (-[DOMCSSRule setCssText:]): Ditto.
642         * DOM/DOMCSSStyleDeclaration.mm:
643         (-[DOMCSSStyleDeclaration setCssText:]): Ditto.
644         (-[DOMCSSStyleDeclaration removeProperty:]): Ditto.
645         (-[DOMCSSStyleDeclaration setProperty:value:priority:]): Ditto.
646         * DOM/DOMCSSStyleSheet.mm:
647         (-[DOMCSSStyleSheet insertRule:index:]): Ditto.
648         (-[DOMCSSStyleSheet deleteRule:]): Ditto.
649         (-[DOMCSSStyleSheet addRule:style:index:]): Ditto.
650         (-[DOMCSSStyleSheet removeRule:]): Ditto.
651         * DOM/DOMCSSValue.mm:
652         (-[DOMCSSValue setCssText:]): Ditto.
653         * DOM/DOMMediaList.mm:
654         (-[DOMMediaList setMediaText:]): Ditto.
655         (-[DOMMediaList deleteMedium:]): Ditto.
656         (-[DOMMediaList appendMedium:]): Ditto.
657
658         * DOM/ExceptionHandlers.h: Added an overload of raiseDOMException
659         that works with a WebCore::Exception&& and overloads of
660         raiseOnDOMError that work with WebCore::ExceptionOr&&.
661         * DOM/ExceptionHandlers.mm:
662         (raiseDOMException): Implemented the new version.
663
664 2016-10-15  Dan Bernstein  <mitz@apple.com>
665
666         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
667         https://bugs.webkit.org/show_bug.cgi?id=163492
668         <rdar://problem/28654799>
669
670         Reviewed by Darin Adler.
671
672         Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm
673
674         * WebView/WebHTMLView.mm:
675         (createMenuItem): Set the tag for items that have submenus as well.
676
677 2016-10-14  Anders Carlsson  <andersca@apple.com>
678
679         Clean up BackForwardClient
680         https://bugs.webkit.org/show_bug.cgi?id=163454
681
682         Reviewed by Sam Weinig.
683
684         * History/BackForwardList.h:
685         Remove override keywords.
686
687         * History/BackForwardList.mm:
688         (BackForwardList::clearAllPageCaches): Deleted.
689         Remove this, it's no longer used.
690
691         * WebView/WebView.mm:
692         (-[WebView _clearBackForwardCache]): Deleted.
693         * WebView/WebViewPrivate.h:
694         Remove SPI that's no longer used by anyone.
695
696 2016-10-13  Anders Carlsson  <andersca@apple.com>
697
698         Move BackForwardList from WebCore to WebKitLegacy
699         https://bugs.webkit.org/show_bug.cgi?id=163418
700
701         Reviewed by Tim Horton.
702
703         * History/BackForwardList.h: Renamed from Source/WebCore/history/BackForwardList.h.
704         (BackForwardList::create):
705         (BackForwardList::webView):
706         * History/BackForwardList.mm: Renamed from Source/WebCore/history/BackForwardList.cpp.
707         (BackForwardList::BackForwardList):
708         (BackForwardList::close):
709         (BackForwardList::containsItem):
710         * History/WebBackForwardList.mm:
711         (kit):
712         (-[WebBackForwardList initWithBackForwardList:]):
713         (-[WebBackForwardList setPageCacheSize:]):
714         (-[WebBackForwardList pageCacheSize]):
715         * History/WebBackForwardListInternal.h:
716         * WebCoreSupport/WebFrameLoaderClient.mm:
717         * WebView/WebFrameView.mm:
718         * WebView/WebView.mm:
719         (-[WebView _commonInitializationWithFrameName:groupName:]):
720         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
721
722 2016-10-13  Anders Carlsson  <andersca@apple.com>
723
724         Get rid of the HistoryItemVector typedef
725         https://bugs.webkit.org/show_bug.cgi?id=163398
726
727         Reviewed by Beth Dakin.
728
729         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
730
731         * History/WebBackForwardList.mm:
732         (-[WebBackForwardList dictionaryRepresentation]):
733         (vectorToNSArray):
734         (-[WebBackForwardList backListWithLimit:]):
735         (-[WebBackForwardList forwardListWithLimit:]):
736         (-[WebBackForwardList description]):
737         * History/WebHistoryItem.mm:
738         (-[WebHistoryItem description]):
739
740 2016-10-12  Chris Dumez  <cdumez@apple.com>
741
742         [Web IDL] Drop support for legacy [ConstructorConditional=*]
743         https://bugs.webkit.org/show_bug.cgi?id=163368
744
745         Reviewed by Ryosuke Niwa.
746
747         Drop ENABLE_DOM4_EVENTS_CONSTRUCTOR compiler flag.
748
749         * Configurations/FeatureDefines.xcconfig:
750
751 2016-10-12  Beth Dakin  <bdakin@apple.com>
752
753         Adobe Contribute CS 6.5 Trial crashes on launch
754         https://bugs.webkit.org/show_bug.cgi?id=163365
755         -and corresponding-
756         <rdar://problem/28732731>
757
758         Reviewed by Tim Horton.
759
760         * Carbon/CarbonWindowFrame.m:
761         (-[CarbonWindowFrame contentFill]):
762
763 2016-10-11  Daniel Bates  <dabates@apple.com>
764
765         Attempt to fix the Apple Internal Mac build following r207159
766         (https://bugs.webkit.org/show_bug.cgi?id=163244)
767
768         * WebView/WebView.mm:
769         (shouldRequireUserGestureToLoadVideo):
770
771 2016-10-11  Daniel Bates  <dabates@apple.com>
772
773         REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
774         https://bugs.webkit.org/show_bug.cgi?id=163259
775         <rdar://problem/28680515>
776
777         Reviewed by Jer Noble.
778
779         In WebKit1 on iOS we want to require user action to load and play videos by default and
780         allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
781         Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
782         can load and play without being initiated by a user action.
783
784         * WebView/WebPreferences.mm:
785         (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
786         WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
787         preference takes precedence over the values of its replacement preferences
788         WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
789
790 2016-10-11  Daniel Bates  <dabates@apple.com>
791
792         [iOS] REGRESSION (r197953): User gesture required to load video in iOS 9-built apps
793         https://bugs.webkit.org/show_bug.cgi?id=163244
794         <rdar://problem/27250015>
795
796         Reviewed by Jer Noble.
797
798         Enable or disable the Setting::requiresUserGestureToLoadVideo() in legacy WebKit depending
799         on the version of iOS SDK that the app was linked against. We require a user gesture to
800         begin loading a video as of iOS 10.
801
802         * WebView/WebView.mm:
803         (shouldRequireUserGestureToLoadVideo):
804         (-[WebView _preferencesChanged:]): Modified to pass the WebKit requiresUserGestureToLoadVideo
805         preference to WebCore.
806
807 2016-10-11  Alex Christensen  <achristensen@webkit.org>
808
809         Remove dead networking code
810         https://bugs.webkit.org/show_bug.cgi?id=163263
811
812         Reviewed by Daniel Bates.
813
814         * Misc/WebDownload.mm:
815         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
816         * Misc/WebDownloadInternal.h:
817         * WebCoreSupport/WebFrameLoaderClient.mm:
818         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
819         * WebView/WebPreferences.mm:
820         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
821         * WebView/WebView.mm:
822         (-[WebView scheduleInRunLoop:forMode:]):
823         (-[WebView unscheduleFromRunLoop:forMode:]):
824
825 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
826
827         Add ENABLE_ENCRYPTED_MEDIA configuration option
828         https://bugs.webkit.org/show_bug.cgi?id=163219
829
830         Reviewed by Darin Adler.
831
832         * Configurations/FeatureDefines.xcconfig:
833         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
834         to enable or disable the new EME implementation at build-time.
835
836 2016-10-10  Darin Adler  <darin@apple.com>
837
838         Move NotificationCenter from legacy to new DOM exceptions
839         https://bugs.webkit.org/show_bug.cgi?id=163217
840
841         Reviewed by Chris Dumez.
842
843         * WebView/WebView.mm:
844         (-[WebView _notificationIDForTesting:]): Pass reference to page rather than pointer.
845
846 2016-10-09  Wenson Hsieh  <wenson_hsieh@apple.com>
847
848         Support InputEvent.inputType for the new InputEvent spec
849         https://bugs.webkit.org/show_bug.cgi?id=163025
850         <rdar://problem/28658092>
851
852         Reviewed by Darin Adler.
853
854         Accounts for some changes to the EditAction enum in nameForEditAction. See WebCore ChangeLog
855         entry for more details.
856
857         * WebCoreSupport/WebEditorClient.mm:
858         (undoNameForEditAction):
859
860 2016-10-06  Darin Adler  <darin@apple.com>
861
862         Next step on moving to modern way to return DOM exceptions
863         https://bugs.webkit.org/show_bug.cgi?id=163016
864
865         Reviewed by Ryosuke Niwa.
866
867         * DOM/DOMDOMImplementation.mm:
868         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated for
869         name change from takeReturnValue to releaseReturnValue.
870         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
871
872 2016-10-07  Simon Fraser  <simon.fraser@apple.com>
873
874         [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
875         https://bugs.webkit.org/show_bug.cgi?id=163154
876         rdar://problem/28674216
877
878         Reviewed by Tim Horton.
879         
880         r55159 added code to counteract AppKit's adjustment of dirty regions during scrolling,
881         by offsetting the dirty rect in -setNeedsDisplayInRect: if the call happens during
882         the NSViewBoundsDidChangeNotification handling.
883         
884         However, AppKit only does dirty region adjustment in the code path that blits ("copy
885         on scroll"), so r55159 produces incorrect behavior in, for example, layer-backed views.
886         
887         Fix by overriding -[NSClipView _canCopyOnScrollForDeltaX:deltaY:] to know if a single
888         scroll is going to blit, and only do adjustments in -setNeedsDisplayInRect: if it is.
889
890         * WebView/WebClipView.h:
891         * WebView/WebClipView.mm:
892         (-[WebClipView _immediateScrollToPoint:]):
893         (-[WebClipView _canCopyOnScrollForDeltaX:deltaY:]):
894         (-[WebClipView currentScrollIsBlit]):
895         * WebView/WebHTMLView.mm:
896         (-[WebHTMLView setNeedsDisplayInRect:]):
897         (-[WebHTMLView drawRect:]):
898
899 2016-10-06  Youenn Fablet  <youenn@apple.com>
900
901         CachedResource client handling methods should take reference
902         https://bugs.webkit.org/show_bug.cgi?id=163014
903
904         Reviewed by Alex Christensen.
905
906         * WebView/WebHTMLView.mm:
907         (promisedDataClient):
908
909 2016-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
910
911         Put variation fonts work behind a compile-time flag
912         https://bugs.webkit.org/show_bug.cgi?id=162949
913
914         Reviewed by Simon Fraser.
915
916         * Configurations/FeatureDefines.xcconfig:
917
918 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
919
920         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
921         https://bugs.webkit.org/show_bug.cgi?id=162903
922
923         Reviewed by Alex Christensen.
924
925         Rename build guards for the remaining implementation of the legacy EME API
926         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
927         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
928
929         * Configurations/FeatureDefines.xcconfig:
930         * WebView/WebPreferences.mm:
931         (+[WebPreferences initialize]):
932         * WebView/WebView.mm:
933         (-[WebView _preferencesChanged:]):
934
935 2016-10-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
936
937         The dragged image should be the current frame only of the animated image
938         https://bugs.webkit.org/show_bug.cgi?id=162109
939
940         Reviewed by Tim Horton.
941
942         * DOM/DOM.mm:
943         (-[DOMElement image]): Call the Image function with its new name.
944         (-[DOMElement _imageTIFFRepresentation]): Ditto.
945         * Misc/WebElementDictionary.mm:
946         (-[WebElementDictionary _image]): Call the Image function with its new name.
947         * Misc/WebIconDatabase.mm:
948         (-[WebIconDatabase defaultIconWithSize:]): Call snapshotNSImage() to create the icon image.
949         (webGetNSImage): Call the Image function with its new name.
950         * WebCoreSupport/WebContextMenuClient.mm:
951         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call snapshotNSImage() instead of nsImage()..
952         (WebContextMenuClient::contextMenuForEvent): Ditto.
953         * WebView/WebHTMLView.mm:
954         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
955
956 2016-10-02  Ryan Haddad  <ryanhaddad@apple.com>
957
958         Unreviewed, rolling out r206683.
959
960         This change caused API test WebKit2.FindMatches to fail on
961         Mac.
962
963         Reverted changeset:
964
965         "The dragged image should be the current frame only of the
966         animated image"
967         https://bugs.webkit.org/show_bug.cgi?id=162109
968         http://trac.webkit.org/changeset/206683
969
970 2016-09-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
971
972         The dragged image should be the current frame only of the animated image
973         https://bugs.webkit.org/show_bug.cgi?id=162109
974
975         Reviewed by Tim Horton.
976
977         * DOM/DOM.mm:
978         (-[DOMElement image]): Call the Image function with its new name.
979         (-[DOMElement _imageTIFFRepresentation]): Ditto.
980         * Misc/WebElementDictionary.mm:
981         (-[WebElementDictionary _image]): Call the Image function with its new name.
982         * Misc/WebIconDatabase.mm:
983         (-[WebIconDatabase defaultIconWithSize:]): Call currentFrameNSImage() to create the icon image.
984         (webGetNSImage): Call the Image function with its new name.
985         * WebCoreSupport/WebContextMenuClient.mm:
986         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call currentFrameNSImage() instead of nsImage()..
987         (WebContextMenuClient::contextMenuForEvent): Ditto.
988         * WebView/WebHTMLView.mm:
989         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
990
991 2016-09-27  Jer Noble  <jer.noble@apple.com>
992
993         Remove deprecated ENCRYPTED_MEDIA implementation.
994         https://bugs.webkit.org/show_bug.cgi?id=161010
995
996         Remove ENABLE_ENCRYPTED_MEDIA.
997
998         Reviewed by Eric Carlson.
999
1000         * Configurations/FeatureDefines.xcconfig:
1001
1002 2016-09-26  Daniel Bates  <dabates@apple.com>
1003
1004         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
1005         https://bugs.webkit.org/show_bug.cgi?id=162365
1006
1007         Reviewed by Simon Fraser.
1008
1009         * Configurations/FeatureDefines.xcconfig:
1010         * WebView/WebFrame.mm:
1011         * WebView/WebPreferences.mm:
1012         (+[WebPreferences initialize]):
1013         * WebView/WebView.mm:
1014         (-[WebView _preferencesChanged:]):
1015
1016 2016-09-25  Antti Koivisto  <antti@apple.com>
1017
1018         AuthorStyleSheets shouldn't trigger synchronous style resolutions
1019         https://bugs.webkit.org/show_bug.cgi?id=162532
1020
1021         Reviewed by Darin Adler.
1022
1023         * WebView/WebHTMLView.mm:
1024         (-[WebHTMLView reapplyStyles]):
1025         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1026
1027 2016-09-24  Antti Koivisto  <antti@apple.com>
1028
1029         Move stylesheet change logic from Document to AuthorStyleSheets
1030         https://bugs.webkit.org/show_bug.cgi?id=162488
1031
1032         Reviewed by Andreas Kling.
1033
1034         * WebView/WebHTMLView.mm:
1035         (-[WebHTMLView reapplyStyles]):
1036         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1037
1038 2016-09-23  Caitlin Potter  <caitp@igalia.com>
1039
1040         [JSC] Implement parsing of Async Functions
1041         https://bugs.webkit.org/show_bug.cgi?id=161409
1042
1043         Reviewed by Yusuke Suzuki.
1044
1045         * Configurations/FeatureDefines.xcconfig:
1046
1047 2016-09-23  Commit Queue  <commit-queue@webkit.org>
1048
1049         Unreviewed, rolling out r206311.
1050         https://bugs.webkit.org/show_bug.cgi?id=162495
1051
1052         Broke internal iOS build (Requested by anttik on #webkit).
1053
1054         Reverted changeset:
1055
1056         "Move stylesheet change logic from Document to
1057         AuthorStyleSheets"
1058         https://bugs.webkit.org/show_bug.cgi?id=162488
1059         http://trac.webkit.org/changeset/206311
1060
1061 2016-09-23  Antoine Quint  <graouts@apple.com>
1062
1063         Add a new runtime flag for work on modern media controls (off by default)
1064         https://bugs.webkit.org/show_bug.cgi?id=162420
1065         <rdar://problem/27989489>
1066
1067         Reviewed by Eric Carlson.
1068
1069         * WebView/WebPreferenceKeysPrivate.h:
1070         * WebView/WebPreferences.mm:
1071         (-[WebPreferences modernMediaControlsEnabled]):
1072         (-[WebPreferences setModernMediaControlsEnabled:]):
1073         * WebView/WebPreferencesPrivate.h:
1074         * WebView/WebView.mm:
1075         (-[WebView _preferencesChanged:]):
1076
1077 2016-09-21  Anders Carlsson  <andersca@apple.com>
1078
1079         Support openPaymentSetup API on ApplePaySession object
1080         https://bugs.webkit.org/show_bug.cgi?id=162357
1081         rdar://problem/26776939
1082
1083         Reviewed by Tim Horton.
1084
1085         Add openPaymentSetup stub.
1086
1087         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1088         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1089         (WebPaymentCoordinatorClient::openPaymentSetup):
1090
1091 2016-09-19  Daniel Bates  <dabates@apple.com>
1092
1093         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
1094         https://bugs.webkit.org/show_bug.cgi?id=162167
1095
1096         Reviewed by Simon Fraser.
1097
1098         * Configurations/FeatureDefines.xcconfig:
1099
1100 2016-09-19  Joseph Pecoraro  <pecoraro@apple.com>
1101
1102         Web Inspector: Bring the inspected page's window forward when activating element search
1103         https://bugs.webkit.org/show_bug.cgi?id=162114
1104         <rdar://problem/28349357>
1105
1106         Reviewed by Brian Burg.
1107
1108         * WebCoreSupport/WebInspectorClient.mm:
1109         (WebInspectorClient::didSetSearchingForNode):
1110         When element search is activated bring the window
1111         containing the inspected page to the foreground.
1112
1113 2016-09-15  Brady Eidson  <beidson@apple.com>
1114
1115         WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
1116         <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
1117
1118         Reviewed by Brent Fulgham. 
1119
1120         * WebCoreSupport/WebFrameLoaderClient.h:
1121         * WebCoreSupport/WebFrameLoaderClient.mm:
1122         (WebFrameLoaderClient::dispatchDidCommitLoad):
1123
1124 2016-09-15  Anders Carlsson  <andersca@apple.com>
1125
1126         This was supposed to be committed with the previous patch!
1127
1128         * Plugins/WebBasePluginPackage.mm:
1129         (pathByResolvingSymlinksAndAliases): Deleted.
1130
1131 2016-09-15  Anders Carlsson  <andersca@apple.com>
1132
1133         Replace use of Carbon file system APIs in plug-in loading
1134         https://bugs.webkit.org/show_bug.cgi?id=162040
1135         rdar://problem/6017896
1136
1137         Reviewed by Sam Weinig.
1138
1139         * Plugins/WebBasePluginPackage.mm:
1140         (-[WebBasePluginPackage initWithPath:]):
1141         Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
1142         to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).
1143
1144 2016-09-15  Beth Dakin  <bdakin@apple.com>
1145
1146         Need hasMarkedText on Mac
1147         https://bugs.webkit.org/show_bug.cgi?id=162026
1148         -and corresponding-
1149         rdar://problem/28272353
1150
1151         Reviewed by Anders Carlsson.
1152
1153         * WebView/WebHTMLViewInternal.h:
1154
1155 2016-09-12  Dean Jackson  <dino@apple.com>
1156
1157         Replace RGBA32 with Color in member variables
1158         https://bugs.webkit.org/show_bug.cgi?id=161856
1159         <rdar://problem/28254324>
1160
1161         Reviewed by Simon Fraser.
1162
1163         In preparation for the Color class to become more than
1164         just a 4-byte RGBA value, I went through a few places
1165         that were using the RGBA32 type directly, and replaced
1166         them with Color. This will make some objects a little
1167         bigger e.g. BorderValue and its friends.
1168
1169         I mostly looked at the places that were using RGBA32 as
1170         a member variable. There is still a lot of RGBA32 use
1171         around the project, in particular the CSS parser.
1172
1173         There should be no behaviour change.
1174
1175         * Misc/WebKitNSStringExtras.mm:
1176         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Explicitly
1177         call a Color constructor, rather than passing an RGBA32.
1178
1179 2016-09-13  Chris Dumez  <cdumez@apple.com>
1180
1181         Drop support for <isindex>
1182         https://bugs.webkit.org/show_bug.cgi?id=7139
1183
1184         Reviewed by Ryosuke Niwa.
1185
1186         Drop references to isindex.
1187
1188         * WebCoreSupport/WebEditorClient.mm:
1189         (attributesForAttributedStringConversion):
1190         * WebView/WebHTMLView.mm:
1191         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1192
1193 2016-09-12  Chris Dumez  <cdumez@apple.com>
1194
1195         Switch remaining users of Document::inPageCache() to pageCacheState()
1196         https://bugs.webkit.org/show_bug.cgi?id=161865
1197
1198         Reviewed by Darin Adler.
1199
1200         Switch remaining users of Document::inPageCache() to pageCacheState() as
1201         the former one is confusing (given that it returns true while the
1202         pagehide event is being fired).
1203
1204         * WebView/WebHTMLView.mm:
1205         (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]):
1206         (-[WebHTMLView setNeedsLayout:]):
1207         (-[WebHTMLView setNeedsToApplyStyles:]):
1208
1209 2016-09-09  Tim Horton  <timothy_horton@apple.com>
1210
1211         Text replacement candidates don't always overwrite the entire original string
1212         https://bugs.webkit.org/show_bug.cgi?id=161779
1213         <rdar://problem/28033492>
1214
1215         Reviewed by Simon Fraser.
1216
1217         * WebCoreSupport/WebEditorClient.mm:
1218         (WebEditorClient::requestCandidatesForSelection):
1219         Make use of the shared implementation of contextRangeForCandidateRequest.
1220
1221 2016-09-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
1222
1223         Move the BitmapImage platform dependent code to a new file named NativeImage[CG|Cairo].cpp
1224         https://bugs.webkit.org/show_bug.cgi?id=158684
1225
1226         Reviewed by Simon Fraser.
1227
1228         * DOM/DOM.mm:
1229         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1230         * Misc/WebCache.mm:
1231         (+[WebCache imageForURL:]):
1232         Replace BitmapImage::getCGImageRef() with BitmapImage::nativeImage().
1233
1234 2016-09-07  Joseph Pecoraro  <pecoraro@apple.com>
1235
1236         [Mac] Address some clang static analyzer warnings in WebKit
1237         https://bugs.webkit.org/show_bug.cgi?id=161597
1238
1239         Reviewed by Darin Adler.
1240
1241         * Misc/WebIconDatabase.h:
1242         Remove unused instance variable. It has not been used since r16005 (2006)!
1243
1244         * Misc/WebSharingServicePickerController.mm:
1245         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1246         Address array leak.
1247
1248         * WebCoreSupport/WebSelectionServiceController.mm:
1249         (WebSelectionServiceController::hasRelevantSelectionServices):
1250         Address attachment and cell leak.
1251
1252         * WebView/WebFullScreenController.h:
1253         * WebView/WebImmediateActionController.h:
1254         Remove unused instance variables.
1255
1256 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
1257
1258         Enable the <meter> element on iOS
1259         https://bugs.webkit.org/show_bug.cgi?id=161714
1260         rdar://problem/8978410
1261
1262         Reviewed by Tim Horton.
1263
1264         Define ENABLE_METER_ELEMENT unconditionally now.
1265
1266         * Configurations/FeatureDefines.xcconfig:
1267
1268 2016-09-07  Mark Lam  <mark.lam@apple.com>
1269
1270         Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
1271         https://bugs.webkit.org/show_bug.cgi?id=161498
1272
1273         Reviewed by Geoffrey Garen.
1274
1275         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1276         (WebKit::NetscapePluginInstanceProxy::evaluate):
1277         (WebKit::NetscapePluginInstanceProxy::invoke):
1278         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1279         (WebKit::NetscapePluginInstanceProxy::construct):
1280         (WebKit::NetscapePluginInstanceProxy::getProperty):
1281         (WebKit::NetscapePluginInstanceProxy::setProperty):
1282         (WebKit::NetscapePluginInstanceProxy::removeProperty):
1283         (WebKit::NetscapePluginInstanceProxy::hasProperty):
1284         (WebKit::NetscapePluginInstanceProxy::hasMethod):
1285         (WebKit::NetscapePluginInstanceProxy::enumerate):
1286         * WebView/WebView.mm:
1287         (aeDescFromJSValue):
1288
1289 2016-09-07  Youenn Fablet  <youenn@apple.com>
1290
1291         [Streams API] Separate compile flag for ReadableStream and WritableStream
1292         https://bugs.webkit.org/show_bug.cgi?id=161044
1293
1294         Reviewed by Alex Christensen.
1295
1296         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
1297
1298         * Configurations/FeatureDefines.xcconfig:
1299
1300 2016-09-06  Chris Dumez  <cdumez@apple.com>
1301
1302         Add support for input.minLength / textArea.minLength
1303         https://bugs.webkit.org/show_bug.cgi?id=161644
1304
1305         Reviewed by Darin Adler.
1306
1307         Update ObjC bindings to reflect method renaming.
1308
1309         * DOM/DOMHTMLInputElement.mm:
1310         (-[DOMHTMLInputElement maxLength]):
1311         (-[DOMHTMLInputElement setMaxLength:]):
1312         * DOM/DOMHTMLTextAreaElement.mm:
1313         (-[DOMHTMLTextAreaElement maxLength]):
1314         (-[DOMHTMLTextAreaElement setMaxLength:]):
1315
1316 2016-09-06  Dan Bernstein  <mitz@apple.com>
1317
1318         <rdar://problem/8064563> Ugly NSLog in DOMInternal.mm
1319
1320         Rubber-stamped by Anders Carlsson.
1321
1322         * DOM/DOMInternal.mm:
1323         (-[WebScriptObject _initializeScriptDOMNodeImp]): Removed useless call to NSLog.
1324
1325 2016-09-06  Ryan Haddad  <ryanhaddad@apple.com>
1326
1327         Unreviewed, rolling out r205407.
1328
1329         Not the correct way to implement this functionality
1330
1331         Reverted changeset:
1332
1333         "Consult with the FrameLoaderClient about whether or not
1334         content extensions should be enabled when loading this URL."
1335         https://bugs.webkit.org/show_bug.cgi?id=161441
1336         http://trac.webkit.org/changeset/205407
1337
1338 2016-09-05  Darin Adler  <darin@apple.com>
1339
1340         More bindings improvements, particularly things not needed for JavaScript bindings
1341         https://bugs.webkit.org/show_bug.cgi?id=161572
1342
1343         Reviewed by Sam Weinig.
1344
1345         * DOM/DOMDOMImplementation.mm:
1346         (-[DOMImplementation hasFeature:version:]): Call SVGTests::hasFeatureForLegacyBindings
1347         instead of DOMImplementation::hasFeature. Also removed JSMainThreadNullState
1348         since this does not do anything that can invoke JavaScript.
1349
1350         * DOM/DOMDocument.mm:
1351         (-[DOMDocument defaultCharset]): Call defaultCharsetForLegacyBindings. Also removed
1352         JSMainThreadNullState.
1353
1354         * DOM/DOMDocumentType.mm:
1355         (-[DOMDocumentType entities]): Changed to simply return nil; same behavior as before,
1356         but with no dependency on WebCore. Also removed JSMainThreadNullState.
1357         (-[DOMDocumentType notations]): Ditto.
1358         (-[DOMDocumentType internalSubset]): Ditto, except empty string rather than nil.
1359
1360         * DOM/DOMNode.mm:
1361         (-[DOMNode isSupported:version:]): Call SVGTests::hasFeatureForLegacyBindings
1362         instead of Node::isSupportedForBindings. Also removed JSMainThreadNullState.
1363
1364 2016-09-04  Joseph Pecoraro  <pecoraro@apple.com>
1365
1366         Remove unnecessary RetainPtr.
1367
1368         Review comments on earlier change.
1369
1370         * WebView/WebImmediateActionController.mm:
1371         (-[WebImmediateActionController _defaultAnimationController]):
1372
1373 2016-09-03  Darin Adler  <darin@apple.com>
1374
1375         Streamline DOMImplementation, and move it to our new DOM exception system
1376         https://bugs.webkit.org/show_bug.cgi?id=161295
1377
1378         Reviewed by Ryosuke Niwa.
1379
1380         * DOM/DOMDOMImplementation.mm:
1381         (unwrap): Added. Use this instead of the IMPL macro.
1382         (-[DOMImplementation dealloc]): Updated to use unwrap.
1383         (-[DOMImplementation hasFeature:version:]): Ditto.
1384         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated to work with
1385         ExceptionOr.
1386         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
1387         (-[DOMImplementation createCSSStyleSheet:media:]): Removed exception logic since
1388         this function can no longer raise an exception.
1389         (-[DOMImplementation createHTMLDocument:]): Updated to use unwrap.
1390         (-[DOMImplementation hasFeature::]): Changed to call the non-deprecated version
1391         rather than duplicating its implementation. Also moved into the category as defined
1392         in the header.
1393         (-[DOMImplementation createDocumentType:::]): Ditto.
1394         (-[DOMImplementation createDocument:::]): Ditto.
1395         (-[DOMImplementation createCSSStyleSheet::]): Ditto.
1396
1397         * DOM/DOMDocument.mm: Removed unneeded include of DOMImplementation.h.
1398         (-[DOMDocument setXmlStandalone:]): Updated since setXMLStandalone no longer can
1399         raise an exception.
1400
1401         * WebView/WebFrame.mm:
1402         (-[WebFrame _canProvideDocumentSource]): Updated to use isTextMIMEType in its new
1403         location in MIMETypeRegistry instead of in DOMImplementation.
1404
1405 2016-09-03  Brian Weinstein  <bweinstein@apple.com>
1406
1407         Implement a stub version of FrameLoaderClient::shouldUseContentExtensionsForURL.
1408         https://bugs.webkit.org/show_bug.cgi?id=16144
1409
1410         Reviewed by Darin Adler.
1411
1412         * WebCoreSupport/WebFrameLoaderClient.h:
1413
1414 2016-09-02  Beth Dakin  <bdakin@apple.com>
1415
1416         Need to updateEditorState if an element change edit-ability without changing 
1417         selection
1418         https://bugs.webkit.org/show_bug.cgi?id=161546
1419         -and corresponding-
1420         rdar://problem/27806012
1421
1422         Reviewed by Ryosuke Niwa.
1423
1424         Every time WebEditorClient::respondToChangedSelection is called, we now save 
1425         whether the last state was contentEditable. That way in 
1426         updateEditorStateAfterLayoutIfNeeded() we can assess whether or not edit-ability 
1427         has changed. 
1428
1429         * WebCoreSupport/WebEditorClient.h:
1430         * WebCoreSupport/WebEditorClient.mm:
1431         (WebEditorClient::respondToChangedSelection):
1432         (WebEditorClient:: updateEditorStateAfterLayoutIfEditabilityChanged):
1433
1434 2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
1435
1436         [Mac] RetainPtr misuse, AnimationController leaks
1437         https://bugs.webkit.org/show_bug.cgi?id=161552
1438
1439         Reviewed by Tim Horton.
1440
1441         * WebView/WebImmediateActionController.mm:
1442         (-[WebImmediateActionController _defaultAnimationController]):
1443
1444 2016-07-08  Jer Noble  <jer.noble@apple.com>
1445
1446         Refactor WebPlaybackSessionModelMediaElement to be client based.
1447         https://bugs.webkit.org/show_bug.cgi?id=159580
1448
1449         Reviewed by Eric Carlson.
1450
1451         No longer necessary to tell the models and interfaces about each other.
1452
1453         * WebView/WebView.mm:
1454         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1455         (-[WebView _clearPlaybackControlsManager]):
1456
1457 2016-09-01  Dan Bernstein  <mitz@apple.com>
1458
1459         Build fix.
1460
1461         * Configurations/FeatureDefines.xcconfig:
1462
1463 2016-09-01  Myles C. Maxfield  <mmaxfield@apple.com>
1464
1465         Clean up TextRun-related code
1466         https://bugs.webkit.org/show_bug.cgi?id=161473
1467
1468         Reviewed by Simon Fraser.
1469
1470         Remove unused #includes.
1471
1472         * WebCoreSupport/WebDragClient.mm:
1473         * WebView/WebView.mm:
1474
1475 2016-08-31  Keith Rollin  <krollin@apple.com>
1476
1477         WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
1478         https://bugs.webkit.org/show_bug.cgi?id=160969
1479         <rdar://problem/26068734>
1480
1481         Reviewed by Simon Fraser.
1482
1483         Enable subsystem- and channel-related data and functions when using
1484         RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
1485         and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
1486
1487         * Misc/WebKitLogging.h:
1488         * Misc/WebKitLogging.m:
1489         * WebView/WebView.mm:
1490         (-[WebView _commonInitializationWithFrameName:groupName:]):
1491
1492 2016-08-31  Brady Eidson  <beidson@apple.com>
1493
1494         WK2 Gamepad provider on iOS.
1495         https://bugs.webkit.org/show_bug.cgi?id=161412
1496
1497         Reviewed by Tim Horton.
1498
1499         * Configurations/FeatureDefines.xcconfig:
1500
1501         * WebView/WebView.mm:
1502         (WebKitInitializeGamepadProviderIfNecessary):
1503
1504 2016-08-30  Mark Lam  <mark.lam@apple.com>
1505
1506         Introduce the ThrowScope and force every throw site to instantiate a ThrowScope.
1507         https://bugs.webkit.org/show_bug.cgi?id=161171
1508
1509         Reviewed by Filip Pizlo and Geoffrey Garen.
1510
1511         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1512         (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
1513         * Plugins/Hosted/ProxyInstance.mm:
1514         (WebKit::ProxyInstance::invokeMethod):
1515
1516 2016-08-28  Andreas Kling  <akling@apple.com>
1517
1518         document.title setter can't throw.
1519         <https://webkit.org/b/161302>
1520
1521         Reviewed by Antti Koivisto.
1522
1523         * DOM/DOMDocument.mm:
1524         (-[DOMDocument setTitle:]):
1525
1526 2016-08-28  Andreas Kling  <akling@apple.com>
1527
1528         Clean up some .text attribute setters that don't throw.
1529         <https://webkit.org/b/161292>
1530
1531         Reviewed by Darin Adler.
1532
1533         * DOM/DOMHTMLTitleElement.mm:
1534         (-[DOMHTMLTitleElement setText:]):
1535
1536 2016-08-26  Sam Weinig  <sam@webkit.org>
1537
1538         Remove support for ENABLE_LEGACY_WEB_AUDIO
1539         https://bugs.webkit.org/show_bug.cgi?id=161262
1540
1541         Reviewed by Anders Carlsson.
1542
1543         * Configurations/FeatureDefines.xcconfig:
1544         Remove ENABLE_LEGACY_WEB_AUDIO
1545
1546 2016-08-25  Anders Carlsson  <andersca@apple.com>
1547
1548         Re-export DOMException NSStrings after r204717
1549         https://bugs.webkit.org/show_bug.cgi?id=161200
1550         <rdar://problem/27959937>
1551
1552         Reviewed by Alex Christensen.
1553
1554         * DOM/ExceptionHandlers.mm:
1555         (raiseDOMException):
1556         * WebKit.exp:
1557
1558 2016-08-22  Darin Adler  <darin@apple.com>
1559
1560         Move Objective-C DOM bindings from WebCore to legacy WebKit
1561         https://bugs.webkit.org/show_bug.cgi?id=160654
1562
1563         Reviewed by Alex Christensen.
1564
1565         * DOM: Added lots of files to the directory.
1566         The files are just as they were in bindings/objc except that the paths of includes
1567         have been updated as needed, and the code no longer is defined inside the WebCore
1568         namespace, requring changes to various functions and their call sites. Also removed
1569         all the WEBCORE_EXPORT since we export differently here in legacy WebKit.
1570
1571         * DOM/DOMInternal.h: Moved. Replaced createDOMWrapper with initializeDOMWrapperHooks.
1572         * DOM/DOMUtility.mm: Moved.
1573         (createDOMWrapper): Simplified to use toWrapped and not do unneeded namespace tricks.
1574         (disconnectWindowWrapper): Added.
1575         (initializeDOMWrapperHooks): Added.
1576
1577         * MigrateHeaders.make: Removed all the internal headers since they are now just
1578         normal project headers. Added the "DOM" directory to the VPATH. Some of the headers
1579         from WebCore are still being migrated, so we can't remove WebCorePrivateHeaders yet.
1580
1581         * WebCoreSupport/WebEditorClient.h: Updated to return RefPtr<DocumentFragment>.
1582
1583         * WebCoreSupport/WebEditorClient.mm:
1584         (WebEditorClient::documentFragmentFromDelegate): Use RefPtr.
1585
1586         * WebKit.exp: Added exports for all the classes that used to use WEBCORE_EXPORT to
1587         be exported from WebCore.
1588
1589         * WebView/WebFrame.mm:
1590         (-[WebFrame innerLineHeight:]): Moved code from WebCore::Frame::innerLineHeight here.
1591         No longer depend on whether this node happens to be in this frame. Also removed
1592         unneeded null check since a node's document can't be null.
1593
1594         * WebView/WebHTMLView.mm: Removed uneeded include of ExceptionHandlers.h, which
1595         is now here in WebKitLegacy instead of WebCore. But no need to include it at all.
1596
1597         * WebView/WebView.mm:
1598         (-[WebView _commonInitializationWithFrameName:groupName:]): Call
1599         initializeDOMWrapperHooks so WebScriptObject can create DOM binding wrappers when
1600         making a script object for a DOM object, rather than just a generic script object.
1601         (+[WebView enableWebThread]): Added a call to WebCoreObjCDeallocOnWebThread here for
1602         DOMObject along with the other classes. This was done in WebCore before, but DOMObject is now
1603         defined here in legacy WebKit.
1604         (-[WebView styleAtSelectionStart]): Moved code from WebCore::Frame::styleAtSelectionStart here.
1605         Replaced incorrect code that called "new PropertySetCSSStyleDeclaration" with a misleading comment
1606         about reference counting; that code was leaking all the style declarations. Instead use
1607         MutableStyleProperties::ensureCSSStyleDeclaration, which is designed for this purpose.
1608
1609 2016-08-22  Youenn Fablet  <youenn@apple.com>
1610
1611         [Fetch API] Activate fetch api runtime flag by default
1612         https://bugs.webkit.org/show_bug.cgi?id=160452
1613
1614         Reviewed by Alex Christensen.
1615
1616         * WebView/WebPreferences.mm:
1617         (+[WebPreferences initialize]):
1618
1619 2016-08-21  Alex Christensen  <achristensen@webkit.org>
1620
1621         Use Document& instead of Document* when getting cookies
1622         https://bugs.webkit.org/show_bug.cgi?id=161011
1623
1624         Reviewed by Darin Adler.
1625
1626         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1627         (WebKit::NetscapePluginInstanceProxy::getCookies):
1628         (WebKit::NetscapePluginInstanceProxy::setCookies):
1629         * Plugins/WebNetscapePluginView.mm:
1630         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1631         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1632
1633 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
1634
1635         Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
1636         https://bugs.webkit.org/show_bug.cgi?id=160923
1637
1638         Reviewed by Tim Horton.
1639
1640         * WebCoreSupport/WebFrameLoaderClient.h:
1641         * WebCoreSupport/WebFrameLoaderClient.mm:
1642         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1643         (WebFrameLoaderClient::dispatchDidLayout): Deleted.
1644
1645 2016-08-18  Daniel Bates  <dabates@apple.com>
1646
1647         Ld warns of non-existent PrivateFrameworks directory when building WebKit with the public iOS 9.3 SDK
1648         https://bugs.webkit.org/show_bug.cgi?id=160979
1649
1650         Rubber-stamped by Simon Fraser.
1651
1652         Only add the SDK PrivateFrameworks directory to the FRAMEWORK_SEARCH_PATH when building for
1653         iOS Simulator, building with an iOS SDK that does not support text-based stubs, or building
1654         an Apple-internal build.
1655
1656         * Configurations/WebKitLegacy.xcconfig:
1657
1658 2016-08-18  Anders Carlsson  <andersca@apple.com>
1659
1660         Move an NPAPI-only function from WebCore to WebKit
1661         https://bugs.webkit.org/show_bug.cgi?id=160967
1662
1663         Reviewed by Sam Weinig.
1664
1665         * Plugins/WebNetscapePluginView.h:
1666         * Plugins/WebNetscapePluginView.mm:
1667         (-[WebNetscapePluginView getVariable:value:]):
1668         (-[WebNetscapePluginView _destroyPlugin]):
1669
1670 2016-08-18  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
1671
1672         [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
1673         https://bugs.webkit.org/show_bug.cgi?id=156096
1674
1675         Reviewed by Dean Jackson.
1676
1677         Adds:
1678         - Setup interface for enabling runtime flag for Web animations through preferences.
1679
1680         * WebView/WebPreferenceKeysPrivate.h:
1681         * WebView/WebPreferences.mm:
1682         (+[WebPreferences initialize]):
1683         (-[WebPreferences webAnimationsEnabled]):
1684         (-[WebPreferences setWebAnimationsEnabled:]):
1685         * WebView/WebPreferencesPrivate.h:
1686         * WebView/WebView.mm:
1687         (-[WebView _preferencesChanged:]):
1688
1689 2016-08-17  Anders Carlsson  <andersca@apple.com>
1690
1691         Remove a couple of unused WKSI function pointers
1692         https://bugs.webkit.org/show_bug.cgi?id=160946
1693
1694         Reviewed by Dan Bernstein.
1695
1696         * WebCoreSupport/WebSystemInterface.mm:
1697         (InitWebCoreSystemInterface): Deleted.
1698
1699 2016-08-16  Daniel Bates  <dabates@apple.com>
1700
1701         WKSI static library should be named by major iOS revision, not individual updates
1702         https://bugs.webkit.org/show_bug.cgi?id=160727
1703         <rdar://problem/22274848>
1704
1705         Reviewed by Alexey Proskuryakov.
1706
1707         * Configurations/Base.xcconfig:
1708         * Configurations/DebugRelease.xcconfig:
1709         * Configurations/WebKitLegacy.xcconfig:
1710
1711 2016-08-16  Darin Adler  <darin@apple.com>
1712
1713         [Cocoa] Remove dependency on Objective-C bindings in WebKit2 editing code
1714         https://bugs.webkit.org/show_bug.cgi?id=160891
1715
1716         Reviewed by Anders Carlsson.
1717
1718         * WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
1719
1720         * WebCoreSupport/WebEditorClient.mm:
1721         (attributesForAttributedStringConversion): Replaced the
1722         createExcludedElementsForAttributedStringConversion function with this one.
1723         No good reason to keep the array around instead of the dictionary.
1724         (_WebCreateFragment): Renamed from documentFragmentFromAttributedString.
1725         This is now a global function exported so it can be called by WebCore with
1726         a different way of returning its value.
1727
1728         * WebKit.exp: Added _WebCreateFragment.
1729
1730         * WebView/WebHTMLView.mm:
1731         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1732         Removed long-ago-obsolete workaround for Radar bug 5052369.
1733
1734 2016-08-15  Anders Carlsson  <andersca@apple.com>
1735
1736         Another build fix.
1737
1738         * WebKit.exp:
1739
1740 2016-08-15  Anders Carlsson  <andersca@apple.com>
1741
1742         Fix build.
1743
1744         * Configurations/WebKitLegacy.xcconfig:
1745         * WebKit.mac.exp:
1746
1747 2016-08-15  Anders Carlsson  <andersca@apple.com>
1748
1749         Remove OldWebAssertions.c
1750         https://bugs.webkit.org/show_bug.cgi?id=160862
1751
1752         Reviewed by Dan Bernstein.
1753
1754         These functions were used by an old version of iWeb. The latest version of iWeb no longer uses them.
1755
1756         * Misc/OldWebAssertions.c: Removed.
1757         (WebReportAssertionFailure): Deleted.
1758         (WebReportError): Deleted.
1759
1760 2016-08-15  Anders Carlsson  <andersca@apple.com>
1761
1762         Remove WebKeyGenerator
1763         https://bugs.webkit.org/show_bug.cgi?id=160854
1764
1765         Reviewed by Dan Bernstein.
1766
1767         This SPI class is no longer used by Safari.
1768
1769         * WebCoreSupport/WebKeyGenerator.h: Removed.
1770         * WebCoreSupport/WebKeyGenerator.mm: Removed.
1771         (+[WebKeyGenerator sharedGenerator]): Deleted.
1772         (toWebCertificateParseResult): Deleted.
1773         (-[WebKeyGenerator addCertificatesToKeychainFromData:]): Deleted.
1774         * WebView/WebFrameView.mm:
1775
1776 2016-08-15  Daniel Bates  <dabates@apple.com>
1777
1778         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
1779         private frameworks and libraries
1780         https://bugs.webkit.org/show_bug.cgi?id=155931
1781         <rdar://problem/25807989>
1782
1783         Reviewed by Dan Bernstein.
1784
1785         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
1786         where X is the major version of the active iOS SDK.
1787
1788         * Configurations/WebKitLegacy.xcconfig:
1789
1790 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1791
1792         Add a setting and preferences to enable visual viewport mode
1793         https://bugs.webkit.org/show_bug.cgi?id=160843
1794
1795         Reviewed by Sam Weinig.
1796
1797         Hook up the visualViewportEnabled setting for WebKit1.
1798
1799         * WebView/WebPreferenceKeysPrivate.h:
1800         * WebView/WebPreferences.mm:
1801         (+[WebPreferences initialize]):
1802         (-[WebPreferences visualViewportEnabled]):
1803         (-[WebPreferences setVisualViewportEnabled:]):
1804         * WebView/WebPreferencesPrivate.h:
1805
1806 2016-08-15  Joseph Pecoraro  <pecoraro@apple.com>
1807
1808         Remove unused includes of wtf headers
1809         https://bugs.webkit.org/show_bug.cgi?id=160839
1810
1811         Reviewed by Alex Christensen.
1812
1813         * History/BinaryPropertyList.cpp:
1814         * History/WebBackForwardList.mm:
1815         * History/WebHistoryItemInternal.h:
1816         * Misc/WebNSFileManagerExtras.mm:
1817         * Plugins/Hosted/NetscapePluginHostProxy.h:
1818         * WebCoreSupport/WebPlatformStrategies.mm:
1819         * WebCoreSupport/WebSelectionServiceController.mm:
1820         * WebCoreSupport/WebUserMediaClient.h:
1821
1822 2016-08-12  Anders Carlsson  <andersca@apple.com>
1823
1824         Move the plug-in and WebGL blacklist code to WebCore
1825         https://bugs.webkit.org/show_bug.cgi?id=160831
1826
1827         Reviewed by Sam Weinig.
1828
1829         Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.
1830
1831         * WebCoreSupport/WebFrameLoaderClient.mm:
1832         (shouldBlockPlugin):
1833         (WebFrameLoaderClient::createPlugin):
1834         (WebFrameLoaderClient::createJavaAppletWidget):
1835         (shouldBlockWebGL):
1836         (WebFrameLoaderClient::webGLPolicyForURL):
1837         (WebFrameLoaderClient::resolveWebGLPolicyForURL):
1838
1839 2016-08-14  Daniel Bates  <dabates@apple.com>
1840
1841         Fix compiler errors when building iOS WebKit using the iOS 10 beta SDK
1842         https://bugs.webkit.org/show_bug.cgi?id=160725
1843
1844         Reviewed by Sam Weinig.
1845
1846         OSAtomicCompareAndSwap32() has been deprecated as of the iOS 10 beta SDK. For now,
1847         silence the complier warning.
1848
1849         * WebView/WebView.mm:
1850         (-[WebView _dispatchTileDidDraw:]):
1851
1852 2016-08-12  Joseph Pecoraro  <pecoraro@apple.com>
1853
1854         Remove always true JSC::Debugger::needPauseHandling virtual method
1855         https://bugs.webkit.org/show_bug.cgi?id=160822
1856
1857         Reviewed by Mark Lam.
1858
1859         * WebView/WebScriptDebugger.h:
1860
1861 2016-08-11  Chris Dumez  <cdumez@apple.com>
1862
1863         Regression(r204268): Mail crashes when trying to compose an email
1864         https://bugs.webkit.org/show_bug.cgi?id=160775
1865
1866         Reviewed by Anders Carlsson.
1867
1868         Properly initialize PageConfiguration.pluginInfoProvider in
1869         [WebView initSimpleHTMLDocumentWithStyle] to avoid a null
1870         dereference in Mail when trying to compose an email.
1871
1872         * WebView/WebView.mm:
1873         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1874
1875 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1876
1877         Sort the feature flags in the FEATURE_DEFINES lines
1878         https://bugs.webkit.org/show_bug.cgi?id=160742
1879
1880         Reviewed by Anders Carlsson.
1881
1882         * Configurations/FeatureDefines.xcconfig:
1883
1884 2016-08-09  Alex Christensen  <achristensen@webkit.org>
1885
1886         Move NetworkStorageSession management to WebCore
1887         https://bugs.webkit.org/show_bug.cgi?id=160173
1888
1889         Reviewed by Brady Eidson.
1890
1891         * WebCoreSupport/WebFrameNetworkingContext.mm:
1892         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1893         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1894         * WebCoreSupport/WebPlatformStrategies.mm:
1895         * WebView/WebView.mm:
1896
1897 2016-08-09  Anders Carlsson  <andersca@apple.com>
1898
1899         Instantiate WebKit plug-ins at layout time, instead of at style resolution time
1900         https://bugs.webkit.org/show_bug.cgi?id=160715
1901
1902         Reviewed by Tim Horton.
1903
1904         * WebCoreSupport/WebFrameLoaderClient.mm:
1905         (WebFrameLoaderClient::objectContentType):
1906
1907 2016-08-09  George Ruan  <gruan@apple.com>
1908
1909         Implement functionality of media capture on iOS
1910         https://bugs.webkit.org/show_bug.cgi?id=158945
1911         <rdar://problem/26893343>
1912
1913         Reviewed by Tim Horton.
1914
1915         * Configurations/FeatureDefines.xcconfig: Enable Media Capture feature
1916         for iOS.
1917
1918 2016-08-09  Anders Carlsson  <andersca@apple.com>
1919
1920         Get rid of PluginStrategy
1921         https://bugs.webkit.org/show_bug.cgi?id=160696
1922
1923         Reviewed by Dan Bernstein.
1924
1925         * WebCoreSupport/WebPlatformStrategies.h:
1926         * WebCoreSupport/WebPlatformStrategies.mm:
1927         (WebPlatformStrategies::createPluginStrategy): Deleted.
1928         * WebCoreSupport/WebPluginInfoProvider.h:
1929         * WebCoreSupport/WebPluginInfoProvider.mm:
1930         (WebPluginInfoProvider::setPluginLoadClientPolicy): Deleted.
1931         (WebPluginInfoProvider::clearPluginClientPolicies): Deleted.
1932
1933 2016-08-09  Anders Carlsson  <andersca@apple.com>
1934
1935         Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
1936         https://bugs.webkit.org/show_bug.cgi?id=160694
1937
1938         Reviewed by Dan Bernstein.
1939
1940         * WebCoreSupport/WebPlatformStrategies.h:
1941         * WebCoreSupport/WebPlatformStrategies.mm:
1942         (WebPlatformStrategies::createPluginStrategy):
1943         (WebPlatformStrategies::refreshPlugins): Deleted.
1944         (WebPlatformStrategies::getPluginInfo): Deleted.
1945         (WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
1946         (WebPlatformStrategies::setPluginLoadClientPolicy): Deleted.
1947         (WebPlatformStrategies::clearPluginClientPolicies): Deleted.
1948         * WebCoreSupport/WebPluginInfoProvider.mm:
1949         (WebPluginInfoProvider::refreshPlugins):
1950         (WebPluginInfoProvider::getPluginInfo):
1951         (WebPluginInfoProvider::getWebVisiblePluginInfo):
1952
1953 2016-08-08  Anders Carlsson  <andersca@apple.com>
1954
1955         Add a new PluginInfoProvider class, to replace PluginStrategy
1956         https://bugs.webkit.org/show_bug.cgi?id=160670
1957
1958         Reviewed by Sam Weinig.
1959
1960         Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
1961
1962         * WebCoreSupport/WebPluginInfoProvider.h: Added.
1963         * WebCoreSupport/WebPluginInfoProvider.mm: Added.
1964         (WebPluginInfoProvider::singleton):
1965         (WebPluginInfoProvider::WebPluginInfoProvider):
1966         (WebPluginInfoProvider::~WebPluginInfoProvider):
1967         (WebPluginInfoProvider::refreshPlugins):
1968         (WebPluginInfoProvider::getPluginInfo):
1969         (WebPluginInfoProvider::getWebVisiblePluginInfo):
1970         (WebPluginInfoProvider::setPluginLoadClientPolicy):
1971         (WebPluginInfoProvider::clearPluginClientPolicies):
1972         * WebView/WebView.mm:
1973         (-[WebView _commonInitializationWithFrameName:groupName:]):
1974
1975 2016-08-02  Enrica Casucci  <enrica@apple.com>
1976
1977         Allow building with content filtering disabled.
1978         https://bugs.webkit.org/show_bug.cgi?id=160454
1979
1980         Reviewed by Simon Fraser.
1981
1982         * Configurations/FeatureDefines.xcconfig:
1983         * WebCoreSupport/WebFrameLoaderClient.h:
1984         * WebCoreSupport/WebFrameLoaderClient.mm:
1985         (WebFrameLoaderClient::blockedByContentFilterError):
1986
1987 2016-08-02  Anders Carlsson  <andersca@apple.com>
1988
1989         Remove more unused/uninstalled Objective-C DOM bindings
1990         https://bugs.webkit.org/show_bug.cgi?id=160464
1991
1992         Reviewed by Darin Adler.
1993
1994         Stop installing unused headers.
1995
1996         * MigrateHeaders.make:
1997
1998 2016-08-01  Anders Carlsson  <andersca@apple.com>
1999
2000         Bring back a file - it needs to be copied by WebCore.
2001
2002         * MigrateHeaders.make:
2003
2004 2016-08-01  Anders Carlsson  <andersca@apple.com>
2005
2006         Remove another file.
2007
2008         * MigrateHeaders.make:
2009
2010 2016-08-01  Anders Carlsson  <andersca@apple.com>
2011
2012         Remove a file.
2013
2014         * MigrateHeaders.make:
2015
2016 2016-08-01  Anders Carlsson  <andersca@apple.com>
2017
2018         Freeze all the DOMHTML* Objective-C bindings
2019         https://bugs.webkit.org/show_bug.cgi?id=160424
2020
2021         Reviewed by Tim Horton.
2022
2023         Don't migrate DOMHTMLEmbedElementPrivate.h - it was just an empty header.
2024
2025         * MigrateHeaders.make:
2026
2027 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
2028
2029         Remove deprecated SPI for video inline / fullscreen controls
2030         https://bugs.webkit.org/show_bug.cgi?id=160318
2031
2032         Reviewed by Tim Horton.
2033
2034         * WebView/WebPreferenceKeysPrivate.h:
2035         * WebView/WebPreferences.mm:
2036         (+[WebPreferences initialize]): Deleted.
2037         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]): Deleted.
2038         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]): Deleted.
2039         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]): Deleted.
2040         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]): Deleted.
2041         * WebView/WebPreferencesPrivate.h:
2042         * WebView/WebView.mm:
2043         (-[WebView _preferencesChanged:]): Deleted.
2044
2045 2016-07-28  Anders Carlsson  <andersca@apple.com>
2046
2047         Move a Mail.app workaround closer to where it's actually needed
2048         https://bugs.webkit.org/show_bug.cgi?id=160317
2049
2050         Reviewed by Tim Horton.
2051
2052         * WebCoreSupport/WebFrameLoaderClient.mm:
2053         (WebFrameLoaderClient::dispatchWillSendRequest):
2054         * WebView/WebFrame.mm:
2055         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Deleted.
2056
2057 2016-07-28  Anders Carlsson  <andersca@apple.com>
2058
2059         Use a RetainPtr in WebFrameLoaderClient::assignIdentifierToInitialRequest
2060         https://bugs.webkit.org/show_bug.cgi?id=160315
2061
2062         Reviewed by Tim Horton.
2063
2064         * WebCoreSupport/WebFrameLoaderClient.mm:
2065         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2066
2067 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2068
2069         Fix the Windows debug build.
2070         
2071         WebResourceLoadScheduler's logging was a holdover from it being in WebCore,
2072         and prior to r203749 WebKit was actually using a WebCore log channel.
2073         
2074         For some reason this doesn't build on Windows debug, so just remove
2075         this logging for now.
2076
2077         * Misc/WebKitLogging.h:
2078
2079 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2080
2081         [iPhone] Playing a video on tudou.com plays only sound, no video
2082         https://bugs.webkit.org/show_bug.cgi?id=160178
2083         <rdar://problem/27535468>
2084
2085         Reviewed by Eric Carlson and Dan Bernstein.
2086
2087         * WebView/WebPreferenceKeysPrivate.h:
2088         * WebView/WebPreferences.mm:
2089         (+[WebPreferences initialize]):
2090         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]):
2091         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]):
2092         * WebView/WebPreferencesPrivate.h:
2093         * WebView/WebView.mm:
2094         (-[WebView _preferencesChanged:]):
2095
2096 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2097
2098         Allow LOG macros to be used outside the namespace, and other logging cleanup
2099         https://bugs.webkit.org/show_bug.cgi?id=160216
2100
2101         Reviewed by Anders Carlsson.
2102
2103         Fix some issues with the LOG macros.
2104         
2105         First, they were not usable outside the WebKit namespace in WebKit2 code. Fix by moving
2106         its log channels outside of the namespace (they are protected by a unique prefix anyway).
2107         
2108         Second, allow LOG_WITH_STREAM to be used in WebKit2 by moving that and a helper macro
2109         into LogMacros.h, which is exported from WebCore as a private header.
2110         
2111         Third, split the Logging.h header into two. Logging.h remains for framework-internal
2112         log channels and log macros. Add LogInitialization.h which is external, and used to
2113         initialize the channels.
2114         
2115         Finally unify "initializeLogChannels" and "initializeLoggingChannels" terminology everywhere.
2116
2117         * Misc/WebKitLogging.h:
2118         * Misc/WebKitLogging.m:
2119         * WebView/WebView.mm:
2120         (-[WebView _commonInitializationWithFrameName:groupName:]):
2121
2122 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2123
2124         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2125         https://bugs.webkit.org/show_bug.cgi?id=160066
2126
2127         Reviewed by Dean Jackson.
2128
2129         * WebView/WebPreferenceKeysPrivate.h:
2130         * WebView/WebPreferences.mm:
2131         (+[WebPreferences initialize]): Deleted.
2132         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]): Deleted.
2133         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): Deleted.
2134         * WebView/WebPreferencesPrivate.h:
2135         * WebView/WebView.mm:
2136         (-[WebView _preferencesChanged:]): Deleted.
2137
2138 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2139
2140         [iPhone] Playing a video on tudou.com plays only sound, no video
2141         https://bugs.webkit.org/show_bug.cgi?id=159967
2142         <rdar://problem/26964090>
2143
2144         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2145
2146         Add the two preferences to WebPreferences.
2147
2148         * WebView/WebPreferenceKeysPrivate.h:
2149         * WebView/WebPreferences.mm:
2150         (+[WebPreferences initialize]):
2151         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
2152         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
2153         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
2154         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
2155         * WebView/WebPreferencesPrivate.h:
2156         * WebView/WebView.mm:
2157         (-[WebView _preferencesChanged:]):
2158
2159 2016-07-20  Commit Queue  <commit-queue@webkit.org>
2160
2161         Unreviewed, rolling out r203471.
2162         https://bugs.webkit.org/show_bug.cgi?id=160003
2163
2164         many iOS-simulator tests are failing (Requested by litherum on
2165         #webkit).
2166
2167         Reverted changeset:
2168
2169         "[iPhone] Playing a video on tudou.com plays only sound, no
2170         video"
2171         https://bugs.webkit.org/show_bug.cgi?id=159967
2172         http://trac.webkit.org/changeset/203471
2173
2174 2016-07-20  Myles C. Maxfield  <mmaxfield@apple.com>
2175
2176         [iPhone] Playing a video on tudou.com plays only sound, no video
2177         https://bugs.webkit.org/show_bug.cgi?id=159967
2178         <rdar://problem/26964090>
2179
2180         Reviewed by Jon Lee.
2181
2182         Add the two preferences to WebPreferences.
2183
2184         * WebView/WebPreferenceKeysPrivate.h:
2185         * WebView/WebPreferences.mm:
2186         (+[WebPreferences initialize]):
2187         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
2188         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
2189         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
2190         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
2191         * WebView/WebPreferencesPrivate.h:
2192         * WebView/WebView.mm:
2193         (-[WebView _preferencesChanged:]):
2194
2195 2016-07-19  Andy Estes  <aestes@apple.com>
2196
2197         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2198         https://bugs.webkit.org/show_bug.cgi?id=159956
2199
2200         Reviewed by Dan Bernstein.
2201
2202         * Misc/WebKitErrors.h: Moved definition of WebKitErrorFrameLoadBlockedByContentFilter from here ...
2203         * Misc/WebKitErrorsPrivate.h: to here.
2204
2205 2016-07-18  Anders Carlsson  <andersca@apple.com>
2206
2207         WebKit nightly fails to build on macOS Sierra
2208         https://bugs.webkit.org/show_bug.cgi?id=159902
2209         rdar://problem/27365672
2210
2211         Reviewed by Tim Horton.
2212
2213         * icu/unicode/ucurr.h: Added.
2214         Add ucurr.h from ICU.
2215
2216 2016-07-17  Sam Weinig  <sam@webkit.org>
2217
2218         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2219         <rdar://problem/26554137>
2220         https://bugs.webkit.org/show_bug.cgi?id=159856
2221
2222         Reviewed by Dan Bernstein.
2223
2224         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2225         (WebKit::NetscapePluginInstanceProxy::evaluate):
2226         * Plugins/WebNetscapePluginView.mm:
2227         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2228         Update for new UserGestureIndicator interface.
2229
2230 2016-07-16  Ryosuke Niwa  <rniwa@webkit.org>
2231
2232         Rename fastGetAttribute to attributeWithoutSynchronization
2233         https://bugs.webkit.org/show_bug.cgi?id=159852
2234
2235         Reviewed by Darin Adler.
2236
2237         * WebView/WebHTMLRepresentation.mm:
2238         (matchLabelsAgainstElement):
2239
2240 2016-07-15  Chris Dumez  <cdumez@apple.com>
2241
2242         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
2243         https://bugs.webkit.org/show_bug.cgi?id=159793
2244
2245         Reviewed by Ryosuke Niwa.
2246
2247         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.
2248
2249         * WebView/WebHTMLRepresentation.mm:
2250         (matchLabelsAgainstElement):
2251
2252 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2253
2254         Use SocketProvider to create SocketStreamHandles
2255         https://bugs.webkit.org/show_bug.cgi?id=159774
2256
2257         Reviewed by Brady Eidson.
2258
2259         * Misc/WebSocketProvider.h: Removed.
2260         * Misc/WebSocketProvider.mm: Removed.
2261         * WebView/WebView.mm:
2262         (-[WebView _commonInitializationWithFrameName:groupName:]):
2263         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2264
2265 2016-07-14  Csaba Osztrogonác  <ossy@webkit.org>
2266
2267         Fix the !ENABLE(WEB_SOCKETS) build after r202930
2268         https://bugs.webkit.org/show_bug.cgi?id=159768
2269
2270         Reviewed by Alex Christensen.
2271
2272         * Misc/WebSocketProvider.h:
2273
2274 2016-07-13  Beth Dakin  <bdakin@apple.com>
2275
2276         Add more candidate tests
2277         https://bugs.webkit.org/show_bug.cgi?id=159730
2278
2279         Reviewed by Tim Horton.
2280
2281         Move shouldRequestCandidates from WebViewInternal to WebViewPrivate so that 
2282         we can use it in tests. 
2283         * WebView/WebViewInternal.h:
2284         * WebView/WebViewPrivate.h:
2285
2286 2016-07-13  Enrica Casucci  <enrica@apple.com>
2287
2288         Update supported platforms in xcconfig files to match the sdk names.
2289         https://bugs.webkit.org/show_bug.cgi?id=159728
2290
2291         Reviewed by Tim Horton.
2292
2293         * Configurations/Base.xcconfig:
2294
2295 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2296
2297         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2298         https://bugs.webkit.org/show_bug.cgi?id=159671
2299
2300         Reviewed by Csaba Osztrogonác.
2301
2302         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2303         https://bugs.webkit.org/show_bug.cgi?id=89235
2304
2305         So this guard can be removed in build scripts.
2306
2307         * Configurations/FeatureDefines.xcconfig:
2308
2309 2016-07-11  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2310
2311         Purge PassRefPtr in platform/efl and platform/mac 
2312         https://bugs.webkit.org/show_bug.cgi?id=159548
2313
2314         Reviewed by Alex Christensen.
2315
2316         Remove all use of PassRefPtr and clean up unnecessary tabs and spaces.
2317
2318         * WebCoreSupport/WebPlatformStrategies.h:
2319         * WebCoreSupport/WebPlatformStrategies.mm:
2320         (WebPlatformStrategies::setBufferForType):
2321
2322 2016-07-11  Enrica Casucci  <enrica@apple.com>
2323
2324         Add synthetic click origin to WKNavigationAction.
2325         https://bugs.webkit.org/show_bug.cgi?id=159584
2326         rdar://problem/25610422
2327
2328         Reviewed by Tim Horton.
2329
2330         * WebView/WebFrame.mm:
2331         (-[WebFrame _dragSourceEndedAt:operation:]):
2332         * WebView/WebPDFView.mm:
2333         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2334
2335 2016-07-11  Anders Carlsson  <andersca@apple.com>
2336
2337         Able to open multiple payment sheets in Safari at the same time
2338         https://bugs.webkit.org/show_bug.cgi?id=159637
2339         rdar://problem/26411339
2340
2341         Reviewed by Beth Dakin.
2342
2343         Update for WebCore changes.
2344
2345         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2346         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2347         (WebPaymentCoordinatorClient::showPaymentUI):
2348
2349 2016-07-08  Andy Estes  <aestes@apple.com>
2350
2351         [Content Filtering] Load blocked pages more like other error pages are loaded
2352         https://bugs.webkit.org/show_bug.cgi?id=159485
2353         <rdar://problem/26014076>
2354
2355         Reviewed by Brady Eidson.
2356
2357         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
2358         * Misc/WebKitErrors.m:
2359         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
2360         * WebCoreSupport/WebFrameLoaderClient.h:
2361         * WebCoreSupport/WebFrameLoaderClient.mm:
2362         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
2363
2364 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2365
2366         Unreviewed, rolling out r202944.
2367         https://bugs.webkit.org/show_bug.cgi?id=159570
2368
2369         caused some tests to crash under GuardMalloc (Requested by
2370         estes on #webkit).
2371
2372         Reverted changeset:
2373
2374         "[Content Filtering] Load blocked pages more like other error
2375         pages are loaded"
2376         https://bugs.webkit.org/show_bug.cgi?id=159485
2377         http://trac.webkit.org/changeset/202944
2378
2379 2016-07-08  Jiewen Tan  <jiewen_tan@apple.com>
2380
2381         Define DYLD_MACOSX_VERSION_10_12
2382         https://bugs.webkit.org/show_bug.cgi?id=159525
2383         <rdar://problem/26250296>
2384
2385         Reviewed by Brent Fulgham.
2386
2387         * WebView/WebView.mm:
2388         (shouldConvertInvalidURLsToBlank):
2389         Replace 0x000A0C00 with DYLD_MACOSX_VERSION_10_12.
2390
2391 2016-07-07  Beth Dakin  <bdakin@apple.com>
2392
2393         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
2394         https://bugs.webkit.org/show_bug.cgi?id=159532
2395         -and corresponding-
2396         rdar://problem/27177179
2397
2398         Reviewed by Tim Horton.
2399
2400         * WebView/WebView.mm:
2401         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
2402         (-[WebView forceRequestCandidatesForTesting]):
2403         (-[WebView shouldRequestCandidates]):
2404         * WebView/WebViewPrivate.h:
2405
2406 2016-07-07  Andy Estes  <aestes@apple.com>
2407
2408         [Content Filtering] Load blocked pages more like other error pages are loaded
2409         https://bugs.webkit.org/show_bug.cgi?id=159485
2410         <rdar://problem/26014076>
2411
2412         Reviewed by Brady Eidson.
2413
2414         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
2415         * Misc/WebKitErrors.m:
2416         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
2417         * WebCoreSupport/WebFrameLoaderClient.h:
2418         * WebCoreSupport/WebFrameLoaderClient.mm:
2419         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
2420
2421 2016-07-07  Alex Christensen  <achristensen@webkit.org>
2422
2423         Use SocketProvider to create WebSocketChannels
2424         https://bugs.webkit.org/show_bug.cgi?id=158776
2425
2426         Reviewed by Brent Fulgham.
2427
2428         * Misc/WebSocketProvider.mm: Copied from Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp.
2429         (WebSocketProvider::createWebSocketChannel):
2430         (WebCore::ThreadableWebSocketChannel::create): Deleted.
2431         * Misc/WebSocketProvider.h:
2432         * WebView/WebView.mm:
2433         (-[WebView _commonInitializationWithFrameName:groupName:]):
2434         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2435
2436 2016-07-06  Benjamin Poulain  <bpoulain@apple.com>
2437
2438         [JSC] Unify how we throw TypeError from C++
2439         https://bugs.webkit.org/show_bug.cgi?id=159500
2440
2441         Reviewed by Saam Barati.
2442
2443         * Plugins/Hosted/ProxyInstance.mm:
2444         (WebKit::ProxyInstance::invokeMethod):
2445
2446 2016-07-01  Youenn Fablet  <youennf@gmail.com>
2447
2448         Add a runtime flag for DOM iterators
2449         https://bugs.webkit.org/show_bug.cgi?id=159300
2450
2451         Reviewed by Alex Christensen.
2452
2453         * WebView/WebPreferenceKeysPrivate.h:
2454         * WebView/WebPreferences.mm:
2455         (-[WebPreferences DOMIteratorEnabled]):
2456         (-[WebPreferences setDOMIteratorEnabled:]):
2457         * WebView/WebPreferencesPrivate.h:
2458         * WebView/WebView.mm:
2459         (-[WebView _preferencesChanged:]):
2460
2461 2016-06-30  Jiewen Tan  <jiewen_tan@apple.com>
2462
2463         Create a generic "linked-on-or-after" check for new CSP Rules
2464         https://bugs.webkit.org/show_bug.cgi?id=159322
2465         <rdar://problem/27117220>
2466
2467         Reviewed by Brent Fulgham.
2468
2469         * WebView/WebView.mm:
2470         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2471
2472 2016-06-30  Anders Carlsson  <andersca@apple.com>
2473
2474         Mail crashes on launch at WebCore::PaymentCoordinator::~PaymentCoordinator() + 20
2475         https://bugs.webkit.org/show_bug.cgi?id=159306
2476         rdar://problem/27092107
2477
2478         Reviewed by Tim Horton.
2479
2480         * WebView/WebView.mm:
2481         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2482         Create a WebPaymentCoordinatorClient. Remove an unneeded #import.
2483
2484         (-[WebView _commonInitializationWithFrameName:groupName:]):
2485         Remove an unneeded #import.
2486
2487 2016-06-27  Anders Carlsson  <andersca@apple.com>
2488
2489         WebKit::WebPaymentCoordinator leak
2490         https://bugs.webkit.org/show_bug.cgi?id=159168
2491         rdar://problem/26929772
2492
2493         Reviewed by Beth Dakin.
2494
2495         Update for WebCore changes.
2496
2497         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2498         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2499         (WebPaymentCoordinatorClient::paymentCoordinatorDestroyed):
2500         (WebPaymentCoordinatorClient::mainFrameDestroyed): Deleted.
2501
2502 2016-06-27  Tim Horton  <timothy_horton@apple.com>
2503
2504         REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app
2505         https://bugs.webkit.org/show_bug.cgi?id=159184
2506         <rdar://problem/26370206>
2507
2508         Reviewed by Beth Dakin.
2509
2510         * WebView/WebHTMLView.mm:
2511         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2512         * WebView/WebImmediateActionController.h:
2513         * WebView/WebImmediateActionController.mm:
2514         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2515         (-[WebImmediateActionController _animationControllerForText]):
2516         (dictionaryPopupInfoForRange): Deleted.
2517         WebImmediateActionController's code to make a DictionaryPopupInfo and TextIndicator
2518         from a Range in WebKit1 is much better than WebHTMLView's; use it in both cases.
2519
2520 2016-06-24  Jer Noble  <jer.noble@apple.com>
2521
2522         Playback controls refer to wrong element when playing multiple items in a page.
2523         https://bugs.webkit.org/show_bug.cgi?id=159076
2524         <rdar://problem/26953532>
2525
2526         Reviewed by Beth Dakin.
2527
2528         clearPlaybackControlsManager() no longer takes a parameter.
2529
2530         * WebCoreSupport/WebChromeClient.h:
2531         * WebCoreSupport/WebChromeClient.mm:
2532         (WebChromeClient::clearPlaybackControlsManager):
2533         * WebView/WebView.mm:
2534         (-[WebView _clearPlaybackControlsManager]): Renamed from _clearPlaybackControlsManagerForMediaElement:.
2535         * WebView/WebViewInternal.h:
2536
2537 2016-06-23  Alex Christensen  <achristensen@webkit.org>
2538
2539         Remove unused didCancelAuthenticationChallenge
2540         https://bugs.webkit.org/show_bug.cgi?id=158819
2541
2542         Reviewed by David Kilzer.
2543
2544         * Misc/WebDownload.mm:
2545         (-[WebDownloadInternal download:didCancelAuthenticationChallenge:]): Deleted.
2546         * WebCoreSupport/WebFrameLoaderClient.h:
2547         * WebCoreSupport/WebFrameLoaderClient.mm:
2548         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.
2549         * WebView/WebDelegateImplementationCaching.h:
2550         * WebView/WebView.mm:
2551         (-[WebView _cacheResourceLoadDelegateImplementations]):
2552
2553 2016-06-23  John Wilander  <wilander@apple.com>
2554
2555         Enable window.open() for existing versions of Secret Society app
2556         https://bugs.webkit.org/show_bug.cgi?id=159049
2557         <rdar://problem/26528349>
2558
2559         Reviewed by Andy Estes.
2560
2561         The Secret Society Hidden Mystery app has a broken version check treating iOS 10
2562         as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
2563         handler. We should allow the existing versions of the app to do this to not break
2564         them.
2565
2566         * WebView/WebView.mm:
2567         (shouldAllowWindowOpenWithoutUserGesture):
2568             Added.
2569         (shouldConvertInvalidURLsToBlank):
2570             Changed hex number to constant DYLD_IOS_VERSION_10_0.
2571
2572 2016-06-22  Anders Carlsson  <andersca@apple.com>
2573
2574         Move the WebKitLegacy Apple Pay code to the open source repository
2575         https://bugs.webkit.org/show_bug.cgi?id=159035
2576
2577         Reviewed by Tim Horton.
2578
2579         * WebCoreSupport/WebPaymentCoordinatorClient.h: Added.
2580         * WebCoreSupport/WebPaymentCoordinatorClient.mm: Added.
2581         (WebPaymentCoordinatorClient::WebPaymentCoordinatorClient):
2582         (WebPaymentCoordinatorClient::~WebPaymentCoordinatorClient):
2583         (WebPaymentCoordinatorClient::supportsVersion):
2584         (WebPaymentCoordinatorClient::canMakePayments):
2585         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
2586         (WebPaymentCoordinatorClient::showPaymentUI):
2587         (WebPaymentCoordinatorClient::completeMerchantValidation):
2588         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
2589         (WebPaymentCoordinatorClient::completeShippingContactSelection):
2590         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
2591         (WebPaymentCoordinatorClient::completePaymentSession):
2592         (WebPaymentCoordinatorClient::abortPaymentSession):
2593         (WebPaymentCoordinatorClient::mainFrameDestroyed):
2594         * WebKitAdditions.mm: Removed.
2595         * WebView/WebView.mm:
2596         (-[WebView _commonInitializationWithFrameName:groupName:]):
2597
2598 2016-06-21  Anders Carlsson  <andersca@apple.com>
2599
2600         Fix build.
2601
2602         * Configurations/FeatureDefines.xcconfig:
2603
2604 2016-06-21  Anders Carlsson  <andersca@apple.com>
2605
2606         Begin moving the Apple Pay code to the open source repository
2607         https://bugs.webkit.org/show_bug.cgi?id=158998
2608
2609         Reviewed by Tim Horton.
2610
2611         * Configurations/FeatureDefines.xcconfig:
2612         Add ENABLE_APPLE_PAY.
2613
2614 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
2615
2616         Focus event dispatched in iframe causes parent document to scroll incorrectly
2617         https://bugs.webkit.org/show_bug.cgi?id=158629
2618         rdar://problem/26521616
2619
2620         Reviewed by Tim Horton.
2621         
2622         Pass SelectionRevealMode::Reveal in existing code.
2623
2624         * WebView/WebFrame.mm:
2625         (-[WebFrame _scrollDOMRangeToVisible:]):
2626         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2627         (-[WebFrame revealSelectionAtExtent:]):
2628         * WebView/WebHTMLView.mm:
2629         (-[WebHTMLView jumpToSelection:]):
2630         (-[WebHTMLView centerSelectionInVisibleArea:]):
2631
2632 2016-06-21  Amir Alavi  <aalavi@apple.com>
2633
2634         Upstream WKHTTPCookiesForURL from WebKitSystemInterface to OpenSource
2635         https://bugs.webkit.org/show_bug.cgi?id=158967
2636
2637         Reviewed by Brent Fulgham.
2638
2639         * WebCoreSupport/WebSystemInterface.mm:
2640         (InitWebCoreSystemInterface): Deleted.
2641
2642 2016-06-20  Commit Queue  <commit-queue@webkit.org>
2643
2644         Unreviewed, rolling out r202243.
2645         https://bugs.webkit.org/show_bug.cgi?id=158972
2646
2647         Broke Windows build and iOS tests (Requested by ap on
2648         #webkit).
2649
2650         Reverted changeset:
2651
2652         "Focus event dispatched in iframe causes parent document to
2653         scroll incorrectly"
2654         https://bugs.webkit.org/show_bug.cgi?id=158629
2655         http://trac.webkit.org/changeset/202243
2656
2657 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
2658
2659         Focus event dispatched in iframe causes parent document to scroll incorrectly
2660         https://bugs.webkit.org/show_bug.cgi?id=158629
2661         rdar://problem/26521616
2662
2663         Reviewed by Tim Horton.
2664         
2665         Pass SelectionRevealMode::Reveal in existing code.
2666
2667         * WebView/WebFrame.mm:
2668         (-[WebFrame _scrollDOMRangeToVisible:]):
2669         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2670         (-[WebFrame revealSelectionAtExtent:]):
2671         * WebView/WebHTMLView.mm:
2672         (-[WebHTMLView jumpToSelection:]):
2673         (-[WebHTMLView centerSelectionInVisibleArea:]):
2674
2675 2016-06-20  Keith Rollin  <krollin@apple.com>
2676
2677         Remove RefPtr::release() and change calls sites to use WTFMove()
2678         https://bugs.webkit.org/show_bug.cgi?id=158369
2679
2680         Reviewed by Chris Dumez.
2681
2682         RefPtr::release() releases its managed pointer awkwardly. It's more
2683         direct and clearer to use WTFMove to transfer ownership of the managed
2684         pointer.
2685
2686         As part of this cleanup, also change a lot of explicit data types to
2687         'auto'.
2688
2689         * Plugins/Hosted/NetscapePluginHostManager.mm:
2690         (WebKit::NetscapePluginHostManager::instantiatePlugin):
2691         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2692         (WebKit::NetscapePluginInstanceProxy::create):
2693         (WebKit::NetscapePluginInstanceProxy::loadRequest):
2694         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
2695         * WebCoreSupport/WebFrameLoaderClient.mm:
2696         (-[WebFramePolicyListener receivedPolicyDecision:]):
2697         * WebCoreSupport/WebSecurityOrigin.mm:
2698         (-[WebSecurityOrigin initWithURL:]):
2699         * WebView/WebArchive.mm:
2700         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
2701         (-[WebArchive initWithData:]):
2702         * WebView/WebDataSource.mm:
2703         (-[WebDataSource mainResource]):
2704         * WebView/WebFrame.mm:
2705         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
2706
2707 2016-06-15  Alexey Proskuryakov  <ap@apple.com>
2708
2709         +[WebHTMLRepresentation supportedMIMETypes] leaks
2710         https://bugs.webkit.org/show_bug.cgi?id=158683
2711
2712         Reviewed by Darin Adler.
2713
2714         The problem occurred when chaining newArrayByConcatenatingArrays calls.
2715
2716         Also refactored the code to avoid returning NSMutableArrays disguised as NSArrays,
2717         and removed __unsafe_unretained modifiers that were added in http://trac.webkit.org/r149453
2718         for no apparent reason.
2719
2720         * WebView/WebHTMLRepresentation.mm:
2721         (newArrayWithStrings):
2722         (+[WebHTMLRepresentation supportedMIMETypes]):
2723         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2724         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2725         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2726         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2727         (newArrayByConcatenatingArrays): Deleted.
2728
2729 2016-06-15  Dean Jackson  <dino@apple.com>
2730
2731         RTL <select> forms are misplaced
2732         https://bugs.webkit.org/show_bug.cgi?id=158810
2733         <rdar://problem/24847541>
2734
2735         Reviewed by Eric Carlson.
2736
2737         AppKit made a change in Sierra that causes popup menus
2738         to snap to a different point when the system language is RTL.
2739         We need to be more explicit about what directionality
2740         we want, and override the location of the popup based
2741         on the text direction.
2742
2743         I also made a small tweak to the fudge offsets we use
2744         in order to make button text and menu text to be
2745         more consistent.
2746
2747         Unfortunately since this is just about the location
2748         of the popup menu, it's unable to be tested in our
2749         current infrastructure.
2750
2751         * WebCoreSupport/PopupMenuMac.mm:
2752         (PopupMenuMac::show):
2753
2754 2016-06-15  Chris Dumez  <cdumez@apple.com>
2755
2756         Drop some unnecessary header includes
2757         https://bugs.webkit.org/show_bug.cgi?id=158788
2758
2759         Reviewed by Alexey Proskuryakov.
2760
2761         Drop some unnecessary header includes in headers to speed up build time.
2762
2763         * WebCoreSupport/WebFrameLoaderClient.mm:
2764
2765 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2766
2767         Enabling Shadow DOM for all platforms
2768         https://bugs.webkit.org/show_bug.cgi?id=158738
2769
2770         Reviewed by Ryosuke Niwa.
2771
2772         Removed Shadow DOM from options (enabled by default)
2773
2774         * Configurations/FeatureDefines.xcconfig:
2775         * WebView/WebPreferences.mm:
2776         * WebView/WebView.mm:
2777
2778 2016-06-15  Antti Koivisto  <antti@apple.com>
2779
2780         Vary:Cookie validation doesn't work in private browsing
2781         https://bugs.webkit.org/show_bug.cgi?id=158616
2782         <rdar://problem/26755067>
2783
2784         Reviewed by Andreas Kling.
2785
2786         * WebCoreSupport/WebFrameNetworkingContext.h:
2787         (WebFrameNetworkingContext::create):
2788         * WebCoreSupport/WebFrameNetworkingContext.mm:
2789         (privateSession):
2790         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2791
2792             Expose the private browsing session.
2793
2794         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2795         * WebCoreSupport/WebPlatformStrategies.h:
2796         * WebCoreSupport/WebPlatformStrategies.mm:
2797         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2798
2799             Implement SessionID version of the function.
2800
2801         (WebPlatformStrategies::getRawCookies):
2802
2803 2016-06-13  Alex Christensen  <achristensen@webkit.org>
2804
2805         Add WebSocketProvider stub
2806         https://bugs.webkit.org/show_bug.cgi?id=158702
2807
2808         Reviewed by Brady Eidson.
2809
2810         * Misc/WebSocketProvider.h: Added.
2811         * WebView/WebView.mm:
2812         (-[WebView _commonInitializationWithFrameName:groupName:]):
2813         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2814
2815 2016-06-10  Alex Christensen  <achristensen@webkit.org>
2816
2817         Introduce WTF::UniqueRef
2818         https://bugs.webkit.org/show_bug.cgi?id=158596
2819
2820         Reviewed by Brady Eidson.
2821
2822         * WebView/WebView.mm:
2823         (-[WebView _commonInitializationWithFrameName:groupName:]):
2824         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2825
2826 2016-06-09  Alex Christensen  <achristensen@webkit.org>
2827
2828         Clean up EditorClient lifetime
2829         https://bugs.webkit.org/show_bug.cgi?id=158588
2830
2831         Reviewed by Anders Carlsson.
2832
2833         * WebCoreSupport/WebEditorClient.h:
2834         * WebCoreSupport/WebEditorClient.mm:
2835         (WebEditorClient::WebEditorClient):
2836         (WebEditorClient::pageDestroyed): Deleted.
2837         * WebView/WebView.mm:
2838         (-[WebView _commonInitializationWithFrameName:groupName:]):
2839         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2840
2841 2016-06-09  Andy Estes  <aestes@apple.com>
2842
2843         Define printing{Minimum,Maximum}ShrinkFactor in only one place
2844         https://bugs.webkit.org/show_bug.cgi?id=158580
2845
2846         Reviewed by Tim Horton.
2847
2848         * WebView/WebHTMLView.mm: Initialized _WebHTMLViewPrintingMinimumShrinkFactor and
2849         _WebHTMLViewPrintingMaximumShrinkFactor with PrintContext::minimumShrinkFactor() and
2850         PrintContext::maximumShrinkFactor() instead of with duplicated float literals.
2851
2852 2016-06-09  Commit Queue  <commit-queue@webkit.org>
2853
2854         Unreviewed, rolling out r201810.
2855         https://bugs.webkit.org/show_bug.cgi?id=158563
2856
2857         breaks build without ENABLE_WEB_ANIMATION (Requested by
2858         mcatanzaro on #webkit).
2859
2860         Reverted changeset:
2861
2862         "[web-animations] Add Animatable, AnimationEffect,
2863         KeyframeEffect and Animation interface"
2864         https://bugs.webkit.org/show_bug.cgi?id=156096
2865         http://trac.webkit.org/changeset/201810
2866
2867 2016-06-08  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
2868
2869         [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
2870         https://bugs.webkit.org/show_bug.cgi?id=156096
2871
2872         Reviewed by Dean Jackson.
2873
2874         Adds:
2875         - Setup interface for enabling runtime flag for Web animations through preferences.
2876
2877         * WebView/WebPreferenceKeysPrivate.h:
2878         * WebView/WebPreferences.mm:
2879         (+[WebPreferences initialize]):
2880         (-[WebPreferences webAnimationsEnabled]):
2881         (-[WebPreferences setWebAnimationsEnabled:]):
2882         * WebView/WebPreferencesPrivate.h:
2883         * WebView/WebView.mm:
2884         (-[WebView _preferencesChanged:]):
2885
2886 2016-06-07  David Kilzer  <ddkilzer@apple.com>
2887
2888         [iOS WK1] Remove unused -_webkit_unescapedQueryValue and -_webkit_queryKeysAndValues NSString category methods
2889         <https://webkit.org/b/158485>
2890         <rdar://problem/16960445>
2891
2892         Reviewed by Dan Bernstein.
2893
2894         * Misc/WebNSURLExtras.h:
2895         (-[NSString _webkit_unescapedQueryValue]): Deleted declaration.
2896         (-[NSString _webkit_queryKeysAndValues]): Deleted declaration.
2897         * Misc/WebNSURLExtras.mm:
2898         (-[NSString _webkit_unescapedQueryValue]): Deleted.
2899         (-[NSString _webkit_queryKeysAndValues]): Deleted.
2900
2901 2016-06-07  Alex Christensen  <achristensen@webkit.org>
2902
2903         Adopt [PDFView documentScrollView]
2904         https://bugs.webkit.org/show_bug.cgi?id=158454
2905         rdar://problem/25875390
2906
2907         Reviewed by Tim Horton.
2908
2909         * WebView/PDFViewSPI.h: Added.
2910         * WebView/WebPDFView.mm:
2911         (-[WebPDFView _clipViewForPDFDocumentView]):
2912
2913 2016-06-05  Anders Carlsson  <andersca@apple.com>
2914
2915         Attempt to fix plug-in hangs by adding back empty slots for the removed messages.
2916
2917         * Plugins/Hosted/WebKitPluginClient.defs:
2918         * Plugins/Hosted/WebKitPluginHost.defs:
2919
2920 2016-06-04  Anders Carlsson  <andersca@apple.com>
2921
2922         Remove NPSPI that is no longer used
2923         https://bugs.webkit.org/show_bug.cgi?id=158384
2924
2925         Reviewed by Sam Weinig.
2926
2927         * Configurations/WebKitLegacy.xcconfig:
2928         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2929         (WKPCCheckIfAllowedToLoadURL): Deleted.
2930         (WKPCCancelCheckIfAllowedToLoadURL): Deleted.
2931         (WKPCResolveURL): Deleted.
2932         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2933         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2934         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Deleted.
2935         (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURL): Deleted.
2936         (WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL): Deleted.
2937         (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult): Deleted.
2938         (WebKit::NetscapePluginInstanceProxy::resolveURL): Deleted.
2939         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2940         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2941         (-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Deleted.
2942         (-[WebHostedNetscapePluginView _containerCheckResult:contextInfo:]): Deleted.
2943         * Plugins/Hosted/WebKitPluginClient.defs:
2944         * Plugins/WebBaseNetscapePluginView.h:
2945         * Plugins/WebBaseNetscapePluginView.mm:
2946         (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]): Deleted.
2947         * Plugins/WebNetscapeContainerCheckContextInfo.h: Removed.
2948         * Plugins/WebNetscapeContainerCheckContextInfo.mm: Removed.
2949         (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]): Deleted.
2950         (-[WebNetscapeContainerCheckContextInfo checkRequestID]): Deleted.
2951         (-[WebNetscapeContainerCheckContextInfo callback]): Deleted.
2952         (-[WebNetscapeContainerCheckContextInfo context]): Deleted.
2953         * Plugins/WebNetscapeContainerCheckPrivate.h: Removed.
2954         * Plugins/WebNetscapeContainerCheckPrivate.mm: Removed.
2955         (browserContainerCheckFuncs): Deleted.
2956         * Plugins/WebNetscapePluginView.h:
2957         * Plugins/WebNetscapePluginView.mm:
2958         (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]): Deleted.
2959         (-[WebNetscapePluginView _containerCheckResult:contextInfo:]): Deleted.
2960         (-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Deleted.
2961         (-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Deleted.
2962         (-[WebNetscapePluginView fini]): Deleted.
2963         (-[WebNetscapePluginView getVariable:value:]): Deleted.
2964         (-[WebNetscapePluginView resolveURL:forTarget:]): Deleted.
2965         * Plugins/npapi.mm:
2966         (WKN_CheckIfAllowedToLoadURL): Deleted.
2967         (WKN_CancelCheckIfAllowedToLoadURL): Deleted.
2968         (WKN_ResolveURL): Deleted.
2969
2970 2016-06-04  Anders Carlsson  <andersca@apple.com>
2971
2972         Temporary build fix. (This function is going away).
2973
2974         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2975         (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult): Deleted.
2976         * Plugins/Hosted/WebKitPluginHost.defs:
2977
2978 2016-06-03  Chris Dumez  <cdumez@apple.com>
2979
2980         Unreviewed, roll out r196633 as it broke PageCache on iOS for WebKit.org
2981         <rdar://problem/26521101>
2982
2983         * WebCoreSupport/WebVisitedLinkStore.mm:
2984         (WebVisitedLinkStore::removeAllVisitedLinks):
2985         (WebVisitedLinkStore::removeVisitedLink):
2986         (WebVisitedLinkStore::addVisitedLinkHash):
2987
2988 2016-06-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2989
2990         Add WebIDL special operation support: serializer
2991         https://bugs.webkit.org/show_bug.cgi?id=156293
2992
2993         Reviewed by Darin Adler.
2994
2995         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2996         (WebKit::HostedNetscapePluginStream::start):
2997         * Plugins/WebNetscapePluginStream.mm:
2998         (WebNetscapePluginStream::start):
2999
3000 2016-05-31  Darin Adler  <darin@apple.com>
3001
3002         Audit RenderObject casts and fix problems and style issues found
3003         https://bugs.webkit.org/show_bug.cgi?id=158221
3004
3005         Reviewed by Chris Dumez.
3006
3007         * Misc/WebNSPasteboardExtras.mm:
3008         (imageFromElement): Use auto and tighten the logic a bit.
3009         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3010         Use auto and added a comment about this not using imageFromElement.
3011
3012         * Plugins/WebBaseNetscapePluginView.mm:
3013         (-[WebBaseNetscapePluginView _windowClipRect]): Consistently cast to
3014         RenderEmbeddedObject, which is the class used for renderers for plug-ins.
3015         (-[WebBaseNetscapePluginView inFlatteningPaint]): Ditto.
3016         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]): Ditto.
3017         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]): Ditto.
3018
3019         * WebCoreSupport/WebFrameLoaderClient.mm:
3020         (WebFrameLoaderClient::createPlugin): Changed code so it does a null check
3021         rather than assuming the renderer is non-null.
3022         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
3023
3024 2016-05-31  Yusuke Suzuki  <utatane.tea@gmail.com>
3025
3026         Unreviewed, roll out r201481, r201523: 0.3% regression in Octane code-load
3027         https://bugs.webkit.org/show_bug.cgi?id=158249
3028
3029         * WebView/WebPreferencesPrivate.h:
3030
3031 2016-05-27  Chris Dumez  <cdumez@apple.com>
3032
3033         callOnMainThread() should not copy captured lambda variables
3034         https://bugs.webkit.org/show_bug.cgi?id=158166
3035
3036         Reviewed by Brady Eidson.
3037
3038         callOnMainThread() should not copy captured lambda variables. This 
3039         function is usually called cross-thread with a lambda and copying
3040         the lambda (and its captured variables) can lead to thread-safety
3041         issues.
3042
3043         This patch updates callOnMainThread() to take a NoncopyableFunction&&
3044         in parameter instead of a std::function. The call sites of
3045         callOnMainThread() have also been updated to use C++14's lambda
3046         capture with initializer.
3047
3048         * Storage/WebDatabaseManagerClient.mm:
3049         (DidModifyOriginData::dispatchToMainThread):
3050         (DidModifyOriginData::DidModifyOriginData): Deleted.
3051         * Storage/WebStorageTrackerClient.mm:
3052         (WebStorageTrackerClient::dispatchDidModifyOrigin):
3053
3054 2016-05-27  Caitlin Potter  <caitp@igalia.com>
3055
3056         [JSC] implement async functions proposal
3057         https://bugs.webkit.org/show_bug.cgi?id=156147
3058
3059         Reviewed by Yusuke Suzuki.
3060
3061         * WebView/WebPreferencesPrivate.h:
3062
3063 2016-05-26  Darin Adler  <darin@apple.com>
3064
3065         Media queries and platform screen modernization and streamlining
3066         https://bugs.webkit.org/show_bug.cgi?id=158067
3067
3068         Reviewed by Alex Christensen.
3069
3070         * WebView/WebFrame.mm:
3071         (-[WebFrame _dragSourceEndedAt:operation:]): Updated to use the new version of
3072         globalPoint, which returns an NSPoint.
3073
3074 2016-05-26  Myles C. Maxfield  <mmaxfield@apple.com>
3075
3076         Build fix
3077
3078         Rubber stamped by Lucas Forschler.
3079
3080         * Configurations/DebugRelease.xcconfig:
3081
3082 2016-05-24  Beth Dakin  <bdakin@apple.com>
3083
3084         Candidates should work with input methods
3085         https://bugs.webkit.org/show_bug.cgi?id=158042
3086         -and corresponding-
3087         rdar://problem/26205228
3088
3089         Reviewed by Tim Horton.
3090
3091         * WebView/WebHTMLView.mm:
3092         * WebView/WebView.mm:
3093         (-[WebView candidateList]):
3094         * WebView/WebViewInternal.h:
3095
3096 2016-05-22  Brady Eidson  <beidson@apple.com>
3097
3098         Move to C++14.
3099         https://bugs.webkit.org/show_bug.cgi?id=157948
3100
3101         Reviewed by Michael Catanzaro.
3102
3103         * Configurations/Base.xcconfig:
3104
3105 2016-05-20  Enrica Casucci  <enrica@apple.com>
3106
3107         Drag cannot start if no drag data or custom data is available in the Pasteboard.
3108         https://bugs.webkit.org/show_bug.cgi?id=157911
3109         rdar://problem/24577706
3110
3111         Reviewed by Tim Horton.
3112
3113         We need to make sure there is always one item in common between source and target
3114         of the drag and drop operation.
3115
3116         * WebView/WebHTMLView.mm:
3117         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3118
3119 2016-05-19  Enrica Casucci  <enrica@apple.com>
3120
3121         Drag cannot start if no drag data is available in the Pasteboard.
3122         https://bugs.webkit.org/show_bug.cgi?id=157911
3123         rdar://problem/24577706
3124
3125         Reviewed by Tim Horton.
3126
3127         * WebView/WebHTMLView.mm:
3128         (+[WebHTMLView _dummyPasteboardType]):
3129         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3130         * WebView/WebHTMLViewPrivate.h:
3131         * WebView/WebView.mm:
3132         (-[WebView _registerDraggedTypes]):
3133
3134 2016-05-19  Jer Noble  <jer.noble@apple.com>
3135
3136         [IOS] Add setting to allow playback to continue inline after exiting fullscreen.
3137         https://bugs.webkit.org/show_bug.cgi?id=157912
3138
3139         Reviewed by Eric Carlson.
3140
3141         Add a preference to control whether media should be allowed to continue playing inline when
3142         exiting fullscreen.
3143
3144         * WebView/WebPreferenceKeysPrivate.h:
3145         * WebView/WebPreferences.mm:
3146         (+[WebPreferences initialize]):
3147         (-[WebPreferences allowsInlineMediaPlaybackAfterFullscreen]):
3148         (-[WebPreferences setAllowsInlineMediaPlaybackAfterFullscreen:]):
3149         * WebView/WebPreferencesPrivate.h:
3150         * WebView/WebView.mm:
3151         (-[WebView _preferencesChanged:]):
3152
3153 2016-05-18  Brady Eidson  <beidson@apple.com>
3154
3155         Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
3156         https://bugs.webkit.org/show_bug.cgi?id=157823
3157
3158         Reviewed by Alex Christensen.
3159
3160         * Storage/WebDatabaseManager.mm:
3161         (-[WebDatabaseManager deleteAllIndexedDatabases]):
3162         * Storage/WebDatabaseManagerPrivate.h:
3163
3164 2016-05-17  Beth Dakin  <bdakin@apple.com>
3165
3166         Make handleAcceptedCandidate a public function
3167         https://bugs.webkit.org/show_bug.cgi?id=157763
3168         -and corresponding-
3169         rdar://problem/26206397
3170
3171         Reviewed by Tim Horton.
3172
3173         This patch re-names handleAcceptedCandidate to 
3174         handleAcceptedCandidateWithSoftSpaces. The function now takes a 
3175         WebCore::TextCheckingResult instead of an NSTextCheckingResult and it can be 
3176         called from outside of WebEditorClient.
3177
3178         * WebCoreSupport/WebEditorClient.h:
3179         * WebCoreSupport/WebEditorClient.mm:
3180         (WebEditorClient::handleRequestedCandidates):
3181         (WebEditorClient::handleAcceptedCandidateWithSoftSpaces):
3182         (textCheckingResultFromNSTextCheckingResult): Deleted.
3183         (WebEditorClient::handleAcceptedCandidate): Deleted.
3184
3185         Move showCandidates to WebViewPrivate so that it can be overridden by a test.
3186         * WebView/WebViewInternal.h:
3187         * WebView/WebViewPrivate.h:
3188
3189 2016-05-17  Dean Jackson  <dino@apple.com>
3190
3191         Remove ES6_GENERATORS flag
3192         https://bugs.webkit.org/show_bug.cgi?id=157815
3193         <rdar://problem/26332894>
3194
3195         Reviewed by Geoffrey Garen.
3196
3197         This flag isn't needed. Generators are enabled everywhere and
3198         part of a stable specification.
3199
3200         * Configurations/FeatureDefines.xcconfig:
3201
3202 2016-05-17  Filip Pizlo  <fpizlo@apple.com>
3203
3204         WTF should know about Language
3205         https://bugs.webkit.org/show_bug.cgi?id=157756
3206
3207         Reviewed by Geoffrey Garen.
3208
3209         Rewires a bunch of includes/imports.
3210
3211         * WebCoreSupport/PopupMenuMac.mm:
3212         * WebCoreSupport/WebChromeClient.mm:
3213         * WebCoreSupport/WebFrameLoaderClient.mm:
3214         * WebCoreSupport/WebGeolocationClient.mm:
3215         * WebCoreSupport/WebNotificationClient.mm:
3216         * WebCoreSupport/WebPlatformStrategies.mm:
3217         * WebCoreSupport/WebUserMediaClient.mm:
3218         * WebCoreSupport/WebVisitedLinkStore.mm:
3219         * WebView/WebHTMLView.mm:
3220
3221 2016-05-13  Enrica Casucci  <enrica@apple.com>
3222
3223         Remove unused initializer for WebEvent on iOS.
3224         https://bugs.webkit.org/show_bug.cgi?id=157689
3225
3226         Reviewed by Anders Carlsson.
3227
3228         Removing use of characterSet property.
3229
3230         * WebView/WebHTMLView.mm:
3231         (-[WebHTMLView _handleEditingKeyEvent:]):
3232
3233
3234 2016-05-13  Commit Queue  <commit-queue@webkit.org>
3235
3236         Unreviewed, rolling out r200894.
3237         https://bugs.webkit.org/show_bug.cgi?id=157695
3238
3239         This change broke the iOS build (Requested by ryanhaddad on
3240         #webkit).
3241
3242         Reverted changeset:
3243
3244         "Remove unused initializer for WebEvent on iOS."
3245         https://bugs.webkit.org/show_bug.cgi?id=157689
3246         http://trac.webkit.org/changeset/200894
3247
3248 2016-05-13  Enrica Casucci  <enrica@apple.com>
3249
3250         Remove unused initializer for WebEvent on iOS.
3251         https://bugs.webkit.org/show_bug.cgi?id=157689
3252
3253         Reviewed by Anders Carlsson.
3254
3255         Removing use of characterSet property.
3256
3257         * WebView/WebHTMLView.mm:
3258         (-[WebHTMLView _handleEditingKeyEvent:]):
3259
3260 2016-05-13  Beth Dakin  <bdakin@apple.com>
3261
3262         Build fix.
3263
3264         * WebView/WebView.mm:
3265
3266 2016-05-13  Beth Dakin  <bdakin@apple.com>
3267
3268         Add dyldSPI.h for linked on or after checks, and add one for link preview
3269         https://bugs.webkit.org/show_bug.cgi?id=157401
3270         -and corresponding-
3271         rdar://problem/26253396
3272
3273         Reviewed by Darin Adler.
3274
3275         This patch removes DynamicLinkerSPI.h and replaces it with 
3276         wtf/spi/darwin/dyldSPI.h
3277
3278         * WebView/WebView.mm:
3279
3280 2016-05-13  Tina Liu  <iting_liu@apple.com>
3281
3282         Revert r199691.
3283         https://bugs.webkit.org/show_bug.cgi?id=157645
3284         <rdar://problem/26235373>
3285
3286         Reviewed by Darin Adler.
3287
3288         * WebCoreSupport/WebPlatformStrategies.h:
3289         * WebCoreSupport/WebPlatformStrategies.mm:
3290         (WebPlatformStrategies::setPrivateBrowsingPluginLoadClientPolicy): Deleted.
3291
3292 2016-05-12  Jiewen Tan  <jiewen_tan@apple.com>
3293
3294         Unreviewed build fix for r200799.
3295
3296         * WebView/WebView.mm:
3297
3298 2016-05-12  Jiewen Tan  <jiewen_tan@apple.com>
3299
3300         REGRESSION (r199313): ICBC app: text field In the webview is not tappable
3301         https://bugs.webkit.org/show_bug.cgi?id=157396
3302         <rdar://problem/25931513>
3303
3304         Reviewed by David Kilzer.
3305
3306         Add a quirk for WebKit1 apps.
3307
3308         * WebView/WebView.mm:
3309         (shouldConvertInvalidURLsToBlank):
3310         (-[WebView _preferencesChanged:]):
3311
3312 2016-05-12  Beth Dakin  <bdakin@apple.com>
3313
3314         WebKitAdditions needs to be notified before the WebView is dealloc'd
3315         https://bugs.webkit.org/show_bug.cgi?id=157633
3316         -and corresponding-
3317         rdar://problem/26134539
3318
3319         Reviewed by Anders Carlsson.
3320
3321         * WebView/WebView.mm:
3322         (-[WebView dealloc]):
3323         * WebView/WebViewInternal.h:
3324
3325 2016-05-12  Konstantin Tokarev  <annulen@yandex.ru>
3326
3327         Use reference instead of pointer in FrameLoaderClient::saveViewStateToItem.
3328         https://bugs.webkit.org/show_bug.cgi?id=157624
3329
3330         Reviewed by Darin Adler.
3331
3332         * WebCoreSupport/WebFrameLoaderClient.h:
3333         * WebCoreSupport/WebFrameLoaderClient.mm:
3334         (WebFrameLoaderClient::saveViewStateToItem):
3335         * WebView/WebFrame.mm:
3336         (-[WebFrame _saveViewState]):
3337
3338 2016-05-12  Csaba Osztrogonác  <ossy@webkit.org>
3339
3340         Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
3341         https://bugs.webkit.org/show_bug.cgi?id=157564
3342
3343         Reviewed by Darin Adler.
3344
3345         * Configurations/FeatureDefines.xcconfig:
3346
3347 2016-05-11  Chris Dumez  <cdumez@apple.com>
3348
3349         Update Node::appendChild() / replaceChild() / removeChild() / insertBefore() to take references instead of pointers
3350         https://bugs.webkit.org/show_bug.cgi?id=157556
3351
3352         Reviewed by Darin Adler.
3353
3354         * WebView/WebFrame.mm:
3355         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
3356
3357 2016-05-10  Shaw rich  <richshaw@126.com>
3358
3359         [OS X] Compatible with gnu sed grammar due to compile error with gnu sed
3360         https://bugs.webkit.org/show_bug.cgi?id=157526
3361
3362         Reviewed by Darin Adler.
3363
3364         * MigrateHeaders.make:
3365
3366 2016-05-10  Simon Fraser  <simon.fraser@apple.com>
3367
3368         [iOS WK1] text autosizing was on for all layout tests
3369         https://bugs.webkit.org/show_bug.cgi?id=157541
3370
3371         Reviewed by Tim Horton.
3372
3373         Make sure that we transfer the WK1 text autosizing preference to Settings.
3374
3375         * WebView/WebView.mm:
3376         (-[WebView _preferencesChanged:]):
3377
3378 2016-05-09  Tim Horton  <timothy_horton@apple.com>
3379
3380         [WebKit1] Invoking a link preview on a complex link (e.g. an image) results in an empty TextIndicator
3381         https://bugs.webkit.org/show_bug.cgi?id=157497
3382         <rdar://problem/25872773>
3383
3384         Reviewed by Anders Carlsson.
3385
3386         * WebView/WebImmediateActionController.mm:
3387         (-[WebImmediateActionController _defaultAnimationController]):
3388         r198578 fixed this for WebKit2, but forgot about WebKit1.
3389
3390 2016-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3391
3392         [OS X] Migrate our Font classes entirely off of NSFont
3393         https://bugs.webkit.org/show_bug.cgi?id=157464
3394
3395         Reviewed by Darin Adler.
3396
3397         * WebCoreSupport/PopupMenuMac.mm:
3398         (PopupMenuMac::populate):
3399         (PopupMenuMac::show):
3400         * WebView/WebHTMLView.mm:
3401         (fontNameForDescription):
3402         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3403
3404 2016-05-06  Joseph Pecoraro  <pecoraro@apple.com>
3405
3406         Rename HitTestRequest DisallowShadowContent to DisallowUserAgentShadowContent
3407         https://bugs.webkit.org/show_bug.cgi?id=157447
3408
3409         Reviewed by Ryosuke Niwa.
3410
3411         * WebView/WebFrame.mm:
3412         (-[WebFrame elementAtPoint:]):
3413         * WebView/WebHTMLView.mm:
3414         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
3415
3416 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
3417
3418         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
3419         https://bugs.webkit.org/show_bug.cgi?id=157432
3420         rdar://problem/16406720
3421
3422         Reviewed by Dean Jackson.
3423
3424         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
3425
3426         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
3427         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
3428         These two settings are shared with TEXT_AUTOSIZING.
3429
3430         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
3431
3432         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
3433         without changes.
3434
3435         An implication of this set of changes is that the way clients enable text autosizing
3436         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
3437         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
3438         on iPhone only, not iPad.
3439
3440         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
3441         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
3442
3443         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
3444         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
3445         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
3446
3447         * Configurations/FeatureDefines.xcconfig:
3448         * WebView/WebPreferenceKeysPrivate.h:
3449         * WebView/WebPreferences.mm:
3450         (+[WebPreferences initialize]):
3451         (-[WebPreferences _setTextAutosizingEnabled:]):
3452         (-[WebPreferences _textAutosizingEnabled]):
3453         * WebView/WebPreferencesPrivate.h:
3454
3455 2016-05-06  Dean Jackson  <dino@apple.com>
3456
3457         Regions, Shapes and Tracks don't need runtime features
3458         https://bugs.webkit.org/show_bug.cgi?id=157426
3459         <rdar://problem/26146262>
3460
3461         Reviewed by Simon Fraser.
3462
3463         The following RuntimeEnabledFeatures can be removed since
3464         we have no need to disable them (they are stable and have
3465         shipped for a while):
3466         - CSS Regions
3467         - CSS Shapes
3468         - Media tracks
3469
3470         * WebView/WebPreferenceKeysPrivate.h:
3471         * WebView/WebPreferences.mm:
3472         (+[WebPreferences initialize]): Deleted.
3473         (-[WebPreferences cssRegionsEnabled]): Deleted.
3474         (-[WebPreferences setCSSRegionsEnabled:]): Deleted.
3475         (-[WebPreferences cssCompositingEnabled]): Deleted.
3476         (-[WebPreferences setCSSCompositingEnabled:]): Deleted.
3477         * WebView/WebPreferencesPrivate.h:
3478         * WebView/WebView.mm:
3479         (-[WebView _preferencesChanged:]): Deleted.
3480
3481 2016-05-06  Daniel Bates  <dabates@apple.com>
3482
3483         Remove workaround for Apple Internal bots
3484         <rdar://problem/25989808>
3485
3486         Reverts the workaround added in r200211 as it is no longer needed.
3487
3488         * WebView/WebPDFView.h:
3489
3490 2016-05-02  Daniel Bates  <dabates@apple.com>
3491
3492         CSP: Add workaround for XtraMath
3493         https://bugs.webkit.org/show_bug.cgi?id=157252
3494
3495         Reviewed by Andy Estes.
3496
3497         * WebView/WebView.mm:
3498         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol): Allow * to match any protocol for
3499         applicable versions of app XtraMath.
3500
3501 2016-05-02  Daniel Bates  <dabates@apple.com>
3502
3503         DatabaseTracker::closeAllDatabases calls Database::close from the wrong thread
3504         https://bugs.webkit.org/show_bug.cgi?id=147672
3505         <rdar://problem/22357464>
3506
3507         Reviewed by Brady Eidson.
3508
3509         Update the background assertion expiration callback to call DatabaseTracker::closeAllDatabases()
3510         with CurrentQueryBehavior::Interrupt so that we abort a long running query and close the database
3511         immediately to avoid holding a locked file when the process is suspended.
3512
3513         * Storage/WebDatabaseManager.mm:
3514         (+[WebDatabaseManager startBackgroundTask]):
3515
3516 2016-04-29  Dean Jackson  <dino@apple.com>
3517
3518         RTL <select> popup menu is in the wrong location
3519         https://bugs.webkit.org/show_bug.cgi?id=157159
3520         <rdar://problem/25894451>
3521
3522         Reapply http://trac.webkit.org/changeset/200217
3523         but with changes that will allow it to build on Yosemite.
3524
3525         * WebCoreSupport/PopupMenuMac.mm:
3526         (PopupMenuMac::show):
3527
3528 2016-04-29  Commit Queue  <commit-queue@webkit.org>
3529
3530         Unreviewed, rolling out r200217.
3531         https://bugs.webkit.org/show_bug.cgi?id=157183
3532
3533         This change broke the Yosemite build. (Requested by ryanhaddad
3534         on #webkit).
3535
3536         Reverted changeset:
3537
3538         "RTL <select> popup menu is in the wrong location"
3539         https://bugs.webkit.org/show_bug.cgi?id=157159
3540         http://trac.webkit.org/changeset/200217
3541
3542 2016-04-28  Dean Jackson  <dino@apple.com>
3543
3544         RTL <select> popup menu is in the wrong location
3545         https://bugs.webkit.org/show_bug.cgi?id=157159
3546         <rdar://problem/25894451>
3547
3548         Reviewed by Simon Fraser.
3549
3550         Make sure both the NSPopupMenuCell and the NSPopupMenu take
3551         the text direction into account, and offset the position
3552         of the menu slightly if we're in RTL mode.
3553
3554         Unfortunately our test infrastructure is unable to exercise
3555         this because it runs without a window, and the popup menu
3556         is not captured in the screenshot.
3557
3558         * WebCoreSupport/PopupMenuMac.mm:
3559         (PopupMenuMac::show):
3560
3561 2016-04-28  Manuel Rego Casasnovas  <rego@igalia.com>
3562
3563         [css-grid] Add CSS Grid Layout runtime flag
3564         https://bugs.webkit.org/show_bug.cgi?id=157134
3565
3566         Reviewed by Simon Fraser.
3567
3568         Add CSS Grid Layout runtime flag based on preferences,
3569         enabled by default.
3570
3571         * WebView/WebPreferenceKeysPrivate.h:
3572         * WebView/WebPreferences.mm:
3573         (+[WebPreferences initialize]):
3574         (-[WebPreferences isCSSGridLayoutEnabled]):
3575         (-[WebPreferences setCSSGridLayoutEnabled:]):
3576         * WebView/WebPreferencesPrivate.h:
3577         * WebView/WebView.mm:
3578         (-[WebView _preferencesChanged:]):
3579
3580 2016-04-28  Daniel Bates  <dabates@apple.com>
3581
3582         Another fix for the Apple Internal OS X build
3583         <rdar://problem/25989808>
3584
3585         Reviewed by Anders Carlsson.
3586
3587         * WebView/WebPDFView.h:
3588
3589 2016-04-28  Daniel Bates  <dabates@apple.com>
3590
3591         Fix the Apple Internal OS X build
3592
3593         * WebView/WebPDFView.h: Import PDFKit for definition of protocol PDFViewDelegate.
3594         Forward declare protocol PDFViewDelegate as appropriate. Mark WebPDFView as implementing
3595         protocol PDFViewDelegate.
3596         * WebView/WebPDFView.mm: Move import of PDFKit from here to the header.
3597
3598 2016-04-27  Daniel Bates  <dabates@apple.com>
3599
3600         CSP: Add app-specific workaround for Ecobee and Quora
3601         https://bugs.webkit.org/show_bug.cgi?id=157005
3602         <rdar://problem/25560776>
3603
3604         Reviewed by Brent Fulgham.
3605
3606         * Misc/WebKitVersionChecks.h:
3607         * WebView/WebView.mm:
3608         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol): Added.
3609         (-[WebView _preferencesChanged:]): Enable setting allowContentSecurityPolicySourceStarToMatchAnyProtocol
3610         if applicable.
3611
3612 2016-04-26  Joseph Pecoraro  <pecoraro@apple.com>
3613
3614         Uncaught Exception: SecurityError: DOM Exception 18: An attempt was made to break through the security policy of the user agent.
3615         https://bugs.webkit.org/show_bug.cgi?id=156991
3616         <rdar://problem/25913475>
3617
3618         Reviewed by Timothy Hatcher.
3619
3620         * WebCoreSupport/WebInspectorClient.mm:
3621         (-[WebInspectorWindowController init]):
3622         Apply the same universal file access to WebKit1 Web Inspector views that
3623         we apply to WebKit2 views. Explicitly always allow access to storage
3624         for Web Inspector content just in case as we already allow universal
3625         file access.
3626
3627 2016-04-26  Beth Dakin  <bdakin@apple.com>
3628
3629         Check to make sure shouldRequestCandidates() before requesting candidates
3630         https://bugs.webkit.org/show_bug.cgi?id=157038
3631         -and corresponding-
3632         rdar://problem/25910418
3633
3634         Reviewed by Tim Horton.
3635
3636         This patch limits requesting and showing candidates to cases where 
3637         shouldRequestCandidates() is true. This patch also caches the sequence number 
3638         returned by [NSSpellChecker requestCandidatesForSelectedRange:] to make sure 
3639         it is equal to the sequence number sent to the callback handler so that we do 
3640         not show candidates for old requests.
3641
3642         * WebCoreSupport/WebEditorClient.h:
3643         * WebCoreSupport/WebEditorClient.mm:
3644         (WebEditorClient::requestCandidatesForSelection):
3645         (WebEditorClient::handleRequestedCandidates):
3646         * WebView/WebView.mm:
3647         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3648         (-[WebView shouldRequestCandidates]):
3649         * WebView/WebViewInternal.h:
3650
3651 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3652
3653         Remove the build flag for template elements
3654         https://bugs.webkit.org/show_bug.cgi?id=157022
3655
3656         Reviewed by Daniel Bates.
3657
3658         * Configurations/FeatureDefines.xcconfig:
3659
3660 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
3661
3662         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
3663         https://bugs.webkit.org/show_bug.cgi?id=156929
3664
3665         Reviewed by Darin Adler.
3666
3667         * Misc/WebKitNSStringExtras.mm:
3668         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Drawing
3669         a string with a null font shouldn't do anything.
3670         * Misc/WebStringTruncator.mm: We can't truncate a string if we don't have a font
3671         to use.
3672         (+[WebStringTruncator centerTruncateString:toWidth:]):
3673         (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
3674         (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
3675         (+[WebStringTruncator widthOfString:font:]):
3676
3677 2016-04-25  Beth Dakin  <bdakin@apple.com>
3678
3679         WebEditorClient should properly write to m_rangeForCandidates
3680         https://bugs.webkit.org/show_bug.cgi?id=157003
3681         -and corresponding-
3682         rdar://problem/25910418
3683
3684         Reviewed by Tim Horton.
3685
3686         Actually write to m_rangeForCandidates instead of declaring a local variable 
3687         of the same name. :-/
3688         * WebCoreSupport/WebEditorClient.mm:
3689         (WebEditorClient::requestCandidatesForSelection):
3690
3691 2016-04-23  Andy Estes  <aestes@apple.com>
3692
3693         Fix issues found by the clang static analyzer
3694         https://bugs.webkit.org/show_bug.cgi?id=156956
3695
3696         Reviewed by Alexey Proskuryakov.
3697
3698         * WebView/WebDeviceOrientationProviderMock.mm:
3699         (-[WebDeviceOrientationProviderMock dealloc]): [super dealloc] should be called last.
3700
3701 2016-04-21  Tim Horton  <timothy_horton@apple.com>
3702
3703         Fix the iOS build: WAKView may not respond to drawLayer:inContext:
3704         https://bugs.webkit.org/show_bug.cgi?id=156879
3705         <rdar://problem/25772661>
3706
3707         Reviewed by Beth Dakin.
3708
3709         * WebView/WebHTMLView.mm:
3710         WebHTMLView on iOS never uses drawLayer:inContext:, and WAKView
3711         doesn't implement it, so this would have thrown an exception
3712         if called, anyway. Fix the build with stricter CA protocols.
3713
3714 2016-04-21  Jer Noble  <jer.noble@apple.com>
3715
3716         [WK1] Add WebPlaybackSession support to WebKit
3717         https://bugs.webkit.org/show_bug.cgi?id=156854
3718
3719         Reviewed by Beth Dakin.
3720
3721         Add support for WebPlaybackSession and the ChromeClient methods setUpPlaybackControlsManager() and
3722         clearPlaybackControlsManager() to WebKit.
3723
3724         * WebCoreSupport/WebChromeClient.h:
3725         * WebCoreSupport/WebChromeClient.mm:
3726         (WebChromeClient::setUpPlaybackControlsManager):
3727         (WebChromeClient::clearPlaybackControlsManager):
3728         * WebView/WebView.mm:
3729         (-[WebView _hasActiveVideoForControlsInterface]):
3730         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3731         (-[WebView _clearPlaybackControlsManagerForMediaElement:]):
3732         * WebView/WebViewData.h:
3733         * WebView/WebViewData.mm:
3734         * WebView/WebViewInternal.h:
3735
3736 2016-04-21  Anders Carlsson  <andersca@apple.com>
3737
3738         Stop using ApplicationCacheStorage::singleton() in WebKitLegacy
3739         https://bugs.webkit.org/show_bug.cgi?id=156859
3740
3741         Reviewed by Tim Horton.
3742
3743         * WebCoreSupport/WebApplicationCache.mm:
3744         (+[WebApplicationCache initializeWithBundleIdentifier:]):
3745         Change this to just store the bundle identifier.
3746
3747         (applicationCacheBundleIdentifier):
3748         Helper function that returns the bundle identifier for the app cache.
3749
3750         (applicationCachePath):
3751         Return the application cache path.
3752
3753         (webApplicationCacheStorage):
3754         Create a new ApplicationCacheStorage object.
3755
3756         * WebView/WebView.mm:
3757         (-[WebView _commonInitializationWithFrameName:groupName:]):
3758         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3759         Set pageConfiguration.applicationCacheStorage to webApplicationCacheStorage().
3760
3761         (WebKitInitializeApplicationCachePathIfNecessary): Deleted.
3762
3763 2016-04-21  Beth Dakin  <bdakin@apple.com>
3764
3765         showCandidates() should take a range and the string should be the whole 
3766         paragraph
3767         https://bugs.webkit.org/show_bug.cgi?id=156813
3768         -and corresponding-
3769         rdar://problem/25760533
3770
3771         Reviewed by Tim Horton.
3772
3773         Cache the range and the paragraph since we compute them in 
3774         requestCandidatesForSelection, and then we can use them again in 
3775         handleRequestedCandidates.
3776         * WebCoreSupport/WebEditorClient.h:
3777         * WebCoreSupport/WebEditorClient.mm:
3778         (WebEditorClient::requestCandidatesForSelection):
3779         (WebEditorClient::handleRequestedCandidates):
3780         * WebView/WebView.mm:
3781         (-[WebView updateWebViewAdditions]):
3782         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3783         (-[WebView showCandidates:forString:inRect:view:completionHandler:]): Deleted.
3784         * WebView/WebViewInternal.h:
3785
3786 2016-04-21  Chris Dumez  <cdumez@apple.com>
3787
3788         Drop [UsePointersEvenForNonNullableObjectArguments] from Range
3789         https://bugs.webkit.org/show_bug.cgi?id=156805
3790
3791         Reviewed by Youenn Fablet.
3792
3793         * WebView/WebFrame.mm:
3794         (-[WebFrame _smartDeleteRangeForProposedRange:]):
3795
3796 2016-04-20  Brady Eidson  <beidson@apple.com>
3797
3798         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
3799         https://bugs.webkit.org/show_bug.cgi?id=156782
3800
3801         Reviewed by Alex Christensen.
3802
3803         * Configurations/FeatureDefines.xcconfig:
3804
3805 2016-04-18  Anders Carlsson  <andersca@apple.com>
3806
3807         Fix build with newer versions of clang.
3808         rdar://problem/25749769
3809
3810         * WebCoreSupport/WebContextMenuClient.mm:
3811         * WebView/WebHTMLView.mm:
3812         Forward declare some AppKit IPI.
3813
3814 2016-04-18  Tina Liu  <iting_liu@apple.com>
3815
3816         Overrode a virtual function of WebCore::PluginStrategy
3817         https://bugs.webkit.org/show_bug.cgi?id=156540
3818
3819         Reviewed by Anders Carlsson.
3820
3821         * WebCoreSupport/WebPlatformStrategies.h:
3822         * WebCoreSupport/WebPlatformStrategies.mm:
3823         (WebPlatformStrategies::setPrivateBrowsingPluginLoadClientPolicy):
3824
3825 2016-04-18  Brent Fulgham  <bfulgham@apple.com>
3826
3827         CSP: Remove stubs for dynamically-added favicons (via link rel="icon")
3828         https://bugs.webkit.org/show_bug.cgi?id=153151
3829         <rdar://problem/24383176>
3830
3831         Reviewed by Darin Adler.
3832
3833         Remove the unused dynamic favicon code and tests.
3834
3835         * WebCoreSupport/WebFrameLoaderClient.h:
3836         * WebCoreSupport/WebFrameLoaderClient.mm:
3837         (WebFrameLoaderClient::dispatchDidChangeIcons): Deleted.
3838
3839 2016-04-15  Darin Adler  <darin@apple.com>
3840
3841         Reduce use of Deprecated::ScriptXXX classes
3842         https://bugs.webkit.org/show_bug.cgi?id=156632
3843
3844         Reviewed by Alex Christensen.
3845
3846         * WebView/WebFrame.mm:
3847         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Use references instead
3848         of pointers.
3849         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Updated
3850         since return value is a JSValue.
3851         * WebView/WebView.mm:
3852         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3853
3854 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
3855
3856         Make <a download> a runtime enabled option
3857         https://bugs.webkit.org/show_bug.cgi?id=156583
3858         <rdar://problem/25733449>
3859
3860         Reviewed by Alex Christensen.
3861
3862         Add a download attribute runtime flag based on preferences.
3863         Disable the download attribute by default.
3864
3865         * WebView/WebPreferenceKeysPrivate.h:
3866         * WebView/WebPreferences.mm:
3867         (+[WebPreferences initialize]):
3868         (-[WebPreferences setFetchAPIEnabled:]):
3869         (-[WebPreferences downloadAttributeEnabled]):
3870         (-[WebPreferences setDownloadAttributeEnabled:]):
3871         * WebView/WebPreferencesPrivate.h:
3872         * WebView/WebView.mm:
3873         (-[WebView _preferencesChanged]): Set the runtime flag properly
3874         based on the user preferences.
3875
3876 2016-04-09  Gavin Barraclough  <barraclough@apple.com>
3877
3878         WebKit should adopt journal_mode=wal for all SQLite databases.
3879         https://bugs.webkit.org/show_bug.cgi?id=133496
3880
3881         Reviewed by Darin Adler.
3882
3883         * Storage/WebDatabaseManagerPrivate.h:
3884             - renamed deleteAllDatabases -> deleteAllDatabasesImmediately.
3885
3886 2016-04-05  Oliver Hunt  <oliver@apple.com>
3887
3888         Remove compile time define for SEPARATED_HEAP
3889         https://bugs.webkit.org/show_bug.cgi?id=155508
3890
3891         Reviewed by Mark Lam.
3892
3893         * Configurations/FeatureDefines.xcconfig:
3894
3895 2016-04-08  Sam Weinig  <sam@webkit.org>
3896
3897         Remove support for custom target picker actions
3898         <rdar://problem/24987783>
3899         https://bugs.webkit.org/show_bug.cgi?id=156434
3900
3901         Reviewed by Eric Carlson.
3902
3903         This mostly entailed rolling out r197429 and r197569.
3904
3905         * WebCoreSupport/WebChromeClient.h:
3906         * WebCoreSupport/WebChromeClient.mm:
3907         (WebChromeClient::removePlaybackTargetPickerClient):
3908         (WebChromeClient::showPlaybackTargetPicker):
3909         * WebView/WebMediaPlaybackTargetPicker.h:
3910         * WebView/WebMediaPlaybackTargetPicker.mm:
3911         (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
3912         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3913         (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
3914         (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget):
3915         (WebMediaPlaybackTargetPicker::invalidate):
3916         (WebMediaPlaybackTargetPicker::customPlaybackActionSelected): Deleted.
3917         * WebView/WebView.mm:
3918         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
3919         (-[WebView _playbackTargetPickerClientStateDidChange:state:]):
3920
3921 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
3922
3923         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
3924         https://bugs.webkit.org/show_bug.cgi?id=156384
3925
3926         Reviewed by Ryosuke Niwa.
3927
3928         * Configurations/FeatureDefines.xcconfig:
3929
3930 2016-04-07  Brian Burg  <bburg@apple.com>
3931
3932         CookieJar should support adding synthetic cookies for developer tools
3933         https://bugs.webkit.org/show_bug.cgi?id=156091
3934         <rdar://problem/25581340>
3935
3936         Reviewed by Timothy Hatcher.
3937
3938         * WebCoreSupport/WebPlatformStrategies.h:
3939         * WebCoreSupport/WebPlatformStrategies.mm:
3940         (WebPlatformStrategies::addCookie):
3941         Add new method override.
3942
3943 2016-04-06  Alex Christensen  <achristensen@webkit.org>
3944
3945         Fix CMake DumpRenderTree
3946         https://bugs.webkit.org/show_bug.cgi?id=156305
3947
3948         Reviewed by Daniel Bates.
3949
3950         * WebKitPrefix.h:
3951
3952 2016-04-05  Beth Dakin  <bdakin@apple.com>
3953
3954         Make requestCandidatesForSelection available on any EditorClient
3955         https://bugs.webkit.org/show_bug.cgi?id=156253
3956         -and corresponding-
3957         rdar://problem/24661147
3958
3959         Reviewed by Dean Jackson.
3960
3961         * WebCoreSupport/WebEditorClient.h:
3962
3963 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3964
3965         [Fetch API] Add a runtime flag to fetch API and related constructs
3966         https://bugs.webkit.org/show_bug.cgi?id=156113
3967  
3968         Reviewed by Alex Christensen.
3969
3970         Add a fetch API runtime flag based on preferences.
3971         Disable fetch API by default.
3972  
3973         * WebView/WebPreferenceKeysPrivate.h:
3974         * WebView/WebPreferences.mm:
3975         (+[WebPreferences initialize]):
3976         (-[WebPreferences setCustomElementsEnabled:]):
3977         (-[WebPreferences fetchAPIEnabled]):
3978         (-[WebPreferences setFetchAPIEnabled:]):
3979         * WebView/WebPreferencesPrivate.h:
3980         * WebView/WebView.mm:
3981         (-[WebView _preferencesChanged:]):
3982         (-[WebView preferencesIdentifier]):
3983         (-[WebView setUIDelegate:]):
3984
3985 2016-04-05  Antoine Quint  <graouts@apple.com>
3986
3987         [WebGL2] Turn the ENABLE_WEBGL2 flag on
3988         https://bugs.webkit.org/show_bug.cgi?id=156061
3989         <rdar://problem/25463193>
3990
3991         Reviewed by Alex Christensen.
3992
3993         * Configurations/FeatureDefines.xcconfig:
3994
3995 2016-04-05  Antoine Quint  <graouts@apple.com>
3996
3997         [WebGL2] Allow enabling WebGL2 with a runtime flag
3998         https://bugs.webkit.org/show_bug.cgi?id=156166
3999         <rdar://problem/25526929>
4000
4001         Set the WebGL2 runtime flag based on preferences, disabled by default.
4002
4003         Reviewed by Dean Jackson.
4004
4005         * WebView/WebPreferenceKeysPrivate.h:
4006         * WebView/WebPreferences.mm:
4007         (+[WebPreferences initialize]):
4008         (-[WebPreferences webGL2Enabled]):
4009         (-[WebPreferences setWebGL2Enabled:]):
4010         * WebView/WebPreferencesPrivate.h:
4011         * WebView/WebView.mm:
4012         (-[WebView _preferencesChanged:]):
4013
4014 2016-04-01  Alex Christensen  <achristensen@webkit.org>
4015
4016         Compile DumpRenderTree with CMake on Mac
4017         https://bugs.webkit.org/show_bug.cgi?id=156088
4018
4019         Reviewed by Brent Fulgham.
4020
4021         * Misc/WebKit.h:
4022         Alphabetize headers.
4023
4024 2016-03-31  Jeremy Jones  <jeremyj@apple.com>
4025
4026         mediaShouldUsePersistentCache() is redundant. Use Page::usesEphemeralSession() instead.
4027         https://bugs.webkit.org/show_bug.cgi?id=155924
4028
4029         Reviewed by Simon Fraser.
4030
4031         Remove mediaShouldUsePersistentCache machinery as it is redundant.
4032
4033         * WebCoreSupport/WebChromeClient.h:
4034         * WebCoreSupport/WebChromeClient.mm:
4035         (WebChromeClient::mediaShouldUsePersistentCache): Deleted.
4036
4037 2016-03-30  Ada Chan  <adachan@apple.com>
4038
4039         Add the new "toggle enhanced fullscreen" context menu item to the video context menu on supporting platforms.
4040         https://bugs.webkit.org/show_bug.cgi?id=156031
4041
4042         Reviewed by Eric Carlson.
4043
4044         * WebView/WebHTMLView.mm:
4045         (toAction):
4046         (toTag):
4047         * WebView/WebUIDelegatePrivate.h:
4048
4049 2016-03-24  Said Abou-Hallawa  <sabouhallawa@apple,com>
4050
4051         Change NativeImagePtr for CG to be RetainPtr<CGImageRef>
4052         https://bugs.webkit.org/show_bug.cgi?id=155412
4053
4054         Reviewed by Darin Adler.
4055
4056         * Misc/WebCache.mm:
4057         (+[WebCache addImageToCache:forURL:forFrame:]):
4058         WebCore::MemoryCache() is taking an rvalue NativeImagePtr. We need to create
4059         NativeImagePtr from the image raw pointer when calling this function.
4060
4061 2016-03-24  Tim Horton  <timothy_horton@apple.com>
4062
4063         Fix some new PDFKit-related warnings
4064         https://bugs.webkit.org/show_bug.cgi?id=155847
4065         <rdar://problem/25340312>
4066
4067         Reviewed by Anders Carlsson.
4068
4069         * WebView/WebPDFView.mm:
4070         (-[WebPDFView setViewState:]):
4071         * WebView/WebPreferences.mm:
4072         (-[WebPreferences PDFDisplayMode]):
4073         PDFDisplayMode is now a real enum.
4074
4075 2016-03-23  Anders Carlsson  <andersca@apple.com>
4076
4077         Crash when using KVO from within -[WebView initWithCoder:]
4078         https://bugs.webkit.org/show_bug.cgi?id=155816
4079         rdar://problem/17073265
4080
4081         Reviewed by Dan Bernstein.
4082
4083         Get rid of the observationInfo getter and setter. It's not clear why they were added (in 2003),
4084         and the methods on NSObject are good enough for us.
4085
4086         * WebView/WebView.mm:
4087         (-[WebView setObservationInfo:]): Deleted.
4088         (-[WebView observationInfo]): Deleted.
4089         * WebView/WebViewData.h:
4090
4091 2016-03-22  Beth Dakin  <bdakin@apple.com>
4092
4093         Advanced spell checking should be guarded behind 
4094         HAVE(ADVANCED_SPELL_CHECKING)
4095         https://bugs.webkit.org/show_bug.cgi?id=155738
4096
4097         Reviewed by Geoff Garen.
4098
4099         * WebCoreSupport/WebEditorClient.mm:
4100         (insertionPointFromCurrentSelection):
4101         (WebEditorClient::checkTextOfParagraph):
4102         (WebEditorClient::getGuessesForWord):
4103         (WebEditorClient::requestCandidatesForSelection):
4104         (WebEditorClient::handleRequestedCandidates):
4105         (WebEditorClient::requestCheckingOfString):
4106         * WebKitPrefix.h:
4107         * WebView/WebHTMLView.mm:
4108         (-[WebHTMLView insertText:]):
4109
4110 2016-03-20  Dan Bernstein  <mitz@apple.com>
4111
4112         [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
4113         https://bugs.webkit.org/show_bug.cgi?id=155707
4114         <rdar://problem/24980691>
4115
4116         Reviewed by Darin Adler.
4117
4118         * Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last
4119           component of MACOSX_DEPLOYMENT_TARGET.
4120         * Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of
4121           TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.
4122
4123 2016-03-20  Darin Adler  <darin@apple.com>
4124
4125         Disable Caches in Safari's Develop menu does not disable caches.
4126         https://bugs.webkit.org/show_bug.cgi?id=64483
4127
4128         Reviewed by Antti Koivisto.
4129
4130         Removed unneeded WebPreferences property; we don't need this for Legacy WebKit.
4131
4132         * WebView/WebPreferenceKeysPrivate.h: Removed
4133         WebKitResourceCachingDisabledPreferenceKey.
4134         * WebView/WebPreferences.mm:
4135         (-[WebPreferences isResourceCachingDisabled]): Deleted.
4136         (-[WebPreferences setResourceCachingDisabled:]): Deleted.
4137         * WebView/WebPreferencesPrivate.h: Removed resourceCachingDisabled property.
4138         * WebView/WebView.mm:
4139         (-[WebView _preferencesChanged:]): Removed code to update resourceCachingDisabled.
4140
4141 2016-03-20  Dan Bernstein  <mitz@apple.com>
4142
4143         Update build settings
4144
4145         Rubber-stamped by Andy Estes.
4146
4147         * Configurations/DebugRelease.xcconfig:
4148         * Configurations/FeatureDefines.xcconfig:
4149         * Configurations/Version.xcconfig:
4150
4151 2016-03-18  Darin Adler  <darin@apple.com>
4152
4153         Disable Caches in Safari's Develop menu does not disable caches.
4154         https://bugs.webkit.org/show_bug.cgi?id=64483
4155
4156         Reviewed by Antti Koivisto.
4157
4158         * WebView/WebPreferenceKeysPrivate.h: Added ResourceCachingDisabled.
4159         * WebView/WebPreferences.mm:
4160         (-[WebPreferences isResourceCachingDisabled]): Added.
4161         (-[WebPreferences setResourceCachingDisabled:]): Added.
4162         * WebView/WebPreferencesPrivate.h: Added resourceCachingDisabled.
4163         * WebView/WebView.mm:
4164         (-[WebView _preferencesChanged:]): Push resourceCachingDisabled into WebCore.
4165
4166 2016-03-17  Csaba Osztrogonác  <ossy@webkit.org>
4167
4168         [cmake][Mac] Unreviewed speculative buildfix after r198088. Just for fun.
4169
4170         * WebView/WebView.mm:
4171         (-[WebView _preferencesChanged:]):
4172
4173 2016-03-17  Andy Estes  <aestes@apple.com>
4174
4175         [Mac] Enable Content-Disposition: attachment sandbox
4176         https://bugs.webkit.org/show_bug.cgi?id=155578
4177         <rdar://problem/21886326>
4178
4179         Reviewed by Dan Bernstein.
4180
4181         Covered by the existing set of attachment sandbox tests, which have always been run on Mac.
4182
4183         * WebView/WebView.mm:
4184         (-[WebView _commonInitializationWithFrameName:groupName:]):
4185
4186 2016-03-16  Beth Dakin  <bdakin@apple.com>
4187
4188         Provide NSSpellChecker spellChecking methods with the current insertion point
4189         https://bugs.webkit.org/show_bug.cgi?id=155532
4190         -and corresponding-
4191         rdar://problem/24066952
4192
4193         Reviewed by Simon Fraser.
4194
4195         Extract the insertion point from the VisibleSelection that WebCore has 
4196         passed. 
4197         * WebCoreSupport/WebEditorClient.h:
4198         (WebEditorClient::getGuessesForWord):
4199         * WebCoreSupport/WebEditorClient.mm:
4200         (WebEditorClient::checkTextOfParagraph):