Turn preferLowPowerWebGLRendering setting on by default
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-01-05  Chris Dumez  <cdumez@apple.com>
2
3         Turn preferLowPowerWebGLRendering setting on by default
4         https://bugs.webkit.org/show_bug.cgi?id=166737
5         <rdar://problem/29870033>
6
7         Reviewed by Dean Jackson.
8
9         Temporarily turn preferLowPowerWebGLRendering setting on by default until
10         we deal better with WebGL content in background tabs.
11
12         * WebView/WebPreferences.mm:
13         (+[WebPreferences initialize]):
14
15 2017-01-05  Enrica Casucci  <enrica@apple.com>
16
17         Support File Promise during drag for macOS.
18         https://bugs.webkit.org/show_bug.cgi?id=165204
19         rdar://problem/19595567
20
21         Reviewed by Tim Horton.
22
23         Adds support for dropping a File Promise in a WebView.
24         The implementation uses new File Promise API available in Sierra.
25
26         * Misc/WebNSPasteboardExtras.mm:
27         (+[NSPasteboard _web_dragTypesForURL]):
28         * WebView/WebView.mm:
29         (-[WebView performDragOperation:]):
30
31 2017-01-05  Andreas Kling  <akling@apple.com>
32
33         Remove ChromeClient::needTouchEvents().
34         <https://webkit.org/b/166723>
35
36         Rubber-stamped by Antti Koivisto.
37
38         * WebCoreSupport/WebChromeClient.h:
39
40 2017-01-04  Darin Adler  <darin@apple.com>
41
42         Remove PassRefPtr use from the "html" directory, other improvements
43         https://bugs.webkit.org/show_bug.cgi?id=166635
44
45         Reviewed by Alex Christensen.
46
47         * WebCoreSupport/WebChromeClient.h:
48         * WebCoreSupport/WebChromeClient.mm:
49         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
50
51 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
52
53         Unreviewed, rolling out r210287.
54
55         This change caused editing test failures on macOS.
56
57         Reverted changeset:
58
59         "Support File Promise during drag for macOS."
60         https://bugs.webkit.org/show_bug.cgi?id=165204
61         http://trac.webkit.org/changeset/210287
62
63 2017-01-04  Enrica Casucci  <enrica@apple.com>
64
65         Support File Promise during drag for macOS.
66         https://bugs.webkit.org/show_bug.cgi?id=165204
67         rdar://problem/19595567
68
69         Reviewed by Tim Horton.
70
71         Adds support for dropping a File Promise in a WebView.
72         The implementation uses new File Promise API available in Sierra.
73
74         * Misc/WebNSPasteboardExtras.mm:
75         (+[NSPasteboard _web_dragTypesForURL]):
76         * WebView/WebView.mm:
77         (-[WebView performDragOperation:]):
78
79 2017-01-04  Tim Horton  <timothy_horton@apple.com>
80
81         Provide a setting for clients to always prefer low-power WebGL
82         https://bugs.webkit.org/show_bug.cgi?id=166675
83         <rdar://problem/29834093>
84
85         Reviewed by Dan Bernstein.
86
87         * WebView/WebPreferenceKeysPrivate.h:
88         * WebView/WebPreferences.mm:
89         (+[WebPreferences initialize]):
90         (-[WebPreferences preferLowPowerWebGLRendering]):
91         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
92         * WebView/WebPreferencesPrivate.h:
93         * WebView/WebView.mm:
94         (-[WebView _preferencesChanged:]):
95         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
96
97 2017-01-03  Tim Horton  <timothy_horton@apple.com>
98
99         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
100         https://bugs.webkit.org/show_bug.cgi?id=166450
101         <rdar://problem/29447824>
102
103         Reviewed by Darin Adler.
104
105         * WebCoreSupport/CorrectionPanel.h:
106         * WebCoreSupport/CorrectionPanel.mm:
107         (CorrectionPanel::recordAutocorrectionResponse):
108         (CorrectionPanel::handleAcceptedReplacement):
109         * WebCoreSupport/WebAlternativeTextClient.mm:
110         (toCorrectionResponse):
111         (WebAlternativeTextClient::recordAutocorrectionResponse):
112         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
113         through recordAutocorrectionResponse, for debugging's sake.
114         Drop the NSView parameter because we don't need it, just the tag.
115         Convert the new AutocorrectionResponseType value to its corresponding
116         NSCorrectionResponse value.
117
118 2017-01-01  Jeff Miller  <jeffm@apple.com>
119
120         Update user-visible copyright strings to include 2017
121         https://bugs.webkit.org/show_bug.cgi?id=166278
122
123         Reviewed by Dan Bernstein.
124
125         * Info.plist:
126
127 2016-12-30  Darin Adler  <darin@apple.com>
128
129         Remove PassRefPtr use from the "dom" directory, related cleanup
130         https://bugs.webkit.org/show_bug.cgi?id=166569
131
132         Reviewed by Alex Christensen.
133
134         * WebCoreSupport/WebFrameLoaderClient.mm:
135         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
136         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
137         (WebFrameLoaderClient::setTitle): Ditto.
138         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
139         * WebView/WebFrame.mm:
140         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
141         Not needed now, but useful later if we ever can get rid of the explicit constructors.
142         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
143         * WebView/WebHTMLRepresentation.mm:
144         (-[WebHTMLRepresentation title]): Updated to use struct.
145
146 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
147
148         Propagate the source origin as much as possible
149         https://bugs.webkit.org/show_bug.cgi?id=166348
150
151         Reviewed by Darin Adler.
152
153         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
154         (WebKit::NetscapePluginInstanceProxy::evaluate):
155
156 2016-12-23  Andy Estes  <aestes@apple.com>
157
158         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
159         https://bugs.webkit.org/show_bug.cgi?id=166471
160
161         Reviewed by Andreas Kling.
162
163         When DumpRenderTree starts up, it calls
164         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
165         builds, this triggers the ASSERT(isMainThread()) in
166         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
167         started, we are on the main thread, and we are not holding the Web thread lock. This is
168         causing all layout tests to crash in the iOS WK1 Debug configuration.
169
170         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
171         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
172
173 2016-12-22  Andy Estes  <aestes@apple.com>
174
175         Make WebCore::EditorInsertAction an enum class
176         https://bugs.webkit.org/show_bug.cgi?id=166424
177
178         Reviewed by Brent Fulgham.
179
180         * WebCoreSupport/WebEditorClient.mm:
181         (kit):
182
183 2016-12-21  Beth Dakin  <bdakin@apple.com>
184
185         Holding down on candidates in the TouchBar should show panel on screen
186         https://bugs.webkit.org/show_bug.cgi?id=166367
187         -and corresponding-
188         <rdar://problem/28479236>
189
190         Reviewed by Tim Horton.
191
192         Stray whitespace.
193         * WebCoreSupport/WebEditorClient.mm:
194         (WebEditorClient::handleRequestedCandidates):
195
196         Call the version of setCandidates: that takes a rect. We need to keep the helper 
197         function in WK1 (unlike WK2) since we also use it for testing.
198         * WebView/WebView.mm:
199         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
200
201 2016-12-20  Dean Jackson  <dino@apple.com>
202
203         Remove INDIE_UI
204         https://bugs.webkit.org/show_bug.cgi?id=165881
205         <rdar://problem/29672532>
206
207         Reviewed by Simon Fraser.
208
209         The Indie UI work has been discontinued.
210
211         * Configurations/FeatureDefines.xcconfig:
212
213 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
214
215         [ES6] Enable ES6 Modules
216         https://bugs.webkit.org/show_bug.cgi?id=165849
217
218         Reviewed by Geoffrey Garen.
219
220         * WebView/WebPreferenceKeysPrivate.h:
221         * WebView/WebPreferences.mm:
222         (+[WebPreferences initialize]):
223         (-[WebPreferences es6ModulesEnabled]): Deleted.
224         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
225         * WebView/WebPreferencesPrivate.h:
226         * WebView/WebView.mm:
227         (-[WebView _preferencesChanged:]):
228
229 2016-12-16  Dave Hyatt  <hyatt@apple.com>
230
231         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
232         https://bugs.webkit.org/show_bug.cgi?id=165968
233
234         Reviewed by Andreas Kling.
235
236         * DOM/DOMCSS.mm:
237         (kitClass):
238         * DOM/DOMCSSPrimitiveValue.mm:
239         (-[DOMCSSPrimitiveValue getCounterValue]):
240         (-[DOMCSSPrimitiveValue getRectValue]):
241         (kit):
242         * DOM/DOMCSSPrimitiveValueInternal.h:
243         * DOM/DOMCSSStyleDeclaration.mm:
244         * DOM/DOMCSSValue.mm:
245         (kit):
246         * DOM/DOMCSSValueInternal.h:
247         * DOM/DOMCSSValueList.mm:
248         * DOM/DOMCounter.mm:
249         (kit):
250         * DOM/DOMCounterInternal.h:
251         * DOM/DOMRGBColor.mm:
252         (kit):
253         * DOM/DOMRGBColorInternal.h:
254         * DOM/DOMRect.mm:
255         (kit):
256         * DOM/DOMRectInternal.h:
257         * DOM/DOMUtility.mm:
258         (createDOMWrapper):
259
260 2016-12-16  Chris Dumez  <cdumez@apple.com>
261
262         HTML form validation bubble should be dismissed on navigation
263         https://bugs.webkit.org/show_bug.cgi?id=165960
264         <rdar://problem/29668086>
265
266         Reviewed by Simon Fraser.
267
268         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
269
270         * WebView/WebView.mm:
271         (-[WebView _didStartProvisionalLoadForFrame:]):
272
273 2016-12-15  Darin Adler  <darin@apple.com>
274
275         Use asString instead of toWTFString, toString, or getString when we already checked isString
276         https://bugs.webkit.org/show_bug.cgi?id=165895
277
278         Reviewed by Yusuke Suzuki.
279
280         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
281         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
282         toWTFString.
283         * WebView/WebView.mm:
284         (aeDescFromJSValue): Use asString/value instead of getString.
285
286 2016-12-15  Chris Dumez  <cdumez@apple.com>
287
288         Make sure HTML validation bubble's state is updated after layout
289         https://bugs.webkit.org/show_bug.cgi?id=165922
290         <rdar://problem/29694730>
291
292         Reviewed by Simon Fraser.
293
294         Make sure HTML validation bubble's state is updated after layout.
295         In particular, if the validation bubble's associated element has
296         moved or is no longer visible, we now hide the bubble.
297
298         * WebCoreSupport/WebValidationMessageClient.h:
299         * WebCoreSupport/WebValidationMessageClient.mm:
300         (WebValidationMessageClient::showValidationMessage):
301         (WebValidationMessageClient::hideValidationMessage):
302         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
303
304 2016-12-15  Chris Dumez  <cdumez@apple.com>
305
306         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
307         https://bugs.webkit.org/show_bug.cgi?id=165904
308
309         Reviewed by Sam Weinig.
310
311         Update ObjC bindings so they keep building.
312
313         * DOM/DOMUIEvent.mm:
314         (-[DOMUIEvent keyCode]):
315         (-[DOMUIEvent charCode]):
316
317 2016-12-15  Andreas Kling  <akling@apple.com>
318
319         Always clear RenderLayer backing stores when going into page cache.
320         <https://webkit.org/b/165901>
321
322         Reviewed by Simon Fraser.
323
324         * WebView/WebView.mm:
325         (+[WebView _setCacheModel:]):
326
327 2016-12-12  Alex Christensen  <achristensen@webkit.org>
328
329         Remove unused workaround for Silverlight
330         https://bugs.webkit.org/show_bug.cgi?id=165773
331
332         Reviewed by Dean Jackson.
333
334         * Plugins/WebNetscapePluginView.mm:
335         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
336         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
337         Allowing 6 years for users to update Silverlight is more than enough.
338         Safari doesn't even use WebKit1 for this any more.
339         I need this to be removed because this is the only non-WebGL code that needs to link against
340         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
341
342 2016-12-12  Chris Dumez  <cdumez@apple.com>
343
344         Document.visibilityState should use an IDL string enumeration
345         https://bugs.webkit.org/show_bug.cgi?id=165774
346
347         Reviewed by Daniel Bates.
348
349         * DOM/DOMDocument.mm:
350         (-[DOMDocument visibilityState]):
351         * WebView/WebView.mm:
352         (kit):
353
354 2016-12-12  Jer Noble  <jer.noble@apple.com>
355
356         Remove implementation of legacy Mozilla-based Fullscreen API.
357         https://bugs.webkit.org/show_bug.cgi?id=165689
358         <rdar://problem/29603053>
359
360         Reviewed by Eric Carlson.
361
362         * DOM/DOMElement.mm:
363         (-[DOMElement webkitRequestFullScreen:]):
364
365 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
366
367         The DOM should have an advancing wavefront opaque root barrier
368         https://bugs.webkit.org/show_bug.cgi?id=165712
369
370         Reviewed by Yusuke Suzuki.
371         
372         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
373
374         * Misc/WebCoreStatistics.mm:
375         (+[WebCoreStatistics javaScriptObjectsCount]):
376         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
377         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
378         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
379         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
380         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
381         (+[WebCoreStatistics shouldPrintExceptions]):
382         (+[WebCoreStatistics setShouldPrintExceptions:]):
383         (+[WebCoreStatistics memoryStatistics]):
384         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
385         * Plugins/Hosted/NetscapePluginHostProxy.mm:
386         (identifierFromIdentifierRep):
387         * Plugins/Hosted/ProxyInstance.mm:
388         (WebKit::ProxyInstance::getPropertyNames):
389         * Plugins/WebNetscapePluginStream.mm:
390         (WebNetscapePluginStream::wantsAllStreams):
391         * Plugins/WebNetscapePluginView.mm:
392         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
393         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
394         (-[WebNetscapePluginView setWindowIfNecessary]):
395         (-[WebNetscapePluginView createPluginScriptableObject]):
396         (-[WebNetscapePluginView getFormValue:]):
397         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
398         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
399         (-[WebNetscapePluginView loadPluginRequest:]):
400         (-[WebNetscapePluginView _printedPluginBitmap]):
401         * Plugins/WebPluginController.mm:
402         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
403         (-[WebPluginController stopOnePlugin:]):
404         (-[WebPluginController stopOnePluginForPageCache:]):
405         (-[WebPluginController destroyOnePlugin:]):
406         (-[WebPluginController startAllPlugins]):
407         (-[WebPluginController addPlugin:]):
408
409 2016-12-09  Dave Hyatt  <hyatt@apple.com>
410
411         [CSS Parser] Remove the old CSS Parser
412         https://bugs.webkit.org/show_bug.cgi?id=165645
413
414         Reviewed by Daniel Bates.
415
416         * DOM/DOMCSS.mm:
417         (kitClass):
418         * DOM/DOMCSSRule.h:
419
420 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
421
422         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
423         https://bugs.webkit.org/show_bug.cgi?id=165251
424
425         Reviewed by Dean Jackson.
426
427         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
428
429         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
430         * WebView/WebPreferences.mm:
431         (+[WebPreferences initialize]):
432         (-[WebPreferences mediaStreamEnabled]):
433         (-[WebPreferences setMediaStreamEnabled:]):
434         (-[WebPreferences peerConnectionEnabled]):
435         (-[WebPreferences setPeerConnectionEnabled:]):
436         * WebView/WebPreferencesPrivate.h:
437         * WebView/WebView.mm:
438         (-[WebView _preferencesChanged:]):
439
440 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
441
442         Don’t expose pointer lock in WebKit1 Objective-C API
443         https://bugs.webkit.org/show_bug.cgi?id=165692
444
445         Reviewed by Simon Fraser.
446
447         * DOM/DOMDocument.mm:
448         (-[DOMDocument pointerLockElement]): Deleted.
449         (-[DOMDocument exitPointerLock]): Deleted.
450         * DOM/DOMElement.mm:
451         (-[DOMElement requestPointerLock]): Deleted.
452         * DOM/DOMMouseEvent.mm:
453         (-[DOMMouseEvent movementX]): Deleted.
454         (-[DOMMouseEvent movementY]): Deleted.
455
456 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
457
458         document.webkitFullscreenElement leaks elements inside a shadow tree
459         https://bugs.webkit.org/show_bug.cgi?id=158471
460
461         Reviewed by Chris Dumez.
462
463         Use the API for bindings to avoid exposing nodes inside a shadow tree.
464
465         * DOM/DOMDocument.mm:
466         (-[DOMDocument webkitCurrentFullScreenElement]):
467         (-[DOMDocument webkitFullscreenElement]):
468
469 2016-12-09  Beth Dakin  <bdakin@apple.com>
470
471         Password fields should not show the emoji button in TouchBar
472         https://bugs.webkit.org/show_bug.cgi?id=165673
473         -and corresponding-
474         rdar://problem/29235739
475
476         Reviewed by Wenson Hsieh.
477
478         This patch adds a new ivar for the password touch bar and password 
479         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
480         of identifiers than the plain text TouchBar, it should just have its own variable.
481
482         The candidate list should be the only item for passwords.
483         * WebView/WebView.mm:
484         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
485
486         Account for _passwordTextTouchBar.
487         (-[WebView didChangeAutomaticTextCompletion:]):
488         (-[WebView setUpTextTouchBar:]):
489         (-[WebView textTouchBar]):
490
491         The empty candidates array is not needed. We can just set @[ ] as the candidates 
492         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
493         other parts of the code to prevent us from requesting or setting other candidates 
494         when in a password field. 
495         (-[WebView updateTextTouchBar]):
496
497         Account for _passwordTextTouchBar.
498         (-[WebView candidateList]):
499         * WebView/WebViewData.h:
500
501 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
502
503         Enable SharedArrayBuffer, remove the flag
504         https://bugs.webkit.org/show_bug.cgi?id=165614
505
506         Rubber stamped by Geoffrey Garen.
507
508         * WebView/WebPreferencesPrivate.h:
509
510 2016-12-07  Dean Jackson  <dino@apple.com>
511
512         Remove runtime toggle for pointer-lock
513         https://bugs.webkit.org/show_bug.cgi?id=165577
514         <rdar://problems/29566996>
515
516         Reviewed by Jon Lee.
517
518         Remove any runtime calls to check if pointer-lock is enabled. It's
519         either compiled in or out.
520
521         * WebView/WebPreferenceKeysPrivate.h:
522         * WebView/WebPreferences.mm:
523         (-[WebPreferences pointerLockEnabled]): Deleted.
524         (-[WebPreferences setPointerLockEnabled:]): Deleted.
525         * WebView/WebPreferencesPrivate.h:
526         * WebView/WebView.mm:
527         (-[WebView _preferencesChanged:]):
528
529 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
530
531         Correct SDKROOT values in xcconfig files
532         https://bugs.webkit.org/show_bug.cgi?id=165487
533         rdar://problem/29539209
534
535         Reviewed by Dan Bernstein.
536
537         Fix suggested by Dan Bernstein.
538
539         * Configurations/DebugRelease.xcconfig:
540
541 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
542
543         Improve the behavior of scroll-into-view when the target is inside position:fixed
544         https://bugs.webkit.org/show_bug.cgi?id=165354
545
546         Reviewed by Zalan Bujtas.
547
548         Plumb through 'insideFixed'. We don't get compute it, so behavior from
549         these call sites won't change.
550
551         * WebView/WebFrame.mm:
552         (-[WebFrame _scrollDOMRangeToVisible:]):
553         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
554
555 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
556
557         Enable visual viewports by default on Mac, and iOS Wk2
558         https://bugs.webkit.org/show_bug.cgi?id=165452
559
560         Reviewed by Zalan Bujtas.
561
562         Turn visual viewports on by default for WK1 on Mac.
563
564         * WebView/WebPreferences.mm:
565         (+[WebPreferences initialize]):
566
567 2016-12-05  Dean Jackson  <dino@apple.com>
568
569         pointer lock needs to be feature detectable
570         https://bugs.webkit.org/show_bug.cgi?id=165426
571         <rdar://problem/29486715>
572
573         Reviewed by Antoine Quint.
574
575         Set the RuntimeEnabledFeature as preferences
576         change.
577
578         * WebView/WebView.mm:
579         (-[WebView _preferencesChanged:]):
580
581 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
582
583         Unreviewed, rolling out r209299.
584
585         This change appears to have caused LayoutTest failures on
586         Sierra WK1.
587
588         Reverted changeset:
589
590         "Improve the behavior of scroll-into-view when the target is
591         inside position:fixed"
592         https://bugs.webkit.org/show_bug.cgi?id=165354
593         http://trac.webkit.org/changeset/209299
594
595 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
596
597         Improve the behavior of scroll-into-view when the target is inside position:fixed
598         https://bugs.webkit.org/show_bug.cgi?id=165354
599
600         Reviewed by Zalan Bujtas.
601
602         Plumb through 'insideFixed'. We don't get compute it, so behavior from
603         these call sites won't change.
604
605         * WebView/WebFrame.mm:
606         (-[WebFrame _scrollDOMRangeToVisible:]):
607         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
608
609 2016-12-02  Andy Estes  <aestes@apple.com>
610
611         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
612         https://bugs.webkit.org/show_bug.cgi?id=164492
613
614         Reviewed by Dan Bernstein.
615
616         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
617         com.apple.$(PRODUCT_NAME:rfc1034identifier).
618         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
619         ${PRODUCT_BUNDLE_IDENTIFIER}.
620
621 2016-12-02  Chris Dumez  <cdumez@apple.com>
622
623         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
624         https://bugs.webkit.org/show_bug.cgi?id=165328
625
626         Reviewed by Simon Fraser.
627
628         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
629
630         * WebView/WebViewData.mm:
631         (-[WebViewPrivate init]):
632
633 2016-12-02  Chris Dumez  <cdumez@apple.com>
634
635         [Mac][WK1] Implement new HTML interactive form validation user interface
636         https://bugs.webkit.org/show_bug.cgi?id=164483
637
638         Reviewed by Simon Fraser.
639
640         Implement new HTML interactive form validation user interface on Mac
641         WK1 and enable it by default.
642
643         * WebCoreSupport/WebValidationMessageClient.h: Added.
644         * WebCoreSupport/WebValidationMessageClient.mm: Added.
645         (WebValidationMessageClient::WebValidationMessageClient):
646         (WebValidationMessageClient::~WebValidationMessageClient):
647         (WebValidationMessageClient::showValidationMessage):
648         (WebValidationMessageClient::hideValidationMessage):
649         (WebValidationMessageClient::isValidationMessageVisible):
650         * WebView/WebHTMLView.mm:
651         (-[WebHTMLView _frameOrBoundsChanged]):
652         * WebView/WebView.mm:
653         (-[WebView _commonInitializationWithFrameName:groupName:]):
654         (-[WebView _willStartScrollingOrZooming]):
655         (-[WebView _contentsOfUserInterfaceItem:]):
656         (-[WebView _scaleWebView:atOrigin:]):
657         (-[WebView _didScrollDocumentInFrameView:]):
658         (-[WebView _setZoomMultiplier:isTextOnly:]):
659         (-[WebView showFormValidationMessage:withAnchorRect:]):
660         (-[WebView hideFormValidationMessage]):
661         * WebView/WebViewData.h:
662         * WebView/WebViewData.mm:
663         (-[WebViewPrivate init]):
664         * WebView/WebViewInternal.h:
665         * WebView/WebViewPrivate.h:
666
667 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
668
669         Add a runtime flag for SubtleCrypto
670         https://bugs.webkit.org/show_bug.cgi?id=164982
671
672         Reviewed by Brent Fulgham.
673
674         * WebView/WebPreferenceKeysPrivate.h:
675         * WebView/WebPreferences.mm:
676         (+[WebPreferences initialize]):
677         (-[WebPreferences subtleCryptoEnabled]):
678         (-[WebPreferences setSubtleCryptoEnabled:]):
679         * WebView/WebPreferencesPrivate.h:
680         * WebView/WebView.mm:
681         (-[WebView _preferencesChanged:]):
682
683 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
684
685         Add separate settings and preferences to enable/disable async decoding for large images and animated images
686         https://bugs.webkit.org/show_bug.cgi?id=165177
687
688         Reviewed by Simon Fraser.
689         
690         Hook up the async image decoding settings for WebKit1.
691
692         * WebView/WebPreferenceKeysPrivate.h:
693         * WebView/WebPreferences.mm:
694         (+[WebPreferences initialize]):
695         (-[WebPreferences largeImageAsyncDecodingEnabled]):
696         (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
697         (-[WebPreferences animatedImageAsyncDecodingEnabled]):
698         (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
699         (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
700         (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
701         * WebView/WebPreferencesPrivate.h:
702         * WebView/WebView.mm:
703         (-[WebView _preferencesChanged:]):
704
705 2016-11-29  Andy Estes  <aestes@apple.com>
706
707         [Cocoa] Enable two clang warnings recommended by Xcode
708         https://bugs.webkit.org/show_bug.cgi?id=164498
709
710         Reviewed by Mark Lam.
711
712         * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
713
714 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
715
716         [WTF] Import std::optional reference implementation as WTF::Optional
717         https://bugs.webkit.org/show_bug.cgi?id=164199
718
719         Reviewed by Saam Barati and Sam Weinig.
720
721         Use WTF::Optional::value_or.
722
723         * DOM/DOMHTMLOptionsCollection.mm:
724         (-[DOMHTMLOptionsCollection add:index:]):
725         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
726         (WebKit::NetscapePluginInstanceProxy::evaluate):
727         * Plugins/WebNetscapePluginView.mm:
728         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
729         * WebCoreSupport/WebFrameLoaderClient.h:
730         * WebCoreSupport/WebFrameLoaderClient.mm:
731         (WebFrameLoaderClient::dispatchDidCommitLoad):
732         * WebCoreSupport/WebPaymentCoordinatorClient.h:
733         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
734         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
735         (WebPaymentCoordinatorClient::completeShippingContactSelection):
736         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
737         * WebCoreSupport/WebSecurityOrigin.mm:
738         (-[WebSecurityOrigin port]):
739         * WebView/WebHTMLView.mm:
740         (toAction):
741         (toTag):
742
743 2016-11-26  Sam Weinig  <sam@webkit.org>
744
745         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
746         https://bugs.webkit.org/show_bug.cgi?id=164965
747
748         Reviewed by Simon Fraser.
749
750         * WebView/WebPreferenceKeysPrivate.h:
751         * WebView/WebPreferences.mm:
752         (-[WebPreferences intersectionObserverEnabled]):
753         (-[WebPreferences setIntersectionObserverEnabled:]):
754         * WebView/WebPreferencesPrivate.h:
755         * WebView/WebView.mm:
756         (-[WebView _preferencesChanged:]):
757         Add a preference, defaulting to off, for enabling IntersectionObserver.
758
759 2016-11-22  Dan Bernstein  <mitz@apple.com>
760
761         [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
762         https://bugs.webkit.org/show_bug.cgi?id=165036
763         <rdar://problem/5708580>
764
765         Reviewed by Alexey Proskuryakov.
766
767         * WebView/WebHTMLView.mm:
768         (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
769           similarly to what we do in -keyDown: and to what WKWebView does with all key events.
770
771 2016-11-21  Alex Christensen  <achristensen@webkit.org>
772
773         Fix Sierra CMake build after r208452
774         https://bugs.webkit.org/show_bug.cgi?id=164437
775
776         * WebView/WebView.mm:
777         (-[WebView updateMediaTouchBar]):
778         I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
779         It's needed for playbackSessionInterface to exist.
780
781 2016-11-18  Enrica Casucci  <enrica@apple.com>
782
783         Refactor drag and drop for WebKit2 to encode DragData message exchange.
784         https://bugs.webkit.org/show_bug.cgi?id=164945
785
786         Reviewed by Tim Horton.
787
788         * WebCoreSupport/WebDragClient.h:
789         * WebCoreSupport/WebDragClient.mm:
790         (WebDragClient::actionMaskForDrag):
791         (WebDragClient::willPerformDragDestinationAction):
792
793 2016-11-18  Jeremy Jones  <jeremyj@apple.com>
794
795         Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
796         https://bugs.webkit.org/show_bug.cgi?id=163801
797
798         Reviewed by Simon Fraser.
799
800         Plumb through PointerLockEnabled setting.
801
802         * Configurations/FeatureDefines.xcconfig:
803         * WebCoreSupport/WebChromeClient.mm:
804         (WebChromeClient::requestPointerUnlock):
805         * WebView/WebPreferenceKeysPrivate.h:
806         * WebView/WebPreferences.mm:
807         (-[WebPreferences pointerLockEnabled]):
808         (-[WebPreferences setPointerLockEnabled:]):
809         * WebView/WebPreferencesPrivate.h:
810         * WebView/WebView.mm:
811         (-[WebView _preferencesChanged:]):
812
813 2016-11-17  Dan Bernstein  <mitz@apple.com>
814
815         Try to fix some non-macOS builds.
816
817         * WebView/WebView.mm:
818
819 2016-11-16  Dave Hyatt  <hyatt@apple.com>
820
821         [CSS Parser] Add @supports, @keyframe and media query parsing options
822         https://bugs.webkit.org/show_bug.cgi?id=164821
823
824         Reviewed by Sam Weinig and Zalan Bujtas.
825
826         Fix up the create call now that fallback descriptor syntax is gone.
827
828         * DOM/DOM.mm:
829         (-[DOMHTMLLinkElement _mediaQueryMatches]):
830
831 2016-11-17  Saam Barati  <sbarati@apple.com>
832
833         Remove async/await compile time flag and enable tests
834         https://bugs.webkit.org/show_bug.cgi?id=164828
835         <rdar://problem/28639334>
836
837         Reviewed by Yusuke Suzuki.
838
839         * Configurations/FeatureDefines.xcconfig:
840
841 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
842
843         [JSC] WTF::TemporaryChange with WTF::SetForScope
844         https://bugs.webkit.org/show_bug.cgi?id=164761
845
846         Reviewed by Saam Barati.
847
848         * WebView/WebView.mm:
849         (-[WebView updateTextTouchBar]):
850
851 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
852
853         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
854         https://bugs.webkit.org/show_bug.cgi?id=164827
855
856         Reviewed by Ryosuke Niwa.
857
858         * Configurations/FeatureDefines.xcconfig:
859         * WebView/WebPreferenceKeysPrivate.h:
860         * WebView/WebPreferences.mm:
861         (+[WebPreferences initialize]):
862         (-[WebPreferences es6ModulesEnabled]):
863         (-[WebPreferences setES6ModulesEnabled:]):
864         * WebView/WebPreferencesPrivate.h:
865         * WebView/WebView.mm:
866         (-[WebView _preferencesChanged:]):
867
868 2016-11-14  Alex Christensen  <achristensen@webkit.org>
869
870         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
871         https://bugs.webkit.org/show_bug.cgi?id=164720
872
873         Reviewed by Brady Eidson.
874
875         * Storage/WebDatabaseManager.mm:
876         (-[WebDatabaseManager origins]):
877         (-[WebDatabaseManager databasesWithOrigin:]):
878         (-[WebDatabaseManager deleteOrigin:]):
879         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
880         * Storage/WebDatabaseManagerClient.h:
881         * Storage/WebDatabaseManagerClient.mm:
882         (DidModifyOriginData::dispatchToMainThread):
883         (DidModifyOriginData::DidModifyOriginData):
884         (WebDatabaseManagerClient::dispatchDidModifyOrigin):
885         (WebDatabaseManagerClient::dispatchDidModifyDatabase):
886         * Storage/WebDatabaseQuotaManager.mm:
887         (-[WebDatabaseQuotaManager usage]):
888         (-[WebDatabaseQuotaManager quota]):
889         (-[WebDatabaseQuotaManager setQuota:]):
890         * Storage/WebStorageManager.mm:
891         (-[WebStorageManager origins]):
892         (-[WebStorageManager deleteOrigin:]):
893         * Storage/WebStorageTrackerClient.h:
894         * Storage/WebStorageTrackerClient.mm:
895         (WebStorageTrackerClient::dispatchDidModifyOrigin):
896         * WebCoreSupport/WebSecurityOrigin.mm:
897         (-[WebSecurityOrigin usage]):
898         (-[WebSecurityOrigin quota]):
899         (-[WebSecurityOrigin setQuota:]):
900
901 2016-11-13  Darin Adler  <darin@apple.com>
902
903         Fix exception handling in SQL database code, streamline and update code
904         https://bugs.webkit.org/show_bug.cgi?id=164685
905
906         Reviewed by Sam Weinig.
907
908         * Storage/WebDatabaseManager.mm:
909         (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
910         a reference.
911         (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
912         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
913         but continue to use DatabaseManager.
914         (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
915         reference.
916         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
917
918         * Storage/WebDatabaseManagerClient.h: Updated to take references.
919         * Storage/WebDatabaseManagerClient.mm:
920         (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
921         members in the class definition.
922         (DidModifyOriginData::dispatchToMainThread): Take references.
923         (DidModifyOriginData::DidModifyOriginData): Ditto.
924         (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
925         (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
926         (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
927         DatabaseTracker::singleton instead of tracker.
928
929         * Storage/WebDatabaseQuotaManager.mm:
930         (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
931         (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
932         (-[WebDatabaseQuotaManager quota]): Ditto.
933         (-[WebDatabaseQuotaManager setQuota:]): Ditto.
934         * WebCoreSupport/WebSecurityOrigin.mm:
935         (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
936         (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
937         (-[WebSecurityOrigin quota]): Ditto.
938         (-[WebSecurityOrigin setQuota:]): Ditto.
939         * WebView/WebFrame.mm:
940         (-[WebFrame _cacheabilityDictionary]): Pass a reference.
941
942 2016-11-12  Darin Adler  <darin@apple.com>
943
944         Remove a few assorted uses of ExceptionCode
945         https://bugs.webkit.org/show_bug.cgi?id=164683
946
947         Reviewed by Chris Dumez.
948
949         * DOM/DOMDOMImplementation.mm:
950         (-[DOMImplementation createDocumentType:publicId:systemId:]):
951         Use raiseOnDOMError instead of much longer hand written equivalent.
952         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
953
954         * DOM/DOMDocument.mm:
955         (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
956         so we are not using a specific exception code.
957
958         * DOM/DOMHTMLOptionsCollection.mm:
959         (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
960         much longer hand written equivalent.
961         * DOM/DOMHTMLSelectElement.mm:
962         (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
963         statement after calling a "no return" function.
964
965         * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
966         raiseOnDOMError functions that take ExceptionCode; keep the ones that take
967         Exception and ExceptionOr. Renamed the other overload of raiseDOMException
968         to raiseDOMErrorException; it is only used as the non-inline implementation
969         part of the inline raiseOnDOMError function.
970         * DOM/ExceptionHandlers.mm:
971         (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
972         to this source file instead of in the header.
973         (raiseTypeErrorException): Updated for name change.
974         (raiseNotSupportedErrorException): Added.
975
976 2016-11-11  Ryosuke Niwa  <rniwa@webkit.org>
977
978         Hovering over a slotted Text node clears hover state
979         https://bugs.webkit.org/show_bug.cgi?id=164002
980         <rdar://problem/29040471>
981
982         Reviewed by Simon Fraser.
983
984         * WebView/WebImmediateActionController.mm:
985         (-[WebImmediateActionController performHitTestAtPoint:]):
986
987 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
988
989         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
990         https://bugs.webkit.org/show_bug.cgi?id=164538
991         <rdar://problem/8418711>
992
993         Reviewed by Ryosuke Niwa.
994
995         Account for renaming HTMLElement::autocorrect to HTMLElement::shouldAutocorrect, as well as moving
996         WebAutocapitalizeType to WebKit from WebCore. Additionally, moves the -autocorrect and -autocapitalize SPIs out
997         of HTML(Input|Form|TextArea)ElementPrivate.h and into HTMLElementPrivate.h. This also means removing redundant
998         code for interfacing with the unwrapped HTMLElement's autocorrect and autocapitalize attributes.
999
1000         * DOM/DOMHTML.mm:
1001         (webAutocapitalizeType):
1002         (-[DOMHTMLInputElement _autocapitalizeType]):
1003         (-[DOMHTMLTextAreaElement _autocapitalizeType]):
1004         * DOM/DOMHTMLElement.mm:
1005         (-[DOMHTMLElement autocorrect]):
1006         (-[DOMHTMLElement setAutocorrect:]):
1007         (-[DOMHTMLElement autocapitalize]):
1008         (-[DOMHTMLElement setAutocapitalize:]):
1009         * DOM/DOMHTMLElementPrivate.h: Copied from Source/WebCore/html/Autocapitalize.h.
1010         * DOM/DOMHTMLFormElement.mm:
1011         (-[DOMHTMLFormElement autocorrect]): Deleted.
1012         (-[DOMHTMLFormElement setAutocorrect:]): Deleted.
1013         (-[DOMHTMLFormElement autocapitalize]): Deleted.
1014         (-[DOMHTMLFormElement setAutocapitalize:]): Deleted.
1015         * DOM/DOMHTMLInputElement.mm:
1016         (-[DOMHTMLInputElement autocorrect]): Deleted.
1017         (-[DOMHTMLInputElement setAutocorrect:]): Deleted.
1018         (-[DOMHTMLInputElement autocapitalize]): Deleted.
1019         (-[DOMHTMLInputElement setAutocapitalize:]): Deleted.
1020         * DOM/DOMHTMLInputElementPrivate.h:
1021         * DOM/DOMHTMLTextAreaElement.mm:
1022         (-[DOMHTMLTextAreaElement autocorrect]): Deleted.
1023         (-[DOMHTMLTextAreaElement setAutocorrect:]): Deleted.
1024         (-[DOMHTMLTextAreaElement autocapitalize]): Deleted.
1025         (-[DOMHTMLTextAreaElement setAutocapitalize:]): Deleted.
1026         * DOM/DOMHTMLTextAreaElementPrivate.h:
1027
1028         We need to import DOMHTMLElementPrivate.h here to avoid breaking UIKit. We should follow this up with a UIKit
1029         change to import DOMHTMLElementPrivate.h directly.
1030
1031         * DOM/DOMPrivate.h:
1032         * DOM/WebAutocapitalizeTypes.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h.
1033         * MigrateHeaders.make:
1034
1035 2016-11-11  Beth Dakin  <bdakin@apple.com>
1036
1037         Move to modern TouchBar methods
1038         https://bugs.webkit.org/show_bug.cgi?id=164655
1039         -and corresponding-
1040         rdar://problem/29226911
1041
1042         Reviewed by Wenson Hsieh.
1043
1044         customizationDefaultItemIdentifiers -> defaultItemIdentifiers
1045         itemIdentifiers -> defaultItemIdentifiers
1046         defaultItems -> templateItems
1047
1048         * WebView/WebView.mm:
1049         (-[WebView _plainTextTouchBarDefaultItemIdentifiers]):
1050         (-[WebView _richTextTouchBarDefaultItemIdentifiers]):
1051         (-[WebView setUpTextTouchBar:]):
1052         (-[WebView updateTextTouchBar]):
1053         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1054         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1055
1056 2016-11-11  Darin Adler  <darin@apple.com>
1057
1058         Move Node from ExceptionCode to ExceptionOr
1059         https://bugs.webkit.org/show_bug.cgi?id=164515
1060
1061         Reviewed by Sam Weinig.
1062
1063         * DOM/DOMHTMLSelectElement.mm:
1064         (-[DOMHTMLSelectElement remove:]): Call remove instead of removeByIndex
1065         now that it was renamed.
1066         * DOM/DOMNode.mm:
1067         (-[DOMNode setNodeValue:]): Updated exception handling.
1068         (-[DOMNode setPrefix:]): Ditto.
1069         (-[DOMNode setTextContent:]): Ditto.
1070         (-[DOMNode insertBefore:refChild:]): Ditto.
1071         (-[DOMNode replaceChild:oldChild:]): Ditto.
1072         (-[DOMNode removeChild:]): Ditto.
1073         (-[DOMNode appendChild:]): Ditto.
1074         (-[DOMNode cloneNode:]): Ditto.
1075
1076 2016-11-11  Beth Dakin  <bdakin@apple.com>
1077
1078         Get touch bar code building for open source builds
1079         https://bugs.webkit.org/show_bug.cgi?id=164610
1080
1081         Reviewed by Wenson Hsieh.
1082
1083         * WebKitPrefix.h:
1084
1085 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1086
1087         Fix assertion after r208534.
1088         https://bugs.webkit.org/show_bug.cgi?id=160497
1089
1090         * WebView/WebView.mm:
1091         (-[WebView _commonInitializationWithFrameName:groupName:]):
1092         (WebInstallMemoryPressureHandler):
1093         WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
1094         When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
1095         only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
1096
1097 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1098
1099         Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
1100         https://bugs.webkit.org/show_bug.cgi?id=164573
1101
1102         Reviewed by Brady Eidson.
1103
1104         * WebCoreSupport/WebSecurityOrigin.mm:
1105         (-[WebSecurityOrigin databaseIdentifier]):
1106
1107 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1108
1109         MemoryPressureHandler shouldn't know how to release WebCore memory
1110         https://bugs.webkit.org/show_bug.cgi?id=160497
1111
1112         Reviewed by Michael Catanzaro.
1113
1114         Set the low memory handler before installing the memory pressure handler.
1115
1116         * WebView/WebView.mm:
1117         (-[WebView _commonInitializationWithFrameName:groupName:]):
1118
1119 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
1120
1121         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
1122         https://bugs.webkit.org/show_bug.cgi?id=164501
1123         <rdar://problem/29152282>
1124
1125         Reviewed by Sam Weinig.
1126
1127         Align what [WebHTMLView attributedString] returns to what would be used on copy & paste by using HTMLConverter
1128         instead of _initWithDOMRange in [WebHTMLView _attributeStringFromDOMRange].
1129
1130         * WebView/WebHTMLView.mm:
1131         (-[WebHTMLView _attributedStringFromDOMRange:]): Renamed from _attributeStringFromDOMRange.
1132         (-[WebHTMLView attributedString]):
1133         (-[WebHTMLView selectedAttributedString]):
1134         (-[WebHTMLView selectedString]): Moved to reduce the number of occurrences of the if-defs.
1135
1136 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
1137
1138         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
1139         https://bugs.webkit.org/show_bug.cgi?id=155185
1140         <rdar://problem/11101440>
1141
1142         Reviewed by Brady Eidson.
1143
1144         Provide SPI to access the new quirk for localStorage. The quirk defaults to 'on'. When active, this
1145         quirk says that localStorage access should be granted, without needing to grant universal file access.
1146
1147         If the quirk is turned off, then localStorage is blocked unless the WebKit client explicitly
1148         grants universal file access.
1149
1150         * WebView/WebPreferenceKeysPrivate.h:
1151         * WebView/WebPreferences.mm:
1152         (-[WebPreferences needsLocalStorageQuirk]): Added.
1153         (-[WebPreferences setNeedsLocalStorageQuirk:]): Added.
1154         * WebView/WebPreferencesPrivate.h:
1155         * WebView/WebView.mm:
1156         (-[WebView _preferencesChanged:]): Honor the new localStorage quirk.
1157
1158 2016-11-09  Alex Christensen  <achristensen@webkit.org>
1159
1160         Clean up Storage code
1161         https://bugs.webkit.org/show_bug.cgi?id=164562
1162
1163         Reviewed by Brady Eidson.
1164
1165         * Storage/WebStorageManager.mm:
1166         (-[WebStorageManager origins]):
1167         (-[WebStorageManager deleteAllOrigins]):
1168         (-[WebStorageManager deleteOrigin:]):
1169         (-[WebStorageManager diskUsageForOrigin:]):
1170         (-[WebStorageManager syncLocalStorage]):
1171         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
1172         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
1173         (+[WebStorageManager closeIdleLocalStorageDatabases]):
1174         (WebKitInitializeStorageIfNecessary):
1175         * WebView/WebView.mm:
1176         (+[WebView _applicationWillTerminate]):
1177
1178 2016-11-09  Beth Dakin  <bdakin@apple.com>
1179
1180         Another attempted build fix.
1181
1182         * WebView/WebView.mm:
1183
1184 2016-11-09  Beth Dakin  <bdakin@apple.com>
1185
1186         Attempted build fix.
1187
1188         * WebView/WebView.mm:
1189
1190 2016-11-09  Darin Adler  <darin@apple.com>
1191
1192         Move Range from ExceptionCode to ExceptionOr
1193         https://bugs.webkit.org/show_bug.cgi?id=164457
1194
1195         Reviewed by Alex Christensen.
1196
1197         * DOM/DOMRange.mm:
1198         (-[DOMRange setStart:offset:]): Updated exception handling.
1199         (-[DOMRange setEnd:offset:]): Ditto.
1200         (-[DOMRange setStartBefore:]): Ditto.
1201         (-[DOMRange setStartAfter:]): Ditto.
1202         (-[DOMRange setEndBefore:]): Ditto.
1203         (-[DOMRange setEndAfter:]): Ditto.
1204         (-[DOMRange selectNode:]): Ditto.
1205         (-[DOMRange selectNodeContents:]): Ditto.
1206         (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
1207         (-[DOMRange deleteContents]): Ditto.
1208         (-[DOMRange extractContents]): Ditto.
1209         (-[DOMRange cloneContents]): Ditto.
1210         (-[DOMRange insertNode:]): Ditto.
1211         (-[DOMRange surroundContents:]): Ditto.
1212         (-[DOMRange createContextualFragment:]): Ditto.
1213         (-[DOMRange compareNode:]): Ditto.
1214         (-[DOMRange intersectsNode:]): Ditto.
1215         (-[DOMRange comparePoint:offset:]): Ditto.
1216         (-[DOMRange isPointInRange:offset:]): Ditto.
1217         (-[DOMRange expand:]): Ditto.
1218         * WebView/WebFrame.mm:
1219         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
1220         (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
1221         This function was incorrectly implemented (set both start and end of
1222         the range to the computed start), not declared in any header file,
1223         not used anywhere inside WebKit, and I also could not find a use of it
1224         in outside-WebKit Apple code.
1225         * mac/DOM/DOMUIKitExtensions.mm:
1226         (-[DOMRange move:inDirection:]): Ditto.
1227         (-[DOMRange extend:inDirection:]): Ditto.
1228
1229 2016-11-09  Darin Adler  <darin@apple.com>
1230
1231         Move EventTarget from ExceptionCode to ExceptionOr
1232         https://bugs.webkit.org/show_bug.cgi?id=164465
1233
1234         Reviewed by Youenn Fablet.
1235
1236         * DOM/DOMNode.mm:
1237         (-[DOMNode dispatchEvent:]): Updated exception handling.
1238
1239 2016-11-09  Chris Dumez  <cdumez@apple.com>
1240
1241         [Mac] Stop using deprecated AppKit enumeration values
1242         https://bugs.webkit.org/show_bug.cgi?id=164494
1243
1244         Reviewed by Darin Adler.
1245
1246         Stop using deprecated AppKit enumeration values.
1247
1248         * Carbon/CarbonWindowAdapter.mm:
1249         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1250         (-[CarbonWindowAdapter sendSuperEvent:]):
1251         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1252         (WebKit::NetscapePluginHostProxy::beginModal):
1253         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1254         (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
1255         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1256         (-[WebHostedNetscapePluginView drawRect:]):
1257         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1258         (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
1259         * WebCoreSupport/PopupMenuMac.mm:
1260         (PopupMenuMac::populate):
1261         (PopupMenuMac::show):
1262         * WebCoreSupport/WebContextMenuClient.mm:
1263         (WebContextMenuClient::showContextMenu):
1264         * WebCoreSupport/WebFrameLoaderClient.mm:
1265         (WebFrameLoaderClient::actionDictionary):
1266         * WebCoreSupport/WebInspectorClient.mm:
1267         (WebInspectorFrontendClient::canAttach):
1268         (-[WebInspectorWindowController window]):
1269         * WebInspector/WebNodeHighlight.mm:
1270         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1271         * WebView/WebFrameView.mm:
1272         (-[WebFrameView keyDown:keyDown:]):
1273         * WebView/WebFullScreenController.mm:
1274         (-[WebFullScreenController init]):
1275         (createBackgroundFullscreenWindow):
1276         * WebView/WebHTMLView.mm:
1277         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
1278         (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
1279         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1280         (isQuickLookEvent):
1281         (-[WebHTMLView hitTest:]):
1282         (-[WebHTMLView _sendToolTipMouseExited]):
1283         (-[WebHTMLView _sendToolTipMouseEntered]):
1284         (mouseEventIsPartOfClickOrDrag):
1285         (-[WebHTMLView _updateMouseoverWithEvent:]):
1286         (-[WebHTMLView _autoscroll]):
1287         (-[WebHTMLView acceptsFirstResponder]):
1288         (-[WebHTMLView viewDidMoveToWindow]):
1289         (-[WebHTMLView mouseDown:mouseDown:]):
1290         (currentKeyboardEvent):
1291         (-[WebHTMLView _handleStyleKeyEquivalent:]):
1292         (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
1293         * WebView/WebPDFView.mm:
1294         (-[WebPDFView hitTest:]):
1295         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1296         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
1297         * WebView/WebTextCompletionController.mm:
1298         (-[WebTextCompletionController _buildUI]):
1299         (-[WebTextCompletionController _placePopupWindow:]):
1300         * WebView/WebView.mm:
1301         (-[WebView applicationFlags:]):
1302
1303 2016-11-09  Beth Dakin  <bdakin@apple.com>
1304
1305         Support TouchBar in WebKit
1306         https://bugs.webkit.org/show_bug.cgi?id=164437
1307         -and corresponding-
1308         rdar://problem/28876524
1309
1310         Reviewed by Darin Adler.
1311
1312         * WebCoreSupport/WebEditorClient.mm:
1313         (WebEditorClient::respondToChangedSelection):
1314         (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
1315         * WebView/WebHTMLView.mm:
1316         (-[WebHTMLView candidateListTouchBarItem]):
1317         * WebView/WebView.mm:
1318         (-[_WebTextListTouchBarViewController initWithWebView:]):
1319         (-[_WebTextListTouchBarViewController _selectList:]):
1320         (-[_WebTextListTouchBarViewController setCurrentListType:]):
1321         (-[WebTextTouchBarItemController initWithWebView:]):
1322         (-[WebTextTouchBarItemController itemForIdentifier:]):
1323         (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
1324         (-[WebTextTouchBarItemController setTextIsBold:]):
1325         (-[WebTextTouchBarItemController setTextIsItalic:]):
1326         (-[WebTextTouchBarItemController setTextIsUnderlined:]):
1327         (-[WebTextTouchBarItemController _webChangeTextStyle:]):
1328         (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
1329         (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
1330         (-[WebTextTouchBarItemController textColor]):
1331         (-[WebTextTouchBarItemController setTextColor:]):
1332         (-[WebTextTouchBarItemController _webChangeColor:]):
1333         (-[WebTextTouchBarItemController textListViewController]):
1334         (-[WebView _commonInitializationWithFrameName:groupName:]):
1335         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1336         (-[WebView shouldRequestCandidates]):
1337         (-[WebView forceRequestCandidatesForTesting]):
1338         (-[WebView makeTouchBar]):
1339         (-[WebView touchBar:makeItemForIdentifier:]):
1340         (textCheckingResultFromNSTextCheckingResult):
1341         (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
1342         (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
1343         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1344         (-[WebView _clearPlaybackControlsManager]):
1345         (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
1346         (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
1347         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
1348         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
1349         (-[WebView touchBarDidExitCustomization:]):
1350         (-[WebView touchBarWillEnterCustomization:]):
1351         (-[WebView didChangeAutomaticTextCompletion:]):
1352         (-[WebView setUpTextTouchBar:]):
1353         (-[WebView _isRichlyEditable]):
1354         (-[WebView textTouchBar]):
1355         (-[WebView updateTextTouchBar]):
1356         (-[WebView updateMediaTouchBar]):
1357         (-[WebView updateTouchBar]):
1358         (-[WebView prepareForMouseDown]):
1359         (-[WebView prepareForMouseUp]):
1360         (-[WebView webViewAdditionsWillDestroyView]):
1361         (-[WebView candidateList]):
1362         (-[WebView updateWebViewAdditions]): Deleted.
1363         * WebView/WebViewData.h:
1364         * WebView/WebViewInternal.h:
1365         * WebView/WebViewPrivate.h:
1366
1367 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1368
1369         Safari does not emit composition end if blurred for dead key / Japanese IME
1370         https://bugs.webkit.org/show_bug.cgi?id=164369
1371         <rdar://problem/29050439>
1372
1373         Reviewed by Ryosuke Niwa.
1374
1375         When canceling a composition, make sure that we clear the system IME state.
1376
1377         * WebCoreSupport/WebEditorClient.h:
1378         * WebCoreSupport/WebEditorClient.mm:
1379         (WebEditorClient::canceledComposition):
1380
1381 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1382
1383         Add a setting and preferences to enable/disable async image decoding
1384         https://bugs.webkit.org/show_bug.cgi?id=164417
1385
1386         Reviewed by Simon Fraser.
1387
1388         Hook up the asyncImageDecodingEnabled setting for WebKit1.
1389
1390         * WebView/WebPreferenceKeysPrivate.h:
1391         * WebView/WebPreferences.mm:
1392         (+[WebPreferences initialize]):
1393         (-[WebPreferences asyncImageDecodingEnabled]):
1394         (-[WebPreferences setAsyncImageDecodingEnabled:]):
1395         * WebView/WebPreferencesPrivate.h:
1396         * WebView/WebView.mm:
1397         (-[WebView _preferencesChanged:]):
1398
1399 2016-11-01  Alex Christensen  <achristensen@webkit.org>
1400
1401         Remove PassRefPtr from DumpRenderTree
1402         https://bugs.webkit.org/show_bug.cgi?id=164307
1403
1404         Reviewed by Sam Weinig.
1405
1406         * WebView/WebGeolocationPosition.mm:
1407         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1408
1409 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1410
1411         [Readable Streams API] Enable creation of ReadableByteStreamController
1412         https://bugs.webkit.org/show_bug.cgi?id=164014
1413
1414         Reviewed by Youenn Fablet.
1415
1416         Added flag for the byte stream part of Readable Streams API.
1417
1418         * Configurations/FeatureDefines.xcconfig:
1419
1420 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
1421
1422         Remove CUSTOM_ELEMENTS build flag
1423         https://bugs.webkit.org/show_bug.cgi?id=164267
1424
1425         Reviewed by Antti Koivisto.
1426
1427         Removed the build flag.
1428
1429         * Configurations/FeatureDefines.xcconfig:
1430         * WebView/WebPreferences.mm:
1431         (+[WebPreferences initialize]):
1432         * WebView/WebView.mm:
1433         (-[WebView _preferencesChanged:]):
1434
1435 2016-11-01  Eric Carlson  <eric.carlson@apple.com>
1436
1437         [MediaStream] restrict media capture secure connections
1438         https://bugs.webkit.org/show_bug.cgi?id=164234
1439         <rdar://problem/28944906>
1440
1441         Reviewed by Alex Christensen.
1442
1443         * WebView/WebPreferenceKeysPrivate.h:
1444         * WebView/WebPreferences.mm:
1445         (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
1446         (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
1447         (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
1448         * WebView/WebPreferencesPrivate.h:
1449
1450         * WebView/WebView.mm:
1451         (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
1452
1453 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
1454
1455         JSC should support SharedArrayBuffer
1456         https://bugs.webkit.org/show_bug.cgi?id=163986
1457
1458         Reviewed by Keith Miller.
1459         
1460         Support the RuntimeFlag.
1461
1462         * WebView/WebPreferencesPrivate.h:
1463
1464 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1465
1466         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
1467         https://bugs.webkit.org/show_bug.cgi?id=164236
1468         <rdar://problem/28747712>
1469
1470         Reviewed by Beth Dakin.
1471
1472         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
1473         dictionary lookup.
1474
1475         * WebCoreSupport/WebEditorClient.mm:
1476         (WebEditorClient::respondToChangedSelection):
1477         * WebView/WebImmediateActionController.mm:
1478         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1479
1480 2016-10-31  Darin Adler  <darin@apple.com>
1481
1482         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
1483         https://bugs.webkit.org/show_bug.cgi?id=164214
1484
1485         Reviewed by Alex Christensen.
1486
1487         * DOM/DOMCSSPrimitiveValue.mm:
1488         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
1489         is a reference now.
1490         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
1491
1492         * DOM/DOMDocument.mm:
1493         (-[DOMDocument querySelector:]): Updated exception handling.
1494         (-[DOMDocument querySelectorAll:]): Ditto.
1495         * DOM/DOMDocumentFragment.mm:
1496         (-[DOMDocumentFragment querySelector:]): Ditto.
1497         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
1498         * DOM/DOMElement.mm:
1499         (-[DOMElement querySelector:]): Ditto.
1500         (-[DOMElement querySelectorAll:]): Ditto.
1501
1502 2016-10-31  Darin Adler  <darin@apple.com>
1503
1504         Convert Document from ExceptionCode to Exception
1505         https://bugs.webkit.org/show_bug.cgi?id=164212
1506
1507         Reviewed by Alex Christensen.
1508
1509         * DOM/DOMDocument.mm:
1510         (-[DOMDocument setXmlVersion:]): Updated exception handling.
1511         (-[DOMDocument cookie]): Ditto.
1512         (-[DOMDocument setCookie:]): Ditto.
1513         (-[DOMDocument setBody:]): Ditto.
1514         (-[DOMDocument createElement:]): Ditto.
1515         (-[DOMDocument createCDATASection:]): Ditto.
1516         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
1517         (-[DOMDocument createAttribute:]): Ditto.
1518         (-[DOMDocument createEntityReference:]): Ditto.
1519         (-[DOMDocument importNode:deep:]): Ditto.
1520         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
1521         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
1522         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
1523         (-[DOMDocument adoptNode:]): Ditto.
1524         (-[DOMDocument createEvent:]): Ditto.
1525
1526 2016-10-30  Darin Adler  <darin@apple.com>
1527
1528         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
1529         https://bugs.webkit.org/show_bug.cgi?id=164206
1530
1531         Reviewed by Chris Dumez.
1532
1533         * DOM/DOMElement.mm:
1534         (-[DOMElement setInnerHTML:]): Updated exception handling.
1535         (-[DOMElement setOuterHTML:]): Ditto.
1536         (-[DOMElement setAttribute:value:]): Ditto.
1537         (-[DOMElement setAttributeNode:]): Ditto.
1538         (-[DOMElement removeAttributeNode:]): Ditto.
1539         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
1540         (-[DOMElement setAttributeNodeNS:]): Ditto.
1541         (-[DOMElement matches:]): Ditto.
1542         (-[DOMElement closest:]): Ditto.
1543         (-[DOMElement webkitMatchesSelector:]): Ditto.
1544         * DOM/DOMHTMLElement.mm:
1545         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
1546         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
1547         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
1548         * DOM/DOMNamedNodeMap.mm:
1549         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
1550         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
1551         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
1552         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
1553
1554 2016-10-29  Darin Adler  <darin@apple.com>
1555
1556         Convert more of DOM from ExceptionCode to Exception
1557         https://bugs.webkit.org/show_bug.cgi?id=164173
1558
1559         Reviewed by Ryosuke Niwa.
1560
1561         * DOM/DOMCharacterData.mm:
1562         (-[DOMCharacterData substringData:length:]): Updated since this
1563         now uses ExceptionOr.
1564         (-[DOMCharacterData insertData:data:]): Ditto.
1565         (-[DOMCharacterData deleteData:length:]): Ditto.
1566         (-[DOMCharacterData replaceData:length:data:]): Ditto.
1567         * DOM/DOMText.mm:
1568         (-[DOMText splitText:]): Ditto.
1569         (-[DOMText replaceWholeText:]): Removed unneeded exception code
1570         handling from function that does not throw an exception.
1571
1572 2016-10-28  Darin Adler  <darin@apple.com>
1573
1574         Move all classes in the HTML directory from ExceptionCode to Exception
1575         https://bugs.webkit.org/show_bug.cgi?id=163876
1576
1577         Reviewed by Sam Weinig.
1578
1579         * DOM/DOMCharacterData.mm:
1580         (-[DOMCharacterData remove]): Updated exception handling.
1581         * DOM/DOMDOMTokenList.mm:
1582         (-[DOMDOMTokenList toggle:force:]): Ditto.
1583         * DOM/DOMDocumentType.mm:
1584         (-[DOMDocumentType remove]): Ditto.
1585         * DOM/DOMElement.mm:
1586         (-[DOMElement remove]): Ditto.
1587         * DOM/DOMHTML.mm:
1588         (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
1589         * DOM/DOMHTMLCanvasElement.mm:
1590         (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
1591         * DOM/DOMHTMLElement.mm:
1592         (-[DOMHTMLElement setInnerText:]): Ditto.
1593         (-[DOMHTMLElement setOuterText:]): Ditto.
1594         (-[DOMHTMLElement setContentEditable:]): Ditto.
1595         * DOM/DOMHTMLInputElement.mm:
1596         (-[DOMHTMLInputElement setMaxLength:]): Ditto.
1597         (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
1598         (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
1599         (-[DOMHTMLInputElement stepUp:]): Ditto.
1600         (-[DOMHTMLInputElement stepDown:]): Ditto.
1601         (-[DOMHTMLInputElement setRangeText:]): Ditto.
1602         (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
1603         * DOM/DOMHTMLMarqueeElement.mm:
1604         (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
1605         * DOM/DOMHTMLMediaElement.mm:
1606         (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
1607         (-[DOMHTMLMediaElement setVolume:]): Ditto.
1608         * DOM/DOMHTMLOptionsCollection.mm:
1609         (-[DOMHTMLOptionsCollection setLength:]): Ditto.
1610         * DOM/DOMHTMLTableElement.mm:
1611         (-[DOMHTMLTableElement setCaption:]): Ditto.
1612         (-[DOMHTMLTableElement setTHead:]): Ditto.
1613         (-[DOMHTMLTableElement setTFoot:]): Ditto.
1614         (-[DOMHTMLTableElement insertRow:]): Ditto.
1615         (-[DOMHTMLTableElement deleteRow:]): Ditto.
1616         * DOM/DOMHTMLTableRowElement.mm:
1617         (-[DOMHTMLTableRowElement insertCell:]): Ditto.
1618         (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
1619         * DOM/DOMHTMLTableSectionElement.mm:
1620         (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
1621         (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
1622         * DOM/DOMHTMLTextAreaElement.mm:
1623         (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
1624         (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
1625         (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
1626         * DOM/DOMHTMLVideoElement.mm:
1627         (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
1628         (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
1629         version (lowercase S) instead of repeating the logic from that method.
1630         (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
1631         * DOM/DOMTimeRanges.mm:
1632         (-[DOMTimeRanges start:]): Updated exception handling.
1633         (-[DOMTimeRanges end:]): Ditto.
1634
1635 2016-10-27  Chris Dumez  <cdumez@apple.com>
1636
1637         Regression(r203601): Caused crashes in iBooks
1638         https://bugs.webkit.org/show_bug.cgi?id=164093
1639         <rdar://problem/28745634>
1640
1641         Reviewed by Darin Adler.
1642
1643         Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
1644         which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
1645
1646         * DOM/DOMNode.mm:
1647         (-[DOMNode compareDocumentPosition:]):
1648
1649 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1650
1651         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
1652         https://bugs.webkit.org/show_bug.cgi?id=163948
1653         <rdar://problem/28921433>
1654
1655         Reviewed by Darin Adler.
1656
1657         Add support for new drag and drop-related EditAction enum values.
1658
1659         * WebCoreSupport/WebEditorClient.mm:
1660         (undoNameForEditAction):
1661
1662 2016-10-27  Dan Bernstein  <mitz@apple.com>
1663
1664         Reapplied the configuration changes from r207934 without breaking iOS builds.
1665
1666         * Configurations/Base.xcconfig:
1667         * Configurations/WebKitLegacy.xcconfig:
1668
1669 2016-10-27  Dan Bernstein  <mitz@apple.com>
1670
1671         Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
1672
1673         * Configurations/Base.xcconfig:
1674         * Configurations/WebKitLegacy.xcconfig:
1675
1676 2016-10-26  Dan Bernstein  <mitz@apple.com>
1677
1678         [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
1679         https://bugs.webkit.org/show_bug.cgi?id=164048
1680
1681         Reviewed by Tim Horton.
1682
1683         * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
1684         * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
1685           headers.
1686
1687         * History/WebBackForwardList.h: Fixed parameter name in @param entry.
1688         * Misc/WebDownload.h: Removed empty entries.
1689         * Misc/WebIconDatabase.h: Remove incorrect @param entries.
1690         * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
1691         * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
1692         * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
1693         * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
1694         * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
1695         * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
1696         * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
1697           Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
1698         * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
1699         * WebView/WebView.h: Changed @method to @property in a couple of places.
1700         * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
1701
1702 2016-10-26  Brian Burg  <bburg@apple.com>
1703
1704         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
1705         https://bugs.webkit.org/show_bug.cgi?id=164046
1706
1707         Reviewed by Joseph Pecoraro.
1708
1709         * WebCoreSupport/WebInspectorClient.h:
1710
1711 2016-10-21  Alex Christensen  <achristensen@webkit.org>
1712
1713         URL::port should return Optional<uint16_t>
1714         https://bugs.webkit.org/show_bug.cgi?id=163806
1715
1716         Reviewed by Darin Adler.
1717
1718         * WebCoreSupport/WebSecurityOrigin.mm:
1719         (-[WebSecurityOrigin port]):
1720
1721 2016-10-24  Dave Hyatt  <hyatt@apple.com>
1722
1723         Remove CSSCharsetRule from the CSS OM
1724         https://bugs.webkit.org/show_bug.cgi?id=163891
1725
1726         Reviewed by Darin Adler.
1727
1728         * DOM/DOMCSSCharsetRule.mm:
1729         (-[DOMCSSCharsetRule encoding]):
1730
1731 2016-10-24  Youenn Fablet  <youenn@apple.com>
1732
1733         Activate WEB_RTC compilation flags for Mac bots
1734         https://bugs.webkit.org/show_bug.cgi?id=163886
1735
1736         Reviewed by Eric Carlson.
1737
1738         * Configurations/FeatureDefines.xcconfig:
1739
1740 2016-10-23  Chris Dumez  <cdumez@apple.com>
1741
1742         addEventListener() / removeEventListener() should use a union for last parameter
1743         https://bugs.webkit.org/show_bug.cgi?id=163863
1744
1745         Reviewed by Darin Adler.
1746
1747         Cast BOOL to bool to help to compiler construct the new variant-type parameter.
1748
1749         * DOM/DOMNode.mm:
1750         (-[DOMNode addEventListener:listener:useCapture:]):
1751         (-[DOMNode addEventListener:::]):
1752         (-[DOMNode removeEventListener:listener:useCapture:]):
1753         (-[DOMNode removeEventListener:::]):
1754
1755 2016-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1756
1757         Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
1758         https://bugs.webkit.org/show_bug.cgi?id=163460
1759         <rdar://problem/28784142>
1760
1761         Reviewed by Darin Adler.
1762
1763         Handle new EditAction types for inserting/deleting pending/final compositions.
1764
1765         * WebCoreSupport/WebEditorClient.mm:
1766         (undoNameForEditAction):
1767
1768 2016-10-21  Jeremy Jones  <jeremyj@apple.com>
1769
1770         Implement basic pointer lock behavior for WebKit and WebKit2.
1771         https://bugs.webkit.org/show_bug.cgi?id=162745
1772
1773         Reviewed by Simon Fraser.
1774
1775         Add basic pointer lock functionality. User permission is not yet implemented.
1776
1777         * WebCoreSupport/WebChromeClient.h:
1778         * WebCoreSupport/WebChromeClient.mm:
1779         (WebChromeClient::requestPointerLock):
1780         (WebChromeClient::requestPointerUnlock):
1781
1782 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
1783
1784         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1785         https://bugs.webkit.org/show_bug.cgi?id=163374
1786
1787         Reviewed by Darin Adler.
1788
1789         * Configurations/FeatureDefines.xcconfig:
1790
1791 2016-10-19  Alex Christensen  <achristensen@webkit.org>
1792
1793         Revert r207151
1794         https://bugs.webkit.org/show_bug.cgi?id=163675
1795
1796         Reviewed by Brent Fulgham.
1797
1798         * Misc/WebDownload.mm:
1799         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
1800         * Misc/WebDownloadInternal.h:
1801         * WebCoreSupport/WebFrameLoaderClient.mm:
1802         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1803         * WebView/WebPreferences.mm:
1804         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
1805         * WebView/WebView.mm:
1806         (-[WebView scheduleInRunLoop:forMode:]):
1807         (-[WebView unscheduleFromRunLoop:forMode:]):
1808
1809 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
1810
1811         Unreviewed, rolling out r207557.
1812
1813         This change caused animations/font-variations tests to time
1814         out on pre-Sierra Macs.
1815
1816         Reverted changeset:
1817
1818         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
1819         iOS 9"
1820         https://bugs.webkit.org/show_bug.cgi?id=163374
1821         http://trac.webkit.org/changeset/207557
1822
1823 2016-10-19  Chris Dumez  <cdumez@apple.com>
1824
1825         Move HTML Interactive Form Validation behind an experimental flag
1826         https://bugs.webkit.org/show_bug.cgi?id=163673
1827
1828         Reviewed by Daniel Bates.
1829
1830         Re-disable HTML Interactive Form Validation by default on Mac WK1.
1831
1832         * WebView/WebViewData.mm:
1833         (-[WebViewPrivate init]):
1834
1835 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
1836
1837         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1838         https://bugs.webkit.org/show_bug.cgi?id=163374
1839
1840         Reviewed by Darin Adler.
1841
1842         * Configurations/FeatureDefines.xcconfig:
1843
1844 2016-10-19  Simon Fraser  <simon.fraser@apple.com>
1845
1846         WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
1847         https://bugs.webkit.org/show_bug.cgi?id=163680
1848
1849         Reviewed by Dean Jackson.
1850
1851         Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
1852
1853         * WebView/WebView.mm:
1854         (-[WebView _preferencesChanged:]):
1855
1856 2016-10-19  Darin Adler  <darin@apple.com>
1857
1858         Move XPath from ExceptionCode to Exception
1859         https://bugs.webkit.org/show_bug.cgi?id=163656
1860
1861         Reviewed by Chris Dumez.
1862
1863         * DOM/DOMDocument.mm:
1864         (wrap): Added. Helper function for wrapping a resolver.
1865         (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
1866         (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
1867         * DOM/DOMXPathExpression.mm:
1868         (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
1869         * DOM/DOMXPathResult.mm:
1870         (-[DOMXPathResult numberValue]): Ditto.
1871         (-[DOMXPathResult stringValue]): Ditto.
1872         (-[DOMXPathResult booleanValue]): Ditto.
1873         (-[DOMXPathResult singleNodeValue]): Ditto.
1874         (-[DOMXPathResult snapshotLength]): Ditto.
1875         (-[DOMXPathResult iterateNext]): Ditto.
1876         (-[DOMXPathResult snapshotItem:]): Ditto.
1877
1878 2016-10-18  Sam Weinig  <sam@webkit.org>
1879
1880         Replace std::experimental::variant with WTF::Variant (or similar)
1881         https://bugs.webkit.org/show_bug.cgi?id=163626
1882
1883         Reviewed by Chris Dumez.
1884
1885         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
1886         into the WTF namespace.
1887
1888         * DOM/DOMHTMLSelectElement.mm:
1889         (-[DOMHTMLSelectElement add:before:]):
1890
1891 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
1892
1893         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
1894         https://bugs.webkit.org/show_bug.cgi?id=163627
1895
1896         Reviewed by Dean Jackson.
1897
1898         Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
1899
1900         * WebView/WebViewPrivate.h:
1901
1902 2016-10-18  Dean Jackson  <dino@apple.com>
1903
1904         Remove CSS_SHAPES feature definition. This should always be on.
1905         https://bugs.webkit.org/show_bug.cgi?id=163628
1906         <rdar://problem/28834613>
1907
1908         Reviewed by Tim Horton.
1909
1910         * Configurations/FeatureDefines.xcconfig:
1911
1912 2016-10-18  Chris Dumez  <cdumez@apple.com>
1913
1914         Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
1915         https://bugs.webkit.org/show_bug.cgi?id=163608
1916
1917         Reviewed by Ryosuke Niwa.
1918
1919         Update add() call sites now that it takes std::variant types in.
1920
1921         * DOM/DOMHTMLOptionsCollection.mm:
1922         (-[DOMHTMLOptionsCollection add:index:]):
1923         * DOM/DOMHTMLSelectElement.mm:
1924         (-[DOMHTMLSelectElement add:before:]):
1925
1926 2016-10-18  Anders Carlsson  <andersca@apple.com>
1927
1928         Get rid of more WebHistoryItem cruft
1929         https://bugs.webkit.org/show_bug.cgi?id=163623
1930
1931         Reviewed by Tim Horton.
1932
1933         * History/WebHistoryItem.mm:
1934         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1935         * History/WebHistoryItemPrivate.h:
1936
1937 2016-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1938
1939         Showing and hiding candidates list is very distracting after selecting word
1940         https://bugs.webkit.org/show_bug.cgi?id=163609
1941         <rdar://problem/28747712>
1942
1943         Reviewed by Tim Horton.
1944
1945         Introduce WebView hooks for mousedown and mouseup. See radar for more details.
1946
1947         * WebView/WebHTMLView.mm:
1948         (-[WebHTMLView mouseDown:mouseDown:]):
1949         (-[WebHTMLView mouseUp:mouseUp:]):
1950         * WebView/WebView.mm:
1951         (-[WebView prepareForMouseDown]):
1952         (-[WebView prepareForMouseUp]):
1953         * WebView/WebViewInternal.h:
1954
1955 2016-10-17  Anders Carlsson  <andersca@apple.com>
1956
1957         Move some history specific HistoryItem code to WebHistoryItem
1958         https://bugs.webkit.org/show_bug.cgi?id=163567
1959
1960         Reviewed by Tim Horton.
1961
1962         * History/HistoryPropertyList.mm:
1963         (HistoryPropertyListWriter::writeHistoryItem):
1964         * History/WebHistory.mm:
1965         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
1966         * History/WebHistoryItem.mm:
1967         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1968         * History/WebHistoryItemInternal.h:
1969         * WebCoreSupport/WebFrameLoaderClient.mm:
1970         (addRedirectURL):
1971         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
1972
1973 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
1974
1975         [MediaStream] Resolve constraints and enumerate devices in the UI process
1976         https://bugs.webkit.org/show_bug.cgi?id=162147
1977         <rdar://problem/28803569>
1978
1979         Reviewed by Darin Adler.
1980
1981         * WebCoreSupport/WebUserMediaClient.h:
1982         * WebCoreSupport/WebUserMediaClient.mm:
1983         (AddPermissionCheckToMap):
1984         (RemovePermissionCheckFromMap):
1985         (WebUserMediaClient::pageDestroyed):
1986         (WebUserMediaClient::requestUserMediaAccess):
1987         (WebUserMediaClient::enumerateMediaDevices):
1988         (WebUserMediaClient::cancelMediaDevicesEnumerationRequest):
1989         (-[WebUserMediaPolicyListener allow]):
1990         (-[WebUserMediaPolicyListener deny]):
1991         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
1992         (-[WebUserMediaPolicyCheckerListener cancelMediaDevicesEnumerationRequest]):
1993         (-[WebUserMediaPolicyCheckerListener allow]):
1994         (-[WebUserMediaPolicyCheckerListener deny]):
1995         (WebUserMediaClient::checkUserMediaPermission): Deleted.
1996         (WebUserMediaClient::cancelUserMediaPermissionCheck): Deleted.
1997         (-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]): Deleted.
1998         (-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]): Deleted.
1999
2000 2016-10-17  Antti Koivisto  <antti@apple.com>
2001
2002         Rename setNeedsStyleRecalc to invalidateStyle
2003         https://bugs.webkit.org/show_bug.cgi?id=163542
2004
2005         Reviewed by Darin Adler.
2006
2007         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2008         (-[WebHostedNetscapePluginView createPluginLayer]):
2009         * Plugins/WebNetscapePluginView.mm:
2010         (-[WebNetscapePluginView createPlugin]):
2011
2012 2016-10-17  Jeremy Jones  <jeremyj@apple.com>
2013
2014         Enable keyboard in fullscreen.
2015         https://bugs.webkit.org/show_bug.cgi?id=163146
2016
2017         Reviewed by Jer Noble.
2018
2019         Allow keyboard in fullscreen.
2020
2021         * WebView/WebView.mm:
2022         (-[WebView _supportsFullScreenForElement:withKeyboard:]):
2023
2024 2016-10-17  Chris Dumez  <cdumez@apple.com>
2025
2026         Move form.reportValidity() behind InteractiveFormValidation setting
2027         https://bugs.webkit.org/show_bug.cgi?id=163550
2028
2029         Reviewed by Darin Adler.
2030
2031         Enable InteractiveFormValidation setting by default and link it to
2032         RuntimeEnabledFeatures so we can use it in the IDL.
2033
2034         * WebView/WebView.mm:
2035         (-[WebView _preferencesChanged:]):
2036         * WebView/WebViewData.mm:
2037         (-[WebViewPrivate init]):
2038
2039 2016-10-17  Anders Carlsson  <andersca@apple.com>
2040
2041         Fix iOS build.
2042
2043         * History/WebBackForwardList.mm:
2044         (-[WebBackForwardList dictionaryRepresentation]):
2045
2046 2016-10-17  Anders Carlsson  <andersca@apple.com>
2047
2048         CTTE some of the BackForwardList member functions
2049         https://bugs.webkit.org/show_bug.cgi?id=163555
2050
2051         Reviewed by Dan Bernstein.
2052
2053         * History/BackForwardList.h:
2054         (BackForwardList::entries):
2055         * History/BackForwardList.mm:
2056         (BackForwardList::removeItem):
2057         (BackForwardList::containsItem):
2058         (BackForwardList::entries): Deleted.
2059         * History/WebBackForwardList.mm:
2060         (-[WebBackForwardList removeItem:]):
2061         (-[WebBackForwardList containsItem:]):
2062         (-[WebBackForwardList description]):
2063
2064 2016-10-17  Anders Carlsson  <andersca@apple.com>
2065
2066         Remove WEBCORE_EXPORT from BackForwardList, it lives in WebKit now
2067         https://bugs.webkit.org/show_bug.cgi?id=163551
2068
2069         Reviewed by Tim Horton.
2070
2071         * History/BackForwardList.h:
2072
2073 2016-10-16  Darin Adler  <darin@apple.com>
2074
2075         Move CSS classes from ExceptionCode to Exception
2076         https://bugs.webkit.org/show_bug.cgi?id=163494
2077
2078         Reviewed by Sam Weinig.
2079
2080         * DOM/DOMCSSMediaRule.mm:
2081         (-[DOMCSSMediaRule insertRule:index:]): Use raiseOnDOMError
2082         the new way to handle ExceptionOr instead of ExceptionCode.
2083         (-[DOMCSSMediaRule deleteRule:]): Ditto.
2084         * DOM/DOMCSSPrimitiveValue.mm:
2085         (-[DOMCSSPrimitiveValue setFloatValue:floatValue:]): Ditto.
2086         (-[DOMCSSPrimitiveValue getFloatValue:]): Ditto.
2087         (-[DOMCSSPrimitiveValue setStringValue:stringValue:]): Ditto.
2088         (-[DOMCSSPrimitiveValue getStringValue]): Ditto.
2089         (-[DOMCSSPrimitiveValue getCounterValue]): Ditto.
2090         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
2091         (-[DOMCSSPrimitiveValue getRGBColorValue]): Ditto.
2092         * DOM/DOMCSSRule.mm:
2093         (-[DOMCSSRule setCssText:]): Ditto.
2094         * DOM/DOMCSSStyleDeclaration.mm:
2095         (-[DOMCSSStyleDeclaration setCssText:]): Ditto.
2096         (-[DOMCSSStyleDeclaration removeProperty:]): Ditto.
2097         (-[DOMCSSStyleDeclaration setProperty:value:priority:]): Ditto.
2098         * DOM/DOMCSSStyleSheet.mm:
2099         (-[DOMCSSStyleSheet insertRule:index:]): Ditto.
2100         (-[DOMCSSStyleSheet deleteRule:]): Ditto.
2101         (-[DOMCSSStyleSheet addRule:style:index:]): Ditto.
2102         (-[DOMCSSStyleSheet removeRule:]): Ditto.
2103         * DOM/DOMCSSValue.mm:
2104         (-[DOMCSSValue setCssText:]): Ditto.
2105         * DOM/DOMMediaList.mm:
2106         (-[DOMMediaList setMediaText:]): Ditto.
2107         (-[DOMMediaList deleteMedium:]): Ditto.
2108         (-[DOMMediaList appendMedium:]): Ditto.
2109
2110         * DOM/ExceptionHandlers.h: Added an overload of raiseDOMException
2111         that works with a WebCore::Exception&& and overloads of
2112         raiseOnDOMError that work with WebCore::ExceptionOr&&.
2113         * DOM/ExceptionHandlers.mm:
2114         (raiseDOMException): Implemented the new version.
2115
2116 2016-10-15  Dan Bernstein  <mitz@apple.com>
2117
2118         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
2119         https://bugs.webkit.org/show_bug.cgi?id=163492
2120         <rdar://problem/28654799>
2121
2122         Reviewed by Darin Adler.
2123
2124         Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm
2125
2126         * WebView/WebHTMLView.mm:
2127         (createMenuItem): Set the tag for items that have submenus as well.
2128
2129 2016-10-14  Anders Carlsson  <andersca@apple.com>
2130
2131         Clean up BackForwardClient
2132         https://bugs.webkit.org/show_bug.cgi?id=163454
2133
2134         Reviewed by Sam Weinig.
2135
2136         * History/BackForwardList.h:
2137         Remove override keywords.
2138
2139         * History/BackForwardList.mm:
2140         (BackForwardList::clearAllPageCaches): Deleted.
2141         Remove this, it's no longer used.
2142
2143         * WebView/WebView.mm:
2144         (-[WebView _clearBackForwardCache]): Deleted.
2145         * WebView/WebViewPrivate.h:
2146         Remove SPI that's no longer used by anyone.
2147
2148 2016-10-13  Anders Carlsson  <andersca@apple.com>
2149
2150         Move BackForwardList from WebCore to WebKitLegacy
2151         https://bugs.webkit.org/show_bug.cgi?id=163418
2152
2153         Reviewed by Tim Horton.
2154
2155         * History/BackForwardList.h: Renamed from Source/WebCore/history/BackForwardList.h.
2156         (BackForwardList::create):
2157         (BackForwardList::webView):
2158         * History/BackForwardList.mm: Renamed from Source/WebCore/history/BackForwardList.cpp.
2159         (BackForwardList::BackForwardList):
2160         (BackForwardList::close):
2161         (BackForwardList::containsItem):
2162         * History/WebBackForwardList.mm:
2163         (kit):
2164         (-[WebBackForwardList initWithBackForwardList:]):
2165         (-[WebBackForwardList setPageCacheSize:]):
2166         (-[WebBackForwardList pageCacheSize]):
2167         * History/WebBackForwardListInternal.h:
2168         * WebCoreSupport/WebFrameLoaderClient.mm:
2169         * WebView/WebFrameView.mm:
2170         * WebView/WebView.mm:
2171         (-[WebView _commonInitializationWithFrameName:groupName:]):
2172         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2173
2174 2016-10-13  Anders Carlsson  <andersca@apple.com>
2175
2176         Get rid of the HistoryItemVector typedef
2177         https://bugs.webkit.org/show_bug.cgi?id=163398
2178
2179         Reviewed by Beth Dakin.
2180
2181         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
2182
2183         * History/WebBackForwardList.mm:
2184         (-[WebBackForwardList dictionaryRepresentation]):
2185         (vectorToNSArray):
2186         (-[WebBackForwardList backListWithLimit:]):
2187         (-[WebBackForwardList forwardListWithLimit:]):
2188         (-[WebBackForwardList description]):
2189         * History/WebHistoryItem.mm:
2190         (-[WebHistoryItem description]):
2191
2192 2016-10-12  Chris Dumez  <cdumez@apple.com>
2193
2194         [Web IDL] Drop support for legacy [ConstructorConditional=*]
2195         https://bugs.webkit.org/show_bug.cgi?id=163368
2196
2197         Reviewed by Ryosuke Niwa.
2198
2199         Drop ENABLE_DOM4_EVENTS_CONSTRUCTOR compiler flag.
2200
2201         * Configurations/FeatureDefines.xcconfig:
2202
2203 2016-10-12  Beth Dakin  <bdakin@apple.com>
2204
2205         Adobe Contribute CS 6.5 Trial crashes on launch
2206         https://bugs.webkit.org/show_bug.cgi?id=163365
2207         -and corresponding-
2208         <rdar://problem/28732731>
2209
2210         Reviewed by Tim Horton.
2211
2212         * Carbon/CarbonWindowFrame.m:
2213         (-[CarbonWindowFrame contentFill]):
2214
2215 2016-10-11  Daniel Bates  <dabates@apple.com>
2216
2217         Attempt to fix the Apple Internal Mac build following r207159
2218         (https://bugs.webkit.org/show_bug.cgi?id=163244)
2219
2220         * WebView/WebView.mm:
2221         (shouldRequireUserGestureToLoadVideo):
2222
2223 2016-10-11  Daniel Bates  <dabates@apple.com>
2224
2225         REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
2226         https://bugs.webkit.org/show_bug.cgi?id=163259
2227         <rdar://problem/28680515>
2228
2229         Reviewed by Jer Noble.
2230
2231         In WebKit1 on iOS we want to require user action to load and play videos by default and
2232         allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
2233         Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
2234         can load and play without being initiated by a user action.
2235
2236         * WebView/WebPreferences.mm:
2237         (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
2238         WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
2239         preference takes precedence over the values of its replacement preferences
2240         WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
2241
2242 2016-10-11  Daniel Bates  <dabates@apple.com>
2243
2244         [iOS] REGRESSION (r197953): User gesture required to load video in iOS 9-built apps
2245         https://bugs.webkit.org/show_bug.cgi?id=163244
2246         <rdar://problem/27250015>
2247
2248         Reviewed by Jer Noble.
2249
2250         Enable or disable the Setting::requiresUserGestureToLoadVideo() in legacy WebKit depending
2251         on the version of iOS SDK that the app was linked against. We require a user gesture to
2252         begin loading a video as of iOS 10.
2253
2254         * WebView/WebView.mm:
2255         (shouldRequireUserGestureToLoadVideo):
2256         (-[WebView _preferencesChanged:]): Modified to pass the WebKit requiresUserGestureToLoadVideo
2257         preference to WebCore.
2258
2259 2016-10-11  Alex Christensen  <achristensen@webkit.org>
2260
2261         Remove dead networking code
2262         https://bugs.webkit.org/show_bug.cgi?id=163263
2263
2264         Reviewed by Daniel Bates.
2265
2266         * Misc/WebDownload.mm:
2267         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2268         * Misc/WebDownloadInternal.h:
2269         * WebCoreSupport/WebFrameLoaderClient.mm:
2270         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2271         * WebView/WebPreferences.mm:
2272         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
2273         * WebView/WebView.mm:
2274         (-[WebView scheduleInRunLoop:forMode:]):
2275         (-[WebView unscheduleFromRunLoop:forMode:]):
2276
2277 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
2278
2279         Add ENABLE_ENCRYPTED_MEDIA configuration option
2280         https://bugs.webkit.org/show_bug.cgi?id=163219
2281
2282         Reviewed by Darin Adler.
2283
2284         * Configurations/FeatureDefines.xcconfig:
2285         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
2286         to enable or disable the new EME implementation at build-time.
2287
2288 2016-10-10  Darin Adler  <darin@apple.com>
2289
2290         Move NotificationCenter from legacy to new DOM exceptions
2291         https://bugs.webkit.org/show_bug.cgi?id=163217
2292
2293         Reviewed by Chris Dumez.
2294
2295         * WebView/WebView.mm:
2296         (-[WebView _notificationIDForTesting:]): Pass reference to page rather than pointer.
2297
2298 2016-10-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2299
2300         Support InputEvent.inputType for the new InputEvent spec
2301         https://bugs.webkit.org/show_bug.cgi?id=163025
2302         <rdar://problem/28658092>
2303
2304         Reviewed by Darin Adler.
2305
2306         Accounts for some changes to the EditAction enum in nameForEditAction. See WebCore ChangeLog
2307         entry for more details.
2308
2309         * WebCoreSupport/WebEditorClient.mm:
2310         (undoNameForEditAction):
2311
2312 2016-10-06  Darin Adler  <darin@apple.com>
2313
2314         Next step on moving to modern way to return DOM exceptions
2315         https://bugs.webkit.org/show_bug.cgi?id=163016
2316
2317         Reviewed by Ryosuke Niwa.
2318
2319         * DOM/DOMDOMImplementation.mm:
2320         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated for
2321         name change from takeReturnValue to releaseReturnValue.
2322         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2323
2324 2016-10-07  Simon Fraser  <simon.fraser@apple.com>
2325
2326         [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
2327         https://bugs.webkit.org/show_bug.cgi?id=163154
2328         rdar://problem/28674216
2329
2330         Reviewed by Tim Horton.
2331         
2332         r55159 added code to counteract AppKit's adjustment of dirty regions during scrolling,
2333         by offsetting the dirty rect in -setNeedsDisplayInRect: if the call happens during
2334         the NSViewBoundsDidChangeNotification handling.
2335         
2336         However, AppKit only does dirty region adjustment in the code path that blits ("copy
2337         on scroll"), so r55159 produces incorrect behavior in, for example, layer-backed views.
2338         
2339         Fix by overriding -[NSClipView _canCopyOnScrollForDeltaX:deltaY:] to know if a single
2340         scroll is going to blit, and only do adjustments in -setNeedsDisplayInRect: if it is.
2341
2342         * WebView/WebClipView.h:
2343         * WebView/WebClipView.mm:
2344         (-[WebClipView _immediateScrollToPoint:]):
2345         (-[WebClipView _canCopyOnScrollForDeltaX:deltaY:]):
2346         (-[WebClipView currentScrollIsBlit]):
2347         * WebView/WebHTMLView.mm:
2348         (-[WebHTMLView setNeedsDisplayInRect:]):
2349         (-[WebHTMLView drawRect:]):
2350
2351 2016-10-06  Youenn Fablet  <youenn@apple.com>
2352
2353         CachedResource client handling methods should take reference
2354         https://bugs.webkit.org/show_bug.cgi?id=163014
2355
2356         Reviewed by Alex Christensen.
2357
2358         * WebView/WebHTMLView.mm:
2359         (promisedDataClient):
2360
2361 2016-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
2362
2363         Put variation fonts work behind a compile-time flag
2364         https://bugs.webkit.org/show_bug.cgi?id=162949
2365
2366         Reviewed by Simon Fraser.
2367
2368         * Configurations/FeatureDefines.xcconfig:
2369
2370 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
2371
2372         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
2373         https://bugs.webkit.org/show_bug.cgi?id=162903
2374
2375         Reviewed by Alex Christensen.
2376
2377         Rename build guards for the remaining implementation of the legacy EME API
2378         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
2379         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
2380
2381         * Configurations/FeatureDefines.xcconfig:
2382         * WebView/WebPreferences.mm:
2383         (+[WebPreferences initialize]):
2384         * WebView/WebView.mm:
2385         (-[WebView _preferencesChanged:]):
2386
2387 2016-10-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2388
2389         The dragged image should be the current frame only of the animated image
2390         https://bugs.webkit.org/show_bug.cgi?id=162109
2391
2392         Reviewed by Tim Horton.
2393
2394         * DOM/DOM.mm:
2395         (-[DOMElement image]): Call the Image function with its new name.
2396         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2397         * Misc/WebElementDictionary.mm:
2398         (-[WebElementDictionary _image]): Call the Image function with its new name.
2399         * Misc/WebIconDatabase.mm:
2400         (-[WebIconDatabase defaultIconWithSize:]): Call snapshotNSImage() to create the icon image.
2401         (webGetNSImage): Call the Image function with its new name.
2402         * WebCoreSupport/WebContextMenuClient.mm:
2403         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call snapshotNSImage() instead of nsImage()..
2404         (WebContextMenuClient::contextMenuForEvent): Ditto.
2405         * WebView/WebHTMLView.mm:
2406         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2407
2408 2016-10-02  Ryan Haddad  <ryanhaddad@apple.com>
2409
2410         Unreviewed, rolling out r206683.
2411
2412         This change caused API test WebKit2.FindMatches to fail on
2413         Mac.
2414
2415         Reverted changeset:
2416
2417         "The dragged image should be the current frame only of the
2418         animated image"
2419         https://bugs.webkit.org/show_bug.cgi?id=162109
2420         http://trac.webkit.org/changeset/206683
2421
2422 2016-09-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
2423
2424         The dragged image should be the current frame only of the animated image
2425         https://bugs.webkit.org/show_bug.cgi?id=162109
2426
2427         Reviewed by Tim Horton.
2428
2429         * DOM/DOM.mm:
2430         (-[DOMElement image]): Call the Image function with its new name.
2431         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2432         * Misc/WebElementDictionary.mm:
2433         (-[WebElementDictionary _image]): Call the Image function with its new name.
2434         * Misc/WebIconDatabase.mm:
2435         (-[WebIconDatabase defaultIconWithSize:]): Call currentFrameNSImage() to create the icon image.
2436         (webGetNSImage): Call the Image function with its new name.
2437         * WebCoreSupport/WebContextMenuClient.mm:
2438         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call currentFrameNSImage() instead of nsImage()..
2439         (WebContextMenuClient::contextMenuForEvent): Ditto.
2440         * WebView/WebHTMLView.mm:
2441         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2442
2443 2016-09-27  Jer Noble  <jer.noble@apple.com>
2444
2445         Remove deprecated ENCRYPTED_MEDIA implementation.
2446         https://bugs.webkit.org/show_bug.cgi?id=161010
2447
2448         Remove ENABLE_ENCRYPTED_MEDIA.
2449
2450         Reviewed by Eric Carlson.
2451
2452         * Configurations/FeatureDefines.xcconfig:
2453
2454 2016-09-26  Daniel Bates  <dabates@apple.com>
2455
2456         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
2457         https://bugs.webkit.org/show_bug.cgi?id=162365
2458
2459         Reviewed by Simon Fraser.
2460
2461         * Configurations/FeatureDefines.xcconfig:
2462         * WebView/WebFrame.mm:
2463         * WebView/WebPreferences.mm:
2464         (+[WebPreferences initialize]):
2465         * WebView/WebView.mm:
2466         (-[WebView _preferencesChanged:]):
2467
2468 2016-09-25  Antti Koivisto  <antti@apple.com>
2469
2470         AuthorStyleSheets shouldn't trigger synchronous style resolutions
2471         https://bugs.webkit.org/show_bug.cgi?id=162532
2472
2473         Reviewed by Darin Adler.
2474
2475         * WebView/WebHTMLView.mm:
2476         (-[WebHTMLView reapplyStyles]):
2477         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2478
2479 2016-09-24  Antti Koivisto  <antti@apple.com>
2480
2481         Move stylesheet change logic from Document to AuthorStyleSheets
2482         https://bugs.webkit.org/show_bug.cgi?id=162488
2483
2484         Reviewed by Andreas Kling.
2485
2486         * WebView/WebHTMLView.mm:
2487         (-[WebHTMLView reapplyStyles]):
2488         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2489
2490 2016-09-23  Caitlin Potter  <caitp@igalia.com>
2491
2492         [JSC] Implement parsing of Async Functions
2493         https://bugs.webkit.org/show_bug.cgi?id=161409
2494
2495         Reviewed by Yusuke Suzuki.
2496
2497         * Configurations/FeatureDefines.xcconfig:
2498
2499 2016-09-23  Commit Queue  <commit-queue@webkit.org>
2500
2501         Unreviewed, rolling out r206311.
2502         https://bugs.webkit.org/show_bug.cgi?id=162495
2503
2504         Broke internal iOS build (Requested by anttik on #webkit).
2505
2506         Reverted changeset:
2507
2508         "Move stylesheet change logic from Document to
2509         AuthorStyleSheets"
2510         https://bugs.webkit.org/show_bug.cgi?id=162488
2511         http://trac.webkit.org/changeset/206311
2512
2513 2016-09-23  Antoine Quint  <graouts@apple.com>
2514
2515         Add a new runtime flag for work on modern media controls (off by default)
2516         https://bugs.webkit.org/show_bug.cgi?id=162420
2517         <rdar://problem/27989489>
2518
2519         Reviewed by Eric Carlson.
2520
2521         * WebView/WebPreferenceKeysPrivate.h:
2522         * WebView/WebPreferences.mm:
2523         (-[WebPreferences modernMediaControlsEnabled]):
2524         (-[WebPreferences setModernMediaControlsEnabled:]):
2525         * WebView/WebPreferencesPrivate.h:
2526         * WebView/WebView.mm:
2527         (-[WebView _preferencesChanged:]):
2528
2529 2016-09-21  Anders Carlsson  <andersca@apple.com>
2530
2531         Support openPaymentSetup API on ApplePaySession object
2532         https://bugs.webkit.org/show_bug.cgi?id=162357
2533         rdar://problem/26776939
2534
2535         Reviewed by Tim Horton.
2536
2537         Add openPaymentSetup stub.
2538
2539         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2540         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2541         (WebPaymentCoordinatorClient::openPaymentSetup):
2542
2543 2016-09-19  Daniel Bates  <dabates@apple.com>
2544
2545         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
2546         https://bugs.webkit.org/show_bug.cgi?id=162167
2547
2548         Reviewed by Simon Fraser.
2549
2550         * Configurations/FeatureDefines.xcconfig:
2551
2552 2016-09-19  Joseph Pecoraro  <pecoraro@apple.com>
2553
2554         Web Inspector: Bring the inspected page's window forward when activating element search
2555         https://bugs.webkit.org/show_bug.cgi?id=162114
2556         <rdar://problem/28349357>
2557
2558         Reviewed by Brian Burg.
2559
2560         * WebCoreSupport/WebInspectorClient.mm:
2561         (WebInspectorClient::didSetSearchingForNode):
2562         When element search is activated bring the window
2563         containing the inspected page to the foreground.
2564
2565 2016-09-15  Brady Eidson  <beidson@apple.com>
2566
2567         WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
2568         <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
2569
2570         Reviewed by Brent Fulgham. 
2571
2572         * WebCoreSupport/WebFrameLoaderClient.h:
2573         * WebCoreSupport/WebFrameLoaderClient.mm:
2574         (WebFrameLoaderClient::dispatchDidCommitLoad):
2575
2576 2016-09-15  Anders Carlsson  <andersca@apple.com>
2577
2578         This was supposed to be committed with the previous patch!
2579
2580         * Plugins/WebBasePluginPackage.mm:
2581         (pathByResolvingSymlinksAndAliases): Deleted.
2582
2583 2016-09-15  Anders Carlsson  <andersca@apple.com>
2584
2585         Replace use of Carbon file system APIs in plug-in loading
2586         https://bugs.webkit.org/show_bug.cgi?id=162040
2587         rdar://problem/6017896
2588
2589         Reviewed by Sam Weinig.
2590
2591         * Plugins/WebBasePluginPackage.mm:
2592         (-[WebBasePluginPackage initWithPath:]):
2593         Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
2594         to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).
2595
2596 2016-09-15  Beth Dakin  <bdakin@apple.com>
2597
2598         Need hasMarkedText on Mac
2599         https://bugs.webkit.org/show_bug.cgi?id=162026
2600         -and corresponding-
2601         rdar://problem/28272353
2602
2603         Reviewed by Anders Carlsson.
2604
2605         * WebView/WebHTMLViewInternal.h:
2606
2607 2016-09-12  Dean Jackson  <dino@apple.com>
2608
2609         Replace RGBA32 with Color in member variables
2610         https://bugs.webkit.org/show_bug.cgi?id=161856
2611         <rdar://problem/28254324>
2612
2613         Reviewed by Simon Fraser.
2614
2615         In preparation for the Color class to become more than
2616         just a 4-byte RGBA value, I went through a few places
2617         that were using the RGBA32 type directly, and replaced
2618         them with Color. This will make some objects a little
2619         bigger e.g. BorderValue and its friends.
2620
2621         I mostly looked at the places that were using RGBA32 as
2622         a member variable. There is still a lot of RGBA32 use
2623         around the project, in particular the CSS parser.
2624
2625         There should be no behaviour change.
2626
2627         * Misc/WebKitNSStringExtras.mm:
2628         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Explicitly
2629         call a Color constructor, rather than passing an RGBA32.
2630
2631 2016-09-13  Chris Dumez  <cdumez@apple.com>
2632
2633         Drop support for <isindex>
2634         https://bugs.webkit.org/show_bug.cgi?id=7139
2635
2636         Reviewed by Ryosuke Niwa.
2637
2638         Drop references to isindex.
2639
2640         * WebCoreSupport/WebEditorClient.mm:
2641         (attributesForAttributedStringConversion):
2642         * WebView/WebHTMLView.mm:
2643         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
2644
2645 2016-09-12  Chris Dumez  <cdumez@apple.com>
2646
2647         Switch remaining users of Document::inPageCache() to pageCacheState()
2648         https://bugs.webkit.org/show_bug.cgi?id=161865
2649
2650         Reviewed by Darin Adler.
2651
2652         Switch remaining users of Document::inPageCache() to pageCacheState() as
2653         the former one is confusing (given that it returns true while the
2654         pagehide event is being fired).
2655
2656         * WebView/WebHTMLView.mm:
2657         (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]):
2658         (-[WebHTMLView setNeedsLayout:]):
2659         (-[WebHTMLView setNeedsToApplyStyles:]):
2660
2661 2016-09-09  Tim Horton  <timothy_horton@apple.com>
2662
2663         Text replacement candidates don't always overwrite the entire original string
2664         https://bugs.webkit.org/show_bug.cgi?id=161779
2665         <rdar://problem/28033492>
2666
2667         Reviewed by Simon Fraser.
2668
2669         * WebCoreSupport/WebEditorClient.mm:
2670         (WebEditorClient::requestCandidatesForSelection):
2671         Make use of the shared implementation of contextRangeForCandidateRequest.
2672
2673 2016-09-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
2674
2675         Move the BitmapImage platform dependent code to a new file named NativeImage[CG|Cairo].cpp
2676         https://bugs.webkit.org/show_bug.cgi?id=158684
2677
2678         Reviewed by Simon Fraser.
2679
2680         * DOM/DOM.mm:
2681         (-[DOMNode getPreviewSnapshotImage:andRects:]):
2682         * Misc/WebCache.mm:
2683         (+[WebCache imageForURL:]):
2684         Replace BitmapImage::getCGImageRef() with BitmapImage::nativeImage().
2685
2686 2016-09-07  Joseph Pecoraro  <pecoraro@apple.com>
2687
2688         [Mac] Address some clang static analyzer warnings in WebKit
2689         https://bugs.webkit.org/show_bug.cgi?id=161597
2690
2691         Reviewed by Darin Adler.
2692
2693         * Misc/WebIconDatabase.h:
2694         Remove unused instance variable. It has not been used since r16005 (2006)!
2695
2696         * Misc/WebSharingServicePickerController.mm:
2697         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2698         Address array leak.
2699
2700         * WebCoreSupport/WebSelectionServiceController.mm:
2701         (WebSelectionServiceController::hasRelevantSelectionServices):
2702         Address attachment and cell leak.
2703
2704         * WebView/WebFullScreenController.h:
2705         * WebView/WebImmediateActionController.h:
2706         Remove unused instance variables.
2707
2708 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
2709
2710         Enable the <meter> element on iOS
2711         https://bugs.webkit.org/show_bug.cgi?id=161714
2712         rdar://problem/8978410
2713
2714         Reviewed by Tim Horton.
2715
2716         Define ENABLE_METER_ELEMENT unconditionally now.
2717
2718         * Configurations/FeatureDefines.xcconfig:
2719
2720 2016-09-07  Mark Lam  <mark.lam@apple.com>
2721
2722         Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
2723         https://bugs.webkit.org/show_bug.cgi?id=161498
2724
2725         Reviewed by Geoffrey Garen.
2726
2727         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2728         (WebKit::NetscapePluginInstanceProxy::evaluate):
2729         (WebKit::NetscapePluginInstanceProxy::invoke):
2730         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2731         (WebKit::NetscapePluginInstanceProxy::construct):
2732         (WebKit::NetscapePluginInstanceProxy::getProperty):
2733         (WebKit::NetscapePluginInstanceProxy::setProperty):
2734         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2735         (WebKit::NetscapePluginInstanceProxy::hasProperty):
2736         (WebKit::NetscapePluginInstanceProxy::hasMethod):
2737         (WebKit::NetscapePluginInstanceProxy::enumerate):
2738         * WebView/WebView.mm:
2739         (aeDescFromJSValue):
2740
2741 2016-09-07  Youenn Fablet  <youenn@apple.com>
2742
2743         [Streams API] Separate compile flag for ReadableStream and WritableStream
2744         https://bugs.webkit.org/show_bug.cgi?id=161044
2745
2746         Reviewed by Alex Christensen.
2747
2748         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
2749
2750         * Configurations/FeatureDefines.xcconfig:
2751
2752 2016-09-06  Chris Dumez  <cdumez@apple.com>
2753
2754         Add support for input.minLength / textArea.minLength
2755         https://bugs.webkit.org/show_bug.cgi?id=161644
2756
2757         Reviewed by Darin Adler.
2758
2759         Update ObjC bindings to reflect method renaming.
2760
2761         * DOM/DOMHTMLInputElement.mm:
2762         (-[DOMHTMLInputElement maxLength]):
2763         (-[DOMHTMLInputElement setMaxLength:]):
2764         * DOM/DOMHTMLTextAreaElement.mm:
2765         (-[DOMHTMLTextAreaElement maxLength]):
2766         (-[DOMHTMLTextAreaElement setMaxLength:]):
2767
2768 2016-09-06  Dan Bernstein  <mitz@apple.com>
2769
2770         <rdar://problem/8064563> Ugly NSLog in DOMInternal.mm
2771
2772         Rubber-stamped by Anders Carlsson.
2773
2774         * DOM/DOMInternal.mm:
2775         (-[WebScriptObject _initializeScriptDOMNodeImp]): Removed useless call to NSLog.
2776
2777 2016-09-06  Ryan Haddad  <ryanhaddad@apple.com>
2778
2779         Unreviewed, rolling out r205407.
2780
2781         Not the correct way to implement this functionality
2782
2783         Reverted changeset:
2784
2785         "Consult with the FrameLoaderClient about whether or not
2786         content extensions should be enabled when loading this URL."
2787         https://bugs.webkit.org/show_bug.cgi?id=161441
2788         http://trac.webkit.org/changeset/205407
2789
2790 2016-09-05  Darin Adler  <darin@apple.com>
2791
2792         More bindings improvements, particularly things not needed for JavaScript bindings
2793         https://bugs.webkit.org/show_bug.cgi?id=161572
2794
2795         Reviewed by Sam Weinig.
2796
2797         * DOM/DOMDOMImplementation.mm:
2798         (-[DOMImplementation hasFeature:version:]): Call SVGTests::hasFeatureForLegacyBindings
2799         instead of DOMImplementation::hasFeature. Also removed JSMainThreadNullState
2800         since this does not do anything that can invoke JavaScript.
2801
2802         * DOM/DOMDocument.mm:
2803         (-[DOMDocument defaultCharset]): Call defaultCharsetForLegacyBindings. Also removed
2804         JSMainThreadNullState.
2805
2806         * DOM/DOMDocumentType.mm:
2807         (-[DOMDocumentType entities]): Changed to simply return nil; same behavior as before,
2808         but with no dependency on WebCore. Also removed JSMainThreadNullState.
2809         (-[DOMDocumentType notations]): Ditto.
2810         (-[DOMDocumentType internalSubset]): Ditto, except empty string rather than nil.
2811
2812         * DOM/DOMNode.mm:
2813         (-[DOMNode isSupported:version:]): Call SVGTests::hasFeatureForLegacyBindings
2814         instead of Node::isSupportedForBindings. Also removed JSMainThreadNullState.
2815
2816 2016-09-04  Joseph Pecoraro  <pecoraro@apple.com>
2817
2818         Remove unnecessary RetainPtr.
2819
2820         Review comments on earlier change.
2821
2822         * WebView/WebImmediateActionController.mm:
2823         (-[WebImmediateActionController _defaultAnimationController]):
2824
2825 2016-09-03  Darin Adler  <darin@apple.com>
2826
2827         Streamline DOMImplementation, and move it to our new DOM exception system
2828         https://bugs.webkit.org/show_bug.cgi?id=161295
2829
2830         Reviewed by Ryosuke Niwa.
2831
2832         * DOM/DOMDOMImplementation.mm:
2833         (unwrap): Added. Use this instead of the IMPL macro.
2834         (-[DOMImplementation dealloc]): Updated to use unwrap.
2835         (-[DOMImplementation hasFeature:version:]): Ditto.
2836         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated to work with
2837         ExceptionOr.
2838         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2839         (-[DOMImplementation createCSSStyleSheet:media:]): Removed exception logic since
2840         this function can no longer raise an exception.
2841         (-[DOMImplementation createHTMLDocument:]): Updated to use unwrap.
2842         (-[DOMImplementation hasFeature::]): Changed to call the non-deprecated version
2843         rather than duplicating its implementation. Also moved into the category as defined
2844         in the header.
2845         (-[DOMImplementation createDocumentType:::]): Ditto.
2846         (-[DOMImplementation createDocument:::]): Ditto.
2847         (-[DOMImplementation createCSSStyleSheet::]): Ditto.
2848
2849         * DOM/DOMDocument.mm: Removed unneeded include of DOMImplementation.h.
2850         (-[DOMDocument setXmlStandalone:]): Updated since setXMLStandalone no longer can
2851         raise an exception.
2852
2853         * WebView/WebFrame.mm:
2854         (-[WebFrame _canProvideDocumentSource]): Updated to use isTextMIMEType in its new
2855         location in MIMETypeRegistry instead of in DOMImplementation.
2856
2857 2016-09-03  Brian Weinstein  <bweinstein@apple.com>
2858
2859         Implement a stub version of FrameLoaderClient::shouldUseContentExtensionsForURL.
2860         https://bugs.webkit.org/show_bug.cgi?id=16144
2861
2862         Reviewed by Darin Adler.
2863
2864         * WebCoreSupport/WebFrameLoaderClient.h:
2865
2866 2016-09-02  Beth Dakin  <bdakin@apple.com>
2867
2868         Need to updateEditorState if an element change edit-ability without changing 
2869         selection
2870         https://bugs.webkit.org/show_bug.cgi?id=161546
2871         -and corresponding-
2872         rdar://problem/27806012
2873
2874         Reviewed by Ryosuke Niwa.
2875
2876         Every time WebEditorClient::respondToChangedSelection is called, we now save 
2877         whether the last state was contentEditable. That way in 
2878         updateEditorStateAfterLayoutIfNeeded() we can assess whether or not edit-ability 
2879         has changed. 
2880
2881         * WebCoreSupport/WebEditorClient.h:
2882         * WebCoreSupport/WebEditorClient.mm:
2883         (WebEditorClient::respondToChangedSelection):
2884         (WebEditorClient:: updateEditorStateAfterLayoutIfEditabilityChanged):
2885
2886 2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
2887
2888         [Mac] RetainPtr misuse, AnimationController leaks
2889         https://bugs.webkit.org/show_bug.cgi?id=161552
2890
2891         Reviewed by Tim Horton.
2892
2893         * WebView/WebImmediateActionController.mm:
2894         (-[WebImmediateActionController _defaultAnimationController]):
2895
2896 2016-07-08  Jer Noble  <jer.noble@apple.com>
2897
2898         Refactor WebPlaybackSessionModelMediaElement to be client based.
2899         https://bugs.webkit.org/show_bug.cgi?id=159580
2900
2901         Reviewed by Eric Carlson.
2902
2903         No longer necessary to tell the models and interfaces about each other.
2904
2905         * WebView/WebView.mm:
2906         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
2907         (-[WebView _clearPlaybackControlsManager]):
2908
2909 2016-09-01  Dan Bernstein  <mitz@apple.com>
2910
2911         Build fix.
2912
2913         * Configurations/FeatureDefines.xcconfig:
2914
2915 2016-09-01  Myles C. Maxfield  <mmaxfield@apple.com>
2916
2917         Clean up TextRun-related code
2918         https://bugs.webkit.org/show_bug.cgi?id=161473
2919
2920         Reviewed by Simon Fraser.
2921
2922         Remove unused #includes.
2923
2924         * WebCoreSupport/WebDragClient.mm:
2925         * WebView/WebView.mm:
2926
2927 2016-08-31  Keith Rollin  <krollin@apple.com>
2928
2929         WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
2930         https://bugs.webkit.org/show_bug.cgi?id=160969
2931         <rdar://problem/26068734>
2932
2933         Reviewed by Simon Fraser.
2934
2935         Enable subsystem- and channel-related data and functions when using
2936         RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
2937         and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
2938
2939         * Misc/WebKitLogging.h:
2940         * Misc/WebKitLogging.m:
2941         * WebView/WebView.mm:
2942         (-[WebView _commonInitializationWithFrameName:groupName:]):
2943
2944 2016-08-31  Brady Eidson  <beidson@apple.com>
2945
2946         WK2 Gamepad provider on iOS.
2947         https://bugs.webkit.org/show_bug.cgi?id=161412
2948
2949         Reviewed by Tim Horton.
2950
2951         * Configurations/FeatureDefines.xcconfig:
2952
2953         * WebView/WebView.mm:
2954         (WebKitInitializeGamepadProviderIfNecessary):
2955
2956 2016-08-30  Mark Lam  <mark.lam@apple.com>
2957
2958         Introduce the ThrowScope and force every throw site to instantiate a ThrowScope.
2959         https://bugs.webkit.org/show_bug.cgi?id=161171
2960
2961         Reviewed by Filip Pizlo and Geoffrey Garen.
2962
2963         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2964         (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
2965         * Plugins/Hosted/ProxyInstance.mm:
2966         (WebKit::ProxyInstance::invokeMethod):
2967
2968 2016-08-28  Andreas Kling  <akling@apple.com>
2969
2970         document.title setter can't throw.
2971         <https://webkit.org/b/161302>
2972
2973         Reviewed by Antti Koivisto.
2974
2975         * DOM/DOMDocument.mm:
2976         (-[DOMDocument setTitle:]):
2977
2978 2016-08-28  Andreas Kling  <akling@apple.com>
2979
2980         Clean up some .text attribute setters that don't throw.
2981         <https://webkit.org/b/161292>
2982
2983         Reviewed by Darin Adler.
2984
2985         * DOM/DOMHTMLTitleElement.mm:
2986         (-[DOMHTMLTitleElement setText:]):
2987
2988 2016-08-26  Sam Weinig  <sam@webkit.org>
2989
2990         Remove support for ENABLE_LEGACY_WEB_AUDIO
2991         https://bugs.webkit.org/show_bug.cgi?id=161262
2992
2993         Reviewed by Anders Carlsson.
2994
2995         * Configurations/FeatureDefines.xcconfig:
2996         Remove ENABLE_LEGACY_WEB_AUDIO
2997
2998 2016-08-25  Anders Carlsson  <andersca@apple.com>
2999
3000         Re-export DOMException NSStrings after r204717
3001         https://bugs.webkit.org/show_bug.cgi?id=161200
3002         <rdar://problem/27959937>
3003
3004         Reviewed by Alex Christensen.
3005
3006         * DOM/ExceptionHandlers.mm:
3007         (raiseDOMException):
3008         * WebKit.exp:
3009
3010 2016-08-22  Darin Adler  <darin@apple.com>
3011
3012         Move Objective-C DOM bindings from WebCore to legacy WebKit
3013         https://bugs.webkit.org/show_bug.cgi?id=160654
3014
3015         Reviewed by Alex Christensen.
3016
3017         * DOM: Added lots of files to the directory.
3018         The files are just as they were in bindings/objc except that the paths of includes
3019         have been updated as needed, and the code no longer is defined inside the WebCore
3020         namespace, requring changes to various functions and their call sites. Also removed
3021         all the WEBCORE_EXPORT since we export differently here in legacy WebKit.
3022
3023         * DOM/DOMInternal.h: Moved. Replaced createDOMWrapper with initializeDOMWrapperHooks.
3024         * DOM/DOMUtility.mm: Moved.
3025         (createDOMWrapper): Simplified to use toWrapped and not do unneeded namespace tricks.
3026         (disconnectWindowWrapper): Added.
3027         (initializeDOMWrapperHooks): Added.
3028
3029         * MigrateHeaders.make: Removed all the internal headers since they are now just
3030         normal project headers. Added the "DOM" directory to the VPATH. Some of the headers
3031         from WebCore are still being migrated, so we can't remove WebCorePrivateHeaders yet.
3032
3033         * WebCoreSupport/WebEditorClient.h: Updated to return RefPtr<DocumentFragment>.
3034
3035         * WebCoreSupport/WebEditorClient.mm:
3036         (WebEditorClient::documentFragmentFromDelegate): Use RefPtr.
3037
3038         * WebKit.exp: Added exports for all the classes that used to use WEBCORE_EXPORT to
3039         be exported from WebCore.
3040
3041         * WebView/WebFrame.mm:
3042         (-[WebFrame innerLineHeight:]): Moved code from WebCore::Frame::innerLineHeight here.
3043         No longer depend on whether this node happens to be in this frame. Also removed
3044         unneeded null check since a node's document can't be null.
3045
3046         * WebView/WebHTMLView.mm: Removed uneeded include of ExceptionHandlers.h, which
3047         is now here in WebKitLegacy instead of WebCore. But no need to include it at all.
3048
3049         * WebView/WebView.mm:
3050         (-[WebView _commonInitializationWithFrameName:groupName:]): Call
3051         initializeDOMWrapperHooks so WebScriptObject can create DOM binding wrappers when
3052         making a script object for a DOM object, rather than just a generic script object.
3053         (+[WebView enableWebThread]): Added a call to WebCoreObjCDeallocOnWebThread here for
3054         DOMObject along with the other classes. This was done in WebCore before, but DOMObject is now
3055         defined here in legacy WebKit.
3056         (-[WebView styleAtSelectionStart]): Moved code from WebCore::Frame::styleAtSelectionStart here.
3057         Replaced incorrect code that called "new PropertySetCSSStyleDeclaration" with a misleading comment
3058         about reference counting; that code was leaking all the style declarations. Instead use
3059         MutableStyleProperties::ensureCSSStyleDeclaration, which is designed for this purpose.
3060
3061 2016-08-22  Youenn Fablet  <youenn@apple.com>
3062
3063         [Fetch API] Activate fetch api runtime flag by default
3064         https://bugs.webkit.org/show_bug.cgi?id=160452
3065
3066         Reviewed by Alex Christensen.
3067
3068         * WebView/WebPreferences.mm:
3069         (+[WebPreferences initialize]):
3070
3071 2016-08-21  Alex Christensen  <achristensen@webkit.org>
3072
3073         Use Document& instead of Document* when getting cookies
3074         https://bugs.webkit.org/show_bug.cgi?id=161011
3075
3076         Reviewed by Darin Adler.
3077
3078         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3079         (WebKit::NetscapePluginInstanceProxy::getCookies):
3080         (WebKit::NetscapePluginInstanceProxy::setCookies):
3081         * Plugins/WebNetscapePluginView.mm:
3082         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3083         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
3084
3085 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
3086
3087         Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
3088         https://bugs.webkit.org/show_bug.cgi?id=160923
3089
3090         Reviewed by Tim Horton.
3091
3092         * WebCoreSupport/WebFrameLoaderClient.h:
3093         * WebCoreSupport/WebFrameLoaderClient.mm:
3094         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
3095         (WebFrameLoaderClient::dispatchDidLayout): Deleted.
3096
3097 2016-08-18  Daniel Bates  <dabates@apple.com>
3098
3099         Ld warns of non-existent PrivateFrameworks directory when building WebKit with the public iOS 9.3 SDK
3100         https://bugs.webkit.org/show_bug.cgi?id=160979
3101
3102         Rubber-stamped by Simon Fraser.
3103
3104         Only add the SDK PrivateFrameworks directory to the FRAMEWORK_SEARCH_PATH when building for
3105         iOS Simulator, building with an iOS SDK that does not support text-based stubs, or building
3106         an Apple-internal build.
3107
3108         * Configurations/WebKitLegacy.xcconfig:
3109
3110 2016-08-18  Anders Carlsson  <andersca@apple.com>
3111
3112         Move an NPAPI-only function from WebCore to WebKit
3113         https://bugs.webkit.org/show_bug.cgi?id=160967
3114
3115         Reviewed by Sam Weinig.
3116
3117         * Plugins/WebNetscapePluginView.h:
3118         * Plugins/WebNetscapePluginView.mm:
3119         (-[WebNetscapePluginView getVariable:value:]):
3120         (-[WebNetscapePluginView _destroyPlugin]):
3121
3122 2016-08-18  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
3123
3124         [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
3125         https://bugs.webkit.org/show_bug.cgi?id=156096
3126
3127         Reviewed by Dean Jackson.
3128
3129         Adds:
3130         - Setup interface for enabling runtime flag for Web animations through preferences.
3131
3132         * WebView/WebPreferenceKeysPrivate.h:
3133         * WebView/WebPreferences.mm:
3134         (+[WebPreferences initialize]):
3135         (-[WebPreferences webAnimationsEnabled]):
3136         (-[WebPreferences setWebAnimationsEnabled:]):
3137         * WebView/WebPreferencesPrivate.h:
3138         * WebView/WebView.mm:
3139         (-[WebView _preferencesChanged:]):
3140
3141 2016-08-17  Anders Carlsson  <andersca@apple.com>
3142
3143         Remove a couple of unused WKSI function pointers
3144         https://bugs.webkit.org/show_bug.cgi?id=160946
3145
3146         Reviewed by Dan Bernstein.
3147
3148         * WebCoreSupport/WebSystemInterface.mm:
3149         (InitWebCoreSystemInterface): Deleted.
3150
3151 2016-08-16  Daniel Bates  <dabates@apple.com>
3152
3153         WKSI static library should be named by major iOS revision, not individual updates
3154         https://bugs.webkit.org/show_bug.cgi?id=160727
3155         <rdar://problem/22274848>
3156
3157         Reviewed by Alexey Proskuryakov.
3158
3159         * Configurations/Base.xcconfig:
3160         * Configurations/DebugRelease.xcconfig:
3161         * Configurations/WebKitLegacy.xcconfig:
3162
3163 2016-08-16  Darin Adler  <darin@apple.com>
3164
3165         [Cocoa] Remove dependency on Objective-C bindings in WebKit2 editing code
3166         https://bugs.webkit.org/show_bug.cgi?id=160891
3167
3168         Reviewed by Anders Carlsson.
3169
3170         * WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
3171
3172         * WebCoreSupport/WebEditorClient.mm:
3173         (attributesForAttributedStringConversion): Replaced the
3174         createExcludedElementsForAttributedStringConversion function with this one.
3175         No good reason to keep the array around instead of the dictionary.
3176         (_WebCreateFragment): Renamed from documentFragmentFromAttributedString.
3177         This is now a global function exported so it can be called by WebCore with
3178         a different way of returning its value.
3179
3180         * WebKit.exp: Added _WebCreateFragment.
3181
3182         * WebView/WebHTMLView.mm:
3183         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3184         Removed long-ago-obsolete workaround for Radar bug 5052369.
3185
3186 2016-08-15  Anders Carlsson  <andersca@apple.com>
3187
3188         Another build fix.
3189
3190         * WebKit.exp:
3191
3192 2016-08-15  Anders Carlsson  <andersca@apple.com>
3193
3194         Fix build.
3195
3196         * Configurations/WebKitLegacy.xcconfig:
3197         * WebKit.mac.exp:
3198
3199 2016-08-15  Anders Carlsson  <andersca@apple.com>
3200
3201         Remove OldWebAssertions.c
3202         https://bugs.webkit.org/show_bug.cgi?id=160862
3203
3204         Reviewed by Dan Bernstein.
3205
3206         These functions were used by an old version of iWeb. The latest version of iWeb no longer uses them.
3207
3208         * Misc/OldWebAssertions.c: Removed.
3209         (WebReportAssertionFailure): Deleted.
3210         (WebReportError): Deleted.
3211
3212 2016-08-15  Anders Carlsson  <andersca@apple.com>
3213
3214         Remove WebKeyGenerator
3215         https://bugs.webkit.org/show_bug.cgi?id=160854
3216
3217         Reviewed by Dan Bernstein.
3218
3219         This SPI class is no longer used by Safari.
3220
3221         * WebCoreSupport/WebKeyGenerator.h: Removed.
3222         * WebCoreSupport/WebKeyGenerator.mm: Removed.
3223         (+[WebKeyGenerator sharedGenerator]): Deleted.
3224         (toWebCertificateParseResult): Deleted.
3225         (-[WebKeyGenerator addCertificatesToKeychainFromData:]): Deleted.
3226         * WebView/WebFrameView.mm:
3227
3228 2016-08-15  Daniel Bates  <dabates@apple.com>
3229
3230         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
3231         private frameworks and libraries
3232         https://bugs.webkit.org/show_bug.cgi?id=155931
3233         <rdar://problem/25807989>
3234
3235         Reviewed by Dan Bernstein.
3236
3237         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
3238         where X is the major version of the active iOS SDK.
3239
3240         * Configurations/WebKitLegacy.xcconfig:
3241
3242 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
3243
3244         Add a setting and preferences to enable visual viewport mode
3245         https://bugs.webkit.org/show_bug.cgi?id=160843
3246
3247         Reviewed by Sam Weinig.
3248
3249         Hook up the visualViewportEnabled setting for WebKit1.
3250
3251         * WebView/WebPreferenceKeysPrivate.h:
3252         * WebView/WebPreferences.mm:
3253         (+[WebPreferences initialize]):
3254         (-[WebPreferences visualViewportEnabled]):
3255         (-[WebPreferences setVisualViewportEnabled:]):
3256         * WebView/WebPreferencesPrivate.h:
3257
3258 2016-08-15  Joseph Pecoraro  <pecoraro@apple.com>
3259
3260         Remove unused includes of wtf headers
3261         https://bugs.webkit.org/show_bug.cgi?id=160839
3262
3263         Reviewed by Alex Christensen.
3264
3265         * History/BinaryPropertyList.cpp:
3266         * History/WebBackForwardList.mm:
3267         * History/WebHistoryItemInternal.h:
3268         * Misc/WebNSFileManagerExtras.mm:
3269         * Plugins/Hosted/NetscapePluginHostProxy.h:
3270         * WebCoreSupport/WebPlatformStrategies.mm:
3271         * WebCoreSupport/WebSelectionServiceController.mm:
3272         * WebCoreSupport/WebUserMediaClient.h:
3273
3274 2016-08-12  Anders Carlsson  <andersca@apple.com>
3275
3276         Move the plug-in and WebGL blacklist code to WebCore
3277         https://bugs.webkit.org/show_bug.cgi?id=160831
3278
3279         Reviewed by Sam Weinig.
3280
3281         Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.
3282
3283         * WebCoreSupport/WebFrameLoaderClient.mm:
3284         (shouldBlockPlugin):
3285         (WebFrameLoaderClient::createPlugin):
3286         (WebFrameLoaderClient::createJavaAppletWidget):
3287         (shouldBlockWebGL):
3288         (WebFrameLoaderClient::webGLPolicyForURL):
3289         (WebFrameLoaderClient::resolveWebGLPolicyForURL):
3290
3291 2016-08-14  Daniel Bates  <dabates@apple.com>
3292
3293         Fix compiler errors when building iOS WebKit using the iOS 10 beta SDK
3294         https://bugs.webkit.org/show_bug.cgi?id=160725
3295
3296         Reviewed by Sam Weinig.
3297
3298         OSAtomicCompareAndSwap32() has been deprecated as of the iOS 10 beta SDK. For now,
3299         silence the complier warning.
3300
3301         * WebView/WebView.mm:
3302         (-[WebView _dispatchTileDidDraw:]):
3303
3304 2016-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3305
3306         Remove always true JSC::Debugger::needPauseHandling virtual method
3307         https://bugs.webkit.org/show_bug.cgi?id=160822
3308
3309         Reviewed by Mark Lam.
3310
3311         * WebView/WebScriptDebugger.h:
3312
3313 2016-08-11  Chris Dumez  <cdumez@apple.com>
3314
3315         Regression(r204268): Mail crashes when trying to compose an email
3316         https://bugs.webkit.org/show_bug.cgi?id=160775
3317
3318         Reviewed by Anders Carlsson.
3319
3320         Properly initialize PageConfiguration.pluginInfoProvider in
3321         [WebView initSimpleHTMLDocumentWithStyle] to avoid a null
3322         dereference in Mail when trying to compose an email.
3323
3324         * WebView/WebView.mm:
3325         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3326
3327 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3328
3329         Sort the feature flags in the FEATURE_DEFINES lines
3330         https://bugs.webkit.org/show_bug.cgi?id=160742
3331
3332         Reviewed by Anders Carlsson.
3333
3334         * Configurations/FeatureDefines.xcconfig:
3335
3336 2016-08-09  Alex Christensen  <achristensen@webkit.org>
3337
3338         Move NetworkStorageSession management to WebCore
3339         https://bugs.webkit.org/show_bug.cgi?id=160173
3340
3341         Reviewed by Brady Eidson.
3342
3343         * WebCoreSupport/WebFrameNetworkingContext.mm:
3344         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3345         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3346         * WebCoreSupport/WebPlatformStrategies.mm:
3347         * WebView/WebView.mm:
3348
3349 2016-08-09  Anders Carlsson  <andersca@apple.com>
3350
3351         Instantiate WebKit plug-ins at layout time, instead of at style resolution time
3352         https://bugs.webkit.org/show_bug.cgi?id=160715
3353
3354         Reviewed by Tim Horton.
3355
3356         * WebCoreSupport/WebFrameLoaderClient.mm:
3357         (WebFrameLoaderClient::objectContentType):
3358
3359 2016-08-09  George Ruan  <gruan@apple.com>
3360
3361         Implement functionality of media capture on iOS
3362         https://bugs.webkit.org/show_bug.cgi?id=158945
3363         <rdar://problem/26893343>
3364
3365         Reviewed by Tim Horton.
3366
3367         * Configurations/FeatureDefines.xcconfig: Enable Media Capture feature
3368         for iOS.
3369
3370 2016-08-09  Anders Carlsson  <andersca@apple.com>
3371
3372         Get rid of PluginStrategy
3373         https://bugs.webkit.org/show_bug.cgi?id=160696
3374
3375         Reviewed by Dan Bernstein.
3376
3377         * WebCoreSupport/WebPlatformStrategies.h:
3378         * WebCoreSupport/WebPlatformStrategies.mm:
3379         (WebPlatformStrategies::createPluginStrategy): Deleted.
3380         * WebCoreSupport/WebPluginInfoProvider.h:
3381         * WebCoreSupport/WebPluginInfoProvider.mm:
3382         (WebPluginInfoProvider::setPluginLoadClientPolicy): Deleted.
3383         (WebPluginInfoProvider::clearPluginClientPolicies): Deleted.
3384
3385 2016-08-09  Anders Carlsson  <andersca@apple.com>
3386
3387         Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
3388         https://bugs.webkit.org/show_bug.cgi?id=160694
3389
3390         Reviewed by Dan Bernstein.
3391
3392         * WebCoreSupport/WebPlatformStrategies.h:
3393         * WebCoreSupport/WebPlatformStrategies.mm:
3394         (WebPlatformStrategies::createPluginStrategy):
3395         (WebPlatformStrategies::refreshPlugins): Deleted.
3396         (WebPlatformStrategies::getPluginInfo): Deleted.
3397         (WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
3398         (WebPlatformStrategies::setPluginLoadClientPolicy): Deleted.
3399         (WebPlatformStrategies::clearPluginClientPolicies): Deleted.
3400         * WebCoreSupport/WebPluginInfoProvider.mm:
3401         (WebPluginInfoProvider::refreshPlugins):
3402         (WebPluginInfoProvider::getPluginInfo):
3403         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3404
3405 2016-08-08  Anders Carlsson  <andersca@apple.com>
3406
3407         Add a new PluginInfoProvider class, to replace PluginStrategy
3408         https://bugs.webkit.org/show_bug.cgi?id=160670
3409
3410         Reviewed by Sam Weinig.
3411
3412         Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
3413
3414         * WebCoreSupport/WebPluginInfoProvider.h: Added.
3415         * WebCoreSupport/WebPluginInfoProvider.mm: Added.
3416         (WebPluginInfoProvider::singleton):
3417         (WebPluginInfoProvider::WebPluginInfoProvider):
3418         (WebPluginInfoProvider::~WebPluginInfoProvider):
3419         (WebPluginInfoProvider::refreshPlugins):
3420         (WebPluginInfoProvider::getPluginInfo):
3421         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3422         (WebPluginInfoProvider::setPluginLoadClientPolicy):
3423         (WebPluginInfoProvider::clearPluginClientPolicies):
3424         * WebView/WebView.mm:
3425         (-[WebView _commonInitializationWithFrameName:groupName:]):
3426
3427 2016-08-02  Enrica Casucci  <enrica@apple.com>
3428
3429         Allow building with content filtering disabled.
3430         https://bugs.webkit.org/show_bug.cgi?id=160454
3431
3432         Reviewed by Simon Fraser.
3433
3434         * Configurations/FeatureDefines.xcconfig:
3435         * WebCoreSupport/WebFrameLoaderClient.h:
3436         * WebCoreSupport/WebFrameLoaderClient.mm:
3437         (WebFrameLoaderClient::blockedByContentFilterError):
3438
3439 2016-08-02  Anders Carlsson  <andersca@apple.com>
3440
3441         Remove more unused/uninstalled Objective-C DOM bindings
3442         https://bugs.webkit.org/show_bug.cgi?id=160464
3443
3444         Reviewed by Darin Adler.
3445
3446         Stop installing unused headers.
3447
3448         * MigrateHeaders.make:
3449
3450 2016-08-01  Anders Carlsson  <andersca@apple.com>
3451
3452         Bring back a file - it needs to be copied by WebCore.
3453
3454         * MigrateHeaders.make:
3455
3456 2016-08-01  Anders Carlsson  <andersca@apple.com>
3457
3458         Remove another file.
3459
3460         * MigrateHeaders.make:
3461
3462 2016-08-01  Anders Carlsson  <andersca@apple.com>
3463
3464         Remove a file.
3465
3466         * MigrateHeaders.make:
3467
3468 2016-08-01  Anders Carlsson  <andersca@apple.com>
3469
3470         Freeze all the DOMHTML* Objective-C bindings
3471         https://bugs.webkit.org/show_bug.cgi?id=160424
3472
3473         Reviewed by Tim Horton.
3474
3475         Don't migrate DOMHTMLEmbedElementPrivate.h - it was just an empty header.
3476
3477         * MigrateHeaders.make:
3478
3479 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
3480
3481         Remove deprecated SPI for video inline / fullscreen controls
3482         https://bugs.webkit.org/show_bug.cgi?id=160318
3483
3484         Reviewed by Tim Horton.
3485
3486         * WebView/WebPreferenceKeysPrivate.h:
3487         * WebView/WebPreferences.mm:
3488         (+[WebPreferences initialize]): Deleted.
3489         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]): Deleted.
3490         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]): Deleted.
3491         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]): Deleted.
3492         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]): Deleted.
3493         * WebView/WebPreferencesPrivate.h:
3494         * WebView/WebView.mm:
3495         (-[WebView _preferencesChanged:]): Deleted.
3496
3497 2016-07-28  Anders Carlsson  <andersca@apple.com>
3498
3499         Move a Mail.app workaround closer to where it's actually needed
3500         https://bugs.webkit.org/show_bug.cgi?id=160317
3501
3502         Reviewed by Tim Horton.
3503
3504         * WebCoreSupport/WebFrameLoaderClient.mm:
3505         (WebFrameLoaderClient::dispatchWillSendRequest):
3506         * WebView/WebFrame.mm:
3507         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Deleted.
3508
3509 2016-07-28  Anders Carlsson  <andersca@apple.com>
3510
3511         Use a RetainPtr in WebFrameLoaderClient::assignIdentifierToInitialRequest
3512         https://bugs.webkit.org/show_bug.cgi?id=160315
3513
3514         Reviewed by Tim Horton.
3515
3516         * WebCoreSupport/WebFrameLoaderClient.mm:
3517         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3518
3519 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
3520
3521         Fix the Windows debug build.
3522         
3523         WebResourceLoadScheduler's logging was a holdover from it being in WebCore,
3524         and prior to r203749 WebKit was actually using a WebCore log channel.
3525         
3526         For some reason this doesn't build on Windows debug, so just remove
3527         this logging for now.
3528
3529         * Misc/WebKitLogging.h:
3530
3531 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
3532
3533         [iPhone] Playing a video on tudou.com plays only sound, no video
3534         https://bugs.webkit.org/show_bug.cgi?id=160178
3535         <rdar://problem/27535468>
3536
3537         Reviewed by Eric Carlson and Dan Bernstein.
3538
3539         * WebView/WebPreferenceKeysPrivate.h:
3540         * WebView/WebPreferences.mm:
3541         (+[WebPreferences initialize]):
3542         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]):
3543         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]):
3544         * WebView/WebPreferencesPrivate.h:
3545         * WebView/WebView.mm:
3546         (-[WebView _preferencesChanged:]):
3547
3548 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
3549
3550         Allow LOG macros to be used outside the namespace, and other logging cleanup
3551         https://bugs.webkit.org/show_bug.cgi?id=160216
3552
3553         Reviewed by Anders Carlsson.
3554
3555         Fix some issues with the LOG macros.
3556         
3557         First, they were not usable outside the WebKit namespace in WebKit2 code. Fix by moving
3558         its log channels outside of the namespace (they are protected by a unique prefix anyway).
3559         
3560         Second, allow LOG_WITH_STREAM to be used in WebKit2 by moving that and a helper macro
3561         into LogMacros.h, which is exported from WebCore as a private header.
3562         
3563         Third, split the Logging.h header into two. Logging.h remains for framework-internal
3564         log channels and log macros. Add LogInitialization.h which is external, and used to
3565         initialize the channels.
3566         
3567         Finally unify "initializeLogChannels" and "initializeLoggingChannels" terminology everywhere.
3568
3569         * Misc/WebKitLogging.h:
3570         * Misc/WebKitLogging.m:
3571         * WebView/WebView.mm:
3572         (-[WebView _commonInitializationWithFrameName:groupName:]):
3573
3574 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3575
3576         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
3577         https://bugs.webkit.org/show_bug.cgi?id=160066
3578
3579         Reviewed by Dean Jackson.
3580
3581         * WebView/WebPreferenceKeysPrivate.h:
3582         * WebView/WebPreferences.mm:
3583         (+[WebPreferences initialize]): Deleted.
3584         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]): Deleted.
3585         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): Deleted.
3586         * WebView/WebPreferencesPrivate.h:
3587         * WebView/WebView.mm:
3588         (-[WebView _preferencesChanged:]): Deleted.
3589
3590 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3591
3592         [iPhone] Playing a video on tudou.com plays only sound, no video
3593         https://bugs.webkit.org/show_bug.cgi?id=159967
3594         <rdar://problem/26964090>
3595
3596         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
3597
3598         Add the two preferences to WebPreferences.
3599
3600         * WebView/WebPreferenceKeysPrivate.h:
3601         * WebView/WebPreferences.mm:
3602         (+[WebPreferences initialize]):
3603         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
3604         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
3605         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
3606         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
3607         * WebView/WebPreferencesPrivate.h:
3608         * WebView/WebView.mm:
3609         (-[WebView _preferencesChanged:]):
3610
3611 2016-07-20  Commit Queue  <commit-queue@webkit.org>
3612
3613         Unreviewed, rolling out r203471.
3614         https://bugs.webkit.org/show_bug.cgi?id=160003
3615
3616         many iOS-simulator tests are failing (Requested by litherum on
3617         #webkit).
3618
3619         Reverted changeset:
3620
3621         "[iPhone] Playing a video on tudou.com plays only sound, no
3622         video"
3623         https://bugs.webkit.org/show_bug.cgi?id=159967
3624         http://trac.webkit.org/changeset/203471
3625
3626 2016-07-20  Myles C. Maxfield  <mmaxfield@apple.com>
3627
3628         [iPhone] Playing a video on tudou.com plays only sound, no video
3629         https://bugs.webkit.org/show_bug.cgi?id=159967
3630         <rdar://problem/26964090>
3631
3632         Reviewed by Jon Lee.
3633
3634         Add the two preferences to WebPreferences.
3635
3636         * WebView/WebPreferenceKeysPrivate.h:
3637         * WebView/WebPreferences.mm:
3638         (+[WebPreferences initialize]):
3639         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
3640         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
3641         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
3642         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
3643         * WebView/WebPreferencesPrivate.h:
3644         * WebView/WebView.mm:
3645         (-[WebView _preferencesChanged:]):
3646
3647 2016-07-19  Andy Estes  <aestes@apple.com>
3648
3649         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
3650         https://bugs.webkit.org/show_bug.cgi?id=159956
3651
3652         Reviewed by Dan Bernstein.
3653
3654         * Misc/WebKitErrors.h: Moved definition of WebKitErrorFrameLoadBlockedByContentFilter from here ...
3655         * Misc/WebKitErrorsPrivate.h: to here.
3656
3657 2016-07-18  Anders Carlsson  <andersca@apple.com>
3658
3659         WebKit nightly fails to build on macOS Sierra
3660         https://bugs.webkit.org/show_bug.cgi?id=159902
3661         rdar://problem/27365672
3662
3663         Reviewed by Tim Horton.
3664
3665         * icu/unicode/ucurr.h: Added.
3666         Add ucurr.h from ICU.
3667
3668 2016-07-17  Sam Weinig  <sam@webkit.org>
3669
3670         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3671         <rdar://problem/26554137>
3672         https://bugs.webkit.org/show_bug.cgi?id=159856
3673
3674         Reviewed by Dan Bernstein.
3675
3676         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3677         (WebKit::NetscapePluginInstanceProxy::evaluate):
3678         * Plugins/WebNetscapePluginView.mm:
3679         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
3680         Update for new UserGestureIndicator interface.
3681
3682 2016-07-16  Ryosuke Niwa  <rniwa@webkit.org>
3683
3684         Rename fastGetAttribute to attributeWithoutSynchronization
3685         https://bugs.webkit.org/show_bug.cgi?id=159852
3686
3687         Reviewed by Darin Adler.
3688
3689         * WebView/WebHTMLRepresentation.mm:
3690         (matchLabelsAgainstElement):
3691
3692 2016-07-15  Chris Dumez  <cdumez@apple.com>
3693
3694         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
3695         https://bugs.webkit.org/show_bug.cgi?id=159793
3696
3697         Reviewed by Ryosuke Niwa.
3698
3699         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.
3700
3701         * WebView/WebHTMLRepresentation.mm:
3702         (matchLabelsAgainstElement):
3703
3704 2016-07-14  Alex Christensen  <achristensen@webkit.org>
3705
3706         Use SocketProvider to create SocketStreamHandles
3707         https://bugs.webkit.org/show_bug.cgi?id=159774
3708
3709         Reviewed by Brady Eidson.
3710
3711         * Misc/WebSocketProvider.h: Removed.
3712         * Misc/WebSocketProvider.mm: Removed.
3713         * WebView/WebView.mm:
3714         (-[WebView _commonInitializationWithFrameName:groupName:]):
3715         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3716
3717 2016-07-14  Csaba Osztrogonác  <ossy@webkit.org>
3718
3719         Fix the !ENABLE(WEB_SOCKETS) build after r202930
3720         https://bugs.webkit.org/show_bug.cgi?id=159768
3721
3722         Reviewed by Alex Christensen.
3723
3724         * Misc/WebSocketProvider.h:
3725
3726 2016-07-13  Beth Dakin  <bdakin@apple.com>
3727
3728         Add more candidate tests
3729         https://bugs.webkit.org/show_bug.cgi?id=159730
3730
3731         Reviewed by Tim Horton.
3732
3733         Move shouldRequestCandidates from WebViewInternal to WebViewPrivate so that 
3734         we can use it in tests. 
3735         * WebView/WebViewInternal.h:
3736         * WebView/WebViewPrivate.h:
3737
3738 2016-07-13  Enrica Casucci  <enrica@apple.com>
3739
3740         Update supported platforms in xcconfig files to match the sdk names.
3741         https://bugs.webkit.org/show_bug.cgi?id=159728
3742
3743         Reviewed by Tim Horton.
3744
3745         * Configurations/Base.xcconfig:
3746
3747 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3748
3749         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3750         https://bugs.webkit.org/show_bug.cgi?id=159671
3751
3752         Reviewed by Csaba Osztrogonác.
3753
3754         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3755         https://bugs.webkit.org/show_bug.cgi?id=89235
3756
3757         So this guard can be removed in build scripts.
3758
3759         * Configurations/FeatureDefines.xcconfig:
3760
3761 2016-07-11  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3762
3763         Purge PassRefPtr in platform/efl and platform/mac 
3764         https://bugs.webkit.org/show_bug.cgi?id=159548
3765
3766         Reviewed by Alex Christensen.
3767
3768         Remove all use of PassRefPtr and clean up unnecessary tabs and spaces.
3769
3770         * WebCoreSupport/WebPlatformStrategies.h:
3771         * WebCoreSupport/WebPlatformStrategies.mm:
3772         (WebPlatformStrategies::setBufferForType):
3773
3774 2016-07-11  Enrica Casucci  <enrica@apple.com>
3775
3776         Add synthetic click origin to WKNavigationAction.
3777         https://bugs.webkit.org/show_bug.cgi?id=159584
3778         rdar://problem/25610422
3779
3780         Reviewed by Tim Horton.
3781
3782         * WebView/WebFrame.mm:
3783         (-[WebFrame _dragSourceEndedAt:operation:]):
3784         * WebView/WebPDFView.mm:
3785         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3786
3787 2016-07-11  Anders Carlsson  <andersca@apple.com>
3788
3789         Able to open multiple payment sheets in Safari at the same time
3790         https://bugs.webkit.org/show_bug.cgi?id=159637
3791         rdar://problem/26411339
3792
3793         Reviewed by Beth Dakin.
3794
3795         Update for WebCore changes.
3796
3797         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3798         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3799         (WebPaymentCoordinatorClient::showPaymentUI):
3800
3801 2016-07-08  Andy Estes  <aestes@apple.com>
3802
3803         [Content Filtering] Load blocked pages more like other error pages are loaded
3804         https://bugs.webkit.org/show_bug.cgi?id=159485
3805         <rdar://problem/26014076>
3806
3807         Reviewed by Brady Eidson.
3808
3809         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
3810         * Misc/WebKitErrors.m:
3811         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
3812         * WebCoreSupport/WebFrameLoaderClient.h:
3813         * WebCoreSupport/WebFrameLoaderClient.mm:
3814         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
3815
3816 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3817
3818         Unreviewed, rolling out r202944.
3819         https://bugs.webkit.org/show_bug.cgi?id=159570
3820
3821         caused some tests to crash under GuardMalloc (Requested by
3822         estes on #webkit).
3823
3824         Reverted changeset:
3825
3826         "[Content Filtering] Load blocked pages more like other error
3827         pages are loaded"
3828         https://bugs.webkit.org/show_bug.cgi?id=159485
3829         http://trac.webkit.org/changeset/202944
3830
3831 2016-07-08  Jiewen Tan  <jiewen_tan@apple.com>
3832
3833         Define DYLD_MACOSX_VERSION_10_12
3834         https://bugs.webkit.org/show_bug.cgi?id=159525
3835         <rdar://problem/26250296>
3836
3837         Reviewed by Brent Fulgham.
3838
3839         * WebView/WebView.mm:
3840         (shouldConvertInvalidURLsToBlank):
3841         Replace 0x000A0C00 with DYLD_MACOSX_VERSION_10_12.
3842
3843 2016-07-07  Beth Dakin  <bdakin@apple.com>
3844
3845         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3846         https://bugs.webkit.org/show_bug.cgi?id=159532
3847         -and corresponding-
3848         rdar://problem/27177179
3849
3850         Reviewed by Tim Horton.
3851
3852         * WebView/WebView.mm:
3853         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3854         (-[WebView forceRequestCandidatesForTesting]):
3855         (-[WebView shouldRequestCandidates]):
3856         * WebView/WebViewPrivate.h:
3857
3858 2016-07-07  Andy Estes  <aestes@apple.com>
3859
3860         [Content Filtering] Load blocked pages more like other error pages are loaded
3861         https://bugs.webkit.org/show_bug.cgi?id=159485
3862         <rdar://problem/26014076>
3863
3864         Reviewed by Brady Eidson.
3865
3866         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
3867         * Misc/WebKitErrors.m:
3868         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
3869         * WebCoreSupport/WebFrameLoaderClient.h:
3870         * WebCoreSupport/WebFrameLoaderClient.mm:
3871         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
3872
3873 2016-07-07  Alex Christensen  <achristensen@webkit.org>
3874
3875         Use SocketProvider to create WebSocketChannels
3876         https://bugs.webkit.org/show_bug.cgi?id=158776
3877
3878         Reviewed by Brent Fulgham.
3879
3880         * Misc/WebSocketProvider.mm: Copied from Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp.
3881         (WebSocketProvider::createWebSocketChannel):
3882         (WebCore::ThreadableWebSocketChannel::create): Deleted.
3883         * Misc/WebSocketProvider.h:
3884         * WebView/WebView.mm:
3885         (-[WebView _commonInitializationWithFrameName:groupName:]):
3886         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3887
3888 2016-07-06  Benjamin Poulain  <bpoulain@apple.com>
3889
3890         [JSC] Unify how we throw TypeError from C++
3891         https://bugs.webkit.org/show_bug.cgi?id=159500
3892
3893         Reviewed by Saam Barati.
3894
3895         * Plugins/Hosted/ProxyInstance.mm:
3896         (WebKit::ProxyInstance::invokeMethod):
3897
3898 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3899
3900         Add a runtime flag for DOM iterators
3901         https://bugs.webkit.org/show_bug.cgi?id=159300
3902
3903         Reviewed by Alex Christensen.
3904
3905         * WebView/WebPreferenceKeysPrivate.h:
3906         * WebView/WebPreferences.mm:
3907         (-[WebPreferences DOMIteratorEnabled]):
3908         (-[WebPreferences setDOMIteratorEnabled:]):
3909         * WebView/WebPreferencesPrivate.h:
3910         * WebView/WebView.mm:
3911         (-[WebView _preferencesChanged:]):
3912
3913 2016-06-30  Jiewen Tan  <jiewen_tan@apple.com>
3914
3915         Create a generic "linked-on-or-after" check for new CSP Rules
3916         https://bugs.webkit.org/show_bug.cgi?id=159322
3917         <rdar://problem/27117220>
3918
3919         Reviewed by Brent Fulgham.
3920
3921         * WebView/WebView.mm:
3922         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
3923
3924 2016-06-30  Anders Carlsson  <andersca@apple.com>
3925
3926         Mail crashes on launch at WebCore::PaymentCoordinator::~PaymentCoordinator() + 20
3927         https://bugs.webkit.org/show_bug.cgi?id=159306
3928         rdar://problem/27092107
3929
3930         Reviewed by Tim Horton.
3931
3932         * WebView/WebView.mm:
3933         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3934         Create a WebPaymentCoordinatorClient. Remove an unneeded #import.
3935
3936         (-[WebView _commonInitializationWithFrameName:groupName:]):
3937         Remove an unneeded #import.
3938
3939 2016-06-27  Anders Carlsson  <andersca@apple.com>
3940
3941         WebKit::WebPaymentCoordinator leak
3942         https://bugs.webkit.org/show_bug.cgi?id=159168
3943         rdar://problem/26929772
3944
3945         Reviewed by Beth Dakin.
3946
3947         Update for WebCore changes.
3948
3949         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3950         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3951         (WebPaymentCoordinatorClient::paymentCoordinatorDestroyed):
3952         (WebPaymentCoordinatorClient::mainFrameDestroyed): Deleted.
3953
3954 2016-06-27  Tim Horton  <timothy_horton@apple.com>
3955
3956         REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app
3957         https://bugs.webkit.org/show_bug.cgi?id=159184
3958         <rdar://problem/26370206>
3959
3960         Reviewed by Beth Dakin.
3961
3962         * WebView/WebHTMLView.mm:
3963         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3964         * WebView/WebImmediateActionController.h:
3965         * WebView/WebImmediateActionController.mm:
3966         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3967         (-[WebImmediateActionController _animationControllerForText]):
3968         (dictionaryPopupInfoForRange): Deleted.
3969         WebImmediateActionController's code to make a DictionaryPopupInfo and TextIndicator
3970         from a Range in WebKit1 is much better than WebHTMLView's; use it in both cases.
3971
3972 2016-06-24  Jer Noble  <jer.noble@apple.com>
3973
3974         Playback controls refer to wrong element when playing multiple items in a page.
3975         https://bugs.webkit.org/show_bug.cgi?id=159076
3976         <rdar://problem/26953532>
3977
3978         Reviewed by Beth Dakin.
3979
3980         clearPlaybackControlsManager() no longer takes a parameter.
3981
3982         * WebCoreSupport/WebChromeClient.h:
3983         * WebCoreSupport/WebChromeClient.mm:
3984         (WebChromeClient::clearPlaybackControlsManager):
3985         * WebView/WebView.mm:
3986         (-[WebView _clearPlaybackControlsManager]): Renamed from _clearPlaybackControlsManagerForMediaElement:.
3987         * WebView/WebViewInternal.h:
3988
3989 2016-06-23  Alex Christensen  <achristensen@webkit.org>
3990
3991         Remove unused didCancelAuthenticationChallenge
3992         https://bugs.webkit.org/show_bug.cgi?id=158819
3993
3994         Reviewed by David Kilzer.
3995
3996         * Misc/WebDownload.mm:
3997         (-[WebDownloadInternal download:didCancelAuthenticationChallenge:]): Deleted.
3998         * WebCoreSupport/WebFrameLoaderClient.h:
3999         * WebCoreSupport/WebFrameLoaderClient.mm:
4000         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.
4001         * WebView/WebDelegateImplementationCaching.h:
4002         * WebView/WebView.mm:
4003         (-[WebView _cacheResourceLoadDelegateImplementations]):
4004
4005 2016-06-23  John Wilander  <wilander@apple.com>
4006
4007         Enable window.open() for existing versions of Secret Society app
4008         https://bugs.webkit.org/show_bug.cgi?id=159049
4009         <rdar://problem/26528349>
4010
4011         Reviewed by Andy Estes.
4012
4013         The Secret Society Hidden Mystery app has a broken version check treating iOS 10
4014         as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
4015         handler. We should allow the existing versions of the app to do this to not break
4016         them.
4017
4018         * WebView/WebView.mm:
4019         (shouldAllowWindowOpenWithoutUserGesture):
4020             Added.
4021         (shouldConvertInvalidURLsToBlank):
4022             Changed hex number to constant DYLD_IOS_VERSION_10_0.
4023
4024 2016-06-22  Anders Carlsson  <andersca@apple.com>
4025
4026         Move the WebKitLegacy Apple Pay code to the open source repository
4027         https://bugs.webkit.org/show_bug.cgi?id=159035
4028
4029         Reviewed by Tim Horton.
4030
4031         * WebCoreSupport/WebPaymentCoordinatorClient.h: Added.
4032         * WebCoreSupport/WebPaymentCoordinatorClient.mm: Added.
4033         (WebPaymentCoordinatorClient::WebPaymentCoordinatorClient):
4034         (WebPaymentCoordinatorClient::~WebPaymentCoordinatorClient):
4035         (WebPaymentCoordinatorClient::supportsVersion):
4036         (WebPaymentCoordinatorClient::canMakePayments):
4037         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
4038         (WebPaymentCoordinatorClient::showPaymentUI):
4039         (WebPaymentCoordinatorClient::completeMerchantValidation):
4040         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
4041         (WebPaymentCoordinatorClient::completeShippingContactSelection):
4042         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
4043         (WebPaymentCoordinatorClient::completePaymentSession):
4044         (WebPaymentCoordinatorClient::abortPaymentSession):
4045         (WebPaymentCoordinatorClient::mainFrameDestroyed):
4046         * WebKitAdditions.mm: Removed.
4047         * WebView/WebView.mm:
4048         (-[WebView _commonInitializationWithFrameName:groupName:]):
4049
4050 2016-06-21  Anders Carlsson  <andersca@apple.com>
4051
4052         Fix build.
4053
4054         * Configurations/FeatureDefines.xcconfig:
4055
4056 2016-06-21  Anders Carlsson  <andersca@apple.com>
4057
4058         Begin moving the Apple Pay code to the open source repository
4059         https://bugs.webkit.org/show_bug.cgi?id=158998
4060
4061         Reviewed by Tim Horton.
4062
4063         * Configurations/FeatureDefines.xcconfig:
4064         Add ENABLE_APPLE_PAY.
4065
4066 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
4067
4068         Focus event dispatched in iframe causes parent document to scroll incorrectly
4069         https://bugs.webkit.org/show_bug.cgi?id=158629
4070         rdar://problem/26521616
4071
4072         Reviewed by Tim Horton.
4073         
4074         Pass SelectionRevealMode::Reveal in existing code.
4075
4076         * WebView/WebFrame.mm:
4077         (-[WebFrame _scrollDOMRangeToVisible:]):
4078         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
4079         (-[WebFrame revealSelectionAtExtent:]):
4080         * WebView/WebHTMLView.mm:
4081         (-[WebHTMLView jumpToSelection:]):
4082         (-[WebHTMLView centerSelectionInVisibleArea:]):
4083
4084 2016-06-21  Amir Alavi  <aalavi@apple.com>
4085
4086         Upstream WKHTTPCookiesForURL from WebKitSystemInterface to OpenSource
4087         https://bugs.webkit.org/show_bug.cgi?id=158967
4088
4089         Reviewed by Brent Fulgham.
4090
4091         * WebCoreSupport/WebSystemInterface.mm:
4092         (InitWebCoreSystemInterface): Deleted.
4093
4094 2016-06-20  Commit Queue  <commit-queue@webkit.org>
4095
4096         Unreviewed, rolling out r202243.
4097         https://bugs.webkit.org/show_bug.cgi?id=158972
4098
4099         Broke Windows build and iOS tests (Requested by ap on
4100         #webkit).
4101
4102         Reverted changeset:
4103
4104         "Focus event dispatched in iframe causes parent document to
4105         scroll incorrectly"
4106         https://bugs.webkit.org/show_bug.cgi?id=158629
4107         http://trac.webkit.org/changeset/202243
4108
4109 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
4110
4111         Focus event dispatched in iframe causes parent document to scroll incorrectly
4112         https://bugs.webkit.org/show_bug.cgi?id=158629
4113         rdar://problem/26521616
4114
4115         Reviewed by Tim Horton.
4116         
4117         Pass SelectionRevealMode::Reveal in existing code.
4118
4119         * WebView/WebFrame.mm:
4120         (-[WebFrame _scrollDOMRangeToVisible:]):
4121         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
4122         (-[WebFrame revealSelectionAtExtent:]):
4123         * WebView/WebHTMLView.mm:
4124         (-[WebHTMLView jumpToSelection:]):
4125         (-[WebHTMLView centerSelectionInVisibleArea:]):
4126
4127 2016-06-20  Keith Rollin  <krollin@apple.com>
4128
4129         Remove RefPtr::release() and change calls sites to use WTFMove()
4130         https://bugs.webkit.org/show_bug.cgi?id=158369
4131
4132         Reviewed by Chris Dumez.
4133
4134         RefPtr::release() releases its managed pointer awkwardly. It's more
4135         direct and clearer to use WTFMove to transfer ownership of the managed
4136         pointer.
4137
4138         As part of this cleanup, also change a lot of explicit data types to
4139         'auto'.
4140
4141         * Plugins/Hosted/NetscapePluginHostManager.mm:
4142         (WebKit::NetscapePluginHostManager::instantiatePlugin):
4143         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4144         (WebKit::NetscapePluginInstanceProxy::create):
4145         (WebKit::NetscapePluginInstanceProxy::loadRequest):
4146         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
4147         * WebCoreSupport/WebFrameLoaderClient.mm:
4148         (-[WebFramePolicyListener receivedPolicyDecision:]):
4149         * WebCoreSupport/WebSecurityOrigin.mm:
4150         (-[WebSecurityOrigin initWithURL:]):
4151         * WebView/WebArchive.mm:
4152         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
4153         (-[WebArchive initWithData:]):
4154         * WebView/WebDataSource.mm:
4155         (-[WebDataSource mainResource]):
4156         * WebView/WebFrame.mm:
4157         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
4158
4159 2016-06-15  Alexey Proskuryakov  <ap@apple.com>
4160
4161         +[WebHTMLRepresentation supportedMIMETypes] leaks
4162         https://bugs.webkit.org/show_bug.cgi?id=158683
4163
4164         Reviewed by Darin Adler.
4165
4166         The problem occurred when chaining newArrayByConcatenatingArrays calls.
4167
4168         Also refactored the code to avoid returning NSMutableArrays disguised as NSArrays,
4169         and removed __unsafe_unretained modifiers that were added in http://trac.webkit.org/r149453
4170         for no apparent reason.
4171