Safari does not emit composition end if blurred for dead key / Japanese IME
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Safari does not emit composition end if blurred for dead key / Japanese IME
4         https://bugs.webkit.org/show_bug.cgi?id=164369
5         <rdar://problem/29050439>
6
7         Reviewed by Ryosuke Niwa.
8
9         When canceling a composition, make sure that we clear the system IME state.
10
11         * WebCoreSupport/WebEditorClient.h:
12         * WebCoreSupport/WebEditorClient.mm:
13         (WebEditorClient::canceledComposition):
14
15 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
16
17         Add a setting and preferences to enable/disable async image decoding
18         https://bugs.webkit.org/show_bug.cgi?id=164417
19
20         Reviewed by Simon Fraser.
21
22         Hook up the asyncImageDecodingEnabled setting for WebKit1.
23
24         * WebView/WebPreferenceKeysPrivate.h:
25         * WebView/WebPreferences.mm:
26         (+[WebPreferences initialize]):
27         (-[WebPreferences asyncImageDecodingEnabled]):
28         (-[WebPreferences setAsyncImageDecodingEnabled:]):
29         * WebView/WebPreferencesPrivate.h:
30         * WebView/WebView.mm:
31         (-[WebView _preferencesChanged:]):
32
33 2016-11-01  Alex Christensen  <achristensen@webkit.org>
34
35         Remove PassRefPtr from DumpRenderTree
36         https://bugs.webkit.org/show_bug.cgi?id=164307
37
38         Reviewed by Sam Weinig.
39
40         * WebView/WebGeolocationPosition.mm:
41         (-[WebGeolocationPosition initWithGeolocationPosition:]):
42
43 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
44
45         [Readable Streams API] Enable creation of ReadableByteStreamController
46         https://bugs.webkit.org/show_bug.cgi?id=164014
47
48         Reviewed by Youenn Fablet.
49
50         Added flag for the byte stream part of Readable Streams API.
51
52         * Configurations/FeatureDefines.xcconfig:
53
54 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
55
56         Remove CUSTOM_ELEMENTS build flag
57         https://bugs.webkit.org/show_bug.cgi?id=164267
58
59         Reviewed by Antti Koivisto.
60
61         Removed the build flag.
62
63         * Configurations/FeatureDefines.xcconfig:
64         * WebView/WebPreferences.mm:
65         (+[WebPreferences initialize]):
66         * WebView/WebView.mm:
67         (-[WebView _preferencesChanged:]):
68
69 2016-11-01  Eric Carlson  <eric.carlson@apple.com>
70
71         [MediaStream] restrict media capture secure connections
72         https://bugs.webkit.org/show_bug.cgi?id=164234
73         <rdar://problem/28944906>
74
75         Reviewed by Alex Christensen.
76
77         * WebView/WebPreferenceKeysPrivate.h:
78         * WebView/WebPreferences.mm:
79         (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
80         (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
81         (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
82         * WebView/WebPreferencesPrivate.h:
83
84         * WebView/WebView.mm:
85         (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
86
87 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
88
89         JSC should support SharedArrayBuffer
90         https://bugs.webkit.org/show_bug.cgi?id=163986
91
92         Reviewed by Keith Miller.
93         
94         Support the RuntimeFlag.
95
96         * WebView/WebPreferencesPrivate.h:
97
98 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
99
100         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
101         https://bugs.webkit.org/show_bug.cgi?id=164236
102         <rdar://problem/28747712>
103
104         Reviewed by Beth Dakin.
105
106         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
107         dictionary lookup.
108
109         * WebCoreSupport/WebEditorClient.mm:
110         (WebEditorClient::respondToChangedSelection):
111         * WebView/WebImmediateActionController.mm:
112         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
113
114 2016-10-31  Darin Adler  <darin@apple.com>
115
116         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
117         https://bugs.webkit.org/show_bug.cgi?id=164214
118
119         Reviewed by Alex Christensen.
120
121         * DOM/DOMCSSPrimitiveValue.mm:
122         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
123         is a reference now.
124         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
125
126         * DOM/DOMDocument.mm:
127         (-[DOMDocument querySelector:]): Updated exception handling.
128         (-[DOMDocument querySelectorAll:]): Ditto.
129         * DOM/DOMDocumentFragment.mm:
130         (-[DOMDocumentFragment querySelector:]): Ditto.
131         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
132         * DOM/DOMElement.mm:
133         (-[DOMElement querySelector:]): Ditto.
134         (-[DOMElement querySelectorAll:]): Ditto.
135
136 2016-10-31  Darin Adler  <darin@apple.com>
137
138         Convert Document from ExceptionCode to Exception
139         https://bugs.webkit.org/show_bug.cgi?id=164212
140
141         Reviewed by Alex Christensen.
142
143         * DOM/DOMDocument.mm:
144         (-[DOMDocument setXmlVersion:]): Updated exception handling.
145         (-[DOMDocument cookie]): Ditto.
146         (-[DOMDocument setCookie:]): Ditto.
147         (-[DOMDocument setBody:]): Ditto.
148         (-[DOMDocument createElement:]): Ditto.
149         (-[DOMDocument createCDATASection:]): Ditto.
150         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
151         (-[DOMDocument createAttribute:]): Ditto.
152         (-[DOMDocument createEntityReference:]): Ditto.
153         (-[DOMDocument importNode:deep:]): Ditto.
154         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
155         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
156         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
157         (-[DOMDocument adoptNode:]): Ditto.
158         (-[DOMDocument createEvent:]): Ditto.
159
160 2016-10-30  Darin Adler  <darin@apple.com>
161
162         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
163         https://bugs.webkit.org/show_bug.cgi?id=164206
164
165         Reviewed by Chris Dumez.
166
167         * DOM/DOMElement.mm:
168         (-[DOMElement setInnerHTML:]): Updated exception handling.
169         (-[DOMElement setOuterHTML:]): Ditto.
170         (-[DOMElement setAttribute:value:]): Ditto.
171         (-[DOMElement setAttributeNode:]): Ditto.
172         (-[DOMElement removeAttributeNode:]): Ditto.
173         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
174         (-[DOMElement setAttributeNodeNS:]): Ditto.
175         (-[DOMElement matches:]): Ditto.
176         (-[DOMElement closest:]): Ditto.
177         (-[DOMElement webkitMatchesSelector:]): Ditto.
178         * DOM/DOMHTMLElement.mm:
179         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
180         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
181         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
182         * DOM/DOMNamedNodeMap.mm:
183         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
184         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
185         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
186         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
187
188 2016-10-29  Darin Adler  <darin@apple.com>
189
190         Convert more of DOM from ExceptionCode to Exception
191         https://bugs.webkit.org/show_bug.cgi?id=164173
192
193         Reviewed by Ryosuke Niwa.
194
195         * DOM/DOMCharacterData.mm:
196         (-[DOMCharacterData substringData:length:]): Updated since this
197         now uses ExceptionOr.
198         (-[DOMCharacterData insertData:data:]): Ditto.
199         (-[DOMCharacterData deleteData:length:]): Ditto.
200         (-[DOMCharacterData replaceData:length:data:]): Ditto.
201         * DOM/DOMText.mm:
202         (-[DOMText splitText:]): Ditto.
203         (-[DOMText replaceWholeText:]): Removed unneeded exception code
204         handling from function that does not throw an exception.
205
206 2016-10-28  Darin Adler  <darin@apple.com>
207
208         Move all classes in the HTML directory from ExceptionCode to Exception
209         https://bugs.webkit.org/show_bug.cgi?id=163876
210
211         Reviewed by Sam Weinig.
212
213         * DOM/DOMCharacterData.mm:
214         (-[DOMCharacterData remove]): Updated exception handling.
215         * DOM/DOMDOMTokenList.mm:
216         (-[DOMDOMTokenList toggle:force:]): Ditto.
217         * DOM/DOMDocumentType.mm:
218         (-[DOMDocumentType remove]): Ditto.
219         * DOM/DOMElement.mm:
220         (-[DOMElement remove]): Ditto.
221         * DOM/DOMHTML.mm:
222         (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
223         * DOM/DOMHTMLCanvasElement.mm:
224         (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
225         * DOM/DOMHTMLElement.mm:
226         (-[DOMHTMLElement setInnerText:]): Ditto.
227         (-[DOMHTMLElement setOuterText:]): Ditto.
228         (-[DOMHTMLElement setContentEditable:]): Ditto.
229         * DOM/DOMHTMLInputElement.mm:
230         (-[DOMHTMLInputElement setMaxLength:]): Ditto.
231         (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
232         (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
233         (-[DOMHTMLInputElement stepUp:]): Ditto.
234         (-[DOMHTMLInputElement stepDown:]): Ditto.
235         (-[DOMHTMLInputElement setRangeText:]): Ditto.
236         (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
237         * DOM/DOMHTMLMarqueeElement.mm:
238         (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
239         * DOM/DOMHTMLMediaElement.mm:
240         (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
241         (-[DOMHTMLMediaElement setVolume:]): Ditto.
242         * DOM/DOMHTMLOptionsCollection.mm:
243         (-[DOMHTMLOptionsCollection setLength:]): Ditto.
244         * DOM/DOMHTMLTableElement.mm:
245         (-[DOMHTMLTableElement setCaption:]): Ditto.
246         (-[DOMHTMLTableElement setTHead:]): Ditto.
247         (-[DOMHTMLTableElement setTFoot:]): Ditto.
248         (-[DOMHTMLTableElement insertRow:]): Ditto.
249         (-[DOMHTMLTableElement deleteRow:]): Ditto.
250         * DOM/DOMHTMLTableRowElement.mm:
251         (-[DOMHTMLTableRowElement insertCell:]): Ditto.
252         (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
253         * DOM/DOMHTMLTableSectionElement.mm:
254         (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
255         (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
256         * DOM/DOMHTMLTextAreaElement.mm:
257         (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
258         (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
259         (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
260         * DOM/DOMHTMLVideoElement.mm:
261         (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
262         (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
263         version (lowercase S) instead of repeating the logic from that method.
264         (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
265         * DOM/DOMTimeRanges.mm:
266         (-[DOMTimeRanges start:]): Updated exception handling.
267         (-[DOMTimeRanges end:]): Ditto.
268
269 2016-10-27  Chris Dumez  <cdumez@apple.com>
270
271         Regression(r203601): Caused crashes in iBooks
272         https://bugs.webkit.org/show_bug.cgi?id=164093
273         <rdar://problem/28745634>
274
275         Reviewed by Darin Adler.
276
277         Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
278         which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
279
280         * DOM/DOMNode.mm:
281         (-[DOMNode compareDocumentPosition:]):
282
283 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
284
285         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
286         https://bugs.webkit.org/show_bug.cgi?id=163948
287         <rdar://problem/28921433>
288
289         Reviewed by Darin Adler.
290
291         Add support for new drag and drop-related EditAction enum values.
292
293         * WebCoreSupport/WebEditorClient.mm:
294         (undoNameForEditAction):
295
296 2016-10-27  Dan Bernstein  <mitz@apple.com>
297
298         Reapplied the configuration changes from r207934 without breaking iOS builds.
299
300         * Configurations/Base.xcconfig:
301         * Configurations/WebKitLegacy.xcconfig:
302
303 2016-10-27  Dan Bernstein  <mitz@apple.com>
304
305         Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
306
307         * Configurations/Base.xcconfig:
308         * Configurations/WebKitLegacy.xcconfig:
309
310 2016-10-26  Dan Bernstein  <mitz@apple.com>
311
312         [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
313         https://bugs.webkit.org/show_bug.cgi?id=164048
314
315         Reviewed by Tim Horton.
316
317         * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
318         * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
319           headers.
320
321         * History/WebBackForwardList.h: Fixed parameter name in @param entry.
322         * Misc/WebDownload.h: Removed empty entries.
323         * Misc/WebIconDatabase.h: Remove incorrect @param entries.
324         * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
325         * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
326         * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
327         * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
328         * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
329         * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
330         * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
331           Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
332         * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
333         * WebView/WebView.h: Changed @method to @property in a couple of places.
334         * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
335
336 2016-10-26  Brian Burg  <bburg@apple.com>
337
338         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
339         https://bugs.webkit.org/show_bug.cgi?id=164046
340
341         Reviewed by Joseph Pecoraro.
342
343         * WebCoreSupport/WebInspectorClient.h:
344
345 2016-10-21  Alex Christensen  <achristensen@webkit.org>
346
347         URL::port should return Optional<uint16_t>
348         https://bugs.webkit.org/show_bug.cgi?id=163806
349
350         Reviewed by Darin Adler.
351
352         * WebCoreSupport/WebSecurityOrigin.mm:
353         (-[WebSecurityOrigin port]):
354
355 2016-10-24  Dave Hyatt  <hyatt@apple.com>
356
357         Remove CSSCharsetRule from the CSS OM
358         https://bugs.webkit.org/show_bug.cgi?id=163891
359
360         Reviewed by Darin Adler.
361
362         * DOM/DOMCSSCharsetRule.mm:
363         (-[DOMCSSCharsetRule encoding]):
364
365 2016-10-24  Youenn Fablet  <youenn@apple.com>
366
367         Activate WEB_RTC compilation flags for Mac bots
368         https://bugs.webkit.org/show_bug.cgi?id=163886
369
370         Reviewed by Eric Carlson.
371
372         * Configurations/FeatureDefines.xcconfig:
373
374 2016-10-23  Chris Dumez  <cdumez@apple.com>
375
376         addEventListener() / removeEventListener() should use a union for last parameter
377         https://bugs.webkit.org/show_bug.cgi?id=163863
378
379         Reviewed by Darin Adler.
380
381         Cast BOOL to bool to help to compiler construct the new variant-type parameter.
382
383         * DOM/DOMNode.mm:
384         (-[DOMNode addEventListener:listener:useCapture:]):
385         (-[DOMNode addEventListener:::]):
386         (-[DOMNode removeEventListener:listener:useCapture:]):
387         (-[DOMNode removeEventListener:::]):
388
389 2016-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
390
391         Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
392         https://bugs.webkit.org/show_bug.cgi?id=163460
393         <rdar://problem/28784142>
394
395         Reviewed by Darin Adler.
396
397         Handle new EditAction types for inserting/deleting pending/final compositions.
398
399         * WebCoreSupport/WebEditorClient.mm:
400         (undoNameForEditAction):
401
402 2016-10-21  Jeremy Jones  <jeremyj@apple.com>
403
404         Implement basic pointer lock behavior for WebKit and WebKit2.
405         https://bugs.webkit.org/show_bug.cgi?id=162745
406
407         Reviewed by Simon Fraser.
408
409         Add basic pointer lock functionality. User permission is not yet implemented.
410
411         * WebCoreSupport/WebChromeClient.h:
412         * WebCoreSupport/WebChromeClient.mm:
413         (WebChromeClient::requestPointerLock):
414         (WebChromeClient::requestPointerUnlock):
415
416 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
417
418         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
419         https://bugs.webkit.org/show_bug.cgi?id=163374
420
421         Reviewed by Darin Adler.
422
423         * Configurations/FeatureDefines.xcconfig:
424
425 2016-10-19  Alex Christensen  <achristensen@webkit.org>
426
427         Revert r207151
428         https://bugs.webkit.org/show_bug.cgi?id=163675
429
430         Reviewed by Brent Fulgham.
431
432         * Misc/WebDownload.mm:
433         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
434         * Misc/WebDownloadInternal.h:
435         * WebCoreSupport/WebFrameLoaderClient.mm:
436         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
437         * WebView/WebPreferences.mm:
438         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
439         * WebView/WebView.mm:
440         (-[WebView scheduleInRunLoop:forMode:]):
441         (-[WebView unscheduleFromRunLoop:forMode:]):
442
443 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
444
445         Unreviewed, rolling out r207557.
446
447         This change caused animations/font-variations tests to time
448         out on pre-Sierra Macs.
449
450         Reverted changeset:
451
452         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
453         iOS 9"
454         https://bugs.webkit.org/show_bug.cgi?id=163374
455         http://trac.webkit.org/changeset/207557
456
457 2016-10-19  Chris Dumez  <cdumez@apple.com>
458
459         Move HTML Interactive Form Validation behind an experimental flag
460         https://bugs.webkit.org/show_bug.cgi?id=163673
461
462         Reviewed by Daniel Bates.
463
464         Re-disable HTML Interactive Form Validation by default on Mac WK1.
465
466         * WebView/WebViewData.mm:
467         (-[WebViewPrivate init]):
468
469 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
470
471         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
472         https://bugs.webkit.org/show_bug.cgi?id=163374
473
474         Reviewed by Darin Adler.
475
476         * Configurations/FeatureDefines.xcconfig:
477
478 2016-10-19  Simon Fraser  <simon.fraser@apple.com>
479
480         WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
481         https://bugs.webkit.org/show_bug.cgi?id=163680
482
483         Reviewed by Dean Jackson.
484
485         Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
486
487         * WebView/WebView.mm:
488         (-[WebView _preferencesChanged:]):
489
490 2016-10-19  Darin Adler  <darin@apple.com>
491
492         Move XPath from ExceptionCode to Exception
493         https://bugs.webkit.org/show_bug.cgi?id=163656
494
495         Reviewed by Chris Dumez.
496
497         * DOM/DOMDocument.mm:
498         (wrap): Added. Helper function for wrapping a resolver.
499         (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
500         (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
501         * DOM/DOMXPathExpression.mm:
502         (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
503         * DOM/DOMXPathResult.mm:
504         (-[DOMXPathResult numberValue]): Ditto.
505         (-[DOMXPathResult stringValue]): Ditto.
506         (-[DOMXPathResult booleanValue]): Ditto.
507         (-[DOMXPathResult singleNodeValue]): Ditto.
508         (-[DOMXPathResult snapshotLength]): Ditto.
509         (-[DOMXPathResult iterateNext]): Ditto.
510         (-[DOMXPathResult snapshotItem:]): Ditto.
511
512 2016-10-18  Sam Weinig  <sam@webkit.org>
513
514         Replace std::experimental::variant with WTF::Variant (or similar)
515         https://bugs.webkit.org/show_bug.cgi?id=163626
516
517         Reviewed by Chris Dumez.
518
519         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
520         into the WTF namespace.
521
522         * DOM/DOMHTMLSelectElement.mm:
523         (-[DOMHTMLSelectElement add:before:]):
524
525 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
526
527         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
528         https://bugs.webkit.org/show_bug.cgi?id=163627
529
530         Reviewed by Dean Jackson.
531
532         Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
533
534         * WebView/WebViewPrivate.h:
535
536 2016-10-18  Dean Jackson  <dino@apple.com>
537
538         Remove CSS_SHAPES feature definition. This should always be on.
539         https://bugs.webkit.org/show_bug.cgi?id=163628
540         <rdar://problem/28834613>
541
542         Reviewed by Tim Horton.
543
544         * Configurations/FeatureDefines.xcconfig:
545
546 2016-10-18  Chris Dumez  <cdumez@apple.com>
547
548         Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
549         https://bugs.webkit.org/show_bug.cgi?id=163608
550
551         Reviewed by Ryosuke Niwa.
552
553         Update add() call sites now that it takes std::variant types in.
554
555         * DOM/DOMHTMLOptionsCollection.mm:
556         (-[DOMHTMLOptionsCollection add:index:]):
557         * DOM/DOMHTMLSelectElement.mm:
558         (-[DOMHTMLSelectElement add:before:]):
559
560 2016-10-18  Anders Carlsson  <andersca@apple.com>
561
562         Get rid of more WebHistoryItem cruft
563         https://bugs.webkit.org/show_bug.cgi?id=163623
564
565         Reviewed by Tim Horton.
566
567         * History/WebHistoryItem.mm:
568         (-[WebHistoryItem initFromDictionaryRepresentation:]):
569         * History/WebHistoryItemPrivate.h:
570
571 2016-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
572
573         Showing and hiding candidates list is very distracting after selecting word
574         https://bugs.webkit.org/show_bug.cgi?id=163609
575         <rdar://problem/28747712>
576
577         Reviewed by Tim Horton.
578
579         Introduce WebView hooks for mousedown and mouseup. See radar for more details.
580
581         * WebView/WebHTMLView.mm:
582         (-[WebHTMLView mouseDown:mouseDown:]):
583         (-[WebHTMLView mouseUp:mouseUp:]):
584         * WebView/WebView.mm:
585         (-[WebView prepareForMouseDown]):
586         (-[WebView prepareForMouseUp]):
587         * WebView/WebViewInternal.h:
588
589 2016-10-17  Anders Carlsson  <andersca@apple.com>
590
591         Move some history specific HistoryItem code to WebHistoryItem
592         https://bugs.webkit.org/show_bug.cgi?id=163567
593
594         Reviewed by Tim Horton.
595
596         * History/HistoryPropertyList.mm:
597         (HistoryPropertyListWriter::writeHistoryItem):
598         * History/WebHistory.mm:
599         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
600         * History/WebHistoryItem.mm:
601         (-[WebHistoryItem initFromDictionaryRepresentation:]):
602         * History/WebHistoryItemInternal.h:
603         * WebCoreSupport/WebFrameLoaderClient.mm:
604         (addRedirectURL):
605         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
606
607 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
608
609         [MediaStream] Resolve constraints and enumerate devices in the UI process
610         https://bugs.webkit.org/show_bug.cgi?id=162147
611         <rdar://problem/28803569>
612
613         Reviewed by Darin Adler.
614
615         * WebCoreSupport/WebUserMediaClient.h:
616         * WebCoreSupport/WebUserMediaClient.mm:
617         (AddPermissionCheckToMap):
618         (RemovePermissionCheckFromMap):
619         (WebUserMediaClient::pageDestroyed):
620         (WebUserMediaClient::requestUserMediaAccess):
621         (WebUserMediaClient::enumerateMediaDevices):
622         (WebUserMediaClient::cancelMediaDevicesEnumerationRequest):
623         (-[WebUserMediaPolicyListener allow]):
624         (-[WebUserMediaPolicyListener deny]):
625         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
626         (-[WebUserMediaPolicyCheckerListener cancelMediaDevicesEnumerationRequest]):
627         (-[WebUserMediaPolicyCheckerListener allow]):
628         (-[WebUserMediaPolicyCheckerListener deny]):
629         (WebUserMediaClient::checkUserMediaPermission): Deleted.
630         (WebUserMediaClient::cancelUserMediaPermissionCheck): Deleted.
631         (-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]): Deleted.
632         (-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]): Deleted.
633
634 2016-10-17  Antti Koivisto  <antti@apple.com>
635
636         Rename setNeedsStyleRecalc to invalidateStyle
637         https://bugs.webkit.org/show_bug.cgi?id=163542
638
639         Reviewed by Darin Adler.
640
641         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
642         (-[WebHostedNetscapePluginView createPluginLayer]):
643         * Plugins/WebNetscapePluginView.mm:
644         (-[WebNetscapePluginView createPlugin]):
645
646 2016-10-17  Jeremy Jones  <jeremyj@apple.com>
647
648         Enable keyboard in fullscreen.
649         https://bugs.webkit.org/show_bug.cgi?id=163146
650
651         Reviewed by Jer Noble.
652
653         Allow keyboard in fullscreen.
654
655         * WebView/WebView.mm:
656         (-[WebView _supportsFullScreenForElement:withKeyboard:]):
657
658 2016-10-17  Chris Dumez  <cdumez@apple.com>
659
660         Move form.reportValidity() behind InteractiveFormValidation setting
661         https://bugs.webkit.org/show_bug.cgi?id=163550
662
663         Reviewed by Darin Adler.
664
665         Enable InteractiveFormValidation setting by default and link it to
666         RuntimeEnabledFeatures so we can use it in the IDL.
667
668         * WebView/WebView.mm:
669         (-[WebView _preferencesChanged:]):
670         * WebView/WebViewData.mm:
671         (-[WebViewPrivate init]):
672
673 2016-10-17  Anders Carlsson  <andersca@apple.com>
674
675         Fix iOS build.
676
677         * History/WebBackForwardList.mm:
678         (-[WebBackForwardList dictionaryRepresentation]):
679
680 2016-10-17  Anders Carlsson  <andersca@apple.com>
681
682         CTTE some of the BackForwardList member functions
683         https://bugs.webkit.org/show_bug.cgi?id=163555
684
685         Reviewed by Dan Bernstein.
686
687         * History/BackForwardList.h:
688         (BackForwardList::entries):
689         * History/BackForwardList.mm:
690         (BackForwardList::removeItem):
691         (BackForwardList::containsItem):
692         (BackForwardList::entries): Deleted.
693         * History/WebBackForwardList.mm:
694         (-[WebBackForwardList removeItem:]):
695         (-[WebBackForwardList containsItem:]):
696         (-[WebBackForwardList description]):
697
698 2016-10-17  Anders Carlsson  <andersca@apple.com>
699
700         Remove WEBCORE_EXPORT from BackForwardList, it lives in WebKit now
701         https://bugs.webkit.org/show_bug.cgi?id=163551
702
703         Reviewed by Tim Horton.
704
705         * History/BackForwardList.h:
706
707 2016-10-16  Darin Adler  <darin@apple.com>
708
709         Move CSS classes from ExceptionCode to Exception
710         https://bugs.webkit.org/show_bug.cgi?id=163494
711
712         Reviewed by Sam Weinig.
713
714         * DOM/DOMCSSMediaRule.mm:
715         (-[DOMCSSMediaRule insertRule:index:]): Use raiseOnDOMError
716         the new way to handle ExceptionOr instead of ExceptionCode.
717         (-[DOMCSSMediaRule deleteRule:]): Ditto.
718         * DOM/DOMCSSPrimitiveValue.mm:
719         (-[DOMCSSPrimitiveValue setFloatValue:floatValue:]): Ditto.
720         (-[DOMCSSPrimitiveValue getFloatValue:]): Ditto.
721         (-[DOMCSSPrimitiveValue setStringValue:stringValue:]): Ditto.
722         (-[DOMCSSPrimitiveValue getStringValue]): Ditto.
723         (-[DOMCSSPrimitiveValue getCounterValue]): Ditto.
724         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
725         (-[DOMCSSPrimitiveValue getRGBColorValue]): Ditto.
726         * DOM/DOMCSSRule.mm:
727         (-[DOMCSSRule setCssText:]): Ditto.
728         * DOM/DOMCSSStyleDeclaration.mm:
729         (-[DOMCSSStyleDeclaration setCssText:]): Ditto.
730         (-[DOMCSSStyleDeclaration removeProperty:]): Ditto.
731         (-[DOMCSSStyleDeclaration setProperty:value:priority:]): Ditto.
732         * DOM/DOMCSSStyleSheet.mm:
733         (-[DOMCSSStyleSheet insertRule:index:]): Ditto.
734         (-[DOMCSSStyleSheet deleteRule:]): Ditto.
735         (-[DOMCSSStyleSheet addRule:style:index:]): Ditto.
736         (-[DOMCSSStyleSheet removeRule:]): Ditto.
737         * DOM/DOMCSSValue.mm:
738         (-[DOMCSSValue setCssText:]): Ditto.
739         * DOM/DOMMediaList.mm:
740         (-[DOMMediaList setMediaText:]): Ditto.
741         (-[DOMMediaList deleteMedium:]): Ditto.
742         (-[DOMMediaList appendMedium:]): Ditto.
743
744         * DOM/ExceptionHandlers.h: Added an overload of raiseDOMException
745         that works with a WebCore::Exception&& and overloads of
746         raiseOnDOMError that work with WebCore::ExceptionOr&&.
747         * DOM/ExceptionHandlers.mm:
748         (raiseDOMException): Implemented the new version.
749
750 2016-10-15  Dan Bernstein  <mitz@apple.com>
751
752         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
753         https://bugs.webkit.org/show_bug.cgi?id=163492
754         <rdar://problem/28654799>
755
756         Reviewed by Darin Adler.
757
758         Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm
759
760         * WebView/WebHTMLView.mm:
761         (createMenuItem): Set the tag for items that have submenus as well.
762
763 2016-10-14  Anders Carlsson  <andersca@apple.com>
764
765         Clean up BackForwardClient
766         https://bugs.webkit.org/show_bug.cgi?id=163454
767
768         Reviewed by Sam Weinig.
769
770         * History/BackForwardList.h:
771         Remove override keywords.
772
773         * History/BackForwardList.mm:
774         (BackForwardList::clearAllPageCaches): Deleted.
775         Remove this, it's no longer used.
776
777         * WebView/WebView.mm:
778         (-[WebView _clearBackForwardCache]): Deleted.
779         * WebView/WebViewPrivate.h:
780         Remove SPI that's no longer used by anyone.
781
782 2016-10-13  Anders Carlsson  <andersca@apple.com>
783
784         Move BackForwardList from WebCore to WebKitLegacy
785         https://bugs.webkit.org/show_bug.cgi?id=163418
786
787         Reviewed by Tim Horton.
788
789         * History/BackForwardList.h: Renamed from Source/WebCore/history/BackForwardList.h.
790         (BackForwardList::create):
791         (BackForwardList::webView):
792         * History/BackForwardList.mm: Renamed from Source/WebCore/history/BackForwardList.cpp.
793         (BackForwardList::BackForwardList):
794         (BackForwardList::close):
795         (BackForwardList::containsItem):
796         * History/WebBackForwardList.mm:
797         (kit):
798         (-[WebBackForwardList initWithBackForwardList:]):
799         (-[WebBackForwardList setPageCacheSize:]):
800         (-[WebBackForwardList pageCacheSize]):
801         * History/WebBackForwardListInternal.h:
802         * WebCoreSupport/WebFrameLoaderClient.mm:
803         * WebView/WebFrameView.mm:
804         * WebView/WebView.mm:
805         (-[WebView _commonInitializationWithFrameName:groupName:]):
806         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
807
808 2016-10-13  Anders Carlsson  <andersca@apple.com>
809
810         Get rid of the HistoryItemVector typedef
811         https://bugs.webkit.org/show_bug.cgi?id=163398
812
813         Reviewed by Beth Dakin.
814
815         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
816
817         * History/WebBackForwardList.mm:
818         (-[WebBackForwardList dictionaryRepresentation]):
819         (vectorToNSArray):
820         (-[WebBackForwardList backListWithLimit:]):
821         (-[WebBackForwardList forwardListWithLimit:]):
822         (-[WebBackForwardList description]):
823         * History/WebHistoryItem.mm:
824         (-[WebHistoryItem description]):
825
826 2016-10-12  Chris Dumez  <cdumez@apple.com>
827
828         [Web IDL] Drop support for legacy [ConstructorConditional=*]
829         https://bugs.webkit.org/show_bug.cgi?id=163368
830
831         Reviewed by Ryosuke Niwa.
832
833         Drop ENABLE_DOM4_EVENTS_CONSTRUCTOR compiler flag.
834
835         * Configurations/FeatureDefines.xcconfig:
836
837 2016-10-12  Beth Dakin  <bdakin@apple.com>
838
839         Adobe Contribute CS 6.5 Trial crashes on launch
840         https://bugs.webkit.org/show_bug.cgi?id=163365
841         -and corresponding-
842         <rdar://problem/28732731>
843
844         Reviewed by Tim Horton.
845
846         * Carbon/CarbonWindowFrame.m:
847         (-[CarbonWindowFrame contentFill]):
848
849 2016-10-11  Daniel Bates  <dabates@apple.com>
850
851         Attempt to fix the Apple Internal Mac build following r207159
852         (https://bugs.webkit.org/show_bug.cgi?id=163244)
853
854         * WebView/WebView.mm:
855         (shouldRequireUserGestureToLoadVideo):
856
857 2016-10-11  Daniel Bates  <dabates@apple.com>
858
859         REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
860         https://bugs.webkit.org/show_bug.cgi?id=163259
861         <rdar://problem/28680515>
862
863         Reviewed by Jer Noble.
864
865         In WebKit1 on iOS we want to require user action to load and play videos by default and
866         allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
867         Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
868         can load and play without being initiated by a user action.
869
870         * WebView/WebPreferences.mm:
871         (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
872         WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
873         preference takes precedence over the values of its replacement preferences
874         WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
875
876 2016-10-11  Daniel Bates  <dabates@apple.com>
877
878         [iOS] REGRESSION (r197953): User gesture required to load video in iOS 9-built apps
879         https://bugs.webkit.org/show_bug.cgi?id=163244
880         <rdar://problem/27250015>
881
882         Reviewed by Jer Noble.
883
884         Enable or disable the Setting::requiresUserGestureToLoadVideo() in legacy WebKit depending
885         on the version of iOS SDK that the app was linked against. We require a user gesture to
886         begin loading a video as of iOS 10.
887
888         * WebView/WebView.mm:
889         (shouldRequireUserGestureToLoadVideo):
890         (-[WebView _preferencesChanged:]): Modified to pass the WebKit requiresUserGestureToLoadVideo
891         preference to WebCore.
892
893 2016-10-11  Alex Christensen  <achristensen@webkit.org>
894
895         Remove dead networking code
896         https://bugs.webkit.org/show_bug.cgi?id=163263
897
898         Reviewed by Daniel Bates.
899
900         * Misc/WebDownload.mm:
901         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
902         * Misc/WebDownloadInternal.h:
903         * WebCoreSupport/WebFrameLoaderClient.mm:
904         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
905         * WebView/WebPreferences.mm:
906         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
907         * WebView/WebView.mm:
908         (-[WebView scheduleInRunLoop:forMode:]):
909         (-[WebView unscheduleFromRunLoop:forMode:]):
910
911 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
912
913         Add ENABLE_ENCRYPTED_MEDIA configuration option
914         https://bugs.webkit.org/show_bug.cgi?id=163219
915
916         Reviewed by Darin Adler.
917
918         * Configurations/FeatureDefines.xcconfig:
919         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
920         to enable or disable the new EME implementation at build-time.
921
922 2016-10-10  Darin Adler  <darin@apple.com>
923
924         Move NotificationCenter from legacy to new DOM exceptions
925         https://bugs.webkit.org/show_bug.cgi?id=163217
926
927         Reviewed by Chris Dumez.
928
929         * WebView/WebView.mm:
930         (-[WebView _notificationIDForTesting:]): Pass reference to page rather than pointer.
931
932 2016-10-09  Wenson Hsieh  <wenson_hsieh@apple.com>
933
934         Support InputEvent.inputType for the new InputEvent spec
935         https://bugs.webkit.org/show_bug.cgi?id=163025
936         <rdar://problem/28658092>
937
938         Reviewed by Darin Adler.
939
940         Accounts for some changes to the EditAction enum in nameForEditAction. See WebCore ChangeLog
941         entry for more details.
942
943         * WebCoreSupport/WebEditorClient.mm:
944         (undoNameForEditAction):
945
946 2016-10-06  Darin Adler  <darin@apple.com>
947
948         Next step on moving to modern way to return DOM exceptions
949         https://bugs.webkit.org/show_bug.cgi?id=163016
950
951         Reviewed by Ryosuke Niwa.
952
953         * DOM/DOMDOMImplementation.mm:
954         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated for
955         name change from takeReturnValue to releaseReturnValue.
956         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
957
958 2016-10-07  Simon Fraser  <simon.fraser@apple.com>
959
960         [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
961         https://bugs.webkit.org/show_bug.cgi?id=163154
962         rdar://problem/28674216
963
964         Reviewed by Tim Horton.
965         
966         r55159 added code to counteract AppKit's adjustment of dirty regions during scrolling,
967         by offsetting the dirty rect in -setNeedsDisplayInRect: if the call happens during
968         the NSViewBoundsDidChangeNotification handling.
969         
970         However, AppKit only does dirty region adjustment in the code path that blits ("copy
971         on scroll"), so r55159 produces incorrect behavior in, for example, layer-backed views.
972         
973         Fix by overriding -[NSClipView _canCopyOnScrollForDeltaX:deltaY:] to know if a single
974         scroll is going to blit, and only do adjustments in -setNeedsDisplayInRect: if it is.
975
976         * WebView/WebClipView.h:
977         * WebView/WebClipView.mm:
978         (-[WebClipView _immediateScrollToPoint:]):
979         (-[WebClipView _canCopyOnScrollForDeltaX:deltaY:]):
980         (-[WebClipView currentScrollIsBlit]):
981         * WebView/WebHTMLView.mm:
982         (-[WebHTMLView setNeedsDisplayInRect:]):
983         (-[WebHTMLView drawRect:]):
984
985 2016-10-06  Youenn Fablet  <youenn@apple.com>
986
987         CachedResource client handling methods should take reference
988         https://bugs.webkit.org/show_bug.cgi?id=163014
989
990         Reviewed by Alex Christensen.
991
992         * WebView/WebHTMLView.mm:
993         (promisedDataClient):
994
995 2016-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
996
997         Put variation fonts work behind a compile-time flag
998         https://bugs.webkit.org/show_bug.cgi?id=162949
999
1000         Reviewed by Simon Fraser.
1001
1002         * Configurations/FeatureDefines.xcconfig:
1003
1004 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
1005
1006         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
1007         https://bugs.webkit.org/show_bug.cgi?id=162903
1008
1009         Reviewed by Alex Christensen.
1010
1011         Rename build guards for the remaining implementation of the legacy EME API
1012         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
1013         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
1014
1015         * Configurations/FeatureDefines.xcconfig:
1016         * WebView/WebPreferences.mm:
1017         (+[WebPreferences initialize]):
1018         * WebView/WebView.mm:
1019         (-[WebView _preferencesChanged:]):
1020
1021 2016-10-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1022
1023         The dragged image should be the current frame only of the animated image
1024         https://bugs.webkit.org/show_bug.cgi?id=162109
1025
1026         Reviewed by Tim Horton.
1027
1028         * DOM/DOM.mm:
1029         (-[DOMElement image]): Call the Image function with its new name.
1030         (-[DOMElement _imageTIFFRepresentation]): Ditto.
1031         * Misc/WebElementDictionary.mm:
1032         (-[WebElementDictionary _image]): Call the Image function with its new name.
1033         * Misc/WebIconDatabase.mm:
1034         (-[WebIconDatabase defaultIconWithSize:]): Call snapshotNSImage() to create the icon image.
1035         (webGetNSImage): Call the Image function with its new name.
1036         * WebCoreSupport/WebContextMenuClient.mm:
1037         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call snapshotNSImage() instead of nsImage()..
1038         (WebContextMenuClient::contextMenuForEvent): Ditto.
1039         * WebView/WebHTMLView.mm:
1040         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
1041
1042 2016-10-02  Ryan Haddad  <ryanhaddad@apple.com>
1043
1044         Unreviewed, rolling out r206683.
1045
1046         This change caused API test WebKit2.FindMatches to fail on
1047         Mac.
1048
1049         Reverted changeset:
1050
1051         "The dragged image should be the current frame only of the
1052         animated image"
1053         https://bugs.webkit.org/show_bug.cgi?id=162109
1054         http://trac.webkit.org/changeset/206683
1055
1056 2016-09-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
1057
1058         The dragged image should be the current frame only of the animated image
1059         https://bugs.webkit.org/show_bug.cgi?id=162109
1060
1061         Reviewed by Tim Horton.
1062
1063         * DOM/DOM.mm:
1064         (-[DOMElement image]): Call the Image function with its new name.
1065         (-[DOMElement _imageTIFFRepresentation]): Ditto.
1066         * Misc/WebElementDictionary.mm:
1067         (-[WebElementDictionary _image]): Call the Image function with its new name.
1068         * Misc/WebIconDatabase.mm:
1069         (-[WebIconDatabase defaultIconWithSize:]): Call currentFrameNSImage() to create the icon image.
1070         (webGetNSImage): Call the Image function with its new name.
1071         * WebCoreSupport/WebContextMenuClient.mm:
1072         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call currentFrameNSImage() instead of nsImage()..
1073         (WebContextMenuClient::contextMenuForEvent): Ditto.
1074         * WebView/WebHTMLView.mm:
1075         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
1076
1077 2016-09-27  Jer Noble  <jer.noble@apple.com>
1078
1079         Remove deprecated ENCRYPTED_MEDIA implementation.
1080         https://bugs.webkit.org/show_bug.cgi?id=161010
1081
1082         Remove ENABLE_ENCRYPTED_MEDIA.
1083
1084         Reviewed by Eric Carlson.
1085
1086         * Configurations/FeatureDefines.xcconfig:
1087
1088 2016-09-26  Daniel Bates  <dabates@apple.com>
1089
1090         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
1091         https://bugs.webkit.org/show_bug.cgi?id=162365
1092
1093         Reviewed by Simon Fraser.
1094
1095         * Configurations/FeatureDefines.xcconfig:
1096         * WebView/WebFrame.mm:
1097         * WebView/WebPreferences.mm:
1098         (+[WebPreferences initialize]):
1099         * WebView/WebView.mm:
1100         (-[WebView _preferencesChanged:]):
1101
1102 2016-09-25  Antti Koivisto  <antti@apple.com>
1103
1104         AuthorStyleSheets shouldn't trigger synchronous style resolutions
1105         https://bugs.webkit.org/show_bug.cgi?id=162532
1106
1107         Reviewed by Darin Adler.
1108
1109         * WebView/WebHTMLView.mm:
1110         (-[WebHTMLView reapplyStyles]):
1111         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1112
1113 2016-09-24  Antti Koivisto  <antti@apple.com>
1114
1115         Move stylesheet change logic from Document to AuthorStyleSheets
1116         https://bugs.webkit.org/show_bug.cgi?id=162488
1117
1118         Reviewed by Andreas Kling.
1119
1120         * WebView/WebHTMLView.mm:
1121         (-[WebHTMLView reapplyStyles]):
1122         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1123
1124 2016-09-23  Caitlin Potter  <caitp@igalia.com>
1125
1126         [JSC] Implement parsing of Async Functions
1127         https://bugs.webkit.org/show_bug.cgi?id=161409
1128
1129         Reviewed by Yusuke Suzuki.
1130
1131         * Configurations/FeatureDefines.xcconfig:
1132
1133 2016-09-23  Commit Queue  <commit-queue@webkit.org>
1134
1135         Unreviewed, rolling out r206311.
1136         https://bugs.webkit.org/show_bug.cgi?id=162495
1137
1138         Broke internal iOS build (Requested by anttik on #webkit).
1139
1140         Reverted changeset:
1141
1142         "Move stylesheet change logic from Document to
1143         AuthorStyleSheets"
1144         https://bugs.webkit.org/show_bug.cgi?id=162488
1145         http://trac.webkit.org/changeset/206311
1146
1147 2016-09-23  Antoine Quint  <graouts@apple.com>
1148
1149         Add a new runtime flag for work on modern media controls (off by default)
1150         https://bugs.webkit.org/show_bug.cgi?id=162420
1151         <rdar://problem/27989489>
1152
1153         Reviewed by Eric Carlson.
1154
1155         * WebView/WebPreferenceKeysPrivate.h:
1156         * WebView/WebPreferences.mm:
1157         (-[WebPreferences modernMediaControlsEnabled]):
1158         (-[WebPreferences setModernMediaControlsEnabled:]):
1159         * WebView/WebPreferencesPrivate.h:
1160         * WebView/WebView.mm:
1161         (-[WebView _preferencesChanged:]):
1162
1163 2016-09-21  Anders Carlsson  <andersca@apple.com>
1164
1165         Support openPaymentSetup API on ApplePaySession object
1166         https://bugs.webkit.org/show_bug.cgi?id=162357
1167         rdar://problem/26776939
1168
1169         Reviewed by Tim Horton.
1170
1171         Add openPaymentSetup stub.
1172
1173         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1174         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1175         (WebPaymentCoordinatorClient::openPaymentSetup):
1176
1177 2016-09-19  Daniel Bates  <dabates@apple.com>
1178
1179         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
1180         https://bugs.webkit.org/show_bug.cgi?id=162167
1181
1182         Reviewed by Simon Fraser.
1183
1184         * Configurations/FeatureDefines.xcconfig:
1185
1186 2016-09-19  Joseph Pecoraro  <pecoraro@apple.com>
1187
1188         Web Inspector: Bring the inspected page's window forward when activating element search
1189         https://bugs.webkit.org/show_bug.cgi?id=162114
1190         <rdar://problem/28349357>
1191
1192         Reviewed by Brian Burg.
1193
1194         * WebCoreSupport/WebInspectorClient.mm:
1195         (WebInspectorClient::didSetSearchingForNode):
1196         When element search is activated bring the window
1197         containing the inspected page to the foreground.
1198
1199 2016-09-15  Brady Eidson  <beidson@apple.com>
1200
1201         WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
1202         <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
1203
1204         Reviewed by Brent Fulgham. 
1205
1206         * WebCoreSupport/WebFrameLoaderClient.h:
1207         * WebCoreSupport/WebFrameLoaderClient.mm:
1208         (WebFrameLoaderClient::dispatchDidCommitLoad):
1209
1210 2016-09-15  Anders Carlsson  <andersca@apple.com>
1211
1212         This was supposed to be committed with the previous patch!
1213
1214         * Plugins/WebBasePluginPackage.mm:
1215         (pathByResolvingSymlinksAndAliases): Deleted.
1216
1217 2016-09-15  Anders Carlsson  <andersca@apple.com>
1218
1219         Replace use of Carbon file system APIs in plug-in loading
1220         https://bugs.webkit.org/show_bug.cgi?id=162040
1221         rdar://problem/6017896
1222
1223         Reviewed by Sam Weinig.
1224
1225         * Plugins/WebBasePluginPackage.mm:
1226         (-[WebBasePluginPackage initWithPath:]):
1227         Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
1228         to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).
1229
1230 2016-09-15  Beth Dakin  <bdakin@apple.com>
1231
1232         Need hasMarkedText on Mac
1233         https://bugs.webkit.org/show_bug.cgi?id=162026
1234         -and corresponding-
1235         rdar://problem/28272353
1236
1237         Reviewed by Anders Carlsson.
1238
1239         * WebView/WebHTMLViewInternal.h:
1240
1241 2016-09-12  Dean Jackson  <dino@apple.com>
1242
1243         Replace RGBA32 with Color in member variables
1244         https://bugs.webkit.org/show_bug.cgi?id=161856
1245         <rdar://problem/28254324>
1246
1247         Reviewed by Simon Fraser.
1248
1249         In preparation for the Color class to become more than
1250         just a 4-byte RGBA value, I went through a few places
1251         that were using the RGBA32 type directly, and replaced
1252         them with Color. This will make some objects a little
1253         bigger e.g. BorderValue and its friends.
1254
1255         I mostly looked at the places that were using RGBA32 as
1256         a member variable. There is still a lot of RGBA32 use
1257         around the project, in particular the CSS parser.
1258
1259         There should be no behaviour change.
1260
1261         * Misc/WebKitNSStringExtras.mm:
1262         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Explicitly
1263         call a Color constructor, rather than passing an RGBA32.
1264
1265 2016-09-13  Chris Dumez  <cdumez@apple.com>
1266
1267         Drop support for <isindex>
1268         https://bugs.webkit.org/show_bug.cgi?id=7139
1269
1270         Reviewed by Ryosuke Niwa.
1271
1272         Drop references to isindex.
1273
1274         * WebCoreSupport/WebEditorClient.mm:
1275         (attributesForAttributedStringConversion):
1276         * WebView/WebHTMLView.mm:
1277         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1278
1279 2016-09-12  Chris Dumez  <cdumez@apple.com>
1280
1281         Switch remaining users of Document::inPageCache() to pageCacheState()
1282         https://bugs.webkit.org/show_bug.cgi?id=161865
1283
1284         Reviewed by Darin Adler.
1285
1286         Switch remaining users of Document::inPageCache() to pageCacheState() as
1287         the former one is confusing (given that it returns true while the
1288         pagehide event is being fired).
1289
1290         * WebView/WebHTMLView.mm:
1291         (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]):
1292         (-[WebHTMLView setNeedsLayout:]):
1293         (-[WebHTMLView setNeedsToApplyStyles:]):
1294
1295 2016-09-09  Tim Horton  <timothy_horton@apple.com>
1296
1297         Text replacement candidates don't always overwrite the entire original string
1298         https://bugs.webkit.org/show_bug.cgi?id=161779
1299         <rdar://problem/28033492>
1300
1301         Reviewed by Simon Fraser.
1302
1303         * WebCoreSupport/WebEditorClient.mm:
1304         (WebEditorClient::requestCandidatesForSelection):
1305         Make use of the shared implementation of contextRangeForCandidateRequest.
1306
1307 2016-09-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
1308
1309         Move the BitmapImage platform dependent code to a new file named NativeImage[CG|Cairo].cpp
1310         https://bugs.webkit.org/show_bug.cgi?id=158684
1311
1312         Reviewed by Simon Fraser.
1313
1314         * DOM/DOM.mm:
1315         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1316         * Misc/WebCache.mm:
1317         (+[WebCache imageForURL:]):
1318         Replace BitmapImage::getCGImageRef() with BitmapImage::nativeImage().
1319
1320 2016-09-07  Joseph Pecoraro  <pecoraro@apple.com>
1321
1322         [Mac] Address some clang static analyzer warnings in WebKit
1323         https://bugs.webkit.org/show_bug.cgi?id=161597
1324
1325         Reviewed by Darin Adler.
1326
1327         * Misc/WebIconDatabase.h:
1328         Remove unused instance variable. It has not been used since r16005 (2006)!
1329
1330         * Misc/WebSharingServicePickerController.mm:
1331         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1332         Address array leak.
1333
1334         * WebCoreSupport/WebSelectionServiceController.mm:
1335         (WebSelectionServiceController::hasRelevantSelectionServices):
1336         Address attachment and cell leak.
1337
1338         * WebView/WebFullScreenController.h:
1339         * WebView/WebImmediateActionController.h:
1340         Remove unused instance variables.
1341
1342 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
1343
1344         Enable the <meter> element on iOS
1345         https://bugs.webkit.org/show_bug.cgi?id=161714
1346         rdar://problem/8978410
1347
1348         Reviewed by Tim Horton.
1349
1350         Define ENABLE_METER_ELEMENT unconditionally now.
1351
1352         * Configurations/FeatureDefines.xcconfig:
1353
1354 2016-09-07  Mark Lam  <mark.lam@apple.com>
1355
1356         Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
1357         https://bugs.webkit.org/show_bug.cgi?id=161498
1358
1359         Reviewed by Geoffrey Garen.
1360
1361         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1362         (WebKit::NetscapePluginInstanceProxy::evaluate):
1363         (WebKit::NetscapePluginInstanceProxy::invoke):
1364         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1365         (WebKit::NetscapePluginInstanceProxy::construct):
1366         (WebKit::NetscapePluginInstanceProxy::getProperty):
1367         (WebKit::NetscapePluginInstanceProxy::setProperty):
1368         (WebKit::NetscapePluginInstanceProxy::removeProperty):
1369         (WebKit::NetscapePluginInstanceProxy::hasProperty):
1370         (WebKit::NetscapePluginInstanceProxy::hasMethod):
1371         (WebKit::NetscapePluginInstanceProxy::enumerate):
1372         * WebView/WebView.mm:
1373         (aeDescFromJSValue):
1374
1375 2016-09-07  Youenn Fablet  <youenn@apple.com>
1376
1377         [Streams API] Separate compile flag for ReadableStream and WritableStream
1378         https://bugs.webkit.org/show_bug.cgi?id=161044
1379
1380         Reviewed by Alex Christensen.
1381
1382         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
1383
1384         * Configurations/FeatureDefines.xcconfig:
1385
1386 2016-09-06  Chris Dumez  <cdumez@apple.com>
1387
1388         Add support for input.minLength / textArea.minLength
1389         https://bugs.webkit.org/show_bug.cgi?id=161644
1390
1391         Reviewed by Darin Adler.
1392
1393         Update ObjC bindings to reflect method renaming.
1394
1395         * DOM/DOMHTMLInputElement.mm:
1396         (-[DOMHTMLInputElement maxLength]):
1397         (-[DOMHTMLInputElement setMaxLength:]):
1398         * DOM/DOMHTMLTextAreaElement.mm:
1399         (-[DOMHTMLTextAreaElement maxLength]):
1400         (-[DOMHTMLTextAreaElement setMaxLength:]):
1401
1402 2016-09-06  Dan Bernstein  <mitz@apple.com>
1403
1404         <rdar://problem/8064563> Ugly NSLog in DOMInternal.mm
1405
1406         Rubber-stamped by Anders Carlsson.
1407
1408         * DOM/DOMInternal.mm:
1409         (-[WebScriptObject _initializeScriptDOMNodeImp]): Removed useless call to NSLog.
1410
1411 2016-09-06  Ryan Haddad  <ryanhaddad@apple.com>
1412
1413         Unreviewed, rolling out r205407.
1414
1415         Not the correct way to implement this functionality
1416
1417         Reverted changeset:
1418
1419         "Consult with the FrameLoaderClient about whether or not
1420         content extensions should be enabled when loading this URL."
1421         https://bugs.webkit.org/show_bug.cgi?id=161441
1422         http://trac.webkit.org/changeset/205407
1423
1424 2016-09-05  Darin Adler  <darin@apple.com>
1425
1426         More bindings improvements, particularly things not needed for JavaScript bindings
1427         https://bugs.webkit.org/show_bug.cgi?id=161572
1428
1429         Reviewed by Sam Weinig.
1430
1431         * DOM/DOMDOMImplementation.mm:
1432         (-[DOMImplementation hasFeature:version:]): Call SVGTests::hasFeatureForLegacyBindings
1433         instead of DOMImplementation::hasFeature. Also removed JSMainThreadNullState
1434         since this does not do anything that can invoke JavaScript.
1435
1436         * DOM/DOMDocument.mm:
1437         (-[DOMDocument defaultCharset]): Call defaultCharsetForLegacyBindings. Also removed
1438         JSMainThreadNullState.
1439
1440         * DOM/DOMDocumentType.mm:
1441         (-[DOMDocumentType entities]): Changed to simply return nil; same behavior as before,
1442         but with no dependency on WebCore. Also removed JSMainThreadNullState.
1443         (-[DOMDocumentType notations]): Ditto.
1444         (-[DOMDocumentType internalSubset]): Ditto, except empty string rather than nil.
1445
1446         * DOM/DOMNode.mm:
1447         (-[DOMNode isSupported:version:]): Call SVGTests::hasFeatureForLegacyBindings
1448         instead of Node::isSupportedForBindings. Also removed JSMainThreadNullState.
1449
1450 2016-09-04  Joseph Pecoraro  <pecoraro@apple.com>
1451
1452         Remove unnecessary RetainPtr.
1453
1454         Review comments on earlier change.
1455
1456         * WebView/WebImmediateActionController.mm:
1457         (-[WebImmediateActionController _defaultAnimationController]):
1458
1459 2016-09-03  Darin Adler  <darin@apple.com>
1460
1461         Streamline DOMImplementation, and move it to our new DOM exception system
1462         https://bugs.webkit.org/show_bug.cgi?id=161295
1463
1464         Reviewed by Ryosuke Niwa.
1465
1466         * DOM/DOMDOMImplementation.mm:
1467         (unwrap): Added. Use this instead of the IMPL macro.
1468         (-[DOMImplementation dealloc]): Updated to use unwrap.
1469         (-[DOMImplementation hasFeature:version:]): Ditto.
1470         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated to work with
1471         ExceptionOr.
1472         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
1473         (-[DOMImplementation createCSSStyleSheet:media:]): Removed exception logic since
1474         this function can no longer raise an exception.
1475         (-[DOMImplementation createHTMLDocument:]): Updated to use unwrap.
1476         (-[DOMImplementation hasFeature::]): Changed to call the non-deprecated version
1477         rather than duplicating its implementation. Also moved into the category as defined
1478         in the header.
1479         (-[DOMImplementation createDocumentType:::]): Ditto.
1480         (-[DOMImplementation createDocument:::]): Ditto.
1481         (-[DOMImplementation createCSSStyleSheet::]): Ditto.
1482
1483         * DOM/DOMDocument.mm: Removed unneeded include of DOMImplementation.h.
1484         (-[DOMDocument setXmlStandalone:]): Updated since setXMLStandalone no longer can
1485         raise an exception.
1486
1487         * WebView/WebFrame.mm:
1488         (-[WebFrame _canProvideDocumentSource]): Updated to use isTextMIMEType in its new
1489         location in MIMETypeRegistry instead of in DOMImplementation.
1490
1491 2016-09-03  Brian Weinstein  <bweinstein@apple.com>
1492
1493         Implement a stub version of FrameLoaderClient::shouldUseContentExtensionsForURL.
1494         https://bugs.webkit.org/show_bug.cgi?id=16144
1495
1496         Reviewed by Darin Adler.
1497
1498         * WebCoreSupport/WebFrameLoaderClient.h:
1499
1500 2016-09-02  Beth Dakin  <bdakin@apple.com>
1501
1502         Need to updateEditorState if an element change edit-ability without changing 
1503         selection
1504         https://bugs.webkit.org/show_bug.cgi?id=161546
1505         -and corresponding-
1506         rdar://problem/27806012
1507
1508         Reviewed by Ryosuke Niwa.
1509
1510         Every time WebEditorClient::respondToChangedSelection is called, we now save 
1511         whether the last state was contentEditable. That way in 
1512         updateEditorStateAfterLayoutIfNeeded() we can assess whether or not edit-ability 
1513         has changed. 
1514
1515         * WebCoreSupport/WebEditorClient.h:
1516         * WebCoreSupport/WebEditorClient.mm:
1517         (WebEditorClient::respondToChangedSelection):
1518         (WebEditorClient:: updateEditorStateAfterLayoutIfEditabilityChanged):
1519
1520 2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
1521
1522         [Mac] RetainPtr misuse, AnimationController leaks
1523         https://bugs.webkit.org/show_bug.cgi?id=161552
1524
1525         Reviewed by Tim Horton.
1526
1527         * WebView/WebImmediateActionController.mm:
1528         (-[WebImmediateActionController _defaultAnimationController]):
1529
1530 2016-07-08  Jer Noble  <jer.noble@apple.com>
1531
1532         Refactor WebPlaybackSessionModelMediaElement to be client based.
1533         https://bugs.webkit.org/show_bug.cgi?id=159580
1534
1535         Reviewed by Eric Carlson.
1536
1537         No longer necessary to tell the models and interfaces about each other.
1538
1539         * WebView/WebView.mm:
1540         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1541         (-[WebView _clearPlaybackControlsManager]):
1542
1543 2016-09-01  Dan Bernstein  <mitz@apple.com>
1544
1545         Build fix.
1546
1547         * Configurations/FeatureDefines.xcconfig:
1548
1549 2016-09-01  Myles C. Maxfield  <mmaxfield@apple.com>
1550
1551         Clean up TextRun-related code
1552         https://bugs.webkit.org/show_bug.cgi?id=161473
1553
1554         Reviewed by Simon Fraser.
1555
1556         Remove unused #includes.
1557
1558         * WebCoreSupport/WebDragClient.mm:
1559         * WebView/WebView.mm:
1560
1561 2016-08-31  Keith Rollin  <krollin@apple.com>
1562
1563         WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
1564         https://bugs.webkit.org/show_bug.cgi?id=160969
1565         <rdar://problem/26068734>
1566
1567         Reviewed by Simon Fraser.
1568
1569         Enable subsystem- and channel-related data and functions when using
1570         RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
1571         and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
1572
1573         * Misc/WebKitLogging.h:
1574         * Misc/WebKitLogging.m:
1575         * WebView/WebView.mm:
1576         (-[WebView _commonInitializationWithFrameName:groupName:]):
1577
1578 2016-08-31  Brady Eidson  <beidson@apple.com>
1579
1580         WK2 Gamepad provider on iOS.
1581         https://bugs.webkit.org/show_bug.cgi?id=161412
1582
1583         Reviewed by Tim Horton.
1584
1585         * Configurations/FeatureDefines.xcconfig:
1586
1587         * WebView/WebView.mm:
1588         (WebKitInitializeGamepadProviderIfNecessary):
1589
1590 2016-08-30  Mark Lam  <mark.lam@apple.com>
1591
1592         Introduce the ThrowScope and force every throw site to instantiate a ThrowScope.
1593         https://bugs.webkit.org/show_bug.cgi?id=161171
1594
1595         Reviewed by Filip Pizlo and Geoffrey Garen.
1596
1597         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1598         (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
1599         * Plugins/Hosted/ProxyInstance.mm:
1600         (WebKit::ProxyInstance::invokeMethod):
1601
1602 2016-08-28  Andreas Kling  <akling@apple.com>
1603
1604         document.title setter can't throw.
1605         <https://webkit.org/b/161302>
1606
1607         Reviewed by Antti Koivisto.
1608
1609         * DOM/DOMDocument.mm:
1610         (-[DOMDocument setTitle:]):
1611
1612 2016-08-28  Andreas Kling  <akling@apple.com>
1613
1614         Clean up some .text attribute setters that don't throw.
1615         <https://webkit.org/b/161292>
1616
1617         Reviewed by Darin Adler.
1618
1619         * DOM/DOMHTMLTitleElement.mm:
1620         (-[DOMHTMLTitleElement setText:]):
1621
1622 2016-08-26  Sam Weinig  <sam@webkit.org>
1623
1624         Remove support for ENABLE_LEGACY_WEB_AUDIO
1625         https://bugs.webkit.org/show_bug.cgi?id=161262
1626
1627         Reviewed by Anders Carlsson.
1628
1629         * Configurations/FeatureDefines.xcconfig:
1630         Remove ENABLE_LEGACY_WEB_AUDIO
1631
1632 2016-08-25  Anders Carlsson  <andersca@apple.com>
1633
1634         Re-export DOMException NSStrings after r204717
1635         https://bugs.webkit.org/show_bug.cgi?id=161200
1636         <rdar://problem/27959937>
1637
1638         Reviewed by Alex Christensen.
1639
1640         * DOM/ExceptionHandlers.mm:
1641         (raiseDOMException):
1642         * WebKit.exp:
1643
1644 2016-08-22  Darin Adler  <darin@apple.com>
1645
1646         Move Objective-C DOM bindings from WebCore to legacy WebKit
1647         https://bugs.webkit.org/show_bug.cgi?id=160654
1648
1649         Reviewed by Alex Christensen.
1650
1651         * DOM: Added lots of files to the directory.
1652         The files are just as they were in bindings/objc except that the paths of includes
1653         have been updated as needed, and the code no longer is defined inside the WebCore
1654         namespace, requring changes to various functions and their call sites. Also removed
1655         all the WEBCORE_EXPORT since we export differently here in legacy WebKit.
1656
1657         * DOM/DOMInternal.h: Moved. Replaced createDOMWrapper with initializeDOMWrapperHooks.
1658         * DOM/DOMUtility.mm: Moved.
1659         (createDOMWrapper): Simplified to use toWrapped and not do unneeded namespace tricks.
1660         (disconnectWindowWrapper): Added.
1661         (initializeDOMWrapperHooks): Added.
1662
1663         * MigrateHeaders.make: Removed all the internal headers since they are now just
1664         normal project headers. Added the "DOM" directory to the VPATH. Some of the headers
1665         from WebCore are still being migrated, so we can't remove WebCorePrivateHeaders yet.
1666
1667         * WebCoreSupport/WebEditorClient.h: Updated to return RefPtr<DocumentFragment>.
1668
1669         * WebCoreSupport/WebEditorClient.mm:
1670         (WebEditorClient::documentFragmentFromDelegate): Use RefPtr.
1671
1672         * WebKit.exp: Added exports for all the classes that used to use WEBCORE_EXPORT to
1673         be exported from WebCore.
1674
1675         * WebView/WebFrame.mm:
1676         (-[WebFrame innerLineHeight:]): Moved code from WebCore::Frame::innerLineHeight here.
1677         No longer depend on whether this node happens to be in this frame. Also removed
1678         unneeded null check since a node's document can't be null.
1679
1680         * WebView/WebHTMLView.mm: Removed uneeded include of ExceptionHandlers.h, which
1681         is now here in WebKitLegacy instead of WebCore. But no need to include it at all.
1682
1683         * WebView/WebView.mm:
1684         (-[WebView _commonInitializationWithFrameName:groupName:]): Call
1685         initializeDOMWrapperHooks so WebScriptObject can create DOM binding wrappers when
1686         making a script object for a DOM object, rather than just a generic script object.
1687         (+[WebView enableWebThread]): Added a call to WebCoreObjCDeallocOnWebThread here for
1688         DOMObject along with the other classes. This was done in WebCore before, but DOMObject is now
1689         defined here in legacy WebKit.
1690         (-[WebView styleAtSelectionStart]): Moved code from WebCore::Frame::styleAtSelectionStart here.
1691         Replaced incorrect code that called "new PropertySetCSSStyleDeclaration" with a misleading comment
1692         about reference counting; that code was leaking all the style declarations. Instead use
1693         MutableStyleProperties::ensureCSSStyleDeclaration, which is designed for this purpose.
1694
1695 2016-08-22  Youenn Fablet  <youenn@apple.com>
1696
1697         [Fetch API] Activate fetch api runtime flag by default
1698         https://bugs.webkit.org/show_bug.cgi?id=160452
1699
1700         Reviewed by Alex Christensen.
1701
1702         * WebView/WebPreferences.mm:
1703         (+[WebPreferences initialize]):
1704
1705 2016-08-21  Alex Christensen  <achristensen@webkit.org>
1706
1707         Use Document& instead of Document* when getting cookies
1708         https://bugs.webkit.org/show_bug.cgi?id=161011
1709
1710         Reviewed by Darin Adler.
1711
1712         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1713         (WebKit::NetscapePluginInstanceProxy::getCookies):
1714         (WebKit::NetscapePluginInstanceProxy::setCookies):
1715         * Plugins/WebNetscapePluginView.mm:
1716         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1717         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1718
1719 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
1720
1721         Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
1722         https://bugs.webkit.org/show_bug.cgi?id=160923
1723
1724         Reviewed by Tim Horton.
1725
1726         * WebCoreSupport/WebFrameLoaderClient.h:
1727         * WebCoreSupport/WebFrameLoaderClient.mm:
1728         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1729         (WebFrameLoaderClient::dispatchDidLayout): Deleted.
1730
1731 2016-08-18  Daniel Bates  <dabates@apple.com>
1732
1733         Ld warns of non-existent PrivateFrameworks directory when building WebKit with the public iOS 9.3 SDK
1734         https://bugs.webkit.org/show_bug.cgi?id=160979
1735
1736         Rubber-stamped by Simon Fraser.
1737
1738         Only add the SDK PrivateFrameworks directory to the FRAMEWORK_SEARCH_PATH when building for
1739         iOS Simulator, building with an iOS SDK that does not support text-based stubs, or building
1740         an Apple-internal build.
1741
1742         * Configurations/WebKitLegacy.xcconfig:
1743
1744 2016-08-18  Anders Carlsson  <andersca@apple.com>
1745
1746         Move an NPAPI-only function from WebCore to WebKit
1747         https://bugs.webkit.org/show_bug.cgi?id=160967
1748
1749         Reviewed by Sam Weinig.
1750
1751         * Plugins/WebNetscapePluginView.h:
1752         * Plugins/WebNetscapePluginView.mm:
1753         (-[WebNetscapePluginView getVariable:value:]):
1754         (-[WebNetscapePluginView _destroyPlugin]):
1755
1756 2016-08-18  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
1757
1758         [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
1759         https://bugs.webkit.org/show_bug.cgi?id=156096
1760
1761         Reviewed by Dean Jackson.
1762
1763         Adds:
1764         - Setup interface for enabling runtime flag for Web animations through preferences.
1765
1766         * WebView/WebPreferenceKeysPrivate.h:
1767         * WebView/WebPreferences.mm:
1768         (+[WebPreferences initialize]):
1769         (-[WebPreferences webAnimationsEnabled]):
1770         (-[WebPreferences setWebAnimationsEnabled:]):
1771         * WebView/WebPreferencesPrivate.h:
1772         * WebView/WebView.mm:
1773         (-[WebView _preferencesChanged:]):
1774
1775 2016-08-17  Anders Carlsson  <andersca@apple.com>
1776
1777         Remove a couple of unused WKSI function pointers
1778         https://bugs.webkit.org/show_bug.cgi?id=160946
1779
1780         Reviewed by Dan Bernstein.
1781
1782         * WebCoreSupport/WebSystemInterface.mm:
1783         (InitWebCoreSystemInterface): Deleted.
1784
1785 2016-08-16  Daniel Bates  <dabates@apple.com>
1786
1787         WKSI static library should be named by major iOS revision, not individual updates
1788         https://bugs.webkit.org/show_bug.cgi?id=160727
1789         <rdar://problem/22274848>
1790
1791         Reviewed by Alexey Proskuryakov.
1792
1793         * Configurations/Base.xcconfig:
1794         * Configurations/DebugRelease.xcconfig:
1795         * Configurations/WebKitLegacy.xcconfig:
1796
1797 2016-08-16  Darin Adler  <darin@apple.com>
1798
1799         [Cocoa] Remove dependency on Objective-C bindings in WebKit2 editing code
1800         https://bugs.webkit.org/show_bug.cgi?id=160891
1801
1802         Reviewed by Anders Carlsson.
1803
1804         * WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
1805
1806         * WebCoreSupport/WebEditorClient.mm:
1807         (attributesForAttributedStringConversion): Replaced the
1808         createExcludedElementsForAttributedStringConversion function with this one.
1809         No good reason to keep the array around instead of the dictionary.
1810         (_WebCreateFragment): Renamed from documentFragmentFromAttributedString.
1811         This is now a global function exported so it can be called by WebCore with
1812         a different way of returning its value.
1813
1814         * WebKit.exp: Added _WebCreateFragment.
1815
1816         * WebView/WebHTMLView.mm:
1817         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1818         Removed long-ago-obsolete workaround for Radar bug 5052369.
1819
1820 2016-08-15  Anders Carlsson  <andersca@apple.com>
1821
1822         Another build fix.
1823
1824         * WebKit.exp:
1825
1826 2016-08-15  Anders Carlsson  <andersca@apple.com>
1827
1828         Fix build.
1829
1830         * Configurations/WebKitLegacy.xcconfig:
1831         * WebKit.mac.exp:
1832
1833 2016-08-15  Anders Carlsson  <andersca@apple.com>
1834
1835         Remove OldWebAssertions.c
1836         https://bugs.webkit.org/show_bug.cgi?id=160862
1837
1838         Reviewed by Dan Bernstein.
1839
1840         These functions were used by an old version of iWeb. The latest version of iWeb no longer uses them.
1841
1842         * Misc/OldWebAssertions.c: Removed.
1843         (WebReportAssertionFailure): Deleted.
1844         (WebReportError): Deleted.
1845
1846 2016-08-15  Anders Carlsson  <andersca@apple.com>
1847
1848         Remove WebKeyGenerator
1849         https://bugs.webkit.org/show_bug.cgi?id=160854
1850
1851         Reviewed by Dan Bernstein.
1852
1853         This SPI class is no longer used by Safari.
1854
1855         * WebCoreSupport/WebKeyGenerator.h: Removed.
1856         * WebCoreSupport/WebKeyGenerator.mm: Removed.
1857         (+[WebKeyGenerator sharedGenerator]): Deleted.
1858         (toWebCertificateParseResult): Deleted.
1859         (-[WebKeyGenerator addCertificatesToKeychainFromData:]): Deleted.
1860         * WebView/WebFrameView.mm:
1861
1862 2016-08-15  Daniel Bates  <dabates@apple.com>
1863
1864         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
1865         private frameworks and libraries
1866         https://bugs.webkit.org/show_bug.cgi?id=155931
1867         <rdar://problem/25807989>
1868
1869         Reviewed by Dan Bernstein.
1870
1871         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
1872         where X is the major version of the active iOS SDK.
1873
1874         * Configurations/WebKitLegacy.xcconfig:
1875
1876 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1877
1878         Add a setting and preferences to enable visual viewport mode
1879         https://bugs.webkit.org/show_bug.cgi?id=160843
1880
1881         Reviewed by Sam Weinig.
1882
1883         Hook up the visualViewportEnabled setting for WebKit1.
1884
1885         * WebView/WebPreferenceKeysPrivate.h:
1886         * WebView/WebPreferences.mm:
1887         (+[WebPreferences initialize]):
1888         (-[WebPreferences visualViewportEnabled]):
1889         (-[WebPreferences setVisualViewportEnabled:]):
1890         * WebView/WebPreferencesPrivate.h:
1891
1892 2016-08-15  Joseph Pecoraro  <pecoraro@apple.com>
1893
1894         Remove unused includes of wtf headers
1895         https://bugs.webkit.org/show_bug.cgi?id=160839
1896
1897         Reviewed by Alex Christensen.
1898
1899         * History/BinaryPropertyList.cpp:
1900         * History/WebBackForwardList.mm:
1901         * History/WebHistoryItemInternal.h:
1902         * Misc/WebNSFileManagerExtras.mm:
1903         * Plugins/Hosted/NetscapePluginHostProxy.h:
1904         * WebCoreSupport/WebPlatformStrategies.mm:
1905         * WebCoreSupport/WebSelectionServiceController.mm:
1906         * WebCoreSupport/WebUserMediaClient.h:
1907
1908 2016-08-12  Anders Carlsson  <andersca@apple.com>
1909
1910         Move the plug-in and WebGL blacklist code to WebCore
1911         https://bugs.webkit.org/show_bug.cgi?id=160831
1912
1913         Reviewed by Sam Weinig.
1914
1915         Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.
1916
1917         * WebCoreSupport/WebFrameLoaderClient.mm:
1918         (shouldBlockPlugin):
1919         (WebFrameLoaderClient::createPlugin):
1920         (WebFrameLoaderClient::createJavaAppletWidget):
1921         (shouldBlockWebGL):
1922         (WebFrameLoaderClient::webGLPolicyForURL):
1923         (WebFrameLoaderClient::resolveWebGLPolicyForURL):
1924
1925 2016-08-14  Daniel Bates  <dabates@apple.com>
1926
1927         Fix compiler errors when building iOS WebKit using the iOS 10 beta SDK
1928         https://bugs.webkit.org/show_bug.cgi?id=160725
1929
1930         Reviewed by Sam Weinig.
1931
1932         OSAtomicCompareAndSwap32() has been deprecated as of the iOS 10 beta SDK. For now,
1933         silence the complier warning.
1934
1935         * WebView/WebView.mm:
1936         (-[WebView _dispatchTileDidDraw:]):
1937
1938 2016-08-12  Joseph Pecoraro  <pecoraro@apple.com>
1939
1940         Remove always true JSC::Debugger::needPauseHandling virtual method
1941         https://bugs.webkit.org/show_bug.cgi?id=160822
1942
1943         Reviewed by Mark Lam.
1944
1945         * WebView/WebScriptDebugger.h:
1946
1947 2016-08-11  Chris Dumez  <cdumez@apple.com>
1948
1949         Regression(r204268): Mail crashes when trying to compose an email
1950         https://bugs.webkit.org/show_bug.cgi?id=160775
1951
1952         Reviewed by Anders Carlsson.
1953
1954         Properly initialize PageConfiguration.pluginInfoProvider in
1955         [WebView initSimpleHTMLDocumentWithStyle] to avoid a null
1956         dereference in Mail when trying to compose an email.
1957
1958         * WebView/WebView.mm:
1959         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1960
1961 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1962
1963         Sort the feature flags in the FEATURE_DEFINES lines
1964         https://bugs.webkit.org/show_bug.cgi?id=160742
1965
1966         Reviewed by Anders Carlsson.
1967
1968         * Configurations/FeatureDefines.xcconfig:
1969
1970 2016-08-09  Alex Christensen  <achristensen@webkit.org>
1971
1972         Move NetworkStorageSession management to WebCore
1973         https://bugs.webkit.org/show_bug.cgi?id=160173
1974
1975         Reviewed by Brady Eidson.
1976
1977         * WebCoreSupport/WebFrameNetworkingContext.mm:
1978         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1979         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1980         * WebCoreSupport/WebPlatformStrategies.mm:
1981         * WebView/WebView.mm:
1982
1983 2016-08-09  Anders Carlsson  <andersca@apple.com>
1984
1985         Instantiate WebKit plug-ins at layout time, instead of at style resolution time
1986         https://bugs.webkit.org/show_bug.cgi?id=160715
1987
1988         Reviewed by Tim Horton.
1989
1990         * WebCoreSupport/WebFrameLoaderClient.mm:
1991         (WebFrameLoaderClient::objectContentType):
1992
1993 2016-08-09  George Ruan  <gruan@apple.com>
1994
1995         Implement functionality of media capture on iOS
1996         https://bugs.webkit.org/show_bug.cgi?id=158945
1997         <rdar://problem/26893343>
1998
1999         Reviewed by Tim Horton.
2000
2001         * Configurations/FeatureDefines.xcconfig: Enable Media Capture feature
2002         for iOS.
2003
2004 2016-08-09  Anders Carlsson  <andersca@apple.com>
2005
2006         Get rid of PluginStrategy
2007         https://bugs.webkit.org/show_bug.cgi?id=160696
2008
2009         Reviewed by Dan Bernstein.
2010
2011         * WebCoreSupport/WebPlatformStrategies.h:
2012         * WebCoreSupport/WebPlatformStrategies.mm:
2013         (WebPlatformStrategies::createPluginStrategy): Deleted.
2014         * WebCoreSupport/WebPluginInfoProvider.h:
2015         * WebCoreSupport/WebPluginInfoProvider.mm:
2016         (WebPluginInfoProvider::setPluginLoadClientPolicy): Deleted.
2017         (WebPluginInfoProvider::clearPluginClientPolicies): Deleted.
2018
2019 2016-08-09  Anders Carlsson  <andersca@apple.com>
2020
2021         Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
2022         https://bugs.webkit.org/show_bug.cgi?id=160694
2023
2024         Reviewed by Dan Bernstein.
2025
2026         * WebCoreSupport/WebPlatformStrategies.h:
2027         * WebCoreSupport/WebPlatformStrategies.mm:
2028         (WebPlatformStrategies::createPluginStrategy):
2029         (WebPlatformStrategies::refreshPlugins): Deleted.
2030         (WebPlatformStrategies::getPluginInfo): Deleted.
2031         (WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
2032         (WebPlatformStrategies::setPluginLoadClientPolicy): Deleted.
2033         (WebPlatformStrategies::clearPluginClientPolicies): Deleted.
2034         * WebCoreSupport/WebPluginInfoProvider.mm:
2035         (WebPluginInfoProvider::refreshPlugins):
2036         (WebPluginInfoProvider::getPluginInfo):
2037         (WebPluginInfoProvider::getWebVisiblePluginInfo):
2038
2039 2016-08-08  Anders Carlsson  <andersca@apple.com>
2040
2041         Add a new PluginInfoProvider class, to replace PluginStrategy
2042         https://bugs.webkit.org/show_bug.cgi?id=160670
2043
2044         Reviewed by Sam Weinig.
2045
2046         Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
2047
2048         * WebCoreSupport/WebPluginInfoProvider.h: Added.
2049         * WebCoreSupport/WebPluginInfoProvider.mm: Added.
2050         (WebPluginInfoProvider::singleton):
2051         (WebPluginInfoProvider::WebPluginInfoProvider):
2052         (WebPluginInfoProvider::~WebPluginInfoProvider):
2053         (WebPluginInfoProvider::refreshPlugins):
2054         (WebPluginInfoProvider::getPluginInfo):
2055         (WebPluginInfoProvider::getWebVisiblePluginInfo):
2056         (WebPluginInfoProvider::setPluginLoadClientPolicy):
2057         (WebPluginInfoProvider::clearPluginClientPolicies):
2058         * WebView/WebView.mm:
2059         (-[WebView _commonInitializationWithFrameName:groupName:]):
2060
2061 2016-08-02  Enrica Casucci  <enrica@apple.com>
2062
2063         Allow building with content filtering disabled.
2064         https://bugs.webkit.org/show_bug.cgi?id=160454
2065
2066         Reviewed by Simon Fraser.
2067
2068         * Configurations/FeatureDefines.xcconfig:
2069         * WebCoreSupport/WebFrameLoaderClient.h:
2070         * WebCoreSupport/WebFrameLoaderClient.mm:
2071         (WebFrameLoaderClient::blockedByContentFilterError):
2072
2073 2016-08-02  Anders Carlsson  <andersca@apple.com>
2074
2075         Remove more unused/uninstalled Objective-C DOM bindings
2076         https://bugs.webkit.org/show_bug.cgi?id=160464
2077
2078         Reviewed by Darin Adler.
2079
2080         Stop installing unused headers.
2081
2082         * MigrateHeaders.make:
2083
2084 2016-08-01  Anders Carlsson  <andersca@apple.com>
2085
2086         Bring back a file - it needs to be copied by WebCore.
2087
2088         * MigrateHeaders.make:
2089
2090 2016-08-01  Anders Carlsson  <andersca@apple.com>
2091
2092         Remove another file.
2093
2094         * MigrateHeaders.make:
2095
2096 2016-08-01  Anders Carlsson  <andersca@apple.com>
2097
2098         Remove a file.
2099
2100         * MigrateHeaders.make:
2101
2102 2016-08-01  Anders Carlsson  <andersca@apple.com>
2103
2104         Freeze all the DOMHTML* Objective-C bindings
2105         https://bugs.webkit.org/show_bug.cgi?id=160424
2106
2107         Reviewed by Tim Horton.
2108
2109         Don't migrate DOMHTMLEmbedElementPrivate.h - it was just an empty header.
2110
2111         * MigrateHeaders.make:
2112
2113 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
2114
2115         Remove deprecated SPI for video inline / fullscreen controls
2116         https://bugs.webkit.org/show_bug.cgi?id=160318
2117
2118         Reviewed by Tim Horton.
2119
2120         * WebView/WebPreferenceKeysPrivate.h:
2121         * WebView/WebPreferences.mm:
2122         (+[WebPreferences initialize]): Deleted.
2123         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]): Deleted.
2124         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]): Deleted.
2125         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]): Deleted.
2126         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]): Deleted.
2127         * WebView/WebPreferencesPrivate.h:
2128         * WebView/WebView.mm:
2129         (-[WebView _preferencesChanged:]): Deleted.
2130
2131 2016-07-28  Anders Carlsson  <andersca@apple.com>
2132
2133         Move a Mail.app workaround closer to where it's actually needed
2134         https://bugs.webkit.org/show_bug.cgi?id=160317
2135
2136         Reviewed by Tim Horton.
2137
2138         * WebCoreSupport/WebFrameLoaderClient.mm:
2139         (WebFrameLoaderClient::dispatchWillSendRequest):
2140         * WebView/WebFrame.mm:
2141         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Deleted.
2142
2143 2016-07-28  Anders Carlsson  <andersca@apple.com>
2144
2145         Use a RetainPtr in WebFrameLoaderClient::assignIdentifierToInitialRequest
2146         https://bugs.webkit.org/show_bug.cgi?id=160315
2147
2148         Reviewed by Tim Horton.
2149
2150         * WebCoreSupport/WebFrameLoaderClient.mm:
2151         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2152
2153 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2154
2155         Fix the Windows debug build.
2156         
2157         WebResourceLoadScheduler's logging was a holdover from it being in WebCore,
2158         and prior to r203749 WebKit was actually using a WebCore log channel.
2159         
2160         For some reason this doesn't build on Windows debug, so just remove
2161         this logging for now.
2162
2163         * Misc/WebKitLogging.h:
2164
2165 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2166
2167         [iPhone] Playing a video on tudou.com plays only sound, no video
2168         https://bugs.webkit.org/show_bug.cgi?id=160178
2169         <rdar://problem/27535468>
2170
2171         Reviewed by Eric Carlson and Dan Bernstein.
2172
2173         * WebView/WebPreferenceKeysPrivate.h:
2174         * WebView/WebPreferences.mm:
2175         (+[WebPreferences initialize]):
2176         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]):
2177         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]):
2178         * WebView/WebPreferencesPrivate.h:
2179         * WebView/WebView.mm:
2180         (-[WebView _preferencesChanged:]):
2181
2182 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2183
2184         Allow LOG macros to be used outside the namespace, and other logging cleanup
2185         https://bugs.webkit.org/show_bug.cgi?id=160216
2186
2187         Reviewed by Anders Carlsson.
2188
2189         Fix some issues with the LOG macros.
2190         
2191         First, they were not usable outside the WebKit namespace in WebKit2 code. Fix by moving
2192         its log channels outside of the namespace (they are protected by a unique prefix anyway).
2193         
2194         Second, allow LOG_WITH_STREAM to be used in WebKit2 by moving that and a helper macro
2195         into LogMacros.h, which is exported from WebCore as a private header.
2196         
2197         Third, split the Logging.h header into two. Logging.h remains for framework-internal
2198         log channels and log macros. Add LogInitialization.h which is external, and used to
2199         initialize the channels.
2200         
2201         Finally unify "initializeLogChannels" and "initializeLoggingChannels" terminology everywhere.
2202
2203         * Misc/WebKitLogging.h:
2204         * Misc/WebKitLogging.m:
2205         * WebView/WebView.mm:
2206         (-[WebView _commonInitializationWithFrameName:groupName:]):
2207
2208 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2209
2210         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2211         https://bugs.webkit.org/show_bug.cgi?id=160066
2212
2213         Reviewed by Dean Jackson.
2214
2215         * WebView/WebPreferenceKeysPrivate.h:
2216         * WebView/WebPreferences.mm:
2217         (+[WebPreferences initialize]): Deleted.
2218         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]): Deleted.
2219         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): Deleted.
2220         * WebView/WebPreferencesPrivate.h:
2221         * WebView/WebView.mm:
2222         (-[WebView _preferencesChanged:]): Deleted.
2223
2224 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2225
2226         [iPhone] Playing a video on tudou.com plays only sound, no video
2227         https://bugs.webkit.org/show_bug.cgi?id=159967
2228         <rdar://problem/26964090>
2229
2230         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2231
2232         Add the two preferences to WebPreferences.
2233
2234         * WebView/WebPreferenceKeysPrivate.h:
2235         * WebView/WebPreferences.mm:
2236         (+[WebPreferences initialize]):
2237         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
2238         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
2239         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
2240         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
2241         * WebView/WebPreferencesPrivate.h:
2242         * WebView/WebView.mm:
2243         (-[WebView _preferencesChanged:]):
2244
2245 2016-07-20  Commit Queue  <commit-queue@webkit.org>
2246
2247         Unreviewed, rolling out r203471.
2248         https://bugs.webkit.org/show_bug.cgi?id=160003
2249
2250         many iOS-simulator tests are failing (Requested by litherum on
2251         #webkit).
2252
2253         Reverted changeset:
2254
2255         "[iPhone] Playing a video on tudou.com plays only sound, no
2256         video"
2257         https://bugs.webkit.org/show_bug.cgi?id=159967
2258         http://trac.webkit.org/changeset/203471
2259
2260 2016-07-20  Myles C. Maxfield  <mmaxfield@apple.com>
2261
2262         [iPhone] Playing a video on tudou.com plays only sound, no video
2263         https://bugs.webkit.org/show_bug.cgi?id=159967
2264         <rdar://problem/26964090>
2265
2266         Reviewed by Jon Lee.
2267
2268         Add the two preferences to WebPreferences.
2269
2270         * WebView/WebPreferenceKeysPrivate.h:
2271         * WebView/WebPreferences.mm:
2272         (+[WebPreferences initialize]):
2273         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
2274         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
2275         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
2276         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
2277         * WebView/WebPreferencesPrivate.h:
2278         * WebView/WebView.mm:
2279         (-[WebView _preferencesChanged:]):
2280
2281 2016-07-19  Andy Estes  <aestes@apple.com>
2282
2283         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2284         https://bugs.webkit.org/show_bug.cgi?id=159956
2285
2286         Reviewed by Dan Bernstein.
2287
2288         * Misc/WebKitErrors.h: Moved definition of WebKitErrorFrameLoadBlockedByContentFilter from here ...
2289         * Misc/WebKitErrorsPrivate.h: to here.
2290
2291 2016-07-18  Anders Carlsson  <andersca@apple.com>
2292
2293         WebKit nightly fails to build on macOS Sierra
2294         https://bugs.webkit.org/show_bug.cgi?id=159902
2295         rdar://problem/27365672
2296
2297         Reviewed by Tim Horton.
2298
2299         * icu/unicode/ucurr.h: Added.
2300         Add ucurr.h from ICU.
2301
2302 2016-07-17  Sam Weinig  <sam@webkit.org>
2303
2304         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2305         <rdar://problem/26554137>
2306         https://bugs.webkit.org/show_bug.cgi?id=159856
2307
2308         Reviewed by Dan Bernstein.
2309
2310         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2311         (WebKit::NetscapePluginInstanceProxy::evaluate):
2312         * Plugins/WebNetscapePluginView.mm:
2313         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2314         Update for new UserGestureIndicator interface.
2315
2316 2016-07-16  Ryosuke Niwa  <rniwa@webkit.org>
2317
2318         Rename fastGetAttribute to attributeWithoutSynchronization
2319         https://bugs.webkit.org/show_bug.cgi?id=159852
2320
2321         Reviewed by Darin Adler.
2322
2323         * WebView/WebHTMLRepresentation.mm:
2324         (matchLabelsAgainstElement):
2325
2326 2016-07-15  Chris Dumez  <cdumez@apple.com>
2327
2328         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
2329         https://bugs.webkit.org/show_bug.cgi?id=159793
2330
2331         Reviewed by Ryosuke Niwa.
2332
2333         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.
2334
2335         * WebView/WebHTMLRepresentation.mm:
2336         (matchLabelsAgainstElement):
2337
2338 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2339
2340         Use SocketProvider to create SocketStreamHandles
2341         https://bugs.webkit.org/show_bug.cgi?id=159774
2342
2343         Reviewed by Brady Eidson.
2344
2345         * Misc/WebSocketProvider.h: Removed.
2346         * Misc/WebSocketProvider.mm: Removed.
2347         * WebView/WebView.mm:
2348         (-[WebView _commonInitializationWithFrameName:groupName:]):
2349         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2350
2351 2016-07-14  Csaba Osztrogonác  <ossy@webkit.org>
2352
2353         Fix the !ENABLE(WEB_SOCKETS) build after r202930
2354         https://bugs.webkit.org/show_bug.cgi?id=159768
2355
2356         Reviewed by Alex Christensen.
2357
2358         * Misc/WebSocketProvider.h:
2359
2360 2016-07-13  Beth Dakin  <bdakin@apple.com>
2361
2362         Add more candidate tests
2363         https://bugs.webkit.org/show_bug.cgi?id=159730
2364
2365         Reviewed by Tim Horton.
2366
2367         Move shouldRequestCandidates from WebViewInternal to WebViewPrivate so that 
2368         we can use it in tests. 
2369         * WebView/WebViewInternal.h:
2370         * WebView/WebViewPrivate.h:
2371
2372 2016-07-13  Enrica Casucci  <enrica@apple.com>
2373
2374         Update supported platforms in xcconfig files to match the sdk names.
2375         https://bugs.webkit.org/show_bug.cgi?id=159728
2376
2377         Reviewed by Tim Horton.
2378
2379         * Configurations/Base.xcconfig:
2380
2381 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2382
2383         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2384         https://bugs.webkit.org/show_bug.cgi?id=159671
2385
2386         Reviewed by Csaba Osztrogonác.
2387
2388         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2389         https://bugs.webkit.org/show_bug.cgi?id=89235
2390
2391         So this guard can be removed in build scripts.
2392
2393         * Configurations/FeatureDefines.xcconfig:
2394
2395 2016-07-11  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2396
2397         Purge PassRefPtr in platform/efl and platform/mac 
2398         https://bugs.webkit.org/show_bug.cgi?id=159548
2399
2400         Reviewed by Alex Christensen.
2401
2402         Remove all use of PassRefPtr and clean up unnecessary tabs and spaces.
2403
2404         * WebCoreSupport/WebPlatformStrategies.h:
2405         * WebCoreSupport/WebPlatformStrategies.mm:
2406         (WebPlatformStrategies::setBufferForType):
2407
2408 2016-07-11  Enrica Casucci  <enrica@apple.com>
2409
2410         Add synthetic click origin to WKNavigationAction.
2411         https://bugs.webkit.org/show_bug.cgi?id=159584
2412         rdar://problem/25610422
2413
2414         Reviewed by Tim Horton.
2415
2416         * WebView/WebFrame.mm:
2417         (-[WebFrame _dragSourceEndedAt:operation:]):
2418         * WebView/WebPDFView.mm:
2419         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2420
2421 2016-07-11  Anders Carlsson  <andersca@apple.com>
2422
2423         Able to open multiple payment sheets in Safari at the same time
2424         https://bugs.webkit.org/show_bug.cgi?id=159637
2425         rdar://problem/26411339
2426
2427         Reviewed by Beth Dakin.
2428
2429         Update for WebCore changes.
2430
2431         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2432         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2433         (WebPaymentCoordinatorClient::showPaymentUI):
2434
2435 2016-07-08  Andy Estes  <aestes@apple.com>
2436
2437         [Content Filtering] Load blocked pages more like other error pages are loaded
2438         https://bugs.webkit.org/show_bug.cgi?id=159485
2439         <rdar://problem/26014076>
2440
2441         Reviewed by Brady Eidson.
2442
2443         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
2444         * Misc/WebKitErrors.m:
2445         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
2446         * WebCoreSupport/WebFrameLoaderClient.h:
2447         * WebCoreSupport/WebFrameLoaderClient.mm:
2448         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
2449
2450 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2451
2452         Unreviewed, rolling out r202944.
2453         https://bugs.webkit.org/show_bug.cgi?id=159570
2454
2455         caused some tests to crash under GuardMalloc (Requested by
2456         estes on #webkit).
2457
2458         Reverted changeset:
2459
2460         "[Content Filtering] Load blocked pages more like other error
2461         pages are loaded"
2462         https://bugs.webkit.org/show_bug.cgi?id=159485
2463         http://trac.webkit.org/changeset/202944
2464
2465 2016-07-08  Jiewen Tan  <jiewen_tan@apple.com>
2466
2467         Define DYLD_MACOSX_VERSION_10_12
2468         https://bugs.webkit.org/show_bug.cgi?id=159525
2469         <rdar://problem/26250296>
2470
2471         Reviewed by Brent Fulgham.
2472
2473         * WebView/WebView.mm:
2474         (shouldConvertInvalidURLsToBlank):
2475         Replace 0x000A0C00 with DYLD_MACOSX_VERSION_10_12.
2476
2477 2016-07-07  Beth Dakin  <bdakin@apple.com>
2478
2479         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
2480         https://bugs.webkit.org/show_bug.cgi?id=159532
2481         -and corresponding-
2482         rdar://problem/27177179
2483
2484         Reviewed by Tim Horton.
2485
2486         * WebView/WebView.mm:
2487         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
2488         (-[WebView forceRequestCandidatesForTesting]):
2489         (-[WebView shouldRequestCandidates]):
2490         * WebView/WebViewPrivate.h:
2491
2492 2016-07-07  Andy Estes  <aestes@apple.com>
2493
2494         [Content Filtering] Load blocked pages more like other error pages are loaded
2495         https://bugs.webkit.org/show_bug.cgi?id=159485
2496         <rdar://problem/26014076>
2497
2498         Reviewed by Brady Eidson.
2499
2500         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
2501         * Misc/WebKitErrors.m:
2502         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
2503         * WebCoreSupport/WebFrameLoaderClient.h:
2504         * WebCoreSupport/WebFrameLoaderClient.mm:
2505         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
2506
2507 2016-07-07  Alex Christensen  <achristensen@webkit.org>
2508
2509         Use SocketProvider to create WebSocketChannels
2510         https://bugs.webkit.org/show_bug.cgi?id=158776
2511
2512         Reviewed by Brent Fulgham.
2513
2514         * Misc/WebSocketProvider.mm: Copied from Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp.
2515         (WebSocketProvider::createWebSocketChannel):
2516         (WebCore::ThreadableWebSocketChannel::create): Deleted.
2517         * Misc/WebSocketProvider.h:
2518         * WebView/WebView.mm:
2519         (-[WebView _commonInitializationWithFrameName:groupName:]):
2520         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2521
2522 2016-07-06  Benjamin Poulain  <bpoulain@apple.com>
2523
2524         [JSC] Unify how we throw TypeError from C++
2525         https://bugs.webkit.org/show_bug.cgi?id=159500
2526
2527         Reviewed by Saam Barati.
2528
2529         * Plugins/Hosted/ProxyInstance.mm:
2530         (WebKit::ProxyInstance::invokeMethod):
2531
2532 2016-07-01  Youenn Fablet  <youennf@gmail.com>
2533
2534         Add a runtime flag for DOM iterators
2535         https://bugs.webkit.org/show_bug.cgi?id=159300
2536
2537         Reviewed by Alex Christensen.
2538
2539         * WebView/WebPreferenceKeysPrivate.h:
2540         * WebView/WebPreferences.mm:
2541         (-[WebPreferences DOMIteratorEnabled]):
2542         (-[WebPreferences setDOMIteratorEnabled:]):
2543         * WebView/WebPreferencesPrivate.h:
2544         * WebView/WebView.mm:
2545         (-[WebView _preferencesChanged:]):
2546
2547 2016-06-30  Jiewen Tan  <jiewen_tan@apple.com>
2548
2549         Create a generic "linked-on-or-after" check for new CSP Rules
2550         https://bugs.webkit.org/show_bug.cgi?id=159322
2551         <rdar://problem/27117220>
2552
2553         Reviewed by Brent Fulgham.
2554
2555         * WebView/WebView.mm:
2556         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2557
2558 2016-06-30  Anders Carlsson  <andersca@apple.com>
2559
2560         Mail crashes on launch at WebCore::PaymentCoordinator::~PaymentCoordinator() + 20
2561         https://bugs.webkit.org/show_bug.cgi?id=159306
2562         rdar://problem/27092107
2563
2564         Reviewed by Tim Horton.
2565
2566         * WebView/WebView.mm:
2567         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2568         Create a WebPaymentCoordinatorClient. Remove an unneeded #import.
2569
2570         (-[WebView _commonInitializationWithFrameName:groupName:]):
2571         Remove an unneeded #import.
2572
2573 2016-06-27  Anders Carlsson  <andersca@apple.com>
2574
2575         WebKit::WebPaymentCoordinator leak
2576         https://bugs.webkit.org/show_bug.cgi?id=159168
2577         rdar://problem/26929772
2578
2579         Reviewed by Beth Dakin.
2580
2581         Update for WebCore changes.
2582
2583         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2584         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2585         (WebPaymentCoordinatorClient::paymentCoordinatorDestroyed):
2586         (WebPaymentCoordinatorClient::mainFrameDestroyed): Deleted.
2587
2588 2016-06-27  Tim Horton  <timothy_horton@apple.com>
2589
2590         REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app
2591         https://bugs.webkit.org/show_bug.cgi?id=159184
2592         <rdar://problem/26370206>
2593
2594         Reviewed by Beth Dakin.
2595
2596         * WebView/WebHTMLView.mm:
2597         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2598         * WebView/WebImmediateActionController.h:
2599         * WebView/WebImmediateActionController.mm:
2600         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2601         (-[WebImmediateActionController _animationControllerForText]):
2602         (dictionaryPopupInfoForRange): Deleted.
2603         WebImmediateActionController's code to make a DictionaryPopupInfo and TextIndicator
2604         from a Range in WebKit1 is much better than WebHTMLView's; use it in both cases.
2605
2606 2016-06-24  Jer Noble  <jer.noble@apple.com>
2607
2608         Playback controls refer to wrong element when playing multiple items in a page.
2609         https://bugs.webkit.org/show_bug.cgi?id=159076
2610         <rdar://problem/26953532>
2611
2612         Reviewed by Beth Dakin.
2613
2614         clearPlaybackControlsManager() no longer takes a parameter.
2615
2616         * WebCoreSupport/WebChromeClient.h:
2617         * WebCoreSupport/WebChromeClient.mm:
2618         (WebChromeClient::clearPlaybackControlsManager):
2619         * WebView/WebView.mm:
2620         (-[WebView _clearPlaybackControlsManager]): Renamed from _clearPlaybackControlsManagerForMediaElement:.
2621         * WebView/WebViewInternal.h:
2622
2623 2016-06-23  Alex Christensen  <achristensen@webkit.org>
2624
2625         Remove unused didCancelAuthenticationChallenge
2626         https://bugs.webkit.org/show_bug.cgi?id=158819
2627
2628         Reviewed by David Kilzer.
2629
2630         * Misc/WebDownload.mm:
2631         (-[WebDownloadInternal download:didCancelAuthenticationChallenge:]): Deleted.
2632         * WebCoreSupport/WebFrameLoaderClient.h:
2633         * WebCoreSupport/WebFrameLoaderClient.mm:
2634         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.
2635         * WebView/WebDelegateImplementationCaching.h:
2636         * WebView/WebView.mm:
2637         (-[WebView _cacheResourceLoadDelegateImplementations]):
2638
2639 2016-06-23  John Wilander  <wilander@apple.com>
2640
2641         Enable window.open() for existing versions of Secret Society app
2642         https://bugs.webkit.org/show_bug.cgi?id=159049
2643         <rdar://problem/26528349>
2644
2645         Reviewed by Andy Estes.
2646
2647         The Secret Society Hidden Mystery app has a broken version check treating iOS 10
2648         as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
2649         handler. We should allow the existing versions of the app to do this to not break
2650         them.
2651
2652         * WebView/WebView.mm:
2653         (shouldAllowWindowOpenWithoutUserGesture):
2654             Added.
2655         (shouldConvertInvalidURLsToBlank):
2656             Changed hex number to constant DYLD_IOS_VERSION_10_0.
2657
2658 2016-06-22  Anders Carlsson  <andersca@apple.com>
2659
2660         Move the WebKitLegacy Apple Pay code to the open source repository
2661         https://bugs.webkit.org/show_bug.cgi?id=159035
2662
2663         Reviewed by Tim Horton.
2664
2665         * WebCoreSupport/WebPaymentCoordinatorClient.h: Added.
2666         * WebCoreSupport/WebPaymentCoordinatorClient.mm: Added.
2667         (WebPaymentCoordinatorClient::WebPaymentCoordinatorClient):
2668         (WebPaymentCoordinatorClient::~WebPaymentCoordinatorClient):
2669         (WebPaymentCoordinatorClient::supportsVersion):
2670         (WebPaymentCoordinatorClient::canMakePayments):
2671         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
2672         (WebPaymentCoordinatorClient::showPaymentUI):
2673         (WebPaymentCoordinatorClient::completeMerchantValidation):
2674         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
2675         (WebPaymentCoordinatorClient::completeShippingContactSelection):
2676         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
2677         (WebPaymentCoordinatorClient::completePaymentSession):
2678         (WebPaymentCoordinatorClient::abortPaymentSession):
2679         (WebPaymentCoordinatorClient::mainFrameDestroyed):
2680         * WebKitAdditions.mm: Removed.
2681         * WebView/WebView.mm:
2682         (-[WebView _commonInitializationWithFrameName:groupName:]):
2683
2684 2016-06-21  Anders Carlsson  <andersca@apple.com>
2685
2686         Fix build.
2687
2688         * Configurations/FeatureDefines.xcconfig:
2689
2690 2016-06-21  Anders Carlsson  <andersca@apple.com>
2691
2692         Begin moving the Apple Pay code to the open source repository
2693         https://bugs.webkit.org/show_bug.cgi?id=158998
2694
2695         Reviewed by Tim Horton.
2696
2697         * Configurations/FeatureDefines.xcconfig:
2698         Add ENABLE_APPLE_PAY.
2699
2700 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
2701
2702         Focus event dispatched in iframe causes parent document to scroll incorrectly
2703         https://bugs.webkit.org/show_bug.cgi?id=158629
2704         rdar://problem/26521616
2705
2706         Reviewed by Tim Horton.
2707         
2708         Pass SelectionRevealMode::Reveal in existing code.
2709
2710         * WebView/WebFrame.mm:
2711         (-[WebFrame _scrollDOMRangeToVisible:]):
2712         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2713         (-[WebFrame revealSelectionAtExtent:]):
2714         * WebView/WebHTMLView.mm:
2715         (-[WebHTMLView jumpToSelection:]):
2716         (-[WebHTMLView centerSelectionInVisibleArea:]):
2717
2718 2016-06-21  Amir Alavi  <aalavi@apple.com>
2719
2720         Upstream WKHTTPCookiesForURL from WebKitSystemInterface to OpenSource
2721         https://bugs.webkit.org/show_bug.cgi?id=158967
2722
2723         Reviewed by Brent Fulgham.
2724
2725         * WebCoreSupport/WebSystemInterface.mm:
2726         (InitWebCoreSystemInterface): Deleted.
2727
2728 2016-06-20  Commit Queue  <commit-queue@webkit.org>
2729
2730         Unreviewed, rolling out r202243.
2731         https://bugs.webkit.org/show_bug.cgi?id=158972
2732
2733         Broke Windows build and iOS tests (Requested by ap on
2734         #webkit).
2735
2736         Reverted changeset:
2737
2738         "Focus event dispatched in iframe causes parent document to
2739         scroll incorrectly"
2740         https://bugs.webkit.org/show_bug.cgi?id=158629
2741         http://trac.webkit.org/changeset/202243
2742
2743 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
2744
2745         Focus event dispatched in iframe causes parent document to scroll incorrectly
2746         https://bugs.webkit.org/show_bug.cgi?id=158629
2747         rdar://problem/26521616
2748
2749         Reviewed by Tim Horton.
2750         
2751         Pass SelectionRevealMode::Reveal in existing code.
2752
2753         * WebView/WebFrame.mm:
2754         (-[WebFrame _scrollDOMRangeToVisible:]):
2755         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2756         (-[WebFrame revealSelectionAtExtent:]):
2757         * WebView/WebHTMLView.mm:
2758         (-[WebHTMLView jumpToSelection:]):
2759         (-[WebHTMLView centerSelectionInVisibleArea:]):
2760
2761 2016-06-20  Keith Rollin  <krollin@apple.com>
2762
2763         Remove RefPtr::release() and change calls sites to use WTFMove()
2764         https://bugs.webkit.org/show_bug.cgi?id=158369
2765
2766         Reviewed by Chris Dumez.
2767
2768         RefPtr::release() releases its managed pointer awkwardly. It's more
2769         direct and clearer to use WTFMove to transfer ownership of the managed
2770         pointer.
2771
2772         As part of this cleanup, also change a lot of explicit data types to
2773         'auto'.
2774
2775         * Plugins/Hosted/NetscapePluginHostManager.mm:
2776         (WebKit::NetscapePluginHostManager::instantiatePlugin):
2777         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2778         (WebKit::NetscapePluginInstanceProxy::create):
2779         (WebKit::NetscapePluginInstanceProxy::loadRequest):
2780         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
2781         * WebCoreSupport/WebFrameLoaderClient.mm:
2782         (-[WebFramePolicyListener receivedPolicyDecision:]):
2783         * WebCoreSupport/WebSecurityOrigin.mm:
2784         (-[WebSecurityOrigin initWithURL:]):
2785         * WebView/WebArchive.mm:
2786         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
2787         (-[WebArchive initWithData:]):
2788         * WebView/WebDataSource.mm:
2789         (-[WebDataSource mainResource]):
2790         * WebView/WebFrame.mm:
2791         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
2792
2793 2016-06-15  Alexey Proskuryakov  <ap@apple.com>
2794
2795         +[WebHTMLRepresentation supportedMIMETypes] leaks
2796         https://bugs.webkit.org/show_bug.cgi?id=158683
2797
2798         Reviewed by Darin Adler.
2799
2800         The problem occurred when chaining newArrayByConcatenatingArrays calls.
2801
2802         Also refactored the code to avoid returning NSMutableArrays disguised as NSArrays,
2803         and removed __unsafe_unretained modifiers that were added in http://trac.webkit.org/r149453
2804         for no apparent reason.
2805
2806         * WebView/WebHTMLRepresentation.mm:
2807         (newArrayWithStrings):
2808         (+[WebHTMLRepresentation supportedMIMETypes]):
2809         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2810         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2811         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2812         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2813         (newArrayByConcatenatingArrays): Deleted.
2814
2815 2016-06-15  Dean Jackson  <dino@apple.com>
2816
2817         RTL <select> forms are misplaced
2818         https://bugs.webkit.org/show_bug.cgi?id=158810
2819         <rdar://problem/24847541>
2820
2821         Reviewed by Eric Carlson.
2822
2823         AppKit made a change in Sierra that causes popup menus
2824         to snap to a different point when the system language is RTL.
2825         We need to be more explicit about what directionality
2826         we want, and override the location of the popup based
2827         on the text direction.
2828
2829         I also made a small tweak to the fudge offsets we use
2830         in order to make button text and menu text to be
2831         more consistent.
2832
2833         Unfortunately since this is just about the location
2834         of the popup menu, it's unable to be tested in our
2835         current infrastructure.
2836
2837         * WebCoreSupport/PopupMenuMac.mm:
2838         (PopupMenuMac::show):
2839
2840 2016-06-15  Chris Dumez  <cdumez@apple.com>
2841
2842         Drop some unnecessary header includes
2843         https://bugs.webkit.org/show_bug.cgi?id=158788
2844
2845         Reviewed by Alexey Proskuryakov.
2846
2847         Drop some unnecessary header includes in headers to speed up build time.
2848
2849         * WebCoreSupport/WebFrameLoaderClient.mm:
2850
2851 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2852
2853         Enabling Shadow DOM for all platforms
2854         https://bugs.webkit.org/show_bug.cgi?id=158738
2855
2856         Reviewed by Ryosuke Niwa.
2857
2858         Removed Shadow DOM from options (enabled by default)
2859
2860         * Configurations/FeatureDefines.xcconfig:
2861         * WebView/WebPreferences.mm:
2862         * WebView/WebView.mm:
2863
2864 2016-06-15  Antti Koivisto  <antti@apple.com>
2865
2866         Vary:Cookie validation doesn't work in private browsing
2867         https://bugs.webkit.org/show_bug.cgi?id=158616
2868         <rdar://problem/26755067>
2869
2870         Reviewed by Andreas Kling.
2871
2872         * WebCoreSupport/WebFrameNetworkingContext.h:
2873         (WebFrameNetworkingContext::create):
2874         * WebCoreSupport/WebFrameNetworkingContext.mm:
2875         (privateSession):
2876         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2877
2878             Expose the private browsing session.
2879
2880         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2881         * WebCoreSupport/WebPlatformStrategies.h:
2882         * WebCoreSupport/WebPlatformStrategies.mm:
2883         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2884
2885             Implement SessionID version of the function.
2886
2887         (WebPlatformStrategies::getRawCookies):
2888
2889 2016-06-13  Alex Christensen  <achristensen@webkit.org>
2890
2891         Add WebSocketProvider stub
2892         https://bugs.webkit.org/show_bug.cgi?id=158702
2893
2894         Reviewed by Brady Eidson.
2895
2896         * Misc/WebSocketProvider.h: Added.
2897         * WebView/WebView.mm:
2898         (-[WebView _commonInitializationWithFrameName:groupName:]):
2899         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2900
2901 2016-06-10  Alex Christensen  <achristensen@webkit.org>
2902
2903         Introduce WTF::UniqueRef
2904         https://bugs.webkit.org/show_bug.cgi?id=158596
2905
2906         Reviewed by Brady Eidson.
2907
2908         * WebView/WebView.mm:
2909         (-[WebView _commonInitializationWithFrameName:groupName:]):
2910         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2911
2912 2016-06-09  Alex Christensen  <achristensen@webkit.org>
2913
2914         Clean up EditorClient lifetime
2915         https://bugs.webkit.org/show_bug.cgi?id=158588
2916
2917         Reviewed by Anders Carlsson.
2918
2919         * WebCoreSupport/WebEditorClient.h:
2920         * WebCoreSupport/WebEditorClient.mm:
2921         (WebEditorClient::WebEditorClient):
2922         (WebEditorClient::pageDestroyed): Deleted.
2923         * WebView/WebView.mm:
2924         (-[WebView _commonInitializationWithFrameName:groupName:]):
2925         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2926
2927 2016-06-09  Andy Estes  <aestes@apple.com>
2928
2929         Define printing{Minimum,Maximum}ShrinkFactor in only one place
2930         https://bugs.webkit.org/show_bug.cgi?id=158580
2931
2932         Reviewed by Tim Horton.
2933
2934         * WebView/WebHTMLView.mm: Initialized _WebHTMLViewPrintingMinimumShrinkFactor and
2935         _WebHTMLViewPrintingMaximumShrinkFactor with PrintContext::minimumShrinkFactor() and
2936         PrintContext::maximumShrinkFactor() instead of with duplicated float literals.
2937
2938 2016-06-09  Commit Queue  <commit-queue@webkit.org>
2939
2940         Unreviewed, rolling out r201810.
2941         https://bugs.webkit.org/show_bug.cgi?id=158563
2942
2943         breaks build without ENABLE_WEB_ANIMATION (Requested by
2944         mcatanzaro on #webkit).
2945
2946         Reverted changeset:
2947
2948         "[web-animations] Add Animatable, AnimationEffect,
2949         KeyframeEffect and Animation interface"
2950         https://bugs.webkit.org/show_bug.cgi?id=156096
2951         http://trac.webkit.org/changeset/201810
2952
2953 2016-06-08  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
2954
2955         [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
2956         https://bugs.webkit.org/show_bug.cgi?id=156096
2957
2958         Reviewed by Dean Jackson.
2959
2960         Adds:
2961         - Setup interface for enabling runtime flag for Web animations through preferences.
2962
2963         * WebView/WebPreferenceKeysPrivate.h:
2964         * WebView/WebPreferences.mm:
2965         (+[WebPreferences initialize]):
2966         (-[WebPreferences webAnimationsEnabled]):
2967         (-[WebPreferences setWebAnimationsEnabled:]):
2968         * WebView/WebPreferencesPrivate.h:
2969         * WebView/WebView.mm:
2970         (-[WebView _preferencesChanged:]):
2971
2972 2016-06-07  David Kilzer  <ddkilzer@apple.com>
2973
2974         [iOS WK1] Remove unused -_webkit_unescapedQueryValue and -_webkit_queryKeysAndValues NSString category methods
2975         <https://webkit.org/b/158485>
2976         <rdar://problem/16960445>
2977
2978         Reviewed by Dan Bernstein.
2979
2980         * Misc/WebNSURLExtras.h:
2981         (-[NSString _webkit_unescapedQueryValue]): Deleted declaration.
2982         (-[NSString _webkit_queryKeysAndValues]): Deleted declaration.
2983         * Misc/WebNSURLExtras.mm:
2984         (-[NSString _webkit_unescapedQueryValue]): Deleted.
2985         (-[NSString _webkit_queryKeysAndValues]): Deleted.
2986
2987 2016-06-07  Alex Christensen  <achristensen@webkit.org>
2988
2989         Adopt [PDFView documentScrollView]
2990         https://bugs.webkit.org/show_bug.cgi?id=158454
2991         rdar://problem/25875390
2992
2993         Reviewed by Tim Horton.
2994
2995         * WebView/PDFViewSPI.h: Added.
2996         * WebView/WebPDFView.mm:
2997         (-[WebPDFView _clipViewForPDFDocumentView]):
2998
2999 2016-06-05  Anders Carlsson  <andersca@apple.com>
3000
3001         Attempt to fix plug-in hangs by adding back empty slots for the removed messages.
3002
3003         * Plugins/Hosted/WebKitPluginClient.defs:
3004         * Plugins/Hosted/WebKitPluginHost.defs:
3005
3006 2016-06-04  Anders Carlsson  <andersca@apple.com>
3007
3008         Remove NPSPI that is no longer used
3009         https://bugs.webkit.org/show_bug.cgi?id=158384
3010
3011         Reviewed by Sam Weinig.
3012
3013         * Configurations/WebKitLegacy.xcconfig:
3014         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3015         (WKPCCheckIfAllowedToLoadURL): Deleted.
3016         (WKPCCancelCheckIfAllowedToLoadURL): Deleted.
3017         (WKPCResolveURL): Deleted.
3018         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3019         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3020         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Deleted.
3021         (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURL): Deleted.
3022         (WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL): Deleted.
3023         (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult): Deleted.
3024         (WebKit::NetscapePluginInstanceProxy::resolveURL): Deleted.
3025         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3026         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3027         (-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Deleted.
3028         (-[WebHostedNetscapePluginView _containerCheckResult:contextInfo:]): Deleted.
3029         * Plugins/Hosted/WebKitPluginClient.defs:
3030         * Plugins/WebBaseNetscapePluginView.h:
3031         * Plugins/WebBaseNetscapePluginView.mm:
3032         (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]): Deleted.
3033         * Plugins/WebNetscapeContainerCheckContextInfo.h: Removed.
3034         * Plugins/WebNetscapeContainerCheckContextInfo.mm: Removed.
3035         (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]): Deleted.
3036         (-[WebNetscapeContainerCheckContextInfo checkRequestID]): Deleted.
3037         (-[WebNetscapeContainerCheckContextInfo callback]): Deleted.
3038         (-[WebNetscapeContainerCheckContextInfo context]): Deleted.
3039         * Plugins/WebNetscapeContainerCheckPrivate.h: Removed.
3040         * Plugins/WebNetscapeContainerCheckPrivate.mm: Removed.
3041         (browserContainerCheckFuncs): Deleted.
3042         * Plugins/WebNetscapePluginView.h:
3043         * Plugins/WebNetscapePluginView.mm:
3044         (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]): Deleted.
3045         (-[WebNetscapePluginView _containerCheckResult:contextInfo:]): Deleted.
3046         (-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Deleted.
3047         (-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Deleted.
3048         (-[WebNetscapePluginView fini]): Deleted.
3049         (-[WebNetscapePluginView getVariable:value:]): Deleted.
3050         (-[WebNetscapePluginView resolveURL:forTarget:]): Deleted.
3051         * Plugins/npapi.mm:
3052         (WKN_CheckIfAllowedToLoadURL): Deleted.
3053         (WKN_CancelCheckIfAllowedToLoadURL): Deleted.
3054         (WKN_ResolveURL): Deleted.
3055
3056 2016-06-04  Anders Carlsson  <andersca@apple.com>
3057
3058         Temporary build fix. (This function is going away).
3059
3060         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3061         (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult): Deleted.
3062         * Plugins/Hosted/WebKitPluginHost.defs:
3063
3064 2016-06-03  Chris Dumez  <cdumez@apple.com>
3065
3066         Unreviewed, roll out r196633 as it broke PageCache on iOS for WebKit.org
3067         <rdar://problem/26521101>
3068
3069         * WebCoreSupport/WebVisitedLinkStore.mm:
3070         (WebVisitedLinkStore::removeAllVisitedLinks):
3071         (WebVisitedLinkStore::removeVisitedLink):
3072         (WebVisitedLinkStore::addVisitedLinkHash):
3073
3074 2016-06-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3075
3076         Add WebIDL special operation support: serializer
3077         https://bugs.webkit.org/show_bug.cgi?id=156293
3078
3079         Reviewed by Darin Adler.
3080
3081         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3082         (WebKit::HostedNetscapePluginStream::start):
3083         * Plugins/WebNetscapePluginStream.mm:
3084         (WebNetscapePluginStream::start):
3085
3086 2016-05-31  Darin Adler  <darin@apple.com>
3087
3088         Audit RenderObject casts and fix problems and style issues found
3089         https://bugs.webkit.org/show_bug.cgi?id=158221
3090
3091         Reviewed by Chris Dumez.
3092
3093         * Misc/WebNSPasteboardExtras.mm:
3094         (imageFromElement): Use auto and tighten the logic a bit.
3095         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3096         Use auto and added a comment about this not using imageFromElement.
3097
3098         * Plugins/WebBaseNetscapePluginView.mm:
3099         (-[WebBaseNetscapePluginView _windowClipRect]): Consistently cast to
3100         RenderEmbeddedObject, which is the class used for renderers for plug-ins.
3101         (-[WebBaseNetscapePluginView inFlatteningPaint]): Ditto.
3102         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]): Ditto.
3103         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]): Ditto.
3104
3105         * WebCoreSupport/WebFrameLoaderClient.mm:
3106         (WebFrameLoaderClient::createPlugin): Changed code so it does a null check
3107         rather than assuming the renderer is non-null.
3108         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
3109
3110 2016-05-31  Yusuke Suzuki  <utatane.tea@gmail.com>
3111
3112         Unreviewed, roll out r201481, r201523: 0.3% regression in Octane code-load
3113         https://bugs.webkit.org/show_bug.cgi?id=158249
3114
3115         * WebView/WebPreferencesPrivate.h:
3116
3117 2016-05-27  Chris Dumez  <cdumez@apple.com>
3118
3119         callOnMainThread() should not copy captured lambda variables
3120         https://bugs.webkit.org/show_bug.cgi?id=158166
3121
3122         Reviewed by Brady Eidson.
3123
3124         callOnMainThread() should not copy captured lambda variables. This 
3125         function is usually called cross-thread with a lambda and copying
3126         the lambda (and its captured variables) can lead to thread-safety
3127         issues.
3128
3129         This patch updates callOnMainThread() to take a NoncopyableFunction&&
3130         in parameter instead of a std::function. The call sites of
3131         callOnMainThread() have also been updated to use C++14's lambda
3132         capture with initializer.
3133
3134         * Storage/WebDatabaseManagerClient.mm:
3135         (DidModifyOriginData::dispatchToMainThread):
3136         (DidModifyOriginData::DidModifyOriginData): Deleted.
3137         * Storage/WebStorageTrackerClient.mm:
3138         (WebStorageTrackerClient::dispatchDidModifyOrigin):
3139
3140 2016-05-27  Caitlin Potter  <caitp@igalia.com>
3141
3142         [JSC] implement async functions proposal
3143         https://bugs.webkit.org/show_bug.cgi?id=156147
3144
3145         Reviewed by Yusuke Suzuki.
3146
3147         * WebView/WebPreferencesPrivate.h:
3148
3149 2016-05-26  Darin Adler  <darin@apple.com>
3150
3151         Media queries and platform screen modernization and streamlining
3152         https://bugs.webkit.org/show_bug.cgi?id=158067
3153
3154         Reviewed by Alex Christensen.
3155
3156         * WebView/WebFrame.mm:
3157         (-[WebFrame _dragSourceEndedAt:operation:]): Updated to use the new version of
3158         globalPoint, which returns an NSPoint.
3159
3160 2016-05-26  Myles C. Maxfield  <mmaxfield@apple.com>
3161
3162         Build fix
3163
3164         Rubber stamped by Lucas Forschler.
3165
3166         * Configurations/DebugRelease.xcconfig:
3167
3168 2016-05-24  Beth Dakin  <bdakin@apple.com>
3169
3170         Candidates should work with input methods
3171         https://bugs.webkit.org/show_bug.cgi?id=158042
3172         -and corresponding-
3173         rdar://problem/26205228
3174
3175         Reviewed by Tim Horton.
3176
3177         * WebView/WebHTMLView.mm:
3178         * WebView/WebView.mm:
3179         (-[WebView candidateList]):
3180         * WebView/WebViewInternal.h:
3181
3182 2016-05-22  Brady Eidson  <beidson@apple.com>
3183
3184         Move to C++14.
3185         https://bugs.webkit.org/show_bug.cgi?id=157948
3186
3187         Reviewed by Michael Catanzaro.
3188
3189         * Configurations/Base.xcconfig:
3190
3191 2016-05-20  Enrica Casucci  <enrica@apple.com>
3192
3193         Drag cannot start if no drag data or custom data is available in the Pasteboard.
3194         https://bugs.webkit.org/show_bug.cgi?id=157911
3195         rdar://problem/24577706
3196
3197         Reviewed by Tim Horton.
3198
3199         We need to make sure there is always one item in common between source and target
3200         of the drag and drop operation.
3201
3202         * WebView/WebHTMLView.mm:
3203         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3204
3205 2016-05-19  Enrica Casucci  <enrica@apple.com>
3206
3207         Drag cannot start if no drag data is available in the Pasteboard.
3208         https://bugs.webkit.org/show_bug.cgi?id=157911
3209         rdar://problem/24577706
3210
3211         Reviewed by Tim Horton.
3212
3213         * WebView/WebHTMLView.mm:
3214         (+[WebHTMLView _dummyPasteboardType]):
3215         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3216         * WebView/WebHTMLViewPrivate.h:
3217         * WebView/WebView.mm:
3218         (-[WebView _registerDraggedTypes]):
3219
3220 2016-05-19  Jer Noble  <jer.noble@apple.com>
3221
3222         [IOS] Add setting to allow playback to continue inline after exiting fullscreen.
3223         https://bugs.webkit.org/show_bug.cgi?id=157912
3224
3225         Reviewed by Eric Carlson.
3226
3227         Add a preference to control whether media should be allowed to continue playing inline when
3228         exiting fullscreen.
3229
3230         * WebView/WebPreferenceKeysPrivate.h:
3231         * WebView/WebPreferences.mm:
3232         (+[WebPreferences initialize]):
3233         (-[WebPreferences allowsInlineMediaPlaybackAfterFullscreen]):
3234         (-[WebPreferences setAllowsInlineMediaPlaybackAfterFullscreen:]):
3235         * WebView/WebPreferencesPrivate.h:
3236         * WebView/WebView.mm:
3237         (-[WebView _preferencesChanged:]):
3238
3239 2016-05-18  Brady Eidson  <beidson@apple.com>
3240
3241         Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
3242         https://bugs.webkit.org/show_bug.cgi?id=157823
3243
3244         Reviewed by Alex Christensen.
3245
3246         * Storage/WebDatabaseManager.mm:
3247         (-[WebDatabaseManager deleteAllIndexedDatabases]):
3248         * Storage/WebDatabaseManagerPrivate.h:
3249
3250 2016-05-17  Beth Dakin  <bdakin@apple.com>
3251
3252         Make handleAcceptedCandidate a public function
3253         https://bugs.webkit.org/show_bug.cgi?id=157763
3254         -and corresponding-
3255         rdar://problem/26206397
3256
3257         Reviewed by Tim Horton.
3258
3259         This patch re-names handleAcceptedCandidate to 
3260         handleAcceptedCandidateWithSoftSpaces. The function now takes a 
3261         WebCore::TextCheckingResult instead of an NSTextCheckingResult and it can be 
3262         called from outside of WebEditorClient.
3263
3264         * WebCoreSupport/WebEditorClient.h:
3265         * WebCoreSupport/WebEditorClient.mm:
3266         (WebEditorClient::handleRequestedCandidates):
3267         (WebEditorClient::handleAcceptedCandidateWithSoftSpaces):
3268         (textCheckingResultFromNSTextCheckingResult): Deleted.
3269         (WebEditorClient::handleAcceptedCandidate): Deleted.
3270
3271         Move showCandidates to WebViewPrivate so that it can be overridden by a test.
3272         * WebView/WebViewInternal.h:
3273         * WebView/WebViewPrivate.h:
3274
3275 2016-05-17  Dean Jackson  <dino@apple.com>
3276
3277         Remove ES6_GENERATORS flag
3278         https://bugs.webkit.org/show_bug.cgi?id=157815
3279         <rdar://problem/26332894>
3280
3281         Reviewed by Geoffrey Garen.
3282
3283         This flag isn't needed. Generators are enabled everywhere and
3284         part of a stable specification.
3285
3286         * Configurations/FeatureDefines.xcconfig:
3287
3288 2016-05-17  Filip Pizlo  <fpizlo@apple.com>
3289
3290         WTF should know about Language
3291         https://bugs.webkit.org/show_bug.cgi?id=157756
3292
3293         Reviewed by Geoffrey Garen.
3294
3295         Rewires a bunch of includes/imports.
3296
3297         * WebCoreSupport/PopupMenuMac.mm:
3298         * WebCoreSupport/WebChromeClient.mm:
3299         * WebCoreSupport/WebFrameLoaderClient.mm:
3300         * WebCoreSupport/WebGeolocationClient.mm:
3301         * WebCoreSupport/WebNotificationClient.mm:
3302         * WebCoreSupport/WebPlatformStrategies.mm:
3303         * WebCoreSupport/WebUserMediaClient.mm:
3304         * WebCoreSupport/WebVisitedLinkStore.mm:
3305         * WebView/WebHTMLView.mm:
3306
3307 2016-05-13  Enrica Casucci  <enrica@apple.com>
3308
3309         Remove unused initializer for WebEvent on iOS.
3310         https://bugs.webkit.org/show_bug.cgi?id=157689
3311
3312         Reviewed by Anders Carlsson.
3313
3314         Removing use of characterSet property.
3315
3316         * WebView/WebHTMLView.mm:
3317         (-[WebHTMLView _handleEditingKeyEvent:]):
3318
3319
3320 2016-05-13  Commit Queue  <commit-queue@webkit.org>
3321
3322         Unreviewed, rolling out r200894.
3323         https://bugs.webkit.org/show_bug.cgi?id=157695
3324
3325         This change broke the iOS build (Requested by ryanhaddad on
3326         #webkit).
3327
3328         Reverted changeset:
3329
3330         "Remove unused initializer for WebEvent on iOS."
3331         https://bugs.webkit.org/show_bug.cgi?id=157689
3332         http://trac.webkit.org/changeset/200894
3333
3334 2016-05-13  Enrica Casucci  <enrica@apple.com>
3335
3336         Remove unused initializer for WebEvent on iOS.
3337         https://bugs.webkit.org/show_bug.cgi?id=157689
3338
3339         Reviewed by Anders Carlsson.
3340
3341         Removing use of characterSet property.
3342
3343         * WebView/WebHTMLView.mm:
3344         (-[WebHTMLView _handleEditingKeyEvent:]):
3345
3346 2016-05-13  Beth Dakin  <bdakin@apple.com>
3347
3348         Build fix.
3349
3350         * WebView/WebView.mm:
3351
3352 2016-05-13  Beth Dakin  <bdakin@apple.com>
3353
3354         Add dyldSPI.h for linked on or after checks, and add one for link preview
3355         https://bugs.webkit.org/show_bug.cgi?id=157401
3356         -and corresponding-
3357         rdar://problem/26253396
3358
3359         Reviewed by Darin Adler.
3360
3361         This patch removes DynamicLinkerSPI.h and replaces it with 
3362         wtf/spi/darwin/dyldSPI.h
3363
3364         * WebView/WebView.mm:
3365
3366 2016-05-13  Tina Liu  <iting_liu@apple.com>
3367
3368         Revert r199691.
3369         https://bugs.webkit.org/show_bug.cgi?id=157645
3370         <rdar://problem/26235373>
3371
3372         Reviewed by Darin Adler.
3373
3374         * WebCoreSupport/WebPlatformStrategies.h:
3375         * WebCoreSupport/WebPlatformStrategies.mm:
3376         (WebPlatformStrategies::setPrivateBrowsingPluginLoadClientPolicy): Deleted.
3377
3378 2016-05-12  Jiewen Tan  <jiewen_tan@apple.com>
3379
3380         Unreviewed build fix for r200799.
3381
3382         * WebView/WebView.mm:
3383
3384 2016-05-12  Jiewen Tan  <jiewen_tan@apple.com>
3385
3386         REGRESSION (r199313): ICBC app: text field In the webview is not tappable
3387         https://bugs.webkit.org/show_bug.cgi?id=157396
3388         <rdar://problem/25931513>
3389
3390         Reviewed by David Kilzer.
3391
3392         Add a quirk for WebKit1 apps.
3393
3394         * WebView/WebView.mm:
3395         (shouldConvertInvalidURLsToBlank):
3396         (-[WebView _preferencesChanged:]):
3397
3398 2016-05-12  Beth Dakin  <bdakin@apple.com>
3399
3400         WebKitAdditions needs to be notified before the WebView is dealloc'd
3401         https://bugs.webkit.org/show_bug.cgi?id=157633
3402         -and corresponding-
3403         rdar://problem/26134539
3404
3405         Reviewed by Anders Carlsson.
3406
3407         * WebView/WebView.mm:
3408         (-[WebView dealloc]):
3409         * WebView/WebViewInternal.h:
3410
3411 2016-05-12  Konstantin Tokarev  <annulen@yandex.ru>
3412
3413         Use reference instead of pointer in FrameLoaderClient::saveViewStateToItem.
3414         https://bugs.webkit.org/show_bug.cgi?id=157624
3415
3416         Reviewed by Darin Adler.
3417
3418         * WebCoreSupport/WebFrameLoaderClient.h:
3419         * WebCoreSupport/WebFrameLoaderClient.mm:
3420         (WebFrameLoaderClient::saveViewStateToItem):
3421         * WebView/WebFrame.mm:
3422         (-[WebFrame _saveViewState]):
3423
3424 2016-05-12  Csaba Osztrogonác  <ossy@webkit.org>
3425
3426         Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
3427         https://bugs.webkit.org/show_bug.cgi?id=157564
3428
3429         Reviewed by Darin Adler.
3430
3431         * Configurations/FeatureDefines.xcconfig:
3432
3433 2016-05-11  Chris Dumez  <cdumez@apple.com>
3434
3435         Update Node::appendChild() / replaceChild() / removeChild() / insertBefore() to take references instead of pointers
3436         https://bugs.webkit.org/show_bug.cgi?id=157556
3437
3438         Reviewed by Darin Adler.
3439
3440         * WebView/WebFrame.mm:
3441         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
3442
3443 2016-05-10  Shaw rich  <richshaw@126.com>
3444
3445         [OS X] Compatible with gnu sed grammar due to compile error with gnu sed
3446         https://bugs.webkit.org/show_bug.cgi?id=157526
3447
3448         Reviewed by Darin Adler.
3449
3450         * MigrateHeaders.make:
3451
3452 2016-05-10  Simon Fraser  <simon.fraser@apple.com>
3453
3454         [iOS WK1] text autosizing was on for all layout tests
3455         https://bugs.webkit.org/show_bug.cgi?id=157541
3456
3457         Reviewed by Tim Horton.
3458
3459         Make sure that we transfer the WK1 text autosizing preference to Settings.
3460
3461         * WebView/WebView.mm:
3462         (-[WebView _preferencesChanged:]):
3463
3464 2016-05-09  Tim Horton  <timothy_horton@apple.com>
3465
3466         [WebKit1] Invoking a link preview on a complex link (e.g. an image) results in an empty TextIndicator
3467         https://bugs.webkit.org/show_bug.cgi?id=157497
3468         <rdar://problem/25872773>
3469
3470         Reviewed by Anders Carlsson.
3471
3472         * WebView/WebImmediateActionController.mm:
3473         (-[WebImmediateActionController _defaultAnimationController]):
3474         r198578 fixed this for WebKit2, but forgot about WebKit1.
3475
3476 2016-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3477
3478         [OS X] Migrate our Font classes entirely off of NSFont
3479         https://bugs.webkit.org/show_bug.cgi?id=157464
3480
3481         Reviewed by Darin Adler.
3482
3483         * WebCoreSupport/PopupMenuMac.mm:
3484         (PopupMenuMac::populate):
3485         (PopupMenuMac::show):
3486         * WebView/WebHTMLView.mm:
3487         (fontNameForDescription):
3488         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3489
3490 2016-05-06  Joseph Pecoraro  <pecoraro@apple.com>
3491
3492         Rename HitTestRequest DisallowShadowContent to DisallowUserAgentShadowContent
3493         https://bugs.webkit.org/show_bug.cgi?id=157447
3494
3495         Reviewed by Ryosuke Niwa.
3496
3497         * WebView/WebFrame.mm:
3498         (-[WebFrame elementAtPoint:]):
3499         * WebView/WebHTMLView.mm:
3500         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
3501
3502 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
3503
3504         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
3505         https://bugs.webkit.org/show_bug.cgi?id=157432
3506         rdar://problem/16406720
3507
3508         Reviewed by Dean Jackson.
3509
3510         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
3511
3512         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
3513         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
3514         These two settings are shared with TEXT_AUTOSIZING.
3515
3516         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
3517
3518         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
3519         without changes.
3520
3521         An implication of this set of changes is that the way clients enable text autosizing
3522         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
3523         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
3524         on iPhone only, not iPad.
3525
3526         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
3527         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
3528
3529         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
3530         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
3531         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
3532
3533         * Configurations/FeatureDefines.xcconfig:
3534         * WebView/WebPreferenceKeysPrivate.h:
3535         * WebView/WebPreferences.mm:
3536         (+[WebPreferences initialize]):
3537         (-[WebPreferences _setTextAutosizingEnabled:]):
3538         (-[WebPreferences _textAutosizingEnabled]):
3539         * WebView/WebPreferencesPrivate.h:
3540
3541 2016-05-06  Dean Jackson  <dino@apple.com>
3542
3543         Regions, Shapes and Tracks don't need runtime features
3544         https://bugs.webkit.org/show_bug.cgi?id=157426
3545         <rdar://problem/26146262>
3546
3547         Reviewed by Simon Fraser.
3548
3549         The following RuntimeEnabledFeatures can be removed since
3550         we have no need to disable them (they are stable and have
3551         shipped for a while):
3552         - CSS Regions
3553         - CSS Shapes
3554         - Media tracks
3555
3556         * WebView/WebPreferenceKeysPrivate.h:
3557         * WebView/WebPreferences.mm:
3558         (+[WebPreferences initialize]): Deleted.
3559         (-[WebPreferences cssRegionsEnabled]): Deleted.
3560         (-[WebPreferences setCSSRegionsEnabled:]): Deleted.
3561         (-[WebPreferences cssCompositingEnabled]): Deleted.
3562         (-[WebPreferences setCSSCompositingEnabled:]): Deleted.
3563         * WebView/WebPreferencesPrivate.h:
3564         * WebView/WebView.mm:
3565         (-[WebView _preferencesChanged:]): Deleted.
3566
3567 2016-05-06  Daniel Bates  <dabates@apple.com>
3568
3569         Remove workaround for Apple Internal bots
3570         <rdar://problem/25989808>
3571
3572         Reverts the workaround added in r200211 as it is no longer needed.
3573
3574         * WebView/WebPDFView.h:
3575
3576 2016-05-02  Daniel Bates  <dabates@apple.com>
3577
3578         CSP: Add workaround for XtraMath
3579         https://bugs.webkit.org/show_bug.cgi?id=157252
3580
3581         Reviewed by Andy Estes.
3582
3583         * WebView/WebView.mm:
3584         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol): Allow * to match any protocol for
3585         applicable versions of app XtraMath.
3586
3587 2016-05-02  Daniel Bates  <dabates@apple.com>
3588
3589         DatabaseTracker::closeAllDatabases calls Database::close from the wrong thread
3590         https://bugs.webkit.org/show_bug.cgi?id=147672
3591         <rdar://problem/22357464>
3592
3593         Reviewed by Brady Eidson.
3594
3595         Update the background assertion expiration callback to call DatabaseTracker::closeAllDatabases()
3596         with CurrentQueryBehavior::Interrupt so that we abort a long running query and close the database
3597         immediately to avoid holding a locked file when the process is suspended.
3598
3599         * Storage/WebDatabaseManager.mm:
3600         (+[WebDatabaseManager startBackgroundTask]):
3601
3602 2016-04-29  Dean Jackson  <dino@apple.com>
3603
3604         RTL <select> popup menu is in the wrong location
3605         https://bugs.webkit.org/show_bug.cgi?id=157159
3606         <rdar://problem/25894451>
3607
3608         Reapply http://trac.webkit.org/changeset/200217
3609         but with changes that will allow it to build on Yosemite.
3610
3611         * WebCoreSupport/PopupMenuMac.mm:
3612         (PopupMenuMac::show):
3613
3614 2016-04-29  Commit Queue  <commit-queue@webkit.org>
3615
3616         Unreviewed, rolling out r200217.
3617         https://bugs.webkit.org/show_bug.cgi?id=157183
3618
3619         This change broke the Yosemite build. (Requested by ryanhaddad
3620         on #webkit).
3621
3622         Reverted changeset:
3623
3624         "RTL <select> popup menu is in the wrong location"
3625         https://bugs.webkit.org/show_bug.cgi?id=157159
3626         http://trac.webkit.org/changeset/200217
3627
3628 2016-04-28  Dean Jackson  <dino@apple.com>
3629
3630         RTL <select> popup menu is in the wrong location
3631         https://bugs.webkit.org/show_bug.cgi?id=157159
3632         <rdar://problem/25894451>
3633
3634         Reviewed by Simon Fraser.
3635
3636         Make sure both the NSPopupMenuCell and the NSPopupMenu take
3637         the text direction into account, and offset the position
3638         of the menu slightly if we're in RTL mode.
3639
3640         Unfortunately our test infrastructure is unable to exercise
3641         this because it runs without a window, and the popup menu
3642         is not captured in the screenshot.
3643
3644         * WebCoreSupport/PopupMenuMac.mm:
3645         (PopupMenuMac::show):
3646
3647 2016-04-28  Manuel Rego Casasnovas  <rego@igalia.com>
3648
3649         [css-grid] Add CSS Grid Layout runtime flag
3650         https://bugs.webkit.org/show_bug.cgi?id=157134
3651
3652         Reviewed by Simon Fraser.
3653
3654         Add CSS Grid Layout runtime flag based on preferences,
3655         enabled by default.
3656
3657         * WebView/WebPreferenceKeysPrivate.h:
3658         * WebView/WebPreferences.mm:
3659         (+[WebPreferences initialize]):
3660         (-[WebPreferences isCSSGridLayoutEnabled]):
3661         (-[WebPreferences setCSSGridLayoutEnabled:]):
3662         * WebView/WebPreferencesPrivate.h:
3663         * WebView/WebView.mm:
3664         (-[WebView _preferencesChanged:]):
3665
3666 2016-04-28  Daniel Bates  <dabates@apple.com>
3667
3668         Another fix for the Apple Internal OS X build
3669         <rdar://problem/25989808>
3670
3671         Reviewed by Anders Carlsson.
3672
3673         * WebView/WebPDFView.h:
3674
3675 2016-04-28  Daniel Bates  <dabates@apple.com>
3676
3677         Fix the Apple Internal OS X build
3678
3679         * WebView/WebPDFView.h: Import PDFKit for definition of protocol PDFViewDelegate.
3680         Forward declare protocol PDFViewDelegate as appropriate. Mark WebPDFView as implementing
3681         protocol PDFViewDelegate.
3682         * WebView/WebPDFView.mm: Move import of PDFKit from here to the header.
3683
3684 2016-04-27  Daniel Bates  <dabates@apple.com>
3685
3686         CSP: Add app-specific workaround for Ecobee and Quora
3687         https://bugs.webkit.org/show_bug.cgi?id=157005
3688         <rdar://problem/25560776>
3689
3690         Reviewed by Brent Fulgham.
3691
3692         * Misc/WebKitVersionChecks.h:
3693         * WebView/WebView.mm:
3694         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol): Added.
3695         (-[WebView _preferencesChanged:]): Enable setting allowContentSecurityPolicySourceStarToMatchAnyProtocol
3696         if applicable.
3697
3698 2016-04-26  Joseph Pecoraro  <pecoraro@apple.com>
3699
3700         Uncaught Exception: SecurityError: DOM Exception 18: An attempt was made to break through the security policy of the user agent.
3701         https://bugs.webkit.org/show_bug.cgi?id=156991
3702         <rdar://problem/25913475>
3703
3704         Reviewed by Timothy Hatcher.
3705
3706         * WebCoreSupport/WebInspectorClient.mm:
3707         (-[WebInspectorWindowController init]):
3708         Apply the same universal file access to WebKit1 Web Inspector views that
3709         we apply to WebKit2 views. Explicitly always allow access to storage
3710         for Web Inspector content just in case as we already allow universal
3711         file access.
3712
3713 2016-04-26  Beth Dakin  <bdakin@apple.com>
3714
3715         Check to make sure shouldRequestCandidates() before requesting candidates
3716         https://bugs.webkit.org/show_bug.cgi?id=157038
3717         -and corresponding-
3718         rdar://problem/25910418
3719
3720         Reviewed by Tim Horton.
3721
3722         This patch limits requesting and showing candidates to cases where 
3723         shouldRequestCandidates() is true. This patch also caches the sequence number 
3724         returned by [NSSpellChecker requestCandidatesForSelectedRange:] to make sure 
3725         it is equal to the sequence number sent to the callback handler so that we do 
3726         not show candidates for old requests.
3727
3728         * WebCoreSupport/WebEditorClient.h:
3729         * WebCoreSupport/WebEditorClient.mm:
3730         (WebEditorClient::requestCandidatesForSelection):
3731         (WebEditorClient::handleRequestedCandidates):
3732         * WebView/WebView.mm:
3733         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3734         (-[WebView shouldRequestCandidates]):
3735         * WebView/WebViewInternal.h:
3736
3737 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3738
3739         Remove the build flag for template elements
3740         https://bugs.webkit.org/show_bug.cgi?id=157022
3741
3742         Reviewed by Daniel Bates.
3743
3744         * Configurations/FeatureDefines.xcconfig:
3745
3746 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
3747
3748         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
3749         https://bugs.webkit.org/show_bug.cgi?id=156929
3750
3751         Reviewed by Darin Adler.
3752
3753         * Misc/WebKitNSStringExtras.mm:
3754         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Drawing
3755         a string with a null font shouldn't do anything.
3756         * Misc/WebStringTruncator.mm: We can't truncate a string if we don't have a font
3757         to use.
3758         (+[WebStringTruncator centerTruncateString:toWidth:]):
3759         (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
3760         (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
3761         (+[WebStringTruncator widthOfString:font:]):
3762
3763 2016-04-25  Beth Dakin  <bdakin@apple.com>
3764
3765         WebEditorClient should properly write to m_rangeForCandidates
3766         https://bugs.webkit.org/show_bug.cgi?id=157003
3767         -and corresponding-
3768         rdar://problem/25910418
3769
3770         Reviewed by Tim Horton.
3771
3772         Actually write to m_rangeForCandidates instead of declaring a local variable 
3773         of the same name. :-/
3774         * WebCoreSupport/WebEditorClient.mm:
3775         (WebEditorClient::requestCandidatesForSelection):
3776
3777 2016-04-23  Andy Estes  <aestes@apple.com>
3778
3779         Fix issues found by the clang static analyzer
3780         https://bugs.webkit.org/show_bug.cgi?id=156956
3781
3782         Reviewed by Alexey Proskuryakov.
3783
3784         * WebView/WebDeviceOrientationProviderMock.mm:
3785         (-[WebDeviceOrientationProviderMock dealloc]): [super dealloc] should be called last.
3786
3787 2016-04-21  Tim Horton  <timothy_horton@apple.com>
3788
3789         Fix the iOS build: WAKView may not respond to drawLayer:inContext:
3790         https://bugs.webkit.org/show_bug.cgi?id=156879
3791         <rdar://problem/25772661>
3792
3793         Reviewed by Beth Dakin.
3794
3795         * WebView/WebHTMLView.mm:
3796         WebHTMLView on iOS never uses drawLayer:inContext:, and WAKView
3797         doesn't implement it, so this would have thrown an exception
3798         if called, anyway. Fix the build with stricter CA protocols.
3799
3800 2016-04-21  Jer Noble  <jer.noble@apple.com>
3801
3802         [WK1] Add WebPlaybackSession support to WebKit
3803         https://bugs.webkit.org/show_bug.cgi?id=156854
3804
3805         Reviewed by Beth Dakin.
3806
3807         Add support for WebPlaybackSession and the ChromeClient methods setUpPlaybackControlsManager() and
3808         clearPlaybackControlsManager() to WebKit.
3809
3810         * WebCoreSupport/WebChromeClient.h:
3811         * WebCoreSupport/WebChromeClient.mm:
3812         (WebChromeClient::setUpPlaybackControlsManager):
3813         (WebChromeClient::clearPlaybackControlsManager):
3814         * WebView/WebView.mm:
3815         (-[WebView _hasActiveVideoForControlsInterface]):
3816         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3817         (-[WebView _clearPlaybackControlsManagerForMediaElement:]):
3818         * WebView/WebViewData.h:
3819         * WebView/WebViewData.mm:
3820         * WebView/WebViewInternal.h:
3821
3822 2016-04-21  Anders Carlsson  <andersca@apple.com>
3823
3824         Stop using ApplicationCacheStorage::singleton() in WebKitLegacy
3825         https://bugs.webkit.org/show_bug.cgi?id=156859
3826
3827         Reviewed by Tim Horton.
3828
3829         * WebCoreSupport/WebApplicationCache.mm:
3830         (+[WebApplicationCache initializeWithBundleIdentifier:]):
3831         Change this to just store the bundle identifier.
3832
3833         (applicationCacheBundleIdentifier):
3834         Helper function that returns the bundle identifier for the app cache.
3835
3836         (applicationCachePath):
3837         Return the application cache path.
3838
3839         (webApplicationCacheStorage):
3840         Create a new ApplicationCacheStorage object.
3841
3842         * WebView/WebView.mm:
3843         (-[WebView _commonInitializationWithFrameName:groupName:]):
3844         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3845         Set pageConfiguration.applicationCacheStorage to webApplicationCacheStorage().
3846
3847         (WebKitInitializeApplicationCachePathIfNecessary): Deleted.
3848
3849 2016-04-21  Beth Dakin  <bdakin@apple.com>
3850
3851         showCandidates() should take a range and the string should be the whole 
3852         paragraph
3853         https://bugs.webkit.org/show_bug.cgi?id=156813
3854         -and corresponding-
3855         rdar://problem/25760533
3856
3857         Reviewed by Tim Horton.
3858
3859         Cache the range and the paragraph since we compute them in 
3860         requestCandidatesForSelection, and then we can use them again in 
3861         handleRequestedCandidates.
3862         * WebCoreSupport/WebEditorClient.h:
3863         * WebCoreSupport/WebEditorClient.mm:
3864         (WebEditorClient::requestCandidatesForSelection):
3865         (WebEditorClient::handleRequestedCandidates):
3866         * WebView/WebView.mm:
3867         (-[WebView updateWebViewAdditions]):
3868         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3869         (-[WebView showCandidates:forString:inRect:view:completionHandler:]): Deleted.
3870         * WebView/WebViewInternal.h:
3871
3872 2016-04-21  Chris Dumez  <cdumez@apple.com>
3873
3874         Drop [UsePointersEvenForNonNullableObjectArguments] from Range
3875         https://bugs.webkit.org/show_bug.cgi?id=156805
3876
3877         Reviewed by Youenn Fablet.
3878
3879         * WebView/WebFrame.mm:
3880         (-[WebFrame _smartDeleteRangeForProposedRange:]):
3881
3882 2016-04-20  Brady Eidson  <beidson@apple.com>
3883
3884         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
3885         https://bugs.webkit.org/show_bug.cgi?id=156782
3886
3887         Reviewed by Alex Christensen.
3888
3889         * Configurations/FeatureDefines.xcconfig:
3890
3891 2016-04-18  Anders Carlsson  <andersca@apple.com>
3892
3893         Fix build with newer versions of clang.
3894         rdar://problem/25749769
3895
3896         * WebCoreSupport/WebContextMenuClient.mm:
3897         * WebView/WebHTMLView.mm:
3898         Forward declare some AppKit IPI.
3899
3900 2016-04-18  Tina Liu  <iting_liu@apple.com>
3901
3902         Overrode a virtual function of WebCore::PluginStrategy
3903         https://bugs.webkit.org/show_bug.cgi?id=156540
3904
3905         Reviewed by Anders Carlsson.
3906
3907         * WebCoreSupport/WebPlatformStrategies.h:
3908         * WebCoreSupport/WebPlatformStrategies.mm:
3909         (WebPlatformStrategies::setPrivateBrowsingPluginLoadClientPolicy):
3910
3911 2016-04-18  Brent Fulgham  <bfulgham@apple.com>
3912
3913         CSP: Remove stubs for dynamically-added favicons (via link rel="icon")
3914         https://bugs.webkit.org/show_bug.cgi?id=153151
3915         <rdar://problem/24383176>
3916
3917         Reviewed by Darin Adler.
3918
3919         Remove the unused dynamic favicon code and tests.
3920
3921         * WebCoreSupport/WebFrameLoaderClient.h:
3922         * WebCoreSupport/WebFrameLoaderClient.mm:
3923         (WebFrameLoaderClient::dispatchDidChangeIcons): Deleted.
3924
3925 2016-04-15  Darin Adler  <darin@apple.com>
3926
3927         Reduce use of Deprecated::ScriptXXX classes
3928         https://bugs.webkit.org/show_bug.cgi?id=156632
3929
3930         Reviewed by Alex Christensen.
3931
3932         * WebView/WebFrame.mm:
3933         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Use references instead
3934         of pointers.
3935         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Updated
3936         since return value is a JSValue.
3937         * WebView/WebView.mm:
3938         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3939
3940 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
3941
3942         Make <a download> a runtime enabled option
3943         https://bugs.webkit.org/show_bug.cgi?id=156583
3944         <rdar://problem/25733449>
3945
3946         Reviewed by Alex Christensen.
3947
3948         Add a download attribute runtime flag based on preferences.
3949         Disable the download attribute by default.
3950
3951         * WebView/WebPreferenceKeysPrivate.h:
3952         * WebView/WebPreferences.mm:
3953         (+[WebPreferences initialize]):
3954         (-[WebPreferences setFetchAPIEnabled:]):
3955         (-[WebPreferences downloadAttributeEnabled]):
3956         (-[WebPreferences setDownloadAttributeEnabled:]):
3957         * WebView/WebPreferencesPrivate.h:
3958         * WebView/WebView.mm:
3959         (-[WebView _preferencesChanged]): Set the runtime flag properly
3960         based on the user preferences.
3961
3962 2016-04-09  Gavin Barraclough  <barraclough@apple.com>
3963
3964         WebKit should adopt journal_mode=wal for all SQLite databases.
3965         https://bugs.webkit.org/show_bug.cgi?id=133496
3966
3967         Reviewed by Darin Adler.
3968
3969         * Storage/WebDatabaseManagerPrivate.h:
3970             - renamed deleteAllDatabases -> deleteAllDatabasesImmediately.
3971
3972 2016-04-05  Oliver Hunt  <oliver@apple.com>
3973
3974         Remove compile time define for SEPARATED_HEAP
3975         https://bugs.webkit.org/show_bug.cgi?id=155508
3976
3977         Reviewed by Mark Lam.
3978
3979         * Configurations/FeatureDefines.xcconfig:
3980
3981 2016-04-08  Sam Weinig  <sam@webkit.org>
3982
3983         Remove support for custom target picker actions
3984         <rdar://problem/24987783>
3985         https://bugs.webkit.org/show_bug.cgi?id=156434
3986
3987         Reviewed by Eric Carlson.
3988
3989         This mostly entailed rolling out r197429 and r197569.
3990
3991         * WebCoreSupport/WebChromeClient.h:
3992         * WebCoreSupport/WebChromeClient.mm:
3993         (WebChromeClient::removePlaybackTargetPickerClient):
3994         (WebChromeClient::showPlaybackTargetPicker):
3995         * WebView/WebMediaPlaybackTargetPicker.h:
3996         * WebView/WebMediaPlaybackTargetPicker.mm:
3997         (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
3998         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3999         (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
4000         (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget):
4001         (WebMediaPlaybackTargetPicker::invalidate):
4002         (WebMediaPlaybackTargetPicker::customPlaybackActionSelected): Deleted.
4003         * WebView/WebView.mm:
4004         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
4005         (-[WebView _playbackTargetPickerClientStateDidChange:state:]):
4006
4007 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
4008
4009         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
4010         https://bugs.webkit.org/show_bug.cgi?id=156384
4011
4012         Reviewed by Ryosuke Niwa.
4013
4014         * Configurations/FeatureDefines.xcconfig:
4015
4016 2016-04-07  Brian Burg  <bburg@apple.com>
4017
4018         CookieJar should support adding synthetic cookies for developer tools
4019         https://bugs.webkit.org/show_bug.cgi?id=156091
4020         <rdar://problem/25581340>
4021
4022         Reviewed by Timothy Hatcher.
4023
4024         * WebCoreSupport/WebPlatformStrategies.h:
4025         * WebCoreSupport/WebPlatformStrategies.mm:
4026         (WebPlatformStrategies::addCookie):
4027         Add new method override.
4028
4029 2016-04-06  Alex Christensen  <achristensen@webkit.org>
4030
4031         Fix CMake DumpRenderTree
4032         https://bugs.webkit.org/show_bug.cgi?id=156305
4033
4034         Reviewed by Daniel Bates.
4035
4036         * WebKitPrefix.h:
4037
4038 2016-04-05  Beth Dakin  <bdakin@apple.com>
4039
4040         Make requestCandidatesForSelection available on any EditorClient
4041         https://bugs.webkit.org/show_bug.cgi?id=156253
4042         -and corresponding-
4043         rdar://problem/24661147
4044
4045         Reviewed by Dean Jackson.
4046
4047         * WebCoreSupport/WebEditorClient.h:
4048
4049 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4050
4051         [Fetch API] Add a runtime flag to fetch API and related constructs
4052         https://bugs.webkit.org/show_bug.cgi?id=156113
4053  
4054         Reviewed by Alex Christensen.
4055
4056         Add a fetch API runtime flag based on preferences.
4057         Disable fetch API by default.
4058  
4059         * WebView/WebPreferenceKeysPrivate.h:
4060         * WebView/WebPreferences.mm:
4061         (+[WebPreferences initialize]):
4062         (-[WebPreferences setCustomElementsEnabled:]):
4063         (-[WebPreferences fetchAPIEnabled]):
4064         (-[WebPreferences setFetchAPIEnabled:]):
4065         * WebView/WebPreferencesPrivate.h:
4066         * WebView/WebView.mm:
4067         (-[WebView _preferencesChanged:]):
4068         (-[WebView preferencesIdentifier]):
4069         (-[WebView setUIDelegate:]):
4070
4071 2016-04-05  Antoine Quint  <graouts@apple.com>
4072
4073         [WebGL2] Turn the ENABLE_WEBGL2 flag on
4074         https://bugs.webkit.org/show_bug.cgi?id=156061
4075         <rdar://problem/25463193>
4076
4077         Reviewed by Alex Christensen.
4078
4079         * Configurations/FeatureDefines.xcconfig:
4080
4081 2016-04-05  Antoine Quint  <graouts@apple.com>
4082
4083         [WebGL2] Allow enabling WebGL2 with a runtime flag
4084         https://bugs.webkit.org/show_bug.cgi?id=156166
4085         <rdar://problem/25526929>
4086
4087         Set the WebGL2 runtime flag based on preferences, disabled by default.
4088
4089         Reviewed by Dean Jackson.
4090
4091         * WebView/WebPreferenceKeysPrivate.h:
4092         * WebView/WebPreferences.mm:
4093         (+[WebPreferences initialize]):
4094         (-[WebPreferences webGL2Enabled]):
4095         (-[WebPreferences setWebGL2Enabled:]):
4096         * WebView/WebPreferencesPrivate.h:
4097         * WebView/WebView.mm:
4098         (-[WebView _preferencesChanged:]):
4099
4100 2016-04-01  Alex Christensen  <achristensen@webkit.org>
4101
4102         Compile DumpRenderTree with CMake on Mac
4103         https://bugs.webkit.org/show_bug.cgi?id=156088
4104
4105         Reviewed by Brent Fulgham.
4106
4107         * Misc/WebKit.h:
4108         Alphabetize headers.
4109
4110 2016-03-31  Jeremy Jones  <jeremyj@apple.com>
4111
4112         mediaShouldUsePersistentCache() is redundant. Use Page::usesEphemeralSession() instead.
4113         https://bugs.webkit.org/show_bug.cgi?id=155924
4114
4115         Reviewed by Simon Fraser.
4116
4117         Remove mediaShouldUsePersistentCache machinery as it is redundant.
4118
4119         * WebCoreSupport/WebChromeClient.h:
4120         * WebCoreSupport/WebChromeClient.mm:
4121         (WebChromeClient::mediaShouldUsePersistentCache): Deleted.
4122
4123 2016-03-30  Ada Chan  <adachan@apple.com>
4124
4125         Add the new "toggle enhanced fullscreen" context menu item to the video context menu on supporting platforms.
4126         https://bugs.webkit.org/show_bug.cgi?id=156031
4127
4128         Reviewed by Eric Carlson.
4129
4130         * WebView/WebHTMLView.mm:
4131         (toAction):
4132         (toTag):
4133         * WebView/WebUIDelegatePrivate.h:
4134
4135 2016-03-24  Said Abou-Hallawa  <sabouhallawa@apple,com>
4136
4137         Change NativeImagePtr for CG to be RetainPtr<CGImageRef>
4138         https://bugs.webkit.org/show_bug.cgi?id=155412
4139
4140         Reviewed by Darin Adler.
4141
4142         * Misc/WebCache.mm:
4143         (+[WebCache addImageToCache:forURL:forFrame:]):
4144         WebCore::MemoryCache() is taking an rvalue NativeImagePtr. We need to create
4145         NativeImagePtr from the image raw pointer when calling this function.
4146
4147 2016-03-24  Tim Horton  <timothy_horton@apple.com>
4148
4149         Fix some new PDFKit-related warnings
4150         https://bugs.webkit.org/show_bug.cgi?id=155847
4151         <rdar://problem/25340312>
4152
4153         Reviewed by Anders Carlsson.
4154
4155         * WebView/WebPDFView.mm:
4156         (-[WebPDFView setViewState:]):
4157         * WebView/WebPreferences.mm:
4158         (-[WebPreferences PDFDisplayMode]):
4159         PDFDisplayMode is now a real enum.
4160
4161 2016-03-23  Anders Carlsson  <andersca@apple.com>
4162
4163         Crash when using KVO from within -[WebView initWithCoder:]
4164         https://bugs.webkit.org/show_bug.cgi?id=155816
4165         rdar://problem/17073265
4166
4167         Reviewed by Dan Bernstein.
4168
4169         Get rid of the observationInfo getter and setter. It's not clear why they were added (in 2003),
4170         and the methods on NSObject are good enough for us.
4171
4172         * WebView/WebView.mm:
4173         (-[WebView setObservationInfo:]): Deleted.
4174         (-[WebView observationInfo]): Deleted.
4175         * WebView/WebViewData.h:
4176
4177 2016-03-22  Beth Dakin  <bdakin@apple.com>
4178
4179         Advanced spell checking should be guarded behind 
4180         HAVE(ADVANCED_SPELL_CHECKING)
4181         https://bugs.webkit.org/show_bug.cgi?id=155738
4182
4183         Reviewed by Geoff Garen.
4184
4185         * WebCoreSupport/WebEditorClient.mm:
4186         (insertionPointFromCurrentSelection):
4187         (WebEditorClient::checkTextOfParagraph):
4188         (WebEditorClient::getGuessesForWord):
4189         (WebEditorClient::requestCandidatesForSelection):
4190         (WebEditorClient::handleRequestedCandidates):
4191         (WebEditorClient::requestCheckingOfString):
4192         * WebKitPrefix.h:
4193         * WebView/WebHTMLView.mm:
4194         (-[WebHTMLView insertText:]):
4195
4196 2016-03-20  Dan Bernstein  <mitz@apple.com>
4197
4198         [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
4199         https://bugs.webkit.org/show_bug.cgi?id=155707
4200         <rdar://problem/24980691>
4201
4202         Reviewed by Darin Adler.
4203