df820ae846dd36b79e716591503edde745e7a565
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-01-12  Chris Dumez  <cdumez@apple.com>
2
3         HTML form validation popover sometimes does not go away
4         https://bugs.webkit.org/show_bug.cgi?id=166990
5         <rdar://problem/29985957>
6
7         Reviewed by Tim Horton.
8
9         Update code using ValidationBubble now that it is RefCounted.
10
11         * WebView/WebView.mm:
12         (-[WebView showFormValidationMessage:withAnchorRect:]):
13
14 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
15
16         Remove pointerLockElement from DOMDocumentPrivate.h
17         https://bugs.webkit.org/show_bug.cgi?id=166882
18
19         Reviewed by Simon Fraser.
20
21         Removed pointerLockElement declaration that was supposed to be removed in r209637.
22
23         * DOM/DOMDocumentPrivate.h:
24
25 2017-01-06  Darin Adler  <darin@apple.com>
26
27         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
28         https://bugs.webkit.org/show_bug.cgi?id=166797
29
30         Reviewed by Alex Christensen.
31
32         * WebCoreSupport/WebEditorClient.h: Updated to take a reference.
33         * WebCoreSupport/WebEditorClient.mm:
34         (WebEditorClient::requestCheckingOfString): Take a reference
35         instead of a PassRefPtr.
36
37 2017-01-05  Chris Dumez  <cdumez@apple.com>
38
39         Turn preferLowPowerWebGLRendering setting on by default
40         https://bugs.webkit.org/show_bug.cgi?id=166737
41         <rdar://problem/29870033>
42
43         Reviewed by Dean Jackson.
44
45         Temporarily turn preferLowPowerWebGLRendering setting on by default until
46         we deal better with WebGL content in background tabs.
47
48         * WebView/WebPreferences.mm:
49         (+[WebPreferences initialize]):
50
51 2017-01-05  Enrica Casucci  <enrica@apple.com>
52
53         Support File Promise during drag for macOS.
54         https://bugs.webkit.org/show_bug.cgi?id=165204
55         rdar://problem/19595567
56
57         Reviewed by Tim Horton.
58
59         Adds support for dropping a File Promise in a WebView.
60         The implementation uses new File Promise API available in Sierra.
61
62         * Misc/WebNSPasteboardExtras.mm:
63         (+[NSPasteboard _web_dragTypesForURL]):
64         * WebView/WebView.mm:
65         (-[WebView performDragOperation:]):
66
67 2017-01-05  Andreas Kling  <akling@apple.com>
68
69         Remove ChromeClient::needTouchEvents().
70         <https://webkit.org/b/166723>
71
72         Rubber-stamped by Antti Koivisto.
73
74         * WebCoreSupport/WebChromeClient.h:
75
76 2017-01-04  Darin Adler  <darin@apple.com>
77
78         Remove PassRefPtr use from the "html" directory, other improvements
79         https://bugs.webkit.org/show_bug.cgi?id=166635
80
81         Reviewed by Alex Christensen.
82
83         * WebCoreSupport/WebChromeClient.h:
84         * WebCoreSupport/WebChromeClient.mm:
85         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
86
87 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
88
89         Unreviewed, rolling out r210287.
90
91         This change caused editing test failures on macOS.
92
93         Reverted changeset:
94
95         "Support File Promise during drag for macOS."
96         https://bugs.webkit.org/show_bug.cgi?id=165204
97         http://trac.webkit.org/changeset/210287
98
99 2017-01-04  Enrica Casucci  <enrica@apple.com>
100
101         Support File Promise during drag for macOS.
102         https://bugs.webkit.org/show_bug.cgi?id=165204
103         rdar://problem/19595567
104
105         Reviewed by Tim Horton.
106
107         Adds support for dropping a File Promise in a WebView.
108         The implementation uses new File Promise API available in Sierra.
109
110         * Misc/WebNSPasteboardExtras.mm:
111         (+[NSPasteboard _web_dragTypesForURL]):
112         * WebView/WebView.mm:
113         (-[WebView performDragOperation:]):
114
115 2017-01-04  Tim Horton  <timothy_horton@apple.com>
116
117         Provide a setting for clients to always prefer low-power WebGL
118         https://bugs.webkit.org/show_bug.cgi?id=166675
119         <rdar://problem/29834093>
120
121         Reviewed by Dan Bernstein.
122
123         * WebView/WebPreferenceKeysPrivate.h:
124         * WebView/WebPreferences.mm:
125         (+[WebPreferences initialize]):
126         (-[WebPreferences preferLowPowerWebGLRendering]):
127         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
128         * WebView/WebPreferencesPrivate.h:
129         * WebView/WebView.mm:
130         (-[WebView _preferencesChanged:]):
131         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
132
133 2017-01-03  Tim Horton  <timothy_horton@apple.com>
134
135         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
136         https://bugs.webkit.org/show_bug.cgi?id=166450
137         <rdar://problem/29447824>
138
139         Reviewed by Darin Adler.
140
141         * WebCoreSupport/CorrectionPanel.h:
142         * WebCoreSupport/CorrectionPanel.mm:
143         (CorrectionPanel::recordAutocorrectionResponse):
144         (CorrectionPanel::handleAcceptedReplacement):
145         * WebCoreSupport/WebAlternativeTextClient.mm:
146         (toCorrectionResponse):
147         (WebAlternativeTextClient::recordAutocorrectionResponse):
148         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
149         through recordAutocorrectionResponse, for debugging's sake.
150         Drop the NSView parameter because we don't need it, just the tag.
151         Convert the new AutocorrectionResponseType value to its corresponding
152         NSCorrectionResponse value.
153
154 2017-01-01  Jeff Miller  <jeffm@apple.com>
155
156         Update user-visible copyright strings to include 2017
157         https://bugs.webkit.org/show_bug.cgi?id=166278
158
159         Reviewed by Dan Bernstein.
160
161         * Info.plist:
162
163 2016-12-30  Darin Adler  <darin@apple.com>
164
165         Remove PassRefPtr use from the "dom" directory, related cleanup
166         https://bugs.webkit.org/show_bug.cgi?id=166569
167
168         Reviewed by Alex Christensen.
169
170         * WebCoreSupport/WebFrameLoaderClient.mm:
171         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
172         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
173         (WebFrameLoaderClient::setTitle): Ditto.
174         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
175         * WebView/WebFrame.mm:
176         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
177         Not needed now, but useful later if we ever can get rid of the explicit constructors.
178         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
179         * WebView/WebHTMLRepresentation.mm:
180         (-[WebHTMLRepresentation title]): Updated to use struct.
181
182 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
183
184         Propagate the source origin as much as possible
185         https://bugs.webkit.org/show_bug.cgi?id=166348
186
187         Reviewed by Darin Adler.
188
189         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
190         (WebKit::NetscapePluginInstanceProxy::evaluate):
191
192 2016-12-23  Andy Estes  <aestes@apple.com>
193
194         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
195         https://bugs.webkit.org/show_bug.cgi?id=166471
196
197         Reviewed by Andreas Kling.
198
199         When DumpRenderTree starts up, it calls
200         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
201         builds, this triggers the ASSERT(isMainThread()) in
202         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
203         started, we are on the main thread, and we are not holding the Web thread lock. This is
204         causing all layout tests to crash in the iOS WK1 Debug configuration.
205
206         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
207         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
208
209 2016-12-22  Andy Estes  <aestes@apple.com>
210
211         Make WebCore::EditorInsertAction an enum class
212         https://bugs.webkit.org/show_bug.cgi?id=166424
213
214         Reviewed by Brent Fulgham.
215
216         * WebCoreSupport/WebEditorClient.mm:
217         (kit):
218
219 2016-12-21  Beth Dakin  <bdakin@apple.com>
220
221         Holding down on candidates in the TouchBar should show panel on screen
222         https://bugs.webkit.org/show_bug.cgi?id=166367
223         -and corresponding-
224         <rdar://problem/28479236>
225
226         Reviewed by Tim Horton.
227
228         Stray whitespace.
229         * WebCoreSupport/WebEditorClient.mm:
230         (WebEditorClient::handleRequestedCandidates):
231
232         Call the version of setCandidates: that takes a rect. We need to keep the helper 
233         function in WK1 (unlike WK2) since we also use it for testing.
234         * WebView/WebView.mm:
235         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
236
237 2016-12-20  Dean Jackson  <dino@apple.com>
238
239         Remove INDIE_UI
240         https://bugs.webkit.org/show_bug.cgi?id=165881
241         <rdar://problem/29672532>
242
243         Reviewed by Simon Fraser.
244
245         The Indie UI work has been discontinued.
246
247         * Configurations/FeatureDefines.xcconfig:
248
249 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
250
251         [ES6] Enable ES6 Modules
252         https://bugs.webkit.org/show_bug.cgi?id=165849
253
254         Reviewed by Geoffrey Garen.
255
256         * WebView/WebPreferenceKeysPrivate.h:
257         * WebView/WebPreferences.mm:
258         (+[WebPreferences initialize]):
259         (-[WebPreferences es6ModulesEnabled]): Deleted.
260         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
261         * WebView/WebPreferencesPrivate.h:
262         * WebView/WebView.mm:
263         (-[WebView _preferencesChanged:]):
264
265 2016-12-16  Dave Hyatt  <hyatt@apple.com>
266
267         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
268         https://bugs.webkit.org/show_bug.cgi?id=165968
269
270         Reviewed by Andreas Kling.
271
272         * DOM/DOMCSS.mm:
273         (kitClass):
274         * DOM/DOMCSSPrimitiveValue.mm:
275         (-[DOMCSSPrimitiveValue getCounterValue]):
276         (-[DOMCSSPrimitiveValue getRectValue]):
277         (kit):
278         * DOM/DOMCSSPrimitiveValueInternal.h:
279         * DOM/DOMCSSStyleDeclaration.mm:
280         * DOM/DOMCSSValue.mm:
281         (kit):
282         * DOM/DOMCSSValueInternal.h:
283         * DOM/DOMCSSValueList.mm:
284         * DOM/DOMCounter.mm:
285         (kit):
286         * DOM/DOMCounterInternal.h:
287         * DOM/DOMRGBColor.mm:
288         (kit):
289         * DOM/DOMRGBColorInternal.h:
290         * DOM/DOMRect.mm:
291         (kit):
292         * DOM/DOMRectInternal.h:
293         * DOM/DOMUtility.mm:
294         (createDOMWrapper):
295
296 2016-12-16  Chris Dumez  <cdumez@apple.com>
297
298         HTML form validation bubble should be dismissed on navigation
299         https://bugs.webkit.org/show_bug.cgi?id=165960
300         <rdar://problem/29668086>
301
302         Reviewed by Simon Fraser.
303
304         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
305
306         * WebView/WebView.mm:
307         (-[WebView _didStartProvisionalLoadForFrame:]):
308
309 2016-12-15  Darin Adler  <darin@apple.com>
310
311         Use asString instead of toWTFString, toString, or getString when we already checked isString
312         https://bugs.webkit.org/show_bug.cgi?id=165895
313
314         Reviewed by Yusuke Suzuki.
315
316         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
317         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
318         toWTFString.
319         * WebView/WebView.mm:
320         (aeDescFromJSValue): Use asString/value instead of getString.
321
322 2016-12-15  Chris Dumez  <cdumez@apple.com>
323
324         Make sure HTML validation bubble's state is updated after layout
325         https://bugs.webkit.org/show_bug.cgi?id=165922
326         <rdar://problem/29694730>
327
328         Reviewed by Simon Fraser.
329
330         Make sure HTML validation bubble's state is updated after layout.
331         In particular, if the validation bubble's associated element has
332         moved or is no longer visible, we now hide the bubble.
333
334         * WebCoreSupport/WebValidationMessageClient.h:
335         * WebCoreSupport/WebValidationMessageClient.mm:
336         (WebValidationMessageClient::showValidationMessage):
337         (WebValidationMessageClient::hideValidationMessage):
338         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
339
340 2016-12-15  Chris Dumez  <cdumez@apple.com>
341
342         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
343         https://bugs.webkit.org/show_bug.cgi?id=165904
344
345         Reviewed by Sam Weinig.
346
347         Update ObjC bindings so they keep building.
348
349         * DOM/DOMUIEvent.mm:
350         (-[DOMUIEvent keyCode]):
351         (-[DOMUIEvent charCode]):
352
353 2016-12-15  Andreas Kling  <akling@apple.com>
354
355         Always clear RenderLayer backing stores when going into page cache.
356         <https://webkit.org/b/165901>
357
358         Reviewed by Simon Fraser.
359
360         * WebView/WebView.mm:
361         (+[WebView _setCacheModel:]):
362
363 2016-12-12  Alex Christensen  <achristensen@webkit.org>
364
365         Remove unused workaround for Silverlight
366         https://bugs.webkit.org/show_bug.cgi?id=165773
367
368         Reviewed by Dean Jackson.
369
370         * Plugins/WebNetscapePluginView.mm:
371         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
372         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
373         Allowing 6 years for users to update Silverlight is more than enough.
374         Safari doesn't even use WebKit1 for this any more.
375         I need this to be removed because this is the only non-WebGL code that needs to link against
376         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
377
378 2016-12-12  Chris Dumez  <cdumez@apple.com>
379
380         Document.visibilityState should use an IDL string enumeration
381         https://bugs.webkit.org/show_bug.cgi?id=165774
382
383         Reviewed by Daniel Bates.
384
385         * DOM/DOMDocument.mm:
386         (-[DOMDocument visibilityState]):
387         * WebView/WebView.mm:
388         (kit):
389
390 2016-12-12  Jer Noble  <jer.noble@apple.com>
391
392         Remove implementation of legacy Mozilla-based Fullscreen API.
393         https://bugs.webkit.org/show_bug.cgi?id=165689
394         <rdar://problem/29603053>
395
396         Reviewed by Eric Carlson.
397
398         * DOM/DOMElement.mm:
399         (-[DOMElement webkitRequestFullScreen:]):
400
401 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
402
403         The DOM should have an advancing wavefront opaque root barrier
404         https://bugs.webkit.org/show_bug.cgi?id=165712
405
406         Reviewed by Yusuke Suzuki.
407         
408         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
409
410         * Misc/WebCoreStatistics.mm:
411         (+[WebCoreStatistics javaScriptObjectsCount]):
412         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
413         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
414         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
415         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
416         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
417         (+[WebCoreStatistics shouldPrintExceptions]):
418         (+[WebCoreStatistics setShouldPrintExceptions:]):
419         (+[WebCoreStatistics memoryStatistics]):
420         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
421         * Plugins/Hosted/NetscapePluginHostProxy.mm:
422         (identifierFromIdentifierRep):
423         * Plugins/Hosted/ProxyInstance.mm:
424         (WebKit::ProxyInstance::getPropertyNames):
425         * Plugins/WebNetscapePluginStream.mm:
426         (WebNetscapePluginStream::wantsAllStreams):
427         * Plugins/WebNetscapePluginView.mm:
428         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
429         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
430         (-[WebNetscapePluginView setWindowIfNecessary]):
431         (-[WebNetscapePluginView createPluginScriptableObject]):
432         (-[WebNetscapePluginView getFormValue:]):
433         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
434         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
435         (-[WebNetscapePluginView loadPluginRequest:]):
436         (-[WebNetscapePluginView _printedPluginBitmap]):
437         * Plugins/WebPluginController.mm:
438         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
439         (-[WebPluginController stopOnePlugin:]):
440         (-[WebPluginController stopOnePluginForPageCache:]):
441         (-[WebPluginController destroyOnePlugin:]):
442         (-[WebPluginController startAllPlugins]):
443         (-[WebPluginController addPlugin:]):
444
445 2016-12-09  Dave Hyatt  <hyatt@apple.com>
446
447         [CSS Parser] Remove the old CSS Parser
448         https://bugs.webkit.org/show_bug.cgi?id=165645
449
450         Reviewed by Daniel Bates.
451
452         * DOM/DOMCSS.mm:
453         (kitClass):
454         * DOM/DOMCSSRule.h:
455
456 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
457
458         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
459         https://bugs.webkit.org/show_bug.cgi?id=165251
460
461         Reviewed by Dean Jackson.
462
463         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
464
465         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
466         * WebView/WebPreferences.mm:
467         (+[WebPreferences initialize]):
468         (-[WebPreferences mediaStreamEnabled]):
469         (-[WebPreferences setMediaStreamEnabled:]):
470         (-[WebPreferences peerConnectionEnabled]):
471         (-[WebPreferences setPeerConnectionEnabled:]):
472         * WebView/WebPreferencesPrivate.h:
473         * WebView/WebView.mm:
474         (-[WebView _preferencesChanged:]):
475
476 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
477
478         Don’t expose pointer lock in WebKit1 Objective-C API
479         https://bugs.webkit.org/show_bug.cgi?id=165692
480
481         Reviewed by Simon Fraser.
482
483         * DOM/DOMDocument.mm:
484         (-[DOMDocument pointerLockElement]): Deleted.
485         (-[DOMDocument exitPointerLock]): Deleted.
486         * DOM/DOMElement.mm:
487         (-[DOMElement requestPointerLock]): Deleted.
488         * DOM/DOMMouseEvent.mm:
489         (-[DOMMouseEvent movementX]): Deleted.
490         (-[DOMMouseEvent movementY]): Deleted.
491
492 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
493
494         document.webkitFullscreenElement leaks elements inside a shadow tree
495         https://bugs.webkit.org/show_bug.cgi?id=158471
496
497         Reviewed by Chris Dumez.
498
499         Use the API for bindings to avoid exposing nodes inside a shadow tree.
500
501         * DOM/DOMDocument.mm:
502         (-[DOMDocument webkitCurrentFullScreenElement]):
503         (-[DOMDocument webkitFullscreenElement]):
504
505 2016-12-09  Beth Dakin  <bdakin@apple.com>
506
507         Password fields should not show the emoji button in TouchBar
508         https://bugs.webkit.org/show_bug.cgi?id=165673
509         -and corresponding-
510         rdar://problem/29235739
511
512         Reviewed by Wenson Hsieh.
513
514         This patch adds a new ivar for the password touch bar and password 
515         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
516         of identifiers than the plain text TouchBar, it should just have its own variable.
517
518         The candidate list should be the only item for passwords.
519         * WebView/WebView.mm:
520         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
521
522         Account for _passwordTextTouchBar.
523         (-[WebView didChangeAutomaticTextCompletion:]):
524         (-[WebView setUpTextTouchBar:]):
525         (-[WebView textTouchBar]):
526
527         The empty candidates array is not needed. We can just set @[ ] as the candidates 
528         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
529         other parts of the code to prevent us from requesting or setting other candidates 
530         when in a password field. 
531         (-[WebView updateTextTouchBar]):
532
533         Account for _passwordTextTouchBar.
534         (-[WebView candidateList]):
535         * WebView/WebViewData.h:
536
537 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
538
539         Enable SharedArrayBuffer, remove the flag
540         https://bugs.webkit.org/show_bug.cgi?id=165614
541
542         Rubber stamped by Geoffrey Garen.
543
544         * WebView/WebPreferencesPrivate.h:
545
546 2016-12-07  Dean Jackson  <dino@apple.com>
547
548         Remove runtime toggle for pointer-lock
549         https://bugs.webkit.org/show_bug.cgi?id=165577
550         <rdar://problems/29566996>
551
552         Reviewed by Jon Lee.
553
554         Remove any runtime calls to check if pointer-lock is enabled. It's
555         either compiled in or out.
556
557         * WebView/WebPreferenceKeysPrivate.h:
558         * WebView/WebPreferences.mm:
559         (-[WebPreferences pointerLockEnabled]): Deleted.
560         (-[WebPreferences setPointerLockEnabled:]): Deleted.
561         * WebView/WebPreferencesPrivate.h:
562         * WebView/WebView.mm:
563         (-[WebView _preferencesChanged:]):
564
565 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
566
567         Correct SDKROOT values in xcconfig files
568         https://bugs.webkit.org/show_bug.cgi?id=165487
569         rdar://problem/29539209
570
571         Reviewed by Dan Bernstein.
572
573         Fix suggested by Dan Bernstein.
574
575         * Configurations/DebugRelease.xcconfig:
576
577 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
578
579         Improve the behavior of scroll-into-view when the target is inside position:fixed
580         https://bugs.webkit.org/show_bug.cgi?id=165354
581
582         Reviewed by Zalan Bujtas.
583
584         Plumb through 'insideFixed'. We don't get compute it, so behavior from
585         these call sites won't change.
586
587         * WebView/WebFrame.mm:
588         (-[WebFrame _scrollDOMRangeToVisible:]):
589         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
590
591 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
592
593         Enable visual viewports by default on Mac, and iOS Wk2
594         https://bugs.webkit.org/show_bug.cgi?id=165452
595
596         Reviewed by Zalan Bujtas.
597
598         Turn visual viewports on by default for WK1 on Mac.
599
600         * WebView/WebPreferences.mm:
601         (+[WebPreferences initialize]):
602
603 2016-12-05  Dean Jackson  <dino@apple.com>
604
605         pointer lock needs to be feature detectable
606         https://bugs.webkit.org/show_bug.cgi?id=165426
607         <rdar://problem/29486715>
608
609         Reviewed by Antoine Quint.
610
611         Set the RuntimeEnabledFeature as preferences
612         change.
613
614         * WebView/WebView.mm:
615         (-[WebView _preferencesChanged:]):
616
617 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
618
619         Unreviewed, rolling out r209299.
620
621         This change appears to have caused LayoutTest failures on
622         Sierra WK1.
623
624         Reverted changeset:
625
626         "Improve the behavior of scroll-into-view when the target is
627         inside position:fixed"
628         https://bugs.webkit.org/show_bug.cgi?id=165354
629         http://trac.webkit.org/changeset/209299
630
631 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
632
633         Improve the behavior of scroll-into-view when the target is inside position:fixed
634         https://bugs.webkit.org/show_bug.cgi?id=165354
635
636         Reviewed by Zalan Bujtas.
637
638         Plumb through 'insideFixed'. We don't get compute it, so behavior from
639         these call sites won't change.
640
641         * WebView/WebFrame.mm:
642         (-[WebFrame _scrollDOMRangeToVisible:]):
643         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
644
645 2016-12-02  Andy Estes  <aestes@apple.com>
646
647         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
648         https://bugs.webkit.org/show_bug.cgi?id=164492
649
650         Reviewed by Dan Bernstein.
651
652         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
653         com.apple.$(PRODUCT_NAME:rfc1034identifier).
654         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
655         ${PRODUCT_BUNDLE_IDENTIFIER}.
656
657 2016-12-02  Chris Dumez  <cdumez@apple.com>
658
659         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
660         https://bugs.webkit.org/show_bug.cgi?id=165328
661
662         Reviewed by Simon Fraser.
663
664         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
665
666         * WebView/WebViewData.mm:
667         (-[WebViewPrivate init]):
668
669 2016-12-02  Chris Dumez  <cdumez@apple.com>
670
671         [Mac][WK1] Implement new HTML interactive form validation user interface
672         https://bugs.webkit.org/show_bug.cgi?id=164483
673
674         Reviewed by Simon Fraser.
675
676         Implement new HTML interactive form validation user interface on Mac
677         WK1 and enable it by default.
678
679         * WebCoreSupport/WebValidationMessageClient.h: Added.
680         * WebCoreSupport/WebValidationMessageClient.mm: Added.
681         (WebValidationMessageClient::WebValidationMessageClient):
682         (WebValidationMessageClient::~WebValidationMessageClient):
683         (WebValidationMessageClient::showValidationMessage):
684         (WebValidationMessageClient::hideValidationMessage):
685         (WebValidationMessageClient::isValidationMessageVisible):
686         * WebView/WebHTMLView.mm:
687         (-[WebHTMLView _frameOrBoundsChanged]):
688         * WebView/WebView.mm:
689         (-[WebView _commonInitializationWithFrameName:groupName:]):
690         (-[WebView _willStartScrollingOrZooming]):
691         (-[WebView _contentsOfUserInterfaceItem:]):
692         (-[WebView _scaleWebView:atOrigin:]):
693         (-[WebView _didScrollDocumentInFrameView:]):
694         (-[WebView _setZoomMultiplier:isTextOnly:]):
695         (-[WebView showFormValidationMessage:withAnchorRect:]):
696         (-[WebView hideFormValidationMessage]):
697         * WebView/WebViewData.h:
698         * WebView/WebViewData.mm:
699         (-[WebViewPrivate init]):
700         * WebView/WebViewInternal.h:
701         * WebView/WebViewPrivate.h:
702
703 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
704
705         Add a runtime flag for SubtleCrypto
706         https://bugs.webkit.org/show_bug.cgi?id=164982
707
708         Reviewed by Brent Fulgham.
709
710         * WebView/WebPreferenceKeysPrivate.h:
711         * WebView/WebPreferences.mm:
712         (+[WebPreferences initialize]):
713         (-[WebPreferences subtleCryptoEnabled]):
714         (-[WebPreferences setSubtleCryptoEnabled:]):
715         * WebView/WebPreferencesPrivate.h:
716         * WebView/WebView.mm:
717         (-[WebView _preferencesChanged:]):
718
719 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
720
721         Add separate settings and preferences to enable/disable async decoding for large images and animated images
722         https://bugs.webkit.org/show_bug.cgi?id=165177
723
724         Reviewed by Simon Fraser.
725         
726         Hook up the async image decoding settings for WebKit1.
727
728         * WebView/WebPreferenceKeysPrivate.h:
729         * WebView/WebPreferences.mm:
730         (+[WebPreferences initialize]):
731         (-[WebPreferences largeImageAsyncDecodingEnabled]):
732         (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
733         (-[WebPreferences animatedImageAsyncDecodingEnabled]):
734         (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
735         (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
736         (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
737         * WebView/WebPreferencesPrivate.h:
738         * WebView/WebView.mm:
739         (-[WebView _preferencesChanged:]):
740
741 2016-11-29  Andy Estes  <aestes@apple.com>
742
743         [Cocoa] Enable two clang warnings recommended by Xcode
744         https://bugs.webkit.org/show_bug.cgi?id=164498
745
746         Reviewed by Mark Lam.
747
748         * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
749
750 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
751
752         [WTF] Import std::optional reference implementation as WTF::Optional
753         https://bugs.webkit.org/show_bug.cgi?id=164199
754
755         Reviewed by Saam Barati and Sam Weinig.
756
757         Use WTF::Optional::value_or.
758
759         * DOM/DOMHTMLOptionsCollection.mm:
760         (-[DOMHTMLOptionsCollection add:index:]):
761         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
762         (WebKit::NetscapePluginInstanceProxy::evaluate):
763         * Plugins/WebNetscapePluginView.mm:
764         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
765         * WebCoreSupport/WebFrameLoaderClient.h:
766         * WebCoreSupport/WebFrameLoaderClient.mm:
767         (WebFrameLoaderClient::dispatchDidCommitLoad):
768         * WebCoreSupport/WebPaymentCoordinatorClient.h:
769         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
770         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
771         (WebPaymentCoordinatorClient::completeShippingContactSelection):
772         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
773         * WebCoreSupport/WebSecurityOrigin.mm:
774         (-[WebSecurityOrigin port]):
775         * WebView/WebHTMLView.mm:
776         (toAction):
777         (toTag):
778
779 2016-11-26  Sam Weinig  <sam@webkit.org>
780
781         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
782         https://bugs.webkit.org/show_bug.cgi?id=164965
783
784         Reviewed by Simon Fraser.
785
786         * WebView/WebPreferenceKeysPrivate.h:
787         * WebView/WebPreferences.mm:
788         (-[WebPreferences intersectionObserverEnabled]):
789         (-[WebPreferences setIntersectionObserverEnabled:]):
790         * WebView/WebPreferencesPrivate.h:
791         * WebView/WebView.mm:
792         (-[WebView _preferencesChanged:]):
793         Add a preference, defaulting to off, for enabling IntersectionObserver.
794
795 2016-11-22  Dan Bernstein  <mitz@apple.com>
796
797         [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
798         https://bugs.webkit.org/show_bug.cgi?id=165036
799         <rdar://problem/5708580>
800
801         Reviewed by Alexey Proskuryakov.
802
803         * WebView/WebHTMLView.mm:
804         (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
805           similarly to what we do in -keyDown: and to what WKWebView does with all key events.
806
807 2016-11-21  Alex Christensen  <achristensen@webkit.org>
808
809         Fix Sierra CMake build after r208452
810         https://bugs.webkit.org/show_bug.cgi?id=164437
811
812         * WebView/WebView.mm:
813         (-[WebView updateMediaTouchBar]):
814         I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
815         It's needed for playbackSessionInterface to exist.
816
817 2016-11-18  Enrica Casucci  <enrica@apple.com>
818
819         Refactor drag and drop for WebKit2 to encode DragData message exchange.
820         https://bugs.webkit.org/show_bug.cgi?id=164945
821
822         Reviewed by Tim Horton.
823
824         * WebCoreSupport/WebDragClient.h:
825         * WebCoreSupport/WebDragClient.mm:
826         (WebDragClient::actionMaskForDrag):
827         (WebDragClient::willPerformDragDestinationAction):
828
829 2016-11-18  Jeremy Jones  <jeremyj@apple.com>
830
831         Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
832         https://bugs.webkit.org/show_bug.cgi?id=163801
833
834         Reviewed by Simon Fraser.
835
836         Plumb through PointerLockEnabled setting.
837
838         * Configurations/FeatureDefines.xcconfig:
839         * WebCoreSupport/WebChromeClient.mm:
840         (WebChromeClient::requestPointerUnlock):
841         * WebView/WebPreferenceKeysPrivate.h:
842         * WebView/WebPreferences.mm:
843         (-[WebPreferences pointerLockEnabled]):
844         (-[WebPreferences setPointerLockEnabled:]):
845         * WebView/WebPreferencesPrivate.h:
846         * WebView/WebView.mm:
847         (-[WebView _preferencesChanged:]):
848
849 2016-11-17  Dan Bernstein  <mitz@apple.com>
850
851         Try to fix some non-macOS builds.
852
853         * WebView/WebView.mm:
854
855 2016-11-16  Dave Hyatt  <hyatt@apple.com>
856
857         [CSS Parser] Add @supports, @keyframe and media query parsing options
858         https://bugs.webkit.org/show_bug.cgi?id=164821
859
860         Reviewed by Sam Weinig and Zalan Bujtas.
861
862         Fix up the create call now that fallback descriptor syntax is gone.
863
864         * DOM/DOM.mm:
865         (-[DOMHTMLLinkElement _mediaQueryMatches]):
866
867 2016-11-17  Saam Barati  <sbarati@apple.com>
868
869         Remove async/await compile time flag and enable tests
870         https://bugs.webkit.org/show_bug.cgi?id=164828
871         <rdar://problem/28639334>
872
873         Reviewed by Yusuke Suzuki.
874
875         * Configurations/FeatureDefines.xcconfig:
876
877 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
878
879         [JSC] WTF::TemporaryChange with WTF::SetForScope
880         https://bugs.webkit.org/show_bug.cgi?id=164761
881
882         Reviewed by Saam Barati.
883
884         * WebView/WebView.mm:
885         (-[WebView updateTextTouchBar]):
886
887 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
888
889         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
890         https://bugs.webkit.org/show_bug.cgi?id=164827
891
892         Reviewed by Ryosuke Niwa.
893
894         * Configurations/FeatureDefines.xcconfig:
895         * WebView/WebPreferenceKeysPrivate.h:
896         * WebView/WebPreferences.mm:
897         (+[WebPreferences initialize]):
898         (-[WebPreferences es6ModulesEnabled]):
899         (-[WebPreferences setES6ModulesEnabled:]):
900         * WebView/WebPreferencesPrivate.h:
901         * WebView/WebView.mm:
902         (-[WebView _preferencesChanged:]):
903
904 2016-11-14  Alex Christensen  <achristensen@webkit.org>
905
906         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
907         https://bugs.webkit.org/show_bug.cgi?id=164720
908
909         Reviewed by Brady Eidson.
910
911         * Storage/WebDatabaseManager.mm:
912         (-[WebDatabaseManager origins]):
913         (-[WebDatabaseManager databasesWithOrigin:]):
914         (-[WebDatabaseManager deleteOrigin:]):
915         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
916         * Storage/WebDatabaseManagerClient.h:
917         * Storage/WebDatabaseManagerClient.mm:
918         (DidModifyOriginData::dispatchToMainThread):
919         (DidModifyOriginData::DidModifyOriginData):
920         (WebDatabaseManagerClient::dispatchDidModifyOrigin):
921         (WebDatabaseManagerClient::dispatchDidModifyDatabase):
922         * Storage/WebDatabaseQuotaManager.mm:
923         (-[WebDatabaseQuotaManager usage]):
924         (-[WebDatabaseQuotaManager quota]):
925         (-[WebDatabaseQuotaManager setQuota:]):
926         * Storage/WebStorageManager.mm:
927         (-[WebStorageManager origins]):
928         (-[WebStorageManager deleteOrigin:]):
929         * Storage/WebStorageTrackerClient.h:
930         * Storage/WebStorageTrackerClient.mm:
931         (WebStorageTrackerClient::dispatchDidModifyOrigin):
932         * WebCoreSupport/WebSecurityOrigin.mm:
933         (-[WebSecurityOrigin usage]):
934         (-[WebSecurityOrigin quota]):
935         (-[WebSecurityOrigin setQuota:]):
936
937 2016-11-13  Darin Adler  <darin@apple.com>
938
939         Fix exception handling in SQL database code, streamline and update code
940         https://bugs.webkit.org/show_bug.cgi?id=164685
941
942         Reviewed by Sam Weinig.
943
944         * Storage/WebDatabaseManager.mm:
945         (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
946         a reference.
947         (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
948         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
949         but continue to use DatabaseManager.
950         (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
951         reference.
952         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
953
954         * Storage/WebDatabaseManagerClient.h: Updated to take references.
955         * Storage/WebDatabaseManagerClient.mm:
956         (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
957         members in the class definition.
958         (DidModifyOriginData::dispatchToMainThread): Take references.
959         (DidModifyOriginData::DidModifyOriginData): Ditto.
960         (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
961         (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
962         (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
963         DatabaseTracker::singleton instead of tracker.
964
965         * Storage/WebDatabaseQuotaManager.mm:
966         (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
967         (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
968         (-[WebDatabaseQuotaManager quota]): Ditto.
969         (-[WebDatabaseQuotaManager setQuota:]): Ditto.
970         * WebCoreSupport/WebSecurityOrigin.mm:
971         (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
972         (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
973         (-[WebSecurityOrigin quota]): Ditto.
974         (-[WebSecurityOrigin setQuota:]): Ditto.
975         * WebView/WebFrame.mm:
976         (-[WebFrame _cacheabilityDictionary]): Pass a reference.
977
978 2016-11-12  Darin Adler  <darin@apple.com>
979
980         Remove a few assorted uses of ExceptionCode
981         https://bugs.webkit.org/show_bug.cgi?id=164683
982
983         Reviewed by Chris Dumez.
984
985         * DOM/DOMDOMImplementation.mm:
986         (-[DOMImplementation createDocumentType:publicId:systemId:]):
987         Use raiseOnDOMError instead of much longer hand written equivalent.
988         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
989
990         * DOM/DOMDocument.mm:
991         (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
992         so we are not using a specific exception code.
993
994         * DOM/DOMHTMLOptionsCollection.mm:
995         (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
996         much longer hand written equivalent.
997         * DOM/DOMHTMLSelectElement.mm:
998         (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
999         statement after calling a "no return" function.
1000
1001         * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
1002         raiseOnDOMError functions that take ExceptionCode; keep the ones that take
1003         Exception and ExceptionOr. Renamed the other overload of raiseDOMException
1004         to raiseDOMErrorException; it is only used as the non-inline implementation
1005         part of the inline raiseOnDOMError function.
1006         * DOM/ExceptionHandlers.mm:
1007         (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
1008         to this source file instead of in the header.
1009         (raiseTypeErrorException): Updated for name change.
1010         (raiseNotSupportedErrorException): Added.
1011
1012 2016-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1013
1014         Hovering over a slotted Text node clears hover state
1015         https://bugs.webkit.org/show_bug.cgi?id=164002
1016         <rdar://problem/29040471>
1017
1018         Reviewed by Simon Fraser.
1019
1020         * WebView/WebImmediateActionController.mm:
1021         (-[WebImmediateActionController performHitTestAtPoint:]):
1022
1023 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1024
1025         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
1026         https://bugs.webkit.org/show_bug.cgi?id=164538
1027         <rdar://problem/8418711>
1028
1029         Reviewed by Ryosuke Niwa.
1030
1031         Account for renaming HTMLElement::autocorrect to HTMLElement::shouldAutocorrect, as well as moving
1032         WebAutocapitalizeType to WebKit from WebCore. Additionally, moves the -autocorrect and -autocapitalize SPIs out
1033         of HTML(Input|Form|TextArea)ElementPrivate.h and into HTMLElementPrivate.h. This also means removing redundant
1034         code for interfacing with the unwrapped HTMLElement's autocorrect and autocapitalize attributes.
1035
1036         * DOM/DOMHTML.mm:
1037         (webAutocapitalizeType):
1038         (-[DOMHTMLInputElement _autocapitalizeType]):
1039         (-[DOMHTMLTextAreaElement _autocapitalizeType]):
1040         * DOM/DOMHTMLElement.mm:
1041         (-[DOMHTMLElement autocorrect]):
1042         (-[DOMHTMLElement setAutocorrect:]):
1043         (-[DOMHTMLElement autocapitalize]):
1044         (-[DOMHTMLElement setAutocapitalize:]):
1045         * DOM/DOMHTMLElementPrivate.h: Copied from Source/WebCore/html/Autocapitalize.h.
1046         * DOM/DOMHTMLFormElement.mm:
1047         (-[DOMHTMLFormElement autocorrect]): Deleted.
1048         (-[DOMHTMLFormElement setAutocorrect:]): Deleted.
1049         (-[DOMHTMLFormElement autocapitalize]): Deleted.
1050         (-[DOMHTMLFormElement setAutocapitalize:]): Deleted.
1051         * DOM/DOMHTMLInputElement.mm:
1052         (-[DOMHTMLInputElement autocorrect]): Deleted.
1053         (-[DOMHTMLInputElement setAutocorrect:]): Deleted.
1054         (-[DOMHTMLInputElement autocapitalize]): Deleted.
1055         (-[DOMHTMLInputElement setAutocapitalize:]): Deleted.
1056         * DOM/DOMHTMLInputElementPrivate.h:
1057         * DOM/DOMHTMLTextAreaElement.mm:
1058         (-[DOMHTMLTextAreaElement autocorrect]): Deleted.
1059         (-[DOMHTMLTextAreaElement setAutocorrect:]): Deleted.
1060         (-[DOMHTMLTextAreaElement autocapitalize]): Deleted.
1061         (-[DOMHTMLTextAreaElement setAutocapitalize:]): Deleted.
1062         * DOM/DOMHTMLTextAreaElementPrivate.h:
1063
1064         We need to import DOMHTMLElementPrivate.h here to avoid breaking UIKit. We should follow this up with a UIKit
1065         change to import DOMHTMLElementPrivate.h directly.
1066
1067         * DOM/DOMPrivate.h:
1068         * DOM/WebAutocapitalizeTypes.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h.
1069         * MigrateHeaders.make:
1070
1071 2016-11-11  Beth Dakin  <bdakin@apple.com>
1072
1073         Move to modern TouchBar methods
1074         https://bugs.webkit.org/show_bug.cgi?id=164655
1075         -and corresponding-
1076         rdar://problem/29226911
1077
1078         Reviewed by Wenson Hsieh.
1079
1080         customizationDefaultItemIdentifiers -> defaultItemIdentifiers
1081         itemIdentifiers -> defaultItemIdentifiers
1082         defaultItems -> templateItems
1083
1084         * WebView/WebView.mm:
1085         (-[WebView _plainTextTouchBarDefaultItemIdentifiers]):
1086         (-[WebView _richTextTouchBarDefaultItemIdentifiers]):
1087         (-[WebView setUpTextTouchBar:]):
1088         (-[WebView updateTextTouchBar]):
1089         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1090         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1091
1092 2016-11-11  Darin Adler  <darin@apple.com>
1093
1094         Move Node from ExceptionCode to ExceptionOr
1095         https://bugs.webkit.org/show_bug.cgi?id=164515
1096
1097         Reviewed by Sam Weinig.
1098
1099         * DOM/DOMHTMLSelectElement.mm:
1100         (-[DOMHTMLSelectElement remove:]): Call remove instead of removeByIndex
1101         now that it was renamed.
1102         * DOM/DOMNode.mm:
1103         (-[DOMNode setNodeValue:]): Updated exception handling.
1104         (-[DOMNode setPrefix:]): Ditto.
1105         (-[DOMNode setTextContent:]): Ditto.
1106         (-[DOMNode insertBefore:refChild:]): Ditto.
1107         (-[DOMNode replaceChild:oldChild:]): Ditto.
1108         (-[DOMNode removeChild:]): Ditto.
1109         (-[DOMNode appendChild:]): Ditto.
1110         (-[DOMNode cloneNode:]): Ditto.
1111
1112 2016-11-11  Beth Dakin  <bdakin@apple.com>
1113
1114         Get touch bar code building for open source builds
1115         https://bugs.webkit.org/show_bug.cgi?id=164610
1116
1117         Reviewed by Wenson Hsieh.
1118
1119         * WebKitPrefix.h:
1120
1121 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1122
1123         Fix assertion after r208534.
1124         https://bugs.webkit.org/show_bug.cgi?id=160497
1125
1126         * WebView/WebView.mm:
1127         (-[WebView _commonInitializationWithFrameName:groupName:]):
1128         (WebInstallMemoryPressureHandler):
1129         WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
1130         When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
1131         only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
1132
1133 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1134
1135         Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
1136         https://bugs.webkit.org/show_bug.cgi?id=164573
1137
1138         Reviewed by Brady Eidson.
1139
1140         * WebCoreSupport/WebSecurityOrigin.mm:
1141         (-[WebSecurityOrigin databaseIdentifier]):
1142
1143 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1144
1145         MemoryPressureHandler shouldn't know how to release WebCore memory
1146         https://bugs.webkit.org/show_bug.cgi?id=160497
1147
1148         Reviewed by Michael Catanzaro.
1149
1150         Set the low memory handler before installing the memory pressure handler.
1151
1152         * WebView/WebView.mm:
1153         (-[WebView _commonInitializationWithFrameName:groupName:]):
1154
1155 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
1156
1157         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
1158         https://bugs.webkit.org/show_bug.cgi?id=164501
1159         <rdar://problem/29152282>
1160
1161         Reviewed by Sam Weinig.
1162
1163         Align what [WebHTMLView attributedString] returns to what would be used on copy & paste by using HTMLConverter
1164         instead of _initWithDOMRange in [WebHTMLView _attributeStringFromDOMRange].
1165
1166         * WebView/WebHTMLView.mm:
1167         (-[WebHTMLView _attributedStringFromDOMRange:]): Renamed from _attributeStringFromDOMRange.
1168         (-[WebHTMLView attributedString]):
1169         (-[WebHTMLView selectedAttributedString]):
1170         (-[WebHTMLView selectedString]): Moved to reduce the number of occurrences of the if-defs.
1171
1172 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
1173
1174         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
1175         https://bugs.webkit.org/show_bug.cgi?id=155185
1176         <rdar://problem/11101440>
1177
1178         Reviewed by Brady Eidson.
1179
1180         Provide SPI to access the new quirk for localStorage. The quirk defaults to 'on'. When active, this
1181         quirk says that localStorage access should be granted, without needing to grant universal file access.
1182
1183         If the quirk is turned off, then localStorage is blocked unless the WebKit client explicitly
1184         grants universal file access.
1185
1186         * WebView/WebPreferenceKeysPrivate.h:
1187         * WebView/WebPreferences.mm:
1188         (-[WebPreferences needsLocalStorageQuirk]): Added.
1189         (-[WebPreferences setNeedsLocalStorageQuirk:]): Added.
1190         * WebView/WebPreferencesPrivate.h:
1191         * WebView/WebView.mm:
1192         (-[WebView _preferencesChanged:]): Honor the new localStorage quirk.
1193
1194 2016-11-09  Alex Christensen  <achristensen@webkit.org>
1195
1196         Clean up Storage code
1197         https://bugs.webkit.org/show_bug.cgi?id=164562
1198
1199         Reviewed by Brady Eidson.
1200
1201         * Storage/WebStorageManager.mm:
1202         (-[WebStorageManager origins]):
1203         (-[WebStorageManager deleteAllOrigins]):
1204         (-[WebStorageManager deleteOrigin:]):
1205         (-[WebStorageManager diskUsageForOrigin:]):
1206         (-[WebStorageManager syncLocalStorage]):
1207         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
1208         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
1209         (+[WebStorageManager closeIdleLocalStorageDatabases]):
1210         (WebKitInitializeStorageIfNecessary):
1211         * WebView/WebView.mm:
1212         (+[WebView _applicationWillTerminate]):
1213
1214 2016-11-09  Beth Dakin  <bdakin@apple.com>
1215
1216         Another attempted build fix.
1217
1218         * WebView/WebView.mm:
1219
1220 2016-11-09  Beth Dakin  <bdakin@apple.com>
1221
1222         Attempted build fix.
1223
1224         * WebView/WebView.mm:
1225
1226 2016-11-09  Darin Adler  <darin@apple.com>
1227
1228         Move Range from ExceptionCode to ExceptionOr
1229         https://bugs.webkit.org/show_bug.cgi?id=164457
1230
1231         Reviewed by Alex Christensen.
1232
1233         * DOM/DOMRange.mm:
1234         (-[DOMRange setStart:offset:]): Updated exception handling.
1235         (-[DOMRange setEnd:offset:]): Ditto.
1236         (-[DOMRange setStartBefore:]): Ditto.
1237         (-[DOMRange setStartAfter:]): Ditto.
1238         (-[DOMRange setEndBefore:]): Ditto.
1239         (-[DOMRange setEndAfter:]): Ditto.
1240         (-[DOMRange selectNode:]): Ditto.
1241         (-[DOMRange selectNodeContents:]): Ditto.
1242         (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
1243         (-[DOMRange deleteContents]): Ditto.
1244         (-[DOMRange extractContents]): Ditto.
1245         (-[DOMRange cloneContents]): Ditto.
1246         (-[DOMRange insertNode:]): Ditto.
1247         (-[DOMRange surroundContents:]): Ditto.
1248         (-[DOMRange createContextualFragment:]): Ditto.
1249         (-[DOMRange compareNode:]): Ditto.
1250         (-[DOMRange intersectsNode:]): Ditto.
1251         (-[DOMRange comparePoint:offset:]): Ditto.
1252         (-[DOMRange isPointInRange:offset:]): Ditto.
1253         (-[DOMRange expand:]): Ditto.
1254         * WebView/WebFrame.mm:
1255         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
1256         (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
1257         This function was incorrectly implemented (set both start and end of
1258         the range to the computed start), not declared in any header file,
1259         not used anywhere inside WebKit, and I also could not find a use of it
1260         in outside-WebKit Apple code.
1261         * mac/DOM/DOMUIKitExtensions.mm:
1262         (-[DOMRange move:inDirection:]): Ditto.
1263         (-[DOMRange extend:inDirection:]): Ditto.
1264
1265 2016-11-09  Darin Adler  <darin@apple.com>
1266
1267         Move EventTarget from ExceptionCode to ExceptionOr
1268         https://bugs.webkit.org/show_bug.cgi?id=164465
1269
1270         Reviewed by Youenn Fablet.
1271
1272         * DOM/DOMNode.mm:
1273         (-[DOMNode dispatchEvent:]): Updated exception handling.
1274
1275 2016-11-09  Chris Dumez  <cdumez@apple.com>
1276
1277         [Mac] Stop using deprecated AppKit enumeration values
1278         https://bugs.webkit.org/show_bug.cgi?id=164494
1279
1280         Reviewed by Darin Adler.
1281
1282         Stop using deprecated AppKit enumeration values.
1283
1284         * Carbon/CarbonWindowAdapter.mm:
1285         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1286         (-[CarbonWindowAdapter sendSuperEvent:]):
1287         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1288         (WebKit::NetscapePluginHostProxy::beginModal):
1289         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1290         (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
1291         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1292         (-[WebHostedNetscapePluginView drawRect:]):
1293         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1294         (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
1295         * WebCoreSupport/PopupMenuMac.mm:
1296         (PopupMenuMac::populate):
1297         (PopupMenuMac::show):
1298         * WebCoreSupport/WebContextMenuClient.mm:
1299         (WebContextMenuClient::showContextMenu):
1300         * WebCoreSupport/WebFrameLoaderClient.mm:
1301         (WebFrameLoaderClient::actionDictionary):
1302         * WebCoreSupport/WebInspectorClient.mm:
1303         (WebInspectorFrontendClient::canAttach):
1304         (-[WebInspectorWindowController window]):
1305         * WebInspector/WebNodeHighlight.mm:
1306         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1307         * WebView/WebFrameView.mm:
1308         (-[WebFrameView keyDown:keyDown:]):
1309         * WebView/WebFullScreenController.mm:
1310         (-[WebFullScreenController init]):
1311         (createBackgroundFullscreenWindow):
1312         * WebView/WebHTMLView.mm:
1313         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
1314         (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
1315         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1316         (isQuickLookEvent):
1317         (-[WebHTMLView hitTest:]):
1318         (-[WebHTMLView _sendToolTipMouseExited]):
1319         (-[WebHTMLView _sendToolTipMouseEntered]):
1320         (mouseEventIsPartOfClickOrDrag):
1321         (-[WebHTMLView _updateMouseoverWithEvent:]):
1322         (-[WebHTMLView _autoscroll]):
1323         (-[WebHTMLView acceptsFirstResponder]):
1324         (-[WebHTMLView viewDidMoveToWindow]):
1325         (-[WebHTMLView mouseDown:mouseDown:]):
1326         (currentKeyboardEvent):
1327         (-[WebHTMLView _handleStyleKeyEquivalent:]):
1328         (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
1329         * WebView/WebPDFView.mm:
1330         (-[WebPDFView hitTest:]):
1331         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1332         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
1333         * WebView/WebTextCompletionController.mm:
1334         (-[WebTextCompletionController _buildUI]):
1335         (-[WebTextCompletionController _placePopupWindow:]):
1336         * WebView/WebView.mm:
1337         (-[WebView applicationFlags:]):
1338
1339 2016-11-09  Beth Dakin  <bdakin@apple.com>
1340
1341         Support TouchBar in WebKit
1342         https://bugs.webkit.org/show_bug.cgi?id=164437
1343         -and corresponding-
1344         rdar://problem/28876524
1345
1346         Reviewed by Darin Adler.
1347
1348         * WebCoreSupport/WebEditorClient.mm:
1349         (WebEditorClient::respondToChangedSelection):
1350         (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
1351         * WebView/WebHTMLView.mm:
1352         (-[WebHTMLView candidateListTouchBarItem]):
1353         * WebView/WebView.mm:
1354         (-[_WebTextListTouchBarViewController initWithWebView:]):
1355         (-[_WebTextListTouchBarViewController _selectList:]):
1356         (-[_WebTextListTouchBarViewController setCurrentListType:]):
1357         (-[WebTextTouchBarItemController initWithWebView:]):
1358         (-[WebTextTouchBarItemController itemForIdentifier:]):
1359         (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
1360         (-[WebTextTouchBarItemController setTextIsBold:]):
1361         (-[WebTextTouchBarItemController setTextIsItalic:]):
1362         (-[WebTextTouchBarItemController setTextIsUnderlined:]):
1363         (-[WebTextTouchBarItemController _webChangeTextStyle:]):
1364         (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
1365         (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
1366         (-[WebTextTouchBarItemController textColor]):
1367         (-[WebTextTouchBarItemController setTextColor:]):
1368         (-[WebTextTouchBarItemController _webChangeColor:]):
1369         (-[WebTextTouchBarItemController textListViewController]):
1370         (-[WebView _commonInitializationWithFrameName:groupName:]):
1371         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1372         (-[WebView shouldRequestCandidates]):
1373         (-[WebView forceRequestCandidatesForTesting]):
1374         (-[WebView makeTouchBar]):
1375         (-[WebView touchBar:makeItemForIdentifier:]):
1376         (textCheckingResultFromNSTextCheckingResult):
1377         (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
1378         (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
1379         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1380         (-[WebView _clearPlaybackControlsManager]):
1381         (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
1382         (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
1383         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
1384         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
1385         (-[WebView touchBarDidExitCustomization:]):
1386         (-[WebView touchBarWillEnterCustomization:]):
1387         (-[WebView didChangeAutomaticTextCompletion:]):
1388         (-[WebView setUpTextTouchBar:]):
1389         (-[WebView _isRichlyEditable]):
1390         (-[WebView textTouchBar]):
1391         (-[WebView updateTextTouchBar]):
1392         (-[WebView updateMediaTouchBar]):
1393         (-[WebView updateTouchBar]):
1394         (-[WebView prepareForMouseDown]):
1395         (-[WebView prepareForMouseUp]):
1396         (-[WebView webViewAdditionsWillDestroyView]):
1397         (-[WebView candidateList]):
1398         (-[WebView updateWebViewAdditions]): Deleted.
1399         * WebView/WebViewData.h:
1400         * WebView/WebViewInternal.h:
1401         * WebView/WebViewPrivate.h:
1402
1403 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1404
1405         Safari does not emit composition end if blurred for dead key / Japanese IME
1406         https://bugs.webkit.org/show_bug.cgi?id=164369
1407         <rdar://problem/29050439>
1408
1409         Reviewed by Ryosuke Niwa.
1410
1411         When canceling a composition, make sure that we clear the system IME state.
1412
1413         * WebCoreSupport/WebEditorClient.h:
1414         * WebCoreSupport/WebEditorClient.mm:
1415         (WebEditorClient::canceledComposition):
1416
1417 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1418
1419         Add a setting and preferences to enable/disable async image decoding
1420         https://bugs.webkit.org/show_bug.cgi?id=164417
1421
1422         Reviewed by Simon Fraser.
1423
1424         Hook up the asyncImageDecodingEnabled setting for WebKit1.
1425
1426         * WebView/WebPreferenceKeysPrivate.h:
1427         * WebView/WebPreferences.mm:
1428         (+[WebPreferences initialize]):
1429         (-[WebPreferences asyncImageDecodingEnabled]):
1430         (-[WebPreferences setAsyncImageDecodingEnabled:]):
1431         * WebView/WebPreferencesPrivate.h:
1432         * WebView/WebView.mm:
1433         (-[WebView _preferencesChanged:]):
1434
1435 2016-11-01  Alex Christensen  <achristensen@webkit.org>
1436
1437         Remove PassRefPtr from DumpRenderTree
1438         https://bugs.webkit.org/show_bug.cgi?id=164307
1439
1440         Reviewed by Sam Weinig.
1441
1442         * WebView/WebGeolocationPosition.mm:
1443         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1444
1445 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1446
1447         [Readable Streams API] Enable creation of ReadableByteStreamController
1448         https://bugs.webkit.org/show_bug.cgi?id=164014
1449
1450         Reviewed by Youenn Fablet.
1451
1452         Added flag for the byte stream part of Readable Streams API.
1453
1454         * Configurations/FeatureDefines.xcconfig:
1455
1456 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
1457
1458         Remove CUSTOM_ELEMENTS build flag
1459         https://bugs.webkit.org/show_bug.cgi?id=164267
1460
1461         Reviewed by Antti Koivisto.
1462
1463         Removed the build flag.
1464
1465         * Configurations/FeatureDefines.xcconfig:
1466         * WebView/WebPreferences.mm:
1467         (+[WebPreferences initialize]):
1468         * WebView/WebView.mm:
1469         (-[WebView _preferencesChanged:]):
1470
1471 2016-11-01  Eric Carlson  <eric.carlson@apple.com>
1472
1473         [MediaStream] restrict media capture secure connections
1474         https://bugs.webkit.org/show_bug.cgi?id=164234
1475         <rdar://problem/28944906>
1476
1477         Reviewed by Alex Christensen.
1478
1479         * WebView/WebPreferenceKeysPrivate.h:
1480         * WebView/WebPreferences.mm:
1481         (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
1482         (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
1483         (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
1484         * WebView/WebPreferencesPrivate.h:
1485
1486         * WebView/WebView.mm:
1487         (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
1488
1489 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
1490
1491         JSC should support SharedArrayBuffer
1492         https://bugs.webkit.org/show_bug.cgi?id=163986
1493
1494         Reviewed by Keith Miller.
1495         
1496         Support the RuntimeFlag.
1497
1498         * WebView/WebPreferencesPrivate.h:
1499
1500 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1501
1502         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
1503         https://bugs.webkit.org/show_bug.cgi?id=164236
1504         <rdar://problem/28747712>
1505
1506         Reviewed by Beth Dakin.
1507
1508         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
1509         dictionary lookup.
1510
1511         * WebCoreSupport/WebEditorClient.mm:
1512         (WebEditorClient::respondToChangedSelection):
1513         * WebView/WebImmediateActionController.mm:
1514         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1515
1516 2016-10-31  Darin Adler  <darin@apple.com>
1517
1518         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
1519         https://bugs.webkit.org/show_bug.cgi?id=164214
1520
1521         Reviewed by Alex Christensen.
1522
1523         * DOM/DOMCSSPrimitiveValue.mm:
1524         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
1525         is a reference now.
1526         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
1527
1528         * DOM/DOMDocument.mm:
1529         (-[DOMDocument querySelector:]): Updated exception handling.
1530         (-[DOMDocument querySelectorAll:]): Ditto.
1531         * DOM/DOMDocumentFragment.mm:
1532         (-[DOMDocumentFragment querySelector:]): Ditto.
1533         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
1534         * DOM/DOMElement.mm:
1535         (-[DOMElement querySelector:]): Ditto.
1536         (-[DOMElement querySelectorAll:]): Ditto.
1537
1538 2016-10-31  Darin Adler  <darin@apple.com>
1539
1540         Convert Document from ExceptionCode to Exception
1541         https://bugs.webkit.org/show_bug.cgi?id=164212
1542
1543         Reviewed by Alex Christensen.
1544
1545         * DOM/DOMDocument.mm:
1546         (-[DOMDocument setXmlVersion:]): Updated exception handling.
1547         (-[DOMDocument cookie]): Ditto.
1548         (-[DOMDocument setCookie:]): Ditto.
1549         (-[DOMDocument setBody:]): Ditto.
1550         (-[DOMDocument createElement:]): Ditto.
1551         (-[DOMDocument createCDATASection:]): Ditto.
1552         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
1553         (-[DOMDocument createAttribute:]): Ditto.
1554         (-[DOMDocument createEntityReference:]): Ditto.
1555         (-[DOMDocument importNode:deep:]): Ditto.
1556         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
1557         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
1558         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
1559         (-[DOMDocument adoptNode:]): Ditto.
1560         (-[DOMDocument createEvent:]): Ditto.
1561
1562 2016-10-30  Darin Adler  <darin@apple.com>
1563
1564         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
1565         https://bugs.webkit.org/show_bug.cgi?id=164206
1566
1567         Reviewed by Chris Dumez.
1568
1569         * DOM/DOMElement.mm:
1570         (-[DOMElement setInnerHTML:]): Updated exception handling.
1571         (-[DOMElement setOuterHTML:]): Ditto.
1572         (-[DOMElement setAttribute:value:]): Ditto.
1573         (-[DOMElement setAttributeNode:]): Ditto.
1574         (-[DOMElement removeAttributeNode:]): Ditto.
1575         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
1576         (-[DOMElement setAttributeNodeNS:]): Ditto.
1577         (-[DOMElement matches:]): Ditto.
1578         (-[DOMElement closest:]): Ditto.
1579         (-[DOMElement webkitMatchesSelector:]): Ditto.
1580         * DOM/DOMHTMLElement.mm:
1581         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
1582         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
1583         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
1584         * DOM/DOMNamedNodeMap.mm:
1585         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
1586         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
1587         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
1588         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
1589
1590 2016-10-29  Darin Adler  <darin@apple.com>
1591
1592         Convert more of DOM from ExceptionCode to Exception
1593         https://bugs.webkit.org/show_bug.cgi?id=164173
1594
1595         Reviewed by Ryosuke Niwa.
1596
1597         * DOM/DOMCharacterData.mm:
1598         (-[DOMCharacterData substringData:length:]): Updated since this
1599         now uses ExceptionOr.
1600         (-[DOMCharacterData insertData:data:]): Ditto.
1601         (-[DOMCharacterData deleteData:length:]): Ditto.
1602         (-[DOMCharacterData replaceData:length:data:]): Ditto.
1603         * DOM/DOMText.mm:
1604         (-[DOMText splitText:]): Ditto.
1605         (-[DOMText replaceWholeText:]): Removed unneeded exception code
1606         handling from function that does not throw an exception.
1607
1608 2016-10-28  Darin Adler  <darin@apple.com>
1609
1610         Move all classes in the HTML directory from ExceptionCode to Exception
1611         https://bugs.webkit.org/show_bug.cgi?id=163876
1612
1613         Reviewed by Sam Weinig.
1614
1615         * DOM/DOMCharacterData.mm:
1616         (-[DOMCharacterData remove]): Updated exception handling.
1617         * DOM/DOMDOMTokenList.mm:
1618         (-[DOMDOMTokenList toggle:force:]): Ditto.
1619         * DOM/DOMDocumentType.mm:
1620         (-[DOMDocumentType remove]): Ditto.
1621         * DOM/DOMElement.mm:
1622         (-[DOMElement remove]): Ditto.
1623         * DOM/DOMHTML.mm:
1624         (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
1625         * DOM/DOMHTMLCanvasElement.mm:
1626         (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
1627         * DOM/DOMHTMLElement.mm:
1628         (-[DOMHTMLElement setInnerText:]): Ditto.
1629         (-[DOMHTMLElement setOuterText:]): Ditto.
1630         (-[DOMHTMLElement setContentEditable:]): Ditto.
1631         * DOM/DOMHTMLInputElement.mm:
1632         (-[DOMHTMLInputElement setMaxLength:]): Ditto.
1633         (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
1634         (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
1635         (-[DOMHTMLInputElement stepUp:]): Ditto.
1636         (-[DOMHTMLInputElement stepDown:]): Ditto.
1637         (-[DOMHTMLInputElement setRangeText:]): Ditto.
1638         (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
1639         * DOM/DOMHTMLMarqueeElement.mm:
1640         (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
1641         * DOM/DOMHTMLMediaElement.mm:
1642         (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
1643         (-[DOMHTMLMediaElement setVolume:]): Ditto.
1644         * DOM/DOMHTMLOptionsCollection.mm:
1645         (-[DOMHTMLOptionsCollection setLength:]): Ditto.
1646         * DOM/DOMHTMLTableElement.mm:
1647         (-[DOMHTMLTableElement setCaption:]): Ditto.
1648         (-[DOMHTMLTableElement setTHead:]): Ditto.
1649         (-[DOMHTMLTableElement setTFoot:]): Ditto.
1650         (-[DOMHTMLTableElement insertRow:]): Ditto.
1651         (-[DOMHTMLTableElement deleteRow:]): Ditto.
1652         * DOM/DOMHTMLTableRowElement.mm:
1653         (-[DOMHTMLTableRowElement insertCell:]): Ditto.
1654         (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
1655         * DOM/DOMHTMLTableSectionElement.mm:
1656         (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
1657         (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
1658         * DOM/DOMHTMLTextAreaElement.mm:
1659         (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
1660         (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
1661         (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
1662         * DOM/DOMHTMLVideoElement.mm:
1663         (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
1664         (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
1665         version (lowercase S) instead of repeating the logic from that method.
1666         (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
1667         * DOM/DOMTimeRanges.mm:
1668         (-[DOMTimeRanges start:]): Updated exception handling.
1669         (-[DOMTimeRanges end:]): Ditto.
1670
1671 2016-10-27  Chris Dumez  <cdumez@apple.com>
1672
1673         Regression(r203601): Caused crashes in iBooks
1674         https://bugs.webkit.org/show_bug.cgi?id=164093
1675         <rdar://problem/28745634>
1676
1677         Reviewed by Darin Adler.
1678
1679         Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
1680         which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
1681
1682         * DOM/DOMNode.mm:
1683         (-[DOMNode compareDocumentPosition:]):
1684
1685 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1686
1687         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
1688         https://bugs.webkit.org/show_bug.cgi?id=163948
1689         <rdar://problem/28921433>
1690
1691         Reviewed by Darin Adler.
1692
1693         Add support for new drag and drop-related EditAction enum values.
1694
1695         * WebCoreSupport/WebEditorClient.mm:
1696         (undoNameForEditAction):
1697
1698 2016-10-27  Dan Bernstein  <mitz@apple.com>
1699
1700         Reapplied the configuration changes from r207934 without breaking iOS builds.
1701
1702         * Configurations/Base.xcconfig:
1703         * Configurations/WebKitLegacy.xcconfig:
1704
1705 2016-10-27  Dan Bernstein  <mitz@apple.com>
1706
1707         Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
1708
1709         * Configurations/Base.xcconfig:
1710         * Configurations/WebKitLegacy.xcconfig:
1711
1712 2016-10-26  Dan Bernstein  <mitz@apple.com>
1713
1714         [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
1715         https://bugs.webkit.org/show_bug.cgi?id=164048
1716
1717         Reviewed by Tim Horton.
1718
1719         * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
1720         * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
1721           headers.
1722
1723         * History/WebBackForwardList.h: Fixed parameter name in @param entry.
1724         * Misc/WebDownload.h: Removed empty entries.
1725         * Misc/WebIconDatabase.h: Remove incorrect @param entries.
1726         * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
1727         * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
1728         * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
1729         * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
1730         * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
1731         * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
1732         * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
1733           Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
1734         * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
1735         * WebView/WebView.h: Changed @method to @property in a couple of places.
1736         * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
1737
1738 2016-10-26  Brian Burg  <bburg@apple.com>
1739
1740         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
1741         https://bugs.webkit.org/show_bug.cgi?id=164046
1742
1743         Reviewed by Joseph Pecoraro.
1744
1745         * WebCoreSupport/WebInspectorClient.h:
1746
1747 2016-10-21  Alex Christensen  <achristensen@webkit.org>
1748
1749         URL::port should return Optional<uint16_t>
1750         https://bugs.webkit.org/show_bug.cgi?id=163806
1751
1752         Reviewed by Darin Adler.
1753
1754         * WebCoreSupport/WebSecurityOrigin.mm:
1755         (-[WebSecurityOrigin port]):
1756
1757 2016-10-24  Dave Hyatt  <hyatt@apple.com>
1758
1759         Remove CSSCharsetRule from the CSS OM
1760         https://bugs.webkit.org/show_bug.cgi?id=163891
1761
1762         Reviewed by Darin Adler.
1763
1764         * DOM/DOMCSSCharsetRule.mm:
1765         (-[DOMCSSCharsetRule encoding]):
1766
1767 2016-10-24  Youenn Fablet  <youenn@apple.com>
1768
1769         Activate WEB_RTC compilation flags for Mac bots
1770         https://bugs.webkit.org/show_bug.cgi?id=163886
1771
1772         Reviewed by Eric Carlson.
1773
1774         * Configurations/FeatureDefines.xcconfig:
1775
1776 2016-10-23  Chris Dumez  <cdumez@apple.com>
1777
1778         addEventListener() / removeEventListener() should use a union for last parameter
1779         https://bugs.webkit.org/show_bug.cgi?id=163863
1780
1781         Reviewed by Darin Adler.
1782
1783         Cast BOOL to bool to help to compiler construct the new variant-type parameter.
1784
1785         * DOM/DOMNode.mm:
1786         (-[DOMNode addEventListener:listener:useCapture:]):
1787         (-[DOMNode addEventListener:::]):
1788         (-[DOMNode removeEventListener:listener:useCapture:]):
1789         (-[DOMNode removeEventListener:::]):
1790
1791 2016-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1792
1793         Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
1794         https://bugs.webkit.org/show_bug.cgi?id=163460
1795         <rdar://problem/28784142>
1796
1797         Reviewed by Darin Adler.
1798
1799         Handle new EditAction types for inserting/deleting pending/final compositions.
1800
1801         * WebCoreSupport/WebEditorClient.mm:
1802         (undoNameForEditAction):
1803
1804 2016-10-21  Jeremy Jones  <jeremyj@apple.com>
1805
1806         Implement basic pointer lock behavior for WebKit and WebKit2.
1807         https://bugs.webkit.org/show_bug.cgi?id=162745
1808
1809         Reviewed by Simon Fraser.
1810
1811         Add basic pointer lock functionality. User permission is not yet implemented.
1812
1813         * WebCoreSupport/WebChromeClient.h:
1814         * WebCoreSupport/WebChromeClient.mm:
1815         (WebChromeClient::requestPointerLock):
1816         (WebChromeClient::requestPointerUnlock):
1817
1818 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
1819
1820         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1821         https://bugs.webkit.org/show_bug.cgi?id=163374
1822
1823         Reviewed by Darin Adler.
1824
1825         * Configurations/FeatureDefines.xcconfig:
1826
1827 2016-10-19  Alex Christensen  <achristensen@webkit.org>
1828
1829         Revert r207151
1830         https://bugs.webkit.org/show_bug.cgi?id=163675
1831
1832         Reviewed by Brent Fulgham.
1833
1834         * Misc/WebDownload.mm:
1835         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
1836         * Misc/WebDownloadInternal.h:
1837         * WebCoreSupport/WebFrameLoaderClient.mm:
1838         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1839         * WebView/WebPreferences.mm:
1840         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
1841         * WebView/WebView.mm:
1842         (-[WebView scheduleInRunLoop:forMode:]):
1843         (-[WebView unscheduleFromRunLoop:forMode:]):
1844
1845 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
1846
1847         Unreviewed, rolling out r207557.
1848
1849         This change caused animations/font-variations tests to time
1850         out on pre-Sierra Macs.
1851
1852         Reverted changeset:
1853
1854         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
1855         iOS 9"
1856         https://bugs.webkit.org/show_bug.cgi?id=163374
1857         http://trac.webkit.org/changeset/207557
1858
1859 2016-10-19  Chris Dumez  <cdumez@apple.com>
1860
1861         Move HTML Interactive Form Validation behind an experimental flag
1862         https://bugs.webkit.org/show_bug.cgi?id=163673
1863
1864         Reviewed by Daniel Bates.
1865
1866         Re-disable HTML Interactive Form Validation by default on Mac WK1.
1867
1868         * WebView/WebViewData.mm:
1869         (-[WebViewPrivate init]):
1870
1871 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
1872
1873         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1874         https://bugs.webkit.org/show_bug.cgi?id=163374
1875
1876         Reviewed by Darin Adler.
1877
1878         * Configurations/FeatureDefines.xcconfig:
1879
1880 2016-10-19  Simon Fraser  <simon.fraser@apple.com>
1881
1882         WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
1883         https://bugs.webkit.org/show_bug.cgi?id=163680
1884
1885         Reviewed by Dean Jackson.
1886
1887         Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
1888
1889         * WebView/WebView.mm:
1890         (-[WebView _preferencesChanged:]):
1891
1892 2016-10-19  Darin Adler  <darin@apple.com>
1893
1894         Move XPath from ExceptionCode to Exception
1895         https://bugs.webkit.org/show_bug.cgi?id=163656
1896
1897         Reviewed by Chris Dumez.
1898
1899         * DOM/DOMDocument.mm:
1900         (wrap): Added. Helper function for wrapping a resolver.
1901         (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
1902         (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
1903         * DOM/DOMXPathExpression.mm:
1904         (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
1905         * DOM/DOMXPathResult.mm:
1906         (-[DOMXPathResult numberValue]): Ditto.
1907         (-[DOMXPathResult stringValue]): Ditto.
1908         (-[DOMXPathResult booleanValue]): Ditto.
1909         (-[DOMXPathResult singleNodeValue]): Ditto.
1910         (-[DOMXPathResult snapshotLength]): Ditto.
1911         (-[DOMXPathResult iterateNext]): Ditto.
1912         (-[DOMXPathResult snapshotItem:]): Ditto.
1913
1914 2016-10-18  Sam Weinig  <sam@webkit.org>
1915
1916         Replace std::experimental::variant with WTF::Variant (or similar)
1917         https://bugs.webkit.org/show_bug.cgi?id=163626
1918
1919         Reviewed by Chris Dumez.
1920
1921         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
1922         into the WTF namespace.
1923
1924         * DOM/DOMHTMLSelectElement.mm:
1925         (-[DOMHTMLSelectElement add:before:]):
1926
1927 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
1928
1929         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
1930         https://bugs.webkit.org/show_bug.cgi?id=163627
1931
1932         Reviewed by Dean Jackson.
1933
1934         Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
1935
1936         * WebView/WebViewPrivate.h:
1937
1938 2016-10-18  Dean Jackson  <dino@apple.com>
1939
1940         Remove CSS_SHAPES feature definition. This should always be on.
1941         https://bugs.webkit.org/show_bug.cgi?id=163628
1942         <rdar://problem/28834613>
1943
1944         Reviewed by Tim Horton.
1945
1946         * Configurations/FeatureDefines.xcconfig:
1947
1948 2016-10-18  Chris Dumez  <cdumez@apple.com>
1949
1950         Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
1951         https://bugs.webkit.org/show_bug.cgi?id=163608
1952
1953         Reviewed by Ryosuke Niwa.
1954
1955         Update add() call sites now that it takes std::variant types in.
1956
1957         * DOM/DOMHTMLOptionsCollection.mm:
1958         (-[DOMHTMLOptionsCollection add:index:]):
1959         * DOM/DOMHTMLSelectElement.mm:
1960         (-[DOMHTMLSelectElement add:before:]):
1961
1962 2016-10-18  Anders Carlsson  <andersca@apple.com>
1963
1964         Get rid of more WebHistoryItem cruft
1965         https://bugs.webkit.org/show_bug.cgi?id=163623
1966
1967         Reviewed by Tim Horton.
1968
1969         * History/WebHistoryItem.mm:
1970         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1971         * History/WebHistoryItemPrivate.h:
1972
1973 2016-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1974
1975         Showing and hiding candidates list is very distracting after selecting word
1976         https://bugs.webkit.org/show_bug.cgi?id=163609
1977         <rdar://problem/28747712>
1978
1979         Reviewed by Tim Horton.
1980
1981         Introduce WebView hooks for mousedown and mouseup. See radar for more details.
1982
1983         * WebView/WebHTMLView.mm:
1984         (-[WebHTMLView mouseDown:mouseDown:]):
1985         (-[WebHTMLView mouseUp:mouseUp:]):
1986         * WebView/WebView.mm:
1987         (-[WebView prepareForMouseDown]):
1988         (-[WebView prepareForMouseUp]):
1989         * WebView/WebViewInternal.h:
1990
1991 2016-10-17  Anders Carlsson  <andersca@apple.com>
1992
1993         Move some history specific HistoryItem code to WebHistoryItem
1994         https://bugs.webkit.org/show_bug.cgi?id=163567
1995
1996         Reviewed by Tim Horton.
1997
1998         * History/HistoryPropertyList.mm:
1999         (HistoryPropertyListWriter::writeHistoryItem):
2000         * History/WebHistory.mm:
2001         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
2002         * History/WebHistoryItem.mm:
2003         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2004         * History/WebHistoryItemInternal.h:
2005         * WebCoreSupport/WebFrameLoaderClient.mm:
2006         (addRedirectURL):
2007         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
2008
2009 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
2010
2011         [MediaStream] Resolve constraints and enumerate devices in the UI process
2012         https://bugs.webkit.org/show_bug.cgi?id=162147
2013         <rdar://problem/28803569>
2014
2015         Reviewed by Darin Adler.
2016
2017         * WebCoreSupport/WebUserMediaClient.h:
2018         * WebCoreSupport/WebUserMediaClient.mm:
2019         (AddPermissionCheckToMap):
2020         (RemovePermissionCheckFromMap):
2021         (WebUserMediaClient::pageDestroyed):
2022         (WebUserMediaClient::requestUserMediaAccess):
2023         (WebUserMediaClient::enumerateMediaDevices):
2024         (WebUserMediaClient::cancelMediaDevicesEnumerationRequest):
2025         (-[WebUserMediaPolicyListener allow]):
2026         (-[WebUserMediaPolicyListener deny]):
2027         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
2028         (-[WebUserMediaPolicyCheckerListener cancelMediaDevicesEnumerationRequest]):
2029         (-[WebUserMediaPolicyCheckerListener allow]):
2030         (-[WebUserMediaPolicyCheckerListener deny]):
2031         (WebUserMediaClient::checkUserMediaPermission): Deleted.
2032         (WebUserMediaClient::cancelUserMediaPermissionCheck): Deleted.
2033         (-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]): Deleted.
2034         (-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]): Deleted.
2035
2036 2016-10-17  Antti Koivisto  <antti@apple.com>
2037
2038         Rename setNeedsStyleRecalc to invalidateStyle
2039         https://bugs.webkit.org/show_bug.cgi?id=163542
2040
2041         Reviewed by Darin Adler.
2042
2043         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2044         (-[WebHostedNetscapePluginView createPluginLayer]):
2045         * Plugins/WebNetscapePluginView.mm:
2046         (-[WebNetscapePluginView createPlugin]):
2047
2048 2016-10-17  Jeremy Jones  <jeremyj@apple.com>
2049
2050         Enable keyboard in fullscreen.
2051         https://bugs.webkit.org/show_bug.cgi?id=163146
2052
2053         Reviewed by Jer Noble.
2054
2055         Allow keyboard in fullscreen.
2056
2057         * WebView/WebView.mm:
2058         (-[WebView _supportsFullScreenForElement:withKeyboard:]):
2059
2060 2016-10-17  Chris Dumez  <cdumez@apple.com>
2061
2062         Move form.reportValidity() behind InteractiveFormValidation setting
2063         https://bugs.webkit.org/show_bug.cgi?id=163550
2064
2065         Reviewed by Darin Adler.
2066
2067         Enable InteractiveFormValidation setting by default and link it to
2068         RuntimeEnabledFeatures so we can use it in the IDL.
2069
2070         * WebView/WebView.mm:
2071         (-[WebView _preferencesChanged:]):
2072         * WebView/WebViewData.mm:
2073         (-[WebViewPrivate init]):
2074
2075 2016-10-17  Anders Carlsson  <andersca@apple.com>
2076
2077         Fix iOS build.
2078
2079         * History/WebBackForwardList.mm:
2080         (-[WebBackForwardList dictionaryRepresentation]):
2081
2082 2016-10-17  Anders Carlsson  <andersca@apple.com>
2083
2084         CTTE some of the BackForwardList member functions
2085         https://bugs.webkit.org/show_bug.cgi?id=163555
2086
2087         Reviewed by Dan Bernstein.
2088
2089         * History/BackForwardList.h:
2090         (BackForwardList::entries):
2091         * History/BackForwardList.mm:
2092         (BackForwardList::removeItem):
2093         (BackForwardList::containsItem):
2094         (BackForwardList::entries): Deleted.
2095         * History/WebBackForwardList.mm:
2096         (-[WebBackForwardList removeItem:]):
2097         (-[WebBackForwardList containsItem:]):
2098         (-[WebBackForwardList description]):
2099
2100 2016-10-17  Anders Carlsson  <andersca@apple.com>
2101
2102         Remove WEBCORE_EXPORT from BackForwardList, it lives in WebKit now
2103         https://bugs.webkit.org/show_bug.cgi?id=163551
2104
2105         Reviewed by Tim Horton.
2106
2107         * History/BackForwardList.h:
2108
2109 2016-10-16  Darin Adler  <darin@apple.com>
2110
2111         Move CSS classes from ExceptionCode to Exception
2112         https://bugs.webkit.org/show_bug.cgi?id=163494
2113
2114         Reviewed by Sam Weinig.
2115
2116         * DOM/DOMCSSMediaRule.mm:
2117         (-[DOMCSSMediaRule insertRule:index:]): Use raiseOnDOMError
2118         the new way to handle ExceptionOr instead of ExceptionCode.
2119         (-[DOMCSSMediaRule deleteRule:]): Ditto.
2120         * DOM/DOMCSSPrimitiveValue.mm:
2121         (-[DOMCSSPrimitiveValue setFloatValue:floatValue:]): Ditto.
2122         (-[DOMCSSPrimitiveValue getFloatValue:]): Ditto.
2123         (-[DOMCSSPrimitiveValue setStringValue:stringValue:]): Ditto.
2124         (-[DOMCSSPrimitiveValue getStringValue]): Ditto.
2125         (-[DOMCSSPrimitiveValue getCounterValue]): Ditto.
2126         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
2127         (-[DOMCSSPrimitiveValue getRGBColorValue]): Ditto.
2128         * DOM/DOMCSSRule.mm:
2129         (-[DOMCSSRule setCssText:]): Ditto.
2130         * DOM/DOMCSSStyleDeclaration.mm:
2131         (-[DOMCSSStyleDeclaration setCssText:]): Ditto.
2132         (-[DOMCSSStyleDeclaration removeProperty:]): Ditto.
2133         (-[DOMCSSStyleDeclaration setProperty:value:priority:]): Ditto.
2134         * DOM/DOMCSSStyleSheet.mm:
2135         (-[DOMCSSStyleSheet insertRule:index:]): Ditto.
2136         (-[DOMCSSStyleSheet deleteRule:]): Ditto.
2137         (-[DOMCSSStyleSheet addRule:style:index:]): Ditto.
2138         (-[DOMCSSStyleSheet removeRule:]): Ditto.
2139         * DOM/DOMCSSValue.mm:
2140         (-[DOMCSSValue setCssText:]): Ditto.
2141         * DOM/DOMMediaList.mm:
2142         (-[DOMMediaList setMediaText:]): Ditto.
2143         (-[DOMMediaList deleteMedium:]): Ditto.
2144         (-[DOMMediaList appendMedium:]): Ditto.
2145
2146         * DOM/ExceptionHandlers.h: Added an overload of raiseDOMException
2147         that works with a WebCore::Exception&& and overloads of
2148         raiseOnDOMError that work with WebCore::ExceptionOr&&.
2149         * DOM/ExceptionHandlers.mm:
2150         (raiseDOMException): Implemented the new version.
2151
2152 2016-10-15  Dan Bernstein  <mitz@apple.com>
2153
2154         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
2155         https://bugs.webkit.org/show_bug.cgi?id=163492
2156         <rdar://problem/28654799>
2157
2158         Reviewed by Darin Adler.
2159
2160         Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm
2161
2162         * WebView/WebHTMLView.mm:
2163         (createMenuItem): Set the tag for items that have submenus as well.
2164
2165 2016-10-14  Anders Carlsson  <andersca@apple.com>
2166
2167         Clean up BackForwardClient
2168         https://bugs.webkit.org/show_bug.cgi?id=163454
2169
2170         Reviewed by Sam Weinig.
2171
2172         * History/BackForwardList.h:
2173         Remove override keywords.
2174
2175         * History/BackForwardList.mm:
2176         (BackForwardList::clearAllPageCaches): Deleted.
2177         Remove this, it's no longer used.
2178
2179         * WebView/WebView.mm:
2180         (-[WebView _clearBackForwardCache]): Deleted.
2181         * WebView/WebViewPrivate.h:
2182         Remove SPI that's no longer used by anyone.
2183
2184 2016-10-13  Anders Carlsson  <andersca@apple.com>
2185
2186         Move BackForwardList from WebCore to WebKitLegacy
2187         https://bugs.webkit.org/show_bug.cgi?id=163418
2188
2189         Reviewed by Tim Horton.
2190
2191         * History/BackForwardList.h: Renamed from Source/WebCore/history/BackForwardList.h.
2192         (BackForwardList::create):
2193         (BackForwardList::webView):
2194         * History/BackForwardList.mm: Renamed from Source/WebCore/history/BackForwardList.cpp.
2195         (BackForwardList::BackForwardList):
2196         (BackForwardList::close):
2197         (BackForwardList::containsItem):
2198         * History/WebBackForwardList.mm:
2199         (kit):
2200         (-[WebBackForwardList initWithBackForwardList:]):
2201         (-[WebBackForwardList setPageCacheSize:]):
2202         (-[WebBackForwardList pageCacheSize]):
2203         * History/WebBackForwardListInternal.h:
2204         * WebCoreSupport/WebFrameLoaderClient.mm:
2205         * WebView/WebFrameView.mm:
2206         * WebView/WebView.mm:
2207         (-[WebView _commonInitializationWithFrameName:groupName:]):
2208         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2209
2210 2016-10-13  Anders Carlsson  <andersca@apple.com>
2211
2212         Get rid of the HistoryItemVector typedef
2213         https://bugs.webkit.org/show_bug.cgi?id=163398
2214
2215         Reviewed by Beth Dakin.
2216
2217         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
2218
2219         * History/WebBackForwardList.mm:
2220         (-[WebBackForwardList dictionaryRepresentation]):
2221         (vectorToNSArray):
2222         (-[WebBackForwardList backListWithLimit:]):
2223         (-[WebBackForwardList forwardListWithLimit:]):
2224         (-[WebBackForwardList description]):
2225         * History/WebHistoryItem.mm:
2226         (-[WebHistoryItem description]):
2227
2228 2016-10-12  Chris Dumez  <cdumez@apple.com>
2229
2230         [Web IDL] Drop support for legacy [ConstructorConditional=*]
2231         https://bugs.webkit.org/show_bug.cgi?id=163368
2232
2233         Reviewed by Ryosuke Niwa.
2234
2235         Drop ENABLE_DOM4_EVENTS_CONSTRUCTOR compiler flag.
2236
2237         * Configurations/FeatureDefines.xcconfig:
2238
2239 2016-10-12  Beth Dakin  <bdakin@apple.com>
2240
2241         Adobe Contribute CS 6.5 Trial crashes on launch
2242         https://bugs.webkit.org/show_bug.cgi?id=163365
2243         -and corresponding-
2244         <rdar://problem/28732731>
2245
2246         Reviewed by Tim Horton.
2247
2248         * Carbon/CarbonWindowFrame.m:
2249         (-[CarbonWindowFrame contentFill]):
2250
2251 2016-10-11  Daniel Bates  <dabates@apple.com>
2252
2253         Attempt to fix the Apple Internal Mac build following r207159
2254         (https://bugs.webkit.org/show_bug.cgi?id=163244)
2255
2256         * WebView/WebView.mm:
2257         (shouldRequireUserGestureToLoadVideo):
2258
2259 2016-10-11  Daniel Bates  <dabates@apple.com>
2260
2261         REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
2262         https://bugs.webkit.org/show_bug.cgi?id=163259
2263         <rdar://problem/28680515>
2264
2265         Reviewed by Jer Noble.
2266
2267         In WebKit1 on iOS we want to require user action to load and play videos by default and
2268         allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
2269         Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
2270         can load and play without being initiated by a user action.
2271
2272         * WebView/WebPreferences.mm:
2273         (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
2274         WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
2275         preference takes precedence over the values of its replacement preferences
2276         WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
2277
2278 2016-10-11  Daniel Bates  <dabates@apple.com>
2279
2280         [iOS] REGRESSION (r197953): User gesture required to load video in iOS 9-built apps
2281         https://bugs.webkit.org/show_bug.cgi?id=163244
2282         <rdar://problem/27250015>
2283
2284         Reviewed by Jer Noble.
2285
2286         Enable or disable the Setting::requiresUserGestureToLoadVideo() in legacy WebKit depending
2287         on the version of iOS SDK that the app was linked against. We require a user gesture to
2288         begin loading a video as of iOS 10.
2289
2290         * WebView/WebView.mm:
2291         (shouldRequireUserGestureToLoadVideo):
2292         (-[WebView _preferencesChanged:]): Modified to pass the WebKit requiresUserGestureToLoadVideo
2293         preference to WebCore.
2294
2295 2016-10-11  Alex Christensen  <achristensen@webkit.org>
2296
2297         Remove dead networking code
2298         https://bugs.webkit.org/show_bug.cgi?id=163263
2299
2300         Reviewed by Daniel Bates.
2301
2302         * Misc/WebDownload.mm:
2303         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2304         * Misc/WebDownloadInternal.h:
2305         * WebCoreSupport/WebFrameLoaderClient.mm:
2306         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2307         * WebView/WebPreferences.mm:
2308         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
2309         * WebView/WebView.mm:
2310         (-[WebView scheduleInRunLoop:forMode:]):
2311         (-[WebView unscheduleFromRunLoop:forMode:]):
2312
2313 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
2314
2315         Add ENABLE_ENCRYPTED_MEDIA configuration option
2316         https://bugs.webkit.org/show_bug.cgi?id=163219
2317
2318         Reviewed by Darin Adler.
2319
2320         * Configurations/FeatureDefines.xcconfig:
2321         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
2322         to enable or disable the new EME implementation at build-time.
2323
2324 2016-10-10  Darin Adler  <darin@apple.com>
2325
2326         Move NotificationCenter from legacy to new DOM exceptions
2327         https://bugs.webkit.org/show_bug.cgi?id=163217
2328
2329         Reviewed by Chris Dumez.
2330
2331         * WebView/WebView.mm:
2332         (-[WebView _notificationIDForTesting:]): Pass reference to page rather than pointer.
2333
2334 2016-10-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2335
2336         Support InputEvent.inputType for the new InputEvent spec
2337         https://bugs.webkit.org/show_bug.cgi?id=163025
2338         <rdar://problem/28658092>
2339
2340         Reviewed by Darin Adler.
2341
2342         Accounts for some changes to the EditAction enum in nameForEditAction. See WebCore ChangeLog
2343         entry for more details.
2344
2345         * WebCoreSupport/WebEditorClient.mm:
2346         (undoNameForEditAction):
2347
2348 2016-10-06  Darin Adler  <darin@apple.com>
2349
2350         Next step on moving to modern way to return DOM exceptions
2351         https://bugs.webkit.org/show_bug.cgi?id=163016
2352
2353         Reviewed by Ryosuke Niwa.
2354
2355         * DOM/DOMDOMImplementation.mm:
2356         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated for
2357         name change from takeReturnValue to releaseReturnValue.
2358         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2359
2360 2016-10-07  Simon Fraser  <simon.fraser@apple.com>
2361
2362         [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
2363         https://bugs.webkit.org/show_bug.cgi?id=163154
2364         rdar://problem/28674216
2365
2366         Reviewed by Tim Horton.
2367         
2368         r55159 added code to counteract AppKit's adjustment of dirty regions during scrolling,
2369         by offsetting the dirty rect in -setNeedsDisplayInRect: if the call happens during
2370         the NSViewBoundsDidChangeNotification handling.
2371         
2372         However, AppKit only does dirty region adjustment in the code path that blits ("copy
2373         on scroll"), so r55159 produces incorrect behavior in, for example, layer-backed views.
2374         
2375         Fix by overriding -[NSClipView _canCopyOnScrollForDeltaX:deltaY:] to know if a single
2376         scroll is going to blit, and only do adjustments in -setNeedsDisplayInRect: if it is.
2377
2378         * WebView/WebClipView.h:
2379         * WebView/WebClipView.mm:
2380         (-[WebClipView _immediateScrollToPoint:]):
2381         (-[WebClipView _canCopyOnScrollForDeltaX:deltaY:]):
2382         (-[WebClipView currentScrollIsBlit]):
2383         * WebView/WebHTMLView.mm:
2384         (-[WebHTMLView setNeedsDisplayInRect:]):
2385         (-[WebHTMLView drawRect:]):
2386
2387 2016-10-06  Youenn Fablet  <youenn@apple.com>
2388
2389         CachedResource client handling methods should take reference
2390         https://bugs.webkit.org/show_bug.cgi?id=163014
2391
2392         Reviewed by Alex Christensen.
2393
2394         * WebView/WebHTMLView.mm:
2395         (promisedDataClient):
2396
2397 2016-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
2398
2399         Put variation fonts work behind a compile-time flag
2400         https://bugs.webkit.org/show_bug.cgi?id=162949
2401
2402         Reviewed by Simon Fraser.
2403
2404         * Configurations/FeatureDefines.xcconfig:
2405
2406 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
2407
2408         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
2409         https://bugs.webkit.org/show_bug.cgi?id=162903
2410
2411         Reviewed by Alex Christensen.
2412
2413         Rename build guards for the remaining implementation of the legacy EME API
2414         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
2415         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
2416
2417         * Configurations/FeatureDefines.xcconfig:
2418         * WebView/WebPreferences.mm:
2419         (+[WebPreferences initialize]):
2420         * WebView/WebView.mm:
2421         (-[WebView _preferencesChanged:]):
2422
2423 2016-10-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2424
2425         The dragged image should be the current frame only of the animated image
2426         https://bugs.webkit.org/show_bug.cgi?id=162109
2427
2428         Reviewed by Tim Horton.
2429
2430         * DOM/DOM.mm:
2431         (-[DOMElement image]): Call the Image function with its new name.
2432         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2433         * Misc/WebElementDictionary.mm:
2434         (-[WebElementDictionary _image]): Call the Image function with its new name.
2435         * Misc/WebIconDatabase.mm:
2436         (-[WebIconDatabase defaultIconWithSize:]): Call snapshotNSImage() to create the icon image.
2437         (webGetNSImage): Call the Image function with its new name.
2438         * WebCoreSupport/WebContextMenuClient.mm:
2439         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call snapshotNSImage() instead of nsImage()..
2440         (WebContextMenuClient::contextMenuForEvent): Ditto.
2441         * WebView/WebHTMLView.mm:
2442         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2443
2444 2016-10-02  Ryan Haddad  <ryanhaddad@apple.com>
2445
2446         Unreviewed, rolling out r206683.
2447
2448         This change caused API test WebKit2.FindMatches to fail on
2449         Mac.
2450
2451         Reverted changeset:
2452
2453         "The dragged image should be the current frame only of the
2454         animated image"
2455         https://bugs.webkit.org/show_bug.cgi?id=162109
2456         http://trac.webkit.org/changeset/206683
2457
2458 2016-09-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
2459
2460         The dragged image should be the current frame only of the animated image
2461         https://bugs.webkit.org/show_bug.cgi?id=162109
2462
2463         Reviewed by Tim Horton.
2464
2465         * DOM/DOM.mm:
2466         (-[DOMElement image]): Call the Image function with its new name.
2467         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2468         * Misc/WebElementDictionary.mm:
2469         (-[WebElementDictionary _image]): Call the Image function with its new name.
2470         * Misc/WebIconDatabase.mm:
2471         (-[WebIconDatabase defaultIconWithSize:]): Call currentFrameNSImage() to create the icon image.
2472         (webGetNSImage): Call the Image function with its new name.
2473         * WebCoreSupport/WebContextMenuClient.mm:
2474         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call currentFrameNSImage() instead of nsImage()..
2475         (WebContextMenuClient::contextMenuForEvent): Ditto.
2476         * WebView/WebHTMLView.mm:
2477         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2478
2479 2016-09-27  Jer Noble  <jer.noble@apple.com>
2480
2481         Remove deprecated ENCRYPTED_MEDIA implementation.
2482         https://bugs.webkit.org/show_bug.cgi?id=161010
2483
2484         Remove ENABLE_ENCRYPTED_MEDIA.
2485
2486         Reviewed by Eric Carlson.
2487
2488         * Configurations/FeatureDefines.xcconfig:
2489
2490 2016-09-26  Daniel Bates  <dabates@apple.com>
2491
2492         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
2493         https://bugs.webkit.org/show_bug.cgi?id=162365
2494
2495         Reviewed by Simon Fraser.
2496
2497         * Configurations/FeatureDefines.xcconfig:
2498         * WebView/WebFrame.mm:
2499         * WebView/WebPreferences.mm:
2500         (+[WebPreferences initialize]):
2501         * WebView/WebView.mm:
2502         (-[WebView _preferencesChanged:]):
2503
2504 2016-09-25  Antti Koivisto  <antti@apple.com>
2505
2506         AuthorStyleSheets shouldn't trigger synchronous style resolutions
2507         https://bugs.webkit.org/show_bug.cgi?id=162532
2508
2509         Reviewed by Darin Adler.
2510
2511         * WebView/WebHTMLView.mm:
2512         (-[WebHTMLView reapplyStyles]):
2513         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2514
2515 2016-09-24  Antti Koivisto  <antti@apple.com>
2516
2517         Move stylesheet change logic from Document to AuthorStyleSheets
2518         https://bugs.webkit.org/show_bug.cgi?id=162488
2519
2520         Reviewed by Andreas Kling.
2521
2522         * WebView/WebHTMLView.mm:
2523         (-[WebHTMLView reapplyStyles]):
2524         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2525
2526 2016-09-23  Caitlin Potter  <caitp@igalia.com>
2527
2528         [JSC] Implement parsing of Async Functions
2529         https://bugs.webkit.org/show_bug.cgi?id=161409
2530
2531         Reviewed by Yusuke Suzuki.
2532
2533         * Configurations/FeatureDefines.xcconfig:
2534
2535 2016-09-23  Commit Queue  <commit-queue@webkit.org>
2536
2537         Unreviewed, rolling out r206311.
2538         https://bugs.webkit.org/show_bug.cgi?id=162495
2539
2540         Broke internal iOS build (Requested by anttik on #webkit).
2541
2542         Reverted changeset:
2543
2544         "Move stylesheet change logic from Document to
2545         AuthorStyleSheets"
2546         https://bugs.webkit.org/show_bug.cgi?id=162488
2547         http://trac.webkit.org/changeset/206311
2548
2549 2016-09-23  Antoine Quint  <graouts@apple.com>
2550
2551         Add a new runtime flag for work on modern media controls (off by default)
2552         https://bugs.webkit.org/show_bug.cgi?id=162420
2553         <rdar://problem/27989489>
2554
2555         Reviewed by Eric Carlson.
2556
2557         * WebView/WebPreferenceKeysPrivate.h:
2558         * WebView/WebPreferences.mm:
2559         (-[WebPreferences modernMediaControlsEnabled]):
2560         (-[WebPreferences setModernMediaControlsEnabled:]):
2561         * WebView/WebPreferencesPrivate.h:
2562         * WebView/WebView.mm:
2563         (-[WebView _preferencesChanged:]):
2564
2565 2016-09-21  Anders Carlsson  <andersca@apple.com>
2566
2567         Support openPaymentSetup API on ApplePaySession object
2568         https://bugs.webkit.org/show_bug.cgi?id=162357
2569         rdar://problem/26776939
2570
2571         Reviewed by Tim Horton.
2572
2573         Add openPaymentSetup stub.
2574
2575         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2576         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2577         (WebPaymentCoordinatorClient::openPaymentSetup):
2578
2579 2016-09-19  Daniel Bates  <dabates@apple.com>
2580
2581         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
2582         https://bugs.webkit.org/show_bug.cgi?id=162167
2583
2584         Reviewed by Simon Fraser.
2585
2586         * Configurations/FeatureDefines.xcconfig:
2587
2588 2016-09-19  Joseph Pecoraro  <pecoraro@apple.com>
2589
2590         Web Inspector: Bring the inspected page's window forward when activating element search
2591         https://bugs.webkit.org/show_bug.cgi?id=162114
2592         <rdar://problem/28349357>
2593
2594         Reviewed by Brian Burg.
2595
2596         * WebCoreSupport/WebInspectorClient.mm:
2597         (WebInspectorClient::didSetSearchingForNode):
2598         When element search is activated bring the window
2599         containing the inspected page to the foreground.
2600
2601 2016-09-15  Brady Eidson  <beidson@apple.com>
2602
2603         WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
2604         <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
2605
2606         Reviewed by Brent Fulgham. 
2607
2608         * WebCoreSupport/WebFrameLoaderClient.h:
2609         * WebCoreSupport/WebFrameLoaderClient.mm:
2610         (WebFrameLoaderClient::dispatchDidCommitLoad):
2611
2612 2016-09-15  Anders Carlsson  <andersca@apple.com>
2613
2614         This was supposed to be committed with the previous patch!
2615
2616         * Plugins/WebBasePluginPackage.mm:
2617         (pathByResolvingSymlinksAndAliases): Deleted.
2618
2619 2016-09-15  Anders Carlsson  <andersca@apple.com>
2620
2621         Replace use of Carbon file system APIs in plug-in loading
2622         https://bugs.webkit.org/show_bug.cgi?id=162040
2623         rdar://problem/6017896
2624
2625         Reviewed by Sam Weinig.
2626
2627         * Plugins/WebBasePluginPackage.mm:
2628         (-[WebBasePluginPackage initWithPath:]):
2629         Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
2630         to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).
2631
2632 2016-09-15  Beth Dakin  <bdakin@apple.com>
2633
2634         Need hasMarkedText on Mac
2635         https://bugs.webkit.org/show_bug.cgi?id=162026
2636         -and corresponding-
2637         rdar://problem/28272353
2638
2639         Reviewed by Anders Carlsson.
2640
2641         * WebView/WebHTMLViewInternal.h:
2642
2643 2016-09-12  Dean Jackson  <dino@apple.com>
2644
2645         Replace RGBA32 with Color in member variables
2646         https://bugs.webkit.org/show_bug.cgi?id=161856
2647         <rdar://problem/28254324>
2648
2649         Reviewed by Simon Fraser.
2650
2651         In preparation for the Color class to become more than
2652         just a 4-byte RGBA value, I went through a few places
2653         that were using the RGBA32 type directly, and replaced
2654         them with Color. This will make some objects a little
2655         bigger e.g. BorderValue and its friends.
2656
2657         I mostly looked at the places that were using RGBA32 as
2658         a member variable. There is still a lot of RGBA32 use
2659         around the project, in particular the CSS parser.
2660
2661         There should be no behaviour change.
2662
2663         * Misc/WebKitNSStringExtras.mm:
2664         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Explicitly
2665         call a Color constructor, rather than passing an RGBA32.
2666
2667 2016-09-13  Chris Dumez  <cdumez@apple.com>
2668
2669         Drop support for <isindex>
2670         https://bugs.webkit.org/show_bug.cgi?id=7139
2671
2672         Reviewed by Ryosuke Niwa.
2673
2674         Drop references to isindex.
2675
2676         * WebCoreSupport/WebEditorClient.mm:
2677         (attributesForAttributedStringConversion):
2678         * WebView/WebHTMLView.mm:
2679         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
2680
2681 2016-09-12  Chris Dumez  <cdumez@apple.com>
2682
2683         Switch remaining users of Document::inPageCache() to pageCacheState()
2684         https://bugs.webkit.org/show_bug.cgi?id=161865
2685
2686         Reviewed by Darin Adler.
2687
2688         Switch remaining users of Document::inPageCache() to pageCacheState() as
2689         the former one is confusing (given that it returns true while the
2690         pagehide event is being fired).
2691
2692         * WebView/WebHTMLView.mm:
2693         (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]):
2694         (-[WebHTMLView setNeedsLayout:]):
2695         (-[WebHTMLView setNeedsToApplyStyles:]):
2696
2697 2016-09-09  Tim Horton  <timothy_horton@apple.com>
2698
2699         Text replacement candidates don't always overwrite the entire original string
2700         https://bugs.webkit.org/show_bug.cgi?id=161779
2701         <rdar://problem/28033492>
2702
2703         Reviewed by Simon Fraser.
2704
2705         * WebCoreSupport/WebEditorClient.mm:
2706         (WebEditorClient::requestCandidatesForSelection):
2707         Make use of the shared implementation of contextRangeForCandidateRequest.
2708
2709 2016-09-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
2710
2711         Move the BitmapImage platform dependent code to a new file named NativeImage[CG|Cairo].cpp
2712         https://bugs.webkit.org/show_bug.cgi?id=158684
2713
2714         Reviewed by Simon Fraser.
2715
2716         * DOM/DOM.mm:
2717         (-[DOMNode getPreviewSnapshotImage:andRects:]):
2718         * Misc/WebCache.mm:
2719         (+[WebCache imageForURL:]):
2720         Replace BitmapImage::getCGImageRef() with BitmapImage::nativeImage().
2721
2722 2016-09-07  Joseph Pecoraro  <pecoraro@apple.com>
2723
2724         [Mac] Address some clang static analyzer warnings in WebKit
2725         https://bugs.webkit.org/show_bug.cgi?id=161597
2726
2727         Reviewed by Darin Adler.
2728
2729         * Misc/WebIconDatabase.h:
2730         Remove unused instance variable. It has not been used since r16005 (2006)!
2731
2732         * Misc/WebSharingServicePickerController.mm:
2733         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2734         Address array leak.
2735
2736         * WebCoreSupport/WebSelectionServiceController.mm:
2737         (WebSelectionServiceController::hasRelevantSelectionServices):
2738         Address attachment and cell leak.
2739
2740         * WebView/WebFullScreenController.h:
2741         * WebView/WebImmediateActionController.h:
2742         Remove unused instance variables.
2743
2744 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
2745
2746         Enable the <meter> element on iOS
2747         https://bugs.webkit.org/show_bug.cgi?id=161714
2748         rdar://problem/8978410
2749
2750         Reviewed by Tim Horton.
2751
2752         Define ENABLE_METER_ELEMENT unconditionally now.
2753
2754         * Configurations/FeatureDefines.xcconfig:
2755
2756 2016-09-07  Mark Lam  <mark.lam@apple.com>
2757
2758         Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
2759         https://bugs.webkit.org/show_bug.cgi?id=161498
2760
2761         Reviewed by Geoffrey Garen.
2762
2763         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2764         (WebKit::NetscapePluginInstanceProxy::evaluate):
2765         (WebKit::NetscapePluginInstanceProxy::invoke):
2766         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2767         (WebKit::NetscapePluginInstanceProxy::construct):
2768         (WebKit::NetscapePluginInstanceProxy::getProperty):
2769         (WebKit::NetscapePluginInstanceProxy::setProperty):
2770         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2771         (WebKit::NetscapePluginInstanceProxy::hasProperty):
2772         (WebKit::NetscapePluginInstanceProxy::hasMethod):
2773         (WebKit::NetscapePluginInstanceProxy::enumerate):
2774         * WebView/WebView.mm:
2775         (aeDescFromJSValue):
2776
2777 2016-09-07  Youenn Fablet  <youenn@apple.com>
2778
2779         [Streams API] Separate compile flag for ReadableStream and WritableStream
2780         https://bugs.webkit.org/show_bug.cgi?id=161044
2781
2782         Reviewed by Alex Christensen.
2783
2784         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
2785
2786         * Configurations/FeatureDefines.xcconfig:
2787
2788 2016-09-06  Chris Dumez  <cdumez@apple.com>
2789
2790         Add support for input.minLength / textArea.minLength
2791         https://bugs.webkit.org/show_bug.cgi?id=161644
2792
2793         Reviewed by Darin Adler.
2794
2795         Update ObjC bindings to reflect method renaming.
2796
2797         * DOM/DOMHTMLInputElement.mm:
2798         (-[DOMHTMLInputElement maxLength]):
2799         (-[DOMHTMLInputElement setMaxLength:]):
2800         * DOM/DOMHTMLTextAreaElement.mm:
2801         (-[DOMHTMLTextAreaElement maxLength]):
2802         (-[DOMHTMLTextAreaElement setMaxLength:]):
2803
2804 2016-09-06  Dan Bernstein  <mitz@apple.com>
2805
2806         <rdar://problem/8064563> Ugly NSLog in DOMInternal.mm
2807
2808         Rubber-stamped by Anders Carlsson.
2809
2810         * DOM/DOMInternal.mm:
2811         (-[WebScriptObject _initializeScriptDOMNodeImp]): Removed useless call to NSLog.
2812
2813 2016-09-06  Ryan Haddad  <ryanhaddad@apple.com>
2814
2815         Unreviewed, rolling out r205407.
2816
2817         Not the correct way to implement this functionality
2818
2819         Reverted changeset:
2820
2821         "Consult with the FrameLoaderClient about whether or not
2822         content extensions should be enabled when loading this URL."
2823         https://bugs.webkit.org/show_bug.cgi?id=161441
2824         http://trac.webkit.org/changeset/205407
2825
2826 2016-09-05  Darin Adler  <darin@apple.com>
2827
2828         More bindings improvements, particularly things not needed for JavaScript bindings
2829         https://bugs.webkit.org/show_bug.cgi?id=161572
2830
2831         Reviewed by Sam Weinig.
2832
2833         * DOM/DOMDOMImplementation.mm:
2834         (-[DOMImplementation hasFeature:version:]): Call SVGTests::hasFeatureForLegacyBindings
2835         instead of DOMImplementation::hasFeature. Also removed JSMainThreadNullState
2836         since this does not do anything that can invoke JavaScript.
2837
2838         * DOM/DOMDocument.mm:
2839         (-[DOMDocument defaultCharset]): Call defaultCharsetForLegacyBindings. Also removed
2840         JSMainThreadNullState.
2841
2842         * DOM/DOMDocumentType.mm:
2843         (-[DOMDocumentType entities]): Changed to simply return nil; same behavior as before,
2844         but with no dependency on WebCore. Also removed JSMainThreadNullState.
2845         (-[DOMDocumentType notations]): Ditto.
2846         (-[DOMDocumentType internalSubset]): Ditto, except empty string rather than nil.
2847
2848         * DOM/DOMNode.mm:
2849         (-[DOMNode isSupported:version:]): Call SVGTests::hasFeatureForLegacyBindings
2850         instead of Node::isSupportedForBindings. Also removed JSMainThreadNullState.
2851
2852 2016-09-04  Joseph Pecoraro  <pecoraro@apple.com>
2853
2854         Remove unnecessary RetainPtr.
2855
2856         Review comments on earlier change.
2857
2858         * WebView/WebImmediateActionController.mm:
2859         (-[WebImmediateActionController _defaultAnimationController]):
2860
2861 2016-09-03  Darin Adler  <darin@apple.com>
2862
2863         Streamline DOMImplementation, and move it to our new DOM exception system
2864         https://bugs.webkit.org/show_bug.cgi?id=161295
2865
2866         Reviewed by Ryosuke Niwa.
2867
2868         * DOM/DOMDOMImplementation.mm:
2869         (unwrap): Added. Use this instead of the IMPL macro.
2870         (-[DOMImplementation dealloc]): Updated to use unwrap.
2871         (-[DOMImplementation hasFeature:version:]): Ditto.
2872         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated to work with
2873         ExceptionOr.
2874         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2875         (-[DOMImplementation createCSSStyleSheet:media:]): Removed exception logic since
2876         this function can no longer raise an exception.
2877         (-[DOMImplementation createHTMLDocument:]): Updated to use unwrap.
2878         (-[DOMImplementation hasFeature::]): Changed to call the non-deprecated version
2879         rather than duplicating its implementation. Also moved into the category as defined
2880         in the header.
2881         (-[DOMImplementation createDocumentType:::]): Ditto.
2882         (-[DOMImplementation createDocument:::]): Ditto.
2883         (-[DOMImplementation createCSSStyleSheet::]): Ditto.
2884
2885         * DOM/DOMDocument.mm: Removed unneeded include of DOMImplementation.h.
2886         (-[DOMDocument setXmlStandalone:]): Updated since setXMLStandalone no longer can
2887         raise an exception.
2888
2889         * WebView/WebFrame.mm:
2890         (-[WebFrame _canProvideDocumentSource]): Updated to use isTextMIMEType in its new
2891         location in MIMETypeRegistry instead of in DOMImplementation.
2892
2893 2016-09-03  Brian Weinstein  <bweinstein@apple.com>
2894
2895         Implement a stub version of FrameLoaderClient::shouldUseContentExtensionsForURL.
2896         https://bugs.webkit.org/show_bug.cgi?id=16144
2897
2898         Reviewed by Darin Adler.
2899
2900         * WebCoreSupport/WebFrameLoaderClient.h:
2901
2902 2016-09-02  Beth Dakin  <bdakin@apple.com>
2903
2904         Need to updateEditorState if an element change edit-ability without changing 
2905         selection
2906         https://bugs.webkit.org/show_bug.cgi?id=161546
2907         -and corresponding-
2908         rdar://problem/27806012
2909
2910         Reviewed by Ryosuke Niwa.
2911
2912         Every time WebEditorClient::respondToChangedSelection is called, we now save 
2913         whether the last state was contentEditable. That way in 
2914         updateEditorStateAfterLayoutIfNeeded() we can assess whether or not edit-ability 
2915         has changed. 
2916
2917         * WebCoreSupport/WebEditorClient.h:
2918         * WebCoreSupport/WebEditorClient.mm:
2919         (WebEditorClient::respondToChangedSelection):
2920         (WebEditorClient:: updateEditorStateAfterLayoutIfEditabilityChanged):
2921
2922 2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
2923
2924         [Mac] RetainPtr misuse, AnimationController leaks
2925         https://bugs.webkit.org/show_bug.cgi?id=161552
2926
2927         Reviewed by Tim Horton.
2928
2929         * WebView/WebImmediateActionController.mm:
2930         (-[WebImmediateActionController _defaultAnimationController]):
2931
2932 2016-07-08  Jer Noble  <jer.noble@apple.com>
2933
2934         Refactor WebPlaybackSessionModelMediaElement to be client based.
2935         https://bugs.webkit.org/show_bug.cgi?id=159580
2936
2937         Reviewed by Eric Carlson.
2938
2939         No longer necessary to tell the models and interfaces about each other.
2940
2941         * WebView/WebView.mm:
2942         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
2943         (-[WebView _clearPlaybackControlsManager]):
2944
2945 2016-09-01  Dan Bernstein  <mitz@apple.com>
2946
2947         Build fix.
2948
2949         * Configurations/FeatureDefines.xcconfig:
2950
2951 2016-09-01  Myles C. Maxfield  <mmaxfield@apple.com>
2952
2953         Clean up TextRun-related code
2954         https://bugs.webkit.org/show_bug.cgi?id=161473
2955
2956         Reviewed by Simon Fraser.
2957
2958         Remove unused #includes.
2959
2960         * WebCoreSupport/WebDragClient.mm:
2961         * WebView/WebView.mm:
2962
2963 2016-08-31  Keith Rollin  <krollin@apple.com>
2964
2965         WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
2966         https://bugs.webkit.org/show_bug.cgi?id=160969
2967         <rdar://problem/26068734>
2968
2969         Reviewed by Simon Fraser.
2970
2971         Enable subsystem- and channel-related data and functions when using
2972         RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
2973         and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
2974
2975         * Misc/WebKitLogging.h:
2976         * Misc/WebKitLogging.m:
2977         * WebView/WebView.mm:
2978         (-[WebView _commonInitializationWithFrameName:groupName:]):
2979
2980 2016-08-31  Brady Eidson  <beidson@apple.com>
2981
2982         WK2 Gamepad provider on iOS.
2983         https://bugs.webkit.org/show_bug.cgi?id=161412
2984
2985         Reviewed by Tim Horton.
2986
2987         * Configurations/FeatureDefines.xcconfig:
2988
2989         * WebView/WebView.mm:
2990         (WebKitInitializeGamepadProviderIfNecessary):
2991
2992 2016-08-30  Mark Lam  <mark.lam@apple.com>
2993
2994         Introduce the ThrowScope and force every throw site to instantiate a ThrowScope.
2995         https://bugs.webkit.org/show_bug.cgi?id=161171
2996
2997         Reviewed by Filip Pizlo and Geoffrey Garen.
2998
2999         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3000         (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
3001         * Plugins/Hosted/ProxyInstance.mm:
3002         (WebKit::ProxyInstance::invokeMethod):
3003
3004 2016-08-28  Andreas Kling  <akling@apple.com>
3005
3006         document.title setter can't throw.
3007         <https://webkit.org/b/161302>
3008
3009         Reviewed by Antti Koivisto.
3010
3011         * DOM/DOMDocument.mm:
3012         (-[DOMDocument setTitle:]):
3013
3014 2016-08-28  Andreas Kling  <akling@apple.com>
3015
3016         Clean up some .text attribute setters that don't throw.
3017         <https://webkit.org/b/161292>
3018
3019         Reviewed by Darin Adler.
3020
3021         * DOM/DOMHTMLTitleElement.mm:
3022         (-[DOMHTMLTitleElement setText:]):
3023
3024 2016-08-26  Sam Weinig  <sam@webkit.org>
3025
3026         Remove support for ENABLE_LEGACY_WEB_AUDIO
3027         https://bugs.webkit.org/show_bug.cgi?id=161262
3028
3029         Reviewed by Anders Carlsson.
3030
3031         * Configurations/FeatureDefines.xcconfig:
3032         Remove ENABLE_LEGACY_WEB_AUDIO
3033
3034 2016-08-25  Anders Carlsson  <andersca@apple.com>
3035
3036         Re-export DOMException NSStrings after r204717
3037         https://bugs.webkit.org/show_bug.cgi?id=161200
3038         <rdar://problem/27959937>
3039
3040         Reviewed by Alex Christensen.
3041
3042         * DOM/ExceptionHandlers.mm:
3043         (raiseDOMException):
3044         * WebKit.exp:
3045
3046 2016-08-22  Darin Adler  <darin@apple.com>
3047
3048         Move Objective-C DOM bindings from WebCore to legacy WebKit
3049         https://bugs.webkit.org/show_bug.cgi?id=160654
3050
3051         Reviewed by Alex Christensen.
3052
3053         * DOM: Added lots of files to the directory.
3054         The files are just as they were in bindings/objc except that the paths of includes
3055         have been updated as needed, and the code no longer is defined inside the WebCore
3056         namespace, requring changes to various functions and their call sites. Also removed
3057         all the WEBCORE_EXPORT since we export differently here in legacy WebKit.
3058
3059         * DOM/DOMInternal.h: Moved. Replaced createDOMWrapper with initializeDOMWrapperHooks.
3060         * DOM/DOMUtility.mm: Moved.
3061         (createDOMWrapper): Simplified to use toWrapped and not do unneeded namespace tricks.
3062         (disconnectWindowWrapper): Added.
3063         (initializeDOMWrapperHooks): Added.
3064
3065         * MigrateHeaders.make: Removed all the internal headers since they are now just
3066         normal project headers. Added the "DOM" directory to the VPATH. Some of the headers
3067         from WebCore are still being migrated, so we can't remove WebCorePrivateHeaders yet.
3068
3069         * WebCoreSupport/WebEditorClient.h: Updated to return RefPtr<DocumentFragment>.
3070
3071         * WebCoreSupport/WebEditorClient.mm:
3072         (WebEditorClient::documentFragmentFromDelegate): Use RefPtr.
3073
3074         * WebKit.exp: Added exports for all the classes that used to use WEBCORE_EXPORT to
3075         be exported from WebCore.
3076
3077         * WebView/WebFrame.mm:
3078         (-[WebFrame innerLineHeight:]): Moved code from WebCore::Frame::innerLineHeight here.
3079         No longer depend on whether this node happens to be in this frame. Also removed
3080         unneeded null check since a node's document can't be null.
3081
3082         * WebView/WebHTMLView.mm: Removed uneeded include of ExceptionHandlers.h, which
3083         is now here in WebKitLegacy instead of WebCore. But no need to include it at all.
3084
3085         * WebView/WebView.mm:
3086         (-[WebView _commonInitializationWithFrameName:groupName:]): Call
3087         initializeDOMWrapperHooks so WebScriptObject can create DOM binding wrappers when
3088         making a script object for a DOM object, rather than just a generic script object.
3089         (+[WebView enableWebThread]): Added a call to WebCoreObjCDeallocOnWebThread here for
3090         DOMObject along with the other classes. This was done in WebCore before, but DOMObject is now
3091         defined here in legacy WebKit.
3092         (-[WebView styleAtSelectionStart]): Moved code from WebCore::Frame::styleAtSelectionStart here.
3093         Replaced incorrect code that called "new PropertySetCSSStyleDeclaration" with a misleading comment
3094         about reference counting; that code was leaking all the style declarations. Instead use
3095         MutableStyleProperties::ensureCSSStyleDeclaration, which is designed for this purpose.
3096
3097 2016-08-22  Youenn Fablet  <youenn@apple.com>
3098
3099         [Fetch API] Activate fetch api runtime flag by default
3100         https://bugs.webkit.org/show_bug.cgi?id=160452
3101
3102         Reviewed by Alex Christensen.
3103
3104         * WebView/WebPreferences.mm:
3105         (+[WebPreferences initialize]):
3106
3107 2016-08-21  Alex Christensen  <achristensen@webkit.org>
3108
3109         Use Document& instead of Document* when getting cookies
3110         https://bugs.webkit.org/show_bug.cgi?id=161011
3111
3112         Reviewed by Darin Adler.
3113
3114         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3115         (WebKit::NetscapePluginInstanceProxy::getCookies):
3116         (WebKit::NetscapePluginInstanceProxy::setCookies):
3117         * Plugins/WebNetscapePluginView.mm:
3118         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3119         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
3120
3121 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
3122
3123         Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
3124         https://bugs.webkit.org/show_bug.cgi?id=160923
3125
3126         Reviewed by Tim Horton.
3127
3128         * WebCoreSupport/WebFrameLoaderClient.h:
3129         * WebCoreSupport/WebFrameLoaderClient.mm:
3130         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
3131         (WebFrameLoaderClient::dispatchDidLayout): Deleted.
3132
3133 2016-08-18  Daniel Bates  <dabates@apple.com>
3134
3135         Ld warns of non-existent PrivateFrameworks directory when building WebKit with the public iOS 9.3 SDK
3136         https://bugs.webkit.org/show_bug.cgi?id=160979
3137
3138         Rubber-stamped by Simon Fraser.
3139
3140         Only add the SDK PrivateFrameworks directory to the FRAMEWORK_SEARCH_PATH when building for
3141         iOS Simulator, building with an iOS SDK that does not support text-based stubs, or building
3142         an Apple-internal build.
3143
3144         * Configurations/WebKitLegacy.xcconfig:
3145
3146 2016-08-18  Anders Carlsson  <andersca@apple.com>
3147
3148         Move an NPAPI-only function from WebCore to WebKit
3149         https://bugs.webkit.org/show_bug.cgi?id=160967
3150
3151         Reviewed by Sam Weinig.
3152
3153         * Plugins/WebNetscapePluginView.h:
3154         * Plugins/WebNetscapePluginView.mm:
3155         (-[WebNetscapePluginView getVariable:value:]):
3156         (-[WebNetscapePluginView _destroyPlugin]):
3157
3158 2016-08-18  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
3159
3160         [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
3161         https://bugs.webkit.org/show_bug.cgi?id=156096
3162
3163         Reviewed by Dean Jackson.
3164
3165         Adds:
3166         - Setup interface for enabling runtime flag for Web animations through preferences.
3167
3168         * WebView/WebPreferenceKeysPrivate.h:
3169         * WebView/WebPreferences.mm:
3170         (+[WebPreferences initialize]):
3171         (-[WebPreferences webAnimationsEnabled]):
3172         (-[WebPreferences setWebAnimationsEnabled:]):
3173         * WebView/WebPreferencesPrivate.h:
3174         * WebView/WebView.mm:
3175         (-[WebView _preferencesChanged:]):
3176
3177 2016-08-17  Anders Carlsson  <andersca@apple.com>
3178
3179         Remove a couple of unused WKSI function pointers
3180         https://bugs.webkit.org/show_bug.cgi?id=160946
3181
3182         Reviewed by Dan Bernstein.
3183
3184         * WebCoreSupport/WebSystemInterface.mm:
3185         (InitWebCoreSystemInterface): Deleted.
3186
3187 2016-08-16  Daniel Bates  <dabates@apple.com>
3188
3189         WKSI static library should be named by major iOS revision, not individual updates
3190         https://bugs.webkit.org/show_bug.cgi?id=160727
3191         <rdar://problem/22274848>
3192
3193         Reviewed by Alexey Proskuryakov.
3194
3195         * Configurations/Base.xcconfig:
3196         * Configurations/DebugRelease.xcconfig:
3197         * Configurations/WebKitLegacy.xcconfig:
3198
3199 2016-08-16  Darin Adler  <darin@apple.com>
3200
3201         [Cocoa] Remove dependency on Objective-C bindings in WebKit2 editing code
3202         https://bugs.webkit.org/show_bug.cgi?id=160891
3203
3204         Reviewed by Anders Carlsson.
3205
3206         * WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
3207
3208         * WebCoreSupport/WebEditorClient.mm:
3209         (attributesForAttributedStringConversion): Replaced the
3210         createExcludedElementsForAttributedStringConversion function with this one.
3211         No good reason to keep the array around instead of the dictionary.
3212         (_WebCreateFragment): Renamed from documentFragmentFromAttributedString.
3213         This is now a global function exported so it can be called by WebCore with
3214         a different way of returning its value.
3215
3216         * WebKit.exp: Added _WebCreateFragment.
3217
3218         * WebView/WebHTMLView.mm:
3219         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3220         Removed long-ago-obsolete workaround for Radar bug 5052369.
3221
3222 2016-08-15  Anders Carlsson  <andersca@apple.com>
3223
3224         Another build fix.
3225
3226         * WebKit.exp:
3227
3228 2016-08-15  Anders Carlsson  <andersca@apple.com>
3229
3230         Fix build.
3231
3232         * Configurations/WebKitLegacy.xcconfig:
3233         * WebKit.mac.exp:
3234
3235 2016-08-15  Anders Carlsson  <andersca@apple.com>
3236
3237         Remove OldWebAssertions.c
3238         https://bugs.webkit.org/show_bug.cgi?id=160862
3239
3240         Reviewed by Dan Bernstein.
3241
3242         These functions were used by an old version of iWeb. The latest version of iWeb no longer uses them.
3243
3244         * Misc/OldWebAssertions.c: Removed.
3245         (WebReportAssertionFailure): Deleted.
3246         (WebReportError): Deleted.
3247
3248 2016-08-15  Anders Carlsson  <andersca@apple.com>
3249
3250         Remove WebKeyGenerator
3251         https://bugs.webkit.org/show_bug.cgi?id=160854
3252
3253         Reviewed by Dan Bernstein.
3254
3255         This SPI class is no longer used by Safari.
3256
3257         * WebCoreSupport/WebKeyGenerator.h: Removed.
3258         * WebCoreSupport/WebKeyGenerator.mm: Removed.
3259         (+[WebKeyGenerator sharedGenerator]): Deleted.
3260         (toWebCertificateParseResult): Deleted.
3261         (-[WebKeyGenerator addCertificatesToKeychainFromData:]): Deleted.
3262         * WebView/WebFrameView.mm:
3263
3264 2016-08-15  Daniel Bates  <dabates@apple.com>
3265
3266         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
3267         private frameworks and libraries
3268         https://bugs.webkit.org/show_bug.cgi?id=155931
3269         <rdar://problem/25807989>
3270
3271         Reviewed by Dan Bernstein.
3272
3273         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
3274         where X is the major version of the active iOS SDK.
3275
3276         * Configurations/WebKitLegacy.xcconfig:
3277
3278 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
3279
3280         Add a setting and preferences to enable visual viewport mode
3281         https://bugs.webkit.org/show_bug.cgi?id=160843
3282
3283         Reviewed by Sam Weinig.
3284
3285         Hook up the visualViewportEnabled setting for WebKit1.
3286
3287         * WebView/WebPreferenceKeysPrivate.h:
3288         * WebView/WebPreferences.mm:
3289         (+[WebPreferences initialize]):
3290         (-[WebPreferences visualViewportEnabled]):
3291         (-[WebPreferences setVisualViewportEnabled:]):
3292         * WebView/WebPreferencesPrivate.h:
3293
3294 2016-08-15  Joseph Pecoraro  <pecoraro@apple.com>
3295
3296         Remove unused includes of wtf headers
3297         https://bugs.webkit.org/show_bug.cgi?id=160839
3298
3299         Reviewed by Alex Christensen.
3300
3301         * History/BinaryPropertyList.cpp:
3302         * History/WebBackForwardList.mm:
3303         * History/WebHistoryItemInternal.h:
3304         * Misc/WebNSFileManagerExtras.mm:
3305         * Plugins/Hosted/NetscapePluginHostProxy.h:
3306         * WebCoreSupport/WebPlatformStrategies.mm:
3307         * WebCoreSupport/WebSelectionServiceController.mm:
3308         * WebCoreSupport/WebUserMediaClient.h:
3309
3310 2016-08-12  Anders Carlsson  <andersca@apple.com>
3311
3312         Move the plug-in and WebGL blacklist code to WebCore
3313         https://bugs.webkit.org/show_bug.cgi?id=160831
3314
3315         Reviewed by Sam Weinig.
3316
3317         Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.
3318
3319         * WebCoreSupport/WebFrameLoaderClient.mm:
3320         (shouldBlockPlugin):
3321         (WebFrameLoaderClient::createPlugin):
3322         (WebFrameLoaderClient::createJavaAppletWidget):
3323         (shouldBlockWebGL):
3324         (WebFrameLoaderClient::webGLPolicyForURL):
3325         (WebFrameLoaderClient::resolveWebGLPolicyForURL):
3326
3327 2016-08-14  Daniel Bates  <dabates@apple.com>
3328
3329         Fix compiler errors when building iOS WebKit using the iOS 10 beta SDK
3330         https://bugs.webkit.org/show_bug.cgi?id=160725
3331
3332         Reviewed by Sam Weinig.
3333
3334         OSAtomicCompareAndSwap32() has been deprecated as of the iOS 10 beta SDK. For now,
3335         silence the complier warning.
3336
3337         * WebView/WebView.mm:
3338         (-[WebView _dispatchTileDidDraw:]):
3339
3340 2016-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3341
3342         Remove always true JSC::Debugger::needPauseHandling virtual method
3343         https://bugs.webkit.org/show_bug.cgi?id=160822
3344
3345         Reviewed by Mark Lam.
3346
3347         * WebView/WebScriptDebugger.h:
3348
3349 2016-08-11  Chris Dumez  <cdumez@apple.com>
3350
3351         Regression(r204268): Mail crashes when trying to compose an email
3352         https://bugs.webkit.org/show_bug.cgi?id=160775
3353
3354         Reviewed by Anders Carlsson.
3355
3356         Properly initialize PageConfiguration.pluginInfoProvider in
3357         [WebView initSimpleHTMLDocumentWithStyle] to avoid a null
3358         dereference in Mail when trying to compose an email.
3359
3360         * WebView/WebView.mm:
3361         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3362
3363 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3364
3365         Sort the feature flags in the FEATURE_DEFINES lines
3366         https://bugs.webkit.org/show_bug.cgi?id=160742
3367
3368         Reviewed by Anders Carlsson.
3369
3370         * Configurations/FeatureDefines.xcconfig:
3371
3372 2016-08-09  Alex Christensen  <achristensen@webkit.org>
3373
3374         Move NetworkStorageSession management to WebCore
3375         https://bugs.webkit.org/show_bug.cgi?id=160173
3376
3377         Reviewed by Brady Eidson.
3378
3379         * WebCoreSupport/WebFrameNetworkingContext.mm:
3380         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3381         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3382         * WebCoreSupport/WebPlatformStrategies.mm:
3383         * WebView/WebView.mm:
3384
3385 2016-08-09  Anders Carlsson  <andersca@apple.com>
3386
3387         Instantiate WebKit plug-ins at layout time, instead of at style resolution time
3388         https://bugs.webkit.org/show_bug.cgi?id=160715
3389
3390         Reviewed by Tim Horton.
3391
3392         * WebCoreSupport/WebFrameLoaderClient.mm:
3393         (WebFrameLoaderClient::objectContentType):
3394
3395 2016-08-09  George Ruan  <gruan@apple.com>
3396
3397         Implement functionality of media capture on iOS
3398         https://bugs.webkit.org/show_bug.cgi?id=158945
3399         <rdar://problem/26893343>
3400
3401         Reviewed by Tim Horton.
3402
3403         * Configurations/FeatureDefines.xcconfig: Enable Media Capture feature
3404         for iOS.
3405
3406 2016-08-09  Anders Carlsson  <andersca@apple.com>
3407
3408         Get rid of PluginStrategy
3409         https://bugs.webkit.org/show_bug.cgi?id=160696
3410
3411         Reviewed by Dan Bernstein.
3412
3413         * WebCoreSupport/WebPlatformStrategies.h:
3414         * WebCoreSupport/WebPlatformStrategies.mm:
3415         (WebPlatformStrategies::createPluginStrategy): Deleted.
3416         * WebCoreSupport/WebPluginInfoProvider.h:
3417         * WebCoreSupport/WebPluginInfoProvider.mm:
3418         (WebPluginInfoProvider::setPluginLoadClientPolicy): Deleted.
3419         (WebPluginInfoProvider::clearPluginClientPolicies): Deleted.
3420
3421 2016-08-09  Anders Carlsson  <andersca@apple.com>
3422
3423         Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
3424         https://bugs.webkit.org/show_bug.cgi?id=160694
3425
3426         Reviewed by Dan Bernstein.
3427
3428         * WebCoreSupport/WebPlatformStrategies.h:
3429         * WebCoreSupport/WebPlatformStrategies.mm:
3430         (WebPlatformStrategies::createPluginStrategy):
3431         (WebPlatformStrategies::refreshPlugins): Deleted.
3432         (WebPlatformStrategies::getPluginInfo): Deleted.
3433         (WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
3434         (WebPlatformStrategies::setPluginLoadClientPolicy): Deleted.
3435         (WebPlatformStrategies::clearPluginClientPolicies): Deleted.
3436         * WebCoreSupport/WebPluginInfoProvider.mm:
3437         (WebPluginInfoProvider::refreshPlugins):
3438         (WebPluginInfoProvider::getPluginInfo):
3439         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3440
3441 2016-08-08  Anders Carlsson  <andersca@apple.com>
3442
3443         Add a new PluginInfoProvider class, to replace PluginStrategy
3444         https://bugs.webkit.org/show_bug.cgi?id=160670
3445
3446         Reviewed by Sam Weinig.
3447
3448         Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
3449
3450         * WebCoreSupport/WebPluginInfoProvider.h: Added.
3451         * WebCoreSupport/WebPluginInfoProvider.mm: Added.
3452         (WebPluginInfoProvider::singleton):
3453         (WebPluginInfoProvider::WebPluginInfoProvider):
3454         (WebPluginInfoProvider::~WebPluginInfoProvider):
3455         (WebPluginInfoProvider::refreshPlugins):
3456         (WebPluginInfoProvider::getPluginInfo):
3457         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3458         (WebPluginInfoProvider::setPluginLoadClientPolicy):
3459         (WebPluginInfoProvider::clearPluginClientPolicies):
3460         * WebView/WebView.mm:
3461         (-[WebView _commonInitializationWithFrameName:groupName:]):
3462
3463 2016-08-02  Enrica Casucci  <enrica@apple.com>
3464
3465         Allow building with content filtering disabled.
3466         https://bugs.webkit.org/show_bug.cgi?id=160454
3467
3468         Reviewed by Simon Fraser.
3469
3470         * Configurations/FeatureDefines.xcconfig:
3471         * WebCoreSupport/WebFrameLoaderClient.h:
3472         * WebCoreSupport/WebFrameLoaderClient.mm:
3473         (WebFrameLoaderClient::blockedByContentFilterError):
3474
3475 2016-08-02  Anders Carlsson  <andersca@apple.com>
3476
3477         Remove more unused/uninstalled Objective-C DOM bindings
3478         https://bugs.webkit.org/show_bug.cgi?id=160464
3479
3480         Reviewed by Darin Adler.
3481
3482         Stop installing unused headers.
3483
3484         * MigrateHeaders.make:
3485
3486 2016-08-01  Anders Carlsson  <andersca@apple.com>
3487
3488         Bring back a file - it needs to be copied by WebCore.
3489
3490         * MigrateHeaders.make:
3491
3492 2016-08-01  Anders Carlsson  <andersca@apple.com>
3493
3494         Remove another file.
3495
3496         * MigrateHeaders.make:
3497
3498 2016-08-01  Anders Carlsson  <andersca@apple.com>
3499
3500         Remove a file.
3501
3502         * MigrateHeaders.make:
3503
3504 2016-08-01  Anders Carlsson  <andersca@apple.com>
3505
3506         Freeze all the DOMHTML* Objective-C bindings
3507         https://bugs.webkit.org/show_bug.cgi?id=160424
3508
3509         Reviewed by Tim Horton.
3510
3511         Don't migrate DOMHTMLEmbedElementPrivate.h - it was just an empty header.
3512
3513         * MigrateHeaders.make:
3514
3515 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
3516
3517         Remove deprecated SPI for video inline / fullscreen controls
3518         https://bugs.webkit.org/show_bug.cgi?id=160318
3519
3520         Reviewed by Tim Horton.
3521
3522         * WebView/WebPreferenceKeysPrivate.h:
3523         * WebView/WebPreferences.mm:
3524         (+[WebPreferences initialize]): Deleted.
3525         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]): Deleted.
3526         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]): Deleted.
3527         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]): Deleted.
3528         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]): Deleted.
3529         * WebView/WebPreferencesPrivate.h:
3530         * WebView/WebView.mm:
3531         (-[WebView _preferencesChanged:]): Deleted.
3532
3533 2016-07-28  Anders Carlsson  <andersca@apple.com>
3534
3535         Move a Mail.app workaround closer to where it's actually needed
3536         https://bugs.webkit.org/show_bug.cgi?id=160317
3537
3538         Reviewed by Tim Horton.
3539
3540         * WebCoreSupport/WebFrameLoaderClient.mm:
3541         (WebFrameLoaderClient::dispatchWillSendRequest):
3542         * WebView/WebFrame.mm:
3543         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Deleted.
3544
3545 2016-07-28  Anders Carlsson  <andersca@apple.com>
3546
3547         Use a RetainPtr in WebFrameLoaderClient::assignIdentifierToInitialRequest
3548         https://bugs.webkit.org/show_bug.cgi?id=160315
3549
3550         Reviewed by Tim Horton.
3551
3552         * WebCoreSupport/WebFrameLoaderClient.mm:
3553         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3554
3555 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
3556
3557         Fix the Windows debug build.
3558         
3559         WebResourceLoadScheduler's logging was a holdover from it being in WebCore,
3560         and prior to r203749 WebKit was actually using a WebCore log channel.
3561