dd6ef916c66bdb0b2d43a79a609e5da4a9c0a7ec
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-03-31  Timothy Horton  <timothy_horton@apple.com>
2
3         TextIndicator for <span> inside an <a> only highlights the <span>, should highlight the whole <a>
4         https://bugs.webkit.org/show_bug.cgi?id=143287
5         <rdar://problem/20318342>
6
7         Reviewed by Beth Dakin.
8
9         * WebView/WebImmediateActionController.mm:
10         (-[WebImmediateActionController _defaultAnimationController]):
11         Instead of just highlighting the hit element, highlight the whole
12         element that the link URL comes from.
13
14 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
15
16         Clean up Identifier factories to clarify the meaning of StringImpl*
17         https://bugs.webkit.org/show_bug.cgi?id=143146
18
19         Reviewed by Filip Pizlo.
20
21         Just change to Identifier::fromString.
22
23         * Plugins/Hosted/NetscapePluginHostProxy.mm:
24         (identifierFromIdentifierRep):
25         * Plugins/Hosted/ProxyInstance.mm:
26         (WebKit::ProxyInstance::getPropertyNames):
27
28 2015-03-28  Anders Carlsson  <andersca@apple.com>
29
30         Remove an unused SPI method from WebKitLegacy
31         https://bugs.webkit.org/show_bug.cgi?id=143185
32
33         Reviewed by Sam Weinig.
34
35         * WebView/WebDataSource.mm:
36         (-[WebDataSource _transferApplicationCache:]): Deleted.
37         * WebView/WebDataSourcePrivate.h:
38
39 2015-03-26  Alex Christensen  <achristensen@webkit.org>
40
41         Progress towards CMake on Mac.
42         https://bugs.webkit.org/show_bug.cgi?id=143112
43
44         Reviewed by Chris Dumez.
45
46         * WebCoreSupport/WebFrameLoaderClient.h:
47
48 2015-03-26  Ryosuke Niwa  <rniwa@webkit.org>
49
50         Cursor doesn't change back to pointer when leaving Mail
51         https://bugs.webkit.org/show_bug.cgi?id=132038
52
53         Reviewed by Anders Carlsson.
54
55         Fixed the bug by adding a cursor rect and making the primary tracking area update the cursor so that
56         AppKit will reset the cursor as it leaves the WebView.
57
58         We use nil cursor here since we manually update the cursor by calling [NSCursor set].
59
60         * WebView/WebHTMLView.mm:
61         (-[WebHTMLView setDataSource:]): Use NSTrackingCursorUpdate option in creating the primary tracking area.
62
63 2015-03-24  Anders Carlsson  <andersca@apple.com>
64
65         Fix designated initializer violations
66         https://bugs.webkit.org/show_bug.cgi?id=143016
67         rdar://problem/20268858
68
69         Reviewed by Dan Bernstein.
70
71         Move -[WebBackForwardList initWithBackForwardList:] to the implementation instead of a category since
72         nobody calls it outside of WebBackForwardList.mm.
73
74         * History/WebBackForwardList.mm:
75         * History/WebBackForwardListInternal.h:
76
77 2015-03-23  Alexey Proskuryakov  <ap@apple.com>
78
79         REGRESSION (Yosemite): WKView visibility notifications are messed up
80         https://bugs.webkit.org/show_bug.cgi?id=142945
81
82         Reviewed by Tim Horton.
83
84         As these notifications cannot be used by NSView subclasses, create a separate
85         object for observing them.
86
87         * WebView/WebView.mm:
88         (-[WebView _commonInitializationWithFrameName:groupName:]):
89         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
90         (-[WebView addWindowObserversForWindow:]):
91         (-[WebView removeWindowObservers]):
92         (-[WebView viewWillMoveToWindow:]): Make sure that observers are removed even
93         if -[WebView close] is called manually.
94         * WebView/WebViewData.h:
95         * WebView/WebViewData.mm:
96         (-[WebWindowVisibilityObserver initWithView:]):
97         (-[WebWindowVisibilityObserver startObserving:]):
98         (-[WebWindowVisibilityObserver stopObserving:]):
99         (-[WebWindowVisibilityObserver _windowVisibilityChanged:]):
100
101 2015-03-23  Tim Horton  <timothy_horton@apple.com>
102
103         Add a share item to the link action menu
104         https://bugs.webkit.org/show_bug.cgi?id=142961
105         <rdar://problem/19198374>
106
107         Reviewed by Beth Dakin.
108
109         * WebView/WebActionMenuController.mm:
110         (-[WebActionMenuController _defaultMenuItemsForImage]):
111         (-[WebActionMenuController _defaultMenuItemsForVideo]):
112         (-[WebActionMenuController _createActionMenuItemForTag:]):
113         (-[WebActionMenuController _createShareActionMenuItemForTag:withItems:]):
114         Adopt -[NSMenuItem standardShareMenuItemWithItems].
115         All of the null-checking is unnecessary as it's impossible to enter
116         these functions with a null image/etc.
117         Also, remove a duplicate isDownloadableMedia check for the 'save to downloads' item.
118
119         (-[WebActionMenuController _defaultMenuItemsForLink]):
120         * WebView/WebUIDelegatePrivate.h:
121         Add a 'Share' item to the link menu.
122
123 2015-03-22  Alexey Proskuryakov  <ap@apple.com>
124
125         Build fix.
126
127         * WebView/WebView.mm: (-[WebView _showPlaybackTargetPicker:hasVideo:]):
128
129 2015-03-22  Eric Carlson  <eric.carlson@apple.com>
130
131         [Mac] Enable WIRELESS_PLAYBACK_TARGET for WK1
132         https://bugs.webkit.org/show_bug.cgi?id=142940
133
134         Reviewed by Sam Weinig.
135
136         * WebCoreSupport/WebChromeClient.h:
137         * WebCoreSupport/WebChromeClient.mm:
138         (WebChromeClient::showPlaybackTargetPicker): New.
139         (WebChromeClient::startingMonitoringPlaybackTargets): New.
140         (WebChromeClient::stopMonitoringPlaybackTargets): New.
141
142         * WebView/WebView.mm:
143         (-[WebView _close]): Invalidate and free the target picker.
144         (-[WebView _devicePicker]): New.
145         (-[WebView _showPlaybackTargetPicker:hasVideo:]): New.
146         (-[WebView _startingMonitoringPlaybackTargets]): New.
147         (-[WebView _stopMonitoringPlaybackTargets]): New.
148
149         * WebView/WebMediaPlaybackTargetPicker.h:
150         * WebView/WebMediaPlaybackTargetPicker.mm:
151         (WebMediaPlaybackTargetPicker::create): New.
152         (WebMediaPlaybackTargetPicker::WebMediaPlaybackTargetPicker): New.
153         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): New.
154         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): New.
155         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): New.
156         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): New.
157         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange): New.
158         (WebMediaPlaybackTargetPicker::invalidate): New.
159         (WebMediaPlaybackTargetPicker::targetPicker): New.
160
161         * WebView/WebViewData.h:
162         (WebMediaPlaybackTargetPicker::~WebMediaPlaybackTargetPicker):
163         * WebView/WebViewData.mm:
164         * WebView/WebViewInternal.h:
165
166 2015-03-19  Andy Estes  <aestes@apple.com>
167
168         [Content Filtering] Add tests for unblock requests
169         https://bugs.webkit.org/show_bug.cgi?id=142900
170
171         Reviewed by Andreas Kling.
172
173         * WebCoreSupport/WebFrameLoaderClient.mm:
174         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): This now happens in PolicyChecker.
175         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
176         * WebView/WebFrame.mm:
177         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Deleted.
178         * WebView/WebFrameInternal.h: Removed contentFilterUnblockHandler from WebFramePrivate.
179
180 2015-03-19  Enrica Casucci  <enrica@apple.com>
181
182         <attachment> should put URLs on the pasteboard so that Finder can accept drops.
183         https://bugs.webkit.org/show_bug.cgi?id=142801
184         rdar://problem/19982527
185
186         Reviewed by Tim Horton.
187
188         This patch adds all the necessary support to write attachment elements into
189         the pasteboard, including the promised type in WK1.
190
191         * Misc/WebNSPasteboardExtras.mm:
192         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
193         * WebCoreSupport/WebDragClient.h:
194         * WebCoreSupport/WebDragClient.mm:
195         (WebDragClient::declareAndWriteAttachment):
196         * WebView/WebHTMLView.mm:
197         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
198         * WebView/WebUIDelegate.h:
199
200 2015-03-19  Chris Dumez  <cdumez@apple.com>
201
202         Clean up DOMTimer related settings
203         https://bugs.webkit.org/show_bug.cgi?id=142837
204
205         Reviewed by Darin Adler.
206
207         Stop setting the DOMTimers' default minimum interval to 4ms as this
208         is now the default.
209
210         * WebView/WebView.mm:
211         (-[WebView _commonInitializationWithFrameName:groupName:]):
212
213 2015-03-17  Conrad Shultz  <conrad_shultz@apple.com>
214
215         Ignore some deprecation warnings
216         https://bugs.webkit.org/show_bug.cgi?id=142813
217
218         Reviewed by Mark Rowe.
219
220         Fixing the deprecations is tracked by: <rdar://problem/20201450>
221
222         * WebCoreSupport/PopupMenuMac.mm:
223         (PopupMenuMac::populate):
224
225 2015-03-17  Tim Horton  <timothy_horton@apple.com>
226
227         Cannot invoke action menus anymore
228         https://bugs.webkit.org/show_bug.cgi?id=142797
229         <rdar://problem/20032670>
230
231         * WebView/WebHTMLView.mm:
232         (-[WebHTMLView otherMouseDown:]):
233         Need a respondsToSelector check.
234
235 2015-03-17  Tim Horton  <timothy_horton@apple.com>
236
237         Fix the iOS build
238
239         * WebView/WebHTMLView.mm:
240
241 2015-03-17  Tim Horton  <timothy_horton@apple.com>
242
243         Cannot invoke action menus anymore
244         https://bugs.webkit.org/show_bug.cgi?id=142797
245         <rdar://problem/20032670>
246
247         Reviewed by Beth Dakin.
248
249         * WebView/WebHTMLView.mm:
250         (-[WebHTMLView otherMouseDown:]):
251         Don't override otherMouseDown: if the event would make an action menu.
252
253 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
254
255         Enable ES6 classes by default
256         https://bugs.webkit.org/show_bug.cgi?id=142774
257
258         Reviewed by Gavin Barraclough.
259
260         * Configurations/FeatureDefines.xcconfig:
261
262 2015-03-16  Brent Fulgham  <bfulgham@apple.com>
263
264         WebKit1 Clients Are Not Reliably Repainted
265         https://bugs.webkit.org/show_bug.cgi?id=142750
266         <rdar://problem/20042453>
267
268         Reviewed by Simon Fraser.
269
270         Check with the FrameView to see if we are in an immediately paintable state. If we are not,
271         mark the view as dirty once the _immediateScrollToPoint operation is complete so that the
272         region will be painted properly.
273
274         * WebView/WebClipView.mm:
275         (-[WebClipView _immediateScrollToPoint:]): 
276
277 2015-03-16  Conrad Shultz  <conrad_shultz@apple.com>
278
279         Allow clients to selectively disable plug-ins
280         https://bugs.webkit.org/show_bug.cgi?id=142506
281
282         Reviewed by Anders Carlsson.
283
284         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
285         from the page). As part of this:
286
287         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
288            set of plug-ins.
289
290         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
291            down the stack.
292
293         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
294            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
295
296         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
297
298         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
299         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
300
301         * Plugins/WebBasePluginPackage.mm:
302         (-[WebBasePluginPackage getPluginInfoFromPLists]):
303         Set new members in PluginInfo.
304
305         * Plugins/WebNetscapePluginPackage.mm:
306         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
307         Set new members in PluginInfo.
308
309         * WebCoreSupport/WebPlatformStrategies.h:
310         * WebCoreSupport/WebPlatformStrategies.mm:
311         (WebPlatformStrategies::getWebVisiblePluginInfo):
312         Override to wrap getPluginInfo().
313         (WebPlatformStrategies::setPluginLoadClientPolicy):
314         Override to do nothing.
315         (WebPlatformStrategies::clearPluginClientPolicies):
316         Ditto.
317
318         * WebView/WebFrame.mm:
319         (-[WebFrame _canProvideDocumentSource]):
320         Update to reflect function rename.
321
322 2015-03-14  Dean Jackson  <dino@apple.com>
323
324         Feature flag for Animations Level 2
325         https://bugs.webkit.org/show_bug.cgi?id=142699
326         <rdar://problem/20165097>
327
328         Reviewed by Brent Fulgham.
329
330         Add ENABLE_CSS_ANIMATIONS_LEVEL_2 and a runtime flag animationTriggersEnabled.
331
332         * Configurations/FeatureDefines.xcconfig:
333
334 2015-03-13  Commit Queue  <commit-queue@webkit.org>
335
336         Unreviewed, rolling out r181483.
337         https://bugs.webkit.org/show_bug.cgi?id=142688
338
339         Caused use-after-free on many tests (Requested by ap on
340         #webkit).
341
342         Reverted changeset:
343
344         "Allow clients to selectively disable plug-ins"
345         https://bugs.webkit.org/show_bug.cgi?id=142506
346         http://trac.webkit.org/changeset/181483
347
348 2015-03-13  Eric Carlson  <eric.carlson@apple.com>
349
350         [Mac] Enable WIRELESS_PLAYBACK_TARGET
351         https://bugs.webkit.org/show_bug.cgi?id=142635
352
353         Reviewed by Darin Adler.
354
355         * Configurations/FeatureDefines.xcconfig:
356
357 2015-03-10  Conrad Shultz  <conrad_shultz@apple.com>
358
359         Allow clients to selectively disable plug-ins
360         https://bugs.webkit.org/show_bug.cgi?id=142506
361
362         Reviewed by Anders Carlsson.
363
364         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
365         from the page). As part of this:
366
367         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
368            set of plug-ins.
369
370         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
371            down the stack.
372
373         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
374            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
375
376         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
377
378         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
379         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
380
381         * Plugins/WebBasePluginPackage.mm:
382         (-[WebBasePluginPackage getPluginInfoFromPLists]):
383         Set new members in PluginInfo.
384
385         * Plugins/WebNetscapePluginPackage.mm:
386         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
387         Set new members in PluginInfo.
388
389         * WebCoreSupport/WebPlatformStrategies.h:
390         * WebCoreSupport/WebPlatformStrategies.mm:
391         (WebPlatformStrategies::getWebVisiblePluginInfo):
392         Override to wrap getPluginInfo().
393         (WebPlatformStrategies::setPluginLoadClientPolicy):
394         Override to do nothing.
395         (WebPlatformStrategies::clearPluginClientPolicies):
396         Ditto.
397
398         * WebView/WebFrame.mm:
399         (-[WebFrame _canProvideDocumentSource]):
400         Update to reflect function rename.
401
402 2015-03-10  Sam Weinig  <sam@webkit.org>
403
404         Allow adding a button in input elements for auto fill related functionality
405         <rdar://problem/19782066>
406         https://bugs.webkit.org/show_bug.cgi?id=142564
407
408         Reviewed by Anders Carlsson.
409
410         * DOM/WebDOMOperations.mm:
411         (-[DOMHTMLInputElement _setAutofilled:]):
412         Update for consistent spelling of AutoFill.
413
414 2015-03-10  Timothy Horton  <timothy_horton@apple.com>
415
416         Fix the build
417
418         * History/WebHistory.mm:
419         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
420         * WebCoreSupport/WebFrameLoaderClient.mm:
421         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
422
423 2015-03-10  Tim Horton  <timothy_horton@apple.com>
424
425         Fix the Mac build with a newer compiler
426
427         * Plugins/WebPluginController.mm:
428         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
429         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
430
431 2015-03-09  David Kilzer  <ddkilzer@apple.com>
432
433         [iOS] Fix build when compiling with dead code stripping disabled
434         <http://webkit.org/b/142467>
435
436         Reviewed by Simon Fraser.
437
438         * Configurations/WebKitLegacy.xcconfig:
439         (EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code
440         generation and compilation for out-of-process plugin support.
441         This was never used on iOS.
442
443 2015-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
444
445         [iOS] SVG fonts are garbled
446         https://bugs.webkit.org/show_bug.cgi?id=142377
447
448         Reviewed by Simon Fraser.
449
450         * Configurations/FeatureDefines.xcconfig:
451
452 2015-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
453
454         Hide Promise with runtime flags under Cocoa JSContext API
455         https://bugs.webkit.org/show_bug.cgi?id=141965
456
457         Reviewed by Filip Pizlo.
458
459         Add new JSC runtime flag, PromiseDisabled.
460
461         * WebView/WebPreferencesPrivate.h:
462
463 2015-03-03  Andy Estes  <aestes@apple.com>
464
465         [Content Filtering] Separate unblock handling into its own class
466         https://bugs.webkit.org/show_bug.cgi?id=142251
467
468         Reviewed by Andreas Kling.
469         
470         Adopted ContentFilterUnblockHandler.
471
472         * WebCoreSupport/WebFrameLoaderClient.h:
473         * WebCoreSupport/WebFrameLoaderClient.mm:
474         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
475         * WebView/WebFrame.mm:
476         (-[WebFrame _contentFilterDidHandleNavigationAction:]):
477         * WebView/WebFrameInternal.h:
478
479 2015-03-03  Chris Dumez  <cdumez@apple.com>
480
481         Access ApplicationCacheStorage global instance via singleton() static member function
482         https://bugs.webkit.org/show_bug.cgi?id=142239
483
484         Reviewed by Anders Carlsson.
485
486         Access ApplicationCacheStorage global instance via singleton() static
487         member function as per WebKit coding style.
488
489 2015-03-02  Jer Noble  <jer.noble@apple.com>
490
491         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
492         https://bugs.webkit.org/show_bug.cgi?id=142121
493
494         Reviewed by Simon Fraser.
495
496         Fullscreening a page with a non-1 scale would result in that scale being applied to the
497         fullscreen content, breaking fullscreen mode. Set the page scale to 1 when entering
498         fullscreen and reset it to the original value when exiting fullscreen.
499
500         * WebView/WebFullScreenController.h:
501         * WebView/WebFullScreenController.mm:
502         (-[WebFullScreenController enterFullScreen:]): Set the page scale to 1.
503         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Reset the page
504                 scale to the original value.
505         * WebView/WebView.mm:
506         (-[WebView _supportsFullScreenForElement:withKeyboard:]): Drive-by fix. Check the
507                 WebView's own preferences to see if fullscreen mode is enabled, rather than
508                 the global object's.
509
510 2015-03-01  Chris Dumez  <cdumez@apple.com>
511
512         Make NotificationCenter / Notification suspendable
513         https://bugs.webkit.org/show_bug.cgi?id=142117
514         <rdar://problem/19923085>
515
516         Reviewed by Andreas Kling.
517
518         Provide implementation for NotificationClient::hasPendingPermissionRequests().
519         The implementation is very simplistic. it will only return false if no
520         request for permission for ever made. This is because there is currently no
521         easy way to figure out if a permission request is pending or not.
522
523         * WebCoreSupport/WebNotificationClient.h:
524         * WebCoreSupport/WebNotificationClient.mm:
525         (WebNotificationClient::requestPermission):
526         (WebNotificationClient::hasPendingPermissionRequests):
527
528 2015-02-28  Simon Fraser  <simon.fraser@apple.com>
529
530         Viewport units should not dirty style just before we do layout
531         https://bugs.webkit.org/show_bug.cgi?id=141682
532
533         Reviewed by Zalan Bujtas.
534
535         * WebView/WebFrameView.mm:
536         (-[WebFrameView _frameSizeChanged]):
537
538 2015-02-26  Chris Dumez  <cdumez@apple.com>
539
540         Rename DatabaseManager::manager() to DatabaseManager::singleton()
541         https://bugs.webkit.org/show_bug.cgi?id=142054
542
543         Reviewed by Ryosuke Niwa.
544
545         Rename DatabaseManager::manager() to DatabaseManager::singleton() as
546         per coding style and use WTF::NeverDestroyed.
547
548         * Storage/WebDatabaseManager.mm:
549         (-[WebDatabaseManager init]):
550         (-[WebDatabaseManager origins]):
551         (-[WebDatabaseManager databasesWithOrigin:]):
552         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
553         (-[WebDatabaseManager deleteAllDatabases]):
554         (-[WebDatabaseManager deleteOrigin:]):
555         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
556         * Storage/WebDatabaseQuotaManager.mm:
557         (-[WebDatabaseQuotaManager usage]):
558         (-[WebDatabaseQuotaManager quota]):
559         (-[WebDatabaseQuotaManager setQuota:]):
560         * WebCoreSupport/WebSecurityOrigin.mm:
561         (-[WebSecurityOrigin usage]):
562         (-[WebSecurityOrigin quota]):
563         (-[WebSecurityOrigin setQuota:]):
564         * WebView/WebFrame.mm:
565         (-[WebFrame _cacheabilityDictionary]):
566         * WebView/WebView.mm:
567         (-[WebView _preferencesChanged:]):
568
569 2015-02-26  Myles C. Maxfield  <mmaxfield@apple.com>
570
571         [Mac] [iOS] Parsing support for -apple-trailing-word
572         https://bugs.webkit.org/show_bug.cgi?id=141939
573
574         Reviewed by Andreas Kling.
575
576         * Configurations/FeatureDefines.xcconfig:
577
578 2015-02-24  Commit Queue  <commit-queue@webkit.org>
579
580         Unreviewed, rolling out r180599.
581         https://bugs.webkit.org/show_bug.cgi?id=141998
582
583         Lots of new test failures (Requested by smfr on #webkit).
584
585         Reverted changeset:
586
587         "Parsing support for -webkit-trailing-word"
588         https://bugs.webkit.org/show_bug.cgi?id=141939
589         http://trac.webkit.org/changeset/180599
590
591 2015-02-24  Myles C. Maxfield  <mmaxfield@apple.com>
592
593         [Mac] [iOS] Parsing support for -apple-trailing-word
594         https://bugs.webkit.org/show_bug.cgi?id=141939
595
596         Reviewed by Andreas Kling.
597
598         * Configurations/FeatureDefines.xcconfig:
599
600 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
601
602         REGRESSION(r179429): Can't type comments in Facebook
603         https://bugs.webkit.org/show_bug.cgi?id=141859
604
605         Reviewed by Brent Fulgham.
606
607         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
608         Private API, javaScriptExperimentsEnabled is dropped.
609
610         * Misc/WebNSDictionaryExtras.h:
611         * Misc/WebNSDictionaryExtras.m:
612         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
613         * WebKit.order:
614         * WebView/WebPreferenceKeysPrivate.h:
615         * WebView/WebPreferences.mm:
616         (+[WebPreferences initialize]):
617         (-[WebPreferences _setUnsignedIntValue:forKey:]):
618         (-[WebPreferences javaScriptRuntimeFlags]):
619         (-[WebPreferences setJavaScriptRuntimeFlags:]):
620         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
621         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
622         * WebView/WebPreferencesPrivate.h:
623         * WebView/WebView.mm:
624         (-[WebView _preferencesChanged:]):
625
626 2015-02-23  Commit Queue  <commit-queue@webkit.org>
627
628         Unreviewed, rolling out r180547 and r180550.
629         https://bugs.webkit.org/show_bug.cgi?id=141957
630
631         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
632
633         Reverted changesets:
634
635         "REGRESSION(r179429): Can't type comments in Facebook"
636         https://bugs.webkit.org/show_bug.cgi?id=141859
637         http://trac.webkit.org/changeset/180547
638
639         "Constructor returning null should construct an object instead
640         of null"
641         https://bugs.webkit.org/show_bug.cgi?id=141640
642         http://trac.webkit.org/changeset/180550
643
644 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
645
646         Disable font loading events until our implementation gets updated to match the latest spec
647         https://bugs.webkit.org/show_bug.cgi?id=141938
648
649         Reviewed by Andreas Kling.
650
651         * Configurations/FeatureDefines.xcconfig:
652
653 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
654
655         REGRESSION(r179429): Can't type comments in Facebook
656         https://bugs.webkit.org/show_bug.cgi?id=141859
657
658         Reviewed by Geoffrey Garen.
659
660         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
661         Private API, javaScriptExperimentsEnabled is dropped.
662
663         * Misc/WebNSDictionaryExtras.h:
664         * Misc/WebNSDictionaryExtras.m:
665         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
666         * WebKit.order:
667         * WebView/WebPreferenceKeysPrivate.h:
668         * WebView/WebPreferences.mm:
669         (+[WebPreferences initialize]):
670         (-[WebPreferences _setUnsignedIntValue:forKey:]):
671         (-[WebPreferences javaScriptRuntimeFlags]):
672         (-[WebPreferences setJavaScriptRuntimeFlags:]):
673         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
674         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
675         * WebView/WebPreferencesPrivate.h:
676         * WebView/WebView.mm:
677         (-[WebView _preferencesChanged:]):
678
679 2015-02-20  Eric Carlson  <eric.carlson@apple.com>
680
681         [iOS] cleanup AirPlay code
682         https://bugs.webkit.org/show_bug.cgi?id=141811
683
684         Reviewed by Jer Noble.
685
686         * Configurations/FeatureDefines.xcconfig: IOS_AIRPLAY -> WIRELESS_PLAYBACK_TARGET.
687
688 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
689
690         Adopt WebCore::IOSurface in ImageBuffer
691         https://bugs.webkit.org/show_bug.cgi?id=141751
692
693         Reviewed by Simon Fraser.
694
695         * WebCoreSupport/WebSystemInterface.mm:
696         (InitWebCoreSystemInterface):
697         Remove old WKSI IOSurface-related functions.
698
699 2015-02-18  Commit Queue  <commit-queue@webkit.org>
700
701         Unreviewed, rolling out r180286.
702         https://bugs.webkit.org/show_bug.cgi?id=141766
703
704         Caused >50 crashed LayoutTests (Requested by jernoble on
705         #webkit).
706
707         Reverted changeset:
708
709         "Page::userContentController() should return a reference, not
710         a pointer"
711         https://bugs.webkit.org/show_bug.cgi?id=141764
712         http://trac.webkit.org/changeset/180286
713
714 2015-02-18  Brady Eidson  <beidson@apple.com>
715
716         Page::userContentController() should return a reference, not a pointer
717         https://bugs.webkit.org/show_bug.cgi?id=141764
718
719         Reviewed by Jer Noble.
720
721         * WebView/WebView.mm:
722         (-[WebView setGroupName:]):
723
724 2015-02-18  Chris Dumez  <cdumez@apple.com>
725
726         Access FontCache global instance via singleton() static member function
727         https://bugs.webkit.org/show_bug.cgi?id=141726
728
729         Reviewed by Daniel Bates.
730
731         Access FontCache global instance via singleton() static member function,
732         as per coding style.
733
734 2015-02-17  Chris Dumez  <cdumez@apple.com>
735
736         Access MemoryPressureHandler global instance via a singleton() static member function
737         https://bugs.webkit.org/show_bug.cgi?id=141691
738
739         Reviewed by Andreas Kling.
740
741         Access MemoryPressureHandler global instance via a singleton() static
742         member function.
743
744         * WebView/WebView.mm:
745         (-[WebView _commonInitializationWithFrameName:groupName:]):
746         (+[WebView registerForMemoryNotifications]):
747         (+[WebView _isUnderMemoryPressure]):
748         (+[WebView _clearMemoryPressure]):
749         (+[WebView _shouldWaitForMemoryClearMessage]):
750         (WebInstallMemoryPressureHandler):
751
752 2015-02-15  Sam Weinig  <sam@webkit.org>
753
754         Add experimental <attachment> element support
755         https://bugs.webkit.org/show_bug.cgi?id=141626
756
757         Reviewed by Tim Horton.
758
759         * Configurations/FeatureDefines.xcconfig:
760
761 2015-02-14  Joseph Pecoraro  <pecoraro@apple.com>
762
763         [Mac] Possible DDActionContext leaks, RetainPtr cleanup
764         https://bugs.webkit.org/show_bug.cgi?id=141613
765
766         Reviewed by Tim Horton.
767
768         * WebCoreSupport/WebEditorClient.mm:
769         (WebEditorClient::WebEditorClient):
770         Avoid unnecessary retain/autorelease by adopting.
771
772         * WebView/WebActionMenuController.mm:
773         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
774         Adopt the allocated object.
775
776 2015-02-09  Brian J. Burg  <burg@cs.washington.edu>
777
778         Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace
779         https://bugs.webkit.org/show_bug.cgi?id=141372
780
781         Reviewed by Joseph Pecoraro.
782
783         * WebCoreSupport/WebInspectorClient.mm:
784         (-[WebInspectorWindowController destroyInspectorView:]):
785
786 2015-02-14  Alexey Proskuryakov  <ap@apple.com>
787
788         rel="noreferrer" should make window.opener null
789         https://bugs.webkit.org/show_bug.cgi?id=141579
790
791         Reviewed by Darin Adler.
792
793         * WebView/WebPDFView.mm:
794         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore
795         function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
796
797 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
798
799         [Streams API] Implement a barebone ReadableStream interface
800         https://bugs.webkit.org/show_bug.cgi?id=141045
801
802         Reviewed by Benjamin Poulain.
803
804         * Configurations/FeatureDefines.xcconfig:
805
806 2015-02-03  Enrica Casucci  <enrica@apple.com>
807
808         [iOS] Add support for deleteFromInputWithFlags.
809         https://bugs.webkit.org/show_bug.cgi?id=141216
810         rdar://problem/19130081
811
812         Reviewed by Benjamin Poulain.
813
814         Adopts the new method as soon as it is available.
815         The patch also removes some obsolete code used for staging.
816
817         * WebView/WebHTMLView.mm:
818         (-[WebHTMLView _handleEditingKeyEvent:]):
819
820 2015-02-02  Chris Dumez  <cdumez@apple.com>
821
822         Access MemoryCache singleton using MemoryCache::singleton()
823         https://bugs.webkit.org/show_bug.cgi?id=141104
824
825         Reviewed by Andreas Kling.
826
827         Access MemoryCache singleton using MemoryCache::singleton() static
828         member function, instead of a free function, as per the recent
829         coding style discussion on WebKit-dev.
830
831 2015-02-01  Chris Dumez  <cdumez@apple.com>
832
833         Use more references in HistoryItem
834         https://bugs.webkit.org/show_bug.cgi?id=141133
835
836         Reviewed by Andreas Kling.
837
838         Use more references in HistoryItem instead of pointers.
839
840 2015-01-31  Sam Weinig  <sam@webkit.org>
841
842         Remove even more Mountain Lion support
843         https://bugs.webkit.org/show_bug.cgi?id=141124
844
845         Reviewed by Alexey Proskuryakov.
846
847         * Configurations/Base.xcconfig:
848         * Configurations/DebugRelease.xcconfig:
849         * Configurations/FeatureDefines.xcconfig:
850         * Configurations/Version.xcconfig:
851         * Configurations/WebKitLegacy.xcconfig:
852
853 2015-01-30  Eric Carlson  <eric.carlson@apple.com>
854
855         Remove MediaPlayerProxy.h
856         https://bugs.webkit.org/show_bug.cgi?id=141087
857
858         Reviewed by Sam Weinig.
859
860         * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h.
861         * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h.
862
863 2015-01-30  Chris Dumez  <cdumez@apple.com>
864
865         Rename shared() static member functions to singleton() for singleton classes.
866         https://bugs.webkit.org/show_bug.cgi?id=141088
867
868         Reviewed by Ryosuke Niwa and Benjamin Poulain.
869
870         Rename shared() static member functions to singleton() for singleton
871         classes as per the recent coding style change.
872
873 2015-01-29  Beth Dakin  <bdakin@apple.com>
874
875         Remove more Mountain Lion code from WebKit
876         https://bugs.webkit.org/show_bug.cgi?id=141050
877
878         Reviewed by Anders Carlsson.
879
880         * History/WebHistory.mm:
881         (getDayBoundaries):
882         * Panels/WebAuthenticationPanel.m:
883         (-[WebAuthenticationPanel cancel:]):
884         (-[WebAuthenticationPanel logIn:]):
885         (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]):
886         * WebCoreSupport/WebSystemInterface.mm:
887         (InitWebCoreSystemInterface):
888         * WebView/WebFrameView.mm:
889         * WebView/WebPreferences.mm:
890         (+[WebPreferences initialize]):
891         (needsScreenFontsEnabledQuirk):
892         * WebView/WebView.mm:
893         (+[WebView registerForMemoryNotifications]):
894         (-[WebView _preferencesChanged:]):
895         (+[WebView initialize]):
896         (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
897         (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
898         (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):
899
900 2015-01-29  Sam Weinig  <sam@webkit.org>
901
902         Remove support for screen font substitution
903         https://bugs.webkit.org/show_bug.cgi?id=141038
904
905         Reviewed by Tim Horton.
906
907         * Misc/WebKitNSStringExtras.mm:
908         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
909         (-[NSString _web_widthWithFont:]):
910         * Misc/WebStringTruncator.mm:
911         (fontFromNSFont):
912         Update for new signature of the FontPlatformData constructor, which no longer cares about
913         whether to use printer fonts.
914
915         * WebView/WebPreferenceKeysPrivate.h:
916         Remove the WebKitScreenFontSubstitutionEnabledKey key.
917
918         * WebView/WebPreferences.mm:
919         (+[WebPreferences initialize]):
920         Remove support for WebKitScreenFontSubstitutionEnabledKey.
921
922         (needsScreenFontsEnabledQuirk): Deleted.
923         Remove support for the Mountain Lion era 1-Password quirk.
924
925         (-[WebPreferences screenFontSubstitutionEnabled]): Deleted.
926         (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted.
927         * WebView/WebPreferencesPrivate.h:
928         * WebView/WebView.mm:
929         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
930         (-[WebView _preferencesChanged:]):
931         Remove support for the screen font substitution setting.
932
933 2015-01-29  Chris Dumez  <cdumez@apple.com>
934
935         Clean up / modernize PageCache class
936         https://bugs.webkit.org/show_bug.cgi?id=141009
937
938         Reviewed by Darin Adler.
939
940         Clean up / modernize PageCache class.
941
942         * History/WebBackForwardList.mm:
943         (-[WebBackForwardList pageCacheSize]):
944         * WebView/WebView.mm:
945         (-[WebView _loadBackForwardListFromOtherView:]):
946         (-[WebView goToBackForwardItem:]):
947         (+[WebView _setCacheModel:]):
948
949 2015-01-28  Beth Dakin  <bdakin@apple.com>
950
951         Remove Mountain Lion code from WebKit and WebKit2
952         https://bugs.webkit.org/show_bug.cgi?id=141010
953
954         Reviewed by Sam Weinig.
955
956         * DOM/WebDOMOperations.mm:
957         (toNSEventPhase):
958         * WebView/WebHTMLView.mm:
959         (isQuickLookEvent):
960
961 2015-01-28  Dana Burkart  <dburkart@apple.com>
962
963         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
964         https://bugs.webkit.org/show_bug.cgi?id=136765
965
966         Reviewed by Alexey Proskuryakov.
967
968         * Configurations/Base.xcconfig:
969         * Configurations/DebugRelease.xcconfig:
970
971 2015-01-28  Chris Dumez  <cdumez@apple.com>
972
973         Fix typo in markPagesForVistedLinkStyleRecalc()
974         https://bugs.webkit.org/show_bug.cgi?id=140977
975
976         Reviewed by Darin Adler.
977
978         * WebCoreSupport/WebVisitedLinkStore.mm:
979         (WebVisitedLinkStore::removeAllVisitedLinks):
980         (WebVisitedLinkStore::removeVisitedLink):
981         (WebVisitedLinkStore::addVisitedLinkHash):
982
983 2015-01-28  Chris Dumez  <cdumez@apple.com>
984
985         Rename pageCache() to PageCache::shared() and return a reference
986         https://bugs.webkit.org/show_bug.cgi?id=140983
987
988         Reviewed by Andreas Kling.
989
990         Rename pageCache() to PageCache::shared() as this is a singleton class
991         and have it return a reference instead of a pointer.
992
993         * History/WebBackForwardList.mm:
994         (-[WebBackForwardList pageCacheSize]):
995         * Misc/WebCoreStatistics.mm:
996         (+[WebCoreStatistics cachedPageCount]):
997         (+[WebCoreStatistics cachedFrameCount]):
998         * WebCoreSupport/WebVisitedLinkStore.mm:
999         (WebVisitedLinkStore::removeAllVisitedLinks):
1000         (WebVisitedLinkStore::removeVisitedLink):
1001         (WebVisitedLinkStore::addVisitedLinkHash):
1002         * WebView/WebView.mm:
1003         (+[WebView _setCacheModel:]):
1004
1005 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1006
1007         More build fixes for newer clang.
1008
1009         Rubber-stamped by Anders Carlsson.
1010
1011         Marked a deprecated accessibility method as such.
1012
1013         * WebView/WebFrame.mm:
1014         (-[WebFrame accessibilityRoot]):
1015
1016 2015-01-27  Beth Dakin  <bdakin@apple.com>
1017
1018         Immediate action gesture recognizer still doesn't work well with IB
1019         https://bugs.webkit.org/show_bug.cgi?id=140967
1020         -and corresponding-
1021         rdar://problem/19621509
1022
1023         Reviewed by Tim Horton.
1024
1025         We should add (or remove) the gesture recognizer in viewDidMoveToWindow because 
1026         initWithFrame it too early and IB might mess with it.
1027         * WebView/WebImmediateActionController.h:
1028         * WebView/WebImmediateActionController.mm:
1029         (-[WebImmediateActionController immediateActionRecognizer]):
1030         * WebView/WebView.mm:
1031         (-[WebView _commonInitializationWithFrameName:groupName:]):
1032         (-[WebView viewDidMoveToWindow]):
1033
1034 2015-01-27  Dan Bernstein  <mitz@apple.com>
1035
1036         Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
1037
1038         Rubber-stamped by Anders Carlsson.
1039
1040         * WebView/WebView.h: Added forward declarations of the protocols.
1041
1042 2015-01-26  Anders Carlsson  <andersca@apple.com>
1043
1044         Make it easy to test enabling formal delegate protocols
1045         https://bugs.webkit.org/show_bug.cgi?id=140892
1046
1047         Reviewed by Dan Bernstein.
1048
1049         Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
1050
1051         * Misc/WebDownload.h:
1052         * WebView/WebFrameLoadDelegate.h:
1053         * WebView/WebPolicyDelegate.h:
1054         * WebView/WebResourceLoadDelegate.h:
1055         * WebView/WebUIDelegate.h:
1056         * WebView/WebView.h:
1057
1058 2015-01-26  Chris Dumez  <cdumez@apple.com>
1059
1060         Rename Document::body() to Document::bodyOrFrameset() for clarity
1061         https://bugs.webkit.org/show_bug.cgi?id=140902
1062
1063         Reviewed by Andreas Kling.
1064
1065         Rename Document::body() to Document::bodyOrFrameset() for clarity. This
1066         method does not necessarily return an HTMLBodyElement, it can also
1067         return a frameset as per the specification:
1068         http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
1069
1070         This method is often misused internally (the caller is only interested
1071         in the <body> element). I will fix these instances in a follow-up patch,
1072         this patch is only renaming mechanically.
1073
1074 2015-01-26  Chris Dumez  <cdumez@apple.com>
1075
1076         First argument to DOM traversal functions should be a reference
1077         https://bugs.webkit.org/show_bug.cgi?id=140895
1078
1079         Reviewed by Antti Koivisto.
1080
1081         First argument to DOM traversal functions should be a reference instead
1082         of a pointer as it is dereferenced without null-check.
1083
1084 2015-01-26  Myles C. Maxfield  <mmaxfield@apple.com>
1085
1086         [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
1087         https://bugs.webkit.org/show_bug.cgi?id=140860
1088
1089         Reviewed by Darin Adler.
1090
1091         The fonts it makes are grotesque. (See what I did there? Typographic
1092         humor is the best humor.)
1093
1094         * Configurations/FeatureDefines.xcconfig:
1095
1096 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
1097
1098         QLPreviewMenuItem popovers don't close when the page scrolls
1099         https://bugs.webkit.org/show_bug.cgi?id=140806
1100         <rdar://problem/19555618>
1101
1102         Reviewed by Beth Dakin.
1103
1104         Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
1105
1106         * WebView/WebHTMLView.mm:
1107         (-[WebHTMLView scrollWheel:scrollWheel:]):
1108         Send scrollWheel along to WebImmediateActionController.
1109
1110         * WebView/WebImmediateActionController.h:
1111         * WebView/WebImmediateActionController.mm:
1112         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
1113         (-[WebImmediateActionController _clearImmediateActionState]):
1114         (-[WebImmediateActionController _defaultAnimationController]):
1115         Keep track of the active QLPreviewMenuItem, and close it upon scroll.
1116
1117 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
1118
1119         Infinite recursion in _clearImmediateActionState
1120         https://bugs.webkit.org/show_bug.cgi?id=140807
1121         <rdar://problem/19571601>
1122
1123         Reviewed by Anders Carlsson.
1124
1125         * WebView/WebImmediateActionController.mm:
1126         (-[WebImmediateActionController _clearImmediateActionState]):
1127         Use this opportunity to bring identical code to WebKit1, to avoid
1128         getting DataDetectors stuck when an immediate action is canceled.
1129
1130 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1131
1132         Add a build flag for ES6 class syntax
1133         https://bugs.webkit.org/show_bug.cgi?id=140760
1134
1135         Reviewed by Michael Saboff.
1136
1137         * Configurations/FeatureDefines.xcconfig:
1138
1139 2015-01-22  Beth Dakin  <bdakin@apple.com>
1140
1141         ibtoold crash below -[WebView close]
1142         https://bugs.webkit.org/show_bug.cgi?id=140782
1143         -and corresponding-
1144         rdar://problem/19558472
1145
1146         Reviewed by Tim Horton.
1147
1148         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
1149         it is because interface builder is messing with our views.
1150         * WebView/WebImmediateActionController.h:
1151         * WebView/WebImmediateActionController.mm:
1152         (-[WebImmediateActionController webViewClosed]):
1153         (-[WebImmediateActionController _cancelImmediateAction]):
1154         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1155         (-[WebImmediateActionController _updateImmediateActionItem]):
1156
1157 2015-01-21  Beth Dakin  <bdakin@apple.com>
1158
1159         Crash in QuickLook preview delegate method
1160         https://bugs.webkit.org/show_bug.cgi?id=140740
1161         -and corresponding-
1162         rdar://problem/19540806
1163
1164         Reviewed by Tim Horton.
1165
1166         Clear out the delegate.
1167         * WebView/WebImmediateActionController.mm:
1168         (-[WebImmediateActionController webViewClosed]):
1169
1170 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
1171
1172         Remove ENABLE(INSPECTOR) ifdef guards
1173         https://bugs.webkit.org/show_bug.cgi?id=140668
1174
1175         Reviewed by Darin Adler.
1176
1177         * Configurations/FeatureDefines.xcconfig:
1178         * WebCoreSupport/WebFrameLoaderClient.mm:
1179         (WebFrameLoaderClient::dispatchWillSendRequest):
1180
1181 2015-01-20  Anders Carlsson  <andersca@apple.com>
1182
1183         Remove USE(GLIB) code from WebKit1
1184         https://bugs.webkit.org/show_bug.cgi?id=140714
1185
1186         Reviewed by Andreas Kling.
1187
1188         * WebView/WebView.mm:
1189         (-[WebView _commonInitializationWithFrameName:groupName:]):
1190         (-[WebView _close]):
1191         (-[WebView _clearGlibLoopObserver]): Deleted.
1192         (glibContextIterationCallback): Deleted.
1193         (-[WebView _scheduleGlibContextIterations]): Deleted.
1194         * WebView/WebViewData.h:
1195         * WebView/WebViewInternal.h:
1196
1197 2015-01-20  David Kilzer  <ddkilzer@apple.com>
1198
1199         Switch to comparing PLATFORM_NAME in terms of macosx
1200         <http://webkit.org/b/139516>
1201
1202         Reviewed by Timothy Hatcher.
1203
1204         * MigrateHeaders.make:
1205         * postprocess-headers.sh:
1206
1207 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1208
1209         [SVG -> OTF Converter] Flip the switch on
1210         https://bugs.webkit.org/show_bug.cgi?id=140592
1211
1212         Reviewed by Antti Koivisto.
1213
1214         * Configurations/FeatureDefines.xcconfig:
1215
1216 2015-01-19  Beth Dakin  <bdakin@apple.com>
1217
1218         Speculative build fix.
1219
1220         * WebView/WebView.mm:
1221         (-[WebView _commonInitializationWithFrameName:groupName:]):
1222
1223 2015-01-19  Beth Dakin  <bdakin@apple.com>
1224
1225         Speculative build fix.
1226
1227         * WebView/WebView.mm:
1228         (-[WebView _convertRectFromRootView:]):
1229
1230 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
1231
1232         Adjust naming of action menu SPI
1233         https://bugs.webkit.org/show_bug.cgi?id=140644
1234         <rdar://problem/19448129>
1235
1236         Reviewed by Brian Weinstein.
1237
1238         * WebView/WebActionMenuController.mm:
1239         (-[WebActionMenuController prepareForMenu:withEvent:]):
1240         (-[WebActionMenuController willOpenMenu:withEvent:]):
1241         (-[WebActionMenuController didCloseMenu:withEvent:]):
1242         * WebView/WebView.mm:
1243         (-[WebView _commonInitializationWithFrameName:groupName:]):
1244         (-[WebView prepareForMenu:withEvent:]):
1245         (-[WebView willOpenMenu:withEvent:]):
1246         (-[WebView didCloseMenu:withEvent:]):
1247
1248 2015-01-19  Beth Dakin  <bdakin@apple.com>
1249
1250         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
1251         offset by flipped-ness
1252         https://bugs.webkit.org/show_bug.cgi?id=140643
1253         -and corresponding-
1254         rdar://problem/19489593
1255
1256         Reviewed by Tim Horton.
1257
1258         We universally flipped because we assumed that the root view was flipped and the 
1259         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
1260         fixes that assumption by checking the WebView’s flipped-ness.
1261         * WebView/WebView.mm:
1262         (-[WebView _convertRectFromRootView:]):
1263
1264 2015-01-19  Commit Queue  <commit-queue@webkit.org>
1265
1266         Unreviewed, rolling out r178653.
1267         https://bugs.webkit.org/show_bug.cgi?id=140634
1268
1269         Broke multiple SVG tests on Mountain Lion (Requested by ap on
1270         #webkit).
1271
1272         Reverted changeset:
1273
1274         "[SVG -> OTF Converter] Flip the switch on"
1275         https://bugs.webkit.org/show_bug.cgi?id=140592
1276         http://trac.webkit.org/changeset/178653
1277
1278 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1279
1280         [SVG -> OTF Converter] Flip the switch on
1281         https://bugs.webkit.org/show_bug.cgi?id=140592
1282
1283         Reviewed by Antti Koivisto.
1284
1285         * Configurations/FeatureDefines.xcconfig:
1286
1287 2015-01-18  Daniel Bates  <dabates@apple.com>
1288
1289         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
1290         (https://bugs.webkit.org/show_bug.cgi?id=129441)
1291
1292         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
1293         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
1294
1295         * WebInspector/WebNodeHighlightView.mm:
1296         (-[WebNodeHighlightView layoutSublayers:]):
1297
1298 2015-01-16  Beth Dakin  <bdakin@apple.com>
1299
1300         Make sure early cancellation of immediate action actually does that in WK1
1301         https://bugs.webkit.org/show_bug.cgi?id=140566
1302         -and corresponding-
1303         rdar://problem/19490114
1304
1305         Reviewed by Tim Horton.
1306
1307         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
1308         asynchronously.
1309         * WebView/WebImmediateActionController.mm:
1310         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1311
1312 2015-01-16  Daniel Bates  <dabates@apple.com>
1313
1314         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
1315         (https://bugs.webkit.org/show_bug.cgi?id=140360)
1316
1317         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
1318
1319         * Misc/WebDownload.h:
1320
1321 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
1322
1323         Remove ENABLE(SQL_DATABASE) guards
1324         https://bugs.webkit.org/show_bug.cgi?id=140434
1325
1326         Reviewed by Darin Adler.
1327
1328         * Configurations/FeatureDefines.xcconfig:
1329         * Storage/WebDatabaseManager.mm:
1330         (databasesDirectoryPath):
1331         * Storage/WebDatabaseManagerClient.h:
1332         * Storage/WebDatabaseManagerClient.mm:
1333         * Storage/WebDatabaseManagerInternal.h:
1334         * Storage/WebDatabaseManagerPrivate.h:
1335         * Storage/WebDatabaseQuotaManager.mm:
1336         (-[WebDatabaseQuotaManager usage]):
1337         (-[WebDatabaseQuotaManager quota]):
1338         (-[WebDatabaseQuotaManager setQuota:]):
1339         * WebCoreSupport/WebChromeClient.h:
1340         * WebCoreSupport/WebChromeClient.mm:
1341         * WebCoreSupport/WebSecurityOrigin.mm:
1342         (-[WebSecurityOrigin usage]):
1343         (-[WebSecurityOrigin quota]):
1344         (-[WebSecurityOrigin setQuota:]):
1345         * WebView/WebFrame.mm:
1346         (-[WebFrame _cacheabilityDictionary]):
1347         * WebView/WebView.mm:
1348         (-[WebView _commonInitializationWithFrameName:groupName:]):
1349         (-[WebView _preferencesChanged:]):
1350
1351 2015-01-14  Chris Dumez  <cdumez@apple.com>
1352
1353         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
1354         https://bugs.webkit.org/show_bug.cgi?id=140347
1355
1356         Reviewed by Darin Adler.
1357
1358         Call FontDescription::setIsItalic() instead of setItalic() as the
1359         call site passes a boolean.
1360
1361         * WebView/WebHTMLView.mm:
1362         (fontNameForDescription):
1363
1364 2015-01-13  Anders Carlsson  <andersca@apple.com>
1365
1366         Temporarily reintroduce the informal delegate protocols
1367         https://bugs.webkit.org/show_bug.cgi?id=140416
1368
1369         Reviewed by Dan Bernstein.
1370
1371         * WebView/WebEditingDelegate.h:
1372         * WebView/WebFrameLoadDelegate.h:
1373         * WebView/WebPolicyDelegate.h:
1374         * WebView/WebResourceLoadDelegate.h:
1375         * WebView/WebUIDelegate.h:
1376
1377 2015-01-13  Beth Dakin  <bdakin@apple.com>
1378
1379         Should disable immediate actions for iTunes
1380         https://bugs.webkit.org/show_bug.cgi?id=140405
1381         -and corresponding-
1382         rdar://problem/19461358
1383
1384         Reviewed by Tim Horton.
1385
1386         * WebView/WebImmediateActionController.mm:
1387         (-[WebImmediateActionController _updateImmediateActionItem]):
1388
1389 2015-01-11  Sam Weinig  <sam@webkit.org>
1390
1391         Remove support for SharedWorkers
1392         https://bugs.webkit.org/show_bug.cgi?id=140344
1393
1394         Reviewed by Anders Carlsson.
1395
1396         * Configurations/FeatureDefines.xcconfig:
1397         * WebCoreSupport/WebPlatformStrategies.h:
1398         * WebCoreSupport/WebPlatformStrategies.mm:
1399         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
1400
1401 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
1402
1403         Get rid of unnecessary reimplementations of CGFloor/Ceiling
1404         https://bugs.webkit.org/show_bug.cgi?id=140375
1405
1406         Reviewed by Simon Fraser.
1407
1408         * Misc/WebKitNSStringExtras.mm:
1409         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1410         (webkit_CGCeiling): Deleted.
1411         Delete unnecessary code, use the real CGFloor/Ceiling instead.
1412
1413 2015-01-12  Anders Carlsson  <andersca@apple.com>
1414
1415         Make delegates conform to formal delegate protocols
1416         https://bugs.webkit.org/show_bug.cgi?id=140370
1417
1418         Reviewed by Dan Bernstein.
1419
1420         * DefaultDelegates/WebDefaultPolicyDelegate.h:
1421         * WebCoreSupport/WebInspectorClient.mm:
1422         Add protocols to the interface declarations.
1423
1424         * WebView/WebActionMenuController.mm:
1425         (-[WebActionMenuController prepareForMenu:withEvent:]):
1426         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1427         * WebView/WebImmediateActionController.mm:
1428         (-[WebImmediateActionController _updateImmediateActionItem]):
1429         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1430         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
1431
1432 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
1433
1434         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
1435         https://bugs.webkit.org/show_bug.cgi?id=136769
1436
1437         Reviewed by Antti Koivisto.
1438
1439         * Configurations/FeatureDefines.xcconfig:
1440
1441 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
1442
1443         Multi-rect TextIndicators are vertically flipped in WebKit1
1444         https://bugs.webkit.org/show_bug.cgi?id=140350
1445         <rdar://problem/19441243>
1446
1447         Reviewed by Beth Dakin.
1448
1449         * WebView/WebView.mm:
1450         (-[WebView _setTextIndicator:fadeOut:]):
1451         Convert the textBoundingRect from root view to screen coordinates.
1452
1453 2015-01-12  Anders Carlsson  <andersca@apple.com>
1454
1455         Make WebResourceDelegate a formal protocol as well
1456         https://bugs.webkit.org/show_bug.cgi?id=140364
1457
1458         Reviewed by Dan Bernstein.
1459
1460         * WebView/WebResourceLoadDelegate.h:
1461
1462 2015-01-12  Anders Carlsson  <andersca@apple.com>
1463
1464         Delegates should be formal protocols
1465         https://bugs.webkit.org/show_bug.cgi?id=140360
1466         rdar://problem/17380856
1467
1468         Reviewed by Dan Bernstein.
1469
1470         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
1471
1472         * DefaultDelegates/WebDefaultUIDelegate.h:
1473         * Misc/WebDownload.h:
1474         * WebView/WebEditingDelegate.h:
1475         * WebView/WebFrameLoadDelegate.h:
1476         * WebView/WebPolicyDelegate.h:
1477         * WebView/WebUIDelegate.h:
1478
1479 2015-01-09  Anders Carlsson  <andersca@apple.com>
1480
1481         Get rid of the database strategy
1482         https://bugs.webkit.org/show_bug.cgi?id=140322
1483
1484         Reviewed by Sam Weinig.
1485
1486         * WebCoreSupport/WebPlatformStrategies.h:
1487         * WebCoreSupport/WebPlatformStrategies.mm:
1488         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
1489
1490 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
1491
1492         Can't use DataDetectors after immediate action preparation
1493         https://bugs.webkit.org/show_bug.cgi?id=140263
1494         <rdar://problem/19412705>
1495
1496         Reviewed by Beth Dakin.
1497
1498         * WebView/WebImmediateActionController.mm:
1499         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1500         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1501         To match WebKit2, only call shouldUseActions if the animation is actually
1502         going to begin, not when preparing for it. This way, we're guaranteed
1503         to get a didCancel or didComplete.
1504
1505 2015-01-08  Dean Jackson  <dino@apple.com>
1506
1507         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
1508         https://bugs.webkit.org/show_bug.cgi?id=140232
1509         <rdar://problem/19371010>
1510
1511         Reviewed by Anders Carlsson.
1512
1513         Remove the applicationChromeMode setting, but leave stubs in to make
1514         sure existing binaries don't break.
1515
1516         * WebCoreSupport/WebInspectorClient.mm:
1517         (-[WebInspectorWindowController init]):
1518         * WebView/WebPreferenceKeysPrivate.h:
1519         * WebView/WebPreferences.mm:
1520         (+[WebPreferences initialize]):
1521         (-[WebPreferences applicationChromeModeEnabled]):
1522         (-[WebPreferences setApplicationChromeModeEnabled:]):
1523         * WebView/WebView.mm:
1524         (-[WebView _preferencesChanged:]):
1525
1526 2015-01-07  Daniel Bates  <dabates@apple.com>
1527
1528         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1529         https://bugs.webkit.org/show_bug.cgi?id=137371
1530
1531         Reviewed by David Kilzer.
1532
1533         Use SPI wrapper headers instead of directly references private SPI headers.
1534
1535         * Plugins/Hosted/NetscapePluginHostManager.mm:
1536
1537 2015-01-07  Commit Queue  <commit-queue@webkit.org>
1538
1539         Unreviewed, rolling out r178068.
1540         https://bugs.webkit.org/show_bug.cgi?id=140235
1541
1542         Breaks the iOS build (Requested by enrica on #webkit).
1543
1544         Reverted changeset:
1545
1546         "[iOS] Make WebKit2 build with public iOS SDK and more build
1547         fixes for DRT"
1548         https://bugs.webkit.org/show_bug.cgi?id=137371
1549         http://trac.webkit.org/changeset/178068
1550
1551 2015-01-07  Daniel Bates  <dabates@apple.com>
1552
1553         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1554         https://bugs.webkit.org/show_bug.cgi?id=137371
1555
1556         Reviewed by David Kilzer.
1557
1558         Use SPI wrapper headers instead of directly references private SPI headers.
1559
1560         * Plugins/Hosted/NetscapePluginHostManager.mm:
1561
1562 2015-01-07  Beth Dakin  <bdakin@apple.com>
1563
1564         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
1565         link
1566         https://bugs.webkit.org/show_bug.cgi?id=140206
1567         -and corresponding-
1568         rdar://problem/19300492
1569
1570         Reviewed by Tim Horton.
1571
1572         Providing and item frame will ensure that the original link is not obscured.
1573         * WebView/WebImmediateActionController.mm:
1574         (elementBoundingBoxInWindowCoordinatesFromNode):
1575         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
1576
1577         For now use a max size that is smaller than the WebView, with the screen’s aspect 
1578         ratio, and scaled down.
1579         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
1580
1581 2015-01-07  Anders Carlsson  <andersca@apple.com>
1582
1583         Give simple HTML documents a database provider
1584         https://bugs.webkit.org/show_bug.cgi?id=140192
1585         rdar://problem/19398825
1586
1587         Reviewed by Tim Horton.
1588
1589         * WebView/WebView.mm:
1590         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1591
1592 2015-01-06  Anders Carlsson  <andersca@apple.com>
1593
1594         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
1595         https://bugs.webkit.org/show_bug.cgi?id=140140
1596
1597         Reviewed by Andreas Kling.
1598
1599         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
1600         out of WebCore since nobody else is using it.
1601
1602         * Plugins/WebNetscapePluginView.h:
1603         * Plugins/WebNetscapePluginView.mm:
1604         (-[WebNetscapePluginView _createPlugin]):
1605         (-[WebNetscapePluginView _destroyPlugin]):
1606         * Plugins/npapi.mm:
1607         (NPN_PluginThreadAsyncCall):
1608
1609 2015-01-06  Anders Carlsson  <andersca@apple.com>
1610
1611         Add a WebKit1 database provider
1612         https://bugs.webkit.org/show_bug.cgi?id=140126
1613
1614         Reviewed by Sam Weinig.
1615
1616         Set the database provider.
1617
1618         * WebView/WebView.mm:
1619         (-[WebView _commonInitializationWithFrameName:groupName:]):
1620
1621 2015-01-06  Commit Queue  <commit-queue@webkit.org>
1622
1623         Unreviewed, rolling out r177963.
1624         https://bugs.webkit.org/show_bug.cgi?id=140136
1625
1626         Caused lots of crashes (Requested by smfr on #webkit).
1627
1628         Reverted changeset:
1629
1630         "Add a WebKit1 database provider"
1631         https://bugs.webkit.org/show_bug.cgi?id=140126
1632         http://trac.webkit.org/changeset/177963
1633
1634 2015-01-06  Anders Carlsson  <andersca@apple.com>
1635
1636         Add a WebKit1 database provider
1637         https://bugs.webkit.org/show_bug.cgi?id=140126
1638
1639         Reviewed by Sam Weinig.
1640
1641         Set the database provider.
1642
1643         * WebView/WebView.mm:
1644         (-[WebView _commonInitializationWithFrameName:groupName:]):
1645
1646 2015-01-01  Jeff Miller  <jeffm@apple.com>
1647
1648         Update user-visible copyright strings to include 2015
1649         https://bugs.webkit.org/show_bug.cgi?id=139880
1650
1651         Reviewed by Darin Adler.
1652
1653         * Info.plist:
1654
1655 2014-12-30  Dan Bernstein  <mitz@apple.com>
1656
1657         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
1658         https://bugs.webkit.org/show_bug.cgi?id=140003
1659
1660         Reviewed by Darin Adler.
1661
1662         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
1663         that takes their "string" parameter as a "value" "parameter and has an attribute telling
1664         the compiler that if the "value" parameter is a format string then the function returns a
1665         modified version of it. The result is that if UI_STRING is used as a format string parameter
1666         to some function or method, the compiler will check the format specifiers in the string
1667         against the other parameters.
1668
1669 2014-12-29  Dan Bernstein  <mitz@apple.com>
1670
1671         Fixed the iOS build.
1672
1673         * Configurations/WebKitLegacy.xcconfig:
1674
1675 2014-12-29  Anders Carlsson  <andersca@apple.com>
1676
1677         Get rid of some PageGroup storage functions
1678         https://bugs.webkit.org/show_bug.cgi?id=139996
1679
1680         Reviewed by Sam Weinig.
1681
1682         Call WebStorageNamespaceProvider directly instead.
1683
1684         * Storage/WebStorageManager.mm:
1685         (-[WebStorageManager syncLocalStorage]):
1686         (+[WebStorageManager closeIdleLocalStorageDatabases]):
1687         * WebView/WebView.mm:
1688         (+[WebView _applicationWillTerminate]):
1689
1690 2014-12-29  Anders Carlsson  <andersca@apple.com>
1691
1692         Move storage code from WebCore to WebKit
1693         https://bugs.webkit.org/show_bug.cgi?id=139558
1694
1695         Reviewed by Darin Adler.
1696
1697         * Storage/WebStorageManager.mm:
1698         * Storage/WebStorageTrackerClient.h:
1699         * WebView/WebView.mm:
1700
1701 2014-12-26  Dan Bernstein  <mitz@apple.com>
1702
1703         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
1704         https://bugs.webkit.org/show_bug.cgi?id=139950
1705
1706         Reviewed by David Kilzer.
1707
1708         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
1709         in a manner that works with Xcode 5.1.1.
1710
1711 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
1712
1713         Install a TextIndicator for link immediate actions
1714         https://bugs.webkit.org/show_bug.cgi?id=139897
1715         <rdar://problem/19333076>
1716
1717         Reviewed by Anders Carlsson.
1718
1719         * WebView/WebImmediateActionController.h:
1720         * WebView/WebImmediateActionController.mm:
1721         (-[WebImmediateActionController _clearImmediateActionState]):
1722         Tear down the TextIndicator, just like WebKit2.
1723
1724         (-[WebImmediateActionController _defaultAnimationController]):
1725         Install a TextIndicator for links.
1726
1727         (-[WebImmediateActionController menuItemDidClose:]):
1728         Tear down the TextIndicator when the QL preview closes.
1729
1730         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1731         Directly install and uninstall the TextIndicator for DataDetectors.
1732
1733         (-[WebImmediateActionController _showTextIndicator]): Deleted.
1734         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
1735         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
1736
1737 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
1738
1739         [iOS] add optimized fullscreen API
1740         https://bugs.webkit.org/show_bug.cgi?id=139833
1741         <rdar://problem/18844486>
1742
1743         Reviewed by Simon Fraser.
1744
1745         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
1746
1747 2014-12-20  David Kilzer  <ddkilzer@apple.com>
1748
1749         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
1750         <http://webkit.org/b/139463>
1751
1752         Reviewed by Mark Rowe.
1753
1754         * Configurations/Base.xcconfig:
1755         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
1756           on OS X.
1757         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
1758         * Configurations/DebugRelease.xcconfig:
1759         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
1760         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
1761         * Configurations/Version.xcconfig:
1762         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
1763         * Configurations/WebKitLegacy.xcconfig:
1764         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
1765           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
1766           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
1767           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
1768           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
1769           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
1770           WEBCORE_PRIVATE_HEADERS_DIR_Production and
1771           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
1772           based on SDK.
1773         - Fix PRODUCTION_ROOT to actually be set properly.
1774         - Simplify EXPORTED_SYMBOLS_FILE_i386.
1775
1776         * migrate-headers.sh:
1777         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
1778         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
1779           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
1780           WebKitLegacy.xcconfig.
1781
1782 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
1783
1784         Fix pink background on CoreAnimation plug-ins in WebKit1
1785         https://bugs.webkit.org/show_bug.cgi?id=139845
1786         rdar://problem/19313075
1787
1788         Reviewed by Tim Horton.
1789         
1790         r154078 left in some debugging code that set a pink background on plug-in hosting
1791         layers. Remove it.
1792
1793         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1794         (-[WebHostedNetscapePluginView createPluginLayer]):
1795
1796 2014-12-19  Andreas Kling  <akling@apple.com>
1797
1798         Ref-ify TextIterator API.
1799         <https://webkit.org/b/139823>
1800
1801         Reviewed by Antti Koivisto.
1802
1803         * WebView/WebTextIterator.mm:
1804         (-[WebTextIterator currentRange]):
1805
1806 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
1807
1808         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
1809         https://bugs.webkit.org/show_bug.cgi?id=139797
1810
1811         Reviewed by Mark Lam.
1812
1813         * WebView/WebScriptDebugger.h:
1814         * WebView/WebScriptDebugger.mm:
1815         (WebScriptDebugger::handlePause):
1816         Standardize on passing JSGlobalObject parameter first.
1817
1818 2014-12-19  Commit Queue  <commit-queue@webkit.org>
1819
1820         Unreviewed, rolling out r177574.
1821         https://bugs.webkit.org/show_bug.cgi?id=139821
1822
1823         "Broke Production builds by installing
1824         libWebCoreTestSupport.dylib in the wrong directory" (Requested
1825         by ddkilzer on #webkit).
1826
1827         Reverted changeset:
1828
1829         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
1830         WebInspectorUI, WebKit, WebKit2"
1831         https://bugs.webkit.org/show_bug.cgi?id=139463
1832         http://trac.webkit.org/changeset/177574
1833
1834 2014-12-19  David Kilzer  <ddkilzer@apple.com>
1835
1836         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
1837         <http://webkit.org/b/139463>
1838
1839         Reviewed by Mark Rowe.
1840
1841         * Configurations/Base.xcconfig:
1842         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
1843           on OS X.
1844         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
1845         * Configurations/DebugRelease.xcconfig:
1846         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
1847         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
1848         * Configurations/Version.xcconfig:
1849         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
1850         * Configurations/WebKitLegacy.xcconfig:
1851         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
1852           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
1853           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
1854           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
1855           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
1856           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
1857           WEBCORE_PRIVATE_HEADERS_DIR_Production and
1858           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
1859           based on SDK.
1860         - Fix PRODUCTION_ROOT to actually be set properly.
1861         - Simplify EXPORTED_SYMBOLS_FILE_i386.
1862
1863         * migrate-headers.sh:
1864         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
1865         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
1866           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
1867           WebKitLegacy.xcconfig.
1868
1869 2014-12-18  Andreas Kling  <akling@apple.com>
1870
1871         Ref-ify various Document-related things.
1872         <https://webkit.org/b/139796>
1873
1874         Reviewed by Anders Carlsson.
1875
1876         * WebView/WebFrame.mm:
1877         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
1878
1879 2014-12-18  Beth Dakin  <bdakin@apple.com>
1880
1881         Need to re-enable action menus
1882         https://bugs.webkit.org/show_bug.cgi?id=139795
1883         -and corresponding-
1884         rdar://problem/19299367
1885
1886         Reviewed by Tim Horton.
1887
1888         Re-enable the menus by un-commenting the code to create the menu and controller.
1889         * WebView/WebView.mm:
1890         (-[WebView _commonInitializationWithFrameName:groupName:]):
1891
1892 2014-12-16  Sam Weinig  <sam@webkit.org>
1893
1894         Unify the Mac and iOS implementations of FontPlatformData a bit
1895         https://bugs.webkit.org/show_bug.cgi?id=139721
1896
1897         Reviewed by Anders Carlsson.
1898
1899         * WebView/WebHTMLView.mm:
1900         (fontNameForDescription):
1901         Update for new function name.
1902
1903 2014-12-18  Antti Koivisto  <antti@apple.com>
1904
1905         Remove alwaysUseBaselineOfPrimaryFont setting
1906         https://bugs.webkit.org/show_bug.cgi?id=139770
1907
1908         Reviewed by Anders Carlsson.
1909
1910         * WebView/WebPreferenceKeysPrivate.h:
1911         * WebView/WebPreferences.mm:
1912         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
1913         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
1914         * WebView/WebPreferencesPrivate.h:
1915         * WebView/WebView.mm:
1916         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1917         (-[WebView _preferencesChanged:]):
1918
1919 2014-12-17  Andreas Kling  <akling@apple.com>
1920
1921         Ref-ify Range::create().
1922         <https://webkit.org/b/139755>
1923
1924         Reviewed by Anders Carlsson.
1925
1926         * WebView/WebHTMLRepresentation.mm:
1927         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1928         * WebView/WebHTMLView.mm:
1929         (-[WebHTMLView attributedString]):
1930
1931 2014-12-17  Anders Carlsson  <andersca@apple.com>
1932
1933         Unify -[WebResource description]
1934         https://bugs.webkit.org/show_bug.cgi?id=139762
1935
1936         Reviewed by Dan Bernstein.
1937
1938         * WebView/WebResource.mm:
1939         (-[WebResource description]):
1940
1941 2014-12-17  Anders Carlsson  <andersca@apple.com>
1942
1943         Get rid of an ugly #define hack in WebFrameLoaderClient
1944         https://bugs.webkit.org/show_bug.cgi?id=139761
1945
1946         Reviewed by Dan Bernstein.
1947
1948         Also replace @private with @package in all public headers, for consistency.
1949
1950         * History/WebBackForwardList.h:
1951         * History/WebHistory.h:
1952         * Misc/WebDownload.h:
1953         * WebCoreSupport/WebFrameLoaderClient.mm:
1954         * WebView/WebArchive.h:
1955         * WebView/WebDataSource.h:
1956         * WebView/WebFrame.h:
1957         * WebView/WebFrameView.h:
1958         * WebView/WebPreferences.h:
1959         * WebView/WebResource.h:
1960
1961 2014-12-17  Dan Bernstein  <mitz@apple.com>
1962
1963         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
1964         https://bugs.webkit.org/show_bug.cgi?id=139760
1965
1966         Reviewed by Anders Carlsson.
1967
1968         * Configurations/WebKitLegacy.xcconfig:
1969
1970 2014-12-17  Andreas Kling  <akling@apple.com>
1971
1972         Purge PassRefPtr from Frame.
1973         <https://webkit.org/b/139731>
1974
1975         Reviewed by Anders Carlsson.
1976
1977         * WebCoreSupport/WebFrameLoaderClient.mm:
1978         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1979         * WebView/WebFrame.mm:
1980         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1981         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
1982         * WebView/WebFrameInternal.h:
1983
1984 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
1985
1986         Implement and adopt two new TextIndicator presentation animations
1987         https://bugs.webkit.org/show_bug.cgi?id=139715
1988         <rdar://problem/19237945>
1989
1990         Reviewed by Anders Carlsson.
1991
1992         * WebView/WebActionMenuController.mm:
1993         (-[WebActionMenuController _showTextIndicator]):
1994         * WebView/WebHTMLView.mm:
1995         (-[WebHTMLView quickLookWithEvent:]):
1996         Remove the completionHandler from text indicator presentation.
1997
1998         * WebView/WebImmediateActionController.mm:
1999         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2000         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
2001         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2002         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2003         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2004         (-[WebImmediateActionController _animationControllerForText]):
2005         (-[WebImmediateActionController _showTextIndicator]):
2006         Forward immediate action gesture recognizer animation progress
2007         to TextIndicator. Force us to keep the selection when immediate
2008         action popovers steal first responder status from the WebView.
2009         If the Lookup range is equal to the selection range, use a Crossfade
2010         animation; otherwise, use a FadeIn animation.
2011
2012         * WebView/WebView.mm:
2013         (-[WebView _setMaintainsInactiveSelection:]):
2014         (-[WebView maintainsInactiveSelection]):
2015         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2016         (-[WebView _setTextIndicator:fadeOut:]):
2017         (-[WebView _clearTextIndicator]):
2018         (-[WebView _setTextIndicatorAnimationProgress:]):
2019         (-[WebView _showDictionaryLookupPopup:]):
2020         (-[WebView _dictionaryLookupPopoverWillClose:]):
2021         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2022         Remove the completionHandler from text indicator presentation.
2023         Add a _setMaintainsInactiveSelection, which allows WebKit internals
2024         to change the return value of -maintainsInactiveSelection, allowing
2025         us to keep the selection alive when the WebView loses first responder status.
2026
2027         * WebView/WebViewData.h:
2028         * WebView/WebViewInternal.h:
2029
2030 2014-12-16  Andreas Kling  <akling@apple.com>
2031
2032         Use Ref for SecurityOrigin.
2033         <https://webkit.org/b/139710>
2034
2035         Reviewed by Anders Carlsson.
2036
2037         * Storage/WebStorageTrackerClient.mm:
2038         (WebStorageTrackerClient::dispatchDidModifyOrigin):
2039         * WebView/WebView.mm:
2040         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
2041         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
2042
2043 2014-12-16  Beth Dakin  <bdakin@apple.com>
2044
2045         Crash getting default animation controller for some text
2046         https://bugs.webkit.org/show_bug.cgi?id=139712
2047         -and corresponding-
2048         rdar://problem/19271707
2049
2050         Reviewed by Tim Horton.
2051
2052         Must null-check the range.
2053         * WebView/WebImmediateActionController.mm:
2054         (-[WebImmediateActionController _animationControllerForText]):
2055
2056 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
2057
2058         Immediate action popovers can get stuck open
2059         https://bugs.webkit.org/show_bug.cgi?id=139709
2060         <rdar://problem/19270279>
2061
2062         Reviewed by Beth Dakin.
2063
2064         * WebView/WebImmediateActionController.mm:
2065         (-[WebImmediateActionController _clearImmediateActionState]):
2066         Don't clear the animation controller; it breaks things and was unnecessary.
2067
2068 2014-12-16  Tim Horton  <timothy_horton@apple.com>
2069
2070         Disable TextIndication for Lookup immediate actions
2071         https://bugs.webkit.org/show_bug.cgi?id=139684
2072
2073         Reviewed by Anders Carlsson.
2074
2075         * WebView/WebView.mm:
2076         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2077
2078 2014-12-15  Beth Dakin  <bdakin@apple.com>
2079
2080         Build fix.
2081
2082         * WebView/WebImmediateActionController.mm:
2083
2084 2014-12-15  Beth Dakin  <bdakin@apple.com>
2085
2086         Speculative build fix.
2087
2088         * WebView/WebView.mm:
2089         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2090         * WebView/WebViewInternal.h:
2091
2092 2014-12-15  Beth Dakin  <bdakin@apple.com>
2093
2094         Make lookup an immediate action instead of an action menu item
2095         https://bugs.webkit.org/show_bug.cgi?id=139661
2096         -and corresponding-
2097         rdar://problem/19198414
2098
2099         Reviewed by Tim Horton.
2100
2101         Remove the lookup menu items and non-unused static function associated with 
2102         lookup.
2103         * WebView/WebActionMenuController.mm:
2104         (-[WebActionMenuController _defaultMenuItemsForText]):
2105         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2106         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2107         (-[WebActionMenuController _createActionMenuItemForTag:]):
2108         (-[WebActionMenuController _lookupText:]): Deleted.
2109         (performDictionaryLookupForSelection): Deleted.
2110         (performDictionaryLookupForRange): Deleted.
2111
2112         Set the defaultAnimationController to the lookup-provided animation controller 
2113         when appropriate.
2114         * WebView/WebImmediateActionController.mm:
2115         (-[WebImmediateActionController _defaultAnimationController]):
2116         (dictionaryPopupInfoForRange):
2117         (-[WebImmediateActionController _animationControllerForText]):
2118
2119         New type.
2120         * WebView/WebUIDelegatePrivate.h:
2121
2122         New function to get the lookup animation controller.
2123         * WebView/WebView.mm:
2124         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2125         * WebView/WebViewInternal.h:
2126
2127 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2128
2129         Implement Data Detectors immediate actions for Legacy WebKit
2130         https://bugs.webkit.org/show_bug.cgi?id=139619
2131         <rdar://problem/19198539>
2132
2133         Reviewed by Beth Dakin.
2134
2135         * WebView/WebImmediateActionController.mm:
2136         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2137         Note that this action context is only for immediate actions.
2138
2139 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
2140
2141         Addressing post-review comments in r177035
2142         https://bugs.webkit.org/show_bug.cgi?id=139557
2143
2144         Reviewed by Darin Adler.
2145
2146         * WebView/WebActionMenuController.mm:
2147         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
2148
2149 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2150
2151         Implement Data Detectors immediate actions for Legacy WebKit
2152         https://bugs.webkit.org/show_bug.cgi?id=139619
2153         <rdar://problem/19198539>
2154
2155         Reviewed by Eric Carlson.
2156
2157         * WebView/WebHTMLView.mm:
2158         (-[WebHTMLView mouseDown:mouseDown:]):
2159         Send mouseDown along to the WebImmediateActionController too.
2160
2161         * WebView/WebImmediateActionController.h:
2162         * WebView/WebImmediateActionController.mm:
2163         (-[WebImmediateActionController webViewClosed]):
2164         (-[WebImmediateActionController webView:willHandleMouseDown:]):
2165         (-[WebImmediateActionController _cancelImmediateAction]):
2166         (-[WebImmediateActionController _clearImmediateActionState]):
2167         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2168         (-[WebImmediateActionController _defaultAnimationController]):
2169         (-[WebImmediateActionController _updateImmediateActionItem]):
2170         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2171         (-[WebImmediateActionController _showTextIndicator]):
2172         (-[WebImmediateActionController _hideTextIndicator]):
2173         Copy most of the DataDetectors implementation into WebImmediateActionController.
2174
2175         * WebView/WebUIDelegatePrivate.h:
2176         Add a new type.
2177
2178         * WebView/WebView.mm:
2179         (-[WebView _commonInitializationWithFrameName:groupName:]):
2180         Temporarily disable action menus.
2181
2182         (-[WebView _immediateActionController]):
2183         * WebView/WebViewInternal.h:
2184
2185 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
2186
2187         Delete Notation because we don't use it
2188         https://bugs.webkit.org/show_bug.cgi?id=139171
2189
2190         Reviewed by Kent Tamura.
2191
2192         * MigrateHeaders.make:
2193
2194 2014-12-14  Andreas Kling  <akling@apple.com>
2195
2196         Replace PassRef with Ref/Ref&& across the board.
2197         <https://webkit.org/b/139587>
2198
2199         Reviewed by Darin Adler.
2200
2201         * WebCoreSupport/WebEditorClient.mm:
2202         (WebEditorClient::shouldApplyStyle):
2203         * WebCoreSupport/WebVisitedLinkStore.h:
2204         * WebCoreSupport/WebVisitedLinkStore.mm:
2205         (WebVisitedLinkStore::create):
2206
2207 2014-12-11  Dan Bernstein  <mitz@apple.com>
2208
2209         Fix a leak introduced in r177199.
2210
2211         Reviewed by Anders Carlsson.
2212
2213         * WebView/WebImmediateActionController.mm:
2214         (-[WebImmediateActionController _updateImmediateActionItem]):
2215
2216 2014-12-11  Beth Dakin  <bdakin@apple.com>
2217
2218         WK1: Need new SPI for Webkit clients to override default immediate action
2219         https://bugs.webkit.org/show_bug.cgi?id=139568
2220         -and corresponding-
2221         rdar://problem/19225448
2222
2223         Reviewed by Dan Bernstein.
2224
2225         Call SPI giving clients a chance to override the default behavior.
2226         * WebView/WebImmediateActionController.mm:
2227         (-[WebImmediateActionController _updateImmediateActionItem]):
2228
2229         New SPI.
2230         * WebView/WebUIDelegatePrivate.h:
2231
2232 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
2233
2234         Move the preview popover to WebImmediateActionController
2235         https://bugs.webkit.org/show_bug.cgi?id=139563
2236         <rdar://problem/19208291>
2237
2238         Reviewed by Beth Dakin.
2239
2240         * WebView/WebActionMenuController.mm:
2241         (-[WebActionMenuController _defaultMenuItemsForLink]):
2242         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
2243         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
2244         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
2245         * WebView/WebImmediateActionController.h:
2246         * WebView/WebImmediateActionController.mm:
2247         (-[WebImmediateActionController webViewClosed]):
2248         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2249         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2250         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2251         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2252         (-[WebImmediateActionController _updateImmediateActionItem]):
2253         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
2254         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
2255         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
2256         Move page preview popover related code to WebImmediateActionController.
2257
2258         * WebView/WebUIDelegatePrivate.h:
2259         Add a link preview type.
2260
2261         * WebView/WebView.mm:
2262         (-[WebView _commonInitializationWithFrameName:groupName:]):
2263         Pass the gesture recognizer to the WebImmediateActionController.
2264
2265 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
2266
2267         Fix the build.
2268
2269         * WebView/WebImmediateActionController.h:
2270         * WebView/WebImmediateActionController.mm:
2271
2272 2014-12-11  Anders Carlsson  <andersca@apple.com>
2273
2274         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
2275         https://bugs.webkit.org/show_bug.cgi?id=139547
2276
2277         Reviewed by Sam Weinig.
2278
2279         * WebView/WebView.mm:
2280         (+[WebView _handleMemoryWarning]):
2281
2282 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
2283
2284         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
2285         https://bugs.webkit.org/show_bug.cgi?id=139504
2286         rdar://problem/19034674
2287
2288         Reviewed by Enrica Casucci.
2289
2290         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
2291
2292         * WebCoreSupport/WebEditorClient.h:
2293         * WebCoreSupport/WebEditorClient.mm:
2294         (WebEditorClient::discardedComposition):
2295
2296 2014-12-10  Anders Carlsson  <andersca@apple.com>
2297
2298         Get rid of the storage strategy
2299         https://bugs.webkit.org/show_bug.cgi?id=139519
2300
2301         Reviewed by Antti Koivisto.
2302
2303         * WebCoreSupport/WebPlatformStrategies.h:
2304         * WebCoreSupport/WebPlatformStrategies.mm:
2305         (WebPlatformStrategies::createStorageStrategy): Deleted.
2306
2307 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2308
2309         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
2310         https://bugs.webkit.org/show_bug.cgi?id=139529
2311         <rdar://problem/19213620>
2312
2313         Reviewed by Beth Dakin.
2314
2315         * WebView/WebActionMenuController.mm:
2316         (-[WebActionMenuController _copySelection:]):
2317         (-[WebActionMenuController _paste:]):
2318         Use the copy: and paste: methods on WebView so that we traverse subviews
2319         when trying to respond, otherwise these actions don't work in subframes.
2320
2321 2014-12-10  Beth Dakin  <bdakin@apple.com>
2322
2323         WK1: Add initial support for immediate actions
2324         https://bugs.webkit.org/show_bug.cgi?id=139522
2325
2326         Reviewed by Dan Bernstein.
2327
2328         This basic implementation of the controller will use the delegate methods to 
2329         perform and cache a HitTest when relevant. Future patches will patch 
2330         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
2331         immediate action that should be taken.
2332         * WebView/WebImmediateActionController.h: Added.
2333         * WebView/WebImmediateActionController.mm: Added.
2334         (-[WebImmediateActionController webViewClosed]):
2335         (-[WebImmediateActionController _clearImmediateActionState]):
2336         (-[WebImmediateActionController performHitTestAtPoint:]):
2337         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2338         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2339         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2340         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2341         (-[WebImmediateActionController _updateImmediateActionItem]):
2342
2343         New enum for immediate action types.
2344         * WebView/WebUIDelegatePrivate.h:
2345
2346         Create an NSImmediateActionGestureRecognizer if possible and a controller.
2347         * WebView/WebView.mm:
2348         (-[WebView _commonInitializationWithFrameName:groupName:]):
2349         (-[WebView _close]):
2350         * WebView/WebViewData.h:
2351         * WebView/WebViewData.mm:
2352         (-[WebViewPrivate dealloc]):
2353
2354 2014-12-08  Anders Carlsson  <andersca@apple.com>
2355
2356         Use the new storage namespace provider in WebKit1
2357         https://bugs.webkit.org/show_bug.cgi?id=139425
2358
2359         Reviewed by Tim Horton.
2360
2361         * WebView/WebView.mm:
2362         (-[WebView _commonInitializationWithFrameName:groupName:]):
2363         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2364         Set the storage namespace provider from the web page group.
2365
2366 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2367
2368         Should have copy and paste items in all text menus
2369         https://bugs.webkit.org/show_bug.cgi?id=139510
2370         <rdar://problem/19198388>
2371
2372         Reviewed by Beth Dakin.
2373
2374         * WebView/WebActionMenuController.mm:
2375         (-[WebActionMenuController _defaultMenuItemsForText]):
2376         Add a disabled paste menu item into the read-only text menu.
2377
2378         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2379         Add a disabled copy menu item into the editable whitespace text menu.
2380
2381 2014-12-10  Anders Carlsson  <andersca@apple.com>
2382
2383         Add WebStorageNamespaceProvider::closeLocalStorage
2384         https://bugs.webkit.org/show_bug.cgi?id=139502
2385
2386         Reviewed by Tim Horton.
2387
2388         * WebView/WebView.mm:
2389         (+[WebView _applicationWillTerminate]):
2390         Call WebStorageNamespaceProvider::closeLocalStorage.
2391
2392 2014-12-09  Commit Queue  <commit-queue@webkit.org>
2393
2394         Unreviewed, rolling out r177037.
2395         https://bugs.webkit.org/show_bug.cgi?id=139464
2396
2397         broke ~50 API tests (Requested by thorton on #webkit).
2398
2399         Reverted changeset:
2400
2401         "Use the new storage namespace provider in WebKit1"
2402         https://bugs.webkit.org/show_bug.cgi?id=139425
2403         http://trac.webkit.org/changeset/177037
2404
2405 2014-12-08  Anders Carlsson  <andersca@apple.com>
2406
2407         Use the new storage namespace provider in WebKit1
2408         https://bugs.webkit.org/show_bug.cgi?id=139425
2409
2410         Reviewed by Tim Horton.
2411
2412         * WebView/WebView.mm:
2413         (-[WebView _commonInitializationWithFrameName:groupName:]):
2414         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2415         Set the storage namespace provider from the web page group.
2416
2417 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
2418
2419         Delete Node::boundingBox()
2420         https://bugs.webkit.org/show_bug.cgi?id=139333
2421
2422         Reviewed by Zalan Bujtas.
2423
2424         * WebView/WebActionMenuController.mm:
2425         (elementBoundingBoxInWindowCoordinatesFromNode): Use
2426         RenderObject::absoluteBoundingBoxRect().
2427
2428 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
2429
2430         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
2431         https://bugs.webkit.org/show_bug.cgi?id=138843
2432         rdar://problem/18793695
2433
2434         Reviewed by Dan Bernstein.
2435
2436         * Panels/WebAuthenticationPanel.m:
2437         (-[WebAuthenticationPanel cancel:]):
2438         (-[WebAuthenticationPanel logIn:]):
2439         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
2440         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
2441         that only when using an old NSWindow API.
2442
2443 2014-12-08  Beth Dakin  <bdakin@apple.com>
2444
2445         Copy and Lookup menu items should be disabled when something is not copyable
2446         https://bugs.webkit.org/show_bug.cgi?id=139423
2447
2448         Reviewed by Tim Horton.
2449
2450         Disable both lookup and copy when a HitTestResult does not allow copy.
2451         * WebView/WebActionMenuController.mm:
2452
2453         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
2454         disable state otherwise.
2455         * WebView/WebView.mm:
2456         (-[WebView _commonInitializationWithFrameName:groupName:]):
2457
2458 2014-12-08  Anders Carlsson  <andersca@apple.com>
2459
2460         Adding user content to a group should force that group to be created
2461         https://bugs.webkit.org/show_bug.cgi?id=139421
2462         rdar://problem/19180108
2463
2464         Reviewed by Sam Weinig.
2465
2466         * WebCoreSupport/WebViewGroup.h:
2467         Store the local storage database path in the group.
2468
2469         * WebCoreSupport/WebViewGroup.mm:
2470         (WebViewGroup::getOrCreate):
2471         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
2472         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
2473
2474         (WebViewGroup::WebViewGroup):
2475         Initialize the new member variable.
2476
2477         (WebViewGroup::storageNamespaceProvider):
2478         Create the namespace provider lazily.
2479
2480         * WebView/WebView.mm:
2481         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
2482         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
2483         Use getOrCreate instead of get.
2484
2485 2014-12-08  Anders Carlsson  <andersca@apple.com>
2486
2487         WebStorageNamespaceProvider should know about its local storage database path
2488         https://bugs.webkit.org/show_bug.cgi?id=139413
2489
2490         Reviewed by Andreas Kling.
2491
2492         * WebCoreSupport/WebViewGroup.h:
2493         * WebCoreSupport/WebViewGroup.mm:
2494         (WebViewGroup::getOrCreate):
2495         (WebViewGroup::WebViewGroup):
2496         * WebView/WebView.mm:
2497         (-[WebView _commonInitializationWithFrameName:groupName:]):
2498         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2499         (-[WebView setGroupName:]):
2500         (-[WebView groupName]): Deleted.
2501
2502 2014-12-08  Daniel Bates  <dabates@apple.com>
2503
2504         [iOS] Fix the WebKit build with the public SDK
2505
2506         Include header NSURLDownloadSPI.h.
2507
2508         * WebCoreSupport/WebFrameLoaderClient.mm:
2509
2510 2014-12-07  Dan Bernstein  <mitz@apple.com>
2511
2512         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
2513         https://bugs.webkit.org/show_bug.cgi?id=139348
2514
2515         Reviewed by Anders Carlsson.
2516
2517         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
2518         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
2519         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
2520         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
2521         avoiding the ambiguity.
2522
2523         * WebView/WebActionMenuController.mm:
2524         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2525
2526 2014-12-06  Anders Carlsson  <andersca@apple.com>
2527
2528         Add a stubbed out version of WebStorageNamespaceProvider
2529         https://bugs.webkit.org/show_bug.cgi?id=139213
2530
2531         Reviewed by Sam Weinig.
2532
2533         * WebCoreSupport/WebViewGroup.h:
2534         (WebViewGroup::storageNamespaceProvider):
2535         * WebCoreSupport/WebViewGroup.mm:
2536         (WebViewGroup::getOrCreate):
2537         (WebViewGroup::WebViewGroup):
2538         Give WebViewGroup a storage namespace provider.
2539
2540 2014-12-06  Anders Carlsson  <andersca@apple.com>
2541
2542         Fix build with newer versions of clang.
2543         rdar://problem/18978687
2544
2545         Add missing overrides and missing casts.
2546
2547         * Storage/WebDatabaseManagerClient.h:
2548         * Storage/WebStorageTrackerClient.h:
2549         * WebCoreSupport/WebChromeClient.h:
2550         * WebCoreSupport/WebFrameLoaderClient.h:
2551         * WebCoreSupport/WebInspectorClient.h:
2552         * WebView/WebDataSource.mm:
2553         (-[WebDataSource _makeRepresentation]):
2554         * WebView/WebFrameView.mm:
2555         (-[WebFrameView _makeDocumentViewForDataSource:]):
2556
2557 2014-12-05  Tim Horton  <timothy_horton@apple.com>
2558
2559         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
2560         https://bugs.webkit.org/show_bug.cgi?id=139306
2561         <rdar://problem/19157955>
2562
2563         Reviewed by Beth Dakin.
2564
2565         * WebView/WebView.mm:
2566         (-[WebView _commonInitializationWithFrameName:groupName:]):
2567         (-[WebView _initWithFrame:frameName:groupName:]):
2568         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
2569
2570 2014-12-05  David Kilzer  <ddkilzer@apple.com>
2571
2572         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
2573         <http://webkit.org/b/139286>
2574
2575         Reviewed by Daniel Bates.
2576
2577         * Configurations/FeatureDefines.xcconfig: Switch back to using
2578         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
2579
2580 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
2581
2582         Fix the 32-bit build.
2583
2584         * WebView/WebView.mm:
2585         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2586
2587 2014-12-04  Tim Horton  <timothy_horton@apple.com>
2588
2589         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
2590         https://bugs.webkit.org/show_bug.cgi?id=139252
2591         <rdar://problem/19140827>
2592
2593         Reviewed by Anders Carlsson.
2594
2595         * WebView/WebView.mm:
2596         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2597         Adjust to the WebCore changes.
2598
2599 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
2600
2601         Implement action menus for tel: URLs
2602         https://bugs.webkit.org/show_bug.cgi?id=139240
2603         <rdar://problem/19115662>
2604
2605         Reviewed by Anders Carlsson.
2606
2607         * WebView/WebActionMenuController.mm:
2608         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2609         Make sure to use the newly created currentActionContext... everywhere.
2610
2611 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
2612
2613         Implement action menus for tel: URLs
2614         https://bugs.webkit.org/show_bug.cgi?id=139240
2615         <rdar://problem/19115662>
2616
2617         Reviewed by Anders Carlsson.
2618
2619         * WebView/WebActionMenuController.mm:
2620         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2621         Make sure to use the newly created currentActionContext.
2622
2623 2014-12-03  Beth Dakin  <bdakin@apple.com>
2624
2625         <input> elements get whitespace action menu instead of editable text menu
2626         https://bugs.webkit.org/show_bug.cgi?id=139241
2627         -and corresponding-
2628         rdar://problem/19072083
2629
2630         Reviewed by Sam Weinig.
2631
2632         We should disallow shadow content in the hit test. This is the default and it is 
2633         how context menus behave. We originally wanted to text inside shadow content so 
2634         that we could find the text, but the new function I added to HitTestResult will 
2635         allow that.
2636         * WebView/WebActionMenuController.mm:
2637         (-[WebActionMenuController performHitTestAtPoint:]):
2638
2639         Adjust to the fact that we don’t hit test shadow content any more.
2640         (-[WebActionMenuController focusAndSelectHitTestResult]):
2641
2642         Offer the text menus for text inside form controls.
2643         (-[WebActionMenuController _defaultMenuItems]):
2644
2645 2014-12-03  Tim Horton  <timothy_horton@apple.com>
2646
2647         Implement action menus for tel: URLs
2648         https://bugs.webkit.org/show_bug.cgi?id=139240
2649         <rdar://problem/19115662>
2650
2651         Reviewed by Anders Carlsson.
2652
2653         * WebView/WebActionMenuController.mm:
2654         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2655         Rename this function as it will work for both mailto and tel URLs.
2656         Adjust it to use contextForView:.
2657
2658         (-[WebActionMenuController webView:willHandleMouseDown:]):
2659         (-[WebActionMenuController prepareForMenu:withEvent:]):
2660         (-[WebActionMenuController didCloseMenu:withEvent:]):
2661         (-[WebActionMenuController _defaultMenuItems]):
2662         Don't check the menu type when going to interact with _currentActionContext.
2663         We'll only have a _currentActionContext if we have a data detected item,
2664         and there are multiple menu types that end up using DDActionContext.
2665
2666         * WebView/WebUIDelegatePrivate.h:
2667         Add a new type.
2668
2669 2014-12-03  Anders Carlsson  <andersca@apple.com>
2670
2671         Set a visited link store when creating a simple WebView
2672         https://bugs.webkit.org/show_bug.cgi?id=139234
2673         <rdar://problem/19132978>
2674
2675         Reviewed by Sam Weinig.
2676
2677         * WebView/WebView.mm:
2678         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2679
2680 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
2681
2682         Fix the build.
2683
2684         * WebCoreSupport/WebFrameLoaderClient.mm:
2685
2686 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
2687
2688         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
2689         https://bugs.webkit.org/show_bug.cgi?id=139149
2690
2691         Reviewed by Anders Carlsson.
2692
2693         This changes API behavior. I think that it's OK, because existing behavior made no sense.
2694         We used to delete caches from disk, but they were still active in memory. Now we also
2695         obsolete them in memory, so documents that use a cache still work, but new ones don't
2696         pick one up.
2697
2698         * WebCoreSupport/WebApplicationCache.mm:
2699         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
2700         need to delete in-momry caches too. Keep existing behavior.
2701         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
2702         that properly deletes caches.
2703
2704 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2705
2706         Remove a SnowLeopard-era quirk for QuickLook
2707         https://bugs.webkit.org/show_bug.cgi?id=139208
2708         <rdar://problem/19121822>
2709
2710         Reviewed by Alexey Proskuryakov.
2711
2712         * WebCoreSupport/WebFrameLoaderClient.h:
2713         * WebCoreSupport/WebFrameLoaderClient.mm:
2714
2715 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2716
2717         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
2718         https://bugs.webkit.org/show_bug.cgi?id=139204
2719
2720         Reviewed by Anders Carlsson.
2721
2722         * WebView/WebView.mm:
2723         (-[WebView _commonInitializationWithFrameName:groupName:]):
2724         (-[WebView _showDictionaryLookupPopup:]):
2725         * WebView/WebViewData.h:
2726         Work around this by delaying the softlinking (and setting up the notification
2727         observer) until we actually need it. There's still an underlying bug, but
2728         this will fix the test.
2729
2730 2014-12-02  Beth Dakin  <bdakin@apple.com>
2731
2732         Yet another build fix.
2733
2734         * WebView/WebActionMenuController.mm:
2735         (-[WebActionMenuController _defaultMenuItemsForLink]):
2736
2737 2014-12-02  Beth Dakin  <bdakin@apple.com>
2738
2739         Build fix.
2740
2741         * WebView/WebActionMenuController.mm:
2742         (-[WebActionMenuController _defaultMenuItemsForLink]):
2743
2744 2014-12-02  Beth Dakin  <bdakin@apple.com>
2745
2746         More build fixing.
2747
2748         * WebView/WebActionMenuController.mm:
2749         (-[WebActionMenuController _defaultMenuItemsForLink]):
2750
2751 2014-12-02  Beth Dakin  <bdakin@apple.com>
2752
2753         Should use standardQuickLookMenuItem for apps that don't implement customizations
2754         https://bugs.webkit.org/show_bug.cgi?id=139193
2755         -and corresponding-
2756         rdar://problem/18944696
2757
2758         Reviewed by Anders Carlsson.
2759
2760         Use [NSMenuItem standardQuickLookMenuItem].
2761         * WebView/WebActionMenuController.mm:
2762         (-[WebActionMenuController _defaultMenuItemsForLink]):
2763
2764         Delegate methods to set up the standardQuickLookMenuItem.
2765         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
2766         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
2767         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
2768
2769         Remove all of the old QLPreviewBubble code.
2770         (-[WebActionMenuController _createActionMenuItemForTag:]):
2771         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
2772
2773 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
2774
2775         Fix the build.
2776
2777         * WebView/WebViewData.h:
2778
2779 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2780
2781         Implement Lookup transition from selection for Legacy WebKit
2782         https://bugs.webkit.org/show_bug.cgi?id=139180
2783         <rdar://problem/19067172>
2784
2785         Reviewed by Beth Dakin.
2786
2787         * WebView/DictionaryPopupInfo.h: Added.
2788         Split DictionaryPopupInfo out into its own file.
2789
2790         * WebView/WebActionMenuController.mm:
2791         (-[WebActionMenuController _lookupText:]):
2792         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
2793
2794         (performDictionaryLookupForSelection):
2795         (performDictionaryLookupForRange):
2796         Plumb the transition style through these helpers.
2797         Create a TextIndicator from the selection range.
2798
2799         * WebView/WebHTMLView.mm:
2800         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2801         Make use of TextIndicator (and DictionaryPopupInfo, and the new
2802         _showDictionaryLookupPopup on WebView) to add a transition from blue
2803         when performing Lookup from the context menu.
2804
2805         (-[WebHTMLView quickLookWithEvent:]):
2806         Remove our TextIndicator whenever a normal three-finger-tap event
2807         comes through, as it will have its own indication.
2808
2809         * WebView/WebView.mm:
2810         (-[WebView _commonInitializationWithFrameName:groupName:]):
2811         (-[WebView _dictionaryLookupPopoverWillClose:]):
2812         Register for the LUNotificationPopoverWillClose notification and remove
2813         our TextIndicator when it is called, just like in WebKit2.
2814         Deregistration is already handled in _close.
2815
2816         (-[WebView _showDictionaryLookupPopup:]):
2817         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
2818         if the relevant API is available.
2819
2820         * WebView/WebViewInternal.h:
2821
2822 2014-12-02  Anders Carlsson  <andersca@apple.com>
2823
2824         Remove visited link handling from PageGroup
2825         https://bugs.webkit.org/show_bug.cgi?id=139185
2826
2827         Reviewed by Sam Weinig.
2828
2829         * History/WebHistory.mm:
2830         (-[WebHistoryPrivate removeItemForURLString:]):
2831         (-[WebHistoryPrivate removeAllItems]):
2832         (+[WebHistory setOptionalSharedHistory:]):
2833         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
2834         (+[WebHistory _removeAllVisitedLinks]):
2835         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
2836         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
2837         * History/WebHistoryInternal.h:
2838         * WebCoreSupport/WebChromeClient.h:
2839         * WebCoreSupport/WebChromeClient.mm:
2840         (WebChromeClient::populateVisitedLinks): Deleted.
2841         * WebView/WebView.mm:
2842         (-[WebView addVisitedLinks:]):
2843         (-[WebView removeVisitedLink:]):
2844
2845 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
2846
2847         Try to fix the Mac build.
2848
2849         * WebView/WebView.mm:
2850         (-[WebView _commonInitializationWithFrameName:groupName:]):
2851         (-[WebView _close]):
2852
2853 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
2854
2855         Fix the iOS build.
2856
2857         * WebView/WebActionMenuController.h:
2858         * WebView/WebActionMenuController.mm:
2859         * WebView/WebHTMLView.mm:
2860         (-[WebHTMLView scrollWheel:scrollWheel:]):
2861         (-[WebHTMLView mouseDown:mouseDown:]):
2862         * WebView/WebView.mm:
2863         * WebView/WebViewData.h:
2864         * WebView/WebViewData.mm:
2865         (-[WebViewPrivate dealloc]):
2866         * WebView/WebViewInternal.h:
2867
2868 2014-12-01  Tim Horton  <timothy_horton@apple.com>
2869
2870         Implement yellow highlight for WebKit1 data detectors
2871         https://bugs.webkit.org/show_bug.cgi?id=138956
2872         <rdar://problem/18992185>
2873
2874         Reviewed by Beth Dakin.
2875
2876         * WebView/WebActionMenuController.h:
2877         * WebView/WebActionMenuController.mm:
2878         (-[WebActionMenuController webView:willHandleMouseDown:]):
2879         (-[WebActionMenuController webView:didHandleScrollWheel:]):
2880         (-[WebActionMenuController prepareForMenu:withEvent:]):
2881         (-[WebActionMenuController didCloseMenu:withEvent:]):
2882         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2883         (-[WebActionMenuController _showTextIndicator]):
2884         (-[WebActionMenuController _hideTextIndicator]):
2885         (-[WebActionMenuController _dismissActionMenuPopovers]):
2886         Copy the WebKit2 WKActionMenuController TextIndicator implementation
2887         into WebActionMenuController. The only significant difference is
2888         that we build the TextIndicator right at menu construction time
2889         instead of in the Web process.
2890
2891         * WebView/WebHTMLView.mm:
2892         (-[WebHTMLView scrollWheel:]):
2893         Let the WebActionMenuController know that we're handling a scroll.
2894
2895         (-[WebHTMLView mouseDown:]):
2896         Let the WebActionMenuController know that we're handling a mouseDown.
2897
2898         * WebView/WebView.mm:
2899         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2900         (-[WebView _clearTextIndicator]):
2901         (-[WebView _actionMenuController]):
2902         (-[WebView _convertRectFromRootView:]): Deleted.
2903         * WebView/WebViewData.h:
2904         * WebView/WebViewData.mm:
2905         * WebView/WebViewInternal.h:
2906         Keep a TextIndicatorWindow on WebView, just like WKView does.
2907         Expose the WebActionMenuController on WebView (internally).
2908
2909 2014-12-01  Anders Carlsson  <andersca@apple.com>
2910
2911         Remove old site specific quirks code that was added in 2009
2912         https://bugs.webkit.org/show_bug.cgi?id=139141
2913
2914         Reviewed by Antti Koivisto.
2915
2916         * WebCoreSupport/WebFrameNetworkingContext.h:
2917         * WebCoreSupport/WebFrameNetworkingContext.mm:
2918         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
2919
2920 2014-11-30  Anders Carlsson  <andersca@apple.com>
2921
2922         Fix a test failure.
2923
2924         * History/WebHistory.mm:
2925         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
2926         Call through to the visited link store.
2927
2928         (+[WebHistory _removeAllVisitedLinks]):
2929         Ditto.
2930
2931         * WebCoreSupport/WebVisitedLinkStore.mm:
2932         (WebVisitedLinkStore::isLinkVisited):
2933         Make sure to populate visited links.
2934
2935 2014-11-30  Anders Carlsson  <andersca@apple.com>
2936
2937         Switch over to the visited link store from the WebViewGroup
2938         https://bugs.webkit.org/show_bug.cgi?id=139112
2939
2940         Reviewed by Sam Weinig.
2941
2942         * WebView/WebView.mm:
2943         (-[WebView _commonInitializationWithFrameName:groupName:]):
2944         (-[WebView setGroupName:]):
2945
2946 2014-11-30  Anders Carlsson  <andersca@apple.com>
2947
2948         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
2949         https://bugs.webkit.org/show_bug.cgi?id=139111
2950
2951         Reviewed by Sam Weinig.
2952
2953         * WebCoreSupport/WebVisitedLinkStore.h:
2954         * WebCoreSupport/WebVisitedLinkStore.mm:
2955         (WebVisitedLinkStore::removeVisitedLink):
2956         * WebView/WebView.mm:
2957         (-[WebView removeVisitedLink:]):
2958
2959 2014-11-29  Anders Carlsson  <andersca@apple.com>
2960
2961         Populate visited links
2962         https://bugs.webkit.org/show_bug.cgi?id=139101
2963
2964         Reviewed by Sam Weinig.
2965
2966         * History/WebHistory.mm:
2967         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
2968         Helper function that adds all visited link to the given store.
2969
2970         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
2971         Call the private method.
2972
2973         * History/WebHistoryInternal.h:
2974         * WebCoreSupport/WebVisitedLinkStore.h:
2975         Add new members.
2976
2977         * WebCoreSupport/WebVisitedLinkStore.mm:
2978         (WebVisitedLinkStore::addVisitedLink):
2979         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
2980
2981         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
2982         Implement this. First try the delegate, then try the shared history.
2983
2984         (WebVisitedLinkStore::addVisitedLinkHash):
2985         Factor code that adds the link to the hash table into a separate function.
2986
2987         * WebView/WebView.mm:
2988         (-[WebView addVisitedLinks:]):
2989         Add the visited links to the store.
2990
2991 2014-11-29  Anders Carlsson  <andersca@apple.com>
2992
2993         More work on the legacy WebKit visited link store
2994         https://bugs.webkit.org/show_bug.cgi?id=139100
2995
2996         Reviewed by Sam Weinig.
2997
2998         * History/WebHistory.mm:
2999         (+[WebHistory setOptionalSharedHistory:]):
3000         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
3001
3002         * WebCoreSupport/WebVisitedLinkStore.h:
3003         * WebCoreSupport/WebVisitedLinkStore.mm:
3004         (visitedLinkStores):
3005         (WebVisitedLinkStore::WebVisitedLinkStore):
3006         (WebVisitedLinkStore::~WebVisitedLinkStore):
3007         Keep track of live visited link stores.
3008
3009         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
3010         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
3011
3012         (WebVisitedLinkStore::removeAllVisitedLinks):
3013         Iterate over all live link stores and remove their links.
3014
3015         (WebVisitedLinkStore::isLinkVisited):
3016         Populate visited links and check if our hash table contains the link.
3017
3018         (WebVisitedLinkStore::addVisitedLink):
3019         Add the link hash to the table.
3020
3021         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
3022         Add stub.
3023
3024         (WebVisitedLinkStore::removeVisitedLinkHashes):
3025         Clear out the hash table.
3026
3027 2014-11-27  Anders Carlsson  <andersca@apple.com>
3028
3029         Add a stubbed out WebVisitedLinkStore to WebViewGroup
3030         https://bugs.webkit.org/show_bug.cgi?id=139066
3031
3032         Reviewed by Antti Koivisto.
3033
3034         * WebCoreSupport/WebViewGroup.h:
3035         (WebViewGroup::visitedLinkStore):
3036         * WebCoreSupport/WebViewGroup.mm:
3037         (WebViewGroup::WebViewGroup):
3038         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
3039         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
3040         (WebVisitedLinkStore::create):
3041         (WebVisitedLinkStore::WebVisitedLinkStore):
3042         (WebVisitedLinkStore::~WebVisitedLinkStore):
3043         (WebVisitedLinkStore::isLinkVisited):
3044         (WebVisitedLinkStore::addVisitedLink):
3045
3046 2014-11-25  Anders Carlsson  <andersca@apple.com>
3047
3048         Remove user content handling from PageGroup
3049         https://bugs.webkit.org/show_bug.cgi?id=139051
3050
3051         Reviewed by Antti Koivisto.
3052
3053         Use the user content controller in the web view group.
3054
3055         * WebView/WebView.mm:
3056         (-[WebView _injectOutlookQuirksScript]):
3057
3058 2014-11-25  Anders Carlsson  <andersca@apple.com>
3059
3060         Add a user content controller to WebViewGroup and use it for user content
3061         https://bugs.webkit.org/show_bug.cgi?id=139043
3062
3063         Reviewed by Antti Koivisto.
3064
3065         This is another tiny step towards getting rid of user content handling inside PageGroup.
3066
3067         * WebCoreSupport/WebViewGroup.h:
3068         (WebViewGroup::userContentController):
3069         Add a UserContentController member and getter.
3070
3071         * WebCoreSupport/WebViewGroup.mm:
3072         (WebViewGroup::get):
3073         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
3074
3075         (WebViewGroup::WebViewGroup):
3076         Create a user content controller.
3077
3078         * WebView/WebView.mm:
3079         (-[WebView _commonInitializationWithFrameName:groupName:]):
3080         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
3081         set its user content controller in the PageConfiguration.
3082
3083         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3084         Ditto.
3085
3086         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
3087         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
3088         (+[WebView _removeUserScriptFromGroup:world:url:]):
3089         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
3090         (+[WebView _removeUserScriptsFromGroup:world:]):
3091         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
3092         (+[WebView _removeAllUserContentFromGroup:]):
3093         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
3094
3095         (-[WebView setGroupName:]):
3096         Set the user content controller to the new WebViewGroup's user content controller.
3097
3098 2014-11-21  Jer Noble  <jer.noble@apple.com>
3099
3100         Support multiple signatures of diagnostic logging.
3101         https://bugs.webkit.org/show_bug.cgi?id=138690
3102
3103         Reviewed by Anders Carlsson.
3104
3105         Page::PageClients has been renamed PageConfiguration.
3106
3107         * WebView/WebView.mm:
3108         (-[WebView _commonInitializationWithFrameName:groupName:]):
3109         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3110
3111 2014-11-21  Zalan Bujtas  <zalan@apple.com>
3112
3113         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
3114         https://bugs.webkit.org/show_bug.cgi?id=138981
3115
3116         Reviewed by Simon Fraser.
3117
3118         * WebView/WebPreferenceKeysPrivate.h:
3119         * WebView/WebPreferences.mm:
3120         (+[WebPreferences initialize]):
3121         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
3122         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
3123         * WebView/WebPreferencesPrivate.h:
3124         * WebView/WebView.mm:
3125         (-[WebView _preferencesChanged:]):
3126
3127 2014-11-21  Tim Horton  <timothy_horton@apple.com>
3128
3129         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
3130         ​https://bugs.webkit.org/show_bug.cgi?id=138960
3131         <rdar://problem/19056715>
3132
3133         Reviewed by Anders Carlsson.
3134
3135         * WebView/WebActionMenuController.mm:
3136         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
3137         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3138         Use DataDetectors SPI instead of an explicit blacklist.
3139
3140 2014-11-21  Tim Horton  <timothy_horton@apple.com>
3141
3142         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
3143         https://bugs.webkit.org/show_bug.cgi?id=138960
3144         <rdar://problem/19056715>
3145
3146         Reviewed by Beth Dakin.
3147
3148         * WebView/WebActionMenuController.mm:
3149         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3150         Blacklist contact results, because they don't have useful menus. If we
3151         bail before setting up _currentActionContext, we'll still allow fallthrough
3152         to ordinary text actions, avoiding mysterious failure when a contact is detected.
3153
3154         This doesn't break the case that r176351 was intended to fix,
3155         because in that case we were detecting e.g. addresses.
3156
3157 2014-11-21  Anders Carlsson  <andersca@apple.com>
3158
3159         Remove the Timer parameters from timer callbacks
3160         https://bugs.webkit.org/show_bug.cgi?id=138974
3161
3162         Reviewed by Antti Koivisto.
3163
3164         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3165         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3166         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
3167         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
3168         * Plugins/WebNetscapePluginStream.h:
3169         * Plugins/WebNetscapePluginStream.mm:
3170         (WebNetscapePluginStream::WebNetscapePluginStream):
3171         (WebNetscapePluginStream::deliverDataTimerFired):
3172
3173 2014-11-21  Anders Carlsson  <andersca@apple.com>
3174
3175         Make memoryCache() return a reference
3176         https://bugs.webkit.org/show_bug.cgi?id=138939
3177
3178         Reviewed by Antti Koivisto.
3179
3180         * Misc/WebCache.mm:
3181         (+[WebCache statistics]):
3182         (+[WebCache emptyInMemoryResources]):
3183         (+[WebCache sizeOfDeadResources:]):
3184         (+[WebCache addImageToCache:forURL:forFrame:]):
3185         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3186         (+[WebCache imageForURL:]):
3187         (+[WebCache setDisabled:]):
3188         (+[WebCache isDisabled]):
3189         * WebView/WebView.mm:
3190         (+[WebView _setCacheModel:]):
3191
3192 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
3193
3194         Remove the remaining vestiges of minimal-ui
3195         https://bugs.webkit.org/show_bug.cgi?id=138890
3196
3197         Reviewed by Sam Weinig.
3198
3199         * History/WebHistoryItem.mm:
3200         * History/WebHistoryItemPrivate.h:
3201
3202 2014-11-20  Tim Horton  <timothy_horton@apple.com>
3203
3204         Cancel DataDetectors menu earlier if we know it can't be presented
3205         https://bugs.webkit.org/show_bug.cgi?id=138922
3206         <rdar://problem/18950441>
3207
3208         Reviewed by Beth Dakin.
3209
3210         * WebView/WebActionMenuController.mm:
3211         (-[WebActionMenuController prepareForMenu:withEvent:]):
3212         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
3213         and use a bigger hammer (removeAllItems).
3214
3215         (-[WebActionMenuController willOpenMenu:withEvent:]):
3216         If we end up with a menu with no items, don't change selection or anything.
3217
3218 2014-11-20  Beth Dakin  <bdakin@apple.com>
3219
3220         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
3221         https://bugs.webkit.org/show_bug.cgi?id=138568
3222         -and corresponding-
3223         rdar://problem/18904600
3224
3225         Reviewed by Tim Horton.
3226
3227         Skip images for lookup.
3228         * WebView/WebActionMenuController.mm:
3229         (performDictionaryLookupForRange):
3230
3231 2014-11-19  Beth Dakin  <bdakin@apple.com>
3232
3233         Invoking an action menu on a selection should result in the text menu
3234         https://bugs.webkit.org/show_bug.cgi?id=138892
3235         -and corresponding-
3236         rdar://problem/18996776
3237
3238         Reviewed by Tim Horton.
3239
3240         * WebView/WebActionMenuController.mm:
3241         (-[WebActionMenuController _defaultMenuItems]):
3242
3243 2014-11-19  Beth Dakin  <bdakin@apple.com>
3244
3245         Data detected results with no menu items should not fall through to regular text 
3246         action menus
3247         https://bugs.webkit.org/show_bug.cgi?id=138887
3248         -and corresponding-
3249         rdar://problem/18971616
3250
3251         Reviewed by Tim Horton.
3252
3253         * WebView/WebActionMenuController.mm:
3254         (-[WebActionMenuController _defaultMenuItems]):
3255
3256 2014-11-19  Daniel Bates  <dabates@apple.com>
3257
3258         [iOS] Make WebKit build with public iOS SDK
3259         https://bugs.webkit.org/show_bug.cgi?id=136863
3260
3261         Reviewed by David Kilzer.
3262
3263         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
3264         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
3265         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
3266         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
3267         may be used by Apple internal clients that do not include wtf/Platform.h.
3268         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
3269         private Foundation headers directly.
3270         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
3271         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
3272         instead of including private CFNetwork headers directly. Also fixed up style and
3273         ordering of header include directives.
3274         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
3275         CFNetwork headers directly. Also sort the #import directives.
3276         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
3277         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
3278
3279 2014-11-18  David Kilzer  <ddkilzer@apple.com>
3280
3281         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
3282         <http://webkit.org/b/138813>
3283
3284         Reviewed by Mark Rowe.
3285
3286         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
3287         selectors.
3288
3289 2014-11-18  Chris Dumez  <cdumez@apple.com>
3290
3291         Add a setting to toggle DOMTimer throttling support
3292         https://bugs.webkit.org/show_bug.cgi?id=138844
3293         <rdar://problem/19020874>
3294
3295         Reviewed by Andreas Kling.
3296
3297         Add a setting to disable DOM timers throttling, in order to help
3298         developers determine if a specific issue is caused by timer
3299         throttling.
3300
3301         * WebView/WebPreferenceKeysPrivate.h:
3302         * WebView/WebPreferences.mm:
3303         (+[WebPreferences initialize]):
3304         (-[WebPreferences domTimersThrottlingEnabled]):
3305         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
3306         * WebView/WebPreferencesPrivate.h:
3307         * WebView/WebView.mm:
3308         (-[WebView _preferencesChanged:]):
3309
3310 2014-11-18  Tim Horton  <timothy_horton@apple.com>
3311
3312         Avoid re-encoding action menu image data
3313         https://bugs.webkit.org/show_bug.cgi?id=138817
3314         <rdar://problem/18840382>
3315
3316         Reviewed by Anders Carlsson.
3317
3318         * WebView/WebActionMenuController.mm:
3319         (-[WebActionMenuController _defaultMenuItemsForImage:]):
3320         (-[WebActionMenuController _addImageToPhotos:]):
3321         Build a temporary filename from a UUID and the image's desired extension.
3322         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
3323         Build an image menu only if we have an image, URL, data, and extension.
3324
3325 2014-11-18  Daniel Bates  <dabates@apple.com>
3326
3327         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3328         SPI are not available in public SDK
3329         https://bugs.webkit.org/show_bug.cgi?id=138802
3330
3331         Reviewed by David Kilzer.
3332
3333         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
3334         libdispatch and MobileGestalt headers directly.
3335
3336         * WebView/WebView.mm:
3337
3338 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
3339
3340         Remove calls to deprecated NSMenu methods
3341         https://bugs.webkit.org/show_bug.cgi?id=138808.
3342
3343         Reviewed by Anders Carlsson.
3344
3345         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
3346
3347         * WebCoreSupport/PopupMenuMac.mm:
3348         (PopupMenuMac::populate):
3349
3350 2014-11-17  Daniel Bates  <dabates@apple.com>
3351
3352         Unreviewed, rolling out r176232.
3353
3354         Broke the Mac build. Will investigate offline.
3355
3356         Reverted changeset:
3357
3358         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
3359         MobileGestalt"
3360         https://bugs.webkit.org/show_bug.cgi?id=138802
3361         http://trac.webkit.org/changeset/176232
3362
3363 2014-11-17  Daniel Bates  <dabates@apple.com>
3364
3365         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3366         SPI are not available in public SDK
3367         https://bugs.webkit.org/show_bug.cgi?id=138802
3368
3369         Reviewed by David Kilzer.
3370
3371         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
3372         libdispatch and MobileGestalt headers directly.
3373
3374         * WebView/WebView.mm:
3375
3376 2014-11-17  Beth Dakin  <bdakin@apple.com>
3377
3378         Whitespace action menus should focus the HitTestResult and create an insertion 
3379         point
3380         https://bugs.webkit.org/show_bug.cgi?id=138786
3381         -and corresponding-
3382         rdar://problem/18944893
3383
3384         Reviewed by Tim Horton.
3385
3386         Whitespace menus should cause the HitTestResult to be focused, and they should set 
3387         the selection based on the HitTest location.
3388
3389         * WebView/WebActionMenuController.mm:
3390         (-[WebActionMenuController isMenuForTextContent]):
3391         (-[WebActionMenuController focusAndSelectHitTestResult]):
3392         (-[WebActionMenuController willOpenMenu:withEvent:]):
3393
3394 2014-11-17  Daniel Bates  <dabates@apple.com>
3395
3396         [iOS] QuartzCore SPI not available in public SDK
3397         https://bugs.webkit.org/show_bug.cgi?id=138751
3398
3399         Reviewed by David Kilzer.
3400
3401         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
3402
3403         * WebInspector/WebNodeHighlight.mm:
3404         * WebView/WebIndicateLayer.mm:
3405
3406 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
3407
3408         [iOS] allow host application to opt-out of alternate fullscreen
3409         https://bugs.webkit.org/show_bug.cgi?id=138787
3410
3411         Reviewed by Darin Adler.
3412
3413         * WebView/WebPreferenceKeysPrivate.h:
3414         * WebView/WebPreferences.mm:
3415         (+[WebPreferences initialize]):
3416         (-[WebPreferences allowsAlternateFullscreen]):
3417         (-[WebPreferences setAllowsAlternateFullscreen:]):
3418         * WebView/WebPreferencesPrivate.h:
3419         * WebView/WebView.mm:
3420         (-[WebView _preferencesChanged:]):
3421
3422 2014-11-16  Tim Horton  <timothy_horton@apple.com>
3423
3424         Use TextIndicator instead of the built in Lookup highlight
3425         https://bugs.webkit.org/show_bug.cgi?id=138775
3426         <rdar://problem/18953982>
3427
3428         Reviewed by Anders Carlsson.
3429
3430         * WebCoreSupport/WebSystemInterface.mm:
3431         (InitWebCoreSystemInterface):
3432         Remove a WKSI import.
3433
3434         * WebView/WebActionMenuController.mm:
3435         (-[WebActionMenuController _lookupText:]):
3436         (-[WebActionMenuController _createActionMenuItemForTag:]):
3437         Make use of the new Lookup SPI header.
3438         Disable the Lookup item if lookup is not available.
3439
3440 2014-11-15  Tim Horton  <timothy_horton@apple.com>
3441
3442         Implement data detectors and mailto action menus for WebKit1
3443         https://bugs.webkit.org/show_bug.cgi?id=138765
3444         <rdar://problem/18877535>
3445
3446         Reviewed by Beth Dakin.
3447
3448         * WebView/WebActionMenuController.h:
3449         * WebView/WebActionMenuController.mm:
3450         (-[WebActionMenuController willOpenMenu:withEvent:]):
3451         Tell DataDetectors that the menu is going to open.
3452         Select the text (or not) based on the number of items in the menu, just like WebKit2.
3453
3454         (-[WebActionMenuController didCloseMenu:withEvent:]):
3455         Tell DataDetectors that the menu closed.
3456
3457         (-[WebActionMenuController _defaultMenuItemsForLink]):
3458         Move these checks out of _defaultMenuItemsForLink, because we expect this
3459         to always return a complete link menu.
3460
3461         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
3462         Implement. More or less copied from WebKit2.
3463
3464         (-[WebActionMenuController _selectDataDetectedText]):
3465         Select the stashed range.
3466
3467         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3468         Implement. More or less copied from WebKit2.
3469         The yellow highlight isn't hooked up yet.
3470         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
3471
3472         (-[WebActionMenuController _selectLookupText]):
3473         Remove an unnecessary return.
3474
3475         (-[WebActionMenuController _defaultMenuItems]):
3476         Call into the two new menu types.
3477
3478         * WebView/WebUIDelegatePrivate.h:
3479
3480 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
3481
3482         Get rid of WebFontCache
3483         https://bugs.webkit.org/show_bug.cgi?id=134752
3484
3485         Reviewed by Dave Hyatt.
3486
3487         * WebView/WebHTMLView.mm:
3488
3489 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
3490
3491         Update some artwork for the legacy WebKit action menu
3492         https://bugs.webkit.org/show_bug.cgi?id=138758
3493         <rdar://problem/18989840>
3494
3495         * WebView/WebActionMenuController.mm:
3496         (webKitBundleImageNamed): Deleted.
3497         Fix the build.
3498
3499 2014-11-14  Tim Horton  <timothy_horton@apple.com>
3500
3501         Update some artwork for the legacy WebKit action menu
3502         https://bugs.webkit.org/show_bug.cgi?id=138758
3503         <rdar://problem/18989840>
3504
3505         Reviewed by Simon Fraser.
3506
3507         * WebView/WebActionMenuController.mm:
3508         (-[WebActionMenuController _createActionMenuItemForTag:]):
3509
3510 2014-11-14  Daniel Bates  <dabates@apple.com>
3511
3512         [iOS] NSFileManager and QuickLook SPI not available in public SDK
3513         https://bugs.webkit.org/show_bug.cgi?id=138742
3514
3515         Reviewed by Pratik Solanki.
3516
3517         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
3518
3519         * WebCoreSupport/WebFrameLoaderClient.mm:
3520
3521 2014-11-14  Beth Dakin  <bdakin@apple.com>
3522
3523         WK1: Webpage preview can come up in wrong location
3524         https://bugs.webkit.org/show_bug.cgi?id=138747
3525         -and corresponding-
3526         rdar://problem/18979004
3527
3528         Reviewed by Tim Horton.
3529
3530         Converting to window twice is bad.
3531         * WebView/WebActionMenuController.mm:
3532         (elementBoundingBoxInWindowCoordinatesFromNode):
3533         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3534         (elementBoundingBoxFromNode): Deleted.
3535
3536 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
3537
3538         Move FontMac and FontCacheMac off of WKSI
3539         https://bugs.webkit.org/show_bug.cgi?id=138633
3540
3541         Reviewed by Simon Fraser.
3542
3543         * WebCoreSupport/WebSystemInterface.mm:
3544         (InitWebCoreSystemInterface):
3545         * WebKit.order:
3546
3547 2014-11-13  Beth Dakin  <bdakin@apple.com>
3548
3549         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
3550         https://bugs.webkit.org/show_bug.cgi?id=138716
3551         -and corresponding-
3552         rdar://problem/18977222
3553
3554         Reviewed by Tim Horton.
3555
3556         It’s not necessary to use the WebElementDictionary for so many things now that we 
3557         are caching the HitTestResult. We should just use the HitTestResult.
3558
3559         * WebView/WebActionMenuController.mm:
3560         (-[WebActionMenuController prepareForMenu:withEvent:]):
3561         (-[WebActionMenuController _openURLFromActionMenu:]):
3562         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3563         (elementBoundingBoxFromNode):
3564         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3565         (-[WebActionMenuController _defaultMenuItemsForLink]):
3566         (-[WebActionMenuController _defaultMenuItemsForImage]):
3567         (-[WebActionMenuController _defaultMenuItemsForVideo]):
3568         (-[WebActionMenuController _defaultMenuItemsForText]):
3569         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
3570         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
3571         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
3572         (-[WebActionMenuController _createActionMenuItemForTag:]):
3573         (-[WebActionMenuController _defaultMenuItems]):
3574         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
3575         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
3576         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
3577         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
3578         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
3579         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
3580         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
3581         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
3582         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
3583         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
3584
3585 2014-11-13  Daniel Bates  <dabates@apple.com>
3586
3587         [iOS] NSGeometry data types are not available in the public SDK
3588         https://bugs.webkit.org/show_bug.cgi?id=137536
3589
3590         Reviewed by David Kilzer.
3591
3592         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
3593         private header.
3594
3595         * DOM/WebDOMOperationsPrivate.h:
3596
3597 2014-11-13  Beth Dakin  <bdakin@apple.com>
3598
3599         WK1: Support default actions for video
3600         https://bugs.webkit.org/show_bug.cgi?id=138713
3601         -and corresponding-
3602         rdar://problem/18877520
3603
3604         Reviewed by Tim Horton.
3605
3606         Call setToNonShadowAncestor() for media HitTestResults.
3607         * WebView/WebActionMenuController.mm:
3608         (-[WebActionMenuController performHitTestAtPoint:]):
3609
3610         Default items and actions.
3611         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
3612         (-[WebActionMenuController _copyVideoURL:]):
3613         (-[WebActionMenuController _saveVideoToDownloads:]):
3614         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3615         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3616         * WebView/WebUIDelegatePrivate.h:
3617
3618 2014-11-13  Tim Horton  <timothy_horton@apple.com>
3619
3620         WK1: Update icon for Add to Reading List
3621         https://bugs.webkit.org/show_bug.cgi?id=138710
3622         <rdar://problem/18975774>
3623
3624         Reviewed by Beth Dakin.
3625
3626         * WebView/WebActionMenuController.mm:
3627         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3628         Use the right icon, matching WebKit2.
3629
3630 2014-11-12  Beth Dakin  <bdakin@apple.com>
3631
3632         WK1: Support default actions for images
3633         https://bugs.webkit.org/show_bug.cgi?id=138668
3634         -and corresponding-
3635         rdar://problem/18785434
3636
3637         Reviewed by Tim Horton.
3638
3639         * WebView/WebActionMenuController.h:
3640         * WebView/WebActionMenuController.mm:
3641         (-[WebActionMenuController didCloseMenu:withEvent:]):
3642         (-[WebActionMenuController _defaultMenuItemsForImage:]):
3643         (-[WebActionMenuController _copyImage:]):
3644         (temporaryPhotosDirectoryPath):
3645         (pathToPhotoOnDisk):
3646         (-[WebActionMenuController _canAddMediaToPhotos]):
3647         (-[WebActionMenuController _addImageToPhotos:]):
3648         (-[WebActionMenuController _saveImageToDownloads:]):
3649         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
3650         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
3651         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3652         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3653         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3654         * WebView/WebUIDelegatePrivate.h:
3655
3656 2014-11-11  Beth Dakin  <bdakin@apple.com>
3657
3658         Action menu hit testing is not working properly with all WK1 apps
3659         https://bugs.webkit.org/show_bug.cgi?id=138643
3660         -and corresponding-
3661         rdar://problem/18949376
3662
3663         Reviewed by Tim Horton.
3664
3665         * WebView/WebActionMenuController.mm:
3666         (-[WebActionMenuController prepareForMenu:withEvent:]):
3667         (-[WebActionMenuController _lookupText:]):
3668
3669 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
3670
3671         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
3672         https://bugs.webkit.org/show_bug.cgi?id=138623
3673
3674         Reviewed by Geoff Garen.
3675
3676         * WebCoreSupport/WebSystemInterface.mm:
3677         (InitWebCoreSystemInterface):
3678         * WebKit.order:
3679
3680 2014-11-11  Tim Horton  <timothy_horton@apple.com>
3681
3682         Localize strings for action menus
3683         https://bugs.webkit.org/show_bug.cgi?id=138591
3684         <rdar://problem/18815343>
3685
3686         Reviewed by Dan Bates.
3687
3688         * WebView/WebActionMenuController.mm:
3689         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3690         Make use of the new strings.
3691
3692 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
3693
3694         Cleanup from r175379
3695         https://bugs.webkit.org/show_bug.cgi?id=138616
3696
3697         Reviewed by Simon Fraser.
3698
3699         * WebCoreSupport/WebSystemInterface.mm:
3700         (InitWebCoreSystemInterface):
3701         * WebKit.order:
3702
3703 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
3704
3705         Move CTFontTransformGlyphs out from WKSI
3706         https://bugs.webkit.org/show_bug.cgi?id=138599
3707
3708         Reviewed by Simon Fraser.
3709
3710         * WebCoreSupport/WebSystemInterface.mm:
3711         (InitWebCoreSystemInterface):
3712         * WebKit.order:
3713
3714 2014-11-11  Dan Bernstein  <mitz@apple.com>
3715
3716         More iOS build fix.
3717
3718         * WebView/WebHTMLViewInternal.h:
3719
3720 2014-11-11  Dan Bernstein  <mitz@apple.com>
3721
3722         iOS build fix.
3723
3724         * WebView/WebHTMLView.mm:
3725
3726 2014-11-10  Beth Dakin  <bdakin@apple.com>
3727
3728         WK1: Support default actions for editable text with misspelled word
3729         https://bugs.webkit.org/show_bug.cgi?id=138590
3730         -and corresponding-
3731         rdar://problem/18877506
3732
3733         Reviewed by Tim Horton.
3734
3735         If there are misspelled word suggestions for editable text, create a new type of 
3736         menu with a spelling suggestion sub-menu.
3737
3738         * WebView/WebActionMenuController.mm:
3739         (-[WebActionMenuController isMenuForTextContent]):
3740         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
3741         (-[WebActionMenuController _changeSelectionToSuggestion:]):
3742         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3743         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3744         * WebView/WebHTMLView.mm:
3745         (-[WebHTMLView _changeSpellingToWord:]):
3746         * WebView/WebHTMLViewInternal.h:
3747         * WebView/WebUIDelegatePrivate.h:
3748
3749 2014-11-10  Beth Dakin  <bdakin@apple.com>
3750
3751         WK1: Support default actions for editable whitespace
3752         https://bugs.webkit.org/show_bug.cgi?id=138586
3753         -and corresponding-
3754         rdar://problem/18932048
3755
3756         Reviewed by Tim Horton.
3757
3758         New menu type. Just wants paste.
3759
3760         * WebView/WebActionMenuController.mm:
3761         (-[WebActionMenuController isMenuForTextContent]):
3762         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
3763         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3764         * WebView/WebUIDelegatePrivate.h:
3765
3766 2014-11-10  Beth Dakin  <bdakin@apple.com>
3767
3768         WK1: Support default actions for editable text
3769         https://bugs.webkit.org/show_bug.cgi?id=138580
3770         -and corresponding-
3771         rdar://problem/18877497
3772
3773         Reviewed by Tim Horton.
3774
3775         New menu type, and new action type for paste. 
3776
3777         * WebView/WebActionMenuController.mm:
3778         (-[WebActionMenuController isMenuForTextContent]):
3779         (-[WebActionMenuController willOpenMenu:withEvent:]):
3780         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
3781         (-[WebActionMenuController _paste:]):
3782         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3783         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3784         * WebView/WebUIDelegatePrivate.h:
3785
3786 2014-11-10  Beth Dakin  <bdakin@apple.com>
3787
3788         WK1: Text is getting selected even when an action menu fails to invoke
3789         https://bugs.webkit.org/show_bug.cgi?id=138576
3790         -and corresponding-
3791         rdar://problem/18931330
3792
3793         Reviewed by Tim Horton.
3794
3795         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
3796         * WebView/WebActionMenuController.h:
3797         * WebView/WebActionMenuController.mm:
3798         (-[WebActionMenuController prepareForMenu:withEvent:]):
3799         (-[WebActionMenuController willOpenMenu:withEvent:]):
3800
3801         _selectLookupText no longer needs to return a BOOL indicating success or failure.
3802         (-[WebActionMenuController _selectLookupText]):
3803         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3804
3805         Pass willOpenMenu: on to the controller.
3806         * WebView/WebView.mm:
3807         (-[WebView willOpenMenu:withEvent:]):
3808
3809 2014-11-10  Beth Dakin  <bdakin@apple.com>
3810
3811         Speculative build fix.
3812
3813         * WebView/WebActionMenuController.mm:
3814
3815 2014-11-10  Beth Dakin  <bdakin@apple.com>
3816
3817         Action menu initialization should be moved to _commonInitializationWithFrameName
3818         https://bugs.webkit.org/show_bug.cgi?id=138572
3819         -and corresponding-
3820         rdar://problem/18929733
3821
3822         Reviewed by Tim Horton.
3823
3824         * WebView/WebView.mm:
3825         (-[WebView _commonInitializationWithFrameName:groupName:]):
3826         (-[WebView _initWithFrame:frameName:groupName:]):
3827
3828 2014-11-10  Beth Dakin  <bdakin@apple.com>
3829
3830         WK1: Support default actions for read-only text
3831         https://bugs.webkit.org/show_bug.cgi?id=138552
3832         -and corresponding-
3833         rdar://problem/18877483
3834
3835         Reviewed by Tim Horton.
3836
3837         New WKSystemInterface functions that WebCore needs to use.
3838         * WebCoreSupport/WebSystemInterface.mm:
3839         (InitWebCoreSystemInterface):
3840
3841         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
3842         makes a lot of things easier.
3843         * WebView/WebActionMenuController.h:
3844         * WebView/WebActionMenuController.mm:
3845
3846         Perform the hit test ourselves instead of calling into WebView so that we can more 
3847         easily save the WebCore::HitTestResult for ourselves.
3848         (-[WebActionMenuController performHitTestAtPoint:]):
3849
3850         Clear selection for non-text menus.
3851         (-[WebActionMenuController prepareForMenu:withEvent:]):
3852
3853         Re-set the _type here just to be safe.
3854         (-[WebActionMenuController didCloseMenu:withEvent:]):
3855
3856         Moving this method to be next to the link actions so they can be within a pragma 
3857         mark.
3858         (-[WebActionMenuController _defaultMenuItemsForLink:]):
3859
3860         New method for default text actions — lookup and copy.
3861         (-[WebActionMenuController _defaultMenuItemsForText:]):
3862         (-[WebActionMenuController _copySelection:]):
3863         (-[WebActionMenuController _lookupText:]):
3864
3865         If there is not already a selection, invoking the action menu on text should 
3866         select the lookup text.
3867         (-[WebActionMenuController _selectLookupText]):
3868         (performDictionaryLookupForSelection):
3869         (performDictionaryLookupForRange):
3870
3871         Handle text now.
3872         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3873         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3874
3875         New enum values.
3876         * WebView/WebUIDelegatePrivate.h:
3877
3878         Pass didCloseMenu on to the controller.
3879         * WebView/WebView.mm:
3880         (-[WebView didCloseMenu:withEvent:]):
3881
3882 2014-11-09  Chris Dumez  <cdumez@apple.com>
3883
3884         Add a more correct way to compare floating point numbers and use it
3885         https://bugs.webkit.org/show_bug.cgi?id=138527
3886
3887         Reviewed by Darin Adler.
3888
3889         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
3890         to compare floating-point numbers.
3891
3892         * WebView/WebHTMLView.mm:
3893         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
3894
3895 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
3896
3897         Delete cookies between tests
3898         https://bugs.webkit.org/show_bug.cgi?id=138528
3899
3900         Reviewed by Sam Weinig.
3901
3902         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
3903         * WebView/WebPreferencesPrivate.h:
3904         Added an SPI for DumpRenderTree.
3905
3906 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
3907
3908         [iOS] Update optimized fullscreen media controls
3909         https://bugs.webkit.org/show_bug.cgi?id=138493
3910
3911         Reviewed by Brent Fulgham.
3912
3913         * WebCoreSupport/WebSystemInterface.mm:
3914         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
3915
3916 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
3917
3918         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
3919         https://bugs.webkit.org/show_bug.cgi?id=138443
3920
3921         Reviewed by Anders Carlsson.
3922
3923         Wrapping the dealloc method in its own autorelease pool avoids the problem of
3924         complex tear-downs leading to the WebView itself being added to an autorelease
3925         pool that is not drained until after the instance has been dealloc'd.
3926  
3927         * WebView/WebView.mm:
3928         (-[WebView dealloc]):
3929
3930 2014-11-05  Jer Noble  <jer.noble@apple.com>
3931
3932         De-templatize Timer
3933         https://bugs.webkit.org/show_bug.cgi?id=138450
3934
3935         Reviewed by Anders Carlsson.
3936
3937         Remove template specifiers from Timer.
3938
3939         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3940         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3941         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
3942         * Plugins/WebNetscapePluginStream.h:
3943         * Plugins/WebNetscapePluginStream.mm:
3944         (WebNetscapePluginStream::deliverDataTimerFired):
3945
3946 2014-11-05  Dan Bernstein  <mitz@apple.com>
3947
3948         Remove the unused deletion UI feature
3949         https://bugs.webkit.org/show_bug.cgi?id=138442
3950
3951         Rubber-stamped by Alexey Proskuryakov.
3952
3953         * DefaultDelegates/WebDefaultEditingDelegate.m:
3954         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
3955         * WebCoreSupport/WebEditorClient.h:
3956         * WebCoreSupport/WebEditorClient.mm:
3957         (WebEditorClient::shouldShowDeleteInterface): Deleted.
3958         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
3959         -webView:shouldShowDeleteInterfaceForElement:.
3960
3961 2014-11-03  Dean Jackson  <dino@apple.com>
3962
3963         Add ENABLE_FILTERS_LEVEL_2 feature guard.
3964         https://bugs.webkit.org/show_bug.cgi?id=138362
3965
3966         Reviewed by Tim Horton.
3967
3968         Add a new feature define for Level 2 of CSS Filters.
3969         http://dev.w3.org/fxtf/filters-2/
3970
3971         * Configurations/FeatureDefines.xcconfig:
3972
3973 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
3974
3975         Add button and enable optimized fullscreen.
3976         https://bugs.webkit.org/show_bug.cgi?id=138351
3977
3978         Reviewed by Eric Carlson.
3979
3980         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
3981
3982         * WebCoreSupport/WebSystemInterface.mm:
3983         (InitWebCoreSystemInterface): added
3984
3985 2014-11-04  Chris Dumez  <cdumez@apple.com>
3986
3987         Add ptr() method to Ref class
3988         https://bugs.webkit.org/show_bug.cgi?id=138361
3989
3990         Reviewed by Darin Adler.
3991
3992         Use the new Ref::ptr() method.
3993
3994         * WebView/WebFrame.mm:
3995         (-[WebFrame _setTypingStyle:withUndoAction:]):
3996         * WebView/WebHTMLView.mm:
3997         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
3998         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
3999         * WebView/WebView.mm:
4000         (-[WebView applyStyle:]):
4001
4002 2014-11-04  Darin Adler  <darin@apple.com>
4003
4004         Eliminate ResourceBuffer and use SharedBuffer directly instead
4005         https://bugs.webkit.org/show_bug.cgi?id=138174
4006
4007         Reviewed by Antti Koivisto.
4008
4009         * WebView/WebDataSource.mm:
4010         (-[WebDataSource data]): Use SharedBuffer directly.
4011         * WebView/WebHTMLView.mm:
4012         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
4013
4014 2014-11-03  Commit Queue  <commit-queue@webkit.org>
4015
4016         Unreviewed, rolling out r175406, r175413, and r175423.
4017         https://bugs.webkit.org/show_bug.cgi?id=138327
4018
4019         Multipart tests are still broken (Requested by ap on #webkit).
4020
4021         Reverted changesets:
4022
4023         "Eliminate ResourceBuffer and use SharedBuffer directly
4024         instead"
4025         https://bugs.webkit.org/show_bug.cgi?id=138174
4026         http://trac.webkit.org/changeset/175406
4027
4028         "Unreviewed, iOS build fix since 175406."
4029         http://trac.webkit.org/changeset/175413
4030
4031         "Fix assertion in CachedResource::addDataBuffer"
4032         http://trac.webkit.org/changeset/175423
4033
4034 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4035
4036         Use std::unique_ptr for TypeCountSet
4037         https://bugs.webkit.org/show_bug.cgi?id=138242
4038
4039         Reviewed by Andreas Kling.
4040
4041         * Misc/WebCoreStatistics.mm:
4042         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
4043         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
4044
4045 2014-10-31  Beth Dakin  <bdakin@apple.com>
4046
4047         Use system art for action menus when possible
4048         https://bugs.webkit.org/show_bug.cgi?id=138260
4049
4050         Reviewed by Tim Horton.
4051
4052         * WebView/WebActionMenuController.mm:
4053         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
4054
4055 2014-10-30  Darin Adler  <darin@apple.com>
4056
4057         Eliminate ResourceBuffer and use SharedBuffer directly instead
4058         https://bugs.webkit.org/show_bug.cgi?id=138174
4059
4060         Reviewed by Antti Koivisto.
4061
4062         * WebView/WebDataSource.mm:
4063         (-[WebDataSource data]): Use SharedBuffer directly.
4064         * WebView/WebHTMLView.mm:
4065         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
4066
4067 2014-10-30  Jer Noble  <jer.noble@apple.com>
4068
4069         [EME] Add Setting for accessing storage location for MediaKeys data
4070         https://bugs.webkit.org/show_bug.cgi?id=138147
4071
4072         Reviewed by Brady Eidson.
4073
4074         * WebView/WebPreferenceKeysPrivate.h:
4075         * WebView/WebPreferences.mm:
4076         (+[WebPreferences initialize]): Set default location.
4077         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
4078         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
4079         * WebView/WebPreferencesPrivate.h:
4080         * WebView/WebView.mm:
4081         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
4082
4083 2014-10-30  Dana Burkart  <dburkart@apple.com>
4084
4085         <rdar://problem/18821260> Prepare for the mysterious future
4086
4087         Reviewed by Lucas Forschler.
4088
4089         * Configurations/Base.xcconfig:
4090         * Configurations/DebugRelease.xcconfig:
4091         * Configurations/FeatureDefines.xcconfig:
4092         * Configurations/Version.xcconfig:
4093
4094 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
4095
4096         Add optimized fullscreen mode.
4097         https://bugs.webkit.org/show_bug.cgi?id=138044
4098
4099         Reviewed by Jer Noble.
4100
4101         Enable different types of fullscreen video behavior.
4102         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
4103
4104         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
4105         * WebCoreSupport/WebChromeClient.mm:
4106         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
4107         * WebView/WebView.mm:
4108         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
4109         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
4110         * WebView/WebViewInternal.h: ditto
4111
4112 2014-10-27  Beth Dakin  <bdakin@apple.com>
4113
4114         Provide a way for WebKit1 clients to override default action menu items
4115         https://bugs.webkit.org/show_bug.cgi?id=138066
4116         -and corresponding-
4117         rdar://problem/18451638
4118
4119         Reviewed by Anders Carlsson.
4120
4121         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
4122         send that along to clients customizing the menu.
4123         * WebView/WebActionMenuController.h:
4124         * WebView/WebActionMenuController.mm:
4125         (-[WebActionMenuController prepareForMenu:withEvent:]):
4126         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
4127
4128         New enum and new SPI to customize menus.
4129         * WebView/WebUIDelegatePrivate.h:
4130
4131 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
4132
4133         Fix the iOS build
4134
4135         * Configurations/WebKitLegacy.xcconfig:
4136         * WebView/WebView.mm:
4137
4138 2014-10-24  Beth Dakin  <bdakin@apple.com>
4139
4140         Build fix.
4141
4142         * WebView/WebActionMenuController.mm:
4143         (-[WebActionMenuController _openURLFromActionMenu:]):
4144         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
4145         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
4146
4147 2014-10-24  Beth Dakin  <bdakin@apple.com>
4148
4149         WebKit1 should support action menus
4150         https://bugs.webkit.org/show_bug.cgi?id=138032
4151
4152         Reviewed by Tim Horton.
4153
4154         This patch adds basic support for action menus and adds actions for links.
4155
4156         Helper class takes care of all of the action menu work. WebView will forward the 
4157         prepareForMenu: message, and then the helper class takes it from there.
4158         * WebView/WebActionMenuController.h: Added.
4159         * WebView/WebActionMenuController.mm: Added.
4160         (-[WebActionMenuController webViewClosed]):
4161         (-[WebActionMenuController prepareForMenu:withEvent:]):
4162
4163         Selectors for link actions.
4164         (-[WebActionMenuController _openURLFromActionMenu:]):
4165         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
4166         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
4167         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
4168         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
4169         (webKitBundleImageNamed):
4170         (-[WebActionMenuController _defaultMenuItemsForLink:]):
4171         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
4172
4173         Tags for the action menu items.
4174         * WebView/WebUIDelegatePrivate.h:
4175         * WebView/WebView.mm:
4176
4177         Set the action menu if possible and create the controller.
4178         (-[WebView _initWithFrame:frameName:groupName:]):
4179         (-[WebView _close]):
4180         (-[WebView prepareForMenu:withEvent:]):
4181
4182         WebViewData stores the WebActionMenuHelper
4183         * WebView/WebViewData.h:
4184         * WebView/WebViewData.mm:
4185         (-[WebViewPrivate dealloc]):
4186
4187 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
4188
4189         Web Inspector: Provide a way to have alternate inspector agents
4190         https://bugs.webkit.org/show_bug.cgi?id=137901
4191
4192         Reviewed by Brian Burg.
4193
4194         * Configurations/FeatureDefines.xcconfig:
4195
4196 2014-10-23  Tim Horton  <timothy_horton@apple.com>
4197
4198         Add some SPI headers for NSExtension and NSSharingService{Picker}
4199         https://bugs.webkit.org/show_bug.cgi?id=138027
4200
4201         Reviewed by Anders Carlsson.
4202
4203         * Misc/WebSharingServicePickerController.h:
4204         * Misc/WebSharingServicePickerController.mm:
4205         * WebCoreSupport/WebSelectionServiceController.mm:
4206         * WebCoreSupport/WebContextMenuClient.mm:
4207         Fix a sorting issue.
4208         Replace redefinitions with SPI header #imports.
4209
4210 2014-10-23  Tim Horton  <timothy_horton@apple.com>
4211
4212         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
4213         https://bugs.webkit.org/show_bug.cgi?id=138013
4214
4215         Reviewed by Dan Bernstein.
4216
4217         * WebCoreSupport/WebSelectionServiceController.mm:
4218         (WebSelectionServiceController::hasRelevantSelectionServices):
4219         Don't adopt this autoreleased object.
4220
4221 2014-10-22  Chris Dumez  <cdumez@apple.com>