dbb0a2e854ead2ce8ea39394f1b182cd70f2c4d7
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Remove pointerLockElement from DOMDocumentPrivate.h
4         https://bugs.webkit.org/show_bug.cgi?id=166882
5
6         Reviewed by Simon Fraser.
7
8         Removed pointerLockElement declaration that was supposed to be removed in r209637.
9
10         * DOM/DOMDocumentPrivate.h:
11
12 2017-01-06  Darin Adler  <darin@apple.com>
13
14         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
15         https://bugs.webkit.org/show_bug.cgi?id=166797
16
17         Reviewed by Alex Christensen.
18
19         * WebCoreSupport/WebEditorClient.h: Updated to take a reference.
20         * WebCoreSupport/WebEditorClient.mm:
21         (WebEditorClient::requestCheckingOfString): Take a reference
22         instead of a PassRefPtr.
23
24 2017-01-05  Chris Dumez  <cdumez@apple.com>
25
26         Turn preferLowPowerWebGLRendering setting on by default
27         https://bugs.webkit.org/show_bug.cgi?id=166737
28         <rdar://problem/29870033>
29
30         Reviewed by Dean Jackson.
31
32         Temporarily turn preferLowPowerWebGLRendering setting on by default until
33         we deal better with WebGL content in background tabs.
34
35         * WebView/WebPreferences.mm:
36         (+[WebPreferences initialize]):
37
38 2017-01-05  Enrica Casucci  <enrica@apple.com>
39
40         Support File Promise during drag for macOS.
41         https://bugs.webkit.org/show_bug.cgi?id=165204
42         rdar://problem/19595567
43
44         Reviewed by Tim Horton.
45
46         Adds support for dropping a File Promise in a WebView.
47         The implementation uses new File Promise API available in Sierra.
48
49         * Misc/WebNSPasteboardExtras.mm:
50         (+[NSPasteboard _web_dragTypesForURL]):
51         * WebView/WebView.mm:
52         (-[WebView performDragOperation:]):
53
54 2017-01-05  Andreas Kling  <akling@apple.com>
55
56         Remove ChromeClient::needTouchEvents().
57         <https://webkit.org/b/166723>
58
59         Rubber-stamped by Antti Koivisto.
60
61         * WebCoreSupport/WebChromeClient.h:
62
63 2017-01-04  Darin Adler  <darin@apple.com>
64
65         Remove PassRefPtr use from the "html" directory, other improvements
66         https://bugs.webkit.org/show_bug.cgi?id=166635
67
68         Reviewed by Alex Christensen.
69
70         * WebCoreSupport/WebChromeClient.h:
71         * WebCoreSupport/WebChromeClient.mm:
72         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
73
74 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
75
76         Unreviewed, rolling out r210287.
77
78         This change caused editing test failures on macOS.
79
80         Reverted changeset:
81
82         "Support File Promise during drag for macOS."
83         https://bugs.webkit.org/show_bug.cgi?id=165204
84         http://trac.webkit.org/changeset/210287
85
86 2017-01-04  Enrica Casucci  <enrica@apple.com>
87
88         Support File Promise during drag for macOS.
89         https://bugs.webkit.org/show_bug.cgi?id=165204
90         rdar://problem/19595567
91
92         Reviewed by Tim Horton.
93
94         Adds support for dropping a File Promise in a WebView.
95         The implementation uses new File Promise API available in Sierra.
96
97         * Misc/WebNSPasteboardExtras.mm:
98         (+[NSPasteboard _web_dragTypesForURL]):
99         * WebView/WebView.mm:
100         (-[WebView performDragOperation:]):
101
102 2017-01-04  Tim Horton  <timothy_horton@apple.com>
103
104         Provide a setting for clients to always prefer low-power WebGL
105         https://bugs.webkit.org/show_bug.cgi?id=166675
106         <rdar://problem/29834093>
107
108         Reviewed by Dan Bernstein.
109
110         * WebView/WebPreferenceKeysPrivate.h:
111         * WebView/WebPreferences.mm:
112         (+[WebPreferences initialize]):
113         (-[WebPreferences preferLowPowerWebGLRendering]):
114         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
115         * WebView/WebPreferencesPrivate.h:
116         * WebView/WebView.mm:
117         (-[WebView _preferencesChanged:]):
118         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
119
120 2017-01-03  Tim Horton  <timothy_horton@apple.com>
121
122         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
123         https://bugs.webkit.org/show_bug.cgi?id=166450
124         <rdar://problem/29447824>
125
126         Reviewed by Darin Adler.
127
128         * WebCoreSupport/CorrectionPanel.h:
129         * WebCoreSupport/CorrectionPanel.mm:
130         (CorrectionPanel::recordAutocorrectionResponse):
131         (CorrectionPanel::handleAcceptedReplacement):
132         * WebCoreSupport/WebAlternativeTextClient.mm:
133         (toCorrectionResponse):
134         (WebAlternativeTextClient::recordAutocorrectionResponse):
135         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
136         through recordAutocorrectionResponse, for debugging's sake.
137         Drop the NSView parameter because we don't need it, just the tag.
138         Convert the new AutocorrectionResponseType value to its corresponding
139         NSCorrectionResponse value.
140
141 2017-01-01  Jeff Miller  <jeffm@apple.com>
142
143         Update user-visible copyright strings to include 2017
144         https://bugs.webkit.org/show_bug.cgi?id=166278
145
146         Reviewed by Dan Bernstein.
147
148         * Info.plist:
149
150 2016-12-30  Darin Adler  <darin@apple.com>
151
152         Remove PassRefPtr use from the "dom" directory, related cleanup
153         https://bugs.webkit.org/show_bug.cgi?id=166569
154
155         Reviewed by Alex Christensen.
156
157         * WebCoreSupport/WebFrameLoaderClient.mm:
158         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
159         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
160         (WebFrameLoaderClient::setTitle): Ditto.
161         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
162         * WebView/WebFrame.mm:
163         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
164         Not needed now, but useful later if we ever can get rid of the explicit constructors.
165         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
166         * WebView/WebHTMLRepresentation.mm:
167         (-[WebHTMLRepresentation title]): Updated to use struct.
168
169 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
170
171         Propagate the source origin as much as possible
172         https://bugs.webkit.org/show_bug.cgi?id=166348
173
174         Reviewed by Darin Adler.
175
176         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
177         (WebKit::NetscapePluginInstanceProxy::evaluate):
178
179 2016-12-23  Andy Estes  <aestes@apple.com>
180
181         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
182         https://bugs.webkit.org/show_bug.cgi?id=166471
183
184         Reviewed by Andreas Kling.
185
186         When DumpRenderTree starts up, it calls
187         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
188         builds, this triggers the ASSERT(isMainThread()) in
189         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
190         started, we are on the main thread, and we are not holding the Web thread lock. This is
191         causing all layout tests to crash in the iOS WK1 Debug configuration.
192
193         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
194         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
195
196 2016-12-22  Andy Estes  <aestes@apple.com>
197
198         Make WebCore::EditorInsertAction an enum class
199         https://bugs.webkit.org/show_bug.cgi?id=166424
200
201         Reviewed by Brent Fulgham.
202
203         * WebCoreSupport/WebEditorClient.mm:
204         (kit):
205
206 2016-12-21  Beth Dakin  <bdakin@apple.com>
207
208         Holding down on candidates in the TouchBar should show panel on screen
209         https://bugs.webkit.org/show_bug.cgi?id=166367
210         -and corresponding-
211         <rdar://problem/28479236>
212
213         Reviewed by Tim Horton.
214
215         Stray whitespace.
216         * WebCoreSupport/WebEditorClient.mm:
217         (WebEditorClient::handleRequestedCandidates):
218
219         Call the version of setCandidates: that takes a rect. We need to keep the helper 
220         function in WK1 (unlike WK2) since we also use it for testing.
221         * WebView/WebView.mm:
222         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
223
224 2016-12-20  Dean Jackson  <dino@apple.com>
225
226         Remove INDIE_UI
227         https://bugs.webkit.org/show_bug.cgi?id=165881
228         <rdar://problem/29672532>
229
230         Reviewed by Simon Fraser.
231
232         The Indie UI work has been discontinued.
233
234         * Configurations/FeatureDefines.xcconfig:
235
236 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
237
238         [ES6] Enable ES6 Modules
239         https://bugs.webkit.org/show_bug.cgi?id=165849
240
241         Reviewed by Geoffrey Garen.
242
243         * WebView/WebPreferenceKeysPrivate.h:
244         * WebView/WebPreferences.mm:
245         (+[WebPreferences initialize]):
246         (-[WebPreferences es6ModulesEnabled]): Deleted.
247         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
248         * WebView/WebPreferencesPrivate.h:
249         * WebView/WebView.mm:
250         (-[WebView _preferencesChanged:]):
251
252 2016-12-16  Dave Hyatt  <hyatt@apple.com>
253
254         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
255         https://bugs.webkit.org/show_bug.cgi?id=165968
256
257         Reviewed by Andreas Kling.
258
259         * DOM/DOMCSS.mm:
260         (kitClass):
261         * DOM/DOMCSSPrimitiveValue.mm:
262         (-[DOMCSSPrimitiveValue getCounterValue]):
263         (-[DOMCSSPrimitiveValue getRectValue]):
264         (kit):
265         * DOM/DOMCSSPrimitiveValueInternal.h:
266         * DOM/DOMCSSStyleDeclaration.mm:
267         * DOM/DOMCSSValue.mm:
268         (kit):
269         * DOM/DOMCSSValueInternal.h:
270         * DOM/DOMCSSValueList.mm:
271         * DOM/DOMCounter.mm:
272         (kit):
273         * DOM/DOMCounterInternal.h:
274         * DOM/DOMRGBColor.mm:
275         (kit):
276         * DOM/DOMRGBColorInternal.h:
277         * DOM/DOMRect.mm:
278         (kit):
279         * DOM/DOMRectInternal.h:
280         * DOM/DOMUtility.mm:
281         (createDOMWrapper):
282
283 2016-12-16  Chris Dumez  <cdumez@apple.com>
284
285         HTML form validation bubble should be dismissed on navigation
286         https://bugs.webkit.org/show_bug.cgi?id=165960
287         <rdar://problem/29668086>
288
289         Reviewed by Simon Fraser.
290
291         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
292
293         * WebView/WebView.mm:
294         (-[WebView _didStartProvisionalLoadForFrame:]):
295
296 2016-12-15  Darin Adler  <darin@apple.com>
297
298         Use asString instead of toWTFString, toString, or getString when we already checked isString
299         https://bugs.webkit.org/show_bug.cgi?id=165895
300
301         Reviewed by Yusuke Suzuki.
302
303         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
304         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
305         toWTFString.
306         * WebView/WebView.mm:
307         (aeDescFromJSValue): Use asString/value instead of getString.
308
309 2016-12-15  Chris Dumez  <cdumez@apple.com>
310
311         Make sure HTML validation bubble's state is updated after layout
312         https://bugs.webkit.org/show_bug.cgi?id=165922
313         <rdar://problem/29694730>
314
315         Reviewed by Simon Fraser.
316
317         Make sure HTML validation bubble's state is updated after layout.
318         In particular, if the validation bubble's associated element has
319         moved or is no longer visible, we now hide the bubble.
320
321         * WebCoreSupport/WebValidationMessageClient.h:
322         * WebCoreSupport/WebValidationMessageClient.mm:
323         (WebValidationMessageClient::showValidationMessage):
324         (WebValidationMessageClient::hideValidationMessage):
325         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
326
327 2016-12-15  Chris Dumez  <cdumez@apple.com>
328
329         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
330         https://bugs.webkit.org/show_bug.cgi?id=165904
331
332         Reviewed by Sam Weinig.
333
334         Update ObjC bindings so they keep building.
335
336         * DOM/DOMUIEvent.mm:
337         (-[DOMUIEvent keyCode]):
338         (-[DOMUIEvent charCode]):
339
340 2016-12-15  Andreas Kling  <akling@apple.com>
341
342         Always clear RenderLayer backing stores when going into page cache.
343         <https://webkit.org/b/165901>
344
345         Reviewed by Simon Fraser.
346
347         * WebView/WebView.mm:
348         (+[WebView _setCacheModel:]):
349
350 2016-12-12  Alex Christensen  <achristensen@webkit.org>
351
352         Remove unused workaround for Silverlight
353         https://bugs.webkit.org/show_bug.cgi?id=165773
354
355         Reviewed by Dean Jackson.
356
357         * Plugins/WebNetscapePluginView.mm:
358         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
359         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
360         Allowing 6 years for users to update Silverlight is more than enough.
361         Safari doesn't even use WebKit1 for this any more.
362         I need this to be removed because this is the only non-WebGL code that needs to link against
363         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
364
365 2016-12-12  Chris Dumez  <cdumez@apple.com>
366
367         Document.visibilityState should use an IDL string enumeration
368         https://bugs.webkit.org/show_bug.cgi?id=165774
369
370         Reviewed by Daniel Bates.
371
372         * DOM/DOMDocument.mm:
373         (-[DOMDocument visibilityState]):
374         * WebView/WebView.mm:
375         (kit):
376
377 2016-12-12  Jer Noble  <jer.noble@apple.com>
378
379         Remove implementation of legacy Mozilla-based Fullscreen API.
380         https://bugs.webkit.org/show_bug.cgi?id=165689
381         <rdar://problem/29603053>
382
383         Reviewed by Eric Carlson.
384
385         * DOM/DOMElement.mm:
386         (-[DOMElement webkitRequestFullScreen:]):
387
388 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
389
390         The DOM should have an advancing wavefront opaque root barrier
391         https://bugs.webkit.org/show_bug.cgi?id=165712
392
393         Reviewed by Yusuke Suzuki.
394         
395         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
396
397         * Misc/WebCoreStatistics.mm:
398         (+[WebCoreStatistics javaScriptObjectsCount]):
399         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
400         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
401         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
402         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
403         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
404         (+[WebCoreStatistics shouldPrintExceptions]):
405         (+[WebCoreStatistics setShouldPrintExceptions:]):
406         (+[WebCoreStatistics memoryStatistics]):
407         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
408         * Plugins/Hosted/NetscapePluginHostProxy.mm:
409         (identifierFromIdentifierRep):
410         * Plugins/Hosted/ProxyInstance.mm:
411         (WebKit::ProxyInstance::getPropertyNames):
412         * Plugins/WebNetscapePluginStream.mm:
413         (WebNetscapePluginStream::wantsAllStreams):
414         * Plugins/WebNetscapePluginView.mm:
415         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
416         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
417         (-[WebNetscapePluginView setWindowIfNecessary]):
418         (-[WebNetscapePluginView createPluginScriptableObject]):
419         (-[WebNetscapePluginView getFormValue:]):
420         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
421         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
422         (-[WebNetscapePluginView loadPluginRequest:]):
423         (-[WebNetscapePluginView _printedPluginBitmap]):
424         * Plugins/WebPluginController.mm:
425         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
426         (-[WebPluginController stopOnePlugin:]):
427         (-[WebPluginController stopOnePluginForPageCache:]):
428         (-[WebPluginController destroyOnePlugin:]):
429         (-[WebPluginController startAllPlugins]):
430         (-[WebPluginController addPlugin:]):
431
432 2016-12-09  Dave Hyatt  <hyatt@apple.com>
433
434         [CSS Parser] Remove the old CSS Parser
435         https://bugs.webkit.org/show_bug.cgi?id=165645
436
437         Reviewed by Daniel Bates.
438
439         * DOM/DOMCSS.mm:
440         (kitClass):
441         * DOM/DOMCSSRule.h:
442
443 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
444
445         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
446         https://bugs.webkit.org/show_bug.cgi?id=165251
447
448         Reviewed by Dean Jackson.
449
450         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
451
452         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
453         * WebView/WebPreferences.mm:
454         (+[WebPreferences initialize]):
455         (-[WebPreferences mediaStreamEnabled]):
456         (-[WebPreferences setMediaStreamEnabled:]):
457         (-[WebPreferences peerConnectionEnabled]):
458         (-[WebPreferences setPeerConnectionEnabled:]):
459         * WebView/WebPreferencesPrivate.h:
460         * WebView/WebView.mm:
461         (-[WebView _preferencesChanged:]):
462
463 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
464
465         Don’t expose pointer lock in WebKit1 Objective-C API
466         https://bugs.webkit.org/show_bug.cgi?id=165692
467
468         Reviewed by Simon Fraser.
469
470         * DOM/DOMDocument.mm:
471         (-[DOMDocument pointerLockElement]): Deleted.
472         (-[DOMDocument exitPointerLock]): Deleted.
473         * DOM/DOMElement.mm:
474         (-[DOMElement requestPointerLock]): Deleted.
475         * DOM/DOMMouseEvent.mm:
476         (-[DOMMouseEvent movementX]): Deleted.
477         (-[DOMMouseEvent movementY]): Deleted.
478
479 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
480
481         document.webkitFullscreenElement leaks elements inside a shadow tree
482         https://bugs.webkit.org/show_bug.cgi?id=158471
483
484         Reviewed by Chris Dumez.
485
486         Use the API for bindings to avoid exposing nodes inside a shadow tree.
487
488         * DOM/DOMDocument.mm:
489         (-[DOMDocument webkitCurrentFullScreenElement]):
490         (-[DOMDocument webkitFullscreenElement]):
491
492 2016-12-09  Beth Dakin  <bdakin@apple.com>
493
494         Password fields should not show the emoji button in TouchBar
495         https://bugs.webkit.org/show_bug.cgi?id=165673
496         -and corresponding-
497         rdar://problem/29235739
498
499         Reviewed by Wenson Hsieh.
500
501         This patch adds a new ivar for the password touch bar and password 
502         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
503         of identifiers than the plain text TouchBar, it should just have its own variable.
504
505         The candidate list should be the only item for passwords.
506         * WebView/WebView.mm:
507         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
508
509         Account for _passwordTextTouchBar.
510         (-[WebView didChangeAutomaticTextCompletion:]):
511         (-[WebView setUpTextTouchBar:]):
512         (-[WebView textTouchBar]):
513
514         The empty candidates array is not needed. We can just set @[ ] as the candidates 
515         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
516         other parts of the code to prevent us from requesting or setting other candidates 
517         when in a password field. 
518         (-[WebView updateTextTouchBar]):
519
520         Account for _passwordTextTouchBar.
521         (-[WebView candidateList]):
522         * WebView/WebViewData.h:
523
524 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
525
526         Enable SharedArrayBuffer, remove the flag
527         https://bugs.webkit.org/show_bug.cgi?id=165614
528
529         Rubber stamped by Geoffrey Garen.
530
531         * WebView/WebPreferencesPrivate.h:
532
533 2016-12-07  Dean Jackson  <dino@apple.com>
534
535         Remove runtime toggle for pointer-lock
536         https://bugs.webkit.org/show_bug.cgi?id=165577
537         <rdar://problems/29566996>
538
539         Reviewed by Jon Lee.
540
541         Remove any runtime calls to check if pointer-lock is enabled. It's
542         either compiled in or out.
543
544         * WebView/WebPreferenceKeysPrivate.h:
545         * WebView/WebPreferences.mm:
546         (-[WebPreferences pointerLockEnabled]): Deleted.
547         (-[WebPreferences setPointerLockEnabled:]): Deleted.
548         * WebView/WebPreferencesPrivate.h:
549         * WebView/WebView.mm:
550         (-[WebView _preferencesChanged:]):
551
552 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
553
554         Correct SDKROOT values in xcconfig files
555         https://bugs.webkit.org/show_bug.cgi?id=165487
556         rdar://problem/29539209
557
558         Reviewed by Dan Bernstein.
559
560         Fix suggested by Dan Bernstein.
561
562         * Configurations/DebugRelease.xcconfig:
563
564 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
565
566         Improve the behavior of scroll-into-view when the target is inside position:fixed
567         https://bugs.webkit.org/show_bug.cgi?id=165354
568
569         Reviewed by Zalan Bujtas.
570
571         Plumb through 'insideFixed'. We don't get compute it, so behavior from
572         these call sites won't change.
573
574         * WebView/WebFrame.mm:
575         (-[WebFrame _scrollDOMRangeToVisible:]):
576         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
577
578 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
579
580         Enable visual viewports by default on Mac, and iOS Wk2
581         https://bugs.webkit.org/show_bug.cgi?id=165452
582
583         Reviewed by Zalan Bujtas.
584
585         Turn visual viewports on by default for WK1 on Mac.
586
587         * WebView/WebPreferences.mm:
588         (+[WebPreferences initialize]):
589
590 2016-12-05  Dean Jackson  <dino@apple.com>
591
592         pointer lock needs to be feature detectable
593         https://bugs.webkit.org/show_bug.cgi?id=165426
594         <rdar://problem/29486715>
595
596         Reviewed by Antoine Quint.
597
598         Set the RuntimeEnabledFeature as preferences
599         change.
600
601         * WebView/WebView.mm:
602         (-[WebView _preferencesChanged:]):
603
604 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
605
606         Unreviewed, rolling out r209299.
607
608         This change appears to have caused LayoutTest failures on
609         Sierra WK1.
610
611         Reverted changeset:
612
613         "Improve the behavior of scroll-into-view when the target is
614         inside position:fixed"
615         https://bugs.webkit.org/show_bug.cgi?id=165354
616         http://trac.webkit.org/changeset/209299
617
618 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
619
620         Improve the behavior of scroll-into-view when the target is inside position:fixed
621         https://bugs.webkit.org/show_bug.cgi?id=165354
622
623         Reviewed by Zalan Bujtas.
624
625         Plumb through 'insideFixed'. We don't get compute it, so behavior from
626         these call sites won't change.
627
628         * WebView/WebFrame.mm:
629         (-[WebFrame _scrollDOMRangeToVisible:]):
630         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
631
632 2016-12-02  Andy Estes  <aestes@apple.com>
633
634         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
635         https://bugs.webkit.org/show_bug.cgi?id=164492
636
637         Reviewed by Dan Bernstein.
638
639         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
640         com.apple.$(PRODUCT_NAME:rfc1034identifier).
641         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
642         ${PRODUCT_BUNDLE_IDENTIFIER}.
643
644 2016-12-02  Chris Dumez  <cdumez@apple.com>
645
646         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
647         https://bugs.webkit.org/show_bug.cgi?id=165328
648
649         Reviewed by Simon Fraser.
650
651         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
652
653         * WebView/WebViewData.mm:
654         (-[WebViewPrivate init]):
655
656 2016-12-02  Chris Dumez  <cdumez@apple.com>
657
658         [Mac][WK1] Implement new HTML interactive form validation user interface
659         https://bugs.webkit.org/show_bug.cgi?id=164483
660
661         Reviewed by Simon Fraser.
662
663         Implement new HTML interactive form validation user interface on Mac
664         WK1 and enable it by default.
665
666         * WebCoreSupport/WebValidationMessageClient.h: Added.
667         * WebCoreSupport/WebValidationMessageClient.mm: Added.
668         (WebValidationMessageClient::WebValidationMessageClient):
669         (WebValidationMessageClient::~WebValidationMessageClient):
670         (WebValidationMessageClient::showValidationMessage):
671         (WebValidationMessageClient::hideValidationMessage):
672         (WebValidationMessageClient::isValidationMessageVisible):
673         * WebView/WebHTMLView.mm:
674         (-[WebHTMLView _frameOrBoundsChanged]):
675         * WebView/WebView.mm:
676         (-[WebView _commonInitializationWithFrameName:groupName:]):
677         (-[WebView _willStartScrollingOrZooming]):
678         (-[WebView _contentsOfUserInterfaceItem:]):
679         (-[WebView _scaleWebView:atOrigin:]):
680         (-[WebView _didScrollDocumentInFrameView:]):
681         (-[WebView _setZoomMultiplier:isTextOnly:]):
682         (-[WebView showFormValidationMessage:withAnchorRect:]):
683         (-[WebView hideFormValidationMessage]):
684         * WebView/WebViewData.h:
685         * WebView/WebViewData.mm:
686         (-[WebViewPrivate init]):
687         * WebView/WebViewInternal.h:
688         * WebView/WebViewPrivate.h:
689
690 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
691
692         Add a runtime flag for SubtleCrypto
693         https://bugs.webkit.org/show_bug.cgi?id=164982
694
695         Reviewed by Brent Fulgham.
696
697         * WebView/WebPreferenceKeysPrivate.h:
698         * WebView/WebPreferences.mm:
699         (+[WebPreferences initialize]):
700         (-[WebPreferences subtleCryptoEnabled]):
701         (-[WebPreferences setSubtleCryptoEnabled:]):
702         * WebView/WebPreferencesPrivate.h:
703         * WebView/WebView.mm:
704         (-[WebView _preferencesChanged:]):
705
706 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
707
708         Add separate settings and preferences to enable/disable async decoding for large images and animated images
709         https://bugs.webkit.org/show_bug.cgi?id=165177
710
711         Reviewed by Simon Fraser.
712         
713         Hook up the async image decoding settings for WebKit1.
714
715         * WebView/WebPreferenceKeysPrivate.h:
716         * WebView/WebPreferences.mm:
717         (+[WebPreferences initialize]):
718         (-[WebPreferences largeImageAsyncDecodingEnabled]):
719         (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
720         (-[WebPreferences animatedImageAsyncDecodingEnabled]):
721         (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
722         (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
723         (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
724         * WebView/WebPreferencesPrivate.h:
725         * WebView/WebView.mm:
726         (-[WebView _preferencesChanged:]):
727
728 2016-11-29  Andy Estes  <aestes@apple.com>
729
730         [Cocoa] Enable two clang warnings recommended by Xcode
731         https://bugs.webkit.org/show_bug.cgi?id=164498
732
733         Reviewed by Mark Lam.
734
735         * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
736
737 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
738
739         [WTF] Import std::optional reference implementation as WTF::Optional
740         https://bugs.webkit.org/show_bug.cgi?id=164199
741
742         Reviewed by Saam Barati and Sam Weinig.
743
744         Use WTF::Optional::value_or.
745
746         * DOM/DOMHTMLOptionsCollection.mm:
747         (-[DOMHTMLOptionsCollection add:index:]):
748         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
749         (WebKit::NetscapePluginInstanceProxy::evaluate):
750         * Plugins/WebNetscapePluginView.mm:
751         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
752         * WebCoreSupport/WebFrameLoaderClient.h:
753         * WebCoreSupport/WebFrameLoaderClient.mm:
754         (WebFrameLoaderClient::dispatchDidCommitLoad):
755         * WebCoreSupport/WebPaymentCoordinatorClient.h:
756         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
757         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
758         (WebPaymentCoordinatorClient::completeShippingContactSelection):
759         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
760         * WebCoreSupport/WebSecurityOrigin.mm:
761         (-[WebSecurityOrigin port]):
762         * WebView/WebHTMLView.mm:
763         (toAction):
764         (toTag):
765
766 2016-11-26  Sam Weinig  <sam@webkit.org>
767
768         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
769         https://bugs.webkit.org/show_bug.cgi?id=164965
770
771         Reviewed by Simon Fraser.
772
773         * WebView/WebPreferenceKeysPrivate.h:
774         * WebView/WebPreferences.mm:
775         (-[WebPreferences intersectionObserverEnabled]):
776         (-[WebPreferences setIntersectionObserverEnabled:]):
777         * WebView/WebPreferencesPrivate.h:
778         * WebView/WebView.mm:
779         (-[WebView _preferencesChanged:]):
780         Add a preference, defaulting to off, for enabling IntersectionObserver.
781
782 2016-11-22  Dan Bernstein  <mitz@apple.com>
783
784         [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
785         https://bugs.webkit.org/show_bug.cgi?id=165036
786         <rdar://problem/5708580>
787
788         Reviewed by Alexey Proskuryakov.
789
790         * WebView/WebHTMLView.mm:
791         (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
792           similarly to what we do in -keyDown: and to what WKWebView does with all key events.
793
794 2016-11-21  Alex Christensen  <achristensen@webkit.org>
795
796         Fix Sierra CMake build after r208452
797         https://bugs.webkit.org/show_bug.cgi?id=164437
798
799         * WebView/WebView.mm:
800         (-[WebView updateMediaTouchBar]):
801         I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
802         It's needed for playbackSessionInterface to exist.
803
804 2016-11-18  Enrica Casucci  <enrica@apple.com>
805
806         Refactor drag and drop for WebKit2 to encode DragData message exchange.
807         https://bugs.webkit.org/show_bug.cgi?id=164945
808
809         Reviewed by Tim Horton.
810
811         * WebCoreSupport/WebDragClient.h:
812         * WebCoreSupport/WebDragClient.mm:
813         (WebDragClient::actionMaskForDrag):
814         (WebDragClient::willPerformDragDestinationAction):
815
816 2016-11-18  Jeremy Jones  <jeremyj@apple.com>
817
818         Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
819         https://bugs.webkit.org/show_bug.cgi?id=163801
820
821         Reviewed by Simon Fraser.
822
823         Plumb through PointerLockEnabled setting.
824
825         * Configurations/FeatureDefines.xcconfig:
826         * WebCoreSupport/WebChromeClient.mm:
827         (WebChromeClient::requestPointerUnlock):
828         * WebView/WebPreferenceKeysPrivate.h:
829         * WebView/WebPreferences.mm:
830         (-[WebPreferences pointerLockEnabled]):
831         (-[WebPreferences setPointerLockEnabled:]):
832         * WebView/WebPreferencesPrivate.h:
833         * WebView/WebView.mm:
834         (-[WebView _preferencesChanged:]):
835
836 2016-11-17  Dan Bernstein  <mitz@apple.com>
837
838         Try to fix some non-macOS builds.
839
840         * WebView/WebView.mm:
841
842 2016-11-16  Dave Hyatt  <hyatt@apple.com>
843
844         [CSS Parser] Add @supports, @keyframe and media query parsing options
845         https://bugs.webkit.org/show_bug.cgi?id=164821
846
847         Reviewed by Sam Weinig and Zalan Bujtas.
848
849         Fix up the create call now that fallback descriptor syntax is gone.
850
851         * DOM/DOM.mm:
852         (-[DOMHTMLLinkElement _mediaQueryMatches]):
853
854 2016-11-17  Saam Barati  <sbarati@apple.com>
855
856         Remove async/await compile time flag and enable tests
857         https://bugs.webkit.org/show_bug.cgi?id=164828
858         <rdar://problem/28639334>
859
860         Reviewed by Yusuke Suzuki.
861
862         * Configurations/FeatureDefines.xcconfig:
863
864 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
865
866         [JSC] WTF::TemporaryChange with WTF::SetForScope
867         https://bugs.webkit.org/show_bug.cgi?id=164761
868
869         Reviewed by Saam Barati.
870
871         * WebView/WebView.mm:
872         (-[WebView updateTextTouchBar]):
873
874 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
875
876         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
877         https://bugs.webkit.org/show_bug.cgi?id=164827
878
879         Reviewed by Ryosuke Niwa.
880
881         * Configurations/FeatureDefines.xcconfig:
882         * WebView/WebPreferenceKeysPrivate.h:
883         * WebView/WebPreferences.mm:
884         (+[WebPreferences initialize]):
885         (-[WebPreferences es6ModulesEnabled]):
886         (-[WebPreferences setES6ModulesEnabled:]):
887         * WebView/WebPreferencesPrivate.h:
888         * WebView/WebView.mm:
889         (-[WebView _preferencesChanged:]):
890
891 2016-11-14  Alex Christensen  <achristensen@webkit.org>
892
893         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
894         https://bugs.webkit.org/show_bug.cgi?id=164720
895
896         Reviewed by Brady Eidson.
897
898         * Storage/WebDatabaseManager.mm:
899         (-[WebDatabaseManager origins]):
900         (-[WebDatabaseManager databasesWithOrigin:]):
901         (-[WebDatabaseManager deleteOrigin:]):
902         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
903         * Storage/WebDatabaseManagerClient.h:
904         * Storage/WebDatabaseManagerClient.mm:
905         (DidModifyOriginData::dispatchToMainThread):
906         (DidModifyOriginData::DidModifyOriginData):
907         (WebDatabaseManagerClient::dispatchDidModifyOrigin):
908         (WebDatabaseManagerClient::dispatchDidModifyDatabase):
909         * Storage/WebDatabaseQuotaManager.mm:
910         (-[WebDatabaseQuotaManager usage]):
911         (-[WebDatabaseQuotaManager quota]):
912         (-[WebDatabaseQuotaManager setQuota:]):
913         * Storage/WebStorageManager.mm:
914         (-[WebStorageManager origins]):
915         (-[WebStorageManager deleteOrigin:]):
916         * Storage/WebStorageTrackerClient.h:
917         * Storage/WebStorageTrackerClient.mm:
918         (WebStorageTrackerClient::dispatchDidModifyOrigin):
919         * WebCoreSupport/WebSecurityOrigin.mm:
920         (-[WebSecurityOrigin usage]):
921         (-[WebSecurityOrigin quota]):
922         (-[WebSecurityOrigin setQuota:]):
923
924 2016-11-13  Darin Adler  <darin@apple.com>
925
926         Fix exception handling in SQL database code, streamline and update code
927         https://bugs.webkit.org/show_bug.cgi?id=164685
928
929         Reviewed by Sam Weinig.
930
931         * Storage/WebDatabaseManager.mm:
932         (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
933         a reference.
934         (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
935         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
936         but continue to use DatabaseManager.
937         (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
938         reference.
939         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
940
941         * Storage/WebDatabaseManagerClient.h: Updated to take references.
942         * Storage/WebDatabaseManagerClient.mm:
943         (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
944         members in the class definition.
945         (DidModifyOriginData::dispatchToMainThread): Take references.
946         (DidModifyOriginData::DidModifyOriginData): Ditto.
947         (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
948         (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
949         (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
950         DatabaseTracker::singleton instead of tracker.
951
952         * Storage/WebDatabaseQuotaManager.mm:
953         (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
954         (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
955         (-[WebDatabaseQuotaManager quota]): Ditto.
956         (-[WebDatabaseQuotaManager setQuota:]): Ditto.
957         * WebCoreSupport/WebSecurityOrigin.mm:
958         (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
959         (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
960         (-[WebSecurityOrigin quota]): Ditto.
961         (-[WebSecurityOrigin setQuota:]): Ditto.
962         * WebView/WebFrame.mm:
963         (-[WebFrame _cacheabilityDictionary]): Pass a reference.
964
965 2016-11-12  Darin Adler  <darin@apple.com>
966
967         Remove a few assorted uses of ExceptionCode
968         https://bugs.webkit.org/show_bug.cgi?id=164683
969
970         Reviewed by Chris Dumez.
971
972         * DOM/DOMDOMImplementation.mm:
973         (-[DOMImplementation createDocumentType:publicId:systemId:]):
974         Use raiseOnDOMError instead of much longer hand written equivalent.
975         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
976
977         * DOM/DOMDocument.mm:
978         (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
979         so we are not using a specific exception code.
980
981         * DOM/DOMHTMLOptionsCollection.mm:
982         (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
983         much longer hand written equivalent.
984         * DOM/DOMHTMLSelectElement.mm:
985         (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
986         statement after calling a "no return" function.
987
988         * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
989         raiseOnDOMError functions that take ExceptionCode; keep the ones that take
990         Exception and ExceptionOr. Renamed the other overload of raiseDOMException
991         to raiseDOMErrorException; it is only used as the non-inline implementation
992         part of the inline raiseOnDOMError function.
993         * DOM/ExceptionHandlers.mm:
994         (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
995         to this source file instead of in the header.
996         (raiseTypeErrorException): Updated for name change.
997         (raiseNotSupportedErrorException): Added.
998
999 2016-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1000
1001         Hovering over a slotted Text node clears hover state
1002         https://bugs.webkit.org/show_bug.cgi?id=164002
1003         <rdar://problem/29040471>
1004
1005         Reviewed by Simon Fraser.
1006
1007         * WebView/WebImmediateActionController.mm:
1008         (-[WebImmediateActionController performHitTestAtPoint:]):
1009
1010 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1011
1012         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
1013         https://bugs.webkit.org/show_bug.cgi?id=164538
1014         <rdar://problem/8418711>
1015
1016         Reviewed by Ryosuke Niwa.
1017
1018         Account for renaming HTMLElement::autocorrect to HTMLElement::shouldAutocorrect, as well as moving
1019         WebAutocapitalizeType to WebKit from WebCore. Additionally, moves the -autocorrect and -autocapitalize SPIs out
1020         of HTML(Input|Form|TextArea)ElementPrivate.h and into HTMLElementPrivate.h. This also means removing redundant
1021         code for interfacing with the unwrapped HTMLElement's autocorrect and autocapitalize attributes.
1022
1023         * DOM/DOMHTML.mm:
1024         (webAutocapitalizeType):
1025         (-[DOMHTMLInputElement _autocapitalizeType]):
1026         (-[DOMHTMLTextAreaElement _autocapitalizeType]):
1027         * DOM/DOMHTMLElement.mm:
1028         (-[DOMHTMLElement autocorrect]):
1029         (-[DOMHTMLElement setAutocorrect:]):
1030         (-[DOMHTMLElement autocapitalize]):
1031         (-[DOMHTMLElement setAutocapitalize:]):
1032         * DOM/DOMHTMLElementPrivate.h: Copied from Source/WebCore/html/Autocapitalize.h.
1033         * DOM/DOMHTMLFormElement.mm:
1034         (-[DOMHTMLFormElement autocorrect]): Deleted.
1035         (-[DOMHTMLFormElement setAutocorrect:]): Deleted.
1036         (-[DOMHTMLFormElement autocapitalize]): Deleted.
1037         (-[DOMHTMLFormElement setAutocapitalize:]): Deleted.
1038         * DOM/DOMHTMLInputElement.mm:
1039         (-[DOMHTMLInputElement autocorrect]): Deleted.
1040         (-[DOMHTMLInputElement setAutocorrect:]): Deleted.
1041         (-[DOMHTMLInputElement autocapitalize]): Deleted.
1042         (-[DOMHTMLInputElement setAutocapitalize:]): Deleted.
1043         * DOM/DOMHTMLInputElementPrivate.h:
1044         * DOM/DOMHTMLTextAreaElement.mm:
1045         (-[DOMHTMLTextAreaElement autocorrect]): Deleted.
1046         (-[DOMHTMLTextAreaElement setAutocorrect:]): Deleted.
1047         (-[DOMHTMLTextAreaElement autocapitalize]): Deleted.
1048         (-[DOMHTMLTextAreaElement setAutocapitalize:]): Deleted.
1049         * DOM/DOMHTMLTextAreaElementPrivate.h:
1050
1051         We need to import DOMHTMLElementPrivate.h here to avoid breaking UIKit. We should follow this up with a UIKit
1052         change to import DOMHTMLElementPrivate.h directly.
1053
1054         * DOM/DOMPrivate.h:
1055         * DOM/WebAutocapitalizeTypes.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h.
1056         * MigrateHeaders.make:
1057
1058 2016-11-11  Beth Dakin  <bdakin@apple.com>
1059
1060         Move to modern TouchBar methods
1061         https://bugs.webkit.org/show_bug.cgi?id=164655
1062         -and corresponding-
1063         rdar://problem/29226911
1064
1065         Reviewed by Wenson Hsieh.
1066
1067         customizationDefaultItemIdentifiers -> defaultItemIdentifiers
1068         itemIdentifiers -> defaultItemIdentifiers
1069         defaultItems -> templateItems
1070
1071         * WebView/WebView.mm:
1072         (-[WebView _plainTextTouchBarDefaultItemIdentifiers]):
1073         (-[WebView _richTextTouchBarDefaultItemIdentifiers]):
1074         (-[WebView setUpTextTouchBar:]):
1075         (-[WebView updateTextTouchBar]):
1076         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1077         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1078
1079 2016-11-11  Darin Adler  <darin@apple.com>
1080
1081         Move Node from ExceptionCode to ExceptionOr
1082         https://bugs.webkit.org/show_bug.cgi?id=164515
1083
1084         Reviewed by Sam Weinig.
1085
1086         * DOM/DOMHTMLSelectElement.mm:
1087         (-[DOMHTMLSelectElement remove:]): Call remove instead of removeByIndex
1088         now that it was renamed.
1089         * DOM/DOMNode.mm:
1090         (-[DOMNode setNodeValue:]): Updated exception handling.
1091         (-[DOMNode setPrefix:]): Ditto.
1092         (-[DOMNode setTextContent:]): Ditto.
1093         (-[DOMNode insertBefore:refChild:]): Ditto.
1094         (-[DOMNode replaceChild:oldChild:]): Ditto.
1095         (-[DOMNode removeChild:]): Ditto.
1096         (-[DOMNode appendChild:]): Ditto.
1097         (-[DOMNode cloneNode:]): Ditto.
1098
1099 2016-11-11  Beth Dakin  <bdakin@apple.com>
1100
1101         Get touch bar code building for open source builds
1102         https://bugs.webkit.org/show_bug.cgi?id=164610
1103
1104         Reviewed by Wenson Hsieh.
1105
1106         * WebKitPrefix.h:
1107
1108 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1109
1110         Fix assertion after r208534.
1111         https://bugs.webkit.org/show_bug.cgi?id=160497
1112
1113         * WebView/WebView.mm:
1114         (-[WebView _commonInitializationWithFrameName:groupName:]):
1115         (WebInstallMemoryPressureHandler):
1116         WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
1117         When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
1118         only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
1119
1120 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1121
1122         Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
1123         https://bugs.webkit.org/show_bug.cgi?id=164573
1124
1125         Reviewed by Brady Eidson.
1126
1127         * WebCoreSupport/WebSecurityOrigin.mm:
1128         (-[WebSecurityOrigin databaseIdentifier]):
1129
1130 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1131
1132         MemoryPressureHandler shouldn't know how to release WebCore memory
1133         https://bugs.webkit.org/show_bug.cgi?id=160497
1134
1135         Reviewed by Michael Catanzaro.
1136
1137         Set the low memory handler before installing the memory pressure handler.
1138
1139         * WebView/WebView.mm:
1140         (-[WebView _commonInitializationWithFrameName:groupName:]):
1141
1142 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
1143
1144         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
1145         https://bugs.webkit.org/show_bug.cgi?id=164501
1146         <rdar://problem/29152282>
1147
1148         Reviewed by Sam Weinig.
1149
1150         Align what [WebHTMLView attributedString] returns to what would be used on copy & paste by using HTMLConverter
1151         instead of _initWithDOMRange in [WebHTMLView _attributeStringFromDOMRange].
1152
1153         * WebView/WebHTMLView.mm:
1154         (-[WebHTMLView _attributedStringFromDOMRange:]): Renamed from _attributeStringFromDOMRange.
1155         (-[WebHTMLView attributedString]):
1156         (-[WebHTMLView selectedAttributedString]):
1157         (-[WebHTMLView selectedString]): Moved to reduce the number of occurrences of the if-defs.
1158
1159 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
1160
1161         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
1162         https://bugs.webkit.org/show_bug.cgi?id=155185
1163         <rdar://problem/11101440>
1164
1165         Reviewed by Brady Eidson.
1166
1167         Provide SPI to access the new quirk for localStorage. The quirk defaults to 'on'. When active, this
1168         quirk says that localStorage access should be granted, without needing to grant universal file access.
1169
1170         If the quirk is turned off, then localStorage is blocked unless the WebKit client explicitly
1171         grants universal file access.
1172
1173         * WebView/WebPreferenceKeysPrivate.h:
1174         * WebView/WebPreferences.mm:
1175         (-[WebPreferences needsLocalStorageQuirk]): Added.
1176         (-[WebPreferences setNeedsLocalStorageQuirk:]): Added.
1177         * WebView/WebPreferencesPrivate.h:
1178         * WebView/WebView.mm:
1179         (-[WebView _preferencesChanged:]): Honor the new localStorage quirk.
1180
1181 2016-11-09  Alex Christensen  <achristensen@webkit.org>
1182
1183         Clean up Storage code
1184         https://bugs.webkit.org/show_bug.cgi?id=164562
1185
1186         Reviewed by Brady Eidson.
1187
1188         * Storage/WebStorageManager.mm:
1189         (-[WebStorageManager origins]):
1190         (-[WebStorageManager deleteAllOrigins]):
1191         (-[WebStorageManager deleteOrigin:]):
1192         (-[WebStorageManager diskUsageForOrigin:]):
1193         (-[WebStorageManager syncLocalStorage]):
1194         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
1195         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
1196         (+[WebStorageManager closeIdleLocalStorageDatabases]):
1197         (WebKitInitializeStorageIfNecessary):
1198         * WebView/WebView.mm:
1199         (+[WebView _applicationWillTerminate]):
1200
1201 2016-11-09  Beth Dakin  <bdakin@apple.com>
1202
1203         Another attempted build fix.
1204
1205         * WebView/WebView.mm:
1206
1207 2016-11-09  Beth Dakin  <bdakin@apple.com>
1208
1209         Attempted build fix.
1210
1211         * WebView/WebView.mm:
1212
1213 2016-11-09  Darin Adler  <darin@apple.com>
1214
1215         Move Range from ExceptionCode to ExceptionOr
1216         https://bugs.webkit.org/show_bug.cgi?id=164457
1217
1218         Reviewed by Alex Christensen.
1219
1220         * DOM/DOMRange.mm:
1221         (-[DOMRange setStart:offset:]): Updated exception handling.
1222         (-[DOMRange setEnd:offset:]): Ditto.
1223         (-[DOMRange setStartBefore:]): Ditto.
1224         (-[DOMRange setStartAfter:]): Ditto.
1225         (-[DOMRange setEndBefore:]): Ditto.
1226         (-[DOMRange setEndAfter:]): Ditto.
1227         (-[DOMRange selectNode:]): Ditto.
1228         (-[DOMRange selectNodeContents:]): Ditto.
1229         (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
1230         (-[DOMRange deleteContents]): Ditto.
1231         (-[DOMRange extractContents]): Ditto.
1232         (-[DOMRange cloneContents]): Ditto.
1233         (-[DOMRange insertNode:]): Ditto.
1234         (-[DOMRange surroundContents:]): Ditto.
1235         (-[DOMRange createContextualFragment:]): Ditto.
1236         (-[DOMRange compareNode:]): Ditto.
1237         (-[DOMRange intersectsNode:]): Ditto.
1238         (-[DOMRange comparePoint:offset:]): Ditto.
1239         (-[DOMRange isPointInRange:offset:]): Ditto.
1240         (-[DOMRange expand:]): Ditto.
1241         * WebView/WebFrame.mm:
1242         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
1243         (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
1244         This function was incorrectly implemented (set both start and end of
1245         the range to the computed start), not declared in any header file,
1246         not used anywhere inside WebKit, and I also could not find a use of it
1247         in outside-WebKit Apple code.
1248         * mac/DOM/DOMUIKitExtensions.mm:
1249         (-[DOMRange move:inDirection:]): Ditto.
1250         (-[DOMRange extend:inDirection:]): Ditto.
1251
1252 2016-11-09  Darin Adler  <darin@apple.com>
1253
1254         Move EventTarget from ExceptionCode to ExceptionOr
1255         https://bugs.webkit.org/show_bug.cgi?id=164465
1256
1257         Reviewed by Youenn Fablet.
1258
1259         * DOM/DOMNode.mm:
1260         (-[DOMNode dispatchEvent:]): Updated exception handling.
1261
1262 2016-11-09  Chris Dumez  <cdumez@apple.com>
1263
1264         [Mac] Stop using deprecated AppKit enumeration values
1265         https://bugs.webkit.org/show_bug.cgi?id=164494
1266
1267         Reviewed by Darin Adler.
1268
1269         Stop using deprecated AppKit enumeration values.
1270
1271         * Carbon/CarbonWindowAdapter.mm:
1272         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1273         (-[CarbonWindowAdapter sendSuperEvent:]):
1274         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1275         (WebKit::NetscapePluginHostProxy::beginModal):
1276         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1277         (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
1278         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1279         (-[WebHostedNetscapePluginView drawRect:]):
1280         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1281         (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
1282         * WebCoreSupport/PopupMenuMac.mm:
1283         (PopupMenuMac::populate):
1284         (PopupMenuMac::show):
1285         * WebCoreSupport/WebContextMenuClient.mm:
1286         (WebContextMenuClient::showContextMenu):
1287         * WebCoreSupport/WebFrameLoaderClient.mm:
1288         (WebFrameLoaderClient::actionDictionary):
1289         * WebCoreSupport/WebInspectorClient.mm:
1290         (WebInspectorFrontendClient::canAttach):
1291         (-[WebInspectorWindowController window]):
1292         * WebInspector/WebNodeHighlight.mm:
1293         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1294         * WebView/WebFrameView.mm:
1295         (-[WebFrameView keyDown:keyDown:]):
1296         * WebView/WebFullScreenController.mm:
1297         (-[WebFullScreenController init]):
1298         (createBackgroundFullscreenWindow):
1299         * WebView/WebHTMLView.mm:
1300         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
1301         (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
1302         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1303         (isQuickLookEvent):
1304         (-[WebHTMLView hitTest:]):
1305         (-[WebHTMLView _sendToolTipMouseExited]):
1306         (-[WebHTMLView _sendToolTipMouseEntered]):
1307         (mouseEventIsPartOfClickOrDrag):
1308         (-[WebHTMLView _updateMouseoverWithEvent:]):
1309         (-[WebHTMLView _autoscroll]):
1310         (-[WebHTMLView acceptsFirstResponder]):
1311         (-[WebHTMLView viewDidMoveToWindow]):
1312         (-[WebHTMLView mouseDown:mouseDown:]):
1313         (currentKeyboardEvent):
1314         (-[WebHTMLView _handleStyleKeyEquivalent:]):
1315         (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
1316         * WebView/WebPDFView.mm:
1317         (-[WebPDFView hitTest:]):
1318         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1319         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
1320         * WebView/WebTextCompletionController.mm:
1321         (-[WebTextCompletionController _buildUI]):
1322         (-[WebTextCompletionController _placePopupWindow:]):
1323         * WebView/WebView.mm:
1324         (-[WebView applicationFlags:]):
1325
1326 2016-11-09  Beth Dakin  <bdakin@apple.com>
1327
1328         Support TouchBar in WebKit
1329         https://bugs.webkit.org/show_bug.cgi?id=164437
1330         -and corresponding-
1331         rdar://problem/28876524
1332
1333         Reviewed by Darin Adler.
1334
1335         * WebCoreSupport/WebEditorClient.mm:
1336         (WebEditorClient::respondToChangedSelection):
1337         (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
1338         * WebView/WebHTMLView.mm:
1339         (-[WebHTMLView candidateListTouchBarItem]):
1340         * WebView/WebView.mm:
1341         (-[_WebTextListTouchBarViewController initWithWebView:]):
1342         (-[_WebTextListTouchBarViewController _selectList:]):
1343         (-[_WebTextListTouchBarViewController setCurrentListType:]):
1344         (-[WebTextTouchBarItemController initWithWebView:]):
1345         (-[WebTextTouchBarItemController itemForIdentifier:]):
1346         (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
1347         (-[WebTextTouchBarItemController setTextIsBold:]):
1348         (-[WebTextTouchBarItemController setTextIsItalic:]):
1349         (-[WebTextTouchBarItemController setTextIsUnderlined:]):
1350         (-[WebTextTouchBarItemController _webChangeTextStyle:]):
1351         (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
1352         (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
1353         (-[WebTextTouchBarItemController textColor]):
1354         (-[WebTextTouchBarItemController setTextColor:]):
1355         (-[WebTextTouchBarItemController _webChangeColor:]):
1356         (-[WebTextTouchBarItemController textListViewController]):
1357         (-[WebView _commonInitializationWithFrameName:groupName:]):
1358         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1359         (-[WebView shouldRequestCandidates]):
1360         (-[WebView forceRequestCandidatesForTesting]):
1361         (-[WebView makeTouchBar]):
1362         (-[WebView touchBar:makeItemForIdentifier:]):
1363         (textCheckingResultFromNSTextCheckingResult):
1364         (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
1365         (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
1366         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1367         (-[WebView _clearPlaybackControlsManager]):
1368         (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
1369         (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
1370         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
1371         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
1372         (-[WebView touchBarDidExitCustomization:]):
1373         (-[WebView touchBarWillEnterCustomization:]):
1374         (-[WebView didChangeAutomaticTextCompletion:]):
1375         (-[WebView setUpTextTouchBar:]):
1376         (-[WebView _isRichlyEditable]):
1377         (-[WebView textTouchBar]):
1378         (-[WebView updateTextTouchBar]):
1379         (-[WebView updateMediaTouchBar]):
1380         (-[WebView updateTouchBar]):
1381         (-[WebView prepareForMouseDown]):
1382         (-[WebView prepareForMouseUp]):
1383         (-[WebView webViewAdditionsWillDestroyView]):
1384         (-[WebView candidateList]):
1385         (-[WebView updateWebViewAdditions]): Deleted.
1386         * WebView/WebViewData.h:
1387         * WebView/WebViewInternal.h:
1388         * WebView/WebViewPrivate.h:
1389
1390 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1391
1392         Safari does not emit composition end if blurred for dead key / Japanese IME
1393         https://bugs.webkit.org/show_bug.cgi?id=164369
1394         <rdar://problem/29050439>
1395
1396         Reviewed by Ryosuke Niwa.
1397
1398         When canceling a composition, make sure that we clear the system IME state.
1399
1400         * WebCoreSupport/WebEditorClient.h:
1401         * WebCoreSupport/WebEditorClient.mm:
1402         (WebEditorClient::canceledComposition):
1403
1404 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1405
1406         Add a setting and preferences to enable/disable async image decoding
1407         https://bugs.webkit.org/show_bug.cgi?id=164417
1408
1409         Reviewed by Simon Fraser.
1410
1411         Hook up the asyncImageDecodingEnabled setting for WebKit1.
1412
1413         * WebView/WebPreferenceKeysPrivate.h:
1414         * WebView/WebPreferences.mm:
1415         (+[WebPreferences initialize]):
1416         (-[WebPreferences asyncImageDecodingEnabled]):
1417         (-[WebPreferences setAsyncImageDecodingEnabled:]):
1418         * WebView/WebPreferencesPrivate.h:
1419         * WebView/WebView.mm:
1420         (-[WebView _preferencesChanged:]):
1421
1422 2016-11-01  Alex Christensen  <achristensen@webkit.org>
1423
1424         Remove PassRefPtr from DumpRenderTree
1425         https://bugs.webkit.org/show_bug.cgi?id=164307
1426
1427         Reviewed by Sam Weinig.
1428
1429         * WebView/WebGeolocationPosition.mm:
1430         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1431
1432 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1433
1434         [Readable Streams API] Enable creation of ReadableByteStreamController
1435         https://bugs.webkit.org/show_bug.cgi?id=164014
1436
1437         Reviewed by Youenn Fablet.
1438
1439         Added flag for the byte stream part of Readable Streams API.
1440
1441         * Configurations/FeatureDefines.xcconfig:
1442
1443 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
1444
1445         Remove CUSTOM_ELEMENTS build flag
1446         https://bugs.webkit.org/show_bug.cgi?id=164267
1447
1448         Reviewed by Antti Koivisto.
1449
1450         Removed the build flag.
1451
1452         * Configurations/FeatureDefines.xcconfig:
1453         * WebView/WebPreferences.mm:
1454         (+[WebPreferences initialize]):
1455         * WebView/WebView.mm:
1456         (-[WebView _preferencesChanged:]):
1457
1458 2016-11-01  Eric Carlson  <eric.carlson@apple.com>
1459
1460         [MediaStream] restrict media capture secure connections
1461         https://bugs.webkit.org/show_bug.cgi?id=164234
1462         <rdar://problem/28944906>
1463
1464         Reviewed by Alex Christensen.
1465
1466         * WebView/WebPreferenceKeysPrivate.h:
1467         * WebView/WebPreferences.mm:
1468         (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
1469         (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
1470         (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
1471         * WebView/WebPreferencesPrivate.h:
1472
1473         * WebView/WebView.mm:
1474         (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
1475
1476 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
1477
1478         JSC should support SharedArrayBuffer
1479         https://bugs.webkit.org/show_bug.cgi?id=163986
1480
1481         Reviewed by Keith Miller.
1482         
1483         Support the RuntimeFlag.
1484
1485         * WebView/WebPreferencesPrivate.h:
1486
1487 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1488
1489         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
1490         https://bugs.webkit.org/show_bug.cgi?id=164236
1491         <rdar://problem/28747712>
1492
1493         Reviewed by Beth Dakin.
1494
1495         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
1496         dictionary lookup.
1497
1498         * WebCoreSupport/WebEditorClient.mm:
1499         (WebEditorClient::respondToChangedSelection):
1500         * WebView/WebImmediateActionController.mm:
1501         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1502
1503 2016-10-31  Darin Adler  <darin@apple.com>
1504
1505         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
1506         https://bugs.webkit.org/show_bug.cgi?id=164214
1507
1508         Reviewed by Alex Christensen.
1509
1510         * DOM/DOMCSSPrimitiveValue.mm:
1511         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
1512         is a reference now.
1513         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
1514
1515         * DOM/DOMDocument.mm:
1516         (-[DOMDocument querySelector:]): Updated exception handling.
1517         (-[DOMDocument querySelectorAll:]): Ditto.
1518         * DOM/DOMDocumentFragment.mm:
1519         (-[DOMDocumentFragment querySelector:]): Ditto.
1520         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
1521         * DOM/DOMElement.mm:
1522         (-[DOMElement querySelector:]): Ditto.
1523         (-[DOMElement querySelectorAll:]): Ditto.
1524
1525 2016-10-31  Darin Adler  <darin@apple.com>
1526
1527         Convert Document from ExceptionCode to Exception
1528         https://bugs.webkit.org/show_bug.cgi?id=164212
1529
1530         Reviewed by Alex Christensen.
1531
1532         * DOM/DOMDocument.mm:
1533         (-[DOMDocument setXmlVersion:]): Updated exception handling.
1534         (-[DOMDocument cookie]): Ditto.
1535         (-[DOMDocument setCookie:]): Ditto.
1536         (-[DOMDocument setBody:]): Ditto.
1537         (-[DOMDocument createElement:]): Ditto.
1538         (-[DOMDocument createCDATASection:]): Ditto.
1539         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
1540         (-[DOMDocument createAttribute:]): Ditto.
1541         (-[DOMDocument createEntityReference:]): Ditto.
1542         (-[DOMDocument importNode:deep:]): Ditto.
1543         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
1544         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
1545         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
1546         (-[DOMDocument adoptNode:]): Ditto.
1547         (-[DOMDocument createEvent:]): Ditto.
1548
1549 2016-10-30  Darin Adler  <darin@apple.com>
1550
1551         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
1552         https://bugs.webkit.org/show_bug.cgi?id=164206
1553
1554         Reviewed by Chris Dumez.
1555
1556         * DOM/DOMElement.mm:
1557         (-[DOMElement setInnerHTML:]): Updated exception handling.
1558         (-[DOMElement setOuterHTML:]): Ditto.
1559         (-[DOMElement setAttribute:value:]): Ditto.
1560         (-[DOMElement setAttributeNode:]): Ditto.
1561         (-[DOMElement removeAttributeNode:]): Ditto.
1562         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
1563         (-[DOMElement setAttributeNodeNS:]): Ditto.
1564         (-[DOMElement matches:]): Ditto.
1565         (-[DOMElement closest:]): Ditto.
1566         (-[DOMElement webkitMatchesSelector:]): Ditto.
1567         * DOM/DOMHTMLElement.mm:
1568         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
1569         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
1570         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
1571         * DOM/DOMNamedNodeMap.mm:
1572         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
1573         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
1574         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
1575         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
1576
1577 2016-10-29  Darin Adler  <darin@apple.com>
1578
1579         Convert more of DOM from ExceptionCode to Exception
1580         https://bugs.webkit.org/show_bug.cgi?id=164173
1581
1582         Reviewed by Ryosuke Niwa.
1583
1584         * DOM/DOMCharacterData.mm:
1585         (-[DOMCharacterData substringData:length:]): Updated since this
1586         now uses ExceptionOr.
1587         (-[DOMCharacterData insertData:data:]): Ditto.
1588         (-[DOMCharacterData deleteData:length:]): Ditto.
1589         (-[DOMCharacterData replaceData:length:data:]): Ditto.
1590         * DOM/DOMText.mm:
1591         (-[DOMText splitText:]): Ditto.
1592         (-[DOMText replaceWholeText:]): Removed unneeded exception code
1593         handling from function that does not throw an exception.
1594
1595 2016-10-28  Darin Adler  <darin@apple.com>
1596
1597         Move all classes in the HTML directory from ExceptionCode to Exception
1598         https://bugs.webkit.org/show_bug.cgi?id=163876
1599
1600         Reviewed by Sam Weinig.
1601
1602         * DOM/DOMCharacterData.mm:
1603         (-[DOMCharacterData remove]): Updated exception handling.
1604         * DOM/DOMDOMTokenList.mm:
1605         (-[DOMDOMTokenList toggle:force:]): Ditto.
1606         * DOM/DOMDocumentType.mm:
1607         (-[DOMDocumentType remove]): Ditto.
1608         * DOM/DOMElement.mm:
1609         (-[DOMElement remove]): Ditto.
1610         * DOM/DOMHTML.mm:
1611         (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
1612         * DOM/DOMHTMLCanvasElement.mm:
1613         (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
1614         * DOM/DOMHTMLElement.mm:
1615         (-[DOMHTMLElement setInnerText:]): Ditto.
1616         (-[DOMHTMLElement setOuterText:]): Ditto.
1617         (-[DOMHTMLElement setContentEditable:]): Ditto.
1618         * DOM/DOMHTMLInputElement.mm:
1619         (-[DOMHTMLInputElement setMaxLength:]): Ditto.
1620         (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
1621         (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
1622         (-[DOMHTMLInputElement stepUp:]): Ditto.
1623         (-[DOMHTMLInputElement stepDown:]): Ditto.
1624         (-[DOMHTMLInputElement setRangeText:]): Ditto.
1625         (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
1626         * DOM/DOMHTMLMarqueeElement.mm:
1627         (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
1628         * DOM/DOMHTMLMediaElement.mm:
1629         (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
1630         (-[DOMHTMLMediaElement setVolume:]): Ditto.
1631         * DOM/DOMHTMLOptionsCollection.mm:
1632         (-[DOMHTMLOptionsCollection setLength:]): Ditto.
1633         * DOM/DOMHTMLTableElement.mm:
1634         (-[DOMHTMLTableElement setCaption:]): Ditto.
1635         (-[DOMHTMLTableElement setTHead:]): Ditto.
1636         (-[DOMHTMLTableElement setTFoot:]): Ditto.
1637         (-[DOMHTMLTableElement insertRow:]): Ditto.
1638         (-[DOMHTMLTableElement deleteRow:]): Ditto.
1639         * DOM/DOMHTMLTableRowElement.mm:
1640         (-[DOMHTMLTableRowElement insertCell:]): Ditto.
1641         (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
1642         * DOM/DOMHTMLTableSectionElement.mm:
1643         (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
1644         (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
1645         * DOM/DOMHTMLTextAreaElement.mm:
1646         (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
1647         (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
1648         (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
1649         * DOM/DOMHTMLVideoElement.mm:
1650         (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
1651         (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
1652         version (lowercase S) instead of repeating the logic from that method.
1653         (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
1654         * DOM/DOMTimeRanges.mm:
1655         (-[DOMTimeRanges start:]): Updated exception handling.
1656         (-[DOMTimeRanges end:]): Ditto.
1657
1658 2016-10-27  Chris Dumez  <cdumez@apple.com>
1659
1660         Regression(r203601): Caused crashes in iBooks
1661         https://bugs.webkit.org/show_bug.cgi?id=164093
1662         <rdar://problem/28745634>
1663
1664         Reviewed by Darin Adler.
1665
1666         Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
1667         which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
1668
1669         * DOM/DOMNode.mm:
1670         (-[DOMNode compareDocumentPosition:]):
1671
1672 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1673
1674         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
1675         https://bugs.webkit.org/show_bug.cgi?id=163948
1676         <rdar://problem/28921433>
1677
1678         Reviewed by Darin Adler.
1679
1680         Add support for new drag and drop-related EditAction enum values.
1681
1682         * WebCoreSupport/WebEditorClient.mm:
1683         (undoNameForEditAction):
1684
1685 2016-10-27  Dan Bernstein  <mitz@apple.com>
1686
1687         Reapplied the configuration changes from r207934 without breaking iOS builds.
1688
1689         * Configurations/Base.xcconfig:
1690         * Configurations/WebKitLegacy.xcconfig:
1691
1692 2016-10-27  Dan Bernstein  <mitz@apple.com>
1693
1694         Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
1695
1696         * Configurations/Base.xcconfig:
1697         * Configurations/WebKitLegacy.xcconfig:
1698
1699 2016-10-26  Dan Bernstein  <mitz@apple.com>
1700
1701         [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
1702         https://bugs.webkit.org/show_bug.cgi?id=164048
1703
1704         Reviewed by Tim Horton.
1705
1706         * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
1707         * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
1708           headers.
1709
1710         * History/WebBackForwardList.h: Fixed parameter name in @param entry.
1711         * Misc/WebDownload.h: Removed empty entries.
1712         * Misc/WebIconDatabase.h: Remove incorrect @param entries.
1713         * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
1714         * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
1715         * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
1716         * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
1717         * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
1718         * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
1719         * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
1720           Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
1721         * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
1722         * WebView/WebView.h: Changed @method to @property in a couple of places.
1723         * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
1724
1725 2016-10-26  Brian Burg  <bburg@apple.com>
1726
1727         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
1728         https://bugs.webkit.org/show_bug.cgi?id=164046
1729
1730         Reviewed by Joseph Pecoraro.
1731
1732         * WebCoreSupport/WebInspectorClient.h:
1733
1734 2016-10-21  Alex Christensen  <achristensen@webkit.org>
1735
1736         URL::port should return Optional<uint16_t>
1737         https://bugs.webkit.org/show_bug.cgi?id=163806
1738
1739         Reviewed by Darin Adler.
1740
1741         * WebCoreSupport/WebSecurityOrigin.mm:
1742         (-[WebSecurityOrigin port]):
1743
1744 2016-10-24  Dave Hyatt  <hyatt@apple.com>
1745
1746         Remove CSSCharsetRule from the CSS OM
1747         https://bugs.webkit.org/show_bug.cgi?id=163891
1748
1749         Reviewed by Darin Adler.
1750
1751         * DOM/DOMCSSCharsetRule.mm:
1752         (-[DOMCSSCharsetRule encoding]):
1753
1754 2016-10-24  Youenn Fablet  <youenn@apple.com>
1755
1756         Activate WEB_RTC compilation flags for Mac bots
1757         https://bugs.webkit.org/show_bug.cgi?id=163886
1758
1759         Reviewed by Eric Carlson.
1760
1761         * Configurations/FeatureDefines.xcconfig:
1762
1763 2016-10-23  Chris Dumez  <cdumez@apple.com>
1764
1765         addEventListener() / removeEventListener() should use a union for last parameter
1766         https://bugs.webkit.org/show_bug.cgi?id=163863
1767
1768         Reviewed by Darin Adler.
1769
1770         Cast BOOL to bool to help to compiler construct the new variant-type parameter.
1771
1772         * DOM/DOMNode.mm:
1773         (-[DOMNode addEventListener:listener:useCapture:]):
1774         (-[DOMNode addEventListener:::]):
1775         (-[DOMNode removeEventListener:listener:useCapture:]):
1776         (-[DOMNode removeEventListener:::]):
1777
1778 2016-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1779
1780         Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
1781         https://bugs.webkit.org/show_bug.cgi?id=163460
1782         <rdar://problem/28784142>
1783
1784         Reviewed by Darin Adler.
1785
1786         Handle new EditAction types for inserting/deleting pending/final compositions.
1787
1788         * WebCoreSupport/WebEditorClient.mm:
1789         (undoNameForEditAction):
1790
1791 2016-10-21  Jeremy Jones  <jeremyj@apple.com>
1792
1793         Implement basic pointer lock behavior for WebKit and WebKit2.
1794         https://bugs.webkit.org/show_bug.cgi?id=162745
1795
1796         Reviewed by Simon Fraser.
1797
1798         Add basic pointer lock functionality. User permission is not yet implemented.
1799
1800         * WebCoreSupport/WebChromeClient.h:
1801         * WebCoreSupport/WebChromeClient.mm:
1802         (WebChromeClient::requestPointerLock):
1803         (WebChromeClient::requestPointerUnlock):
1804
1805 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
1806
1807         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1808         https://bugs.webkit.org/show_bug.cgi?id=163374
1809
1810         Reviewed by Darin Adler.
1811
1812         * Configurations/FeatureDefines.xcconfig:
1813
1814 2016-10-19  Alex Christensen  <achristensen@webkit.org>
1815
1816         Revert r207151
1817         https://bugs.webkit.org/show_bug.cgi?id=163675
1818
1819         Reviewed by Brent Fulgham.
1820
1821         * Misc/WebDownload.mm:
1822         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
1823         * Misc/WebDownloadInternal.h:
1824         * WebCoreSupport/WebFrameLoaderClient.mm:
1825         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1826         * WebView/WebPreferences.mm:
1827         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
1828         * WebView/WebView.mm:
1829         (-[WebView scheduleInRunLoop:forMode:]):
1830         (-[WebView unscheduleFromRunLoop:forMode:]):
1831
1832 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
1833
1834         Unreviewed, rolling out r207557.
1835
1836         This change caused animations/font-variations tests to time
1837         out on pre-Sierra Macs.
1838
1839         Reverted changeset:
1840
1841         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
1842         iOS 9"
1843         https://bugs.webkit.org/show_bug.cgi?id=163374
1844         http://trac.webkit.org/changeset/207557
1845
1846 2016-10-19  Chris Dumez  <cdumez@apple.com>
1847
1848         Move HTML Interactive Form Validation behind an experimental flag
1849         https://bugs.webkit.org/show_bug.cgi?id=163673
1850
1851         Reviewed by Daniel Bates.
1852
1853         Re-disable HTML Interactive Form Validation by default on Mac WK1.
1854
1855         * WebView/WebViewData.mm:
1856         (-[WebViewPrivate init]):
1857
1858 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
1859
1860         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1861         https://bugs.webkit.org/show_bug.cgi?id=163374
1862
1863         Reviewed by Darin Adler.
1864
1865         * Configurations/FeatureDefines.xcconfig:
1866
1867 2016-10-19  Simon Fraser  <simon.fraser@apple.com>
1868
1869         WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
1870         https://bugs.webkit.org/show_bug.cgi?id=163680
1871
1872         Reviewed by Dean Jackson.
1873
1874         Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
1875
1876         * WebView/WebView.mm:
1877         (-[WebView _preferencesChanged:]):
1878
1879 2016-10-19  Darin Adler  <darin@apple.com>
1880
1881         Move XPath from ExceptionCode to Exception
1882         https://bugs.webkit.org/show_bug.cgi?id=163656
1883
1884         Reviewed by Chris Dumez.
1885
1886         * DOM/DOMDocument.mm:
1887         (wrap): Added. Helper function for wrapping a resolver.
1888         (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
1889         (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
1890         * DOM/DOMXPathExpression.mm:
1891         (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
1892         * DOM/DOMXPathResult.mm:
1893         (-[DOMXPathResult numberValue]): Ditto.
1894         (-[DOMXPathResult stringValue]): Ditto.
1895         (-[DOMXPathResult booleanValue]): Ditto.
1896         (-[DOMXPathResult singleNodeValue]): Ditto.
1897         (-[DOMXPathResult snapshotLength]): Ditto.
1898         (-[DOMXPathResult iterateNext]): Ditto.
1899         (-[DOMXPathResult snapshotItem:]): Ditto.
1900
1901 2016-10-18  Sam Weinig  <sam@webkit.org>
1902
1903         Replace std::experimental::variant with WTF::Variant (or similar)
1904         https://bugs.webkit.org/show_bug.cgi?id=163626
1905
1906         Reviewed by Chris Dumez.
1907
1908         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
1909         into the WTF namespace.
1910
1911         * DOM/DOMHTMLSelectElement.mm:
1912         (-[DOMHTMLSelectElement add:before:]):
1913
1914 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
1915
1916         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
1917         https://bugs.webkit.org/show_bug.cgi?id=163627
1918
1919         Reviewed by Dean Jackson.
1920
1921         Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
1922
1923         * WebView/WebViewPrivate.h:
1924
1925 2016-10-18  Dean Jackson  <dino@apple.com>
1926
1927         Remove CSS_SHAPES feature definition. This should always be on.
1928         https://bugs.webkit.org/show_bug.cgi?id=163628
1929         <rdar://problem/28834613>
1930
1931         Reviewed by Tim Horton.
1932
1933         * Configurations/FeatureDefines.xcconfig:
1934
1935 2016-10-18  Chris Dumez  <cdumez@apple.com>
1936
1937         Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
1938         https://bugs.webkit.org/show_bug.cgi?id=163608
1939
1940         Reviewed by Ryosuke Niwa.
1941
1942         Update add() call sites now that it takes std::variant types in.
1943
1944         * DOM/DOMHTMLOptionsCollection.mm:
1945         (-[DOMHTMLOptionsCollection add:index:]):
1946         * DOM/DOMHTMLSelectElement.mm:
1947         (-[DOMHTMLSelectElement add:before:]):
1948
1949 2016-10-18  Anders Carlsson  <andersca@apple.com>
1950
1951         Get rid of more WebHistoryItem cruft
1952         https://bugs.webkit.org/show_bug.cgi?id=163623
1953
1954         Reviewed by Tim Horton.
1955
1956         * History/WebHistoryItem.mm:
1957         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1958         * History/WebHistoryItemPrivate.h:
1959
1960 2016-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1961
1962         Showing and hiding candidates list is very distracting after selecting word
1963         https://bugs.webkit.org/show_bug.cgi?id=163609
1964         <rdar://problem/28747712>
1965
1966         Reviewed by Tim Horton.
1967
1968         Introduce WebView hooks for mousedown and mouseup. See radar for more details.
1969
1970         * WebView/WebHTMLView.mm:
1971         (-[WebHTMLView mouseDown:mouseDown:]):
1972         (-[WebHTMLView mouseUp:mouseUp:]):
1973         * WebView/WebView.mm:
1974         (-[WebView prepareForMouseDown]):
1975         (-[WebView prepareForMouseUp]):
1976         * WebView/WebViewInternal.h:
1977
1978 2016-10-17  Anders Carlsson  <andersca@apple.com>
1979
1980         Move some history specific HistoryItem code to WebHistoryItem
1981         https://bugs.webkit.org/show_bug.cgi?id=163567
1982
1983         Reviewed by Tim Horton.
1984
1985         * History/HistoryPropertyList.mm:
1986         (HistoryPropertyListWriter::writeHistoryItem):
1987         * History/WebHistory.mm:
1988         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
1989         * History/WebHistoryItem.mm:
1990         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1991         * History/WebHistoryItemInternal.h:
1992         * WebCoreSupport/WebFrameLoaderClient.mm:
1993         (addRedirectURL):
1994         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
1995
1996 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
1997
1998         [MediaStream] Resolve constraints and enumerate devices in the UI process
1999         https://bugs.webkit.org/show_bug.cgi?id=162147
2000         <rdar://problem/28803569>
2001
2002         Reviewed by Darin Adler.
2003
2004         * WebCoreSupport/WebUserMediaClient.h:
2005         * WebCoreSupport/WebUserMediaClient.mm:
2006         (AddPermissionCheckToMap):
2007         (RemovePermissionCheckFromMap):
2008         (WebUserMediaClient::pageDestroyed):
2009         (WebUserMediaClient::requestUserMediaAccess):
2010         (WebUserMediaClient::enumerateMediaDevices):
2011         (WebUserMediaClient::cancelMediaDevicesEnumerationRequest):
2012         (-[WebUserMediaPolicyListener allow]):
2013         (-[WebUserMediaPolicyListener deny]):
2014         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
2015         (-[WebUserMediaPolicyCheckerListener cancelMediaDevicesEnumerationRequest]):
2016         (-[WebUserMediaPolicyCheckerListener allow]):
2017         (-[WebUserMediaPolicyCheckerListener deny]):
2018         (WebUserMediaClient::checkUserMediaPermission): Deleted.
2019         (WebUserMediaClient::cancelUserMediaPermissionCheck): Deleted.
2020         (-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]): Deleted.
2021         (-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]): Deleted.
2022
2023 2016-10-17  Antti Koivisto  <antti@apple.com>
2024
2025         Rename setNeedsStyleRecalc to invalidateStyle
2026         https://bugs.webkit.org/show_bug.cgi?id=163542
2027
2028         Reviewed by Darin Adler.
2029
2030         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2031         (-[WebHostedNetscapePluginView createPluginLayer]):
2032         * Plugins/WebNetscapePluginView.mm:
2033         (-[WebNetscapePluginView createPlugin]):
2034
2035 2016-10-17  Jeremy Jones  <jeremyj@apple.com>
2036
2037         Enable keyboard in fullscreen.
2038         https://bugs.webkit.org/show_bug.cgi?id=163146
2039
2040         Reviewed by Jer Noble.
2041
2042         Allow keyboard in fullscreen.
2043
2044         * WebView/WebView.mm:
2045         (-[WebView _supportsFullScreenForElement:withKeyboard:]):
2046
2047 2016-10-17  Chris Dumez  <cdumez@apple.com>
2048
2049         Move form.reportValidity() behind InteractiveFormValidation setting
2050         https://bugs.webkit.org/show_bug.cgi?id=163550
2051
2052         Reviewed by Darin Adler.
2053
2054         Enable InteractiveFormValidation setting by default and link it to
2055         RuntimeEnabledFeatures so we can use it in the IDL.
2056
2057         * WebView/WebView.mm:
2058         (-[WebView _preferencesChanged:]):
2059         * WebView/WebViewData.mm:
2060         (-[WebViewPrivate init]):
2061
2062 2016-10-17  Anders Carlsson  <andersca@apple.com>
2063
2064         Fix iOS build.
2065
2066         * History/WebBackForwardList.mm:
2067         (-[WebBackForwardList dictionaryRepresentation]):
2068
2069 2016-10-17  Anders Carlsson  <andersca@apple.com>
2070
2071         CTTE some of the BackForwardList member functions
2072         https://bugs.webkit.org/show_bug.cgi?id=163555
2073
2074         Reviewed by Dan Bernstein.
2075
2076         * History/BackForwardList.h:
2077         (BackForwardList::entries):
2078         * History/BackForwardList.mm:
2079         (BackForwardList::removeItem):
2080         (BackForwardList::containsItem):
2081         (BackForwardList::entries): Deleted.
2082         * History/WebBackForwardList.mm:
2083         (-[WebBackForwardList removeItem:]):
2084         (-[WebBackForwardList containsItem:]):
2085         (-[WebBackForwardList description]):
2086
2087 2016-10-17  Anders Carlsson  <andersca@apple.com>
2088
2089         Remove WEBCORE_EXPORT from BackForwardList, it lives in WebKit now
2090         https://bugs.webkit.org/show_bug.cgi?id=163551
2091
2092         Reviewed by Tim Horton.
2093
2094         * History/BackForwardList.h:
2095
2096 2016-10-16  Darin Adler  <darin@apple.com>
2097
2098         Move CSS classes from ExceptionCode to Exception
2099         https://bugs.webkit.org/show_bug.cgi?id=163494
2100
2101         Reviewed by Sam Weinig.
2102
2103         * DOM/DOMCSSMediaRule.mm:
2104         (-[DOMCSSMediaRule insertRule:index:]): Use raiseOnDOMError
2105         the new way to handle ExceptionOr instead of ExceptionCode.
2106         (-[DOMCSSMediaRule deleteRule:]): Ditto.
2107         * DOM/DOMCSSPrimitiveValue.mm:
2108         (-[DOMCSSPrimitiveValue setFloatValue:floatValue:]): Ditto.
2109         (-[DOMCSSPrimitiveValue getFloatValue:]): Ditto.
2110         (-[DOMCSSPrimitiveValue setStringValue:stringValue:]): Ditto.
2111         (-[DOMCSSPrimitiveValue getStringValue]): Ditto.
2112         (-[DOMCSSPrimitiveValue getCounterValue]): Ditto.
2113         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
2114         (-[DOMCSSPrimitiveValue getRGBColorValue]): Ditto.
2115         * DOM/DOMCSSRule.mm:
2116         (-[DOMCSSRule setCssText:]): Ditto.
2117         * DOM/DOMCSSStyleDeclaration.mm:
2118         (-[DOMCSSStyleDeclaration setCssText:]): Ditto.
2119         (-[DOMCSSStyleDeclaration removeProperty:]): Ditto.
2120         (-[DOMCSSStyleDeclaration setProperty:value:priority:]): Ditto.
2121         * DOM/DOMCSSStyleSheet.mm:
2122         (-[DOMCSSStyleSheet insertRule:index:]): Ditto.
2123         (-[DOMCSSStyleSheet deleteRule:]): Ditto.
2124         (-[DOMCSSStyleSheet addRule:style:index:]): Ditto.
2125         (-[DOMCSSStyleSheet removeRule:]): Ditto.
2126         * DOM/DOMCSSValue.mm:
2127         (-[DOMCSSValue setCssText:]): Ditto.
2128         * DOM/DOMMediaList.mm:
2129         (-[DOMMediaList setMediaText:]): Ditto.
2130         (-[DOMMediaList deleteMedium:]): Ditto.
2131         (-[DOMMediaList appendMedium:]): Ditto.
2132
2133         * DOM/ExceptionHandlers.h: Added an overload of raiseDOMException
2134         that works with a WebCore::Exception&& and overloads of
2135         raiseOnDOMError that work with WebCore::ExceptionOr&&.
2136         * DOM/ExceptionHandlers.mm:
2137         (raiseDOMException): Implemented the new version.
2138
2139 2016-10-15  Dan Bernstein  <mitz@apple.com>
2140
2141         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
2142         https://bugs.webkit.org/show_bug.cgi?id=163492
2143         <rdar://problem/28654799>
2144
2145         Reviewed by Darin Adler.
2146
2147         Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm
2148
2149         * WebView/WebHTMLView.mm:
2150         (createMenuItem): Set the tag for items that have submenus as well.
2151
2152 2016-10-14  Anders Carlsson  <andersca@apple.com>
2153
2154         Clean up BackForwardClient
2155         https://bugs.webkit.org/show_bug.cgi?id=163454
2156
2157         Reviewed by Sam Weinig.
2158
2159         * History/BackForwardList.h:
2160         Remove override keywords.
2161
2162         * History/BackForwardList.mm:
2163         (BackForwardList::clearAllPageCaches): Deleted.
2164         Remove this, it's no longer used.
2165
2166         * WebView/WebView.mm:
2167         (-[WebView _clearBackForwardCache]): Deleted.
2168         * WebView/WebViewPrivate.h:
2169         Remove SPI that's no longer used by anyone.
2170
2171 2016-10-13  Anders Carlsson  <andersca@apple.com>
2172
2173         Move BackForwardList from WebCore to WebKitLegacy
2174         https://bugs.webkit.org/show_bug.cgi?id=163418
2175
2176         Reviewed by Tim Horton.
2177
2178         * History/BackForwardList.h: Renamed from Source/WebCore/history/BackForwardList.h.
2179         (BackForwardList::create):
2180         (BackForwardList::webView):
2181         * History/BackForwardList.mm: Renamed from Source/WebCore/history/BackForwardList.cpp.
2182         (BackForwardList::BackForwardList):
2183         (BackForwardList::close):
2184         (BackForwardList::containsItem):
2185         * History/WebBackForwardList.mm:
2186         (kit):
2187         (-[WebBackForwardList initWithBackForwardList:]):
2188         (-[WebBackForwardList setPageCacheSize:]):
2189         (-[WebBackForwardList pageCacheSize]):
2190         * History/WebBackForwardListInternal.h:
2191         * WebCoreSupport/WebFrameLoaderClient.mm:
2192         * WebView/WebFrameView.mm:
2193         * WebView/WebView.mm:
2194         (-[WebView _commonInitializationWithFrameName:groupName:]):
2195         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2196
2197 2016-10-13  Anders Carlsson  <andersca@apple.com>
2198
2199         Get rid of the HistoryItemVector typedef
2200         https://bugs.webkit.org/show_bug.cgi?id=163398
2201
2202         Reviewed by Beth Dakin.
2203
2204         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
2205
2206         * History/WebBackForwardList.mm:
2207         (-[WebBackForwardList dictionaryRepresentation]):
2208         (vectorToNSArray):
2209         (-[WebBackForwardList backListWithLimit:]):
2210         (-[WebBackForwardList forwardListWithLimit:]):
2211         (-[WebBackForwardList description]):
2212         * History/WebHistoryItem.mm:
2213         (-[WebHistoryItem description]):
2214
2215 2016-10-12  Chris Dumez  <cdumez@apple.com>
2216
2217         [Web IDL] Drop support for legacy [ConstructorConditional=*]
2218         https://bugs.webkit.org/show_bug.cgi?id=163368
2219
2220         Reviewed by Ryosuke Niwa.
2221
2222         Drop ENABLE_DOM4_EVENTS_CONSTRUCTOR compiler flag.
2223
2224         * Configurations/FeatureDefines.xcconfig:
2225
2226 2016-10-12  Beth Dakin  <bdakin@apple.com>
2227
2228         Adobe Contribute CS 6.5 Trial crashes on launch
2229         https://bugs.webkit.org/show_bug.cgi?id=163365
2230         -and corresponding-
2231         <rdar://problem/28732731>
2232
2233         Reviewed by Tim Horton.
2234
2235         * Carbon/CarbonWindowFrame.m:
2236         (-[CarbonWindowFrame contentFill]):
2237
2238 2016-10-11  Daniel Bates  <dabates@apple.com>
2239
2240         Attempt to fix the Apple Internal Mac build following r207159
2241         (https://bugs.webkit.org/show_bug.cgi?id=163244)
2242
2243         * WebView/WebView.mm:
2244         (shouldRequireUserGestureToLoadVideo):
2245
2246 2016-10-11  Daniel Bates  <dabates@apple.com>
2247
2248         REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
2249         https://bugs.webkit.org/show_bug.cgi?id=163259
2250         <rdar://problem/28680515>
2251
2252         Reviewed by Jer Noble.
2253
2254         In WebKit1 on iOS we want to require user action to load and play videos by default and
2255         allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
2256         Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
2257         can load and play without being initiated by a user action.
2258
2259         * WebView/WebPreferences.mm:
2260         (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
2261         WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
2262         preference takes precedence over the values of its replacement preferences
2263         WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
2264
2265 2016-10-11  Daniel Bates  <dabates@apple.com>
2266
2267         [iOS] REGRESSION (r197953): User gesture required to load video in iOS 9-built apps
2268         https://bugs.webkit.org/show_bug.cgi?id=163244
2269         <rdar://problem/27250015>
2270
2271         Reviewed by Jer Noble.
2272
2273         Enable or disable the Setting::requiresUserGestureToLoadVideo() in legacy WebKit depending
2274         on the version of iOS SDK that the app was linked against. We require a user gesture to
2275         begin loading a video as of iOS 10.
2276
2277         * WebView/WebView.mm:
2278         (shouldRequireUserGestureToLoadVideo):
2279         (-[WebView _preferencesChanged:]): Modified to pass the WebKit requiresUserGestureToLoadVideo
2280         preference to WebCore.
2281
2282 2016-10-11  Alex Christensen  <achristensen@webkit.org>
2283
2284         Remove dead networking code
2285         https://bugs.webkit.org/show_bug.cgi?id=163263
2286
2287         Reviewed by Daniel Bates.
2288
2289         * Misc/WebDownload.mm:
2290         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2291         * Misc/WebDownloadInternal.h:
2292         * WebCoreSupport/WebFrameLoaderClient.mm:
2293         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2294         * WebView/WebPreferences.mm:
2295         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
2296         * WebView/WebView.mm:
2297         (-[WebView scheduleInRunLoop:forMode:]):
2298         (-[WebView unscheduleFromRunLoop:forMode:]):
2299
2300 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
2301
2302         Add ENABLE_ENCRYPTED_MEDIA configuration option
2303         https://bugs.webkit.org/show_bug.cgi?id=163219
2304
2305         Reviewed by Darin Adler.
2306
2307         * Configurations/FeatureDefines.xcconfig:
2308         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
2309         to enable or disable the new EME implementation at build-time.
2310
2311 2016-10-10  Darin Adler  <darin@apple.com>
2312
2313         Move NotificationCenter from legacy to new DOM exceptions
2314         https://bugs.webkit.org/show_bug.cgi?id=163217
2315
2316         Reviewed by Chris Dumez.
2317
2318         * WebView/WebView.mm:
2319         (-[WebView _notificationIDForTesting:]): Pass reference to page rather than pointer.
2320
2321 2016-10-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2322
2323         Support InputEvent.inputType for the new InputEvent spec
2324         https://bugs.webkit.org/show_bug.cgi?id=163025
2325         <rdar://problem/28658092>
2326
2327         Reviewed by Darin Adler.
2328
2329         Accounts for some changes to the EditAction enum in nameForEditAction. See WebCore ChangeLog
2330         entry for more details.
2331
2332         * WebCoreSupport/WebEditorClient.mm:
2333         (undoNameForEditAction):
2334
2335 2016-10-06  Darin Adler  <darin@apple.com>
2336
2337         Next step on moving to modern way to return DOM exceptions
2338         https://bugs.webkit.org/show_bug.cgi?id=163016
2339
2340         Reviewed by Ryosuke Niwa.
2341
2342         * DOM/DOMDOMImplementation.mm:
2343         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated for
2344         name change from takeReturnValue to releaseReturnValue.
2345         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2346
2347 2016-10-07  Simon Fraser  <simon.fraser@apple.com>
2348
2349         [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
2350         https://bugs.webkit.org/show_bug.cgi?id=163154
2351         rdar://problem/28674216
2352
2353         Reviewed by Tim Horton.
2354         
2355         r55159 added code to counteract AppKit's adjustment of dirty regions during scrolling,
2356         by offsetting the dirty rect in -setNeedsDisplayInRect: if the call happens during
2357         the NSViewBoundsDidChangeNotification handling.
2358         
2359         However, AppKit only does dirty region adjustment in the code path that blits ("copy
2360         on scroll"), so r55159 produces incorrect behavior in, for example, layer-backed views.
2361         
2362         Fix by overriding -[NSClipView _canCopyOnScrollForDeltaX:deltaY:] to know if a single
2363         scroll is going to blit, and only do adjustments in -setNeedsDisplayInRect: if it is.
2364
2365         * WebView/WebClipView.h:
2366         * WebView/WebClipView.mm:
2367         (-[WebClipView _immediateScrollToPoint:]):
2368         (-[WebClipView _canCopyOnScrollForDeltaX:deltaY:]):
2369         (-[WebClipView currentScrollIsBlit]):
2370         * WebView/WebHTMLView.mm:
2371         (-[WebHTMLView setNeedsDisplayInRect:]):
2372         (-[WebHTMLView drawRect:]):
2373
2374 2016-10-06  Youenn Fablet  <youenn@apple.com>
2375
2376         CachedResource client handling methods should take reference
2377         https://bugs.webkit.org/show_bug.cgi?id=163014
2378
2379         Reviewed by Alex Christensen.
2380
2381         * WebView/WebHTMLView.mm:
2382         (promisedDataClient):
2383
2384 2016-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
2385
2386         Put variation fonts work behind a compile-time flag
2387         https://bugs.webkit.org/show_bug.cgi?id=162949
2388
2389         Reviewed by Simon Fraser.
2390
2391         * Configurations/FeatureDefines.xcconfig:
2392
2393 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
2394
2395         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
2396         https://bugs.webkit.org/show_bug.cgi?id=162903
2397
2398         Reviewed by Alex Christensen.
2399
2400         Rename build guards for the remaining implementation of the legacy EME API
2401         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
2402         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
2403
2404         * Configurations/FeatureDefines.xcconfig:
2405         * WebView/WebPreferences.mm:
2406         (+[WebPreferences initialize]):
2407         * WebView/WebView.mm:
2408         (-[WebView _preferencesChanged:]):
2409
2410 2016-10-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2411
2412         The dragged image should be the current frame only of the animated image
2413         https://bugs.webkit.org/show_bug.cgi?id=162109
2414
2415         Reviewed by Tim Horton.
2416
2417         * DOM/DOM.mm:
2418         (-[DOMElement image]): Call the Image function with its new name.
2419         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2420         * Misc/WebElementDictionary.mm:
2421         (-[WebElementDictionary _image]): Call the Image function with its new name.
2422         * Misc/WebIconDatabase.mm:
2423         (-[WebIconDatabase defaultIconWithSize:]): Call snapshotNSImage() to create the icon image.
2424         (webGetNSImage): Call the Image function with its new name.
2425         * WebCoreSupport/WebContextMenuClient.mm:
2426         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call snapshotNSImage() instead of nsImage()..
2427         (WebContextMenuClient::contextMenuForEvent): Ditto.
2428         * WebView/WebHTMLView.mm:
2429         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2430
2431 2016-10-02  Ryan Haddad  <ryanhaddad@apple.com>
2432
2433         Unreviewed, rolling out r206683.
2434
2435         This change caused API test WebKit2.FindMatches to fail on
2436         Mac.
2437
2438         Reverted changeset:
2439
2440         "The dragged image should be the current frame only of the
2441         animated image"
2442         https://bugs.webkit.org/show_bug.cgi?id=162109
2443         http://trac.webkit.org/changeset/206683
2444
2445 2016-09-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
2446
2447         The dragged image should be the current frame only of the animated image
2448         https://bugs.webkit.org/show_bug.cgi?id=162109
2449
2450         Reviewed by Tim Horton.
2451
2452         * DOM/DOM.mm:
2453         (-[DOMElement image]): Call the Image function with its new name.
2454         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2455         * Misc/WebElementDictionary.mm:
2456         (-[WebElementDictionary _image]): Call the Image function with its new name.
2457         * Misc/WebIconDatabase.mm:
2458         (-[WebIconDatabase defaultIconWithSize:]): Call currentFrameNSImage() to create the icon image.
2459         (webGetNSImage): Call the Image function with its new name.
2460         * WebCoreSupport/WebContextMenuClient.mm:
2461         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call currentFrameNSImage() instead of nsImage()..
2462         (WebContextMenuClient::contextMenuForEvent): Ditto.
2463         * WebView/WebHTMLView.mm:
2464         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2465
2466 2016-09-27  Jer Noble  <jer.noble@apple.com>
2467
2468         Remove deprecated ENCRYPTED_MEDIA implementation.
2469         https://bugs.webkit.org/show_bug.cgi?id=161010
2470
2471         Remove ENABLE_ENCRYPTED_MEDIA.
2472
2473         Reviewed by Eric Carlson.
2474
2475         * Configurations/FeatureDefines.xcconfig:
2476
2477 2016-09-26  Daniel Bates  <dabates@apple.com>
2478
2479         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
2480         https://bugs.webkit.org/show_bug.cgi?id=162365
2481
2482         Reviewed by Simon Fraser.
2483
2484         * Configurations/FeatureDefines.xcconfig:
2485         * WebView/WebFrame.mm:
2486         * WebView/WebPreferences.mm:
2487         (+[WebPreferences initialize]):
2488         * WebView/WebView.mm:
2489         (-[WebView _preferencesChanged:]):
2490
2491 2016-09-25  Antti Koivisto  <antti@apple.com>
2492
2493         AuthorStyleSheets shouldn't trigger synchronous style resolutions
2494         https://bugs.webkit.org/show_bug.cgi?id=162532
2495
2496         Reviewed by Darin Adler.
2497
2498         * WebView/WebHTMLView.mm:
2499         (-[WebHTMLView reapplyStyles]):
2500         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2501
2502 2016-09-24  Antti Koivisto  <antti@apple.com>
2503
2504         Move stylesheet change logic from Document to AuthorStyleSheets
2505         https://bugs.webkit.org/show_bug.cgi?id=162488
2506
2507         Reviewed by Andreas Kling.
2508
2509         * WebView/WebHTMLView.mm:
2510         (-[WebHTMLView reapplyStyles]):
2511         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2512
2513 2016-09-23  Caitlin Potter  <caitp@igalia.com>
2514
2515         [JSC] Implement parsing of Async Functions
2516         https://bugs.webkit.org/show_bug.cgi?id=161409
2517
2518         Reviewed by Yusuke Suzuki.
2519
2520         * Configurations/FeatureDefines.xcconfig:
2521
2522 2016-09-23  Commit Queue  <commit-queue@webkit.org>
2523
2524         Unreviewed, rolling out r206311.
2525         https://bugs.webkit.org/show_bug.cgi?id=162495
2526
2527         Broke internal iOS build (Requested by anttik on #webkit).
2528
2529         Reverted changeset:
2530
2531         "Move stylesheet change logic from Document to
2532         AuthorStyleSheets"
2533         https://bugs.webkit.org/show_bug.cgi?id=162488
2534         http://trac.webkit.org/changeset/206311
2535
2536 2016-09-23  Antoine Quint  <graouts@apple.com>
2537
2538         Add a new runtime flag for work on modern media controls (off by default)
2539         https://bugs.webkit.org/show_bug.cgi?id=162420
2540         <rdar://problem/27989489>
2541
2542         Reviewed by Eric Carlson.
2543
2544         * WebView/WebPreferenceKeysPrivate.h:
2545         * WebView/WebPreferences.mm:
2546         (-[WebPreferences modernMediaControlsEnabled]):
2547         (-[WebPreferences setModernMediaControlsEnabled:]):
2548         * WebView/WebPreferencesPrivate.h:
2549         * WebView/WebView.mm:
2550         (-[WebView _preferencesChanged:]):
2551
2552 2016-09-21  Anders Carlsson  <andersca@apple.com>
2553
2554         Support openPaymentSetup API on ApplePaySession object
2555         https://bugs.webkit.org/show_bug.cgi?id=162357
2556         rdar://problem/26776939
2557
2558         Reviewed by Tim Horton.
2559
2560         Add openPaymentSetup stub.
2561
2562         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2563         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2564         (WebPaymentCoordinatorClient::openPaymentSetup):
2565
2566 2016-09-19  Daniel Bates  <dabates@apple.com>
2567
2568         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
2569         https://bugs.webkit.org/show_bug.cgi?id=162167
2570
2571         Reviewed by Simon Fraser.
2572
2573         * Configurations/FeatureDefines.xcconfig:
2574
2575 2016-09-19  Joseph Pecoraro  <pecoraro@apple.com>
2576
2577         Web Inspector: Bring the inspected page's window forward when activating element search
2578         https://bugs.webkit.org/show_bug.cgi?id=162114
2579         <rdar://problem/28349357>
2580
2581         Reviewed by Brian Burg.
2582
2583         * WebCoreSupport/WebInspectorClient.mm:
2584         (WebInspectorClient::didSetSearchingForNode):
2585         When element search is activated bring the window
2586         containing the inspected page to the foreground.
2587
2588 2016-09-15  Brady Eidson  <beidson@apple.com>
2589
2590         WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
2591         <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
2592
2593         Reviewed by Brent Fulgham. 
2594
2595         * WebCoreSupport/WebFrameLoaderClient.h:
2596         * WebCoreSupport/WebFrameLoaderClient.mm:
2597         (WebFrameLoaderClient::dispatchDidCommitLoad):
2598
2599 2016-09-15  Anders Carlsson  <andersca@apple.com>
2600
2601         This was supposed to be committed with the previous patch!
2602
2603         * Plugins/WebBasePluginPackage.mm:
2604         (pathByResolvingSymlinksAndAliases): Deleted.
2605
2606 2016-09-15  Anders Carlsson  <andersca@apple.com>
2607
2608         Replace use of Carbon file system APIs in plug-in loading
2609         https://bugs.webkit.org/show_bug.cgi?id=162040
2610         rdar://problem/6017896
2611
2612         Reviewed by Sam Weinig.
2613
2614         * Plugins/WebBasePluginPackage.mm:
2615         (-[WebBasePluginPackage initWithPath:]):
2616         Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
2617         to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).
2618
2619 2016-09-15  Beth Dakin  <bdakin@apple.com>
2620
2621         Need hasMarkedText on Mac
2622         https://bugs.webkit.org/show_bug.cgi?id=162026
2623         -and corresponding-
2624         rdar://problem/28272353
2625
2626         Reviewed by Anders Carlsson.
2627
2628         * WebView/WebHTMLViewInternal.h:
2629
2630 2016-09-12  Dean Jackson  <dino@apple.com>
2631
2632         Replace RGBA32 with Color in member variables
2633         https://bugs.webkit.org/show_bug.cgi?id=161856
2634         <rdar://problem/28254324>
2635
2636         Reviewed by Simon Fraser.
2637
2638         In preparation for the Color class to become more than
2639         just a 4-byte RGBA value, I went through a few places
2640         that were using the RGBA32 type directly, and replaced
2641         them with Color. This will make some objects a little
2642         bigger e.g. BorderValue and its friends.
2643
2644         I mostly looked at the places that were using RGBA32 as
2645         a member variable. There is still a lot of RGBA32 use
2646         around the project, in particular the CSS parser.
2647
2648         There should be no behaviour change.
2649
2650         * Misc/WebKitNSStringExtras.mm:
2651         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Explicitly
2652         call a Color constructor, rather than passing an RGBA32.
2653
2654 2016-09-13  Chris Dumez  <cdumez@apple.com>
2655
2656         Drop support for <isindex>
2657         https://bugs.webkit.org/show_bug.cgi?id=7139
2658
2659         Reviewed by Ryosuke Niwa.
2660
2661         Drop references to isindex.
2662
2663         * WebCoreSupport/WebEditorClient.mm:
2664         (attributesForAttributedStringConversion):
2665         * WebView/WebHTMLView.mm:
2666         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
2667
2668 2016-09-12  Chris Dumez  <cdumez@apple.com>
2669
2670         Switch remaining users of Document::inPageCache() to pageCacheState()
2671         https://bugs.webkit.org/show_bug.cgi?id=161865
2672
2673         Reviewed by Darin Adler.
2674
2675         Switch remaining users of Document::inPageCache() to pageCacheState() as
2676         the former one is confusing (given that it returns true while the
2677         pagehide event is being fired).
2678
2679         * WebView/WebHTMLView.mm:
2680         (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]):
2681         (-[WebHTMLView setNeedsLayout:]):
2682         (-[WebHTMLView setNeedsToApplyStyles:]):
2683
2684 2016-09-09  Tim Horton  <timothy_horton@apple.com>
2685
2686         Text replacement candidates don't always overwrite the entire original string
2687         https://bugs.webkit.org/show_bug.cgi?id=161779
2688         <rdar://problem/28033492>
2689
2690         Reviewed by Simon Fraser.
2691
2692         * WebCoreSupport/WebEditorClient.mm:
2693         (WebEditorClient::requestCandidatesForSelection):
2694         Make use of the shared implementation of contextRangeForCandidateRequest.
2695
2696 2016-09-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
2697
2698         Move the BitmapImage platform dependent code to a new file named NativeImage[CG|Cairo].cpp
2699         https://bugs.webkit.org/show_bug.cgi?id=158684
2700
2701         Reviewed by Simon Fraser.
2702
2703         * DOM/DOM.mm:
2704         (-[DOMNode getPreviewSnapshotImage:andRects:]):
2705         * Misc/WebCache.mm:
2706         (+[WebCache imageForURL:]):
2707         Replace BitmapImage::getCGImageRef() with BitmapImage::nativeImage().
2708
2709 2016-09-07  Joseph Pecoraro  <pecoraro@apple.com>
2710
2711         [Mac] Address some clang static analyzer warnings in WebKit
2712         https://bugs.webkit.org/show_bug.cgi?id=161597
2713
2714         Reviewed by Darin Adler.
2715
2716         * Misc/WebIconDatabase.h:
2717         Remove unused instance variable. It has not been used since r16005 (2006)!
2718
2719         * Misc/WebSharingServicePickerController.mm:
2720         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2721         Address array leak.
2722
2723         * WebCoreSupport/WebSelectionServiceController.mm:
2724         (WebSelectionServiceController::hasRelevantSelectionServices):
2725         Address attachment and cell leak.
2726
2727         * WebView/WebFullScreenController.h:
2728         * WebView/WebImmediateActionController.h:
2729         Remove unused instance variables.
2730
2731 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
2732
2733         Enable the <meter> element on iOS
2734         https://bugs.webkit.org/show_bug.cgi?id=161714
2735         rdar://problem/8978410
2736
2737         Reviewed by Tim Horton.
2738
2739         Define ENABLE_METER_ELEMENT unconditionally now.
2740
2741         * Configurations/FeatureDefines.xcconfig:
2742
2743 2016-09-07  Mark Lam  <mark.lam@apple.com>
2744
2745         Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
2746         https://bugs.webkit.org/show_bug.cgi?id=161498
2747
2748         Reviewed by Geoffrey Garen.
2749
2750         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2751         (WebKit::NetscapePluginInstanceProxy::evaluate):
2752         (WebKit::NetscapePluginInstanceProxy::invoke):
2753         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2754         (WebKit::NetscapePluginInstanceProxy::construct):
2755         (WebKit::NetscapePluginInstanceProxy::getProperty):
2756         (WebKit::NetscapePluginInstanceProxy::setProperty):
2757         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2758         (WebKit::NetscapePluginInstanceProxy::hasProperty):
2759         (WebKit::NetscapePluginInstanceProxy::hasMethod):
2760         (WebKit::NetscapePluginInstanceProxy::enumerate):
2761         * WebView/WebView.mm:
2762         (aeDescFromJSValue):
2763
2764 2016-09-07  Youenn Fablet  <youenn@apple.com>
2765
2766         [Streams API] Separate compile flag for ReadableStream and WritableStream
2767         https://bugs.webkit.org/show_bug.cgi?id=161044
2768
2769         Reviewed by Alex Christensen.
2770
2771         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
2772
2773         * Configurations/FeatureDefines.xcconfig:
2774
2775 2016-09-06  Chris Dumez  <cdumez@apple.com>
2776
2777         Add support for input.minLength / textArea.minLength
2778         https://bugs.webkit.org/show_bug.cgi?id=161644
2779
2780         Reviewed by Darin Adler.
2781
2782         Update ObjC bindings to reflect method renaming.
2783
2784         * DOM/DOMHTMLInputElement.mm:
2785         (-[DOMHTMLInputElement maxLength]):
2786         (-[DOMHTMLInputElement setMaxLength:]):
2787         * DOM/DOMHTMLTextAreaElement.mm:
2788         (-[DOMHTMLTextAreaElement maxLength]):
2789         (-[DOMHTMLTextAreaElement setMaxLength:]):
2790
2791 2016-09-06  Dan Bernstein  <mitz@apple.com>
2792
2793         <rdar://problem/8064563> Ugly NSLog in DOMInternal.mm
2794
2795         Rubber-stamped by Anders Carlsson.
2796
2797         * DOM/DOMInternal.mm:
2798         (-[WebScriptObject _initializeScriptDOMNodeImp]): Removed useless call to NSLog.
2799
2800 2016-09-06  Ryan Haddad  <ryanhaddad@apple.com>
2801
2802         Unreviewed, rolling out r205407.
2803
2804         Not the correct way to implement this functionality
2805
2806         Reverted changeset:
2807
2808         "Consult with the FrameLoaderClient about whether or not
2809         content extensions should be enabled when loading this URL."
2810         https://bugs.webkit.org/show_bug.cgi?id=161441
2811         http://trac.webkit.org/changeset/205407
2812
2813 2016-09-05  Darin Adler  <darin@apple.com>
2814
2815         More bindings improvements, particularly things not needed for JavaScript bindings
2816         https://bugs.webkit.org/show_bug.cgi?id=161572
2817
2818         Reviewed by Sam Weinig.
2819
2820         * DOM/DOMDOMImplementation.mm:
2821         (-[DOMImplementation hasFeature:version:]): Call SVGTests::hasFeatureForLegacyBindings
2822         instead of DOMImplementation::hasFeature. Also removed JSMainThreadNullState
2823         since this does not do anything that can invoke JavaScript.
2824
2825         * DOM/DOMDocument.mm:
2826         (-[DOMDocument defaultCharset]): Call defaultCharsetForLegacyBindings. Also removed
2827         JSMainThreadNullState.
2828
2829         * DOM/DOMDocumentType.mm:
2830         (-[DOMDocumentType entities]): Changed to simply return nil; same behavior as before,
2831         but with no dependency on WebCore. Also removed JSMainThreadNullState.
2832         (-[DOMDocumentType notations]): Ditto.
2833         (-[DOMDocumentType internalSubset]): Ditto, except empty string rather than nil.
2834
2835         * DOM/DOMNode.mm:
2836         (-[DOMNode isSupported:version:]): Call SVGTests::hasFeatureForLegacyBindings
2837         instead of Node::isSupportedForBindings. Also removed JSMainThreadNullState.
2838
2839 2016-09-04  Joseph Pecoraro  <pecoraro@apple.com>
2840
2841         Remove unnecessary RetainPtr.
2842
2843         Review comments on earlier change.
2844
2845         * WebView/WebImmediateActionController.mm:
2846         (-[WebImmediateActionController _defaultAnimationController]):
2847
2848 2016-09-03  Darin Adler  <darin@apple.com>
2849
2850         Streamline DOMImplementation, and move it to our new DOM exception system
2851         https://bugs.webkit.org/show_bug.cgi?id=161295
2852
2853         Reviewed by Ryosuke Niwa.
2854
2855         * DOM/DOMDOMImplementation.mm:
2856         (unwrap): Added. Use this instead of the IMPL macro.
2857         (-[DOMImplementation dealloc]): Updated to use unwrap.
2858         (-[DOMImplementation hasFeature:version:]): Ditto.
2859         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated to work with
2860         ExceptionOr.
2861         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2862         (-[DOMImplementation createCSSStyleSheet:media:]): Removed exception logic since
2863         this function can no longer raise an exception.
2864         (-[DOMImplementation createHTMLDocument:]): Updated to use unwrap.
2865         (-[DOMImplementation hasFeature::]): Changed to call the non-deprecated version
2866         rather than duplicating its implementation. Also moved into the category as defined
2867         in the header.
2868         (-[DOMImplementation createDocumentType:::]): Ditto.
2869         (-[DOMImplementation createDocument:::]): Ditto.
2870         (-[DOMImplementation createCSSStyleSheet::]): Ditto.
2871
2872         * DOM/DOMDocument.mm: Removed unneeded include of DOMImplementation.h.
2873         (-[DOMDocument setXmlStandalone:]): Updated since setXMLStandalone no longer can
2874         raise an exception.
2875
2876         * WebView/WebFrame.mm:
2877         (-[WebFrame _canProvideDocumentSource]): Updated to use isTextMIMEType in its new
2878         location in MIMETypeRegistry instead of in DOMImplementation.
2879
2880 2016-09-03  Brian Weinstein  <bweinstein@apple.com>
2881
2882         Implement a stub version of FrameLoaderClient::shouldUseContentExtensionsForURL.
2883         https://bugs.webkit.org/show_bug.cgi?id=16144
2884
2885         Reviewed by Darin Adler.
2886
2887         * WebCoreSupport/WebFrameLoaderClient.h:
2888
2889 2016-09-02  Beth Dakin  <bdakin@apple.com>
2890
2891         Need to updateEditorState if an element change edit-ability without changing 
2892         selection
2893         https://bugs.webkit.org/show_bug.cgi?id=161546
2894         -and corresponding-
2895         rdar://problem/27806012
2896
2897         Reviewed by Ryosuke Niwa.
2898
2899         Every time WebEditorClient::respondToChangedSelection is called, we now save 
2900         whether the last state was contentEditable. That way in 
2901         updateEditorStateAfterLayoutIfNeeded() we can assess whether or not edit-ability 
2902         has changed. 
2903
2904         * WebCoreSupport/WebEditorClient.h:
2905         * WebCoreSupport/WebEditorClient.mm:
2906         (WebEditorClient::respondToChangedSelection):
2907         (WebEditorClient:: updateEditorStateAfterLayoutIfEditabilityChanged):
2908
2909 2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
2910
2911         [Mac] RetainPtr misuse, AnimationController leaks
2912         https://bugs.webkit.org/show_bug.cgi?id=161552
2913
2914         Reviewed by Tim Horton.
2915
2916         * WebView/WebImmediateActionController.mm:
2917         (-[WebImmediateActionController _defaultAnimationController]):
2918
2919 2016-07-08  Jer Noble  <jer.noble@apple.com>
2920
2921         Refactor WebPlaybackSessionModelMediaElement to be client based.
2922         https://bugs.webkit.org/show_bug.cgi?id=159580
2923
2924         Reviewed by Eric Carlson.
2925
2926         No longer necessary to tell the models and interfaces about each other.
2927
2928         * WebView/WebView.mm:
2929         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
2930         (-[WebView _clearPlaybackControlsManager]):
2931
2932 2016-09-01  Dan Bernstein  <mitz@apple.com>
2933
2934         Build fix.
2935
2936         * Configurations/FeatureDefines.xcconfig:
2937
2938 2016-09-01  Myles C. Maxfield  <mmaxfield@apple.com>
2939
2940         Clean up TextRun-related code
2941         https://bugs.webkit.org/show_bug.cgi?id=161473
2942
2943         Reviewed by Simon Fraser.
2944
2945         Remove unused #includes.
2946
2947         * WebCoreSupport/WebDragClient.mm:
2948         * WebView/WebView.mm:
2949
2950 2016-08-31  Keith Rollin  <krollin@apple.com>
2951
2952         WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
2953         https://bugs.webkit.org/show_bug.cgi?id=160969
2954         <rdar://problem/26068734>
2955
2956         Reviewed by Simon Fraser.
2957
2958         Enable subsystem- and channel-related data and functions when using
2959         RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
2960         and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
2961
2962         * Misc/WebKitLogging.h:
2963         * Misc/WebKitLogging.m:
2964         * WebView/WebView.mm:
2965         (-[WebView _commonInitializationWithFrameName:groupName:]):
2966
2967 2016-08-31  Brady Eidson  <beidson@apple.com>
2968
2969         WK2 Gamepad provider on iOS.
2970         https://bugs.webkit.org/show_bug.cgi?id=161412
2971
2972         Reviewed by Tim Horton.
2973
2974         * Configurations/FeatureDefines.xcconfig:
2975
2976         * WebView/WebView.mm:
2977         (WebKitInitializeGamepadProviderIfNecessary):
2978
2979 2016-08-30  Mark Lam  <mark.lam@apple.com>
2980
2981         Introduce the ThrowScope and force every throw site to instantiate a ThrowScope.
2982         https://bugs.webkit.org/show_bug.cgi?id=161171
2983
2984         Reviewed by Filip Pizlo and Geoffrey Garen.
2985
2986         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2987         (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
2988         * Plugins/Hosted/ProxyInstance.mm:
2989         (WebKit::ProxyInstance::invokeMethod):
2990
2991 2016-08-28  Andreas Kling  <akling@apple.com>
2992
2993         document.title setter can't throw.
2994         <https://webkit.org/b/161302>
2995
2996         Reviewed by Antti Koivisto.
2997
2998         * DOM/DOMDocument.mm:
2999         (-[DOMDocument setTitle:]):
3000
3001 2016-08-28  Andreas Kling  <akling@apple.com>
3002
3003         Clean up some .text attribute setters that don't throw.
3004         <https://webkit.org/b/161292>
3005
3006         Reviewed by Darin Adler.
3007
3008         * DOM/DOMHTMLTitleElement.mm:
3009         (-[DOMHTMLTitleElement setText:]):
3010
3011 2016-08-26  Sam Weinig  <sam@webkit.org>
3012
3013         Remove support for ENABLE_LEGACY_WEB_AUDIO
3014         https://bugs.webkit.org/show_bug.cgi?id=161262
3015
3016         Reviewed by Anders Carlsson.
3017
3018         * Configurations/FeatureDefines.xcconfig:
3019         Remove ENABLE_LEGACY_WEB_AUDIO
3020
3021 2016-08-25  Anders Carlsson  <andersca@apple.com>
3022
3023         Re-export DOMException NSStrings after r204717
3024         https://bugs.webkit.org/show_bug.cgi?id=161200
3025         <rdar://problem/27959937>
3026
3027         Reviewed by Alex Christensen.
3028
3029         * DOM/ExceptionHandlers.mm:
3030         (raiseDOMException):
3031         * WebKit.exp:
3032
3033 2016-08-22  Darin Adler  <darin@apple.com>
3034
3035         Move Objective-C DOM bindings from WebCore to legacy WebKit
3036         https://bugs.webkit.org/show_bug.cgi?id=160654
3037
3038         Reviewed by Alex Christensen.
3039
3040         * DOM: Added lots of files to the directory.
3041         The files are just as they were in bindings/objc except that the paths of includes
3042         have been updated as needed, and the code no longer is defined inside the WebCore
3043         namespace, requring changes to various functions and their call sites. Also removed
3044         all the WEBCORE_EXPORT since we export differently here in legacy WebKit.
3045
3046         * DOM/DOMInternal.h: Moved. Replaced createDOMWrapper with initializeDOMWrapperHooks.
3047         * DOM/DOMUtility.mm: Moved.
3048         (createDOMWrapper): Simplified to use toWrapped and not do unneeded namespace tricks.
3049         (disconnectWindowWrapper): Added.
3050         (initializeDOMWrapperHooks): Added.
3051
3052         * MigrateHeaders.make: Removed all the internal headers since they are now just
3053         normal project headers. Added the "DOM" directory to the VPATH. Some of the headers
3054         from WebCore are still being migrated, so we can't remove WebCorePrivateHeaders yet.
3055
3056         * WebCoreSupport/WebEditorClient.h: Updated to return RefPtr<DocumentFragment>.
3057
3058         * WebCoreSupport/WebEditorClient.mm:
3059         (WebEditorClient::documentFragmentFromDelegate): Use RefPtr.
3060
3061         * WebKit.exp: Added exports for all the classes that used to use WEBCORE_EXPORT to
3062         be exported from WebCore.
3063
3064         * WebView/WebFrame.mm:
3065         (-[WebFrame innerLineHeight:]): Moved code from WebCore::Frame::innerLineHeight here.
3066         No longer depend on whether this node happens to be in this frame. Also removed
3067         unneeded null check since a node's document can't be null.
3068
3069         * WebView/WebHTMLView.mm: Removed uneeded include of ExceptionHandlers.h, which
3070         is now here in WebKitLegacy instead of WebCore. But no need to include it at all.
3071
3072         * WebView/WebView.mm:
3073         (-[WebView _commonInitializationWithFrameName:groupName:]): Call
3074         initializeDOMWrapperHooks so WebScriptObject can create DOM binding wrappers when
3075         making a script object for a DOM object, rather than just a generic script object.
3076         (+[WebView enableWebThread]): Added a call to WebCoreObjCDeallocOnWebThread here for
3077         DOMObject along with the other classes. This was done in WebCore before, but DOMObject is now
3078         defined here in legacy WebKit.
3079         (-[WebView styleAtSelectionStart]): Moved code from WebCore::Frame::styleAtSelectionStart here.
3080         Replaced incorrect code that called "new PropertySetCSSStyleDeclaration" with a misleading comment
3081         about reference counting; that code was leaking all the style declarations. Instead use
3082         MutableStyleProperties::ensureCSSStyleDeclaration, which is designed for this purpose.
3083
3084 2016-08-22  Youenn Fablet  <youenn@apple.com>
3085
3086         [Fetch API] Activate fetch api runtime flag by default
3087         https://bugs.webkit.org/show_bug.cgi?id=160452
3088
3089         Reviewed by Alex Christensen.
3090
3091         * WebView/WebPreferences.mm:
3092         (+[WebPreferences initialize]):
3093
3094 2016-08-21  Alex Christensen  <achristensen@webkit.org>
3095
3096         Use Document& instead of Document* when getting cookies
3097         https://bugs.webkit.org/show_bug.cgi?id=161011
3098
3099         Reviewed by Darin Adler.
3100
3101         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3102         (WebKit::NetscapePluginInstanceProxy::getCookies):
3103         (WebKit::NetscapePluginInstanceProxy::setCookies):
3104         * Plugins/WebNetscapePluginView.mm:
3105         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3106         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
3107
3108 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
3109
3110         Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
3111         https://bugs.webkit.org/show_bug.cgi?id=160923
3112
3113         Reviewed by Tim Horton.
3114
3115         * WebCoreSupport/WebFrameLoaderClient.h:
3116         * WebCoreSupport/WebFrameLoaderClient.mm:
3117         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
3118         (WebFrameLoaderClient::dispatchDidLayout): Deleted.
3119
3120 2016-08-18  Daniel Bates  <dabates@apple.com>
3121
3122         Ld warns of non-existent PrivateFrameworks directory when building WebKit with the public iOS 9.3 SDK
3123         https://bugs.webkit.org/show_bug.cgi?id=160979
3124
3125         Rubber-stamped by Simon Fraser.
3126
3127         Only add the SDK PrivateFrameworks directory to the FRAMEWORK_SEARCH_PATH when building for
3128         iOS Simulator, building with an iOS SDK that does not support text-based stubs, or building
3129         an Apple-internal build.
3130
3131         * Configurations/WebKitLegacy.xcconfig:
3132
3133 2016-08-18  Anders Carlsson  <andersca@apple.com>
3134
3135         Move an NPAPI-only function from WebCore to WebKit
3136         https://bugs.webkit.org/show_bug.cgi?id=160967
3137
3138         Reviewed by Sam Weinig.
3139
3140         * Plugins/WebNetscapePluginView.h:
3141         * Plugins/WebNetscapePluginView.mm:
3142         (-[WebNetscapePluginView getVariable:value:]):
3143         (-[WebNetscapePluginView _destroyPlugin]):
3144
3145 2016-08-18  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
3146
3147         [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
3148         https://bugs.webkit.org/show_bug.cgi?id=156096
3149
3150         Reviewed by Dean Jackson.
3151
3152         Adds:
3153         - Setup interface for enabling runtime flag for Web animations through preferences.
3154
3155         * WebView/WebPreferenceKeysPrivate.h:
3156         * WebView/WebPreferences.mm:
3157         (+[WebPreferences initialize]):
3158         (-[WebPreferences webAnimationsEnabled]):
3159         (-[WebPreferences setWebAnimationsEnabled:]):
3160         * WebView/WebPreferencesPrivate.h:
3161         * WebView/WebView.mm:
3162         (-[WebView _preferencesChanged:]):
3163
3164 2016-08-17  Anders Carlsson  <andersca@apple.com>
3165
3166         Remove a couple of unused WKSI function pointers
3167         https://bugs.webkit.org/show_bug.cgi?id=160946
3168
3169         Reviewed by Dan Bernstein.
3170
3171         * WebCoreSupport/WebSystemInterface.mm:
3172         (InitWebCoreSystemInterface): Deleted.
3173
3174 2016-08-16  Daniel Bates  <dabates@apple.com>
3175
3176         WKSI static library should be named by major iOS revision, not individual updates
3177         https://bugs.webkit.org/show_bug.cgi?id=160727
3178         <rdar://problem/22274848>
3179
3180         Reviewed by Alexey Proskuryakov.
3181
3182         * Configurations/Base.xcconfig:
3183         * Configurations/DebugRelease.xcconfig:
3184         * Configurations/WebKitLegacy.xcconfig:
3185
3186 2016-08-16  Darin Adler  <darin@apple.com>
3187
3188         [Cocoa] Remove dependency on Objective-C bindings in WebKit2 editing code
3189         https://bugs.webkit.org/show_bug.cgi?id=160891
3190
3191         Reviewed by Anders Carlsson.
3192
3193         * WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
3194
3195         * WebCoreSupport/WebEditorClient.mm:
3196         (attributesForAttributedStringConversion): Replaced the
3197         createExcludedElementsForAttributedStringConversion function with this one.
3198         No good reason to keep the array around instead of the dictionary.
3199         (_WebCreateFragment): Renamed from documentFragmentFromAttributedString.
3200         This is now a global function exported so it can be called by WebCore with
3201         a different way of returning its value.
3202
3203         * WebKit.exp: Added _WebCreateFragment.
3204
3205         * WebView/WebHTMLView.mm:
3206         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3207         Removed long-ago-obsolete workaround for Radar bug 5052369.
3208
3209 2016-08-15  Anders Carlsson  <andersca@apple.com>
3210
3211         Another build fix.
3212
3213         * WebKit.exp:
3214
3215 2016-08-15  Anders Carlsson  <andersca@apple.com>
3216
3217         Fix build.
3218
3219         * Configurations/WebKitLegacy.xcconfig:
3220         * WebKit.mac.exp:
3221
3222 2016-08-15  Anders Carlsson  <andersca@apple.com>
3223
3224         Remove OldWebAssertions.c
3225         https://bugs.webkit.org/show_bug.cgi?id=160862
3226
3227         Reviewed by Dan Bernstein.
3228
3229         These functions were used by an old version of iWeb. The latest version of iWeb no longer uses them.
3230
3231         * Misc/OldWebAssertions.c: Removed.
3232         (WebReportAssertionFailure): Deleted.
3233         (WebReportError): Deleted.
3234
3235 2016-08-15  Anders Carlsson  <andersca@apple.com>
3236
3237         Remove WebKeyGenerator
3238         https://bugs.webkit.org/show_bug.cgi?id=160854
3239
3240         Reviewed by Dan Bernstein.
3241
3242         This SPI class is no longer used by Safari.
3243
3244         * WebCoreSupport/WebKeyGenerator.h: Removed.
3245         * WebCoreSupport/WebKeyGenerator.mm: Removed.
3246         (+[WebKeyGenerator sharedGenerator]): Deleted.
3247         (toWebCertificateParseResult): Deleted.
3248         (-[WebKeyGenerator addCertificatesToKeychainFromData:]): Deleted.
3249         * WebView/WebFrameView.mm:
3250
3251 2016-08-15  Daniel Bates  <dabates@apple.com>
3252
3253         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
3254         private frameworks and libraries
3255         https://bugs.webkit.org/show_bug.cgi?id=155931
3256         <rdar://problem/25807989>
3257
3258         Reviewed by Dan Bernstein.
3259
3260         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
3261         where X is the major version of the active iOS SDK.
3262
3263         * Configurations/WebKitLegacy.xcconfig:
3264
3265 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
3266
3267         Add a setting and preferences to enable visual viewport mode
3268         https://bugs.webkit.org/show_bug.cgi?id=160843
3269
3270         Reviewed by Sam Weinig.
3271
3272         Hook up the visualViewportEnabled setting for WebKit1.
3273
3274         * WebView/WebPreferenceKeysPrivate.h:
3275         * WebView/WebPreferences.mm:
3276         (+[WebPreferences initialize]):
3277         (-[WebPreferences visualViewportEnabled]):
3278         (-[WebPreferences setVisualViewportEnabled:]):
3279         * WebView/WebPreferencesPrivate.h:
3280
3281 2016-08-15  Joseph Pecoraro  <pecoraro@apple.com>
3282
3283         Remove unused includes of wtf headers
3284         https://bugs.webkit.org/show_bug.cgi?id=160839
3285
3286         Reviewed by Alex Christensen.
3287
3288         * History/BinaryPropertyList.cpp:
3289         * History/WebBackForwardList.mm:
3290         * History/WebHistoryItemInternal.h:
3291         * Misc/WebNSFileManagerExtras.mm:
3292         * Plugins/Hosted/NetscapePluginHostProxy.h:
3293         * WebCoreSupport/WebPlatformStrategies.mm:
3294         * WebCoreSupport/WebSelectionServiceController.mm:
3295         * WebCoreSupport/WebUserMediaClient.h:
3296
3297 2016-08-12  Anders Carlsson  <andersca@apple.com>
3298
3299         Move the plug-in and WebGL blacklist code to WebCore
3300         https://bugs.webkit.org/show_bug.cgi?id=160831
3301
3302         Reviewed by Sam Weinig.
3303
3304         Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.
3305
3306         * WebCoreSupport/WebFrameLoaderClient.mm:
3307         (shouldBlockPlugin):
3308         (WebFrameLoaderClient::createPlugin):
3309         (WebFrameLoaderClient::createJavaAppletWidget):
3310         (shouldBlockWebGL):
3311         (WebFrameLoaderClient::webGLPolicyForURL):
3312         (WebFrameLoaderClient::resolveWebGLPolicyForURL):
3313
3314 2016-08-14  Daniel Bates  <dabates@apple.com>
3315
3316         Fix compiler errors when building iOS WebKit using the iOS 10 beta SDK
3317         https://bugs.webkit.org/show_bug.cgi?id=160725
3318
3319         Reviewed by Sam Weinig.
3320
3321         OSAtomicCompareAndSwap32() has been deprecated as of the iOS 10 beta SDK. For now,
3322         silence the complier warning.
3323
3324         * WebView/WebView.mm:
3325         (-[WebView _dispatchTileDidDraw:]):
3326
3327 2016-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3328
3329         Remove always true JSC::Debugger::needPauseHandling virtual method
3330         https://bugs.webkit.org/show_bug.cgi?id=160822
3331
3332         Reviewed by Mark Lam.
3333
3334         * WebView/WebScriptDebugger.h:
3335
3336 2016-08-11  Chris Dumez  <cdumez@apple.com>
3337
3338         Regression(r204268): Mail crashes when trying to compose an email
3339         https://bugs.webkit.org/show_bug.cgi?id=160775
3340
3341         Reviewed by Anders Carlsson.
3342
3343         Properly initialize PageConfiguration.pluginInfoProvider in
3344         [WebView initSimpleHTMLDocumentWithStyle] to avoid a null
3345         dereference in Mail when trying to compose an email.
3346
3347         * WebView/WebView.mm:
3348         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3349
3350 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3351
3352         Sort the feature flags in the FEATURE_DEFINES lines
3353         https://bugs.webkit.org/show_bug.cgi?id=160742
3354
3355         Reviewed by Anders Carlsson.
3356
3357         * Configurations/FeatureDefines.xcconfig:
3358
3359 2016-08-09  Alex Christensen  <achristensen@webkit.org>
3360
3361         Move NetworkStorageSession management to WebCore
3362         https://bugs.webkit.org/show_bug.cgi?id=160173
3363
3364         Reviewed by Brady Eidson.
3365
3366         * WebCoreSupport/WebFrameNetworkingContext.mm:
3367         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3368         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3369         * WebCoreSupport/WebPlatformStrategies.mm:
3370         * WebView/WebView.mm:
3371
3372 2016-08-09  Anders Carlsson  <andersca@apple.com>
3373
3374         Instantiate WebKit plug-ins at layout time, instead of at style resolution time
3375         https://bugs.webkit.org/show_bug.cgi?id=160715
3376
3377         Reviewed by Tim Horton.
3378
3379         * WebCoreSupport/WebFrameLoaderClient.mm:
3380         (WebFrameLoaderClient::objectContentType):
3381
3382 2016-08-09  George Ruan  <gruan@apple.com>
3383
3384         Implement functionality of media capture on iOS
3385         https://bugs.webkit.org/show_bug.cgi?id=158945
3386         <rdar://problem/26893343>
3387
3388         Reviewed by Tim Horton.
3389
3390         * Configurations/FeatureDefines.xcconfig: Enable Media Capture feature
3391         for iOS.
3392
3393 2016-08-09  Anders Carlsson  <andersca@apple.com>
3394
3395         Get rid of PluginStrategy
3396         https://bugs.webkit.org/show_bug.cgi?id=160696
3397
3398         Reviewed by Dan Bernstein.
3399
3400         * WebCoreSupport/WebPlatformStrategies.h:
3401         * WebCoreSupport/WebPlatformStrategies.mm:
3402         (WebPlatformStrategies::createPluginStrategy): Deleted.
3403         * WebCoreSupport/WebPluginInfoProvider.h:
3404         * WebCoreSupport/WebPluginInfoProvider.mm:
3405         (WebPluginInfoProvider::setPluginLoadClientPolicy): Deleted.
3406         (WebPluginInfoProvider::clearPluginClientPolicies): Deleted.
3407
3408 2016-08-09  Anders Carlsson  <andersca@apple.com>
3409
3410         Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
3411         https://bugs.webkit.org/show_bug.cgi?id=160694
3412
3413         Reviewed by Dan Bernstein.
3414
3415         * WebCoreSupport/WebPlatformStrategies.h:
3416         * WebCoreSupport/WebPlatformStrategies.mm:
3417         (WebPlatformStrategies::createPluginStrategy):
3418         (WebPlatformStrategies::refreshPlugins): Deleted.
3419         (WebPlatformStrategies::getPluginInfo): Deleted.
3420         (WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
3421         (WebPlatformStrategies::setPluginLoadClientPolicy): Deleted.
3422         (WebPlatformStrategies::clearPluginClientPolicies): Deleted.
3423         * WebCoreSupport/WebPluginInfoProvider.mm:
3424         (WebPluginInfoProvider::refreshPlugins):
3425         (WebPluginInfoProvider::getPluginInfo):
3426         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3427
3428 2016-08-08  Anders Carlsson  <andersca@apple.com>
3429
3430         Add a new PluginInfoProvider class, to replace PluginStrategy
3431         https://bugs.webkit.org/show_bug.cgi?id=160670
3432
3433         Reviewed by Sam Weinig.
3434
3435         Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
3436
3437         * WebCoreSupport/WebPluginInfoProvider.h: Added.
3438         * WebCoreSupport/WebPluginInfoProvider.mm: Added.
3439         (WebPluginInfoProvider::singleton):
3440         (WebPluginInfoProvider::WebPluginInfoProvider):
3441         (WebPluginInfoProvider::~WebPluginInfoProvider):
3442         (WebPluginInfoProvider::refreshPlugins):
3443         (WebPluginInfoProvider::getPluginInfo):
3444         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3445         (WebPluginInfoProvider::setPluginLoadClientPolicy):
3446         (WebPluginInfoProvider::clearPluginClientPolicies):
3447         * WebView/WebView.mm:
3448         (-[WebView _commonInitializationWithFrameName:groupName:]):
3449
3450 2016-08-02  Enrica Casucci  <enrica@apple.com>
3451
3452         Allow building with content filtering disabled.
3453         https://bugs.webkit.org/show_bug.cgi?id=160454
3454
3455         Reviewed by Simon Fraser.
3456
3457         * Configurations/FeatureDefines.xcconfig:
3458         * WebCoreSupport/WebFrameLoaderClient.h:
3459         * WebCoreSupport/WebFrameLoaderClient.mm:
3460         (WebFrameLoaderClient::blockedByContentFilterError):
3461
3462 2016-08-02  Anders Carlsson  <andersca@apple.com>
3463
3464         Remove more unused/uninstalled Objective-C DOM bindings
3465         https://bugs.webkit.org/show_bug.cgi?id=160464
3466
3467         Reviewed by Darin Adler.
3468
3469         Stop installing unused headers.
3470
3471         * MigrateHeaders.make:
3472
3473 2016-08-01  Anders Carlsson  <andersca@apple.com>
3474
3475         Bring back a file - it needs to be copied by WebCore.
3476
3477         * MigrateHeaders.make:
3478
3479 2016-08-01  Anders Carlsson  <andersca@apple.com>
3480
3481         Remove another file.
3482
3483         * MigrateHeaders.make:
3484
3485 2016-08-01  Anders Carlsson  <andersca@apple.com>
3486
3487         Remove a file.
3488
3489         * MigrateHeaders.make:
3490
3491 2016-08-01  Anders Carlsson  <andersca@apple.com>
3492
3493         Freeze all the DOMHTML* Objective-C bindings
3494         https://bugs.webkit.org/show_bug.cgi?id=160424
3495
3496         Reviewed by Tim Horton.
3497
3498         Don't migrate DOMHTMLEmbedElementPrivate.h - it was just an empty header.
3499
3500         * MigrateHeaders.make:
3501
3502 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
3503
3504         Remove deprecated SPI for video inline / fullscreen controls
3505         https://bugs.webkit.org/show_bug.cgi?id=160318
3506
3507         Reviewed by Tim Horton.
3508
3509         * WebView/WebPreferenceKeysPrivate.h:
3510         * WebView/WebPreferences.mm:
3511         (+[WebPreferences initialize]): Deleted.
3512         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]): Deleted.
3513         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]): Deleted.
3514         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]): Deleted.
3515         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]): Deleted.
3516         * WebView/WebPreferencesPrivate.h:
3517         * WebView/WebView.mm:
3518         (-[WebView _preferencesChanged:]): Deleted.
3519
3520 2016-07-28  Anders Carlsson  <andersca@apple.com>
3521
3522         Move a Mail.app workaround closer to where it's actually needed
3523         https://bugs.webkit.org/show_bug.cgi?id=160317
3524
3525         Reviewed by Tim Horton.
3526
3527         * WebCoreSupport/WebFrameLoaderClient.mm:
3528         (WebFrameLoaderClient::dispatchWillSendRequest):
3529         * WebView/WebFrame.mm:
3530         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Deleted.
3531
3532 2016-07-28  Anders Carlsson  <andersca@apple.com>
3533
3534         Use a RetainPtr in WebFrameLoaderClient::assignIdentifierToInitialRequest
3535         https://bugs.webkit.org/show_bug.cgi?id=160315
3536
3537         Reviewed by Tim Horton.
3538
3539         * WebCoreSupport/WebFrameLoaderClient.mm:
3540         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3541
3542 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
3543
3544         Fix the Windows debug build.
3545         
3546         WebResourceLoadScheduler's logging was a holdover from it being in WebCore,
3547         and prior to r203749 WebKit was actually using a WebCore log channel.
3548         
3549         For some reason this doesn't build on Windows debug, so just remove
3550         this logging for now.
3551
3552         * Misc/WebKitLogging.h:
3553
3554 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
3555
3556         [iPhone] Playing a video on tudou.com plays only sound, no video
3557         https://bugs.webkit.org/show_bug.cgi?id=160178
3558         <rdar://problem/27535468>
3559
3560         Reviewed by Eric Carlson and Dan Bernstein.