1 2016-12-08 Filip Pizlo <fpizlo@apple.com>
3 Enable SharedArrayBuffer, remove the flag
4 https://bugs.webkit.org/show_bug.cgi?id=165614
6 Rubber stamped by Geoffrey Garen.
8 * WebView/WebPreferencesPrivate.h:
10 2016-12-07 Dean Jackson <dino@apple.com>
12 Remove runtime toggle for pointer-lock
13 https://bugs.webkit.org/show_bug.cgi?id=165577
14 <rdar://problems/29566996>
18 Remove any runtime calls to check if pointer-lock is enabled. It's
19 either compiled in or out.
21 * WebView/WebPreferenceKeysPrivate.h:
22 * WebView/WebPreferences.mm:
23 (-[WebPreferences pointerLockEnabled]): Deleted.
24 (-[WebPreferences setPointerLockEnabled:]): Deleted.
25 * WebView/WebPreferencesPrivate.h:
27 (-[WebView _preferencesChanged:]):
29 2016-12-06 Alexey Proskuryakov <ap@apple.com>
31 Correct SDKROOT values in xcconfig files
32 https://bugs.webkit.org/show_bug.cgi?id=165487
33 rdar://problem/29539209
35 Reviewed by Dan Bernstein.
37 Fix suggested by Dan Bernstein.
39 * Configurations/DebugRelease.xcconfig:
41 2016-12-05 Simon Fraser <simon.fraser@apple.com>
43 Improve the behavior of scroll-into-view when the target is inside position:fixed
44 https://bugs.webkit.org/show_bug.cgi?id=165354
46 Reviewed by Zalan Bujtas.
48 Plumb through 'insideFixed'. We don't get compute it, so behavior from
49 these call sites won't change.
51 * WebView/WebFrame.mm:
52 (-[WebFrame _scrollDOMRangeToVisible:]):
53 (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
55 2016-12-06 Simon Fraser <simon.fraser@apple.com>
57 Enable visual viewports by default on Mac, and iOS Wk2
58 https://bugs.webkit.org/show_bug.cgi?id=165452
60 Reviewed by Zalan Bujtas.
62 Turn visual viewports on by default for WK1 on Mac.
64 * WebView/WebPreferences.mm:
65 (+[WebPreferences initialize]):
67 2016-12-05 Dean Jackson <dino@apple.com>
69 pointer lock needs to be feature detectable
70 https://bugs.webkit.org/show_bug.cgi?id=165426
71 <rdar://problem/29486715>
73 Reviewed by Antoine Quint.
75 Set the RuntimeEnabledFeature as preferences
79 (-[WebView _preferencesChanged:]):
81 2016-12-05 Ryan Haddad <ryanhaddad@apple.com>
83 Unreviewed, rolling out r209299.
85 This change appears to have caused LayoutTest failures on
90 "Improve the behavior of scroll-into-view when the target is
91 inside position:fixed"
92 https://bugs.webkit.org/show_bug.cgi?id=165354
93 http://trac.webkit.org/changeset/209299
95 2016-12-02 Simon Fraser <simon.fraser@apple.com>
97 Improve the behavior of scroll-into-view when the target is inside position:fixed
98 https://bugs.webkit.org/show_bug.cgi?id=165354
100 Reviewed by Zalan Bujtas.
102 Plumb through 'insideFixed'. We don't get compute it, so behavior from
103 these call sites won't change.
105 * WebView/WebFrame.mm:
106 (-[WebFrame _scrollDOMRangeToVisible:]):
107 (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
109 2016-12-02 Andy Estes <aestes@apple.com>
111 [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
112 https://bugs.webkit.org/show_bug.cgi?id=164492
114 Reviewed by Dan Bernstein.
116 * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
117 com.apple.$(PRODUCT_NAME:rfc1034identifier).
118 * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
119 ${PRODUCT_BUNDLE_IDENTIFIER}.
121 2016-12-02 Chris Dumez <cdumez@apple.com>
123 Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
124 https://bugs.webkit.org/show_bug.cgi?id=165328
126 Reviewed by Simon Fraser.
128 Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
130 * WebView/WebViewData.mm:
131 (-[WebViewPrivate init]):
133 2016-12-02 Chris Dumez <cdumez@apple.com>
135 [Mac][WK1] Implement new HTML interactive form validation user interface
136 https://bugs.webkit.org/show_bug.cgi?id=164483
138 Reviewed by Simon Fraser.
140 Implement new HTML interactive form validation user interface on Mac
141 WK1 and enable it by default.
143 * WebCoreSupport/WebValidationMessageClient.h: Added.
144 * WebCoreSupport/WebValidationMessageClient.mm: Added.
145 (WebValidationMessageClient::WebValidationMessageClient):
146 (WebValidationMessageClient::~WebValidationMessageClient):
147 (WebValidationMessageClient::showValidationMessage):
148 (WebValidationMessageClient::hideValidationMessage):
149 (WebValidationMessageClient::isValidationMessageVisible):
150 * WebView/WebHTMLView.mm:
151 (-[WebHTMLView _frameOrBoundsChanged]):
152 * WebView/WebView.mm:
153 (-[WebView _commonInitializationWithFrameName:groupName:]):
154 (-[WebView _willStartScrollingOrZooming]):
155 (-[WebView _contentsOfUserInterfaceItem:]):
156 (-[WebView _scaleWebView:atOrigin:]):
157 (-[WebView _didScrollDocumentInFrameView:]):
158 (-[WebView _setZoomMultiplier:isTextOnly:]):
159 (-[WebView showFormValidationMessage:withAnchorRect:]):
160 (-[WebView hideFormValidationMessage]):
161 * WebView/WebViewData.h:
162 * WebView/WebViewData.mm:
163 (-[WebViewPrivate init]):
164 * WebView/WebViewInternal.h:
165 * WebView/WebViewPrivate.h:
167 2016-12-01 Jiewen Tan <jiewen_tan@apple.com>
169 Add a runtime flag for SubtleCrypto
170 https://bugs.webkit.org/show_bug.cgi?id=164982
172 Reviewed by Brent Fulgham.
174 * WebView/WebPreferenceKeysPrivate.h:
175 * WebView/WebPreferences.mm:
176 (+[WebPreferences initialize]):
177 (-[WebPreferences subtleCryptoEnabled]):
178 (-[WebPreferences setSubtleCryptoEnabled:]):
179 * WebView/WebPreferencesPrivate.h:
180 * WebView/WebView.mm:
181 (-[WebView _preferencesChanged:]):
183 2016-11-30 Said Abou-Hallawa <sabouhallawa@apple.com>
185 Add separate settings and preferences to enable/disable async decoding for large images and animated images
186 https://bugs.webkit.org/show_bug.cgi?id=165177
188 Reviewed by Simon Fraser.
190 Hook up the async image decoding settings for WebKit1.
192 * WebView/WebPreferenceKeysPrivate.h:
193 * WebView/WebPreferences.mm:
194 (+[WebPreferences initialize]):
195 (-[WebPreferences largeImageAsyncDecodingEnabled]):
196 (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
197 (-[WebPreferences animatedImageAsyncDecodingEnabled]):
198 (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
199 (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
200 (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
201 * WebView/WebPreferencesPrivate.h:
202 * WebView/WebView.mm:
203 (-[WebView _preferencesChanged:]):
205 2016-11-29 Andy Estes <aestes@apple.com>
207 [Cocoa] Enable two clang warnings recommended by Xcode
208 https://bugs.webkit.org/show_bug.cgi?id=164498
210 Reviewed by Mark Lam.
212 * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
214 2016-11-26 Yusuke Suzuki <utatane.tea@gmail.com>
216 [WTF] Import std::optional reference implementation as WTF::Optional
217 https://bugs.webkit.org/show_bug.cgi?id=164199
219 Reviewed by Saam Barati and Sam Weinig.
221 Use WTF::Optional::value_or.
223 * DOM/DOMHTMLOptionsCollection.mm:
224 (-[DOMHTMLOptionsCollection add:index:]):
225 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
226 (WebKit::NetscapePluginInstanceProxy::evaluate):
227 * Plugins/WebNetscapePluginView.mm:
228 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
229 * WebCoreSupport/WebFrameLoaderClient.h:
230 * WebCoreSupport/WebFrameLoaderClient.mm:
231 (WebFrameLoaderClient::dispatchDidCommitLoad):
232 * WebCoreSupport/WebPaymentCoordinatorClient.h:
233 * WebCoreSupport/WebPaymentCoordinatorClient.mm:
234 (WebPaymentCoordinatorClient::completeShippingMethodSelection):
235 (WebPaymentCoordinatorClient::completeShippingContactSelection):
236 (WebPaymentCoordinatorClient::completePaymentMethodSelection):
237 * WebCoreSupport/WebSecurityOrigin.mm:
238 (-[WebSecurityOrigin port]):
239 * WebView/WebHTMLView.mm:
243 2016-11-26 Sam Weinig <sam@webkit.org>
245 Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
246 https://bugs.webkit.org/show_bug.cgi?id=164965
248 Reviewed by Simon Fraser.
250 * WebView/WebPreferenceKeysPrivate.h:
251 * WebView/WebPreferences.mm:
252 (-[WebPreferences intersectionObserverEnabled]):
253 (-[WebPreferences setIntersectionObserverEnabled:]):
254 * WebView/WebPreferencesPrivate.h:
255 * WebView/WebView.mm:
256 (-[WebView _preferencesChanged:]):
257 Add a preference, defaulting to off, for enabling IntersectionObserver.
259 2016-11-22 Dan Bernstein <mitz@apple.com>
261 [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
262 https://bugs.webkit.org/show_bug.cgi?id=165036
263 <rdar://problem/5708580>
265 Reviewed by Alexey Proskuryakov.
267 * WebView/WebHTMLView.mm:
268 (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
269 similarly to what we do in -keyDown: and to what WKWebView does with all key events.
271 2016-11-21 Alex Christensen <achristensen@webkit.org>
273 Fix Sierra CMake build after r208452
274 https://bugs.webkit.org/show_bug.cgi?id=164437
276 * WebView/WebView.mm:
277 (-[WebView updateMediaTouchBar]):
278 I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
279 It's needed for playbackSessionInterface to exist.
281 2016-11-18 Enrica Casucci <enrica@apple.com>
283 Refactor drag and drop for WebKit2 to encode DragData message exchange.
284 https://bugs.webkit.org/show_bug.cgi?id=164945
286 Reviewed by Tim Horton.
288 * WebCoreSupport/WebDragClient.h:
289 * WebCoreSupport/WebDragClient.mm:
290 (WebDragClient::actionMaskForDrag):
291 (WebDragClient::willPerformDragDestinationAction):
293 2016-11-18 Jeremy Jones <jeremyj@apple.com>
295 Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
296 https://bugs.webkit.org/show_bug.cgi?id=163801
298 Reviewed by Simon Fraser.
300 Plumb through PointerLockEnabled setting.
302 * Configurations/FeatureDefines.xcconfig:
303 * WebCoreSupport/WebChromeClient.mm:
304 (WebChromeClient::requestPointerUnlock):
305 * WebView/WebPreferenceKeysPrivate.h:
306 * WebView/WebPreferences.mm:
307 (-[WebPreferences pointerLockEnabled]):
308 (-[WebPreferences setPointerLockEnabled:]):
309 * WebView/WebPreferencesPrivate.h:
310 * WebView/WebView.mm:
311 (-[WebView _preferencesChanged:]):
313 2016-11-17 Dan Bernstein <mitz@apple.com>
315 Try to fix some non-macOS builds.
317 * WebView/WebView.mm:
319 2016-11-16 Dave Hyatt <hyatt@apple.com>
321 [CSS Parser] Add @supports, @keyframe and media query parsing options
322 https://bugs.webkit.org/show_bug.cgi?id=164821
324 Reviewed by Sam Weinig and Zalan Bujtas.
326 Fix up the create call now that fallback descriptor syntax is gone.
329 (-[DOMHTMLLinkElement _mediaQueryMatches]):
331 2016-11-17 Saam Barati <sbarati@apple.com>
333 Remove async/await compile time flag and enable tests
334 https://bugs.webkit.org/show_bug.cgi?id=164828
335 <rdar://problem/28639334>
337 Reviewed by Yusuke Suzuki.
339 * Configurations/FeatureDefines.xcconfig:
341 2016-11-17 Yusuke Suzuki <utatane.tea@gmail.com>
343 [JSC] WTF::TemporaryChange with WTF::SetForScope
344 https://bugs.webkit.org/show_bug.cgi?id=164761
346 Reviewed by Saam Barati.
348 * WebView/WebView.mm:
349 (-[WebView updateTextTouchBar]):
351 2016-11-16 Yusuke Suzuki <utatane.tea@gmail.com>
353 [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
354 https://bugs.webkit.org/show_bug.cgi?id=164827
356 Reviewed by Ryosuke Niwa.
358 * Configurations/FeatureDefines.xcconfig:
359 * WebView/WebPreferenceKeysPrivate.h:
360 * WebView/WebPreferences.mm:
361 (+[WebPreferences initialize]):
362 (-[WebPreferences es6ModulesEnabled]):
363 (-[WebPreferences setES6ModulesEnabled:]):
364 * WebView/WebPreferencesPrivate.h:
365 * WebView/WebView.mm:
366 (-[WebView _preferencesChanged:]):
368 2016-11-14 Alex Christensen <achristensen@webkit.org>
370 Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
371 https://bugs.webkit.org/show_bug.cgi?id=164720
373 Reviewed by Brady Eidson.
375 * Storage/WebDatabaseManager.mm:
376 (-[WebDatabaseManager origins]):
377 (-[WebDatabaseManager databasesWithOrigin:]):
378 (-[WebDatabaseManager deleteOrigin:]):
379 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
380 * Storage/WebDatabaseManagerClient.h:
381 * Storage/WebDatabaseManagerClient.mm:
382 (DidModifyOriginData::dispatchToMainThread):
383 (DidModifyOriginData::DidModifyOriginData):
384 (WebDatabaseManagerClient::dispatchDidModifyOrigin):
385 (WebDatabaseManagerClient::dispatchDidModifyDatabase):
386 * Storage/WebDatabaseQuotaManager.mm:
387 (-[WebDatabaseQuotaManager usage]):
388 (-[WebDatabaseQuotaManager quota]):
389 (-[WebDatabaseQuotaManager setQuota:]):
390 * Storage/WebStorageManager.mm:
391 (-[WebStorageManager origins]):
392 (-[WebStorageManager deleteOrigin:]):
393 * Storage/WebStorageTrackerClient.h:
394 * Storage/WebStorageTrackerClient.mm:
395 (WebStorageTrackerClient::dispatchDidModifyOrigin):
396 * WebCoreSupport/WebSecurityOrigin.mm:
397 (-[WebSecurityOrigin usage]):
398 (-[WebSecurityOrigin quota]):
399 (-[WebSecurityOrigin setQuota:]):
401 2016-11-13 Darin Adler <darin@apple.com>
403 Fix exception handling in SQL database code, streamline and update code
404 https://bugs.webkit.org/show_bug.cgi?id=164685
406 Reviewed by Sam Weinig.
408 * Storage/WebDatabaseManager.mm:
409 (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
411 (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
412 (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
413 but continue to use DatabaseManager.
414 (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
416 (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
418 * Storage/WebDatabaseManagerClient.h: Updated to take references.
419 * Storage/WebDatabaseManagerClient.mm:
420 (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
421 members in the class definition.
422 (DidModifyOriginData::dispatchToMainThread): Take references.
423 (DidModifyOriginData::DidModifyOriginData): Ditto.
424 (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
425 (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
426 (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
427 DatabaseTracker::singleton instead of tracker.
429 * Storage/WebDatabaseQuotaManager.mm:
430 (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
431 (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
432 (-[WebDatabaseQuotaManager quota]): Ditto.
433 (-[WebDatabaseQuotaManager setQuota:]): Ditto.
434 * WebCoreSupport/WebSecurityOrigin.mm:
435 (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
436 (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
437 (-[WebSecurityOrigin quota]): Ditto.
438 (-[WebSecurityOrigin setQuota:]): Ditto.
439 * WebView/WebFrame.mm:
440 (-[WebFrame _cacheabilityDictionary]): Pass a reference.
442 2016-11-12 Darin Adler <darin@apple.com>
444 Remove a few assorted uses of ExceptionCode
445 https://bugs.webkit.org/show_bug.cgi?id=164683
447 Reviewed by Chris Dumez.
449 * DOM/DOMDOMImplementation.mm:
450 (-[DOMImplementation createDocumentType:publicId:systemId:]):
451 Use raiseOnDOMError instead of much longer hand written equivalent.
452 (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
454 * DOM/DOMDocument.mm:
455 (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
456 so we are not using a specific exception code.
458 * DOM/DOMHTMLOptionsCollection.mm:
459 (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
460 much longer hand written equivalent.
461 * DOM/DOMHTMLSelectElement.mm:
462 (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
463 statement after calling a "no return" function.
465 * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
466 raiseOnDOMError functions that take ExceptionCode; keep the ones that take
467 Exception and ExceptionOr. Renamed the other overload of raiseDOMException
468 to raiseDOMErrorException; it is only used as the non-inline implementation
469 part of the inline raiseOnDOMError function.
470 * DOM/ExceptionHandlers.mm:
471 (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
472 to this source file instead of in the header.
473 (raiseTypeErrorException): Updated for name change.
474 (raiseNotSupportedErrorException): Added.
476 2016-11-11 Ryosuke Niwa <rniwa@webkit.org>
478 Hovering over a slotted Text node clears hover state
479 https://bugs.webkit.org/show_bug.cgi?id=164002
480 <rdar://problem/29040471>
482 Reviewed by Simon Fraser.
484 * WebView/WebImmediateActionController.mm:
485 (-[WebImmediateActionController performHitTestAtPoint:]):
487 2016-11-11 Wenson Hsieh <wenson_hsieh@apple.com>
489 [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
490 https://bugs.webkit.org/show_bug.cgi?id=164538
491 <rdar://problem/8418711>
493 Reviewed by Ryosuke Niwa.
495 Account for renaming HTMLElement::autocorrect to HTMLElement::shouldAutocorrect, as well as moving
496 WebAutocapitalizeType to WebKit from WebCore. Additionally, moves the -autocorrect and -autocapitalize SPIs out
497 of HTML(Input|Form|TextArea)ElementPrivate.h and into HTMLElementPrivate.h. This also means removing redundant
498 code for interfacing with the unwrapped HTMLElement's autocorrect and autocapitalize attributes.
501 (webAutocapitalizeType):
502 (-[DOMHTMLInputElement _autocapitalizeType]):
503 (-[DOMHTMLTextAreaElement _autocapitalizeType]):
504 * DOM/DOMHTMLElement.mm:
505 (-[DOMHTMLElement autocorrect]):
506 (-[DOMHTMLElement setAutocorrect:]):
507 (-[DOMHTMLElement autocapitalize]):
508 (-[DOMHTMLElement setAutocapitalize:]):
509 * DOM/DOMHTMLElementPrivate.h: Copied from Source/WebCore/html/Autocapitalize.h.
510 * DOM/DOMHTMLFormElement.mm:
511 (-[DOMHTMLFormElement autocorrect]): Deleted.
512 (-[DOMHTMLFormElement setAutocorrect:]): Deleted.
513 (-[DOMHTMLFormElement autocapitalize]): Deleted.
514 (-[DOMHTMLFormElement setAutocapitalize:]): Deleted.
515 * DOM/DOMHTMLInputElement.mm:
516 (-[DOMHTMLInputElement autocorrect]): Deleted.
517 (-[DOMHTMLInputElement setAutocorrect:]): Deleted.
518 (-[DOMHTMLInputElement autocapitalize]): Deleted.
519 (-[DOMHTMLInputElement setAutocapitalize:]): Deleted.
520 * DOM/DOMHTMLInputElementPrivate.h:
521 * DOM/DOMHTMLTextAreaElement.mm:
522 (-[DOMHTMLTextAreaElement autocorrect]): Deleted.
523 (-[DOMHTMLTextAreaElement setAutocorrect:]): Deleted.
524 (-[DOMHTMLTextAreaElement autocapitalize]): Deleted.
525 (-[DOMHTMLTextAreaElement setAutocapitalize:]): Deleted.
526 * DOM/DOMHTMLTextAreaElementPrivate.h:
528 We need to import DOMHTMLElementPrivate.h here to avoid breaking UIKit. We should follow this up with a UIKit
529 change to import DOMHTMLElementPrivate.h directly.
532 * DOM/WebAutocapitalizeTypes.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h.
533 * MigrateHeaders.make:
535 2016-11-11 Beth Dakin <bdakin@apple.com>
537 Move to modern TouchBar methods
538 https://bugs.webkit.org/show_bug.cgi?id=164655
540 rdar://problem/29226911
542 Reviewed by Wenson Hsieh.
544 customizationDefaultItemIdentifiers -> defaultItemIdentifiers
545 itemIdentifiers -> defaultItemIdentifiers
546 defaultItems -> templateItems
548 * WebView/WebView.mm:
549 (-[WebView _plainTextTouchBarDefaultItemIdentifiers]):
550 (-[WebView _richTextTouchBarDefaultItemIdentifiers]):
551 (-[WebView setUpTextTouchBar:]):
552 (-[WebView updateTextTouchBar]):
553 (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
554 (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
556 2016-11-11 Darin Adler <darin@apple.com>
558 Move Node from ExceptionCode to ExceptionOr
559 https://bugs.webkit.org/show_bug.cgi?id=164515
561 Reviewed by Sam Weinig.
563 * DOM/DOMHTMLSelectElement.mm:
564 (-[DOMHTMLSelectElement remove:]): Call remove instead of removeByIndex
565 now that it was renamed.
567 (-[DOMNode setNodeValue:]): Updated exception handling.
568 (-[DOMNode setPrefix:]): Ditto.
569 (-[DOMNode setTextContent:]): Ditto.
570 (-[DOMNode insertBefore:refChild:]): Ditto.
571 (-[DOMNode replaceChild:oldChild:]): Ditto.
572 (-[DOMNode removeChild:]): Ditto.
573 (-[DOMNode appendChild:]): Ditto.
574 (-[DOMNode cloneNode:]): Ditto.
576 2016-11-11 Beth Dakin <bdakin@apple.com>
578 Get touch bar code building for open source builds
579 https://bugs.webkit.org/show_bug.cgi?id=164610
581 Reviewed by Wenson Hsieh.
585 2016-11-10 Alex Christensen <achristensen@webkit.org>
587 Fix assertion after r208534.
588 https://bugs.webkit.org/show_bug.cgi?id=160497
590 * WebView/WebView.mm:
591 (-[WebView _commonInitializationWithFrameName:groupName:]):
592 (WebInstallMemoryPressureHandler):
593 WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
594 When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
595 only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
597 2016-11-10 Alex Christensen <achristensen@webkit.org>
599 Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
600 https://bugs.webkit.org/show_bug.cgi?id=164573
602 Reviewed by Brady Eidson.
604 * WebCoreSupport/WebSecurityOrigin.mm:
605 (-[WebSecurityOrigin databaseIdentifier]):
607 2016-10-14 Carlos Garcia Campos <cgarcia@igalia.com>
609 MemoryPressureHandler shouldn't know how to release WebCore memory
610 https://bugs.webkit.org/show_bug.cgi?id=160497
612 Reviewed by Michael Catanzaro.
614 Set the low memory handler before installing the memory pressure handler.
616 * WebView/WebView.mm:
617 (-[WebView _commonInitializationWithFrameName:groupName:]):
619 2016-11-09 Ryosuke Niwa <rniwa@webkit.org>
621 WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
622 https://bugs.webkit.org/show_bug.cgi?id=164501
623 <rdar://problem/29152282>
625 Reviewed by Sam Weinig.
627 Align what [WebHTMLView attributedString] returns to what would be used on copy & paste by using HTMLConverter
628 instead of _initWithDOMRange in [WebHTMLView _attributeStringFromDOMRange].
630 * WebView/WebHTMLView.mm:
631 (-[WebHTMLView _attributedStringFromDOMRange:]): Renamed from _attributeStringFromDOMRange.
632 (-[WebHTMLView attributedString]):
633 (-[WebHTMLView selectedAttributedString]):
634 (-[WebHTMLView selectedString]): Moved to reduce the number of occurrences of the if-defs.
636 2016-11-04 Brent Fulgham <bfulgham@apple.com>
638 Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
639 https://bugs.webkit.org/show_bug.cgi?id=155185
640 <rdar://problem/11101440>
642 Reviewed by Brady Eidson.
644 Provide SPI to access the new quirk for localStorage. The quirk defaults to 'on'. When active, this
645 quirk says that localStorage access should be granted, without needing to grant universal file access.
647 If the quirk is turned off, then localStorage is blocked unless the WebKit client explicitly
648 grants universal file access.
650 * WebView/WebPreferenceKeysPrivate.h:
651 * WebView/WebPreferences.mm:
652 (-[WebPreferences needsLocalStorageQuirk]): Added.
653 (-[WebPreferences setNeedsLocalStorageQuirk:]): Added.
654 * WebView/WebPreferencesPrivate.h:
655 * WebView/WebView.mm:
656 (-[WebView _preferencesChanged:]): Honor the new localStorage quirk.
658 2016-11-09 Alex Christensen <achristensen@webkit.org>
660 Clean up Storage code
661 https://bugs.webkit.org/show_bug.cgi?id=164562
663 Reviewed by Brady Eidson.
665 * Storage/WebStorageManager.mm:
666 (-[WebStorageManager origins]):
667 (-[WebStorageManager deleteAllOrigins]):
668 (-[WebStorageManager deleteOrigin:]):
669 (-[WebStorageManager diskUsageForOrigin:]):
670 (-[WebStorageManager syncLocalStorage]):
671 (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
672 (+[WebStorageManager setStorageDatabaseIdleInterval:]):
673 (+[WebStorageManager closeIdleLocalStorageDatabases]):
674 (WebKitInitializeStorageIfNecessary):
675 * WebView/WebView.mm:
676 (+[WebView _applicationWillTerminate]):
678 2016-11-09 Beth Dakin <bdakin@apple.com>
680 Another attempted build fix.
682 * WebView/WebView.mm:
684 2016-11-09 Beth Dakin <bdakin@apple.com>
688 * WebView/WebView.mm:
690 2016-11-09 Darin Adler <darin@apple.com>
692 Move Range from ExceptionCode to ExceptionOr
693 https://bugs.webkit.org/show_bug.cgi?id=164457
695 Reviewed by Alex Christensen.
698 (-[DOMRange setStart:offset:]): Updated exception handling.
699 (-[DOMRange setEnd:offset:]): Ditto.
700 (-[DOMRange setStartBefore:]): Ditto.
701 (-[DOMRange setStartAfter:]): Ditto.
702 (-[DOMRange setEndBefore:]): Ditto.
703 (-[DOMRange setEndAfter:]): Ditto.
704 (-[DOMRange selectNode:]): Ditto.
705 (-[DOMRange selectNodeContents:]): Ditto.
706 (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
707 (-[DOMRange deleteContents]): Ditto.
708 (-[DOMRange extractContents]): Ditto.
709 (-[DOMRange cloneContents]): Ditto.
710 (-[DOMRange insertNode:]): Ditto.
711 (-[DOMRange surroundContents:]): Ditto.
712 (-[DOMRange createContextualFragment:]): Ditto.
713 (-[DOMRange compareNode:]): Ditto.
714 (-[DOMRange intersectsNode:]): Ditto.
715 (-[DOMRange comparePoint:offset:]): Ditto.
716 (-[DOMRange isPointInRange:offset:]): Ditto.
717 (-[DOMRange expand:]): Ditto.
718 * WebView/WebFrame.mm:
719 (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
720 (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
721 This function was incorrectly implemented (set both start and end of
722 the range to the computed start), not declared in any header file,
723 not used anywhere inside WebKit, and I also could not find a use of it
724 in outside-WebKit Apple code.
725 * mac/DOM/DOMUIKitExtensions.mm:
726 (-[DOMRange move:inDirection:]): Ditto.
727 (-[DOMRange extend:inDirection:]): Ditto.
729 2016-11-09 Darin Adler <darin@apple.com>
731 Move EventTarget from ExceptionCode to ExceptionOr
732 https://bugs.webkit.org/show_bug.cgi?id=164465
734 Reviewed by Youenn Fablet.
737 (-[DOMNode dispatchEvent:]): Updated exception handling.
739 2016-11-09 Chris Dumez <cdumez@apple.com>
741 [Mac] Stop using deprecated AppKit enumeration values
742 https://bugs.webkit.org/show_bug.cgi?id=164494
744 Reviewed by Darin Adler.
746 Stop using deprecated AppKit enumeration values.
748 * Carbon/CarbonWindowAdapter.mm:
749 (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
750 (-[CarbonWindowAdapter sendSuperEvent:]):
751 * Plugins/Hosted/NetscapePluginHostProxy.mm:
752 (WebKit::NetscapePluginHostProxy::beginModal):
753 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
754 (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
755 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
756 (-[WebHostedNetscapePluginView drawRect:]):
757 * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
758 (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
759 * WebCoreSupport/PopupMenuMac.mm:
760 (PopupMenuMac::populate):
761 (PopupMenuMac::show):
762 * WebCoreSupport/WebContextMenuClient.mm:
763 (WebContextMenuClient::showContextMenu):
764 * WebCoreSupport/WebFrameLoaderClient.mm:
765 (WebFrameLoaderClient::actionDictionary):
766 * WebCoreSupport/WebInspectorClient.mm:
767 (WebInspectorFrontendClient::canAttach):
768 (-[WebInspectorWindowController window]):
769 * WebInspector/WebNodeHighlight.mm:
770 (-[WebNodeHighlight initWithTargetView:inspectorController:]):
771 * WebView/WebFrameView.mm:
772 (-[WebFrameView keyDown:keyDown:]):
773 * WebView/WebFullScreenController.mm:
774 (-[WebFullScreenController init]):
775 (createBackgroundFullscreenWindow):
776 * WebView/WebHTMLView.mm:
777 (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
778 (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
779 (-[WebHTMLView _updateMouseoverWithFakeEvent]):
781 (-[WebHTMLView hitTest:]):
782 (-[WebHTMLView _sendToolTipMouseExited]):
783 (-[WebHTMLView _sendToolTipMouseEntered]):
784 (mouseEventIsPartOfClickOrDrag):
785 (-[WebHTMLView _updateMouseoverWithEvent:]):
786 (-[WebHTMLView _autoscroll]):
787 (-[WebHTMLView acceptsFirstResponder]):
788 (-[WebHTMLView viewDidMoveToWindow]):
789 (-[WebHTMLView mouseDown:mouseDown:]):
790 (currentKeyboardEvent):
791 (-[WebHTMLView _handleStyleKeyEquivalent:]):
792 (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
793 * WebView/WebPDFView.mm:
794 (-[WebPDFView hitTest:]):
795 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
796 (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
797 * WebView/WebTextCompletionController.mm:
798 (-[WebTextCompletionController _buildUI]):
799 (-[WebTextCompletionController _placePopupWindow:]):
800 * WebView/WebView.mm:
801 (-[WebView applicationFlags:]):
803 2016-11-09 Beth Dakin <bdakin@apple.com>
805 Support TouchBar in WebKit
806 https://bugs.webkit.org/show_bug.cgi?id=164437
808 rdar://problem/28876524
810 Reviewed by Darin Adler.
812 * WebCoreSupport/WebEditorClient.mm:
813 (WebEditorClient::respondToChangedSelection):
814 (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
815 * WebView/WebHTMLView.mm:
816 (-[WebHTMLView candidateListTouchBarItem]):
817 * WebView/WebView.mm:
818 (-[_WebTextListTouchBarViewController initWithWebView:]):
819 (-[_WebTextListTouchBarViewController _selectList:]):
820 (-[_WebTextListTouchBarViewController setCurrentListType:]):
821 (-[WebTextTouchBarItemController initWithWebView:]):
822 (-[WebTextTouchBarItemController itemForIdentifier:]):
823 (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
824 (-[WebTextTouchBarItemController setTextIsBold:]):
825 (-[WebTextTouchBarItemController setTextIsItalic:]):
826 (-[WebTextTouchBarItemController setTextIsUnderlined:]):
827 (-[WebTextTouchBarItemController _webChangeTextStyle:]):
828 (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
829 (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
830 (-[WebTextTouchBarItemController textColor]):
831 (-[WebTextTouchBarItemController setTextColor:]):
832 (-[WebTextTouchBarItemController _webChangeColor:]):
833 (-[WebTextTouchBarItemController textListViewController]):
834 (-[WebView _commonInitializationWithFrameName:groupName:]):
835 (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
836 (-[WebView shouldRequestCandidates]):
837 (-[WebView forceRequestCandidatesForTesting]):
838 (-[WebView makeTouchBar]):
839 (-[WebView touchBar:makeItemForIdentifier:]):
840 (textCheckingResultFromNSTextCheckingResult):
841 (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
842 (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
843 (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
844 (-[WebView _clearPlaybackControlsManager]):
845 (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
846 (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
847 (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
848 (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
849 (-[WebView touchBarDidExitCustomization:]):
850 (-[WebView touchBarWillEnterCustomization:]):
851 (-[WebView didChangeAutomaticTextCompletion:]):
852 (-[WebView setUpTextTouchBar:]):
853 (-[WebView _isRichlyEditable]):
854 (-[WebView textTouchBar]):
855 (-[WebView updateTextTouchBar]):
856 (-[WebView updateMediaTouchBar]):
857 (-[WebView updateTouchBar]):
858 (-[WebView prepareForMouseDown]):
859 (-[WebView prepareForMouseUp]):
860 (-[WebView webViewAdditionsWillDestroyView]):
861 (-[WebView candidateList]):
862 (-[WebView updateWebViewAdditions]): Deleted.
863 * WebView/WebViewData.h:
864 * WebView/WebViewInternal.h:
865 * WebView/WebViewPrivate.h:
867 2016-11-04 Wenson Hsieh <wenson_hsieh@apple.com>
869 Safari does not emit composition end if blurred for dead key / Japanese IME
870 https://bugs.webkit.org/show_bug.cgi?id=164369
871 <rdar://problem/29050439>
873 Reviewed by Ryosuke Niwa.
875 When canceling a composition, make sure that we clear the system IME state.
877 * WebCoreSupport/WebEditorClient.h:
878 * WebCoreSupport/WebEditorClient.mm:
879 (WebEditorClient::canceledComposition):
881 2016-11-04 Said Abou-Hallawa <sabouhallawa@apple.com>
883 Add a setting and preferences to enable/disable async image decoding
884 https://bugs.webkit.org/show_bug.cgi?id=164417
886 Reviewed by Simon Fraser.
888 Hook up the asyncImageDecodingEnabled setting for WebKit1.
890 * WebView/WebPreferenceKeysPrivate.h:
891 * WebView/WebPreferences.mm:
892 (+[WebPreferences initialize]):
893 (-[WebPreferences asyncImageDecodingEnabled]):
894 (-[WebPreferences setAsyncImageDecodingEnabled:]):
895 * WebView/WebPreferencesPrivate.h:
896 * WebView/WebView.mm:
897 (-[WebView _preferencesChanged:]):
899 2016-11-01 Alex Christensen <achristensen@webkit.org>
901 Remove PassRefPtr from DumpRenderTree
902 https://bugs.webkit.org/show_bug.cgi?id=164307
904 Reviewed by Sam Weinig.
906 * WebView/WebGeolocationPosition.mm:
907 (-[WebGeolocationPosition initWithGeolocationPosition:]):
909 2016-11-02 Romain Bellessort <romain.bellessort@crf.canon.fr>
911 [Readable Streams API] Enable creation of ReadableByteStreamController
912 https://bugs.webkit.org/show_bug.cgi?id=164014
914 Reviewed by Youenn Fablet.
916 Added flag for the byte stream part of Readable Streams API.
918 * Configurations/FeatureDefines.xcconfig:
920 2016-11-01 Ryosuke Niwa <rniwa@webkit.org>
922 Remove CUSTOM_ELEMENTS build flag
923 https://bugs.webkit.org/show_bug.cgi?id=164267
925 Reviewed by Antti Koivisto.
927 Removed the build flag.
929 * Configurations/FeatureDefines.xcconfig:
930 * WebView/WebPreferences.mm:
931 (+[WebPreferences initialize]):
932 * WebView/WebView.mm:
933 (-[WebView _preferencesChanged:]):
935 2016-11-01 Eric Carlson <eric.carlson@apple.com>
937 [MediaStream] restrict media capture secure connections
938 https://bugs.webkit.org/show_bug.cgi?id=164234
939 <rdar://problem/28944906>
941 Reviewed by Alex Christensen.
943 * WebView/WebPreferenceKeysPrivate.h:
944 * WebView/WebPreferences.mm:
945 (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
946 (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
947 (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
948 * WebView/WebPreferencesPrivate.h:
950 * WebView/WebView.mm:
951 (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
953 2016-10-29 Filip Pizlo <fpizlo@apple.com>
955 JSC should support SharedArrayBuffer
956 https://bugs.webkit.org/show_bug.cgi?id=163986
958 Reviewed by Keith Miller.
960 Support the RuntimeFlag.
962 * WebView/WebPreferencesPrivate.h:
964 2016-10-31 Wenson Hsieh <wenson_hsieh@apple.com>
966 [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
967 https://bugs.webkit.org/show_bug.cgi?id=164236
968 <rdar://problem/28747712>
970 Reviewed by Beth Dakin.
972 See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
975 * WebCoreSupport/WebEditorClient.mm:
976 (WebEditorClient::respondToChangedSelection):
977 * WebView/WebImmediateActionController.mm:
978 (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
980 2016-10-31 Darin Adler <darin@apple.com>
982 Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
983 https://bugs.webkit.org/show_bug.cgi?id=164214
985 Reviewed by Alex Christensen.
987 * DOM/DOMCSSPrimitiveValue.mm:
988 (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
990 (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
992 * DOM/DOMDocument.mm:
993 (-[DOMDocument querySelector:]): Updated exception handling.
994 (-[DOMDocument querySelectorAll:]): Ditto.
995 * DOM/DOMDocumentFragment.mm:
996 (-[DOMDocumentFragment querySelector:]): Ditto.
997 (-[DOMDocumentFragment querySelectorAll:]): Ditto.
999 (-[DOMElement querySelector:]): Ditto.
1000 (-[DOMElement querySelectorAll:]): Ditto.
1002 2016-10-31 Darin Adler <darin@apple.com>
1004 Convert Document from ExceptionCode to Exception
1005 https://bugs.webkit.org/show_bug.cgi?id=164212
1007 Reviewed by Alex Christensen.
1009 * DOM/DOMDocument.mm:
1010 (-[DOMDocument setXmlVersion:]): Updated exception handling.
1011 (-[DOMDocument cookie]): Ditto.
1012 (-[DOMDocument setCookie:]): Ditto.
1013 (-[DOMDocument setBody:]): Ditto.
1014 (-[DOMDocument createElement:]): Ditto.
1015 (-[DOMDocument createCDATASection:]): Ditto.
1016 (-[DOMDocument createProcessingInstruction:data:]): Ditto.
1017 (-[DOMDocument createAttribute:]): Ditto.
1018 (-[DOMDocument createEntityReference:]): Ditto.
1019 (-[DOMDocument importNode:deep:]): Ditto.
1020 (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
1021 (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
1022 (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
1023 (-[DOMDocument adoptNode:]): Ditto.
1024 (-[DOMDocument createEvent:]): Ditto.
1026 2016-10-30 Darin Adler <darin@apple.com>
1028 Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
1029 https://bugs.webkit.org/show_bug.cgi?id=164206
1031 Reviewed by Chris Dumez.
1033 * DOM/DOMElement.mm:
1034 (-[DOMElement setInnerHTML:]): Updated exception handling.
1035 (-[DOMElement setOuterHTML:]): Ditto.
1036 (-[DOMElement setAttribute:value:]): Ditto.
1037 (-[DOMElement setAttributeNode:]): Ditto.
1038 (-[DOMElement removeAttributeNode:]): Ditto.
1039 (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
1040 (-[DOMElement setAttributeNodeNS:]): Ditto.
1041 (-[DOMElement matches:]): Ditto.
1042 (-[DOMElement closest:]): Ditto.
1043 (-[DOMElement webkitMatchesSelector:]): Ditto.
1044 * DOM/DOMHTMLElement.mm:
1045 (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
1046 (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
1047 (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
1048 * DOM/DOMNamedNodeMap.mm:
1049 (-[DOMNamedNodeMap setNamedItem:]): Ditto.
1050 (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
1051 (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
1052 (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
1054 2016-10-29 Darin Adler <darin@apple.com>
1056 Convert more of DOM from ExceptionCode to Exception
1057 https://bugs.webkit.org/show_bug.cgi?id=164173
1059 Reviewed by Ryosuke Niwa.
1061 * DOM/DOMCharacterData.mm:
1062 (-[DOMCharacterData substringData:length:]): Updated since this
1063 now uses ExceptionOr.
1064 (-[DOMCharacterData insertData:data:]): Ditto.
1065 (-[DOMCharacterData deleteData:length:]): Ditto.
1066 (-[DOMCharacterData replaceData:length:data:]): Ditto.
1068 (-[DOMText splitText:]): Ditto.
1069 (-[DOMText replaceWholeText:]): Removed unneeded exception code
1070 handling from function that does not throw an exception.
1072 2016-10-28 Darin Adler <darin@apple.com>
1074 Move all classes in the HTML directory from ExceptionCode to Exception
1075 https://bugs.webkit.org/show_bug.cgi?id=163876
1077 Reviewed by Sam Weinig.
1079 * DOM/DOMCharacterData.mm:
1080 (-[DOMCharacterData remove]): Updated exception handling.
1081 * DOM/DOMDOMTokenList.mm:
1082 (-[DOMDOMTokenList toggle:force:]): Ditto.
1083 * DOM/DOMDocumentType.mm:
1084 (-[DOMDocumentType remove]): Ditto.
1085 * DOM/DOMElement.mm:
1086 (-[DOMElement remove]): Ditto.
1088 (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
1089 * DOM/DOMHTMLCanvasElement.mm:
1090 (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
1091 * DOM/DOMHTMLElement.mm:
1092 (-[DOMHTMLElement setInnerText:]): Ditto.
1093 (-[DOMHTMLElement setOuterText:]): Ditto.
1094 (-[DOMHTMLElement setContentEditable:]): Ditto.
1095 * DOM/DOMHTMLInputElement.mm:
1096 (-[DOMHTMLInputElement setMaxLength:]): Ditto.
1097 (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
1098 (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
1099 (-[DOMHTMLInputElement stepUp:]): Ditto.
1100 (-[DOMHTMLInputElement stepDown:]): Ditto.
1101 (-[DOMHTMLInputElement setRangeText:]): Ditto.
1102 (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
1103 * DOM/DOMHTMLMarqueeElement.mm:
1104 (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
1105 * DOM/DOMHTMLMediaElement.mm:
1106 (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
1107 (-[DOMHTMLMediaElement setVolume:]): Ditto.
1108 * DOM/DOMHTMLOptionsCollection.mm:
1109 (-[DOMHTMLOptionsCollection setLength:]): Ditto.
1110 * DOM/DOMHTMLTableElement.mm:
1111 (-[DOMHTMLTableElement setCaption:]): Ditto.
1112 (-[DOMHTMLTableElement setTHead:]): Ditto.
1113 (-[DOMHTMLTableElement setTFoot:]): Ditto.
1114 (-[DOMHTMLTableElement insertRow:]): Ditto.
1115 (-[DOMHTMLTableElement deleteRow:]): Ditto.
1116 * DOM/DOMHTMLTableRowElement.mm:
1117 (-[DOMHTMLTableRowElement insertCell:]): Ditto.
1118 (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
1119 * DOM/DOMHTMLTableSectionElement.mm:
1120 (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
1121 (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
1122 * DOM/DOMHTMLTextAreaElement.mm:
1123 (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
1124 (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
1125 (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
1126 * DOM/DOMHTMLVideoElement.mm:
1127 (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
1128 (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
1129 version (lowercase S) instead of repeating the logic from that method.
1130 (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
1131 * DOM/DOMTimeRanges.mm:
1132 (-[DOMTimeRanges start:]): Updated exception handling.
1133 (-[DOMTimeRanges end:]): Ditto.
1135 2016-10-27 Chris Dumez <cdumez@apple.com>
1137 Regression(r203601): Caused crashes in iBooks
1138 https://bugs.webkit.org/show_bug.cgi?id=164093
1139 <rdar://problem/28745634>
1141 Reviewed by Darin Adler.
1143 Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
1144 which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
1147 (-[DOMNode compareDocumentPosition:]):
1149 2016-10-27 Wenson Hsieh <wenson_hsieh@apple.com>
1151 Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
1152 https://bugs.webkit.org/show_bug.cgi?id=163948
1153 <rdar://problem/28921433>
1155 Reviewed by Darin Adler.
1157 Add support for new drag and drop-related EditAction enum values.
1159 * WebCoreSupport/WebEditorClient.mm:
1160 (undoNameForEditAction):
1162 2016-10-27 Dan Bernstein <mitz@apple.com>
1164 Reapplied the configuration changes from r207934 without breaking iOS builds.
1166 * Configurations/Base.xcconfig:
1167 * Configurations/WebKitLegacy.xcconfig:
1169 2016-10-27 Dan Bernstein <mitz@apple.com>
1171 Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
1173 * Configurations/Base.xcconfig:
1174 * Configurations/WebKitLegacy.xcconfig:
1176 2016-10-26 Dan Bernstein <mitz@apple.com>
1178 [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
1179 https://bugs.webkit.org/show_bug.cgi?id=164048
1181 Reviewed by Tim Horton.
1183 * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
1184 * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
1187 * History/WebBackForwardList.h: Fixed parameter name in @param entry.
1188 * Misc/WebDownload.h: Removed empty entries.
1189 * Misc/WebIconDatabase.h: Remove incorrect @param entries.
1190 * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
1191 * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
1192 * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
1193 * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
1194 * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
1195 * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
1196 * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
1197 Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
1198 * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
1199 * WebView/WebView.h: Changed @method to @property in a couple of places.
1200 * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
1202 2016-10-26 Brian Burg <bburg@apple.com>
1204 Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
1205 https://bugs.webkit.org/show_bug.cgi?id=164046
1207 Reviewed by Joseph Pecoraro.
1209 * WebCoreSupport/WebInspectorClient.h:
1211 2016-10-21 Alex Christensen <achristensen@webkit.org>
1213 URL::port should return Optional<uint16_t>
1214 https://bugs.webkit.org/show_bug.cgi?id=163806
1216 Reviewed by Darin Adler.
1218 * WebCoreSupport/WebSecurityOrigin.mm:
1219 (-[WebSecurityOrigin port]):
1221 2016-10-24 Dave Hyatt <hyatt@apple.com>
1223 Remove CSSCharsetRule from the CSS OM
1224 https://bugs.webkit.org/show_bug.cgi?id=163891
1226 Reviewed by Darin Adler.
1228 * DOM/DOMCSSCharsetRule.mm:
1229 (-[DOMCSSCharsetRule encoding]):
1231 2016-10-24 Youenn Fablet <youenn@apple.com>
1233 Activate WEB_RTC compilation flags for Mac bots
1234 https://bugs.webkit.org/show_bug.cgi?id=163886
1236 Reviewed by Eric Carlson.
1238 * Configurations/FeatureDefines.xcconfig:
1240 2016-10-23 Chris Dumez <cdumez@apple.com>
1242 addEventListener() / removeEventListener() should use a union for last parameter
1243 https://bugs.webkit.org/show_bug.cgi?id=163863
1245 Reviewed by Darin Adler.
1247 Cast BOOL to bool to help to compiler construct the new variant-type parameter.
1250 (-[DOMNode addEventListener:listener:useCapture:]):
1251 (-[DOMNode addEventListener:::]):
1252 (-[DOMNode removeEventListener:listener:useCapture:]):
1253 (-[DOMNode removeEventListener:::]):
1255 2016-10-21 Wenson Hsieh <wenson_hsieh@apple.com>
1257 Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
1258 https://bugs.webkit.org/show_bug.cgi?id=163460
1259 <rdar://problem/28784142>
1261 Reviewed by Darin Adler.
1263 Handle new EditAction types for inserting/deleting pending/final compositions.
1265 * WebCoreSupport/WebEditorClient.mm:
1266 (undoNameForEditAction):
1268 2016-10-21 Jeremy Jones <jeremyj@apple.com>
1270 Implement basic pointer lock behavior for WebKit and WebKit2.
1271 https://bugs.webkit.org/show_bug.cgi?id=162745
1273 Reviewed by Simon Fraser.
1275 Add basic pointer lock functionality. User permission is not yet implemented.
1277 * WebCoreSupport/WebChromeClient.h:
1278 * WebCoreSupport/WebChromeClient.mm:
1279 (WebChromeClient::requestPointerLock):
1280 (WebChromeClient::requestPointerUnlock):
1282 2016-10-19 Myles C. Maxfield <mmaxfield@apple.com>
1284 [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1285 https://bugs.webkit.org/show_bug.cgi?id=163374
1287 Reviewed by Darin Adler.
1289 * Configurations/FeatureDefines.xcconfig:
1291 2016-10-19 Alex Christensen <achristensen@webkit.org>
1294 https://bugs.webkit.org/show_bug.cgi?id=163675
1296 Reviewed by Brent Fulgham.
1298 * Misc/WebDownload.mm:
1299 (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
1300 * Misc/WebDownloadInternal.h:
1301 * WebCoreSupport/WebFrameLoaderClient.mm:
1302 (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1303 * WebView/WebPreferences.mm:
1304 (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
1305 * WebView/WebView.mm:
1306 (-[WebView scheduleInRunLoop:forMode:]):
1307 (-[WebView unscheduleFromRunLoop:forMode:]):
1309 2016-10-19 Ryan Haddad <ryanhaddad@apple.com>
1311 Unreviewed, rolling out r207557.
1313 This change caused animations/font-variations tests to time
1314 out on pre-Sierra Macs.
1318 "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
1320 https://bugs.webkit.org/show_bug.cgi?id=163374
1321 http://trac.webkit.org/changeset/207557
1323 2016-10-19 Chris Dumez <cdumez@apple.com>
1325 Move HTML Interactive Form Validation behind an experimental flag
1326 https://bugs.webkit.org/show_bug.cgi?id=163673
1328 Reviewed by Daniel Bates.
1330 Re-disable HTML Interactive Form Validation by default on Mac WK1.
1332 * WebView/WebViewData.mm:
1333 (-[WebViewPrivate init]):
1335 2016-10-19 Myles C. Maxfield <mmaxfield@apple.com>
1337 [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1338 https://bugs.webkit.org/show_bug.cgi?id=163374
1340 Reviewed by Darin Adler.
1342 * Configurations/FeatureDefines.xcconfig:
1344 2016-10-19 Simon Fraser <simon.fraser@apple.com>
1346 WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
1347 https://bugs.webkit.org/show_bug.cgi?id=163680
1349 Reviewed by Dean Jackson.
1351 Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
1353 * WebView/WebView.mm:
1354 (-[WebView _preferencesChanged:]):
1356 2016-10-19 Darin Adler <darin@apple.com>
1358 Move XPath from ExceptionCode to Exception
1359 https://bugs.webkit.org/show_bug.cgi?id=163656
1361 Reviewed by Chris Dumez.
1363 * DOM/DOMDocument.mm:
1364 (wrap): Added. Helper function for wrapping a resolver.
1365 (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
1366 (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
1367 * DOM/DOMXPathExpression.mm:
1368 (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
1369 * DOM/DOMXPathResult.mm:
1370 (-[DOMXPathResult numberValue]): Ditto.
1371 (-[DOMXPathResult stringValue]): Ditto.
1372 (-[DOMXPathResult booleanValue]): Ditto.
1373 (-[DOMXPathResult singleNodeValue]): Ditto.
1374 (-[DOMXPathResult snapshotLength]): Ditto.
1375 (-[DOMXPathResult iterateNext]): Ditto.
1376 (-[DOMXPathResult snapshotItem:]): Ditto.
1378 2016-10-18 Sam Weinig <sam@webkit.org>
1380 Replace std::experimental::variant with WTF::Variant (or similar)
1381 https://bugs.webkit.org/show_bug.cgi?id=163626
1383 Reviewed by Chris Dumez.
1385 Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
1386 into the WTF namespace.
1388 * DOM/DOMHTMLSelectElement.mm:
1389 (-[DOMHTMLSelectElement add:before:]):
1391 2016-10-18 Simon Fraser <simon.fraser@apple.com>
1393 Add a MiniBrowser menu item to apply page scale in WK1 and WK2
1394 https://bugs.webkit.org/show_bug.cgi?id=163627
1396 Reviewed by Dean Jackson.
1398 Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
1400 * WebView/WebViewPrivate.h:
1402 2016-10-18 Dean Jackson <dino@apple.com>
1404 Remove CSS_SHAPES feature definition. This should always be on.
1405 https://bugs.webkit.org/show_bug.cgi?id=163628
1406 <rdar://problem/28834613>
1408 Reviewed by Tim Horton.
1410 * Configurations/FeatureDefines.xcconfig:
1412 2016-10-18 Chris Dumez <cdumez@apple.com>
1414 Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
1415 https://bugs.webkit.org/show_bug.cgi?id=163608
1417 Reviewed by Ryosuke Niwa.
1419 Update add() call sites now that it takes std::variant types in.
1421 * DOM/DOMHTMLOptionsCollection.mm:
1422 (-[DOMHTMLOptionsCollection add:index:]):
1423 * DOM/DOMHTMLSelectElement.mm:
1424 (-[DOMHTMLSelectElement add:before:]):
1426 2016-10-18 Anders Carlsson <andersca@apple.com>
1428 Get rid of more WebHistoryItem cruft
1429 https://bugs.webkit.org/show_bug.cgi?id=163623
1431 Reviewed by Tim Horton.
1433 * History/WebHistoryItem.mm:
1434 (-[WebHistoryItem initFromDictionaryRepresentation:]):
1435 * History/WebHistoryItemPrivate.h:
1437 2016-10-18 Wenson Hsieh <wenson_hsieh@apple.com>
1439 Showing and hiding candidates list is very distracting after selecting word
1440 https://bugs.webkit.org/show_bug.cgi?id=163609
1441 <rdar://problem/28747712>
1443 Reviewed by Tim Horton.
1445 Introduce WebView hooks for mousedown and mouseup. See radar for more details.
1447 * WebView/WebHTMLView.mm:
1448 (-[WebHTMLView mouseDown:mouseDown:]):
1449 (-[WebHTMLView mouseUp:mouseUp:]):
1450 * WebView/WebView.mm:
1451 (-[WebView prepareForMouseDown]):
1452 (-[WebView prepareForMouseUp]):
1453 * WebView/WebViewInternal.h:
1455 2016-10-17 Anders Carlsson <andersca@apple.com>
1457 Move some history specific HistoryItem code to WebHistoryItem
1458 https://bugs.webkit.org/show_bug.cgi?id=163567
1460 Reviewed by Tim Horton.
1462 * History/HistoryPropertyList.mm:
1463 (HistoryPropertyListWriter::writeHistoryItem):
1464 * History/WebHistory.mm:
1465 (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
1466 * History/WebHistoryItem.mm:
1467 (-[WebHistoryItem initFromDictionaryRepresentation:]):
1468 * History/WebHistoryItemInternal.h:
1469 * WebCoreSupport/WebFrameLoaderClient.mm:
1471 (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
1473 2016-10-18 Eric Carlson <eric.carlson@apple.com>
1475 [MediaStream] Resolve constraints and enumerate devices in the UI process
1476 https://bugs.webkit.org/show_bug.cgi?id=162147
1477 <rdar://problem/28803569>
1479 Reviewed by Darin Adler.
1481 * WebCoreSupport/WebUserMediaClient.h:
1482 * WebCoreSupport/WebUserMediaClient.mm:
1483 (AddPermissionCheckToMap):
1484 (RemovePermissionCheckFromMap):
1485 (WebUserMediaClient::pageDestroyed):
1486 (WebUserMediaClient::requestUserMediaAccess):
1487 (WebUserMediaClient::enumerateMediaDevices):
1488 (WebUserMediaClient::cancelMediaDevicesEnumerationRequest):
1489 (-[WebUserMediaPolicyListener allow]):
1490 (-[WebUserMediaPolicyListener deny]):
1491 (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
1492 (-[WebUserMediaPolicyCheckerListener cancelMediaDevicesEnumerationRequest]):
1493 (-[WebUserMediaPolicyCheckerListener allow]):
1494 (-[WebUserMediaPolicyCheckerListener deny]):
1495 (WebUserMediaClient::checkUserMediaPermission): Deleted.
1496 (WebUserMediaClient::cancelUserMediaPermissionCheck): Deleted.
1497 (-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]): Deleted.
1498 (-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]): Deleted.
1500 2016-10-17 Antti Koivisto <antti@apple.com>
1502 Rename setNeedsStyleRecalc to invalidateStyle
1503 https://bugs.webkit.org/show_bug.cgi?id=163542
1505 Reviewed by Darin Adler.
1507 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1508 (-[WebHostedNetscapePluginView createPluginLayer]):
1509 * Plugins/WebNetscapePluginView.mm:
1510 (-[WebNetscapePluginView createPlugin]):
1512 2016-10-17 Jeremy Jones <jeremyj@apple.com>
1514 Enable keyboard in fullscreen.
1515 https://bugs.webkit.org/show_bug.cgi?id=163146
1517 Reviewed by Jer Noble.
1519 Allow keyboard in fullscreen.
1521 * WebView/WebView.mm:
1522 (-[WebView _supportsFullScreenForElement:withKeyboard:]):
1524 2016-10-17 Chris Dumez <cdumez@apple.com>
1526 Move form.reportValidity() behind InteractiveFormValidation setting
1527 https://bugs.webkit.org/show_bug.cgi?id=163550
1529 Reviewed by Darin Adler.
1531 Enable InteractiveFormValidation setting by default and link it to
1532 RuntimeEnabledFeatures so we can use it in the IDL.
1534 * WebView/WebView.mm:
1535 (-[WebView _preferencesChanged:]):
1536 * WebView/WebViewData.mm:
1537 (-[WebViewPrivate init]):
1539 2016-10-17 Anders Carlsson <andersca@apple.com>
1543 * History/WebBackForwardList.mm:
1544 (-[WebBackForwardList dictionaryRepresentation]):
1546 2016-10-17 Anders Carlsson <andersca@apple.com>
1548 CTTE some of the BackForwardList member functions
1549 https://bugs.webkit.org/show_bug.cgi?id=163555
1551 Reviewed by Dan Bernstein.
1553 * History/BackForwardList.h:
1554 (BackForwardList::entries):
1555 * History/BackForwardList.mm:
1556 (BackForwardList::removeItem):
1557 (BackForwardList::containsItem):
1558 (BackForwardList::entries): Deleted.
1559 * History/WebBackForwardList.mm:
1560 (-[WebBackForwardList removeItem:]):
1561 (-[WebBackForwardList containsItem:]):
1562 (-[WebBackForwardList description]):
1564 2016-10-17 Anders Carlsson <andersca@apple.com>
1566 Remove WEBCORE_EXPORT from BackForwardList, it lives in WebKit now
1567 https://bugs.webkit.org/show_bug.cgi?id=163551
1569 Reviewed by Tim Horton.
1571 * History/BackForwardList.h:
1573 2016-10-16 Darin Adler <darin@apple.com>
1575 Move CSS classes from ExceptionCode to Exception
1576 https://bugs.webkit.org/show_bug.cgi?id=163494
1578 Reviewed by Sam Weinig.
1580 * DOM/DOMCSSMediaRule.mm:
1581 (-[DOMCSSMediaRule insertRule:index:]): Use raiseOnDOMError
1582 the new way to handle ExceptionOr instead of ExceptionCode.
1583 (-[DOMCSSMediaRule deleteRule:]): Ditto.
1584 * DOM/DOMCSSPrimitiveValue.mm:
1585 (-[DOMCSSPrimitiveValue setFloatValue:floatValue:]): Ditto.
1586 (-[DOMCSSPrimitiveValue getFloatValue:]): Ditto.
1587 (-[DOMCSSPrimitiveValue setStringValue:stringValue:]): Ditto.
1588 (-[DOMCSSPrimitiveValue getStringValue]): Ditto.
1589 (-[DOMCSSPrimitiveValue getCounterValue]): Ditto.
1590 (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
1591 (-[DOMCSSPrimitiveValue getRGBColorValue]): Ditto.
1592 * DOM/DOMCSSRule.mm:
1593 (-[DOMCSSRule setCssText:]): Ditto.
1594 * DOM/DOMCSSStyleDeclaration.mm:
1595 (-[DOMCSSStyleDeclaration setCssText:]): Ditto.
1596 (-[DOMCSSStyleDeclaration removeProperty:]): Ditto.
1597 (-[DOMCSSStyleDeclaration setProperty:value:priority:]): Ditto.
1598 * DOM/DOMCSSStyleSheet.mm:
1599 (-[DOMCSSStyleSheet insertRule:index:]): Ditto.
1600 (-[DOMCSSStyleSheet deleteRule:]): Ditto.
1601 (-[DOMCSSStyleSheet addRule:style:index:]): Ditto.
1602 (-[DOMCSSStyleSheet removeRule:]): Ditto.
1603 * DOM/DOMCSSValue.mm:
1604 (-[DOMCSSValue setCssText:]): Ditto.
1605 * DOM/DOMMediaList.mm:
1606 (-[DOMMediaList setMediaText:]): Ditto.
1607 (-[DOMMediaList deleteMedium:]): Ditto.
1608 (-[DOMMediaList appendMedium:]): Ditto.
1610 * DOM/ExceptionHandlers.h: Added an overload of raiseDOMException
1611 that works with a WebCore::Exception&& and overloads of
1612 raiseOnDOMError that work with WebCore::ExceptionOr&&.
1613 * DOM/ExceptionHandlers.mm:
1614 (raiseDOMException): Implemented the new version.
1616 2016-10-15 Dan Bernstein <mitz@apple.com>
1618 REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
1619 https://bugs.webkit.org/show_bug.cgi?id=163492
1620 <rdar://problem/28654799>
1622 Reviewed by Darin Adler.
1624 Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm
1626 * WebView/WebHTMLView.mm:
1627 (createMenuItem): Set the tag for items that have submenus as well.
1629 2016-10-14 Anders Carlsson <andersca@apple.com>
1631 Clean up BackForwardClient
1632 https://bugs.webkit.org/show_bug.cgi?id=163454
1634 Reviewed by Sam Weinig.
1636 * History/BackForwardList.h:
1637 Remove override keywords.
1639 * History/BackForwardList.mm:
1640 (BackForwardList::clearAllPageCaches): Deleted.
1641 Remove this, it's no longer used.
1643 * WebView/WebView.mm:
1644 (-[WebView _clearBackForwardCache]): Deleted.
1645 * WebView/WebViewPrivate.h:
1646 Remove SPI that's no longer used by anyone.
1648 2016-10-13 Anders Carlsson <andersca@apple.com>
1650 Move BackForwardList from WebCore to WebKitLegacy
1651 https://bugs.webkit.org/show_bug.cgi?id=163418
1653 Reviewed by Tim Horton.
1655 * History/BackForwardList.h: Renamed from Source/WebCore/history/BackForwardList.h.
1656 (BackForwardList::create):
1657 (BackForwardList::webView):
1658 * History/BackForwardList.mm: Renamed from Source/WebCore/history/BackForwardList.cpp.
1659 (BackForwardList::BackForwardList):
1660 (BackForwardList::close):
1661 (BackForwardList::containsItem):
1662 * History/WebBackForwardList.mm:
1664 (-[WebBackForwardList initWithBackForwardList:]):
1665 (-[WebBackForwardList setPageCacheSize:]):
1666 (-[WebBackForwardList pageCacheSize]):
1667 * History/WebBackForwardListInternal.h:
1668 * WebCoreSupport/WebFrameLoaderClient.mm:
1669 * WebView/WebFrameView.mm:
1670 * WebView/WebView.mm:
1671 (-[WebView _commonInitializationWithFrameName:groupName:]):
1672 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1674 2016-10-13 Anders Carlsson <andersca@apple.com>
1676 Get rid of the HistoryItemVector typedef
1677 https://bugs.webkit.org/show_bug.cgi?id=163398
1679 Reviewed by Beth Dakin.
1681 Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
1683 * History/WebBackForwardList.mm:
1684 (-[WebBackForwardList dictionaryRepresentation]):
1686 (-[WebBackForwardList backListWithLimit:]):
1687 (-[WebBackForwardList forwardListWithLimit:]):
1688 (-[WebBackForwardList description]):
1689 * History/WebHistoryItem.mm:
1690 (-[WebHistoryItem description]):
1692 2016-10-12 Chris Dumez <cdumez@apple.com>
1694 [Web IDL] Drop support for legacy [ConstructorConditional=*]
1695 https://bugs.webkit.org/show_bug.cgi?id=163368
1697 Reviewed by Ryosuke Niwa.
1699 Drop ENABLE_DOM4_EVENTS_CONSTRUCTOR compiler flag.
1701 * Configurations/FeatureDefines.xcconfig:
1703 2016-10-12 Beth Dakin <bdakin@apple.com>
1705 Adobe Contribute CS 6.5 Trial crashes on launch
1706 https://bugs.webkit.org/show_bug.cgi?id=163365
1708 <rdar://problem/28732731>
1710 Reviewed by Tim Horton.
1712 * Carbon/CarbonWindowFrame.m:
1713 (-[CarbonWindowFrame contentFill]):
1715 2016-10-11 Daniel Bates <dabates@apple.com>
1717 Attempt to fix the Apple Internal Mac build following r207159
1718 (https://bugs.webkit.org/show_bug.cgi?id=163244)
1720 * WebView/WebView.mm:
1721 (shouldRequireUserGestureToLoadVideo):
1723 2016-10-11 Daniel Bates <dabates@apple.com>
1725 REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
1726 https://bugs.webkit.org/show_bug.cgi?id=163259
1727 <rdar://problem/28680515>
1729 Reviewed by Jer Noble.
1731 In WebKit1 on iOS we want to require user action to load and play videos by default and
1732 allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
1733 Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
1734 can load and play without being initiated by a user action.
1736 * WebView/WebPreferences.mm:
1737 (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
1738 WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
1739 preference takes precedence over the values of its replacement preferences
1740 WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
1742 2016-10-11 Daniel Bates <dabates@apple.com>
1744 [iOS] REGRESSION (r197953): User gesture required to load video in iOS 9-built apps
1745 https://bugs.webkit.org/show_bug.cgi?id=163244
1746 <rdar://problem/27250015>
1748 Reviewed by Jer Noble.
1750 Enable or disable the Setting::requiresUserGestureToLoadVideo() in legacy WebKit depending
1751 on the version of iOS SDK that the app was linked against. We require a user gesture to
1752 begin loading a video as of iOS 10.
1754 * WebView/WebView.mm:
1755 (shouldRequireUserGestureToLoadVideo):
1756 (-[WebView _preferencesChanged:]): Modified to pass the WebKit requiresUserGestureToLoadVideo
1757 preference to WebCore.
1759 2016-10-11 Alex Christensen <achristensen@webkit.org>
1761 Remove dead networking code
1762 https://bugs.webkit.org/show_bug.cgi?id=163263
1764 Reviewed by Daniel Bates.
1766 * Misc/WebDownload.mm:
1767 (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1768 * Misc/WebDownloadInternal.h:
1769 * WebCoreSupport/WebFrameLoaderClient.mm:
1770 (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1771 * WebView/WebPreferences.mm:
1772 (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
1773 * WebView/WebView.mm:
1774 (-[WebView scheduleInRunLoop:forMode:]):
1775 (-[WebView unscheduleFromRunLoop:forMode:]):
1777 2016-10-10 Zan Dobersek <zdobersek@igalia.com>
1779 Add ENABLE_ENCRYPTED_MEDIA configuration option
1780 https://bugs.webkit.org/show_bug.cgi?id=163219
1782 Reviewed by Darin Adler.
1784 * Configurations/FeatureDefines.xcconfig:
1785 Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
1786 to enable or disable the new EME implementation at build-time.
1788 2016-10-10 Darin Adler <darin@apple.com>
1790 Move NotificationCenter from legacy to new DOM exceptions
1791 https://bugs.webkit.org/show_bug.cgi?id=163217
1793 Reviewed by Chris Dumez.
1795 * WebView/WebView.mm:
1796 (-[WebView _notificationIDForTesting:]): Pass reference to page rather than pointer.
1798 2016-10-09 Wenson Hsieh <wenson_hsieh@apple.com>
1800 Support InputEvent.inputType for the new InputEvent spec
1801 https://bugs.webkit.org/show_bug.cgi?id=163025
1802 <rdar://problem/28658092>
1804 Reviewed by Darin Adler.
1806 Accounts for some changes to the EditAction enum in nameForEditAction. See WebCore ChangeLog
1807 entry for more details.
1809 * WebCoreSupport/WebEditorClient.mm:
1810 (undoNameForEditAction):
1812 2016-10-06 Darin Adler <darin@apple.com>
1814 Next step on moving to modern way to return DOM exceptions
1815 https://bugs.webkit.org/show_bug.cgi?id=163016
1817 Reviewed by Ryosuke Niwa.
1819 * DOM/DOMDOMImplementation.mm:
1820 (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated for
1821 name change from takeReturnValue to releaseReturnValue.
1822 (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
1824 2016-10-07 Simon Fraser <simon.fraser@apple.com>
1826 [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
1827 https://bugs.webkit.org/show_bug.cgi?id=163154
1828 rdar://problem/28674216
1830 Reviewed by Tim Horton.
1832 r55159 added code to counteract AppKit's adjustment of dirty regions during scrolling,
1833 by offsetting the dirty rect in -setNeedsDisplayInRect: if the call happens during
1834 the NSViewBoundsDidChangeNotification handling.
1836 However, AppKit only does dirty region adjustment in the code path that blits ("copy
1837 on scroll"), so r55159 produces incorrect behavior in, for example, layer-backed views.
1839 Fix by overriding -[NSClipView _canCopyOnScrollForDeltaX:deltaY:] to know if a single
1840 scroll is going to blit, and only do adjustments in -setNeedsDisplayInRect: if it is.
1842 * WebView/WebClipView.h:
1843 * WebView/WebClipView.mm:
1844 (-[WebClipView _immediateScrollToPoint:]):
1845 (-[WebClipView _canCopyOnScrollForDeltaX:deltaY:]):
1846 (-[WebClipView currentScrollIsBlit]):
1847 * WebView/WebHTMLView.mm:
1848 (-[WebHTMLView setNeedsDisplayInRect:]):
1849 (-[WebHTMLView drawRect:]):
1851 2016-10-06 Youenn Fablet <youenn@apple.com>
1853 CachedResource client handling methods should take reference
1854 https://bugs.webkit.org/show_bug.cgi?id=163014
1856 Reviewed by Alex Christensen.
1858 * WebView/WebHTMLView.mm:
1859 (promisedDataClient):
1861 2016-10-05 Myles C. Maxfield <mmaxfield@apple.com>
1863 Put variation fonts work behind a compile-time flag
1864 https://bugs.webkit.org/show_bug.cgi?id=162949
1866 Reviewed by Simon Fraser.
1868 * Configurations/FeatureDefines.xcconfig:
1870 2016-10-05 Zan Dobersek <zdobersek@igalia.com>
1872 Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
1873 https://bugs.webkit.org/show_bug.cgi?id=162903
1875 Reviewed by Alex Christensen.
1877 Rename build guards for the remaining implementation of the legacy EME API
1878 to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
1879 of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
1881 * Configurations/FeatureDefines.xcconfig:
1882 * WebView/WebPreferences.mm:
1883 (+[WebPreferences initialize]):
1884 * WebView/WebView.mm:
1885 (-[WebView _preferencesChanged:]):
1887 2016-10-04 Said Abou-Hallawa <sabouhallawa@apple.com>
1889 The dragged image should be the current frame only of the animated image
1890 https://bugs.webkit.org/show_bug.cgi?id=162109
1892 Reviewed by Tim Horton.
1895 (-[DOMElement image]): Call the Image function with its new name.
1896 (-[DOMElement _imageTIFFRepresentation]): Ditto.
1897 * Misc/WebElementDictionary.mm:
1898 (-[WebElementDictionary _image]): Call the Image function with its new name.
1899 * Misc/WebIconDatabase.mm:
1900 (-[WebIconDatabase defaultIconWithSize:]): Call snapshotNSImage() to create the icon image.
1901 (webGetNSImage): Call the Image function with its new name.
1902 * WebCoreSupport/WebContextMenuClient.mm:
1903 (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call snapshotNSImage() instead of nsImage()..
1904 (WebContextMenuClient::contextMenuForEvent): Ditto.
1905 * WebView/WebHTMLView.mm:
1906 (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
1908 2016-10-02 Ryan Haddad <ryanhaddad@apple.com>
1910 Unreviewed, rolling out r206683.
1912 This change caused API test WebKit2.FindMatches to fail on
1917 "The dragged image should be the current frame only of the
1919 https://bugs.webkit.org/show_bug.cgi?id=162109
1920 http://trac.webkit.org/changeset/206683
1922 2016-09-30 Said Abou-Hallawa <sabouhallawa@apple.com>
1924 The dragged image should be the current frame only of the animated image
1925 https://bugs.webkit.org/show_bug.cgi?id=162109
1927 Reviewed by Tim Horton.
1930 (-[DOMElement image]): Call the Image function with its new name.
1931 (-[DOMElement _imageTIFFRepresentation]): Ditto.
1932 * Misc/WebElementDictionary.mm:
1933 (-[WebElementDictionary _image]): Call the Image function with its new name.
1934 * Misc/WebIconDatabase.mm:
1935 (-[WebIconDatabase defaultIconWithSize:]): Call currentFrameNSImage() to create the icon image.
1936 (webGetNSImage): Call the Image function with its new name.
1937 * WebCoreSupport/WebContextMenuClient.mm:
1938 (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call currentFrameNSImage() instead of nsImage()..
1939 (WebContextMenuClient::contextMenuForEvent): Ditto.
1940 * WebView/WebHTMLView.mm:
1941 (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
1943 2016-09-27 Jer Noble <jer.noble@apple.com>
1945 Remove deprecated ENCRYPTED_MEDIA implementation.
1946 https://bugs.webkit.org/show_bug.cgi?id=161010
1948 Remove ENABLE_ENCRYPTED_MEDIA.
1950 Reviewed by Eric Carlson.
1952 * Configurations/FeatureDefines.xcconfig:
1954 2016-09-26 Daniel Bates <dabates@apple.com>
1956 Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
1957 https://bugs.webkit.org/show_bug.cgi?id=162365
1959 Reviewed by Simon Fraser.
1961 * Configurations/FeatureDefines.xcconfig:
1962 * WebView/WebFrame.mm:
1963 * WebView/WebPreferences.mm:
1964 (+[WebPreferences initialize]):
1965 * WebView/WebView.mm:
1966 (-[WebView _preferencesChanged:]):
1968 2016-09-25 Antti Koivisto <antti@apple.com>
1970 AuthorStyleSheets shouldn't trigger synchronous style resolutions
1971 https://bugs.webkit.org/show_bug.cgi?id=162532
1973 Reviewed by Darin Adler.
1975 * WebView/WebHTMLView.mm:
1976 (-[WebHTMLView reapplyStyles]):
1977 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1979 2016-09-24 Antti Koivisto <antti@apple.com>
1981 Move stylesheet change logic from Document to AuthorStyleSheets
1982 https://bugs.webkit.org/show_bug.cgi?id=162488
1984 Reviewed by Andreas Kling.
1986 * WebView/WebHTMLView.mm:
1987 (-[WebHTMLView reapplyStyles]):
1988 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1990 2016-09-23 Caitlin Potter <caitp@igalia.com>
1992 [JSC] Implement parsing of Async Functions
1993 https://bugs.webkit.org/show_bug.cgi?id=161409
1995 Reviewed by Yusuke Suzuki.
1997 * Configurations/FeatureDefines.xcconfig:
1999 2016-09-23 Commit Queue <commit-queue@webkit.org>
2001 Unreviewed, rolling out r206311.
2002 https://bugs.webkit.org/show_bug.cgi?id=162495
2004 Broke internal iOS build (Requested by anttik on #webkit).
2008 "Move stylesheet change logic from Document to
2010 https://bugs.webkit.org/show_bug.cgi?id=162488
2011 http://trac.webkit.org/changeset/206311
2013 2016-09-23 Antoine Quint <graouts@apple.com>
2015 Add a new runtime flag for work on modern media controls (off by default)
2016 https://bugs.webkit.org/show_bug.cgi?id=162420
2017 <rdar://problem/27989489>
2019 Reviewed by Eric Carlson.
2021 * WebView/WebPreferenceKeysPrivate.h:
2022 * WebView/WebPreferences.mm:
2023 (-[WebPreferences modernMediaControlsEnabled]):
2024 (-[WebPreferences setModernMediaControlsEnabled:]):
2025 * WebView/WebPreferencesPrivate.h:
2026 * WebView/WebView.mm:
2027 (-[WebView _preferencesChanged:]):
2029 2016-09-21 Anders Carlsson <andersca@apple.com>
2031 Support openPaymentSetup API on ApplePaySession object
2032 https://bugs.webkit.org/show_bug.cgi?id=162357
2033 rdar://problem/26776939
2035 Reviewed by Tim Horton.
2037 Add openPaymentSetup stub.
2039 * WebCoreSupport/WebPaymentCoordinatorClient.h:
2040 * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2041 (WebPaymentCoordinatorClient::openPaymentSetup):
2043 2016-09-19 Daniel Bates <dabates@apple.com>
2045 Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
2046 https://bugs.webkit.org/show_bug.cgi?id=162167
2048 Reviewed by Simon Fraser.
2050 * Configurations/FeatureDefines.xcconfig:
2052 2016-09-19 Joseph Pecoraro <pecoraro@apple.com>
2054 Web Inspector: Bring the inspected page's window forward when activating element search
2055 https://bugs.webkit.org/show_bug.cgi?id=162114
2056 <rdar://problem/28349357>
2058 Reviewed by Brian Burg.
2060 * WebCoreSupport/WebInspectorClient.mm:
2061 (WebInspectorClient::didSetSearchingForNode):
2062 When element search is activated bring the window
2063 containing the inspected page to the foreground.
2065 2016-09-15 Brady Eidson <beidson@apple.com>
2067 WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
2068 <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
2070 Reviewed by Brent Fulgham.
2072 * WebCoreSupport/WebFrameLoaderClient.h:
2073 * WebCoreSupport/WebFrameLoaderClient.mm:
2074 (WebFrameLoaderClient::dispatchDidCommitLoad):
2076 2016-09-15 Anders Carlsson <andersca@apple.com>
2078 This was supposed to be committed with the previous patch!
2080 * Plugins/WebBasePluginPackage.mm:
2081 (pathByResolvingSymlinksAndAliases): Deleted.
2083 2016-09-15 Anders Carlsson <andersca@apple.com>
2085 Replace use of Carbon file system APIs in plug-in loading
2086 https://bugs.webkit.org/show_bug.cgi?id=162040
2087 rdar://problem/6017896
2089 Reviewed by Sam Weinig.
2091 * Plugins/WebBasePluginPackage.mm:
2092 (-[WebBasePluginPackage initWithPath:]):
2093 Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
2094 to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).
2096 2016-09-15 Beth Dakin <bdakin@apple.com>
2098 Need hasMarkedText on Mac
2099 https://bugs.webkit.org/show_bug.cgi?id=162026
2101 rdar://problem/28272353
2103 Reviewed by Anders Carlsson.
2105 * WebView/WebHTMLViewInternal.h:
2107 2016-09-12 Dean Jackson <dino@apple.com>
2109 Replace RGBA32 with Color in member variables
2110 https://bugs.webkit.org/show_bug.cgi?id=161856
2111 <rdar://problem/28254324>
2113 Reviewed by Simon Fraser.
2115 In preparation for the Color class to become more than
2116 just a 4-byte RGBA value, I went through a few places
2117 that were using the RGBA32 type directly, and replaced
2118 them with Color. This will make some objects a little
2119 bigger e.g. BorderValue and its friends.
2121 I mostly looked at the places that were using RGBA32 as
2122 a member variable. There is still a lot of RGBA32 use
2123 around the project, in particular the CSS parser.
2125 There should be no behaviour change.
2127 * Misc/WebKitNSStringExtras.mm:
2128 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Explicitly
2129 call a Color constructor, rather than passing an RGBA32.
2131 2016-09-13 Chris Dumez <cdumez@apple.com>
2133 Drop support for <isindex>
2134 https://bugs.webkit.org/show_bug.cgi?id=7139
2136 Reviewed by Ryosuke Niwa.
2138 Drop references to isindex.
2140 * WebCoreSupport/WebEditorClient.mm:
2141 (attributesForAttributedStringConversion):
2142 * WebView/WebHTMLView.mm:
2143 (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
2145 2016-09-12 Chris Dumez <cdumez@apple.com>
2147 Switch remaining users of Document::inPageCache() to pageCacheState()
2148 https://bugs.webkit.org/show_bug.cgi?id=161865
2150 Reviewed by Darin Adler.
2152 Switch remaining users of Document::inPageCache() to pageCacheState() as
2153 the former one is confusing (given that it returns true while the
2154 pagehide event is being fired).
2156 * WebView/WebHTMLView.mm:
2157 (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]):
2158 (-[WebHTMLView setNeedsLayout:]):
2159 (-[WebHTMLView setNeedsToApplyStyles:]):
2161 2016-09-09 Tim Horton <timothy_horton@apple.com>
2163 Text replacement candidates don't always overwrite the entire original string
2164 https://bugs.webkit.org/show_bug.cgi?id=161779
2165 <rdar://problem/28033492>
2167 Reviewed by Simon Fraser.
2169 * WebCoreSupport/WebEditorClient.mm:
2170 (WebEditorClient::requestCandidatesForSelection):
2171 Make use of the shared implementation of contextRangeForCandidateRequest.
2173 2016-09-08 Said Abou-Hallawa <sabouhallawa@apple.com>
2175 Move the BitmapImage platform dependent code to a new file named NativeImage[CG|Cairo].cpp
2176 https://bugs.webkit.org/show_bug.cgi?id=158684
2178 Reviewed by Simon Fraser.
2181 (-[DOMNode getPreviewSnapshotImage:andRects:]):
2183 (+[WebCache imageForURL:]):
2184 Replace BitmapImage::getCGImageRef() with BitmapImage::nativeImage().
2186 2016-09-07 Joseph Pecoraro <pecoraro@apple.com>
2188 [Mac] Address some clang static analyzer warnings in WebKit
2189 https://bugs.webkit.org/show_bug.cgi?id=161597
2191 Reviewed by Darin Adler.
2193 * Misc/WebIconDatabase.h:
2194 Remove unused instance variable. It has not been used since r16005 (2006)!
2196 * Misc/WebSharingServicePickerController.mm:
2197 (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2200 * WebCoreSupport/WebSelectionServiceController.mm:
2201 (WebSelectionServiceController::hasRelevantSelectionServices):
2202 Address attachment and cell leak.
2204 * WebView/WebFullScreenController.h:
2205 * WebView/WebImmediateActionController.h:
2206 Remove unused instance variables.
2208 2016-09-07 Simon Fraser <simon.fraser@apple.com>
2210 Enable the <meter> element on iOS
2211 https://bugs.webkit.org/show_bug.cgi?id=161714
2212 rdar://problem/8978410
2214 Reviewed by Tim Horton.
2216 Define ENABLE_METER_ELEMENT unconditionally now.
2218 * Configurations/FeatureDefines.xcconfig:
2220 2016-09-07 Mark Lam <mark.lam@apple.com>
2222 Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
2223 https://bugs.webkit.org/show_bug.cgi?id=161498
2225 Reviewed by Geoffrey Garen.
2227 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2228 (WebKit::NetscapePluginInstanceProxy::evaluate):
2229 (WebKit::NetscapePluginInstanceProxy::invoke):
2230 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2231 (WebKit::NetscapePluginInstanceProxy::construct):
2232 (WebKit::NetscapePluginInstanceProxy::getProperty):
2233 (WebKit::NetscapePluginInstanceProxy::setProperty):
2234 (WebKit::NetscapePluginInstanceProxy::removeProperty):
2235 (WebKit::NetscapePluginInstanceProxy::hasProperty):
2236 (WebKit::NetscapePluginInstanceProxy::hasMethod):
2237 (WebKit::NetscapePluginInstanceProxy::enumerate):
2238 * WebView/WebView.mm:
2239 (aeDescFromJSValue):
2241 2016-09-07 Youenn Fablet <youenn@apple.com>
2243 [Streams API] Separate compile flag for ReadableStream and WritableStream
2244 https://bugs.webkit.org/show_bug.cgi?id=161044
2246 Reviewed by Alex Christensen.
2248 Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
2250 * Configurations/FeatureDefines.xcconfig:
2252 2016-09-06 Chris Dumez <cdumez@apple.com>
2254 Add support for input.minLength / textArea.minLength
2255 https://bugs.webkit.org/show_bug.cgi?id=161644
2257 Reviewed by Darin Adler.
2259 Update ObjC bindings to reflect method renaming.
2261 * DOM/DOMHTMLInputElement.mm:
2262 (-[DOMHTMLInputElement maxLength]):
2263 (-[DOMHTMLInputElement setMaxLength:]):
2264 * DOM/DOMHTMLTextAreaElement.mm:
2265 (-[DOMHTMLTextAreaElement maxLength]):
2266 (-[DOMHTMLTextAreaElement setMaxLength:]):
2268 2016-09-06 Dan Bernstein <mitz@apple.com>
2270 <rdar://problem/8064563> Ugly NSLog in DOMInternal.mm
2272 Rubber-stamped by Anders Carlsson.
2274 * DOM/DOMInternal.mm:
2275 (-[WebScriptObject _initializeScriptDOMNodeImp]): Removed useless call to NSLog.
2277 2016-09-06 Ryan Haddad <ryanhaddad@apple.com>
2279 Unreviewed, rolling out r205407.
2281 Not the correct way to implement this functionality
2285 "Consult with the FrameLoaderClient about whether or not
2286 content extensions should be enabled when loading this URL."
2287 https://bugs.webkit.org/show_bug.cgi?id=161441
2288 http://trac.webkit.org/changeset/205407
2290 2016-09-05 Darin Adler <darin@apple.com>
2292 More bindings improvements, particularly things not needed for JavaScript bindings
2293 https://bugs.webkit.org/show_bug.cgi?id=161572
2295 Reviewed by Sam Weinig.
2297 * DOM/DOMDOMImplementation.mm:
2298 (-[DOMImplementation hasFeature:version:]): Call SVGTests::hasFeatureForLegacyBindings
2299 instead of DOMImplementation::hasFeature. Also removed JSMainThreadNullState
2300 since this does not do anything that can invoke JavaScript.
2302 * DOM/DOMDocument.mm:
2303 (-[DOMDocument defaultCharset]): Call defaultCharsetForLegacyBindings. Also removed
2304 JSMainThreadNullState.
2306 * DOM/DOMDocumentType.mm:
2307 (-[DOMDocumentType entities]): Changed to simply return nil; same behavior as before,
2308 but with no dependency on WebCore. Also removed JSMainThreadNullState.
2309 (-[DOMDocumentType notations]): Ditto.
2310 (-[DOMDocumentType internalSubset]): Ditto, except empty string rather than nil.
2313 (-[DOMNode isSupported:version:]): Call SVGTests::hasFeatureForLegacyBindings
2314 instead of Node::isSupportedForBindings. Also removed JSMainThreadNullState.
2316 2016-09-04 Joseph Pecoraro <pecoraro@apple.com>
2318 Remove unnecessary RetainPtr.
2320 Review comments on earlier change.
2322 * WebView/WebImmediateActionController.mm:
2323 (-[WebImmediateActionController _defaultAnimationController]):
2325 2016-09-03 Darin Adler <darin@apple.com>
2327 Streamline DOMImplementation, and move it to our new DOM exception system
2328 https://bugs.webkit.org/show_bug.cgi?id=161295
2330 Reviewed by Ryosuke Niwa.
2332 * DOM/DOMDOMImplementation.mm:
2333 (unwrap): Added. Use this instead of the IMPL macro.
2334 (-[DOMImplementation dealloc]): Updated to use unwrap.
2335 (-[DOMImplementation hasFeature:version:]): Ditto.
2336 (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated to work with
2338 (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2339 (-[DOMImplementation createCSSStyleSheet:media:]): Removed exception logic since
2340 this function can no longer raise an exception.
2341 (-[DOMImplementation createHTMLDocument:]): Updated to use unwrap.
2342 (-[DOMImplementation hasFeature::]): Changed to call the non-deprecated version
2343 rather than duplicating its implementation. Also moved into the category as defined
2345 (-[DOMImplementation createDocumentType:::]): Ditto.
2346 (-[DOMImplementation createDocument:::]): Ditto.
2347 (-[DOMImplementation createCSSStyleSheet::]): Ditto.
2349 * DOM/DOMDocument.mm: Removed unneeded include of DOMImplementation.h.
2350 (-[DOMDocument setXmlStandalone:]): Updated since setXMLStandalone no longer can
2353 * WebView/WebFrame.mm:
2354 (-[WebFrame _canProvideDocumentSource]): Updated to use isTextMIMEType in its new
2355 location in MIMETypeRegistry instead of in DOMImplementation.
2357 2016-09-03 Brian Weinstein <bweinstein@apple.com>
2359 Implement a stub version of FrameLoaderClient::shouldUseContentExtensionsForURL.
2360 https://bugs.webkit.org/show_bug.cgi?id=16144
2362 Reviewed by Darin Adler.
2364 * WebCoreSupport/WebFrameLoaderClient.h:
2366 2016-09-02 Beth Dakin <bdakin@apple.com>
2368 Need to updateEditorState if an element change edit-ability without changing
2370 https://bugs.webkit.org/show_bug.cgi?id=161546
2372 rdar://problem/27806012
2374 Reviewed by Ryosuke Niwa.
2376 Every time WebEditorClient::respondToChangedSelection is called, we now save
2377 whether the last state was contentEditable. That way in
2378 updateEditorStateAfterLayoutIfNeeded() we can assess whether or not edit-ability
2381 * WebCoreSupport/WebEditorClient.h:
2382 * WebCoreSupport/WebEditorClient.mm:
2383 (WebEditorClient::respondToChangedSelection):
2384 (WebEditorClient:: updateEditorStateAfterLayoutIfEditabilityChanged):
2386 2016-09-02 Joseph Pecoraro <pecoraro@apple.com>
2388 [Mac] RetainPtr misuse, AnimationController leaks
2389 https://bugs.webkit.org/show_bug.cgi?id=161552
2391 Reviewed by Tim Horton.
2393 * WebView/WebImmediateActionController.mm:
2394 (-[WebImmediateActionController _defaultAnimationController]):
2396 2016-07-08 Jer Noble <jer.noble@apple.com>
2398 Refactor WebPlaybackSessionModelMediaElement to be client based.
2399 https://bugs.webkit.org/show_bug.cgi?id=159580
2401 Reviewed by Eric Carlson.
2403 No longer necessary to tell the models and interfaces about each other.
2405 * WebView/WebView.mm:
2406 (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
2407 (-[WebView _clearPlaybackControlsManager]):
2409 2016-09-01 Dan Bernstein <mitz@apple.com>
2413 * Configurations/FeatureDefines.xcconfig:
2415 2016-09-01 Myles C. Maxfield <mmaxfield@apple.com>
2417 Clean up TextRun-related code
2418 https://bugs.webkit.org/show_bug.cgi?id=161473
2420 Reviewed by Simon Fraser.
2422 Remove unused #includes.
2424 * WebCoreSupport/WebDragClient.mm:
2425 * WebView/WebView.mm:
2427 2016-08-31 Keith Rollin <krollin@apple.com>
2429 WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
2430 https://bugs.webkit.org/show_bug.cgi?id=160969
2431 <rdar://problem/26068734>
2433 Reviewed by Simon Fraser.
2435 Enable subsystem- and channel-related data and functions when using
2436 RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
2437 and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
2439 * Misc/WebKitLogging.h:
2440 * Misc/WebKitLogging.m:
2441 * WebView/WebView.mm:
2442 (-[WebView _commonInitializationWithFrameName:groupName:]):
2444 2016-08-31 Brady Eidson <beidson@apple.com>
2446 WK2 Gamepad provider on iOS.
2447 https://bugs.webkit.org/show_bug.cgi?id=161412
2449 Reviewed by Tim Horton.
2451 * Configurations/FeatureDefines.xcconfig:
2453 * WebView/WebView.mm:
2454 (WebKitInitializeGamepadProviderIfNecessary):
2456 2016-08-30 Mark Lam <mark.lam@apple.com>
2458 Introduce the ThrowScope and force every throw site to instantiate a ThrowScope.
2459 https://bugs.webkit.org/show_bug.cgi?id=161171
2461 Reviewed by Filip Pizlo and Geoffrey Garen.
2463 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2464 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
2465 * Plugins/Hosted/ProxyInstance.mm:
2466 (WebKit::ProxyInstance::invokeMethod):
2468 2016-08-28 Andreas Kling <akling@apple.com>
2470 document.title setter can't throw.
2471 <https://webkit.org/b/161302>
2473 Reviewed by Antti Koivisto.
2475 * DOM/DOMDocument.mm:
2476 (-[DOMDocument setTitle:]):
2478 2016-08-28 Andreas Kling <akling@apple.com>
2480 Clean up some .text attribute setters that don't throw.
2481 <https://webkit.org/b/161292>
2483 Reviewed by Darin Adler.
2485 * DOM/DOMHTMLTitleElement.mm:
2486 (-[DOMHTMLTitleElement setText:]):
2488 2016-08-26 Sam Weinig <sam@webkit.org>
2490 Remove support for ENABLE_LEGACY_WEB_AUDIO
2491 https://bugs.webkit.org/show_bug.cgi?id=161262
2493 Reviewed by Anders Carlsson.
2495 * Configurations/FeatureDefines.xcconfig:
2496 Remove ENABLE_LEGACY_WEB_AUDIO
2498 2016-08-25 Anders Carlsson <andersca@apple.com>
2500 Re-export DOMException NSStrings after r204717
2501 https://bugs.webkit.org/show_bug.cgi?id=161200
2502 <rdar://problem/27959937>
2504 Reviewed by Alex Christensen.
2506 * DOM/ExceptionHandlers.mm:
2507 (raiseDOMException):
2510 2016-08-22 Darin Adler <darin@apple.com>
2512 Move Objective-C DOM bindings from WebCore to legacy WebKit
2513 https://bugs.webkit.org/show_bug.cgi?id=160654
2515 Reviewed by Alex Christensen.
2517 * DOM: Added lots of files to the directory.
2518 The files are just as they were in bindings/objc except that the paths of includes
2519 have been updated as needed, and the code no longer is defined inside the WebCore
2520 namespace, requring changes to various functions and their call sites. Also removed
2521 all the WEBCORE_EXPORT since we export differently here in legacy WebKit.
2523 * DOM/DOMInternal.h: Moved. Replaced createDOMWrapper with initializeDOMWrapperHooks.
2524 * DOM/DOMUtility.mm: Moved.
2525 (createDOMWrapper): Simplified to use toWrapped and not do unneeded namespace tricks.
2526 (disconnectWindowWrapper): Added.
2527 (initializeDOMWrapperHooks): Added.
2529 * MigrateHeaders.make: Removed all the internal headers since they are now just
2530 normal project headers. Added the "DOM" directory to the VPATH. Some of the headers
2531 from WebCore are still being migrated, so we can't remove WebCorePrivateHeaders yet.
2533 * WebCoreSupport/WebEditorClient.h: Updated to return RefPtr<DocumentFragment>.
2535 * WebCoreSupport/WebEditorClient.mm:
2536 (WebEditorClient::documentFragmentFromDelegate): Use RefPtr.
2538 * WebKit.exp: Added exports for all the classes that used to use WEBCORE_EXPORT to
2539 be exported from WebCore.
2541 * WebView/WebFrame.mm:
2542 (-[WebFrame innerLineHeight:]): Moved code from WebCore::Frame::innerLineHeight here.
2543 No longer depend on whether this node happens to be in this frame. Also removed
2544 unneeded null check since a node's document can't be null.
2546 * WebView/WebHTMLView.mm: Removed uneeded include of ExceptionHandlers.h, which
2547 is now here in WebKitLegacy instead of WebCore. But no need to include it at all.
2549 * WebView/WebView.mm:
2550 (-[WebView _commonInitializationWithFrameName:groupName:]): Call
2551 initializeDOMWrapperHooks so WebScriptObject can create DOM binding wrappers when
2552 making a script object for a DOM object, rather than just a generic script object.
2553 (+[WebView enableWebThread]): Added a call to WebCoreObjCDeallocOnWebThread here for
2554 DOMObject along with the other classes. This was done in WebCore before, but DOMObject is now
2555 defined here in legacy WebKit.
2556 (-[WebView styleAtSelectionStart]): Moved code from WebCore::Frame::styleAtSelectionStart here.
2557 Replaced incorrect code that called "new PropertySetCSSStyleDeclaration" with a misleading comment
2558 about reference counting; that code was leaking all the style declarations. Instead use
2559 MutableStyleProperties::ensureCSSStyleDeclaration, which is designed for this purpose.
2561 2016-08-22 Youenn Fablet <youenn@apple.com>
2563 [Fetch API] Activate fetch api runtime flag by default
2564 https://bugs.webkit.org/show_bug.cgi?id=160452
2566 Reviewed by Alex Christensen.
2568 * WebView/WebPreferences.mm:
2569 (+[WebPreferences initialize]):
2571 2016-08-21 Alex Christensen <achristensen@webkit.org>
2573 Use Document& instead of Document* when getting cookies
2574 https://bugs.webkit.org/show_bug.cgi?id=161011
2576 Reviewed by Darin Adler.
2578 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2579 (WebKit::NetscapePluginInstanceProxy::getCookies):
2580 (WebKit::NetscapePluginInstanceProxy::setCookies):
2581 * Plugins/WebNetscapePluginView.mm:
2582 (-[WebNetscapePluginView getVariable:forURL:value:length:]):
2583 (-[WebNetscapePluginView setVariable:forURL:value:length:]):
2585 2016-08-16 Simon Fraser <simon.fraser@apple.com>
2587 Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
2588 https://bugs.webkit.org/show_bug.cgi?id=160923
2590 Reviewed by Tim Horton.
2592 * WebCoreSupport/WebFrameLoaderClient.h:
2593 * WebCoreSupport/WebFrameLoaderClient.mm:
2594 (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2595 (WebFrameLoaderClient::dispatchDidLayout): Deleted.
2597 2016-08-18 Daniel Bates <dabates@apple.com>
2599 Ld warns of non-existent PrivateFrameworks directory when building WebKit with the public iOS 9.3 SDK
2600 https://bugs.webkit.org/show_bug.cgi?id=160979
2602 Rubber-stamped by Simon Fraser.
2604 Only add the SDK PrivateFrameworks directory to the FRAMEWORK_SEARCH_PATH when building for
2605 iOS Simulator, building with an iOS SDK that does not support text-based stubs, or building
2606 an Apple-internal build.
2608 * Configurations/WebKitLegacy.xcconfig:
2610 2016-08-18 Anders Carlsson <andersca@apple.com>
2612 Move an NPAPI-only function from WebCore to WebKit
2613 https://bugs.webkit.org/show_bug.cgi?id=160967
2615 Reviewed by Sam Weinig.
2617 * Plugins/WebNetscapePluginView.h:
2618 * Plugins/WebNetscapePluginView.mm:
2619 (-[WebNetscapePluginView getVariable:value:]):
2620 (-[WebNetscapePluginView _destroyPlugin]):
2622 2016-08-18 Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au>
2624 [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
2625 https://bugs.webkit.org/show_bug.cgi?id=156096
2627 Reviewed by Dean Jackson.
2630 - Setup interface for enabling runtime flag for Web animations through preferences.
2632 * WebView/WebPreferenceKeysPrivate.h:
2633 * WebView/WebPreferences.mm:
2634 (+[WebPreferences initialize]):
2635 (-[WebPreferences webAnimationsEnabled]):
2636 (-[WebPreferences setWebAnimationsEnabled:]):
2637 * WebView/WebPreferencesPrivate.h:
2638 * WebView/WebView.mm:
2639 (-[WebView _preferencesChanged:]):
2641 2016-08-17 Anders Carlsson <andersca@apple.com>
2643 Remove a couple of unused WKSI function pointers
2644 https://bugs.webkit.org/show_bug.cgi?id=160946
2646 Reviewed by Dan Bernstein.
2648 * WebCoreSupport/WebSystemInterface.mm:
2649 (InitWebCoreSystemInterface): Deleted.
2651 2016-08-16 Daniel Bates <dabates@apple.com>
2653 WKSI static library should be named by major iOS revision, not individual updates
2654 https://bugs.webkit.org/show_bug.cgi?id=160727
2655 <rdar://problem/22274848>
2657 Reviewed by Alexey Proskuryakov.
2659 * Configurations/Base.xcconfig:
2660 * Configurations/DebugRelease.xcconfig:
2661 * Configurations/WebKitLegacy.xcconfig:
2663 2016-08-16 Darin Adler <darin@apple.com>
2665 [Cocoa] Remove dependency on Objective-C bindings in WebKit2 editing code
2666 https://bugs.webkit.org/show_bug.cgi?id=160891
2668 Reviewed by Anders Carlsson.
2670 * WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
2672 * WebCoreSupport/WebEditorClient.mm:
2673 (attributesForAttributedStringConversion): Replaced the
2674 createExcludedElementsForAttributedStringConversion function with this one.
2675 No good reason to keep the array around instead of the dictionary.
2676 (_WebCreateFragment): Renamed from documentFragmentFromAttributedString.
2677 This is now a global function exported so it can be called by WebCore with
2678 a different way of returning its value.
2680 * WebKit.exp: Added _WebCreateFragment.
2682 * WebView/WebHTMLView.mm:
2683 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2684 Removed long-ago-obsolete workaround for Radar bug 5052369.
2686 2016-08-15 Anders Carlsson <andersca@apple.com>
2692 2016-08-15 Anders Carlsson <andersca@apple.com>
2696 * Configurations/WebKitLegacy.xcconfig:
2699 2016-08-15 Anders Carlsson <andersca@apple.com>
2701 Remove OldWebAssertions.c
2702 https://bugs.webkit.org/show_bug.cgi?id=160862
2704 Reviewed by Dan Bernstein.
2706 These functions were used by an old version of iWeb. The latest version of iWeb no longer uses them.
2708 * Misc/OldWebAssertions.c: Removed.
2709 (WebReportAssertionFailure): Deleted.
2710 (WebReportError): Deleted.
2712 2016-08-15 Anders Carlsson <andersca@apple.com>
2714 Remove WebKeyGenerator
2715 https://bugs.webkit.org/show_bug.cgi?id=160854
2717 Reviewed by Dan Bernstein.
2719 This SPI class is no longer used by Safari.
2721 * WebCoreSupport/WebKeyGenerator.h: Removed.
2722 * WebCoreSupport/WebKeyGenerator.mm: Removed.
2723 (+[WebKeyGenerator sharedGenerator]): Deleted.
2724 (toWebCertificateParseResult): Deleted.
2725 (-[WebKeyGenerator addCertificatesToKeychainFromData:]): Deleted.
2726 * WebView/WebFrameView.mm:
2728 2016-08-15 Daniel Bates <dabates@apple.com>
2730 Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
2731 private frameworks and libraries
2732 https://bugs.webkit.org/show_bug.cgi?id=155931
2733 <rdar://problem/25807989>
2735 Reviewed by Dan Bernstein.
2737 Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
2738 where X is the major version of the active iOS SDK.
2740 * Configurations/WebKitLegacy.xcconfig:
2742 2016-08-15 Simon Fraser <simon.fraser@apple.com>
2744 Add a setting and preferences to enable visual viewport mode
2745 https://bugs.webkit.org/show_bug.cgi?id=160843
2747 Reviewed by Sam Weinig.
2749 Hook up the visualViewportEnabled setting for WebKit1.
2751 * WebView/WebPreferenceKeysPrivate.h:
2752 * WebView/WebPreferences.mm:
2753 (+[WebPreferences initialize]):
2754 (-[WebPreferences visualViewportEnabled]):
2755 (-[WebPreferences setVisualViewportEnabled:]):
2756 * WebView/WebPreferencesPrivate.h:
2758 2016-08-15 Joseph Pecoraro <pecoraro@apple.com>
2760 Remove unused includes of wtf headers
2761 https://bugs.webkit.org/show_bug.cgi?id=160839
2763 Reviewed by Alex Christensen.
2765 * History/BinaryPropertyList.cpp:
2766 * History/WebBackForwardList.mm:
2767 * History/WebHistoryItemInternal.h:
2768 * Misc/WebNSFileManagerExtras.mm:
2769 * Plugins/Hosted/NetscapePluginHostProxy.h:
2770 * WebCoreSupport/WebPlatformStrategies.mm:
2771 * WebCoreSupport/WebSelectionServiceController.mm:
2772 * WebCoreSupport/WebUserMediaClient.h:
2774 2016-08-12 Anders Carlsson <andersca@apple.com>
2776 Move the plug-in and WebGL blacklist code to WebCore
2777 https://bugs.webkit.org/show_bug.cgi?id=160831
2779 Reviewed by Sam Weinig.
2781 Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.
2783 * WebCoreSupport/WebFrameLoaderClient.mm:
2784 (shouldBlockPlugin):
2785 (WebFrameLoaderClient::createPlugin):
2786 (WebFrameLoaderClient::createJavaAppletWidget):
2788 (WebFrameLoaderClient::webGLPolicyForURL):
2789 (WebFrameLoaderClient::resolveWebGLPolicyForURL):
2791 2016-08-14 Daniel Bates <dabates@apple.com>
2793 Fix compiler errors when building iOS WebKit using the iOS 10 beta SDK
2794 https://bugs.webkit.org/show_bug.cgi?id=160725
2796 Reviewed by Sam Weinig.
2798 OSAtomicCompareAndSwap32() has been deprecated as of the iOS 10 beta SDK. For now,
2799 silence the complier warning.
2801 * WebView/WebView.mm:
2802 (-[WebView _dispatchTileDidDraw:]):
2804 2016-08-12 Joseph Pecoraro <pecoraro@apple.com>
2806 Remove always true JSC::Debugger::needPauseHandling virtual method
2807 https://bugs.webkit.org/show_bug.cgi?id=160822
2809 Reviewed by Mark Lam.
2811 * WebView/WebScriptDebugger.h:
2813 2016-08-11 Chris Dumez <cdumez@apple.com>
2815 Regression(r204268): Mail crashes when trying to compose an email
2816 https://bugs.webkit.org/show_bug.cgi?id=160775
2818 Reviewed by Anders Carlsson.
2820 Properly initialize PageConfiguration.pluginInfoProvider in
2821 [WebView initSimpleHTMLDocumentWithStyle] to avoid a null
2822 dereference in Mail when trying to compose an email.
2824 * WebView/WebView.mm:
2825 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2827 2016-08-10 Simon Fraser <simon.fraser@apple.com>
2829 Sort the feature flags in the FEATURE_DEFINES lines
2830 https://bugs.webkit.org/show_bug.cgi?id=160742
2832 Reviewed by Anders Carlsson.
2834 * Configurations/FeatureDefines.xcconfig:
2836 2016-08-09 Alex Christensen <achristensen@webkit.org>
2838 Move NetworkStorageSession management to WebCore
2839 https://bugs.webkit.org/show_bug.cgi?id=160173
2841 Reviewed by Brady Eidson.
2843 * WebCoreSupport/WebFrameNetworkingContext.mm:
2844 (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2845 (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2846 * WebCoreSupport/WebPlatformStrategies.mm:
2847 * WebView/WebView.mm:
2849 2016-08-09 Anders Carlsson <andersca@apple.com>
2851 Instantiate WebKit plug-ins at layout time, instead of at style resolution time
2852 https://bugs.webkit.org/show_bug.cgi?id=160715
2854 Reviewed by Tim Horton.
2856 * WebCoreSupport/WebFrameLoaderClient.mm:
2857 (WebFrameLoaderClient::objectContentType):
2859 2016-08-09 George Ruan <gruan@apple.com>
2861 Implement functionality of media capture on iOS
2862 https://bugs.webkit.org/show_bug.cgi?id=158945
2863 <rdar://problem/26893343>
2865 Reviewed by Tim Horton.
2867 * Configurations/FeatureDefines.xcconfig: Enable Media Capture feature
2870 2016-08-09 Anders Carlsson <andersca@apple.com>
2872 Get rid of PluginStrategy
2873 https://bugs.webkit.org/show_bug.cgi?id=160696
2875 Reviewed by Dan Bernstein.
2877 * WebCoreSupport/WebPlatformStrategies.h:
2878 * WebCoreSupport/WebPlatformStrategies.mm:
2879 (WebPlatformStrategies::createPluginStrategy): Deleted.
2880 * WebCoreSupport/WebPluginInfoProvider.h:
2881 * WebCoreSupport/WebPluginInfoProvider.mm:
2882 (WebPluginInfoProvider::setPluginLoadClientPolicy): Deleted.
2883 (WebPluginInfoProvider::clearPluginClientPolicies): Deleted.
2885 2016-08-09 Anders Carlsson <andersca@apple.com>
2887 Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
2888 https://bugs.webkit.org/show_bug.cgi?id=160694
2890 Reviewed by Dan Bernstein.
2892 * WebCoreSupport/WebPlatformStrategies.h:
2893 * WebCoreSupport/WebPlatformStrategies.mm:
2894 (WebPlatformStrategies::createPluginStrategy):
2895 (WebPlatformStrategies::refreshPlugins): Deleted.
2896 (WebPlatformStrategies::getPluginInfo): Deleted.
2897 (WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
2898 (WebPlatformStrategies::setPluginLoadClientPolicy): Deleted.
2899 (WebPlatformStrategies::clearPluginClientPolicies): Deleted.
2900 * WebCoreSupport/WebPluginInfoProvider.mm:
2901 (WebPluginInfoProvider::refreshPlugins):
2902 (WebPluginInfoProvider::getPluginInfo):
2903 (WebPluginInfoProvider::getWebVisiblePluginInfo):
2905 2016-08-08 Anders Carlsson <andersca@apple.com>
2907 Add a new PluginInfoProvider class, to replace PluginStrategy
2908 https://bugs.webkit.org/show_bug.cgi?id=160670
2910 Reviewed by Sam Weinig.
2912 Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
2914 * WebCoreSupport/WebPluginInfoProvider.h: Added.
2915 * WebCoreSupport/WebPluginInfoProvider.mm: Added.
2916 (WebPluginInfoProvider::singleton):
2917 (WebPluginInfoProvider::WebPluginInfoProvider):
2918 (WebPluginInfoProvider::~WebPluginInfoProvider):
2919 (WebPluginInfoProvider::refreshPlugins):
2920 (WebPluginInfoProvider::getPluginInfo):
2921 (WebPluginInfoProvider::getWebVisiblePluginInfo):
2922 (WebPluginInfoProvider::setPluginLoadClientPolicy):
2923 (WebPluginInfoProvider::clearPluginClientPolicies):
2924 * WebView/WebView.mm:
2925 (-[WebView _commonInitializationWithFrameName:groupName:]):
2927 2016-08-02 Enrica Casucci <enrica@apple.com>
2929 Allow building with content filtering disabled.
2930 https://bugs.webkit.org/show_bug.cgi?id=160454
2932 Reviewed by Simon Fraser.
2934 * Configurations/FeatureDefines.xcconfig:
2935 * WebCoreSupport/WebFrameLoaderClient.h:
2936 * WebCoreSupport/WebFrameLoaderClient.mm:
2937 (WebFrameLoaderClient::blockedByContentFilterError):
2939 2016-08-02 Anders Carlsson <andersca@apple.com>
2941 Remove more unused/uninstalled Objective-C DOM bindings
2942 https://bugs.webkit.org/show_bug.cgi?id=160464
2944 Reviewed by Darin Adler.
2946 Stop installing unused headers.
2948 * MigrateHeaders.make:
2950 2016-08-01 Anders Carlsson <andersca@apple.com>
2952 Bring back a file - it needs to be copied by WebCore.
2954 * MigrateHeaders.make:
2956 2016-08-01 Anders Carlsson <andersca@apple.com>
2958 Remove another file.
2960 * MigrateHeaders.make:
2962 2016-08-01 Anders Carlsson <andersca@apple.com>
2966 * MigrateHeaders.make:
2968 2016-08-01 Anders Carlsson <andersca@apple.com>
2970 Freeze all the DOMHTML* Objective-C bindings
2971 https://bugs.webkit.org/show_bug.cgi?id=160424
2973 Reviewed by Tim Horton.
2975 Don't migrate DOMHTMLEmbedElementPrivate.h - it was just an empty header.
2977 * MigrateHeaders.make:
2979 2016-07-28 Myles C. Maxfield <mmaxfield@apple.com>
2981 Remove deprecated SPI for video inline / fullscreen controls
2982 https://bugs.webkit.org/show_bug.cgi?id=160318
2984 Reviewed by Tim Horton.
2986 * WebView/WebPreferenceKeysPrivate.h:
2987 * WebView/WebPreferences.mm:
2988 (+[WebPreferences initialize]): Deleted.
2989 (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]): Deleted.
2990 (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]): Deleted.
2991 (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]): Deleted.
2992 (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]): Deleted.
2993 * WebView/WebPreferencesPrivate.h:
2994 * WebView/WebView.mm:
2995 (-[WebView _preferencesChanged:]): Deleted.
2997 2016-07-28 Anders Carlsson <andersca@apple.com>
2999 Move a Mail.app workaround closer to where it's actually needed
3000 https://bugs.webkit.org/show_bug.cgi?id=160317
3002 Reviewed by Tim Horton.
3004 * WebCoreSupport/WebFrameLoaderClient.mm:
3005 (WebFrameLoaderClient::dispatchWillSendRequest):
3006 * WebView/WebFrame.mm:
3007 (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Deleted.
3009 2016-07-28 Anders Carlsson <andersca@apple.com>
3011 Use a RetainPtr in WebFrameLoaderClient::assignIdentifierToInitialRequest
3012 https://bugs.webkit.org/show_bug.cgi?id=160315
3014 Reviewed by Tim Horton.
3016 * WebCoreSupport/WebFrameLoaderClient.mm:
3017 (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3019 2016-07-26 Simon Fraser <simon.fraser@apple.com>
3021 Fix the Windows debug build.
3023 WebResourceLoadScheduler's logging was a holdover from it being in WebCore,
3024 and prior to r203749 WebKit was actually using a WebCore log channel.
3026 For some reason this doesn't build on Windows debug, so just remove
3027 this logging for now.
3029 * Misc/WebKitLogging.h:
3031 2016-07-26 Myles C. Maxfield <mmaxfield@apple.com>
3033 [iPhone] Playing a video on tudou.com plays only sound, no video
3034 https://bugs.webkit.org/show_bug.cgi?id=160178
3035 <rdar://problem/27535468>
3037 Reviewed by Eric Carlson and Dan Bernstein.
3039 * WebView/WebPreferenceKeysPrivate.h:
3040 * WebView/WebPreferences.mm:
3041 (+[WebPreferences initialize]):
3042 (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]):
3043 (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]):
3044 * WebView/WebPreferencesPrivate.h:
3045 * WebView/WebView.mm:
3046 (-[WebView _preferencesChanged:]):
3048 2016-07-26 Simon Fraser <simon.fraser@apple.com>
3050 Allow LOG macros to be used outside the namespace, and other logging cleanup
3051 https://bugs.webkit.org/show_bug.cgi?id=160216
3053 Reviewed by Anders Carlsson.
3055 Fix some issues with the LOG macros.
3057 First, they were not usable outside the WebKit namespace in WebKit2 code. Fix by moving
3058 its log channels outside of the namespace (they are protected by a unique prefix anyway).
3060 Second, allow LOG_WITH_STREAM to be used in WebKit2 by moving that and a helper macro
3061 into LogMacros.h, which is exported from WebCore as a private header.
3063 Third, split the Logging.h header into two. Logging.h remains for framework-internal
3064 log channels and log macros. Add LogInitialization.h which is external, and used to
3065 initialize the channels.
3067 Finally unify "initializeLogChannels" and "initializeLoggingChannels" terminology everywhere.
3069 * Misc/WebKitLogging.h:
3070 * Misc/WebKitLogging.m:
3071 * WebView/WebView.mm:
3072 (-[WebView _commonInitializationWithFrameName:groupName:]):
3074 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
3076 Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
3077 https://bugs.webkit.org/show_bug.cgi?id=160066
3079 Reviewed by Dean Jackson.
3081 * WebView/WebPreferenceKeysPrivate.h:
3082 * WebView/WebPreferences.mm:
3083 (+[WebPreferences initialize]): Deleted.
3084 (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]): Deleted.
3085 (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): Deleted.
3086 * WebView/WebPreferencesPrivate.h:
3087 * WebView/WebView.mm:
3088 (-[WebView _preferencesChanged:]): Deleted.
3090 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
3092 [iPhone] Playing a video on tudou.com plays only sound, no video
3093 https://bugs.webkit.org/show_bug.cgi?id=159967
3094 <rdar://problem/26964090>
3096 Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
3098 Add the two preferences to WebPreferences.
3100 * WebView/WebPreferenceKeysPrivate.h:
3101 * WebView/WebPreferences.mm:
3102 (+[WebPreferences initialize]):
3103 (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
3104 (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
3105 (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
3106 (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
3107 * WebView/WebPreferencesPrivate.h:
3108 * WebView/WebView.mm:
3109 (-[WebView _preferencesChanged:]):
3111 2016-07-20 Commit Queue <commit-queue@webkit.org>
3113 Unreviewed, rolling out r203471.
3114 https://bugs.webkit.org/show_bug.cgi?id=160003
3116 many iOS-simulator tests are failing (Requested by litherum on
3121 "[iPhone] Playing a video on tudou.com plays only sound, no
3123 https://bugs.webkit.org/show_bug.cgi?id=159967
3124 http://trac.webkit.org/changeset/203471
3126 2016-07-20 Myles C. Maxfield <mmaxfield@apple.com>
3128 [iPhone] Playing a video on tudou.com plays only sound, no video
3129 https://bugs.webkit.org/show_bug.cgi?id=159967
3130 <rdar://problem/26964090>
3132 Reviewed by Jon Lee.
3134 Add the two preferences to WebPreferences.
3136 * WebView/WebPreferenceKeysPrivate.h:
3137 * WebView/WebPreferences.mm:
3138 (+[WebPreferences initialize]):
3139 (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
3140 (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
3141 (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
3142 (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
3143 * WebView/WebPreferencesPrivate.h:
3144 * WebView/WebView.mm:
3145 (-[WebView _preferencesChanged:]):
3147 2016-07-19 Andy Estes <aestes@apple.com>
3149 Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
3150 https://bugs.webkit.org/show_bug.cgi?id=159956
3152 Reviewed by Dan Bernstein.
3154 * Misc/WebKitErrors.h: Moved definition of WebKitErrorFrameLoadBlockedByContentFilter from here ...
3155 * Misc/WebKitErrorsPrivate.h: to here.
3157 2016-07-18 Anders Carlsson <andersca@apple.com>
3159 WebKit nightly fails to build on macOS Sierra
3160 https://bugs.webkit.org/show_bug.cgi?id=159902
3161 rdar://problem/27365672
3163 Reviewed by Tim Horton.
3165 * icu/unicode/ucurr.h: Added.
3166 Add ucurr.h from ICU.
3168 2016-07-17 Sam Weinig <sam@webkit.org>
3170 [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3171 <rdar://problem/26554137>
3172 https://bugs.webkit.org/show_bug.cgi?id=159856
3174 Reviewed by Dan Bernstein.
3176 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3177 (WebKit::NetscapePluginInstanceProxy::evaluate):
3178 * Plugins/WebNetscapePluginView.mm:
3179 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
3180 Update for new UserGestureIndicator interface.
3182 2016-07-16 Ryosuke Niwa <rniwa@webkit.org>
3184 Rename fastGetAttribute to attributeWithoutSynchronization
3185 https://bugs.webkit.org/show_bug.cgi?id=159852
3187 Reviewed by Darin Adler.
3189 * WebView/WebHTMLRepresentation.mm:
3190 (matchLabelsAgainstElement):
3192 2016-07-15 Chris Dumez <cdumez@apple.com>
3194 Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
3195 https://bugs.webkit.org/show_bug.cgi?id=159793
3197 Reviewed by Ryosuke Niwa.
3199 Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.
3201 * WebView/WebHTMLRepresentation.mm:
3202 (matchLabelsAgainstElement):
3204 2016-07-14 Alex Christensen <achristensen@webkit.org>
3206 Use SocketProvider to create SocketStreamHandles
3207 https://bugs.webkit.org/show_bug.cgi?id=159774
3209 Reviewed by Brady Eidson.
3211 * Misc/WebSocketProvider.h: Removed.
3212 * Misc/WebSocketProvider.mm: Removed.
3213 * WebView/WebView.mm:
3214 (-[WebView _commonInitializationWithFrameName:groupName:]):
3215 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3217 2016-07-14 Csaba Osztrogonác <ossy@webkit.org>
3219 Fix the !ENABLE(WEB_SOCKETS) build after r202930
3220 https://bugs.webkit.org/show_bug.cgi?id=159768
3222 Reviewed by Alex Christensen.
3224 * Misc/WebSocketProvider.h:
3226 2016-07-13 Beth Dakin <bdakin@apple.com>
3228 Add more candidate tests
3229 https://bugs.webkit.org/show_bug.cgi?id=159730
3231 Reviewed by Tim Horton.
3233 Move shouldRequestCandidates from WebViewInternal to WebViewPrivate so that
3234 we can use it in tests.
3235 * WebView/WebViewInternal.h:
3236 * WebView/WebViewPrivate.h:
3238 2016-07-13 Enrica Casucci <enrica@apple.com>
3240 Update supported platforms in xcconfig files to match the sdk names.
3241 https://bugs.webkit.org/show_bug.cgi?id=159728
3243 Reviewed by Tim Horton.
3245 * Configurations/Base.xcconfig:
3247 2016-07-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3249 Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3250 https://bugs.webkit.org/show_bug.cgi?id=159671
3252 Reviewed by Csaba Osztrogonác.
3254 ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3255 https://bugs.webkit.org/show_bug.cgi?id=89235
3257 So this guard can be removed in build scripts.
3259 * Configurations/FeatureDefines.xcconfig:
3261 2016-07-11 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3263 Purge PassRefPtr in platform/efl and platform/mac
3264 https://bugs.webkit.org/show_bug.cgi?id=159548
3266 Reviewed by Alex Christensen.
3268 Remove all use of PassRefPtr and clean up unnecessary tabs and spaces.
3270 * WebCoreSupport/WebPlatformStrategies.h:
3271 * WebCoreSupport/WebPlatformStrategies.mm:
3272 (WebPlatformStrategies::setBufferForType):
3274 2016-07-11 Enrica Casucci <enrica@apple.com>
3276 Add synthetic click origin to WKNavigationAction.
3277 https://bugs.webkit.org/show_bug.cgi?id=159584
3278 rdar://problem/25610422
3280 Reviewed by Tim Horton.
3282 * WebView/WebFrame.mm:
3283 (-[WebFrame _dragSourceEndedAt:operation:]):
3284 * WebView/WebPDFView.mm:
3285 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3287 2016-07-11 Anders Carlsson <andersca@apple.com>
3289 Able to open multiple payment sheets in Safari at the same time
3290 https://bugs.webkit.org/show_bug.cgi?id=159637
3291 rdar://problem/26411339
3293 Reviewed by Beth Dakin.
3295 Update for WebCore changes.
3297 * WebCoreSupport/WebPaymentCoordinatorClient.h:
3298 * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3299 (WebPaymentCoordinatorClient::showPaymentUI):
3301 2016-07-08 Andy Estes <aestes@apple.com>
3303 [Content Filtering] Load blocked pages more like other error pages are loaded
3304 https://bugs.webkit.org/show_bug.cgi?id=159485
3305 <rdar://problem/26014076>
3307 Reviewed by Brady Eidson.
3309 * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
3310 * Misc/WebKitErrors.m:
3311 (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
3312 * WebCoreSupport/WebFrameLoaderClient.h:
3313 * WebCoreSupport/WebFrameLoaderClient.mm:
3314 (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
3316 2016-07-08 Commit Queue <commit-queue@webkit.org>
3318 Unreviewed, rolling out r202944.
3319 https://bugs.webkit.org/show_bug.cgi?id=159570
3321 caused some tests to crash under GuardMalloc (Requested by
3326 "[Content Filtering] Load blocked pages more like other error
3328 https://bugs.webkit.org/show_bug.cgi?id=159485
3329 http://trac.webkit.org/changeset/202944
3331 2016-07-08 Jiewen Tan <jiewen_tan@apple.com>
3333 Define DYLD_MACOSX_VERSION_10_12
3334 https://bugs.webkit.org/show_bug.cgi?id=159525
3335 <rdar://problem/26250296>
3337 Reviewed by Brent Fulgham.
3339 * WebView/WebView.mm:
3340 (shouldConvertInvalidURLsToBlank):
3341 Replace 0x000A0C00 with DYLD_MACOSX_VERSION_10_12.
3343 2016-07-07 Beth Dakin <bdakin@apple.com>
3345 API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3346 https://bugs.webkit.org/show_bug.cgi?id=159532
3348 rdar://problem/27177179
3350 Reviewed by Tim Horton.
3352 * WebView/WebView.mm:
3353 (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3354 (-[WebView forceRequestCandidatesForTesting]):
3355 (-[WebView shouldRequestCandidates]):
3356 * WebView/WebViewPrivate.h:
3358 2016-07-07 Andy Estes <aestes@apple.com>
3360 [Content Filtering] Load blocked pages more like other error pages are loaded
3361 https://bugs.webkit.org/show_bug.cgi?id=159485
3362 <rdar://problem/26014076>
3364 Reviewed by Brady Eidson.
3366 * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
3367 * Misc/WebKitErrors.m:
3368 (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
3369 * WebCoreSupport/WebFrameLoaderClient.h:
3370 * WebCoreSupport/WebFrameLoaderClient.mm:
3371 (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
3373 2016-07-07 Alex Christensen <achristensen@webkit.org>
3375 Use SocketProvider to create WebSocketChannels
3376 https://bugs.webkit.org/show_bug.cgi?id=158776
3378 Reviewed by Brent Fulgham.
3380 * Misc/WebSocketProvider.mm: Copied from Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp.
3381 (WebSocketProvider::createWebSocketChannel):
3382 (WebCore::ThreadableWebSocketChannel::create): Deleted.
3383 * Misc/WebSocketProvider.h:
3384 * WebView/WebView.mm:
3385 (-[WebView _commonInitializationWithFrameName:groupName:]):
3386 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3388 2016-07-06 Benjamin Poulain <bpoulain@apple.com>
3390 [JSC] Unify how we throw TypeError from C++
3391 https://bugs.webkit.org/show_bug.cgi?id=159500
3393 Reviewed by Saam Barati.
3395 * Plugins/Hosted/ProxyInstance.mm:
3396 (WebKit::ProxyInstance::invokeMethod):
3398 2016-07-01 Youenn Fablet <youennf@gmail.com>
3400 Add a runtime flag for DOM iterators
3401 https://bugs.webkit.org/show_bug.cgi?id=159300
3403 Reviewed by Alex Christensen.
3405 * WebView/WebPreferenceKeysPrivate.h:
3406 * WebView/WebPreferences.mm:
3407 (-[WebPreferences DOMIteratorEnabled]):
3408 (-[WebPreferences setDOMIteratorEnabled:]):
3409 * WebView/WebPreferencesPrivate.h:
3410 * WebView/WebView.mm:
3411 (-[WebView _preferencesChanged:]):
3413 2016-06-30 Jiewen Tan <jiewen_tan@apple.com>
3415 Create a generic "linked-on-or-after" check for new CSP Rules
3416 https://bugs.webkit.org/show_bug.cgi?id=159322
3417 <rdar://problem/27117220>
3419 Reviewed by Brent Fulgham.
3421 * WebView/WebView.mm:
3422 (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
3424 2016-06-30 Anders Carlsson <andersca@apple.com>
3426 Mail crashes on launch at WebCore::PaymentCoordinator::~PaymentCoordinator() + 20
3427 https://bugs.webkit.org/show_bug.cgi?id=159306
3428 rdar://problem/27092107
3430 Reviewed by Tim Horton.
3432 * WebView/WebView.mm:
3433 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3434 Create a WebPaymentCoordinatorClient. Remove an unneeded #import.
3436 (-[WebView _commonInitializationWithFrameName:groupName:]):
3437 Remove an unneeded #import.
3439 2016-06-27 Anders Carlsson <andersca@apple.com>
3441 WebKit::WebPaymentCoordinator leak
3442 https://bugs.webkit.org/show_bug.cgi?id=159168
3443 rdar://problem/26929772
3445 Reviewed by Beth Dakin.
3447 Update for WebCore changes.
3449 * WebCoreSupport/WebPaymentCoordinatorClient.h:
3450 * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3451 (WebPaymentCoordinatorClient::paymentCoordinatorDestroyed):
3452 (WebPaymentCoordinatorClient::mainFrameDestroyed): Deleted.
3454 2016-06-27 Tim Horton <timothy_horton@apple.com>
3456 REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app
3457 https://bugs.webkit.org/show_bug.cgi?id=159184
3458 <rdar://problem/26370206>
3460 Reviewed by Beth Dakin.
3462 * WebView/WebHTMLView.mm:
3463 (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3464 * WebView/WebImmediateActionController.h:
3465 * WebView/WebImmediateActionController.mm:
3466 (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3467 (-[WebImmediateActionController _animationControllerForText]):
3468 (dictionaryPopupInfoForRange): Deleted.
3469 WebImmediateActionController's code to make a DictionaryPopupInfo and TextIndicator
3470 from a Range in WebKit1 is much better than WebHTMLView's; use it in both cases.
3472 2016-06-24 Jer Noble <jer.noble@apple.com>
3474 Playback controls refer to wrong element when playing multiple items in a page.
3475 https://bugs.webkit.org/show_bug.cgi?id=159076
3476 <rdar://problem/26953532>
3478 Reviewed by Beth Dakin.
3480 clearPlaybackControlsManager() no longer takes a parameter.
3482 * WebCoreSupport/WebChromeClient.h:
3483 * WebCoreSupport/WebChromeClient.mm:
3484 (WebChromeClient::clearPlaybackControlsManager):
3485 * WebView/WebView.mm:
3486 (-[WebView _clearPlaybackControlsManager]): Renamed from _clearPlaybackControlsManagerForMediaElement:.
3487 * WebView/WebViewInternal.h:
3489 2016-06-23 Alex Christensen <achristensen@webkit.org>
3491 Remove unused didCancelAuthenticationChallenge
3492 https://bugs.webkit.org/show_bug.cgi?id=158819
3494 Reviewed by David Kilzer.
3496 * Misc/WebDownload.mm:
3497 (-[WebDownloadInternal download:didCancelAuthenticationChallenge:]): Deleted.
3498 * WebCoreSupport/WebFrameLoaderClient.h:
3499 * WebCoreSupport/WebFrameLoaderClient.mm:
3500 (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.
3501 * WebView/WebDelegateImplementationCaching.h:
3502 * WebView/WebView.mm:
3503 (-[WebView _cacheResourceLoadDelegateImplementations]):
3505 2016-06-23 John Wilander <wilander@apple.com>
3507 Enable window.open() for existing versions of Secret Society app
3508 https://bugs.webkit.org/show_bug.cgi?id=159049
3509 <rdar://problem/26528349>
3511 Reviewed by Andy Estes.
3513 The Secret Society Hidden Mystery app has a broken version check treating iOS 10
3514 as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
3515 handler. We should allow the existing versions of the app to do this to not break
3518 * WebView/WebView.mm:
3519 (shouldAllowWindowOpenWithoutUserGesture):
3521 (shouldConvertInvalidURLsToBlank):
3522 Changed hex number to constant DYLD_IOS_VERSION_10_0.
3524 2016-06-22 Anders Carlsson <andersca@apple.com>
3526 Move the WebKitLegacy Apple Pay code to the open source repository
3527 https://bugs.webkit.org/show_bug.cgi?id=159035
3529 Reviewed by Tim Horton.
3531 * WebCoreSupport/WebPaymentCoordinatorClient.h: Added.
3532 * WebCoreSupport/WebPaymentCoordinatorClient.mm: Added.
3533 (WebPaymentCoordinatorClient::WebPaymentCoordinatorClient):
3534 (WebPaymentCoordinatorClient::~WebPaymentCoordinatorClient):
3535 (WebPaymentCoordinatorClient::supportsVersion):
3536 (WebPaymentCoordinatorClient::canMakePayments):
3537 (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
3538 (WebPaymentCoordinatorClient::showPaymentUI):
3539 (WebPaymentCoordinatorClient::completeMerchantValidation):
3540 (WebPaymentCoordinatorClient::completeShippingMethodSelection):
3541 (WebPaymentCoordinatorClient::completeShippingContactSelection):
3542 (WebPaymentCoordinatorClient::completePaymentMethodSelection):
3543 (WebPaymentCoordinatorClient::completePaymentSession):
3544 (WebPaymentCoordinatorClient::abortPaymentSession):
3545 (WebPaymentCoordinatorClient::mainFrameDestroyed):
3546 * WebKitAdditions.mm: Removed.
3547 * WebView/WebView.mm:
3548 (-[WebView _commonInitializationWithFrameName:groupName:]):
3550 2016-06-21 Anders Carlsson <andersca@apple.com>
3554 * Configurations/FeatureDefines.xcconfig:
3556 2016-06-21 Anders Carlsson <andersca@apple.com>
3558 Begin moving the Apple Pay code to the open source repository
3559 https://bugs.webkit.org/show_bug.cgi?id=158998