Rename pageCache() to PageCache::shared() and return a reference
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-01-28  Chris Dumez  <cdumez@apple.com>
2
3         Rename pageCache() to PageCache::shared() and return a reference
4         https://bugs.webkit.org/show_bug.cgi?id=140983
5
6         Reviewed by Andreas Kling.
7
8         Rename pageCache() to PageCache::shared() as this is a singleton class
9         and have it return a reference instead of a pointer.
10
11         * History/WebBackForwardList.mm:
12         (-[WebBackForwardList pageCacheSize]):
13         * Misc/WebCoreStatistics.mm:
14         (+[WebCoreStatistics cachedPageCount]):
15         (+[WebCoreStatistics cachedFrameCount]):
16         * WebCoreSupport/WebVisitedLinkStore.mm:
17         (WebVisitedLinkStore::removeAllVisitedLinks):
18         (WebVisitedLinkStore::removeVisitedLink):
19         (WebVisitedLinkStore::addVisitedLinkHash):
20         * WebView/WebView.mm:
21         (+[WebView _setCacheModel:]):
22
23 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
24
25         More build fixes for newer clang.
26
27         Rubber-stamped by Anders Carlsson.
28
29         Marked a deprecated accessibility method as such.
30
31         * WebView/WebFrame.mm:
32         (-[WebFrame accessibilityRoot]):
33
34 2015-01-27  Beth Dakin  <bdakin@apple.com>
35
36         Immediate action gesture recognizer still doesn't work well with IB
37         https://bugs.webkit.org/show_bug.cgi?id=140967
38         -and corresponding-
39         rdar://problem/19621509
40
41         Reviewed by Tim Horton.
42
43         We should add (or remove) the gesture recognizer in viewDidMoveToWindow because 
44         initWithFrame it too early and IB might mess with it.
45         * WebView/WebImmediateActionController.h:
46         * WebView/WebImmediateActionController.mm:
47         (-[WebImmediateActionController immediateActionRecognizer]):
48         * WebView/WebView.mm:
49         (-[WebView _commonInitializationWithFrameName:groupName:]):
50         (-[WebView viewDidMoveToWindow]):
51
52 2015-01-27  Dan Bernstein  <mitz@apple.com>
53
54         Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
55
56         Rubber-stamped by Anders Carlsson.
57
58         * WebView/WebView.h: Added forward declarations of the protocols.
59
60 2015-01-26  Anders Carlsson  <andersca@apple.com>
61
62         Make it easy to test enabling formal delegate protocols
63         https://bugs.webkit.org/show_bug.cgi?id=140892
64
65         Reviewed by Dan Bernstein.
66
67         Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
68
69         * Misc/WebDownload.h:
70         * WebView/WebFrameLoadDelegate.h:
71         * WebView/WebPolicyDelegate.h:
72         * WebView/WebResourceLoadDelegate.h:
73         * WebView/WebUIDelegate.h:
74         * WebView/WebView.h:
75
76 2015-01-26  Chris Dumez  <cdumez@apple.com>
77
78         Rename Document::body() to Document::bodyOrFrameset() for clarity
79         https://bugs.webkit.org/show_bug.cgi?id=140902
80
81         Reviewed by Andreas Kling.
82
83         Rename Document::body() to Document::bodyOrFrameset() for clarity. This
84         method does not necessarily return an HTMLBodyElement, it can also
85         return a frameset as per the specification:
86         http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
87
88         This method is often misused internally (the caller is only interested
89         in the <body> element). I will fix these instances in a follow-up patch,
90         this patch is only renaming mechanically.
91
92 2015-01-26  Chris Dumez  <cdumez@apple.com>
93
94         First argument to DOM traversal functions should be a reference
95         https://bugs.webkit.org/show_bug.cgi?id=140895
96
97         Reviewed by Antti Koivisto.
98
99         First argument to DOM traversal functions should be a reference instead
100         of a pointer as it is dereferenced without null-check.
101
102 2015-01-26  Myles C. Maxfield  <mmaxfield@apple.com>
103
104         [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
105         https://bugs.webkit.org/show_bug.cgi?id=140860
106
107         Reviewed by Darin Adler.
108
109         The fonts it makes are grotesque. (See what I did there? Typographic
110         humor is the best humor.)
111
112         * Configurations/FeatureDefines.xcconfig:
113
114 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
115
116         QLPreviewMenuItem popovers don't close when the page scrolls
117         https://bugs.webkit.org/show_bug.cgi?id=140806
118         <rdar://problem/19555618>
119
120         Reviewed by Beth Dakin.
121
122         Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
123
124         * WebView/WebHTMLView.mm:
125         (-[WebHTMLView scrollWheel:scrollWheel:]):
126         Send scrollWheel along to WebImmediateActionController.
127
128         * WebView/WebImmediateActionController.h:
129         * WebView/WebImmediateActionController.mm:
130         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
131         (-[WebImmediateActionController _clearImmediateActionState]):
132         (-[WebImmediateActionController _defaultAnimationController]):
133         Keep track of the active QLPreviewMenuItem, and close it upon scroll.
134
135 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
136
137         Infinite recursion in _clearImmediateActionState
138         https://bugs.webkit.org/show_bug.cgi?id=140807
139         <rdar://problem/19571601>
140
141         Reviewed by Anders Carlsson.
142
143         * WebView/WebImmediateActionController.mm:
144         (-[WebImmediateActionController _clearImmediateActionState]):
145         Use this opportunity to bring identical code to WebKit1, to avoid
146         getting DataDetectors stuck when an immediate action is canceled.
147
148 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
149
150         Add a build flag for ES6 class syntax
151         https://bugs.webkit.org/show_bug.cgi?id=140760
152
153         Reviewed by Michael Saboff.
154
155         * Configurations/FeatureDefines.xcconfig:
156
157 2015-01-22  Beth Dakin  <bdakin@apple.com>
158
159         ibtoold crash below -[WebView close]
160         https://bugs.webkit.org/show_bug.cgi?id=140782
161         -and corresponding-
162         rdar://problem/19558472
163
164         Reviewed by Tim Horton.
165
166         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
167         it is because interface builder is messing with our views.
168         * WebView/WebImmediateActionController.h:
169         * WebView/WebImmediateActionController.mm:
170         (-[WebImmediateActionController webViewClosed]):
171         (-[WebImmediateActionController _cancelImmediateAction]):
172         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
173         (-[WebImmediateActionController _updateImmediateActionItem]):
174
175 2015-01-21  Beth Dakin  <bdakin@apple.com>
176
177         Crash in QuickLook preview delegate method
178         https://bugs.webkit.org/show_bug.cgi?id=140740
179         -and corresponding-
180         rdar://problem/19540806
181
182         Reviewed by Tim Horton.
183
184         Clear out the delegate.
185         * WebView/WebImmediateActionController.mm:
186         (-[WebImmediateActionController webViewClosed]):
187
188 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
189
190         Remove ENABLE(INSPECTOR) ifdef guards
191         https://bugs.webkit.org/show_bug.cgi?id=140668
192
193         Reviewed by Darin Adler.
194
195         * Configurations/FeatureDefines.xcconfig:
196         * WebCoreSupport/WebFrameLoaderClient.mm:
197         (WebFrameLoaderClient::dispatchWillSendRequest):
198
199 2015-01-20  Anders Carlsson  <andersca@apple.com>
200
201         Remove USE(GLIB) code from WebKit1
202         https://bugs.webkit.org/show_bug.cgi?id=140714
203
204         Reviewed by Andreas Kling.
205
206         * WebView/WebView.mm:
207         (-[WebView _commonInitializationWithFrameName:groupName:]):
208         (-[WebView _close]):
209         (-[WebView _clearGlibLoopObserver]): Deleted.
210         (glibContextIterationCallback): Deleted.
211         (-[WebView _scheduleGlibContextIterations]): Deleted.
212         * WebView/WebViewData.h:
213         * WebView/WebViewInternal.h:
214
215 2015-01-20  David Kilzer  <ddkilzer@apple.com>
216
217         Switch to comparing PLATFORM_NAME in terms of macosx
218         <http://webkit.org/b/139516>
219
220         Reviewed by Timothy Hatcher.
221
222         * MigrateHeaders.make:
223         * postprocess-headers.sh:
224
225 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
226
227         [SVG -> OTF Converter] Flip the switch on
228         https://bugs.webkit.org/show_bug.cgi?id=140592
229
230         Reviewed by Antti Koivisto.
231
232         * Configurations/FeatureDefines.xcconfig:
233
234 2015-01-19  Beth Dakin  <bdakin@apple.com>
235
236         Speculative build fix.
237
238         * WebView/WebView.mm:
239         (-[WebView _commonInitializationWithFrameName:groupName:]):
240
241 2015-01-19  Beth Dakin  <bdakin@apple.com>
242
243         Speculative build fix.
244
245         * WebView/WebView.mm:
246         (-[WebView _convertRectFromRootView:]):
247
248 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
249
250         Adjust naming of action menu SPI
251         https://bugs.webkit.org/show_bug.cgi?id=140644
252         <rdar://problem/19448129>
253
254         Reviewed by Brian Weinstein.
255
256         * WebView/WebActionMenuController.mm:
257         (-[WebActionMenuController prepareForMenu:withEvent:]):
258         (-[WebActionMenuController willOpenMenu:withEvent:]):
259         (-[WebActionMenuController didCloseMenu:withEvent:]):
260         * WebView/WebView.mm:
261         (-[WebView _commonInitializationWithFrameName:groupName:]):
262         (-[WebView prepareForMenu:withEvent:]):
263         (-[WebView willOpenMenu:withEvent:]):
264         (-[WebView didCloseMenu:withEvent:]):
265
266 2015-01-19  Beth Dakin  <bdakin@apple.com>
267
268         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
269         offset by flipped-ness
270         https://bugs.webkit.org/show_bug.cgi?id=140643
271         -and corresponding-
272         rdar://problem/19489593
273
274         Reviewed by Tim Horton.
275
276         We universally flipped because we assumed that the root view was flipped and the 
277         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
278         fixes that assumption by checking the WebView’s flipped-ness.
279         * WebView/WebView.mm:
280         (-[WebView _convertRectFromRootView:]):
281
282 2015-01-19  Commit Queue  <commit-queue@webkit.org>
283
284         Unreviewed, rolling out r178653.
285         https://bugs.webkit.org/show_bug.cgi?id=140634
286
287         Broke multiple SVG tests on Mountain Lion (Requested by ap on
288         #webkit).
289
290         Reverted changeset:
291
292         "[SVG -> OTF Converter] Flip the switch on"
293         https://bugs.webkit.org/show_bug.cgi?id=140592
294         http://trac.webkit.org/changeset/178653
295
296 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
297
298         [SVG -> OTF Converter] Flip the switch on
299         https://bugs.webkit.org/show_bug.cgi?id=140592
300
301         Reviewed by Antti Koivisto.
302
303         * Configurations/FeatureDefines.xcconfig:
304
305 2015-01-18  Daniel Bates  <dabates@apple.com>
306
307         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
308         (https://bugs.webkit.org/show_bug.cgi?id=129441)
309
310         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
311         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
312
313         * WebInspector/WebNodeHighlightView.mm:
314         (-[WebNodeHighlightView layoutSublayers:]):
315
316 2015-01-16  Beth Dakin  <bdakin@apple.com>
317
318         Make sure early cancellation of immediate action actually does that in WK1
319         https://bugs.webkit.org/show_bug.cgi?id=140566
320         -and corresponding-
321         rdar://problem/19490114
322
323         Reviewed by Tim Horton.
324
325         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
326         asynchronously.
327         * WebView/WebImmediateActionController.mm:
328         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
329
330 2015-01-16  Daniel Bates  <dabates@apple.com>
331
332         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
333         (https://bugs.webkit.org/show_bug.cgi?id=140360)
334
335         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
336
337         * Misc/WebDownload.h:
338
339 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
340
341         Remove ENABLE(SQL_DATABASE) guards
342         https://bugs.webkit.org/show_bug.cgi?id=140434
343
344         Reviewed by Darin Adler.
345
346         * Configurations/FeatureDefines.xcconfig:
347         * Storage/WebDatabaseManager.mm:
348         (databasesDirectoryPath):
349         * Storage/WebDatabaseManagerClient.h:
350         * Storage/WebDatabaseManagerClient.mm:
351         * Storage/WebDatabaseManagerInternal.h:
352         * Storage/WebDatabaseManagerPrivate.h:
353         * Storage/WebDatabaseQuotaManager.mm:
354         (-[WebDatabaseQuotaManager usage]):
355         (-[WebDatabaseQuotaManager quota]):
356         (-[WebDatabaseQuotaManager setQuota:]):
357         * WebCoreSupport/WebChromeClient.h:
358         * WebCoreSupport/WebChromeClient.mm:
359         * WebCoreSupport/WebSecurityOrigin.mm:
360         (-[WebSecurityOrigin usage]):
361         (-[WebSecurityOrigin quota]):
362         (-[WebSecurityOrigin setQuota:]):
363         * WebView/WebFrame.mm:
364         (-[WebFrame _cacheabilityDictionary]):
365         * WebView/WebView.mm:
366         (-[WebView _commonInitializationWithFrameName:groupName:]):
367         (-[WebView _preferencesChanged:]):
368
369 2015-01-14  Chris Dumez  <cdumez@apple.com>
370
371         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
372         https://bugs.webkit.org/show_bug.cgi?id=140347
373
374         Reviewed by Darin Adler.
375
376         Call FontDescription::setIsItalic() instead of setItalic() as the
377         call site passes a boolean.
378
379         * WebView/WebHTMLView.mm:
380         (fontNameForDescription):
381
382 2015-01-13  Anders Carlsson  <andersca@apple.com>
383
384         Temporarily reintroduce the informal delegate protocols
385         https://bugs.webkit.org/show_bug.cgi?id=140416
386
387         Reviewed by Dan Bernstein.
388
389         * WebView/WebEditingDelegate.h:
390         * WebView/WebFrameLoadDelegate.h:
391         * WebView/WebPolicyDelegate.h:
392         * WebView/WebResourceLoadDelegate.h:
393         * WebView/WebUIDelegate.h:
394
395 2015-01-13  Beth Dakin  <bdakin@apple.com>
396
397         Should disable immediate actions for iTunes
398         https://bugs.webkit.org/show_bug.cgi?id=140405
399         -and corresponding-
400         rdar://problem/19461358
401
402         Reviewed by Tim Horton.
403
404         * WebView/WebImmediateActionController.mm:
405         (-[WebImmediateActionController _updateImmediateActionItem]):
406
407 2015-01-11  Sam Weinig  <sam@webkit.org>
408
409         Remove support for SharedWorkers
410         https://bugs.webkit.org/show_bug.cgi?id=140344
411
412         Reviewed by Anders Carlsson.
413
414         * Configurations/FeatureDefines.xcconfig:
415         * WebCoreSupport/WebPlatformStrategies.h:
416         * WebCoreSupport/WebPlatformStrategies.mm:
417         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
418
419 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
420
421         Get rid of unnecessary reimplementations of CGFloor/Ceiling
422         https://bugs.webkit.org/show_bug.cgi?id=140375
423
424         Reviewed by Simon Fraser.
425
426         * Misc/WebKitNSStringExtras.mm:
427         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
428         (webkit_CGCeiling): Deleted.
429         Delete unnecessary code, use the real CGFloor/Ceiling instead.
430
431 2015-01-12  Anders Carlsson  <andersca@apple.com>
432
433         Make delegates conform to formal delegate protocols
434         https://bugs.webkit.org/show_bug.cgi?id=140370
435
436         Reviewed by Dan Bernstein.
437
438         * DefaultDelegates/WebDefaultPolicyDelegate.h:
439         * WebCoreSupport/WebInspectorClient.mm:
440         Add protocols to the interface declarations.
441
442         * WebView/WebActionMenuController.mm:
443         (-[WebActionMenuController prepareForMenu:withEvent:]):
444         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
445         * WebView/WebImmediateActionController.mm:
446         (-[WebImmediateActionController _updateImmediateActionItem]):
447         (-[WebImmediateActionController _menuItemForDataDetectedText]):
448         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
449
450 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
451
452         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
453         https://bugs.webkit.org/show_bug.cgi?id=136769
454
455         Reviewed by Antti Koivisto.
456
457         * Configurations/FeatureDefines.xcconfig:
458
459 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
460
461         Multi-rect TextIndicators are vertically flipped in WebKit1
462         https://bugs.webkit.org/show_bug.cgi?id=140350
463         <rdar://problem/19441243>
464
465         Reviewed by Beth Dakin.
466
467         * WebView/WebView.mm:
468         (-[WebView _setTextIndicator:fadeOut:]):
469         Convert the textBoundingRect from root view to screen coordinates.
470
471 2015-01-12  Anders Carlsson  <andersca@apple.com>
472
473         Make WebResourceDelegate a formal protocol as well
474         https://bugs.webkit.org/show_bug.cgi?id=140364
475
476         Reviewed by Dan Bernstein.
477
478         * WebView/WebResourceLoadDelegate.h:
479
480 2015-01-12  Anders Carlsson  <andersca@apple.com>
481
482         Delegates should be formal protocols
483         https://bugs.webkit.org/show_bug.cgi?id=140360
484         rdar://problem/17380856
485
486         Reviewed by Dan Bernstein.
487
488         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
489
490         * DefaultDelegates/WebDefaultUIDelegate.h:
491         * Misc/WebDownload.h:
492         * WebView/WebEditingDelegate.h:
493         * WebView/WebFrameLoadDelegate.h:
494         * WebView/WebPolicyDelegate.h:
495         * WebView/WebUIDelegate.h:
496
497 2015-01-09  Anders Carlsson  <andersca@apple.com>
498
499         Get rid of the database strategy
500         https://bugs.webkit.org/show_bug.cgi?id=140322
501
502         Reviewed by Sam Weinig.
503
504         * WebCoreSupport/WebPlatformStrategies.h:
505         * WebCoreSupport/WebPlatformStrategies.mm:
506         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
507
508 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
509
510         Can't use DataDetectors after immediate action preparation
511         https://bugs.webkit.org/show_bug.cgi?id=140263
512         <rdar://problem/19412705>
513
514         Reviewed by Beth Dakin.
515
516         * WebView/WebImmediateActionController.mm:
517         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
518         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
519         To match WebKit2, only call shouldUseActions if the animation is actually
520         going to begin, not when preparing for it. This way, we're guaranteed
521         to get a didCancel or didComplete.
522
523 2015-01-08  Dean Jackson  <dino@apple.com>
524
525         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
526         https://bugs.webkit.org/show_bug.cgi?id=140232
527         <rdar://problem/19371010>
528
529         Reviewed by Anders Carlsson.
530
531         Remove the applicationChromeMode setting, but leave stubs in to make
532         sure existing binaries don't break.
533
534         * WebCoreSupport/WebInspectorClient.mm:
535         (-[WebInspectorWindowController init]):
536         * WebView/WebPreferenceKeysPrivate.h:
537         * WebView/WebPreferences.mm:
538         (+[WebPreferences initialize]):
539         (-[WebPreferences applicationChromeModeEnabled]):
540         (-[WebPreferences setApplicationChromeModeEnabled:]):
541         * WebView/WebView.mm:
542         (-[WebView _preferencesChanged:]):
543
544 2015-01-07  Daniel Bates  <dabates@apple.com>
545
546         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
547         https://bugs.webkit.org/show_bug.cgi?id=137371
548
549         Reviewed by David Kilzer.
550
551         Use SPI wrapper headers instead of directly references private SPI headers.
552
553         * Plugins/Hosted/NetscapePluginHostManager.mm:
554
555 2015-01-07  Commit Queue  <commit-queue@webkit.org>
556
557         Unreviewed, rolling out r178068.
558         https://bugs.webkit.org/show_bug.cgi?id=140235
559
560         Breaks the iOS build (Requested by enrica on #webkit).
561
562         Reverted changeset:
563
564         "[iOS] Make WebKit2 build with public iOS SDK and more build
565         fixes for DRT"
566         https://bugs.webkit.org/show_bug.cgi?id=137371
567         http://trac.webkit.org/changeset/178068
568
569 2015-01-07  Daniel Bates  <dabates@apple.com>
570
571         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
572         https://bugs.webkit.org/show_bug.cgi?id=137371
573
574         Reviewed by David Kilzer.
575
576         Use SPI wrapper headers instead of directly references private SPI headers.
577
578         * Plugins/Hosted/NetscapePluginHostManager.mm:
579
580 2015-01-07  Beth Dakin  <bdakin@apple.com>
581
582         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
583         link
584         https://bugs.webkit.org/show_bug.cgi?id=140206
585         -and corresponding-
586         rdar://problem/19300492
587
588         Reviewed by Tim Horton.
589
590         Providing and item frame will ensure that the original link is not obscured.
591         * WebView/WebImmediateActionController.mm:
592         (elementBoundingBoxInWindowCoordinatesFromNode):
593         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
594
595         For now use a max size that is smaller than the WebView, with the screen’s aspect 
596         ratio, and scaled down.
597         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
598
599 2015-01-07  Anders Carlsson  <andersca@apple.com>
600
601         Give simple HTML documents a database provider
602         https://bugs.webkit.org/show_bug.cgi?id=140192
603         rdar://problem/19398825
604
605         Reviewed by Tim Horton.
606
607         * WebView/WebView.mm:
608         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
609
610 2015-01-06  Anders Carlsson  <andersca@apple.com>
611
612         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
613         https://bugs.webkit.org/show_bug.cgi?id=140140
614
615         Reviewed by Andreas Kling.
616
617         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
618         out of WebCore since nobody else is using it.
619
620         * Plugins/WebNetscapePluginView.h:
621         * Plugins/WebNetscapePluginView.mm:
622         (-[WebNetscapePluginView _createPlugin]):
623         (-[WebNetscapePluginView _destroyPlugin]):
624         * Plugins/npapi.mm:
625         (NPN_PluginThreadAsyncCall):
626
627 2015-01-06  Anders Carlsson  <andersca@apple.com>
628
629         Add a WebKit1 database provider
630         https://bugs.webkit.org/show_bug.cgi?id=140126
631
632         Reviewed by Sam Weinig.
633
634         Set the database provider.
635
636         * WebView/WebView.mm:
637         (-[WebView _commonInitializationWithFrameName:groupName:]):
638
639 2015-01-06  Commit Queue  <commit-queue@webkit.org>
640
641         Unreviewed, rolling out r177963.
642         https://bugs.webkit.org/show_bug.cgi?id=140136
643
644         Caused lots of crashes (Requested by smfr on #webkit).
645
646         Reverted changeset:
647
648         "Add a WebKit1 database provider"
649         https://bugs.webkit.org/show_bug.cgi?id=140126
650         http://trac.webkit.org/changeset/177963
651
652 2015-01-06  Anders Carlsson  <andersca@apple.com>
653
654         Add a WebKit1 database provider
655         https://bugs.webkit.org/show_bug.cgi?id=140126
656
657         Reviewed by Sam Weinig.
658
659         Set the database provider.
660
661         * WebView/WebView.mm:
662         (-[WebView _commonInitializationWithFrameName:groupName:]):
663
664 2015-01-01  Jeff Miller  <jeffm@apple.com>
665
666         Update user-visible copyright strings to include 2015
667         https://bugs.webkit.org/show_bug.cgi?id=139880
668
669         Reviewed by Darin Adler.
670
671         * Info.plist:
672
673 2014-12-30  Dan Bernstein  <mitz@apple.com>
674
675         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
676         https://bugs.webkit.org/show_bug.cgi?id=140003
677
678         Reviewed by Darin Adler.
679
680         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
681         that takes their "string" parameter as a "value" "parameter and has an attribute telling
682         the compiler that if the "value" parameter is a format string then the function returns a
683         modified version of it. The result is that if UI_STRING is used as a format string parameter
684         to some function or method, the compiler will check the format specifiers in the string
685         against the other parameters.
686
687 2014-12-29  Dan Bernstein  <mitz@apple.com>
688
689         Fixed the iOS build.
690
691         * Configurations/WebKitLegacy.xcconfig:
692
693 2014-12-29  Anders Carlsson  <andersca@apple.com>
694
695         Get rid of some PageGroup storage functions
696         https://bugs.webkit.org/show_bug.cgi?id=139996
697
698         Reviewed by Sam Weinig.
699
700         Call WebStorageNamespaceProvider directly instead.
701
702         * Storage/WebStorageManager.mm:
703         (-[WebStorageManager syncLocalStorage]):
704         (+[WebStorageManager closeIdleLocalStorageDatabases]):
705         * WebView/WebView.mm:
706         (+[WebView _applicationWillTerminate]):
707
708 2014-12-29  Anders Carlsson  <andersca@apple.com>
709
710         Move storage code from WebCore to WebKit
711         https://bugs.webkit.org/show_bug.cgi?id=139558
712
713         Reviewed by Darin Adler.
714
715         * Storage/WebStorageManager.mm:
716         * Storage/WebStorageTrackerClient.h:
717         * WebView/WebView.mm:
718
719 2014-12-26  Dan Bernstein  <mitz@apple.com>
720
721         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
722         https://bugs.webkit.org/show_bug.cgi?id=139950
723
724         Reviewed by David Kilzer.
725
726         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
727         in a manner that works with Xcode 5.1.1.
728
729 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
730
731         Install a TextIndicator for link immediate actions
732         https://bugs.webkit.org/show_bug.cgi?id=139897
733         <rdar://problem/19333076>
734
735         Reviewed by Anders Carlsson.
736
737         * WebView/WebImmediateActionController.h:
738         * WebView/WebImmediateActionController.mm:
739         (-[WebImmediateActionController _clearImmediateActionState]):
740         Tear down the TextIndicator, just like WebKit2.
741
742         (-[WebImmediateActionController _defaultAnimationController]):
743         Install a TextIndicator for links.
744
745         (-[WebImmediateActionController menuItemDidClose:]):
746         Tear down the TextIndicator when the QL preview closes.
747
748         (-[WebImmediateActionController _menuItemForDataDetectedText]):
749         Directly install and uninstall the TextIndicator for DataDetectors.
750
751         (-[WebImmediateActionController _showTextIndicator]): Deleted.
752         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
753         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
754
755 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
756
757         [iOS] add optimized fullscreen API
758         https://bugs.webkit.org/show_bug.cgi?id=139833
759         <rdar://problem/18844486>
760
761         Reviewed by Simon Fraser.
762
763         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
764
765 2014-12-20  David Kilzer  <ddkilzer@apple.com>
766
767         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
768         <http://webkit.org/b/139463>
769
770         Reviewed by Mark Rowe.
771
772         * Configurations/Base.xcconfig:
773         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
774           on OS X.
775         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
776         * Configurations/DebugRelease.xcconfig:
777         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
778         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
779         * Configurations/Version.xcconfig:
780         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
781         * Configurations/WebKitLegacy.xcconfig:
782         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
783           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
784           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
785           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
786           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
787           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
788           WEBCORE_PRIVATE_HEADERS_DIR_Production and
789           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
790           based on SDK.
791         - Fix PRODUCTION_ROOT to actually be set properly.
792         - Simplify EXPORTED_SYMBOLS_FILE_i386.
793
794         * migrate-headers.sh:
795         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
796         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
797           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
798           WebKitLegacy.xcconfig.
799
800 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
801
802         Fix pink background on CoreAnimation plug-ins in WebKit1
803         https://bugs.webkit.org/show_bug.cgi?id=139845
804         rdar://problem/19313075
805
806         Reviewed by Tim Horton.
807         
808         r154078 left in some debugging code that set a pink background on plug-in hosting
809         layers. Remove it.
810
811         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
812         (-[WebHostedNetscapePluginView createPluginLayer]):
813
814 2014-12-19  Andreas Kling  <akling@apple.com>
815
816         Ref-ify TextIterator API.
817         <https://webkit.org/b/139823>
818
819         Reviewed by Antti Koivisto.
820
821         * WebView/WebTextIterator.mm:
822         (-[WebTextIterator currentRange]):
823
824 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
825
826         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
827         https://bugs.webkit.org/show_bug.cgi?id=139797
828
829         Reviewed by Mark Lam.
830
831         * WebView/WebScriptDebugger.h:
832         * WebView/WebScriptDebugger.mm:
833         (WebScriptDebugger::handlePause):
834         Standardize on passing JSGlobalObject parameter first.
835
836 2014-12-19  Commit Queue  <commit-queue@webkit.org>
837
838         Unreviewed, rolling out r177574.
839         https://bugs.webkit.org/show_bug.cgi?id=139821
840
841         "Broke Production builds by installing
842         libWebCoreTestSupport.dylib in the wrong directory" (Requested
843         by ddkilzer on #webkit).
844
845         Reverted changeset:
846
847         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
848         WebInspectorUI, WebKit, WebKit2"
849         https://bugs.webkit.org/show_bug.cgi?id=139463
850         http://trac.webkit.org/changeset/177574
851
852 2014-12-19  David Kilzer  <ddkilzer@apple.com>
853
854         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
855         <http://webkit.org/b/139463>
856
857         Reviewed by Mark Rowe.
858
859         * Configurations/Base.xcconfig:
860         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
861           on OS X.
862         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
863         * Configurations/DebugRelease.xcconfig:
864         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
865         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
866         * Configurations/Version.xcconfig:
867         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
868         * Configurations/WebKitLegacy.xcconfig:
869         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
870           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
871           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
872           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
873           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
874           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
875           WEBCORE_PRIVATE_HEADERS_DIR_Production and
876           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
877           based on SDK.
878         - Fix PRODUCTION_ROOT to actually be set properly.
879         - Simplify EXPORTED_SYMBOLS_FILE_i386.
880
881         * migrate-headers.sh:
882         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
883         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
884           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
885           WebKitLegacy.xcconfig.
886
887 2014-12-18  Andreas Kling  <akling@apple.com>
888
889         Ref-ify various Document-related things.
890         <https://webkit.org/b/139796>
891
892         Reviewed by Anders Carlsson.
893
894         * WebView/WebFrame.mm:
895         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
896
897 2014-12-18  Beth Dakin  <bdakin@apple.com>
898
899         Need to re-enable action menus
900         https://bugs.webkit.org/show_bug.cgi?id=139795
901         -and corresponding-
902         rdar://problem/19299367
903
904         Reviewed by Tim Horton.
905
906         Re-enable the menus by un-commenting the code to create the menu and controller.
907         * WebView/WebView.mm:
908         (-[WebView _commonInitializationWithFrameName:groupName:]):
909
910 2014-12-16  Sam Weinig  <sam@webkit.org>
911
912         Unify the Mac and iOS implementations of FontPlatformData a bit
913         https://bugs.webkit.org/show_bug.cgi?id=139721
914
915         Reviewed by Anders Carlsson.
916
917         * WebView/WebHTMLView.mm:
918         (fontNameForDescription):
919         Update for new function name.
920
921 2014-12-18  Antti Koivisto  <antti@apple.com>
922
923         Remove alwaysUseBaselineOfPrimaryFont setting
924         https://bugs.webkit.org/show_bug.cgi?id=139770
925
926         Reviewed by Anders Carlsson.
927
928         * WebView/WebPreferenceKeysPrivate.h:
929         * WebView/WebPreferences.mm:
930         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
931         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
932         * WebView/WebPreferencesPrivate.h:
933         * WebView/WebView.mm:
934         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
935         (-[WebView _preferencesChanged:]):
936
937 2014-12-17  Andreas Kling  <akling@apple.com>
938
939         Ref-ify Range::create().
940         <https://webkit.org/b/139755>
941
942         Reviewed by Anders Carlsson.
943
944         * WebView/WebHTMLRepresentation.mm:
945         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
946         * WebView/WebHTMLView.mm:
947         (-[WebHTMLView attributedString]):
948
949 2014-12-17  Anders Carlsson  <andersca@apple.com>
950
951         Unify -[WebResource description]
952         https://bugs.webkit.org/show_bug.cgi?id=139762
953
954         Reviewed by Dan Bernstein.
955
956         * WebView/WebResource.mm:
957         (-[WebResource description]):
958
959 2014-12-17  Anders Carlsson  <andersca@apple.com>
960
961         Get rid of an ugly #define hack in WebFrameLoaderClient
962         https://bugs.webkit.org/show_bug.cgi?id=139761
963
964         Reviewed by Dan Bernstein.
965
966         Also replace @private with @package in all public headers, for consistency.
967
968         * History/WebBackForwardList.h:
969         * History/WebHistory.h:
970         * Misc/WebDownload.h:
971         * WebCoreSupport/WebFrameLoaderClient.mm:
972         * WebView/WebArchive.h:
973         * WebView/WebDataSource.h:
974         * WebView/WebFrame.h:
975         * WebView/WebFrameView.h:
976         * WebView/WebPreferences.h:
977         * WebView/WebResource.h:
978
979 2014-12-17  Dan Bernstein  <mitz@apple.com>
980
981         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
982         https://bugs.webkit.org/show_bug.cgi?id=139760
983
984         Reviewed by Anders Carlsson.
985
986         * Configurations/WebKitLegacy.xcconfig:
987
988 2014-12-17  Andreas Kling  <akling@apple.com>
989
990         Purge PassRefPtr from Frame.
991         <https://webkit.org/b/139731>
992
993         Reviewed by Anders Carlsson.
994
995         * WebCoreSupport/WebFrameLoaderClient.mm:
996         (WebFrameLoaderClient::transitionToCommittedForNewPage):
997         * WebView/WebFrame.mm:
998         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
999         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
1000         * WebView/WebFrameInternal.h:
1001
1002 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
1003
1004         Implement and adopt two new TextIndicator presentation animations
1005         https://bugs.webkit.org/show_bug.cgi?id=139715
1006         <rdar://problem/19237945>
1007
1008         Reviewed by Anders Carlsson.
1009
1010         * WebView/WebActionMenuController.mm:
1011         (-[WebActionMenuController _showTextIndicator]):
1012         * WebView/WebHTMLView.mm:
1013         (-[WebHTMLView quickLookWithEvent:]):
1014         Remove the completionHandler from text indicator presentation.
1015
1016         * WebView/WebImmediateActionController.mm:
1017         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1018         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
1019         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1020         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1021         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1022         (-[WebImmediateActionController _animationControllerForText]):
1023         (-[WebImmediateActionController _showTextIndicator]):
1024         Forward immediate action gesture recognizer animation progress
1025         to TextIndicator. Force us to keep the selection when immediate
1026         action popovers steal first responder status from the WebView.
1027         If the Lookup range is equal to the selection range, use a Crossfade
1028         animation; otherwise, use a FadeIn animation.
1029
1030         * WebView/WebView.mm:
1031         (-[WebView _setMaintainsInactiveSelection:]):
1032         (-[WebView maintainsInactiveSelection]):
1033         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1034         (-[WebView _setTextIndicator:fadeOut:]):
1035         (-[WebView _clearTextIndicator]):
1036         (-[WebView _setTextIndicatorAnimationProgress:]):
1037         (-[WebView _showDictionaryLookupPopup:]):
1038         (-[WebView _dictionaryLookupPopoverWillClose:]):
1039         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1040         Remove the completionHandler from text indicator presentation.
1041         Add a _setMaintainsInactiveSelection, which allows WebKit internals
1042         to change the return value of -maintainsInactiveSelection, allowing
1043         us to keep the selection alive when the WebView loses first responder status.
1044
1045         * WebView/WebViewData.h:
1046         * WebView/WebViewInternal.h:
1047
1048 2014-12-16  Andreas Kling  <akling@apple.com>
1049
1050         Use Ref for SecurityOrigin.
1051         <https://webkit.org/b/139710>
1052
1053         Reviewed by Anders Carlsson.
1054
1055         * Storage/WebStorageTrackerClient.mm:
1056         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1057         * WebView/WebView.mm:
1058         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
1059         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
1060
1061 2014-12-16  Beth Dakin  <bdakin@apple.com>
1062
1063         Crash getting default animation controller for some text
1064         https://bugs.webkit.org/show_bug.cgi?id=139712
1065         -and corresponding-
1066         rdar://problem/19271707
1067
1068         Reviewed by Tim Horton.
1069
1070         Must null-check the range.
1071         * WebView/WebImmediateActionController.mm:
1072         (-[WebImmediateActionController _animationControllerForText]):
1073
1074 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
1075
1076         Immediate action popovers can get stuck open
1077         https://bugs.webkit.org/show_bug.cgi?id=139709
1078         <rdar://problem/19270279>
1079
1080         Reviewed by Beth Dakin.
1081
1082         * WebView/WebImmediateActionController.mm:
1083         (-[WebImmediateActionController _clearImmediateActionState]):
1084         Don't clear the animation controller; it breaks things and was unnecessary.
1085
1086 2014-12-16  Tim Horton  <timothy_horton@apple.com>
1087
1088         Disable TextIndication for Lookup immediate actions
1089         https://bugs.webkit.org/show_bug.cgi?id=139684
1090
1091         Reviewed by Anders Carlsson.
1092
1093         * WebView/WebView.mm:
1094         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1095
1096 2014-12-15  Beth Dakin  <bdakin@apple.com>
1097
1098         Build fix.
1099
1100         * WebView/WebImmediateActionController.mm:
1101
1102 2014-12-15  Beth Dakin  <bdakin@apple.com>
1103
1104         Speculative build fix.
1105
1106         * WebView/WebView.mm:
1107         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1108         * WebView/WebViewInternal.h:
1109
1110 2014-12-15  Beth Dakin  <bdakin@apple.com>
1111
1112         Make lookup an immediate action instead of an action menu item
1113         https://bugs.webkit.org/show_bug.cgi?id=139661
1114         -and corresponding-
1115         rdar://problem/19198414
1116
1117         Reviewed by Tim Horton.
1118
1119         Remove the lookup menu items and non-unused static function associated with 
1120         lookup.
1121         * WebView/WebActionMenuController.mm:
1122         (-[WebActionMenuController _defaultMenuItemsForText]):
1123         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
1124         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
1125         (-[WebActionMenuController _createActionMenuItemForTag:]):
1126         (-[WebActionMenuController _lookupText:]): Deleted.
1127         (performDictionaryLookupForSelection): Deleted.
1128         (performDictionaryLookupForRange): Deleted.
1129
1130         Set the defaultAnimationController to the lookup-provided animation controller 
1131         when appropriate.
1132         * WebView/WebImmediateActionController.mm:
1133         (-[WebImmediateActionController _defaultAnimationController]):
1134         (dictionaryPopupInfoForRange):
1135         (-[WebImmediateActionController _animationControllerForText]):
1136
1137         New type.
1138         * WebView/WebUIDelegatePrivate.h:
1139
1140         New function to get the lookup animation controller.
1141         * WebView/WebView.mm:
1142         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1143         * WebView/WebViewInternal.h:
1144
1145 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1146
1147         Implement Data Detectors immediate actions for Legacy WebKit
1148         https://bugs.webkit.org/show_bug.cgi?id=139619
1149         <rdar://problem/19198539>
1150
1151         Reviewed by Beth Dakin.
1152
1153         * WebView/WebImmediateActionController.mm:
1154         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1155         Note that this action context is only for immediate actions.
1156
1157 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1158
1159         Addressing post-review comments in r177035
1160         https://bugs.webkit.org/show_bug.cgi?id=139557
1161
1162         Reviewed by Darin Adler.
1163
1164         * WebView/WebActionMenuController.mm:
1165         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
1166
1167 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1168
1169         Implement Data Detectors immediate actions for Legacy WebKit
1170         https://bugs.webkit.org/show_bug.cgi?id=139619
1171         <rdar://problem/19198539>
1172
1173         Reviewed by Eric Carlson.
1174
1175         * WebView/WebHTMLView.mm:
1176         (-[WebHTMLView mouseDown:mouseDown:]):
1177         Send mouseDown along to the WebImmediateActionController too.
1178
1179         * WebView/WebImmediateActionController.h:
1180         * WebView/WebImmediateActionController.mm:
1181         (-[WebImmediateActionController webViewClosed]):
1182         (-[WebImmediateActionController webView:willHandleMouseDown:]):
1183         (-[WebImmediateActionController _cancelImmediateAction]):
1184         (-[WebImmediateActionController _clearImmediateActionState]):
1185         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1186         (-[WebImmediateActionController _defaultAnimationController]):
1187         (-[WebImmediateActionController _updateImmediateActionItem]):
1188         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1189         (-[WebImmediateActionController _showTextIndicator]):
1190         (-[WebImmediateActionController _hideTextIndicator]):
1191         Copy most of the DataDetectors implementation into WebImmediateActionController.
1192
1193         * WebView/WebUIDelegatePrivate.h:
1194         Add a new type.
1195
1196         * WebView/WebView.mm:
1197         (-[WebView _commonInitializationWithFrameName:groupName:]):
1198         Temporarily disable action menus.
1199
1200         (-[WebView _immediateActionController]):
1201         * WebView/WebViewInternal.h:
1202
1203 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1204
1205         Delete Notation because we don't use it
1206         https://bugs.webkit.org/show_bug.cgi?id=139171
1207
1208         Reviewed by Kent Tamura.
1209
1210         * MigrateHeaders.make:
1211
1212 2014-12-14  Andreas Kling  <akling@apple.com>
1213
1214         Replace PassRef with Ref/Ref&& across the board.
1215         <https://webkit.org/b/139587>
1216
1217         Reviewed by Darin Adler.
1218
1219         * WebCoreSupport/WebEditorClient.mm:
1220         (WebEditorClient::shouldApplyStyle):
1221         * WebCoreSupport/WebVisitedLinkStore.h:
1222         * WebCoreSupport/WebVisitedLinkStore.mm:
1223         (WebVisitedLinkStore::create):
1224
1225 2014-12-11  Dan Bernstein  <mitz@apple.com>
1226
1227         Fix a leak introduced in r177199.
1228
1229         Reviewed by Anders Carlsson.
1230
1231         * WebView/WebImmediateActionController.mm:
1232         (-[WebImmediateActionController _updateImmediateActionItem]):
1233
1234 2014-12-11  Beth Dakin  <bdakin@apple.com>
1235
1236         WK1: Need new SPI for Webkit clients to override default immediate action
1237         https://bugs.webkit.org/show_bug.cgi?id=139568
1238         -and corresponding-
1239         rdar://problem/19225448
1240
1241         Reviewed by Dan Bernstein.
1242
1243         Call SPI giving clients a chance to override the default behavior.
1244         * WebView/WebImmediateActionController.mm:
1245         (-[WebImmediateActionController _updateImmediateActionItem]):
1246
1247         New SPI.
1248         * WebView/WebUIDelegatePrivate.h:
1249
1250 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1251
1252         Move the preview popover to WebImmediateActionController
1253         https://bugs.webkit.org/show_bug.cgi?id=139563
1254         <rdar://problem/19208291>
1255
1256         Reviewed by Beth Dakin.
1257
1258         * WebView/WebActionMenuController.mm:
1259         (-[WebActionMenuController _defaultMenuItemsForLink]):
1260         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
1261         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
1262         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
1263         * WebView/WebImmediateActionController.h:
1264         * WebView/WebImmediateActionController.mm:
1265         (-[WebImmediateActionController webViewClosed]):
1266         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1267         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1268         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1269         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1270         (-[WebImmediateActionController _updateImmediateActionItem]):
1271         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
1272         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
1273         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
1274         Move page preview popover related code to WebImmediateActionController.
1275
1276         * WebView/WebUIDelegatePrivate.h:
1277         Add a link preview type.
1278
1279         * WebView/WebView.mm:
1280         (-[WebView _commonInitializationWithFrameName:groupName:]):
1281         Pass the gesture recognizer to the WebImmediateActionController.
1282
1283 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1284
1285         Fix the build.
1286
1287         * WebView/WebImmediateActionController.h:
1288         * WebView/WebImmediateActionController.mm:
1289
1290 2014-12-11  Anders Carlsson  <andersca@apple.com>
1291
1292         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
1293         https://bugs.webkit.org/show_bug.cgi?id=139547
1294
1295         Reviewed by Sam Weinig.
1296
1297         * WebView/WebView.mm:
1298         (+[WebView _handleMemoryWarning]):
1299
1300 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
1301
1302         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
1303         https://bugs.webkit.org/show_bug.cgi?id=139504
1304         rdar://problem/19034674
1305
1306         Reviewed by Enrica Casucci.
1307
1308         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
1309
1310         * WebCoreSupport/WebEditorClient.h:
1311         * WebCoreSupport/WebEditorClient.mm:
1312         (WebEditorClient::discardedComposition):
1313
1314 2014-12-10  Anders Carlsson  <andersca@apple.com>
1315
1316         Get rid of the storage strategy
1317         https://bugs.webkit.org/show_bug.cgi?id=139519
1318
1319         Reviewed by Antti Koivisto.
1320
1321         * WebCoreSupport/WebPlatformStrategies.h:
1322         * WebCoreSupport/WebPlatformStrategies.mm:
1323         (WebPlatformStrategies::createStorageStrategy): Deleted.
1324
1325 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1326
1327         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
1328         https://bugs.webkit.org/show_bug.cgi?id=139529
1329         <rdar://problem/19213620>
1330
1331         Reviewed by Beth Dakin.
1332
1333         * WebView/WebActionMenuController.mm:
1334         (-[WebActionMenuController _copySelection:]):
1335         (-[WebActionMenuController _paste:]):
1336         Use the copy: and paste: methods on WebView so that we traverse subviews
1337         when trying to respond, otherwise these actions don't work in subframes.
1338
1339 2014-12-10  Beth Dakin  <bdakin@apple.com>
1340
1341         WK1: Add initial support for immediate actions
1342         https://bugs.webkit.org/show_bug.cgi?id=139522
1343
1344         Reviewed by Dan Bernstein.
1345
1346         This basic implementation of the controller will use the delegate methods to 
1347         perform and cache a HitTest when relevant. Future patches will patch 
1348         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
1349         immediate action that should be taken.
1350         * WebView/WebImmediateActionController.h: Added.
1351         * WebView/WebImmediateActionController.mm: Added.
1352         (-[WebImmediateActionController webViewClosed]):
1353         (-[WebImmediateActionController _clearImmediateActionState]):
1354         (-[WebImmediateActionController performHitTestAtPoint:]):
1355         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1356         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1357         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1358         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1359         (-[WebImmediateActionController _updateImmediateActionItem]):
1360
1361         New enum for immediate action types.
1362         * WebView/WebUIDelegatePrivate.h:
1363
1364         Create an NSImmediateActionGestureRecognizer if possible and a controller.
1365         * WebView/WebView.mm:
1366         (-[WebView _commonInitializationWithFrameName:groupName:]):
1367         (-[WebView _close]):
1368         * WebView/WebViewData.h:
1369         * WebView/WebViewData.mm:
1370         (-[WebViewPrivate dealloc]):
1371
1372 2014-12-08  Anders Carlsson  <andersca@apple.com>
1373
1374         Use the new storage namespace provider in WebKit1
1375         https://bugs.webkit.org/show_bug.cgi?id=139425
1376
1377         Reviewed by Tim Horton.
1378
1379         * WebView/WebView.mm:
1380         (-[WebView _commonInitializationWithFrameName:groupName:]):
1381         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1382         Set the storage namespace provider from the web page group.
1383
1384 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1385
1386         Should have copy and paste items in all text menus
1387         https://bugs.webkit.org/show_bug.cgi?id=139510
1388         <rdar://problem/19198388>
1389
1390         Reviewed by Beth Dakin.
1391
1392         * WebView/WebActionMenuController.mm:
1393         (-[WebActionMenuController _defaultMenuItemsForText]):
1394         Add a disabled paste menu item into the read-only text menu.
1395
1396         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1397         Add a disabled copy menu item into the editable whitespace text menu.
1398
1399 2014-12-10  Anders Carlsson  <andersca@apple.com>
1400
1401         Add WebStorageNamespaceProvider::closeLocalStorage
1402         https://bugs.webkit.org/show_bug.cgi?id=139502
1403
1404         Reviewed by Tim Horton.
1405
1406         * WebView/WebView.mm:
1407         (+[WebView _applicationWillTerminate]):
1408         Call WebStorageNamespaceProvider::closeLocalStorage.
1409
1410 2014-12-09  Commit Queue  <commit-queue@webkit.org>
1411
1412         Unreviewed, rolling out r177037.
1413         https://bugs.webkit.org/show_bug.cgi?id=139464
1414
1415         broke ~50 API tests (Requested by thorton on #webkit).
1416
1417         Reverted changeset:
1418
1419         "Use the new storage namespace provider in WebKit1"
1420         https://bugs.webkit.org/show_bug.cgi?id=139425
1421         http://trac.webkit.org/changeset/177037
1422
1423 2014-12-08  Anders Carlsson  <andersca@apple.com>
1424
1425         Use the new storage namespace provider in WebKit1
1426         https://bugs.webkit.org/show_bug.cgi?id=139425
1427
1428         Reviewed by Tim Horton.
1429
1430         * WebView/WebView.mm:
1431         (-[WebView _commonInitializationWithFrameName:groupName:]):
1432         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1433         Set the storage namespace provider from the web page group.
1434
1435 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
1436
1437         Delete Node::boundingBox()
1438         https://bugs.webkit.org/show_bug.cgi?id=139333
1439
1440         Reviewed by Zalan Bujtas.
1441
1442         * WebView/WebActionMenuController.mm:
1443         (elementBoundingBoxInWindowCoordinatesFromNode): Use
1444         RenderObject::absoluteBoundingBoxRect().
1445
1446 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
1447
1448         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
1449         https://bugs.webkit.org/show_bug.cgi?id=138843
1450         rdar://problem/18793695
1451
1452         Reviewed by Dan Bernstein.
1453
1454         * Panels/WebAuthenticationPanel.m:
1455         (-[WebAuthenticationPanel cancel:]):
1456         (-[WebAuthenticationPanel logIn:]):
1457         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
1458         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
1459         that only when using an old NSWindow API.
1460
1461 2014-12-08  Beth Dakin  <bdakin@apple.com>
1462
1463         Copy and Lookup menu items should be disabled when something is not copyable
1464         https://bugs.webkit.org/show_bug.cgi?id=139423
1465
1466         Reviewed by Tim Horton.
1467
1468         Disable both lookup and copy when a HitTestResult does not allow copy.
1469         * WebView/WebActionMenuController.mm:
1470
1471         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
1472         disable state otherwise.
1473         * WebView/WebView.mm:
1474         (-[WebView _commonInitializationWithFrameName:groupName:]):
1475
1476 2014-12-08  Anders Carlsson  <andersca@apple.com>
1477
1478         Adding user content to a group should force that group to be created
1479         https://bugs.webkit.org/show_bug.cgi?id=139421
1480         rdar://problem/19180108
1481
1482         Reviewed by Sam Weinig.
1483
1484         * WebCoreSupport/WebViewGroup.h:
1485         Store the local storage database path in the group.
1486
1487         * WebCoreSupport/WebViewGroup.mm:
1488         (WebViewGroup::getOrCreate):
1489         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
1490         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
1491
1492         (WebViewGroup::WebViewGroup):
1493         Initialize the new member variable.
1494
1495         (WebViewGroup::storageNamespaceProvider):
1496         Create the namespace provider lazily.
1497
1498         * WebView/WebView.mm:
1499         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1500         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1501         Use getOrCreate instead of get.
1502
1503 2014-12-08  Anders Carlsson  <andersca@apple.com>
1504
1505         WebStorageNamespaceProvider should know about its local storage database path
1506         https://bugs.webkit.org/show_bug.cgi?id=139413
1507
1508         Reviewed by Andreas Kling.
1509
1510         * WebCoreSupport/WebViewGroup.h:
1511         * WebCoreSupport/WebViewGroup.mm:
1512         (WebViewGroup::getOrCreate):
1513         (WebViewGroup::WebViewGroup):
1514         * WebView/WebView.mm:
1515         (-[WebView _commonInitializationWithFrameName:groupName:]):
1516         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1517         (-[WebView setGroupName:]):
1518         (-[WebView groupName]): Deleted.
1519
1520 2014-12-08  Daniel Bates  <dabates@apple.com>
1521
1522         [iOS] Fix the WebKit build with the public SDK
1523
1524         Include header NSURLDownloadSPI.h.
1525
1526         * WebCoreSupport/WebFrameLoaderClient.mm:
1527
1528 2014-12-07  Dan Bernstein  <mitz@apple.com>
1529
1530         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
1531         https://bugs.webkit.org/show_bug.cgi?id=139348
1532
1533         Reviewed by Anders Carlsson.
1534
1535         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
1536         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
1537         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
1538         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
1539         avoiding the ambiguity.
1540
1541         * WebView/WebActionMenuController.mm:
1542         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1543
1544 2014-12-06  Anders Carlsson  <andersca@apple.com>
1545
1546         Add a stubbed out version of WebStorageNamespaceProvider
1547         https://bugs.webkit.org/show_bug.cgi?id=139213
1548
1549         Reviewed by Sam Weinig.
1550
1551         * WebCoreSupport/WebViewGroup.h:
1552         (WebViewGroup::storageNamespaceProvider):
1553         * WebCoreSupport/WebViewGroup.mm:
1554         (WebViewGroup::getOrCreate):
1555         (WebViewGroup::WebViewGroup):
1556         Give WebViewGroup a storage namespace provider.
1557
1558 2014-12-06  Anders Carlsson  <andersca@apple.com>
1559
1560         Fix build with newer versions of clang.
1561         rdar://problem/18978687
1562
1563         Add missing overrides and missing casts.
1564
1565         * Storage/WebDatabaseManagerClient.h:
1566         * Storage/WebStorageTrackerClient.h:
1567         * WebCoreSupport/WebChromeClient.h:
1568         * WebCoreSupport/WebFrameLoaderClient.h:
1569         * WebCoreSupport/WebInspectorClient.h:
1570         * WebView/WebDataSource.mm:
1571         (-[WebDataSource _makeRepresentation]):
1572         * WebView/WebFrameView.mm:
1573         (-[WebFrameView _makeDocumentViewForDataSource:]):
1574
1575 2014-12-05  Tim Horton  <timothy_horton@apple.com>
1576
1577         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
1578         https://bugs.webkit.org/show_bug.cgi?id=139306
1579         <rdar://problem/19157955>
1580
1581         Reviewed by Beth Dakin.
1582
1583         * WebView/WebView.mm:
1584         (-[WebView _commonInitializationWithFrameName:groupName:]):
1585         (-[WebView _initWithFrame:frameName:groupName:]):
1586         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
1587
1588 2014-12-05  David Kilzer  <ddkilzer@apple.com>
1589
1590         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
1591         <http://webkit.org/b/139286>
1592
1593         Reviewed by Daniel Bates.
1594
1595         * Configurations/FeatureDefines.xcconfig: Switch back to using
1596         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
1597
1598 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
1599
1600         Fix the 32-bit build.
1601
1602         * WebView/WebView.mm:
1603         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1604
1605 2014-12-04  Tim Horton  <timothy_horton@apple.com>
1606
1607         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
1608         https://bugs.webkit.org/show_bug.cgi?id=139252
1609         <rdar://problem/19140827>
1610
1611         Reviewed by Anders Carlsson.
1612
1613         * WebView/WebView.mm:
1614         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1615         Adjust to the WebCore changes.
1616
1617 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1618
1619         Implement action menus for tel: URLs
1620         https://bugs.webkit.org/show_bug.cgi?id=139240
1621         <rdar://problem/19115662>
1622
1623         Reviewed by Anders Carlsson.
1624
1625         * WebView/WebActionMenuController.mm:
1626         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1627         Make sure to use the newly created currentActionContext... everywhere.
1628
1629 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1630
1631         Implement action menus for tel: URLs
1632         https://bugs.webkit.org/show_bug.cgi?id=139240
1633         <rdar://problem/19115662>
1634
1635         Reviewed by Anders Carlsson.
1636
1637         * WebView/WebActionMenuController.mm:
1638         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1639         Make sure to use the newly created currentActionContext.
1640
1641 2014-12-03  Beth Dakin  <bdakin@apple.com>
1642
1643         <input> elements get whitespace action menu instead of editable text menu
1644         https://bugs.webkit.org/show_bug.cgi?id=139241
1645         -and corresponding-
1646         rdar://problem/19072083
1647
1648         Reviewed by Sam Weinig.
1649
1650         We should disallow shadow content in the hit test. This is the default and it is 
1651         how context menus behave. We originally wanted to text inside shadow content so 
1652         that we could find the text, but the new function I added to HitTestResult will 
1653         allow that.
1654         * WebView/WebActionMenuController.mm:
1655         (-[WebActionMenuController performHitTestAtPoint:]):
1656
1657         Adjust to the fact that we don’t hit test shadow content any more.
1658         (-[WebActionMenuController focusAndSelectHitTestResult]):
1659
1660         Offer the text menus for text inside form controls.
1661         (-[WebActionMenuController _defaultMenuItems]):
1662
1663 2014-12-03  Tim Horton  <timothy_horton@apple.com>
1664
1665         Implement action menus for tel: URLs
1666         https://bugs.webkit.org/show_bug.cgi?id=139240
1667         <rdar://problem/19115662>
1668
1669         Reviewed by Anders Carlsson.
1670
1671         * WebView/WebActionMenuController.mm:
1672         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1673         Rename this function as it will work for both mailto and tel URLs.
1674         Adjust it to use contextForView:.
1675
1676         (-[WebActionMenuController webView:willHandleMouseDown:]):
1677         (-[WebActionMenuController prepareForMenu:withEvent:]):
1678         (-[WebActionMenuController didCloseMenu:withEvent:]):
1679         (-[WebActionMenuController _defaultMenuItems]):
1680         Don't check the menu type when going to interact with _currentActionContext.
1681         We'll only have a _currentActionContext if we have a data detected item,
1682         and there are multiple menu types that end up using DDActionContext.
1683
1684         * WebView/WebUIDelegatePrivate.h:
1685         Add a new type.
1686
1687 2014-12-03  Anders Carlsson  <andersca@apple.com>
1688
1689         Set a visited link store when creating a simple WebView
1690         https://bugs.webkit.org/show_bug.cgi?id=139234
1691         <rdar://problem/19132978>
1692
1693         Reviewed by Sam Weinig.
1694
1695         * WebView/WebView.mm:
1696         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1697
1698 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1699
1700         Fix the build.
1701
1702         * WebCoreSupport/WebFrameLoaderClient.mm:
1703
1704 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1705
1706         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1707         https://bugs.webkit.org/show_bug.cgi?id=139149
1708
1709         Reviewed by Anders Carlsson.
1710
1711         This changes API behavior. I think that it's OK, because existing behavior made no sense.
1712         We used to delete caches from disk, but they were still active in memory. Now we also
1713         obsolete them in memory, so documents that use a cache still work, but new ones don't
1714         pick one up.
1715
1716         * WebCoreSupport/WebApplicationCache.mm:
1717         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
1718         need to delete in-momry caches too. Keep existing behavior.
1719         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
1720         that properly deletes caches.
1721
1722 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1723
1724         Remove a SnowLeopard-era quirk for QuickLook
1725         https://bugs.webkit.org/show_bug.cgi?id=139208
1726         <rdar://problem/19121822>
1727
1728         Reviewed by Alexey Proskuryakov.
1729
1730         * WebCoreSupport/WebFrameLoaderClient.h:
1731         * WebCoreSupport/WebFrameLoaderClient.mm:
1732
1733 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1734
1735         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
1736         https://bugs.webkit.org/show_bug.cgi?id=139204
1737
1738         Reviewed by Anders Carlsson.
1739
1740         * WebView/WebView.mm:
1741         (-[WebView _commonInitializationWithFrameName:groupName:]):
1742         (-[WebView _showDictionaryLookupPopup:]):
1743         * WebView/WebViewData.h:
1744         Work around this by delaying the softlinking (and setting up the notification
1745         observer) until we actually need it. There's still an underlying bug, but
1746         this will fix the test.
1747
1748 2014-12-02  Beth Dakin  <bdakin@apple.com>
1749
1750         Yet another build fix.
1751
1752         * WebView/WebActionMenuController.mm:
1753         (-[WebActionMenuController _defaultMenuItemsForLink]):
1754
1755 2014-12-02  Beth Dakin  <bdakin@apple.com>
1756
1757         Build fix.
1758
1759         * WebView/WebActionMenuController.mm:
1760         (-[WebActionMenuController _defaultMenuItemsForLink]):
1761
1762 2014-12-02  Beth Dakin  <bdakin@apple.com>
1763
1764         More build fixing.
1765
1766         * WebView/WebActionMenuController.mm:
1767         (-[WebActionMenuController _defaultMenuItemsForLink]):
1768
1769 2014-12-02  Beth Dakin  <bdakin@apple.com>
1770
1771         Should use standardQuickLookMenuItem for apps that don't implement customizations
1772         https://bugs.webkit.org/show_bug.cgi?id=139193
1773         -and corresponding-
1774         rdar://problem/18944696
1775
1776         Reviewed by Anders Carlsson.
1777
1778         Use [NSMenuItem standardQuickLookMenuItem].
1779         * WebView/WebActionMenuController.mm:
1780         (-[WebActionMenuController _defaultMenuItemsForLink]):
1781
1782         Delegate methods to set up the standardQuickLookMenuItem.
1783         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
1784         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
1785         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
1786
1787         Remove all of the old QLPreviewBubble code.
1788         (-[WebActionMenuController _createActionMenuItemForTag:]):
1789         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
1790
1791 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1792
1793         Fix the build.
1794
1795         * WebView/WebViewData.h:
1796
1797 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1798
1799         Implement Lookup transition from selection for Legacy WebKit
1800         https://bugs.webkit.org/show_bug.cgi?id=139180
1801         <rdar://problem/19067172>
1802
1803         Reviewed by Beth Dakin.
1804
1805         * WebView/DictionaryPopupInfo.h: Added.
1806         Split DictionaryPopupInfo out into its own file.
1807
1808         * WebView/WebActionMenuController.mm:
1809         (-[WebActionMenuController _lookupText:]):
1810         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
1811
1812         (performDictionaryLookupForSelection):
1813         (performDictionaryLookupForRange):
1814         Plumb the transition style through these helpers.
1815         Create a TextIndicator from the selection range.
1816
1817         * WebView/WebHTMLView.mm:
1818         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1819         Make use of TextIndicator (and DictionaryPopupInfo, and the new
1820         _showDictionaryLookupPopup on WebView) to add a transition from blue
1821         when performing Lookup from the context menu.
1822
1823         (-[WebHTMLView quickLookWithEvent:]):
1824         Remove our TextIndicator whenever a normal three-finger-tap event
1825         comes through, as it will have its own indication.
1826
1827         * WebView/WebView.mm:
1828         (-[WebView _commonInitializationWithFrameName:groupName:]):
1829         (-[WebView _dictionaryLookupPopoverWillClose:]):
1830         Register for the LUNotificationPopoverWillClose notification and remove
1831         our TextIndicator when it is called, just like in WebKit2.
1832         Deregistration is already handled in _close.
1833
1834         (-[WebView _showDictionaryLookupPopup:]):
1835         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
1836         if the relevant API is available.
1837
1838         * WebView/WebViewInternal.h:
1839
1840 2014-12-02  Anders Carlsson  <andersca@apple.com>
1841
1842         Remove visited link handling from PageGroup
1843         https://bugs.webkit.org/show_bug.cgi?id=139185
1844
1845         Reviewed by Sam Weinig.
1846
1847         * History/WebHistory.mm:
1848         (-[WebHistoryPrivate removeItemForURLString:]):
1849         (-[WebHistoryPrivate removeAllItems]):
1850         (+[WebHistory setOptionalSharedHistory:]):
1851         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1852         (+[WebHistory _removeAllVisitedLinks]):
1853         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
1854         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
1855         * History/WebHistoryInternal.h:
1856         * WebCoreSupport/WebChromeClient.h:
1857         * WebCoreSupport/WebChromeClient.mm:
1858         (WebChromeClient::populateVisitedLinks): Deleted.
1859         * WebView/WebView.mm:
1860         (-[WebView addVisitedLinks:]):
1861         (-[WebView removeVisitedLink:]):
1862
1863 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1864
1865         Try to fix the Mac build.
1866
1867         * WebView/WebView.mm:
1868         (-[WebView _commonInitializationWithFrameName:groupName:]):
1869         (-[WebView _close]):
1870
1871 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1872
1873         Fix the iOS build.
1874
1875         * WebView/WebActionMenuController.h:
1876         * WebView/WebActionMenuController.mm:
1877         * WebView/WebHTMLView.mm:
1878         (-[WebHTMLView scrollWheel:scrollWheel:]):
1879         (-[WebHTMLView mouseDown:mouseDown:]):
1880         * WebView/WebView.mm:
1881         * WebView/WebViewData.h:
1882         * WebView/WebViewData.mm:
1883         (-[WebViewPrivate dealloc]):
1884         * WebView/WebViewInternal.h:
1885
1886 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1887
1888         Implement yellow highlight for WebKit1 data detectors
1889         https://bugs.webkit.org/show_bug.cgi?id=138956
1890         <rdar://problem/18992185>
1891
1892         Reviewed by Beth Dakin.
1893
1894         * WebView/WebActionMenuController.h:
1895         * WebView/WebActionMenuController.mm:
1896         (-[WebActionMenuController webView:willHandleMouseDown:]):
1897         (-[WebActionMenuController webView:didHandleScrollWheel:]):
1898         (-[WebActionMenuController prepareForMenu:withEvent:]):
1899         (-[WebActionMenuController didCloseMenu:withEvent:]):
1900         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1901         (-[WebActionMenuController _showTextIndicator]):
1902         (-[WebActionMenuController _hideTextIndicator]):
1903         (-[WebActionMenuController _dismissActionMenuPopovers]):
1904         Copy the WebKit2 WKActionMenuController TextIndicator implementation
1905         into WebActionMenuController. The only significant difference is
1906         that we build the TextIndicator right at menu construction time
1907         instead of in the Web process.
1908
1909         * WebView/WebHTMLView.mm:
1910         (-[WebHTMLView scrollWheel:]):
1911         Let the WebActionMenuController know that we're handling a scroll.
1912
1913         (-[WebHTMLView mouseDown:]):
1914         Let the WebActionMenuController know that we're handling a mouseDown.
1915
1916         * WebView/WebView.mm:
1917         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1918         (-[WebView _clearTextIndicator]):
1919         (-[WebView _actionMenuController]):
1920         (-[WebView _convertRectFromRootView:]): Deleted.
1921         * WebView/WebViewData.h:
1922         * WebView/WebViewData.mm:
1923         * WebView/WebViewInternal.h:
1924         Keep a TextIndicatorWindow on WebView, just like WKView does.
1925         Expose the WebActionMenuController on WebView (internally).
1926
1927 2014-12-01  Anders Carlsson  <andersca@apple.com>
1928
1929         Remove old site specific quirks code that was added in 2009
1930         https://bugs.webkit.org/show_bug.cgi?id=139141
1931
1932         Reviewed by Antti Koivisto.
1933
1934         * WebCoreSupport/WebFrameNetworkingContext.h:
1935         * WebCoreSupport/WebFrameNetworkingContext.mm:
1936         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
1937
1938 2014-11-30  Anders Carlsson  <andersca@apple.com>
1939
1940         Fix a test failure.
1941
1942         * History/WebHistory.mm:
1943         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1944         Call through to the visited link store.
1945
1946         (+[WebHistory _removeAllVisitedLinks]):
1947         Ditto.
1948
1949         * WebCoreSupport/WebVisitedLinkStore.mm:
1950         (WebVisitedLinkStore::isLinkVisited):
1951         Make sure to populate visited links.
1952
1953 2014-11-30  Anders Carlsson  <andersca@apple.com>
1954
1955         Switch over to the visited link store from the WebViewGroup
1956         https://bugs.webkit.org/show_bug.cgi?id=139112
1957
1958         Reviewed by Sam Weinig.
1959
1960         * WebView/WebView.mm:
1961         (-[WebView _commonInitializationWithFrameName:groupName:]):
1962         (-[WebView setGroupName:]):
1963
1964 2014-11-30  Anders Carlsson  <andersca@apple.com>
1965
1966         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
1967         https://bugs.webkit.org/show_bug.cgi?id=139111
1968
1969         Reviewed by Sam Weinig.
1970
1971         * WebCoreSupport/WebVisitedLinkStore.h:
1972         * WebCoreSupport/WebVisitedLinkStore.mm:
1973         (WebVisitedLinkStore::removeVisitedLink):
1974         * WebView/WebView.mm:
1975         (-[WebView removeVisitedLink:]):
1976
1977 2014-11-29  Anders Carlsson  <andersca@apple.com>
1978
1979         Populate visited links
1980         https://bugs.webkit.org/show_bug.cgi?id=139101
1981
1982         Reviewed by Sam Weinig.
1983
1984         * History/WebHistory.mm:
1985         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
1986         Helper function that adds all visited link to the given store.
1987
1988         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
1989         Call the private method.
1990
1991         * History/WebHistoryInternal.h:
1992         * WebCoreSupport/WebVisitedLinkStore.h:
1993         Add new members.
1994
1995         * WebCoreSupport/WebVisitedLinkStore.mm:
1996         (WebVisitedLinkStore::addVisitedLink):
1997         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
1998
1999         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
2000         Implement this. First try the delegate, then try the shared history.
2001
2002         (WebVisitedLinkStore::addVisitedLinkHash):
2003         Factor code that adds the link to the hash table into a separate function.
2004
2005         * WebView/WebView.mm:
2006         (-[WebView addVisitedLinks:]):
2007         Add the visited links to the store.
2008
2009 2014-11-29  Anders Carlsson  <andersca@apple.com>
2010
2011         More work on the legacy WebKit visited link store
2012         https://bugs.webkit.org/show_bug.cgi?id=139100
2013
2014         Reviewed by Sam Weinig.
2015
2016         * History/WebHistory.mm:
2017         (+[WebHistory setOptionalSharedHistory:]):
2018         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
2019
2020         * WebCoreSupport/WebVisitedLinkStore.h:
2021         * WebCoreSupport/WebVisitedLinkStore.mm:
2022         (visitedLinkStores):
2023         (WebVisitedLinkStore::WebVisitedLinkStore):
2024         (WebVisitedLinkStore::~WebVisitedLinkStore):
2025         Keep track of live visited link stores.
2026
2027         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
2028         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
2029
2030         (WebVisitedLinkStore::removeAllVisitedLinks):
2031         Iterate over all live link stores and remove their links.
2032
2033         (WebVisitedLinkStore::isLinkVisited):
2034         Populate visited links and check if our hash table contains the link.
2035
2036         (WebVisitedLinkStore::addVisitedLink):
2037         Add the link hash to the table.
2038
2039         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
2040         Add stub.
2041
2042         (WebVisitedLinkStore::removeVisitedLinkHashes):
2043         Clear out the hash table.
2044
2045 2014-11-27  Anders Carlsson  <andersca@apple.com>
2046
2047         Add a stubbed out WebVisitedLinkStore to WebViewGroup
2048         https://bugs.webkit.org/show_bug.cgi?id=139066
2049
2050         Reviewed by Antti Koivisto.
2051
2052         * WebCoreSupport/WebViewGroup.h:
2053         (WebViewGroup::visitedLinkStore):
2054         * WebCoreSupport/WebViewGroup.mm:
2055         (WebViewGroup::WebViewGroup):
2056         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
2057         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
2058         (WebVisitedLinkStore::create):
2059         (WebVisitedLinkStore::WebVisitedLinkStore):
2060         (WebVisitedLinkStore::~WebVisitedLinkStore):
2061         (WebVisitedLinkStore::isLinkVisited):
2062         (WebVisitedLinkStore::addVisitedLink):
2063
2064 2014-11-25  Anders Carlsson  <andersca@apple.com>
2065
2066         Remove user content handling from PageGroup
2067         https://bugs.webkit.org/show_bug.cgi?id=139051
2068
2069         Reviewed by Antti Koivisto.
2070
2071         Use the user content controller in the web view group.
2072
2073         * WebView/WebView.mm:
2074         (-[WebView _injectOutlookQuirksScript]):
2075
2076 2014-11-25  Anders Carlsson  <andersca@apple.com>
2077
2078         Add a user content controller to WebViewGroup and use it for user content
2079         https://bugs.webkit.org/show_bug.cgi?id=139043
2080
2081         Reviewed by Antti Koivisto.
2082
2083         This is another tiny step towards getting rid of user content handling inside PageGroup.
2084
2085         * WebCoreSupport/WebViewGroup.h:
2086         (WebViewGroup::userContentController):
2087         Add a UserContentController member and getter.
2088
2089         * WebCoreSupport/WebViewGroup.mm:
2090         (WebViewGroup::get):
2091         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
2092
2093         (WebViewGroup::WebViewGroup):
2094         Create a user content controller.
2095
2096         * WebView/WebView.mm:
2097         (-[WebView _commonInitializationWithFrameName:groupName:]):
2098         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
2099         set its user content controller in the PageConfiguration.
2100
2101         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2102         Ditto.
2103
2104         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
2105         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
2106         (+[WebView _removeUserScriptFromGroup:world:url:]):
2107         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
2108         (+[WebView _removeUserScriptsFromGroup:world:]):
2109         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
2110         (+[WebView _removeAllUserContentFromGroup:]):
2111         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
2112
2113         (-[WebView setGroupName:]):
2114         Set the user content controller to the new WebViewGroup's user content controller.
2115
2116 2014-11-21  Jer Noble  <jer.noble@apple.com>
2117
2118         Support multiple signatures of diagnostic logging.
2119         https://bugs.webkit.org/show_bug.cgi?id=138690
2120
2121         Reviewed by Anders Carlsson.
2122
2123         Page::PageClients has been renamed PageConfiguration.
2124
2125         * WebView/WebView.mm:
2126         (-[WebView _commonInitializationWithFrameName:groupName:]):
2127         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2128
2129 2014-11-21  Zalan Bujtas  <zalan@apple.com>
2130
2131         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
2132         https://bugs.webkit.org/show_bug.cgi?id=138981
2133
2134         Reviewed by Simon Fraser.
2135
2136         * WebView/WebPreferenceKeysPrivate.h:
2137         * WebView/WebPreferences.mm:
2138         (+[WebPreferences initialize]):
2139         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
2140         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
2141         * WebView/WebPreferencesPrivate.h:
2142         * WebView/WebView.mm:
2143         (-[WebView _preferencesChanged:]):
2144
2145 2014-11-21  Tim Horton  <timothy_horton@apple.com>
2146
2147         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2148         ​https://bugs.webkit.org/show_bug.cgi?id=138960
2149         <rdar://problem/19056715>
2150
2151         Reviewed by Anders Carlsson.
2152
2153         * WebView/WebActionMenuController.mm:
2154         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2155         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2156         Use DataDetectors SPI instead of an explicit blacklist.
2157
2158 2014-11-21  Tim Horton  <timothy_horton@apple.com>
2159
2160         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2161         https://bugs.webkit.org/show_bug.cgi?id=138960
2162         <rdar://problem/19056715>
2163
2164         Reviewed by Beth Dakin.
2165
2166         * WebView/WebActionMenuController.mm:
2167         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2168         Blacklist contact results, because they don't have useful menus. If we
2169         bail before setting up _currentActionContext, we'll still allow fallthrough
2170         to ordinary text actions, avoiding mysterious failure when a contact is detected.
2171
2172         This doesn't break the case that r176351 was intended to fix,
2173         because in that case we were detecting e.g. addresses.
2174
2175 2014-11-21  Anders Carlsson  <andersca@apple.com>
2176
2177         Remove the Timer parameters from timer callbacks
2178         https://bugs.webkit.org/show_bug.cgi?id=138974
2179
2180         Reviewed by Antti Koivisto.
2181
2182         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2183         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2184         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
2185         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2186         * Plugins/WebNetscapePluginStream.h:
2187         * Plugins/WebNetscapePluginStream.mm:
2188         (WebNetscapePluginStream::WebNetscapePluginStream):
2189         (WebNetscapePluginStream::deliverDataTimerFired):
2190
2191 2014-11-21  Anders Carlsson  <andersca@apple.com>
2192
2193         Make memoryCache() return a reference
2194         https://bugs.webkit.org/show_bug.cgi?id=138939
2195
2196         Reviewed by Antti Koivisto.
2197
2198         * Misc/WebCache.mm:
2199         (+[WebCache statistics]):
2200         (+[WebCache emptyInMemoryResources]):
2201         (+[WebCache sizeOfDeadResources:]):
2202         (+[WebCache addImageToCache:forURL:forFrame:]):
2203         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2204         (+[WebCache imageForURL:]):
2205         (+[WebCache setDisabled:]):
2206         (+[WebCache isDisabled]):
2207         * WebView/WebView.mm:
2208         (+[WebView _setCacheModel:]):
2209
2210 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
2211
2212         Remove the remaining vestiges of minimal-ui
2213         https://bugs.webkit.org/show_bug.cgi?id=138890
2214
2215         Reviewed by Sam Weinig.
2216
2217         * History/WebHistoryItem.mm:
2218         * History/WebHistoryItemPrivate.h:
2219
2220 2014-11-20  Tim Horton  <timothy_horton@apple.com>
2221
2222         Cancel DataDetectors menu earlier if we know it can't be presented
2223         https://bugs.webkit.org/show_bug.cgi?id=138922
2224         <rdar://problem/18950441>
2225
2226         Reviewed by Beth Dakin.
2227
2228         * WebView/WebActionMenuController.mm:
2229         (-[WebActionMenuController prepareForMenu:withEvent:]):
2230         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
2231         and use a bigger hammer (removeAllItems).
2232
2233         (-[WebActionMenuController willOpenMenu:withEvent:]):
2234         If we end up with a menu with no items, don't change selection or anything.
2235
2236 2014-11-20  Beth Dakin  <bdakin@apple.com>
2237
2238         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
2239         https://bugs.webkit.org/show_bug.cgi?id=138568
2240         -and corresponding-
2241         rdar://problem/18904600
2242
2243         Reviewed by Tim Horton.
2244
2245         Skip images for lookup.
2246         * WebView/WebActionMenuController.mm:
2247         (performDictionaryLookupForRange):
2248
2249 2014-11-19  Beth Dakin  <bdakin@apple.com>
2250
2251         Invoking an action menu on a selection should result in the text menu
2252         https://bugs.webkit.org/show_bug.cgi?id=138892
2253         -and corresponding-
2254         rdar://problem/18996776
2255
2256         Reviewed by Tim Horton.
2257
2258         * WebView/WebActionMenuController.mm:
2259         (-[WebActionMenuController _defaultMenuItems]):
2260
2261 2014-11-19  Beth Dakin  <bdakin@apple.com>
2262
2263         Data detected results with no menu items should not fall through to regular text 
2264         action menus
2265         https://bugs.webkit.org/show_bug.cgi?id=138887
2266         -and corresponding-
2267         rdar://problem/18971616
2268
2269         Reviewed by Tim Horton.
2270
2271         * WebView/WebActionMenuController.mm:
2272         (-[WebActionMenuController _defaultMenuItems]):
2273
2274 2014-11-19  Daniel Bates  <dabates@apple.com>
2275
2276         [iOS] Make WebKit build with public iOS SDK
2277         https://bugs.webkit.org/show_bug.cgi?id=136863
2278
2279         Reviewed by David Kilzer.
2280
2281         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
2282         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
2283         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
2284         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
2285         may be used by Apple internal clients that do not include wtf/Platform.h.
2286         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
2287         private Foundation headers directly.
2288         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
2289         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
2290         instead of including private CFNetwork headers directly. Also fixed up style and
2291         ordering of header include directives.
2292         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
2293         CFNetwork headers directly. Also sort the #import directives.
2294         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
2295         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
2296
2297 2014-11-18  David Kilzer  <ddkilzer@apple.com>
2298
2299         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
2300         <http://webkit.org/b/138813>
2301
2302         Reviewed by Mark Rowe.
2303
2304         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
2305         selectors.
2306
2307 2014-11-18  Chris Dumez  <cdumez@apple.com>
2308
2309         Add a setting to toggle DOMTimer throttling support
2310         https://bugs.webkit.org/show_bug.cgi?id=138844
2311         <rdar://problem/19020874>
2312
2313         Reviewed by Andreas Kling.
2314
2315         Add a setting to disable DOM timers throttling, in order to help
2316         developers determine if a specific issue is caused by timer
2317         throttling.
2318
2319         * WebView/WebPreferenceKeysPrivate.h:
2320         * WebView/WebPreferences.mm:
2321         (+[WebPreferences initialize]):
2322         (-[WebPreferences domTimersThrottlingEnabled]):
2323         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
2324         * WebView/WebPreferencesPrivate.h:
2325         * WebView/WebView.mm:
2326         (-[WebView _preferencesChanged:]):
2327
2328 2014-11-18  Tim Horton  <timothy_horton@apple.com>
2329
2330         Avoid re-encoding action menu image data
2331         https://bugs.webkit.org/show_bug.cgi?id=138817
2332         <rdar://problem/18840382>
2333
2334         Reviewed by Anders Carlsson.
2335
2336         * WebView/WebActionMenuController.mm:
2337         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2338         (-[WebActionMenuController _addImageToPhotos:]):
2339         Build a temporary filename from a UUID and the image's desired extension.
2340         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
2341         Build an image menu only if we have an image, URL, data, and extension.
2342
2343 2014-11-18  Daniel Bates  <dabates@apple.com>
2344
2345         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2346         SPI are not available in public SDK
2347         https://bugs.webkit.org/show_bug.cgi?id=138802
2348
2349         Reviewed by David Kilzer.
2350
2351         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2352         libdispatch and MobileGestalt headers directly.
2353
2354         * WebView/WebView.mm:
2355
2356 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
2357
2358         Remove calls to deprecated NSMenu methods
2359         https://bugs.webkit.org/show_bug.cgi?id=138808.
2360
2361         Reviewed by Anders Carlsson.
2362
2363         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
2364
2365         * WebCoreSupport/PopupMenuMac.mm:
2366         (PopupMenuMac::populate):
2367
2368 2014-11-17  Daniel Bates  <dabates@apple.com>
2369
2370         Unreviewed, rolling out r176232.
2371
2372         Broke the Mac build. Will investigate offline.
2373
2374         Reverted changeset:
2375
2376         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2377         MobileGestalt"
2378         https://bugs.webkit.org/show_bug.cgi?id=138802
2379         http://trac.webkit.org/changeset/176232
2380
2381 2014-11-17  Daniel Bates  <dabates@apple.com>
2382
2383         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2384         SPI are not available in public SDK
2385         https://bugs.webkit.org/show_bug.cgi?id=138802
2386
2387         Reviewed by David Kilzer.
2388
2389         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2390         libdispatch and MobileGestalt headers directly.
2391
2392         * WebView/WebView.mm:
2393
2394 2014-11-17  Beth Dakin  <bdakin@apple.com>
2395
2396         Whitespace action menus should focus the HitTestResult and create an insertion 
2397         point
2398         https://bugs.webkit.org/show_bug.cgi?id=138786
2399         -and corresponding-
2400         rdar://problem/18944893
2401
2402         Reviewed by Tim Horton.
2403
2404         Whitespace menus should cause the HitTestResult to be focused, and they should set 
2405         the selection based on the HitTest location.
2406
2407         * WebView/WebActionMenuController.mm:
2408         (-[WebActionMenuController isMenuForTextContent]):
2409         (-[WebActionMenuController focusAndSelectHitTestResult]):
2410         (-[WebActionMenuController willOpenMenu:withEvent:]):
2411
2412 2014-11-17  Daniel Bates  <dabates@apple.com>
2413
2414         [iOS] QuartzCore SPI not available in public SDK
2415         https://bugs.webkit.org/show_bug.cgi?id=138751
2416
2417         Reviewed by David Kilzer.
2418
2419         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
2420
2421         * WebInspector/WebNodeHighlight.mm:
2422         * WebView/WebIndicateLayer.mm:
2423
2424 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
2425
2426         [iOS] allow host application to opt-out of alternate fullscreen
2427         https://bugs.webkit.org/show_bug.cgi?id=138787
2428
2429         Reviewed by Darin Adler.
2430
2431         * WebView/WebPreferenceKeysPrivate.h:
2432         * WebView/WebPreferences.mm:
2433         (+[WebPreferences initialize]):
2434         (-[WebPreferences allowsAlternateFullscreen]):
2435         (-[WebPreferences setAllowsAlternateFullscreen:]):
2436         * WebView/WebPreferencesPrivate.h:
2437         * WebView/WebView.mm:
2438         (-[WebView _preferencesChanged:]):
2439
2440 2014-11-16  Tim Horton  <timothy_horton@apple.com>
2441
2442         Use TextIndicator instead of the built in Lookup highlight
2443         https://bugs.webkit.org/show_bug.cgi?id=138775
2444         <rdar://problem/18953982>
2445
2446         Reviewed by Anders Carlsson.
2447
2448         * WebCoreSupport/WebSystemInterface.mm:
2449         (InitWebCoreSystemInterface):
2450         Remove a WKSI import.
2451
2452         * WebView/WebActionMenuController.mm:
2453         (-[WebActionMenuController _lookupText:]):
2454         (-[WebActionMenuController _createActionMenuItemForTag:]):
2455         Make use of the new Lookup SPI header.
2456         Disable the Lookup item if lookup is not available.
2457
2458 2014-11-15  Tim Horton  <timothy_horton@apple.com>
2459
2460         Implement data detectors and mailto action menus for WebKit1
2461         https://bugs.webkit.org/show_bug.cgi?id=138765
2462         <rdar://problem/18877535>
2463
2464         Reviewed by Beth Dakin.
2465
2466         * WebView/WebActionMenuController.h:
2467         * WebView/WebActionMenuController.mm:
2468         (-[WebActionMenuController willOpenMenu:withEvent:]):
2469         Tell DataDetectors that the menu is going to open.
2470         Select the text (or not) based on the number of items in the menu, just like WebKit2.
2471
2472         (-[WebActionMenuController didCloseMenu:withEvent:]):
2473         Tell DataDetectors that the menu closed.
2474
2475         (-[WebActionMenuController _defaultMenuItemsForLink]):
2476         Move these checks out of _defaultMenuItemsForLink, because we expect this
2477         to always return a complete link menu.
2478
2479         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2480         Implement. More or less copied from WebKit2.
2481
2482         (-[WebActionMenuController _selectDataDetectedText]):
2483         Select the stashed range.
2484
2485         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2486         Implement. More or less copied from WebKit2.
2487         The yellow highlight isn't hooked up yet.
2488         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
2489
2490         (-[WebActionMenuController _selectLookupText]):
2491         Remove an unnecessary return.
2492
2493         (-[WebActionMenuController _defaultMenuItems]):
2494         Call into the two new menu types.
2495
2496         * WebView/WebUIDelegatePrivate.h:
2497
2498 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
2499
2500         Get rid of WebFontCache
2501         https://bugs.webkit.org/show_bug.cgi?id=134752
2502
2503         Reviewed by Dave Hyatt.
2504
2505         * WebView/WebHTMLView.mm:
2506
2507 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
2508
2509         Update some artwork for the legacy WebKit action menu
2510         https://bugs.webkit.org/show_bug.cgi?id=138758
2511         <rdar://problem/18989840>
2512
2513         * WebView/WebActionMenuController.mm:
2514         (webKitBundleImageNamed): Deleted.
2515         Fix the build.
2516
2517 2014-11-14  Tim Horton  <timothy_horton@apple.com>
2518
2519         Update some artwork for the legacy WebKit action menu
2520         https://bugs.webkit.org/show_bug.cgi?id=138758
2521         <rdar://problem/18989840>
2522
2523         Reviewed by Simon Fraser.
2524
2525         * WebView/WebActionMenuController.mm:
2526         (-[WebActionMenuController _createActionMenuItemForTag:]):
2527
2528 2014-11-14  Daniel Bates  <dabates@apple.com>
2529
2530         [iOS] NSFileManager and QuickLook SPI not available in public SDK
2531         https://bugs.webkit.org/show_bug.cgi?id=138742
2532
2533         Reviewed by Pratik Solanki.
2534
2535         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
2536
2537         * WebCoreSupport/WebFrameLoaderClient.mm:
2538
2539 2014-11-14  Beth Dakin  <bdakin@apple.com>
2540
2541         WK1: Webpage preview can come up in wrong location
2542         https://bugs.webkit.org/show_bug.cgi?id=138747
2543         -and corresponding-
2544         rdar://problem/18979004
2545
2546         Reviewed by Tim Horton.
2547
2548         Converting to window twice is bad.
2549         * WebView/WebActionMenuController.mm:
2550         (elementBoundingBoxInWindowCoordinatesFromNode):
2551         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2552         (elementBoundingBoxFromNode): Deleted.
2553
2554 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2555
2556         Move FontMac and FontCacheMac off of WKSI
2557         https://bugs.webkit.org/show_bug.cgi?id=138633
2558
2559         Reviewed by Simon Fraser.
2560
2561         * WebCoreSupport/WebSystemInterface.mm:
2562         (InitWebCoreSystemInterface):
2563         * WebKit.order:
2564
2565 2014-11-13  Beth Dakin  <bdakin@apple.com>
2566
2567         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
2568         https://bugs.webkit.org/show_bug.cgi?id=138716
2569         -and corresponding-
2570         rdar://problem/18977222
2571
2572         Reviewed by Tim Horton.
2573
2574         It’s not necessary to use the WebElementDictionary for so many things now that we 
2575         are caching the HitTestResult. We should just use the HitTestResult.
2576
2577         * WebView/WebActionMenuController.mm:
2578         (-[WebActionMenuController prepareForMenu:withEvent:]):
2579         (-[WebActionMenuController _openURLFromActionMenu:]):
2580         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2581         (elementBoundingBoxFromNode):
2582         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2583         (-[WebActionMenuController _defaultMenuItemsForLink]):
2584         (-[WebActionMenuController _defaultMenuItemsForImage]):
2585         (-[WebActionMenuController _defaultMenuItemsForVideo]):
2586         (-[WebActionMenuController _defaultMenuItemsForText]):
2587         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2588         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2589         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2590         (-[WebActionMenuController _createActionMenuItemForTag:]):
2591         (-[WebActionMenuController _defaultMenuItems]):
2592         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
2593         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
2594         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
2595         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
2596         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
2597         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
2598         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
2599         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
2600         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
2601         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
2602
2603 2014-11-13  Daniel Bates  <dabates@apple.com>
2604
2605         [iOS] NSGeometry data types are not available in the public SDK
2606         https://bugs.webkit.org/show_bug.cgi?id=137536
2607
2608         Reviewed by David Kilzer.
2609
2610         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
2611         private header.
2612
2613         * DOM/WebDOMOperationsPrivate.h:
2614
2615 2014-11-13  Beth Dakin  <bdakin@apple.com>
2616
2617         WK1: Support default actions for video
2618         https://bugs.webkit.org/show_bug.cgi?id=138713
2619         -and corresponding-
2620         rdar://problem/18877520
2621
2622         Reviewed by Tim Horton.
2623
2624         Call setToNonShadowAncestor() for media HitTestResults.
2625         * WebView/WebActionMenuController.mm:
2626         (-[WebActionMenuController performHitTestAtPoint:]):
2627
2628         Default items and actions.
2629         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
2630         (-[WebActionMenuController _copyVideoURL:]):
2631         (-[WebActionMenuController _saveVideoToDownloads:]):
2632         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2633         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2634         * WebView/WebUIDelegatePrivate.h:
2635
2636 2014-11-13  Tim Horton  <timothy_horton@apple.com>
2637
2638         WK1: Update icon for Add to Reading List
2639         https://bugs.webkit.org/show_bug.cgi?id=138710
2640         <rdar://problem/18975774>
2641
2642         Reviewed by Beth Dakin.
2643
2644         * WebView/WebActionMenuController.mm:
2645         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2646         Use the right icon, matching WebKit2.
2647
2648 2014-11-12  Beth Dakin  <bdakin@apple.com>
2649
2650         WK1: Support default actions for images
2651         https://bugs.webkit.org/show_bug.cgi?id=138668
2652         -and corresponding-
2653         rdar://problem/18785434
2654
2655         Reviewed by Tim Horton.
2656
2657         * WebView/WebActionMenuController.h:
2658         * WebView/WebActionMenuController.mm:
2659         (-[WebActionMenuController didCloseMenu:withEvent:]):
2660         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2661         (-[WebActionMenuController _copyImage:]):
2662         (temporaryPhotosDirectoryPath):
2663         (pathToPhotoOnDisk):
2664         (-[WebActionMenuController _canAddMediaToPhotos]):
2665         (-[WebActionMenuController _addImageToPhotos:]):
2666         (-[WebActionMenuController _saveImageToDownloads:]):
2667         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2668         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
2669         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2670         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2671         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2672         * WebView/WebUIDelegatePrivate.h:
2673
2674 2014-11-11  Beth Dakin  <bdakin@apple.com>
2675
2676         Action menu hit testing is not working properly with all WK1 apps
2677         https://bugs.webkit.org/show_bug.cgi?id=138643
2678         -and corresponding-
2679         rdar://problem/18949376
2680
2681         Reviewed by Tim Horton.
2682
2683         * WebView/WebActionMenuController.mm:
2684         (-[WebActionMenuController prepareForMenu:withEvent:]):
2685         (-[WebActionMenuController _lookupText:]):
2686
2687 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2688
2689         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
2690         https://bugs.webkit.org/show_bug.cgi?id=138623
2691
2692         Reviewed by Geoff Garen.
2693
2694         * WebCoreSupport/WebSystemInterface.mm:
2695         (InitWebCoreSystemInterface):
2696         * WebKit.order:
2697
2698 2014-11-11  Tim Horton  <timothy_horton@apple.com>
2699
2700         Localize strings for action menus
2701         https://bugs.webkit.org/show_bug.cgi?id=138591
2702         <rdar://problem/18815343>
2703
2704         Reviewed by Dan Bates.
2705
2706         * WebView/WebActionMenuController.mm:
2707         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2708         Make use of the new strings.
2709
2710 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2711
2712         Cleanup from r175379
2713         https://bugs.webkit.org/show_bug.cgi?id=138616
2714
2715         Reviewed by Simon Fraser.
2716
2717         * WebCoreSupport/WebSystemInterface.mm:
2718         (InitWebCoreSystemInterface):
2719         * WebKit.order:
2720
2721 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2722
2723         Move CTFontTransformGlyphs out from WKSI
2724         https://bugs.webkit.org/show_bug.cgi?id=138599
2725
2726         Reviewed by Simon Fraser.
2727
2728         * WebCoreSupport/WebSystemInterface.mm:
2729         (InitWebCoreSystemInterface):
2730         * WebKit.order:
2731
2732 2014-11-11  Dan Bernstein  <mitz@apple.com>
2733
2734         More iOS build fix.
2735
2736         * WebView/WebHTMLViewInternal.h:
2737
2738 2014-11-11  Dan Bernstein  <mitz@apple.com>
2739
2740         iOS build fix.
2741
2742         * WebView/WebHTMLView.mm:
2743
2744 2014-11-10  Beth Dakin  <bdakin@apple.com>
2745
2746         WK1: Support default actions for editable text with misspelled word
2747         https://bugs.webkit.org/show_bug.cgi?id=138590
2748         -and corresponding-
2749         rdar://problem/18877506
2750
2751         Reviewed by Tim Horton.
2752
2753         If there are misspelled word suggestions for editable text, create a new type of 
2754         menu with a spelling suggestion sub-menu.
2755
2756         * WebView/WebActionMenuController.mm:
2757         (-[WebActionMenuController isMenuForTextContent]):
2758         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
2759         (-[WebActionMenuController _changeSelectionToSuggestion:]):
2760         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2761         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2762         * WebView/WebHTMLView.mm:
2763         (-[WebHTMLView _changeSpellingToWord:]):
2764         * WebView/WebHTMLViewInternal.h:
2765         * WebView/WebUIDelegatePrivate.h:
2766
2767 2014-11-10  Beth Dakin  <bdakin@apple.com>
2768
2769         WK1: Support default actions for editable whitespace
2770         https://bugs.webkit.org/show_bug.cgi?id=138586
2771         -and corresponding-
2772         rdar://problem/18932048
2773
2774         Reviewed by Tim Horton.
2775
2776         New menu type. Just wants paste.
2777
2778         * WebView/WebActionMenuController.mm:
2779         (-[WebActionMenuController isMenuForTextContent]):
2780         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
2781         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2782         * WebView/WebUIDelegatePrivate.h:
2783
2784 2014-11-10  Beth Dakin  <bdakin@apple.com>
2785
2786         WK1: Support default actions for editable text
2787         https://bugs.webkit.org/show_bug.cgi?id=138580
2788         -and corresponding-
2789         rdar://problem/18877497
2790
2791         Reviewed by Tim Horton.
2792
2793         New menu type, and new action type for paste. 
2794
2795         * WebView/WebActionMenuController.mm:
2796         (-[WebActionMenuController isMenuForTextContent]):
2797         (-[WebActionMenuController willOpenMenu:withEvent:]):
2798         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
2799         (-[WebActionMenuController _paste:]):
2800         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2801         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2802         * WebView/WebUIDelegatePrivate.h:
2803
2804 2014-11-10  Beth Dakin  <bdakin@apple.com>
2805
2806         WK1: Text is getting selected even when an action menu fails to invoke
2807         https://bugs.webkit.org/show_bug.cgi?id=138576
2808         -and corresponding-
2809         rdar://problem/18931330
2810
2811         Reviewed by Tim Horton.
2812
2813         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
2814         * WebView/WebActionMenuController.h:
2815         * WebView/WebActionMenuController.mm:
2816         (-[WebActionMenuController prepareForMenu:withEvent:]):
2817         (-[WebActionMenuController willOpenMenu:withEvent:]):
2818
2819         _selectLookupText no longer needs to return a BOOL indicating success or failure.
2820         (-[WebActionMenuController _selectLookupText]):
2821         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2822
2823         Pass willOpenMenu: on to the controller.
2824         * WebView/WebView.mm:
2825         (-[WebView willOpenMenu:withEvent:]):
2826
2827 2014-11-10  Beth Dakin  <bdakin@apple.com>
2828
2829         Speculative build fix.
2830
2831         * WebView/WebActionMenuController.mm:
2832
2833 2014-11-10  Beth Dakin  <bdakin@apple.com>
2834
2835         Action menu initialization should be moved to _commonInitializationWithFrameName
2836         https://bugs.webkit.org/show_bug.cgi?id=138572
2837         -and corresponding-
2838         rdar://problem/18929733
2839
2840         Reviewed by Tim Horton.
2841
2842         * WebView/WebView.mm:
2843         (-[WebView _commonInitializationWithFrameName:groupName:]):
2844         (-[WebView _initWithFrame:frameName:groupName:]):
2845
2846 2014-11-10  Beth Dakin  <bdakin@apple.com>
2847
2848         WK1: Support default actions for read-only text
2849         https://bugs.webkit.org/show_bug.cgi?id=138552
2850         -and corresponding-
2851         rdar://problem/18877483
2852
2853         Reviewed by Tim Horton.
2854
2855         New WKSystemInterface functions that WebCore needs to use.
2856         * WebCoreSupport/WebSystemInterface.mm:
2857         (InitWebCoreSystemInterface):
2858
2859         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
2860         makes a lot of things easier.
2861         * WebView/WebActionMenuController.h:
2862         * WebView/WebActionMenuController.mm:
2863
2864         Perform the hit test ourselves instead of calling into WebView so that we can more 
2865         easily save the WebCore::HitTestResult for ourselves.
2866         (-[WebActionMenuController performHitTestAtPoint:]):
2867
2868         Clear selection for non-text menus.
2869         (-[WebActionMenuController prepareForMenu:withEvent:]):
2870
2871         Re-set the _type here just to be safe.
2872         (-[WebActionMenuController didCloseMenu:withEvent:]):
2873
2874         Moving this method to be next to the link actions so they can be within a pragma 
2875         mark.
2876         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2877
2878         New method for default text actions — lookup and copy.
2879         (-[WebActionMenuController _defaultMenuItemsForText:]):
2880         (-[WebActionMenuController _copySelection:]):
2881         (-[WebActionMenuController _lookupText:]):
2882
2883         If there is not already a selection, invoking the action menu on text should 
2884         select the lookup text.
2885         (-[WebActionMenuController _selectLookupText]):
2886         (performDictionaryLookupForSelection):
2887         (performDictionaryLookupForRange):
2888
2889         Handle text now.
2890         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2891         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2892
2893         New enum values.
2894         * WebView/WebUIDelegatePrivate.h:
2895
2896         Pass didCloseMenu on to the controller.
2897         * WebView/WebView.mm:
2898         (-[WebView didCloseMenu:withEvent:]):
2899
2900 2014-11-09  Chris Dumez  <cdumez@apple.com>
2901
2902         Add a more correct way to compare floating point numbers and use it
2903         https://bugs.webkit.org/show_bug.cgi?id=138527
2904
2905         Reviewed by Darin Adler.
2906
2907         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
2908         to compare floating-point numbers.
2909
2910         * WebView/WebHTMLView.mm:
2911         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2912
2913 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2914
2915         Delete cookies between tests
2916         https://bugs.webkit.org/show_bug.cgi?id=138528
2917
2918         Reviewed by Sam Weinig.
2919
2920         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
2921         * WebView/WebPreferencesPrivate.h:
2922         Added an SPI for DumpRenderTree.
2923
2924 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
2925
2926         [iOS] Update optimized fullscreen media controls
2927         https://bugs.webkit.org/show_bug.cgi?id=138493
2928
2929         Reviewed by Brent Fulgham.
2930
2931         * WebCoreSupport/WebSystemInterface.mm:
2932         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
2933
2934 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
2935
2936         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
2937         https://bugs.webkit.org/show_bug.cgi?id=138443
2938
2939         Reviewed by Anders Carlsson.
2940
2941         Wrapping the dealloc method in its own autorelease pool avoids the problem of
2942         complex tear-downs leading to the WebView itself being added to an autorelease
2943         pool that is not drained until after the instance has been dealloc'd.
2944  
2945         * WebView/WebView.mm:
2946         (-[WebView dealloc]):
2947
2948 2014-11-05  Jer Noble  <jer.noble@apple.com>
2949
2950         De-templatize Timer
2951         https://bugs.webkit.org/show_bug.cgi?id=138450
2952
2953         Reviewed by Anders Carlsson.
2954
2955         Remove template specifiers from Timer.
2956
2957         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2958         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2959         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2960         * Plugins/WebNetscapePluginStream.h:
2961         * Plugins/WebNetscapePluginStream.mm:
2962         (WebNetscapePluginStream::deliverDataTimerFired):
2963
2964 2014-11-05  Dan Bernstein  <mitz@apple.com>
2965
2966         Remove the unused deletion UI feature
2967         https://bugs.webkit.org/show_bug.cgi?id=138442
2968
2969         Rubber-stamped by Alexey Proskuryakov.
2970
2971         * DefaultDelegates/WebDefaultEditingDelegate.m:
2972         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
2973         * WebCoreSupport/WebEditorClient.h:
2974         * WebCoreSupport/WebEditorClient.mm:
2975         (WebEditorClient::shouldShowDeleteInterface): Deleted.
2976         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
2977         -webView:shouldShowDeleteInterfaceForElement:.
2978
2979 2014-11-03  Dean Jackson  <dino@apple.com>
2980
2981         Add ENABLE_FILTERS_LEVEL_2 feature guard.
2982         https://bugs.webkit.org/show_bug.cgi?id=138362
2983
2984         Reviewed by Tim Horton.
2985
2986         Add a new feature define for Level 2 of CSS Filters.
2987         http://dev.w3.org/fxtf/filters-2/
2988
2989         * Configurations/FeatureDefines.xcconfig:
2990
2991 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
2992
2993         Add button and enable optimized fullscreen.
2994         https://bugs.webkit.org/show_bug.cgi?id=138351
2995
2996         Reviewed by Eric Carlson.
2997
2998         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
2999
3000         * WebCoreSupport/WebSystemInterface.mm:
3001         (InitWebCoreSystemInterface): added
3002
3003 2014-11-04  Chris Dumez  <cdumez@apple.com>
3004
3005         Add ptr() method to Ref class
3006         https://bugs.webkit.org/show_bug.cgi?id=138361
3007
3008         Reviewed by Darin Adler.
3009
3010         Use the new Ref::ptr() method.
3011
3012         * WebView/WebFrame.mm:
3013         (-[WebFrame _setTypingStyle:withUndoAction:]):
3014         * WebView/WebHTMLView.mm:
3015         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
3016         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
3017         * WebView/WebView.mm:
3018         (-[WebView applyStyle:]):
3019
3020 2014-11-04  Darin Adler  <darin@apple.com>
3021
3022         Eliminate ResourceBuffer and use SharedBuffer directly instead
3023         https://bugs.webkit.org/show_bug.cgi?id=138174
3024
3025         Reviewed by Antti Koivisto.
3026
3027         * WebView/WebDataSource.mm:
3028         (-[WebDataSource data]): Use SharedBuffer directly.
3029         * WebView/WebHTMLView.mm:
3030         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3031
3032 2014-11-03  Commit Queue  <commit-queue@webkit.org>
3033
3034         Unreviewed, rolling out r175406, r175413, and r175423.
3035         https://bugs.webkit.org/show_bug.cgi?id=138327
3036
3037         Multipart tests are still broken (Requested by ap on #webkit).
3038
3039         Reverted changesets:
3040
3041         "Eliminate ResourceBuffer and use SharedBuffer directly
3042         instead"
3043         https://bugs.webkit.org/show_bug.cgi?id=138174
3044         http://trac.webkit.org/changeset/175406
3045
3046         "Unreviewed, iOS build fix since 175406."
3047         http://trac.webkit.org/changeset/175413
3048
3049         "Fix assertion in CachedResource::addDataBuffer"
3050         http://trac.webkit.org/changeset/175423
3051
3052 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3053
3054         Use std::unique_ptr for TypeCountSet
3055         https://bugs.webkit.org/show_bug.cgi?id=138242
3056
3057         Reviewed by Andreas Kling.
3058
3059         * Misc/WebCoreStatistics.mm:
3060         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
3061         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
3062
3063 2014-10-31  Beth Dakin  <bdakin@apple.com>
3064
3065         Use system art for action menus when possible
3066         https://bugs.webkit.org/show_bug.cgi?id=138260
3067
3068         Reviewed by Tim Horton.
3069
3070         * WebView/WebActionMenuController.mm:
3071         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3072
3073 2014-10-30  Darin Adler  <darin@apple.com>
3074
3075         Eliminate ResourceBuffer and use SharedBuffer directly instead
3076         https://bugs.webkit.org/show_bug.cgi?id=138174
3077
3078         Reviewed by Antti Koivisto.
3079
3080         * WebView/WebDataSource.mm:
3081         (-[WebDataSource data]): Use SharedBuffer directly.
3082         * WebView/WebHTMLView.mm:
3083         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3084
3085 2014-10-30  Jer Noble  <jer.noble@apple.com>
3086
3087         [EME] Add Setting for accessing storage location for MediaKeys data
3088         https://bugs.webkit.org/show_bug.cgi?id=138147
3089
3090         Reviewed by Brady Eidson.
3091
3092         * WebView/WebPreferenceKeysPrivate.h:
3093         * WebView/WebPreferences.mm:
3094         (+[WebPreferences initialize]): Set default location.
3095         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
3096         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
3097         * WebView/WebPreferencesPrivate.h:
3098         * WebView/WebView.mm:
3099         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
3100
3101 2014-10-30  Dana Burkart  <dburkart@apple.com>
3102
3103         <rdar://problem/18821260> Prepare for the mysterious future
3104
3105         Reviewed by Lucas Forschler.
3106
3107         * Configurations/Base.xcconfig:
3108         * Configurations/DebugRelease.xcconfig:
3109         * Configurations/FeatureDefines.xcconfig:
3110         * Configurations/Version.xcconfig:
3111
3112 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
3113
3114         Add optimized fullscreen mode.
3115         https://bugs.webkit.org/show_bug.cgi?id=138044
3116
3117         Reviewed by Jer Noble.
3118
3119         Enable different types of fullscreen video behavior.
3120         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
3121
3122         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
3123         * WebCoreSupport/WebChromeClient.mm:
3124         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
3125         * WebView/WebView.mm:
3126         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
3127         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
3128         * WebView/WebViewInternal.h: ditto
3129
3130 2014-10-27  Beth Dakin  <bdakin@apple.com>
3131
3132         Provide a way for WebKit1 clients to override default action menu items
3133         https://bugs.webkit.org/show_bug.cgi?id=138066
3134         -and corresponding-
3135         rdar://problem/18451638
3136
3137         Reviewed by Anders Carlsson.
3138
3139         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
3140         send that along to clients customizing the menu.
3141         * WebView/WebActionMenuController.h:
3142         * WebView/WebActionMenuController.mm:
3143         (-[WebActionMenuController prepareForMenu:withEvent:]):
3144         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3145
3146         New enum and new SPI to customize menus.
3147         * WebView/WebUIDelegatePrivate.h:
3148
3149 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
3150
3151         Fix the iOS build
3152
3153         * Configurations/WebKitLegacy.xcconfig:
3154         * WebView/WebView.mm:
3155
3156 2014-10-24  Beth Dakin  <bdakin@apple.com>
3157
3158         Build fix.
3159
3160         * WebView/WebActionMenuController.mm:
3161         (-[WebActionMenuController _openURLFromActionMenu:]):
3162         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3163         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3164
3165 2014-10-24  Beth Dakin  <bdakin@apple.com>
3166
3167         WebKit1 should support action menus
3168         https://bugs.webkit.org/show_bug.cgi?id=138032
3169
3170         Reviewed by Tim Horton.
3171
3172         This patch adds basic support for action menus and adds actions for links.
3173
3174         Helper class takes care of all of the action menu work. WebView will forward the 
3175         prepareForMenu: message, and then the helper class takes it from there.
3176         * WebView/WebActionMenuController.h: Added.
3177         * WebView/WebActionMenuController.mm: Added.
3178         (-[WebActionMenuController webViewClosed]):
3179         (-[WebActionMenuController prepareForMenu:withEvent:]):
3180
3181         Selectors for link actions.
3182         (-[WebActionMenuController _openURLFromActionMenu:]):
3183         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3184         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
3185         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3186         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3187         (webKitBundleImageNamed):
3188         (-[WebActionMenuController _defaultMenuItemsForLink:]):
3189         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3190
3191         Tags for the action menu items.
3192         * WebView/WebUIDelegatePrivate.h:
3193         * WebView/WebView.mm:
3194
3195         Set the action menu if possible and create the controller.
3196         (-[WebView _initWithFrame:frameName:groupName:]):
3197         (-[WebView _close]):
3198         (-[WebView prepareForMenu:withEvent:]):
3199
3200         WebViewData stores the WebActionMenuHelper
3201         * WebView/WebViewData.h:
3202         * WebView/WebViewData.mm:
3203         (-[WebViewPrivate dealloc]):
3204
3205 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
3206
3207         Web Inspector: Provide a way to have alternate inspector agents
3208         https://bugs.webkit.org/show_bug.cgi?id=137901
3209
3210         Reviewed by Brian Burg.
3211
3212         * Configurations/FeatureDefines.xcconfig:
3213
3214 2014-10-23  Tim Horton  <timothy_horton@apple.com>
3215
3216         Add some SPI headers for NSExtension and NSSharingService{Picker}
3217         https://bugs.webkit.org/show_bug.cgi?id=138027
3218
3219         Reviewed by Anders Carlsson.
3220
3221         * Misc/WebSharingServicePickerController.h:
3222         * Misc/WebSharingServicePickerController.mm:
3223         * WebCoreSupport/WebSelectionServiceController.mm:
3224         * WebCoreSupport/WebContextMenuClient.mm:
3225         Fix a sorting issue.
3226         Replace redefinitions with SPI header #imports.
3227
3228 2014-10-23  Tim Horton  <timothy_horton@apple.com>
3229
3230         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
3231         https://bugs.webkit.org/show_bug.cgi?id=138013
3232
3233         Reviewed by Dan Bernstein.
3234
3235         * WebCoreSupport/WebSelectionServiceController.mm:
3236         (WebSelectionServiceController::hasRelevantSelectionServices):
3237         Don't adopt this autoreleased object.
3238
3239 2014-10-22  Chris Dumez  <cdumez@apple.com>
3240
3241         [Mac][WK2] Fix applicationIsSafari() detection
3242         https://bugs.webkit.org/show_bug.cgi?id=137893
3243
3244         Reviewed by Alexey Proskuryakov.
3245
3246         Provide an implementation for FrameLoaderClient's new
3247         needsQuickLookResourceCachingQuirks() that returns
3248         a static flag initialized using
3249         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
3250
3251         * WebCoreSupport/WebFrameLoaderClient.h:
3252         * WebCoreSupport/WebFrameLoaderClient.mm:
3253
3254 2014-10-20  Chris Dumez  <cdumez@apple.com>
3255
3256         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
3257         https://bugs.webkit.org/show_bug.cgi?id=137797
3258
3259         Reviewed by Darin Adler.
3260
3261         Call ResourceRequest::setDomainForPartitionName() instead of
3262         setPartitionName() as the argument is a domain, not a valid
3263         partition name.
3264
3265         * Misc/WebCache.mm:
3266         (+[WebCache addImageToCache:forURL:forFrame:]):
3267         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3268
3269 2014-10-20  Andy Estes  <aestes@apple.com>
3270
3271         Fix the iOS build.
3272
3273         * WebView/WebFrame.mm:
3274         (-[WebFrame getDictationResultRanges:andMetadatas:]):
3275         (-[WebFrame dictationResultMetadataForRange:]):
3276
3277 2014-10-19  Chris Dumez  <cdumez@apple.com>
3278
3279         Use is<>() / downcast<>() for all remaining RenderObject subclasses
3280         https://bugs.webkit.org/show_bug.cgi?id=137845
3281
3282         Reviewed by Darin Adler.
3283
3284         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
3285         clean up the surrounding code.
3286
3287         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3288         (-[WebHostedNetscapePluginView pluginHostDied]):
3289         * Plugins/WebBaseNetscapePluginView.mm:
3290         (-[WebBaseNetscapePluginView _windowClipRect]):
3291         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
3292         * WebCoreSupport/WebFrameLoaderClient.mm:
3293         (WebFrameLoaderClient::createPlugin):
3294         (WebFrameLoaderClient::createJavaAppletWidget):
3295
3296 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3297
3298         Build fix for 32-bit Yosemite
3299
3300         * WebCoreSupport/WebContextMenuClient.mm:
3301         (WebContextMenuClient::contextMenuForEvent):
3302         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
3303
3304 2014-10-17  Chris Dumez  <cdumez@apple.com>
3305
3306         Use is<>() / downcast<>() for RenderBox
3307         https://bugs.webkit.org/show_bug.cgi?id=137804
3308
3309         Reviewed by Andreas Kling.
3310
3311         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
3312         code.
3313
3314         * WebCoreSupport/WebContextMenuClient.mm:
3315         (WebContextMenuClient::clientFloatRectForNode):
3316         * WebView/WebFrame.mm:
3317         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
3318
3319 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3320
3321         Fix the build with the public SDK.
3322
3323         * WebCoreSupport/WebSelectionServiceController.mm:
3324         We should transition all this SPI to real SPI headers as soon as possible.
3325
3326 2014-10-16  Tim Horton  <timothy_horton@apple.com>
3327
3328         Implement selection services menu for Legacy WebKit
3329         https://bugs.webkit.org/show_bug.cgi?id=137582
3330         <rdar://problem/18604241>
3331
3332         Reviewed by Brady Eidson.
3333
3334         * Misc/WebSharingServicePickerController.h:
3335         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
3336         Add WebSharingServicePickerClient, which other classes can implement
3337         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
3338         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
3339
3340         * Misc/WebSharingServicePickerController.mm:
3341         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
3342
3343         (-[WebSharingServicePickerController clear]):
3344         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
3345         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
3346         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
3347         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
3348         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3349         Make use of WebSharingServicePickerClient.
3350
3351         (-[WebSharingServicePickerController sharingService:didShareItems:]):
3352         If we're returned a NSAttributedString, paste it on top of the current selection,
3353         similar to what the WebKit2 implementation currently does.
3354         
3355         * WebCoreSupport/WebChromeClient.h:
3356         * WebCoreSupport/WebChromeClient.mm:
3357         (WebChromeClient::handleTelephoneNumberClick):
3358         (WebChromeClient::handleSelectionServiceClick):
3359         (WebChromeClient::hasRelevantSelectionServices):
3360         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
3361
3362         * WebCoreSupport/WebContextMenuClient.h:
3363         * WebCoreSupport/WebContextMenuClient.mm:
3364         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
3365         (WebContextMenuClient::pageForSharingServicePicker):
3366         (WebContextMenuClient::windowForSharingServicePicker):
3367         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
3368         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3369         (WebContextMenuClient::contextMenuForEvent):
3370         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
3371         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
3372         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
3373         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
3374         having WebSharingServicePickerController tightly bound to it.
3375         Make an NSItemProvider array when instantiating WebSharingServicePickerController
3376         instead of handing it data directly.
3377
3378         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
3379         * WebCoreSupport/WebSelectionServiceController.mm: Added.
3380         (WebSelectionServiceController::WebSelectionServiceController):
3381         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
3382         for selection services.
3383
3384         (WebSelectionServiceController::handleSelectionServiceClick):
3385         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
3386
3387         (hasCompatibleServicesForItems):
3388         (WebSelectionServiceController::hasRelevantSelectionServices):
3389         Determine whether or not services are available.
3390
3391         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
3392         (WebSelectionServiceController::pageForSharingServicePicker):
3393         (WebSelectionServiceController::windowForSharingServicePicker):
3394         Implement the rest of the WebSharingServicePickerClient overrides.
3395
3396         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
3397         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
3398         These are only useful for image sharing services, so we don't need to
3399         implement them (WebContextMenuClient does, on the other hand).
3400
3401         * WebView/WebView.mm:
3402         (-[WebView _selectionServiceController]):
3403         * WebView/WebViewData.h:
3404         * WebView/WebViewData.mm:
3405         * WebView/WebViewInternal.h:
3406         Keep a WebSelectionServiceController.
3407
3408 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3409
3410         Improve debug description of WAKViews
3411         https://bugs.webkit.org/show_bug.cgi?id=137716
3412
3413         Reviewed by Simon Fraser.
3414
3415         * WebView/WebView.mm:
3416         (-[WebView _touchEventRegions]): Adding a comment.
3417
3418 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3419
3420         Addressing post-review comment.
3421         https://bugs.webkit.org/show_bug.cgi?id=137550
3422
3423         Unreviewed.
3424
3425         * WebView/WebHTMLView.mm:
3426         (fontNameForDescription):
3427         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3428
3429 2014-10-14  Chris Dumez  <cdumez@apple.com>
3430
3431         Use is<>() / downcast<>() for RenderImage
3432         https://bugs.webkit.org/show_bug.cgi?id=137683
3433
3434         Reviewed by Mihnea Ovidenie.
3435
3436         Use is<>() / downcast<>() for RenderImage.
3437
3438         * Misc/WebNSPasteboardExtras.mm:
3439         (imageFromElement):
3440         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3441
3442 2014-10-10  Daniel Bates  <dabates@apple.com>
3443
3444         Remove unused classes WebRender{Node, Layer}
3445         https://bugs.webkit.org/show_bug.cgi?id=137628
3446
3447         Reviewed by Simon Fraser.
3448
3449         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
3450         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
3451
3452         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
3453         of excluded source files when building for iOS.
3454         * WebKit.exp: Remove symbol for WebRenderLayer.
3455         * WebKit.mac.exp: Remove symbol for WebRenderNode.
3456         * WebView/WebRenderLayer.h: Removed.
3457         * WebView/WebRenderLayer.mm: Removed.
3458         * WebView/WebRenderNode.h: Removed.
3459         * WebView/WebRenderNode.mm: Removed.
3460
3461 2014-10-10  Chris Dumez  <cdumez@apple.com>
3462
3463         Use is<>() / downcast<>() for RenderBoxModelObject
3464         https://bugs.webkit.org/show_bug.cgi?id=137587
3465
3466         Reviewed by Mihnea Ovidenie.
3467
3468         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
3469         surrounding code.
3470
3471         * Plugins/WebBaseNetscapePluginView.mm:
3472         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
3473         * WebView/WebRenderLayer.mm:
3474         (-[WebRenderLayer initWithWebFrame:]):
3475
3476 2014-10-09  Dean Jackson  <dino@apple.com>
3477
3478         Remove ENABLE_CSS3_CONDITIONAL_RULES
3479         https://bugs.webkit.org/show_bug.cgi?id=137571
3480
3481         Reviewed by Simon Fraser.
3482
3483         * Configurations/FeatureDefines.xcconfig:
3484
3485 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3486
3487         Add a WebKit1 preference for selection services
3488         https://bugs.webkit.org/show_bug.cgi?id=137498
3489         <rdar://problem/18572699>
3490
3491         Reviewed by Simon Fraser.
3492
3493         * WebView/WebPreferenceKeysPrivate.h:
3494         * WebView/WebPreferences.mm:
3495         (+[WebPreferences initialize]):
3496         (-[WebPreferences serviceControlsEnabled]):
3497         (-[WebPreferences setServiceControlsEnabled:]):
3498         * WebView/WebPreferencesPrivate.h:
3499         * WebView/WebView.mm:
3500         (-[WebView _preferencesChanged:]):
3501         Add and plumb the preference.
3502
3503 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
3504
3505         Remove second-to-last client of WebFontCache
3506         https://bugs.webkit.org/show_bug.cgi?id=137550
3507
3508         Reviewed by Darin Adler.
3509
3510         Use FontCache::getCachedFontData() instead of WebFontCache.
3511
3512         * WebView/WebHTMLView.mm:
3513         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3514
3515 2014-10-09  Chris Dumez  <cdumez@apple.com>
3516
3517         Use is<>() / downcast<>() for Widget subclasses
3518         https://bugs.webkit.org/show_bug.cgi?id=137549
3519
3520         Reviewed by Darin Adler.
3521
3522         Use is<>() / downcast<>() for Widget subclasses and clean up the
3523         surrounding code.
3524
3525         * WebView/WebRenderNode.mm:
3526         (copyRenderNode):
3527         * WebView/WebView.mm:
3528         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
3529
3530 2014-10-07  Christophe Dumez  <cdumez@apple.com>
3531
3532         Use is<>() / downcast<>() for RenderText / RenderTextFragment
3533         https://bugs.webkit.org/show_bug.cgi?id=137476
3534
3535         Reviewed by Darin Adler.
3536
3537         * WebView/WebRenderNode.mm:
3538         (copyRenderNode):
3539
3540 2014-10-06  Dan Bernstein  <mitz@apple.com>
3541
3542         Build fix.
3543
3544         * Misc/WebCache.mm:
3545         (+[WebCache imageForURL:]):
3546
3547 2014-10-06  Chris Dumez  <cdumez@apple.com>
3548
3549         Unreviewed build fix after r174333.
3550
3551         Forgot explicit WebCore:: namespace.
3552
3553         * Misc/WebCache.mm:
3554         (+[WebCache imageForURL:]):
3555
3556 2014-10-05  Christophe Dumez  <cdumez@apple.com>
3557
3558         Use is<>() / downcast<>() for CachedResource subclasses
3559         https://bugs.webkit.org/show_bug.cgi?id=137431
3560
3561         Reviewed by Benjamin Poulain.
3562
3563         Use is<>() / downcast<>() for CachedResource subclasses.
3564
3565         * Misc/WebCache.mm:
3566         (+[WebCache imageForURL:]):
3567
3568 2014-10-02  Daniel Bates  <dabates@apple.com>
3569
3570         Use version number 101000 instead of 10100 for OS X Yosemite
3571         https://bugs.webkit.org/show_bug.cgi?id=137372
3572
3573         Reviewed by Mark Rowe.
3574
3575         The version number for OS X Yosemite is 101000.
3576
3577         * WebView/WebView.mm: