d42420ab16698dcf1d804384bc92cdfe8bd9a3b4
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-07-05  Brady Eidson  <beidson@apple.com>
2
3         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
4         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
5
6         Reviewed by Alex Christensen.
7
8         Adopt to the new constructor for FrameLoadRequest.
9
10         * WebView/WebPDFView.mm:
11         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
12
13 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
14
15         Make WebKit's public headers on Mac and iOS C++ module safe
16         https://bugs.webkit.org/show_bug.cgi?id=174175
17
18         Reviewed by Alex Christensen.
19
20         Fixed the header files.
21
22         * Misc/WebDownload.h:
23         * Misc/WebKitErrors.h:
24         * Plugins/WebPluginContainer.h:
25         * WebView/WebResourceLoadDelegate.h:
26
27 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
28
29         Remove copy of ICU headers from WebKit
30         https://bugs.webkit.org/show_bug.cgi?id=116407
31
32         Reviewed by Alex Christensen.
33
34         Use WTF's copy of ICU headers.
35
36         * Configurations/WebKitLegacy.xcconfig:
37         * icu/unicode/localpointer.h: Removed.
38         * icu/unicode/parseerr.h: Removed.
39         * icu/unicode/platform.h: Removed.
40         * icu/unicode/ptypes.h: Removed.
41         * icu/unicode/putil.h: Removed.
42         * icu/unicode/uchar.h: Removed.
43         * icu/unicode/uconfig.h: Removed.
44         * icu/unicode/ucurr.h: Removed.
45         * icu/unicode/uidna.h: Removed.
46         * icu/unicode/uiter.h: Removed.
47         * icu/unicode/umachine.h: Removed.
48         * icu/unicode/unorm.h: Removed.
49         * icu/unicode/unorm2.h: Removed.
50         * icu/unicode/urename.h: Removed.
51         * icu/unicode/uscript.h: Removed.
52         * icu/unicode/ustring.h: Removed.
53         * icu/unicode/utf.h: Removed.
54         * icu/unicode/utf16.h: Removed.
55         * icu/unicode/utf8.h: Removed.
56         * icu/unicode/utf_old.h: Removed.
57         * icu/unicode/utypes.h: Removed.
58         * icu/unicode/uvernum.h: Removed.
59         * icu/unicode/uversion.h: Removed.
60
61 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
62
63         Add WebKitPrivateFrameworkStubs for iOS 11
64         https://bugs.webkit.org/show_bug.cgi?id=173988
65
66         Reviewed by David Kilzer.
67
68         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
69         use the same directory for private framework stubs.
70
71 2017-07-03  Matt Lewis  <jlewis3@apple.com>
72
73         Unreviewed, rolling out r219103.
74
75         Caused multiple build failures.
76
77         Reverted changeset:
78
79         "Remove copy of ICU headers from WebKit"
80         https://bugs.webkit.org/show_bug.cgi?id=116407
81         http://trac.webkit.org/changeset/219103
82
83 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
84
85         Remove copy of ICU headers from WebKit
86         https://bugs.webkit.org/show_bug.cgi?id=116407
87
88         Reviewed by Alex Christensen.
89
90         Use WTF's copy of ICU headers.
91
92         * Configurations/WebKitLegacy.xcconfig:
93         * icu/unicode/localpointer.h: Removed.
94         * icu/unicode/parseerr.h: Removed.
95         * icu/unicode/platform.h: Removed.
96         * icu/unicode/ptypes.h: Removed.
97         * icu/unicode/putil.h: Removed.
98         * icu/unicode/uchar.h: Removed.
99         * icu/unicode/uconfig.h: Removed.
100         * icu/unicode/ucurr.h: Removed.
101         * icu/unicode/uidna.h: Removed.
102         * icu/unicode/uiter.h: Removed.
103         * icu/unicode/umachine.h: Removed.
104         * icu/unicode/unorm.h: Removed.
105         * icu/unicode/unorm2.h: Removed.
106         * icu/unicode/urename.h: Removed.
107         * icu/unicode/uscript.h: Removed.
108         * icu/unicode/ustring.h: Removed.
109         * icu/unicode/utf.h: Removed.
110         * icu/unicode/utf16.h: Removed.
111         * icu/unicode/utf8.h: Removed.
112         * icu/unicode/utf_old.h: Removed.
113         * icu/unicode/utypes.h: Removed.
114         * icu/unicode/uvernum.h: Removed.
115         * icu/unicode/uversion.h: Removed.
116
117 2017-07-03  Brady Eidson  <beidson@apple.com>
118
119         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
120         https://bugs.webkit.org/show_bug.cgi?id=174073
121
122         Reviewed by Andy Estes.
123
124         WebView now keeps a direct copy of its main frame icon as a member variable.
125         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
126         
127         This change causes a progression in KVO observation of the mainFrameIcon property as we now
128         have both the old icon and new icon at the time it changes.
129
130         * WebCoreSupport/WebFrameLoaderClient.h:
131         * WebCoreSupport/WebFrameLoaderClient.mm:
132         (WebFrameLoaderClient::prepareForDataSourceReplacement):
133         (WebFrameLoaderClient::getLoadDecisionForIcons):
134         (WebFrameLoaderClient::finishedLoadingIcon):
135         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
136         (WebFrameLoaderClient::registerForIconNotification): Deleted.
137
138         * WebView/WebView.mm:
139         (+[WebView _setIconLoadingEnabled:]):
140         (+[WebView _isIconLoadingEnabled]):
141         (-[WebView mainFrameIcon]):
142         (-[WebView _setMainFrameIcon:]):
143         (-[WebView _receivedIconChangedNotification:]): Deleted.
144         (-[WebView _registerForIconNotification:]): Deleted.
145         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
146         * WebView/WebViewData.h:
147         * WebView/WebViewInternal.h:
148         * WebView/WebViewPrivate.h:
149
150 2017-07-03  Sam Weinig  <sam@webkit.org>
151
152         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
153         https://bugs.webkit.org/show_bug.cgi?id=174083
154
155         Reviewed by Alex Christensen.
156
157         * Configurations/FeatureDefines.xcconfig:
158         Add ENABLE_NAVIGATOR_STANDALONE.
159
160 2017-07-03  Tim Horton  <timothy_horton@apple.com>
161
162         Expose unobscuredSafeAreaInsets on WebView
163         https://bugs.webkit.org/show_bug.cgi?id=174075
164         <rdar://problem/33096997>
165
166         Reviewed by Beth Dakin.
167
168         * WebView/WebView.mm:
169         (-[WebView _setUnobscuredSafeAreaInsets:]):
170         (-[WebView _unobscuredSafeAreaInsets]):
171         * WebView/WebViewPrivate.h:
172         Expose unobscuredSafeAreaInsets as a new private property on WebView,
173         similar to how it is exposed in WebKit2.
174
175 2017-07-03  Andy Estes  <aestes@apple.com>
176
177         [Xcode] Add an experimental setting to build with ccache
178         https://bugs.webkit.org/show_bug.cgi?id=173875
179
180         Reviewed by Tim Horton.
181
182         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
183
184 2017-07-03  Tim Horton  <timothy_horton@apple.com>
185
186         Expose WebPreferences for viewport-fit and constant() properties
187         https://bugs.webkit.org/show_bug.cgi?id=174072
188         <rdar://problem/33096639>
189
190         Reviewed by Ryosuke Niwa.
191
192         * WebView/WebPreferenceKeysPrivate.h:
193         * WebView/WebPreferences.mm:
194         (-[WebPreferences viewportFitEnabled]):
195         (-[WebPreferences setViewportFitEnabled:]):
196         (-[WebPreferences constantPropertiesEnabled]):
197         (-[WebPreferences setConstantPropertiesEnabled:]):
198         * WebView/WebPreferencesPrivate.h:
199         * WebView/WebView.mm:
200         (-[WebView _preferencesChanged:]):
201
202 2017-07-01  Tim Horton  <timothy_horton@apple.com>
203
204         Expose viewport-fit value to UIKit via viewport arguments dictionary
205         https://bugs.webkit.org/show_bug.cgi?id=174071
206         <rdar://problem/33096620>
207
208         Reviewed by Wenson Hsieh.
209
210         * History/WebHistoryItem.mm:
211         * History/WebHistoryItemPrivate.h:
212         Add another dictionary key and three values.
213
214 2017-07-01  Dan Bernstein  <mitz@apple.com>
215
216         [iOS] Remove code only needed when building for iOS 9.x
217         https://bugs.webkit.org/show_bug.cgi?id=174068
218
219         Reviewed by Tim Horton.
220
221         * Configurations/FeatureDefines.xcconfig:
222
223 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
224
225         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
226         https://bugs.webkit.org/show_bug.cgi?id=174004
227
228         Reviewed by Simon Fraser.
229
230         * WebCoreSupport/WebPluginInfoProvider.mm:
231
232 2017-07-01  Dan Bernstein  <mitz@apple.com>
233
234         [macOS] Remove code only needed when building for OS X Yosemite
235         https://bugs.webkit.org/show_bug.cgi?id=174067
236
237         Reviewed by Tim Horton.
238
239         * Configurations/Base.xcconfig:
240         * Configurations/DebugRelease.xcconfig:
241         * Configurations/FeatureDefines.xcconfig:
242         * Configurations/Version.xcconfig:
243         * Plugins/WebBasePluginPackage.mm:
244         (-[WebBasePluginPackage getPluginInfoFromPLists]):
245         * WebCoreSupport/PopupMenuMac.mm:
246         (PopupMenuMac::show):
247         * WebCoreSupport/WebInspectorClient.mm:
248         (WebInspectorFrontendClient::startWindowDrag):
249         (-[WebInspectorWindowController window]):
250         * WebView/WebView.mm:
251         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
252
253 2017-06-30  Daniel Bates  <dabates@apple.com>
254
255         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
256         https://bugs.webkit.org/show_bug.cgi?id=165160
257         <rdar://problem/29451999>
258
259         Reviewed by Brady Eidson.
260
261         Pass the document that is requesting the load to the loader.
262
263         * WebView/WebPDFView.mm:
264         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
265
266 2017-06-29  Jer Noble  <jer.noble@apple.com>
267
268         Make Legacy EME API controlled by RuntimeEnabled setting.
269         https://bugs.webkit.org/show_bug.cgi?id=173994
270
271         Reviewed by Sam Weinig.
272
273         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
274
275         * Configurations/FeatureDefines.xcconfig:
276         * WebView/WebPreferenceKeysPrivate.h:
277         * WebView/WebPreferences.mm:
278         (+[WebPreferences initialize]):
279         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
280         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
281         * WebView/WebPreferencesPrivate.h:
282         * WebView/WebView.mm:
283         (-[WebView _preferencesChanged:]):
284
285 2017-06-30  Chris Dumez  <cdumez@apple.com>
286
287         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
288         https://bugs.webkit.org/show_bug.cgi?id=174013
289
290         Reviewed by Brent Fulgham.
291
292         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
293         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
294
295         * WebView/WebView.mm:
296         (-[WebView _commonInitializationWithFrameName:groupName:]):
297
298 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
299
300         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
301         https://bugs.webkit.org/show_bug.cgi?id=174017
302         <rdar://problem/32959782>
303
304         Reviewed by Simon Fraser.
305
306         Use root view coordinates when computing the drag caret rect.
307
308         * WebView/WebView.mm:
309         (-[WebView _dataInteractionCaretRect]):
310
311 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
312
313         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
314         https://bugs.webkit.org/show_bug.cgi?id=173899
315         rdar://problem/32994474
316
317         Reviewed by Tim Horton.
318
319         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
320         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
321         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
322
323         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
324         documentView is a WebHTMLView.
325
326         * WebView/WebFrame.mm:
327         (-[WebFrame _webHTMLDocumentView]):
328         (-[WebFrame _paintBehaviorForDestinationContext:]):
329         (-[WebFrame _drawRect:contentsOnly:]):
330         (-[WebFrame setTimeoutsPaused:]):
331         (-[WebFrame prepareForPause]):
332         (-[WebFrame resumeFromPause]):
333         (-[WebFrame resetTextAutosizingBeforeLayout]):
334         * WebView/WebHTMLView.mm:
335         (-[WebHTMLView drawLayer:inContext:]):
336         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
337         * WebView/WebHTMLViewInternal.h:
338
339 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
340
341         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
342         https://bugs.webkit.org/show_bug.cgi?id=173854
343         <rdar://problem/32236827>
344
345         Reviewed by Ryosuke Niwa and Tim Horton.
346
347         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
348         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
349
350         * WebView/WebView.mm:
351         (-[WebView _startDrag:]):
352         (-[WebView _dragSourceAction]):
353         (-[WebView _draggedLinkTitle]):
354         (-[WebView _draggedLinkURL]):
355         (-[WebView _draggedElementBounds]):
356         (-[WebView _endedDataInteraction:global:]):
357         * WebView/WebViewData.h:
358         * WebView/WebViewPrivate.h:
359
360 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
361
362         Refactor drag start codepaths to plumb a DragItem to client layers
363         https://bugs.webkit.org/show_bug.cgi?id=173832
364         Work towards <rdar://problem/32236827>
365
366         Reviewed by Ryosuke Niwa and Tim Horton.
367
368         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
369         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
370         to _startDrag: to match logic used to start a drag on other platforms.
371
372         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
373         through the DragItem struct.
374
375         * WebCoreSupport/WebDragClient.h:
376         * WebCoreSupport/WebDragClient.mm:
377         (WebDragClient::startDrag):
378         (WebDragClient::dragSourceActionMaskForPoint):
379         (WebDragClient::willPerformDragSourceAction):
380         (WebDragClient::beginDrag):
381         * WebView/WebView.mm:
382         (-[WebView _startDrag:]):
383         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
384         * WebView/WebViewInternal.h:
385
386 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
387
388         Remove excessive headers from JavaScriptCore
389         https://bugs.webkit.org/show_bug.cgi?id=173812
390
391         Reviewed by Darin Adler.
392
393         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
394         * WebView/WebView.mm:
395
396 2017-06-23  Tim Horton  <timothy_horton@apple.com>
397
398         Remove an unused typedef from WebFrameLoaderClient
399         https://bugs.webkit.org/show_bug.cgi?id=173795
400
401         Reviewed by Simon Fraser.
402
403         * WebCoreSupport/WebFrameLoaderClient.h:
404         This unused typedef in the global namespace conflicts with one in a macOS system header.
405         Also... it's unused.
406         Remove it.
407
408 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
409
410         Remove excessive headers from WebCore/{bindings,css,dom}
411         https://bugs.webkit.org/show_bug.cgi?id=173766
412
413         Reviewed by Simon Fraser.
414
415         * DOM/DOMInternal.mm:
416
417 2017-06-22  Daniel Bates  <dabates@apple.com>
418
419         Make FrameLoadRequest a move-only type
420         https://bugs.webkit.org/show_bug.cgi?id=173682
421
422         Reviewed by Alex Christensen and Darin Adler.
423
424         A FrameLoadRequest groups together the information to perform a load into a single object
425         that is more manageable to pass around than its constituent parts. Code that receives a
426         FrameLoadRequest is expected to extract out the information it needs to complete its task.
427         And it does not make sense to re-use the same FrameLoadRequest object for more than one
428         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
429
430         * Plugins/WebPluginController.mm:
431         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
432         * WebView/WebPDFView.mm:
433         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
434
435 2017-06-21  Antoine Quint  <graouts@apple.com>
436
437         Ensure DRT always logs rAF suspension debugging code
438         https://bugs.webkit.org/show_bug.cgi?id=173681
439
440         Reviewed by Tim "Mr. T" Horton.
441
442         * WebView/WebPreferenceKeysPrivate.h:
443         * WebView/WebPreferences.mm:
444         (+[WebPreferences initialize]):
445         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
446         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
447         * WebView/WebPreferencesPrivate.h:
448         * WebView/WebView.mm:
449         (-[WebView _preferencesChanged:]):
450
451 2017-06-21  Daniel Bates  <dabates@apple.com>
452
453         Cleanup FrameLoadRequest
454         https://bugs.webkit.org/show_bug.cgi?id=173564
455         <rdar://problem/32903570>
456
457         Reviewed by Brent Fulgham.
458
459         * WebView/WebPDFView.mm:
460         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
461         into a local variable and use C++11 brace initialization syntax to make it easier to identify
462         the arguments passed to FrameLoader::loadFrameRequest().
463
464 2017-06-21  Antoine Quint  <graouts@apple.com>
465
466         Add logging to identify when the Page suspends scripted animations
467         https://bugs.webkit.org/show_bug.cgi?id=173626
468
469         Reviewed by Tim Horton.
470
471         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
472         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
473
474         * WebView/WebPreferenceKeysPrivate.h:
475         * WebView/WebPreferences.mm:
476         (+[WebPreferences initialize]):
477         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
478         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
479         * WebView/WebPreferencesPrivate.h:
480         * WebView/WebView.mm:
481         (-[WebView _preferencesChanged:]):
482
483 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
484
485         Disable font variations on macOS Sierra and iOS 10
486         https://bugs.webkit.org/show_bug.cgi?id=173618
487         <rdar://problem/32879164>
488
489         Reviewed by Jon Lee.
490
491         * Configurations/FeatureDefines.xcconfig:
492
493 2017-06-20  Daniel Bates  <dabates@apple.com>
494
495         Have FrameLoadRequest takes a Frame& instead of a Frame*
496         https://bugs.webkit.org/show_bug.cgi?id=173614
497         <rdar://problem/32884890>
498
499         Reviewed by Brent Fulgham.
500
501         * Plugins/WebPluginController.mm:
502         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
503         * WebView/WebFrame.mm:
504         (-[WebFrame loadRequest:]):
505         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
506
507 2017-06-19  Frederic Wang  <fwang@igalia.com>
508
509         [Mac] Add an experimental feature setting for async frame scrolling
510         https://bugs.webkit.org/show_bug.cgi?id=173359
511
512         Reviewed by Simon Fraser.
513
514         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
515         * WebView/WebPreferences.mm:
516         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
517         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
518         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
519         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
520         * WebView/WebView.mm:
521         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
522         scrolling.
523
524 2017-06-19  Chris Dumez  <cdumez@apple.com>
525
526         Use WTF::Function instead of std::function in more places in WebCore/
527         https://bugs.webkit.org/show_bug.cgi?id=173535
528
529         Reviewed by Antti Koivisto.
530
531         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
532
533         * WebCoreSupport/WebFrameLoaderClient.h:
534         * WebCoreSupport/WebFrameLoaderClient.mm:
535         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
536         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
537         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
538         (WebFrameLoaderClient::dispatchWillSubmitForm):
539         (WebFrameLoaderClient::setUpPolicyListener):
540         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
541         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
542
543 2017-05-14 Frederic Wang  <fwang@igalia.com>
544
545         Add heuristic to avoid flattening "fullscreen" iframes
546         https://bugs.webkit.org/show_bug.cgi?id=171914
547
548         Reviewed by Simon Fraser.
549
550         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
551
552         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
553         * WebView/WebPreferences.mm:
554         (+[WebPreferences initialize]): Handle frame flattening as an enum.
555         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
556         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
557         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
558         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
559         * WebView/WebPreferencesPrivate.h: Ditto.
560         * WebView/WebView.mm:
561         (-[WebView _preferencesChanged:]): Ditto.
562         * WebView/WebPreferencesPrivate.h: Add new enum definition.
563
564 2017-06-17  Chris Dumez  <cdumez@apple.com>
565
566         Use WTF::Function instead of std::function in WebKit2/
567         https://bugs.webkit.org/show_bug.cgi?id=173504
568
569         Reviewed by Darin Adler.
570
571         Use WTF::Function instead of std::function in WebKit2/ to avoid
572         unnecessary copying.
573
574         * Plugins/Hosted/HostedNetscapePluginStream.h:
575         * Plugins/Hosted/HostedNetscapePluginStream.mm:
576         (WebKit::HostedNetscapePluginStream::willSendRequest):
577         * Plugins/WebNetscapePluginStream.h:
578         * Plugins/WebNetscapePluginStream.mm:
579         (WebNetscapePluginStream::willSendRequest):
580         * WebCoreSupport/WebPaymentCoordinatorClient.h:
581         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
582         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
583         (WebPaymentCoordinatorClient::openPaymentSetup):
584
585 2017-06-16  Sam Weinig  <sam@webkit.org>
586
587         [WebIDL] Remove custom bindings for HTMLDocument
588         https://bugs.webkit.org/show_bug.cgi?id=173444
589
590         Reviewed by Darin Adler.
591
592         * DOM/DOMHTMLDocument.mm:
593         (-[DOMHTMLDocument linkColor]):
594         (-[DOMHTMLDocument setLinkColor:]):
595         (-[DOMHTMLDocument write:]):
596         (-[DOMHTMLDocument writeln:]):
597         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
598
599 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
600
601         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
602         https://bugs.webkit.org/show_bug.cgi?id=173366
603         <rdar://problem/32767014>
604
605         Reviewed by Tim Horton.
606
607         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
608
609         * Configurations/FeatureDefines.xcconfig:
610         * WebCoreSupport/WebDragClient.mm:
611         (WebDragClient::useLegacyDragClient):
612         (WebDragClient::willPerformDragDestinationAction):
613         (WebDragClient::dragSourceActionMaskForPoint):
614         (WebDragClient::willPerformDragSourceAction):
615         (WebDragClient::startDrag):
616         (WebDragClient::beginDrag):
617         (WebDragClient::declareAndWriteDragImage):
618         (WebDragClient::declareAndWriteAttachment):
619         (WebDragClient::didConcludeEditDrag):
620         * WebView/WebView.mm:
621         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
622         (-[WebView _getDataInteractionData]):
623         (-[WebView dragDataForSession:client:global:operation:]):
624         (-[WebView _enteredDataInteraction:client:global:operation:]):
625         (-[WebView _updatedDataInteraction:client:global:operation:]):
626         (-[WebView _exitedDataInteraction:client:global:operation:]):
627         (-[WebView _performDataInteraction:client:global:operation:]):
628         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
629         (-[WebView _endedDataInteraction:global:]):
630         (-[WebView _didConcludeEditDataInteraction]):
631         (floatRectsForCGRectArray): Deleted.
632         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
633         * WebView/WebViewData.h:
634         * WebView/WebViewData.mm:
635         (-[WebViewPrivate dealloc]):
636         * WebView/WebViewPrivate.h:
637
638 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
639
640         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
641         https://bugs.webkit.org/show_bug.cgi?id=173454
642         <rdar://problem/31720671>
643
644         Reviewed by Tim Horton.
645
646         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
647         If unimplemented, the default UI delegate allows all actions except for URL loading.
648
649         * DefaultDelegates/WebDefaultUIDelegate.mm:
650         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
651         * WebView/WebUIDelegatePrivate.h:
652         * WebView/WebView.mm:
653         (-[WebView dragDestinationActionMaskForSession:]):
654
655 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
656
657         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
658         https://bugs.webkit.org/show_bug.cgi?id=173338
659         <rdar://problem/32777720>
660
661         Reviewed by Tim Horton.
662
663         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
664
665         * WebCoreSupport/WebPlatformStrategies.h:
666         * WebCoreSupport/WebPlatformStrategies.mm:
667         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
668         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
669
670 2017-06-13  Daniel Bates  <dabates@apple.com>
671
672         Implement W3C Secure Contexts Draft Specification
673         https://bugs.webkit.org/show_bug.cgi?id=158121
674         <rdar://problem/26012994>
675
676         Reviewed by Brent Fulgham.
677
678         Part 4
679
680         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
681
682         * WebView/WebPreferenceKeysPrivate.h:
683         * WebView/WebPreferences.mm:
684         (+[WebPreferences initialize]):
685         (-[WebPreferences isSecureContextAttributeEnabled]):
686         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
687         * WebView/WebPreferencesPrivate.h:
688         * WebView/WebView.mm:
689         (-[WebView _preferencesChanged:]):
690
691 2017-06-13  Sam Weinig  <sam@webkit.org>
692
693         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
694         https://bugs.webkit.org/show_bug.cgi?id=80733
695
696         Reviewed by Chris Dumez.
697
698         * DOM/DOMUtility.mm:
699         (createDOMWrapper):
700         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
701         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
702         * WebView/WebFrame.mm:
703         (-[WebFrame _attachScriptDebugger]):
704         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
705
706 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
707
708         [WebCrypto] Remove experimental feature flag of SubtleCrypto
709         https://bugs.webkit.org/show_bug.cgi?id=173197
710         <rdar://problem/32688148>
711
712         Reviewed by Brent Fulgham.
713
714         * WebView/WebPreferences.mm:
715         (+[WebPreferences initialize]):
716         (-[WebPreferences subtleCryptoEnabled]): Deleted.
717         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
718         * WebView/WebPreferencesPrivate.h:
719         * WebView/WebView.mm:
720         (-[WebView _preferencesChanged:]):
721
722 2017-06-10  Dan Bernstein  <mitz@apple.com>
723
724         Reverted r218056 because it made the IDE reindex constantly.
725
726         * Configurations/DebugRelease.xcconfig:
727
728 2017-06-10  Dan Bernstein  <mitz@apple.com>
729
730         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
731         https://bugs.webkit.org/show_bug.cgi?id=173223
732
733         Reviewed by Sam Weinig.
734
735         The rebuilds were happening due to a difference in the compiler options that the IDE and
736         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
737         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
738         specify an appropriate path in CLANG_INDEX_STORE_PATH.
739
740         * Configurations/DebugRelease.xcconfig:
741
742 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
743
744         [iOS DnD] Add a hook to perform two-step drops in editable content
745         https://bugs.webkit.org/show_bug.cgi?id=172992
746         <rdar://problem/32590174>
747
748         Reviewed by Tim Horton.
749
750         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
751         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
752         returning NO will continue with default WebKit behavior.
753
754         * WebCoreSupport/WebEditorClient.h:
755         * WebCoreSupport/WebEditorClient.mm:
756         (WebEditorClient::performTwoStepDrop):
757
758 2017-06-08  Jer Noble  <jer.noble@apple.com>
759
760         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
761         https://bugs.webkit.org/show_bug.cgi?id=173091
762
763         Reviewed by Eric Carlson.
764
765         * WebView/WebPreferences.mm:
766         (+[WebPreferences initialize]):
767
768 2017-06-07  Jer Noble  <jer.noble@apple.com>
769
770         Clean-up: RenderElement.h includes headers it doesn't use
771         https://bugs.webkit.org/show_bug.cgi?id=173046
772
773         Reviewed by Andy Estes.
774
775         * WebView/WebImmediateActionController.mm:
776
777 2017-06-07  Zalan Bujtas  <zalan@apple.com>
778
779         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
780         https://bugs.webkit.org/show_bug.cgi?id=173044
781         <rdar://problem/32449338>
782
783         Reviewed by Tim Horton.
784
785         Cache the current device orientation so that we don't have to lift the WebThread lock
786         to collect it.
787
788         * WebView/WebFrame.mm:
789         (-[WebFrame deviceOrientationChanged]):
790         * WebView/WebView.mm:
791         (-[WebView _commonInitializationWithFrameName:groupName:]):
792         (-[WebView _setDeviceOrientation:]):
793         (-[WebView _deviceOrientation]):
794         * WebView/WebViewData.h:
795         * WebView/WebViewInternal.h:
796
797 2017-06-06  Jer Noble  <jer.noble@apple.com>
798
799         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
800         https://bugs.webkit.org/show_bug.cgi?id=173008
801
802         Reviewed by Eric Carlson.
803
804         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
805
806         * WebView/WebPreferenceKeysPrivate.h:
807         * WebView/WebPreferences.mm:
808         (+[WebPreferences initialize]):
809         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
810         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
811         * WebView/WebPreferencesPrivate.h:
812         * WebView/WebView.mm:
813         (-[WebView _preferencesChanged:]):
814
815 2017-06-06  Youenn Fablet  <youenn@apple.com>
816
817         Add an option to disable getUserMedia prompt in case of mock capture sources
818         https://bugs.webkit.org/show_bug.cgi?id=172981
819         <rdar://problem/32580325>
820
821         Reviewed by Eric Carlson.
822
823         Defining the option, getter and setter.
824
825         * WebView/WebPreferences.mm:
826         (+[WebPreferences initialize]):
827         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
828         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
829         * WebView/WebPreferencesPrivate.h:
830
831 2017-06-05  Dan Bernstein  <mitz@apple.com>
832
833         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
834
835         * WebView/WebView.mm:
836         (-[WebView updateMediaTouchBar]):
837         * WebView/WebViewData.h:
838
839 2017-06-03  Darin Adler  <darin@apple.com>
840
841         Streamline handling of attributes, using references as much as possible
842         https://bugs.webkit.org/show_bug.cgi?id=172899
843
844         Reviewed by Chris Dumez.
845
846         * WebView/WebHTMLRepresentation.mm:
847         (matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
848         passed in element can't be null. Removed unnecessary conversion from NSString to String
849         and then back to NSString.
850
851 2017-06-01  Andy Estes  <aestes@apple.com>
852
853         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
854         https://bugs.webkit.org/show_bug.cgi?id=172828
855
856         Reviewed by Beth Dakin.
857
858         * Configurations/FeatureDefines.xcconfig:
859
860 2017-05-31  Andy Estes  <aestes@apple.com>
861
862         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
863         https://bugs.webkit.org/show_bug.cgi?id=172366
864
865         Reviewed by Daniel Bates.
866
867         * Configurations/FeatureDefines.xcconfig:
868
869 2017-05-30  Ryosuke Niwa  <rniwa@webkit.org>
870
871         Only include DataDetectorsUI headers in iOS
872         https://bugs.webkit.org/show_bug.cgi?id=172633
873
874         Reviewed by David Kilzer.
875
876         Enable data detectors only on iOS and not other variants of iOS.
877
878         * WebCoreSupport/WebFrameLoaderClient.mm:
879
880 2017-05-30  Alex Christensen  <achristensen@webkit.org>
881
882         Update libwebrtc configuration
883         https://bugs.webkit.org/show_bug.cgi?id=172727
884
885         Reviewed by Geoffrey Garen.
886
887         * Configurations/FeatureDefines.xcconfig:
888
889 2017-05-28  Dan Bernstein  <mitz@apple.com>
890
891         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
892         https://bugs.webkit.org/show_bug.cgi?id=172691
893
894         Reviewed by Tim Horton.
895
896         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
897
898 2017-05-26  Brent Fulgham  <bfulgham@apple.com>
899
900         [WK2] Address thread safety issues with ResourceLoadStatistics
901         https://bugs.webkit.org/show_bug.cgi?id=172519
902         <rdar://problem/31707642>
903
904         Reviewed by Chris Dumez.
905
906         Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
907
908         * WebView/WebView.mm:
909         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
910
911 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
912
913         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
914         https://bugs.webkit.org/show_bug.cgi?id=172554
915         <rdar://problem/31247133>
916
917         Reviewed by Simon Fraser.
918
919         Update an overridden internal AppKit function to the new signature.
920
921         * WebView/WebHTMLView.mm:
922         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
923         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
924         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
925         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
926
927 2017-05-24  Jer Noble  <jer.noble@apple.com>
928
929         Rename DisplaySleepDisabler -> SleepDisabler
930         https://bugs.webkit.org/show_bug.cgi?id=172478
931
932         Reviewed by Sam Weinig.
933
934         * WebView/WebFullScreenController.h:
935
936 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
937
938         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
939         https://bugs.webkit.org/show_bug.cgi?id=172522
940         rdar://problem/31071812
941
942         Reviewed by Tim Horton.
943
944         There's no need to consult -[NSWindow viewsNeedDisplay] on newer OSes. It was
945         added in r58623, and modified in r61204 for Carbon apps, but with more recent AppKit
946         versions this synchronization is no longer required.
947
948         * WebView/WebView.mm:
949         (LayerFlushController::flushLayers):
950
951 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
952
953         Snapshotting via -renderInContext: should do synchronous image decodes
954         https://bugs.webkit.org/show_bug.cgi?id=172485
955         rdar://problem/32276146
956
957         Reviewed by Tim Horton.
958
959         Remove the _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap: SPI that no longer
960         has any callers.
961
962         * Plugins/WebBaseNetscapePluginView.h:
963         * Plugins/WebBaseNetscapePluginView.mm:
964         (-[WebBaseNetscapePluginView inFlatteningPaint]): Deleted.
965         * WebView/WebFrame.mm:
966         (-[WebFrame _paintBehaviorForDestinationContext:]):
967         (-[WebFrame _drawRect:contentsOnly:]):
968         (-[WebFrame _shouldFlattenCompositingLayers:]): Deleted.
969         * WebView/WebHTMLView.mm:
970         (imageFromRect):
971         * WebView/WebView.mm:
972         (-[WebView _commonInitializationWithFrameName:groupName:]):
973         (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): Deleted.
974         (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): Deleted.
975         * WebView/WebViewData.h:
976         * WebView/WebViewPrivate.h:
977
978 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
979
980         Remove dead ENABLE(FONT_LOAD_EVENTS) code
981         https://bugs.webkit.org/show_bug.cgi?id=172517
982
983         Rubber-stamped by Simon Fraser.
984
985         * Configurations/FeatureDefines.xcconfig:
986
987 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
988
989         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
990         https://bugs.webkit.org/show_bug.cgi?id=171984
991
992         Reviewed by Antti Koivisto.
993
994         * WebView/WebPreferenceKeysPrivate.h:
995         * WebView/WebPreferences.mm:
996         (+[WebPreferences initialize]):
997         (-[WebPreferences displayContentsEnabled]):
998         (-[WebPreferences setDisplayContentsEnabled:]):
999         * WebView/WebPreferencesPrivate.h:
1000         * WebView/WebView.mm:
1001         (-[WebView _preferencesChanged:]):
1002
1003 2017-05-22  Youenn Fablet  <youenn@apple.com>
1004
1005         Remove AVAudioCaptureSource
1006         https://bugs.webkit.org/show_bug.cgi?id=172360
1007
1008         Reviewed by Sam Weinig.
1009
1010         Removing the handling of AVAudio/CoreAudio capture source dynamic switch.
1011
1012         * WebView/WebPreferenceKeysPrivate.h:
1013         * WebView/WebPreferences.mm:
1014         (+[WebPreferences initialize]):
1015         (-[WebPreferences useAVFoundationAudioCapture]): Deleted.
1016         (-[WebPreferences setUseAVFoundationAudioCapture:]): Deleted.
1017         * WebView/WebPreferencesPrivate.h:
1018         * WebView/WebView.mm:
1019         (-[WebView _preferencesChanged:]):
1020
1021 2017-05-22  Sam Weinig  <sam@webkit.org>
1022
1023         [WebIDL] Support callbacks with arbitrary return types
1024         https://bugs.webkit.org/show_bug.cgi?id=172407
1025
1026         Reviewed by Chris Dumez.
1027
1028         * DOM/DOM.mm:
1029         (-[DOMNodeFilter acceptNode:]):
1030         Update for CallbackResult adoption in the base class.
1031
1032         * DOM/DOMNodeIterator.mm:
1033         * DOM/DOMTreeWalker.mm:
1034         Update to account for new WebCore implementation return types. We return nil
1035         if there was an exception, since retains the existing behavior if a javascript
1036         NodeFilter had been used (an exception would cause all nodes to be rejected,
1037         thus returning nullptr).
1038
1039         * DOM/ObjCNodeFilterCondition.h:
1040         * DOM/ObjCNodeFilterCondition.mm:
1041         Update to match new interface of NodeFilterCondition.
1042
1043 2017-05-18  Sam Weinig  <sam@webkit.org>
1044
1045         [WebIDL] Remove the need for the generator to know about native type mapping
1046         https://bugs.webkit.org/show_bug.cgi?id=172310
1047
1048         Reviewed by Darin Adler.
1049
1050         * DOM/DOM.mm:
1051         (-[DOMNodeFilter acceptNode:]):
1052         Update to pass Node by reference.
1053
1054 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1055
1056         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
1057         https://bugs.webkit.org/show_bug.cgi?id=172098
1058
1059         Reviewed by Saam Barati.
1060
1061         * Plugins/Hosted/ProxyInstance.mm:
1062         * Plugins/Hosted/ProxyRuntimeObject.mm:
1063
1064 2017-05-18  Andy Estes  <aestes@apple.com>
1065
1066         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
1067         https://bugs.webkit.org/show_bug.cgi?id=172305
1068
1069         Reviewed by Anders Carlsson.
1070
1071         * Configurations/FeatureDefines.xcconfig:
1072
1073 2017-05-18  Commit Queue  <commit-queue@webkit.org>
1074
1075         Unreviewed, rolling out r217031, r217032, and r217037.
1076         https://bugs.webkit.org/show_bug.cgi?id=172293
1077
1078         cause linking errors in Windows (Requested by yusukesuzuki on
1079         #webkit).
1080
1081         Reverted changesets:
1082
1083         "[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass"
1084         https://bugs.webkit.org/show_bug.cgi?id=172098
1085         http://trac.webkit.org/changeset/217031
1086
1087         "Unreviewed, rebaseline for newly added ClassInfo"
1088         https://bugs.webkit.org/show_bug.cgi?id=172098
1089         http://trac.webkit.org/changeset/217032
1090
1091         "Unreviewed, fix debug and non-JIT build"
1092         https://bugs.webkit.org/show_bug.cgi?id=172098
1093         http://trac.webkit.org/changeset/217037
1094
1095 2017-05-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1096
1097         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
1098         https://bugs.webkit.org/show_bug.cgi?id=172098
1099
1100         Reviewed by Saam Barati.
1101
1102         * Plugins/Hosted/ProxyInstance.mm:
1103         * Plugins/Hosted/ProxyRuntimeObject.mm:
1104
1105 2017-05-17  Matt Lewis  <jlewis3@apple.com>
1106
1107         Unreviewed, rolling out r216974.
1108
1109         Revision caused consistent timeouts on all platforms.
1110
1111         Reverted changeset:
1112
1113         "Add a RuntimeEnabledFeature for display: contents, defaulted
1114         to false."
1115         https://bugs.webkit.org/show_bug.cgi?id=171984
1116         http://trac.webkit.org/changeset/216974
1117
1118 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
1119
1120         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1121         https://bugs.webkit.org/show_bug.cgi?id=171984
1122
1123         Reviewed by Antti Koivisto.
1124
1125         * WebView/WebPreferenceKeysPrivate.h:
1126         * WebView/WebPreferences.mm:
1127         (+[WebPreferences initialize]):
1128         (-[WebPreferences displayContentsEnabled]):
1129         (-[WebPreferences setDisplayContentsEnabled:]):
1130         * WebView/WebPreferencesPrivate.h:
1131         * WebView/WebView.mm:
1132         (-[WebView _preferencesChanged:]):
1133
1134 2017-05-16  Sam Weinig  <sam@webkit.org>
1135
1136         Bring Notification.idl up to spec
1137         https://bugs.webkit.org/show_bug.cgi?id=172156
1138
1139         Reviewed by Chris Dumez.
1140
1141         * WebCoreSupport/WebNotificationClient.h:
1142         * WebCoreSupport/WebNotificationClient.mm:
1143         (generateNotificationID):
1144         (WebNotificationClient::show):
1145         (WebNotificationClient::cancel):
1146         (WebNotificationClient::clearNotifications):
1147         (WebNotificationClient::notificationObjectDestroyed):
1148         (WebNotificationClient::requestPermission):
1149         (WebNotificationClient::hasPendingPermissionRequests):
1150         (WebNotificationClient::checkPermission):
1151         (-[WebNotificationPolicyListener allow]):
1152         (-[WebNotificationPolicyListener deny]):
1153         * WebView/WebNotification.mm:
1154         (-[WebNotification iconURL]):
1155         (-[WebNotification dir]):
1156         Simplify #ifdefs and update for enum vs String usage.
1157
1158 2017-05-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
1159
1160         Do not delete asynchronously decoded frames for large images if their clients are in the viewport
1161         https://bugs.webkit.org/show_bug.cgi?id=170640
1162
1163         Reviewed by Simon Fraser.
1164
1165         Enable the async decoding for large images.
1166
1167         * WebView/WebView.mm:
1168         (-[WebView _preferencesChanged:]):
1169
1170 2017-05-15  Jer Noble  <jer.noble@apple.com>
1171
1172         Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement
1173         https://bugs.webkit.org/show_bug.cgi?id=172131
1174
1175         Reviewed by Eric Carlson.
1176
1177         * WebView/WebPreferenceKeysPrivate.h:
1178         * WebView/WebPreferences.mm:
1179         (+[WebPreferences initialize]):
1180         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
1181         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
1182         * WebView/WebPreferencesPrivate.h:
1183
1184 2017-05-12  Chris Dumez  <cdumez@apple.com>
1185
1186         Drop uses of PassRefPtr in WebKit/mac
1187         https://bugs.webkit.org/show_bug.cgi?id=172066
1188
1189         Reviewed by Sam Weinig.
1190
1191         * History/WebBackForwardListInternal.h:
1192         * History/WebHistoryItem.mm:
1193         (kit):
1194         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
1195         * History/WebHistoryItemInternal.h:
1196         * Plugins/Hosted/HostedNetscapePluginStream.h:
1197         (WebKit::HostedNetscapePluginStream::create):
1198         * Plugins/Hosted/NetscapePluginHostManager.h:
1199         * Plugins/Hosted/NetscapePluginHostManager.mm:
1200         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1201         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1202         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1203         (WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
1204         (WebKit::NetscapePluginInstanceProxy::create):
1205         (WebKit::NetscapePluginInstanceProxy::setManualStream):
1206         * Plugins/Hosted/ProxyInstance.h:
1207         (WebKit::ProxyInstance::create):
1208         * Plugins/Hosted/ProxyInstance.mm:
1209         (WebKit::ProxyInstance::ProxyInstance):
1210         (WebKit::ProxyInstance::newRuntimeObject):
1211         * Plugins/Hosted/ProxyRuntimeObject.h:
1212         (WebKit::ProxyRuntimeObject::create):
1213         * Plugins/Hosted/ProxyRuntimeObject.mm:
1214         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
1215         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1216         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1217         (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1218         * Plugins/WebBaseNetscapePluginView.h:
1219         * Plugins/WebBaseNetscapePluginView.mm:
1220         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1221         * Plugins/WebNetscapePluginStream.h:
1222         (WebNetscapePluginStream::create):
1223         * Plugins/WebNetscapePluginView.h:
1224         * Plugins/WebNetscapePluginView.mm:
1225         (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1226         * WebCoreSupport/WebChromeClient.mm:
1227         * WebCoreSupport/WebEditorClient.mm:
1228         * WebCoreSupport/WebNotificationClient.mm:
1229         (WebNotificationClient::requestPermission):
1230         (-[WebNotificationPolicyListener initWithCallback:]):
1231         * WebCoreSupport/WebOpenPanelResultListener.mm:
1232         * WebCoreSupport/WebUserMediaClient.mm:
1233         (WebUserMediaClient::requestUserMediaAccess):
1234         (WebUserMediaClient::enumerateMediaDevices):
1235         (-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
1236         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
1237         * WebView/WebArchive.mm:
1238         (-[WebArchivePrivate initWithCoreArchive:]):
1239         (-[WebArchivePrivate setCoreArchive:]):
1240         (-[WebArchive initWithData:]):
1241         (-[WebArchive subframeArchives]):
1242         (-[WebArchive _initWithCoreLegacyWebArchive:]):
1243         * WebView/WebArchiveInternal.h:
1244         * WebView/WebDataSource.mm:
1245         (WebDataSourcePrivate::WebDataSourcePrivate):
1246         (WebDataSourcePrivate::~WebDataSourcePrivate):
1247         (-[WebDataSource _initWithDocumentLoader:]):
1248         * WebView/WebDataSourceInternal.h:
1249         * WebView/WebDeviceOrientation.mm:
1250         (-[WebDeviceOrientation initWithCoreDeviceOrientation:]):
1251         * WebView/WebDeviceOrientationInternal.h:
1252         * WebView/WebFrame.mm:
1253         (-[WebFrame _convertToDOMRange:]):
1254         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
1255         * WebView/WebFrameInternal.h:
1256         * WebView/WebFullScreenController.h:
1257         * WebView/WebFullScreenController.mm:
1258         (-[WebFullScreenController setElement:]):
1259         * WebView/WebGeolocationPosition.mm:
1260         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1261         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1262         * WebView/WebHTMLView.mm:
1263         (currentKeyboardEvent):
1264         * WebView/WebResource.mm:
1265         * WebView/WebScriptWorld.mm:
1266         (-[WebScriptWorld initWithWorld:]):
1267         (+[WebScriptWorld standardWorld]):
1268         (+[WebScriptWorld findOrCreateWorld:]):
1269         * WebView/WebViewData.h:
1270         (LayerFlushController::create):
1271
1272 2017-05-11  Chris Dumez  <cdumez@apple.com>
1273
1274         Drop remaining uses of PassRefPtr in WebCore
1275         https://bugs.webkit.org/show_bug.cgi?id=172013
1276
1277         Reviewed by Yusuke Suzuki.
1278
1279         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1280         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1281         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
1282         (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
1283         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1284         (-[WebHostedNetscapePluginView createPluginBindingsInstance:]):
1285
1286 2017-05-11  Tim Horton  <timothy_horton@apple.com>
1287
1288         Mail spins launching spell checker when typing
1289         https://bugs.webkit.org/show_bug.cgi?id=171986
1290         <rdar://problem/26305327>
1291
1292         Reviewed by Beth Dakin.
1293
1294         * WebView/WebView.mm:
1295         (-[WebView setEditable:]):
1296         Asynchronously pre-warm the spell checker when a WebView becomes editable.
1297
1298 2017-05-09  Sam Weinig  <sam@webkit.org>
1299
1300         Remove support for legacy Notifications
1301         https://bugs.webkit.org/show_bug.cgi?id=171487
1302
1303         Reviewed by Jon Lee.
1304
1305         * Configurations/FeatureDefines.xcconfig:
1306         * WebCoreSupport/WebNotificationClient.h:
1307         * WebCoreSupport/WebNotificationClient.mm:
1308         * WebView/WebNotification.mm:
1309         * WebView/WebNotificationInternal.h:
1310         * WebView/WebView.mm:
1311         (-[WebView _commonInitializationWithFrameName:groupName:]):
1312         (-[WebView _notificationIDForTesting:]):
1313         Remove legacy notification specific code.
1314
1315 2017-05-10  Chris Dumez  <cdumez@apple.com>
1316
1317         Simplify relationship between Attr and Element now that Attr is childless
1318         https://bugs.webkit.org/show_bug.cgi?id=171909
1319
1320         Reviewed by Ryosuke Niwa.
1321
1322         Build fix.
1323
1324         * DOM/DOMAttr.mm:
1325         (-[DOMAttr value]):
1326         (-[DOMAttr setValue:]):
1327
1328 2017-05-08  Chris Dumez  <cdumez@apple.com>
1329
1330         Move 'style' from Element to HTMLElement / SVGElement and make it settable
1331         https://bugs.webkit.org/show_bug.cgi?id=171795
1332
1333         Reviewed by Alex Christensen.
1334
1335         Build fix.
1336
1337         * DOM/DOMElement.mm:
1338         (-[DOMElement style]):
1339         * WebCoreSupport/WebEditorClient.mm:
1340         (WebEditorClient::shouldApplyStyle):
1341         * WebView/WebFrame.mm:
1342         (-[WebFrame _typingStyle]):
1343
1344 2017-05-06  Chris Dumez  <cdumez@apple.com>
1345
1346         Align our IDL files with the latest DOM specification
1347         https://bugs.webkit.org/show_bug.cgi?id=171777
1348
1349         Reviewed by Sam Weinig.
1350
1351         Build fix.
1352
1353         * DOM/DOMDocument.mm:
1354         (-[DOMDocument readyState]):
1355
1356 2017-05-05  Jeremy Jones  <jeremyj@apple.com>
1357
1358         REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
1359         https://bugs.webkit.org/show_bug.cgi?id=171610
1360         <rdar://problem/31976820>
1361
1362         Reviewed by Eric Carlson.
1363
1364         Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
1365
1366         * WebCoreSupport/WebChromeClient.h:
1367         * WebCoreSupport/WebChromeClient.mm:
1368         (WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
1369
1370 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1371
1372         Unreviewed, rolling out r216206.
1373         https://bugs.webkit.org/show_bug.cgi?id=171714
1374
1375         Multiple LayoutTests crashing in Document::page() (Requested
1376         by ap on #webkit).
1377
1378         Reverted changeset:
1379
1380         "Remove support for legacy Notifications"
1381         https://bugs.webkit.org/show_bug.cgi?id=171487
1382         http://trac.webkit.org/changeset/216206
1383
1384 2017-05-04  Jeremy Jones  <jeremyj@apple.com>
1385
1386         UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
1387         https://bugs.webkit.org/show_bug.cgi?id=171704
1388
1389         Reviewed by Jer Noble.
1390
1391         Fix build by casting result of +whiteColor to UIColor.
1392
1393         * WebView/WebView.mm:
1394         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
1395
1396 2017-05-04  Sam Weinig  <sam@webkit.org>
1397
1398         Remove support for legacy Notifications
1399         https://bugs.webkit.org/show_bug.cgi?id=171487
1400
1401         Reviewed by Jon Lee.
1402
1403         * Configurations/FeatureDefines.xcconfig:
1404         * WebCoreSupport/WebNotificationClient.h:
1405         * WebCoreSupport/WebNotificationClient.mm:
1406         * WebView/WebNotification.mm:
1407         * WebView/WebNotificationInternal.h:
1408         * WebView/WebView.mm:
1409         (-[WebView _commonInitializationWithFrameName:groupName:]):
1410         (-[WebView _notificationIDForTesting:]):
1411         Remove legacy notification specific code.
1412
1413 2017-05-03  Joseph Pecoraro  <pecoraro@apple.com>
1414
1415         [Cocoa] Stop exporting symbols for ivars that were made private
1416         https://bugs.webkit.org/show_bug.cgi?id=171631
1417
1418         Reviewed by Dan Bernstein.
1419
1420         * WebKit.exp:
1421
1422 2017-05-01  Chris Dumez  <cdumez@apple.com>
1423
1424         Remove some usage of PassRefPtr in editing code
1425         https://bugs.webkit.org/show_bug.cgi?id=171490
1426
1427         Reviewed by Darin Adler.
1428
1429         * WebView/WebFrame.mm:
1430         (-[WebFrame dictationResultMetadataForRange:]):
1431         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1432
1433 2017-05-01  Beth Dakin  <bdakin@apple.com>
1434
1435         On-screen panel for candidate bar is in the wrong place when the caret is at the 
1436         start of a paragraph
1437         https://bugs.webkit.org/show_bug.cgi?id=171453
1438         -and corresponding-
1439         rdar://problem/29779764
1440
1441         Reviewed by Tim Horton.
1442
1443         This bug only happens when the caret is at the beginning of the paragraph, and it 
1444         is because Range::absoluteTextQuads() returns no quads in this case. I think it 
1445         might be correct that absoluteTextQuads() returns no quads in this case, so this 
1446         patch fixes the bug at the call site by using absoluteCaretBounds() in this case.
1447
1448         * WebCoreSupport/WebEditorClient.mm:
1449         (WebEditorClient::handleRequestedCandidates):
1450
1451 2017-04-30  Dan Bernstein  <mitz@apple.com>
1452
1453         [Cocoa] Replaces uses of [get…() alloc] with alloc…Instance()
1454         https://bugs.webkit.org/show_bug.cgi?id=171485
1455
1456         Reviewed by Geoffrey Garen.
1457
1458         * WebView/WebView.mm:
1459         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1460         (-[WebUITextIndicatorData initWithImage:scale:]):
1461
1462 2017-04-28  Youenn Fablet  <youenn@apple.com>
1463
1464         Adding a runtime flag specific to MediaDevices
1465         https://bugs.webkit.org/show_bug.cgi?id=171433
1466
1467         Reviewed by Geoffrey Garen.
1468
1469         Adding a preference for MediaDevices.
1470         Setting media devices runtime flag to false by default.
1471         Setting peer connection and media stream flags to true by default.
1472
1473         * WebView/WebPreferenceKeysPrivate.h:
1474         * WebView/WebPreferences.mm:
1475         (+[WebPreferences initialize]):
1476         (-[WebPreferences mediaDevicesEnabled]):
1477         (-[WebPreferences setMediaDevicesEnabled:]):
1478         * WebView/WebPreferencesPrivate.h:
1479         * WebView/WebView.mm:
1480         (-[WebView _preferencesChanged:]):
1481
1482 2017-04-27  Chris Dumez  <cdumez@apple.com>
1483
1484         Align colspan/rowspan limits with the latest HTML specification
1485         https://bugs.webkit.org/show_bug.cgi?id=171322
1486
1487         Reviewed by Darin Adler.
1488
1489         ObjC bindings build fix.
1490
1491         * DOM/DOMHTMLTableCellElement.mm:
1492         (-[DOMHTMLTableCellElement colSpan]):
1493         (-[DOMHTMLTableCellElement setColSpan:]):
1494
1495 2017-04-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
1496
1497         REGRESSION(r213764): Async decoding of animated images is disabled for ImageDocument
1498         https://bugs.webkit.org/show_bug.cgi?id=170333
1499
1500         Reviewed by Simon Fraser.
1501
1502         Disbale the async decoding for large images for now.
1503
1504         * WebView/WebView.mm:
1505         (-[WebView _preferencesChanged:]):
1506
1507 2017-04-27  Alex Christensen  <achristensen@webkit.org>
1508
1509         Modernize Frame.h
1510         https://bugs.webkit.org/show_bug.cgi?id=171357
1511
1512         Reviewed by Andy Estes.
1513
1514         * WebCoreSupport/WebEditorClient.h:
1515         * WebCoreSupport/WebEditorClient.mm:
1516         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
1517
1518 2017-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1519
1520         [WK1] Tweak the data interaction SPI to indicate whether or not a data interaction was handled
1521         https://bugs.webkit.org/show_bug.cgi?id=171369
1522         <rdar://problem/31858853>
1523
1524         Reviewed by Dan Bernstein.
1525
1526         Introduce a new SPI hook intended to replace performDataInteraction:client:global:operation: that
1527         returns whether or not the data interaction was handled. Due to the difference only in return type
1528         and some staging constraints, this version is prefixed with "_tryTo".
1529
1530         * WebView/WebView.mm:
1531         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
1532         * WebView/WebViewPrivate.h:
1533
1534 2017-04-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1535
1536         WebItemProviderPasteboard should not synchronously load provided data
1537         https://bugs.webkit.org/show_bug.cgi?id=171341
1538         <rdar://problem/31614010>
1539
1540         Reviewed by Tim Horton.
1541
1542         Adds client-layer plumbing for updatePreferredTypeIdentifiers. See WebCore ChangeLog for more details.
1543
1544         * WebCoreSupport/WebPlatformStrategies.h:
1545         * WebCoreSupport/WebPlatformStrategies.mm:
1546         (WebPlatformStrategies::updatePreferredTypeIdentifiers):
1547
1548 2017-04-26  Zalan Bujtas  <zalan@apple.com>
1549
1550         RTL: recent searches popover is displayed in incorrect location
1551         https://bugs.webkit.org/show_bug.cgi?id=171338
1552         <rdar://problem/31377807>
1553
1554         Reviewed by Dean Jackson.
1555
1556         Add RTL support for the pop-under branch.
1557
1558         * WebCoreSupport/PopupMenuMac.mm:
1559         (PopupMenuMac::show):
1560
1561 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
1562
1563         Limit allowed size of document.title to avoid locking WebKit clients
1564         https://bugs.webkit.org/show_bug.cgi?id=165113
1565         <rdar://problem/28324389>
1566
1567         Reviewed by Darin Adler.
1568
1569         When a web application attempts to set an extremely long title, truncate the
1570         title to a more reasonable size.
1571
1572         We do this at at the presentation layer, rather than in the DOM, so that we do
1573         not affect script function. Instead, we merely limit display to a level that is
1574         reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
1575         layer, so it is a waste of effort to send across IPC.
1576
1577         * WebCoreSupport/WebFrameLoaderClient.h:
1578         * WebCoreSupport/WebFrameLoaderClient.mm:
1579         (WebFrameLoaderClient::dispatchDidReceiveTitle):
1580
1581 2017-04-25  Daniel Bates  <dabates@apple.com>
1582
1583         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
1584         https://bugs.webkit.org/show_bug.cgi?id=136452
1585         <rdar://problem/23412620>
1586
1587         Reviewed by Brent Fulgham.
1588
1589         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
1590
1591         * Configurations/FeatureDefines.xcconfig:
1592
1593 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1594
1595         Support reading NSURL titles from the pasteboard when performing data interaction
1596         https://bugs.webkit.org/show_bug.cgi?id=171156
1597         <rdar://problem/31356937>
1598
1599         Reviewed by Tim Horton.
1600
1601         Add a new WK1 SPI property, -[WebFrame hasRichlyEditableDragCaret].
1602
1603         * WebCoreSupport/WebPlatformStrategies.h:
1604         * WebCoreSupport/WebPlatformStrategies.mm:
1605         (WebPlatformStrategies::readURLFromPasteboard):
1606         * WebView/WebFrame.mm:
1607         (-[WebFrame hasRichlyEditableDragCaret]):
1608         * WebView/WebFramePrivate.h:
1609
1610 2017-04-24  Andy VanWagoner  <thetalecrafter@gmail.com>
1611
1612         Clean up ICU headers
1613         https://bugs.webkit.org/show_bug.cgi?id=170997
1614
1615         Reviewed by JF Bastien.
1616
1617         Update all icu headers to 55.1
1618
1619         * icu/README: Explain ICU headers for OS X better
1620         * icu/unicode/localpointer.h:
1621         (LocalPointer::LocalPointer):
1622         (LocalPointer::adoptInsteadAndCheckErrorCode):
1623         * icu/unicode/platform.h:
1624         * icu/unicode/putil.h:
1625         * icu/unicode/uchar.h:
1626         * icu/unicode/uconfig.h:
1627         * icu/unicode/ucurr.h:
1628         * icu/unicode/uidna.h:
1629         * icu/unicode/umachine.h:
1630         * icu/unicode/urename.h:
1631         * icu/unicode/uscript.h:
1632         * icu/unicode/ustring.h:
1633         * icu/unicode/utf8.h:
1634         * icu/unicode/utypes.h:
1635         * icu/unicode/uvernum.h:
1636
1637 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1638
1639         Respect fidelity order when reading web content from item providers
1640         https://bugs.webkit.org/show_bug.cgi?id=171155
1641         <rdar://problem/31356937>
1642
1643         Reviewed by Tim Horton.
1644
1645         Adjusts for changes in WebCore (see WebCore/ChangeLog for more details).
1646
1647         * WebCoreSupport/WebPlatformStrategies.h:
1648         * WebCoreSupport/WebPlatformStrategies.mm:
1649         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex):
1650
1651 2017-04-24  Alex Christensen  <achristensen@webkit.org>
1652
1653         Reduce copies and allocations in SharedBuffer::append
1654         https://bugs.webkit.org/show_bug.cgi?id=170956
1655
1656         Reviewed by Andreas Kling.
1657
1658         * WebView/WebArchive.mm:
1659         (-[WebArchive initWithData:]):
1660         * WebView/WebFrame.mm:
1661         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1662         * WebView/WebResource.mm:
1663         (-[WebResource initWithCoder:]):
1664         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1665
1666 2017-04-24  Dan Bernstein  <mitz@apple.com>
1667
1668         [Cocoa] Some ivars are needlessly @protected
1669         https://bugs.webkit.org/show_bug.cgi?id=171208
1670
1671         Reviewed by Anders Carlsson
1672
1673         Made ivars @private where possible.
1674
1675         * Misc/WebUserContentURLPattern.h:
1676         * Plugins/WebPluginDatabase.h:
1677         * Storage/WebDatabaseQuotaManager.h:
1678         * WebCoreSupport/WebSecurityOriginPrivate.h:
1679         * WebInspector/WebInspector.h:
1680         * WebView/WebDeviceOrientation.h:
1681         * WebView/WebDeviceOrientationProviderMock.h:
1682         * WebView/WebGeolocationPosition.h:
1683         * WebView/WebHTMLRepresentation.h:
1684         * WebView/WebNotification.h:
1685
1686 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1687
1688         Support writing link titles to the pasteboard when beginning data interaction on a link
1689         https://bugs.webkit.org/show_bug.cgi?id=171154
1690         <rdar://problem/31356937>
1691
1692         Reviewed by Andy Estes.
1693
1694         Adjust for some changes in WebCore to introduce a separate codepath for writing PasteboardURLs. See WebCore
1695         and WebKit2 ChangeLogs for more details.
1696
1697         * WebCoreSupport/WebPlatformStrategies.h:
1698         * WebCoreSupport/WebPlatformStrategies.mm:
1699         (WebPlatformStrategies::writeToPasteboard):
1700
1701 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1702
1703         Unreviewed, rolling out r215608.
1704
1705         Hundreds of test failures on GTK bot
1706
1707         Reverted changeset:
1708
1709         "Reduce copies and allocations in SharedBuffer::append"
1710         https://bugs.webkit.org/show_bug.cgi?id=170956
1711         http://trac.webkit.org/changeset/215608
1712
1713 2017-04-21  Alex Christensen  <achristensen@webkit.org>
1714
1715         Reduce copies and allocations in SharedBuffer::append
1716         https://bugs.webkit.org/show_bug.cgi?id=170956
1717
1718         Reviewed by Andreas Kling.
1719
1720         * WebView/WebArchive.mm:
1721         (-[WebArchive initWithData:]):
1722         * WebView/WebFrame.mm:
1723         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1724         * WebView/WebResource.mm:
1725         (-[WebResource initWithCoder:]):
1726         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1727
1728 2017-04-20  Dewei Zhu  <dewei_zhu@apple.com>
1729
1730         Build fix to start using C++14.
1731         https://bugs.webkit.org/show_bug.cgi?id=171038
1732
1733         Reviewed by Alex Christensen.
1734
1735         Use 'c++14' instead of 'c++11' in order to use 'auto' in lambda.
1736
1737         * Configurations/WebKitLegacy.xcconfig:
1738
1739 2017-04-19  Youenn Fablet  <youenn@apple.com>
1740
1741         [Mac] Allow customizing H264 encoder
1742         https://bugs.webkit.org/show_bug.cgi?id=170829
1743
1744         Reviewed by Alex Christensen.
1745
1746         * Configurations/FeatureDefines.xcconfig:
1747
1748 2017-04-19  Anders Carlsson  <andersca@apple.com>
1749
1750         Stop using deprecated APIs, part 3
1751         https://bugs.webkit.org/show_bug.cgi?id=171003
1752         rdar://problem/31589635
1753
1754         Reviewed by Tim Horton.
1755
1756         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1757         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1758         (WebPaymentCoordinatorClient::cancelPaymentSession):
1759         Update for WebCore changes.
1760
1761 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1762
1763         [WK2] Support DataTransfer::files() when performing a DHTML data interaction
1764         https://bugs.webkit.org/show_bug.cgi?id=170880
1765         <rdar://problem/31314689>
1766
1767         Reviewed by Tim Horton.
1768
1769         Adjust for a change in PasteboardStrategy. See WebCore ChangeLog for more details.
1770
1771         * WebCoreSupport/WebPlatformStrategies.h:
1772         * WebCoreSupport/WebPlatformStrategies.mm:
1773         (WebPlatformStrategies::getFilenamesForDataInteraction):
1774
1775 2017-04-17  Youenn Fablet  <youenn@apple.com>
1776
1777         Disable outdated WritableStream API
1778         https://bugs.webkit.org/show_bug.cgi?id=170749
1779         <rdar://problem/31446233>
1780
1781         Reviewed by Alex Christensen.
1782
1783         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
1784         - A STREAMS_API compilation flag.
1785         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
1786
1787         * Configurations/FeatureDefines.xcconfig:
1788         * WebView/WebPreferenceKeysPrivate.h:
1789         * WebView/WebPreferences.mm:
1790         (+[WebPreferences initialize]):
1791         (-[WebPreferences readableByteStreamAPIEnabled]):
1792         (-[WebPreferences setReadableByteStreamAPIEnabled:]):
1793         (-[WebPreferences writableStreamAPIEnabled]):
1794         (-[WebPreferences setWritableStreamAPIEnabled:]):
1795         * WebView/WebPreferencesPrivate.h:
1796         * WebView/WebView.mm:
1797         (-[WebView _preferencesChanged:]):
1798
1799 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1800
1801         [WK2] Support data interaction of files into file inputs
1802         https://bugs.webkit.org/show_bug.cgi?id=170803
1803         <rdar://problem/31286130>
1804
1805         Reviewed by Tim Horton.
1806
1807         Add boilerplate plumbing for fetching the number of files in the pasteboard.
1808
1809         * WebCoreSupport/WebPlatformStrategies.h:
1810         * WebCoreSupport/WebPlatformStrategies.mm:
1811         (WebPlatformStrategies::getNumberOfFiles):
1812
1813 2017-04-14  Mark Lam  <mark.lam@apple.com>
1814
1815         Update architectures in xcconfig files.
1816         https://bugs.webkit.org/show_bug.cgi?id=170867
1817         <rdar://problem/31628104>
1818
1819         Reviewed by Joseph Pecoraro.
1820
1821         * Configurations/FeatureDefines.xcconfig:
1822
1823 2017-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1824
1825         [WK2] Support Icon creation from file URLs on iOS
1826         https://bugs.webkit.org/show_bug.cgi?id=170809
1827         <rdar://problem/31286130>
1828
1829         Reviewed by Tim Horton.
1830
1831         Adjust for changes in the ChromeClient in WebCore.
1832
1833         * WebCoreSupport/WebChromeClient.h:
1834         * WebCoreSupport/WebChromeClient.mm:
1835         (WebChromeClient::loadIconForFiles):
1836         (WebChromeClient::createIconForFiles):
1837
1838 2017-04-12  Dan Bernstein  <mitz@apple.com>
1839
1840         [Mac] Future-proof .xcconfig files
1841         https://bugs.webkit.org/show_bug.cgi?id=170802
1842
1843         Reviewed by Tim Horton.
1844
1845         * Configurations/Base.xcconfig:
1846         * Configurations/DebugRelease.xcconfig:
1847         * Configurations/FeatureDefines.xcconfig:
1848         * Configurations/Version.xcconfig:
1849
1850 2017-04-12  Beth Dakin  <bdakin@apple.com>
1851
1852         Build fix.
1853
1854         * WebView/WebViewData.h:
1855
1856 2017-04-12  Brian Weinstein  <bweinstein@apple.com>
1857
1858         Should always override -[WebStorageManager init].
1859         https://bugs.webkit.org/show_bug.cgi?id=170787
1860         -and corresponding-
1861         rdar://problem/31371835
1862
1863         Reviewed by Anders Carlsson.
1864
1865         * Storage/WebStorageManager.mm:
1866         (-[WebStorageManager init]):
1867
1868 2017-04-12  Beth Dakin  <bdakin@apple.com>
1869
1870         Speculative build fix. 
1871
1872         * WebView/WebViewData.h:
1873
1874 2017-04-12  Beth Dakin  <bdakin@apple.com>
1875
1876         Adopt AVKit name change from AVFunctionBar* to AVTouchBar*
1877         https://bugs.webkit.org/show_bug.cgi?id=170693
1878         -and corresponding-
1879         rdar://problem/31230018
1880
1881         Reviewed by Sam Weinig.
1882
1883         Since the new names only apply to some versions of macOS, this patch uses typedefs 
1884         for the older OS’s. SO:
1885
1886         AVFunctionBarScrubber is now AVTouchBarScrubber
1887
1888         AVFunctionBarPlaybackControlsProvider is now AVTouchBarPlaybackControlsProvider
1889
1890         AVFunctionBarMediaSelectionOption is now AVTouchBarMediaSelectionOption
1891
1892         And the protocol AVFunctionBarPlaybackControlsControlling is now 
1893         AVTouchBarPlaybackControlsControlling
1894
1895         Soft links and allocations cannot use the typedefs.
1896         * WebView/WebView.mm:
1897         (-[WebView updateMediaTouchBar]):
1898         * WebView/WebViewData.h:
1899
1900 2017-04-11  Dean Jackson  <dino@apple.com>
1901
1902         Disable outdated WritableStream API
1903         https://bugs.webkit.org/show_bug.cgi?id=170749
1904         <rdar://problem/31446233>
1905
1906         Reviewed by Tim Horton.
1907
1908         The API we implement is no longer accurate. Disable it until we
1909         are compatible with the new specification
1910
1911         * Configurations/FeatureDefines.xcconfig:
1912
1913 2017-04-11  Dan Bernstein  <mitz@apple.com>
1914
1915         [iOS] Simple HTML documents should allow non-markup JavaScript
1916         https://bugs.webkit.org/show_bug.cgi?id=170734
1917
1918         Reviewed by Sam Weinig.
1919
1920         * WebView/WebView.mm:
1921         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Enabled scripting
1922           but disabled scripting markup.
1923
1924 2017-04-10  Alex Christensen  <achristensen@webkit.org>
1925
1926         Revert r215217
1927         https://bugs.webkit.org/show_bug.cgi?id=170703
1928
1929         * Configurations/FeatureDefines.xcconfig:
1930
1931 2017-04-10  Alex Christensen  <achristensen@webkit.org>
1932
1933         Continue enabling WebRTC
1934         https://bugs.webkit.org/show_bug.cgi?id=170703
1935
1936         Reviewed by Youenn Fablet.
1937
1938         * Configurations/FeatureDefines.xcconfig:
1939
1940 2017-04-10  Anders Carlsson  <andersca@apple.com>
1941
1942         Remove call to WKShowKeyAndMain
1943         https://bugs.webkit.org/show_bug.cgi?id=170691
1944         rdar://problem/31050032
1945
1946         Reviewed by Beth Dakin.
1947
1948         * Carbon/CarbonWindowAdapter.mm:
1949         (-[CarbonWindowAdapter makeKeyWindow]):
1950
1951 2017-04-10  Jeremy Jones  <jeremyj@apple.com>
1952
1953         Add CoreAudioCaptureSource.
1954         https://bugs.webkit.org/show_bug.cgi?id=170112
1955         rdar://problem/30293338
1956
1957         Reviewed by Eric Carlson.
1958
1959         Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.
1960
1961         * WebView/WebPreferenceKeysPrivate.h:
1962         * WebView/WebPreferences.mm:
1963         (+[WebPreferences initialize]):
1964         (-[WebPreferences useAVFoundationAudioCapture]):
1965         (-[WebPreferences setUseAVFoundationAudioCapture:]):
1966         * WebView/WebPreferencesPrivate.h:
1967         * WebView/WebView.mm:
1968         (-[WebView _preferencesChanged:]):
1969
1970 2017-04-10  Chris Dumez  <cdumez@apple.com>
1971
1972         Drop Timer::startOneShot() overload taking a double
1973         https://bugs.webkit.org/show_bug.cgi?id=170659
1974
1975         Reviewed by Yusuke Suzuki.
1976
1977         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
1978
1979         * Plugins/WebNetscapePluginView.mm:
1980         (PluginTimer::start):
1981         * Storage/WebStorageManager.mm:
1982         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
1983
1984 2017-04-09  Chris Dumez  <cdumez@apple.com>
1985
1986         Drop Timer::startRepeating() overload taking a double
1987         https://bugs.webkit.org/show_bug.cgi?id=170656
1988
1989         Reviewed by Yusuke Suzuki.
1990
1991         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
1992
1993         * Plugins/WebNetscapePluginView.mm:
1994         (PluginTimer::start):
1995
1996 2017-04-09  Chris Dumez  <cdumez@apple.com>
1997
1998         Start dropping Timer API dealing with double
1999         https://bugs.webkit.org/show_bug.cgi?id=170649
2000
2001         Reviewed by Yusuke Suzuki.
2002
2003         Start dropping Timer API dealing with double as people should use Seconds now.
2004
2005         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2006         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2007         (WebKit::NetscapePluginInstanceProxy::loadRequest):
2008         * Plugins/WebNetscapePluginStream.mm:
2009         (WebNetscapePluginStream::deliverData):
2010
2011 2017-04-08  Chris Dumez  <cdumez@apple.com>
2012
2013         Drop std::chrono support from Timer class
2014         https://bugs.webkit.org/show_bug.cgi?id=170645
2015
2016         Reviewed by Sam Weinig.
2017
2018         Drop std::chrono support from Timer class now that we prefer using Seconds type.
2019
2020         * WebView/WebView.mm:
2021         (+[WebView _setCacheModel:]):
2022
2023 2017-04-08  Youenn Fablet  <youenn@apple.com>
2024
2025         WebRTC tests gardening
2026         https://bugs.webkit.org/show_bug.cgi?id=170508
2027
2028         Reviewed by Eric Carlson.
2029
2030         * Configurations/FeatureDefines.xcconfig:
2031
2032 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
2033
2034         Unreviewed, rolling out r215046.
2035
2036         This change broke internal builds.
2037
2038         Reverted changeset:
2039
2040         "WebRTC tests gardening"
2041         https://bugs.webkit.org/show_bug.cgi?id=170508
2042         http://trac.webkit.org/changeset/215046
2043
2044 2017-04-06  Tim Horton  <timothy_horton@apple.com>
2045
2046         Obj-C bindings build fails with CSS_DEVICE_ADAPTATION turned on
2047         https://bugs.webkit.org/show_bug.cgi?id=170566
2048
2049         Reviewed by Simon Fraser.
2050
2051         * DOM/DOMCSS.mm:
2052         (kitClass):
2053         Use the WebCore-side enum for this, since that's actually what we're switching over.
2054         This allows us to handle values here without adding them to the API header.
2055         All of the other kitClass() functions work the same way.
2056         Also, unindent for style purposes.
2057
2058 2017-04-06  Youenn Fablet  <youenn@apple.com>
2059
2060         WebRTC tests gardening
2061         https://bugs.webkit.org/show_bug.cgi?id=170508
2062
2063         Reviewed by Eric Carlson.
2064
2065         * Configurations/FeatureDefines.xcconfig:
2066
2067 2017-04-04  Megan Gardner  <megan_gardner@apple.com>
2068
2069         Fix leaks in WebUITextIndicatorData
2070         https://bugs.webkit.org/show_bug.cgi?id=170480
2071
2072         Reviewed by Wenson Hsieh.
2073
2074         Removes extraneous retains.
2075
2076         * WebView/WebView.mm:
2077         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2078
2079 2017-04-04  Tim Horton  <timothy_horton@apple.com>
2080
2081         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
2082         https://bugs.webkit.org/show_bug.cgi?id=165801
2083         <rdar://problem/29649535>
2084
2085         Reviewed by Wenson Hsieh.
2086
2087         * WebView/WebView.mm:
2088         (incrementFrame):
2089         Adjust to the new CanWrap enum.
2090
2091 2017-03-27  Joseph Pecoraro  <pecoraro@apple.com>
2092
2093         Web Inspector: Saving files should not suggest the top level directory
2094         https://bugs.webkit.org/show_bug.cgi?id=170085
2095         <rdar://problem/30197794>
2096
2097         Reviewed by Matt Baker.
2098
2099         * WebCoreSupport/WebInspectorClient.mm:
2100         (WebInspectorFrontendClient::save):
2101         Don't set panel.directoryURL unless we have a good suggestion.
2102
2103 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2104
2105         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
2106         https://bugs.webkit.org/show_bug.cgi?id=169168
2107         <rdar://problem/30688374>
2108
2109         Reviewed by Tim Horton.
2110
2111         Refactors WebDragClient::actionMaskForDrag to take platform data only, rather than the entire DragData. See the
2112         WebCore ChangeLog entry for more details. Also renames WebDefaultUIDelegate.m to WebDefaultUIDelegate.mm, since
2113         we need to import a C++ header for linkedOnOrAfter().
2114
2115         The default delegate implementation of webView:dragDestinationActionMaskForDraggingInfo: now checks if the current
2116         application is linking against 10.12 or earlier, and if so, will allow any drag destination action instead of
2117         the new default value of everything but DragDestinationActionLoad.
2118
2119         * DefaultDelegates/WebDefaultUIDelegate.mm: Renamed from Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.m.
2120         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
2121         * Misc/WebKitVersionChecks.h:
2122         * WebCoreSupport/WebDragClient.h:
2123         * WebCoreSupport/WebDragClient.mm:
2124         (WebDragClient::actionMaskForDrag): Deleted.
2125         * WebView/WebView.mm:
2126         (-[WebView draggingEntered:]):
2127         (-[WebView draggingUpdated:]):
2128
2129 2017-03-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2130
2131         Add support for showing the platform data interaction caret
2132         https://bugs.webkit.org/show_bug.cgi?id=169898
2133         <rdar://problem/31146295>
2134
2135         Reviewed by Beth Dakin.
2136
2137         Plumb the dataInteractionCaretRect through WebView SPI to WebKit1 clients.
2138
2139         * WebView/WebView.mm:
2140         (-[WebView _dataInteractionCaretRect]):
2141         * WebView/WebViewPrivate.h:
2142
2143 2017-03-22  Dan Bernstein  <mitz@apple.com>
2144
2145         [iOS] downloadableBinaryFontsEnabled is set to false in -initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:
2146         https://bugs.webkit.org/show_bug.cgi?id=169967
2147         <rdar://problem/30406898>
2148
2149         Reviewed by Anders Carlsson.
2150
2151         * WebView/WebView.mm:
2152         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Removed call to
2153           Settings::downloadableBinaryFontsEnabled. The default is true.
2154
2155 2017-03-22  Andy Estes  <aestes@apple.com>
2156
2157         [QuickLook] Rename QuickLookHandle to PreviewLoader
2158         https://bugs.webkit.org/show_bug.cgi?id=169961
2159
2160         Reviewed by Andreas Kling.
2161
2162         * WebCoreSupport/WebFrameLoaderClient.h:
2163         * WebCoreSupport/WebFrameLoaderClient.mm:
2164         (WebFrameLoaderClient::createPreviewLoaderClient):
2165         (WebFrameLoaderClient::createQuickLookHandleClient): Deleted.
2166
2167 2017-03-21  Anders Carlsson  <andersca@apple.com>
2168
2169         Remove bogus availability annotations from DOM SPI headers.
2170         rdar://problem/31015675
2171
2172         Rubber-stamped by Dan Bernstein.
2173
2174         * DOM/DOMHTMLMediaElement.h:
2175         * DOM/DOMHTMLVideoElement.h:
2176         * DOM/DOMMediaError.h:
2177         * DOM/DOMTextEvent.h:
2178         * DOM/DOMTimeRanges.h:
2179         * DOM/DOMTokenList.h:
2180
2181 2017-03-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2182
2183         Teach TextIndicator to estimate the background color of the given Range
2184         https://bugs.webkit.org/show_bug.cgi?id=169869
2185         <rdar://problem/31127272>
2186
2187         Reviewed by Anders Carlsson and Simon Fraser.
2188
2189         Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.
2190
2191         * WebView/WebView.mm:
2192         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2193         (-[WebUITextIndicatorData dealloc]):
2194         * WebView/WebViewPrivate.h:
2195
2196 2017-03-20  Dan Bernstein  <mitz@apple.com>
2197
2198         [Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
2199         https://bugs.webkit.org/show_bug.cgi?id=169861
2200
2201         Reviewed by Sam Weinig.
2202
2203         * MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
2204         * postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the
2205           timestamp file used by the Xcode project to determine whether to run the script.
2206
2207 2017-03-19  Alexey Proskuryakov  <ap@apple.com>
2208
2209         WebHTMLView is useless as WebResourceHandler
2210         https://bugs.webkit.org/show_bug.cgi?id=169857
2211
2212         Reviewed by Dan Bernstein.
2213
2214         * WebView/WebHTMLView.mm:
2215         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2216         WebHTMLView doesnt implement any of WebResourceHandler methods.
2217
2218 2017-03-17  Michael Saboff  <msaboff@apple.com>
2219
2220         Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
2221         https://bugs.webkit.org/show_bug.cgi?id=169817
2222
2223         Reviewed by Filip Pizlo.
2224
2225         * Configurations/FeatureDefines.xcconfig:
2226
2227 2017-03-17  Antti Koivisto  <antti@apple.com>
2228
2229         Add a reload policy where only expired subresources are revalidated
2230         https://bugs.webkit.org/show_bug.cgi?id=169756
2231
2232         Reviewed by Andreas Kling.
2233
2234         * WebView/WebFrame.mm:
2235         (toWebFrameLoadType):
2236         (-[WebFrame reload]):
2237         (-[WebFrame reloadFromOrigin]):
2238
2239 2017-03-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2240
2241         [WK1] Support animated transitions when performing a data interaction operation
2242         https://bugs.webkit.org/show_bug.cgi?id=169805
2243         <rdar://problem/31045767>
2244
2245         Reviewed by Beth Dakin and Megan Gardner.
2246
2247         Adds WebKit1 support for animated transitions when performing a data interaction operation. See per-method changes
2248         for more details.
2249
2250         * DOM/DOMElement.h:
2251         * DOM/DOMElement.mm:
2252         (-[DOMElement boundsInRootViewSpace]):
2253
2254         Introduce -[DOMElement boundsInRootViewSpace], which returns the bounds of the element in root view coordinates.
2255
2256         * WebCoreSupport/WebDragClient.h:
2257         (): Deleted.
2258         * WebCoreSupport/WebDragClient.mm:
2259         (WebDragClient::didConcludeEditDrag):
2260
2261         Add boilerplate plumbing.
2262
2263         * WebView/WebView.mm:
2264         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2265
2266         Add contentImageWithoutSelection and contentImageWithoutSelectionRectInRootViewCoordinates to WebUITextIndicatorData.
2267
2268         (floatRectsForCGRectArray):
2269         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
2270
2271         Introduces a SPI helper method in WebView that clients can use to generate an image of a text platter given an
2272         image of some text, as well as clipping rects to apply to the image.
2273
2274         (-[WebView _dataOperationTextIndicator]):
2275
2276         Add SPI to fetch the text indicator used to drive animations for the current data operation.
2277
2278         (-[WebView _didConcludeEditDataInteraction]):
2279         * WebView/WebViewData.h:
2280         * WebView/WebViewInternal.h:
2281         * WebView/WebViewPrivate.h:
2282
2283 2017-03-16  Simon Fraser  <simon.fraser@apple.com>
2284
2285         Improve the system tracing points
2286         https://bugs.webkit.org/show_bug.cgi?id=169790
2287
2288         Reviewed by Zalan Bujtas.
2289
2290         Use a more cohesive set of system trace points that give a good overview of what
2291         WebKit is doing. Added points for resource loading, render tree building, sync messages
2292         to the web process, async image decode, WASM and fetching cookies.
2293
2294         * WebView/WebHTMLView.mm:
2295         (-[WebHTMLView drawRect:]):
2296
2297 2017-03-16  Youenn Fablet  <youenn@apple.com>
2298
2299         Wrap legacy WebRTC API in runtime flag
2300         https://bugs.webkit.org/show_bug.cgi?id=169646
2301
2302         Reviewed by Alex Christensen.
2303
2304         * WebView/WebPreferenceKeysPrivate.h:
2305         * WebView/WebPreferences.mm:
2306         (+[WebPreferences initialize]):
2307         (-[WebPreferences webRTCLegacyAPIEnabled]):
2308         (-[WebPreferences setWebRTCLegacyAPIEnabled:]):
2309         * WebView/WebPreferencesPrivate.h:
2310         * WebView/WebView.mm:
2311         (-[WebView _preferencesChanged:]):
2312
2313 2017-03-14  Megan Gardner  <megan_gardner@apple.com>
2314
2315         Correctly export WebItemProviderPasteboard
2316         https://bugs.webkit.org/show_bug.cgi?id=169578
2317
2318         Reviewed by Tim Horton.
2319
2320         * MigrateHeaders.make:
2321
2322 2017-03-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2323
2324         [WK2] Data interaction tests occasionally hit assertions in debug builds
2325         https://bugs.webkit.org/show_bug.cgi?id=169002
2326         <rdar://problem/30994806>
2327
2328         Reviewed by Tim Horton.
2329
2330         Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.
2331
2332         * WebView/WebHTMLView.mm:
2333         (-[WebHTMLView _updateSelectionForInputManager]):
2334         * WebView/WebView.mm:
2335         (-[WebView updateTextTouchBar]):
2336
2337 2017-03-13  Anders Carlsson  <andersca@apple.com>
2338
2339         Fix build warnings.
2340
2341         * WebCoreSupport/WebInspectorClient.mm:
2342         (WebInspectorFrontendClient::save):
2343         (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2344
2345 2017-03-11  Brady Eidson  <beidson@apple.com>
2346
2347         Cleanup "addCookie" and its sole user.
2348         https://bugs.webkit.org/show_bug.cgi?id=169486
2349
2350         Reviewed by Brian Burg.
2351
2352         * WebCoreSupport/WebPlatformStrategies.h:
2353         * WebCoreSupport/WebPlatformStrategies.mm:
2354         (WebPlatformStrategies::addCookie): Deleted.
2355
2356 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2357
2358         Fix watch and tv builds after r213294
2359         https://bugs.webkit.org/show_bug.cgi?id=169508
2360
2361         Reviewed by Dan Bernstein.
2362
2363         * Configurations/FeatureDefines.xcconfig:
2364
2365 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2366
2367         Fix CMake build.
2368
2369         * WebView/WebNotification.h:
2370         Don't assume we have already included something that includes NSObject.h.
2371
2372 2017-03-09  Daniel Bates  <dabates@apple.com>
2373
2374         Guard Credential Management implementation behind a runtime enabled feature flag
2375         https://bugs.webkit.org/show_bug.cgi?id=169364
2376         <rdar://problem/30957425>
2377
2378         Reviewed by Brent Fulgham.
2379
2380         Add WebKit preference for Credential Management (disabled by default).
2381
2382         * WebView/WebPreferenceKeysPrivate.h:
2383         * WebView/WebPreferences.mm:
2384         (+[WebPreferences initialize]):
2385         (-[WebPreferences credentialManagementEnabled]): Added.
2386         (-[WebPreferences setCredentialManagementEnabled:]): Added.
2387         * WebView/WebPreferencesPrivate.h:
2388         * WebView/WebView.mm:
2389         (-[WebView _preferencesChanged:]):
2390
2391 2017-03-09  Anders Carlsson  <andersca@apple.com>
2392
2393         Add delegate support to WebCore
2394         https://bugs.webkit.org/show_bug.cgi?id=169427
2395         Part of rdar://problem/28880714.
2396
2397         Reviewed by Geoffrey Garen.
2398
2399         * Configurations/FeatureDefines.xcconfig:
2400         Add feature define.
2401
2402 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
2403
2404         Fix DataInteraction guards
2405         https://bugs.webkit.org/show_bug.cgi?id=169404
2406
2407         Reviewed by Wenson Hsieh.
2408
2409         * WebCoreSupport/WebDragClient.mm:
2410
2411 2017-03-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2412
2413         Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
2414         https://bugs.webkit.org/show_bug.cgi?id=169392
2415         <rdar://problem/30882974>
2416
2417         Reviewed by Tim Horton.
2418
2419         Add a stub implementation of WebDragClient::didConcludeEditDrag.
2420
2421         * WebCoreSupport/WebDragClient.h:
2422
2423 2017-03-08  Anders Carlsson  <andersca@apple.com>
2424
2425         Simplify the PaymentCoordinator interface
2426         https://bugs.webkit.org/show_bug.cgi?id=169382
2427         Part of rdar://problem/28880714.
2428
2429         Reviewed by Tim Horton.
2430
2431         Update for PaymentCoordinatorClient changes.
2432
2433         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2434         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2435         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
2436         (WebPaymentCoordinatorClient::completeShippingContactSelection):
2437         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
2438         (WebPaymentCoordinatorClient::completePaymentSession):
2439
2440 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
2441
2442         Fix for dependency fix
2443         https://bugs.webkit.org/show_bug.cgi?id=169369
2444
2445         Reviewed by Beth Dakin.
2446
2447         * WebView/WebViewPrivate.h:
2448
2449 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
2450
2451         Fix Project Dependency
2452         https://bugs.webkit.org/show_bug.cgi?id=169340
2453
2454         Unreviewed Dependency Fix.
2455
2456         * WebView/WebViewPrivate.h:
2457
2458 2017-03-07  Alexey Proskuryakov  <ap@apple.com>
2459
2460         WebKitLegacy should re-export symbols from WebCore on watchos and tvos
2461         https://bugs.webkit.org/show_bug.cgi?id=169341
2462         <rdar://problem/30913788>
2463
2464         Reviewed by Dan Bernstein.
2465
2466         * MigrateHeaders.make:
2467
2468 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
2469
2470         Have fixedPositionCreatesStackingContext be on by default everywhere
2471         https://bugs.webkit.org/show_bug.cgi?id=169334
2472
2473         Reviewed by Zalan Bujtas.
2474
2475         It makes no sense to have web-exposed CSS functionality be different based on setting,
2476         and other browser are now aligned with having position:fixed create stacking context.
2477
2478         So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
2479         always force stacking context for position:fixed.
2480
2481         * WebView/WebView.mm:
2482         (-[WebView _preferencesChanged:]):
2483
2484 2017-03-06  Simon Fraser  <simon.fraser@apple.com>
2485
2486         Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
2487         https://bugs.webkit.org/show_bug.cgi?id=169230
2488
2489         Reviewed by Tim Horton.
2490
2491         * WebView/WebView.mm:
2492         (-[WebView _preferencesChanged:]):
2493
2494 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
2495
2496         Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
2497         https://bugs.webkit.org/show_bug.cgi?id=169329
2498
2499         Reviewed by Tim Horton.
2500
2501         If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.
2502
2503         * WebView/WebPreferences.mm:
2504         (+[WebPreferences initialize]):
2505
2506 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
2507
2508         Additional DataInteraction Support
2509         https://bugs.webkit.org/show_bug.cgi?id=169316
2510         <rdar://problem/30884234>
2511
2512         Reviewed by Wenson Hsieh.
2513
2514         Add stub implementations to WebView for methods that handle data interaction
2515
2516         * WebView/WebView.mm:
2517         (-[WebView _enteredDataInteraction:client:global:operation:]):
2518         (-[WebView _updatedDataInteraction:client:global:operation:]):
2519         (-[WebView _exitedDataInteraction:client:global:operation:]):
2520         (-[WebView _performDataInteraction:client:global:operation:]):
2521         (-[WebView _endedDataInteraction:global:]):
2522         * WebView/WebViewPrivate.h:
2523
2524 2017-03-07  Dean Jackson  <dino@apple.com>
2525
2526         Some platforms won't be able to create a GPUDevice
2527         https://bugs.webkit.org/show_bug.cgi?id=169314
2528         <rdar://problems/30907521>
2529
2530         Reviewed by Jon Lee.
2531
2532         Disable WEB_GPU on the iOS Simulator.
2533
2534         * Configurations/FeatureDefines.xcconfig:
2535
2536 2017-03-07  Maureen Daum  <mdaum@apple.com>
2537
2538         Correctly check for an empty database file.
2539         <rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
2540         https://bugs.webkit.org/show_bug.cgi?id=169256
2541
2542         Reviewed by Brady Eidson.
2543
2544         Check if the folder for an origin's WebSQL databases is empty after trying to delete
2545         all of its files. Currently we check if the deletedDatabaseFileCount matches the number
2546         of files that were in the folder. However, when we delete the actual database file in
2547         DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
2548         the database file, but deletedDatabaseFileCount only gets incremented once.
2549
2550         * Storage/WebDatabaseManager.mm:
2551         (+[WebDatabaseManager removeEmptyDatabaseFiles]):
2552         Delete the folder if it is empty.
2553
2554 2017-03-06  Michael Saboff  <msaboff@apple.com>
2555
2556         Unreviewed build fix to add
2557         -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
2558         for objective C++ files.
2559
2560         * Configurations/WebKitLegacy.xcconfig:
2561
2562 2017-03-06  Michael Saboff  <msaboff@apple.com>
2563
2564         Take advantage of fast permissions switching of JIT memory for devices that support it
2565         https://bugs.webkit.org/show_bug.cgi?id=169155
2566
2567         Reviewed by Saam Barati.
2568
2569         Updated the Xcode config files to match what is in the JavaScriptCore ones.
2570
2571         * Configurations/FeatureDefines.xcconfig:
2572
2573 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
2574
2575         Expand font-weight and font-stretch to take any number
2576         https://bugs.webkit.org/show_bug.cgi?id=168889
2577
2578         Reviewed by Simon Fraser.
2579
2580         Migrate off old enum types.
2581
2582         * WebCoreSupport/PopupMenuMac.mm:
2583         (PopupMenuMac::populate):
2584         * WebView/WebHTMLView.mm:
2585         (fontNameForDescription):
2586         * WebView/WebView.mm:
2587         (-[WebView updateTextTouchBar]):
2588
2589 2017-03-03  Dean Jackson  <dino@apple.com>
2590
2591         Add WebGPU compile flag and experimental feature flag
2592         https://bugs.webkit.org/show_bug.cgi?id=169161
2593         <rdar://problem/30846689>
2594
2595         Reviewed by Tim Horton.
2596
2597         Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
2598         and an InternalSetting.
2599
2600         * Configurations/FeatureDefines.xcconfig:
2601         * WebView/WebPreferenceKeysPrivate.h:
2602         * WebView/WebPreferences.mm:
2603         (+[WebPreferences initialize]):
2604         (-[WebPreferences webGPUEnabled]):
2605         (-[WebPreferences setWebGPUEnabled:]):
2606         * WebView/WebPreferencesPrivate.h:
2607         * WebView/WebView.mm:
2608         (-[WebView _preferencesChanged:]):
2609
2610 2017-03-03  Alexey Proskuryakov  <ap@apple.com>
2611
2612         Build fix
2613         rdar://problem/30825660
2614
2615         Suggested by Dan Bernstein.
2616
2617         * Configurations/WebKitLegacy.xcconfig:
2618
2619 2017-03-02  Sam Weinig  <sam@webkit.org>
2620
2621         Rename htmlediting.h/cpp to Editing.h/cpp
2622         https://bugs.webkit.org/show_bug.cgi?id=169103
2623
2624         Reviewed by Alex Christensen.
2625
2626         * DOM/DOMUIKitExtensions.mm:
2627         * WebView/WebFrame.mm:
2628         * WebView/WebView.mm:
2629
2630 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2631
2632         Fix 32-bit
2633         https://bugs.webkit.org/show_bug.cgi?id=169114
2634
2635         Reviewed by Alex Christensen.
2636
2637         * WebView/WebView.mm:
2638
2639 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2640
2641         More guard fixing
2642         https://bugs.webkit.org/show_bug.cgi?id=169112
2643
2644         Reviewed by Alex Christensen.
2645
2646         Fixed an internal build.
2647
2648         * WebView/WebView.mm:
2649         * WebView/WebViewPrivate.h:
2650
2651 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2652
2653         Data Interaction build fixes
2654         https://bugs.webkit.org/show_bug.cgi?id=169096
2655
2656         Reviewed by Tim Horton.
2657
2658         Guards weren't all correct, also missed a selector name change.
2659
2660         * WebView/WebView.mm:
2661         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
2662         * WebView/WebViewData.h:
2663         * WebView/WebViewData.mm:
2664         (-[WebViewPrivate dealloc]):
2665
2666 2017-03-02  Alex Christensen  <achristensen@webkit.org>
2667
2668         Continue enabling WebRTC
2669         https://bugs.webkit.org/show_bug.cgi?id=169056
2670
2671         Reviewed by Jon Lee.
2672
2673         * Configurations/FeatureDefines.xcconfig:
2674
2675 2017-03-01  Megan Gardner  <megan_gardner@apple.com>
2676
2677         Data interaction support for WK1
2678         https://bugs.webkit.org/show_bug.cgi?id=169062
2679
2680         Reviewed by Wenson Hsieh.
2681
2682         Support for data interaction in WebKit1
2683
2684         * WebCoreSupport/WebDragClient.mm:
2685         * WebView/WebView.mm:
2686         (-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
2687         (-[WebUITextIndicatorData initWithImage:scale:]):
2688         (-[WebUITextIndicatorData dealloc]):
2689         (-[WebView _requestStartDataInteraction:globalPosition:]):
2690         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
2691         (-[WebView _getDataInteractionData]):
2692         * WebView/WebViewData.h:
2693         * WebView/WebViewData.mm:
2694         (-[WebViewPrivate dealloc]):
2695         * WebView/WebViewInternal.h:
2696         * WebView/WebViewPrivate.h:
2697
2698 2017-03-02  Youenn Fablet  <youenn@apple.com>
2699
2700         [WebRTC] Activate ICE candidate privacy policy
2701         https://bugs.webkit.org/show_bug.cgi?id=168975
2702
2703         Reviewed by Alex Christensen.
2704
2705         * WebView/WebPreferenceKeysPrivate.h:
2706         * WebView/WebPreferences.mm:
2707         (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
2708         (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
2709         (-[WebPreferences iceCandidateFilteringEnabled]):
2710         (-[WebPreferences setIceCandidateFilteringEnabled:]):
2711         * WebView/WebPreferencesPrivate.h:
2712
2713 2017-03-01  Alex Christensen  <achristensen@webkit.org>
2714
2715         Unreviewed, rolling out r213259.
2716
2717         Broke an internal build
2718
2719         Reverted changeset:
2720
2721         "Continue enabling WebRTC"
2722         https://bugs.webkit.org/show_bug.cgi?id=169056
2723         http://trac.webkit.org/changeset/213259
2724
2725 2017-03-01  Alex Christensen  <achristensen@webkit.org>
2726
2727         Continue enabling WebRTC
2728         https://bugs.webkit.org/show_bug.cgi?id=169056
2729
2730         Reviewed by Jon Lee.
2731
2732         * Configurations/FeatureDefines.xcconfig:
2733
2734 2017-02-27  Alex Christensen  <achristensen@webkit.org>
2735
2736         Begin enabling WebRTC on 64-bit
2737         https://bugs.webkit.org/show_bug.cgi?id=168915
2738
2739         Reviewed by Eric Carlson.
2740
2741         * Configurations/FeatureDefines.xcconfig:
2742
2743 2017-02-27  Aakash Jain  <aakash_jain@apple.com>
2744
2745         Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
2746         https://bugs.webkit.org/show_bug.cgi?id=168919
2747
2748         Reviewed by Tim Horton.
2749
2750         * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
2751         * migrate-headers.sh: Run the migrate-headers script for installapi phase.
2752
2753 2017-02-27  Alex Christensen  <achristensen@webkit.org>
2754
2755         [libwebrtc] Enable WebRTC in some Production Builds
2756         https://bugs.webkit.org/show_bug.cgi?id=168858
2757
2758         * Configurations/FeatureDefines.xcconfig:
2759
2760 2017-02-26  Alexey Proskuryakov  <ap@apple.com>
2761
2762         Don't import RetainPtr in WebNotification.h
2763         https://bugs.webkit.org/show_bug.cgi?id=168876
2764
2765         Reviewed by Dan Bernstein.
2766
2767         This is an Objective-C SPI header.
2768
2769         * WebView/WebNotification.h:
2770         * WebView/WebNotification.mm:
2771         (-[WebNotification initWithCoreNotification:notificationID:]):
2772         (-[WebNotification dealloc]):
2773
2774 2017-02-26  Aakash Jain  <aakash_jain@apple.com>
2775
2776         Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
2777         https://bugs.webkit.org/show_bug.cgi?id=168819
2778
2779         Reviewed by Dan Bernstein.
2780
2781         * Configurations/WebKitLegacy.xcconfig:
2782
2783 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
2784
2785         Export Objective-C symbols for variables in Webkit SPI
2786         https://bugs.webkit.org/show_bug.cgi?id=168758
2787
2788         Reviewed by Alexey Proskuryakov.
2789
2790         * Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
2791         * WebKit.exp: Added various Objective-C symbols.
2792
2793 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
2794
2795         Move instance members from WKQuadObject to implementation file
2796         https://bugs.webkit.org/show_bug.cgi?id=168740
2797
2798         Reviewed by Tim Horton.
2799
2800         * DOM/DOM.mm: Moving instance member to implementation file.
2801         * DOM/DOMExtensions.h: Ditto.
2802
2803 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
2804
2805         Move iOS specific symbols to WebKit.ios.exp
2806         https://bugs.webkit.org/show_bug.cgi?id=168726
2807
2808         Reviewed by Alexey Proskuryakov.
2809
2810         * WebKit.exp:
2811
2812 2017-02-21  Youenn Fablet  <youenn@apple.com>
2813
2814         [WebRTC][Mac] Activate libwebrtc
2815         https://bugs.webkit.org/show_bug.cgi?id=167293
2816         <rdar://problem/30401864>
2817
2818         Reviewed by Alex Christensen.
2819
2820         * Configurations/FeatureDefines.xcconfig:
2821
2822 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
2823
2824         Export various NSString symbols from WebFramePrivate.h
2825         https://bugs.webkit.org/show_bug.cgi?id=168702
2826
2827         Reviewed by Alexey Proskuryakov.
2828
2829         * WebKit.exp:
2830
2831 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
2832
2833         Export various NSString symbols from WebPreferencesPrivate.h
2834         https://bugs.webkit.org/show_bug.cgi?id=168701
2835
2836         Reviewed by Alexey Proskuryakov.
2837
2838         * WebKit.exp:
2839
2840 2017-02-21  Joseph Pecoraro  <pecoraro@apple.com>
2841
2842         Add missing WebConsoleMessage string key
2843         https://bugs.webkit.org/show_bug.cgi?id=168690
2844
2845         Reviewed by Alexey Proskuryakov.
2846
2847         * WebKit.exp:
2848         * WebView/WebUIDelegatePrivate.h:
2849         This key has an implementation but was not extern / exported like the others.
2850
2851 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
2852
2853         Export various NSString symbols from WebViewPrivate.h
2854         https://bugs.webkit.org/show_bug.cgi?id=168689
2855
2856         Reviewed by Alexey Proskuryakov.
2857
2858         * WebKit.exp:
2859
2860 2017-02-21  Commit Queue  <commit-queue@webkit.org>
2861
2862         Unreviewed, rolling out r212768.
2863         https://bugs.webkit.org/show_bug.cgi?id=168698
2864
2865         Rolling out since this would break other projects. (Requested
2866         by aakashjain on #webkit).
2867
2868         Reverted changeset:
2869
2870         "[iOS] Remove old WebKit1 MemoryMeasure helper."
2871         https://bugs.webkit.org/show_bug.cgi?id=168675
2872         http://trac.webkit.org/changeset/212768
2873
2874 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
2875
2876         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
2877         https://bugs.webkit.org/show_bug.cgi?id=168620
2878         <rdar://problem/30617772>
2879
2880         Reviewed by Tim Horton.
2881
2882         * WebView/WebPreferenceKeysPrivate.h:
2883         * WebView/WebPreferences.mm:
2884         (+[WebPreferences initialize]):
2885         (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
2886         (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
2887         * WebView/WebPreferencesPrivate.h:
2888
2889 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
2890
2891         Export various NSString symbols from WebUIDelegatePrivate.h
2892         https://bugs.webkit.org/show_bug.cgi?id=168679
2893
2894         Reviewed by Joseph Pecoraro.
2895
2896         * WebKit.exp:
2897
2898 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
2899
2900         Export symbols for various classes present in webkit SPI
2901         https://bugs.webkit.org/show_bug.cgi?id=168674
2902
2903         Reviewed by Dan Bernstein.
2904
2905         * WebKit.exp:
2906
2907 2017-02-21  Andreas Kling  <akling@apple.com>
2908
2909         [iOS] Remove old WebKit1 MemoryMeasure helper.
2910         <https://webkit.org/b/168675>
2911
2912         Reviewed by Sam Weinig.
2913
2914         * Configurations/WebKitLegacy.xcconfig:
2915         * Misc/WebCache.mm:
2916         (+[WebCache emptyInMemoryResources]):
2917         * WebView/WebView.mm:
2918
2919 2017-02-21  Andreas Kling  <akling@apple.com>
2920
2921         [iOS] WebKit1 should use shared memory pressure handler code.
2922         <https://webkit.org/b/168653>
2923
2924         Reviewed by Antti Koivisto.
2925
2926         Register a WebThread-aware memory callback with the shared MemoryPressureHandler
2927         and get rid of the old iOS WebKit1 specific implementation. Some of it was even
2928         dead code since MobileSafari has been using WebKit2 for quite a while.
2929
2930         * WebView/WebView.h:
2931         * WebView/WebView.mm:
2932         (WebInstallMemoryPressureHandler):
2933         (+[WebView _handleMemoryWarning]): Deleted.
2934         (+[WebView registerForMemoryNotifications]): Deleted.
2935         (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
2936         (+[WebView garbageCollectNow]): Deleted.
2937         (+[WebView purgeInactiveFontData]): Deleted.
2938         (+[WebView drainLayerPool]): Deleted.
2939         (+[WebView discardAllCompiledCode]): Deleted.
2940         (+[WebView _clearMemoryPressure]): Deleted.
2941         (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
2942         * WebView/WebViewPrivate.h:
2943
2944 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
2945
2946         Stop exporting interface WebCoreScrollView on iOS
2947         https://bugs.webkit.org/show_bug.cgi?id=168536
2948
2949         Reviewed by Dan Bernstein.
2950
2951         * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
2952         * WebKit.mac.exp: Ditto.
2953         * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
2954
2955 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
2956
2957         Exclude various mac-specific header files from iOS build
2958         https://bugs.webkit.org/show_bug.cgi?id=168621
2959
2960         Reviewed by Dan Bernstein.
2961
2962         * Configurations/WebKitLegacy.xcconfig:
2963
2964 2017-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2965
2966         Add plumbing to the UI process for TextIndicatorData when computing the drag image
2967         https://bugs.webkit.org/show_bug.cgi?id=168583
2968         Work towards <rdar://problem/30313681>
2969
2970         Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
2971
2972         Reviewed by Tim Horton.
2973
2974         * WebView/WebHTMLView.mm:
2975         (-[WebHTMLView _selectionDraggingImage]):
2976         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2977
2978 2017-02-17  Anders Carlsson  <andersca@apple.com>
2979
2980         Add a new drag code path and use it for dragging plain text
2981         https://bugs.webkit.org/show_bug.cgi?id=168534
2982
2983         Reviewed by Geoffrey Garen.
2984
2985         * WebCoreSupport/WebDragClient.h:
2986         Add new members.
2987
2988         * WebCoreSupport/WebDragClient.mm:
2989         (WebDragClient::useLegacyDragClient):
2990         Return false here.
2991
2992         (WebDragClient::beginDrag):
2993         New client member function. Create an NSDraggingItem and use it to begin a dragging session.
2994
2995         * WebView/WebHTMLView.mm:
2996         (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
2997         Get the source operation mask from WebCore.
2998
2999         (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
3000         Send a fake mouse up event.
3001
3002         * WebView/WebHTMLViewInternal.h:
3003         Declare that WebHTMLView conforms to NSDraggingSource.
3004
3005 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
3006
3007         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
3008         https://bugs.webkit.org/show_bug.cgi?id=168342
3009         rdar://problem/26182266
3010
3011         Reviewed by Tim Horton.
3012
3013         * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
3014         symbols to re-export.
3015
3016 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3017
3018         Stop exporting DOMTokenList from WebKit
3019         https://bugs.webkit.org/show_bug.cgi?id=168544
3020
3021         Reviewed by Alexey Proskuryakov.
3022
3023         * WebKit.exp:
3024
3025 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
3026
3027         Clean up how WebKit exports _WebCreateFragment
3028         https://bugs.webkit.org/show_bug.cgi?id=168579
3029
3030         Reviewed by Dan Bernstein.
3031
3032         * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
3033         * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
3034
3035 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3036
3037         Stop exporting DOMNodeFilter
3038         https://bugs.webkit.org/show_bug.cgi?id=168542
3039
3040         Reviewed by Alexey Proskuryakov.
3041
3042         * WebKit.exp:
3043
3044 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
3045
3046         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
3047         https://bugs.webkit.org/show_bug.cgi?id=167693
3048
3049         Reviewed by Sergio Villar Senin.
3050
3051         * Configurations/FeatureDefines.xcconfig:
3052         * WebView/WebPreferences.mm:
3053         (+[WebPreferences initialize]):
3054         * WebView/WebView.mm:
3055         (-[WebView _preferencesChanged:]):
3056
3057 2017-02-15  Brady Eidson  <beidson@apple.com>
3058
3059         Stop backing up localStorage databases to iCloud by default.
3060         <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
3061
3062         Reviewed by Geoffrey Garen.
3063
3064         * Misc/WebKitVersionChecks.h:
3065         * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
3066         (WebKitLinkedOnOrAfter):
3067         (setWebKitLinkTimeVersion):
3068         (WebKitLinkTimeVersion):
3069         (linkedOnOrAfter):
3070
3071         * Storage/WebStorageManager.mm:
3072         (WebKitInitializeStorageIfNecessary):
3073
3074 2017-02-16  Daniel Bates  <dabates@apple.com>
3075
3076         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
3077         https://bugs.webkit.org/show_bug.cgi?id=168417
3078         <rdar://problem/30541748>
3079
3080         Reviewed by Brent Fulgham.
3081
3082         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
3083         Widget* as it is always called with a valid Widget.
3084
3085         * WebCoreSupport/WebFrameLoaderClient.h:
3086         * WebCoreSupport/WebFrameLoaderClient.mm:
3087         (WebFrameLoaderClient::redirectDataToPlugin):
3088         * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
3089         as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
3090         r180570 (2 years ago) though Xcode still references this ordering file (why?).
3091
3092 2017-02-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3093
3094         [JSC] Drop PassRefPtr in inspector/
3095         https://bugs.webkit.org/show_bug.cgi?id=168420
3096
3097         Reviewed by Alex Christensen.
3098
3099         * WebView/WebScriptDebugger.mm:
3100         (WebScriptDebugger::handlePause):
3101
3102 2017-02-16  Simon Fraser  <simon.fraser@apple.com>
3103
3104         Clean up use of some CALayer-related SPI
3105         https://bugs.webkit.org/show_bug.cgi?id=168401
3106
3107         Reviewed by Tim Horton.
3108
3109         Include CALayer.h not CATiledLayer.h.
3110
3111         * WebInspector/WebNodeHighlight.h:
3112
3113 2017-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3114
3115         Fix the build after r212379
3116
3117         Rubber-stamped by Anders Carlsson.
3118
3119         * WebCoreSupport/WebDragClient.mm:
3120         (WebDragClient::startDrag):
3121
3122 2017-02-15  Anders Carlsson  <andersca@apple.com>
3123
3124         Modernize DragClient::startDrag somewhat
3125         https://bugs.webkit.org/show_bug.cgi?id=168379
3126
3127         Reviewed by Tim Horton.
3128
3129         Update for WebCore changes.
3130
3131         * WebCoreSupport/WebDragClient.h:
3132         * WebCoreSupport/WebDragClient.mm:
3133         (WebDragClient::startDrag):
3134
3135 2017-02-14  Dean Jackson  <dino@apple.com>
3136
3137         Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
3138         https://bugs.webkit.org/show_bug.cgi?id=168339
3139
3140         Reviewed by Simon Fraser.
3141
3142         Use a better name.
3143
3144         * WebView/WebPreferenceKeysPrivate.h:
3145         * WebView/WebPreferences.mm:
3146         (+[WebPreferences initialize]):
3147         (-[WebPreferences forceLowPowerGPUForWebGL]):
3148         (-[WebPreferences setForceLowPowerGPUForWebGL:]):
3149         (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
3150         (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
3151         * WebView/WebPreferencesPrivate.h:
3152         * WebView/WebView.mm:
3153         (-[WebView _preferencesChanged:]):
3154
3155 2017-02-14  Chris Dumez  <cdumez@apple.com>
3156
3157         HTML Form Validation bubble should take minimum font size setting into consideration
3158         https://bugs.webkit.org/show_bug.cgi?id=168271
3159         <rdar://problem/29869869>
3160
3161         Reviewed by Simon Fraser.
3162
3163         * WebView/WebView.mm:
3164         (-[WebView _contentsOfUserInterfaceItem:]):
3165         Return font size used in the validation bubble.
3166
3167         (-[WebView showFormValidationMessage:withAnchorRect:]):
3168         Pass minimum font size setting when constructing the validation bubble.
3169
3170 2017-02-14  Anders Carlsson  <andersca@apple.com>
3171
3172         Remove an unused delegate method
3173         https://bugs.webkit.org/show_bug.cgi?id=168328
3174
3175         Reviewed by Wenson Hsieh.
3176
3177         * DefaultDelegates/WebDefaultUIDelegate.m:
3178         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
3179
3180 2017-02-14  Alexey Proskuryakov  <ap@apple.com>
3181
3182         WebCore shouldn't export SystemMemory.h
3183         https://bugs.webkit.org/show_bug.cgi?id=168285
3184
3185         Reviewed by Alex Christensen.
3186
3187         * MigrateHeaders.make: And WebKit shouldn't re-export it.
3188
3189 2017-02-13  Alexey Proskuryakov  <ap@apple.com>
3190
3191         WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
3192         https://bugs.webkit.org/show_bug.cgi?id=168282
3193
3194         Reviewed by Dan Bernstein.
3195
3196         * MigrateHeaders.make:
3197
3198 2017-02-12  Dan Bernstein  <mitz@apple.com>
3199
3200         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
3201
3202         * WebView/WebHTMLView.mm:
3203         (createShareMenuItem): Use non-deprecated method.
3204
3205 2017-02-12  Dan Bernstein  <mitz@apple.com>
3206
3207         [Cocoa] Some -respondsToSelector: checks are unnecessary
3208         https://bugs.webkit.org/show_bug.cgi?id=168183
3209
3210         Reviewed by Tim Horton.
3211
3212         * WebView/WebFullScreenController.mm:
3213         (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
3214           responds to -isOnActiveSpace.
3215         (-[WebFullScreenController exitFullScreen]): Ditto.
3216         (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
3217           NSApplication responds to -setPresentationOptions.
3218
3219         * WebView/WebHTMLView.mm:
3220         (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
3221         (-[WebHTMLView otherMouseDown:]): Ditto.
3222
3223         * WebView/WebImmediateActionController.mm:
3224         (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
3225         (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
3226
3227         * WebView/WebView.mm:
3228         (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
3229         (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
3230
3231 2017-02-10  Daniel Bates  <dabates@apple.com>
3232
3233         Detach frame from document when entering page cache
3234         https://bugs.webkit.org/show_bug.cgi?id=166774
3235         <rdar://problem/29904368>
3236
3237         Reviewed by Chris Dumez.
3238
3239         * WebView/WebPreferenceKeysPrivate.h:
3240         * WebView/WebPreferences.mm:
3241         (+[WebPreferences initialize]):
3242         (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
3243         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
3244         * WebView/WebPreferencesPrivate.h:
3245         * WebView/WebView.mm:
3246         (-[WebView _preferencesChanged:]):
3247
3248 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
3249
3250         [Resource Timing] Enable Resource Timing by default in Tests
3251         https://bugs.webkit.org/show_bug.cgi?id=168145
3252
3253         Reviewed by Ryosuke Niwa.
3254
3255         * WebView/WebPreferenceKeysPrivate.h:
3256         * WebView/WebPreferences.mm:
3257         (+[WebPreferences initialize]):
3258         (-[WebPreferences resourceTimingEnabled]):
3259         (-[WebPreferences setResourceTimingEnabled:]):
3260         * WebView/WebPreferencesPrivate.h:
3261         * WebView/WebView.mm:
3262         (-[WebView _preferencesChanged:]):
3263
3264 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
3265
3266         cleanup WebLocalizableStrings.
3267         https://bugs.webkit.org/show_bug.cgi?id=168078
3268
3269         Reviewed by Alexey Proskuryakov.
3270
3271         * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
3272         as it's for each framework's own consumption, and never needs to be exported.
3273
3274 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
3275
3276         WebResourceLoadDelegatePrivate.h cannot be imported standalone
3277         https://bugs.webkit.org/show_bug.cgi?id=168096
3278
3279         Reviewed by Alexey Proskuryakov.
3280
3281         * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
3282
3283 2017-02-09  Antti Koivisto  <antti@apple.com>
3284
3285         Remove most cases of #if ENABLE(CACHE_PARTITIONING)
3286         https://bugs.webkit.org/show_bug.cgi?id=167990
3287
3288         Reviewed by Sam Weinig.
3289
3290         * Misc/WebCache.mm:
3291         (+[WebCache addImageToCache:forURL:forFrame:]):
3292         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3293         * WebCoreSupport/WebSystemInterface.mm:
3294         (InitWebCoreSystemInterface):
3295
3296 2017-02-07  Alexey Proskuryakov  <ap@apple.com>
3297
3298         Don't migrate WebKit DOM headers in MigrateHeaders.make
3299         https://bugs.webkit.org/show_bug.cgi?id=167608
3300
3301         Reviewed by Darin Adler.
3302
3303         Stop migrating DOM headers that are now in WebKit.
3304
3305         * DOM/DOMDOMImplementation.h: Removed.
3306         * DOM/DOMDOMImplementation.mm: Removed.
3307         * DOM/DOMDOMImplementationInternal.h: Removed.
3308         * DOM/DOMDOMTokenList.h: Removed.
3309         * DOM/DOMDOMTokenList.mm: Removed.
3310         * DOM/DOMDOMTokenListInternal.h: Removed.
3311         * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
3312         * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
3313         * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
3314         * DOM/DOMTokenList.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.h.
3315         * DOM/DOMTokenList.mm: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.mm.
3316         * DOM/DOMTokenListInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenListInternal.h.
3317         As the files are not in WebCore any more, there is no need to differentiate from
3318         WebCore internal headers with the same name. This makes it possible to make these
3319         headers private using Xcode mechanisms, as opposed to copying with a shell script.
3320
3321         * DOM/DOMElement.mm: Removed "using namespace WebCore". Other DOM implementation
3322         files don't have it.
3323
3324         * DOM/DOMCore.h:
3325         * DOM/DOMDocument.mm:
3326         * DOM/DOMHTMLAnchorElement.mm:
3327         * DOM/DOMHTMLAreaElement.mm:
3328         * DOM/DOMHTMLLinkElement.mm:
3329         * DOM/DOMUtility.mm:
3330         No more "DOMDOM".
3331
3332         * WebKit.exp:
3333         No more "DOMDOM". DOMDOMTokenList was not directly exposed via an SPI header, so
3334         renaming it is likely to be safe.
3335
3336         * MigrateHeaders.make: Don't migrate WebKit headers.
3337
3338         * Configurations/WebKitLegacy.xcconfig: Don't include two iOS specific SPI headers
3339         on macOS.
3340
3341 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
3342
3343         Don't re-export PluginData.h from WebKit
3344         https://bugs.webkit.org/show_bug.cgi?id=168020
3345
3346         Reviewed by Alexey Proskuryakov.
3347
3348         * MigrateHeaders.make: Removed PluginData.h
3349
3350 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
3351
3352         Don't re-export WKUtilities.h from WebKit
3353         https://bugs.webkit.org/show_bug.cgi?id=167977
3354
3355         Reviewed by Alexey Proskuryakov.
3356
3357         * MigrateHeaders.make: Removed WKUtilities.h
3358
3359 2017-02-06  Alex Christensen  <achristensen@webkit.org>
3360
3361         credentials should be partitioned by main document domain
3362         https://bugs.webkit.org/show_bug.cgi?id=166998
3363         rdar://problem/22901123
3364
3365         Reviewed by Brady Eidson.
3366
3367         * Misc/WebDownload.mm:
3368         * Plugins/WebBaseNetscapePluginView.mm:
3369         (WebKit::getAuthenticationInfo):
3370         Don't use partitioned credentials for WebKit1 plugins or downloads.
3371         Downloads should be authenticated before becoming a download anyways.
3372
3373 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3374
3375         Rename AnimationController to CSSAnimationController
3376         https://bugs.webkit.org/show_bug.cgi?id=167829
3377
3378         Reviewed by Simon Fraser.
3379
3380         * WebView/WebFrame.mm:
3381         * WebView/WebView.mm:
3382
3383 2017-02-03  Chris Dumez  <cdumez@apple.com>
3384
3385         Dismiss HTML form validation popover when pressing Escape key
3386         https://bugs.webkit.org/show_bug.cgi?id=167716
3387         <rdar://problem/29872943>
3388
3389         Reviewed by Simon Fraser.
3390
3391         Override ValidationMessageClient::hideAnyValidationMessage().
3392
3393         * WebCoreSupport/WebValidationMessageClient.h:
3394         * WebCoreSupport/WebValidationMessageClient.mm:
3395         (WebValidationMessageClient::hideAnyValidationMessage):
3396
3397 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3398
3399         Drag images should be anchored to the mouse location
3400         https://bugs.webkit.org/show_bug.cgi?id=167690
3401         <rdar://problem/30295261>
3402
3403         Reviewed by Enrica Casucci.
3404
3405         Adds some plumbing for the anchor point in the WK1 client layer.
3406
3407         * WebCoreSupport/WebDragClient.h:
3408         * WebCoreSupport/WebDragClient.mm:
3409         (WebDragClient::startDrag):
3410
3411 2017-02-02  Chris Dumez  <cdumez@apple.com>
3412
3413         Rename Node::inDocument() to isConnected()
3414         https://bugs.webkit.org/show_bug.cgi?id=167743
3415
3416         Reviewed by Sam Weinig.
3417
3418         Rename Node::inDocument() to isConnected() to match the DOM specification more closely:
3419         - https://dom.spec.whatwg.org/#connected
3420
3421         * DOM/DOMNode.mm:
3422         (-[DOMNode isConnected]):
3423         * WebView/WebFrame.mm:
3424         (-[WebFrame selectNSRange:onElement:]):
3425
3426 2017-02-02  Chris Dumez  <cdumez@apple.com>
3427
3428         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
3429         https://bugs.webkit.org/show_bug.cgi?id=167738
3430         <rdar://problem/30229990>
3431
3432         Reviewed by Andreas Kling.
3433
3434         The BackForwardClient no longer needs to worry about removing HistoryItems
3435         from the PageCache now that WebCore takes care of it.
3436
3437         * History/BackForwardList.mm:
3438         (BackForwardList::close):
3439
3440 2017-02-02  Yongjun Zhang  <yongjun_zhang@apple.com>
3441
3442         In iOS, we should take background assertion when accessing localstorage databases.
3443         https://bugs.webkit.org/show_bug.cgi?id=165478
3444
3445         Move database transaction background task handling code from WebDatabaseManager to
3446         WebCore's WebSQLiteDatabaseTrackerClient.
3447
3448         Reviewed by Brady Eidson.
3449
3450         * Storage/WebDatabaseManager.mm:
3451         * Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.
3452         * WebCoreSupport/WebApplicationCache.mm:
3453         (+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.
3454         * WebView/WebView.mm:
3455         (-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.
3456
3457 2017-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3458
3459         [WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
3460         https://bugs.webkit.org/show_bug.cgi?id=167695
3461         <rdar://problem/30305390>
3462
3463         Reviewed by Sam Weinig.
3464
3465         Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
3466         exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
3467         is destroyed.
3468
3469         * WebView/WebView.mm:
3470         (-[WebView _commonInitializationWithFrameName:groupName:]):
3471
3472 2017-01-31  Joseph Pecoraro  <pecoraro@apple.com>
3473
3474         ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
3475         https://bugs.webkit.org/show_bug.cgi?id=167684
3476
3477         Reviewed by Dan Bernstein.
3478
3479         * DOM/DOMHTML.mm:
3480         (-[DOMHTMLInputElement _isAutofilled]): Deleted.
3481         (-[DOMHTMLInputElement _setAutofilled:]): Deleted.
3482         Consolidate in the WebDOMOperationsPrivate category.
3483
3484         * DOM/DOMPrivate.h:
3485         Include WebDOMOperationsPrivate header to get other DOM Private categories.
3486
3487         * DOM/WebDOMOperations.mm:
3488         (-[DOMHTMLInputElement _isAutofilled]):
3489         * DOM/WebDOMOperationsPrivate.h:
3490         Include getter alongside the setter.
3491
3492 2017-01-31  Jessie Berlin  <jberlin@webkit.org>
3493
3494         Build fix.
3495
3496         * Misc/WebNSPasteboardExtras.mm:
3497         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3498         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3499         * WebView/WebHTMLView.mm:
3500         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3501         (-[WebHTMLView copyFont:]):
3502
3503 2017-01-30  Andy Estes  <aestes@apple.com>
3504
3505         [QuickLook] FrameLoaderClient should return the new QuickLookHandleClient it creates
3506         https://bugs.webkit.org/show_bug.cgi?id=167625
3507
3508         Reviewed by Andreas Kling.
3509
3510         * WebCoreSupport/WebFrameLoaderClient.h: Declared createQuickLookHandleClient().
3511         * WebCoreSupport/WebFrameLoaderClient.mm:
3512         (WebFrameLoaderClient::createQuickLookHandleClient): Renamed from didCreateQuickLookHandle().
3513         (WebFrameLoaderClient::didCreateQuickLookHandle): Renamed to createQuickLookHandleClient().
3514
3515 2017-01-30  Chris Dumez  <cdumez@apple.com>
3516
3517         Drop legacy Attributes.isId attribute
3518         https://bugs.webkit.org/show_bug.cgi?id=167603
3519
3520         Reviewed by Ryosuke Niwa.
3521
3522         Keep Attr.isId in ObjC bindings.
3523
3524         * DOM/DOMAttr.mm:
3525         (-[DOMAttr isId]):
3526
3527 2017-01-30  Andreas Kling  <akling@apple.com>
3528
3529         [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.
3530         <https://webkit.org/b/167580>
3531
3532         Reviewed by Antti Koivisto.
3533
3534         Avoid the implicit strong capture of self by keeping it in a __block variable.
3535         Also add code to dealloc to unregister the event monitor, since it will otherwise leak.
3536         This fixes huge WebHTMLView leaks seen on the leaks bot.
3537
3538         * WebView/WebHTMLView.mm:
3539         (-[WebHTMLViewPrivate dealloc]):
3540         (-[WebHTMLView viewDidMoveToWindow]):
3541
3542 2017-01-29  Andy Estes  <aestes@apple.com>
3543
3544         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
3545         https://bugs.webkit.org/show_bug.cgi?id=167563
3546         <rdar://problem/30253207>
3547
3548         Reviewed by Andreas Kling.
3549
3550         Instead of only saving QuickLook documents to a temporary file when the client is
3551         MobileSafari, base this decision on a WebPreference that clients can choose to enable.
3552
3553         This also changes the SPI for accessing the temporary file path and UTI. Instead of
3554         -[WebView quickLookContentForURL:], which requires the client to pass the response URL of
3555         the frame that saved the QuickLook document, the content dictionary is now stored as a
3556         property of WebDataSource.
3557
3558         This also removes the manual lifetime management of the QLPreviewConverter from
3559         QuickLookDocumentWriter. The QLPreviewConverter is kept alive by DocumentLoader these days,
3560         which ensures it lives long enough to respond to subresource requests.
3561
3562         New API test: QuickLook.LegacyQuickLookContent
3563
3564         * WebCoreSupport/WebFrameLoaderClient.mm:
3565         (WebFrameLoaderClient::didCreateQuickLookHandle): Moved the logic of deciding whether to
3566         write a temporary file to here from the QuickLookDocumentWriter constructor.
3567         * WebView/WebDataSource.mm: Declared _quickLookContent.
3568         (-[WebDataSource _quickLookContent]):
3569         (-[WebDataSource _setQuickLookContent:]):
3570         * WebView/WebDataSourceInternal.h: Overrode _quickLookContent as a read/write property.
3571         * WebView/WebDataSourcePrivate.h: Declared _quickLookContent as a readonly property.
3572         * WebView/WebPreferenceKeysPrivate.h: Defined WebKitQuickLookDocumentSavingPreferenceKey.
3573         * WebView/WebPreferences.mm:
3574         (-[WebPreferences quickLookDocumentSavingEnabled]):
3575         (-[WebPreferences setQuickLookDocumentSavingEnabled:]):
3576         * WebView/WebPreferencesPrivate.h: Declared property quickLookDocumentSavingEnabled.
3577         * WebView/WebView.mm:
3578         (-[WebView quickLookContentForURL:]): Changed to always return nil.
3579         * WebView/WebViewPrivate.h: Added a comment stating that clients should use
3580         -[WebDataSource _quickLookContent] instead.
3581
3582 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
3583
3584         Add Link Preload as an off-by-default experimental feature menu item.
3585         https://bugs.webkit.org/show_bug.cgi?id=167201
3586
3587         Reviewed by Ryosuke Niwa.
3588
3589         * WebView/WebPreferenceKeysPrivate.h:
3590         * WebView/WebPreferences.mm:
3591         (-[WebPreferences linkPreloadEnabled]):
3592         (-[WebPreferences setLinkPreloadEnabled:]):
3593         * WebView/WebPreferencesPrivate.h:
3594         * WebView/WebView.mm:
3595         (-[WebView _preferencesChanged:]):
3596
3597 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
3598
3599         Add User Timing Experimental Feature
3600         https://bugs.webkit.org/show_bug.cgi?id=167542
3601         <rdar://problem/22746307>
3602
3603         Reviewed by Ryosuke Niwa.
3604
3605         * WebView/WebPreferenceKeysPrivate.h:
3606         * WebView/WebPreferences.mm:
3607         (+[WebPreferences initialize]):
3608         (-[WebPreferences userTimingEnabled]):
3609         (-[WebPreferences setUserTimingEnabled:]):
3610         * WebView/WebPreferencesPrivate.h:
3611         * WebView/WebView.mm:
3612         (-[WebView _preferencesChanged:]):
3613         Add setting for User Timing runtime enabled feature.
3614
3615 2017-01-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3616
3617         [WK1] Do not prevent the drag client from initializing on Mac
3618         https://bugs.webkit.org/show_bug.cgi?id=167541
3619
3620         Reviewed by Dan Bernstein.
3621
3622         Fixes fallout from r211192. To ensure compability with WebKit clients, we need to ensure that WebDragClient is
3623         initialized everywhere when creating a WebView. Stub out method implementations as no-ops for non-Mac platforms.
3624         This caused certain clients, such as Mail, to crash when a webView closes due to  null dereference.
3625
3626         * WebCoreSupport/WebDragClient.mm:
3627         (WebDragClient::WebDragClient):
3628         (WebDragClient::actionMaskForDrag):
3629         (WebDragClient::willPerformDragDestinationAction):
3630         (WebDragClient::dragSourceActionMaskForPoint):
3631         (WebDragClient::willPerformDragSourceAction):
3632         (WebDragClient::startDrag):
3633         (WebDragClient::declareAndWriteDragImage):
3634         (WebDragClient::declareAndWriteAttachment):
3635         * WebView/WebView.mm:
3636         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3637
3638 2017-01-26  Chris Dumez  <cdumez@apple.com>
3639
3640         Crash when navigating back to a page in PacheCache when one of its frames has been removed
3641         https://bugs.webkit.org/show_bug.cgi?id=167421
3642         <rdar://problem/30188490>
3643
3644         Reviewed by Darin Adler.
3645
3646         Add a new setting allowing layout tests to enable PageCache in a window
3647         that has an opener, for convenience.
3648
3649         * WebView/WebPreferenceKeysPrivate.h:
3650         * WebView/WebPreferences.mm:
3651         (+[WebPreferences initialize]):
3652         (-[WebPreferences allowsPageCacheWithWindowOpener]):
3653         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]):
3654         * WebView/WebPreferencesPrivate.h:
3655         * WebView/WebView.mm:
3656         (-[WebView _preferencesChanged:]):
3657
3658 2017-01-26  Keith Miller  <keith_miller@apple.com>
3659
3660         classInfo should take a VM so it is not materialized from the object on each call
3661         https://bugs.webkit.org/show_bug.cgi?id=167424
3662
3663         Rubber Stamped by Michael Saboff.
3664
3665         Previously, classInfo() would get the VM from the target's
3666         MarkedBlock.  Most callers already have a VM on hand, so it is
3667         wasteful to compute the VM from the marked block every time. This
3668         patch refactors some of the most common callers of classInfo(),
3669         jsDynamicCast and inherits to take a VM as well.
3670
3671         * DOM/DOM.mm:
3672         (+[DOMNode _nodeFromJSWrapper:]):
3673         * DOM/DOMUtility.mm:
3674         (createDOMWrapper):
3675         * DOM/WebDOMOperations.mm:
3676         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3677         (WebKit::getObjectID):
3678         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
3679         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
3680         * Plugins/Hosted/ProxyInstance.mm:
3681         (WebKit::ProxyRuntimeMethod::finishCreation):
3682         (WebKit::ProxyInstance::invokeMethod):
3683         * Plugins/Hosted/ProxyRuntimeObject.mm:
3684         (WebKit::ProxyRuntimeObject::finishCreation):
3685         * WebView/WebFrame.mm:
3686         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3687         * WebView/WebView.mm:
3688         (+[WebView _reportException:inContext:]):
3689         (aeDescFromJSValue):
3690         (-[WebView _notificationIDForTesting:]):
3691
3692 2017-01-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3693
3694         REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar in HTML Notes
3695         https://bugs.webkit.org/show_bug.cgi?id=167472
3696         <rdar://problem/30149809>
3697
3698         Reviewed by Beth Dakin.
3699
3700         Revision 207483 caused the touch bar to stop showing up in HTML Notes due to -updateTextTouchBar not
3701         initializing the text touch bar and causing -makeTouchBar to return nil while processing a mouse click. The
3702         purpose of bailing out of the update was to prevent the text touch bar from thrashing during a selection drag.
3703         If the text touch bar doesn't exist yet, we don't have to worry about its appearance flickering from a different
3704         previous state, so we should just allow the touch bar to update instead.
3705
3706         * WebView/WebView.mm:
3707         (-[WebView updateTextTouchBar]):
3708
3709 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
3710
3711         Crash when setting custom scale factor.
3712         https://bugs.webkit.org/show_bug.cgi?id=167369
3713
3714         Reviewed by Sam Weinig.
3715
3716         Add null pointer check.
3717
3718         * WebView/WebView.mm:
3719         (-[WebView _setCustomBackingScaleFactor:]):
3720
3721 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3722
3723         Refactor drag and drop implementation on Mac
3724         https://bugs.webkit.org/show_bug.cgi?id=167427
3725
3726         Reviewed by Enrica Casucci.
3727
3728         Refactor some WebKit1 code on the Mac pertaining to drag and drop. See WebCore ChangeLog for more details.
3729
3730         * Misc/WebNSPasteboardExtras.h:
3731         * WebCoreSupport/WebDragClient.mm:
3732         * WebView/WebFrame.mm:
3733         * WebView/WebFrameInternal.h:
3734         * WebView/WebHTMLView.mm:
3735         * WebView/WebView.mm:
3736         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3737
3738 2017-01-24  Youenn Fablet  <youennf@gmail.com>
3739
3740         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
3741         https://bugs.webkit.org/show_bug.cgi?id=167294
3742
3743         Reviewed by Alex Christensen.
3744
3745         * WebView/WebView.mm:
3746         (-[WebView _commonInitializationWithFrameName:groupName:]):
3747
3748 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3749
3750         Add support for named pasteboards, pasteboard strategies and platform pasteboards
3751         https://bugs.webkit.org/show_bug.cgi?id=167404
3752
3753         Reviewed by Enrica Casucci.
3754
3755         Adds pasteboard name as an argument to pasteboard-related WebPlatformStrategy methods.
3756
3757         * WebCoreSupport/WebPlatformStrategies.h:
3758         * WebCoreSupport/WebPlatformStrategies.mm:
3759         (WebPlatformStrategies::writeToPasteboard):
3760         (WebPlatformStrategies::getPasteboardItemsCount):
3761         (WebPlatformStrategies::readBufferFromPasteboard):
3762         (WebPlatformStrategies::readURLFromPasteboard):
3763         (WebPlatformStrategies::readStringFromPasteboard):
3764
3765 2017-01-25  Aakash Jain  <aakash_jain@apple.com>
3766
3767         LoadWebLocalizedStrings method should be moved in correct file
3768         https://bugs.webkit.org/show_bug.cgi?id=167393
3769
3770         Reviewed by Alexey Proskuryakov.
3771
3772         * Misc/WebLocalizableStrings.h: Deleted LoadWebLocalizedStrings method.
3773         * Misc/WebLocalizableStrings.mm:
3774         (LoadWebLocalizedStringsTimerCallback): Deleted, moved to WebUIKitSupport.mm
3775         (LoadWebLocalizedStrings): Deleted, moved to WebUIKitSupport.mm
3776
3777 2017-01-24  Zalan Bujtas  <zalan@apple.com>
3778
3779         Add simple line layout toggle to MiniBrowser
3780         https://bugs.webkit.org/show_bug.cgi?id=167405
3781
3782         Reviewed by Andreas Kling.
3783
3784         * WebView/WebPreferenceKeysPrivate.h:
3785         * WebView/WebPreferences.mm:
3786         (+[WebPreferences initialize]):
3787         (-[WebPreferences simpleLineLayoutEnabled]):
3788         (-[WebPreferences setSimpleLineLayoutEnabled:]):
3789         * WebView/WebPreferencesPrivate.h:
3790         * WebView/WebView.mm:
3791         (-[WebView _preferencesChanged:]):
3792
3793 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
3794
3795         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
3796         https://bugs.webkit.org/show_bug.cgi?id=167394
3797
3798         Reviewed by Ryosuke Niwa.
3799
3800         * Configurations/FeatureDefines.xcconfig:
3801
3802 2017-01-23  Chris Dumez  <cdumez@apple.com>
3803
3804         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
3805         https://bugs.webkit.org/show_bug.cgi?id=167308
3806         <rdar://problem/30144964>
3807
3808         Unreviewed, do a partial revert of r211033 to fix assertion.
3809
3810         * WebCoreSupport/WebChromeClient.h:
3811         * WebCoreSupport/WebChromeClient.mm:
3812         (WebChromeClient::exitFullScreenForElement):
3813
3814 2017-01-23  Joseph Pecoraro  <pecoraro@apple.com>
3815
3816         Remove allowWindowOpenWithoutUserGesture setting
3817         https://bugs.webkit.org/show_bug.cgi?id=167301
3818
3819         Reviewed by Darin Adler.
3820
3821         * WebView/WebView.mm:
3822         (-[WebView _preferencesChanged:]):
3823         Use the equivalent existing setting.
3824
3825 2017-01-20  Darin Adler  <darin@apple.com>
3826
3827         Remove PassRefPtr from "page" directory of WebCore, also deploy references
3828         https://bugs.webkit.org/show_bug.cgi?id=167224
3829
3830         Reviewed by Chris Dumez.
3831
3832         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
3833         (-[WebApplicationCacheQuotaManager quota]): Pass reference.
3834
3835         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
3836         * WebCoreSupport/WebChromeClient.mm:
3837         (WebChromeClient::focusedElementChanged): Ditto.
3838         (WebChromeClient::createWindow): Ditto.
3839         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
3840         (WebChromeClient::runJavaScriptAlert): Ditto.
3841         (WebChromeClient::runJavaScriptConfirm): Ditto.
3842         (WebChromeClient::runJavaScriptPrompt): Ditto.
3843         (WebChromeClient::contentsSizeChanged): Ditto.
3844         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
3845         (WebChromeClient::print): Ditto.
3846         (WebChromeClient::exceededDatabaseQuota): Ditto.
3847         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
3848         (WebChromeClient::createColorChooser): Ditto.
3849         (WebChromeClient::elementDidFocus): Ditto.
3850         (WebChromeClient::elementDidBlur): Ditto.
3851         (WebChromeClient::createPopupMenu): Ditto.
3852         (WebChromeClient::createSearchPopupMenu): Ditto.
3853         (WebChromeClient::attachRootGraphicsLayer): Ditto.
3854         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
3855         (WebChromeClient::supportsFullScreenForElement): Ditto.
3856         (WebChromeClient::enterFullScreenForElement): Ditto.
3857         (WebChromeClient::exitFullScreenForElement): Ditto.
3858
3859         * WebView/WebFrame.mm:
3860         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
3861         Updated for change to the appendChild function.
3862
3863 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
3864
3865         Remove -[WebFrame sendOrientationChangeEvent:] which is unused
3866         https://bugs.webkit.org/show_bug.cgi?id=167276
3867
3868         Reviewed by Alex Christensen.
3869         
3870         It was usurped by -deviceOrientationChanged in 2014.
3871
3872         * WebView/WebFrame.mm:
3873         (-[WebFrame sendOrientationChangeEvent:]): Deleted.
3874         * WebView/WebFramePrivate.h:
3875
3876 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
3877
3878         Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
3879         https://bugs.webkit.org/show_bug.cgi?id=167271
3880
3881         Reviewed by Alex Christensen.
3882         
3883         -_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
3884         overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),
3885
3886         * WebView/WebView.mm:
3887         (-[WebView _contentsSizeRespectingOverflow]): Deleted.
3888         * WebView/WebViewPrivate.h:
3889
3890 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3891
3892         Remove never changing IndexedDB RuntimeEnabledFeature
3893         https://bugs.webkit.org/show_bug.cgi?id=167278
3894
3895         Reviewed by Darin Adler.
3896
3897         * WebView/WebView.mm:
3898         (-[WebView _preferencesChanged:]):
3899
3900 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3901
3902         Cleanup RuntimeEnabledFeatures
3903         https://bugs.webkit.org/show_bug.cgi?id=167228
3904
3905         Reviewed by Simon Fraser.
3906
3907         * WebView/WebView.mm:
3908         (-[WebView _preferencesChanged:]):
3909
3910 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3911
3912         Remove outdated ENABLE(CSP_NEXT) build flag
3913         https://bugs.webkit.org/show_bug.cgi?id=167252
3914
3915         Reviewed by Brent Fulgham.
3916
3917         * Configurations/FeatureDefines.xcconfig:
3918
3919 2017-01-20  Antoine Quint  <graouts@apple.com>
3920
3921         [Modern Media Controls] Turn modern media controls on by default
3922         https://bugs.webkit.org/show_bug.cgi?id=165668
3923
3924         Reviewed by Dean Jackson.
3925
3926         Enabled modern media controls by default in WK1.
3927
3928         * WebView/WebPreferences.mm:
3929         (+[WebPreferences initialize]):
3930
3931 2017-01-19  Chris Dumez  <cdumez@apple.com>
3932
3933         iterable<> should be enabled on WK1
3934         https://bugs.webkit.org/show_bug.cgi?id=167221
3935         <rdar://problem/30108531>
3936
3937         Reviewed by Youenn Fablet.
3938
3939         * WebView/WebPreferenceKeysPrivate.h:
3940         * WebView/WebPreferences.mm:
3941         (-[WebPreferences setCustomElementsEnabled:]):
3942         (-[WebPreferences DOMIteratorEnabled]): Deleted.
3943         (-[WebPreferences setDOMIteratorEnabled:]): Deleted.
3944         * WebView/WebPreferencesPrivate.h:
3945         * WebView/WebView.mm:
3946         (-[WebView _preferencesChanged:]):
3947
3948 2017-01-19  Chris Dumez  <cdumez@apple.com>
3949
3950         Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
3951         https://bugs.webkit.org/show_bug.cgi?id=167215
3952         <rdar://problem/29885052>
3953
3954         Reviewed by Andreas Kling.
3955
3956         Make sure HTML validation bubble gets dismissed when its associated
3957         element's frame gets detached and that we do not crash.
3958
3959         * WebCoreSupport/WebValidationMessageClient.h:
3960         * WebCoreSupport/WebValidationMessageClient.mm:
3961         (WebValidationMessageClient::documentDetached):
3962
3963 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
3964
3965         [Cocoa] Variation fonts are erroneously disabled on iOS
3966         https://bugs.webkit.org/show_bug.cgi?id=167172
3967
3968         Reviewed by Simon Fraser.
3969
3970         OpenSource builders don't seem to understand sdk=embedded*.
3971
3972         * Configurations/FeatureDefines.xcconfig:
3973
3974 2017-01-19  Andreas Kling  <akling@apple.com>
3975
3976         ScriptExecutionContext::topOrigin() should return a reference.
3977         <https://webkit.org/b/167190>
3978
3979         Reviewed by Sam Weinig.
3980
3981         * Misc/WebCache.mm:
3982         (+[WebCache addImageToCache:forURL:forFrame:]):
3983         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3984
3985 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3986
3987         Unreviewed fix for the macOS build.
3988
3989         * Carbon/CarbonWindowAdapter.mm:
3990         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3991
3992 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3993
3994         Unreviewed, rolling out r210848.
3995
3996         This change introduced media-related LayoutTest failures and
3997         crashes on macOS.
3998
3999         Reverted changeset:
4000
4001         "[Modern Media Controls] Turn modern media controls on by
4002         default"
4003         https://bugs.webkit.org/show_bug.cgi?id=165668
4004         http://trac.webkit.org/changeset/210848
4005
4006 2017-01-18  Andreas Kling  <akling@apple.com>
4007
4008         Document::securityOrigin() should return a reference.
4009         <https://webkit.org/b/167124>
4010
4011         Reviewed by Sam Weinig.
4012
4013         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4014         (WebKit::NetscapePluginInstanceProxy::loadRequest):
4015         * Plugins/WebNetscapePluginStream.mm:
4016         (WebNetscapePluginStream::WebNetscapePluginStream):
4017         * Plugins/WebNetscapePluginView.mm:
4018         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
4019         * Plugins/WebPluginContainerCheck.mm:
4020         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
4021         * WebCoreSupport/WebChromeClient.mm:
4022         (WebChromeClient::exceededDatabaseQuota):
4023         * WebCoreSupport/WebFrameLoaderClient.h:
4024         * WebCoreSupport/WebFrameLoaderClient.mm:
4025         (WebFrameLoaderClient::didRunInsecureContent):
4026         * WebCoreSupport/WebGeolocationClient.mm:
4027         (WebGeolocationClient::requestPermission):
4028         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
4029         * WebView/WebFrame.mm:
4030         (-[WebFrame _allowsFollowingLink:]):
4031
4032 2017-01-18  Antoine Quint  <graouts@apple.com>
4033
4034         [Modern Media Controls] Turn modern media controls on by default
4035         https://bugs.webkit.org/show_bug.cgi?id=165668
4036
4037         Reviewed by Dean Jackson.
4038
4039         Enabled modern media controls by default in WK1. 
4040
4041         * WebView/WebPreferences.mm:
4042         (+[WebPreferences initialize]):
4043
4044 2017-01-15  Darin Adler  <darin@apple.com>
4045
4046         Remove PassRefPtr from "loader" directory of WebCore
4047         https://bugs.webkit.org/show_bug.cgi?id=167055
4048
4049         Reviewed by Alex Christensen.
4050
4051         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
4052         Also made class final and most functions private and final.
4053         * WebCoreSupport/WebChromeClient.mm:
4054         (WebChromeClient::runOpenPanel): Updated to take references.
4055
4056         * WebCoreSupport/WebEditorClient.h: Updated for changes to EditorClient.
4057         * WebCoreSupport/WebEditorClient.mm:
4058         (-[WebUndoStep initWithUndoStep:]): Take reference instead of PassRefPtr.
4059         (+[WebUndoStep stepWithUndoStep:]): Ditto.
4060         (-[WebUndoStep step]): Return reference instead of pointer.
4061         (-[WebEditorUndoTarget undoEditing:]): Updated for the above.
4062         (-[WebEditorUndoTarget redoEditing:]): Ditto.
4063         (WebEditorClient::registerUndoOrRedoStep): Take reference instead of
4064         PassRefPtr.
4065         (WebEditorClient::registerUndoStep): Ditto.
4066         (WebEditorClient::registerRedoStep): Ditto.
4067
4068         * WebCoreSupport/WebFrameLoaderClient.h: Updated for changes to
4069         FrameLoaderClient, marked functions final instead of override.
4070         * WebCoreSupport/WebFrameLoaderClient.mm:
4071         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Take
4072         pointer instead of PassRefPtr.
4073         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
4074         (makeFormFieldValuesDictionary): Take a reference.
4075         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Take Ref&& instead
4076         of PassRefPtr.
4077         (WebFrameLoaderClient::dispatchWillSubmitForm): Take a reference instead
4078         of PassRefPtr.
4079         (WebFrameLoaderClient::actionDictionary): Take a pointer instead of PassRePtr.
4080         (WebFrameLoaderClient::createFrame): Take a reference instead of a pointer.
4081         (WebFrameLoaderClient::createPlugin): Ditto.
4082         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
4083         (WebFrameLoaderClient::createNetworkingContext): Ditto.
4084         (WebFrameLoaderClient::didCreateQuickLookHandle): Pass a reference.
4085
4086         * WebCoreSupport/WebFrameNetworkingContext.h: Use Ref instead of PassRefPtr.
4087         * WebCoreSupport/WebFrameNetworkingContext.mm: Tweak style a bit.
4088
4089         * WebCoreSupport/WebOpenPanelResultListener.h: Take a reference instead of
4090         PassRefPtr. Use RefPtr for class field.
4091         * WebCoreSupport/WebOpenPanelResultListener.mm:
4092         (-[WebOpenPanelResultListener dealloc]): Deleted. Compiler will now do it
4093         correctly without us declaring anything explicitly.
4094         (-[WebOpenPanelResultListener cancel]): Get rid of hand-written deref code,
4095         and let RefPtr do the work.
4096         (-[WebOpenPanelResultListener chooseFilename:]): Ditto.
4097         (-[WebOpenPanelResultListener chooseFilenames:]): Ditto.
4098         (-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]):
4099         Rewrote to use a modern Objective-C for loop, reserveInitialCapacity,
4100         and uncheckedAppend.
4101
4102         * WebView/WebArchive.mm:
4103         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
4104         Updated for changes to LegacyWebArchive.
4105         (-[WebArchive mainResource]): Ditto.
4106         (-[WebArchive subresources]): Ditto.
4107         (-[WebArchive subframeArchives]): Ditto.
4108
4109         * WebView/WebDataSource.mm:
4110         (-[WebDataSource _addSubframeArchives:]): Use a modern Objective-C for loop
4111         instead of NSEnumerator.
4112         (-[WebDataSource _fileWrapperForURL:]): Use auto.
4113         (-[WebDataSource _documentFragmentWithArchive:]): Pass a reference.
4114         (-[WebDataSource mainResource]): Ditto.
4115         (-[WebDataSource subresources]): Ditto.
4116         (-[WebDataSource subresourceForURL:]): Ditto.
4117         (-[WebDataSource addSubresource:]): Ditto.
4118
4119         * WebView/WebResource.mm:
4120         (-[WebResourcePrivate initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
4121         (-[WebResourcePrivate dealloc]): Remove explicit deref since RefPtr will now take
4122         care of it
4123         (-[WebResource initWithCoder:]): Pass a reference.
4124         (-[WebResource encodeWithCoder:]): Updated since coreResource is now RefPtr.
4125         (-[WebResource _initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
4126         (-[WebResource _coreResource]): Return reference rather than pointer.
4127         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
4128         Added code to handle the null case and pass a reference rather than a pointer.
4129         * WebView/WebResourceInternal.h: Updated for the above.
4130
4131 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
4132
4133         Unreviewed, rolling out r210834
4134         https://bugs.webkit.org/show_bug.cgi?id=165668
4135
4136         It introduced dozens of test timeouts.
4137
4138         Reverted changeset:
4139         "[Modern Media Controls] Turn modern media controls on by default"
4140         https://bugs.webkit.org/show_bug.cgi?id=165668
4141         http://trac.webkit.org/changeset/210834
4142
4143 2017-01-17  Antoine Quint  <graouts@apple.com>
4144
4145         [Modern Media Controls] Turn modern media controls on by default
4146         https://bugs.webkit.org/show_bug.cgi?id=165668
4147
4148         Reviewed by Dean Jackson.
4149
4150         Enabled modern media controls by default in WK1. 
4151
4152         * WebView/WebPreferences.mm:
4153         (+[WebPreferences initialize]):
4154
4155 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
4156
4157         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
4158         https://bugs.webkit.org/show_bug.cgi?id=116551
4159         <rdar://problem/13949830>
4160
4161         Reviewed by Alex Christensen.
4162
4163         * Configurations/FeatureDefines.xcconfig:
4164
4165 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
4166
4167         Crash when closing tab with debugger paused
4168         https://bugs.webkit.org/show_bug.cgi?id=161746
4169         <rdar://problem/15607819>
4170
4171         Reviewed by Brian Burg and Brent Fulgham.
4172
4173         * WebView/WebView.mm:
4174         (WebKit::DeferredPageDestructor::createDeferredPageDestructor):
4175         (WebKit::DeferredPageDestructor::DeferredPageDestructor):
4176         (WebKit::DeferredPageDestructor::tryDestruction):
4177         (-[WebView _close]):
4178         Defer destruction of the Page if we are in a nested runloop.
4179
4180 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
4181
4182         Remove the REQUEST_ANIMATION_FRAME flag
4183         https://bugs.webkit.org/show_bug.cgi?id=156980
4184         <rdar://problem/25906849>
4185
4186         Reviewed by Simon Fraser.
4187
4188         * Configurations/FeatureDefines.xcconfig:
4189
4190 2017-01-16  Andy Estes  <aestes@apple.com>
4191
4192         [QuickLook] Do some cleanup in QuickLookHandle
4193         https://bugs.webkit.org/show_bug.cgi?id=166864
4194
4195         Reviewed by Darin Adler.
4196
4197         * WebCoreSupport/WebFrameLoaderClient.mm:
4198         (WebFrameLoaderClient::didCreateQuickLookHandle): Changed to pass a
4199         Ref<QuickLookHandleClient>&& to QuickLookHandle::setClient().
4200
4201 2017-01-15  Tim Horton  <timothy_horton@apple.com>
4202
4203         De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
4204         https://bugs.webkit.org/show_bug.cgi?id=167063
4205
4206         Reviewed by Dan Bernstein.
4207
4208         * WebView/WebHTMLView.mm:
4209         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
4210         (-[WebHTMLView _updateFontPanel]):
4211         * WebView/WebView.mm:
4212         (-[WebView typingAttributes]):
4213         Adjust to fontAttributesForSelectionStart returning a RetainPtr.
4214
4215 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
4216
4217         Remove ENABLE(DETAILS_ELEMENT) guards
4218         https://bugs.webkit.org/show_bug.cgi?id=167042
4219
4220         Reviewed by Alex Christensen.
4221
4222         * Configurations/FeatureDefines.xcconfig:
4223
4224 2017-01-11  Darin Adler  <darin@apple.com>
4225
4226         Remove PassRefPtr from more of "platform"
4227         https://bugs.webkit.org/show_bug.cgi?id=166809
4228
4229         Reviewed by Sam Weinig.
4230
4231         * WebCoreSupport/WebFrameLoaderClient.mm:
4232         (NetscapePluginWidget::handleEvent): Pass a reference.
4233         * WebView/WebView.mm:
4234         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
4235         Updated since the children set now contains Ref instead of RefPtr.
4236
4237