cfd90cdba0cd3d8c329b8f7118ce488d14cd7890
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-01-18  Antoine Quint  <graouts@apple.com>
2
3         [Modern Media Controls] Turn modern media controls on by default
4         https://bugs.webkit.org/show_bug.cgi?id=165668
5
6         Reviewed by Dean Jackson.
7
8         Enabled modern media controls by default in WK1. 
9
10         * WebView/WebPreferences.mm:
11         (+[WebPreferences initialize]):
12
13 2017-01-15  Darin Adler  <darin@apple.com>
14
15         Remove PassRefPtr from "loader" directory of WebCore
16         https://bugs.webkit.org/show_bug.cgi?id=167055
17
18         Reviewed by Alex Christensen.
19
20         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
21         Also made class final and most functions private and final.
22         * WebCoreSupport/WebChromeClient.mm:
23         (WebChromeClient::runOpenPanel): Updated to take references.
24
25         * WebCoreSupport/WebEditorClient.h: Updated for changes to EditorClient.
26         * WebCoreSupport/WebEditorClient.mm:
27         (-[WebUndoStep initWithUndoStep:]): Take reference instead of PassRefPtr.
28         (+[WebUndoStep stepWithUndoStep:]): Ditto.
29         (-[WebUndoStep step]): Return reference instead of pointer.
30         (-[WebEditorUndoTarget undoEditing:]): Updated for the above.
31         (-[WebEditorUndoTarget redoEditing:]): Ditto.
32         (WebEditorClient::registerUndoOrRedoStep): Take reference instead of
33         PassRefPtr.
34         (WebEditorClient::registerUndoStep): Ditto.
35         (WebEditorClient::registerRedoStep): Ditto.
36
37         * WebCoreSupport/WebFrameLoaderClient.h: Updated for changes to
38         FrameLoaderClient, marked functions final instead of override.
39         * WebCoreSupport/WebFrameLoaderClient.mm:
40         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Take
41         pointer instead of PassRefPtr.
42         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
43         (makeFormFieldValuesDictionary): Take a reference.
44         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Take Ref&& instead
45         of PassRefPtr.
46         (WebFrameLoaderClient::dispatchWillSubmitForm): Take a reference instead
47         of PassRefPtr.
48         (WebFrameLoaderClient::actionDictionary): Take a pointer instead of PassRePtr.
49         (WebFrameLoaderClient::createFrame): Take a reference instead of a pointer.
50         (WebFrameLoaderClient::createPlugin): Ditto.
51         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
52         (WebFrameLoaderClient::createNetworkingContext): Ditto.
53         (WebFrameLoaderClient::didCreateQuickLookHandle): Pass a reference.
54
55         * WebCoreSupport/WebFrameNetworkingContext.h: Use Ref instead of PassRefPtr.
56         * WebCoreSupport/WebFrameNetworkingContext.mm: Tweak style a bit.
57
58         * WebCoreSupport/WebOpenPanelResultListener.h: Take a reference instead of
59         PassRefPtr. Use RefPtr for class field.
60         * WebCoreSupport/WebOpenPanelResultListener.mm:
61         (-[WebOpenPanelResultListener dealloc]): Deleted. Compiler will now do it
62         correctly without us declaring anything explicitly.
63         (-[WebOpenPanelResultListener cancel]): Get rid of hand-written deref code,
64         and let RefPtr do the work.
65         (-[WebOpenPanelResultListener chooseFilename:]): Ditto.
66         (-[WebOpenPanelResultListener chooseFilenames:]): Ditto.
67         (-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]):
68         Rewrote to use a modern Objective-C for loop, reserveInitialCapacity,
69         and uncheckedAppend.
70
71         * WebView/WebArchive.mm:
72         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
73         Updated for changes to LegacyWebArchive.
74         (-[WebArchive mainResource]): Ditto.
75         (-[WebArchive subresources]): Ditto.
76         (-[WebArchive subframeArchives]): Ditto.
77
78         * WebView/WebDataSource.mm:
79         (-[WebDataSource _addSubframeArchives:]): Use a modern Objective-C for loop
80         instead of NSEnumerator.
81         (-[WebDataSource _fileWrapperForURL:]): Use auto.
82         (-[WebDataSource _documentFragmentWithArchive:]): Pass a reference.
83         (-[WebDataSource mainResource]): Ditto.
84         (-[WebDataSource subresources]): Ditto.
85         (-[WebDataSource subresourceForURL:]): Ditto.
86         (-[WebDataSource addSubresource:]): Ditto.
87
88         * WebView/WebResource.mm:
89         (-[WebResourcePrivate initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
90         (-[WebResourcePrivate dealloc]): Remove explicit deref since RefPtr will now take
91         care of it
92         (-[WebResource initWithCoder:]): Pass a reference.
93         (-[WebResource encodeWithCoder:]): Updated since coreResource is now RefPtr.
94         (-[WebResource _initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
95         (-[WebResource _coreResource]): Return reference rather than pointer.
96         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
97         Added code to handle the null case and pass a reference rather than a pointer.
98         * WebView/WebResourceInternal.h: Updated for the above.
99
100 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
101
102         Unreviewed, rolling out r210834
103         https://bugs.webkit.org/show_bug.cgi?id=165668
104
105         It introduced dozens of test timeouts.
106
107         Reverted changeset:
108         "[Modern Media Controls] Turn modern media controls on by default"
109         https://bugs.webkit.org/show_bug.cgi?id=165668
110         http://trac.webkit.org/changeset/210834
111
112 2017-01-17  Antoine Quint  <graouts@apple.com>
113
114         [Modern Media Controls] Turn modern media controls on by default
115         https://bugs.webkit.org/show_bug.cgi?id=165668
116
117         Reviewed by Dean Jackson.
118
119         Enabled modern media controls by default in WK1. 
120
121         * WebView/WebPreferences.mm:
122         (+[WebPreferences initialize]):
123
124 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
125
126         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
127         https://bugs.webkit.org/show_bug.cgi?id=116551
128         <rdar://problem/13949830>
129
130         Reviewed by Alex Christensen.
131
132         * Configurations/FeatureDefines.xcconfig:
133
134 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
135
136         Crash when closing tab with debugger paused
137         https://bugs.webkit.org/show_bug.cgi?id=161746
138         <rdar://problem/15607819>
139
140         Reviewed by Brian Burg and Brent Fulgham.
141
142         * WebView/WebView.mm:
143         (WebKit::DeferredPageDestructor::createDeferredPageDestructor):
144         (WebKit::DeferredPageDestructor::DeferredPageDestructor):
145         (WebKit::DeferredPageDestructor::tryDestruction):
146         (-[WebView _close]):
147         Defer destruction of the Page if we are in a nested runloop.
148
149 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
150
151         Remove the REQUEST_ANIMATION_FRAME flag
152         https://bugs.webkit.org/show_bug.cgi?id=156980
153         <rdar://problem/25906849>
154
155         Reviewed by Simon Fraser.
156
157         * Configurations/FeatureDefines.xcconfig:
158
159 2017-01-16  Andy Estes  <aestes@apple.com>
160
161         [QuickLook] Do some cleanup in QuickLookHandle
162         https://bugs.webkit.org/show_bug.cgi?id=166864
163
164         Reviewed by Darin Adler.
165
166         * WebCoreSupport/WebFrameLoaderClient.mm:
167         (WebFrameLoaderClient::didCreateQuickLookHandle): Changed to pass a
168         Ref<QuickLookHandleClient>&& to QuickLookHandle::setClient().
169
170 2017-01-15  Tim Horton  <timothy_horton@apple.com>
171
172         De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
173         https://bugs.webkit.org/show_bug.cgi?id=167063
174
175         Reviewed by Dan Bernstein.
176
177         * WebView/WebHTMLView.mm:
178         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
179         (-[WebHTMLView _updateFontPanel]):
180         * WebView/WebView.mm:
181         (-[WebView typingAttributes]):
182         Adjust to fontAttributesForSelectionStart returning a RetainPtr.
183
184 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
185
186         Remove ENABLE(DETAILS_ELEMENT) guards
187         https://bugs.webkit.org/show_bug.cgi?id=167042
188
189         Reviewed by Alex Christensen.
190
191         * Configurations/FeatureDefines.xcconfig:
192
193 2017-01-11  Darin Adler  <darin@apple.com>
194
195         Remove PassRefPtr from more of "platform"
196         https://bugs.webkit.org/show_bug.cgi?id=166809
197
198         Reviewed by Sam Weinig.
199
200         * WebCoreSupport/WebFrameLoaderClient.mm:
201         (NetscapePluginWidget::handleEvent): Pass a reference.
202         * WebView/WebView.mm:
203         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
204         Updated since the children set now contains Ref instead of RefPtr.
205
206 2017-01-13  Sam Weinig  <sam@webkit.org>
207
208         [WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent
209         https://bugs.webkit.org/show_bug.cgi?id=167006
210
211         Reviewed by Geoffrey Garen.
212
213         * WebView/WebDeviceOrientation.mm:
214         (convert):
215         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
216         Update for new use of std::optional.
217
218 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
219
220         Remove unnecessary includes of Page.h
221         https://bugs.webkit.org/show_bug.cgi?id=166996
222
223         Reviewed by Yusuke Suzuki.
224
225         * DOM/DOMHTML.mm:
226         * History/WebBackForwardList.mm:
227         * Plugins/WebPluginController.mm:
228         * WebCoreSupport/WebNotificationClient.mm:
229         * WebCoreSupport/WebPlatformStrategies.mm:
230         * WebCoreSupport/WebUserMediaClient.mm:
231         * WebView/WebFullScreenController.mm:
232
233 2017-01-12  Chris Dumez  <cdumez@apple.com>
234
235         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
236         https://bugs.webkit.org/show_bug.cgi?id=166995
237
238         Reviewed by Jer Noble.
239
240         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
241         as some people are having trouble building without it.
242
243         * Configurations/FeatureDefines.xcconfig:
244
245 2017-01-12  Chris Dumez  <cdumez@apple.com>
246
247         HTML form validation popover sometimes does not go away
248         https://bugs.webkit.org/show_bug.cgi?id=166990
249         <rdar://problem/29985957>
250
251         Reviewed by Tim Horton.
252
253         Update code using ValidationBubble now that it is RefCounted.
254
255         * WebView/WebView.mm:
256         (-[WebView showFormValidationMessage:withAnchorRect:]):
257
258 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
259
260         Remove pointerLockElement from DOMDocumentPrivate.h
261         https://bugs.webkit.org/show_bug.cgi?id=166882
262
263         Reviewed by Simon Fraser.
264
265         Removed pointerLockElement declaration that was supposed to be removed in r209637.
266
267         * DOM/DOMDocumentPrivate.h:
268
269 2017-01-06  Darin Adler  <darin@apple.com>
270
271         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
272         https://bugs.webkit.org/show_bug.cgi?id=166797
273
274         Reviewed by Alex Christensen.
275
276         * WebCoreSupport/WebEditorClient.h: Updated to take a reference.
277         * WebCoreSupport/WebEditorClient.mm:
278         (WebEditorClient::requestCheckingOfString): Take a reference
279         instead of a PassRefPtr.
280
281 2017-01-05  Chris Dumez  <cdumez@apple.com>
282
283         Turn preferLowPowerWebGLRendering setting on by default
284         https://bugs.webkit.org/show_bug.cgi?id=166737
285         <rdar://problem/29870033>
286
287         Reviewed by Dean Jackson.
288
289         Temporarily turn preferLowPowerWebGLRendering setting on by default until
290         we deal better with WebGL content in background tabs.
291
292         * WebView/WebPreferences.mm:
293         (+[WebPreferences initialize]):
294
295 2017-01-05  Enrica Casucci  <enrica@apple.com>
296
297         Support File Promise during drag for macOS.
298         https://bugs.webkit.org/show_bug.cgi?id=165204
299         rdar://problem/19595567
300
301         Reviewed by Tim Horton.
302
303         Adds support for dropping a File Promise in a WebView.
304         The implementation uses new File Promise API available in Sierra.
305
306         * Misc/WebNSPasteboardExtras.mm:
307         (+[NSPasteboard _web_dragTypesForURL]):
308         * WebView/WebView.mm:
309         (-[WebView performDragOperation:]):
310
311 2017-01-05  Andreas Kling  <akling@apple.com>
312
313         Remove ChromeClient::needTouchEvents().
314         <https://webkit.org/b/166723>
315
316         Rubber-stamped by Antti Koivisto.
317
318         * WebCoreSupport/WebChromeClient.h:
319
320 2017-01-04  Darin Adler  <darin@apple.com>
321
322         Remove PassRefPtr use from the "html" directory, other improvements
323         https://bugs.webkit.org/show_bug.cgi?id=166635
324
325         Reviewed by Alex Christensen.
326
327         * WebCoreSupport/WebChromeClient.h:
328         * WebCoreSupport/WebChromeClient.mm:
329         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
330
331 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
332
333         Unreviewed, rolling out r210287.
334
335         This change caused editing test failures on macOS.
336
337         Reverted changeset:
338
339         "Support File Promise during drag for macOS."
340         https://bugs.webkit.org/show_bug.cgi?id=165204
341         http://trac.webkit.org/changeset/210287
342
343 2017-01-04  Enrica Casucci  <enrica@apple.com>
344
345         Support File Promise during drag for macOS.
346         https://bugs.webkit.org/show_bug.cgi?id=165204
347         rdar://problem/19595567
348
349         Reviewed by Tim Horton.
350
351         Adds support for dropping a File Promise in a WebView.
352         The implementation uses new File Promise API available in Sierra.
353
354         * Misc/WebNSPasteboardExtras.mm:
355         (+[NSPasteboard _web_dragTypesForURL]):
356         * WebView/WebView.mm:
357         (-[WebView performDragOperation:]):
358
359 2017-01-04  Tim Horton  <timothy_horton@apple.com>
360
361         Provide a setting for clients to always prefer low-power WebGL
362         https://bugs.webkit.org/show_bug.cgi?id=166675
363         <rdar://problem/29834093>
364
365         Reviewed by Dan Bernstein.
366
367         * WebView/WebPreferenceKeysPrivate.h:
368         * WebView/WebPreferences.mm:
369         (+[WebPreferences initialize]):
370         (-[WebPreferences preferLowPowerWebGLRendering]):
371         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
372         * WebView/WebPreferencesPrivate.h:
373         * WebView/WebView.mm:
374         (-[WebView _preferencesChanged:]):
375         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
376
377 2017-01-03  Tim Horton  <timothy_horton@apple.com>
378
379         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
380         https://bugs.webkit.org/show_bug.cgi?id=166450
381         <rdar://problem/29447824>
382
383         Reviewed by Darin Adler.
384
385         * WebCoreSupport/CorrectionPanel.h:
386         * WebCoreSupport/CorrectionPanel.mm:
387         (CorrectionPanel::recordAutocorrectionResponse):
388         (CorrectionPanel::handleAcceptedReplacement):
389         * WebCoreSupport/WebAlternativeTextClient.mm:
390         (toCorrectionResponse):
391         (WebAlternativeTextClient::recordAutocorrectionResponse):
392         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
393         through recordAutocorrectionResponse, for debugging's sake.
394         Drop the NSView parameter because we don't need it, just the tag.
395         Convert the new AutocorrectionResponseType value to its corresponding
396         NSCorrectionResponse value.
397
398 2017-01-01  Jeff Miller  <jeffm@apple.com>
399
400         Update user-visible copyright strings to include 2017
401         https://bugs.webkit.org/show_bug.cgi?id=166278
402
403         Reviewed by Dan Bernstein.
404
405         * Info.plist:
406
407 2016-12-30  Darin Adler  <darin@apple.com>
408
409         Remove PassRefPtr use from the "dom" directory, related cleanup
410         https://bugs.webkit.org/show_bug.cgi?id=166569
411
412         Reviewed by Alex Christensen.
413
414         * WebCoreSupport/WebFrameLoaderClient.mm:
415         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
416         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
417         (WebFrameLoaderClient::setTitle): Ditto.
418         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
419         * WebView/WebFrame.mm:
420         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
421         Not needed now, but useful later if we ever can get rid of the explicit constructors.
422         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
423         * WebView/WebHTMLRepresentation.mm:
424         (-[WebHTMLRepresentation title]): Updated to use struct.
425
426 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
427
428         Propagate the source origin as much as possible
429         https://bugs.webkit.org/show_bug.cgi?id=166348
430
431         Reviewed by Darin Adler.
432
433         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
434         (WebKit::NetscapePluginInstanceProxy::evaluate):
435
436 2016-12-23  Andy Estes  <aestes@apple.com>
437
438         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
439         https://bugs.webkit.org/show_bug.cgi?id=166471
440
441         Reviewed by Andreas Kling.
442
443         When DumpRenderTree starts up, it calls
444         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
445         builds, this triggers the ASSERT(isMainThread()) in
446         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
447         started, we are on the main thread, and we are not holding the Web thread lock. This is
448         causing all layout tests to crash in the iOS WK1 Debug configuration.
449
450         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
451         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
452
453 2016-12-22  Andy Estes  <aestes@apple.com>
454
455         Make WebCore::EditorInsertAction an enum class
456         https://bugs.webkit.org/show_bug.cgi?id=166424
457
458         Reviewed by Brent Fulgham.
459
460         * WebCoreSupport/WebEditorClient.mm:
461         (kit):
462
463 2016-12-21  Beth Dakin  <bdakin@apple.com>
464
465         Holding down on candidates in the TouchBar should show panel on screen
466         https://bugs.webkit.org/show_bug.cgi?id=166367
467         -and corresponding-
468         <rdar://problem/28479236>
469
470         Reviewed by Tim Horton.
471
472         Stray whitespace.
473         * WebCoreSupport/WebEditorClient.mm:
474         (WebEditorClient::handleRequestedCandidates):
475
476         Call the version of setCandidates: that takes a rect. We need to keep the helper 
477         function in WK1 (unlike WK2) since we also use it for testing.
478         * WebView/WebView.mm:
479         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
480
481 2016-12-20  Dean Jackson  <dino@apple.com>
482
483         Remove INDIE_UI
484         https://bugs.webkit.org/show_bug.cgi?id=165881
485         <rdar://problem/29672532>
486
487         Reviewed by Simon Fraser.
488
489         The Indie UI work has been discontinued.
490
491         * Configurations/FeatureDefines.xcconfig:
492
493 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
494
495         [ES6] Enable ES6 Modules
496         https://bugs.webkit.org/show_bug.cgi?id=165849
497
498         Reviewed by Geoffrey Garen.
499
500         * WebView/WebPreferenceKeysPrivate.h:
501         * WebView/WebPreferences.mm:
502         (+[WebPreferences initialize]):
503         (-[WebPreferences es6ModulesEnabled]): Deleted.
504         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
505         * WebView/WebPreferencesPrivate.h:
506         * WebView/WebView.mm:
507         (-[WebView _preferencesChanged:]):
508
509 2016-12-16  Dave Hyatt  <hyatt@apple.com>
510
511         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
512         https://bugs.webkit.org/show_bug.cgi?id=165968
513
514         Reviewed by Andreas Kling.
515
516         * DOM/DOMCSS.mm:
517         (kitClass):
518         * DOM/DOMCSSPrimitiveValue.mm:
519         (-[DOMCSSPrimitiveValue getCounterValue]):
520         (-[DOMCSSPrimitiveValue getRectValue]):
521         (kit):
522         * DOM/DOMCSSPrimitiveValueInternal.h:
523         * DOM/DOMCSSStyleDeclaration.mm:
524         * DOM/DOMCSSValue.mm:
525         (kit):
526         * DOM/DOMCSSValueInternal.h:
527         * DOM/DOMCSSValueList.mm:
528         * DOM/DOMCounter.mm:
529         (kit):
530         * DOM/DOMCounterInternal.h:
531         * DOM/DOMRGBColor.mm:
532         (kit):
533         * DOM/DOMRGBColorInternal.h:
534         * DOM/DOMRect.mm:
535         (kit):
536         * DOM/DOMRectInternal.h:
537         * DOM/DOMUtility.mm:
538         (createDOMWrapper):
539
540 2016-12-16  Chris Dumez  <cdumez@apple.com>
541
542         HTML form validation bubble should be dismissed on navigation
543         https://bugs.webkit.org/show_bug.cgi?id=165960
544         <rdar://problem/29668086>
545
546         Reviewed by Simon Fraser.
547
548         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
549
550         * WebView/WebView.mm:
551         (-[WebView _didStartProvisionalLoadForFrame:]):
552
553 2016-12-15  Darin Adler  <darin@apple.com>
554
555         Use asString instead of toWTFString, toString, or getString when we already checked isString
556         https://bugs.webkit.org/show_bug.cgi?id=165895
557
558         Reviewed by Yusuke Suzuki.
559
560         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
561         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
562         toWTFString.
563         * WebView/WebView.mm:
564         (aeDescFromJSValue): Use asString/value instead of getString.
565
566 2016-12-15  Chris Dumez  <cdumez@apple.com>
567
568         Make sure HTML validation bubble's state is updated after layout
569         https://bugs.webkit.org/show_bug.cgi?id=165922
570         <rdar://problem/29694730>
571
572         Reviewed by Simon Fraser.
573
574         Make sure HTML validation bubble's state is updated after layout.
575         In particular, if the validation bubble's associated element has
576         moved or is no longer visible, we now hide the bubble.
577
578         * WebCoreSupport/WebValidationMessageClient.h:
579         * WebCoreSupport/WebValidationMessageClient.mm:
580         (WebValidationMessageClient::showValidationMessage):
581         (WebValidationMessageClient::hideValidationMessage):
582         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
583
584 2016-12-15  Chris Dumez  <cdumez@apple.com>
585
586         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
587         https://bugs.webkit.org/show_bug.cgi?id=165904
588
589         Reviewed by Sam Weinig.
590
591         Update ObjC bindings so they keep building.
592
593         * DOM/DOMUIEvent.mm:
594         (-[DOMUIEvent keyCode]):
595         (-[DOMUIEvent charCode]):
596
597 2016-12-15  Andreas Kling  <akling@apple.com>
598
599         Always clear RenderLayer backing stores when going into page cache.
600         <https://webkit.org/b/165901>
601
602         Reviewed by Simon Fraser.
603
604         * WebView/WebView.mm:
605         (+[WebView _setCacheModel:]):
606
607 2016-12-12  Alex Christensen  <achristensen@webkit.org>
608
609         Remove unused workaround for Silverlight
610         https://bugs.webkit.org/show_bug.cgi?id=165773
611
612         Reviewed by Dean Jackson.
613
614         * Plugins/WebNetscapePluginView.mm:
615         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
616         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
617         Allowing 6 years for users to update Silverlight is more than enough.
618         Safari doesn't even use WebKit1 for this any more.
619         I need this to be removed because this is the only non-WebGL code that needs to link against
620         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
621
622 2016-12-12  Chris Dumez  <cdumez@apple.com>
623
624         Document.visibilityState should use an IDL string enumeration
625         https://bugs.webkit.org/show_bug.cgi?id=165774
626
627         Reviewed by Daniel Bates.
628
629         * DOM/DOMDocument.mm:
630         (-[DOMDocument visibilityState]):
631         * WebView/WebView.mm:
632         (kit):
633
634 2016-12-12  Jer Noble  <jer.noble@apple.com>
635
636         Remove implementation of legacy Mozilla-based Fullscreen API.
637         https://bugs.webkit.org/show_bug.cgi?id=165689
638         <rdar://problem/29603053>
639
640         Reviewed by Eric Carlson.
641
642         * DOM/DOMElement.mm:
643         (-[DOMElement webkitRequestFullScreen:]):
644
645 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
646
647         The DOM should have an advancing wavefront opaque root barrier
648         https://bugs.webkit.org/show_bug.cgi?id=165712
649
650         Reviewed by Yusuke Suzuki.
651         
652         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
653
654         * Misc/WebCoreStatistics.mm:
655         (+[WebCoreStatistics javaScriptObjectsCount]):
656         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
657         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
658         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
659         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
660         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
661         (+[WebCoreStatistics shouldPrintExceptions]):
662         (+[WebCoreStatistics setShouldPrintExceptions:]):
663         (+[WebCoreStatistics memoryStatistics]):
664         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
665         * Plugins/Hosted/NetscapePluginHostProxy.mm:
666         (identifierFromIdentifierRep):
667         * Plugins/Hosted/ProxyInstance.mm:
668         (WebKit::ProxyInstance::getPropertyNames):
669         * Plugins/WebNetscapePluginStream.mm:
670         (WebNetscapePluginStream::wantsAllStreams):
671         * Plugins/WebNetscapePluginView.mm:
672         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
673         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
674         (-[WebNetscapePluginView setWindowIfNecessary]):
675         (-[WebNetscapePluginView createPluginScriptableObject]):
676         (-[WebNetscapePluginView getFormValue:]):
677         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
678         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
679         (-[WebNetscapePluginView loadPluginRequest:]):
680         (-[WebNetscapePluginView _printedPluginBitmap]):
681         * Plugins/WebPluginController.mm:
682         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
683         (-[WebPluginController stopOnePlugin:]):
684         (-[WebPluginController stopOnePluginForPageCache:]):
685         (-[WebPluginController destroyOnePlugin:]):
686         (-[WebPluginController startAllPlugins]):
687         (-[WebPluginController addPlugin:]):
688
689 2016-12-09  Dave Hyatt  <hyatt@apple.com>
690
691         [CSS Parser] Remove the old CSS Parser
692         https://bugs.webkit.org/show_bug.cgi?id=165645
693
694         Reviewed by Daniel Bates.
695
696         * DOM/DOMCSS.mm:
697         (kitClass):
698         * DOM/DOMCSSRule.h:
699
700 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
701
702         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
703         https://bugs.webkit.org/show_bug.cgi?id=165251
704
705         Reviewed by Dean Jackson.
706
707         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
708
709         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
710         * WebView/WebPreferences.mm:
711         (+[WebPreferences initialize]):
712         (-[WebPreferences mediaStreamEnabled]):
713         (-[WebPreferences setMediaStreamEnabled:]):
714         (-[WebPreferences peerConnectionEnabled]):
715         (-[WebPreferences setPeerConnectionEnabled:]):
716         * WebView/WebPreferencesPrivate.h:
717         * WebView/WebView.mm:
718         (-[WebView _preferencesChanged:]):
719
720 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
721
722         Don’t expose pointer lock in WebKit1 Objective-C API
723         https://bugs.webkit.org/show_bug.cgi?id=165692
724
725         Reviewed by Simon Fraser.
726
727         * DOM/DOMDocument.mm:
728         (-[DOMDocument pointerLockElement]): Deleted.
729         (-[DOMDocument exitPointerLock]): Deleted.
730         * DOM/DOMElement.mm:
731         (-[DOMElement requestPointerLock]): Deleted.
732         * DOM/DOMMouseEvent.mm:
733         (-[DOMMouseEvent movementX]): Deleted.
734         (-[DOMMouseEvent movementY]): Deleted.
735
736 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
737
738         document.webkitFullscreenElement leaks elements inside a shadow tree
739         https://bugs.webkit.org/show_bug.cgi?id=158471
740
741         Reviewed by Chris Dumez.
742
743         Use the API for bindings to avoid exposing nodes inside a shadow tree.
744
745         * DOM/DOMDocument.mm:
746         (-[DOMDocument webkitCurrentFullScreenElement]):
747         (-[DOMDocument webkitFullscreenElement]):
748
749 2016-12-09  Beth Dakin  <bdakin@apple.com>
750
751         Password fields should not show the emoji button in TouchBar
752         https://bugs.webkit.org/show_bug.cgi?id=165673
753         -and corresponding-
754         rdar://problem/29235739
755
756         Reviewed by Wenson Hsieh.
757
758         This patch adds a new ivar for the password touch bar and password 
759         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
760         of identifiers than the plain text TouchBar, it should just have its own variable.
761
762         The candidate list should be the only item for passwords.
763         * WebView/WebView.mm:
764         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
765
766         Account for _passwordTextTouchBar.
767         (-[WebView didChangeAutomaticTextCompletion:]):
768         (-[WebView setUpTextTouchBar:]):
769         (-[WebView textTouchBar]):
770
771         The empty candidates array is not needed. We can just set @[ ] as the candidates 
772         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
773         other parts of the code to prevent us from requesting or setting other candidates 
774         when in a password field. 
775         (-[WebView updateTextTouchBar]):
776
777         Account for _passwordTextTouchBar.
778         (-[WebView candidateList]):
779         * WebView/WebViewData.h:
780
781 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
782
783         Enable SharedArrayBuffer, remove the flag
784         https://bugs.webkit.org/show_bug.cgi?id=165614
785
786         Rubber stamped by Geoffrey Garen.
787
788         * WebView/WebPreferencesPrivate.h:
789
790 2016-12-07  Dean Jackson  <dino@apple.com>
791
792         Remove runtime toggle for pointer-lock
793         https://bugs.webkit.org/show_bug.cgi?id=165577
794         <rdar://problems/29566996>
795
796         Reviewed by Jon Lee.
797
798         Remove any runtime calls to check if pointer-lock is enabled. It's
799         either compiled in or out.
800
801         * WebView/WebPreferenceKeysPrivate.h:
802         * WebView/WebPreferences.mm:
803         (-[WebPreferences pointerLockEnabled]): Deleted.
804         (-[WebPreferences setPointerLockEnabled:]): Deleted.
805         * WebView/WebPreferencesPrivate.h:
806         * WebView/WebView.mm:
807         (-[WebView _preferencesChanged:]):
808
809 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
810
811         Correct SDKROOT values in xcconfig files
812         https://bugs.webkit.org/show_bug.cgi?id=165487
813         rdar://problem/29539209
814
815         Reviewed by Dan Bernstein.
816
817         Fix suggested by Dan Bernstein.
818
819         * Configurations/DebugRelease.xcconfig:
820
821 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
822
823         Improve the behavior of scroll-into-view when the target is inside position:fixed
824         https://bugs.webkit.org/show_bug.cgi?id=165354
825
826         Reviewed by Zalan Bujtas.
827
828         Plumb through 'insideFixed'. We don't get compute it, so behavior from
829         these call sites won't change.
830
831         * WebView/WebFrame.mm:
832         (-[WebFrame _scrollDOMRangeToVisible:]):
833         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
834
835 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
836
837         Enable visual viewports by default on Mac, and iOS Wk2
838         https://bugs.webkit.org/show_bug.cgi?id=165452
839
840         Reviewed by Zalan Bujtas.
841
842         Turn visual viewports on by default for WK1 on Mac.
843
844         * WebView/WebPreferences.mm:
845         (+[WebPreferences initialize]):
846
847 2016-12-05  Dean Jackson  <dino@apple.com>
848
849         pointer lock needs to be feature detectable
850         https://bugs.webkit.org/show_bug.cgi?id=165426
851         <rdar://problem/29486715>
852
853         Reviewed by Antoine Quint.
854
855         Set the RuntimeEnabledFeature as preferences
856         change.
857
858         * WebView/WebView.mm:
859         (-[WebView _preferencesChanged:]):
860
861 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
862
863         Unreviewed, rolling out r209299.
864
865         This change appears to have caused LayoutTest failures on
866         Sierra WK1.
867
868         Reverted changeset:
869
870         "Improve the behavior of scroll-into-view when the target is
871         inside position:fixed"
872         https://bugs.webkit.org/show_bug.cgi?id=165354
873         http://trac.webkit.org/changeset/209299
874
875 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
876
877         Improve the behavior of scroll-into-view when the target is inside position:fixed
878         https://bugs.webkit.org/show_bug.cgi?id=165354
879
880         Reviewed by Zalan Bujtas.
881
882         Plumb through 'insideFixed'. We don't get compute it, so behavior from
883         these call sites won't change.
884
885         * WebView/WebFrame.mm:
886         (-[WebFrame _scrollDOMRangeToVisible:]):
887         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
888
889 2016-12-02  Andy Estes  <aestes@apple.com>
890
891         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
892         https://bugs.webkit.org/show_bug.cgi?id=164492
893
894         Reviewed by Dan Bernstein.
895
896         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
897         com.apple.$(PRODUCT_NAME:rfc1034identifier).
898         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
899         ${PRODUCT_BUNDLE_IDENTIFIER}.
900
901 2016-12-02  Chris Dumez  <cdumez@apple.com>
902
903         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
904         https://bugs.webkit.org/show_bug.cgi?id=165328
905
906         Reviewed by Simon Fraser.
907
908         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
909
910         * WebView/WebViewData.mm:
911         (-[WebViewPrivate init]):
912
913 2016-12-02  Chris Dumez  <cdumez@apple.com>
914
915         [Mac][WK1] Implement new HTML interactive form validation user interface
916         https://bugs.webkit.org/show_bug.cgi?id=164483
917
918         Reviewed by Simon Fraser.
919
920         Implement new HTML interactive form validation user interface on Mac
921         WK1 and enable it by default.
922
923         * WebCoreSupport/WebValidationMessageClient.h: Added.
924         * WebCoreSupport/WebValidationMessageClient.mm: Added.
925         (WebValidationMessageClient::WebValidationMessageClient):
926         (WebValidationMessageClient::~WebValidationMessageClient):
927         (WebValidationMessageClient::showValidationMessage):
928         (WebValidationMessageClient::hideValidationMessage):
929         (WebValidationMessageClient::isValidationMessageVisible):
930         * WebView/WebHTMLView.mm:
931         (-[WebHTMLView _frameOrBoundsChanged]):
932         * WebView/WebView.mm:
933         (-[WebView _commonInitializationWithFrameName:groupName:]):
934         (-[WebView _willStartScrollingOrZooming]):
935         (-[WebView _contentsOfUserInterfaceItem:]):
936         (-[WebView _scaleWebView:atOrigin:]):
937         (-[WebView _didScrollDocumentInFrameView:]):
938         (-[WebView _setZoomMultiplier:isTextOnly:]):
939         (-[WebView showFormValidationMessage:withAnchorRect:]):
940         (-[WebView hideFormValidationMessage]):
941         * WebView/WebViewData.h:
942         * WebView/WebViewData.mm:
943         (-[WebViewPrivate init]):
944         * WebView/WebViewInternal.h:
945         * WebView/WebViewPrivate.h:
946
947 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
948
949         Add a runtime flag for SubtleCrypto
950         https://bugs.webkit.org/show_bug.cgi?id=164982
951
952         Reviewed by Brent Fulgham.
953
954         * WebView/WebPreferenceKeysPrivate.h:
955         * WebView/WebPreferences.mm:
956         (+[WebPreferences initialize]):
957         (-[WebPreferences subtleCryptoEnabled]):
958         (-[WebPreferences setSubtleCryptoEnabled:]):
959         * WebView/WebPreferencesPrivate.h:
960         * WebView/WebView.mm:
961         (-[WebView _preferencesChanged:]):
962
963 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
964
965         Add separate settings and preferences to enable/disable async decoding for large images and animated images
966         https://bugs.webkit.org/show_bug.cgi?id=165177
967
968         Reviewed by Simon Fraser.
969         
970         Hook up the async image decoding settings for WebKit1.
971
972         * WebView/WebPreferenceKeysPrivate.h:
973         * WebView/WebPreferences.mm:
974         (+[WebPreferences initialize]):
975         (-[WebPreferences largeImageAsyncDecodingEnabled]):
976         (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
977         (-[WebPreferences animatedImageAsyncDecodingEnabled]):
978         (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
979         (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
980         (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
981         * WebView/WebPreferencesPrivate.h:
982         * WebView/WebView.mm:
983         (-[WebView _preferencesChanged:]):
984
985 2016-11-29  Andy Estes  <aestes@apple.com>
986
987         [Cocoa] Enable two clang warnings recommended by Xcode
988         https://bugs.webkit.org/show_bug.cgi?id=164498
989
990         Reviewed by Mark Lam.
991
992         * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
993
994 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
995
996         [WTF] Import std::optional reference implementation as WTF::Optional
997         https://bugs.webkit.org/show_bug.cgi?id=164199
998
999         Reviewed by Saam Barati and Sam Weinig.
1000
1001         Use WTF::Optional::value_or.
1002
1003         * DOM/DOMHTMLOptionsCollection.mm:
1004         (-[DOMHTMLOptionsCollection add:index:]):
1005         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1006         (WebKit::NetscapePluginInstanceProxy::evaluate):
1007         * Plugins/WebNetscapePluginView.mm:
1008         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
1009         * WebCoreSupport/WebFrameLoaderClient.h:
1010         * WebCoreSupport/WebFrameLoaderClient.mm:
1011         (WebFrameLoaderClient::dispatchDidCommitLoad):
1012         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1013         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1014         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
1015         (WebPaymentCoordinatorClient::completeShippingContactSelection):
1016         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
1017         * WebCoreSupport/WebSecurityOrigin.mm:
1018         (-[WebSecurityOrigin port]):
1019         * WebView/WebHTMLView.mm:
1020         (toAction):
1021         (toTag):
1022
1023 2016-11-26  Sam Weinig  <sam@webkit.org>
1024
1025         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
1026         https://bugs.webkit.org/show_bug.cgi?id=164965
1027
1028         Reviewed by Simon Fraser.
1029
1030         * WebView/WebPreferenceKeysPrivate.h:
1031         * WebView/WebPreferences.mm:
1032         (-[WebPreferences intersectionObserverEnabled]):
1033         (-[WebPreferences setIntersectionObserverEnabled:]):
1034         * WebView/WebPreferencesPrivate.h:
1035         * WebView/WebView.mm:
1036         (-[WebView _preferencesChanged:]):
1037         Add a preference, defaulting to off, for enabling IntersectionObserver.
1038
1039 2016-11-22  Dan Bernstein  <mitz@apple.com>
1040
1041         [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
1042         https://bugs.webkit.org/show_bug.cgi?id=165036
1043         <rdar://problem/5708580>
1044
1045         Reviewed by Alexey Proskuryakov.
1046
1047         * WebView/WebHTMLView.mm:
1048         (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
1049           similarly to what we do in -keyDown: and to what WKWebView does with all key events.
1050
1051 2016-11-21  Alex Christensen  <achristensen@webkit.org>
1052
1053         Fix Sierra CMake build after r208452
1054         https://bugs.webkit.org/show_bug.cgi?id=164437
1055
1056         * WebView/WebView.mm:
1057         (-[WebView updateMediaTouchBar]):
1058         I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
1059         It's needed for playbackSessionInterface to exist.
1060
1061 2016-11-18  Enrica Casucci  <enrica@apple.com>
1062
1063         Refactor drag and drop for WebKit2 to encode DragData message exchange.
1064         https://bugs.webkit.org/show_bug.cgi?id=164945
1065
1066         Reviewed by Tim Horton.
1067
1068         * WebCoreSupport/WebDragClient.h:
1069         * WebCoreSupport/WebDragClient.mm:
1070         (WebDragClient::actionMaskForDrag):
1071         (WebDragClient::willPerformDragDestinationAction):
1072
1073 2016-11-18  Jeremy Jones  <jeremyj@apple.com>
1074
1075         Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
1076         https://bugs.webkit.org/show_bug.cgi?id=163801
1077
1078         Reviewed by Simon Fraser.
1079
1080         Plumb through PointerLockEnabled setting.
1081
1082         * Configurations/FeatureDefines.xcconfig:
1083         * WebCoreSupport/WebChromeClient.mm:
1084         (WebChromeClient::requestPointerUnlock):
1085         * WebView/WebPreferenceKeysPrivate.h:
1086         * WebView/WebPreferences.mm:
1087         (-[WebPreferences pointerLockEnabled]):
1088         (-[WebPreferences setPointerLockEnabled:]):
1089         * WebView/WebPreferencesPrivate.h:
1090         * WebView/WebView.mm:
1091         (-[WebView _preferencesChanged:]):
1092
1093 2016-11-17  Dan Bernstein  <mitz@apple.com>
1094
1095         Try to fix some non-macOS builds.
1096
1097         * WebView/WebView.mm:
1098
1099 2016-11-16  Dave Hyatt  <hyatt@apple.com>
1100
1101         [CSS Parser] Add @supports, @keyframe and media query parsing options
1102         https://bugs.webkit.org/show_bug.cgi?id=164821
1103
1104         Reviewed by Sam Weinig and Zalan Bujtas.
1105
1106         Fix up the create call now that fallback descriptor syntax is gone.
1107
1108         * DOM/DOM.mm:
1109         (-[DOMHTMLLinkElement _mediaQueryMatches]):
1110
1111 2016-11-17  Saam Barati  <sbarati@apple.com>
1112
1113         Remove async/await compile time flag and enable tests
1114         https://bugs.webkit.org/show_bug.cgi?id=164828
1115         <rdar://problem/28639334>
1116
1117         Reviewed by Yusuke Suzuki.
1118
1119         * Configurations/FeatureDefines.xcconfig:
1120
1121 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
1122
1123         [JSC] WTF::TemporaryChange with WTF::SetForScope
1124         https://bugs.webkit.org/show_bug.cgi?id=164761
1125
1126         Reviewed by Saam Barati.
1127
1128         * WebView/WebView.mm:
1129         (-[WebView updateTextTouchBar]):
1130
1131 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1132
1133         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
1134         https://bugs.webkit.org/show_bug.cgi?id=164827
1135
1136         Reviewed by Ryosuke Niwa.
1137
1138         * Configurations/FeatureDefines.xcconfig:
1139         * WebView/WebPreferenceKeysPrivate.h:
1140         * WebView/WebPreferences.mm:
1141         (+[WebPreferences initialize]):
1142         (-[WebPreferences es6ModulesEnabled]):
1143         (-[WebPreferences setES6ModulesEnabled:]):
1144         * WebView/WebPreferencesPrivate.h:
1145         * WebView/WebView.mm:
1146         (-[WebView _preferencesChanged:]):
1147
1148 2016-11-14  Alex Christensen  <achristensen@webkit.org>
1149
1150         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
1151         https://bugs.webkit.org/show_bug.cgi?id=164720
1152
1153         Reviewed by Brady Eidson.
1154
1155         * Storage/WebDatabaseManager.mm:
1156         (-[WebDatabaseManager origins]):
1157         (-[WebDatabaseManager databasesWithOrigin:]):
1158         (-[WebDatabaseManager deleteOrigin:]):
1159         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1160         * Storage/WebDatabaseManagerClient.h:
1161         * Storage/WebDatabaseManagerClient.mm:
1162         (DidModifyOriginData::dispatchToMainThread):
1163         (DidModifyOriginData::DidModifyOriginData):
1164         (WebDatabaseManagerClient::dispatchDidModifyOrigin):
1165         (WebDatabaseManagerClient::dispatchDidModifyDatabase):
1166         * Storage/WebDatabaseQuotaManager.mm:
1167         (-[WebDatabaseQuotaManager usage]):
1168         (-[WebDatabaseQuotaManager quota]):
1169         (-[WebDatabaseQuotaManager setQuota:]):
1170         * Storage/WebStorageManager.mm:
1171         (-[WebStorageManager origins]):
1172         (-[WebStorageManager deleteOrigin:]):
1173         * Storage/WebStorageTrackerClient.h:
1174         * Storage/WebStorageTrackerClient.mm:
1175         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1176         * WebCoreSupport/WebSecurityOrigin.mm:
1177         (-[WebSecurityOrigin usage]):
1178         (-[WebSecurityOrigin quota]):
1179         (-[WebSecurityOrigin setQuota:]):
1180
1181 2016-11-13  Darin Adler  <darin@apple.com>
1182
1183         Fix exception handling in SQL database code, streamline and update code
1184         https://bugs.webkit.org/show_bug.cgi?id=164685
1185
1186         Reviewed by Sam Weinig.
1187
1188         * Storage/WebDatabaseManager.mm:
1189         (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
1190         a reference.
1191         (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
1192         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
1193         but continue to use DatabaseManager.
1194         (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
1195         reference.
1196         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
1197
1198         * Storage/WebDatabaseManagerClient.h: Updated to take references.
1199         * Storage/WebDatabaseManagerClient.mm:
1200         (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
1201         members in the class definition.
1202         (DidModifyOriginData::dispatchToMainThread): Take references.
1203         (DidModifyOriginData::DidModifyOriginData): Ditto.
1204         (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
1205         (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
1206         (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
1207         DatabaseTracker::singleton instead of tracker.
1208
1209         * Storage/WebDatabaseQuotaManager.mm:
1210         (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
1211         (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
1212         (-[WebDatabaseQuotaManager quota]): Ditto.
1213         (-[WebDatabaseQuotaManager setQuota:]): Ditto.
1214         * WebCoreSupport/WebSecurityOrigin.mm:
1215         (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
1216         (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
1217         (-[WebSecurityOrigin quota]): Ditto.
1218         (-[WebSecurityOrigin setQuota:]): Ditto.
1219         * WebView/WebFrame.mm:
1220         (-[WebFrame _cacheabilityDictionary]): Pass a reference.
1221
1222 2016-11-12  Darin Adler  <darin@apple.com>
1223
1224         Remove a few assorted uses of ExceptionCode
1225         https://bugs.webkit.org/show_bug.cgi?id=164683
1226
1227         Reviewed by Chris Dumez.
1228
1229         * DOM/DOMDOMImplementation.mm:
1230         (-[DOMImplementation createDocumentType:publicId:systemId:]):
1231         Use raiseOnDOMError instead of much longer hand written equivalent.
1232         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
1233
1234         * DOM/DOMDocument.mm:
1235         (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
1236         so we are not using a specific exception code.
1237
1238         * DOM/DOMHTMLOptionsCollection.mm:
1239         (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
1240         much longer hand written equivalent.
1241         * DOM/DOMHTMLSelectElement.mm:
1242         (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
1243         statement after calling a "no return" function.
1244
1245         * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
1246         raiseOnDOMError functions that take ExceptionCode; keep the ones that take
1247         Exception and ExceptionOr. Renamed the other overload of raiseDOMException
1248         to raiseDOMErrorException; it is only used as the non-inline implementation
1249         part of the inline raiseOnDOMError function.
1250         * DOM/ExceptionHandlers.mm:
1251         (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
1252         to this source file instead of in the header.
1253         (raiseTypeErrorException): Updated for name change.
1254         (raiseNotSupportedErrorException): Added.
1255
1256 2016-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1257
1258         Hovering over a slotted Text node clears hover state
1259         https://bugs.webkit.org/show_bug.cgi?id=164002
1260         <rdar://problem/29040471>
1261
1262         Reviewed by Simon Fraser.
1263
1264         * WebView/WebImmediateActionController.mm:
1265         (-[WebImmediateActionController performHitTestAtPoint:]):
1266
1267 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1268
1269         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
1270         https://bugs.webkit.org/show_bug.cgi?id=164538
1271         <rdar://problem/8418711>
1272
1273         Reviewed by Ryosuke Niwa.
1274
1275         Account for renaming HTMLElement::autocorrect to HTMLElement::shouldAutocorrect, as well as moving
1276         WebAutocapitalizeType to WebKit from WebCore. Additionally, moves the -autocorrect and -autocapitalize SPIs out
1277         of HTML(Input|Form|TextArea)ElementPrivate.h and into HTMLElementPrivate.h. This also means removing redundant
1278         code for interfacing with the unwrapped HTMLElement's autocorrect and autocapitalize attributes.
1279
1280         * DOM/DOMHTML.mm:
1281         (webAutocapitalizeType):
1282         (-[DOMHTMLInputElement _autocapitalizeType]):
1283         (-[DOMHTMLTextAreaElement _autocapitalizeType]):
1284         * DOM/DOMHTMLElement.mm:
1285         (-[DOMHTMLElement autocorrect]):
1286         (-[DOMHTMLElement setAutocorrect:]):
1287         (-[DOMHTMLElement autocapitalize]):
1288         (-[DOMHTMLElement setAutocapitalize:]):
1289         * DOM/DOMHTMLElementPrivate.h: Copied from Source/WebCore/html/Autocapitalize.h.
1290         * DOM/DOMHTMLFormElement.mm:
1291         (-[DOMHTMLFormElement autocorrect]): Deleted.
1292         (-[DOMHTMLFormElement setAutocorrect:]): Deleted.
1293         (-[DOMHTMLFormElement autocapitalize]): Deleted.
1294         (-[DOMHTMLFormElement setAutocapitalize:]): Deleted.
1295         * DOM/DOMHTMLInputElement.mm:
1296         (-[DOMHTMLInputElement autocorrect]): Deleted.
1297         (-[DOMHTMLInputElement setAutocorrect:]): Deleted.
1298         (-[DOMHTMLInputElement autocapitalize]): Deleted.
1299         (-[DOMHTMLInputElement setAutocapitalize:]): Deleted.
1300         * DOM/DOMHTMLInputElementPrivate.h:
1301         * DOM/DOMHTMLTextAreaElement.mm:
1302         (-[DOMHTMLTextAreaElement autocorrect]): Deleted.
1303         (-[DOMHTMLTextAreaElement setAutocorrect:]): Deleted.
1304         (-[DOMHTMLTextAreaElement autocapitalize]): Deleted.
1305         (-[DOMHTMLTextAreaElement setAutocapitalize:]): Deleted.
1306         * DOM/DOMHTMLTextAreaElementPrivate.h:
1307
1308         We need to import DOMHTMLElementPrivate.h here to avoid breaking UIKit. We should follow this up with a UIKit
1309         change to import DOMHTMLElementPrivate.h directly.
1310
1311         * DOM/DOMPrivate.h:
1312         * DOM/WebAutocapitalizeTypes.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h.
1313         * MigrateHeaders.make:
1314
1315 2016-11-11  Beth Dakin  <bdakin@apple.com>
1316
1317         Move to modern TouchBar methods
1318         https://bugs.webkit.org/show_bug.cgi?id=164655
1319         -and corresponding-
1320         rdar://problem/29226911
1321
1322         Reviewed by Wenson Hsieh.
1323
1324         customizationDefaultItemIdentifiers -> defaultItemIdentifiers
1325         itemIdentifiers -> defaultItemIdentifiers
1326         defaultItems -> templateItems
1327
1328         * WebView/WebView.mm:
1329         (-[WebView _plainTextTouchBarDefaultItemIdentifiers]):
1330         (-[WebView _richTextTouchBarDefaultItemIdentifiers]):
1331         (-[WebView setUpTextTouchBar:]):
1332         (-[WebView updateTextTouchBar]):
1333         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1334         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1335
1336 2016-11-11  Darin Adler  <darin@apple.com>
1337
1338         Move Node from ExceptionCode to ExceptionOr
1339         https://bugs.webkit.org/show_bug.cgi?id=164515
1340
1341         Reviewed by Sam Weinig.
1342
1343         * DOM/DOMHTMLSelectElement.mm:
1344         (-[DOMHTMLSelectElement remove:]): Call remove instead of removeByIndex
1345         now that it was renamed.
1346         * DOM/DOMNode.mm:
1347         (-[DOMNode setNodeValue:]): Updated exception handling.
1348         (-[DOMNode setPrefix:]): Ditto.
1349         (-[DOMNode setTextContent:]): Ditto.
1350         (-[DOMNode insertBefore:refChild:]): Ditto.
1351         (-[DOMNode replaceChild:oldChild:]): Ditto.
1352         (-[DOMNode removeChild:]): Ditto.
1353         (-[DOMNode appendChild:]): Ditto.
1354         (-[DOMNode cloneNode:]): Ditto.
1355
1356 2016-11-11  Beth Dakin  <bdakin@apple.com>
1357
1358         Get touch bar code building for open source builds
1359         https://bugs.webkit.org/show_bug.cgi?id=164610
1360
1361         Reviewed by Wenson Hsieh.
1362
1363         * WebKitPrefix.h:
1364
1365 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1366
1367         Fix assertion after r208534.
1368         https://bugs.webkit.org/show_bug.cgi?id=160497
1369
1370         * WebView/WebView.mm:
1371         (-[WebView _commonInitializationWithFrameName:groupName:]):
1372         (WebInstallMemoryPressureHandler):
1373         WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
1374         When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
1375         only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
1376
1377 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1378
1379         Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
1380         https://bugs.webkit.org/show_bug.cgi?id=164573
1381
1382         Reviewed by Brady Eidson.
1383
1384         * WebCoreSupport/WebSecurityOrigin.mm:
1385         (-[WebSecurityOrigin databaseIdentifier]):
1386
1387 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1388
1389         MemoryPressureHandler shouldn't know how to release WebCore memory
1390         https://bugs.webkit.org/show_bug.cgi?id=160497
1391
1392         Reviewed by Michael Catanzaro.
1393
1394         Set the low memory handler before installing the memory pressure handler.
1395
1396         * WebView/WebView.mm:
1397         (-[WebView _commonInitializationWithFrameName:groupName:]):
1398
1399 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
1400
1401         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
1402         https://bugs.webkit.org/show_bug.cgi?id=164501
1403         <rdar://problem/29152282>
1404
1405         Reviewed by Sam Weinig.
1406
1407         Align what [WebHTMLView attributedString] returns to what would be used on copy & paste by using HTMLConverter
1408         instead of _initWithDOMRange in [WebHTMLView _attributeStringFromDOMRange].
1409
1410         * WebView/WebHTMLView.mm:
1411         (-[WebHTMLView _attributedStringFromDOMRange:]): Renamed from _attributeStringFromDOMRange.
1412         (-[WebHTMLView attributedString]):
1413         (-[WebHTMLView selectedAttributedString]):
1414         (-[WebHTMLView selectedString]): Moved to reduce the number of occurrences of the if-defs.
1415
1416 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
1417
1418         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
1419         https://bugs.webkit.org/show_bug.cgi?id=155185
1420         <rdar://problem/11101440>
1421
1422         Reviewed by Brady Eidson.
1423
1424         Provide SPI to access the new quirk for localStorage. The quirk defaults to 'on'. When active, this
1425         quirk says that localStorage access should be granted, without needing to grant universal file access.
1426
1427         If the quirk is turned off, then localStorage is blocked unless the WebKit client explicitly
1428         grants universal file access.
1429
1430         * WebView/WebPreferenceKeysPrivate.h:
1431         * WebView/WebPreferences.mm:
1432         (-[WebPreferences needsLocalStorageQuirk]): Added.
1433         (-[WebPreferences setNeedsLocalStorageQuirk:]): Added.
1434         * WebView/WebPreferencesPrivate.h:
1435         * WebView/WebView.mm:
1436         (-[WebView _preferencesChanged:]): Honor the new localStorage quirk.
1437
1438 2016-11-09  Alex Christensen  <achristensen@webkit.org>
1439
1440         Clean up Storage code
1441         https://bugs.webkit.org/show_bug.cgi?id=164562
1442
1443         Reviewed by Brady Eidson.
1444
1445         * Storage/WebStorageManager.mm:
1446         (-[WebStorageManager origins]):
1447         (-[WebStorageManager deleteAllOrigins]):
1448         (-[WebStorageManager deleteOrigin:]):
1449         (-[WebStorageManager diskUsageForOrigin:]):
1450         (-[WebStorageManager syncLocalStorage]):
1451         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
1452         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
1453         (+[WebStorageManager closeIdleLocalStorageDatabases]):
1454         (WebKitInitializeStorageIfNecessary):
1455         * WebView/WebView.mm:
1456         (+[WebView _applicationWillTerminate]):
1457
1458 2016-11-09  Beth Dakin  <bdakin@apple.com>
1459
1460         Another attempted build fix.
1461
1462         * WebView/WebView.mm:
1463
1464 2016-11-09  Beth Dakin  <bdakin@apple.com>
1465
1466         Attempted build fix.
1467
1468         * WebView/WebView.mm:
1469
1470 2016-11-09  Darin Adler  <darin@apple.com>
1471
1472         Move Range from ExceptionCode to ExceptionOr
1473         https://bugs.webkit.org/show_bug.cgi?id=164457
1474
1475         Reviewed by Alex Christensen.
1476
1477         * DOM/DOMRange.mm:
1478         (-[DOMRange setStart:offset:]): Updated exception handling.
1479         (-[DOMRange setEnd:offset:]): Ditto.
1480         (-[DOMRange setStartBefore:]): Ditto.
1481         (-[DOMRange setStartAfter:]): Ditto.
1482         (-[DOMRange setEndBefore:]): Ditto.
1483         (-[DOMRange setEndAfter:]): Ditto.
1484         (-[DOMRange selectNode:]): Ditto.
1485         (-[DOMRange selectNodeContents:]): Ditto.
1486         (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
1487         (-[DOMRange deleteContents]): Ditto.
1488         (-[DOMRange extractContents]): Ditto.
1489         (-[DOMRange cloneContents]): Ditto.
1490         (-[DOMRange insertNode:]): Ditto.
1491         (-[DOMRange surroundContents:]): Ditto.
1492         (-[DOMRange createContextualFragment:]): Ditto.
1493         (-[DOMRange compareNode:]): Ditto.
1494         (-[DOMRange intersectsNode:]): Ditto.
1495         (-[DOMRange comparePoint:offset:]): Ditto.
1496         (-[DOMRange isPointInRange:offset:]): Ditto.
1497         (-[DOMRange expand:]): Ditto.
1498         * WebView/WebFrame.mm:
1499         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
1500         (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
1501         This function was incorrectly implemented (set both start and end of
1502         the range to the computed start), not declared in any header file,
1503         not used anywhere inside WebKit, and I also could not find a use of it
1504         in outside-WebKit Apple code.
1505         * mac/DOM/DOMUIKitExtensions.mm:
1506         (-[DOMRange move:inDirection:]): Ditto.
1507         (-[DOMRange extend:inDirection:]): Ditto.
1508
1509 2016-11-09  Darin Adler  <darin@apple.com>
1510
1511         Move EventTarget from ExceptionCode to ExceptionOr
1512         https://bugs.webkit.org/show_bug.cgi?id=164465
1513
1514         Reviewed by Youenn Fablet.
1515
1516         * DOM/DOMNode.mm:
1517         (-[DOMNode dispatchEvent:]): Updated exception handling.
1518
1519 2016-11-09  Chris Dumez  <cdumez@apple.com>
1520
1521         [Mac] Stop using deprecated AppKit enumeration values
1522         https://bugs.webkit.org/show_bug.cgi?id=164494
1523
1524         Reviewed by Darin Adler.
1525
1526         Stop using deprecated AppKit enumeration values.
1527
1528         * Carbon/CarbonWindowAdapter.mm:
1529         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1530         (-[CarbonWindowAdapter sendSuperEvent:]):
1531         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1532         (WebKit::NetscapePluginHostProxy::beginModal):
1533         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1534         (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
1535         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1536         (-[WebHostedNetscapePluginView drawRect:]):
1537         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1538         (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
1539         * WebCoreSupport/PopupMenuMac.mm:
1540         (PopupMenuMac::populate):
1541         (PopupMenuMac::show):
1542         * WebCoreSupport/WebContextMenuClient.mm:
1543         (WebContextMenuClient::showContextMenu):
1544         * WebCoreSupport/WebFrameLoaderClient.mm:
1545         (WebFrameLoaderClient::actionDictionary):
1546         * WebCoreSupport/WebInspectorClient.mm:
1547         (WebInspectorFrontendClient::canAttach):
1548         (-[WebInspectorWindowController window]):
1549         * WebInspector/WebNodeHighlight.mm:
1550         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1551         * WebView/WebFrameView.mm:
1552         (-[WebFrameView keyDown:keyDown:]):
1553         * WebView/WebFullScreenController.mm:
1554         (-[WebFullScreenController init]):
1555         (createBackgroundFullscreenWindow):
1556         * WebView/WebHTMLView.mm:
1557         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
1558         (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
1559         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1560         (isQuickLookEvent):
1561         (-[WebHTMLView hitTest:]):
1562         (-[WebHTMLView _sendToolTipMouseExited]):
1563         (-[WebHTMLView _sendToolTipMouseEntered]):
1564         (mouseEventIsPartOfClickOrDrag):
1565         (-[WebHTMLView _updateMouseoverWithEvent:]):
1566         (-[WebHTMLView _autoscroll]):
1567         (-[WebHTMLView acceptsFirstResponder]):
1568         (-[WebHTMLView viewDidMoveToWindow]):
1569         (-[WebHTMLView mouseDown:mouseDown:]):
1570         (currentKeyboardEvent):
1571         (-[WebHTMLView _handleStyleKeyEquivalent:]):
1572         (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
1573         * WebView/WebPDFView.mm:
1574         (-[WebPDFView hitTest:]):
1575         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1576         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
1577         * WebView/WebTextCompletionController.mm:
1578         (-[WebTextCompletionController _buildUI]):
1579         (-[WebTextCompletionController _placePopupWindow:]):
1580         * WebView/WebView.mm:
1581         (-[WebView applicationFlags:]):
1582
1583 2016-11-09  Beth Dakin  <bdakin@apple.com>
1584
1585         Support TouchBar in WebKit
1586         https://bugs.webkit.org/show_bug.cgi?id=164437
1587         -and corresponding-
1588         rdar://problem/28876524
1589
1590         Reviewed by Darin Adler.
1591
1592         * WebCoreSupport/WebEditorClient.mm:
1593         (WebEditorClient::respondToChangedSelection):
1594         (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
1595         * WebView/WebHTMLView.mm:
1596         (-[WebHTMLView candidateListTouchBarItem]):
1597         * WebView/WebView.mm:
1598         (-[_WebTextListTouchBarViewController initWithWebView:]):
1599         (-[_WebTextListTouchBarViewController _selectList:]):
1600         (-[_WebTextListTouchBarViewController setCurrentListType:]):
1601         (-[WebTextTouchBarItemController initWithWebView:]):
1602         (-[WebTextTouchBarItemController itemForIdentifier:]):
1603         (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
1604         (-[WebTextTouchBarItemController setTextIsBold:]):
1605         (-[WebTextTouchBarItemController setTextIsItalic:]):
1606         (-[WebTextTouchBarItemController setTextIsUnderlined:]):
1607         (-[WebTextTouchBarItemController _webChangeTextStyle:]):
1608         (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
1609         (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
1610         (-[WebTextTouchBarItemController textColor]):
1611         (-[WebTextTouchBarItemController setTextColor:]):
1612         (-[WebTextTouchBarItemController _webChangeColor:]):
1613         (-[WebTextTouchBarItemController textListViewController]):
1614         (-[WebView _commonInitializationWithFrameName:groupName:]):
1615         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1616         (-[WebView shouldRequestCandidates]):
1617         (-[WebView forceRequestCandidatesForTesting]):
1618         (-[WebView makeTouchBar]):
1619         (-[WebView touchBar:makeItemForIdentifier:]):
1620         (textCheckingResultFromNSTextCheckingResult):
1621         (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
1622         (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
1623         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1624         (-[WebView _clearPlaybackControlsManager]):
1625         (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
1626         (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
1627         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
1628         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
1629         (-[WebView touchBarDidExitCustomization:]):
1630         (-[WebView touchBarWillEnterCustomization:]):
1631         (-[WebView didChangeAutomaticTextCompletion:]):
1632         (-[WebView setUpTextTouchBar:]):
1633         (-[WebView _isRichlyEditable]):
1634         (-[WebView textTouchBar]):
1635         (-[WebView updateTextTouchBar]):
1636         (-[WebView updateMediaTouchBar]):
1637         (-[WebView updateTouchBar]):
1638         (-[WebView prepareForMouseDown]):
1639         (-[WebView prepareForMouseUp]):
1640         (-[WebView webViewAdditionsWillDestroyView]):
1641         (-[WebView candidateList]):
1642         (-[WebView updateWebViewAdditions]): Deleted.
1643         * WebView/WebViewData.h:
1644         * WebView/WebViewInternal.h:
1645         * WebView/WebViewPrivate.h:
1646
1647 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1648
1649         Safari does not emit composition end if blurred for dead key / Japanese IME
1650         https://bugs.webkit.org/show_bug.cgi?id=164369
1651         <rdar://problem/29050439>
1652
1653         Reviewed by Ryosuke Niwa.
1654
1655         When canceling a composition, make sure that we clear the system IME state.
1656
1657         * WebCoreSupport/WebEditorClient.h:
1658         * WebCoreSupport/WebEditorClient.mm:
1659         (WebEditorClient::canceledComposition):
1660
1661 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1662
1663         Add a setting and preferences to enable/disable async image decoding
1664         https://bugs.webkit.org/show_bug.cgi?id=164417
1665
1666         Reviewed by Simon Fraser.
1667
1668         Hook up the asyncImageDecodingEnabled setting for WebKit1.
1669
1670         * WebView/WebPreferenceKeysPrivate.h:
1671         * WebView/WebPreferences.mm:
1672         (+[WebPreferences initialize]):
1673         (-[WebPreferences asyncImageDecodingEnabled]):
1674         (-[WebPreferences setAsyncImageDecodingEnabled:]):
1675         * WebView/WebPreferencesPrivate.h:
1676         * WebView/WebView.mm:
1677         (-[WebView _preferencesChanged:]):
1678
1679 2016-11-01  Alex Christensen  <achristensen@webkit.org>
1680
1681         Remove PassRefPtr from DumpRenderTree
1682         https://bugs.webkit.org/show_bug.cgi?id=164307
1683
1684         Reviewed by Sam Weinig.
1685
1686         * WebView/WebGeolocationPosition.mm:
1687         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1688
1689 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1690
1691         [Readable Streams API] Enable creation of ReadableByteStreamController
1692         https://bugs.webkit.org/show_bug.cgi?id=164014
1693
1694         Reviewed by Youenn Fablet.
1695
1696         Added flag for the byte stream part of Readable Streams API.
1697
1698         * Configurations/FeatureDefines.xcconfig:
1699
1700 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
1701
1702         Remove CUSTOM_ELEMENTS build flag
1703         https://bugs.webkit.org/show_bug.cgi?id=164267
1704
1705         Reviewed by Antti Koivisto.
1706
1707         Removed the build flag.
1708
1709         * Configurations/FeatureDefines.xcconfig:
1710         * WebView/WebPreferences.mm:
1711         (+[WebPreferences initialize]):
1712         * WebView/WebView.mm:
1713         (-[WebView _preferencesChanged:]):
1714
1715 2016-11-01  Eric Carlson  <eric.carlson@apple.com>
1716
1717         [MediaStream] restrict media capture secure connections
1718         https://bugs.webkit.org/show_bug.cgi?id=164234
1719         <rdar://problem/28944906>
1720
1721         Reviewed by Alex Christensen.
1722
1723         * WebView/WebPreferenceKeysPrivate.h:
1724         * WebView/WebPreferences.mm:
1725         (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
1726         (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
1727         (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
1728         * WebView/WebPreferencesPrivate.h:
1729
1730         * WebView/WebView.mm:
1731         (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
1732
1733 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
1734
1735         JSC should support SharedArrayBuffer
1736         https://bugs.webkit.org/show_bug.cgi?id=163986
1737
1738         Reviewed by Keith Miller.
1739         
1740         Support the RuntimeFlag.
1741
1742         * WebView/WebPreferencesPrivate.h:
1743
1744 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1745
1746         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
1747         https://bugs.webkit.org/show_bug.cgi?id=164236
1748         <rdar://problem/28747712>
1749
1750         Reviewed by Beth Dakin.
1751
1752         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
1753         dictionary lookup.
1754
1755         * WebCoreSupport/WebEditorClient.mm:
1756         (WebEditorClient::respondToChangedSelection):
1757         * WebView/WebImmediateActionController.mm:
1758         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1759
1760 2016-10-31  Darin Adler  <darin@apple.com>
1761
1762         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
1763         https://bugs.webkit.org/show_bug.cgi?id=164214
1764
1765         Reviewed by Alex Christensen.
1766
1767         * DOM/DOMCSSPrimitiveValue.mm:
1768         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
1769         is a reference now.
1770         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
1771
1772         * DOM/DOMDocument.mm:
1773         (-[DOMDocument querySelector:]): Updated exception handling.
1774         (-[DOMDocument querySelectorAll:]): Ditto.
1775         * DOM/DOMDocumentFragment.mm:
1776         (-[DOMDocumentFragment querySelector:]): Ditto.
1777         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
1778         * DOM/DOMElement.mm:
1779         (-[DOMElement querySelector:]): Ditto.
1780         (-[DOMElement querySelectorAll:]): Ditto.
1781
1782 2016-10-31  Darin Adler  <darin@apple.com>
1783
1784         Convert Document from ExceptionCode to Exception
1785         https://bugs.webkit.org/show_bug.cgi?id=164212
1786
1787         Reviewed by Alex Christensen.
1788
1789         * DOM/DOMDocument.mm:
1790         (-[DOMDocument setXmlVersion:]): Updated exception handling.
1791         (-[DOMDocument cookie]): Ditto.
1792         (-[DOMDocument setCookie:]): Ditto.
1793         (-[DOMDocument setBody:]): Ditto.
1794         (-[DOMDocument createElement:]): Ditto.
1795         (-[DOMDocument createCDATASection:]): Ditto.
1796         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
1797         (-[DOMDocument createAttribute:]): Ditto.
1798         (-[DOMDocument createEntityReference:]): Ditto.
1799         (-[DOMDocument importNode:deep:]): Ditto.
1800         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
1801         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
1802         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
1803         (-[DOMDocument adoptNode:]): Ditto.
1804         (-[DOMDocument createEvent:]): Ditto.
1805
1806 2016-10-30  Darin Adler  <darin@apple.com>
1807
1808         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
1809         https://bugs.webkit.org/show_bug.cgi?id=164206
1810
1811         Reviewed by Chris Dumez.
1812
1813         * DOM/DOMElement.mm:
1814         (-[DOMElement setInnerHTML:]): Updated exception handling.
1815         (-[DOMElement setOuterHTML:]): Ditto.
1816         (-[DOMElement setAttribute:value:]): Ditto.
1817         (-[DOMElement setAttributeNode:]): Ditto.
1818         (-[DOMElement removeAttributeNode:]): Ditto.
1819         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
1820         (-[DOMElement setAttributeNodeNS:]): Ditto.
1821         (-[DOMElement matches:]): Ditto.
1822         (-[DOMElement closest:]): Ditto.
1823         (-[DOMElement webkitMatchesSelector:]): Ditto.
1824         * DOM/DOMHTMLElement.mm:
1825         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
1826         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
1827         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
1828         * DOM/DOMNamedNodeMap.mm:
1829         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
1830         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
1831         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
1832         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
1833
1834 2016-10-29  Darin Adler  <darin@apple.com>
1835
1836         Convert more of DOM from ExceptionCode to Exception
1837         https://bugs.webkit.org/show_bug.cgi?id=164173
1838
1839         Reviewed by Ryosuke Niwa.
1840
1841         * DOM/DOMCharacterData.mm:
1842         (-[DOMCharacterData substringData:length:]): Updated since this
1843         now uses ExceptionOr.
1844         (-[DOMCharacterData insertData:data:]): Ditto.
1845         (-[DOMCharacterData deleteData:length:]): Ditto.
1846         (-[DOMCharacterData replaceData:length:data:]): Ditto.
1847         * DOM/DOMText.mm:
1848         (-[DOMText splitText:]): Ditto.
1849         (-[DOMText replaceWholeText:]): Removed unneeded exception code
1850         handling from function that does not throw an exception.
1851
1852 2016-10-28  Darin Adler  <darin@apple.com>
1853
1854         Move all classes in the HTML directory from ExceptionCode to Exception
1855         https://bugs.webkit.org/show_bug.cgi?id=163876
1856
1857         Reviewed by Sam Weinig.
1858
1859         * DOM/DOMCharacterData.mm:
1860         (-[DOMCharacterData remove]): Updated exception handling.
1861         * DOM/DOMDOMTokenList.mm:
1862         (-[DOMDOMTokenList toggle:force:]): Ditto.
1863         * DOM/DOMDocumentType.mm:
1864         (-[DOMDocumentType remove]): Ditto.
1865         * DOM/DOMElement.mm:
1866         (-[DOMElement remove]): Ditto.
1867         * DOM/DOMHTML.mm:
1868         (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
1869         * DOM/DOMHTMLCanvasElement.mm:
1870         (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
1871         * DOM/DOMHTMLElement.mm:
1872         (-[DOMHTMLElement setInnerText:]): Ditto.
1873         (-[DOMHTMLElement setOuterText:]): Ditto.
1874         (-[DOMHTMLElement setContentEditable:]): Ditto.
1875         * DOM/DOMHTMLInputElement.mm:
1876         (-[DOMHTMLInputElement setMaxLength:]): Ditto.
1877         (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
1878         (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
1879         (-[DOMHTMLInputElement stepUp:]): Ditto.
1880         (-[DOMHTMLInputElement stepDown:]): Ditto.
1881         (-[DOMHTMLInputElement setRangeText:]): Ditto.
1882         (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
1883         * DOM/DOMHTMLMarqueeElement.mm:
1884         (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
1885         * DOM/DOMHTMLMediaElement.mm:
1886         (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
1887         (-[DOMHTMLMediaElement setVolume:]): Ditto.
1888         * DOM/DOMHTMLOptionsCollection.mm:
1889         (-[DOMHTMLOptionsCollection setLength:]): Ditto.
1890         * DOM/DOMHTMLTableElement.mm:
1891         (-[DOMHTMLTableElement setCaption:]): Ditto.
1892         (-[DOMHTMLTableElement setTHead:]): Ditto.
1893         (-[DOMHTMLTableElement setTFoot:]): Ditto.
1894         (-[DOMHTMLTableElement insertRow:]): Ditto.
1895         (-[DOMHTMLTableElement deleteRow:]): Ditto.
1896         * DOM/DOMHTMLTableRowElement.mm:
1897         (-[DOMHTMLTableRowElement insertCell:]): Ditto.
1898         (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
1899         * DOM/DOMHTMLTableSectionElement.mm:
1900         (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
1901         (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
1902         * DOM/DOMHTMLTextAreaElement.mm:
1903         (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
1904         (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
1905         (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
1906         * DOM/DOMHTMLVideoElement.mm:
1907         (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
1908         (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
1909         version (lowercase S) instead of repeating the logic from that method.
1910         (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
1911         * DOM/DOMTimeRanges.mm:
1912         (-[DOMTimeRanges start:]): Updated exception handling.
1913         (-[DOMTimeRanges end:]): Ditto.
1914
1915 2016-10-27  Chris Dumez  <cdumez@apple.com>
1916
1917         Regression(r203601): Caused crashes in iBooks
1918         https://bugs.webkit.org/show_bug.cgi?id=164093
1919         <rdar://problem/28745634>
1920
1921         Reviewed by Darin Adler.
1922
1923         Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
1924         which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
1925
1926         * DOM/DOMNode.mm:
1927         (-[DOMNode compareDocumentPosition:]):
1928
1929 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1930
1931         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
1932         https://bugs.webkit.org/show_bug.cgi?id=163948
1933         <rdar://problem/28921433>
1934
1935         Reviewed by Darin Adler.
1936
1937         Add support for new drag and drop-related EditAction enum values.
1938
1939         * WebCoreSupport/WebEditorClient.mm:
1940         (undoNameForEditAction):
1941
1942 2016-10-27  Dan Bernstein  <mitz@apple.com>
1943
1944         Reapplied the configuration changes from r207934 without breaking iOS builds.
1945
1946         * Configurations/Base.xcconfig:
1947         * Configurations/WebKitLegacy.xcconfig:
1948
1949 2016-10-27  Dan Bernstein  <mitz@apple.com>
1950
1951         Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
1952
1953         * Configurations/Base.xcconfig:
1954         * Configurations/WebKitLegacy.xcconfig:
1955
1956 2016-10-26  Dan Bernstein  <mitz@apple.com>
1957
1958         [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
1959         https://bugs.webkit.org/show_bug.cgi?id=164048
1960
1961         Reviewed by Tim Horton.
1962
1963         * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
1964         * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
1965           headers.
1966
1967         * History/WebBackForwardList.h: Fixed parameter name in @param entry.
1968         * Misc/WebDownload.h: Removed empty entries.
1969         * Misc/WebIconDatabase.h: Remove incorrect @param entries.
1970         * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
1971         * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
1972         * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
1973         * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
1974         * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
1975         * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
1976         * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
1977           Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
1978         * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
1979         * WebView/WebView.h: Changed @method to @property in a couple of places.
1980         * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
1981
1982 2016-10-26  Brian Burg  <bburg@apple.com>
1983
1984         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
1985         https://bugs.webkit.org/show_bug.cgi?id=164046
1986
1987         Reviewed by Joseph Pecoraro.
1988
1989         * WebCoreSupport/WebInspectorClient.h:
1990
1991 2016-10-21  Alex Christensen  <achristensen@webkit.org>
1992
1993         URL::port should return Optional<uint16_t>
1994         https://bugs.webkit.org/show_bug.cgi?id=163806
1995
1996         Reviewed by Darin Adler.
1997
1998         * WebCoreSupport/WebSecurityOrigin.mm:
1999         (-[WebSecurityOrigin port]):
2000
2001 2016-10-24  Dave Hyatt  <hyatt@apple.com>
2002
2003         Remove CSSCharsetRule from the CSS OM
2004         https://bugs.webkit.org/show_bug.cgi?id=163891
2005
2006         Reviewed by Darin Adler.
2007
2008         * DOM/DOMCSSCharsetRule.mm:
2009         (-[DOMCSSCharsetRule encoding]):
2010
2011 2016-10-24  Youenn Fablet  <youenn@apple.com>
2012
2013         Activate WEB_RTC compilation flags for Mac bots
2014         https://bugs.webkit.org/show_bug.cgi?id=163886
2015
2016         Reviewed by Eric Carlson.
2017
2018         * Configurations/FeatureDefines.xcconfig:
2019
2020 2016-10-23  Chris Dumez  <cdumez@apple.com>
2021
2022         addEventListener() / removeEventListener() should use a union for last parameter
2023         https://bugs.webkit.org/show_bug.cgi?id=163863
2024
2025         Reviewed by Darin Adler.
2026
2027         Cast BOOL to bool to help to compiler construct the new variant-type parameter.
2028
2029         * DOM/DOMNode.mm:
2030         (-[DOMNode addEventListener:listener:useCapture:]):
2031         (-[DOMNode addEventListener:::]):
2032         (-[DOMNode removeEventListener:listener:useCapture:]):
2033         (-[DOMNode removeEventListener:::]):
2034
2035 2016-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2036
2037         Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
2038         https://bugs.webkit.org/show_bug.cgi?id=163460
2039         <rdar://problem/28784142>
2040
2041         Reviewed by Darin Adler.
2042
2043         Handle new EditAction types for inserting/deleting pending/final compositions.
2044
2045         * WebCoreSupport/WebEditorClient.mm:
2046         (undoNameForEditAction):
2047
2048 2016-10-21  Jeremy Jones  <jeremyj@apple.com>
2049
2050         Implement basic pointer lock behavior for WebKit and WebKit2.
2051         https://bugs.webkit.org/show_bug.cgi?id=162745
2052
2053         Reviewed by Simon Fraser.
2054
2055         Add basic pointer lock functionality. User permission is not yet implemented.
2056
2057         * WebCoreSupport/WebChromeClient.h:
2058         * WebCoreSupport/WebChromeClient.mm:
2059         (WebChromeClient::requestPointerLock):
2060         (WebChromeClient::requestPointerUnlock):
2061
2062 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
2063
2064         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
2065         https://bugs.webkit.org/show_bug.cgi?id=163374
2066
2067         Reviewed by Darin Adler.
2068
2069         * Configurations/FeatureDefines.xcconfig:
2070
2071 2016-10-19  Alex Christensen  <achristensen@webkit.org>
2072
2073         Revert r207151
2074         https://bugs.webkit.org/show_bug.cgi?id=163675
2075
2076         Reviewed by Brent Fulgham.
2077
2078         * Misc/WebDownload.mm:
2079         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
2080         * Misc/WebDownloadInternal.h:
2081         * WebCoreSupport/WebFrameLoaderClient.mm:
2082         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2083         * WebView/WebPreferences.mm:
2084         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
2085         * WebView/WebView.mm:
2086         (-[WebView scheduleInRunLoop:forMode:]):
2087         (-[WebView unscheduleFromRunLoop:forMode:]):
2088
2089 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
2090
2091         Unreviewed, rolling out r207557.
2092
2093         This change caused animations/font-variations tests to time
2094         out on pre-Sierra Macs.
2095
2096         Reverted changeset:
2097
2098         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
2099         iOS 9"
2100         https://bugs.webkit.org/show_bug.cgi?id=163374
2101         http://trac.webkit.org/changeset/207557
2102
2103 2016-10-19  Chris Dumez  <cdumez@apple.com>
2104
2105         Move HTML Interactive Form Validation behind an experimental flag
2106         https://bugs.webkit.org/show_bug.cgi?id=163673
2107
2108         Reviewed by Daniel Bates.
2109
2110         Re-disable HTML Interactive Form Validation by default on Mac WK1.
2111
2112         * WebView/WebViewData.mm:
2113         (-[WebViewPrivate init]):
2114
2115 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
2116
2117         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
2118         https://bugs.webkit.org/show_bug.cgi?id=163374
2119
2120         Reviewed by Darin Adler.
2121
2122         * Configurations/FeatureDefines.xcconfig:
2123
2124 2016-10-19  Simon Fraser  <simon.fraser@apple.com>
2125
2126         WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
2127         https://bugs.webkit.org/show_bug.cgi?id=163680
2128
2129         Reviewed by Dean Jackson.
2130
2131         Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
2132
2133         * WebView/WebView.mm:
2134         (-[WebView _preferencesChanged:]):
2135
2136 2016-10-19  Darin Adler  <darin@apple.com>
2137
2138         Move XPath from ExceptionCode to Exception
2139         https://bugs.webkit.org/show_bug.cgi?id=163656
2140
2141         Reviewed by Chris Dumez.
2142
2143         * DOM/DOMDocument.mm:
2144         (wrap): Added. Helper function for wrapping a resolver.
2145         (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
2146         (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
2147         * DOM/DOMXPathExpression.mm:
2148         (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
2149         * DOM/DOMXPathResult.mm:
2150         (-[DOMXPathResult numberValue]): Ditto.
2151         (-[DOMXPathResult stringValue]): Ditto.
2152         (-[DOMXPathResult booleanValue]): Ditto.
2153         (-[DOMXPathResult singleNodeValue]): Ditto.
2154         (-[DOMXPathResult snapshotLength]): Ditto.
2155         (-[DOMXPathResult iterateNext]): Ditto.
2156         (-[DOMXPathResult snapshotItem:]): Ditto.
2157
2158 2016-10-18  Sam Weinig  <sam@webkit.org>
2159
2160         Replace std::experimental::variant with WTF::Variant (or similar)
2161         https://bugs.webkit.org/show_bug.cgi?id=163626
2162
2163         Reviewed by Chris Dumez.
2164
2165         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
2166         into the WTF namespace.
2167
2168         * DOM/DOMHTMLSelectElement.mm:
2169         (-[DOMHTMLSelectElement add:before:]):
2170
2171 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
2172
2173         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
2174         https://bugs.webkit.org/show_bug.cgi?id=163627
2175
2176         Reviewed by Dean Jackson.
2177
2178         Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
2179
2180         * WebView/WebViewPrivate.h:
2181
2182 2016-10-18  Dean Jackson  <dino@apple.com>
2183
2184         Remove CSS_SHAPES feature definition. This should always be on.
2185         https://bugs.webkit.org/show_bug.cgi?id=163628
2186         <rdar://problem/28834613>
2187
2188         Reviewed by Tim Horton.
2189
2190         * Configurations/FeatureDefines.xcconfig:
2191
2192 2016-10-18  Chris Dumez  <cdumez@apple.com>
2193
2194         Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
2195         https://bugs.webkit.org/show_bug.cgi?id=163608
2196
2197         Reviewed by Ryosuke Niwa.
2198
2199         Update add() call sites now that it takes std::variant types in.
2200
2201         * DOM/DOMHTMLOptionsCollection.mm:
2202         (-[DOMHTMLOptionsCollection add:index:]):
2203         * DOM/DOMHTMLSelectElement.mm:
2204         (-[DOMHTMLSelectElement add:before:]):
2205
2206 2016-10-18  Anders Carlsson  <andersca@apple.com>
2207
2208         Get rid of more WebHistoryItem cruft
2209         https://bugs.webkit.org/show_bug.cgi?id=163623
2210
2211         Reviewed by Tim Horton.
2212
2213         * History/WebHistoryItem.mm:
2214         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2215         * History/WebHistoryItemPrivate.h:
2216
2217 2016-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2218
2219         Showing and hiding candidates list is very distracting after selecting word
2220         https://bugs.webkit.org/show_bug.cgi?id=163609
2221         <rdar://problem/28747712>
2222
2223         Reviewed by Tim Horton.
2224
2225         Introduce WebView hooks for mousedown and mouseup. See radar for more details.
2226
2227         * WebView/WebHTMLView.mm:
2228         (-[WebHTMLView mouseDown:mouseDown:]):
2229         (-[WebHTMLView mouseUp:mouseUp:]):
2230         * WebView/WebView.mm:
2231         (-[WebView prepareForMouseDown]):
2232         (-[WebView prepareForMouseUp]):
2233         * WebView/WebViewInternal.h:
2234
2235 2016-10-17  Anders Carlsson  <andersca@apple.com>
2236
2237         Move some history specific HistoryItem code to WebHistoryItem
2238         https://bugs.webkit.org/show_bug.cgi?id=163567
2239
2240         Reviewed by Tim Horton.
2241
2242         * History/HistoryPropertyList.mm:
2243         (HistoryPropertyListWriter::writeHistoryItem):
2244         * History/WebHistory.mm:
2245         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
2246         * History/WebHistoryItem.mm:
2247         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2248         * History/WebHistoryItemInternal.h:
2249         * WebCoreSupport/WebFrameLoaderClient.mm:
2250         (addRedirectURL):
2251         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
2252
2253 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
2254
2255         [MediaStream] Resolve constraints and enumerate devices in the UI process
2256         https://bugs.webkit.org/show_bug.cgi?id=162147
2257         <rdar://problem/28803569>
2258
2259         Reviewed by Darin Adler.
2260
2261         * WebCoreSupport/WebUserMediaClient.h:
2262         * WebCoreSupport/WebUserMediaClient.mm:
2263         (AddPermissionCheckToMap):
2264         (RemovePermissionCheckFromMap):
2265         (WebUserMediaClient::pageDestroyed):
2266         (WebUserMediaClient::requestUserMediaAccess):
2267         (WebUserMediaClient::enumerateMediaDevices):
2268         (WebUserMediaClient::cancelMediaDevicesEnumerationRequest):
2269         (-[WebUserMediaPolicyListener allow]):
2270         (-[WebUserMediaPolicyListener deny]):
2271         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
2272         (-[WebUserMediaPolicyCheckerListener cancelMediaDevicesEnumerationRequest]):
2273         (-[WebUserMediaPolicyCheckerListener allow]):
2274         (-[WebUserMediaPolicyCheckerListener deny]):
2275         (WebUserMediaClient::checkUserMediaPermission): Deleted.
2276         (WebUserMediaClient::cancelUserMediaPermissionCheck): Deleted.
2277         (-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]): Deleted.
2278         (-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]): Deleted.
2279
2280 2016-10-17  Antti Koivisto  <antti@apple.com>
2281
2282         Rename setNeedsStyleRecalc to invalidateStyle
2283         https://bugs.webkit.org/show_bug.cgi?id=163542
2284
2285         Reviewed by Darin Adler.
2286
2287         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2288         (-[WebHostedNetscapePluginView createPluginLayer]):
2289         * Plugins/WebNetscapePluginView.mm:
2290         (-[WebNetscapePluginView createPlugin]):
2291
2292 2016-10-17  Jeremy Jones  <jeremyj@apple.com>
2293
2294         Enable keyboard in fullscreen.
2295         https://bugs.webkit.org/show_bug.cgi?id=163146
2296
2297         Reviewed by Jer Noble.
2298
2299         Allow keyboard in fullscreen.
2300
2301         * WebView/WebView.mm:
2302         (-[WebView _supportsFullScreenForElement:withKeyboard:]):
2303
2304 2016-10-17  Chris Dumez  <cdumez@apple.com>
2305
2306         Move form.reportValidity() behind InteractiveFormValidation setting
2307         https://bugs.webkit.org/show_bug.cgi?id=163550
2308
2309         Reviewed by Darin Adler.
2310
2311         Enable InteractiveFormValidation setting by default and link it to
2312         RuntimeEnabledFeatures so we can use it in the IDL.
2313
2314         * WebView/WebView.mm:
2315         (-[WebView _preferencesChanged:]):
2316         * WebView/WebViewData.mm:
2317         (-[WebViewPrivate init]):
2318
2319 2016-10-17  Anders Carlsson  <andersca@apple.com>
2320
2321         Fix iOS build.
2322
2323         * History/WebBackForwardList.mm:
2324         (-[WebBackForwardList dictionaryRepresentation]):
2325
2326 2016-10-17  Anders Carlsson  <andersca@apple.com>
2327
2328         CTTE some of the BackForwardList member functions
2329         https://bugs.webkit.org/show_bug.cgi?id=163555
2330
2331         Reviewed by Dan Bernstein.
2332
2333         * History/BackForwardList.h:
2334         (BackForwardList::entries):
2335         * History/BackForwardList.mm:
2336         (BackForwardList::removeItem):
2337         (BackForwardList::containsItem):
2338         (BackForwardList::entries): Deleted.
2339         * History/WebBackForwardList.mm:
2340         (-[WebBackForwardList removeItem:]):
2341         (-[WebBackForwardList containsItem:]):
2342         (-[WebBackForwardList description]):
2343
2344 2016-10-17  Anders Carlsson  <andersca@apple.com>
2345
2346         Remove WEBCORE_EXPORT from BackForwardList, it lives in WebKit now
2347         https://bugs.webkit.org/show_bug.cgi?id=163551
2348
2349         Reviewed by Tim Horton.
2350
2351         * History/BackForwardList.h:
2352
2353 2016-10-16  Darin Adler  <darin@apple.com>
2354
2355         Move CSS classes from ExceptionCode to Exception
2356         https://bugs.webkit.org/show_bug.cgi?id=163494
2357
2358         Reviewed by Sam Weinig.
2359
2360         * DOM/DOMCSSMediaRule.mm:
2361         (-[DOMCSSMediaRule insertRule:index:]): Use raiseOnDOMError
2362         the new way to handle ExceptionOr instead of ExceptionCode.
2363         (-[DOMCSSMediaRule deleteRule:]): Ditto.
2364         * DOM/DOMCSSPrimitiveValue.mm:
2365         (-[DOMCSSPrimitiveValue setFloatValue:floatValue:]): Ditto.
2366         (-[DOMCSSPrimitiveValue getFloatValue:]): Ditto.
2367         (-[DOMCSSPrimitiveValue setStringValue:stringValue:]): Ditto.
2368         (-[DOMCSSPrimitiveValue getStringValue]): Ditto.
2369         (-[DOMCSSPrimitiveValue getCounterValue]): Ditto.
2370         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
2371         (-[DOMCSSPrimitiveValue getRGBColorValue]): Ditto.
2372         * DOM/DOMCSSRule.mm:
2373         (-[DOMCSSRule setCssText:]): Ditto.
2374         * DOM/DOMCSSStyleDeclaration.mm:
2375         (-[DOMCSSStyleDeclaration setCssText:]): Ditto.
2376         (-[DOMCSSStyleDeclaration removeProperty:]): Ditto.
2377         (-[DOMCSSStyleDeclaration setProperty:value:priority:]): Ditto.
2378         * DOM/DOMCSSStyleSheet.mm:
2379         (-[DOMCSSStyleSheet insertRule:index:]): Ditto.
2380         (-[DOMCSSStyleSheet deleteRule:]): Ditto.
2381         (-[DOMCSSStyleSheet addRule:style:index:]): Ditto.
2382         (-[DOMCSSStyleSheet removeRule:]): Ditto.
2383         * DOM/DOMCSSValue.mm:
2384         (-[DOMCSSValue setCssText:]): Ditto.
2385         * DOM/DOMMediaList.mm:
2386         (-[DOMMediaList setMediaText:]): Ditto.
2387         (-[DOMMediaList deleteMedium:]): Ditto.
2388         (-[DOMMediaList appendMedium:]): Ditto.
2389
2390         * DOM/ExceptionHandlers.h: Added an overload of raiseDOMException
2391         that works with a WebCore::Exception&& and overloads of
2392         raiseOnDOMError that work with WebCore::ExceptionOr&&.
2393         * DOM/ExceptionHandlers.mm:
2394         (raiseDOMException): Implemented the new version.
2395
2396 2016-10-15  Dan Bernstein  <mitz@apple.com>
2397
2398         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
2399         https://bugs.webkit.org/show_bug.cgi?id=163492
2400         <rdar://problem/28654799>
2401
2402         Reviewed by Darin Adler.
2403
2404         Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm
2405
2406         * WebView/WebHTMLView.mm:
2407         (createMenuItem): Set the tag for items that have submenus as well.
2408
2409 2016-10-14  Anders Carlsson  <andersca@apple.com>
2410
2411         Clean up BackForwardClient
2412         https://bugs.webkit.org/show_bug.cgi?id=163454
2413
2414         Reviewed by Sam Weinig.
2415
2416         * History/BackForwardList.h:
2417         Remove override keywords.
2418
2419         * History/BackForwardList.mm:
2420         (BackForwardList::clearAllPageCaches): Deleted.
2421         Remove this, it's no longer used.
2422
2423         * WebView/WebView.mm:
2424         (-[WebView _clearBackForwardCache]): Deleted.
2425         * WebView/WebViewPrivate.h:
2426         Remove SPI that's no longer used by anyone.
2427
2428 2016-10-13  Anders Carlsson  <andersca@apple.com>
2429
2430         Move BackForwardList from WebCore to WebKitLegacy
2431         https://bugs.webkit.org/show_bug.cgi?id=163418
2432
2433         Reviewed by Tim Horton.
2434
2435         * History/BackForwardList.h: Renamed from Source/WebCore/history/BackForwardList.h.
2436         (BackForwardList::create):
2437         (BackForwardList::webView):
2438         * History/BackForwardList.mm: Renamed from Source/WebCore/history/BackForwardList.cpp.
2439         (BackForwardList::BackForwardList):
2440         (BackForwardList::close):
2441         (BackForwardList::containsItem):
2442         * History/WebBackForwardList.mm:
2443         (kit):
2444         (-[WebBackForwardList initWithBackForwardList:]):
2445         (-[WebBackForwardList setPageCacheSize:]):
2446         (-[WebBackForwardList pageCacheSize]):
2447         * History/WebBackForwardListInternal.h:
2448         * WebCoreSupport/WebFrameLoaderClient.mm:
2449         * WebView/WebFrameView.mm:
2450         * WebView/WebView.mm:
2451         (-[WebView _commonInitializationWithFrameName:groupName:]):
2452         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2453
2454 2016-10-13  Anders Carlsson  <andersca@apple.com>
2455
2456         Get rid of the HistoryItemVector typedef
2457         https://bugs.webkit.org/show_bug.cgi?id=163398
2458
2459         Reviewed by Beth Dakin.
2460
2461         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
2462
2463         * History/WebBackForwardList.mm:
2464         (-[WebBackForwardList dictionaryRepresentation]):
2465         (vectorToNSArray):
2466         (-[WebBackForwardList backListWithLimit:]):
2467         (-[WebBackForwardList forwardListWithLimit:]):
2468         (-[WebBackForwardList description]):
2469         * History/WebHistoryItem.mm:
2470         (-[WebHistoryItem description]):
2471
2472 2016-10-12  Chris Dumez  <cdumez@apple.com>
2473
2474         [Web IDL] Drop support for legacy [ConstructorConditional=*]
2475         https://bugs.webkit.org/show_bug.cgi?id=163368
2476
2477         Reviewed by Ryosuke Niwa.
2478
2479         Drop ENABLE_DOM4_EVENTS_CONSTRUCTOR compiler flag.
2480
2481         * Configurations/FeatureDefines.xcconfig:
2482
2483 2016-10-12  Beth Dakin  <bdakin@apple.com>
2484
2485         Adobe Contribute CS 6.5 Trial crashes on launch
2486         https://bugs.webkit.org/show_bug.cgi?id=163365
2487         -and corresponding-
2488         <rdar://problem/28732731>
2489
2490         Reviewed by Tim Horton.
2491
2492         * Carbon/CarbonWindowFrame.m:
2493         (-[CarbonWindowFrame contentFill]):
2494
2495 2016-10-11  Daniel Bates  <dabates@apple.com>
2496
2497         Attempt to fix the Apple Internal Mac build following r207159
2498         (https://bugs.webkit.org/show_bug.cgi?id=163244)
2499
2500         * WebView/WebView.mm:
2501         (shouldRequireUserGestureToLoadVideo):
2502
2503 2016-10-11  Daniel Bates  <dabates@apple.com>
2504
2505         REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
2506         https://bugs.webkit.org/show_bug.cgi?id=163259
2507         <rdar://problem/28680515>
2508
2509         Reviewed by Jer Noble.
2510
2511         In WebKit1 on iOS we want to require user action to load and play videos by default and
2512         allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
2513         Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
2514         can load and play without being initiated by a user action.
2515
2516         * WebView/WebPreferences.mm:
2517         (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
2518         WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
2519         preference takes precedence over the values of its replacement preferences
2520         WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
2521
2522 2016-10-11  Daniel Bates  <dabates@apple.com>
2523
2524         [iOS] REGRESSION (r197953): User gesture required to load video in iOS 9-built apps
2525         https://bugs.webkit.org/show_bug.cgi?id=163244
2526         <rdar://problem/27250015>
2527
2528         Reviewed by Jer Noble.
2529
2530         Enable or disable the Setting::requiresUserGestureToLoadVideo() in legacy WebKit depending
2531         on the version of iOS SDK that the app was linked against. We require a user gesture to
2532         begin loading a video as of iOS 10.
2533
2534         * WebView/WebView.mm:
2535         (shouldRequireUserGestureToLoadVideo):
2536         (-[WebView _preferencesChanged:]): Modified to pass the WebKit requiresUserGestureToLoadVideo
2537         preference to WebCore.
2538
2539 2016-10-11  Alex Christensen  <achristensen@webkit.org>
2540
2541         Remove dead networking code
2542         https://bugs.webkit.org/show_bug.cgi?id=163263
2543
2544         Reviewed by Daniel Bates.
2545
2546         * Misc/WebDownload.mm:
2547         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2548         * Misc/WebDownloadInternal.h:
2549         * WebCoreSupport/WebFrameLoaderClient.mm:
2550         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2551         * WebView/WebPreferences.mm:
2552         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
2553         * WebView/WebView.mm:
2554         (-[WebView scheduleInRunLoop:forMode:]):
2555         (-[WebView unscheduleFromRunLoop:forMode:]):
2556
2557 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
2558
2559         Add ENABLE_ENCRYPTED_MEDIA configuration option
2560         https://bugs.webkit.org/show_bug.cgi?id=163219
2561
2562         Reviewed by Darin Adler.
2563
2564         * Configurations/FeatureDefines.xcconfig:
2565         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
2566         to enable or disable the new EME implementation at build-time.
2567
2568 2016-10-10  Darin Adler  <darin@apple.com>
2569
2570         Move NotificationCenter from legacy to new DOM exceptions
2571         https://bugs.webkit.org/show_bug.cgi?id=163217
2572
2573         Reviewed by Chris Dumez.
2574
2575         * WebView/WebView.mm:
2576         (-[WebView _notificationIDForTesting:]): Pass reference to page rather than pointer.
2577
2578 2016-10-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2579
2580         Support InputEvent.inputType for the new InputEvent spec
2581         https://bugs.webkit.org/show_bug.cgi?id=163025
2582         <rdar://problem/28658092>
2583
2584         Reviewed by Darin Adler.
2585
2586         Accounts for some changes to the EditAction enum in nameForEditAction. See WebCore ChangeLog
2587         entry for more details.
2588
2589         * WebCoreSupport/WebEditorClient.mm:
2590         (undoNameForEditAction):
2591
2592 2016-10-06  Darin Adler  <darin@apple.com>
2593
2594         Next step on moving to modern way to return DOM exceptions
2595         https://bugs.webkit.org/show_bug.cgi?id=163016
2596
2597         Reviewed by Ryosuke Niwa.
2598
2599         * DOM/DOMDOMImplementation.mm:
2600         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated for
2601         name change from takeReturnValue to releaseReturnValue.
2602         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2603
2604 2016-10-07  Simon Fraser  <simon.fraser@apple.com>
2605
2606         [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
2607         https://bugs.webkit.org/show_bug.cgi?id=163154
2608         rdar://problem/28674216
2609
2610         Reviewed by Tim Horton.
2611         
2612         r55159 added code to counteract AppKit's adjustment of dirty regions during scrolling,
2613         by offsetting the dirty rect in -setNeedsDisplayInRect: if the call happens during
2614         the NSViewBoundsDidChangeNotification handling.
2615         
2616         However, AppKit only does dirty region adjustment in the code path that blits ("copy
2617         on scroll"), so r55159 produces incorrect behavior in, for example, layer-backed views.
2618         
2619         Fix by overriding -[NSClipView _canCopyOnScrollForDeltaX:deltaY:] to know if a single
2620         scroll is going to blit, and only do adjustments in -setNeedsDisplayInRect: if it is.
2621
2622         * WebView/WebClipView.h:
2623         * WebView/WebClipView.mm:
2624         (-[WebClipView _immediateScrollToPoint:]):
2625         (-[WebClipView _canCopyOnScrollForDeltaX:deltaY:]):
2626         (-[WebClipView currentScrollIsBlit]):
2627         * WebView/WebHTMLView.mm:
2628         (-[WebHTMLView setNeedsDisplayInRect:]):
2629         (-[WebHTMLView drawRect:]):
2630
2631 2016-10-06  Youenn Fablet  <youenn@apple.com>
2632
2633         CachedResource client handling methods should take reference
2634         https://bugs.webkit.org/show_bug.cgi?id=163014
2635
2636         Reviewed by Alex Christensen.
2637
2638         * WebView/WebHTMLView.mm:
2639         (promisedDataClient):
2640
2641 2016-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
2642
2643         Put variation fonts work behind a compile-time flag
2644         https://bugs.webkit.org/show_bug.cgi?id=162949
2645
2646         Reviewed by Simon Fraser.
2647
2648         * Configurations/FeatureDefines.xcconfig:
2649
2650 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
2651
2652         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
2653         https://bugs.webkit.org/show_bug.cgi?id=162903
2654
2655         Reviewed by Alex Christensen.
2656
2657         Rename build guards for the remaining implementation of the legacy EME API
2658         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
2659         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
2660
2661         * Configurations/FeatureDefines.xcconfig:
2662         * WebView/WebPreferences.mm:
2663         (+[WebPreferences initialize]):
2664         * WebView/WebView.mm:
2665         (-[WebView _preferencesChanged:]):
2666
2667 2016-10-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2668
2669         The dragged image should be the current frame only of the animated image
2670         https://bugs.webkit.org/show_bug.cgi?id=162109
2671
2672         Reviewed by Tim Horton.
2673
2674         * DOM/DOM.mm:
2675         (-[DOMElement image]): Call the Image function with its new name.
2676         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2677         * Misc/WebElementDictionary.mm:
2678         (-[WebElementDictionary _image]): Call the Image function with its new name.
2679         * Misc/WebIconDatabase.mm:
2680         (-[WebIconDatabase defaultIconWithSize:]): Call snapshotNSImage() to create the icon image.
2681         (webGetNSImage): Call the Image function with its new name.
2682         * WebCoreSupport/WebContextMenuClient.mm:
2683         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call snapshotNSImage() instead of nsImage()..
2684         (WebContextMenuClient::contextMenuForEvent): Ditto.
2685         * WebView/WebHTMLView.mm:
2686         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2687
2688 2016-10-02  Ryan Haddad  <ryanhaddad@apple.com>
2689
2690         Unreviewed, rolling out r206683.
2691
2692         This change caused API test WebKit2.FindMatches to fail on
2693         Mac.
2694
2695         Reverted changeset:
2696
2697         "The dragged image should be the current frame only of the
2698         animated image"
2699         https://bugs.webkit.org/show_bug.cgi?id=162109
2700         http://trac.webkit.org/changeset/206683
2701
2702 2016-09-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
2703
2704         The dragged image should be the current frame only of the animated image
2705         https://bugs.webkit.org/show_bug.cgi?id=162109
2706
2707         Reviewed by Tim Horton.
2708
2709         * DOM/DOM.mm:
2710         (-[DOMElement image]): Call the Image function with its new name.
2711         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2712         * Misc/WebElementDictionary.mm:
2713         (-[WebElementDictionary _image]): Call the Image function with its new name.
2714         * Misc/WebIconDatabase.mm:
2715         (-[WebIconDatabase defaultIconWithSize:]): Call currentFrameNSImage() to create the icon image.
2716         (webGetNSImage): Call the Image function with its new name.
2717         * WebCoreSupport/WebContextMenuClient.mm:
2718         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call currentFrameNSImage() instead of nsImage()..
2719         (WebContextMenuClient::contextMenuForEvent): Ditto.
2720         * WebView/WebHTMLView.mm:
2721         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2722
2723 2016-09-27  Jer Noble  <jer.noble@apple.com>
2724
2725         Remove deprecated ENCRYPTED_MEDIA implementation.
2726         https://bugs.webkit.org/show_bug.cgi?id=161010
2727
2728         Remove ENABLE_ENCRYPTED_MEDIA.
2729
2730         Reviewed by Eric Carlson.
2731
2732         * Configurations/FeatureDefines.xcconfig:
2733
2734 2016-09-26  Daniel Bates  <dabates@apple.com>
2735
2736         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
2737         https://bugs.webkit.org/show_bug.cgi?id=162365
2738
2739         Reviewed by Simon Fraser.
2740
2741         * Configurations/FeatureDefines.xcconfig:
2742         * WebView/WebFrame.mm:
2743         * WebView/WebPreferences.mm:
2744         (+[WebPreferences initialize]):
2745         * WebView/WebView.mm:
2746         (-[WebView _preferencesChanged:]):
2747
2748 2016-09-25  Antti Koivisto  <antti@apple.com>
2749
2750         AuthorStyleSheets shouldn't trigger synchronous style resolutions
2751         https://bugs.webkit.org/show_bug.cgi?id=162532
2752
2753         Reviewed by Darin Adler.
2754
2755         * WebView/WebHTMLView.mm:
2756         (-[WebHTMLView reapplyStyles]):
2757         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2758
2759 2016-09-24  Antti Koivisto  <antti@apple.com>
2760
2761         Move stylesheet change logic from Document to AuthorStyleSheets
2762         https://bugs.webkit.org/show_bug.cgi?id=162488
2763
2764         Reviewed by Andreas Kling.
2765
2766         * WebView/WebHTMLView.mm:
2767         (-[WebHTMLView reapplyStyles]):
2768         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2769
2770 2016-09-23  Caitlin Potter  <caitp@igalia.com>
2771
2772         [JSC] Implement parsing of Async Functions
2773         https://bugs.webkit.org/show_bug.cgi?id=161409
2774
2775         Reviewed by Yusuke Suzuki.
2776
2777         * Configurations/FeatureDefines.xcconfig:
2778
2779 2016-09-23  Commit Queue  <commit-queue@webkit.org>
2780
2781         Unreviewed, rolling out r206311.
2782         https://bugs.webkit.org/show_bug.cgi?id=162495
2783
2784         Broke internal iOS build (Requested by anttik on #webkit).
2785
2786         Reverted changeset:
2787
2788         "Move stylesheet change logic from Document to
2789         AuthorStyleSheets"
2790         https://bugs.webkit.org/show_bug.cgi?id=162488
2791         http://trac.webkit.org/changeset/206311
2792
2793 2016-09-23  Antoine Quint  <graouts@apple.com>
2794
2795         Add a new runtime flag for work on modern media controls (off by default)
2796         https://bugs.webkit.org/show_bug.cgi?id=162420
2797         <rdar://problem/27989489>
2798
2799         Reviewed by Eric Carlson.
2800
2801         * WebView/WebPreferenceKeysPrivate.h:
2802         * WebView/WebPreferences.mm:
2803         (-[WebPreferences modernMediaControlsEnabled]):
2804         (-[WebPreferences setModernMediaControlsEnabled:]):
2805         * WebView/WebPreferencesPrivate.h:
2806         * WebView/WebView.mm:
2807         (-[WebView _preferencesChanged:]):
2808
2809 2016-09-21  Anders Carlsson  <andersca@apple.com>
2810
2811         Support openPaymentSetup API on ApplePaySession object
2812         https://bugs.webkit.org/show_bug.cgi?id=162357
2813         rdar://problem/26776939
2814
2815         Reviewed by Tim Horton.
2816
2817         Add openPaymentSetup stub.
2818
2819         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2820         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2821         (WebPaymentCoordinatorClient::openPaymentSetup):
2822
2823 2016-09-19  Daniel Bates  <dabates@apple.com>
2824
2825         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
2826         https://bugs.webkit.org/show_bug.cgi?id=162167
2827
2828         Reviewed by Simon Fraser.
2829
2830         * Configurations/FeatureDefines.xcconfig:
2831
2832 2016-09-19  Joseph Pecoraro  <pecoraro@apple.com>
2833
2834         Web Inspector: Bring the inspected page's window forward when activating element search
2835         https://bugs.webkit.org/show_bug.cgi?id=162114
2836         <rdar://problem/28349357>
2837
2838         Reviewed by Brian Burg.
2839
2840         * WebCoreSupport/WebInspectorClient.mm:
2841         (WebInspectorClient::didSetSearchingForNode):
2842         When element search is activated bring the window
2843         containing the inspected page to the foreground.
2844
2845 2016-09-15  Brady Eidson  <beidson@apple.com>
2846
2847         WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
2848         <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
2849
2850         Reviewed by Brent Fulgham. 
2851
2852         * WebCoreSupport/WebFrameLoaderClient.h:
2853         * WebCoreSupport/WebFrameLoaderClient.mm:
2854         (WebFrameLoaderClient::dispatchDidCommitLoad):
2855
2856 2016-09-15  Anders Carlsson  <andersca@apple.com>
2857
2858         This was supposed to be committed with the previous patch!
2859
2860         * Plugins/WebBasePluginPackage.mm:
2861         (pathByResolvingSymlinksAndAliases): Deleted.
2862
2863 2016-09-15  Anders Carlsson  <andersca@apple.com>
2864
2865         Replace use of Carbon file system APIs in plug-in loading
2866         https://bugs.webkit.org/show_bug.cgi?id=162040
2867         rdar://problem/6017896
2868
2869         Reviewed by Sam Weinig.
2870
2871         * Plugins/WebBasePluginPackage.mm:
2872         (-[WebBasePluginPackage initWithPath:]):
2873         Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
2874         to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).
2875
2876 2016-09-15  Beth Dakin  <bdakin@apple.com>
2877
2878         Need hasMarkedText on Mac
2879         https://bugs.webkit.org/show_bug.cgi?id=162026
2880         -and corresponding-
2881         rdar://problem/28272353
2882
2883         Reviewed by Anders Carlsson.
2884
2885         * WebView/WebHTMLViewInternal.h:
2886
2887 2016-09-12  Dean Jackson  <dino@apple.com>
2888
2889         Replace RGBA32 with Color in member variables
2890         https://bugs.webkit.org/show_bug.cgi?id=161856
2891         <rdar://problem/28254324>
2892
2893         Reviewed by Simon Fraser.
2894
2895         In preparation for the Color class to become more than
2896         just a 4-byte RGBA value, I went through a few places
2897         that were using the RGBA32 type directly, and replaced
2898         them with Color. This will make some objects a little
2899         bigger e.g. BorderValue and its friends.
2900
2901         I mostly looked at the places that were using RGBA32 as
2902         a member variable. There is still a lot of RGBA32 use
2903         around the project, in particular the CSS parser.
2904
2905         There should be no behaviour change.
2906
2907         * Misc/WebKitNSStringExtras.mm:
2908         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Explicitly
2909         call a Color constructor, rather than passing an RGBA32.
2910
2911 2016-09-13  Chris Dumez  <cdumez@apple.com>
2912
2913         Drop support for <isindex>
2914         https://bugs.webkit.org/show_bug.cgi?id=7139
2915
2916         Reviewed by Ryosuke Niwa.
2917
2918         Drop references to isindex.
2919
2920         * WebCoreSupport/WebEditorClient.mm:
2921         (attributesForAttributedStringConversion):
2922         * WebView/WebHTMLView.mm:
2923         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
2924
2925 2016-09-12  Chris Dumez  <cdumez@apple.com>
2926
2927         Switch remaining users of Document::inPageCache() to pageCacheState()
2928         https://bugs.webkit.org/show_bug.cgi?id=161865
2929
2930         Reviewed by Darin Adler.
2931
2932         Switch remaining users of Document::inPageCache() to pageCacheState() as
2933         the former one is confusing (given that it returns true while the
2934         pagehide event is being fired).
2935
2936         * WebView/WebHTMLView.mm:
2937         (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]):
2938         (-[WebHTMLView setNeedsLayout:]):
2939         (-[WebHTMLView setNeedsToApplyStyles:]):
2940
2941 2016-09-09  Tim Horton  <timothy_horton@apple.com>
2942
2943         Text replacement candidates don't always overwrite the entire original string
2944         https://bugs.webkit.org/show_bug.cgi?id=161779
2945         <rdar://problem/28033492>
2946
2947         Reviewed by Simon Fraser.
2948
2949         * WebCoreSupport/WebEditorClient.mm:
2950         (WebEditorClient::requestCandidatesForSelection):
2951         Make use of the shared implementation of contextRangeForCandidateRequest.
2952
2953 2016-09-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
2954
2955         Move the BitmapImage platform dependent code to a new file named NativeImage[CG|Cairo].cpp
2956         https://bugs.webkit.org/show_bug.cgi?id=158684
2957
2958         Reviewed by Simon Fraser.
2959
2960         * DOM/DOM.mm:
2961         (-[DOMNode getPreviewSnapshotImage:andRects:]):
2962         * Misc/WebCache.mm:
2963         (+[WebCache imageForURL:]):
2964         Replace BitmapImage::getCGImageRef() with BitmapImage::nativeImage().
2965
2966 2016-09-07  Joseph Pecoraro  <pecoraro@apple.com>
2967
2968         [Mac] Address some clang static analyzer warnings in WebKit
2969         https://bugs.webkit.org/show_bug.cgi?id=161597
2970
2971         Reviewed by Darin Adler.
2972
2973         * Misc/WebIconDatabase.h:
2974         Remove unused instance variable. It has not been used since r16005 (2006)!
2975
2976         * Misc/WebSharingServicePickerController.mm:
2977         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2978         Address array leak.
2979
2980         * WebCoreSupport/WebSelectionServiceController.mm:
2981         (WebSelectionServiceController::hasRelevantSelectionServices):
2982         Address attachment and cell leak.
2983
2984         * WebView/WebFullScreenController.h:
2985         * WebView/WebImmediateActionController.h:
2986         Remove unused instance variables.
2987
2988 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
2989
2990         Enable the <meter> element on iOS
2991         https://bugs.webkit.org/show_bug.cgi?id=161714
2992         rdar://problem/8978410
2993
2994         Reviewed by Tim Horton.
2995
2996         Define ENABLE_METER_ELEMENT unconditionally now.
2997
2998         * Configurations/FeatureDefines.xcconfig:
2999
3000 2016-09-07  Mark Lam  <mark.lam@apple.com>
3001
3002         Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
3003         https://bugs.webkit.org/show_bug.cgi?id=161498
3004
3005         Reviewed by Geoffrey Garen.
3006
3007         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3008         (WebKit::NetscapePluginInstanceProxy::evaluate):
3009         (WebKit::NetscapePluginInstanceProxy::invoke):
3010         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3011         (WebKit::NetscapePluginInstanceProxy::construct):
3012         (WebKit::NetscapePluginInstanceProxy::getProperty):
3013         (WebKit::NetscapePluginInstanceProxy::setProperty):
3014         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3015         (WebKit::NetscapePluginInstanceProxy::hasProperty):
3016         (WebKit::NetscapePluginInstanceProxy::hasMethod):
3017         (WebKit::NetscapePluginInstanceProxy::enumerate):
3018         * WebView/WebView.mm:
3019         (aeDescFromJSValue):
3020
3021 2016-09-07  Youenn Fablet  <youenn@apple.com>
3022
3023         [Streams API] Separate compile flag for ReadableStream and WritableStream
3024         https://bugs.webkit.org/show_bug.cgi?id=161044
3025
3026         Reviewed by Alex Christensen.
3027
3028         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
3029
3030         * Configurations/FeatureDefines.xcconfig:
3031
3032 2016-09-06  Chris Dumez  <cdumez@apple.com>
3033
3034         Add support for input.minLength / textArea.minLength
3035         https://bugs.webkit.org/show_bug.cgi?id=161644
3036
3037         Reviewed by Darin Adler.
3038
3039         Update ObjC bindings to reflect method renaming.
3040
3041         * DOM/DOMHTMLInputElement.mm:
3042         (-[DOMHTMLInputElement maxLength]):
3043         (-[DOMHTMLInputElement setMaxLength:]):
3044         * DOM/DOMHTMLTextAreaElement.mm:
3045         (-[DOMHTMLTextAreaElement maxLength]):
3046         (-[DOMHTMLTextAreaElement setMaxLength:]):
3047
3048 2016-09-06  Dan Bernstein  <mitz@apple.com>
3049
3050         <rdar://problem/8064563> Ugly NSLog in DOMInternal.mm
3051
3052         Rubber-stamped by Anders Carlsson.
3053
3054         * DOM/DOMInternal.mm:
3055         (-[WebScriptObject _initializeScriptDOMNodeImp]): Removed useless call to NSLog.
3056
3057 2016-09-06  Ryan Haddad  <ryanhaddad@apple.com>
3058
3059         Unreviewed, rolling out r205407.
3060
3061         Not the correct way to implement this functionality
3062
3063         Reverted changeset:
3064
3065         "Consult with the FrameLoaderClient about whether or not
3066         content extensions should be enabled when loading this URL."
3067         https://bugs.webkit.org/show_bug.cgi?id=161441
3068         http://trac.webkit.org/changeset/205407
3069
3070 2016-09-05  Darin Adler  <darin@apple.com>
3071
3072         More bindings improvements, particularly things not needed for JavaScript bindings
3073         https://bugs.webkit.org/show_bug.cgi?id=161572
3074
3075         Reviewed by Sam Weinig.
3076
3077         * DOM/DOMDOMImplementation.mm:
3078         (-[DOMImplementation hasFeature:version:]): Call SVGTests::hasFeatureForLegacyBindings
3079         instead of DOMImplementation::hasFeature. Also removed JSMainThreadNullState
3080         since this does not do anything that can invoke JavaScript.
3081
3082         * DOM/DOMDocument.mm:
3083         (-[DOMDocument defaultCharset]): Call defaultCharsetForLegacyBindings. Also removed
3084         JSMainThreadNullState.
3085
3086         * DOM/DOMDocumentType.mm:
3087         (-[DOMDocumentType entities]): Changed to simply return nil; same behavior as before,
3088         but with no dependency on WebCore. Also removed JSMainThreadNullState.
3089         (-[DOMDocumentType notations]): Ditto.
3090         (-[DOMDocumentType internalSubset]): Ditto, except empty string rather than nil.
3091
3092         * DOM/DOMNode.mm:
3093         (-[DOMNode isSupported:version:]): Call SVGTests::hasFeatureForLegacyBindings
3094         instead of Node::isSupportedForBindings. Also removed JSMainThreadNullState.
3095
3096 2016-09-04  Joseph Pecoraro  <pecoraro@apple.com>
3097
3098         Remove unnecessary RetainPtr.
3099
3100         Review comments on earlier change.
3101
3102         * WebView/WebImmediateActionController.mm:
3103         (-[WebImmediateActionController _defaultAnimationController]):
3104
3105 2016-09-03  Darin Adler  <darin@apple.com>
3106
3107         Streamline DOMImplementation, and move it to our new DOM exception system
3108         https://bugs.webkit.org/show_bug.cgi?id=161295
3109
3110         Reviewed by Ryosuke Niwa.
3111
3112         * DOM/DOMDOMImplementation.mm:
3113         (unwrap): Added. Use this instead of the IMPL macro.
3114         (-[DOMImplementation dealloc]): Updated to use unwrap.
3115         (-[DOMImplementation hasFeature:version:]): Ditto.
3116         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated to work with
3117         ExceptionOr.
3118         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
3119         (-[DOMImplementation createCSSStyleSheet:media:]): Removed exception logic since
3120         this function can no longer raise an exception.
3121         (-[DOMImplementation createHTMLDocument:]): Updated to use unwrap.
3122         (-[DOMImplementation hasFeature::]): Changed to call the non-deprecated version
3123         rather than duplicating its implementation. Also moved into the category as defined
3124         in the header.
3125         (-[DOMImplementation createDocumentType:::]): Ditto.
3126         (-[DOMImplementation createDocument:::]): Ditto.
3127         (-[DOMImplementation createCSSStyleSheet::]): Ditto.
3128
3129         * DOM/DOMDocument.mm: Removed unneeded include of DOMImplementation.h.
3130         (-[DOMDocument setXmlStandalone:]): Updated since setXMLStandalone no longer can
3131         raise an exception.
3132
3133         * WebView/WebFrame.mm:
3134         (-[WebFrame _canProvideDocumentSource]): Updated to use isTextMIMEType in its new
3135         location in MIMETypeRegistry instead of in DOMImplementation.
3136
3137 2016-09-03  Brian Weinstein  <bweinstein@apple.com>
3138
3139         Implement a stub version of FrameLoaderClient::shouldUseContentExtensionsForURL.
3140         https://bugs.webkit.org/show_bug.cgi?id=16144
3141
3142         Reviewed by Darin Adler.
3143
3144         * WebCoreSupport/WebFrameLoaderClient.h:
3145
3146 2016-09-02  Beth Dakin  <bdakin@apple.com>
3147
3148         Need to updateEditorState if an element change edit-ability without changing 
3149         selection
3150         https://bugs.webkit.org/show_bug.cgi?id=161546
3151         -and corresponding-
3152         rdar://problem/27806012
3153
3154         Reviewed by Ryosuke Niwa.
3155
3156         Every time WebEditorClient::respondToChangedSelection is called, we now save 
3157         whether the last state was contentEditable. That way in 
3158         updateEditorStateAfterLayoutIfNeeded() we can assess whether or not edit-ability 
3159         has changed. 
3160
3161         * WebCoreSupport/WebEditorClient.h:
3162         * WebCoreSupport/WebEditorClient.mm:
3163         (WebEditorClient::respondToChangedSelection):
3164         (WebEditorClient:: updateEditorStateAfterLayoutIfEditabilityChanged):
3165
3166 2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
3167
3168         [Mac] RetainPtr misuse, AnimationController leaks
3169         https://bugs.webkit.org/show_bug.cgi?id=161552
3170
3171         Reviewed by Tim Horton.
3172
3173         * WebView/WebImmediateActionController.mm:
3174         (-[WebImmediateActionController _defaultAnimationController]):
3175
3176 2016-07-08  Jer Noble  <jer.noble@apple.com>
3177
3178         Refactor WebPlaybackSessionModelMediaElement to be client based.
3179         https://bugs.webkit.org/show_bug.cgi?id=159580
3180
3181         Reviewed by Eric Carlson.
3182
3183         No longer necessary to tell the models and interfaces about each other.
3184
3185         * WebView/WebView.mm:
3186         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3187         (-[WebView _clearPlaybackControlsManager]):
3188
3189 2016-09-01  Dan Bernstein  <mitz@apple.com>
3190
3191         Build fix.
3192
3193         * Configurations/FeatureDefines.xcconfig:
3194
3195 2016-09-01  Myles C. Maxfield  <mmaxfield@apple.com>
3196
3197         Clean up TextRun-related code
3198         https://bugs.webkit.org/show_bug.cgi?id=161473
3199
3200         Reviewed by Simon Fraser.
3201
3202         Remove unused #includes.
3203
3204         * WebCoreSupport/WebDragClient.mm:
3205         * WebView/WebView.mm:
3206
3207 2016-08-31  Keith Rollin  <krollin@apple.com>
3208
3209         WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
3210         https://bugs.webkit.org/show_bug.cgi?id=160969
3211         <rdar://problem/26068734>
3212
3213         Reviewed by Simon Fraser.
3214
3215         Enable subsystem- and channel-related data and functions when using
3216         RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
3217         and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
3218
3219         * Misc/WebKitLogging.h:
3220         * Misc/WebKitLogging.m:
3221         * WebView/WebView.mm:
3222         (-[WebView _commonInitializationWithFrameName:groupName:]):
3223
3224 2016-08-31  Brady Eidson  <beidson@apple.com>
3225
3226         WK2 Gamepad provider on iOS.
3227         https://bugs.webkit.org/show_bug.cgi?id=161412
3228
3229         Reviewed by Tim Horton.
3230
3231         * Configurations/FeatureDefines.xcconfig:
3232
3233         * WebView/WebView.mm:
3234         (WebKitInitializeGamepadProviderIfNecessary):
3235
3236 2016-08-30  Mark Lam  <mark.lam@apple.com>
3237
3238         Introduce the ThrowScope and force every throw site to instantiate a ThrowScope.
3239         https://bugs.webkit.org/show_bug.cgi?id=161171
3240
3241         Reviewed by Filip Pizlo and Geoffrey Garen.
3242
3243         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3244         (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
3245         * Plugins/Hosted/ProxyInstance.mm:
3246         (WebKit::ProxyInstance::invokeMethod):
3247
3248 2016-08-28  Andreas Kling  <akling@apple.com>
3249
3250         document.title setter can't throw.
3251         <https://webkit.org/b/161302>
3252
3253         Reviewed by Antti Koivisto.
3254
3255         * DOM/DOMDocument.mm:
3256         (-[DOMDocument setTitle:]):
3257
3258 2016-08-28  Andreas Kling  <akling@apple.com>
3259
3260         Clean up some .text attribute setters that don't throw.
3261         <https://webkit.org/b/161292>
3262
3263         Reviewed by Darin Adler.
3264
3265         * DOM/DOMHTMLTitleElement.mm:
3266         (-[DOMHTMLTitleElement setText:]):
3267
3268 2016-08-26  Sam Weinig  <sam@webkit.org>
3269
3270         Remove support for ENABLE_LEGACY_WEB_AUDIO
3271         https://bugs.webkit.org/show_bug.cgi?id=161262
3272
3273         Reviewed by Anders Carlsson.
3274
3275         * Configurations/FeatureDefines.xcconfig:
3276         Remove ENABLE_LEGACY_WEB_AUDIO
3277
3278 2016-08-25  Anders Carlsson  <andersca@apple.com>
3279
3280         Re-export DOMException NSStrings after r204717
3281         https://bugs.webkit.org/show_bug.cgi?id=161200
3282         <rdar://problem/27959937>
3283
3284         Reviewed by Alex Christensen.
3285
3286         * DOM/ExceptionHandlers.mm:
3287         (raiseDOMException):
3288         * WebKit.exp:
3289
3290 2016-08-22  Darin Adler  <darin@apple.com>
3291
3292         Move Objective-C DOM bindings from WebCore to legacy WebKit
3293         https://bugs.webkit.org/show_bug.cgi?id=160654
3294
3295         Reviewed by Alex Christensen.
3296
3297         * DOM: Added lots of files to the directory.
3298         The files are just as they were in bindings/objc except that the paths of includes
3299         have been updated as needed, and the code no longer is defined inside the WebCore
3300         namespace, requring changes to various functions and their call sites. Also removed
3301         all the WEBCORE_EXPORT since we export differently here in legacy WebKit.
3302
3303         * DOM/DOMInternal.h: Moved. Replaced createDOMWrapper with initializeDOMWrapperHooks.
3304         * DOM/DOMUtility.mm: Moved.
3305         (createDOMWrapper): Simplified to use toWrapped and not do unneeded namespace tricks.
3306         (disconnectWindowWrapper): Added.
3307         (initializeDOMWrapperHooks): Added.
3308
3309         * MigrateHeaders.make: Removed all the internal headers since they are now just
3310         normal project headers. Added the "DOM" directory to the VPATH. Some of the headers
3311         from WebCore are still being migrated, so we can't remove WebCorePrivateHeaders yet.
3312
3313         * WebCoreSupport/WebEditorClient.h: Updated to return RefPtr<DocumentFragment>.
3314
3315         * WebCoreSupport/WebEditorClient.mm:
3316         (WebEditorClient::documentFragmentFromDelegate): Use RefPtr.
3317
3318         * WebKit.exp: Added exports for all the classes that used to use WEBCORE_EXPORT to
3319         be exported from WebCore.
3320
3321         * WebView/WebFrame.mm:
3322         (-[WebFrame innerLineHeight:]): Moved code from WebCore::Frame::innerLineHeight here.
3323         No longer depend on whether this node happens to be in this frame. Also removed
3324         unneeded null check since a node's document can't be null.
3325
3326         * WebView/WebHTMLView.mm: Removed uneeded include of ExceptionHandlers.h, which
3327         is now here in WebKitLegacy instead of WebCore. But no need to include it at all.
3328
3329         * WebView/WebView.mm:
3330         (-[WebView _commonInitializationWithFrameName:groupName:]): Call
3331         initializeDOMWrapperHooks so WebScriptObject can create DOM binding wrappers when
3332         making a script object for a DOM object, rather than just a generic script object.
3333         (+[WebView enableWebThread]): Added a call to WebCoreObjCDeallocOnWebThread here for
3334         DOMObject along with the other classes. This was done in WebCore before, but DOMObject is now
3335         defined here in legacy WebKit.
3336         (-[WebView styleAtSelectionStart]): Moved code from WebCore::Frame::styleAtSelectionStart here.
3337         Replaced incorrect code that called "new PropertySetCSSStyleDeclaration" with a misleading comment
3338         about reference counting; that code was leaking all the style declarations. Instead use
3339         MutableStyleProperties::ensureCSSStyleDeclaration, which is designed for this purpose.
3340
3341 2016-08-22  Youenn Fablet  <youenn@apple.com>
3342
3343         [Fetch API] Activate fetch api runtime flag by default
3344         https://bugs.webkit.org/show_bug.cgi?id=160452
3345
3346         Reviewed by Alex Christensen.
3347
3348         * WebView/WebPreferences.mm:
3349         (+[WebPreferences initialize]):
3350
3351 2016-08-21  Alex Christensen  <achristensen@webkit.org>
3352
3353         Use Document& instead of Document* when getting cookies
3354         https://bugs.webkit.org/show_bug.cgi?id=161011
3355
3356         Reviewed by Darin Adler.
3357
3358         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3359         (WebKit::NetscapePluginInstanceProxy::getCookies):
3360         (WebKit::NetscapePluginInstanceProxy::setCookies):
3361         * Plugins/WebNetscapePluginView.mm:
3362         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3363         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
3364
3365 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
3366
3367         Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
3368         https://bugs.webkit.org/show_bug.cgi?id=160923
3369
3370         Reviewed by Tim Horton.
3371
3372         * WebCoreSupport/WebFrameLoaderClient.h:
3373         * WebCoreSupport/WebFrameLoaderClient.mm:
3374         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
3375         (WebFrameLoaderClient::dispatchDidLayout): Deleted.
3376
3377 2016-08-18  Daniel Bates  <dabates@apple.com>
3378
3379         Ld warns of non-existent PrivateFrameworks directory when building WebKit with the public iOS 9.3 SDK
3380         https://bugs.webkit.org/show_bug.cgi?id=160979
3381
3382         Rubber-stamped by Simon Fraser.
3383
3384         Only add the SDK PrivateFrameworks directory to the FRAMEWORK_SEARCH_PATH when building for
3385         iOS Simulator, building with an iOS SDK that does not support text-based stubs, or building
3386         an Apple-internal build.
3387
3388         * Configurations/WebKitLegacy.xcconfig:
3389
3390 2016-08-18  Anders Carlsson  <andersca@apple.com>
3391
3392         Move an NPAPI-only function from WebCore to WebKit
3393         https://bugs.webkit.org/show_bug.cgi?id=160967
3394
3395         Reviewed by Sam Weinig.
3396
3397         * Plugins/WebNetscapePluginView.h:
3398         * Plugins/WebNetscapePluginView.mm:
3399         (-[WebNetscapePluginView getVariable:value:]):
3400         (-[WebNetscapePluginView _destroyPlugin]):
3401
3402 2016-08-18  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
3403
3404         [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
3405         https://bugs.webkit.org/show_bug.cgi?id=156096
3406
3407         Reviewed by Dean Jackson.
3408
3409         Adds:
3410         - Setup interface for enabling runtime flag for Web animations through preferences.
3411
3412         * WebView/WebPreferenceKeysPrivate.h:
3413         * WebView/WebPreferences.mm:
3414         (+[WebPreferences initialize]):
3415         (-[WebPreferences webAnimationsEnabled]):
3416         (-[WebPreferences setWebAnimationsEnabled:]):
3417         * WebView/WebPreferencesPrivate.h:
3418         * WebView/WebView.mm:
3419         (-[WebView _preferencesChanged:]):
3420
3421 2016-08-17  Anders Carlsson  <andersca@apple.com>
3422
3423         Remove a couple of unused WKSI function pointers
3424         https://bugs.webkit.org/show_bug.cgi?id=160946
3425
3426         Reviewed by Dan Bernstein.
3427
3428         * WebCoreSupport/WebSystemInterface.mm:
3429         (InitWebCoreSystemInterface): Deleted.
3430
3431 2016-08-16  Daniel Bates  <dabates@apple.com>
3432
3433         WKSI static library should be named by major iOS revision, not individual updates
3434         https://bugs.webkit.org/show_bug.cgi?id=160727
3435         <rdar://problem/22274848>
3436
3437         Reviewed by Alexey Proskuryakov.
3438
3439         * Configurations/Base.xcconfig:
3440         * Configurations/DebugRelease.xcconfig:
3441         * Configurations/WebKitLegacy.xcconfig:
3442
3443 2016-08-16  Darin Adler  <darin@apple.com>
3444
3445         [Cocoa] Remove dependency on Objective-C bindings in WebKit2 editing code
3446         https://bugs.webkit.org/show_bug.cgi?id=160891
3447
3448         Reviewed by Anders Carlsson.
3449
3450         * WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
3451
3452         * WebCoreSupport/WebEditorClient.mm:
3453         (attributesForAttributedStringConversion): Replaced the
3454         createExcludedElementsForAttributedStringConversion function with this one.
3455         No good reason to keep the array around instead of the dictionary.
3456         (_WebCreateFragment): Renamed from documentFragmentFromAttributedString.
3457         This is now a global function exported so it can be called by WebCore with
3458         a different way of returning its value.
3459
3460         * WebKit.exp: Added _WebCreateFragment.
3461
3462         * WebView/WebHTMLView.mm:
3463         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3464         Removed long-ago-obsolete workaround for Radar bug 5052369.
3465
3466 2016-08-15  Anders Carlsson  <andersca@apple.com>
3467
3468         Another build fix.
3469
3470         * WebKit.exp:
3471
3472 2016-08-15  Anders Carlsson  <andersca@apple.com>
3473
3474         Fix build.
3475
3476         * Configurations/WebKitLegacy.xcconfig:
3477         * WebKit.mac.exp:
3478
3479 2016-08-15  Anders Carlsson  <andersca@apple.com>
3480
3481         Remove OldWebAssertions.c
3482         https://bugs.webkit.org/show_bug.cgi?id=160862
3483
3484         Reviewed by Dan Bernstein.
3485
3486         These functions were used by an old version of iWeb. The latest version of iWeb no longer uses them.
3487
3488         * Misc/OldWebAssertions.c: Removed.
3489         (WebReportAssertionFailure): Deleted.
3490         (WebReportError): Deleted.
3491
3492 2016-08-15  Anders Carlsson  <andersca@apple.com>
3493
3494         Remove WebKeyGenerator
3495         https://bugs.webkit.org/show_bug.cgi?id=160854
3496
3497         Reviewed by Dan Bernstein.
3498
3499         This SPI class is no longer used by Safari.
3500
3501         * WebCoreSupport/WebKeyGenerator.h: Removed.
3502         * WebCoreSupport/WebKeyGenerator.mm: Removed.
3503         (+[WebKeyGenerator sharedGenerator]): Deleted.
3504         (toWebCertificateParseResult): Deleted.
3505         (-[WebKeyGenerator addCertificatesToKeychainFromData:]): Deleted.
3506         * WebView/WebFrameView.mm:
3507
3508 2016-08-15  Daniel Bates  <dabates@apple.com>
3509
3510         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
3511         private frameworks and libraries
3512         https://bugs.webkit.org/show_bug.cgi?id=155931
3513         <rdar://problem/25807989>
3514
3515         Reviewed by Dan Bernstein.
3516
3517         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
3518         where X is the major version of the active iOS SDK.
3519
3520         * Configurations/WebKitLegacy.xcconfig:
3521
3522 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
3523
3524         Add a setting and preferences to enable visual viewport mode
3525         https://bugs.webkit.org/show_bug.cgi?id=160843
3526
3527         Reviewed by Sam Weinig.
3528
3529         Hook up the visualViewportEnabled setting for WebKit1.
3530
3531         * WebView/WebPreferenceKeysPrivate.h:
3532         * WebView/WebPreferences.mm:
3533         (+[WebPreferences initialize]):
3534         (-[WebPreferences visualViewportEnabled]):
3535         (-[WebPreferences setVisualViewportEnabled:]):
3536         * WebView/WebPreferencesPrivate.h:
3537
3538 2016-08-15  Joseph Pecoraro  <pecoraro@apple.com>
3539
3540         Remove unused includes of wtf headers
3541         https://bugs.webkit.org/show_bug.cgi?id=160839
3542
3543         Reviewed by Alex Christensen.
3544
3545         * History/BinaryPropertyList.cpp:
3546         * History/WebBackForwardList.mm:
3547         * History/WebHistoryItemInternal.h:
3548         * Misc/WebNSFileManagerExtras.mm:
3549         * Plugins/Hosted/NetscapePluginHostProxy.h:
3550         * WebCoreSupport/WebPlatformStrategies.mm:
3551         * WebCoreSupport/WebSelectionServiceController.mm:
3552         * WebCoreSupport/WebUserMediaClient.h:
3553
3554 2016-08-12  Anders Carlsson  <andersca@apple.com>
3555
3556         Move the plug-in and WebGL blacklist code to WebCore
3557         https://bugs.webkit.org/show_bug.cgi?id=160831
3558
3559         Reviewed by Sam Weinig.
3560
3561         Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.
3562
3563         * WebCoreSupport/WebFrameLoaderClient.mm:
3564         (shouldBlockPlugin):
3565         (WebFrameLoaderClient::createPlugin):
3566         (WebFrameLoaderClient::createJavaAppletWidget):
3567         (shouldBlockWebGL):
3568         (WebFrameLoaderClient::webGLPolicyForURL):
3569         (WebFrameLoaderClient::resolveWebGLPolicyForURL):
3570
3571 2016-08-14  Daniel Bates  <dabates@apple.com>
3572
3573         Fix compiler errors when building iOS WebKit using the iOS 10 beta SDK
3574         https://bugs.webkit.org/show_bug.cgi?id=160725
3575
3576         Reviewed by Sam Weinig.
3577
3578         OSAtomicCompareAndSwap32() has been deprecated as of the iOS 10 beta SDK. For now,
3579         silence the complier warning.
3580
3581         * WebView/WebView.mm:
3582         (-[WebView _dispatchTileDidDraw:]):
3583
3584 2016-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3585
3586         Remove always true JSC::Debugger::needPauseHandling virtual method
3587         https://bugs.webkit.org/show_bug.cgi?id=160822
3588
3589         Reviewed by Mark Lam.
3590
3591         * WebView/WebScriptDebugger.h:
3592
3593 2016-08-11  Chris Dumez  <cdumez@apple.com>
3594
3595         Regression(r204268): Mail crashes when trying to compose an email
3596         https://bugs.webkit.org/show_bug.cgi?id=160775
3597
3598         Reviewed by Anders Carlsson.
3599
3600         Properly initialize PageConfiguration.pluginInfoProvider in
3601         [WebView initSimpleHTMLDocumentWithStyle] to avoid a null
3602         dereference in Mail when trying to compose an email.
3603
3604         * WebView/WebView.mm:
3605         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3606
3607 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3608
3609         Sort the feature flags in the FEATURE_DEFINES lines
3610         https://bugs.webkit.org/show_bug.cgi?id=160742
3611
3612         Reviewed by Anders Carlsson.
3613
3614         * Configurations/FeatureDefines.xcconfig:
3615
3616 2016-08-09  Alex Christensen  <achristensen@webkit.org>
3617
3618         Move NetworkStorageSession management to WebCore
3619         https://bugs.webkit.org/show_bug.cgi?id=160173
3620
3621         Reviewed by Brady Eidson.
3622
3623         * WebCoreSupport/WebFrameNetworkingContext.mm:
3624         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3625         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3626         * WebCoreSupport/WebPlatformStrategies.mm:
3627         * WebView/WebView.mm:
3628
3629 2016-08-09  Anders Carlsson  <andersca@apple.com>
3630
3631         Instantiate WebKit plug-ins at layout time, instead of at style resolution time
3632         https://bugs.webkit.org/show_bug.cgi?id=160715
3633
3634         Reviewed by Tim Horton.
3635
3636         * WebCoreSupport/WebFrameLoaderClient.mm:
3637         (WebFrameLoaderClient::objectContentType):
3638
3639 2016-08-09  George Ruan  <gruan@apple.com>
3640
3641         Implement functionality of media capture on iOS
3642         https://bugs.webkit.org/show_bug.cgi?id=158945
3643         <rdar://problem/26893343>
3644
3645         Reviewed by Tim Horton.
3646
3647         * Configurations/FeatureDefines.xcconfig: Enable Media Capture feature
3648         for iOS.
3649
3650 2016-08-09  Anders Carlsson  <andersca@apple.com>
3651
3652         Get rid of PluginStrategy
3653         https://bugs.webkit.org/show_bug.cgi?id=160696
3654
3655         Reviewed by Dan Bernstein.
3656
3657         * WebCoreSupport/WebPlatformStrategies.h:
3658         * WebCoreSupport/WebPlatformStrategies.mm:
3659         (WebPlatformStrategies::createPluginStrategy): Deleted.
3660         * WebCoreSupport/WebPluginInfoProvider.h:
3661         * WebCoreSupport/WebPluginInfoProvider.mm:
3662         (WebPluginInfoProvider::setPluginLoadClientPolicy): Deleted.
3663         (WebPluginInfoProvider::clearPluginClientPolicies): Deleted.
3664
3665 2016-08-09  Anders Carlsson  <andersca@apple.com>
3666
3667         Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
3668         https://bugs.webkit.org/show_bug.cgi?id=160694
3669
3670         Reviewed by Dan Bernstein.
3671
3672         * WebCoreSupport/WebPlatformStrategies.h:
3673         * WebCoreSupport/WebPlatformStrategies.mm:
3674         (WebPlatformStrategies::createPluginStrategy):
3675         (WebPlatformStrategies::refreshPlugins): Deleted.
3676         (WebPlatformStrategies::getPluginInfo): Deleted.
3677         (WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
3678         (WebPlatformStrategies::setPluginLoadClientPolicy): Deleted.
3679         (WebPlatformStrategies::clearPluginClientPolicies): Deleted.
3680         * WebCoreSupport/WebPluginInfoProvider.mm:
3681         (WebPluginInfoProvider::refreshPlugins):
3682         (WebPluginInfoProvider::getPluginInfo):
3683         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3684
3685 2016-08-08  Anders Carlsson  <andersca@apple.com>
3686
3687         Add a new PluginInfoProvider class, to replace PluginStrategy
3688         https://bugs.webkit.org/show_bug.cgi?id=160670
3689
3690         Reviewed by Sam Weinig.
3691
3692         Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
3693
3694         * WebCoreSupport/WebPluginInfoProvider.h: Added.
3695         * WebCoreSupport/WebPluginInfoProvider.mm: Added.
3696         (WebPluginInfoProvider::singleton):
3697         (WebPluginInfoProvider::WebPluginInfoProvider):
3698         (WebPluginInfoProvider::~WebPluginInfoProvider):
3699         (WebPluginInfoProvider::refreshPlugins):
3700         (WebPluginInfoProvider::getPluginInfo):
3701         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3702         (WebPluginInfoProvider::setPluginLoadClientPolicy):
3703         (WebPluginInfoProvider::clearPluginClientPolicies):
3704         * WebView/WebView.mm:
3705         (-[WebView _commonInitializationWithFrameName:groupName:]):
3706
3707 2016-08-02  Enrica Casucci  <enrica@apple.com>
3708
3709         Allow building with content filtering disabled.
3710         https://bugs.webkit.org/show_bug.cgi?id=160454
3711
3712         Reviewed by Simon Fraser.
3713
3714         * Configurations/FeatureDefines.xcconfig:
3715         * WebCoreSupport/WebFrameLoaderClient.h:
3716         * WebCoreSupport/WebFrameLoaderClient.mm:
3717         (WebFrameLoaderClient::blockedByContentFilterError):
3718
3719 2016-08-02  Anders Carlsson  <andersca@apple.com>
3720
3721         Remove more unused/uninstalled Objective-C DOM bindings
3722         https://bugs.webkit.org/show_bug.cgi?id=160464
3723
3724         Reviewed by Darin Adler.
3725
3726         Stop installing unused headers.
3727
3728         * MigrateHeaders.make:
3729
3730 2016-08-01  Anders Carlsson  <andersca@apple.com>
3731
3732         Bring back a file - it needs to be copied by WebCore.
3733
3734         * MigrateHeaders.make:
3735
3736 2016-08-01  Anders Carlsson  <andersca@apple.com>
3737
3738         Remove another file.
3739
3740         * MigrateHeaders.make:
3741
3742 2016-08-01  Anders Carlsson  <andersca@apple.com>
3743
3744         Remove a file.
3745
3746         * MigrateHeaders.make:
3747
3748 2016-08-01  Anders Carlsson  <andersca@apple.com>
3749
3750         Freeze all the DOMHTML* Objective-C bindings
3751         https://bugs.webkit.org/show_bug.cgi?id=160424
3752
3753         Reviewed by Tim Horton.
3754
3755         Don't migrate DOMHTMLEmbedElementPrivate.h - it was just an empty header.
3756
3757         * MigrateHeaders.make:
3758
3759 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
3760
3761         Remove deprecated SPI for video inline / fullscreen controls
3762         https://bugs.webkit.org/show_bug.cgi?id=160318
3763
3764         Reviewed by Tim Horton.
3765
3766         * WebView/WebPreferenceKeysPrivate.h:
3767         * WebView/WebPreferences.mm:
3768         (+[WebPreferences initialize]): Deleted.
3769         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]): Deleted.
3770         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]): Deleted.
3771         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]): Deleted.
3772         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]): Deleted.
3773         * WebView/WebPreferencesPrivate.h:
3774         * WebView/WebView.mm:
3775         (-[WebView _preferencesChanged:]): Deleted.
3776
3777 2016-07-28  Anders Carlsson  <andersca@apple.com>
3778
3779         Move a Mail.app workaround closer to where it's actually needed
3780         https://bugs.webkit.org/show_bug.cgi?id=160317
3781
3782         Reviewed by Tim Horton.
3783
3784         * WebCoreSupport/WebFrameLoaderClient.mm:
3785         (WebFrameLoaderClient::dispatchWillSendRequest):
3786         * WebView/WebFrame.mm:
3787         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Deleted.
3788
3789 2016-07-28  Anders Carlsson  <andersca@apple.com>
3790
3791         Use a RetainPtr in WebFrameLoaderClient::assignIdentifierToInitialRequest
3792         https://bugs.webkit.org/show_bug.cgi?id=160315
3793
3794         Reviewed by Tim Horton.
3795
3796         * WebCoreSupport/WebFrameLoaderClient.mm:
3797         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3798
3799 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
3800
3801         Fix the Windows debug build.
3802         
3803         WebResourceLoadScheduler's logging was a holdover from it being in WebCore,
3804         and prior to r203749 WebKit was actually using a WebCore log channel.
3805         
3806         For some reason this doesn't build on Windows debug, so just remove
3807         this logging for now.
3808
3809         * Misc/WebKitLogging.h:
3810
3811 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
3812
3813         [iPhone] Playing a video on tudou.com plays only sound, no video
3814         https://bugs.webkit.org/show_bug.cgi?id=160178
3815         <rdar://problem/27535468>
3816
3817         Reviewed by Eric Carlson and Dan Bernstein.
3818
3819         * WebView/WebPreferenceKeysPrivate.h:
3820         * WebView/WebPreferences.mm:
3821         (+[WebPreferences initialize]):
3822         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]):
3823         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]):
3824         * WebView/WebPreferencesPrivate.h:
3825         * WebView/WebView.mm:
3826         (-[WebView _preferencesChanged:]):
3827
3828 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
3829
3830         Allow LOG macros to be used outside the namespace, and other logging cleanup
3831         https://bugs.webkit.org/show_bug.cgi?id=160216
3832
3833         Reviewed by Anders Carlsson.
3834
3835         Fix some issues with the LOG macros.
3836         
3837         First, they were not usable outside the WebKit namespace in WebKit2 code. Fix by moving
3838         its log channels outside of the namespace (they are protected by a unique prefix anyway).
3839         
3840         Second, allow LOG_WITH_STREAM to be used in WebKit2 by moving that and a helper macro
3841         into LogMacros.h, which is exported from WebCore as a private header.
3842         
3843         Third, split the Logging.h header into two. Logging.h remains for framework-internal
3844         log channels and log macros. Add LogInitialization.h which is external, and used to
3845         initialize the channels.
3846         
3847         Finally unify "initializeLogChannels" and "initializeLoggingChannels" terminology everywhere.
3848
3849         * Misc/WebKitLogging.h:
3850         * Misc/WebKitLogging.m:
3851         * WebView/WebView.mm:
3852         (-[WebView _commonInitializationWithFrameName:groupName:]):
3853
3854 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3855
3856         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
3857         https://bugs.webkit.org/show_bug.cgi?id=160066
3858
3859         Reviewed by Dean Jackson.
3860
3861         * WebView/WebPreferenceKeysPrivate.h:
3862         * WebView/WebPreferences.mm:
3863         (+[WebPreferences initialize]): Deleted.
3864         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]): Deleted.
3865         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): Deleted.
3866         * WebView/WebPreferencesPrivate.h:
3867         * WebView/WebView.mm:
3868         (-[WebView _preferencesChanged:]): Deleted.
3869
3870 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3871
3872         [iPhone] Playing a video on tudou.com plays only sound, no video
3873         https://bugs.webkit.org/show_bug.cgi?id=159967
3874         <rdar://problem/26964090>
3875
3876         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
3877
3878         Add the two preferences to WebPreferences.
3879
3880         * WebView/WebPreferenceKeysPrivate.h:
3881         * WebView/WebPreferences.mm:
3882         (+[WebPreferences initialize]):
3883         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
3884         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
3885         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
3886         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
3887         * WebView/WebPreferencesPrivate.h:
3888         * WebView/WebView.mm:
3889         (-[WebView _preferencesChanged:]):
3890
3891 2016-07-20  Commit Queue  <commit-queue@webkit.org>
3892
3893         Unreviewed, rolling out r203471.
3894         https://bugs.webkit.org/show_bug.cgi?id=160003
3895
3896         many iOS-simulator tests are failing (Requested by litherum on
3897         #webkit).
3898
3899         Reverted changeset:
3900
3901         "[iPhone] Playing a video on tudou.com plays only sound, no
3902         video"
3903         https://bugs.webkit.org/show_bug.cgi?id=159967
3904         http://trac.webkit.org/changeset/203471
3905
3906 2016-07-20  Myles C. Maxfield  <mmaxfield@apple.com>
3907
3908         [iPhone] Playing a video on tudou.com plays only sound, no video
3909         https://bugs.webkit.org/show_bug.cgi?id=159967
3910         <rdar://problem/26964090>
3911
3912         Reviewed by Jon Lee.
3913
3914         Add the two preferences to WebPreferences.
3915
3916         * WebView/WebPreferenceKeysPrivate.h:
3917         * WebView/WebPreferences.mm:
3918         (+[WebPreferences initialize]):
3919         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
3920         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
3921         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
3922         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
3923         * WebView/WebPreferencesPrivate.h:
3924         * WebView/WebView.mm:
3925         (-[WebView _preferencesChanged:]):
3926
3927 2016-07-19  Andy Estes  <aestes@apple.com>
3928
3929         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
3930         https://bugs.webkit.org/show_bug.cgi?id=159956
3931
3932         Reviewed by Dan Bernstein.
3933
3934         * Misc/WebKitErrors.h: Moved definition of WebKitErrorFrameLoadBlockedByContentFilter from here ...
3935         * Misc/WebKitErrorsPrivate.h: to here.
3936
3937 2016-07-18  Anders Carlsson  <andersca@apple.com>
3938
3939         WebKit nightly fails to build on macOS Sierra
3940         https://bugs.webkit.org/show_bug.cgi?id=159902
3941         rdar://problem/27365672
3942
3943         Reviewed by Tim Horton.
3944
3945         * icu/unicode/ucurr.h: Added.
3946         Add ucurr.h from ICU.
3947
3948 2016-07-17  Sam Weinig  <sam@webkit.org>
3949
3950         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3951         <rdar://problem/26554137>
3952         https://bugs.webkit.org/show_bug.cgi?id=159856
3953
3954         Reviewed by Dan Bernstein.
3955
3956         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3957         (WebKit::NetscapePluginInstanceProxy::evaluate):
3958         * Plugins/WebNetscapePluginView.mm:
3959         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
3960         Update for new UserGestureIndicator interface.
3961
3962 2016-07-16  Ryosuke Niwa  <rniwa@webkit.org>
3963
3964         Rename fastGetAttribute to attributeWithoutSynchronization
3965         https://bugs.webkit.org/show_bug.cgi?id=159852
3966
3967         Reviewed by Darin Adler.
3968
3969         * WebView/WebHTMLRepresentation.mm:
3970         (matchLabelsAgainstElement):
3971
3972 2016-07-15  Chris Dumez  <cdumez@apple.com>
3973
3974         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
3975         https://bugs.webkit.org/show_bug.cgi?id=159793
3976
3977         Reviewed by Ryosuke Niwa.
3978
3979         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.
3980
3981         * WebView/WebHTMLRepresentation.mm:
3982         (matchLabelsAgainstElement):
3983
3984 2016-07-14  Alex Christensen  <achristensen@webkit.org>
3985
3986         Use SocketProvider to create SocketStreamHandles
3987         https://bugs.webkit.org/show_bug.cgi?id=159774
3988
3989         Reviewed by Brady Eidson.
3990
3991         * Misc/WebSocketProvider.h: Removed.
3992         * Misc/WebSocketProvider.mm: Removed.
3993         * WebView/WebView.mm:
3994         (-[WebView _commonInitializationWithFrameName:groupName:]):
3995         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3996
3997 2016-07-14  Csaba Osztrogonác  <ossy@webkit.org>
3998
3999         Fix the !ENABLE(WEB_SOCKETS) build after r202930
4000         https://bugs.webkit.org/show_bug.cgi?id=159768
4001
4002         Reviewed by Alex Christensen.
4003
4004         * Misc/WebSocketProvider.h:
4005
4006 2016-07-13  Beth Dakin  <bdakin@apple.com>
4007
4008         Add more candidate tests
4009         https://bugs.webkit.org/show_bug.cgi?id=159730
4010
4011         Reviewed by Tim Horton.
4012
4013         Move shouldRequestCandidates from WebViewInternal to WebViewPrivate so that 
4014         we can use it in tests. 
4015         * WebView/WebViewInternal.h:
4016         * WebView/WebViewPrivate.h:
4017
4018 2016-07-13  Enrica Casucci  <enrica@apple.com>
4019
4020         Update supported platforms in xcconfig files to match the sdk names.
4021         https://bugs.webkit.org/show_bug.cgi?id=159728
4022
4023         Reviewed by Tim Horton.
4024
4025         * Configurations/Base.xcconfig:
4026
4027 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4028
4029         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
4030         https://bugs.webkit.org/show_bug.cgi?id=159671
4031
4032         Reviewed by Csaba Osztrogonác.
4033
4034         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
4035         https://bugs.webkit.org/show_bug.cgi?id=89235
4036
4037         So this guard can be removed in build scripts.
4038
4039         * Configurations/FeatureDefines.xcconfig:
4040
4041 2016-07-11  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4042
4043         Purge PassRefPtr in platform/efl and platform/mac 
4044         https://bugs.webkit.org/show_bug.cgi?id=159548
4045
4046         Reviewed by Alex Christensen.
4047
4048         Remove all use of PassRefPtr and clean up unnecessary tabs and spaces.
4049
4050         * WebCoreSupport/WebPlatformStrategies.h:
4051         * WebCoreSupport/WebPlatformStrategies.mm:
4052         (WebPlatformStrategies::setBufferForType):
4053
4054 2016-07-11  Enrica Casucci  <enrica@apple.com>
4055
4056         Add synthetic click origin to WKNavigationAction.
4057         https://bugs.webkit.org/show_bug.cgi?id=159584
4058         rdar://problem/25610422
4059
4060         Reviewed by Tim Horton.
4061
4062         * WebView/WebFrame.mm:
4063         (-[WebFrame _dragSourceEndedAt:operation:]):
4064         * WebView/WebPDFView.mm:
4065         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4066
4067 2016-07-11  Anders Carlsson  <andersca@apple.com>
4068
4069         Able to open multiple payment sheets in Safari at the same time
4070         https://bugs.webkit.org/show_bug.cgi?id=159637
4071         rdar://problem/26411339
4072
4073         Reviewed by Beth Dakin.
4074
4075         Update for WebCore changes.
4076
4077         * WebCoreSupport/WebPaymentCoordinatorClient.h:
4078         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
4079         (WebPaymentCoordinatorClient::showPaymentUI):
4080
4081 2016-07-08  Andy Estes  <aestes@apple.com>
4082
4083         [Content Filtering] Load blocked pages more like other error pages are loaded
4084         https://bugs.webkit.org/show_bug.cgi?id=159485
4085         <rdar://problem/26014076>
4086
4087         Reviewed by Brady Eidson.
4088
4089         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
4090         * Misc/WebKitErrors.m:
4091         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
4092         * WebCoreSupport/WebFrameLoaderClient.h:
4093         * WebCoreSupport/WebFrameLoaderClient.mm:
4094         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
4095
4096 2016-07-08  Commit Queue  <commit-queue@webkit.org>
4097
4098         Unreviewed, rolling out r202944.
4099         https://bugs.webkit.org/show_bug.cgi?id=159570
4100
4101         caused some tests to crash under GuardMalloc (Requested by
4102         estes on #webkit).
4103
4104         Reverted changeset:
4105
4106         "[Content Filtering] Load blocked pages more like other error
4107         pages are loaded"
4108         https://bugs.webkit.org/show_bug.cgi?id=159485
4109         http://trac.webkit.org/changeset/202944
4110
4111 2016-07-08  Jiewen Tan  <jiewen_tan@apple.com>
4112
4113         Define DYLD_MACOSX_VERSION_10_12
4114         https://bugs.webkit.org/show_bug.cgi?id=159525
4115         <rdar://problem/26250296>
4116
4117         Reviewed by Brent Fulgham.
4118
4119         * WebView/WebView.mm:
4120         (shouldConvertInvalidURLsToBlank):
4121         Replace 0x000A0C00 with DYLD_MACOSX_VERSION_10_12.
4122
4123 2016-07-07  Beth Dakin  <bdakin@apple.com>
4124
4125         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
4126         https://bugs.webkit.org/show_bug.cgi?id=159532
4127         -and corresponding-
4128         rdar://problem/27177179
4129
4130         Reviewed by Tim Horton.
4131
4132         * WebView/WebView.mm:
4133         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
4134         (-[WebView forceRequestCandidatesForTesting]):
4135         (-[WebView shouldRequestCandidates]):
4136         * WebView/WebViewPrivate.h:
4137
4138 2016-07-07  Andy Estes  <aestes@apple.com>
4139
4140         [Content Filtering] Load blocked pages more like other error pages are loaded
4141         https://bugs.webkit.org/show_bug.cgi?id=159485
4142         <rdar://problem/26014076>
4143
4144         Reviewed by Brady Eidson.
4145
4146         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
4147         * Misc/WebKitErrors.m:
4148         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
4149         * WebCoreSupport/WebFrameLoaderClient.h:
4150         * WebCoreSupport/WebFrameLoaderClient.mm:
4151         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
4152
4153 2016-07-07  Alex Christensen  <achristensen@webkit.org>
4154
4155         Use SocketProvider to create WebSocketChannels
4156         https://bugs.webkit.org/show_bug.cgi?id=158776
4157
4158         Reviewed by Brent Fulgham.
4159
4160         * Misc/WebSocketProvider.mm: Copied from Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp.
4161         (WebSocketProvider::createWebSocketChannel):
4162         (WebCore::ThreadableWebSocketChannel::create): Deleted.
4163         * Misc/WebSocketProvider.h:
4164         * WebView/WebView.mm:
4165         (-[WebView _commonInitializationWithFrameName:groupName:]):
4166         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
4167
4168 2016-07-06  Benjamin Poulain  <bpoulain@apple.com>
4169
4170         [JSC] Unify how we throw TypeError from C++
4171         https://bugs.webkit.org/show_bug.cgi?id=159500
4172
4173         Reviewed by Saam Barati.
4174
4175         * Plugins/Hosted/ProxyInstance.mm:
4176         (WebKit::ProxyInstance::invokeMethod):
4177
4178 2016-07-01  Youenn Fablet  <youennf@gmail.com>
4179
4180         Add a runtime flag for DOM iterators
4181         https://bugs.webkit.org/show_bug.cgi?id=159300
4182
4183         Reviewed by Alex Christensen.
4184
4185         * WebView/WebPreferenceKeysPrivate.h:
4186         * WebView/WebPreferences.mm:
4187         (-[WebPreferences DOMIteratorEnabled]):
4188         (-[WebPreferences setDOMIteratorEnabled:]):
4189         * WebView/WebPreferencesPrivate.h: