cc6016266dc8313360033637f1d94868ebbb57e5
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-04-22  Darin Adler  <darin@apple.com>
2
3         Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2
4         https://bugs.webkit.org/show_bug.cgi?id=143943
5
6         Reviewed by Anders Carlsson.
7
8         * Plugins/Hosted/ProxyInstance.h: Removed unneeded include.
9         * Plugins/WebBaseNetscapePluginView.h: Ditto.
10
11         * Plugins/WebNetscapePluginEventHandler.h: Use unique_ptr instead of
12         PassOwnPtr for the create function. Also tweaked formatting and removed
13         unneeded forward declaration of CGRect.
14         * Plugins/WebNetscapePluginEventHandler.mm:
15         (WebNetscapePluginEventHandler::create): Changed to use unique_ptr and
16         make_unique.
17
18         * Plugins/WebNetscapePluginView.h: Use unique_ptr instead of OwnPtr for
19         the _eventHandler field.
20         * Plugins/WebNetscapePluginView.mm:
21         (-[WebNetscapePluginView destroyPlugin]): Changed code to work with unique_ptr.
22
23         * WebCoreSupport/WebUserMediaClient.mm: Removed unneeded include.
24
25         * WebView/WebDeviceOrientationProviderMock.mm: Changed to use make_unique.
26         * WebView/WebDeviceOrientationProviderMockInternal.h: Changed to use unique_ptr.
27
28         * WebView/WebFrame.mm:
29         (vectorForDictationPhrasesArray): Changed to return Vector<Vector<String>> and
30         not a PassOwnPtr. Also rewrote to be much simpler, although there is still a
31         pre-existing problem here where this could put empty vectors into the result,
32         and I'm pretty sure the client never expects any of the Vector<String> to be empty.
33         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
34         Rewrote logic to involve WebCore types a bit less; old code was round tripping
35         things through WebCore::URL for no obvious reason.
36
37         * WebView/WebFrameInternal.h: Changed vectorForDictationPhrasesArray to return
38         a Vector<Vector<String>> and not a PassOwnPtr.
39
40         * WebView/WebFullScreenController.h: Removed unneeded include.
41
42         * WebView/WebViewData.h: Changed m_alternativeTextUIController to be a
43         m_alternativeTextUIController.
44         * WebView/WebViewData.mm:
45         (-[WebViewPrivate init]): Use make_unique to initialize m_alternativeTextUIController.
46
47 2015-04-22  Brent Fulgham  <bfulgham@apple.com>
48
49         VisibleSelection should only accept Range by reference
50         https://bugs.webkit.org/show_bug.cgi?id=144047
51
52         Reviewed by Tim Horton.
53
54         Update all uses of VisibleSelection to pass a Range reference instead
55         of a Range pointer.
56
57         * WebCoreSupport/WebContextMenuClient.mm:
58         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
59         * WebView/WebFrame.mm:
60         (-[WebFrame _selectNSRange:]):
61
62 2015-04-22  Eric Carlson  <eric.carlson@apple.com>
63
64         [Mac] Device picker menu is positioned incorrectly in WK1
65         https://bugs.webkit.org/show_bug.cgi?id=144049
66         <rdar://problem/20493101>
67
68         Reviewed by Dean Jackson.
69
70         * WebView/WebView.mm:
71         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]): Mouse location is already in
72             window coordinates so don't call convertRect:toView:nil.
73
74 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
75
76         Extend action menus to support PDF
77         https://bugs.webkit.org/show_bug.cgi?id=143895
78         <rdar://problem/19003333>
79
80         Reviewed by Tim Horton.
81
82         Prevent a crash when someone attempts to invoke an action menu on a PDF hosted
83         in a WK1 view.
84
85         * WebView/WebActionMenuController.mm:
86         (-[WebActionMenuController performHitTestAtPoint:]): Handle WebPDFView as well as
87         the WebHTMLView case.
88         * WebView/WebDocument.h:
89         * WebView/WebHTMLView.h:
90         * WebView/WebHTMLView.mm:
91         (-[WebHTMLView _frame]):
92         * WebView/WebHTMLViewInternal.h:
93         * WebView/WebPDFView.h:
94         * WebView/WebPDFView.mm:
95         (-[WebPDFView _frame]): Added.
96
97 2015-04-22  Eric Carlson  <eric.carlson@apple.com>
98
99         Unreviewed post-review clean up after r183096.
100
101         * WebView/WebMediaPlaybackTargetPicker.h:
102
103 2015-04-21  Eric Carlson  <eric.carlson@apple.com>
104
105         [Mac] Use one playback target for all web processes
106         https://bugs.webkit.org/show_bug.cgi?id=144009
107
108         Reviewed by Tim Horton.
109
110         Update to use WebMediaSessionManager for playback target management.
111
112         * WebCoreSupport/WebChromeClient.h:
113         * WebCoreSupport/WebChromeClient.mm:
114         (WebChromeClient::addPlaybackTargetPickerClient):
115         (WebChromeClient::removePlaybackTargetPickerClient):
116         (WebChromeClient::showPlaybackTargetPicker):
117         (WebChromeClient::playbackTargetPickerClientStateDidChange):
118         (WebChromeClient::startingMonitoringPlaybackTargets): Deleted.
119         (WebChromeClient::stopMonitoringPlaybackTargets): Deleted.
120         * WebView/WebMediaPlaybackTargetPicker.h:
121         * WebView/WebMediaPlaybackTargetPicker.mm:
122         (WebMediaPlaybackTargetPicker::addPlaybackTargetPickerClient):
123         (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
124         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
125         (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
126         (WebMediaPlaybackTargetPicker::setPlaybackTarget):
127         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange):
128         (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget):
129         (WebMediaPlaybackTargetPicker::invalidate):
130         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): Deleted.
131         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): Deleted.
132         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Deleted.
133         (WebMediaPlaybackTargetPicker::targetPicker): Deleted.
134         * WebView/WebView.mm:
135         (-[WebView _addPlaybackTargetPickerClient:]):
136         (-[WebView _removePlaybackTargetPickerClient:]):
137         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
138         (-[WebView _playbackTargetPickerClientStateDidChange:state:]):
139         (-[WebView _showPlaybackTargetPicker:hasVideo:]): Deleted.
140         (-[WebView _startingMonitoringPlaybackTargets]): Deleted.
141         (-[WebView _stopMonitoringPlaybackTargets]): Deleted.
142         * WebView/WebViewInternal.h:
143
144 2015-04-20  Alexey Proskuryakov  <ap@apple.com>
145
146         Disable mixed content blocking for existing WebKit1 clients
147         https://bugs.webkit.org/show_bug.cgi?id=143955
148         rdar://problem/20177186
149
150         Reviewed by Oliver Hunt.
151
152         * Misc/WebKitVersionChecks.h:
153         * WebView/WebView.mm:
154         (shouldAllowInsecureContent):
155         (-[WebView _preferencesChanged:]):
156
157 2015-04-20  Tim Horton  <timothy_horton@apple.com>
158
159         Implement immediate action support for tel: and mailto: URLs
160         https://bugs.webkit.org/show_bug.cgi?id=143916
161         <rdar://problem/19721711>
162
163         Reviewed by Darin Adler.
164
165         * WebView/WebImmediateActionController.mm:
166         (-[WebImmediateActionController _defaultAnimationController]):
167         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
168         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
169         (-[WebImmediateActionController _menuItemForDataDetectedText]): Deleted.
170         * WebView/WebUIDelegatePrivate.h:
171         Add _animationControllerForDataDetectedLink and use it when
172         building immediate actions for tel: and mailto: links.
173
174 2015-04-17  Daniel Bates  <dabates@apple.com>
175
176         REGRESSION: SVG does not support link dragging
177         https://bugs.webkit.org/show_bug.cgi?id=141597
178
179         Reviewed by Darin Adler.
180
181         Write -[WebElementDictionary _isLiveLink] in terms of WebCore::isDraggableLink().
182
183         * Misc/WebElementDictionary.mm:
184         (-[WebElementDictionary _isLiveLink]):
185
186 2015-04-16  Sam Weinig  <sam@webkit.org>
187
188         Expose JavaScriptMarkupEnabled preference for WebKit1
189         <rdar://problem/19939450>
190         https://bugs.webkit.org/show_bug.cgi?id=143855
191
192         Reviewed by Dan Bernstein.
193
194         * WebView/WebPreferenceKeysPrivate.h:
195         Add new key, WebKitJavaScriptMarkupEnabledPreferenceKey
196
197         * WebView/WebPreferences.mm:
198         (+[WebPreferences initialize]):
199         Initialize WebKitJavaScriptMarkupEnabledPreferenceKey to YES.
200
201         (-[WebPreferences isJavaScriptMarkupEnabled]):
202         (-[WebPreferences setJavaScriptMarkupEnabled:]):
203         Implement getter/setter.
204
205         * WebView/WebPreferencesPrivate.h:
206         Add new property, javaScriptMarkupEnabled.
207
208         * WebView/WebView.mm:
209         (-[WebView _preferencesChanged:]):
210         Map the new preference to WebCore's scriptMarkupEnabled setting.
211
212 2015-04-15  Brent Fulgham  <bfulgham@apple.com>
213
214         [Mac] Disable "Save to Downloads" option for local files
215         https://bugs.webkit.org/show_bug.cgi?id=143794
216
217         Reviewed by Tim Horton.
218
219         Disable the Image and Media download options if the download
220         target is a local file. We can only download web resources;
221         anything else is actually a no-op.
222
223         * WebView/WebActionMenuController.mm:
224         (-[WebActionMenuController _defaultMenuItemsForImage]):
225         (-[WebActionMenuController _defaultMenuItemsForVideo]):
226
227 2015-04-15  Alex Christensen  <achristensen@webkit.org>
228
229         Progress towards CMake on Mac.
230         https://bugs.webkit.org/show_bug.cgi?id=143785
231
232         Reviewed by Csaba Osztrogonác.
233
234         * WebView/WebPDFDocumentExtras.mm:
235         * WebView/WebPDFView.mm:
236
237 2015-04-13  Jer Noble  <jer.noble@apple.com>
238
239         [Fullscreen] ChromeClient::exitVideoFullscreen() should take a pointer to a HTMLVideoElement.
240         https://bugs.webkit.org/show_bug.cgi?id=143674
241
242         Reviewed by Darin Adler.
243
244         * WebCoreSupport/WebChromeClient.h:
245         * WebCoreSupport/WebChromeClient.mm:
246         (WebChromeClient::enterVideoFullscreenForVideoElement): Takes a reference.
247         (WebChromeClient::exitVideoFullscreenForVideoElement): Renamed from exitVideoFullscreen().
248         (WebChromeClient::exitVideoFullscreen): Deleted.
249
250 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
251
252         Re-enable custom dilation for antialiased fonts
253         https://bugs.webkit.org/show_bug.cgi?id=143738
254
255         Reviewed by Tim Horton.
256         
257         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
258         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
259         a private WebKit pref. This pref defaults to YES, enabling the feature by default
260         in WK1 as we do for WK2.
261
262         * WebView/WebPreferenceKeysPrivate.h:
263         * WebView/WebPreferences.mm:
264         (+[WebPreferences initialize]):
265         (-[WebPreferences setAntialiasedFontDilationEnabled:]):
266         (-[WebPreferences antialiasedFontDilationEnabled]):
267         * WebView/WebPreferencesPrivate.h:
268         * WebView/WebView.mm:
269         (-[WebView _preferencesChanged:]):
270
271 2015-04-13  Brady Eidson  <beidson@apple.com>
272
273         Share sheets from Share menus appear outside the browser window.
274         <rdar://problem/20455592> and https://bugs.webkit.org/show_bug.cgi?id=143620
275
276         Reviewed by Darin Adler.
277
278         Refactor existing Sharing Service Picker code to also be used for the Share menu NSMenuItem.
279
280         * Misc/WebSharingServicePickerController.h:
281         (WebSharingServicePickerClient::webView):
282         * Misc/WebSharingServicePickerController.mm:
283         (WebSharingServicePickerClient::WebSharingServicePickerClient):
284         (WebSharingServicePickerClient::sharingServicePickerWillBeDestroyed):
285         (WebSharingServicePickerClient::pageForSharingServicePicker):
286         (WebSharingServicePickerClient::windowForSharingServicePicker):
287         (WebSharingServicePickerClient::screenRectForCurrentSharingServicePickerItem):
288         (WebSharingServicePickerClient::imageForCurrentSharingServicePickerItem):
289         (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]):
290         (-[WebSharingServicePickerController initWithSharingServicePicker:client:]):
291         (-[WebSharingServicePickerController sharingService:didShareItems:]):
292
293         * WebCoreSupport/WebContextMenuClient.h:
294         (WebContextMenuClient::webView): Deleted.
295         * WebCoreSupport/WebContextMenuClient.mm:
296         (WebContextMenuClient::WebContextMenuClient):
297         (WebContextMenuClient::pageForSharingServicePicker): Deleted.
298         (WebContextMenuClient::windowForSharingServicePicker): Deleted.
299
300         * WebCoreSupport/WebSelectionServiceController.h:
301         * WebCoreSupport/WebSelectionServiceController.mm:
302         (WebSelectionServiceController::WebSelectionServiceController):
303         (WebSelectionServiceController::handleSelectionServiceClick):
304         (WebSelectionServiceController::pageForSharingServicePicker): Deleted.
305         (WebSelectionServiceController::windowForSharingServicePicker): Deleted.
306         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem): Deleted.
307         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem): Deleted.
308
309         * WebView/WebHTMLView.mm:
310         (-[WebHTMLView menuForEvent:]):
311         * WebView/WebViewData.h:
312
313 2015-04-13  Beth Dakin  <bdakin@apple.com>
314
315         Add force property to MouseEvents
316         https://bugs.webkit.org/show_bug.cgi?id=143569
317         -and corresponding-
318         rdar://problem/20472954
319
320         Reviewed by Darin Adler.
321
322         PlatformMouseEvent and MouseEvent now take force parameters.
323         * WebView/WebFrame.mm:
324         (-[WebFrame _dragSourceEndedAt:operation:]):
325         * WebView/WebPDFView.mm:
326         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
327
328 2015-04-12  Darin Adler  <darin@apple.com>
329
330         [Cocoa] Localizable strings are inconsistent and need to be regenerated
331         https://bugs.webkit.org/show_bug.cgi?id=143661
332         rdar://problem/19634388
333
334         Reviewed by Dan Bernstein.
335
336         * Misc/WebLocalizableStrings.mm:
337         (LoadWebLocalizedStringsTimerCallback): Moved the comment, useful for programmers but
338         not for localization, into a C++ source code comment, and made the localizer comment
339         consistent with the place this localizable string is used for actual localization.
340         * WebCoreSupport/WebEditorClient.mm:
341         (undoNameForEditAction): Changed the localizer comments for Delete and Dictation
342         to match the ones in WebKit2; no need to specify that these are iOS only, and if we do
343         want to specify that, we should not be using the term PLATFORM(IOS) since there is no
344         reason for us to expect localizers to understand that terminology. Also added a comment
345         about the fact that we have two copies of all the localizable strings.
346
347 2015-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
348
349         [ES6] Enable Symbol in web pages
350         https://bugs.webkit.org/show_bug.cgi?id=143375
351
352         Reviewed by Ryosuke Niwa.
353
354         * WebView/WebPreferencesPrivate.h:
355
356 2015-04-08  Sam Weinig  <sam@webkit.org>
357
358         Allow LaunchServices to handle URLs on link navigations
359         <rdar://problem/19446826>
360         https://bugs.webkit.org/show_bug.cgi?id=143544
361
362         Reviewed by Anders Carlsson.
363
364         * Configurations/WebKitLegacy.xcconfig:
365         Link MobileCoreServices.
366
367         * WebCoreSupport/WebFrameLoaderClient.h:
368         * WebCoreSupport/WebFrameLoaderClient.mm:
369         (shouldTryAppLink):
370         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
371         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
372         (WebFrameLoaderClient::setUpPolicyListener):
373         Only let LaunchServices have a crack at the URL if the navigation is:
374             1) a main frame navigation
375             2) a result of a user gesture
376
377 2015-04-10  Alexey Proskuryakov  <ap@apple.com>
378
379         Build fix.
380
381         * Misc/WebNSURLExtras.mm: (-[NSString _webkit_unescapedQueryValue]): Ignore a deprecation.
382
383 2015-04-10  Eric Carlson  <eric.carlson@apple.com>
384
385         [Mac] Refactor MediaPlaybackTarget
386         https://bugs.webkit.org/show_bug.cgi?id=143571
387
388         Reviewed by Jer Noble.
389
390         * WebView/WebMediaPlaybackTargetPicker.h:
391         * WebView/WebMediaPlaybackTargetPicker.mm:
392         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Take a Ref<MediaPlaybackTarget>&&.
393
394 2015-04-09  Andy Estes  <aestes@apple.com>
395
396         [Cocoa] Add a HAVE(AVKIT) and use it
397         https://bugs.webkit.org/show_bug.cgi?id=143593
398
399         Reviewed by David Kilzer.
400
401         * WebView/WebPreferences.mm:
402         (+[WebPreferences initialize]): Only set WebKitAVKitEnabled to YES if HAVE(AVKIT).
403         (-[WebPreferences setAVKitEnabled:]): Only set value for WebKitAVKitEnabled if HAVE(AVKIT).
404         * WebView/WebView.mm:
405         (-[WebView _preferencesChanged:]): Only called Settings::setAVKitEnabled() if HAVE(AVKIT).
406
407 2015-04-09  Chris Dumez  <cdumez@apple.com>
408
409         [WK2][iOS] editorState() should not cause a synchronous layout
410         https://bugs.webkit.org/show_bug.cgi?id=142536
411         <rdar://problem/20041506>
412
413         Reviewed by Enrica Casucci.
414
415         Provide implementation for EditorClient::didChangeSelectionAndUpdateLayout().
416
417         * WebCoreSupport/WebEditorClient.h:
418
419 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
420
421         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
422         https://bugs.webkit.org/show_bug.cgi?id=143452
423         <rdar://problem/20437483>
424
425         Reviewed by Tim Horton.
426
427         We were improperly intercepting contextual menu clicks and passing them through
428         the mouseDown handler, rather than processing via NSView's menu handling code.
429
430         * WebView/WebHTMLView.mm:
431         (-[WebHTMLView otherMouseDown:]): Treat context menu events the same as the action
432         menu case, and pass it to AppKit for normal menu processing. 
433
434 2015-04-08  Brady Eidson  <beidson@apple.com>
435
436         Expose the "Share" menu for links, images, and media.
437         <rdar://problem/20435340> and https://bugs.webkit.org/show_bug.cgi?id=143502
438
439         Reviewed by Tim Horton.
440
441         * WebCoreSupport/WebContextMenuClient.h:
442         * WebCoreSupport/WebContextMenuClient.mm:
443         (WebContextMenuClient::shareMenuItem): 
444
445 2015-04-08  Anders Carlsson  <andersca@apple.com>
446
447         Move some ApplicationCache static member functions to ApplicationCacheStorage
448         https://bugs.webkit.org/show_bug.cgi?id=143524
449
450         Reviewed by Antti Koivisto.
451
452         * WebCoreSupport/WebApplicationCache.mm:
453         (+[WebApplicationCache diskUsageForOrigin:]):
454         (+[WebApplicationCache deleteAllApplicationCaches]):
455         (+[WebApplicationCache deleteCacheForOrigin:]):
456
457 2015-04-08  Chris Dumez  <cdumez@apple.com>
458
459         Rename ActiveDOMObject::canSuspend() to canSuspendForPageCache() for clarity
460         https://bugs.webkit.org/show_bug.cgi?id=143513
461
462         Reviewed by Andreas Kling.
463
464         Update ScriptExecutionContext::canSuspendActiveDOMObjects() to
465         canSuspendActiveDOMObjectsForPageCache() as the method was renamed.
466
467         * WebView/WebFrame.mm:
468         (-[WebFrame _cacheabilityDictionary]):
469
470 2015-04-07  Anders Carlsson  <andersca@apple.com>
471
472         Get rid of uses of ApplicationCacheStorage::singleton() from WebKitLegacy
473         https://bugs.webkit.org/show_bug.cgi?id=143504
474
475         Reviewed by Sam Weinig.
476
477         Add a webApplicationCacheStorage() function and use it throughout WebKitLegacy.
478         In the future, webApplicationCacheStorage will return a custom singleton, but for now
479         it just returns ApplicationCacheStorage::singleton().
480
481         * Misc/WebCache.mm:
482         (+[WebCache empty]):
483         * WebCoreSupport/WebApplicationCache.mm:
484         (+[WebApplicationCache maximumSize]):
485         (+[WebApplicationCache setMaximumSize:]):
486         (+[WebApplicationCache defaultOriginQuota]):
487         (+[WebApplicationCache setDefaultOriginQuota:]):
488         (+[WebApplicationCache originsWithCache]):
489         (webApplicationCacheStorage):
490         * WebCoreSupport/WebApplicationCacheInternal.h: Added.
491         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
492         (-[WebApplicationCacheQuotaManager usage]):
493         (-[WebApplicationCacheQuotaManager quota]):
494         (-[WebApplicationCacheQuotaManager setQuota:]):
495         * WebView/WebView.mm:
496         (WebKitInitializeApplicationCachePathIfNecessary):
497
498 2015-04-07  Brady Eidson  <beidson@apple.com>
499
500         ContextMenuItem refactoring
501         https://bugs.webkit.org/show_bug.cgi?id=143485
502
503         Reviewed by Beth Dakin.
504
505         * WebCoreSupport/WebContextMenuClient.mm:
506         (WebContextMenuClient::contextMenuItemSelected):
507
508 2015-04-06  Chris Dumez  <cdumez@apple.com>
509
510         Bing video search result pages are not PageCacheable
511         https://bugs.webkit.org/show_bug.cgi?id=143463
512         <rdar://problem/20440916>
513
514         Reviewed by Alexey Proskuryakov.
515
516         Fix the iOS / WK1 build by using MemoryCache::resourceForRequest()
517         instead of resourceForUrl().
518
519         * Misc/WebCache.mm:
520         (+[WebCache imageForURL:]):
521
522 2015-04-05  Simon Fraser  <simon.fraser@apple.com>
523
524         Remove "go ahead and" from comments
525         https://bugs.webkit.org/show_bug.cgi?id=143421
526
527         Reviewed by Darin Adler, Benjamin Poulain.
528
529         Remove the phrase "go ahead and" from comments where it doesn't add
530         anything (which is almost all of them).
531
532         * WebView/WebDynamicScrollBarsView.mm:
533         (-[WebDynamicScrollBarsView updateScrollers]):
534         * WebView/WebHTMLView.mm:
535         (-[WebHTMLView insertText:]):
536
537 2015-04-02  Brady Eidson  <beidson@apple.com>
538
539         Unreviewed: Reland change after rollout.
540
541         Expose the "Share" menu for text selections on platforms where it's available.
542         rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
543
544         * WebView/WebImmediateActionController.mm: Update for required #include
545
546 2015-04-02  Commit Queue  <commit-queue@webkit.org>
547
548         Unreviewed, rolling out r182293.
549         https://bugs.webkit.org/show_bug.cgi?id=143355
550
551         Broke GTK and EFL builds. (Requested by bfulgham on #webkit).
552
553         Reverted changeset:
554
555         "Expose the "Share" menu for text selections on platforms
556         where it's available."
557         https://bugs.webkit.org/show_bug.cgi?id=143318
558         http://trac.webkit.org/changeset/182293
559
560 2015-04-02  Brady Eidson  <beidson@apple.com>
561
562         Expose the "Share" menu for text selections on platforms where it's available.
563         rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
564
565         Reviewed by Sam Weinig.
566
567         * WebView/WebImmediateActionController.mm: Update for required #include
568
569 2015-04-02  Yusuke Suzuki  <utatane.tea@gmail.com>
570
571         Clean up EnumerationMode to easily extend
572         https://bugs.webkit.org/show_bug.cgi?id=143276
573
574         Reviewed by Geoffrey Garen.
575
576         Use default EnumerationMode().
577
578         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
579         (WebKit::NetscapePluginInstanceProxy::enumerate):
580
581 2015-03-31  Simon Fraser  <simon.fraser@apple.com>
582
583         Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
584         https://bugs.webkit.org/show_bug.cgi?id=143288
585
586         Reviewed by Beth Dakin.
587
588         Remove the wheel event counting that Document does, and passes into the scrolling tree.
589         The ScrollingTree now just uses the non-fast scrollable region to determine when to
590         fast scroll on pages with wheel event handlers.
591
592         * WebCoreSupport/WebChromeClient.h:
593
594 2015-03-31  Timothy Horton  <timothy_horton@apple.com>
595
596         TextIndicator for <span> inside an <a> only highlights the <span>, should highlight the whole <a>
597         https://bugs.webkit.org/show_bug.cgi?id=143287
598         <rdar://problem/20318342>
599
600         Reviewed by Beth Dakin.
601
602         * WebView/WebImmediateActionController.mm:
603         (-[WebImmediateActionController _defaultAnimationController]):
604         Instead of just highlighting the hit element, highlight the whole
605         element that the link URL comes from.
606
607 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
608
609         Clean up Identifier factories to clarify the meaning of StringImpl*
610         https://bugs.webkit.org/show_bug.cgi?id=143146
611
612         Reviewed by Filip Pizlo.
613
614         Just change to Identifier::fromString.
615
616         * Plugins/Hosted/NetscapePluginHostProxy.mm:
617         (identifierFromIdentifierRep):
618         * Plugins/Hosted/ProxyInstance.mm:
619         (WebKit::ProxyInstance::getPropertyNames):
620
621 2015-03-28  Anders Carlsson  <andersca@apple.com>
622
623         Remove an unused SPI method from WebKitLegacy
624         https://bugs.webkit.org/show_bug.cgi?id=143185
625
626         Reviewed by Sam Weinig.
627
628         * WebView/WebDataSource.mm:
629         (-[WebDataSource _transferApplicationCache:]): Deleted.
630         * WebView/WebDataSourcePrivate.h:
631
632 2015-03-26  Alex Christensen  <achristensen@webkit.org>
633
634         Progress towards CMake on Mac.
635         https://bugs.webkit.org/show_bug.cgi?id=143112
636
637         Reviewed by Chris Dumez.
638
639         * WebCoreSupport/WebFrameLoaderClient.h:
640
641 2015-03-26  Ryosuke Niwa  <rniwa@webkit.org>
642
643         Cursor doesn't change back to pointer when leaving Mail
644         https://bugs.webkit.org/show_bug.cgi?id=132038
645
646         Reviewed by Anders Carlsson.
647
648         Fixed the bug by adding a cursor rect and making the primary tracking area update the cursor so that
649         AppKit will reset the cursor as it leaves the WebView.
650
651         We use nil cursor here since we manually update the cursor by calling [NSCursor set].
652
653         * WebView/WebHTMLView.mm:
654         (-[WebHTMLView setDataSource:]): Use NSTrackingCursorUpdate option in creating the primary tracking area.
655
656 2015-03-24  Anders Carlsson  <andersca@apple.com>
657
658         Fix designated initializer violations
659         https://bugs.webkit.org/show_bug.cgi?id=143016
660         rdar://problem/20268858
661
662         Reviewed by Dan Bernstein.
663
664         Move -[WebBackForwardList initWithBackForwardList:] to the implementation instead of a category since
665         nobody calls it outside of WebBackForwardList.mm.
666
667         * History/WebBackForwardList.mm:
668         * History/WebBackForwardListInternal.h:
669
670 2015-03-23  Alexey Proskuryakov  <ap@apple.com>
671
672         REGRESSION (Yosemite): WKView visibility notifications are messed up
673         https://bugs.webkit.org/show_bug.cgi?id=142945
674
675         Reviewed by Tim Horton.
676
677         As these notifications cannot be used by NSView subclasses, create a separate
678         object for observing them.
679
680         * WebView/WebView.mm:
681         (-[WebView _commonInitializationWithFrameName:groupName:]):
682         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
683         (-[WebView addWindowObserversForWindow:]):
684         (-[WebView removeWindowObservers]):
685         (-[WebView viewWillMoveToWindow:]): Make sure that observers are removed even
686         if -[WebView close] is called manually.
687         * WebView/WebViewData.h:
688         * WebView/WebViewData.mm:
689         (-[WebWindowVisibilityObserver initWithView:]):
690         (-[WebWindowVisibilityObserver startObserving:]):
691         (-[WebWindowVisibilityObserver stopObserving:]):
692         (-[WebWindowVisibilityObserver _windowVisibilityChanged:]):
693
694 2015-03-23  Tim Horton  <timothy_horton@apple.com>
695
696         Add a share item to the link action menu
697         https://bugs.webkit.org/show_bug.cgi?id=142961
698         <rdar://problem/19198374>
699
700         Reviewed by Beth Dakin.
701
702         * WebView/WebActionMenuController.mm:
703         (-[WebActionMenuController _defaultMenuItemsForImage]):
704         (-[WebActionMenuController _defaultMenuItemsForVideo]):
705         (-[WebActionMenuController _createActionMenuItemForTag:]):
706         (-[WebActionMenuController _createShareActionMenuItemForTag:withItems:]):
707         Adopt -[NSMenuItem standardShareMenuItemWithItems].
708         All of the null-checking is unnecessary as it's impossible to enter
709         these functions with a null image/etc.
710         Also, remove a duplicate isDownloadableMedia check for the 'save to downloads' item.
711
712         (-[WebActionMenuController _defaultMenuItemsForLink]):
713         * WebView/WebUIDelegatePrivate.h:
714         Add a 'Share' item to the link menu.
715
716 2015-03-22  Alexey Proskuryakov  <ap@apple.com>
717
718         Build fix.
719
720         * WebView/WebView.mm: (-[WebView _showPlaybackTargetPicker:hasVideo:]):
721
722 2015-03-22  Eric Carlson  <eric.carlson@apple.com>
723
724         [Mac] Enable WIRELESS_PLAYBACK_TARGET for WK1
725         https://bugs.webkit.org/show_bug.cgi?id=142940
726
727         Reviewed by Sam Weinig.
728
729         * WebCoreSupport/WebChromeClient.h:
730         * WebCoreSupport/WebChromeClient.mm:
731         (WebChromeClient::showPlaybackTargetPicker): New.
732         (WebChromeClient::startingMonitoringPlaybackTargets): New.
733         (WebChromeClient::stopMonitoringPlaybackTargets): New.
734
735         * WebView/WebView.mm:
736         (-[WebView _close]): Invalidate and free the target picker.
737         (-[WebView _devicePicker]): New.
738         (-[WebView _showPlaybackTargetPicker:hasVideo:]): New.
739         (-[WebView _startingMonitoringPlaybackTargets]): New.
740         (-[WebView _stopMonitoringPlaybackTargets]): New.
741
742         * WebView/WebMediaPlaybackTargetPicker.h:
743         * WebView/WebMediaPlaybackTargetPicker.mm:
744         (WebMediaPlaybackTargetPicker::create): New.
745         (WebMediaPlaybackTargetPicker::WebMediaPlaybackTargetPicker): New.
746         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): New.
747         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): New.
748         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): New.
749         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): New.
750         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange): New.
751         (WebMediaPlaybackTargetPicker::invalidate): New.
752         (WebMediaPlaybackTargetPicker::targetPicker): New.
753
754         * WebView/WebViewData.h:
755         (WebMediaPlaybackTargetPicker::~WebMediaPlaybackTargetPicker):
756         * WebView/WebViewData.mm:
757         * WebView/WebViewInternal.h:
758
759 2015-03-19  Andy Estes  <aestes@apple.com>
760
761         [Content Filtering] Add tests for unblock requests
762         https://bugs.webkit.org/show_bug.cgi?id=142900
763
764         Reviewed by Andreas Kling.
765
766         * WebCoreSupport/WebFrameLoaderClient.mm:
767         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): This now happens in PolicyChecker.
768         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
769         * WebView/WebFrame.mm:
770         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Deleted.
771         * WebView/WebFrameInternal.h: Removed contentFilterUnblockHandler from WebFramePrivate.
772
773 2015-03-19  Enrica Casucci  <enrica@apple.com>
774
775         <attachment> should put URLs on the pasteboard so that Finder can accept drops.
776         https://bugs.webkit.org/show_bug.cgi?id=142801
777         rdar://problem/19982527
778
779         Reviewed by Tim Horton.
780
781         This patch adds all the necessary support to write attachment elements into
782         the pasteboard, including the promised type in WK1.
783
784         * Misc/WebNSPasteboardExtras.mm:
785         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
786         * WebCoreSupport/WebDragClient.h:
787         * WebCoreSupport/WebDragClient.mm:
788         (WebDragClient::declareAndWriteAttachment):
789         * WebView/WebHTMLView.mm:
790         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
791         * WebView/WebUIDelegate.h:
792
793 2015-03-19  Chris Dumez  <cdumez@apple.com>
794
795         Clean up DOMTimer related settings
796         https://bugs.webkit.org/show_bug.cgi?id=142837
797
798         Reviewed by Darin Adler.
799
800         Stop setting the DOMTimers' default minimum interval to 4ms as this
801         is now the default.
802
803         * WebView/WebView.mm:
804         (-[WebView _commonInitializationWithFrameName:groupName:]):
805
806 2015-03-17  Conrad Shultz  <conrad_shultz@apple.com>
807
808         Ignore some deprecation warnings
809         https://bugs.webkit.org/show_bug.cgi?id=142813
810
811         Reviewed by Mark Rowe.
812
813         Fixing the deprecations is tracked by: <rdar://problem/20201450>
814
815         * WebCoreSupport/PopupMenuMac.mm:
816         (PopupMenuMac::populate):
817
818 2015-03-17  Tim Horton  <timothy_horton@apple.com>
819
820         Cannot invoke action menus anymore
821         https://bugs.webkit.org/show_bug.cgi?id=142797
822         <rdar://problem/20032670>
823
824         * WebView/WebHTMLView.mm:
825         (-[WebHTMLView otherMouseDown:]):
826         Need a respondsToSelector check.
827
828 2015-03-17  Tim Horton  <timothy_horton@apple.com>
829
830         Fix the iOS build
831
832         * WebView/WebHTMLView.mm:
833
834 2015-03-17  Tim Horton  <timothy_horton@apple.com>
835
836         Cannot invoke action menus anymore
837         https://bugs.webkit.org/show_bug.cgi?id=142797
838         <rdar://problem/20032670>
839
840         Reviewed by Beth Dakin.
841
842         * WebView/WebHTMLView.mm:
843         (-[WebHTMLView otherMouseDown:]):
844         Don't override otherMouseDown: if the event would make an action menu.
845
846 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
847
848         Enable ES6 classes by default
849         https://bugs.webkit.org/show_bug.cgi?id=142774
850
851         Reviewed by Gavin Barraclough.
852
853         * Configurations/FeatureDefines.xcconfig:
854
855 2015-03-16  Brent Fulgham  <bfulgham@apple.com>
856
857         WebKit1 Clients Are Not Reliably Repainted
858         https://bugs.webkit.org/show_bug.cgi?id=142750
859         <rdar://problem/20042453>
860
861         Reviewed by Simon Fraser.
862
863         Check with the FrameView to see if we are in an immediately paintable state. If we are not,
864         mark the view as dirty once the _immediateScrollToPoint operation is complete so that the
865         region will be painted properly.
866
867         * WebView/WebClipView.mm:
868         (-[WebClipView _immediateScrollToPoint:]): 
869
870 2015-03-16  Conrad Shultz  <conrad_shultz@apple.com>
871
872         Allow clients to selectively disable plug-ins
873         https://bugs.webkit.org/show_bug.cgi?id=142506
874
875         Reviewed by Anders Carlsson.
876
877         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
878         from the page). As part of this:
879
880         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
881            set of plug-ins.
882
883         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
884            down the stack.
885
886         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
887            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
888
889         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
890
891         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
892         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
893
894         * Plugins/WebBasePluginPackage.mm:
895         (-[WebBasePluginPackage getPluginInfoFromPLists]):
896         Set new members in PluginInfo.
897
898         * Plugins/WebNetscapePluginPackage.mm:
899         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
900         Set new members in PluginInfo.
901
902         * WebCoreSupport/WebPlatformStrategies.h:
903         * WebCoreSupport/WebPlatformStrategies.mm:
904         (WebPlatformStrategies::getWebVisiblePluginInfo):
905         Override to wrap getPluginInfo().
906         (WebPlatformStrategies::setPluginLoadClientPolicy):
907         Override to do nothing.
908         (WebPlatformStrategies::clearPluginClientPolicies):
909         Ditto.
910
911         * WebView/WebFrame.mm:
912         (-[WebFrame _canProvideDocumentSource]):
913         Update to reflect function rename.
914
915 2015-03-14  Dean Jackson  <dino@apple.com>
916
917         Feature flag for Animations Level 2
918         https://bugs.webkit.org/show_bug.cgi?id=142699
919         <rdar://problem/20165097>
920
921         Reviewed by Brent Fulgham.
922
923         Add ENABLE_CSS_ANIMATIONS_LEVEL_2 and a runtime flag animationTriggersEnabled.
924
925         * Configurations/FeatureDefines.xcconfig:
926
927 2015-03-13  Commit Queue  <commit-queue@webkit.org>
928
929         Unreviewed, rolling out r181483.
930         https://bugs.webkit.org/show_bug.cgi?id=142688
931
932         Caused use-after-free on many tests (Requested by ap on
933         #webkit).
934
935         Reverted changeset:
936
937         "Allow clients to selectively disable plug-ins"
938         https://bugs.webkit.org/show_bug.cgi?id=142506
939         http://trac.webkit.org/changeset/181483
940
941 2015-03-13  Eric Carlson  <eric.carlson@apple.com>
942
943         [Mac] Enable WIRELESS_PLAYBACK_TARGET
944         https://bugs.webkit.org/show_bug.cgi?id=142635
945
946         Reviewed by Darin Adler.
947
948         * Configurations/FeatureDefines.xcconfig:
949
950 2015-03-10  Conrad Shultz  <conrad_shultz@apple.com>
951
952         Allow clients to selectively disable plug-ins
953         https://bugs.webkit.org/show_bug.cgi?id=142506
954
955         Reviewed by Anders Carlsson.
956
957         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
958         from the page). As part of this:
959
960         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
961            set of plug-ins.
962
963         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
964            down the stack.
965
966         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
967            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
968
969         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
970
971         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
972         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
973
974         * Plugins/WebBasePluginPackage.mm:
975         (-[WebBasePluginPackage getPluginInfoFromPLists]):
976         Set new members in PluginInfo.
977
978         * Plugins/WebNetscapePluginPackage.mm:
979         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
980         Set new members in PluginInfo.
981
982         * WebCoreSupport/WebPlatformStrategies.h:
983         * WebCoreSupport/WebPlatformStrategies.mm:
984         (WebPlatformStrategies::getWebVisiblePluginInfo):
985         Override to wrap getPluginInfo().
986         (WebPlatformStrategies::setPluginLoadClientPolicy):
987         Override to do nothing.
988         (WebPlatformStrategies::clearPluginClientPolicies):
989         Ditto.
990
991         * WebView/WebFrame.mm:
992         (-[WebFrame _canProvideDocumentSource]):
993         Update to reflect function rename.
994
995 2015-03-10  Sam Weinig  <sam@webkit.org>
996
997         Allow adding a button in input elements for auto fill related functionality
998         <rdar://problem/19782066>
999         https://bugs.webkit.org/show_bug.cgi?id=142564
1000
1001         Reviewed by Anders Carlsson.
1002
1003         * DOM/WebDOMOperations.mm:
1004         (-[DOMHTMLInputElement _setAutofilled:]):
1005         Update for consistent spelling of AutoFill.
1006
1007 2015-03-10  Timothy Horton  <timothy_horton@apple.com>
1008
1009         Fix the build
1010
1011         * History/WebHistory.mm:
1012         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1013         * WebCoreSupport/WebFrameLoaderClient.mm:
1014         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1015
1016 2015-03-10  Tim Horton  <timothy_horton@apple.com>
1017
1018         Fix the Mac build with a newer compiler
1019
1020         * Plugins/WebPluginController.mm:
1021         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1022         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1023
1024 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1025
1026         [iOS] Fix build when compiling with dead code stripping disabled
1027         <http://webkit.org/b/142467>
1028
1029         Reviewed by Simon Fraser.
1030
1031         * Configurations/WebKitLegacy.xcconfig:
1032         (EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code
1033         generation and compilation for out-of-process plugin support.
1034         This was never used on iOS.
1035
1036 2015-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
1037
1038         [iOS] SVG fonts are garbled
1039         https://bugs.webkit.org/show_bug.cgi?id=142377
1040
1041         Reviewed by Simon Fraser.
1042
1043         * Configurations/FeatureDefines.xcconfig:
1044
1045 2015-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1046
1047         Hide Promise with runtime flags under Cocoa JSContext API
1048         https://bugs.webkit.org/show_bug.cgi?id=141965
1049
1050         Reviewed by Filip Pizlo.
1051
1052         Add new JSC runtime flag, PromiseDisabled.
1053
1054         * WebView/WebPreferencesPrivate.h:
1055
1056 2015-03-03  Andy Estes  <aestes@apple.com>
1057
1058         [Content Filtering] Separate unblock handling into its own class
1059         https://bugs.webkit.org/show_bug.cgi?id=142251
1060
1061         Reviewed by Andreas Kling.
1062         
1063         Adopted ContentFilterUnblockHandler.
1064
1065         * WebCoreSupport/WebFrameLoaderClient.h:
1066         * WebCoreSupport/WebFrameLoaderClient.mm:
1067         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1068         * WebView/WebFrame.mm:
1069         (-[WebFrame _contentFilterDidHandleNavigationAction:]):
1070         * WebView/WebFrameInternal.h:
1071
1072 2015-03-03  Chris Dumez  <cdumez@apple.com>
1073
1074         Access ApplicationCacheStorage global instance via singleton() static member function
1075         https://bugs.webkit.org/show_bug.cgi?id=142239
1076
1077         Reviewed by Anders Carlsson.
1078
1079         Access ApplicationCacheStorage global instance via singleton() static
1080         member function as per WebKit coding style.
1081
1082 2015-03-02  Jer Noble  <jer.noble@apple.com>
1083
1084         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1085         https://bugs.webkit.org/show_bug.cgi?id=142121
1086
1087         Reviewed by Simon Fraser.
1088
1089         Fullscreening a page with a non-1 scale would result in that scale being applied to the
1090         fullscreen content, breaking fullscreen mode. Set the page scale to 1 when entering
1091         fullscreen and reset it to the original value when exiting fullscreen.
1092
1093         * WebView/WebFullScreenController.h:
1094         * WebView/WebFullScreenController.mm:
1095         (-[WebFullScreenController enterFullScreen:]): Set the page scale to 1.
1096         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Reset the page
1097                 scale to the original value.
1098         * WebView/WebView.mm:
1099         (-[WebView _supportsFullScreenForElement:withKeyboard:]): Drive-by fix. Check the
1100                 WebView's own preferences to see if fullscreen mode is enabled, rather than
1101                 the global object's.
1102
1103 2015-03-01  Chris Dumez  <cdumez@apple.com>
1104
1105         Make NotificationCenter / Notification suspendable
1106         https://bugs.webkit.org/show_bug.cgi?id=142117
1107         <rdar://problem/19923085>
1108
1109         Reviewed by Andreas Kling.
1110
1111         Provide implementation for NotificationClient::hasPendingPermissionRequests().
1112         The implementation is very simplistic. it will only return false if no
1113         request for permission for ever made. This is because there is currently no
1114         easy way to figure out if a permission request is pending or not.
1115
1116         * WebCoreSupport/WebNotificationClient.h:
1117         * WebCoreSupport/WebNotificationClient.mm:
1118         (WebNotificationClient::requestPermission):
1119         (WebNotificationClient::hasPendingPermissionRequests):
1120
1121 2015-02-28  Simon Fraser  <simon.fraser@apple.com>
1122
1123         Viewport units should not dirty style just before we do layout
1124         https://bugs.webkit.org/show_bug.cgi?id=141682
1125
1126         Reviewed by Zalan Bujtas.
1127
1128         * WebView/WebFrameView.mm:
1129         (-[WebFrameView _frameSizeChanged]):
1130
1131 2015-02-26  Chris Dumez  <cdumez@apple.com>
1132
1133         Rename DatabaseManager::manager() to DatabaseManager::singleton()
1134         https://bugs.webkit.org/show_bug.cgi?id=142054
1135
1136         Reviewed by Ryosuke Niwa.
1137
1138         Rename DatabaseManager::manager() to DatabaseManager::singleton() as
1139         per coding style and use WTF::NeverDestroyed.
1140
1141         * Storage/WebDatabaseManager.mm:
1142         (-[WebDatabaseManager init]):
1143         (-[WebDatabaseManager origins]):
1144         (-[WebDatabaseManager databasesWithOrigin:]):
1145         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
1146         (-[WebDatabaseManager deleteAllDatabases]):
1147         (-[WebDatabaseManager deleteOrigin:]):
1148         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1149         * Storage/WebDatabaseQuotaManager.mm:
1150         (-[WebDatabaseQuotaManager usage]):
1151         (-[WebDatabaseQuotaManager quota]):
1152         (-[WebDatabaseQuotaManager setQuota:]):
1153         * WebCoreSupport/WebSecurityOrigin.mm:
1154         (-[WebSecurityOrigin usage]):
1155         (-[WebSecurityOrigin quota]):
1156         (-[WebSecurityOrigin setQuota:]):
1157         * WebView/WebFrame.mm:
1158         (-[WebFrame _cacheabilityDictionary]):
1159         * WebView/WebView.mm:
1160         (-[WebView _preferencesChanged:]):
1161
1162 2015-02-26  Myles C. Maxfield  <mmaxfield@apple.com>
1163
1164         [Mac] [iOS] Parsing support for -apple-trailing-word
1165         https://bugs.webkit.org/show_bug.cgi?id=141939
1166
1167         Reviewed by Andreas Kling.
1168
1169         * Configurations/FeatureDefines.xcconfig:
1170
1171 2015-02-24  Commit Queue  <commit-queue@webkit.org>
1172
1173         Unreviewed, rolling out r180599.
1174         https://bugs.webkit.org/show_bug.cgi?id=141998
1175
1176         Lots of new test failures (Requested by smfr on #webkit).
1177
1178         Reverted changeset:
1179
1180         "Parsing support for -webkit-trailing-word"
1181         https://bugs.webkit.org/show_bug.cgi?id=141939
1182         http://trac.webkit.org/changeset/180599
1183
1184 2015-02-24  Myles C. Maxfield  <mmaxfield@apple.com>
1185
1186         [Mac] [iOS] Parsing support for -apple-trailing-word
1187         https://bugs.webkit.org/show_bug.cgi?id=141939
1188
1189         Reviewed by Andreas Kling.
1190
1191         * Configurations/FeatureDefines.xcconfig:
1192
1193 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1194
1195         REGRESSION(r179429): Can't type comments in Facebook
1196         https://bugs.webkit.org/show_bug.cgi?id=141859
1197
1198         Reviewed by Brent Fulgham.
1199
1200         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1201         Private API, javaScriptExperimentsEnabled is dropped.
1202
1203         * Misc/WebNSDictionaryExtras.h:
1204         * Misc/WebNSDictionaryExtras.m:
1205         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1206         * WebKit.order:
1207         * WebView/WebPreferenceKeysPrivate.h:
1208         * WebView/WebPreferences.mm:
1209         (+[WebPreferences initialize]):
1210         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1211         (-[WebPreferences javaScriptRuntimeFlags]):
1212         (-[WebPreferences setJavaScriptRuntimeFlags:]):
1213         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1214         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1215         * WebView/WebPreferencesPrivate.h:
1216         * WebView/WebView.mm:
1217         (-[WebView _preferencesChanged:]):
1218
1219 2015-02-23  Commit Queue  <commit-queue@webkit.org>
1220
1221         Unreviewed, rolling out r180547 and r180550.
1222         https://bugs.webkit.org/show_bug.cgi?id=141957
1223
1224         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1225
1226         Reverted changesets:
1227
1228         "REGRESSION(r179429): Can't type comments in Facebook"
1229         https://bugs.webkit.org/show_bug.cgi?id=141859
1230         http://trac.webkit.org/changeset/180547
1231
1232         "Constructor returning null should construct an object instead
1233         of null"
1234         https://bugs.webkit.org/show_bug.cgi?id=141640
1235         http://trac.webkit.org/changeset/180550
1236
1237 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1238
1239         Disable font loading events until our implementation gets updated to match the latest spec
1240         https://bugs.webkit.org/show_bug.cgi?id=141938
1241
1242         Reviewed by Andreas Kling.
1243
1244         * Configurations/FeatureDefines.xcconfig:
1245
1246 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1247
1248         REGRESSION(r179429): Can't type comments in Facebook
1249         https://bugs.webkit.org/show_bug.cgi?id=141859
1250
1251         Reviewed by Geoffrey Garen.
1252
1253         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1254         Private API, javaScriptExperimentsEnabled is dropped.
1255
1256         * Misc/WebNSDictionaryExtras.h:
1257         * Misc/WebNSDictionaryExtras.m:
1258         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1259         * WebKit.order:
1260         * WebView/WebPreferenceKeysPrivate.h:
1261         * WebView/WebPreferences.mm:
1262         (+[WebPreferences initialize]):
1263         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1264         (-[WebPreferences javaScriptRuntimeFlags]):
1265         (-[WebPreferences setJavaScriptRuntimeFlags:]):
1266         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1267         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1268         * WebView/WebPreferencesPrivate.h:
1269         * WebView/WebView.mm:
1270         (-[WebView _preferencesChanged:]):
1271
1272 2015-02-20  Eric Carlson  <eric.carlson@apple.com>
1273
1274         [iOS] cleanup AirPlay code
1275         https://bugs.webkit.org/show_bug.cgi?id=141811
1276
1277         Reviewed by Jer Noble.
1278
1279         * Configurations/FeatureDefines.xcconfig: IOS_AIRPLAY -> WIRELESS_PLAYBACK_TARGET.
1280
1281 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
1282
1283         Adopt WebCore::IOSurface in ImageBuffer
1284         https://bugs.webkit.org/show_bug.cgi?id=141751
1285
1286         Reviewed by Simon Fraser.
1287
1288         * WebCoreSupport/WebSystemInterface.mm:
1289         (InitWebCoreSystemInterface):
1290         Remove old WKSI IOSurface-related functions.
1291
1292 2015-02-18  Commit Queue  <commit-queue@webkit.org>
1293
1294         Unreviewed, rolling out r180286.
1295         https://bugs.webkit.org/show_bug.cgi?id=141766
1296
1297         Caused >50 crashed LayoutTests (Requested by jernoble on
1298         #webkit).
1299
1300         Reverted changeset:
1301
1302         "Page::userContentController() should return a reference, not
1303         a pointer"
1304         https://bugs.webkit.org/show_bug.cgi?id=141764
1305         http://trac.webkit.org/changeset/180286
1306
1307 2015-02-18  Brady Eidson  <beidson@apple.com>
1308
1309         Page::userContentController() should return a reference, not a pointer
1310         https://bugs.webkit.org/show_bug.cgi?id=141764
1311
1312         Reviewed by Jer Noble.
1313
1314         * WebView/WebView.mm:
1315         (-[WebView setGroupName:]):
1316
1317 2015-02-18  Chris Dumez  <cdumez@apple.com>
1318
1319         Access FontCache global instance via singleton() static member function
1320         https://bugs.webkit.org/show_bug.cgi?id=141726
1321
1322         Reviewed by Daniel Bates.
1323
1324         Access FontCache global instance via singleton() static member function,
1325         as per coding style.
1326
1327 2015-02-17  Chris Dumez  <cdumez@apple.com>
1328
1329         Access MemoryPressureHandler global instance via a singleton() static member function
1330         https://bugs.webkit.org/show_bug.cgi?id=141691
1331
1332         Reviewed by Andreas Kling.
1333
1334         Access MemoryPressureHandler global instance via a singleton() static
1335         member function.
1336
1337         * WebView/WebView.mm:
1338         (-[WebView _commonInitializationWithFrameName:groupName:]):
1339         (+[WebView registerForMemoryNotifications]):
1340         (+[WebView _isUnderMemoryPressure]):
1341         (+[WebView _clearMemoryPressure]):
1342         (+[WebView _shouldWaitForMemoryClearMessage]):
1343         (WebInstallMemoryPressureHandler):
1344
1345 2015-02-15  Sam Weinig  <sam@webkit.org>
1346
1347         Add experimental <attachment> element support
1348         https://bugs.webkit.org/show_bug.cgi?id=141626
1349
1350         Reviewed by Tim Horton.
1351
1352         * Configurations/FeatureDefines.xcconfig:
1353
1354 2015-02-14  Joseph Pecoraro  <pecoraro@apple.com>
1355
1356         [Mac] Possible DDActionContext leaks, RetainPtr cleanup
1357         https://bugs.webkit.org/show_bug.cgi?id=141613
1358
1359         Reviewed by Tim Horton.
1360
1361         * WebCoreSupport/WebEditorClient.mm:
1362         (WebEditorClient::WebEditorClient):
1363         Avoid unnecessary retain/autorelease by adopting.
1364
1365         * WebView/WebActionMenuController.mm:
1366         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1367         Adopt the allocated object.
1368
1369 2015-02-09  Brian J. Burg  <burg@cs.washington.edu>
1370
1371         Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace
1372         https://bugs.webkit.org/show_bug.cgi?id=141372
1373
1374         Reviewed by Joseph Pecoraro.
1375
1376         * WebCoreSupport/WebInspectorClient.mm:
1377         (-[WebInspectorWindowController destroyInspectorView:]):
1378
1379 2015-02-14  Alexey Proskuryakov  <ap@apple.com>
1380
1381         rel="noreferrer" should make window.opener null
1382         https://bugs.webkit.org/show_bug.cgi?id=141579
1383
1384         Reviewed by Darin Adler.
1385
1386         * WebView/WebPDFView.mm:
1387         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore
1388         function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
1389
1390 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
1391
1392         [Streams API] Implement a barebone ReadableStream interface
1393         https://bugs.webkit.org/show_bug.cgi?id=141045
1394
1395         Reviewed by Benjamin Poulain.
1396
1397         * Configurations/FeatureDefines.xcconfig:
1398
1399 2015-02-03  Enrica Casucci  <enrica@apple.com>
1400
1401         [iOS] Add support for deleteFromInputWithFlags.
1402         https://bugs.webkit.org/show_bug.cgi?id=141216
1403         rdar://problem/19130081
1404
1405         Reviewed by Benjamin Poulain.
1406
1407         Adopts the new method as soon as it is available.
1408         The patch also removes some obsolete code used for staging.
1409
1410         * WebView/WebHTMLView.mm:
1411         (-[WebHTMLView _handleEditingKeyEvent:]):
1412
1413 2015-02-02  Chris Dumez  <cdumez@apple.com>
1414
1415         Access MemoryCache singleton using MemoryCache::singleton()
1416         https://bugs.webkit.org/show_bug.cgi?id=141104
1417
1418         Reviewed by Andreas Kling.
1419
1420         Access MemoryCache singleton using MemoryCache::singleton() static
1421         member function, instead of a free function, as per the recent
1422         coding style discussion on WebKit-dev.
1423
1424 2015-02-01  Chris Dumez  <cdumez@apple.com>
1425
1426         Use more references in HistoryItem
1427         https://bugs.webkit.org/show_bug.cgi?id=141133
1428
1429         Reviewed by Andreas Kling.
1430
1431         Use more references in HistoryItem instead of pointers.
1432
1433 2015-01-31  Sam Weinig  <sam@webkit.org>
1434
1435         Remove even more Mountain Lion support
1436         https://bugs.webkit.org/show_bug.cgi?id=141124
1437
1438         Reviewed by Alexey Proskuryakov.
1439
1440         * Configurations/Base.xcconfig:
1441         * Configurations/DebugRelease.xcconfig:
1442         * Configurations/FeatureDefines.xcconfig:
1443         * Configurations/Version.xcconfig:
1444         * Configurations/WebKitLegacy.xcconfig:
1445
1446 2015-01-30  Eric Carlson  <eric.carlson@apple.com>
1447
1448         Remove MediaPlayerProxy.h
1449         https://bugs.webkit.org/show_bug.cgi?id=141087
1450
1451         Reviewed by Sam Weinig.
1452
1453         * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h.
1454         * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h.
1455
1456 2015-01-30  Chris Dumez  <cdumez@apple.com>
1457
1458         Rename shared() static member functions to singleton() for singleton classes.
1459         https://bugs.webkit.org/show_bug.cgi?id=141088
1460
1461         Reviewed by Ryosuke Niwa and Benjamin Poulain.
1462
1463         Rename shared() static member functions to singleton() for singleton
1464         classes as per the recent coding style change.
1465
1466 2015-01-29  Beth Dakin  <bdakin@apple.com>
1467
1468         Remove more Mountain Lion code from WebKit
1469         https://bugs.webkit.org/show_bug.cgi?id=141050
1470
1471         Reviewed by Anders Carlsson.
1472
1473         * History/WebHistory.mm:
1474         (getDayBoundaries):
1475         * Panels/WebAuthenticationPanel.m:
1476         (-[WebAuthenticationPanel cancel:]):
1477         (-[WebAuthenticationPanel logIn:]):
1478         (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]):
1479         * WebCoreSupport/WebSystemInterface.mm:
1480         (InitWebCoreSystemInterface):
1481         * WebView/WebFrameView.mm:
1482         * WebView/WebPreferences.mm:
1483         (+[WebPreferences initialize]):
1484         (needsScreenFontsEnabledQuirk):
1485         * WebView/WebView.mm:
1486         (+[WebView registerForMemoryNotifications]):
1487         (-[WebView _preferencesChanged:]):
1488         (+[WebView initialize]):
1489         (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
1490         (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
1491         (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):
1492
1493 2015-01-29  Sam Weinig  <sam@webkit.org>
1494
1495         Remove support for screen font substitution
1496         https://bugs.webkit.org/show_bug.cgi?id=141038
1497
1498         Reviewed by Tim Horton.
1499
1500         * Misc/WebKitNSStringExtras.mm:
1501         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1502         (-[NSString _web_widthWithFont:]):
1503         * Misc/WebStringTruncator.mm:
1504         (fontFromNSFont):
1505         Update for new signature of the FontPlatformData constructor, which no longer cares about
1506         whether to use printer fonts.
1507
1508         * WebView/WebPreferenceKeysPrivate.h:
1509         Remove the WebKitScreenFontSubstitutionEnabledKey key.
1510
1511         * WebView/WebPreferences.mm:
1512         (+[WebPreferences initialize]):
1513         Remove support for WebKitScreenFontSubstitutionEnabledKey.
1514
1515         (needsScreenFontsEnabledQuirk): Deleted.
1516         Remove support for the Mountain Lion era 1-Password quirk.
1517
1518         (-[WebPreferences screenFontSubstitutionEnabled]): Deleted.
1519         (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted.
1520         * WebView/WebPreferencesPrivate.h:
1521         * WebView/WebView.mm:
1522         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1523         (-[WebView _preferencesChanged:]):
1524         Remove support for the screen font substitution setting.
1525
1526 2015-01-29  Chris Dumez  <cdumez@apple.com>
1527
1528         Clean up / modernize PageCache class
1529         https://bugs.webkit.org/show_bug.cgi?id=141009
1530
1531         Reviewed by Darin Adler.
1532
1533         Clean up / modernize PageCache class.
1534
1535         * History/WebBackForwardList.mm:
1536         (-[WebBackForwardList pageCacheSize]):
1537         * WebView/WebView.mm:
1538         (-[WebView _loadBackForwardListFromOtherView:]):
1539         (-[WebView goToBackForwardItem:]):
1540         (+[WebView _setCacheModel:]):
1541
1542 2015-01-28  Beth Dakin  <bdakin@apple.com>
1543
1544         Remove Mountain Lion code from WebKit and WebKit2
1545         https://bugs.webkit.org/show_bug.cgi?id=141010
1546
1547         Reviewed by Sam Weinig.
1548
1549         * DOM/WebDOMOperations.mm:
1550         (toNSEventPhase):
1551         * WebView/WebHTMLView.mm:
1552         (isQuickLookEvent):
1553
1554 2015-01-28  Dana Burkart  <dburkart@apple.com>
1555
1556         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1557         https://bugs.webkit.org/show_bug.cgi?id=136765
1558
1559         Reviewed by Alexey Proskuryakov.
1560
1561         * Configurations/Base.xcconfig:
1562         * Configurations/DebugRelease.xcconfig:
1563
1564 2015-01-28  Chris Dumez  <cdumez@apple.com>
1565
1566         Fix typo in markPagesForVistedLinkStyleRecalc()
1567         https://bugs.webkit.org/show_bug.cgi?id=140977
1568
1569         Reviewed by Darin Adler.
1570
1571         * WebCoreSupport/WebVisitedLinkStore.mm:
1572         (WebVisitedLinkStore::removeAllVisitedLinks):
1573         (WebVisitedLinkStore::removeVisitedLink):
1574         (WebVisitedLinkStore::addVisitedLinkHash):
1575
1576 2015-01-28  Chris Dumez  <cdumez@apple.com>
1577
1578         Rename pageCache() to PageCache::shared() and return a reference
1579         https://bugs.webkit.org/show_bug.cgi?id=140983
1580
1581         Reviewed by Andreas Kling.
1582
1583         Rename pageCache() to PageCache::shared() as this is a singleton class
1584         and have it return a reference instead of a pointer.
1585
1586         * History/WebBackForwardList.mm:
1587         (-[WebBackForwardList pageCacheSize]):
1588         * Misc/WebCoreStatistics.mm:
1589         (+[WebCoreStatistics cachedPageCount]):
1590         (+[WebCoreStatistics cachedFrameCount]):
1591         * WebCoreSupport/WebVisitedLinkStore.mm:
1592         (WebVisitedLinkStore::removeAllVisitedLinks):
1593         (WebVisitedLinkStore::removeVisitedLink):
1594         (WebVisitedLinkStore::addVisitedLinkHash):
1595         * WebView/WebView.mm:
1596         (+[WebView _setCacheModel:]):
1597
1598 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1599
1600         More build fixes for newer clang.
1601
1602         Rubber-stamped by Anders Carlsson.
1603
1604         Marked a deprecated accessibility method as such.
1605
1606         * WebView/WebFrame.mm:
1607         (-[WebFrame accessibilityRoot]):
1608
1609 2015-01-27  Beth Dakin  <bdakin@apple.com>
1610
1611         Immediate action gesture recognizer still doesn't work well with IB
1612         https://bugs.webkit.org/show_bug.cgi?id=140967
1613         -and corresponding-
1614         rdar://problem/19621509
1615
1616         Reviewed by Tim Horton.
1617
1618         We should add (or remove) the gesture recognizer in viewDidMoveToWindow because 
1619         initWithFrame it too early and IB might mess with it.
1620         * WebView/WebImmediateActionController.h:
1621         * WebView/WebImmediateActionController.mm:
1622         (-[WebImmediateActionController immediateActionRecognizer]):
1623         * WebView/WebView.mm:
1624         (-[WebView _commonInitializationWithFrameName:groupName:]):
1625         (-[WebView viewDidMoveToWindow]):
1626
1627 2015-01-27  Dan Bernstein  <mitz@apple.com>
1628
1629         Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
1630
1631         Rubber-stamped by Anders Carlsson.
1632
1633         * WebView/WebView.h: Added forward declarations of the protocols.
1634
1635 2015-01-26  Anders Carlsson  <andersca@apple.com>
1636
1637         Make it easy to test enabling formal delegate protocols
1638         https://bugs.webkit.org/show_bug.cgi?id=140892
1639
1640         Reviewed by Dan Bernstein.
1641
1642         Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
1643
1644         * Misc/WebDownload.h:
1645         * WebView/WebFrameLoadDelegate.h:
1646         * WebView/WebPolicyDelegate.h:
1647         * WebView/WebResourceLoadDelegate.h:
1648         * WebView/WebUIDelegate.h:
1649         * WebView/WebView.h:
1650
1651 2015-01-26  Chris Dumez  <cdumez@apple.com>
1652
1653         Rename Document::body() to Document::bodyOrFrameset() for clarity
1654         https://bugs.webkit.org/show_bug.cgi?id=140902
1655
1656         Reviewed by Andreas Kling.
1657
1658         Rename Document::body() to Document::bodyOrFrameset() for clarity. This
1659         method does not necessarily return an HTMLBodyElement, it can also
1660         return a frameset as per the specification:
1661         http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
1662
1663         This method is often misused internally (the caller is only interested
1664         in the <body> element). I will fix these instances in a follow-up patch,
1665         this patch is only renaming mechanically.
1666
1667 2015-01-26  Chris Dumez  <cdumez@apple.com>
1668
1669         First argument to DOM traversal functions should be a reference
1670         https://bugs.webkit.org/show_bug.cgi?id=140895
1671
1672         Reviewed by Antti Koivisto.
1673
1674         First argument to DOM traversal functions should be a reference instead
1675         of a pointer as it is dereferenced without null-check.
1676
1677 2015-01-26  Myles C. Maxfield  <mmaxfield@apple.com>
1678
1679         [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
1680         https://bugs.webkit.org/show_bug.cgi?id=140860
1681
1682         Reviewed by Darin Adler.
1683
1684         The fonts it makes are grotesque. (See what I did there? Typographic
1685         humor is the best humor.)
1686
1687         * Configurations/FeatureDefines.xcconfig:
1688
1689 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
1690
1691         QLPreviewMenuItem popovers don't close when the page scrolls
1692         https://bugs.webkit.org/show_bug.cgi?id=140806
1693         <rdar://problem/19555618>
1694
1695         Reviewed by Beth Dakin.
1696
1697         Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
1698
1699         * WebView/WebHTMLView.mm:
1700         (-[WebHTMLView scrollWheel:scrollWheel:]):
1701         Send scrollWheel along to WebImmediateActionController.
1702
1703         * WebView/WebImmediateActionController.h:
1704         * WebView/WebImmediateActionController.mm:
1705         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
1706         (-[WebImmediateActionController _clearImmediateActionState]):
1707         (-[WebImmediateActionController _defaultAnimationController]):
1708         Keep track of the active QLPreviewMenuItem, and close it upon scroll.
1709
1710 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
1711
1712         Infinite recursion in _clearImmediateActionState
1713         https://bugs.webkit.org/show_bug.cgi?id=140807
1714         <rdar://problem/19571601>
1715
1716         Reviewed by Anders Carlsson.
1717
1718         * WebView/WebImmediateActionController.mm:
1719         (-[WebImmediateActionController _clearImmediateActionState]):
1720         Use this opportunity to bring identical code to WebKit1, to avoid
1721         getting DataDetectors stuck when an immediate action is canceled.
1722
1723 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1724
1725         Add a build flag for ES6 class syntax
1726         https://bugs.webkit.org/show_bug.cgi?id=140760
1727
1728         Reviewed by Michael Saboff.
1729
1730         * Configurations/FeatureDefines.xcconfig:
1731
1732 2015-01-22  Beth Dakin  <bdakin@apple.com>
1733
1734         ibtoold crash below -[WebView close]
1735         https://bugs.webkit.org/show_bug.cgi?id=140782
1736         -and corresponding-
1737         rdar://problem/19558472
1738
1739         Reviewed by Tim Horton.
1740
1741         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
1742         it is because interface builder is messing with our views.
1743         * WebView/WebImmediateActionController.h:
1744         * WebView/WebImmediateActionController.mm:
1745         (-[WebImmediateActionController webViewClosed]):
1746         (-[WebImmediateActionController _cancelImmediateAction]):
1747         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1748         (-[WebImmediateActionController _updateImmediateActionItem]):
1749
1750 2015-01-21  Beth Dakin  <bdakin@apple.com>
1751
1752         Crash in QuickLook preview delegate method
1753         https://bugs.webkit.org/show_bug.cgi?id=140740
1754         -and corresponding-
1755         rdar://problem/19540806
1756
1757         Reviewed by Tim Horton.
1758
1759         Clear out the delegate.
1760         * WebView/WebImmediateActionController.mm:
1761         (-[WebImmediateActionController webViewClosed]):
1762
1763 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
1764
1765         Remove ENABLE(INSPECTOR) ifdef guards
1766         https://bugs.webkit.org/show_bug.cgi?id=140668
1767
1768         Reviewed by Darin Adler.
1769
1770         * Configurations/FeatureDefines.xcconfig:
1771         * WebCoreSupport/WebFrameLoaderClient.mm:
1772         (WebFrameLoaderClient::dispatchWillSendRequest):
1773
1774 2015-01-20  Anders Carlsson  <andersca@apple.com>
1775
1776         Remove USE(GLIB) code from WebKit1
1777         https://bugs.webkit.org/show_bug.cgi?id=140714
1778
1779         Reviewed by Andreas Kling.
1780
1781         * WebView/WebView.mm:
1782         (-[WebView _commonInitializationWithFrameName:groupName:]):
1783         (-[WebView _close]):
1784         (-[WebView _clearGlibLoopObserver]): Deleted.
1785         (glibContextIterationCallback): Deleted.
1786         (-[WebView _scheduleGlibContextIterations]): Deleted.
1787         * WebView/WebViewData.h:
1788         * WebView/WebViewInternal.h:
1789
1790 2015-01-20  David Kilzer  <ddkilzer@apple.com>
1791
1792         Switch to comparing PLATFORM_NAME in terms of macosx
1793         <http://webkit.org/b/139516>
1794
1795         Reviewed by Timothy Hatcher.
1796
1797         * MigrateHeaders.make:
1798         * postprocess-headers.sh:
1799
1800 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1801
1802         [SVG -> OTF Converter] Flip the switch on
1803         https://bugs.webkit.org/show_bug.cgi?id=140592
1804
1805         Reviewed by Antti Koivisto.
1806
1807         * Configurations/FeatureDefines.xcconfig:
1808
1809 2015-01-19  Beth Dakin  <bdakin@apple.com>
1810
1811         Speculative build fix.
1812
1813         * WebView/WebView.mm:
1814         (-[WebView _commonInitializationWithFrameName:groupName:]):
1815
1816 2015-01-19  Beth Dakin  <bdakin@apple.com>
1817
1818         Speculative build fix.
1819
1820         * WebView/WebView.mm:
1821         (-[WebView _convertRectFromRootView:]):
1822
1823 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
1824
1825         Adjust naming of action menu SPI
1826         https://bugs.webkit.org/show_bug.cgi?id=140644
1827         <rdar://problem/19448129>
1828
1829         Reviewed by Brian Weinstein.
1830
1831         * WebView/WebActionMenuController.mm:
1832         (-[WebActionMenuController prepareForMenu:withEvent:]):
1833         (-[WebActionMenuController willOpenMenu:withEvent:]):
1834         (-[WebActionMenuController didCloseMenu:withEvent:]):
1835         * WebView/WebView.mm:
1836         (-[WebView _commonInitializationWithFrameName:groupName:]):
1837         (-[WebView prepareForMenu:withEvent:]):
1838         (-[WebView willOpenMenu:withEvent:]):
1839         (-[WebView didCloseMenu:withEvent:]):
1840
1841 2015-01-19  Beth Dakin  <bdakin@apple.com>
1842
1843         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
1844         offset by flipped-ness
1845         https://bugs.webkit.org/show_bug.cgi?id=140643
1846         -and corresponding-
1847         rdar://problem/19489593
1848
1849         Reviewed by Tim Horton.
1850
1851         We universally flipped because we assumed that the root view was flipped and the 
1852         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
1853         fixes that assumption by checking the WebView’s flipped-ness.
1854         * WebView/WebView.mm:
1855         (-[WebView _convertRectFromRootView:]):
1856
1857 2015-01-19  Commit Queue  <commit-queue@webkit.org>
1858
1859         Unreviewed, rolling out r178653.
1860         https://bugs.webkit.org/show_bug.cgi?id=140634
1861
1862         Broke multiple SVG tests on Mountain Lion (Requested by ap on
1863         #webkit).
1864
1865         Reverted changeset:
1866
1867         "[SVG -> OTF Converter] Flip the switch on"
1868         https://bugs.webkit.org/show_bug.cgi?id=140592
1869         http://trac.webkit.org/changeset/178653
1870
1871 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1872
1873         [SVG -> OTF Converter] Flip the switch on
1874         https://bugs.webkit.org/show_bug.cgi?id=140592
1875
1876         Reviewed by Antti Koivisto.
1877
1878         * Configurations/FeatureDefines.xcconfig:
1879
1880 2015-01-18  Daniel Bates  <dabates@apple.com>
1881
1882         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
1883         (https://bugs.webkit.org/show_bug.cgi?id=129441)
1884
1885         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
1886         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
1887
1888         * WebInspector/WebNodeHighlightView.mm:
1889         (-[WebNodeHighlightView layoutSublayers:]):
1890
1891 2015-01-16  Beth Dakin  <bdakin@apple.com>
1892
1893         Make sure early cancellation of immediate action actually does that in WK1
1894         https://bugs.webkit.org/show_bug.cgi?id=140566
1895         -and corresponding-
1896         rdar://problem/19490114
1897
1898         Reviewed by Tim Horton.
1899
1900         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
1901         asynchronously.
1902         * WebView/WebImmediateActionController.mm:
1903         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1904
1905 2015-01-16  Daniel Bates  <dabates@apple.com>
1906
1907         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
1908         (https://bugs.webkit.org/show_bug.cgi?id=140360)
1909
1910         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
1911
1912         * Misc/WebDownload.h:
1913
1914 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
1915
1916         Remove ENABLE(SQL_DATABASE) guards
1917         https://bugs.webkit.org/show_bug.cgi?id=140434
1918
1919         Reviewed by Darin Adler.
1920
1921         * Configurations/FeatureDefines.xcconfig:
1922         * Storage/WebDatabaseManager.mm:
1923         (databasesDirectoryPath):
1924         * Storage/WebDatabaseManagerClient.h:
1925         * Storage/WebDatabaseManagerClient.mm:
1926         * Storage/WebDatabaseManagerInternal.h:
1927         * Storage/WebDatabaseManagerPrivate.h:
1928         * Storage/WebDatabaseQuotaManager.mm:
1929         (-[WebDatabaseQuotaManager usage]):
1930         (-[WebDatabaseQuotaManager quota]):
1931         (-[WebDatabaseQuotaManager setQuota:]):
1932         * WebCoreSupport/WebChromeClient.h:
1933         * WebCoreSupport/WebChromeClient.mm:
1934         * WebCoreSupport/WebSecurityOrigin.mm:
1935         (-[WebSecurityOrigin usage]):
1936         (-[WebSecurityOrigin quota]):
1937         (-[WebSecurityOrigin setQuota:]):
1938         * WebView/WebFrame.mm:
1939         (-[WebFrame _cacheabilityDictionary]):
1940         * WebView/WebView.mm:
1941         (-[WebView _commonInitializationWithFrameName:groupName:]):
1942         (-[WebView _preferencesChanged:]):
1943
1944 2015-01-14  Chris Dumez  <cdumez@apple.com>
1945
1946         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
1947         https://bugs.webkit.org/show_bug.cgi?id=140347
1948
1949         Reviewed by Darin Adler.
1950
1951         Call FontDescription::setIsItalic() instead of setItalic() as the
1952         call site passes a boolean.
1953
1954         * WebView/WebHTMLView.mm:
1955         (fontNameForDescription):
1956
1957 2015-01-13  Anders Carlsson  <andersca@apple.com>
1958
1959         Temporarily reintroduce the informal delegate protocols
1960         https://bugs.webkit.org/show_bug.cgi?id=140416
1961
1962         Reviewed by Dan Bernstein.
1963
1964         * WebView/WebEditingDelegate.h:
1965         * WebView/WebFrameLoadDelegate.h:
1966         * WebView/WebPolicyDelegate.h:
1967         * WebView/WebResourceLoadDelegate.h:
1968         * WebView/WebUIDelegate.h:
1969
1970 2015-01-13  Beth Dakin  <bdakin@apple.com>
1971
1972         Should disable immediate actions for iTunes
1973         https://bugs.webkit.org/show_bug.cgi?id=140405
1974         -and corresponding-
1975         rdar://problem/19461358
1976
1977         Reviewed by Tim Horton.
1978
1979         * WebView/WebImmediateActionController.mm:
1980         (-[WebImmediateActionController _updateImmediateActionItem]):
1981
1982 2015-01-11  Sam Weinig  <sam@webkit.org>
1983
1984         Remove support for SharedWorkers
1985         https://bugs.webkit.org/show_bug.cgi?id=140344
1986
1987         Reviewed by Anders Carlsson.
1988
1989         * Configurations/FeatureDefines.xcconfig:
1990         * WebCoreSupport/WebPlatformStrategies.h:
1991         * WebCoreSupport/WebPlatformStrategies.mm:
1992         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
1993
1994 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
1995
1996         Get rid of unnecessary reimplementations of CGFloor/Ceiling
1997         https://bugs.webkit.org/show_bug.cgi?id=140375
1998
1999         Reviewed by Simon Fraser.
2000
2001         * Misc/WebKitNSStringExtras.mm:
2002         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2003         (webkit_CGCeiling): Deleted.
2004         Delete unnecessary code, use the real CGFloor/Ceiling instead.
2005
2006 2015-01-12  Anders Carlsson  <andersca@apple.com>
2007
2008         Make delegates conform to formal delegate protocols
2009         https://bugs.webkit.org/show_bug.cgi?id=140370
2010
2011         Reviewed by Dan Bernstein.
2012
2013         * DefaultDelegates/WebDefaultPolicyDelegate.h:
2014         * WebCoreSupport/WebInspectorClient.mm:
2015         Add protocols to the interface declarations.
2016
2017         * WebView/WebActionMenuController.mm:
2018         (-[WebActionMenuController prepareForMenu:withEvent:]):
2019         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2020         * WebView/WebImmediateActionController.mm:
2021         (-[WebImmediateActionController _updateImmediateActionItem]):
2022         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2023         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
2024
2025 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
2026
2027         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
2028         https://bugs.webkit.org/show_bug.cgi?id=136769
2029
2030         Reviewed by Antti Koivisto.
2031
2032         * Configurations/FeatureDefines.xcconfig:
2033
2034 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
2035
2036         Multi-rect TextIndicators are vertically flipped in WebKit1
2037         https://bugs.webkit.org/show_bug.cgi?id=140350
2038         <rdar://problem/19441243>
2039
2040         Reviewed by Beth Dakin.
2041
2042         * WebView/WebView.mm:
2043         (-[WebView _setTextIndicator:fadeOut:]):
2044         Convert the textBoundingRect from root view to screen coordinates.
2045
2046 2015-01-12  Anders Carlsson  <andersca@apple.com>
2047
2048         Make WebResourceDelegate a formal protocol as well
2049         https://bugs.webkit.org/show_bug.cgi?id=140364
2050
2051         Reviewed by Dan Bernstein.
2052
2053         * WebView/WebResourceLoadDelegate.h:
2054
2055 2015-01-12  Anders Carlsson  <andersca@apple.com>
2056
2057         Delegates should be formal protocols
2058         https://bugs.webkit.org/show_bug.cgi?id=140360
2059         rdar://problem/17380856
2060
2061         Reviewed by Dan Bernstein.
2062
2063         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
2064
2065         * DefaultDelegates/WebDefaultUIDelegate.h:
2066         * Misc/WebDownload.h:
2067         * WebView/WebEditingDelegate.h:
2068         * WebView/WebFrameLoadDelegate.h:
2069         * WebView/WebPolicyDelegate.h:
2070         * WebView/WebUIDelegate.h:
2071
2072 2015-01-09  Anders Carlsson  <andersca@apple.com>
2073
2074         Get rid of the database strategy
2075         https://bugs.webkit.org/show_bug.cgi?id=140322
2076
2077         Reviewed by Sam Weinig.
2078
2079         * WebCoreSupport/WebPlatformStrategies.h:
2080         * WebCoreSupport/WebPlatformStrategies.mm:
2081         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
2082
2083 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
2084
2085         Can't use DataDetectors after immediate action preparation
2086         https://bugs.webkit.org/show_bug.cgi?id=140263
2087         <rdar://problem/19412705>
2088
2089         Reviewed by Beth Dakin.
2090
2091         * WebView/WebImmediateActionController.mm:
2092         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2093         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2094         To match WebKit2, only call shouldUseActions if the animation is actually
2095         going to begin, not when preparing for it. This way, we're guaranteed
2096         to get a didCancel or didComplete.
2097
2098 2015-01-08  Dean Jackson  <dino@apple.com>
2099
2100         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
2101         https://bugs.webkit.org/show_bug.cgi?id=140232
2102         <rdar://problem/19371010>
2103
2104         Reviewed by Anders Carlsson.
2105
2106         Remove the applicationChromeMode setting, but leave stubs in to make
2107         sure existing binaries don't break.
2108
2109         * WebCoreSupport/WebInspectorClient.mm:
2110         (-[WebInspectorWindowController init]):
2111         * WebView/WebPreferenceKeysPrivate.h:
2112         * WebView/WebPreferences.mm:
2113         (+[WebPreferences initialize]):
2114         (-[WebPreferences applicationChromeModeEnabled]):
2115         (-[WebPreferences setApplicationChromeModeEnabled:]):
2116         * WebView/WebView.mm:
2117         (-[WebView _preferencesChanged:]):
2118
2119 2015-01-07  Daniel Bates  <dabates@apple.com>
2120
2121         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2122         https://bugs.webkit.org/show_bug.cgi?id=137371
2123
2124         Reviewed by David Kilzer.
2125
2126         Use SPI wrapper headers instead of directly references private SPI headers.
2127
2128         * Plugins/Hosted/NetscapePluginHostManager.mm:
2129
2130 2015-01-07  Commit Queue  <commit-queue@webkit.org>
2131
2132         Unreviewed, rolling out r178068.
2133         https://bugs.webkit.org/show_bug.cgi?id=140235
2134
2135         Breaks the iOS build (Requested by enrica on #webkit).
2136
2137         Reverted changeset:
2138
2139         "[iOS] Make WebKit2 build with public iOS SDK and more build
2140         fixes for DRT"
2141         https://bugs.webkit.org/show_bug.cgi?id=137371
2142         http://trac.webkit.org/changeset/178068
2143
2144 2015-01-07  Daniel Bates  <dabates@apple.com>
2145
2146         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2147         https://bugs.webkit.org/show_bug.cgi?id=137371
2148
2149         Reviewed by David Kilzer.
2150
2151         Use SPI wrapper headers instead of directly references private SPI headers.
2152
2153         * Plugins/Hosted/NetscapePluginHostManager.mm:
2154
2155 2015-01-07  Beth Dakin  <bdakin@apple.com>
2156
2157         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
2158         link
2159         https://bugs.webkit.org/show_bug.cgi?id=140206
2160         -and corresponding-
2161         rdar://problem/19300492
2162
2163         Reviewed by Tim Horton.
2164
2165         Providing and item frame will ensure that the original link is not obscured.
2166         * WebView/WebImmediateActionController.mm:
2167         (elementBoundingBoxInWindowCoordinatesFromNode):
2168         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
2169
2170         For now use a max size that is smaller than the WebView, with the screen’s aspect 
2171         ratio, and scaled down.
2172         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
2173
2174 2015-01-07  Anders Carlsson  <andersca@apple.com>
2175
2176         Give simple HTML documents a database provider
2177         https://bugs.webkit.org/show_bug.cgi?id=140192
2178         rdar://problem/19398825
2179
2180         Reviewed by Tim Horton.
2181
2182         * WebView/WebView.mm:
2183         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2184
2185 2015-01-06  Anders Carlsson  <andersca@apple.com>
2186
2187         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
2188         https://bugs.webkit.org/show_bug.cgi?id=140140
2189
2190         Reviewed by Andreas Kling.
2191
2192         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
2193         out of WebCore since nobody else is using it.
2194
2195         * Plugins/WebNetscapePluginView.h:
2196         * Plugins/WebNetscapePluginView.mm:
2197         (-[WebNetscapePluginView _createPlugin]):
2198         (-[WebNetscapePluginView _destroyPlugin]):
2199         * Plugins/npapi.mm:
2200         (NPN_PluginThreadAsyncCall):
2201
2202 2015-01-06  Anders Carlsson  <andersca@apple.com>
2203
2204         Add a WebKit1 database provider
2205         https://bugs.webkit.org/show_bug.cgi?id=140126
2206
2207         Reviewed by Sam Weinig.
2208
2209         Set the database provider.
2210
2211         * WebView/WebView.mm:
2212         (-[WebView _commonInitializationWithFrameName:groupName:]):
2213
2214 2015-01-06  Commit Queue  <commit-queue@webkit.org>
2215
2216         Unreviewed, rolling out r177963.
2217         https://bugs.webkit.org/show_bug.cgi?id=140136
2218
2219         Caused lots of crashes (Requested by smfr on #webkit).
2220
2221         Reverted changeset:
2222
2223         "Add a WebKit1 database provider"
2224         https://bugs.webkit.org/show_bug.cgi?id=140126
2225         http://trac.webkit.org/changeset/177963
2226
2227 2015-01-06  Anders Carlsson  <andersca@apple.com>
2228
2229         Add a WebKit1 database provider
2230         https://bugs.webkit.org/show_bug.cgi?id=140126
2231
2232         Reviewed by Sam Weinig.
2233
2234         Set the database provider.
2235
2236         * WebView/WebView.mm:
2237         (-[WebView _commonInitializationWithFrameName:groupName:]):
2238
2239 2015-01-01  Jeff Miller  <jeffm@apple.com>
2240
2241         Update user-visible copyright strings to include 2015
2242         https://bugs.webkit.org/show_bug.cgi?id=139880
2243
2244         Reviewed by Darin Adler.
2245
2246         * Info.plist:
2247
2248 2014-12-30  Dan Bernstein  <mitz@apple.com>
2249
2250         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
2251         https://bugs.webkit.org/show_bug.cgi?id=140003
2252
2253         Reviewed by Darin Adler.
2254
2255         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
2256         that takes their "string" parameter as a "value" "parameter and has an attribute telling
2257         the compiler that if the "value" parameter is a format string then the function returns a
2258         modified version of it. The result is that if UI_STRING is used as a format string parameter
2259         to some function or method, the compiler will check the format specifiers in the string
2260         against the other parameters.
2261
2262 2014-12-29  Dan Bernstein  <mitz@apple.com>
2263
2264         Fixed the iOS build.
2265
2266         * Configurations/WebKitLegacy.xcconfig:
2267
2268 2014-12-29  Anders Carlsson  <andersca@apple.com>
2269
2270         Get rid of some PageGroup storage functions
2271         https://bugs.webkit.org/show_bug.cgi?id=139996
2272
2273         Reviewed by Sam Weinig.
2274
2275         Call WebStorageNamespaceProvider directly instead.
2276
2277         * Storage/WebStorageManager.mm:
2278         (-[WebStorageManager syncLocalStorage]):
2279         (+[WebStorageManager closeIdleLocalStorageDatabases]):
2280         * WebView/WebView.mm:
2281         (+[WebView _applicationWillTerminate]):
2282
2283 2014-12-29  Anders Carlsson  <andersca@apple.com>
2284
2285         Move storage code from WebCore to WebKit
2286         https://bugs.webkit.org/show_bug.cgi?id=139558
2287
2288         Reviewed by Darin Adler.
2289
2290         * Storage/WebStorageManager.mm:
2291         * Storage/WebStorageTrackerClient.h:
2292         * WebView/WebView.mm:
2293
2294 2014-12-26  Dan Bernstein  <mitz@apple.com>
2295
2296         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
2297         https://bugs.webkit.org/show_bug.cgi?id=139950
2298
2299         Reviewed by David Kilzer.
2300
2301         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
2302         in a manner that works with Xcode 5.1.1.
2303
2304 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
2305
2306         Install a TextIndicator for link immediate actions
2307         https://bugs.webkit.org/show_bug.cgi?id=139897
2308         <rdar://problem/19333076>
2309
2310         Reviewed by Anders Carlsson.
2311
2312         * WebView/WebImmediateActionController.h:
2313         * WebView/WebImmediateActionController.mm:
2314         (-[WebImmediateActionController _clearImmediateActionState]):
2315         Tear down the TextIndicator, just like WebKit2.
2316
2317         (-[WebImmediateActionController _defaultAnimationController]):
2318         Install a TextIndicator for links.
2319
2320         (-[WebImmediateActionController menuItemDidClose:]):
2321         Tear down the TextIndicator when the QL preview closes.
2322
2323         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2324         Directly install and uninstall the TextIndicator for DataDetectors.
2325
2326         (-[WebImmediateActionController _showTextIndicator]): Deleted.
2327         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
2328         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
2329
2330 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
2331
2332         [iOS] add optimized fullscreen API
2333         https://bugs.webkit.org/show_bug.cgi?id=139833
2334         <rdar://problem/18844486>
2335
2336         Reviewed by Simon Fraser.
2337
2338         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
2339
2340 2014-12-20  David Kilzer  <ddkilzer@apple.com>
2341
2342         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2343         <http://webkit.org/b/139463>
2344
2345         Reviewed by Mark Rowe.
2346
2347         * Configurations/Base.xcconfig:
2348         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2349           on OS X.
2350         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2351         * Configurations/DebugRelease.xcconfig:
2352         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2353         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2354         * Configurations/Version.xcconfig:
2355         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2356         * Configurations/WebKitLegacy.xcconfig:
2357         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2358           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2359           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2360           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2361           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2362           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2363           WEBCORE_PRIVATE_HEADERS_DIR_Production and
2364           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2365           based on SDK.
2366         - Fix PRODUCTION_ROOT to actually be set properly.
2367         - Simplify EXPORTED_SYMBOLS_FILE_i386.
2368
2369         * migrate-headers.sh:
2370         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2371         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
2372           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
2373           WebKitLegacy.xcconfig.
2374
2375 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
2376
2377         Fix pink background on CoreAnimation plug-ins in WebKit1
2378         https://bugs.webkit.org/show_bug.cgi?id=139845
2379         rdar://problem/19313075
2380
2381         Reviewed by Tim Horton.
2382         
2383         r154078 left in some debugging code that set a pink background on plug-in hosting
2384         layers. Remove it.
2385
2386         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2387         (-[WebHostedNetscapePluginView createPluginLayer]):
2388
2389 2014-12-19  Andreas Kling  <akling@apple.com>
2390
2391         Ref-ify TextIterator API.
2392         <https://webkit.org/b/139823>
2393
2394         Reviewed by Antti Koivisto.
2395
2396         * WebView/WebTextIterator.mm:
2397         (-[WebTextIterator currentRange]):
2398
2399 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
2400
2401         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
2402         https://bugs.webkit.org/show_bug.cgi?id=139797
2403
2404         Reviewed by Mark Lam.
2405
2406         * WebView/WebScriptDebugger.h:
2407         * WebView/WebScriptDebugger.mm:
2408         (WebScriptDebugger::handlePause):
2409         Standardize on passing JSGlobalObject parameter first.
2410
2411 2014-12-19  Commit Queue  <commit-queue@webkit.org>
2412
2413         Unreviewed, rolling out r177574.
2414         https://bugs.webkit.org/show_bug.cgi?id=139821
2415
2416         "Broke Production builds by installing
2417         libWebCoreTestSupport.dylib in the wrong directory" (Requested
2418         by ddkilzer on #webkit).
2419
2420         Reverted changeset:
2421
2422         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
2423         WebInspectorUI, WebKit, WebKit2"
2424         https://bugs.webkit.org/show_bug.cgi?id=139463
2425         http://trac.webkit.org/changeset/177574
2426
2427 2014-12-19  David Kilzer  <ddkilzer@apple.com>
2428
2429         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2430         <http://webkit.org/b/139463>
2431
2432         Reviewed by Mark Rowe.
2433
2434         * Configurations/Base.xcconfig:
2435         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2436           on OS X.
2437         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2438         * Configurations/DebugRelease.xcconfig:
2439         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2440         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2441         * Configurations/Version.xcconfig:
2442         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2443         * Configurations/WebKitLegacy.xcconfig:
2444         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2445           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2446           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2447           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2448           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2449           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2450           WEBCORE_PRIVATE_HEADERS_DIR_Production and
2451           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2452           based on SDK.
2453         - Fix PRODUCTION_ROOT to actually be set properly.
2454         - Simplify EXPORTED_SYMBOLS_FILE_i386.
2455
2456         * migrate-headers.sh:
2457         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2458         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
2459           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
2460           WebKitLegacy.xcconfig.
2461
2462 2014-12-18  Andreas Kling  <akling@apple.com>
2463
2464         Ref-ify various Document-related things.
2465         <https://webkit.org/b/139796>
2466
2467         Reviewed by Anders Carlsson.
2468
2469         * WebView/WebFrame.mm:
2470         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
2471
2472 2014-12-18  Beth Dakin  <bdakin@apple.com>
2473
2474         Need to re-enable action menus
2475         https://bugs.webkit.org/show_bug.cgi?id=139795
2476         -and corresponding-
2477         rdar://problem/19299367
2478
2479         Reviewed by Tim Horton.
2480
2481         Re-enable the menus by un-commenting the code to create the menu and controller.
2482         * WebView/WebView.mm:
2483         (-[WebView _commonInitializationWithFrameName:groupName:]):
2484
2485 2014-12-16  Sam Weinig  <sam@webkit.org>
2486
2487         Unify the Mac and iOS implementations of FontPlatformData a bit
2488         https://bugs.webkit.org/show_bug.cgi?id=139721
2489
2490         Reviewed by Anders Carlsson.
2491
2492         * WebView/WebHTMLView.mm:
2493         (fontNameForDescription):
2494         Update for new function name.
2495
2496 2014-12-18  Antti Koivisto  <antti@apple.com>
2497
2498         Remove alwaysUseBaselineOfPrimaryFont setting
2499         https://bugs.webkit.org/show_bug.cgi?id=139770
2500
2501         Reviewed by Anders Carlsson.
2502
2503         * WebView/WebPreferenceKeysPrivate.h:
2504         * WebView/WebPreferences.mm:
2505         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
2506         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
2507         * WebView/WebPreferencesPrivate.h:
2508         * WebView/WebView.mm:
2509         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2510         (-[WebView _preferencesChanged:]):
2511
2512 2014-12-17  Andreas Kling  <akling@apple.com>
2513
2514         Ref-ify Range::create().
2515         <https://webkit.org/b/139755>
2516
2517         Reviewed by Anders Carlsson.
2518
2519         * WebView/WebHTMLRepresentation.mm:
2520         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2521         * WebView/WebHTMLView.mm:
2522         (-[WebHTMLView attributedString]):
2523
2524 2014-12-17  Anders Carlsson  <andersca@apple.com>
2525
2526         Unify -[WebResource description]
2527         https://bugs.webkit.org/show_bug.cgi?id=139762
2528
2529         Reviewed by Dan Bernstein.
2530
2531         * WebView/WebResource.mm:
2532         (-[WebResource description]):
2533
2534 2014-12-17  Anders Carlsson  <andersca@apple.com>
2535
2536         Get rid of an ugly #define hack in WebFrameLoaderClient
2537         https://bugs.webkit.org/show_bug.cgi?id=139761
2538
2539         Reviewed by Dan Bernstein.
2540
2541         Also replace @private with @package in all public headers, for consistency.
2542
2543         * History/WebBackForwardList.h:
2544         * History/WebHistory.h:
2545         * Misc/WebDownload.h:
2546         * WebCoreSupport/WebFrameLoaderClient.mm:
2547         * WebView/WebArchive.h:
2548         * WebView/WebDataSource.h:
2549         * WebView/WebFrame.h:
2550         * WebView/WebFrameView.h:
2551         * WebView/WebPreferences.h:
2552         * WebView/WebResource.h:
2553
2554 2014-12-17  Dan Bernstein  <mitz@apple.com>
2555
2556         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
2557         https://bugs.webkit.org/show_bug.cgi?id=139760
2558
2559         Reviewed by Anders Carlsson.
2560
2561         * Configurations/WebKitLegacy.xcconfig:
2562
2563 2014-12-17  Andreas Kling  <akling@apple.com>
2564
2565         Purge PassRefPtr from Frame.
2566         <https://webkit.org/b/139731>
2567
2568         Reviewed by Anders Carlsson.
2569
2570         * WebCoreSupport/WebFrameLoaderClient.mm:
2571         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2572         * WebView/WebFrame.mm:
2573         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
2574         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
2575         * WebView/WebFrameInternal.h:
2576
2577 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
2578
2579         Implement and adopt two new TextIndicator presentation animations
2580         https://bugs.webkit.org/show_bug.cgi?id=139715
2581         <rdar://problem/19237945>
2582
2583         Reviewed by Anders Carlsson.
2584
2585         * WebView/WebActionMenuController.mm:
2586         (-[WebActionMenuController _showTextIndicator]):
2587         * WebView/WebHTMLView.mm:
2588         (-[WebHTMLView quickLookWithEvent:]):
2589         Remove the completionHandler from text indicator presentation.
2590
2591         * WebView/WebImmediateActionController.mm:
2592         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2593         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
2594         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2595         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2596         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2597         (-[WebImmediateActionController _animationControllerForText]):
2598         (-[WebImmediateActionController _showTextIndicator]):
2599         Forward immediate action gesture recognizer animation progress
2600         to TextIndicator. Force us to keep the selection when immediate
2601         action popovers steal first responder status from the WebView.
2602         If the Lookup range is equal to the selection range, use a Crossfade
2603         animation; otherwise, use a FadeIn animation.
2604
2605         * WebView/WebView.mm:
2606         (-[WebView _setMaintainsInactiveSelection:]):
2607         (-[WebView maintainsInactiveSelection]):
2608         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2609         (-[WebView _setTextIndicator:fadeOut:]):
2610         (-[WebView _clearTextIndicator]):
2611         (-[WebView _setTextIndicatorAnimationProgress:]):
2612         (-[WebView _showDictionaryLookupPopup:]):
2613         (-[WebView _dictionaryLookupPopoverWillClose:]):
2614         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2615         Remove the completionHandler from text indicator presentation.
2616         Add a _setMaintainsInactiveSelection, which allows WebKit internals
2617         to change the return value of -maintainsInactiveSelection, allowing
2618         us to keep the selection alive when the WebView loses first responder status.
2619
2620         * WebView/WebViewData.h:
2621         * WebView/WebViewInternal.h:
2622
2623 2014-12-16  Andreas Kling  <akling@apple.com>
2624
2625         Use Ref for SecurityOrigin.
2626         <https://webkit.org/b/139710>
2627
2628         Reviewed by Anders Carlsson.
2629
2630         * Storage/WebStorageTrackerClient.mm:
2631         (WebStorageTrackerClient::dispatchDidModifyOrigin):
2632         * WebView/WebView.mm:
2633         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
2634         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
2635
2636 2014-12-16  Beth Dakin  <bdakin@apple.com>
2637
2638         Crash getting default animation controller for some text
2639         https://bugs.webkit.org/show_bug.cgi?id=139712
2640         -and corresponding-
2641         rdar://problem/19271707
2642
2643         Reviewed by Tim Horton.
2644
2645         Must null-check the range.
2646         * WebView/WebImmediateActionController.mm:
2647         (-[WebImmediateActionController _animationControllerForText]):
2648
2649 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
2650
2651         Immediate action popovers can get stuck open
2652         https://bugs.webkit.org/show_bug.cgi?id=139709
2653         <rdar://problem/19270279>
2654
2655         Reviewed by Beth Dakin.
2656
2657         * WebView/WebImmediateActionController.mm:
2658         (-[WebImmediateActionController _clearImmediateActionState]):
2659         Don't clear the animation controller; it breaks things and was unnecessary.
2660
2661 2014-12-16  Tim Horton  <timothy_horton@apple.com>
2662
2663         Disable TextIndication for Lookup immediate actions
2664         https://bugs.webkit.org/show_bug.cgi?id=139684
2665
2666         Reviewed by Anders Carlsson.
2667
2668         * WebView/WebView.mm:
2669         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2670
2671 2014-12-15  Beth Dakin  <bdakin@apple.com>
2672
2673         Build fix.
2674
2675         * WebView/WebImmediateActionController.mm:
2676
2677 2014-12-15  Beth Dakin  <bdakin@apple.com>
2678
2679         Speculative build fix.
2680
2681         * WebView/WebView.mm:
2682         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2683         * WebView/WebViewInternal.h:
2684
2685 2014-12-15  Beth Dakin  <bdakin@apple.com>
2686
2687         Make lookup an immediate action instead of an action menu item
2688         https://bugs.webkit.org/show_bug.cgi?id=139661
2689         -and corresponding-
2690         rdar://problem/19198414
2691
2692         Reviewed by Tim Horton.
2693
2694         Remove the lookup menu items and non-unused static function associated with 
2695         lookup.
2696         * WebView/WebActionMenuController.mm:
2697         (-[WebActionMenuController _defaultMenuItemsForText]):
2698         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2699         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2700         (-[WebActionMenuController _createActionMenuItemForTag:]):
2701         (-[WebActionMenuController _lookupText:]): Deleted.
2702         (performDictionaryLookupForSelection): Deleted.
2703         (performDictionaryLookupForRange): Deleted.
2704
2705         Set the defaultAnimationController to the lookup-provided animation controller 
2706         when appropriate.
2707         * WebView/WebImmediateActionController.mm:
2708         (-[WebImmediateActionController _defaultAnimationController]):
2709         (dictionaryPopupInfoForRange):
2710         (-[WebImmediateActionController _animationControllerForText]):
2711
2712         New type.
2713         * WebView/WebUIDelegatePrivate.h:
2714
2715         New function to get the lookup animation controller.
2716         * WebView/WebView.mm:
2717         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2718         * WebView/WebViewInternal.h:
2719
2720 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2721
2722         Implement Data Detectors immediate actions for Legacy WebKit
2723         https://bugs.webkit.org/show_bug.cgi?id=139619
2724         <rdar://problem/19198539>
2725
2726         Reviewed by Beth Dakin.
2727
2728         * WebView/WebImmediateActionController.mm:
2729         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2730         Note that this action context is only for immediate actions.
2731
2732 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
2733
2734         Addressing post-review comments in r177035
2735         https://bugs.webkit.org/show_bug.cgi?id=139557
2736
2737         Reviewed by Darin Adler.
2738
2739         * WebView/WebActionMenuController.mm:
2740         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
2741
2742 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2743
2744         Implement Data Detectors immediate actions for Legacy WebKit
2745         https://bugs.webkit.org/show_bug.cgi?id=139619
2746         <rdar://problem/19198539>
2747
2748         Reviewed by Eric Carlson.
2749
2750         * WebView/WebHTMLView.mm:
2751         (-[WebHTMLView mouseDown:mouseDown:]):
2752         Send mouseDown along to the WebImmediateActionController too.
2753
2754         * WebView/WebImmediateActionController.h:
2755         * WebView/WebImmediateActionController.mm:
2756         (-[WebImmediateActionController webViewClosed]):
2757         (-[WebImmediateActionController webView:willHandleMouseDown:]):
2758         (-[WebImmediateActionController _cancelImmediateAction]):
2759         (-[WebImmediateActionController _clearImmediateActionState]):
2760         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2761         (-[WebImmediateActionController _defaultAnimationController]):
2762         (-[WebImmediateActionController _updateImmediateActionItem]):
2763         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2764         (-[WebImmediateActionController _showTextIndicator]):
2765         (-[WebImmediateActionController _hideTextIndicator]):
2766         Copy most of the DataDetectors implementation into WebImmediateActionController.
2767
2768         * WebView/WebUIDelegatePrivate.h:
2769         Add a new type.
2770
2771         * WebView/WebView.mm:
2772         (-[WebView _commonInitializationWithFrameName:groupName:]):
2773         Temporarily disable action menus.
2774
2775         (-[WebView _immediateActionController]):
2776         * WebView/WebViewInternal.h:
2777
2778 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
2779
2780         Delete Notation because we don't use it
2781         https://bugs.webkit.org/show_bug.cgi?id=139171
2782
2783         Reviewed by Kent Tamura.
2784
2785         * MigrateHeaders.make:
2786
2787 2014-12-14  Andreas Kling  <akling@apple.com>
2788
2789         Replace PassRef with Ref/Ref&& across the board.
2790         <https://webkit.org/b/139587>
2791
2792         Reviewed by Darin Adler.
2793
2794         * WebCoreSupport/WebEditorClient.mm:
2795         (WebEditorClient::shouldApplyStyle):
2796         * WebCoreSupport/WebVisitedLinkStore.h:
2797         * WebCoreSupport/WebVisitedLinkStore.mm:
2798         (WebVisitedLinkStore::create):
2799
2800 2014-12-11  Dan Bernstein  <mitz@apple.com>
2801
2802         Fix a leak introduced in r177199.
2803
2804         Reviewed by Anders Carlsson.
2805
2806         * WebView/WebImmediateActionController.mm:
2807         (-[WebImmediateActionController _updateImmediateActionItem]):
2808
2809 2014-12-11  Beth Dakin  <bdakin@apple.com>
2810
2811         WK1: Need new SPI for Webkit clients to override default immediate action
2812         https://bugs.webkit.org/show_bug.cgi?id=139568
2813         -and corresponding-
2814         rdar://problem/19225448
2815
2816         Reviewed by Dan Bernstein.
2817
2818         Call SPI giving clients a chance to override the default behavior.
2819         * WebView/WebImmediateActionController.mm:
2820         (-[WebImmediateActionController _updateImmediateActionItem]):
2821
2822         New SPI.
2823         * WebView/WebUIDelegatePrivate.h:
2824
2825 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
2826
2827         Move the preview popover to WebImmediateActionController
2828         https://bugs.webkit.org/show_bug.cgi?id=139563
2829         <rdar://problem/19208291>
2830
2831         Reviewed by Beth Dakin.
2832
2833         * WebView/WebActionMenuController.mm:
2834         (-[WebActionMenuController _defaultMenuItemsForLink]):
2835         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
2836         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
2837         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
2838         * WebView/WebImmediateActionController.h:
2839         * WebView/WebImmediateActionController.mm:
2840         (-[WebImmediateActionController webViewClosed]):
2841         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2842         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2843         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2844         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2845         (-[WebImmediateActionController _updateImmediateActionItem]):
2846         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
2847         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
2848         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
2849         Move page preview popover related code to WebImmediateActionController.
2850
2851         * WebView/WebUIDelegatePrivate.h:
2852         Add a link preview type.
2853
2854         * WebView/WebView.mm:
2855         (-[WebView _commonInitializationWithFrameName:groupName:]):
2856         Pass the gesture recognizer to the WebImmediateActionController.
2857
2858 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
2859
2860         Fix the build.
2861
2862         * WebView/WebImmediateActionController.h:
2863         * WebView/WebImmediateActionController.mm:
2864
2865 2014-12-11  Anders Carlsson  <andersca@apple.com>
2866
2867         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
2868         https://bugs.webkit.org/show_bug.cgi?id=139547
2869
2870         Reviewed by Sam Weinig.
2871
2872         * WebView/WebView.mm:
2873         (+[WebView _handleMemoryWarning]):
2874
2875 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
2876
2877         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
2878         https://bugs.webkit.org/show_bug.cgi?id=139504
2879         rdar://problem/19034674
2880
2881         Reviewed by Enrica Casucci.
2882
2883         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
2884
2885         * WebCoreSupport/WebEditorClient.h:
2886         * WebCoreSupport/WebEditorClient.mm:
2887         (WebEditorClient::discardedComposition):
2888
2889 2014-12-10  Anders Carlsson  <andersca@apple.com>
2890
2891         Get rid of the storage strategy
2892         https://bugs.webkit.org/show_bug.cgi?id=139519
2893
2894         Reviewed by Antti Koivisto.
2895
2896         * WebCoreSupport/WebPlatformStrategies.h:
2897         * WebCoreSupport/WebPlatformStrategies.mm:
2898         (WebPlatformStrategies::createStorageStrategy): Deleted.
2899
2900 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2901
2902         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
2903         https://bugs.webkit.org/show_bug.cgi?id=139529
2904         <rdar://problem/19213620>
2905
2906         Reviewed by Beth Dakin.
2907
2908         * WebView/WebActionMenuController.mm:
2909         (-[WebActionMenuController _copySelection:]):
2910         (-[WebActionMenuController _paste:]):
2911         Use the copy: and paste: methods on WebView so that we traverse subviews
2912         when trying to respond, otherwise these actions don't work in subframes.
2913
2914 2014-12-10  Beth Dakin  <bdakin@apple.com>
2915
2916         WK1: Add initial support for immediate actions
2917         https://bugs.webkit.org/show_bug.cgi?id=139522
2918
2919         Reviewed by Dan Bernstein.
2920
2921         This basic implementation of the controller will use the delegate methods to 
2922         perform and cache a HitTest when relevant. Future patches will patch 
2923         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
2924         immediate action that should be taken.
2925         * WebView/WebImmediateActionController.h: Added.
2926         * WebView/WebImmediateActionController.mm: Added.
2927         (-[WebImmediateActionController webViewClosed]):
2928         (-[WebImmediateActionController _clearImmediateActionState]):
2929         (-[WebImmediateActionController performHitTestAtPoint:]):
2930         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2931         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2932         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2933         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2934         (-[WebImmediateActionController _updateImmediateActionItem]):
2935
2936         New enum for immediate action types.
2937         * WebView/WebUIDelegatePrivate.h:
2938
2939         Create an NSImmediateActionGestureRecognizer if possible and a controller.
2940         * WebView/WebView.mm:
2941         (-[WebView _commonInitializationWithFrameName:groupName:]):
2942         (-[WebView _close]):
2943         * WebView/WebViewData.h:
2944         * WebView/WebViewData.mm:
2945         (-[WebViewPrivate dealloc]):
2946
2947 2014-12-08  Anders Carlsson  <andersca@apple.com>
2948
2949         Use the new storage namespace provider in WebKit1
2950         https://bugs.webkit.org/show_bug.cgi?id=139425
2951
2952         Reviewed by Tim Horton.
2953
2954         * WebView/WebView.mm:
2955         (-[WebView _commonInitializationWithFrameName:groupName:]):
2956         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2957         Set the storage namespace provider from the web page group.
2958
2959 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2960
2961         Should have copy and paste items in all text menus
2962         https://bugs.webkit.org/show_bug.cgi?id=139510
2963         <rdar://problem/19198388>
2964
2965         Reviewed by Beth Dakin.
2966
2967         * WebView/WebActionMenuController.mm:
2968         (-[WebActionMenuController _defaultMenuItemsForText]):
2969         Add a disabled paste menu item into the read-only text menu.
2970
2971         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2972         Add a disabled copy menu item into the editable whitespace text menu.
2973
2974 2014-12-10  Anders Carlsson  <andersca@apple.com>
2975
2976         Add WebStorageNamespaceProvider::closeLocalStorage
2977         https://bugs.webkit.org/show_bug.cgi?id=139502
2978
2979         Reviewed by Tim Horton.
2980
2981         * WebView/WebView.mm:
2982         (+[WebView _applicationWillTerminate]):
2983         Call WebStorageNamespaceProvider::closeLocalStorage.
2984
2985 2014-12-09  Commit Queue  <commit-queue@webkit.org>
2986
2987         Unreviewed, rolling out r177037.
2988         https://bugs.webkit.org/show_bug.cgi?id=139464
2989
2990         broke ~50 API tests (Requested by thorton on #webkit).
2991
2992         Reverted changeset:
2993
2994         "Use the new storage namespace provider in WebKit1"
2995         https://bugs.webkit.org/show_bug.cgi?id=139425
2996         http://trac.webkit.org/changeset/177037
2997
2998 2014-12-08  Anders Carlsson  <andersca@apple.com>
2999
3000         Use the new storage namespace provider in WebKit1
3001         https://bugs.webkit.org/show_bug.cgi?id=139425
3002
3003         Reviewed by Tim Horton.
3004
3005         * WebView/WebView.mm:
3006         (-[WebView _commonInitializationWithFrameName:groupName:]):
3007         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3008         Set the storage namespace provider from the web page group.
3009
3010 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
3011
3012         Delete Node::boundingBox()
3013         https://bugs.webkit.org/show_bug.cgi?id=139333
3014
3015         Reviewed by Zalan Bujtas.
3016
3017         * WebView/WebActionMenuController.mm:
3018         (elementBoundingBoxInWindowCoordinatesFromNode): Use
3019         RenderObject::absoluteBoundingBoxRect().
3020
3021 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
3022
3023         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
3024         https://bugs.webkit.org/show_bug.cgi?id=138843
3025         rdar://problem/18793695
3026
3027         Reviewed by Dan Bernstein.
3028
3029         * Panels/WebAuthenticationPanel.m:
3030         (-[WebAuthenticationPanel cancel:]):
3031         (-[WebAuthenticationPanel logIn:]):
3032         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
3033         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
3034         that only when using an old NSWindow API.
3035
3036 2014-12-08  Beth Dakin  <bdakin@apple.com>
3037
3038         Copy and Lookup menu items should be disabled when something is not copyable
3039         https://bugs.webkit.org/show_bug.cgi?id=139423
3040
3041         Reviewed by Tim Horton.
3042
3043         Disable both lookup and copy when a HitTestResult does not allow copy.
3044         * WebView/WebActionMenuController.mm:
3045
3046         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
3047         disable state otherwise.
3048         * WebView/WebView.mm:
3049         (-[WebView _commonInitializationWithFrameName:groupName:]):
3050
3051 2014-12-08  Anders Carlsson  <andersca@apple.com>
3052
3053         Adding user content to a group should force that group to be created
3054         https://bugs.webkit.org/show_bug.cgi?id=139421
3055         rdar://problem/19180108
3056
3057         Reviewed by Sam Weinig.
3058
3059         * WebCoreSupport/WebViewGroup.h:
3060         Store the local storage database path in the group.
3061
3062         * WebCoreSupport/WebViewGroup.mm:
3063         (WebViewGroup::getOrCreate):
3064         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
3065         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
3066
3067         (WebViewGroup::WebViewGroup):
3068         Initialize the new member variable.
3069
3070         (WebViewGroup::storageNamespaceProvider):
3071         Create the namespace provider lazily.
3072
3073         * WebView/WebView.mm:
3074         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
3075         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
3076         Use getOrCreate instead of get.
3077
3078 2014-12-08  Anders Carlsson  <andersca@apple.com>
3079
3080         WebStorageNamespaceProvider should know about its local storage database path
3081         https://bugs.webkit.org/show_bug.cgi?id=139413
3082
3083         Reviewed by Andreas Kling.
3084
3085         * WebCoreSupport/WebViewGroup.h:
3086         * WebCoreSupport/WebViewGroup.mm:
3087         (WebViewGroup::getOrCreate):
3088         (WebViewGroup::WebViewGroup):
3089         * WebView/WebView.mm:
3090         (-[WebView _commonInitializationWithFrameName:groupName:]):
3091         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3092         (-[WebView setGroupName:]):
3093         (-[WebView groupName]): Deleted.
3094
3095 2014-12-08  Daniel Bates  <dabates@apple.com>
3096
3097         [iOS] Fix the WebKit build with the public SDK
3098
3099         Include header NSURLDownloadSPI.h.
3100
3101         * WebCoreSupport/WebFrameLoaderClient.mm:
3102
3103 2014-12-07  Dan Bernstein  <mitz@apple.com>
3104
3105         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
3106         https://bugs.webkit.org/show_bug.cgi?id=139348
3107
3108         Reviewed by Anders Carlsson.
3109
3110         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
3111         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
3112         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
3113         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
3114         avoiding the ambiguity.
3115
3116         * WebView/WebActionMenuController.mm:
3117         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3118
3119 2014-12-06  Anders Carlsson  <andersca@apple.com>
3120
3121         Add a stubbed out version of WebStorageNamespaceProvider
3122         https://bugs.webkit.org/show_bug.cgi?id=139213
3123
3124         Reviewed by Sam Weinig.
3125
3126         * WebCoreSupport/WebViewGroup.h:
3127         (WebViewGroup::storageNamespaceProvider):
3128         * WebCoreSupport/WebViewGroup.mm:
3129         (WebViewGroup::getOrCreate):
3130         (WebViewGroup::WebViewGroup):
3131         Give WebViewGroup a storage namespace provider.
3132
3133 2014-12-06  Anders Carlsson  <andersca@apple.com>
3134
3135         Fix build with newer versions of clang.
3136         rdar://problem/18978687
3137
3138         Add missing overrides and missing casts.
3139
3140         * Storage/WebDatabaseManagerClient.h:
3141         * Storage/WebStorageTrackerClient.h:
3142         * WebCoreSupport/WebChromeClient.h:
3143         * WebCoreSupport/WebFrameLoaderClient.h:
3144         * WebCoreSupport/WebInspectorClient.h:
3145         * WebView/WebDataSource.mm:
3146         (-[WebDataSource _makeRepresentation]):
3147         * WebView/WebFrameView.mm:
3148         (-[WebFrameView _makeDocumentViewForDataSource:]):
3149
3150 2014-12-05  Tim Horton  <timothy_horton@apple.com>
3151
3152         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
3153         https://bugs.webkit.org/show_bug.cgi?id=139306
3154         <rdar://problem/19157955>
3155
3156         Reviewed by Beth Dakin.
3157
3158         * WebView/WebView.mm:
3159         (-[WebView _commonInitializationWithFrameName:groupName:]):
3160         (-[WebView _initWithFrame:frameName:groupName:]):
3161         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
3162
3163 2014-12-05  David Kilzer  <ddkilzer@apple.com>
3164
3165         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
3166         <http://webkit.org/b/139286>
3167
3168         Reviewed by Daniel Bates.
3169
3170         * Configurations/FeatureDefines.xcconfig: Switch back to using
3171         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
3172
3173 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
3174
3175         Fix the 32-bit build.
3176
3177         * WebView/WebView.mm:
3178         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3179
3180 2014-12-04  Tim Horton  <timothy_horton@apple.com>
3181
3182         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
3183         https://bugs.webkit.org/show_bug.cgi?id=139252
3184         <rdar://problem/19140827>
3185
3186         Reviewed by Anders Carlsson.
3187
3188         * WebView/WebView.mm:
3189         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3190         Adjust to the WebCore changes.
3191
3192 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
3193
3194         Implement action menus for tel: URLs
3195         https://bugs.webkit.org/show_bug.cgi?id=139240
3196         <rdar://problem/19115662>
3197
3198         Reviewed by Anders Carlsson.
3199
3200         * WebView/WebActionMenuController.mm:
3201         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3202         Make sure to use the newly created currentActionContext... everywhere.
3203
3204 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
3205
3206         Implement action menus for tel: URLs
3207         https://bugs.webkit.org/show_bug.cgi?id=139240
3208         <rdar://problem/19115662>
3209
3210         Reviewed by Anders Carlsson.
3211
3212         * WebView/WebActionMenuController.mm:
3213         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3214         Make sure to use the newly created currentActionContext.
3215
3216 2014-12-03  Beth Dakin  <bdakin@apple.com>
3217
3218         <input> elements get whitespace action menu instead of editable text menu
3219         https://bugs.webkit.org/show_bug.cgi?id=139241
3220         -and corresponding-
3221         rdar://problem/19072083
3222
3223         Reviewed by Sam Weinig.
3224
3225         We should disallow shadow content in the hit test. This is the default and it is 
3226         how context menus behave. We originally wanted to text inside shadow content so 
3227         that we could find the text, but the new function I added to HitTestResult will 
3228         allow that.
3229         * WebView/WebActionMenuController.mm:
3230         (-[WebActionMenuController performHitTestAtPoint:]):
3231
3232         Adjust to the fact that we don’t hit test shadow content any more.
3233         (-[WebActionMenuController focusAndSelectHitTestResult]):
3234
3235         Offer the text menus for text inside form controls.
3236         (-[WebActionMenuController _defaultMenuItems]):
3237
3238 2014-12-03  Tim Horton  <timothy_horton@apple.com>
3239
3240         Implement action menus for tel: URLs
3241         https://bugs.webkit.org/show_bug.cgi?id=139240
3242         <rdar://problem/19115662>
3243
3244         Reviewed by Anders Carlsson.
3245
3246         * WebView/WebActionMenuController.mm:
3247         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3248         Rename this function as it will work for both mailto and tel URLs.
3249         Adjust it to use contextForView:.
3250
3251         (-[WebActionMenuController webView:willHandleMouseDown:]):
3252         (-[WebActionMenuController prepareForMenu:withEvent:]):
3253         (-[WebActionMenuController didCloseMenu:withEvent:]):
3254         (-[WebActionMenuController _defaultMenuItems]):
3255         Don't check the menu type when going to interact with _currentActionContext.
3256         We'll only have a _currentActionContext if we have a data detected item,
3257         and there are multiple menu types that end up using DDActionContext.
3258
3259         * WebView/WebUIDelegatePrivate.h:
3260         Add a new type.
3261
3262 2014-12-03  Anders Carlsson  <andersca@apple.com>
3263
3264         Set a visited link store when creating a simple WebView
3265         https://bugs.webkit.org/show_bug.cgi?id=139234
3266         <rdar://problem/19132978>
3267
3268         Reviewed by Sam Weinig.
3269
3270         * WebView/WebView.mm:
3271         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3272
3273 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
3274
3275         Fix the build.
3276
3277         * WebCoreSupport/WebFrameLoaderClient.mm:
3278
3279 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
3280
3281         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
3282         https://bugs.webkit.org/show_bug.cgi?id=139149
3283
3284         Reviewed by Anders Carlsson.
3285
3286         This changes API behavior. I think that it's OK, because existing behavior made no sense.
3287         We used to delete caches from disk, but they were still active in memory. Now we also
3288         obsolete them in memory, so documents that use a cache still work, but new ones don't
3289         pick one up.
3290
3291         * WebCoreSupport/WebApplicationCache.mm:
3292         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
3293         need to delete in-momry caches too. Keep existing behavior.
3294         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
3295         that properly deletes caches.
3296
3297 2014-12-02  Tim Horton  <timothy_horton@apple.com>
3298
3299         Remove a SnowLeopard-era quirk for QuickLook
3300         https://bugs.webkit.org/show_bug.cgi?id=139208
3301         <rdar://problem/19121822>
3302
3303         Reviewed by Alexey Proskuryakov.
3304
3305         * WebCoreSupport/WebFrameLoaderClient.h:
3306         * WebCoreSupport/WebFrameLoaderClient.mm:
3307
3308 2014-12-02  Tim Horton  <timothy_horton@apple.com>
3309
3310         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
3311         https://bugs.webkit.org/show_bug.cgi?id=139204
3312
3313         Reviewed by Anders Carlsson.
3314
3315         * WebView/WebView.mm:
3316         (-[WebView _commonInitializationWithFrameName:groupName:]):
3317         (-[WebView _showDictionaryLookupPopup:]):
3318         * WebView/WebViewData.h:
3319         Work around this by delaying the softlinking (and setting up the notification
3320         observer) until we actually need it. There's still an underlying bug, but
3321         this will fix the test.
3322
3323 2014-12-02  Beth Dakin  <bdakin@apple.com>
3324
3325         Yet another build fix.
3326
3327         * WebView/WebActionMenuController.mm:
3328         (-[WebActionMenuController _defaultMenuItemsForLink]):
3329
3330 2014-12-02  Beth Dakin  <bdakin@apple.com>
3331
3332         Build fix.
3333
3334         * WebView/WebActionMenuController.mm:
3335         (-[WebActionMenuController _defaultMenuItemsForLink]):
3336
3337 2014-12-02  Beth Dakin  <bdakin@apple.com>
3338
3339         More build fixing.
3340
3341         * WebView/WebActionMenuController.mm:
3342         (-[WebActionMenuController _defaultMenuItemsForLink]):
3343
3344 2014-12-02  Beth Dakin  <bdakin@apple.com>
3345
3346         Should use standardQuickLookMenuItem for apps that don't implement customizations
3347         https://bugs.webkit.org/show_bug.cgi?id=139193
3348         -and corresponding-
3349         rdar://problem/18944696
3350
3351         Reviewed by Anders Carlsson.
3352
3353         Use [NSMenuItem standardQuickLookMenuItem].
3354         * WebView/WebActionMenuController.mm:
3355         (-[WebActionMenuController _defaultMenuItemsForLink]):
3356
3357         Delegate methods to set up the standardQuickLookMenuItem.
3358         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
3359         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
3360         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
3361
3362         Remove all of the old QLPreviewBubble code.
3363         (-[WebActionMenuController _createActionMenuItemForTag:]):
3364         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
3365
3366 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
3367
3368         Fix the build.
3369
3370         * WebView/WebViewData.h:
3371
3372 2014-12-02  Tim Horton  <timothy_horton@apple.com>
3373
3374         Implement Lookup transition from selection for Legacy WebKit
3375         https://bugs.webkit.org/show_bug.cgi?id=139180
3376         <rdar://problem/19067172>
3377
3378         Reviewed by Beth Dakin.
3379
3380         * WebView/DictionaryPopupInfo.h: Added.
3381         Split DictionaryPopupInfo out into its own file.
3382
3383         * WebView/WebActionMenuController.mm:
3384         (-[WebActionMenuController _lookupText:]):
3385         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
3386
3387         (performDictionaryLookupForSelection):
3388         (performDictionaryLookupForRange):
3389         Plumb the transition style through these helpers.
3390         Create a TextIndicator from the selection range.
3391
3392         * WebView/WebHTMLView.mm:
3393         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3394         Make use of TextIndicator (and DictionaryPopupInfo, and the new
3395         _showDictionaryLookupPopup on WebView) to add a transition from blue
3396         when performing Lookup from the context menu.
3397
3398         (-[WebHTMLView quickLookWithEvent:]):
3399         Remove our TextIndicator whenever a normal three-finger-tap event
3400         comes through, as it will have its own indication.
3401
3402         * WebView/WebView.mm:
3403         (-[WebView _commonInitializationWithFrameName:groupName:]):
3404         (-[WebView _dictionaryLookupPopoverWillClose:]):
3405         Register for the LUNotificationPopoverWillClose notification and remove
3406         our TextIndicator when it is called, just like in WebKit2.
3407         Deregistration is already handled in _close.
3408
3409         (-[WebView _showDictionaryLookupPopup:]):
3410         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
3411         if the relevant API is available.
3412
3413         * WebView/WebViewInternal.h:
3414
3415 2014-12-02  Anders Carlsson  <andersca@apple.com>
3416
3417         Remove visited link handling from PageGroup
3418         https://bugs.webkit.org/show_bug.cgi?id=139185
3419
3420         Reviewed by Sam Weinig.
3421
3422         * History/WebHistory.mm:
3423         (-[WebHistoryPrivate removeItemForURLString:]):
3424         (-[WebHistoryPrivate removeAllItems]):
3425         (+[WebHistory setOptionalSharedHistory:]):
3426         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
3427         (+[WebHistory _removeAllVisitedLinks]):
3428         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
3429         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
3430         * History/WebHistoryInternal.h:
3431         * WebCoreSupport/WebChromeClient.h:
3432         * WebCoreSupport/WebChromeClient.mm:
3433         (WebChromeClient::populateVisitedLinks): Deleted.
3434         * WebView/WebView.mm:
3435         (-[WebView addVisitedLinks:]):
3436         (-[WebView removeVisitedLink:]):
3437
3438 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
3439
3440         Try to fix the Mac build.
3441
3442         * WebView/WebView.mm:
3443         (-[WebView _commonInitializationWithFrameName:groupName:]):
3444         (-[WebView _close]):
3445
3446 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
3447
3448         Fix the iOS build.
3449
3450         * WebView/WebActionMenuController.h:
3451         * WebView/WebActionMenuController.mm:
3452         * WebView/WebHTMLView.mm:
3453         (-[WebHTMLView scrollWheel:scrollWheel:]):
3454         (-[WebHTMLView mouseDown:mouseDown:]):
3455         * WebView/WebView.mm:
3456         * WebView/WebViewData.h:
3457         * WebView/WebViewData.mm:
3458         (-[WebViewPrivate dealloc]):
3459         * WebView/WebViewInternal.h:
3460
3461 2014-12-01  Tim Horton  <timothy_horton@apple.com>
3462
3463         Implement yellow highlight for WebKit1 data detectors
3464         https://bugs.webkit.org/show_bug.cgi?id=138956
3465         <rdar://problem/18992185>
3466
3467         Reviewed by Beth Dakin.
3468
3469         * WebView/WebActionMenuController.h:
3470         * WebView/WebActionMenuController.mm:
3471         (-[WebActionMenuController webView:willHandleMouseDown:]):
3472         (-[WebActionMenuController webView:didHandleScrollWheel:]):
3473         (-[WebActionMenuController prepareForMenu:withEvent:]):
3474         (-[WebActionMenuController didCloseMenu:withEvent:]):
3475         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3476         (-[WebActionMenuController _showTextIndicator]):
3477         (-[WebActionMenuController _hideTextIndicator]):
3478         (-[WebActionMenuController _dismissActionMenuPopovers]):
3479         Copy the WebKit2 WKActionMenuController TextIndicator implementation
3480         into WebActionMenuController. The only significant difference is
3481         that we build the TextIndicator right at menu construction time
3482         instead of in the Web process.
3483
3484         * WebView/WebHTMLView.mm:
3485         (-[WebHTMLView scrollWheel:]):
3486         Let the WebActionMenuController know that we're handling a scroll.
3487
3488         (-[WebHTMLView mouseDown:]):
3489         Let the WebActionMenuController know that we're handling a mouseDown.
3490
3491         * WebView/WebView.mm:
3492         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3493         (-[WebView _clearTextIndicator]):
3494         (-[WebView _actionMenuController]):
3495         (-[WebView _convertRectFromRootView:]): Deleted.
3496         * WebView/WebViewData.h:
3497         * WebView/WebViewData.mm:
3498         * WebView/WebViewInternal.h:
3499         Keep a TextIndicatorWindow on WebView, just like WKView does.
3500         Expose the WebActionMenuController on WebView (internally).
3501
3502 2014-12-01  Anders Carlsson  <andersca@apple.com>
3503
3504         Remove old site specific quirks code that was added in 2009
3505         https://bugs.webkit.org/show_bug.cgi?id=139141
3506
3507         Reviewed by Antti Koivisto.
3508
3509         * WebCoreSupport/WebFrameNetworkingContext.h:
3510         * WebCoreSupport/WebFrameNetworkingContext.mm:
3511         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
3512
3513 2014-11-30  Anders Carlsson  <andersca@apple.com>
3514
3515         Fix a test failure.
3516
3517         * History/WebHistory.mm:
3518         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
3519         Call through to the visited link store.
3520
3521         (+[WebHistory _removeAllVisitedLinks]):
3522         Ditto.
3523
3524         * WebCoreSupport/WebVisitedLinkStore.mm:
3525         (WebVisitedLinkStore::isLinkVisited):
3526         Make sure to populate visited links.
3527
3528 2014-11-30  Anders Carlsson  <andersca@apple.com>
3529
3530         Switch over to the visited link store from the WebViewGroup
3531         https://bugs.webkit.org/show_bug.cgi?id=139112
3532
3533         Reviewed by Sam Weinig.
3534
3535         * WebView/WebView.mm:
3536         (-[WebView _commonInitializationWithFrameName:groupName:]):
3537         (-[WebView setGroupName:]):
3538
3539 2014-11-30  Anders Carlsson  <andersca@apple.com>
3540
3541         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
3542         https://bugs.webkit.org/show_bug.cgi?id=139111
3543
3544         Reviewed by Sam Weinig.
3545
3546         * WebCoreSupport/WebVisitedLinkStore.h:
3547         * WebCoreSupport/WebVisitedLinkStore.mm:
3548         (WebVisitedLinkStore::removeVisitedLink):
3549         * WebView/WebView.mm:
3550         (-[WebView removeVisitedLink:]):
3551
3552 2014-11-29  Anders Carlsson  <andersca@apple.com>
3553
3554         Populate visited links
3555         https://bugs.webkit.org/show_bug.cgi?id=139101
3556
3557         Reviewed by Sam Weinig.
3558
3559         * History/WebHistory.mm:
3560         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
3561         Helper function that adds all visited link to the given store.
3562
3563         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
3564         Call the private method.
3565
3566         * History/WebHistoryInternal.h:
3567         * WebCoreSupport/WebVisitedLinkStore.h:
3568         Add new members.
3569
3570         * WebCoreSupport/WebVisitedLinkStore.mm:
3571         (WebVisitedLinkStore::addVisitedLink):
3572         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
3573
3574         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
3575         Implement this. First try the delegate, then try the shared history.
3576
3577         (WebVisitedLinkStore::addVisitedLinkHash):
3578         Factor code that adds the link to the hash table into a separate function.
3579
3580         * WebView/WebView.mm:
3581         (-[WebView addVisitedLinks:]):
3582         Add the visited links to the store.
3583
3584 2014-11-29  Anders Carlsson  <andersca@apple.com>
3585
3586         More work on the legacy WebKit visited link store
3587         https://bugs.webkit.org/show_bug.cgi?id=139100
3588
3589         Reviewed by Sam Weinig.
3590
3591         * History/WebHistory.mm:
3592         (+[WebHistory setOptionalSharedHistory:]):
3593         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
3594
3595         * WebCoreSupport/WebVisitedLinkStore.h:
3596         * WebCoreSupport/WebVisitedLinkStore.mm:
3597         (visitedLinkStores):
3598         (WebVisitedLinkStore::WebVisitedLinkStore):
3599         (WebVisitedLinkStore::~WebVisitedLinkStore):
3600         Keep track of live visited link stores.
3601
3602         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
3603         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
3604
3605         (WebVisitedLinkStore::removeAllVisitedLinks):
3606         Iterate over all live link stores and remove their links.
3607
3608         (WebVisitedLinkStore::isLinkVisited):
3609         Populate visited links and check if our hash table contains the link.
3610
3611         (WebVisitedLinkStore::addVisitedLink):
3612         Add the link hash to the table.
3613
3614         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
3615         Add stub.
3616
3617         (WebVisitedLinkStore::removeVisitedLinkHashes):
3618         Clear out the hash table.
3619
3620 2014-11-27  Anders Carlsson  <andersca@apple.com>
3621
3622         Add a stubbed out WebVisitedLinkStore to WebViewGroup
3623         https://bugs.webkit.org/show_bug.cgi?id=139066
3624
3625         Reviewed by Antti Koivisto.
3626
3627         * WebCoreSupport/WebViewGroup.h:
3628         (WebViewGroup::visitedLinkStore):
3629         * WebCoreSupport/WebViewGroup.mm:
3630         (WebViewGroup::WebViewGroup):
3631         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
3632         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
3633         (WebVisitedLinkStore::create):
3634         (WebVisitedLinkStore::WebVisitedLinkStore):
3635         (WebVisitedLinkStore::~WebVisitedLinkStore):
3636         (WebVisitedLinkStore::isLinkVisited):
3637         (WebVisitedLinkStore::addVisitedLink):
3638
3639 2014-11-25  Anders Carlsson  <andersca@apple.com>
3640
3641         Remove user content handling from PageGroup
3642         https://bugs.webkit.org/show_bug.cgi?id=139051
3643
3644         Reviewed by Antti Koivisto.
3645
3646         Use the user content controller in the web view group.
3647
3648         * WebView/WebView.mm:
3649         (-[WebView _injectOutlookQuirksScript]):
3650
3651 2014-11-25  Anders Carlsson  <andersca@apple.com>
3652
3653         Add a user content controller to WebViewGroup and use it for user content
3654         https://bugs.webkit.org/show_bug.cgi?id=139043
3655
3656         Reviewed by Antti Koivisto.
3657
3658         This is another tiny step towards getting rid of user content handling inside PageGroup.
3659
3660         * WebCoreSupport/WebViewGroup.h:
3661         (WebViewGroup::userContentController):
3662         Add a UserContentController member and getter.
3663
3664         * WebCoreSupport/WebViewGroup.mm:
3665         (WebViewGroup::get):
3666         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
3667
3668         (WebViewGroup::WebViewGroup):
3669         Create a user content controller.
3670
3671         * WebView/WebView.mm:
3672         (-[WebView _commonInitializationWithFrameName:groupName:]):
3673         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
3674         set its user content controller in the PageConfiguration.
3675
3676         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3677         Ditto.
3678
3679         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
3680         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
3681         (+[WebView _removeUserScriptFromGroup:world:url:]):
3682         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
3683         (+[WebView _removeUserScriptsFromGroup:world:]):
3684         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
3685         (+[WebView _removeAllUserContentFromGroup:]):
3686         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
3687
3688         (-[WebView setGroupName:]):
3689         Set the user content controller to the new WebViewGroup's user content controller.
3690
3691 2014-11-21  Jer Noble  <jer.noble@apple.com>
3692
3693         Support multiple signatures of diagnostic logging.
3694         https://bugs.webkit.org/show_bug.cgi?id=138690
3695
3696         Reviewed by Anders Carlsson.
3697
3698         Page::PageClients has been renamed PageConfiguration.
3699
3700         * WebView/WebView.mm:
3701         (-[WebView _commonInitializationWithFrameName:groupName:]):
3702         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3703
3704 2014-11-21  Zalan Bujtas  <zalan@apple.com>
3705
3706         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
3707         https://bugs.webkit.org/show_bug.cgi?id=138981
3708
3709         Reviewed by Simon Fraser.
3710
3711         * WebView/WebPreferenceKeysPrivate.h:
3712         * WebView/WebPreferences.mm:
3713         (+[WebPreferences initialize]):
3714         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
3715         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
3716         * WebView/WebPreferencesPrivate.h:
3717         * WebView/WebView.mm:
3718         (-[WebView _preferencesChanged:]):
3719
3720 2014-11-21  Tim Horton  <timothy_horton@apple.com>
3721
3722         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
3723         ​https://bugs.webkit.org/show_bug.cgi?id=138960
3724         <rdar://problem/19056715>
3725
3726         Reviewed by Anders Carlsson.
3727
3728         * WebView/WebActionMenuController.mm:
3729         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
3730         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3731         Use DataDetectors SPI instead of an explicit blacklist.
3732
3733 2014-11-21  Tim Horton  <timothy_horton@apple.com>
3734
3735         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
3736         https://bugs.webkit.org/show_bug.cgi?id=138960
3737         <rdar://problem/19056715>
3738
3739         Reviewed by Beth Dakin.
3740
3741         * WebView/WebActionMenuController.mm:
3742         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3743         Blacklist contact results, because they don't have useful menus. If we
3744         bail before setting up _currentActionContext, we'll still allow fallthrough
3745         to ordinary text actions, avoiding mysterious failure when a contact is detected.
3746
3747         This doesn't break the case that r176351 was intended to fix,
3748         because in that case we were detecting e.g. addresses.
3749
3750 2014-11-21  Anders Carlsson  <andersca@apple.com>
3751
3752         Remove the Timer parameters from timer callbacks
3753         https://bugs.webkit.org/show_bug.cgi?id=138974
3754
3755         Reviewed by Antti Koivisto.
3756
3757         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3758         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3759         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
3760         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
3761         * Plugins/WebNetscapePluginStream.h:
3762         * Plugins/WebNetscapePluginStream.mm:
3763         (WebNetscapePluginStream::WebNetscapePluginStream):
3764         (WebNetscapePluginStream::deliverDataTimerFired):
3765
3766 2014-11-21  Anders Carlsson  <andersca@apple.com>
3767
3768         Make memoryCache() return a reference
3769         https://bugs.webkit.org/show_bug.cgi?id=138939
3770
3771         Reviewed by Antti Koivisto.
3772
3773         * Misc/WebCache.mm:
3774         (+[WebCache statistics]):
3775         (+[WebCache emptyInMemoryResources]):
3776         (+[WebCache sizeOfDeadResources:]):
3777         (+[WebCache addImageToCache:forURL:forFrame:]):
3778         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3779         (+[WebCache imageForURL:]):
3780         (+[WebCache setDisabled:]):
3781         (+[WebCache isDisabled]):
3782         * WebView/WebView.mm:
3783         (+[WebView _setCacheModel:]):
3784
3785 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
3786
3787         Remove the remaining vestiges of minimal-ui
3788         https://bugs.webkit.org/show_bug.cgi?id=138890
3789
3790         Reviewed by Sam Weinig.
3791
3792         * History/WebHistoryItem.mm:
3793         * History/WebHistoryItemPrivate.h:
3794
3795 2014-11-20  Tim Horton  <timothy_horton@apple.com>
3796
3797         Cancel DataDetectors menu earlier if we know it can't be presented
3798         https://bugs.webkit.org/show_bug.cgi?id=138922
3799         <rdar://problem/18950441>
3800
3801         Reviewed by Beth Dakin.
3802
3803         * WebView/WebActionMenuController.mm:
3804         (-[WebActionMenuController prepareForMenu:withEvent:]):
3805         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
3806         and use a bigger hammer (removeAllItems).
3807
3808         (-[WebActionMenuController willOpenMenu:withEvent:]):
3809         If we end up with a menu with no items, don't change selection or anything.
3810
3811 2014-11-20  Beth Dakin  <bdakin@apple.com>
3812
3813         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
3814         https://bugs.webkit.org/show_bug.cgi?id=138568
3815         -and corresponding-
3816         rdar://problem/18904600
3817
3818         Reviewed by Tim Horton.
3819
3820         Skip images for lookup.
3821         * WebView/WebActionMenuController.mm:
3822         (performDictionaryLookupForRange):
3823
3824 2014-11-19  Beth Dakin  <bdakin@apple.com>
3825
3826         Invoking an action menu on a selection should result in the text menu
3827         https://bugs.webkit.org/show_bug.cgi?id=138892
3828         -and corresponding-
3829         rdar://problem/18996776
3830
3831         Reviewed by Tim Horton.
3832
3833         * WebView/WebActionMenuController.mm:
3834         (-[WebActionMenuController _defaultMenuItems]):
3835
3836 2014-11-19  Beth Dakin  <bdakin@apple.com>
3837
3838         Data detected results with no menu items should not fall through to regular text 
3839         action menus
3840         https://bugs.webkit.org/show_bug.cgi?id=138887
3841         -and corresponding-
3842         rdar://problem/18971616
3843
3844         Reviewed by Tim Horton.
3845
3846         * WebView/WebActionMenuController.mm:
3847         (-[WebActionMenuController _defaultMenuItems]):
3848
3849 2014-11-19  Daniel Bates  <dabates@apple.com>
3850
3851         [iOS] Make WebKit build with public iOS SDK
3852         https://bugs.webkit.org/show_bug.cgi?id=136863
3853
3854         Reviewed by David Kilzer.
3855
3856         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
3857         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
3858         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
3859         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
3860         may be used by Apple internal clients that do not include wtf/Platform.h.
3861         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
3862         private Foundation headers directly.
3863         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
3864         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
3865         instead of including private CFNetwork headers directly. Also fixed up style and
3866         ordering of header include directives.
3867         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
3868         CFNetwork headers directly. Also sort the #import directives.
3869         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
3870         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
3871
3872 2014-11-18  David Kilzer  <ddkilzer@apple.com>
3873
3874         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
3875         <http://webkit.org/b/138813>
3876
3877         Reviewed by Mark Rowe.
3878
3879         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
3880         selectors.
3881
3882 2014-11-18  Chris Dumez  <cdumez@apple.com>
3883
3884         Add a setting to toggle DOMTimer throttling support
3885         https://bugs.webkit.org/show_bug.cgi?id=138844
3886         <rdar://problem/19020874>
3887
3888         Reviewed by Andreas Kling.
3889
3890         Add a setting to disable DOM timers throttling, in order to help
3891         developers determine if a specific issue is caused by timer
3892         throttling.
3893
3894         * WebView/WebPreferenceKeysPrivate.h:
3895         * WebView/WebPreferences.mm:
3896         (+[WebPreferences initialize]):
3897         (-[WebPreferences domTimersThrottlingEnabled]):
3898         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
3899         * WebView/WebPreferencesPrivate.h:
3900         * WebView/WebView.mm:
3901         (-[WebView _preferencesChanged:]):
3902
3903 2014-11-18  Tim Horton  <timothy_horton@apple.com>
3904
3905         Avoid re-encoding action menu image data
3906         https://bugs.webkit.org/show_bug.cgi?id=138817
3907         <rdar://problem/18840382>
3908
3909         Reviewed by Anders Carlsson.
3910
3911         * WebView/WebActionMenuController.mm:
3912         (-[WebActionMenuController _defaultMenuItemsForImage:]):
3913         (-[WebActionMenuController _addImageToPhotos:]):
3914         Build a temporary filename from a UUID and the image's desired extension.
3915         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
3916         Build an image menu only if we have an image, URL, data, and extension.
3917
3918 2014-11-18  Daniel Bates  <dabates@apple.com>
3919
3920         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3921         SPI are not available in public SDK
3922         https://bugs.webkit.org/show_bug.cgi?id=138802
3923
3924         Reviewed by David Kilzer.
3925
3926         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
3927         libdispatch and MobileGestalt headers directly.
3928
3929         * WebView/WebView.mm:
3930
3931 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
3932
3933         Remove calls to deprecated NSMenu methods
3934         https://bugs.webkit.org/show_bug.cgi?id=138808.
3935
3936         Reviewed by Anders Carlsson.
3937
3938         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
3939
3940         * WebCoreSupport/PopupMenuMac.mm:
3941         (PopupMenuMac::populate):
3942
3943 2014-11-17  Daniel Bates  <dabates@apple.com>
3944
3945         Unreviewed, rolling out r176232.
3946
3947         Broke the Mac build. Will investigate offline.
3948
3949         Reverted changeset:
3950
3951         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
3952         MobileGestalt"
3953         https://bugs.webkit.org/show_bug.cgi?id=138802
3954         http://trac.webkit.org/changeset/176232
3955
3956 2014-11-17  Daniel Bates  <dabates@apple.com>
3957
3958         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3959         SPI are not available in public SDK
3960         https://bugs.webkit.org/show_bug.cgi?id=138802
3961
3962         Reviewed by David Kilzer.
3963
3964         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
3965         libdispatch and MobileGestalt headers directly.
3966
3967         * WebView/WebView.mm:
3968
3969 2014-11-17  Beth Dakin  <bdakin@apple.com>
3970
3971         Whitespace action menus should focus the HitTestResult and create an insertion 
3972         point
3973         https://bugs.webkit.org/show_bug.cgi?id=138786
3974         -and corresponding-
3975         rdar://problem/18944893
3976
3977         Reviewed by Tim Horton.
3978
3979         Whitespace menus should cause the HitTestResult to be focused, and they should set 
3980         the selection based on the HitTest location.
3981
3982         * WebView/WebActionMenuController.mm:
3983         (-[WebActionMenuController isMenuForTextContent]):
3984         (-[WebActionMenuController focusAndSelectHitTestResult]):
3985         (-[WebActionMenuController willOpenMenu:withEvent:]):
3986
3987 2014-11-17  Daniel Bates  <dabates@apple.com>
3988
3989         [iOS] QuartzCore SPI not available in public SDK
3990         https://bugs.webkit.org/show_bug.cgi?id=138751
3991
3992         Reviewed by David Kilzer.
3993
3994         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
3995
3996         * WebInspector/WebNodeHighlight.mm:
3997         * WebView/WebIndicateLayer.mm:
3998
3999 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
4000
4001         [iOS] allow host application to opt-out of alternate fullscreen
4002         https://bugs.webkit.org/show_bug.cgi?id=138787
4003
4004         Reviewed by Darin Adler.
4005
4006         * WebView/WebPreferenceKeysPrivate.h:
4007         * WebView/WebPreferences.mm:
4008         (+[WebPreferences initialize]):
4009         (-[WebPreferences allowsAlternateFullscreen]):
4010         (-[WebPreferences setAllowsAlternateFullscreen:]):
4011         * WebView/WebPreferencesPrivate.h:
4012         * WebView/WebView.mm:
4013         (-[WebView _preferencesChanged:]):
4014
4015 2014-11-16  Tim Horton  <timothy_horton@apple.com>
4016
4017         Use TextIndicator instead of the built in Lookup highlight
4018         https://bugs.webkit.org/show_bug.cgi?id=138775
4019         <rdar://problem/18953982>
4020
4021         Reviewed by Anders Carlsson.
4022
4023         * WebCoreSupport/WebSystemInterface.mm:
4024         (InitWebCoreSystemInterface):
4025         Remove a WKSI import.
4026
4027         * WebView/WebActionMenuController.mm:
4028         (-[WebActionMenuController _lookupText:]):
4029         (-[WebActionMenuController _createActionMenuItemForTag:]):
4030         Make use of the new Lookup SPI header.
4031         Disable the Lookup item if lookup is not available.
4032
4033 2014-11-15  Tim Horton  <timothy_horton@apple.com>
4034
4035         Implement data detectors and mailto action menus for WebKit1
4036         https://bugs.webkit.org/show_bug.cgi?id=138765
4037         <rdar://problem/18877535>
4038
4039         Reviewed by Beth Dakin.
4040
4041         * WebView/WebActionMenuController.h:
4042         * WebView/WebActionMenuController.mm:
4043         (-[WebActionMenuController willOpenMenu:withEvent:]):
4044         Tell DataDetectors that the menu is going to open.
4045         Select the text (or not) based on the number of items in the menu, just like WebKit2.
4046
4047         (-[WebActionMenuController didCloseMenu:withEvent:]):
4048         Tell DataDetectors that the menu closed.
4049
4050         (-[WebActionMenuController _defaultMenuItemsForLink]):
4051         Move these checks out of _defaultMenuItemsForLink, because we expect this
4052         to always return a complete link menu.
4053
4054         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
4055         Implement. More or less copied from WebKit2.
4056
4057         (-[WebActionMenuController _selectDataDetectedText]):
4058         Select the stashed range.
4059
4060         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
4061         Implement. More or less copied from WebKit2.
4062         The yellow highlight isn't hooked up yet.
4063         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
4064
4065         (-[WebActionMenuController _selectLookupText]):
4066         Remove an unnecessary return.
4067
4068         (-[WebActionMenuController _defaultMenuItems]):
4069         Call into the two new menu types.
4070
4071         * WebView/WebUIDelegatePrivate.h:
4072
4073 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
4074
4075         Get rid of WebFontCache
4076         https://bugs.webkit.org/show_bug.cgi?id=134752
4077
4078         Reviewed by Dave Hyatt.
4079
4080         * WebView/WebHTMLView.mm:
4081
4082 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
4083
4084         Update some artwork for the legacy WebKit action menu
4085         https://bugs.webkit.org/show_bug.cgi?id=138758
4086         <rdar://problem/18989840>
4087
4088         * WebView/WebActionMenuController.mm:
4089         (webKitBundleImageNamed): Deleted.
4090         Fix the build.
4091
4092 2014-11-14  Tim Horton  <timothy_horton@apple.com>
4093
4094         Update some artwork for the legacy WebKit action menu
4095         https://bugs.webkit.org/show_bug.cgi?id=138758
4096         <rdar://problem/18989840>
4097
4098         Reviewed by Simon Fraser.
4099
4100         * WebView/WebActionMenuController.mm:
4101         (-[WebActionMenuController _createActionMenuItemForTag:]):
4102
4103 2014-11-14  Daniel Bates  <dabates@apple.com>
4104
4105         [iOS] NSFileManager and QuickLook SPI not available in public SDK
4106         https://bugs.webkit.org/show_bug.cgi?id=138742
4107
4108         Reviewed by Pratik Solanki.
4109
4110         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
4111
4112         * WebCoreSupport/WebFrameLoaderClient.mm:
4113
4114 2014-11-14  Beth Dakin  <bdakin@apple.com>
4115
4116         WK1: Webpage preview can come up in wrong location
4117         https://bugs.webkit.org/show_bug.cgi?id=138747
4118         -and corresponding-
4119         rdar://problem/18979004
4120
4121         Reviewed by Tim Horton.
4122
4123         Converting to window twice is bad.
4124         * WebView/WebActionMenuController.mm:
4125         (elementBoundingBoxInWindowCoordinatesFromNode):
4126         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
4127         (elementBoundingBoxFromNode): Deleted.
4128
4129 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
4130
4131         Move FontMac and FontCacheMac off of WKSI
4132         https://bugs.webkit.org/show_bug.cgi?id=138633
4133
4134         Reviewed by Simon Fraser.
4135
4136         * WebCoreSupport/WebSystemInterface.mm:
4137         (InitWebCoreSystemInterface):
4138         * WebKit.order:
4139
4140 2014-11-13  Beth Dakin  <bdakin@apple.com>
4141
4142         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
4143         https://bugs.webkit.org/show_bug.cgi?id=138716
4144         -and corresponding-
4145         rdar://problem/18977222
4146
4147         Reviewed by Tim Horton.
4148
4149         It’s not necessary to use the WebElementDictionary for so many things now that we 
4150         are caching the HitTestResult. We should just use the HitTestResult.
4151
4152         * WebView/WebActionMenuController.mm:
4153         (-[WebActionMenuController prepareForMenu:withEvent:]):
4154         (-[WebActionMenuController _openURLFromActionMenu:]):
4155         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
4156         (elementBoundingBoxFromNode):
4157         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
4158         (-[WebActionMenuController _defaultMenuItemsForLink]):
4159         (-[WebActionMenuController _defaultMenuItemsForImage]):
4160         (-[WebActionMenuController _defaultMenuItemsForVideo]):
4161         (-[WebActionMenuController _defaultMenuItemsForText]):
4162         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
4163         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
4164         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
4165         (-[WebActionMenuController _createActionMenuItemForTag:]):
4166         (-[WebActionMenuController _defaultMenuItems]):
4167         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
4168         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
4169         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
4170         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
4171         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
4172         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
4173         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
4174         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
4175         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
4176         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
4177
4178 2014-11-13  Daniel Bates  <dabates@apple.com>
4179
4180         [iOS] NSGeometry data types are not available in the public SDK
4181         https://bugs.webkit.org/show_bug.cgi?id=137536
4182
4183         Reviewed by David Kilzer.
4184
4185         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
4186         private header.
4187
4188         * DOM/WebDOMOperationsPrivate.h:
4189
4190 2014-11-13  Beth Dakin  <bdakin@apple.com>
4191
4192         WK1: Support default actions for video
4193         https://bugs.webkit.org/show_bug.cgi?id=138713
4194         -and corresponding-
4195         rdar://problem/18877520
4196
4197         Reviewed by Tim Horton.
4198
4199         Call setToNonShadowAncestor() for media HitTestResults.
4200         * WebView/WebActionMenuController.mm:
4201         (-[WebActionMenuController performHitTestAtPoint:]):
4202
4203         Default items and actions.
4204         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
4205         (-[WebActionMenu