Set a visited link store when creating a simple WebView
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-12-03  Anders Carlsson  <andersca@apple.com>
2
3         Set a visited link store when creating a simple WebView
4         https://bugs.webkit.org/show_bug.cgi?id=139234
5         <rdar://problem/19132978>
6
7         Reviewed by Sam Weinig.
8
9         * WebView/WebView.mm:
10         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
11
12 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
13
14         Fix the build.
15
16         * WebCoreSupport/WebFrameLoaderClient.mm:
17
18 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
19
20         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
21         https://bugs.webkit.org/show_bug.cgi?id=139149
22
23         Reviewed by Anders Carlsson.
24
25         This changes API behavior. I think that it's OK, because existing behavior made no sense.
26         We used to delete caches from disk, but they were still active in memory. Now we also
27         obsolete them in memory, so documents that use a cache still work, but new ones don't
28         pick one up.
29
30         * WebCoreSupport/WebApplicationCache.mm:
31         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
32         need to delete in-momry caches too. Keep existing behavior.
33         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
34         that properly deletes caches.
35
36 2014-12-02  Tim Horton  <timothy_horton@apple.com>
37
38         Remove a SnowLeopard-era quirk for QuickLook
39         https://bugs.webkit.org/show_bug.cgi?id=139208
40         <rdar://problem/19121822>
41
42         Reviewed by Alexey Proskuryakov.
43
44         * WebCoreSupport/WebFrameLoaderClient.h:
45         * WebCoreSupport/WebFrameLoaderClient.mm:
46
47 2014-12-02  Tim Horton  <timothy_horton@apple.com>
48
49         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
50         https://bugs.webkit.org/show_bug.cgi?id=139204
51
52         Reviewed by Anders Carlsson.
53
54         * WebView/WebView.mm:
55         (-[WebView _commonInitializationWithFrameName:groupName:]):
56         (-[WebView _showDictionaryLookupPopup:]):
57         * WebView/WebViewData.h:
58         Work around this by delaying the softlinking (and setting up the notification
59         observer) until we actually need it. There's still an underlying bug, but
60         this will fix the test.
61
62 2014-12-02  Beth Dakin  <bdakin@apple.com>
63
64         Yet another build fix.
65
66         * WebView/WebActionMenuController.mm:
67         (-[WebActionMenuController _defaultMenuItemsForLink]):
68
69 2014-12-02  Beth Dakin  <bdakin@apple.com>
70
71         Build fix.
72
73         * WebView/WebActionMenuController.mm:
74         (-[WebActionMenuController _defaultMenuItemsForLink]):
75
76 2014-12-02  Beth Dakin  <bdakin@apple.com>
77
78         More build fixing.
79
80         * WebView/WebActionMenuController.mm:
81         (-[WebActionMenuController _defaultMenuItemsForLink]):
82
83 2014-12-02  Beth Dakin  <bdakin@apple.com>
84
85         Should use standardQuickLookMenuItem for apps that don't implement customizations
86         https://bugs.webkit.org/show_bug.cgi?id=139193
87         -and corresponding-
88         rdar://problem/18944696
89
90         Reviewed by Anders Carlsson.
91
92         Use [NSMenuItem standardQuickLookMenuItem].
93         * WebView/WebActionMenuController.mm:
94         (-[WebActionMenuController _defaultMenuItemsForLink]):
95
96         Delegate methods to set up the standardQuickLookMenuItem.
97         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
98         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
99         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
100
101         Remove all of the old QLPreviewBubble code.
102         (-[WebActionMenuController _createActionMenuItemForTag:]):
103         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
104
105 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
106
107         Fix the build.
108
109         * WebView/WebViewData.h:
110
111 2014-12-02  Tim Horton  <timothy_horton@apple.com>
112
113         Implement Lookup transition from selection for Legacy WebKit
114         https://bugs.webkit.org/show_bug.cgi?id=139180
115         <rdar://problem/19067172>
116
117         Reviewed by Beth Dakin.
118
119         * WebView/DictionaryPopupInfo.h: Added.
120         Split DictionaryPopupInfo out into its own file.
121
122         * WebView/WebActionMenuController.mm:
123         (-[WebActionMenuController _lookupText:]):
124         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
125
126         (performDictionaryLookupForSelection):
127         (performDictionaryLookupForRange):
128         Plumb the transition style through these helpers.
129         Create a TextIndicator from the selection range.
130
131         * WebView/WebHTMLView.mm:
132         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
133         Make use of TextIndicator (and DictionaryPopupInfo, and the new
134         _showDictionaryLookupPopup on WebView) to add a transition from blue
135         when performing Lookup from the context menu.
136
137         (-[WebHTMLView quickLookWithEvent:]):
138         Remove our TextIndicator whenever a normal three-finger-tap event
139         comes through, as it will have its own indication.
140
141         * WebView/WebView.mm:
142         (-[WebView _commonInitializationWithFrameName:groupName:]):
143         (-[WebView _dictionaryLookupPopoverWillClose:]):
144         Register for the LUNotificationPopoverWillClose notification and remove
145         our TextIndicator when it is called, just like in WebKit2.
146         Deregistration is already handled in _close.
147
148         (-[WebView _showDictionaryLookupPopup:]):
149         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
150         if the relevant API is available.
151
152         * WebView/WebViewInternal.h:
153
154 2014-12-02  Anders Carlsson  <andersca@apple.com>
155
156         Remove visited link handling from PageGroup
157         https://bugs.webkit.org/show_bug.cgi?id=139185
158
159         Reviewed by Sam Weinig.
160
161         * History/WebHistory.mm:
162         (-[WebHistoryPrivate removeItemForURLString:]):
163         (-[WebHistoryPrivate removeAllItems]):
164         (+[WebHistory setOptionalSharedHistory:]):
165         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
166         (+[WebHistory _removeAllVisitedLinks]):
167         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
168         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
169         * History/WebHistoryInternal.h:
170         * WebCoreSupport/WebChromeClient.h:
171         * WebCoreSupport/WebChromeClient.mm:
172         (WebChromeClient::populateVisitedLinks): Deleted.
173         * WebView/WebView.mm:
174         (-[WebView addVisitedLinks:]):
175         (-[WebView removeVisitedLink:]):
176
177 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
178
179         Try to fix the Mac build.
180
181         * WebView/WebView.mm:
182         (-[WebView _commonInitializationWithFrameName:groupName:]):
183         (-[WebView _close]):
184
185 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
186
187         Fix the iOS build.
188
189         * WebView/WebActionMenuController.h:
190         * WebView/WebActionMenuController.mm:
191         * WebView/WebHTMLView.mm:
192         (-[WebHTMLView scrollWheel:scrollWheel:]):
193         (-[WebHTMLView mouseDown:mouseDown:]):
194         * WebView/WebView.mm:
195         * WebView/WebViewData.h:
196         * WebView/WebViewData.mm:
197         (-[WebViewPrivate dealloc]):
198         * WebView/WebViewInternal.h:
199
200 2014-12-01  Tim Horton  <timothy_horton@apple.com>
201
202         Implement yellow highlight for WebKit1 data detectors
203         https://bugs.webkit.org/show_bug.cgi?id=138956
204         <rdar://problem/18992185>
205
206         Reviewed by Beth Dakin.
207
208         * WebView/WebActionMenuController.h:
209         * WebView/WebActionMenuController.mm:
210         (-[WebActionMenuController webView:willHandleMouseDown:]):
211         (-[WebActionMenuController webView:didHandleScrollWheel:]):
212         (-[WebActionMenuController prepareForMenu:withEvent:]):
213         (-[WebActionMenuController didCloseMenu:withEvent:]):
214         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
215         (-[WebActionMenuController _showTextIndicator]):
216         (-[WebActionMenuController _hideTextIndicator]):
217         (-[WebActionMenuController _dismissActionMenuPopovers]):
218         Copy the WebKit2 WKActionMenuController TextIndicator implementation
219         into WebActionMenuController. The only significant difference is
220         that we build the TextIndicator right at menu construction time
221         instead of in the Web process.
222
223         * WebView/WebHTMLView.mm:
224         (-[WebHTMLView scrollWheel:]):
225         Let the WebActionMenuController know that we're handling a scroll.
226
227         (-[WebHTMLView mouseDown:]):
228         Let the WebActionMenuController know that we're handling a mouseDown.
229
230         * WebView/WebView.mm:
231         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
232         (-[WebView _clearTextIndicator]):
233         (-[WebView _actionMenuController]):
234         (-[WebView _convertRectFromRootView:]): Deleted.
235         * WebView/WebViewData.h:
236         * WebView/WebViewData.mm:
237         * WebView/WebViewInternal.h:
238         Keep a TextIndicatorWindow on WebView, just like WKView does.
239         Expose the WebActionMenuController on WebView (internally).
240
241 2014-12-01  Anders Carlsson  <andersca@apple.com>
242
243         Remove old site specific quirks code that was added in 2009
244         https://bugs.webkit.org/show_bug.cgi?id=139141
245
246         Reviewed by Antti Koivisto.
247
248         * WebCoreSupport/WebFrameNetworkingContext.h:
249         * WebCoreSupport/WebFrameNetworkingContext.mm:
250         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
251
252 2014-11-30  Anders Carlsson  <andersca@apple.com>
253
254         Fix a test failure.
255
256         * History/WebHistory.mm:
257         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
258         Call through to the visited link store.
259
260         (+[WebHistory _removeAllVisitedLinks]):
261         Ditto.
262
263         * WebCoreSupport/WebVisitedLinkStore.mm:
264         (WebVisitedLinkStore::isLinkVisited):
265         Make sure to populate visited links.
266
267 2014-11-30  Anders Carlsson  <andersca@apple.com>
268
269         Switch over to the visited link store from the WebViewGroup
270         https://bugs.webkit.org/show_bug.cgi?id=139112
271
272         Reviewed by Sam Weinig.
273
274         * WebView/WebView.mm:
275         (-[WebView _commonInitializationWithFrameName:groupName:]):
276         (-[WebView setGroupName:]):
277
278 2014-11-30  Anders Carlsson  <andersca@apple.com>
279
280         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
281         https://bugs.webkit.org/show_bug.cgi?id=139111
282
283         Reviewed by Sam Weinig.
284
285         * WebCoreSupport/WebVisitedLinkStore.h:
286         * WebCoreSupport/WebVisitedLinkStore.mm:
287         (WebVisitedLinkStore::removeVisitedLink):
288         * WebView/WebView.mm:
289         (-[WebView removeVisitedLink:]):
290
291 2014-11-29  Anders Carlsson  <andersca@apple.com>
292
293         Populate visited links
294         https://bugs.webkit.org/show_bug.cgi?id=139101
295
296         Reviewed by Sam Weinig.
297
298         * History/WebHistory.mm:
299         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
300         Helper function that adds all visited link to the given store.
301
302         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
303         Call the private method.
304
305         * History/WebHistoryInternal.h:
306         * WebCoreSupport/WebVisitedLinkStore.h:
307         Add new members.
308
309         * WebCoreSupport/WebVisitedLinkStore.mm:
310         (WebVisitedLinkStore::addVisitedLink):
311         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
312
313         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
314         Implement this. First try the delegate, then try the shared history.
315
316         (WebVisitedLinkStore::addVisitedLinkHash):
317         Factor code that adds the link to the hash table into a separate function.
318
319         * WebView/WebView.mm:
320         (-[WebView addVisitedLinks:]):
321         Add the visited links to the store.
322
323 2014-11-29  Anders Carlsson  <andersca@apple.com>
324
325         More work on the legacy WebKit visited link store
326         https://bugs.webkit.org/show_bug.cgi?id=139100
327
328         Reviewed by Sam Weinig.
329
330         * History/WebHistory.mm:
331         (+[WebHistory setOptionalSharedHistory:]):
332         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
333
334         * WebCoreSupport/WebVisitedLinkStore.h:
335         * WebCoreSupport/WebVisitedLinkStore.mm:
336         (visitedLinkStores):
337         (WebVisitedLinkStore::WebVisitedLinkStore):
338         (WebVisitedLinkStore::~WebVisitedLinkStore):
339         Keep track of live visited link stores.
340
341         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
342         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
343
344         (WebVisitedLinkStore::removeAllVisitedLinks):
345         Iterate over all live link stores and remove their links.
346
347         (WebVisitedLinkStore::isLinkVisited):
348         Populate visited links and check if our hash table contains the link.
349
350         (WebVisitedLinkStore::addVisitedLink):
351         Add the link hash to the table.
352
353         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
354         Add stub.
355
356         (WebVisitedLinkStore::removeVisitedLinkHashes):
357         Clear out the hash table.
358
359 2014-11-27  Anders Carlsson  <andersca@apple.com>
360
361         Add a stubbed out WebVisitedLinkStore to WebViewGroup
362         https://bugs.webkit.org/show_bug.cgi?id=139066
363
364         Reviewed by Antti Koivisto.
365
366         * WebCoreSupport/WebViewGroup.h:
367         (WebViewGroup::visitedLinkStore):
368         * WebCoreSupport/WebViewGroup.mm:
369         (WebViewGroup::WebViewGroup):
370         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
371         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
372         (WebVisitedLinkStore::create):
373         (WebVisitedLinkStore::WebVisitedLinkStore):
374         (WebVisitedLinkStore::~WebVisitedLinkStore):
375         (WebVisitedLinkStore::isLinkVisited):
376         (WebVisitedLinkStore::addVisitedLink):
377
378 2014-11-25  Anders Carlsson  <andersca@apple.com>
379
380         Remove user content handling from PageGroup
381         https://bugs.webkit.org/show_bug.cgi?id=139051
382
383         Reviewed by Antti Koivisto.
384
385         Use the user content controller in the web view group.
386
387         * WebView/WebView.mm:
388         (-[WebView _injectOutlookQuirksScript]):
389
390 2014-11-25  Anders Carlsson  <andersca@apple.com>
391
392         Add a user content controller to WebViewGroup and use it for user content
393         https://bugs.webkit.org/show_bug.cgi?id=139043
394
395         Reviewed by Antti Koivisto.
396
397         This is another tiny step towards getting rid of user content handling inside PageGroup.
398
399         * WebCoreSupport/WebViewGroup.h:
400         (WebViewGroup::userContentController):
401         Add a UserContentController member and getter.
402
403         * WebCoreSupport/WebViewGroup.mm:
404         (WebViewGroup::get):
405         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
406
407         (WebViewGroup::WebViewGroup):
408         Create a user content controller.
409
410         * WebView/WebView.mm:
411         (-[WebView _commonInitializationWithFrameName:groupName:]):
412         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
413         set its user content controller in the PageConfiguration.
414
415         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
416         Ditto.
417
418         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
419         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
420         (+[WebView _removeUserScriptFromGroup:world:url:]):
421         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
422         (+[WebView _removeUserScriptsFromGroup:world:]):
423         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
424         (+[WebView _removeAllUserContentFromGroup:]):
425         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
426
427         (-[WebView setGroupName:]):
428         Set the user content controller to the new WebViewGroup's user content controller.
429
430 2014-11-21  Jer Noble  <jer.noble@apple.com>
431
432         Support multiple signatures of diagnostic logging.
433         https://bugs.webkit.org/show_bug.cgi?id=138690
434
435         Reviewed by Anders Carlsson.
436
437         Page::PageClients has been renamed PageConfiguration.
438
439         * WebView/WebView.mm:
440         (-[WebView _commonInitializationWithFrameName:groupName:]):
441         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
442
443 2014-11-21  Zalan Bujtas  <zalan@apple.com>
444
445         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
446         https://bugs.webkit.org/show_bug.cgi?id=138981
447
448         Reviewed by Simon Fraser.
449
450         * WebView/WebPreferenceKeysPrivate.h:
451         * WebView/WebPreferences.mm:
452         (+[WebPreferences initialize]):
453         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
454         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
455         * WebView/WebPreferencesPrivate.h:
456         * WebView/WebView.mm:
457         (-[WebView _preferencesChanged:]):
458
459 2014-11-21  Tim Horton  <timothy_horton@apple.com>
460
461         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
462         ​https://bugs.webkit.org/show_bug.cgi?id=138960
463         <rdar://problem/19056715>
464
465         Reviewed by Anders Carlsson.
466
467         * WebView/WebActionMenuController.mm:
468         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
469         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
470         Use DataDetectors SPI instead of an explicit blacklist.
471
472 2014-11-21  Tim Horton  <timothy_horton@apple.com>
473
474         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
475         https://bugs.webkit.org/show_bug.cgi?id=138960
476         <rdar://problem/19056715>
477
478         Reviewed by Beth Dakin.
479
480         * WebView/WebActionMenuController.mm:
481         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
482         Blacklist contact results, because they don't have useful menus. If we
483         bail before setting up _currentActionContext, we'll still allow fallthrough
484         to ordinary text actions, avoiding mysterious failure when a contact is detected.
485
486         This doesn't break the case that r176351 was intended to fix,
487         because in that case we were detecting e.g. addresses.
488
489 2014-11-21  Anders Carlsson  <andersca@apple.com>
490
491         Remove the Timer parameters from timer callbacks
492         https://bugs.webkit.org/show_bug.cgi?id=138974
493
494         Reviewed by Antti Koivisto.
495
496         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
497         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
498         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
499         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
500         * Plugins/WebNetscapePluginStream.h:
501         * Plugins/WebNetscapePluginStream.mm:
502         (WebNetscapePluginStream::WebNetscapePluginStream):
503         (WebNetscapePluginStream::deliverDataTimerFired):
504
505 2014-11-21  Anders Carlsson  <andersca@apple.com>
506
507         Make memoryCache() return a reference
508         https://bugs.webkit.org/show_bug.cgi?id=138939
509
510         Reviewed by Antti Koivisto.
511
512         * Misc/WebCache.mm:
513         (+[WebCache statistics]):
514         (+[WebCache emptyInMemoryResources]):
515         (+[WebCache sizeOfDeadResources:]):
516         (+[WebCache addImageToCache:forURL:forFrame:]):
517         (+[WebCache removeImageFromCacheForURL:forFrame:]):
518         (+[WebCache imageForURL:]):
519         (+[WebCache setDisabled:]):
520         (+[WebCache isDisabled]):
521         * WebView/WebView.mm:
522         (+[WebView _setCacheModel:]):
523
524 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
525
526         Remove the remaining vestiges of minimal-ui
527         https://bugs.webkit.org/show_bug.cgi?id=138890
528
529         Reviewed by Sam Weinig.
530
531         * History/WebHistoryItem.mm:
532         * History/WebHistoryItemPrivate.h:
533
534 2014-11-20  Tim Horton  <timothy_horton@apple.com>
535
536         Cancel DataDetectors menu earlier if we know it can't be presented
537         https://bugs.webkit.org/show_bug.cgi?id=138922
538         <rdar://problem/18950441>
539
540         Reviewed by Beth Dakin.
541
542         * WebView/WebActionMenuController.mm:
543         (-[WebActionMenuController prepareForMenu:withEvent:]):
544         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
545         and use a bigger hammer (removeAllItems).
546
547         (-[WebActionMenuController willOpenMenu:withEvent:]):
548         If we end up with a menu with no items, don't change selection or anything.
549
550 2014-11-20  Beth Dakin  <bdakin@apple.com>
551
552         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
553         https://bugs.webkit.org/show_bug.cgi?id=138568
554         -and corresponding-
555         rdar://problem/18904600
556
557         Reviewed by Tim Horton.
558
559         Skip images for lookup.
560         * WebView/WebActionMenuController.mm:
561         (performDictionaryLookupForRange):
562
563 2014-11-19  Beth Dakin  <bdakin@apple.com>
564
565         Invoking an action menu on a selection should result in the text menu
566         https://bugs.webkit.org/show_bug.cgi?id=138892
567         -and corresponding-
568         rdar://problem/18996776
569
570         Reviewed by Tim Horton.
571
572         * WebView/WebActionMenuController.mm:
573         (-[WebActionMenuController _defaultMenuItems]):
574
575 2014-11-19  Beth Dakin  <bdakin@apple.com>
576
577         Data detected results with no menu items should not fall through to regular text 
578         action menus
579         https://bugs.webkit.org/show_bug.cgi?id=138887
580         -and corresponding-
581         rdar://problem/18971616
582
583         Reviewed by Tim Horton.
584
585         * WebView/WebActionMenuController.mm:
586         (-[WebActionMenuController _defaultMenuItems]):
587
588 2014-11-19  Daniel Bates  <dabates@apple.com>
589
590         [iOS] Make WebKit build with public iOS SDK
591         https://bugs.webkit.org/show_bug.cgi?id=136863
592
593         Reviewed by David Kilzer.
594
595         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
596         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
597         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
598         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
599         may be used by Apple internal clients that do not include wtf/Platform.h.
600         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
601         private Foundation headers directly.
602         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
603         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
604         instead of including private CFNetwork headers directly. Also fixed up style and
605         ordering of header include directives.
606         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
607         CFNetwork headers directly. Also sort the #import directives.
608         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
609         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
610
611 2014-11-18  David Kilzer  <ddkilzer@apple.com>
612
613         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
614         <http://webkit.org/b/138813>
615
616         Reviewed by Mark Rowe.
617
618         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
619         selectors.
620
621 2014-11-18  Chris Dumez  <cdumez@apple.com>
622
623         Add a setting to toggle DOMTimer throttling support
624         https://bugs.webkit.org/show_bug.cgi?id=138844
625         <rdar://problem/19020874>
626
627         Reviewed by Andreas Kling.
628
629         Add a setting to disable DOM timers throttling, in order to help
630         developers determine if a specific issue is caused by timer
631         throttling.
632
633         * WebView/WebPreferenceKeysPrivate.h:
634         * WebView/WebPreferences.mm:
635         (+[WebPreferences initialize]):
636         (-[WebPreferences domTimersThrottlingEnabled]):
637         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
638         * WebView/WebPreferencesPrivate.h:
639         * WebView/WebView.mm:
640         (-[WebView _preferencesChanged:]):
641
642 2014-11-18  Tim Horton  <timothy_horton@apple.com>
643
644         Avoid re-encoding action menu image data
645         https://bugs.webkit.org/show_bug.cgi?id=138817
646         <rdar://problem/18840382>
647
648         Reviewed by Anders Carlsson.
649
650         * WebView/WebActionMenuController.mm:
651         (-[WebActionMenuController _defaultMenuItemsForImage:]):
652         (-[WebActionMenuController _addImageToPhotos:]):
653         Build a temporary filename from a UUID and the image's desired extension.
654         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
655         Build an image menu only if we have an image, URL, data, and extension.
656
657 2014-11-18  Daniel Bates  <dabates@apple.com>
658
659         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
660         SPI are not available in public SDK
661         https://bugs.webkit.org/show_bug.cgi?id=138802
662
663         Reviewed by David Kilzer.
664
665         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
666         libdispatch and MobileGestalt headers directly.
667
668         * WebView/WebView.mm:
669
670 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
671
672         Remove calls to deprecated NSMenu methods
673         https://bugs.webkit.org/show_bug.cgi?id=138808.
674
675         Reviewed by Anders Carlsson.
676
677         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
678
679         * WebCoreSupport/PopupMenuMac.mm:
680         (PopupMenuMac::populate):
681
682 2014-11-17  Daniel Bates  <dabates@apple.com>
683
684         Unreviewed, rolling out r176232.
685
686         Broke the Mac build. Will investigate offline.
687
688         Reverted changeset:
689
690         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
691         MobileGestalt"
692         https://bugs.webkit.org/show_bug.cgi?id=138802
693         http://trac.webkit.org/changeset/176232
694
695 2014-11-17  Daniel Bates  <dabates@apple.com>
696
697         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
698         SPI are not available in public SDK
699         https://bugs.webkit.org/show_bug.cgi?id=138802
700
701         Reviewed by David Kilzer.
702
703         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
704         libdispatch and MobileGestalt headers directly.
705
706         * WebView/WebView.mm:
707
708 2014-11-17  Beth Dakin  <bdakin@apple.com>
709
710         Whitespace action menus should focus the HitTestResult and create an insertion 
711         point
712         https://bugs.webkit.org/show_bug.cgi?id=138786
713         -and corresponding-
714         rdar://problem/18944893
715
716         Reviewed by Tim Horton.
717
718         Whitespace menus should cause the HitTestResult to be focused, and they should set 
719         the selection based on the HitTest location.
720
721         * WebView/WebActionMenuController.mm:
722         (-[WebActionMenuController isMenuForTextContent]):
723         (-[WebActionMenuController focusAndSelectHitTestResult]):
724         (-[WebActionMenuController willOpenMenu:withEvent:]):
725
726 2014-11-17  Daniel Bates  <dabates@apple.com>
727
728         [iOS] QuartzCore SPI not available in public SDK
729         https://bugs.webkit.org/show_bug.cgi?id=138751
730
731         Reviewed by David Kilzer.
732
733         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
734
735         * WebInspector/WebNodeHighlight.mm:
736         * WebView/WebIndicateLayer.mm:
737
738 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
739
740         [iOS] allow host application to opt-out of alternate fullscreen
741         https://bugs.webkit.org/show_bug.cgi?id=138787
742
743         Reviewed by Darin Adler.
744
745         * WebView/WebPreferenceKeysPrivate.h:
746         * WebView/WebPreferences.mm:
747         (+[WebPreferences initialize]):
748         (-[WebPreferences allowsAlternateFullscreen]):
749         (-[WebPreferences setAllowsAlternateFullscreen:]):
750         * WebView/WebPreferencesPrivate.h:
751         * WebView/WebView.mm:
752         (-[WebView _preferencesChanged:]):
753
754 2014-11-16  Tim Horton  <timothy_horton@apple.com>
755
756         Use TextIndicator instead of the built in Lookup highlight
757         https://bugs.webkit.org/show_bug.cgi?id=138775
758         <rdar://problem/18953982>
759
760         Reviewed by Anders Carlsson.
761
762         * WebCoreSupport/WebSystemInterface.mm:
763         (InitWebCoreSystemInterface):
764         Remove a WKSI import.
765
766         * WebView/WebActionMenuController.mm:
767         (-[WebActionMenuController _lookupText:]):
768         (-[WebActionMenuController _createActionMenuItemForTag:]):
769         Make use of the new Lookup SPI header.
770         Disable the Lookup item if lookup is not available.
771
772 2014-11-15  Tim Horton  <timothy_horton@apple.com>
773
774         Implement data detectors and mailto action menus for WebKit1
775         https://bugs.webkit.org/show_bug.cgi?id=138765
776         <rdar://problem/18877535>
777
778         Reviewed by Beth Dakin.
779
780         * WebView/WebActionMenuController.h:
781         * WebView/WebActionMenuController.mm:
782         (-[WebActionMenuController willOpenMenu:withEvent:]):
783         Tell DataDetectors that the menu is going to open.
784         Select the text (or not) based on the number of items in the menu, just like WebKit2.
785
786         (-[WebActionMenuController didCloseMenu:withEvent:]):
787         Tell DataDetectors that the menu closed.
788
789         (-[WebActionMenuController _defaultMenuItemsForLink]):
790         Move these checks out of _defaultMenuItemsForLink, because we expect this
791         to always return a complete link menu.
792
793         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
794         Implement. More or less copied from WebKit2.
795
796         (-[WebActionMenuController _selectDataDetectedText]):
797         Select the stashed range.
798
799         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
800         Implement. More or less copied from WebKit2.
801         The yellow highlight isn't hooked up yet.
802         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
803
804         (-[WebActionMenuController _selectLookupText]):
805         Remove an unnecessary return.
806
807         (-[WebActionMenuController _defaultMenuItems]):
808         Call into the two new menu types.
809
810         * WebView/WebUIDelegatePrivate.h:
811
812 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
813
814         Get rid of WebFontCache
815         https://bugs.webkit.org/show_bug.cgi?id=134752
816
817         Reviewed by Dave Hyatt.
818
819         * WebView/WebHTMLView.mm:
820
821 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
822
823         Update some artwork for the legacy WebKit action menu
824         https://bugs.webkit.org/show_bug.cgi?id=138758
825         <rdar://problem/18989840>
826
827         * WebView/WebActionMenuController.mm:
828         (webKitBundleImageNamed): Deleted.
829         Fix the build.
830
831 2014-11-14  Tim Horton  <timothy_horton@apple.com>
832
833         Update some artwork for the legacy WebKit action menu
834         https://bugs.webkit.org/show_bug.cgi?id=138758
835         <rdar://problem/18989840>
836
837         Reviewed by Simon Fraser.
838
839         * WebView/WebActionMenuController.mm:
840         (-[WebActionMenuController _createActionMenuItemForTag:]):
841
842 2014-11-14  Daniel Bates  <dabates@apple.com>
843
844         [iOS] NSFileManager and QuickLook SPI not available in public SDK
845         https://bugs.webkit.org/show_bug.cgi?id=138742
846
847         Reviewed by Pratik Solanki.
848
849         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
850
851         * WebCoreSupport/WebFrameLoaderClient.mm:
852
853 2014-11-14  Beth Dakin  <bdakin@apple.com>
854
855         WK1: Webpage preview can come up in wrong location
856         https://bugs.webkit.org/show_bug.cgi?id=138747
857         -and corresponding-
858         rdar://problem/18979004
859
860         Reviewed by Tim Horton.
861
862         Converting to window twice is bad.
863         * WebView/WebActionMenuController.mm:
864         (elementBoundingBoxInWindowCoordinatesFromNode):
865         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
866         (elementBoundingBoxFromNode): Deleted.
867
868 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
869
870         Move FontMac and FontCacheMac off of WKSI
871         https://bugs.webkit.org/show_bug.cgi?id=138633
872
873         Reviewed by Simon Fraser.
874
875         * WebCoreSupport/WebSystemInterface.mm:
876         (InitWebCoreSystemInterface):
877         * WebKit.order:
878
879 2014-11-13  Beth Dakin  <bdakin@apple.com>
880
881         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
882         https://bugs.webkit.org/show_bug.cgi?id=138716
883         -and corresponding-
884         rdar://problem/18977222
885
886         Reviewed by Tim Horton.
887
888         It’s not necessary to use the WebElementDictionary for so many things now that we 
889         are caching the HitTestResult. We should just use the HitTestResult.
890
891         * WebView/WebActionMenuController.mm:
892         (-[WebActionMenuController prepareForMenu:withEvent:]):
893         (-[WebActionMenuController _openURLFromActionMenu:]):
894         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
895         (elementBoundingBoxFromNode):
896         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
897         (-[WebActionMenuController _defaultMenuItemsForLink]):
898         (-[WebActionMenuController _defaultMenuItemsForImage]):
899         (-[WebActionMenuController _defaultMenuItemsForVideo]):
900         (-[WebActionMenuController _defaultMenuItemsForText]):
901         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
902         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
903         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
904         (-[WebActionMenuController _createActionMenuItemForTag:]):
905         (-[WebActionMenuController _defaultMenuItems]):
906         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
907         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
908         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
909         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
910         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
911         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
912         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
913         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
914         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
915         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
916
917 2014-11-13  Daniel Bates  <dabates@apple.com>
918
919         [iOS] NSGeometry data types are not available in the public SDK
920         https://bugs.webkit.org/show_bug.cgi?id=137536
921
922         Reviewed by David Kilzer.
923
924         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
925         private header.
926
927         * DOM/WebDOMOperationsPrivate.h:
928
929 2014-11-13  Beth Dakin  <bdakin@apple.com>
930
931         WK1: Support default actions for video
932         https://bugs.webkit.org/show_bug.cgi?id=138713
933         -and corresponding-
934         rdar://problem/18877520
935
936         Reviewed by Tim Horton.
937
938         Call setToNonShadowAncestor() for media HitTestResults.
939         * WebView/WebActionMenuController.mm:
940         (-[WebActionMenuController performHitTestAtPoint:]):
941
942         Default items and actions.
943         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
944         (-[WebActionMenuController _copyVideoURL:]):
945         (-[WebActionMenuController _saveVideoToDownloads:]):
946         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
947         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
948         * WebView/WebUIDelegatePrivate.h:
949
950 2014-11-13  Tim Horton  <timothy_horton@apple.com>
951
952         WK1: Update icon for Add to Reading List
953         https://bugs.webkit.org/show_bug.cgi?id=138710
954         <rdar://problem/18975774>
955
956         Reviewed by Beth Dakin.
957
958         * WebView/WebActionMenuController.mm:
959         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
960         Use the right icon, matching WebKit2.
961
962 2014-11-12  Beth Dakin  <bdakin@apple.com>
963
964         WK1: Support default actions for images
965         https://bugs.webkit.org/show_bug.cgi?id=138668
966         -and corresponding-
967         rdar://problem/18785434
968
969         Reviewed by Tim Horton.
970
971         * WebView/WebActionMenuController.h:
972         * WebView/WebActionMenuController.mm:
973         (-[WebActionMenuController didCloseMenu:withEvent:]):
974         (-[WebActionMenuController _defaultMenuItemsForImage:]):
975         (-[WebActionMenuController _copyImage:]):
976         (temporaryPhotosDirectoryPath):
977         (pathToPhotoOnDisk):
978         (-[WebActionMenuController _canAddMediaToPhotos]):
979         (-[WebActionMenuController _addImageToPhotos:]):
980         (-[WebActionMenuController _saveImageToDownloads:]):
981         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
982         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
983         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
984         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
985         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
986         * WebView/WebUIDelegatePrivate.h:
987
988 2014-11-11  Beth Dakin  <bdakin@apple.com>
989
990         Action menu hit testing is not working properly with all WK1 apps
991         https://bugs.webkit.org/show_bug.cgi?id=138643
992         -and corresponding-
993         rdar://problem/18949376
994
995         Reviewed by Tim Horton.
996
997         * WebView/WebActionMenuController.mm:
998         (-[WebActionMenuController prepareForMenu:withEvent:]):
999         (-[WebActionMenuController _lookupText:]):
1000
1001 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1002
1003         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
1004         https://bugs.webkit.org/show_bug.cgi?id=138623
1005
1006         Reviewed by Geoff Garen.
1007
1008         * WebCoreSupport/WebSystemInterface.mm:
1009         (InitWebCoreSystemInterface):
1010         * WebKit.order:
1011
1012 2014-11-11  Tim Horton  <timothy_horton@apple.com>
1013
1014         Localize strings for action menus
1015         https://bugs.webkit.org/show_bug.cgi?id=138591
1016         <rdar://problem/18815343>
1017
1018         Reviewed by Dan Bates.
1019
1020         * WebView/WebActionMenuController.mm:
1021         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1022         Make use of the new strings.
1023
1024 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1025
1026         Cleanup from r175379
1027         https://bugs.webkit.org/show_bug.cgi?id=138616
1028
1029         Reviewed by Simon Fraser.
1030
1031         * WebCoreSupport/WebSystemInterface.mm:
1032         (InitWebCoreSystemInterface):
1033         * WebKit.order:
1034
1035 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1036
1037         Move CTFontTransformGlyphs out from WKSI
1038         https://bugs.webkit.org/show_bug.cgi?id=138599
1039
1040         Reviewed by Simon Fraser.
1041
1042         * WebCoreSupport/WebSystemInterface.mm:
1043         (InitWebCoreSystemInterface):
1044         * WebKit.order:
1045
1046 2014-11-11  Dan Bernstein  <mitz@apple.com>
1047
1048         More iOS build fix.
1049
1050         * WebView/WebHTMLViewInternal.h:
1051
1052 2014-11-11  Dan Bernstein  <mitz@apple.com>
1053
1054         iOS build fix.
1055
1056         * WebView/WebHTMLView.mm:
1057
1058 2014-11-10  Beth Dakin  <bdakin@apple.com>
1059
1060         WK1: Support default actions for editable text with misspelled word
1061         https://bugs.webkit.org/show_bug.cgi?id=138590
1062         -and corresponding-
1063         rdar://problem/18877506
1064
1065         Reviewed by Tim Horton.
1066
1067         If there are misspelled word suggestions for editable text, create a new type of 
1068         menu with a spelling suggestion sub-menu.
1069
1070         * WebView/WebActionMenuController.mm:
1071         (-[WebActionMenuController isMenuForTextContent]):
1072         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
1073         (-[WebActionMenuController _changeSelectionToSuggestion:]):
1074         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1075         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1076         * WebView/WebHTMLView.mm:
1077         (-[WebHTMLView _changeSpellingToWord:]):
1078         * WebView/WebHTMLViewInternal.h:
1079         * WebView/WebUIDelegatePrivate.h:
1080
1081 2014-11-10  Beth Dakin  <bdakin@apple.com>
1082
1083         WK1: Support default actions for editable whitespace
1084         https://bugs.webkit.org/show_bug.cgi?id=138586
1085         -and corresponding-
1086         rdar://problem/18932048
1087
1088         Reviewed by Tim Horton.
1089
1090         New menu type. Just wants paste.
1091
1092         * WebView/WebActionMenuController.mm:
1093         (-[WebActionMenuController isMenuForTextContent]):
1094         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
1095         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1096         * WebView/WebUIDelegatePrivate.h:
1097
1098 2014-11-10  Beth Dakin  <bdakin@apple.com>
1099
1100         WK1: Support default actions for editable text
1101         https://bugs.webkit.org/show_bug.cgi?id=138580
1102         -and corresponding-
1103         rdar://problem/18877497
1104
1105         Reviewed by Tim Horton.
1106
1107         New menu type, and new action type for paste. 
1108
1109         * WebView/WebActionMenuController.mm:
1110         (-[WebActionMenuController isMenuForTextContent]):
1111         (-[WebActionMenuController willOpenMenu:withEvent:]):
1112         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
1113         (-[WebActionMenuController _paste:]):
1114         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1115         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1116         * WebView/WebUIDelegatePrivate.h:
1117
1118 2014-11-10  Beth Dakin  <bdakin@apple.com>
1119
1120         WK1: Text is getting selected even when an action menu fails to invoke
1121         https://bugs.webkit.org/show_bug.cgi?id=138576
1122         -and corresponding-
1123         rdar://problem/18931330
1124
1125         Reviewed by Tim Horton.
1126
1127         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
1128         * WebView/WebActionMenuController.h:
1129         * WebView/WebActionMenuController.mm:
1130         (-[WebActionMenuController prepareForMenu:withEvent:]):
1131         (-[WebActionMenuController willOpenMenu:withEvent:]):
1132
1133         _selectLookupText no longer needs to return a BOOL indicating success or failure.
1134         (-[WebActionMenuController _selectLookupText]):
1135         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1136
1137         Pass willOpenMenu: on to the controller.
1138         * WebView/WebView.mm:
1139         (-[WebView willOpenMenu:withEvent:]):
1140
1141 2014-11-10  Beth Dakin  <bdakin@apple.com>
1142
1143         Speculative build fix.
1144
1145         * WebView/WebActionMenuController.mm:
1146
1147 2014-11-10  Beth Dakin  <bdakin@apple.com>
1148
1149         Action menu initialization should be moved to _commonInitializationWithFrameName
1150         https://bugs.webkit.org/show_bug.cgi?id=138572
1151         -and corresponding-
1152         rdar://problem/18929733
1153
1154         Reviewed by Tim Horton.
1155
1156         * WebView/WebView.mm:
1157         (-[WebView _commonInitializationWithFrameName:groupName:]):
1158         (-[WebView _initWithFrame:frameName:groupName:]):
1159
1160 2014-11-10  Beth Dakin  <bdakin@apple.com>
1161
1162         WK1: Support default actions for read-only text
1163         https://bugs.webkit.org/show_bug.cgi?id=138552
1164         -and corresponding-
1165         rdar://problem/18877483
1166
1167         Reviewed by Tim Horton.
1168
1169         New WKSystemInterface functions that WebCore needs to use.
1170         * WebCoreSupport/WebSystemInterface.mm:
1171         (InitWebCoreSystemInterface):
1172
1173         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
1174         makes a lot of things easier.
1175         * WebView/WebActionMenuController.h:
1176         * WebView/WebActionMenuController.mm:
1177
1178         Perform the hit test ourselves instead of calling into WebView so that we can more 
1179         easily save the WebCore::HitTestResult for ourselves.
1180         (-[WebActionMenuController performHitTestAtPoint:]):
1181
1182         Clear selection for non-text menus.
1183         (-[WebActionMenuController prepareForMenu:withEvent:]):
1184
1185         Re-set the _type here just to be safe.
1186         (-[WebActionMenuController didCloseMenu:withEvent:]):
1187
1188         Moving this method to be next to the link actions so they can be within a pragma 
1189         mark.
1190         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1191
1192         New method for default text actions — lookup and copy.
1193         (-[WebActionMenuController _defaultMenuItemsForText:]):
1194         (-[WebActionMenuController _copySelection:]):
1195         (-[WebActionMenuController _lookupText:]):
1196
1197         If there is not already a selection, invoking the action menu on text should 
1198         select the lookup text.
1199         (-[WebActionMenuController _selectLookupText]):
1200         (performDictionaryLookupForSelection):
1201         (performDictionaryLookupForRange):
1202
1203         Handle text now.
1204         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1205         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1206
1207         New enum values.
1208         * WebView/WebUIDelegatePrivate.h:
1209
1210         Pass didCloseMenu on to the controller.
1211         * WebView/WebView.mm:
1212         (-[WebView didCloseMenu:withEvent:]):
1213
1214 2014-11-09  Chris Dumez  <cdumez@apple.com>
1215
1216         Add a more correct way to compare floating point numbers and use it
1217         https://bugs.webkit.org/show_bug.cgi?id=138527
1218
1219         Reviewed by Darin Adler.
1220
1221         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
1222         to compare floating-point numbers.
1223
1224         * WebView/WebHTMLView.mm:
1225         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
1226
1227 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1228
1229         Delete cookies between tests
1230         https://bugs.webkit.org/show_bug.cgi?id=138528
1231
1232         Reviewed by Sam Weinig.
1233
1234         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
1235         * WebView/WebPreferencesPrivate.h:
1236         Added an SPI for DumpRenderTree.
1237
1238 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
1239
1240         [iOS] Update optimized fullscreen media controls
1241         https://bugs.webkit.org/show_bug.cgi?id=138493
1242
1243         Reviewed by Brent Fulgham.
1244
1245         * WebCoreSupport/WebSystemInterface.mm:
1246         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
1247
1248 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
1249
1250         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
1251         https://bugs.webkit.org/show_bug.cgi?id=138443
1252
1253         Reviewed by Anders Carlsson.
1254
1255         Wrapping the dealloc method in its own autorelease pool avoids the problem of
1256         complex tear-downs leading to the WebView itself being added to an autorelease
1257         pool that is not drained until after the instance has been dealloc'd.
1258  
1259         * WebView/WebView.mm:
1260         (-[WebView dealloc]):
1261
1262 2014-11-05  Jer Noble  <jer.noble@apple.com>
1263
1264         De-templatize Timer
1265         https://bugs.webkit.org/show_bug.cgi?id=138450
1266
1267         Reviewed by Anders Carlsson.
1268
1269         Remove template specifiers from Timer.
1270
1271         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1272         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1273         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1274         * Plugins/WebNetscapePluginStream.h:
1275         * Plugins/WebNetscapePluginStream.mm:
1276         (WebNetscapePluginStream::deliverDataTimerFired):
1277
1278 2014-11-05  Dan Bernstein  <mitz@apple.com>
1279
1280         Remove the unused deletion UI feature
1281         https://bugs.webkit.org/show_bug.cgi?id=138442
1282
1283         Rubber-stamped by Alexey Proskuryakov.
1284
1285         * DefaultDelegates/WebDefaultEditingDelegate.m:
1286         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
1287         * WebCoreSupport/WebEditorClient.h:
1288         * WebCoreSupport/WebEditorClient.mm:
1289         (WebEditorClient::shouldShowDeleteInterface): Deleted.
1290         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
1291         -webView:shouldShowDeleteInterfaceForElement:.
1292
1293 2014-11-03  Dean Jackson  <dino@apple.com>
1294
1295         Add ENABLE_FILTERS_LEVEL_2 feature guard.
1296         https://bugs.webkit.org/show_bug.cgi?id=138362
1297
1298         Reviewed by Tim Horton.
1299
1300         Add a new feature define for Level 2 of CSS Filters.
1301         http://dev.w3.org/fxtf/filters-2/
1302
1303         * Configurations/FeatureDefines.xcconfig:
1304
1305 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
1306
1307         Add button and enable optimized fullscreen.
1308         https://bugs.webkit.org/show_bug.cgi?id=138351
1309
1310         Reviewed by Eric Carlson.
1311
1312         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
1313
1314         * WebCoreSupport/WebSystemInterface.mm:
1315         (InitWebCoreSystemInterface): added
1316
1317 2014-11-04  Chris Dumez  <cdumez@apple.com>
1318
1319         Add ptr() method to Ref class
1320         https://bugs.webkit.org/show_bug.cgi?id=138361
1321
1322         Reviewed by Darin Adler.
1323
1324         Use the new Ref::ptr() method.
1325
1326         * WebView/WebFrame.mm:
1327         (-[WebFrame _setTypingStyle:withUndoAction:]):
1328         * WebView/WebHTMLView.mm:
1329         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
1330         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
1331         * WebView/WebView.mm:
1332         (-[WebView applyStyle:]):
1333
1334 2014-11-04  Darin Adler  <darin@apple.com>
1335
1336         Eliminate ResourceBuffer and use SharedBuffer directly instead
1337         https://bugs.webkit.org/show_bug.cgi?id=138174
1338
1339         Reviewed by Antti Koivisto.
1340
1341         * WebView/WebDataSource.mm:
1342         (-[WebDataSource data]): Use SharedBuffer directly.
1343         * WebView/WebHTMLView.mm:
1344         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1345
1346 2014-11-03  Commit Queue  <commit-queue@webkit.org>
1347
1348         Unreviewed, rolling out r175406, r175413, and r175423.
1349         https://bugs.webkit.org/show_bug.cgi?id=138327
1350
1351         Multipart tests are still broken (Requested by ap on #webkit).
1352
1353         Reverted changesets:
1354
1355         "Eliminate ResourceBuffer and use SharedBuffer directly
1356         instead"
1357         https://bugs.webkit.org/show_bug.cgi?id=138174
1358         http://trac.webkit.org/changeset/175406
1359
1360         "Unreviewed, iOS build fix since 175406."
1361         http://trac.webkit.org/changeset/175413
1362
1363         "Fix assertion in CachedResource::addDataBuffer"
1364         http://trac.webkit.org/changeset/175423
1365
1366 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1367
1368         Use std::unique_ptr for TypeCountSet
1369         https://bugs.webkit.org/show_bug.cgi?id=138242
1370
1371         Reviewed by Andreas Kling.
1372
1373         * Misc/WebCoreStatistics.mm:
1374         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
1375         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
1376
1377 2014-10-31  Beth Dakin  <bdakin@apple.com>
1378
1379         Use system art for action menus when possible
1380         https://bugs.webkit.org/show_bug.cgi?id=138260
1381
1382         Reviewed by Tim Horton.
1383
1384         * WebView/WebActionMenuController.mm:
1385         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1386
1387 2014-10-30  Darin Adler  <darin@apple.com>
1388
1389         Eliminate ResourceBuffer and use SharedBuffer directly instead
1390         https://bugs.webkit.org/show_bug.cgi?id=138174
1391
1392         Reviewed by Antti Koivisto.
1393
1394         * WebView/WebDataSource.mm:
1395         (-[WebDataSource data]): Use SharedBuffer directly.
1396         * WebView/WebHTMLView.mm:
1397         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1398
1399 2014-10-30  Jer Noble  <jer.noble@apple.com>
1400
1401         [EME] Add Setting for accessing storage location for MediaKeys data
1402         https://bugs.webkit.org/show_bug.cgi?id=138147
1403
1404         Reviewed by Brady Eidson.
1405
1406         * WebView/WebPreferenceKeysPrivate.h:
1407         * WebView/WebPreferences.mm:
1408         (+[WebPreferences initialize]): Set default location.
1409         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
1410         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
1411         * WebView/WebPreferencesPrivate.h:
1412         * WebView/WebView.mm:
1413         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
1414
1415 2014-10-30  Dana Burkart  <dburkart@apple.com>
1416
1417         <rdar://problem/18821260> Prepare for the mysterious future
1418
1419         Reviewed by Lucas Forschler.
1420
1421         * Configurations/Base.xcconfig:
1422         * Configurations/DebugRelease.xcconfig:
1423         * Configurations/FeatureDefines.xcconfig:
1424         * Configurations/Version.xcconfig:
1425
1426 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
1427
1428         Add optimized fullscreen mode.
1429         https://bugs.webkit.org/show_bug.cgi?id=138044
1430
1431         Reviewed by Jer Noble.
1432
1433         Enable different types of fullscreen video behavior.
1434         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
1435
1436         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
1437         * WebCoreSupport/WebChromeClient.mm:
1438         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
1439         * WebView/WebView.mm:
1440         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
1441         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
1442         * WebView/WebViewInternal.h: ditto
1443
1444 2014-10-27  Beth Dakin  <bdakin@apple.com>
1445
1446         Provide a way for WebKit1 clients to override default action menu items
1447         https://bugs.webkit.org/show_bug.cgi?id=138066
1448         -and corresponding-
1449         rdar://problem/18451638
1450
1451         Reviewed by Anders Carlsson.
1452
1453         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
1454         send that along to clients customizing the menu.
1455         * WebView/WebActionMenuController.h:
1456         * WebView/WebActionMenuController.mm:
1457         (-[WebActionMenuController prepareForMenu:withEvent:]):
1458         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1459
1460         New enum and new SPI to customize menus.
1461         * WebView/WebUIDelegatePrivate.h:
1462
1463 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
1464
1465         Fix the iOS build
1466
1467         * Configurations/WebKitLegacy.xcconfig:
1468         * WebView/WebView.mm:
1469
1470 2014-10-24  Beth Dakin  <bdakin@apple.com>
1471
1472         Build fix.
1473
1474         * WebView/WebActionMenuController.mm:
1475         (-[WebActionMenuController _openURLFromActionMenu:]):
1476         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1477         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1478
1479 2014-10-24  Beth Dakin  <bdakin@apple.com>
1480
1481         WebKit1 should support action menus
1482         https://bugs.webkit.org/show_bug.cgi?id=138032
1483
1484         Reviewed by Tim Horton.
1485
1486         This patch adds basic support for action menus and adds actions for links.
1487
1488         Helper class takes care of all of the action menu work. WebView will forward the 
1489         prepareForMenu: message, and then the helper class takes it from there.
1490         * WebView/WebActionMenuController.h: Added.
1491         * WebView/WebActionMenuController.mm: Added.
1492         (-[WebActionMenuController webViewClosed]):
1493         (-[WebActionMenuController prepareForMenu:withEvent:]):
1494
1495         Selectors for link actions.
1496         (-[WebActionMenuController _openURLFromActionMenu:]):
1497         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1498         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
1499         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1500         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1501         (webKitBundleImageNamed):
1502         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1503         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1504
1505         Tags for the action menu items.
1506         * WebView/WebUIDelegatePrivate.h:
1507         * WebView/WebView.mm:
1508
1509         Set the action menu if possible and create the controller.
1510         (-[WebView _initWithFrame:frameName:groupName:]):
1511         (-[WebView _close]):
1512         (-[WebView prepareForMenu:withEvent:]):
1513
1514         WebViewData stores the WebActionMenuHelper
1515         * WebView/WebViewData.h:
1516         * WebView/WebViewData.mm:
1517         (-[WebViewPrivate dealloc]):
1518
1519 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
1520
1521         Web Inspector: Provide a way to have alternate inspector agents
1522         https://bugs.webkit.org/show_bug.cgi?id=137901
1523
1524         Reviewed by Brian Burg.
1525
1526         * Configurations/FeatureDefines.xcconfig:
1527
1528 2014-10-23  Tim Horton  <timothy_horton@apple.com>
1529
1530         Add some SPI headers for NSExtension and NSSharingService{Picker}
1531         https://bugs.webkit.org/show_bug.cgi?id=138027
1532
1533         Reviewed by Anders Carlsson.
1534
1535         * Misc/WebSharingServicePickerController.h:
1536         * Misc/WebSharingServicePickerController.mm:
1537         * WebCoreSupport/WebSelectionServiceController.mm:
1538         * WebCoreSupport/WebContextMenuClient.mm:
1539         Fix a sorting issue.
1540         Replace redefinitions with SPI header #imports.
1541
1542 2014-10-23  Tim Horton  <timothy_horton@apple.com>
1543
1544         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
1545         https://bugs.webkit.org/show_bug.cgi?id=138013
1546
1547         Reviewed by Dan Bernstein.
1548
1549         * WebCoreSupport/WebSelectionServiceController.mm:
1550         (WebSelectionServiceController::hasRelevantSelectionServices):
1551         Don't adopt this autoreleased object.
1552
1553 2014-10-22  Chris Dumez  <cdumez@apple.com>
1554
1555         [Mac][WK2] Fix applicationIsSafari() detection
1556         https://bugs.webkit.org/show_bug.cgi?id=137893
1557
1558         Reviewed by Alexey Proskuryakov.
1559
1560         Provide an implementation for FrameLoaderClient's new
1561         needsQuickLookResourceCachingQuirks() that returns
1562         a static flag initialized using
1563         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
1564
1565         * WebCoreSupport/WebFrameLoaderClient.h:
1566         * WebCoreSupport/WebFrameLoaderClient.mm:
1567
1568 2014-10-20  Chris Dumez  <cdumez@apple.com>
1569
1570         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
1571         https://bugs.webkit.org/show_bug.cgi?id=137797
1572
1573         Reviewed by Darin Adler.
1574
1575         Call ResourceRequest::setDomainForPartitionName() instead of
1576         setPartitionName() as the argument is a domain, not a valid
1577         partition name.
1578
1579         * Misc/WebCache.mm:
1580         (+[WebCache addImageToCache:forURL:forFrame:]):
1581         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1582
1583 2014-10-20  Andy Estes  <aestes@apple.com>
1584
1585         Fix the iOS build.
1586
1587         * WebView/WebFrame.mm:
1588         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1589         (-[WebFrame dictationResultMetadataForRange:]):
1590
1591 2014-10-19  Chris Dumez  <cdumez@apple.com>
1592
1593         Use is<>() / downcast<>() for all remaining RenderObject subclasses
1594         https://bugs.webkit.org/show_bug.cgi?id=137845
1595
1596         Reviewed by Darin Adler.
1597
1598         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
1599         clean up the surrounding code.
1600
1601         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1602         (-[WebHostedNetscapePluginView pluginHostDied]):
1603         * Plugins/WebBaseNetscapePluginView.mm:
1604         (-[WebBaseNetscapePluginView _windowClipRect]):
1605         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
1606         * WebCoreSupport/WebFrameLoaderClient.mm:
1607         (WebFrameLoaderClient::createPlugin):
1608         (WebFrameLoaderClient::createJavaAppletWidget):
1609
1610 2014-10-17  Tim Horton  <timothy_horton@apple.com>
1611
1612         Build fix for 32-bit Yosemite
1613
1614         * WebCoreSupport/WebContextMenuClient.mm:
1615         (WebContextMenuClient::contextMenuForEvent):
1616         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
1617
1618 2014-10-17  Chris Dumez  <cdumez@apple.com>
1619
1620         Use is<>() / downcast<>() for RenderBox
1621         https://bugs.webkit.org/show_bug.cgi?id=137804
1622
1623         Reviewed by Andreas Kling.
1624
1625         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
1626         code.
1627
1628         * WebCoreSupport/WebContextMenuClient.mm:
1629         (WebContextMenuClient::clientFloatRectForNode):
1630         * WebView/WebFrame.mm:
1631         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
1632
1633 2014-10-17  Tim Horton  <timothy_horton@apple.com>
1634
1635         Fix the build with the public SDK.
1636
1637         * WebCoreSupport/WebSelectionServiceController.mm:
1638         We should transition all this SPI to real SPI headers as soon as possible.
1639
1640 2014-10-16  Tim Horton  <timothy_horton@apple.com>
1641
1642         Implement selection services menu for Legacy WebKit
1643         https://bugs.webkit.org/show_bug.cgi?id=137582
1644         <rdar://problem/18604241>
1645
1646         Reviewed by Brady Eidson.
1647
1648         * Misc/WebSharingServicePickerController.h:
1649         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
1650         Add WebSharingServicePickerClient, which other classes can implement
1651         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
1652         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
1653
1654         * Misc/WebSharingServicePickerController.mm:
1655         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
1656
1657         (-[WebSharingServicePickerController clear]):
1658         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
1659         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
1660         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
1661         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
1662         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1663         Make use of WebSharingServicePickerClient.
1664
1665         (-[WebSharingServicePickerController sharingService:didShareItems:]):
1666         If we're returned a NSAttributedString, paste it on top of the current selection,
1667         similar to what the WebKit2 implementation currently does.
1668         
1669         * WebCoreSupport/WebChromeClient.h:
1670         * WebCoreSupport/WebChromeClient.mm:
1671         (WebChromeClient::handleTelephoneNumberClick):
1672         (WebChromeClient::handleSelectionServiceClick):
1673         (WebChromeClient::hasRelevantSelectionServices):
1674         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
1675
1676         * WebCoreSupport/WebContextMenuClient.h:
1677         * WebCoreSupport/WebContextMenuClient.mm:
1678         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
1679         (WebContextMenuClient::pageForSharingServicePicker):
1680         (WebContextMenuClient::windowForSharingServicePicker):
1681         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
1682         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1683         (WebContextMenuClient::contextMenuForEvent):
1684         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
1685         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
1686         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
1687         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
1688         having WebSharingServicePickerController tightly bound to it.
1689         Make an NSItemProvider array when instantiating WebSharingServicePickerController
1690         instead of handing it data directly.
1691
1692         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
1693         * WebCoreSupport/WebSelectionServiceController.mm: Added.
1694         (WebSelectionServiceController::WebSelectionServiceController):
1695         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
1696         for selection services.
1697
1698         (WebSelectionServiceController::handleSelectionServiceClick):
1699         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
1700
1701         (hasCompatibleServicesForItems):
1702         (WebSelectionServiceController::hasRelevantSelectionServices):
1703         Determine whether or not services are available.
1704
1705         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
1706         (WebSelectionServiceController::pageForSharingServicePicker):
1707         (WebSelectionServiceController::windowForSharingServicePicker):
1708         Implement the rest of the WebSharingServicePickerClient overrides.
1709
1710         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
1711         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
1712         These are only useful for image sharing services, so we don't need to
1713         implement them (WebContextMenuClient does, on the other hand).
1714
1715         * WebView/WebView.mm:
1716         (-[WebView _selectionServiceController]):
1717         * WebView/WebViewData.h:
1718         * WebView/WebViewData.mm:
1719         * WebView/WebViewInternal.h:
1720         Keep a WebSelectionServiceController.
1721
1722 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
1723
1724         Improve debug description of WAKViews
1725         https://bugs.webkit.org/show_bug.cgi?id=137716
1726
1727         Reviewed by Simon Fraser.
1728
1729         * WebView/WebView.mm:
1730         (-[WebView _touchEventRegions]): Adding a comment.
1731
1732 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
1733
1734         Addressing post-review comment.
1735         https://bugs.webkit.org/show_bug.cgi?id=137550
1736
1737         Unreviewed.
1738
1739         * WebView/WebHTMLView.mm:
1740         (fontNameForDescription):
1741         (-[WebHTMLView _addToStyle:fontA:fontB:]):
1742
1743 2014-10-14  Chris Dumez  <cdumez@apple.com>
1744
1745         Use is<>() / downcast<>() for RenderImage
1746         https://bugs.webkit.org/show_bug.cgi?id=137683
1747
1748         Reviewed by Mihnea Ovidenie.
1749
1750         Use is<>() / downcast<>() for RenderImage.
1751
1752         * Misc/WebNSPasteboardExtras.mm:
1753         (imageFromElement):
1754         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1755
1756 2014-10-10  Daniel Bates  <dabates@apple.com>
1757
1758         Remove unused classes WebRender{Node, Layer}
1759         https://bugs.webkit.org/show_bug.cgi?id=137628
1760
1761         Reviewed by Simon Fraser.
1762
1763         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
1764         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
1765
1766         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
1767         of excluded source files when building for iOS.
1768         * WebKit.exp: Remove symbol for WebRenderLayer.
1769         * WebKit.mac.exp: Remove symbol for WebRenderNode.
1770         * WebView/WebRenderLayer.h: Removed.
1771         * WebView/WebRenderLayer.mm: Removed.
1772         * WebView/WebRenderNode.h: Removed.
1773         * WebView/WebRenderNode.mm: Removed.
1774
1775 2014-10-10  Chris Dumez  <cdumez@apple.com>
1776
1777         Use is<>() / downcast<>() for RenderBoxModelObject
1778         https://bugs.webkit.org/show_bug.cgi?id=137587
1779
1780         Reviewed by Mihnea Ovidenie.
1781
1782         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
1783         surrounding code.
1784
1785         * Plugins/WebBaseNetscapePluginView.mm:
1786         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
1787         * WebView/WebRenderLayer.mm:
1788         (-[WebRenderLayer initWithWebFrame:]):
1789
1790 2014-10-09  Dean Jackson  <dino@apple.com>
1791
1792         Remove ENABLE_CSS3_CONDITIONAL_RULES
1793         https://bugs.webkit.org/show_bug.cgi?id=137571
1794
1795         Reviewed by Simon Fraser.
1796
1797         * Configurations/FeatureDefines.xcconfig:
1798
1799 2014-10-09  Tim Horton  <timothy_horton@apple.com>
1800
1801         Add a WebKit1 preference for selection services
1802         https://bugs.webkit.org/show_bug.cgi?id=137498
1803         <rdar://problem/18572699>
1804
1805         Reviewed by Simon Fraser.
1806
1807         * WebView/WebPreferenceKeysPrivate.h:
1808         * WebView/WebPreferences.mm:
1809         (+[WebPreferences initialize]):
1810         (-[WebPreferences serviceControlsEnabled]):
1811         (-[WebPreferences setServiceControlsEnabled:]):
1812         * WebView/WebPreferencesPrivate.h:
1813         * WebView/WebView.mm:
1814         (-[WebView _preferencesChanged:]):
1815         Add and plumb the preference.
1816
1817 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
1818
1819         Remove second-to-last client of WebFontCache
1820         https://bugs.webkit.org/show_bug.cgi?id=137550
1821
1822         Reviewed by Darin Adler.
1823
1824         Use FontCache::getCachedFontData() instead of WebFontCache.
1825
1826         * WebView/WebHTMLView.mm:
1827         (-[WebHTMLView _addToStyle:fontA:fontB:]):
1828
1829 2014-10-09  Chris Dumez  <cdumez@apple.com>
1830
1831         Use is<>() / downcast<>() for Widget subclasses
1832         https://bugs.webkit.org/show_bug.cgi?id=137549
1833
1834         Reviewed by Darin Adler.
1835
1836         Use is<>() / downcast<>() for Widget subclasses and clean up the
1837         surrounding code.
1838
1839         * WebView/WebRenderNode.mm:
1840         (copyRenderNode):
1841         * WebView/WebView.mm:
1842         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
1843
1844 2014-10-07  Christophe Dumez  <cdumez@apple.com>
1845
1846         Use is<>() / downcast<>() for RenderText / RenderTextFragment
1847         https://bugs.webkit.org/show_bug.cgi?id=137476
1848
1849         Reviewed by Darin Adler.
1850
1851         * WebView/WebRenderNode.mm:
1852         (copyRenderNode):
1853
1854 2014-10-06  Dan Bernstein  <mitz@apple.com>
1855
1856         Build fix.
1857
1858         * Misc/WebCache.mm:
1859         (+[WebCache imageForURL:]):
1860
1861 2014-10-06  Chris Dumez  <cdumez@apple.com>
1862
1863         Unreviewed build fix after r174333.
1864
1865         Forgot explicit WebCore:: namespace.
1866
1867         * Misc/WebCache.mm:
1868         (+[WebCache imageForURL:]):
1869
1870 2014-10-05  Christophe Dumez  <cdumez@apple.com>
1871
1872         Use is<>() / downcast<>() for CachedResource subclasses
1873         https://bugs.webkit.org/show_bug.cgi?id=137431
1874
1875         Reviewed by Benjamin Poulain.
1876
1877         Use is<>() / downcast<>() for CachedResource subclasses.
1878
1879         * Misc/WebCache.mm:
1880         (+[WebCache imageForURL:]):
1881
1882 2014-10-02  Daniel Bates  <dabates@apple.com>
1883
1884         Use version number 101000 instead of 10100 for OS X Yosemite
1885         https://bugs.webkit.org/show_bug.cgi?id=137372
1886
1887         Reviewed by Mark Rowe.
1888
1889         The version number for OS X Yosemite is 101000.
1890
1891         * WebView/WebView.mm:
1892         (-[WebView _preferencesChanged:]):
1893
1894 2014-10-02  Tim Horton  <timothy_horton@apple.com>
1895
1896         Move PageOverlay[Controller] to WebCore
1897         https://bugs.webkit.org/show_bug.cgi?id=137164
1898         <rdar://problem/18508258>
1899
1900         Reviewed by Anders Carlsson.
1901
1902         * WebCoreSupport/WebChromeClient.h:
1903         * WebCoreSupport/WebChromeClient.mm:
1904         (WebChromeClient::attachViewOverlayGraphicsLayer):
1905         Add an empty ChromeClient override.
1906
1907 2014-10-01  Christophe Dumez  <cdumez@apple.com>
1908
1909         Have is<>(T*) function do a null check on the pointer argument
1910         https://bugs.webkit.org/show_bug.cgi?id=137333
1911
1912         Reviewed by Gavin Barraclough.
1913
1914         Have is<>(T*) function do a null check on the argument instead of a
1915         simple assertion. This makes sense for 2 reasons:
1916         1. It is more consistent with downcast<>(T*), which will succeed even
1917            if the argument is a nullptr.
1918         2. It simplifies the code a bit as it gets rid of a lot of explicit
1919            null checks.
1920
1921         * WebCoreSupport/WebChromeClient.mm:
1922         (WebChromeClient::focusedElementChanged):
1923         * WebCoreSupport/WebEditorClient.mm:
1924         (WebEditorClient::textFieldDidBeginEditing):
1925         (WebEditorClient::textFieldDidEndEditing):
1926         (WebEditorClient::textDidChangeInTextField):
1927         (WebEditorClient::doTextFieldCommandFromEvent):
1928         (WebEditorClient::textWillBeDeletedInTextField):
1929         (WebEditorClient::textDidChangeInTextArea):
1930         * WebView/WebHTMLRepresentation.mm:
1931         (inputElementFromDOMElement):
1932         (searchForLabelsBeforeElement):
1933         * WebView/WebRenderLayer.mm:
1934         (+[WebRenderLayer nameForLayer:]):
1935
1936 2014-10-01  Mark Rowe  <mrowe@apple.com>
1937
1938         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
1939
1940         Reviewed by Dan Bernstein.
1941
1942         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
1943
1944 2014-09-30  Chris Dumez  <cdumez@apple.com>
1945
1946         Use is<>() / downcast<>() for Element
1947         https://bugs.webkit.org/show_bug.cgi?id=137241
1948
1949         Reviewed by Andreas Kling.
1950
1951         Use is<>() / downcast<>() for Element instead of isElementNode() /
1952         toElement().
1953
1954         * WebView/WebRenderLayer.mm:
1955         (+[WebRenderLayer nameForLayer:]):
1956
1957 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1958
1959         Move ColorInputType class to std::unique_ptr
1960         https://bugs.webkit.org/show_bug.cgi?id=137173
1961
1962         Reviewed by Darin Adler.
1963
1964         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
1965         Child classes follow this change as well.
1966
1967         * WebCoreSupport/WebChromeClient.h:
1968         * WebCoreSupport/WebChromeClient.mm:
1969         (WebChromeClient::createColorChooser):
1970
1971 2014-09-24  Christophe Dumez  <cdumez@apple.com>
1972
1973         Add initial is<>() / downcast<>() support for any type of Nodes
1974         https://bugs.webkit.org/show_bug.cgi?id=137056
1975
1976         Reviewed by Benjamin Poulain.
1977
1978         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
1979         instead of isFormControlElement() / toHTMLFormControlElement().
1980
1981         * WebView/WebHTMLRepresentation.mm:
1982         (searchForLabelsBeforeElement):
1983
1984 2014-09-24  Christophe Dumez  <cdumez@apple.com>
1985
1986         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
1987         https://bugs.webkit.org/show_bug.cgi?id=137068
1988
1989         Reviewed by Ryosuke Niwa.
1990
1991         Start using is<HTML*Element>() instead of isHTML*Element().
1992         Remaining usages will be updated in a follow-up patch to
1993         reduce the size of the change.
1994
1995         * WebCoreSupport/WebChromeClient.mm:
1996         (WebChromeClient::focusedElementChanged):
1997         * WebCoreSupport/WebEditorClient.mm:
1998         (WebEditorClient::textFieldDidBeginEditing):
1999         (WebEditorClient::textFieldDidEndEditing):
2000         (WebEditorClient::textDidChangeInTextField):
2001         (WebEditorClient::doTextFieldCommandFromEvent):
2002         (WebEditorClient::textWillBeDeletedInTextField):
2003         (WebEditorClient::textDidChangeInTextArea):
2004         * WebView/WebHTMLRepresentation.mm:
2005         (inputElementFromDOMElement):
2006
2007 2014-09-21  Timothy Hatcher  <timothy@apple.com>
2008
2009         Make the Web Inspector use a separate web process.
2010
2011         https://bugs.webkit.org/show_bug.cgi?id=135120
2012
2013         Reviewed by Anders Carlsson.
2014
2015         * WebCoreSupport/WebInspectorClient.h:
2016         * WebCoreSupport/WebInspectorClient.mm:
2017         (WebInspectorClient::WebInspectorClient):
2018         (WebInspectorClient::openInspectorFrontend):
2019         (WebInspectorClient::releaseFrontend):
2020         Own WebInspectorFrontendClient instead of moving it.
2021
2022 2014-09-23  Chris Dumez  <cdumez@apple.com>
2023
2024         Use downcast<HTML*Element>() instead of toHTML*Element()
2025         https://bugs.webkit.org/show_bug.cgi?id=137007
2026
2027         Reviewed by Benjamin Poulain.
2028
2029         Use downcast<HTML*Element>() instead of toHTML*Element().
2030
2031         * DOM/WebDOMOperations.mm:
2032         (-[DOMHTMLInputElement _setAutofilled:]):
2033         * WebCoreSupport/WebChromeClient.mm:
2034         (WebChromeClient::focusedElementChanged):
2035         * WebCoreSupport/WebEditorClient.mm:
2036         (WebEditorClient::textFieldDidBeginEditing):
2037         (WebEditorClient::textFieldDidEndEditing):
2038         (WebEditorClient::textDidChangeInTextField):
2039         (WebEditorClient::doTextFieldCommandFromEvent):
2040         (WebEditorClient::textWillBeDeletedInTextField):
2041         (WebEditorClient::textDidChangeInTextArea):
2042         * WebView/WebHTMLRepresentation.mm:
2043         (inputElementFromDOMElement):
2044
2045 2014-09-21  Chris Dumez  <cdumez@apple.com>
2046
2047         Generate Element casting helper functions
2048         https://bugs.webkit.org/show_bug.cgi?id=136839
2049
2050         Reviewed by Darin Adler.
2051
2052         Use JSXXX::toWrapped() instead of toXXX() function.
2053
2054         * DOM/WebDOMOperations.mm:
2055         * WebView/WebView.mm:
2056         (-[WebView _notificationIDForTesting:]):
2057
2058 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
2059
2060         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
2061         https://bugs.webkit.org/show_bug.cgi?id=136972
2062
2063         Reviewed by Darin Adler.
2064
2065         * WebView/WebNotification.h:
2066         * WebView/WebNotification.mm:
2067         (-[WebNotification initWithCoreNotification:notificationID:]):
2068         Switch to RetainPtr and adopt into _private to ensure when we are
2069         deallocated that _private will get deallocated.
2070
2071 2014-09-19  Dean Jackson  <dino@apple.com>
2072
2073         Multithreaded WebGL is a bad idea - remove it
2074         https://bugs.webkit.org/show_bug.cgi?id=136964
2075         <rdar://problem/18399858>
2076
2077         Reviewed by Brent Fulgham.
2078
2079         Remove the setting to allow multithreaded WebGL.
2080
2081         * WebView/WebPreferenceKeysPrivate.h:
2082         * WebView/WebPreferences.mm:
2083         (+[WebPreferences initialize]):
2084         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
2085         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
2086         * WebView/WebPreferencesPrivate.h:
2087         * WebView/WebView.mm:
2088         (-[WebView _preferencesChanged:]):
2089
2090 2014-09-19  Daniel Bates  <dabates@apple.com>
2091
2092         Always assume internal SDK when building configuration Production
2093         https://bugs.webkit.org/show_bug.cgi?id=136925
2094         <rdar://problem/18362399>
2095
2096         Reviewed by Dan Bernstein.
2097
2098         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
2099         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
2100
2101         * Configurations/Base.xcconfig:
2102
2103 2014-09-17  Daniel Bates  <dabates@apple.com>
2104
2105         Unreviewed, rolling out r173695.
2106
2107         Broke building third-party Legacy WebKit apps; will
2108         investigate offline
2109
2110         Reverted changeset:
2111
2112         "[iOS] Make WebCore build with public iOS SDK"
2113         https://bugs.webkit.org/show_bug.cgi?id=136487
2114         http://trac.webkit.org/changeset/173695
2115
2116 2014-09-17  Daniel Bates  <dabates@apple.com>
2117
2118         [iOS] Make WebCore build with public iOS SDK
2119         https://bugs.webkit.org/show_bug.cgi?id=136487
2120
2121         Reviewed by David Kilzer.
2122
2123         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
2124         actual SPI header(s).
2125
2126         * DOM/WebDOMOperationsPrivate.h:
2127         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
2128         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
2129         such files into the WebKit framework as private headers.
2130         * WebCoreSupport/WebFrameLoaderClient.mm:
2131         * WebInspector/WebNodeHighlight.mm:
2132         * WebView/WebIndicateLayer.mm:
2133         * WebView/WebRenderLayer.h:
2134         * WebView/WebView.mm:
2135
2136 2014-09-16  Daniel Bates  <dabates@apple.com>
2137
2138         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
2139         https://bugs.webkit.org/show_bug.cgi?id=136862
2140
2141         Reviewed by David Kilzer.
2142
2143         * Configurations/DebugRelease.xcconfig:
2144
2145 2014-09-16  Enrica Casucci  <enrica@apple.com>
2146
2147         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2148         https://bugs.webkit.org/show_bug.cgi?id=136474
2149
2150         Reviewed by Benjamin Poulain.
2151
2152         This is the updated version of the patch that was landed in r173340.
2153         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2154         and removes the assumption that EAffinity values match NSSelectionAffinity
2155         values. It also removes the includes in TextAffinity.h, creating the need to
2156         include explicitly the files when necessary.
2157
2158         * WebCoreSupport/WebEditorClient.h:
2159         (kit):
2160         (core):
2161
2162 2014-09-14  Daniel Bates  <dabates@apple.com>
2163
2164         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
2165         (https://bugs.webkit.org/show_bug.cgi?id=136789)
2166
2167         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
2168
2169         * WebView/WebFrame.mm:
2170         (-[WebFrame focusedNodeHasContent]):
2171
2172 2014-09-14  Chris Dumez  <cdumez@apple.com>
2173
2174         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
2175         https://bugs.webkit.org/show_bug.cgi?id=136789
2176
2177         Reviewed by Darin Adler.
2178
2179         Rename childNodeCount() to countChildNodes().
2180
2181         * WebView/WebHTMLView.mm:
2182         (-[WebHTMLView attributedString]):
2183
2184 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
2185
2186         Re-add the request autocomplete feature
2187
2188         <https://bugs.webkit.org/show_bug.cgi?id=136730>
2189
2190         This feature was rolled out in r148731 because it was only used by
2191         Chromium. As we consider supporting this feature, roll it back in, but
2192         leave it disabled.
2193
2194         This rolls out r148731 (which removed the feature) with small changes
2195         needed to make the code build in ToT, to match modern style, to make
2196         the tests run, and to remove unused code.
2197
2198         Reviewed by Andy Estes.
2199
2200         * Configurations/FeatureDefines.xcconfig:
2201         * WebCoreSupport/WebFrameLoaderClient.h:
2202
2203 2014-09-12  Commit Queue  <commit-queue@webkit.org>
2204
2205         Unreviewed, rolling out r173575.
2206         https://bugs.webkit.org/show_bug.cgi?id=136790
2207
2208         Failing tests (Requested by enrica on #webkit).
2209
2210         Reverted changeset:
2211
2212         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2213         https://bugs.webkit.org/show_bug.cgi?id=136474
2214         http://trac.webkit.org/changeset/173575
2215
2216 2014-09-12  Enrica Casucci  <enrica@apple.com>
2217
2218         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2219         https://bugs.webkit.org/show_bug.cgi?id=136474
2220
2221         Reviewed by Benjamin Poulain.
2222
2223         This is the updated version of the patch that was landed in r173340.
2224         I changed the use of IntPoint to FloatPoint since it was causing tests
2225         to fail.
2226         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2227         and removes the assumption that EAffinity values match NSSelectionAffinity
2228         values. It also removes the includes in TextAffinity.h, creating the need to
2229         include explicitly the files when necessary. It also removes the unnecessary
2230         use of platform specific types, replacing them with WebCore types.
2231
2232         * WebCoreSupport/WebEditorClient.h:
2233         (kit):
2234         (core):
2235         * WebView/WebFrameView.mm:
2236         (-[WebFrameView _scrollToBeginningOfDocument]):
2237         (-[WebFrameView _scrollToEndOfDocument]):
2238
2239 2014-09-11  Bear Travis  <betravis@adobe.com>
2240
2241         [CSS Font Loading] Enable CSS Font Loading on Mac
2242         https://bugs.webkit.org/show_bug.cgi?id=135473
2243
2244         Reviewed by Antti Koivisto.
2245
2246         Enable CSS Font Loading in FeatureDefines.
2247
2248         * Configurations/FeatureDefines.xcconfig:
2249
2250 2014-09-11  Beth Dakin  <bdakin@apple.com>
2251
2252         Support rubber-banding in sub-frames
2253         https://bugs.webkit.org/show_bug.cgi?id=136726
2254         -and corresponding-
2255         rdar://problem/10011924
2256
2257         Reviewed by Tim Horton.
2258
2259         rubberBandingForOverflowScrollEnabled is re-named to
2260         rubberBandingForSubScrollableRegionsEnabled
2261         * WebView/WebView.mm:
2262         (-[WebView _preferencesChanged:]):
2263
2264 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
2265
2266         Disable the "unreachable-code" warning
2267         https://bugs.webkit.org/show_bug.cgi?id=136677
2268
2269         Reviewed by Darin Adler.
2270
2271         * Configurations/Base.xcconfig:
2272
2273 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
2274
2275         Fix 32-bit Mac build for new warnings
2276         https://bugs.webkit.org/show_bug.cgi?id=136624
2277
2278         Reviewed by Darin Adler.
2279         
2280         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
2281
2282         * Carbon/HIViewAdapter.m:
2283         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
2284
2285 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2286
2287         Remove FILTERS flag
2288         https://bugs.webkit.org/show_bug.cgi?id=136571
2289
2290         Reviewed by Darin Adler.
2291
2292         * Configurations/FeatureDefines.xcconfig:
2293
2294 2014-09-08  Jessie Berlin  <jberlin@apple.com>
2295
2296         32-bit build fix after r173364.
2297
2298         * Carbon/HIViewAdapter.m:
2299         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
2300
2301 2014-09-08  Dan Bernstein  <mitz@apple.com>
2302
2303         Build fix.
2304
2305         Added back SPI that is still in use.
2306
2307         * Misc/WebNSURLExtras.h:
2308         * Misc/WebNSURLExtras.mm:
2309         (-[NSURL _webkit_URLByRemovingFragment]):
2310
2311 2014-09-08  Dan Bernstein  <mitz@apple.com>
2312
2313         iOS Simulator build fix.
2314
2315         * Misc/WebKitSystemBits.m:
2316         (WebMemorySize):
2317
2318 2014-09-07  Darin Adler  <darin@apple.com>
2319
2320         Fix build failure seen on Mountain Lion buildbot.
2321
2322         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
2323         of an int, to avoid warning about mixing signs.
2324
2325 2014-09-06  Darin Adler  <darin@apple.com>
2326
2327         Make updates suggested by new version of Xcode
2328         https://bugs.webkit.org/show_bug.cgi?id=136603
2329
2330         Reviewed by Mark Rowe.
2331
2332         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
2333         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
2334
2335         * History/WebURLsWithTitles.m:
2336         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
2337         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
2338         not turned on because it gives us too many false positives).
2339         * Misc/WebElementDictionary.mm:
2340         (-[WebElementDictionary objectForKey:]): Ditto.
2341         * Misc/WebNSDataExtras.m:
2342         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
2343         (-[NSData _webkit_guessedMIMEType]): Ditto.
2344         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
2345         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
2346
2347         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
2348         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
2349         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
2350         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
2351         and _webkit_URLFragment methods.
2352
2353         * Misc/WebNSURLExtras.mm:
2354         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
2355         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
2356         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
2357         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
2358         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
2359         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
2360         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
2361         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
2362         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
2363         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
2364         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
2365         (-[NSString _webkit_URLFragment]): Deleted.
2366
2367         * Plugins/WebPluginDatabase.mm:
2368         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
2369         to iterate an array instead of a loop using the type "unsigned int".
2370
2371         * WebCoreSupport/WebOpenPanelResultListener.mm:
2372         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
2373
2374         * WebView/WebDelegateImplementationCaching.mm:
2375         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
2376         directly without a proper type for the function pointer. This might have been causing
2377         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
2378         functions that were already doing this correctly.
2379
2380         * WebView/WebTextCompletionController.mm:
2381         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
2382
2383 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
2384
2385         Web Inspector: convert DockSide to an enum class
2386         https://bugs.webkit.org/show_bug.cgi?id=136601
2387
2388         Reviewed by Timothy Hatcher.
2389
2390         * WebCoreSupport/WebInspectorClient.mm:
2391         (WebInspectorFrontendClient::frontendLoaded):
2392         (-[WebInspectorWindowController attachWindow:]):
2393         (-[WebInspectorWindowController attach]):
2394         (-[WebInspectorWindowController detach]):
2395         * WebInspector/WebInspectorFrontend.mm:
2396         (-[WebInspectorFrontend attach]):
2397
2398 2014-09-05  Commit Queue  <commit-queue@webkit.org>
2399
2400         Unreviewed, rolling out r173340 and r173342.
2401         https://bugs.webkit.org/show_bug.cgi?id=136596
2402
2403         Broke many tests (Requested by ap on #webkit).
2404
2405         Reverted changesets:
2406
2407         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2408         https://bugs.webkit.org/show_bug.cgi?id=136474
2409         http://trac.webkit.org/changeset/173340
2410
2411         "Build fix after r173340."
2412         http://trac.webkit.org/changeset/173342
2413
2414 2014-09-05  Enrica Casucci  <enrica@apple.com>
2415
2416         Build fix after r173340.
2417
2418         * WebCoreSupport/WebEditorClient.h:
2419         (kit):
2420         (core):
2421
2422 2014-09-05  Enrica Casucci  <enrica@apple.com>
2423
2424         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2425         https://bugs.webkit.org/show_bug.cgi?id=136474
2426
2427         Reviewed by Benjamin Poulain.
2428
2429         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2430         and removes the assumption that EAffinity values match NSSelectionAffinity
2431         values. It also removes the includes in TextAffinity.h, creating the need to
2432         include explicitly the files when necessary. It also removes the unnecessary
2433         use of platform specific types, replacing them with WebCore types.
2434
2435         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
2436         * WebView/WebFrameView.mm:
2437         (-[WebFrameView _scrollToBeginningOfDocument]):
2438         (-[WebFrameView _scrollToEndOfDocument]):
2439
2440 2014-09-05  Daniel Bates  <dabates@apple.com>
2441
2442         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
2443         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2444
2445         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
2446
2447         * WebView/WebHTMLView.mm:
2448         (-[WebHTMLView viewDidMoveToWindow]):
2449
2450 2014-09-05  Daniel Bates  <dabates@apple.com>
2451
2452         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
2453         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2454
2455         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
2456         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
2457
2458         * WebView/WebHTMLView.mm:
2459         (-[WebHTMLView viewDidMoveToWindow]):
2460
2461 2014-09-05  Daniel Bates  <dabates@apple.com>
2462
2463         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
2464         (https://bugs.webkit.org/show_bug.cgi?id=136564)
2465
2466         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
2467
2468         * WebView/WebHTMLView.mm:
2469         (-[WebHTMLView setDataSource:]):
2470
2471 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
2472
2473         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
2474         https://bugs.webkit.org/show_bug.cgi?id=136564
2475
2476         Reviewed by Dan Bernstein.
2477         
2478         WebKit1 depended on mouse moved event notifications to track mouse
2479         moves, and on being specially called by Safari to track flags
2480         changes. WebKit2 does both these things better - it uses a tracking area
2481         and event monitors. Copy those approaches.
2482
2483         * WebKit.order: Remove reference to obsolete call.
2484         * WebView/WebHTMLView.mm:
2485         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
2486         area, since we now just always have one.
2487         (-[WebHTMLViewPrivate clear]): ditto
2488         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
2489         New method that posts a fake mouse move event in response to
2490         a flags change event, for use by the event monitor.
2491         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
2492         still kept around for benefit of older Safari.
2493         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
2494         special mouseover mode (previously handled in a weird way).
2495         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
2496         (-[WebHTMLView viewWillMoveToWindow:]): ditto
2497         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
2498         changed monitor.
2499         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
2500         tracking area or mouse moved observer.
2501         (-[WebHTMLView windowDidResignKey:]): ditto
2502         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
2503         moved observer.
2504         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
2505         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
2506         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
2507         up tracking area - we have to do it here, because before this point, the
2508         WebHTMLView does not know its WebView, which is where dashboard settings
2509         live.
2510         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
2511         (-[WebHTMLView addMouseMovedObserver]): Deleted.
2512         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
2513
2514 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2515
2516         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
2517         https://bugs.webkit.org/show_bug.cgi?id=136560
2518
2519         Reviewed by Joseph Pecoraro.
2520
2521         I removed the disk image caching code in r173265. However, we still have clients that call
2522         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
2523
2524         * WebView/WebPreferences.mm:
2525         (-[WebPreferences setDiskImageCacheEnabled:]):
2526         * WebView/WebPreferencesPrivate.h:
2527
2528 2014-09-03  Andy Estes  <aestes@apple.com>
2529
2530         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2531         https://bugs.webkit.org/show_bug.cgi?id=136521
2532
2533         Reviewed by Anders Carlsson.
2534
2535         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
2536
2537             s/(^ *)WEBCORE_EXPORT /\1/g
2538
2539         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
2540
2541         * MigrateHeaders.make:
2542
2543 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
2544
2545         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
2546         https://bugs.webkit.org/show_bug.cgi?id=136527
2547
2548         Reviewed by Alexey Proskuryakov.
2549
2550         * WebCoreSupport/WebSystemInterface.mm:
2551         (InitWebCoreSystemInterface):
2552
2553 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2554
2555         Remove CSS_FILTERS flag
2556         https://bugs.webkit.org/show_bug.cgi?id=136529
2557
2558         Reviewed by Dirk Schulze.
2559
2560         * Configurations/FeatureDefines.xcconfig:
2561
2562 2014-09-04  Pratik Solanki  <psolanki@apple.com>
2563
2564         Remove iOS specific disk image cache
2565         https://bugs.webkit.org/show_bug.cgi?id=136517
2566
2567         Reviewed by Antti Koivisto.
2568
2569         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
2570         this now since we don't enable it in WebKit2 on iOS.
2571
2572         * Misc/WebCache.mm:
2573         (+[WebCache statistics]):
2574         * WebView/WebDataSource.mm:
2575         (-[WebDataSource _setAllowToBeMemoryMapped]):
2576         (-[WebDataSource setDataSourceDelegate:]):
2577         (-[WebDataSource dataSourceDelegate]):
2578         (-[WebDataSource dealloc]):
2579         (BufferMemoryMapped): Deleted.
2580         * WebView/WebPreferenceKeysPrivate.h:
2581         * WebView/WebPreferences.mm:
2582         (+[WebPreferences initialize]):
2583         (-[WebPreferences diskImageCacheEnabled]): Deleted.
2584         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
2585         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
2586         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
2587         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
2588         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
2589         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
2590         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
2591         * WebView/WebPreferencesPrivate.h:
2592         * WebView/WebView.mm:
2593         (-[WebView _commonInitializationWithFrameName:groupName:]):
2594         (+[WebView _handleMemoryWarning]):
2595         (-[WebView _preferencesChanged:]):
2596
2597 2014-09-04  Daniel Bates  <dabates@apple.com>
2598
2599         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
2600         https://bugs.webkit.org/show_bug.cgi?id=136494
2601
2602         Reviewed by Andy Estes.
2603
2604         * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined.
2605         * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
2606
2607 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2608
2609         Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
2610         https://bugs.webkit.org/show_bug.cgi?id=136476
2611
2612         Reviewed by Timothy Hatcher.
2613
2614         * Misc/WebCoreStatistics.mm:
2615         (+[WebCoreStatistics shouldPrintExceptions]):
2616         (+[WebCoreStatistics setShouldPrintExceptions:]):
2617
2618 2014-09-03  Enrica Casucci  <enrica@apple.com>
2619
2620         Remove PLATFORM(IOS) from WebCore/editing (Part 1).
2621         https://bugs.webkit.org/show_bug.cgi?id=136474
2622
2623         Reviewed by Tim Horton.
2624
2625         * WebCoreSupport/WebEditorClient.mm:
2626         (undoNameForEditAction):
2627
2628 2014-09-02  Maciej Stachowiak  <mjs@apple.com>
2629
2630         Clean up naming for and slightly refactor legacy video fullscreen support
2631         https://bugs.webkit.org/show_bug.cgi?id=136446
2632
2633         Reviewed by Jer Noble.
2634
2635         Key changes:
2636         supportsFullscreenForNode(Node*) --> supportsVideoFullscreen()
2637         enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*)
2638         exitFullscreenForNode(Node*) --> exitVideoFullscreen()
2639         
2640         The old versions had unnecessary parameters, did not clearly distinguish their purpose
2641         from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes.
2642         Also changed many other places to use HTMLVideoElement* instead of Node* or 
2643         HTMLMediaElement* when they were in fact only used for video elements and would only
2644         work for such.
2645
2646         * WebCoreSupport/WebChromeClient.h:
2647         * WebCoreSupport/WebChromeClient.mm:
2648         (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring.
2649         Also no more need to check for video elementness.
2650         (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring.
2651         (WebChromeClient::exitVideoFullscreen): ditto
2652         * WebView/WebView.mm:
2653         (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main
2654         refactoring.
2655         (-[WebView _exitVideoFullscreen]): ditto
2656         (-[WebView _close]): ditto
2657         * WebView/WebViewInternal.h:
2658
2659 2014-09-03  Dan Bernstein  <mitz@apple.com>
2660
2661         Get rid of HIGH_DPI_CANVAS leftovers
2662         https://bugs.webkit.org/show_bug.cgi?id=136491
2663
2664         Reviewed by Benjamin Poulain.
2665
2666         * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS
2667         and removed it from FEATURE_DEFINES.
2668
2669 2014-08-31  Tim Horton  <timothy_horton@apple.com>
2670
2671         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
2672         https://bugs.webkit.org/show_bug.cgi?id=136416
2673
2674         Reviewed by Dan Bernstein.
2675
2676         * WebView/WebFrameView.mm:
2677         (-[WebFrameView drawRect:]):
2678         We only end up filling, so only set the fill color.
2679
2680 2014-08-26  Maciej Stachowiak  <mjs@apple.com>
2681
2682         Use RetainPtr::autorelease in some places where it seems appropriate
2683         https://bugs.webkit.org/show_bug.cgi?id=136280
2684
2685         Reviewed by Darin Adler.
2686
2687         * WebView/WebHTMLView.mm:
2688         (imageFromRect): Use RetainPtr in this function.
2689         * WebView/WebPDFRepresentation.mm:
2690         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
2691         in this method.
2692
2693 2014-08-29  Csaba Osztrogonác  <ossy@webkit.org>
2694
2695         Unreviwed, remove empty directories.
2696
2697         * ForwardingHeaders/wtf: Removed.
2698
2699 2014-08-27  Zalan Bujtas  <zalan@apple.com>
2700
2701         Subpixel layout: Rename LayoutRect's device pixel snapping functions.
2702         https://bugs.webkit.org/show_bug.cgi?id=136319
2703
2704         Reviewed by Simon Fraser.
2705
2706         From pixelSnappedForPainting() to snapRectToDevicePixels() and 
2707         pixelSnappedIntRect*() to snappedIntRect*().
2708
2709         No change in functionality.
2710
2711         * WebView/WebView.mm:
2712         (-[WebView _dashboardRegions]):
2713         (-[WebView trackedRepaintRects]):
2714
2715 2014-08-25  Maciej Stachowiak  <mjs@apple.com>
2716
2717         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
2718         https://bugs.webkit.org/show_bug.cgi?id=136082
2719
2720         Reviewed by Alexey Proskuryakov.
2721
2722         * Plugins/Hosted/NetscapePluginHostManager.mm:
2723         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
2724         localization name using WebCore helper instead of SPI.
2725         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
2726         file.
2727         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
2728         localization name using WebCore helper instead of SPI.
2729         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
2730         helper no longer pulls its weight.
2731         * WebCoreSupport/WebSystemInterface.mm: 
2732         (InitWebCoreSystemInterface): Remove mention of
2733         WKCopyCFLocalizationPreferredName.
2734         * WebKit.order: ditto
2735
2736 2014-08-25  Daniel Bates  <dabates@apple.com>
2737
2738         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/172889>
2739         (https://bugs.webkit.org/show_bug.cgi?id=109658)
2740
2741         Substitute GraphicsLayer::setContentsToPlatformLayer(..., GraphicsLayer::ContentsLayerForMedia)
2742         for GraphicsLayer::setContentsToMedia(...) because the latter was removed in <http://trac.webkit.org/changeset/172889>.
2743
2744         * WebView/WebView.mm:
2745         (-[WebView _setMediaLayer:forPluginView:]):
2746
2747 2014-08-22  Commit Queue  <commit-queue@webkit.org>
2748
2749         Unreviewed, rolling out r172866.
2750         https://bugs.webkit.org/show_bug.cgi?id=136177
2751
2752         Broke iOS build (Requested by othermaciej on #webkit).
2753
2754         Reverted changeset:
2755
2756         "Replace use of WKCopyCFLocalizationPreferredName with
2757         NSLocale public API"
2758         https://bugs.webkit.org/show_bug.cgi?id=136082
2759         http://trac.webkit.org/changeset/172866
2760
2761 2014-08-22  Simon Fraser  <simon.fraser@apple.com>
2762
2763         Implement paint flashing in the WK1 InspectorOverlay page
2764         https://bugs.webkit.org/show_bug.cgi?id=136138
2765
2766         Reviewed by Sam Weinig, Joseph Pecoraro.
2767
2768         Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page.
2769         We avoid allocating backing store for this canvas until we have paint rects.
2770         
2771         Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages
2772         an array of rects, and pushes them to the page when they change, before forcing a paint.
2773         
2774         Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its
2775         WebKit WebInspectorClient, but don't yet implement paint flashing there.
2776
2777         * WebCoreSupport/WebInspectorClient.h:
2778         * WebCoreSupport/WebInspectorClient.mm:
2779         (WebInspectorClient::WebInspectorClient):
2780
2781 2014-08-20  Maciej Stachowiak  <mjs@apple.com>
2782
2783         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
2784         https://bugs.webkit.org/show_bug.cgi?id=136082
2785
2786         Reviewed by Alexey Proskuryakov.
2787
2788         * Plugins/Hosted/NetscapePluginHostManager.mm:
2789         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
2790         localization name using WebCore helper instead of SPI.
2791         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
2792         file.
2793         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
2794         localization name using WebCore helper instead of SPI.
2795         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
2796         helper no longer pulls its weight.
2797         * WebCoreSupport/WebSystemInterface.mm: 
2798         (InitWebCoreSystemInterface): Remove mention of
2799         WKCopyCFLocalizationPreferredName.
2800         * WebKit.order: ditto
2801
2802 2014-08-22  Daniel Bates  <dabates@apple.com>
2803
2804         [iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily disable ENABLE_TOUCH_EVENTS
2805         and ENABLE_XSLT when building with the iOS public SDK
2806         https://bugs.webkit.org/show_bug.cgi?id=135945
2807
2808         Reviewed by Andy Estes.
2809
2810         * Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS
2811         and ENABLE_XSLT when building with the public SDK.
2812         * MigrateHeaders.make: Conditionally migrate headers for touch and gesture events.
2813
2814 2014-08-22  Jon Lee  <jonlee@apple.com>
2815
2816         Fix iOS build due to r172832 and move RUBBER_BANDING out of FeatureDefines.h
2817         https://bugs.webkit.org/show_bug.cgi?id=136157
2818
2819         Reviewed by Simon Fraser.
2820
2821         * Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).
2822         * WebView/WebView.mm:
2823         (-[WebView _preferencesChanged:]): Wrap in ENABLE(RUBBER_BANDING).
2824
2825 2014-08-21  Zalan Bujtas  <zalan@apple.com>
2826
2827         Enable SATURATED_LAYOUT_ARITHMETIC.
2828         https://bugs.webkit.org/show_bug.cgi?id=136106
2829
2830         Reviewed by Simon Fraser.
2831
2832         SATURATED_LAYOUT_ARITHMETIC protects LayoutUnit against arithmetic overflow.
2833         (No measurable performance regression on Mac.)
2834
2835         * Configurations/FeatureDefines.xcconfig:
2836
2837 2014-08-21  Beth Dakin  <bdakin@apple.com>
2838
2839         overflow:scroll elements should support rubber-banding
2840         https://bugs.webkit.org/show_bug.cgi?id=91655
2841
2842         Reviewed by Sam Weinig and Darin Adler.
2843
2844         Disable rubber-banding in overflow areas for now.
2845         * WebView/WebView.mm:
2846         (-[WebView _preferencesChanged:]):
2847
2848 2014-08-19  Pratik Solanki  <psolanki@apple.com>
2849
2850         Remove PurgeableBuffer since it is not very useful any more
2851         https://bugs.webkit.org/show_bug.cgi?id=135939
2852
2853         Reviewed by Andreas Kling.
2854
2855         * Misc/WebCache.mm:
2856         (+[WebCache statistics]):
2857
2858 2014-08-19  Zalan Bujtas  <zalan@apple.com>
2859
2860         Remove ENABLE(SUBPIXEL_LAYOUT).
2861         https://bugs.webkit.org/show_bug.cgi?id=136077
2862
2863         Reviewed by Simon Fraser.
2864
2865         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
2866
2867         * Configurations/FeatureDefines.xcconfig:
2868
2869 2014-08-18  Maciej Stachowiak  <mjs@apple.com>
2870
2871         Use NSURLFileTypeMappings directly instead of depending on WebKitSystemInterface wrappers for it
2872         https://bugs.webkit.org/show_bug.cgi?id=136035
2873
2874         Reviewed by Dan Bernstein.
2875
2876         * Misc/WebNSViewExtras.m:
2877         (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Remove comment
2878         reference to obsolete WKSI function.
2879         * WebCoreSupport/WebSystemInterface.mm:
2880         (InitWebCoreSystemInterface): Don't initialize the no-longer-used WKGetExtensionsForMIMEType,
2881         WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension
2882         * Plugins/WebPluginDatabase.mm:
2883         (-[WebPluginDatabase pluginForExtension:]): Include SPI header from WebCore; use
2884         NSURLFileTypeMappings directly instead of via WKSI wrapper.
2885         * WebCoreSupport/WebFrameLoaderClient.mm:
2886         (WebFrameLoaderClient::objectContentType): ditto
2887         * WebView/WebHTMLView.mm:
2888         (-[WebHTMLView _imageExistsAtPaths:]): ditto
2889         * WebView/WebView.mm:
2890         (+[WebView _supportedFileExtensions]): ditto
2891         (+[WebView suggestedFileExtensionForMIMEType:]): ditto
2892         (+[WebView _MIMETypeForFile:]): ditto
2893
2894 2014-08-18  Commit Queue  <commit-queue@webkit.org>
2895
2896         Unreviewed, rolling out r172736.
2897         https://bugs.webkit.org/show_bug.cgi?id=136060
2898
2899         Caused 14% PLT regressions (Requested by rniwa on #webkit).
2900
2901         Reverted changeset:
2902
2903         "Remove PurgeableBuffer since it is not very useful any more"
2904         https://bugs.webkit.org/show_bug.cgi?id=135939
2905         http://trac.webkit.org/changeset/172736
2906
2907 2014-08-18  Pratik Solanki  <psolanki@apple.com>
2908
2909         Remove PurgeableBuffer since it is not very useful any more
2910         https://bugs.webkit.org/show_bug.cgi?id=135939
2911
2912         Reviewed by Geoffrey Garen.
2913
2914         * Misc/WebCache.mm:
2915         (+[WebCache statistics]):
2916
2917 2014-08-18  Andy Estes  <aestes@apple.com>
2918
2919         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
2920         https://bugs.webkit.org/show_bug.cgi?id=136010
2921
2922         Reviewed by Darin Adler.
2923
2924         * Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
2925         * WebView/WebPDFView.mm:
2926         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
2927         * WebView/WebView.mm:
2928         (-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary.
2929
2930 2014-08-18  Andy Estes  <aestes@apple.com>
2931
2932         Revert r172697.
2933
2934         It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects.
2935
2936         * Misc/WebKitVersionChecks.h:
2937         * WebView/WebView.mm:
2938         (-[WebView _preferencesChanged:]):
2939
2940 2014-08-15  Andy Estes  <aestes@apple.com>
2941
2942         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
2943         https://bugs.webkit.org/show_bug.cgi?id=136010
2944
2945         Reviewed by Darin Adler.
2946
2947         Reverted the linked-on-or-after check added in r170120 since it is no longer necessary.
2948
2949         * Misc/WebKitVersionChecks.h:
2950         * WebView/WebView.mm:
2951         (-[WebView _preferencesChanged:]):
2952
2953 2014-08-16  Maciej Stachowiak  <mjs@apple.com>
2954
2955         Remove the obsolete WebKitEnableCoalescedUpdatesPreferenceKey
2956         https://bugs.webkit.org/show_bug.cgi?id=136024
2957
2958         Reviewed by Filip Pizlo.
2959
2960         * WebView/WebFrameView.mm:
2961         (-[WebFrameView initWithFrame:]): Remove code that respects
2962         this key. It was SPI and is no longer used; also it was
2963         only relevant for versions of OS X that WebKit no longer supports.
2964         * WebView/WebPreferenceKeysPrivate.h: Remove declaration.
2965
2966 2014-08-15  Daniel Bates  <dabates@apple.com>
2967
2968         [iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS
2969         and ENABLE_TOUCH_EVENTS if applicable
2970         https://bugs.webkit.org/show_bug.cgi?id=135993
2971
2972         Reviewed by Andy Estes.
2973
2974         Add support infrastructure to remove code from public and private API headers that is
2975         guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled.
2976
2977         We aren't using this functionality yet, but we will soon.
2978
2979         * postprocess-headers.sh:
2980
2981 2014-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2982
2983         Enable CSS_SCROLL_SNAP for iOS
2984         https://bugs.webkit.org/show_bug.cgi?id=135915
2985
2986         Turn on CSS_SCROLL_SNAP for iOS and the iOS simulator.
2987
2988         Reviewed by Tim Horton.
2989
2990         * Configurations/FeatureDefines.xcconfig:
2991
2992 2014-08-13  Mark Rowe  <mrowe@apple.com>
2993
2994         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
2995
2996         Reviewed by Darin Adler.
2997
2998         * Misc/WebSharingServicePickerController.mm: Forward-declare some details related to NSSharingServicePicker.
2999
3000 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3001
3002         Web Inspector: Workaround a NSWindow change to the title bar.
3003         https://bugs.webkit.org/show_bug.cgi?id=135880
3004
3005         Reviewed by Joseph Pecoraro.
3006
3007         * WebCoreSupport/WebInspectorClient.mm:
3008         (WebInspectorFrontendClient::setToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier.
3009         (-[WebInspectorWindowController init]): Only call setDrawsBackground: on 10.9 and earlier.
3010         (-[WebInspectorWindowController window]): Set titlebarAppearsTransparent on 10.10.
3011         Only call border thickness APIs on 10.9 and earlier.
3012
3013 2014-08-12  Peyton Randolph  <prandolph@apple.com>
3014
3015         Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.           
3016         https://bugs.webkit.org/show_bug.cgi?id=135682
3017
3018         Reviewed by Tim Horton.
3019
3020         * Configurations/FeatureDefines.xcconfig:
3021         Remove LONG_MOUSE_PRESS feature flag.
3022
3023 2014-08-11  Andy Estes  <aestes@apple.com>
3024
3025         [iOS] Get rid of iOS.xcconfig
3026         https://bugs.webkit.org/show_bug.cgi?id=135809
3027
3028         Reviewed by Joseph Pecoraro.
3029
3030         All iOS.xcconfig did was include AspenFamily.xcconfig, so there's no need for the indirection.
3031
3032         * Configurations/Base.xcconfig:
3033         * Configurations/iOS.xcconfig: Removed.
3034
3035 2014-08-10  Timothy Hatcher  <timothy@apple.com>
3036
3037         Web Inspector: new glyphs are visible on OS X 10.9 builds
3038         https://bugs.webkit.org/show_bug.cgi?id=135743
3039
3040         Reviewed by Joseph Pecoraro.
3041
3042         * WebCoreSupport/WebInspectorClient.mm:
3043         (-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version.
3044
3045 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3046
3047         Get rid of SCRIPTED_SPEECH
3048         https://bugs.webkit.org/show_bug.cgi?id=135729
3049
3050         Reviewed by Brent Fulgham.
3051
3052         * Configurations/FeatureDefines.xcconfig:
3053
3054 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3055
3056         Get rid of INPUT_SPEECH
3057         https://bugs.webkit.org/show_bug.cgi?id=135672
3058
3059         Reviewed by Andreas Kling.
3060
3061         * Configurations/FeatureDefines.xcconfig:
3062
3063 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3064
3065         Web Inspector: Update glyphs to be more like Xcode 6
3066         https://bugs.webkit.org/show_bug.cgi?id=135705
3067
3068         Reviewed by Joseph Pecoraro.
3069
3070         * Resources/Dock.pdf: Added.
3071         * Resources/DockLegacy.pdf: Copied from Source/WebKit/mac/Resources/Dock.pdf.
3072         * WebCoreSupport/WebInspectorClient.mm:
3073         (-[WebInspectorWindowController window]): Use new images.
3074
3075 2014-08-06  Dean Jackson  <dino@apple.com>
3076
3077         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
3078         https://bugs.webkit.org/show_bug.cgi?id=135675
3079
3080         Reviewed by Sam Weinig.
3081
3082         * Configurations/FeatureDefines.xcconfig:
3083
3084 2014-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3085
3086         Implement parsing for CSS scroll snap points
3087         https://bugs.webkit.org/show_bug.cgi?id=134301
3088
3089         Reviewed by Dean Jackson.
3090
3091         * Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP
3092
3093 2014-08-06  Alexey Proskuryakov  <ap@apple.com>
3094
3095         REGRESSION (WebKit2): iOS Safari default encoding doesn't follow system language
3096         https://bugs.webkit.org/show_bug.cgi?id=135667
3097         <rdar://problem/17862892>
3098
3099         Reviewed by Anders Carlsson.
3100
3101         * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
3102         Moved implementation to WebCore, so that it can be shared with WebKit2.
3103
3104         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
3105         We now use WKGetWebDefaultCFStringEncoding in WebCore, so it needs to be initialized.
3106
3107 2014-08-05  Peyton Randolph  <prandolph@apple.com>
3108
3109         Rename MAC_LONG_PRESS feature flag to LONG_MOUSE_PRESS.
3110         https://bugs.webkit.org/show_bug.cgi?id=135276
3111
3112         Reviewed by Beth Dakin.
3113
3114         * Configurations/FeatureDefines.xcconfig:
3115
3116 2014-08-04  Benjamin Poulain  <benjamin@webkit.org>
3117
3118         Add a flag for the CSS Selectors level 4 implementation
3119         https://bugs.webkit.org/show_bug.cgi?id=135535
3120
3121         Reviewed by Andreas Kling.
3122
3123         * Configurations/FeatureDefines.xcconfig:
3124
3125 2014-08-04  Benjamin Poulain  <bpoulain@apple.com>
3126
3127         Check for null frame when processing geolocation authorization request
3128         https://bugs.webkit.org/show_bug.cgi?id=135577
3129         <rdar://problem/17896295>
3130
3131         Reviewed by Geoffrey Garen.
3132
3133         * WebCoreSupport/WebGeolocationClient.mm:
3134         (WebGeolocationClient::requestPermission):
3135
3136 2014-08-02  Jeremy Jones  <jeremyj@apple.com>
3137
3138         Support both window and view based video fullscreen.
3139         https://bugs.webkit.org/show_bug.cgi?id=135525
3140
3141         Reviewed by Simon Fraser.
3142
3143         Parenting in the view instead of the window gives the fullscreen implementation more latitude 
3144         in how it implements the animation.
3145
3146         * WebView/WebView.mm:
3147         (-[WebView _enterFullscreenForNode:]): Use view instead of window.
3148
3149 2014-08-01  Dan Bernstein  <mitz@apple.com>
3150
3151         <rdar://problem/17891752> [iOS] WebKit links against libraries it doesn’t use
3152         https://bugs.webkit.org/show_bug.cgi?id=135536
3153
3154         Reviewed by Tim Horton.
3155
3156         * Configurations/WebKitLegacy.xcconfig: Removed -framework MobileAsset from
3157         OTHER_LDFLAGS_iphoneos.
3158
3159 2014-07-30  Andy Estes  <aestes@apple.com>
3160
3161         USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
3162         https://bugs.webkit.org/show_bug.cgi?id=135439
3163
3164         Reviewed by Tim Horton.
3165
3166         We now support two different platform content filters, and will soon support a mock content filter (as part of
3167         webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party
3168         library. ENABLE() is the correct macro to use for such a feature.
3169
3170         * Configurations/FeatureDefines.xcconfig:
3171
3172 2014-07-30  Andreas Kling  <akling@apple.com>
3173
3174         Static hash tables no longer need to be coupled with a VM.
3175         <https://webkit.org/b/135421>
3176
3177         Reviewed by Geoffrey Garen.
3178
3179         * Plugins/Hosted/ProxyInstance.mm:
3180         * Plugins/Hosted/ProxyRuntimeObject.mm:
3181
3182 2014-07-30  Dan Bernstein  <mitz@apple.com>
3183
3184         Updated for changes to the WebCore::Credential API.
3185         Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327
3186
3187         Reviewed by Alexey Proskuryakov.
3188
3189         * Misc/WebDownload.mm:
3190         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential
3191         getter.
3192         * Plugins/WebBaseNetscapePluginView.mm:
3193         (WebKit::getAuthenticationInfo): Ditto.
3194
3195 2014-07-27  Pratik Solanki  <psolanki@apple.com>
3196
3197         Remove unused preference keys
3198         https://bugs.webkit.org/show_bug.cgi?id=135280
3199
3200         Reviewed by Darin Adler.
3201
3202         * WebView/WebPreferenceKeysPrivate.h:
3203         * WebView/WebPreferences.mm:
3204         (+[WebPreferences initialize]):
3205         (-[WebPreferences _setPageCacheSize:]): Deleted.
3206         (-[WebPreferences _pageCacheSize]): Deleted.
3207         (-[WebPreferences _setObjectCacheSize:]): Deleted.
3208         (-[WebPreferences _objectCacheSize]): Deleted.
3209         * WebView/WebPreferencesPrivate.h:
3210
3211 2014-07-27  Filip Pizlo  <fpizlo@apple.com>
3212
3213         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
3214
3215     2014-07-25  Mark Lam  <mark.lam@apple.com>
3216     
3217             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
3218             <https://webkit.org/b/134273>
3219     
3220             Reviewed by Michael Saboff.
3221     
3222             * WebView/WebScriptDebugDelegate.mm:
3223             - Removed unneeded #include.
3224     
3225 2014-07-26  Filip Pizlo  <fpizlo@apple.com>
3226
3227         Unreviewed, roll out r171641-r171644. It broke some tests; will investigate and
3228         reland later.
3229
3230         * WebView/WebScriptDebugDelegate.mm:
3231
3232 2014-07-25  Filip Pizlo  <fpizlo@apple.com>
3233
3234         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
3235
3236     2014-07-25  Mark Lam  <mark.lam@apple.com>
3237     
3238             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
3239             <https://webkit.org/b/134273>
3240     
3241             Reviewed by Michael Saboff.
3242     
3243             * WebView/WebScriptDebugDelegate.mm:
3244             - Removed unneeded #include.
3245     
3246 2014-07-25  Jeremy Jones  <jeremyj@apple.com>
3247
3248         Parent fullscreen from window instead of view
3249         https://bugs.webkit.org/show_bug.cgi?id=135310
3250
3251         Reviewed by Jer Noble.
3252
3253         Parenting in the view causes an incorrect animation to fullscreen, and can cause 
3254         fullscreen to only expand to the size of the view instead of the whole window.
3255
3256         * WebView/WebView.mm:
3257         (-[WebView _enterFullscreenForNode:]): Pass window instead of view.
3258
3259 2014-07-24  Pratik Solanki  <psolanki@apple.com>
3260
3261         [iOS] Remove prefs to tweak cache values
3262         https://bugs.webkit.org/show_bug.cgi?id=135274
3263         <rdar://problem/17784826>
3264
3265         Reviewed by Alexey Proskuryakov.
3266
3267         Remove iOS specific code that used to look up user defaults to see if any cache values were
3268         overridden. This was added for testing, is not used any more and is actually harmful now. It
3269         can cause unnecessary memory churn when under memory pressure since we call [WebView _setCacheModel]
3270         as a means to clear out memory cache.
3271
3272         * WebView/WebPreferenceKeysPrivate.h:
3273         * WebView/WebPreferences.mm:
3274         (+[WebPreferences initialize]):
3275         (-[WebPreferences _setNSURLMemoryCacheSize:]): Deleted.
3276         (-[WebPreferences _NSURLMemoryCacheSize]): Deleted.
3277         (-[WebPreferences _setNSURLDiskCacheSize:]): Deleted.
3278         (-[WebPreferences _NSURLDiskCacheSize]): Deleted.
3279         * WebView/WebPreferencesPrivate.h:
3280         * WebView/WebView.mm:
3281         (+[WebView _setCacheModel:]):
3282
3283 2014-07-24  Peyton Randolph  <prandolph@apple.com>
3284
3285         Rename feature flag for long-press gesture on Mac.                                                                   
3286         https://bugs.webkit.org/show_bug.cgi?id=135259                                                                 
3287
3288         Reviewed by Beth Dakin.
3289
3290         * Configurations/FeatureDefines.xcconfig:
3291         Rename LINK_LONG_PRESS to MAC_LONG_PRESS.
3292
3293 2014-07-24  Dan Bernstein  <mitz@apple.com>
3294
3295         WebKit part of <rdar://problem/17766348> [Cocoa] WebCore::ProtectionSpace doesn’t preserve all NSURLProtectionSpace properties, such as the distinguishedNames array
3296         https://bugs.webkit.org/show_bug.cgi?id=135229
3297
3298         Reviewed by Alexey Proskuryakov.
3299
3300         * Misc/WebDownload.mm:
3301         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Chanegd to use the
3302         ProtectionSpace constructor that takes an NSURLProtectionSpace.
3303
3304         * Plugins/WebBaseNetscapePluginView.mm:
3305         (WebKit::getAuthenticationInfo): Ditto.
3306
3307         * WebCoreSupport/WebFrameLoaderClient.mm:
3308         (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Changed to use
3309         ProtectionSpace::nsSpace.
3310
3311 2014-07-23  Bem Jones-Bey  <bjonesbe@adobe.com>
3312
3313         Remove CSS_EXCLUSIONS compile flag and leftover code
3314         https://bugs.webkit.org/show_bug.cgi?id=135175
3315
3316         Reviewed by Zoltan Horvath.
3317
3318         At this point, the CSS_EXCLUSIONS flag guards nothing but some useless
3319         stubs. This removes the flag and the useless code.
3320
3321         * Configurations/FeatureDefines.xcconfig:
3322
3323 2014-07-22  Enrica Casucci  <enrica@apple.com>
3324
3325         REGRESSION (WebKit2): Selection inside accelerated overflow:scroll doesn't track scrolling.
3326         https://bugs.webkit.org/show_bug.cgi?id=135180
3327         <rdar://problem/16721055>
3328
3329         Reviewed by Simon Fraser.
3330
3331         * WebCoreSupport/WebEditorClient.h:
3332
3333 2014-07-22  Jeremy Jones  <jeremyj@apple.com>
3334
3335         Don't create new UIWindow for video fullscreen.
3336         https://bugs.webkit.org/show_bug.cgi?id=135038
3337
3338         Reviewed by Darin Adler.
3339
3340         Provide UIView to WebVideoFullscreenController
3341
3342         * WebView/WebView.mm:
3343         (-[WebView _enterFullscreenForNode:]): pass UIView instead of nil
3344
3345 2014-07-21  Pratik Solanki  <psolanki@apple.com>
3346
3347         Unreviewed iOS build fix after r171321.
3348
3349         * WebView/WebView.mm:
3350         (-[WebView _preferencesChanged:]):
3351
3352 2014-07-21  Beth Dakin  <bdakin@apple.com>
3353
3354         WK1 should always setAcceleratedCompositingForFixedPositionEnabled(true) on 
3355         Yosemite
3356         https://bugs.webkit.org/show_bug.cgi?id=135135
3357
3358         Reviewed by Darin Adler.
3359
3360         Get rid of the ChromeClient function, and enable the Setting instead.
3361         * WebCoreSupport/WebChromeClient.h:
3362         * WebCoreSupport/WebChromeClient.mm:
3363         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition): Deleted.
3364         * WebView/WebView.mm:
3365         (-[WebView _preferencesChanged:]):
3366
3367 2014-07-21  Beth Dakin  <bdakin@apple.com>
3368
3369         Build fix.
3370
3371         * WebCoreSupport/WebChromeClient.mm:
3372         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition):
3373
3374 2014-07-21  Beth Dakin  <bdakin@apple.com>
3375
3376         Put position:fixed elements into layers when a WK1 view is layer-backed
3377         https://bugs.webkit.org/show_bug.cgi?id=135075
3378
3379         Reviewed by Darin Adler.
3380
3381         Returns true when the WebHTMLView has a layer.
3382
3383         * WebCoreSupport/WebChromeClient.h:
3384         * WebCoreSupport/WebChromeClient.mm:
3385         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition):
3386
3387 2014-07-18  Andy Estes  <aestes@apple.com>
3388
3389         [iOS] Tapping "Allow Website" on a restricted page does not bring up the keypad
3390         https://bugs.webkit.org/show_bug.cgi?id=135072
3391         <rdar://problem/17528188>
3392
3393         Reviewed by David Kilzer.
3394
3395         * WebCoreSupport/WebFrameLoaderClient.h: Override contentFilterDidBlockLoad().
3396         * WebCoreSupport/WebFrameLoaderClient.mm:
3397         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): Reset contentFilterForBlockedLoad to nullptr.
3398         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Check if this is navigation represents an
3399         unblock request and ignore if so.
3400         * WebView/WebFrame.mm:
3401         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Called ContentFilter::handleUnblockRequestAndDispatchIfSuccessful().
3402         If the unblock is successful, reload the main frame.
3403         * WebView/WebFrameInternal.h:
3404
3405 2014-07-17  David Kilzer  <ddkilzer@apple.com>
3406
3407         SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig
3408         <http://webkit.org/b/135006>
3409
3410         Reviewed by Darin Adler.
3411
3412         * Configurations/Base.xcconfig: Move SECTORDER_FLAGS to
3413         WebKitLegacy.xcconfig.
3414         * Configurations/DebugRelease.xcconfig: Remove empty
3415         SECTORDER_FLAGS definition.
3416         * Configurations/WebKit.xcconfig: Removed.  Unused.
3417         * Configurations/WebKitLegacy.xcconfig: Use $(CONFIGURATION) so
3418         SECTORDER_FLAGS is only set on Production builds.
3419
3420 2014-07-17  Timothy Hatcher  <timothy@apple.com>
3421
3422         Make console.profile record to the Timeline.
3423
3424         https://bugs.webkit.org/show_bug.cgi?id=134643
3425
3426         Reviewed by Joseph Pecoraro.
3427
3428         * WebInspector/WebInspector.mm:
3429         (-[WebInspector isProfilingJavaScript]):
3430         (-[WebInspector toggleProfilingJavaScript:]):
3431         (-[WebInspector startProfilingJavaScript:]):
3432         (-[WebInspector stopProfilingJavaScript:]):
3433         (-[WebInspector isJavaScriptProfilingEnabled]):
3434         (-[WebInspector setJavaScriptProfilingEnabled:]):
3435
3436 2014-07-16  David Kilzer  <ddkilzer@apple.com>
3437
3438         [iOS] Update order file paths for WebKit and WebKit2
3439         <http://webkit.org/b/134993>
3440         <rdar://problem/17557776>
3441
3442         Reviewed by Darin Adler.
3443
3444         * Configurations/Base.xcconfig: Rename WebKit.order to
3445         WebKitLegacy.order.
3446
3447 2014-07-16  Brady Eidson  <beidson@apple.com>
3448
3449         Add WebSecurityOrigin "webSecurityOriginFromDatabaseIdentifier" SPI and change _websiteDataURLForContainerWithURL: SPI
3450         <rdar://problem/17454712> and https://bugs.webkit.org/show_bug.cgi?id=134984
3451
3452         Reviewed by Dan Bernstein.
3453
3454         * WebCoreSupport/WebSecurityOrigin.mm:
3455         (+[WebSecurityOrigin webSecurityOriginFromDatabaseIdentifier:]): Added.
3456         (-[WebSecurityOrigin initWithURL:]): Update using RefPtr API to avoid a ref().
3457
3458 2014-07-15  Myles C. Maxfield  <mmaxfield@apple.com>
3459
3460         [OSX] [WK1] Crash when exiting fullscreen
3461         https://bugs.webkit.org/show_bug.cgi?id=134943
3462
3463         Reviewed by Dean Jackson.
3464
3465         AppKit doesn't remove a view from the Key View Loop when removing it from its superview.
3466
3467         This codepath is already "tested" in fullscreen/full-screen-cancel.html, but because of our
3468         testing infrastructure, the broken codepath doesn't actually get hit in DRT. Therefore,
3469         there is no test.
3470
3471         * WebView/WebFullScreenController.mm:
3472         (-[WebFullScreenController enterFullScreen:]):
3473
3474         * WebCoreSupport/WebSecurityOriginPrivate.h:
3475
3476 2014-07-14  Bear Travis  <betravis@adobe.com>
3477
3478         [Feature Queries] Enable Feature Queries on Mac
3479         https://bugs.webkit.org/show_bug.cgi?id=134404
3480
3481         Reviewed by Antti Koivisto.
3482
3483         Enable Feature Queries on Mac and resume running the
3484         feature tests.
3485
3486         * Configurations/FeatureDefines.xcconfig: Turn on
3487         ENABLE_CSS3_CONDITIONAL_RULES.
3488
3489 2014-07-11  Zalan Bujtas  <zalan@apple.com>
3490
3491         Subpixel layout: return integral results for offset*, client*, scroll* by default.
3492         https://bugs.webkit.org/show_bug.cgi?id=134651
3493
3494         Reviewed by Simon Fraser.
3495
3496         Revert to returning integral values for Element.offset* client* scroll* by default.
3497         Fractional values break number of sites(tight design) and JS frameworks(fail to handle fractional values).
3498
3499         Since snapped dimension depends on both the original point and the width/height of the box,
3500         we need to call RenderBoxModelObject::pixelSnapped*() helpers, instead of round().
3501
3502         Covered by existing tests
3503
3504         * WebView/WebPreferences.mm:
3505         (+[WebPreferences initialize]):
3506
3507 2014-07-10  Joseph Pecoraro  <pecoraro@apple.com>
3508
3509         [Mac] NSWindow warning: adding an unknown subview opening detached Inspector
3510         https://bugs.webkit.org/show_bug.cgi?id=134813
3511
3512         Reviewed by Timothy Hatcher.
3513
3514         * WebCoreSupport/WebInspectorClient.mm:
3515         (-[WebInspectorWindowController window]):
3516         Use a selector that will avoid the warning message.
3517
3518 2014-07-09  Ryosuke Niwa  <rniwa@webkit.org>
3519
3520         REGRESSION(r167770): Cannot login in Evernote Safari extension
3521         https://bugs.webkit.org/show_bug.cgi?id=134776
3522
3523         Reviewed by Enrica Casucci.
3524
3525         Unfortunately, NSWindowDidBecomeKeyNotification does not notify us when a popover becomes key
3526         so we need to keep using the SPI (_windowChangedKeyState) I removed in r167770.
3527
3528         * WebView/WebView.mm:
3529         (-[WebView _windowChangedKeyState]):
3530
3531 2014-07-09  Enrica Casucci  <enrica@apple.com>
3532
3533         Implement Editor::fontAttributesForSelectionStart() or iOS.
3534         https://bugs.webkit.org/show_bug.cgi?id=134771
3535         <rdar://problem/16167838>
3536
3537         Reviewed by Ryosuke Niwa.
3538
3539         * WebView/WebViewPrivate.h:
3540
3541 2014-07-08  Tim Horton  <timothy_horton@apple.com>
3542
3543         [WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
3544         https://bugs.webkit.org/show_bug.cgi?id=134645
3545
3546         Reviewed by Dan Bernstein.
3547
3548         * WebView/WebPreferences.mm:
3549         (-[WebPreferences setSubpixelCSSOMElementMetricsEnabled:]):
3550         Remove an extra unnecessary space.
3551
3552 2014-07-03  Daniel Bates  <dabates@apple.com>
3553
3554         Add WTF::move()
3555         https://bugs.webkit.org/show_bug.cgi?id=134500
3556
3557         Rubber-stamped by Anders Carlsson.
3558
3559         Substitute WTF::move() for std::move().
3560
3561         * History/WebHistoryItem.mm:
3562         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3563         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3564         (WebKit::NetscapePluginInstanceProxy::setCurrentReply):
3565         * Plugins/WebNetscapePluginView.mm:
3566         (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):