Adjust naming of action menu SPI
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
2
3         Adjust naming of action menu SPI
4         https://bugs.webkit.org/show_bug.cgi?id=140644
5         <rdar://problem/19448129>
6
7         Reviewed by Brian Weinstein.
8
9         * WebView/WebActionMenuController.mm:
10         (-[WebActionMenuController prepareForMenu:withEvent:]):
11         (-[WebActionMenuController willOpenMenu:withEvent:]):
12         (-[WebActionMenuController didCloseMenu:withEvent:]):
13         * WebView/WebView.mm:
14         (-[WebView _commonInitializationWithFrameName:groupName:]):
15         (-[WebView prepareForMenu:withEvent:]):
16         (-[WebView willOpenMenu:withEvent:]):
17         (-[WebView didCloseMenu:withEvent:]):
18
19 2015-01-19  Beth Dakin  <bdakin@apple.com>
20
21         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
22         offset by flipped-ness
23         https://bugs.webkit.org/show_bug.cgi?id=140643
24         -and corresponding-
25         rdar://problem/19489593
26
27         Reviewed by Tim Horton.
28
29         We universally flipped because we assumed that the root view was flipped and the 
30         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
31         fixes that assumption by checking the WebView’s flipped-ness.
32         * WebView/WebView.mm:
33         (-[WebView _convertRectFromRootView:]):
34
35 2015-01-19  Commit Queue  <commit-queue@webkit.org>
36
37         Unreviewed, rolling out r178653.
38         https://bugs.webkit.org/show_bug.cgi?id=140634
39
40         Broke multiple SVG tests on Mountain Lion (Requested by ap on
41         #webkit).
42
43         Reverted changeset:
44
45         "[SVG -> OTF Converter] Flip the switch on"
46         https://bugs.webkit.org/show_bug.cgi?id=140592
47         http://trac.webkit.org/changeset/178653
48
49 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
50
51         [SVG -> OTF Converter] Flip the switch on
52         https://bugs.webkit.org/show_bug.cgi?id=140592
53
54         Reviewed by Antti Koivisto.
55
56         * Configurations/FeatureDefines.xcconfig:
57
58 2015-01-18  Daniel Bates  <dabates@apple.com>
59
60         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
61         (https://bugs.webkit.org/show_bug.cgi?id=129441)
62
63         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
64         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
65
66         * WebInspector/WebNodeHighlightView.mm:
67         (-[WebNodeHighlightView layoutSublayers:]):
68
69 2015-01-16  Beth Dakin  <bdakin@apple.com>
70
71         Make sure early cancellation of immediate action actually does that in WK1
72         https://bugs.webkit.org/show_bug.cgi?id=140566
73         -and corresponding-
74         rdar://problem/19490114
75
76         Reviewed by Tim Horton.
77
78         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
79         asynchronously.
80         * WebView/WebImmediateActionController.mm:
81         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
82
83 2015-01-16  Daniel Bates  <dabates@apple.com>
84
85         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
86         (https://bugs.webkit.org/show_bug.cgi?id=140360)
87
88         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
89
90         * Misc/WebDownload.h:
91
92 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
93
94         Remove ENABLE(SQL_DATABASE) guards
95         https://bugs.webkit.org/show_bug.cgi?id=140434
96
97         Reviewed by Darin Adler.
98
99         * Configurations/FeatureDefines.xcconfig:
100         * Storage/WebDatabaseManager.mm:
101         (databasesDirectoryPath):
102         * Storage/WebDatabaseManagerClient.h:
103         * Storage/WebDatabaseManagerClient.mm:
104         * Storage/WebDatabaseManagerInternal.h:
105         * Storage/WebDatabaseManagerPrivate.h:
106         * Storage/WebDatabaseQuotaManager.mm:
107         (-[WebDatabaseQuotaManager usage]):
108         (-[WebDatabaseQuotaManager quota]):
109         (-[WebDatabaseQuotaManager setQuota:]):
110         * WebCoreSupport/WebChromeClient.h:
111         * WebCoreSupport/WebChromeClient.mm:
112         * WebCoreSupport/WebSecurityOrigin.mm:
113         (-[WebSecurityOrigin usage]):
114         (-[WebSecurityOrigin quota]):
115         (-[WebSecurityOrigin setQuota:]):
116         * WebView/WebFrame.mm:
117         (-[WebFrame _cacheabilityDictionary]):
118         * WebView/WebView.mm:
119         (-[WebView _commonInitializationWithFrameName:groupName:]):
120         (-[WebView _preferencesChanged:]):
121
122 2015-01-14  Chris Dumez  <cdumez@apple.com>
123
124         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
125         https://bugs.webkit.org/show_bug.cgi?id=140347
126
127         Reviewed by Darin Adler.
128
129         Call FontDescription::setIsItalic() instead of setItalic() as the
130         call site passes a boolean.
131
132         * WebView/WebHTMLView.mm:
133         (fontNameForDescription):
134
135 2015-01-13  Anders Carlsson  <andersca@apple.com>
136
137         Temporarily reintroduce the informal delegate protocols
138         https://bugs.webkit.org/show_bug.cgi?id=140416
139
140         Reviewed by Dan Bernstein.
141
142         * WebView/WebEditingDelegate.h:
143         * WebView/WebFrameLoadDelegate.h:
144         * WebView/WebPolicyDelegate.h:
145         * WebView/WebResourceLoadDelegate.h:
146         * WebView/WebUIDelegate.h:
147
148 2015-01-13  Beth Dakin  <bdakin@apple.com>
149
150         Should disable immediate actions for iTunes
151         https://bugs.webkit.org/show_bug.cgi?id=140405
152         -and corresponding-
153         rdar://problem/19461358
154
155         Reviewed by Tim Horton.
156
157         * WebView/WebImmediateActionController.mm:
158         (-[WebImmediateActionController _updateImmediateActionItem]):
159
160 2015-01-11  Sam Weinig  <sam@webkit.org>
161
162         Remove support for SharedWorkers
163         https://bugs.webkit.org/show_bug.cgi?id=140344
164
165         Reviewed by Anders Carlsson.
166
167         * Configurations/FeatureDefines.xcconfig:
168         * WebCoreSupport/WebPlatformStrategies.h:
169         * WebCoreSupport/WebPlatformStrategies.mm:
170         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
171
172 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
173
174         Get rid of unnecessary reimplementations of CGFloor/Ceiling
175         https://bugs.webkit.org/show_bug.cgi?id=140375
176
177         Reviewed by Simon Fraser.
178
179         * Misc/WebKitNSStringExtras.mm:
180         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
181         (webkit_CGCeiling): Deleted.
182         Delete unnecessary code, use the real CGFloor/Ceiling instead.
183
184 2015-01-12  Anders Carlsson  <andersca@apple.com>
185
186         Make delegates conform to formal delegate protocols
187         https://bugs.webkit.org/show_bug.cgi?id=140370
188
189         Reviewed by Dan Bernstein.
190
191         * DefaultDelegates/WebDefaultPolicyDelegate.h:
192         * WebCoreSupport/WebInspectorClient.mm:
193         Add protocols to the interface declarations.
194
195         * WebView/WebActionMenuController.mm:
196         (-[WebActionMenuController prepareForMenu:withEvent:]):
197         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
198         * WebView/WebImmediateActionController.mm:
199         (-[WebImmediateActionController _updateImmediateActionItem]):
200         (-[WebImmediateActionController _menuItemForDataDetectedText]):
201         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
202
203 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
204
205         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
206         https://bugs.webkit.org/show_bug.cgi?id=136769
207
208         Reviewed by Antti Koivisto.
209
210         * Configurations/FeatureDefines.xcconfig:
211
212 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
213
214         Multi-rect TextIndicators are vertically flipped in WebKit1
215         https://bugs.webkit.org/show_bug.cgi?id=140350
216         <rdar://problem/19441243>
217
218         Reviewed by Beth Dakin.
219
220         * WebView/WebView.mm:
221         (-[WebView _setTextIndicator:fadeOut:]):
222         Convert the textBoundingRect from root view to screen coordinates.
223
224 2015-01-12  Anders Carlsson  <andersca@apple.com>
225
226         Make WebResourceDelegate a formal protocol as well
227         https://bugs.webkit.org/show_bug.cgi?id=140364
228
229         Reviewed by Dan Bernstein.
230
231         * WebView/WebResourceLoadDelegate.h:
232
233 2015-01-12  Anders Carlsson  <andersca@apple.com>
234
235         Delegates should be formal protocols
236         https://bugs.webkit.org/show_bug.cgi?id=140360
237         rdar://problem/17380856
238
239         Reviewed by Dan Bernstein.
240
241         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
242
243         * DefaultDelegates/WebDefaultUIDelegate.h:
244         * Misc/WebDownload.h:
245         * WebView/WebEditingDelegate.h:
246         * WebView/WebFrameLoadDelegate.h:
247         * WebView/WebPolicyDelegate.h:
248         * WebView/WebUIDelegate.h:
249
250 2015-01-09  Anders Carlsson  <andersca@apple.com>
251
252         Get rid of the database strategy
253         https://bugs.webkit.org/show_bug.cgi?id=140322
254
255         Reviewed by Sam Weinig.
256
257         * WebCoreSupport/WebPlatformStrategies.h:
258         * WebCoreSupport/WebPlatformStrategies.mm:
259         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
260
261 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
262
263         Can't use DataDetectors after immediate action preparation
264         https://bugs.webkit.org/show_bug.cgi?id=140263
265         <rdar://problem/19412705>
266
267         Reviewed by Beth Dakin.
268
269         * WebView/WebImmediateActionController.mm:
270         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
271         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
272         To match WebKit2, only call shouldUseActions if the animation is actually
273         going to begin, not when preparing for it. This way, we're guaranteed
274         to get a didCancel or didComplete.
275
276 2015-01-08  Dean Jackson  <dino@apple.com>
277
278         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
279         https://bugs.webkit.org/show_bug.cgi?id=140232
280         <rdar://problem/19371010>
281
282         Reviewed by Anders Carlsson.
283
284         Remove the applicationChromeMode setting, but leave stubs in to make
285         sure existing binaries don't break.
286
287         * WebCoreSupport/WebInspectorClient.mm:
288         (-[WebInspectorWindowController init]):
289         * WebView/WebPreferenceKeysPrivate.h:
290         * WebView/WebPreferences.mm:
291         (+[WebPreferences initialize]):
292         (-[WebPreferences applicationChromeModeEnabled]):
293         (-[WebPreferences setApplicationChromeModeEnabled:]):
294         * WebView/WebView.mm:
295         (-[WebView _preferencesChanged:]):
296
297 2015-01-07  Daniel Bates  <dabates@apple.com>
298
299         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
300         https://bugs.webkit.org/show_bug.cgi?id=137371
301
302         Reviewed by David Kilzer.
303
304         Use SPI wrapper headers instead of directly references private SPI headers.
305
306         * Plugins/Hosted/NetscapePluginHostManager.mm:
307
308 2015-01-07  Commit Queue  <commit-queue@webkit.org>
309
310         Unreviewed, rolling out r178068.
311         https://bugs.webkit.org/show_bug.cgi?id=140235
312
313         Breaks the iOS build (Requested by enrica on #webkit).
314
315         Reverted changeset:
316
317         "[iOS] Make WebKit2 build with public iOS SDK and more build
318         fixes for DRT"
319         https://bugs.webkit.org/show_bug.cgi?id=137371
320         http://trac.webkit.org/changeset/178068
321
322 2015-01-07  Daniel Bates  <dabates@apple.com>
323
324         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
325         https://bugs.webkit.org/show_bug.cgi?id=137371
326
327         Reviewed by David Kilzer.
328
329         Use SPI wrapper headers instead of directly references private SPI headers.
330
331         * Plugins/Hosted/NetscapePluginHostManager.mm:
332
333 2015-01-07  Beth Dakin  <bdakin@apple.com>
334
335         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
336         link
337         https://bugs.webkit.org/show_bug.cgi?id=140206
338         -and corresponding-
339         rdar://problem/19300492
340
341         Reviewed by Tim Horton.
342
343         Providing and item frame will ensure that the original link is not obscured.
344         * WebView/WebImmediateActionController.mm:
345         (elementBoundingBoxInWindowCoordinatesFromNode):
346         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
347
348         For now use a max size that is smaller than the WebView, with the screen’s aspect 
349         ratio, and scaled down.
350         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
351
352 2015-01-07  Anders Carlsson  <andersca@apple.com>
353
354         Give simple HTML documents a database provider
355         https://bugs.webkit.org/show_bug.cgi?id=140192
356         rdar://problem/19398825
357
358         Reviewed by Tim Horton.
359
360         * WebView/WebView.mm:
361         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
362
363 2015-01-06  Anders Carlsson  <andersca@apple.com>
364
365         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
366         https://bugs.webkit.org/show_bug.cgi?id=140140
367
368         Reviewed by Andreas Kling.
369
370         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
371         out of WebCore since nobody else is using it.
372
373         * Plugins/WebNetscapePluginView.h:
374         * Plugins/WebNetscapePluginView.mm:
375         (-[WebNetscapePluginView _createPlugin]):
376         (-[WebNetscapePluginView _destroyPlugin]):
377         * Plugins/npapi.mm:
378         (NPN_PluginThreadAsyncCall):
379
380 2015-01-06  Anders Carlsson  <andersca@apple.com>
381
382         Add a WebKit1 database provider
383         https://bugs.webkit.org/show_bug.cgi?id=140126
384
385         Reviewed by Sam Weinig.
386
387         Set the database provider.
388
389         * WebView/WebView.mm:
390         (-[WebView _commonInitializationWithFrameName:groupName:]):
391
392 2015-01-06  Commit Queue  <commit-queue@webkit.org>
393
394         Unreviewed, rolling out r177963.
395         https://bugs.webkit.org/show_bug.cgi?id=140136
396
397         Caused lots of crashes (Requested by smfr on #webkit).
398
399         Reverted changeset:
400
401         "Add a WebKit1 database provider"
402         https://bugs.webkit.org/show_bug.cgi?id=140126
403         http://trac.webkit.org/changeset/177963
404
405 2015-01-06  Anders Carlsson  <andersca@apple.com>
406
407         Add a WebKit1 database provider
408         https://bugs.webkit.org/show_bug.cgi?id=140126
409
410         Reviewed by Sam Weinig.
411
412         Set the database provider.
413
414         * WebView/WebView.mm:
415         (-[WebView _commonInitializationWithFrameName:groupName:]):
416
417 2015-01-01  Jeff Miller  <jeffm@apple.com>
418
419         Update user-visible copyright strings to include 2015
420         https://bugs.webkit.org/show_bug.cgi?id=139880
421
422         Reviewed by Darin Adler.
423
424         * Info.plist:
425
426 2014-12-30  Dan Bernstein  <mitz@apple.com>
427
428         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
429         https://bugs.webkit.org/show_bug.cgi?id=140003
430
431         Reviewed by Darin Adler.
432
433         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
434         that takes their "string" parameter as a "value" "parameter and has an attribute telling
435         the compiler that if the "value" parameter is a format string then the function returns a
436         modified version of it. The result is that if UI_STRING is used as a format string parameter
437         to some function or method, the compiler will check the format specifiers in the string
438         against the other parameters.
439
440 2014-12-29  Dan Bernstein  <mitz@apple.com>
441
442         Fixed the iOS build.
443
444         * Configurations/WebKitLegacy.xcconfig:
445
446 2014-12-29  Anders Carlsson  <andersca@apple.com>
447
448         Get rid of some PageGroup storage functions
449         https://bugs.webkit.org/show_bug.cgi?id=139996
450
451         Reviewed by Sam Weinig.
452
453         Call WebStorageNamespaceProvider directly instead.
454
455         * Storage/WebStorageManager.mm:
456         (-[WebStorageManager syncLocalStorage]):
457         (+[WebStorageManager closeIdleLocalStorageDatabases]):
458         * WebView/WebView.mm:
459         (+[WebView _applicationWillTerminate]):
460
461 2014-12-29  Anders Carlsson  <andersca@apple.com>
462
463         Move storage code from WebCore to WebKit
464         https://bugs.webkit.org/show_bug.cgi?id=139558
465
466         Reviewed by Darin Adler.
467
468         * Storage/WebStorageManager.mm:
469         * Storage/WebStorageTrackerClient.h:
470         * WebView/WebView.mm:
471
472 2014-12-26  Dan Bernstein  <mitz@apple.com>
473
474         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
475         https://bugs.webkit.org/show_bug.cgi?id=139950
476
477         Reviewed by David Kilzer.
478
479         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
480         in a manner that works with Xcode 5.1.1.
481
482 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
483
484         Install a TextIndicator for link immediate actions
485         https://bugs.webkit.org/show_bug.cgi?id=139897
486         <rdar://problem/19333076>
487
488         Reviewed by Anders Carlsson.
489
490         * WebView/WebImmediateActionController.h:
491         * WebView/WebImmediateActionController.mm:
492         (-[WebImmediateActionController _clearImmediateActionState]):
493         Tear down the TextIndicator, just like WebKit2.
494
495         (-[WebImmediateActionController _defaultAnimationController]):
496         Install a TextIndicator for links.
497
498         (-[WebImmediateActionController menuItemDidClose:]):
499         Tear down the TextIndicator when the QL preview closes.
500
501         (-[WebImmediateActionController _menuItemForDataDetectedText]):
502         Directly install and uninstall the TextIndicator for DataDetectors.
503
504         (-[WebImmediateActionController _showTextIndicator]): Deleted.
505         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
506         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
507
508 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
509
510         [iOS] add optimized fullscreen API
511         https://bugs.webkit.org/show_bug.cgi?id=139833
512         <rdar://problem/18844486>
513
514         Reviewed by Simon Fraser.
515
516         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
517
518 2014-12-20  David Kilzer  <ddkilzer@apple.com>
519
520         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
521         <http://webkit.org/b/139463>
522
523         Reviewed by Mark Rowe.
524
525         * Configurations/Base.xcconfig:
526         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
527           on OS X.
528         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
529         * Configurations/DebugRelease.xcconfig:
530         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
531         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
532         * Configurations/Version.xcconfig:
533         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
534         * Configurations/WebKitLegacy.xcconfig:
535         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
536           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
537           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
538           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
539           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
540           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
541           WEBCORE_PRIVATE_HEADERS_DIR_Production and
542           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
543           based on SDK.
544         - Fix PRODUCTION_ROOT to actually be set properly.
545         - Simplify EXPORTED_SYMBOLS_FILE_i386.
546
547         * migrate-headers.sh:
548         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
549         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
550           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
551           WebKitLegacy.xcconfig.
552
553 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
554
555         Fix pink background on CoreAnimation plug-ins in WebKit1
556         https://bugs.webkit.org/show_bug.cgi?id=139845
557         rdar://problem/19313075
558
559         Reviewed by Tim Horton.
560         
561         r154078 left in some debugging code that set a pink background on plug-in hosting
562         layers. Remove it.
563
564         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
565         (-[WebHostedNetscapePluginView createPluginLayer]):
566
567 2014-12-19  Andreas Kling  <akling@apple.com>
568
569         Ref-ify TextIterator API.
570         <https://webkit.org/b/139823>
571
572         Reviewed by Antti Koivisto.
573
574         * WebView/WebTextIterator.mm:
575         (-[WebTextIterator currentRange]):
576
577 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
578
579         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
580         https://bugs.webkit.org/show_bug.cgi?id=139797
581
582         Reviewed by Mark Lam.
583
584         * WebView/WebScriptDebugger.h:
585         * WebView/WebScriptDebugger.mm:
586         (WebScriptDebugger::handlePause):
587         Standardize on passing JSGlobalObject parameter first.
588
589 2014-12-19  Commit Queue  <commit-queue@webkit.org>
590
591         Unreviewed, rolling out r177574.
592         https://bugs.webkit.org/show_bug.cgi?id=139821
593
594         "Broke Production builds by installing
595         libWebCoreTestSupport.dylib in the wrong directory" (Requested
596         by ddkilzer on #webkit).
597
598         Reverted changeset:
599
600         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
601         WebInspectorUI, WebKit, WebKit2"
602         https://bugs.webkit.org/show_bug.cgi?id=139463
603         http://trac.webkit.org/changeset/177574
604
605 2014-12-19  David Kilzer  <ddkilzer@apple.com>
606
607         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
608         <http://webkit.org/b/139463>
609
610         Reviewed by Mark Rowe.
611
612         * Configurations/Base.xcconfig:
613         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
614           on OS X.
615         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
616         * Configurations/DebugRelease.xcconfig:
617         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
618         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
619         * Configurations/Version.xcconfig:
620         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
621         * Configurations/WebKitLegacy.xcconfig:
622         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
623           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
624           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
625           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
626           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
627           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
628           WEBCORE_PRIVATE_HEADERS_DIR_Production and
629           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
630           based on SDK.
631         - Fix PRODUCTION_ROOT to actually be set properly.
632         - Simplify EXPORTED_SYMBOLS_FILE_i386.
633
634         * migrate-headers.sh:
635         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
636         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
637           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
638           WebKitLegacy.xcconfig.
639
640 2014-12-18  Andreas Kling  <akling@apple.com>
641
642         Ref-ify various Document-related things.
643         <https://webkit.org/b/139796>
644
645         Reviewed by Anders Carlsson.
646
647         * WebView/WebFrame.mm:
648         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
649
650 2014-12-18  Beth Dakin  <bdakin@apple.com>
651
652         Need to re-enable action menus
653         https://bugs.webkit.org/show_bug.cgi?id=139795
654         -and corresponding-
655         rdar://problem/19299367
656
657         Reviewed by Tim Horton.
658
659         Re-enable the menus by un-commenting the code to create the menu and controller.
660         * WebView/WebView.mm:
661         (-[WebView _commonInitializationWithFrameName:groupName:]):
662
663 2014-12-16  Sam Weinig  <sam@webkit.org>
664
665         Unify the Mac and iOS implementations of FontPlatformData a bit
666         https://bugs.webkit.org/show_bug.cgi?id=139721
667
668         Reviewed by Anders Carlsson.
669
670         * WebView/WebHTMLView.mm:
671         (fontNameForDescription):
672         Update for new function name.
673
674 2014-12-18  Antti Koivisto  <antti@apple.com>
675
676         Remove alwaysUseBaselineOfPrimaryFont setting
677         https://bugs.webkit.org/show_bug.cgi?id=139770
678
679         Reviewed by Anders Carlsson.
680
681         * WebView/WebPreferenceKeysPrivate.h:
682         * WebView/WebPreferences.mm:
683         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
684         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
685         * WebView/WebPreferencesPrivate.h:
686         * WebView/WebView.mm:
687         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
688         (-[WebView _preferencesChanged:]):
689
690 2014-12-17  Andreas Kling  <akling@apple.com>
691
692         Ref-ify Range::create().
693         <https://webkit.org/b/139755>
694
695         Reviewed by Anders Carlsson.
696
697         * WebView/WebHTMLRepresentation.mm:
698         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
699         * WebView/WebHTMLView.mm:
700         (-[WebHTMLView attributedString]):
701
702 2014-12-17  Anders Carlsson  <andersca@apple.com>
703
704         Unify -[WebResource description]
705         https://bugs.webkit.org/show_bug.cgi?id=139762
706
707         Reviewed by Dan Bernstein.
708
709         * WebView/WebResource.mm:
710         (-[WebResource description]):
711
712 2014-12-17  Anders Carlsson  <andersca@apple.com>
713
714         Get rid of an ugly #define hack in WebFrameLoaderClient
715         https://bugs.webkit.org/show_bug.cgi?id=139761
716
717         Reviewed by Dan Bernstein.
718
719         Also replace @private with @package in all public headers, for consistency.
720
721         * History/WebBackForwardList.h:
722         * History/WebHistory.h:
723         * Misc/WebDownload.h:
724         * WebCoreSupport/WebFrameLoaderClient.mm:
725         * WebView/WebArchive.h:
726         * WebView/WebDataSource.h:
727         * WebView/WebFrame.h:
728         * WebView/WebFrameView.h:
729         * WebView/WebPreferences.h:
730         * WebView/WebResource.h:
731
732 2014-12-17  Dan Bernstein  <mitz@apple.com>
733
734         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
735         https://bugs.webkit.org/show_bug.cgi?id=139760
736
737         Reviewed by Anders Carlsson.
738
739         * Configurations/WebKitLegacy.xcconfig:
740
741 2014-12-17  Andreas Kling  <akling@apple.com>
742
743         Purge PassRefPtr from Frame.
744         <https://webkit.org/b/139731>
745
746         Reviewed by Anders Carlsson.
747
748         * WebCoreSupport/WebFrameLoaderClient.mm:
749         (WebFrameLoaderClient::transitionToCommittedForNewPage):
750         * WebView/WebFrame.mm:
751         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
752         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
753         * WebView/WebFrameInternal.h:
754
755 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
756
757         Implement and adopt two new TextIndicator presentation animations
758         https://bugs.webkit.org/show_bug.cgi?id=139715
759         <rdar://problem/19237945>
760
761         Reviewed by Anders Carlsson.
762
763         * WebView/WebActionMenuController.mm:
764         (-[WebActionMenuController _showTextIndicator]):
765         * WebView/WebHTMLView.mm:
766         (-[WebHTMLView quickLookWithEvent:]):
767         Remove the completionHandler from text indicator presentation.
768
769         * WebView/WebImmediateActionController.mm:
770         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
771         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
772         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
773         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
774         (-[WebImmediateActionController _menuItemForDataDetectedText]):
775         (-[WebImmediateActionController _animationControllerForText]):
776         (-[WebImmediateActionController _showTextIndicator]):
777         Forward immediate action gesture recognizer animation progress
778         to TextIndicator. Force us to keep the selection when immediate
779         action popovers steal first responder status from the WebView.
780         If the Lookup range is equal to the selection range, use a Crossfade
781         animation; otherwise, use a FadeIn animation.
782
783         * WebView/WebView.mm:
784         (-[WebView _setMaintainsInactiveSelection:]):
785         (-[WebView maintainsInactiveSelection]):
786         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
787         (-[WebView _setTextIndicator:fadeOut:]):
788         (-[WebView _clearTextIndicator]):
789         (-[WebView _setTextIndicatorAnimationProgress:]):
790         (-[WebView _showDictionaryLookupPopup:]):
791         (-[WebView _dictionaryLookupPopoverWillClose:]):
792         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
793         Remove the completionHandler from text indicator presentation.
794         Add a _setMaintainsInactiveSelection, which allows WebKit internals
795         to change the return value of -maintainsInactiveSelection, allowing
796         us to keep the selection alive when the WebView loses first responder status.
797
798         * WebView/WebViewData.h:
799         * WebView/WebViewInternal.h:
800
801 2014-12-16  Andreas Kling  <akling@apple.com>
802
803         Use Ref for SecurityOrigin.
804         <https://webkit.org/b/139710>
805
806         Reviewed by Anders Carlsson.
807
808         * Storage/WebStorageTrackerClient.mm:
809         (WebStorageTrackerClient::dispatchDidModifyOrigin):
810         * WebView/WebView.mm:
811         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
812         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
813
814 2014-12-16  Beth Dakin  <bdakin@apple.com>
815
816         Crash getting default animation controller for some text
817         https://bugs.webkit.org/show_bug.cgi?id=139712
818         -and corresponding-
819         rdar://problem/19271707
820
821         Reviewed by Tim Horton.
822
823         Must null-check the range.
824         * WebView/WebImmediateActionController.mm:
825         (-[WebImmediateActionController _animationControllerForText]):
826
827 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
828
829         Immediate action popovers can get stuck open
830         https://bugs.webkit.org/show_bug.cgi?id=139709
831         <rdar://problem/19270279>
832
833         Reviewed by Beth Dakin.
834
835         * WebView/WebImmediateActionController.mm:
836         (-[WebImmediateActionController _clearImmediateActionState]):
837         Don't clear the animation controller; it breaks things and was unnecessary.
838
839 2014-12-16  Tim Horton  <timothy_horton@apple.com>
840
841         Disable TextIndication for Lookup immediate actions
842         https://bugs.webkit.org/show_bug.cgi?id=139684
843
844         Reviewed by Anders Carlsson.
845
846         * WebView/WebView.mm:
847         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
848
849 2014-12-15  Beth Dakin  <bdakin@apple.com>
850
851         Build fix.
852
853         * WebView/WebImmediateActionController.mm:
854
855 2014-12-15  Beth Dakin  <bdakin@apple.com>
856
857         Speculative build fix.
858
859         * WebView/WebView.mm:
860         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
861         * WebView/WebViewInternal.h:
862
863 2014-12-15  Beth Dakin  <bdakin@apple.com>
864
865         Make lookup an immediate action instead of an action menu item
866         https://bugs.webkit.org/show_bug.cgi?id=139661
867         -and corresponding-
868         rdar://problem/19198414
869
870         Reviewed by Tim Horton.
871
872         Remove the lookup menu items and non-unused static function associated with 
873         lookup.
874         * WebView/WebActionMenuController.mm:
875         (-[WebActionMenuController _defaultMenuItemsForText]):
876         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
877         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
878         (-[WebActionMenuController _createActionMenuItemForTag:]):
879         (-[WebActionMenuController _lookupText:]): Deleted.
880         (performDictionaryLookupForSelection): Deleted.
881         (performDictionaryLookupForRange): Deleted.
882
883         Set the defaultAnimationController to the lookup-provided animation controller 
884         when appropriate.
885         * WebView/WebImmediateActionController.mm:
886         (-[WebImmediateActionController _defaultAnimationController]):
887         (dictionaryPopupInfoForRange):
888         (-[WebImmediateActionController _animationControllerForText]):
889
890         New type.
891         * WebView/WebUIDelegatePrivate.h:
892
893         New function to get the lookup animation controller.
894         * WebView/WebView.mm:
895         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
896         * WebView/WebViewInternal.h:
897
898 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
899
900         Implement Data Detectors immediate actions for Legacy WebKit
901         https://bugs.webkit.org/show_bug.cgi?id=139619
902         <rdar://problem/19198539>
903
904         Reviewed by Beth Dakin.
905
906         * WebView/WebImmediateActionController.mm:
907         (-[WebImmediateActionController _menuItemForDataDetectedText]):
908         Note that this action context is only for immediate actions.
909
910 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
911
912         Addressing post-review comments in r177035
913         https://bugs.webkit.org/show_bug.cgi?id=139557
914
915         Reviewed by Darin Adler.
916
917         * WebView/WebActionMenuController.mm:
918         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
919
920 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
921
922         Implement Data Detectors immediate actions for Legacy WebKit
923         https://bugs.webkit.org/show_bug.cgi?id=139619
924         <rdar://problem/19198539>
925
926         Reviewed by Eric Carlson.
927
928         * WebView/WebHTMLView.mm:
929         (-[WebHTMLView mouseDown:mouseDown:]):
930         Send mouseDown along to the WebImmediateActionController too.
931
932         * WebView/WebImmediateActionController.h:
933         * WebView/WebImmediateActionController.mm:
934         (-[WebImmediateActionController webViewClosed]):
935         (-[WebImmediateActionController webView:willHandleMouseDown:]):
936         (-[WebImmediateActionController _cancelImmediateAction]):
937         (-[WebImmediateActionController _clearImmediateActionState]):
938         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
939         (-[WebImmediateActionController _defaultAnimationController]):
940         (-[WebImmediateActionController _updateImmediateActionItem]):
941         (-[WebImmediateActionController _menuItemForDataDetectedText]):
942         (-[WebImmediateActionController _showTextIndicator]):
943         (-[WebImmediateActionController _hideTextIndicator]):
944         Copy most of the DataDetectors implementation into WebImmediateActionController.
945
946         * WebView/WebUIDelegatePrivate.h:
947         Add a new type.
948
949         * WebView/WebView.mm:
950         (-[WebView _commonInitializationWithFrameName:groupName:]):
951         Temporarily disable action menus.
952
953         (-[WebView _immediateActionController]):
954         * WebView/WebViewInternal.h:
955
956 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
957
958         Delete Notation because we don't use it
959         https://bugs.webkit.org/show_bug.cgi?id=139171
960
961         Reviewed by Kent Tamura.
962
963         * MigrateHeaders.make:
964
965 2014-12-14  Andreas Kling  <akling@apple.com>
966
967         Replace PassRef with Ref/Ref&& across the board.
968         <https://webkit.org/b/139587>
969
970         Reviewed by Darin Adler.
971
972         * WebCoreSupport/WebEditorClient.mm:
973         (WebEditorClient::shouldApplyStyle):
974         * WebCoreSupport/WebVisitedLinkStore.h:
975         * WebCoreSupport/WebVisitedLinkStore.mm:
976         (WebVisitedLinkStore::create):
977
978 2014-12-11  Dan Bernstein  <mitz@apple.com>
979
980         Fix a leak introduced in r177199.
981
982         Reviewed by Anders Carlsson.
983
984         * WebView/WebImmediateActionController.mm:
985         (-[WebImmediateActionController _updateImmediateActionItem]):
986
987 2014-12-11  Beth Dakin  <bdakin@apple.com>
988
989         WK1: Need new SPI for Webkit clients to override default immediate action
990         https://bugs.webkit.org/show_bug.cgi?id=139568
991         -and corresponding-
992         rdar://problem/19225448
993
994         Reviewed by Dan Bernstein.
995
996         Call SPI giving clients a chance to override the default behavior.
997         * WebView/WebImmediateActionController.mm:
998         (-[WebImmediateActionController _updateImmediateActionItem]):
999
1000         New SPI.
1001         * WebView/WebUIDelegatePrivate.h:
1002
1003 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1004
1005         Move the preview popover to WebImmediateActionController
1006         https://bugs.webkit.org/show_bug.cgi?id=139563
1007         <rdar://problem/19208291>
1008
1009         Reviewed by Beth Dakin.
1010
1011         * WebView/WebActionMenuController.mm:
1012         (-[WebActionMenuController _defaultMenuItemsForLink]):
1013         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
1014         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
1015         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
1016         * WebView/WebImmediateActionController.h:
1017         * WebView/WebImmediateActionController.mm:
1018         (-[WebImmediateActionController webViewClosed]):
1019         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1020         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1021         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1022         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1023         (-[WebImmediateActionController _updateImmediateActionItem]):
1024         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
1025         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
1026         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
1027         Move page preview popover related code to WebImmediateActionController.
1028
1029         * WebView/WebUIDelegatePrivate.h:
1030         Add a link preview type.
1031
1032         * WebView/WebView.mm:
1033         (-[WebView _commonInitializationWithFrameName:groupName:]):
1034         Pass the gesture recognizer to the WebImmediateActionController.
1035
1036 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1037
1038         Fix the build.
1039
1040         * WebView/WebImmediateActionController.h:
1041         * WebView/WebImmediateActionController.mm:
1042
1043 2014-12-11  Anders Carlsson  <andersca@apple.com>
1044
1045         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
1046         https://bugs.webkit.org/show_bug.cgi?id=139547
1047
1048         Reviewed by Sam Weinig.
1049
1050         * WebView/WebView.mm:
1051         (+[WebView _handleMemoryWarning]):
1052
1053 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
1054
1055         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
1056         https://bugs.webkit.org/show_bug.cgi?id=139504
1057         rdar://problem/19034674
1058
1059         Reviewed by Enrica Casucci.
1060
1061         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
1062
1063         * WebCoreSupport/WebEditorClient.h:
1064         * WebCoreSupport/WebEditorClient.mm:
1065         (WebEditorClient::discardedComposition):
1066
1067 2014-12-10  Anders Carlsson  <andersca@apple.com>
1068
1069         Get rid of the storage strategy
1070         https://bugs.webkit.org/show_bug.cgi?id=139519
1071
1072         Reviewed by Antti Koivisto.
1073
1074         * WebCoreSupport/WebPlatformStrategies.h:
1075         * WebCoreSupport/WebPlatformStrategies.mm:
1076         (WebPlatformStrategies::createStorageStrategy): Deleted.
1077
1078 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1079
1080         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
1081         https://bugs.webkit.org/show_bug.cgi?id=139529
1082         <rdar://problem/19213620>
1083
1084         Reviewed by Beth Dakin.
1085
1086         * WebView/WebActionMenuController.mm:
1087         (-[WebActionMenuController _copySelection:]):
1088         (-[WebActionMenuController _paste:]):
1089         Use the copy: and paste: methods on WebView so that we traverse subviews
1090         when trying to respond, otherwise these actions don't work in subframes.
1091
1092 2014-12-10  Beth Dakin  <bdakin@apple.com>
1093
1094         WK1: Add initial support for immediate actions
1095         https://bugs.webkit.org/show_bug.cgi?id=139522
1096
1097         Reviewed by Dan Bernstein.
1098
1099         This basic implementation of the controller will use the delegate methods to 
1100         perform and cache a HitTest when relevant. Future patches will patch 
1101         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
1102         immediate action that should be taken.
1103         * WebView/WebImmediateActionController.h: Added.
1104         * WebView/WebImmediateActionController.mm: Added.
1105         (-[WebImmediateActionController webViewClosed]):
1106         (-[WebImmediateActionController _clearImmediateActionState]):
1107         (-[WebImmediateActionController performHitTestAtPoint:]):
1108         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1109         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1110         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1111         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1112         (-[WebImmediateActionController _updateImmediateActionItem]):
1113
1114         New enum for immediate action types.
1115         * WebView/WebUIDelegatePrivate.h:
1116
1117         Create an NSImmediateActionGestureRecognizer if possible and a controller.
1118         * WebView/WebView.mm:
1119         (-[WebView _commonInitializationWithFrameName:groupName:]):
1120         (-[WebView _close]):
1121         * WebView/WebViewData.h:
1122         * WebView/WebViewData.mm:
1123         (-[WebViewPrivate dealloc]):
1124
1125 2014-12-08  Anders Carlsson  <andersca@apple.com>
1126
1127         Use the new storage namespace provider in WebKit1
1128         https://bugs.webkit.org/show_bug.cgi?id=139425
1129
1130         Reviewed by Tim Horton.
1131
1132         * WebView/WebView.mm:
1133         (-[WebView _commonInitializationWithFrameName:groupName:]):
1134         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1135         Set the storage namespace provider from the web page group.
1136
1137 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1138
1139         Should have copy and paste items in all text menus
1140         https://bugs.webkit.org/show_bug.cgi?id=139510
1141         <rdar://problem/19198388>
1142
1143         Reviewed by Beth Dakin.
1144
1145         * WebView/WebActionMenuController.mm:
1146         (-[WebActionMenuController _defaultMenuItemsForText]):
1147         Add a disabled paste menu item into the read-only text menu.
1148
1149         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1150         Add a disabled copy menu item into the editable whitespace text menu.
1151
1152 2014-12-10  Anders Carlsson  <andersca@apple.com>
1153
1154         Add WebStorageNamespaceProvider::closeLocalStorage
1155         https://bugs.webkit.org/show_bug.cgi?id=139502
1156
1157         Reviewed by Tim Horton.
1158
1159         * WebView/WebView.mm:
1160         (+[WebView _applicationWillTerminate]):
1161         Call WebStorageNamespaceProvider::closeLocalStorage.
1162
1163 2014-12-09  Commit Queue  <commit-queue@webkit.org>
1164
1165         Unreviewed, rolling out r177037.
1166         https://bugs.webkit.org/show_bug.cgi?id=139464
1167
1168         broke ~50 API tests (Requested by thorton on #webkit).
1169
1170         Reverted changeset:
1171
1172         "Use the new storage namespace provider in WebKit1"
1173         https://bugs.webkit.org/show_bug.cgi?id=139425
1174         http://trac.webkit.org/changeset/177037
1175
1176 2014-12-08  Anders Carlsson  <andersca@apple.com>
1177
1178         Use the new storage namespace provider in WebKit1
1179         https://bugs.webkit.org/show_bug.cgi?id=139425
1180
1181         Reviewed by Tim Horton.
1182
1183         * WebView/WebView.mm:
1184         (-[WebView _commonInitializationWithFrameName:groupName:]):
1185         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1186         Set the storage namespace provider from the web page group.
1187
1188 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
1189
1190         Delete Node::boundingBox()
1191         https://bugs.webkit.org/show_bug.cgi?id=139333
1192
1193         Reviewed by Zalan Bujtas.
1194
1195         * WebView/WebActionMenuController.mm:
1196         (elementBoundingBoxInWindowCoordinatesFromNode): Use
1197         RenderObject::absoluteBoundingBoxRect().
1198
1199 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
1200
1201         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
1202         https://bugs.webkit.org/show_bug.cgi?id=138843
1203         rdar://problem/18793695
1204
1205         Reviewed by Dan Bernstein.
1206
1207         * Panels/WebAuthenticationPanel.m:
1208         (-[WebAuthenticationPanel cancel:]):
1209         (-[WebAuthenticationPanel logIn:]):
1210         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
1211         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
1212         that only when using an old NSWindow API.
1213
1214 2014-12-08  Beth Dakin  <bdakin@apple.com>
1215
1216         Copy and Lookup menu items should be disabled when something is not copyable
1217         https://bugs.webkit.org/show_bug.cgi?id=139423
1218
1219         Reviewed by Tim Horton.
1220
1221         Disable both lookup and copy when a HitTestResult does not allow copy.
1222         * WebView/WebActionMenuController.mm:
1223
1224         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
1225         disable state otherwise.
1226         * WebView/WebView.mm:
1227         (-[WebView _commonInitializationWithFrameName:groupName:]):
1228
1229 2014-12-08  Anders Carlsson  <andersca@apple.com>
1230
1231         Adding user content to a group should force that group to be created
1232         https://bugs.webkit.org/show_bug.cgi?id=139421
1233         rdar://problem/19180108
1234
1235         Reviewed by Sam Weinig.
1236
1237         * WebCoreSupport/WebViewGroup.h:
1238         Store the local storage database path in the group.
1239
1240         * WebCoreSupport/WebViewGroup.mm:
1241         (WebViewGroup::getOrCreate):
1242         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
1243         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
1244
1245         (WebViewGroup::WebViewGroup):
1246         Initialize the new member variable.
1247
1248         (WebViewGroup::storageNamespaceProvider):
1249         Create the namespace provider lazily.
1250
1251         * WebView/WebView.mm:
1252         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1253         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1254         Use getOrCreate instead of get.
1255
1256 2014-12-08  Anders Carlsson  <andersca@apple.com>
1257
1258         WebStorageNamespaceProvider should know about its local storage database path
1259         https://bugs.webkit.org/show_bug.cgi?id=139413
1260
1261         Reviewed by Andreas Kling.
1262
1263         * WebCoreSupport/WebViewGroup.h:
1264         * WebCoreSupport/WebViewGroup.mm:
1265         (WebViewGroup::getOrCreate):
1266         (WebViewGroup::WebViewGroup):
1267         * WebView/WebView.mm:
1268         (-[WebView _commonInitializationWithFrameName:groupName:]):
1269         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1270         (-[WebView setGroupName:]):
1271         (-[WebView groupName]): Deleted.
1272
1273 2014-12-08  Daniel Bates  <dabates@apple.com>
1274
1275         [iOS] Fix the WebKit build with the public SDK
1276
1277         Include header NSURLDownloadSPI.h.
1278
1279         * WebCoreSupport/WebFrameLoaderClient.mm:
1280
1281 2014-12-07  Dan Bernstein  <mitz@apple.com>
1282
1283         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
1284         https://bugs.webkit.org/show_bug.cgi?id=139348
1285
1286         Reviewed by Anders Carlsson.
1287
1288         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
1289         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
1290         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
1291         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
1292         avoiding the ambiguity.
1293
1294         * WebView/WebActionMenuController.mm:
1295         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1296
1297 2014-12-06  Anders Carlsson  <andersca@apple.com>
1298
1299         Add a stubbed out version of WebStorageNamespaceProvider
1300         https://bugs.webkit.org/show_bug.cgi?id=139213
1301
1302         Reviewed by Sam Weinig.
1303
1304         * WebCoreSupport/WebViewGroup.h:
1305         (WebViewGroup::storageNamespaceProvider):
1306         * WebCoreSupport/WebViewGroup.mm:
1307         (WebViewGroup::getOrCreate):
1308         (WebViewGroup::WebViewGroup):
1309         Give WebViewGroup a storage namespace provider.
1310
1311 2014-12-06  Anders Carlsson  <andersca@apple.com>
1312
1313         Fix build with newer versions of clang.
1314         rdar://problem/18978687
1315
1316         Add missing overrides and missing casts.
1317
1318         * Storage/WebDatabaseManagerClient.h:
1319         * Storage/WebStorageTrackerClient.h:
1320         * WebCoreSupport/WebChromeClient.h:
1321         * WebCoreSupport/WebFrameLoaderClient.h:
1322         * WebCoreSupport/WebInspectorClient.h:
1323         * WebView/WebDataSource.mm:
1324         (-[WebDataSource _makeRepresentation]):
1325         * WebView/WebFrameView.mm:
1326         (-[WebFrameView _makeDocumentViewForDataSource:]):
1327
1328 2014-12-05  Tim Horton  <timothy_horton@apple.com>
1329
1330         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
1331         https://bugs.webkit.org/show_bug.cgi?id=139306
1332         <rdar://problem/19157955>
1333
1334         Reviewed by Beth Dakin.
1335
1336         * WebView/WebView.mm:
1337         (-[WebView _commonInitializationWithFrameName:groupName:]):
1338         (-[WebView _initWithFrame:frameName:groupName:]):
1339         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
1340
1341 2014-12-05  David Kilzer  <ddkilzer@apple.com>
1342
1343         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
1344         <http://webkit.org/b/139286>
1345
1346         Reviewed by Daniel Bates.
1347
1348         * Configurations/FeatureDefines.xcconfig: Switch back to using
1349         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
1350
1351 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
1352
1353         Fix the 32-bit build.
1354
1355         * WebView/WebView.mm:
1356         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1357
1358 2014-12-04  Tim Horton  <timothy_horton@apple.com>
1359
1360         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
1361         https://bugs.webkit.org/show_bug.cgi?id=139252
1362         <rdar://problem/19140827>
1363
1364         Reviewed by Anders Carlsson.
1365
1366         * WebView/WebView.mm:
1367         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1368         Adjust to the WebCore changes.
1369
1370 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1371
1372         Implement action menus for tel: URLs
1373         https://bugs.webkit.org/show_bug.cgi?id=139240
1374         <rdar://problem/19115662>
1375
1376         Reviewed by Anders Carlsson.
1377
1378         * WebView/WebActionMenuController.mm:
1379         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1380         Make sure to use the newly created currentActionContext... everywhere.
1381
1382 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1383
1384         Implement action menus for tel: URLs
1385         https://bugs.webkit.org/show_bug.cgi?id=139240
1386         <rdar://problem/19115662>
1387
1388         Reviewed by Anders Carlsson.
1389
1390         * WebView/WebActionMenuController.mm:
1391         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1392         Make sure to use the newly created currentActionContext.
1393
1394 2014-12-03  Beth Dakin  <bdakin@apple.com>
1395
1396         <input> elements get whitespace action menu instead of editable text menu
1397         https://bugs.webkit.org/show_bug.cgi?id=139241
1398         -and corresponding-
1399         rdar://problem/19072083
1400
1401         Reviewed by Sam Weinig.
1402
1403         We should disallow shadow content in the hit test. This is the default and it is 
1404         how context menus behave. We originally wanted to text inside shadow content so 
1405         that we could find the text, but the new function I added to HitTestResult will 
1406         allow that.
1407         * WebView/WebActionMenuController.mm:
1408         (-[WebActionMenuController performHitTestAtPoint:]):
1409
1410         Adjust to the fact that we don’t hit test shadow content any more.
1411         (-[WebActionMenuController focusAndSelectHitTestResult]):
1412
1413         Offer the text menus for text inside form controls.
1414         (-[WebActionMenuController _defaultMenuItems]):
1415
1416 2014-12-03  Tim Horton  <timothy_horton@apple.com>
1417
1418         Implement action menus for tel: URLs
1419         https://bugs.webkit.org/show_bug.cgi?id=139240
1420         <rdar://problem/19115662>
1421
1422         Reviewed by Anders Carlsson.
1423
1424         * WebView/WebActionMenuController.mm:
1425         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1426         Rename this function as it will work for both mailto and tel URLs.
1427         Adjust it to use contextForView:.
1428
1429         (-[WebActionMenuController webView:willHandleMouseDown:]):
1430         (-[WebActionMenuController prepareForMenu:withEvent:]):
1431         (-[WebActionMenuController didCloseMenu:withEvent:]):
1432         (-[WebActionMenuController _defaultMenuItems]):
1433         Don't check the menu type when going to interact with _currentActionContext.
1434         We'll only have a _currentActionContext if we have a data detected item,
1435         and there are multiple menu types that end up using DDActionContext.
1436
1437         * WebView/WebUIDelegatePrivate.h:
1438         Add a new type.
1439
1440 2014-12-03  Anders Carlsson  <andersca@apple.com>
1441
1442         Set a visited link store when creating a simple WebView
1443         https://bugs.webkit.org/show_bug.cgi?id=139234
1444         <rdar://problem/19132978>
1445
1446         Reviewed by Sam Weinig.
1447
1448         * WebView/WebView.mm:
1449         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1450
1451 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1452
1453         Fix the build.
1454
1455         * WebCoreSupport/WebFrameLoaderClient.mm:
1456
1457 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1458
1459         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1460         https://bugs.webkit.org/show_bug.cgi?id=139149
1461
1462         Reviewed by Anders Carlsson.
1463
1464         This changes API behavior. I think that it's OK, because existing behavior made no sense.
1465         We used to delete caches from disk, but they were still active in memory. Now we also
1466         obsolete them in memory, so documents that use a cache still work, but new ones don't
1467         pick one up.
1468
1469         * WebCoreSupport/WebApplicationCache.mm:
1470         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
1471         need to delete in-momry caches too. Keep existing behavior.
1472         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
1473         that properly deletes caches.
1474
1475 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1476
1477         Remove a SnowLeopard-era quirk for QuickLook
1478         https://bugs.webkit.org/show_bug.cgi?id=139208
1479         <rdar://problem/19121822>
1480
1481         Reviewed by Alexey Proskuryakov.
1482
1483         * WebCoreSupport/WebFrameLoaderClient.h:
1484         * WebCoreSupport/WebFrameLoaderClient.mm:
1485
1486 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1487
1488         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
1489         https://bugs.webkit.org/show_bug.cgi?id=139204
1490
1491         Reviewed by Anders Carlsson.
1492
1493         * WebView/WebView.mm:
1494         (-[WebView _commonInitializationWithFrameName:groupName:]):
1495         (-[WebView _showDictionaryLookupPopup:]):
1496         * WebView/WebViewData.h:
1497         Work around this by delaying the softlinking (and setting up the notification
1498         observer) until we actually need it. There's still an underlying bug, but
1499         this will fix the test.
1500
1501 2014-12-02  Beth Dakin  <bdakin@apple.com>
1502
1503         Yet another build fix.
1504
1505         * WebView/WebActionMenuController.mm:
1506         (-[WebActionMenuController _defaultMenuItemsForLink]):
1507
1508 2014-12-02  Beth Dakin  <bdakin@apple.com>
1509
1510         Build fix.
1511
1512         * WebView/WebActionMenuController.mm:
1513         (-[WebActionMenuController _defaultMenuItemsForLink]):
1514
1515 2014-12-02  Beth Dakin  <bdakin@apple.com>
1516
1517         More build fixing.
1518
1519         * WebView/WebActionMenuController.mm:
1520         (-[WebActionMenuController _defaultMenuItemsForLink]):
1521
1522 2014-12-02  Beth Dakin  <bdakin@apple.com>
1523
1524         Should use standardQuickLookMenuItem for apps that don't implement customizations
1525         https://bugs.webkit.org/show_bug.cgi?id=139193
1526         -and corresponding-
1527         rdar://problem/18944696
1528
1529         Reviewed by Anders Carlsson.
1530
1531         Use [NSMenuItem standardQuickLookMenuItem].
1532         * WebView/WebActionMenuController.mm:
1533         (-[WebActionMenuController _defaultMenuItemsForLink]):
1534
1535         Delegate methods to set up the standardQuickLookMenuItem.
1536         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
1537         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
1538         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
1539
1540         Remove all of the old QLPreviewBubble code.
1541         (-[WebActionMenuController _createActionMenuItemForTag:]):
1542         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
1543
1544 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1545
1546         Fix the build.
1547
1548         * WebView/WebViewData.h:
1549
1550 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1551
1552         Implement Lookup transition from selection for Legacy WebKit
1553         https://bugs.webkit.org/show_bug.cgi?id=139180
1554         <rdar://problem/19067172>
1555
1556         Reviewed by Beth Dakin.
1557
1558         * WebView/DictionaryPopupInfo.h: Added.
1559         Split DictionaryPopupInfo out into its own file.
1560
1561         * WebView/WebActionMenuController.mm:
1562         (-[WebActionMenuController _lookupText:]):
1563         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
1564
1565         (performDictionaryLookupForSelection):
1566         (performDictionaryLookupForRange):
1567         Plumb the transition style through these helpers.
1568         Create a TextIndicator from the selection range.
1569
1570         * WebView/WebHTMLView.mm:
1571         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1572         Make use of TextIndicator (and DictionaryPopupInfo, and the new
1573         _showDictionaryLookupPopup on WebView) to add a transition from blue
1574         when performing Lookup from the context menu.
1575
1576         (-[WebHTMLView quickLookWithEvent:]):
1577         Remove our TextIndicator whenever a normal three-finger-tap event
1578         comes through, as it will have its own indication.
1579
1580         * WebView/WebView.mm:
1581         (-[WebView _commonInitializationWithFrameName:groupName:]):
1582         (-[WebView _dictionaryLookupPopoverWillClose:]):
1583         Register for the LUNotificationPopoverWillClose notification and remove
1584         our TextIndicator when it is called, just like in WebKit2.
1585         Deregistration is already handled in _close.
1586
1587         (-[WebView _showDictionaryLookupPopup:]):
1588         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
1589         if the relevant API is available.
1590
1591         * WebView/WebViewInternal.h:
1592
1593 2014-12-02  Anders Carlsson  <andersca@apple.com>
1594
1595         Remove visited link handling from PageGroup
1596         https://bugs.webkit.org/show_bug.cgi?id=139185
1597
1598         Reviewed by Sam Weinig.
1599
1600         * History/WebHistory.mm:
1601         (-[WebHistoryPrivate removeItemForURLString:]):
1602         (-[WebHistoryPrivate removeAllItems]):
1603         (+[WebHistory setOptionalSharedHistory:]):
1604         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1605         (+[WebHistory _removeAllVisitedLinks]):
1606         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
1607         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
1608         * History/WebHistoryInternal.h:
1609         * WebCoreSupport/WebChromeClient.h:
1610         * WebCoreSupport/WebChromeClient.mm:
1611         (WebChromeClient::populateVisitedLinks): Deleted.
1612         * WebView/WebView.mm:
1613         (-[WebView addVisitedLinks:]):
1614         (-[WebView removeVisitedLink:]):
1615
1616 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1617
1618         Try to fix the Mac build.
1619
1620         * WebView/WebView.mm:
1621         (-[WebView _commonInitializationWithFrameName:groupName:]):
1622         (-[WebView _close]):
1623
1624 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1625
1626         Fix the iOS build.
1627
1628         * WebView/WebActionMenuController.h:
1629         * WebView/WebActionMenuController.mm:
1630         * WebView/WebHTMLView.mm:
1631         (-[WebHTMLView scrollWheel:scrollWheel:]):
1632         (-[WebHTMLView mouseDown:mouseDown:]):
1633         * WebView/WebView.mm:
1634         * WebView/WebViewData.h:
1635         * WebView/WebViewData.mm:
1636         (-[WebViewPrivate dealloc]):
1637         * WebView/WebViewInternal.h:
1638
1639 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1640
1641         Implement yellow highlight for WebKit1 data detectors
1642         https://bugs.webkit.org/show_bug.cgi?id=138956
1643         <rdar://problem/18992185>
1644
1645         Reviewed by Beth Dakin.
1646
1647         * WebView/WebActionMenuController.h:
1648         * WebView/WebActionMenuController.mm:
1649         (-[WebActionMenuController webView:willHandleMouseDown:]):
1650         (-[WebActionMenuController webView:didHandleScrollWheel:]):
1651         (-[WebActionMenuController prepareForMenu:withEvent:]):
1652         (-[WebActionMenuController didCloseMenu:withEvent:]):
1653         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1654         (-[WebActionMenuController _showTextIndicator]):
1655         (-[WebActionMenuController _hideTextIndicator]):
1656         (-[WebActionMenuController _dismissActionMenuPopovers]):
1657         Copy the WebKit2 WKActionMenuController TextIndicator implementation
1658         into WebActionMenuController. The only significant difference is
1659         that we build the TextIndicator right at menu construction time
1660         instead of in the Web process.
1661
1662         * WebView/WebHTMLView.mm:
1663         (-[WebHTMLView scrollWheel:]):
1664         Let the WebActionMenuController know that we're handling a scroll.
1665
1666         (-[WebHTMLView mouseDown:]):
1667         Let the WebActionMenuController know that we're handling a mouseDown.
1668
1669         * WebView/WebView.mm:
1670         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1671         (-[WebView _clearTextIndicator]):
1672         (-[WebView _actionMenuController]):
1673         (-[WebView _convertRectFromRootView:]): Deleted.
1674         * WebView/WebViewData.h:
1675         * WebView/WebViewData.mm:
1676         * WebView/WebViewInternal.h:
1677         Keep a TextIndicatorWindow on WebView, just like WKView does.
1678         Expose the WebActionMenuController on WebView (internally).
1679
1680 2014-12-01  Anders Carlsson  <andersca@apple.com>
1681
1682         Remove old site specific quirks code that was added in 2009
1683         https://bugs.webkit.org/show_bug.cgi?id=139141
1684
1685         Reviewed by Antti Koivisto.
1686
1687         * WebCoreSupport/WebFrameNetworkingContext.h:
1688         * WebCoreSupport/WebFrameNetworkingContext.mm:
1689         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
1690
1691 2014-11-30  Anders Carlsson  <andersca@apple.com>
1692
1693         Fix a test failure.
1694
1695         * History/WebHistory.mm:
1696         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1697         Call through to the visited link store.
1698
1699         (+[WebHistory _removeAllVisitedLinks]):
1700         Ditto.
1701
1702         * WebCoreSupport/WebVisitedLinkStore.mm:
1703         (WebVisitedLinkStore::isLinkVisited):
1704         Make sure to populate visited links.
1705
1706 2014-11-30  Anders Carlsson  <andersca@apple.com>
1707
1708         Switch over to the visited link store from the WebViewGroup
1709         https://bugs.webkit.org/show_bug.cgi?id=139112
1710
1711         Reviewed by Sam Weinig.
1712
1713         * WebView/WebView.mm:
1714         (-[WebView _commonInitializationWithFrameName:groupName:]):
1715         (-[WebView setGroupName:]):
1716
1717 2014-11-30  Anders Carlsson  <andersca@apple.com>
1718
1719         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
1720         https://bugs.webkit.org/show_bug.cgi?id=139111
1721
1722         Reviewed by Sam Weinig.
1723
1724         * WebCoreSupport/WebVisitedLinkStore.h:
1725         * WebCoreSupport/WebVisitedLinkStore.mm:
1726         (WebVisitedLinkStore::removeVisitedLink):
1727         * WebView/WebView.mm:
1728         (-[WebView removeVisitedLink:]):
1729
1730 2014-11-29  Anders Carlsson  <andersca@apple.com>
1731
1732         Populate visited links
1733         https://bugs.webkit.org/show_bug.cgi?id=139101
1734
1735         Reviewed by Sam Weinig.
1736
1737         * History/WebHistory.mm:
1738         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
1739         Helper function that adds all visited link to the given store.
1740
1741         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
1742         Call the private method.
1743
1744         * History/WebHistoryInternal.h:
1745         * WebCoreSupport/WebVisitedLinkStore.h:
1746         Add new members.
1747
1748         * WebCoreSupport/WebVisitedLinkStore.mm:
1749         (WebVisitedLinkStore::addVisitedLink):
1750         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
1751
1752         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1753         Implement this. First try the delegate, then try the shared history.
1754
1755         (WebVisitedLinkStore::addVisitedLinkHash):
1756         Factor code that adds the link to the hash table into a separate function.
1757
1758         * WebView/WebView.mm:
1759         (-[WebView addVisitedLinks:]):
1760         Add the visited links to the store.
1761
1762 2014-11-29  Anders Carlsson  <andersca@apple.com>
1763
1764         More work on the legacy WebKit visited link store
1765         https://bugs.webkit.org/show_bug.cgi?id=139100
1766
1767         Reviewed by Sam Weinig.
1768
1769         * History/WebHistory.mm:
1770         (+[WebHistory setOptionalSharedHistory:]):
1771         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
1772
1773         * WebCoreSupport/WebVisitedLinkStore.h:
1774         * WebCoreSupport/WebVisitedLinkStore.mm:
1775         (visitedLinkStores):
1776         (WebVisitedLinkStore::WebVisitedLinkStore):
1777         (WebVisitedLinkStore::~WebVisitedLinkStore):
1778         Keep track of live visited link stores.
1779
1780         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
1781         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
1782
1783         (WebVisitedLinkStore::removeAllVisitedLinks):
1784         Iterate over all live link stores and remove their links.
1785
1786         (WebVisitedLinkStore::isLinkVisited):
1787         Populate visited links and check if our hash table contains the link.
1788
1789         (WebVisitedLinkStore::addVisitedLink):
1790         Add the link hash to the table.
1791
1792         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1793         Add stub.
1794
1795         (WebVisitedLinkStore::removeVisitedLinkHashes):
1796         Clear out the hash table.
1797
1798 2014-11-27  Anders Carlsson  <andersca@apple.com>
1799
1800         Add a stubbed out WebVisitedLinkStore to WebViewGroup
1801         https://bugs.webkit.org/show_bug.cgi?id=139066
1802
1803         Reviewed by Antti Koivisto.
1804
1805         * WebCoreSupport/WebViewGroup.h:
1806         (WebViewGroup::visitedLinkStore):
1807         * WebCoreSupport/WebViewGroup.mm:
1808         (WebViewGroup::WebViewGroup):
1809         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1810         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1811         (WebVisitedLinkStore::create):
1812         (WebVisitedLinkStore::WebVisitedLinkStore):
1813         (WebVisitedLinkStore::~WebVisitedLinkStore):
1814         (WebVisitedLinkStore::isLinkVisited):
1815         (WebVisitedLinkStore::addVisitedLink):
1816
1817 2014-11-25  Anders Carlsson  <andersca@apple.com>
1818
1819         Remove user content handling from PageGroup
1820         https://bugs.webkit.org/show_bug.cgi?id=139051
1821
1822         Reviewed by Antti Koivisto.
1823
1824         Use the user content controller in the web view group.
1825
1826         * WebView/WebView.mm:
1827         (-[WebView _injectOutlookQuirksScript]):
1828
1829 2014-11-25  Anders Carlsson  <andersca@apple.com>
1830
1831         Add a user content controller to WebViewGroup and use it for user content
1832         https://bugs.webkit.org/show_bug.cgi?id=139043
1833
1834         Reviewed by Antti Koivisto.
1835
1836         This is another tiny step towards getting rid of user content handling inside PageGroup.
1837
1838         * WebCoreSupport/WebViewGroup.h:
1839         (WebViewGroup::userContentController):
1840         Add a UserContentController member and getter.
1841
1842         * WebCoreSupport/WebViewGroup.mm:
1843         (WebViewGroup::get):
1844         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
1845
1846         (WebViewGroup::WebViewGroup):
1847         Create a user content controller.
1848
1849         * WebView/WebView.mm:
1850         (-[WebView _commonInitializationWithFrameName:groupName:]):
1851         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
1852         set its user content controller in the PageConfiguration.
1853
1854         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1855         Ditto.
1856
1857         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1858         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1859         (+[WebView _removeUserScriptFromGroup:world:url:]):
1860         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
1861         (+[WebView _removeUserScriptsFromGroup:world:]):
1862         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
1863         (+[WebView _removeAllUserContentFromGroup:]):
1864         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
1865
1866         (-[WebView setGroupName:]):
1867         Set the user content controller to the new WebViewGroup's user content controller.
1868
1869 2014-11-21  Jer Noble  <jer.noble@apple.com>
1870
1871         Support multiple signatures of diagnostic logging.
1872         https://bugs.webkit.org/show_bug.cgi?id=138690
1873
1874         Reviewed by Anders Carlsson.
1875
1876         Page::PageClients has been renamed PageConfiguration.
1877
1878         * WebView/WebView.mm:
1879         (-[WebView _commonInitializationWithFrameName:groupName:]):
1880         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1881
1882 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1883
1884         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1885         https://bugs.webkit.org/show_bug.cgi?id=138981
1886
1887         Reviewed by Simon Fraser.
1888
1889         * WebView/WebPreferenceKeysPrivate.h:
1890         * WebView/WebPreferences.mm:
1891         (+[WebPreferences initialize]):
1892         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
1893         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
1894         * WebView/WebPreferencesPrivate.h:
1895         * WebView/WebView.mm:
1896         (-[WebView _preferencesChanged:]):
1897
1898 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1899
1900         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1901         ​https://bugs.webkit.org/show_bug.cgi?id=138960
1902         <rdar://problem/19056715>
1903
1904         Reviewed by Anders Carlsson.
1905
1906         * WebView/WebActionMenuController.mm:
1907         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1908         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1909         Use DataDetectors SPI instead of an explicit blacklist.
1910
1911 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1912
1913         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1914         https://bugs.webkit.org/show_bug.cgi?id=138960
1915         <rdar://problem/19056715>
1916
1917         Reviewed by Beth Dakin.
1918
1919         * WebView/WebActionMenuController.mm:
1920         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1921         Blacklist contact results, because they don't have useful menus. If we
1922         bail before setting up _currentActionContext, we'll still allow fallthrough
1923         to ordinary text actions, avoiding mysterious failure when a contact is detected.
1924
1925         This doesn't break the case that r176351 was intended to fix,
1926         because in that case we were detecting e.g. addresses.
1927
1928 2014-11-21  Anders Carlsson  <andersca@apple.com>
1929
1930         Remove the Timer parameters from timer callbacks
1931         https://bugs.webkit.org/show_bug.cgi?id=138974
1932
1933         Reviewed by Antti Koivisto.
1934
1935         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1936         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1937         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
1938         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1939         * Plugins/WebNetscapePluginStream.h:
1940         * Plugins/WebNetscapePluginStream.mm:
1941         (WebNetscapePluginStream::WebNetscapePluginStream):
1942         (WebNetscapePluginStream::deliverDataTimerFired):
1943
1944 2014-11-21  Anders Carlsson  <andersca@apple.com>
1945
1946         Make memoryCache() return a reference
1947         https://bugs.webkit.org/show_bug.cgi?id=138939
1948
1949         Reviewed by Antti Koivisto.
1950
1951         * Misc/WebCache.mm:
1952         (+[WebCache statistics]):
1953         (+[WebCache emptyInMemoryResources]):
1954         (+[WebCache sizeOfDeadResources:]):
1955         (+[WebCache addImageToCache:forURL:forFrame:]):
1956         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1957         (+[WebCache imageForURL:]):
1958         (+[WebCache setDisabled:]):
1959         (+[WebCache isDisabled]):
1960         * WebView/WebView.mm:
1961         (+[WebView _setCacheModel:]):
1962
1963 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
1964
1965         Remove the remaining vestiges of minimal-ui
1966         https://bugs.webkit.org/show_bug.cgi?id=138890
1967
1968         Reviewed by Sam Weinig.
1969
1970         * History/WebHistoryItem.mm:
1971         * History/WebHistoryItemPrivate.h:
1972
1973 2014-11-20  Tim Horton  <timothy_horton@apple.com>
1974
1975         Cancel DataDetectors menu earlier if we know it can't be presented
1976         https://bugs.webkit.org/show_bug.cgi?id=138922
1977         <rdar://problem/18950441>
1978
1979         Reviewed by Beth Dakin.
1980
1981         * WebView/WebActionMenuController.mm:
1982         (-[WebActionMenuController prepareForMenu:withEvent:]):
1983         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
1984         and use a bigger hammer (removeAllItems).
1985
1986         (-[WebActionMenuController willOpenMenu:withEvent:]):
1987         If we end up with a menu with no items, don't change selection or anything.
1988
1989 2014-11-20  Beth Dakin  <bdakin@apple.com>
1990
1991         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
1992         https://bugs.webkit.org/show_bug.cgi?id=138568
1993         -and corresponding-
1994         rdar://problem/18904600
1995
1996         Reviewed by Tim Horton.
1997
1998         Skip images for lookup.
1999         * WebView/WebActionMenuController.mm:
2000         (performDictionaryLookupForRange):
2001
2002 2014-11-19  Beth Dakin  <bdakin@apple.com>
2003
2004         Invoking an action menu on a selection should result in the text menu
2005         https://bugs.webkit.org/show_bug.cgi?id=138892
2006         -and corresponding-
2007         rdar://problem/18996776
2008
2009         Reviewed by Tim Horton.
2010
2011         * WebView/WebActionMenuController.mm:
2012         (-[WebActionMenuController _defaultMenuItems]):
2013
2014 2014-11-19  Beth Dakin  <bdakin@apple.com>
2015
2016         Data detected results with no menu items should not fall through to regular text 
2017         action menus
2018         https://bugs.webkit.org/show_bug.cgi?id=138887
2019         -and corresponding-
2020         rdar://problem/18971616
2021
2022         Reviewed by Tim Horton.
2023
2024         * WebView/WebActionMenuController.mm:
2025         (-[WebActionMenuController _defaultMenuItems]):
2026
2027 2014-11-19  Daniel Bates  <dabates@apple.com>
2028
2029         [iOS] Make WebKit build with public iOS SDK
2030         https://bugs.webkit.org/show_bug.cgi?id=136863
2031
2032         Reviewed by David Kilzer.
2033
2034         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
2035         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
2036         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
2037         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
2038         may be used by Apple internal clients that do not include wtf/Platform.h.
2039         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
2040         private Foundation headers directly.
2041         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
2042         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
2043         instead of including private CFNetwork headers directly. Also fixed up style and
2044         ordering of header include directives.
2045         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
2046         CFNetwork headers directly. Also sort the #import directives.
2047         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
2048         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
2049
2050 2014-11-18  David Kilzer  <ddkilzer@apple.com>
2051
2052         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
2053         <http://webkit.org/b/138813>
2054
2055         Reviewed by Mark Rowe.
2056
2057         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
2058         selectors.
2059
2060 2014-11-18  Chris Dumez  <cdumez@apple.com>
2061
2062         Add a setting to toggle DOMTimer throttling support
2063         https://bugs.webkit.org/show_bug.cgi?id=138844
2064         <rdar://problem/19020874>
2065
2066         Reviewed by Andreas Kling.
2067
2068         Add a setting to disable DOM timers throttling, in order to help
2069         developers determine if a specific issue is caused by timer
2070         throttling.
2071
2072         * WebView/WebPreferenceKeysPrivate.h:
2073         * WebView/WebPreferences.mm:
2074         (+[WebPreferences initialize]):
2075         (-[WebPreferences domTimersThrottlingEnabled]):
2076         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
2077         * WebView/WebPreferencesPrivate.h:
2078         * WebView/WebView.mm:
2079         (-[WebView _preferencesChanged:]):
2080
2081 2014-11-18  Tim Horton  <timothy_horton@apple.com>
2082
2083         Avoid re-encoding action menu image data
2084         https://bugs.webkit.org/show_bug.cgi?id=138817
2085         <rdar://problem/18840382>
2086
2087         Reviewed by Anders Carlsson.
2088
2089         * WebView/WebActionMenuController.mm:
2090         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2091         (-[WebActionMenuController _addImageToPhotos:]):
2092         Build a temporary filename from a UUID and the image's desired extension.
2093         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
2094         Build an image menu only if we have an image, URL, data, and extension.
2095
2096 2014-11-18  Daniel Bates  <dabates@apple.com>
2097
2098         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2099         SPI are not available in public SDK
2100         https://bugs.webkit.org/show_bug.cgi?id=138802
2101
2102         Reviewed by David Kilzer.
2103
2104         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2105         libdispatch and MobileGestalt headers directly.
2106
2107         * WebView/WebView.mm:
2108
2109 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
2110
2111         Remove calls to deprecated NSMenu methods
2112         https://bugs.webkit.org/show_bug.cgi?id=138808.
2113
2114         Reviewed by Anders Carlsson.
2115
2116         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
2117
2118         * WebCoreSupport/PopupMenuMac.mm:
2119         (PopupMenuMac::populate):
2120
2121 2014-11-17  Daniel Bates  <dabates@apple.com>
2122
2123         Unreviewed, rolling out r176232.
2124
2125         Broke the Mac build. Will investigate offline.
2126
2127         Reverted changeset:
2128
2129         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2130         MobileGestalt"
2131         https://bugs.webkit.org/show_bug.cgi?id=138802
2132         http://trac.webkit.org/changeset/176232
2133
2134 2014-11-17  Daniel Bates  <dabates@apple.com>
2135
2136         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2137         SPI are not available in public SDK
2138         https://bugs.webkit.org/show_bug.cgi?id=138802
2139
2140         Reviewed by David Kilzer.
2141
2142         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2143         libdispatch and MobileGestalt headers directly.
2144
2145         * WebView/WebView.mm:
2146
2147 2014-11-17  Beth Dakin  <bdakin@apple.com>
2148
2149         Whitespace action menus should focus the HitTestResult and create an insertion 
2150         point
2151         https://bugs.webkit.org/show_bug.cgi?id=138786
2152         -and corresponding-
2153         rdar://problem/18944893
2154
2155         Reviewed by Tim Horton.
2156
2157         Whitespace menus should cause the HitTestResult to be focused, and they should set 
2158         the selection based on the HitTest location.
2159
2160         * WebView/WebActionMenuController.mm:
2161         (-[WebActionMenuController isMenuForTextContent]):
2162         (-[WebActionMenuController focusAndSelectHitTestResult]):
2163         (-[WebActionMenuController willOpenMenu:withEvent:]):
2164
2165 2014-11-17  Daniel Bates  <dabates@apple.com>
2166
2167         [iOS] QuartzCore SPI not available in public SDK
2168         https://bugs.webkit.org/show_bug.cgi?id=138751
2169
2170         Reviewed by David Kilzer.
2171
2172         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
2173
2174         * WebInspector/WebNodeHighlight.mm:
2175         * WebView/WebIndicateLayer.mm:
2176
2177 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
2178
2179         [iOS] allow host application to opt-out of alternate fullscreen
2180         https://bugs.webkit.org/show_bug.cgi?id=138787
2181
2182         Reviewed by Darin Adler.
2183
2184         * WebView/WebPreferenceKeysPrivate.h:
2185         * WebView/WebPreferences.mm:
2186         (+[WebPreferences initialize]):
2187         (-[WebPreferences allowsAlternateFullscreen]):
2188         (-[WebPreferences setAllowsAlternateFullscreen:]):
2189         * WebView/WebPreferencesPrivate.h:
2190         * WebView/WebView.mm:
2191         (-[WebView _preferencesChanged:]):
2192
2193 2014-11-16  Tim Horton  <timothy_horton@apple.com>
2194
2195         Use TextIndicator instead of the built in Lookup highlight
2196         https://bugs.webkit.org/show_bug.cgi?id=138775
2197         <rdar://problem/18953982>
2198
2199         Reviewed by Anders Carlsson.
2200
2201         * WebCoreSupport/WebSystemInterface.mm:
2202         (InitWebCoreSystemInterface):
2203         Remove a WKSI import.
2204
2205         * WebView/WebActionMenuController.mm:
2206         (-[WebActionMenuController _lookupText:]):
2207         (-[WebActionMenuController _createActionMenuItemForTag:]):
2208         Make use of the new Lookup SPI header.
2209         Disable the Lookup item if lookup is not available.
2210
2211 2014-11-15  Tim Horton  <timothy_horton@apple.com>
2212
2213         Implement data detectors and mailto action menus for WebKit1
2214         https://bugs.webkit.org/show_bug.cgi?id=138765
2215         <rdar://problem/18877535>
2216
2217         Reviewed by Beth Dakin.
2218
2219         * WebView/WebActionMenuController.h:
2220         * WebView/WebActionMenuController.mm:
2221         (-[WebActionMenuController willOpenMenu:withEvent:]):
2222         Tell DataDetectors that the menu is going to open.
2223         Select the text (or not) based on the number of items in the menu, just like WebKit2.
2224
2225         (-[WebActionMenuController didCloseMenu:withEvent:]):
2226         Tell DataDetectors that the menu closed.
2227
2228         (-[WebActionMenuController _defaultMenuItemsForLink]):
2229         Move these checks out of _defaultMenuItemsForLink, because we expect this
2230         to always return a complete link menu.
2231
2232         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2233         Implement. More or less copied from WebKit2.
2234
2235         (-[WebActionMenuController _selectDataDetectedText]):
2236         Select the stashed range.
2237
2238         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2239         Implement. More or less copied from WebKit2.
2240         The yellow highlight isn't hooked up yet.
2241         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
2242
2243         (-[WebActionMenuController _selectLookupText]):
2244         Remove an unnecessary return.
2245
2246         (-[WebActionMenuController _defaultMenuItems]):
2247         Call into the two new menu types.
2248
2249         * WebView/WebUIDelegatePrivate.h:
2250
2251 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
2252
2253         Get rid of WebFontCache
2254         https://bugs.webkit.org/show_bug.cgi?id=134752
2255
2256         Reviewed by Dave Hyatt.
2257
2258         * WebView/WebHTMLView.mm:
2259
2260 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
2261
2262         Update some artwork for the legacy WebKit action menu
2263         https://bugs.webkit.org/show_bug.cgi?id=138758
2264         <rdar://problem/18989840>
2265
2266         * WebView/WebActionMenuController.mm:
2267         (webKitBundleImageNamed): Deleted.
2268         Fix the build.
2269
2270 2014-11-14  Tim Horton  <timothy_horton@apple.com>
2271
2272         Update some artwork for the legacy WebKit action menu
2273         https://bugs.webkit.org/show_bug.cgi?id=138758
2274         <rdar://problem/18989840>
2275
2276         Reviewed by Simon Fraser.
2277
2278         * WebView/WebActionMenuController.mm:
2279         (-[WebActionMenuController _createActionMenuItemForTag:]):
2280
2281 2014-11-14  Daniel Bates  <dabates@apple.com>
2282
2283         [iOS] NSFileManager and QuickLook SPI not available in public SDK
2284         https://bugs.webkit.org/show_bug.cgi?id=138742
2285
2286         Reviewed by Pratik Solanki.
2287
2288         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
2289
2290         * WebCoreSupport/WebFrameLoaderClient.mm:
2291
2292 2014-11-14  Beth Dakin  <bdakin@apple.com>
2293
2294         WK1: Webpage preview can come up in wrong location
2295         https://bugs.webkit.org/show_bug.cgi?id=138747
2296         -and corresponding-
2297         rdar://problem/18979004
2298
2299         Reviewed by Tim Horton.
2300
2301         Converting to window twice is bad.
2302         * WebView/WebActionMenuController.mm:
2303         (elementBoundingBoxInWindowCoordinatesFromNode):
2304         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2305         (elementBoundingBoxFromNode): Deleted.
2306
2307 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2308
2309         Move FontMac and FontCacheMac off of WKSI
2310         https://bugs.webkit.org/show_bug.cgi?id=138633
2311
2312         Reviewed by Simon Fraser.
2313
2314         * WebCoreSupport/WebSystemInterface.mm:
2315         (InitWebCoreSystemInterface):
2316         * WebKit.order:
2317
2318 2014-11-13  Beth Dakin  <bdakin@apple.com>
2319
2320         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
2321         https://bugs.webkit.org/show_bug.cgi?id=138716
2322         -and corresponding-
2323         rdar://problem/18977222
2324
2325         Reviewed by Tim Horton.
2326
2327         It’s not necessary to use the WebElementDictionary for so many things now that we 
2328         are caching the HitTestResult. We should just use the HitTestResult.
2329
2330         * WebView/WebActionMenuController.mm:
2331         (-[WebActionMenuController prepareForMenu:withEvent:]):
2332         (-[WebActionMenuController _openURLFromActionMenu:]):
2333         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2334         (elementBoundingBoxFromNode):
2335         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2336         (-[WebActionMenuController _defaultMenuItemsForLink]):
2337         (-[WebActionMenuController _defaultMenuItemsForImage]):
2338         (-[WebActionMenuController _defaultMenuItemsForVideo]):
2339         (-[WebActionMenuController _defaultMenuItemsForText]):
2340         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2341         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2342         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2343         (-[WebActionMenuController _createActionMenuItemForTag:]):
2344         (-[WebActionMenuController _defaultMenuItems]):
2345         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
2346         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
2347         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
2348         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
2349         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
2350         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
2351         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
2352         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
2353         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
2354         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
2355
2356 2014-11-13  Daniel Bates  <dabates@apple.com>
2357
2358         [iOS] NSGeometry data types are not available in the public SDK
2359         https://bugs.webkit.org/show_bug.cgi?id=137536
2360
2361         Reviewed by David Kilzer.
2362
2363         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
2364         private header.
2365
2366         * DOM/WebDOMOperationsPrivate.h:
2367
2368 2014-11-13  Beth Dakin  <bdakin@apple.com>
2369
2370         WK1: Support default actions for video
2371         https://bugs.webkit.org/show_bug.cgi?id=138713
2372         -and corresponding-
2373         rdar://problem/18877520
2374
2375         Reviewed by Tim Horton.
2376
2377         Call setToNonShadowAncestor() for media HitTestResults.
2378         * WebView/WebActionMenuController.mm:
2379         (-[WebActionMenuController performHitTestAtPoint:]):
2380
2381         Default items and actions.
2382         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
2383         (-[WebActionMenuController _copyVideoURL:]):
2384         (-[WebActionMenuController _saveVideoToDownloads:]):
2385         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2386         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2387         * WebView/WebUIDelegatePrivate.h:
2388
2389 2014-11-13  Tim Horton  <timothy_horton@apple.com>
2390
2391         WK1: Update icon for Add to Reading List
2392         https://bugs.webkit.org/show_bug.cgi?id=138710
2393         <rdar://problem/18975774>
2394
2395         Reviewed by Beth Dakin.
2396
2397         * WebView/WebActionMenuController.mm:
2398         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2399         Use the right icon, matching WebKit2.
2400
2401 2014-11-12  Beth Dakin  <bdakin@apple.com>
2402
2403         WK1: Support default actions for images
2404         https://bugs.webkit.org/show_bug.cgi?id=138668
2405         -and corresponding-
2406         rdar://problem/18785434
2407
2408         Reviewed by Tim Horton.
2409
2410         * WebView/WebActionMenuController.h:
2411         * WebView/WebActionMenuController.mm:
2412         (-[WebActionMenuController didCloseMenu:withEvent:]):
2413         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2414         (-[WebActionMenuController _copyImage:]):
2415         (temporaryPhotosDirectoryPath):
2416         (pathToPhotoOnDisk):
2417         (-[WebActionMenuController _canAddMediaToPhotos]):
2418         (-[WebActionMenuController _addImageToPhotos:]):
2419         (-[WebActionMenuController _saveImageToDownloads:]):
2420         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2421         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
2422         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2423         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2424         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2425         * WebView/WebUIDelegatePrivate.h:
2426
2427 2014-11-11  Beth Dakin  <bdakin@apple.com>
2428
2429         Action menu hit testing is not working properly with all WK1 apps
2430         https://bugs.webkit.org/show_bug.cgi?id=138643
2431         -and corresponding-
2432         rdar://problem/18949376
2433
2434         Reviewed by Tim Horton.
2435
2436         * WebView/WebActionMenuController.mm:
2437         (-[WebActionMenuController prepareForMenu:withEvent:]):
2438         (-[WebActionMenuController _lookupText:]):
2439
2440 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2441
2442         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
2443         https://bugs.webkit.org/show_bug.cgi?id=138623
2444
2445         Reviewed by Geoff Garen.
2446
2447         * WebCoreSupport/WebSystemInterface.mm:
2448         (InitWebCoreSystemInterface):
2449         * WebKit.order:
2450
2451 2014-11-11  Tim Horton  <timothy_horton@apple.com>
2452
2453         Localize strings for action menus
2454         https://bugs.webkit.org/show_bug.cgi?id=138591
2455         <rdar://problem/18815343>
2456
2457         Reviewed by Dan Bates.
2458
2459         * WebView/WebActionMenuController.mm:
2460         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2461         Make use of the new strings.
2462
2463 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2464
2465         Cleanup from r175379
2466         https://bugs.webkit.org/show_bug.cgi?id=138616
2467
2468         Reviewed by Simon Fraser.
2469
2470         * WebCoreSupport/WebSystemInterface.mm:
2471         (InitWebCoreSystemInterface):
2472         * WebKit.order:
2473
2474 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2475
2476         Move CTFontTransformGlyphs out from WKSI
2477         https://bugs.webkit.org/show_bug.cgi?id=138599
2478
2479         Reviewed by Simon Fraser.
2480
2481         * WebCoreSupport/WebSystemInterface.mm:
2482         (InitWebCoreSystemInterface):
2483         * WebKit.order:
2484
2485 2014-11-11  Dan Bernstein  <mitz@apple.com>
2486
2487         More iOS build fix.
2488
2489         * WebView/WebHTMLViewInternal.h:
2490
2491 2014-11-11  Dan Bernstein  <mitz@apple.com>
2492
2493         iOS build fix.
2494
2495         * WebView/WebHTMLView.mm:
2496
2497 2014-11-10  Beth Dakin  <bdakin@apple.com>
2498
2499         WK1: Support default actions for editable text with misspelled word
2500         https://bugs.webkit.org/show_bug.cgi?id=138590
2501         -and corresponding-
2502         rdar://problem/18877506
2503
2504         Reviewed by Tim Horton.
2505
2506         If there are misspelled word suggestions for editable text, create a new type of 
2507         menu with a spelling suggestion sub-menu.
2508
2509         * WebView/WebActionMenuController.mm:
2510         (-[WebActionMenuController isMenuForTextContent]):
2511         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
2512         (-[WebActionMenuController _changeSelectionToSuggestion:]):
2513         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2514         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2515         * WebView/WebHTMLView.mm:
2516         (-[WebHTMLView _changeSpellingToWord:]):
2517         * WebView/WebHTMLViewInternal.h:
2518         * WebView/WebUIDelegatePrivate.h:
2519
2520 2014-11-10  Beth Dakin  <bdakin@apple.com>
2521
2522         WK1: Support default actions for editable whitespace
2523         https://bugs.webkit.org/show_bug.cgi?id=138586
2524         -and corresponding-
2525         rdar://problem/18932048
2526
2527         Reviewed by Tim Horton.
2528
2529         New menu type. Just wants paste.
2530
2531         * WebView/WebActionMenuController.mm:
2532         (-[WebActionMenuController isMenuForTextContent]):
2533         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
2534         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2535         * WebView/WebUIDelegatePrivate.h:
2536
2537 2014-11-10  Beth Dakin  <bdakin@apple.com>
2538
2539         WK1: Support default actions for editable text
2540         https://bugs.webkit.org/show_bug.cgi?id=138580
2541         -and corresponding-
2542         rdar://problem/18877497
2543
2544         Reviewed by Tim Horton.
2545
2546         New menu type, and new action type for paste. 
2547
2548         * WebView/WebActionMenuController.mm:
2549         (-[WebActionMenuController isMenuForTextContent]):
2550         (-[WebActionMenuController willOpenMenu:withEvent:]):
2551         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
2552         (-[WebActionMenuController _paste:]):
2553         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2554         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2555         * WebView/WebUIDelegatePrivate.h:
2556
2557 2014-11-10  Beth Dakin  <bdakin@apple.com>
2558
2559         WK1: Text is getting selected even when an action menu fails to invoke
2560         https://bugs.webkit.org/show_bug.cgi?id=138576
2561         -and corresponding-
2562         rdar://problem/18931330
2563
2564         Reviewed by Tim Horton.
2565
2566         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
2567         * WebView/WebActionMenuController.h:
2568         * WebView/WebActionMenuController.mm:
2569         (-[WebActionMenuController prepareForMenu:withEvent:]):
2570         (-[WebActionMenuController willOpenMenu:withEvent:]):
2571
2572         _selectLookupText no longer needs to return a BOOL indicating success or failure.
2573         (-[WebActionMenuController _selectLookupText]):
2574         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2575
2576         Pass willOpenMenu: on to the controller.
2577         * WebView/WebView.mm:
2578         (-[WebView willOpenMenu:withEvent:]):
2579
2580 2014-11-10  Beth Dakin  <bdakin@apple.com>
2581
2582         Speculative build fix.
2583
2584         * WebView/WebActionMenuController.mm:
2585
2586 2014-11-10  Beth Dakin  <bdakin@apple.com>
2587
2588         Action menu initialization should be moved to _commonInitializationWithFrameName
2589         https://bugs.webkit.org/show_bug.cgi?id=138572
2590         -and corresponding-
2591         rdar://problem/18929733
2592
2593         Reviewed by Tim Horton.
2594
2595         * WebView/WebView.mm:
2596         (-[WebView _commonInitializationWithFrameName:groupName:]):
2597         (-[WebView _initWithFrame:frameName:groupName:]):
2598
2599 2014-11-10  Beth Dakin  <bdakin@apple.com>
2600
2601         WK1: Support default actions for read-only text
2602         https://bugs.webkit.org/show_bug.cgi?id=138552
2603         -and corresponding-
2604         rdar://problem/18877483
2605
2606         Reviewed by Tim Horton.
2607
2608         New WKSystemInterface functions that WebCore needs to use.
2609         * WebCoreSupport/WebSystemInterface.mm:
2610         (InitWebCoreSystemInterface):
2611
2612         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
2613         makes a lot of things easier.
2614         * WebView/WebActionMenuController.h:
2615         * WebView/WebActionMenuController.mm:
2616
2617         Perform the hit test ourselves instead of calling into WebView so that we can more 
2618         easily save the WebCore::HitTestResult for ourselves.
2619         (-[WebActionMenuController performHitTestAtPoint:]):
2620
2621         Clear selection for non-text menus.
2622         (-[WebActionMenuController prepareForMenu:withEvent:]):
2623
2624         Re-set the _type here just to be safe.
2625         (-[WebActionMenuController didCloseMenu:withEvent:]):
2626
2627         Moving this method to be next to the link actions so they can be within a pragma 
2628         mark.
2629         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2630
2631         New method for default text actions — lookup and copy.
2632         (-[WebActionMenuController _defaultMenuItemsForText:]):
2633         (-[WebActionMenuController _copySelection:]):
2634         (-[WebActionMenuController _lookupText:]):
2635
2636         If there is not already a selection, invoking the action menu on text should 
2637         select the lookup text.
2638         (-[WebActionMenuController _selectLookupText]):
2639         (performDictionaryLookupForSelection):
2640         (performDictionaryLookupForRange):
2641
2642         Handle text now.
2643         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2644         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2645
2646         New enum values.
2647         * WebView/WebUIDelegatePrivate.h:
2648
2649         Pass didCloseMenu on to the controller.
2650         * WebView/WebView.mm:
2651         (-[WebView didCloseMenu:withEvent:]):
2652
2653 2014-11-09  Chris Dumez  <cdumez@apple.com>
2654
2655         Add a more correct way to compare floating point numbers and use it
2656         https://bugs.webkit.org/show_bug.cgi?id=138527
2657
2658         Reviewed by Darin Adler.
2659
2660         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
2661         to compare floating-point numbers.
2662
2663         * WebView/WebHTMLView.mm:
2664         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2665
2666 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2667
2668         Delete cookies between tests
2669         https://bugs.webkit.org/show_bug.cgi?id=138528
2670
2671         Reviewed by Sam Weinig.
2672
2673         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
2674         * WebView/WebPreferencesPrivate.h:
2675         Added an SPI for DumpRenderTree.
2676
2677 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
2678
2679         [iOS] Update optimized fullscreen media controls
2680         https://bugs.webkit.org/show_bug.cgi?id=138493
2681
2682         Reviewed by Brent Fulgham.
2683
2684         * WebCoreSupport/WebSystemInterface.mm:
2685         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
2686
2687 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
2688
2689         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
2690         https://bugs.webkit.org/show_bug.cgi?id=138443
2691
2692         Reviewed by Anders Carlsson.
2693
2694         Wrapping the dealloc method in its own autorelease pool avoids the problem of
2695         complex tear-downs leading to the WebView itself being added to an autorelease
2696         pool that is not drained until after the instance has been dealloc'd.
2697  
2698         * WebView/WebView.mm:
2699         (-[WebView dealloc]):
2700
2701 2014-11-05  Jer Noble  <jer.noble@apple.com>
2702
2703         De-templatize Timer
2704         https://bugs.webkit.org/show_bug.cgi?id=138450
2705
2706         Reviewed by Anders Carlsson.
2707
2708         Remove template specifiers from Timer.
2709
2710         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2711         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2712         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2713         * Plugins/WebNetscapePluginStream.h:
2714         * Plugins/WebNetscapePluginStream.mm:
2715         (WebNetscapePluginStream::deliverDataTimerFired):
2716
2717 2014-11-05  Dan Bernstein  <mitz@apple.com>
2718
2719         Remove the unused deletion UI feature
2720         https://bugs.webkit.org/show_bug.cgi?id=138442
2721
2722         Rubber-stamped by Alexey Proskuryakov.
2723
2724         * DefaultDelegates/WebDefaultEditingDelegate.m:
2725         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
2726         * WebCoreSupport/WebEditorClient.h:
2727         * WebCoreSupport/WebEditorClient.mm:
2728         (WebEditorClient::shouldShowDeleteInterface): Deleted.
2729         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
2730         -webView:shouldShowDeleteInterfaceForElement:.
2731
2732 2014-11-03  Dean Jackson  <dino@apple.com>
2733
2734         Add ENABLE_FILTERS_LEVEL_2 feature guard.
2735         https://bugs.webkit.org/show_bug.cgi?id=138362
2736
2737         Reviewed by Tim Horton.
2738
2739         Add a new feature define for Level 2 of CSS Filters.
2740         http://dev.w3.org/fxtf/filters-2/
2741
2742         * Configurations/FeatureDefines.xcconfig:
2743
2744 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
2745
2746         Add button and enable optimized fullscreen.
2747         https://bugs.webkit.org/show_bug.cgi?id=138351
2748
2749         Reviewed by Eric Carlson.
2750
2751         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
2752
2753         * WebCoreSupport/WebSystemInterface.mm:
2754         (InitWebCoreSystemInterface): added
2755
2756 2014-11-04  Chris Dumez  <cdumez@apple.com>
2757
2758         Add ptr() method to Ref class
2759         https://bugs.webkit.org/show_bug.cgi?id=138361
2760
2761         Reviewed by Darin Adler.
2762
2763         Use the new Ref::ptr() method.
2764
2765         * WebView/WebFrame.mm:
2766         (-[WebFrame _setTypingStyle:withUndoAction:]):
2767         * WebView/WebHTMLView.mm:
2768         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2769         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2770         * WebView/WebView.mm:
2771         (-[WebView applyStyle:]):
2772
2773 2014-11-04  Darin Adler  <darin@apple.com>
2774
2775         Eliminate ResourceBuffer and use SharedBuffer directly instead
2776         https://bugs.webkit.org/show_bug.cgi?id=138174
2777
2778         Reviewed by Antti Koivisto.
2779
2780         * WebView/WebDataSource.mm:
2781         (-[WebDataSource data]): Use SharedBuffer directly.
2782         * WebView/WebHTMLView.mm:
2783         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2784
2785 2014-11-03  Commit Queue  <commit-queue@webkit.org>
2786
2787         Unreviewed, rolling out r175406, r175413, and r175423.
2788         https://bugs.webkit.org/show_bug.cgi?id=138327
2789
2790         Multipart tests are still broken (Requested by ap on #webkit).
2791
2792         Reverted changesets:
2793
2794         "Eliminate ResourceBuffer and use SharedBuffer directly
2795         instead"
2796         https://bugs.webkit.org/show_bug.cgi?id=138174
2797         http://trac.webkit.org/changeset/175406
2798
2799         "Unreviewed, iOS build fix since 175406."
2800         http://trac.webkit.org/changeset/175413
2801
2802         "Fix assertion in CachedResource::addDataBuffer"
2803         http://trac.webkit.org/changeset/175423
2804
2805 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2806
2807         Use std::unique_ptr for TypeCountSet
2808         https://bugs.webkit.org/show_bug.cgi?id=138242
2809
2810         Reviewed by Andreas Kling.
2811
2812         * Misc/WebCoreStatistics.mm:
2813         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
2814         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
2815
2816 2014-10-31  Beth Dakin  <bdakin@apple.com>
2817
2818         Use system art for action menus when possible
2819         https://bugs.webkit.org/show_bug.cgi?id=138260
2820
2821         Reviewed by Tim Horton.
2822
2823         * WebView/WebActionMenuController.mm:
2824         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2825
2826 2014-10-30  Darin Adler  <darin@apple.com>
2827
2828         Eliminate ResourceBuffer and use SharedBuffer directly instead
2829         https://bugs.webkit.org/show_bug.cgi?id=138174
2830
2831         Reviewed by Antti Koivisto.
2832
2833         * WebView/WebDataSource.mm:
2834         (-[WebDataSource data]): Use SharedBuffer directly.
2835         * WebView/WebHTMLView.mm:
2836         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2837
2838 2014-10-30  Jer Noble  <jer.noble@apple.com>
2839
2840         [EME] Add Setting for accessing storage location for MediaKeys data
2841         https://bugs.webkit.org/show_bug.cgi?id=138147
2842
2843         Reviewed by Brady Eidson.
2844
2845         * WebView/WebPreferenceKeysPrivate.h:
2846         * WebView/WebPreferences.mm:
2847         (+[WebPreferences initialize]): Set default location.
2848         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
2849         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
2850         * WebView/WebPreferencesPrivate.h:
2851         * WebView/WebView.mm:
2852         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
2853
2854 2014-10-30  Dana Burkart  <dburkart@apple.com>
2855
2856         <rdar://problem/18821260> Prepare for the mysterious future
2857
2858         Reviewed by Lucas Forschler.
2859
2860         * Configurations/Base.xcconfig:
2861         * Configurations/DebugRelease.xcconfig:
2862         * Configurations/FeatureDefines.xcconfig:
2863         * Configurations/Version.xcconfig:
2864
2865 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
2866
2867         Add optimized fullscreen mode.
2868         https://bugs.webkit.org/show_bug.cgi?id=138044
2869
2870         Reviewed by Jer Noble.
2871
2872         Enable different types of fullscreen video behavior.
2873         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
2874
2875         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
2876         * WebCoreSupport/WebChromeClient.mm:
2877         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
2878         * WebView/WebView.mm:
2879         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
2880         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
2881         * WebView/WebViewInternal.h: ditto
2882
2883 2014-10-27  Beth Dakin  <bdakin@apple.com>
2884
2885         Provide a way for WebKit1 clients to override default action menu items
2886         https://bugs.webkit.org/show_bug.cgi?id=138066
2887         -and corresponding-
2888         rdar://problem/18451638
2889
2890         Reviewed by Anders Carlsson.
2891
2892         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
2893         send that along to clients customizing the menu.
2894         * WebView/WebActionMenuController.h:
2895         * WebView/WebActionMenuController.mm:
2896         (-[WebActionMenuController prepareForMenu:withEvent:]):
2897         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2898
2899         New enum and new SPI to customize menus.
2900         * WebView/WebUIDelegatePrivate.h:
2901
2902 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
2903
2904         Fix the iOS build
2905
2906         * Configurations/WebKitLegacy.xcconfig:
2907         * WebView/WebView.mm:
2908
2909 2014-10-24  Beth Dakin  <bdakin@apple.com>
2910
2911         Build fix.
2912
2913         * WebView/WebActionMenuController.mm:
2914         (-[WebActionMenuController _openURLFromActionMenu:]):
2915         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2916         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2917
2918 2014-10-24  Beth Dakin  <bdakin@apple.com>
2919
2920         WebKit1 should support action menus
2921         https://bugs.webkit.org/show_bug.cgi?id=138032
2922
2923         Reviewed by Tim Horton.
2924
2925         This patch adds basic support for action menus and adds actions for links.
2926
2927         Helper class takes care of all of the action menu work. WebView will forward the 
2928         prepareForMenu: message, and then the helper class takes it from there.
2929         * WebView/WebActionMenuController.h: Added.
2930         * WebView/WebActionMenuController.mm: Added.
2931         (-[WebActionMenuController webViewClosed]):
2932         (-[WebActionMenuController prepareForMenu:withEvent:]):
2933
2934         Selectors for link actions.
2935         (-[WebActionMenuController _openURLFromActionMenu:]):
2936         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2937         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
2938         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2939         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2940         (webKitBundleImageNamed):
2941         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2942         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2943
2944         Tags for the action menu items.
2945         * WebView/WebUIDelegatePrivate.h:
2946         * WebView/WebView.mm:
2947
2948         Set the action menu if possible and create the controller.
2949         (-[WebView _initWithFrame:frameName:groupName:]):
2950         (-[WebView _close]):
2951         (-[WebView prepareForMenu:withEvent:]):
2952
2953         WebViewData stores the WebActionMenuHelper
2954         * WebView/WebViewData.h:
2955         * WebView/WebViewData.mm:
2956         (-[WebViewPrivate dealloc]):
2957
2958 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
2959
2960         Web Inspector: Provide a way to have alternate inspector agents
2961         https://bugs.webkit.org/show_bug.cgi?id=137901
2962
2963         Reviewed by Brian Burg.
2964
2965         * Configurations/FeatureDefines.xcconfig:
2966
2967 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2968
2969         Add some SPI headers for NSExtension and NSSharingService{Picker}
2970         https://bugs.webkit.org/show_bug.cgi?id=138027
2971
2972         Reviewed by Anders Carlsson.
2973
2974         * Misc/WebSharingServicePickerController.h:
2975         * Misc/WebSharingServicePickerController.mm:
2976         * WebCoreSupport/WebSelectionServiceController.mm:
2977         * WebCoreSupport/WebContextMenuClient.mm:
2978         Fix a sorting issue.
2979         Replace redefinitions with SPI header #imports.
2980
2981 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2982
2983         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
2984         https://bugs.webkit.org/show_bug.cgi?id=138013
2985
2986         Reviewed by Dan Bernstein.
2987
2988         * WebCoreSupport/WebSelectionServiceController.mm:
2989         (WebSelectionServiceController::hasRelevantSelectionServices):
2990         Don't adopt this autoreleased object.
2991
2992 2014-10-22  Chris Dumez  <cdumez@apple.com>
2993
2994         [Mac][WK2] Fix applicationIsSafari() detection
2995         https://bugs.webkit.org/show_bug.cgi?id=137893
2996
2997         Reviewed by Alexey Proskuryakov.
2998
2999         Provide an implementation for FrameLoaderClient's new
3000         needsQuickLookResourceCachingQuirks() that returns
3001         a static flag initialized using
3002         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
3003
3004         * WebCoreSupport/WebFrameLoaderClient.h:
3005         * WebCoreSupport/WebFrameLoaderClient.mm:
3006
3007 2014-10-20  Chris Dumez  <cdumez@apple.com>
3008
3009         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
3010         https://bugs.webkit.org/show_bug.cgi?id=137797
3011
3012         Reviewed by Darin Adler.
3013
3014         Call ResourceRequest::setDomainForPartitionName() instead of
3015         setPartitionName() as the argument is a domain, not a valid
3016         partition name.
3017
3018         * Misc/WebCache.mm:
3019         (+[WebCache addImageToCache:forURL:forFrame:]):
3020         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3021
3022 2014-10-20  Andy Estes  <aestes@apple.com>
3023
3024         Fix the iOS build.
3025
3026         * WebView/WebFrame.mm:
3027         (-[WebFrame getDictationResultRanges:andMetadatas:]):
3028         (-[WebFrame dictationResultMetadataForRange:]):
3029
3030 2014-10-19  Chris Dumez  <cdumez@apple.com>
3031
3032         Use is<>() / downcast<>() for all remaining RenderObject subclasses
3033         https://bugs.webkit.org/show_bug.cgi?id=137845
3034
3035         Reviewed by Darin Adler.
3036
3037         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
3038         clean up the surrounding code.
3039
3040         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3041         (-[WebHostedNetscapePluginView pluginHostDied]):
3042         * Plugins/WebBaseNetscapePluginView.mm:
3043         (-[WebBaseNetscapePluginView _windowClipRect]):
3044         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
3045         * WebCoreSupport/WebFrameLoaderClient.mm:
3046         (WebFrameLoaderClient::createPlugin):
3047         (WebFrameLoaderClient::createJavaAppletWidget):
3048
3049 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3050
3051         Build fix for 32-bit Yosemite
3052
3053         * WebCoreSupport/WebContextMenuClient.mm:
3054         (WebContextMenuClient::contextMenuForEvent):
3055         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
3056
3057 2014-10-17  Chris Dumez  <cdumez@apple.com>
3058
3059         Use is<>() / downcast<>() for RenderBox
3060         https://bugs.webkit.org/show_bug.cgi?id=137804
3061
3062         Reviewed by Andreas Kling.
3063
3064         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
3065         code.
3066
3067         * WebCoreSupport/WebContextMenuClient.mm:
3068         (WebContextMenuClient::clientFloatRectForNode):
3069         * WebView/WebFrame.mm:
3070         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
3071
3072 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3073
3074         Fix the build with the public SDK.
3075
3076         * WebCoreSupport/WebSelectionServiceController.mm:
3077         We should transition all this SPI to real SPI headers as soon as possible.
3078
3079 2014-10-16  Tim Horton  <timothy_horton@apple.com>
3080
3081         Implement selection services menu for Legacy WebKit
3082         https://bugs.webkit.org/show_bug.cgi?id=137582
3083         <rdar://problem/18604241>
3084
3085         Reviewed by Brady Eidson.
3086
3087         * Misc/WebSharingServicePickerController.h:
3088         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
3089         Add WebSharingServicePickerClient, which other classes can implement
3090         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
3091         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
3092
3093         * Misc/WebSharingServicePickerController.mm:
3094         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
3095
3096         (-[WebSharingServicePickerController clear]):
3097         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
3098         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
3099         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
3100         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
3101         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3102         Make use of WebSharingServicePickerClient.
3103
3104         (-[WebSharingServicePickerController sharingService:didShareItems:]):
3105         If we're returned a NSAttributedString, paste it on top of the current selection,
3106         similar to what the WebKit2 implementation currently does.
3107         
3108         * WebCoreSupport/WebChromeClient.h:
3109         * WebCoreSupport/WebChromeClient.mm:
3110         (WebChromeClient::handleTelephoneNumberClick):
3111         (WebChromeClient::handleSelectionServiceClick):
3112         (WebChromeClient::hasRelevantSelectionServices):
3113         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
3114
3115         * WebCoreSupport/WebContextMenuClient.h:
3116         * WebCoreSupport/WebContextMenuClient.mm:
3117         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
3118         (WebContextMenuClient::pageForSharingServicePicker):
3119         (WebContextMenuClient::windowForSharingServicePicker):
3120         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
3121         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3122         (WebContextMenuClient::contextMenuForEvent):
3123         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
3124         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
3125         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
3126         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
3127         having WebSharingServicePickerController tightly bound to it.
3128         Make an NSItemProvider array when instantiating WebSharingServicePickerController
3129         instead of handing it data directly.
3130
3131         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
3132         * WebCoreSupport/WebSelectionServiceController.mm: Added.
3133         (WebSelectionServiceController::WebSelectionServiceController):
3134         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
3135         for selection services.
3136
3137         (WebSelectionServiceController::handleSelectionServiceClick):
3138         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
3139
3140         (hasCompatibleServicesForItems):
3141         (WebSelectionServiceController::hasRelevantSelectionServices):
3142         Determine whether or not services are available.
3143
3144         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
3145         (WebSelectionServiceController::pageForSharingServicePicker):
3146         (WebSelectionServiceController::windowForSharingServicePicker):
3147         Implement the rest of the WebSharingServicePickerClient overrides.
3148
3149         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
3150         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
3151         These are only useful for image sharing services, so we don't need to
3152         implement them (WebContextMenuClient does, on the other hand).
3153
3154         * WebView/WebView.mm:
3155         (-[WebView _selectionServiceController]):
3156         * WebView/WebViewData.h:
3157         * WebView/WebViewData.mm:
3158         * WebView/WebViewInternal.h:
3159         Keep a WebSelectionServiceController.
3160
3161 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3162
3163         Improve debug description of WAKViews
3164         https://bugs.webkit.org/show_bug.cgi?id=137716
3165
3166         Reviewed by Simon Fraser.
3167
3168         * WebView/WebView.mm:
3169         (-[WebView _touchEventRegions]): Adding a comment.
3170
3171 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3172
3173         Addressing post-review comment.
3174         https://bugs.webkit.org/show_bug.cgi?id=137550
3175
3176         Unreviewed.
3177
3178         * WebView/WebHTMLView.mm:
3179         (fontNameForDescription):
3180         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3181
3182 2014-10-14  Chris Dumez  <cdumez@apple.com>
3183
3184         Use is<>() / downcast<>() for RenderImage
3185         https://bugs.webkit.org/show_bug.cgi?id=137683
3186
3187         Reviewed by Mihnea Ovidenie.
3188
3189         Use is<>() / downcast<>() for RenderImage.
3190
3191         * Misc/WebNSPasteboardExtras.mm:
3192         (imageFromElement):
3193         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3194
3195 2014-10-10  Daniel Bates  <dabates@apple.com>
3196
3197         Remove unused classes WebRender{Node, Layer}
3198         https://bugs.webkit.org/show_bug.cgi?id=137628
3199
3200         Reviewed by Simon Fraser.
3201
3202         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
3203         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
3204
3205         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
3206         of excluded source files when building for iOS.
3207         * WebKit.exp: Remove symbol for WebRenderLayer.
3208         * WebKit.mac.exp: Remove symbol for WebRenderNode.
3209         * WebView/WebRenderLayer.h: Removed.
3210         * WebView/WebRenderLayer.mm: Removed.
3211         * WebView/WebRenderNode.h: Removed.
3212         * WebView/WebRenderNode.mm: Removed.
3213
3214 2014-10-10  Chris Dumez  <cdumez@apple.com>
3215
3216         Use is<>() / downcast<>() for RenderBoxModelObject
3217         https://bugs.webkit.org/show_bug.cgi?id=137587
3218
3219         Reviewed by Mihnea Ovidenie.
3220
3221         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
3222         surrounding code.
3223
3224         * Plugins/WebBaseNetscapePluginView.mm:
3225         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
3226         * WebView/WebRenderLayer.mm:
3227         (-[WebRenderLayer initWithWebFrame:]):
3228
3229 2014-10-09  Dean Jackson  <dino@apple.com>
3230
3231         Remove ENABLE_CSS3_CONDITIONAL_RULES
3232         https://bugs.webkit.org/show_bug.cgi?id=137571
3233
3234         Reviewed by Simon Fraser.
3235
3236         * Configurations/FeatureDefines.xcconfig:
3237
3238 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3239
3240         Add a WebKit1 preference for selection services
3241         https://bugs.webkit.org/show_bug.cgi?id=137498
3242         <rdar://problem/18572699>
3243
3244         Reviewed by Simon Fraser.
3245
3246         * WebView/WebPreferenceKeysPrivate.h:
3247         * WebView/WebPreferences.mm:
3248         (+[WebPreferences initialize]):
3249         (-[WebPreferences serviceControlsEnabled]):
3250         (-[WebPreferences setServiceControlsEnabled:]):
3251         * WebView/WebPreferencesPrivate.h:
3252         * WebView/WebView.mm:
3253         (-[WebView _preferencesChanged:]):
3254         Add and plumb the preference.
3255
3256 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
3257
3258         Remove second-to-last client of WebFontCache
3259         https://bugs.webkit.org/show_bug.cgi?id=137550
3260
3261         Reviewed by Darin Adler.
3262
3263         Use FontCache::getCachedFontData() instead of WebFontCache.
3264
3265         * WebView/WebHTMLView.mm:
3266         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3267
3268 2014-10-09  Chris Dumez  <cdumez@apple.com>
3269
3270         Use is<>() / downcast<>() for Widget subclasses
3271         https://bugs.webkit.org/show_bug.cgi?id=137549
3272
3273         Reviewed by Darin Adler.
3274
3275         Use is<>() / downcast<>() for Widget subclasses and clean up the
3276         surrounding code.
3277
3278         * WebView/WebRenderNode.mm:
3279         (copyRenderNode):
3280         * WebView/WebView.mm:
3281         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
3282
3283 2014-10-07  Christophe Dumez  <cdumez@apple.com>
3284
3285         Use is<>() / downcast<>() for RenderText / RenderTextFragment
3286         https://bugs.webkit.org/show_bug.cgi?id=137476
3287
3288         Reviewed by Darin Adler.
3289
3290         * WebView/WebRenderNode.mm:
3291         (copyRenderNode):
3292
3293 2014-10-06  Dan Bernstein  <mitz@apple.com>
3294
3295         Build fix.
3296
3297         * Misc/WebCache.mm:
3298         (+[WebCache imageForURL:]):
3299
3300 2014-10-06  Chris Dumez  <cdumez@apple.com>
3301
3302         Unreviewed build fix after r174333.
3303
3304         Forgot explicit WebCore:: namespace.
3305
3306         * Misc/WebCache.mm:
3307         (+[WebCache imageForURL:]):
3308
3309 2014-10-05  Christophe Dumez  <cdumez@apple.com>
3310
3311         Use is<>() / downcast<>() for CachedResource subclasses
3312         https://bugs.webkit.org/show_bug.cgi?id=137431
3313
3314         Reviewed by Benjamin Poulain.
3315
3316         Use is<>() / downcast<>() for CachedResource subclasses.
3317
3318         * Misc/WebCache.mm:
3319         (+[WebCache imageForURL:]):
3320
3321 2014-10-02  Daniel Bates  <dabates@apple.com>
3322
3323         Use version number 101000 instead of 10100 for OS X Yosemite
3324         https://bugs.webkit.org/show_bug.cgi?id=137372
3325
3326         Reviewed by Mark Rowe.
3327
3328         The version number for OS X Yosemite is 101000.
3329
3330         * WebView/WebView.mm:
3331         (-[WebView _preferencesChanged:]):
3332
3333 2014-10-02  Tim Horton  <timothy_horton@apple.com>
3334
3335         Move PageOverlay[Controller] to WebCore
3336         https://bugs.webkit.org/show_bug.cgi?id=137164
3337         <rdar://problem/18508258>
3338
3339         Reviewed by Anders Carlsson.
3340
3341         * WebCoreSupport/WebChromeClient.h:
3342         * WebCoreSupport/WebChromeClient.mm:
3343         (WebChromeClient::attachViewOverlayGraphicsLayer):
3344         Add an empty ChromeClient override.
3345
3346 2014-10-01  Christophe Dumez  <cdumez@apple.com>
3347
3348         Have is<>(T*) function do a null check on the pointer argument
3349         https://bugs.webkit.org/show_bug.cgi?id=137333
3350
3351         Reviewed by Gavin Barraclough.
3352
3353         Have is<>(T*) function do a null check on the argument instead of a
3354         simple assertion. This makes sense for 2 reasons:
3355         1. It is more consistent with downcast<>(T*), which will succeed even
3356            if the argument is a nullptr.
3357         2. It simplifies the code a bit as it gets rid of a lot of explicit
3358            null checks.
3359
3360         * WebCoreSupport/WebChromeClient.mm:
3361         (WebChromeClient::focusedElementChanged):
3362         * WebCoreSupport/WebEditorClient.mm:
3363         (WebEditorClient::textFieldDidBeginEditing):
3364         (WebEditorClient::textFieldDidEndEditing):
3365         (WebEditorClient::textDidChangeInTextField):
3366         (WebEditorClient::doTextFieldCommandFromEvent):
3367         (WebEditorClient::textWillBeDeletedInTextField):
3368         (WebEditorClient::textDidChangeInTextArea):
3369         * WebView/WebHTMLRepresentation.mm:
3370         (inputElementFromDOMElement):
3371         (searchForLabelsBeforeElement):
3372         * WebView/WebRenderLayer.mm:
3373         (+[WebRenderLayer nameForLayer:]):
3374
3375 2014-10-01  Mark Rowe  <mrowe@apple.com>
3376
3377         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3378
3379         Reviewed by Dan Bernstein.
3380
3381         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
3382
3383 2014-09-30  Chris Dumez  <cdumez@apple.com>
3384
3385         Use is<>() / downcast<>() for Element
3386         https://bugs.webkit.org/show_bug.cgi?id=137241
3387
3388         Reviewed by Andreas Kling.
3389
3390         Use is<>() / downcast<>() for Element instead of isElementNode() /
3391         toElement().
3392
3393         * WebView/WebRenderLayer.mm:
3394         (+[WebRenderLayer nameForLayer:]):
3395
3396 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3397
3398         Move ColorInputType class to std::unique_ptr
3399         https://bugs.webkit.org/show_bug.cgi?id=137173
3400
3401         Reviewed by Darin Adler.
3402
3403         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
3404         Child classes follow this change as well.
3405
3406         * WebCoreSupport/WebChromeClient.h:
3407         * WebCoreSupport/WebChromeClient.mm:
3408         (WebChromeClient::createColorChooser):
3409
3410 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3411
3412         Add initial is<>() / downcast<>() support for any type of Nodes
3413         https://bugs.webkit.org/show_bug.cgi?id=137056
3414
3415         Reviewed by Benjamin Poulain.
3416
3417         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
3418         instead of isFormControlElement() / toHTMLFormControlElement().
3419
3420         * WebView/WebHTMLRepresentation.mm:
3421         (searchForLabelsBeforeElement):
3422
3423 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3424
3425         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
3426         https://bugs.webkit.org/show_bug.cgi?id=137068
3427
3428         Reviewed by Ryosuke Niwa.
3429
3430         Start using is<HTML*Element>() instead of isHTML*Element().
3431         Remaining usages will be updated in a follow-up patch to
3432         reduce the size of the change.
3433
3434         * WebCoreSupport/WebChromeClient.mm:
3435         (WebChromeClient::focusedElementChanged):
3436         * WebCoreSupport/WebEditorClient.mm:
3437         (WebEditorClient::textFieldDidBeginEditing):
3438         (WebEditorClient::textFieldDidEndEditing):
3439         (WebEditorClient::textDidChangeInTextField):
3440         (WebEditorClient::doTextFieldCommandFromEvent):
3441         (WebEditorClient::textWillBeDeletedInTextField):
3442         (WebEditorClient::textDidChangeInTextArea):
3443         * WebView/WebHTMLRepresentation.mm:
3444         (inputElementFromDOMElement):
3445
3446 2014-09-21  Timothy Hatcher  <timothy@apple.com>
3447
3448         Make the Web Inspector use a separate web process.
3449
3450         https://bugs.webkit.org/show_bug.cgi?id=135120
3451
3452         Reviewed by Anders Carlsson.
3453
3454         * WebCoreSupport/WebInspectorClient.h:
3455         * WebCoreSupport/WebInspectorClient.mm:
3456         (WebInspectorClient::WebInspectorClient):
3457         (WebInspectorClient::openInspectorFrontend):
3458         (WebInspectorClient::releaseFrontend):
3459         Own WebInspectorFrontendClient instead of moving it.
3460
3461 2014-09-23  Chris Dumez  <cdumez@apple.com>
3462
3463         Use downcast<HTML*Element>() instead of toHTML*Element()
3464         https://bugs.webkit.org/show_bug.cgi?id=137007
3465
3466         Reviewed by Benjamin Poulain.
3467
3468         Use downcast<HTML*Element>() instead of toHTML*Element().
3469
3470         * DOM/WebDOMOperations.mm:
3471         (-[DOMHTMLInputElement _setAutofilled:]):
3472         * WebCoreSupport/WebChromeClient.mm:
3473         (WebChromeClient::focusedElementChanged):
3474         * WebCoreSupport/WebEditorClient.mm:
3475         (WebEditorClient::textFieldDidBeginEditing):
3476         (WebEditorClient::textFieldDidEndEditing):
3477         (WebEditorClient::textDidChangeInTextField):
3478         (WebEditorClient::doTextFieldCommandFromEvent):
3479         (WebEditorClient::textWillBeDeletedInTextField):
3480         (WebEditorClient::textDidChangeInTextArea):
3481         * WebView/WebHTMLRepresentation.mm:
3482         (inputElementFromDOMElement):
3483
3484 2014-09-21  Chris Dumez  <cdumez@apple.com>
3485
3486         Generate Element casting helper functions
3487         https://bugs.webkit.org/show_bug.cgi?id=136839
3488
3489         Reviewed by Darin Adler.
3490
3491         Use JSXXX::toWrapped() instead of toXXX() function.
3492
3493         * DOM/WebDOMOperations.mm:
3494         * WebView/WebView.mm:
3495         (-[WebView _notificationIDForTesting:]):
3496
3497 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
3498
3499         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
3500         https://bugs.webkit.org/show_bug.cgi?id=136972
3501
3502         Reviewed by Darin Adler.
3503
3504         * WebView/WebNotification.h:
3505         * WebView/WebNotification.mm:
3506         (-[WebNotification initWithCoreNotification:notificationID:]):
3507         Switch to RetainPtr and adopt into _private to ensure when we are
3508         deallocated that _private will get deallocated.
3509
3510 2014-09-19  Dean Jackson  <dino@apple.com>
3511
3512         Multithreaded WebGL is a bad idea - remove it
3513         https://bugs.webkit.org/show_bug.cgi?id=136964
3514         <rdar://problem/18399858>
3515
3516         Reviewed by Brent Fulgham.
3517
3518         Remove the setting to allow multithreaded WebGL.
3519
3520         * WebView/WebPreferenceKeysPrivate.h:
3521         * WebView/WebPreferences.mm:
3522         (+[WebPreferences initialize]):
3523         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
3524         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
3525         * WebView/WebPreferencesPrivate.h:
3526         * WebView/WebView.mm:
3527         (-[WebView _preferencesChanged:]):
3528
3529 2014-09-19  Daniel Bates  <dabates@apple.com>
3530
3531         Always assume internal SDK when building configuration Production
3532         https://bugs.webkit.org/show_bug.cgi?id=136925
3533         <rdar://problem/18362399>
3534
3535         Reviewed by Dan Bernstein.
3536
3537         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
3538         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
3539
3540         * Configurations/Base.xcconfig:
3541
3542 2014-09-17  Daniel Bates  <dabates@apple.com>
3543
3544         Unreviewed, rolling out r173695.
3545
3546         Broke building third-party Legacy WebKit apps; will
3547         investigate offline
3548
3549         Reverted changeset:
3550
3551         "[iOS] Make WebCore build with public iOS SDK"
3552         https://bugs.webkit.org/show_bug.cgi?id=136487
3553         http://trac.webkit.org/changeset/173695
3554
3555 2014-09-17  Daniel Bates  <dabates@apple.com>
3556
3557         [iOS] Make WebCore build with public iOS SDK
3558         https://bugs.webkit.org/show_bug.cgi?id=136487
3559
3560         Reviewed by David Kilzer.
3561
3562         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
3563         actual SPI header(s).
3564
3565         * DOM/WebDOMOperationsPrivate.h:
3566         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
3567         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
3568         such files into the WebKit framework as private headers.
3569         * WebCoreSupport/WebFrameLoaderClient.mm:
3570         * WebInspector/WebNodeHighlight.mm:
3571         * WebView/WebIndicateLayer.mm:
3572         * WebView/WebRenderLayer.h:
3573         * WebView/WebView.mm:
3574
3575 2014-09-16  Daniel Bates  <dabates@a