Source/WebKit/mac/ChangeLog

   1 2015-10-26  Anders Carlsson  <andersca@apple.com>
   2
   3         Remove dead context menu code
   4         https://bugs.webkit.org/show_bug.cgi?id=150567
   5
   6         Reviewed by Tim Horton.
   7
   8         * WebCoreSupport/WebContextMenuClient.h:
   9         * WebCoreSupport/WebContextMenuClient.mm:
  10         (WebContextMenuClient::getCustomMenuFromDefaultItems): Deleted.
  11
  12 2015-10-23  Anders Carlsson  <andersca@apple.com>
  13
  14         Invoke the context menu delegate callback right before we return the menu
  15         https://bugs.webkit.org/show_bug.cgi?id=150521
  16
  17         Reviewed by Tim Horton.
  18
  19         Move the getCustomMenuFromDefaultItems to WebHTMLView wholesale. This will allow us to get rid of the ContextMenuClient function from WebCore.
  20
  21         * WebCoreSupport/WebContextMenuClient.mm:
  22         (WebContextMenuClient::getCustomMenuFromDefaultItems):
  23         (isPreVersion3Client): Deleted.
  24         (isPreInspectElementTagClient): Deleted.
  25         (fixMenusToSendToOldClients): Deleted.
  26         (fixMenusReceivedFromOldClients): Deleted.
  27         * WebView/WebHTMLView.mm:
  28         (isPreVersion3Client):
  29         (isPreInspectElementTagClient):
  30         (fixMenusToSendToOldClients):
  31         (fixMenusReceivedFromOldClients):
  32         (customMenuFromDefaultItems):
  33         (-[WebHTMLView menuForEvent:]):
  34
  35 2015-10-23  Anders Carlsson  <andersca@apple.com>
  36
  37         More context menu simplification
  38         https://bugs.webkit.org/show_bug.cgi?id=150519
  39
  40         Reviewed by Tim Horton.
  41
  42         There's no need to convert the menu items back to ContextMenuItems just so we can check whether its
  43         represented object is the sharing service picker. Also, move the check to the second loop.
  44
  45         * WebView/WebHTMLView.mm:
  46         (-[WebHTMLView menuForEvent:]):
  47
  48 2015-10-23  Anders Carlsson  <andersca@apple.com>
  49
  50         Simplify the WebKitLegacy menu conversion code
  51         https://bugs.webkit.org/show_bug.cgi?id=150509
  52
  53         Reviewed by Andreas Kling.
  54
  55         * WebCoreSupport/WebContextMenuClient.mm:
  56         (fixMenusToSendToOldClients):
  57         (fixMenusReceivedFromOldClients):
  58         (WebContextMenuClient::getCustomMenuFromDefaultItems):
  59
  60 2015-10-23  Anders Carlsson  <andersca@apple.com>
  61
  62         Don't override already existing represented objects on menu items
  63         https://bugs.webkit.org/show_bug.cgi?id=150508
  64
  65         Reviewed by Tim Horton.
  66
  67         This fixes a crash/exception when a client implements webView:contextMenuItemsForElement:defaultMenuItems: and
  68         the default menu has a share menu item.
  69
  70         * WebCoreSupport/WebContextMenuClient.mm:
  71         (WebContextMenuClient::getCustomMenuFromDefaultItems):
  72
  73 2015-10-22  Sam Weinig  <sam@webkit.org>
  74
  75         Navigations on the same host (but with different schemes and ports) should not trigger universal links
  76         <rdar://problem/22811325>
  77         https://bugs.webkit.org/show_bug.cgi?id=150481
  78
  79         Reviewed by Dan Bernstein.
  80
  81         * WebCoreSupport/WebFrameLoaderClient.mm:
  82         (shouldTryAppLink):
  83         Update the policy for following universal links to only take host into consideration.
  84
  85 2015-10-22  Gordon Sheridan  <gordon_sheridan@apple.com>
  86
  87         Fix build for clang-700.0.59.5 by replacing deprecated calls to convert points between screen and window coordinates for Mac.
  88         https://bugs.webkit.org/show_bug.cgi?id=150379
  89
  90         Reviewed by Andy Estes.
  91
  92         * WebView/WebHTMLView.mm:
  93         (-[WebHTMLView characterIndexForPoint:]):
  94         Convert point to rect, and replace call to deprecated convertScreenToBase: with convertRectFromScreen:.
  95
  96         (-[WebHTMLView firstRectForCharacterRange:]):
  97         Replace call to deprecated convertBaseToScreen: with convertRectToScreen:.
  98
  99 2015-10-22  Myles C. Maxfield  <mmaxfield@apple.com>
 100
 101         [Cocoa] Migrate WKSetPatternPhaseInUserSpace() and WKGetUserToBaseCTM() from WKSI
 102         https://bugs.webkit.org/show_bug.cgi?id=150460
 103
 104         Reviewed by Tim Horton.
 105
 106         * WebCoreSupport/WebSystemInterface.mm:
 107         (InitWebCoreSystemInterface): Deleted.
 108
 109 2015-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
 110
 111         NetworkProcess: DNS prefetch happens in the Web Process
 112         https://bugs.webkit.org/show_bug.cgi?id=147824
 113
 114         Reviewed by Chris Dumez.
 115
 116         Implement FrameLoaderClient::prefetchDNS().
 117
 118         * WebCoreSupport/WebFrameLoaderClient.h:
 119         * WebCoreSupport/WebFrameLoaderClient.mm:
 120
 121 2015-10-20  Commit Queue  <commit-queue@webkit.org>
 122
 123         Unreviewed, rolling out r191370.
 124         https://bugs.webkit.org/show_bug.cgi?id=150384
 125
 126         Broke iOS 9 build (Requested by ap on #webkit).
 127
 128         Reverted changeset:
 129
 130         "Fix build for clang-700.0.59.5 by replacing deprecated calls
 131         to convertScreenToBase: with convertRectFromScreen:."
 132         https://bugs.webkit.org/show_bug.cgi?id=150379
 133         http://trac.webkit.org/changeset/191370
 134
 135 2015-10-20  Gordon Sheridan  <gordon_sheridan@apple.com>
 136
 137         Fix build for clang-700.0.59.5 by replacing deprecated calls to convertScreenToBase: with convertRectFromScreen:.
 138         https://bugs.webkit.org/show_bug.cgi?id=150379
 139
 140         Reviewed by Simon Fraser.
 141
 142         * WebView/WebHTMLView.mm:
 143         (-[WebHTMLView characterIndexForPoint:]):
 144         Convert point to rect, and call convertRectFromScreen:.
 145
 146         (-[WebHTMLView firstRectForCharacterRange:]):
 147         Replace convertBaseToScreen: with convertRectToScreen:.
 148
 149 2015-10-20  Tim Horton  <timothy_horton@apple.com>
 150
 151         Try to fix the build by disabling MAC_GESTURE_EVENTS on 10.9 and 10.10
 152
 153         * Configurations/FeatureDefines.xcconfig:
 154
 155 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
 156
 157         Rename the PICTURE_SIZES flag to CURRENTSRC
 158         https://bugs.webkit.org/show_bug.cgi?id=150275
 159
 160         Reviewed by Dean Jackson.
 161
 162         * Configurations/FeatureDefines.xcconfig:
 163
 164 2015-10-19  Tim Horton  <timothy_horton@apple.com>
 165
 166         Try to fix the iOS build
 167
 168         * Configurations/FeatureDefines.xcconfig:
 169
 170 2015-10-19  Tim Horton  <timothy_horton@apple.com>
 171
 172         Add magnify and rotate gesture event support for Mac
 173         https://bugs.webkit.org/show_bug.cgi?id=150179
 174         <rdar://problem/8036240>
 175
 176         Reviewed by Darin Adler.
 177
 178         * Configurations/FeatureDefines.xcconfig:
 179         New feature flag.
 180
 181 2015-10-17  Myles C. Maxfield  <mmaxfield@apple.com>
 182
 183         Build fix after r191260
 184
 185         Unreviewed.
 186
 187         * WebView/WebView.mm:
 188         (+[WebView initialize]):
 189
 190 2015-10-18  Myles C. Maxfield  <mmaxfield@apple.com>
 191
 192         Stop honoring the user default "WebKitKerningAndLigaturesEnabledByDefault"
 193         https://bugs.webkit.org/show_bug.cgi?id=150287
 194
 195         Reviewed by Simon Fraser.
 196
 197         * WebView/WebView.mm:
 198         (+[WebView initialize]): Deleted.
 199
 200 2015-10-18  Commit Queue  <commit-queue@webkit.org>
 201
 202         Unreviewed, rolling out r191250 and r191253.
 203         https://bugs.webkit.org/show_bug.cgi?id=150296
 204
 205         Broke all the tests on Windows (Requested by ap on #webkit).
 206
 207         Reverted changesets:
 208
 209         "Stop honoring the user default
 210         "WebKitKerningAndLigaturesEnabledByDefault""
 211         https://bugs.webkit.org/show_bug.cgi?id=150287
 212         http://trac.webkit.org/changeset/191250
 213
 214         "Build fix after r191250"
 215         http://trac.webkit.org/changeset/191253
 216
 217 2015-10-17  Myles C. Maxfield  <mmaxfield@apple.com>
 218
 219         Build fix after r191250
 220
 221         Unreviewed.
 222
 223         * WebView/WebView.mm:
 224         (+[WebView initialize]):
 225
 226 2015-10-17  Myles C. Maxfield  <mmaxfield@apple.com>
 227
 228         Stop honoring the user default "WebKitKerningAndLigaturesEnabledByDefault"
 229         https://bugs.webkit.org/show_bug.cgi?id=150287
 230
 231         Reviewed by Simon Fraser.
 232
 233         * WebView/WebView.mm:
 234         (+[WebView initialize]): Deleted.
 235
 236 2015-10-16  Anders Carlsson  <andersca@apple.com>
 237
 238         WebEditingDelegate should be a formal protocol
 239         https://bugs.webkit.org/show_bug.cgi?id=150254
 240         <rdar://problem/23149847>
 241
 242         Reviewed by Dan Bernstein.
 243
 244         * WebView/WebEditingDelegate.h:
 245         Move all the delegate methods inside the protocol declaration. Also make the header self-contained.
 246
 247         * WebView/WebView.h:
 248         Change the type of the editing delegate and make it assign.
 249
 250 2015-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
 251
 252         Migrate to CGContextSetBaseCTM() and CGContextResetClip() from WKSI
 253         https://bugs.webkit.org/show_bug.cgi?id=150155
 254
 255         Reviewed by Tim Horton.
 256
 257         * WebCoreSupport/WebSystemInterface.mm:
 258         (InitWebCoreSystemInterface): Deleted.
 259         * WebView/WebView.mm:
 260         (-[WebView _setBaseCTM:forContext:]):
 261
 262 2015-10-15  Dan Bernstein  <mitz@apple.com>
 263
 264         [Cocoa] Stop using WKSetNSURLConnectionDefersCallbacks
 265         https://bugs.webkit.org/show_bug.cgi?id=150189
 266
 267         Reviewed by Anders Carlsson.
 268
 269         * WebCoreSupport/WebSystemInterface.mm:
 270         (InitWebCoreSystemInterface): Removed initialization.
 271
 272 2015-10-14  Zhuo Li  <zachli@apple.com>
 273
 274         Augment <input type=search>’s recent search history with the time each entry was added,
 275         in order to allow time-based clearing of search history.
 276         https://bugs.webkit.org/show_bug.cgi?id=148388.
 277
 278         Reviewed by Darin Adler.
 279
 280         Replace Vector<String> with Vector<RecentSearch>, where RecentSearch is a struct
 281         that consists search string and time, for recent searches in order to store additional time information.
 282
 283         All these new RecentSearches are stored in a plist in which the structure looks like:
 284         Root {
 285             "items": {
 286                 autosave name: {
 287                     "searches": [
 288                         { "searchString": searchString, "date": date },
 289                         ...
 290                     ]
 291                 }
 292             }
 293         }
 294
 295         * WebCoreSupport/SearchPopupMenuMac.h:
 296         * WebCoreSupport/SearchPopupMenuMac.mm:
 297         (SearchPopupMenuMac::saveRecentSearches): Call saveRecentSearches in WebCore::SearchPopupMenuCocoa.
 298         (SearchPopupMenuMac::loadRecentSearches): Call loadRecentSearches in WebCore::SearchPopupMenuCocoa.
 299         (autosaveKey): Deleted.
 300
 301 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
 302
 303         Split TypesettingFeatures into kerning and ligatures bools
 304         https://bugs.webkit.org/show_bug.cgi?id=150074
 305
 306         Reviewed by Simon Fraser.
 307
 308         * WebView/WebView.mm:
 309         (+[WebView initialize]):
 310
 311 2015-10-13  Chris Dumez  <cdumez@apple.com>
 312
 313         Avoid useless copies in range-loops that are using 'auto'
 314         https://bugs.webkit.org/show_bug.cgi?id=150091
 315
 316         Reviewed by Sam Weinig.
 317
 318         Avoid useless copies in range-loops that are using 'auto'. Also use
 319         'auto*' instead of 'auto' when range values are pointers for clarity.
 320
 321         * WebView/WebFrame.mm:
 322         (-[WebFrame getDictationResultRanges:andMetadatas:]):
 323
 324 2015-10-09  Anders Carlsson  <andersca@apple.com>
 325
 326         Don't allow plug-ins to override image types for <embed> elements
 327         https://bugs.webkit.org/show_bug.cgi?id=149979
 328
 329         Reviewed by Tim Horton.
 330
 331         * WebCoreSupport/WebFrameLoaderClient.h:
 332         * WebCoreSupport/WebFrameLoaderClient.mm:
 333         (WebFrameLoaderClient::objectContentType):
 334
 335 2015-10-10  Dan Bernstein  <mitz@apple.com>
 336
 337         [iOS] Remove unnecessary iOS version checks
 338         https://bugs.webkit.org/show_bug.cgi?id=150002
 339
 340         Reviewed by Alexey Proskuryakov.
 341
 342         * Plugins/WebPluginController.h:
 343         * Plugins/WebPluginController.mm:
 344         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
 345         (+[WebPluginController addPlugInView:]):
 346         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): Deleted.
 347         * WebCoreSupport/WebFrameLoaderClient.mm:
 348         (pluginView):
 349         * WebView/WebPreferences.mm:
 350         (-[WebPreferences isDNSPrefetchingEnabled]):
 351         (-[WebPreferences setWebInspectorServerEnabled:]): Deleted.
 352         (-[WebPreferences _setAllowCompositingLayerVisualDegradation:]): Deleted.
 353         * WebView/WebPreferencesPrivate.h:
 354         * WebView/WebView.mm:
 355         (shouldAllowPictureInPictureMediaPlayback):
 356
 357 2015-10-10  Dan Bernstein  <mitz@apple.com>
 358
 359         [iOS] Remove project support for iOS 8
 360         https://bugs.webkit.org/show_bug.cgi?id=149993
 361
 362         Reviewed by Alexey Proskuryakov.
 363
 364         * Configurations/WebKitLegacy.xcconfig:
 365
 366 2015-10-06  Daniel Bates  <dbates@webkit.org>
 367
 368         Enable XSLT when building WebKit for iOS using the public iOS SDK
 369         https://bugs.webkit.org/show_bug.cgi?id=149827
 370
 371         Reviewed by Alexey Proskuryakov.
 372
 373         * Configurations/FeatureDefines.xcconfig:
 374
 375 2015-10-06  Alex Christensen  <achristensen@webkit.org>
 376
 377         Report error when main resource is blocked by content blocker
 378         https://bugs.webkit.org/show_bug.cgi?id=149719
 379         rdar://problem/21970595
 380
 381         Reviewed by Brady Eidson.
 382
 383         * WebCoreSupport/WebFrameLoaderClient.h:
 384         * WebCoreSupport/WebFrameLoaderClient.mm:
 385         (WebFrameLoaderClient::blockedError):
 386         (WebFrameLoaderClient::blockedByContentBlockerError):
 387         (WebFrameLoaderClient::cannotShowURLError):
 388         Add blockedByContentBlockerError so WebFrameLoaderClient is not an abstract class,
 389         but it should be unused because content blockers are not enabled on WK1.
 390
 391 2015-10-05  Daniel Bates  <dabates@apple.com>
 392
 393         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
 394         https://bugs.webkit.org/show_bug.cgi?id=149766
 395
 396         Reviewed by Alexey Proskuryakov.
 397
 398         Assert that we have a non-null pointer to a cookie storage.
 399
 400         * WebView/WebPreferences.mm:
 401         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
 402
 403 2015-10-05  Andreas Kling  <akling@apple.com>
 404
 405         Remove unused HistoryItem::targetItem()
 406         <https://webkit.org/b/149803>
 407
 408         Reviewed by Anders Carlsson.
 409
 410         Remove the only (unused) client of HistoryItem::targetItem().
 411
 412         * History/WebHistoryItem.mm:
 413         * History/WebHistoryItemPrivate.h:
 414
 415 2015-10-05  Andreas Kling  <akling@apple.com>
 416
 417         Remove unused HistoryItem::parent
 418         <https://webkit.org/b/149803>
 419
 420         Reviewed by Anders Carlsson.
 421
 422         Remove the only (unused) client of HistoryItem's with-parent constructor.
 423
 424         * History/WebHistoryItem.mm:
 425         (-[WebHistoryItem initWithURL:target:parent:title:]): Deleted.
 426         * History/WebHistoryItemInternal.h:
 427
 428 2015-09-30  Timothy Horton  <timothy_horton@apple.com>
 429
 430         Compute document marker rects at use time instead of paint time
 431         https://bugs.webkit.org/show_bug.cgi?id=149643
 432
 433         Reviewed by Darin Adler.
 434
 435         * WebView/WebHTMLView.mm:
 436         (-[WebHTMLView rectsForTextMatches]):
 437
 438 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
 439
 440         printing does not use minimum page zoom factor
 441         https://bugs.webkit.org/show_bug.cgi?id=108507
 442
 443         Reviewed by Darin Adler.
 444
 445         Pass a the frame as a reference instead of using pointers.
 446
 447         * Misc/WebCoreStatistics.mm:
 448         (-[WebFrame numberOfPagesWithPageWidth:pageHeight:]):
 449         (-[WebFrame printToCGContext:pageWidth:pageHeight:]):
 450
 451 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
 452
 453         Clean up user media request internal API
 454         https://bugs.webkit.org/show_bug.cgi?id=149527
 455
 456         Reviewed by Tim Horton.
 457
 458         * WebCoreSupport/WebUserMediaClient.mm:
 459         (WebUserMediaClient::cancelRequest): Put UserMediaRequestsMap in a local instead or calling
 460           userMediaRequestsMap() three times.
 461         (-[WebUserMediaPolicyListener allow]): Get rid of unneeded local variables.
 462         (-[WebUserMediaPolicyListener allowDeviceWithVideoUID]): Deleted, unused.
 463
 464 2015-09-22  Andy Estes  <aestes@apple.com>
 465
 466         Disable QuickLook on tvOS
 467         https://bugs.webkit.org/show_bug.cgi?id=149492
 468         <rdar://problem/22741586>
 469
 470         Reviewed by Dan Bernstein.
 471
 472         We can't use USE(QUICK_LOOK) in a Private header, and postprocess-headers.sh doesn't know how to strip things
 473         that aren't feature flags. So, if QuickLook is disabled, we'll just always define WebQuickLookFileNameKey and
 474         WebQuickLookUTIKey, and we'll also define -quickLookContentForURL: but have it return nil.
 475
 476         * WebView/WebView.mm:
 477         (-[WebView quickLookContentForURL:]):
 478
 479 2015-09-22  Tim Horton  <timothy_horton@apple.com>
 480
 481         Make it more obvious when using an unaccelerated image buffer, and fix a few callers who do
 482         https://bugs.webkit.org/show_bug.cgi?id=149428
 483
 484         Reviewed by Simon Fraser and Darin Adler.
 485
 486         * WebCoreSupport/WebContextMenuClient.mm:
 487         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
 488
 489 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
 490
 491         REGRESSION (r182648): UIWebView does not set location.hash synchronously
 492         https://bugs.webkit.org/show_bug.cgi?id=149415
 493         <rdar://problem/22169467>
 494
 495         Reviewed by Darin Adler.
 496
 497         The problem was that the delegate in UI thread became asynchronous due to calling
 498         into LaunchServices.
 499
 500         * WebCoreSupport/WebFrameLoaderClient.mm: (shouldTryAppLink): Don't attempt app
 501         links for same domain navigations. This check is part of substantially more complicated
 502         logic in WebKit2 that I don't understand, but that should be enough to demonstrate
 503         that this fix is an improvement at least.
 504
 505 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 506
 507         Remove XHR_TIMEOUT compilation guard
 508         https://bugs.webkit.org/show_bug.cgi?id=149260
 509
 510         Reviewed by Benjamin Poulain.
 511
 512         * Configurations/FeatureDefines.xcconfig:
 513
 514 2015-09-18  Commit Queue  <commit-queue@webkit.org>
 515
 516         Unreviewed, rolling out r189908.
 517         https://bugs.webkit.org/show_bug.cgi?id=149368
 518
 519         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
 520
 521         Reverted changeset:
 522
 523         "printing does not use minimum page zoom factor"
 524         https://bugs.webkit.org/show_bug.cgi?id=108507
 525         http://trac.webkit.org/changeset/189908
 526
 527 2015-09-17  Brian Burg  <bburg@apple.com>
 528
 529         ASSERT(!m_frontendRouter->hasLocalFrontend()) when running Web Inspector tests
 530         https://bugs.webkit.org/show_bug.cgi?id=149006
 531
 532         Reviewed by Joseph Pecoraro.
 533
 534         WK1 WebInspectorClient was connecting to the wrong controllers. Fix this, and
 535         remove extra code paths for closing the frontend.
 536
 537         * WebCoreSupport/WebInspectorClient.h:
 538         * WebCoreSupport/WebInspectorClient.mm:
 539         (-[WebInspectorWindowController destroyInspectorView]):
 540
 541             Disconnect the FrontendClient from the frontend page's inspector controller.
 542             Do this teardown before releasing the frontend, otherwise we can't use it.
 543
 544         (WebInspectorClient::inspectedPageDestroyed): Deleted.
 545         (WebInspectorClient::closeLocalFrontend): Deleted.
 546         (WebInspectorFrontendClient::disconnectFromBackend): Deleted.
 547         * WebInspector/WebInspector.mm:
 548         (-[WebInspector inspectedWebViewClosed]):
 549
 550             Make sure to close ourself if the inspected page closes.
 551
 552         (-[WebInspector close:]):
 553
 554             Go through the frontend instead of InspectorController.
 555
 556         * WebInspector/WebInspectorFrontend.h:
 557         * WebInspector/WebInspectorFrontend.mm:
 558         (-[WebInspectorFrontend close]):
 559
 560 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
 561
 562         printing does not use minimum page zoom factor
 563         https://bugs.webkit.org/show_bug.cgi?id=108507
 564
 565         Reviewed by Darin Adler.
 566
 567         Pass a the frame as a reference instead of using pointers.
 568
 569         * Misc/WebCoreStatistics.mm:
 570         (-[WebFrame numberOfPagesWithPageWidth:pageHeight:]):
 571         (-[WebFrame printToCGContext:pageWidth:pageHeight:]):
 572
 573 2015-09-16  Brady Eidson  <beidson@apple.com>
 574
 575         Have window.indexedDB.deleteDatabase return an IDBOpenDBRequest.
 576         https://bugs.webkit.org/show_bug.cgi?id=149229
 577
 578         Reviewed by Alex Christensen.
 579
 580         * WebView/WebView.mm:
 581         (-[WebView _preferencesChanged:]): Enable IDB in WK1.
 582
 583 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
 584
 585         Add ShadowRoot interface and Element.prototype.attachShadow
 586         https://bugs.webkit.org/show_bug.cgi?id=149187
 587
 588         Reviewed by Antti Koivisto.
 589
 590         * Configurations/FeatureDefines.xcconfig:
 591
 592 2015-09-14  Alex Christensen  <achristensen@webkit.org>
 593
 594         Progress towards CMake on Mac.
 595         https://bugs.webkit.org/show_bug.cgi?id=149123
 596
 597         Reviewed by Chris Dumez.
 598
 599         * WebView/WebPDFDocumentExtras.mm:
 600         (appendValuesInPDFNameSubtreeToVector):
 601         * WebView/WebPDFView.mm:
 602         Removed cmake include quirks that are not needed when we include things correctly from Quartz.framework/Frameworks.
 603
 604 2015-09-12  Brian Burg  <bburg@apple.com>
 605
 606         Web Inspector: disambiguate inspected/frontend controllers and pages in backend code
 607         https://bugs.webkit.org/show_bug.cgi?id=149071
 608
 609         Reviewed by Joseph Pecoraro.
 610
 611         Be consistent about prefixing pages, inspector controllers, and window controllers
 612         with either "frontend" or "inspected", as appropriate. This change makes obvious some bugs
 613         in the frontend connection code, which are tracked by https://webkit.org/b/149006.
 614
 615         * WebCoreSupport/WebInspectorClient.h:
 616         * WebCoreSupport/WebInspectorClient.mm:
 617         (WebInspectorClient::WebInspectorClient): Renamed.
 618         (WebInspectorClient::inspectedPageDestroyed): Renamed.
 619         (WebInspectorClient::openLocalFrontend): Renamed.
 620         (WebInspectorClient::closeLocalFrontend): Renamed.
 621         (WebInspectorClient::didSetSearchingForNode):
 622         (WebInspectorFrontendClient::WebInspectorFrontendClient):
 623         (WebInspectorFrontendClient::attachAvailabilityChanged):
 624         (WebInspectorFrontendClient::canAttach):
 625         (WebInspectorFrontendClient::frontendLoaded):
 626         (WebInspectorFrontendClient::startWindowDrag):
 627         (WebInspectorFrontendClient::bringToFront):
 628         (WebInspectorFrontendClient::closeWindow):
 629         (WebInspectorFrontendClient::disconnectFromBackend):
 630         (WebInspectorFrontendClient::attachWindow):
 631         (WebInspectorFrontendClient::detachWindow):
 632         (WebInspectorFrontendClient::setAttachedWindowHeight):
 633         (WebInspectorFrontendClient::setToolbarHeight):
 634         (WebInspectorFrontendClient::updateWindowTitle):
 635         (WebInspectorFrontendClient::save):
 636         (WebInspectorFrontendClient::append):
 637         (-[WebInspectorWindowController init]):
 638         (-[WebInspectorWindowController initWithInspectedWebView:isUnderTest:]):
 639         (-[WebInspectorWindowController dealloc]):
 640         (-[WebInspectorWindowController frontendWebView]):
 641         (-[WebInspectorWindowController close]):
 642         (-[WebInspectorWindowController showWindow:]):
 643         (-[WebInspectorWindowController setAttachedWindowHeight:]):
 644         (-[WebInspectorWindowController destroyInspectorView]):
 645         (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
 646         (WebInspectorClient::inspectorDestroyed): Deleted.
 647         (WebInspectorClient::openInspectorFrontend): Deleted.
 648         (WebInspectorClient::closeInspectorFrontend): Deleted.
 649         (-[WebInspectorWindowController webView]): Deleted.
 650         * WebInspector/WebInspector.h:
 651         * WebInspector/WebInspector.mm:
 652         (-[WebInspector initWithInspectedWebView:]): Renamed.
 653         (-[WebInspector inspectedWebViewClosed]): Renamed.
 654         (-[WebInspector showWindow]):
 655         (-[WebInspector close:]):
 656         (-[WebInspector evaluateInFrontend:script:]):
 657         (-[WebInspector releaseFrontend]):
 658         (-[WebInspector initWithWebView:]): Deleted.
 659         (-[WebInspector webViewClosed]): Deleted.
 660         * WebView/WebView.mm:
 661         (-[WebView _close]):
 662         (-[WebView inspector]):
 663
 664 2015-09-10  Chris Dumez  <cdumez@apple.com>
 665
 666         Node.appendChild(null) / replaceChild(null, null) / removeChild(null) / insertBefore(null, ref) should throw a TypeError
 667         https://bugs.webkit.org/show_bug.cgi?id=148971
 668         <rdar://problem/22560883>
 669         <rdar://problem/22559225>
 670
 671         Reviewed by Ryosuke Niwa.
 672
 673         ContainerNode::appendChild() now takes a Ref<Node>&& parameter so we
 674         need to update the call site.
 675
 676         * WebView/WebFrame.mm:
 677         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
 678
 679 2015-09-07  Andy Estes  <aestes@apple.com>
 680
 681         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
 682         https://bugs.webkit.org/show_bug.cgi?id=148946
 683         <rdar://problem/22603981>
 684
 685         Reviewed by Dan Bernstein.
 686
 687         * Configurations/DebugRelease.xcconfig:
 688
 689 2015-09-04  Brian Burg  <bburg@apple.com>
 690
 691         Web Inspector: agents should send messages through FrontendRouter instead of FrontendChannel
 692         https://bugs.webkit.org/show_bug.cgi?id=148492
 693
 694         Reviewed by Joseph Pecoraro.
 695
 696         * WebCoreSupport/WebInspectorClient.h: Clean up the forward declarations, don't use InspectorForwarding.h.
 697         * WebCoreSupport/WebInspectorClient.mm:
 698         (WebInspectorClient::openInspectorFrontend):
 699
 700 2015-09-04  Csaba Osztrogonác  <ossy@webkit.org>
 701
 702         Remove unnecessary compiler guards from mm files
 703         https://bugs.webkit.org/show_bug.cgi?id=148797
 704
 705         Reviewed by Dan Bernstein.
 706
 707         * Plugins/WebBasePluginPackage.mm:
 708         * Plugins/WebNetscapePluginPackage.mm:
 709
 710 2015-09-04  Brian Burg  <bburg@apple.com>
 711
 712         Web Inspector: InspectorController should support multiple frontend channels
 713         https://bugs.webkit.org/show_bug.cgi?id=148538
 714
 715         Reviewed by Joseph Pecoraro.
 716
 717         Remove the notifyInspectorController flag from closeWindow. Since InspectorClients
 718         must now manually disconnect their FrontendChannel(s), we should always
 719         perform the teardown that was guarded by this flag.
 720
 721         * WebCoreSupport/WebInspectorClient.h:
 722         * WebCoreSupport/WebInspectorClient.mm:
 723         (WebInspectorClient::bringFrontendToFront): Add a missing assertion.
 724         (WebInspectorFrontendClient::closeWindow):
 725         (WebInspectorFrontendClient::disconnectFromBackend):
 726         (-[WebInspectorWindowController windowShouldClose:]):
 727         (-[WebInspectorWindowController destroyInspectorView]): Always clear the frontend client.
 728         (-[WebInspectorWindowController destroyInspectorView:]): Renamed to above.
 729
 730 2015-09-03  Commit Queue  <commit-queue@webkit.org>
 731
 732         Unreviewed, rolling out r189338.
 733         https://bugs.webkit.org/show_bug.cgi?id=148785
 734
 735         Caused tons of crashes (Requested by cdumez on #webkit).
 736
 737         Reverted changeset:
 738
 739         "Web Inspector: InspectorController should support multiple
 740         frontend channels"
 741         https://bugs.webkit.org/show_bug.cgi?id=148538
 742         http://trac.webkit.org/changeset/189338
 743
 744 2015-09-03  Brian Burg  <bburg@apple.com>
 745
 746         Web Inspector: InspectorController should support multiple frontend channels
 747         https://bugs.webkit.org/show_bug.cgi?id=148538
 748
 749         Reviewed by Joseph Pecoraro.
 750
 751         Remove the notifyInspectorController flag from closeWindow. Since InspectorClients
 752         must now manually disconnect their FrontendChannel(s), we should always
 753         perform the teardown that was guarded by this flag.
 754
 755         * WebCoreSupport/WebInspectorClient.h:
 756         * WebCoreSupport/WebInspectorClient.mm:
 757         (WebInspectorClient::bringFrontendToFront): Add a missing assertion.
 758         (WebInspectorFrontendClient::closeWindow):
 759         (WebInspectorFrontendClient::disconnectFromBackend):
 760         (-[WebInspectorWindowController windowShouldClose:]):
 761         (-[WebInspectorWindowController destroyInspectorView]): Always clear the frontend client.
 762         (-[WebInspectorWindowController destroyInspectorView:]): Renamed to above.
 763
 764 2015-08-26  Andy Estes  <aestes@apple.com>
 765
 766         [Content Filtering] Determine navigation and content policy before continuing to filter a load
 767         https://bugs.webkit.org/show_bug.cgi?id=148506
 768
 769         Reviewed by Brady Eidson.
 770
 771         Deleted parts of r188486 and r188851.
 772
 773         * WebCoreSupport/WebFrameLoaderClient.h:
 774         * WebCoreSupport/WebFrameLoaderClient.mm:
 775         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
 776         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
 777
 778 2015-08-31  Chris Dumez  <cdumez@apple.com>
 779
 780         Range.detach() / NodeIterator.detach() should be no-ops as per the latest DOM specification
 781         https://bugs.webkit.org/show_bug.cgi?id=148454
 782
 783         Reviewed by Ryosuke Niwa.
 784
 785         Update Range API call sites to reflect changes.
 786
 787         * WebView/WebImmediateActionController.mm:
 788         (dictionaryPopupInfoForRange):
 789
 790 2015-08-28  Myles C. Maxfield  <mmaxfield@apple.com>
 791
 792         Migrate GraphicsContexts from pointers to references
 793         https://bugs.webkit.org/show_bug.cgi?id=148561
 794
 795         Reviewed by Tim Horton.
 796
 797         * Misc/WebKitNSStringExtras.mm:
 798         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
 799         * WebCoreSupport/WebContextMenuClient.mm:
 800         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
 801         * WebView/WebFrame.mm:
 802         (-[WebFrame _drawRect:contentsOnly:]):
 803
 804 2015-08-28  Eric Carlson  <eric.carlson@apple.com>
 805
 806         [Mac] Restructure WebMediaSessionManager for testing
 807         https://bugs.webkit.org/show_bug.cgi?id=148593
 808
 809         Reviewed by Jer Noble.
 810
 811         * WebView/WebMediaPlaybackTargetPicker.mm:
 812         (WebMediaPlaybackTargetPicker::addPlaybackTargetPickerClient): Call WebMediaSessionManager::singleton,
 813           not WebMediaSessionManagerMac::singleton.
 814         (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient): Ditto.
 815         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Ditto.
 816         (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange): Ditto.
 817         (WebMediaPlaybackTargetPicker::setPlaybackTarget): Ditto.
 818         (WebMediaPlaybackTargetPicker::invalidate): Ditto.
 819
 820 2015-08-28  Jer Noble  <jer.noble@apple.com>
 821
 822         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
 823         https://bugs.webkit.org/show_bug.cgi?id=148579
 824
 825         Reviewed by Anders Carlsson.
 826
 827         Add a WebPreference to allow clients to control whether media is allowed to load automatically.
 828         Remove the (now unnecessary) WebFrame property to do the same.
 829
 830         * WebView/WebFrame.mm:
 831         (-[WebFrame mediaDataLoadsAutomatically]): Deleted.
 832         (-[WebFrame setMediaDataLoadsAutomatically:]): Deleted.
 833         * WebView/WebFramePrivate.h:
 834         * WebView/WebPreferenceKeysPrivate.h:
 835         * WebView/WebPreferences.mm:
 836         (+[WebPreferences initialize]):
 837         (-[WebPreferences mediaDataLoadsAutomatically]):
 838         (-[WebPreferences setMediaDataLoadsAutomatically:]):
 839         * WebView/WebPreferencesPrivate.h:
 840         * WebView/WebView.mm:
 841         (-[WebView _preferencesChanged:]):
 842
 843 2015-08-28  Beth Dakin  <bdakin@apple.com>
 844
 845         Crash in WK1 when clicking on a PDF inside an iframe
 846         https://bugs.webkit.org/show_bug.cgi?id=148585
 847         -and corresponding-
 848         rdar://problem/22165194
 849
 850         Reviewed by Tim Horton.
 851
 852         Only handle WebHTMLViews.
 853         * WebView/WebImmediateActionController.mm:
 854         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
 855         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
 856
 857 2015-08-28  Jer Noble  <jer.noble@apple.com>
 858
 859         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
 860         https://bugs.webkit.org/show_bug.cgi?id=147512
 861
 862         Reviewed by Anders Carlsson.
 863
 864         Add a new preference, inlineMediaPlaybackRequiresPlaysInlineAttribute, which defaults to
 865         NO on iPad and YES on iPhone and iPod.
 866
 867         * WebView/WebPreferenceKeysPrivate.h:
 868         * WebView/WebPreferences.mm:
 869         (+[WebPreferences initialize]): Default the value of WebKitAllowsInlineMediaPlaybackPreferenceKey to
 870         YES on iPad and NO on iPhone and iPod.
 871         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]):
 872         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]):
 873         * WebView/WebPreferencesPrivate.h:
 874         * WebView/WebView.mm:
 875         (-[WebView _preferencesChanged:]):
 876
 877 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
 878
 879         [Mac] Right-clicking on GIFs spins the UI process for a while
 880         https://bugs.webkit.org/show_bug.cgi?id=148566
 881         <rdar://problem/22460854>
 882
 883         Reviewed by Brady Eidson.
 884
 885         * WebCoreSupport/WebContextMenuClient.mm:
 886         (WebContextMenuClient::shareMenuItem):
 887         Make an NSImage directly from the hit image if possible.
 888
 889 2015-08-27  Timothy Horton  <timothy_horton@apple.com>
 890
 891         Factor out Lookup invocation
 892         https://bugs.webkit.org/show_bug.cgi?id=148509
 893
 894         Reviewed by Anders Carlsson.
 895
 896         * WebView/DictionaryPopupInfo.h: Removed.
 897         Move to WebCore.
 898
 899         * WebView/WebHTMLView.mm:
 900         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
 901         DictionaryPopupInfo keeps a TextIndicatorData, not a TextIndicator.
 902
 903         * WebView/WebImmediateActionController.mm:
 904         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
 905         (dictionaryPopupInfoForRange):
 906         (-[WebImmediateActionController _animationControllerForText]):
 907         * WebView/WebView.mm:
 908         (-[WebView _prepareForDictionaryLookup]):
 909         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
 910         (-[WebView _setTextIndicator:withLifetime:]):
 911         (-[WebView _showDictionaryLookupPopup:]):
 912         * WebView/WebViewInternal.h:
 913         Move a bunch of code to WebCore.
 914         Factor some that has to stay out into _prepareForDictionaryLookup.
 915
 916 2015-08-27  Brian Burg  <bburg@apple.com>
 917
 918         Web Inspector: FrontendChannel should know its own connection type
 919         https://bugs.webkit.org/show_bug.cgi?id=148482
 920
 921         Reviewed by Joseph Pecoraro.
 922
 923         * WebCoreSupport/WebInspectorClient.h: add connectionType().
 924
 925 2015-08-26  Beth Dakin  <bdakin@apple.com>
 926
 927         REGRESSION: Safari navigates after a cancelled force click
 928         https://bugs.webkit.org/show_bug.cgi?id=148491
 929         -and corresponding-
 930         rdar://problem/22394323
 931
 932         Reviewed by Tim Horton.
 933
 934         Use the current stage to determine which type of cancel this is.
 935         * WebView/WebImmediateActionController.mm:
 936         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
 937
 938 2015-08-26  Tim Horton  <timothy_horton@apple.com>
 939
 940         Layout Test platform/mac/fast/events/content-inset-hit-testing-in-frame.html is flaky
 941         https://bugs.webkit.org/show_bug.cgi?id=148409
 942
 943         Reviewed by Beth Dakin.
 944
 945         * WebView/WebDynamicScrollBarsView.mm:
 946         (-[WebDynamicScrollBarsView setContentInsets:]):
 947         Explicitly force our NSScrollView to lay out after updating
 948         content insets. We depend on this happening synchronously (specifically,
 949         we need our frame/bounds change callbacks to fire), because the layout
 950         which will happen subsequently needs up-to-date information in order to
 951         correctly a) enable scrollbars and then b) update the scroll position.
 952
 953 2015-08-23  Andy Estes  <aestes@apple.com>
 954
 955         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
 956         https://bugs.webkit.org/show_bug.cgi?id=147872
 957         rdar://problem/22044000
 958
 959         Reviewed by Dan Bernstein.
 960
 961         * WebCoreSupport/WebFrameLoaderClient.h:
 962         * WebCoreSupport/WebFrameLoaderClient.mm:
 963         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Set provisionalURL using the URL argument.
 964
 965 2015-08-23  Geoffrey Garen  <ggaren@apple.com>
 966
 967         Unreviewed, rolling back in r188803.
 968
 969         "Debugger's VM should never be null"
 970         https://bugs.webkit.org/show_bug.cgi?id=148341
 971         http://trac.webkit.org/changeset/188803
 972
 973         * WebView/WebScriptDebugger.mm:
 974         (toWebFrame):
 975         (WebScriptDebugger::WebScriptDebugger):
 976
 977 2015-08-21  Commit Queue  <commit-queue@webkit.org>
 978
 979         Unreviewed, rolling out r188792 and r188803.
 980         https://bugs.webkit.org/show_bug.cgi?id=148347
 981
 982         broke lots of tests, ggaren is going to investigate and reland
 983         (Requested by thorton on #webkit).
 984
 985         Reverted changesets:
 986
 987         "Unify code paths for manually deleting all code"
 988         https://bugs.webkit.org/show_bug.cgi?id=148280
 989         http://trac.webkit.org/changeset/188792
 990
 991         "Debugger's VM should never be null"
 992         https://bugs.webkit.org/show_bug.cgi?id=148341
 993         http://trac.webkit.org/changeset/188803
 994
 995 2015-08-21  Chris Dumez  <cdumez@apple.com>
 996
 997         document.getElementsByTagName should return an HTMLCollection
 998         https://bugs.webkit.org/show_bug.cgi?id=110611
 999
1000         Reviewed by Darin Adler.
1001
1002         * WebView/WebFrame.mm:
1003         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]):
1004         Use .ptr() as createFragmentFromMarkup() now returns a
1005         Ref<> instead of a RefPtr<>.
1006
1007 2015-08-21  Anders Carlsson  <andersca@apple.com>
1008
1009         Get rid of uses of the old callOnMainThread function that takes a function ptr + context
1010         https://bugs.webkit.org/show_bug.cgi?id=148324
1011
1012         Reviewed by Tim Horton.
1013
1014         * Storage/WebDatabaseManagerClient.mm:
1015         (DidModifyOriginData::dispatchToMainThread):
1016         (DidModifyOriginData::dispatchDidModifyOriginOnMainThread): Deleted.
1017         * Storage/WebStorageTrackerClient.h:
1018         * Storage/WebStorageTrackerClient.mm:
1019         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1020         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Deleted.
1021
1022 2015-08-19  Eric Carlson  <eric.carlson@apple.com>
1023
1024         Remove ENABLE_WEBVTT_REGIONS
1025         https://bugs.webkit.org/show_bug.cgi?id=148184
1026
1027         Reviewed by Jer Noble.
1028
1029         * Configurations/FeatureDefines.xcconfig: Remove ENABLE_WEBVTT_REGIONS.
1030
1031 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
1032
1033         Replace all remaining uses of WTF::Mutex with WTF::Lock
1034         https://bugs.webkit.org/show_bug.cgi?id=148089
1035
1036         Reviewed by Geoffrey Garen.
1037
1038         * Storage/WebDatabaseManager.mm:
1039         (transactionBackgroundTaskIdentifierLock):
1040         (+[WebDatabaseManager startBackgroundTask]):
1041         (+[WebDatabaseManager endBackgroundTask]):
1042         * WebView/WebView.mm:
1043         (-[WebView _synchronizeCustomFixedPositionLayoutRect]):
1044         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
1045         (-[WebView _setCustomFixedPositionLayoutRect:]):
1046         (-[WebView _fetchCustomFixedPositionLayoutRect:]):
1047         * WebView/WebViewData.h:
1048
1049 2015-08-17  Jeff Miller  <jeffm@apple.com>
1050
1051         Add a method to WebInspector to indicate whether the inspector is open
1052         https://bugs.webkit.org/show_bug.cgi?id=148087
1053
1054         Reviewed by Joseph Pecoraro.
1055
1056         * WebInspector/WebInspector.h:
1057         Added open property.
1058
1059         * WebInspector/WebInspector.mm:
1060         (-[WebInspector isOpen]):
1061         Added, returns YES if we have a frontend.
1062
1063 2015-08-13  Andy Estes  <aestes@apple.com>
1064
1065         [Cocoa] Downloads do not start if policy decision is made asynchronously
1066         https://bugs.webkit.org/show_bug.cgi?id=147985
1067
1068         Reviewed by Brady Eidson.
1069
1070         * WebCoreSupport/WebFrameLoaderClient.mm:
1071         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Started a new download if the main resource loader is not calling didReceiveResponse.
1072
1073 2015-08-13  Tim Horton  <timothy_horton@apple.com>
1074
1075         Performing a Lookup on wrapped text puts the popover arrow in the wrong place (off to the right)
1076         https://bugs.webkit.org/show_bug.cgi?id=148012
1077         <rdar://problem/19238094>
1078
1079         Reviewed by Simon Fraser.
1080
1081         * WebView/WebView.mm:
1082         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1083         (-[WebView _showDictionaryLookupPopup:]):
1084         Adopt the new SPI, handing it the first text rect, instead of having it
1085         guess where to put the popover.
1086         Also, null-check the TextIndicator.
1087
1088 2015-08-13  Tim Horton  <timothy_horton@apple.com>
1089
1090         Refactor and improve TextIndicator to prepare for tests
1091         https://bugs.webkit.org/show_bug.cgi?id=147622
1092
1093         Reviewed by Simon Fraser.
1094
1095         * WebView/WebFrame.mm:
1096         (-[WebFrame _rectsForRange:]):
1097         * WebView/WebHTMLView.mm:
1098         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1099         (-[WebHTMLView quickLookWithEvent:]):
1100         * WebView/WebImmediateActionController.mm:
1101         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
1102         (-[WebImmediateActionController _cancelImmediateAction]):
1103         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1104         (-[WebImmediateActionController _defaultAnimationController]):
1105         (-[WebImmediateActionController menuItemDidClose:]):
1106         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
1107         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
1108         (dictionaryPopupInfoForRange):
1109         * WebView/WebView.mm:
1110         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1111         (-[WebView _setTextIndicator:]):
1112         (-[WebView _setTextIndicator:withLifetime:]):
1113         (-[WebView _clearTextIndicatorWithAnimation:]):
1114         (-[WebView _showDictionaryLookupPopup:]):
1115         (-[WebView _dictionaryLookupPopoverWillClose:]):
1116         * WebView/WebViewInternal.h:
1117         Adopt TextIndicatorOptions.
1118         Adjust to Range method renames.
1119
1120 2015-08-13  Geoffrey Garen  <ggaren@apple.com>
1121
1122         Standardize on the phrase "delete code"
1123         https://bugs.webkit.org/show_bug.cgi?id=147984
1124
1125         Reviewed by Mark Lam.
1126
1127         * WebView/WebView.mm:
1128         (+[WebView discardAllCompiledCode]):
1129         (+[WebView isCharacterSmartReplaceExempt:isPreviousCharacter:]):
1130
1131 2015-08-12  Anders Carlsson  <andersca@apple.com>
1132
1133         Use WTF::Optional in WindowFeatures
1134         https://bugs.webkit.org/show_bug.cgi?id=147956
1135
1136         Reviewed by Sam Weinig.
1137
1138         * WebCoreSupport/WebChromeClient.mm:
1139         (WebChromeClient::createWindow):
1140
1141 2015-08-13  Matthew Daiter  <mdaiter@apple.com>
1142
1143         Linking device query ability from WebKit2 to clients
1144         https://bugs.webkit.org/show_bug.cgi?id=147263
1145         <rdar://problem/21983345>
1146
1147         Reviewed by Jer Noble.
1148
1149         * WebCoreSupport/WebUserMediaClient.mm:
1150         (-[WebUserMediaPolicyListener allow]):
1151         (-[WebUserMediaPolicyListener allowDeviceWithVideoUID:andAudioUID:]):
1152
1153
1154 2015-08-10  Chris Dumez  <cdumez@apple.com>
1155
1156         Align WebKit1's PageCache size with WebKit2's
1157         https://bugs.webkit.org/show_bug.cgi?id=147831
1158
1159         Reviewed by Sam Weinig.
1160
1161         Align WebKit1's PageCache size with WebKit2's for consistency. Also, we
1162         have data showing that keeping more than 3 pages in the PageCache is
1163         not really useful.
1164
1165         * WebView/WebView.mm:
1166         (+[WebView _setCacheModel:]):
1167
1168 2015-08-06  Anders Carlsson  <andersca@apple.com>
1169
1170         Crashes when calling swizzled setNeedsDisplayInRect: on heartbeat thread
1171         https://bugs.webkit.org/show_bug.cgi?id=147746
1172         rdar://problem/18698271
1173
1174         Reviewed by Dan Bernstein.
1175
1176         Back off if someone is calling our swizzled setNeedsDisplayInRect on a non-main thread.
1177
1178         * WebView/WebHTMLView.mm:
1179         (setNeedsDisplayInRect):
1180
1181 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
1182
1183         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
1184
1185         * Storage/WebDatabaseManager.mm:
1186         (transactionBackgroundTaskIdentifierLock):
1187         (+[WebDatabaseManager startBackgroundTask]):
1188         (+[WebDatabaseManager endBackgroundTask]):
1189         * WebView/WebView.mm:
1190         (-[WebView _synchronizeCustomFixedPositionLayoutRect]):
1191         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
1192         (-[WebView _setCustomFixedPositionLayoutRect:]):
1193         (-[WebView _fetchCustomFixedPositionLayoutRect:]):
1194         * WebView/WebViewData.h:
1195
1196 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
1197
1198         Rename Mutex to DeprecatedMutex
1199         https://bugs.webkit.org/show_bug.cgi?id=147675
1200
1201         Reviewed by Geoffrey Garen.
1202
1203         * Storage/WebDatabaseManager.mm:
1204         (transactionBackgroundTaskIdentifierLock):
1205         (+[WebDatabaseManager startBackgroundTask]):
1206         (+[WebDatabaseManager endBackgroundTask]):
1207         * WebView/WebView.mm:
1208         (-[WebView _synchronizeCustomFixedPositionLayoutRect]):
1209         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
1210         (-[WebView _setCustomFixedPositionLayoutRect:]):
1211         (-[WebView _fetchCustomFixedPositionLayoutRect:]):
1212         * WebView/WebViewData.h:
1213
1214 2015-08-04  Anders Carlsson  <andersca@apple.com>
1215
1216         Remove database thread pause code
1217         https://bugs.webkit.org/show_bug.cgi?id=147669
1218
1219         Reviewed by Daniel Bates.
1220
1221         * Storage/WebDatabaseManager.mm:
1222         (WebKitSetWebDatabasePaused): Deleted.
1223         * Storage/WebDatabaseManagerInternal.h:
1224
1225 2015-08-04  Simon Fraser  <simon.fraser@apple.com>
1226
1227         Fix the build.
1228
1229         * Plugins/WebNetscapePluginStream.h:
1230
1231 2015-08-04  Anders Carlsson  <andersca@apple.com>
1232
1233         Get rid of ReasonForCallingAllowPlugins since it's not used anywhere
1234         https://bugs.webkit.org/show_bug.cgi?id=147648
1235
1236         Reviewed by Andreas Kling.
1237
1238         * WebCoreSupport/WebPlatformStrategies.mm:
1239         (WebPlatformStrategies::getPluginInfo):
1240         * WebView/WebFrame.mm:
1241         (-[WebFrame _canProvideDocumentSource]):
1242
1243 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
1244
1245         Implement NPAPI redirect handling
1246         https://bugs.webkit.org/show_bug.cgi?id=138675
1247         rdar://problem/15779101
1248
1249         Patch by Jeffrey Pfau, updated and tweaked by me.
1250
1251         Reviewed by Anders Carlsson.
1252
1253         * Plugins/Hosted/HostedNetscapePluginStream.h:
1254         (WebKit::HostedNetscapePluginStream::streamID):
1255         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1256         (WebKit::HostedNetscapePluginStream::didFinishLoading):
1257         (WebKit::HostedNetscapePluginStream::willSendRequest):
1258         (WebKit::HostedNetscapePluginStream::didReceiveResponse):
1259         * Plugins/WebNetscapePluginStream.h:
1260         * Plugins/WebNetscapePluginStream.mm:
1261         (WebNetscapePluginStream::stop):
1262         (WebNetscapePluginStream::willSendRequest):
1263         (WebNetscapePluginStream::didReceiveResponse):
1264
1265 2015-08-03  Myles C. Maxfield  <mmaxfield@apple.com>
1266
1267         Unreviewed post-review feedback on r187797
1268
1269         The correct terminology is "registered" instead of "activated."
1270
1271         * WebView/WebHTMLView.mm:
1272         (-[WebHTMLView _updateFontPanel]):
1273
1274 2015-08-03  Myles C. Maxfield  <mmaxfield@apple.com>
1275
1276         Clean up casts between NSFont*s and CTFontRefs
1277         https://bugs.webkit.org/show_bug.cgi?id=147618
1278
1279         Reviewed by Mitz Pettel
1280
1281         For toll free bridged types, it makes more sense to do a C-style cast, than jump
1282         through hoops for older compilers.
1283
1284         * WebView/WebHTMLView.mm:
1285         (-[WebHTMLView _updateFontPanel]):
1286
1287 2015-08-03  Myles C. Maxfield  <mmaxfield@apple.com>
1288
1289         Fix the Yosemite build after r187797
1290
1291         Unreviewed.
1292
1293         * WebView/WebHTMLView.mm:
1294         (-[WebHTMLView _updateFontPanel]):
1295
1296 2015-08-03  Myles C. Maxfield  <mmaxfield@apple.com>
1297
1298         REGRESSION(r184899): Crash when focusing an input element styled with a web font
1299         https://bugs.webkit.org/show_bug.cgi?id=147616
1300         <rdar://problem/21838271>
1301
1302         Reviewed by Dean Jackson.
1303
1304         NSFontManager can't handle web fonts. We used to pass null to NSFontManager in this case,
1305         but r184899 changed that.
1306
1307         * WebView/WebHTMLView.mm:
1308         (-[WebHTMLView _updateFontPanel]):
1309
1310 2015-07-31  Chris Dumez  <cdumez@apple.com>
1311
1312         Drop dummy Timer callbacks
1313         https://bugs.webkit.org/show_bug.cgi?id=147516
1314
1315         Reviewed by Alexey Proskuryakov.
1316
1317         Drop dummy Timer callbacks in the code base. A lot of Timer callbacks
1318         do nothing else beside calling a particular method. In such case, we
1319         can use the called method as Timer callback instead.
1320
1321         * Plugins/WebNetscapePluginStream.h:
1322         * Plugins/WebNetscapePluginStream.mm:
1323         (WebNetscapePluginStream::WebNetscapePluginStream):
1324         (WebNetscapePluginStream::deliverDataTimerFired): Deleted.
1325
1326 2015-07-31  Brady Eidson  <beidson@apple.com>
1327
1328         REGRESSION (r174791): Returning a zombie NSImage from sharingService:transitionImageForShareItem:contentRect:
1329         <rdar://problem/22060183> and https://bugs.webkit.org/show_bug.cgi?id=147497
1330
1331         Reviewed by Tim Horton.
1332
1333         * WebCoreSupport/WebContextMenuClient.mm:
1334         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Don't return what is basically a temporary NSImage.
1335           Instead do a [[retain] autorelease] on it while still valid.
1336
1337 2015-07-29  Dean Jackson  <dino@apple.com>
1338
1339         Don't use (Details) when exposing SPI
1340         https://bugs.webkit.org/show_bug.cgi?id=147426
1341         <rdar://problem/22062407>
1342
1343         Reviewed by Dan Bernstein.
1344
1345         If we are declaring the interface without any implementation,
1346         we should use class extensions.
1347
1348         * WebView/WebFrameView.mm:
1349         * WebView/WebPDFView.mm:
1350
1351 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
1352
1353         Implement basic types for ECMAScript Internationalization API
1354         https://bugs.webkit.org/show_bug.cgi?id=146926
1355
1356         Reviewed by Benjamin Poulain.
1357
1358         * Configurations/FeatureDefines.xcconfig: Enabled INTL.
1359
1360 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1361
1362         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
1363         https://bugs.webkit.org/show_bug.cgi?id=147350
1364
1365         Reviewed by Sam Weinig.
1366
1367         * Configurations/FeatureDefines.xcconfig:
1368
1369 2015-07-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1370
1371         Remove runtime flags for symbols
1372         https://bugs.webkit.org/show_bug.cgi?id=147246
1373
1374         Reviewed by Alex Christensen.
1375
1376         * WebView/WebPreferencesPrivate.h:
1377
1378 2015-07-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1379
1380         Object.getOwnPropertySymbols on large list takes very long
1381         https://bugs.webkit.org/show_bug.cgi?id=146137
1382
1383         Reviewed by Mark Lam.
1384
1385         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1386         (WebKit::NetscapePluginInstanceProxy::enumerate):
1387
1388 2015-07-23  Alex Christensen  <achristensen@webkit.org>
1389
1390         Remove compile and runtime flags for promises.
1391         https://bugs.webkit.org/show_bug.cgi?id=147244
1392
1393         Reviewed by Yusuke Suzuki.
1394
1395         * Configurations/FeatureDefines.xcconfig:
1396         * WebView/WebPreferencesPrivate.h:
1397
1398 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
1399
1400         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
1401         https://bugs.webkit.org/show_bug.cgi?id=147212
1402
1403         Reviewed by Filip Pizlo.
1404
1405         * Configurations/FeatureDefines.xcconfig:
1406
1407 2015-07-21  Joseph Pecoraro  <pecoraro@apple.com>
1408
1409         Web Inspector: [Mac] "Open Image In New Window" context menu item does nothing on an image
1410         https://bugs.webkit.org/show_bug.cgi?id=147175
1411
1412         Reviewed by Timothy Hatcher.
1413
1414         * WebCoreSupport/WebInspectorClient.mm:
1415         (-[WebInspectorWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
1416         Remove default context menus that won't work in the inspector page.
1417
1418 2015-07-21  Simon Fraser  <simon.fraser@apple.com>
1419
1420         Add a logging channel for Layout, remove the LiveConnect channel
1421         https://bugs.webkit.org/show_bug.cgi?id=147170
1422
1423         Reviewed by Zalan Bujtas.
1424
1425         Add a layout logging channel to WebCore, and remove the LiveConnect channel.
1426
1427         * Misc/WebKitLogging.h:
1428         * Plugins/WebNetscapePluginPackage.mm:
1429         (-[WebNetscapePluginPackage _tryLoad]): Deleted.
1430
1431 2015-07-21  Brady Eidson  <beidson@apple.com>
1432
1433         Fix WebPreferences infinite recursion introduced in r186232.
1434         <rdar://problem/9091261> and https://bugs.webkit.org/show_bug.cgi?id=147149
1435
1436         Reviewed by Tim Horton.
1437
1438         * WebView/WebPreferences.mm:
1439         (-[WebPreferences metaRefreshEnabled]):
1440
1441 2015-07-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1442
1443         Reduce PassRefPtr in WebKit2 - 3
1444         https://bugs.webkit.org/show_bug.cgi?id=146995
1445
1446         Reviewed by Daniel Bates.
1447
1448         To remove PassRefPtr, this patch reduces use of PassRefPtr in WebKit2.
1449         Because some uses depend on WebCore, WebCore, WK1 ports are modified as well.
1450
1451         * WebCoreSupport/WebFrameLoaderClient.h:
1452         * WebCoreSupport/WebFrameLoaderClient.mm:
1453         (WebFrameLoaderClient::createDocumentLoader):
1454
1455 2015-07-17  Andy Estes  <aestes@apple.com>
1456
1457         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
1458         https://bugs.webkit.org/show_bug.cgi?id=147044
1459         rdar://problem/21567820
1460
1461         Reviewed by Brady Eidson.
1462
1463         * WebView/WebView.mm:
1464         (-[WebView _commonInitializationWithFrameName:groupName:]): Enabled Content-Disposition: attachment sandbox on iOS.
1465
1466 2015-07-16  Joseph Pecoraro  <pecoraro@apple.com>
1467
1468         Web Inspector: [Mac] Save dialog not working when inspector is docked
1469         https://bugs.webkit.org/show_bug.cgi?id=146991
1470
1471         Reviewed by Sam Weinig.
1472
1473         * WebCoreSupport/WebInspectorClient.mm:
1474         (WebInspectorFrontendClient::save):
1475         (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1476         When the window is nil (docked) use a non-window version of running the dialog.
1477
1478 2015-07-13  Simon Fraser  <simon.fraser@apple.com>
1479
1480         [iOS] Expose contentsSizeRespectingOverflow() via WebView so UIWebView can use it
1481         https://bugs.webkit.org/show_bug.cgi?id=146924
1482         WebKit part of rdar://problem/21802456
1483
1484         Reviewed by Tim Horton.
1485
1486         Expose the FrameView's contentsSizeRespectingOverflow() via WebView, for use
1487         by UIKit.
1488
1489         * WebView/WebView.mm:
1490         (-[WebView _contentsSizeRespectingOverflow]):
1491         * WebView/WebViewPrivate.h:
1492
1493 2015-07-14  Anders Carlsson  <andersca@apple.com>
1494
1495         Remove wkPopupMenu from WebCoreSystemInterface; it's not called from WebCore
1496         https://bugs.webkit.org/show_bug.cgi?id=146945
1497
1498         Reviewed by Tim Horton.
1499
1500         * WebCoreSupport/PopupMenuMac.mm:
1501         (PopupMenuMac::show):
1502         * WebCoreSupport/WebSystemInterface.mm:
1503         (InitWebCoreSystemInterface): Deleted.
1504
1505 2015-07-11  Nikita Vasilyev  <nvasilyev@apple.com>
1506
1507         Web Inspector: Inspector should be able to be docked to the bottom of a narrow window
1508         https://bugs.webkit.org/show_bug.cgi?id=146871
1509
1510         Reviewed by Timothy Hatcher.
1511
1512         * WebCoreSupport/WebInspectorClient.mm:
1513
1514 2015-07-07  Brady Eidson  <beidson@apple.com>
1515
1516         HTTP Auth cached after disabling private browsing/reset.
1517         <rdar://problem/8293055> and https://bugs.webkit.org/show_bug.cgi?id=146654
1518
1519         Reviewed by Tim Horton.
1520
1521         * Misc/WebCache.h:
1522         * Misc/WebCache.mm:
1523         (+[WebCache clearCachedCredentials]): Clear the global CredentialStorage as well as the
1524           storages belonging to each main frame of each WebView. This method is for DRT.
1525
1526         * Misc/WebDownload.mm:
1527         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1528
1529         * Plugins/WebBaseNetscapePluginView.mm:
1530         (WebKit::getAuthenticationInfo):
1531
1532         * WebView/WebView.mm:
1533         (-[WebView _clearCredentials]): Clear the storage belonging to the current networking session
1534           of the main frame of this WebView.
1535         * WebView/WebViewInternal.h:
1536
1537 2015-07-04  Chris Dumez  <cdumez@apple.com>
1538
1539         Drop RefPtr::clear() method
1540         https://bugs.webkit.org/show_bug.cgi?id=146556
1541
1542         Reviewed by Brady Eidson.
1543
1544         Drop RefPtr::clear() method in favor of "= nullptr;" pattern.
1545
1546 2015-07-03  Dan Bernstein  <mitz@apple.com>
1547
1548         [Xcode] Update some build settings as recommended by Xcode 7
1549         https://bugs.webkit.org/show_bug.cgi?id=146597
1550
1551         Reviewed by Sam Weinig.
1552
1553         * Configurations/Base.xcconfig: Enabled CLANG_WARN_UNREACHABLE_CODE,
1554         GCC_WARN_UNDECLARED_SELECTOR and GCC_NO_COMMON_BLOCKS. Removed GCC_MODEL_TUNING.
1555
1556 2015-07-02  Timothy Horton  <timothy_horton@apple.com>
1557
1558         Fix the build.
1559
1560         Rubber-stamped by Brady Eidson.
1561
1562         * WebView/WebView.mm:
1563         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1564         Http, not HTTP, for settings generator reasons.
1565
1566 2015-07-02  Brady Eidson  <beidson@apple.com>
1567
1568         Add preference to disable all http-equiv.
1569         <rdar://problem/9091261> and https://bugs.webkit.org/show_bug.cgi?id=146553
1570
1571         Reviewed by Sam Weinig.
1572
1573         * WebView/WebPreferenceKeysPrivate.h:
1574
1575         * WebView/WebPreferences.mm:
1576         (+[WebPreferences initialize]):
1577         (-[WebPreferences setMetaRefreshEnabled:]): Still expose this SPI, but have it affect
1578           the "httpEquivEnabled" setting.
1579         (-[WebPreferences metaRefreshEnabled]): Ditto.
1580         (-[WebPreferences setHTTPEquivEnabled:]):
1581         (-[WebPreferences httpEquivEnabled]):
1582         * WebView/WebPreferencesPrivate.h:
1583
1584         * WebView/WebView.mm:
1585         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1586         (-[WebView _preferencesChanged:]):
1587
1588 2015-07-02  Timothy Horton  <timothy_horton@apple.com>
1589
1590         iOS WebKitLegacy should match WebKit2's viewport behavior
1591         https://bugs.webkit.org/show_bug.cgi?id=146540
1592         <rdar://problem/20574017>
1593
1594         Reviewed by Dan Bernstein.
1595
1596         A number of changes have been made to WebKit2's viewport behavior
1597         to make it possible to scale "responsive" sites that misbehave (lay out
1598         in a non-responsive way).
1599
1600         * History/WebHistoryItem.mm:
1601         * History/WebHistoryItemPrivate.h:
1602         Add the plumbing required to implement these new behaviors in WebKit1.
1603
1604 2015-07-01  Dean Jackson  <dino@apple.com>
1605
1606         Disable the experimental WebGL2 implementation
1607         https://bugs.webkit.org/show_bug.cgi?id=146526
1608         <rdar://problem/21641235>
1609
1610         Reviewed by Myles Maxfield.
1611
1612         Add (and disable) an ENABLE_WEBGL2 flag.
1613
1614         * Configurations/FeatureDefines.xcconfig:
1615
1616 2015-07-01  Simon Fraser  <simon.fraser@apple.com>
1617
1618         Fix the iOS build.
1619
1620         * WebCoreSupport/WebUserMediaClient.mm:
1621         (-[WebUserMediaPolicyListener denyOnlyThisRequest]): Remove ASSERT_NOT_REACHED,
1622         because it caused the compiler to warn about noreturn.
1623
1624 2015-07-01  Matthew Daiter  <mdaiter@apple.com>
1625
1626         Enable MEDIA_STREAM flag
1627         https://bugs.webkit.org/show_bug.cgi?id=145947
1628         <rdar://problem/21365829>
1629
1630         Reviewed by Eric Carlson.
1631
1632         * Configurations/FeatureDefines.xcconfig: Added MEDIA_STREAM flag
1633         * WebCoreSupport/WebUserMediaClient.h: Changed signatures
1634         * WebCoreSupport/WebUserMediaClient.mm: Changed signatures
1635         (WebUserMediaClient::requestPermission):
1636         (WebUserMediaClient::cancelRequest):
1637         (-[WebUserMediaPolicyListener denyOnlyThisRequest]):
1638         (-[WebUserMediaPolicyListener shouldClearCache]):
1639
1640 2015-07-01  Brady Eidson  <beidson@apple.com>
1641
1642         REGRESSION (185319): Reproducible crash in WebHistoryItem launching FluidApp.
1643         <rdar://problem/21598293> and https://bugs.webkit.org/show_bug.cgi?id=146494
1644
1645         Reviewed by Darin Adler.
1646
1647         * History/WebHistoryItem.mm:
1648         (-[WebHistoryItem initFromDictionaryRepresentation:]): Don’t reference members of a Vector
1649           that don’t exist.
1650
1651 2015-06-30  Andy VanWagoner  <thetalecrafter@gmail.com>
1652
1653         Implement ECMAScript Internationalization API
1654         https://bugs.webkit.org/show_bug.cgi?id=90906
1655
1656         Reviewed by Benjamin Poulain.
1657
1658         * Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag
1659
1660 2015-06-30  Simon Fraser  <simon.fraser@apple.com>
1661
1662         Crash under _layoutForNodeHighlight: when inspecting espn.com
1663         https://bugs.webkit.org/show_bug.cgi?id=146422
1664
1665         Reviewed by Joseph Pecoraro.
1666
1667         When inspecting espn.com, MobileSafari sometimes crashes, because
1668         highlight.quads is empty. I was not able to quickly determine why.
1669
1670         Fix by bailing in this case.
1671
1672         * WebInspector/WebNodeHighlightView.mm:
1673         (-[WebNodeHighlightView _layoutForNodeHighlight:parent:]):
1674
1675 2015-06-30  Anders Carlsson  <andersca@apple.com>
1676
1677         Remove the WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS ifdefs now that this is always true
1678         https://bugs.webkit.org/show_bug.cgi?id=146462
1679
1680         Reviewed by Dan Bernstein.
1681
1682         * Misc/WebDownload.h:
1683         * WebView/WebFrameLoadDelegate.h:
1684         * WebView/WebPolicyDelegate.h:
1685         * WebView/WebResourceLoadDelegate.h:
1686         * WebView/WebUIDelegate.h:
1687         * WebView/WebView.h:
1688         * postprocess-headers.sh:
1689
1690 2015-06-29  Anders Carlsson  <andersca@apple.com>
1691
1692         Get rid of unused WKSI functions
1693         https://bugs.webkit.org/show_bug.cgi?id=146443
1694
1695         Reviewed by Tim Horton.
1696
1697         * WebCoreSupport/WebSystemInterface.mm:
1698         (InitWebCoreSystemInterface): Deleted.
1699
1700 2015-06-29  Dean Jackson  <dino@apple.com>
1701
1702         Temporarily disable PICTURE_SIZES
1703         https://bugs.webkit.org/show_bug.cgi?id=146435
1704         <rdar://problem/21087013>
1705
1706         Reviewed by Tim Horton.
1707
1708         Temporarily disable PICTURE_SIZES because it causes problems with out
1709         of date <picture> polyfills.
1710
1711         * Configurations/FeatureDefines.xcconfig:
1712
1713 2015-06-27  Ryosuke Niwa  <rniwa@webkit.org>
1714
1715         Font panel doesn't get updated when bolding text via cmd+b in Mail on OS X
1716         https://bugs.webkit.org/show_bug.cgi?id=146379
1717
1718         Reviewed by Darin Adler.
1719
1720         Update the font panel when newly added EditorClient::didApplyStyle is called. Also set the font attributes
1721         in _updateFontPanel so that underline and strike through states will be reflected.
1722
1723         * WebCoreSupport/WebEditorClient.h:
1724         * WebCoreSupport/WebEditorClient.mm:
1725         (WebEditorClient::shouldApplyStyle):
1726         (updateFontPanelIfNeeded): Extracted from respondToChangedContents.
1727         (WebEditorClient::didApplyStyle): Added.
1728         (WebEditorClient::respondToChangedContents):
1729         * WebView/WebHTMLView.mm:
1730         (-[WebHTMLView _updateFontPanel]): Sets font attributes as well as font.
1731
1732 2015-06-29  Dean Jackson  <dino@apple.com>
1733
1734         Setting to enable/disable media controls sizing on page zoom
1735         https://bugs.webkit.org/show_bug.cgi?id=146423
1736         <rdar://problem/18379634>
1737
1738         Reviewed by Eric Carlson.
1739
1740         Add a new setting "MediaControlsScaleWithPageZoom" that can disable
1741         the behaviour we currently implement on iOS, where the media controls
1742         attempt to remain at a fixed size independent of page zoom.
1743
1744         * WebView/WebPreferenceKeysPrivate.h:
1745         * WebView/WebPreferences.mm:
1746         (+[WebPreferences initialize]): Initialize to false on iOS, true otherwise.
1747         (-[WebPreferences mediaControlsScaleWithPageZoom]):
1748         (-[WebPreferences setMediaControlsScaleWithPageZoom:]):
1749         * WebView/WebPreferencesPrivate.h:
1750         * WebView/WebView.mm:
1751         (-[WebView _preferencesChanged:]):
1752
1753 2015-06-29  Anders Carlsson  <andersca@apple.com>
1754
1755         Use DISPATCH_SOURCE_TYPE_MEMORYPRESSURE instead of DISPATCH_SOURCE_TYPE_MEMORYSTATUS
1756         https://bugs.webkit.org/show_bug.cgi?id=146413
1757
1758         Reviewed by Andreas Kling.
1759
1760         Replace SPI with API.
1761
1762         * WebCoreSupport/WebSystemInterface.mm:
1763         (InitWebCoreSystemInterface): Deleted.
1764         * WebView/WebView.mm:
1765         (+[WebView registerForMemoryNotifications]):
1766
1767 2015-06-28  Darin Adler  <darin@apple.com>
1768
1769         [Mac] Remove redundant call to colorUsingColorSpaceName:
1770         https://bugs.webkit.org/show_bug.cgi?id=146397
1771
1772         Reviewed by Alexey Proskuryakov.
1773
1774         * WebView/WebHTMLView.mm:
1775         (extractUnderlines): Remove call to the colorUsingColorSpaceName: method,
1776         since colorFromNSColor already calls it. No need to do it twice.
1777
1778 2015-06-26  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1779
1780         [Win] Implement WebViewGroup to support WebView::addxxxToGroup().
1781         https://bugs.webkit.org/show_bug.cgi?id=145908
1782
1783         Reviewed by Brent Fulgham.
1784
1785         Make WebViewGroup class sharing on Mac and Win port.
1786
1787         * WebCoreSupport/WebViewGroup.h: Removed.
1788         * WebCoreSupport/WebViewGroup.mm: Removed.
1789
1790 2015-06-25  Joseph Pecoraro  <pecoraro@apple.com>
1791
1792         Web Inspector: Add Support for OS X Full Screen Mode
1793         https://bugs.webkit.org/show_bug.cgi?id=123510
1794
1795         Reviewed by Timothy Hatcher.
1796
1797         * WebCoreSupport/WebInspectorClient.h:
1798         * WebCoreSupport/WebInspectorClient.mm:
1799         (WebInspectorClient::didResizeMainFrame):
1800         (WebInspectorClient::windowFullScreenDidChange):
1801         (WebInspectorClient::canAttach):
1802         (WebInspectorFrontendClient::canAttach):
1803         (-[WebInspectorWindowController showWindow:]):
1804         Consolidate canAttach logic into canAttach functions.
1805
1806         (-[WebInspectorWindowController window:]):
1807         Share the same full screen behavior as WebKit2.
1808
1809         (-[WebInspectorWindowController windowDidEnterFullScreen:]):
1810         (-[WebInspectorWindowController windowDidExitFullScreen:]):
1811         Attach availability may have changed.
1812
1813 2015-06-25  Joseph Pecoraro  <pecoraro@apple.com>
1814
1815         [Mac] Web Inspector: Window dragging on toolbar should behave more like native window dragging
1816         https://bugs.webkit.org/show_bug.cgi?id=146324
1817
1818         Reviewed by Timothy Hatcher.
1819
1820         * WebCoreSupport/WebInspectorClient.h:
1821         * WebCoreSupport/WebInspectorClient.mm:
1822         (WebInspectorFrontendClient::startWindowDrag):
1823         Start performing a window drag.
1824
1825 2015-06-23  Anders Carlsson  <andersca@apple.com>
1826
1827         Remove windowResizerRect code, nobody is using it anymore
1828         https://bugs.webkit.org/show_bug.cgi?id=146265
1829
1830         Reviewed by Beth Dakin.
1831
1832         * WebCoreSupport/WebChromeClient.h:
1833         * WebCoreSupport/WebChromeClient.mm:
1834         (WebChromeClient::windowResizerRect): Deleted.
1835
1836 2015-06-22  Chris Dumez  <cdumez@apple.com>
1837
1838         [WK1] WebAllowDenyPolicyListener.denyOnlyThisRequest() should not start a new permission request
1839         https://bugs.webkit.org/show_bug.cgi?id=146228
1840         <rdar://problem/15179262>
1841
1842         Reviewed by Daniel Bates.
1843
1844         Call the new Geolocation::resetIsAllowed() API after denying the
1845         current request, instead of calling
1846         Geolocation::resetAllGeolocationPermission(). In addition to resetting
1847         m_allowGeolocation to Unknown, the latter would also start a new
1848         permission request. However, for
1849         WebAllowDenyPolicyListener.denyOnlyThisRequest(), we really only want
1850         to deny the current request and then reset m_allowGeolocation to
1851         Unknown so that permission is requested again later if the app requests
1852         a position again.
1853
1854         The previous implementation meant that if the client application keeps
1855         calling WebAllowDenyPolicyListener.denyOnlyThisRequest(), we would end
1856         up in an infinite loop (requesting for permission), even though the
1857         application did not make any new geolocation requests.
1858
1859         * WebCoreSupport/WebGeolocationClient.mm:
1860         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
1861
1862 2015-06-22  Anders Carlsson  <andersca@apple.com>
1863
1864         Delegates should be formal protocols
1865         https://bugs.webkit.org/show_bug.cgi?id=146222
1866         rdar://problem/17380856
1867
1868         Reviewed by Dan Bernstein.
1869
1870         Flip the switch on OS X and make delegates formal protocols.
1871
1872         * postprocess-headers.sh:
1873
1874 2015-06-20  Tim Horton  <timothy_horton@apple.com>
1875
1876         Deselection of text causes a noticeable jump on force touch machines
1877         https://bugs.webkit.org/show_bug.cgi?id=146173
1878         <rdar://problem/20992842>
1879
1880         Reviewed by Sam Weinig.
1881
1882         * WebView/WebImmediateActionController.mm:
1883         (-[WebImmediateActionController _animationControllerForText]):
1884         Get rid of TextIndicatorPresentationTransition::Crossfade.
1885
1886 2015-06-19  Brent Fulgham  <bfulgham@apple.com>
1887
1888         All calls of ImageBuffer::create should null check the return value
1889         https://bugs.webkit.org/show_bug.cgi?id=22132
1890
1891         Reviewed by Zalan Bujtas.
1892
1893         ImageBuffer::create returns nullptr for a number of reasons, and should be
1894         expected to do so. We missed this check in a few places, resulting in
1895         crashes on some systems. Likewise, ImageBuffer::copyImage may return nullptr
1896         in normal use and should be checked.
1897
1898         * WebCoreSupport/WebContextMenuClient.mm:
1899         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Add nullptr check
1900         for copyImage.
1901
1902 2015-06-18  Jon Lee  <jonlee@apple.com>
1903
1904         Update AVKit usage of pip
1905         https://bugs.webkit.org/show_bug.cgi?id=146095
1906         <rdar://problem/21386853>
1907
1908         Reviewed by Eric Carlson.
1909
1910         - Rename preference key
1911         - Rename shouldAllowAlternateFullscreen to shouldAllowPictureInPictureMediaPlayback
1912
1913         * WebCoreSupport/WebSystemInterface.mm:
1914         * WebView/WebPreferenceKeysPrivate.h:
1915         * WebView/WebPreferences.mm:
1916         (-[WebPreferences allowsAlternateFullscreen]): Call allowsPictureInPictureMediaPlayback.
1917         (-[WebPreferences setAllowsAlternateFullscreen:]):
1918         (-[WebPreferences allowsPictureInPictureMediaPlayback]): Added.
1919         (-[WebPreferences setAllowsPictureInPictureMediaPlayback:]):
1920         * WebView/WebPreferencesPrivate.h:
1921         * WebView/WebView.mm:
1922
1923 2015-06-18  Anders Carlsson  <andersca@apple.com>
1924
1925         Remove shouldInterruptJavaScript
1926         https://bugs.webkit.org/show_bug.cgi?id=146118
1927
1928         Reviewed by Antti Koivisto.
1929
1930         * WebCoreSupport/WebChromeClient.h:
1931         * WebCoreSupport/WebChromeClient.mm:
1932         (WebChromeClient::shouldInterruptJavaScript): Deleted.
1933         * WebView/WebUIDelegatePrivate.h:
1934
1935 2015-06-17  Alex Christensen  <achristensen@webkit.org>
1936
1937         [Content Extensions] Log blocked loads to the WebInspector console
1938         https://bugs.webkit.org/show_bug.cgi?id=146089
1939
1940         Reviewed by Joseph Pecoraro.
1941
1942         * WebCoreSupport/WebChromeClient.mm:
1943         (stringForMessageSource):
1944         Added content blocker message source.
1945
1946 2015-06-17  Dan Bernstein  <mitz@apple.com>
1947
1948         <rdar://problem/19034131> Cleaned up the WebDownload.h framework header.
1949
1950         Reviewed by Anders Carlsson.
1951
1952         * Misc/WebDownload.h: Changed to use USE_APPLE_INTERNAL_SDK instead of __has_include.
1953         * postprocess-headers.sh: Define USE_APPLE_INTERNAL_SDK when postprocessing framework
1954         headers.
1955
1956 2015-06-17  Commit Queue  <commit-queue@webkit.org>
1957
1958         Unreviewed, rolling out r185636.
1959         https://bugs.webkit.org/show_bug.cgi?id=146068
1960
1961         Caused many crashes on Windows (Requested by ap on #webkit).
1962
1963         Reverted changeset:
1964
1965         "[Win] Implement WebViewGroup to support
1966         WebView::addxxxToGroup()."
1967         https://bugs.webkit.org/show_bug.cgi?id=145908
1968         http://trac.webkit.org/changeset/185636
1969
1970 2015-06-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1971
1972         [Win] Implement WebViewGroup to support WebView::addxxxToGroup().
1973         https://bugs.webkit.org/show_bug.cgi?id=145908
1974
1975         Reviewed by Brent Fulgham.
1976
1977         Make WebViewGroup class sharing on Mac and Win port.
1978
1979         * WebCoreSupport/WebViewGroup.h: Removed.
1980         * WebCoreSupport/WebViewGroup.mm: Removed.
1981
1982 2015-06-13  Chris Dumez  <cdumez@apple.com>
1983
1984         [WK2] API::Navigation objects are leaked on history navigation to HistoryItems in PageCache
1985         https://bugs.webkit.org/show_bug.cgi?id=145948
1986
1987         Reviewed by Darin Adler.
1988
1989         Add empty implementation for new
1990         FrameLoaderClient::updatedCachedDocumentLoader().
1991
1992         * WebCoreSupport/WebFrameLoaderClient.h:
1993
1994 2015-06-11  Mark Lam  <mark.lam@apple.com>
1995
1996         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
1997         https://bugs.webkit.org/show_bug.cgi?id=145872
1998
1999         Reviewed by Michael Saboff.
2000
2001         * WebView/WebView.mm:
2002         (+[WebView _reportException:inContext:]):
2003         - Don't assume we have an Exception object.  Let WebCore::reportException() take
2004           care of it.
2005
2006 2015-06-11  Jon Lee  <jonlee@apple.com>
2007
2008         Update media controls JS and CSS to use picture-in-picture
2009         https://bugs.webkit.org/show_bug.cgi?id=145827
2010         <rdar://problem/21311576>
2011
2012         Reviewed by Dean Jackson.
2013
2014         * WebCoreSupport/WebSystemInterface.mm:
2015         (InitWebCoreSystemInterface): Deleted GetMediaUIImageData.
2016
2017 2015-06-10  Jon Honeycutt  <jhoneycutt@apple.com>
2018
2019         Meta refresh preference is not respected on fast path WebView
2020         initialization
2021
2022         <https://bugs.webkit.org/show_bug.cgi?id=145861>
2023         <rdar://problem/21309911>
2024
2025         Reviewed by Brady Eidson.
2026
2027         * WebView/WebView.mm:
2028         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2029         Set the WebCore setting from the WebPreferences preference.
2030
2031 2015-06-09  Anders Carlsson  <andersca@apple.com>
2032
2033         Remove more unused SPI methods
2034         https://bugs.webkit.org/show_bug.cgi?id=145804
2035
2036         Reviewed by Simon Fraser.
2037
2038         * Misc/WebNSURLRequestExtras.h:
2039         * Misc/WebNSURLRequestExtras.m:
2040         (-[NSURLRequest _web_HTTPReferrer]): Deleted.
2041         (-[NSURLRequest _web_HTTPContentType]): Deleted.
2042         (-[NSURLRequest _web_isConditionalRequest]): Deleted.
2043
2044 2015-06-08  Dan Bernstein  <mitz@apple.com>
2045
2046         Removed WebDragSourceActionAttachment from the WebDragSourceAction enum.
2047
2048         Rubber-stamped by Anders Carlsson.
2049
2050         * WebView/WebUIDelegate.h: Removed the value. It was added in r181760 and never used.
2051
2052 2015-06-08  Chris Dumez  <cdumez@apple.com>
2053
2054         Access GCController instance via GCController::singleton() instead of a free function
2055         https://bugs.webkit.org/show_bug.cgi?id=145776
2056
2057         Reviewed by Darin Adler.
2058
2059         Access GCController instance via GCController::singleton() instead of a
2060         free function as per coding style and for consistency with other
2061         singleton classes in the codebase.
2062
2063         * Misc/WebCoreStatistics.mm:
2064         (+[WebCoreStatistics garbageCollectJavaScriptObjects]):
2065         (+[WebCoreStatistics garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging:]):
2066         (+[WebCoreStatistics setJavaScriptGarbageCollectorTimerEnabled:]):
2067         * WebView/WebView.mm:
2068         (+[WebView garbageCollectNow]):
2069         (+[WebView discardAllCompiledCode]):
2070         (-[WebView _close]):
2071
2072 2015-06-08  Anders Carlsson  <andersca@apple.com>
2073
2074         Remove more unused Objective-C methods
2075         https://bugs.webkit.org/show_bug.cgi?id=145761
2076
2077         Reviewed by Geoffrey Garen.
2078
2079         * Misc/WebNSImageExtras.h:
2080         * Misc/WebNSImageExtras.m:
2081         (-[NSImage _web_saveAndOpen]): Deleted.
2082         * Misc/WebNSViewExtras.h:
2083         * Misc/WebNSViewExtras.m:
2084         (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Deleted.
2085         (-[NSView _web_convertRect:toView:]): Deleted.
2086
2087 2015-06-08  Anders Carlsson  <andersca@apple.com>
2088
2089         Try to fix the Mavericks build.
2090
2091         * WebView/WebPDFView.mm:
2092         (removeUselessMenuItemSeparators):
2093
2094 2015-06-07  Anders Carlsson  <andersca@apple.com>
2095
2096         Remove WebNSArrayExtras
2097         https://bugs.webkit.org/show_bug.cgi?id=145747
2098
2099         Reviewed by Darin Adler.
2100
2101         * History/WebHistoryItem.mm:
2102         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2103         * Misc/WebNSArrayExtras.h: Removed.
2104         * Misc/WebNSArrayExtras.m: Removed.
2105         (-[NSArray _webkit_numberAtIndex:]): Deleted.
2106         (-[NSArray _webkit_stringAtIndex:]): Deleted.
2107         (-[NSMutableArray _webkit_removeUselessMenuItemSeparators]): Deleted.
2108         * WebView/WebPDFView.mm:
2109         (removeUselessMenuItemSeparators):
2110         (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
2111
2112 2015-06-08  Dan Bernstein  <mitz@apple.com>
2113
2114         Fixed the build.
2115
2116         * WebView/WebView.mm:
2117         (+[WebView _setCacheModel:]):
2118
2119 2015-06-07  Anders Carlsson  <andersca@apple.com>
2120
2121         Remove WebKitSystemBits
2122         https://bugs.webkit.org/show_bug.cgi?id=145746
2123
2124         Reviewed by Dan Bernstein.
2125
2126         Fold WebVolumeFreeSize into its only caller and get rid of WebKitSystemBits.
2127
2128         * Misc/WebKitSystemBits.h: Removed.
2129         * Misc/WebKitSystemBits.m: Removed.
2130         * WebView/WebPreferences.mm:
2131         * WebView/WebView.mm:
2132         (+[WebView _setCacheModel:]):
2133
2134 2015-06-07  Anders Carlsson  <andersca@apple.com>
2135
2136         Remove another SPI method that hasn't been used since Tiger
2137         https://bugs.webkit.org/show_bug.cgi?id=145745
2138
2139         Reviewed by Dan Bernstein.
2140
2141         * WebView/WebView.mm:
2142         (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]): Deleted.
2143         * WebView/WebViewPrivate.h:
2144
2145 2015-06-07  Anders Carlsson  <andersca@apple.com>
2146
2147         Remove another unused SPI method
2148         https://bugs.webkit.org/show_bug.cgi?id=145743
2149
2150         Reviewed by Dan Bernstein.
2151
2152         * WebView/WebView.mm:
2153         (+[WebView _pointingHandCursor]): Deleted.
2154         * WebView/WebViewPrivate.h:
2155
2156 2015-06-07  Anders Carlsson  <andersca@apple.com>
2157
2158         Remove unused SPI
2159         https://bugs.webkit.org/show_bug.cgi?id=145742
2160
2161         Reviewed by Dan Bernstein.
2162
2163         * WebCoreSupport/WebFrameNetworkingContext.h:
2164         * WebCoreSupport/WebFrameNetworkingContext.mm:
2165         (WebFrameNetworkingContext::clearPrivateBrowsingSessionCookieStorage): Deleted.
2166         * WebView/WebView.mm:
2167         (+[WebView _clearPrivateBrowsingSessionCookieStorage]): Deleted.
2168         * WebView/WebViewPrivate.h:
2169
2170 2015-06-06  Dan Bernstein  <mitz@apple.com>
2171
2172         Restored binary compatibility with shipping Safari.
2173
2174         Suggested by Anders Carlsson.
2175
2176         * Misc/WebKitNSStringExtras.mm:
2177         (-[NSString _webkit_fixedCarbonPOSIXPath]): Added an implementation that returns self, so
2178         that Safari doesn’t crash when trying to call this method.
2179
2180 2015-06-06  Dan Bernstein  <mitz@apple.com>
2181
2182         Fixed the build.
2183
2184         * Plugins/WebBasePluginPackage.mm:
2185
2186 2015-06-06  Anders Carlsson  <andersca@apple.com>
2187
2188         Remove support from getting plug-in information from Carbon resources
2189         https://bugs.webkit.org/show_bug.cgi?id=145730
2190
2191         Reviewed by Dan Bernstein.
2192
2193         No current plug-in versions use this feature, and both Chrome and Mozilla for
2194         Mac stopped looking at Carbon resources years ago.
2195
2196         * Misc/WebKitNSStringExtras.h:
2197         * Misc/WebKitNSStringExtras.mm:
2198         (+[NSString _web_encodingForResource:]): Deleted.
2199         * Plugins/WebBasePluginPackage.mm:
2200         * Plugins/WebNetscapePluginPackage.mm:
2201         (-[WebNetscapePluginPackage _initWithPath:]):
2202         (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): Deleted.
2203         (-[WebNetscapePluginPackage getPluginInfoFromResources]): Deleted.
2204
2205 2015-06-06  Anders Carlsson  <andersca@apple.com>
2206
2207         Remove now unused category methods
2208         https://bugs.webkit.org/show_bug.cgi?id=145729
2209
2210         Reviewed by Dan Bernstein.
2211
2212         * Configurations/WebKitLegacy.xcconfig:
2213         * Misc/WebKitNSStringExtras.h:
2214         * Misc/WebKitNSStringExtras.mm:
2215         (-[NSString _webkit_fixedCarbonPOSIXPath]): Deleted.
2216         * Misc/WebNSFileManagerExtras.h:
2217         * Misc/WebNSFileManagerExtras.mm:
2218         (-[NSFileManager _webkit_startupVolumeName]): Deleted.
2219
2220 2015-06-06  Anders Carlsson  <andersca@apple.com>
2221
2222         Fix build.
2223
2224         * WebKit.mac.exp:
2225
2226 2015-06-06  Anders Carlsson  <andersca@apple.com>
2227
2228         Stop using _webkit_fixedCarbonPOSIXPath in plug-in code
2229         https://bugs.webkit.org/show_bug.cgi?id=145728
2230
2231         Reviewed by Dan Bernstein.
2232
2233         This code was put in place to support old plug-ins that would pass Carbon paths to NPAPI functions.
2234         WebKit2 never supported this and we've never had any problems so let's just get rid of it.
2235
2236         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2237         (WebKit::NetscapePluginInstanceProxy::loadURL):
2238         * Plugins/WebNetscapePluginView.mm:
2239         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
2240
2241 2015-06-06  Anders Carlsson  <andersca@apple.com>
2242
2243         Remove SPI that's no longer used
2244         https://bugs.webkit.org/show_bug.cgi?id=145727
2245
2246         Reviewed by Dan Bernstein.
2247
2248         * Plugins/WebPluginsPrivate.h: Removed.
2249         * Plugins/WebPluginsPrivate.m: Removed.
2250
2251 2015-06-06  Anders Carlsson  <andersca@apple.com>
2252
2253         Only allow plug-ins to create custom MIME property lists on older versions of OS X
2254         https://bugs.webkit.org/show_bug.cgi?id=145726
2255
2256         Reviewed by Dan Bernstein.
2257
2258         * Plugins/WebBasePluginPackage.mm:
2259         (-[WebBasePluginPackage getPluginInfoFromPLists]):
2260
2261 2015-06-05  Mark Lam  <mark.lam@apple.com>
2262
2263         finally blocks should not set the exception stack trace when re-throwing the exception.
2264         https://bugs.webkit.org/show_bug.cgi?id=145525
2265
2266         Reviewed by Geoffrey Garen.
2267
2268         * WebView/WebView.mm:
2269         (+[WebView _reportException:inContext:]):
2270         (WebKitInitializeApplicationCachePathIfNecessary):
2271         - Changed to use the new Exception object.
2272
2273 2015-06-03  Anders Carlsson  <andersca@apple.com>
2274
2275         Define WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS on iOS
2276         https://bugs.webkit.org/show_bug.cgi?id=145615
2277         Part of rdar://problem/17380856.
2278
2279         Reviewed by Dan Bernstein.
2280
2281         * postprocess-headers.sh:
2282
2283 2015-06-02  Brady Eidson  <beidson@apple.com>
2284
2285         WebKit policy delegate should suggest if a navigation should be allowed to open URLs externally.
2286         rdar://problem/21025301 and https://bugs.webkit.org/show_bug.cgi?id=145280
2287
2288         Reviewed by Alex Christensen.
2289
2290         * Plugins/WebPluginController.mm:
2291         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
2292
2293         * WebView/WebFrame.mm:
2294         (-[WebFrame loadRequest:]):
2295         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2296
2297         * WebView/WebPDFView.mm:
2298         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2299
2300 2015-06-01  Anders Carlsson  <andersca@apple.com>
2301
2302         WAKScrollView.h cannot be imported standalone
2303         https://bugs.webkit.org/show_bug.cgi?id=145529
2304
2305         Reviewed by Dan Bernstein.
2306
2307         Don't migrate WAKScrollView.h, it's not used outside of WebKit.
2308
2309         * MigrateHeaders.make:
2310
2311 2015-05-29  Anders Carlsson  <andersca@apple.com>
2312
2313         Make the header replace rule more restrictive and get rid of a special case
2314         https://bugs.webkit.org/show_bug.cgi?id=145486
2315
2316         Reviewed by Ryosuke Niwa.
2317
2318         We used to not run the header migration script on WAKScrollView.h since we had a rule that would transform
2319         "<WebCore" to "<WebKitLegacy" to convert header #imports. However, WAKScrollView.h contains "WAKView <WebCoreFrameScrollView>"
2320         which would get transformed to "WAKView <WebKitLegacyFrameScrollView>".
2321
2322         Instead, check for the trailing slash as well and stop special-casing WAKScrollView.h.
2323
2324         * MigrateHeaders.make:
2325
2326 2015-05-29  Anders Carlsson  <andersca@apple.com>
2327
2328         Get rid of WAKViewPrivate.h
2329         https://bugs.webkit.org/show_bug.cgi?id=145482
2330         rdar://problem/21162149
2331
2332         Reviewed by Dan Bernstein.
2333
2334         Remove WAKViewPrivate.h imports.
2335
2336         * DefaultDelegates/WebDefaultUIDelegate.m:
2337         * MigrateHeaders.make:
2338         * Misc/WebKitNSStringExtras.mm:
2339         * Misc/WebNSViewExtras.m:
2340         * WebCoreSupport/WebFrameLoaderClient.mm:
2341         * WebView/WebFrame.mm:
2342         * WebView/WebFrameView.mm:
2343         * WebView/WebHTMLView.mm:
2344
2345 2015-05-29  Anders Carlsson  <andersca@apple.com>
2346
2347         WebResourceLoadDelegatePrivate.h cannot be imported standalone (missing WebNSInteger type)
2348         https://bugs.webkit.org/show_bug.cgi?id=145476
2349         rdar://problem/21162400
2350
2351         Reviewed by Dan Bernstein.
2352
2353         Change WebNSInteger to NSInteger.
2354
2355         * WebView/WebResourceLoadDelegatePrivate.h:
2356
2357 2015-05-29  Anders Carlsson  <andersca@apple.com>
2358
2359         WebKit.framework installs or references Mac-only headers on iOS
2360         https://bugs.webkit.org/show_bug.cgi?id=145471
2361         rdar://problem/21161459
2362
2363         Reviewed by Dan Bernstein.
2364
2365         * History/WebURLsWithTitles.h:
2366         Add an #if !TARGET_OS_IPHONE guard around the entire header.
2367
2368         * MigrateHeaders.make:
2369         Don't migrate the NPAPI headers on iOS.
2370
2371 2015-05-28  Matt Rajca  <mrajca@apple.com>
2372
2373         Add ENABLE_MEDIA_SESSION feature flag (which is off by default).
2374         https://bugs.webkit.org/show_bug.cgi?id=145415
2375
2376         Reviewed by Eric Carlson.
2377
2378         * Configurations/FeatureDefines.xcconfig:
2379
2380 2015-05-28  Jon Lee  <jonlee@apple.com>
2381
2382         Build fix after r184946.
2383
2384         * WebView/WebPreferences.mm:
2385         (-[WebPreferences allowsAirPlayForMediaPlayback]):
2386         (-[WebPreferences setAllowsAirPlayForMediaPlayback:]):
2387
2388 2015-05-19  Jon Honeycutt  <jhoneycutt@apple.com>
2389
2390         [iOS] When viewing an MJPEG stream as the main resource, only the first
2391         frame paints
2392
2393         <https://bugs.webkit.org/show_bug.cgi?id=145185>
2394         <rdar://problem/20124694>
2395
2396         Reviewed by Darin Adler.
2397
2398         * WebCoreSupport/WebFrameLoaderClient.h:
2399
2400         * WebCoreSupport/WebFrameLoaderClient.mm:
2401         (WebFrameLoaderClient::didReplaceMultipartContent):
2402         Call the FrameView's didReplaceMultipartContent().
2403
2404 2015-05-22  Jon Lee  <jonlee@apple.com>
2405
2406         Fix macros for wireless playback
2407         https://bugs.webkit.org/show_bug.cgi?id=145239
2408         rdar://problem/21049541
2409
2410         Reviewed by Anders Carlsson.
2411
2412         Encompass the logic within ENABLE(WIRELESS_TARGET_PLAYBACK). Update property name.
2413
2414         * WebView/WebPreferenceKeysPrivate.h:
2415         * WebView/WebPreferences.h:
2416         * WebView/WebPreferences.mm:
2417         (+[WebPreferences initialize]): Wrap in ENABLE.
2418         (-[WebPreferences allowsAirPlayForMediaPlayback]): Ditto.
2419         (-[WebPreferences setAllowsAirPlayForMediaPlayback:]): Ditto.
2420         * WebView/WebView.mm:
2421         (-[WebView _preferencesChanged:]): Ditto.
2422
2423 2015-05-27  Dean Jackson  <dino@apple.com>
2424
2425         img.currentSrc problem in strict mode with old picturefill
2426         https://bugs.webkit.org/show_bug.cgi?id=144095
2427         <rdar://problem/21087013>
2428
2429         Reviewed by Simon Fraser.
2430
2431         Add a PICTURE_SIZES flag.
2432
2433         * Configurations/FeatureDefines.xcconfig:
2434
2435 2015-05-26  Dan Bernstein  <mitz@apple.com>
2436
2437         <rdar://problem/21104551> Update build settings
2438
2439         Reviewed by Anders Carlsson.
2440
2441         * Configurations/DebugRelease.xcconfig:
2442         * Configurations/FeatureDefines.xcconfig:
2443         * Configurations/Version.xcconfig:
2444
2445 2015-05-25  Dan Bernstein  <mitz@apple.com>
2446
2447         ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD are unnecessary no-ops
2448         https://bugs.webkit.org/show_bug.cgi?id=145372
2449
2450         Reviewed by Sam Weinig.
2451
2452         * Carbon/CarbonWindowAdapter.mm:
2453         (-[CarbonWindowAdapter finalize]): Removed use of ASSERT_MAIN_THREAD.
2454
2455         * Configurations/Base.xcconfig: Removed DISABLE_THREAD_CHECK from DEBUG_DEFINES.
2456
2457         * History/WebHistoryItem.mm:
2458         (-[WebHistoryItem URLString]): Removed use of ASSERT_MAIN_THREAD.
2459         (-[WebHistoryItem originalURLString]): Ditto.
2460         (-[WebHistoryItem title]): Ditto.
2461         (-[WebHistoryItem lastVisitedTimeInterval]): Ditto.
2462         (-[WebHistoryItem isEqual:]): Ditto.
2463         (-[WebHistoryItem description]): Ditto.
2464         (-[WebHistoryItem initFromDictionaryRepresentation:]): Ditto.
2465         (-[WebHistoryItem scrollPoint]): Ditto.
2466
2467         * Misc/WebElementDictionary.mm:
2468         (-[WebElementDictionary finalize]): Ditto.
2469
2470         * Misc/WebIconDatabase.mm:
2471         (-[WebIconDatabase iconForURL:withSize:cache:]): Ditto.
2472         (-[WebIconDatabase iconURLForURL:]): Ditto.
2473         (-[WebIconDatabase defaultIconWithSize:]): Ditto.
2474         (-[WebIconDatabase retainIconForURL:]): Ditto.
2475         (-[WebIconDatabase releaseIconForURL:]): Ditto.
2476         (+[WebIconDatabase delayDatabaseCleanup]): Ditto.
2477         (+[WebIconDatabase allowDatabaseCleanup]): Ditto.
2478         (-[WebIconDatabase removeAllIcons]): Ditto.
2479         (-[WebIconDatabase _iconForFileURL:withSize:]): Ditto.
2480         (webGetNSImage): Ditto.
2481
2482         * Misc/WebKitLogging.h: Removed definition of ASSERT_MAIN_THREAD.
2483
2484         * Plugins/WebBaseNetscapePluginView.mm:
2485         (-[WebBaseNetscapePluginView finalize]): Removed use of ASSERT_MAIN_THREAD.
2486
2487         * Plugins/WebBasePluginPackage.mm:
2488         (-[WebBasePluginPackage finalize]): Ditto.
2489
2490         * Plugins/WebNetscapePluginView.mm:
2491         (-[WebNetscapePluginView finalize]): Ditto.
2492
2493         * WebCoreSupport/WebEditorClient.mm:
2494         (-[WebUndoStep finalize]): Ditto.
2495
2496         * WebView/WebDataSource.mm:
2497         (-[WebDataSource finalize]): Ditto.
2498
2499         * WebView/WebHTMLView.mm:
2500         (-[WebHTMLViewPrivate finalize]): Ditto.
2501         (-[WebHTMLView finalize]): Ditto.
2502         (-[WebHTMLView drawRect:]): Ditto.
2503
2504         * WebView/WebViewData.mm:
2505         (-[WebViewPrivate finalize]): Ditto.
2506
2507 2015-05-23  Dan Bernstein  <mitz@apple.com>
2508
2509         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
2510         https://bugs.webkit.org/show_bug.cgi?id=145345
2511
2512         Reviewed by Sam Weinig.
2513
2514         * Configurations/WebKitLegacy.xcconfig: Also changed to use $(inherited).
2515
2516 2015-05-24  Jeremy Jones  <jeremyj@apple.com>
2517
2518         Register media MIME types as supported by HTML view in WebKit1.
2519         https://bugs.webkit.org/show_bug.cgi?id=145356
2520
2521         Reviewed by Eric Carlson.
2522
2523         WebDataSource and WebFrame view knew about suppotedImageMIMETypes and supportedNonImageMIMETypes,
2524         but not a third category supportedMediaMIMETypes. These are now included along-side
2525         supportedNonImageMIMETypes.
2526
2527         * WebView/WebDataSource.mm:
2528         (+[WebDataSource _repTypesAllowImageTypeOmission:]): use supportedMediaMIMETypes.
2529         * WebView/WebFrameView.mm:
2530         (+[WebFrameView _viewTypesAllowImageTypeOmission:]): use supportedMediaMIMETypes.
2531         * WebView/WebHTMLRepresentation.h: declare -supportedMediaMIMETypes
2532         * WebView/WebHTMLRepresentation.mm:
2533         (+[WebHTMLRepresentation supportedMIMETypes]): include supportedMediaMIMETypes
2534         (+[WebHTMLRepresentation supportedMediaMIMETypes]): added
2535         * WebView/WebHTMLView.mm:
2536         (+[WebHTMLView supportedMediaMIMETypes]): added
2537         * WebView/WebHTMLViewPrivate.h: declare -supportedMediaMIMETypes
2538
2539 2015-05-22  Jon Lee  <jonlee@apple.com>
2540
2541         Rename MediaPlaybackAllowsInline
2542         https://bugs.webkit.org/show_bug.cgi?id=145315
2543
2544         Reviewed by Eric Carlson.
2545
2546         Our API uses allowsInlineMediaPlayback. Our symbols should reflect the same.
2547
2548         * WebView/WebPreferenceKeysPrivate.h: Update the name of the key, but not its
2549         value, for backwards compatibility.
2550         * WebView/WebPreferences.mm:
2551         (+[WebPreferences initialize]): Update the symbol.
2552         (-[WebPreferences mediaPlaybackAllowsInline]): Ditto. This setting will not
2553         be renamed in a future patch.
2554         (-[WebPreferences setMediaPlaybackAllowsInline:]): Ditto.
2555         * WebView/WebView.mm:
2556         (-[WebView _preferencesChanged:]): Update the call to settings.
2557
2558 2015-05-22  Jon Lee  <jonlee@apple.com>
2559
2560         Rename MediaPlaybackAllowsAirPlay
2561         https://bugs.webkit.org/show_bug.cgi?id=145316
2562
2563         Reviewed by Eric Carlson.
2564
2565         In preparation for an API rename, update internal symbols from mediaPlaybackAllowsAirPlay
2566         to allowsAirPlayForMediaPlayback.
2567
2568         * WebView/WebPreferenceKeysPrivate.h: Update the name but keep its value, for backwards
2569         compatibility.
2570         * WebView/WebPreferences.mm:
2571         (+[WebPreferences initialize]): Update to reference the new key name.
2572         (-[WebPreferences mediaPlaybackAllowsAirPlay]): Ditto. This API will not change in a future
2573         patch.
2574         (-[WebPreferences setMediaPlaybackAllowsAirPlay:]): Ditto.
2575         * WebView/WebView.mm:
2576         (-[WebView _preferencesChanged:]): Update the call to settings.
2577
2578 2015-05-22  Jon Lee  <jonlee@apple.com>
2579
2580         Rename MediaPlaybackRequiresUserGesture
2581         https://bugs.webkit.org/show_bug.cgi?id=145314
2582
2583         Reviewed by Anders Carlsson.
2584
2585         In preparation for an API rename, update internal symbols from mediaPlaybackRequiresUserGesture
2586         to requiresUserGestureForMediaPlayback.
2587
2588         No changes are being made to the API in this patch.
2589
2590         * WebView/WebPreferenceKeysPrivate.h: Update the name of the key, but not its value, for backwards
2591         compatibility.
2592         * WebView/WebPreferences.mm:
2593         (+[WebPreferences initialize]): Update the symbol.
2594         (-[WebPreferences mediaPlaybackRequiresUserGesture]): Ditto. This setting will not be renamed
2595         in a future patch.
2596         (-[WebPreferences setMediaPlaybackRequiresUserGesture:]): Ditto.
2597         * WebView/WebView.mm:
2598         (-[WebView _preferencesChanged:]): Update the call to settings.
2599
2600 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2601
2602         Remove action menu support
2603         https://bugs.webkit.org/show_bug.cgi?id=145305
2604         <rdar://problem/21070771>
2605
2606         Reviewed by Anders Carlsson.
2607
2608         * Configurations/WebKitLegacy.xcconfig:
2609         * WebView/WebActionMenuController.h: Removed.
2610         * WebView/WebActionMenuController.mm: Removed.
2611         * WebView/WebHTMLView.mm:
2612         (-[WebHTMLView otherMouseDown:]):
2613         (-[WebHTMLView scrollWheel:scrollWheel:]): Deleted.
2614         (-[WebHTMLView mouseDown:mouseDown:]): Deleted.
2615         * WebView/WebUIDelegatePrivate.h:
2616         * WebView/WebView.mm:
2617         (-[WebView _commonInitializationWithFrameName:groupName:]): Deleted.
2618         (-[WebView _close]): Deleted.
2619         (-[WebView prepareForMenu:withEvent:]): Deleted.
2620         (-[WebView willOpenMenu:withEvent:]): Deleted.
2621         (-[WebView didCloseMenu:withEvent:]): Deleted.
2622         (-[WebView _actionMenuController]): Deleted.
2623         * WebView/WebViewData.h:
2624         * WebView/WebViewData.mm:
2625         (-[WebViewPrivate dealloc]): Deleted.
2626         * WebView/WebViewInternal.h:
2627         Remove everything, except some enums that clients still refer to.
2628
2629 2015-05-22  Brady Eidson  <beidson@apple.com>
2630
2631         Rework how the ResourceRequest user initiated property key is used.
2632         Followup to https://bugs.webkit.org/show_bug.cgi?id=145281
2633
2634         Reviewed by Dan Bernstein.
2635
2636         * WebCoreSupport/WebSystemInterface.mm:
2637         (WKResourceRequestIsUserInitiatedKey): Deleted.
2638         (InitWebCoreSystemInterface): Deleted.
2639
2640 2015-05-21  Brady Eidson  <beidson@apple.com>
2641
2642         Add an "initiated by user gesture" flag to ResourceRequest.
2643         https://bugs.webkit.org/show_bug.cgi?id=145281
2644
2645         Reviewed by Alex Christensen.
2646
2647         * WebCoreSupport/WebSystemInterface.mm:
2648         (WKResourceRequestIsUserInitiatedKey):
2649         (InitWebCoreSystemInterface):
2650
2651 2015-05-20  Anders Carlsson  <andersca@apple.com>
2652
2653         Fix build.
2654
2655         * WebView/WebViewInternal.h:
2656
2657 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2658
2659         Unreviewed build fix; LocalizedStrings.h is in WebCore.
2660
2661         * WebView/WebActionMenuController.mm:
2662
2663 2015-05-20  Jer Noble  <jer.noble@apple.com>
2664
2665         Unreviewed build fix; WebActionMenuController.mm should directly include LocalizedStrings.h
2666
2667         * WebView/WebActionMenuController.mm:
2668
2669 2015-05-19  Jer Noble  <jer.noble@apple.com>
2670
2671         Touching HTMLMediaElement.h or MediaPlayer.h causes a world rebuild.
2672         https://bugs.webkit.org/show_bug.cgi?id=145193
2673
2674         Reviewed by Eric Carlson.
2675
2676         Use HTMLMediaElementEnums instead of HTMLMediaElement.
2677
2678         * WebCoreSupport/WebChromeClient.h:
2679         * WebCoreSupport/WebChromeClient.mm:
2680         (WebChromeClient::enterVideoFullscreenForVideoElement): HTMLMediaElement -> HTMLMediaElementEnums.
2681         * WebView/WebView.mm:
2682         (-[WebView _enterVideoFullscreenForVideoElement:mode:]): Ditto.
2683         * WebView/WebViewInternal.h:
2684
2685 2015-05-19  Michael Saboff  <msaboff@apple.com>
2686
2687         REGRESSION(183787): JIT is enabled for all builds
2688         https://bugs.webkit.org/show_bug.cgi?id=145179
2689
2690         Reviewed by Geoffrey Garen.
2691
2692         Eliminated the setting of ENABLE_JIT, as wtf/Platform.h has appropriate logic to
2693         set it depending on OS and CPU type.
2694
2695         * Configurations/FeatureDefines.xcconfig:
2696
2697 2015-05-19  Brady Eidson  <beidson@apple.com>
2698
2699         X-Frame-Options headers not respected when loading from application cache.
2700         <rdar://problem/14877623> and https://bugs.webkit.org/show_bug.cgi?id=131800
2701
2702         Reviewed by Alexey Proskuryakov.
2703
2704         * WebView/WebFrame.mm:
2705         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2706
2707 2015-05-18  Skachkov Alexandr  <gskachkov@gmail.com>
2708
2709         [ES6] Arrow function syntax. Feature flag for arrow function
2710         https://bugs.webkit.org/show_bug.cgi?id=145108
2711
2712         Reviewed by Ryosuke Niwa.
2713
2714         Added feature flag ENABLE_ES6_ARROWFUNCTION_SYNTAX for arrow function
2715
2716         * Configurations/FeatureDefines.xcconfig:
2717
2718 2015-05-15  Jeremy Jones  <jeremyj@apple.com>
2719
2720         Limit alternate fullscreen with linked on or after.
2721         https://bugs.webkit.org/show_bug.cgi?id=144894
2722
2723         Reviewed by Dean Jackson.
2724
2725         * WebView/WebView.mm:
2726         (shouldAllowAlternateFullscreen): Added.
2727         (-[WebView _preferencesChanged:]):
2728
2729 2015-05-12  Simon Fraser  <simon.fraser@apple.com>
2730
2731         Turn antialiased font dilation off by default
2732         https://bugs.webkit.org/show_bug.cgi?id=144940
2733         rdar://problem/20923031
2734
2735         Reviewed by Sam Weinig.
2736
2737         Turn antialised font dilation off by default.
2738
2739         * WebView/WebPreferences.mm:
2740         (+[WebPreferences initialize]):
2741
2742 2015-05-11  Daniel Bates  <dabates@apple.com>
2743
2744         [iOS] Close all open databases in expiration handler of process assertion
2745         https://bugs.webkit.org/show_bug.cgi?id=144661
2746         <rdar://problem/20845052>
2747
2748         Reviewed by Darin Adler.
2749
2750         For Legacy WebKit, close all open databases when the process assertion expiration
2751         handler is called.
2752
2753         * Storage/WebDatabaseManager.mm:
2754         (+[WebDatabaseManager startBackgroundTask]): Call DatabaseTracker::tracker().closeAllDatabases()
2755         in the expiration handler to close all open databases. As a side effect of closing
2756         a database all in-progress database transactions are interrupted.
2757
2758 2015-05-10  Sungmann Cho  <sungmann.cho@navercorp.com>
2759
2760         Get rid of the public item accessors in BackForwardClient
2761         https://bugs.webkit.org/show_bug.cgi?id=144827
2762
2763         Reviewed by Darin Adler.
2764
2765         Remove backItem(), currentItem(), and forwardItem() from BackForwardClient.
2766         We can still use these functionalities through BackForwardController.
2767
2768         No new tests, no behavior change.
2769
2770         * WebView/WebView.mm:
2771         (-[WebView _loadBackForwardListFromOtherView:]):
2772
2773 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
2774
2775         Remove the PICTURE_SIZES build flag
2776         https://bugs.webkit.org/show_bug.cgi?id=144679
2777
2778         Reviewed by Benjamin Poulain.
2779
2780         Removed the PICTURE_SIZES build time flag.
2781
2782         * Configurations/FeatureDefines.xcconfig:
2783
2784 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
2785
2786         Remove convenience constructors for TextRun
2787         https://bugs.webkit.org/show_bug.cgi?id=144752
2788
2789         These convenience constructors are unnecessary. Moving the code that makes the StringView
2790         back to the call site will also help us make things more elegant in future refactoring.
2791
2792         Reviewed by Darin Adler.
2793
2794         No new tests because there is no behavior change.
2795
2796         * Misc/WebKitNSStringExtras.mm:
2797         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2798         (-[NSString _web_widthWithFont:]):
2799
2800 2015-05-08  Commit Queue  <commit-queue@webkit.org>
2801
2802         Unreviewed, rolling out r183996.
2803         https://bugs.webkit.org/show_bug.cgi?id=144806
2804
2805         ASan detected use-after free (Requested by ap on #webkit).
2806
2807         Reverted changeset:
2808
2809         "Remove convenience constructors for TextRun"
2810         https://bugs.webkit.org/show_bug.cgi?id=144752
2811         http://trac.webkit.org/changeset/183996
2812
2813 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
2814
2815         Remove convenience constructors for TextRun
2816         https://bugs.webkit.org/show_bug.cgi?id=144752
2817
2818         These convenience constructors are unnecessary. Moving the code that makes the StringView
2819         back to the call site will also help us make things more elegant in future refactoring.
2820
2821         Reviewed by Darin Adler.
2822
2823         No new tests because there is no behavior change.
2824
2825         * Misc/WebKitNSStringExtras.mm:
2826         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2827         (-[NSString _web_widthWithFont:]):
2828
2829 2015-05-07  Anders Carlsson  <andersca@apple.com>
2830
2831         Build fixes.
2832
2833         * Misc/WebNSPasteboardExtras.mm:
2834         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
2835         * WebView/WebHTMLView.mm:
2836         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2837         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2838         * WebView/WebPDFView.mm:
2839         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
2840         Pass empty arrays and dictionaries instead of nil.
2841
2842         * WebView/WebView.mm:
2843         (-[WebView _commonInitializationWithFrameName:groupName:]):
2844         Use the regular init method.
2845
2846 2015-05-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2847
2848         Fix iPhone 6 iOS simulator Build.
2849         following http://trac.webkit.org/changeset/183954.
2850
2851         Reviewed by Daniel Bates.
2852
2853         * WebView/WebHTMLView.mm:
2854         (-[WebHTMLView pressureChangeWithEvent:]):
2855
2856 2015-05-07  Timothy Horton  <timothy_horton@apple.com>
2857
2858         Occasional null deref in WebImmediateActionController
2859         https://bugs.webkit.org/show_bug.cgi?id=144772
2860         <rdar://problem/20811128>
2861
2862         Reviewed by Beth Dakin.
2863
2864         * WebView/WebImmediateActionController.mm:
2865         (-[WebImmediateActionController _defaultAnimationController]):
2866         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
2867         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
2868         Null-check TextIndicators before dereferencing.
2869
2870 2015-05-07  Beth Dakin  <bdakin@apple.com>
2871
2872         New force-related DOM events should fire in WK1 views
2873         https://bugs.webkit.org/show_bug.cgi?id=144663
2874         -and corresponding-
2875         rdar://problem/20281886
2876
2877         Reviewed by Sam Weinig.
2878
2879         Pass the lastPressureEvent to WebCore.
2880         * WebView/WebHTMLView.mm:
2881         (-[WebHTMLView _updateMouseoverWithEvent:]):
2882         (-[WebHTMLView rightMouseUp:]):
2883         (-[WebHTMLView menuForEvent:]):
2884         (-[WebHTMLView acceptsFirstMouse:]):
2885         (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
2886         (-[WebHTMLView mouseDown:mouseDown:]):
2887         (-[WebHTMLView mouseDragged:]):
2888         (-[WebHTMLView mouseUp:mouseUp:]):
2889
2890         New NSRespnder method for pressure changes.
2891         (-[WebHTMLView pressureChangeWithEvent:]):
2892
2893         New BOOL _contentPreventsDefault tracks whether the HitTestResult prevented the
2894         default action. Get rid of willHandleMouseDown; now that the gesture recognizer
2895         sets delaysPrimaryMouseButtonEvents to NO, we don’t need this.
2896         * WebView/WebImmediateActionController.h:
2897         * WebView/WebImmediateActionController.mm:
2898         (-[WebImmediateActionController _clearImmediateActionState]):
2899
2900         Set all of the immediateActionStages on EventHandler. This is critical to keep
2901         link navigation happening at the right time now that
2902         delaysPrimaryMouseButtonEvents is set to NO.
2903         (-[WebImmediateActionController performHitTestAtPoint:]):
2904         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
2905         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2906         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2907
2908         Use a dummy animation controller if the content prevents default.
2909         (-[WebImmediateActionController _defaultAnimationController]):
2910         (-[WebImmediateActionController _updateImmediateActionItem]):
2911         (-[WebImmediateActionController webView:willHandleMouseDown:]): Deleted.
2912
2913         Set delaysPrimaryMouseButtonEvents to NO so that we get existing mouse events when
2914         we expect to.
2915         * WebView/WebView.mm:
2916         (-[WebView _commonInitializationWithFrameName:groupName:]):
2917
2918         Cache the most recent pressure event so that we can send it to WebCore for all of
2919         the mouse events.
2920         (-[WebView _pressureEvent]):
2921         (-[WebView _setPressureEvent:]):
2922         * WebView/WebViewData.h:
2923         * WebView/WebViewData.mm:
2924         (-[WebViewPrivate dealloc]):
2925         * WebView/WebViewInternal.h:
2926
2927 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
2928
2929         Revert "Introducing the Platform Abstraction Layer (PAL)"
2930         https://bugs.webkit.org/show_bug.cgi?id=144751
2931
2932         Unreviewed.
2933
2934         PAL should be a new target inside WebCore, rather than a top-level folder.
2935
2936         * Configurations/FeatureDefines.xcconfig: Updated
2937
2938 2015-05-07  Dan Bernstein  <mitz@apple.com>
2939
2940         <rdar://problem/19317140> [Xcode] Remove usage of AspenFamily.xcconfig in Source/
2941         https://bugs.webkit.org/show_bug.cgi?id=144727
2942
2943         Reviewed by Darin Adler.
2944
2945         * Configurations/Base.xcconfig: Don’t include AspenFamily.xcconfig.
2946         * Configurations/WebKitLegacy.xcconfig: Define INSTALL_PATH in terms of
2947         INSTALL_PATH_PREFIX and INSTALL_PATH_ACTUAL, and define INSTALL_PATH_PREFIX for the iOS 8.x
2948         Simulator.
2949
2950 2015-04-02  Myles C. Maxfield  <mmaxfield@apple.com>
2951
2952         Introducing the Platform Abstraction Layer (PAL)
2953         https://bugs.webkit.org/show_bug.cgi?id=143358
2954
2955         Reviewed by Simon Fraser.
2956
2957         * Configurations/FeatureDefines.xcconfig: Updated
2958
2959 2015-05-06  Antti Koivisto  <antti@apple.com>
2960
2961         REGRESSION (r183467): Unable to start downloads in private browsing mode
2962         https://bugs.webkit.org/show_bug.cgi?id=144533
2963
2964         Reviewed by Darin Adler.
2965
2966         * WebCoreSupport/WebFrameLoaderClient.mm:
2967         (WebFrameLoaderClient::dispatchWillSendRequest):
2968
2969             Use updateFromDelegatePreservingOldProperties (like WK2) instead of doing the same thing manually.
2970
2971 2015-05-06  Ryosuke Niwa  <rniwa@webkit.org>
2972
2973         Toggling underline on font panel removes strike through
2974         https://bugs.webkit.org/show_bug.cgi?id=144670
2975         <rdar://problem/3790443>
2976
2977         Reviewed by Darin Adler.
2978
2979         Use setStrikeThroughChange and setUnderlineChange added in r183770 to toggle underline and strike through.
2980
2981         * WebView/WebHTMLView.mm:
2982         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
2983         (-[WebHTMLView _styleForAttributeChange:]):
2984         (-[WebHTMLView changeAttributes:]):
2985
2986 2015-05-04  Ryosuke Niwa  <rniwa@webkit.org>
2987
2988         Toggling underline or strike through affects each other
2989         https://bugs.webkit.org/show_bug.cgi?id=27818
2990
2991         Reviewed by Darin Adler.
2992
2993         * WebView/WebFrame.mm:
2994         (-[WebFrame _setTypingStyle:withUndoAction:]):
2995
2996 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
2997
2998         USE(...) macro should expect unprefixed variables
2999         https://bugs.webkit.org/show_bug.cgi?id=144454
3000
3001         Reviewed by Daniel Bates.
3002
3003         * Misc/WebDownload.h: Replace all occurrences WTF_USE with USE.
3004
3005 2015-05-01  Brady Eidson  <beidson@apple.com>
3006
3007         Add API to disable meta refreshes.
3008         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
3009
3010         Reviewed by Alexey Proskuryakov.
3011
3012         Add a preference to enable/disable meta refreshes, enabled by default.
3013
3014         * WebView/WebPreferenceKeysPrivate.h:
3015         * WebView/WebPreferences.mm:
3016         (+[WebPreferences initialize]):
3017         (-[WebPreferences setMetaRefreshEnabled:]):
3018         (-[WebPreferences metaRefreshEnabled]):
3019         * WebView/WebPreferencesPrivate.h:
3020         * WebView/WebView.mm:
3021         (-[WebView _preferencesChanged:]):
3022
3023 2015-04-30  Jon Davis  <jond@apple.com>
3024
3025         Web Inspector: console should show an icon for console.info() messages
3026         https://bugs.webkit.org/show_bug.cgi?id=18530
3027
3028         Reviewed by Timothy Hatcher.
3029
3030         * WebCoreSupport/WebChromeClient.mm:
3031         (stringForMessageLevel):
3032         * WebView/WebUIDelegatePrivate.h:
3033
3034 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
3035
3036         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
3037         https://bugs.webkit.org/show_bug.cgi?id=132159
3038
3039         Reviewed by Darin Adler.
3040
3041         Add SPI to set the font whitelist.
3042
3043         * WebView/WebView.mm:
3044         (+[WebView _setFontWhitelist:]):
3045         * WebView/WebViewPrivate.h:
3046
3047 2015-04-28  Timothy Horton  <timothy_horton@apple.com>
3048
3049         [TextIndicator] Yellow highlight takes too long to fade out on scroll
3050         https://bugs.webkit.org/show_bug.cgi?id=144358
3051         <rdar://problem/19451011>
3052
3053         Reviewed by Beth Dakin.
3054
3055         * WebView/WebActionMenuController.mm:
3056         (-[WebActionMenuController _showTextIndicator]):
3057         * WebView/WebHTMLView.mm:
3058         (-[WebHTMLView quickLookWithEvent:]):
3059         * WebView/WebImmediateActionController.mm:
3060         (-[WebImmediateActionController _defaultAnimationController]):
3061         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
3062         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
3063         Pull _clearTextIndicatorWithAnimation out, make it avoid using a dismissal animation
3064         if we're called from didHandleScrollWheel.
3065
3066         * WebView/WebView.mm:
3067         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3068         (-[WebView _setTextIndicator:]):
3069         (-[WebView _setTextIndicator:withLifetime:]):
3070         (-[WebView _clearTextIndicator]):
3071         (-[WebView _showDictionaryLookupPopup:]):
3072         (-[WebView _dictionaryLookupPopoverWillClose:]):
3073         (-[WebView _setTextIndicator:fadeOut:]): Deleted.
3074         * WebView/WebViewInternal.h:
3075         Make _setTextIndicator take a reference.
3076         Add a variant of _setTextIndicator that takes a Lifetime.
3077         Make _clearTextIndicatorWithAnimation take a DismissalAnimation.
3078
3079 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3080
3081         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
3082         https://bugs.webkit.org/show_bug.cgi?id=144304
3083
3084         Reviewed by Geoffrey Garen.
3085
3086         Define ENABLE_JIT, enabled by default, instead of ENABLE_LLINT_C_LOOP, disabled by default.
3087
3088         * Configurations/FeatureDefines.xcconfig:
3089
3090 2015-04-28  Commit Queue  <commit-queue@webkit.org>
3091
3092         Unreviewed, rolling out r183514.
3093         https://bugs.webkit.org/show_bug.cgi?id=144359
3094
3095         It broke cloop test bots (Requested by mcatanzaro on #webkit).
3096
3097         Reverted changeset:
3098
3099         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
3100         https://bugs.webkit.org/show_bug.cgi?id=144304
3101         http://trac.webkit.org/changeset/183514
3102
3103 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3104
3105         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
3106         https://bugs.webkit.org/show_bug.cgi?id=144304
3107
3108         Reviewed by Geoffrey Garen.
3109
3110         Define ENABLE_JIT, enabled by default, instead of ENABLE_LLINT_C_LOOP, disabled by default.
3111
3112         * Configurations/FeatureDefines.xcconfig:
3113
3114 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
3115
3116         Fix common typo "targetting" => "targeting"
3117         https://bugs.webkit.org/show_bug.cgi?id=144349
3118
3119         Reviewed by Daniel Bates.
3120
3121         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3122         (WebKit::NetscapePluginInstanceProxy::loadRequest):
3123         * Plugins/WebNetscapePluginView.mm:
3124         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3125         * WebView/WebPolicyDelegate.h:
3126
3127 2015-04-28  Brady Eidson  <beidson@apple.com>
3128
3129         Consolidate most "frame load" arguments into FrameLoadRequest.
3130         https://bugs.webkit.org/show_bug.cgi?id=144276
3131
3132         Reviewed by Alexey Proskuryakov.
3133
3134         * WebView/WebPDFView.mm:
3135         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3136
3137 2015-04-27  Dan Bernstein  <mitz@apple.com>
3138
3139         <rdar://problem/20721931> REGRESSION (r178753): All legacy framework headers are missing availability annotations
3140         https://bugs.webkit.org/show_bug.cgi?id=144311
3141
3142         Reviewed by Adele Peterson.
3143
3144         * postprocess-headers.sh: Changed “macsox” to “macosx”.
3145
3146 2015-04-27  Brady Eidson  <beidson@apple.com>
3147
3148         Make 'enum NavigationType' be an enum class
3149         https://bugs.webkit.org/show_bug.cgi?id=144270
3150
3151         Reviewed by Alex Christensen.
3152
3153         * WebCoreSupport/WebFrameLoaderClient.mm:
3154         (WebFrameLoaderClient::actionDictionary):
3155
3156 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
3157
3158         REGRESSION(r182879): Images and video can no longer be downloaded
3159         https://bugs.webkit.org/show_bug.cgi?id=144267
3160         <rdar://problem/20702844>
3161
3162         Reviewed by Simon Fraser.
3163
3164         * WebView/WebActionMenuController.mm:
3165         (-[WebActionMenuController _createActionMenuItemForTag:]): Check for
3166         "!WebCore::protocolIs(..., "file")" for image and media downloads.
3167
3168 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3169
3170         [ES6] Implement ES6 template literals
3171         https://bugs.webkit.org/show_bug.cgi?id=142691
3172
3173         Reviewed by Darin Adler.
3174
3175         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
3176
3177         * Configurations/FeatureDefines.xcconfig:
3178
3179 2015-04-26  Doug Russell  <d_russell@apple.com>
3180
3181         AX: richer text change notifications (142719)
3182         https://bugs.webkit.org/show_bug.cgi?id=142719
3183
3184         Reviewed by Darin Adler.
3185
3186         Richer accessibility value change notifications. Introduce AXTextEditType,
3187         postTextStateChangeNotification and postTextReplacementNotification to give assistive
3188         tech apps more reliable context for responding to changes in web content. Also implement
3189         a mechanism to post value changes in password form fields in coalesced ticks to thwart
3190         analyzing the cadence of changes.
3191
3192         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
3193         and an overload of postTextReplacementNotification to give assistive tech apps more
3194         reliable context for responding to changes in web content selection. Also block posting
3195         selection changes on password fields.
3196
3197         * WebCoreSupport/WebEditorClient.mm:
3198         (undoNameForEditAction):
3199
3200 2015-04-24  Timothy Hatcher  <timothy@apple.com>
3201
3202         Web Inspector: Remove native window dock controls
3203         https://bugs.webkit.org/show_bug.cgi?id=144184
3204
3205         Reviewed by Joseph Pecoraro.
3206
3207         * Resources/Dock.pdf: Removed.
3208         * Resources/DockLegacy.pdf: Removed.
3209         * WebCoreSupport/WebInspectorClient.mm:
3210         (-[WebInspectorWindowController window]):
3211         (-[WebInspectorWindowController setDockingUnavailable:]):
3212
3213 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
3214
3215         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
3216         https://bugs.webkit.org/show_bug.cgi?id=144182
3217
3218         Reviewed by Simon Fraser.
3219
3220         * Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
3221
3222 2015-04-24  Commit Queue  <commit-queue@webkit.org>
3223
3224         Unreviewed, rolling out r183266.
3225         https://bugs.webkit.org/show_bug.cgi?id=144164
3226
3227         Broke 32-bit build and a test. (Requested by ap on #webkit).
3228
3229         Reverted changeset:
3230
3231         "AX: richer text change notifications (142719)"
3232         https://bugs.webkit.org/show_bug.cgi?id=142719
3233         http://trac.webkit.org/changeset/183266
3234
3235 2015-04-24  Myles C. Maxfield  <mmaxfield@apple.com>
3236
3237         [Cocoa] Start cleaning up FontPlatformData
3238         https://bugs.webkit.org/show_bug.cgi?id=144133
3239
3240         Reviewed by Enrica Casucci.
3241
3242         Receive casts which have been hoisted from the deleted FontPlatformData constructor.
3243
3244         * Misc/WebKitNSStringExtras.mm:
3245         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Receive cast which has
3246         been hoisted from the deleted FontPlatformData constructor.
3247         (-[NSString _web_widthWithFont:]): Ditto.
3248         * Misc/WebStringTruncator.mm:
3249         (fontFromNSFont): Ditto.
3250
3251 2015-04-24  Doug Russell  <d_russell@apple.com>
3252
3253         AX: richer text change notifications (142719)
3254         https://bugs.webkit.org/show_bug.cgi?id=142719
3255
3256         Reviewed by Darin Adler.
3257
3258         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
3259
3260         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
3261
3262         * WebCoreSupport/WebEditorClient.mm:
3263         (undoNameForEditAction):
3264
3265 2015-04-23  Jer Noble  <jer.noble@apple.com>
3266
3267         [Mac] Disable QTKit by default on future OS X.
3268         https://bugs.webkit.org/show_bug.cgi?id=144082
3269
3270         Reviewed by Darin Adler.
3271
3272         Default WebKitQTKitEnabledPreferenceKey to NO.
3273
3274         * WebView/WebPreferences.mm:
3275         (+[WebPreferences initialize]):
3276
3277 2015-04-23  Andreas Kling  <akling@apple.com>
3278
3279         There should only be one way to get the system memory size.
3280         <https://webkit.org/b/144081>
3281
3282         Reviewed by Antti Koivisto.
3283
3284         * Misc/WebKitSystemBits.h:
3285         * Misc/WebKitSystemBits.m:
3286         (WebMemorySize): Deleted.
3287         * WebView/WebView.mm:
3288         (+[WebView _setCacheModel:]):
3289         (roundUpToPowerOf2): Deleted.
3290
3291 2015-04-22  Darin Adler  <darin@apple.com>
3292
3293         Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2
3294         https://bugs.webkit.org/show_bug.cgi?id=143943
3295
3296         Reviewed by Anders Carlsson.
3297
3298         * Plugins/Hosted/ProxyInstance.h: Removed unneeded include.
3299         * Plugins/WebBaseNetscapePluginView.h: Ditto.
3300
3301         * Plugins/WebNetscapePluginEventHandler.h: Use unique_ptr instead of
3302         PassOwnPtr for the create function. Also tweaked formatting and removed
3303         unneeded forward declaration of CGRect.
3304         * Plugins/WebNetscapePluginEventHandler.mm:
3305         (WebNetscapePluginEventHandler::create): Changed to use unique_ptr and
3306         make_unique.
3307
3308         * Plugins/WebNetscapePluginView.h: Use unique_ptr instead of OwnPtr for
3309         the _eventHandler field.
3310         * Plugins/WebNetscapePluginView.mm:
3311         (-[WebNetscapePluginView destroyPlugin]): Changed code to work with unique_ptr.
3312
3313         * WebCoreSupport/WebUserMediaClient.mm: Removed unneeded include.
3314
3315         * WebView/WebDeviceOrientationProviderMock.mm: Changed to use make_unique.
3316         * WebView/WebDeviceOrientationProviderMockInternal.h: Changed to use unique_ptr.
3317
3318         * WebView/WebFrame.mm:
3319         (vectorForDictationPhrasesArray): Changed to return Vector<Vector<String>> and
3320         not a PassOwnPtr. Also rewrote to be much simpler, although there is still a
3321         pre-existing problem here where this could put empty vectors into the result,
3322         and I'm pretty sure the client never expects any of the Vector<String> to be empty.
3323         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
3324         Rewrote logic to involve WebCore types a bit less; old code was round tripping
3325         things through WebCore::URL for no obvious reason.
3326
3327         * WebView/WebFrameInternal.h: Changed vectorForDictationPhrasesArray to return
3328         a Vector<Vector<String>> and not a PassOwnPtr.
3329
3330         * WebView/WebFullScreenController.h: Removed unneeded include.
3331
3332         * WebView/WebViewData.h: Changed m_alternativeTextUIController to be a
3333         m_alternativeTextUIController.
3334         * WebView/WebViewData.mm:
3335         (-[WebViewPrivate init]): Use make_unique to initialize m_alternativeTextUIController.
3336
3337 2015-04-22  Brent Fulgham  <bfulgham@apple.com>
3338
3339         VisibleSelection should only accept Range by reference
3340         https://bugs.webkit.org/show_bug.cgi?id=144047
3341
3342         Reviewed by Tim Horton.
3343
3344         Update all uses of VisibleSelection to pass a Range reference instead
3345         of a Range pointer.
3346
3347         * WebCoreSupport/WebContextMenuClient.mm:
3348         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3349         * WebView/WebFrame.mm:
3350         (-[WebFrame _selectNSRange:]):
3351
3352 2015-04-22  Eric Carlson  <eric.carlson@apple.com>
3353
3354         [Mac] Device picker menu is positioned incorrectly in WK1
3355         https://bugs.webkit.org/show_bug.cgi?id=144049
3356         <rdar://problem/20493101>
3357
3358         Reviewed by Dean Jackson.
3359
3360         * WebView/WebView.mm:
3361         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]): Mouse location is already in
3362             window coordinates so don't call convertRect:toView:nil.
3363
3364 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
3365
3366         Extend action menus to support PDF
3367         https://bugs.webkit.org/show_bug.cgi?id=143895
3368         <rdar://problem/19003333>
3369
3370         Reviewed by Tim Horton.
3371
3372         Prevent a crash when someone attempts to invoke an action menu on a PDF hosted
3373         in a WK1 view.
3374
3375         * WebView/WebActionMenuController.mm:
3376         (-[WebActionMenuController performHitTestAtPoint:]): Handle WebPDFView as well as
3377         the WebHTMLView case.
3378         * WebView/WebDocument.h:
3379         * WebView/WebHTMLView.h:
3380         * WebView/WebHTMLView.mm:
3381         (-[WebHTMLView _frame]):
3382         * WebView/WebHTMLViewInternal.h:
3383         * WebView/WebPDFView.h:
3384         * WebView/WebPDFView.mm:
3385         (-[WebPDFView _frame]): Added.
3386
3387 2015-04-22  Eric Carlson  <eric.carlson@apple.com>
3388
3389         Unreviewed post-review clean up after r183096.
3390
3391         * WebView/WebMediaPlaybackTargetPicker.h:
3392
3393 2015-04-21  Eric Carlson  <eric.carlson@apple.com>
3394
3395         [Mac] Use one playback target for all web processes
3396         https://bugs.webkit.org/show_bug.cgi?id=144009
3397
3398         Reviewed by Tim Horton.
3399
3400         Update to use WebMediaSessionManager for playback target management.
3401
3402         * WebCoreSupport/WebChromeClient.h:
3403         * WebCoreSupport/WebChromeClient.mm:
3404         (WebChromeClient::addPlaybackTargetPickerClient):
3405         (WebChromeClient::removePlaybackTargetPickerClient):
3406         (WebChromeClient::showPlaybackTargetPicker):
3407         (WebChromeClient::playbackTargetPickerClientStateDidChange):
3408         (WebChromeClient::startingMonitoringPlaybackTargets): Deleted.
3409         (WebChromeClient::stopMonitoringPlaybackTargets): Deleted.
3410         * WebView/WebMediaPlaybackTargetPicker.h:
3411         * WebView/WebMediaPlaybackTargetPicker.mm:
3412         (WebMediaPlaybackTargetPicker::addPlaybackTargetPickerClient):
3413         (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
3414         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3415         (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
3416         (WebMediaPlaybackTargetPicker::setPlaybackTarget):
3417         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange):
3418         (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget):
3419         (WebMediaPlaybackTargetPicker::invalidate):
3420         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): Deleted.
3421         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): Deleted.
3422         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Deleted.
3423         (WebMediaPlaybackTargetPicker::targetPicker): Deleted.
3424         * WebView/WebView.mm:
3425         (-[WebView _addPlaybackTargetPickerClient:]):
3426         (-[WebView _removePlaybackTargetPickerClient:]):
3427         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
3428         (-[WebView _playbackTargetPickerClientStateDidChange:state:]):
3429         (-[WebView _showPlaybackTargetPicker:hasVideo:]): Deleted.
3430         (-[WebView _startingMonitoringPlaybackTargets]): Deleted.
3431         (-[WebView _stopMonitoringPlaybackTargets]): Deleted.
3432         * WebView/WebViewInternal.h:
3433
3434 2015-04-20  Alexey Proskuryakov  <ap@apple.com>
3435
3436         Disable mixed content blocking for existing WebKit1 clients
3437         https://bugs.webkit.org/show_bug.cgi?id=143955
3438         rdar://problem/20177186
3439
3440         Reviewed by Oliver Hunt.
3441
3442         * Misc/WebKitVersionChecks.h:
3443         * WebView/WebView.mm:
3444         (shouldAllowInsecureContent):
3445         (-[WebView _preferencesChanged:]):
3446
3447 2015-04-20  Tim Horton  <timothy_horton@apple.com>
3448
3449         Implement immediate action support for tel: and mailto: URLs
3450         https://bugs.webkit.org/show_bug.cgi?id=143916
3451         <rdar://problem/19721711>
3452
3453         Reviewed by Darin Adler.
3454
3455         * WebView/WebImmediateActionController.mm:
3456         (-[WebImmediateActionController _defaultAnimationController]):
3457         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
3458         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
3459         (-[WebImmediateActionController _menuItemForDataDetectedText]): Deleted.
3460         * WebView/WebUIDelegatePrivate.h:
3461         Add _animationControllerForDataDetectedLink and use it when
3462         building immediate actions for tel: and mailto: links.
3463
3464 2015-04-17  Daniel Bates  <dabates@apple.com>
3465
3466         REGRESSION: SVG does not support link dragging
3467         https://bugs.webkit.org/show_bug.cgi?id=141597
3468
3469         Reviewed by Darin Adler.
3470
3471         Write -[WebElementDictionary _isLiveLink] in terms of WebCore::isDraggableLink().
3472
3473         * Misc/WebElementDictionary.mm:
3474         (-[WebElementDictionary _isLiveLink]):
3475
3476 2015-04-16  Sam Weinig  <sam@webkit.org>
3477
3478         Expose JavaScriptMarkupEnabled preference for WebKit1
3479         <rdar://problem/19939450>
3480         https://bugs.webkit.org/show_bug.cgi?id=143855
3481
3482         Reviewed by Dan Bernstein.
3483
3484         * WebView/WebPreferenceKeysPrivate.h:
3485         Add new key, WebKitJavaScriptMarkupEnabledPreferenceKey
3486
3487         * WebView/WebPreferences.mm:
3488         (+[WebPreferences initialize]):
3489         Initialize WebKitJavaScriptMarkupEnabledPreferenceKey to YES.
3490
3491         (-[WebPreferences isJavaScriptMarkupEnabled]):
3492         (-[WebPreferences setJavaScriptMarkupEnabled:]):
3493         Implement getter/setter.
3494
3495         * WebView/WebPreferencesPrivate.h:
3496         Add new property, javaScriptMarkupEnabled.
3497
3498         * WebView/WebView.mm:
3499         (-[WebView _preferencesChanged:]):
3500         Map the new preference to WebCore's scriptMarkupEnabled setting.
3501
3502 2015-04-15  Brent Fulgham  <bfulgham@apple.com>
3503
3504         [Mac] Disable "Save to Downloads" option for local files
3505         https://bugs.webkit.org/show_bug.cgi?id=143794
3506
3507         Reviewed by Tim Horton.
3508
3509         Disable the Image and Media download options if the download
3510         target is a local file. We can only download web resources;
3511         anything else is actually a no-op.
3512
3513         * WebView/WebActionMenuController.mm:
3514         (-[WebActionMenuController _defaultMenuItemsForImage]):
3515         (-[WebActionMenuController _defaultMenuItemsForVideo]):
3516
3517 2015-04-15  Alex Christensen  <achristensen@webkit.org>
3518
3519         Progress towards CMake on Mac.
3520         https://bugs.webkit.org/show_bug.cgi?id=143785
3521
3522         Reviewed by Csaba Osztrogonác.
3523
3524         * WebView/WebPDFDocumentExtras.mm:
3525         * WebView/WebPDFView.mm:
3526
3527 2015-04-13  Jer Noble  <jer.noble@apple.com>
3528
3529         [Fullscreen] ChromeClient::exitVideoFullscreen() should take a pointer to a HTMLVideoElement.
3530         https://bugs.webkit.org/show_bug.cgi?id=143674
3531
3532         Reviewed by Darin Adler.
3533
3534         * WebCoreSupport/WebChromeClient.h:
3535         * WebCoreSupport/WebChromeClient.mm:
3536         (WebChromeClient::enterVideoFullscreenForVideoElement): Takes a reference.
3537         (WebChromeClient::exitVideoFullscreenForVideoElement): Renamed from exitVideoFullscreen().
3538         (WebChromeClient::exitVideoFullscreen): Deleted.
3539
3540 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
3541
3542         Re-enable custom dilation for antialiased fonts
3543         https://bugs.webkit.org/show_bug.cgi?id=143738
3544
3545         Reviewed by Tim Horton.
3546
3547         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
3548         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
3549         a private WebKit pref. This pref defaults to YES, enabling the feature by default
3550         in WK1 as we do for WK2.
3551
3552         * WebView/WebPreferenceKeysPrivate.h:
3553         * WebView/WebPreferences.mm:
3554         (+[WebPreferences initialize]):
3555         (-[WebPreferences setAntialiasedFontDilationEnabled:]):
3556         (-[WebPreferences antialiasedFontDilationEnabled]):
3557         * WebView/WebPreferencesPrivate.h:
3558         * WebView/WebView.mm:
3559         (-[WebView _preferencesChanged:]):
3560
3561 2015-04-13  Brady Eidson  <beidson@apple.com>
3562
3563         Share sheets from Share menus appear outside the browser window.
3564         <rdar://problem/20455592> and https://bugs.webkit.org/show_bug.cgi?id=143620
3565
3566         Reviewed by Darin Adler.
3567
3568         Refactor existing Sharing Service Picker code to also be used for the Share menu NSMenuItem.
3569
3570         * Misc/WebSharingServicePickerController.h:
3571         (WebSharingServicePickerClient::webView):
3572         * Misc/WebSharingServicePickerController.mm:
3573         (WebSharingServicePickerClient::WebSharingServicePickerClient):
3574         (WebSharingServicePickerClient::sharingServicePickerWillBeDestroyed):
3575         (WebSharingServicePickerClient::pageForSharingServicePicker):
3576         (WebSharingServicePickerClient::windowForSharingServicePicker):
3577         (WebSharingServicePickerClient::screenRectForCurrentSharingServicePickerItem):
3578         (WebSharingServicePickerClient::imageForCurrentSharingServicePickerItem):
3579         (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]):
3580         (-[WebSharingServicePickerController initWithSharingServicePicker:client:]):
3581         (-[WebSharingServicePickerController sharingService:didShareItems:]):
3582
3583         * WebCoreSupport/WebContextMenuClient.h:
3584         (WebContextMenuClient::webView): Deleted.
3585         * WebCoreSupport/WebContextMenuClient.mm:
3586         (WebContextMenuClient::WebContextMenuClient):
3587         (WebContextMenuClient::pageForSharingServicePicker): Deleted.
3588         (WebContextMenuClient::windowForSharingServicePicker): Deleted.
3589
3590         * WebCoreSupport/WebSelectionServiceController.h:
3591         * WebCoreSupport/WebSelectionServiceController.mm: