Wrap legacy WebRTC API in runtime flag
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-03-16  Youenn Fablet  <youenn@apple.com>
2
3         Wrap legacy WebRTC API in runtime flag
4         https://bugs.webkit.org/show_bug.cgi?id=169646
5
6         Reviewed by Alex Christensen.
7
8         * WebView/WebPreferenceKeysPrivate.h:
9         * WebView/WebPreferences.mm:
10         (+[WebPreferences initialize]):
11         (-[WebPreferences webRTCLegacyAPIEnabled]):
12         (-[WebPreferences setWebRTCLegacyAPIEnabled:]):
13         * WebView/WebPreferencesPrivate.h:
14         * WebView/WebView.mm:
15         (-[WebView _preferencesChanged:]):
16
17 2017-03-14  Megan Gardner  <megan_gardner@apple.com>
18
19         Correctly export WebItemProviderPasteboard
20         https://bugs.webkit.org/show_bug.cgi?id=169578
21
22         Reviewed by Tim Horton.
23
24         * MigrateHeaders.make:
25
26 2017-03-14  Wenson Hsieh  <wenson_hsieh@apple.com>
27
28         [WK2] Data interaction tests occasionally hit assertions in debug builds
29         https://bugs.webkit.org/show_bug.cgi?id=169002
30         <rdar://problem/30994806>
31
32         Reviewed by Tim Horton.
33
34         Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.
35
36         * WebView/WebHTMLView.mm:
37         (-[WebHTMLView _updateSelectionForInputManager]):
38         * WebView/WebView.mm:
39         (-[WebView updateTextTouchBar]):
40
41 2017-03-13  Anders Carlsson  <andersca@apple.com>
42
43         Fix build warnings.
44
45         * WebCoreSupport/WebInspectorClient.mm:
46         (WebInspectorFrontendClient::save):
47         (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
48
49 2017-03-11  Brady Eidson  <beidson@apple.com>
50
51         Cleanup "addCookie" and its sole user.
52         https://bugs.webkit.org/show_bug.cgi?id=169486
53
54         Reviewed by Brian Burg.
55
56         * WebCoreSupport/WebPlatformStrategies.h:
57         * WebCoreSupport/WebPlatformStrategies.mm:
58         (WebPlatformStrategies::addCookie): Deleted.
59
60 2017-03-10  Alex Christensen  <achristensen@webkit.org>
61
62         Fix watch and tv builds after r213294
63         https://bugs.webkit.org/show_bug.cgi?id=169508
64
65         Reviewed by Dan Bernstein.
66
67         * Configurations/FeatureDefines.xcconfig:
68
69 2017-03-10  Alex Christensen  <achristensen@webkit.org>
70
71         Fix CMake build.
72
73         * WebView/WebNotification.h:
74         Don't assume we have already included something that includes NSObject.h.
75
76 2017-03-09  Daniel Bates  <dabates@apple.com>
77
78         Guard Credential Management implementation behind a runtime enabled feature flag
79         https://bugs.webkit.org/show_bug.cgi?id=169364
80         <rdar://problem/30957425>
81
82         Reviewed by Brent Fulgham.
83
84         Add WebKit preference for Credential Management (disabled by default).
85
86         * WebView/WebPreferenceKeysPrivate.h:
87         * WebView/WebPreferences.mm:
88         (+[WebPreferences initialize]):
89         (-[WebPreferences credentialManagementEnabled]): Added.
90         (-[WebPreferences setCredentialManagementEnabled:]): Added.
91         * WebView/WebPreferencesPrivate.h:
92         * WebView/WebView.mm:
93         (-[WebView _preferencesChanged:]):
94
95 2017-03-09  Anders Carlsson  <andersca@apple.com>
96
97         Add delegate support to WebCore
98         https://bugs.webkit.org/show_bug.cgi?id=169427
99         Part of rdar://problem/28880714.
100
101         Reviewed by Geoffrey Garen.
102
103         * Configurations/FeatureDefines.xcconfig:
104         Add feature define.
105
106 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
107
108         Fix DataInteraction guards
109         https://bugs.webkit.org/show_bug.cgi?id=169404
110
111         Reviewed by Wenson Hsieh.
112
113         * WebCoreSupport/WebDragClient.mm:
114
115 2017-03-08  Wenson Hsieh  <wenson_hsieh@apple.com>
116
117         Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
118         https://bugs.webkit.org/show_bug.cgi?id=169392
119         <rdar://problem/30882974>
120
121         Reviewed by Tim Horton.
122
123         Add a stub implementation of WebDragClient::didConcludeEditDrag.
124
125         * WebCoreSupport/WebDragClient.h:
126
127 2017-03-08  Anders Carlsson  <andersca@apple.com>
128
129         Simplify the PaymentCoordinator interface
130         https://bugs.webkit.org/show_bug.cgi?id=169382
131         Part of rdar://problem/28880714.
132
133         Reviewed by Tim Horton.
134
135         Update for PaymentCoordinatorClient changes.
136
137         * WebCoreSupport/WebPaymentCoordinatorClient.h:
138         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
139         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
140         (WebPaymentCoordinatorClient::completeShippingContactSelection):
141         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
142         (WebPaymentCoordinatorClient::completePaymentSession):
143
144 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
145
146         Fix for dependency fix
147         https://bugs.webkit.org/show_bug.cgi?id=169369
148
149         Reviewed by Beth Dakin.
150
151         * WebView/WebViewPrivate.h:
152
153 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
154
155         Fix Project Dependency
156         https://bugs.webkit.org/show_bug.cgi?id=169340
157
158         Unreviewed Dependency Fix.
159
160         * WebView/WebViewPrivate.h:
161
162 2017-03-07  Alexey Proskuryakov  <ap@apple.com>
163
164         WebKitLegacy should re-export symbols from WebCore on watchos and tvos
165         https://bugs.webkit.org/show_bug.cgi?id=169341
166         <rdar://problem/30913788>
167
168         Reviewed by Dan Bernstein.
169
170         * MigrateHeaders.make:
171
172 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
173
174         Have fixedPositionCreatesStackingContext be on by default everywhere
175         https://bugs.webkit.org/show_bug.cgi?id=169334
176
177         Reviewed by Zalan Bujtas.
178
179         It makes no sense to have web-exposed CSS functionality be different based on setting,
180         and other browser are now aligned with having position:fixed create stacking context.
181
182         So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
183         always force stacking context for position:fixed.
184
185         * WebView/WebView.mm:
186         (-[WebView _preferencesChanged:]):
187
188 2017-03-06  Simon Fraser  <simon.fraser@apple.com>
189
190         Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
191         https://bugs.webkit.org/show_bug.cgi?id=169230
192
193         Reviewed by Tim Horton.
194
195         * WebView/WebView.mm:
196         (-[WebView _preferencesChanged:]):
197
198 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
199
200         Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
201         https://bugs.webkit.org/show_bug.cgi?id=169329
202
203         Reviewed by Tim Horton.
204
205         If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.
206
207         * WebView/WebPreferences.mm:
208         (+[WebPreferences initialize]):
209
210 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
211
212         Additional DataInteraction Support
213         https://bugs.webkit.org/show_bug.cgi?id=169316
214         <rdar://problem/30884234>
215
216         Reviewed by Wenson Hsieh.
217
218         Add stub implementations to WebView for methods that handle data interaction
219
220         * WebView/WebView.mm:
221         (-[WebView _enteredDataInteraction:client:global:operation:]):
222         (-[WebView _updatedDataInteraction:client:global:operation:]):
223         (-[WebView _exitedDataInteraction:client:global:operation:]):
224         (-[WebView _performDataInteraction:client:global:operation:]):
225         (-[WebView _endedDataInteraction:global:]):
226         * WebView/WebViewPrivate.h:
227
228 2017-03-07  Dean Jackson  <dino@apple.com>
229
230         Some platforms won't be able to create a GPUDevice
231         https://bugs.webkit.org/show_bug.cgi?id=169314
232         <rdar://problems/30907521>
233
234         Reviewed by Jon Lee.
235
236         Disable WEB_GPU on the iOS Simulator.
237
238         * Configurations/FeatureDefines.xcconfig:
239
240 2017-03-07  Maureen Daum  <mdaum@apple.com>
241
242         Correctly check for an empty database file.
243         <rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
244         https://bugs.webkit.org/show_bug.cgi?id=169256
245
246         Reviewed by Brady Eidson.
247
248         Check if the folder for an origin's WebSQL databases is empty after trying to delete
249         all of its files. Currently we check if the deletedDatabaseFileCount matches the number
250         of files that were in the folder. However, when we delete the actual database file in
251         DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
252         the database file, but deletedDatabaseFileCount only gets incremented once.
253
254         * Storage/WebDatabaseManager.mm:
255         (+[WebDatabaseManager removeEmptyDatabaseFiles]):
256         Delete the folder if it is empty.
257
258 2017-03-06  Michael Saboff  <msaboff@apple.com>
259
260         Unreviewed build fix to add
261         -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
262         for objective C++ files.
263
264         * Configurations/WebKitLegacy.xcconfig:
265
266 2017-03-06  Michael Saboff  <msaboff@apple.com>
267
268         Take advantage of fast permissions switching of JIT memory for devices that support it
269         https://bugs.webkit.org/show_bug.cgi?id=169155
270
271         Reviewed by Saam Barati.
272
273         Updated the Xcode config files to match what is in the JavaScriptCore ones.
274
275         * Configurations/FeatureDefines.xcconfig:
276
277 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
278
279         Expand font-weight and font-stretch to take any number
280         https://bugs.webkit.org/show_bug.cgi?id=168889
281
282         Reviewed by Simon Fraser.
283
284         Migrate off old enum types.
285
286         * WebCoreSupport/PopupMenuMac.mm:
287         (PopupMenuMac::populate):
288         * WebView/WebHTMLView.mm:
289         (fontNameForDescription):
290         * WebView/WebView.mm:
291         (-[WebView updateTextTouchBar]):
292
293 2017-03-03  Dean Jackson  <dino@apple.com>
294
295         Add WebGPU compile flag and experimental feature flag
296         https://bugs.webkit.org/show_bug.cgi?id=169161
297         <rdar://problem/30846689>
298
299         Reviewed by Tim Horton.
300
301         Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
302         and an InternalSetting.
303
304         * Configurations/FeatureDefines.xcconfig:
305         * WebView/WebPreferenceKeysPrivate.h:
306         * WebView/WebPreferences.mm:
307         (+[WebPreferences initialize]):
308         (-[WebPreferences webGPUEnabled]):
309         (-[WebPreferences setWebGPUEnabled:]):
310         * WebView/WebPreferencesPrivate.h:
311         * WebView/WebView.mm:
312         (-[WebView _preferencesChanged:]):
313
314 2017-03-03  Alexey Proskuryakov  <ap@apple.com>
315
316         Build fix
317         rdar://problem/30825660
318
319         Suggested by Dan Bernstein.
320
321         * Configurations/WebKitLegacy.xcconfig:
322
323 2017-03-02  Sam Weinig  <sam@webkit.org>
324
325         Rename htmlediting.h/cpp to Editing.h/cpp
326         https://bugs.webkit.org/show_bug.cgi?id=169103
327
328         Reviewed by Alex Christensen.
329
330         * DOM/DOMUIKitExtensions.mm:
331         * WebView/WebFrame.mm:
332         * WebView/WebView.mm:
333
334 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
335
336         Fix 32-bit
337         https://bugs.webkit.org/show_bug.cgi?id=169114
338
339         Reviewed by Alex Christensen.
340
341         * WebView/WebView.mm:
342
343 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
344
345         More guard fixing
346         https://bugs.webkit.org/show_bug.cgi?id=169112
347
348         Reviewed by Alex Christensen.
349
350         Fixed an internal build.
351
352         * WebView/WebView.mm:
353         * WebView/WebViewPrivate.h:
354
355 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
356
357         Data Interaction build fixes
358         https://bugs.webkit.org/show_bug.cgi?id=169096
359
360         Reviewed by Tim Horton.
361
362         Guards weren't all correct, also missed a selector name change.
363
364         * WebView/WebView.mm:
365         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
366         * WebView/WebViewData.h:
367         * WebView/WebViewData.mm:
368         (-[WebViewPrivate dealloc]):
369
370 2017-03-02  Alex Christensen  <achristensen@webkit.org>
371
372         Continue enabling WebRTC
373         https://bugs.webkit.org/show_bug.cgi?id=169056
374
375         Reviewed by Jon Lee.
376
377         * Configurations/FeatureDefines.xcconfig:
378
379 2017-03-01  Megan Gardner  <megan_gardner@apple.com>
380
381         Data interaction support for WK1
382         https://bugs.webkit.org/show_bug.cgi?id=169062
383
384         Reviewed by Wenson Hsieh.
385
386         Support for data interaction in WebKit1
387
388         * WebCoreSupport/WebDragClient.mm:
389         * WebView/WebView.mm:
390         (-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
391         (-[WebUITextIndicatorData initWithImage:scale:]):
392         (-[WebUITextIndicatorData dealloc]):
393         (-[WebView _requestStartDataInteraction:globalPosition:]):
394         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
395         (-[WebView _getDataInteractionData]):
396         * WebView/WebViewData.h:
397         * WebView/WebViewData.mm:
398         (-[WebViewPrivate dealloc]):
399         * WebView/WebViewInternal.h:
400         * WebView/WebViewPrivate.h:
401
402 2017-03-02  Youenn Fablet  <youenn@apple.com>
403
404         [WebRTC] Activate ICE candidate privacy policy
405         https://bugs.webkit.org/show_bug.cgi?id=168975
406
407         Reviewed by Alex Christensen.
408
409         * WebView/WebPreferenceKeysPrivate.h:
410         * WebView/WebPreferences.mm:
411         (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
412         (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
413         (-[WebPreferences iceCandidateFilteringEnabled]):
414         (-[WebPreferences setIceCandidateFilteringEnabled:]):
415         * WebView/WebPreferencesPrivate.h:
416
417 2017-03-01  Alex Christensen  <achristensen@webkit.org>
418
419         Unreviewed, rolling out r213259.
420
421         Broke an internal build
422
423         Reverted changeset:
424
425         "Continue enabling WebRTC"
426         https://bugs.webkit.org/show_bug.cgi?id=169056
427         http://trac.webkit.org/changeset/213259
428
429 2017-03-01  Alex Christensen  <achristensen@webkit.org>
430
431         Continue enabling WebRTC
432         https://bugs.webkit.org/show_bug.cgi?id=169056
433
434         Reviewed by Jon Lee.
435
436         * Configurations/FeatureDefines.xcconfig:
437
438 2017-02-27  Alex Christensen  <achristensen@webkit.org>
439
440         Begin enabling WebRTC on 64-bit
441         https://bugs.webkit.org/show_bug.cgi?id=168915
442
443         Reviewed by Eric Carlson.
444
445         * Configurations/FeatureDefines.xcconfig:
446
447 2017-02-27  Aakash Jain  <aakash_jain@apple.com>
448
449         Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
450         https://bugs.webkit.org/show_bug.cgi?id=168919
451
452         Reviewed by Tim Horton.
453
454         * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
455         * migrate-headers.sh: Run the migrate-headers script for installapi phase.
456
457 2017-02-27  Alex Christensen  <achristensen@webkit.org>
458
459         [libwebrtc] Enable WebRTC in some Production Builds
460         https://bugs.webkit.org/show_bug.cgi?id=168858
461
462         * Configurations/FeatureDefines.xcconfig:
463
464 2017-02-26  Alexey Proskuryakov  <ap@apple.com>
465
466         Don't import RetainPtr in WebNotification.h
467         https://bugs.webkit.org/show_bug.cgi?id=168876
468
469         Reviewed by Dan Bernstein.
470
471         This is an Objective-C SPI header.
472
473         * WebView/WebNotification.h:
474         * WebView/WebNotification.mm:
475         (-[WebNotification initWithCoreNotification:notificationID:]):
476         (-[WebNotification dealloc]):
477
478 2017-02-26  Aakash Jain  <aakash_jain@apple.com>
479
480         Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
481         https://bugs.webkit.org/show_bug.cgi?id=168819
482
483         Reviewed by Dan Bernstein.
484
485         * Configurations/WebKitLegacy.xcconfig:
486
487 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
488
489         Export Objective-C symbols for variables in Webkit SPI
490         https://bugs.webkit.org/show_bug.cgi?id=168758
491
492         Reviewed by Alexey Proskuryakov.
493
494         * Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
495         * WebKit.exp: Added various Objective-C symbols.
496
497 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
498
499         Move instance members from WKQuadObject to implementation file
500         https://bugs.webkit.org/show_bug.cgi?id=168740
501
502         Reviewed by Tim Horton.
503
504         * DOM/DOM.mm: Moving instance member to implementation file.
505         * DOM/DOMExtensions.h: Ditto.
506
507 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
508
509         Move iOS specific symbols to WebKit.ios.exp
510         https://bugs.webkit.org/show_bug.cgi?id=168726
511
512         Reviewed by Alexey Proskuryakov.
513
514         * WebKit.exp:
515
516 2017-02-21  Youenn Fablet  <youenn@apple.com>
517
518         [WebRTC][Mac] Activate libwebrtc
519         https://bugs.webkit.org/show_bug.cgi?id=167293
520         <rdar://problem/30401864>
521
522         Reviewed by Alex Christensen.
523
524         * Configurations/FeatureDefines.xcconfig:
525
526 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
527
528         Export various NSString symbols from WebFramePrivate.h
529         https://bugs.webkit.org/show_bug.cgi?id=168702
530
531         Reviewed by Alexey Proskuryakov.
532
533         * WebKit.exp:
534
535 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
536
537         Export various NSString symbols from WebPreferencesPrivate.h
538         https://bugs.webkit.org/show_bug.cgi?id=168701
539
540         Reviewed by Alexey Proskuryakov.
541
542         * WebKit.exp:
543
544 2017-02-21  Joseph Pecoraro  <pecoraro@apple.com>
545
546         Add missing WebConsoleMessage string key
547         https://bugs.webkit.org/show_bug.cgi?id=168690
548
549         Reviewed by Alexey Proskuryakov.
550
551         * WebKit.exp:
552         * WebView/WebUIDelegatePrivate.h:
553         This key has an implementation but was not extern / exported like the others.
554
555 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
556
557         Export various NSString symbols from WebViewPrivate.h
558         https://bugs.webkit.org/show_bug.cgi?id=168689
559
560         Reviewed by Alexey Proskuryakov.
561
562         * WebKit.exp:
563
564 2017-02-21  Commit Queue  <commit-queue@webkit.org>
565
566         Unreviewed, rolling out r212768.
567         https://bugs.webkit.org/show_bug.cgi?id=168698
568
569         Rolling out since this would break other projects. (Requested
570         by aakashjain on #webkit).
571
572         Reverted changeset:
573
574         "[iOS] Remove old WebKit1 MemoryMeasure helper."
575         https://bugs.webkit.org/show_bug.cgi?id=168675
576         http://trac.webkit.org/changeset/212768
577
578 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
579
580         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
581         https://bugs.webkit.org/show_bug.cgi?id=168620
582         <rdar://problem/30617772>
583
584         Reviewed by Tim Horton.
585
586         * WebView/WebPreferenceKeysPrivate.h:
587         * WebView/WebPreferences.mm:
588         (+[WebPreferences initialize]):
589         (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
590         (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
591         * WebView/WebPreferencesPrivate.h:
592
593 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
594
595         Export various NSString symbols from WebUIDelegatePrivate.h
596         https://bugs.webkit.org/show_bug.cgi?id=168679
597
598         Reviewed by Joseph Pecoraro.
599
600         * WebKit.exp:
601
602 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
603
604         Export symbols for various classes present in webkit SPI
605         https://bugs.webkit.org/show_bug.cgi?id=168674
606
607         Reviewed by Dan Bernstein.
608
609         * WebKit.exp:
610
611 2017-02-21  Andreas Kling  <akling@apple.com>
612
613         [iOS] Remove old WebKit1 MemoryMeasure helper.
614         <https://webkit.org/b/168675>
615
616         Reviewed by Sam Weinig.
617
618         * Configurations/WebKitLegacy.xcconfig:
619         * Misc/WebCache.mm:
620         (+[WebCache emptyInMemoryResources]):
621         * WebView/WebView.mm:
622
623 2017-02-21  Andreas Kling  <akling@apple.com>
624
625         [iOS] WebKit1 should use shared memory pressure handler code.
626         <https://webkit.org/b/168653>
627
628         Reviewed by Antti Koivisto.
629
630         Register a WebThread-aware memory callback with the shared MemoryPressureHandler
631         and get rid of the old iOS WebKit1 specific implementation. Some of it was even
632         dead code since MobileSafari has been using WebKit2 for quite a while.
633
634         * WebView/WebView.h:
635         * WebView/WebView.mm:
636         (WebInstallMemoryPressureHandler):
637         (+[WebView _handleMemoryWarning]): Deleted.
638         (+[WebView registerForMemoryNotifications]): Deleted.
639         (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
640         (+[WebView garbageCollectNow]): Deleted.
641         (+[WebView purgeInactiveFontData]): Deleted.
642         (+[WebView drainLayerPool]): Deleted.
643         (+[WebView discardAllCompiledCode]): Deleted.
644         (+[WebView _clearMemoryPressure]): Deleted.
645         (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
646         * WebView/WebViewPrivate.h:
647
648 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
649
650         Stop exporting interface WebCoreScrollView on iOS
651         https://bugs.webkit.org/show_bug.cgi?id=168536
652
653         Reviewed by Dan Bernstein.
654
655         * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
656         * WebKit.mac.exp: Ditto.
657         * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
658
659 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
660
661         Exclude various mac-specific header files from iOS build
662         https://bugs.webkit.org/show_bug.cgi?id=168621
663
664         Reviewed by Dan Bernstein.
665
666         * Configurations/WebKitLegacy.xcconfig:
667
668 2017-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
669
670         Add plumbing to the UI process for TextIndicatorData when computing the drag image
671         https://bugs.webkit.org/show_bug.cgi?id=168583
672         Work towards <rdar://problem/30313681>
673
674         Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
675
676         Reviewed by Tim Horton.
677
678         * WebView/WebHTMLView.mm:
679         (-[WebHTMLView _selectionDraggingImage]):
680         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
681
682 2017-02-17  Anders Carlsson  <andersca@apple.com>
683
684         Add a new drag code path and use it for dragging plain text
685         https://bugs.webkit.org/show_bug.cgi?id=168534
686
687         Reviewed by Geoffrey Garen.
688
689         * WebCoreSupport/WebDragClient.h:
690         Add new members.
691
692         * WebCoreSupport/WebDragClient.mm:
693         (WebDragClient::useLegacyDragClient):
694         Return false here.
695
696         (WebDragClient::beginDrag):
697         New client member function. Create an NSDraggingItem and use it to begin a dragging session.
698
699         * WebView/WebHTMLView.mm:
700         (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
701         Get the source operation mask from WebCore.
702
703         (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
704         Send a fake mouse up event.
705
706         * WebView/WebHTMLViewInternal.h:
707         Declare that WebHTMLView conforms to NSDraggingSource.
708
709 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
710
711         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
712         https://bugs.webkit.org/show_bug.cgi?id=168342
713         rdar://problem/26182266
714
715         Reviewed by Tim Horton.
716
717         * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
718         symbols to re-export.
719
720 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
721
722         Stop exporting DOMTokenList from WebKit
723         https://bugs.webkit.org/show_bug.cgi?id=168544
724
725         Reviewed by Alexey Proskuryakov.
726
727         * WebKit.exp:
728
729 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
730
731         Clean up how WebKit exports _WebCreateFragment
732         https://bugs.webkit.org/show_bug.cgi?id=168579
733
734         Reviewed by Dan Bernstein.
735
736         * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
737         * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
738
739 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
740
741         Stop exporting DOMNodeFilter
742         https://bugs.webkit.org/show_bug.cgi?id=168542
743
744         Reviewed by Alexey Proskuryakov.
745
746         * WebKit.exp:
747
748 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
749
750         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
751         https://bugs.webkit.org/show_bug.cgi?id=167693
752
753         Reviewed by Sergio Villar Senin.
754
755         * Configurations/FeatureDefines.xcconfig:
756         * WebView/WebPreferences.mm:
757         (+[WebPreferences initialize]):
758         * WebView/WebView.mm:
759         (-[WebView _preferencesChanged:]):
760
761 2017-02-15  Brady Eidson  <beidson@apple.com>
762
763         Stop backing up localStorage databases to iCloud by default.
764         <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
765
766         Reviewed by Geoffrey Garen.
767
768         * Misc/WebKitVersionChecks.h:
769         * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
770         (WebKitLinkedOnOrAfter):
771         (setWebKitLinkTimeVersion):
772         (WebKitLinkTimeVersion):
773         (linkedOnOrAfter):
774
775         * Storage/WebStorageManager.mm:
776         (WebKitInitializeStorageIfNecessary):
777
778 2017-02-16  Daniel Bates  <dabates@apple.com>
779
780         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
781         https://bugs.webkit.org/show_bug.cgi?id=168417
782         <rdar://problem/30541748>
783
784         Reviewed by Brent Fulgham.
785
786         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
787         Widget* as it is always called with a valid Widget.
788
789         * WebCoreSupport/WebFrameLoaderClient.h:
790         * WebCoreSupport/WebFrameLoaderClient.mm:
791         (WebFrameLoaderClient::redirectDataToPlugin):
792         * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
793         as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
794         r180570 (2 years ago) though Xcode still references this ordering file (why?).
795
796 2017-02-16  Yusuke Suzuki  <utatane.tea@gmail.com>
797
798         [JSC] Drop PassRefPtr in inspector/
799         https://bugs.webkit.org/show_bug.cgi?id=168420
800
801         Reviewed by Alex Christensen.
802
803         * WebView/WebScriptDebugger.mm:
804         (WebScriptDebugger::handlePause):
805
806 2017-02-16  Simon Fraser  <simon.fraser@apple.com>
807
808         Clean up use of some CALayer-related SPI
809         https://bugs.webkit.org/show_bug.cgi?id=168401
810
811         Reviewed by Tim Horton.
812
813         Include CALayer.h not CATiledLayer.h.
814
815         * WebInspector/WebNodeHighlight.h:
816
817 2017-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
818
819         Fix the build after r212379
820
821         Rubber-stamped by Anders Carlsson.
822
823         * WebCoreSupport/WebDragClient.mm:
824         (WebDragClient::startDrag):
825
826 2017-02-15  Anders Carlsson  <andersca@apple.com>
827
828         Modernize DragClient::startDrag somewhat
829         https://bugs.webkit.org/show_bug.cgi?id=168379
830
831         Reviewed by Tim Horton.
832
833         Update for WebCore changes.
834
835         * WebCoreSupport/WebDragClient.h:
836         * WebCoreSupport/WebDragClient.mm:
837         (WebDragClient::startDrag):
838
839 2017-02-14  Dean Jackson  <dino@apple.com>
840
841         Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
842         https://bugs.webkit.org/show_bug.cgi?id=168339
843
844         Reviewed by Simon Fraser.
845
846         Use a better name.
847
848         * WebView/WebPreferenceKeysPrivate.h:
849         * WebView/WebPreferences.mm:
850         (+[WebPreferences initialize]):
851         (-[WebPreferences forceLowPowerGPUForWebGL]):
852         (-[WebPreferences setForceLowPowerGPUForWebGL:]):
853         (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
854         (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
855         * WebView/WebPreferencesPrivate.h:
856         * WebView/WebView.mm:
857         (-[WebView _preferencesChanged:]):
858
859 2017-02-14  Chris Dumez  <cdumez@apple.com>
860
861         HTML Form Validation bubble should take minimum font size setting into consideration
862         https://bugs.webkit.org/show_bug.cgi?id=168271
863         <rdar://problem/29869869>
864
865         Reviewed by Simon Fraser.
866
867         * WebView/WebView.mm:
868         (-[WebView _contentsOfUserInterfaceItem:]):
869         Return font size used in the validation bubble.
870
871         (-[WebView showFormValidationMessage:withAnchorRect:]):
872         Pass minimum font size setting when constructing the validation bubble.
873
874 2017-02-14  Anders Carlsson  <andersca@apple.com>
875
876         Remove an unused delegate method
877         https://bugs.webkit.org/show_bug.cgi?id=168328
878
879         Reviewed by Wenson Hsieh.
880
881         * DefaultDelegates/WebDefaultUIDelegate.m:
882         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
883
884 2017-02-14  Alexey Proskuryakov  <ap@apple.com>
885
886         WebCore shouldn't export SystemMemory.h
887         https://bugs.webkit.org/show_bug.cgi?id=168285
888
889         Reviewed by Alex Christensen.
890
891         * MigrateHeaders.make: And WebKit shouldn't re-export it.
892
893 2017-02-13  Alexey Proskuryakov  <ap@apple.com>
894
895         WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
896         https://bugs.webkit.org/show_bug.cgi?id=168282
897
898         Reviewed by Dan Bernstein.
899
900         * MigrateHeaders.make:
901
902 2017-02-12  Dan Bernstein  <mitz@apple.com>
903
904         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
905
906         * WebView/WebHTMLView.mm:
907         (createShareMenuItem): Use non-deprecated method.
908
909 2017-02-12  Dan Bernstein  <mitz@apple.com>
910
911         [Cocoa] Some -respondsToSelector: checks are unnecessary
912         https://bugs.webkit.org/show_bug.cgi?id=168183
913
914         Reviewed by Tim Horton.
915
916         * WebView/WebFullScreenController.mm:
917         (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
918           responds to -isOnActiveSpace.
919         (-[WebFullScreenController exitFullScreen]): Ditto.
920         (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
921           NSApplication responds to -setPresentationOptions.
922
923         * WebView/WebHTMLView.mm:
924         (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
925         (-[WebHTMLView otherMouseDown:]): Ditto.
926
927         * WebView/WebImmediateActionController.mm:
928         (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
929         (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
930
931         * WebView/WebView.mm:
932         (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
933         (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
934
935 2017-02-10  Daniel Bates  <dabates@apple.com>
936
937         Detach frame from document when entering page cache
938         https://bugs.webkit.org/show_bug.cgi?id=166774
939         <rdar://problem/29904368>
940
941         Reviewed by Chris Dumez.
942
943         * WebView/WebPreferenceKeysPrivate.h:
944         * WebView/WebPreferences.mm:
945         (+[WebPreferences initialize]):
946         (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
947         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
948         * WebView/WebPreferencesPrivate.h:
949         * WebView/WebView.mm:
950         (-[WebView _preferencesChanged:]):
951
952 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
953
954         [Resource Timing] Enable Resource Timing by default in Tests
955         https://bugs.webkit.org/show_bug.cgi?id=168145
956
957         Reviewed by Ryosuke Niwa.
958
959         * WebView/WebPreferenceKeysPrivate.h:
960         * WebView/WebPreferences.mm:
961         (+[WebPreferences initialize]):
962         (-[WebPreferences resourceTimingEnabled]):
963         (-[WebPreferences setResourceTimingEnabled:]):
964         * WebView/WebPreferencesPrivate.h:
965         * WebView/WebView.mm:
966         (-[WebView _preferencesChanged:]):
967
968 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
969
970         cleanup WebLocalizableStrings.
971         https://bugs.webkit.org/show_bug.cgi?id=168078
972
973         Reviewed by Alexey Proskuryakov.
974
975         * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
976         as it's for each framework's own consumption, and never needs to be exported.
977
978 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
979
980         WebResourceLoadDelegatePrivate.h cannot be imported standalone
981         https://bugs.webkit.org/show_bug.cgi?id=168096
982
983         Reviewed by Alexey Proskuryakov.
984
985         * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
986
987 2017-02-09  Antti Koivisto  <antti@apple.com>
988
989         Remove most cases of #if ENABLE(CACHE_PARTITIONING)
990         https://bugs.webkit.org/show_bug.cgi?id=167990
991
992         Reviewed by Sam Weinig.
993
994         * Misc/WebCache.mm:
995         (+[WebCache addImageToCache:forURL:forFrame:]):
996         (+[WebCache removeImageFromCacheForURL:forFrame:]):
997         * WebCoreSupport/WebSystemInterface.mm:
998         (InitWebCoreSystemInterface):
999
1000 2017-02-07  Alexey Proskuryakov  <ap@apple.com>
1001
1002         Don't migrate WebKit DOM headers in MigrateHeaders.make
1003         https://bugs.webkit.org/show_bug.cgi?id=167608
1004
1005         Reviewed by Darin Adler.
1006
1007         Stop migrating DOM headers that are now in WebKit.
1008
1009         * DOM/DOMDOMImplementation.h: Removed.
1010         * DOM/DOMDOMImplementation.mm: Removed.
1011         * DOM/DOMDOMImplementationInternal.h: Removed.
1012         * DOM/DOMDOMTokenList.h: Removed.
1013         * DOM/DOMDOMTokenList.mm: Removed.
1014         * DOM/DOMDOMTokenListInternal.h: Removed.
1015         * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
1016         * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
1017         * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
1018         * DOM/DOMTokenList.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.h.
1019         * DOM/DOMTokenList.mm: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.mm.
1020         * DOM/DOMTokenListInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenListInternal.h.
1021         As the files are not in WebCore any more, there is no need to differentiate from
1022         WebCore internal headers with the same name. This makes it possible to make these
1023         headers private using Xcode mechanisms, as opposed to copying with a shell script.
1024
1025         * DOM/DOMElement.mm: Removed "using namespace WebCore". Other DOM implementation
1026         files don't have it.
1027
1028         * DOM/DOMCore.h:
1029         * DOM/DOMDocument.mm:
1030         * DOM/DOMHTMLAnchorElement.mm:
1031         * DOM/DOMHTMLAreaElement.mm:
1032         * DOM/DOMHTMLLinkElement.mm:
1033         * DOM/DOMUtility.mm:
1034         No more "DOMDOM".
1035
1036         * WebKit.exp:
1037         No more "DOMDOM". DOMDOMTokenList was not directly exposed via an SPI header, so
1038         renaming it is likely to be safe.
1039
1040         * MigrateHeaders.make: Don't migrate WebKit headers.
1041
1042         * Configurations/WebKitLegacy.xcconfig: Don't include two iOS specific SPI headers
1043         on macOS.
1044
1045 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
1046
1047         Don't re-export PluginData.h from WebKit
1048         https://bugs.webkit.org/show_bug.cgi?id=168020
1049
1050         Reviewed by Alexey Proskuryakov.
1051
1052         * MigrateHeaders.make: Removed PluginData.h
1053
1054 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
1055
1056         Don't re-export WKUtilities.h from WebKit
1057         https://bugs.webkit.org/show_bug.cgi?id=167977
1058
1059         Reviewed by Alexey Proskuryakov.
1060
1061         * MigrateHeaders.make: Removed WKUtilities.h
1062
1063 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1064
1065         credentials should be partitioned by main document domain
1066         https://bugs.webkit.org/show_bug.cgi?id=166998
1067         rdar://problem/22901123
1068
1069         Reviewed by Brady Eidson.
1070
1071         * Misc/WebDownload.mm:
1072         * Plugins/WebBaseNetscapePluginView.mm:
1073         (WebKit::getAuthenticationInfo):
1074         Don't use partitioned credentials for WebKit1 plugins or downloads.
1075         Downloads should be authenticated before becoming a download anyways.
1076
1077 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
1078
1079         Rename AnimationController to CSSAnimationController
1080         https://bugs.webkit.org/show_bug.cgi?id=167829
1081
1082         Reviewed by Simon Fraser.
1083
1084         * WebView/WebFrame.mm:
1085         * WebView/WebView.mm:
1086
1087 2017-02-03  Chris Dumez  <cdumez@apple.com>
1088
1089         Dismiss HTML form validation popover when pressing Escape key
1090         https://bugs.webkit.org/show_bug.cgi?id=167716
1091         <rdar://problem/29872943>
1092
1093         Reviewed by Simon Fraser.
1094
1095         Override ValidationMessageClient::hideAnyValidationMessage().
1096
1097         * WebCoreSupport/WebValidationMessageClient.h:
1098         * WebCoreSupport/WebValidationMessageClient.mm:
1099         (WebValidationMessageClient::hideAnyValidationMessage):
1100
1101 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1102
1103         Drag images should be anchored to the mouse location
1104         https://bugs.webkit.org/show_bug.cgi?id=167690
1105         <rdar://problem/30295261>
1106
1107         Reviewed by Enrica Casucci.
1108
1109         Adds some plumbing for the anchor point in the WK1 client layer.
1110
1111         * WebCoreSupport/WebDragClient.h:
1112         * WebCoreSupport/WebDragClient.mm:
1113         (WebDragClient::startDrag):
1114
1115 2017-02-02  Chris Dumez  <cdumez@apple.com>
1116
1117         Rename Node::inDocument() to isConnected()
1118         https://bugs.webkit.org/show_bug.cgi?id=167743
1119
1120         Reviewed by Sam Weinig.
1121
1122         Rename Node::inDocument() to isConnected() to match the DOM specification more closely:
1123         - https://dom.spec.whatwg.org/#connected
1124
1125         * DOM/DOMNode.mm:
1126         (-[DOMNode isConnected]):
1127         * WebView/WebFrame.mm:
1128         (-[WebFrame selectNSRange:onElement:]):
1129
1130 2017-02-02  Chris Dumez  <cdumez@apple.com>
1131
1132         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
1133         https://bugs.webkit.org/show_bug.cgi?id=167738
1134         <rdar://problem/30229990>
1135
1136         Reviewed by Andreas Kling.
1137
1138         The BackForwardClient no longer needs to worry about removing HistoryItems
1139         from the PageCache now that WebCore takes care of it.
1140
1141         * History/BackForwardList.mm:
1142         (BackForwardList::close):
1143
1144 2017-02-02  Yongjun Zhang  <yongjun_zhang@apple.com>
1145
1146         In iOS, we should take background assertion when accessing localstorage databases.
1147         https://bugs.webkit.org/show_bug.cgi?id=165478
1148
1149         Move database transaction background task handling code from WebDatabaseManager to
1150         WebCore's WebSQLiteDatabaseTrackerClient.
1151
1152         Reviewed by Brady Eidson.
1153
1154         * Storage/WebDatabaseManager.mm:
1155         * Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.
1156         * WebCoreSupport/WebApplicationCache.mm:
1157         (+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.
1158         * WebView/WebView.mm:
1159         (-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.
1160
1161 2017-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1162
1163         [WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
1164         https://bugs.webkit.org/show_bug.cgi?id=167695
1165         <rdar://problem/30305390>
1166
1167         Reviewed by Sam Weinig.
1168
1169         Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
1170         exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
1171         is destroyed.
1172
1173         * WebView/WebView.mm:
1174         (-[WebView _commonInitializationWithFrameName:groupName:]):
1175
1176 2017-01-31  Joseph Pecoraro  <pecoraro@apple.com>
1177
1178         ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
1179         https://bugs.webkit.org/show_bug.cgi?id=167684
1180
1181         Reviewed by Dan Bernstein.
1182
1183         * DOM/DOMHTML.mm:
1184         (-[DOMHTMLInputElement _isAutofilled]): Deleted.
1185         (-[DOMHTMLInputElement _setAutofilled:]): Deleted.
1186         Consolidate in the WebDOMOperationsPrivate category.
1187
1188         * DOM/DOMPrivate.h:
1189         Include WebDOMOperationsPrivate header to get other DOM Private categories.
1190
1191         * DOM/WebDOMOperations.mm:
1192         (-[DOMHTMLInputElement _isAutofilled]):
1193         * DOM/WebDOMOperationsPrivate.h:
1194         Include getter alongside the setter.
1195
1196 2017-01-31  Jessie Berlin  <jberlin@webkit.org>
1197
1198         Build fix.
1199
1200         * Misc/WebNSPasteboardExtras.mm:
1201         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1202         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1203         * WebView/WebHTMLView.mm:
1204         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1205         (-[WebHTMLView copyFont:]):
1206
1207 2017-01-30  Andy Estes  <aestes@apple.com>
1208
1209         [QuickLook] FrameLoaderClient should return the new QuickLookHandleClient it creates
1210         https://bugs.webkit.org/show_bug.cgi?id=167625
1211
1212         Reviewed by Andreas Kling.
1213
1214         * WebCoreSupport/WebFrameLoaderClient.h: Declared createQuickLookHandleClient().
1215         * WebCoreSupport/WebFrameLoaderClient.mm:
1216         (WebFrameLoaderClient::createQuickLookHandleClient): Renamed from didCreateQuickLookHandle().
1217         (WebFrameLoaderClient::didCreateQuickLookHandle): Renamed to createQuickLookHandleClient().
1218
1219 2017-01-30  Chris Dumez  <cdumez@apple.com>
1220
1221         Drop legacy Attributes.isId attribute
1222         https://bugs.webkit.org/show_bug.cgi?id=167603
1223
1224         Reviewed by Ryosuke Niwa.
1225
1226         Keep Attr.isId in ObjC bindings.
1227
1228         * DOM/DOMAttr.mm:
1229         (-[DOMAttr isId]):
1230
1231 2017-01-30  Andreas Kling  <akling@apple.com>
1232
1233         [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.
1234         <https://webkit.org/b/167580>
1235
1236         Reviewed by Antti Koivisto.
1237
1238         Avoid the implicit strong capture of self by keeping it in a __block variable.
1239         Also add code to dealloc to unregister the event monitor, since it will otherwise leak.
1240         This fixes huge WebHTMLView leaks seen on the leaks bot.
1241
1242         * WebView/WebHTMLView.mm:
1243         (-[WebHTMLViewPrivate dealloc]):
1244         (-[WebHTMLView viewDidMoveToWindow]):
1245
1246 2017-01-29  Andy Estes  <aestes@apple.com>
1247
1248         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1249         https://bugs.webkit.org/show_bug.cgi?id=167563
1250         <rdar://problem/30253207>
1251
1252         Reviewed by Andreas Kling.
1253
1254         Instead of only saving QuickLook documents to a temporary file when the client is
1255         MobileSafari, base this decision on a WebPreference that clients can choose to enable.
1256
1257         This also changes the SPI for accessing the temporary file path and UTI. Instead of
1258         -[WebView quickLookContentForURL:], which requires the client to pass the response URL of
1259         the frame that saved the QuickLook document, the content dictionary is now stored as a
1260         property of WebDataSource.
1261
1262         This also removes the manual lifetime management of the QLPreviewConverter from
1263         QuickLookDocumentWriter. The QLPreviewConverter is kept alive by DocumentLoader these days,
1264         which ensures it lives long enough to respond to subresource requests.
1265
1266         New API test: QuickLook.LegacyQuickLookContent
1267
1268         * WebCoreSupport/WebFrameLoaderClient.mm:
1269         (WebFrameLoaderClient::didCreateQuickLookHandle): Moved the logic of deciding whether to
1270         write a temporary file to here from the QuickLookDocumentWriter constructor.
1271         * WebView/WebDataSource.mm: Declared _quickLookContent.
1272         (-[WebDataSource _quickLookContent]):
1273         (-[WebDataSource _setQuickLookContent:]):
1274         * WebView/WebDataSourceInternal.h: Overrode _quickLookContent as a read/write property.
1275         * WebView/WebDataSourcePrivate.h: Declared _quickLookContent as a readonly property.
1276         * WebView/WebPreferenceKeysPrivate.h: Defined WebKitQuickLookDocumentSavingPreferenceKey.
1277         * WebView/WebPreferences.mm:
1278         (-[WebPreferences quickLookDocumentSavingEnabled]):
1279         (-[WebPreferences setQuickLookDocumentSavingEnabled:]):
1280         * WebView/WebPreferencesPrivate.h: Declared property quickLookDocumentSavingEnabled.
1281         * WebView/WebView.mm:
1282         (-[WebView quickLookContentForURL:]): Changed to always return nil.
1283         * WebView/WebViewPrivate.h: Added a comment stating that clients should use
1284         -[WebDataSource _quickLookContent] instead.
1285
1286 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1287
1288         Add Link Preload as an off-by-default experimental feature menu item.
1289         https://bugs.webkit.org/show_bug.cgi?id=167201
1290
1291         Reviewed by Ryosuke Niwa.
1292
1293         * WebView/WebPreferenceKeysPrivate.h:
1294         * WebView/WebPreferences.mm:
1295         (-[WebPreferences linkPreloadEnabled]):
1296         (-[WebPreferences setLinkPreloadEnabled:]):
1297         * WebView/WebPreferencesPrivate.h:
1298         * WebView/WebView.mm:
1299         (-[WebView _preferencesChanged:]):
1300
1301 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1302
1303         Add User Timing Experimental Feature
1304         https://bugs.webkit.org/show_bug.cgi?id=167542
1305         <rdar://problem/22746307>
1306
1307         Reviewed by Ryosuke Niwa.
1308
1309         * WebView/WebPreferenceKeysPrivate.h:
1310         * WebView/WebPreferences.mm:
1311         (+[WebPreferences initialize]):
1312         (-[WebPreferences userTimingEnabled]):
1313         (-[WebPreferences setUserTimingEnabled:]):
1314         * WebView/WebPreferencesPrivate.h:
1315         * WebView/WebView.mm:
1316         (-[WebView _preferencesChanged:]):
1317         Add setting for User Timing runtime enabled feature.
1318
1319 2017-01-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1320
1321         [WK1] Do not prevent the drag client from initializing on Mac
1322         https://bugs.webkit.org/show_bug.cgi?id=167541
1323
1324         Reviewed by Dan Bernstein.
1325
1326         Fixes fallout from r211192. To ensure compability with WebKit clients, we need to ensure that WebDragClient is
1327         initialized everywhere when creating a WebView. Stub out method implementations as no-ops for non-Mac platforms.
1328         This caused certain clients, such as Mail, to crash when a webView closes due to  null dereference.
1329
1330         * WebCoreSupport/WebDragClient.mm:
1331         (WebDragClient::WebDragClient):
1332         (WebDragClient::actionMaskForDrag):
1333         (WebDragClient::willPerformDragDestinationAction):
1334         (WebDragClient::dragSourceActionMaskForPoint):
1335         (WebDragClient::willPerformDragSourceAction):
1336         (WebDragClient::startDrag):
1337         (WebDragClient::declareAndWriteDragImage):
1338         (WebDragClient::declareAndWriteAttachment):
1339         * WebView/WebView.mm:
1340         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1341
1342 2017-01-26  Chris Dumez  <cdumez@apple.com>
1343
1344         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1345         https://bugs.webkit.org/show_bug.cgi?id=167421
1346         <rdar://problem/30188490>
1347
1348         Reviewed by Darin Adler.
1349
1350         Add a new setting allowing layout tests to enable PageCache in a window
1351         that has an opener, for convenience.
1352
1353         * WebView/WebPreferenceKeysPrivate.h:
1354         * WebView/WebPreferences.mm:
1355         (+[WebPreferences initialize]):
1356         (-[WebPreferences allowsPageCacheWithWindowOpener]):
1357         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]):
1358         * WebView/WebPreferencesPrivate.h:
1359         * WebView/WebView.mm:
1360         (-[WebView _preferencesChanged:]):
1361
1362 2017-01-26  Keith Miller  <keith_miller@apple.com>
1363
1364         classInfo should take a VM so it is not materialized from the object on each call
1365         https://bugs.webkit.org/show_bug.cgi?id=167424
1366
1367         Rubber Stamped by Michael Saboff.
1368
1369         Previously, classInfo() would get the VM from the target's
1370         MarkedBlock.  Most callers already have a VM on hand, so it is
1371         wasteful to compute the VM from the marked block every time. This
1372         patch refactors some of the most common callers of classInfo(),
1373         jsDynamicCast and inherits to take a VM as well.
1374
1375         * DOM/DOM.mm:
1376         (+[DOMNode _nodeFromJSWrapper:]):
1377         * DOM/DOMUtility.mm:
1378         (createDOMWrapper):
1379         * DOM/WebDOMOperations.mm:
1380         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1381         (WebKit::getObjectID):
1382         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
1383         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
1384         * Plugins/Hosted/ProxyInstance.mm:
1385         (WebKit::ProxyRuntimeMethod::finishCreation):
1386         (WebKit::ProxyInstance::invokeMethod):
1387         * Plugins/Hosted/ProxyRuntimeObject.mm:
1388         (WebKit::ProxyRuntimeObject::finishCreation):
1389         * WebView/WebFrame.mm:
1390         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
1391         * WebView/WebView.mm:
1392         (+[WebView _reportException:inContext:]):
1393         (aeDescFromJSValue):
1394         (-[WebView _notificationIDForTesting:]):
1395
1396 2017-01-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1397
1398         REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar in HTML Notes
1399         https://bugs.webkit.org/show_bug.cgi?id=167472
1400         <rdar://problem/30149809>
1401
1402         Reviewed by Beth Dakin.
1403
1404         Revision 207483 caused the touch bar to stop showing up in HTML Notes due to -updateTextTouchBar not
1405         initializing the text touch bar and causing -makeTouchBar to return nil while processing a mouse click. The
1406         purpose of bailing out of the update was to prevent the text touch bar from thrashing during a selection drag.
1407         If the text touch bar doesn't exist yet, we don't have to worry about its appearance flickering from a different
1408         previous state, so we should just allow the touch bar to update instead.
1409
1410         * WebView/WebView.mm:
1411         (-[WebView updateTextTouchBar]):
1412
1413 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1414
1415         Crash when setting custom scale factor.
1416         https://bugs.webkit.org/show_bug.cgi?id=167369
1417
1418         Reviewed by Sam Weinig.
1419
1420         Add null pointer check.
1421
1422         * WebView/WebView.mm:
1423         (-[WebView _setCustomBackingScaleFactor:]):
1424
1425 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1426
1427         Refactor drag and drop implementation on Mac
1428         https://bugs.webkit.org/show_bug.cgi?id=167427
1429
1430         Reviewed by Enrica Casucci.
1431
1432         Refactor some WebKit1 code on the Mac pertaining to drag and drop. See WebCore ChangeLog for more details.
1433
1434         * Misc/WebNSPasteboardExtras.h:
1435         * WebCoreSupport/WebDragClient.mm:
1436         * WebView/WebFrame.mm:
1437         * WebView/WebFrameInternal.h:
1438         * WebView/WebHTMLView.mm:
1439         * WebView/WebView.mm:
1440         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1441
1442 2017-01-24  Youenn Fablet  <youennf@gmail.com>
1443
1444         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
1445         https://bugs.webkit.org/show_bug.cgi?id=167294
1446
1447         Reviewed by Alex Christensen.
1448
1449         * WebView/WebView.mm:
1450         (-[WebView _commonInitializationWithFrameName:groupName:]):
1451
1452 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1453
1454         Add support for named pasteboards, pasteboard strategies and platform pasteboards
1455         https://bugs.webkit.org/show_bug.cgi?id=167404
1456
1457         Reviewed by Enrica Casucci.
1458
1459         Adds pasteboard name as an argument to pasteboard-related WebPlatformStrategy methods.
1460
1461         * WebCoreSupport/WebPlatformStrategies.h:
1462         * WebCoreSupport/WebPlatformStrategies.mm:
1463         (WebPlatformStrategies::writeToPasteboard):
1464         (WebPlatformStrategies::getPasteboardItemsCount):
1465         (WebPlatformStrategies::readBufferFromPasteboard):
1466         (WebPlatformStrategies::readURLFromPasteboard):
1467         (WebPlatformStrategies::readStringFromPasteboard):
1468
1469 2017-01-25  Aakash Jain  <aakash_jain@apple.com>
1470
1471         LoadWebLocalizedStrings method should be moved in correct file
1472         https://bugs.webkit.org/show_bug.cgi?id=167393
1473
1474         Reviewed by Alexey Proskuryakov.
1475
1476         * Misc/WebLocalizableStrings.h: Deleted LoadWebLocalizedStrings method.
1477         * Misc/WebLocalizableStrings.mm:
1478         (LoadWebLocalizedStringsTimerCallback): Deleted, moved to WebUIKitSupport.mm
1479         (LoadWebLocalizedStrings): Deleted, moved to WebUIKitSupport.mm
1480
1481 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1482
1483         Add simple line layout toggle to MiniBrowser
1484         https://bugs.webkit.org/show_bug.cgi?id=167405
1485
1486         Reviewed by Andreas Kling.
1487
1488         * WebView/WebPreferenceKeysPrivate.h:
1489         * WebView/WebPreferences.mm:
1490         (+[WebPreferences initialize]):
1491         (-[WebPreferences simpleLineLayoutEnabled]):
1492         (-[WebPreferences setSimpleLineLayoutEnabled:]):
1493         * WebView/WebPreferencesPrivate.h:
1494         * WebView/WebView.mm:
1495         (-[WebView _preferencesChanged:]):
1496
1497 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1498
1499         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1500         https://bugs.webkit.org/show_bug.cgi?id=167394
1501
1502         Reviewed by Ryosuke Niwa.
1503
1504         * Configurations/FeatureDefines.xcconfig:
1505
1506 2017-01-23  Chris Dumez  <cdumez@apple.com>
1507
1508         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
1509         https://bugs.webkit.org/show_bug.cgi?id=167308
1510         <rdar://problem/30144964>
1511
1512         Unreviewed, do a partial revert of r211033 to fix assertion.
1513
1514         * WebCoreSupport/WebChromeClient.h:
1515         * WebCoreSupport/WebChromeClient.mm:
1516         (WebChromeClient::exitFullScreenForElement):
1517
1518 2017-01-23  Joseph Pecoraro  <pecoraro@apple.com>
1519
1520         Remove allowWindowOpenWithoutUserGesture setting
1521         https://bugs.webkit.org/show_bug.cgi?id=167301
1522
1523         Reviewed by Darin Adler.
1524
1525         * WebView/WebView.mm:
1526         (-[WebView _preferencesChanged:]):
1527         Use the equivalent existing setting.
1528
1529 2017-01-20  Darin Adler  <darin@apple.com>
1530
1531         Remove PassRefPtr from "page" directory of WebCore, also deploy references
1532         https://bugs.webkit.org/show_bug.cgi?id=167224
1533
1534         Reviewed by Chris Dumez.
1535
1536         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
1537         (-[WebApplicationCacheQuotaManager quota]): Pass reference.
1538
1539         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
1540         * WebCoreSupport/WebChromeClient.mm:
1541         (WebChromeClient::focusedElementChanged): Ditto.
1542         (WebChromeClient::createWindow): Ditto.
1543         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
1544         (WebChromeClient::runJavaScriptAlert): Ditto.
1545         (WebChromeClient::runJavaScriptConfirm): Ditto.
1546         (WebChromeClient::runJavaScriptPrompt): Ditto.
1547         (WebChromeClient::contentsSizeChanged): Ditto.
1548         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
1549         (WebChromeClient::print): Ditto.
1550         (WebChromeClient::exceededDatabaseQuota): Ditto.
1551         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
1552         (WebChromeClient::createColorChooser): Ditto.
1553         (WebChromeClient::elementDidFocus): Ditto.
1554         (WebChromeClient::elementDidBlur): Ditto.
1555         (WebChromeClient::createPopupMenu): Ditto.
1556         (WebChromeClient::createSearchPopupMenu): Ditto.
1557         (WebChromeClient::attachRootGraphicsLayer): Ditto.
1558         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
1559         (WebChromeClient::supportsFullScreenForElement): Ditto.
1560         (WebChromeClient::enterFullScreenForElement): Ditto.
1561         (WebChromeClient::exitFullScreenForElement): Ditto.
1562
1563         * WebView/WebFrame.mm:
1564         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1565         Updated for change to the appendChild function.
1566
1567 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
1568
1569         Remove -[WebFrame sendOrientationChangeEvent:] which is unused
1570         https://bugs.webkit.org/show_bug.cgi?id=167276
1571
1572         Reviewed by Alex Christensen.
1573         
1574         It was usurped by -deviceOrientationChanged in 2014.
1575
1576         * WebView/WebFrame.mm:
1577         (-[WebFrame sendOrientationChangeEvent:]): Deleted.
1578         * WebView/WebFramePrivate.h:
1579
1580 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
1581
1582         Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
1583         https://bugs.webkit.org/show_bug.cgi?id=167271
1584
1585         Reviewed by Alex Christensen.
1586         
1587         -_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
1588         overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),
1589
1590         * WebView/WebView.mm:
1591         (-[WebView _contentsSizeRespectingOverflow]): Deleted.
1592         * WebView/WebViewPrivate.h:
1593
1594 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1595
1596         Remove never changing IndexedDB RuntimeEnabledFeature
1597         https://bugs.webkit.org/show_bug.cgi?id=167278
1598
1599         Reviewed by Darin Adler.
1600
1601         * WebView/WebView.mm:
1602         (-[WebView _preferencesChanged:]):
1603
1604 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1605
1606         Cleanup RuntimeEnabledFeatures
1607         https://bugs.webkit.org/show_bug.cgi?id=167228
1608
1609         Reviewed by Simon Fraser.
1610
1611         * WebView/WebView.mm:
1612         (-[WebView _preferencesChanged:]):
1613
1614 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1615
1616         Remove outdated ENABLE(CSP_NEXT) build flag
1617         https://bugs.webkit.org/show_bug.cgi?id=167252
1618
1619         Reviewed by Brent Fulgham.
1620
1621         * Configurations/FeatureDefines.xcconfig:
1622
1623 2017-01-20  Antoine Quint  <graouts@apple.com>
1624
1625         [Modern Media Controls] Turn modern media controls on by default
1626         https://bugs.webkit.org/show_bug.cgi?id=165668
1627
1628         Reviewed by Dean Jackson.
1629
1630         Enabled modern media controls by default in WK1.
1631
1632         * WebView/WebPreferences.mm:
1633         (+[WebPreferences initialize]):
1634
1635 2017-01-19  Chris Dumez  <cdumez@apple.com>
1636
1637         iterable<> should be enabled on WK1
1638         https://bugs.webkit.org/show_bug.cgi?id=167221
1639         <rdar://problem/30108531>
1640
1641         Reviewed by Youenn Fablet.
1642
1643         * WebView/WebPreferenceKeysPrivate.h:
1644         * WebView/WebPreferences.mm:
1645         (-[WebPreferences setCustomElementsEnabled:]):
1646         (-[WebPreferences DOMIteratorEnabled]): Deleted.
1647         (-[WebPreferences setDOMIteratorEnabled:]): Deleted.
1648         * WebView/WebPreferencesPrivate.h:
1649         * WebView/WebView.mm:
1650         (-[WebView _preferencesChanged:]):
1651
1652 2017-01-19  Chris Dumez  <cdumez@apple.com>
1653
1654         Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
1655         https://bugs.webkit.org/show_bug.cgi?id=167215
1656         <rdar://problem/29885052>
1657
1658         Reviewed by Andreas Kling.
1659
1660         Make sure HTML validation bubble gets dismissed when its associated
1661         element's frame gets detached and that we do not crash.
1662
1663         * WebCoreSupport/WebValidationMessageClient.h:
1664         * WebCoreSupport/WebValidationMessageClient.mm:
1665         (WebValidationMessageClient::documentDetached):
1666
1667 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1668
1669         [Cocoa] Variation fonts are erroneously disabled on iOS
1670         https://bugs.webkit.org/show_bug.cgi?id=167172
1671
1672         Reviewed by Simon Fraser.
1673
1674         OpenSource builders don't seem to understand sdk=embedded*.
1675
1676         * Configurations/FeatureDefines.xcconfig:
1677
1678 2017-01-19  Andreas Kling  <akling@apple.com>
1679
1680         ScriptExecutionContext::topOrigin() should return a reference.
1681         <https://webkit.org/b/167190>
1682
1683         Reviewed by Sam Weinig.
1684
1685         * Misc/WebCache.mm:
1686         (+[WebCache addImageToCache:forURL:forFrame:]):
1687         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1688
1689 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1690
1691         Unreviewed fix for the macOS build.
1692
1693         * Carbon/CarbonWindowAdapter.mm:
1694         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1695
1696 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1697
1698         Unreviewed, rolling out r210848.
1699
1700         This change introduced media-related LayoutTest failures and
1701         crashes on macOS.
1702
1703         Reverted changeset:
1704
1705         "[Modern Media Controls] Turn modern media controls on by
1706         default"
1707         https://bugs.webkit.org/show_bug.cgi?id=165668
1708         http://trac.webkit.org/changeset/210848
1709
1710 2017-01-18  Andreas Kling  <akling@apple.com>
1711
1712         Document::securityOrigin() should return a reference.
1713         <https://webkit.org/b/167124>
1714
1715         Reviewed by Sam Weinig.
1716
1717         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1718         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1719         * Plugins/WebNetscapePluginStream.mm:
1720         (WebNetscapePluginStream::WebNetscapePluginStream):
1721         * Plugins/WebNetscapePluginView.mm:
1722         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1723         * Plugins/WebPluginContainerCheck.mm:
1724         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1725         * WebCoreSupport/WebChromeClient.mm:
1726         (WebChromeClient::exceededDatabaseQuota):
1727         * WebCoreSupport/WebFrameLoaderClient.h:
1728         * WebCoreSupport/WebFrameLoaderClient.mm:
1729         (WebFrameLoaderClient::didRunInsecureContent):
1730         * WebCoreSupport/WebGeolocationClient.mm:
1731         (WebGeolocationClient::requestPermission):
1732         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
1733         * WebView/WebFrame.mm:
1734         (-[WebFrame _allowsFollowingLink:]):
1735
1736 2017-01-18  Antoine Quint  <graouts@apple.com>
1737
1738         [Modern Media Controls] Turn modern media controls on by default
1739         https://bugs.webkit.org/show_bug.cgi?id=165668
1740
1741         Reviewed by Dean Jackson.
1742
1743         Enabled modern media controls by default in WK1. 
1744
1745         * WebView/WebPreferences.mm:
1746         (+[WebPreferences initialize]):
1747
1748 2017-01-15  Darin Adler  <darin@apple.com>
1749
1750         Remove PassRefPtr from "loader" directory of WebCore
1751         https://bugs.webkit.org/show_bug.cgi?id=167055
1752
1753         Reviewed by Alex Christensen.
1754
1755         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
1756         Also made class final and most functions private and final.
1757         * WebCoreSupport/WebChromeClient.mm:
1758         (WebChromeClient::runOpenPanel): Updated to take references.
1759
1760         * WebCoreSupport/WebEditorClient.h: Updated for changes to EditorClient.
1761         * WebCoreSupport/WebEditorClient.mm:
1762         (-[WebUndoStep initWithUndoStep:]): Take reference instead of PassRefPtr.
1763         (+[WebUndoStep stepWithUndoStep:]): Ditto.
1764         (-[WebUndoStep step]): Return reference instead of pointer.
1765         (-[WebEditorUndoTarget undoEditing:]): Updated for the above.
1766         (-[WebEditorUndoTarget redoEditing:]): Ditto.
1767         (WebEditorClient::registerUndoOrRedoStep): Take reference instead of
1768         PassRefPtr.
1769         (WebEditorClient::registerUndoStep): Ditto.
1770         (WebEditorClient::registerRedoStep): Ditto.
1771
1772         * WebCoreSupport/WebFrameLoaderClient.h: Updated for changes to
1773         FrameLoaderClient, marked functions final instead of override.
1774         * WebCoreSupport/WebFrameLoaderClient.mm:
1775         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Take
1776         pointer instead of PassRefPtr.
1777         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
1778         (makeFormFieldValuesDictionary): Take a reference.
1779         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Take Ref&& instead
1780         of PassRefPtr.
1781         (WebFrameLoaderClient::dispatchWillSubmitForm): Take a reference instead
1782         of PassRefPtr.
1783         (WebFrameLoaderClient::actionDictionary): Take a pointer instead of PassRePtr.
1784         (WebFrameLoaderClient::createFrame): Take a reference instead of a pointer.
1785         (WebFrameLoaderClient::createPlugin): Ditto.
1786         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
1787         (WebFrameLoaderClient::createNetworkingContext): Ditto.
1788         (WebFrameLoaderClient::didCreateQuickLookHandle): Pass a reference.
1789
1790         * WebCoreSupport/WebFrameNetworkingContext.h: Use Ref instead of PassRefPtr.
1791         * WebCoreSupport/WebFrameNetworkingContext.mm: Tweak style a bit.
1792
1793         * WebCoreSupport/WebOpenPanelResultListener.h: Take a reference instead of
1794         PassRefPtr. Use RefPtr for class field.
1795         * WebCoreSupport/WebOpenPanelResultListener.mm:
1796         (-[WebOpenPanelResultListener dealloc]): Deleted. Compiler will now do it
1797         correctly without us declaring anything explicitly.
1798         (-[WebOpenPanelResultListener cancel]): Get rid of hand-written deref code,
1799         and let RefPtr do the work.
1800         (-[WebOpenPanelResultListener chooseFilename:]): Ditto.
1801         (-[WebOpenPanelResultListener chooseFilenames:]): Ditto.
1802         (-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]):
1803         Rewrote to use a modern Objective-C for loop, reserveInitialCapacity,
1804         and uncheckedAppend.
1805
1806         * WebView/WebArchive.mm:
1807         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
1808         Updated for changes to LegacyWebArchive.
1809         (-[WebArchive mainResource]): Ditto.
1810         (-[WebArchive subresources]): Ditto.
1811         (-[WebArchive subframeArchives]): Ditto.
1812
1813         * WebView/WebDataSource.mm:
1814         (-[WebDataSource _addSubframeArchives:]): Use a modern Objective-C for loop
1815         instead of NSEnumerator.
1816         (-[WebDataSource _fileWrapperForURL:]): Use auto.
1817         (-[WebDataSource _documentFragmentWithArchive:]): Pass a reference.
1818         (-[WebDataSource mainResource]): Ditto.
1819         (-[WebDataSource subresources]): Ditto.
1820         (-[WebDataSource subresourceForURL:]): Ditto.
1821         (-[WebDataSource addSubresource:]): Ditto.
1822
1823         * WebView/WebResource.mm:
1824         (-[WebResourcePrivate initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
1825         (-[WebResourcePrivate dealloc]): Remove explicit deref since RefPtr will now take
1826         care of it
1827         (-[WebResource initWithCoder:]): Pass a reference.
1828         (-[WebResource encodeWithCoder:]): Updated since coreResource is now RefPtr.
1829         (-[WebResource _initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
1830         (-[WebResource _coreResource]): Return reference rather than pointer.
1831         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1832         Added code to handle the null case and pass a reference rather than a pointer.
1833         * WebView/WebResourceInternal.h: Updated for the above.
1834
1835 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1836
1837         Unreviewed, rolling out r210834
1838         https://bugs.webkit.org/show_bug.cgi?id=165668
1839
1840         It introduced dozens of test timeouts.
1841
1842         Reverted changeset:
1843         "[Modern Media Controls] Turn modern media controls on by default"
1844         https://bugs.webkit.org/show_bug.cgi?id=165668
1845         http://trac.webkit.org/changeset/210834
1846
1847 2017-01-17  Antoine Quint  <graouts@apple.com>
1848
1849         [Modern Media Controls] Turn modern media controls on by default
1850         https://bugs.webkit.org/show_bug.cgi?id=165668
1851
1852         Reviewed by Dean Jackson.
1853
1854         Enabled modern media controls by default in WK1. 
1855
1856         * WebView/WebPreferences.mm:
1857         (+[WebPreferences initialize]):
1858
1859 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1860
1861         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1862         https://bugs.webkit.org/show_bug.cgi?id=116551
1863         <rdar://problem/13949830>
1864
1865         Reviewed by Alex Christensen.
1866
1867         * Configurations/FeatureDefines.xcconfig:
1868
1869 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1870
1871         Crash when closing tab with debugger paused
1872         https://bugs.webkit.org/show_bug.cgi?id=161746
1873         <rdar://problem/15607819>
1874
1875         Reviewed by Brian Burg and Brent Fulgham.
1876
1877         * WebView/WebView.mm:
1878         (WebKit::DeferredPageDestructor::createDeferredPageDestructor):
1879         (WebKit::DeferredPageDestructor::DeferredPageDestructor):
1880         (WebKit::DeferredPageDestructor::tryDestruction):
1881         (-[WebView _close]):
1882         Defer destruction of the Page if we are in a nested runloop.
1883
1884 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1885
1886         Remove the REQUEST_ANIMATION_FRAME flag
1887         https://bugs.webkit.org/show_bug.cgi?id=156980
1888         <rdar://problem/25906849>
1889
1890         Reviewed by Simon Fraser.
1891
1892         * Configurations/FeatureDefines.xcconfig:
1893
1894 2017-01-16  Andy Estes  <aestes@apple.com>
1895
1896         [QuickLook] Do some cleanup in QuickLookHandle
1897         https://bugs.webkit.org/show_bug.cgi?id=166864
1898
1899         Reviewed by Darin Adler.
1900
1901         * WebCoreSupport/WebFrameLoaderClient.mm:
1902         (WebFrameLoaderClient::didCreateQuickLookHandle): Changed to pass a
1903         Ref<QuickLookHandleClient>&& to QuickLookHandle::setClient().
1904
1905 2017-01-15  Tim Horton  <timothy_horton@apple.com>
1906
1907         De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
1908         https://bugs.webkit.org/show_bug.cgi?id=167063
1909
1910         Reviewed by Dan Bernstein.
1911
1912         * WebView/WebHTMLView.mm:
1913         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1914         (-[WebHTMLView _updateFontPanel]):
1915         * WebView/WebView.mm:
1916         (-[WebView typingAttributes]):
1917         Adjust to fontAttributesForSelectionStart returning a RetainPtr.
1918
1919 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1920
1921         Remove ENABLE(DETAILS_ELEMENT) guards
1922         https://bugs.webkit.org/show_bug.cgi?id=167042
1923
1924         Reviewed by Alex Christensen.
1925
1926         * Configurations/FeatureDefines.xcconfig:
1927
1928 2017-01-11  Darin Adler  <darin@apple.com>
1929
1930         Remove PassRefPtr from more of "platform"
1931         https://bugs.webkit.org/show_bug.cgi?id=166809
1932
1933         Reviewed by Sam Weinig.
1934
1935         * WebCoreSupport/WebFrameLoaderClient.mm:
1936         (NetscapePluginWidget::handleEvent): Pass a reference.
1937         * WebView/WebView.mm:
1938         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
1939         Updated since the children set now contains Ref instead of RefPtr.
1940
1941 2017-01-13  Sam Weinig  <sam@webkit.org>
1942
1943         [WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent
1944         https://bugs.webkit.org/show_bug.cgi?id=167006
1945
1946         Reviewed by Geoffrey Garen.
1947
1948         * WebView/WebDeviceOrientation.mm:
1949         (convert):
1950         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1951         Update for new use of std::optional.
1952
1953 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
1954
1955         Remove unnecessary includes of Page.h
1956         https://bugs.webkit.org/show_bug.cgi?id=166996
1957
1958         Reviewed by Yusuke Suzuki.
1959
1960         * DOM/DOMHTML.mm:
1961         * History/WebBackForwardList.mm:
1962         * Plugins/WebPluginController.mm:
1963         * WebCoreSupport/WebNotificationClient.mm:
1964         * WebCoreSupport/WebPlatformStrategies.mm:
1965         * WebCoreSupport/WebUserMediaClient.mm:
1966         * WebView/WebFullScreenController.mm:
1967
1968 2017-01-12  Chris Dumez  <cdumez@apple.com>
1969
1970         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1971         https://bugs.webkit.org/show_bug.cgi?id=166995
1972
1973         Reviewed by Jer Noble.
1974
1975         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1976         as some people are having trouble building without it.
1977
1978         * Configurations/FeatureDefines.xcconfig:
1979
1980 2017-01-12  Chris Dumez  <cdumez@apple.com>
1981
1982         HTML form validation popover sometimes does not go away
1983         https://bugs.webkit.org/show_bug.cgi?id=166990
1984         <rdar://problem/29985957>
1985
1986         Reviewed by Tim Horton.
1987
1988         Update code using ValidationBubble now that it is RefCounted.
1989
1990         * WebView/WebView.mm:
1991         (-[WebView showFormValidationMessage:withAnchorRect:]):
1992
1993 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1994
1995         Remove pointerLockElement from DOMDocumentPrivate.h
1996         https://bugs.webkit.org/show_bug.cgi?id=166882
1997
1998         Reviewed by Simon Fraser.
1999
2000         Removed pointerLockElement declaration that was supposed to be removed in r209637.
2001
2002         * DOM/DOMDocumentPrivate.h:
2003
2004 2017-01-06  Darin Adler  <darin@apple.com>
2005
2006         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
2007         https://bugs.webkit.org/show_bug.cgi?id=166797
2008
2009         Reviewed by Alex Christensen.
2010
2011         * WebCoreSupport/WebEditorClient.h: Updated to take a reference.
2012         * WebCoreSupport/WebEditorClient.mm:
2013         (WebEditorClient::requestCheckingOfString): Take a reference
2014         instead of a PassRefPtr.
2015
2016 2017-01-05  Chris Dumez  <cdumez@apple.com>
2017
2018         Turn preferLowPowerWebGLRendering setting on by default
2019         https://bugs.webkit.org/show_bug.cgi?id=166737
2020         <rdar://problem/29870033>
2021
2022         Reviewed by Dean Jackson.
2023
2024         Temporarily turn preferLowPowerWebGLRendering setting on by default until
2025         we deal better with WebGL content in background tabs.
2026
2027         * WebView/WebPreferences.mm:
2028         (+[WebPreferences initialize]):
2029
2030 2017-01-05  Enrica Casucci  <enrica@apple.com>
2031
2032         Support File Promise during drag for macOS.
2033         https://bugs.webkit.org/show_bug.cgi?id=165204
2034         rdar://problem/19595567
2035
2036         Reviewed by Tim Horton.
2037
2038         Adds support for dropping a File Promise in a WebView.
2039         The implementation uses new File Promise API available in Sierra.
2040
2041         * Misc/WebNSPasteboardExtras.mm:
2042         (+[NSPasteboard _web_dragTypesForURL]):
2043         * WebView/WebView.mm:
2044         (-[WebView performDragOperation:]):
2045
2046 2017-01-05  Andreas Kling  <akling@apple.com>
2047
2048         Remove ChromeClient::needTouchEvents().
2049         <https://webkit.org/b/166723>
2050
2051         Rubber-stamped by Antti Koivisto.
2052
2053         * WebCoreSupport/WebChromeClient.h:
2054
2055 2017-01-04  Darin Adler  <darin@apple.com>
2056
2057         Remove PassRefPtr use from the "html" directory, other improvements
2058         https://bugs.webkit.org/show_bug.cgi?id=166635
2059
2060         Reviewed by Alex Christensen.
2061
2062         * WebCoreSupport/WebChromeClient.h:
2063         * WebCoreSupport/WebChromeClient.mm:
2064         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
2065
2066 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
2067
2068         Unreviewed, rolling out r210287.
2069
2070         This change caused editing test failures on macOS.
2071
2072         Reverted changeset:
2073
2074         "Support File Promise during drag for macOS."
2075         https://bugs.webkit.org/show_bug.cgi?id=165204
2076         http://trac.webkit.org/changeset/210287
2077
2078 2017-01-04  Enrica Casucci  <enrica@apple.com>
2079
2080         Support File Promise during drag for macOS.
2081         https://bugs.webkit.org/show_bug.cgi?id=165204
2082         rdar://problem/19595567
2083
2084         Reviewed by Tim Horton.
2085
2086         Adds support for dropping a File Promise in a WebView.
2087         The implementation uses new File Promise API available in Sierra.
2088
2089         * Misc/WebNSPasteboardExtras.mm:
2090         (+[NSPasteboard _web_dragTypesForURL]):
2091         * WebView/WebView.mm:
2092         (-[WebView performDragOperation:]):
2093
2094 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2095
2096         Provide a setting for clients to always prefer low-power WebGL
2097         https://bugs.webkit.org/show_bug.cgi?id=166675
2098         <rdar://problem/29834093>
2099
2100         Reviewed by Dan Bernstein.
2101
2102         * WebView/WebPreferenceKeysPrivate.h:
2103         * WebView/WebPreferences.mm:
2104         (+[WebPreferences initialize]):
2105         (-[WebPreferences preferLowPowerWebGLRendering]):
2106         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
2107         * WebView/WebPreferencesPrivate.h:
2108         * WebView/WebView.mm:
2109         (-[WebView _preferencesChanged:]):
2110         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
2111
2112 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2113
2114         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2115         https://bugs.webkit.org/show_bug.cgi?id=166450
2116         <rdar://problem/29447824>
2117
2118         Reviewed by Darin Adler.
2119
2120         * WebCoreSupport/CorrectionPanel.h:
2121         * WebCoreSupport/CorrectionPanel.mm:
2122         (CorrectionPanel::recordAutocorrectionResponse):
2123         (CorrectionPanel::handleAcceptedReplacement):
2124         * WebCoreSupport/WebAlternativeTextClient.mm:
2125         (toCorrectionResponse):
2126         (WebAlternativeTextClient::recordAutocorrectionResponse):
2127         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2128         through recordAutocorrectionResponse, for debugging's sake.
2129         Drop the NSView parameter because we don't need it, just the tag.
2130         Convert the new AutocorrectionResponseType value to its corresponding
2131         NSCorrectionResponse value.
2132
2133 2017-01-01  Jeff Miller  <jeffm@apple.com>
2134
2135         Update user-visible copyright strings to include 2017
2136         https://bugs.webkit.org/show_bug.cgi?id=166278
2137
2138         Reviewed by Dan Bernstein.
2139
2140         * Info.plist:
2141
2142 2016-12-30  Darin Adler  <darin@apple.com>
2143
2144         Remove PassRefPtr use from the "dom" directory, related cleanup
2145         https://bugs.webkit.org/show_bug.cgi?id=166569
2146
2147         Reviewed by Alex Christensen.
2148
2149         * WebCoreSupport/WebFrameLoaderClient.mm:
2150         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
2151         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
2152         (WebFrameLoaderClient::setTitle): Ditto.
2153         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
2154         * WebView/WebFrame.mm:
2155         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
2156         Not needed now, but useful later if we ever can get rid of the explicit constructors.
2157         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
2158         * WebView/WebHTMLRepresentation.mm:
2159         (-[WebHTMLRepresentation title]): Updated to use struct.
2160
2161 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
2162
2163         Propagate the source origin as much as possible
2164         https://bugs.webkit.org/show_bug.cgi?id=166348
2165
2166         Reviewed by Darin Adler.
2167
2168         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2169         (WebKit::NetscapePluginInstanceProxy::evaluate):
2170
2171 2016-12-23  Andy Estes  <aestes@apple.com>
2172
2173         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
2174         https://bugs.webkit.org/show_bug.cgi?id=166471
2175
2176         Reviewed by Andreas Kling.
2177
2178         When DumpRenderTree starts up, it calls
2179         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
2180         builds, this triggers the ASSERT(isMainThread()) in
2181         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
2182         started, we are on the main thread, and we are not holding the Web thread lock. This is
2183         causing all layout tests to crash in the iOS WK1 Debug configuration.
2184
2185         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2186         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
2187
2188 2016-12-22  Andy Estes  <aestes@apple.com>
2189
2190         Make WebCore::EditorInsertAction an enum class
2191         https://bugs.webkit.org/show_bug.cgi?id=166424
2192
2193         Reviewed by Brent Fulgham.
2194
2195         * WebCoreSupport/WebEditorClient.mm:
2196         (kit):
2197
2198 2016-12-21  Beth Dakin  <bdakin@apple.com>
2199
2200         Holding down on candidates in the TouchBar should show panel on screen
2201         https://bugs.webkit.org/show_bug.cgi?id=166367
2202         -and corresponding-
2203         <rdar://problem/28479236>
2204
2205         Reviewed by Tim Horton.
2206
2207         Stray whitespace.
2208         * WebCoreSupport/WebEditorClient.mm:
2209         (WebEditorClient::handleRequestedCandidates):
2210
2211         Call the version of setCandidates: that takes a rect. We need to keep the helper 
2212         function in WK1 (unlike WK2) since we also use it for testing.
2213         * WebView/WebView.mm:
2214         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
2215
2216 2016-12-20  Dean Jackson  <dino@apple.com>
2217
2218         Remove INDIE_UI
2219         https://bugs.webkit.org/show_bug.cgi?id=165881
2220         <rdar://problem/29672532>
2221
2222         Reviewed by Simon Fraser.
2223
2224         The Indie UI work has been discontinued.
2225
2226         * Configurations/FeatureDefines.xcconfig:
2227
2228 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2229
2230         [ES6] Enable ES6 Modules
2231         https://bugs.webkit.org/show_bug.cgi?id=165849
2232
2233         Reviewed by Geoffrey Garen.
2234
2235         * WebView/WebPreferenceKeysPrivate.h:
2236         * WebView/WebPreferences.mm:
2237         (+[WebPreferences initialize]):
2238         (-[WebPreferences es6ModulesEnabled]): Deleted.
2239         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
2240         * WebView/WebPreferencesPrivate.h:
2241         * WebView/WebView.mm:
2242         (-[WebView _preferencesChanged:]):
2243
2244 2016-12-16  Dave Hyatt  <hyatt@apple.com>
2245
2246         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
2247         https://bugs.webkit.org/show_bug.cgi?id=165968
2248
2249         Reviewed by Andreas Kling.
2250
2251         * DOM/DOMCSS.mm:
2252         (kitClass):
2253         * DOM/DOMCSSPrimitiveValue.mm:
2254         (-[DOMCSSPrimitiveValue getCounterValue]):
2255         (-[DOMCSSPrimitiveValue getRectValue]):
2256         (kit):
2257         * DOM/DOMCSSPrimitiveValueInternal.h:
2258         * DOM/DOMCSSStyleDeclaration.mm:
2259         * DOM/DOMCSSValue.mm:
2260         (kit):
2261         * DOM/DOMCSSValueInternal.h:
2262         * DOM/DOMCSSValueList.mm:
2263         * DOM/DOMCounter.mm:
2264         (kit):
2265         * DOM/DOMCounterInternal.h:
2266         * DOM/DOMRGBColor.mm:
2267         (kit):
2268         * DOM/DOMRGBColorInternal.h:
2269         * DOM/DOMRect.mm:
2270         (kit):
2271         * DOM/DOMRectInternal.h:
2272         * DOM/DOMUtility.mm:
2273         (createDOMWrapper):
2274
2275 2016-12-16  Chris Dumez  <cdumez@apple.com>
2276
2277         HTML form validation bubble should be dismissed on navigation
2278         https://bugs.webkit.org/show_bug.cgi?id=165960
2279         <rdar://problem/29668086>
2280
2281         Reviewed by Simon Fraser.
2282
2283         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
2284
2285         * WebView/WebView.mm:
2286         (-[WebView _didStartProvisionalLoadForFrame:]):
2287
2288 2016-12-15  Darin Adler  <darin@apple.com>
2289
2290         Use asString instead of toWTFString, toString, or getString when we already checked isString
2291         https://bugs.webkit.org/show_bug.cgi?id=165895
2292
2293         Reviewed by Yusuke Suzuki.
2294
2295         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2296         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
2297         toWTFString.
2298         * WebView/WebView.mm:
2299         (aeDescFromJSValue): Use asString/value instead of getString.
2300
2301 2016-12-15  Chris Dumez  <cdumez@apple.com>
2302
2303         Make sure HTML validation bubble's state is updated after layout
2304         https://bugs.webkit.org/show_bug.cgi?id=165922
2305         <rdar://problem/29694730>
2306
2307         Reviewed by Simon Fraser.
2308
2309         Make sure HTML validation bubble's state is updated after layout.
2310         In particular, if the validation bubble's associated element has
2311         moved or is no longer visible, we now hide the bubble.
2312
2313         * WebCoreSupport/WebValidationMessageClient.h:
2314         * WebCoreSupport/WebValidationMessageClient.mm:
2315         (WebValidationMessageClient::showValidationMessage):
2316         (WebValidationMessageClient::hideValidationMessage):
2317         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
2318
2319 2016-12-15  Chris Dumez  <cdumez@apple.com>
2320
2321         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
2322         https://bugs.webkit.org/show_bug.cgi?id=165904
2323
2324         Reviewed by Sam Weinig.
2325
2326         Update ObjC bindings so they keep building.
2327
2328         * DOM/DOMUIEvent.mm:
2329         (-[DOMUIEvent keyCode]):
2330         (-[DOMUIEvent charCode]):
2331
2332 2016-12-15  Andreas Kling  <akling@apple.com>
2333
2334         Always clear RenderLayer backing stores when going into page cache.
2335         <https://webkit.org/b/165901>
2336
2337         Reviewed by Simon Fraser.
2338
2339         * WebView/WebView.mm:
2340         (+[WebView _setCacheModel:]):
2341
2342 2016-12-12  Alex Christensen  <achristensen@webkit.org>
2343
2344         Remove unused workaround for Silverlight
2345         https://bugs.webkit.org/show_bug.cgi?id=165773
2346
2347         Reviewed by Dean Jackson.
2348
2349         * Plugins/WebNetscapePluginView.mm:
2350         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
2351         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
2352         Allowing 6 years for users to update Silverlight is more than enough.
2353         Safari doesn't even use WebKit1 for this any more.
2354         I need this to be removed because this is the only non-WebGL code that needs to link against
2355         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
2356
2357 2016-12-12  Chris Dumez  <cdumez@apple.com>
2358
2359         Document.visibilityState should use an IDL string enumeration
2360         https://bugs.webkit.org/show_bug.cgi?id=165774
2361
2362         Reviewed by Daniel Bates.
2363
2364         * DOM/DOMDocument.mm:
2365         (-[DOMDocument visibilityState]):
2366         * WebView/WebView.mm:
2367         (kit):
2368
2369 2016-12-12  Jer Noble  <jer.noble@apple.com>
2370
2371         Remove implementation of legacy Mozilla-based Fullscreen API.
2372         https://bugs.webkit.org/show_bug.cgi?id=165689
2373         <rdar://problem/29603053>
2374
2375         Reviewed by Eric Carlson.
2376
2377         * DOM/DOMElement.mm:
2378         (-[DOMElement webkitRequestFullScreen:]):
2379
2380 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
2381
2382         The DOM should have an advancing wavefront opaque root barrier
2383         https://bugs.webkit.org/show_bug.cgi?id=165712
2384
2385         Reviewed by Yusuke Suzuki.
2386         
2387         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
2388
2389         * Misc/WebCoreStatistics.mm:
2390         (+[WebCoreStatistics javaScriptObjectsCount]):
2391         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
2392         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
2393         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
2394         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
2395         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
2396         (+[WebCoreStatistics shouldPrintExceptions]):
2397         (+[WebCoreStatistics setShouldPrintExceptions:]):
2398         (+[WebCoreStatistics memoryStatistics]):
2399         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
2400         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2401         (identifierFromIdentifierRep):
2402         * Plugins/Hosted/ProxyInstance.mm:
2403         (WebKit::ProxyInstance::getPropertyNames):
2404         * Plugins/WebNetscapePluginStream.mm:
2405         (WebNetscapePluginStream::wantsAllStreams):
2406         * Plugins/WebNetscapePluginView.mm:
2407         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2408         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
2409         (-[WebNetscapePluginView setWindowIfNecessary]):
2410         (-[WebNetscapePluginView createPluginScriptableObject]):
2411         (-[WebNetscapePluginView getFormValue:]):
2412         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
2413         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
2414         (-[WebNetscapePluginView loadPluginRequest:]):
2415         (-[WebNetscapePluginView _printedPluginBitmap]):
2416         * Plugins/WebPluginController.mm:
2417         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2418         (-[WebPluginController stopOnePlugin:]):
2419         (-[WebPluginController stopOnePluginForPageCache:]):
2420         (-[WebPluginController destroyOnePlugin:]):
2421         (-[WebPluginController startAllPlugins]):
2422         (-[WebPluginController addPlugin:]):
2423
2424 2016-12-09  Dave Hyatt  <hyatt@apple.com>
2425
2426         [CSS Parser] Remove the old CSS Parser
2427         https://bugs.webkit.org/show_bug.cgi?id=165645
2428
2429         Reviewed by Daniel Bates.
2430
2431         * DOM/DOMCSS.mm:
2432         (kitClass):
2433         * DOM/DOMCSSRule.h:
2434
2435 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
2436
2437         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
2438         https://bugs.webkit.org/show_bug.cgi?id=165251
2439
2440         Reviewed by Dean Jackson.
2441
2442         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
2443
2444         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
2445         * WebView/WebPreferences.mm:
2446         (+[WebPreferences initialize]):
2447         (-[WebPreferences mediaStreamEnabled]):
2448         (-[WebPreferences setMediaStreamEnabled:]):
2449         (-[WebPreferences peerConnectionEnabled]):
2450         (-[WebPreferences setPeerConnectionEnabled:]):
2451         * WebView/WebPreferencesPrivate.h:
2452         * WebView/WebView.mm:
2453         (-[WebView _preferencesChanged:]):
2454
2455 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
2456
2457         Don’t expose pointer lock in WebKit1 Objective-C API
2458         https://bugs.webkit.org/show_bug.cgi?id=165692
2459
2460         Reviewed by Simon Fraser.
2461
2462         * DOM/DOMDocument.mm:
2463         (-[DOMDocument pointerLockElement]): Deleted.
2464         (-[DOMDocument exitPointerLock]): Deleted.
2465         * DOM/DOMElement.mm:
2466         (-[DOMElement requestPointerLock]): Deleted.
2467         * DOM/DOMMouseEvent.mm:
2468         (-[DOMMouseEvent movementX]): Deleted.
2469         (-[DOMMouseEvent movementY]): Deleted.
2470
2471 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
2472
2473         document.webkitFullscreenElement leaks elements inside a shadow tree
2474         https://bugs.webkit.org/show_bug.cgi?id=158471
2475
2476         Reviewed by Chris Dumez.
2477
2478         Use the API for bindings to avoid exposing nodes inside a shadow tree.
2479
2480         * DOM/DOMDocument.mm:
2481         (-[DOMDocument webkitCurrentFullScreenElement]):
2482         (-[DOMDocument webkitFullscreenElement]):
2483
2484 2016-12-09  Beth Dakin  <bdakin@apple.com>
2485
2486         Password fields should not show the emoji button in TouchBar
2487         https://bugs.webkit.org/show_bug.cgi?id=165673
2488         -and corresponding-
2489         rdar://problem/29235739
2490
2491         Reviewed by Wenson Hsieh.
2492
2493         This patch adds a new ivar for the password touch bar and password 
2494         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
2495         of identifiers than the plain text TouchBar, it should just have its own variable.
2496
2497         The candidate list should be the only item for passwords.
2498         * WebView/WebView.mm:
2499         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
2500
2501         Account for _passwordTextTouchBar.
2502         (-[WebView didChangeAutomaticTextCompletion:]):
2503         (-[WebView setUpTextTouchBar:]):
2504         (-[WebView textTouchBar]):
2505
2506         The empty candidates array is not needed. We can just set @[ ] as the candidates 
2507         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
2508         other parts of the code to prevent us from requesting or setting other candidates 
2509         when in a password field. 
2510         (-[WebView updateTextTouchBar]):
2511
2512         Account for _passwordTextTouchBar.
2513         (-[WebView candidateList]):
2514         * WebView/WebViewData.h:
2515
2516 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
2517
2518         Enable SharedArrayBuffer, remove the flag
2519         https://bugs.webkit.org/show_bug.cgi?id=165614
2520
2521         Rubber stamped by Geoffrey Garen.
2522
2523         * WebView/WebPreferencesPrivate.h:
2524
2525 2016-12-07  Dean Jackson  <dino@apple.com>
2526
2527         Remove runtime toggle for pointer-lock
2528         https://bugs.webkit.org/show_bug.cgi?id=165577
2529         <rdar://problems/29566996>
2530
2531         Reviewed by Jon Lee.
2532
2533         Remove any runtime calls to check if pointer-lock is enabled. It's
2534         either compiled in or out.
2535
2536         * WebView/WebPreferenceKeysPrivate.h:
2537         * WebView/WebPreferences.mm:
2538         (-[WebPreferences pointerLockEnabled]): Deleted.
2539         (-[WebPreferences setPointerLockEnabled:]): Deleted.
2540         * WebView/WebPreferencesPrivate.h:
2541         * WebView/WebView.mm:
2542         (-[WebView _preferencesChanged:]):
2543
2544 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
2545
2546         Correct SDKROOT values in xcconfig files
2547         https://bugs.webkit.org/show_bug.cgi?id=165487
2548         rdar://problem/29539209
2549
2550         Reviewed by Dan Bernstein.
2551
2552         Fix suggested by Dan Bernstein.
2553
2554         * Configurations/DebugRelease.xcconfig:
2555
2556 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
2557
2558         Improve the behavior of scroll-into-view when the target is inside position:fixed
2559         https://bugs.webkit.org/show_bug.cgi?id=165354
2560
2561         Reviewed by Zalan Bujtas.
2562
2563         Plumb through 'insideFixed'. We don't get compute it, so behavior from
2564         these call sites won't change.
2565
2566         * WebView/WebFrame.mm:
2567         (-[WebFrame _scrollDOMRangeToVisible:]):
2568         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2569
2570 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
2571
2572         Enable visual viewports by default on Mac, and iOS Wk2
2573         https://bugs.webkit.org/show_bug.cgi?id=165452
2574
2575         Reviewed by Zalan Bujtas.
2576
2577         Turn visual viewports on by default for WK1 on Mac.
2578
2579         * WebView/WebPreferences.mm:
2580         (+[WebPreferences initialize]):
2581
2582 2016-12-05  Dean Jackson  <dino@apple.com>
2583
2584         pointer lock needs to be feature detectable
2585         https://bugs.webkit.org/show_bug.cgi?id=165426
2586         <rdar://problem/29486715>
2587
2588         Reviewed by Antoine Quint.
2589
2590         Set the RuntimeEnabledFeature as preferences
2591         change.
2592
2593         * WebView/WebView.mm:
2594         (-[WebView _preferencesChanged:]):
2595
2596 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
2597
2598         Unreviewed, rolling out r209299.
2599
2600         This change appears to have caused LayoutTest failures on
2601         Sierra WK1.
2602
2603         Reverted changeset:
2604
2605         "Improve the behavior of scroll-into-view when the target is
2606         inside position:fixed"
2607         https://bugs.webkit.org/show_bug.cgi?id=165354
2608         http://trac.webkit.org/changeset/209299
2609
2610 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
2611
2612         Improve the behavior of scroll-into-view when the target is inside position:fixed
2613         https://bugs.webkit.org/show_bug.cgi?id=165354
2614
2615         Reviewed by Zalan Bujtas.
2616
2617         Plumb through 'insideFixed'. We don't get compute it, so behavior from
2618         these call sites won't change.
2619
2620         * WebView/WebFrame.mm:
2621         (-[WebFrame _scrollDOMRangeToVisible:]):
2622         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2623
2624 2016-12-02  Andy Estes  <aestes@apple.com>
2625
2626         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
2627         https://bugs.webkit.org/show_bug.cgi?id=164492
2628
2629         Reviewed by Dan Bernstein.
2630
2631         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
2632         com.apple.$(PRODUCT_NAME:rfc1034identifier).
2633         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
2634         ${PRODUCT_BUNDLE_IDENTIFIER}.
2635
2636 2016-12-02  Chris Dumez  <cdumez@apple.com>
2637
2638         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
2639         https://bugs.webkit.org/show_bug.cgi?id=165328
2640
2641         Reviewed by Simon Fraser.
2642
2643         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
2644
2645         * WebView/WebViewData.mm:
2646         (-[WebViewPrivate init]):
2647
2648 2016-12-02  Chris Dumez  <cdumez@apple.com>
2649
2650         [Mac][WK1] Implement new HTML interactive form validation user interface
2651         https://bugs.webkit.org/show_bug.cgi?id=164483
2652
2653         Reviewed by Simon Fraser.
2654
2655         Implement new HTML interactive form validation user interface on Mac
2656         WK1 and enable it by default.
2657
2658         * WebCoreSupport/WebValidationMessageClient.h: Added.
2659         * WebCoreSupport/WebValidationMessageClient.mm: Added.
2660         (WebValidationMessageClient::WebValidationMessageClient):
2661         (WebValidationMessageClient::~WebValidationMessageClient):
2662         (WebValidationMessageClient::showValidationMessage):
2663         (WebValidationMessageClient::hideValidationMessage):
2664         (WebValidationMessageClient::isValidationMessageVisible):
2665         * WebView/WebHTMLView.mm:
2666         (-[WebHTMLView _frameOrBoundsChanged]):
2667         * WebView/WebView.mm:
2668         (-[WebView _commonInitializationWithFrameName:groupName:]):
2669         (-[WebView _willStartScrollingOrZooming]):
2670         (-[WebView _contentsOfUserInterfaceItem:]):
2671         (-[WebView _scaleWebView:atOrigin:]):
2672         (-[WebView _didScrollDocumentInFrameView:]):
2673         (-[WebView _setZoomMultiplier:isTextOnly:]):
2674         (-[WebView showFormValidationMessage:withAnchorRect:]):
2675         (-[WebView hideFormValidationMessage]):
2676         * WebView/WebViewData.h:
2677         * WebView/WebViewData.mm:
2678         (-[WebViewPrivate init]):
2679         * WebView/WebViewInternal.h:
2680         * WebView/WebViewPrivate.h:
2681
2682 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
2683
2684         Add a runtime flag for SubtleCrypto
2685         https://bugs.webkit.org/show_bug.cgi?id=164982
2686
2687         Reviewed by Brent Fulgham.
2688
2689         * WebView/WebPreferenceKeysPrivate.h:
2690         * WebView/WebPreferences.mm:
2691         (+[WebPreferences initialize]):
2692         (-[WebPreferences subtleCryptoEnabled]):
2693         (-[WebPreferences setSubtleCryptoEnabled:]):
2694         * WebView/WebPreferencesPrivate.h:
2695         * WebView/WebView.mm:
2696         (-[WebView _preferencesChanged:]):
2697
2698 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
2699
2700         Add separate settings and preferences to enable/disable async decoding for large images and animated images
2701         https://bugs.webkit.org/show_bug.cgi?id=165177
2702
2703         Reviewed by Simon Fraser.
2704         
2705         Hook up the async image decoding settings for WebKit1.
2706
2707         * WebView/WebPreferenceKeysPrivate.h:
2708         * WebView/WebPreferences.mm:
2709         (+[WebPreferences initialize]):
2710         (-[WebPreferences largeImageAsyncDecodingEnabled]):
2711         (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
2712         (-[WebPreferences animatedImageAsyncDecodingEnabled]):
2713         (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
2714         (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
2715         (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
2716         * WebView/WebPreferencesPrivate.h:
2717         * WebView/WebView.mm:
2718         (-[WebView _preferencesChanged:]):
2719
2720 2016-11-29  Andy Estes  <aestes@apple.com>
2721
2722         [Cocoa] Enable two clang warnings recommended by Xcode
2723         https://bugs.webkit.org/show_bug.cgi?id=164498
2724
2725         Reviewed by Mark Lam.
2726
2727         * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
2728
2729 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2730
2731         [WTF] Import std::optional reference implementation as WTF::Optional
2732         https://bugs.webkit.org/show_bug.cgi?id=164199
2733
2734         Reviewed by Saam Barati and Sam Weinig.
2735
2736         Use WTF::Optional::value_or.
2737
2738         * DOM/DOMHTMLOptionsCollection.mm:
2739         (-[DOMHTMLOptionsCollection add:index:]):
2740         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2741         (WebKit::NetscapePluginInstanceProxy::evaluate):
2742         * Plugins/WebNetscapePluginView.mm:
2743         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2744         * WebCoreSupport/WebFrameLoaderClient.h:
2745         * WebCoreSupport/WebFrameLoaderClient.mm:
2746         (WebFrameLoaderClient::dispatchDidCommitLoad):
2747         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2748         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2749         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
2750         (WebPaymentCoordinatorClient::completeShippingContactSelection):
2751         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
2752         * WebCoreSupport/WebSecurityOrigin.mm:
2753         (-[WebSecurityOrigin port]):
2754         * WebView/WebHTMLView.mm:
2755         (toAction):
2756         (toTag):
2757
2758 2016-11-26  Sam Weinig  <sam@webkit.org>
2759
2760         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
2761         https://bugs.webkit.org/show_bug.cgi?id=164965
2762
2763         Reviewed by Simon Fraser.
2764
2765         * WebView/WebPreferenceKeysPrivate.h:
2766         * WebView/WebPreferences.mm:
2767         (-[WebPreferences intersectionObserverEnabled]):
2768         (-[WebPreferences setIntersectionObserverEnabled:]):
2769         * WebView/WebPreferencesPrivate.h:
2770         * WebView/WebView.mm:
2771         (-[WebView _preferencesChanged:]):
2772         Add a preference, defaulting to off, for enabling IntersectionObserver.
2773
2774 2016-11-22  Dan Bernstein  <mitz@apple.com>
2775
2776         [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
2777         https://bugs.webkit.org/show_bug.cgi?id=165036
2778         <rdar://problem/5708580>
2779
2780         Reviewed by Alexey Proskuryakov.
2781
2782         * WebView/WebHTMLView.mm:
2783         (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
2784           similarly to what we do in -keyDown: and to what WKWebView does with all key events.
2785
2786 2016-11-21  Alex Christensen  <achristensen@webkit.org>
2787
2788         Fix Sierra CMake build after r208452
2789         https://bugs.webkit.org/show_bug.cgi?id=164437
2790
2791         * WebView/WebView.mm:
2792         (-[WebView updateMediaTouchBar]):
2793         I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
2794         It's needed for playbackSessionInterface to exist.
2795
2796 2016-11-18  Enrica Casucci  <enrica@apple.com>
2797
2798         Refactor drag and drop for WebKit2 to encode DragData message exchange.
2799         https://bugs.webkit.org/show_bug.cgi?id=164945
2800
2801         Reviewed by Tim Horton.
2802
2803         * WebCoreSupport/WebDragClient.h:
2804         * WebCoreSupport/WebDragClient.mm:
2805         (WebDragClient::actionMaskForDrag):
2806         (WebDragClient::willPerformDragDestinationAction):
2807
2808 2016-11-18  Jeremy Jones  <jeremyj@apple.com>
2809
2810         Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
2811         https://bugs.webkit.org/show_bug.cgi?id=163801
2812
2813         Reviewed by Simon Fraser.
2814
2815         Plumb through PointerLockEnabled setting.
2816
2817         * Configurations/FeatureDefines.xcconfig:
2818         * WebCoreSupport/WebChromeClient.mm:
2819         (WebChromeClient::requestPointerUnlock):
2820         * WebView/WebPreferenceKeysPrivate.h:
2821         * WebView/WebPreferences.mm:
2822         (-[WebPreferences pointerLockEnabled]):
2823         (-[WebPreferences setPointerLockEnabled:]):
2824         * WebView/WebPreferencesPrivate.h:
2825         * WebView/WebView.mm:
2826         (-[WebView _preferencesChanged:]):
2827
2828 2016-11-17  Dan Bernstein  <mitz@apple.com>
2829
2830         Try to fix some non-macOS builds.
2831
2832         * WebView/WebView.mm:
2833
2834 2016-11-16  Dave Hyatt  <hyatt@apple.com>
2835
2836         [CSS Parser] Add @supports, @keyframe and media query parsing options
2837         https://bugs.webkit.org/show_bug.cgi?id=164821
2838
2839         Reviewed by Sam Weinig and Zalan Bujtas.
2840
2841         Fix up the create call now that fallback descriptor syntax is gone.
2842
2843         * DOM/DOM.mm:
2844         (-[DOMHTMLLinkElement _mediaQueryMatches]):
2845
2846 2016-11-17  Saam Barati  <sbarati@apple.com>
2847
2848         Remove async/await compile time flag and enable tests
2849         https://bugs.webkit.org/show_bug.cgi?id=164828
2850         <rdar://problem/28639334>
2851
2852         Reviewed by Yusuke Suzuki.
2853
2854         * Configurations/FeatureDefines.xcconfig:
2855
2856 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2857
2858         [JSC] WTF::TemporaryChange with WTF::SetForScope
2859         https://bugs.webkit.org/show_bug.cgi?id=164761
2860
2861         Reviewed by Saam Barati.
2862
2863         * WebView/WebView.mm:
2864         (-[WebView updateTextTouchBar]):
2865
2866 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2867
2868         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
2869         https://bugs.webkit.org/show_bug.cgi?id=164827
2870
2871         Reviewed by Ryosuke Niwa.
2872
2873         * Configurations/FeatureDefines.xcconfig:
2874         * WebView/WebPreferenceKeysPrivate.h:
2875         * WebView/WebPreferences.mm:
2876         (+[WebPreferences initialize]):
2877         (-[WebPreferences es6ModulesEnabled]):
2878         (-[WebPreferences setES6ModulesEnabled:]):
2879         * WebView/WebPreferencesPrivate.h:
2880         * WebView/WebView.mm:
2881         (-[WebView _preferencesChanged:]):
2882
2883 2016-11-14  Alex Christensen  <achristensen@webkit.org>
2884
2885         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
2886         https://bugs.webkit.org/show_bug.cgi?id=164720
2887
2888         Reviewed by Brady Eidson.
2889
2890         * Storage/WebDatabaseManager.mm:
2891         (-[WebDatabaseManager origins]):
2892         (-[WebDatabaseManager databasesWithOrigin:]):
2893         (-[WebDatabaseManager deleteOrigin:]):
2894         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
2895         * Storage/WebDatabaseManagerClient.h:
2896         * Storage/WebDatabaseManagerClient.mm:
2897         (DidModifyOriginData::dispatchToMainThread):
2898         (DidModifyOriginData::DidModifyOriginData):
2899         (WebDatabaseManagerClient::dispatchDidModifyOrigin):
2900         (WebDatabaseManagerClient::dispatchDidModifyDatabase):
2901         * Storage/WebDatabaseQuotaManager.mm:
2902         (-[WebDatabaseQuotaManager usage]):
2903         (-[WebDatabaseQuotaManager quota]):
2904         (-[WebDatabaseQuotaManager setQuota:]):
2905         * Storage/WebStorageManager.mm:
2906         (-[WebStorageManager origins]):
2907         (-[WebStorageManager deleteOrigin:]):
2908         * Storage/WebStorageTrackerClient.h:
2909         * Storage/WebStorageTrackerClient.mm:
2910         (WebStorageTrackerClient::dispatchDidModifyOrigin):
2911         * WebCoreSupport/WebSecurityOrigin.mm:
2912         (-[WebSecurityOrigin usage]):
2913         (-[WebSecurityOrigin quota]):
2914         (-[WebSecurityOrigin setQuota:]):
2915
2916 2016-11-13  Darin Adler  <darin@apple.com>
2917
2918         Fix exception handling in SQL database code, streamline and update code
2919         https://bugs.webkit.org/show_bug.cgi?id=164685
2920
2921         Reviewed by Sam Weinig.
2922
2923         * Storage/WebDatabaseManager.mm:
2924         (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
2925         a reference.
2926         (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
2927         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
2928         but continue to use DatabaseManager.
2929         (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
2930         reference.
2931         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
2932
2933         * Storage/WebDatabaseManagerClient.h: Updated to take references.
2934         * Storage/WebDatabaseManagerClient.mm:
2935         (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
2936         members in the class definition.
2937         (DidModifyOriginData::dispatchToMainThread): Take references.
2938         (DidModifyOriginData::DidModifyOriginData): Ditto.
2939         (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
2940         (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
2941         (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
2942         DatabaseTracker::singleton instead of tracker.
2943
2944         * Storage/WebDatabaseQuotaManager.mm:
2945         (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
2946         (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
2947         (-[WebDatabaseQuotaManager quota]): Ditto.
2948         (-[WebDatabaseQuotaManager setQuota:]): Ditto.
2949         * WebCoreSupport/WebSecurityOrigin.mm:
2950         (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
2951         (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
2952         (-[WebSecurityOrigin quota]): Ditto.
2953         (-[WebSecurityOrigin setQuota:]): Ditto.
2954         * WebView/WebFrame.mm:
2955         (-[WebFrame _cacheabilityDictionary]): Pass a reference.
2956
2957 2016-11-12  Darin Adler  <darin@apple.com>
2958
2959         Remove a few assorted uses of ExceptionCode
2960         https://bugs.webkit.org/show_bug.cgi?id=164683
2961
2962         Reviewed by Chris Dumez.
2963
2964         * DOM/DOMDOMImplementation.mm:
2965         (-[DOMImplementation createDocumentType:publicId:systemId:]):
2966         Use raiseOnDOMError instead of much longer hand written equivalent.
2967         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2968
2969         * DOM/DOMDocument.mm:
2970         (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
2971         so we are not using a specific exception code.
2972
2973         * DOM/DOMHTMLOptionsCollection.mm:
2974         (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
2975         much longer hand written equivalent.
2976         * DOM/DOMHTMLSelectElement.mm:
2977         (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
2978         statement after calling a "no return" function.
2979
2980         * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
2981         raiseOnDOMError functions that take ExceptionCode; keep the ones that take
2982         Exception and ExceptionOr. Renamed the other overload of raiseDOMException
2983         to raiseDOMErrorException; it is only used as the non-inline implementation
2984         part of the inline raiseOnDOMError function.
2985         * DOM/ExceptionHandlers.mm:
2986         (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
2987         to this source file instead of in the header.
2988         (raiseTypeErrorException): Updated for name change.
2989         (raiseNotSupportedErrorException): Added.
2990
2991 2016-11-11  Ryosuke Niwa  <rniwa@webkit.org>
2992
2993         Hovering over a slotted Text node clears hover state
2994         https://bugs.webkit.org/show_bug.cgi?id=164002
2995         <rdar://problem/29040471>
2996
2997         Reviewed by Simon Fraser.
2998
2999         * WebView/WebImmediateActionController.mm:
3000         (-[WebImmediateActionController performHitTestAtPoint:]):
3001
3002 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3003
3004         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
3005         https://bugs.webkit.org/show_bug.cgi?id=164538
3006         <rdar://problem/8418711>
3007
3008         Reviewed by Ryosuke Niwa.
3009
3010         Account for renaming HTMLElement::autocorrect to HTMLElement::shouldAutocorrect, as well as moving
3011         WebAutocapitalizeType to WebKit from WebCore. Additionally, moves the -autocorrect and -autocapitalize SPIs out
3012         of HTML(Input|Form|TextArea)ElementPrivate.h and into HTMLElementPrivate.h. This also means removing redundant
3013         code for interfacing with the unwrapped HTMLElement's autocorrect and autocapitalize attributes.
3014
3015         * DOM/DOMHTML.mm:
3016         (webAutocapitalizeType):
3017         (-[DOMHTMLInputElement _autocapitalizeType]):
3018         (-[DOMHTMLTextAreaElement _autocapitalizeType]):
3019         * DOM/DOMHTMLElement.mm:
3020         (-[DOMHTMLElement autocorrect]):
3021         (-[DOMHTMLElement setAutocorrect:]):
3022         (-[DOMHTMLElement autocapitalize]):
3023         (-[DOMHTMLElement setAutocapitalize:]):
3024         * DOM/DOMHTMLElementPrivate.h: Copied from Source/WebCore/html/Autocapitalize.h.
3025         * DOM/DOMHTMLFormElement.mm:
3026         (-[DOMHTMLFormElement autocorrect]): Deleted.
3027         (-[DOMHTMLFormElement setAutocorrect:]): Deleted.
3028         (-[DOMHTMLFormElement autocapitalize]): Deleted.
3029         (-[DOMHTMLFormElement setAutocapitalize:]): Deleted.
3030         * DOM/DOMHTMLInputElement.mm:
3031         (-[DOMHTMLInputElement autocorrect]): Deleted.
3032         (-[DOMHTMLInputElement setAutocorrect:]): Deleted.
3033         (-[DOMHTMLInputElement autocapitalize]): Deleted.
3034         (-[DOMHTMLInputElement setAutocapitalize:]): Deleted.
3035         * DOM/DOMHTMLInputElementPrivate.h:
3036         * DOM/DOMHTMLTextAreaElement.mm:
3037         (-[DOMHTMLTextAreaElement autocorrect]): Deleted.
3038         (-[DOMHTMLTextAreaElement setAutocorrect:]): Deleted.
3039         (-[DOMHTMLTextAreaElement autocapitalize]): Deleted.
3040         (-[DOMHTMLTextAreaElement setAutocapitalize:]): Deleted.
3041         * DOM/DOMHTMLTextAreaElementPrivate.h:
3042
3043         We need to import DOMHTMLElementPrivate.h here to avoid breaking UIKit. We should follow this up with a UIKit
3044         change to import DOMHTMLElementPrivate.h directly.
3045
3046         * DOM/DOMPrivate.h:
3047         * DOM/WebAutocapitalizeTypes.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h.
3048         * MigrateHeaders.make:
3049
3050 2016-11-11  Beth Dakin  <bdakin@apple.com>
3051
3052         Move to modern TouchBar methods
3053         https://bugs.webkit.org/show_bug.cgi?id=164655
3054         -and corresponding-
3055         rdar://problem/29226911
3056
3057         Reviewed by Wenson Hsieh.
3058
3059         customizationDefaultItemIdentifiers -> defaultItemIdentifiers
3060         itemIdentifiers -> defaultItemIdentifiers
3061         defaultItems -> templateItems
3062
3063         * WebView/WebView.mm:
3064         (-[WebView _plainTextTouchBarDefaultItemIdentifiers]):
3065         (-[WebView _richTextTouchBarDefaultItemIdentifiers]):
3066         (-[WebView setUpTextTouchBar:]):
3067         (-[WebView updateTextTouchBar]):
3068         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
3069         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
3070
3071 2016-11-11  Darin Adler  <darin@apple.com>
3072
3073         Move Node from ExceptionCode to ExceptionOr
3074         https://bugs.webkit.org/show_bug.cgi?id=164515
3075
3076         Reviewed by Sam Weinig.
3077
3078         * DOM/DOMHTMLSelectElement.mm:
3079         (-[DOMHTMLSelectElement remove:]): Call remove instead of removeByIndex
3080         now that it was renamed.
3081         * DOM/DOMNode.mm:
3082         (-[DOMNode setNodeValue:]): Updated exception handling.
3083         (-[DOMNode setPrefix:]): Ditto.
3084         (-[DOMNode setTextContent:]): Ditto.
3085         (-[DOMNode insertBefore:refChild:]): Ditto.
3086         (-[DOMNode replaceChild:oldChild:]): Ditto.
3087         (-[DOMNode removeChild:]): Ditto.
3088         (-[DOMNode appendChild:]): Ditto.
3089         (-[DOMNode cloneNode:]): Ditto.
3090
3091 2016-11-11  Beth Dakin  <bdakin@apple.com>
3092
3093         Get touch bar code building for open source builds
3094         https://bugs.webkit.org/show_bug.cgi?id=164610
3095
3096         Reviewed by Wenson Hsieh.
3097
3098         * WebKitPrefix.h:
3099
3100 2016-11-10  Alex Christensen  <achristensen@webkit.org>
3101
3102         Fix assertion after r208534.
3103         https://bugs.webkit.org/show_bug.cgi?id=160497
3104
3105         * WebView/WebView.mm:
3106         (-[WebView _commonInitializationWithFrameName:groupName:]):
3107         (WebInstallMemoryPressureHandler):
3108         WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
3109         When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
3110         only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
3111
3112 2016-11-10  Alex Christensen  <achristensen@webkit.org>
3113
3114         Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
3115         https://bugs.webkit.org/show_bug.cgi?id=164573
3116
3117         Reviewed by Brady Eidson.
3118
3119         * WebCoreSupport/WebSecurityOrigin.mm:
3120         (-[WebSecurityOrigin databaseIdentifier]):
3121
3122 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3123
3124         MemoryPressureHandler shouldn't know how to release WebCore memory
3125         https://bugs.webkit.org/show_bug.cgi?id=160497
3126
3127         Reviewed by Michael Catanzaro.
3128
3129         Set the low memory handler before installing the memory pressure handler.
3130
3131         * WebView/WebView.mm:
3132         (-[WebView _commonInitializationWithFrameName:groupName:]):
3133
3134 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
3135
3136         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
3137         https://bugs.webkit.org/show_bug.cgi?id=164501
3138         <rdar://problem/29152282>
3139
3140         Reviewed by Sam Weinig.
3141
3142         Align what [WebHTMLView attributedString] returns to what would be used on copy & paste by using HTMLConverter
3143         instead of _initWithDOMRange in [WebHTMLView _attributeStringFromDOMRange].
3144
3145         * WebView/WebHTMLView.mm:
3146         (-[WebHTMLView _attributedStringFromDOMRange:]): Renamed from _attributeStringFromDOMRange.
3147         (-[WebHTMLView attributedString]):
3148         (-[WebHTMLView selectedAttributedString]):
3149         (-[WebHTMLView selectedString]): Moved to reduce the number of occurrences of the if-defs.
3150
3151 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
3152
3153         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
3154         https://bugs.webkit.org/show_bug.cgi?id=155185
3155         <rdar://problem/11101440>
3156
3157         Reviewed by Brady Eidson.
3158
3159         Provide SPI to access the new quirk for localStorage. The quirk defaults to 'on'. When active, this
3160         quirk says that localStorage access should be granted, without needing to grant universal file access.
3161
3162         If the quirk is turned off, then localStorage is blocked unless the WebKit client explicitly
3163         grants universal file access.
3164
3165         * WebView/WebPreferenceKeysPrivate.h:
3166         * WebView/WebPreferences.mm:
3167         (-[WebPreferences needsLocalStorageQuirk]): Added.
3168         (-[WebPreferences setNeedsLocalStorageQuirk:]): Added.
3169         * WebView/WebPreferencesPrivate.h:
3170         * WebView/WebView.mm:
3171         (-[WebView _preferencesChanged:]): Honor the new localStorage quirk.
3172
3173 2016-11-09  Alex Christensen  <achristensen@webkit.org>
3174
3175         Clean up Storage code
3176         https://bugs.webkit.org/show_bug.cgi?id=164562
3177
3178         Reviewed by Brady Eidson.
3179
3180         * Storage/WebStorageManager.mm:
3181         (-[WebStorageManager origins]):
3182         (-[WebStorageManager deleteAllOrigins]):
3183         (-[WebStorageManager deleteOrigin:]):
3184         (-[WebStorageManager diskUsageForOrigin:]):
3185         (-[WebStorageManager syncLocalStorage]):
3186         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
3187         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
3188         (+[WebStorageManager closeIdleLocalStorageDatabases]):
3189         (WebKitInitializeStorageIfNecessary):
3190         * WebView/WebView.mm:
3191         (+[WebView _applicationWillTerminate]):
3192
3193 2016-11-09  Beth Dakin  <bdakin@apple.com>
3194
3195         Another attempted build fix.
3196
3197         * WebView/WebView.mm:
3198
3199 2016-11-09  Beth Dakin  <bdakin@apple.com>
3200
3201         Attempted build fix.
3202
3203         * WebView/WebView.mm:
3204
3205 2016-11-09  Darin Adler  <darin@apple.com>
3206
3207         Move Range from ExceptionCode to ExceptionOr
3208         https://bugs.webkit.org/show_bug.cgi?id=164457
3209
3210         Reviewed by Alex Christensen.
3211
3212         * DOM/DOMRange.mm:
3213         (-[DOMRange setStart:offset:]): Updated exception handling.
3214         (-[DOMRange setEnd:offset:]): Ditto.
3215         (-[DOMRange setStartBefore:]): Ditto.
3216         (-[DOMRange setStartAfter:]): Ditto.
3217         (-[DOMRange setEndBefore:]): Ditto.
3218         (-[DOMRange setEndAfter:]): Ditto.
3219         (-[DOMRange selectNode:]): Ditto.
3220         (-[DOMRange selectNodeContents:]): Ditto.
3221         (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
3222         (-[DOMRange deleteContents]): Ditto.
3223         (-[DOMRange extractContents]): Ditto.
3224         (-[DOMRange cloneContents]): Ditto.
3225         (-[DOMRange insertNode:]): Ditto.
3226         (-[DOMRange surroundContents:]): Ditto.
3227         (-[DOMRange createContextualFragment:]): Ditto.
3228         (-[DOMRange compareNode:]): Ditto.
3229         (-[DOMRange intersectsNode:]): Ditto.
3230         (-[DOMRange comparePoint:offset:]): Ditto.
3231         (-[DOMRange isPointInRange:offset:]): Ditto.
3232         (-[DOMRange expand:]): Ditto.
3233         * WebView/WebFrame.mm:
3234         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
3235         (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
3236         This function was incorrectly implemented (set both start and end of
3237         the range to the computed start), not declared in any header file,
3238         not used anywhere inside WebKit, and I also could not find a use of it
3239         in outside-WebKit Apple code.
3240         * mac/DOM/DOMUIKitExtensions.mm:
3241         (-[DOMRange move:inDirection:]): Ditto.
3242         (-[DOMRange extend:inDirection:]): Ditto.
3243
3244 2016-11-09  Darin Adler  <darin@apple.com>
3245
3246         Move EventTarget from ExceptionCode to ExceptionOr
3247         https://bugs.webkit.org/show_bug.cgi?id=164465
3248
3249         Reviewed by Youenn Fablet.
3250
3251         * DOM/DOMNode.mm:
3252         (-[DOMNode dispatchEvent:]): Updated exception handling.
3253
3254 2016-11-09  Chris Dumez  <cdumez@apple.com>
3255
3256         [Mac] Stop using deprecated AppKit enumeration values
3257         https://bugs.webkit.org/show_bug.cgi?id=164494
3258
3259         Reviewed by Darin Adler.
3260
3261         Stop using deprecated AppKit enumeration values.
3262
3263         * Carbon/CarbonWindowAdapter.mm:
3264         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3265         (-[CarbonWindowAdapter sendSuperEvent:]):
3266         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3267         (WebKit::NetscapePluginHostProxy::beginModal):
3268         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3269         (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
3270         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3271         (-[WebHostedNetscapePluginView drawRect:]):
3272         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3273         (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
3274         * WebCoreSupport/PopupMenuMac.mm:
3275         (PopupMenuMac::populate):
3276         (PopupMenuMac::show):
3277         * WebCoreSupport/WebContextMenuClient.mm:
3278         (WebContextMenuClient::showContextMenu):
3279         * WebCoreSupport/WebFrameLoaderClient.mm:
3280         (WebFrameLoaderClient::actionDictionary):
3281         * WebCoreSupport/WebInspectorClient.mm:
3282         (WebInspectorFrontendClient::canAttach):
3283         (-[WebInspectorWindowController window]):
3284         * WebInspector/WebNodeHighlight.mm:
3285         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
3286         * WebView/WebFrameView.mm:
3287         (-[WebFrameView keyDown:keyDown:]):
3288         * WebView/WebFullScreenController.mm:
3289         (-[WebFullScreenController init]):
3290         (createBackgroundFullscreenWindow):
3291         * WebView/WebHTMLView.mm:
3292         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
3293         (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
3294         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3295         (isQuickLookEvent):
3296         (-[WebHTMLView hitTest:]):
3297         (-[WebHTMLView _sendToolTipMouseExited]):
3298         (-[WebHTMLView _sendToolTipMouseEntered]):
3299         (mouseEventIsPartOfClickOrDrag):
3300         (-[WebHTMLView _updateMouseoverWithEvent:]):
3301         (-[WebHTMLView _autoscroll]):
3302         (-[WebHTMLView acceptsFirstResponder]):
3303         (-[WebHTMLView viewDidMoveToWindow]):
3304         (-[WebHTMLView mouseDown:mouseDown:]):
3305         (currentKeyboardEvent):
3306         (-[WebHTMLView _handleStyleKeyEquivalent:]):
3307         (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
3308         * WebView/WebPDFView.mm:
3309         (-[WebPDFView hitTest:]):
3310         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3311         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
3312         * WebView/WebTextCompletionController.mm:
3313         (-[WebTextCompletionController _buildUI]):
3314         (-[WebTextCompletionController _placePopupWindow:]):
3315         * WebView/WebView.mm:
3316         (-[WebView applicationFlags:]):
3317
3318 2016-11-09  Beth Dakin  <bdakin@apple.com>
3319
3320         Support TouchBar in WebKit
3321         https://bugs.webkit.org/show_bug.cgi?id=164437
3322         -and corresponding-
3323         rdar://problem/28876524
3324
3325         Reviewed by Darin Adler.
3326
3327         * WebCoreSupport/WebEditorClient.mm:
3328         (WebEditorClient::respondToChangedSelection):
3329         (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
3330         * WebView/WebHTMLView.mm:
3331         (-[WebHTMLView candidateListTouchBarItem]):
3332         * WebView/WebView.mm:
3333         (-[_WebTextListTouchBarViewController initWithWebView:]):
3334         (-[_WebTextListTouchBarViewController _selectList:]):
3335         (-[_WebTextListTouchBarViewController setCurrentListType:]):
3336         (-[WebTextTouchBarItemController initWithWebView:]):
3337         (-[WebTextTouchBarItemController itemForIdentifier:]):
3338         (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
3339         (-[WebTextTouchBarItemController setTextIsBold:]):
3340         (-[WebTextTouchBarItemController setTextIsItalic:]):
3341         (-[WebTextTouchBarItemController setTextIsUnderlined:]):
3342         (-[WebTextTouchBarItemController _webChangeTextStyle:]):
3343         (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
3344         (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
3345         (-[WebTextTouchBarItemController textColor]):
3346         (-[WebTextTouchBarItemController setTextColor:]):
3347         (-[WebTextTouchBarItemController _webChangeColor:]):
3348         (-[WebTextTouchBarItemController textListViewController]):
3349         (-[WebView _commonInitializationWithFrameName:groupName:]):
3350         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3351         (-[WebView shouldRequestCandidates]):
3352         (-[WebView forceRequestCandidatesForTesting]):
3353         (-[WebView makeTouchBar]):
3354         (-[WebView touchBar:makeItemForIdentifier:]):
3355         (textCheckingResultFromNSTextCheckingResult):
3356         (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
3357         (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
3358         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3359         (-[WebView _clearPlaybackControlsManager]):
3360         (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
3361         (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
3362         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
3363         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
3364         (-[WebView touchBarDidExitCustomization:]):
3365         (-[WebView touchBarWillEnterCustomization:]):
3366         (-[WebView didChangeAutomaticTextCompletion:]):
3367         (-[WebView setUpTextTouchBar:]):
3368         (-[WebView _isRichlyEditable]):
3369         (-[WebView textTouchBar]):
3370         (-[WebView updateTextTouchBar]):
3371         (-[WebView updateMediaTouchBar]):
3372         (-[WebView updateTouchBar]):
3373         (-[WebView prepareForMouseDown]):
3374         (-[WebView prepareForMouseUp]):
3375         (-[WebView webViewAdditionsWillDestroyView]):
3376         (-[WebView candidateList]):
3377         (-[WebView updateWebViewAdditions]): Deleted.
3378         * WebView/WebViewData.h:
3379         * WebView/WebViewInternal.h:
3380         * WebView/WebViewPrivate.h:
3381
3382 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3383
3384         Safari does not emit composition end if blurred for dead key / Japanese IME
3385         https://bugs.webkit.org/show_bug.cgi?id=164369
3386         <rdar://problem/29050439>
3387
3388         Reviewed by Ryosuke Niwa.
3389
3390         When canceling a composition, make sure that we clear the system IME state.
3391
3392         * WebCoreSupport/WebEditorClient.h:
3393         * WebCoreSupport/WebEditorClient.mm:
3394         (WebEditorClient::canceledComposition):
3395
3396 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
3397
3398         Add a setting and preferences to enable/disable async image decoding
3399         https://bugs.webkit.org/show_bug.cgi?id=164417
3400
3401         Reviewed by Simon Fraser.
3402
3403         Hook up the asyncImageDecodingEnabled setting for WebKit1.
3404
3405         * WebView/WebPreferenceKeysPrivate.h:
3406         * WebView/WebPreferences.mm:
3407         (+[WebPreferences initialize]):
3408         (-[WebPreferences asyncImageDecodingEnabled]):
3409         (-[WebPreferences setAsyncImageDecodingEnabled:]):
3410         * WebView/WebPreferencesPrivate.h:
3411         * WebView/WebView.mm:
3412         (-[WebView _preferencesChanged:]):
3413
3414 2016-11-01  Alex Christensen  <achristensen@webkit.org>
3415
3416         Remove PassRefPtr from DumpRenderTree
3417         https://bugs.webkit.org/show_bug.cgi?id=164307
3418
3419         Reviewed by Sam Weinig.
3420
3421         * WebView/WebGeolocationPosition.mm:
3422         (-[WebGeolocationPosition initWithGeolocationPosition:]):
3423
3424 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
3425
3426         [Readable Streams API] Enable creation of ReadableByteStreamController
3427         https://bugs.webkit.org/show_bug.cgi?id=164014
3428
3429         Reviewed by Youenn Fablet.
3430
3431         Added flag for the byte stream part of Readable Streams API.
3432
3433         * Configurations/FeatureDefines.xcconfig:
3434
3435 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
3436
3437         Remove CUSTOM_ELEMENTS build flag
3438         https://bugs.webkit.org/show_bug.cgi?id=164267
3439
3440         Reviewed by Antti Koivisto.
3441
3442         Removed the build flag.
3443
3444         * Configurations/FeatureDefines.xcconfig:
3445         * WebView/WebPreferences.mm:
3446         (+[WebPreferences initialize]):
3447         * WebView/WebView.mm:
3448         (-[WebView _preferencesChanged:]):
3449
3450 2016-11-01  Eric Carlson  <eric.carlson@apple.com>
3451
3452         [MediaStream] restrict media capture secure connections
3453         https://bugs.webkit.org/show_bug.cgi?id=164234
3454         <rdar://problem/28944906>
3455
3456         Reviewed by Alex Christensen.
3457
3458         * WebView/WebPreferenceKeysPrivate.h:
3459         * WebView/WebPreferences.mm:
3460         (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
3461         (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
3462         (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
3463         * WebView/WebPreferencesPrivate.h:
3464
3465         * WebView/WebView.mm:
3466         (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
3467
3468 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
3469
3470         JSC should support SharedArrayBuffer
3471         https://bugs.webkit.org/show_bug.cgi?id=163986
3472
3473         Reviewed by Keith Miller.
3474         
3475         Support the RuntimeFlag.
3476
3477         * WebView/WebPreferencesPrivate.h:
3478
3479 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
3480
3481         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
3482         https://bugs.webkit.org/show_bug.cgi?id=164236
3483         <rdar://problem/28747712>
3484
3485         Reviewed by Beth Dakin.
3486
3487         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
3488         dictionary lookup.
3489
3490         * WebCoreSupport/WebEditorClient.mm:
3491         (WebEditorClient::respondToChangedSelection):
3492         * WebView/WebImmediateActionController.mm:
3493         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3494
3495 2016-10-31  Darin Adler  <darin@apple.com>
3496
3497         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
3498         https://bugs.webkit.org/show_bug.cgi?id=164214
3499
3500         Reviewed by Alex Christensen.
3501
3502         * DOM/DOMCSSPrimitiveValue.mm:
3503         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
3504         is a reference now.
3505         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
3506
3507         * DOM/DOMDocument.mm:
3508         (-[DOMDocument querySelector:]): Updated exception handling.
3509         (-[DOMDocument querySelectorAll:]): Ditto.
3510         * DOM/DOMDocumentFragment.mm:
3511         (-[DOMDocumentFragment querySelector:]): Ditto.
3512         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
3513         * DOM/DOMElement.mm:
3514         (-[DOMElement querySelector:]): Ditto.
3515         (-[DOMElement querySelectorAll:]): Ditto.
3516
3517 2016-10-31  Darin Adler  <darin@apple.com>
3518
3519         Convert Document from ExceptionCode to Exception
3520         https://bugs.webkit.org/show_bug.cgi?id=164212
3521
3522         Reviewed by Alex Christensen.
3523
3524         * DOM/DOMDocument.mm:
3525         (-[DOMDocument setXmlVersion:]): Updated exception handling.
3526         (-[DOMDocument cookie]): Ditto.
3527         (-[DOMDocument setCookie:]): Ditto.
3528         (-[DOMDocument setBody:]): Ditto.
3529         (-[DOMDocument createElement:]): Ditto.
3530         (-[DOMDocument createCDATASection:]): Ditto.
3531         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
3532         (-[DOMDocument createAttribute:]): Ditto.
3533         (-[DOMDocument createEntityReference:]): Ditto.
3534         (-[DOMDocument importNode:deep:]): Ditto.
3535         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
3536         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
3537         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
3538         (-[DOMDocument adoptNode:]): Ditto.
3539         (-[DOMDocument createEvent:]): Ditto.
3540
3541 2016-10-30  Darin Adler  <darin@apple.com>
3542
3543         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
3544         https://bugs.webkit.org/show_bug.cgi?id=164206
3545
3546         Reviewed by Chris Dumez.
3547
3548         * DOM/DOMElement.mm:
3549         (-[DOMElement setInnerHTML:]): Updated exception handling.
3550         (-[DOMElement setOuterHTML:]): Ditto.
3551         (-[DOMElement setAttribute:value:]): Ditto.
3552         (-[DOMElement setAttributeNode:]): Ditto.
3553         (-[DOMElement removeAttributeNode:]): Ditto.
3554         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
3555         (-[DOMElement setAttributeNodeNS:]): Ditto.
3556         (-[DOMElement matches:]): Ditto.
3557         (-[DOMElement closest:]): Ditto.
3558         (-[DOMElement webkitMatchesSelector:]): Ditto.
3559         * DOM/DOMHTMLElement.mm:
3560         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
3561         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
3562         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
3563         * DOM/DOMNamedNodeMap.mm:
3564         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
3565         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
3566         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
3567         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
3568
3569 2016-10-29  Darin Adler  <darin@apple.com>
3570
3571         Convert more of DOM from ExceptionCode to Exception
3572         https://bugs.webkit.org/show_bug.cgi?id=164173
3573