bd79babf5d23ed54402a0785adcb01b452167883
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
2
3         Implement and adopt two new TextIndicator presentation animations
4         https://bugs.webkit.org/show_bug.cgi?id=139715
5         <rdar://problem/19237945>
6
7         Reviewed by Anders Carlsson.
8
9         * WebView/WebActionMenuController.mm:
10         (-[WebActionMenuController _showTextIndicator]):
11         * WebView/WebHTMLView.mm:
12         (-[WebHTMLView quickLookWithEvent:]):
13         Remove the completionHandler from text indicator presentation.
14
15         * WebView/WebImmediateActionController.mm:
16         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
17         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
18         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
19         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
20         (-[WebImmediateActionController _menuItemForDataDetectedText]):
21         (-[WebImmediateActionController _animationControllerForText]):
22         (-[WebImmediateActionController _showTextIndicator]):
23         Forward immediate action gesture recognizer animation progress
24         to TextIndicator. Force us to keep the selection when immediate
25         action popovers steal first responder status from the WebView.
26         If the Lookup range is equal to the selection range, use a Crossfade
27         animation; otherwise, use a FadeIn animation.
28
29         * WebView/WebView.mm:
30         (-[WebView _setMaintainsInactiveSelection:]):
31         (-[WebView maintainsInactiveSelection]):
32         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
33         (-[WebView _setTextIndicator:fadeOut:]):
34         (-[WebView _clearTextIndicator]):
35         (-[WebView _setTextIndicatorAnimationProgress:]):
36         (-[WebView _showDictionaryLookupPopup:]):
37         (-[WebView _dictionaryLookupPopoverWillClose:]):
38         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
39         Remove the completionHandler from text indicator presentation.
40         Add a _setMaintainsInactiveSelection, which allows WebKit internals
41         to change the return value of -maintainsInactiveSelection, allowing
42         us to keep the selection alive when the WebView loses first responder status.
43
44         * WebView/WebViewData.h:
45         * WebView/WebViewInternal.h:
46
47 2014-12-16  Andreas Kling  <akling@apple.com>
48
49         Use Ref for SecurityOrigin.
50         <https://webkit.org/b/139710>
51
52         Reviewed by Anders Carlsson.
53
54         * Storage/WebStorageTrackerClient.mm:
55         (WebStorageTrackerClient::dispatchDidModifyOrigin):
56         * WebView/WebView.mm:
57         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
58         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
59
60 2014-12-16  Beth Dakin  <bdakin@apple.com>
61
62         Crash getting default animation controller for some text
63         https://bugs.webkit.org/show_bug.cgi?id=139712
64         -and corresponding-
65         rdar://problem/19271707
66
67         Reviewed by Tim Horton.
68
69         Must null-check the range.
70         * WebView/WebImmediateActionController.mm:
71         (-[WebImmediateActionController _animationControllerForText]):
72
73 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
74
75         Immediate action popovers can get stuck open
76         https://bugs.webkit.org/show_bug.cgi?id=139709
77         <rdar://problem/19270279>
78
79         Reviewed by Beth Dakin.
80
81         * WebView/WebImmediateActionController.mm:
82         (-[WebImmediateActionController _clearImmediateActionState]):
83         Don't clear the animation controller; it breaks things and was unnecessary.
84
85 2014-12-16  Tim Horton  <timothy_horton@apple.com>
86
87         Disable TextIndication for Lookup immediate actions
88         https://bugs.webkit.org/show_bug.cgi?id=139684
89
90         Reviewed by Anders Carlsson.
91
92         * WebView/WebView.mm:
93         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
94
95 2014-12-15  Beth Dakin  <bdakin@apple.com>
96
97         Build fix.
98
99         * WebView/WebImmediateActionController.mm:
100
101 2014-12-15  Beth Dakin  <bdakin@apple.com>
102
103         Speculative build fix.
104
105         * WebView/WebView.mm:
106         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
107         * WebView/WebViewInternal.h:
108
109 2014-12-15  Beth Dakin  <bdakin@apple.com>
110
111         Make lookup an immediate action instead of an action menu item
112         https://bugs.webkit.org/show_bug.cgi?id=139661
113         -and corresponding-
114         rdar://problem/19198414
115
116         Reviewed by Tim Horton.
117
118         Remove the lookup menu items and non-unused static function associated with 
119         lookup.
120         * WebView/WebActionMenuController.mm:
121         (-[WebActionMenuController _defaultMenuItemsForText]):
122         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
123         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
124         (-[WebActionMenuController _createActionMenuItemForTag:]):
125         (-[WebActionMenuController _lookupText:]): Deleted.
126         (performDictionaryLookupForSelection): Deleted.
127         (performDictionaryLookupForRange): Deleted.
128
129         Set the defaultAnimationController to the lookup-provided animation controller 
130         when appropriate.
131         * WebView/WebImmediateActionController.mm:
132         (-[WebImmediateActionController _defaultAnimationController]):
133         (dictionaryPopupInfoForRange):
134         (-[WebImmediateActionController _animationControllerForText]):
135
136         New type.
137         * WebView/WebUIDelegatePrivate.h:
138
139         New function to get the lookup animation controller.
140         * WebView/WebView.mm:
141         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
142         * WebView/WebViewInternal.h:
143
144 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
145
146         Implement Data Detectors immediate actions for Legacy WebKit
147         https://bugs.webkit.org/show_bug.cgi?id=139619
148         <rdar://problem/19198539>
149
150         Reviewed by Beth Dakin.
151
152         * WebView/WebImmediateActionController.mm:
153         (-[WebImmediateActionController _menuItemForDataDetectedText]):
154         Note that this action context is only for immediate actions.
155
156 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
157
158         Addressing post-review comments in r177035
159         https://bugs.webkit.org/show_bug.cgi?id=139557
160
161         Reviewed by Darin Adler.
162
163         * WebView/WebActionMenuController.mm:
164         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
165
166 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
167
168         Implement Data Detectors immediate actions for Legacy WebKit
169         https://bugs.webkit.org/show_bug.cgi?id=139619
170         <rdar://problem/19198539>
171
172         Reviewed by Eric Carlson.
173
174         * WebView/WebHTMLView.mm:
175         (-[WebHTMLView mouseDown:mouseDown:]):
176         Send mouseDown along to the WebImmediateActionController too.
177
178         * WebView/WebImmediateActionController.h:
179         * WebView/WebImmediateActionController.mm:
180         (-[WebImmediateActionController webViewClosed]):
181         (-[WebImmediateActionController webView:willHandleMouseDown:]):
182         (-[WebImmediateActionController _cancelImmediateAction]):
183         (-[WebImmediateActionController _clearImmediateActionState]):
184         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
185         (-[WebImmediateActionController _defaultAnimationController]):
186         (-[WebImmediateActionController _updateImmediateActionItem]):
187         (-[WebImmediateActionController _menuItemForDataDetectedText]):
188         (-[WebImmediateActionController _showTextIndicator]):
189         (-[WebImmediateActionController _hideTextIndicator]):
190         Copy most of the DataDetectors implementation into WebImmediateActionController.
191
192         * WebView/WebUIDelegatePrivate.h:
193         Add a new type.
194
195         * WebView/WebView.mm:
196         (-[WebView _commonInitializationWithFrameName:groupName:]):
197         Temporarily disable action menus.
198
199         (-[WebView _immediateActionController]):
200         * WebView/WebViewInternal.h:
201
202 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
203
204         Delete Notation because we don't use it
205         https://bugs.webkit.org/show_bug.cgi?id=139171
206
207         Reviewed by Kent Tamura.
208
209         * MigrateHeaders.make:
210
211 2014-12-14  Andreas Kling  <akling@apple.com>
212
213         Replace PassRef with Ref/Ref&& across the board.
214         <https://webkit.org/b/139587>
215
216         Reviewed by Darin Adler.
217
218         * WebCoreSupport/WebEditorClient.mm:
219         (WebEditorClient::shouldApplyStyle):
220         * WebCoreSupport/WebVisitedLinkStore.h:
221         * WebCoreSupport/WebVisitedLinkStore.mm:
222         (WebVisitedLinkStore::create):
223
224 2014-12-11  Dan Bernstein  <mitz@apple.com>
225
226         Fix a leak introduced in r177199.
227
228         Reviewed by Anders Carlsson.
229
230         * WebView/WebImmediateActionController.mm:
231         (-[WebImmediateActionController _updateImmediateActionItem]):
232
233 2014-12-11  Beth Dakin  <bdakin@apple.com>
234
235         WK1: Need new SPI for Webkit clients to override default immediate action
236         https://bugs.webkit.org/show_bug.cgi?id=139568
237         -and corresponding-
238         rdar://problem/19225448
239
240         Reviewed by Dan Bernstein.
241
242         Call SPI giving clients a chance to override the default behavior.
243         * WebView/WebImmediateActionController.mm:
244         (-[WebImmediateActionController _updateImmediateActionItem]):
245
246         New SPI.
247         * WebView/WebUIDelegatePrivate.h:
248
249 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
250
251         Move the preview popover to WebImmediateActionController
252         https://bugs.webkit.org/show_bug.cgi?id=139563
253         <rdar://problem/19208291>
254
255         Reviewed by Beth Dakin.
256
257         * WebView/WebActionMenuController.mm:
258         (-[WebActionMenuController _defaultMenuItemsForLink]):
259         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
260         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
261         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
262         * WebView/WebImmediateActionController.h:
263         * WebView/WebImmediateActionController.mm:
264         (-[WebImmediateActionController webViewClosed]):
265         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
266         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
267         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
268         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
269         (-[WebImmediateActionController _updateImmediateActionItem]):
270         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
271         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
272         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
273         Move page preview popover related code to WebImmediateActionController.
274
275         * WebView/WebUIDelegatePrivate.h:
276         Add a link preview type.
277
278         * WebView/WebView.mm:
279         (-[WebView _commonInitializationWithFrameName:groupName:]):
280         Pass the gesture recognizer to the WebImmediateActionController.
281
282 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
283
284         Fix the build.
285
286         * WebView/WebImmediateActionController.h:
287         * WebView/WebImmediateActionController.mm:
288
289 2014-12-11  Anders Carlsson  <andersca@apple.com>
290
291         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
292         https://bugs.webkit.org/show_bug.cgi?id=139547
293
294         Reviewed by Sam Weinig.
295
296         * WebView/WebView.mm:
297         (+[WebView _handleMemoryWarning]):
298
299 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
300
301         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
302         https://bugs.webkit.org/show_bug.cgi?id=139504
303         rdar://problem/19034674
304
305         Reviewed by Enrica Casucci.
306
307         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
308
309         * WebCoreSupport/WebEditorClient.h:
310         * WebCoreSupport/WebEditorClient.mm:
311         (WebEditorClient::discardedComposition):
312
313 2014-12-10  Anders Carlsson  <andersca@apple.com>
314
315         Get rid of the storage strategy
316         https://bugs.webkit.org/show_bug.cgi?id=139519
317
318         Reviewed by Antti Koivisto.
319
320         * WebCoreSupport/WebPlatformStrategies.h:
321         * WebCoreSupport/WebPlatformStrategies.mm:
322         (WebPlatformStrategies::createStorageStrategy): Deleted.
323
324 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
325
326         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
327         https://bugs.webkit.org/show_bug.cgi?id=139529
328         <rdar://problem/19213620>
329
330         Reviewed by Beth Dakin.
331
332         * WebView/WebActionMenuController.mm:
333         (-[WebActionMenuController _copySelection:]):
334         (-[WebActionMenuController _paste:]):
335         Use the copy: and paste: methods on WebView so that we traverse subviews
336         when trying to respond, otherwise these actions don't work in subframes.
337
338 2014-12-10  Beth Dakin  <bdakin@apple.com>
339
340         WK1: Add initial support for immediate actions
341         https://bugs.webkit.org/show_bug.cgi?id=139522
342
343         Reviewed by Dan Bernstein.
344
345         This basic implementation of the controller will use the delegate methods to 
346         perform and cache a HitTest when relevant. Future patches will patch 
347         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
348         immediate action that should be taken.
349         * WebView/WebImmediateActionController.h: Added.
350         * WebView/WebImmediateActionController.mm: Added.
351         (-[WebImmediateActionController webViewClosed]):
352         (-[WebImmediateActionController _clearImmediateActionState]):
353         (-[WebImmediateActionController performHitTestAtPoint:]):
354         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
355         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
356         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
357         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
358         (-[WebImmediateActionController _updateImmediateActionItem]):
359
360         New enum for immediate action types.
361         * WebView/WebUIDelegatePrivate.h:
362
363         Create an NSImmediateActionGestureRecognizer if possible and a controller.
364         * WebView/WebView.mm:
365         (-[WebView _commonInitializationWithFrameName:groupName:]):
366         (-[WebView _close]):
367         * WebView/WebViewData.h:
368         * WebView/WebViewData.mm:
369         (-[WebViewPrivate dealloc]):
370
371 2014-12-08  Anders Carlsson  <andersca@apple.com>
372
373         Use the new storage namespace provider in WebKit1
374         https://bugs.webkit.org/show_bug.cgi?id=139425
375
376         Reviewed by Tim Horton.
377
378         * WebView/WebView.mm:
379         (-[WebView _commonInitializationWithFrameName:groupName:]):
380         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
381         Set the storage namespace provider from the web page group.
382
383 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
384
385         Should have copy and paste items in all text menus
386         https://bugs.webkit.org/show_bug.cgi?id=139510
387         <rdar://problem/19198388>
388
389         Reviewed by Beth Dakin.
390
391         * WebView/WebActionMenuController.mm:
392         (-[WebActionMenuController _defaultMenuItemsForText]):
393         Add a disabled paste menu item into the read-only text menu.
394
395         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
396         Add a disabled copy menu item into the editable whitespace text menu.
397
398 2014-12-10  Anders Carlsson  <andersca@apple.com>
399
400         Add WebStorageNamespaceProvider::closeLocalStorage
401         https://bugs.webkit.org/show_bug.cgi?id=139502
402
403         Reviewed by Tim Horton.
404
405         * WebView/WebView.mm:
406         (+[WebView _applicationWillTerminate]):
407         Call WebStorageNamespaceProvider::closeLocalStorage.
408
409 2014-12-09  Commit Queue  <commit-queue@webkit.org>
410
411         Unreviewed, rolling out r177037.
412         https://bugs.webkit.org/show_bug.cgi?id=139464
413
414         broke ~50 API tests (Requested by thorton on #webkit).
415
416         Reverted changeset:
417
418         "Use the new storage namespace provider in WebKit1"
419         https://bugs.webkit.org/show_bug.cgi?id=139425
420         http://trac.webkit.org/changeset/177037
421
422 2014-12-08  Anders Carlsson  <andersca@apple.com>
423
424         Use the new storage namespace provider in WebKit1
425         https://bugs.webkit.org/show_bug.cgi?id=139425
426
427         Reviewed by Tim Horton.
428
429         * WebView/WebView.mm:
430         (-[WebView _commonInitializationWithFrameName:groupName:]):
431         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
432         Set the storage namespace provider from the web page group.
433
434 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
435
436         Delete Node::boundingBox()
437         https://bugs.webkit.org/show_bug.cgi?id=139333
438
439         Reviewed by Zalan Bujtas.
440
441         * WebView/WebActionMenuController.mm:
442         (elementBoundingBoxInWindowCoordinatesFromNode): Use
443         RenderObject::absoluteBoundingBoxRect().
444
445 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
446
447         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
448         https://bugs.webkit.org/show_bug.cgi?id=138843
449         rdar://problem/18793695
450
451         Reviewed by Dan Bernstein.
452
453         * Panels/WebAuthenticationPanel.m:
454         (-[WebAuthenticationPanel cancel:]):
455         (-[WebAuthenticationPanel logIn:]):
456         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
457         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
458         that only when using an old NSWindow API.
459
460 2014-12-08  Beth Dakin  <bdakin@apple.com>
461
462         Copy and Lookup menu items should be disabled when something is not copyable
463         https://bugs.webkit.org/show_bug.cgi?id=139423
464
465         Reviewed by Tim Horton.
466
467         Disable both lookup and copy when a HitTestResult does not allow copy.
468         * WebView/WebActionMenuController.mm:
469
470         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
471         disable state otherwise.
472         * WebView/WebView.mm:
473         (-[WebView _commonInitializationWithFrameName:groupName:]):
474
475 2014-12-08  Anders Carlsson  <andersca@apple.com>
476
477         Adding user content to a group should force that group to be created
478         https://bugs.webkit.org/show_bug.cgi?id=139421
479         rdar://problem/19180108
480
481         Reviewed by Sam Weinig.
482
483         * WebCoreSupport/WebViewGroup.h:
484         Store the local storage database path in the group.
485
486         * WebCoreSupport/WebViewGroup.mm:
487         (WebViewGroup::getOrCreate):
488         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
489         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
490
491         (WebViewGroup::WebViewGroup):
492         Initialize the new member variable.
493
494         (WebViewGroup::storageNamespaceProvider):
495         Create the namespace provider lazily.
496
497         * WebView/WebView.mm:
498         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
499         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
500         Use getOrCreate instead of get.
501
502 2014-12-08  Anders Carlsson  <andersca@apple.com>
503
504         WebStorageNamespaceProvider should know about its local storage database path
505         https://bugs.webkit.org/show_bug.cgi?id=139413
506
507         Reviewed by Andreas Kling.
508
509         * WebCoreSupport/WebViewGroup.h:
510         * WebCoreSupport/WebViewGroup.mm:
511         (WebViewGroup::getOrCreate):
512         (WebViewGroup::WebViewGroup):
513         * WebView/WebView.mm:
514         (-[WebView _commonInitializationWithFrameName:groupName:]):
515         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
516         (-[WebView setGroupName:]):
517         (-[WebView groupName]): Deleted.
518
519 2014-12-08  Daniel Bates  <dabates@apple.com>
520
521         [iOS] Fix the WebKit build with the public SDK
522
523         Include header NSURLDownloadSPI.h.
524
525         * WebCoreSupport/WebFrameLoaderClient.mm:
526
527 2014-12-07  Dan Bernstein  <mitz@apple.com>
528
529         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
530         https://bugs.webkit.org/show_bug.cgi?id=139348
531
532         Reviewed by Anders Carlsson.
533
534         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
535         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
536         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
537         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
538         avoiding the ambiguity.
539
540         * WebView/WebActionMenuController.mm:
541         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
542
543 2014-12-06  Anders Carlsson  <andersca@apple.com>
544
545         Add a stubbed out version of WebStorageNamespaceProvider
546         https://bugs.webkit.org/show_bug.cgi?id=139213
547
548         Reviewed by Sam Weinig.
549
550         * WebCoreSupport/WebViewGroup.h:
551         (WebViewGroup::storageNamespaceProvider):
552         * WebCoreSupport/WebViewGroup.mm:
553         (WebViewGroup::getOrCreate):
554         (WebViewGroup::WebViewGroup):
555         Give WebViewGroup a storage namespace provider.
556
557 2014-12-06  Anders Carlsson  <andersca@apple.com>
558
559         Fix build with newer versions of clang.
560         rdar://problem/18978687
561
562         Add missing overrides and missing casts.
563
564         * Storage/WebDatabaseManagerClient.h:
565         * Storage/WebStorageTrackerClient.h:
566         * WebCoreSupport/WebChromeClient.h:
567         * WebCoreSupport/WebFrameLoaderClient.h:
568         * WebCoreSupport/WebInspectorClient.h:
569         * WebView/WebDataSource.mm:
570         (-[WebDataSource _makeRepresentation]):
571         * WebView/WebFrameView.mm:
572         (-[WebFrameView _makeDocumentViewForDataSource:]):
573
574 2014-12-05  Tim Horton  <timothy_horton@apple.com>
575
576         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
577         https://bugs.webkit.org/show_bug.cgi?id=139306
578         <rdar://problem/19157955>
579
580         Reviewed by Beth Dakin.
581
582         * WebView/WebView.mm:
583         (-[WebView _commonInitializationWithFrameName:groupName:]):
584         (-[WebView _initWithFrame:frameName:groupName:]):
585         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
586
587 2014-12-05  David Kilzer  <ddkilzer@apple.com>
588
589         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
590         <http://webkit.org/b/139286>
591
592         Reviewed by Daniel Bates.
593
594         * Configurations/FeatureDefines.xcconfig: Switch back to using
595         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
596
597 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
598
599         Fix the 32-bit build.
600
601         * WebView/WebView.mm:
602         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
603
604 2014-12-04  Tim Horton  <timothy_horton@apple.com>
605
606         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
607         https://bugs.webkit.org/show_bug.cgi?id=139252
608         <rdar://problem/19140827>
609
610         Reviewed by Anders Carlsson.
611
612         * WebView/WebView.mm:
613         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
614         Adjust to the WebCore changes.
615
616 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
617
618         Implement action menus for tel: URLs
619         https://bugs.webkit.org/show_bug.cgi?id=139240
620         <rdar://problem/19115662>
621
622         Reviewed by Anders Carlsson.
623
624         * WebView/WebActionMenuController.mm:
625         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
626         Make sure to use the newly created currentActionContext... everywhere.
627
628 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
629
630         Implement action menus for tel: URLs
631         https://bugs.webkit.org/show_bug.cgi?id=139240
632         <rdar://problem/19115662>
633
634         Reviewed by Anders Carlsson.
635
636         * WebView/WebActionMenuController.mm:
637         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
638         Make sure to use the newly created currentActionContext.
639
640 2014-12-03  Beth Dakin  <bdakin@apple.com>
641
642         <input> elements get whitespace action menu instead of editable text menu
643         https://bugs.webkit.org/show_bug.cgi?id=139241
644         -and corresponding-
645         rdar://problem/19072083
646
647         Reviewed by Sam Weinig.
648
649         We should disallow shadow content in the hit test. This is the default and it is 
650         how context menus behave. We originally wanted to text inside shadow content so 
651         that we could find the text, but the new function I added to HitTestResult will 
652         allow that.
653         * WebView/WebActionMenuController.mm:
654         (-[WebActionMenuController performHitTestAtPoint:]):
655
656         Adjust to the fact that we don’t hit test shadow content any more.
657         (-[WebActionMenuController focusAndSelectHitTestResult]):
658
659         Offer the text menus for text inside form controls.
660         (-[WebActionMenuController _defaultMenuItems]):
661
662 2014-12-03  Tim Horton  <timothy_horton@apple.com>
663
664         Implement action menus for tel: URLs
665         https://bugs.webkit.org/show_bug.cgi?id=139240
666         <rdar://problem/19115662>
667
668         Reviewed by Anders Carlsson.
669
670         * WebView/WebActionMenuController.mm:
671         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
672         Rename this function as it will work for both mailto and tel URLs.
673         Adjust it to use contextForView:.
674
675         (-[WebActionMenuController webView:willHandleMouseDown:]):
676         (-[WebActionMenuController prepareForMenu:withEvent:]):
677         (-[WebActionMenuController didCloseMenu:withEvent:]):
678         (-[WebActionMenuController _defaultMenuItems]):
679         Don't check the menu type when going to interact with _currentActionContext.
680         We'll only have a _currentActionContext if we have a data detected item,
681         and there are multiple menu types that end up using DDActionContext.
682
683         * WebView/WebUIDelegatePrivate.h:
684         Add a new type.
685
686 2014-12-03  Anders Carlsson  <andersca@apple.com>
687
688         Set a visited link store when creating a simple WebView
689         https://bugs.webkit.org/show_bug.cgi?id=139234
690         <rdar://problem/19132978>
691
692         Reviewed by Sam Weinig.
693
694         * WebView/WebView.mm:
695         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
696
697 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
698
699         Fix the build.
700
701         * WebCoreSupport/WebFrameLoaderClient.mm:
702
703 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
704
705         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
706         https://bugs.webkit.org/show_bug.cgi?id=139149
707
708         Reviewed by Anders Carlsson.
709
710         This changes API behavior. I think that it's OK, because existing behavior made no sense.
711         We used to delete caches from disk, but they were still active in memory. Now we also
712         obsolete them in memory, so documents that use a cache still work, but new ones don't
713         pick one up.
714
715         * WebCoreSupport/WebApplicationCache.mm:
716         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
717         need to delete in-momry caches too. Keep existing behavior.
718         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
719         that properly deletes caches.
720
721 2014-12-02  Tim Horton  <timothy_horton@apple.com>
722
723         Remove a SnowLeopard-era quirk for QuickLook
724         https://bugs.webkit.org/show_bug.cgi?id=139208
725         <rdar://problem/19121822>
726
727         Reviewed by Alexey Proskuryakov.
728
729         * WebCoreSupport/WebFrameLoaderClient.h:
730         * WebCoreSupport/WebFrameLoaderClient.mm:
731
732 2014-12-02  Tim Horton  <timothy_horton@apple.com>
733
734         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
735         https://bugs.webkit.org/show_bug.cgi?id=139204
736
737         Reviewed by Anders Carlsson.
738
739         * WebView/WebView.mm:
740         (-[WebView _commonInitializationWithFrameName:groupName:]):
741         (-[WebView _showDictionaryLookupPopup:]):
742         * WebView/WebViewData.h:
743         Work around this by delaying the softlinking (and setting up the notification
744         observer) until we actually need it. There's still an underlying bug, but
745         this will fix the test.
746
747 2014-12-02  Beth Dakin  <bdakin@apple.com>
748
749         Yet another build fix.
750
751         * WebView/WebActionMenuController.mm:
752         (-[WebActionMenuController _defaultMenuItemsForLink]):
753
754 2014-12-02  Beth Dakin  <bdakin@apple.com>
755
756         Build fix.
757
758         * WebView/WebActionMenuController.mm:
759         (-[WebActionMenuController _defaultMenuItemsForLink]):
760
761 2014-12-02  Beth Dakin  <bdakin@apple.com>
762
763         More build fixing.
764
765         * WebView/WebActionMenuController.mm:
766         (-[WebActionMenuController _defaultMenuItemsForLink]):
767
768 2014-12-02  Beth Dakin  <bdakin@apple.com>
769
770         Should use standardQuickLookMenuItem for apps that don't implement customizations
771         https://bugs.webkit.org/show_bug.cgi?id=139193
772         -and corresponding-
773         rdar://problem/18944696
774
775         Reviewed by Anders Carlsson.
776
777         Use [NSMenuItem standardQuickLookMenuItem].
778         * WebView/WebActionMenuController.mm:
779         (-[WebActionMenuController _defaultMenuItemsForLink]):
780
781         Delegate methods to set up the standardQuickLookMenuItem.
782         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
783         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
784         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
785
786         Remove all of the old QLPreviewBubble code.
787         (-[WebActionMenuController _createActionMenuItemForTag:]):
788         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
789
790 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
791
792         Fix the build.
793
794         * WebView/WebViewData.h:
795
796 2014-12-02  Tim Horton  <timothy_horton@apple.com>
797
798         Implement Lookup transition from selection for Legacy WebKit
799         https://bugs.webkit.org/show_bug.cgi?id=139180
800         <rdar://problem/19067172>
801
802         Reviewed by Beth Dakin.
803
804         * WebView/DictionaryPopupInfo.h: Added.
805         Split DictionaryPopupInfo out into its own file.
806
807         * WebView/WebActionMenuController.mm:
808         (-[WebActionMenuController _lookupText:]):
809         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
810
811         (performDictionaryLookupForSelection):
812         (performDictionaryLookupForRange):
813         Plumb the transition style through these helpers.
814         Create a TextIndicator from the selection range.
815
816         * WebView/WebHTMLView.mm:
817         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
818         Make use of TextIndicator (and DictionaryPopupInfo, and the new
819         _showDictionaryLookupPopup on WebView) to add a transition from blue
820         when performing Lookup from the context menu.
821
822         (-[WebHTMLView quickLookWithEvent:]):
823         Remove our TextIndicator whenever a normal three-finger-tap event
824         comes through, as it will have its own indication.
825
826         * WebView/WebView.mm:
827         (-[WebView _commonInitializationWithFrameName:groupName:]):
828         (-[WebView _dictionaryLookupPopoverWillClose:]):
829         Register for the LUNotificationPopoverWillClose notification and remove
830         our TextIndicator when it is called, just like in WebKit2.
831         Deregistration is already handled in _close.
832
833         (-[WebView _showDictionaryLookupPopup:]):
834         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
835         if the relevant API is available.
836
837         * WebView/WebViewInternal.h:
838
839 2014-12-02  Anders Carlsson  <andersca@apple.com>
840
841         Remove visited link handling from PageGroup
842         https://bugs.webkit.org/show_bug.cgi?id=139185
843
844         Reviewed by Sam Weinig.
845
846         * History/WebHistory.mm:
847         (-[WebHistoryPrivate removeItemForURLString:]):
848         (-[WebHistoryPrivate removeAllItems]):
849         (+[WebHistory setOptionalSharedHistory:]):
850         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
851         (+[WebHistory _removeAllVisitedLinks]):
852         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
853         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
854         * History/WebHistoryInternal.h:
855         * WebCoreSupport/WebChromeClient.h:
856         * WebCoreSupport/WebChromeClient.mm:
857         (WebChromeClient::populateVisitedLinks): Deleted.
858         * WebView/WebView.mm:
859         (-[WebView addVisitedLinks:]):
860         (-[WebView removeVisitedLink:]):
861
862 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
863
864         Try to fix the Mac build.
865
866         * WebView/WebView.mm:
867         (-[WebView _commonInitializationWithFrameName:groupName:]):
868         (-[WebView _close]):
869
870 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
871
872         Fix the iOS build.
873
874         * WebView/WebActionMenuController.h:
875         * WebView/WebActionMenuController.mm:
876         * WebView/WebHTMLView.mm:
877         (-[WebHTMLView scrollWheel:scrollWheel:]):
878         (-[WebHTMLView mouseDown:mouseDown:]):
879         * WebView/WebView.mm:
880         * WebView/WebViewData.h:
881         * WebView/WebViewData.mm:
882         (-[WebViewPrivate dealloc]):
883         * WebView/WebViewInternal.h:
884
885 2014-12-01  Tim Horton  <timothy_horton@apple.com>
886
887         Implement yellow highlight for WebKit1 data detectors
888         https://bugs.webkit.org/show_bug.cgi?id=138956
889         <rdar://problem/18992185>
890
891         Reviewed by Beth Dakin.
892
893         * WebView/WebActionMenuController.h:
894         * WebView/WebActionMenuController.mm:
895         (-[WebActionMenuController webView:willHandleMouseDown:]):
896         (-[WebActionMenuController webView:didHandleScrollWheel:]):
897         (-[WebActionMenuController prepareForMenu:withEvent:]):
898         (-[WebActionMenuController didCloseMenu:withEvent:]):
899         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
900         (-[WebActionMenuController _showTextIndicator]):
901         (-[WebActionMenuController _hideTextIndicator]):
902         (-[WebActionMenuController _dismissActionMenuPopovers]):
903         Copy the WebKit2 WKActionMenuController TextIndicator implementation
904         into WebActionMenuController. The only significant difference is
905         that we build the TextIndicator right at menu construction time
906         instead of in the Web process.
907
908         * WebView/WebHTMLView.mm:
909         (-[WebHTMLView scrollWheel:]):
910         Let the WebActionMenuController know that we're handling a scroll.
911
912         (-[WebHTMLView mouseDown:]):
913         Let the WebActionMenuController know that we're handling a mouseDown.
914
915         * WebView/WebView.mm:
916         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
917         (-[WebView _clearTextIndicator]):
918         (-[WebView _actionMenuController]):
919         (-[WebView _convertRectFromRootView:]): Deleted.
920         * WebView/WebViewData.h:
921         * WebView/WebViewData.mm:
922         * WebView/WebViewInternal.h:
923         Keep a TextIndicatorWindow on WebView, just like WKView does.
924         Expose the WebActionMenuController on WebView (internally).
925
926 2014-12-01  Anders Carlsson  <andersca@apple.com>
927
928         Remove old site specific quirks code that was added in 2009
929         https://bugs.webkit.org/show_bug.cgi?id=139141
930
931         Reviewed by Antti Koivisto.
932
933         * WebCoreSupport/WebFrameNetworkingContext.h:
934         * WebCoreSupport/WebFrameNetworkingContext.mm:
935         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
936
937 2014-11-30  Anders Carlsson  <andersca@apple.com>
938
939         Fix a test failure.
940
941         * History/WebHistory.mm:
942         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
943         Call through to the visited link store.
944
945         (+[WebHistory _removeAllVisitedLinks]):
946         Ditto.
947
948         * WebCoreSupport/WebVisitedLinkStore.mm:
949         (WebVisitedLinkStore::isLinkVisited):
950         Make sure to populate visited links.
951
952 2014-11-30  Anders Carlsson  <andersca@apple.com>
953
954         Switch over to the visited link store from the WebViewGroup
955         https://bugs.webkit.org/show_bug.cgi?id=139112
956
957         Reviewed by Sam Weinig.
958
959         * WebView/WebView.mm:
960         (-[WebView _commonInitializationWithFrameName:groupName:]):
961         (-[WebView setGroupName:]):
962
963 2014-11-30  Anders Carlsson  <andersca@apple.com>
964
965         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
966         https://bugs.webkit.org/show_bug.cgi?id=139111
967
968         Reviewed by Sam Weinig.
969
970         * WebCoreSupport/WebVisitedLinkStore.h:
971         * WebCoreSupport/WebVisitedLinkStore.mm:
972         (WebVisitedLinkStore::removeVisitedLink):
973         * WebView/WebView.mm:
974         (-[WebView removeVisitedLink:]):
975
976 2014-11-29  Anders Carlsson  <andersca@apple.com>
977
978         Populate visited links
979         https://bugs.webkit.org/show_bug.cgi?id=139101
980
981         Reviewed by Sam Weinig.
982
983         * History/WebHistory.mm:
984         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
985         Helper function that adds all visited link to the given store.
986
987         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
988         Call the private method.
989
990         * History/WebHistoryInternal.h:
991         * WebCoreSupport/WebVisitedLinkStore.h:
992         Add new members.
993
994         * WebCoreSupport/WebVisitedLinkStore.mm:
995         (WebVisitedLinkStore::addVisitedLink):
996         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
997
998         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
999         Implement this. First try the delegate, then try the shared history.
1000
1001         (WebVisitedLinkStore::addVisitedLinkHash):
1002         Factor code that adds the link to the hash table into a separate function.
1003
1004         * WebView/WebView.mm:
1005         (-[WebView addVisitedLinks:]):
1006         Add the visited links to the store.
1007
1008 2014-11-29  Anders Carlsson  <andersca@apple.com>
1009
1010         More work on the legacy WebKit visited link store
1011         https://bugs.webkit.org/show_bug.cgi?id=139100
1012
1013         Reviewed by Sam Weinig.
1014
1015         * History/WebHistory.mm:
1016         (+[WebHistory setOptionalSharedHistory:]):
1017         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
1018
1019         * WebCoreSupport/WebVisitedLinkStore.h:
1020         * WebCoreSupport/WebVisitedLinkStore.mm:
1021         (visitedLinkStores):
1022         (WebVisitedLinkStore::WebVisitedLinkStore):
1023         (WebVisitedLinkStore::~WebVisitedLinkStore):
1024         Keep track of live visited link stores.
1025
1026         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
1027         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
1028
1029         (WebVisitedLinkStore::removeAllVisitedLinks):
1030         Iterate over all live link stores and remove their links.
1031
1032         (WebVisitedLinkStore::isLinkVisited):
1033         Populate visited links and check if our hash table contains the link.
1034
1035         (WebVisitedLinkStore::addVisitedLink):
1036         Add the link hash to the table.
1037
1038         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1039         Add stub.
1040
1041         (WebVisitedLinkStore::removeVisitedLinkHashes):
1042         Clear out the hash table.
1043
1044 2014-11-27  Anders Carlsson  <andersca@apple.com>
1045
1046         Add a stubbed out WebVisitedLinkStore to WebViewGroup
1047         https://bugs.webkit.org/show_bug.cgi?id=139066
1048
1049         Reviewed by Antti Koivisto.
1050
1051         * WebCoreSupport/WebViewGroup.h:
1052         (WebViewGroup::visitedLinkStore):
1053         * WebCoreSupport/WebViewGroup.mm:
1054         (WebViewGroup::WebViewGroup):
1055         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1056         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1057         (WebVisitedLinkStore::create):
1058         (WebVisitedLinkStore::WebVisitedLinkStore):
1059         (WebVisitedLinkStore::~WebVisitedLinkStore):
1060         (WebVisitedLinkStore::isLinkVisited):
1061         (WebVisitedLinkStore::addVisitedLink):
1062
1063 2014-11-25  Anders Carlsson  <andersca@apple.com>
1064
1065         Remove user content handling from PageGroup
1066         https://bugs.webkit.org/show_bug.cgi?id=139051
1067
1068         Reviewed by Antti Koivisto.
1069
1070         Use the user content controller in the web view group.
1071
1072         * WebView/WebView.mm:
1073         (-[WebView _injectOutlookQuirksScript]):
1074
1075 2014-11-25  Anders Carlsson  <andersca@apple.com>
1076
1077         Add a user content controller to WebViewGroup and use it for user content
1078         https://bugs.webkit.org/show_bug.cgi?id=139043
1079
1080         Reviewed by Antti Koivisto.
1081
1082         This is another tiny step towards getting rid of user content handling inside PageGroup.
1083
1084         * WebCoreSupport/WebViewGroup.h:
1085         (WebViewGroup::userContentController):
1086         Add a UserContentController member and getter.
1087
1088         * WebCoreSupport/WebViewGroup.mm:
1089         (WebViewGroup::get):
1090         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
1091
1092         (WebViewGroup::WebViewGroup):
1093         Create a user content controller.
1094
1095         * WebView/WebView.mm:
1096         (-[WebView _commonInitializationWithFrameName:groupName:]):
1097         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
1098         set its user content controller in the PageConfiguration.
1099
1100         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1101         Ditto.
1102
1103         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1104         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1105         (+[WebView _removeUserScriptFromGroup:world:url:]):
1106         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
1107         (+[WebView _removeUserScriptsFromGroup:world:]):
1108         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
1109         (+[WebView _removeAllUserContentFromGroup:]):
1110         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
1111
1112         (-[WebView setGroupName:]):
1113         Set the user content controller to the new WebViewGroup's user content controller.
1114
1115 2014-11-21  Jer Noble  <jer.noble@apple.com>
1116
1117         Support multiple signatures of diagnostic logging.
1118         https://bugs.webkit.org/show_bug.cgi?id=138690
1119
1120         Reviewed by Anders Carlsson.
1121
1122         Page::PageClients has been renamed PageConfiguration.
1123
1124         * WebView/WebView.mm:
1125         (-[WebView _commonInitializationWithFrameName:groupName:]):
1126         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1127
1128 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1129
1130         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1131         https://bugs.webkit.org/show_bug.cgi?id=138981
1132
1133         Reviewed by Simon Fraser.
1134
1135         * WebView/WebPreferenceKeysPrivate.h:
1136         * WebView/WebPreferences.mm:
1137         (+[WebPreferences initialize]):
1138         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
1139         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
1140         * WebView/WebPreferencesPrivate.h:
1141         * WebView/WebView.mm:
1142         (-[WebView _preferencesChanged:]):
1143
1144 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1145
1146         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1147         ​https://bugs.webkit.org/show_bug.cgi?id=138960
1148         <rdar://problem/19056715>
1149
1150         Reviewed by Anders Carlsson.
1151
1152         * WebView/WebActionMenuController.mm:
1153         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1154         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1155         Use DataDetectors SPI instead of an explicit blacklist.
1156
1157 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1158
1159         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1160         https://bugs.webkit.org/show_bug.cgi?id=138960
1161         <rdar://problem/19056715>
1162
1163         Reviewed by Beth Dakin.
1164
1165         * WebView/WebActionMenuController.mm:
1166         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1167         Blacklist contact results, because they don't have useful menus. If we
1168         bail before setting up _currentActionContext, we'll still allow fallthrough
1169         to ordinary text actions, avoiding mysterious failure when a contact is detected.
1170
1171         This doesn't break the case that r176351 was intended to fix,
1172         because in that case we were detecting e.g. addresses.
1173
1174 2014-11-21  Anders Carlsson  <andersca@apple.com>
1175
1176         Remove the Timer parameters from timer callbacks
1177         https://bugs.webkit.org/show_bug.cgi?id=138974
1178
1179         Reviewed by Antti Koivisto.
1180
1181         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1182         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1183         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
1184         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1185         * Plugins/WebNetscapePluginStream.h:
1186         * Plugins/WebNetscapePluginStream.mm:
1187         (WebNetscapePluginStream::WebNetscapePluginStream):
1188         (WebNetscapePluginStream::deliverDataTimerFired):
1189
1190 2014-11-21  Anders Carlsson  <andersca@apple.com>
1191
1192         Make memoryCache() return a reference
1193         https://bugs.webkit.org/show_bug.cgi?id=138939
1194
1195         Reviewed by Antti Koivisto.
1196
1197         * Misc/WebCache.mm:
1198         (+[WebCache statistics]):
1199         (+[WebCache emptyInMemoryResources]):
1200         (+[WebCache sizeOfDeadResources:]):
1201         (+[WebCache addImageToCache:forURL:forFrame:]):
1202         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1203         (+[WebCache imageForURL:]):
1204         (+[WebCache setDisabled:]):
1205         (+[WebCache isDisabled]):
1206         * WebView/WebView.mm:
1207         (+[WebView _setCacheModel:]):
1208
1209 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
1210
1211         Remove the remaining vestiges of minimal-ui
1212         https://bugs.webkit.org/show_bug.cgi?id=138890
1213
1214         Reviewed by Sam Weinig.
1215
1216         * History/WebHistoryItem.mm:
1217         * History/WebHistoryItemPrivate.h:
1218
1219 2014-11-20  Tim Horton  <timothy_horton@apple.com>
1220
1221         Cancel DataDetectors menu earlier if we know it can't be presented
1222         https://bugs.webkit.org/show_bug.cgi?id=138922
1223         <rdar://problem/18950441>
1224
1225         Reviewed by Beth Dakin.
1226
1227         * WebView/WebActionMenuController.mm:
1228         (-[WebActionMenuController prepareForMenu:withEvent:]):
1229         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
1230         and use a bigger hammer (removeAllItems).
1231
1232         (-[WebActionMenuController willOpenMenu:withEvent:]):
1233         If we end up with a menu with no items, don't change selection or anything.
1234
1235 2014-11-20  Beth Dakin  <bdakin@apple.com>
1236
1237         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
1238         https://bugs.webkit.org/show_bug.cgi?id=138568
1239         -and corresponding-
1240         rdar://problem/18904600
1241
1242         Reviewed by Tim Horton.
1243
1244         Skip images for lookup.
1245         * WebView/WebActionMenuController.mm:
1246         (performDictionaryLookupForRange):
1247
1248 2014-11-19  Beth Dakin  <bdakin@apple.com>
1249
1250         Invoking an action menu on a selection should result in the text menu
1251         https://bugs.webkit.org/show_bug.cgi?id=138892
1252         -and corresponding-
1253         rdar://problem/18996776
1254
1255         Reviewed by Tim Horton.
1256
1257         * WebView/WebActionMenuController.mm:
1258         (-[WebActionMenuController _defaultMenuItems]):
1259
1260 2014-11-19  Beth Dakin  <bdakin@apple.com>
1261
1262         Data detected results with no menu items should not fall through to regular text 
1263         action menus
1264         https://bugs.webkit.org/show_bug.cgi?id=138887
1265         -and corresponding-
1266         rdar://problem/18971616
1267
1268         Reviewed by Tim Horton.
1269
1270         * WebView/WebActionMenuController.mm:
1271         (-[WebActionMenuController _defaultMenuItems]):
1272
1273 2014-11-19  Daniel Bates  <dabates@apple.com>
1274
1275         [iOS] Make WebKit build with public iOS SDK
1276         https://bugs.webkit.org/show_bug.cgi?id=136863
1277
1278         Reviewed by David Kilzer.
1279
1280         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
1281         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
1282         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
1283         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
1284         may be used by Apple internal clients that do not include wtf/Platform.h.
1285         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
1286         private Foundation headers directly.
1287         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
1288         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
1289         instead of including private CFNetwork headers directly. Also fixed up style and
1290         ordering of header include directives.
1291         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
1292         CFNetwork headers directly. Also sort the #import directives.
1293         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
1294         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
1295
1296 2014-11-18  David Kilzer  <ddkilzer@apple.com>
1297
1298         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
1299         <http://webkit.org/b/138813>
1300
1301         Reviewed by Mark Rowe.
1302
1303         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
1304         selectors.
1305
1306 2014-11-18  Chris Dumez  <cdumez@apple.com>
1307
1308         Add a setting to toggle DOMTimer throttling support
1309         https://bugs.webkit.org/show_bug.cgi?id=138844
1310         <rdar://problem/19020874>
1311
1312         Reviewed by Andreas Kling.
1313
1314         Add a setting to disable DOM timers throttling, in order to help
1315         developers determine if a specific issue is caused by timer
1316         throttling.
1317
1318         * WebView/WebPreferenceKeysPrivate.h:
1319         * WebView/WebPreferences.mm:
1320         (+[WebPreferences initialize]):
1321         (-[WebPreferences domTimersThrottlingEnabled]):
1322         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
1323         * WebView/WebPreferencesPrivate.h:
1324         * WebView/WebView.mm:
1325         (-[WebView _preferencesChanged:]):
1326
1327 2014-11-18  Tim Horton  <timothy_horton@apple.com>
1328
1329         Avoid re-encoding action menu image data
1330         https://bugs.webkit.org/show_bug.cgi?id=138817
1331         <rdar://problem/18840382>
1332
1333         Reviewed by Anders Carlsson.
1334
1335         * WebView/WebActionMenuController.mm:
1336         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1337         (-[WebActionMenuController _addImageToPhotos:]):
1338         Build a temporary filename from a UUID and the image's desired extension.
1339         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
1340         Build an image menu only if we have an image, URL, data, and extension.
1341
1342 2014-11-18  Daniel Bates  <dabates@apple.com>
1343
1344         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1345         SPI are not available in public SDK
1346         https://bugs.webkit.org/show_bug.cgi?id=138802
1347
1348         Reviewed by David Kilzer.
1349
1350         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1351         libdispatch and MobileGestalt headers directly.
1352
1353         * WebView/WebView.mm:
1354
1355 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
1356
1357         Remove calls to deprecated NSMenu methods
1358         https://bugs.webkit.org/show_bug.cgi?id=138808.
1359
1360         Reviewed by Anders Carlsson.
1361
1362         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
1363
1364         * WebCoreSupport/PopupMenuMac.mm:
1365         (PopupMenuMac::populate):
1366
1367 2014-11-17  Daniel Bates  <dabates@apple.com>
1368
1369         Unreviewed, rolling out r176232.
1370
1371         Broke the Mac build. Will investigate offline.
1372
1373         Reverted changeset:
1374
1375         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
1376         MobileGestalt"
1377         https://bugs.webkit.org/show_bug.cgi?id=138802
1378         http://trac.webkit.org/changeset/176232
1379
1380 2014-11-17  Daniel Bates  <dabates@apple.com>
1381
1382         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1383         SPI are not available in public SDK
1384         https://bugs.webkit.org/show_bug.cgi?id=138802
1385
1386         Reviewed by David Kilzer.
1387
1388         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1389         libdispatch and MobileGestalt headers directly.
1390
1391         * WebView/WebView.mm:
1392
1393 2014-11-17  Beth Dakin  <bdakin@apple.com>
1394
1395         Whitespace action menus should focus the HitTestResult and create an insertion 
1396         point
1397         https://bugs.webkit.org/show_bug.cgi?id=138786
1398         -and corresponding-
1399         rdar://problem/18944893
1400
1401         Reviewed by Tim Horton.
1402
1403         Whitespace menus should cause the HitTestResult to be focused, and they should set 
1404         the selection based on the HitTest location.
1405
1406         * WebView/WebActionMenuController.mm:
1407         (-[WebActionMenuController isMenuForTextContent]):
1408         (-[WebActionMenuController focusAndSelectHitTestResult]):
1409         (-[WebActionMenuController willOpenMenu:withEvent:]):
1410
1411 2014-11-17  Daniel Bates  <dabates@apple.com>
1412
1413         [iOS] QuartzCore SPI not available in public SDK
1414         https://bugs.webkit.org/show_bug.cgi?id=138751
1415
1416         Reviewed by David Kilzer.
1417
1418         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
1419
1420         * WebInspector/WebNodeHighlight.mm:
1421         * WebView/WebIndicateLayer.mm:
1422
1423 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
1424
1425         [iOS] allow host application to opt-out of alternate fullscreen
1426         https://bugs.webkit.org/show_bug.cgi?id=138787
1427
1428         Reviewed by Darin Adler.
1429
1430         * WebView/WebPreferenceKeysPrivate.h:
1431         * WebView/WebPreferences.mm:
1432         (+[WebPreferences initialize]):
1433         (-[WebPreferences allowsAlternateFullscreen]):
1434         (-[WebPreferences setAllowsAlternateFullscreen:]):
1435         * WebView/WebPreferencesPrivate.h:
1436         * WebView/WebView.mm:
1437         (-[WebView _preferencesChanged:]):
1438
1439 2014-11-16  Tim Horton  <timothy_horton@apple.com>
1440
1441         Use TextIndicator instead of the built in Lookup highlight
1442         https://bugs.webkit.org/show_bug.cgi?id=138775
1443         <rdar://problem/18953982>
1444
1445         Reviewed by Anders Carlsson.
1446
1447         * WebCoreSupport/WebSystemInterface.mm:
1448         (InitWebCoreSystemInterface):
1449         Remove a WKSI import.
1450
1451         * WebView/WebActionMenuController.mm:
1452         (-[WebActionMenuController _lookupText:]):
1453         (-[WebActionMenuController _createActionMenuItemForTag:]):
1454         Make use of the new Lookup SPI header.
1455         Disable the Lookup item if lookup is not available.
1456
1457 2014-11-15  Tim Horton  <timothy_horton@apple.com>
1458
1459         Implement data detectors and mailto action menus for WebKit1
1460         https://bugs.webkit.org/show_bug.cgi?id=138765
1461         <rdar://problem/18877535>
1462
1463         Reviewed by Beth Dakin.
1464
1465         * WebView/WebActionMenuController.h:
1466         * WebView/WebActionMenuController.mm:
1467         (-[WebActionMenuController willOpenMenu:withEvent:]):
1468         Tell DataDetectors that the menu is going to open.
1469         Select the text (or not) based on the number of items in the menu, just like WebKit2.
1470
1471         (-[WebActionMenuController didCloseMenu:withEvent:]):
1472         Tell DataDetectors that the menu closed.
1473
1474         (-[WebActionMenuController _defaultMenuItemsForLink]):
1475         Move these checks out of _defaultMenuItemsForLink, because we expect this
1476         to always return a complete link menu.
1477
1478         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1479         Implement. More or less copied from WebKit2.
1480
1481         (-[WebActionMenuController _selectDataDetectedText]):
1482         Select the stashed range.
1483
1484         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1485         Implement. More or less copied from WebKit2.
1486         The yellow highlight isn't hooked up yet.
1487         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
1488
1489         (-[WebActionMenuController _selectLookupText]):
1490         Remove an unnecessary return.
1491
1492         (-[WebActionMenuController _defaultMenuItems]):
1493         Call into the two new menu types.
1494
1495         * WebView/WebUIDelegatePrivate.h:
1496
1497 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
1498
1499         Get rid of WebFontCache
1500         https://bugs.webkit.org/show_bug.cgi?id=134752
1501
1502         Reviewed by Dave Hyatt.
1503
1504         * WebView/WebHTMLView.mm:
1505
1506 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
1507
1508         Update some artwork for the legacy WebKit action menu
1509         https://bugs.webkit.org/show_bug.cgi?id=138758
1510         <rdar://problem/18989840>
1511
1512         * WebView/WebActionMenuController.mm:
1513         (webKitBundleImageNamed): Deleted.
1514         Fix the build.
1515
1516 2014-11-14  Tim Horton  <timothy_horton@apple.com>
1517
1518         Update some artwork for the legacy WebKit action menu
1519         https://bugs.webkit.org/show_bug.cgi?id=138758
1520         <rdar://problem/18989840>
1521
1522         Reviewed by Simon Fraser.
1523
1524         * WebView/WebActionMenuController.mm:
1525         (-[WebActionMenuController _createActionMenuItemForTag:]):
1526
1527 2014-11-14  Daniel Bates  <dabates@apple.com>
1528
1529         [iOS] NSFileManager and QuickLook SPI not available in public SDK
1530         https://bugs.webkit.org/show_bug.cgi?id=138742
1531
1532         Reviewed by Pratik Solanki.
1533
1534         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
1535
1536         * WebCoreSupport/WebFrameLoaderClient.mm:
1537
1538 2014-11-14  Beth Dakin  <bdakin@apple.com>
1539
1540         WK1: Webpage preview can come up in wrong location
1541         https://bugs.webkit.org/show_bug.cgi?id=138747
1542         -and corresponding-
1543         rdar://problem/18979004
1544
1545         Reviewed by Tim Horton.
1546
1547         Converting to window twice is bad.
1548         * WebView/WebActionMenuController.mm:
1549         (elementBoundingBoxInWindowCoordinatesFromNode):
1550         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1551         (elementBoundingBoxFromNode): Deleted.
1552
1553 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
1554
1555         Move FontMac and FontCacheMac off of WKSI
1556         https://bugs.webkit.org/show_bug.cgi?id=138633
1557
1558         Reviewed by Simon Fraser.
1559
1560         * WebCoreSupport/WebSystemInterface.mm:
1561         (InitWebCoreSystemInterface):
1562         * WebKit.order:
1563
1564 2014-11-13  Beth Dakin  <bdakin@apple.com>
1565
1566         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
1567         https://bugs.webkit.org/show_bug.cgi?id=138716
1568         -and corresponding-
1569         rdar://problem/18977222
1570
1571         Reviewed by Tim Horton.
1572
1573         It’s not necessary to use the WebElementDictionary for so many things now that we 
1574         are caching the HitTestResult. We should just use the HitTestResult.
1575
1576         * WebView/WebActionMenuController.mm:
1577         (-[WebActionMenuController prepareForMenu:withEvent:]):
1578         (-[WebActionMenuController _openURLFromActionMenu:]):
1579         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1580         (elementBoundingBoxFromNode):
1581         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1582         (-[WebActionMenuController _defaultMenuItemsForLink]):
1583         (-[WebActionMenuController _defaultMenuItemsForImage]):
1584         (-[WebActionMenuController _defaultMenuItemsForVideo]):
1585         (-[WebActionMenuController _defaultMenuItemsForText]):
1586         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
1587         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
1588         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1589         (-[WebActionMenuController _createActionMenuItemForTag:]):
1590         (-[WebActionMenuController _defaultMenuItems]):
1591         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
1592         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
1593         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
1594         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
1595         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
1596         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
1597         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
1598         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
1599         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
1600         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
1601
1602 2014-11-13  Daniel Bates  <dabates@apple.com>
1603
1604         [iOS] NSGeometry data types are not available in the public SDK
1605         https://bugs.webkit.org/show_bug.cgi?id=137536
1606
1607         Reviewed by David Kilzer.
1608
1609         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
1610         private header.
1611
1612         * DOM/WebDOMOperationsPrivate.h:
1613
1614 2014-11-13  Beth Dakin  <bdakin@apple.com>
1615
1616         WK1: Support default actions for video
1617         https://bugs.webkit.org/show_bug.cgi?id=138713
1618         -and corresponding-
1619         rdar://problem/18877520
1620
1621         Reviewed by Tim Horton.
1622
1623         Call setToNonShadowAncestor() for media HitTestResults.
1624         * WebView/WebActionMenuController.mm:
1625         (-[WebActionMenuController performHitTestAtPoint:]):
1626
1627         Default items and actions.
1628         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
1629         (-[WebActionMenuController _copyVideoURL:]):
1630         (-[WebActionMenuController _saveVideoToDownloads:]):
1631         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1632         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1633         * WebView/WebUIDelegatePrivate.h:
1634
1635 2014-11-13  Tim Horton  <timothy_horton@apple.com>
1636
1637         WK1: Update icon for Add to Reading List
1638         https://bugs.webkit.org/show_bug.cgi?id=138710
1639         <rdar://problem/18975774>
1640
1641         Reviewed by Beth Dakin.
1642
1643         * WebView/WebActionMenuController.mm:
1644         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1645         Use the right icon, matching WebKit2.
1646
1647 2014-11-12  Beth Dakin  <bdakin@apple.com>
1648
1649         WK1: Support default actions for images
1650         https://bugs.webkit.org/show_bug.cgi?id=138668
1651         -and corresponding-
1652         rdar://problem/18785434
1653
1654         Reviewed by Tim Horton.
1655
1656         * WebView/WebActionMenuController.h:
1657         * WebView/WebActionMenuController.mm:
1658         (-[WebActionMenuController didCloseMenu:withEvent:]):
1659         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1660         (-[WebActionMenuController _copyImage:]):
1661         (temporaryPhotosDirectoryPath):
1662         (pathToPhotoOnDisk):
1663         (-[WebActionMenuController _canAddMediaToPhotos]):
1664         (-[WebActionMenuController _addImageToPhotos:]):
1665         (-[WebActionMenuController _saveImageToDownloads:]):
1666         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1667         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
1668         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1669         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1670         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1671         * WebView/WebUIDelegatePrivate.h:
1672
1673 2014-11-11  Beth Dakin  <bdakin@apple.com>
1674
1675         Action menu hit testing is not working properly with all WK1 apps
1676         https://bugs.webkit.org/show_bug.cgi?id=138643
1677         -and corresponding-
1678         rdar://problem/18949376
1679
1680         Reviewed by Tim Horton.
1681
1682         * WebView/WebActionMenuController.mm:
1683         (-[WebActionMenuController prepareForMenu:withEvent:]):
1684         (-[WebActionMenuController _lookupText:]):
1685
1686 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1687
1688         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
1689         https://bugs.webkit.org/show_bug.cgi?id=138623
1690
1691         Reviewed by Geoff Garen.
1692
1693         * WebCoreSupport/WebSystemInterface.mm:
1694         (InitWebCoreSystemInterface):
1695         * WebKit.order:
1696
1697 2014-11-11  Tim Horton  <timothy_horton@apple.com>
1698
1699         Localize strings for action menus
1700         https://bugs.webkit.org/show_bug.cgi?id=138591
1701         <rdar://problem/18815343>
1702
1703         Reviewed by Dan Bates.
1704
1705         * WebView/WebActionMenuController.mm:
1706         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1707         Make use of the new strings.
1708
1709 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1710
1711         Cleanup from r175379
1712         https://bugs.webkit.org/show_bug.cgi?id=138616
1713
1714         Reviewed by Simon Fraser.
1715
1716         * WebCoreSupport/WebSystemInterface.mm:
1717         (InitWebCoreSystemInterface):
1718         * WebKit.order:
1719
1720 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1721
1722         Move CTFontTransformGlyphs out from WKSI
1723         https://bugs.webkit.org/show_bug.cgi?id=138599
1724
1725         Reviewed by Simon Fraser.
1726
1727         * WebCoreSupport/WebSystemInterface.mm:
1728         (InitWebCoreSystemInterface):
1729         * WebKit.order:
1730
1731 2014-11-11  Dan Bernstein  <mitz@apple.com>
1732
1733         More iOS build fix.
1734
1735         * WebView/WebHTMLViewInternal.h:
1736
1737 2014-11-11  Dan Bernstein  <mitz@apple.com>
1738
1739         iOS build fix.
1740
1741         * WebView/WebHTMLView.mm:
1742
1743 2014-11-10  Beth Dakin  <bdakin@apple.com>
1744
1745         WK1: Support default actions for editable text with misspelled word
1746         https://bugs.webkit.org/show_bug.cgi?id=138590
1747         -and corresponding-
1748         rdar://problem/18877506
1749
1750         Reviewed by Tim Horton.
1751
1752         If there are misspelled word suggestions for editable text, create a new type of 
1753         menu with a spelling suggestion sub-menu.
1754
1755         * WebView/WebActionMenuController.mm:
1756         (-[WebActionMenuController isMenuForTextContent]):
1757         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
1758         (-[WebActionMenuController _changeSelectionToSuggestion:]):
1759         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1760         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1761         * WebView/WebHTMLView.mm:
1762         (-[WebHTMLView _changeSpellingToWord:]):
1763         * WebView/WebHTMLViewInternal.h:
1764         * WebView/WebUIDelegatePrivate.h:
1765
1766 2014-11-10  Beth Dakin  <bdakin@apple.com>
1767
1768         WK1: Support default actions for editable whitespace
1769         https://bugs.webkit.org/show_bug.cgi?id=138586
1770         -and corresponding-
1771         rdar://problem/18932048
1772
1773         Reviewed by Tim Horton.
1774
1775         New menu type. Just wants paste.
1776
1777         * WebView/WebActionMenuController.mm:
1778         (-[WebActionMenuController isMenuForTextContent]):
1779         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
1780         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1781         * WebView/WebUIDelegatePrivate.h:
1782
1783 2014-11-10  Beth Dakin  <bdakin@apple.com>
1784
1785         WK1: Support default actions for editable text
1786         https://bugs.webkit.org/show_bug.cgi?id=138580
1787         -and corresponding-
1788         rdar://problem/18877497
1789
1790         Reviewed by Tim Horton.
1791
1792         New menu type, and new action type for paste. 
1793
1794         * WebView/WebActionMenuController.mm:
1795         (-[WebActionMenuController isMenuForTextContent]):
1796         (-[WebActionMenuController willOpenMenu:withEvent:]):
1797         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
1798         (-[WebActionMenuController _paste:]):
1799         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1800         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1801         * WebView/WebUIDelegatePrivate.h:
1802
1803 2014-11-10  Beth Dakin  <bdakin@apple.com>
1804
1805         WK1: Text is getting selected even when an action menu fails to invoke
1806         https://bugs.webkit.org/show_bug.cgi?id=138576
1807         -and corresponding-
1808         rdar://problem/18931330
1809
1810         Reviewed by Tim Horton.
1811
1812         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
1813         * WebView/WebActionMenuController.h:
1814         * WebView/WebActionMenuController.mm:
1815         (-[WebActionMenuController prepareForMenu:withEvent:]):
1816         (-[WebActionMenuController willOpenMenu:withEvent:]):
1817
1818         _selectLookupText no longer needs to return a BOOL indicating success or failure.
1819         (-[WebActionMenuController _selectLookupText]):
1820         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1821
1822         Pass willOpenMenu: on to the controller.
1823         * WebView/WebView.mm:
1824         (-[WebView willOpenMenu:withEvent:]):
1825
1826 2014-11-10  Beth Dakin  <bdakin@apple.com>
1827
1828         Speculative build fix.
1829
1830         * WebView/WebActionMenuController.mm:
1831
1832 2014-11-10  Beth Dakin  <bdakin@apple.com>
1833
1834         Action menu initialization should be moved to _commonInitializationWithFrameName
1835         https://bugs.webkit.org/show_bug.cgi?id=138572
1836         -and corresponding-
1837         rdar://problem/18929733
1838
1839         Reviewed by Tim Horton.
1840
1841         * WebView/WebView.mm:
1842         (-[WebView _commonInitializationWithFrameName:groupName:]):
1843         (-[WebView _initWithFrame:frameName:groupName:]):
1844
1845 2014-11-10  Beth Dakin  <bdakin@apple.com>
1846
1847         WK1: Support default actions for read-only text
1848         https://bugs.webkit.org/show_bug.cgi?id=138552
1849         -and corresponding-
1850         rdar://problem/18877483
1851
1852         Reviewed by Tim Horton.
1853
1854         New WKSystemInterface functions that WebCore needs to use.
1855         * WebCoreSupport/WebSystemInterface.mm:
1856         (InitWebCoreSystemInterface):
1857
1858         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
1859         makes a lot of things easier.
1860         * WebView/WebActionMenuController.h:
1861         * WebView/WebActionMenuController.mm:
1862
1863         Perform the hit test ourselves instead of calling into WebView so that we can more 
1864         easily save the WebCore::HitTestResult for ourselves.
1865         (-[WebActionMenuController performHitTestAtPoint:]):
1866
1867         Clear selection for non-text menus.
1868         (-[WebActionMenuController prepareForMenu:withEvent:]):
1869
1870         Re-set the _type here just to be safe.
1871         (-[WebActionMenuController didCloseMenu:withEvent:]):
1872
1873         Moving this method to be next to the link actions so they can be within a pragma 
1874         mark.
1875         (-[WebActionMenuController _defaultMenuItemsForLink:]):
1876
1877         New method for default text actions — lookup and copy.
1878         (-[WebActionMenuController _defaultMenuItemsForText:]):
1879         (-[WebActionMenuController _copySelection:]):
1880         (-[WebActionMenuController _lookupText:]):
1881
1882         If there is not already a selection, invoking the action menu on text should 
1883         select the lookup text.
1884         (-[WebActionMenuController _selectLookupText]):
1885         (performDictionaryLookupForSelection):
1886         (performDictionaryLookupForRange):
1887
1888         Handle text now.
1889         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1890         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1891
1892         New enum values.
1893         * WebView/WebUIDelegatePrivate.h:
1894
1895         Pass didCloseMenu on to the controller.
1896         * WebView/WebView.mm:
1897         (-[WebView didCloseMenu:withEvent:]):
1898
1899 2014-11-09  Chris Dumez  <cdumez@apple.com>
1900
1901         Add a more correct way to compare floating point numbers and use it
1902         https://bugs.webkit.org/show_bug.cgi?id=138527
1903
1904         Reviewed by Darin Adler.
1905
1906         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
1907         to compare floating-point numbers.
1908
1909         * WebView/WebHTMLView.mm:
1910         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
1911
1912 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1913
1914         Delete cookies between tests
1915         https://bugs.webkit.org/show_bug.cgi?id=138528
1916
1917         Reviewed by Sam Weinig.
1918
1919         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
1920         * WebView/WebPreferencesPrivate.h:
1921         Added an SPI for DumpRenderTree.
1922
1923 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
1924
1925         [iOS] Update optimized fullscreen media controls
1926         https://bugs.webkit.org/show_bug.cgi?id=138493
1927
1928         Reviewed by Brent Fulgham.
1929
1930         * WebCoreSupport/WebSystemInterface.mm:
1931         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
1932
1933 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
1934
1935         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
1936         https://bugs.webkit.org/show_bug.cgi?id=138443
1937
1938         Reviewed by Anders Carlsson.
1939
1940         Wrapping the dealloc method in its own autorelease pool avoids the problem of
1941         complex tear-downs leading to the WebView itself being added to an autorelease
1942         pool that is not drained until after the instance has been dealloc'd.
1943  
1944         * WebView/WebView.mm:
1945         (-[WebView dealloc]):
1946
1947 2014-11-05  Jer Noble  <jer.noble@apple.com>
1948
1949         De-templatize Timer
1950         https://bugs.webkit.org/show_bug.cgi?id=138450
1951
1952         Reviewed by Anders Carlsson.
1953
1954         Remove template specifiers from Timer.
1955
1956         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1957         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1958         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1959         * Plugins/WebNetscapePluginStream.h:
1960         * Plugins/WebNetscapePluginStream.mm:
1961         (WebNetscapePluginStream::deliverDataTimerFired):
1962
1963 2014-11-05  Dan Bernstein  <mitz@apple.com>
1964
1965         Remove the unused deletion UI feature
1966         https://bugs.webkit.org/show_bug.cgi?id=138442
1967
1968         Rubber-stamped by Alexey Proskuryakov.
1969
1970         * DefaultDelegates/WebDefaultEditingDelegate.m:
1971         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
1972         * WebCoreSupport/WebEditorClient.h:
1973         * WebCoreSupport/WebEditorClient.mm:
1974         (WebEditorClient::shouldShowDeleteInterface): Deleted.
1975         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
1976         -webView:shouldShowDeleteInterfaceForElement:.
1977
1978 2014-11-03  Dean Jackson  <dino@apple.com>
1979
1980         Add ENABLE_FILTERS_LEVEL_2 feature guard.
1981         https://bugs.webkit.org/show_bug.cgi?id=138362
1982
1983         Reviewed by Tim Horton.
1984
1985         Add a new feature define for Level 2 of CSS Filters.
1986         http://dev.w3.org/fxtf/filters-2/
1987
1988         * Configurations/FeatureDefines.xcconfig:
1989
1990 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
1991
1992         Add button and enable optimized fullscreen.
1993         https://bugs.webkit.org/show_bug.cgi?id=138351
1994
1995         Reviewed by Eric Carlson.
1996
1997         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
1998
1999         * WebCoreSupport/WebSystemInterface.mm:
2000         (InitWebCoreSystemInterface): added
2001
2002 2014-11-04  Chris Dumez  <cdumez@apple.com>
2003
2004         Add ptr() method to Ref class
2005         https://bugs.webkit.org/show_bug.cgi?id=138361
2006
2007         Reviewed by Darin Adler.
2008
2009         Use the new Ref::ptr() method.
2010
2011         * WebView/WebFrame.mm:
2012         (-[WebFrame _setTypingStyle:withUndoAction:]):
2013         * WebView/WebHTMLView.mm:
2014         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2015         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2016         * WebView/WebView.mm:
2017         (-[WebView applyStyle:]):
2018
2019 2014-11-04  Darin Adler  <darin@apple.com>
2020
2021         Eliminate ResourceBuffer and use SharedBuffer directly instead
2022         https://bugs.webkit.org/show_bug.cgi?id=138174
2023
2024         Reviewed by Antti Koivisto.
2025
2026         * WebView/WebDataSource.mm:
2027         (-[WebDataSource data]): Use SharedBuffer directly.
2028         * WebView/WebHTMLView.mm:
2029         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2030
2031 2014-11-03  Commit Queue  <commit-queue@webkit.org>
2032
2033         Unreviewed, rolling out r175406, r175413, and r175423.
2034         https://bugs.webkit.org/show_bug.cgi?id=138327
2035
2036         Multipart tests are still broken (Requested by ap on #webkit).
2037
2038         Reverted changesets:
2039
2040         "Eliminate ResourceBuffer and use SharedBuffer directly
2041         instead"
2042         https://bugs.webkit.org/show_bug.cgi?id=138174
2043         http://trac.webkit.org/changeset/175406
2044
2045         "Unreviewed, iOS build fix since 175406."
2046         http://trac.webkit.org/changeset/175413
2047
2048         "Fix assertion in CachedResource::addDataBuffer"
2049         http://trac.webkit.org/changeset/175423
2050
2051 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2052
2053         Use std::unique_ptr for TypeCountSet
2054         https://bugs.webkit.org/show_bug.cgi?id=138242
2055
2056         Reviewed by Andreas Kling.
2057
2058         * Misc/WebCoreStatistics.mm:
2059         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
2060         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
2061
2062 2014-10-31  Beth Dakin  <bdakin@apple.com>
2063
2064         Use system art for action menus when possible
2065         https://bugs.webkit.org/show_bug.cgi?id=138260
2066
2067         Reviewed by Tim Horton.
2068
2069         * WebView/WebActionMenuController.mm:
2070         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2071
2072 2014-10-30  Darin Adler  <darin@apple.com>
2073
2074         Eliminate ResourceBuffer and use SharedBuffer directly instead
2075         https://bugs.webkit.org/show_bug.cgi?id=138174
2076
2077         Reviewed by Antti Koivisto.
2078
2079         * WebView/WebDataSource.mm:
2080         (-[WebDataSource data]): Use SharedBuffer directly.
2081         * WebView/WebHTMLView.mm:
2082         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2083
2084 2014-10-30  Jer Noble  <jer.noble@apple.com>
2085
2086         [EME] Add Setting for accessing storage location for MediaKeys data
2087         https://bugs.webkit.org/show_bug.cgi?id=138147
2088
2089         Reviewed by Brady Eidson.
2090
2091         * WebView/WebPreferenceKeysPrivate.h:
2092         * WebView/WebPreferences.mm:
2093         (+[WebPreferences initialize]): Set default location.
2094         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
2095         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
2096         * WebView/WebPreferencesPrivate.h:
2097         * WebView/WebView.mm:
2098         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
2099
2100 2014-10-30  Dana Burkart  <dburkart@apple.com>
2101
2102         <rdar://problem/18821260> Prepare for the mysterious future
2103
2104         Reviewed by Lucas Forschler.
2105
2106         * Configurations/Base.xcconfig:
2107         * Configurations/DebugRelease.xcconfig:
2108         * Configurations/FeatureDefines.xcconfig:
2109         * Configurations/Version.xcconfig:
2110
2111 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
2112
2113         Add optimized fullscreen mode.
2114         https://bugs.webkit.org/show_bug.cgi?id=138044
2115
2116         Reviewed by Jer Noble.
2117
2118         Enable different types of fullscreen video behavior.
2119         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
2120
2121         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
2122         * WebCoreSupport/WebChromeClient.mm:
2123         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
2124         * WebView/WebView.mm:
2125         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
2126         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
2127         * WebView/WebViewInternal.h: ditto
2128
2129 2014-10-27  Beth Dakin  <bdakin@apple.com>
2130
2131         Provide a way for WebKit1 clients to override default action menu items
2132         https://bugs.webkit.org/show_bug.cgi?id=138066
2133         -and corresponding-
2134         rdar://problem/18451638
2135
2136         Reviewed by Anders Carlsson.
2137
2138         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
2139         send that along to clients customizing the menu.
2140         * WebView/WebActionMenuController.h:
2141         * WebView/WebActionMenuController.mm:
2142         (-[WebActionMenuController prepareForMenu:withEvent:]):
2143         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2144
2145         New enum and new SPI to customize menus.
2146         * WebView/WebUIDelegatePrivate.h:
2147
2148 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
2149
2150         Fix the iOS build
2151
2152         * Configurations/WebKitLegacy.xcconfig:
2153         * WebView/WebView.mm:
2154
2155 2014-10-24  Beth Dakin  <bdakin@apple.com>
2156
2157         Build fix.
2158
2159         * WebView/WebActionMenuController.mm:
2160         (-[WebActionMenuController _openURLFromActionMenu:]):
2161         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2162         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2163
2164 2014-10-24  Beth Dakin  <bdakin@apple.com>
2165
2166         WebKit1 should support action menus
2167         https://bugs.webkit.org/show_bug.cgi?id=138032
2168
2169         Reviewed by Tim Horton.
2170
2171         This patch adds basic support for action menus and adds actions for links.
2172
2173         Helper class takes care of all of the action menu work. WebView will forward the 
2174         prepareForMenu: message, and then the helper class takes it from there.
2175         * WebView/WebActionMenuController.h: Added.
2176         * WebView/WebActionMenuController.mm: Added.
2177         (-[WebActionMenuController webViewClosed]):
2178         (-[WebActionMenuController prepareForMenu:withEvent:]):
2179
2180         Selectors for link actions.
2181         (-[WebActionMenuController _openURLFromActionMenu:]):
2182         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2183         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
2184         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2185         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2186         (webKitBundleImageNamed):
2187         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2188         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2189
2190         Tags for the action menu items.
2191         * WebView/WebUIDelegatePrivate.h:
2192         * WebView/WebView.mm:
2193
2194         Set the action menu if possible and create the controller.
2195         (-[WebView _initWithFrame:frameName:groupName:]):
2196         (-[WebView _close]):
2197         (-[WebView prepareForMenu:withEvent:]):
2198
2199         WebViewData stores the WebActionMenuHelper
2200         * WebView/WebViewData.h:
2201         * WebView/WebViewData.mm:
2202         (-[WebViewPrivate dealloc]):
2203
2204 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
2205
2206         Web Inspector: Provide a way to have alternate inspector agents
2207         https://bugs.webkit.org/show_bug.cgi?id=137901
2208
2209         Reviewed by Brian Burg.
2210
2211         * Configurations/FeatureDefines.xcconfig:
2212
2213 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2214
2215         Add some SPI headers for NSExtension and NSSharingService{Picker}
2216         https://bugs.webkit.org/show_bug.cgi?id=138027
2217
2218         Reviewed by Anders Carlsson.
2219
2220         * Misc/WebSharingServicePickerController.h:
2221         * Misc/WebSharingServicePickerController.mm:
2222         * WebCoreSupport/WebSelectionServiceController.mm:
2223         * WebCoreSupport/WebContextMenuClient.mm:
2224         Fix a sorting issue.
2225         Replace redefinitions with SPI header #imports.
2226
2227 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2228
2229         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
2230         https://bugs.webkit.org/show_bug.cgi?id=138013
2231
2232         Reviewed by Dan Bernstein.
2233
2234         * WebCoreSupport/WebSelectionServiceController.mm:
2235         (WebSelectionServiceController::hasRelevantSelectionServices):
2236         Don't adopt this autoreleased object.
2237
2238 2014-10-22  Chris Dumez  <cdumez@apple.com>
2239
2240         [Mac][WK2] Fix applicationIsSafari() detection
2241         https://bugs.webkit.org/show_bug.cgi?id=137893
2242
2243         Reviewed by Alexey Proskuryakov.
2244
2245         Provide an implementation for FrameLoaderClient's new
2246         needsQuickLookResourceCachingQuirks() that returns
2247         a static flag initialized using
2248         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
2249
2250         * WebCoreSupport/WebFrameLoaderClient.h:
2251         * WebCoreSupport/WebFrameLoaderClient.mm:
2252
2253 2014-10-20  Chris Dumez  <cdumez@apple.com>
2254
2255         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
2256         https://bugs.webkit.org/show_bug.cgi?id=137797
2257
2258         Reviewed by Darin Adler.
2259
2260         Call ResourceRequest::setDomainForPartitionName() instead of
2261         setPartitionName() as the argument is a domain, not a valid
2262         partition name.
2263
2264         * Misc/WebCache.mm:
2265         (+[WebCache addImageToCache:forURL:forFrame:]):
2266         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2267
2268 2014-10-20  Andy Estes  <aestes@apple.com>
2269
2270         Fix the iOS build.
2271
2272         * WebView/WebFrame.mm:
2273         (-[WebFrame getDictationResultRanges:andMetadatas:]):
2274         (-[WebFrame dictationResultMetadataForRange:]):
2275
2276 2014-10-19  Chris Dumez  <cdumez@apple.com>
2277
2278         Use is<>() / downcast<>() for all remaining RenderObject subclasses
2279         https://bugs.webkit.org/show_bug.cgi?id=137845
2280
2281         Reviewed by Darin Adler.
2282
2283         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
2284         clean up the surrounding code.
2285
2286         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2287         (-[WebHostedNetscapePluginView pluginHostDied]):
2288         * Plugins/WebBaseNetscapePluginView.mm:
2289         (-[WebBaseNetscapePluginView _windowClipRect]):
2290         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
2291         * WebCoreSupport/WebFrameLoaderClient.mm:
2292         (WebFrameLoaderClient::createPlugin):
2293         (WebFrameLoaderClient::createJavaAppletWidget):
2294
2295 2014-10-17  Tim Horton  <timothy_horton@apple.com>
2296
2297         Build fix for 32-bit Yosemite
2298
2299         * WebCoreSupport/WebContextMenuClient.mm:
2300         (WebContextMenuClient::contextMenuForEvent):
2301         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
2302
2303 2014-10-17  Chris Dumez  <cdumez@apple.com>
2304
2305         Use is<>() / downcast<>() for RenderBox
2306         https://bugs.webkit.org/show_bug.cgi?id=137804
2307
2308         Reviewed by Andreas Kling.
2309
2310         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
2311         code.
2312
2313         * WebCoreSupport/WebContextMenuClient.mm:
2314         (WebContextMenuClient::clientFloatRectForNode):
2315         * WebView/WebFrame.mm:
2316         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
2317
2318 2014-10-17  Tim Horton  <timothy_horton@apple.com>
2319
2320         Fix the build with the public SDK.
2321
2322         * WebCoreSupport/WebSelectionServiceController.mm:
2323         We should transition all this SPI to real SPI headers as soon as possible.
2324
2325 2014-10-16  Tim Horton  <timothy_horton@apple.com>
2326
2327         Implement selection services menu for Legacy WebKit
2328         https://bugs.webkit.org/show_bug.cgi?id=137582
2329         <rdar://problem/18604241>
2330
2331         Reviewed by Brady Eidson.
2332
2333         * Misc/WebSharingServicePickerController.h:
2334         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
2335         Add WebSharingServicePickerClient, which other classes can implement
2336         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
2337         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
2338
2339         * Misc/WebSharingServicePickerController.mm:
2340         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
2341
2342         (-[WebSharingServicePickerController clear]):
2343         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
2344         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
2345         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
2346         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
2347         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2348         Make use of WebSharingServicePickerClient.
2349
2350         (-[WebSharingServicePickerController sharingService:didShareItems:]):
2351         If we're returned a NSAttributedString, paste it on top of the current selection,
2352         similar to what the WebKit2 implementation currently does.
2353         
2354         * WebCoreSupport/WebChromeClient.h:
2355         * WebCoreSupport/WebChromeClient.mm:
2356         (WebChromeClient::handleTelephoneNumberClick):
2357         (WebChromeClient::handleSelectionServiceClick):
2358         (WebChromeClient::hasRelevantSelectionServices):
2359         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
2360
2361         * WebCoreSupport/WebContextMenuClient.h:
2362         * WebCoreSupport/WebContextMenuClient.mm:
2363         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
2364         (WebContextMenuClient::pageForSharingServicePicker):
2365         (WebContextMenuClient::windowForSharingServicePicker):
2366         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
2367         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2368         (WebContextMenuClient::contextMenuForEvent):
2369         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
2370         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
2371         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
2372         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
2373         having WebSharingServicePickerController tightly bound to it.
2374         Make an NSItemProvider array when instantiating WebSharingServicePickerController
2375         instead of handing it data directly.
2376
2377         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
2378         * WebCoreSupport/WebSelectionServiceController.mm: Added.
2379         (WebSelectionServiceController::WebSelectionServiceController):
2380         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
2381         for selection services.
2382
2383         (WebSelectionServiceController::handleSelectionServiceClick):
2384         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
2385
2386         (hasCompatibleServicesForItems):
2387         (WebSelectionServiceController::hasRelevantSelectionServices):
2388         Determine whether or not services are available.
2389
2390         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
2391         (WebSelectionServiceController::pageForSharingServicePicker):
2392         (WebSelectionServiceController::windowForSharingServicePicker):
2393         Implement the rest of the WebSharingServicePickerClient overrides.
2394
2395         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
2396         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
2397         These are only useful for image sharing services, so we don't need to
2398         implement them (WebContextMenuClient does, on the other hand).
2399
2400         * WebView/WebView.mm:
2401         (-[WebView _selectionServiceController]):
2402         * WebView/WebViewData.h:
2403         * WebView/WebViewData.mm:
2404         * WebView/WebViewInternal.h:
2405         Keep a WebSelectionServiceController.
2406
2407 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2408
2409         Improve debug description of WAKViews
2410         https://bugs.webkit.org/show_bug.cgi?id=137716
2411
2412         Reviewed by Simon Fraser.
2413
2414         * WebView/WebView.mm:
2415         (-[WebView _touchEventRegions]): Adding a comment.
2416
2417 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2418
2419         Addressing post-review comment.
2420         https://bugs.webkit.org/show_bug.cgi?id=137550
2421
2422         Unreviewed.
2423
2424         * WebView/WebHTMLView.mm:
2425         (fontNameForDescription):
2426         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2427
2428 2014-10-14  Chris Dumez  <cdumez@apple.com>
2429
2430         Use is<>() / downcast<>() for RenderImage
2431         https://bugs.webkit.org/show_bug.cgi?id=137683
2432
2433         Reviewed by Mihnea Ovidenie.
2434
2435         Use is<>() / downcast<>() for RenderImage.
2436
2437         * Misc/WebNSPasteboardExtras.mm:
2438         (imageFromElement):
2439         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2440
2441 2014-10-10  Daniel Bates  <dabates@apple.com>
2442
2443         Remove unused classes WebRender{Node, Layer}
2444         https://bugs.webkit.org/show_bug.cgi?id=137628
2445
2446         Reviewed by Simon Fraser.
2447
2448         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
2449         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
2450
2451         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
2452         of excluded source files when building for iOS.
2453         * WebKit.exp: Remove symbol for WebRenderLayer.
2454         * WebKit.mac.exp: Remove symbol for WebRenderNode.
2455         * WebView/WebRenderLayer.h: Removed.
2456         * WebView/WebRenderLayer.mm: Removed.
2457         * WebView/WebRenderNode.h: Removed.
2458         * WebView/WebRenderNode.mm: Removed.
2459
2460 2014-10-10  Chris Dumez  <cdumez@apple.com>
2461
2462         Use is<>() / downcast<>() for RenderBoxModelObject
2463         https://bugs.webkit.org/show_bug.cgi?id=137587
2464
2465         Reviewed by Mihnea Ovidenie.
2466
2467         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
2468         surrounding code.
2469
2470         * Plugins/WebBaseNetscapePluginView.mm:
2471         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
2472         * WebView/WebRenderLayer.mm:
2473         (-[WebRenderLayer initWithWebFrame:]):
2474
2475 2014-10-09  Dean Jackson  <dino@apple.com>
2476
2477         Remove ENABLE_CSS3_CONDITIONAL_RULES
2478         https://bugs.webkit.org/show_bug.cgi?id=137571
2479
2480         Reviewed by Simon Fraser.
2481
2482         * Configurations/FeatureDefines.xcconfig:
2483
2484 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2485
2486         Add a WebKit1 preference for selection services
2487         https://bugs.webkit.org/show_bug.cgi?id=137498
2488         <rdar://problem/18572699>
2489
2490         Reviewed by Simon Fraser.
2491
2492         * WebView/WebPreferenceKeysPrivate.h:
2493         * WebView/WebPreferences.mm:
2494         (+[WebPreferences initialize]):
2495         (-[WebPreferences serviceControlsEnabled]):
2496         (-[WebPreferences setServiceControlsEnabled:]):
2497         * WebView/WebPreferencesPrivate.h:
2498         * WebView/WebView.mm:
2499         (-[WebView _preferencesChanged:]):
2500         Add and plumb the preference.
2501
2502 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
2503
2504         Remove second-to-last client of WebFontCache
2505         https://bugs.webkit.org/show_bug.cgi?id=137550
2506
2507         Reviewed by Darin Adler.
2508
2509         Use FontCache::getCachedFontData() instead of WebFontCache.
2510
2511         * WebView/WebHTMLView.mm:
2512         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2513
2514 2014-10-09  Chris Dumez  <cdumez@apple.com>
2515
2516         Use is<>() / downcast<>() for Widget subclasses
2517         https://bugs.webkit.org/show_bug.cgi?id=137549
2518
2519         Reviewed by Darin Adler.
2520
2521         Use is<>() / downcast<>() for Widget subclasses and clean up the
2522         surrounding code.
2523
2524         * WebView/WebRenderNode.mm:
2525         (copyRenderNode):
2526         * WebView/WebView.mm:
2527         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
2528
2529 2014-10-07  Christophe Dumez  <cdumez@apple.com>
2530
2531         Use is<>() / downcast<>() for RenderText / RenderTextFragment
2532         https://bugs.webkit.org/show_bug.cgi?id=137476
2533
2534         Reviewed by Darin Adler.
2535
2536         * WebView/WebRenderNode.mm:
2537         (copyRenderNode):
2538
2539 2014-10-06  Dan Bernstein  <mitz@apple.com>
2540
2541         Build fix.
2542
2543         * Misc/WebCache.mm:
2544         (+[WebCache imageForURL:]):
2545
2546 2014-10-06  Chris Dumez  <cdumez@apple.com>
2547
2548         Unreviewed build fix after r174333.
2549
2550         Forgot explicit WebCore:: namespace.
2551
2552         * Misc/WebCache.mm:
2553         (+[WebCache imageForURL:]):
2554
2555 2014-10-05  Christophe Dumez  <cdumez@apple.com>
2556
2557         Use is<>() / downcast<>() for CachedResource subclasses
2558         https://bugs.webkit.org/show_bug.cgi?id=137431
2559
2560         Reviewed by Benjamin Poulain.
2561
2562         Use is<>() / downcast<>() for CachedResource subclasses.
2563
2564         * Misc/WebCache.mm:
2565         (+[WebCache imageForURL:]):
2566
2567 2014-10-02  Daniel Bates  <dabates@apple.com>
2568
2569         Use version number 101000 instead of 10100 for OS X Yosemite
2570         https://bugs.webkit.org/show_bug.cgi?id=137372
2571
2572         Reviewed by Mark Rowe.
2573
2574         The version number for OS X Yosemite is 101000.
2575
2576         * WebView/WebView.mm:
2577         (-[WebView _preferencesChanged:]):
2578
2579 2014-10-02  Tim Horton  <timothy_horton@apple.com>
2580
2581         Move PageOverlay[Controller] to WebCore
2582         https://bugs.webkit.org/show_bug.cgi?id=137164
2583         <rdar://problem/18508258>
2584
2585         Reviewed by Anders Carlsson.
2586
2587         * WebCoreSupport/WebChromeClient.h:
2588         * WebCoreSupport/WebChromeClient.mm:
2589         (WebChromeClient::attachViewOverlayGraphicsLayer):
2590         Add an empty ChromeClient override.
2591
2592 2014-10-01  Christophe Dumez  <cdumez@apple.com>
2593
2594         Have is<>(T*) function do a null check on the pointer argument
2595         https://bugs.webkit.org/show_bug.cgi?id=137333
2596
2597         Reviewed by Gavin Barraclough.
2598
2599         Have is<>(T*) function do a null check on the argument instead of a
2600         simple assertion. This makes sense for 2 reasons:
2601         1. It is more consistent with downcast<>(T*), which will succeed even
2602            if the argument is a nullptr.
2603         2. It simplifies the code a bit as it gets rid of a lot of explicit
2604            null checks.
2605
2606         * WebCoreSupport/WebChromeClient.mm:
2607         (WebChromeClient::focusedElementChanged):
2608         * WebCoreSupport/WebEditorClient.mm:
2609         (WebEditorClient::textFieldDidBeginEditing):
2610         (WebEditorClient::textFieldDidEndEditing):
2611         (WebEditorClient::textDidChangeInTextField):
2612         (WebEditorClient::doTextFieldCommandFromEvent):
2613         (WebEditorClient::textWillBeDeletedInTextField):
2614         (WebEditorClient::textDidChangeInTextArea):
2615         * WebView/WebHTMLRepresentation.mm:
2616         (inputElementFromDOMElement):
2617         (searchForLabelsBeforeElement):
2618         * WebView/WebRenderLayer.mm:
2619         (+[WebRenderLayer nameForLayer:]):
2620
2621 2014-10-01  Mark Rowe  <mrowe@apple.com>
2622
2623         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2624
2625         Reviewed by Dan Bernstein.
2626
2627         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
2628
2629 2014-09-30  Chris Dumez  <cdumez@apple.com>
2630
2631         Use is<>() / downcast<>() for Element
2632         https://bugs.webkit.org/show_bug.cgi?id=137241
2633
2634         Reviewed by Andreas Kling.
2635
2636         Use is<>() / downcast<>() for Element instead of isElementNode() /
2637         toElement().
2638
2639         * WebView/WebRenderLayer.mm:
2640         (+[WebRenderLayer nameForLayer:]):
2641
2642 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2643
2644         Move ColorInputType class to std::unique_ptr
2645         https://bugs.webkit.org/show_bug.cgi?id=137173
2646
2647         Reviewed by Darin Adler.
2648
2649         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
2650         Child classes follow this change as well.
2651
2652         * WebCoreSupport/WebChromeClient.h:
2653         * WebCoreSupport/WebChromeClient.mm:
2654         (WebChromeClient::createColorChooser):
2655
2656 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2657
2658         Add initial is<>() / downcast<>() support for any type of Nodes
2659         https://bugs.webkit.org/show_bug.cgi?id=137056
2660
2661         Reviewed by Benjamin Poulain.
2662
2663         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
2664         instead of isFormControlElement() / toHTMLFormControlElement().
2665
2666         * WebView/WebHTMLRepresentation.mm:
2667         (searchForLabelsBeforeElement):
2668
2669 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2670
2671         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
2672         https://bugs.webkit.org/show_bug.cgi?id=137068
2673
2674         Reviewed by Ryosuke Niwa.
2675
2676         Start using is<HTML*Element>() instead of isHTML*Element().
2677         Remaining usages will be updated in a follow-up patch to
2678         reduce the size of the change.
2679
2680         * WebCoreSupport/WebChromeClient.mm:
2681         (WebChromeClient::focusedElementChanged):
2682         * WebCoreSupport/WebEditorClient.mm:
2683         (WebEditorClient::textFieldDidBeginEditing):
2684         (WebEditorClient::textFieldDidEndEditing):
2685         (WebEditorClient::textDidChangeInTextField):
2686         (WebEditorClient::doTextFieldCommandFromEvent):
2687         (WebEditorClient::textWillBeDeletedInTextField):
2688         (WebEditorClient::textDidChangeInTextArea):
2689         * WebView/WebHTMLRepresentation.mm:
2690         (inputElementFromDOMElement):
2691
2692 2014-09-21  Timothy Hatcher  <timothy@apple.com>
2693
2694         Make the Web Inspector use a separate web process.
2695
2696         https://bugs.webkit.org/show_bug.cgi?id=135120
2697
2698         Reviewed by Anders Carlsson.
2699
2700         * WebCoreSupport/WebInspectorClient.h:
2701         * WebCoreSupport/WebInspectorClient.mm:
2702         (WebInspectorClient::WebInspectorClient):
2703         (WebInspectorClient::openInspectorFrontend):
2704         (WebInspectorClient::releaseFrontend):
2705         Own WebInspectorFrontendClient instead of moving it.
2706
2707 2014-09-23  Chris Dumez  <cdumez@apple.com>
2708
2709         Use downcast<HTML*Element>() instead of toHTML*Element()
2710         https://bugs.webkit.org/show_bug.cgi?id=137007
2711
2712         Reviewed by Benjamin Poulain.
2713
2714         Use downcast<HTML*Element>() instead of toHTML*Element().
2715
2716         * DOM/WebDOMOperations.mm:
2717         (-[DOMHTMLInputElement _setAutofilled:]):
2718         * WebCoreSupport/WebChromeClient.mm:
2719         (WebChromeClient::focusedElementChanged):
2720         * WebCoreSupport/WebEditorClient.mm:
2721         (WebEditorClient::textFieldDidBeginEditing):
2722         (WebEditorClient::textFieldDidEndEditing):
2723         (WebEditorClient::textDidChangeInTextField):
2724         (WebEditorClient::doTextFieldCommandFromEvent):
2725         (WebEditorClient::textWillBeDeletedInTextField):
2726         (WebEditorClient::textDidChangeInTextArea):
2727         * WebView/WebHTMLRepresentation.mm:
2728         (inputElementFromDOMElement):
2729
2730 2014-09-21  Chris Dumez  <cdumez@apple.com>
2731
2732         Generate Element casting helper functions
2733         https://bugs.webkit.org/show_bug.cgi?id=136839
2734
2735         Reviewed by Darin Adler.
2736
2737         Use JSXXX::toWrapped() instead of toXXX() function.
2738
2739         * DOM/WebDOMOperations.mm:
2740         * WebView/WebView.mm:
2741         (-[WebView _notificationIDForTesting:]):
2742
2743 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
2744
2745         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
2746         https://bugs.webkit.org/show_bug.cgi?id=136972
2747
2748         Reviewed by Darin Adler.
2749
2750         * WebView/WebNotification.h:
2751         * WebView/WebNotification.mm:
2752         (-[WebNotification initWithCoreNotification:notificationID:]):
2753         Switch to RetainPtr and adopt into _private to ensure when we are
2754         deallocated that _private will get deallocated.
2755
2756 2014-09-19  Dean Jackson  <dino@apple.com>
2757
2758         Multithreaded WebGL is a bad idea - remove it
2759         https://bugs.webkit.org/show_bug.cgi?id=136964
2760         <rdar://problem/18399858>
2761
2762         Reviewed by Brent Fulgham.
2763
2764         Remove the setting to allow multithreaded WebGL.
2765
2766         * WebView/WebPreferenceKeysPrivate.h:
2767         * WebView/WebPreferences.mm:
2768         (+[WebPreferences initialize]):
2769         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
2770         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
2771         * WebView/WebPreferencesPrivate.h:
2772         * WebView/WebView.mm:
2773         (-[WebView _preferencesChanged:]):
2774
2775 2014-09-19  Daniel Bates  <dabates@apple.com>
2776
2777         Always assume internal SDK when building configuration Production
2778         https://bugs.webkit.org/show_bug.cgi?id=136925
2779         <rdar://problem/18362399>
2780
2781         Reviewed by Dan Bernstein.
2782
2783         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
2784         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
2785
2786         * Configurations/Base.xcconfig:
2787
2788 2014-09-17  Daniel Bates  <dabates@apple.com>
2789
2790         Unreviewed, rolling out r173695.
2791
2792         Broke building third-party Legacy WebKit apps; will
2793         investigate offline
2794
2795         Reverted changeset:
2796
2797         "[iOS] Make WebCore build with public iOS SDK"
2798         https://bugs.webkit.org/show_bug.cgi?id=136487
2799         http://trac.webkit.org/changeset/173695
2800
2801 2014-09-17  Daniel Bates  <dabates@apple.com>
2802
2803         [iOS] Make WebCore build with public iOS SDK
2804         https://bugs.webkit.org/show_bug.cgi?id=136487
2805
2806         Reviewed by David Kilzer.
2807
2808         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
2809         actual SPI header(s).
2810
2811         * DOM/WebDOMOperationsPrivate.h:
2812         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
2813         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
2814         such files into the WebKit framework as private headers.
2815         * WebCoreSupport/WebFrameLoaderClient.mm:
2816         * WebInspector/WebNodeHighlight.mm:
2817         * WebView/WebIndicateLayer.mm:
2818         * WebView/WebRenderLayer.h:
2819         * WebView/WebView.mm:
2820
2821 2014-09-16  Daniel Bates  <dabates@apple.com>
2822
2823         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
2824         https://bugs.webkit.org/show_bug.cgi?id=136862
2825
2826         Reviewed by David Kilzer.
2827
2828         * Configurations/DebugRelease.xcconfig:
2829
2830 2014-09-16  Enrica Casucci  <enrica@apple.com>
2831
2832         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2833         https://bugs.webkit.org/show_bug.cgi?id=136474
2834
2835         Reviewed by Benjamin Poulain.
2836
2837         This is the updated version of the patch that was landed in r173340.
2838         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2839         and removes the assumption that EAffinity values match NSSelectionAffinity
2840         values. It also removes the includes in TextAffinity.h, creating the need to
2841         include explicitly the files when necessary.
2842
2843         * WebCoreSupport/WebEditorClient.h:
2844         (kit):
2845         (core):
2846
2847 2014-09-14  Daniel Bates  <dabates@apple.com>
2848
2849         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
2850         (https://bugs.webkit.org/show_bug.cgi?id=136789)
2851
2852         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
2853
2854         * WebView/WebFrame.mm:
2855         (-[WebFrame focusedNodeHasContent]):
2856
2857 2014-09-14  Chris Dumez  <cdumez@apple.com>
2858
2859         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
2860         https://bugs.webkit.org/show_bug.cgi?id=136789
2861
2862         Reviewed by Darin Adler.
2863
2864         Rename childNodeCount() to countChildNodes().
2865
2866         * WebView/WebHTMLView.mm:
2867         (-[WebHTMLView attributedString]):
2868
2869 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
2870
2871         Re-add the request autocomplete feature
2872
2873         <https://bugs.webkit.org/show_bug.cgi?id=136730>
2874
2875         This feature was rolled out in r148731 because it was only used by
2876         Chromium. As we consider supporting this feature, roll it back in, but
2877         leave it disabled.
2878
2879         This rolls out r148731 (which removed the feature) with small changes
2880         needed to make the code build in ToT, to match modern style, to make
2881         the tests run, and to remove unused code.
2882
2883         Reviewed by Andy Estes.
2884
2885         * Configurations/FeatureDefines.xcconfig:
2886         * WebCoreSupport/WebFrameLoaderClient.h:
2887
2888 2014-09-12  Commit Queue  <commit-queue@webkit.org>
2889
2890         Unreviewed, rolling out r173575.
2891         https://bugs.webkit.org/show_bug.cgi?id=136790
2892
2893         Failing tests (Requested by enrica on #webkit).
2894
2895         Reverted changeset:
2896
2897         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
2898         https://bugs.webkit.org/show_bug.cgi?id=136474
2899         http://trac.webkit.org/changeset/173575
2900
2901 2014-09-12  Enrica Casucci  <enrica@apple.com>
2902
2903         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2904         https://bugs.webkit.org/show_bug.cgi?id=136474
2905
2906         Reviewed by Benjamin Poulain.
2907
2908         This is the updated version of the patch that was landed in r173340.
2909         I changed the use of IntPoint to FloatPoint since it was causing tests
2910         to fail.
2911         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2912         and removes the assumption that EAffinity values match NSSelectionAffinity
2913         values. It also removes the includes in TextAffinity.h, creating the need to
2914         include explicitly the files when necessary. It also removes the unnecessary
2915         use of platform specific types, replacing them with WebCore types.
2916
2917         * WebCoreSupport/WebEditorClient.h:
2918         (kit):
2919         (core):
2920         * WebView/WebFrameView.mm:
2921         (-[WebFrameView _scrollToBeginningOfDocument]):
2922         (-[WebFrameView _scrollToEndOfDocument]):
2923
2924 2014-09-11  Bear Travis  <betravis@adobe.com>
2925
2926         [CSS Font Loading] Enable CSS Font Loading on Mac
2927         https://bugs.webkit.org/show_bug.cgi?id=135473
2928
2929         Reviewed by Antti Koivisto.
2930
2931         Enable CSS Font Loading in FeatureDefines.
2932
2933         * Configurations/FeatureDefines.xcconfig:
2934
2935 2014-09-11  Beth Dakin  <bdakin@apple.com>
2936
2937         Support rubber-banding in sub-frames
2938         https://bugs.webkit.org/show_bug.cgi?id=136726
2939         -and corresponding-
2940         rdar://problem/10011924
2941
2942         Reviewed by Tim Horton.
2943
2944         rubberBandingForOverflowScrollEnabled is re-named to
2945         rubberBandingForSubScrollableRegionsEnabled
2946         * WebView/WebView.mm:
2947         (-[WebView _preferencesChanged:]):
2948
2949 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
2950
2951         Disable the "unreachable-code" warning
2952         https://bugs.webkit.org/show_bug.cgi?id=136677
2953
2954         Reviewed by Darin Adler.
2955
2956         * Configurations/Base.xcconfig:
2957
2958 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
2959
2960         Fix 32-bit Mac build for new warnings
2961         https://bugs.webkit.org/show_bug.cgi?id=136624
2962
2963         Reviewed by Darin Adler.
2964         
2965         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
2966
2967         * Carbon/HIViewAdapter.m:
2968         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
2969
2970 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2971
2972         Remove FILTERS flag
2973         https://bugs.webkit.org/show_bug.cgi?id=136571
2974
2975         Reviewed by Darin Adler.
2976
2977         * Configurations/FeatureDefines.xcconfig:
2978
2979 2014-09-08  Jessie Berlin  <jberlin@apple.com>
2980
2981         32-bit build fix after r173364.
2982
2983         * Carbon/HIViewAdapter.m:
2984         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
2985
2986 2014-09-08  Dan Bernstein  <mitz@apple.com>
2987
2988         Build fix.
2989
2990         Added back SPI that is still in use.
2991
2992         * Misc/WebNSURLExtras.h:
2993         * Misc/WebNSURLExtras.mm:
2994         (-[NSURL _webkit_URLByRemovingFragment]):
2995
2996 2014-09-08  Dan Bernstein  <mitz@apple.com>
2997
2998         iOS Simulator build fix.
2999
3000         * Misc/WebKitSystemBits.m:
3001         (WebMemorySize):
3002
3003 2014-09-07  Darin Adler  <darin@apple.com>
3004
3005         Fix build failure seen on Mountain Lion buildbot.
3006
3007         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
3008         of an int, to avoid warning about mixing signs.
3009
3010 2014-09-06  Darin Adler  <darin@apple.com>
3011
3012         Make updates suggested by new version of Xcode
3013         https://bugs.webkit.org/show_bug.cgi?id=136603
3014
3015         Reviewed by Mark Rowe.
3016
3017         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
3018         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
3019
3020         * History/WebURLsWithTitles.m:
3021         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
3022         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
3023         not turned on because it gives us too many false positives).
3024         * Misc/WebElementDictionary.mm:
3025         (-[WebElementDictionary objectForKey:]): Ditto.
3026         * Misc/WebNSDataExtras.m:
3027         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
3028         (-[NSData _webkit_guessedMIMEType]): Ditto.
3029         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
3030         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
3031
3032         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
3033         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
3034         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
3035         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
3036         and _webkit_URLFragment methods.
3037
3038         * Misc/WebNSURLExtras.mm:
3039         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
3040         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
3041         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
3042         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
3043         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
3044         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
3045         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
3046         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
3047         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
3048         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
3049         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
3050         (-[NSString _webkit_URLFragment]): Deleted.
3051
3052         * Plugins/WebPluginDatabase.mm:
3053         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
3054         to iterate an array instead of a loop using the type "unsigned int".
3055
3056         * WebCoreSupport/WebOpenPanelResultListener.mm:
3057         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
3058
3059         * WebView/WebDelegateImplementationCaching.mm:
3060         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
3061         directly without a proper type for the function pointer. This might have been causing
3062         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
3063         functions that were already doing this correctly.
3064
3065         * WebView/WebTextCompletionController.mm:
3066         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
3067
3068 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
3069
3070         Web Inspector: convert DockSide to an enum class
3071         https://bugs.webkit.org/show_bug.cgi?id=136601
3072
3073         Reviewed by Timothy Hatcher.
3074
3075         * WebCoreSupport/WebInspectorClient.mm:
3076         (WebInspectorFrontendClient::frontendLoaded):
3077         (-[WebInspectorWindowController attachWindow:]):
3078         (-[WebInspectorWindowController attach]):
3079         (-[WebInspectorWindowController detach]):
3080         * WebInspector/WebInspectorFrontend.mm:
3081         (-[WebInspectorFrontend attach]):
3082
3083 2014-09-05  Commit Queue  <commit-queue@webkit.org>
3084
3085         Unreviewed, rolling out r173340 and r173342.
3086         https://bugs.webkit.org/show_bug.cgi?id=136596
3087
3088         Broke many tests (Requested by ap on #webkit).
3089
3090         Reverted changesets:
3091
3092         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3093         https://bugs.webkit.org/show_bug.cgi?id=136474
3094         http://trac.webkit.org/changeset/173340
3095
3096         "Build fix after r173340."
3097         http://trac.webkit.org/changeset/173342
3098
3099 2014-09-05  Enrica Casucci  <enrica@apple.com>
3100
3101         Build fix after r173340.
3102
3103         * WebCoreSupport/WebEditorClient.h:
3104         (kit):
3105         (core):
3106
3107 2014-09-05  Enrica Casucci  <enrica@apple.com>
3108
3109         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3110         https://bugs.webkit.org/show_bug.cgi?id=136474
3111
3112         Reviewed by Benjamin Poulain.
3113
3114         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3115         and removes the assumption that EAffinity values match NSSelectionAffinity
3116         values. It also removes the includes in TextAffinity.h, creating the need to
3117         include explicitly the files when necessary. It also removes the unnecessary
3118         use of platform specific types, replacing them with WebCore types.
3119
3120         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
3121         * WebView/WebFrameView.mm:
3122         (-[WebFrameView _scrollToBeginningOfDocument]):
3123         (-[WebFrameView _scrollToEndOfDocument]):
3124
3125 2014-09-05  Daniel Bates  <dabates@apple.com>
3126
3127         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3128         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3129
3130         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
3131
3132         * WebView/WebHTMLView.mm:
3133         (-[WebHTMLView viewDidMoveToWindow]):
3134
3135 2014-09-05  Daniel Bates  <dabates@apple.com>
3136
3137         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3138         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3139
3140         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
3141         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
3142
3143         * WebView/WebHTMLView.mm:
3144         (-[WebHTMLView viewDidMoveToWindow]):
3145
3146 2014-09-05  Daniel Bates  <dabates@apple.com>
3147
3148         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
3149         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3150
3151         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
3152
3153         * WebView/WebHTMLView.mm:
3154         (-[WebHTMLView setDataSource:]):
3155
3156 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
3157
3158         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
3159         https://bugs.webkit.org/show_bug.cgi?id=136564
3160
3161         Reviewed by Dan Bernstein.
3162         
3163         WebKit1 depended on mouse moved event notifications to track mouse
3164         moves, and on being specially called by Safari to track flags
3165         changes. WebKit2 does both these things better - it uses a tracking area
3166         and event monitors. Copy those approaches.
3167
3168         * WebKit.order: Remove reference to obsolete call.
3169         * WebView/WebHTMLView.mm:
3170         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
3171         area, since we now just always have one.
3172         (-[WebHTMLViewPrivate clear]): ditto
3173         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
3174         New method that posts a fake mouse move event in response to
3175         a flags change event, for use by the event monitor.
3176         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
3177         still kept around for benefit of older Safari.
3178         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
3179         special mouseover mode (previously handled in a weird way).
3180         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
3181         (-[WebHTMLView viewWillMoveToWindow:]): ditto
3182         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
3183         changed monitor.
3184         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
3185         tracking area or mouse moved observer.
3186         (-[WebHTMLView windowDidResignKey:]): ditto
3187         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
3188         moved observer.
3189         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
3190         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
3191         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
3192         up tracking area - we have to do it here, because before this point, the
3193         WebHTMLView does not know its WebView, which is where dashboard settings
3194         live.
3195         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
3196         (-[WebHTMLView addMouseMovedObserver]): Deleted.
3197         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
3198
3199 2014-09-04  Pratik Solanki  <psolanki@apple.com>
3200
3201         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
3202         https://bugs.webkit.org/show_bug.cgi?id=136560
3203
3204         Reviewed by Joseph Pecoraro.
3205
3206         I removed the disk image caching code in r173265. However, we still have clients that call
3207         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
3208
3209         * WebView/WebPreferences.mm:
3210         (-[WebPreferences setDiskImageCacheEnabled:]):
3211         * WebView/WebPreferencesPrivate.h:
3212
3213 2014-09-03  Andy Estes  <aestes@apple.com>
3214
3215         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
3216         https://bugs.webkit.org/show_bug.cgi?id=136521
3217
3218         Reviewed by Anders Carlsson.
3219
3220         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
3221
3222             s/(^ *)WEBCORE_EXPORT /\1/g
3223
3224         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
3225
3226         * MigrateHeaders.make:
3227
3228 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
3229
3230         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
3231         https://bugs.webkit.org/show_bug.cgi?id=136527
3232
3233         Reviewed by Alexey Proskuryakov.
3234
3235         * WebCoreSupport/WebSystemInterface.mm:
3236         (InitWebCoreSystemInterface):
3237
3238 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3239
3240         Remove CSS_FILTERS flag
3241         https://bugs.webkit.org/show_bug.cgi?id=136529
3242
3243         Reviewed by Dirk Schulze.
3244
3245         * Configurations/FeatureDefines.xcconfig:
3246
3247 2014-09-04  Pratik Solanki  <psolanki@apple.com>
3248
3249         Remove iOS specific disk image cache
3250         https://bugs.webkit.org/show_bug.cgi?id=136517
3251
3252         Reviewed by Antti Koivisto.
3253
3254         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
3255         this now since we don't enable it in WebKit2 on iOS.
3256
3257         * Misc/WebCache.mm:
3258         (+[WebCache statistics]):
3259         * WebView/WebDataSource.mm:
3260         (-[WebDataSource _setAllowToBeMemoryMapped]):
3261         (-[WebDataSource setDataSourceDelegate:]):
3262         (-[WebDataSource dataSourceDelegate]):
3263         (-[WebDataSource dealloc]):
3264         (BufferMemoryMapped): Deleted.
3265         * WebView/WebPreferenceKeysPrivate.h:
3266         * WebView/WebPreferences.mm:
3267         (+[WebPreferences initialize]):
3268         (-[WebPreferences diskImageCacheEnabled]): Deleted.
3269         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
3270         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
3271         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
3272         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
3273         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
3274         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
3275         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
3276         * WebView/WebPreferencesPrivate.h:
3277         * WebView/WebView.mm:
3278         (-[WebView _commonInitializationWithFrameName:groupName:]):
3279         (+[WebView _handleMemoryWarning]):
3280         (-[WebView _preferencesChanged:]):
3281
3282 2014-09-04  Daniel Bates  <dabates@apple.com>
3283
3284         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
3285         https://bugs.webkit.org/show_bug.cgi?id=136494
3286
3287         Reviewed by Andy Estes.
3288
3289         * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined.
3290         * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
3291
3292 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
3293
3294         Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
3295         https://bugs.webkit.org/show_bug.cgi?id=136476
3296
3297         Reviewed by Timothy Hatcher.
3298
3299         * Misc/WebCoreStatistics.mm:
3300         (+[WebCoreStatistics shouldPrintExceptions]):
3301         (+[WebCoreStatistics setShouldPrintExceptions:]):
3302
3303 2014-09-03  Enrica Casucci  <enrica@apple.com>
3304
3305         Remove PLATFORM(IOS) from WebCore/editing (Part 1).
3306         https://bugs.webkit.org/show_bug.cgi?id=136474
3307
3308         Reviewed by Tim Horton.
3309
3310         * WebCoreSupport/WebEditorClient.mm:
3311         (undoNameForEditAction):
3312
3313 2014-09-02  Maciej Stachowiak  <mjs@apple.com>
3314
3315         Clean up naming for and slightly refactor legacy video fullscreen support
3316         https://bugs.webkit.org/show_bug.cgi?id=136446
3317
3318         Reviewed by Jer Noble.
3319
3320         Key changes:
3321         supportsFullscreenForNode(Node*) --> supportsVideoFullscreen()
3322         enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*)
3323         exitFullscreenForNode(Node*) --> exitVideoFullscreen()
3324         
3325         The old versions had unnecessary parameters, did not clearly distinguish their purpose
3326         from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes.
3327         Also changed many other places to use HTMLVideoElement* instead of Node* or 
3328         HTMLMediaElement* when they were in fact only used for video elements and would only
3329         work for such.
3330
3331         * WebCoreSupport/WebChromeClient.h:
3332         * WebCoreSupport/WebChromeClient.mm:
3333         (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring.
3334         Also no more need to check for video elementness.
3335         (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring.
3336         (WebChromeClient::exitVideoFullscreen): ditto
3337         * WebView/WebView.mm:
3338         (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main
3339         refactoring.
3340         (-[WebView _exitVideoFullscreen]): ditto
3341         (-[WebView _close]): ditto
3342         * WebView/WebViewInternal.h:
3343
3344 2014-09-03  Dan Bernstein  <mitz@apple.com>
3345
3346         Get rid of HIGH_DPI_CANVAS leftovers
3347         https://bugs.webkit.org/show_bug.cgi?id=136491
3348
3349         Reviewed by Benjamin Poulain.
3350
3351         * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS
3352         and removed it from FEATURE_DEFINES.
3353
3354 2014-08-31  Tim Horton  <timothy_horton@apple.com>
3355
3356         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
3357         https://bugs.webkit.org/show_bug.cgi?id=136416
3358
3359         Reviewed by Dan Bernstein.
3360
3361         * WebView/WebFrameView.mm:
3362         (-[WebFrameView drawRect:]):
3363         We only end up filling, so only set the fill color.
3364
3365 2014-08-26  Maciej Stachowiak  <mjs@apple.com>
3366
3367         Use RetainPtr::autorelease in some places where it seems appropriate
3368         https://bugs.webkit.org/show_bug.cgi?id=136280
3369
3370         Reviewed by Darin Adler.
3371
3372         * WebView/WebHTMLView.mm:
3373         (imageFromRect): Use RetainPtr in this function.
3374         * WebView/WebPDFRepresentation.mm:
3375         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
3376         in this method.
3377
3378 2014-08-29  Csaba Osztrogonác  <ossy@webkit.org>
3379
3380         Unreviwed, remove empty directories.
3381
3382         * ForwardingHeaders/wtf: Removed.
3383
3384 2014-08-27  Zalan Bujtas  <zalan@apple.com>
3385
3386         Subpixel layout: Rename LayoutRect's device pixel snapping functions.
3387         https://bugs.webkit.org/show_bug.cgi?id=136319
3388
3389         Reviewed by Simon Fraser.
3390
3391         From pixelSnappedForPainting() to snapRectToDevicePixels() and 
3392         pixelSnappedIntRect*() to snappedIntRect*().
3393
3394         No change in functionality.
3395
3396         * WebView/WebView.mm:
3397         (-[WebView _dashboardRegions]):
3398         (-[WebView trackedRepaintRects]):
3399
3400 2014-08-25  Maciej Stachowiak  <mjs@apple.com>
3401
3402         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
3403         https://bugs.webkit.org/show_bug.cgi?id=136082
3404
3405         Reviewed by Alexey Proskuryakov.
3406
3407         * Plugins/Hosted/NetscapePluginHostManager.mm:
3408         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
3409         localization name using WebCore helper instead of SPI.
3410         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
3411         file.
3412         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
3413         localization name using WebCore helper instead of SPI.
3414         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
3415         helper no longer pulls its weight.
3416         * WebCoreSupport/WebSystemInterface.mm: 
3417         (InitWebCoreSystemInterface): Remove mention of
3418         WKCopyCFLocalizationPreferredName.
3419         * WebKit.order: ditto
3420
3421 2014-08-25  Daniel Bates  <dabates@apple.com>
3422
3423         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/172889>
3424         (https://bugs.webkit.org/show_bug.cgi?id=109658)
3425
3426         Substitute GraphicsLayer::setContentsToPlatformLayer(..., GraphicsLayer::ContentsLayerForMedia)
3427         for GraphicsLayer::setContentsToMedia(...) because the latter was removed in <http://trac.webkit.org/changeset/172889>.
3428
3429         * WebView/WebView.mm:
3430         (-[WebView _setMediaLayer:forPluginView:]):
3431
3432 2014-08-22  Commit Queue  <commit-queue@webkit.org>
3433
3434         Unreviewed, rolling out r172866.
3435         https://bugs.webkit.org/show_bug.cgi?id=136177
3436
3437         Broke iOS build (Requested by othermaciej on #webkit).
3438
3439         Reverted changeset:
3440
3441         "Replace use of WKCopyCFLocalizationPreferredName with
3442         NSLocale public API"
3443         https://bugs.webkit.org/show_bug.cgi?id=136082
3444         http://trac.webkit.org/changeset/172866
3445
3446 2014-08-22  Simon Fraser  <simon.fraser@apple.com>
3447
3448         Implement paint flashing in the WK1 InspectorOverlay page
3449         https://bugs.webkit.org/show_bug.cgi?id=136138
3450
3451         Reviewed by Sam Weinig, Joseph Pecoraro.
3452
3453         Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page.
3454         We avoid allocating backing store for this canvas until we have paint rects.
3455         
3456         Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages
3457         an array of rects, and pushes them to the page when they change, before forcing a paint.
3458         
3459         Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its
3460         WebKit WebInspectorClient, but don't yet implement paint flashing there.
3461
3462         * WebCoreSupport/WebInspectorClient.h:
3463         * WebCoreSupport/WebInspectorClient.mm:
3464         (WebInspectorClient::WebInspectorClient):
3465
3466 2014-08-20  Maciej Stachowiak  <mjs@apple.com>
3467
3468         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
3469         https://bugs.webkit.org/show_bug.cgi?id=136082
3470
3471         Reviewed by Alexey Proskuryakov.
3472
3473         * Plugins/Hosted/NetscapePluginHostManager.mm:
3474         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
3475         localization name using WebCore helper instead of SPI.
3476         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
3477         file.
3478         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
3479         localization name using WebCore helper instead of SPI.
3480         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
3481         helper no longer pulls its weight.
3482         * WebCoreSupport/WebSystemInterface.mm: 
3483         (InitWebCoreSystemInterface): Remove mention of
3484         WKCopyCFLocalizationPreferredName.
3485         * WebKit.order: ditto
3486
3487 2014-08-22  Daniel Bates  <dabates@apple.com>
3488
3489         [iOS] Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, and temporarily disable ENABLE_TOUCH_EVENTS
3490         and ENABLE_XSLT when building with the iOS public SDK
3491         https://bugs.webkit.org/show_bug.cgi?id=135945
3492
3493         Reviewed by Andy Estes.
3494
3495         * Configurations/FeatureDefines.xcconfig: Disable ENABLE_IOS_{GESTURE, TOUCH}_EVENTS, ENABLE_TOUCH_EVENTS
3496         and ENABLE_XSLT when building with the public SDK.
3497         * MigrateHeaders.make: Conditionally migrate headers for touch and gesture events.
3498
3499 2014-08-22  Jon Lee  <jonlee@apple.com>
3500
3501         Fix iOS build due to r172832 and move RUBBER_BANDING out of FeatureDefines.h
3502         https://bugs.webkit.org/show_bug.cgi?id=136157
3503
3504         Reviewed by Simon Fraser.
3505
3506         * Configurations/FeatureDefines.xcconfig: Add ENABLE(RUBBER_BANDING).
3507         * WebView/WebView.mm:
3508         (-[WebView _preferencesChanged:]): Wrap in ENABLE(RUBBER_BANDING).
3509
3510 2014-08-21  Zalan Bujtas  <zalan@apple.com>
3511
3512         Enable SATURATED_LAYOUT_ARITHMETIC.
3513         https://bugs.webkit.org/show_bug.cgi?id=136106
3514
3515         Reviewed by Simon Fraser.
3516
3517         SATURATED_LAYOUT_ARITHMETIC protects LayoutUnit against arithmetic overflow.
3518         (No measurable performance regression on Mac.)
3519
3520         * Configurations/FeatureDefines.xcconfig:
3521
3522 2014-08-21  Beth Dakin  <bdakin@apple.com>
3523
3524         overflow:scroll elements should support rubber-banding
3525         https://bugs.webkit.org/show_bug.cgi?id=91655
3526
3527         Reviewed by Sam Weinig and Darin Adler.
3528
3529         Disable rubber-banding in overflow areas for now.
3530         * WebView/WebView.mm:
3531         (-[WebView _preferencesChanged:]):
3532
3533 2014-08-19  Pratik Solanki  <psolanki@apple.com>
3534
3535         Remove PurgeableBuffer since it is not very useful any more
3536         https://bugs.webkit.org/show_bug.cgi?id=135939
3537
3538         Reviewed by Andreas Kling.
3539
3540         * Misc/WebCache.mm:
3541         (+[WebCache statistics]):
3542
3543 2014-08-19  Zalan Bujtas  <zalan@apple.com>
3544
3545         Remove ENABLE(SUBPIXEL_LAYOUT).
3546         https://bugs.webkit.org/show_bug.cgi?id=136077
3547
3548         Reviewed by Simon Fraser.
3549
3550         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
3551
3552         * Configurations/FeatureDefines.xcconfig:
3553
3554 2014-08-18  Maciej Stachowiak  <mjs@apple.com>
3555
3556         Use NSURLFileTypeMappings directly instead of depending on WebKitSystemInterface wrappers for it
3557         https://bugs.webkit.org/show_bug.cgi?id=136035
3558
3559         Reviewed by Dan Bernstein.
3560
3561         * Misc/WebNSViewExtras.m:
3562         (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Remove comment
3563         reference to obsolete WKSI function.
3564         * WebCoreSupport/WebSystemInterface.mm:
3565         (InitWebCoreSystemInterface): Don't initialize the no-longer-used WKGetExtensionsForMIMEType,
3566         WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension
3567         * Plugins/WebPluginDatabase.mm:
3568         (-[WebPluginDatabase pluginForExtension:]): Include SPI header from WebCore; use
3569         NSURLFileTypeMappings directly instead of via WKSI wrapper.
3570         * WebCoreSupport/WebFrameLoaderClient.mm:
3571         (WebFrameLoaderClient::objectContentType): ditto
3572         * WebView/WebHTMLView.mm:
3573         (-[WebHTMLView _imageExistsAtPaths:]): ditto
3574         * WebView/WebView.mm:
3575         (+[WebView _supportedFileExtensions]): ditto
3576         (+[WebView suggestedFileExtensionForMIMEType:]): ditto
3577         (+[WebView _MIMETypeForFile:]): ditto
3578
3579 2014-08-18  Commit Queue  <commit-queue@webkit.org>
3580
3581         Unreviewed, rolling out r172736.
3582         https://bugs.webkit.org/show_bug.cgi?id=136060
3583
3584         Caused 14% PLT regressions (Requested by rniwa on #webkit).
3585
3586         Reverted changeset:
3587
3588         "Remove PurgeableBuffer since it is not very useful any more"
3589         https://bugs.webkit.org/show_bug.cgi?id=135939
3590         http://trac.webkit.org/changeset/172736
3591
3592 2014-08-18  Pratik Solanki  <psolanki@apple.com>
3593
3594         Remove PurgeableBuffer since it is not very useful any more
3595         https://bugs.webkit.org/show_bug.cgi?id=135939
3596
3597         Reviewed by Geoffrey Garen.
3598
3599         * Misc/WebCache.mm:
3600         (+[WebCache statistics]):
3601
3602 2014-08-18  Andy Estes  <aestes@apple.com>
3603
3604         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
3605         https://bugs.webkit.org/show_bug.cgi?id=136010
3606
3607         Reviewed by Darin Adler.
3608
3609         * Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
3610         * WebView/WebPDFView.mm:
3611         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
3612         * WebView/WebView.mm:
3613         (-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary.
3614
3615 2014-08-18  Andy Estes  <aestes@apple.com>
3616
3617         Revert r172697.
3618
3619         It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects.
3620
3621         * Misc/WebKitVersionChecks.h:
3622         * WebView/WebView.mm:
3623         (-[WebView _preferencesChanged:]):
3624
3625 2014-08-15  Andy Estes  <aestes@apple.com>
3626
3627         REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
3628         https://bugs.webkit.org/show_bug.cgi?id=136010
3629
3630         Reviewed by Darin Adler.
3631
3632         Reverted the linked-on-or-after check added in r170120 since it is no longer necessary.
3633
3634         * Misc/WebKitVersionChecks.h:
3635         * WebView/WebView.mm:
3636         (-[WebView _preferencesChanged:]):
3637
3638 2014-08-16  Maciej Stachowiak  <mjs@apple.com>
3639
3640         Remove the obsolete WebKitEnableCoalescedUpdatesPreferenceKey
3641         https://bugs.webkit.org/show_bug.cgi?id=136024
3642
3643         Reviewed by Filip Pizlo.
3644
3645         * WebView/WebFrameView.mm:
3646         (-[WebFrameView initWithFrame:]): Remove code that respects
3647         this key. It was SPI and is no longer used; also it was
3648         only relevant for versions of OS X that WebKit no longer supports.
3649         * WebView/WebPreferenceKeysPrivate.h: Remove declaration.
3650
3651 2014-08-15  Daniel Bates  <dabates@apple.com>
3652
3653         [iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS
3654         and ENABLE_TOUCH_EVENTS if applicable
3655         https://bugs.webkit.org/show_bug.cgi?id=135993
3656
3657         Reviewed by Andy Estes.
3658
3659         Add support infrastructure to remove code from public and private API headers that is
3660         guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled.
3661
3662         We aren't using this functionality yet, but we will soon.
3663
3664         * postprocess-headers.sh:
3665
3666 2014-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3667
3668         Enable CSS_SCROLL_SNAP for iOS
3669         https://bugs.webkit.org/show_bug.cgi?id=135915
3670
3671         Turn on CSS_SCROLL_SNAP for iOS and the iOS simulator.
3672
3673         Reviewed by Tim Horton.
3674
3675         * Configurations/FeatureDefines.xcconfig:
3676
3677 2014-08-13  Mark Rowe  <mrowe@apple.com>
3678
3679         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
3680
3681         Reviewed by Darin Adler.
3682
3683         * Misc/WebSharingServicePickerController.mm: Forward-declare some details related to NSSharingServicePicker.
3684
3685 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3686
3687         Web Inspector: Workaround a NSWindow change to the title bar.
3688         https://bugs.webkit.org/show_bug.cgi?id=135880
3689
3690         Reviewed by Joseph Pecoraro.
3691
3692         * WebCoreSupport/WebInspectorClient.mm:
3693         (WebInspectorFrontendClient::setToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier.
3694         (-[WebInspectorWindowController init]): Only call setDrawsBackground: on 10.9 and earlier.
3695         (-[WebInspectorWindowController window]): Set titlebarAppearsTransparent on 10.10.
3696         Only call border thickness APIs on 10.9 and earlier.
3697
3698 2014-08-12  Peyton Randolph  <prandolph@apple.com>
3699
3700         Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.           
3701         https://bugs.webkit.org/show_bug.cgi?id=135682
3702
3703         Reviewed by Tim Horton.
3704
3705         * Configurations/FeatureDefines.xcconfig:
3706         Remove LONG_MOUSE_PRESS feature flag.
3707
3708 2014-08-11  Andy Estes  <aestes@apple.com>
3709
3710         [iOS] Get rid of iOS.xcconfig
3711         https://bugs.webkit.org/show_bug.cgi?id=135809
3712
3713         Reviewed by Joseph Pecoraro.
3714
3715         All iOS.xcconfig did was include AspenFamily.xcconfig, so there's no need for the indirection.
3716
3717         * Configurations/Base.xcconfig:
3718         * Configurations/iOS.xcconfig: Removed.
3719
3720 2014-08-10  Timothy Hatcher  <timothy@apple.com>
3721
3722         Web Inspector: new glyphs are visible on OS X 10.9 builds
3723         https://bugs.webkit.org/show_bug.cgi?id=135743
3724
3725         Reviewed by Joseph Pecoraro.
3726
3727         * WebCoreSupport/WebInspectorClient.mm:
3728         (-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version.
3729
3730 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3731
3732         Get rid of SCRIPTED_SPEECH
3733         https://bugs.webkit.org/show_bug.cgi?id=135729
3734
3735         Reviewed by Brent Fulgham.
3736
3737         * Configurations/FeatureDefines.xcconfig:
3738
3739 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3740
3741         Get rid of INPUT_SPEECH
3742         https://bugs.webkit.org/show_bug.cgi?id=135672
3743
3744         Reviewed by Andreas Kling.
3745
3746         * Configurations/FeatureDefines.xcconfig:
3747
3748 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3749
3750         Web Inspector: Update glyphs to be more like Xcode 6
3751         https://bugs.webkit.org/show_bug.cgi?id=135705
3752
3753         Reviewed by Joseph Pecoraro.
3754
3755         * Resources/Dock.pdf: Added.
3756         * Resources/DockLegacy.pdf: Copied from Source/WebKit/mac/Resources/Dock.pdf.
3757         * WebCoreSupport/WebInspectorClient.mm:
3758         (-[WebInspectorWindowController window]): Use new images.
3759
3760 2014-08-06  Dean Jackson  <dino@apple.com>
3761
3762         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
3763         https://bugs.webkit.org/show_bug.cgi?id=135675
3764
3765         Reviewed by Sam Weinig.
3766
3767         * Configurations/FeatureDefines.xcconfig:
3768
3769 2014-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3770
3771         Implement parsing for CSS scroll snap points
3772         https://bugs.webkit.org/show_bug.cgi?id=134301
3773
3774         Reviewed by Dean Jackson.
3775
3776         * Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP
3777
3778 2014-08-06  Alexey Proskuryakov  <ap@apple.com>
3779
3780         REGRESSION (WebKit2): iOS Safari default encoding doesn't follow system language
3781         https://bugs.webkit.org/show_bug.cgi?id=135667
3782         <rdar://problem/17862892>
3783
3784         Reviewed by Anders Carlsson.
3785
3786         * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
3787         Moved implementation to WebCore, so that it can be shared with WebKit2.
3788
3789         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
3790         We now use WKGetWebDefaultCFStringEncoding in WebCore, so it needs to be initialized.
3791
3792 2014-08-05  Peyton Randolph  <prandolph@apple.com>
3793
3794         Rename MAC_LONG_PRESS feature flag to LONG_MOUSE_PRESS.
3795         https://bugs.webkit.org/show_bug.cgi?id=135276
3796
3797         Reviewed by Beth Dakin.
3798
3799         * Configurations/FeatureDefines.xcconfig:
3800
3801 2014-08-04  Benjamin Poulain  <benjamin@webkit.org>
3802
3803         Add a flag for the CSS Selectors level 4 implementation
3804         https://bugs.webkit.org/show_bug.cgi?id=135535
3805
3806         Reviewed by Andreas Kling.
3807
3808         * Configurations/FeatureDefines.xcconfig:
3809
3810 2014-08-04  Benjamin Poulain  <bpoulain@apple.com>
3811
3812         Check for null frame when processing geolocation authorization request
3813         https://bugs.webkit.org/show_bug.cgi?id=135577
3814         <rdar://problem/17896295>
3815
3816         Reviewed by Geoffrey Garen.
3817
3818         * WebCoreSupport/WebGeolocationClient.mm:
3819         (WebGeolocationClient::requestPermission):
3820
3821 2014-08-02  Jeremy Jones  <jeremyj@apple.com>
3822
3823         Support both window and view based video fullscreen.
3824         https://bugs.webkit.org/show_bug.cgi?id=135525
3825
3826         Reviewed by Simon Fraser.
3827
3828         Parenting in the view instead of the window gives the fullscreen implementation more latitude 
3829         in how it implements the animation.
3830
3831         * WebView/WebView.mm:
3832         (-[WebView _enterFullscreenForNode:]): Use view instead of window.
3833
3834 2014-08-01  Dan Bernstein  <mitz@apple.com>
3835
3836         <rdar://problem/17891752> [iOS] WebKit links against libraries it doesn’t use
3837         https://bugs.webkit.org/show_bug.cgi?id=135536
3838
3839         Reviewed by Tim Horton.
3840
3841         * Configurations/WebKitLegacy.xcconfig: Removed -framework MobileAsset from
3842         OTHER_LDFLAGS_iphoneos.
3843
3844 2014-07-30  Andy Estes  <aestes@apple.com>
3845
3846         USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
3847         https://bugs.webkit.org/show_bug.cgi?id=135439
3848
3849         Reviewed by Tim Horton.
3850
3851         We now support two different platform content filters, and will soon support a mock content filter (as part of
3852         webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party
3853         library. ENABLE() is the correct macro to use for such a feature.
3854
3855         * Configurations/FeatureDefines.xcconfig:
3856
3857 2014-07-30  Andreas Kling  <akling@apple.com>
3858
3859         Static hash tables no longer need to be coupled with a VM.
3860         <https://webkit.org/b/135421>
3861
3862         Reviewed by Geoffrey Garen.
3863
3864         * Plugins/Hosted/ProxyInstance.mm:
3865         * Plugins/Hosted/ProxyRuntimeObject.mm:
3866
3867 2014-07-30  Dan Bernstein  <mitz@apple.com>
3868
3869         Updated for changes to the WebCore::Credential API.
3870         Work towards fixing https://bugs.webkit.org/show_bug.cgi?id=135327
3871
3872         Reviewed by Alexey Proskuryakov.
3873
3874         * Misc/WebDownload.mm:
3875         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential
3876         getter.
3877         * Plugins/WebBaseNetscapePluginView.mm:
3878         (WebKit::getAuthenticationInfo): Ditto.
3879
3880 2014-07-27  Pratik Solanki  <psolanki@apple.com>
3881
3882         Remove unused preference keys
3883         https://bugs.webkit.org/show_bug.cgi?id=135280
3884
3885         Reviewed by Darin Adler.
3886
3887         * WebView/WebPreferenceKeysPrivate.h:
3888         * WebView/WebPreferences.mm:
3889         (+[WebPreferences initialize]):
3890         (-[WebPreferences _setPageCacheSize:]): Deleted.
3891         (-[WebPreferences _pageCacheSize]): Deleted.
3892         (-[WebPreferences _setObjectCacheSize:]): Deleted.
3893         (-[WebPreferences _objectCacheSize]): Deleted.
3894         * WebView/WebPreferencesPrivate.h:
3895
3896 2014-07-27  Filip Pizlo  <fpizlo@apple.com>
3897
3898         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
3899
3900     2014-07-25  Mark Lam  <mark.lam@apple.com>
3901     
3902             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
3903             <https://webkit.org/b/134273>
3904     
3905             Reviewed by Michael Saboff.
3906     
3907             * WebView/WebScriptDebugDelegate.mm:
3908             - Removed unneeded #include.
3909     
3910 2014-07-26  Filip Pizlo  <fpizlo@apple.com>
3911
3912         Unreviewed, roll out r171641-r171644. It broke some tests; will investigate and
3913         reland later.
3914
3915         * WebView/WebScriptDebugDelegate.mm:
3916
3917 2014-07-25  Filip Pizlo  <fpizlo@apple.com>
3918
3919         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.
3920
3921     2014-07-25  Mark Lam  <mark.lam@apple.com>
3922     
3923             [ftlopt] Renamed DebuggerActivation to DebuggerScope.
3924             <https://webkit.org/b/134273>
3925     
3926             Reviewed by Michael Saboff.
3927     
3928             * WebView/WebScriptDebugDelegate.mm:
3929             - Removed unneeded #include.
3930     
3931 2014-07-25  Jeremy Jones  <jeremyj@apple.com>
3932
3933         Parent fullscreen from window instead of view
3934         https://bugs.webkit.org/show_bug.cgi?id=135310
3935
3936         Reviewed by Jer Noble.
3937
3938         Parenting in the view causes an incorrect animation to fullscreen, and can cause 
3939         fullscreen to only expand to the size of the view instead of the whole window.
3940
3941         * WebView/WebView.mm:
3942         (-[WebView _enterFullscreenForNode:]): Pass window instead of view.
3943
3944 2014-07-24  Pratik Solanki  <psolanki@apple.com>
3945
3946         [iOS] Remove prefs to tweak cache values
3947         https://bugs.webkit.org/show_bug.cgi?id=135274
3948         <rdar://problem/17784826>
3949
3950         Reviewed by Alexey Proskuryakov.
3951
3952         Remove iOS specific code that used to look up user defaults to see if any cache values were
3953         overridden. This was added for testing, is not used any more and is actually harmful now. It
3954         can cause unnecessary memory churn when under memory pressure since we call [WebView _setCacheModel]
3955         as a means to clear out memory cache.
3956
3957         * WebView/WebPreferenceKeysPrivate.h:
3958         * WebView/WebPreferences.mm:
3959         (+[WebPreferences initialize]):
3960         (-[WebPreferences _setNSURLMemoryCacheSize:]): Deleted.
3961         (-[WebPreferences _NSURLMemoryCacheSize]): Deleted.
3962         (-[WebPreferences _setNSURLDiskCacheSize:]): Deleted.
3963         (-[WebPreferences _NSURLDiskCacheSize]): Deleted.
3964         * WebView/WebPreferencesPrivate.h:
3965         * WebView/WebView.mm:
3966         (+[WebView _setCacheModel:]):
3967
3968 2014-07-24  Peyton Randolph  <prandolph@apple.com>
3969
3970         Rename feature flag for long-press gesture on Mac.                                                                   
3971         https://bugs.webkit.org/show_bug.cgi?id=135259                                                                 
3972
3973         Reviewed by Beth Dakin.
3974
3975         * Configurations/FeatureDefines.xcconfig:
3976         Rename LINK_LONG_PRESS to MAC_LONG_PRESS.
3977
3978 2014-07-24  Dan Bernstein  <mitz@apple.com>
3979
3980         WebKit part of <rdar://problem/17766348> [Cocoa] WebCore::ProtectionSpace doesn’t preserve all NSURLProtectionSpace properties, such as the distinguishedNames array
3981         https://bugs.webkit.org/show_bug.cgi?id=135229
3982
3983         Reviewed by Alexey Proskuryakov.
3984
3985         * Misc/WebDownload.mm:
3986         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Chanegd to use the
3987         ProtectionSpace constructor that takes an NSURLProtectionSpace.
3988
3989         * Plugins/WebBaseNetscapePluginView.mm:
3990         (WebKit::getAuthenticationInfo): Ditto.
3991
3992         * WebCoreSupport/WebFrameLoaderClient.mm:
3993         (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Changed to use
3994         ProtectionSpace::nsSpace.
3995
3996 2014-07-23  Bem Jones-Bey  <bjonesbe@adobe.com>
3997
3998         Remove CSS_EXCLUSIONS compile flag and leftover code
3999         https://bugs.webkit.org/show_bug.cgi?id=135175
4000
4001         Reviewed by Zoltan Horvath.
4002
4003         At this point, the CSS_EXCLUSIONS flag guards nothing but some useless
4004         stubs. This removes the flag and the useless code.
4005
4006         * Configurations/FeatureDefines.xcconfig:
4007
4008 2014-07-22  Enrica Casucci  <enrica@apple.com>
4009
4010         REGRESSION (WebKit2): Selection inside accelerated overflow:scroll doesn't track scrolling.
4011         https://bugs.webkit.org/show_bug.cgi?id=135180
4012         <rdar://problem/16721055>
4013
4014         Reviewed by Simon Fraser.
4015
4016         * WebCoreSupport/WebEditorClient.h:
4017
4018 2014-07-22  Jeremy Jones  <jeremyj@apple.com>
4019
4020         Don't create new UIWindow for video fullscreen.
4021         https://bugs.webkit.org/show_bug.cgi?id=135038
4022
4023         Reviewed by Darin Adler.
4024
4025         Provide UIView to WebVideoFullscreenController
4026
4027         * WebView/WebView.mm:
4028         (-[WebView _enterFullscreenForNode:]): pass UIView instead of nil
4029
4030 2014-07-21  Pratik Solanki  <psolanki@apple.com>
4031
4032         Unreviewed iOS build fix after r171321.
4033
4034         * WebView/WebView.mm:
4035         (-[WebView _preferencesChanged:]):
4036
4037 2014-07-21  Beth Dakin  <bdakin@apple.com>
4038
4039         WK1 should always setAcceleratedCompositingForFixedPositionEnabled(true) on 
4040         Yosemite
4041         https://bugs.webkit.org/show_bug.cgi?id=135135
4042
4043         Reviewed by Darin Adler.
4044
4045         Get rid of the ChromeClient function, and enable the Setting instead.
4046         * WebCoreSupport/WebChromeClient.h:
4047         * WebCoreSupport/WebChromeClient.mm:
4048         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition): Deleted.
4049         * WebView/WebView.mm:
4050         (-[WebView _preferencesChanged:]):
4051
4052 2014-07-21  Beth Dakin  <bdakin@apple.com>
4053
4054         Build fix.
4055
4056         * WebCoreSupport/WebChromeClient.mm:
4057         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition):
4058
4059 2014-07-21  Beth Dakin  <bdakin@apple.com>
4060
4061         Put position:fixed elements into layers when a WK1 view is layer-backed
4062         https://bugs.webkit.org/show_bug.cgi?id=135075
4063
4064         Reviewed by Darin Adler.
4065
4066         Returns true when the WebHTMLView has a layer.
4067
4068         * WebCoreSupport/WebChromeClient.h:
4069         * WebCoreSupport/WebChromeClient.mm:
4070         (WebChromeClient::requiresAcceleratedCompositingForViewportConstrainedPosition):
4071
4072 2014-07-18  Andy Estes  <aestes@apple.com>
4073
4074         [iOS] Tapping "Allow Website" on a restricted page does not bring up the keypad
4075         https://bugs.webkit.org/show_bug.cgi?id=135072
4076         <rdar://problem/17528188>
4077
4078         Reviewed by David Kilzer.
4079
4080         * WebCoreSupport/WebFrameLoaderClient.h: Override contentFilterDidBlockLoad().
4081         * WebCoreSupport/WebFrameLoaderClient.mm:
4082         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): Reset contentFilterForBlockedLoad to nullptr.
4083         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Check if this is navigation represents an
4084         unblock request and ignore if so.
4085         * WebView/WebFrame.mm:
4086         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Called ContentFilter::handleUnblockRequestAndDispatchIfSuccessful().
4087         If the unblock is successful, reload the main frame.
4088         * WebView/WebFrameInternal.h:
4089
4090 2014-07-17  David Kilzer  <ddkilzer@apple.com>
4091
4092         SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig
4093         <http://webkit.org/b/135006>
4094
4095         Reviewed by Darin Adler.
4096
4097         * Configurations/Base.xcconfig: Move SECTORDER_FLAGS to
4098         WebKitLegacy.xcconfig.
4099         * Configurations/DebugRelease.xcconfig: Remove empty
4100         SECTORDER_FLAGS definition.
4101         * Configurations/WebKit.xcconfig: Removed.  Unused.
4102         * Configurations/WebKitLegacy.xcconfig: Use $(CONFIGURATION) so
4103         SECTORDER_FLAGS is only set on Production builds.
4104
4105 2014-07-17  Timothy Hatcher  <timothy@apple.com>
4106
4107         Make console.profile record to the Timeline.
4108
4109         https://bugs.webkit.org/show_bug.cgi?id=134643
4110
4111         Reviewed by Joseph Pecoraro.
4112
4113         * WebInspector/WebInspector.mm:
4114         (-[WebInspector isProfilingJavaScript]):
4115         (-[WebInspector toggleProfilingJavaScript:]):
4116         (-[WebInspector startProfilingJavaScript:]):
4117         (-[WebInspector stopProfilingJavaScript:]):
4118         (-[WebInspector isJavaScriptProfilingEnabled]):
4119         (-[WebInspector setJavaScriptProfilingEnabled:]):
4120
4121 2014-07-16  David Kilzer  <ddkilzer@apple.com>
4122
4123         [iOS] Update order file paths for WebKit and WebKit2
4124         <http://webkit.org/b/134993>
4125         <rdar://problem/17557776>
4126
4127         Reviewed by Darin Adler.
4128
4129         * Configurations/Base.xcconfig: Rename WebKit.order to
4130         WebKitLegacy.order.
4131
4132 2014-07-16  Brady Eidson  <beidson@apple.com>
4133
4134         Add WebSecurityOrigin "webSecurityOriginFromDatabaseIdentifier" SPI and change _websiteDataURLForContainerWithURL: SPI
4135         <rdar://problem/17454712> and https://bugs.webkit.org/show_bug.cgi?id=134984
4136
4137         Reviewed by Dan Bernstein.
4138
4139         * WebCoreSupport/WebSecurityOrigin.mm:
4140         (+[WebSecurityOrigin webSecurityOriginFromDatabaseIdentifier:]): Added.
4141         (-[WebSecurityOrigin initWithURL:]): Update using RefPtr API to avoid a ref().
4142
4143 2014-07-15  Myles C. Maxfield  <mmaxfield@apple.com>
4144
4145         [OSX] [WK1] Crash when exiting fullscreen
4146         https://bugs.webkit.org/show_bug.cgi?id=134943
4147
4148         Reviewed by Dean Jackson.
4149
4150         AppKit doesn't remove a view from the Key View Loop when removing it from its superview.
4151
4152         This codepath is already "tested" in fullscreen/full-screen-cancel.html, but because of our
4153         testing infrastructure, the broken codepath doesn't actually get hit in DRT. Therefore,
4154         there is no test.
4155
4156         * WebView/WebFullScreenController.mm:
4157         (-[WebFullScreenController enterFullScreen:]):
4158
4159         * WebCoreSupport/WebSecurityOriginPrivate.h:
4160
4161 2014-07-14  Bear Travis  <betravis@adobe.com>
4162
4163         [Feature Queries] Enable Feature Queries on Mac
4164         https://bugs.webkit.org/show_bug.cgi?id=134404
4165
4166         Reviewed by Antti Koivisto.
4167
4168         Enable Feature Queries on Mac and resume running the
4169         feature tests.
4170
4171         * Configurations/FeatureDefines.xcconfig: Turn on
4172         ENABLE_CSS3_CONDITIONAL_RULES.
4173
4174 2014-07-11  Zalan Bujtas  <zalan@apple.com>
4175
4176         Subpixel layout: return integral results for offset*, client*, scroll* by default.
4177         https://bugs.webkit.org/show_bug.cgi?id=134651
4178
4179         Reviewed by Simon Fraser.
4180
4181         Revert to returning integral values for Element.offset* client* scroll* by default.
4182         Fractional values break number of sites(tight design) and JS frameworks(fail to handle fractional values).
4183
4184         Since snapped dimension depends on both the original point and the width/height of the box,
4185         we need to call RenderBoxModelObject::pixelSnapped*() helpers, instead of round().
4186
4187         Covered by existing tests
4188
4189         * WebView/WebPreferences.mm:
4190         (+[WebPreferences initialize]):
4191
4192 2014-07-10  Joseph Pecoraro  <pecoraro@apple.com>
4193
4194         [Mac] NSWindow warning: adding an unknown subview openi