2011-04-20 Dominic Cooney <dominicc@chromium.org>
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
2
3         Reviewed by Dimitri Glazkov.
4
5         layoutTestController can create and destroy shadow DOM
6         https://bugs.webkit.org/show_bug.cgi?id=59058
7
8         Support for new methods in Mac DRT.
9
10         * DOM/WebDOMOperations.mm:
11         (-[DOMElement _ensureShadowRoot:]):
12         (-[DOMElement _removeShadowRoot]):
13         * DOM/WebDOMOperationsPrivate.h:
14
15 2011-04-20  Eric Carlson  <eric.carlson@apple.com>
16
17         Reviewed by Dan Bernstein.
18
19         Adopt QTKit API for listing and deleting file in its media cache.
20         <rdar://problem/9130029> 
21
22         * WebCoreSupport/WebSystemInterface.mm:
23         (InitWebCoreSystemInterface): Initialize new functions.
24
25 2011-04-19  Matthew Delaney  <mdelaney@apple.com>
26
27         Reviewed by Simon Fraser.
28
29         WebPreferences in WebKit1 should have CanvasUsesAcceleratedDrawing set to NO by default
30         https://bugs.webkit.org/show_bug.cgi?id=58936
31
32         * WebView/WebPreferences.mm:
33         (+[WebPreferences initialize]):
34
35 2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>
36
37         Reviewed by Pavel Feldman.
38
39         Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
40         https://bugs.webkit.org/show_bug.cgi?id=58883
41
42         * WebCoreSupport/WebFrameLoaderClient.h:
43         * WebCoreSupport/WebFrameLoaderClient.mm:
44         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
45
46 2011-04-18  Jia Pu  <jpu@apple.com>
47
48         Reviewed by Mark Rowe.
49
50         WebKit needs to stop importing <AppKit/NSTextChecker.h>
51         https://bugs.webkit.org/show_bug.cgi?id=58798
52         <rdar://problem/9294938>
53
54         Use public header <AppKit/NSSpellChecker.h> instead.
55
56         * WebCoreSupport/CorrectionPanel.h:
57         * WebCoreSupport/CorrectionPanel.mm:
58         (correctionIndicatorType):
59         (CorrectionPanel::show):
60         (CorrectionPanel::dismissInternal):
61         (CorrectionPanel::handleAcceptedReplacement):
62         * WebCoreSupport/WebEditorClient.mm:
63         * WebView/WebView.mm:
64
65 2011-04-17  Cameron Zwarich  <zwarich@apple.com>
66
67         Reviewed by Timothy Hatcher.
68
69         Stop using -[NSString initWithContentsOfFile:]
70         https://bugs.webkit.org/show_bug.cgi?id=58763
71
72         -[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
73
74         * WebView/WebView.mm:
75         (leakMailQuirksUserScriptContents):
76         (leakOutlookQuirksUserScriptContents):
77
78 2011-04-17  David Kilzer  <ddkilzer@apple.com>
79
80         <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
81         <rdar://problem/9268729>
82
83         Reviewed by Dan Bernstein.
84
85         This replaces support for the WebKitEnableHTTPPipelining user
86         default with methods on the WebCore::ResourceRequest class in
87         WebCore, the WebView class in WebKit1, and the WebContext class
88         in WebKit2.  It also removes support for the
89         WebKitForceHTTPPipeliningPriorityHigh user default which was not
90         needed.
91
92         * WebView/WebView.mm:
93         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
94         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
95         * WebView/WebViewPrivate.h:
96         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
97         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
98
99 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
100
101         Reviewed by Dan Bernstein.
102
103         Assign to self in WebInspectorWindowController constructors
104         https://bugs.webkit.org/show_bug.cgi?id=58749
105
106         * WebCoreSupport/WebInspectorClient.mm:
107         (-[WebInspectorWindowController init]):
108         (-[WebInspectorWindowController initWithInspectedWebView:]):
109
110 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
111
112         Reviewed by Timothy Hatcher.
113
114         Move WebNodeHighlighter into its own file
115         https://bugs.webkit.org/show_bug.cgi?id=58746
116
117         Extract this class into its own file alongside the
118         other WebNodeHighlight files. In doing so do some
119         cleanup on WebInspectorClient removing some methods
120         that were never called.
121
122         * WebCoreSupport/WebInspectorClient.mm:
123         (WebInspectorClient::WebInspectorClient): style fix.
124         * WebInspector/WebNodeHighlighter.h: Added.
125         * WebInspector/WebNodeHighlighter.mm: Added.
126         (-[WebNodeHighlighter initWithInspectedWebView:]): call super init.
127         (-[WebNodeHighlighter dealloc]):
128         (-[WebNodeHighlighter highlightNode:]):
129         (-[WebNodeHighlighter hideHighlight]):
130         (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
131         (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
132
133 2011-04-15  Jia Pu  <jpu@apple.com>
134
135         Reviewed by Dan Bernstein.
136
137         [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
138         https://bugs.webkit.org/show_bug.cgi?id=58717
139
140         Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
141
142         * WebCoreSupport/CorrectionPanel.mm:
143         (CorrectionPanel::show):
144
145 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
146
147         Reviewed by James Robinson.
148
149         Add a flag to guard Page Visibility API changes.
150         https://bugs.webkit.org/show_bug.cgi?id=58464
151
152         * Configurations/FeatureDefines.xcconfig:
153
154 2011-04-15  Oliver Hunt  <oliver@apple.com>
155
156         GC allocate Structure
157         https://bugs.webkit.org/show_bug.cgi?id=58483
158
159         Rolling r83894 r83827 r83810 r83809 r83808 back in with
160         a workaround for the gcc bug seen by the gtk bots
161
162         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
163         * Plugins/Hosted/ProxyInstance.mm:
164         (WebKit::ProxyRuntimeMethod::createStructure):
165         * Plugins/Hosted/ProxyRuntimeObject.h:
166         (WebKit::ProxyRuntimeObject::createStructure):
167
168 2011-04-14  Alexey Proskuryakov  <ap@apple.com>
169
170         Reviewed by Dan Bernstein.
171
172         WebKit2: Password field input does not switch to ASCII-compatible source
173         https://bugs.webkit.org/show_bug.cgi?id=58583
174         <rdar://problem/9059651>
175
176         Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the
177         necessary logic, needed to return a nil text input context when in password fields.
178
179         * WebView/WebHTMLView.mm:
180         (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop.
181         (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState.
182         (-[WebHTMLView windowDidResignKey:]): Ditto.
183         (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky
184         because the first responder is still different an this point, so set a boolean variable to
185         let _updateSecureInputState know what's going on.
186         (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on.
187         (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and
188         allowed input sources accorsing to current selection.
189         (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState.
190
191 2011-04-15  Sam Weinig  <sam@webkit.org>
192
193         Reviewed by Maciej Stachowiak.
194
195         Make mac WebKit1 use the default localization strategy
196         https://bugs.webkit.org/show_bug.cgi?id=58628
197
198         * WebCoreSupport/WebPlatformStrategies.h:
199         * WebCoreSupport/WebPlatformStrategies.mm:
200         Remove the localization strategy code. The equivalent is now
201         in WebCore/platform/DefaultLocalizationStrategy.cpp.
202
203 2011-04-15  Anna Cavender  <annacc@chromium.org>
204
205         Reviewed by Eric Carlson.
206
207         Renaming TRACK feature define to VIDEO_TRACK
208         https://bugs.webkit.org/show_bug.cgi?id=53556
209
210         * Configurations/FeatureDefines.xcconfig:
211
212 2011-04-14  Pratik Solanki  <psolanki@apple.com>
213
214         Reviewed by David Kilzer.
215
216         Set minimum priority for fast lane connections
217         https://bugs.webkit.org/show_bug.cgi?id=58353
218
219         * WebCoreSupport/WebSystemInterface.mm:
220         (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
221
222 2011-04-13  Sam Weinig  <sam@webkit.org>
223
224         Reviewed by Gavin Barraclough.
225
226         WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
227         <rdar://problem/9260518>
228
229         * WebCoreSupport/WebSystemInterface.mm:
230         (InitWebCoreSystemInterface):
231         Initialize new WKSI functions.
232
233 2011-04-13  David Kilzer  <ddkilzer@apple.com>
234
235         <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
236
237         Reviewed by Anders Carlsson.
238
239         Fixes the following warning with -Wcast-align enabled:
240
241             Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
242                          archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
243                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
244
245         * Plugins/WebBasePluginPackage.mm:
246         (-[WebBasePluginPackage isNativeLibraryData:]): Added
247         COMPILE_ASSERT() to make sure our pointer math is valid.
248         Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
249         by sizeof(uint32_t) to fix the pointer math.  Replaced C-style
250         casts with reinterpret_cast.
251
252 2011-04-12  Enrica Casucci  <enrica@apple.com>
253
254         Reviewed by Alexey Proskuryakov.
255
256         Infinite recursion in WebHTMLView executeSavedKeypressCommands.
257         https://bugs.webkit.org/show_bug.cgi?id=58382
258         <rdar://problem/9239370>
259
260         Execution of some editing commands could trigger a call to selectedRange that
261         internally calls executeSavedKeypressCommands creating an infinite recursion.
262
263         * WebView/WebHTMLView.mm:
264         (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
265         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
266
267 2011-04-12  Alice Liu  <alice.liu@apple.com>
268
269         Reviewed by Sam Weinig.
270
271         https://bugs.webkit.org/show_bug.cgi?id=58292
272         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
273
274         * WebView/WebPreferenceKeysPrivate.h: Add preference key.
275         * WebView/WebPreferences.mm:
276         (+[WebPreferences initialize]): Initialize to false.
277         (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
278         (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
279         * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
280         * WebView/WebView.mm:
281         (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes. 
282
283 2011-04-11  Alexey Proskuryakov  <ap@apple.com>
284
285         Reviewed by Maciej Stachowiak.
286
287         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
288         https://bugs.webkit.org/show_bug.cgi?id=58175
289         <rdar://problem/9060555>
290
291         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
292         should be changed to match WebKit2.
293
294 2011-04-06  Timothy Hatcher  <timothy@apple.com>
295
296         Fix a bug where the context menu does not show in PDF documents if there is no
297         UI delegate or the UI delegate does not respond to the context menu selector.
298
299         https://webkit.org/b/57958
300
301         Reviewed by Darin Adler.
302
303         * WebView/WebView.mm:
304         (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil
305         if UIDelegate is nil or doesn't respond to the selector. So check that
306         here to distinguish between using defaultMenuItems or the delegate
307         really returning nil to say "no context menu".
308
309 2011-04-11  Jer Noble  <jer.noble@apple.com>
310
311         Unreviewed; roll out unintentional change to WebFullScreenController.mm.
312
313         * WebView/WebFullScreenController.mm:
314         (-[WebFullScreenController enterFullscreen:]):
315
316 2011-04-08  Geoffrey Garen  <ggaren@apple.com>
317
318         Reviewed by Oliver Hunt.
319
320         A few heap-related renames and file moves.
321         
322         WeakGCPtr<T> => Weak<T>
323         Global<T> => Strong<T>
324         collector/ => heap/
325         collector/* => heap/*
326         runtime/WeakGCPtr.h => heap/Weak.h
327         
328         (Eventually, even more files should move into the heap directory. Like
329         Heap.h and Heap.cpp, for example.)
330
331         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
332         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
333         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
334         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
335         (WebKit::NetscapePluginInstanceProxy::evaluate):
336         * WebView/WebScriptDebugger.h:
337
338 2011-04-08  Alexey Proskuryakov  <ap@apple.com>
339
340         Reviewed by Darin Adler.
341
342         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
343         https://bugs.webkit.org/show_bug.cgi?id=58175
344         <rdar://problem/9060555>
345
346         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
347         should be changed to match WebKit2.
348
349 2011-04-08  Alpha Lam  <hclam@chromium.org>
350
351         Unreviewed, rolling out r83335.
352         http://trac.webkit.org/changeset/83335
353         https://bugs.webkit.org/show_bug.cgi?id=53556
354
355         GTK and QT bots are broken
356
357         * Configurations/FeatureDefines.xcconfig:
358
359 2011-04-07  Anna Cavender  <annacc@chromium.org>
360
361         Reviewed by Eric Carlson.
362
363         Setup ENABLE(TRACK) feature define
364         https://bugs.webkit.org/show_bug.cgi?id=53556
365
366         * Configurations/FeatureDefines.xcconfig:
367
368 2011-04-08  Maciej Stachowiak  <mjs@apple.com>
369
370         Reviewed by Darin Adler.
371
372         -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
373         https://bugs.webkit.org/show_bug.cgi?id=58128
374         <rdar://problem/9244553>
375         
376         The root of the problem here was an O(N^2) issue - each WebView,
377         upon having its preferences initialized, would broadcast a
378         notification that was listened to by all other WebViews sharing
379         its preferences.
380         
381         To maintain the API contract, I split the notification into two,
382         one that is for public API consumption, and the other which is for
383         internal use only. Changes that don't need to be picked up by
384         other WebViews broadcast the public notification only. And we
385         avoid WebView broadcasting a notification just to get itself to
386         update.
387
388         * Misc/WebIconDatabase.mm:
389         (-[WebIconDatabase _startUpIconDatabase]):
390         (-[WebIconDatabase _shutDownIconDatabase]):
391         * Plugins/WebBaseNetscapePluginView.mm:
392         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
393         (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
394         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
395         (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
396         * WebView/WebPreferences.mm:
397         (-[WebPreferences initWithIdentifier:]):
398         (-[WebPreferences _setStringValue:forKey:]):
399         (-[WebPreferences _setIntegerValue:forKey:]):
400         (-[WebPreferences _setFloatValue:forKey:]):
401         (-[WebPreferences _setBoolValue:forKey:]):
402         (-[WebPreferences _setLongLongValue:forKey:]):
403         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
404         (-[WebPreferences _postPreferencesChangedNotification]):
405         (-[WebPreferences _postPreferencesChangedAPINotification]):
406         * WebView/WebPreferencesPrivate.h:
407         * WebView/WebView.mm:
408         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
409         (-[WebView _preferencesChangedNotification:]):
410         (-[WebView _preferencesChanged:]):
411         (-[WebView setUsesPageCache:]):
412         (+[WebView initialize]):
413         (-[WebView setPreferences:]):
414         (-[WebView _keyboardUIMode]):
415         * WebView/WebViewInternal.h:
416
417 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
418
419         Revert ENABLE_TRACK patch due to compile failures.
420
421         * Configurations/FeatureDefines.xcconfig:
422
423 2011-04-07  Alexey Proskuryakov  <ap@apple.com>
424
425         Reviewed by Anders Carlsson.
426
427         REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
428         https://bugs.webkit.org/show_bug.cgi?id=58066
429         <rdar://problem/8965302>
430
431         * WebView/WebHTMLRepresentation.mm:
432         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
433         * WebView/WebHTMLView.mm:
434         (-[WebHTMLView attributedSubstringFromRange:]):
435         (-[WebHTMLView attributedString]):
436         (-[WebHTMLView selectedAttributedString]):
437         Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange.
438
439 2011-04-07  Andy Estes  <aestes@apple.com>
440
441         Reviewed by Darin Adler.
442
443         REGRESSION (r64712): Microsoft Outlook 2011: original message contents
444         not included when replying to an email.
445         https://bugs.webkit.org/show_bug.cgi?id=57794
446         
447         Outlook populates a reply message by creating an empty WebView and
448         using DOM API to populate the WebView's empty document with content
449         from the original message. It expects the initial empty document to
450         simply be "<html></html>", and it proceeds to dynamically create and
451         append a BODY node and add the original message content as a child of
452         that node. Outlook then takes the innerHTML of the frame's first body
453         element and copies it into a *new* document that is displayed and
454         edited in the reply message window.
455         
456         Due to implementing the HTML5 tree building algorithm in r64712,
457         initial empty documents went from being "<html></html>" to being
458         "<html><head></head><body></body></html>". Outlook still dynamically
459         creates a BODY node to parent the original message content, but this
460         BODY node duplicates the one created by the tree builder. When Outlook
461         then takes the innerHTML of the first body element to populate the
462         reply message window it gets the empty body element created by the
463         parser, not the one it created with the original message content.
464         
465         Fix this by injecting a user script into the initial empty document
466         that removes the HEAD and BODY nodes created by the parser. This
467         ensures that the BODY created by Outlook is the only BODY in the
468         document.
469
470         * Misc/OutlookQuirksUserScript.js: Added.
471         * WebView/WebView.mm:
472         (leakMailQuirksUserScriptContents):
473         (-[WebView _injectMailQuirksScript]):
474         (needsOutlookQuirksScript):
475         (leakOutlookQuirksUserScriptContents):
476         (-[WebView _injectOutlookQuirksScript]):
477         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
478
479 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
480
481         Reviewed by David Levin.
482
483         Add QUOTA build flag for unified quota API
484         https://bugs.webkit.org/show_bug.cgi?id=57918
485
486         * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
487
488 2011-04-06  Robert Sesek  <rsesek@chromium.org>
489
490         Reviewed by Alexey Proskuryakov.
491
492         Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
493         https://bugs.webkit.org/show_bug.cgi?id=54969
494
495         * WebView/WebFrame.mm:
496         (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
497         (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
498
499 2011-04-05  Alexey Proskuryakov  <ap@apple.com>
500
501         Reviewed by Darin Adler.
502
503         Move attributedStringFromRange down to WebCore
504         https://bugs.webkit.org/show_bug.cgi?id=57905
505
506         * Misc/WebNSAttributedStringExtras.h: Removed.
507         * Misc/WebNSAttributedStringExtras.mm: Removed.
508         * WebView/WebHTMLRepresentation.mm:
509         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
510         * WebView/WebHTMLView.mm:
511         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
512         (-[WebHTMLView attributedSubstringFromRange:]):
513         (-[WebHTMLView attributedString]):
514         (-[WebHTMLView selectedAttributedString]):
515         * WebView/WebPDFView.mm:
516         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
517
518 2011-04-04  MORITA Hajime  <morrita@google.com>
519
520         Reviewed by Ryosuke Niwa.
521
522         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
523         https://bugs.webkit.org/show_bug.cgi?id=56085
524
525         Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
526         NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
527         for requestCheckingOfString method.
528         
529         * WebCoreSupport/WebEditorClient.h:
530         * WebCoreSupport/WebEditorClient.mm:
531         (toCoreTextCheckingResults):
532         (WebEditorClient::checkTextOfParagraph):
533         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
534         (-[WebEditorSpellCheckResponder perform]):
535         (WebEditorClient::requestCheckingOfString):
536         * WebView/WebFrame.mm:
537         (-[WebFrame markersForSelectionStartAsText]):
538         * WebView/WebFramePrivate.h:
539
540 2011-04-05  Anders Carlsson  <andersca@apple.com>
541
542         Didn't mean to land this.
543
544         * Plugins/WebNetscapePluginView.mm:
545         (-[WebNetscapePluginView getVariable:value:]):
546
547 2011-04-04  David Kilzer  <ddkilzer@apple.com>
548
549         <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
550
551         Reviewed by Alexey Proskuryakov.
552
553         * WebCoreSupport/WebSystemInterface.mm:
554         (InitWebCoreSystemInterface): Added initialization for
555         wkSetHTTPPipeliningMaximumPriority().
556
557 2011-04-04  Alexey Proskuryakov  <ap@apple.com>
558
559         Reviewed by Dan Bernstein.
560
561         REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
562         https://bugs.webkit.org/show_bug.cgi?id=51230
563         <rdar://problem/8780989>
564
565         * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from
566         WebKits to WebCore, because WebKit shouldn't be smart.
567
568 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
569
570         Reviewed by Darin Adler.
571
572         REGRESSION: Assertion failure when executing a complex custom key binding
573         https://bugs.webkit.org/show_bug.cgi?id=57681
574
575         * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved
576         commands when they can't possibly change the result.
577
578 2011-04-01  Anders Carlsson  <andersca@apple.com>
579
580         Reviewed by Sam Weinig.
581
582         Shockwave plug-in doesn't accept mouse events
583         https://bugs.webkit.org/show_bug.cgi?id=57653
584         <rdar://problem/8483273>
585
586         Fix an unrelated bug found by the added test.
587
588         * Plugins/WebBaseNetscapePluginView.mm:
589         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
590         Make sure to always set destX and destY.
591
592 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
593
594         Reviewed by Darin Adler.
595
596         Make WebKit2 text input handling more like WebKit1
597         https://bugs.webkit.org/show_bug.cgi?id=57649
598
599         * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView.
600         * WebView/WebHTMLView.mm:
601         (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands.
602         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands.
603         (-[WebHTMLView characterIndexForPoint:]): Ditto.
604         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
605         (-[WebHTMLView selectedRange]): Ditto.
606         (-[WebHTMLView markedRange]): Ditto.
607         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
608         (-[WebHTMLView hasMarkedText]): Ditto.
609         (-[WebHTMLView unmarkText]): Ditto.
610         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument
611         type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't
612         be able to call text input protocol methods from here (and we didn't even reset it back on
613         return). Changed to retrieve all data before starting to apply actions to better match WK2 code.
614         (-[WebHTMLView insertText:]): Ditto.
615
616 2011-04-01  Timothy Hatcher  <timothy@apple.com>
617
618         Make momentum scroll event latching work in WebKit2 on Mac.
619
620         <rdar://problem/8751861>
621
622         Reviewed by Darin Adler.
623
624         * WebCoreSupport/WebSystemInterface.mm:
625         (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
626         * WebView/WebDynamicScrollBarsView.mm:
627         (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.
628
629 2011-03-31  Darin Adler  <darin@apple.com>
630
631         Reviewed by Anders Carlsson.
632
633         Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
634         https://bugs.webkit.org/show_bug.cgi?id=26667
635
636         * WebView/WebHTMLView.mm:
637         (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
638         nil rather than asserting that it is non-nil. One case where WebView will be nil
639         is when the frame is closed, but in any case where it is nil, the correct thing
640         to do is to not try to handle the style key.
641
642 2011-03-31  Alexey Proskuryakov  <ap@apple.com>
643
644         Patch by John Harvey, reviewed and tweaked by me.
645
646         <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
647
648         * Plugins/Hosted/WebTextInputWindowController.m:
649         (-[WebTextInputPanel _interpretKeyEvent:string:]):
650
651 2011-03-31  Evan Martin  <evan@chromium.org>
652
653         Reviewed by Eric Seidel.
654
655         <title> should support dir attribute
656         https://bugs.webkit.org/show_bug.cgi?id=50961
657
658         Update to new FrameLoaderClient interface.
659
660         * WebCoreSupport/WebFrameLoaderClient.h:
661         * WebCoreSupport/WebFrameLoaderClient.mm:
662         (WebFrameLoaderClient::dispatchDidReceiveTitle):
663         (WebFrameLoaderClient::setTitle):
664
665 2011-03-30  Dominic Cooney  <dominicc@google.com>
666
667         Reviewed by Dimitri Glazkov.
668
669         Adds layoutTestController.shadowRoot accessor to Mac DRT.
670         https://bugs.webkit.org/show_bug.cgi?id=57415
671
672         * DOM/WebDOMOperations.mm:
673         (-[DOMElement _shadowRoot:]):
674         * DOM/WebDOMOperationsPrivate.h:
675
676 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
677
678         Reviewed by Darin Adler.
679
680         WebHTMLView shouldn't resend noop: commands
681         https://bugs.webkit.org/show_bug.cgi?id=57504
682         <rdar://problem/9209390>
683
684         * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
685         which we get e.g. when handling Cmd-key combos.
686
687 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
688
689         Reviewed by Darin Adler.
690
691         REGRESSION (r82320): Spacebar no longer pages down
692         https://bugs.webkit.org/show_bug.cgi?id=57423
693         <rdar://problem/9207702>
694
695         Also includes some unrelated cleanup that I had in my tree.
696
697         * WebView/WebHTMLView.mm:
698         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
699         being dispatched to the right frame.
700         (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
701         (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
702         Even if this specific command hasn't been handled, that doesn't nullify side effects from
703         previous commands.
704         (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
705         bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
706         another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
707         going to look at it.
708
709 2011-03-30  Sam Weinig  <sam@webkit.org>
710
711         Reviewed by Brady Eidson.
712
713         WebKit2: Attempting to view css file from url causes it to download
714         <rdar://problem/9102611>
715         https://bugs.webkit.org/show_bug.cgi?id=57501
716
717         * WebView/WebHTMLRepresentation.h:
718         * WebView/WebHTMLRepresentation.mm:
719         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
720         * WebView/WebHTMLView.mm:
721         (+[WebHTMLView unsupportedTextMIMETypes]):
722         Re-factor unsupportedTextMIMETypes to pull from WebCore's
723         MIMETypeRegistry, so that the list can be shared with WebKit2.
724
725 2011-03-29  Beth Dakin  <bdakin@apple.com>
726
727         Reviewed by Maciej Stachowiak.
728
729         Fix for https://bugs.webkit.org/show_bug.cgi?id=57408 
730         webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard 
731         -and corresponding-
732         <rdar://problem/8665411>
733
734         * Misc/WebNSControlExtras.m:
735         (-[NSControl sizeToFitAndAdjustWindowHeight]):
736         * WebCoreSupport/WebChromeClient.mm:
737         (WebChromeClient::scaleFactor):
738         * WebView/WebHTMLView.mm:
739         (-[WebHTMLView viewDidMoveToWindow]):
740         (-[WebHTMLView attachRootLayer:]):
741
742 2011-03-29  Kent Tamura  <tkent@chromium.org>
743
744         Reviewed by Dimitri Glazkov.
745
746         Make validation message bubble testable
747         https://bugs.webkit.org/show_bug.cgi?id=57290
748
749         * WebView/WebView.mm:
750         (-[WebView _preferencesChangedNotification:]): Copy the private value of
751           the timer magnification to WebCore::Settings.
752         (-[WebView validationMessageTimerMagnification]): Added.
753         (-[WebView setValidationMessageTimerMagnification:]): Added.
754         * WebView/WebViewData.h: Declare a member for the timer magnification.
755         * WebView/WebViewData.mm:
756         (-[WebViewPrivate init]): Initialize the timer magnification.
757         * WebView/WebViewPrivate.h:
758           Declare a setter and a getter for the timer magnification.
759
760 2011-03-29  Kent Tamura  <tkent@chromium.org>
761
762         Reviewed by Dimitri Glazkov.
763
764         [Mac] Enable interactive-validation tests on Mac DRT
765         https://bugs.webkit.org/show_bug.cgi?id=57308
766
767         * WebView/WebView.mm:
768         (-[WebView _preferencesChangedNotification:]):
769           Convey a WebView flag for interactive validation to WebCore::Settings.
770         (-[WebView interactiveFormValidationEnabled]): Added.
771         (-[WebView setInteractiveFormValidationEnabled:]): Added.
772         * WebView/WebViewData.h: Add interactiveFormValidationEnabled.
773         * WebView/WebViewData.mm:
774         (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
775         * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
776
777 2011-03-29  Timothy Hatcher  <timothy@apple.com>
778
779         Update the order of the context menu to better match AppKit on Mac.
780
781         <rdar://problem/9054893>
782
783         Reviewed by John Sullivan.
784
785         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
786         (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
787         * WebCoreSupport/WebPlatformStrategies.h:
788         * WebCoreSupport/WebPlatformStrategies.mm:
789         (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
790
791 2011-03-29  Alexey Proskuryakov  <ap@apple.com>
792
793         Reviewed by Darin Adler.
794
795         https://bugs.webkit.org/show_bug.cgi?id=57379
796         Clean up WK1 key event handling logic
797
798         No bugs knowingly fixed, but this makes the code more consistent.
799
800         * WebView/WebHTMLView.mm:
801         (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
802         eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
803         (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
804         from other functions. We need to execute saved commands when an input method asks for current
805         state, because providing stale state could confuse it.
806         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
807         changes.
808         (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
809         the answer would be stale.
810         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
811         (-[WebHTMLView selectedRange]): Ditto.
812         (-[WebHTMLView markedRange]): Ditto.
813         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
814         (-[WebHTMLView hasMarkedText]): Ditto.
815         (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
816         operating on stale data. Also, updated for eventWasHandled renaming.
817         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
818         (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
819         it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
820         fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
821         could have a noop: as one of its commands, although that's hardly practical).
822         Added the same "from input method" logic that we have in insertText: - I don't know of any
823         IMs that call this method, but we clearly need to execute it as part of IM processing when
824         there is marked text.
825         (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
826         eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
827         if current selection isn't editable. This is different from doCommandBySelector:, where we
828         need to give super class a chance to handle the event if our processing fails.
829         Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
830         return value of _interpretKeyEvent is computed differently.
831
832 2011-03-28  Adele Peterson  <adele@apple.com>
833
834         Reviewed by Eric Seidel.
835
836         Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
837         https://bugs.webkit.org/show_bug.cgi?id=57173
838
839         * WebView/WebFrame.mm:
840         (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
841         (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
842         * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
843
844 2011-03-28  Alexey Proskuryakov  <ap@apple.com>
845
846         Reviewed by Darin Adler.
847
848         https://bugs.webkit.org/show_bug.cgi?id=57260
849         Clean up text input code a little
850
851         * WebCoreSupport/WebEditorClient.mm:
852         (WebEditorClient::handleKeyboardEvent):
853         (WebEditorClient::handleInputMethodKeydown):
854         * WebView/WebHTMLViewInternal.h:
855         Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
856         anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
857         and also possibly saves resulting commands for later execution.
858
859         * WebView/WebHTMLView.mm:
860         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
861         return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
862         WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
863         handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
864         because the first call resulted in no saved commands, becasue it's confusing and apparently
865         useless (I couldn't find any broken behavior).
866         (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
867         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
868         (-[WebHTMLView doCommandBySelector:]): Ditto.
869         (-[WebHTMLView insertText:]): Ditto.
870
871         * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
872         method on WebView.
873
874 2011-03-27  Jer Noble  <jer.noble@apple.com>
875
876         Reviewed by Maciej Stachowiak.
877
878         Full Screen: disable keyboard access by default
879         https://bugs.webkit.org/show_bug.cgi?id=56684
880
881         Take into account whether keyboard access was requested when deciding whether full
882         screen mode is supported.
883
884         * WebCoreSupport/WebChromeClient.h:
885         * WebCoreSupport/WebChromeClient.mm:
886         (WebChromeClient::supportsFullScreenForElement):
887         * WebView/WebView.mm:
888         (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
889         * WebView/WebViewInternal.h:
890
891 2011-03-26  Jer Noble  <jer.noble@apple.com>
892
893         Reviewed by Eric Carlson.
894
895         Enable the Full Screen API by default in WebKit/mac and WebKit2
896         https://bugs.webkit.org/show_bug.cgi?id=56956
897
898         * WebView/WebPreferences.mm:
899         (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
900
901 2011-03-25  Andy Estes  <aestes@apple.com>
902
903         Reviewed by Adele Peterson.
904
905         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
906         https://bugs.webkit.org/show_bug.cgi?id=49016
907
908         Update objectContentType() implementation to handle the
909         shouldPreferPlugInsForImages flag.
910
911         * WebCoreSupport/WebFrameLoaderClient.h:
912         * WebCoreSupport/WebFrameLoaderClient.mm:
913         (WebFrameLoaderClient::objectContentType):
914
915 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
916
917         Unreviewed, rolling out r81939.
918         http://trac.webkit.org/changeset/81939
919         https://bugs.webkit.org/show_bug.cgi?id=57084
920
921         Rolling out 81939, as it's causing a number of app cache test
922         failures. (Requested by jernoble on #webkit).
923
924         * WebView/WebView.mm:
925         (-[WebView _preferencesChangedNotification:]):
926
927 2011-03-23  Jer Noble  <jer.noble@apple.com>
928
929         Reviewed by Maciej Stachowiak.
930
931         Application Cache should save audio/ and video/ mime types as flat files
932         https://bugs.webkit.org/show_bug.cgi?id=53784
933         <rdar://problem/8932473>
934
935         No new tests.
936
937         Initialize the AppCache Total size quotas with the values for WebKitPreferences
938         upon startup.
939
940         * WebView/WebView.mm:
941         (-[WebView _preferencesChangedNotification:]):
942
943 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
944
945         Unreviewed, rolling out r81916 and r81917.
946         http://trac.webkit.org/changeset/81916
947         http://trac.webkit.org/changeset/81917
948         https://bugs.webkit.org/show_bug.cgi?id=57071
949
950         broke a test on platforms that do not have QuickTime installed
951         (Requested by estes on #webkit).
952
953         * WebCoreSupport/WebFrameLoaderClient.h:
954         * WebCoreSupport/WebFrameLoaderClient.mm:
955         (WebFrameLoaderClient::objectContentType):
956
957 2011-03-24  Andy Estes  <aestes@apple.com>
958
959         Reviewed by Darin Adler.
960
961         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
962         https://bugs.webkit.org/show_bug.cgi?id=49016
963
964         Update objectContentType() implementation to handle the
965         shouldPreferPlugInsForImages flag.
966
967         * WebCoreSupport/WebFrameLoaderClient.h:
968         * WebCoreSupport/WebFrameLoaderClient.mm:
969         (WebFrameLoaderClient::objectContentType):
970
971 2011-03-24  Geoffrey Garen  <ggaren@apple.com>
972
973         Reviewed by Oliver Hunt.
974
975         Ensure that all compilation takes place within a dynamic global object scope
976         https://bugs.webkit.org/show_bug.cgi?id=57054
977
978         * WebView/WebScriptDebugDelegate.mm:
979         (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
980
981 2011-03-24  Jia Pu  <jpu@apple.com>
982
983         Reviewed by Darin Adler.
984
985         Dismissed reversion suggestion is incorrectly learned.
986         https://bugs.webkit.org/show_bug.cgi?id=57039
987
988         CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
989         [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
990         is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
991         incorrect automatic learning.
992
993         * WebCoreSupport/CorrectionPanel.mm:
994         (CorrectionPanel::dismissInternal):
995
996 2011-03-24  David Kilzer  <ddkilzer@apple.com>
997
998         <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X
999
1000         Reviewed by Joseph Pecoraro.
1001
1002         * Plugins/WebPluginContainerPrivate.h: Changed value of
1003         ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.
1004
1005 2011-03-23  Jia Pu  <jpu@apple.com>
1006
1007         Reviewed by Darin Adler.
1008
1009         Hook up new AppKit autocorrection UI with WK2.
1010         https://bugs.webkit.org/show_bug.cgi?id=56055
1011         <rdar://problem/8947463>
1012
1013         Please see WebCore/ChangeLog for detail.
1014
1015         * WebCoreSupport/CorrectionPanel.h: Added.
1016         (CorrectionPanel::isShowing):
1017         * WebCoreSupport/CorrectionPanel.mm: Added.
1018         (correctionBubbleType):
1019         (CorrectionPanel::CorrectionPanel):
1020         (CorrectionPanel::~CorrectionPanel):
1021         (CorrectionPanel::show):
1022         (CorrectionPanel::dismiss):
1023         (CorrectionPanel::dismissSoon):
1024         (CorrectionPanel::dismissInternal):
1025         (CorrectionPanel::recordAutocorrectionResponse):
1026         * WebCoreSupport/WebEditorClient.h:
1027         * WebCoreSupport/WebEditorClient.mm:
1028         (WebEditorClient::WebEditorClient):
1029         (WebEditorClient::showCorrectionPanel):
1030         (WebEditorClient::dismissCorrectionPanel):
1031         (WebEditorClient::dismissCorrectionPanelSoon):
1032         (WebEditorClient::recordAutocorrectionResponse):
1033         * WebView/WebView.mm:
1034         (-[WebView handleCorrectionPanelResult:]):
1035         * WebView/WebViewPrivate.h:
1036
1037 2011-03-23  Enrica Casucci  <enrica@apple.com>
1038
1039         Reviewed by Alexey Proskuryakov.
1040
1041         Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
1042         https://bugs.webkit.org/show_bug.cgi?id=56974
1043         <rdar://problem/8284642>
1044
1045         This fixes a regression introduced by http://trac.webkit.org/changeset/61794
1046         where readSelectionFromPasteboard was accidentally removed.
1047         This method and writeSelectionToPasteboard are needed to support Mac OS X
1048         services.
1049         
1050         * WebView/WebHTMLView.mm:
1051         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
1052         (-[WebHTMLView readSelectionFromPasteboard:]): Added.
1053
1054 2011-03-23  Brady Eidson  <beidson@apple.com>
1055
1056         Reviewed by Sam Weinig.
1057
1058         Change IconDatabase opening to allow for arbitrary filenames
1059         https://bugs.webkit.org/show_bug.cgi?id=56977
1060
1061         * Misc/WebIconDatabase.mm:
1062         (-[WebIconDatabase _startUpIconDatabase]):
1063
1064 2011-03-22  Anton D'Auria  <adauria@apple.com>
1065
1066         Reviewed by Alexey Proskuryakov.
1067
1068         Add +[WebApplicationCache getOriginsWithCache]
1069         https://bugs.webkit.org/show_bug.cgi?id=56722
1070
1071         Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.
1072
1073         * WebCoreSupport/WebApplicationCache.h:
1074         * WebCoreSupport/WebApplicationCache.mm:
1075         (+[WebApplicationCache originsWithCache]):
1076
1077 2011-03-22  Anders Carlsson  <andersca@apple.com>
1078
1079         Reviewed by Sam Weinig.
1080
1081         OBJECT element with DivX source is always downloaded
1082         https://bugs.webkit.org/show_bug.cgi?id=56879
1083
1084         * Plugins/WebBasePluginPackage.mm:
1085         (-[WebBasePluginPackage getPluginInfoFromPLists]):
1086         Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
1087         specifies multiple file extensions in a single element.
1088
1089 2011-03-22  Brady Eidson  <beidson@apple.com>
1090
1091         Reviewed by Sam Weinig.
1092
1093         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
1094         WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
1095
1096         Note that while the new client calls always come through on the main thread, our mechanisms to
1097         route dispatches to the main thread are still valid and will still work.
1098
1099         Update to the new IconDatabaseClient interface:
1100         * WebCoreSupport/WebIconDatabaseClient.h:
1101         * WebCoreSupport/WebIconDatabaseClient.mm:
1102         (WebIconDatabaseClient::didRemoveAllIcons):
1103         (WebIconDatabaseClient::didImportIconURLForPageURL):
1104         (WebIconDatabaseClient::didImportIconDataForPageURL):
1105         (WebIconDatabaseClient::didChangeIconForPageURL):
1106         (WebIconDatabaseClient::didFinishURLImport):
1107
1108 2011-03-22  Matthew Delaney  <mdelaney@apple.com>
1109
1110         Reviewed by Simon Fraser.
1111
1112         Have WebKit push acceleratedDrawing preferences to settings
1113         https://bugs.webkit.org/show_bug.cgi?id=56792
1114
1115         * WebView/WebView.mm:
1116
1117 2011-03-21  Nate Chapin  <japhet@chromium.org>
1118
1119         Reviewed by Brady Eidson.
1120
1121         Expose a preference to use caching quirks for QuickLook,
1122         and use it if the QuickLook framework is loaded.
1123
1124         https://bugs.webkit.org/show_bug.cgi?id=38690
1125
1126         * WebView/WebPreferenceKeysPrivate.h:
1127         * WebView/WebPreferences.mm:
1128         (useQuickLookQuirks):
1129         (+[WebPreferences initialize]):
1130         (-[WebPreferences useQuickLookResourceCachingQuirks]):
1131         * WebView/WebPreferencesPrivate.h:
1132         * WebView/WebView.mm:
1133         (-[WebView _preferencesChangedNotification:]):
1134
1135 2011-03-21  Chris Fleizach  <cfleizach@apple.com>
1136
1137         Reviewed by Darin Adler.
1138
1139         AX: showContextMenu not working in WK2
1140         https://bugs.webkit.org/show_bug.cgi?id=56734
1141
1142         Implement showContextMenu() so accessibility related code can call this
1143         independent of whether WK1 or WK2 is running.
1144
1145         * WebCoreSupport/WebChromeClient.h:
1146         * WebCoreSupport/WebChromeClient.mm:
1147         (WebChromeClient::showContextMenu):
1148
1149 2011-03-21  Chang Shu  <cshu@webkit.org>
1150
1151         Reviewed by Alexey Proskuryakov.
1152
1153         REGRESSION (r79953): Can't type in MS Outlook 2011
1154         https://bugs.webkit.org/show_bug.cgi?id=56665
1155
1156         r79953 removed the WebView level editablity which is persistent no matter whether
1157         underlying document itself is changed and editability gets lost. The resolution is to
1158         set this WebView editable value to WebCore. This avoids the callback from WebCore to
1159         WebKit which was the main goal in r79953 to improve performance.
1160
1161         * WebView/WebView.mm:
1162         (-[WebView setEditable:]):
1163         (-[WebView isEditable]):
1164
1165 2011-03-19  Anton D'Auria  <adauria@apple.com>
1166
1167         Reviewed by Alexey Proskuryakov.
1168
1169         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1170         https://bugs.webkit.org/show_bug.cgi?id=56415
1171         
1172         Use new ApplicationCache API to delete all cache for an origin.
1173
1174         * WebCoreSupport/WebApplicationCache.h:
1175         * WebCoreSupport/WebApplicationCache.mm:
1176         (+[WebApplicationCache deleteOrigin:]):
1177
1178 2011-03-17  Brady Eidson  <beidson@apple.com>
1179
1180         Reviewed by Sam Weinig.
1181
1182         https://bugs.webkit.org/show_bug.cgi?id=56425
1183         More groundwork for WebKit2 IconDatabase
1184
1185         Update already-used function names:
1186         * Misc/WebIconDatabase.mm:
1187         (-[WebIconDatabase iconForURL:withSize:cache:]):
1188         (-[WebIconDatabase iconURLForURL:]):
1189         * WebView/WebView.mm:
1190         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1191
1192 2011-03-18  Pavel Podivilov  <podivilov@chromium.org>
1193
1194         Reviewed by Yury Semikhatsky.
1195
1196         Web Inspector: implement inspector session storage.
1197         https://bugs.webkit.org/show_bug.cgi?id=56643
1198
1199         * WebCoreSupport/WebInspectorClient.h:
1200         * WebCoreSupport/WebInspectorClient.mm:
1201         (WebInspectorClient::saveSessionSetting):
1202         (WebInspectorClient::loadSessionSetting):
1203         (WebInspectorFrontendClient::saveSessionSetting):
1204         (WebInspectorFrontendClient::loadSessionSetting):
1205         (-[WebInspectorWindowController inspectorClient]):
1206
1207 2011-03-17  Geoffrey Garen  <ggaren@apple.com>
1208
1209         Reviewed by Oliver Hunt.
1210
1211         Fixed a leak seen on the buildbot.
1212
1213         * WebCoreSupport/WebInspectorClient.mm:
1214         (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
1215
1216 2011-03-16  Jeff Johnson  <github@lapcatsoftware.com>
1217
1218         Reviewed by Alexey Proskuryakov.
1219
1220         Logic error in -[WebHTMLView close]
1221         https://bugs.webkit.org/show_bug.cgi?id=56445
1222
1223         Page is always nil at this point, because [self _webView] is nil,
1224         so the conditional code is never run.
1225
1226         * WebView/WebHTMLView.mm:
1227         (-[WebHTMLView close]):
1228
1229 2011-03-16  Chris Fleizach  <cfleizach@apple.com>
1230
1231         Reviewed by Darin Adler.
1232
1233         WK2: Need to propagate enhanced accessibility flag from UI -> web process
1234         https://bugs.webkit.org/show_bug.cgi?id=56379
1235
1236         * WebView/WebFrame.mm:
1237         (-[WebFrame accessibilityRoot]):
1238
1239 2011-03-15  Oliver Hunt  <oliver@apple.com>
1240
1241         Reviewed by Geoffrey Garen.
1242
1243         Make Structure creation require a JSGlobalData
1244         https://bugs.webkit.org/show_bug.cgi?id=56438
1245
1246         Mechanical change to make all Structure creation use a JSGlobalData&
1247
1248         * Plugins/Hosted/ProxyInstance.mm:
1249         (WebKit::ProxyRuntimeMethod::createStructure):
1250         * Plugins/Hosted/ProxyRuntimeObject.h:
1251         (WebKit::ProxyRuntimeObject::createStructure):
1252
1253 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
1254
1255         Forgot to save a modification to this file when committing.
1256
1257         * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
1258
1259 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
1260
1261         Reviewed by Darin Adler.
1262
1263         REGRESSION (WebKit2): keygen element doesn't work
1264         https://bugs.webkit.org/show_bug.cgi?id=56402
1265         <rdar://problem/9006545>
1266
1267         * WebCoreSupport/WebKeyGenerator.h:
1268         * WebCoreSupport/WebKeyGenerator.m: Removed.
1269         * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m.
1270         (+[WebKeyGenerator sharedGenerator]):
1271         (toWebCertificateParseResult):
1272         WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping
1273         this misnamed and misplaced code for now.
1274
1275         * WebCoreSupport/WebPlatformStrategies.h:
1276         * WebCoreSupport/WebPlatformStrategies.mm:
1277         (WebPlatformStrategies::keygenMenuItem512):
1278         (WebPlatformStrategies::keygenMenuItem1024):
1279         (WebPlatformStrategies::keygenMenuItem2048):
1280         (WebPlatformStrategies::keygenKeychainItemName):
1281         Added strings used by keygen.
1282
1283         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore
1284         pointer to a function used by keygen.
1285
1286         * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily
1287         initialized now.
1288
1289 2011-03-15  Beth Dakin  <bdakin@apple.com>
1290
1291         Reviewed by Simon Fraser.
1292
1293         WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
1294
1295         New WebKitystemInterface function to force the scrollbars to flash
1296         * WebCoreSupport/WebSystemInterface.mm:
1297         (InitWebCoreSystemInterface):
1298
1299 2011-03-15  Ilya Sherman  <isherman@chromium.org>
1300
1301         Reviewed by Tony Chang.
1302
1303         Autofilled form elements are assigned fixed background color but not text color
1304         https://bugs.webkit.org/show_bug.cgi?id=48382
1305
1306         * DOM/WebDOMOperations.mm:
1307         (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
1308         * DOM/WebDOMOperationsPrivate.h:
1309
1310 2011-03-15  Adam Roben  <aroben@apple.com>
1311
1312         Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
1313
1314         Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
1315         WebStorageTrackerClient::dispatchDidModifyOrigin
1316
1317         Reviewed by Antti Koivisto.
1318
1319         * Storage/WebStorageTrackerClient.mm:
1320         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
1321         to us by dispatchDidModifyOrigin.
1322         (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
1323         unnecessary cast.
1324
1325 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1326
1327         Reviewed by Darin Adler.
1328
1329         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1330         info into the headers rather than in export symbol definition files, but disable it on 
1331         all platforms initially so we can deal with port build issues one port at a time.
1332         
1333         https://bugs.webkit.org/show_bug.cgi?id=27551
1334
1335         * WebKitPrefix.h:
1336
1337 2011-03-14  Brady Eidson  <beidson@apple.com>
1338
1339         Reviewed by Anders Carlsson.
1340
1341         https://bugs.webkit.org/show_bug.cgi?id=56320
1342         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
1343
1344         * History/WebHistoryItem.mm:
1345         (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
1346
1347 2011-03-13  Pratik Solanki  <psolanki@apple.com>
1348
1349         Reviewed by Brady Eidson.
1350
1351         Make adjustMIMETypeIfNecessary use CFNetwork directly
1352         https://bugs.webkit.org/show_bug.cgi?id=55912
1353
1354         * WebCoreSupport/WebSystemInterface.mm:
1355         (InitWebCoreSystemInterface): Support for new WKSI functions.
1356
1357 2011-03-12  Mark Rowe  <mrowe@apple.com>
1358
1359         Fix the 32-bit build.
1360
1361         * Carbon/CarbonWindowAdapter.mm:
1362         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
1363         (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
1364
1365 2011-03-11  Brady Eidson  <beidson@apple.com>
1366
1367         Reviewed by Anders Carlsson
1368
1369         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
1370         Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
1371
1372         * Misc/WebIconDatabase.mm:
1373         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
1374         (-[WebIconDatabase _startUpIconDatabase]): Ditto.
1375         (importToWebCoreFormat):
1376
1377 2011-03-11  Anton D'Auria  <adauria@apple.com>
1378
1379         Reviewed and landed by Brady Eidson.
1380
1381         https://bugs.webkit.org/show_bug.cgi?id=51878
1382         Add WebKit1 API to view and delete local storage
1383
1384         * Storage/WebStorageManager.mm: Added.
1385         (+[WebStorageManager sharedWebStorageManager]):
1386         (-[WebStorageManager origins]):
1387         (-[WebStorageManager deleteAllOrigins]):
1388         (-[WebStorageManager deleteOrigin:]):
1389         (-[WebStorageManager syncLocalStorage]):
1390         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
1391         (storageDirectoryPath):
1392         (WebKitInitializeStorageIfNecessary):
1393         * Storage/WebStorageManagerInternal.h: Added.
1394         * Storage/WebStorageManagerPrivate.h: Added.
1395         * Storage/WebStorageTrackerClient.h: Added.
1396         * Storage/WebStorageTrackerClient.mm: Added.
1397         (WebStorageTrackerClient::sharedWebStorageTrackerClient):
1398         (WebStorageTrackerClient::WebStorageTrackerClient):
1399         (WebStorageTrackerClient::~WebStorageTrackerClient):
1400         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
1401         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1402         * WebCoreSupport/WebSecurityOrigin.mm:
1403         (-[WebSecurityOrigin protocol]):
1404         (-[WebSecurityOrigin host]):
1405         (-[WebSecurityOrigin databaseIdentifier]):
1406         (-[WebSecurityOrigin domain]):
1407         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
1408         * WebCoreSupport/WebSecurityOriginPrivate.h:
1409         * WebKit.exp:
1410         * WebView/WebView.mm:
1411         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1412
1413 2011-03-10  Anders Carlsson  <andersca@apple.com>
1414
1415         Reviewed by Sam Weinig.
1416
1417         <rdar://problem/9117047>
1418         Don't paint more than 60 times per second even when scrolling
1419
1420         * WebView/WebClipView.mm:
1421         (-[WebClipView _immediateScrollToPoint:]):
1422
1423 2011-03-09  Matthew Delaney  <mdelaney@apple.com>
1424
1425         Reviewed by Simon Fraser.
1426
1427         Plumb through settings for accelerated drawing for canvas
1428         https://bugs.webkit.org/show_bug.cgi?id=56039
1429
1430         * WebView/WebPreferenceKeysPrivate.h:
1431         * WebView/WebPreferences.mm:
1432         * WebView/WebPreferencesPrivate.h:
1433
1434 2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>
1435
1436         Reviewed by Tony Chang.
1437
1438         VisiblePosition's next and previous should take an enum instead of a boolean
1439         https://bugs.webkit.org/show_bug.cgi?id=56135
1440
1441         SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
1442         StayInEditableContent.
1443
1444         * WebView/WebView.mm:
1445         (-[WebView _selectionIsAll]):
1446
1447 2011-03-09  Jessie Berlin  <jberlin@apple.com>
1448
1449         Reviewed by Adam Roben.
1450
1451         Use the Cookie Storage from the Private Browsing Storage Session directly
1452         https://bugs.webkit.org/show_bug.cgi?id=55986
1453
1454         * WebCoreSupport/WebSystemInterface.mm:
1455         (InitWebCoreSystemInterface):
1456
1457 2011-03-08  Darin Adler  <darin@apple.com>
1458
1459         Reviewed by Timothy Hatcher.
1460
1461         Promote a method used outside WebKit from internal to private
1462         https://bugs.webkit.org/show_bug.cgi?id=55949
1463
1464         * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
1465         Minor tweak, not directly related to the rest of this patch.
1466
1467         * WebView/WebFrame.mm:
1468         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
1469         this method from the internal category into the private category.
1470         Streamlined the code a bit.
1471
1472         * WebView/WebFrameInternal.h: Removed _computePageRects method.
1473         * WebView/WebFramePrivate.h: Added _computePageRects method.
1474
1475 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
1476
1477         Reviewed by Darin Adler.
1478
1479         selectionHasStyle and selectionStartHasStyle should use EditingStyle
1480         https://bugs.webkit.org/show_bug.cgi?id=55902
1481
1482         selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
1483
1484         * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
1485         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
1486
1487 2011-03-07  Dan Bernstein  <mitz@apple.com>
1488
1489         LLVM Compiler build fix.
1490
1491         * WebCoreSupport/WebEditorClient.mm:
1492         (WebEditorClient::checkGrammarOfString):
1493
1494 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1495
1496         Reviewed by Beth Dakin.
1497
1498         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
1499         https://bugs.webkit.org/show_bug.cgi?id=55706
1500
1501         Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
1502         returns the scroll bar objects).
1503         Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
1504         will expect that as its child, instead of the WebCore ScrollView object.
1505
1506         * WebView/WebDynamicScrollBarsView.mm:
1507         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
1508         * WebView/WebFrame.mm:
1509         (-[WebFrame accessibilityRoot]):
1510
1511 2011-03-07  Sam Weinig  <sam@webkit.org>
1512
1513         Reviewed by Anders Carlsson.
1514
1515         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1516         https://bugs.webkit.org/show_bug.cgi?id=55827
1517
1518         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
1519         and pass the entire response, instead of just the MIMEType.
1520
1521         * WebCoreSupport/WebFrameLoaderClient.h:
1522         * WebCoreSupport/WebFrameLoaderClient.mm:
1523         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1524
1525 2011-03-06  Dan Bernstein  <mitz@apple.com>
1526
1527         LLVM Compiler build fix.
1528
1529         * DOM/WebDOMOperations.mm:
1530         (-[DOMHTMLInputElement _setValueForUser:]):
1531
1532 2011-03-06  Jessie Berlin  <jberlin@apple.com>
1533
1534         Reviewed by Sam Weinig.
1535
1536         WebKit2: Use CFNetwork Sessions API.
1537         https://bugs.webkit.org/show_bug.cgi?id=55435.
1538
1539         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
1540         Private Browsing Storage Session.
1541
1542         * WebCoreSupport/WebSystemInterface.mm:
1543         (InitWebCoreSystemInterface):
1544         Add support for using the new WKSI functions in WebCore.
1545
1546 2011-03-05  Ilya Sherman  <isherman@chromium.org>
1547
1548         Reviewed by Darin Adler.
1549
1550         HTMLInputElement::setValue() should schedule change event when the element is focused
1551         In service of https://code.google.com/p/chromium/issues/detail?id=42716
1552         https://bugs.webkit.org/show_bug.cgi?id=53160
1553
1554         * DOM/WebDOMOperations.mm:
1555         (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
1556         * DOM/WebDOMOperationsPrivate.h:
1557         * WebView/WebViewInternal.h:
1558
1559 2011-03-04  Jia Pu  <jpu@apple.com>
1560
1561         Reviewed by Darin Adler.
1562
1563         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
1564         https://bugs.webkit.org/show_bug.cgi?id=55717
1565         <rdar://problem/9018127>
1566
1567         With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
1568         is already in window coordinate. We don't need to do further conversion anymore.
1569
1570         * WebCoreSupport/WebEditorClient.mm:
1571         (WebEditorClient::showCorrectionPanel):
1572
1573 2011-03-04  Jessie Berlin  <jberlin@apple.com>
1574
1575         Reviewed by Maciej Stachowiak.
1576
1577         WebKit2: Use CFNetwork Sessions API.
1578         https://bugs.webkit.org/show_bug.cgi?id=55435.
1579
1580         When Private Browsing is enabled, get the cached url response from the cache associated with
1581         the Private Browsing Storage Session.
1582
1583         * WebView/WebView.mm:
1584         (-[WebView _cachedResponseForURL:]):
1585
1586 2011-03-03  Anders Carlsson  <andersca@apple.com>
1587
1588         Reviewed by Sam Weinig.
1589
1590         Get rid of Page::globalHistoryItem
1591         https://bugs.webkit.org/show_bug.cgi?id=55738
1592
1593         * WebCoreSupport/WebFrameLoaderClient.h:
1594         * WebCoreSupport/WebFrameLoaderClient.mm:
1595         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
1596         Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
1597     
1598         * WebView/WebView.mm:
1599         (-[WebView _globalHistoryItem]):
1600         (-[WebView _setGlobalHistoryItem:]):
1601         Set _globalHistoryItem ivar.
1602
1603         * WebView/WebViewData.h:
1604         * WebView/WebViewData.mm:
1605         Add _globalHistoryItem ivar.
1606
1607 2011-03-03  Brady Eidson  <beidson@apple.com>
1608
1609         Reviewed by Darin Adler.
1610
1611         https://bugs.webkit.org/show_bug.cgi?id=55721
1612         Global IconDatabase should be returned by reference, not as a pointer
1613
1614         * Misc/WebCoreStatistics.mm:
1615         (+[WebCoreStatistics iconPageURLMappingCount]):
1616         (+[WebCoreStatistics iconRetainedPageURLCount]):
1617         (+[WebCoreStatistics iconRecordCount]):
1618         (+[WebCoreStatistics iconsWithDataCount]):
1619         * Misc/WebIconDatabase.mm:
1620         (-[WebIconDatabase init]):
1621         (-[WebIconDatabase iconForURL:withSize:cache:]):
1622         (-[WebIconDatabase iconURLForURL:]):
1623         (-[WebIconDatabase defaultIconWithSize:]):
1624         (-[WebIconDatabase retainIconForURL:]):
1625         (-[WebIconDatabase releaseIconForURL:]):
1626         (-[WebIconDatabase isEnabled]):
1627         (-[WebIconDatabase setEnabled:]):
1628         (-[WebIconDatabase removeAllIcons]):
1629         (+[WebIconDatabase _checkIntegrityBeforeOpening]):
1630         (-[WebIconDatabase _startUpIconDatabase]):
1631         (-[WebIconDatabase _applicationWillTerminate:]):
1632         (-[WebIconDatabase _resetCachedWebPreferences:]):
1633         (importToWebCoreFormat):
1634         * WebView/WebView.mm:
1635         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1636
1637 2011-03-03  Jessie Berlin  <jberlin@apple.com>
1638
1639         Reviewed by Adam Roben.
1640
1641         WebKit2: Use CFNetwork Sessions API.
1642         https://bugs.webkit.org/show_bug.cgi?id=55435.
1643
1644         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
1645
1646         * WebCoreSupport/WebSystemInterface.mm:
1647         (InitWebCoreSystemInterface):
1648         Support using WKCopyRequestWithStorageSession in WebCore.
1649
1650 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
1651
1652         Reviewed by Darin Adler.
1653
1654         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
1655         https://bugs.webkit.org/show_bug.cgi?id=55633
1656         <rdar://problem/8963023>
1657
1658         * WebCoreSupport/WebChromeClient.h:
1659         * WebCoreSupport/WebChromeClient.mm:
1660         Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
1661
1662         * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1663         Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
1664         require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
1665         so I've preserved it.
1666
1667 2011-03-02  Jessie Berlin  <jberlin@apple.com>
1668
1669         Rubber-stamped by Dan Bernstein.
1670
1671         Fix crashes in private browsing tests in WK1 on Snow Leopard.
1672
1673         * WebCoreSupport/WebSystemInterface.mm:
1674         (InitWebCoreSystemInterface):
1675         Put the INIT call for wkCreatePrivateStorageSession outside of the
1676         #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
1677         guards.
1678
1679 2011-03-02  Jessie Berlin  <jberlin@apple.com>
1680
1681         Reviewed by Adam Roben.
1682
1683         WebKit2: Use CFNetwork Sessions API.
1684         https://bugs.webkit.org/show_bug.cgi?id=55435.
1685
1686         Add the ability to create a Private Browsing Storage Session.
1687
1688         * WebCoreSupport/WebSystemInterface.mm:
1689         (InitWebCoreSystemInterface):
1690         Support calling wkCreatePrivateStorageSession from WebCore.
1691
1692 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
1693
1694         Reviewed by David Levin.
1695
1696         Add feature define for data transfer items
1697         https://bugs.webkit.org/show_bug.cgi?id=55510
1698
1699         * Configurations/FeatureDefines.xcconfig:
1700
1701 2011-03-02  Sam Weinig  <sam@webkit.org>
1702
1703         Reviewed by Anders Carlsson.
1704
1705         Fix remaining localization issues by piping all localized strings through WebCore's
1706         localization bottleneck.
1707         <rdar://problem/8728860>
1708
1709         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1710         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
1711         * Misc/WebKitErrors.m:
1712         * Misc/WebLocalizableStringsInternal.h: Added.
1713         * Misc/WebLocalizableStringsInternal.mm: Added.
1714         (WebLocalizedStringInternal):
1715         * Panels/WebAuthenticationPanel.m:
1716         (-[WebAuthenticationPanel setUpForChallenge:]):
1717         * Plugins/Hosted/NetscapePluginHostManager.mm:
1718         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1719         * WebCoreSupport/WebEditorClient.mm:
1720         (undoNameForEditAction):
1721         * WebCoreSupport/WebInspectorClient.mm:
1722         (WebInspectorFrontendClient::updateWindowTitle):
1723         (-[WebInspectorWindowController validateUserInterfaceItem:]):
1724         * WebCoreSupport/WebKeyGenerator.m:
1725         (-[WebKeyGenerator strengthMenuItemTitles]):
1726         (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
1727         * WebCoreSupport/WebPlatformStrategies.mm:
1728         * WebView/WebHTMLView.mm:
1729         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1730         * WebView/WebPDFView.mm:
1731         (-[WebPDFView menuForEvent:]):
1732
1733 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
1734
1735         Reviewed by Adam Roben.
1736
1737         Part of WebKit2: Need a way to send notifications to client when cookies change
1738         https://bugs.webkit.org/show_bug.cgi?id=55427
1739         <rdar://problem/9056027>
1740         
1741         Add stubs for CookiesStrategy on Mac WebKit1.
1742
1743         * WebCoreSupport/WebPlatformStrategies.h:
1744         * WebCoreSupport/WebPlatformStrategies.mm:
1745         (WebPlatformStrategies::createCookiesStrategy):
1746         (WebPlatformStrategies::notifyCookiesChanged):
1747
1748 2011-03-01  Philippe Normand  <pnormand@igalia.com>
1749
1750         Reviewed by Eric Carlson.
1751
1752         [GStreamer] support in mac video fullscreen controller
1753         https://bugs.webkit.org/show_bug.cgi?id=52280
1754
1755         Factored the code to configure the video overlay in a new private
1756         method of the controller and added GStreamer support to it.
1757
1758         * WebView/WebVideoFullscreenController.h:
1759         * WebView/WebVideoFullscreenController.mm:
1760         (-[WebVideoFullscreenController setupVideoOverlay:]):
1761         (-[WebVideoFullscreenController windowDidLoad]):
1762         (-[WebVideoFullscreenController setMediaElement:WebCore::]):
1763         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1764
1765 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
1766
1767         Reviewed by Timothy Hatcher.
1768
1769         All Console Messages should be passed to ChromeClients.
1770         https://bugs.webkit.org/show_bug.cgi?id=54926
1771
1772         Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
1773         which supersedes -webView:addMessageToConsole if it exists. The new delegate
1774         does not filter to only JavaScript originated console messages. The old
1775         delegate is left around for clients that expect filtered messages, like
1776         DashCode and older versions of Safari.
1777
1778         The dictionary message passed to the delegate now includes more information
1779         about the message source, type, and level.
1780
1781         * WebCoreSupport/WebChromeClient.mm:
1782         (stringForMessageSource):
1783         (stringForMessageType):
1784         (stringForMessageLevel):
1785         (WebChromeClient::addMessageToConsole):
1786         * WebView/WebUIDelegatePrivate.h:
1787
1788 2011-03-01  Levi Weintraub  <leviw@chromium.org>
1789
1790         Reviewed by Ryosuke Niwa.
1791
1792         Stop instantiating legacy editing Positions in VisiblePosition
1793         https://bugs.webkit.org/show_bug.cgi?id=52919
1794
1795         Changing usage of legacy VisiblePosition constructor. Since we were dealing
1796         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
1797
1798         * WebView/WebFrame.mm:
1799         (-[WebFrame _caretRectAtPosition:affinity:]):
1800         * WebView/WebFrameInternal.h:
1801         * WebView/WebTextCompletionController.mm:
1802         (-[WebTextCompletionController doCompletion]):
1803
1804 2011-03-01  Sam Weinig  <sam@webkit.org>
1805
1806         Reviewed by Timothy Hatcher.
1807
1808         WebKit2 needs to be made localizable
1809         https://bugs.webkit.org/show_bug.cgi?id=55483
1810
1811         * WebCoreSupport/WebPlatformStrategies.mm:
1812         Use WebCore's localizedString function instead of WebLocalizableStrings
1813         since WebCore is now responsible for localization.
1814
1815 2011-02-25 Steve Block <steveblock@google.com>
1816
1817         Reviewed by Jeremy Orlow.
1818
1819         Bridge.h should not include BridgeJSC.h
1820         https://bugs.webkit.org/show_bug.cgi?id=55212
1821
1822         Include BridgeJSC.h directly instead.
1823
1824         * Plugins/Hosted/ProxyInstance.h:
1825         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1826
1827 2011-02-28  Chang Shu  <cshu@webkit.org>
1828
1829         Reviewed by Ryosuke Niwa.
1830
1831         Remove the support of Frame::isContentEditable and its dependencies.
1832         https://bugs.webkit.org/show_bug.cgi?id=54292
1833
1834         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
1835
1836         * WebCoreSupport/WebEditorClient.h:
1837         * WebCoreSupport/WebEditorClient.mm:
1838         * WebView/WebView.mm:
1839         (-[WebView setEditable:]):
1840         (-[WebView isEditable]):
1841         * WebView/WebViewData.h:
1842
1843 2011-02-28  Oliver Hunt  <oliver@apple.com>
1844
1845         Reviewed by Gavin Barraclough.
1846
1847         Make ScopeChainNode GC allocated
1848         https://bugs.webkit.org/show_bug.cgi?id=55283
1849
1850         More updates for the absence of the ScopeChain class
1851
1852         * WebView/WebScriptDebugDelegate.mm:
1853         (-[WebScriptCallFrame scopeChain]):
1854
1855 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
1856
1857         Reviewed by Pavel Feldman.
1858
1859         DumpRenderTree should reset frame opener between tests.
1860         https://bugs.webkit.org/show_bug.cgi?id=54874
1861
1862         Added clearOpener method to WebFramePrivate.
1863
1864         * WebView/WebFrame.mm:
1865         (-[WebFrame _clearOpener]):
1866         * WebView/WebFramePrivate.h:
1867
1868 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1869
1870         Unreviewed, rolling out r79764.
1871         http://trac.webkit.org/changeset/79764
1872         https://bugs.webkit.org/show_bug.cgi?id=55295
1873
1874         "broke Chromium builds" (Requested by rniwa on #webkit).
1875
1876         * WebView/WebFrame.mm:
1877         * WebView/WebFramePrivate.h:
1878
1879 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
1880
1881         Reviewed by David Kilzer.
1882
1883         https://bugs.webkit.org/show_bug.cgi?id=48781
1884
1885         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
1886
1887         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
1888         should paint the default broken image when an image fails to load or decode.  The method also passes the
1889         URL of the failed image.
1890
1891         * WebCoreSupport/WebFrameLoaderClient.h:
1892         * WebCoreSupport/WebFrameLoaderClient.mm:
1893         (WebFrameLoaderClient::shouldPaintBrokenImage):
1894         * WebView/WebDelegateImplementationCaching.h:
1895         * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
1896         (CallResourceLoadDelegateReturningBoolean):
1897         * WebView/WebResourceLoadDelegatePrivate.h:
1898         * WebView/WebView.mm:
1899         (-[WebView _cacheResourceLoadDelegateImplementations]):
1900
1901 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
1902
1903         Reviewed by Pavel Feldman.
1904
1905         DumpRenderTree should reset frame opener between tests.
1906         https://bugs.webkit.org/show_bug.cgi?id=54874
1907
1908         Added clearOpener method to WebFramePrivate.
1909
1910         * WebView/WebFrame.mm:
1911         (-[WebFrame _clearOpener]):
1912         * WebView/WebFramePrivate.h:
1913
1914 2011-02-25  Mark Rowe  <mrowe@apple.com>
1915
1916         <rdar://problem/8902546> Build fix.
1917
1918         * Misc/QuickDrawCompatibility.h:
1919
1920 2011-02-24  Anders Carlsson  <andersca@apple.com>
1921
1922         Fix clang build.
1923
1924         * WebCoreSupport/WebKeyGenerator.m:
1925         (toWebCertificateParseResult):
1926         (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
1927         * WebView/WebTextCompletionController.mm:
1928
1929 2011-02-24  Peter Kasting  <pkasting@google.com>
1930
1931         Reviewed by Eric Seidel.
1932
1933         Drop the "U; " encryption level from the User Agent string.
1934         https://bugs.webkit.org/show_bug.cgi?id=54566
1935
1936         * WebView/WebView.mm:
1937         (+[WebView _standardUserAgentWithApplicationName:]):
1938
1939 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
1940
1941         Unreviewed, rolling out r79570.
1942         http://trac.webkit.org/changeset/79570
1943         https://bugs.webkit.org/show_bug.cgi?id=54874
1944
1945         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
1946         was not updated
1947
1948         * WebView/WebFrame.mm:
1949         * WebView/WebFramePrivate.h:
1950
1951 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
1952
1953         Reviewed by Alexey Proskuryakov.
1954
1955         DumpRenderTree should reset frame opener between tests.
1956         https://bugs.webkit.org/show_bug.cgi?id=54874
1957
1958         Added clearOpener method to WebFramePrivate.
1959
1960         * WebView/WebFrame.mm:
1961         (-[WebFrame _clearOpener]):
1962         * WebView/WebFramePrivate.h:
1963
1964 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1965
1966         Reviewed by Alexey Proskuryakov.
1967
1968         Drop the language tag part from the User Agent string
1969         https://bugs.webkit.org/show_bug.cgi?id=54560
1970
1971         * WebView/WebView.mm:
1972         (+[WebView _standardUserAgentWithApplicationName:]): Drop the
1973         language tag part.
1974
1975 2011-02-22  Brady Eidson  <beidson@apple.com>
1976
1977         Reviewed by Anders Carlsson.
1978
1979         Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
1980         API to view and delete Application Cache data by origin.
1981
1982         * WebCoreSupport/WebApplicationCache.mm:
1983         (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
1984
1985 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
1986
1987         Reviewed by Kent Tamura.
1988
1989         Rename Position::node() to Position::deprecatedNode()
1990         https://bugs.webkit.org/show_bug.cgi?id=54622
1991
1992         * WebView/WebFrame.mm:
1993         (-[WebFrame _smartDeleteRangeForProposedRange:]):
1994
1995 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
1996
1997         Reviewed by Kent Tamura.
1998
1999         Rename Position::node() to Position::deprecatedNode()
2000         https://bugs.webkit.org/show_bug.cgi?id=54622
2001         
2002         Done the rename.
2003
2004         * WebView/WebFrame.mm:
2005         (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
2006         use containerNode() and offsetInContainerNode() instead of deprecated member functions.
2007
2008 2011-02-18  Gavin Barraclough  <barraclough@apple.com>
2009
2010         Reviewed by Sam Weinig.
2011
2012         Bug 54786 - Devirtualize JSCell::classInfo()
2013
2014         Instead of making a virtual function call, add a pointer to the ClassInfo
2015         onto Structure.
2016
2017         This removes a virtual function call, and paves the way towards removing all
2018         the createStructure methods, and StructureFlags/AnonymousSlotCount properties
2019         (these should be able to move onto ClassInfo).
2020
2021         Calls to Structure::create must now pass a pointer to the ClassInfo for the
2022         structure. All objects now have a ClassInfo pointer, non-object cell types
2023         still do not.
2024
2025         Changes are most mechanical, involving three steps:
2026             * Remove virtual classInfo() methods.
2027             * Add &s_info parameter to calls to Structure::create.
2028             * Rename ClassInfo static members on classes from 'info' to 's_info',
2029               for consistency.
2030
2031         * Plugins/Hosted/ProxyInstance.mm:
2032         (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
2033         (WebKit::ProxyRuntimeMethod::createStructure):
2034         * Plugins/Hosted/ProxyRuntimeObject.h:
2035         (WebKit::ProxyRuntimeObject::createStructure):
2036         * Plugins/Hosted/ProxyRuntimeObject.mm:
2037         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2038         * WebView/WebView.mm:
2039         (aeDescFromJSValue):
2040
2041 2011-02-19  Brian Ryner  <bryner@chromium.org>
2042
2043         Reviewed by Adam Barth.
2044
2045         Add missing #include of DocumentLoader.h, needed since the transitive
2046         include through Document.h is removed.
2047         https://bugs.webkit.org/show_bug.cgi?id=50489
2048
2049         * WebView/WebFrame.mm:
2050
2051 2011-02-19  Charlie Reis  <creis@chromium.org>
2052
2053         Reviewed by Mihai Parparita.
2054
2055         Ensure loading has stopped in HistoryController::goToItem
2056         https://bugs.webkit.org/show_bug.cgi?id=54517
2057
2058         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
2059
2060         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
2061
2062         * WebCoreSupport/WebFrameLoaderClient.mm:
2063         (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
2064         * WebCoreSupport/WebFrameLoaderClient.h:
2065
2066 2011-02-16  David Hyatt  <hyatt@apple.com>
2067
2068         Reviewed by Dan Bernstein.
2069
2070         https://bugs.webkit.org/show_bug.cgi?id=54244
2071         
2072         Convert the line box tree to floating point and eliminate font rounding hacks.  This patch removes all of the rounding
2073         hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
2074         
2075         The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
2076         been changed as well.
2077         
2078         In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
2079         
2080         Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
2081         
2082         Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
2083         still have a precise floating point position.
2084
2085         Justification will now allow subpixel positioning to occur as well.  Platforms that don't support subpixel positioning should already
2086         be rounding justification spacing in their font code.
2087
2088         Many layout test results change on Mac, since rounding hacks were used there and are now gone.
2089
2090         * Misc/WebKitNSStringExtras.mm:
2091         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2092         (-[NSString _web_widthWithFont:]):
2093
2094 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
2095
2096         Reviewed by Adam Roben.
2097
2098         HTML5 <details> and <summary>: localized text
2099         https://bugs.webkit.org/show_bug.cgi?id=54260
2100
2101         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
2102         provide the default label to be used by a <details> tag that has no <summary> child.
2103
2104         * WebCoreSupport/WebPlatformStrategies.h:
2105         * WebCoreSupport/WebPlatformStrategies.mm:
2106         (WebPlatformStrategies::defaultDetailsSummaryText):
2107
2108 2011-02-16  Matthew Delaney  <mdelaney@apple.com>
2109
2110         Reviewed by Simon Fraser.
2111
2112         Allow acceleratesDrawing for WebKit2
2113         https://bugs.webkit.org/show_bug.cgi?id=54511
2114
2115         Plumb through preference for accelerated drawing.
2116         
2117         * WebView/WebPreferenceKeysPrivate.h:
2118         * WebView/WebPreferences.mm:
2119         (+[WebPreferences initialize]):
2120         (-[WebPreferences acceleratedDrawingEnabled]):
2121         (-[WebPreferences setAcceleratedDrawingEnabled:]):
2122         * WebView/WebPreferencesPrivate.h:
2123
2124 2011-02-15  David Kilzer  <ddkilzer@apple.com>
2125
2126         <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
2127
2128         Reviewed by Darin Adler.
2129
2130         * WebView/WebDynamicScrollBarsView.h:
2131         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
2132         declaration.
2133         * WebView/WebDynamicScrollBarsView.mm:
2134         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
2135         implementation into correct category.
2136         * WebView/WebDynamicScrollBarsViewInternal.h:
2137         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
2138         declaration.
2139         * WebView/WebHTMLView.mm: Included
2140         WebDynamicScrollBarsViewInternal.h instead of
2141         WebDynamicScrollBarsView.h.
2142
2143 2011-02-14  Oliver Hunt  <oliver@apple.com>
2144
2145         Reviewed by Gavin Barraclough and Geoff Garen.
2146
2147         Refactor handles and weak pointers to become nicer and more automatic
2148         https://bugs.webkit.org/show_bug.cgi?id=54415
2149
2150         Update to use Global<> instead of ProtectedPtr, and refactored slightly
2151         to get global data to places it's needed for when we're assigning to
2152         Global<>s
2153
2154         * ForwardingHeaders/collector/handles/Global.h: Added.
2155         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2156         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2157         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
2158         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
2159         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
2160         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2161         (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
2162         (WebKit::NetscapePluginInstanceProxy::evaluate):
2163         (WebKit::NetscapePluginInstanceProxy::invoke):
2164         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2165         (WebKit::NetscapePluginInstanceProxy::construct):
2166         (WebKit::NetscapePluginInstanceProxy::addValueToArray):
2167         * WebView/WebScriptDebugger.h:
2168         * WebView/WebScriptDebugger.mm:
2169         (WebScriptDebugger::WebScriptDebugger):
2170
2171 2011-02-15  Jia Pu  <jpu@apple.com>
2172
2173         Reviewed by Darin Adler.
2174
2175         Autocorrection should respect undo.
2176         https://bugs.webkit.org/show_bug.cgi?id=52221
2177         <rdar://problem/8663399>
2178
2179         Please see WebCore/ChangeLog for detailed description.
2180
2181         * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
2182
2183         * WebCoreSupport/WebEditorClient.mm:
2184         (WebEditorClient::recordAutocorrectionResponse): Ditto.
2185
2186         * WebView/WebFrame.mm:
2187         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2188              Adopted new signature of ReplaceSelectionCommand::create().
2189
2190 2011-02-15  David Kilzer  <ddkilzer@apple.com>
2191
2192         <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
2193
2194         Reviewed by Darin Adler.
2195
2196         * WebView/WebDynamicScrollBarsView.h:
2197         * WebView/WebDynamicScrollBarsView.mm:
2198         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
2199         -inProgramaticScroll.
2200         * WebView/WebHTMLView.mm:
2201         (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
2202
2203 2011-02-15  Kenneth Russell  <kbr@google.com>
2204
2205         Reviewed by Darin Fisher.
2206
2207         Allow controlling minimum DOMTimer interval on a per-page basis
2208         https://bugs.webkit.org/show_bug.cgi?id=54312
2209
2210         Added needed methods to implement LayoutTestController's new
2211         setMinimumTimerInterval method.
2212
2213         * WebView/WebView.mm:
2214         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2215         (+[WebView _defaultMinimumTimerInterval]):
2216         (-[WebView _setMinimumTimerInterval:]):
2217         * WebView/WebViewPrivate.h:
2218
2219 2011-02-11  Geoffrey Garen  <ggaren@apple.com>
2220
2221         Reviewed by Oliver Hunt.
2222
2223         A little more encapsulation for the heap: Removed CollectorHeapIterator
2224         https://bugs.webkit.org/show_bug.cgi?id=54298
2225
2226         * Misc/WebCoreStatistics.mm:
2227         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
2228         (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
2229
2230 2011-02-10  Nate Chapin  <japhet@chromium.org>
2231
2232         Reviewed by Adam Barth.
2233
2234         Update calls to DocumentWriter.
2235         https://bugs.webkit.org/show_bug.cgi?id=50489
2236
2237         * WebView/WebFrame.mm:
2238         (-[WebFrame _canProvideDocumentSource]):
2239
2240 2011-02-10  Chris Fleizach  <cfleizach@apple.com>
2241
2242         Reviewed by Anders Carlsson.
2243
2244         AX: AX needs to stop using WebCoreViewFactory
2245         https://bugs.webkit.org/show_bug.cgi?id=54153
2246
2247         * WebCoreSupport/WebSystemInterface.mm:
2248         (InitWebCoreSystemInterface):
2249
2250 2011-02-10  Peter Varga  <pvarga@webkit.org>
2251
2252         Reviewed by Csaba Osztrogonác.
2253
2254         Remove PCRE source from trunk
2255         https://bugs.webkit.org/show_bug.cgi?id=54188
2256
2257         * ForwardingHeaders/pcre/pcre.h: Removed.
2258
2259 2011-02-09  Pavel Feldman  <pfeldman@chromium.org>
2260
2261         Reviewed by Yury Semikhatsky.
2262
2263         Web Inspector: follow up on InspectorAgent split -
2264         removing unnecessary methods from InspectorController.
2265         https://bugs.webkit.org/show_bug.cgi?id=54093
2266
2267         * WebInspector/WebInspector.mm:
2268         (-[WebInspector showConsole:]):
2269         (-[WebInspector stopProfilingJavaScript:]):
2270
2271 2011-02-08  Dan Bernstein  <mitz@apple.com>
2272
2273         Reviewed by Jon Honeycutt and Maciej Stachowiak.
2274
2275         <rdar://problem/8959420> Find in Mail no longer cycles around
2276
2277         * WebView/WebHTMLView.mm:
2278         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
2279         the wrap option according to the flag.
2280
2281 2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2282
2283         Unreviewed, rolling out r77980.
2284         http://trac.webkit.org/changeset/77980
2285         https://bugs.webkit.org/show_bug.cgi?id=54043
2286
2287         "Crashes on Windows and Linux..." (Requested by leviw on
2288         #webkit).
2289
2290         * WebView/WebFrame.mm:
2291         (-[WebFrame _caretRectAtNode:offset:affinity:]):
2292         * WebView/WebFrameInternal.h:
2293         * WebView/WebTextCompletionController.mm:
2294         (-[WebTextCompletionController doCompletion]):
2295
2296 2011-02-08  Levi Weintraub  <leviw@chromium.org>
2297
2298         Reviewed by Ryosuke Niwa.
2299
2300         Stop instantiating legacy editing Positions in VisiblePosition
2301         https://bugs.webkit.org/show_bug.cgi?id=52919
2302
2303         Changing usage of legacy VisiblePosition constructor. Since we were dealing
2304         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
2305
2306         * WebView/WebFrame.mm:
2307         (-[WebFrame _caretRectAtPosition:affinity:]):
2308         * WebView/WebFrameInternal.h:
2309         * WebView/WebTextCompletionController.mm:
2310         (-[WebTextCompletionController doCompletion]):
2311
2312 2011-02-08  Adam Barth  <abarth@webkit.org>
2313
2314         Reviewed by Eric Seidel.
2315
2316         Remove orphan code from old parser
2317         https://bugs.webkit.org/show_bug.cgi?id=53984
2318
2319         * WebCoreSupport/WebChromeClient.h:
2320
2321 2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>
2322
2323         Reviewed by Yury Semikhatsky.
2324
2325         Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
2326
2327         https://bugs.webkit.org/show_bug.cgi?id=53169
2328
2329         Minor change enforced by major changes in WebCore/inspector/InspectorController.
2330
2331         * WebInspector/WebInspector.mm:
2332         (-[WebInspector isTimelineProfilingEnabled]):
2333
2334 2011-02-07  Enrica Casucci  <enrica@apple.com>
2335
2336         Reviewed Adam Roben and Darin Adler.
2337
2338         WebKit2: drag and drop support on Windows.
2339         https://bugs.webkit.org/show_bug.cgi?id=52775
2340
2341         Removed createDragImageForLink from DragClient.
2342
2343         * WebCoreSupport/WebDragClient.h:
2344         * WebCoreSupport/WebDragClient.mm:
2345         (WebDragClient::startDrag):
2346
2347 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
2348
2349         Reviewed by Pavel Feldman.
2350
2351         Web Inspector: remove settings related methods from InspectorClient
2352         https://bugs.webkit.org/show_bug.cgi?id=53686
2353
2354         * WebCoreSupport/WebInspectorClient.h:
2355         * WebCoreSupport/WebInspectorClient.mm:
2356         (WebInspectorClient::openInspectorFrontend):
2357         (WebInspectorFrontendClient::WebInspectorFrontendClient):
2358
2359 2011-02-03  James Kozianski  <koz@chromium.org>
2360
2361         Reviewed by Dimitri Glazkov.
2362
2363         Add navigator.registerProtocolHandler behind a flag.
2364         https://bugs.webkit.org/show_bug.cgi?id=52609
2365
2366         * Configurations/FeatureDefines.xcconfig:
2367
2368 2011-02-03  Adam Langley  <agl@chromium.org>
2369
2370         Reviewed by Adam Barth.
2371
2372         Plumb mixed script URL to FrameLoaderClient
2373         https://bugs.webkit.org/show_bug.cgi?id=52384
2374
2375         Regressions covered by http/tests/security/mixedContent/*
2376
2377         * WebCoreSupport/WebFrameLoaderClient.h:
2378         * WebCoreSupport/WebFrameLoaderClient.mm:
2379         (WebFrameLoaderClient::didRunInsecureContent):
2380
2381 2011-02-03  Beth Dakin  <bdakin@apple.com>
2382
2383         Reviewed by Sam Weinig.
2384
2385         Fix for <rdar://problem/8944544> Ability to animate track
2386         for WKPainter scrollers
2387
2388         * WebCoreSupport/WebSystemInterface.mm:
2389         (InitWebCoreSystemInterface):
2390
2391 2011-02-02  Mark Rowe  <mrowe@apple.com>
2392
2393         Reviewed by Beth Dakin.
2394
2395         <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
2396
2397         * WebCoreSupport/WebSystemInterface.mm:
2398         (InitWebCoreSystemInterface): Add some missing initializers.
2399
2400 2011-02-02  Steve Lacey  <sjl@chromium.org>
2401
2402         Reviewed by Eric Carlson.
2403
2404         Implement basic media statistics on media elements.
2405         https://bugs.webkit.org/show_bug.cgi?id=53322
2406
2407         * Configurations/FeatureDefines.xcconfig:
2408
2409 2011-02-01  Sam Weinig  <sam@webkit.org>
2410
2411         Reviewed by Beth Dakin.
2412
2413         Part 2 for <rdar://problem/8492788>
2414         Adopt WKScrollbarPainterController
2415
2416         Use header detection to define scrollbar painting controller #define.
2417
2418         * WebCoreSupport/WebSystemInterface.mm:
2419         (InitWebCoreSystemInterface):
2420
2421 2011-02-01  David Hyatt  <hyatt@apple.com>
2422
2423         Reviewed by Oliver Hunt.
2424
2425         https://bugs.webkit.org/show_bug.cgi?id=53520
2426         
2427         Remove the physical terminology from IntRect and FloatRect.
2428         
2429         Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
2430         we need to update our terminology to be more accurate.
2431
2432         I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
2433         renaming right() and bottom() to maxX() and maxY().  These terms remain accurate
2434         even for flipped rectangles.
2435
2436         * WebView/WebHTMLView.mm:
2437         (setNeedsDisplayInRect):
2438
2439 2011-02-01  Beth Dakin  <bdakin@apple.com>
2440
2441         Reviewed by Sam Weinig.
2442
2443         Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
2444
2445         * WebCoreSupport/WebSystemInterface.mm:
2446         (InitWebCoreSystemInterface):
2447
2448 2011-02-01  Dave Hyatt  <hyatt@apple.com>
2449
2450         Reviewed by Darin Adler.
2451
2452         https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
2453         with vertical text.
2454
2455         Change printing functions to check writing-mode and properly swap width and height
2456         as needed.
2457
2458         * WebView/WebDynamicScrollBarsView.mm:
2459         (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
2460         * WebView/WebFrame.mm:
2461         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
2462         * WebView/WebFrameInternal.h:
2463         * WebView/WebHTMLView.mm:
2464         (-[WebHTMLView _web_setPrintingModeRecursive]):
2465         (-[WebHTMLView _web_clearPrintingModeRecursive]):
2466         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
2467         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
2468         (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
2469         (-[WebHTMLView _endPrintMode]):
2470         (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
2471         (-[WebHTMLView _endScreenPaginationMode]):
2472         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
2473         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
2474         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
2475         (-[WebHTMLView _scaleFactorForPrintOperation:]):
2476         (-[WebHTMLView setPageWidthForPrinting:]):
2477         (-[WebHTMLView knowsPageRange:]):
2478
2479 2011-01-31  Oliver Hunt  <oliver@apple.com>
2480
2481         Convert markstack to a slot visitor API
2482         https://bugs.webkit.org/show_bug.cgi?id=53219
2483
2484         rolling r77098, r77099, r77100, r77109, and
2485         r77111 back in, along with a few more Qt fix attempts.
2486
2487         * WebView/WebScriptDebugDelegate.mm:
2488         (-[WebScriptCallFrame scopeChain]):
2489
2490 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
2491
2492         Unreviewed, rolling out r77098, r77099, r77100, r77109, and
2493         r77111.
2494         http://trac.webkit.org/changeset/77098
2495         http://trac.webkit.org/changeset/77099
2496         http://trac.webkit.org/changeset/77100
2497         http://trac.webkit.org/changeset/77109
2498         http://trac.webkit.org/changeset/77111
2499         https://bugs.webkit.org/show_bug.cgi?id=53219
2500
2501         Qt build is broken
2502
2503         * WebView/WebScriptDebugDelegate.mm:
2504         (-[WebScriptCallFrame scopeChain]):
2505
2506 2011-01-30  Oliver Hunt  <oliver@apple.com>
2507
2508         Convert markstack to a slot visitor API
2509         https://bugs.webkit.org/show_bug.cgi?id=53219
2510
2511         rolling r77006 and r77020 back in.
2512
2513         * WebView/WebScriptDebugDelegate.mm:
2514         (-[WebScriptCallFrame scopeChain]):
2515
2516 2011-01-28  Geoffrey Garen  <ggaren@apple.com>
2517
2518         Reviewed by Maciej Stachowiak.
2519
2520         Some more Heap cleanup.
2521         https://bugs.webkit.org/show_bug.cgi?id=53357
2522
2523         Updated for JavaScriptCore changes.
2524
2525         * Misc/WebCoreStatistics.mm:
2526         (+[WebCoreStatistics memoryStatistics]):
2527
2528 2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2529
2530         Unreviewed, rolling out r77006 and r77020.
2531         http://trac.webkit.org/changeset/77006
2532         http://trac.webkit.org/changeset/77020
2533         https://bugs.webkit.org/show_bug.cgi?id=53360
2534
2535         "Broke Windows tests" (Requested by rniwa on #webkit).
2536
2537         * WebView/WebScriptDebugDelegate.mm:
2538         (-[WebScriptCallFrame scopeChain]):
2539
2540 2011-01-27  Oliver Hunt  <oliver@apple.com>
2541
2542         Reviewed by Geoffrey Garen.
2543
2544         Convert markstack to a slot visitor API
2545         https://bugs.webkit.org/show_bug.cgi?id=53219
2546
2547         Update to new marking api
2548
2549         * WebView/WebScriptDebugDelegate.mm:
2550         (-[WebScriptCallFrame scopeChain]):
2551
2552 2011-01-28  Dan Bernstein  <mitz@apple.com>
2553
2554         Reviewed by Sam Weinig.
2555
2556         <select> can't display right-to-left (rtl) languages
2557         https://bugs.webkit.org/show_bug.cgi?id=19785
2558
2559         * WebCoreSupport/WebChromeClient.h:
2560         * WebCoreSupport/WebChromeClient.mm:
2561         (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
2562         (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
2563
2564 2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2565
2566         Unreviewed, rolling out r76891.
2567         http://trac.webkit.org/changeset/76891
2568         https://bugs.webkit.org/show_bug.cgi?id=53280
2569
2570         Makes every layout test crash (Requested by othermaciej on
2571         #webkit).
2572
2573         * Misc/WebIconDatabase.mm:
2574         (-[ThreadEnabler threadEnablingSelector:]):
2575         (importToWebCoreFormat):
2576
2577 2011-01-27  Nate Chapin  <japhet@chromium.org>
2578
2579         Reviewed by Adam Barth.
2580
2581         Use Document::url() instead of FrameLoader::url().
2582         https://bugs.webkit.org/show_bug.cgi?id=41165
2583
2584         * WebView/WebView.mm:
2585         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2586
2587 2011-01-27  Dan Bernstein  <mitz@apple.com>
2588
2589         Rubber-stamped by Anders Carlsson.
2590
2591         Reverted an accidental change in r76561.
2592
2593         * WebView/WebHTMLView.mm:
2594
2595 2011-01-26  David Kilzer  <ddkilzer@apple.com>
2596
2597         <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
2598         <rdar://problem/8821760>
2599
2600         Reviewed by Antti Koivisto.
2601
2602         * WebCoreSupport/WebSystemInterface.mm:
2603         (InitWebCoreSystemInterface): Added initialization for
2604         GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
2605
2606 2011-01-26  Beth Dakin  <bdakin@apple.com>
2607
2608         Reviewed by Darin Adler.
2609
2610         Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics 
2611         when using WKScrollbars.
2612
2613         * WebCoreSupport/WebSystemInterface.mm:
2614         (InitWebCoreSystemInterface):
2615
2616 2011-01-25  Darin Adler  <darin@apple.com>
2617
2618         Reviewed by Anders Carlsson.
2619
2620         WebKit is using CSBackupSetItemExcluded incorrectly
2621         https://bugs.webkit.org/show_bug.cgi?id=53095
2622         rdar://problem/8790540
2623
2624         * Misc/WebIconDatabase.mm:
2625         (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
2626         It was incorrect, and this responsibility has been moved to WebCore.
2627
2628 2011-01-24  Chris Marrin  <cmarrin@apple.com>
2629
2630         Reviewed by Eric Seidel.
2631
2632         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
2633         https://bugs.webkit.org/show_bug.cgi?id=53041
2634
2635         * Configurations/FeatureDefines.xcconfig:
2636
2637 2011-01-25  Yury Semikhatsky  <yurys@chromium.org>
2638
2639         Reviewed by Pavel Feldman.
2640
2641         Web Inspector: remove "attached" state related methods from InspectorAgent
2642         https://bugs.webkit.org/show_bug.cgi?id=53086
2643
2644         * WebCoreSupport/WebInspectorClient.h:
2645         * WebCoreSupport/WebInspectorClient.mm:
2646         (-[WebInspectorWindowController showWindow:]):
2647         (-[WebInspectorWindowController attach]):
2648         (-[WebInspectorWindowController detach]):
2649
2650 2011-01-23  Dan Bernstein  <mitz@apple.com>
2651
2652         Reviewed by John Sullivan.
2653
2654         <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
2655
2656         * WebCoreSupport/WebChromeClient.mm:
2657         (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
2658
2659 2011-01-22  Alexey Proskuryakov  <ap@apple.com>
2660
2661         Reviewed by Darin Adler.
2662
2663         https://bugs.webkit.org/show_bug.cgi?id=52473
2664         Auto-scaling to avoid orphans is broken, remove dysfunctional code
2665
2666         * WebView/WebHTMLView.mm:
2667         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
2668         (-[WebHTMLView _scaleFactorForPrintOperation:]):
2669         (-[WebHTMLView knowsPageRange:]):
2670
2671 2011-01-21  Mark Rowe  <mrowe@apple.com>
2672
2673         Rubber-stamped by Jon Honeycutt.
2674
2675         Fix the build when using Clang by removing some unused variables.
2676
2677         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2678         (-[WebHostedNetscapePluginView updateAndSetWindow]):
2679         * WebView/WebFullScreenController.mm:
2680         (-[WebFullScreenController enterFullscreen:]):
2681         (-[WebFullScreenController exitFullscreen]):
2682
2683 2011-01-21  Chris Rogers  <crogers@google.com>
2684
2685         Reviewed by Darin Fisher.
2686
2687         Add run-time enable support for the web audio API
2688         https://bugs.webkit.org/show_bug.cgi?id=52741
2689
2690         * WebView/WebPreferenceKeysPrivate.h:
2691         * WebView/WebPreferences.mm:
2692         (-[WebPreferences webAudioEnabled]):
2693         (-[WebPreferences setWebAudioEnabled:]):
2694         * WebView/WebPreferencesPrivate.h:
2695         * WebView/WebView.mm:
2696         (-[WebView _preferencesChangedNotification:]):
2697
2698 2011-01-20  John Sullivan  <sullivan@apple.com>
2699
2700         Reviewed by Mark Rowe.
2701
2702         Shift-tab doesn't cycle through fields in http authentication panel
2703         https://bugs.webkit.org/show_bug.cgi?id=52850
2704
2705         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
2706         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
2707         Re-wired the key loop so that there aren't two views with the same nextKeyView.
2708
2709 2011-01-20  Beth Dakin  <bdakin@apple.com>
2710
2711         Reviewed by Geoffrey Garen.
2712
2713         Fix for <rdar://problem/8890255>
2714
2715         Allow WebKitSystemInterface to draw scrollbars 
2716         when appropriate.
2717         * WebCoreSupport/WebSystemInterface.mm:
2718         (InitWebCoreSystemInterface):
2719
2720 2011-01-19  Simon Fraser  <simon.fraser@apple.com>
2721
2722         Reviewed by Sam Weinig.
2723
2724         GraphicsLayers in subframes can get sync'd multiple times
2725         https://bugs.webkit.org/show_bug.cgi?id=52489
2726
2727         * WebView/WebView.mm:
2728         (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
2729         was renamed to syncCompositingStateIncludingSubframes().
2730
2731 2011-01-19  Darin Adler  <darin@apple.com>
2732
2733         Reviewed by Sam Weinig.
2734
2735         Would like script debugging protocol method to differentiate between caught and uncaught exceptions
2736         https://bugs.webkit.org/show_bug.cgi?id=52104
2737         rdar://problem/8704226
2738
2739         * WebView/WebDelegateImplementationCaching.h:
2740         Fix type of second integer in CallScriptDebugDelegate function overload
2741         to be int to match the actual Objective-C method. Added a new overload
2742         that includes a BOOL in the right place. Added a boolean named
2743         exceptionWasRaisedExpectsHasHandlerFlag.
2744
2745         * WebView/WebDelegateImplementationCaching.mm:
2746         (CallDelegate): Added overloads as above.
2747         (CallScriptDebugDelegate): Ditto.
2748
2749         * WebView/WebScriptDebugDelegate.h: Added new method with the additional
2750         boolean argument. Marked the old method informally deprecated.
2751
2752         * WebView/WebScriptDebugger.mm:
2753         (WebScriptDebugger::exception): Added code to call with or without the
2754         boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
2755
2756         * WebView/WebView.mm:
2757         (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
2758         exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
2759         guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
2760
2761 2011-01-19  Tony Gentilcore  <tonyg@chromium.org>
2762
2763         Reviewed by Mihai Parparita.
2764
2765         Perform some forward declaration
2766         https://bugs.webkit.org/show_bug.cgi?id=52522
2767
2768         * Misc/WebKitNSStringExtras.mm:
2769
2770 2011-01-19  Pavel Podivilov  <podivilov@chromium.org>
2771
2772         Reviewed by Yury Semikhatsky.
2773
2774         Web Inspector: [JSC] scripts have incorrect starting line (always 1).
2775         https://bugs.webkit.org/show_bug.cgi?id=52721
2776
2777         * WebView/WebScriptDebugger.h:
2778         * WebView/WebScriptDebugger.mm:
2779         (toNSString):
2780         (WebScriptDebugger::sourceParsed):
2781
2782 2011-01-19  Levi Weintraub  <leviw@google.com>
2783
2784         Reviewed by Ryosuke Niwa.
2785
2786         Updating to use Position::parentAnchoredEquivalent instead of
2787         the old htmlediting rangeCompliantEquivalent.
2788
2789         remove rangeCompliantEquivalent and replace it with Position methods
2790         https://bugs.webkit.org/show_bug.cgi?id=25057
2791
2792         * WebView/WebFrame.mm:
2793         (-[WebFrame _smartDeleteRangeForProposedRange:]):
2794
2795 2011-01-18  Chris Fleizach  <cfleizach@apple.com>
2796
2797         Reviewed by Darin Adler.
2798
2799         REGRESSION: A problem with Voiceover and finding links
2800         https://bugs.webkit.org/show_bug.cgi?id=52324
2801
2802         * WebView/WebDynamicScrollBarsView.mm:
2803         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
2804
2805 2011-01-17  David Kilzer  <ddkilzer@apple.com>
2806
2807         <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
2808
2809         Reviewed by Dan Bernstein.
2810
2811         * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
2812         DOMDocumentPrivate.h to the PrivateHeaders directory.
2813
2814 2011-01-17  Enrica Casucci  <enrica@apple.com>
2815
2816         Reviewed by Alexey Proskuryakov.
2817
2818         Drag and drop support: refactoring of image from link and image from selection
2819         https://bugs.webkit.org/show_bug.cgi?id=52496
2820
2821         This work cleans up the Mac code and makes it more similar to the Windows implementation,
2822         avoiding the use of an NSView when the FrameView can be used.
2823         The refactoring is a necessary step towards the complete support of drag and drop
2824         in WebKit2.
2825
2826         * WebCoreSupport/WebDragClient.mm:
2827         (WebDragClient::createDragImageForLink): Added.
2828         * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
2829         * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
2830
2831 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
2832
2833         Reviewed by Yury Semikhatsky.
2834
2835         Web Inspector: simplify debugger enabling routine.
2836         https://bugs.webkit.org/show_bug.cgi?id=52472
2837
2838         * WebInspector/WebInspector.mm:
2839         (-[WebInspector startDebuggingJavaScript:]):
2840
2841 2011-01-16  Dan Bernstein  <mitz@apple.com>
2842
2843         Reviewed by Simon Fraser.
2844
2845         Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
2846         https://bugs.webkit.org/show_bug.cgi?id=52550
2847
2848         * Plugins/WebNetscapePluginView.mm:
2849         (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
2850         that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
2851
2852 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
2853
2854         Reviewed by Dan Bernstein.
2855
2856         Issues with iframes and plugins when the WebView is scaled.
2857         <rdar://problem/6213380>
2858         
2859         When _scaleWebView has been called on a WebView, iframes
2860         in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
2861         This is caused by AppKit NSViews not playing nicely with the scale
2862         applied through style.
2863         
2864         Work around most of these issues by adjusting the bounds size
2865         of widgets to allow iframe contents to paint with the correct scale,
2866         and fix various places in the code where we relied on coordinate
2867         transforms via NSViews (which ignore CSS transforms).
2868
2869         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2870         (-[WebHostedNetscapePluginView updateAndSetWindow]):
2871         * WebView/WebFrameView.mm:
2872         (-[WebFrameView setBoundsSize:]):
2873
2874 2011-01-16  Beth Dakin  <bdakin@apple.com>
2875
2876         Reviewed by Kevin Decker.
2877
2878         Fix for <rdar://problem/8871204>
2879
2880         Don't try to save elasticity state. Just rely on
2881         NSScrollElasticityAutomatic to restore the correct state.
2882         * WebCoreSupport/WebFrameLoaderClient.h:
2883         * WebCoreSupport/WebFrameLoaderClient.mm:
2884         (WebFrameLoaderClient::WebFrameLoaderClient):
2885         (WebFrameLoaderClient::dispatchDidFirstLayout):
2886         (WebFrameLoaderClient::provisionalLoadStarted):
2887
2888 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
2889
2890         Reviewed by Dan Bernstein.
2891
2892         Plugins render incorrectly with transformed ancestors
2893         https://bugs.webkit.org/show_bug.cgi?id=52507
2894         
2895         -[NSView visibleRect] gives the wrong answer if there are CSS transforms
2896         in the ancestor chain of a plugin.
2897         
2898         So use of this method with calls to -actualVisibleRectInWindow, which
2899         maps rects through the render tree to compute the correct rect,
2900         clipping via windowClipRect() if necessary.
2901         
2902         Not testable, because doing so relies on the behavior of some
2903         plugins, which stop rendering if setWindow passes an empty rect.
2904
2905         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2906         (-[WebHostedNetscapePluginView updateAndSetWindow]):
2907         * Plugins/WebBaseNetscapePluginView.h:
2908         * Plugins/WebBaseNetscapePluginView.mm:
2909         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
2910         * Plugins/WebNetscapePluginView.mm:
2911         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2912
2913 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
2914
2915         Reviewed by Antti Koivisto.
2916
2917         Rename cache() to memoryCache()
2918         https://bugs.webkit.org/show_bug.cgi?id=52433
2919
2920         * Misc/WebCache.mm:
2921         (+[WebCache statistics]):
2922         (+[WebCache setDisabled:]):
2923         (+[WebCache isDisabled]):
2924         * WebView/WebView.mm:
2925         (+[WebView _setCacheModel:]):
2926
2927 2011-01-13  Geoffrey Garen  <ggaren@apple.com>
2928
2929         Reviewed by Oliver Hunt.
2930
2931         Split out a MarkedSpace strategy object from Heap.
2932         https://bugs.webkit.org/show_bug.cgi?id=52421
2933
2934         * Misc/WebCoreStatistics.mm:
2935         (+[WebCoreStatistics memoryStatistics]): Updated for class move.
2936
2937 2011-01-14  Dan Bernstein  <mitz@apple.com>
2938
2939         Reviewed by Simon Fraser.
2940
2941         WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
2942
2943         * WebView/WebHTMLView.mm:
2944         (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
2945         to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
2946         that the NSView tree doesn’t change from under AppKit as it traverses it.
2947
2948 2011-01-14  Beth Dakin  <bdakin@apple.com>
2949
2950         Reviewed by Mark Rowe.
2951
2952         Fix for <rdar://problem/7793902> Artifacts when scrolling
2953         page in Safari while page is loading
2954
2955         Call setDrawsBackground:YES on the scrollView in 
2956         dispatchDidFirstLayout() rather than waiting until
2957         frameLoadCompleted(). Also suspend scrolling elasticity
2958         between provisionalLoadStarted() and dispatchDidFirstLayout()
2959         * WebCoreSupport/WebFrameLoaderClient.h:
2960         * WebCoreSupport/WebFrameLoaderClient.mm:
2961         (WebFrameLoaderClient::WebFrameLoaderClient):
2962         (WebFrameLoaderClient::dispatchDidFirstLayout):
2963         (WebFrameLoaderClient::provisionalLoadStarted):
2964
2965 2011-01-12  Enrica Casucci  <enrica@apple.com>
2966
2967         Reviewed by Darin Adler.
2968
2969         WebKit2: Add support for drag and drop
2970         https://bugs.webkit.org/show_bug.cgi?id=52343
2971         <rdar://problem/7660558>
2972         
2973         The DragData class has been extended to provide
2974         additional context from the application (keyboard state, modal windows, etc.)
2975         as well as information of the drag pasteboard being used.
2976         These are the changes to align the behavior for WebKit.
2977
2978         * WebView/WebView.mm:
2979         (-[WebView applicationFlags:]): Added.
2980         (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
2981         (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
2982         (-[WebView draggingExited:]): Added parameter to the DragData constructor.
2983         (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
2984
2985 2011-01-12  Beth Dakin  <bdakin@apple.com>
2986
2987         Reviewed by Anders Carlsson.
2988
2989         Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309 
2990         Expose fixed layout through WebKit SPI
2991         -and corresponding-
2992         <rdar://problem/8844464>
2993
2994         And now with getters!
2995         * WebView/WebView.mm:
2996         (-[WebView _useFixedLayout]):
2997         (-[WebView _fixedLayoutSize]):
2998         * WebView/WebViewPrivate.h:
2999
3000 2011-01-12  Beth Dakin  <bdakin@apple.com>
3001
3002         Reviewed by Anders Carlsson.
3003
3004         Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
3005         fixed layout through WebKit SPI
3006         -and corresponding-
3007         <rdar://problem/8844464>
3008
3009         * WebView/WebView.mm:
3010         (-[WebView _setUseFixedLayout:]):
3011         (-[WebView _setFixedLayoutSize:]):
3012         * WebView/WebViewPrivate.h:
3013
3014 2011-01-07  Enrica Casucci  <enrica@apple.com>
3015
3016         Reviewed by Alexey Proskuryakov.
3017
3018         Paste and drag and drop use different code paths to interact with the pasteboard.
3019         https://bugs.webkit.org/show_bug.cgi?id=52093
3020         The change consists in a refactoring of the code to have only one class that
3021         deals with the pasteboard on Mac.
3022
3023         * WebCoreSupport/WebEditorClient.h:
3024         * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
3025         exposed by NSURLExtras.
3026         (WebEditorClient::canonicalizeURL):
3027         (WebEditorClient::canonicalizeURLString):
3028         * WebCoreSupport/WebPasteboardHelper.h: Removed.
3029         * WebCoreSupport/WebPasteboardHelper.mm: Removed.
3030         * WebView/WebHTMLView.mm: Removed comment.
3031         * WebView/WebView.mm: The following methods have been changed to use the new DragData
3032         constructor that doesn't use the WebPasteboardHelper reference.
3033         (-[WebView draggingEntered:]):
3034         (-[WebView draggingUpdated:]):
3035         (-[WebView draggingExited:]):
3036         (-[WebView performDragOperation:]):
3037
3038 2011-01-09  Tony Gentilcore  <tonyg@chromium.org>
3039
3040         Reviewed by Alexey Proskuryakov.
3041
3042         Forward declare some headers where possible
3043         https://bugs.webkit.org/show_bug.cgi?id=52133
3044
3045         * WebView/WebFrame.mm:
3046
3047 2011-01-09  Xianzhu Wang <phnixwxz@gmail.com>
3048
3049         Reviewed by Darin Fisher.
3050
3051         https://bugs.webkit.org/show_bug.cgi?id=41441
3052         createWindow method should only do window-creating without URL navigation
3053
3054         * WebCoreSupport/WebChromeClient.mm:
3055         (WebChromeClient::createWindow):
3056
3057 2011-01-08  Dan Bernstein  <mitz@apple.com>
3058
3059         Try to fix the Leopard build.
3060
3061         * WebView/WebFullScreenController.mm:
3062
3063 2011-01-07  Jer Noble  <jer.noble@apple.com>
3064
3065         Yet another Leopard build fix: NSRect and CGRect are not inter-
3066         changable in 32-bit.  
3067         
3068         * WebView/WebFullScreenController.mm:
3069         (-[WebFullScreenController exitFullscreen]):
3070
3071 2011-01-07  Jer Noble  <jer.noble@apple.com>
3072
3073         Fix the Leopard build: Replace CoreAnimation SL-only functions
3074         with Leopard equivalents.
3075
3076         * WebView/WebFullScreenController.mm:
3077         (+[CATransaction setDisableActions:]):
3078         (+[CATransaction setAnimationDuration:]):
3079         (-[WebFullScreenController _animationDuration]):
3080         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
3081
3082 2010-12-21  Jer Noble  <jer.noble@apple.com>
3083
3084         Reviewed by Simon Fraser.
3085
3086         Implement WebKit Full Screen support.
3087         https://bugs.webkit.org/show_bug.cgi?id=49481
3088         rdar://problem/8247444
3089
3090         Support the new fullscreen Chrome client requests.  WebView will pass
3091         through these requests to a WebFullscreenController.
3092
3093         * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
3094         * WebView/WebView.mm:
3095         (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
3096         (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
3097         (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
3098         (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
3099         * WebView/WebViewData.h: Add ivar newFullscreenController.
3100
3101 2010-12-17  Jer Noble  <jer@kokode.apple.com>
3102
3103         Reviewed by Simon Fraser.
3104
3105         Implement WebKit Full Screen support.
3106         https://bugs.webkit.org/show_bug.cgi?id=49481
3107         rdar://problem/8247444
3108         
3109         This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
3110         Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
3111         window, and a custom CAAnimation animates that layer between the initial screen rect of the
3112         full screen element, to its final value. WebFullscreenController will swap the WebView out of
3113         its original window, and into the fullscreen window. The controller will replace the WebView
3114         with a placeholder view, so that if the placeholder moves or resized while the WebView is
3115         absent, the WebView will move back to the correct location when exiting fullscreen.
3116
3117         * WebView/WebFullscreenController.h: Added.
3118         * WebView/WebFullscreenController.mm: Added.
3119         (-[WebFullscreenController windowDidExitFullscreen:]):  Close the fullscreen window.
3120         (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window. 
3121         (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
3122         (-[WebFullscreenController applicationDidResignActive:]):
3123         (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
3124             the new screen parameters.
3125         (-[WebFullscreenController enterFullscreen:]):  Set up the animation that will take the fullscreen element
3126             from its original screen rect into fullscreen.
3127         (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
3128             Set up the animation that will take the fullscreen element back into its original screen
3129             rect.
3130         (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine 
3131             whether to disable screensaver and sleep.
3132         (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
3133             looking for HTMLVideoElements; returns whether any are found to be playing.
3134         (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
3135             and shift keys.
3136         (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
3137         (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
3138         (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
3139         (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
3140         (-[WebFullscreenWindow setRendererLayer:]): Ditto.
3141         (-[WebFullscreenWindow backgroundLayer]): Ditto.
3142         (-[WebFullscreenWindow animationView]): Ditto.
3143         (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
3144         (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
3145         
3146 2011-01-07  James Robinson  <jamesr@chromium.org>
3147
3148         Revert "Implement mozilla's animationTime property"
3149         https://bugs.webkit.org/show_bug.cgi?id=51952
3150
3151         This approach isn't quite right.
3152
3153         * WebView/WebHTMLView.mm:
3154         (-[WebHTMLView drawRect:]):
3155         * WebView/WebView.mm:
3156         (layerSyncRunLoopObserverCallBack):
3157
3158 2011-01-06  Gavin Barraclough  <barraclough@apple.com>
3159
3160         Reviewed by Geoff Garen.
3161
3162         Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
3163
3164         The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
3165         destructor early, in order to release wrappers once we know we no longer intend to use them.
3166         Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
3167         lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
3168         A sequence of events that triggers the bug would look like this:
3169
3170         (1) Create a DOMWrapperWorld.
3171         (2) Register a timer in the world.
3172         (3) Call unregisterWorld() on the world.
3173         (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
3174         (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
3175             called forgetWorld() none exists.
3176         (6) Attempt to add a wrapper to a NULL map.
3177
3178         Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
3179
3180         * WebView/WebScriptWorld.mm:
3181         (-[WebScriptWorld unregisterWorld]):
3182
3183 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3184
3185         Reviewed by Sam Weinig.
3186
3187         WK2: Support Accessibility
3188         https://bugs.webkit.org/show_bug.cgi?id=51859
3189
3190         Use rootObject() method to get top of AX tree.
3191
3192         * WebCoreSupport/WebFrameLoaderClient.h:
3193         (WebFrameLoaderClient::accessibilityRemoteObject):
3194         * WebView/WebFrame.mm:
3195         (-[WebFrame setAccessibleName:]):
3196         (-[WebFrame accessibilityRoot]):
3197         * WebView/WebFrameInternal.h:
3198         * WebView/WebFramePrivate.h:
3199         * WebView/WebHTMLView.mm:
3200         (-[WebHTMLView accessibilityAttributeValue:]):
3201         (-[WebHTMLView accessibilityFocusedUIElement]):
3202         (-[WebHTMLView accessibilityHitTest:]):
3203         (-[WebHTMLView _accessibilityParentForSubview:]):
3204
3205 2011-01-04  David Kilzer  <ddkilzer@apple.com>
3206
3207         <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
3208
3209         Reviewed by Eric Carlson.
3210
3211         This originally broke in r61581.  It is inside an
3212         ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
3213         build then.
3214
3215         * WebCoreSupport/WebFrameLoaderClient.mm: Call
3216         (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
3217         use WebCore::PluginInfo.name instead of
3218         -[WebBasePluginPackage name].
3219
3220 2011-01-02  Dan Bernstein  <mitz@apple.com>
3221
3222         Rubber-stamped by Simon Fraser.
3223
3224         <rdar://problem/8812159> Update copyright strings
3225
3226         * Info.plist:
3227
3228 2010-12-29  Dan Bernstein  <mitz@apple.com>
3229
3230         Reviewed by Ada Chan.
3231
3232         <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
3233         https://bugs.webkit.org/show_bug.cgi?id=51717
3234
3235         Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
3236         protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
3237
3238         * WebView/WebDocumentInternal.h:
3239         * WebView/WebHTMLView.mm:
3240         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3241         (-[WebHTMLView _findString:options:]):
3242         * WebView/WebView.mm:
3243         (findString):
3244
3245 2010-12-28  Daniel Bates  <dbates@rim.com>
3246
3247         Reviewed by Sam Weinig.
3248
3249         Substitute // MARK: for compiler-specific #pragma mark
3250         https://bugs.webkit.org/show_bug.cgi?id=51657
3251
3252         For consistency, we should substitute "// MARK:" for compiler-
3253         specific "#pragma mark" in the source files for the Mac port.
3254
3255         * History/WebHistory.mm:
3256         * Plugins/WebBaseNetscapePluginView.mm:
3257         * Plugins/WebNetscapePluginView.mm:
3258         * WebCoreSupport/WebInspectorClient.mm:
3259         * WebCoreSupport/WebSecurityOrigin.mm:
3260         * WebView/WebPDFView.mm:
3261         * WebView/WebVideoFullscreenController.mm:
3262         * WebView/WebVideoFullscreenHUDWindowController.mm:
3263
3264 2010-12-23  Yongjun Zhang  <yongjun_zhang@apple.com>
3265
3266         Reviewed by Darin Adler.
3267
3268         WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
3269         https://bugs.webkit.org/show_bug.cgi?id=38535
3270
3271         WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram.  As a result,
3272         if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
3273         WebScriptDebugger's callframe stack is wrong from this point.  That could cause crash if we trying to access the top
3274         call frame from this stack when an exception throws because the saved top frame could be invalid.
3275
3276         To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
3277         callEvent and returnEvent.
3278
3279         * WebView/WebScriptDebugger.mm:
3280         (WebScriptDebugger::willExecuteProgram):
3281         (WebScriptDebugger::didExecuteProgram):
3282
3283 2010-12-22  Sam Weinig  <sam@webkit.org>
3284
3285         Reviewed by Darin Adler.
3286
3287         WebKit2 needs to mirror the frame tree in the UIProcess
3288         https://bugs.webkit.org/show_bug.cgi?id=51546
3289
3290         - Add client functions to notify that a frame has been added or
3291           removed from the page cache.
3292
3293         * WebCoreSupport/WebFrameLoaderClient.h:
3294         * WebCoreSupport/WebFrameLoaderClient.mm:
3295         (WebFrameLoaderClient::didSaveToPageCache):
3296         (WebFrameLoaderClient::didRestoreFromPageCache):
3297
3298 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3299
3300         Reviewed by Eric Seidel.
3301
3302         Editor.h doesn't need to include SelectionController.h
3303         https://bugs.webkit.org/show_bug.cgi?id=51441
3304
3305         Renamed SelectionController::EDirection to SelectionDirection.
3306
3307         * WebView/WebFrame.mm:
3308         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
3309         Takes SelectionDirection instead of SelectionController::EDirection.
3310         * WebView/WebFrameInternal.h:
3311         * WebView/WebTextCompletionController.mm:
3312         (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
3313
3314 2010-12-22  Simon Fraser  <simon.fraser@apple.com>
3315
3316         Reviewed by Darin Adler.
3317
3318         Cache snapshots of plug-ins before painting, to avoid script running during painting
3319         https://bugs.webkit.org/show_bug.cgi?id=51493
3320
3321         When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
3322         or when printing), plug-ins which otherwise use the CA rendering model
3323         are sent a paint event. Some plug-ins may run script while handling this event,
3324         or out of process plug-ins may process queued requests at this time. Running
3325         script while inside layout or painting can have bad consequences, because it
3326         can result in arbitrary changes to the render tree.
3327         
3328         This patch avoids sending plug-ins paint events inside of painting. Instead,
3329         we ask the plug-ins to cache a snapshot before we paint, and then the software
3330         paint simply draws that snapshot.
3331
3332         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3333         (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
3334         draw it. Also only send the snapshot message to the plugin proxy if we
3335         know we're snapshotting, since even if creating the snapshot image failed,
3336         we still don't want to call to the plug-in.
3337
3338         * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
3339         * Plugins/WebBaseNetscapePluginView.mm:
3340         (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
3341         (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
3342
3343         * Plugins/WebNetscapePluginView.mm:
3344         (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
3345         * WebCoreSupport/WebFrameLoaderClient.mm:
3346         (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
3347         to cache and clear the snapshots.
3348
3349 2010-12-21  Cameron Zwarich  <zwarich@apple.com>
3350
3351         Reviewed by Darin Adler.
3352
3353         -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
3354         https://bugs.webkit.org/show_bug.cgi?id=51431
3355         <rdar://problem/8791757>
3356
3357         * Plugins/WebBasePluginPackage.mm:
3358         (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
3359         it doesn't underflow.
3360
3361 2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3362
3363         Reviewed by Cameron Zwarich.
3364
3365         REGRESSION(r74172): 125 java tests fail on Mac
3366         https://bugs.webkit.org/show_bug.cgi?id=51214
3367
3368         The regression was caused by an incorrectly adding sizeof(struct fat_header)
3369         to a pointer for uint32_t as supposed to uint8_t.
3370
3371         Fixed the bug by explicitly casting it to uint8_t* before the addition.
3372
3373         * Plugins/WebBasePluginPackage.mm:
3374         (-[WebBasePluginPackage isNativeLibraryData:]):
3375
3376 2010-12-15  Cameron Zwarich  <zwarich@apple.com>
3377
3378         Reviewed by Darin Adler.
3379
3380         Clang -Wcast-align gives an error in WebBasePluginPackage.mm
3381         https://bugs.webkit.org/show_bug.cgi?id=51144
3382
3383         Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
3384         we were calling it on a byte array 32 bits at a time. While this is okay in practice,
3385         since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
3386         inline storage is at the beginning of the Vector, it is still better to fix this
3387         and silence the warning.
3388
3389         * Plugins/WebBasePluginPackage.mm:
3390         (swapIntsInHeader):
3391         (-[WebBasePluginPackage isNativeLibraryData:]):
3392
3393 2010-12-14  Mark Rowe  <mrowe@apple.com>
3394
3395         Reviewed by Sam Weinig.
3396
3397         <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
3398
3399         * History/WebHistoryItem.mm:
3400         (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
3401         always including the target in the output.
3402
3403 2010-12-13  Alexey Proskuryakov  <ap@apple.com>
3404
3405         Reviewed by Adam Barth.
3406
3407         https://bugs.webkit.org/show_bug.cgi?id=50953
3408         DNS Prefetch should be an opt-in feature
3409
3410         * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
3411
3412 2010-12-13  Mike Thole  <mthole@apple.com>
3413
3414         Rubber-stamped by John Sullivan.
3415
3416         https://bugs.webkit.org/show_bug.cgi?id=50956
3417         WebAuthenticationPanel.nib appears to have a cut-off sentence
3418         
3419         Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
3420         The contents of this text field are updated dynamically before the sheet is displayed.
3421
3422         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
3423         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
3424
3425 2010-12-13  Antti Koivisto  <antti@apple.com>
3426
3427         Reviewed by Alexey Proskuryakov.
3428
3429         https://bugs.webkit.org/show_bug.cgi?id=50758
3430         <rdar://problem/8722094> 
3431         Defer loading print stylesheets
3432         
3433         Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
3434
3435         * WebView/WebView.mm:
3436         (+[WebView _setLoadResourcesSerially:forHost:]):
3437         * WebView/WebViewPrivate.h:
3438
3439 2010-12-09  Matthew Delaney  <mdelaney@apple.com>
3440
3441         Reviewed by Simon Fraser.
3442
3443         Adopt new CG API for canvas
3444         https://bugs.webkit.org/show_bug.cgi?id=50591
3445
3446         * WebCoreSupport/WebSystemInterface.mm:
3447
3448 2010-10-28  MORITA Hajime  <morrita@google.com>
3449
3450         Reviewed by Ojan Vafai.
3451
3452         spellcheck does not check pasted text
3453         https://bugs.webkit.org/show_bug.cgi?id=40092
3454
3455         Added asynchronous spell checking API to WebEditorClient using
3456         -[NSSpellChecker requestCheckingOfString].
3457         Note that WebEditorSpellCheckResponder is a small class to receive
3458         requested spell-checking result. Note that this feature is
3459         disabled at default.
3460         
3461         Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to 
3462         enable the feature from LayoutTestController.
3463
3464         * WebCoreSupport/WebEditorClient.h:
3465         * WebCoreSupport/WebEditorClient.mm:
3466         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
3467         (-[WebEditorSpellCheckResponder perform]):
3468         (toCoreSpellingResult):
3469         (-[WebEditorSpellCheckResponder WTF::WebCore::]):
3470         (WebEditorClient::requestCheckingOfString):
3471         * WebView/WebPreferenceKeysPrivate.h:
3472         * WebView/WebPreferences.mm:
3473         (+[WebPreferences initialize]):
3474         (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
3475         (-[WebPreferences asynchronousSpellCheckingEnabled]):
3476         * WebView/WebPreferencesPrivate.h:
3477         * WebView/WebView.mm:
3478         (-[WebView _preferencesChangedNotification:]):
3479
3480 2010-12-09  Anders Carlsson  <andersca@apple.com>
3481
3482         Fix a bug uncovered by clang++.
3483
3484         * WebView/WebHTMLView.mm:
3485         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3486
3487 2010-12-09  Anders Carlsson  <andersca@apple.com>
3488
3489         Clang++ build fixes.
3490
3491         Silence a couple of warnings.
3492
3493         * WebView/WebFrame.mm:
3494         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
3495         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3496         * WebView/WebTextCompletionController.mm:
3497         (-[WebTextCompletionController filterKeyDown:]):
3498
3499 2010-12-09  David Hyatt  <hyatt@apple.com>
3500
3501         Reviewed by Dan Bernstein.
3502
3503         https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
3504         writing-mode.  This first part of the patch just patches Mac WebKit 1 views.
3505
3506         * WebView/WebFrameView.mm:
3507         (-[WebFrameView _isVerticalDocument]):
3508         (-[WebFrameView _isFlippedDocument]):
3509         (-[WebFrameView _scrollToEndOfDocument]):
3510         (-[WebFrameView _pageInBlockProgressionDirection:]):
3511         (-[WebFrameView scrollPageUp:]):
3512         (-[WebFrameView scrollPageDown:]):
3513
3514 2010-12-08  Andy Estes  <aestes@apple.com>
3515
3516         Reviewed by Darin Adler.
3517
3518         Enable pre-HTML5 parser quirks for Apple Mail.app
3519         https://bugs.webkit.org/show_bug.cgi?id=50727
3520
3521         * WebView/WebView.mm:
3522         (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
3523         application is Mail.app.
3524
3525 2010-12-08  Brian Weinstein  <bweinstein@apple.com>
3526
3527         Reviewed by John Sullivan.
3528
3529         REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
3530         https://bugs.webkit.org/show_bug.cgi?id=50683
3531         
3532         If our context menu item already has an action, don't overwrite the action with the context menu
3533         forwarder.