2011-03-15 Ilya Sherman <isherman@chromium.org>
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         Autofilled form elements are assigned fixed background color but not text color
6         https://bugs.webkit.org/show_bug.cgi?id=48382
7
8         * DOM/WebDOMOperations.mm:
9         (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
10         * DOM/WebDOMOperationsPrivate.h:
11
12 2011-03-15  Adam Roben  <aroben@apple.com>
13
14         Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
15
16         Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
17         WebStorageTrackerClient::dispatchDidModifyOrigin
18
19         Reviewed by Antti Koivisto.
20
21         * Storage/WebStorageTrackerClient.mm:
22         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
23         to us by dispatchDidModifyOrigin.
24         (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
25         unnecessary cast.
26
27 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
28
29         Reviewed by Darin Adler.
30
31         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
32         info into the headers rather than in export symbol definition files, but disable it on 
33         all platforms initially so we can deal with port build issues one port at a time.
34         
35         https://bugs.webkit.org/show_bug.cgi?id=27551
36
37         * WebKitPrefix.h:
38
39 2011-03-14  Brady Eidson  <beidson@apple.com>
40
41         Reviewed by Anders Carlsson.
42
43         https://bugs.webkit.org/show_bug.cgi?id=56320
44         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
45
46         * History/WebHistoryItem.mm:
47         (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
48
49 2011-03-13  Pratik Solanki  <psolanki@apple.com>
50
51         Reviewed by Brady Eidson.
52
53         Make adjustMIMETypeIfNecessary use CFNetwork directly
54         https://bugs.webkit.org/show_bug.cgi?id=55912
55
56         * WebCoreSupport/WebSystemInterface.mm:
57         (InitWebCoreSystemInterface): Support for new WKSI functions.
58
59 2011-03-12  Mark Rowe  <mrowe@apple.com>
60
61         Fix the 32-bit build.
62
63         * Carbon/CarbonWindowAdapter.mm:
64         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
65         (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
66
67 2011-03-11  Brady Eidson  <beidson@apple.com>
68
69         Reviewed by Anders Carlsson
70
71         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
72         Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
73
74         * Misc/WebIconDatabase.mm:
75         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
76         (-[WebIconDatabase _startUpIconDatabase]): Ditto.
77         (importToWebCoreFormat):
78
79 2011-03-11  Anton D'Auria  <adauria@apple.com>
80
81         Reviewed and landed by Brady Eidson.
82
83         https://bugs.webkit.org/show_bug.cgi?id=51878
84         Add WebKit1 API to view and delete local storage
85
86         * Storage/WebStorageManager.mm: Added.
87         (+[WebStorageManager sharedWebStorageManager]):
88         (-[WebStorageManager origins]):
89         (-[WebStorageManager deleteAllOrigins]):
90         (-[WebStorageManager deleteOrigin:]):
91         (-[WebStorageManager syncLocalStorage]):
92         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
93         (storageDirectoryPath):
94         (WebKitInitializeStorageIfNecessary):
95         * Storage/WebStorageManagerInternal.h: Added.
96         * Storage/WebStorageManagerPrivate.h: Added.
97         * Storage/WebStorageTrackerClient.h: Added.
98         * Storage/WebStorageTrackerClient.mm: Added.
99         (WebStorageTrackerClient::sharedWebStorageTrackerClient):
100         (WebStorageTrackerClient::WebStorageTrackerClient):
101         (WebStorageTrackerClient::~WebStorageTrackerClient):
102         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
103         (WebStorageTrackerClient::dispatchDidModifyOrigin):
104         * WebCoreSupport/WebSecurityOrigin.mm:
105         (-[WebSecurityOrigin protocol]):
106         (-[WebSecurityOrigin host]):
107         (-[WebSecurityOrigin databaseIdentifier]):
108         (-[WebSecurityOrigin domain]):
109         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
110         * WebCoreSupport/WebSecurityOriginPrivate.h:
111         * WebKit.exp:
112         * WebView/WebView.mm:
113         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
114
115 2011-03-10  Anders Carlsson  <andersca@apple.com>
116
117         Reviewed by Sam Weinig.
118
119         <rdar://problem/9117047>
120         Don't paint more than 60 times per second even when scrolling
121
122         * WebView/WebClipView.mm:
123         (-[WebClipView _immediateScrollToPoint:]):
124
125 2011-03-09  Matthew Delaney  <mdelaney@apple.com>
126
127         Reviewed by Simon Fraser.
128
129         Plumb through settings for accelerated drawing for canvas
130         https://bugs.webkit.org/show_bug.cgi?id=56039
131
132         * WebView/WebPreferenceKeysPrivate.h:
133         * WebView/WebPreferences.mm:
134         * WebView/WebPreferencesPrivate.h:
135
136 2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>
137
138         Reviewed by Tony Chang.
139
140         VisiblePosition's next and previous should take an enum instead of a boolean
141         https://bugs.webkit.org/show_bug.cgi?id=56135
142
143         SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
144         StayInEditableContent.
145
146         * WebView/WebView.mm:
147         (-[WebView _selectionIsAll]):
148
149 2011-03-09  Jessie Berlin  <jberlin@apple.com>
150
151         Reviewed by Adam Roben.
152
153         Use the Cookie Storage from the Private Browsing Storage Session directly
154         https://bugs.webkit.org/show_bug.cgi?id=55986
155
156         * WebCoreSupport/WebSystemInterface.mm:
157         (InitWebCoreSystemInterface):
158
159 2011-03-08  Darin Adler  <darin@apple.com>
160
161         Reviewed by Timothy Hatcher.
162
163         Promote a method used outside WebKit from internal to private
164         https://bugs.webkit.org/show_bug.cgi?id=55949
165
166         * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
167         Minor tweak, not directly related to the rest of this patch.
168
169         * WebView/WebFrame.mm:
170         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
171         this method from the internal category into the private category.
172         Streamlined the code a bit.
173
174         * WebView/WebFrameInternal.h: Removed _computePageRects method.
175         * WebView/WebFramePrivate.h: Added _computePageRects method.
176
177 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
178
179         Reviewed by Darin Adler.
180
181         selectionHasStyle and selectionStartHasStyle should use EditingStyle
182         https://bugs.webkit.org/show_bug.cgi?id=55902
183
184         selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
185
186         * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
187         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
188
189 2011-03-07  Dan Bernstein  <mitz@apple.com>
190
191         LLVM Compiler build fix.
192
193         * WebCoreSupport/WebEditorClient.mm:
194         (WebEditorClient::checkGrammarOfString):
195
196 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
197
198         Reviewed by Beth Dakin.
199
200         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
201         https://bugs.webkit.org/show_bug.cgi?id=55706
202
203         Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
204         returns the scroll bar objects).
205         Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
206         will expect that as its child, instead of the WebCore ScrollView object.
207
208         * WebView/WebDynamicScrollBarsView.mm:
209         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
210         * WebView/WebFrame.mm:
211         (-[WebFrame accessibilityRoot]):
212
213 2011-03-07  Sam Weinig  <sam@webkit.org>
214
215         Reviewed by Anders Carlsson.
216
217         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
218         https://bugs.webkit.org/show_bug.cgi?id=55827
219
220         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
221         and pass the entire response, instead of just the MIMEType.
222
223         * WebCoreSupport/WebFrameLoaderClient.h:
224         * WebCoreSupport/WebFrameLoaderClient.mm:
225         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
226
227 2011-03-06  Dan Bernstein  <mitz@apple.com>
228
229         LLVM Compiler build fix.
230
231         * DOM/WebDOMOperations.mm:
232         (-[DOMHTMLInputElement _setValueForUser:]):
233
234 2011-03-06  Jessie Berlin  <jberlin@apple.com>
235
236         Reviewed by Sam Weinig.
237
238         WebKit2: Use CFNetwork Sessions API.
239         https://bugs.webkit.org/show_bug.cgi?id=55435.
240
241         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
242         Private Browsing Storage Session.
243
244         * WebCoreSupport/WebSystemInterface.mm:
245         (InitWebCoreSystemInterface):
246         Add support for using the new WKSI functions in WebCore.
247
248 2011-03-05  Ilya Sherman  <isherman@chromium.org>
249
250         Reviewed by Darin Adler.
251
252         HTMLInputElement::setValue() should schedule change event when the element is focused
253         In service of https://code.google.com/p/chromium/issues/detail?id=42716
254         https://bugs.webkit.org/show_bug.cgi?id=53160
255
256         * DOM/WebDOMOperations.mm:
257         (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
258         * DOM/WebDOMOperationsPrivate.h:
259         * WebView/WebViewInternal.h:
260
261 2011-03-04  Jia Pu  <jpu@apple.com>
262
263         Reviewed by Darin Adler.
264
265         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
266         https://bugs.webkit.org/show_bug.cgi?id=55717
267         <rdar://problem/9018127>
268
269         With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
270         is already in window coordinate. We don't need to do further conversion anymore.
271
272         * WebCoreSupport/WebEditorClient.mm:
273         (WebEditorClient::showCorrectionPanel):
274
275 2011-03-04  Jessie Berlin  <jberlin@apple.com>
276
277         Reviewed by Maciej Stachowiak.
278
279         WebKit2: Use CFNetwork Sessions API.
280         https://bugs.webkit.org/show_bug.cgi?id=55435.
281
282         When Private Browsing is enabled, get the cached url response from the cache associated with
283         the Private Browsing Storage Session.
284
285         * WebView/WebView.mm:
286         (-[WebView _cachedResponseForURL:]):
287
288 2011-03-03  Anders Carlsson  <andersca@apple.com>
289
290         Reviewed by Sam Weinig.
291
292         Get rid of Page::globalHistoryItem
293         https://bugs.webkit.org/show_bug.cgi?id=55738
294
295         * WebCoreSupport/WebFrameLoaderClient.h:
296         * WebCoreSupport/WebFrameLoaderClient.mm:
297         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
298         Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
299     
300         * WebView/WebView.mm:
301         (-[WebView _globalHistoryItem]):
302         (-[WebView _setGlobalHistoryItem:]):
303         Set _globalHistoryItem ivar.
304
305         * WebView/WebViewData.h:
306         * WebView/WebViewData.mm:
307         Add _globalHistoryItem ivar.
308
309 2011-03-03  Brady Eidson  <beidson@apple.com>
310
311         Reviewed by Darin Adler.
312
313         https://bugs.webkit.org/show_bug.cgi?id=55721
314         Global IconDatabase should be returned by reference, not as a pointer
315
316         * Misc/WebCoreStatistics.mm:
317         (+[WebCoreStatistics iconPageURLMappingCount]):
318         (+[WebCoreStatistics iconRetainedPageURLCount]):
319         (+[WebCoreStatistics iconRecordCount]):
320         (+[WebCoreStatistics iconsWithDataCount]):
321         * Misc/WebIconDatabase.mm:
322         (-[WebIconDatabase init]):
323         (-[WebIconDatabase iconForURL:withSize:cache:]):
324         (-[WebIconDatabase iconURLForURL:]):
325         (-[WebIconDatabase defaultIconWithSize:]):
326         (-[WebIconDatabase retainIconForURL:]):
327         (-[WebIconDatabase releaseIconForURL:]):
328         (-[WebIconDatabase isEnabled]):
329         (-[WebIconDatabase setEnabled:]):
330         (-[WebIconDatabase removeAllIcons]):
331         (+[WebIconDatabase _checkIntegrityBeforeOpening]):
332         (-[WebIconDatabase _startUpIconDatabase]):
333         (-[WebIconDatabase _applicationWillTerminate:]):
334         (-[WebIconDatabase _resetCachedWebPreferences:]):
335         (importToWebCoreFormat):
336         * WebView/WebView.mm:
337         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
338
339 2011-03-03  Jessie Berlin  <jberlin@apple.com>
340
341         Reviewed by Adam Roben.
342
343         WebKit2: Use CFNetwork Sessions API.
344         https://bugs.webkit.org/show_bug.cgi?id=55435.
345
346         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
347
348         * WebCoreSupport/WebSystemInterface.mm:
349         (InitWebCoreSystemInterface):
350         Support using WKCopyRequestWithStorageSession in WebCore.
351
352 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
353
354         Reviewed by Darin Adler.
355
356         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
357         https://bugs.webkit.org/show_bug.cgi?id=55633
358         <rdar://problem/8963023>
359
360         * WebCoreSupport/WebChromeClient.h:
361         * WebCoreSupport/WebChromeClient.mm:
362         Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
363
364         * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
365         Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
366         require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
367         so I've preserved it.
368
369 2011-03-02  Jessie Berlin  <jberlin@apple.com>
370
371         Rubber-stamped by Dan Bernstein.
372
373         Fix crashes in private browsing tests in WK1 on Snow Leopard.
374
375         * WebCoreSupport/WebSystemInterface.mm:
376         (InitWebCoreSystemInterface):
377         Put the INIT call for wkCreatePrivateStorageSession outside of the
378         #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
379         guards.
380
381 2011-03-02  Jessie Berlin  <jberlin@apple.com>
382
383         Reviewed by Adam Roben.
384
385         WebKit2: Use CFNetwork Sessions API.
386         https://bugs.webkit.org/show_bug.cgi?id=55435.
387
388         Add the ability to create a Private Browsing Storage Session.
389
390         * WebCoreSupport/WebSystemInterface.mm:
391         (InitWebCoreSystemInterface):
392         Support calling wkCreatePrivateStorageSession from WebCore.
393
394 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
395
396         Reviewed by David Levin.
397
398         Add feature define for data transfer items
399         https://bugs.webkit.org/show_bug.cgi?id=55510
400
401         * Configurations/FeatureDefines.xcconfig:
402
403 2011-03-02  Sam Weinig  <sam@webkit.org>
404
405         Reviewed by Anders Carlsson.
406
407         Fix remaining localization issues by piping all localized strings through WebCore's
408         localization bottleneck.
409         <rdar://problem/8728860>
410
411         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
412         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
413         * Misc/WebKitErrors.m:
414         * Misc/WebLocalizableStringsInternal.h: Added.
415         * Misc/WebLocalizableStringsInternal.mm: Added.
416         (WebLocalizedStringInternal):
417         * Panels/WebAuthenticationPanel.m:
418         (-[WebAuthenticationPanel setUpForChallenge:]):
419         * Plugins/Hosted/NetscapePluginHostManager.mm:
420         (WebKit::NetscapePluginHostManager::spawnPluginHost):
421         * WebCoreSupport/WebEditorClient.mm:
422         (undoNameForEditAction):
423         * WebCoreSupport/WebInspectorClient.mm:
424         (WebInspectorFrontendClient::updateWindowTitle):
425         (-[WebInspectorWindowController validateUserInterfaceItem:]):
426         * WebCoreSupport/WebKeyGenerator.m:
427         (-[WebKeyGenerator strengthMenuItemTitles]):
428         (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
429         * WebCoreSupport/WebPlatformStrategies.mm:
430         * WebView/WebHTMLView.mm:
431         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
432         * WebView/WebPDFView.mm:
433         (-[WebPDFView menuForEvent:]):
434
435 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
436
437         Reviewed by Adam Roben.
438
439         Part of WebKit2: Need a way to send notifications to client when cookies change
440         https://bugs.webkit.org/show_bug.cgi?id=55427
441         <rdar://problem/9056027>
442         
443         Add stubs for CookiesStrategy on Mac WebKit1.
444
445         * WebCoreSupport/WebPlatformStrategies.h:
446         * WebCoreSupport/WebPlatformStrategies.mm:
447         (WebPlatformStrategies::createCookiesStrategy):
448         (WebPlatformStrategies::notifyCookiesChanged):
449
450 2011-03-01  Philippe Normand  <pnormand@igalia.com>
451
452         Reviewed by Eric Carlson.
453
454         [GStreamer] support in mac video fullscreen controller
455         https://bugs.webkit.org/show_bug.cgi?id=52280
456
457         Factored the code to configure the video overlay in a new private
458         method of the controller and added GStreamer support to it.
459
460         * WebView/WebVideoFullscreenController.h:
461         * WebView/WebVideoFullscreenController.mm:
462         (-[WebVideoFullscreenController setupVideoOverlay:]):
463         (-[WebVideoFullscreenController windowDidLoad]):
464         (-[WebVideoFullscreenController setMediaElement:WebCore::]):
465         (-[WebVideoFullscreenController windowDidExitFullscreen]):
466
467 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
468
469         Reviewed by Timothy Hatcher.
470
471         All Console Messages should be passed to ChromeClients.
472         https://bugs.webkit.org/show_bug.cgi?id=54926
473
474         Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
475         which supersedes -webView:addMessageToConsole if it exists. The new delegate
476         does not filter to only JavaScript originated console messages. The old
477         delegate is left around for clients that expect filtered messages, like
478         DashCode and older versions of Safari.
479
480         The dictionary message passed to the delegate now includes more information
481         about the message source, type, and level.
482
483         * WebCoreSupport/WebChromeClient.mm:
484         (stringForMessageSource):
485         (stringForMessageType):
486         (stringForMessageLevel):
487         (WebChromeClient::addMessageToConsole):
488         * WebView/WebUIDelegatePrivate.h:
489
490 2011-03-01  Levi Weintraub  <leviw@chromium.org>
491
492         Reviewed by Ryosuke Niwa.
493
494         Stop instantiating legacy editing Positions in VisiblePosition
495         https://bugs.webkit.org/show_bug.cgi?id=52919
496
497         Changing usage of legacy VisiblePosition constructor. Since we were dealing
498         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
499
500         * WebView/WebFrame.mm:
501         (-[WebFrame _caretRectAtPosition:affinity:]):
502         * WebView/WebFrameInternal.h:
503         * WebView/WebTextCompletionController.mm:
504         (-[WebTextCompletionController doCompletion]):
505
506 2011-03-01  Sam Weinig  <sam@webkit.org>
507
508         Reviewed by Timothy Hatcher.
509
510         WebKit2 needs to be made localizable
511         https://bugs.webkit.org/show_bug.cgi?id=55483
512
513         * WebCoreSupport/WebPlatformStrategies.mm:
514         Use WebCore's localizedString function instead of WebLocalizableStrings
515         since WebCore is now responsible for localization.
516
517 2011-02-25 Steve Block <steveblock@google.com>
518
519         Reviewed by Jeremy Orlow.
520
521         Bridge.h should not include BridgeJSC.h
522         https://bugs.webkit.org/show_bug.cgi?id=55212
523
524         Include BridgeJSC.h directly instead.
525
526         * Plugins/Hosted/ProxyInstance.h:
527         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
528
529 2011-02-28  Chang Shu  <cshu@webkit.org>
530
531         Reviewed by Ryosuke Niwa.
532
533         Remove the support of Frame::isContentEditable and its dependencies.
534         https://bugs.webkit.org/show_bug.cgi?id=54292
535
536         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
537
538         * WebCoreSupport/WebEditorClient.h:
539         * WebCoreSupport/WebEditorClient.mm:
540         * WebView/WebView.mm:
541         (-[WebView setEditable:]):
542         (-[WebView isEditable]):
543         * WebView/WebViewData.h:
544
545 2011-02-28  Oliver Hunt  <oliver@apple.com>
546
547         Reviewed by Gavin Barraclough.
548
549         Make ScopeChainNode GC allocated
550         https://bugs.webkit.org/show_bug.cgi?id=55283
551
552         More updates for the absence of the ScopeChain class
553
554         * WebView/WebScriptDebugDelegate.mm:
555         (-[WebScriptCallFrame scopeChain]):
556
557 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
558
559         Reviewed by Pavel Feldman.
560
561         DumpRenderTree should reset frame opener between tests.
562         https://bugs.webkit.org/show_bug.cgi?id=54874
563
564         Added clearOpener method to WebFramePrivate.
565
566         * WebView/WebFrame.mm:
567         (-[WebFrame _clearOpener]):
568         * WebView/WebFramePrivate.h:
569
570 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
571
572         Unreviewed, rolling out r79764.
573         http://trac.webkit.org/changeset/79764
574         https://bugs.webkit.org/show_bug.cgi?id=55295
575
576         "broke Chromium builds" (Requested by rniwa on #webkit).
577
578         * WebView/WebFrame.mm:
579         * WebView/WebFramePrivate.h:
580
581 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
582
583         Reviewed by David Kilzer.
584
585         https://bugs.webkit.org/show_bug.cgi?id=48781
586
587         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
588
589         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
590         should paint the default broken image when an image fails to load or decode.  The method also passes the
591         URL of the failed image.
592
593         * WebCoreSupport/WebFrameLoaderClient.h:
594         * WebCoreSupport/WebFrameLoaderClient.mm:
595         (WebFrameLoaderClient::shouldPaintBrokenImage):
596         * WebView/WebDelegateImplementationCaching.h:
597         * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
598         (CallResourceLoadDelegateReturningBoolean):
599         * WebView/WebResourceLoadDelegatePrivate.h:
600         * WebView/WebView.mm:
601         (-[WebView _cacheResourceLoadDelegateImplementations]):
602
603 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
604
605         Reviewed by Pavel Feldman.
606
607         DumpRenderTree should reset frame opener between tests.
608         https://bugs.webkit.org/show_bug.cgi?id=54874
609
610         Added clearOpener method to WebFramePrivate.
611
612         * WebView/WebFrame.mm:
613         (-[WebFrame _clearOpener]):
614         * WebView/WebFramePrivate.h:
615
616 2011-02-25  Mark Rowe  <mrowe@apple.com>
617
618         <rdar://problem/8902546> Build fix.
619
620         * Misc/QuickDrawCompatibility.h:
621
622 2011-02-24  Anders Carlsson  <andersca@apple.com>
623
624         Fix clang build.
625
626         * WebCoreSupport/WebKeyGenerator.m:
627         (toWebCertificateParseResult):
628         (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
629         * WebView/WebTextCompletionController.mm:
630
631 2011-02-24  Peter Kasting  <pkasting@google.com>
632
633         Reviewed by Eric Seidel.
634
635         Drop the "U; " encryption level from the User Agent string.
636         https://bugs.webkit.org/show_bug.cgi?id=54566
637
638         * WebView/WebView.mm:
639         (+[WebView _standardUserAgentWithApplicationName:]):
640
641 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
642
643         Unreviewed, rolling out r79570.
644         http://trac.webkit.org/changeset/79570
645         https://bugs.webkit.org/show_bug.cgi?id=54874
646
647         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
648         was not updated
649
650         * WebView/WebFrame.mm:
651         * WebView/WebFramePrivate.h:
652
653 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
654
655         Reviewed by Alexey Proskuryakov.
656
657         DumpRenderTree should reset frame opener between tests.
658         https://bugs.webkit.org/show_bug.cgi?id=54874
659
660         Added clearOpener method to WebFramePrivate.
661
662         * WebView/WebFrame.mm:
663         (-[WebFrame _clearOpener]):
664         * WebView/WebFramePrivate.h:
665
666 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
667
668         Reviewed by Alexey Proskuryakov.
669
670         Drop the language tag part from the User Agent string
671         https://bugs.webkit.org/show_bug.cgi?id=54560
672
673         * WebView/WebView.mm:
674         (+[WebView _standardUserAgentWithApplicationName:]): Drop the
675         language tag part.
676
677 2011-02-22  Brady Eidson  <beidson@apple.com>
678
679         Reviewed by Anders Carlsson.
680
681         Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
682         API to view and delete Application Cache data by origin.
683
684         * WebCoreSupport/WebApplicationCache.mm:
685         (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
686
687 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
688
689         Reviewed by Kent Tamura.
690
691         Rename Position::node() to Position::deprecatedNode()
692         https://bugs.webkit.org/show_bug.cgi?id=54622
693
694         * WebView/WebFrame.mm:
695         (-[WebFrame _smartDeleteRangeForProposedRange:]):
696
697 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
698
699         Reviewed by Kent Tamura.
700
701         Rename Position::node() to Position::deprecatedNode()
702         https://bugs.webkit.org/show_bug.cgi?id=54622
703         
704         Done the rename.
705
706         * WebView/WebFrame.mm:
707         (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
708         use containerNode() and offsetInContainerNode() instead of deprecated member functions.
709
710 2011-02-18  Gavin Barraclough  <barraclough@apple.com>
711
712         Reviewed by Sam Weinig.
713
714         Bug 54786 - Devirtualize JSCell::classInfo()
715
716         Instead of making a virtual function call, add a pointer to the ClassInfo
717         onto Structure.
718
719         This removes a virtual function call, and paves the way towards removing all
720         the createStructure methods, and StructureFlags/AnonymousSlotCount properties
721         (these should be able to move onto ClassInfo).
722
723         Calls to Structure::create must now pass a pointer to the ClassInfo for the
724         structure. All objects now have a ClassInfo pointer, non-object cell types
725         still do not.
726
727         Changes are most mechanical, involving three steps:
728             * Remove virtual classInfo() methods.
729             * Add &s_info parameter to calls to Structure::create.
730             * Rename ClassInfo static members on classes from 'info' to 's_info',
731               for consistency.
732
733         * Plugins/Hosted/ProxyInstance.mm:
734         (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
735         (WebKit::ProxyRuntimeMethod::createStructure):
736         * Plugins/Hosted/ProxyRuntimeObject.h:
737         (WebKit::ProxyRuntimeObject::createStructure):
738         * Plugins/Hosted/ProxyRuntimeObject.mm:
739         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
740         * WebView/WebView.mm:
741         (aeDescFromJSValue):
742
743 2011-02-19  Brian Ryner  <bryner@chromium.org>
744
745         Reviewed by Adam Barth.
746
747         Add missing #include of DocumentLoader.h, needed since the transitive
748         include through Document.h is removed.
749         https://bugs.webkit.org/show_bug.cgi?id=50489
750
751         * WebView/WebFrame.mm:
752
753 2011-02-19  Charlie Reis  <creis@chromium.org>
754
755         Reviewed by Mihai Parparita.
756
757         Ensure loading has stopped in HistoryController::goToItem
758         https://bugs.webkit.org/show_bug.cgi?id=54517
759
760         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
761
762         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
763
764         * WebCoreSupport/WebFrameLoaderClient.mm:
765         (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
766         * WebCoreSupport/WebFrameLoaderClient.h:
767
768 2011-02-16  David Hyatt  <hyatt@apple.com>
769
770         Reviewed by Dan Bernstein.
771
772         https://bugs.webkit.org/show_bug.cgi?id=54244
773         
774         Convert the line box tree to floating point and eliminate font rounding hacks.  This patch removes all of the rounding
775         hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
776         
777         The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
778         been changed as well.
779         
780         In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
781         
782         Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
783         
784         Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
785         still have a precise floating point position.
786
787         Justification will now allow subpixel positioning to occur as well.  Platforms that don't support subpixel positioning should already
788         be rounding justification spacing in their font code.
789
790         Many layout test results change on Mac, since rounding hacks were used there and are now gone.
791
792         * Misc/WebKitNSStringExtras.mm:
793         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
794         (-[NSString _web_widthWithFont:]):
795
796 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
797
798         Reviewed by Adam Roben.
799
800         HTML5 <details> and <summary>: localized text
801         https://bugs.webkit.org/show_bug.cgi?id=54260
802
803         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
804         provide the default label to be used by a <details> tag that has no <summary> child.
805
806         * WebCoreSupport/WebPlatformStrategies.h:
807         * WebCoreSupport/WebPlatformStrategies.mm:
808         (WebPlatformStrategies::defaultDetailsSummaryText):
809
810 2011-02-16  Matthew Delaney  <mdelaney@apple.com>
811
812         Reviewed by Simon Fraser.
813
814         Allow acceleratesDrawing for WebKit2
815         https://bugs.webkit.org/show_bug.cgi?id=54511
816
817         Plumb through preference for accelerated drawing.
818         
819         * WebView/WebPreferenceKeysPrivate.h:
820         * WebView/WebPreferences.mm:
821         (+[WebPreferences initialize]):
822         (-[WebPreferences acceleratedDrawingEnabled]):
823         (-[WebPreferences setAcceleratedDrawingEnabled:]):
824         * WebView/WebPreferencesPrivate.h:
825
826 2011-02-15  David Kilzer  <ddkilzer@apple.com>
827
828         <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
829
830         Reviewed by Darin Adler.
831
832         * WebView/WebDynamicScrollBarsView.h:
833         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
834         declaration.
835         * WebView/WebDynamicScrollBarsView.mm:
836         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
837         implementation into correct category.
838         * WebView/WebDynamicScrollBarsViewInternal.h:
839         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
840         declaration.
841         * WebView/WebHTMLView.mm: Included
842         WebDynamicScrollBarsViewInternal.h instead of
843         WebDynamicScrollBarsView.h.
844
845 2011-02-14  Oliver Hunt  <oliver@apple.com>
846
847         Reviewed by Gavin Barraclough and Geoff Garen.
848
849         Refactor handles and weak pointers to become nicer and more automatic
850         https://bugs.webkit.org/show_bug.cgi?id=54415
851
852         Update to use Global<> instead of ProtectedPtr, and refactored slightly
853         to get global data to places it's needed for when we're assigning to
854         Global<>s
855
856         * ForwardingHeaders/collector/handles/Global.h: Added.
857         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
858         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
859         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
860         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
861         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
862         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
863         (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
864         (WebKit::NetscapePluginInstanceProxy::evaluate):
865         (WebKit::NetscapePluginInstanceProxy::invoke):
866         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
867         (WebKit::NetscapePluginInstanceProxy::construct):
868         (WebKit::NetscapePluginInstanceProxy::addValueToArray):
869         * WebView/WebScriptDebugger.h:
870         * WebView/WebScriptDebugger.mm:
871         (WebScriptDebugger::WebScriptDebugger):
872
873 2011-02-15  Jia Pu  <jpu@apple.com>
874
875         Reviewed by Darin Adler.
876
877         Autocorrection should respect undo.
878         https://bugs.webkit.org/show_bug.cgi?id=52221
879         <rdar://problem/8663399>
880
881         Please see WebCore/ChangeLog for detailed description.
882
883         * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
884
885         * WebCoreSupport/WebEditorClient.mm:
886         (WebEditorClient::recordAutocorrectionResponse): Ditto.
887
888         * WebView/WebFrame.mm:
889         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
890              Adopted new signature of ReplaceSelectionCommand::create().
891
892 2011-02-15  David Kilzer  <ddkilzer@apple.com>
893
894         <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
895
896         Reviewed by Darin Adler.
897
898         * WebView/WebDynamicScrollBarsView.h:
899         * WebView/WebDynamicScrollBarsView.mm:
900         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
901         -inProgramaticScroll.
902         * WebView/WebHTMLView.mm:
903         (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
904
905 2011-02-15  Kenneth Russell  <kbr@google.com>
906
907         Reviewed by Darin Fisher.
908
909         Allow controlling minimum DOMTimer interval on a per-page basis
910         https://bugs.webkit.org/show_bug.cgi?id=54312
911
912         Added needed methods to implement LayoutTestController's new
913         setMinimumTimerInterval method.
914
915         * WebView/WebView.mm:
916         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
917         (+[WebView _defaultMinimumTimerInterval]):
918         (-[WebView _setMinimumTimerInterval:]):
919         * WebView/WebViewPrivate.h:
920
921 2011-02-11  Geoffrey Garen  <ggaren@apple.com>
922
923         Reviewed by Oliver Hunt.
924
925         A little more encapsulation for the heap: Removed CollectorHeapIterator
926         https://bugs.webkit.org/show_bug.cgi?id=54298
927
928         * Misc/WebCoreStatistics.mm:
929         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
930         (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
931
932 2011-02-10  Nate Chapin  <japhet@chromium.org>
933
934         Reviewed by Adam Barth.
935
936         Update calls to DocumentWriter.
937         https://bugs.webkit.org/show_bug.cgi?id=50489
938
939         * WebView/WebFrame.mm:
940         (-[WebFrame _canProvideDocumentSource]):
941
942 2011-02-10  Chris Fleizach  <cfleizach@apple.com>
943
944         Reviewed by Anders Carlsson.
945
946         AX: AX needs to stop using WebCoreViewFactory
947         https://bugs.webkit.org/show_bug.cgi?id=54153
948
949         * WebCoreSupport/WebSystemInterface.mm:
950         (InitWebCoreSystemInterface):
951
952 2011-02-10  Peter Varga  <pvarga@webkit.org>
953
954         Reviewed by Csaba Osztrogonác.
955
956         Remove PCRE source from trunk
957         https://bugs.webkit.org/show_bug.cgi?id=54188
958
959         * ForwardingHeaders/pcre/pcre.h: Removed.
960
961 2011-02-09  Pavel Feldman  <pfeldman@chromium.org>
962
963         Reviewed by Yury Semikhatsky.
964
965         Web Inspector: follow up on InspectorAgent split -
966         removing unnecessary methods from InspectorController.
967         https://bugs.webkit.org/show_bug.cgi?id=54093
968
969         * WebInspector/WebInspector.mm:
970         (-[WebInspector showConsole:]):
971         (-[WebInspector stopProfilingJavaScript:]):
972
973 2011-02-08  Dan Bernstein  <mitz@apple.com>
974
975         Reviewed by Jon Honeycutt and Maciej Stachowiak.
976
977         <rdar://problem/8959420> Find in Mail no longer cycles around
978
979         * WebView/WebHTMLView.mm:
980         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
981         the wrap option according to the flag.
982
983 2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
984
985         Unreviewed, rolling out r77980.
986         http://trac.webkit.org/changeset/77980
987         https://bugs.webkit.org/show_bug.cgi?id=54043
988
989         "Crashes on Windows and Linux..." (Requested by leviw on
990         #webkit).
991
992         * WebView/WebFrame.mm:
993         (-[WebFrame _caretRectAtNode:offset:affinity:]):
994         * WebView/WebFrameInternal.h:
995         * WebView/WebTextCompletionController.mm:
996         (-[WebTextCompletionController doCompletion]):
997
998 2011-02-08  Levi Weintraub  <leviw@chromium.org>
999
1000         Reviewed by Ryosuke Niwa.
1001
1002         Stop instantiating legacy editing Positions in VisiblePosition
1003         https://bugs.webkit.org/show_bug.cgi?id=52919
1004
1005         Changing usage of legacy VisiblePosition constructor. Since we were dealing
1006         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
1007
1008         * WebView/WebFrame.mm:
1009         (-[WebFrame _caretRectAtPosition:affinity:]):
1010         * WebView/WebFrameInternal.h:
1011         * WebView/WebTextCompletionController.mm:
1012         (-[WebTextCompletionController doCompletion]):
1013
1014 2011-02-08  Adam Barth  <abarth@webkit.org>
1015
1016         Reviewed by Eric Seidel.
1017
1018         Remove orphan code from old parser
1019         https://bugs.webkit.org/show_bug.cgi?id=53984
1020
1021         * WebCoreSupport/WebChromeClient.h:
1022
1023 2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>
1024
1025         Reviewed by Yury Semikhatsky.
1026
1027         Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
1028
1029         https://bugs.webkit.org/show_bug.cgi?id=53169
1030
1031         Minor change enforced by major changes in WebCore/inspector/InspectorController.
1032
1033         * WebInspector/WebInspector.mm:
1034         (-[WebInspector isTimelineProfilingEnabled]):
1035
1036 2011-02-07  Enrica Casucci  <enrica@apple.com>
1037
1038         Reviewed Adam Roben and Darin Adler.
1039
1040         WebKit2: drag and drop support on Windows.
1041         https://bugs.webkit.org/show_bug.cgi?id=52775
1042
1043         Removed createDragImageForLink from DragClient.
1044
1045         * WebCoreSupport/WebDragClient.h:
1046         * WebCoreSupport/WebDragClient.mm:
1047         (WebDragClient::startDrag):
1048
1049 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
1050
1051         Reviewed by Pavel Feldman.
1052
1053         Web Inspector: remove settings related methods from InspectorClient
1054         https://bugs.webkit.org/show_bug.cgi?id=53686
1055
1056         * WebCoreSupport/WebInspectorClient.h:
1057         * WebCoreSupport/WebInspectorClient.mm:
1058         (WebInspectorClient::openInspectorFrontend):
1059         (WebInspectorFrontendClient::WebInspectorFrontendClient):
1060
1061 2011-02-03  James Kozianski  <koz@chromium.org>
1062
1063         Reviewed by Dimitri Glazkov.
1064
1065         Add navigator.registerProtocolHandler behind a flag.
1066         https://bugs.webkit.org/show_bug.cgi?id=52609
1067
1068         * Configurations/FeatureDefines.xcconfig:
1069
1070 2011-02-03  Adam Langley  <agl@chromium.org>
1071
1072         Reviewed by Adam Barth.
1073
1074         Plumb mixed script URL to FrameLoaderClient
1075         https://bugs.webkit.org/show_bug.cgi?id=52384
1076
1077         Regressions covered by http/tests/security/mixedContent/*
1078
1079         * WebCoreSupport/WebFrameLoaderClient.h:
1080         * WebCoreSupport/WebFrameLoaderClient.mm:
1081         (WebFrameLoaderClient::didRunInsecureContent):
1082
1083 2011-02-03  Beth Dakin  <bdakin@apple.com>
1084
1085         Reviewed by Sam Weinig.
1086
1087         Fix for <rdar://problem/8944544> Ability to animate track
1088         for WKPainter scrollers
1089
1090         * WebCoreSupport/WebSystemInterface.mm:
1091         (InitWebCoreSystemInterface):
1092
1093 2011-02-02  Mark Rowe  <mrowe@apple.com>
1094
1095         Reviewed by Beth Dakin.
1096
1097         <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
1098
1099         * WebCoreSupport/WebSystemInterface.mm:
1100         (InitWebCoreSystemInterface): Add some missing initializers.
1101
1102 2011-02-02  Steve Lacey  <sjl@chromium.org>
1103
1104         Reviewed by Eric Carlson.
1105
1106         Implement basic media statistics on media elements.
1107         https://bugs.webkit.org/show_bug.cgi?id=53322
1108
1109         * Configurations/FeatureDefines.xcconfig:
1110
1111 2011-02-01  Sam Weinig  <sam@webkit.org>
1112
1113         Reviewed by Beth Dakin.
1114
1115         Part 2 for <rdar://problem/8492788>
1116         Adopt WKScrollbarPainterController
1117
1118         Use header detection to define scrollbar painting controller #define.
1119
1120         * WebCoreSupport/WebSystemInterface.mm:
1121         (InitWebCoreSystemInterface):
1122
1123 2011-02-01  David Hyatt  <hyatt@apple.com>
1124
1125         Reviewed by Oliver Hunt.
1126
1127         https://bugs.webkit.org/show_bug.cgi?id=53520
1128         
1129         Remove the physical terminology from IntRect and FloatRect.
1130         
1131         Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
1132         we need to update our terminology to be more accurate.
1133
1134         I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
1135         renaming right() and bottom() to maxX() and maxY().  These terms remain accurate
1136         even for flipped rectangles.
1137
1138         * WebView/WebHTMLView.mm:
1139         (setNeedsDisplayInRect):
1140
1141 2011-02-01  Beth Dakin  <bdakin@apple.com>
1142
1143         Reviewed by Sam Weinig.
1144
1145         Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
1146
1147         * WebCoreSupport/WebSystemInterface.mm:
1148         (InitWebCoreSystemInterface):
1149
1150 2011-02-01  Dave Hyatt  <hyatt@apple.com>
1151
1152         Reviewed by Darin Adler.
1153
1154         https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
1155         with vertical text.
1156
1157         Change printing functions to check writing-mode and properly swap width and height
1158         as needed.
1159
1160         * WebView/WebDynamicScrollBarsView.mm:
1161         (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
1162         * WebView/WebFrame.mm:
1163         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
1164         * WebView/WebFrameInternal.h:
1165         * WebView/WebHTMLView.mm:
1166         (-[WebHTMLView _web_setPrintingModeRecursive]):
1167         (-[WebHTMLView _web_clearPrintingModeRecursive]):
1168         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
1169         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
1170         (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
1171         (-[WebHTMLView _endPrintMode]):
1172         (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
1173         (-[WebHTMLView _endScreenPaginationMode]):
1174         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
1175         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
1176         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
1177         (-[WebHTMLView _scaleFactorForPrintOperation:]):
1178         (-[WebHTMLView setPageWidthForPrinting:]):
1179         (-[WebHTMLView knowsPageRange:]):
1180
1181 2011-01-31  Oliver Hunt  <oliver@apple.com>
1182
1183         Convert markstack to a slot visitor API
1184         https://bugs.webkit.org/show_bug.cgi?id=53219
1185
1186         rolling r77098, r77099, r77100, r77109, and
1187         r77111 back in, along with a few more Qt fix attempts.
1188
1189         * WebView/WebScriptDebugDelegate.mm:
1190         (-[WebScriptCallFrame scopeChain]):
1191
1192 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
1193
1194         Unreviewed, rolling out r77098, r77099, r77100, r77109, and
1195         r77111.
1196         http://trac.webkit.org/changeset/77098
1197         http://trac.webkit.org/changeset/77099
1198         http://trac.webkit.org/changeset/77100
1199         http://trac.webkit.org/changeset/77109
1200         http://trac.webkit.org/changeset/77111
1201         https://bugs.webkit.org/show_bug.cgi?id=53219
1202
1203         Qt build is broken
1204
1205         * WebView/WebScriptDebugDelegate.mm:
1206         (-[WebScriptCallFrame scopeChain]):
1207
1208 2011-01-30  Oliver Hunt  <oliver@apple.com>
1209
1210         Convert markstack to a slot visitor API
1211         https://bugs.webkit.org/show_bug.cgi?id=53219
1212
1213         rolling r77006 and r77020 back in.
1214
1215         * WebView/WebScriptDebugDelegate.mm:
1216         (-[WebScriptCallFrame scopeChain]):
1217
1218 2011-01-28  Geoffrey Garen  <ggaren@apple.com>
1219
1220         Reviewed by Maciej Stachowiak.
1221
1222         Some more Heap cleanup.
1223         https://bugs.webkit.org/show_bug.cgi?id=53357
1224
1225         Updated for JavaScriptCore changes.
1226
1227         * Misc/WebCoreStatistics.mm:
1228         (+[WebCoreStatistics memoryStatistics]):
1229
1230 2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1231
1232         Unreviewed, rolling out r77006 and r77020.
1233         http://trac.webkit.org/changeset/77006
1234         http://trac.webkit.org/changeset/77020
1235         https://bugs.webkit.org/show_bug.cgi?id=53360
1236
1237         "Broke Windows tests" (Requested by rniwa on #webkit).
1238
1239         * WebView/WebScriptDebugDelegate.mm:
1240         (-[WebScriptCallFrame scopeChain]):
1241
1242 2011-01-27  Oliver Hunt  <oliver@apple.com>
1243
1244         Reviewed by Geoffrey Garen.
1245
1246         Convert markstack to a slot visitor API
1247         https://bugs.webkit.org/show_bug.cgi?id=53219
1248
1249         Update to new marking api
1250
1251         * WebView/WebScriptDebugDelegate.mm:
1252         (-[WebScriptCallFrame scopeChain]):
1253
1254 2011-01-28  Dan Bernstein  <mitz@apple.com>
1255
1256         Reviewed by Sam Weinig.
1257
1258         <select> can't display right-to-left (rtl) languages
1259         https://bugs.webkit.org/show_bug.cgi?id=19785
1260
1261         * WebCoreSupport/WebChromeClient.h:
1262         * WebCoreSupport/WebChromeClient.mm:
1263         (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
1264         (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
1265
1266 2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1267
1268         Unreviewed, rolling out r76891.
1269         http://trac.webkit.org/changeset/76891
1270         https://bugs.webkit.org/show_bug.cgi?id=53280
1271
1272         Makes every layout test crash (Requested by othermaciej on
1273         #webkit).
1274
1275         * Misc/WebIconDatabase.mm:
1276         (-[ThreadEnabler threadEnablingSelector:]):
1277         (importToWebCoreFormat):
1278
1279 2011-01-27  Nate Chapin  <japhet@chromium.org>
1280
1281         Reviewed by Adam Barth.
1282
1283         Use Document::url() instead of FrameLoader::url().
1284         https://bugs.webkit.org/show_bug.cgi?id=41165
1285
1286         * WebView/WebView.mm:
1287         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1288
1289 2011-01-27  Dan Bernstein  <mitz@apple.com>
1290
1291         Rubber-stamped by Anders Carlsson.
1292
1293         Reverted an accidental change in r76561.
1294
1295         * WebView/WebHTMLView.mm:
1296
1297 2011-01-26  David Kilzer  <ddkilzer@apple.com>
1298
1299         <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
1300         <rdar://problem/8821760>
1301
1302         Reviewed by Antti Koivisto.
1303
1304         * WebCoreSupport/WebSystemInterface.mm:
1305         (InitWebCoreSystemInterface): Added initialization for
1306         GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
1307
1308 2011-01-26  Beth Dakin  <bdakin@apple.com>
1309
1310         Reviewed by Darin Adler.
1311
1312         Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics 
1313         when using WKScrollbars.
1314
1315         * WebCoreSupport/WebSystemInterface.mm:
1316         (InitWebCoreSystemInterface):
1317
1318 2011-01-25  Darin Adler  <darin@apple.com>
1319
1320         Reviewed by Anders Carlsson.
1321
1322         WebKit is using CSBackupSetItemExcluded incorrectly
1323         https://bugs.webkit.org/show_bug.cgi?id=53095
1324         rdar://problem/8790540
1325
1326         * Misc/WebIconDatabase.mm:
1327         (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
1328         It was incorrect, and this responsibility has been moved to WebCore.
1329
1330 2011-01-24  Chris Marrin  <cmarrin@apple.com>
1331
1332         Reviewed by Eric Seidel.
1333
1334         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
1335         https://bugs.webkit.org/show_bug.cgi?id=53041
1336
1337         * Configurations/FeatureDefines.xcconfig:
1338
1339 2011-01-25  Yury Semikhatsky  <yurys@chromium.org>
1340
1341         Reviewed by Pavel Feldman.
1342
1343         Web Inspector: remove "attached" state related methods from InspectorAgent
1344         https://bugs.webkit.org/show_bug.cgi?id=53086
1345
1346         * WebCoreSupport/WebInspectorClient.h:
1347         * WebCoreSupport/WebInspectorClient.mm:
1348         (-[WebInspectorWindowController showWindow:]):
1349         (-[WebInspectorWindowController attach]):
1350         (-[WebInspectorWindowController detach]):
1351
1352 2011-01-23  Dan Bernstein  <mitz@apple.com>
1353
1354         Reviewed by John Sullivan.
1355
1356         <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
1357
1358         * WebCoreSupport/WebChromeClient.mm:
1359         (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
1360
1361 2011-01-22  Alexey Proskuryakov  <ap@apple.com>
1362
1363         Reviewed by Darin Adler.
1364
1365         https://bugs.webkit.org/show_bug.cgi?id=52473
1366         Auto-scaling to avoid orphans is broken, remove dysfunctional code
1367
1368         * WebView/WebHTMLView.mm:
1369         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
1370         (-[WebHTMLView _scaleFactorForPrintOperation:]):
1371         (-[WebHTMLView knowsPageRange:]):
1372
1373 2011-01-21  Mark Rowe  <mrowe@apple.com>
1374
1375         Rubber-stamped by Jon Honeycutt.
1376
1377         Fix the build when using Clang by removing some unused variables.
1378
1379         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1380         (-[WebHostedNetscapePluginView updateAndSetWindow]):
1381         * WebView/WebFullScreenController.mm:
1382         (-[WebFullScreenController enterFullscreen:]):
1383         (-[WebFullScreenController exitFullscreen]):
1384
1385 2011-01-21  Chris Rogers  <crogers@google.com>
1386
1387         Reviewed by Darin Fisher.
1388
1389         Add run-time enable support for the web audio API
1390         https://bugs.webkit.org/show_bug.cgi?id=52741
1391
1392         * WebView/WebPreferenceKeysPrivate.h:
1393         * WebView/WebPreferences.mm:
1394         (-[WebPreferences webAudioEnabled]):
1395         (-[WebPreferences setWebAudioEnabled:]):
1396         * WebView/WebPreferencesPrivate.h:
1397         * WebView/WebView.mm:
1398         (-[WebView _preferencesChangedNotification:]):
1399
1400 2011-01-20  John Sullivan  <sullivan@apple.com>
1401
1402         Reviewed by Mark Rowe.
1403
1404         Shift-tab doesn't cycle through fields in http authentication panel
1405         https://bugs.webkit.org/show_bug.cgi?id=52850
1406
1407         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
1408         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
1409         Re-wired the key loop so that there aren't two views with the same nextKeyView.
1410
1411 2011-01-20  Beth Dakin  <bdakin@apple.com>
1412
1413         Reviewed by Geoffrey Garen.
1414
1415         Fix for <rdar://problem/8890255>
1416
1417         Allow WebKitSystemInterface to draw scrollbars 
1418         when appropriate.
1419         * WebCoreSupport/WebSystemInterface.mm:
1420         (InitWebCoreSystemInterface):
1421
1422 2011-01-19  Simon Fraser  <simon.fraser@apple.com>
1423
1424         Reviewed by Sam Weinig.
1425
1426         GraphicsLayers in subframes can get sync'd multiple times
1427         https://bugs.webkit.org/show_bug.cgi?id=52489
1428
1429         * WebView/WebView.mm:
1430         (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
1431         was renamed to syncCompositingStateIncludingSubframes().
1432
1433 2011-01-19  Darin Adler  <darin@apple.com>
1434
1435         Reviewed by Sam Weinig.
1436
1437         Would like script debugging protocol method to differentiate between caught and uncaught exceptions
1438         https://bugs.webkit.org/show_bug.cgi?id=52104
1439         rdar://problem/8704226
1440
1441         * WebView/WebDelegateImplementationCaching.h:
1442         Fix type of second integer in CallScriptDebugDelegate function overload
1443         to be int to match the actual Objective-C method. Added a new overload
1444         that includes a BOOL in the right place. Added a boolean named
1445         exceptionWasRaisedExpectsHasHandlerFlag.
1446
1447         * WebView/WebDelegateImplementationCaching.mm:
1448         (CallDelegate): Added overloads as above.
1449         (CallScriptDebugDelegate): Ditto.
1450
1451         * WebView/WebScriptDebugDelegate.h: Added new method with the additional
1452         boolean argument. Marked the old method informally deprecated.
1453
1454         * WebView/WebScriptDebugger.mm:
1455         (WebScriptDebugger::exception): Added code to call with or without the
1456         boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
1457
1458         * WebView/WebView.mm:
1459         (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
1460         exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
1461         guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
1462
1463 2011-01-19  Tony Gentilcore  <tonyg@chromium.org>
1464
1465         Reviewed by Mihai Parparita.
1466
1467         Perform some forward declaration
1468         https://bugs.webkit.org/show_bug.cgi?id=52522
1469
1470         * Misc/WebKitNSStringExtras.mm:
1471
1472 2011-01-19  Pavel Podivilov  <podivilov@chromium.org>
1473
1474         Reviewed by Yury Semikhatsky.
1475
1476         Web Inspector: [JSC] scripts have incorrect starting line (always 1).
1477         https://bugs.webkit.org/show_bug.cgi?id=52721
1478
1479         * WebView/WebScriptDebugger.h:
1480         * WebView/WebScriptDebugger.mm:
1481         (toNSString):
1482         (WebScriptDebugger::sourceParsed):
1483
1484 2011-01-19  Levi Weintraub  <leviw@google.com>
1485
1486         Reviewed by Ryosuke Niwa.
1487
1488         Updating to use Position::parentAnchoredEquivalent instead of
1489         the old htmlediting rangeCompliantEquivalent.
1490
1491         remove rangeCompliantEquivalent and replace it with Position methods
1492         https://bugs.webkit.org/show_bug.cgi?id=25057
1493
1494         * WebView/WebFrame.mm:
1495         (-[WebFrame _smartDeleteRangeForProposedRange:]):
1496
1497 2011-01-18  Chris Fleizach  <cfleizach@apple.com>
1498
1499         Reviewed by Darin Adler.
1500
1501         REGRESSION: A problem with Voiceover and finding links
1502         https://bugs.webkit.org/show_bug.cgi?id=52324
1503
1504         * WebView/WebDynamicScrollBarsView.mm:
1505         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
1506
1507 2011-01-17  David Kilzer  <ddkilzer@apple.com>
1508
1509         <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
1510
1511         Reviewed by Dan Bernstein.
1512
1513         * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
1514         DOMDocumentPrivate.h to the PrivateHeaders directory.
1515
1516 2011-01-17  Enrica Casucci  <enrica@apple.com>
1517
1518         Reviewed by Alexey Proskuryakov.
1519
1520         Drag and drop support: refactoring of image from link and image from selection
1521         https://bugs.webkit.org/show_bug.cgi?id=52496
1522
1523         This work cleans up the Mac code and makes it more similar to the Windows implementation,
1524         avoiding the use of an NSView when the FrameView can be used.
1525         The refactoring is a necessary step towards the complete support of drag and drop
1526         in WebKit2.
1527
1528         * WebCoreSupport/WebDragClient.mm:
1529         (WebDragClient::createDragImageForLink): Added.
1530         * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
1531         * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
1532
1533 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
1534
1535         Reviewed by Yury Semikhatsky.
1536
1537         Web Inspector: simplify debugger enabling routine.
1538         https://bugs.webkit.org/show_bug.cgi?id=52472
1539
1540         * WebInspector/WebInspector.mm:
1541         (-[WebInspector startDebuggingJavaScript:]):
1542
1543 2011-01-16  Dan Bernstein  <mitz@apple.com>
1544
1545         Reviewed by Simon Fraser.
1546
1547         Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
1548         https://bugs.webkit.org/show_bug.cgi?id=52550
1549
1550         * Plugins/WebNetscapePluginView.mm:
1551         (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
1552         that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
1553
1554 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
1555
1556         Reviewed by Dan Bernstein.
1557
1558         Issues with iframes and plugins when the WebView is scaled.
1559         <rdar://problem/6213380>
1560         
1561         When _scaleWebView has been called on a WebView, iframes
1562         in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
1563         This is caused by AppKit NSViews not playing nicely with the scale
1564         applied through style.
1565         
1566         Work around most of these issues by adjusting the bounds size
1567         of widgets to allow iframe contents to paint with the correct scale,
1568         and fix various places in the code where we relied on coordinate
1569         transforms via NSViews (which ignore CSS transforms).
1570
1571         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1572         (-[WebHostedNetscapePluginView updateAndSetWindow]):
1573         * WebView/WebFrameView.mm:
1574         (-[WebFrameView setBoundsSize:]):
1575
1576 2011-01-16  Beth Dakin  <bdakin@apple.com>
1577
1578         Reviewed by Kevin Decker.
1579
1580         Fix for <rdar://problem/8871204>
1581
1582         Don't try to save elasticity state. Just rely on
1583         NSScrollElasticityAutomatic to restore the correct state.
1584         * WebCoreSupport/WebFrameLoaderClient.h:
1585         * WebCoreSupport/WebFrameLoaderClient.mm:
1586         (WebFrameLoaderClient::WebFrameLoaderClient):
1587         (WebFrameLoaderClient::dispatchDidFirstLayout):
1588         (WebFrameLoaderClient::provisionalLoadStarted):
1589
1590 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
1591
1592         Reviewed by Dan Bernstein.
1593
1594         Plugins render incorrectly with transformed ancestors
1595         https://bugs.webkit.org/show_bug.cgi?id=52507
1596         
1597         -[NSView visibleRect] gives the wrong answer if there are CSS transforms
1598         in the ancestor chain of a plugin.
1599         
1600         So use of this method with calls to -actualVisibleRectInWindow, which
1601         maps rects through the render tree to compute the correct rect,
1602         clipping via windowClipRect() if necessary.
1603         
1604         Not testable, because doing so relies on the behavior of some
1605         plugins, which stop rendering if setWindow passes an empty rect.
1606
1607         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1608         (-[WebHostedNetscapePluginView updateAndSetWindow]):
1609         * Plugins/WebBaseNetscapePluginView.h:
1610         * Plugins/WebBaseNetscapePluginView.mm:
1611         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
1612         * Plugins/WebNetscapePluginView.mm:
1613         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1614
1615 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
1616
1617         Reviewed by Antti Koivisto.
1618
1619         Rename cache() to memoryCache()
1620         https://bugs.webkit.org/show_bug.cgi?id=52433
1621
1622         * Misc/WebCache.mm:
1623         (+[WebCache statistics]):
1624         (+[WebCache setDisabled:]):
1625         (+[WebCache isDisabled]):
1626         * WebView/WebView.mm:
1627         (+[WebView _setCacheModel:]):
1628
1629 2011-01-13  Geoffrey Garen  <ggaren@apple.com>
1630
1631         Reviewed by Oliver Hunt.
1632
1633         Split out a MarkedSpace strategy object from Heap.
1634         https://bugs.webkit.org/show_bug.cgi?id=52421
1635
1636         * Misc/WebCoreStatistics.mm:
1637         (+[WebCoreStatistics memoryStatistics]): Updated for class move.
1638
1639 2011-01-14  Dan Bernstein  <mitz@apple.com>
1640
1641         Reviewed by Simon Fraser.
1642
1643         WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
1644
1645         * WebView/WebHTMLView.mm:
1646         (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
1647         to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
1648         that the NSView tree doesn’t change from under AppKit as it traverses it.
1649
1650 2011-01-14  Beth Dakin  <bdakin@apple.com>
1651
1652         Reviewed by Mark Rowe.
1653
1654         Fix for <rdar://problem/7793902> Artifacts when scrolling
1655         page in Safari while page is loading
1656
1657         Call setDrawsBackground:YES on the scrollView in 
1658         dispatchDidFirstLayout() rather than waiting until
1659         frameLoadCompleted(). Also suspend scrolling elasticity
1660         between provisionalLoadStarted() and dispatchDidFirstLayout()
1661         * WebCoreSupport/WebFrameLoaderClient.h:
1662         * WebCoreSupport/WebFrameLoaderClient.mm:
1663         (WebFrameLoaderClient::WebFrameLoaderClient):
1664         (WebFrameLoaderClient::dispatchDidFirstLayout):
1665         (WebFrameLoaderClient::provisionalLoadStarted):
1666
1667 2011-01-12  Enrica Casucci  <enrica@apple.com>
1668
1669         Reviewed by Darin Adler.
1670
1671         WebKit2: Add support for drag and drop
1672         https://bugs.webkit.org/show_bug.cgi?id=52343
1673         <rdar://problem/7660558>
1674         
1675         The DragData class has been extended to provide
1676         additional context from the application (keyboard state, modal windows, etc.)
1677         as well as information of the drag pasteboard being used.
1678         These are the changes to align the behavior for WebKit.
1679
1680         * WebView/WebView.mm:
1681         (-[WebView applicationFlags:]): Added.
1682         (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
1683         (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
1684         (-[WebView draggingExited:]): Added parameter to the DragData constructor.
1685         (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
1686
1687 2011-01-12  Beth Dakin  <bdakin@apple.com>
1688
1689         Reviewed by Anders Carlsson.
1690
1691         Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309 
1692         Expose fixed layout through WebKit SPI
1693         -and corresponding-
1694         <rdar://problem/8844464>
1695
1696         And now with getters!
1697         * WebView/WebView.mm:
1698         (-[WebView _useFixedLayout]):
1699         (-[WebView _fixedLayoutSize]):
1700         * WebView/WebViewPrivate.h:
1701
1702 2011-01-12  Beth Dakin  <bdakin@apple.com>
1703
1704         Reviewed by Anders Carlsson.
1705
1706         Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
1707         fixed layout through WebKit SPI
1708         -and corresponding-
1709         <rdar://problem/8844464>
1710
1711         * WebView/WebView.mm:
1712         (-[WebView _setUseFixedLayout:]):
1713         (-[WebView _setFixedLayoutSize:]):
1714         * WebView/WebViewPrivate.h:
1715
1716 2011-01-07  Enrica Casucci  <enrica@apple.com>
1717
1718         Reviewed by Alexey Proskuryakov.
1719
1720         Paste and drag and drop use different code paths to interact with the pasteboard.
1721         https://bugs.webkit.org/show_bug.cgi?id=52093
1722         The change consists in a refactoring of the code to have only one class that
1723         deals with the pasteboard on Mac.
1724
1725         * WebCoreSupport/WebEditorClient.h:
1726         * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
1727         exposed by NSURLExtras.
1728         (WebEditorClient::canonicalizeURL):
1729         (WebEditorClient::canonicalizeURLString):
1730         * WebCoreSupport/WebPasteboardHelper.h: Removed.
1731         * WebCoreSupport/WebPasteboardHelper.mm: Removed.
1732         * WebView/WebHTMLView.mm: Removed comment.
1733         * WebView/WebView.mm: The following methods have been changed to use the new DragData
1734         constructor that doesn't use the WebPasteboardHelper reference.
1735         (-[WebView draggingEntered:]):
1736         (-[WebView draggingUpdated:]):
1737         (-[WebView draggingExited:]):
1738         (-[WebView performDragOperation:]):
1739
1740 2011-01-09  Tony Gentilcore  <tonyg@chromium.org>
1741
1742         Reviewed by Alexey Proskuryakov.
1743
1744         Forward declare some headers where possible
1745         https://bugs.webkit.org/show_bug.cgi?id=52133
1746
1747         * WebView/WebFrame.mm:
1748
1749 2011-01-09  Xianzhu Wang <phnixwxz@gmail.com>
1750
1751         Reviewed by Darin Fisher.
1752
1753         https://bugs.webkit.org/show_bug.cgi?id=41441
1754         createWindow method should only do window-creating without URL navigation
1755
1756         * WebCoreSupport/WebChromeClient.mm:
1757         (WebChromeClient::createWindow):
1758
1759 2011-01-08  Dan Bernstein  <mitz@apple.com>
1760
1761         Try to fix the Leopard build.
1762
1763         * WebView/WebFullScreenController.mm:
1764
1765 2011-01-07  Jer Noble  <jer.noble@apple.com>
1766
1767         Yet another Leopard build fix: NSRect and CGRect are not inter-
1768         changable in 32-bit.  
1769         
1770         * WebView/WebFullScreenController.mm:
1771         (-[WebFullScreenController exitFullscreen]):
1772
1773 2011-01-07  Jer Noble  <jer.noble@apple.com>
1774
1775         Fix the Leopard build: Replace CoreAnimation SL-only functions
1776         with Leopard equivalents.
1777
1778         * WebView/WebFullScreenController.mm:
1779         (+[CATransaction setDisableActions:]):
1780         (+[CATransaction setAnimationDuration:]):
1781         (-[WebFullScreenController _animationDuration]):
1782         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1783
1784 2010-12-21  Jer Noble  <jer.noble@apple.com>
1785
1786         Reviewed by Simon Fraser.
1787
1788         Implement WebKit Full Screen support.
1789         https://bugs.webkit.org/show_bug.cgi?id=49481
1790         rdar://problem/8247444
1791
1792         Support the new fullscreen Chrome client requests.  WebView will pass
1793         through these requests to a WebFullscreenController.
1794
1795         * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
1796         * WebView/WebView.mm:
1797         (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
1798         (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
1799         (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
1800         (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
1801         * WebView/WebViewData.h: Add ivar newFullscreenController.
1802
1803 2010-12-17  Jer Noble  <jer@kokode.apple.com>
1804
1805         Reviewed by Simon Fraser.
1806
1807         Implement WebKit Full Screen support.
1808         https://bugs.webkit.org/show_bug.cgi?id=49481
1809         rdar://problem/8247444
1810         
1811         This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
1812         Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
1813         window, and a custom CAAnimation animates that layer between the initial screen rect of the
1814         full screen element, to its final value. WebFullscreenController will swap the WebView out of
1815         its original window, and into the fullscreen window. The controller will replace the WebView
1816         with a placeholder view, so that if the placeholder moves or resized while the WebView is
1817         absent, the WebView will move back to the correct location when exiting fullscreen.
1818
1819         * WebView/WebFullscreenController.h: Added.
1820         * WebView/WebFullscreenController.mm: Added.
1821         (-[WebFullscreenController windowDidExitFullscreen:]):  Close the fullscreen window.
1822         (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window. 
1823         (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
1824         (-[WebFullscreenController applicationDidResignActive:]):
1825         (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
1826             the new screen parameters.
1827         (-[WebFullscreenController enterFullscreen:]):  Set up the animation that will take the fullscreen element
1828             from its original screen rect into fullscreen.
1829         (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
1830             Set up the animation that will take the fullscreen element back into its original screen
1831             rect.
1832         (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine 
1833             whether to disable screensaver and sleep.
1834         (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
1835             looking for HTMLVideoElements; returns whether any are found to be playing.
1836         (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
1837             and shift keys.
1838         (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
1839         (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
1840         (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
1841         (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
1842         (-[WebFullscreenWindow setRendererLayer:]): Ditto.
1843         (-[WebFullscreenWindow backgroundLayer]): Ditto.
1844         (-[WebFullscreenWindow animationView]): Ditto.
1845         (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
1846         (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
1847         
1848 2011-01-07  James Robinson  <jamesr@chromium.org>
1849
1850         Revert "Implement mozilla's animationTime property"
1851         https://bugs.webkit.org/show_bug.cgi?id=51952
1852
1853         This approach isn't quite right.
1854
1855         * WebView/WebHTMLView.mm:
1856         (-[WebHTMLView drawRect:]):
1857         * WebView/WebView.mm:
1858         (layerSyncRunLoopObserverCallBack):
1859
1860 2011-01-06  Gavin Barraclough  <barraclough@apple.com>
1861
1862         Reviewed by Geoff Garen.
1863
1864         Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
1865
1866         The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
1867         destructor early, in order to release wrappers once we know we no longer intend to use them.
1868         Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
1869         lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
1870         A sequence of events that triggers the bug would look like this:
1871
1872         (1) Create a DOMWrapperWorld.
1873         (2) Register a timer in the world.
1874         (3) Call unregisterWorld() on the world.
1875         (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
1876         (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
1877             called forgetWorld() none exists.
1878         (6) Attempt to add a wrapper to a NULL map.
1879
1880         Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
1881
1882         * WebView/WebScriptWorld.mm:
1883         (-[WebScriptWorld unregisterWorld]):
1884
1885 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1886
1887         Reviewed by Sam Weinig.
1888
1889         WK2: Support Accessibility
1890         https://bugs.webkit.org/show_bug.cgi?id=51859
1891
1892         Use rootObject() method to get top of AX tree.
1893
1894         * WebCoreSupport/WebFrameLoaderClient.h:
1895         (WebFrameLoaderClient::accessibilityRemoteObject):
1896         * WebView/WebFrame.mm:
1897         (-[WebFrame setAccessibleName:]):
1898         (-[WebFrame accessibilityRoot]):
1899         * WebView/WebFrameInternal.h:
1900         * WebView/WebFramePrivate.h:
1901         * WebView/WebHTMLView.mm:
1902         (-[WebHTMLView accessibilityAttributeValue:]):
1903         (-[WebHTMLView accessibilityFocusedUIElement]):
1904         (-[WebHTMLView accessibilityHitTest:]):
1905         (-[WebHTMLView _accessibilityParentForSubview:]):
1906
1907 2011-01-04  David Kilzer  <ddkilzer@apple.com>
1908
1909         <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
1910
1911         Reviewed by Eric Carlson.
1912
1913         This originally broke in r61581.  It is inside an
1914         ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
1915         build then.
1916
1917         * WebCoreSupport/WebFrameLoaderClient.mm: Call
1918         (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
1919         use WebCore::PluginInfo.name instead of
1920         -[WebBasePluginPackage name].
1921
1922 2011-01-02  Dan Bernstein  <mitz@apple.com>
1923
1924         Rubber-stamped by Simon Fraser.
1925
1926         <rdar://problem/8812159> Update copyright strings
1927
1928         * Info.plist:
1929
1930 2010-12-29  Dan Bernstein  <mitz@apple.com>
1931
1932         Reviewed by Ada Chan.
1933
1934         <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
1935         https://bugs.webkit.org/show_bug.cgi?id=51717
1936
1937         Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
1938         protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
1939
1940         * WebView/WebDocumentInternal.h:
1941         * WebView/WebHTMLView.mm:
1942         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1943         (-[WebHTMLView _findString:options:]):
1944         * WebView/WebView.mm:
1945         (findString):
1946
1947 2010-12-28  Daniel Bates  <dbates@rim.com>
1948
1949         Reviewed by Sam Weinig.
1950
1951         Substitute // MARK: for compiler-specific #pragma mark
1952         https://bugs.webkit.org/show_bug.cgi?id=51657
1953
1954         For consistency, we should substitute "// MARK:" for compiler-
1955         specific "#pragma mark" in the source files for the Mac port.
1956
1957         * History/WebHistory.mm:
1958         * Plugins/WebBaseNetscapePluginView.mm:
1959         * Plugins/WebNetscapePluginView.mm:
1960         * WebCoreSupport/WebInspectorClient.mm:
1961         * WebCoreSupport/WebSecurityOrigin.mm:
1962         * WebView/WebPDFView.mm:
1963         * WebView/WebVideoFullscreenController.mm:
1964         * WebView/WebVideoFullscreenHUDWindowController.mm:
1965
1966 2010-12-23  Yongjun Zhang  <yongjun_zhang@apple.com>
1967
1968         Reviewed by Darin Adler.
1969
1970         WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
1971         https://bugs.webkit.org/show_bug.cgi?id=38535
1972
1973         WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram.  As a result,
1974         if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
1975         WebScriptDebugger's callframe stack is wrong from this point.  That could cause crash if we trying to access the top
1976         call frame from this stack when an exception throws because the saved top frame could be invalid.
1977
1978         To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
1979         callEvent and returnEvent.
1980
1981         * WebView/WebScriptDebugger.mm:
1982         (WebScriptDebugger::willExecuteProgram):
1983         (WebScriptDebugger::didExecuteProgram):
1984
1985 2010-12-22  Sam Weinig  <sam@webkit.org>
1986
1987         Reviewed by Darin Adler.
1988
1989         WebKit2 needs to mirror the frame tree in the UIProcess
1990         https://bugs.webkit.org/show_bug.cgi?id=51546
1991
1992         - Add client functions to notify that a frame has been added or
1993           removed from the page cache.
1994
1995         * WebCoreSupport/WebFrameLoaderClient.h:
1996         * WebCoreSupport/WebFrameLoaderClient.mm:
1997         (WebFrameLoaderClient::didSaveToPageCache):
1998         (WebFrameLoaderClient::didRestoreFromPageCache):
1999
2000 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2001
2002         Reviewed by Eric Seidel.
2003
2004         Editor.h doesn't need to include SelectionController.h
2005         https://bugs.webkit.org/show_bug.cgi?id=51441
2006
2007         Renamed SelectionController::EDirection to SelectionDirection.
2008
2009         * WebView/WebFrame.mm:
2010         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
2011         Takes SelectionDirection instead of SelectionController::EDirection.
2012         * WebView/WebFrameInternal.h:
2013         * WebView/WebTextCompletionController.mm:
2014         (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
2015
2016 2010-12-22  Simon Fraser  <simon.fraser@apple.com>
2017
2018         Reviewed by Darin Adler.
2019
2020         Cache snapshots of plug-ins before painting, to avoid script running during painting
2021         https://bugs.webkit.org/show_bug.cgi?id=51493
2022
2023         When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
2024         or when printing), plug-ins which otherwise use the CA rendering model
2025         are sent a paint event. Some plug-ins may run script while handling this event,
2026         or out of process plug-ins may process queued requests at this time. Running
2027         script while inside layout or painting can have bad consequences, because it
2028         can result in arbitrary changes to the render tree.
2029         
2030         This patch avoids sending plug-ins paint events inside of painting. Instead,
2031         we ask the plug-ins to cache a snapshot before we paint, and then the software
2032         paint simply draws that snapshot.
2033
2034         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2035         (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
2036         draw it. Also only send the snapshot message to the plugin proxy if we
2037         know we're snapshotting, since even if creating the snapshot image failed,
2038         we still don't want to call to the plug-in.
2039
2040         * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
2041         * Plugins/WebBaseNetscapePluginView.mm:
2042         (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
2043         (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
2044
2045         * Plugins/WebNetscapePluginView.mm:
2046         (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
2047         * WebCoreSupport/WebFrameLoaderClient.mm:
2048         (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
2049         to cache and clear the snapshots.
2050
2051 2010-12-21  Cameron Zwarich  <zwarich@apple.com>
2052
2053         Reviewed by Darin Adler.
2054
2055         -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
2056         https://bugs.webkit.org/show_bug.cgi?id=51431
2057         <rdar://problem/8791757>
2058
2059         * Plugins/WebBasePluginPackage.mm:
2060         (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
2061         it doesn't underflow.
2062
2063 2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>
2064
2065         Reviewed by Cameron Zwarich.
2066
2067         REGRESSION(r74172): 125 java tests fail on Mac
2068         https://bugs.webkit.org/show_bug.cgi?id=51214
2069
2070         The regression was caused by an incorrectly adding sizeof(struct fat_header)
2071         to a pointer for uint32_t as supposed to uint8_t.
2072
2073         Fixed the bug by explicitly casting it to uint8_t* before the addition.
2074
2075         * Plugins/WebBasePluginPackage.mm:
2076         (-[WebBasePluginPackage isNativeLibraryData:]):
2077
2078 2010-12-15  Cameron Zwarich  <zwarich@apple.com>
2079
2080         Reviewed by Darin Adler.
2081
2082         Clang -Wcast-align gives an error in WebBasePluginPackage.mm
2083         https://bugs.webkit.org/show_bug.cgi?id=51144
2084
2085         Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
2086         we were calling it on a byte array 32 bits at a time. While this is okay in practice,
2087         since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
2088         inline storage is at the beginning of the Vector, it is still better to fix this
2089         and silence the warning.
2090
2091         * Plugins/WebBasePluginPackage.mm:
2092         (swapIntsInHeader):
2093         (-[WebBasePluginPackage isNativeLibraryData:]):
2094
2095 2010-12-14  Mark Rowe  <mrowe@apple.com>
2096
2097         Reviewed by Sam Weinig.
2098
2099         <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
2100
2101         * History/WebHistoryItem.mm:
2102         (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
2103         always including the target in the output.
2104
2105 2010-12-13  Alexey Proskuryakov  <ap@apple.com>
2106
2107         Reviewed by Adam Barth.
2108
2109         https://bugs.webkit.org/show_bug.cgi?id=50953
2110         DNS Prefetch should be an opt-in feature
2111
2112         * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
2113
2114 2010-12-13  Mike Thole  <mthole@apple.com>
2115
2116         Rubber-stamped by John Sullivan.
2117
2118         https://bugs.webkit.org/show_bug.cgi?id=50956
2119         WebAuthenticationPanel.nib appears to have a cut-off sentence
2120         
2121         Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
2122         The contents of this text field are updated dynamically before the sheet is displayed.
2123
2124         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
2125         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
2126
2127 2010-12-13  Antti Koivisto  <antti@apple.com>
2128
2129         Reviewed by Alexey Proskuryakov.
2130
2131         https://bugs.webkit.org/show_bug.cgi?id=50758
2132         <rdar://problem/8722094> 
2133         Defer loading print stylesheets
2134         
2135         Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
2136
2137         * WebView/WebView.mm:
2138         (+[WebView _setLoadResourcesSerially:forHost:]):
2139         * WebView/WebViewPrivate.h:
2140
2141 2010-12-09  Matthew Delaney  <mdelaney@apple.com>
2142
2143         Reviewed by Simon Fraser.
2144
2145         Adopt new CG API for canvas
2146         https://bugs.webkit.org/show_bug.cgi?id=50591
2147
2148         * WebCoreSupport/WebSystemInterface.mm:
2149
2150 2010-10-28  MORITA Hajime  <morrita@google.com>
2151
2152         Reviewed by Ojan Vafai.
2153
2154         spellcheck does not check pasted text
2155         https://bugs.webkit.org/show_bug.cgi?id=40092
2156
2157         Added asynchronous spell checking API to WebEditorClient using
2158         -[NSSpellChecker requestCheckingOfString].
2159         Note that WebEditorSpellCheckResponder is a small class to receive
2160         requested spell-checking result. Note that this feature is
2161         disabled at default.
2162         
2163         Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to 
2164         enable the feature from LayoutTestController.
2165
2166         * WebCoreSupport/WebEditorClient.h:
2167         * WebCoreSupport/WebEditorClient.mm:
2168         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
2169         (-[WebEditorSpellCheckResponder perform]):
2170         (toCoreSpellingResult):
2171         (-[WebEditorSpellCheckResponder WTF::WebCore::]):
2172         (WebEditorClient::requestCheckingOfString):
2173         * WebView/WebPreferenceKeysPrivate.h:
2174         * WebView/WebPreferences.mm:
2175         (+[WebPreferences initialize]):
2176         (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
2177         (-[WebPreferences asynchronousSpellCheckingEnabled]):
2178         * WebView/WebPreferencesPrivate.h:
2179         * WebView/WebView.mm:
2180         (-[WebView _preferencesChangedNotification:]):
2181
2182 2010-12-09  Anders Carlsson  <andersca@apple.com>
2183
2184         Fix a bug uncovered by clang++.
2185
2186         * WebView/WebHTMLView.mm:
2187         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2188
2189 2010-12-09  Anders Carlsson  <andersca@apple.com>
2190
2191         Clang++ build fixes.
2192
2193         Silence a couple of warnings.
2194
2195         * WebView/WebFrame.mm:
2196         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2197         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2198         * WebView/WebTextCompletionController.mm:
2199         (-[WebTextCompletionController filterKeyDown:]):
2200
2201 2010-12-09  David Hyatt  <hyatt@apple.com>
2202
2203         Reviewed by Dan Bernstein.
2204
2205         https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
2206         writing-mode.  This first part of the patch just patches Mac WebKit 1 views.
2207
2208         * WebView/WebFrameView.mm:
2209         (-[WebFrameView _isVerticalDocument]):
2210         (-[WebFrameView _isFlippedDocument]):
2211         (-[WebFrameView _scrollToEndOfDocument]):
2212         (-[WebFrameView _pageInBlockProgressionDirection:]):
2213         (-[WebFrameView scrollPageUp:]):
2214         (-[WebFrameView scrollPageDown:]):
2215
2216 2010-12-08  Andy Estes  <aestes@apple.com>
2217
2218         Reviewed by Darin Adler.
2219
2220         Enable pre-HTML5 parser quirks for Apple Mail.app
2221         https://bugs.webkit.org/show_bug.cgi?id=50727
2222
2223         * WebView/WebView.mm:
2224         (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
2225         application is Mail.app.
2226
2227 2010-12-08  Brian Weinstein  <bweinstein@apple.com>
2228
2229         Reviewed by John Sullivan.
2230
2231         REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
2232         https://bugs.webkit.org/show_bug.cgi?id=50683
2233         
2234         If our context menu item already has an action, don't overwrite the action with the context menu
2235         forwarder.
2236
2237         * WebView/WebHTMLView.mm:
2238         (setMenuItemTarget):
2239
2240 2010-12-08  Anders Carlsson  <andersca@apple.com>
2241
2242         Remove an unused variable.
2243
2244         * WebView/WebDynamicScrollBarsView.mm:
2245         (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
2246
2247 2010-12-07  Brian Weinstein  <bweinstein@apple.com>
2248
2249         Reviewed by John Sullivan.
2250
2251         Layering Violation in ContextMenu - member variable of type HitTestResult
2252         https://bugs.webkit.org/show_bug.cgi?id=50586
2253         
2254         Update users of ContextMenu and ContextMenuController to match where the new functions 
2255         are located.
2256
2257         * WebCoreSupport/WebContextMenuClient.mm:
2258         (WebContextMenuClient::getCustomMenuFromDefaultItems):
2259         (WebContextMenuClient::contextMenuItemSelected):
2260         * WebView/WebHTMLView.mm:
2261         (-[WebMenuTarget validateMenuItem:]):
2262
2263 2010-12-07  Brian Weinstein  <bweinstein@apple.com>
2264
2265         Reviewed by John Sullivan.
2266
2267         Part of Layering Violation in ContextMenu
2268         https://bugs.webkit.org/show_bug.cgi?id=50586
2269         
2270         Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
2271         was a layering violation. Also, make sure we set the menu item targets for all menu
2272         items before showing them, because the ContextMenu constructor doesn't do that anymore.
2273
2274         * WebView/WebHTMLView.mm:
2275         (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
2276         (-[WebMenuTarget WebCore::]): Ditto.
2277         (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
2278         (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
2279         (-[WebMenuTarget validateMenuItem:]): Ditto.
2280
2281         (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
2282         (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
2283             submenus), and calls setMenuItemTarget on them.
2284         (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
2285             them to the menu.
2286
2287 2010-12-06  Darin Adler  <darin@apple.com>
2288
2289         Reviewed by Sam Weinig.
2290
2291         Pass security origin to make local file decision correctly
2292         https://bugs.webkit.org/show_bug.cgi?id=48603
2293
2294         * WebView/WebPDFView.mm:
2295         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
2296
2297 2010-12-07  Martin Robinson  <mrobinson@igalia.com>
2298
2299         Unreviewed, rolling out r73392.
2300         http://trac.webkit.org/changeset/73392
2301         https://bugs.webkit.org/show_bug.cgi?id=50489
2302
2303         This commit caused crashes on the GTK+ bots
2304
2305         * WebView/WebFrame.mm:
2306         (-[WebFrame _canProvideDocumentSource]):
2307
2308 2010-12-07  Kenichi Ishibashi  <bashi@google.com>
2309
2310         Reviewed by Kent Tamura.
2311
2312         Let HTMLObjectElement be a form associated element
2313         https://bugs.webkit.org/show_bug.cgi?id=48821
2314
2315         Modified to use FormAssociatedElement instead of HTMLFormControlElement.
2316
2317         * WebView/WebHTMLRepresentation.mm:
2318         (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
2319         FormAssociatedElement instead of HTMLFormControlElement.
2320         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
2321
2322 2010-12-06  Nate Chapin  <japhet@chromium.org>
2323
2324         Reviewed by Adam Barth.
2325
2326         Update calls to DocumentWriter.
2327         https://bugs.webkit.org/show_bug.cgi?id=50489
2328
2329         * WebView/WebFrame.mm:
2330         (-[WebFrame _canProvideDocumentSource]):
2331
2332 2010-12-06  Chris Marrin  <cmarrin@apple.com>
2333
2334         Reviewed by Simon Fraser.
2335
2336         Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
2337         https://bugs.webkit.org/show_bug.cgi?id=49388
2338
2339         Got rid of GraphicsLayer::nativeLayer() call, replacing it with 
2340         GraphicsLayer::platformLayer().
2341
2342         * WebCoreSupport/WebChromeClient.mm:
2343         (WebChromeClient::attachRootGraphicsLayer):
2344
2345 2010-12-04  Dan Bernstein  <mitz@apple.com>
2346
2347         Reviewed by Sam Weinig.
2348
2349         WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
2350         https://bugs.webkit.org/show_bug.cgi?id=50530
2351
2352         * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
2353         * WebView/WebHTMLView.mm:
2354         (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
2355         which is passed through to WebCore.
2356         * WebView/WebPDFView.mm:
2357         (isFrameInRange): Added this helper function.
2358         (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
2359         a check if the frame is in the range.
2360         * WebView/WebView.mm:
2361         (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
2362         (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
2363         parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
2364         * WebView/WebViewPrivate.h:
2365
2366 2010-12-03  Sam Weinig  <sam@webkit.org>
2367
2368         Reviewed by Maciej Stachowiak.
2369
2370         Enable <a ping> for Mac/Windows/WebKit2 builds
2371         <rdar://problem/8504473>
2372         https://bugs.webkit.org/show_bug.cgi?id=50488
2373
2374         * WebView/WebPreferences.mm:
2375         (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
2376
2377 2010-12-03  Jia Pu  <jpu@apple.com>
2378
2379         Reviewed by Darin Adler.
2380
2381         Need to move all code that applies correction into correction panel callback.
2382         https://bugs.webkit.org/show_bug.cgi?id=50426
2383         <rdar://problem/8720832>
2384
2385         * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
2386
2387         * WebCoreSupport/WebEditorClient.mm:
2388         (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
2389         (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
2390         (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.
2391
2392 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2393
2394         Revert r73217 and r73227 because of continued bustage.
2395
2396         * WebCoreSupport/WebChromeClient.mm:
2397         (WebChromeClient::attachRootGraphicsLayer):
2398
2399 2010-12-02  Chris Marrin  <cmarrin@apple.com>
2400
2401         Reviewed by Simon Fraser.
2402
2403         Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
2404         https://bugs.webkit.org/show_bug.cgi?id=49388
2405
2406         Got rid of GraphicsLayer::nativeLayer() call, replacing it with 
2407         GraphicsLayer::platformLayer().
2408
2409         * WebCoreSupport/WebChromeClient.mm:
2410         (WebChromeClient::attachRootGraphicsLayer):
2411
2412 2010-12-02  Mark Rowe  <mrowe@apple.com>
2413
2414         Reviewed by Beth Dakin.
2415
2416         <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool
2417
2418         * Misc/WebNSFileManagerExtras.m:
2419         (setMetaData): Create an autorelease pool for the duration of the thread body.
2420
2421 2010-12-02  John Knottenbelt  <jknotten@chromium.org>
2422
2423         Reviewed by Steve Block.
2424
2425         Move requestGeolocationPermissionForFrame to GeolocationClient
2426         https://bugs.webkit.org/show_bug.cgi?id=50061
2427
2428         This change facilitates client-based geolocation implementation by
2429         bringing together permission control into the geolocation client
2430         interface.
2431
2432         Move method ChromeClient::requestGeolocationPermissionForFrame to
2433         GeolocationClient::requestPermission, and supporting class
2434         WebGeolocationPolicyListener. The moved code is unchanged except
2435         that requestPermission now takes only one argument (Geolocation*)
2436         and the Frame parameter is retrieved from the Geolocation object.
2437
2438         * WebCoreSupport/WebChromeClient.h:
2439         * WebCoreSupport/WebChromeClient.mm:
2440         * WebCoreSupport/WebGeolocationClient.h:
2441         (WebGeolocationClient::cancelPermissionRequest):
2442         * WebCoreSupport/WebGeolocationClient.mm:
2443         (WebGeolocationClient::requestPermission):
2444         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2445         (-[WebGeolocationPolicyListener allow]):
2446         (-[WebGeolocationPolicyListener deny]):
2447
2448 2010-12-02  Joseph Pecoraro  <joepeck@webkit.org>
2449
2450         Reviewed by Eric Carlson.
2451
2452         Style Fixes in WebPluginController
2453         https://bugs.webkit.org/show_bug.cgi?id=50397
2454
2455         * Plugins/WebPluginController.mm:
2456         (-[WebPluginController startAllPlugins]):
2457         (-[WebPluginController stopAllPlugins]):
2458
2459 2010-12-02  John Sullivan  <sullivan@apple.com>
2460
2461         Reviewed by Adam Roben.
2462         
2463         Slightly speculative fix for:
2464
2465         <rdar://problem/8712674>
2466         <https://bugs.webkit.org/show_bug.cgi?id=50393>
2467         setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]        
2468
2469         * Panels/WebAuthenticationPanel.m:
2470         (-[WebAuthenticationPanel setUpForChallenge:]):
2471         If the realm is nil, use @"" instead.
2472
2473 2010-12-01  Jia Pu  <jpu@apple.com>
2474
2475         Reviewed by Darin Adler.
2476
2477         Support multiple correction candidates panel for misspelled word on Mac OS X.
2478         https://bugs.webkit.org/show_bug.cgi?id=50137
2479         <rdar://problem/8568059>
2480
2481         This patch is for supporting multiple correction suggestion panel on Mac OS X.
2482         The behavior and implementation is similar to that of reversion candiate panel.
2483
2484         * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
2485
2486         * WebCoreSupport/WebEditorClient.mm:  Adopted new signatures defined in base class.
2487           Added code to handle new multiple suggestion canidate panel type.
2488         (WebEditorClient::showCorrectionPanel):
2489         (WebEditorClient::getGuessesForWord):
2490
2491 2010-12-01  David Hyatt  <hyatt@apple.com>
2492
2493         Reviewed by Darin Adler.
2494
2495         https://bugs.webkit.org/show_bug.cgi?id=46645
2496         
2497         Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
2498         recently added for horizontal RTL documents and applies it to writing modes as well.  Now the
2499         scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
2500         
2501         This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
2502         makes them behave the same as the cross-platform code (allowing for cross-platform results to be
2503         landed).
2504
2505         * WebView/WebDynamicScrollBarsView.mm:
2506         (-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
2507         (-[WebDynamicScrollBarsView updateScrollers]):
2508         (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
2509         (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
2510         (-[WebDynamicScrollBarsView scrollOrigin]):
2511         * WebView/WebFrameView.mm:
2512         (-[WebFrameView _scrollToBeginningOfDocument]):
2513         (-[WebFrameView _scrollToEndOfDocument]):
2514
2515 2010-11-29  Dan Bernstein  <mitz@apple.com>
2516
2517         Reviewed by Darin Adler.
2518
2519         WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
2520         https://bugs.webkit.org/show_bug.cgi?id=50038
2521         Based on a patch from Darin Adler.
2522
2523         * WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and
2524         replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
2525         method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
2526         method. Made WebHTMLView conform to the new protocol.
2527         * WebView/WebHTMLView.mm:
2528         (coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
2529         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
2530         -findString:options:.
2531         (-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
2532         (-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().
2533         * WebView/WebPDFView.mm:
2534         (-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
2535         * WebView/WebView.mm:
2536         (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
2537         -countMatchesForText:options:highlight:limit:markMatches.
2538         (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
2539         (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
2540         -findString:options:.
2541         (incrementFrame): Changed to use WebFindOptions.
2542         (findString): Added this helper method that performs the search using the best supported
2543         method for the document view.
2544         (-[WebView findString:options:]): Changed -searchFor::::: into this.
2545         (-[WebView canMarkAllTextMatches]):
2546         (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
2547         WebFindOptions.
2548         (-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
2549         (-[WebView rectsForTextMatches]): Ditto.
2550         * WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version
2551         of countMatchesForText:.
2552
2553 2010-11-29  Jeremy Moskovich  <jeremy@chromium.org>
2554
2555         Reviewed by David Hyatt.
2556
2557         Right-to-left pages should be scrollable to reveal left overflow.
2558         https://bugs.webkit.org/show_bug.cgi?id=23556
2559
2560         Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
2561         Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
2562         pages with a left overflow.
2563
2564         * WebView/WebDynamicScrollBarsView.h:
2565         * WebView/WebDynamicScrollBarsView.mm:
2566         (-[WebDynamicScrollBarsView inProgramaticScroll]):
2567         (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]):
2568         (-[WebDynamicScrollBarsView updateScrollers]):
2569         (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
2570         (-[WebDynamicScrollBarsView setScrollOriginX:]):
2571         (-[WebDynamicScrollBarsView scrollOriginX]):
2572         * WebView/WebFrameView.mm:
2573         (-[WebFrameView _scrollToBeginningOfDocument]):
2574         (-[WebFrameView _scrollToEndOfDocument]):
2575         * WebView/WebHTMLView.mm:
2576         (-[WebHTMLView _frameOrBoundsChanged]):
2577
2578 2010-11-22  Ryosuke Niwa  <rniwa@webkit.org>
2579
2580         Reviewed by Tony Chang.
2581
2582         SelectionController::typingStyle() should return EditingStyle*
2583         https://bugs.webkit.org/show_bug.cgi?id=49813
2584
2585         Changed the return value of SelectionController::typingStyle() to EditingStyle*.
2586         Also added SelectionController::copyTypingStyle() to copy the typing style
2587         as an instance of CSSMutableStyleDeclaration.
2588
2589         No tests are added since this is no behavioral change.
2590
2591         * WebView/WebFrame.mm:
2592         (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
2593
2594 2010-11-19  Michael Saboff  <msaboff@apple.com>
2595
2596         Reviewed by Sam Weinig
2597
2598         Remove DOMSVGAnimatedPathData.h from all: target to fix build.
2599
2600         * MigrateHeaders.make:
2601
2602 2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>
2603
2604         Reviewed by Dirk Schulze.
2605
2606         Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
2607         https://bugs.webkit.org/show_bug.cgi?id=49580
2608
2609         * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
2610
2611 2010-11-18  Mark Rowe  <mrowe@apple.com>
2612
2613         Rubber-stamped by Adam Roben.
2614
2615         <rdar://problem/8602509&8602717&8602724> Enable compaction support.
2616
2617         * Configurations/WebKit.xcconfig:
2618
2619 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
2620
2621         Unreviewed, rolling out r72288.
2622         http://trac.webkit.org/changeset/72288
2623         https://bugs.webkit.org/show_bug.cgi?id=49730
2624
2625         'krit attempted to do that, but revert got stuck' (Requested
2626         by antonm on #webkit).
2627
2628         * WebView/WebRenderLayer.mm:
2629
2630 2010-11-17  Nikolas Zimmermann  <nzimmermann@rim.com>
2631
2632         Reviewed by Dirk Schulze.
2633
2634         Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
2635         https://bugs.webkit.org/show_bug.cgi?id=49580
2636
2637         * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
2638
2639 2010-11-16  Stephanie Lewis  <slewis@apple.com>
2640
2641         Reviewed by Geoff Garen.
2642
2643         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
2644
2645         Make a static provider for WebDeviceOrientationProviderMock.  The old code allocated a new WebDeviceOrientationProviderMock for 
2646         every WebView, and the WebKit API doesn't support that ownership model.
2647
2648         * WebView/WebDeviceOrientationProviderMock.h:
2649         * WebView/WebDeviceOrientationProviderMock.mm:
2650         (+[WebDeviceOrientationProviderMock shared]):
2651
2652 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2653
2654         Reviewed by Dan Bernstein.
2655
2656         https://bugs.webkit.org/show_bug.cgi?id=11004
2657         
2658         font-size:0 is ignored.  Remove the minimum font size of 1 in CSSStyleSelector.
2659         Change the pref value for minimum font size from 1 to 0.  Make sure to never use the NSFont's size,
2660         since it doesn't honor a size of 0.  Instead pass the size in to the FontPlatformData(NSFont*) version
2661         of the constructor rather than using [NSFont pointSize].
2662
2663         https://bugs.webkit.org/show_bug.cgi?id=49582
2664         
2665         Negative leading is not handled correctly.  There are two bugs here.  The first is that
2666         maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
2667         set them before so that we can allow them to be < 0.
2668         
2669         The second issue is that we should understand where fonts will end up relative to
2670         our baseline (excluding line height), and only allow those boxes to impact ascent and
2671         descent if the actual font box (without factoring in line height) is above or below the
2672         root line box baseline.
2673
2674         Added fast/css/negative-leading.html
2675         
2676         These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
2677
2678         * Misc/WebKitNSStringExtras.mm:
2679         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2680         (-[NSString _web_widthWithFont:]):
2681         * Misc/WebStringTruncator.mm:
2682         (fontFromNSFont):
2683         * WebView/WebPreferences.mm:
2684         (+[WebPreferences initialize]):
2685
2686 2010-11-16  Anders Carlsson  <andersca@apple.com>
2687
2688         Fix clang++ build.
2689
2690         * WebCoreSupport/WebFrameLoaderClient.mm:
2691
2692 2010-11-14  Kent Tamura  <tkent@chromium.org>
2693
2694         Reviewed by Andreas Kling.
2695
2696         KeyboardEvent::keyIdentifier() should return "const String&"
2697         https://bugs.webkit.org/show_bug.cgi?id=49426
2698
2699         * WebCoreSupport/WebEditorClient.mm:
2700         (selectorForKeyEvent):
2701           Change the type of a variable to have keyIdentifier(); String -> const String&
2702
2703 2010-11-12  John Knottenbelt  <jknotten@chromium.org>
2704
2705         Reviewed by Steve Block.
2706
2707         Rename GeolocationControllerClient to GeolocationClient.
2708         https://bugs.webkit.org/show_bug.cgi?id=49259
2709
2710         * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h.
2711         (WebGeolocationClient::webView):
2712         (WebGeolocationClient::setEnableHighAccuracy):
2713         * WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm.
2714         (WebGeolocationClient::WebGeolocationClient):
2715         (WebGeolocationClient::geolocationDestroyed):
2716         (WebGeolocationClient::startUpdating):
2717         (WebGeolocationClient::stopUpdating):
2718         (WebGeolocationClient::lastPosition):
2719         * WebKit.order:
2720         * WebView/WebView.mm:
2721         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2722
2723 2010-11-10  Beth Dakin  <bdakin@apple.com>
2724
2725         Reviewed by Simon Fraser.
2726
2727         Fix for https://bugs.webkit.org/show_bug.cgi?id=49356 
2728         -[WebView _scaleWebView:] should take and origin and scroll the 
2729         document
2730         -and corresponding-
2731         <rdar://problem/8643921>
2732
2733         * WebView/WebView.mm:
2734         (-[WebView _scaleWebView:atOrigin:]):
2735         * WebView/WebViewPrivate.h:
2736
2737 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
2738
2739         Reviewed by David Hyatt.
2740
2741         HTML5 Ruby support should be mandatory feature
2742         https://bugs.webkit.org/show_bug.cgi?id=49272
2743
2744         Remove Ruby as optional feature.
2745
2746         * Configurations/FeatureDefines.xcconfig:
2747
2748 2010-11-08  Ned Holbrook  <nholbrook@apple.com>
2749
2750         Reviewed by Adam Barth.
2751
2752         Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
2753         https://bugs.webkit.org/show_bug.cgi?id=48886
2754
2755         * WebCoreSupport/WebSystemInterface.mm:
2756         (InitWebCoreSystemInterface):
2757
2758 2010-11-08  Nate Chapin  <japhet@chromium.org>
2759
2760         Unreviewed, build fix.
2761
2762         Clumsy typo in r71562.
2763
2764         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2765         (WebKit::HostedNetscapePluginStream::start):
2766
2767 2010-11-08  Nate Chapin  <japhet@chromium.org>
2768
2769         Reviewed by Alexey Proskuryakov.
2770
2771         Interface changes in https://bugs.webkit.org/show_bug.cgi?id=27165
2772
2773         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2774         (WebKit::HostedNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
2775         * Plugins/WebNetscapePluginStream.mm:
2776         (WebNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
2777         * WebView/WebView.mm:
2778         (-[WebView _dispatchPendingLoadRequests]): Use resourceLoadScheduler() instead of cache()->loader().
2779
2780 2010-11-08  Anders Carlsson  <andersca@apple.com>
2781
2782         Reviewed by Dan Bernstein.
2783
2784         Plug-in views should not assume that plugins are RenderEmbeddedObjects
2785         https://bugs.webkit.org/show_bug.cgi?id=49196
2786         <rdar://problem/8638467>
2787
2788         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2789         (-[WebHostedNetscapePluginView pluginHostDied]):
2790
2791 2010-11-08  Alexey Proskuryakov  <ap@apple.com>
2792
2793         Reviewed by Darin Adler.
2794
2795         https://bugs.webkit.org/show_bug.cgi?id=48685
2796         Notify UI process about focused frame
2797
2798         Added an empty implementation of the new ChromeClient method.
2799
2800         * WebCoreSupport/WebChromeClient.h:
2801         * WebCoreSupport/WebChromeClient.mm:
2802         (WebChromeClient::focusedFrameChanged):
2803
2804 2010-11-08  Anders Carlsson  <andersca@apple.com>
2805
2806         Build fix.
2807
2808         * MigrateHeaders.make:
2809
2810 2010-11-08  Anders Carlsson  <andersca@apple.com>
2811
2812         Reviewed by Adam Roben.
2813
2814         Remove use of HIGetScaleFactor
2815         https://bugs.webkit.org/show_bug.cgi?id=49186
2816         <rdar://problem/8618410>
2817
2818         Scale factors can vary on a display-by-display basis and it doesn't make sense
2819         to compute scale factor event coordinates like this.
2820
2821         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2822         (getCarbonEvent):
2823
2824 2010-11-08  Simon Fraser  <simon.fraser@apple.com>
2825
2826         Reviewed by Sam Weinig.
2827
2828         Allow applets to participate in accelerated compositing
2829         https://bugs.webkit.org/show_bug.cgi?id=49117
2830         <rdar://problem/8625819>
2831         
2832         If Java is being loaded via the Netscape Plugin API, create a
2833         NetscapePluginWidget so that it has an implementation of platformLayer().
2834         
2835         Also clean up by using early returns.
2836
2837         * WebCoreSupport/WebFrameLoaderClient.mm:
2838
2839 2010-11-07  Adam Barth  <abarth@webkit.org>
2840
2841         Reviewed by Eric Seidel.
2842
2843         Rename Cache to MemoryCache
2844         https://bugs.webkit.org/show_bug.cgi?id=49159
2845
2846         * Misc/WebCache.mm:
2847         (+[WebCache statistics]):
2848         * WebCoreSupport/WebDeviceOrientationClient.mm:
2849         (WebDeviceOrientationClient::setController):
2850         * WebView/WebView.mm:
2851
2852 2010-11-05  Alexey Proskuryakov  <ap@apple.com>
2853
2854         Reviewed by Darin Adler.
2855
2856         https://bugs.webkit.org/show_bug.cgi?id=49100
2857         ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]
2858
2859         * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]):
2860         Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive
2861         (see bug comments), and there seems to be no harm in executing this function in that case.
2862
2863 2010-11-05  Chris Marrin  <cmarrin@apple.com>
2864
2865         Reviewed by Simon Fraser.
2866
2867         Move resumeAnimations/suspendAnimations from Frame to AnimationController.
2868         https://bugs.webkit.org/show_bug.cgi?id=49073
2869
2870         * WebView/WebFrame.mm:
2871         (-[WebFrame _suspendAnimations]):
2872         (-[WebFrame _resumeAnimations]):
2873
2874 2010-11-04  Alexey Proskuryakov  <ap@apple.com>
2875
2876         Reviewed by Darin Adler.
2877
2878         https://bugs.webkit.org/show_bug.cgi?id=49008
2879         <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp
2880
2881         Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
2882         the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
2883         deleted during wait:
2884         - plugin crashed;
2885         - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in
2886         while waiting).
2887
2888         We didn't recognize the latter.
2889
2890         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2891         (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
2892         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2893         (WebKit::NetscapePluginInstanceProxy::waitForReply):
2894         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2895         (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
2896
2897 2010-11-05  Chris Marrin  <cmarrin@apple.com>
2898
2899         Reviewed by Simon Fraser.
2900
2901         Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
2902         https://bugs.webkit.org/show_bug.cgi?id=46945
2903
2904         * WebView/WebFrame.mm:
2905         (-[WebFrame _suspendAnimations]):
2906         (-[WebFrame _resumeAnimations]):
2907
2908 2010-11-04  Jia Pu  <jpu@apple.com>
2909
2910         Reviewed by Dan Bernstein.
2911
2912         reversion bubble in WebViews
2913         https://bugs.webkit.org/show_bug.cgi?id=47630
2914         <rdar://problem/8530960>
2915
2916         This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.
2917
2918         * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
2919         * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
2920           change to use new reversion API in AppKit.
2921         (WebEditorClient::WebEditorClient):
2922         (WebEditorClient::~WebEditorClient):
2923         (WebEditorClient::respondToChangedSelection):
2924         (WebEditorClient::showCorrectionPanel):
2925         (WebEditorClient::dismissCorrectionPanel):
2926         (WebEditorClient::isShowingCorrectionPanel):
2927
2928 2010-11-04  Mike Thole  <mthole@apple.com>
2929
2930         Reviewed by Dan Bernstein.
2931
2932         Title for images should use localized numerals
2933         https://bugs.webkit.org/show_bug.cgi?id=49017
2934
2935         * WebCoreSupport/WebPlatformStrategies.mm:
2936         (WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.
2937
2938 2010-11-02  Daniel Bates  <dbates@rim.com>
2939
2940         Reviewed by Adam Barth.
2941
2942         For unnamed frames, window.name returns a generated name
2943         https://bugs.webkit.org/show_bug.cgi?id=6751
2944
2945         Part 1 of 2.
2946
2947         Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port. 
2948
2949         * WebView/WebFrame.mm:
2950         (-[WebFrame name]):
2951
2952 2010-11-01  Brady Eidson  <beidson@apple.com>
2953
2954         Reviewed by Anders Carlsson.
2955
2956         <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
2957         Context menu support for WebKit 2.
2958
2959         * WebCoreSupport/WebChromeClient.h:
2960         (WebChromeClient::showContextMenu):
2961
2962 2010-10-29  Daniel Bates  <dbates@rim.com>
2963
2964         No review, rolling out 70971.
2965         http://trac.webkit.org/changeset/70971
2966         https://bugs.webkit.org/show_bug.cgi?id=6751
2967
2968         Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
2969         it caused layout test failures on all bots. In particular, the
2970         child count in a generated frame name differs after this patch. We need
2971         to look into this further.
2972
2973         * WebView/WebFrame.mm:
2974         (-[WebFrame name]):
2975
2976 2010-10-28  Antonio Gomes  <agomes@rim.com>
2977
2978         Reviewed by Ojan Vafai.
2979
2980         Needs a "LinuxEditingBehavior", perhaps with a better name
2981         https://bugs.webkit.org/show_bug.cgi?id=36627
2982
2983         Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
2984
2985         * WebView/WebFrame.mm:
2986         (core):
2987         * WebView/WebPreferencesPrivate.h:
2988
2989 2010-10-29  Daniel Bates  <dbates@rim.com>
2990
2991         Reviewed by Adam Barth.
2992
2993         For unnamed frames, window.name returns a generated name
2994         https://bugs.webkit.org/show_bug.cgi?id=6751
2995
2996         Modified Mac-port to use FrameTree::uniqueName().
2997
2998         * WebView/WebFrame.mm:
2999         (-[WebFrame name]):
3000
3001 2010-10-29  Darin Adler  <darin@apple.com>
3002
3003         Reviewed by Sam Weinig.
3004
3005         Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
3006         https://bugs.webkit.org/show_bug.cgi?id=48574
3007
3008         * History/WebBackForwardList.mm:
3009         Use BackForwardListImpl.
3010
3011 2010-10-29  Alexey Proskuryakov  <ap@apple.com>
3012
3013         Rubber-stamped by Sam Weinig.
3014
3015         Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
3016         create views for subframes.
3017
3018         * WebView/WebViewData.h: Double negation is better than a lie.
3019
3020 2010-10-27  Jer Noble  <jer.noble@apple.com>
3021
3022         Reviewed by Darin Adler.
3023
3024         Full screen video in Safari (still) exits full-screen if you switch to another 
3025         app on a multi-display system.
3026         https://bugs.webkit.org/show_bug.cgi?id=47364
3027         <rdar://problem/8382299>
3028         
3029         The FullScreen window does not technically close when it deactivates, but the 
3030         two NSWindows that make up the FullScreen feature should not hide when deactivated.
3031         
3032         * WebView/WebVideoFullscreenController.mm:
3033         (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
3034         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
3035         * WebView/WebVideoFullscreenHUDWindowController.mm:
3036         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
3037
3038 2010-10-29  Alexey Proskuryakov  <ap@apple.com>
3039
3040         Reviewed by Darin Adler.
3041
3042         https://bugs.webkit.org/show_bug.cgi?id=48576
3043         Let WebKit2 client know when a frame is a frameset
3044
3045         Added a blank implementation of the new FrameLoaderClient method.
3046
3047         * WebCoreSupport/WebFrameLoaderClient.h:
3048         * WebCoreSupport/WebFrameLoaderClient.mm:
3049         (WebFrameLoaderClient::dispatchDidBecomeFrameset):
3050
3051 2010-10-29  Csaba Osztrogonác  <ossy@webkit.org>
3052
3053         Reviewed by Adam Roben and David Kilzer.
3054
3055         Fix and cleanup of build systems
3056         https://bugs.webkit.org/show_bug.cgi?id=48342
3057
3058         * Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.
3059
3060 2010-10-28  Dan Bernstein  <mitz@apple.com>
3061
3062         Reviewed by Mark Rowe.
3063
3064         LLVM compiler build fix
3065
3066         * Misc/WebDownload.mm:
3067         (-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
3068         id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.
3069
3070 2010-10-28  Ivan Krstić  <ike@apple.com>
3071
3072         Reviewed by Mark Rowe.
3073
3074         Remove unused experimental proxied panel interface.
3075         <rdar://problem/7237059>
3076
3077         * Plugins/Hosted/NetscapePluginHostManager.h:
3078         * Plugins/Hosted/NetscapePluginHostManager.mm:
3079         (WebKit::NetscapePluginHostManager::hostForPlugin):
3080         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3081         (WebKit::NetscapePluginHostManager::instantiatePlugin):
3082         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3083         * Plugins/Hosted/WebKitPluginClient.defs:
3084         * Plugins/Hosted/WebKitPluginHost.defs:
3085         * WebCoreSupport/WebSystemInterface.mm:
3086         (InitWebCoreSystemInterface):
3087         * WebView/WebPreferenceKeysPrivate.h:
3088         * WebView/WebPreferences.mm:
3089         (+[WebPreferences initialize]):
3090         * WebView/WebPreferencesPrivate.h:
3091
3092 2010-10-27  Pratik Solanki  <psolanki@apple.com>
3093
3094         Reviewed by Darin Adler.
3095
3096         Improve memSize calculation in [WebView _setCacheModel]
3097         https://bugs.webkit.org/show_bug.cgi?id=48484
3098
3099         * WebView/WebView.mm:
3100         (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2.
3101         (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next
3102         bigger power of 2. Also update WebCore cache settings.
3103
3104 2010-10-26  Darin Adler  <darin@apple.com>
3105
3106         Reviewed by Sam Weinig.
3107
3108         WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
3109         https://bugs.webkit.org/show_bug.cgi?id=42322
3110         rdar://problem/8193631
3111
3112         WebKitTestRunner needs to support layoutTestController.clearBackForwardList
3113         https://bugs.webkit.org/show_bug.cgi?id=42333
3114         rdar://problem/8193643
3115
3116         * History/WebBackForwardList.mm:
3117         (core): Return BackForwardListImpl.
3118         (kit): Take BackForwardListImpl.
3119         (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
3120         (-[WebBackForwardList dealloc]): Ditto.
3121         (-[WebBackForwardList finalize]): Ditto.
3122         (-[WebBackForwardList description]): Ditto.
3123         (-[WebBackForwardList setPageCacheSize:]): Ditto.
3124         (-[WebBackForwardList pageCacheSize]): Ditto.
3125         * History/WebBackForwardListInternal.h: Ditto.
3126         * WebView/WebFrameView.mm:
3127         (-[WebFrameView keyDown:]): Ditto.
3128         * WebView/WebView.mm:
3129         (-[WebView initWithCoder:]): Ditto.
3130         (-[WebView encodeWithCoder:]): Ditto.
3131         (-[WebView backForwardList]): Ditto.
3132         (-[WebView setMaintainsBackForwardList:]): Ditto.
3133
3134 2010-10-27  Chris Rogers  <crogers@google.com>
3135
3136         Reviewed by Chris Marrin.
3137
3138         Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
3139         https://bugs.webkit.org/show_bug.cgi?id=48279
3140
3141         * Configurations/FeatureDefines.xcconfig:
3142
3143 2010-10-27  Beth Dakin  <bdakin@apple.com>
3144
3145         Reviewed by Darin Adler.
3146
3147         Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit 
3148         SPI to scale a WebView
3149         -and corresponding-
3150         <rdar://problem/8107667>
3151
3152         This patch adds SPI to Mac WebKit that scales the page by the given 
3153         scale factor.
3154
3155         * WebView/WebView.mm:
3156         (-[WebView _scaleWebView:]):
3157         (-[WebView _viewScaleFactor]):
3158         * WebView/WebViewPrivate.h:
3159
3160 2010-10-27  Dan Bernstein  <mitz@apple.com>
3161
3162         Reviewed by Darin Adler.
3163
3164         REGRESSION (r70335): Incorrect article layout in Safari Reader
3165         https://bugs.webkit.org/show_bug.cgi?id=48436
3166
3167         * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
3168         * WebView/WebView.mm:
3169         (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
3170         versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
3171         (-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
3172         based on the above.
3173
3174 2010-10-18  Jer Noble  <jer.noble@apple.com>
3175
3176         Reviewed by Eric Carlson.
3177
3178         Safari fullscreen media element tickles when it should not.
3179         
3180         https://bugs.webkit.org/show_bug.cgi?id=47861
3181
3182         * WebView/WebVideoFullscreenController.mm:
3183         (-[WebVideoFullscreenController updatePowerAssertions]):
3184
3185 2010-10-26  Jenn Braithwaite  <jennb@chromium.org>
3186
3187         Reviewed by Dmitry Titov.
3188
3189         Resource tracking failure when trying to move a frame between documents
3190         https://bugs.webkit.org/show_bug.cgi?id=44713
3191
3192         * WebCoreSupport/WebFrameLoaderClient.h:
3193         * WebCoreSupport/WebFrameLoaderClient.mm:
3194         (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
3195         Empty method.
3196         (WebFrameLoaderClient::transferLoadingResourceFromPage):
3197         Update resource tracking for a resource load that has been transferred
3198         to a new page.
3199
3200 2010-10-25  Oliver Hunt  <oliver@apple.com>
3201
3202         Reviewed by Gavin Barraclough.
3203
3204         Remove exec and globalData arguments from jsNumber
3205         https://bugs.webkit.org/show_bug.cgi?id=48270
3206
3207         Mechanical removal of exec parameter to jsNumber
3208
3209         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3210         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
3211         * Plugins/Hosted/ProxyInstance.mm:
3212         (WebKit::ProxyInstance::numberValue):
3213
3214 2010-10-24  Dan Bernstein  <mitz@apple.com>
3215
3216         Reviewed by Anders Carlsson.
3217
3218         Expose HitTestResult::absoluteMediaURL() via WebKit API
3219         https://bugs.webkit.org/show_bug.cgi?id=48219
3220
3221         * Misc/WebElementDictionary.mm:
3222         (+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
3223         _absoluteMediaURL.
3224         (-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().
3225         * WebKit.exp: Export WebElementMediaURLKey.
3226         * WebView/WebView.mm: Define WebElementMediaURLKey.
3227         * WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.
3228
3229 2010-10-24  Dan Bernstein  <mitz@apple.com>
3230
3231         Reviewed by Simon Fraser.
3232
3233         Removed deprecated methods from the WebHTMLHighlighter private protocol.
3234
3235         * WebCoreSupport/WebChromeClient.mm:
3236         (WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
3237         unconditionally.
3238         (WebChromeClient::paintCustomHighlight): Call
3239         -paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.
3240         * WebView/WebHTMLViewPrivate.h:
3241
3242 2010-10-23  Xan Lopez  <xlopez@igalia.com>
3243
3244         Reviewed by Sam Weinig.
3245
3246         Unify globalData APIs
3247         https://bugs.webkit.org/show_bug.cgi?id=47969
3248
3249         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3250         (WebKit::NetscapePluginInstanceProxy::evaluate):
3251         (WebKit::NetscapePluginInstanceProxy::invoke):
3252         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3253         (WebKit::NetscapePluginInstanceProxy::construct):
3254         * WebView/WebScriptDebugDelegate.mm:
3255         (-[WebScriptCallFrame evaluateWebScript:]):
3256
3257 2010-10-23  David Kilzer  <ddkilzer@apple.com>
3258
3259         <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
3260
3261         Reviewed by Sam Weinig.
3262
3263         The only method defined in WebHTMLRepresentationInternal.h is
3264         also defined in WebHTMLRepresentation.h, so use that instead.
3265
3266         * WebView/WebHTMLRepresentationInternal.h: Removed.
3267
3268 2010-10-23  Alexey Proskuryakov  <ap@apple.com>
3269
3270         Reviewed by Anders Carlsson.
3271
3272         https://bugs.webkit.org/show_bug.cgi?id=48083
3273         <rdar://problem/8489082> Need WebKit2 API for private browsing (48083)
3274
3275         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize the new method.
3276
3277 2010-10-22  Sam Weinig  <sam@webkit.org>
3278
3279         Reviewed by Anders Carlsson.
3280
3281         WebKit2 needs to pass the current event modifier flags when requesting a new window
3282         https://bugs.webkit.org/show_bug.cgi?id=48140
3283
3284         * WebCoreSupport/WebChromeClient.h:
3285         * WebCoreSupport/WebChromeClient.mm:
3286         (WebChromeClient::createWindow):
3287         * WebCoreSupport/WebFrameLoaderClient.h:
3288         * WebCoreSupport/WebFrameLoaderClient.mm:
3289         (WebFrameLoaderClient::dispatchCreatePage):
3290         Add NavigationAction parameter.
3291
3292 2010-10-21  Andy Estes  <aestes@apple.com>
3293
3294         Reviewed by Eric Carlson.
3295
3296         WebKit shouldn't load a plug-in based on file extension if a MIME type
3297         is specified.
3298         https://bugs.webkit.org/show_bug.cgi?id=48046
3299
3300         If a MIME type is specified in an object or embed element, and that MIME
3301         type isn't supported by an installed plug-in, WebKit shouldn't attempt
3302         to find a plug-in based on the file extension of the url attribute.
3303         Doing so can lead to cases where a plug-in is loaded that can't handle
3304         resources of the MIME type specified by the author.
3305
3306         * WebCoreSupport/WebFrameLoaderClient.mm:
3307         (WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by
3308         extension if MIME type is the empty string.
3309
3310 2010-10-20  Simon Fraser  <simon.fraser@apple.com>
3311
3312         Reviewed by Dan Bernstein.
3313
3314         Composited elements drawn twice when WebView is layer-backed
3315         https://bugs.webkit.org/show_bug.cgi?id=48024
3316         <rdar://problem/7916580>
3317         
3318         When drawing content in a layer-backed WebView, WebFrame's test
3319         for drawing to a bitmap succeeded, causing us to paint flattened
3320         compositing layers into the view. They would also be rendered
3321         by the normal compositing path, resulting in double rendering.
3322         
3323         Fix this by detecting when the WebHTMLView is being drawn into
3324         a layer, and avoiding flattening in that case.
3325
3326         * WebView/WebFrame.mm:
3327         (-[WebFrame _showFlattenedCompositingLayers:]):
3328         (-[WebFrame _drawRect:contentsOnly:]):
3329         * WebView/WebHTMLView.mm:
3330         (-[WebHTMLView drawLayer:inContext:]):
3331         (-[WebHTMLView _web_isDrawingIntoLayer]):
3332         * WebView/WebHTMLViewInternal.h:
3333
3334 2010-10-20  Dumitru Daniliuc  <dumi@chromium.org>
3335
3336         Reviewed by David Levin.
3337
3338         Repost the DatabaseTracker notifications to the main thread, if needed.
3339         https://bugs.webkit.org/show_bug.cgi?id=40655
3340
3341         * Storage/WebDatabaseTrackerClient.mm:
3342         (DidModifyOriginData::dispatchToMainThread):
3343         (DidModifyOriginData::DidModifyOriginData):
3344         (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
3345         (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
3346         (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
3347
3348 2010-10-20  Simon Fraser  <simon.fraser@apple.com>
3349
3350         Reviewed by Darin Adler.
3351
3352         REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard
3353         https://bugs.webkit.org/show_bug.cgi?id=47369
3354         
3355         r46947 added code that limits the size of the layer-backed view on Leopard when
3356         the page height exceeds 4096px (later adjusted to 2048px in r48401).
3357         
3358         Later, r67576 altered the geometry flipping behavior to push the geometry flipping
3359         down into WebKit. However, the code that adjusts the hosting layer's sublayer transform
3360         to account for layer-backed view size-limiting was not fixed at the same time.
3361         This change corrects that.
3362
3363         * WebView/WebHTMLView.mm:
3364         (-[WebHTMLView _updateLayerHostingViewPosition]):
3365
3366 2010-10-19  Simon Fraser  <simon.fraser@apple.com>
3367
3368         Reviewed by Dan Bernstein.
3369
3370         <rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews
3371         
3372         AppKit has some special code to prevent it meddling with view's layers
3373         under layer-backed WebViews. When a layer-backed WebView became composited,
3374         this caused our layer to remain zero-sized. Fix this by manually
3375         setting the geometry for our layer, if the WebHTMLView has a layer.
3376         
3377         This does not seem to be a problem if the WebView becomes layer-backed, or
3378         stops being layer-backed after the WebView starts using compositing.
3379
3380         * WebView/WebHTMLView.mm:
3381         (-[WebHTMLView attachRootLayer:]):
3382
3383 2010-10-20  Dirk Schulze  <krit@webkit.org>
3384
3385         Reviewed by Nikolas Zimmermann.
3386
3387         Merge ColorSpace and ImageColorSpace enums
3388         https://bugs.webkit.org/show_bug.cgi?id=47922
3389
3390         Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
3391         to follow webkit style rules.
3392
3393         * Misc/WebKitNSStringExtras.mm:
3394         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
3395
3396 2010-10-19  Alexey Proskuryakov  <ap@apple.com>
3397
3398         Reviewed by Anders Carlsson.
3399
3400         https://bugs.webkit.org/show_bug.cgi?id=47933
3401         <rdar://problem/8494337> navigator.language doesn't work in WebKit2
3402
3403         * Misc/WebNSUserDefaultsExtras.mm: Moved code for computing default language to WebCore.
3404         We need to keep _webkit_preferredLanguageCode for Safari.
3405
3406         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
3407         Initialize wkCopyCFLocalizationPreferredName.
3408
3409         * WebCoreSupport/WebViewFactory.mm: Removed defaultLanguage. WebCore was the only caller.
3410
3411 2010-10-18  Alexey Proskuryakov  <ap@apple.com>
3412
3413         Reviewed by David Kilzer.
3414
3415         https://bugs.webkit.org/show_bug.cgi?id=47864
3416         Convert WebNSUserDefaultsExtras.m to .mm
3417
3418         Also, fixed some issues in the process:
3419         - removed locking, which was only necessary when this code was in Foundation;
3420         - fixed notification center observer to actually work (previously, it picked up changes
3421         when application preferences changed, not when system language did);
3422         - removed unused NSString category;
3423         - updated style.
3424
3425         * Misc/WebNSUserDefaultsExtras.m: Removed.
3426         * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m.
3427         (createHTTPStyleLanguageCode):
3428         (+[NSUserDefaults _webkit_defaultsDidChange]):
3429         (addLanguageChangeObserver):
3430         (+[NSUserDefaults _webkit_preferredLanguageCode]):
3431
3432 2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>
3433
3434         Reviewed by Eric Seidel.
3435
3436         Switch to using the new Carbon NPAPI event declarations, and remove
3437         the old ones.
3438
3439         https://bugs.webkit.org/show_bug.cgi?id=40784
3440
3441         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3442         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
3443         (WebNetscapePluginEventHandlerCarbon::mouseExited):
3444         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
3445         (WebNetscapePluginEventHandlerCarbon::focusChanged):
3446
3447 2010-10-18  Pavel Podivilov  <podivilov@chromium.org>
3448
3449         Reviewed by Timothy Hatcher.
3450
3451         Web Inspector: disable private browsing for inspector
3452         https://bugs.webkit.org/show_bug.cgi?id=47827
3453
3454         * WebCoreSupport/WebInspectorClient.mm:
3455         (-[WebInspectorWindowController init]):
3456
3457 2010-10-14  Ilya Tikhonovsky  <loislo@chromium.org>
3458
3459         Reviewed by Pavel Feldman.
3460
3461         Web Inspector: inspector settings/properties/states management
3462         should be extracted into separate class.
3463
3464         We have a lot of flags/values in InspectorController.
3465         Some flags are persisting into profile.
3466         Others are part of inspector state for frontend.
3467         All these flags should keep their values after navigation.
3468         It'd be better to extract these flags/values into separate
3469         class which will care about theirs lifetime.
3470
3471         https://bugs.webkit.org/show_bug.cgi?id=47275
3472
3473         * WebCoreSupport/WebInspectorClient.mm:
3474         (-[WebInspectorWindowController showWindow:]):
3475         (-[WebInspectorWindowController attach]):
3476         (-[WebInspectorWindowController detach]):
3477
3478 2010-10-13  Gavin Barraclough  <barraclough@apple.com>
3479
3480         Reviewed by Oliver Hunt.
3481
3482         https://bugs.webkit.org/show_bug.cgi?id=43987
3483         Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
3484         to construct their internal result string.  Remove ScriptString (this is now
3485         redundant).
3486
3487         * WebCoreSupport/WebFrameLoaderClient.mm:
3488
3489 2010-10-12  Andy Estes  <aestes@apple.com>
3490
3491         Rubber-stamped by Darin Adler.
3492
3493         Check in some cleanup from the previous commit.
3494
3495         * WebView/WebView.mm:
3496         (leakMailQuirksUserScriptPath): Renamed to indicate that this function
3497         leaks an NSString.
3498         (-[WebView _injectMailQuirksScript]): Moved a static initialization from
3499         a separate class method into the only method that used it and removed
3500         the now-unnecessary class method.
3501
3502 2010-10-12  Eric Seidel  <eric@webkit.org>
3503
3504         Reviewed by Darin Adler.
3505
3506         REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
3507         https://bugs.webkit.org/show_bug.cgi?id=45693
3508
3509         Re-implement this former WebCore parser quirk as a
3510         Mac-only userscript-based quirk.  As far as I can tell
3511         from Darin's description this should satisfy Mail's needs.
3512
3513         * Misc/MailQuirksUserScript.js: Added.
3514         * WebView/WebView.mm:
3515         (+[WebView _mailQuirksUserScript]):
3516         (-[WebView _injectMailQuirksScript]):
3517         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3518
3519 2010-10-12  Simon Fraser  <simon.fraser@apple.com>
3520
3521         Reviewed by Sam Weinig.
3522
3523         Add 'didDraw' callback for framerate tracking
3524         https://bugs.webkit.org/show_bug.cgi?id=47478
3525
3526         Add a callback at the end of -[WebHTMLView drawRect:] so
3527         a delegate can get notified when a draw happens.
3528         
3529         * WebView/WebHTMLView.mm:
3530         (-[WebHTMLView drawRect:]):
3531         * WebView/WebUIDelegatePrivate.h:
3532
3533 2010-10-11  Anders Carlsson  <andersca@apple.com>
3534
3535         Reviewed by Darin Adler.
3536
3537         Remove WebIconFetcher from WebKit and IconFetcher from WebCore
3538         https://bugs.webkit.org/show_bug.cgi?id=47523
3539
3540         Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
3541
3542         * Misc/WebIconFetcher.h: Removed.
3543         * Misc/WebIconFetcher.mm: Removed.
3544         * Misc/WebIconFetcherInternal.h: Removed.
3545         * WebView/WebFrame.mm:
3546         * WebView/WebFramePrivate.h:
3547
3548 2010-10-11  Jessie Berlin  <jberlin@apple.com>