Update supported platforms in xcconfig files to match the sdk names.
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2016-07-13  Enrica Casucci  <enrica@apple.com>
2
3         Update supported platforms in xcconfig files to match the sdk names.
4         https://bugs.webkit.org/show_bug.cgi?id=159728
5
6         Reviewed by Tim Horton.
7
8         * Configurations/Base.xcconfig:
9
10 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
11
12         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
13         https://bugs.webkit.org/show_bug.cgi?id=159671
14
15         Reviewed by Csaba Osztrogonác.
16
17         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
18         https://bugs.webkit.org/show_bug.cgi?id=89235
19
20         So this guard can be removed in build scripts.
21
22         * Configurations/FeatureDefines.xcconfig:
23
24 2016-07-11  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
25
26         Purge PassRefPtr in platform/efl and platform/mac 
27         https://bugs.webkit.org/show_bug.cgi?id=159548
28
29         Reviewed by Alex Christensen.
30
31         Remove all use of PassRefPtr and clean up unnecessary tabs and spaces.
32
33         * WebCoreSupport/WebPlatformStrategies.h:
34         * WebCoreSupport/WebPlatformStrategies.mm:
35         (WebPlatformStrategies::setBufferForType):
36
37 2016-07-11  Enrica Casucci  <enrica@apple.com>
38
39         Add synthetic click origin to WKNavigationAction.
40         https://bugs.webkit.org/show_bug.cgi?id=159584
41         rdar://problem/25610422
42
43         Reviewed by Tim Horton.
44
45         * WebView/WebFrame.mm:
46         (-[WebFrame _dragSourceEndedAt:operation:]):
47         * WebView/WebPDFView.mm:
48         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
49
50 2016-07-11  Anders Carlsson  <andersca@apple.com>
51
52         Able to open multiple payment sheets in Safari at the same time
53         https://bugs.webkit.org/show_bug.cgi?id=159637
54         rdar://problem/26411339
55
56         Reviewed by Beth Dakin.
57
58         Update for WebCore changes.
59
60         * WebCoreSupport/WebPaymentCoordinatorClient.h:
61         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
62         (WebPaymentCoordinatorClient::showPaymentUI):
63
64 2016-07-08  Andy Estes  <aestes@apple.com>
65
66         [Content Filtering] Load blocked pages more like other error pages are loaded
67         https://bugs.webkit.org/show_bug.cgi?id=159485
68         <rdar://problem/26014076>
69
70         Reviewed by Brady Eidson.
71
72         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
73         * Misc/WebKitErrors.m:
74         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
75         * WebCoreSupport/WebFrameLoaderClient.h:
76         * WebCoreSupport/WebFrameLoaderClient.mm:
77         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
78
79 2016-07-08  Commit Queue  <commit-queue@webkit.org>
80
81         Unreviewed, rolling out r202944.
82         https://bugs.webkit.org/show_bug.cgi?id=159570
83
84         caused some tests to crash under GuardMalloc (Requested by
85         estes on #webkit).
86
87         Reverted changeset:
88
89         "[Content Filtering] Load blocked pages more like other error
90         pages are loaded"
91         https://bugs.webkit.org/show_bug.cgi?id=159485
92         http://trac.webkit.org/changeset/202944
93
94 2016-07-08  Jiewen Tan  <jiewen_tan@apple.com>
95
96         Define DYLD_MACOSX_VERSION_10_12
97         https://bugs.webkit.org/show_bug.cgi?id=159525
98         <rdar://problem/26250296>
99
100         Reviewed by Brent Fulgham.
101
102         * WebView/WebView.mm:
103         (shouldConvertInvalidURLsToBlank):
104         Replace 0x000A0C00 with DYLD_MACOSX_VERSION_10_12.
105
106 2016-07-07  Beth Dakin  <bdakin@apple.com>
107
108         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
109         https://bugs.webkit.org/show_bug.cgi?id=159532
110         -and corresponding-
111         rdar://problem/27177179
112
113         Reviewed by Tim Horton.
114
115         * WebView/WebView.mm:
116         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
117         (-[WebView forceRequestCandidatesForTesting]):
118         (-[WebView shouldRequestCandidates]):
119         * WebView/WebViewPrivate.h:
120
121 2016-07-07  Andy Estes  <aestes@apple.com>
122
123         [Content Filtering] Load blocked pages more like other error pages are loaded
124         https://bugs.webkit.org/show_bug.cgi?id=159485
125         <rdar://problem/26014076>
126
127         Reviewed by Brady Eidson.
128
129         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
130         * Misc/WebKitErrors.m:
131         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
132         * WebCoreSupport/WebFrameLoaderClient.h:
133         * WebCoreSupport/WebFrameLoaderClient.mm:
134         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
135
136 2016-07-07  Alex Christensen  <achristensen@webkit.org>
137
138         Use SocketProvider to create WebSocketChannels
139         https://bugs.webkit.org/show_bug.cgi?id=158776
140
141         Reviewed by Brent Fulgham.
142
143         * Misc/WebSocketProvider.mm: Copied from Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp.
144         (WebSocketProvider::createWebSocketChannel):
145         (WebCore::ThreadableWebSocketChannel::create): Deleted.
146         * Misc/WebSocketProvider.h:
147         * WebView/WebView.mm:
148         (-[WebView _commonInitializationWithFrameName:groupName:]):
149         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
150
151 2016-07-06  Benjamin Poulain  <bpoulain@apple.com>
152
153         [JSC] Unify how we throw TypeError from C++
154         https://bugs.webkit.org/show_bug.cgi?id=159500
155
156         Reviewed by Saam Barati.
157
158         * Plugins/Hosted/ProxyInstance.mm:
159         (WebKit::ProxyInstance::invokeMethod):
160
161 2016-07-01  Youenn Fablet  <youennf@gmail.com>
162
163         Add a runtime flag for DOM iterators
164         https://bugs.webkit.org/show_bug.cgi?id=159300
165
166         Reviewed by Alex Christensen.
167
168         * WebView/WebPreferenceKeysPrivate.h:
169         * WebView/WebPreferences.mm:
170         (-[WebPreferences DOMIteratorEnabled]):
171         (-[WebPreferences setDOMIteratorEnabled:]):
172         * WebView/WebPreferencesPrivate.h:
173         * WebView/WebView.mm:
174         (-[WebView _preferencesChanged:]):
175
176 2016-06-30  Jiewen Tan  <jiewen_tan@apple.com>
177
178         Create a generic "linked-on-or-after" check for new CSP Rules
179         https://bugs.webkit.org/show_bug.cgi?id=159322
180         <rdar://problem/27117220>
181
182         Reviewed by Brent Fulgham.
183
184         * WebView/WebView.mm:
185         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
186
187 2016-06-30  Anders Carlsson  <andersca@apple.com>
188
189         Mail crashes on launch at WebCore::PaymentCoordinator::~PaymentCoordinator() + 20
190         https://bugs.webkit.org/show_bug.cgi?id=159306
191         rdar://problem/27092107
192
193         Reviewed by Tim Horton.
194
195         * WebView/WebView.mm:
196         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
197         Create a WebPaymentCoordinatorClient. Remove an unneeded #import.
198
199         (-[WebView _commonInitializationWithFrameName:groupName:]):
200         Remove an unneeded #import.
201
202 2016-06-27  Anders Carlsson  <andersca@apple.com>
203
204         WebKit::WebPaymentCoordinator leak
205         https://bugs.webkit.org/show_bug.cgi?id=159168
206         rdar://problem/26929772
207
208         Reviewed by Beth Dakin.
209
210         Update for WebCore changes.
211
212         * WebCoreSupport/WebPaymentCoordinatorClient.h:
213         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
214         (WebPaymentCoordinatorClient::paymentCoordinatorDestroyed):
215         (WebPaymentCoordinatorClient::mainFrameDestroyed): Deleted.
216
217 2016-06-27  Tim Horton  <timothy_horton@apple.com>
218
219         REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app
220         https://bugs.webkit.org/show_bug.cgi?id=159184
221         <rdar://problem/26370206>
222
223         Reviewed by Beth Dakin.
224
225         * WebView/WebHTMLView.mm:
226         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
227         * WebView/WebImmediateActionController.h:
228         * WebView/WebImmediateActionController.mm:
229         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
230         (-[WebImmediateActionController _animationControllerForText]):
231         (dictionaryPopupInfoForRange): Deleted.
232         WebImmediateActionController's code to make a DictionaryPopupInfo and TextIndicator
233         from a Range in WebKit1 is much better than WebHTMLView's; use it in both cases.
234
235 2016-06-24  Jer Noble  <jer.noble@apple.com>
236
237         Playback controls refer to wrong element when playing multiple items in a page.
238         https://bugs.webkit.org/show_bug.cgi?id=159076
239         <rdar://problem/26953532>
240
241         Reviewed by Beth Dakin.
242
243         clearPlaybackControlsManager() no longer takes a parameter.
244
245         * WebCoreSupport/WebChromeClient.h:
246         * WebCoreSupport/WebChromeClient.mm:
247         (WebChromeClient::clearPlaybackControlsManager):
248         * WebView/WebView.mm:
249         (-[WebView _clearPlaybackControlsManager]): Renamed from _clearPlaybackControlsManagerForMediaElement:.
250         * WebView/WebViewInternal.h:
251
252 2016-06-23  Alex Christensen  <achristensen@webkit.org>
253
254         Remove unused didCancelAuthenticationChallenge
255         https://bugs.webkit.org/show_bug.cgi?id=158819
256
257         Reviewed by David Kilzer.
258
259         * Misc/WebDownload.mm:
260         (-[WebDownloadInternal download:didCancelAuthenticationChallenge:]): Deleted.
261         * WebCoreSupport/WebFrameLoaderClient.h:
262         * WebCoreSupport/WebFrameLoaderClient.mm:
263         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.
264         * WebView/WebDelegateImplementationCaching.h:
265         * WebView/WebView.mm:
266         (-[WebView _cacheResourceLoadDelegateImplementations]):
267
268 2016-06-23  John Wilander  <wilander@apple.com>
269
270         Enable window.open() for existing versions of Secret Society app
271         https://bugs.webkit.org/show_bug.cgi?id=159049
272         <rdar://problem/26528349>
273
274         Reviewed by Andy Estes.
275
276         The Secret Society Hidden Mystery app has a broken version check treating iOS 10
277         as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
278         handler. We should allow the existing versions of the app to do this to not break
279         them.
280
281         * WebView/WebView.mm:
282         (shouldAllowWindowOpenWithoutUserGesture):
283             Added.
284         (shouldConvertInvalidURLsToBlank):
285             Changed hex number to constant DYLD_IOS_VERSION_10_0.
286
287 2016-06-22  Anders Carlsson  <andersca@apple.com>
288
289         Move the WebKitLegacy Apple Pay code to the open source repository
290         https://bugs.webkit.org/show_bug.cgi?id=159035
291
292         Reviewed by Tim Horton.
293
294         * WebCoreSupport/WebPaymentCoordinatorClient.h: Added.
295         * WebCoreSupport/WebPaymentCoordinatorClient.mm: Added.
296         (WebPaymentCoordinatorClient::WebPaymentCoordinatorClient):
297         (WebPaymentCoordinatorClient::~WebPaymentCoordinatorClient):
298         (WebPaymentCoordinatorClient::supportsVersion):
299         (WebPaymentCoordinatorClient::canMakePayments):
300         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
301         (WebPaymentCoordinatorClient::showPaymentUI):
302         (WebPaymentCoordinatorClient::completeMerchantValidation):
303         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
304         (WebPaymentCoordinatorClient::completeShippingContactSelection):
305         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
306         (WebPaymentCoordinatorClient::completePaymentSession):
307         (WebPaymentCoordinatorClient::abortPaymentSession):
308         (WebPaymentCoordinatorClient::mainFrameDestroyed):
309         * WebKitAdditions.mm: Removed.
310         * WebView/WebView.mm:
311         (-[WebView _commonInitializationWithFrameName:groupName:]):
312
313 2016-06-21  Anders Carlsson  <andersca@apple.com>
314
315         Fix build.
316
317         * Configurations/FeatureDefines.xcconfig:
318
319 2016-06-21  Anders Carlsson  <andersca@apple.com>
320
321         Begin moving the Apple Pay code to the open source repository
322         https://bugs.webkit.org/show_bug.cgi?id=158998
323
324         Reviewed by Tim Horton.
325
326         * Configurations/FeatureDefines.xcconfig:
327         Add ENABLE_APPLE_PAY.
328
329 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
330
331         Focus event dispatched in iframe causes parent document to scroll incorrectly
332         https://bugs.webkit.org/show_bug.cgi?id=158629
333         rdar://problem/26521616
334
335         Reviewed by Tim Horton.
336         
337         Pass SelectionRevealMode::Reveal in existing code.
338
339         * WebView/WebFrame.mm:
340         (-[WebFrame _scrollDOMRangeToVisible:]):
341         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
342         (-[WebFrame revealSelectionAtExtent:]):
343         * WebView/WebHTMLView.mm:
344         (-[WebHTMLView jumpToSelection:]):
345         (-[WebHTMLView centerSelectionInVisibleArea:]):
346
347 2016-06-21  Amir Alavi  <aalavi@apple.com>
348
349         Upstream WKHTTPCookiesForURL from WebKitSystemInterface to OpenSource
350         https://bugs.webkit.org/show_bug.cgi?id=158967
351
352         Reviewed by Brent Fulgham.
353
354         * WebCoreSupport/WebSystemInterface.mm:
355         (InitWebCoreSystemInterface): Deleted.
356
357 2016-06-20  Commit Queue  <commit-queue@webkit.org>
358
359         Unreviewed, rolling out r202243.
360         https://bugs.webkit.org/show_bug.cgi?id=158972
361
362         Broke Windows build and iOS tests (Requested by ap on
363         #webkit).
364
365         Reverted changeset:
366
367         "Focus event dispatched in iframe causes parent document to
368         scroll incorrectly"
369         https://bugs.webkit.org/show_bug.cgi?id=158629
370         http://trac.webkit.org/changeset/202243
371
372 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
373
374         Focus event dispatched in iframe causes parent document to scroll incorrectly
375         https://bugs.webkit.org/show_bug.cgi?id=158629
376         rdar://problem/26521616
377
378         Reviewed by Tim Horton.
379         
380         Pass SelectionRevealMode::Reveal in existing code.
381
382         * WebView/WebFrame.mm:
383         (-[WebFrame _scrollDOMRangeToVisible:]):
384         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
385         (-[WebFrame revealSelectionAtExtent:]):
386         * WebView/WebHTMLView.mm:
387         (-[WebHTMLView jumpToSelection:]):
388         (-[WebHTMLView centerSelectionInVisibleArea:]):
389
390 2016-06-20  Keith Rollin  <krollin@apple.com>
391
392         Remove RefPtr::release() and change calls sites to use WTFMove()
393         https://bugs.webkit.org/show_bug.cgi?id=158369
394
395         Reviewed by Chris Dumez.
396
397         RefPtr::release() releases its managed pointer awkwardly. It's more
398         direct and clearer to use WTFMove to transfer ownership of the managed
399         pointer.
400
401         As part of this cleanup, also change a lot of explicit data types to
402         'auto'.
403
404         * Plugins/Hosted/NetscapePluginHostManager.mm:
405         (WebKit::NetscapePluginHostManager::instantiatePlugin):
406         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
407         (WebKit::NetscapePluginInstanceProxy::create):
408         (WebKit::NetscapePluginInstanceProxy::loadRequest):
409         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
410         * WebCoreSupport/WebFrameLoaderClient.mm:
411         (-[WebFramePolicyListener receivedPolicyDecision:]):
412         * WebCoreSupport/WebSecurityOrigin.mm:
413         (-[WebSecurityOrigin initWithURL:]):
414         * WebView/WebArchive.mm:
415         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
416         (-[WebArchive initWithData:]):
417         * WebView/WebDataSource.mm:
418         (-[WebDataSource mainResource]):
419         * WebView/WebFrame.mm:
420         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
421
422 2016-06-15  Alexey Proskuryakov  <ap@apple.com>
423
424         +[WebHTMLRepresentation supportedMIMETypes] leaks
425         https://bugs.webkit.org/show_bug.cgi?id=158683
426
427         Reviewed by Darin Adler.
428
429         The problem occurred when chaining newArrayByConcatenatingArrays calls.
430
431         Also refactored the code to avoid returning NSMutableArrays disguised as NSArrays,
432         and removed __unsafe_unretained modifiers that were added in http://trac.webkit.org/r149453
433         for no apparent reason.
434
435         * WebView/WebHTMLRepresentation.mm:
436         (newArrayWithStrings):
437         (+[WebHTMLRepresentation supportedMIMETypes]):
438         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
439         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
440         (+[WebHTMLRepresentation supportedImageMIMETypes]):
441         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
442         (newArrayByConcatenatingArrays): Deleted.
443
444 2016-06-15  Dean Jackson  <dino@apple.com>
445
446         RTL <select> forms are misplaced
447         https://bugs.webkit.org/show_bug.cgi?id=158810
448         <rdar://problem/24847541>
449
450         Reviewed by Eric Carlson.
451
452         AppKit made a change in Sierra that causes popup menus
453         to snap to a different point when the system language is RTL.
454         We need to be more explicit about what directionality
455         we want, and override the location of the popup based
456         on the text direction.
457
458         I also made a small tweak to the fudge offsets we use
459         in order to make button text and menu text to be
460         more consistent.
461
462         Unfortunately since this is just about the location
463         of the popup menu, it's unable to be tested in our
464         current infrastructure.
465
466         * WebCoreSupport/PopupMenuMac.mm:
467         (PopupMenuMac::show):
468
469 2016-06-15  Chris Dumez  <cdumez@apple.com>
470
471         Drop some unnecessary header includes
472         https://bugs.webkit.org/show_bug.cgi?id=158788
473
474         Reviewed by Alexey Proskuryakov.
475
476         Drop some unnecessary header includes in headers to speed up build time.
477
478         * WebCoreSupport/WebFrameLoaderClient.mm:
479
480 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
481
482         Enabling Shadow DOM for all platforms
483         https://bugs.webkit.org/show_bug.cgi?id=158738
484
485         Reviewed by Ryosuke Niwa.
486
487         Removed Shadow DOM from options (enabled by default)
488
489         * Configurations/FeatureDefines.xcconfig:
490         * WebView/WebPreferences.mm:
491         * WebView/WebView.mm:
492
493 2016-06-15  Antti Koivisto  <antti@apple.com>
494
495         Vary:Cookie validation doesn't work in private browsing
496         https://bugs.webkit.org/show_bug.cgi?id=158616
497         <rdar://problem/26755067>
498
499         Reviewed by Andreas Kling.
500
501         * WebCoreSupport/WebFrameNetworkingContext.h:
502         (WebFrameNetworkingContext::create):
503         * WebCoreSupport/WebFrameNetworkingContext.mm:
504         (privateSession):
505         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
506
507             Expose the private browsing session.
508
509         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
510         * WebCoreSupport/WebPlatformStrategies.h:
511         * WebCoreSupport/WebPlatformStrategies.mm:
512         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
513
514             Implement SessionID version of the function.
515
516         (WebPlatformStrategies::getRawCookies):
517
518 2016-06-13  Alex Christensen  <achristensen@webkit.org>
519
520         Add WebSocketProvider stub
521         https://bugs.webkit.org/show_bug.cgi?id=158702
522
523         Reviewed by Brady Eidson.
524
525         * Misc/WebSocketProvider.h: Added.
526         * WebView/WebView.mm:
527         (-[WebView _commonInitializationWithFrameName:groupName:]):
528         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
529
530 2016-06-10  Alex Christensen  <achristensen@webkit.org>
531
532         Introduce WTF::UniqueRef
533         https://bugs.webkit.org/show_bug.cgi?id=158596
534
535         Reviewed by Brady Eidson.
536
537         * WebView/WebView.mm:
538         (-[WebView _commonInitializationWithFrameName:groupName:]):
539         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
540
541 2016-06-09  Alex Christensen  <achristensen@webkit.org>
542
543         Clean up EditorClient lifetime
544         https://bugs.webkit.org/show_bug.cgi?id=158588
545
546         Reviewed by Anders Carlsson.
547
548         * WebCoreSupport/WebEditorClient.h:
549         * WebCoreSupport/WebEditorClient.mm:
550         (WebEditorClient::WebEditorClient):
551         (WebEditorClient::pageDestroyed): Deleted.
552         * WebView/WebView.mm:
553         (-[WebView _commonInitializationWithFrameName:groupName:]):
554         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
555
556 2016-06-09  Andy Estes  <aestes@apple.com>
557
558         Define printing{Minimum,Maximum}ShrinkFactor in only one place
559         https://bugs.webkit.org/show_bug.cgi?id=158580
560
561         Reviewed by Tim Horton.
562
563         * WebView/WebHTMLView.mm: Initialized _WebHTMLViewPrintingMinimumShrinkFactor and
564         _WebHTMLViewPrintingMaximumShrinkFactor with PrintContext::minimumShrinkFactor() and
565         PrintContext::maximumShrinkFactor() instead of with duplicated float literals.
566
567 2016-06-09  Commit Queue  <commit-queue@webkit.org>
568
569         Unreviewed, rolling out r201810.
570         https://bugs.webkit.org/show_bug.cgi?id=158563
571
572         breaks build without ENABLE_WEB_ANIMATION (Requested by
573         mcatanzaro on #webkit).
574
575         Reverted changeset:
576
577         "[web-animations] Add Animatable, AnimationEffect,
578         KeyframeEffect and Animation interface"
579         https://bugs.webkit.org/show_bug.cgi?id=156096
580         http://trac.webkit.org/changeset/201810
581
582 2016-06-08  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
583
584         [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
585         https://bugs.webkit.org/show_bug.cgi?id=156096
586
587         Reviewed by Dean Jackson.
588
589         Adds:
590         - Setup interface for enabling runtime flag for Web animations through preferences.
591
592         * WebView/WebPreferenceKeysPrivate.h:
593         * WebView/WebPreferences.mm:
594         (+[WebPreferences initialize]):
595         (-[WebPreferences webAnimationsEnabled]):
596         (-[WebPreferences setWebAnimationsEnabled:]):
597         * WebView/WebPreferencesPrivate.h:
598         * WebView/WebView.mm:
599         (-[WebView _preferencesChanged:]):
600
601 2016-06-07  David Kilzer  <ddkilzer@apple.com>
602
603         [iOS WK1] Remove unused -_webkit_unescapedQueryValue and -_webkit_queryKeysAndValues NSString category methods
604         <https://webkit.org/b/158485>
605         <rdar://problem/16960445>
606
607         Reviewed by Dan Bernstein.
608
609         * Misc/WebNSURLExtras.h:
610         (-[NSString _webkit_unescapedQueryValue]): Deleted declaration.
611         (-[NSString _webkit_queryKeysAndValues]): Deleted declaration.
612         * Misc/WebNSURLExtras.mm:
613         (-[NSString _webkit_unescapedQueryValue]): Deleted.
614         (-[NSString _webkit_queryKeysAndValues]): Deleted.
615
616 2016-06-07  Alex Christensen  <achristensen@webkit.org>
617
618         Adopt [PDFView documentScrollView]
619         https://bugs.webkit.org/show_bug.cgi?id=158454
620         rdar://problem/25875390
621
622         Reviewed by Tim Horton.
623
624         * WebView/PDFViewSPI.h: Added.
625         * WebView/WebPDFView.mm:
626         (-[WebPDFView _clipViewForPDFDocumentView]):
627
628 2016-06-05  Anders Carlsson  <andersca@apple.com>
629
630         Attempt to fix plug-in hangs by adding back empty slots for the removed messages.
631
632         * Plugins/Hosted/WebKitPluginClient.defs:
633         * Plugins/Hosted/WebKitPluginHost.defs:
634
635 2016-06-04  Anders Carlsson  <andersca@apple.com>
636
637         Remove NPSPI that is no longer used
638         https://bugs.webkit.org/show_bug.cgi?id=158384
639
640         Reviewed by Sam Weinig.
641
642         * Configurations/WebKitLegacy.xcconfig:
643         * Plugins/Hosted/NetscapePluginHostProxy.mm:
644         (WKPCCheckIfAllowedToLoadURL): Deleted.
645         (WKPCCancelCheckIfAllowedToLoadURL): Deleted.
646         (WKPCResolveURL): Deleted.
647         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
648         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
649         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Deleted.
650         (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURL): Deleted.
651         (WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL): Deleted.
652         (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult): Deleted.
653         (WebKit::NetscapePluginInstanceProxy::resolveURL): Deleted.
654         * Plugins/Hosted/WebHostedNetscapePluginView.h:
655         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
656         (-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Deleted.
657         (-[WebHostedNetscapePluginView _containerCheckResult:contextInfo:]): Deleted.
658         * Plugins/Hosted/WebKitPluginClient.defs:
659         * Plugins/WebBaseNetscapePluginView.h:
660         * Plugins/WebBaseNetscapePluginView.mm:
661         (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]): Deleted.
662         * Plugins/WebNetscapeContainerCheckContextInfo.h: Removed.
663         * Plugins/WebNetscapeContainerCheckContextInfo.mm: Removed.
664         (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]): Deleted.
665         (-[WebNetscapeContainerCheckContextInfo checkRequestID]): Deleted.
666         (-[WebNetscapeContainerCheckContextInfo callback]): Deleted.
667         (-[WebNetscapeContainerCheckContextInfo context]): Deleted.
668         * Plugins/WebNetscapeContainerCheckPrivate.h: Removed.
669         * Plugins/WebNetscapeContainerCheckPrivate.mm: Removed.
670         (browserContainerCheckFuncs): Deleted.
671         * Plugins/WebNetscapePluginView.h:
672         * Plugins/WebNetscapePluginView.mm:
673         (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]): Deleted.
674         (-[WebNetscapePluginView _containerCheckResult:contextInfo:]): Deleted.
675         (-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Deleted.
676         (-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Deleted.
677         (-[WebNetscapePluginView fini]): Deleted.
678         (-[WebNetscapePluginView getVariable:value:]): Deleted.
679         (-[WebNetscapePluginView resolveURL:forTarget:]): Deleted.
680         * Plugins/npapi.mm:
681         (WKN_CheckIfAllowedToLoadURL): Deleted.
682         (WKN_CancelCheckIfAllowedToLoadURL): Deleted.
683         (WKN_ResolveURL): Deleted.
684
685 2016-06-04  Anders Carlsson  <andersca@apple.com>
686
687         Temporary build fix. (This function is going away).
688
689         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
690         (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult): Deleted.
691         * Plugins/Hosted/WebKitPluginHost.defs:
692
693 2016-06-03  Chris Dumez  <cdumez@apple.com>
694
695         Unreviewed, roll out r196633 as it broke PageCache on iOS for WebKit.org
696         <rdar://problem/26521101>
697
698         * WebCoreSupport/WebVisitedLinkStore.mm:
699         (WebVisitedLinkStore::removeAllVisitedLinks):
700         (WebVisitedLinkStore::removeVisitedLink):
701         (WebVisitedLinkStore::addVisitedLinkHash):
702
703 2016-06-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
704
705         Add WebIDL special operation support: serializer
706         https://bugs.webkit.org/show_bug.cgi?id=156293
707
708         Reviewed by Darin Adler.
709
710         * Plugins/Hosted/HostedNetscapePluginStream.mm:
711         (WebKit::HostedNetscapePluginStream::start):
712         * Plugins/WebNetscapePluginStream.mm:
713         (WebNetscapePluginStream::start):
714
715 2016-05-31  Darin Adler  <darin@apple.com>
716
717         Audit RenderObject casts and fix problems and style issues found
718         https://bugs.webkit.org/show_bug.cgi?id=158221
719
720         Reviewed by Chris Dumez.
721
722         * Misc/WebNSPasteboardExtras.mm:
723         (imageFromElement): Use auto and tighten the logic a bit.
724         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
725         Use auto and added a comment about this not using imageFromElement.
726
727         * Plugins/WebBaseNetscapePluginView.mm:
728         (-[WebBaseNetscapePluginView _windowClipRect]): Consistently cast to
729         RenderEmbeddedObject, which is the class used for renderers for plug-ins.
730         (-[WebBaseNetscapePluginView inFlatteningPaint]): Ditto.
731         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]): Ditto.
732         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]): Ditto.
733
734         * WebCoreSupport/WebFrameLoaderClient.mm:
735         (WebFrameLoaderClient::createPlugin): Changed code so it does a null check
736         rather than assuming the renderer is non-null.
737         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
738
739 2016-05-31  Yusuke Suzuki  <utatane.tea@gmail.com>
740
741         Unreviewed, roll out r201481, r201523: 0.3% regression in Octane code-load
742         https://bugs.webkit.org/show_bug.cgi?id=158249
743
744         * WebView/WebPreferencesPrivate.h:
745
746 2016-05-27  Chris Dumez  <cdumez@apple.com>
747
748         callOnMainThread() should not copy captured lambda variables
749         https://bugs.webkit.org/show_bug.cgi?id=158166
750
751         Reviewed by Brady Eidson.
752
753         callOnMainThread() should not copy captured lambda variables. This 
754         function is usually called cross-thread with a lambda and copying
755         the lambda (and its captured variables) can lead to thread-safety
756         issues.
757
758         This patch updates callOnMainThread() to take a NoncopyableFunction&&
759         in parameter instead of a std::function. The call sites of
760         callOnMainThread() have also been updated to use C++14's lambda
761         capture with initializer.
762
763         * Storage/WebDatabaseManagerClient.mm:
764         (DidModifyOriginData::dispatchToMainThread):
765         (DidModifyOriginData::DidModifyOriginData): Deleted.
766         * Storage/WebStorageTrackerClient.mm:
767         (WebStorageTrackerClient::dispatchDidModifyOrigin):
768
769 2016-05-27  Caitlin Potter  <caitp@igalia.com>
770
771         [JSC] implement async functions proposal
772         https://bugs.webkit.org/show_bug.cgi?id=156147
773
774         Reviewed by Yusuke Suzuki.
775
776         * WebView/WebPreferencesPrivate.h:
777
778 2016-05-26  Darin Adler  <darin@apple.com>
779
780         Media queries and platform screen modernization and streamlining
781         https://bugs.webkit.org/show_bug.cgi?id=158067
782
783         Reviewed by Alex Christensen.
784
785         * WebView/WebFrame.mm:
786         (-[WebFrame _dragSourceEndedAt:operation:]): Updated to use the new version of
787         globalPoint, which returns an NSPoint.
788
789 2016-05-26  Myles C. Maxfield  <mmaxfield@apple.com>
790
791         Build fix
792
793         Rubber stamped by Lucas Forschler.
794
795         * Configurations/DebugRelease.xcconfig:
796
797 2016-05-24  Beth Dakin  <bdakin@apple.com>
798
799         Candidates should work with input methods
800         https://bugs.webkit.org/show_bug.cgi?id=158042
801         -and corresponding-
802         rdar://problem/26205228
803
804         Reviewed by Tim Horton.
805
806         * WebView/WebHTMLView.mm:
807         * WebView/WebView.mm:
808         (-[WebView candidateList]):
809         * WebView/WebViewInternal.h:
810
811 2016-05-22  Brady Eidson  <beidson@apple.com>
812
813         Move to C++14.
814         https://bugs.webkit.org/show_bug.cgi?id=157948
815
816         Reviewed by Michael Catanzaro.
817
818         * Configurations/Base.xcconfig:
819
820 2016-05-20  Enrica Casucci  <enrica@apple.com>
821
822         Drag cannot start if no drag data or custom data is available in the Pasteboard.
823         https://bugs.webkit.org/show_bug.cgi?id=157911
824         rdar://problem/24577706
825
826         Reviewed by Tim Horton.
827
828         We need to make sure there is always one item in common between source and target
829         of the drag and drop operation.
830
831         * WebView/WebHTMLView.mm:
832         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
833
834 2016-05-19  Enrica Casucci  <enrica@apple.com>
835
836         Drag cannot start if no drag data is available in the Pasteboard.
837         https://bugs.webkit.org/show_bug.cgi?id=157911
838         rdar://problem/24577706
839
840         Reviewed by Tim Horton.
841
842         * WebView/WebHTMLView.mm:
843         (+[WebHTMLView _dummyPasteboardType]):
844         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
845         * WebView/WebHTMLViewPrivate.h:
846         * WebView/WebView.mm:
847         (-[WebView _registerDraggedTypes]):
848
849 2016-05-19  Jer Noble  <jer.noble@apple.com>
850
851         [IOS] Add setting to allow playback to continue inline after exiting fullscreen.
852         https://bugs.webkit.org/show_bug.cgi?id=157912
853
854         Reviewed by Eric Carlson.
855
856         Add a preference to control whether media should be allowed to continue playing inline when
857         exiting fullscreen.
858
859         * WebView/WebPreferenceKeysPrivate.h:
860         * WebView/WebPreferences.mm:
861         (+[WebPreferences initialize]):
862         (-[WebPreferences allowsInlineMediaPlaybackAfterFullscreen]):
863         (-[WebPreferences setAllowsInlineMediaPlaybackAfterFullscreen:]):
864         * WebView/WebPreferencesPrivate.h:
865         * WebView/WebView.mm:
866         (-[WebView _preferencesChanged:]):
867
868 2016-05-18  Brady Eidson  <beidson@apple.com>
869
870         Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
871         https://bugs.webkit.org/show_bug.cgi?id=157823
872
873         Reviewed by Alex Christensen.
874
875         * Storage/WebDatabaseManager.mm:
876         (-[WebDatabaseManager deleteAllIndexedDatabases]):
877         * Storage/WebDatabaseManagerPrivate.h:
878
879 2016-05-17  Beth Dakin  <bdakin@apple.com>
880
881         Make handleAcceptedCandidate a public function
882         https://bugs.webkit.org/show_bug.cgi?id=157763
883         -and corresponding-
884         rdar://problem/26206397
885
886         Reviewed by Tim Horton.
887
888         This patch re-names handleAcceptedCandidate to 
889         handleAcceptedCandidateWithSoftSpaces. The function now takes a 
890         WebCore::TextCheckingResult instead of an NSTextCheckingResult and it can be 
891         called from outside of WebEditorClient.
892
893         * WebCoreSupport/WebEditorClient.h:
894         * WebCoreSupport/WebEditorClient.mm:
895         (WebEditorClient::handleRequestedCandidates):
896         (WebEditorClient::handleAcceptedCandidateWithSoftSpaces):
897         (textCheckingResultFromNSTextCheckingResult): Deleted.
898         (WebEditorClient::handleAcceptedCandidate): Deleted.
899
900         Move showCandidates to WebViewPrivate so that it can be overridden by a test.
901         * WebView/WebViewInternal.h:
902         * WebView/WebViewPrivate.h:
903
904 2016-05-17  Dean Jackson  <dino@apple.com>
905
906         Remove ES6_GENERATORS flag
907         https://bugs.webkit.org/show_bug.cgi?id=157815
908         <rdar://problem/26332894>
909
910         Reviewed by Geoffrey Garen.
911
912         This flag isn't needed. Generators are enabled everywhere and
913         part of a stable specification.
914
915         * Configurations/FeatureDefines.xcconfig:
916
917 2016-05-17  Filip Pizlo  <fpizlo@apple.com>
918
919         WTF should know about Language
920         https://bugs.webkit.org/show_bug.cgi?id=157756
921
922         Reviewed by Geoffrey Garen.
923
924         Rewires a bunch of includes/imports.
925
926         * WebCoreSupport/PopupMenuMac.mm:
927         * WebCoreSupport/WebChromeClient.mm:
928         * WebCoreSupport/WebFrameLoaderClient.mm:
929         * WebCoreSupport/WebGeolocationClient.mm:
930         * WebCoreSupport/WebNotificationClient.mm:
931         * WebCoreSupport/WebPlatformStrategies.mm:
932         * WebCoreSupport/WebUserMediaClient.mm:
933         * WebCoreSupport/WebVisitedLinkStore.mm:
934         * WebView/WebHTMLView.mm:
935
936 2016-05-13  Enrica Casucci  <enrica@apple.com>
937
938         Remove unused initializer for WebEvent on iOS.
939         https://bugs.webkit.org/show_bug.cgi?id=157689
940
941         Reviewed by Anders Carlsson.
942
943         Removing use of characterSet property.
944
945         * WebView/WebHTMLView.mm:
946         (-[WebHTMLView _handleEditingKeyEvent:]):
947
948
949 2016-05-13  Commit Queue  <commit-queue@webkit.org>
950
951         Unreviewed, rolling out r200894.
952         https://bugs.webkit.org/show_bug.cgi?id=157695
953
954         This change broke the iOS build (Requested by ryanhaddad on
955         #webkit).
956
957         Reverted changeset:
958
959         "Remove unused initializer for WebEvent on iOS."
960         https://bugs.webkit.org/show_bug.cgi?id=157689
961         http://trac.webkit.org/changeset/200894
962
963 2016-05-13  Enrica Casucci  <enrica@apple.com>
964
965         Remove unused initializer for WebEvent on iOS.
966         https://bugs.webkit.org/show_bug.cgi?id=157689
967
968         Reviewed by Anders Carlsson.
969
970         Removing use of characterSet property.
971
972         * WebView/WebHTMLView.mm:
973         (-[WebHTMLView _handleEditingKeyEvent:]):
974
975 2016-05-13  Beth Dakin  <bdakin@apple.com>
976
977         Build fix.
978
979         * WebView/WebView.mm:
980
981 2016-05-13  Beth Dakin  <bdakin@apple.com>
982
983         Add dyldSPI.h for linked on or after checks, and add one for link preview
984         https://bugs.webkit.org/show_bug.cgi?id=157401
985         -and corresponding-
986         rdar://problem/26253396
987
988         Reviewed by Darin Adler.
989
990         This patch removes DynamicLinkerSPI.h and replaces it with 
991         wtf/spi/darwin/dyldSPI.h
992
993         * WebView/WebView.mm:
994
995 2016-05-13  Tina Liu  <iting_liu@apple.com>
996
997         Revert r199691.
998         https://bugs.webkit.org/show_bug.cgi?id=157645
999         <rdar://problem/26235373>
1000
1001         Reviewed by Darin Adler.
1002
1003         * WebCoreSupport/WebPlatformStrategies.h:
1004         * WebCoreSupport/WebPlatformStrategies.mm:
1005         (WebPlatformStrategies::setPrivateBrowsingPluginLoadClientPolicy): Deleted.
1006
1007 2016-05-12  Jiewen Tan  <jiewen_tan@apple.com>
1008
1009         Unreviewed build fix for r200799.
1010
1011         * WebView/WebView.mm:
1012
1013 2016-05-12  Jiewen Tan  <jiewen_tan@apple.com>
1014
1015         REGRESSION (r199313): ICBC app: text field In the webview is not tappable
1016         https://bugs.webkit.org/show_bug.cgi?id=157396
1017         <rdar://problem/25931513>
1018
1019         Reviewed by David Kilzer.
1020
1021         Add a quirk for WebKit1 apps.
1022
1023         * WebView/WebView.mm:
1024         (shouldConvertInvalidURLsToBlank):
1025         (-[WebView _preferencesChanged:]):
1026
1027 2016-05-12  Beth Dakin  <bdakin@apple.com>
1028
1029         WebKitAdditions needs to be notified before the WebView is dealloc'd
1030         https://bugs.webkit.org/show_bug.cgi?id=157633
1031         -and corresponding-
1032         rdar://problem/26134539
1033
1034         Reviewed by Anders Carlsson.
1035
1036         * WebView/WebView.mm:
1037         (-[WebView dealloc]):
1038         * WebView/WebViewInternal.h:
1039
1040 2016-05-12  Konstantin Tokarev  <annulen@yandex.ru>
1041
1042         Use reference instead of pointer in FrameLoaderClient::saveViewStateToItem.
1043         https://bugs.webkit.org/show_bug.cgi?id=157624
1044
1045         Reviewed by Darin Adler.
1046
1047         * WebCoreSupport/WebFrameLoaderClient.h:
1048         * WebCoreSupport/WebFrameLoaderClient.mm:
1049         (WebFrameLoaderClient::saveViewStateToItem):
1050         * WebView/WebFrame.mm:
1051         (-[WebFrame _saveViewState]):
1052
1053 2016-05-12  Csaba Osztrogonác  <ossy@webkit.org>
1054
1055         Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
1056         https://bugs.webkit.org/show_bug.cgi?id=157564
1057
1058         Reviewed by Darin Adler.
1059
1060         * Configurations/FeatureDefines.xcconfig:
1061
1062 2016-05-11  Chris Dumez  <cdumez@apple.com>
1063
1064         Update Node::appendChild() / replaceChild() / removeChild() / insertBefore() to take references instead of pointers
1065         https://bugs.webkit.org/show_bug.cgi?id=157556
1066
1067         Reviewed by Darin Adler.
1068
1069         * WebView/WebFrame.mm:
1070         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
1071
1072 2016-05-10  Shaw rich  <richshaw@126.com>
1073
1074         [OS X] Compatible with gnu sed grammar due to compile error with gnu sed
1075         https://bugs.webkit.org/show_bug.cgi?id=157526
1076
1077         Reviewed by Darin Adler.
1078
1079         * MigrateHeaders.make:
1080
1081 2016-05-10  Simon Fraser  <simon.fraser@apple.com>
1082
1083         [iOS WK1] text autosizing was on for all layout tests
1084         https://bugs.webkit.org/show_bug.cgi?id=157541
1085
1086         Reviewed by Tim Horton.
1087
1088         Make sure that we transfer the WK1 text autosizing preference to Settings.
1089
1090         * WebView/WebView.mm:
1091         (-[WebView _preferencesChanged:]):
1092
1093 2016-05-09  Tim Horton  <timothy_horton@apple.com>
1094
1095         [WebKit1] Invoking a link preview on a complex link (e.g. an image) results in an empty TextIndicator
1096         https://bugs.webkit.org/show_bug.cgi?id=157497
1097         <rdar://problem/25872773>
1098
1099         Reviewed by Anders Carlsson.
1100
1101         * WebView/WebImmediateActionController.mm:
1102         (-[WebImmediateActionController _defaultAnimationController]):
1103         r198578 fixed this for WebKit2, but forgot about WebKit1.
1104
1105 2016-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
1106
1107         [OS X] Migrate our Font classes entirely off of NSFont
1108         https://bugs.webkit.org/show_bug.cgi?id=157464
1109
1110         Reviewed by Darin Adler.
1111
1112         * WebCoreSupport/PopupMenuMac.mm:
1113         (PopupMenuMac::populate):
1114         (PopupMenuMac::show):
1115         * WebView/WebHTMLView.mm:
1116         (fontNameForDescription):
1117         (-[WebHTMLView _addToStyle:fontA:fontB:]):
1118
1119 2016-05-06  Joseph Pecoraro  <pecoraro@apple.com>
1120
1121         Rename HitTestRequest DisallowShadowContent to DisallowUserAgentShadowContent
1122         https://bugs.webkit.org/show_bug.cgi?id=157447
1123
1124         Reviewed by Ryosuke Niwa.
1125
1126         * WebView/WebFrame.mm:
1127         (-[WebFrame elementAtPoint:]):
1128         * WebView/WebHTMLView.mm:
1129         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
1130
1131 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
1132
1133         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
1134         https://bugs.webkit.org/show_bug.cgi?id=157432
1135         rdar://problem/16406720
1136
1137         Reviewed by Dean Jackson.
1138
1139         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
1140
1141         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
1142         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
1143         These two settings are shared with TEXT_AUTOSIZING.
1144
1145         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
1146
1147         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
1148         without changes.
1149
1150         An implication of this set of changes is that the way clients enable text autosizing
1151         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
1152         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
1153         on iPhone only, not iPad.
1154
1155         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
1156         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
1157
1158         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
1159         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
1160         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
1161
1162         * Configurations/FeatureDefines.xcconfig:
1163         * WebView/WebPreferenceKeysPrivate.h:
1164         * WebView/WebPreferences.mm:
1165         (+[WebPreferences initialize]):
1166         (-[WebPreferences _setTextAutosizingEnabled:]):
1167         (-[WebPreferences _textAutosizingEnabled]):
1168         * WebView/WebPreferencesPrivate.h:
1169
1170 2016-05-06  Dean Jackson  <dino@apple.com>
1171
1172         Regions, Shapes and Tracks don't need runtime features
1173         https://bugs.webkit.org/show_bug.cgi?id=157426
1174         <rdar://problem/26146262>
1175
1176         Reviewed by Simon Fraser.
1177
1178         The following RuntimeEnabledFeatures can be removed since
1179         we have no need to disable them (they are stable and have
1180         shipped for a while):
1181         - CSS Regions
1182         - CSS Shapes
1183         - Media tracks
1184
1185         * WebView/WebPreferenceKeysPrivate.h:
1186         * WebView/WebPreferences.mm:
1187         (+[WebPreferences initialize]): Deleted.
1188         (-[WebPreferences cssRegionsEnabled]): Deleted.
1189         (-[WebPreferences setCSSRegionsEnabled:]): Deleted.
1190         (-[WebPreferences cssCompositingEnabled]): Deleted.
1191         (-[WebPreferences setCSSCompositingEnabled:]): Deleted.
1192         * WebView/WebPreferencesPrivate.h:
1193         * WebView/WebView.mm:
1194         (-[WebView _preferencesChanged:]): Deleted.
1195
1196 2016-05-06  Daniel Bates  <dabates@apple.com>
1197
1198         Remove workaround for Apple Internal bots
1199         <rdar://problem/25989808>
1200
1201         Reverts the workaround added in r200211 as it is no longer needed.
1202
1203         * WebView/WebPDFView.h:
1204
1205 2016-05-02  Daniel Bates  <dabates@apple.com>
1206
1207         CSP: Add workaround for XtraMath
1208         https://bugs.webkit.org/show_bug.cgi?id=157252
1209
1210         Reviewed by Andy Estes.
1211
1212         * WebView/WebView.mm:
1213         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol): Allow * to match any protocol for
1214         applicable versions of app XtraMath.
1215
1216 2016-05-02  Daniel Bates  <dabates@apple.com>
1217
1218         DatabaseTracker::closeAllDatabases calls Database::close from the wrong thread
1219         https://bugs.webkit.org/show_bug.cgi?id=147672
1220         <rdar://problem/22357464>
1221
1222         Reviewed by Brady Eidson.
1223
1224         Update the background assertion expiration callback to call DatabaseTracker::closeAllDatabases()
1225         with CurrentQueryBehavior::Interrupt so that we abort a long running query and close the database
1226         immediately to avoid holding a locked file when the process is suspended.
1227
1228         * Storage/WebDatabaseManager.mm:
1229         (+[WebDatabaseManager startBackgroundTask]):
1230
1231 2016-04-29  Dean Jackson  <dino@apple.com>
1232
1233         RTL <select> popup menu is in the wrong location
1234         https://bugs.webkit.org/show_bug.cgi?id=157159
1235         <rdar://problem/25894451>
1236
1237         Reapply http://trac.webkit.org/changeset/200217
1238         but with changes that will allow it to build on Yosemite.
1239
1240         * WebCoreSupport/PopupMenuMac.mm:
1241         (PopupMenuMac::show):
1242
1243 2016-04-29  Commit Queue  <commit-queue@webkit.org>
1244
1245         Unreviewed, rolling out r200217.
1246         https://bugs.webkit.org/show_bug.cgi?id=157183
1247
1248         This change broke the Yosemite build. (Requested by ryanhaddad
1249         on #webkit).
1250
1251         Reverted changeset:
1252
1253         "RTL <select> popup menu is in the wrong location"
1254         https://bugs.webkit.org/show_bug.cgi?id=157159
1255         http://trac.webkit.org/changeset/200217
1256
1257 2016-04-28  Dean Jackson  <dino@apple.com>
1258
1259         RTL <select> popup menu is in the wrong location
1260         https://bugs.webkit.org/show_bug.cgi?id=157159
1261         <rdar://problem/25894451>
1262
1263         Reviewed by Simon Fraser.
1264
1265         Make sure both the NSPopupMenuCell and the NSPopupMenu take
1266         the text direction into account, and offset the position
1267         of the menu slightly if we're in RTL mode.
1268
1269         Unfortunately our test infrastructure is unable to exercise
1270         this because it runs without a window, and the popup menu
1271         is not captured in the screenshot.
1272
1273         * WebCoreSupport/PopupMenuMac.mm:
1274         (PopupMenuMac::show):
1275
1276 2016-04-28  Manuel Rego Casasnovas  <rego@igalia.com>
1277
1278         [css-grid] Add CSS Grid Layout runtime flag
1279         https://bugs.webkit.org/show_bug.cgi?id=157134
1280
1281         Reviewed by Simon Fraser.
1282
1283         Add CSS Grid Layout runtime flag based on preferences,
1284         enabled by default.
1285
1286         * WebView/WebPreferenceKeysPrivate.h:
1287         * WebView/WebPreferences.mm:
1288         (+[WebPreferences initialize]):
1289         (-[WebPreferences isCSSGridLayoutEnabled]):
1290         (-[WebPreferences setCSSGridLayoutEnabled:]):
1291         * WebView/WebPreferencesPrivate.h:
1292         * WebView/WebView.mm:
1293         (-[WebView _preferencesChanged:]):
1294
1295 2016-04-28  Daniel Bates  <dabates@apple.com>
1296
1297         Another fix for the Apple Internal OS X build
1298         <rdar://problem/25989808>
1299
1300         Reviewed by Anders Carlsson.
1301
1302         * WebView/WebPDFView.h:
1303
1304 2016-04-28  Daniel Bates  <dabates@apple.com>
1305
1306         Fix the Apple Internal OS X build
1307
1308         * WebView/WebPDFView.h: Import PDFKit for definition of protocol PDFViewDelegate.
1309         Forward declare protocol PDFViewDelegate as appropriate. Mark WebPDFView as implementing
1310         protocol PDFViewDelegate.
1311         * WebView/WebPDFView.mm: Move import of PDFKit from here to the header.
1312
1313 2016-04-27  Daniel Bates  <dabates@apple.com>
1314
1315         CSP: Add app-specific workaround for Ecobee and Quora
1316         https://bugs.webkit.org/show_bug.cgi?id=157005
1317         <rdar://problem/25560776>
1318
1319         Reviewed by Brent Fulgham.
1320
1321         * Misc/WebKitVersionChecks.h:
1322         * WebView/WebView.mm:
1323         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol): Added.
1324         (-[WebView _preferencesChanged:]): Enable setting allowContentSecurityPolicySourceStarToMatchAnyProtocol
1325         if applicable.
1326
1327 2016-04-26  Joseph Pecoraro  <pecoraro@apple.com>
1328
1329         Uncaught Exception: SecurityError: DOM Exception 18: An attempt was made to break through the security policy of the user agent.
1330         https://bugs.webkit.org/show_bug.cgi?id=156991
1331         <rdar://problem/25913475>
1332
1333         Reviewed by Timothy Hatcher.
1334
1335         * WebCoreSupport/WebInspectorClient.mm:
1336         (-[WebInspectorWindowController init]):
1337         Apply the same universal file access to WebKit1 Web Inspector views that
1338         we apply to WebKit2 views. Explicitly always allow access to storage
1339         for Web Inspector content just in case as we already allow universal
1340         file access.
1341
1342 2016-04-26  Beth Dakin  <bdakin@apple.com>
1343
1344         Check to make sure shouldRequestCandidates() before requesting candidates
1345         https://bugs.webkit.org/show_bug.cgi?id=157038
1346         -and corresponding-
1347         rdar://problem/25910418
1348
1349         Reviewed by Tim Horton.
1350
1351         This patch limits requesting and showing candidates to cases where 
1352         shouldRequestCandidates() is true. This patch also caches the sequence number 
1353         returned by [NSSpellChecker requestCandidatesForSelectedRange:] to make sure 
1354         it is equal to the sequence number sent to the callback handler so that we do 
1355         not show candidates for old requests.
1356
1357         * WebCoreSupport/WebEditorClient.h:
1358         * WebCoreSupport/WebEditorClient.mm:
1359         (WebEditorClient::requestCandidatesForSelection):
1360         (WebEditorClient::handleRequestedCandidates):
1361         * WebView/WebView.mm:
1362         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1363         (-[WebView shouldRequestCandidates]):
1364         * WebView/WebViewInternal.h:
1365
1366 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1367
1368         Remove the build flag for template elements
1369         https://bugs.webkit.org/show_bug.cgi?id=157022
1370
1371         Reviewed by Daniel Bates.
1372
1373         * Configurations/FeatureDefines.xcconfig:
1374
1375 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
1376
1377         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
1378         https://bugs.webkit.org/show_bug.cgi?id=156929
1379
1380         Reviewed by Darin Adler.
1381
1382         * Misc/WebKitNSStringExtras.mm:
1383         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Drawing
1384         a string with a null font shouldn't do anything.
1385         * Misc/WebStringTruncator.mm: We can't truncate a string if we don't have a font
1386         to use.
1387         (+[WebStringTruncator centerTruncateString:toWidth:]):
1388         (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
1389         (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
1390         (+[WebStringTruncator widthOfString:font:]):
1391
1392 2016-04-25  Beth Dakin  <bdakin@apple.com>
1393
1394         WebEditorClient should properly write to m_rangeForCandidates
1395         https://bugs.webkit.org/show_bug.cgi?id=157003
1396         -and corresponding-
1397         rdar://problem/25910418
1398
1399         Reviewed by Tim Horton.
1400
1401         Actually write to m_rangeForCandidates instead of declaring a local variable 
1402         of the same name. :-/
1403         * WebCoreSupport/WebEditorClient.mm:
1404         (WebEditorClient::requestCandidatesForSelection):
1405
1406 2016-04-23  Andy Estes  <aestes@apple.com>
1407
1408         Fix issues found by the clang static analyzer
1409         https://bugs.webkit.org/show_bug.cgi?id=156956
1410
1411         Reviewed by Alexey Proskuryakov.
1412
1413         * WebView/WebDeviceOrientationProviderMock.mm:
1414         (-[WebDeviceOrientationProviderMock dealloc]): [super dealloc] should be called last.
1415
1416 2016-04-21  Tim Horton  <timothy_horton@apple.com>
1417
1418         Fix the iOS build: WAKView may not respond to drawLayer:inContext:
1419         https://bugs.webkit.org/show_bug.cgi?id=156879
1420         <rdar://problem/25772661>
1421
1422         Reviewed by Beth Dakin.
1423
1424         * WebView/WebHTMLView.mm:
1425         WebHTMLView on iOS never uses drawLayer:inContext:, and WAKView
1426         doesn't implement it, so this would have thrown an exception
1427         if called, anyway. Fix the build with stricter CA protocols.
1428
1429 2016-04-21  Jer Noble  <jer.noble@apple.com>
1430
1431         [WK1] Add WebPlaybackSession support to WebKit
1432         https://bugs.webkit.org/show_bug.cgi?id=156854
1433
1434         Reviewed by Beth Dakin.
1435
1436         Add support for WebPlaybackSession and the ChromeClient methods setUpPlaybackControlsManager() and
1437         clearPlaybackControlsManager() to WebKit.
1438
1439         * WebCoreSupport/WebChromeClient.h:
1440         * WebCoreSupport/WebChromeClient.mm:
1441         (WebChromeClient::setUpPlaybackControlsManager):
1442         (WebChromeClient::clearPlaybackControlsManager):
1443         * WebView/WebView.mm:
1444         (-[WebView _hasActiveVideoForControlsInterface]):
1445         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1446         (-[WebView _clearPlaybackControlsManagerForMediaElement:]):
1447         * WebView/WebViewData.h:
1448         * WebView/WebViewData.mm:
1449         * WebView/WebViewInternal.h:
1450
1451 2016-04-21  Anders Carlsson  <andersca@apple.com>
1452
1453         Stop using ApplicationCacheStorage::singleton() in WebKitLegacy
1454         https://bugs.webkit.org/show_bug.cgi?id=156859
1455
1456         Reviewed by Tim Horton.
1457
1458         * WebCoreSupport/WebApplicationCache.mm:
1459         (+[WebApplicationCache initializeWithBundleIdentifier:]):
1460         Change this to just store the bundle identifier.
1461
1462         (applicationCacheBundleIdentifier):
1463         Helper function that returns the bundle identifier for the app cache.
1464
1465         (applicationCachePath):
1466         Return the application cache path.
1467
1468         (webApplicationCacheStorage):
1469         Create a new ApplicationCacheStorage object.
1470
1471         * WebView/WebView.mm:
1472         (-[WebView _commonInitializationWithFrameName:groupName:]):
1473         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1474         Set pageConfiguration.applicationCacheStorage to webApplicationCacheStorage().
1475
1476         (WebKitInitializeApplicationCachePathIfNecessary): Deleted.
1477
1478 2016-04-21  Beth Dakin  <bdakin@apple.com>
1479
1480         showCandidates() should take a range and the string should be the whole 
1481         paragraph
1482         https://bugs.webkit.org/show_bug.cgi?id=156813
1483         -and corresponding-
1484         rdar://problem/25760533
1485
1486         Reviewed by Tim Horton.
1487
1488         Cache the range and the paragraph since we compute them in 
1489         requestCandidatesForSelection, and then we can use them again in 
1490         handleRequestedCandidates.
1491         * WebCoreSupport/WebEditorClient.h:
1492         * WebCoreSupport/WebEditorClient.mm:
1493         (WebEditorClient::requestCandidatesForSelection):
1494         (WebEditorClient::handleRequestedCandidates):
1495         * WebView/WebView.mm:
1496         (-[WebView updateWebViewAdditions]):
1497         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1498         (-[WebView showCandidates:forString:inRect:view:completionHandler:]): Deleted.
1499         * WebView/WebViewInternal.h:
1500
1501 2016-04-21  Chris Dumez  <cdumez@apple.com>
1502
1503         Drop [UsePointersEvenForNonNullableObjectArguments] from Range
1504         https://bugs.webkit.org/show_bug.cgi?id=156805
1505
1506         Reviewed by Youenn Fablet.
1507
1508         * WebView/WebFrame.mm:
1509         (-[WebFrame _smartDeleteRangeForProposedRange:]):
1510
1511 2016-04-20  Brady Eidson  <beidson@apple.com>
1512
1513         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
1514         https://bugs.webkit.org/show_bug.cgi?id=156782
1515
1516         Reviewed by Alex Christensen.
1517
1518         * Configurations/FeatureDefines.xcconfig:
1519
1520 2016-04-18  Anders Carlsson  <andersca@apple.com>
1521
1522         Fix build with newer versions of clang.
1523         rdar://problem/25749769
1524
1525         * WebCoreSupport/WebContextMenuClient.mm:
1526         * WebView/WebHTMLView.mm:
1527         Forward declare some AppKit IPI.
1528
1529 2016-04-18  Tina Liu  <iting_liu@apple.com>
1530
1531         Overrode a virtual function of WebCore::PluginStrategy
1532         https://bugs.webkit.org/show_bug.cgi?id=156540
1533
1534         Reviewed by Anders Carlsson.
1535
1536         * WebCoreSupport/WebPlatformStrategies.h:
1537         * WebCoreSupport/WebPlatformStrategies.mm:
1538         (WebPlatformStrategies::setPrivateBrowsingPluginLoadClientPolicy):
1539
1540 2016-04-18  Brent Fulgham  <bfulgham@apple.com>
1541
1542         CSP: Remove stubs for dynamically-added favicons (via link rel="icon")
1543         https://bugs.webkit.org/show_bug.cgi?id=153151
1544         <rdar://problem/24383176>
1545
1546         Reviewed by Darin Adler.
1547
1548         Remove the unused dynamic favicon code and tests.
1549
1550         * WebCoreSupport/WebFrameLoaderClient.h:
1551         * WebCoreSupport/WebFrameLoaderClient.mm:
1552         (WebFrameLoaderClient::dispatchDidChangeIcons): Deleted.
1553
1554 2016-04-15  Darin Adler  <darin@apple.com>
1555
1556         Reduce use of Deprecated::ScriptXXX classes
1557         https://bugs.webkit.org/show_bug.cgi?id=156632
1558
1559         Reviewed by Alex Christensen.
1560
1561         * WebView/WebFrame.mm:
1562         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Use references instead
1563         of pointers.
1564         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Updated
1565         since return value is a JSValue.
1566         * WebView/WebView.mm:
1567         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
1568
1569 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
1570
1571         Make <a download> a runtime enabled option
1572         https://bugs.webkit.org/show_bug.cgi?id=156583
1573         <rdar://problem/25733449>
1574
1575         Reviewed by Alex Christensen.
1576
1577         Add a download attribute runtime flag based on preferences.
1578         Disable the download attribute by default.
1579
1580         * WebView/WebPreferenceKeysPrivate.h:
1581         * WebView/WebPreferences.mm:
1582         (+[WebPreferences initialize]):
1583         (-[WebPreferences setFetchAPIEnabled:]):
1584         (-[WebPreferences downloadAttributeEnabled]):
1585         (-[WebPreferences setDownloadAttributeEnabled:]):
1586         * WebView/WebPreferencesPrivate.h:
1587         * WebView/WebView.mm:
1588         (-[WebView _preferencesChanged]): Set the runtime flag properly
1589         based on the user preferences.
1590
1591 2016-04-09  Gavin Barraclough  <barraclough@apple.com>
1592
1593         WebKit should adopt journal_mode=wal for all SQLite databases.
1594         https://bugs.webkit.org/show_bug.cgi?id=133496
1595
1596         Reviewed by Darin Adler.
1597
1598         * Storage/WebDatabaseManagerPrivate.h:
1599             - renamed deleteAllDatabases -> deleteAllDatabasesImmediately.
1600
1601 2016-04-05  Oliver Hunt  <oliver@apple.com>
1602
1603         Remove compile time define for SEPARATED_HEAP
1604         https://bugs.webkit.org/show_bug.cgi?id=155508
1605
1606         Reviewed by Mark Lam.
1607
1608         * Configurations/FeatureDefines.xcconfig:
1609
1610 2016-04-08  Sam Weinig  <sam@webkit.org>
1611
1612         Remove support for custom target picker actions
1613         <rdar://problem/24987783>
1614         https://bugs.webkit.org/show_bug.cgi?id=156434
1615
1616         Reviewed by Eric Carlson.
1617
1618         This mostly entailed rolling out r197429 and r197569.
1619
1620         * WebCoreSupport/WebChromeClient.h:
1621         * WebCoreSupport/WebChromeClient.mm:
1622         (WebChromeClient::removePlaybackTargetPickerClient):
1623         (WebChromeClient::showPlaybackTargetPicker):
1624         * WebView/WebMediaPlaybackTargetPicker.h:
1625         * WebView/WebMediaPlaybackTargetPicker.mm:
1626         (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
1627         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
1628         (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
1629         (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget):
1630         (WebMediaPlaybackTargetPicker::invalidate):
1631         (WebMediaPlaybackTargetPicker::customPlaybackActionSelected): Deleted.
1632         * WebView/WebView.mm:
1633         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
1634         (-[WebView _playbackTargetPickerClientStateDidChange:state:]):
1635
1636 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
1637
1638         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
1639         https://bugs.webkit.org/show_bug.cgi?id=156384
1640
1641         Reviewed by Ryosuke Niwa.
1642
1643         * Configurations/FeatureDefines.xcconfig:
1644
1645 2016-04-07  Brian Burg  <bburg@apple.com>
1646
1647         CookieJar should support adding synthetic cookies for developer tools
1648         https://bugs.webkit.org/show_bug.cgi?id=156091
1649         <rdar://problem/25581340>
1650
1651         Reviewed by Timothy Hatcher.
1652
1653         * WebCoreSupport/WebPlatformStrategies.h:
1654         * WebCoreSupport/WebPlatformStrategies.mm:
1655         (WebPlatformStrategies::addCookie):
1656         Add new method override.
1657
1658 2016-04-06  Alex Christensen  <achristensen@webkit.org>
1659
1660         Fix CMake DumpRenderTree
1661         https://bugs.webkit.org/show_bug.cgi?id=156305
1662
1663         Reviewed by Daniel Bates.
1664
1665         * WebKitPrefix.h:
1666
1667 2016-04-05  Beth Dakin  <bdakin@apple.com>
1668
1669         Make requestCandidatesForSelection available on any EditorClient
1670         https://bugs.webkit.org/show_bug.cgi?id=156253
1671         -and corresponding-
1672         rdar://problem/24661147
1673
1674         Reviewed by Dean Jackson.
1675
1676         * WebCoreSupport/WebEditorClient.h:
1677
1678 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1679
1680         [Fetch API] Add a runtime flag to fetch API and related constructs
1681         https://bugs.webkit.org/show_bug.cgi?id=156113
1682  
1683         Reviewed by Alex Christensen.
1684
1685         Add a fetch API runtime flag based on preferences.
1686         Disable fetch API by default.
1687  
1688         * WebView/WebPreferenceKeysPrivate.h:
1689         * WebView/WebPreferences.mm:
1690         (+[WebPreferences initialize]):
1691         (-[WebPreferences setCustomElementsEnabled:]):
1692         (-[WebPreferences fetchAPIEnabled]):
1693         (-[WebPreferences setFetchAPIEnabled:]):
1694         * WebView/WebPreferencesPrivate.h:
1695         * WebView/WebView.mm:
1696         (-[WebView _preferencesChanged:]):
1697         (-[WebView preferencesIdentifier]):
1698         (-[WebView setUIDelegate:]):
1699
1700 2016-04-05  Antoine Quint  <graouts@apple.com>
1701
1702         [WebGL2] Turn the ENABLE_WEBGL2 flag on
1703         https://bugs.webkit.org/show_bug.cgi?id=156061
1704         <rdar://problem/25463193>
1705
1706         Reviewed by Alex Christensen.
1707
1708         * Configurations/FeatureDefines.xcconfig:
1709
1710 2016-04-05  Antoine Quint  <graouts@apple.com>
1711
1712         [WebGL2] Allow enabling WebGL2 with a runtime flag
1713         https://bugs.webkit.org/show_bug.cgi?id=156166
1714         <rdar://problem/25526929>
1715
1716         Set the WebGL2 runtime flag based on preferences, disabled by default.
1717
1718         Reviewed by Dean Jackson.
1719
1720         * WebView/WebPreferenceKeysPrivate.h:
1721         * WebView/WebPreferences.mm:
1722         (+[WebPreferences initialize]):
1723         (-[WebPreferences webGL2Enabled]):
1724         (-[WebPreferences setWebGL2Enabled:]):
1725         * WebView/WebPreferencesPrivate.h:
1726         * WebView/WebView.mm:
1727         (-[WebView _preferencesChanged:]):
1728
1729 2016-04-01  Alex Christensen  <achristensen@webkit.org>
1730
1731         Compile DumpRenderTree with CMake on Mac
1732         https://bugs.webkit.org/show_bug.cgi?id=156088
1733
1734         Reviewed by Brent Fulgham.
1735
1736         * Misc/WebKit.h:
1737         Alphabetize headers.
1738
1739 2016-03-31  Jeremy Jones  <jeremyj@apple.com>
1740
1741         mediaShouldUsePersistentCache() is redundant. Use Page::usesEphemeralSession() instead.
1742         https://bugs.webkit.org/show_bug.cgi?id=155924
1743
1744         Reviewed by Simon Fraser.
1745
1746         Remove mediaShouldUsePersistentCache machinery as it is redundant.
1747
1748         * WebCoreSupport/WebChromeClient.h:
1749         * WebCoreSupport/WebChromeClient.mm:
1750         (WebChromeClient::mediaShouldUsePersistentCache): Deleted.
1751
1752 2016-03-30  Ada Chan  <adachan@apple.com>
1753
1754         Add the new "toggle enhanced fullscreen" context menu item to the video context menu on supporting platforms.
1755         https://bugs.webkit.org/show_bug.cgi?id=156031
1756
1757         Reviewed by Eric Carlson.
1758
1759         * WebView/WebHTMLView.mm:
1760         (toAction):
1761         (toTag):
1762         * WebView/WebUIDelegatePrivate.h:
1763
1764 2016-03-24  Said Abou-Hallawa  <sabouhallawa@apple,com>
1765
1766         Change NativeImagePtr for CG to be RetainPtr<CGImageRef>
1767         https://bugs.webkit.org/show_bug.cgi?id=155412
1768
1769         Reviewed by Darin Adler.
1770
1771         * Misc/WebCache.mm:
1772         (+[WebCache addImageToCache:forURL:forFrame:]):
1773         WebCore::MemoryCache() is taking an rvalue NativeImagePtr. We need to create
1774         NativeImagePtr from the image raw pointer when calling this function.
1775
1776 2016-03-24  Tim Horton  <timothy_horton@apple.com>
1777
1778         Fix some new PDFKit-related warnings
1779         https://bugs.webkit.org/show_bug.cgi?id=155847
1780         <rdar://problem/25340312>
1781
1782         Reviewed by Anders Carlsson.
1783
1784         * WebView/WebPDFView.mm:
1785         (-[WebPDFView setViewState:]):
1786         * WebView/WebPreferences.mm:
1787         (-[WebPreferences PDFDisplayMode]):
1788         PDFDisplayMode is now a real enum.
1789
1790 2016-03-23  Anders Carlsson  <andersca@apple.com>
1791
1792         Crash when using KVO from within -[WebView initWithCoder:]
1793         https://bugs.webkit.org/show_bug.cgi?id=155816
1794         rdar://problem/17073265
1795
1796         Reviewed by Dan Bernstein.
1797
1798         Get rid of the observationInfo getter and setter. It's not clear why they were added (in 2003),
1799         and the methods on NSObject are good enough for us.
1800
1801         * WebView/WebView.mm:
1802         (-[WebView setObservationInfo:]): Deleted.
1803         (-[WebView observationInfo]): Deleted.
1804         * WebView/WebViewData.h:
1805
1806 2016-03-22  Beth Dakin  <bdakin@apple.com>
1807
1808         Advanced spell checking should be guarded behind 
1809         HAVE(ADVANCED_SPELL_CHECKING)
1810         https://bugs.webkit.org/show_bug.cgi?id=155738
1811
1812         Reviewed by Geoff Garen.
1813
1814         * WebCoreSupport/WebEditorClient.mm:
1815         (insertionPointFromCurrentSelection):
1816         (WebEditorClient::checkTextOfParagraph):
1817         (WebEditorClient::getGuessesForWord):
1818         (WebEditorClient::requestCandidatesForSelection):
1819         (WebEditorClient::handleRequestedCandidates):
1820         (WebEditorClient::requestCheckingOfString):
1821         * WebKitPrefix.h:
1822         * WebView/WebHTMLView.mm:
1823         (-[WebHTMLView insertText:]):
1824
1825 2016-03-20  Dan Bernstein  <mitz@apple.com>
1826
1827         [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
1828         https://bugs.webkit.org/show_bug.cgi?id=155707
1829         <rdar://problem/24980691>
1830
1831         Reviewed by Darin Adler.
1832
1833         * Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR based on the last
1834           component of MACOSX_DEPLOYMENT_TARGET.
1835         * Configurations/DebugRelease.xcconfig: For engineering builds, preserve the behavior of
1836           TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.
1837
1838 2016-03-20  Darin Adler  <darin@apple.com>
1839
1840         Disable Caches in Safari's Develop menu does not disable caches.
1841         https://bugs.webkit.org/show_bug.cgi?id=64483
1842
1843         Reviewed by Antti Koivisto.
1844
1845         Removed unneeded WebPreferences property; we don't need this for Legacy WebKit.
1846
1847         * WebView/WebPreferenceKeysPrivate.h: Removed
1848         WebKitResourceCachingDisabledPreferenceKey.
1849         * WebView/WebPreferences.mm:
1850         (-[WebPreferences isResourceCachingDisabled]): Deleted.
1851         (-[WebPreferences setResourceCachingDisabled:]): Deleted.
1852         * WebView/WebPreferencesPrivate.h: Removed resourceCachingDisabled property.
1853         * WebView/WebView.mm:
1854         (-[WebView _preferencesChanged:]): Removed code to update resourceCachingDisabled.
1855
1856 2016-03-20  Dan Bernstein  <mitz@apple.com>
1857
1858         Update build settings
1859
1860         Rubber-stamped by Andy Estes.
1861
1862         * Configurations/DebugRelease.xcconfig:
1863         * Configurations/FeatureDefines.xcconfig:
1864         * Configurations/Version.xcconfig:
1865
1866 2016-03-18  Darin Adler  <darin@apple.com>
1867
1868         Disable Caches in Safari's Develop menu does not disable caches.
1869         https://bugs.webkit.org/show_bug.cgi?id=64483
1870
1871         Reviewed by Antti Koivisto.
1872
1873         * WebView/WebPreferenceKeysPrivate.h: Added ResourceCachingDisabled.
1874         * WebView/WebPreferences.mm:
1875         (-[WebPreferences isResourceCachingDisabled]): Added.
1876         (-[WebPreferences setResourceCachingDisabled:]): Added.
1877         * WebView/WebPreferencesPrivate.h: Added resourceCachingDisabled.
1878         * WebView/WebView.mm:
1879         (-[WebView _preferencesChanged:]): Push resourceCachingDisabled into WebCore.
1880
1881 2016-03-17  Csaba Osztrogonác  <ossy@webkit.org>
1882
1883         [cmake][Mac] Unreviewed speculative buildfix after r198088. Just for fun.
1884
1885         * WebView/WebView.mm:
1886         (-[WebView _preferencesChanged:]):
1887
1888 2016-03-17  Andy Estes  <aestes@apple.com>
1889
1890         [Mac] Enable Content-Disposition: attachment sandbox
1891         https://bugs.webkit.org/show_bug.cgi?id=155578
1892         <rdar://problem/21886326>
1893
1894         Reviewed by Dan Bernstein.
1895
1896         Covered by the existing set of attachment sandbox tests, which have always been run on Mac.
1897
1898         * WebView/WebView.mm:
1899         (-[WebView _commonInitializationWithFrameName:groupName:]):
1900
1901 2016-03-16  Beth Dakin  <bdakin@apple.com>
1902
1903         Provide NSSpellChecker spellChecking methods with the current insertion point
1904         https://bugs.webkit.org/show_bug.cgi?id=155532
1905         -and corresponding-
1906         rdar://problem/24066952
1907
1908         Reviewed by Simon Fraser.
1909
1910         Extract the insertion point from the VisibleSelection that WebCore has 
1911         passed. 
1912         * WebCoreSupport/WebEditorClient.h:
1913         (WebEditorClient::getGuessesForWord):
1914         * WebCoreSupport/WebEditorClient.mm:
1915         (WebEditorClient::checkTextOfParagraph):
1916         (insertionPointFromCurrentSelection):
1917         (WebEditorClient::getGuessesForWord):
1918         (WebEditorClient::requestCheckingOfString):
1919
1920 2016-03-16  Chris Dumez  <cdumez@apple.com>
1921
1922         Unreviewed, rolling out r198235, r198240, r198241, and
1923         r198252.
1924
1925         Causing crashes on ARM
1926
1927         Reverted changesets:
1928
1929         "Remove compile time define for SEPARATED_HEAP"
1930         https://bugs.webkit.org/show_bug.cgi?id=155508
1931         http://trac.webkit.org/changeset/198235
1932
1933         "Gardening: build fix after r198235."
1934         http://trac.webkit.org/changeset/198240
1935
1936         "Build fix."
1937         http://trac.webkit.org/changeset/198241
1938
1939         "Rename performJITMemcpy to something more inline with our
1940         normal webkit function names"
1941         https://bugs.webkit.org/show_bug.cgi?id=155525
1942         http://trac.webkit.org/changeset/198252
1943
1944 2016-03-16  Jiewen Tan  <jiewen_tan@apple.com>
1945
1946         URL Parsing should signal failure for illegal IDN
1947         https://bugs.webkit.org/show_bug.cgi?id=154945
1948         <rdar://problem/8014795>
1949
1950         Reviewed by Brent Fulgham.
1951
1952         In this patch, we add new SPIs _webkit_URLWithUserTypedString, _webkit_decodeHostName and
1953         _webkit_encodeHostName which will return nil while dealing with illegal IDN.
1954
1955         Old SPIs _web_URLWithUserTypedString, _web_decodeHostName and _web_encodeHostName are marked
1956         deprecated as they ignore URL parsing failure.
1957
1958         * History/WebHistoryItem.mm:
1959         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1960         * Misc/WebKitErrors.m:
1961         (+[NSError _webKitErrorWithCode:failingURL:]):
1962         * Misc/WebNSFileManagerExtras.mm:
1963         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
1964         * Misc/WebNSPasteboardExtras.mm:
1965         (-[NSPasteboard _web_bestURL]):
1966         * Misc/WebNSURLExtras.h:
1967         * Misc/WebNSURLExtras.mm:
1968         (+[NSURL _web_URLWithUserTypedString:]):
1969         (+[NSURL _webkit_URLWithUserTypedString:relativeToURL:]):
1970         (+[NSURL _webkit_URLWithUserTypedString:]):
1971         (-[NSString _web_decodeHostName]):
1972         (-[NSString _web_encodeHostName]):
1973         (-[NSString _webkit_decodeHostName]):
1974         (-[NSString _webkit_encodeHostName]):
1975         * Panels/WebAuthenticationPanel.m:
1976         (-[WebAuthenticationPanel setUpForChallenge:]):
1977         * WebCoreSupport/WebEditorClient.mm:
1978         (WebEditorClient::canonicalizeURLString):
1979
1980 2016-03-15  Jer Noble  <jer.noble@apple.com>
1981
1982         [ios-sim debug] API test WebKit1.AudioSessionCategoryIOS timing out
1983         https://bugs.webkit.org/show_bug.cgi?id=155275
1984
1985         Reviewed by Alexey Proskuryakov.
1986
1987         The videoPlaybackRequiresUserGesture and audioPlaybackRequiresUserGesture should both defalut to
1988         NO, so that legacy clients of -[UIWebView setMediaPlaybackRequiresUserAction:] continue to work
1989         as expected.
1990
1991         * WebView/WebPreferences.mm:
1992         (+[WebPreferences initialize]):
1993
1994 2016-03-15  Oliver Hunt  <oliver@apple.com>
1995
1996         Remove compile time define for SEPARATED_HEAP
1997         https://bugs.webkit.org/show_bug.cgi?id=155508
1998
1999         Reviewed by Mark Lam.
2000
2001         Remove the feature define.
2002
2003         * Configurations/FeatureDefines.xcconfig:
2004
2005 2016-03-15  Chris Dumez  <cdumez@apple.com>
2006
2007         Unreviewed, rolling out r198203.
2008
2009         Favorites view is no longer loading on iOS
2010
2011         Reverted changeset:
2012
2013         "URL Parsing should signal failure for illegal IDN"
2014         https://bugs.webkit.org/show_bug.cgi?id=154945
2015         http://trac.webkit.org/changeset/198203
2016
2017 2016-03-15  Jiewen Tan  <jiewen_tan@apple.com>
2018
2019         URL Parsing should signal failure for illegal IDN
2020         https://bugs.webkit.org/show_bug.cgi?id=154945
2021         <rdar://problem/8014795>
2022
2023         Reviewed by Brent Fulgham.
2024
2025         In this patch, we add new SPIs _webkit_URLWithUserTypedString, _webkit_decodeHostName and
2026         _webkit_encodeHostName which will return nil while dealing with illegal IDN.
2027
2028         Old SPIs _web_URLWithUserTypedString, _web_decodeHostName and _web_encodeHostName are marked
2029         deprecated as they ignore URL parsing failure.
2030
2031         * History/WebHistoryItem.mm:
2032         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2033         * Misc/WebKitErrors.m:
2034         (+[NSError _webKitErrorWithCode:failingURL:]):
2035         * Misc/WebNSFileManagerExtras.mm:
2036         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2037         * Misc/WebNSPasteboardExtras.mm:
2038         (-[NSPasteboard _web_bestURL]):
2039         * Misc/WebNSURLExtras.h:
2040         * Misc/WebNSURLExtras.mm:
2041         (+[NSURL _web_URLWithUserTypedString:]):
2042         (+[NSURL _webkit_URLWithUserTypedString:relativeToURL:]):
2043         (+[NSURL _webkit_URLWithUserTypedString:]):
2044         (-[NSString _web_decodeHostName]):
2045         (-[NSString _web_encodeHostName]):
2046         (-[NSString _webkit_decodeHostName]):
2047         (-[NSString _webkit_encodeHostName]):
2048         * Panels/WebAuthenticationPanel.m:
2049         (-[WebAuthenticationPanel setUpForChallenge:]):
2050         * WebCoreSupport/WebEditorClient.mm:
2051         (WebEditorClient::canonicalizeURLString):
2052
2053 2016-03-14  Chris Dumez  <cdumez@apple.com>
2054
2055         Unreviewed, rolling out r197981.
2056
2057         Caused a massive PLT regression on Mac.
2058
2059         Reverted changeset:
2060
2061         "Font antialiasing (smoothing) changes when elements are
2062         rendered into compositing layers"
2063         https://bugs.webkit.org/show_bug.cgi?id=23364
2064         http://trac.webkit.org/changeset/197981
2065
2066 2016-03-14  Sam Weinig  <sam@webkit.org>
2067
2068         Add a baseURL parameter to _WKUserStyleSheet
2069         https://bugs.webkit.org/show_bug.cgi?id=155219
2070
2071         Reviewed by Tim Horton.
2072
2073         * WebView/WebView.mm:
2074         (-[WebView _commonInitializationWithFrameName:groupName:]):
2075         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2076         (-[WebView setGroupName:]):
2077         Update to account for the name change from UserContentController -> UserContentProvider.
2078
2079 2016-03-14  Joonghun Park  <jh718.park@samsung.com>
2080
2081         Purge PassRefPtr from ArrayBuffer, ArchiveResource, Pasteboard, LegacyWebArchive and DataObjectGtk
2082         https://bugs.webkit.org/show_bug.cgi?id=150497
2083
2084         Reviewed by Darin Adler.
2085
2086         * DOM/WebDOMOperations.mm:
2087         (-[DOMNode webArchive]):
2088         (-[DOMNode webArchiveByFilteringSubframes:]):
2089         * WebCoreSupport/WebPlatformStrategies.h:
2090         * WebCoreSupport/WebPlatformStrategies.mm:
2091         (WebPlatformStrategies::bufferForType):
2092         (WebPlatformStrategies::readBufferFromPasteboard):
2093         * WebView/WebArchive.mm:
2094         (-[WebArchive initWithData:]):
2095         * WebView/WebDataSource.mm:
2096         (-[WebDataSource webArchive]):
2097         (-[WebDataSource addSubresource:]):
2098         * WebView/WebResource.mm:
2099         (-[WebResource encodeWithCoder:]):
2100         (-[WebResource data]):
2101         (-[WebResource _stringValue]):
2102         (-[WebResource _initWithCoreResource:]): Deleted.
2103
2104 2016-03-14  Oliver Hunt  <oliver@apple.com>
2105
2106         Temporarily disable the separated heap.
2107         https://bugs.webkit.org/show_bug.cgi?id=155472
2108
2109         Reviewed by Geoffrey Garen.
2110
2111         Temporarily disable this.
2112
2113         * Configurations/FeatureDefines.xcconfig:
2114
2115 2016-03-14  Anders Carlsson  <andersca@apple.com>
2116
2117         Fix build.
2118
2119         Ignore nullability warnings, create an empty PDF selection.
2120
2121         * WebView/WebPDFView.mm:
2122         (-[WebPDFView centerSelectionInVisibleArea:]):
2123         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2124         (+[WebPDFView _PDFSelectionClass]):
2125         (-[WebPDFView _nextMatchFor:direction:caseSensitive:wrap:fromSelection:startInSelection:]):
2126
2127 2016-03-13  Joseph Pecoraro  <pecoraro@apple.com>
2128
2129         Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards
2130         https://bugs.webkit.org/show_bug.cgi?id=155417
2131
2132         Reviewed by Yusuke Suzuki.
2133
2134         * Configurations/FeatureDefines.xcconfig:
2135
2136 2016-03-13  Dean Jackson  <dino@apple.com>
2137
2138         <attachment> should be a runtime-enabled feature
2139         https://bugs.webkit.org/show_bug.cgi?id=155413
2140         <rdar://problem/25120753>
2141
2142         Reviewed by Sam Weinig and Anders Carlsson.
2143
2144         Add an internal setting on WebPreferences
2145         to enable the <attachment> element support.
2146
2147         * WebView/WebPreferenceKeysPrivate.h:
2148         * WebView/WebPreferences.mm:
2149         (+[WebPreferences initialize]):
2150         (-[WebPreferences attachmentElementEnabled]):
2151         (-[WebPreferences setAttachmentElementEnabled:]):
2152         * WebView/WebPreferencesPrivate.h:
2153         * WebView/WebView.mm:
2154         (-[WebView _preferencesChanged:]):
2155
2156 2016-03-12  Sam Weinig  <sam@webkit.org>
2157
2158         WebKit can easily crash below NetworkSession::dataTaskForIdentifier() with NSURLSession enabled
2159         <rdar://problem/25129946>
2160         https://bugs.webkit.org/show_bug.cgi?id=155401
2161
2162         Reviewed by Alex Christensen.
2163
2164         * WebCoreSupport/WebFrameNetworkingContext.mm:
2165         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2166         Pass a SessionID to NetworkStorageSession::createPrivateBrowsingSession().
2167
2168 2016-03-12  Myles C. Maxfield  <mmaxfield@apple.com>
2169
2170         Delete dead SVG Font code
2171         https://bugs.webkit.org/show_bug.cgi?id=154718
2172
2173         Reviewed by Antti Koivisto.
2174
2175         * Configurations/FeatureDefines.xcconfig:
2176
2177 2016-03-11  Yusuke Suzuki  <utatane.tea@gmail.com>
2178
2179         [ES6] Implement Reflect.set without receiver support
2180         https://bugs.webkit.org/show_bug.cgi?id=155024
2181
2182         Reviewed by Geoffrey Garen.
2183
2184         As the same to NPJSObject, we just propagate the returned value of NetscapePluginInstanceProxy::setProperty.
2185
2186         * Plugins/Hosted/ProxyInstance.h:
2187         * Plugins/Hosted/ProxyInstance.mm:
2188         (WebKit::ProxyField::setValueToInstance):
2189         (WebKit::ProxyInstance::setFieldValue):
2190
2191 2016-03-10  Jeremy Jones  <jeremyj@apple.com>
2192
2193         Set AVURLAssetUsesNoPersistentCacheKey on AVAsset to match caching policy.
2194         https://bugs.webkit.org/show_bug.cgi?id=155117
2195         rdar://problem/6802240
2196
2197         Reviewed by Simon Fraser.
2198
2199         Implement mediaShouldUsePersistentCache to disable media caching when NSURLCache is disabled.
2200
2201         * WebCoreSupport/WebChromeClient.h:
2202         * WebCoreSupport/WebChromeClient.mm:
2203         (WebChromeClient::mediaShouldUsePersistentCache): Added.
2204
2205 2016-03-10  Simon Fraser  <simon.fraser@apple.com>
2206
2207         Font antialiasing (smoothing) changes when elements are rendered into compositing layers
2208         https://bugs.webkit.org/show_bug.cgi?id=23364
2209
2210         Reviewed by Tim Horton.
2211
2212         Allow internal clients to turn off smoothed layer text, so that WebKitTestRunner
2213         can disable it.
2214
2215         * WebView/WebView.mm:
2216         (+[WebView _setSmoothedLayerTextEnabled:]):
2217         (+[WebView _smoothedLayerTextEnabled]):
2218         * WebView/WebViewPrivate.h:
2219
2220 2016-03-10  Jer Noble  <jer.noble@apple.com>
2221
2222         Add WebCore, WebKit, & WebKit2 preference/setting to enable Main Content heuristic.
2223         https://bugs.webkit.org/show_bug.cgi?id=155326
2224         <rdar://problem/25095408>
2225
2226         Reviewed by Beth Dakin.
2227
2228         Add SPI to get and set the new preference.
2229
2230         * WebView/WebPreferenceKeysPrivate.h:
2231         * WebView/WebPreferences.mm:
2232         (-[WebPreferences overrideUserGestureRequirementForMainContent]):
2233         (-[WebPreferences setOverrideUserGestureRequirementForMainContent:]):
2234         * WebView/WebPreferencesPrivate.h:
2235         * WebView/WebView.mm:
2236         (-[WebView _preferencesChanged:]):
2237
2238 2016-03-07  Jer Noble  <jer.noble@apple.com>
2239
2240         Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally
2241         https://bugs.webkit.org/show_bug.cgi?id=155141
2242
2243         Reviewed by Beth Dakin.
2244
2245         Deprecate WebPreferences.mediaPlaybackRequiresUserGesture property in favor of .videoPlaybackRequiresUserGesture.
2246
2247         * WebView/WebPreferenceKeysPrivate.h:
2248         * WebView/WebPreferences.mm:
2249         (+[WebPreferences initialize]):
2250         (-[WebPreferences mediaPlaybackRequiresUserGesture]):
2251         (-[WebPreferences setMediaPlaybackRequiresUserGesture:]):
2252         (-[WebPreferences videoPlaybackRequiresUserGesture]):
2253         (-[WebPreferences setVideoPlaybackRequiresUserGesture:]):
2254         * WebView/WebPreferencesPrivate.h:
2255         * WebView/WebView.mm:
2256         (-[WebView _preferencesChanged:]):
2257
2258 2016-03-10  Alexey Proskuryakov  <ap@apple.com>
2259
2260         Build fix for deprecated constant names.
2261
2262         * Carbon/CarbonWindowAdapter.mm:
2263         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2264         (-[CarbonWindowAdapter sendSuperEvent:]):
2265
2266 2016-03-10  Commit Queue  <commit-queue@webkit.org>
2267
2268         Unreviewed, rolling out r197943.
2269         https://bugs.webkit.org/show_bug.cgi?id=155317
2270
2271         This change broke Windows, WinCairo, GTK and EFL builds
2272         (Requested by ryanhaddad on #webkit).
2273
2274         Reverted changeset:
2275
2276         "Add a baseURL parameter to _WKUserStyleSheet"
2277         https://bugs.webkit.org/show_bug.cgi?id=155219
2278         http://trac.webkit.org/changeset/197943
2279
2280 2016-03-08  Sam Weinig  <sam@webkit.org>
2281
2282         Add a baseURL parameter to _WKUserStyleSheet
2283         https://bugs.webkit.org/show_bug.cgi?id=155219
2284
2285         Reviewed by Tim Horton.
2286
2287         * WebView/WebView.mm:
2288         (-[WebView _commonInitializationWithFrameName:groupName:]):
2289         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2290         (-[WebView setGroupName:]):
2291         Update to account for the name change from UserContentController -> UserContentProvider.
2292
2293 2016-02-22  Jer Noble  <jer.noble@apple.com>
2294
2295         Enable AVFoundationNSURLSessionEnabled by default
2296         https://bugs.webkit.org/show_bug.cgi?id=154469
2297
2298         Reviewed by Sam Weinig.
2299
2300         * WebView/WebPreferences.mm:
2301         (+[WebPreferences initialize]):
2302
2303 2016-03-09  Ryosuke Niwa  <rniwa@webkit.org>
2304
2305         Add runtime flags for shadow DOM and custom elements
2306         https://bugs.webkit.org/show_bug.cgi?id=155213
2307
2308         Reviewed by Dean Jackson.
2309
2310         Set the runtime flag based on preferences. Enable shadow DOM and disable custom elements by default.
2311
2312         * WebView/WebPreferenceKeysPrivate.h:
2313         * WebView/WebPreferences.mm:
2314         (+[WebPreferences initialize]):
2315         (-[WebPreferences shadowDOMEnabled]):
2316         (-[WebPreferences setShadowDOMEnabled:]):
2317         (-[WebPreferences customElementsEnabled]):
2318         (-[WebPreferences setCustomElementsEnabled:]):
2319         * WebView/WebPreferencesPrivate.h:
2320         * WebView/WebView.mm:
2321         (-[WebView _preferencesChanged:]):
2322
2323 2016-03-09  David Kilzer  <ddkilzer@apple.com>
2324
2325         REGRESSION (r197149): Missing availability checks when soft-linking DataDetectors.framework
2326         <http://webkit.org/b/155258>
2327
2328         Reviewed by Andy Estes.
2329
2330         * WebView/WebImmediateActionController.mm:
2331         (-[WebImmediateActionController _clearImmediateActionState]):
2332         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2333         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
2334         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
2335         - Add check that returns early if DataDetectors.framework is not
2336           available.
2337
2338 2016-03-08  Oliver Hunt  <oliver@apple.com>
2339
2340         Start moving to separated writable and executable mappings in the JIT
2341         https://bugs.webkit.org/show_bug.cgi?id=155178
2342
2343         Reviewed by Fil Pizlo.
2344
2345         Update feature defines.
2346
2347         * Configurations/FeatureDefines.xcconfig:
2348
2349 2016-03-08  Commit Queue  <commit-queue@webkit.org>
2350
2351         Unreviewed, rolling out r197793 and r197799.
2352         https://bugs.webkit.org/show_bug.cgi?id=155195
2353
2354         something weird happened while landing this and everything
2355         broke (Requested by olliej on #webkit).
2356
2357         Reverted changesets:
2358
2359         "Start moving to separated writable and executable mappings in
2360         the JIT"
2361         https://bugs.webkit.org/show_bug.cgi?id=155178
2362         http://trac.webkit.org/changeset/197793
2363
2364         "arm64 build fix after r197793."
2365         http://trac.webkit.org/changeset/197799
2366
2367 2016-03-08  Oliver Hunt  <oliver@apple.com>
2368
2369         Start moving to separated writable and executable mappings in the JIT
2370         https://bugs.webkit.org/show_bug.cgi?id=155178
2371
2372         Reviewed by Filip Pizlo.
2373
2374         Update feature defines.
2375
2376         * Configurations/FeatureDefines.xcconfig:
2377
2378 2016-03-08  Anders Carlsson  <andersca@apple.com>
2379
2380         Ignore deprecation warnings.
2381
2382         * Misc/WebNSEventExtras.m:
2383         (-[NSEvent _web_isKeyEvent:]):
2384         (-[NSEvent _web_isOptionTabKeyEvent]):
2385         * Misc/WebNSViewExtras.m:
2386         (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]):
2387         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2388         (WebKit::NetscapePluginHostProxy::beginModal):
2389         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2390         (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
2391         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2392         (-[WebHostedNetscapePluginView drawRect:]):
2393         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2394         (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
2395         * WebCoreSupport/PopupMenuMac.mm:
2396         (PopupMenuMac::populate):
2397         (PopupMenuMac::show):
2398         * WebCoreSupport/WebContextMenuClient.mm:
2399         (WebContextMenuClient::showContextMenu):
2400         * WebCoreSupport/WebFrameLoaderClient.mm:
2401         (WebFrameLoaderClient::actionDictionary):
2402         * WebCoreSupport/WebInspectorClient.mm:
2403         (WebInspectorFrontendClient::canAttach):
2404         (-[WebInspectorWindowController window]):
2405         * WebInspector/WebNodeHighlight.mm:
2406         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2407         * WebView/WebFrameView.mm:
2408         (-[WebFrameView keyDown:keyDown:]):
2409         * WebView/WebFullScreenController.mm:
2410         (-[WebFullScreenController init]):
2411         (createBackgroundFullscreenWindow):
2412         * WebView/WebHTMLView.mm:
2413         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
2414         (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
2415         (isQuickLookEvent):
2416         (-[WebHTMLView hitTest:]):
2417         (-[WebHTMLView _sendToolTipMouseExited]):
2418         (-[WebHTMLView _sendToolTipMouseEntered]):
2419         (mouseEventIsPartOfClickOrDrag):
2420         (-[WebHTMLView _updateMouseoverWithEvent:]):
2421         (-[WebHTMLView acceptsFirstResponder]):
2422         (-[WebHTMLView viewDidMoveToWindow]):
2423         (currentKeyboardEvent):
2424         (-[WebHTMLView _handleStyleKeyEquivalent:]):
2425         (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
2426         * WebView/WebPDFView.mm:
2427         (-[WebPDFView hitTest:]):
2428         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2429         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
2430         * WebView/WebTextCompletionController.mm:
2431         (-[WebTextCompletionController _buildUI]):
2432         (-[WebTextCompletionController _placePopupWindow:]):
2433         * WebView/WebView.mm:
2434         (-[WebView applicationFlags:]):
2435
2436 2016-03-07  Brent Fulgham  <bfulgham@apple.com>
2437
2438         Reduce startup and shutdown cost of resource load statistics
2439         https://bugs.webkit.org/show_bug.cgi?id=155120
2440         <rdar://problem/25010167>
2441
2442         Reviewed by Andy Estes.
2443
2444         Remove the Resource Load Statistics stuff from WK1, now that it is up and
2445         running in WK2.
2446
2447         * WebView/WebView.mm:
2448         (-[WebView _preferencesChanged:]): Remove call to read resource load
2449         statistics from disk.
2450         (+[WebView _applicationWillTerminate]): Remove call to write resource load
2451         statistics to disk.
2452
2453 2016-03-06  Andreas Kling  <akling@apple.com>
2454
2455         Reduce page cache capacity from 3 to 2.
2456         <https://webkit.org/b/155087>
2457
2458         Reviewed by Antti Koivisto.
2459
2460         Trim WebKit1 page cache capacities consistently with WebKit2.
2461
2462         * WebView/WebView.mm:
2463         (+[WebView _setCacheModel:]):
2464
2465 2016-03-05  Chris Dumez  <cdumez@apple.com>
2466
2467         Consolidate RuntimeApplicationChecks and RuntimeApplicationChecksIOS
2468         https://bugs.webkit.org/show_bug.cgi?id=155035
2469
2470         Reviewed by Darin Adler.
2471
2472         Update runtime application checks.
2473
2474         * Plugins/WebPluginController.mm:
2475         (initializeAudioSession):
2476         * WebCoreSupport/WebFrameLoaderClient.mm:
2477         * WebView/WebFrame.mm:
2478         (needsMicrosoftMessengerDOMDocumentWorkaround):
2479         * WebView/WebImmediateActionController.mm:
2480         (-[WebImmediateActionController _updateImmediateActionItem]):
2481         * WebView/WebView.mm:
2482         (WebKitInitializeApplicationCachePathIfNecessary):
2483         (shouldEnableLoadDeferring):
2484         (shouldRestrictWindowFocus):
2485         (needsOutlookQuirksScript):
2486         (shouldTransformsAffectOverflow):
2487         (shouldDispatchJavaScriptWindowOnErrorEvents):
2488         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2489         (-[WebView _commonInitializationWithFrameName:groupName:]):
2490         (+[WebView enableWebThread]):
2491         (+[WebView registerForMemoryNotifications]):
2492         (-[WebView _needsKeyboardEventDisambiguationQuirks]):
2493         (needsSelfRetainWhileLoadingQuirk):
2494         (-[WebView _needsPreHTML5ParserQuirks]):
2495
2496 2016-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2497
2498         [ES6] Support Reflect.construct
2499         https://bugs.webkit.org/show_bug.cgi?id=147330
2500
2501         Reviewed by Saam Barati.
2502
2503         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2504         (WebKit::NetscapePluginInstanceProxy::invoke):
2505         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2506         (WebKit::NetscapePluginInstanceProxy::construct):
2507
2508 2016-03-04  Brent Fulgham  <bfulgham@apple.com>
2509
2510         Unreviewed test fix for null global WebResourceLoadStatisticsStore.
2511
2512         * WebView/WebView.mm:
2513         (-[WebView _preferencesChanged:]):
2514         (+[WebView _applicationWillTerminate]):
2515
2516 2016-03-04  Brent Fulgham  <bfulgham@apple.com>
2517
2518         [WK2] Gather resource load statistics
2519         https://bugs.webkit.org/show_bug.cgi?id=154278
2520         <rdar://problem/24702892>
2521
2522         Reviewed by Andy Estes.
2523
2524         Switch to maintaining a global WebCore::ResourceLoadStatisticsStore in the WebKit process,
2525         and hand it off to the WebCore layer to use during data gathering. The ResourceLoadStatisticsStore
2526         is now responsible for reading/writing to disk, and tracking the collection of load data.
2527
2528         * WebView/WebView.mm:
2529         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Initialize singleton
2530         ResourceLoadStatisticsStore object for tracking state.
2531         (-[WebView _preferencesChanged:]): Revise for new singleton.
2532         (+[WebView _applicationWillTerminate]): Ditto.
2533
2534 2016-02-29  Ada Chan  <adachan@apple.com>
2535
2536         Adopt the new version of AVOutputDeviceMenuController's showMenuForRect method.
2537         https://bugs.webkit.org/show_bug.cgi?id=154823
2538
2539         Reviewed by Tim Horton.
2540
2541         * WebCoreSupport/WebChromeClient.h:
2542         * WebCoreSupport/WebChromeClient.mm:
2543         (WebChromeClient::showPlaybackTargetPicker):
2544         * WebView/WebMediaPlaybackTargetPicker.h:
2545         * WebView/WebMediaPlaybackTargetPicker.mm:
2546         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
2547         (WebMediaPlaybackTargetPicker::customPlaybackActionSelected):
2548         * WebView/WebView.mm:
2549         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
2550
2551 2016-03-01  Tim Horton  <timothy_horton@apple.com>
2552
2553         Expose MediaElement and VideoElement to the Objective-C DOM bindings
2554         https://bugs.webkit.org/show_bug.cgi?id=154830
2555
2556         Reviewed by Sam Weinig.
2557
2558         * MigrateHeaders.make:
2559
2560 2016-02-29  Simon Fraser  <simon.fraser@apple.com>
2561
2562         Remove the experimental feature of antialiased font dilation
2563         https://bugs.webkit.org/show_bug.cgi?id=154843
2564
2565         Reviewed by Zalan Bujtas.
2566
2567         Remove the "antialiased font dilation" code path, and related prefs.
2568
2569         * WebView/WebPreferenceKeysPrivate.h:
2570         * WebView/WebPreferences.mm:
2571         (+[WebPreferences initialize]): Deleted.
2572         (-[WebPreferences setAntialiasedFontDilationEnabled:]): Deleted.
2573         (-[WebPreferences antialiasedFontDilationEnabled]): Deleted.
2574         * WebView/WebPreferencesPrivate.h:
2575         * WebView/WebView.mm:
2576         (-[WebView _preferencesChanged:]): Deleted.
2577
2578 2016-02-26  Dan Bernstein  <mitz@apple.com>
2579
2580         Build fix for when WK_OVERRIDE_FRAMEWORKS_DIR contains spaces.
2581
2582         * Configurations/WebKitLegacy.xcconfig: Added quotes.
2583
2584 2016-02-25  Ada Chan  <adachan@apple.com>
2585
2586         Update the definition of ENABLE_VIDEO_PRESENTATION_MODE for Mac platform
2587         https://bugs.webkit.org/show_bug.cgi?id=154702
2588
2589         Reviewed by Dan Bernstein.
2590
2591         * Configurations/FeatureDefines.xcconfig:
2592
2593 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
2594
2595         Restrict information passed with navigation action which is triggered by untrusted event
2596         https://bugs.webkit.org/show_bug.cgi?id=154571
2597         <rdar://problem/15967937>
2598
2599         Reviewed by Andy Estes.
2600
2601         * WebCoreSupport/WebFrameLoaderClient.mm:
2602         (WebFrameLoaderClient::actionDictionary):
2603
2604 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
2605
2606         [MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin
2607         https://bugs.webkit.org/show_bug.cgi?id=153163
2608         <rdar://problem/24334526>
2609
2610         Reviewed by Tim Horton.
2611
2612         * WebCoreSupport/WebUserMediaClient.mm:
2613         (WebUserMediaClient::requestUserMediaAccess):
2614         (WebUserMediaClient::checkUserMediaPermission):
2615         (-[WebUserMediaPolicyCheckerListener allow]):
2616         (-[WebUserMediaPolicyCheckerListener deny]):
2617
2618 2016-02-24  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
2619
2620         [web-animations] Add AnimationTimeline, DocumentTimeline and add extensions to Document interface
2621         https://bugs.webkit.org/show_bug.cgi?id=151688
2622
2623         Reviewed by Dean Jackson.
2624
2625         Enables the WEB_ANIMATIONS compiler switch.
2626
2627         * Configurations/FeatureDefines.xcconfig:
2628
2629 2016-02-23  Dan Bernstein  <mitz@apple.com>
2630
2631         [Xcode] Linker errors display mangled names, but no longer should
2632         https://bugs.webkit.org/show_bug.cgi?id=154632
2633
2634         Reviewed by Sam Weinig.
2635
2636         * Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
2637
2638 2016-02-23  Gavin Barraclough  <barraclough@apple.com>
2639
2640         Remove HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define
2641         https://bugs.webkit.org/show_bug.cgi?id=112323
2642
2643         Reviewed by Chris Dumez.
2644
2645         This feature is controlled by a runtime switch, and defaults off.
2646
2647         * Configurations/FeatureDefines.xcconfig:
2648         * WebView/WebView.mm:
2649         (-[WebView _preferencesChanged:]):
2650
2651 2016-02-22  Commit Queue  <commit-queue@webkit.org>
2652
2653         Unreviewed, rolling out r196935.
2654         https://bugs.webkit.org/show_bug.cgi?id=154557
2655
2656         This change causes timeouts and crashes in LayoutTests
2657         (Requested by ryanhaddad on #webkit).
2658
2659         Reverted changeset:
2660
2661         "Enable AVFoundationNSURLSessionEnabled by default"
2662         https://bugs.webkit.org/show_bug.cgi?id=154469
2663         http://trac.webkit.org/changeset/196935
2664
2665 2016-02-22  Keith Rollin  <krollin@apple.com>
2666
2667         Add mechanism to disable memory pressure handling
2668         https://bugs.webkit.org/show_bug.cgi?id=154254
2669         <rdar://problem/24662616>
2670
2671         Reviewed by Chris Dumez.
2672
2673         Add a mechanism to disable WebKit's response to memory pressure
2674         triggers. This was asked for by another group for testing purposes.
2675
2676         In order to disable WebKit's memory pressure handling, execute the
2677         following from the command line:
2678
2679             defaults write com.apple.Safari WebKitSuppressMemoryPressureHandler -bool true
2680
2681         To revert to standard behavior, delete the key or set it to False.
2682
2683         This flag is used when a new sub-process is being spawned. The value
2684         is read and stored in an initialization parameter block, which is then
2685         sent to the new sub-process.
2686
2687         In actuality, only the UI, WebContent, and Network processes heed the
2688         flag. The Plugin process isn't instrumented to heed this flag for
2689         three reasons. First, the Plugin process installs its memory pressure
2690         handler in initializeProcess, not initializePluginProcess. This is
2691         contrary to when the other processes install their handlers, which is
2692         in initialize<PluginType>Process, not initializeProcess. So in order
2693         to accomodate the Plugin process, we'd need to modify
2694         ChildProcessInitializationParameters. Doing this is awkward at best,
2695         but also seems to be opposed to what's supposed to be done in
2696         initializeProcess and conveyed in
2697         ChildProcessInitializationParameters. And even if we did add a boolean
2698         to this structure and added support for conveying it through the XPC
2699         port, it would end up being a Plugin process-only boolean in a general
2700         parameter block, which seems asymmetric with the other processes.
2701         Second, there's no convenient Cocoa function called in the flow that
2702         spawns the Plugin process, meaning that there's no convenient place to
2703         call NSUserDefaults to get the flag's value. And third, the Plugin
2704         process doesn't elegantly respond to the memory pressure trigger
2705         anyway. It might terminate itself, but that's it. As for the Database
2706         process, it doesn't seem to support responding to memory pressure at
2707         all, so we don't send it a flag telling it to ignore it.
2708
2709         Internally, the memory pressure handler is suppressed by not calling
2710         MemoryPressureHandler::install() if the flag is set. In the case of
2711         the Network process, the flag is saved so that it can be checked later
2712         in other places that manually kick off the memory pressure handling
2713         procedure.
2714
2715         * WebView/WebView.mm:
2716         (-[WebView _commonInitializationWithFrameName:groupName:]):
2717         (WebInstallMemoryPressureHandler):
2718
2719 2016-02-22  Jer Noble  <jer.noble@apple.com>
2720
2721         Enable AVFoundationNSURLSessionEnabled by default
2722         https://bugs.webkit.org/show_bug.cgi?id=154469
2723
2724         Reviewed by Sam Weinig.
2725
2726         * WebView/WebPreferences.mm:
2727         (+[WebPreferences initialize]):
2728
2729 2016-02-15  Brent Fulgham  <bfulgham@apple.com>
2730
2731         [Mac] Gather some rudimentary statistics during resource load 
2732         https://bugs.webkit.org/show_bug.cgi?id=153575
2733         <rdar://problem/24075254>
2734
2735         Reviewed by Brady Eidson.
2736
2737         * Misc/WebKitNSStringExtras.h:
2738         * Misc/WebKitNSStringExtras.mm:
2739         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Added.
2740         * WebView/WebPreferenceKeysPrivate.h:
2741         * WebView/WebPreferences.mm:
2742         (+[WebPreferences initialize]):
2743         (-[WebPreferences resourceLoadStatisticsEnabled]): Added.
2744         (-[WebPreferences setResourceLoadStatisticsEnabled:]): Added.
2745         * WebView/WebPreferencesPrivate.h:
2746         * WebView/WebView.mm:
2747         (WebKitInitializeApplicationCachePathIfNecessary):
2748         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Added.
2749         (-[WebView _commonInitializationWithFrameName:groupName:]): Add call to new
2750         initialization method.
2751         (-[WebView _preferencesChanged:]): Track changes in the user's desire to
2752         monitor resource load statistics.
2753         (+[WebView _applicationWillTerminate]): Write statistics to disk (if preferences
2754         say to do so.)
2755
2756 2016-02-13  Mark Lam  <mark.lam@apple.com>
2757
2758         Add thread violation checks to WebView public APIs.
2759         https://bugs.webkit.org/show_bug.cgi?id=154183
2760
2761         Reviewed by Timothy Hatcher.
2762
2763         Re-landing r196527 with a newly added WebCoreThreadViolationCheckRoundThree().
2764         Previously was using WebCoreThreadViolationCheckRoundTwo().
2765
2766         * Misc/WebKitVersionChecks.h:
2767         * WebView/WebFrameView.mm:
2768         (-[WebFrameView initWithFrame:]):
2769         * WebView/WebView.mm:
2770         (-[WebView setCustomTextEncodingName:]):
2771         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2772         (-[WebView windowScriptObject]):
2773         (-[WebView setGroupName:]):
2774         (-[WebView setMainFrameURL:]):
2775         (-[WebView mainFrameTitle]):
2776         (-[WebView mainFrameIcon]):
2777         (-[WebView setDrawsBackground:]):
2778         (-[WebView setShouldUpdateWhileOffscreen:]):
2779
2780 2016-02-12  Commit Queue  <commit-queue@webkit.org>
2781
2782         Unreviewed, rolling out r196527.
2783         https://bugs.webkit.org/show_bug.cgi?id=154204
2784
2785         "Need to redo as WebCoreThreadViolationCheckRoundThree"
2786         (Requested by mlam on #webkit).
2787
2788         Reverted changeset:
2789
2790         "Add thread violation checks to WebView public APIs."
2791         https://bugs.webkit.org/show_bug.cgi?id=154183
2792         http://trac.webkit.org/changeset/196527
2793
2794 2016-02-12  Mark Lam  <mark.lam@apple.com>
2795
2796         Add thread violation checks to WebView public APIs.
2797         https://bugs.webkit.org/show_bug.cgi?id=154183
2798
2799         Reviewed by Geoffrey Garen.
2800
2801         This will help clients of the API detect the violations sooner rather than
2802         having to debug mysterious crashes / failures later.
2803
2804         To that end, I've added thread violation checks to the following functions
2805         because ...
2806
2807         * WebView/WebView.mm:
2808         (-[WebView setCustomTextEncodingName:]):
2809         - Uses the FrameLoader (which is for the main thread only).
2810
2811         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2812         - Invokes JavaScript (which is for the main thread only).
2813
2814         (-[WebView windowScriptObject]):
2815         - Invokes ScriptController::windowScriptObject() which requires the JSLock.
2816
2817         (-[WebView setGroupName:]):
2818         - Manipulates the PageGroup and Page (which is for the main thread only).
2819
2820         (-[WebView setMainFrameURL:]):
2821         - Uses the FrameLoader (which is for the main thread only).
2822
2823         (-[WebView mainFrameTitle]):
2824         - Uses the FrameLoader::documentLoader() (via [WebFrame _dataSource]) which
2825           is RefPtr, and therefore not safe for other threads to access.
2826
2827         (-[WebView mainFrameIcon]):
2828         - Uses the FrameLoader::documentLoader() (via [WebFrame _dataSource]) which
2829           is RefPtr, and therefore not safe for other threads to access.
2830         - Uses [WebIconDatabase sharedIconDatabase] which does a singleton
2831           instantiation but is not protected by a lock.
2832
2833         (-[WebView setDrawsBackground:]):
2834         - Potentially manipulates a RenderView (via FrameView::setBaseBackgroundColor,
2835           via [WebFrame _updateBackgroundAndUpdatesWhileOffscreen]), and RenderView
2836           is for main thread only use.
2837
2838         (-[WebView setShouldUpdateWhileOffscreen:]):
2839         - Uses [WebFrame _updateBackgroundAndUpdatesWhileOffscreen].  Hence, for the
2840           main thread only.
2841
2842 2016-02-12  Sukolsak Sakshuwong  <sukolsak@gmail.com>
2843
2844         Update ICU header files to version 52
2845         https://bugs.webkit.org/show_bug.cgi?id=154160
2846
2847         Reviewed by Alex Christensen.
2848
2849         Update ICU header files to version 52 to allow the use of newer APIs.
2850
2851         * icu/unicode/localpointer.h:
2852         * icu/unicode/platform.h:
2853         * icu/unicode/ptypes.h:
2854         * icu/unicode/putil.h:
2855         * icu/unicode/uchar.h:
2856         * icu/unicode/uconfig.h:
2857         * icu/unicode/uidna.h:
2858         * icu/unicode/uiter.h:
2859         * icu/unicode/umachine.h:
2860         * icu/unicode/unorm2.h:
2861         * icu/unicode/urename.h:
2862         * icu/unicode/uscript.h:
2863         * icu/unicode/ustring.h:
2864         * icu/unicode/utf.h:
2865         * icu/unicode/utf16.h:
2866         * icu/unicode/utf8.h:
2867         * icu/unicode/utf_old.h:
2868         * icu/unicode/utypes.h:
2869         * icu/unicode/uvernum.h:
2870         * icu/unicode/uversion.h:
2871
2872 2016-02-12  Beth Dakin  <bdakin@apple.com>
2873
2874         NSRangeIsRelativeTo should not have NS prefix
2875         https://bugs.webkit.org/show_bug.cgi?id=154174
2876
2877         Reviewed by Tim Horton.
2878
2879         NSRangeIsRelativeTo -> WebRangeIsRelativeTo
2880         * WebView/WebFrame.mm:
2881         (-[WebFrame _convertToDOMRange:]):
2882         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
2883         * WebView/WebFrameInternal.h:
2884         * WebView/WebHTMLView.mm:
2885         (-[WebHTMLView insertText:]):
2886
2887 2016-02-11  Beth Dakin  <bdakin@apple.com>
2888
2889         EditingRangeIsRelativeTo::Document and NSRangeIsRelativeTo::Document should 
2890         be called EditableRoot instead
2891         https://bugs.webkit.org/show_bug.cgi?id=154138
2892
2893         Reviewed by Alexey Proskuryakov.
2894
2895         EditableRoot is much more accurate than Document.
2896         * WebView/WebFrame.mm:
2897         (-[WebFrame _convertToDOMRange:]):
2898         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
2899         * WebView/WebFrameInternal.h:
2900         * WebView/WebHTMLView.mm:
2901         (-[WebHTMLView insertText:]):
2902
2903 2016-02-11  Beth Dakin  <bdakin@apple.com>
2904
2905         Soft spaces are often tracked in the wrong spot
2906         https://bugs.webkit.org/show_bug.cgi?id=154127
2907         -and corresponding-
2908         rdar://problem/24493140
2909
2910         Reviewed by Sam Weinig.
2911
2912         Soft spaces are in the wrong space now for two reasons. First of all, the 
2913         NSRange we get from the accepted candidate is relative to the paragraph 
2914         start, so without this patch, soft spaces are only ever right for the first 
2915         paragraph. Secondly, if focus changes for any reason other than text 
2916         insertion, soft spaces are also wrong because they need to be re-set.
2917
2918         New version of _convertToDOMRange takes a NSRangeIsRelativeTo so that it can 
2919         handle ranges relative to both the document and the paragraph. 
2920         * WebView/WebFrame.mm:
2921         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
2922         (-[WebFrame _convertNSRangeToDOMRange:]):
2923
2924         New enum NSRangeIsRelativeTo.
2925         * WebView/WebFrameInternal.h:
2926
2927         Re-set the softSpaceRange on selection changes so long as the WebCore::Editor 
2928         is not currently handling an accepted candidate.
2929         * WebView/WebHTMLView.mm:
2930         (-[WebHTMLView _selectionChanged]):
2931
2932         If needToRemoveSoftSpace is true, then the replacementRange is 
2933         relative to the paragraph.
2934         (-[WebHTMLView insertText:]):
2935
2936 2016-02-10  Mark Lam  <mark.lam@apple.com>
2937
2938         WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture: should assert that it is being called from the "main" thread.
2939         https://bugs.webkit.org/show_bug.cgi?id=154059
2940
2941         Reviewed by Geoffrey Garen.
2942
2943         This makes it so that misbehaving clients which call it (indirectly) from another
2944         thread (not the main thread) will fail faster.  Otherwise, we get potential
2945         memory corruption that results in strange crashes elsewhere later.
2946
2947         * WebView/WebFrame.mm:
2948         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2949
2950 2016-02-04  Jer Noble  <jer.noble@apple.com>
2951
2952         [Mac] Adopt NSURLSession properties in AVAssetResourceLoader
2953         https://bugs.webkit.org/show_bug.cgi?id=153873
2954
2955         Reviewed by Eric Carlson.
2956
2957         Add a WebKit preference to control the WebCore isAVFoundationNSURLSessionEnabled()
2958         setting.
2959
2960         * WebView/WebPreferenceKeysPrivate.h:
2961         * WebView/WebPreferences.mm:
2962         (+[WebPreferences initialize]):
2963         (-[WebPreferences setAVFoundationNSURLSessionEnabled:]):
2964         (-[WebPreferences isAVFoundationNSURLSessionEnabled]):
2965         * WebView/WebPreferencesPrivate.h:
2966         * WebView/WebView.mm:
2967         (-[WebView _preferencesChanged:]):
2968
2969 2016-02-09  Eric Carlson  <eric.carlson@apple.com>
2970
2971         checkValidity() sometimes asserts in WebUserMediaClient::pageDestroyed
2972         https://bugs.webkit.org/show_bug.cgi?id=154029
2973         <rdar://problem/24065022>
2974
2975         Reviewed by Alex Christensen.
2976
2977         * WebCoreSupport/WebUserMediaClient.mm:
2978         (WebUserMediaClient::pageDestroyed): Copy map keys to a vector and clear the map before
2979           enumerating the vector and canceling the requests. ASSERT that the map is not modified
2980           during cleanup. Clean up the permission check map.
2981         (WebUserMediaClient::requestUserMediaAccess): Add the request to the map before calling the
2982           UI delegate in case it works synchronously (as it does in DRT).
2983         (WebUserMediaClient::checkUserMediaPermission): Ditto.
2984         (WebUserMediaClient::cancelUserMediaPermissionCheck): White-space cleanup.
2985         (-[WebUserMediaPolicyListener allow]): Ditto.
2986
2987 2016-02-08  Anders Carlsson  <andersca@apple.com>
2988
2989         Crash when trying to chain to the old -[NSView setNeedsDisplayInRect:]
2990         https://bugs.webkit.org/show_bug.cgi?id=154001
2991         rdar://problem/24519975
2992
2993         Reviewed by Dan Bernstein.
2994
2995         If our replaced -[NSView setNeedsDisplayInRect:] is called before the old IMP has been initialized,
2996         we can end up trying to call a null pointer. 
2997         
2998         Fix this by using method_exchangeImplementations instead of method_setImplementation, since the former is done
2999         atomically.
3000
3001         * WebView/WebHTMLView.mm:
3002         (-[NSView _web_setNeedsDisplayInRect:]):
3003         (+[WebHTMLViewPrivate initialize]):
3004         (setNeedsDisplayInRect): Deleted.
3005
3006 2016-02-07  Dan Bernstein  <mitz@apple.com>
3007
3008         [Cocoa] Replace __has_include guards around inclusion of Apple-internal-SDK headers with USE(APPLE_INTERNAL_SDK)
3009         https://bugs.webkit.org/show_bug.cgi?id=153963
3010
3011         Reviewed by Sam Weinig.
3012
3013         * WebView/WebPDFView.mm:
3014
3015 2016-02-06  Darin Adler  <darin@apple.com>
3016
3017         Finish auditing call sites of upper() and lower(), eliminate many, and rename the functions
3018         https://bugs.webkit.org/show_bug.cgi?id=153905
3019
3020         Reviewed by Sam Weinig.
3021
3022         * Plugins/WebBasePluginPackage.mm:
3023         (-[WebBasePluginPackage getPluginInfoFromPLists]): Use modern for loops.
3024         (-[WebBasePluginPackage supportsExtension:]): Use convertToASCIILowercase for extension assert.
3025         Also use modern for loop.
3026         (-[WebBasePluginPackage supportsMIMEType:]): Ditto.
3027         (-[WebBasePluginPackage MIMETypeForExtension:]): Ditto.
3028
3029 2016-02-03  Jessie Berlin  <jberlin@webkit.org>
3030
3031         Build fix.
3032
3033         [NSEvent context] has always returned nil. Replace uses with nullptr.
3034
3035         * WebView/WebHTMLView.mm:
3036         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
3037         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3038         (-[WebHTMLView _updateMouseoverWithEvent:]):
3039         (-[WebHTMLView _autoscroll]):
3040         (-[WebHTMLView draggedImage:endedAt:operation:]):
3041
3042 2016-02-01  Dave Hyatt  <hyatt@apple.com>
3043
3044         Add a line grid pagination SPI to WebKit.
3045         https://bugs.webkit.org/show_bug.cgi?id=153757
3046         <rdar://problem/23041598>
3047
3048         Reviewed by Anders Carlsson.
3049
3050         * WebView/WebView.mm:
3051         (-[WebView _setPaginationLineGridEnabled:]):
3052         (-[WebView _paginationLineGridEnabled]):
3053         * WebView/WebViewPrivate.h:
3054
3055 2016-02-01  Joseph Pecoraro  <pecoraro@apple.com>
3056
3057         Web Inspector: High Level Memory Overview Instrument
3058         https://bugs.webkit.org/show_bug.cgi?id=153516
3059         <rdar://problem/24356378>
3060
3061         Reviewed by Brian Burg.
3062
3063         * Configurations/FeatureDefines.xcconfig:
3064
3065 2016-01-31  Darin Adler  <darin@apple.com>
3066
3067         Cut down on calls to String::lower; mostly replace with convertToASCIILowercase
3068         https://bugs.webkit.org/show_bug.cgi?id=153732
3069
3070         Reviewed by Dean Jackson.
3071
3072         * WebView/WebHTMLRepresentation.mm:
3073         (newArrayWithStrings): Updated to use HashSet<String, ASCIICaseInsensitiveHash>
3074         and also to use a modern for loop.
3075
3076 2016-01-31  Dan Bernstein  <mitz@apple.com>
3077
3078         [Cocoa] Remove __has_include guards around use of WebKitAdditions
3079         https://bugs.webkit.org/show_bug.cgi?id=153728
3080
3081         Reviewed by Andy Estes.
3082
3083         Guard WebKitAdditions includes with #if USE(APPLE_INTERNAL_SDK) rather than with __has_include.
3084
3085         * WebKitAdditions.mm:
3086         * WebView/WebView.mm:
3087         (-[WebView _commonInitializationWithFrameName:groupName:]):
3088         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3089
3090 2016-01-29  Ada Chan  <adachan@apple.com>
3091
3092         Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
3093         https://bugs.webkit.org/show_bug.cgi?id=153665
3094
3095         Reviewed by Dan Bernstein.
3096
3097         * Configurations/FeatureDefines.xcconfig:
3098
3099 2016-01-28  Darin Adler  <darin@apple.com>
3100
3101         Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
3102         https://bugs.webkit.org/show_bug.cgi?id=153411
3103
3104         Reviewed by Ryosuke Niwa.
3105
3106         * WebCoreSupport/WebFrameLoaderClient.mm:
3107         (parameterValue): Use equalIgnoringASCIICase. No behavior change because the
3108         only name we ever search for with this is "pluginspage".
3109
3110 2016-01-27  Enrica Casucci  <enrica@apple.com>
3111
3112         Cache results of data detection in the UI process when load completes.
3113         https://bugs.webkit.org/show_bug.cgi?id=153560
3114
3115         Reviewed by Tim Horton.
3116
3117         Adding empty implementation for WK1.
3118
3119         * WebCoreSupport/WebFrameLoaderClient.h:
3120         * WebCoreSupport/WebFrameLoaderClient.mm:
3121         (WebFrameLoaderClient::dispatchDidFinishDataDetection):
3122
3123 2016-01-27  Anders Carlsson  <andersca@apple.com>
3124
3125         Add WebKitAdditions extension points to WebCore, WebKit and WebKitLegacy
3126         https://bugs.webkit.org/show_bug.cgi?id=153550
3127
3128         Reviewed by Sam Weinig.
3129
3130         * Configurations/WebKitLegacy.xcconfig:
3131         Add WKA header search paths.
3132
3133         * WebKitAdditions.mm: Added.
3134         Add addition files.
3135
3136         * WebView/WebView.mm:
3137         (-[WebView _commonInitializationWithFrameName:groupName:]):
3138         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3139         Add extension points.
3140
3141 2016-01-27  Chris Dumez  <cdumez@apple.com>
3142
3143         window.atob() should ignore spaces in input
3144         https://bugs.webkit.org/show_bug.cgi?id=153522
3145         <rdar://problem/24357822>
3146
3147         Reviewed by Benjamin Poulain.
3148
3149         * WebCoreSupport/WebInspectorClient.mm:
3150         (WebInspectorFrontendClient::save):
3151
3152 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
3153
3154         Remove ENABLE_CURRENTSRC
3155         https://bugs.webkit.org/show_bug.cgi?id=153545
3156
3157         Reviewed by Simon Fraser.
3158
3159         * Configurations/FeatureDefines.xcconfig:
3160
3161 2016-01-25  Beth Dakin  <bdakin@apple.com>
3162
3163         Build fix.
3164
3165         * WebView/WebHTMLView.mm:
3166         (-[WebHTMLView initWithFrame:]):
3167         (-[WebHTMLView insertText:]):
3168
3169 2016-01-25  Beth Dakin  <bdakin@apple.com>
3170
3171         WK1: Handle soft spaces after accepted candidates
3172         https://bugs.webkit.org/show_bug.cgi?id=153442
3173         -and corresponding-
3174         rdar://problem/23958418
3175
3176         Reviewed by Tim Horton.
3177
3178         The space at the end of candidates is a soft space. If that space exists, 
3179         cache the range of the space in m_softSpaceRange.
3180         * WebCoreSupport/WebEditorClient.mm:
3181         (WebEditorClient::handleAcceptedCandidate):
3182
3183         New ivar in WebHTMLViewPrivate softSpaceRange keeps track to the NSRange of a 
3184         soft space if the last text that was inserted has a soft space at the end.
3185         * WebView/WebHTMLView.mm:
3186         (-[WebHTMLView initWithFrame:]):
3187         (-[WebHTMLView _setSoftSpaceRange:]):
3188
3189         When new text is inserted, find out if it is being inserted right after a 
3190         soft space. If it is, then [NSSpellChecker deletesAutospaceBeforeString] will 
3191         tell us if the space needs to be removed. If that is the case, then set the 
3192         replacementString to the soft space.
3193         (-[WebHTMLView insertText:]):
3194         * WebView/WebHTMLViewInternal.h:
3195
3196 2016-01-17  Ada Chan  <adachan@apple.com>
3197
3198         Add a mode parameter to MediaControllerInterface::supportsFullscreen() and ChromeClient::supportsVideoFullscreen().
3199         https://bugs.webkit.org/show_bug.cgi?id=153220
3200
3201         Reviewed by Eric Carlson.
3202
3203         * WebCoreSupport/WebChromeClient.h:
3204         * WebCoreSupport/WebChromeClient.mm:
3205         (WebChromeClient::supportsVideoFullscreen):
3206
3207 2016-01-22  Darin Adler  <darin@apple.com>
3208
3209         Reduce use of equalIgnoringCase to just ignore ASCII case
3210         https://bugs.webkit.org/show_bug.cgi?id=153266
3211
3212         Reviewed by Ryosuke Niwa.
3213
3214         * WebCoreSupport/WebFrameLoaderClient.mm:
3215         (WebFrameLoaderClient::createPlugin): Use equalLettersIgnoringASCIICase.
3216
3217 2016-01-21  Brent Fulgham  <bfulgham@apple.com>
3218
3219         [Mac] Tooltips do not honor some types of obscuring windows
3220         https://bugs.webkit.org/show_bug.cgi?id=153263
3221         <rdar://problem/21423972>
3222
3223         Reviewed by Simon Fraser.
3224
3225         * WebView/WebHTMLView.mm:
3226         (-[WebHTMLView _updateMouseoverWithEvent:]): When the WebView is not the key window, don't
3227         display tooltips.
3228
3229 2016-01-19  Ada Chan  <adachan@apple.com>
3230
3231         Make it possible to enable VIDEO_PRESENTATION_MODE on other Cocoa platforms.
3232         https://bugs.webkit.org/show_bug.cgi?id=153218
3233
3234         Reviewed by Eric Carlson.
3235
3236         * Configurations/FeatureDefines.xcconfig:
3237
3238 2016-01-19  Beth Dakin  <bdakin@apple.com>
3239
3240         32-bit build fix.
3241
3242         * WebView/WebView.mm:
3243         (-[WebView updateWebViewAdditions]):
3244         (-[WebView showCandidates:forString:inRect:view:completionHandler:]):
3245         * WebView/WebViewInternal.h:
3246
3247 2016-01-19  Beth Dakin  <bdakin@apple.com>
3248
3249         Move away from NSSpellChecker's showCandidates method
3250         https://bugs.webkit.org/show_bug.cgi?id=153254
3251         -and corresponding-
3252         rdar://problem/24216292
3253
3254         Reviewed by Tim Horton.
3255
3256         * WebCoreSupport/WebEditorClient.mm:
3257         (WebEditorClient::handleRequestedCandidates):
3258         * WebView/WebView.mm:
3259         (-[WebView updateWebViewAdditions]):
3260         (-[WebView showCandidates:forString:inRect:view:completionHandler:]):
3261         * WebView/WebViewInternal.h:
3262
3263 2016-01-19  Enrica Casucci  <enrica@apple.com>
3264
3265         Add support for DataDetectors in WK (iOS).
3266         https://bugs.webkit.org/show_bug.cgi?id=152989
3267         rdar://problem/22855960
3268
3269         Reviewed by Tim Horton.
3270
3271         Adding feature definition for data detection.
3272
3273         * Configurations/FeatureDefines.xcconfig:
3274
3275 2016-01-19  Commit Queue  <commit-queue@webkit.org>
3276
3277         Unreviewed, rolling out r195300.
3278         https://bugs.webkit.org/show_bug.cgi?id=153244
3279
3280         enrica wants more time to fix Windows (Requested by thorton on
3281         #webkit).
3282
3283         Reverted changeset:
3284
3285         "Add support for DataDetectors in WK (iOS)."
3286         https://bugs.webkit.org/show_bug.cgi?id=152989
3287         http://trac.webkit.org/changeset/195300
3288
3289 2016-01-19  Enrica Casucci  <enrica@apple.com>
3290
3291         Add support for DataDetectors in WK (iOS).
3292         https://bugs.webkit.org/show_bug.cgi?id=152989
3293         rdar://problem/22855960
3294
3295         Reviewed by Tim Horton.
3296
3297         Adding feature definition for data detection.
3298
3299         * Configurations/FeatureDefines.xcconfig:
3300
3301 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
3302
3303         Remove TextRun::allowsRoundingHacks()
3304         https://bugs.webkit.org/show_bug.cgi?id=153185
3305
3306         Reviewed by Simon Fraser.
3307
3308         * Misc/WebKitNSStringExtras.mm:
3309         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
3310         (-[NSString _web_widthWithFont:]): Deleted.
3311         * WebView/WebView.mm:
3312         (+[WebView _setAllowsRoundingHacks:]): Deleted.
3313         (+[WebView _allowsRoundingHacks]): Deleted.
3314         * WebView/WebViewPrivate.h:
3315
3316 2016-01-15  Tim Horton  <timothy_horton@apple.com>
3317
3318         Data detector yellow highlight location is vertically mirrored in WebKit1
3319         https://bugs.webkit.org/show_bug.cgi?id=152216
3320         <rdar://problem/23848003>
3321
3322         Reviewed by Beth Dakin.
3323
3324         * WebView/WebImmediateActionController.mm:
3325         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
3326         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
3327         These assignments have no effect because they're operating on a copy, because
3328         TextIndicator::data() does not return a reference... so remove them.
3329
3330         * WebView/WebView.mm:
3331         (-[WebView _setTextIndicator:withLifetime:]):
3332         Convert textBoundingRectInRootViewCoordinates to WebView coordinates before
3333         converting to Window coordinates from WebView coordinates so we get flipping right.
3334
3335         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3336         (-[WebView _showDictionaryLookupPopup:]):
3337         Ditto for these, except in the aforementioned conversion callback.
3338
3339 2016-01-14  Brady Eidson  <beidson@apple.com>
3340
3341         Modern IDB: Support opening and deleting SQLite databases on disk.
3342         https://bugs.webkit.org/show_bug.cgi?id=153084
3343
3344         Reviewed by Alex Christensen, Sam Weinig and Andy Estes (oh my!).
3345
3346         * Storage/WebDatabaseProvider.mm: Copied from Source/WebKit/Storage/WebDatabaseProvider.cpp.
3347         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
3348
3349 2016-01-14  Beth Dakin  <bdakin@apple.com>
3350
3351         WK1 and WK2 should share more candidate request code
3352         https://bugs.webkit.org/show_bug.cgi?id=153108
3353
3354         Reviewed by Simon Fraser.
3355
3356         requestCandidatesForSelection() does not need to be exposed as an 
3357         EditorClient function. WK1 can just call invoke this code from the existing 
3358         respondToChangedSelection EditorClient function, which is what WK2 does.
3359         * WebCoreSupport/WebEditorClient.h:
3360         * WebCoreSupport/WebEditorClient.mm:
3361         (WebEditorClient::respondToChangedSelection):
3362
3363         Cleanup — use some code that was moved to WebCore::Editor.
3364         (WebEditorClient::requestCandidatesForSelection):
3365         (WebEditorClient::handleRequestedCandidates):
3366         (textCheckingResultFromNSTextCheckingResult):
3367         (WebEditorClient::handleAcceptedCandidate):
3368         (candidateRangeForSelection): Deleted.
3369         (candidateWouldReplaceText): Deleted.
3370
3371 2016-01-13  Chris Dumez  <cdumez@apple.com>
3372
3373         Unreviewed, rolling out r194900.
3374
3375         Roll back in as this did not actually regress PLT
3376
3377         Reverted changeset:
3378
3379         "Unreviewed, rolling out r194826."
3380         https://bugs.webkit.org/show_bug.cgi?id=153020
3381         http://trac.webkit.org/changeset/194900
3382
3383 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
3384
3385         Add a build flag for custom element
3386         https://bugs.webkit.org/show_bug.cgi?id=153005
3387
3388         Reviewed by Alex Christensen.
3389
3390         * Configurations/FeatureDefines.xcconfig:
3391
3392 2016-01-12  Commit Queue  <commit-queue@webkit.org>
3393
3394         Unreviewed, rolling out r194826.
3395         https://bugs.webkit.org/show_bug.cgi?id=153020
3396
3397         Appears to have regressed PLT (Requested by kling on #webkit).
3398
3399         Reverted changeset:
3400
3401         "Use NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL
3402         cont'd"
3403         https://bugs.webkit.org/show_bug.cgi?id=152902
3404         http://trac.webkit.org/changeset/194826
3405
3406 2016-01-11  Anders Carlsson  <andersca@apple.com>
3407
3408         Get rid of CFMakeCollectable, it is a no-op
3409         https://bugs.webkit.org/show_bug.cgi?id=152988
3410
3411         Reviewed by Sam Weinig.
3412
3413         * Misc/WebNSDataExtras.m:
3414         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
3415         (-[NSData _webkit_parseRFC822HeaderFields]):
3416         * Plugins/WebPluginController.mm:
3417         (-[WebPluginController initWithDocumentView:]):
3418
3419 2016-01-10  Andreas Kling  <akling@apple.com>
3420
3421         Use NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL cont'd
3422         <https://webkit.org/b/152902>
3423
3424         Reviewed by Andy Estes.
3425
3426         Convert some more of the remaining clients to use NeverDestroyed.
3427
3428         * History/WebBackForwardList.mm:
3429         (backForwardLists):
3430         * History/WebHistoryItem.mm:
3431         (historyItemWrappers):
3432         * Misc/WebNSPasteboardExtras.mm:
3433         (+[NSPasteboard _web_writableTypesForURL]):
3434         (_writableTypesForImageWithoutArchive):
3435         (_writableTypesForImageWithArchive):
3436         * Plugins/Hosted/NetscapePluginHostManager.mm:
3437         (WebKit::NetscapePluginHostManager::singleton):
3438         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3439         (WebKit::pluginProxyMap):
3440         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3441         (WebKit::globalExceptionString):
3442         * Plugins/Hosted/ProxyInstance.mm:
3443         (WebKit::proxyClass):
3444         * Plugins/WebNetscapePluginStream.mm:
3445         (streams):
3446         * Storage/WebDatabaseManager.mm:
3447         (transactionBackgroundTaskIdentifierLock):
3448         * WebCoreSupport/WebUserMediaClient.mm:
3449         (userMediaCheckMap):
3450         * WebView/WebHTMLRepresentation.mm:
3451         (regExpForLabels):
3452         * WebView/WebView.mm:
3453         (aeDescFromJSValue):
3454
3455 2016-01-09  Dan Bernstein  <mitz@apple.com>
3456
3457         [Cocoa] Allow overriding the frameworks directory independently of using a staging install path
3458         https://bugs.webkit.org/show_bug.cgi?id=152926
3459
3460         Reviewed by Tim Horton.
3461
3462         Introduce a new build setting, WK_OVERRIDE_FRAMEWORKS_DIR. When not empty, it determines
3463         where the frameworks are installed. Setting USE_STAGING_INSTALL_PATH to YES sets
3464         WK_OVERRIDE_FRAMEWORKS_DIR to $(SYSTEM_LIBRARY_DIR)/StagedFrameworks/Safari.
3465
3466         Account for the possibility of WK_OVERRIDE_FRAMEWORKS_DIR containing spaces.
3467
3468         * Configurations/WebKitLegacy.xcconfig:
3469         - Replace STAGED_FRAMEWORKS_SEARCH_PATH in FRAMEWORK_SEARCH_PATHS with
3470           WK_OVERRIDE_FRAMEWORKS_DIR and add quotes to account for spaces.
3471         - Define WEBKIT_LEGACY_FRAMEWORKS_DIR, PRODUCTION_FRAMEWORKS_DIR, and
3472           WEBCORE_PRIVATE_HEADERS_DIR based on WK_OVERRIDE_FRAMEWORKS_DIR.
3473
3474         * MigrateHeaders.make:
3475           Use a symlink under BUILT_PRODUCTS_DIR to the WebCore Private Headers. Use a
3476           BUILT_PRODUCTS_DIR-based path to the framework instead of a TARGET_BUILD_DIR-based one in
3477           order to avoid spaces.
3478         * migrate-headers.sh:
3479           Make the symlink to WEBCORE_PRIVATE_HEADERS_DIR that the makefile now uses.
3480
3481 2016-01-07  Tim Horton  <timothy_horton@apple.com>
3482
3483         Can't play inline video in a stock WK1 WebView on Mac
3484         https://bugs.webkit.org/show_bug.cgi?id=152860
3485
3486         Rubber-stamped by Jer Noble.
3487
3488         * WebView/WebPreferences.mm:
3489         (+[WebPreferences initialize]):
3490         The default for this preference is supposed to be NO on Mac. It is in
3491         Settings.in, and in WebKit2, but this one place got it wrong.
3492
3493 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
3494
3495         Add a setting and preferences to enable display-list drawing. Does nothing yet.
3496         https://bugs.webkit.org/show_bug.cgi?id=152807
3497
3498         Reviewed by Zalan Bujtas.
3499         
3500         WK1 pref for display-list drawing, defaults to off.
3501
3502         * WebView/WebPreferenceKeysPrivate.h:
3503         * WebView/WebPreferences.mm:
3504         (+[WebPreferences initialize]):
3505         (-[WebPreferences displayListDrawingEnabled]):
3506         (-[WebPreferences setDisplayListDrawingEnabled:]):
3507         * WebView/WebPreferencesPrivate.h:
3508         * WebView/WebView.mm:
3509         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3510         (-[WebView _preferencesChanged:]):
3511
3512 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
3513
3514         [iOS] Revert overflow:hidden on the body affecting viewport scale (r186786)
3515         https://bugs.webkit.org/show_bug.cgi?id=152803
3516         rdar://problem/22242515
3517
3518         Reviewed by Tim Horton.
3519
3520         * WebView/WebView.mm:
3521         (-[WebView _contentsSizeRespectingOverflow]): Keep this function which is used
3522         by UIKit, but change the implementation to just return the document size.
3523
3524 2016-01-04  Tim Horton  <timothy_horton@apple.com>
3525
3526         Turn on gesture events when building for Yosemite
3527         https://bugs.webkit.org/show_bug.cgi?id=152704
3528         rdar://problem/24042472
3529
3530         Reviewed by Anders Carlsson.
3531
3532         * Configurations/FeatureDefines.xcconfig:
3533
3534 2015-12-31  Andy Estes  <aestes@apple.com>
3535
3536         Replace WTF::move with WTFMove
3537         https://bugs.webkit.org/show_bug.cgi?id=152601
3538
3539         Reviewed by Brady Eidson.
3540
3541         * History/WebHistoryItem.mm:
3542         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3543         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3544         (WebKit::HostedNetscapePluginStream::willSendRequest):
3545         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3546         (WebKit::NetscapePluginInstanceProxy::setCurrentReply):
3547         * Plugins/WebNetscapePluginStream.mm:
3548         (WebNetscapePluginStream::willSendRequest):
3549         * Plugins/WebNetscapePluginView.mm:
3550         (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
3551         * WebCoreSupport/WebContextMenuClient.mm:
3552         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3553         * WebCoreSupport/WebFrameLoaderClient.mm:
3554         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3555         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3556         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3557         (WebFrameLoaderClient::dispatchWillSubmitForm):
3558         (WebFrameLoaderClient::createDocumentLoader):
3559         * WebCoreSupport/WebInspectorClient.mm:
3560         (WebInspectorFrontendClient::WebInspectorFrontendClient):
3561         * WebView/WebArchive.mm:
3562         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
3563         * WebView/WebFrame.mm:
3564         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
3565         * WebView/WebHTMLView.mm:
3566         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3567         * WebView/WebMediaPlaybackTargetPicker.mm:
3568         (WebMediaPlaybackTargetPicker::setPlaybackTarget):
3569         * WebView/WebView.mm:
3570         (-[WebView _loadBackForwardListFromOtherView:]):
3571         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
3572         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
3573
3574 2016-01-01  Simon Fraser  <simon.fraser@apple.com>
3575
3576         Fix the iOS and EFL builds, after an over-eager commit-queue commit.