Remove support for legacy Notifications
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-05-04  Sam Weinig  <sam@webkit.org>
2
3         Remove support for legacy Notifications
4         https://bugs.webkit.org/show_bug.cgi?id=171487
5
6         Reviewed by Jon Lee.
7
8         * Configurations/FeatureDefines.xcconfig:
9         * WebCoreSupport/WebNotificationClient.h:
10         * WebCoreSupport/WebNotificationClient.mm:
11         * WebView/WebNotification.mm:
12         * WebView/WebNotificationInternal.h:
13         * WebView/WebView.mm:
14         (-[WebView _commonInitializationWithFrameName:groupName:]):
15         (-[WebView _notificationIDForTesting:]):
16         Remove legacy notification specific code.
17
18 2017-05-03  Joseph Pecoraro  <pecoraro@apple.com>
19
20         [Cocoa] Stop exporting symbols for ivars that were made private
21         https://bugs.webkit.org/show_bug.cgi?id=171631
22
23         Reviewed by Dan Bernstein.
24
25         * WebKit.exp:
26
27 2017-05-01  Chris Dumez  <cdumez@apple.com>
28
29         Remove some usage of PassRefPtr in editing code
30         https://bugs.webkit.org/show_bug.cgi?id=171490
31
32         Reviewed by Darin Adler.
33
34         * WebView/WebFrame.mm:
35         (-[WebFrame dictationResultMetadataForRange:]):
36         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
37
38 2017-05-01  Beth Dakin  <bdakin@apple.com>
39
40         On-screen panel for candidate bar is in the wrong place when the caret is at the 
41         start of a paragraph
42         https://bugs.webkit.org/show_bug.cgi?id=171453
43         -and corresponding-
44         rdar://problem/29779764
45
46         Reviewed by Tim Horton.
47
48         This bug only happens when the caret is at the beginning of the paragraph, and it 
49         is because Range::absoluteTextQuads() returns no quads in this case. I think it 
50         might be correct that absoluteTextQuads() returns no quads in this case, so this 
51         patch fixes the bug at the call site by using absoluteCaretBounds() in this case.
52
53         * WebCoreSupport/WebEditorClient.mm:
54         (WebEditorClient::handleRequestedCandidates):
55
56 2017-04-30  Dan Bernstein  <mitz@apple.com>
57
58         [Cocoa] Replaces uses of [get…() alloc] with alloc…Instance()
59         https://bugs.webkit.org/show_bug.cgi?id=171485
60
61         Reviewed by Geoffrey Garen.
62
63         * WebView/WebView.mm:
64         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
65         (-[WebUITextIndicatorData initWithImage:scale:]):
66
67 2017-04-28  Youenn Fablet  <youenn@apple.com>
68
69         Adding a runtime flag specific to MediaDevices
70         https://bugs.webkit.org/show_bug.cgi?id=171433
71
72         Reviewed by Geoffrey Garen.
73
74         Adding a preference for MediaDevices.
75         Setting media devices runtime flag to false by default.
76         Setting peer connection and media stream flags to true by default.
77
78         * WebView/WebPreferenceKeysPrivate.h:
79         * WebView/WebPreferences.mm:
80         (+[WebPreferences initialize]):
81         (-[WebPreferences mediaDevicesEnabled]):
82         (-[WebPreferences setMediaDevicesEnabled:]):
83         * WebView/WebPreferencesPrivate.h:
84         * WebView/WebView.mm:
85         (-[WebView _preferencesChanged:]):
86
87 2017-04-27  Chris Dumez  <cdumez@apple.com>
88
89         Align colspan/rowspan limits with the latest HTML specification
90         https://bugs.webkit.org/show_bug.cgi?id=171322
91
92         Reviewed by Darin Adler.
93
94         ObjC bindings build fix.
95
96         * DOM/DOMHTMLTableCellElement.mm:
97         (-[DOMHTMLTableCellElement colSpan]):
98         (-[DOMHTMLTableCellElement setColSpan:]):
99
100 2017-04-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
101
102         REGRESSION(r213764): Async decoding of animated images is disabled for ImageDocument
103         https://bugs.webkit.org/show_bug.cgi?id=170333
104
105         Reviewed by Simon Fraser.
106
107         Disbale the async decoding for large images for now.
108
109         * WebView/WebView.mm:
110         (-[WebView _preferencesChanged:]):
111
112 2017-04-27  Alex Christensen  <achristensen@webkit.org>
113
114         Modernize Frame.h
115         https://bugs.webkit.org/show_bug.cgi?id=171357
116
117         Reviewed by Andy Estes.
118
119         * WebCoreSupport/WebEditorClient.h:
120         * WebCoreSupport/WebEditorClient.mm:
121         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
122
123 2017-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
124
125         [WK1] Tweak the data interaction SPI to indicate whether or not a data interaction was handled
126         https://bugs.webkit.org/show_bug.cgi?id=171369
127         <rdar://problem/31858853>
128
129         Reviewed by Dan Bernstein.
130
131         Introduce a new SPI hook intended to replace performDataInteraction:client:global:operation: that
132         returns whether or not the data interaction was handled. Due to the difference only in return type
133         and some staging constraints, this version is prefixed with "_tryTo".
134
135         * WebView/WebView.mm:
136         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
137         * WebView/WebViewPrivate.h:
138
139 2017-04-26  Wenson Hsieh  <wenson_hsieh@apple.com>
140
141         WebItemProviderPasteboard should not synchronously load provided data
142         https://bugs.webkit.org/show_bug.cgi?id=171341
143         <rdar://problem/31614010>
144
145         Reviewed by Tim Horton.
146
147         Adds client-layer plumbing for updatePreferredTypeIdentifiers. See WebCore ChangeLog for more details.
148
149         * WebCoreSupport/WebPlatformStrategies.h:
150         * WebCoreSupport/WebPlatformStrategies.mm:
151         (WebPlatformStrategies::updatePreferredTypeIdentifiers):
152
153 2017-04-26  Zalan Bujtas  <zalan@apple.com>
154
155         RTL: recent searches popover is displayed in incorrect location
156         https://bugs.webkit.org/show_bug.cgi?id=171338
157         <rdar://problem/31377807>
158
159         Reviewed by Dean Jackson.
160
161         Add RTL support for the pop-under branch.
162
163         * WebCoreSupport/PopupMenuMac.mm:
164         (PopupMenuMac::show):
165
166 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
167
168         Limit allowed size of document.title to avoid locking WebKit clients
169         https://bugs.webkit.org/show_bug.cgi?id=165113
170         <rdar://problem/28324389>
171
172         Reviewed by Darin Adler.
173
174         When a web application attempts to set an extremely long title, truncate the
175         title to a more reasonable size.
176
177         We do this at at the presentation layer, rather than in the DOM, so that we do
178         not affect script function. Instead, we merely limit display to a level that is
179         reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
180         layer, so it is a waste of effort to send across IPC.
181
182         * WebCoreSupport/WebFrameLoaderClient.h:
183         * WebCoreSupport/WebFrameLoaderClient.mm:
184         (WebFrameLoaderClient::dispatchDidReceiveTitle):
185
186 2017-04-25  Daniel Bates  <dabates@apple.com>
187
188         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
189         https://bugs.webkit.org/show_bug.cgi?id=136452
190         <rdar://problem/23412620>
191
192         Reviewed by Brent Fulgham.
193
194         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
195
196         * Configurations/FeatureDefines.xcconfig:
197
198 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
199
200         Support reading NSURL titles from the pasteboard when performing data interaction
201         https://bugs.webkit.org/show_bug.cgi?id=171156
202         <rdar://problem/31356937>
203
204         Reviewed by Tim Horton.
205
206         Add a new WK1 SPI property, -[WebFrame hasRichlyEditableDragCaret].
207
208         * WebCoreSupport/WebPlatformStrategies.h:
209         * WebCoreSupport/WebPlatformStrategies.mm:
210         (WebPlatformStrategies::readURLFromPasteboard):
211         * WebView/WebFrame.mm:
212         (-[WebFrame hasRichlyEditableDragCaret]):
213         * WebView/WebFramePrivate.h:
214
215 2017-04-24  Andy VanWagoner  <thetalecrafter@gmail.com>
216
217         Clean up ICU headers
218         https://bugs.webkit.org/show_bug.cgi?id=170997
219
220         Reviewed by JF Bastien.
221
222         Update all icu headers to 55.1
223
224         * icu/README: Explain ICU headers for OS X better
225         * icu/unicode/localpointer.h:
226         (LocalPointer::LocalPointer):
227         (LocalPointer::adoptInsteadAndCheckErrorCode):
228         * icu/unicode/platform.h:
229         * icu/unicode/putil.h:
230         * icu/unicode/uchar.h:
231         * icu/unicode/uconfig.h:
232         * icu/unicode/ucurr.h:
233         * icu/unicode/uidna.h:
234         * icu/unicode/umachine.h:
235         * icu/unicode/urename.h:
236         * icu/unicode/uscript.h:
237         * icu/unicode/ustring.h:
238         * icu/unicode/utf8.h:
239         * icu/unicode/utypes.h:
240         * icu/unicode/uvernum.h:
241
242 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
243
244         Respect fidelity order when reading web content from item providers
245         https://bugs.webkit.org/show_bug.cgi?id=171155
246         <rdar://problem/31356937>
247
248         Reviewed by Tim Horton.
249
250         Adjusts for changes in WebCore (see WebCore/ChangeLog for more details).
251
252         * WebCoreSupport/WebPlatformStrategies.h:
253         * WebCoreSupport/WebPlatformStrategies.mm:
254         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex):
255
256 2017-04-24  Alex Christensen  <achristensen@webkit.org>
257
258         Reduce copies and allocations in SharedBuffer::append
259         https://bugs.webkit.org/show_bug.cgi?id=170956
260
261         Reviewed by Andreas Kling.
262
263         * WebView/WebArchive.mm:
264         (-[WebArchive initWithData:]):
265         * WebView/WebFrame.mm:
266         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
267         * WebView/WebResource.mm:
268         (-[WebResource initWithCoder:]):
269         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
270
271 2017-04-24  Dan Bernstein  <mitz@apple.com>
272
273         [Cocoa] Some ivars are needlessly @protected
274         https://bugs.webkit.org/show_bug.cgi?id=171208
275
276         Reviewed by Anders Carlsson
277
278         Made ivars @private where possible.
279
280         * Misc/WebUserContentURLPattern.h:
281         * Plugins/WebPluginDatabase.h:
282         * Storage/WebDatabaseQuotaManager.h:
283         * WebCoreSupport/WebSecurityOriginPrivate.h:
284         * WebInspector/WebInspector.h:
285         * WebView/WebDeviceOrientation.h:
286         * WebView/WebDeviceOrientationProviderMock.h:
287         * WebView/WebGeolocationPosition.h:
288         * WebView/WebHTMLRepresentation.h:
289         * WebView/WebNotification.h:
290
291 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
292
293         Support writing link titles to the pasteboard when beginning data interaction on a link
294         https://bugs.webkit.org/show_bug.cgi?id=171154
295         <rdar://problem/31356937>
296
297         Reviewed by Andy Estes.
298
299         Adjust for some changes in WebCore to introduce a separate codepath for writing PasteboardURLs. See WebCore
300         and WebKit2 ChangeLogs for more details.
301
302         * WebCoreSupport/WebPlatformStrategies.h:
303         * WebCoreSupport/WebPlatformStrategies.mm:
304         (WebPlatformStrategies::writeToPasteboard):
305
306 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
307
308         Unreviewed, rolling out r215608.
309
310         Hundreds of test failures on GTK bot
311
312         Reverted changeset:
313
314         "Reduce copies and allocations in SharedBuffer::append"
315         https://bugs.webkit.org/show_bug.cgi?id=170956
316         http://trac.webkit.org/changeset/215608
317
318 2017-04-21  Alex Christensen  <achristensen@webkit.org>
319
320         Reduce copies and allocations in SharedBuffer::append
321         https://bugs.webkit.org/show_bug.cgi?id=170956
322
323         Reviewed by Andreas Kling.
324
325         * WebView/WebArchive.mm:
326         (-[WebArchive initWithData:]):
327         * WebView/WebFrame.mm:
328         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
329         * WebView/WebResource.mm:
330         (-[WebResource initWithCoder:]):
331         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
332
333 2017-04-20  Dewei Zhu  <dewei_zhu@apple.com>
334
335         Build fix to start using C++14.
336         https://bugs.webkit.org/show_bug.cgi?id=171038
337
338         Reviewed by Alex Christensen.
339
340         Use 'c++14' instead of 'c++11' in order to use 'auto' in lambda.
341
342         * Configurations/WebKitLegacy.xcconfig:
343
344 2017-04-19  Youenn Fablet  <youenn@apple.com>
345
346         [Mac] Allow customizing H264 encoder
347         https://bugs.webkit.org/show_bug.cgi?id=170829
348
349         Reviewed by Alex Christensen.
350
351         * Configurations/FeatureDefines.xcconfig:
352
353 2017-04-19  Anders Carlsson  <andersca@apple.com>
354
355         Stop using deprecated APIs, part 3
356         https://bugs.webkit.org/show_bug.cgi?id=171003
357         rdar://problem/31589635
358
359         Reviewed by Tim Horton.
360
361         * WebCoreSupport/WebPaymentCoordinatorClient.h:
362         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
363         (WebPaymentCoordinatorClient::cancelPaymentSession):
364         Update for WebCore changes.
365
366 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
367
368         [WK2] Support DataTransfer::files() when performing a DHTML data interaction
369         https://bugs.webkit.org/show_bug.cgi?id=170880
370         <rdar://problem/31314689>
371
372         Reviewed by Tim Horton.
373
374         Adjust for a change in PasteboardStrategy. See WebCore ChangeLog for more details.
375
376         * WebCoreSupport/WebPlatformStrategies.h:
377         * WebCoreSupport/WebPlatformStrategies.mm:
378         (WebPlatformStrategies::getFilenamesForDataInteraction):
379
380 2017-04-17  Youenn Fablet  <youenn@apple.com>
381
382         Disable outdated WritableStream API
383         https://bugs.webkit.org/show_bug.cgi?id=170749
384         <rdar://problem/31446233>
385
386         Reviewed by Alex Christensen.
387
388         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
389         - A STREAMS_API compilation flag.
390         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
391
392         * Configurations/FeatureDefines.xcconfig:
393         * WebView/WebPreferenceKeysPrivate.h:
394         * WebView/WebPreferences.mm:
395         (+[WebPreferences initialize]):
396         (-[WebPreferences readableByteStreamAPIEnabled]):
397         (-[WebPreferences setReadableByteStreamAPIEnabled:]):
398         (-[WebPreferences writableStreamAPIEnabled]):
399         (-[WebPreferences setWritableStreamAPIEnabled:]):
400         * WebView/WebPreferencesPrivate.h:
401         * WebView/WebView.mm:
402         (-[WebView _preferencesChanged:]):
403
404 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
405
406         [WK2] Support data interaction of files into file inputs
407         https://bugs.webkit.org/show_bug.cgi?id=170803
408         <rdar://problem/31286130>
409
410         Reviewed by Tim Horton.
411
412         Add boilerplate plumbing for fetching the number of files in the pasteboard.
413
414         * WebCoreSupport/WebPlatformStrategies.h:
415         * WebCoreSupport/WebPlatformStrategies.mm:
416         (WebPlatformStrategies::getNumberOfFiles):
417
418 2017-04-14  Mark Lam  <mark.lam@apple.com>
419
420         Update architectures in xcconfig files.
421         https://bugs.webkit.org/show_bug.cgi?id=170867
422         <rdar://problem/31628104>
423
424         Reviewed by Joseph Pecoraro.
425
426         * Configurations/FeatureDefines.xcconfig:
427
428 2017-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
429
430         [WK2] Support Icon creation from file URLs on iOS
431         https://bugs.webkit.org/show_bug.cgi?id=170809
432         <rdar://problem/31286130>
433
434         Reviewed by Tim Horton.
435
436         Adjust for changes in the ChromeClient in WebCore.
437
438         * WebCoreSupport/WebChromeClient.h:
439         * WebCoreSupport/WebChromeClient.mm:
440         (WebChromeClient::loadIconForFiles):
441         (WebChromeClient::createIconForFiles):
442
443 2017-04-12  Dan Bernstein  <mitz@apple.com>
444
445         [Mac] Future-proof .xcconfig files
446         https://bugs.webkit.org/show_bug.cgi?id=170802
447
448         Reviewed by Tim Horton.
449
450         * Configurations/Base.xcconfig:
451         * Configurations/DebugRelease.xcconfig:
452         * Configurations/FeatureDefines.xcconfig:
453         * Configurations/Version.xcconfig:
454
455 2017-04-12  Beth Dakin  <bdakin@apple.com>
456
457         Build fix.
458
459         * WebView/WebViewData.h:
460
461 2017-04-12  Brian Weinstein  <bweinstein@apple.com>
462
463         Should always override -[WebStorageManager init].
464         https://bugs.webkit.org/show_bug.cgi?id=170787
465         -and corresponding-
466         rdar://problem/31371835
467
468         Reviewed by Anders Carlsson.
469
470         * Storage/WebStorageManager.mm:
471         (-[WebStorageManager init]):
472
473 2017-04-12  Beth Dakin  <bdakin@apple.com>
474
475         Speculative build fix. 
476
477         * WebView/WebViewData.h:
478
479 2017-04-12  Beth Dakin  <bdakin@apple.com>
480
481         Adopt AVKit name change from AVFunctionBar* to AVTouchBar*
482         https://bugs.webkit.org/show_bug.cgi?id=170693
483         -and corresponding-
484         rdar://problem/31230018
485
486         Reviewed by Sam Weinig.
487
488         Since the new names only apply to some versions of macOS, this patch uses typedefs 
489         for the older OS’s. SO:
490
491         AVFunctionBarScrubber is now AVTouchBarScrubber
492
493         AVFunctionBarPlaybackControlsProvider is now AVTouchBarPlaybackControlsProvider
494
495         AVFunctionBarMediaSelectionOption is now AVTouchBarMediaSelectionOption
496
497         And the protocol AVFunctionBarPlaybackControlsControlling is now 
498         AVTouchBarPlaybackControlsControlling
499
500         Soft links and allocations cannot use the typedefs.
501         * WebView/WebView.mm:
502         (-[WebView updateMediaTouchBar]):
503         * WebView/WebViewData.h:
504
505 2017-04-11  Dean Jackson  <dino@apple.com>
506
507         Disable outdated WritableStream API
508         https://bugs.webkit.org/show_bug.cgi?id=170749
509         <rdar://problem/31446233>
510
511         Reviewed by Tim Horton.
512
513         The API we implement is no longer accurate. Disable it until we
514         are compatible with the new specification
515
516         * Configurations/FeatureDefines.xcconfig:
517
518 2017-04-11  Dan Bernstein  <mitz@apple.com>
519
520         [iOS] Simple HTML documents should allow non-markup JavaScript
521         https://bugs.webkit.org/show_bug.cgi?id=170734
522
523         Reviewed by Sam Weinig.
524
525         * WebView/WebView.mm:
526         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Enabled scripting
527           but disabled scripting markup.
528
529 2017-04-10  Alex Christensen  <achristensen@webkit.org>
530
531         Revert r215217
532         https://bugs.webkit.org/show_bug.cgi?id=170703
533
534         * Configurations/FeatureDefines.xcconfig:
535
536 2017-04-10  Alex Christensen  <achristensen@webkit.org>
537
538         Continue enabling WebRTC
539         https://bugs.webkit.org/show_bug.cgi?id=170703
540
541         Reviewed by Youenn Fablet.
542
543         * Configurations/FeatureDefines.xcconfig:
544
545 2017-04-10  Anders Carlsson  <andersca@apple.com>
546
547         Remove call to WKShowKeyAndMain
548         https://bugs.webkit.org/show_bug.cgi?id=170691
549         rdar://problem/31050032
550
551         Reviewed by Beth Dakin.
552
553         * Carbon/CarbonWindowAdapter.mm:
554         (-[CarbonWindowAdapter makeKeyWindow]):
555
556 2017-04-10  Jeremy Jones  <jeremyj@apple.com>
557
558         Add CoreAudioCaptureSource.
559         https://bugs.webkit.org/show_bug.cgi?id=170112
560         rdar://problem/30293338
561
562         Reviewed by Eric Carlson.
563
564         Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.
565
566         * WebView/WebPreferenceKeysPrivate.h:
567         * WebView/WebPreferences.mm:
568         (+[WebPreferences initialize]):
569         (-[WebPreferences useAVFoundationAudioCapture]):
570         (-[WebPreferences setUseAVFoundationAudioCapture:]):
571         * WebView/WebPreferencesPrivate.h:
572         * WebView/WebView.mm:
573         (-[WebView _preferencesChanged:]):
574
575 2017-04-10  Chris Dumez  <cdumez@apple.com>
576
577         Drop Timer::startOneShot() overload taking a double
578         https://bugs.webkit.org/show_bug.cgi?id=170659
579
580         Reviewed by Yusuke Suzuki.
581
582         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
583
584         * Plugins/WebNetscapePluginView.mm:
585         (PluginTimer::start):
586         * Storage/WebStorageManager.mm:
587         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
588
589 2017-04-09  Chris Dumez  <cdumez@apple.com>
590
591         Drop Timer::startRepeating() overload taking a double
592         https://bugs.webkit.org/show_bug.cgi?id=170656
593
594         Reviewed by Yusuke Suzuki.
595
596         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
597
598         * Plugins/WebNetscapePluginView.mm:
599         (PluginTimer::start):
600
601 2017-04-09  Chris Dumez  <cdumez@apple.com>
602
603         Start dropping Timer API dealing with double
604         https://bugs.webkit.org/show_bug.cgi?id=170649
605
606         Reviewed by Yusuke Suzuki.
607
608         Start dropping Timer API dealing with double as people should use Seconds now.
609
610         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
611         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
612         (WebKit::NetscapePluginInstanceProxy::loadRequest):
613         * Plugins/WebNetscapePluginStream.mm:
614         (WebNetscapePluginStream::deliverData):
615
616 2017-04-08  Chris Dumez  <cdumez@apple.com>
617
618         Drop std::chrono support from Timer class
619         https://bugs.webkit.org/show_bug.cgi?id=170645
620
621         Reviewed by Sam Weinig.
622
623         Drop std::chrono support from Timer class now that we prefer using Seconds type.
624
625         * WebView/WebView.mm:
626         (+[WebView _setCacheModel:]):
627
628 2017-04-08  Youenn Fablet  <youenn@apple.com>
629
630         WebRTC tests gardening
631         https://bugs.webkit.org/show_bug.cgi?id=170508
632
633         Reviewed by Eric Carlson.
634
635         * Configurations/FeatureDefines.xcconfig:
636
637 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
638
639         Unreviewed, rolling out r215046.
640
641         This change broke internal builds.
642
643         Reverted changeset:
644
645         "WebRTC tests gardening"
646         https://bugs.webkit.org/show_bug.cgi?id=170508
647         http://trac.webkit.org/changeset/215046
648
649 2017-04-06  Tim Horton  <timothy_horton@apple.com>
650
651         Obj-C bindings build fails with CSS_DEVICE_ADAPTATION turned on
652         https://bugs.webkit.org/show_bug.cgi?id=170566
653
654         Reviewed by Simon Fraser.
655
656         * DOM/DOMCSS.mm:
657         (kitClass):
658         Use the WebCore-side enum for this, since that's actually what we're switching over.
659         This allows us to handle values here without adding them to the API header.
660         All of the other kitClass() functions work the same way.
661         Also, unindent for style purposes.
662
663 2017-04-06  Youenn Fablet  <youenn@apple.com>
664
665         WebRTC tests gardening
666         https://bugs.webkit.org/show_bug.cgi?id=170508
667
668         Reviewed by Eric Carlson.
669
670         * Configurations/FeatureDefines.xcconfig:
671
672 2017-04-04  Megan Gardner  <megan_gardner@apple.com>
673
674         Fix leaks in WebUITextIndicatorData
675         https://bugs.webkit.org/show_bug.cgi?id=170480
676
677         Reviewed by Wenson Hsieh.
678
679         Removes extraneous retains.
680
681         * WebView/WebView.mm:
682         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
683
684 2017-04-04  Tim Horton  <timothy_horton@apple.com>
685
686         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
687         https://bugs.webkit.org/show_bug.cgi?id=165801
688         <rdar://problem/29649535>
689
690         Reviewed by Wenson Hsieh.
691
692         * WebView/WebView.mm:
693         (incrementFrame):
694         Adjust to the new CanWrap enum.
695
696 2017-03-27  Joseph Pecoraro  <pecoraro@apple.com>
697
698         Web Inspector: Saving files should not suggest the top level directory
699         https://bugs.webkit.org/show_bug.cgi?id=170085
700         <rdar://problem/30197794>
701
702         Reviewed by Matt Baker.
703
704         * WebCoreSupport/WebInspectorClient.mm:
705         (WebInspectorFrontendClient::save):
706         Don't set panel.directoryURL unless we have a good suggestion.
707
708 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
709
710         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
711         https://bugs.webkit.org/show_bug.cgi?id=169168
712         <rdar://problem/30688374>
713
714         Reviewed by Tim Horton.
715
716         Refactors WebDragClient::actionMaskForDrag to take platform data only, rather than the entire DragData. See the
717         WebCore ChangeLog entry for more details. Also renames WebDefaultUIDelegate.m to WebDefaultUIDelegate.mm, since
718         we need to import a C++ header for linkedOnOrAfter().
719
720         The default delegate implementation of webView:dragDestinationActionMaskForDraggingInfo: now checks if the current
721         application is linking against 10.12 or earlier, and if so, will allow any drag destination action instead of
722         the new default value of everything but DragDestinationActionLoad.
723
724         * DefaultDelegates/WebDefaultUIDelegate.mm: Renamed from Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.m.
725         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
726         * Misc/WebKitVersionChecks.h:
727         * WebCoreSupport/WebDragClient.h:
728         * WebCoreSupport/WebDragClient.mm:
729         (WebDragClient::actionMaskForDrag): Deleted.
730         * WebView/WebView.mm:
731         (-[WebView draggingEntered:]):
732         (-[WebView draggingUpdated:]):
733
734 2017-03-21  Wenson Hsieh  <wenson_hsieh@apple.com>
735
736         Add support for showing the platform data interaction caret
737         https://bugs.webkit.org/show_bug.cgi?id=169898
738         <rdar://problem/31146295>
739
740         Reviewed by Beth Dakin.
741
742         Plumb the dataInteractionCaretRect through WebView SPI to WebKit1 clients.
743
744         * WebView/WebView.mm:
745         (-[WebView _dataInteractionCaretRect]):
746         * WebView/WebViewPrivate.h:
747
748 2017-03-22  Dan Bernstein  <mitz@apple.com>
749
750         [iOS] downloadableBinaryFontsEnabled is set to false in -initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:
751         https://bugs.webkit.org/show_bug.cgi?id=169967
752         <rdar://problem/30406898>
753
754         Reviewed by Anders Carlsson.
755
756         * WebView/WebView.mm:
757         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Removed call to
758           Settings::downloadableBinaryFontsEnabled. The default is true.
759
760 2017-03-22  Andy Estes  <aestes@apple.com>
761
762         [QuickLook] Rename QuickLookHandle to PreviewLoader
763         https://bugs.webkit.org/show_bug.cgi?id=169961
764
765         Reviewed by Andreas Kling.
766
767         * WebCoreSupport/WebFrameLoaderClient.h:
768         * WebCoreSupport/WebFrameLoaderClient.mm:
769         (WebFrameLoaderClient::createPreviewLoaderClient):
770         (WebFrameLoaderClient::createQuickLookHandleClient): Deleted.
771
772 2017-03-21  Anders Carlsson  <andersca@apple.com>
773
774         Remove bogus availability annotations from DOM SPI headers.
775         rdar://problem/31015675
776
777         Rubber-stamped by Dan Bernstein.
778
779         * DOM/DOMHTMLMediaElement.h:
780         * DOM/DOMHTMLVideoElement.h:
781         * DOM/DOMMediaError.h:
782         * DOM/DOMTextEvent.h:
783         * DOM/DOMTimeRanges.h:
784         * DOM/DOMTokenList.h:
785
786 2017-03-19  Wenson Hsieh  <wenson_hsieh@apple.com>
787
788         Teach TextIndicator to estimate the background color of the given Range
789         https://bugs.webkit.org/show_bug.cgi?id=169869
790         <rdar://problem/31127272>
791
792         Reviewed by Anders Carlsson and Simon Fraser.
793
794         Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.
795
796         * WebView/WebView.mm:
797         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
798         (-[WebUITextIndicatorData dealloc]):
799         * WebView/WebViewPrivate.h:
800
801 2017-03-20  Dan Bernstein  <mitz@apple.com>
802
803         [Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
804         https://bugs.webkit.org/show_bug.cgi?id=169861
805
806         Reviewed by Sam Weinig.
807
808         * MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
809         * postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the
810           timestamp file used by the Xcode project to determine whether to run the script.
811
812 2017-03-19  Alexey Proskuryakov  <ap@apple.com>
813
814         WebHTMLView is useless as WebResourceHandler
815         https://bugs.webkit.org/show_bug.cgi?id=169857
816
817         Reviewed by Dan Bernstein.
818
819         * WebView/WebHTMLView.mm:
820         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
821         WebHTMLView doesnt implement any of WebResourceHandler methods.
822
823 2017-03-17  Michael Saboff  <msaboff@apple.com>
824
825         Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
826         https://bugs.webkit.org/show_bug.cgi?id=169817
827
828         Reviewed by Filip Pizlo.
829
830         * Configurations/FeatureDefines.xcconfig:
831
832 2017-03-17  Antti Koivisto  <antti@apple.com>
833
834         Add a reload policy where only expired subresources are revalidated
835         https://bugs.webkit.org/show_bug.cgi?id=169756
836
837         Reviewed by Andreas Kling.
838
839         * WebView/WebFrame.mm:
840         (toWebFrameLoadType):
841         (-[WebFrame reload]):
842         (-[WebFrame reloadFromOrigin]):
843
844 2017-03-17  Wenson Hsieh  <wenson_hsieh@apple.com>
845
846         [WK1] Support animated transitions when performing a data interaction operation
847         https://bugs.webkit.org/show_bug.cgi?id=169805
848         <rdar://problem/31045767>
849
850         Reviewed by Beth Dakin and Megan Gardner.
851
852         Adds WebKit1 support for animated transitions when performing a data interaction operation. See per-method changes
853         for more details.
854
855         * DOM/DOMElement.h:
856         * DOM/DOMElement.mm:
857         (-[DOMElement boundsInRootViewSpace]):
858
859         Introduce -[DOMElement boundsInRootViewSpace], which returns the bounds of the element in root view coordinates.
860
861         * WebCoreSupport/WebDragClient.h:
862         (): Deleted.
863         * WebCoreSupport/WebDragClient.mm:
864         (WebDragClient::didConcludeEditDrag):
865
866         Add boilerplate plumbing.
867
868         * WebView/WebView.mm:
869         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
870
871         Add contentImageWithoutSelection and contentImageWithoutSelectionRectInRootViewCoordinates to WebUITextIndicatorData.
872
873         (floatRectsForCGRectArray):
874         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
875
876         Introduces a SPI helper method in WebView that clients can use to generate an image of a text platter given an
877         image of some text, as well as clipping rects to apply to the image.
878
879         (-[WebView _dataOperationTextIndicator]):
880
881         Add SPI to fetch the text indicator used to drive animations for the current data operation.
882
883         (-[WebView _didConcludeEditDataInteraction]):
884         * WebView/WebViewData.h:
885         * WebView/WebViewInternal.h:
886         * WebView/WebViewPrivate.h:
887
888 2017-03-16  Simon Fraser  <simon.fraser@apple.com>
889
890         Improve the system tracing points
891         https://bugs.webkit.org/show_bug.cgi?id=169790
892
893         Reviewed by Zalan Bujtas.
894
895         Use a more cohesive set of system trace points that give a good overview of what
896         WebKit is doing. Added points for resource loading, render tree building, sync messages
897         to the web process, async image decode, WASM and fetching cookies.
898
899         * WebView/WebHTMLView.mm:
900         (-[WebHTMLView drawRect:]):
901
902 2017-03-16  Youenn Fablet  <youenn@apple.com>
903
904         Wrap legacy WebRTC API in runtime flag
905         https://bugs.webkit.org/show_bug.cgi?id=169646
906
907         Reviewed by Alex Christensen.
908
909         * WebView/WebPreferenceKeysPrivate.h:
910         * WebView/WebPreferences.mm:
911         (+[WebPreferences initialize]):
912         (-[WebPreferences webRTCLegacyAPIEnabled]):
913         (-[WebPreferences setWebRTCLegacyAPIEnabled:]):
914         * WebView/WebPreferencesPrivate.h:
915         * WebView/WebView.mm:
916         (-[WebView _preferencesChanged:]):
917
918 2017-03-14  Megan Gardner  <megan_gardner@apple.com>
919
920         Correctly export WebItemProviderPasteboard
921         https://bugs.webkit.org/show_bug.cgi?id=169578
922
923         Reviewed by Tim Horton.
924
925         * MigrateHeaders.make:
926
927 2017-03-14  Wenson Hsieh  <wenson_hsieh@apple.com>
928
929         [WK2] Data interaction tests occasionally hit assertions in debug builds
930         https://bugs.webkit.org/show_bug.cgi?id=169002
931         <rdar://problem/30994806>
932
933         Reviewed by Tim Horton.
934
935         Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.
936
937         * WebView/WebHTMLView.mm:
938         (-[WebHTMLView _updateSelectionForInputManager]):
939         * WebView/WebView.mm:
940         (-[WebView updateTextTouchBar]):
941
942 2017-03-13  Anders Carlsson  <andersca@apple.com>
943
944         Fix build warnings.
945
946         * WebCoreSupport/WebInspectorClient.mm:
947         (WebInspectorFrontendClient::save):
948         (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
949
950 2017-03-11  Brady Eidson  <beidson@apple.com>
951
952         Cleanup "addCookie" and its sole user.
953         https://bugs.webkit.org/show_bug.cgi?id=169486
954
955         Reviewed by Brian Burg.
956
957         * WebCoreSupport/WebPlatformStrategies.h:
958         * WebCoreSupport/WebPlatformStrategies.mm:
959         (WebPlatformStrategies::addCookie): Deleted.
960
961 2017-03-10  Alex Christensen  <achristensen@webkit.org>
962
963         Fix watch and tv builds after r213294
964         https://bugs.webkit.org/show_bug.cgi?id=169508
965
966         Reviewed by Dan Bernstein.
967
968         * Configurations/FeatureDefines.xcconfig:
969
970 2017-03-10  Alex Christensen  <achristensen@webkit.org>
971
972         Fix CMake build.
973
974         * WebView/WebNotification.h:
975         Don't assume we have already included something that includes NSObject.h.
976
977 2017-03-09  Daniel Bates  <dabates@apple.com>
978
979         Guard Credential Management implementation behind a runtime enabled feature flag
980         https://bugs.webkit.org/show_bug.cgi?id=169364
981         <rdar://problem/30957425>
982
983         Reviewed by Brent Fulgham.
984
985         Add WebKit preference for Credential Management (disabled by default).
986
987         * WebView/WebPreferenceKeysPrivate.h:
988         * WebView/WebPreferences.mm:
989         (+[WebPreferences initialize]):
990         (-[WebPreferences credentialManagementEnabled]): Added.
991         (-[WebPreferences setCredentialManagementEnabled:]): Added.
992         * WebView/WebPreferencesPrivate.h:
993         * WebView/WebView.mm:
994         (-[WebView _preferencesChanged:]):
995
996 2017-03-09  Anders Carlsson  <andersca@apple.com>
997
998         Add delegate support to WebCore
999         https://bugs.webkit.org/show_bug.cgi?id=169427
1000         Part of rdar://problem/28880714.
1001
1002         Reviewed by Geoffrey Garen.
1003
1004         * Configurations/FeatureDefines.xcconfig:
1005         Add feature define.
1006
1007 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
1008
1009         Fix DataInteraction guards
1010         https://bugs.webkit.org/show_bug.cgi?id=169404
1011
1012         Reviewed by Wenson Hsieh.
1013
1014         * WebCoreSupport/WebDragClient.mm:
1015
1016 2017-03-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1017
1018         Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
1019         https://bugs.webkit.org/show_bug.cgi?id=169392
1020         <rdar://problem/30882974>
1021
1022         Reviewed by Tim Horton.
1023
1024         Add a stub implementation of WebDragClient::didConcludeEditDrag.
1025
1026         * WebCoreSupport/WebDragClient.h:
1027
1028 2017-03-08  Anders Carlsson  <andersca@apple.com>
1029
1030         Simplify the PaymentCoordinator interface
1031         https://bugs.webkit.org/show_bug.cgi?id=169382
1032         Part of rdar://problem/28880714.
1033
1034         Reviewed by Tim Horton.
1035
1036         Update for PaymentCoordinatorClient changes.
1037
1038         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1039         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1040         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
1041         (WebPaymentCoordinatorClient::completeShippingContactSelection):
1042         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
1043         (WebPaymentCoordinatorClient::completePaymentSession):
1044
1045 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
1046
1047         Fix for dependency fix
1048         https://bugs.webkit.org/show_bug.cgi?id=169369
1049
1050         Reviewed by Beth Dakin.
1051
1052         * WebView/WebViewPrivate.h:
1053
1054 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
1055
1056         Fix Project Dependency
1057         https://bugs.webkit.org/show_bug.cgi?id=169340
1058
1059         Unreviewed Dependency Fix.
1060
1061         * WebView/WebViewPrivate.h:
1062
1063 2017-03-07  Alexey Proskuryakov  <ap@apple.com>
1064
1065         WebKitLegacy should re-export symbols from WebCore on watchos and tvos
1066         https://bugs.webkit.org/show_bug.cgi?id=169341
1067         <rdar://problem/30913788>
1068
1069         Reviewed by Dan Bernstein.
1070
1071         * MigrateHeaders.make:
1072
1073 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
1074
1075         Have fixedPositionCreatesStackingContext be on by default everywhere
1076         https://bugs.webkit.org/show_bug.cgi?id=169334
1077
1078         Reviewed by Zalan Bujtas.
1079
1080         It makes no sense to have web-exposed CSS functionality be different based on setting,
1081         and other browser are now aligned with having position:fixed create stacking context.
1082
1083         So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
1084         always force stacking context for position:fixed.
1085
1086         * WebView/WebView.mm:
1087         (-[WebView _preferencesChanged:]):
1088
1089 2017-03-06  Simon Fraser  <simon.fraser@apple.com>
1090
1091         Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
1092         https://bugs.webkit.org/show_bug.cgi?id=169230
1093
1094         Reviewed by Tim Horton.
1095
1096         * WebView/WebView.mm:
1097         (-[WebView _preferencesChanged:]):
1098
1099 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
1100
1101         Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
1102         https://bugs.webkit.org/show_bug.cgi?id=169329
1103
1104         Reviewed by Tim Horton.
1105
1106         If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.
1107
1108         * WebView/WebPreferences.mm:
1109         (+[WebPreferences initialize]):
1110
1111 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
1112
1113         Additional DataInteraction Support
1114         https://bugs.webkit.org/show_bug.cgi?id=169316
1115         <rdar://problem/30884234>
1116
1117         Reviewed by Wenson Hsieh.
1118
1119         Add stub implementations to WebView for methods that handle data interaction
1120
1121         * WebView/WebView.mm:
1122         (-[WebView _enteredDataInteraction:client:global:operation:]):
1123         (-[WebView _updatedDataInteraction:client:global:operation:]):
1124         (-[WebView _exitedDataInteraction:client:global:operation:]):
1125         (-[WebView _performDataInteraction:client:global:operation:]):
1126         (-[WebView _endedDataInteraction:global:]):
1127         * WebView/WebViewPrivate.h:
1128
1129 2017-03-07  Dean Jackson  <dino@apple.com>
1130
1131         Some platforms won't be able to create a GPUDevice
1132         https://bugs.webkit.org/show_bug.cgi?id=169314
1133         <rdar://problems/30907521>
1134
1135         Reviewed by Jon Lee.
1136
1137         Disable WEB_GPU on the iOS Simulator.
1138
1139         * Configurations/FeatureDefines.xcconfig:
1140
1141 2017-03-07  Maureen Daum  <mdaum@apple.com>
1142
1143         Correctly check for an empty database file.
1144         <rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
1145         https://bugs.webkit.org/show_bug.cgi?id=169256
1146
1147         Reviewed by Brady Eidson.
1148
1149         Check if the folder for an origin's WebSQL databases is empty after trying to delete
1150         all of its files. Currently we check if the deletedDatabaseFileCount matches the number
1151         of files that were in the folder. However, when we delete the actual database file in
1152         DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
1153         the database file, but deletedDatabaseFileCount only gets incremented once.
1154
1155         * Storage/WebDatabaseManager.mm:
1156         (+[WebDatabaseManager removeEmptyDatabaseFiles]):
1157         Delete the folder if it is empty.
1158
1159 2017-03-06  Michael Saboff  <msaboff@apple.com>
1160
1161         Unreviewed build fix to add
1162         -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
1163         for objective C++ files.
1164
1165         * Configurations/WebKitLegacy.xcconfig:
1166
1167 2017-03-06  Michael Saboff  <msaboff@apple.com>
1168
1169         Take advantage of fast permissions switching of JIT memory for devices that support it
1170         https://bugs.webkit.org/show_bug.cgi?id=169155
1171
1172         Reviewed by Saam Barati.
1173
1174         Updated the Xcode config files to match what is in the JavaScriptCore ones.
1175
1176         * Configurations/FeatureDefines.xcconfig:
1177
1178 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
1179
1180         Expand font-weight and font-stretch to take any number
1181         https://bugs.webkit.org/show_bug.cgi?id=168889
1182
1183         Reviewed by Simon Fraser.
1184
1185         Migrate off old enum types.
1186
1187         * WebCoreSupport/PopupMenuMac.mm:
1188         (PopupMenuMac::populate):
1189         * WebView/WebHTMLView.mm:
1190         (fontNameForDescription):
1191         * WebView/WebView.mm:
1192         (-[WebView updateTextTouchBar]):
1193
1194 2017-03-03  Dean Jackson  <dino@apple.com>
1195
1196         Add WebGPU compile flag and experimental feature flag
1197         https://bugs.webkit.org/show_bug.cgi?id=169161
1198         <rdar://problem/30846689>
1199
1200         Reviewed by Tim Horton.
1201
1202         Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
1203         and an InternalSetting.
1204
1205         * Configurations/FeatureDefines.xcconfig:
1206         * WebView/WebPreferenceKeysPrivate.h:
1207         * WebView/WebPreferences.mm:
1208         (+[WebPreferences initialize]):
1209         (-[WebPreferences webGPUEnabled]):
1210         (-[WebPreferences setWebGPUEnabled:]):
1211         * WebView/WebPreferencesPrivate.h:
1212         * WebView/WebView.mm:
1213         (-[WebView _preferencesChanged:]):
1214
1215 2017-03-03  Alexey Proskuryakov  <ap@apple.com>
1216
1217         Build fix
1218         rdar://problem/30825660
1219
1220         Suggested by Dan Bernstein.
1221
1222         * Configurations/WebKitLegacy.xcconfig:
1223
1224 2017-03-02  Sam Weinig  <sam@webkit.org>
1225
1226         Rename htmlediting.h/cpp to Editing.h/cpp
1227         https://bugs.webkit.org/show_bug.cgi?id=169103
1228
1229         Reviewed by Alex Christensen.
1230
1231         * DOM/DOMUIKitExtensions.mm:
1232         * WebView/WebFrame.mm:
1233         * WebView/WebView.mm:
1234
1235 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
1236
1237         Fix 32-bit
1238         https://bugs.webkit.org/show_bug.cgi?id=169114
1239
1240         Reviewed by Alex Christensen.
1241
1242         * WebView/WebView.mm:
1243
1244 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
1245
1246         More guard fixing
1247         https://bugs.webkit.org/show_bug.cgi?id=169112
1248
1249         Reviewed by Alex Christensen.
1250
1251         Fixed an internal build.
1252
1253         * WebView/WebView.mm:
1254         * WebView/WebViewPrivate.h:
1255
1256 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
1257
1258         Data Interaction build fixes
1259         https://bugs.webkit.org/show_bug.cgi?id=169096
1260
1261         Reviewed by Tim Horton.
1262
1263         Guards weren't all correct, also missed a selector name change.
1264
1265         * WebView/WebView.mm:
1266         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
1267         * WebView/WebViewData.h:
1268         * WebView/WebViewData.mm:
1269         (-[WebViewPrivate dealloc]):
1270
1271 2017-03-02  Alex Christensen  <achristensen@webkit.org>
1272
1273         Continue enabling WebRTC
1274         https://bugs.webkit.org/show_bug.cgi?id=169056
1275
1276         Reviewed by Jon Lee.
1277
1278         * Configurations/FeatureDefines.xcconfig:
1279
1280 2017-03-01  Megan Gardner  <megan_gardner@apple.com>
1281
1282         Data interaction support for WK1
1283         https://bugs.webkit.org/show_bug.cgi?id=169062
1284
1285         Reviewed by Wenson Hsieh.
1286
1287         Support for data interaction in WebKit1
1288
1289         * WebCoreSupport/WebDragClient.mm:
1290         * WebView/WebView.mm:
1291         (-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
1292         (-[WebUITextIndicatorData initWithImage:scale:]):
1293         (-[WebUITextIndicatorData dealloc]):
1294         (-[WebView _requestStartDataInteraction:globalPosition:]):
1295         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
1296         (-[WebView _getDataInteractionData]):
1297         * WebView/WebViewData.h:
1298         * WebView/WebViewData.mm:
1299         (-[WebViewPrivate dealloc]):
1300         * WebView/WebViewInternal.h:
1301         * WebView/WebViewPrivate.h:
1302
1303 2017-03-02  Youenn Fablet  <youenn@apple.com>
1304
1305         [WebRTC] Activate ICE candidate privacy policy
1306         https://bugs.webkit.org/show_bug.cgi?id=168975
1307
1308         Reviewed by Alex Christensen.
1309
1310         * WebView/WebPreferenceKeysPrivate.h:
1311         * WebView/WebPreferences.mm:
1312         (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
1313         (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
1314         (-[WebPreferences iceCandidateFilteringEnabled]):
1315         (-[WebPreferences setIceCandidateFilteringEnabled:]):
1316         * WebView/WebPreferencesPrivate.h:
1317
1318 2017-03-01  Alex Christensen  <achristensen@webkit.org>
1319
1320         Unreviewed, rolling out r213259.
1321
1322         Broke an internal build
1323
1324         Reverted changeset:
1325
1326         "Continue enabling WebRTC"
1327         https://bugs.webkit.org/show_bug.cgi?id=169056
1328         http://trac.webkit.org/changeset/213259
1329
1330 2017-03-01  Alex Christensen  <achristensen@webkit.org>
1331
1332         Continue enabling WebRTC
1333         https://bugs.webkit.org/show_bug.cgi?id=169056
1334
1335         Reviewed by Jon Lee.
1336
1337         * Configurations/FeatureDefines.xcconfig:
1338
1339 2017-02-27  Alex Christensen  <achristensen@webkit.org>
1340
1341         Begin enabling WebRTC on 64-bit
1342         https://bugs.webkit.org/show_bug.cgi?id=168915
1343
1344         Reviewed by Eric Carlson.
1345
1346         * Configurations/FeatureDefines.xcconfig:
1347
1348 2017-02-27  Aakash Jain  <aakash_jain@apple.com>
1349
1350         Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
1351         https://bugs.webkit.org/show_bug.cgi?id=168919
1352
1353         Reviewed by Tim Horton.
1354
1355         * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
1356         * migrate-headers.sh: Run the migrate-headers script for installapi phase.
1357
1358 2017-02-27  Alex Christensen  <achristensen@webkit.org>
1359
1360         [libwebrtc] Enable WebRTC in some Production Builds
1361         https://bugs.webkit.org/show_bug.cgi?id=168858
1362
1363         * Configurations/FeatureDefines.xcconfig:
1364
1365 2017-02-26  Alexey Proskuryakov  <ap@apple.com>
1366
1367         Don't import RetainPtr in WebNotification.h
1368         https://bugs.webkit.org/show_bug.cgi?id=168876
1369
1370         Reviewed by Dan Bernstein.
1371
1372         This is an Objective-C SPI header.
1373
1374         * WebView/WebNotification.h:
1375         * WebView/WebNotification.mm:
1376         (-[WebNotification initWithCoreNotification:notificationID:]):
1377         (-[WebNotification dealloc]):
1378
1379 2017-02-26  Aakash Jain  <aakash_jain@apple.com>
1380
1381         Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
1382         https://bugs.webkit.org/show_bug.cgi?id=168819
1383
1384         Reviewed by Dan Bernstein.
1385
1386         * Configurations/WebKitLegacy.xcconfig:
1387
1388 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1389
1390         Export Objective-C symbols for variables in Webkit SPI
1391         https://bugs.webkit.org/show_bug.cgi?id=168758
1392
1393         Reviewed by Alexey Proskuryakov.
1394
1395         * Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
1396         * WebKit.exp: Added various Objective-C symbols.
1397
1398 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1399
1400         Move instance members from WKQuadObject to implementation file
1401         https://bugs.webkit.org/show_bug.cgi?id=168740
1402
1403         Reviewed by Tim Horton.
1404
1405         * DOM/DOM.mm: Moving instance member to implementation file.
1406         * DOM/DOMExtensions.h: Ditto.
1407
1408 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1409
1410         Move iOS specific symbols to WebKit.ios.exp
1411         https://bugs.webkit.org/show_bug.cgi?id=168726
1412
1413         Reviewed by Alexey Proskuryakov.
1414
1415         * WebKit.exp:
1416
1417 2017-02-21  Youenn Fablet  <youenn@apple.com>
1418
1419         [WebRTC][Mac] Activate libwebrtc
1420         https://bugs.webkit.org/show_bug.cgi?id=167293
1421         <rdar://problem/30401864>
1422
1423         Reviewed by Alex Christensen.
1424
1425         * Configurations/FeatureDefines.xcconfig:
1426
1427 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1428
1429         Export various NSString symbols from WebFramePrivate.h
1430         https://bugs.webkit.org/show_bug.cgi?id=168702
1431
1432         Reviewed by Alexey Proskuryakov.
1433
1434         * WebKit.exp:
1435
1436 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1437
1438         Export various NSString symbols from WebPreferencesPrivate.h
1439         https://bugs.webkit.org/show_bug.cgi?id=168701
1440
1441         Reviewed by Alexey Proskuryakov.
1442
1443         * WebKit.exp:
1444
1445 2017-02-21  Joseph Pecoraro  <pecoraro@apple.com>
1446
1447         Add missing WebConsoleMessage string key
1448         https://bugs.webkit.org/show_bug.cgi?id=168690
1449
1450         Reviewed by Alexey Proskuryakov.
1451
1452         * WebKit.exp:
1453         * WebView/WebUIDelegatePrivate.h:
1454         This key has an implementation but was not extern / exported like the others.
1455
1456 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1457
1458         Export various NSString symbols from WebViewPrivate.h
1459         https://bugs.webkit.org/show_bug.cgi?id=168689
1460
1461         Reviewed by Alexey Proskuryakov.
1462
1463         * WebKit.exp:
1464
1465 2017-02-21  Commit Queue  <commit-queue@webkit.org>
1466
1467         Unreviewed, rolling out r212768.
1468         https://bugs.webkit.org/show_bug.cgi?id=168698
1469
1470         Rolling out since this would break other projects. (Requested
1471         by aakashjain on #webkit).
1472
1473         Reverted changeset:
1474
1475         "[iOS] Remove old WebKit1 MemoryMeasure helper."
1476         https://bugs.webkit.org/show_bug.cgi?id=168675
1477         http://trac.webkit.org/changeset/212768
1478
1479 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
1480
1481         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
1482         https://bugs.webkit.org/show_bug.cgi?id=168620
1483         <rdar://problem/30617772>
1484
1485         Reviewed by Tim Horton.
1486
1487         * WebView/WebPreferenceKeysPrivate.h:
1488         * WebView/WebPreferences.mm:
1489         (+[WebPreferences initialize]):
1490         (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
1491         (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
1492         * WebView/WebPreferencesPrivate.h:
1493
1494 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1495
1496         Export various NSString symbols from WebUIDelegatePrivate.h
1497         https://bugs.webkit.org/show_bug.cgi?id=168679
1498
1499         Reviewed by Joseph Pecoraro.
1500
1501         * WebKit.exp:
1502
1503 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1504
1505         Export symbols for various classes present in webkit SPI
1506         https://bugs.webkit.org/show_bug.cgi?id=168674
1507
1508         Reviewed by Dan Bernstein.
1509
1510         * WebKit.exp:
1511
1512 2017-02-21  Andreas Kling  <akling@apple.com>
1513
1514         [iOS] Remove old WebKit1 MemoryMeasure helper.
1515         <https://webkit.org/b/168675>
1516
1517         Reviewed by Sam Weinig.
1518
1519         * Configurations/WebKitLegacy.xcconfig:
1520         * Misc/WebCache.mm:
1521         (+[WebCache emptyInMemoryResources]):
1522         * WebView/WebView.mm:
1523
1524 2017-02-21  Andreas Kling  <akling@apple.com>
1525
1526         [iOS] WebKit1 should use shared memory pressure handler code.
1527         <https://webkit.org/b/168653>
1528
1529         Reviewed by Antti Koivisto.
1530
1531         Register a WebThread-aware memory callback with the shared MemoryPressureHandler
1532         and get rid of the old iOS WebKit1 specific implementation. Some of it was even
1533         dead code since MobileSafari has been using WebKit2 for quite a while.
1534
1535         * WebView/WebView.h:
1536         * WebView/WebView.mm:
1537         (WebInstallMemoryPressureHandler):
1538         (+[WebView _handleMemoryWarning]): Deleted.
1539         (+[WebView registerForMemoryNotifications]): Deleted.
1540         (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
1541         (+[WebView garbageCollectNow]): Deleted.
1542         (+[WebView purgeInactiveFontData]): Deleted.
1543         (+[WebView drainLayerPool]): Deleted.
1544         (+[WebView discardAllCompiledCode]): Deleted.
1545         (+[WebView _clearMemoryPressure]): Deleted.
1546         (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
1547         * WebView/WebViewPrivate.h:
1548
1549 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
1550
1551         Stop exporting interface WebCoreScrollView on iOS
1552         https://bugs.webkit.org/show_bug.cgi?id=168536
1553
1554         Reviewed by Dan Bernstein.
1555
1556         * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
1557         * WebKit.mac.exp: Ditto.
1558         * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
1559
1560 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
1561
1562         Exclude various mac-specific header files from iOS build
1563         https://bugs.webkit.org/show_bug.cgi?id=168621
1564
1565         Reviewed by Dan Bernstein.
1566
1567         * Configurations/WebKitLegacy.xcconfig:
1568
1569 2017-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1570
1571         Add plumbing to the UI process for TextIndicatorData when computing the drag image
1572         https://bugs.webkit.org/show_bug.cgi?id=168583
1573         Work towards <rdar://problem/30313681>
1574
1575         Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
1576
1577         Reviewed by Tim Horton.
1578
1579         * WebView/WebHTMLView.mm:
1580         (-[WebHTMLView _selectionDraggingImage]):
1581         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1582
1583 2017-02-17  Anders Carlsson  <andersca@apple.com>
1584
1585         Add a new drag code path and use it for dragging plain text
1586         https://bugs.webkit.org/show_bug.cgi?id=168534
1587
1588         Reviewed by Geoffrey Garen.
1589
1590         * WebCoreSupport/WebDragClient.h:
1591         Add new members.
1592
1593         * WebCoreSupport/WebDragClient.mm:
1594         (WebDragClient::useLegacyDragClient):
1595         Return false here.
1596
1597         (WebDragClient::beginDrag):
1598         New client member function. Create an NSDraggingItem and use it to begin a dragging session.
1599
1600         * WebView/WebHTMLView.mm:
1601         (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
1602         Get the source operation mask from WebCore.
1603
1604         (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
1605         Send a fake mouse up event.
1606
1607         * WebView/WebHTMLViewInternal.h:
1608         Declare that WebHTMLView conforms to NSDraggingSource.
1609
1610 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
1611
1612         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
1613         https://bugs.webkit.org/show_bug.cgi?id=168342
1614         rdar://problem/26182266
1615
1616         Reviewed by Tim Horton.
1617
1618         * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
1619         symbols to re-export.
1620
1621 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
1622
1623         Stop exporting DOMTokenList from WebKit
1624         https://bugs.webkit.org/show_bug.cgi?id=168544
1625
1626         Reviewed by Alexey Proskuryakov.
1627
1628         * WebKit.exp:
1629
1630 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
1631
1632         Clean up how WebKit exports _WebCreateFragment
1633         https://bugs.webkit.org/show_bug.cgi?id=168579
1634
1635         Reviewed by Dan Bernstein.
1636
1637         * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
1638         * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
1639
1640 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
1641
1642         Stop exporting DOMNodeFilter
1643         https://bugs.webkit.org/show_bug.cgi?id=168542
1644
1645         Reviewed by Alexey Proskuryakov.
1646
1647         * WebKit.exp:
1648
1649 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
1650
1651         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
1652         https://bugs.webkit.org/show_bug.cgi?id=167693
1653
1654         Reviewed by Sergio Villar Senin.
1655
1656         * Configurations/FeatureDefines.xcconfig:
1657         * WebView/WebPreferences.mm:
1658         (+[WebPreferences initialize]):
1659         * WebView/WebView.mm:
1660         (-[WebView _preferencesChanged:]):
1661
1662 2017-02-15  Brady Eidson  <beidson@apple.com>
1663
1664         Stop backing up localStorage databases to iCloud by default.
1665         <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
1666
1667         Reviewed by Geoffrey Garen.
1668
1669         * Misc/WebKitVersionChecks.h:
1670         * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
1671         (WebKitLinkedOnOrAfter):
1672         (setWebKitLinkTimeVersion):
1673         (WebKitLinkTimeVersion):
1674         (linkedOnOrAfter):
1675
1676         * Storage/WebStorageManager.mm:
1677         (WebKitInitializeStorageIfNecessary):
1678
1679 2017-02-16  Daniel Bates  <dabates@apple.com>
1680
1681         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
1682         https://bugs.webkit.org/show_bug.cgi?id=168417
1683         <rdar://problem/30541748>
1684
1685         Reviewed by Brent Fulgham.
1686
1687         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
1688         Widget* as it is always called with a valid Widget.
1689
1690         * WebCoreSupport/WebFrameLoaderClient.h:
1691         * WebCoreSupport/WebFrameLoaderClient.mm:
1692         (WebFrameLoaderClient::redirectDataToPlugin):
1693         * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
1694         as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
1695         r180570 (2 years ago) though Xcode still references this ordering file (why?).
1696
1697 2017-02-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1698
1699         [JSC] Drop PassRefPtr in inspector/
1700         https://bugs.webkit.org/show_bug.cgi?id=168420
1701
1702         Reviewed by Alex Christensen.
1703
1704         * WebView/WebScriptDebugger.mm:
1705         (WebScriptDebugger::handlePause):
1706
1707 2017-02-16  Simon Fraser  <simon.fraser@apple.com>
1708
1709         Clean up use of some CALayer-related SPI
1710         https://bugs.webkit.org/show_bug.cgi?id=168401
1711
1712         Reviewed by Tim Horton.
1713
1714         Include CALayer.h not CATiledLayer.h.
1715
1716         * WebInspector/WebNodeHighlight.h:
1717
1718 2017-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1719
1720         Fix the build after r212379
1721
1722         Rubber-stamped by Anders Carlsson.
1723
1724         * WebCoreSupport/WebDragClient.mm:
1725         (WebDragClient::startDrag):
1726
1727 2017-02-15  Anders Carlsson  <andersca@apple.com>
1728
1729         Modernize DragClient::startDrag somewhat
1730         https://bugs.webkit.org/show_bug.cgi?id=168379
1731
1732         Reviewed by Tim Horton.
1733
1734         Update for WebCore changes.
1735
1736         * WebCoreSupport/WebDragClient.h:
1737         * WebCoreSupport/WebDragClient.mm:
1738         (WebDragClient::startDrag):
1739
1740 2017-02-14  Dean Jackson  <dino@apple.com>
1741
1742         Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
1743         https://bugs.webkit.org/show_bug.cgi?id=168339
1744
1745         Reviewed by Simon Fraser.
1746
1747         Use a better name.
1748
1749         * WebView/WebPreferenceKeysPrivate.h:
1750         * WebView/WebPreferences.mm:
1751         (+[WebPreferences initialize]):
1752         (-[WebPreferences forceLowPowerGPUForWebGL]):
1753         (-[WebPreferences setForceLowPowerGPUForWebGL:]):
1754         (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
1755         (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
1756         * WebView/WebPreferencesPrivate.h:
1757         * WebView/WebView.mm:
1758         (-[WebView _preferencesChanged:]):
1759
1760 2017-02-14  Chris Dumez  <cdumez@apple.com>
1761
1762         HTML Form Validation bubble should take minimum font size setting into consideration
1763         https://bugs.webkit.org/show_bug.cgi?id=168271
1764         <rdar://problem/29869869>
1765
1766         Reviewed by Simon Fraser.
1767
1768         * WebView/WebView.mm:
1769         (-[WebView _contentsOfUserInterfaceItem:]):
1770         Return font size used in the validation bubble.
1771
1772         (-[WebView showFormValidationMessage:withAnchorRect:]):
1773         Pass minimum font size setting when constructing the validation bubble.
1774
1775 2017-02-14  Anders Carlsson  <andersca@apple.com>
1776
1777         Remove an unused delegate method
1778         https://bugs.webkit.org/show_bug.cgi?id=168328
1779
1780         Reviewed by Wenson Hsieh.
1781
1782         * DefaultDelegates/WebDefaultUIDelegate.m:
1783         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
1784
1785 2017-02-14  Alexey Proskuryakov  <ap@apple.com>
1786
1787         WebCore shouldn't export SystemMemory.h
1788         https://bugs.webkit.org/show_bug.cgi?id=168285
1789
1790         Reviewed by Alex Christensen.
1791
1792         * MigrateHeaders.make: And WebKit shouldn't re-export it.
1793
1794 2017-02-13  Alexey Proskuryakov  <ap@apple.com>
1795
1796         WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
1797         https://bugs.webkit.org/show_bug.cgi?id=168282
1798
1799         Reviewed by Dan Bernstein.
1800
1801         * MigrateHeaders.make:
1802
1803 2017-02-12  Dan Bernstein  <mitz@apple.com>
1804
1805         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
1806
1807         * WebView/WebHTMLView.mm:
1808         (createShareMenuItem): Use non-deprecated method.
1809
1810 2017-02-12  Dan Bernstein  <mitz@apple.com>
1811
1812         [Cocoa] Some -respondsToSelector: checks are unnecessary
1813         https://bugs.webkit.org/show_bug.cgi?id=168183
1814
1815         Reviewed by Tim Horton.
1816
1817         * WebView/WebFullScreenController.mm:
1818         (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
1819           responds to -isOnActiveSpace.
1820         (-[WebFullScreenController exitFullScreen]): Ditto.
1821         (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
1822           NSApplication responds to -setPresentationOptions.
1823
1824         * WebView/WebHTMLView.mm:
1825         (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
1826         (-[WebHTMLView otherMouseDown:]): Ditto.
1827
1828         * WebView/WebImmediateActionController.mm:
1829         (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
1830         (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
1831
1832         * WebView/WebView.mm:
1833         (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
1834         (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
1835
1836 2017-02-10  Daniel Bates  <dabates@apple.com>
1837
1838         Detach frame from document when entering page cache
1839         https://bugs.webkit.org/show_bug.cgi?id=166774
1840         <rdar://problem/29904368>
1841
1842         Reviewed by Chris Dumez.
1843
1844         * WebView/WebPreferenceKeysPrivate.h:
1845         * WebView/WebPreferences.mm:
1846         (+[WebPreferences initialize]):
1847         (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
1848         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
1849         * WebView/WebPreferencesPrivate.h:
1850         * WebView/WebView.mm:
1851         (-[WebView _preferencesChanged:]):
1852
1853 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
1854
1855         [Resource Timing] Enable Resource Timing by default in Tests
1856         https://bugs.webkit.org/show_bug.cgi?id=168145
1857
1858         Reviewed by Ryosuke Niwa.
1859
1860         * WebView/WebPreferenceKeysPrivate.h:
1861         * WebView/WebPreferences.mm:
1862         (+[WebPreferences initialize]):
1863         (-[WebPreferences resourceTimingEnabled]):
1864         (-[WebPreferences setResourceTimingEnabled:]):
1865         * WebView/WebPreferencesPrivate.h:
1866         * WebView/WebView.mm:
1867         (-[WebView _preferencesChanged:]):
1868
1869 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
1870
1871         cleanup WebLocalizableStrings.
1872         https://bugs.webkit.org/show_bug.cgi?id=168078
1873
1874         Reviewed by Alexey Proskuryakov.
1875
1876         * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
1877         as it's for each framework's own consumption, and never needs to be exported.
1878
1879 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
1880
1881         WebResourceLoadDelegatePrivate.h cannot be imported standalone
1882         https://bugs.webkit.org/show_bug.cgi?id=168096
1883
1884         Reviewed by Alexey Proskuryakov.
1885
1886         * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
1887
1888 2017-02-09  Antti Koivisto  <antti@apple.com>
1889
1890         Remove most cases of #if ENABLE(CACHE_PARTITIONING)
1891         https://bugs.webkit.org/show_bug.cgi?id=167990
1892
1893         Reviewed by Sam Weinig.
1894
1895         * Misc/WebCache.mm:
1896         (+[WebCache addImageToCache:forURL:forFrame:]):
1897         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1898         * WebCoreSupport/WebSystemInterface.mm:
1899         (InitWebCoreSystemInterface):
1900
1901 2017-02-07  Alexey Proskuryakov  <ap@apple.com>
1902
1903         Don't migrate WebKit DOM headers in MigrateHeaders.make
1904         https://bugs.webkit.org/show_bug.cgi?id=167608
1905
1906         Reviewed by Darin Adler.
1907
1908         Stop migrating DOM headers that are now in WebKit.
1909
1910         * DOM/DOMDOMImplementation.h: Removed.
1911         * DOM/DOMDOMImplementation.mm: Removed.
1912         * DOM/DOMDOMImplementationInternal.h: Removed.
1913         * DOM/DOMDOMTokenList.h: Removed.
1914         * DOM/DOMDOMTokenList.mm: Removed.
1915         * DOM/DOMDOMTokenListInternal.h: Removed.
1916         * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
1917         * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
1918         * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
1919         * DOM/DOMTokenList.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.h.
1920         * DOM/DOMTokenList.mm: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.mm.
1921         * DOM/DOMTokenListInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenListInternal.h.
1922         As the files are not in WebCore any more, there is no need to differentiate from
1923         WebCore internal headers with the same name. This makes it possible to make these
1924         headers private using Xcode mechanisms, as opposed to copying with a shell script.
1925
1926         * DOM/DOMElement.mm: Removed "using namespace WebCore". Other DOM implementation
1927         files don't have it.
1928
1929         * DOM/DOMCore.h:
1930         * DOM/DOMDocument.mm:
1931         * DOM/DOMHTMLAnchorElement.mm:
1932         * DOM/DOMHTMLAreaElement.mm:
1933         * DOM/DOMHTMLLinkElement.mm:
1934         * DOM/DOMUtility.mm:
1935         No more "DOMDOM".
1936
1937         * WebKit.exp:
1938         No more "DOMDOM". DOMDOMTokenList was not directly exposed via an SPI header, so
1939         renaming it is likely to be safe.
1940
1941         * MigrateHeaders.make: Don't migrate WebKit headers.
1942
1943         * Configurations/WebKitLegacy.xcconfig: Don't include two iOS specific SPI headers
1944         on macOS.
1945
1946 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
1947
1948         Don't re-export PluginData.h from WebKit
1949         https://bugs.webkit.org/show_bug.cgi?id=168020
1950
1951         Reviewed by Alexey Proskuryakov.
1952
1953         * MigrateHeaders.make: Removed PluginData.h
1954
1955 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
1956
1957         Don't re-export WKUtilities.h from WebKit
1958         https://bugs.webkit.org/show_bug.cgi?id=167977
1959
1960         Reviewed by Alexey Proskuryakov.
1961
1962         * MigrateHeaders.make: Removed WKUtilities.h
1963
1964 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1965
1966         credentials should be partitioned by main document domain
1967         https://bugs.webkit.org/show_bug.cgi?id=166998
1968         rdar://problem/22901123
1969
1970         Reviewed by Brady Eidson.
1971
1972         * Misc/WebDownload.mm:
1973         * Plugins/WebBaseNetscapePluginView.mm:
1974         (WebKit::getAuthenticationInfo):
1975         Don't use partitioned credentials for WebKit1 plugins or downloads.
1976         Downloads should be authenticated before becoming a download anyways.
1977
1978 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
1979
1980         Rename AnimationController to CSSAnimationController
1981         https://bugs.webkit.org/show_bug.cgi?id=167829
1982
1983         Reviewed by Simon Fraser.
1984
1985         * WebView/WebFrame.mm:
1986         * WebView/WebView.mm:
1987
1988 2017-02-03  Chris Dumez  <cdumez@apple.com>
1989
1990         Dismiss HTML form validation popover when pressing Escape key
1991         https://bugs.webkit.org/show_bug.cgi?id=167716
1992         <rdar://problem/29872943>
1993
1994         Reviewed by Simon Fraser.
1995
1996         Override ValidationMessageClient::hideAnyValidationMessage().
1997
1998         * WebCoreSupport/WebValidationMessageClient.h:
1999         * WebCoreSupport/WebValidationMessageClient.mm:
2000         (WebValidationMessageClient::hideAnyValidationMessage):
2001
2002 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2003
2004         Drag images should be anchored to the mouse location
2005         https://bugs.webkit.org/show_bug.cgi?id=167690
2006         <rdar://problem/30295261>
2007
2008         Reviewed by Enrica Casucci.
2009
2010         Adds some plumbing for the anchor point in the WK1 client layer.
2011
2012         * WebCoreSupport/WebDragClient.h:
2013         * WebCoreSupport/WebDragClient.mm:
2014         (WebDragClient::startDrag):
2015
2016 2017-02-02  Chris Dumez  <cdumez@apple.com>
2017
2018         Rename Node::inDocument() to isConnected()
2019         https://bugs.webkit.org/show_bug.cgi?id=167743
2020
2021         Reviewed by Sam Weinig.
2022
2023         Rename Node::inDocument() to isConnected() to match the DOM specification more closely:
2024         - https://dom.spec.whatwg.org/#connected
2025
2026         * DOM/DOMNode.mm:
2027         (-[DOMNode isConnected]):
2028         * WebView/WebFrame.mm:
2029         (-[WebFrame selectNSRange:onElement:]):
2030
2031 2017-02-02  Chris Dumez  <cdumez@apple.com>
2032
2033         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
2034         https://bugs.webkit.org/show_bug.cgi?id=167738
2035         <rdar://problem/30229990>
2036
2037         Reviewed by Andreas Kling.
2038
2039         The BackForwardClient no longer needs to worry about removing HistoryItems
2040         from the PageCache now that WebCore takes care of it.
2041
2042         * History/BackForwardList.mm:
2043         (BackForwardList::close):
2044
2045 2017-02-02  Yongjun Zhang  <yongjun_zhang@apple.com>
2046
2047         In iOS, we should take background assertion when accessing localstorage databases.
2048         https://bugs.webkit.org/show_bug.cgi?id=165478
2049
2050         Move database transaction background task handling code from WebDatabaseManager to
2051         WebCore's WebSQLiteDatabaseTrackerClient.
2052
2053         Reviewed by Brady Eidson.
2054
2055         * Storage/WebDatabaseManager.mm:
2056         * Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.
2057         * WebCoreSupport/WebApplicationCache.mm:
2058         (+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.
2059         * WebView/WebView.mm:
2060         (-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.
2061
2062 2017-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2063
2064         [WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
2065         https://bugs.webkit.org/show_bug.cgi?id=167695
2066         <rdar://problem/30305390>
2067
2068         Reviewed by Sam Weinig.
2069
2070         Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
2071         exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
2072         is destroyed.
2073
2074         * WebView/WebView.mm:
2075         (-[WebView _commonInitializationWithFrameName:groupName:]):
2076
2077 2017-01-31  Joseph Pecoraro  <pecoraro@apple.com>
2078
2079         ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
2080         https://bugs.webkit.org/show_bug.cgi?id=167684
2081
2082         Reviewed by Dan Bernstein.
2083
2084         * DOM/DOMHTML.mm:
2085         (-[DOMHTMLInputElement _isAutofilled]): Deleted.
2086         (-[DOMHTMLInputElement _setAutofilled:]): Deleted.
2087         Consolidate in the WebDOMOperationsPrivate category.
2088
2089         * DOM/DOMPrivate.h:
2090         Include WebDOMOperationsPrivate header to get other DOM Private categories.
2091
2092         * DOM/WebDOMOperations.mm:
2093         (-[DOMHTMLInputElement _isAutofilled]):
2094         * DOM/WebDOMOperationsPrivate.h:
2095         Include getter alongside the setter.
2096
2097 2017-01-31  Jessie Berlin  <jberlin@webkit.org>
2098
2099         Build fix.
2100
2101         * Misc/WebNSPasteboardExtras.mm:
2102         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2103         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2104         * WebView/WebHTMLView.mm:
2105         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2106         (-[WebHTMLView copyFont:]):
2107
2108 2017-01-30  Andy Estes  <aestes@apple.com>
2109
2110         [QuickLook] FrameLoaderClient should return the new QuickLookHandleClient it creates
2111         https://bugs.webkit.org/show_bug.cgi?id=167625
2112
2113         Reviewed by Andreas Kling.
2114
2115         * WebCoreSupport/WebFrameLoaderClient.h: Declared createQuickLookHandleClient().
2116         * WebCoreSupport/WebFrameLoaderClient.mm:
2117         (WebFrameLoaderClient::createQuickLookHandleClient): Renamed from didCreateQuickLookHandle().
2118         (WebFrameLoaderClient::didCreateQuickLookHandle): Renamed to createQuickLookHandleClient().
2119
2120 2017-01-30  Chris Dumez  <cdumez@apple.com>
2121
2122         Drop legacy Attributes.isId attribute
2123         https://bugs.webkit.org/show_bug.cgi?id=167603
2124
2125         Reviewed by Ryosuke Niwa.
2126
2127         Keep Attr.isId in ObjC bindings.
2128
2129         * DOM/DOMAttr.mm:
2130         (-[DOMAttr isId]):
2131
2132 2017-01-30  Andreas Kling  <akling@apple.com>
2133
2134         [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.
2135         <https://webkit.org/b/167580>
2136
2137         Reviewed by Antti Koivisto.
2138
2139         Avoid the implicit strong capture of self by keeping it in a __block variable.
2140         Also add code to dealloc to unregister the event monitor, since it will otherwise leak.
2141         This fixes huge WebHTMLView leaks seen on the leaks bot.
2142
2143         * WebView/WebHTMLView.mm:
2144         (-[WebHTMLViewPrivate dealloc]):
2145         (-[WebHTMLView viewDidMoveToWindow]):
2146
2147 2017-01-29  Andy Estes  <aestes@apple.com>
2148
2149         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2150         https://bugs.webkit.org/show_bug.cgi?id=167563
2151         <rdar://problem/30253207>
2152
2153         Reviewed by Andreas Kling.
2154
2155         Instead of only saving QuickLook documents to a temporary file when the client is
2156         MobileSafari, base this decision on a WebPreference that clients can choose to enable.
2157
2158         This also changes the SPI for accessing the temporary file path and UTI. Instead of
2159         -[WebView quickLookContentForURL:], which requires the client to pass the response URL of
2160         the frame that saved the QuickLook document, the content dictionary is now stored as a
2161         property of WebDataSource.
2162
2163         This also removes the manual lifetime management of the QLPreviewConverter from
2164         QuickLookDocumentWriter. The QLPreviewConverter is kept alive by DocumentLoader these days,
2165         which ensures it lives long enough to respond to subresource requests.
2166
2167         New API test: QuickLook.LegacyQuickLookContent
2168
2169         * WebCoreSupport/WebFrameLoaderClient.mm:
2170         (WebFrameLoaderClient::didCreateQuickLookHandle): Moved the logic of deciding whether to
2171         write a temporary file to here from the QuickLookDocumentWriter constructor.
2172         * WebView/WebDataSource.mm: Declared _quickLookContent.
2173         (-[WebDataSource _quickLookContent]):
2174         (-[WebDataSource _setQuickLookContent:]):
2175         * WebView/WebDataSourceInternal.h: Overrode _quickLookContent as a read/write property.
2176         * WebView/WebDataSourcePrivate.h: Declared _quickLookContent as a readonly property.
2177         * WebView/WebPreferenceKeysPrivate.h: Defined WebKitQuickLookDocumentSavingPreferenceKey.
2178         * WebView/WebPreferences.mm:
2179         (-[WebPreferences quickLookDocumentSavingEnabled]):
2180         (-[WebPreferences setQuickLookDocumentSavingEnabled:]):
2181         * WebView/WebPreferencesPrivate.h: Declared property quickLookDocumentSavingEnabled.
2182         * WebView/WebView.mm:
2183         (-[WebView quickLookContentForURL:]): Changed to always return nil.
2184         * WebView/WebViewPrivate.h: Added a comment stating that clients should use
2185         -[WebDataSource _quickLookContent] instead.
2186
2187 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2188
2189         Add Link Preload as an off-by-default experimental feature menu item.
2190         https://bugs.webkit.org/show_bug.cgi?id=167201
2191
2192         Reviewed by Ryosuke Niwa.
2193
2194         * WebView/WebPreferenceKeysPrivate.h:
2195         * WebView/WebPreferences.mm:
2196         (-[WebPreferences linkPreloadEnabled]):
2197         (-[WebPreferences setLinkPreloadEnabled:]):
2198         * WebView/WebPreferencesPrivate.h:
2199         * WebView/WebView.mm:
2200         (-[WebView _preferencesChanged:]):
2201
2202 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2203
2204         Add User Timing Experimental Feature
2205         https://bugs.webkit.org/show_bug.cgi?id=167542
2206         <rdar://problem/22746307>
2207
2208         Reviewed by Ryosuke Niwa.
2209
2210         * WebView/WebPreferenceKeysPrivate.h:
2211         * WebView/WebPreferences.mm:
2212         (+[WebPreferences initialize]):
2213         (-[WebPreferences userTimingEnabled]):
2214         (-[WebPreferences setUserTimingEnabled:]):
2215         * WebView/WebPreferencesPrivate.h:
2216         * WebView/WebView.mm:
2217         (-[WebView _preferencesChanged:]):
2218         Add setting for User Timing runtime enabled feature.
2219
2220 2017-01-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2221
2222         [WK1] Do not prevent the drag client from initializing on Mac
2223         https://bugs.webkit.org/show_bug.cgi?id=167541
2224
2225         Reviewed by Dan Bernstein.
2226
2227         Fixes fallout from r211192. To ensure compability with WebKit clients, we need to ensure that WebDragClient is
2228         initialized everywhere when creating a WebView. Stub out method implementations as no-ops for non-Mac platforms.
2229         This caused certain clients, such as Mail, to crash when a webView closes due to  null dereference.
2230
2231         * WebCoreSupport/WebDragClient.mm:
2232         (WebDragClient::WebDragClient):
2233         (WebDragClient::actionMaskForDrag):
2234         (WebDragClient::willPerformDragDestinationAction):
2235         (WebDragClient::dragSourceActionMaskForPoint):
2236         (WebDragClient::willPerformDragSourceAction):
2237         (WebDragClient::startDrag):
2238         (WebDragClient::declareAndWriteDragImage):
2239         (WebDragClient::declareAndWriteAttachment):
2240         * WebView/WebView.mm:
2241         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2242
2243 2017-01-26  Chris Dumez  <cdumez@apple.com>
2244
2245         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2246         https://bugs.webkit.org/show_bug.cgi?id=167421
2247         <rdar://problem/30188490>
2248
2249         Reviewed by Darin Adler.
2250
2251         Add a new setting allowing layout tests to enable PageCache in a window
2252         that has an opener, for convenience.
2253
2254         * WebView/WebPreferenceKeysPrivate.h:
2255         * WebView/WebPreferences.mm:
2256         (+[WebPreferences initialize]):
2257         (-[WebPreferences allowsPageCacheWithWindowOpener]):
2258         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]):
2259         * WebView/WebPreferencesPrivate.h:
2260         * WebView/WebView.mm:
2261         (-[WebView _preferencesChanged:]):
2262
2263 2017-01-26  Keith Miller  <keith_miller@apple.com>
2264
2265         classInfo should take a VM so it is not materialized from the object on each call
2266         https://bugs.webkit.org/show_bug.cgi?id=167424
2267
2268         Rubber Stamped by Michael Saboff.
2269
2270         Previously, classInfo() would get the VM from the target's
2271         MarkedBlock.  Most callers already have a VM on hand, so it is
2272         wasteful to compute the VM from the marked block every time. This
2273         patch refactors some of the most common callers of classInfo(),
2274         jsDynamicCast and inherits to take a VM as well.
2275
2276         * DOM/DOM.mm:
2277         (+[DOMNode _nodeFromJSWrapper:]):
2278         * DOM/DOMUtility.mm:
2279         (createDOMWrapper):
2280         * DOM/WebDOMOperations.mm:
2281         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2282         (WebKit::getObjectID):
2283         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
2284         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
2285         * Plugins/Hosted/ProxyInstance.mm:
2286         (WebKit::ProxyRuntimeMethod::finishCreation):
2287         (WebKit::ProxyInstance::invokeMethod):
2288         * Plugins/Hosted/ProxyRuntimeObject.mm:
2289         (WebKit::ProxyRuntimeObject::finishCreation):
2290         * WebView/WebFrame.mm:
2291         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2292         * WebView/WebView.mm:
2293         (+[WebView _reportException:inContext:]):
2294         (aeDescFromJSValue):
2295         (-[WebView _notificationIDForTesting:]):
2296
2297 2017-01-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2298
2299         REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar in HTML Notes
2300         https://bugs.webkit.org/show_bug.cgi?id=167472
2301         <rdar://problem/30149809>
2302
2303         Reviewed by Beth Dakin.
2304
2305         Revision 207483 caused the touch bar to stop showing up in HTML Notes due to -updateTextTouchBar not
2306         initializing the text touch bar and causing -makeTouchBar to return nil while processing a mouse click. The
2307         purpose of bailing out of the update was to prevent the text touch bar from thrashing during a selection drag.
2308         If the text touch bar doesn't exist yet, we don't have to worry about its appearance flickering from a different
2309         previous state, so we should just allow the touch bar to update instead.
2310
2311         * WebView/WebView.mm:
2312         (-[WebView updateTextTouchBar]):
2313
2314 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2315
2316         Crash when setting custom scale factor.
2317         https://bugs.webkit.org/show_bug.cgi?id=167369
2318
2319         Reviewed by Sam Weinig.
2320
2321         Add null pointer check.
2322
2323         * WebView/WebView.mm:
2324         (-[WebView _setCustomBackingScaleFactor:]):
2325
2326 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2327
2328         Refactor drag and drop implementation on Mac
2329         https://bugs.webkit.org/show_bug.cgi?id=167427
2330
2331         Reviewed by Enrica Casucci.
2332
2333         Refactor some WebKit1 code on the Mac pertaining to drag and drop. See WebCore ChangeLog for more details.
2334
2335         * Misc/WebNSPasteboardExtras.h:
2336         * WebCoreSupport/WebDragClient.mm:
2337         * WebView/WebFrame.mm:
2338         * WebView/WebFrameInternal.h:
2339         * WebView/WebHTMLView.mm:
2340         * WebView/WebView.mm:
2341         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2342
2343 2017-01-24  Youenn Fablet  <youennf@gmail.com>
2344
2345         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
2346         https://bugs.webkit.org/show_bug.cgi?id=167294
2347
2348         Reviewed by Alex Christensen.
2349
2350         * WebView/WebView.mm:
2351         (-[WebView _commonInitializationWithFrameName:groupName:]):
2352
2353 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2354
2355         Add support for named pasteboards, pasteboard strategies and platform pasteboards
2356         https://bugs.webkit.org/show_bug.cgi?id=167404
2357
2358         Reviewed by Enrica Casucci.
2359
2360         Adds pasteboard name as an argument to pasteboard-related WebPlatformStrategy methods.
2361
2362         * WebCoreSupport/WebPlatformStrategies.h:
2363         * WebCoreSupport/WebPlatformStrategies.mm:
2364         (WebPlatformStrategies::writeToPasteboard):
2365         (WebPlatformStrategies::getPasteboardItemsCount):
2366         (WebPlatformStrategies::readBufferFromPasteboard):
2367         (WebPlatformStrategies::readURLFromPasteboard):
2368         (WebPlatformStrategies::readStringFromPasteboard):
2369
2370 2017-01-25  Aakash Jain  <aakash_jain@apple.com>
2371
2372         LoadWebLocalizedStrings method should be moved in correct file
2373         https://bugs.webkit.org/show_bug.cgi?id=167393
2374
2375         Reviewed by Alexey Proskuryakov.
2376
2377         * Misc/WebLocalizableStrings.h: Deleted LoadWebLocalizedStrings method.
2378         * Misc/WebLocalizableStrings.mm:
2379         (LoadWebLocalizedStringsTimerCallback): Deleted, moved to WebUIKitSupport.mm
2380         (LoadWebLocalizedStrings): Deleted, moved to WebUIKitSupport.mm
2381
2382 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2383
2384         Add simple line layout toggle to MiniBrowser
2385         https://bugs.webkit.org/show_bug.cgi?id=167405
2386
2387         Reviewed by Andreas Kling.
2388
2389         * WebView/WebPreferenceKeysPrivate.h:
2390         * WebView/WebPreferences.mm:
2391         (+[WebPreferences initialize]):
2392         (-[WebPreferences simpleLineLayoutEnabled]):
2393         (-[WebPreferences setSimpleLineLayoutEnabled:]):
2394         * WebView/WebPreferencesPrivate.h:
2395         * WebView/WebView.mm:
2396         (-[WebView _preferencesChanged:]):
2397
2398 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2399
2400         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2401         https://bugs.webkit.org/show_bug.cgi?id=167394
2402
2403         Reviewed by Ryosuke Niwa.
2404
2405         * Configurations/FeatureDefines.xcconfig:
2406
2407 2017-01-23  Chris Dumez  <cdumez@apple.com>
2408
2409         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
2410         https://bugs.webkit.org/show_bug.cgi?id=167308
2411         <rdar://problem/30144964>
2412
2413         Unreviewed, do a partial revert of r211033 to fix assertion.
2414
2415         * WebCoreSupport/WebChromeClient.h:
2416         * WebCoreSupport/WebChromeClient.mm:
2417         (WebChromeClient::exitFullScreenForElement):
2418
2419 2017-01-23  Joseph Pecoraro  <pecoraro@apple.com>
2420
2421         Remove allowWindowOpenWithoutUserGesture setting
2422         https://bugs.webkit.org/show_bug.cgi?id=167301
2423
2424         Reviewed by Darin Adler.
2425
2426         * WebView/WebView.mm:
2427         (-[WebView _preferencesChanged:]):
2428         Use the equivalent existing setting.
2429
2430 2017-01-20  Darin Adler  <darin@apple.com>
2431
2432         Remove PassRefPtr from "page" directory of WebCore, also deploy references
2433         https://bugs.webkit.org/show_bug.cgi?id=167224
2434
2435         Reviewed by Chris Dumez.
2436
2437         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
2438         (-[WebApplicationCacheQuotaManager quota]): Pass reference.
2439
2440         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
2441         * WebCoreSupport/WebChromeClient.mm:
2442         (WebChromeClient::focusedElementChanged): Ditto.
2443         (WebChromeClient::createWindow): Ditto.
2444         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
2445         (WebChromeClient::runJavaScriptAlert): Ditto.
2446         (WebChromeClient::runJavaScriptConfirm): Ditto.
2447         (WebChromeClient::runJavaScriptPrompt): Ditto.
2448         (WebChromeClient::contentsSizeChanged): Ditto.
2449         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
2450         (WebChromeClient::print): Ditto.
2451         (WebChromeClient::exceededDatabaseQuota): Ditto.
2452         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
2453         (WebChromeClient::createColorChooser): Ditto.
2454         (WebChromeClient::elementDidFocus): Ditto.
2455         (WebChromeClient::elementDidBlur): Ditto.
2456         (WebChromeClient::createPopupMenu): Ditto.
2457         (WebChromeClient::createSearchPopupMenu): Ditto.
2458         (WebChromeClient::attachRootGraphicsLayer): Ditto.
2459         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
2460         (WebChromeClient::supportsFullScreenForElement): Ditto.
2461         (WebChromeClient::enterFullScreenForElement): Ditto.
2462         (WebChromeClient::exitFullScreenForElement): Ditto.
2463
2464         * WebView/WebFrame.mm:
2465         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
2466         Updated for change to the appendChild function.
2467
2468 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
2469
2470         Remove -[WebFrame sendOrientationChangeEvent:] which is unused
2471         https://bugs.webkit.org/show_bug.cgi?id=167276
2472
2473         Reviewed by Alex Christensen.
2474         
2475         It was usurped by -deviceOrientationChanged in 2014.
2476
2477         * WebView/WebFrame.mm:
2478         (-[WebFrame sendOrientationChangeEvent:]): Deleted.
2479         * WebView/WebFramePrivate.h:
2480
2481 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
2482
2483         Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
2484         https://bugs.webkit.org/show_bug.cgi?id=167271
2485
2486         Reviewed by Alex Christensen.
2487         
2488         -_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
2489         overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),
2490
2491         * WebView/WebView.mm:
2492         (-[WebView _contentsSizeRespectingOverflow]): Deleted.
2493         * WebView/WebViewPrivate.h:
2494
2495 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2496
2497         Remove never changing IndexedDB RuntimeEnabledFeature
2498         https://bugs.webkit.org/show_bug.cgi?id=167278
2499
2500         Reviewed by Darin Adler.
2501
2502         * WebView/WebView.mm:
2503         (-[WebView _preferencesChanged:]):
2504
2505 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2506
2507         Cleanup RuntimeEnabledFeatures
2508         https://bugs.webkit.org/show_bug.cgi?id=167228
2509
2510         Reviewed by Simon Fraser.
2511
2512         * WebView/WebView.mm:
2513         (-[WebView _preferencesChanged:]):
2514
2515 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2516
2517         Remove outdated ENABLE(CSP_NEXT) build flag
2518         https://bugs.webkit.org/show_bug.cgi?id=167252
2519
2520         Reviewed by Brent Fulgham.
2521
2522         * Configurations/FeatureDefines.xcconfig:
2523
2524 2017-01-20  Antoine Quint  <graouts@apple.com>
2525
2526         [Modern Media Controls] Turn modern media controls on by default
2527         https://bugs.webkit.org/show_bug.cgi?id=165668
2528
2529         Reviewed by Dean Jackson.
2530
2531         Enabled modern media controls by default in WK1.
2532
2533         * WebView/WebPreferences.mm:
2534         (+[WebPreferences initialize]):
2535
2536 2017-01-19  Chris Dumez  <cdumez@apple.com>
2537
2538         iterable<> should be enabled on WK1
2539         https://bugs.webkit.org/show_bug.cgi?id=167221
2540         <rdar://problem/30108531>
2541
2542         Reviewed by Youenn Fablet.
2543
2544         * WebView/WebPreferenceKeysPrivate.h:
2545         * WebView/WebPreferences.mm:
2546         (-[WebPreferences setCustomElementsEnabled:]):
2547         (-[WebPreferences DOMIteratorEnabled]): Deleted.
2548         (-[WebPreferences setDOMIteratorEnabled:]): Deleted.
2549         * WebView/WebPreferencesPrivate.h:
2550         * WebView/WebView.mm:
2551         (-[WebView _preferencesChanged:]):
2552
2553 2017-01-19  Chris Dumez  <cdumez@apple.com>
2554
2555         Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
2556         https://bugs.webkit.org/show_bug.cgi?id=167215
2557         <rdar://problem/29885052>
2558
2559         Reviewed by Andreas Kling.
2560
2561         Make sure HTML validation bubble gets dismissed when its associated
2562         element's frame gets detached and that we do not crash.
2563
2564         * WebCoreSupport/WebValidationMessageClient.h:
2565         * WebCoreSupport/WebValidationMessageClient.mm:
2566         (WebValidationMessageClient::documentDetached):
2567
2568 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2569
2570         [Cocoa] Variation fonts are erroneously disabled on iOS
2571         https://bugs.webkit.org/show_bug.cgi?id=167172
2572
2573         Reviewed by Simon Fraser.
2574
2575         OpenSource builders don't seem to understand sdk=embedded*.
2576
2577         * Configurations/FeatureDefines.xcconfig:
2578
2579 2017-01-19  Andreas Kling  <akling@apple.com>
2580
2581         ScriptExecutionContext::topOrigin() should return a reference.
2582         <https://webkit.org/b/167190>
2583
2584         Reviewed by Sam Weinig.
2585
2586         * Misc/WebCache.mm:
2587         (+[WebCache addImageToCache:forURL:forFrame:]):
2588         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2589
2590 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2591
2592         Unreviewed fix for the macOS build.
2593
2594         * Carbon/CarbonWindowAdapter.mm:
2595         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2596
2597 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2598
2599         Unreviewed, rolling out r210848.
2600
2601         This change introduced media-related LayoutTest failures and
2602         crashes on macOS.
2603
2604         Reverted changeset:
2605
2606         "[Modern Media Controls] Turn modern media controls on by
2607         default"
2608         https://bugs.webkit.org/show_bug.cgi?id=165668
2609         http://trac.webkit.org/changeset/210848
2610
2611 2017-01-18  Andreas Kling  <akling@apple.com>
2612
2613         Document::securityOrigin() should return a reference.
2614         <https://webkit.org/b/167124>
2615
2616         Reviewed by Sam Weinig.
2617
2618         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2619         (WebKit::NetscapePluginInstanceProxy::loadRequest):
2620         * Plugins/WebNetscapePluginStream.mm:
2621         (WebNetscapePluginStream::WebNetscapePluginStream):
2622         * Plugins/WebNetscapePluginView.mm:
2623         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2624         * Plugins/WebPluginContainerCheck.mm:
2625         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2626         * WebCoreSupport/WebChromeClient.mm:
2627         (WebChromeClient::exceededDatabaseQuota):
2628         * WebCoreSupport/WebFrameLoaderClient.h:
2629         * WebCoreSupport/WebFrameLoaderClient.mm:
2630         (WebFrameLoaderClient::didRunInsecureContent):
2631         * WebCoreSupport/WebGeolocationClient.mm:
2632         (WebGeolocationClient::requestPermission):
2633         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
2634         * WebView/WebFrame.mm:
2635         (-[WebFrame _allowsFollowingLink:]):
2636
2637 2017-01-18  Antoine Quint  <graouts@apple.com>
2638
2639         [Modern Media Controls] Turn modern media controls on by default
2640         https://bugs.webkit.org/show_bug.cgi?id=165668
2641
2642         Reviewed by Dean Jackson.
2643
2644         Enabled modern media controls by default in WK1. 
2645
2646         * WebView/WebPreferences.mm:
2647         (+[WebPreferences initialize]):
2648
2649 2017-01-15  Darin Adler  <darin@apple.com>
2650
2651         Remove PassRefPtr from "loader" directory of WebCore
2652         https://bugs.webkit.org/show_bug.cgi?id=167055
2653
2654         Reviewed by Alex Christensen.
2655
2656         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
2657         Also made class final and most functions private and final.
2658         * WebCoreSupport/WebChromeClient.mm:
2659         (WebChromeClient::runOpenPanel): Updated to take references.
2660
2661         * WebCoreSupport/WebEditorClient.h: Updated for changes to EditorClient.
2662         * WebCoreSupport/WebEditorClient.mm:
2663         (-[WebUndoStep initWithUndoStep:]): Take reference instead of PassRefPtr.
2664         (+[WebUndoStep stepWithUndoStep:]): Ditto.
2665         (-[WebUndoStep step]): Return reference instead of pointer.
2666         (-[WebEditorUndoTarget undoEditing:]): Updated for the above.
2667         (-[WebEditorUndoTarget redoEditing:]): Ditto.
2668         (WebEditorClient::registerUndoOrRedoStep): Take reference instead of
2669         PassRefPtr.
2670         (WebEditorClient::registerUndoStep): Ditto.
2671         (WebEditorClient::registerRedoStep): Ditto.
2672
2673         * WebCoreSupport/WebFrameLoaderClient.h: Updated for changes to
2674         FrameLoaderClient, marked functions final instead of override.
2675         * WebCoreSupport/WebFrameLoaderClient.mm:
2676         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Take
2677         pointer instead of PassRefPtr.
2678         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
2679         (makeFormFieldValuesDictionary): Take a reference.
2680         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Take Ref&& instead
2681         of PassRefPtr.
2682         (WebFrameLoaderClient::dispatchWillSubmitForm): Take a reference instead
2683         of PassRefPtr.
2684         (WebFrameLoaderClient::actionDictionary): Take a pointer instead of PassRePtr.
2685         (WebFrameLoaderClient::createFrame): Take a reference instead of a pointer.
2686         (WebFrameLoaderClient::createPlugin): Ditto.
2687         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
2688         (WebFrameLoaderClient::createNetworkingContext): Ditto.
2689         (WebFrameLoaderClient::didCreateQuickLookHandle): Pass a reference.
2690
2691         * WebCoreSupport/WebFrameNetworkingContext.h: Use Ref instead of PassRefPtr.
2692         * WebCoreSupport/WebFrameNetworkingContext.mm: Tweak style a bit.
2693
2694         * WebCoreSupport/WebOpenPanelResultListener.h: Take a reference instead of
2695         PassRefPtr. Use RefPtr for class field.
2696         * WebCoreSupport/WebOpenPanelResultListener.mm:
2697         (-[WebOpenPanelResultListener dealloc]): Deleted. Compiler will now do it
2698         correctly without us declaring anything explicitly.
2699         (-[WebOpenPanelResultListener cancel]): Get rid of hand-written deref code,
2700         and let RefPtr do the work.
2701         (-[WebOpenPanelResultListener chooseFilename:]): Ditto.
2702         (-[WebOpenPanelResultListener chooseFilenames:]): Ditto.
2703         (-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]):
2704         Rewrote to use a modern Objective-C for loop, reserveInitialCapacity,
2705         and uncheckedAppend.
2706
2707         * WebView/WebArchive.mm:
2708         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
2709         Updated for changes to LegacyWebArchive.
2710         (-[WebArchive mainResource]): Ditto.
2711         (-[WebArchive subresources]): Ditto.
2712         (-[WebArchive subframeArchives]): Ditto.
2713
2714         * WebView/WebDataSource.mm:
2715         (-[WebDataSource _addSubframeArchives:]): Use a modern Objective-C for loop
2716         instead of NSEnumerator.
2717         (-[WebDataSource _fileWrapperForURL:]): Use auto.
2718         (-[WebDataSource _documentFragmentWithArchive:]): Pass a reference.
2719         (-[WebDataSource mainResource]): Ditto.
2720         (-[WebDataSource subresources]): Ditto.
2721         (-[WebDataSource subresourceForURL:]): Ditto.
2722         (-[WebDataSource addSubresource:]): Ditto.
2723
2724         * WebView/WebResource.mm:
2725         (-[WebResourcePrivate initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
2726         (-[WebResourcePrivate dealloc]): Remove explicit deref since RefPtr will now take
2727         care of it
2728         (-[WebResource initWithCoder:]): Pass a reference.
2729         (-[WebResource encodeWithCoder:]): Updated since coreResource is now RefPtr.
2730         (-[WebResource _initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
2731         (-[WebResource _coreResource]): Return reference rather than pointer.
2732         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
2733         Added code to handle the null case and pass a reference rather than a pointer.
2734         * WebView/WebResourceInternal.h: Updated for the above.
2735
2736 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2737
2738         Unreviewed, rolling out r210834
2739         https://bugs.webkit.org/show_bug.cgi?id=165668
2740
2741         It introduced dozens of test timeouts.
2742
2743         Reverted changeset:
2744         "[Modern Media Controls] Turn modern media controls on by default"
2745         https://bugs.webkit.org/show_bug.cgi?id=165668
2746         http://trac.webkit.org/changeset/210834
2747
2748 2017-01-17  Antoine Quint  <graouts@apple.com>
2749
2750         [Modern Media Controls] Turn modern media controls on by default
2751         https://bugs.webkit.org/show_bug.cgi?id=165668
2752
2753         Reviewed by Dean Jackson.
2754
2755         Enabled modern media controls by default in WK1. 
2756
2757         * WebView/WebPreferences.mm:
2758         (+[WebPreferences initialize]):
2759
2760 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2761
2762         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2763         https://bugs.webkit.org/show_bug.cgi?id=116551
2764         <rdar://problem/13949830>
2765
2766         Reviewed by Alex Christensen.
2767
2768         * Configurations/FeatureDefines.xcconfig:
2769
2770 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2771
2772         Crash when closing tab with debugger paused
2773         https://bugs.webkit.org/show_bug.cgi?id=161746
2774         <rdar://problem/15607819>
2775
2776         Reviewed by Brian Burg and Brent Fulgham.
2777
2778         * WebView/WebView.mm:
2779         (WebKit::DeferredPageDestructor::createDeferredPageDestructor):
2780         (WebKit::DeferredPageDestructor::DeferredPageDestructor):
2781         (WebKit::DeferredPageDestructor::tryDestruction):
2782         (-[WebView _close]):
2783         Defer destruction of the Page if we are in a nested runloop.
2784
2785 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2786
2787         Remove the REQUEST_ANIMATION_FRAME flag
2788         https://bugs.webkit.org/show_bug.cgi?id=156980
2789         <rdar://problem/25906849>
2790
2791         Reviewed by Simon Fraser.
2792
2793         * Configurations/FeatureDefines.xcconfig:
2794
2795 2017-01-16  Andy Estes  <aestes@apple.com>
2796
2797         [QuickLook] Do some cleanup in QuickLookHandle
2798         https://bugs.webkit.org/show_bug.cgi?id=166864
2799
2800         Reviewed by Darin Adler.
2801
2802         * WebCoreSupport/WebFrameLoaderClient.mm:
2803         (WebFrameLoaderClient::didCreateQuickLookHandle): Changed to pass a
2804         Ref<QuickLookHandleClient>&& to QuickLookHandle::setClient().
2805
2806 2017-01-15  Tim Horton  <timothy_horton@apple.com>
2807
2808         De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
2809         https://bugs.webkit.org/show_bug.cgi?id=167063
2810
2811         Reviewed by Dan Bernstein.
2812
2813         * WebView/WebHTMLView.mm:
2814         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2815         (-[WebHTMLView _updateFontPanel]):
2816         * WebView/WebView.mm:
2817         (-[WebView typingAttributes]):
2818         Adjust to fontAttributesForSelectionStart returning a RetainPtr.
2819
2820 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2821
2822         Remove ENABLE(DETAILS_ELEMENT) guards
2823         https://bugs.webkit.org/show_bug.cgi?id=167042
2824
2825         Reviewed by Alex Christensen.
2826
2827         * Configurations/FeatureDefines.xcconfig:
2828
2829 2017-01-11  Darin Adler  <darin@apple.com>
2830
2831         Remove PassRefPtr from more of "platform"
2832         https://bugs.webkit.org/show_bug.cgi?id=166809
2833
2834         Reviewed by Sam Weinig.
2835
2836         * WebCoreSupport/WebFrameLoaderClient.mm:
2837         (NetscapePluginWidget::handleEvent): Pass a reference.
2838         * WebView/WebView.mm:
2839         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
2840         Updated since the children set now contains Ref instead of RefPtr.
2841
2842 2017-01-13  Sam Weinig  <sam@webkit.org>
2843
2844         [WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent
2845         https://bugs.webkit.org/show_bug.cgi?id=167006
2846
2847         Reviewed by Geoffrey Garen.
2848
2849         * WebView/WebDeviceOrientation.mm:
2850         (convert):
2851         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2852         Update for new use of std::optional.
2853
2854 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
2855
2856         Remove unnecessary includes of Page.h
2857         https://bugs.webkit.org/show_bug.cgi?id=166996
2858
2859         Reviewed by Yusuke Suzuki.
2860
2861         * DOM/DOMHTML.mm:
2862         * History/WebBackForwardList.mm:
2863         * Plugins/WebPluginController.mm:
2864         * WebCoreSupport/WebNotificationClient.mm:
2865         * WebCoreSupport/WebPlatformStrategies.mm:
2866         * WebCoreSupport/WebUserMediaClient.mm:
2867         * WebView/WebFullScreenController.mm:
2868
2869 2017-01-12  Chris Dumez  <cdumez@apple.com>
2870
2871         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2872         https://bugs.webkit.org/show_bug.cgi?id=166995
2873
2874         Reviewed by Jer Noble.
2875
2876         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2877         as some people are having trouble building without it.
2878
2879         * Configurations/FeatureDefines.xcconfig:
2880
2881 2017-01-12  Chris Dumez  <cdumez@apple.com>
2882
2883         HTML form validation popover sometimes does not go away
2884         https://bugs.webkit.org/show_bug.cgi?id=166990
2885         <rdar://problem/29985957>
2886
2887         Reviewed by Tim Horton.
2888
2889         Update code using ValidationBubble now that it is RefCounted.
2890
2891         * WebView/WebView.mm:
2892         (-[WebView showFormValidationMessage:withAnchorRect:]):
2893
2894 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2895
2896         Remove pointerLockElement from DOMDocumentPrivate.h
2897         https://bugs.webkit.org/show_bug.cgi?id=166882
2898
2899         Reviewed by Simon Fraser.
2900
2901         Removed pointerLockElement declaration that was supposed to be removed in r209637.
2902
2903         * DOM/DOMDocumentPrivate.h:
2904
2905 2017-01-06  Darin Adler  <darin@apple.com>
2906
2907         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
2908         https://bugs.webkit.org/show_bug.cgi?id=166797
2909
2910         Reviewed by Alex Christensen.
2911
2912         * WebCoreSupport/WebEditorClient.h: Updated to take a reference.
2913         * WebCoreSupport/WebEditorClient.mm:
2914         (WebEditorClient::requestCheckingOfString): Take a reference
2915         instead of a PassRefPtr.
2916
2917 2017-01-05  Chris Dumez  <cdumez@apple.com>
2918
2919         Turn preferLowPowerWebGLRendering setting on by default
2920         https://bugs.webkit.org/show_bug.cgi?id=166737
2921         <rdar://problem/29870033>
2922
2923         Reviewed by Dean Jackson.
2924
2925         Temporarily turn preferLowPowerWebGLRendering setting on by default until
2926         we deal better with WebGL content in background tabs.
2927
2928         * WebView/WebPreferences.mm:
2929         (+[WebPreferences initialize]):
2930
2931 2017-01-05  Enrica Casucci  <enrica@apple.com>
2932
2933         Support File Promise during drag for macOS.
2934         https://bugs.webkit.org/show_bug.cgi?id=165204
2935         rdar://problem/19595567
2936
2937         Reviewed by Tim Horton.
2938
2939         Adds support for dropping a File Promise in a WebView.
2940         The implementation uses new File Promise API available in Sierra.
2941
2942         * Misc/WebNSPasteboardExtras.mm:
2943         (+[NSPasteboard _web_dragTypesForURL]):
2944         * WebView/WebView.mm:
2945         (-[WebView performDragOperation:]):
2946
2947 2017-01-05  Andreas Kling  <akling@apple.com>
2948
2949         Remove ChromeClient::needTouchEvents().
2950         <https://webkit.org/b/166723>
2951
2952         Rubber-stamped by Antti Koivisto.
2953
2954         * WebCoreSupport/WebChromeClient.h:
2955
2956 2017-01-04  Darin Adler  <darin@apple.com>
2957
2958         Remove PassRefPtr use from the "html" directory, other improvements
2959         https://bugs.webkit.org/show_bug.cgi?id=166635
2960
2961         Reviewed by Alex Christensen.
2962
2963         * WebCoreSupport/WebChromeClient.h:
2964         * WebCoreSupport/WebChromeClient.mm:
2965         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
2966
2967 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
2968
2969         Unreviewed, rolling out r210287.
2970
2971         This change caused editing test failures on macOS.
2972
2973         Reverted changeset:
2974
2975         "Support File Promise during drag for macOS."
2976         https://bugs.webkit.org/show_bug.cgi?id=165204
2977         http://trac.webkit.org/changeset/210287
2978
2979 2017-01-04  Enrica Casucci  <enrica@apple.com>
2980
2981         Support File Promise during drag for macOS.
2982         https://bugs.webkit.org/show_bug.cgi?id=165204
2983         rdar://problem/19595567
2984
2985         Reviewed by Tim Horton.
2986
2987         Adds support for dropping a File Promise in a WebView.
2988         The implementation uses new File Promise API available in Sierra.
2989
2990         * Misc/WebNSPasteboardExtras.mm:
2991         (+[NSPasteboard _web_dragTypesForURL]):
2992         * WebView/WebView.mm:
2993         (-[WebView performDragOperation:]):
2994
2995 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2996
2997         Provide a setting for clients to always prefer low-power WebGL
2998         https://bugs.webkit.org/show_bug.cgi?id=166675
2999         <rdar://problem/29834093>
3000
3001         Reviewed by Dan Bernstein.
3002
3003         * WebView/WebPreferenceKeysPrivate.h:
3004         * WebView/WebPreferences.mm:
3005         (+[WebPreferences initialize]):
3006         (-[WebPreferences preferLowPowerWebGLRendering]):
3007         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
3008         * WebView/WebPreferencesPrivate.h:
3009         * WebView/WebView.mm:
3010         (-[WebView _preferencesChanged:]):
3011         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
3012
3013 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3014
3015         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3016         https://bugs.webkit.org/show_bug.cgi?id=166450
3017         <rdar://problem/29447824>
3018
3019         Reviewed by Darin Adler.
3020
3021         * WebCoreSupport/CorrectionPanel.h:
3022         * WebCoreSupport/CorrectionPanel.mm:
3023         (CorrectionPanel::recordAutocorrectionResponse):
3024         (CorrectionPanel::handleAcceptedReplacement):
3025         * WebCoreSupport/WebAlternativeTextClient.mm:
3026         (toCorrectionResponse):
3027         (WebAlternativeTextClient::recordAutocorrectionResponse):
3028         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3029         through recordAutocorrectionResponse, for debugging's sake.
3030         Drop the NSView parameter because we don't need it, just the tag.
3031         Convert the new AutocorrectionResponseType value to its corresponding
3032         NSCorrectionResponse value.
3033
3034 2017-01-01  Jeff Miller  <jeffm@apple.com>
3035
3036         Update user-visible copyright strings to include 2017
3037         https://bugs.webkit.org/show_bug.cgi?id=166278
3038
3039         Reviewed by Dan Bernstein.
3040
3041         * Info.plist:
3042
3043 2016-12-30  Darin Adler  <darin@apple.com>
3044
3045         Remove PassRefPtr use from the "dom" directory, related cleanup
3046         https://bugs.webkit.org/show_bug.cgi?id=166569
3047
3048         Reviewed by Alex Christensen.
3049
3050         * WebCoreSupport/WebFrameLoaderClient.mm:
3051         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
3052         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
3053         (WebFrameLoaderClient::setTitle): Ditto.
3054         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
3055         * WebView/WebFrame.mm:
3056         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
3057         Not needed now, but useful later if we ever can get rid of the explicit constructors.
3058         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
3059         * WebView/WebHTMLRepresentation.mm:
3060         (-[WebHTMLRepresentation title]): Updated to use struct.
3061
3062 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
3063
3064         Propagate the source origin as much as possible
3065         https://bugs.webkit.org/show_bug.cgi?id=166348
3066
3067         Reviewed by Darin Adler.
3068
3069         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3070         (WebKit::NetscapePluginInstanceProxy::evaluate):
3071
3072 2016-12-23  Andy Estes  <aestes@apple.com>
3073
3074         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
3075         https://bugs.webkit.org/show_bug.cgi?id=166471
3076
3077         Reviewed by Andreas Kling.
3078
3079         When DumpRenderTree starts up, it calls
3080         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
3081         builds, this triggers the ASSERT(isMainThread()) in
3082         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
3083         started, we are on the main thread, and we are not holding the Web thread lock. This is
3084         causing all layout tests to crash in the iOS WK1 Debug configuration.
3085
3086         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
3087         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
3088
3089 2016-12-22  Andy Estes  <aestes@apple.com>
3090
3091         Make WebCore::EditorInsertAction an enum class
3092         https://bugs.webkit.org/show_bug.cgi?id=166424
3093
3094         Reviewed by Brent Fulgham.
3095
3096         * WebCoreSupport/WebEditorClient.mm:
3097         (kit):
3098
3099 2016-12-21  Beth Dakin  <bdakin@apple.com>
3100
3101         Holding down on candidates in the TouchBar should show panel on screen
3102         https://bugs.webkit.org/show_bug.cgi?id=166367
3103         -and corresponding-
3104         <rdar://problem/28479236>
3105
3106         Reviewed by Tim Horton.
3107
3108         Stray whitespace.
3109         * WebCoreSupport/WebEditorClient.mm:
3110         (WebEditorClient::handleRequestedCandidates):
3111
3112         Call the version of setCandidates: that takes a rect. We need to keep the helper 
3113         function in WK1 (unlike WK2) since we also use it for testing.
3114         * WebView/WebView.mm:
3115         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3116
3117 2016-12-20  Dean Jackson  <dino@apple.com>
3118
3119         Remove INDIE_UI
3120         https://bugs.webkit.org/show_bug.cgi?id=165881
3121         <rdar://problem/29672532>
3122
3123         Reviewed by Simon Fraser.
3124
3125         The Indie UI work has been discontinued.
3126
3127         * Configurations/FeatureDefines.xcconfig:
3128
3129 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3130
3131         [ES6] Enable ES6 Modules
3132         https://bugs.webkit.org/show_bug.cgi?id=165849
3133
3134         Reviewed by Geoffrey Garen.
3135
3136         * WebView/WebPreferenceKeysPrivate.h:
3137         * WebView/WebPreferences.mm:
3138         (+[WebPreferences initialize]):
3139         (-[WebPreferences es6ModulesEnabled]): Deleted.
3140         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
3141         * WebView/WebPreferencesPrivate.h:
3142         * WebView/WebView.mm:
3143         (-[WebView _preferencesChanged:]):
3144
3145 2016-12-16  Dave Hyatt  <hyatt@apple.com>
3146
3147         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
3148         https://bugs.webkit.org/show_bug.cgi?id=165968
3149
3150         Reviewed by Andreas Kling.
3151
3152         * DOM/DOMCSS.mm:
3153         (kitClass):
3154         * DOM/DOMCSSPrimitiveValue.mm:
3155         (-[DOMCSSPrimitiveValue getCounterValue]):
3156         (-[DOMCSSPrimitiveValue getRectValue]):
3157         (kit):
3158         * DOM/DOMCSSPrimitiveValueInternal.h:
3159         * DOM/DOMCSSStyleDeclaration.mm:
3160         * DOM/DOMCSSValue.mm:
3161         (kit):
3162         * DOM/DOMCSSValueInternal.h:
3163         * DOM/DOMCSSValueList.mm:
3164         * DOM/DOMCounter.mm:
3165         (kit):
3166         * DOM/DOMCounterInternal.h:
3167         * DOM/DOMRGBColor.mm:
3168         (kit):
3169         * DOM/DOMRGBColorInternal.h:
3170         * DOM/DOMRect.mm:
3171         (kit):
3172         * DOM/DOMRectInternal.h:
3173         * DOM/DOMUtility.mm:
3174         (createDOMWrapper):
3175
3176 2016-12-16  Chris Dumez  <cdumez@apple.com>
3177
3178         HTML form validation bubble should be dismissed on navigation
3179         https://bugs.webkit.org/show_bug.cgi?id=165960
3180         <rdar://problem/29668086>
3181
3182         Reviewed by Simon Fraser.
3183
3184         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
3185
3186         * WebView/WebView.mm:
3187         (-[WebView _didStartProvisionalLoadForFrame:]):
3188
3189 2016-12-15  Darin Adler  <darin@apple.com>
3190
3191         Use asString instead of toWTFString, toString, or getString when we already checked isString
3192         https://bugs.webkit.org/show_bug.cgi?id=165895
3193
3194         Reviewed by Yusuke Suzuki.
3195
3196         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3197         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
3198         toWTFString.
3199         * WebView/WebView.mm:
3200         (aeDescFromJSValue): Use asString/value instead of getString.
3201
3202 2016-12-15  Chris Dumez  <cdumez@apple.com>
3203
3204         Make sure HTML validation bubble's state is updated after layout
3205         https://bugs.webkit.org/show_bug.cgi?id=165922
3206         <rdar://problem/29694730>
3207
3208         Reviewed by Simon Fraser.
3209
3210         Make sure HTML validation bubble's state is updated after layout.
3211         In particular, if the validation bubble's associated element has
3212         moved or is no longer visible, we now hide the bubble.
3213
3214         * WebCoreSupport/WebValidationMessageClient.h:
3215         * WebCoreSupport/WebValidationMessageClient.mm:
3216         (WebValidationMessageClient::showValidationMessage):
3217         (WebValidationMessageClient::hideValidationMessage):
3218         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
3219
3220 2016-12-15  Chris Dumez  <cdumez@apple.com>
3221
3222         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
3223         https://bugs.webkit.org/show_bug.cgi?id=165904
3224
3225         Reviewed by Sam Weinig.
3226
3227         Update ObjC bindings so they keep building.
3228
3229         * DOM/DOMUIEvent.mm:
3230         (-[DOMUIEvent keyCode]):
3231         (-[DOMUIEvent charCode]):
3232
3233 2016-12-15  Andreas Kling  <akling@apple.com>
3234
3235         Always clear RenderLayer backing stores when going into page cache.
3236         <https://webkit.org/b/165901>
3237
3238         Reviewed by Simon Fraser.
3239
3240         * WebView/WebView.mm:
3241         (+[WebView _setCacheModel:]):
3242
3243 2016-12-12  Alex Christensen  <achristensen@webkit.org>
3244
3245         Remove unused workaround for Silverlight
3246         https://bugs.webkit.org/show_bug.cgi?id=165773
3247
3248         Reviewed by Dean Jackson.
3249
3250         * Plugins/WebNetscapePluginView.mm:
3251         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
3252         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
3253         Allowing 6 years for users to update Silverlight is more than enough.
3254         Safari doesn't even use WebKit1 for this any more.
3255         I need this to be removed because this is the only non-WebGL code that needs to link against
3256         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
3257
3258 2016-12-12  Chris Dumez  <cdumez@apple.com>
3259
3260         Document.visibilityState should use an IDL string enumeration
3261         https://bugs.webkit.org/show_bug.cgi?id=165774
3262
3263         Reviewed by Daniel Bates.
3264
3265         * DOM/DOMDocument.mm:
3266         (-[DOMDocument visibilityState]):
3267         * WebView/WebView.mm:
3268         (kit):
3269
3270 2016-12-12  Jer Noble  <jer.noble@apple.com>
3271
3272         Remove implementation of legacy Mozilla-based Fullscreen API.
3273         https://bugs.webkit.org/show_bug.cgi?id=165689
3274         <rdar://problem/29603053>
3275
3276         Reviewed by Eric Carlson.
3277
3278         * DOM/DOMElement.mm:
3279         (-[DOMElement webkitRequestFullScreen:]):
3280
3281 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
3282
3283         The DOM should have an advancing wavefront opaque root barrier
3284         https://bugs.webkit.org/show_bug.cgi?id=165712
3285
3286         Reviewed by Yusuke Suzuki.
3287         
3288         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
3289
3290         * Misc/WebCoreStatistics.mm:
3291         (+[WebCoreStatistics javaScriptObjectsCount]):
3292         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
3293         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
3294         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
3295         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
3296         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
3297         (+[WebCoreStatistics shouldPrintExceptions]):
3298         (+[WebCoreStatistics setShouldPrintExceptions:]):
3299         (+[WebCoreStatistics memoryStatistics]):
3300         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
3301         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3302         (identifierFromIdentifierRep):
3303         * Plugins/Hosted/ProxyInstance.mm:
3304         (WebKit::ProxyInstance::getPropertyNames):
3305         * Plugins/WebNetscapePluginStream.mm:
3306         (WebNetscapePluginStream::wantsAllStreams):
3307         * Plugins/WebNetscapePluginView.mm:
3308         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
3309         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
3310         (-[WebNetscapePluginView setWindowIfNecessary]):
3311         (-[WebNetscapePluginView createPluginScriptableObject]):
3312         (-[WebNetscapePluginView getFormValue:]):
3313         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
3314         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
3315         (-[WebNetscapePluginView loadPluginRequest:]):
3316         (-[WebNetscapePluginView _printedPluginBitmap]):
3317         * Plugins/WebPluginController.mm:
3318         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
3319         (-[WebPluginController stopOnePlugin:]):
3320         (-[WebPluginController stopOnePluginForPageCache:]):
3321         (-[WebPluginController destroyOnePlugin:]):
3322         (-[WebPluginController startAllPlugins]):
3323         (-[WebPluginController addPlugin:]):
3324
3325 2016-12-09  Dave Hyatt  <hyatt@apple.com>
3326
3327         [CSS Parser] Remove the old CSS Parser
3328         https://bugs.webkit.org/show_bug.cgi?id=165645
3329
3330         Reviewed by Daniel Bates.
3331
3332         * DOM/DOMCSS.mm:
3333         (kitClass):
3334         * DOM/DOMCSSRule.h:
3335
3336 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3337
3338         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3339         https://bugs.webkit.org/show_bug.cgi?id=165251
3340
3341         Reviewed by Dean Jackson.
3342
3343         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3344
3345         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
3346         * WebView/WebPreferences.mm:
3347         (+[WebPreferences initialize]):
3348         (-[WebPreferences mediaStreamEnabled]):
3349         (-[WebPreferences setMediaStreamEnabled:]):
3350         (-[WebPreferences peerConnectionEnabled]):
3351         (-[WebPreferences setPeerConnectionEnabled:]):
3352         * WebView/WebPreferencesPrivate.h:
3353         * WebView/WebView.mm:
3354         (-[WebView _preferencesChanged:]):
3355
3356 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
3357
3358         Don’t expose pointer lock in WebKit1 Objective-C API
3359         https://bugs.webkit.org/show_bug.cgi?id=165692
3360
3361         Reviewed by Simon Fraser.
3362
3363         * DOM/DOMDocument.mm:
3364         (-[DOMDocument pointerLockElement]): Deleted.
3365         (-[DOMDocument exitPointerLock]): Deleted.
3366         * DOM/DOMElement.mm:
3367         (-[DOMElement requestPointerLock]): Deleted.
3368         * DOM/DOMMouseEvent.mm:
3369         (-[DOMMouseEvent movementX]): Deleted.
3370         (-[DOMMouseEvent movementY]): Deleted.
3371
3372 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
3373
3374         document.webkitFullscreenElement leaks elements inside a shadow tree
3375         https://bugs.webkit.org/show_bug.cgi?id=158471
3376
3377         Reviewed by Chris Dumez.
3378
3379         Use the API for bindings to avoid exposing nodes inside a shadow tree.
3380
3381         * DOM/DOMDocument.mm:
3382         (-[DOMDocument webkitCurrentFullScreenElement]):
3383         (-[DOMDocument webkitFullscreenElement]):
3384
3385 2016-12-09  Beth Dakin  <bdakin@apple.com>
3386
3387         Password fields should not show the emoji button in TouchBar
3388         https://bugs.webkit.org/show_bug.cgi?id=165673
3389         -and corresponding-
3390         rdar://problem/29235739
3391
3392         Reviewed by Wenson Hsieh.
3393
3394         This patch adds a new ivar for the password touch bar and password 
3395         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
3396         of identifiers than the plain text TouchBar, it should just have its own variable.
3397
3398         The candidate list should be the only item for passwords.
3399         * WebView/WebView.mm:
3400         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
3401
3402         Account for _passwordTextTouchBar.
3403         (-[WebView didChangeAutomaticTextCompletion:]):
3404         (-[WebView setUpTextTouchBar:]):
3405         (-[WebView textTouchBar]):
3406
3407         The empty candidates array is not needed. We can just set @[ ] as the candidates 
3408         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
3409         other parts of the code to prevent us from requesting or setting other candidates 
3410         when in a password field. 
3411         (-[WebView updateTextTouchBar]):
3412
3413         Account for _passwordTextTouchBar.
3414         (-[WebView candidateList]):
3415         * WebView/WebViewData.h:
3416
3417 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3418
3419         Enable SharedArrayBuffer, remove the flag
3420         https://bugs.webkit.org/show_bug.cgi?id=165614
3421
3422         Rubber stamped by Geoffrey Garen.
3423
3424         * WebView/WebPreferencesPrivate.h:
3425
3426 2016-12-07  Dean Jackson  <dino@apple.com>
3427
3428         Remove runtime toggle for pointer-lock
3429         https://bugs.webkit.org/show_bug.cgi?id=165577
3430         <rdar://problems/29566996>
3431
3432         Reviewed by Jon Lee.
3433
3434         Remove any runtime calls to check if pointer-lock is enabled. It's
3435         either compiled in or out.
3436
3437         * WebView/WebPreferenceKeysPrivate.h:
3438         * WebView/WebPreferences.mm:
3439         (-[WebPreferences pointerLockEnabled]): Deleted.
3440         (-[WebPreferences setPointerLockEnabled:]): Deleted.
3441         * WebView/WebPreferencesPrivate.h:
3442         * WebView/WebView.mm:
3443         (-[WebView _preferencesChanged:]):
3444
3445 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
3446
3447         Correct SDKROOT values in xcconfig files
3448         https://bugs.webkit.org/show_bug.cgi?id=165487
3449         rdar://problem/29539209
3450
3451         Reviewed by Dan Bernstein.
3452
3453         Fix suggested by Dan Bernstein.
3454
3455         * Configurations/DebugRelease.xcconfig:
3456
3457 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
3458
3459         Improve the behavior of scroll-into-view when the target is inside position:fixed
3460         https://bugs.webkit.org/show_bug.cgi?id=165354
3461
3462         Reviewed by Zalan Bujtas.
3463
3464         Plumb through 'insideFixed'. We don't get compute it, so behavior from
3465         these call sites won't change.
3466
3467         * WebView/WebFrame.mm:
3468         (-[WebFrame _scrollDOMRangeToVisible:]):
3469         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
3470
3471 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
3472
3473         Enable visual viewports by default on Mac, and iOS Wk2
3474         https://bugs.webkit.org/show_bug.cgi?id=165452
3475
3476         Reviewed by Zalan Bujtas.
3477
3478         Turn visual viewports on by default for WK1 on Mac.
3479
3480         * WebView/WebPreferences.mm:
3481         (+[WebPreferences initialize]):
3482
3483 2016-12-05  Dean Jackson  <dino@apple.com>
3484
3485         pointer lock needs to be feature detectable
3486         https://bugs.webkit.org/show_bug.cgi?id=165426
3487         <rdar://problem/29486715>
3488
3489         Reviewed by Antoine Quint.
3490
3491         Set the RuntimeEnabledFeature as preferences
3492         change.
3493
3494         * WebView/WebView.mm:
3495         (-[WebView _preferencesChanged:]):
3496
3497 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
3498
3499         Unreviewed, rolling out r209299.
3500
3501         This change appears to have caused LayoutTest failures on
3502         Sierra WK1.
3503
3504         Reverted changeset:
3505
3506         "Improve the behavior of scroll-into-view when the target is
3507         inside position:fixed"
3508         https://bugs.webkit.org/show_bug.cgi?id=165354
3509         http://trac.webkit.org/changeset/209299
3510
3511 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
3512
3513         Improve the behavior of scroll-into-view when the target is inside position:fixed
3514         https://bugs.webkit.org/show_bug.cgi?id=165354
3515
3516         Reviewed by Zalan Bujtas.
3517
3518         Plumb through 'insideFixed'. We don't get compute it, so behavior from
3519         these call sites won't change.
3520
3521         * WebView/WebFrame.mm:
3522         (-[WebFrame _scrollDOMRangeToVisible:]):
3523         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
3524
3525 2016-12-02  Andy Estes  <aestes@apple.com>
3526
3527         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
3528         https://bugs.webkit.org/show_bug.cgi?id=164492
3529
3530         Reviewed by Dan Bernstein.
3531
3532         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
3533         com.apple.$(PRODUCT_NAME:rfc1034identifier).
3534         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
3535         ${PRODUCT_BUNDLE_IDENTIFIER}.
3536
3537 2016-12-02  Chris Dumez  <cdumez@apple.com>
3538
3539         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
3540         https://bugs.webkit.org/show_bug.cgi?id=165328
3541
3542         Reviewed by Simon Fraser.
3543
3544         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
3545
3546         * WebView/WebViewData.mm:
3547         (-[WebViewPrivate init]):
3548
3549 2016-12-02  Chris Dumez  <cdumez@apple.com>
3550
3551         [Mac][WK1] Implement new HTML interactive form validation user interface
3552         https://bugs.webkit.org/show_bug.cgi?id=164483
3553
3554         Reviewed by Simon Fraser.
3555
3556         Implement new HTML interactive form validation user interface on Mac
3557         WK1 and enable it by default.
3558
3559         * WebCoreSupport/WebValidationMessageClient.h: Added.
3560         * WebCoreSupport/WebValidationMessageClient.mm: Added.
3561         (WebValidationMessageClient::WebValidationMessageClient):
3562         (WebValidationMessageClient::~WebValidationMessageClient):
3563         (WebValidationMessageClient::showValidationMessage):
3564         (WebValidationMessageClient::hideValidationMessage):
3565         (WebValidationMessageClient::isValidationMessageVisible):
3566         * WebView/WebHTMLView.mm:
3567         (-[WebHTMLView _frameOrBoundsChanged]):
3568         * WebView/WebView.mm:
3569         (-[WebView _commonInitializationWithFrameName:groupName:]):
3570         (-[WebView _willStartScrollingOrZooming]):
3571         (-[WebView _contentsOfUserInterfaceItem:]):
3572         (-[WebView _scaleWebView:atOrigin:]):
3573         (-[WebView _didScrollDocumentInFrameView:]):
3574         (-[WebView _setZoomMultiplier:isTextOnly:]):
3575         (-[WebView showFormValidationMessage:withAnchorRect:]):
3576         (-[WebView hideFormValidationMessage]):
3577         * WebView/WebViewData.h:
3578         * WebView/WebViewData.mm:
3579         (-[WebViewPrivate init]):
3580         * WebView/WebViewInternal.h:
3581         * WebView/WebViewPrivate.h:
3582
3583 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
3584
3585         Add a runtime flag for SubtleCrypto
3586         https://bugs.webkit.org/show_bug.cgi?id=164982
3587
3588         Reviewed by Brent Fulgham.
3589
3590         * WebView/WebPreferenceKeysPrivate.h:
3591         * WebView/WebPreferences.mm:
3592         (+[WebPreferences initialize]):
3593         (-[WebPreferences subtleCryptoEnabled]):
3594         (-[WebPreferences setSubtleCryptoEnabled:]):
3595         * WebView/WebPreferencesPrivate.h:
3596         * WebView/WebView.mm:
3597         (-[WebView _preferencesChanged:]):
3598
3599 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
3600
3601         Add separate settings and preferences to enable/disable async decoding for large images and animated images
3602         https://bugs.webkit.org/show_bug.cgi?id=165177
3603
3604         Reviewed by Simon Fraser.
3605         
3606         Hook up the&nb