94cfc83659cf3b4fd4e74846053b37e8269013f8
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-01-19  Beth Dakin  <bdakin@apple.com>
2
3         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
4         offset by flipped-ness
5         https://bugs.webkit.org/show_bug.cgi?id=140643
6         -and corresponding-
7         rdar://problem/19489593
8
9         Reviewed by Tim Horton.
10
11         We universally flipped because we assumed that the root view was flipped and the 
12         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
13         fixes that assumption by checking the WebView’s flipped-ness.
14         * WebView/WebView.mm:
15         (-[WebView _convertRectFromRootView:]):
16
17 2015-01-19  Commit Queue  <commit-queue@webkit.org>
18
19         Unreviewed, rolling out r178653.
20         https://bugs.webkit.org/show_bug.cgi?id=140634
21
22         Broke multiple SVG tests on Mountain Lion (Requested by ap on
23         #webkit).
24
25         Reverted changeset:
26
27         "[SVG -> OTF Converter] Flip the switch on"
28         https://bugs.webkit.org/show_bug.cgi?id=140592
29         http://trac.webkit.org/changeset/178653
30
31 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
32
33         [SVG -> OTF Converter] Flip the switch on
34         https://bugs.webkit.org/show_bug.cgi?id=140592
35
36         Reviewed by Antti Koivisto.
37
38         * Configurations/FeatureDefines.xcconfig:
39
40 2015-01-18  Daniel Bates  <dabates@apple.com>
41
42         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
43         (https://bugs.webkit.org/show_bug.cgi?id=129441)
44
45         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
46         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
47
48         * WebInspector/WebNodeHighlightView.mm:
49         (-[WebNodeHighlightView layoutSublayers:]):
50
51 2015-01-16  Beth Dakin  <bdakin@apple.com>
52
53         Make sure early cancellation of immediate action actually does that in WK1
54         https://bugs.webkit.org/show_bug.cgi?id=140566
55         -and corresponding-
56         rdar://problem/19490114
57
58         Reviewed by Tim Horton.
59
60         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
61         asynchronously.
62         * WebView/WebImmediateActionController.mm:
63         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
64
65 2015-01-16  Daniel Bates  <dabates@apple.com>
66
67         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
68         (https://bugs.webkit.org/show_bug.cgi?id=140360)
69
70         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
71
72         * Misc/WebDownload.h:
73
74 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
75
76         Remove ENABLE(SQL_DATABASE) guards
77         https://bugs.webkit.org/show_bug.cgi?id=140434
78
79         Reviewed by Darin Adler.
80
81         * Configurations/FeatureDefines.xcconfig:
82         * Storage/WebDatabaseManager.mm:
83         (databasesDirectoryPath):
84         * Storage/WebDatabaseManagerClient.h:
85         * Storage/WebDatabaseManagerClient.mm:
86         * Storage/WebDatabaseManagerInternal.h:
87         * Storage/WebDatabaseManagerPrivate.h:
88         * Storage/WebDatabaseQuotaManager.mm:
89         (-[WebDatabaseQuotaManager usage]):
90         (-[WebDatabaseQuotaManager quota]):
91         (-[WebDatabaseQuotaManager setQuota:]):
92         * WebCoreSupport/WebChromeClient.h:
93         * WebCoreSupport/WebChromeClient.mm:
94         * WebCoreSupport/WebSecurityOrigin.mm:
95         (-[WebSecurityOrigin usage]):
96         (-[WebSecurityOrigin quota]):
97         (-[WebSecurityOrigin setQuota:]):
98         * WebView/WebFrame.mm:
99         (-[WebFrame _cacheabilityDictionary]):
100         * WebView/WebView.mm:
101         (-[WebView _commonInitializationWithFrameName:groupName:]):
102         (-[WebView _preferencesChanged:]):
103
104 2015-01-14  Chris Dumez  <cdumez@apple.com>
105
106         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
107         https://bugs.webkit.org/show_bug.cgi?id=140347
108
109         Reviewed by Darin Adler.
110
111         Call FontDescription::setIsItalic() instead of setItalic() as the
112         call site passes a boolean.
113
114         * WebView/WebHTMLView.mm:
115         (fontNameForDescription):
116
117 2015-01-13  Anders Carlsson  <andersca@apple.com>
118
119         Temporarily reintroduce the informal delegate protocols
120         https://bugs.webkit.org/show_bug.cgi?id=140416
121
122         Reviewed by Dan Bernstein.
123
124         * WebView/WebEditingDelegate.h:
125         * WebView/WebFrameLoadDelegate.h:
126         * WebView/WebPolicyDelegate.h:
127         * WebView/WebResourceLoadDelegate.h:
128         * WebView/WebUIDelegate.h:
129
130 2015-01-13  Beth Dakin  <bdakin@apple.com>
131
132         Should disable immediate actions for iTunes
133         https://bugs.webkit.org/show_bug.cgi?id=140405
134         -and corresponding-
135         rdar://problem/19461358
136
137         Reviewed by Tim Horton.
138
139         * WebView/WebImmediateActionController.mm:
140         (-[WebImmediateActionController _updateImmediateActionItem]):
141
142 2015-01-11  Sam Weinig  <sam@webkit.org>
143
144         Remove support for SharedWorkers
145         https://bugs.webkit.org/show_bug.cgi?id=140344
146
147         Reviewed by Anders Carlsson.
148
149         * Configurations/FeatureDefines.xcconfig:
150         * WebCoreSupport/WebPlatformStrategies.h:
151         * WebCoreSupport/WebPlatformStrategies.mm:
152         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
153
154 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
155
156         Get rid of unnecessary reimplementations of CGFloor/Ceiling
157         https://bugs.webkit.org/show_bug.cgi?id=140375
158
159         Reviewed by Simon Fraser.
160
161         * Misc/WebKitNSStringExtras.mm:
162         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
163         (webkit_CGCeiling): Deleted.
164         Delete unnecessary code, use the real CGFloor/Ceiling instead.
165
166 2015-01-12  Anders Carlsson  <andersca@apple.com>
167
168         Make delegates conform to formal delegate protocols
169         https://bugs.webkit.org/show_bug.cgi?id=140370
170
171         Reviewed by Dan Bernstein.
172
173         * DefaultDelegates/WebDefaultPolicyDelegate.h:
174         * WebCoreSupport/WebInspectorClient.mm:
175         Add protocols to the interface declarations.
176
177         * WebView/WebActionMenuController.mm:
178         (-[WebActionMenuController prepareForMenu:withEvent:]):
179         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
180         * WebView/WebImmediateActionController.mm:
181         (-[WebImmediateActionController _updateImmediateActionItem]):
182         (-[WebImmediateActionController _menuItemForDataDetectedText]):
183         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
184
185 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
186
187         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
188         https://bugs.webkit.org/show_bug.cgi?id=136769
189
190         Reviewed by Antti Koivisto.
191
192         * Configurations/FeatureDefines.xcconfig:
193
194 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
195
196         Multi-rect TextIndicators are vertically flipped in WebKit1
197         https://bugs.webkit.org/show_bug.cgi?id=140350
198         <rdar://problem/19441243>
199
200         Reviewed by Beth Dakin.
201
202         * WebView/WebView.mm:
203         (-[WebView _setTextIndicator:fadeOut:]):
204         Convert the textBoundingRect from root view to screen coordinates.
205
206 2015-01-12  Anders Carlsson  <andersca@apple.com>
207
208         Make WebResourceDelegate a formal protocol as well
209         https://bugs.webkit.org/show_bug.cgi?id=140364
210
211         Reviewed by Dan Bernstein.
212
213         * WebView/WebResourceLoadDelegate.h:
214
215 2015-01-12  Anders Carlsson  <andersca@apple.com>
216
217         Delegates should be formal protocols
218         https://bugs.webkit.org/show_bug.cgi?id=140360
219         rdar://problem/17380856
220
221         Reviewed by Dan Bernstein.
222
223         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
224
225         * DefaultDelegates/WebDefaultUIDelegate.h:
226         * Misc/WebDownload.h:
227         * WebView/WebEditingDelegate.h:
228         * WebView/WebFrameLoadDelegate.h:
229         * WebView/WebPolicyDelegate.h:
230         * WebView/WebUIDelegate.h:
231
232 2015-01-09  Anders Carlsson  <andersca@apple.com>
233
234         Get rid of the database strategy
235         https://bugs.webkit.org/show_bug.cgi?id=140322
236
237         Reviewed by Sam Weinig.
238
239         * WebCoreSupport/WebPlatformStrategies.h:
240         * WebCoreSupport/WebPlatformStrategies.mm:
241         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
242
243 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
244
245         Can't use DataDetectors after immediate action preparation
246         https://bugs.webkit.org/show_bug.cgi?id=140263
247         <rdar://problem/19412705>
248
249         Reviewed by Beth Dakin.
250
251         * WebView/WebImmediateActionController.mm:
252         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
253         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
254         To match WebKit2, only call shouldUseActions if the animation is actually
255         going to begin, not when preparing for it. This way, we're guaranteed
256         to get a didCancel or didComplete.
257
258 2015-01-08  Dean Jackson  <dino@apple.com>
259
260         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
261         https://bugs.webkit.org/show_bug.cgi?id=140232
262         <rdar://problem/19371010>
263
264         Reviewed by Anders Carlsson.
265
266         Remove the applicationChromeMode setting, but leave stubs in to make
267         sure existing binaries don't break.
268
269         * WebCoreSupport/WebInspectorClient.mm:
270         (-[WebInspectorWindowController init]):
271         * WebView/WebPreferenceKeysPrivate.h:
272         * WebView/WebPreferences.mm:
273         (+[WebPreferences initialize]):
274         (-[WebPreferences applicationChromeModeEnabled]):
275         (-[WebPreferences setApplicationChromeModeEnabled:]):
276         * WebView/WebView.mm:
277         (-[WebView _preferencesChanged:]):
278
279 2015-01-07  Daniel Bates  <dabates@apple.com>
280
281         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
282         https://bugs.webkit.org/show_bug.cgi?id=137371
283
284         Reviewed by David Kilzer.
285
286         Use SPI wrapper headers instead of directly references private SPI headers.
287
288         * Plugins/Hosted/NetscapePluginHostManager.mm:
289
290 2015-01-07  Commit Queue  <commit-queue@webkit.org>
291
292         Unreviewed, rolling out r178068.
293         https://bugs.webkit.org/show_bug.cgi?id=140235
294
295         Breaks the iOS build (Requested by enrica on #webkit).
296
297         Reverted changeset:
298
299         "[iOS] Make WebKit2 build with public iOS SDK and more build
300         fixes for DRT"
301         https://bugs.webkit.org/show_bug.cgi?id=137371
302         http://trac.webkit.org/changeset/178068
303
304 2015-01-07  Daniel Bates  <dabates@apple.com>
305
306         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
307         https://bugs.webkit.org/show_bug.cgi?id=137371
308
309         Reviewed by David Kilzer.
310
311         Use SPI wrapper headers instead of directly references private SPI headers.
312
313         * Plugins/Hosted/NetscapePluginHostManager.mm:
314
315 2015-01-07  Beth Dakin  <bdakin@apple.com>
316
317         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
318         link
319         https://bugs.webkit.org/show_bug.cgi?id=140206
320         -and corresponding-
321         rdar://problem/19300492
322
323         Reviewed by Tim Horton.
324
325         Providing and item frame will ensure that the original link is not obscured.
326         * WebView/WebImmediateActionController.mm:
327         (elementBoundingBoxInWindowCoordinatesFromNode):
328         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
329
330         For now use a max size that is smaller than the WebView, with the screen’s aspect 
331         ratio, and scaled down.
332         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
333
334 2015-01-07  Anders Carlsson  <andersca@apple.com>
335
336         Give simple HTML documents a database provider
337         https://bugs.webkit.org/show_bug.cgi?id=140192
338         rdar://problem/19398825
339
340         Reviewed by Tim Horton.
341
342         * WebView/WebView.mm:
343         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
344
345 2015-01-06  Anders Carlsson  <andersca@apple.com>
346
347         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
348         https://bugs.webkit.org/show_bug.cgi?id=140140
349
350         Reviewed by Andreas Kling.
351
352         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
353         out of WebCore since nobody else is using it.
354
355         * Plugins/WebNetscapePluginView.h:
356         * Plugins/WebNetscapePluginView.mm:
357         (-[WebNetscapePluginView _createPlugin]):
358         (-[WebNetscapePluginView _destroyPlugin]):
359         * Plugins/npapi.mm:
360         (NPN_PluginThreadAsyncCall):
361
362 2015-01-06  Anders Carlsson  <andersca@apple.com>
363
364         Add a WebKit1 database provider
365         https://bugs.webkit.org/show_bug.cgi?id=140126
366
367         Reviewed by Sam Weinig.
368
369         Set the database provider.
370
371         * WebView/WebView.mm:
372         (-[WebView _commonInitializationWithFrameName:groupName:]):
373
374 2015-01-06  Commit Queue  <commit-queue@webkit.org>
375
376         Unreviewed, rolling out r177963.
377         https://bugs.webkit.org/show_bug.cgi?id=140136
378
379         Caused lots of crashes (Requested by smfr on #webkit).
380
381         Reverted changeset:
382
383         "Add a WebKit1 database provider"
384         https://bugs.webkit.org/show_bug.cgi?id=140126
385         http://trac.webkit.org/changeset/177963
386
387 2015-01-06  Anders Carlsson  <andersca@apple.com>
388
389         Add a WebKit1 database provider
390         https://bugs.webkit.org/show_bug.cgi?id=140126
391
392         Reviewed by Sam Weinig.
393
394         Set the database provider.
395
396         * WebView/WebView.mm:
397         (-[WebView _commonInitializationWithFrameName:groupName:]):
398
399 2015-01-01  Jeff Miller  <jeffm@apple.com>
400
401         Update user-visible copyright strings to include 2015
402         https://bugs.webkit.org/show_bug.cgi?id=139880
403
404         Reviewed by Darin Adler.
405
406         * Info.plist:
407
408 2014-12-30  Dan Bernstein  <mitz@apple.com>
409
410         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
411         https://bugs.webkit.org/show_bug.cgi?id=140003
412
413         Reviewed by Darin Adler.
414
415         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
416         that takes their "string" parameter as a "value" "parameter and has an attribute telling
417         the compiler that if the "value" parameter is a format string then the function returns a
418         modified version of it. The result is that if UI_STRING is used as a format string parameter
419         to some function or method, the compiler will check the format specifiers in the string
420         against the other parameters.
421
422 2014-12-29  Dan Bernstein  <mitz@apple.com>
423
424         Fixed the iOS build.
425
426         * Configurations/WebKitLegacy.xcconfig:
427
428 2014-12-29  Anders Carlsson  <andersca@apple.com>
429
430         Get rid of some PageGroup storage functions
431         https://bugs.webkit.org/show_bug.cgi?id=139996
432
433         Reviewed by Sam Weinig.
434
435         Call WebStorageNamespaceProvider directly instead.
436
437         * Storage/WebStorageManager.mm:
438         (-[WebStorageManager syncLocalStorage]):
439         (+[WebStorageManager closeIdleLocalStorageDatabases]):
440         * WebView/WebView.mm:
441         (+[WebView _applicationWillTerminate]):
442
443 2014-12-29  Anders Carlsson  <andersca@apple.com>
444
445         Move storage code from WebCore to WebKit
446         https://bugs.webkit.org/show_bug.cgi?id=139558
447
448         Reviewed by Darin Adler.
449
450         * Storage/WebStorageManager.mm:
451         * Storage/WebStorageTrackerClient.h:
452         * WebView/WebView.mm:
453
454 2014-12-26  Dan Bernstein  <mitz@apple.com>
455
456         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
457         https://bugs.webkit.org/show_bug.cgi?id=139950
458
459         Reviewed by David Kilzer.
460
461         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
462         in a manner that works with Xcode 5.1.1.
463
464 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
465
466         Install a TextIndicator for link immediate actions
467         https://bugs.webkit.org/show_bug.cgi?id=139897
468         <rdar://problem/19333076>
469
470         Reviewed by Anders Carlsson.
471
472         * WebView/WebImmediateActionController.h:
473         * WebView/WebImmediateActionController.mm:
474         (-[WebImmediateActionController _clearImmediateActionState]):
475         Tear down the TextIndicator, just like WebKit2.
476
477         (-[WebImmediateActionController _defaultAnimationController]):
478         Install a TextIndicator for links.
479
480         (-[WebImmediateActionController menuItemDidClose:]):
481         Tear down the TextIndicator when the QL preview closes.
482
483         (-[WebImmediateActionController _menuItemForDataDetectedText]):
484         Directly install and uninstall the TextIndicator for DataDetectors.
485
486         (-[WebImmediateActionController _showTextIndicator]): Deleted.
487         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
488         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
489
490 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
491
492         [iOS] add optimized fullscreen API
493         https://bugs.webkit.org/show_bug.cgi?id=139833
494         <rdar://problem/18844486>
495
496         Reviewed by Simon Fraser.
497
498         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
499
500 2014-12-20  David Kilzer  <ddkilzer@apple.com>
501
502         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
503         <http://webkit.org/b/139463>
504
505         Reviewed by Mark Rowe.
506
507         * Configurations/Base.xcconfig:
508         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
509           on OS X.
510         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
511         * Configurations/DebugRelease.xcconfig:
512         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
513         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
514         * Configurations/Version.xcconfig:
515         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
516         * Configurations/WebKitLegacy.xcconfig:
517         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
518           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
519           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
520           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
521           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
522           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
523           WEBCORE_PRIVATE_HEADERS_DIR_Production and
524           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
525           based on SDK.
526         - Fix PRODUCTION_ROOT to actually be set properly.
527         - Simplify EXPORTED_SYMBOLS_FILE_i386.
528
529         * migrate-headers.sh:
530         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
531         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
532           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
533           WebKitLegacy.xcconfig.
534
535 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
536
537         Fix pink background on CoreAnimation plug-ins in WebKit1
538         https://bugs.webkit.org/show_bug.cgi?id=139845
539         rdar://problem/19313075
540
541         Reviewed by Tim Horton.
542         
543         r154078 left in some debugging code that set a pink background on plug-in hosting
544         layers. Remove it.
545
546         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
547         (-[WebHostedNetscapePluginView createPluginLayer]):
548
549 2014-12-19  Andreas Kling  <akling@apple.com>
550
551         Ref-ify TextIterator API.
552         <https://webkit.org/b/139823>
553
554         Reviewed by Antti Koivisto.
555
556         * WebView/WebTextIterator.mm:
557         (-[WebTextIterator currentRange]):
558
559 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
560
561         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
562         https://bugs.webkit.org/show_bug.cgi?id=139797
563
564         Reviewed by Mark Lam.
565
566         * WebView/WebScriptDebugger.h:
567         * WebView/WebScriptDebugger.mm:
568         (WebScriptDebugger::handlePause):
569         Standardize on passing JSGlobalObject parameter first.
570
571 2014-12-19  Commit Queue  <commit-queue@webkit.org>
572
573         Unreviewed, rolling out r177574.
574         https://bugs.webkit.org/show_bug.cgi?id=139821
575
576         "Broke Production builds by installing
577         libWebCoreTestSupport.dylib in the wrong directory" (Requested
578         by ddkilzer on #webkit).
579
580         Reverted changeset:
581
582         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
583         WebInspectorUI, WebKit, WebKit2"
584         https://bugs.webkit.org/show_bug.cgi?id=139463
585         http://trac.webkit.org/changeset/177574
586
587 2014-12-19  David Kilzer  <ddkilzer@apple.com>
588
589         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
590         <http://webkit.org/b/139463>
591
592         Reviewed by Mark Rowe.
593
594         * Configurations/Base.xcconfig:
595         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
596           on OS X.
597         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
598         * Configurations/DebugRelease.xcconfig:
599         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
600         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
601         * Configurations/Version.xcconfig:
602         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
603         * Configurations/WebKitLegacy.xcconfig:
604         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
605           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
606           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
607           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
608           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
609           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
610           WEBCORE_PRIVATE_HEADERS_DIR_Production and
611           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
612           based on SDK.
613         - Fix PRODUCTION_ROOT to actually be set properly.
614         - Simplify EXPORTED_SYMBOLS_FILE_i386.
615
616         * migrate-headers.sh:
617         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
618         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
619           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
620           WebKitLegacy.xcconfig.
621
622 2014-12-18  Andreas Kling  <akling@apple.com>
623
624         Ref-ify various Document-related things.
625         <https://webkit.org/b/139796>
626
627         Reviewed by Anders Carlsson.
628
629         * WebView/WebFrame.mm:
630         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
631
632 2014-12-18  Beth Dakin  <bdakin@apple.com>
633
634         Need to re-enable action menus
635         https://bugs.webkit.org/show_bug.cgi?id=139795
636         -and corresponding-
637         rdar://problem/19299367
638
639         Reviewed by Tim Horton.
640
641         Re-enable the menus by un-commenting the code to create the menu and controller.
642         * WebView/WebView.mm:
643         (-[WebView _commonInitializationWithFrameName:groupName:]):
644
645 2014-12-16  Sam Weinig  <sam@webkit.org>
646
647         Unify the Mac and iOS implementations of FontPlatformData a bit
648         https://bugs.webkit.org/show_bug.cgi?id=139721
649
650         Reviewed by Anders Carlsson.
651
652         * WebView/WebHTMLView.mm:
653         (fontNameForDescription):
654         Update for new function name.
655
656 2014-12-18  Antti Koivisto  <antti@apple.com>
657
658         Remove alwaysUseBaselineOfPrimaryFont setting
659         https://bugs.webkit.org/show_bug.cgi?id=139770
660
661         Reviewed by Anders Carlsson.
662
663         * WebView/WebPreferenceKeysPrivate.h:
664         * WebView/WebPreferences.mm:
665         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
666         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
667         * WebView/WebPreferencesPrivate.h:
668         * WebView/WebView.mm:
669         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
670         (-[WebView _preferencesChanged:]):
671
672 2014-12-17  Andreas Kling  <akling@apple.com>
673
674         Ref-ify Range::create().
675         <https://webkit.org/b/139755>
676
677         Reviewed by Anders Carlsson.
678
679         * WebView/WebHTMLRepresentation.mm:
680         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
681         * WebView/WebHTMLView.mm:
682         (-[WebHTMLView attributedString]):
683
684 2014-12-17  Anders Carlsson  <andersca@apple.com>
685
686         Unify -[WebResource description]
687         https://bugs.webkit.org/show_bug.cgi?id=139762
688
689         Reviewed by Dan Bernstein.
690
691         * WebView/WebResource.mm:
692         (-[WebResource description]):
693
694 2014-12-17  Anders Carlsson  <andersca@apple.com>
695
696         Get rid of an ugly #define hack in WebFrameLoaderClient
697         https://bugs.webkit.org/show_bug.cgi?id=139761
698
699         Reviewed by Dan Bernstein.
700
701         Also replace @private with @package in all public headers, for consistency.
702
703         * History/WebBackForwardList.h:
704         * History/WebHistory.h:
705         * Misc/WebDownload.h:
706         * WebCoreSupport/WebFrameLoaderClient.mm:
707         * WebView/WebArchive.h:
708         * WebView/WebDataSource.h:
709         * WebView/WebFrame.h:
710         * WebView/WebFrameView.h:
711         * WebView/WebPreferences.h:
712         * WebView/WebResource.h:
713
714 2014-12-17  Dan Bernstein  <mitz@apple.com>
715
716         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
717         https://bugs.webkit.org/show_bug.cgi?id=139760
718
719         Reviewed by Anders Carlsson.
720
721         * Configurations/WebKitLegacy.xcconfig:
722
723 2014-12-17  Andreas Kling  <akling@apple.com>
724
725         Purge PassRefPtr from Frame.
726         <https://webkit.org/b/139731>
727
728         Reviewed by Anders Carlsson.
729
730         * WebCoreSupport/WebFrameLoaderClient.mm:
731         (WebFrameLoaderClient::transitionToCommittedForNewPage):
732         * WebView/WebFrame.mm:
733         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
734         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
735         * WebView/WebFrameInternal.h:
736
737 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
738
739         Implement and adopt two new TextIndicator presentation animations
740         https://bugs.webkit.org/show_bug.cgi?id=139715
741         <rdar://problem/19237945>
742
743         Reviewed by Anders Carlsson.
744
745         * WebView/WebActionMenuController.mm:
746         (-[WebActionMenuController _showTextIndicator]):
747         * WebView/WebHTMLView.mm:
748         (-[WebHTMLView quickLookWithEvent:]):
749         Remove the completionHandler from text indicator presentation.
750
751         * WebView/WebImmediateActionController.mm:
752         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
753         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
754         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
755         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
756         (-[WebImmediateActionController _menuItemForDataDetectedText]):
757         (-[WebImmediateActionController _animationControllerForText]):
758         (-[WebImmediateActionController _showTextIndicator]):
759         Forward immediate action gesture recognizer animation progress
760         to TextIndicator. Force us to keep the selection when immediate
761         action popovers steal first responder status from the WebView.
762         If the Lookup range is equal to the selection range, use a Crossfade
763         animation; otherwise, use a FadeIn animation.
764
765         * WebView/WebView.mm:
766         (-[WebView _setMaintainsInactiveSelection:]):
767         (-[WebView maintainsInactiveSelection]):
768         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
769         (-[WebView _setTextIndicator:fadeOut:]):
770         (-[WebView _clearTextIndicator]):
771         (-[WebView _setTextIndicatorAnimationProgress:]):
772         (-[WebView _showDictionaryLookupPopup:]):
773         (-[WebView _dictionaryLookupPopoverWillClose:]):
774         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
775         Remove the completionHandler from text indicator presentation.
776         Add a _setMaintainsInactiveSelection, which allows WebKit internals
777         to change the return value of -maintainsInactiveSelection, allowing
778         us to keep the selection alive when the WebView loses first responder status.
779
780         * WebView/WebViewData.h:
781         * WebView/WebViewInternal.h:
782
783 2014-12-16  Andreas Kling  <akling@apple.com>
784
785         Use Ref for SecurityOrigin.
786         <https://webkit.org/b/139710>
787
788         Reviewed by Anders Carlsson.
789
790         * Storage/WebStorageTrackerClient.mm:
791         (WebStorageTrackerClient::dispatchDidModifyOrigin):
792         * WebView/WebView.mm:
793         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
794         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
795
796 2014-12-16  Beth Dakin  <bdakin@apple.com>
797
798         Crash getting default animation controller for some text
799         https://bugs.webkit.org/show_bug.cgi?id=139712
800         -and corresponding-
801         rdar://problem/19271707
802
803         Reviewed by Tim Horton.
804
805         Must null-check the range.
806         * WebView/WebImmediateActionController.mm:
807         (-[WebImmediateActionController _animationControllerForText]):
808
809 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
810
811         Immediate action popovers can get stuck open
812         https://bugs.webkit.org/show_bug.cgi?id=139709
813         <rdar://problem/19270279>
814
815         Reviewed by Beth Dakin.
816
817         * WebView/WebImmediateActionController.mm:
818         (-[WebImmediateActionController _clearImmediateActionState]):
819         Don't clear the animation controller; it breaks things and was unnecessary.
820
821 2014-12-16  Tim Horton  <timothy_horton@apple.com>
822
823         Disable TextIndication for Lookup immediate actions
824         https://bugs.webkit.org/show_bug.cgi?id=139684
825
826         Reviewed by Anders Carlsson.
827
828         * WebView/WebView.mm:
829         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
830
831 2014-12-15  Beth Dakin  <bdakin@apple.com>
832
833         Build fix.
834
835         * WebView/WebImmediateActionController.mm:
836
837 2014-12-15  Beth Dakin  <bdakin@apple.com>
838
839         Speculative build fix.
840
841         * WebView/WebView.mm:
842         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
843         * WebView/WebViewInternal.h:
844
845 2014-12-15  Beth Dakin  <bdakin@apple.com>
846
847         Make lookup an immediate action instead of an action menu item
848         https://bugs.webkit.org/show_bug.cgi?id=139661
849         -and corresponding-
850         rdar://problem/19198414
851
852         Reviewed by Tim Horton.
853
854         Remove the lookup menu items and non-unused static function associated with 
855         lookup.
856         * WebView/WebActionMenuController.mm:
857         (-[WebActionMenuController _defaultMenuItemsForText]):
858         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
859         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
860         (-[WebActionMenuController _createActionMenuItemForTag:]):
861         (-[WebActionMenuController _lookupText:]): Deleted.
862         (performDictionaryLookupForSelection): Deleted.
863         (performDictionaryLookupForRange): Deleted.
864
865         Set the defaultAnimationController to the lookup-provided animation controller 
866         when appropriate.
867         * WebView/WebImmediateActionController.mm:
868         (-[WebImmediateActionController _defaultAnimationController]):
869         (dictionaryPopupInfoForRange):
870         (-[WebImmediateActionController _animationControllerForText]):
871
872         New type.
873         * WebView/WebUIDelegatePrivate.h:
874
875         New function to get the lookup animation controller.
876         * WebView/WebView.mm:
877         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
878         * WebView/WebViewInternal.h:
879
880 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
881
882         Implement Data Detectors immediate actions for Legacy WebKit
883         https://bugs.webkit.org/show_bug.cgi?id=139619
884         <rdar://problem/19198539>
885
886         Reviewed by Beth Dakin.
887
888         * WebView/WebImmediateActionController.mm:
889         (-[WebImmediateActionController _menuItemForDataDetectedText]):
890         Note that this action context is only for immediate actions.
891
892 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
893
894         Addressing post-review comments in r177035
895         https://bugs.webkit.org/show_bug.cgi?id=139557
896
897         Reviewed by Darin Adler.
898
899         * WebView/WebActionMenuController.mm:
900         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
901
902 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
903
904         Implement Data Detectors immediate actions for Legacy WebKit
905         https://bugs.webkit.org/show_bug.cgi?id=139619
906         <rdar://problem/19198539>
907
908         Reviewed by Eric Carlson.
909
910         * WebView/WebHTMLView.mm:
911         (-[WebHTMLView mouseDown:mouseDown:]):
912         Send mouseDown along to the WebImmediateActionController too.
913
914         * WebView/WebImmediateActionController.h:
915         * WebView/WebImmediateActionController.mm:
916         (-[WebImmediateActionController webViewClosed]):
917         (-[WebImmediateActionController webView:willHandleMouseDown:]):
918         (-[WebImmediateActionController _cancelImmediateAction]):
919         (-[WebImmediateActionController _clearImmediateActionState]):
920         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
921         (-[WebImmediateActionController _defaultAnimationController]):
922         (-[WebImmediateActionController _updateImmediateActionItem]):
923         (-[WebImmediateActionController _menuItemForDataDetectedText]):
924         (-[WebImmediateActionController _showTextIndicator]):
925         (-[WebImmediateActionController _hideTextIndicator]):
926         Copy most of the DataDetectors implementation into WebImmediateActionController.
927
928         * WebView/WebUIDelegatePrivate.h:
929         Add a new type.
930
931         * WebView/WebView.mm:
932         (-[WebView _commonInitializationWithFrameName:groupName:]):
933         Temporarily disable action menus.
934
935         (-[WebView _immediateActionController]):
936         * WebView/WebViewInternal.h:
937
938 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
939
940         Delete Notation because we don't use it
941         https://bugs.webkit.org/show_bug.cgi?id=139171
942
943         Reviewed by Kent Tamura.
944
945         * MigrateHeaders.make:
946
947 2014-12-14  Andreas Kling  <akling@apple.com>
948
949         Replace PassRef with Ref/Ref&& across the board.
950         <https://webkit.org/b/139587>
951
952         Reviewed by Darin Adler.
953
954         * WebCoreSupport/WebEditorClient.mm:
955         (WebEditorClient::shouldApplyStyle):
956         * WebCoreSupport/WebVisitedLinkStore.h:
957         * WebCoreSupport/WebVisitedLinkStore.mm:
958         (WebVisitedLinkStore::create):
959
960 2014-12-11  Dan Bernstein  <mitz@apple.com>
961
962         Fix a leak introduced in r177199.
963
964         Reviewed by Anders Carlsson.
965
966         * WebView/WebImmediateActionController.mm:
967         (-[WebImmediateActionController _updateImmediateActionItem]):
968
969 2014-12-11  Beth Dakin  <bdakin@apple.com>
970
971         WK1: Need new SPI for Webkit clients to override default immediate action
972         https://bugs.webkit.org/show_bug.cgi?id=139568
973         -and corresponding-
974         rdar://problem/19225448
975
976         Reviewed by Dan Bernstein.
977
978         Call SPI giving clients a chance to override the default behavior.
979         * WebView/WebImmediateActionController.mm:
980         (-[WebImmediateActionController _updateImmediateActionItem]):
981
982         New SPI.
983         * WebView/WebUIDelegatePrivate.h:
984
985 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
986
987         Move the preview popover to WebImmediateActionController
988         https://bugs.webkit.org/show_bug.cgi?id=139563
989         <rdar://problem/19208291>
990
991         Reviewed by Beth Dakin.
992
993         * WebView/WebActionMenuController.mm:
994         (-[WebActionMenuController _defaultMenuItemsForLink]):
995         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
996         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
997         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
998         * WebView/WebImmediateActionController.h:
999         * WebView/WebImmediateActionController.mm:
1000         (-[WebImmediateActionController webViewClosed]):
1001         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1002         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1003         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1004         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1005         (-[WebImmediateActionController _updateImmediateActionItem]):
1006         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
1007         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
1008         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
1009         Move page preview popover related code to WebImmediateActionController.
1010
1011         * WebView/WebUIDelegatePrivate.h:
1012         Add a link preview type.
1013
1014         * WebView/WebView.mm:
1015         (-[WebView _commonInitializationWithFrameName:groupName:]):
1016         Pass the gesture recognizer to the WebImmediateActionController.
1017
1018 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1019
1020         Fix the build.
1021
1022         * WebView/WebImmediateActionController.h:
1023         * WebView/WebImmediateActionController.mm:
1024
1025 2014-12-11  Anders Carlsson  <andersca@apple.com>
1026
1027         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
1028         https://bugs.webkit.org/show_bug.cgi?id=139547
1029
1030         Reviewed by Sam Weinig.
1031
1032         * WebView/WebView.mm:
1033         (+[WebView _handleMemoryWarning]):
1034
1035 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
1036
1037         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
1038         https://bugs.webkit.org/show_bug.cgi?id=139504
1039         rdar://problem/19034674
1040
1041         Reviewed by Enrica Casucci.
1042
1043         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
1044
1045         * WebCoreSupport/WebEditorClient.h:
1046         * WebCoreSupport/WebEditorClient.mm:
1047         (WebEditorClient::discardedComposition):
1048
1049 2014-12-10  Anders Carlsson  <andersca@apple.com>
1050
1051         Get rid of the storage strategy
1052         https://bugs.webkit.org/show_bug.cgi?id=139519
1053
1054         Reviewed by Antti Koivisto.
1055
1056         * WebCoreSupport/WebPlatformStrategies.h:
1057         * WebCoreSupport/WebPlatformStrategies.mm:
1058         (WebPlatformStrategies::createStorageStrategy): Deleted.
1059
1060 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1061
1062         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
1063         https://bugs.webkit.org/show_bug.cgi?id=139529
1064         <rdar://problem/19213620>
1065
1066         Reviewed by Beth Dakin.
1067
1068         * WebView/WebActionMenuController.mm:
1069         (-[WebActionMenuController _copySelection:]):
1070         (-[WebActionMenuController _paste:]):
1071         Use the copy: and paste: methods on WebView so that we traverse subviews
1072         when trying to respond, otherwise these actions don't work in subframes.
1073
1074 2014-12-10  Beth Dakin  <bdakin@apple.com>
1075
1076         WK1: Add initial support for immediate actions
1077         https://bugs.webkit.org/show_bug.cgi?id=139522
1078
1079         Reviewed by Dan Bernstein.
1080
1081         This basic implementation of the controller will use the delegate methods to 
1082         perform and cache a HitTest when relevant. Future patches will patch 
1083         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
1084         immediate action that should be taken.
1085         * WebView/WebImmediateActionController.h: Added.
1086         * WebView/WebImmediateActionController.mm: Added.
1087         (-[WebImmediateActionController webViewClosed]):
1088         (-[WebImmediateActionController _clearImmediateActionState]):
1089         (-[WebImmediateActionController performHitTestAtPoint:]):
1090         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1091         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1092         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1093         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1094         (-[WebImmediateActionController _updateImmediateActionItem]):
1095
1096         New enum for immediate action types.
1097         * WebView/WebUIDelegatePrivate.h:
1098
1099         Create an NSImmediateActionGestureRecognizer if possible and a controller.
1100         * WebView/WebView.mm:
1101         (-[WebView _commonInitializationWithFrameName:groupName:]):
1102         (-[WebView _close]):
1103         * WebView/WebViewData.h:
1104         * WebView/WebViewData.mm:
1105         (-[WebViewPrivate dealloc]):
1106
1107 2014-12-08  Anders Carlsson  <andersca@apple.com>
1108
1109         Use the new storage namespace provider in WebKit1
1110         https://bugs.webkit.org/show_bug.cgi?id=139425
1111
1112         Reviewed by Tim Horton.
1113
1114         * WebView/WebView.mm:
1115         (-[WebView _commonInitializationWithFrameName:groupName:]):
1116         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1117         Set the storage namespace provider from the web page group.
1118
1119 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1120
1121         Should have copy and paste items in all text menus
1122         https://bugs.webkit.org/show_bug.cgi?id=139510
1123         <rdar://problem/19198388>
1124
1125         Reviewed by Beth Dakin.
1126
1127         * WebView/WebActionMenuController.mm:
1128         (-[WebActionMenuController _defaultMenuItemsForText]):
1129         Add a disabled paste menu item into the read-only text menu.
1130
1131         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1132         Add a disabled copy menu item into the editable whitespace text menu.
1133
1134 2014-12-10  Anders Carlsson  <andersca@apple.com>
1135
1136         Add WebStorageNamespaceProvider::closeLocalStorage
1137         https://bugs.webkit.org/show_bug.cgi?id=139502
1138
1139         Reviewed by Tim Horton.
1140
1141         * WebView/WebView.mm:
1142         (+[WebView _applicationWillTerminate]):
1143         Call WebStorageNamespaceProvider::closeLocalStorage.
1144
1145 2014-12-09  Commit Queue  <commit-queue@webkit.org>
1146
1147         Unreviewed, rolling out r177037.
1148         https://bugs.webkit.org/show_bug.cgi?id=139464
1149
1150         broke ~50 API tests (Requested by thorton on #webkit).
1151
1152         Reverted changeset:
1153
1154         "Use the new storage namespace provider in WebKit1"
1155         https://bugs.webkit.org/show_bug.cgi?id=139425
1156         http://trac.webkit.org/changeset/177037
1157
1158 2014-12-08  Anders Carlsson  <andersca@apple.com>
1159
1160         Use the new storage namespace provider in WebKit1
1161         https://bugs.webkit.org/show_bug.cgi?id=139425
1162
1163         Reviewed by Tim Horton.
1164
1165         * WebView/WebView.mm:
1166         (-[WebView _commonInitializationWithFrameName:groupName:]):
1167         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1168         Set the storage namespace provider from the web page group.
1169
1170 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
1171
1172         Delete Node::boundingBox()
1173         https://bugs.webkit.org/show_bug.cgi?id=139333
1174
1175         Reviewed by Zalan Bujtas.
1176
1177         * WebView/WebActionMenuController.mm:
1178         (elementBoundingBoxInWindowCoordinatesFromNode): Use
1179         RenderObject::absoluteBoundingBoxRect().
1180
1181 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
1182
1183         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
1184         https://bugs.webkit.org/show_bug.cgi?id=138843
1185         rdar://problem/18793695
1186
1187         Reviewed by Dan Bernstein.
1188
1189         * Panels/WebAuthenticationPanel.m:
1190         (-[WebAuthenticationPanel cancel:]):
1191         (-[WebAuthenticationPanel logIn:]):
1192         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
1193         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
1194         that only when using an old NSWindow API.
1195
1196 2014-12-08  Beth Dakin  <bdakin@apple.com>
1197
1198         Copy and Lookup menu items should be disabled when something is not copyable
1199         https://bugs.webkit.org/show_bug.cgi?id=139423
1200
1201         Reviewed by Tim Horton.
1202
1203         Disable both lookup and copy when a HitTestResult does not allow copy.
1204         * WebView/WebActionMenuController.mm:
1205
1206         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
1207         disable state otherwise.
1208         * WebView/WebView.mm:
1209         (-[WebView _commonInitializationWithFrameName:groupName:]):
1210
1211 2014-12-08  Anders Carlsson  <andersca@apple.com>
1212
1213         Adding user content to a group should force that group to be created
1214         https://bugs.webkit.org/show_bug.cgi?id=139421
1215         rdar://problem/19180108
1216
1217         Reviewed by Sam Weinig.
1218
1219         * WebCoreSupport/WebViewGroup.h:
1220         Store the local storage database path in the group.
1221
1222         * WebCoreSupport/WebViewGroup.mm:
1223         (WebViewGroup::getOrCreate):
1224         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
1225         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
1226
1227         (WebViewGroup::WebViewGroup):
1228         Initialize the new member variable.
1229
1230         (WebViewGroup::storageNamespaceProvider):
1231         Create the namespace provider lazily.
1232
1233         * WebView/WebView.mm:
1234         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1235         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1236         Use getOrCreate instead of get.
1237
1238 2014-12-08  Anders Carlsson  <andersca@apple.com>
1239
1240         WebStorageNamespaceProvider should know about its local storage database path
1241         https://bugs.webkit.org/show_bug.cgi?id=139413
1242
1243         Reviewed by Andreas Kling.
1244
1245         * WebCoreSupport/WebViewGroup.h:
1246         * WebCoreSupport/WebViewGroup.mm:
1247         (WebViewGroup::getOrCreate):
1248         (WebViewGroup::WebViewGroup):
1249         * WebView/WebView.mm:
1250         (-[WebView _commonInitializationWithFrameName:groupName:]):
1251         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1252         (-[WebView setGroupName:]):
1253         (-[WebView groupName]): Deleted.
1254
1255 2014-12-08  Daniel Bates  <dabates@apple.com>
1256
1257         [iOS] Fix the WebKit build with the public SDK
1258
1259         Include header NSURLDownloadSPI.h.
1260
1261         * WebCoreSupport/WebFrameLoaderClient.mm:
1262
1263 2014-12-07  Dan Bernstein  <mitz@apple.com>
1264
1265         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
1266         https://bugs.webkit.org/show_bug.cgi?id=139348
1267
1268         Reviewed by Anders Carlsson.
1269
1270         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
1271         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
1272         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
1273         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
1274         avoiding the ambiguity.
1275
1276         * WebView/WebActionMenuController.mm:
1277         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1278
1279 2014-12-06  Anders Carlsson  <andersca@apple.com>
1280
1281         Add a stubbed out version of WebStorageNamespaceProvider
1282         https://bugs.webkit.org/show_bug.cgi?id=139213
1283
1284         Reviewed by Sam Weinig.
1285
1286         * WebCoreSupport/WebViewGroup.h:
1287         (WebViewGroup::storageNamespaceProvider):
1288         * WebCoreSupport/WebViewGroup.mm:
1289         (WebViewGroup::getOrCreate):
1290         (WebViewGroup::WebViewGroup):
1291         Give WebViewGroup a storage namespace provider.
1292
1293 2014-12-06  Anders Carlsson  <andersca@apple.com>
1294
1295         Fix build with newer versions of clang.
1296         rdar://problem/18978687
1297
1298         Add missing overrides and missing casts.
1299
1300         * Storage/WebDatabaseManagerClient.h:
1301         * Storage/WebStorageTrackerClient.h:
1302         * WebCoreSupport/WebChromeClient.h:
1303         * WebCoreSupport/WebFrameLoaderClient.h:
1304         * WebCoreSupport/WebInspectorClient.h:
1305         * WebView/WebDataSource.mm:
1306         (-[WebDataSource _makeRepresentation]):
1307         * WebView/WebFrameView.mm:
1308         (-[WebFrameView _makeDocumentViewForDataSource:]):
1309
1310 2014-12-05  Tim Horton  <timothy_horton@apple.com>
1311
1312         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
1313         https://bugs.webkit.org/show_bug.cgi?id=139306
1314         <rdar://problem/19157955>
1315
1316         Reviewed by Beth Dakin.
1317
1318         * WebView/WebView.mm:
1319         (-[WebView _commonInitializationWithFrameName:groupName:]):
1320         (-[WebView _initWithFrame:frameName:groupName:]):
1321         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
1322
1323 2014-12-05  David Kilzer  <ddkilzer@apple.com>
1324
1325         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
1326         <http://webkit.org/b/139286>
1327
1328         Reviewed by Daniel Bates.
1329
1330         * Configurations/FeatureDefines.xcconfig: Switch back to using
1331         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
1332
1333 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
1334
1335         Fix the 32-bit build.
1336
1337         * WebView/WebView.mm:
1338         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1339
1340 2014-12-04  Tim Horton  <timothy_horton@apple.com>
1341
1342         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
1343         https://bugs.webkit.org/show_bug.cgi?id=139252
1344         <rdar://problem/19140827>
1345
1346         Reviewed by Anders Carlsson.
1347
1348         * WebView/WebView.mm:
1349         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1350         Adjust to the WebCore changes.
1351
1352 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1353
1354         Implement action menus for tel: URLs
1355         https://bugs.webkit.org/show_bug.cgi?id=139240
1356         <rdar://problem/19115662>
1357
1358         Reviewed by Anders Carlsson.
1359
1360         * WebView/WebActionMenuController.mm:
1361         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1362         Make sure to use the newly created currentActionContext... everywhere.
1363
1364 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1365
1366         Implement action menus for tel: URLs
1367         https://bugs.webkit.org/show_bug.cgi?id=139240
1368         <rdar://problem/19115662>
1369
1370         Reviewed by Anders Carlsson.
1371
1372         * WebView/WebActionMenuController.mm:
1373         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1374         Make sure to use the newly created currentActionContext.
1375
1376 2014-12-03  Beth Dakin  <bdakin@apple.com>
1377
1378         <input> elements get whitespace action menu instead of editable text menu
1379         https://bugs.webkit.org/show_bug.cgi?id=139241
1380         -and corresponding-
1381         rdar://problem/19072083
1382
1383         Reviewed by Sam Weinig.
1384
1385         We should disallow shadow content in the hit test. This is the default and it is 
1386         how context menus behave. We originally wanted to text inside shadow content so 
1387         that we could find the text, but the new function I added to HitTestResult will 
1388         allow that.
1389         * WebView/WebActionMenuController.mm:
1390         (-[WebActionMenuController performHitTestAtPoint:]):
1391
1392         Adjust to the fact that we don’t hit test shadow content any more.
1393         (-[WebActionMenuController focusAndSelectHitTestResult]):
1394
1395         Offer the text menus for text inside form controls.
1396         (-[WebActionMenuController _defaultMenuItems]):
1397
1398 2014-12-03  Tim Horton  <timothy_horton@apple.com>
1399
1400         Implement action menus for tel: URLs
1401         https://bugs.webkit.org/show_bug.cgi?id=139240
1402         <rdar://problem/19115662>
1403
1404         Reviewed by Anders Carlsson.
1405
1406         * WebView/WebActionMenuController.mm:
1407         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1408         Rename this function as it will work for both mailto and tel URLs.
1409         Adjust it to use contextForView:.
1410
1411         (-[WebActionMenuController webView:willHandleMouseDown:]):
1412         (-[WebActionMenuController prepareForMenu:withEvent:]):
1413         (-[WebActionMenuController didCloseMenu:withEvent:]):
1414         (-[WebActionMenuController _defaultMenuItems]):
1415         Don't check the menu type when going to interact with _currentActionContext.
1416         We'll only have a _currentActionContext if we have a data detected item,
1417         and there are multiple menu types that end up using DDActionContext.
1418
1419         * WebView/WebUIDelegatePrivate.h:
1420         Add a new type.
1421
1422 2014-12-03  Anders Carlsson  <andersca@apple.com>
1423
1424         Set a visited link store when creating a simple WebView
1425         https://bugs.webkit.org/show_bug.cgi?id=139234
1426         <rdar://problem/19132978>
1427
1428         Reviewed by Sam Weinig.
1429
1430         * WebView/WebView.mm:
1431         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1432
1433 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1434
1435         Fix the build.
1436
1437         * WebCoreSupport/WebFrameLoaderClient.mm:
1438
1439 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1440
1441         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1442         https://bugs.webkit.org/show_bug.cgi?id=139149
1443
1444         Reviewed by Anders Carlsson.
1445
1446         This changes API behavior. I think that it's OK, because existing behavior made no sense.
1447         We used to delete caches from disk, but they were still active in memory. Now we also
1448         obsolete them in memory, so documents that use a cache still work, but new ones don't
1449         pick one up.
1450
1451         * WebCoreSupport/WebApplicationCache.mm:
1452         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
1453         need to delete in-momry caches too. Keep existing behavior.
1454         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
1455         that properly deletes caches.
1456
1457 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1458
1459         Remove a SnowLeopard-era quirk for QuickLook
1460         https://bugs.webkit.org/show_bug.cgi?id=139208
1461         <rdar://problem/19121822>
1462
1463         Reviewed by Alexey Proskuryakov.
1464
1465         * WebCoreSupport/WebFrameLoaderClient.h:
1466         * WebCoreSupport/WebFrameLoaderClient.mm:
1467
1468 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1469
1470         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
1471         https://bugs.webkit.org/show_bug.cgi?id=139204
1472
1473         Reviewed by Anders Carlsson.
1474
1475         * WebView/WebView.mm:
1476         (-[WebView _commonInitializationWithFrameName:groupName:]):
1477         (-[WebView _showDictionaryLookupPopup:]):
1478         * WebView/WebViewData.h:
1479         Work around this by delaying the softlinking (and setting up the notification
1480         observer) until we actually need it. There's still an underlying bug, but
1481         this will fix the test.
1482
1483 2014-12-02  Beth Dakin  <bdakin@apple.com>
1484
1485         Yet another build fix.
1486
1487         * WebView/WebActionMenuController.mm:
1488         (-[WebActionMenuController _defaultMenuItemsForLink]):
1489
1490 2014-12-02  Beth Dakin  <bdakin@apple.com>
1491
1492         Build fix.
1493
1494         * WebView/WebActionMenuController.mm:
1495         (-[WebActionMenuController _defaultMenuItemsForLink]):
1496
1497 2014-12-02  Beth Dakin  <bdakin@apple.com>
1498
1499         More build fixing.
1500
1501         * WebView/WebActionMenuController.mm:
1502         (-[WebActionMenuController _defaultMenuItemsForLink]):
1503
1504 2014-12-02  Beth Dakin  <bdakin@apple.com>
1505
1506         Should use standardQuickLookMenuItem for apps that don't implement customizations
1507         https://bugs.webkit.org/show_bug.cgi?id=139193
1508         -and corresponding-
1509         rdar://problem/18944696
1510
1511         Reviewed by Anders Carlsson.
1512
1513         Use [NSMenuItem standardQuickLookMenuItem].
1514         * WebView/WebActionMenuController.mm:
1515         (-[WebActionMenuController _defaultMenuItemsForLink]):
1516
1517         Delegate methods to set up the standardQuickLookMenuItem.
1518         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
1519         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
1520         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
1521
1522         Remove all of the old QLPreviewBubble code.
1523         (-[WebActionMenuController _createActionMenuItemForTag:]):
1524         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
1525
1526 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1527
1528         Fix the build.
1529
1530         * WebView/WebViewData.h:
1531
1532 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1533
1534         Implement Lookup transition from selection for Legacy WebKit
1535         https://bugs.webkit.org/show_bug.cgi?id=139180
1536         <rdar://problem/19067172>
1537
1538         Reviewed by Beth Dakin.
1539
1540         * WebView/DictionaryPopupInfo.h: Added.
1541         Split DictionaryPopupInfo out into its own file.
1542
1543         * WebView/WebActionMenuController.mm:
1544         (-[WebActionMenuController _lookupText:]):
1545         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
1546
1547         (performDictionaryLookupForSelection):
1548         (performDictionaryLookupForRange):
1549         Plumb the transition style through these helpers.
1550         Create a TextIndicator from the selection range.
1551
1552         * WebView/WebHTMLView.mm:
1553         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1554         Make use of TextIndicator (and DictionaryPopupInfo, and the new
1555         _showDictionaryLookupPopup on WebView) to add a transition from blue
1556         when performing Lookup from the context menu.
1557
1558         (-[WebHTMLView quickLookWithEvent:]):
1559         Remove our TextIndicator whenever a normal three-finger-tap event
1560         comes through, as it will have its own indication.
1561
1562         * WebView/WebView.mm:
1563         (-[WebView _commonInitializationWithFrameName:groupName:]):
1564         (-[WebView _dictionaryLookupPopoverWillClose:]):
1565         Register for the LUNotificationPopoverWillClose notification and remove
1566         our TextIndicator when it is called, just like in WebKit2.
1567         Deregistration is already handled in _close.
1568
1569         (-[WebView _showDictionaryLookupPopup:]):
1570         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
1571         if the relevant API is available.
1572
1573         * WebView/WebViewInternal.h:
1574
1575 2014-12-02  Anders Carlsson  <andersca@apple.com>
1576
1577         Remove visited link handling from PageGroup
1578         https://bugs.webkit.org/show_bug.cgi?id=139185
1579
1580         Reviewed by Sam Weinig.
1581
1582         * History/WebHistory.mm:
1583         (-[WebHistoryPrivate removeItemForURLString:]):
1584         (-[WebHistoryPrivate removeAllItems]):
1585         (+[WebHistory setOptionalSharedHistory:]):
1586         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1587         (+[WebHistory _removeAllVisitedLinks]):
1588         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
1589         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
1590         * History/WebHistoryInternal.h:
1591         * WebCoreSupport/WebChromeClient.h:
1592         * WebCoreSupport/WebChromeClient.mm:
1593         (WebChromeClient::populateVisitedLinks): Deleted.
1594         * WebView/WebView.mm:
1595         (-[WebView addVisitedLinks:]):
1596         (-[WebView removeVisitedLink:]):
1597
1598 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1599
1600         Try to fix the Mac build.
1601
1602         * WebView/WebView.mm:
1603         (-[WebView _commonInitializationWithFrameName:groupName:]):
1604         (-[WebView _close]):
1605
1606 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1607
1608         Fix the iOS build.
1609
1610         * WebView/WebActionMenuController.h:
1611         * WebView/WebActionMenuController.mm:
1612         * WebView/WebHTMLView.mm:
1613         (-[WebHTMLView scrollWheel:scrollWheel:]):
1614         (-[WebHTMLView mouseDown:mouseDown:]):
1615         * WebView/WebView.mm:
1616         * WebView/WebViewData.h:
1617         * WebView/WebViewData.mm:
1618         (-[WebViewPrivate dealloc]):
1619         * WebView/WebViewInternal.h:
1620
1621 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1622
1623         Implement yellow highlight for WebKit1 data detectors
1624         https://bugs.webkit.org/show_bug.cgi?id=138956
1625         <rdar://problem/18992185>
1626
1627         Reviewed by Beth Dakin.
1628
1629         * WebView/WebActionMenuController.h:
1630         * WebView/WebActionMenuController.mm:
1631         (-[WebActionMenuController webView:willHandleMouseDown:]):
1632         (-[WebActionMenuController webView:didHandleScrollWheel:]):
1633         (-[WebActionMenuController prepareForMenu:withEvent:]):
1634         (-[WebActionMenuController didCloseMenu:withEvent:]):
1635         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1636         (-[WebActionMenuController _showTextIndicator]):
1637         (-[WebActionMenuController _hideTextIndicator]):
1638         (-[WebActionMenuController _dismissActionMenuPopovers]):
1639         Copy the WebKit2 WKActionMenuController TextIndicator implementation
1640         into WebActionMenuController. The only significant difference is
1641         that we build the TextIndicator right at menu construction time
1642         instead of in the Web process.
1643
1644         * WebView/WebHTMLView.mm:
1645         (-[WebHTMLView scrollWheel:]):
1646         Let the WebActionMenuController know that we're handling a scroll.
1647
1648         (-[WebHTMLView mouseDown:]):
1649         Let the WebActionMenuController know that we're handling a mouseDown.
1650
1651         * WebView/WebView.mm:
1652         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1653         (-[WebView _clearTextIndicator]):
1654         (-[WebView _actionMenuController]):
1655         (-[WebView _convertRectFromRootView:]): Deleted.
1656         * WebView/WebViewData.h:
1657         * WebView/WebViewData.mm:
1658         * WebView/WebViewInternal.h:
1659         Keep a TextIndicatorWindow on WebView, just like WKView does.
1660         Expose the WebActionMenuController on WebView (internally).
1661
1662 2014-12-01  Anders Carlsson  <andersca@apple.com>
1663
1664         Remove old site specific quirks code that was added in 2009
1665         https://bugs.webkit.org/show_bug.cgi?id=139141
1666
1667         Reviewed by Antti Koivisto.
1668
1669         * WebCoreSupport/WebFrameNetworkingContext.h:
1670         * WebCoreSupport/WebFrameNetworkingContext.mm:
1671         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
1672
1673 2014-11-30  Anders Carlsson  <andersca@apple.com>
1674
1675         Fix a test failure.
1676
1677         * History/WebHistory.mm:
1678         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1679         Call through to the visited link store.
1680
1681         (+[WebHistory _removeAllVisitedLinks]):
1682         Ditto.
1683
1684         * WebCoreSupport/WebVisitedLinkStore.mm:
1685         (WebVisitedLinkStore::isLinkVisited):
1686         Make sure to populate visited links.
1687
1688 2014-11-30  Anders Carlsson  <andersca@apple.com>
1689
1690         Switch over to the visited link store from the WebViewGroup
1691         https://bugs.webkit.org/show_bug.cgi?id=139112
1692
1693         Reviewed by Sam Weinig.
1694
1695         * WebView/WebView.mm:
1696         (-[WebView _commonInitializationWithFrameName:groupName:]):
1697         (-[WebView setGroupName:]):
1698
1699 2014-11-30  Anders Carlsson  <andersca@apple.com>
1700
1701         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
1702         https://bugs.webkit.org/show_bug.cgi?id=139111
1703
1704         Reviewed by Sam Weinig.
1705
1706         * WebCoreSupport/WebVisitedLinkStore.h:
1707         * WebCoreSupport/WebVisitedLinkStore.mm:
1708         (WebVisitedLinkStore::removeVisitedLink):
1709         * WebView/WebView.mm:
1710         (-[WebView removeVisitedLink:]):
1711
1712 2014-11-29  Anders Carlsson  <andersca@apple.com>
1713
1714         Populate visited links
1715         https://bugs.webkit.org/show_bug.cgi?id=139101
1716
1717         Reviewed by Sam Weinig.
1718
1719         * History/WebHistory.mm:
1720         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
1721         Helper function that adds all visited link to the given store.
1722
1723         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
1724         Call the private method.
1725
1726         * History/WebHistoryInternal.h:
1727         * WebCoreSupport/WebVisitedLinkStore.h:
1728         Add new members.
1729
1730         * WebCoreSupport/WebVisitedLinkStore.mm:
1731         (WebVisitedLinkStore::addVisitedLink):
1732         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
1733
1734         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1735         Implement this. First try the delegate, then try the shared history.
1736
1737         (WebVisitedLinkStore::addVisitedLinkHash):
1738         Factor code that adds the link to the hash table into a separate function.
1739
1740         * WebView/WebView.mm:
1741         (-[WebView addVisitedLinks:]):
1742         Add the visited links to the store.
1743
1744 2014-11-29  Anders Carlsson  <andersca@apple.com>
1745
1746         More work on the legacy WebKit visited link store
1747         https://bugs.webkit.org/show_bug.cgi?id=139100
1748
1749         Reviewed by Sam Weinig.
1750
1751         * History/WebHistory.mm:
1752         (+[WebHistory setOptionalSharedHistory:]):
1753         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
1754
1755         * WebCoreSupport/WebVisitedLinkStore.h:
1756         * WebCoreSupport/WebVisitedLinkStore.mm:
1757         (visitedLinkStores):
1758         (WebVisitedLinkStore::WebVisitedLinkStore):
1759         (WebVisitedLinkStore::~WebVisitedLinkStore):
1760         Keep track of live visited link stores.
1761
1762         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
1763         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
1764
1765         (WebVisitedLinkStore::removeAllVisitedLinks):
1766         Iterate over all live link stores and remove their links.
1767
1768         (WebVisitedLinkStore::isLinkVisited):
1769         Populate visited links and check if our hash table contains the link.
1770
1771         (WebVisitedLinkStore::addVisitedLink):
1772         Add the link hash to the table.
1773
1774         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1775         Add stub.
1776
1777         (WebVisitedLinkStore::removeVisitedLinkHashes):
1778         Clear out the hash table.
1779
1780 2014-11-27  Anders Carlsson  <andersca@apple.com>
1781
1782         Add a stubbed out WebVisitedLinkStore to WebViewGroup
1783         https://bugs.webkit.org/show_bug.cgi?id=139066
1784
1785         Reviewed by Antti Koivisto.
1786
1787         * WebCoreSupport/WebViewGroup.h:
1788         (WebViewGroup::visitedLinkStore):
1789         * WebCoreSupport/WebViewGroup.mm:
1790         (WebViewGroup::WebViewGroup):
1791         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1792         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1793         (WebVisitedLinkStore::create):
1794         (WebVisitedLinkStore::WebVisitedLinkStore):
1795         (WebVisitedLinkStore::~WebVisitedLinkStore):
1796         (WebVisitedLinkStore::isLinkVisited):
1797         (WebVisitedLinkStore::addVisitedLink):
1798
1799 2014-11-25  Anders Carlsson  <andersca@apple.com>
1800
1801         Remove user content handling from PageGroup
1802         https://bugs.webkit.org/show_bug.cgi?id=139051
1803
1804         Reviewed by Antti Koivisto.
1805
1806         Use the user content controller in the web view group.
1807
1808         * WebView/WebView.mm:
1809         (-[WebView _injectOutlookQuirksScript]):
1810
1811 2014-11-25  Anders Carlsson  <andersca@apple.com>
1812
1813         Add a user content controller to WebViewGroup and use it for user content
1814         https://bugs.webkit.org/show_bug.cgi?id=139043
1815
1816         Reviewed by Antti Koivisto.
1817
1818         This is another tiny step towards getting rid of user content handling inside PageGroup.
1819
1820         * WebCoreSupport/WebViewGroup.h:
1821         (WebViewGroup::userContentController):
1822         Add a UserContentController member and getter.
1823
1824         * WebCoreSupport/WebViewGroup.mm:
1825         (WebViewGroup::get):
1826         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
1827
1828         (WebViewGroup::WebViewGroup):
1829         Create a user content controller.
1830
1831         * WebView/WebView.mm:
1832         (-[WebView _commonInitializationWithFrameName:groupName:]):
1833         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
1834         set its user content controller in the PageConfiguration.
1835
1836         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1837         Ditto.
1838
1839         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1840         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1841         (+[WebView _removeUserScriptFromGroup:world:url:]):
1842         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
1843         (+[WebView _removeUserScriptsFromGroup:world:]):
1844         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
1845         (+[WebView _removeAllUserContentFromGroup:]):
1846         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
1847
1848         (-[WebView setGroupName:]):
1849         Set the user content controller to the new WebViewGroup's user content controller.
1850
1851 2014-11-21  Jer Noble  <jer.noble@apple.com>
1852
1853         Support multiple signatures of diagnostic logging.
1854         https://bugs.webkit.org/show_bug.cgi?id=138690
1855
1856         Reviewed by Anders Carlsson.
1857
1858         Page::PageClients has been renamed PageConfiguration.
1859
1860         * WebView/WebView.mm:
1861         (-[WebView _commonInitializationWithFrameName:groupName:]):
1862         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1863
1864 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1865
1866         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1867         https://bugs.webkit.org/show_bug.cgi?id=138981
1868
1869         Reviewed by Simon Fraser.
1870
1871         * WebView/WebPreferenceKeysPrivate.h:
1872         * WebView/WebPreferences.mm:
1873         (+[WebPreferences initialize]):
1874         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
1875         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
1876         * WebView/WebPreferencesPrivate.h:
1877         * WebView/WebView.mm:
1878         (-[WebView _preferencesChanged:]):
1879
1880 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1881
1882         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1883         ​https://bugs.webkit.org/show_bug.cgi?id=138960
1884         <rdar://problem/19056715>
1885
1886         Reviewed by Anders Carlsson.
1887
1888         * WebView/WebActionMenuController.mm:
1889         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1890         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1891         Use DataDetectors SPI instead of an explicit blacklist.
1892
1893 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1894
1895         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1896         https://bugs.webkit.org/show_bug.cgi?id=138960
1897         <rdar://problem/19056715>
1898
1899         Reviewed by Beth Dakin.
1900
1901         * WebView/WebActionMenuController.mm:
1902         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1903         Blacklist contact results, because they don't have useful menus. If we
1904         bail before setting up _currentActionContext, we'll still allow fallthrough
1905         to ordinary text actions, avoiding mysterious failure when a contact is detected.
1906
1907         This doesn't break the case that r176351 was intended to fix,
1908         because in that case we were detecting e.g. addresses.
1909
1910 2014-11-21  Anders Carlsson  <andersca@apple.com>
1911
1912         Remove the Timer parameters from timer callbacks
1913         https://bugs.webkit.org/show_bug.cgi?id=138974
1914
1915         Reviewed by Antti Koivisto.
1916
1917         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1918         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1919         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
1920         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1921         * Plugins/WebNetscapePluginStream.h:
1922         * Plugins/WebNetscapePluginStream.mm:
1923         (WebNetscapePluginStream::WebNetscapePluginStream):
1924         (WebNetscapePluginStream::deliverDataTimerFired):
1925
1926 2014-11-21  Anders Carlsson  <andersca@apple.com>
1927
1928         Make memoryCache() return a reference
1929         https://bugs.webkit.org/show_bug.cgi?id=138939
1930
1931         Reviewed by Antti Koivisto.
1932
1933         * Misc/WebCache.mm:
1934         (+[WebCache statistics]):
1935         (+[WebCache emptyInMemoryResources]):
1936         (+[WebCache sizeOfDeadResources:]):
1937         (+[WebCache addImageToCache:forURL:forFrame:]):
1938         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1939         (+[WebCache imageForURL:]):
1940         (+[WebCache setDisabled:]):
1941         (+[WebCache isDisabled]):
1942         * WebView/WebView.mm:
1943         (+[WebView _setCacheModel:]):
1944
1945 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
1946
1947         Remove the remaining vestiges of minimal-ui
1948         https://bugs.webkit.org/show_bug.cgi?id=138890
1949
1950         Reviewed by Sam Weinig.
1951
1952         * History/WebHistoryItem.mm:
1953         * History/WebHistoryItemPrivate.h:
1954
1955 2014-11-20  Tim Horton  <timothy_horton@apple.com>
1956
1957         Cancel DataDetectors menu earlier if we know it can't be presented
1958         https://bugs.webkit.org/show_bug.cgi?id=138922
1959         <rdar://problem/18950441>
1960
1961         Reviewed by Beth Dakin.
1962
1963         * WebView/WebActionMenuController.mm:
1964         (-[WebActionMenuController prepareForMenu:withEvent:]):
1965         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
1966         and use a bigger hammer (removeAllItems).
1967
1968         (-[WebActionMenuController willOpenMenu:withEvent:]):
1969         If we end up with a menu with no items, don't change selection or anything.
1970
1971 2014-11-20  Beth Dakin  <bdakin@apple.com>
1972
1973         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
1974         https://bugs.webkit.org/show_bug.cgi?id=138568
1975         -and corresponding-
1976         rdar://problem/18904600
1977
1978         Reviewed by Tim Horton.
1979
1980         Skip images for lookup.
1981         * WebView/WebActionMenuController.mm:
1982         (performDictionaryLookupForRange):
1983
1984 2014-11-19  Beth Dakin  <bdakin@apple.com>
1985
1986         Invoking an action menu on a selection should result in the text menu
1987         https://bugs.webkit.org/show_bug.cgi?id=138892
1988         -and corresponding-
1989         rdar://problem/18996776
1990
1991         Reviewed by Tim Horton.
1992
1993         * WebView/WebActionMenuController.mm:
1994         (-[WebActionMenuController _defaultMenuItems]):
1995
1996 2014-11-19  Beth Dakin  <bdakin@apple.com>
1997
1998         Data detected results with no menu items should not fall through to regular text 
1999         action menus
2000         https://bugs.webkit.org/show_bug.cgi?id=138887
2001         -and corresponding-
2002         rdar://problem/18971616
2003
2004         Reviewed by Tim Horton.
2005
2006         * WebView/WebActionMenuController.mm:
2007         (-[WebActionMenuController _defaultMenuItems]):
2008
2009 2014-11-19  Daniel Bates  <dabates@apple.com>
2010
2011         [iOS] Make WebKit build with public iOS SDK
2012         https://bugs.webkit.org/show_bug.cgi?id=136863
2013
2014         Reviewed by David Kilzer.
2015
2016         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
2017         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
2018         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
2019         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
2020         may be used by Apple internal clients that do not include wtf/Platform.h.
2021         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
2022         private Foundation headers directly.
2023         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
2024         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
2025         instead of including private CFNetwork headers directly. Also fixed up style and
2026         ordering of header include directives.
2027         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
2028         CFNetwork headers directly. Also sort the #import directives.
2029         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
2030         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
2031
2032 2014-11-18  David Kilzer  <ddkilzer@apple.com>
2033
2034         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
2035         <http://webkit.org/b/138813>
2036
2037         Reviewed by Mark Rowe.
2038
2039         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
2040         selectors.
2041
2042 2014-11-18  Chris Dumez  <cdumez@apple.com>
2043
2044         Add a setting to toggle DOMTimer throttling support
2045         https://bugs.webkit.org/show_bug.cgi?id=138844
2046         <rdar://problem/19020874>
2047
2048         Reviewed by Andreas Kling.
2049
2050         Add a setting to disable DOM timers throttling, in order to help
2051         developers determine if a specific issue is caused by timer
2052         throttling.
2053
2054         * WebView/WebPreferenceKeysPrivate.h:
2055         * WebView/WebPreferences.mm:
2056         (+[WebPreferences initialize]):
2057         (-[WebPreferences domTimersThrottlingEnabled]):
2058         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
2059         * WebView/WebPreferencesPrivate.h:
2060         * WebView/WebView.mm:
2061         (-[WebView _preferencesChanged:]):
2062
2063 2014-11-18  Tim Horton  <timothy_horton@apple.com>
2064
2065         Avoid re-encoding action menu image data
2066         https://bugs.webkit.org/show_bug.cgi?id=138817
2067         <rdar://problem/18840382>
2068
2069         Reviewed by Anders Carlsson.
2070
2071         * WebView/WebActionMenuController.mm:
2072         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2073         (-[WebActionMenuController _addImageToPhotos:]):
2074         Build a temporary filename from a UUID and the image's desired extension.
2075         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
2076         Build an image menu only if we have an image, URL, data, and extension.
2077
2078 2014-11-18  Daniel Bates  <dabates@apple.com>
2079
2080         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2081         SPI are not available in public SDK
2082         https://bugs.webkit.org/show_bug.cgi?id=138802
2083
2084         Reviewed by David Kilzer.
2085
2086         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2087         libdispatch and MobileGestalt headers directly.
2088
2089         * WebView/WebView.mm:
2090
2091 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
2092
2093         Remove calls to deprecated NSMenu methods
2094         https://bugs.webkit.org/show_bug.cgi?id=138808.
2095
2096         Reviewed by Anders Carlsson.
2097
2098         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
2099
2100         * WebCoreSupport/PopupMenuMac.mm:
2101         (PopupMenuMac::populate):
2102
2103 2014-11-17  Daniel Bates  <dabates@apple.com>
2104
2105         Unreviewed, rolling out r176232.
2106
2107         Broke the Mac build. Will investigate offline.
2108
2109         Reverted changeset:
2110
2111         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2112         MobileGestalt"
2113         https://bugs.webkit.org/show_bug.cgi?id=138802
2114         http://trac.webkit.org/changeset/176232
2115
2116 2014-11-17  Daniel Bates  <dabates@apple.com>
2117
2118         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2119         SPI are not available in public SDK
2120         https://bugs.webkit.org/show_bug.cgi?id=138802
2121
2122         Reviewed by David Kilzer.
2123
2124         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2125         libdispatch and MobileGestalt headers directly.
2126
2127         * WebView/WebView.mm:
2128
2129 2014-11-17  Beth Dakin  <bdakin@apple.com>
2130
2131         Whitespace action menus should focus the HitTestResult and create an insertion 
2132         point
2133         https://bugs.webkit.org/show_bug.cgi?id=138786
2134         -and corresponding-
2135         rdar://problem/18944893
2136
2137         Reviewed by Tim Horton.
2138
2139         Whitespace menus should cause the HitTestResult to be focused, and they should set 
2140         the selection based on the HitTest location.
2141
2142         * WebView/WebActionMenuController.mm:
2143         (-[WebActionMenuController isMenuForTextContent]):
2144         (-[WebActionMenuController focusAndSelectHitTestResult]):
2145         (-[WebActionMenuController willOpenMenu:withEvent:]):
2146
2147 2014-11-17  Daniel Bates  <dabates@apple.com>
2148
2149         [iOS] QuartzCore SPI not available in public SDK
2150         https://bugs.webkit.org/show_bug.cgi?id=138751
2151
2152         Reviewed by David Kilzer.
2153
2154         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
2155
2156         * WebInspector/WebNodeHighlight.mm:
2157         * WebView/WebIndicateLayer.mm:
2158
2159 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
2160
2161         [iOS] allow host application to opt-out of alternate fullscreen
2162         https://bugs.webkit.org/show_bug.cgi?id=138787
2163
2164         Reviewed by Darin Adler.
2165
2166         * WebView/WebPreferenceKeysPrivate.h:
2167         * WebView/WebPreferences.mm:
2168         (+[WebPreferences initialize]):
2169         (-[WebPreferences allowsAlternateFullscreen]):
2170         (-[WebPreferences setAllowsAlternateFullscreen:]):
2171         * WebView/WebPreferencesPrivate.h:
2172         * WebView/WebView.mm:
2173         (-[WebView _preferencesChanged:]):
2174
2175 2014-11-16  Tim Horton  <timothy_horton@apple.com>
2176
2177         Use TextIndicator instead of the built in Lookup highlight
2178         https://bugs.webkit.org/show_bug.cgi?id=138775
2179         <rdar://problem/18953982>
2180
2181         Reviewed by Anders Carlsson.
2182
2183         * WebCoreSupport/WebSystemInterface.mm:
2184         (InitWebCoreSystemInterface):
2185         Remove a WKSI import.
2186
2187         * WebView/WebActionMenuController.mm:
2188         (-[WebActionMenuController _lookupText:]):
2189         (-[WebActionMenuController _createActionMenuItemForTag:]):
2190         Make use of the new Lookup SPI header.
2191         Disable the Lookup item if lookup is not available.
2192
2193 2014-11-15  Tim Horton  <timothy_horton@apple.com>
2194
2195         Implement data detectors and mailto action menus for WebKit1
2196         https://bugs.webkit.org/show_bug.cgi?id=138765
2197         <rdar://problem/18877535>
2198
2199         Reviewed by Beth Dakin.
2200
2201         * WebView/WebActionMenuController.h:
2202         * WebView/WebActionMenuController.mm:
2203         (-[WebActionMenuController willOpenMenu:withEvent:]):
2204         Tell DataDetectors that the menu is going to open.
2205         Select the text (or not) based on the number of items in the menu, just like WebKit2.
2206
2207         (-[WebActionMenuController didCloseMenu:withEvent:]):
2208         Tell DataDetectors that the menu closed.
2209
2210         (-[WebActionMenuController _defaultMenuItemsForLink]):
2211         Move these checks out of _defaultMenuItemsForLink, because we expect this
2212         to always return a complete link menu.
2213
2214         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2215         Implement. More or less copied from WebKit2.
2216
2217         (-[WebActionMenuController _selectDataDetectedText]):
2218         Select the stashed range.
2219
2220         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2221         Implement. More or less copied from WebKit2.
2222         The yellow highlight isn't hooked up yet.
2223         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
2224
2225         (-[WebActionMenuController _selectLookupText]):
2226         Remove an unnecessary return.
2227
2228         (-[WebActionMenuController _defaultMenuItems]):
2229         Call into the two new menu types.
2230
2231         * WebView/WebUIDelegatePrivate.h:
2232
2233 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
2234
2235         Get rid of WebFontCache
2236         https://bugs.webkit.org/show_bug.cgi?id=134752
2237
2238         Reviewed by Dave Hyatt.
2239
2240         * WebView/WebHTMLView.mm:
2241
2242 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
2243
2244         Update some artwork for the legacy WebKit action menu
2245         https://bugs.webkit.org/show_bug.cgi?id=138758
2246         <rdar://problem/18989840>
2247
2248         * WebView/WebActionMenuController.mm:
2249         (webKitBundleImageNamed): Deleted.
2250         Fix the build.
2251
2252 2014-11-14  Tim Horton  <timothy_horton@apple.com>
2253
2254         Update some artwork for the legacy WebKit action menu
2255         https://bugs.webkit.org/show_bug.cgi?id=138758
2256         <rdar://problem/18989840>
2257
2258         Reviewed by Simon Fraser.
2259
2260         * WebView/WebActionMenuController.mm:
2261         (-[WebActionMenuController _createActionMenuItemForTag:]):
2262
2263 2014-11-14  Daniel Bates  <dabates@apple.com>
2264
2265         [iOS] NSFileManager and QuickLook SPI not available in public SDK
2266         https://bugs.webkit.org/show_bug.cgi?id=138742
2267
2268         Reviewed by Pratik Solanki.
2269
2270         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
2271
2272         * WebCoreSupport/WebFrameLoaderClient.mm:
2273
2274 2014-11-14  Beth Dakin  <bdakin@apple.com>
2275
2276         WK1: Webpage preview can come up in wrong location
2277         https://bugs.webkit.org/show_bug.cgi?id=138747
2278         -and corresponding-
2279         rdar://problem/18979004
2280
2281         Reviewed by Tim Horton.
2282
2283         Converting to window twice is bad.
2284         * WebView/WebActionMenuController.mm:
2285         (elementBoundingBoxInWindowCoordinatesFromNode):
2286         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2287         (elementBoundingBoxFromNode): Deleted.
2288
2289 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2290
2291         Move FontMac and FontCacheMac off of WKSI
2292         https://bugs.webkit.org/show_bug.cgi?id=138633
2293
2294         Reviewed by Simon Fraser.
2295
2296         * WebCoreSupport/WebSystemInterface.mm:
2297         (InitWebCoreSystemInterface):
2298         * WebKit.order:
2299
2300 2014-11-13  Beth Dakin  <bdakin@apple.com>
2301
2302         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
2303         https://bugs.webkit.org/show_bug.cgi?id=138716
2304         -and corresponding-
2305         rdar://problem/18977222
2306
2307         Reviewed by Tim Horton.
2308
2309         It’s not necessary to use the WebElementDictionary for so many things now that we 
2310         are caching the HitTestResult. We should just use the HitTestResult.
2311
2312         * WebView/WebActionMenuController.mm:
2313         (-[WebActionMenuController prepareForMenu:withEvent:]):
2314         (-[WebActionMenuController _openURLFromActionMenu:]):
2315         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2316         (elementBoundingBoxFromNode):
2317         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2318         (-[WebActionMenuController _defaultMenuItemsForLink]):
2319         (-[WebActionMenuController _defaultMenuItemsForImage]):
2320         (-[WebActionMenuController _defaultMenuItemsForVideo]):
2321         (-[WebActionMenuController _defaultMenuItemsForText]):
2322         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2323         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2324         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2325         (-[WebActionMenuController _createActionMenuItemForTag:]):
2326         (-[WebActionMenuController _defaultMenuItems]):
2327         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
2328         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
2329         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
2330         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
2331         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
2332         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
2333         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
2334         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
2335         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
2336         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
2337
2338 2014-11-13  Daniel Bates  <dabates@apple.com>
2339
2340         [iOS] NSGeometry data types are not available in the public SDK
2341         https://bugs.webkit.org/show_bug.cgi?id=137536
2342
2343         Reviewed by David Kilzer.
2344
2345         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
2346         private header.
2347
2348         * DOM/WebDOMOperationsPrivate.h:
2349
2350 2014-11-13  Beth Dakin  <bdakin@apple.com>
2351
2352         WK1: Support default actions for video
2353         https://bugs.webkit.org/show_bug.cgi?id=138713
2354         -and corresponding-
2355         rdar://problem/18877520
2356
2357         Reviewed by Tim Horton.
2358
2359         Call setToNonShadowAncestor() for media HitTestResults.
2360         * WebView/WebActionMenuController.mm:
2361         (-[WebActionMenuController performHitTestAtPoint:]):
2362
2363         Default items and actions.
2364         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
2365         (-[WebActionMenuController _copyVideoURL:]):
2366         (-[WebActionMenuController _saveVideoToDownloads:]):
2367         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2368         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2369         * WebView/WebUIDelegatePrivate.h:
2370
2371 2014-11-13  Tim Horton  <timothy_horton@apple.com>
2372
2373         WK1: Update icon for Add to Reading List
2374         https://bugs.webkit.org/show_bug.cgi?id=138710
2375         <rdar://problem/18975774>
2376
2377         Reviewed by Beth Dakin.
2378
2379         * WebView/WebActionMenuController.mm:
2380         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2381         Use the right icon, matching WebKit2.
2382
2383 2014-11-12  Beth Dakin  <bdakin@apple.com>
2384
2385         WK1: Support default actions for images
2386         https://bugs.webkit.org/show_bug.cgi?id=138668
2387         -and corresponding-
2388         rdar://problem/18785434
2389
2390         Reviewed by Tim Horton.
2391
2392         * WebView/WebActionMenuController.h:
2393         * WebView/WebActionMenuController.mm:
2394         (-[WebActionMenuController didCloseMenu:withEvent:]):
2395         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2396         (-[WebActionMenuController _copyImage:]):
2397         (temporaryPhotosDirectoryPath):
2398         (pathToPhotoOnDisk):
2399         (-[WebActionMenuController _canAddMediaToPhotos]):
2400         (-[WebActionMenuController _addImageToPhotos:]):
2401         (-[WebActionMenuController _saveImageToDownloads:]):
2402         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2403         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
2404         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2405         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2406         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2407         * WebView/WebUIDelegatePrivate.h:
2408
2409 2014-11-11  Beth Dakin  <bdakin@apple.com>
2410
2411         Action menu hit testing is not working properly with all WK1 apps
2412         https://bugs.webkit.org/show_bug.cgi?id=138643
2413         -and corresponding-
2414         rdar://problem/18949376
2415
2416         Reviewed by Tim Horton.
2417
2418         * WebView/WebActionMenuController.mm:
2419         (-[WebActionMenuController prepareForMenu:withEvent:]):
2420         (-[WebActionMenuController _lookupText:]):
2421
2422 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2423
2424         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
2425         https://bugs.webkit.org/show_bug.cgi?id=138623
2426
2427         Reviewed by Geoff Garen.
2428
2429         * WebCoreSupport/WebSystemInterface.mm:
2430         (InitWebCoreSystemInterface):
2431         * WebKit.order:
2432
2433 2014-11-11  Tim Horton  <timothy_horton@apple.com>
2434
2435         Localize strings for action menus
2436         https://bugs.webkit.org/show_bug.cgi?id=138591
2437         <rdar://problem/18815343>
2438
2439         Reviewed by Dan Bates.
2440
2441         * WebView/WebActionMenuController.mm:
2442         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2443         Make use of the new strings.
2444
2445 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2446
2447         Cleanup from r175379
2448         https://bugs.webkit.org/show_bug.cgi?id=138616
2449
2450         Reviewed by Simon Fraser.
2451
2452         * WebCoreSupport/WebSystemInterface.mm:
2453         (InitWebCoreSystemInterface):
2454         * WebKit.order:
2455
2456 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2457
2458         Move CTFontTransformGlyphs out from WKSI
2459         https://bugs.webkit.org/show_bug.cgi?id=138599
2460
2461         Reviewed by Simon Fraser.
2462
2463         * WebCoreSupport/WebSystemInterface.mm:
2464         (InitWebCoreSystemInterface):
2465         * WebKit.order:
2466
2467 2014-11-11  Dan Bernstein  <mitz@apple.com>
2468
2469         More iOS build fix.
2470
2471         * WebView/WebHTMLViewInternal.h:
2472
2473 2014-11-11  Dan Bernstein  <mitz@apple.com>
2474
2475         iOS build fix.
2476
2477         * WebView/WebHTMLView.mm:
2478
2479 2014-11-10  Beth Dakin  <bdakin@apple.com>
2480
2481         WK1: Support default actions for editable text with misspelled word
2482         https://bugs.webkit.org/show_bug.cgi?id=138590
2483         -and corresponding-
2484         rdar://problem/18877506
2485
2486         Reviewed by Tim Horton.
2487
2488         If there are misspelled word suggestions for editable text, create a new type of 
2489         menu with a spelling suggestion sub-menu.
2490
2491         * WebView/WebActionMenuController.mm:
2492         (-[WebActionMenuController isMenuForTextContent]):
2493         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
2494         (-[WebActionMenuController _changeSelectionToSuggestion:]):
2495         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2496         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2497         * WebView/WebHTMLView.mm:
2498         (-[WebHTMLView _changeSpellingToWord:]):
2499         * WebView/WebHTMLViewInternal.h:
2500         * WebView/WebUIDelegatePrivate.h:
2501
2502 2014-11-10  Beth Dakin  <bdakin@apple.com>
2503
2504         WK1: Support default actions for editable whitespace
2505         https://bugs.webkit.org/show_bug.cgi?id=138586
2506         -and corresponding-
2507         rdar://problem/18932048
2508
2509         Reviewed by Tim Horton.
2510
2511         New menu type. Just wants paste.
2512
2513         * WebView/WebActionMenuController.mm:
2514         (-[WebActionMenuController isMenuForTextContent]):
2515         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
2516         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2517         * WebView/WebUIDelegatePrivate.h:
2518
2519 2014-11-10  Beth Dakin  <bdakin@apple.com>
2520
2521         WK1: Support default actions for editable text
2522         https://bugs.webkit.org/show_bug.cgi?id=138580
2523         -and corresponding-
2524         rdar://problem/18877497
2525
2526         Reviewed by Tim Horton.
2527
2528         New menu type, and new action type for paste. 
2529
2530         * WebView/WebActionMenuController.mm:
2531         (-[WebActionMenuController isMenuForTextContent]):
2532         (-[WebActionMenuController willOpenMenu:withEvent:]):
2533         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
2534         (-[WebActionMenuController _paste:]):
2535         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2536         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2537         * WebView/WebUIDelegatePrivate.h:
2538
2539 2014-11-10  Beth Dakin  <bdakin@apple.com>
2540
2541         WK1: Text is getting selected even when an action menu fails to invoke
2542         https://bugs.webkit.org/show_bug.cgi?id=138576
2543         -and corresponding-
2544         rdar://problem/18931330
2545
2546         Reviewed by Tim Horton.
2547
2548         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
2549         * WebView/WebActionMenuController.h:
2550         * WebView/WebActionMenuController.mm:
2551         (-[WebActionMenuController prepareForMenu:withEvent:]):
2552         (-[WebActionMenuController willOpenMenu:withEvent:]):
2553
2554         _selectLookupText no longer needs to return a BOOL indicating success or failure.
2555         (-[WebActionMenuController _selectLookupText]):
2556         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2557
2558         Pass willOpenMenu: on to the controller.
2559         * WebView/WebView.mm:
2560         (-[WebView willOpenMenu:withEvent:]):
2561
2562 2014-11-10  Beth Dakin  <bdakin@apple.com>
2563
2564         Speculative build fix.
2565
2566         * WebView/WebActionMenuController.mm:
2567
2568 2014-11-10  Beth Dakin  <bdakin@apple.com>
2569
2570         Action menu initialization should be moved to _commonInitializationWithFrameName
2571         https://bugs.webkit.org/show_bug.cgi?id=138572
2572         -and corresponding-
2573         rdar://problem/18929733
2574
2575         Reviewed by Tim Horton.
2576
2577         * WebView/WebView.mm:
2578         (-[WebView _commonInitializationWithFrameName:groupName:]):
2579         (-[WebView _initWithFrame:frameName:groupName:]):
2580
2581 2014-11-10  Beth Dakin  <bdakin@apple.com>
2582
2583         WK1: Support default actions for read-only text
2584         https://bugs.webkit.org/show_bug.cgi?id=138552
2585         -and corresponding-
2586         rdar://problem/18877483
2587
2588         Reviewed by Tim Horton.
2589
2590         New WKSystemInterface functions that WebCore needs to use.
2591         * WebCoreSupport/WebSystemInterface.mm:
2592         (InitWebCoreSystemInterface):
2593
2594         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
2595         makes a lot of things easier.
2596         * WebView/WebActionMenuController.h:
2597         * WebView/WebActionMenuController.mm:
2598
2599         Perform the hit test ourselves instead of calling into WebView so that we can more 
2600         easily save the WebCore::HitTestResult for ourselves.
2601         (-[WebActionMenuController performHitTestAtPoint:]):
2602
2603         Clear selection for non-text menus.
2604         (-[WebActionMenuController prepareForMenu:withEvent:]):
2605
2606         Re-set the _type here just to be safe.
2607         (-[WebActionMenuController didCloseMenu:withEvent:]):
2608
2609         Moving this method to be next to the link actions so they can be within a pragma 
2610         mark.
2611         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2612
2613         New method for default text actions — lookup and copy.
2614         (-[WebActionMenuController _defaultMenuItemsForText:]):
2615         (-[WebActionMenuController _copySelection:]):
2616         (-[WebActionMenuController _lookupText:]):
2617
2618         If there is not already a selection, invoking the action menu on text should 
2619         select the lookup text.
2620         (-[WebActionMenuController _selectLookupText]):
2621         (performDictionaryLookupForSelection):
2622         (performDictionaryLookupForRange):
2623
2624         Handle text now.
2625         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2626         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2627
2628         New enum values.
2629         * WebView/WebUIDelegatePrivate.h:
2630
2631         Pass didCloseMenu on to the controller.
2632         * WebView/WebView.mm:
2633         (-[WebView didCloseMenu:withEvent:]):
2634
2635 2014-11-09  Chris Dumez  <cdumez@apple.com>
2636
2637         Add a more correct way to compare floating point numbers and use it
2638         https://bugs.webkit.org/show_bug.cgi?id=138527
2639
2640         Reviewed by Darin Adler.
2641
2642         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
2643         to compare floating-point numbers.
2644
2645         * WebView/WebHTMLView.mm:
2646         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2647
2648 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2649
2650         Delete cookies between tests
2651         https://bugs.webkit.org/show_bug.cgi?id=138528
2652
2653         Reviewed by Sam Weinig.
2654
2655         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
2656         * WebView/WebPreferencesPrivate.h:
2657         Added an SPI for DumpRenderTree.
2658
2659 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
2660
2661         [iOS] Update optimized fullscreen media controls
2662         https://bugs.webkit.org/show_bug.cgi?id=138493
2663
2664         Reviewed by Brent Fulgham.
2665
2666         * WebCoreSupport/WebSystemInterface.mm:
2667         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
2668
2669 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
2670
2671         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
2672         https://bugs.webkit.org/show_bug.cgi?id=138443
2673
2674         Reviewed by Anders Carlsson.
2675
2676         Wrapping the dealloc method in its own autorelease pool avoids the problem of
2677         complex tear-downs leading to the WebView itself being added to an autorelease
2678         pool that is not drained until after the instance has been dealloc'd.
2679  
2680         * WebView/WebView.mm:
2681         (-[WebView dealloc]):
2682
2683 2014-11-05  Jer Noble  <jer.noble@apple.com>
2684
2685         De-templatize Timer
2686         https://bugs.webkit.org/show_bug.cgi?id=138450
2687
2688         Reviewed by Anders Carlsson.
2689
2690         Remove template specifiers from Timer.
2691
2692         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2693         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2694         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2695         * Plugins/WebNetscapePluginStream.h:
2696         * Plugins/WebNetscapePluginStream.mm:
2697         (WebNetscapePluginStream::deliverDataTimerFired):
2698
2699 2014-11-05  Dan Bernstein  <mitz@apple.com>
2700
2701         Remove the unused deletion UI feature
2702         https://bugs.webkit.org/show_bug.cgi?id=138442
2703
2704         Rubber-stamped by Alexey Proskuryakov.
2705
2706         * DefaultDelegates/WebDefaultEditingDelegate.m:
2707         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
2708         * WebCoreSupport/WebEditorClient.h:
2709         * WebCoreSupport/WebEditorClient.mm:
2710         (WebEditorClient::shouldShowDeleteInterface): Deleted.
2711         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
2712         -webView:shouldShowDeleteInterfaceForElement:.
2713
2714 2014-11-03  Dean Jackson  <dino@apple.com>
2715
2716         Add ENABLE_FILTERS_LEVEL_2 feature guard.
2717         https://bugs.webkit.org/show_bug.cgi?id=138362
2718
2719         Reviewed by Tim Horton.
2720
2721         Add a new feature define for Level 2 of CSS Filters.
2722         http://dev.w3.org/fxtf/filters-2/
2723
2724         * Configurations/FeatureDefines.xcconfig:
2725
2726 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
2727
2728         Add button and enable optimized fullscreen.
2729         https://bugs.webkit.org/show_bug.cgi?id=138351
2730
2731         Reviewed by Eric Carlson.
2732
2733         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
2734
2735         * WebCoreSupport/WebSystemInterface.mm:
2736         (InitWebCoreSystemInterface): added
2737
2738 2014-11-04  Chris Dumez  <cdumez@apple.com>
2739
2740         Add ptr() method to Ref class
2741         https://bugs.webkit.org/show_bug.cgi?id=138361
2742
2743         Reviewed by Darin Adler.
2744
2745         Use the new Ref::ptr() method.
2746
2747         * WebView/WebFrame.mm:
2748         (-[WebFrame _setTypingStyle:withUndoAction:]):
2749         * WebView/WebHTMLView.mm:
2750         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2751         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2752         * WebView/WebView.mm:
2753         (-[WebView applyStyle:]):
2754
2755 2014-11-04  Darin Adler  <darin@apple.com>
2756
2757         Eliminate ResourceBuffer and use SharedBuffer directly instead
2758         https://bugs.webkit.org/show_bug.cgi?id=138174
2759
2760         Reviewed by Antti Koivisto.
2761
2762         * WebView/WebDataSource.mm:
2763         (-[WebDataSource data]): Use SharedBuffer directly.
2764         * WebView/WebHTMLView.mm:
2765         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2766
2767 2014-11-03  Commit Queue  <commit-queue@webkit.org>
2768
2769         Unreviewed, rolling out r175406, r175413, and r175423.
2770         https://bugs.webkit.org/show_bug.cgi?id=138327
2771
2772         Multipart tests are still broken (Requested by ap on #webkit).
2773
2774         Reverted changesets:
2775
2776         "Eliminate ResourceBuffer and use SharedBuffer directly
2777         instead"
2778         https://bugs.webkit.org/show_bug.cgi?id=138174
2779         http://trac.webkit.org/changeset/175406
2780
2781         "Unreviewed, iOS build fix since 175406."
2782         http://trac.webkit.org/changeset/175413
2783
2784         "Fix assertion in CachedResource::addDataBuffer"
2785         http://trac.webkit.org/changeset/175423
2786
2787 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2788
2789         Use std::unique_ptr for TypeCountSet
2790         https://bugs.webkit.org/show_bug.cgi?id=138242
2791
2792         Reviewed by Andreas Kling.
2793
2794         * Misc/WebCoreStatistics.mm:
2795         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
2796         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
2797
2798 2014-10-31  Beth Dakin  <bdakin@apple.com>
2799
2800         Use system art for action menus when possible
2801         https://bugs.webkit.org/show_bug.cgi?id=138260
2802
2803         Reviewed by Tim Horton.
2804
2805         * WebView/WebActionMenuController.mm:
2806         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2807
2808 2014-10-30  Darin Adler  <darin@apple.com>
2809
2810         Eliminate ResourceBuffer and use SharedBuffer directly instead
2811         https://bugs.webkit.org/show_bug.cgi?id=138174
2812
2813         Reviewed by Antti Koivisto.
2814
2815         * WebView/WebDataSource.mm:
2816         (-[WebDataSource data]): Use SharedBuffer directly.
2817         * WebView/WebHTMLView.mm:
2818         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2819
2820 2014-10-30  Jer Noble  <jer.noble@apple.com>
2821
2822         [EME] Add Setting for accessing storage location for MediaKeys data
2823         https://bugs.webkit.org/show_bug.cgi?id=138147
2824
2825         Reviewed by Brady Eidson.
2826
2827         * WebView/WebPreferenceKeysPrivate.h:
2828         * WebView/WebPreferences.mm:
2829         (+[WebPreferences initialize]): Set default location.
2830         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
2831         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
2832         * WebView/WebPreferencesPrivate.h:
2833         * WebView/WebView.mm:
2834         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
2835
2836 2014-10-30  Dana Burkart  <dburkart@apple.com>
2837
2838         <rdar://problem/18821260> Prepare for the mysterious future
2839
2840         Reviewed by Lucas Forschler.
2841
2842         * Configurations/Base.xcconfig:
2843         * Configurations/DebugRelease.xcconfig:
2844         * Configurations/FeatureDefines.xcconfig:
2845         * Configurations/Version.xcconfig:
2846
2847 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
2848
2849         Add optimized fullscreen mode.
2850         https://bugs.webkit.org/show_bug.cgi?id=138044
2851
2852         Reviewed by Jer Noble.
2853
2854         Enable different types of fullscreen video behavior.
2855         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
2856
2857         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
2858         * WebCoreSupport/WebChromeClient.mm:
2859         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
2860         * WebView/WebView.mm:
2861         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
2862         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
2863         * WebView/WebViewInternal.h: ditto
2864
2865 2014-10-27  Beth Dakin  <bdakin@apple.com>
2866
2867         Provide a way for WebKit1 clients to override default action menu items
2868         https://bugs.webkit.org/show_bug.cgi?id=138066
2869         -and corresponding-
2870         rdar://problem/18451638
2871
2872         Reviewed by Anders Carlsson.
2873
2874         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
2875         send that along to clients customizing the menu.
2876         * WebView/WebActionMenuController.h:
2877         * WebView/WebActionMenuController.mm:
2878         (-[WebActionMenuController prepareForMenu:withEvent:]):
2879         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2880
2881         New enum and new SPI to customize menus.
2882         * WebView/WebUIDelegatePrivate.h:
2883
2884 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
2885
2886         Fix the iOS build
2887
2888         * Configurations/WebKitLegacy.xcconfig:
2889         * WebView/WebView.mm:
2890
2891 2014-10-24  Beth Dakin  <bdakin@apple.com>
2892
2893         Build fix.
2894
2895         * WebView/WebActionMenuController.mm:
2896         (-[WebActionMenuController _openURLFromActionMenu:]):
2897         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2898         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2899
2900 2014-10-24  Beth Dakin  <bdakin@apple.com>
2901
2902         WebKit1 should support action menus
2903         https://bugs.webkit.org/show_bug.cgi?id=138032
2904
2905         Reviewed by Tim Horton.
2906
2907         This patch adds basic support for action menus and adds actions for links.
2908
2909         Helper class takes care of all of the action menu work. WebView will forward the 
2910         prepareForMenu: message, and then the helper class takes it from there.
2911         * WebView/WebActionMenuController.h: Added.
2912         * WebView/WebActionMenuController.mm: Added.
2913         (-[WebActionMenuController webViewClosed]):
2914         (-[WebActionMenuController prepareForMenu:withEvent:]):
2915
2916         Selectors for link actions.
2917         (-[WebActionMenuController _openURLFromActionMenu:]):
2918         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2919         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
2920         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2921         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2922         (webKitBundleImageNamed):
2923         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2924         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2925
2926         Tags for the action menu items.
2927         * WebView/WebUIDelegatePrivate.h:
2928         * WebView/WebView.mm:
2929
2930         Set the action menu if possible and create the controller.
2931         (-[WebView _initWithFrame:frameName:groupName:]):
2932         (-[WebView _close]):
2933         (-[WebView prepareForMenu:withEvent:]):
2934
2935         WebViewData stores the WebActionMenuHelper
2936         * WebView/WebViewData.h:
2937         * WebView/WebViewData.mm:
2938         (-[WebViewPrivate dealloc]):
2939
2940 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
2941
2942         Web Inspector: Provide a way to have alternate inspector agents
2943         https://bugs.webkit.org/show_bug.cgi?id=137901
2944
2945         Reviewed by Brian Burg.
2946
2947         * Configurations/FeatureDefines.xcconfig:
2948
2949 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2950
2951         Add some SPI headers for NSExtension and NSSharingService{Picker}
2952         https://bugs.webkit.org/show_bug.cgi?id=138027
2953
2954         Reviewed by Anders Carlsson.
2955
2956         * Misc/WebSharingServicePickerController.h:
2957         * Misc/WebSharingServicePickerController.mm:
2958         * WebCoreSupport/WebSelectionServiceController.mm:
2959         * WebCoreSupport/WebContextMenuClient.mm:
2960         Fix a sorting issue.
2961         Replace redefinitions with SPI header #imports.
2962
2963 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2964
2965         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
2966         https://bugs.webkit.org/show_bug.cgi?id=138013
2967
2968         Reviewed by Dan Bernstein.
2969
2970         * WebCoreSupport/WebSelectionServiceController.mm:
2971         (WebSelectionServiceController::hasRelevantSelectionServices):
2972         Don't adopt this autoreleased object.
2973
2974 2014-10-22  Chris Dumez  <cdumez@apple.com>
2975
2976         [Mac][WK2] Fix applicationIsSafari() detection
2977         https://bugs.webkit.org/show_bug.cgi?id=137893
2978
2979         Reviewed by Alexey Proskuryakov.
2980
2981         Provide an implementation for FrameLoaderClient's new
2982         needsQuickLookResourceCachingQuirks() that returns
2983         a static flag initialized using
2984         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
2985
2986         * WebCoreSupport/WebFrameLoaderClient.h:
2987         * WebCoreSupport/WebFrameLoaderClient.mm:
2988
2989 2014-10-20  Chris Dumez  <cdumez@apple.com>
2990
2991         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
2992         https://bugs.webkit.org/show_bug.cgi?id=137797
2993
2994         Reviewed by Darin Adler.
2995
2996         Call ResourceRequest::setDomainForPartitionName() instead of
2997         setPartitionName() as the argument is a domain, not a valid
2998         partition name.
2999
3000         * Misc/WebCache.mm:
3001         (+[WebCache addImageToCache:forURL:forFrame:]):
3002         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3003
3004 2014-10-20  Andy Estes  <aestes@apple.com>
3005
3006         Fix the iOS build.
3007
3008         * WebView/WebFrame.mm:
3009         (-[WebFrame getDictationResultRanges:andMetadatas:]):
3010         (-[WebFrame dictationResultMetadataForRange:]):
3011
3012 2014-10-19  Chris Dumez  <cdumez@apple.com>
3013
3014         Use is<>() / downcast<>() for all remaining RenderObject subclasses
3015         https://bugs.webkit.org/show_bug.cgi?id=137845
3016
3017         Reviewed by Darin Adler.
3018
3019         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
3020         clean up the surrounding code.
3021
3022         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3023         (-[WebHostedNetscapePluginView pluginHostDied]):
3024         * Plugins/WebBaseNetscapePluginView.mm:
3025         (-[WebBaseNetscapePluginView _windowClipRect]):
3026         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
3027         * WebCoreSupport/WebFrameLoaderClient.mm:
3028         (WebFrameLoaderClient::createPlugin):
3029         (WebFrameLoaderClient::createJavaAppletWidget):
3030
3031 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3032
3033         Build fix for 32-bit Yosemite
3034
3035         * WebCoreSupport/WebContextMenuClient.mm:
3036         (WebContextMenuClient::contextMenuForEvent):
3037         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
3038
3039 2014-10-17  Chris Dumez  <cdumez@apple.com>
3040
3041         Use is<>() / downcast<>() for RenderBox
3042         https://bugs.webkit.org/show_bug.cgi?id=137804
3043
3044         Reviewed by Andreas Kling.
3045
3046         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
3047         code.
3048
3049         * WebCoreSupport/WebContextMenuClient.mm:
3050         (WebContextMenuClient::clientFloatRectForNode):
3051         * WebView/WebFrame.mm:
3052         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
3053
3054 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3055
3056         Fix the build with the public SDK.
3057
3058         * WebCoreSupport/WebSelectionServiceController.mm:
3059         We should transition all this SPI to real SPI headers as soon as possible.
3060
3061 2014-10-16  Tim Horton  <timothy_horton@apple.com>
3062
3063         Implement selection services menu for Legacy WebKit
3064         https://bugs.webkit.org/show_bug.cgi?id=137582
3065         <rdar://problem/18604241>
3066
3067         Reviewed by Brady Eidson.
3068
3069         * Misc/WebSharingServicePickerController.h:
3070         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
3071         Add WebSharingServicePickerClient, which other classes can implement
3072         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
3073         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
3074
3075         * Misc/WebSharingServicePickerController.mm:
3076         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
3077
3078         (-[WebSharingServicePickerController clear]):
3079         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
3080         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
3081         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
3082         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
3083         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3084         Make use of WebSharingServicePickerClient.
3085
3086         (-[WebSharingServicePickerController sharingService:didShareItems:]):
3087         If we're returned a NSAttributedString, paste it on top of the current selection,
3088         similar to what the WebKit2 implementation currently does.
3089         
3090         * WebCoreSupport/WebChromeClient.h:
3091         * WebCoreSupport/WebChromeClient.mm:
3092         (WebChromeClient::handleTelephoneNumberClick):
3093         (WebChromeClient::handleSelectionServiceClick):
3094         (WebChromeClient::hasRelevantSelectionServices):
3095         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
3096
3097         * WebCoreSupport/WebContextMenuClient.h:
3098         * WebCoreSupport/WebContextMenuClient.mm:
3099         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
3100         (WebContextMenuClient::pageForSharingServicePicker):
3101         (WebContextMenuClient::windowForSharingServicePicker):
3102         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
3103         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3104         (WebContextMenuClient::contextMenuForEvent):
3105         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
3106         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
3107         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
3108         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
3109         having WebSharingServicePickerController tightly bound to it.
3110         Make an NSItemProvider array when instantiating WebSharingServicePickerController
3111         instead of handing it data directly.
3112
3113         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
3114         * WebCoreSupport/WebSelectionServiceController.mm: Added.
3115         (WebSelectionServiceController::WebSelectionServiceController):
3116         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
3117         for selection services.
3118
3119         (WebSelectionServiceController::handleSelectionServiceClick):
3120         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
3121
3122         (hasCompatibleServicesForItems):
3123         (WebSelectionServiceController::hasRelevantSelectionServices):
3124         Determine whether or not services are available.
3125
3126         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
3127         (WebSelectionServiceController::pageForSharingServicePicker):
3128         (WebSelectionServiceController::windowForSharingServicePicker):
3129         Implement the rest of the WebSharingServicePickerClient overrides.
3130
3131         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
3132         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
3133         These are only useful for image sharing services, so we don't need to
3134         implement them (WebContextMenuClient does, on the other hand).
3135
3136         * WebView/WebView.mm:
3137         (-[WebView _selectionServiceController]):
3138         * WebView/WebViewData.h:
3139         * WebView/WebViewData.mm:
3140         * WebView/WebViewInternal.h:
3141         Keep a WebSelectionServiceController.
3142
3143 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3144
3145         Improve debug description of WAKViews
3146         https://bugs.webkit.org/show_bug.cgi?id=137716
3147
3148         Reviewed by Simon Fraser.
3149
3150         * WebView/WebView.mm:
3151         (-[WebView _touchEventRegions]): Adding a comment.
3152
3153 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3154
3155         Addressing post-review comment.
3156         https://bugs.webkit.org/show_bug.cgi?id=137550
3157
3158         Unreviewed.
3159
3160         * WebView/WebHTMLView.mm:
3161         (fontNameForDescription):
3162         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3163
3164 2014-10-14  Chris Dumez  <cdumez@apple.com>
3165
3166         Use is<>() / downcast<>() for RenderImage
3167         https://bugs.webkit.org/show_bug.cgi?id=137683
3168
3169         Reviewed by Mihnea Ovidenie.
3170
3171         Use is<>() / downcast<>() for RenderImage.
3172
3173         * Misc/WebNSPasteboardExtras.mm:
3174         (imageFromElement):
3175         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3176
3177 2014-10-10  Daniel Bates  <dabates@apple.com>
3178
3179         Remove unused classes WebRender{Node, Layer}
3180         https://bugs.webkit.org/show_bug.cgi?id=137628
3181
3182         Reviewed by Simon Fraser.
3183
3184         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
3185         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
3186
3187         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
3188         of excluded source files when building for iOS.
3189         * WebKit.exp: Remove symbol for WebRenderLayer.
3190         * WebKit.mac.exp: Remove symbol for WebRenderNode.
3191         * WebView/WebRenderLayer.h: Removed.
3192         * WebView/WebRenderLayer.mm: Removed.
3193         * WebView/WebRenderNode.h: Removed.
3194         * WebView/WebRenderNode.mm: Removed.
3195
3196 2014-10-10  Chris Dumez  <cdumez@apple.com>
3197
3198         Use is<>() / downcast<>() for RenderBoxModelObject
3199         https://bugs.webkit.org/show_bug.cgi?id=137587
3200
3201         Reviewed by Mihnea Ovidenie.
3202
3203         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
3204         surrounding code.
3205
3206         * Plugins/WebBaseNetscapePluginView.mm:
3207         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
3208         * WebView/WebRenderLayer.mm:
3209         (-[WebRenderLayer initWithWebFrame:]):
3210
3211 2014-10-09  Dean Jackson  <dino@apple.com>
3212
3213         Remove ENABLE_CSS3_CONDITIONAL_RULES
3214         https://bugs.webkit.org/show_bug.cgi?id=137571
3215
3216         Reviewed by Simon Fraser.
3217
3218         * Configurations/FeatureDefines.xcconfig:
3219
3220 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3221
3222         Add a WebKit1 preference for selection services
3223         https://bugs.webkit.org/show_bug.cgi?id=137498
3224         <rdar://problem/18572699>
3225
3226         Reviewed by Simon Fraser.
3227
3228         * WebView/WebPreferenceKeysPrivate.h:
3229         * WebView/WebPreferences.mm:
3230         (+[WebPreferences initialize]):
3231         (-[WebPreferences serviceControlsEnabled]):
3232         (-[WebPreferences setServiceControlsEnabled:]):
3233         * WebView/WebPreferencesPrivate.h:
3234         * WebView/WebView.mm:
3235         (-[WebView _preferencesChanged:]):
3236         Add and plumb the preference.
3237
3238 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
3239
3240         Remove second-to-last client of WebFontCache
3241         https://bugs.webkit.org/show_bug.cgi?id=137550
3242
3243         Reviewed by Darin Adler.
3244
3245         Use FontCache::getCachedFontData() instead of WebFontCache.
3246
3247         * WebView/WebHTMLView.mm:
3248         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3249
3250 2014-10-09  Chris Dumez  <cdumez@apple.com>
3251
3252         Use is<>() / downcast<>() for Widget subclasses
3253         https://bugs.webkit.org/show_bug.cgi?id=137549
3254
3255         Reviewed by Darin Adler.
3256
3257         Use is<>() / downcast<>() for Widget subclasses and clean up the
3258         surrounding code.
3259
3260         * WebView/WebRenderNode.mm:
3261         (copyRenderNode):
3262         * WebView/WebView.mm:
3263         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
3264
3265 2014-10-07  Christophe Dumez  <cdumez@apple.com>
3266
3267         Use is<>() / downcast<>() for RenderText / RenderTextFragment
3268         https://bugs.webkit.org/show_bug.cgi?id=137476
3269
3270         Reviewed by Darin Adler.
3271
3272         * WebView/WebRenderNode.mm:
3273         (copyRenderNode):
3274
3275 2014-10-06  Dan Bernstein  <mitz@apple.com>
3276
3277         Build fix.
3278
3279         * Misc/WebCache.mm:
3280         (+[WebCache imageForURL:]):
3281
3282 2014-10-06  Chris Dumez  <cdumez@apple.com>
3283
3284         Unreviewed build fix after r174333.
3285
3286         Forgot explicit WebCore:: namespace.
3287
3288         * Misc/WebCache.mm:
3289         (+[WebCache imageForURL:]):
3290
3291 2014-10-05  Christophe Dumez  <cdumez@apple.com>
3292
3293         Use is<>() / downcast<>() for CachedResource subclasses
3294         https://bugs.webkit.org/show_bug.cgi?id=137431
3295
3296         Reviewed by Benjamin Poulain.
3297
3298         Use is<>() / downcast<>() for CachedResource subclasses.
3299
3300         * Misc/WebCache.mm:
3301         (+[WebCache imageForURL:]):
3302
3303 2014-10-02  Daniel Bates  <dabates@apple.com>
3304
3305         Use version number 101000 instead of 10100 for OS X Yosemite
3306         https://bugs.webkit.org/show_bug.cgi?id=137372
3307
3308         Reviewed by Mark Rowe.
3309
3310         The version number for OS X Yosemite is 101000.
3311
3312         * WebView/WebView.mm:
3313         (-[WebView _preferencesChanged:]):
3314
3315 2014-10-02  Tim Horton  <timothy_horton@apple.com>
3316
3317         Move PageOverlay[Controller] to WebCore
3318         https://bugs.webkit.org/show_bug.cgi?id=137164
3319         <rdar://problem/18508258>
3320
3321         Reviewed by Anders Carlsson.
3322
3323         * WebCoreSupport/WebChromeClient.h:
3324         * WebCoreSupport/WebChromeClient.mm:
3325         (WebChromeClient::attachViewOverlayGraphicsLayer):
3326         Add an empty ChromeClient override.
3327
3328 2014-10-01  Christophe Dumez  <cdumez@apple.com>
3329
3330         Have is<>(T*) function do a null check on the pointer argument
3331         https://bugs.webkit.org/show_bug.cgi?id=137333
3332
3333         Reviewed by Gavin Barraclough.
3334
3335         Have is<>(T*) function do a null check on the argument instead of a
3336         simple assertion. This makes sense for 2 reasons:
3337         1. It is more consistent with downcast<>(T*), which will succeed even
3338            if the argument is a nullptr.
3339         2. It simplifies the code a bit as it gets rid of a lot of explicit
3340            null checks.
3341
3342         * WebCoreSupport/WebChromeClient.mm:
3343         (WebChromeClient::focusedElementChanged):
3344         * WebCoreSupport/WebEditorClient.mm:
3345         (WebEditorClient::textFieldDidBeginEditing):
3346         (WebEditorClient::textFieldDidEndEditing):
3347         (WebEditorClient::textDidChangeInTextField):
3348         (WebEditorClient::doTextFieldCommandFromEvent):
3349         (WebEditorClient::textWillBeDeletedInTextField):
3350         (WebEditorClient::textDidChangeInTextArea):
3351         * WebView/WebHTMLRepresentation.mm:
3352         (inputElementFromDOMElement):
3353         (searchForLabelsBeforeElement):
3354         * WebView/WebRenderLayer.mm:
3355         (+[WebRenderLayer nameForLayer:]):
3356
3357 2014-10-01  Mark Rowe  <mrowe@apple.com>
3358
3359         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3360
3361         Reviewed by Dan Bernstein.
3362
3363         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
3364
3365 2014-09-30  Chris Dumez  <cdumez@apple.com>
3366
3367         Use is<>() / downcast<>() for Element
3368         https://bugs.webkit.org/show_bug.cgi?id=137241
3369
3370         Reviewed by Andreas Kling.
3371
3372         Use is<>() / downcast<>() for Element instead of isElementNode() /
3373         toElement().
3374
3375         * WebView/WebRenderLayer.mm:
3376         (+[WebRenderLayer nameForLayer:]):
3377
3378 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3379
3380         Move ColorInputType class to std::unique_ptr
3381         https://bugs.webkit.org/show_bug.cgi?id=137173
3382
3383         Reviewed by Darin Adler.
3384
3385         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
3386         Child classes follow this change as well.
3387
3388         * WebCoreSupport/WebChromeClient.h:
3389         * WebCoreSupport/WebChromeClient.mm:
3390         (WebChromeClient::createColorChooser):
3391
3392 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3393
3394         Add initial is<>() / downcast<>() support for any type of Nodes
3395         https://bugs.webkit.org/show_bug.cgi?id=137056
3396
3397         Reviewed by Benjamin Poulain.
3398
3399         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
3400         instead of isFormControlElement() / toHTMLFormControlElement().
3401
3402         * WebView/WebHTMLRepresentation.mm:
3403         (searchForLabelsBeforeElement):
3404
3405 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3406
3407         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
3408         https://bugs.webkit.org/show_bug.cgi?id=137068
3409
3410         Reviewed by Ryosuke Niwa.
3411
3412         Start using is<HTML*Element>() instead of isHTML*Element().
3413         Remaining usages will be updated in a follow-up patch to
3414         reduce the size of the change.
3415
3416         * WebCoreSupport/WebChromeClient.mm:
3417         (WebChromeClient::focusedElementChanged):
3418         * WebCoreSupport/WebEditorClient.mm:
3419         (WebEditorClient::textFieldDidBeginEditing):
3420         (WebEditorClient::textFieldDidEndEditing):
3421         (WebEditorClient::textDidChangeInTextField):
3422         (WebEditorClient::doTextFieldCommandFromEvent):
3423         (WebEditorClient::textWillBeDeletedInTextField):
3424         (WebEditorClient::textDidChangeInTextArea):
3425         * WebView/WebHTMLRepresentation.mm:
3426         (inputElementFromDOMElement):
3427
3428 2014-09-21  Timothy Hatcher  <timothy@apple.com>
3429
3430         Make the Web Inspector use a separate web process.
3431
3432         https://bugs.webkit.org/show_bug.cgi?id=135120
3433
3434         Reviewed by Anders Carlsson.
3435
3436         * WebCoreSupport/WebInspectorClient.h:
3437         * WebCoreSupport/WebInspectorClient.mm:
3438         (WebInspectorClient::WebInspectorClient):
3439         (WebInspectorClient::openInspectorFrontend):
3440         (WebInspectorClient::releaseFrontend):
3441         Own WebInspectorFrontendClient instead of moving it.
3442
3443 2014-09-23  Chris Dumez  <cdumez@apple.com>
3444
3445         Use downcast<HTML*Element>() instead of toHTML*Element()
3446         https://bugs.webkit.org/show_bug.cgi?id=137007
3447
3448         Reviewed by Benjamin Poulain.
3449
3450         Use downcast<HTML*Element>() instead of toHTML*Element().
3451
3452         * DOM/WebDOMOperations.mm:
3453         (-[DOMHTMLInputElement _setAutofilled:]):
3454         * WebCoreSupport/WebChromeClient.mm:
3455         (WebChromeClient::focusedElementChanged):
3456         * WebCoreSupport/WebEditorClient.mm:
3457         (WebEditorClient::textFieldDidBeginEditing):
3458         (WebEditorClient::textFieldDidEndEditing):
3459         (WebEditorClient::textDidChangeInTextField):
3460         (WebEditorClient::doTextFieldCommandFromEvent):
3461         (WebEditorClient::textWillBeDeletedInTextField):
3462         (WebEditorClient::textDidChangeInTextArea):
3463         * WebView/WebHTMLRepresentation.mm:
3464         (inputElementFromDOMElement):
3465
3466 2014-09-21  Chris Dumez  <cdumez@apple.com>
3467
3468         Generate Element casting helper functions
3469         https://bugs.webkit.org/show_bug.cgi?id=136839
3470
3471         Reviewed by Darin Adler.
3472
3473         Use JSXXX::toWrapped() instead of toXXX() function.
3474
3475         * DOM/WebDOMOperations.mm:
3476         * WebView/WebView.mm:
3477         (-[WebView _notificationIDForTesting:]):
3478
3479 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
3480
3481         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
3482         https://bugs.webkit.org/show_bug.cgi?id=136972
3483
3484         Reviewed by Darin Adler.
3485
3486         * WebView/WebNotification.h:
3487         * WebView/WebNotification.mm:
3488         (-[WebNotification initWithCoreNotification:notificationID:]):
3489         Switch to RetainPtr and adopt into _private to ensure when we are
3490         deallocated that _private will get deallocated.
3491
3492 2014-09-19  Dean Jackson  <dino@apple.com>
3493
3494         Multithreaded WebGL is a bad idea - remove it
3495         https://bugs.webkit.org/show_bug.cgi?id=136964
3496         <rdar://problem/18399858>
3497
3498         Reviewed by Brent Fulgham.
3499
3500         Remove the setting to allow multithreaded WebGL.
3501
3502         * WebView/WebPreferenceKeysPrivate.h:
3503         * WebView/WebPreferences.mm:
3504         (+[WebPreferences initialize]):
3505         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
3506         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
3507         * WebView/WebPreferencesPrivate.h:
3508         * WebView/WebView.mm:
3509         (-[WebView _preferencesChanged:]):
3510
3511 2014-09-19  Daniel Bates  <dabates@apple.com>
3512
3513         Always assume internal SDK when building configuration Production
3514         https://bugs.webkit.org/show_bug.cgi?id=136925
3515         <rdar://problem/18362399>
3516
3517         Reviewed by Dan Bernstein.
3518
3519         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
3520         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
3521
3522         * Configurations/Base.xcconfig:
3523
3524 2014-09-17  Daniel Bates  <dabates@apple.com>
3525
3526         Unreviewed, rolling out r173695.
3527
3528         Broke building third-party Legacy WebKit apps; will
3529         investigate offline
3530
3531         Reverted changeset:
3532
3533         "[iOS] Make WebCore build with public iOS SDK"
3534         https://bugs.webkit.org/show_bug.cgi?id=136487
3535         http://trac.webkit.org/changeset/173695
3536
3537 2014-09-17  Daniel Bates  <dabates@apple.com>
3538
3539         [iOS] Make WebCore build with public iOS SDK
3540         https://bugs.webkit.org/show_bug.cgi?id=136487
3541
3542         Reviewed by David Kilzer.
3543
3544         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
3545         actual SPI header(s).
3546
3547         * DOM/WebDOMOperationsPrivate.h:
3548         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
3549         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
3550         such files into the WebKit framework as private headers.
3551         * WebCoreSupport/WebFrameLoaderClient.mm:
3552         * WebInspector/WebNodeHighlight.mm:
3553         * WebView/WebIndicateLayer.mm:
3554         * WebView/WebRenderLayer.h:
3555         * WebView/WebView.mm:
3556
3557 2014-09-16  Daniel Bates  <dabates@apple.com>
3558
3559         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3560         https://bugs.webkit.org/show_bug.cgi?id=136862
3561
3562         Reviewed by David Kilzer.
3563
3564         * Configurations/DebugRelease.xcconfig:
3565
3566 2014-09-16  Enrica Casucci  <enrica@apple.com>
3567
3568         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3569         https://bugs.webkit.org/show_bug.cgi?id=136474
3570
3571         Reviewed by Benjamin Poulain.
3572
3573         This is the updated version of the patch that was landed in r173340.
3574         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3575         and removes the assumption that EAffinity values match NSSelectionAffinity
3576         values. It also removes the includes in TextAffinity.h, creating the need to
3577         include explicitly the files when necessary.
3578
3579         * WebCoreSupport/WebEditorClient.h:
3580         (kit):
3581         (core):
3582
3583 2014-09-14  Daniel Bates  <dabates@apple.com>
3584
3585         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
3586         (https://bugs.webkit.org/show_bug.cgi?id=136789)
3587
3588         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
3589
3590         * WebView/WebFrame.mm:
3591         (-[WebFrame focusedNodeHasContent]):
3592
3593 2014-09-14  Chris Dumez  <cdumez@apple.com>
3594
3595         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
3596         https://bugs.webkit.org/show_bug.cgi?id=136789
3597
3598         Reviewed by Darin Adler.
3599
3600         Rename childNodeCount() to countChildNodes().
3601
3602         * WebView/WebHTMLView.mm:
3603         (-[WebHTMLView attributedString]):
3604
3605 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
3606
3607         Re-add the request autocomplete feature
3608
3609         <https://bugs.webkit.org/show_bug.cgi?id=136730>
3610
3611         This feature was rolled out in r148731 because it was only used by
3612         Chromium. As we consider supporting this feature, roll it back in, but
3613         leave it disabled.
3614
3615         This rolls out r148731 (which removed the feature) with small changes
3616         needed to make the code build in ToT, to match modern style, to make
3617         the tests run, and to remove unused code.
3618
3619         Reviewed by Andy Estes.
3620
3621         * Configurations/FeatureDefines.xcconfig:
3622         * WebCoreSupport/WebFrameLoaderClient.h:
3623
3624 2014-09-12  Commit Queue  <commit-queue@webkit.org>
3625
3626         Unreviewed, rolling out r173575.
3627         https://bugs.webkit.org/show_bug.cgi?id=136790
3628
3629         Failing tests (Requested by enrica on #webkit).
3630
3631         Reverted changeset:
3632
3633         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3634         https://bugs.webkit.org/show_bug.cgi?id=136474
3635         http://trac.webkit.org/changeset/173575
3636
3637 2014-09-12  Enrica Casucci  <enrica@apple.com>
3638
3639         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3640         https://bugs.webkit.org/show_bug.cgi?id=136474
3641
3642         Reviewed by Benjamin Poulain.
3643
3644         This is the updated version of the patch that was landed in r173340.
3645         I changed the use of IntPoint to FloatPoint since it was causing tests
3646         to fail.
3647         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3648         and removes the assumption that EAffinity values match NSSelectionAffinity
3649         values. It also removes the includes in TextAffinity.h, creating the need to
3650         include explicitly the files when necessary. It also removes the unnecessary
3651         use of platform specific types, replacing them with WebCore types.
3652
3653         * WebCoreSupport/WebEditorClient.h:
3654         (kit):
3655         (core):
3656         * WebView/WebFrameView.mm:
3657         (-[WebFrameView _scrollToBeginningOfDocument]):
3658         (-[WebFrameView _scrollToEndOfDocument]):
3659
3660 2014-09-11  Bear Travis  <betravis@adobe.com>
3661
3662         [CSS Font Loading] Enable CSS Font Loading on Mac
3663         https://bugs.webkit.org/show_bug.cgi?id=135473
3664
3665         Reviewed by Antti Koivisto.
3666
3667         Enable CSS Font Loading in FeatureDefines.
3668
3669         * Configurations/FeatureDefines.xcconfig:
3670
3671 2014-09-11  Beth Dakin  <bdakin@apple.com>
3672
3673         Support rubber-banding in sub-frames
3674         https://bugs.webkit.org/show_bug.cgi?id=136726
3675         -and corresponding-
3676         rdar://problem/10011924
3677
3678         Reviewed by Tim Horton.
3679
3680         rubberBandingForOverflowScrollEnabled is re-named to
3681         rubberBandingForSubScrollableRegionsEnabled
3682         * WebView/WebView.mm:
3683         (-[WebView _preferencesChanged:]):
3684
3685 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
3686
3687         Disable the "unreachable-code" warning
3688         https://bugs.webkit.org/show_bug.cgi?id=136677
3689
3690         Reviewed by Darin Adler.
3691
3692         * Configurations/Base.xcconfig:
3693
3694 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
3695
3696         Fix 32-bit Mac build for new warnings
3697         https://bugs.webkit.org/show_bug.cgi?id=136624
3698
3699         Reviewed by Darin Adler.
3700         
3701         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
3702
3703         * Carbon/HIViewAdapter.m:
3704         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
3705
3706 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3707
3708         Remove FILTERS flag
3709         https://bugs.webkit.org/show_bug.cgi?id=136571
3710
3711         Reviewed by Darin Adler.
3712
3713         * Configurations/FeatureDefines.xcconfig:
3714
3715 2014-09-08  Jessie Berlin  <jberlin@apple.com>
3716
3717         32-bit build fix after r173364.
3718
3719         * Carbon/HIViewAdapter.m:
3720         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
3721
3722 2014-09-08  Dan Bernstein  <mitz@apple.com>
3723
3724         Build fix.
3725
3726         Added back SPI that is still in use.
3727
3728         * Misc/WebNSURLExtras.h:
3729         * Misc/WebNSURLExtras.mm:
3730         (-[NSURL _webkit_URLByRemovingFragment]):
3731
3732 2014-09-08  Dan Bernstein  <mitz@apple.com>
3733
3734         iOS Simulator build fix.
3735
3736         * Misc/WebKitSystemBits.m:
3737         (WebMemorySize):
3738
3739 2014-09-07  Darin Adler  <darin@apple.com>
3740
3741         Fix build failure seen on Mountain Lion buildbot.
3742
3743         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
3744         of an int, to avoid warning about mixing signs.
3745
3746 2014-09-06  Darin Adler  <darin@apple.com>
3747
3748         Make updates suggested by new version of Xcode
3749         https://bugs.webkit.org/show_bug.cgi?id=136603
3750
3751         Reviewed by Mark Rowe.
3752
3753         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
3754         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
3755
3756         * History/WebURLsWithTitles.m:
3757         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
3758         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
3759         not turned on because it gives us too many false positives).
3760         * Misc/WebElementDictionary.mm:
3761         (-[WebElementDictionary objectForKey:]): Ditto.
3762         * Misc/WebNSDataExtras.m:
3763         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
3764         (-[NSData _webkit_guessedMIMEType]): Ditto.
3765         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
3766         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
3767
3768         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
3769         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
3770         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
3771         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
3772         and _webkit_URLFragment methods.
3773
3774         * Misc/WebNSURLExtras.mm:
3775         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
3776         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
3777         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
3778         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
3779         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
3780         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
3781         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
3782         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
3783         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
3784         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
3785         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
3786         (-[NSString _webkit_URLFragment]): Deleted.
3787
3788         * Plugins/WebPluginDatabase.mm:
3789         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
3790         to iterate an array instead of a loop using the type "unsigned int".
3791
3792         * WebCoreSupport/WebOpenPanelResultListener.mm:
3793         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
3794
3795         * WebView/WebDelegateImplementationCaching.mm:
3796         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
3797         directly without a proper type for the function pointer. This might have been causing
3798         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
3799         functions that were already doing this correctly.
3800
3801         * WebView/WebTextCompletionController.mm:
3802         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
3803
3804 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
3805
3806         Web Inspector: convert DockSide to an enum class
3807         https://bugs.webkit.org/show_bug.cgi?id=136601
3808
3809         Reviewed by Timothy Hatcher.
3810
3811         * WebCoreSupport/WebInspectorClient.mm:
3812         (WebInspectorFrontendClient::frontendLoaded):
3813         (-[WebInspectorWindowController attachWindow:]):
3814         (-[WebInspectorWindowController attach]):
3815         (-[WebInspectorWindowController detach]):
3816         * WebInspector/WebInspectorFrontend.mm:
3817         (-[WebInspectorFrontend attach]):
3818
3819 2014-09-05  Commit Queue  <commit-queue@webkit.org>
3820
3821         Unreviewed, rolling out r173340 and r173342.
3822         https://bugs.webkit.org/show_bug.cgi?id=136596
3823
3824         Broke many tests (Requested by ap on #webkit).
3825
3826         Reverted changesets:
3827
3828         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3829         https://bugs.webkit.org/show_bug.cgi?id=136474
3830         http://trac.webkit.org/changeset/173340
3831
3832         "Build fix after r173340."
3833         http://trac.webkit.org/changeset/173342
3834
3835 2014-09-05  Enrica Casucci  <enrica@apple.com>
3836
3837         Build fix after r173340.
3838
3839         * WebCoreSupport/WebEditorClient.h:
3840         (kit):
3841         (core):
3842
3843 2014-09-05  Enrica Casucci  <enrica@apple.com>
3844
3845         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3846         https://bugs.webkit.org/show_bug.cgi?id=136474
3847
3848         Reviewed by Benjamin Poulain.
3849
3850         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3851         and removes the assumption that EAffinity values match NSSelectionAffinity
3852         values. It also removes the includes in TextAffinity.h, creating the need to
3853         include explicitly the files when necessary. It also removes the unnecessary
3854         use of platform specific types, replacing them with WebCore types.
3855
3856         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
3857         * WebView/WebFrameView.mm:
3858         (-[WebFrameView _scrollToBeginningOfDocument]):
3859         (-[WebFrameView _scrollToEndOfDocument]):
3860
3861 2014-09-05  Daniel Bates  <dabates@apple.com>
3862
3863         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3864         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3865
3866         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
3867
3868         * WebView/WebHTMLView.mm:
3869         (-[WebHTMLView viewDidMoveToWindow]):
3870
3871 2014-09-05  Daniel Bates  <dabates@apple.com>
3872
3873         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3874         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3875
3876         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
3877         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
3878
3879         * WebView/WebHTMLView.mm:
3880         (-[WebHTMLView viewDidMoveToWindow]):
3881
3882 2014-09-05  Daniel Bates  <dabates@apple.com>
3883
3884         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
3885         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3886
3887         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
3888
3889         * WebView/WebHTMLView.mm:
3890         (-[WebHTMLView setDataSource:]):
3891
3892 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
3893
3894         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
3895         https://bugs.webkit.org/show_bug.cgi?id=136564
3896
3897         Reviewed by Dan Bernstein.
3898         
3899         WebKit1 depended on mouse moved event notifications to track mouse
3900         moves, and on being specially called by Safari to track flags
3901         changes. WebKit2 does both these things better - it uses a tracking area
3902         and event monitors. Copy those approaches.
3903
3904         * WebKit.order: Remove reference to obsolete call.
3905         * WebView/WebHTMLView.mm:
3906         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
3907         area, since we now just always have one.
3908         (-[WebHTMLViewPrivate clear]): ditto
3909         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
3910         New method that posts a fake mouse move event in response to
3911         a flags change event, for use by the event monitor.
3912         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
3913         still kept around for benefit of older Safari.
3914         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
3915         special mouseover mode (previously handled in a weird way).
3916         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
3917         (-[WebHTMLView viewWillMoveToWindow:]): ditto
3918         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
3919         changed monitor.
3920         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
3921         tracking area or mouse moved observer.
3922         (-[WebHTMLView windowDidResignKey:]): ditto
3923         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
3924         moved observer.
3925         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
3926         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
3927         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
3928         up tracking area - we have to do it here, because before this point, the
3929         WebHTMLView does not know its WebView, which is where dashboard settings
3930         live.
3931         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
3932         (-[WebHTMLView addMouseMovedObserver]): Deleted.
3933         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
3934
3935 2014-09-04  Pratik Solanki  <psolanki@apple.com>
3936
3937         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
3938         https://bugs.webkit.org/show_bug.cgi?id=136560
3939
3940         Reviewed by Joseph Pecoraro.
3941
3942         I removed the disk image caching code in r173265. However, we still have clients that call
3943         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
3944
3945         * WebView/WebPreferences.mm:
3946         (-[WebPreferences setDiskImageCacheEnabled:]):
3947         * WebView/WebPreferencesPrivate.h:
3948
3949 2014-09-03  Andy Estes  <aestes@apple.com>
3950
3951         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
3952         https://bugs.webkit.org/show_bug.cgi?id=136521
3953
3954         Reviewed by Anders Carlsson.
3955
3956         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
3957
3958             s/(^ *)WEBCORE_EXPORT /\1/g
3959
3960         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
3961
3962         * MigrateHeaders.make:
3963
3964 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
3965
3966         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
3967         https://bugs.webkit.org/show_bug.cgi?id=136527
3968
3969         Reviewed by Alexey Proskuryakov.
3970
3971         * WebCoreSupport/WebSystemInterface.mm:
3972         (InitWebCoreSystemInterface):
3973
3974 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3975
3976         Remove CSS_FILTERS flag
3977         https://bugs.webkit.org/show_bug.cgi?id=136529
3978
3979         Reviewed by Dirk Schulze.
3980
3981         * Configurations/FeatureDefines.xcconfig:
3982
3983 2014-09-04  Pratik Solanki  <psolanki@apple.com>
3984
3985         Remove iOS specific disk image cache
3986         https://bugs.webkit.org/show_bug.cgi?id=136517
3987
3988         Reviewed by Antti Koivisto.
3989
3990         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
3991         this now since we don't enable it in WebKit2 on iOS.
3992
3993         * Misc/WebCache.mm:
3994         (+[WebCache statistics]):
3995         * WebView/WebDataSource.mm:
3996         (-[WebDataSource _setAllowToBeMemoryMapped]):
3997         (-[WebDataSource setDataSourceDelegate:]):
3998         (-[WebDataSource dataSourceDelegate]):
3999         (-[WebDataSource dealloc]):
4000         (BufferMemoryMapped): Deleted.
4001         * WebView/WebPreferenceKeysPrivate.h:
4002         * WebView/WebPreferences.mm:
4003         (+[WebPreferences initialize]):
4004         (-[WebPreferences diskImageCacheEnabled]): Deleted.
4005         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
4006         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
4007         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
4008         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
4009         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
4010         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
4011         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
4012         * WebView/WebPreferencesPrivate.h:
4013         * WebView/WebView.mm:
4014         (-[WebView _commonInitializationWithFrameName:groupName:]):
4015         (+[WebView _handleMemoryWarning]):
4016         (-[WebView _preferencesChanged:]):
4017
4018 2014-09-04  Daniel Bates  <dabates@apple.com>
4019
4020         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
4021         https://bugs.webkit.org/show_bug.cgi?id=136494
4022
4023         Reviewed by Andy Estes.
4024
4025         * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined.
4026         * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
4027
4028 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
4029
4030         Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
4031         https://bugs.webkit.org/show_bug.cgi?id=136476
4032
4033         Reviewed by Timothy Hatcher.
4034
4035         * Misc/WebCoreStatistics.mm:
4036         (+[WebCoreStatistics shouldPrintExceptions]):
4037         (+[WebCoreStatistics setShouldPrintExceptions:]):
4038
4039 2014-09-03  Enrica Casucci  <enrica@apple.com>
4040
4041         Remove PLATFORM(IOS) from WebCore/editing (Part 1).
4042         https://bugs.webkit.org/show_bug.cgi?id=136474
4043
4044         Reviewed by Tim Horton.
4045
4046         * WebCoreSupport/WebEditorClient.mm:
4047         (undoNameForEditAction):
4048
4049 2014-09-02  Maciej Stachowiak  <mjs@apple.com>
4050
4051         Clean up naming for and slightly refactor legacy video fullscreen support
4052         https://bugs.webkit.org/show_bug.cgi?id=136446
4053
4054         Reviewed by Jer Noble.
4055
4056         Key changes:
4057         supportsFullscreenForNode(Node*) --> supportsVideoFullscreen()
4058         enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*)
4059         exitFullscreenForNode(Node*) --> exitVideoFullscreen()
4060         
4061         The old versions had unnecessary parameters, did not clearly distinguish their purpose
4062         from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes.
4063         Also changed many other places to use HTMLVideoElement* instead of Node* or 
4064         HTMLMediaElement* when they were in fact only used for video elements and would only
4065         work for such.
4066
4067         * WebCoreSupport/WebChromeClient.h:
4068         * WebCoreSupport/WebChromeClient.mm:
4069         (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring.
4070         Also no more need to check for video elementness.
4071         (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring.
4072         (WebChromeClient::exitVideoFullscreen): ditto
4073         * WebView/WebView.mm:
4074         (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main
4075         refactoring.
4076         (-[WebView _exitVideoFullscreen]): ditto
4077         (-[WebView _close]): ditto
4078         * WebView/WebViewInternal.h:
4079
4080 2014-09-03  Dan Bernstein  <mitz@apple.com>
4081
4082         Get rid of HIGH_DPI_CANVAS leftovers
4083         https://bugs.webkit.org/show_bug.cgi?id=136491
4084
4085         Reviewed by Benjamin Poulain.
4086
4087         * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS
4088         and removed it from FEATURE_DEFINES.
4089
4090 2014-08-31  Tim Horton  <timothy_horton@apple.com>
4091
4092         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
4093         https://bugs.webkit.org/show_bug.cgi?id=136416
4094
4095         Reviewed by Dan Bernstein.
4096
4097         * WebView/WebFrameView.mm:
4098         (-[WebFrameView drawRect:]):
4099         We only end up filling, so only set the fill color.
4100
4101 2014-08-26  Maciej Stachowiak  <mjs@apple.com>
4102
4103         Use RetainPtr::autorelease in some places where it seems appropriate
4104         https://bugs.webkit.org/show_bug.cgi?id=136280
4105
4106         Reviewed by Darin Adler.
4107
4108         * WebView/WebHTMLView.mm:
4109         (imageFromRect): Use RetainPtr in this function.
4110         * WebView/WebPDFRepresentation.mm:
4111         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
4112         in this method.
4113
4114 2014-08-29  Csaba Osztrogonác  <ossy@webkit.org>
4115
4116         Unreviwed, remove empty directories.
4117
4118         * ForwardingHeaders/wtf: Removed.
4119
4120 2014-08-27  Zalan Bujtas  <zalan@apple.com>
4121
4122         Subpixel layout: Rename LayoutRect's device pixel snapping functions.
4123         https://bugs.webkit.org/show_bug.cgi?id=136319
4124
4125         Reviewed by Simon Fraser.
4126
4127         From pixelSnappedForPainting() to snapRectToDevicePixels() and 
4128         pixelSnappedIntRect*() to snappedIntRect*().
4129
4130         No change in functionality.
4131
4132         * WebView/WebView.mm:
4133         (-[WebView _dashboardRegions]):
4134         (-[WebView trackedRepaintRects]):
4135
4136 2014-08-25  Maciej Stachowiak  <mjs@apple.com>
4137
4138         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
4139         https://bugs.webkit.org/show_bug.cgi?id=136082
4140
4141         Reviewed by Alexey Proskuryakov.
4142
4143         * Plugins/Hosted/NetscapePluginHostManager.mm:
4144         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
4145         localization name using WebCore helper instead of SPI.
4146         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
4147         file.
4148         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current
4149         localization name using WebCore helper instead of SPI.
4150         (+[WebBasePluginPackage preferredLocalizationName]): Deleted. This
4151         helper no longer pulls its weight.
4152         * WebCoreSupport/WebSystemInterface.mm: 
4153         (InitWebCoreSystemInterface): Remove mention of
4154         WKCopyCFLocalizationPreferredName.
4155         * WebKit.order: ditto
4156
4157 2014-08-25  Daniel Bates  <dabates@apple.com>
4158
4159         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/172889>
4160         (https://bugs.webkit.org/show_bug.cgi?id=109658)
4161
4162         Substitute GraphicsLayer::setContentsToPlatformLayer(..., GraphicsLayer::ContentsLayerForMedia)
4163         for GraphicsLayer::setContentsToMedia(...) because the latter was removed in <http://trac.webkit.org/changeset/172889>.
4164
4165         * WebView/WebView.mm:
4166         (-[WebView _setMediaLayer:forPluginView:]):
4167
4168 2014-08-22  Commit Queue  <commit-queue@webkit.org>
4169
4170         Unreviewed, rolling out r172866.
4171         https://bugs.webkit.org/show_bug.cgi?id=136177
4172
4173         Broke iOS build (Requested by othermaciej on #webkit).
4174
4175         Reverted changeset:
4176
4177         "Replace use of WKCopyCFLocalizationPreferredName with
4178         NSLocale public API"
4179         https://bugs.webkit.org/show_bug.cgi?id=136082
4180         http://trac.webkit.org/changeset/172866
4181
4182 2014-08-22  Simon Fraser  <simon.fraser@apple.com>
4183
4184         Implement paint flashing in the WK1 InspectorOverlay page
4185         https://bugs.webkit.org/show_bug.cgi?id=136138
4186
4187         Reviewed by Sam Weinig, Joseph Pecoraro.
4188
4189         Implement paint flashing for the WebKit1 InspectorOverlay via a second canvas in the overlay page.
4190         We avoid allocating backing store for this canvas until we have paint rects.
4191         
4192         Because this overlay page is weird and doesn't know how to paint itself, InspectorOverlay manages
4193         an array of rects, and pushes them to the page when they change, before forcing a paint.
4194         
4195         Because iOS doesn't use the InspectorOverlay page, stub out setShowPaintRects on its
4196         WebKit WebInspectorClient, but don't yet implement paint flashing there.
4197
4198         * WebCoreSupport/WebInspectorClient.h:
4199         * WebCoreSupport/WebInspectorClient.mm:
4200         (WebInspectorClient::WebIn