94cf0e58cfba58c2e4dbaa3de7dd2f4dfca1c000
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-01-05  Andreas Kling  <akling@apple.com>
2
3         Remove ChromeClient::needTouchEvents().
4         <https://webkit.org/b/166723>
5
6         Rubber-stamped by Antti Koivisto.
7
8         * WebCoreSupport/WebChromeClient.h:
9
10 2017-01-04  Darin Adler  <darin@apple.com>
11
12         Remove PassRefPtr use from the "html" directory, other improvements
13         https://bugs.webkit.org/show_bug.cgi?id=166635
14
15         Reviewed by Alex Christensen.
16
17         * WebCoreSupport/WebChromeClient.h:
18         * WebCoreSupport/WebChromeClient.mm:
19         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
20
21 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
22
23         Unreviewed, rolling out r210287.
24
25         This change caused editing test failures on macOS.
26
27         Reverted changeset:
28
29         "Support File Promise during drag for macOS."
30         https://bugs.webkit.org/show_bug.cgi?id=165204
31         http://trac.webkit.org/changeset/210287
32
33 2017-01-04  Enrica Casucci  <enrica@apple.com>
34
35         Support File Promise during drag for macOS.
36         https://bugs.webkit.org/show_bug.cgi?id=165204
37         rdar://problem/19595567
38
39         Reviewed by Tim Horton.
40
41         Adds support for dropping a File Promise in a WebView.
42         The implementation uses new File Promise API available in Sierra.
43
44         * Misc/WebNSPasteboardExtras.mm:
45         (+[NSPasteboard _web_dragTypesForURL]):
46         * WebView/WebView.mm:
47         (-[WebView performDragOperation:]):
48
49 2017-01-04  Tim Horton  <timothy_horton@apple.com>
50
51         Provide a setting for clients to always prefer low-power WebGL
52         https://bugs.webkit.org/show_bug.cgi?id=166675
53         <rdar://problem/29834093>
54
55         Reviewed by Dan Bernstein.
56
57         * WebView/WebPreferenceKeysPrivate.h:
58         * WebView/WebPreferences.mm:
59         (+[WebPreferences initialize]):
60         (-[WebPreferences preferLowPowerWebGLRendering]):
61         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
62         * WebView/WebPreferencesPrivate.h:
63         * WebView/WebView.mm:
64         (-[WebView _preferencesChanged:]):
65         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
66
67 2017-01-03  Tim Horton  <timothy_horton@apple.com>
68
69         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
70         https://bugs.webkit.org/show_bug.cgi?id=166450
71         <rdar://problem/29447824>
72
73         Reviewed by Darin Adler.
74
75         * WebCoreSupport/CorrectionPanel.h:
76         * WebCoreSupport/CorrectionPanel.mm:
77         (CorrectionPanel::recordAutocorrectionResponse):
78         (CorrectionPanel::handleAcceptedReplacement):
79         * WebCoreSupport/WebAlternativeTextClient.mm:
80         (toCorrectionResponse):
81         (WebAlternativeTextClient::recordAutocorrectionResponse):
82         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
83         through recordAutocorrectionResponse, for debugging's sake.
84         Drop the NSView parameter because we don't need it, just the tag.
85         Convert the new AutocorrectionResponseType value to its corresponding
86         NSCorrectionResponse value.
87
88 2017-01-01  Jeff Miller  <jeffm@apple.com>
89
90         Update user-visible copyright strings to include 2017
91         https://bugs.webkit.org/show_bug.cgi?id=166278
92
93         Reviewed by Dan Bernstein.
94
95         * Info.plist:
96
97 2016-12-30  Darin Adler  <darin@apple.com>
98
99         Remove PassRefPtr use from the "dom" directory, related cleanup
100         https://bugs.webkit.org/show_bug.cgi?id=166569
101
102         Reviewed by Alex Christensen.
103
104         * WebCoreSupport/WebFrameLoaderClient.mm:
105         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
106         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
107         (WebFrameLoaderClient::setTitle): Ditto.
108         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
109         * WebView/WebFrame.mm:
110         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
111         Not needed now, but useful later if we ever can get rid of the explicit constructors.
112         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
113         * WebView/WebHTMLRepresentation.mm:
114         (-[WebHTMLRepresentation title]): Updated to use struct.
115
116 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
117
118         Propagate the source origin as much as possible
119         https://bugs.webkit.org/show_bug.cgi?id=166348
120
121         Reviewed by Darin Adler.
122
123         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
124         (WebKit::NetscapePluginInstanceProxy::evaluate):
125
126 2016-12-23  Andy Estes  <aestes@apple.com>
127
128         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
129         https://bugs.webkit.org/show_bug.cgi?id=166471
130
131         Reviewed by Andreas Kling.
132
133         When DumpRenderTree starts up, it calls
134         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
135         builds, this triggers the ASSERT(isMainThread()) in
136         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
137         started, we are on the main thread, and we are not holding the Web thread lock. This is
138         causing all layout tests to crash in the iOS WK1 Debug configuration.
139
140         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
141         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
142
143 2016-12-22  Andy Estes  <aestes@apple.com>
144
145         Make WebCore::EditorInsertAction an enum class
146         https://bugs.webkit.org/show_bug.cgi?id=166424
147
148         Reviewed by Brent Fulgham.
149
150         * WebCoreSupport/WebEditorClient.mm:
151         (kit):
152
153 2016-12-21  Beth Dakin  <bdakin@apple.com>
154
155         Holding down on candidates in the TouchBar should show panel on screen
156         https://bugs.webkit.org/show_bug.cgi?id=166367
157         -and corresponding-
158         <rdar://problem/28479236>
159
160         Reviewed by Tim Horton.
161
162         Stray whitespace.
163         * WebCoreSupport/WebEditorClient.mm:
164         (WebEditorClient::handleRequestedCandidates):
165
166         Call the version of setCandidates: that takes a rect. We need to keep the helper 
167         function in WK1 (unlike WK2) since we also use it for testing.
168         * WebView/WebView.mm:
169         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
170
171 2016-12-20  Dean Jackson  <dino@apple.com>
172
173         Remove INDIE_UI
174         https://bugs.webkit.org/show_bug.cgi?id=165881
175         <rdar://problem/29672532>
176
177         Reviewed by Simon Fraser.
178
179         The Indie UI work has been discontinued.
180
181         * Configurations/FeatureDefines.xcconfig:
182
183 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
184
185         [ES6] Enable ES6 Modules
186         https://bugs.webkit.org/show_bug.cgi?id=165849
187
188         Reviewed by Geoffrey Garen.
189
190         * WebView/WebPreferenceKeysPrivate.h:
191         * WebView/WebPreferences.mm:
192         (+[WebPreferences initialize]):
193         (-[WebPreferences es6ModulesEnabled]): Deleted.
194         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
195         * WebView/WebPreferencesPrivate.h:
196         * WebView/WebView.mm:
197         (-[WebView _preferencesChanged:]):
198
199 2016-12-16  Dave Hyatt  <hyatt@apple.com>
200
201         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
202         https://bugs.webkit.org/show_bug.cgi?id=165968
203
204         Reviewed by Andreas Kling.
205
206         * DOM/DOMCSS.mm:
207         (kitClass):
208         * DOM/DOMCSSPrimitiveValue.mm:
209         (-[DOMCSSPrimitiveValue getCounterValue]):
210         (-[DOMCSSPrimitiveValue getRectValue]):
211         (kit):
212         * DOM/DOMCSSPrimitiveValueInternal.h:
213         * DOM/DOMCSSStyleDeclaration.mm:
214         * DOM/DOMCSSValue.mm:
215         (kit):
216         * DOM/DOMCSSValueInternal.h:
217         * DOM/DOMCSSValueList.mm:
218         * DOM/DOMCounter.mm:
219         (kit):
220         * DOM/DOMCounterInternal.h:
221         * DOM/DOMRGBColor.mm:
222         (kit):
223         * DOM/DOMRGBColorInternal.h:
224         * DOM/DOMRect.mm:
225         (kit):
226         * DOM/DOMRectInternal.h:
227         * DOM/DOMUtility.mm:
228         (createDOMWrapper):
229
230 2016-12-16  Chris Dumez  <cdumez@apple.com>
231
232         HTML form validation bubble should be dismissed on navigation
233         https://bugs.webkit.org/show_bug.cgi?id=165960
234         <rdar://problem/29668086>
235
236         Reviewed by Simon Fraser.
237
238         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
239
240         * WebView/WebView.mm:
241         (-[WebView _didStartProvisionalLoadForFrame:]):
242
243 2016-12-15  Darin Adler  <darin@apple.com>
244
245         Use asString instead of toWTFString, toString, or getString when we already checked isString
246         https://bugs.webkit.org/show_bug.cgi?id=165895
247
248         Reviewed by Yusuke Suzuki.
249
250         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
251         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
252         toWTFString.
253         * WebView/WebView.mm:
254         (aeDescFromJSValue): Use asString/value instead of getString.
255
256 2016-12-15  Chris Dumez  <cdumez@apple.com>
257
258         Make sure HTML validation bubble's state is updated after layout
259         https://bugs.webkit.org/show_bug.cgi?id=165922
260         <rdar://problem/29694730>
261
262         Reviewed by Simon Fraser.
263
264         Make sure HTML validation bubble's state is updated after layout.
265         In particular, if the validation bubble's associated element has
266         moved or is no longer visible, we now hide the bubble.
267
268         * WebCoreSupport/WebValidationMessageClient.h:
269         * WebCoreSupport/WebValidationMessageClient.mm:
270         (WebValidationMessageClient::showValidationMessage):
271         (WebValidationMessageClient::hideValidationMessage):
272         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
273
274 2016-12-15  Chris Dumez  <cdumez@apple.com>
275
276         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
277         https://bugs.webkit.org/show_bug.cgi?id=165904
278
279         Reviewed by Sam Weinig.
280
281         Update ObjC bindings so they keep building.
282
283         * DOM/DOMUIEvent.mm:
284         (-[DOMUIEvent keyCode]):
285         (-[DOMUIEvent charCode]):
286
287 2016-12-15  Andreas Kling  <akling@apple.com>
288
289         Always clear RenderLayer backing stores when going into page cache.
290         <https://webkit.org/b/165901>
291
292         Reviewed by Simon Fraser.
293
294         * WebView/WebView.mm:
295         (+[WebView _setCacheModel:]):
296
297 2016-12-12  Alex Christensen  <achristensen@webkit.org>
298
299         Remove unused workaround for Silverlight
300         https://bugs.webkit.org/show_bug.cgi?id=165773
301
302         Reviewed by Dean Jackson.
303
304         * Plugins/WebNetscapePluginView.mm:
305         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
306         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
307         Allowing 6 years for users to update Silverlight is more than enough.
308         Safari doesn't even use WebKit1 for this any more.
309         I need this to be removed because this is the only non-WebGL code that needs to link against
310         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
311
312 2016-12-12  Chris Dumez  <cdumez@apple.com>
313
314         Document.visibilityState should use an IDL string enumeration
315         https://bugs.webkit.org/show_bug.cgi?id=165774
316
317         Reviewed by Daniel Bates.
318
319         * DOM/DOMDocument.mm:
320         (-[DOMDocument visibilityState]):
321         * WebView/WebView.mm:
322         (kit):
323
324 2016-12-12  Jer Noble  <jer.noble@apple.com>
325
326         Remove implementation of legacy Mozilla-based Fullscreen API.
327         https://bugs.webkit.org/show_bug.cgi?id=165689
328         <rdar://problem/29603053>
329
330         Reviewed by Eric Carlson.
331
332         * DOM/DOMElement.mm:
333         (-[DOMElement webkitRequestFullScreen:]):
334
335 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
336
337         The DOM should have an advancing wavefront opaque root barrier
338         https://bugs.webkit.org/show_bug.cgi?id=165712
339
340         Reviewed by Yusuke Suzuki.
341         
342         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
343
344         * Misc/WebCoreStatistics.mm:
345         (+[WebCoreStatistics javaScriptObjectsCount]):
346         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
347         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
348         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
349         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
350         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
351         (+[WebCoreStatistics shouldPrintExceptions]):
352         (+[WebCoreStatistics setShouldPrintExceptions:]):
353         (+[WebCoreStatistics memoryStatistics]):
354         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
355         * Plugins/Hosted/NetscapePluginHostProxy.mm:
356         (identifierFromIdentifierRep):
357         * Plugins/Hosted/ProxyInstance.mm:
358         (WebKit::ProxyInstance::getPropertyNames):
359         * Plugins/WebNetscapePluginStream.mm:
360         (WebNetscapePluginStream::wantsAllStreams):
361         * Plugins/WebNetscapePluginView.mm:
362         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
363         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
364         (-[WebNetscapePluginView setWindowIfNecessary]):
365         (-[WebNetscapePluginView createPluginScriptableObject]):
366         (-[WebNetscapePluginView getFormValue:]):
367         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
368         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
369         (-[WebNetscapePluginView loadPluginRequest:]):
370         (-[WebNetscapePluginView _printedPluginBitmap]):
371         * Plugins/WebPluginController.mm:
372         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
373         (-[WebPluginController stopOnePlugin:]):
374         (-[WebPluginController stopOnePluginForPageCache:]):
375         (-[WebPluginController destroyOnePlugin:]):
376         (-[WebPluginController startAllPlugins]):
377         (-[WebPluginController addPlugin:]):
378
379 2016-12-09  Dave Hyatt  <hyatt@apple.com>
380
381         [CSS Parser] Remove the old CSS Parser
382         https://bugs.webkit.org/show_bug.cgi?id=165645
383
384         Reviewed by Daniel Bates.
385
386         * DOM/DOMCSS.mm:
387         (kitClass):
388         * DOM/DOMCSSRule.h:
389
390 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
391
392         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
393         https://bugs.webkit.org/show_bug.cgi?id=165251
394
395         Reviewed by Dean Jackson.
396
397         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
398
399         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
400         * WebView/WebPreferences.mm:
401         (+[WebPreferences initialize]):
402         (-[WebPreferences mediaStreamEnabled]):
403         (-[WebPreferences setMediaStreamEnabled:]):
404         (-[WebPreferences peerConnectionEnabled]):
405         (-[WebPreferences setPeerConnectionEnabled:]):
406         * WebView/WebPreferencesPrivate.h:
407         * WebView/WebView.mm:
408         (-[WebView _preferencesChanged:]):
409
410 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
411
412         Don’t expose pointer lock in WebKit1 Objective-C API
413         https://bugs.webkit.org/show_bug.cgi?id=165692
414
415         Reviewed by Simon Fraser.
416
417         * DOM/DOMDocument.mm:
418         (-[DOMDocument pointerLockElement]): Deleted.
419         (-[DOMDocument exitPointerLock]): Deleted.
420         * DOM/DOMElement.mm:
421         (-[DOMElement requestPointerLock]): Deleted.
422         * DOM/DOMMouseEvent.mm:
423         (-[DOMMouseEvent movementX]): Deleted.
424         (-[DOMMouseEvent movementY]): Deleted.
425
426 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
427
428         document.webkitFullscreenElement leaks elements inside a shadow tree
429         https://bugs.webkit.org/show_bug.cgi?id=158471
430
431         Reviewed by Chris Dumez.
432
433         Use the API for bindings to avoid exposing nodes inside a shadow tree.
434
435         * DOM/DOMDocument.mm:
436         (-[DOMDocument webkitCurrentFullScreenElement]):
437         (-[DOMDocument webkitFullscreenElement]):
438
439 2016-12-09  Beth Dakin  <bdakin@apple.com>
440
441         Password fields should not show the emoji button in TouchBar
442         https://bugs.webkit.org/show_bug.cgi?id=165673
443         -and corresponding-
444         rdar://problem/29235739
445
446         Reviewed by Wenson Hsieh.
447
448         This patch adds a new ivar for the password touch bar and password 
449         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
450         of identifiers than the plain text TouchBar, it should just have its own variable.
451
452         The candidate list should be the only item for passwords.
453         * WebView/WebView.mm:
454         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
455
456         Account for _passwordTextTouchBar.
457         (-[WebView didChangeAutomaticTextCompletion:]):
458         (-[WebView setUpTextTouchBar:]):
459         (-[WebView textTouchBar]):
460
461         The empty candidates array is not needed. We can just set @[ ] as the candidates 
462         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
463         other parts of the code to prevent us from requesting or setting other candidates 
464         when in a password field. 
465         (-[WebView updateTextTouchBar]):
466
467         Account for _passwordTextTouchBar.
468         (-[WebView candidateList]):
469         * WebView/WebViewData.h:
470
471 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
472
473         Enable SharedArrayBuffer, remove the flag
474         https://bugs.webkit.org/show_bug.cgi?id=165614
475
476         Rubber stamped by Geoffrey Garen.
477
478         * WebView/WebPreferencesPrivate.h:
479
480 2016-12-07  Dean Jackson  <dino@apple.com>
481
482         Remove runtime toggle for pointer-lock
483         https://bugs.webkit.org/show_bug.cgi?id=165577
484         <rdar://problems/29566996>
485
486         Reviewed by Jon Lee.
487
488         Remove any runtime calls to check if pointer-lock is enabled. It's
489         either compiled in or out.
490
491         * WebView/WebPreferenceKeysPrivate.h:
492         * WebView/WebPreferences.mm:
493         (-[WebPreferences pointerLockEnabled]): Deleted.
494         (-[WebPreferences setPointerLockEnabled:]): Deleted.
495         * WebView/WebPreferencesPrivate.h:
496         * WebView/WebView.mm:
497         (-[WebView _preferencesChanged:]):
498
499 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
500
501         Correct SDKROOT values in xcconfig files
502         https://bugs.webkit.org/show_bug.cgi?id=165487
503         rdar://problem/29539209
504
505         Reviewed by Dan Bernstein.
506
507         Fix suggested by Dan Bernstein.
508
509         * Configurations/DebugRelease.xcconfig:
510
511 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
512
513         Improve the behavior of scroll-into-view when the target is inside position:fixed
514         https://bugs.webkit.org/show_bug.cgi?id=165354
515
516         Reviewed by Zalan Bujtas.
517
518         Plumb through 'insideFixed'. We don't get compute it, so behavior from
519         these call sites won't change.
520
521         * WebView/WebFrame.mm:
522         (-[WebFrame _scrollDOMRangeToVisible:]):
523         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
524
525 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
526
527         Enable visual viewports by default on Mac, and iOS Wk2
528         https://bugs.webkit.org/show_bug.cgi?id=165452
529
530         Reviewed by Zalan Bujtas.
531
532         Turn visual viewports on by default for WK1 on Mac.
533
534         * WebView/WebPreferences.mm:
535         (+[WebPreferences initialize]):
536
537 2016-12-05  Dean Jackson  <dino@apple.com>
538
539         pointer lock needs to be feature detectable
540         https://bugs.webkit.org/show_bug.cgi?id=165426
541         <rdar://problem/29486715>
542
543         Reviewed by Antoine Quint.
544
545         Set the RuntimeEnabledFeature as preferences
546         change.
547
548         * WebView/WebView.mm:
549         (-[WebView _preferencesChanged:]):
550
551 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
552
553         Unreviewed, rolling out r209299.
554
555         This change appears to have caused LayoutTest failures on
556         Sierra WK1.
557
558         Reverted changeset:
559
560         "Improve the behavior of scroll-into-view when the target is
561         inside position:fixed"
562         https://bugs.webkit.org/show_bug.cgi?id=165354
563         http://trac.webkit.org/changeset/209299
564
565 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
566
567         Improve the behavior of scroll-into-view when the target is inside position:fixed
568         https://bugs.webkit.org/show_bug.cgi?id=165354
569
570         Reviewed by Zalan Bujtas.
571
572         Plumb through 'insideFixed'. We don't get compute it, so behavior from
573         these call sites won't change.
574
575         * WebView/WebFrame.mm:
576         (-[WebFrame _scrollDOMRangeToVisible:]):
577         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
578
579 2016-12-02  Andy Estes  <aestes@apple.com>
580
581         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
582         https://bugs.webkit.org/show_bug.cgi?id=164492
583
584         Reviewed by Dan Bernstein.
585
586         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
587         com.apple.$(PRODUCT_NAME:rfc1034identifier).
588         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
589         ${PRODUCT_BUNDLE_IDENTIFIER}.
590
591 2016-12-02  Chris Dumez  <cdumez@apple.com>
592
593         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
594         https://bugs.webkit.org/show_bug.cgi?id=165328
595
596         Reviewed by Simon Fraser.
597
598         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
599
600         * WebView/WebViewData.mm:
601         (-[WebViewPrivate init]):
602
603 2016-12-02  Chris Dumez  <cdumez@apple.com>
604
605         [Mac][WK1] Implement new HTML interactive form validation user interface
606         https://bugs.webkit.org/show_bug.cgi?id=164483
607
608         Reviewed by Simon Fraser.
609
610         Implement new HTML interactive form validation user interface on Mac
611         WK1 and enable it by default.
612
613         * WebCoreSupport/WebValidationMessageClient.h: Added.
614         * WebCoreSupport/WebValidationMessageClient.mm: Added.
615         (WebValidationMessageClient::WebValidationMessageClient):
616         (WebValidationMessageClient::~WebValidationMessageClient):
617         (WebValidationMessageClient::showValidationMessage):
618         (WebValidationMessageClient::hideValidationMessage):
619         (WebValidationMessageClient::isValidationMessageVisible):
620         * WebView/WebHTMLView.mm:
621         (-[WebHTMLView _frameOrBoundsChanged]):
622         * WebView/WebView.mm:
623         (-[WebView _commonInitializationWithFrameName:groupName:]):
624         (-[WebView _willStartScrollingOrZooming]):
625         (-[WebView _contentsOfUserInterfaceItem:]):
626         (-[WebView _scaleWebView:atOrigin:]):
627         (-[WebView _didScrollDocumentInFrameView:]):
628         (-[WebView _setZoomMultiplier:isTextOnly:]):
629         (-[WebView showFormValidationMessage:withAnchorRect:]):
630         (-[WebView hideFormValidationMessage]):
631         * WebView/WebViewData.h:
632         * WebView/WebViewData.mm:
633         (-[WebViewPrivate init]):
634         * WebView/WebViewInternal.h:
635         * WebView/WebViewPrivate.h:
636
637 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
638
639         Add a runtime flag for SubtleCrypto
640         https://bugs.webkit.org/show_bug.cgi?id=164982
641
642         Reviewed by Brent Fulgham.
643
644         * WebView/WebPreferenceKeysPrivate.h:
645         * WebView/WebPreferences.mm:
646         (+[WebPreferences initialize]):
647         (-[WebPreferences subtleCryptoEnabled]):
648         (-[WebPreferences setSubtleCryptoEnabled:]):
649         * WebView/WebPreferencesPrivate.h:
650         * WebView/WebView.mm:
651         (-[WebView _preferencesChanged:]):
652
653 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
654
655         Add separate settings and preferences to enable/disable async decoding for large images and animated images
656         https://bugs.webkit.org/show_bug.cgi?id=165177
657
658         Reviewed by Simon Fraser.
659         
660         Hook up the async image decoding settings for WebKit1.
661
662         * WebView/WebPreferenceKeysPrivate.h:
663         * WebView/WebPreferences.mm:
664         (+[WebPreferences initialize]):
665         (-[WebPreferences largeImageAsyncDecodingEnabled]):
666         (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
667         (-[WebPreferences animatedImageAsyncDecodingEnabled]):
668         (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
669         (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
670         (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
671         * WebView/WebPreferencesPrivate.h:
672         * WebView/WebView.mm:
673         (-[WebView _preferencesChanged:]):
674
675 2016-11-29  Andy Estes  <aestes@apple.com>
676
677         [Cocoa] Enable two clang warnings recommended by Xcode
678         https://bugs.webkit.org/show_bug.cgi?id=164498
679
680         Reviewed by Mark Lam.
681
682         * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
683
684 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
685
686         [WTF] Import std::optional reference implementation as WTF::Optional
687         https://bugs.webkit.org/show_bug.cgi?id=164199
688
689         Reviewed by Saam Barati and Sam Weinig.
690
691         Use WTF::Optional::value_or.
692
693         * DOM/DOMHTMLOptionsCollection.mm:
694         (-[DOMHTMLOptionsCollection add:index:]):
695         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
696         (WebKit::NetscapePluginInstanceProxy::evaluate):
697         * Plugins/WebNetscapePluginView.mm:
698         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
699         * WebCoreSupport/WebFrameLoaderClient.h:
700         * WebCoreSupport/WebFrameLoaderClient.mm:
701         (WebFrameLoaderClient::dispatchDidCommitLoad):
702         * WebCoreSupport/WebPaymentCoordinatorClient.h:
703         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
704         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
705         (WebPaymentCoordinatorClient::completeShippingContactSelection):
706         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
707         * WebCoreSupport/WebSecurityOrigin.mm:
708         (-[WebSecurityOrigin port]):
709         * WebView/WebHTMLView.mm:
710         (toAction):
711         (toTag):
712
713 2016-11-26  Sam Weinig  <sam@webkit.org>
714
715         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
716         https://bugs.webkit.org/show_bug.cgi?id=164965
717
718         Reviewed by Simon Fraser.
719
720         * WebView/WebPreferenceKeysPrivate.h:
721         * WebView/WebPreferences.mm:
722         (-[WebPreferences intersectionObserverEnabled]):
723         (-[WebPreferences setIntersectionObserverEnabled:]):
724         * WebView/WebPreferencesPrivate.h:
725         * WebView/WebView.mm:
726         (-[WebView _preferencesChanged:]):
727         Add a preference, defaulting to off, for enabling IntersectionObserver.
728
729 2016-11-22  Dan Bernstein  <mitz@apple.com>
730
731         [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
732         https://bugs.webkit.org/show_bug.cgi?id=165036
733         <rdar://problem/5708580>
734
735         Reviewed by Alexey Proskuryakov.
736
737         * WebView/WebHTMLView.mm:
738         (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
739           similarly to what we do in -keyDown: and to what WKWebView does with all key events.
740
741 2016-11-21  Alex Christensen  <achristensen@webkit.org>
742
743         Fix Sierra CMake build after r208452
744         https://bugs.webkit.org/show_bug.cgi?id=164437
745
746         * WebView/WebView.mm:
747         (-[WebView updateMediaTouchBar]):
748         I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
749         It's needed for playbackSessionInterface to exist.
750
751 2016-11-18  Enrica Casucci  <enrica@apple.com>
752
753         Refactor drag and drop for WebKit2 to encode DragData message exchange.
754         https://bugs.webkit.org/show_bug.cgi?id=164945
755
756         Reviewed by Tim Horton.
757
758         * WebCoreSupport/WebDragClient.h:
759         * WebCoreSupport/WebDragClient.mm:
760         (WebDragClient::actionMaskForDrag):
761         (WebDragClient::willPerformDragDestinationAction):
762
763 2016-11-18  Jeremy Jones  <jeremyj@apple.com>
764
765         Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
766         https://bugs.webkit.org/show_bug.cgi?id=163801
767
768         Reviewed by Simon Fraser.
769
770         Plumb through PointerLockEnabled setting.
771
772         * Configurations/FeatureDefines.xcconfig:
773         * WebCoreSupport/WebChromeClient.mm:
774         (WebChromeClient::requestPointerUnlock):
775         * WebView/WebPreferenceKeysPrivate.h:
776         * WebView/WebPreferences.mm:
777         (-[WebPreferences pointerLockEnabled]):
778         (-[WebPreferences setPointerLockEnabled:]):
779         * WebView/WebPreferencesPrivate.h:
780         * WebView/WebView.mm:
781         (-[WebView _preferencesChanged:]):
782
783 2016-11-17  Dan Bernstein  <mitz@apple.com>
784
785         Try to fix some non-macOS builds.
786
787         * WebView/WebView.mm:
788
789 2016-11-16  Dave Hyatt  <hyatt@apple.com>
790
791         [CSS Parser] Add @supports, @keyframe and media query parsing options
792         https://bugs.webkit.org/show_bug.cgi?id=164821
793
794         Reviewed by Sam Weinig and Zalan Bujtas.
795
796         Fix up the create call now that fallback descriptor syntax is gone.
797
798         * DOM/DOM.mm:
799         (-[DOMHTMLLinkElement _mediaQueryMatches]):
800
801 2016-11-17  Saam Barati  <sbarati@apple.com>
802
803         Remove async/await compile time flag and enable tests
804         https://bugs.webkit.org/show_bug.cgi?id=164828
805         <rdar://problem/28639334>
806
807         Reviewed by Yusuke Suzuki.
808
809         * Configurations/FeatureDefines.xcconfig:
810
811 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
812
813         [JSC] WTF::TemporaryChange with WTF::SetForScope
814         https://bugs.webkit.org/show_bug.cgi?id=164761
815
816         Reviewed by Saam Barati.
817
818         * WebView/WebView.mm:
819         (-[WebView updateTextTouchBar]):
820
821 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
822
823         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
824         https://bugs.webkit.org/show_bug.cgi?id=164827
825
826         Reviewed by Ryosuke Niwa.
827
828         * Configurations/FeatureDefines.xcconfig:
829         * WebView/WebPreferenceKeysPrivate.h:
830         * WebView/WebPreferences.mm:
831         (+[WebPreferences initialize]):
832         (-[WebPreferences es6ModulesEnabled]):
833         (-[WebPreferences setES6ModulesEnabled:]):
834         * WebView/WebPreferencesPrivate.h:
835         * WebView/WebView.mm:
836         (-[WebView _preferencesChanged:]):
837
838 2016-11-14  Alex Christensen  <achristensen@webkit.org>
839
840         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
841         https://bugs.webkit.org/show_bug.cgi?id=164720
842
843         Reviewed by Brady Eidson.
844
845         * Storage/WebDatabaseManager.mm:
846         (-[WebDatabaseManager origins]):
847         (-[WebDatabaseManager databasesWithOrigin:]):
848         (-[WebDatabaseManager deleteOrigin:]):
849         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
850         * Storage/WebDatabaseManagerClient.h:
851         * Storage/WebDatabaseManagerClient.mm:
852         (DidModifyOriginData::dispatchToMainThread):
853         (DidModifyOriginData::DidModifyOriginData):
854         (WebDatabaseManagerClient::dispatchDidModifyOrigin):
855         (WebDatabaseManagerClient::dispatchDidModifyDatabase):
856         * Storage/WebDatabaseQuotaManager.mm:
857         (-[WebDatabaseQuotaManager usage]):
858         (-[WebDatabaseQuotaManager quota]):
859         (-[WebDatabaseQuotaManager setQuota:]):
860         * Storage/WebStorageManager.mm:
861         (-[WebStorageManager origins]):
862         (-[WebStorageManager deleteOrigin:]):
863         * Storage/WebStorageTrackerClient.h:
864         * Storage/WebStorageTrackerClient.mm:
865         (WebStorageTrackerClient::dispatchDidModifyOrigin):
866         * WebCoreSupport/WebSecurityOrigin.mm:
867         (-[WebSecurityOrigin usage]):
868         (-[WebSecurityOrigin quota]):
869         (-[WebSecurityOrigin setQuota:]):
870
871 2016-11-13  Darin Adler  <darin@apple.com>
872
873         Fix exception handling in SQL database code, streamline and update code
874         https://bugs.webkit.org/show_bug.cgi?id=164685
875
876         Reviewed by Sam Weinig.
877
878         * Storage/WebDatabaseManager.mm:
879         (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
880         a reference.
881         (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
882         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
883         but continue to use DatabaseManager.
884         (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
885         reference.
886         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
887
888         * Storage/WebDatabaseManagerClient.h: Updated to take references.
889         * Storage/WebDatabaseManagerClient.mm:
890         (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
891         members in the class definition.
892         (DidModifyOriginData::dispatchToMainThread): Take references.
893         (DidModifyOriginData::DidModifyOriginData): Ditto.
894         (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
895         (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
896         (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
897         DatabaseTracker::singleton instead of tracker.
898
899         * Storage/WebDatabaseQuotaManager.mm:
900         (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
901         (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
902         (-[WebDatabaseQuotaManager quota]): Ditto.
903         (-[WebDatabaseQuotaManager setQuota:]): Ditto.
904         * WebCoreSupport/WebSecurityOrigin.mm:
905         (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
906         (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
907         (-[WebSecurityOrigin quota]): Ditto.
908         (-[WebSecurityOrigin setQuota:]): Ditto.
909         * WebView/WebFrame.mm:
910         (-[WebFrame _cacheabilityDictionary]): Pass a reference.
911
912 2016-11-12  Darin Adler  <darin@apple.com>
913
914         Remove a few assorted uses of ExceptionCode
915         https://bugs.webkit.org/show_bug.cgi?id=164683
916
917         Reviewed by Chris Dumez.
918
919         * DOM/DOMDOMImplementation.mm:
920         (-[DOMImplementation createDocumentType:publicId:systemId:]):
921         Use raiseOnDOMError instead of much longer hand written equivalent.
922         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
923
924         * DOM/DOMDocument.mm:
925         (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
926         so we are not using a specific exception code.
927
928         * DOM/DOMHTMLOptionsCollection.mm:
929         (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
930         much longer hand written equivalent.
931         * DOM/DOMHTMLSelectElement.mm:
932         (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
933         statement after calling a "no return" function.
934
935         * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
936         raiseOnDOMError functions that take ExceptionCode; keep the ones that take
937         Exception and ExceptionOr. Renamed the other overload of raiseDOMException
938         to raiseDOMErrorException; it is only used as the non-inline implementation
939         part of the inline raiseOnDOMError function.
940         * DOM/ExceptionHandlers.mm:
941         (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
942         to this source file instead of in the header.
943         (raiseTypeErrorException): Updated for name change.
944         (raiseNotSupportedErrorException): Added.
945
946 2016-11-11  Ryosuke Niwa  <rniwa@webkit.org>
947
948         Hovering over a slotted Text node clears hover state
949         https://bugs.webkit.org/show_bug.cgi?id=164002
950         <rdar://problem/29040471>
951
952         Reviewed by Simon Fraser.
953
954         * WebView/WebImmediateActionController.mm:
955         (-[WebImmediateActionController performHitTestAtPoint:]):
956
957 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
958
959         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
960         https://bugs.webkit.org/show_bug.cgi?id=164538
961         <rdar://problem/8418711>
962
963         Reviewed by Ryosuke Niwa.
964
965         Account for renaming HTMLElement::autocorrect to HTMLElement::shouldAutocorrect, as well as moving
966         WebAutocapitalizeType to WebKit from WebCore. Additionally, moves the -autocorrect and -autocapitalize SPIs out
967         of HTML(Input|Form|TextArea)ElementPrivate.h and into HTMLElementPrivate.h. This also means removing redundant
968         code for interfacing with the unwrapped HTMLElement's autocorrect and autocapitalize attributes.
969
970         * DOM/DOMHTML.mm:
971         (webAutocapitalizeType):
972         (-[DOMHTMLInputElement _autocapitalizeType]):
973         (-[DOMHTMLTextAreaElement _autocapitalizeType]):
974         * DOM/DOMHTMLElement.mm:
975         (-[DOMHTMLElement autocorrect]):
976         (-[DOMHTMLElement setAutocorrect:]):
977         (-[DOMHTMLElement autocapitalize]):
978         (-[DOMHTMLElement setAutocapitalize:]):
979         * DOM/DOMHTMLElementPrivate.h: Copied from Source/WebCore/html/Autocapitalize.h.
980         * DOM/DOMHTMLFormElement.mm:
981         (-[DOMHTMLFormElement autocorrect]): Deleted.
982         (-[DOMHTMLFormElement setAutocorrect:]): Deleted.
983         (-[DOMHTMLFormElement autocapitalize]): Deleted.
984         (-[DOMHTMLFormElement setAutocapitalize:]): Deleted.
985         * DOM/DOMHTMLInputElement.mm:
986         (-[DOMHTMLInputElement autocorrect]): Deleted.
987         (-[DOMHTMLInputElement setAutocorrect:]): Deleted.
988         (-[DOMHTMLInputElement autocapitalize]): Deleted.
989         (-[DOMHTMLInputElement setAutocapitalize:]): Deleted.
990         * DOM/DOMHTMLInputElementPrivate.h:
991         * DOM/DOMHTMLTextAreaElement.mm:
992         (-[DOMHTMLTextAreaElement autocorrect]): Deleted.
993         (-[DOMHTMLTextAreaElement setAutocorrect:]): Deleted.
994         (-[DOMHTMLTextAreaElement autocapitalize]): Deleted.
995         (-[DOMHTMLTextAreaElement setAutocapitalize:]): Deleted.
996         * DOM/DOMHTMLTextAreaElementPrivate.h:
997
998         We need to import DOMHTMLElementPrivate.h here to avoid breaking UIKit. We should follow this up with a UIKit
999         change to import DOMHTMLElementPrivate.h directly.
1000
1001         * DOM/DOMPrivate.h:
1002         * DOM/WebAutocapitalizeTypes.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h.
1003         * MigrateHeaders.make:
1004
1005 2016-11-11  Beth Dakin  <bdakin@apple.com>
1006
1007         Move to modern TouchBar methods
1008         https://bugs.webkit.org/show_bug.cgi?id=164655
1009         -and corresponding-
1010         rdar://problem/29226911
1011
1012         Reviewed by Wenson Hsieh.
1013
1014         customizationDefaultItemIdentifiers -> defaultItemIdentifiers
1015         itemIdentifiers -> defaultItemIdentifiers
1016         defaultItems -> templateItems
1017
1018         * WebView/WebView.mm:
1019         (-[WebView _plainTextTouchBarDefaultItemIdentifiers]):
1020         (-[WebView _richTextTouchBarDefaultItemIdentifiers]):
1021         (-[WebView setUpTextTouchBar:]):
1022         (-[WebView updateTextTouchBar]):
1023         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1024         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
1025
1026 2016-11-11  Darin Adler  <darin@apple.com>
1027
1028         Move Node from ExceptionCode to ExceptionOr
1029         https://bugs.webkit.org/show_bug.cgi?id=164515
1030
1031         Reviewed by Sam Weinig.
1032
1033         * DOM/DOMHTMLSelectElement.mm:
1034         (-[DOMHTMLSelectElement remove:]): Call remove instead of removeByIndex
1035         now that it was renamed.
1036         * DOM/DOMNode.mm:
1037         (-[DOMNode setNodeValue:]): Updated exception handling.
1038         (-[DOMNode setPrefix:]): Ditto.
1039         (-[DOMNode setTextContent:]): Ditto.
1040         (-[DOMNode insertBefore:refChild:]): Ditto.
1041         (-[DOMNode replaceChild:oldChild:]): Ditto.
1042         (-[DOMNode removeChild:]): Ditto.
1043         (-[DOMNode appendChild:]): Ditto.
1044         (-[DOMNode cloneNode:]): Ditto.
1045
1046 2016-11-11  Beth Dakin  <bdakin@apple.com>
1047
1048         Get touch bar code building for open source builds
1049         https://bugs.webkit.org/show_bug.cgi?id=164610
1050
1051         Reviewed by Wenson Hsieh.
1052
1053         * WebKitPrefix.h:
1054
1055 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1056
1057         Fix assertion after r208534.
1058         https://bugs.webkit.org/show_bug.cgi?id=160497
1059
1060         * WebView/WebView.mm:
1061         (-[WebView _commonInitializationWithFrameName:groupName:]):
1062         (WebInstallMemoryPressureHandler):
1063         WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
1064         When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
1065         only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
1066
1067 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1068
1069         Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
1070         https://bugs.webkit.org/show_bug.cgi?id=164573
1071
1072         Reviewed by Brady Eidson.
1073
1074         * WebCoreSupport/WebSecurityOrigin.mm:
1075         (-[WebSecurityOrigin databaseIdentifier]):
1076
1077 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1078
1079         MemoryPressureHandler shouldn't know how to release WebCore memory
1080         https://bugs.webkit.org/show_bug.cgi?id=160497
1081
1082         Reviewed by Michael Catanzaro.
1083
1084         Set the low memory handler before installing the memory pressure handler.
1085
1086         * WebView/WebView.mm:
1087         (-[WebView _commonInitializationWithFrameName:groupName:]):
1088
1089 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
1090
1091         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
1092         https://bugs.webkit.org/show_bug.cgi?id=164501
1093         <rdar://problem/29152282>
1094
1095         Reviewed by Sam Weinig.
1096
1097         Align what [WebHTMLView attributedString] returns to what would be used on copy & paste by using HTMLConverter
1098         instead of _initWithDOMRange in [WebHTMLView _attributeStringFromDOMRange].
1099
1100         * WebView/WebHTMLView.mm:
1101         (-[WebHTMLView _attributedStringFromDOMRange:]): Renamed from _attributeStringFromDOMRange.
1102         (-[WebHTMLView attributedString]):
1103         (-[WebHTMLView selectedAttributedString]):
1104         (-[WebHTMLView selectedString]): Moved to reduce the number of occurrences of the if-defs.
1105
1106 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
1107
1108         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
1109         https://bugs.webkit.org/show_bug.cgi?id=155185
1110         <rdar://problem/11101440>
1111
1112         Reviewed by Brady Eidson.
1113
1114         Provide SPI to access the new quirk for localStorage. The quirk defaults to 'on'. When active, this
1115         quirk says that localStorage access should be granted, without needing to grant universal file access.
1116
1117         If the quirk is turned off, then localStorage is blocked unless the WebKit client explicitly
1118         grants universal file access.
1119
1120         * WebView/WebPreferenceKeysPrivate.h:
1121         * WebView/WebPreferences.mm:
1122         (-[WebPreferences needsLocalStorageQuirk]): Added.
1123         (-[WebPreferences setNeedsLocalStorageQuirk:]): Added.
1124         * WebView/WebPreferencesPrivate.h:
1125         * WebView/WebView.mm:
1126         (-[WebView _preferencesChanged:]): Honor the new localStorage quirk.
1127
1128 2016-11-09  Alex Christensen  <achristensen@webkit.org>
1129
1130         Clean up Storage code
1131         https://bugs.webkit.org/show_bug.cgi?id=164562
1132
1133         Reviewed by Brady Eidson.
1134
1135         * Storage/WebStorageManager.mm:
1136         (-[WebStorageManager origins]):
1137         (-[WebStorageManager deleteAllOrigins]):
1138         (-[WebStorageManager deleteOrigin:]):
1139         (-[WebStorageManager diskUsageForOrigin:]):
1140         (-[WebStorageManager syncLocalStorage]):
1141         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
1142         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
1143         (+[WebStorageManager closeIdleLocalStorageDatabases]):
1144         (WebKitInitializeStorageIfNecessary):
1145         * WebView/WebView.mm:
1146         (+[WebView _applicationWillTerminate]):
1147
1148 2016-11-09  Beth Dakin  <bdakin@apple.com>
1149
1150         Another attempted build fix.
1151
1152         * WebView/WebView.mm:
1153
1154 2016-11-09  Beth Dakin  <bdakin@apple.com>
1155
1156         Attempted build fix.
1157
1158         * WebView/WebView.mm:
1159
1160 2016-11-09  Darin Adler  <darin@apple.com>
1161
1162         Move Range from ExceptionCode to ExceptionOr
1163         https://bugs.webkit.org/show_bug.cgi?id=164457
1164
1165         Reviewed by Alex Christensen.
1166
1167         * DOM/DOMRange.mm:
1168         (-[DOMRange setStart:offset:]): Updated exception handling.
1169         (-[DOMRange setEnd:offset:]): Ditto.
1170         (-[DOMRange setStartBefore:]): Ditto.
1171         (-[DOMRange setStartAfter:]): Ditto.
1172         (-[DOMRange setEndBefore:]): Ditto.
1173         (-[DOMRange setEndAfter:]): Ditto.
1174         (-[DOMRange selectNode:]): Ditto.
1175         (-[DOMRange selectNodeContents:]): Ditto.
1176         (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
1177         (-[DOMRange deleteContents]): Ditto.
1178         (-[DOMRange extractContents]): Ditto.
1179         (-[DOMRange cloneContents]): Ditto.
1180         (-[DOMRange insertNode:]): Ditto.
1181         (-[DOMRange surroundContents:]): Ditto.
1182         (-[DOMRange createContextualFragment:]): Ditto.
1183         (-[DOMRange compareNode:]): Ditto.
1184         (-[DOMRange intersectsNode:]): Ditto.
1185         (-[DOMRange comparePoint:offset:]): Ditto.
1186         (-[DOMRange isPointInRange:offset:]): Ditto.
1187         (-[DOMRange expand:]): Ditto.
1188         * WebView/WebFrame.mm:
1189         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
1190         (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
1191         This function was incorrectly implemented (set both start and end of
1192         the range to the computed start), not declared in any header file,
1193         not used anywhere inside WebKit, and I also could not find a use of it
1194         in outside-WebKit Apple code.
1195         * mac/DOM/DOMUIKitExtensions.mm:
1196         (-[DOMRange move:inDirection:]): Ditto.
1197         (-[DOMRange extend:inDirection:]): Ditto.
1198
1199 2016-11-09  Darin Adler  <darin@apple.com>
1200
1201         Move EventTarget from ExceptionCode to ExceptionOr
1202         https://bugs.webkit.org/show_bug.cgi?id=164465
1203
1204         Reviewed by Youenn Fablet.
1205
1206         * DOM/DOMNode.mm:
1207         (-[DOMNode dispatchEvent:]): Updated exception handling.
1208
1209 2016-11-09  Chris Dumez  <cdumez@apple.com>
1210
1211         [Mac] Stop using deprecated AppKit enumeration values
1212         https://bugs.webkit.org/show_bug.cgi?id=164494
1213
1214         Reviewed by Darin Adler.
1215
1216         Stop using deprecated AppKit enumeration values.
1217
1218         * Carbon/CarbonWindowAdapter.mm:
1219         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1220         (-[CarbonWindowAdapter sendSuperEvent:]):
1221         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1222         (WebKit::NetscapePluginHostProxy::beginModal):
1223         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1224         (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
1225         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1226         (-[WebHostedNetscapePluginView drawRect:]):
1227         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1228         (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
1229         * WebCoreSupport/PopupMenuMac.mm:
1230         (PopupMenuMac::populate):
1231         (PopupMenuMac::show):
1232         * WebCoreSupport/WebContextMenuClient.mm:
1233         (WebContextMenuClient::showContextMenu):
1234         * WebCoreSupport/WebFrameLoaderClient.mm:
1235         (WebFrameLoaderClient::actionDictionary):
1236         * WebCoreSupport/WebInspectorClient.mm:
1237         (WebInspectorFrontendClient::canAttach):
1238         (-[WebInspectorWindowController window]):
1239         * WebInspector/WebNodeHighlight.mm:
1240         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1241         * WebView/WebFrameView.mm:
1242         (-[WebFrameView keyDown:keyDown:]):
1243         * WebView/WebFullScreenController.mm:
1244         (-[WebFullScreenController init]):
1245         (createBackgroundFullscreenWindow):
1246         * WebView/WebHTMLView.mm:
1247         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
1248         (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
1249         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1250         (isQuickLookEvent):
1251         (-[WebHTMLView hitTest:]):
1252         (-[WebHTMLView _sendToolTipMouseExited]):
1253         (-[WebHTMLView _sendToolTipMouseEntered]):
1254         (mouseEventIsPartOfClickOrDrag):
1255         (-[WebHTMLView _updateMouseoverWithEvent:]):
1256         (-[WebHTMLView _autoscroll]):
1257         (-[WebHTMLView acceptsFirstResponder]):
1258         (-[WebHTMLView viewDidMoveToWindow]):
1259         (-[WebHTMLView mouseDown:mouseDown:]):
1260         (currentKeyboardEvent):
1261         (-[WebHTMLView _handleStyleKeyEquivalent:]):
1262         (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
1263         * WebView/WebPDFView.mm:
1264         (-[WebPDFView hitTest:]):
1265         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1266         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
1267         * WebView/WebTextCompletionController.mm:
1268         (-[WebTextCompletionController _buildUI]):
1269         (-[WebTextCompletionController _placePopupWindow:]):
1270         * WebView/WebView.mm:
1271         (-[WebView applicationFlags:]):
1272
1273 2016-11-09  Beth Dakin  <bdakin@apple.com>
1274
1275         Support TouchBar in WebKit
1276         https://bugs.webkit.org/show_bug.cgi?id=164437
1277         -and corresponding-
1278         rdar://problem/28876524
1279
1280         Reviewed by Darin Adler.
1281
1282         * WebCoreSupport/WebEditorClient.mm:
1283         (WebEditorClient::respondToChangedSelection):
1284         (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
1285         * WebView/WebHTMLView.mm:
1286         (-[WebHTMLView candidateListTouchBarItem]):
1287         * WebView/WebView.mm:
1288         (-[_WebTextListTouchBarViewController initWithWebView:]):
1289         (-[_WebTextListTouchBarViewController _selectList:]):
1290         (-[_WebTextListTouchBarViewController setCurrentListType:]):
1291         (-[WebTextTouchBarItemController initWithWebView:]):
1292         (-[WebTextTouchBarItemController itemForIdentifier:]):
1293         (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
1294         (-[WebTextTouchBarItemController setTextIsBold:]):
1295         (-[WebTextTouchBarItemController setTextIsItalic:]):
1296         (-[WebTextTouchBarItemController setTextIsUnderlined:]):
1297         (-[WebTextTouchBarItemController _webChangeTextStyle:]):
1298         (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
1299         (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
1300         (-[WebTextTouchBarItemController textColor]):
1301         (-[WebTextTouchBarItemController setTextColor:]):
1302         (-[WebTextTouchBarItemController _webChangeColor:]):
1303         (-[WebTextTouchBarItemController textListViewController]):
1304         (-[WebView _commonInitializationWithFrameName:groupName:]):
1305         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1306         (-[WebView shouldRequestCandidates]):
1307         (-[WebView forceRequestCandidatesForTesting]):
1308         (-[WebView makeTouchBar]):
1309         (-[WebView touchBar:makeItemForIdentifier:]):
1310         (textCheckingResultFromNSTextCheckingResult):
1311         (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
1312         (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
1313         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1314         (-[WebView _clearPlaybackControlsManager]):
1315         (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
1316         (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
1317         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
1318         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
1319         (-[WebView touchBarDidExitCustomization:]):
1320         (-[WebView touchBarWillEnterCustomization:]):
1321         (-[WebView didChangeAutomaticTextCompletion:]):
1322         (-[WebView setUpTextTouchBar:]):
1323         (-[WebView _isRichlyEditable]):
1324         (-[WebView textTouchBar]):
1325         (-[WebView updateTextTouchBar]):
1326         (-[WebView updateMediaTouchBar]):
1327         (-[WebView updateTouchBar]):
1328         (-[WebView prepareForMouseDown]):
1329         (-[WebView prepareForMouseUp]):
1330         (-[WebView webViewAdditionsWillDestroyView]):
1331         (-[WebView candidateList]):
1332         (-[WebView updateWebViewAdditions]): Deleted.
1333         * WebView/WebViewData.h:
1334         * WebView/WebViewInternal.h:
1335         * WebView/WebViewPrivate.h:
1336
1337 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1338
1339         Safari does not emit composition end if blurred for dead key / Japanese IME
1340         https://bugs.webkit.org/show_bug.cgi?id=164369
1341         <rdar://problem/29050439>
1342
1343         Reviewed by Ryosuke Niwa.
1344
1345         When canceling a composition, make sure that we clear the system IME state.
1346
1347         * WebCoreSupport/WebEditorClient.h:
1348         * WebCoreSupport/WebEditorClient.mm:
1349         (WebEditorClient::canceledComposition):
1350
1351 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1352
1353         Add a setting and preferences to enable/disable async image decoding
1354         https://bugs.webkit.org/show_bug.cgi?id=164417
1355
1356         Reviewed by Simon Fraser.
1357
1358         Hook up the asyncImageDecodingEnabled setting for WebKit1.
1359
1360         * WebView/WebPreferenceKeysPrivate.h:
1361         * WebView/WebPreferences.mm:
1362         (+[WebPreferences initialize]):
1363         (-[WebPreferences asyncImageDecodingEnabled]):
1364         (-[WebPreferences setAsyncImageDecodingEnabled:]):
1365         * WebView/WebPreferencesPrivate.h:
1366         * WebView/WebView.mm:
1367         (-[WebView _preferencesChanged:]):
1368
1369 2016-11-01  Alex Christensen  <achristensen@webkit.org>
1370
1371         Remove PassRefPtr from DumpRenderTree
1372         https://bugs.webkit.org/show_bug.cgi?id=164307
1373
1374         Reviewed by Sam Weinig.
1375
1376         * WebView/WebGeolocationPosition.mm:
1377         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1378
1379 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1380
1381         [Readable Streams API] Enable creation of ReadableByteStreamController
1382         https://bugs.webkit.org/show_bug.cgi?id=164014
1383
1384         Reviewed by Youenn Fablet.
1385
1386         Added flag for the byte stream part of Readable Streams API.
1387
1388         * Configurations/FeatureDefines.xcconfig:
1389
1390 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
1391
1392         Remove CUSTOM_ELEMENTS build flag
1393         https://bugs.webkit.org/show_bug.cgi?id=164267
1394
1395         Reviewed by Antti Koivisto.
1396
1397         Removed the build flag.
1398
1399         * Configurations/FeatureDefines.xcconfig:
1400         * WebView/WebPreferences.mm:
1401         (+[WebPreferences initialize]):
1402         * WebView/WebView.mm:
1403         (-[WebView _preferencesChanged:]):
1404
1405 2016-11-01  Eric Carlson  <eric.carlson@apple.com>
1406
1407         [MediaStream] restrict media capture secure connections
1408         https://bugs.webkit.org/show_bug.cgi?id=164234
1409         <rdar://problem/28944906>
1410
1411         Reviewed by Alex Christensen.
1412
1413         * WebView/WebPreferenceKeysPrivate.h:
1414         * WebView/WebPreferences.mm:
1415         (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
1416         (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
1417         (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
1418         * WebView/WebPreferencesPrivate.h:
1419
1420         * WebView/WebView.mm:
1421         (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
1422
1423 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
1424
1425         JSC should support SharedArrayBuffer
1426         https://bugs.webkit.org/show_bug.cgi?id=163986
1427
1428         Reviewed by Keith Miller.
1429         
1430         Support the RuntimeFlag.
1431
1432         * WebView/WebPreferencesPrivate.h:
1433
1434 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1435
1436         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
1437         https://bugs.webkit.org/show_bug.cgi?id=164236
1438         <rdar://problem/28747712>
1439
1440         Reviewed by Beth Dakin.
1441
1442         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
1443         dictionary lookup.
1444
1445         * WebCoreSupport/WebEditorClient.mm:
1446         (WebEditorClient::respondToChangedSelection):
1447         * WebView/WebImmediateActionController.mm:
1448         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1449
1450 2016-10-31  Darin Adler  <darin@apple.com>
1451
1452         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
1453         https://bugs.webkit.org/show_bug.cgi?id=164214
1454
1455         Reviewed by Alex Christensen.
1456
1457         * DOM/DOMCSSPrimitiveValue.mm:
1458         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
1459         is a reference now.
1460         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
1461
1462         * DOM/DOMDocument.mm:
1463         (-[DOMDocument querySelector:]): Updated exception handling.
1464         (-[DOMDocument querySelectorAll:]): Ditto.
1465         * DOM/DOMDocumentFragment.mm:
1466         (-[DOMDocumentFragment querySelector:]): Ditto.
1467         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
1468         * DOM/DOMElement.mm:
1469         (-[DOMElement querySelector:]): Ditto.
1470         (-[DOMElement querySelectorAll:]): Ditto.
1471
1472 2016-10-31  Darin Adler  <darin@apple.com>
1473
1474         Convert Document from ExceptionCode to Exception
1475         https://bugs.webkit.org/show_bug.cgi?id=164212
1476
1477         Reviewed by Alex Christensen.
1478
1479         * DOM/DOMDocument.mm:
1480         (-[DOMDocument setXmlVersion:]): Updated exception handling.
1481         (-[DOMDocument cookie]): Ditto.
1482         (-[DOMDocument setCookie:]): Ditto.
1483         (-[DOMDocument setBody:]): Ditto.
1484         (-[DOMDocument createElement:]): Ditto.
1485         (-[DOMDocument createCDATASection:]): Ditto.
1486         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
1487         (-[DOMDocument createAttribute:]): Ditto.
1488         (-[DOMDocument createEntityReference:]): Ditto.
1489         (-[DOMDocument importNode:deep:]): Ditto.
1490         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
1491         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
1492         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
1493         (-[DOMDocument adoptNode:]): Ditto.
1494         (-[DOMDocument createEvent:]): Ditto.
1495
1496 2016-10-30  Darin Adler  <darin@apple.com>
1497
1498         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
1499         https://bugs.webkit.org/show_bug.cgi?id=164206
1500
1501         Reviewed by Chris Dumez.
1502
1503         * DOM/DOMElement.mm:
1504         (-[DOMElement setInnerHTML:]): Updated exception handling.
1505         (-[DOMElement setOuterHTML:]): Ditto.
1506         (-[DOMElement setAttribute:value:]): Ditto.
1507         (-[DOMElement setAttributeNode:]): Ditto.
1508         (-[DOMElement removeAttributeNode:]): Ditto.
1509         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
1510         (-[DOMElement setAttributeNodeNS:]): Ditto.
1511         (-[DOMElement matches:]): Ditto.
1512         (-[DOMElement closest:]): Ditto.
1513         (-[DOMElement webkitMatchesSelector:]): Ditto.
1514         * DOM/DOMHTMLElement.mm:
1515         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
1516         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
1517         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
1518         * DOM/DOMNamedNodeMap.mm:
1519         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
1520         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
1521         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
1522         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
1523
1524 2016-10-29  Darin Adler  <darin@apple.com>
1525
1526         Convert more of DOM from ExceptionCode to Exception
1527         https://bugs.webkit.org/show_bug.cgi?id=164173
1528
1529         Reviewed by Ryosuke Niwa.
1530
1531         * DOM/DOMCharacterData.mm:
1532         (-[DOMCharacterData substringData:length:]): Updated since this
1533         now uses ExceptionOr.
1534         (-[DOMCharacterData insertData:data:]): Ditto.
1535         (-[DOMCharacterData deleteData:length:]): Ditto.
1536         (-[DOMCharacterData replaceData:length:data:]): Ditto.
1537         * DOM/DOMText.mm:
1538         (-[DOMText splitText:]): Ditto.
1539         (-[DOMText replaceWholeText:]): Removed unneeded exception code
1540         handling from function that does not throw an exception.
1541
1542 2016-10-28  Darin Adler  <darin@apple.com>
1543
1544         Move all classes in the HTML directory from ExceptionCode to Exception
1545         https://bugs.webkit.org/show_bug.cgi?id=163876
1546
1547         Reviewed by Sam Weinig.
1548
1549         * DOM/DOMCharacterData.mm:
1550         (-[DOMCharacterData remove]): Updated exception handling.
1551         * DOM/DOMDOMTokenList.mm:
1552         (-[DOMDOMTokenList toggle:force:]): Ditto.
1553         * DOM/DOMDocumentType.mm:
1554         (-[DOMDocumentType remove]): Ditto.
1555         * DOM/DOMElement.mm:
1556         (-[DOMElement remove]): Ditto.
1557         * DOM/DOMHTML.mm:
1558         (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
1559         * DOM/DOMHTMLCanvasElement.mm:
1560         (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
1561         * DOM/DOMHTMLElement.mm:
1562         (-[DOMHTMLElement setInnerText:]): Ditto.
1563         (-[DOMHTMLElement setOuterText:]): Ditto.
1564         (-[DOMHTMLElement setContentEditable:]): Ditto.
1565         * DOM/DOMHTMLInputElement.mm:
1566         (-[DOMHTMLInputElement setMaxLength:]): Ditto.
1567         (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
1568         (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
1569         (-[DOMHTMLInputElement stepUp:]): Ditto.
1570         (-[DOMHTMLInputElement stepDown:]): Ditto.
1571         (-[DOMHTMLInputElement setRangeText:]): Ditto.
1572         (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
1573         * DOM/DOMHTMLMarqueeElement.mm:
1574         (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
1575         * DOM/DOMHTMLMediaElement.mm:
1576         (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
1577         (-[DOMHTMLMediaElement setVolume:]): Ditto.
1578         * DOM/DOMHTMLOptionsCollection.mm:
1579         (-[DOMHTMLOptionsCollection setLength:]): Ditto.
1580         * DOM/DOMHTMLTableElement.mm:
1581         (-[DOMHTMLTableElement setCaption:]): Ditto.
1582         (-[DOMHTMLTableElement setTHead:]): Ditto.
1583         (-[DOMHTMLTableElement setTFoot:]): Ditto.
1584         (-[DOMHTMLTableElement insertRow:]): Ditto.
1585         (-[DOMHTMLTableElement deleteRow:]): Ditto.
1586         * DOM/DOMHTMLTableRowElement.mm:
1587         (-[DOMHTMLTableRowElement insertCell:]): Ditto.
1588         (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
1589         * DOM/DOMHTMLTableSectionElement.mm:
1590         (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
1591         (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
1592         * DOM/DOMHTMLTextAreaElement.mm:
1593         (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
1594         (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
1595         (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
1596         * DOM/DOMHTMLVideoElement.mm:
1597         (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
1598         (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
1599         version (lowercase S) instead of repeating the logic from that method.
1600         (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
1601         * DOM/DOMTimeRanges.mm:
1602         (-[DOMTimeRanges start:]): Updated exception handling.
1603         (-[DOMTimeRanges end:]): Ditto.
1604
1605 2016-10-27  Chris Dumez  <cdumez@apple.com>
1606
1607         Regression(r203601): Caused crashes in iBooks
1608         https://bugs.webkit.org/show_bug.cgi?id=164093
1609         <rdar://problem/28745634>
1610
1611         Reviewed by Darin Adler.
1612
1613         Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
1614         which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
1615
1616         * DOM/DOMNode.mm:
1617         (-[DOMNode compareDocumentPosition:]):
1618
1619 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1620
1621         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
1622         https://bugs.webkit.org/show_bug.cgi?id=163948
1623         <rdar://problem/28921433>
1624
1625         Reviewed by Darin Adler.
1626
1627         Add support for new drag and drop-related EditAction enum values.
1628
1629         * WebCoreSupport/WebEditorClient.mm:
1630         (undoNameForEditAction):
1631
1632 2016-10-27  Dan Bernstein  <mitz@apple.com>
1633
1634         Reapplied the configuration changes from r207934 without breaking iOS builds.
1635
1636         * Configurations/Base.xcconfig:
1637         * Configurations/WebKitLegacy.xcconfig:
1638
1639 2016-10-27  Dan Bernstein  <mitz@apple.com>
1640
1641         Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
1642
1643         * Configurations/Base.xcconfig:
1644         * Configurations/WebKitLegacy.xcconfig:
1645
1646 2016-10-26  Dan Bernstein  <mitz@apple.com>
1647
1648         [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
1649         https://bugs.webkit.org/show_bug.cgi?id=164048
1650
1651         Reviewed by Tim Horton.
1652
1653         * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
1654         * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
1655           headers.
1656
1657         * History/WebBackForwardList.h: Fixed parameter name in @param entry.
1658         * Misc/WebDownload.h: Removed empty entries.
1659         * Misc/WebIconDatabase.h: Remove incorrect @param entries.
1660         * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
1661         * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
1662         * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
1663         * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
1664         * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
1665         * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
1666         * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
1667           Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
1668         * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
1669         * WebView/WebView.h: Changed @method to @property in a couple of places.
1670         * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
1671
1672 2016-10-26  Brian Burg  <bburg@apple.com>
1673
1674         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
1675         https://bugs.webkit.org/show_bug.cgi?id=164046
1676
1677         Reviewed by Joseph Pecoraro.
1678
1679         * WebCoreSupport/WebInspectorClient.h:
1680
1681 2016-10-21  Alex Christensen  <achristensen@webkit.org>
1682
1683         URL::port should return Optional<uint16_t>
1684         https://bugs.webkit.org/show_bug.cgi?id=163806
1685
1686         Reviewed by Darin Adler.
1687
1688         * WebCoreSupport/WebSecurityOrigin.mm:
1689         (-[WebSecurityOrigin port]):
1690
1691 2016-10-24  Dave Hyatt  <hyatt@apple.com>
1692
1693         Remove CSSCharsetRule from the CSS OM
1694         https://bugs.webkit.org/show_bug.cgi?id=163891
1695
1696         Reviewed by Darin Adler.
1697
1698         * DOM/DOMCSSCharsetRule.mm:
1699         (-[DOMCSSCharsetRule encoding]):
1700
1701 2016-10-24  Youenn Fablet  <youenn@apple.com>
1702
1703         Activate WEB_RTC compilation flags for Mac bots
1704         https://bugs.webkit.org/show_bug.cgi?id=163886
1705
1706         Reviewed by Eric Carlson.
1707
1708         * Configurations/FeatureDefines.xcconfig:
1709
1710 2016-10-23  Chris Dumez  <cdumez@apple.com>
1711
1712         addEventListener() / removeEventListener() should use a union for last parameter
1713         https://bugs.webkit.org/show_bug.cgi?id=163863
1714
1715         Reviewed by Darin Adler.
1716
1717         Cast BOOL to bool to help to compiler construct the new variant-type parameter.
1718
1719         * DOM/DOMNode.mm:
1720         (-[DOMNode addEventListener:listener:useCapture:]):
1721         (-[DOMNode addEventListener:::]):
1722         (-[DOMNode removeEventListener:listener:useCapture:]):
1723         (-[DOMNode removeEventListener:::]):
1724
1725 2016-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1726
1727         Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
1728         https://bugs.webkit.org/show_bug.cgi?id=163460
1729         <rdar://problem/28784142>
1730
1731         Reviewed by Darin Adler.
1732
1733         Handle new EditAction types for inserting/deleting pending/final compositions.
1734
1735         * WebCoreSupport/WebEditorClient.mm:
1736         (undoNameForEditAction):
1737
1738 2016-10-21  Jeremy Jones  <jeremyj@apple.com>
1739
1740         Implement basic pointer lock behavior for WebKit and WebKit2.
1741         https://bugs.webkit.org/show_bug.cgi?id=162745
1742
1743         Reviewed by Simon Fraser.
1744
1745         Add basic pointer lock functionality. User permission is not yet implemented.
1746
1747         * WebCoreSupport/WebChromeClient.h:
1748         * WebCoreSupport/WebChromeClient.mm:
1749         (WebChromeClient::requestPointerLock):
1750         (WebChromeClient::requestPointerUnlock):
1751
1752 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
1753
1754         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1755         https://bugs.webkit.org/show_bug.cgi?id=163374
1756
1757         Reviewed by Darin Adler.
1758
1759         * Configurations/FeatureDefines.xcconfig:
1760
1761 2016-10-19  Alex Christensen  <achristensen@webkit.org>
1762
1763         Revert r207151
1764         https://bugs.webkit.org/show_bug.cgi?id=163675
1765
1766         Reviewed by Brent Fulgham.
1767
1768         * Misc/WebDownload.mm:
1769         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
1770         * Misc/WebDownloadInternal.h:
1771         * WebCoreSupport/WebFrameLoaderClient.mm:
1772         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1773         * WebView/WebPreferences.mm:
1774         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
1775         * WebView/WebView.mm:
1776         (-[WebView scheduleInRunLoop:forMode:]):
1777         (-[WebView unscheduleFromRunLoop:forMode:]):
1778
1779 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
1780
1781         Unreviewed, rolling out r207557.
1782
1783         This change caused animations/font-variations tests to time
1784         out on pre-Sierra Macs.
1785
1786         Reverted changeset:
1787
1788         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
1789         iOS 9"
1790         https://bugs.webkit.org/show_bug.cgi?id=163374
1791         http://trac.webkit.org/changeset/207557
1792
1793 2016-10-19  Chris Dumez  <cdumez@apple.com>
1794
1795         Move HTML Interactive Form Validation behind an experimental flag
1796         https://bugs.webkit.org/show_bug.cgi?id=163673
1797
1798         Reviewed by Daniel Bates.
1799
1800         Re-disable HTML Interactive Form Validation by default on Mac WK1.
1801
1802         * WebView/WebViewData.mm:
1803         (-[WebViewPrivate init]):
1804
1805 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
1806
1807         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1808         https://bugs.webkit.org/show_bug.cgi?id=163374
1809
1810         Reviewed by Darin Adler.
1811
1812         * Configurations/FeatureDefines.xcconfig:
1813
1814 2016-10-19  Simon Fraser  <simon.fraser@apple.com>
1815
1816         WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
1817         https://bugs.webkit.org/show_bug.cgi?id=163680
1818
1819         Reviewed by Dean Jackson.
1820
1821         Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
1822
1823         * WebView/WebView.mm:
1824         (-[WebView _preferencesChanged:]):
1825
1826 2016-10-19  Darin Adler  <darin@apple.com>
1827
1828         Move XPath from ExceptionCode to Exception
1829         https://bugs.webkit.org/show_bug.cgi?id=163656
1830
1831         Reviewed by Chris Dumez.
1832
1833         * DOM/DOMDocument.mm:
1834         (wrap): Added. Helper function for wrapping a resolver.
1835         (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
1836         (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
1837         * DOM/DOMXPathExpression.mm:
1838         (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
1839         * DOM/DOMXPathResult.mm:
1840         (-[DOMXPathResult numberValue]): Ditto.
1841         (-[DOMXPathResult stringValue]): Ditto.
1842         (-[DOMXPathResult booleanValue]): Ditto.
1843         (-[DOMXPathResult singleNodeValue]): Ditto.
1844         (-[DOMXPathResult snapshotLength]): Ditto.
1845         (-[DOMXPathResult iterateNext]): Ditto.
1846         (-[DOMXPathResult snapshotItem:]): Ditto.
1847
1848 2016-10-18  Sam Weinig  <sam@webkit.org>
1849
1850         Replace std::experimental::variant with WTF::Variant (or similar)
1851         https://bugs.webkit.org/show_bug.cgi?id=163626
1852
1853         Reviewed by Chris Dumez.
1854
1855         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
1856         into the WTF namespace.
1857
1858         * DOM/DOMHTMLSelectElement.mm:
1859         (-[DOMHTMLSelectElement add:before:]):
1860
1861 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
1862
1863         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
1864         https://bugs.webkit.org/show_bug.cgi?id=163627
1865
1866         Reviewed by Dean Jackson.
1867
1868         Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
1869
1870         * WebView/WebViewPrivate.h:
1871
1872 2016-10-18  Dean Jackson  <dino@apple.com>
1873
1874         Remove CSS_SHAPES feature definition. This should always be on.
1875         https://bugs.webkit.org/show_bug.cgi?id=163628
1876         <rdar://problem/28834613>
1877
1878         Reviewed by Tim Horton.
1879
1880         * Configurations/FeatureDefines.xcconfig:
1881
1882 2016-10-18  Chris Dumez  <cdumez@apple.com>
1883
1884         Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
1885         https://bugs.webkit.org/show_bug.cgi?id=163608
1886
1887         Reviewed by Ryosuke Niwa.
1888
1889         Update add() call sites now that it takes std::variant types in.
1890
1891         * DOM/DOMHTMLOptionsCollection.mm:
1892         (-[DOMHTMLOptionsCollection add:index:]):
1893         * DOM/DOMHTMLSelectElement.mm:
1894         (-[DOMHTMLSelectElement add:before:]):
1895
1896 2016-10-18  Anders Carlsson  <andersca@apple.com>
1897
1898         Get rid of more WebHistoryItem cruft
1899         https://bugs.webkit.org/show_bug.cgi?id=163623
1900
1901         Reviewed by Tim Horton.
1902
1903         * History/WebHistoryItem.mm:
1904         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1905         * History/WebHistoryItemPrivate.h:
1906
1907 2016-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1908
1909         Showing and hiding candidates list is very distracting after selecting word
1910         https://bugs.webkit.org/show_bug.cgi?id=163609
1911         <rdar://problem/28747712>
1912
1913         Reviewed by Tim Horton.
1914
1915         Introduce WebView hooks for mousedown and mouseup. See radar for more details.
1916
1917         * WebView/WebHTMLView.mm:
1918         (-[WebHTMLView mouseDown:mouseDown:]):
1919         (-[WebHTMLView mouseUp:mouseUp:]):
1920         * WebView/WebView.mm:
1921         (-[WebView prepareForMouseDown]):
1922         (-[WebView prepareForMouseUp]):
1923         * WebView/WebViewInternal.h:
1924
1925 2016-10-17  Anders Carlsson  <andersca@apple.com>
1926
1927         Move some history specific HistoryItem code to WebHistoryItem
1928         https://bugs.webkit.org/show_bug.cgi?id=163567
1929
1930         Reviewed by Tim Horton.
1931
1932         * History/HistoryPropertyList.mm:
1933         (HistoryPropertyListWriter::writeHistoryItem):
1934         * History/WebHistory.mm:
1935         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
1936         * History/WebHistoryItem.mm:
1937         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1938         * History/WebHistoryItemInternal.h:
1939         * WebCoreSupport/WebFrameLoaderClient.mm:
1940         (addRedirectURL):
1941         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
1942
1943 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
1944
1945         [MediaStream] Resolve constraints and enumerate devices in the UI process
1946         https://bugs.webkit.org/show_bug.cgi?id=162147
1947         <rdar://problem/28803569>
1948
1949         Reviewed by Darin Adler.
1950
1951         * WebCoreSupport/WebUserMediaClient.h:
1952         * WebCoreSupport/WebUserMediaClient.mm:
1953         (AddPermissionCheckToMap):
1954         (RemovePermissionCheckFromMap):
1955         (WebUserMediaClient::pageDestroyed):
1956         (WebUserMediaClient::requestUserMediaAccess):
1957         (WebUserMediaClient::enumerateMediaDevices):
1958         (WebUserMediaClient::cancelMediaDevicesEnumerationRequest):
1959         (-[WebUserMediaPolicyListener allow]):
1960         (-[WebUserMediaPolicyListener deny]):
1961         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
1962         (-[WebUserMediaPolicyCheckerListener cancelMediaDevicesEnumerationRequest]):
1963         (-[WebUserMediaPolicyCheckerListener allow]):
1964         (-[WebUserMediaPolicyCheckerListener deny]):
1965         (WebUserMediaClient::checkUserMediaPermission): Deleted.
1966         (WebUserMediaClient::cancelUserMediaPermissionCheck): Deleted.
1967         (-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]): Deleted.
1968         (-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]): Deleted.
1969
1970 2016-10-17  Antti Koivisto  <antti@apple.com>
1971
1972         Rename setNeedsStyleRecalc to invalidateStyle
1973         https://bugs.webkit.org/show_bug.cgi?id=163542
1974
1975         Reviewed by Darin Adler.
1976
1977         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1978         (-[WebHostedNetscapePluginView createPluginLayer]):
1979         * Plugins/WebNetscapePluginView.mm:
1980         (-[WebNetscapePluginView createPlugin]):
1981
1982 2016-10-17  Jeremy Jones  <jeremyj@apple.com>
1983
1984         Enable keyboard in fullscreen.
1985         https://bugs.webkit.org/show_bug.cgi?id=163146
1986
1987         Reviewed by Jer Noble.
1988
1989         Allow keyboard in fullscreen.
1990
1991         * WebView/WebView.mm:
1992         (-[WebView _supportsFullScreenForElement:withKeyboard:]):
1993
1994 2016-10-17  Chris Dumez  <cdumez@apple.com>
1995
1996         Move form.reportValidity() behind InteractiveFormValidation setting
1997         https://bugs.webkit.org/show_bug.cgi?id=163550
1998
1999         Reviewed by Darin Adler.
2000
2001         Enable InteractiveFormValidation setting by default and link it to
2002         RuntimeEnabledFeatures so we can use it in the IDL.
2003
2004         * WebView/WebView.mm:
2005         (-[WebView _preferencesChanged:]):
2006         * WebView/WebViewData.mm:
2007         (-[WebViewPrivate init]):
2008
2009 2016-10-17  Anders Carlsson  <andersca@apple.com>
2010
2011         Fix iOS build.
2012
2013         * History/WebBackForwardList.mm:
2014         (-[WebBackForwardList dictionaryRepresentation]):
2015
2016 2016-10-17  Anders Carlsson  <andersca@apple.com>
2017
2018         CTTE some of the BackForwardList member functions
2019         https://bugs.webkit.org/show_bug.cgi?id=163555
2020
2021         Reviewed by Dan Bernstein.
2022
2023         * History/BackForwardList.h:
2024         (BackForwardList::entries):
2025         * History/BackForwardList.mm:
2026         (BackForwardList::removeItem):
2027         (BackForwardList::containsItem):
2028         (BackForwardList::entries): Deleted.
2029         * History/WebBackForwardList.mm:
2030         (-[WebBackForwardList removeItem:]):
2031         (-[WebBackForwardList containsItem:]):
2032         (-[WebBackForwardList description]):
2033
2034 2016-10-17  Anders Carlsson  <andersca@apple.com>
2035
2036         Remove WEBCORE_EXPORT from BackForwardList, it lives in WebKit now
2037         https://bugs.webkit.org/show_bug.cgi?id=163551
2038
2039         Reviewed by Tim Horton.
2040
2041         * History/BackForwardList.h:
2042
2043 2016-10-16  Darin Adler  <darin@apple.com>
2044
2045         Move CSS classes from ExceptionCode to Exception
2046         https://bugs.webkit.org/show_bug.cgi?id=163494
2047
2048         Reviewed by Sam Weinig.
2049
2050         * DOM/DOMCSSMediaRule.mm:
2051         (-[DOMCSSMediaRule insertRule:index:]): Use raiseOnDOMError
2052         the new way to handle ExceptionOr instead of ExceptionCode.
2053         (-[DOMCSSMediaRule deleteRule:]): Ditto.
2054         * DOM/DOMCSSPrimitiveValue.mm:
2055         (-[DOMCSSPrimitiveValue setFloatValue:floatValue:]): Ditto.
2056         (-[DOMCSSPrimitiveValue getFloatValue:]): Ditto.
2057         (-[DOMCSSPrimitiveValue setStringValue:stringValue:]): Ditto.
2058         (-[DOMCSSPrimitiveValue getStringValue]): Ditto.
2059         (-[DOMCSSPrimitiveValue getCounterValue]): Ditto.
2060         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
2061         (-[DOMCSSPrimitiveValue getRGBColorValue]): Ditto.
2062         * DOM/DOMCSSRule.mm:
2063         (-[DOMCSSRule setCssText:]): Ditto.
2064         * DOM/DOMCSSStyleDeclaration.mm:
2065         (-[DOMCSSStyleDeclaration setCssText:]): Ditto.
2066         (-[DOMCSSStyleDeclaration removeProperty:]): Ditto.
2067         (-[DOMCSSStyleDeclaration setProperty:value:priority:]): Ditto.
2068         * DOM/DOMCSSStyleSheet.mm:
2069         (-[DOMCSSStyleSheet insertRule:index:]): Ditto.
2070         (-[DOMCSSStyleSheet deleteRule:]): Ditto.
2071         (-[DOMCSSStyleSheet addRule:style:index:]): Ditto.
2072         (-[DOMCSSStyleSheet removeRule:]): Ditto.
2073         * DOM/DOMCSSValue.mm:
2074         (-[DOMCSSValue setCssText:]): Ditto.
2075         * DOM/DOMMediaList.mm:
2076         (-[DOMMediaList setMediaText:]): Ditto.
2077         (-[DOMMediaList deleteMedium:]): Ditto.
2078         (-[DOMMediaList appendMedium:]): Ditto.
2079
2080         * DOM/ExceptionHandlers.h: Added an overload of raiseDOMException
2081         that works with a WebCore::Exception&& and overloads of
2082         raiseOnDOMError that work with WebCore::ExceptionOr&&.
2083         * DOM/ExceptionHandlers.mm:
2084         (raiseDOMException): Implemented the new version.
2085
2086 2016-10-15  Dan Bernstein  <mitz@apple.com>
2087
2088         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
2089         https://bugs.webkit.org/show_bug.cgi?id=163492
2090         <rdar://problem/28654799>
2091
2092         Reviewed by Darin Adler.
2093
2094         Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm
2095
2096         * WebView/WebHTMLView.mm:
2097         (createMenuItem): Set the tag for items that have submenus as well.
2098
2099 2016-10-14  Anders Carlsson  <andersca@apple.com>
2100
2101         Clean up BackForwardClient
2102         https://bugs.webkit.org/show_bug.cgi?id=163454
2103
2104         Reviewed by Sam Weinig.
2105
2106         * History/BackForwardList.h:
2107         Remove override keywords.
2108
2109         * History/BackForwardList.mm:
2110         (BackForwardList::clearAllPageCaches): Deleted.
2111         Remove this, it's no longer used.
2112
2113         * WebView/WebView.mm:
2114         (-[WebView _clearBackForwardCache]): Deleted.
2115         * WebView/WebViewPrivate.h:
2116         Remove SPI that's no longer used by anyone.
2117
2118 2016-10-13  Anders Carlsson  <andersca@apple.com>
2119
2120         Move BackForwardList from WebCore to WebKitLegacy
2121         https://bugs.webkit.org/show_bug.cgi?id=163418
2122
2123         Reviewed by Tim Horton.
2124
2125         * History/BackForwardList.h: Renamed from Source/WebCore/history/BackForwardList.h.
2126         (BackForwardList::create):
2127         (BackForwardList::webView):
2128         * History/BackForwardList.mm: Renamed from Source/WebCore/history/BackForwardList.cpp.
2129         (BackForwardList::BackForwardList):
2130         (BackForwardList::close):
2131         (BackForwardList::containsItem):
2132         * History/WebBackForwardList.mm:
2133         (kit):
2134         (-[WebBackForwardList initWithBackForwardList:]):
2135         (-[WebBackForwardList setPageCacheSize:]):
2136         (-[WebBackForwardList pageCacheSize]):
2137         * History/WebBackForwardListInternal.h:
2138         * WebCoreSupport/WebFrameLoaderClient.mm:
2139         * WebView/WebFrameView.mm:
2140         * WebView/WebView.mm:
2141         (-[WebView _commonInitializationWithFrameName:groupName:]):
2142         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2143
2144 2016-10-13  Anders Carlsson  <andersca@apple.com>
2145
2146         Get rid of the HistoryItemVector typedef
2147         https://bugs.webkit.org/show_bug.cgi?id=163398
2148
2149         Reviewed by Beth Dakin.
2150
2151         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
2152
2153         * History/WebBackForwardList.mm:
2154         (-[WebBackForwardList dictionaryRepresentation]):
2155         (vectorToNSArray):
2156         (-[WebBackForwardList backListWithLimit:]):
2157         (-[WebBackForwardList forwardListWithLimit:]):
2158         (-[WebBackForwardList description]):
2159         * History/WebHistoryItem.mm:
2160         (-[WebHistoryItem description]):
2161
2162 2016-10-12  Chris Dumez  <cdumez@apple.com>
2163
2164         [Web IDL] Drop support for legacy [ConstructorConditional=*]
2165         https://bugs.webkit.org/show_bug.cgi?id=163368
2166
2167         Reviewed by Ryosuke Niwa.
2168
2169         Drop ENABLE_DOM4_EVENTS_CONSTRUCTOR compiler flag.
2170
2171         * Configurations/FeatureDefines.xcconfig:
2172
2173 2016-10-12  Beth Dakin  <bdakin@apple.com>
2174
2175         Adobe Contribute CS 6.5 Trial crashes on launch
2176         https://bugs.webkit.org/show_bug.cgi?id=163365
2177         -and corresponding-
2178         <rdar://problem/28732731>
2179
2180         Reviewed by Tim Horton.
2181
2182         * Carbon/CarbonWindowFrame.m:
2183         (-[CarbonWindowFrame contentFill]):
2184
2185 2016-10-11  Daniel Bates  <dabates@apple.com>
2186
2187         Attempt to fix the Apple Internal Mac build following r207159
2188         (https://bugs.webkit.org/show_bug.cgi?id=163244)
2189
2190         * WebView/WebView.mm:
2191         (shouldRequireUserGestureToLoadVideo):
2192
2193 2016-10-11  Daniel Bates  <dabates@apple.com>
2194
2195         REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
2196         https://bugs.webkit.org/show_bug.cgi?id=163259
2197         <rdar://problem/28680515>
2198
2199         Reviewed by Jer Noble.
2200
2201         In WebKit1 on iOS we want to require user action to load and play videos by default and
2202         allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
2203         Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
2204         can load and play without being initiated by a user action.
2205
2206         * WebView/WebPreferences.mm:
2207         (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
2208         WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
2209         preference takes precedence over the values of its replacement preferences
2210         WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
2211
2212 2016-10-11  Daniel Bates  <dabates@apple.com>
2213
2214         [iOS] REGRESSION (r197953): User gesture required to load video in iOS 9-built apps
2215         https://bugs.webkit.org/show_bug.cgi?id=163244
2216         <rdar://problem/27250015>
2217
2218         Reviewed by Jer Noble.
2219
2220         Enable or disable the Setting::requiresUserGestureToLoadVideo() in legacy WebKit depending
2221         on the version of iOS SDK that the app was linked against. We require a user gesture to
2222         begin loading a video as of iOS 10.
2223
2224         * WebView/WebView.mm:
2225         (shouldRequireUserGestureToLoadVideo):
2226         (-[WebView _preferencesChanged:]): Modified to pass the WebKit requiresUserGestureToLoadVideo
2227         preference to WebCore.
2228
2229 2016-10-11  Alex Christensen  <achristensen@webkit.org>
2230
2231         Remove dead networking code
2232         https://bugs.webkit.org/show_bug.cgi?id=163263
2233
2234         Reviewed by Daniel Bates.
2235
2236         * Misc/WebDownload.mm:
2237         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2238         * Misc/WebDownloadInternal.h:
2239         * WebCoreSupport/WebFrameLoaderClient.mm:
2240         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2241         * WebView/WebPreferences.mm:
2242         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
2243         * WebView/WebView.mm:
2244         (-[WebView scheduleInRunLoop:forMode:]):
2245         (-[WebView unscheduleFromRunLoop:forMode:]):
2246
2247 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
2248
2249         Add ENABLE_ENCRYPTED_MEDIA configuration option
2250         https://bugs.webkit.org/show_bug.cgi?id=163219
2251
2252         Reviewed by Darin Adler.
2253
2254         * Configurations/FeatureDefines.xcconfig:
2255         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
2256         to enable or disable the new EME implementation at build-time.
2257
2258 2016-10-10  Darin Adler  <darin@apple.com>
2259
2260         Move NotificationCenter from legacy to new DOM exceptions
2261         https://bugs.webkit.org/show_bug.cgi?id=163217
2262
2263         Reviewed by Chris Dumez.
2264
2265         * WebView/WebView.mm:
2266         (-[WebView _notificationIDForTesting:]): Pass reference to page rather than pointer.
2267
2268 2016-10-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2269
2270         Support InputEvent.inputType for the new InputEvent spec
2271         https://bugs.webkit.org/show_bug.cgi?id=163025
2272         <rdar://problem/28658092>
2273
2274         Reviewed by Darin Adler.
2275
2276         Accounts for some changes to the EditAction enum in nameForEditAction. See WebCore ChangeLog
2277         entry for more details.
2278
2279         * WebCoreSupport/WebEditorClient.mm:
2280         (undoNameForEditAction):
2281
2282 2016-10-06  Darin Adler  <darin@apple.com>
2283
2284         Next step on moving to modern way to return DOM exceptions
2285         https://bugs.webkit.org/show_bug.cgi?id=163016
2286
2287         Reviewed by Ryosuke Niwa.
2288
2289         * DOM/DOMDOMImplementation.mm:
2290         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated for
2291         name change from takeReturnValue to releaseReturnValue.
2292         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2293
2294 2016-10-07  Simon Fraser  <simon.fraser@apple.com>
2295
2296         [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
2297         https://bugs.webkit.org/show_bug.cgi?id=163154
2298         rdar://problem/28674216
2299
2300         Reviewed by Tim Horton.
2301         
2302         r55159 added code to counteract AppKit's adjustment of dirty regions during scrolling,
2303         by offsetting the dirty rect in -setNeedsDisplayInRect: if the call happens during
2304         the NSViewBoundsDidChangeNotification handling.
2305         
2306         However, AppKit only does dirty region adjustment in the code path that blits ("copy
2307         on scroll"), so r55159 produces incorrect behavior in, for example, layer-backed views.
2308         
2309         Fix by overriding -[NSClipView _canCopyOnScrollForDeltaX:deltaY:] to know if a single
2310         scroll is going to blit, and only do adjustments in -setNeedsDisplayInRect: if it is.
2311
2312         * WebView/WebClipView.h:
2313         * WebView/WebClipView.mm:
2314         (-[WebClipView _immediateScrollToPoint:]):
2315         (-[WebClipView _canCopyOnScrollForDeltaX:deltaY:]):
2316         (-[WebClipView currentScrollIsBlit]):
2317         * WebView/WebHTMLView.mm:
2318         (-[WebHTMLView setNeedsDisplayInRect:]):
2319         (-[WebHTMLView drawRect:]):
2320
2321 2016-10-06  Youenn Fablet  <youenn@apple.com>
2322
2323         CachedResource client handling methods should take reference
2324         https://bugs.webkit.org/show_bug.cgi?id=163014
2325
2326         Reviewed by Alex Christensen.
2327
2328         * WebView/WebHTMLView.mm:
2329         (promisedDataClient):
2330
2331 2016-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
2332
2333         Put variation fonts work behind a compile-time flag
2334         https://bugs.webkit.org/show_bug.cgi?id=162949
2335
2336         Reviewed by Simon Fraser.
2337
2338         * Configurations/FeatureDefines.xcconfig:
2339
2340 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
2341
2342         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
2343         https://bugs.webkit.org/show_bug.cgi?id=162903
2344
2345         Reviewed by Alex Christensen.
2346
2347         Rename build guards for the remaining implementation of the legacy EME API
2348         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
2349         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
2350
2351         * Configurations/FeatureDefines.xcconfig:
2352         * WebView/WebPreferences.mm:
2353         (+[WebPreferences initialize]):
2354         * WebView/WebView.mm:
2355         (-[WebView _preferencesChanged:]):
2356
2357 2016-10-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2358
2359         The dragged image should be the current frame only of the animated image
2360         https://bugs.webkit.org/show_bug.cgi?id=162109
2361
2362         Reviewed by Tim Horton.
2363
2364         * DOM/DOM.mm:
2365         (-[DOMElement image]): Call the Image function with its new name.
2366         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2367         * Misc/WebElementDictionary.mm:
2368         (-[WebElementDictionary _image]): Call the Image function with its new name.
2369         * Misc/WebIconDatabase.mm:
2370         (-[WebIconDatabase defaultIconWithSize:]): Call snapshotNSImage() to create the icon image.
2371         (webGetNSImage): Call the Image function with its new name.
2372         * WebCoreSupport/WebContextMenuClient.mm:
2373         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call snapshotNSImage() instead of nsImage()..
2374         (WebContextMenuClient::contextMenuForEvent): Ditto.
2375         * WebView/WebHTMLView.mm:
2376         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2377
2378 2016-10-02  Ryan Haddad  <ryanhaddad@apple.com>
2379
2380         Unreviewed, rolling out r206683.
2381
2382         This change caused API test WebKit2.FindMatches to fail on
2383         Mac.
2384
2385         Reverted changeset:
2386
2387         "The dragged image should be the current frame only of the
2388         animated image"
2389         https://bugs.webkit.org/show_bug.cgi?id=162109
2390         http://trac.webkit.org/changeset/206683
2391
2392 2016-09-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
2393
2394         The dragged image should be the current frame only of the animated image
2395         https://bugs.webkit.org/show_bug.cgi?id=162109
2396
2397         Reviewed by Tim Horton.
2398
2399         * DOM/DOM.mm:
2400         (-[DOMElement image]): Call the Image function with its new name.
2401         (-[DOMElement _imageTIFFRepresentation]): Ditto.
2402         * Misc/WebElementDictionary.mm:
2403         (-[WebElementDictionary _image]): Call the Image function with its new name.
2404         * Misc/WebIconDatabase.mm:
2405         (-[WebIconDatabase defaultIconWithSize:]): Call currentFrameNSImage() to create the icon image.
2406         (webGetNSImage): Call the Image function with its new name.
2407         * WebCoreSupport/WebContextMenuClient.mm:
2408         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call currentFrameNSImage() instead of nsImage()..
2409         (WebContextMenuClient::contextMenuForEvent): Ditto.
2410         * WebView/WebHTMLView.mm:
2411         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
2412
2413 2016-09-27  Jer Noble  <jer.noble@apple.com>
2414
2415         Remove deprecated ENCRYPTED_MEDIA implementation.
2416         https://bugs.webkit.org/show_bug.cgi?id=161010
2417
2418         Remove ENABLE_ENCRYPTED_MEDIA.
2419
2420         Reviewed by Eric Carlson.
2421
2422         * Configurations/FeatureDefines.xcconfig:
2423
2424 2016-09-26  Daniel Bates  <dabates@apple.com>
2425
2426         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
2427         https://bugs.webkit.org/show_bug.cgi?id=162365
2428
2429         Reviewed by Simon Fraser.
2430
2431         * Configurations/FeatureDefines.xcconfig:
2432         * WebView/WebFrame.mm:
2433         * WebView/WebPreferences.mm:
2434         (+[WebPreferences initialize]):
2435         * WebView/WebView.mm:
2436         (-[WebView _preferencesChanged:]):
2437
2438 2016-09-25  Antti Koivisto  <antti@apple.com>
2439
2440         AuthorStyleSheets shouldn't trigger synchronous style resolutions
2441         https://bugs.webkit.org/show_bug.cgi?id=162532
2442
2443         Reviewed by Darin Adler.
2444
2445         * WebView/WebHTMLView.mm:
2446         (-[WebHTMLView reapplyStyles]):
2447         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2448
2449 2016-09-24  Antti Koivisto  <antti@apple.com>
2450
2451         Move stylesheet change logic from Document to AuthorStyleSheets
2452         https://bugs.webkit.org/show_bug.cgi?id=162488
2453
2454         Reviewed by Andreas Kling.
2455
2456         * WebView/WebHTMLView.mm:
2457         (-[WebHTMLView reapplyStyles]):
2458         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2459
2460 2016-09-23  Caitlin Potter  <caitp@igalia.com>
2461
2462         [JSC] Implement parsing of Async Functions
2463         https://bugs.webkit.org/show_bug.cgi?id=161409
2464
2465         Reviewed by Yusuke Suzuki.
2466
2467         * Configurations/FeatureDefines.xcconfig:
2468
2469 2016-09-23  Commit Queue  <commit-queue@webkit.org>
2470
2471         Unreviewed, rolling out r206311.
2472         https://bugs.webkit.org/show_bug.cgi?id=162495
2473
2474         Broke internal iOS build (Requested by anttik on #webkit).
2475
2476         Reverted changeset:
2477
2478         "Move stylesheet change logic from Document to
2479         AuthorStyleSheets"
2480         https://bugs.webkit.org/show_bug.cgi?id=162488
2481         http://trac.webkit.org/changeset/206311
2482
2483 2016-09-23  Antoine Quint  <graouts@apple.com>
2484
2485         Add a new runtime flag for work on modern media controls (off by default)
2486         https://bugs.webkit.org/show_bug.cgi?id=162420
2487         <rdar://problem/27989489>
2488
2489         Reviewed by Eric Carlson.
2490
2491         * WebView/WebPreferenceKeysPrivate.h:
2492         * WebView/WebPreferences.mm:
2493         (-[WebPreferences modernMediaControlsEnabled]):
2494         (-[WebPreferences setModernMediaControlsEnabled:]):
2495         * WebView/WebPreferencesPrivate.h:
2496         * WebView/WebView.mm:
2497         (-[WebView _preferencesChanged:]):
2498
2499 2016-09-21  Anders Carlsson  <andersca@apple.com>
2500
2501         Support openPaymentSetup API on ApplePaySession object
2502         https://bugs.webkit.org/show_bug.cgi?id=162357
2503         rdar://problem/26776939
2504
2505         Reviewed by Tim Horton.
2506
2507         Add openPaymentSetup stub.
2508
2509         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2510         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2511         (WebPaymentCoordinatorClient::openPaymentSetup):
2512
2513 2016-09-19  Daniel Bates  <dabates@apple.com>
2514
2515         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
2516         https://bugs.webkit.org/show_bug.cgi?id=162167
2517
2518         Reviewed by Simon Fraser.
2519
2520         * Configurations/FeatureDefines.xcconfig:
2521
2522 2016-09-19  Joseph Pecoraro  <pecoraro@apple.com>
2523
2524         Web Inspector: Bring the inspected page's window forward when activating element search
2525         https://bugs.webkit.org/show_bug.cgi?id=162114
2526         <rdar://problem/28349357>
2527
2528         Reviewed by Brian Burg.
2529
2530         * WebCoreSupport/WebInspectorClient.mm:
2531         (WebInspectorClient::didSetSearchingForNode):
2532         When element search is activated bring the window
2533         containing the inspected page to the foreground.
2534
2535 2016-09-15  Brady Eidson  <beidson@apple.com>
2536
2537         WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
2538         <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
2539
2540         Reviewed by Brent Fulgham. 
2541
2542         * WebCoreSupport/WebFrameLoaderClient.h:
2543         * WebCoreSupport/WebFrameLoaderClient.mm:
2544         (WebFrameLoaderClient::dispatchDidCommitLoad):
2545
2546 2016-09-15  Anders Carlsson  <andersca@apple.com>
2547
2548         This was supposed to be committed with the previous patch!
2549
2550         * Plugins/WebBasePluginPackage.mm:
2551         (pathByResolvingSymlinksAndAliases): Deleted.
2552
2553 2016-09-15  Anders Carlsson  <andersca@apple.com>
2554
2555         Replace use of Carbon file system APIs in plug-in loading
2556         https://bugs.webkit.org/show_bug.cgi?id=162040
2557         rdar://problem/6017896
2558
2559         Reviewed by Sam Weinig.
2560
2561         * Plugins/WebBasePluginPackage.mm:
2562         (-[WebBasePluginPackage initWithPath:]):
2563         Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
2564         to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).
2565
2566 2016-09-15  Beth Dakin  <bdakin@apple.com>
2567
2568         Need hasMarkedText on Mac
2569         https://bugs.webkit.org/show_bug.cgi?id=162026
2570         -and corresponding-
2571         rdar://problem/28272353
2572
2573         Reviewed by Anders Carlsson.
2574
2575         * WebView/WebHTMLViewInternal.h:
2576
2577 2016-09-12  Dean Jackson  <dino@apple.com>
2578
2579         Replace RGBA32 with Color in member variables
2580         https://bugs.webkit.org/show_bug.cgi?id=161856
2581         <rdar://problem/28254324>
2582
2583         Reviewed by Simon Fraser.
2584
2585         In preparation for the Color class to become more than
2586         just a 4-byte RGBA value, I went through a few places
2587         that were using the RGBA32 type directly, and replaced
2588         them with Color. This will make some objects a little
2589         bigger e.g. BorderValue and its friends.
2590
2591         I mostly looked at the places that were using RGBA32 as
2592         a member variable. There is still a lot of RGBA32 use
2593         around the project, in particular the CSS parser.
2594
2595         There should be no behaviour change.
2596
2597         * Misc/WebKitNSStringExtras.mm:
2598         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Explicitly
2599         call a Color constructor, rather than passing an RGBA32.
2600
2601 2016-09-13  Chris Dumez  <cdumez@apple.com>
2602
2603         Drop support for <isindex>
2604         https://bugs.webkit.org/show_bug.cgi?id=7139
2605
2606         Reviewed by Ryosuke Niwa.
2607
2608         Drop references to isindex.
2609
2610         * WebCoreSupport/WebEditorClient.mm:
2611         (attributesForAttributedStringConversion):
2612         * WebView/WebHTMLView.mm:
2613         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
2614
2615 2016-09-12  Chris Dumez  <cdumez@apple.com>
2616
2617         Switch remaining users of Document::inPageCache() to pageCacheState()
2618         https://bugs.webkit.org/show_bug.cgi?id=161865
2619
2620         Reviewed by Darin Adler.
2621
2622         Switch remaining users of Document::inPageCache() to pageCacheState() as
2623         the former one is confusing (given that it returns true while the
2624         pagehide event is being fired).
2625
2626         * WebView/WebHTMLView.mm:
2627         (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]):
2628         (-[WebHTMLView setNeedsLayout:]):
2629         (-[WebHTMLView setNeedsToApplyStyles:]):
2630
2631 2016-09-09  Tim Horton  <timothy_horton@apple.com>
2632
2633         Text replacement candidates don't always overwrite the entire original string
2634         https://bugs.webkit.org/show_bug.cgi?id=161779
2635         <rdar://problem/28033492>
2636
2637         Reviewed by Simon Fraser.
2638
2639         * WebCoreSupport/WebEditorClient.mm:
2640         (WebEditorClient::requestCandidatesForSelection):
2641         Make use of the shared implementation of contextRangeForCandidateRequest.
2642
2643 2016-09-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
2644
2645         Move the BitmapImage platform dependent code to a new file named NativeImage[CG|Cairo].cpp
2646         https://bugs.webkit.org/show_bug.cgi?id=158684
2647
2648         Reviewed by Simon Fraser.
2649
2650         * DOM/DOM.mm:
2651         (-[DOMNode getPreviewSnapshotImage:andRects:]):
2652         * Misc/WebCache.mm:
2653         (+[WebCache imageForURL:]):
2654         Replace BitmapImage::getCGImageRef() with BitmapImage::nativeImage().
2655
2656 2016-09-07  Joseph Pecoraro  <pecoraro@apple.com>
2657
2658         [Mac] Address some clang static analyzer warnings in WebKit
2659         https://bugs.webkit.org/show_bug.cgi?id=161597
2660
2661         Reviewed by Darin Adler.
2662
2663         * Misc/WebIconDatabase.h:
2664         Remove unused instance variable. It has not been used since r16005 (2006)!
2665
2666         * Misc/WebSharingServicePickerController.mm:
2667         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2668         Address array leak.
2669
2670         * WebCoreSupport/WebSelectionServiceController.mm:
2671         (WebSelectionServiceController::hasRelevantSelectionServices):
2672         Address attachment and cell leak.
2673
2674         * WebView/WebFullScreenController.h:
2675         * WebView/WebImmediateActionController.h:
2676         Remove unused instance variables.
2677
2678 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
2679
2680         Enable the <meter> element on iOS
2681         https://bugs.webkit.org/show_bug.cgi?id=161714
2682         rdar://problem/8978410
2683
2684         Reviewed by Tim Horton.
2685
2686         Define ENABLE_METER_ELEMENT unconditionally now.
2687
2688         * Configurations/FeatureDefines.xcconfig:
2689
2690 2016-09-07  Mark Lam  <mark.lam@apple.com>
2691
2692         Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
2693         https://bugs.webkit.org/show_bug.cgi?id=161498
2694
2695         Reviewed by Geoffrey Garen.
2696
2697         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2698         (WebKit::NetscapePluginInstanceProxy::evaluate):
2699         (WebKit::NetscapePluginInstanceProxy::invoke):
2700         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2701         (WebKit::NetscapePluginInstanceProxy::construct):
2702         (WebKit::NetscapePluginInstanceProxy::getProperty):
2703         (WebKit::NetscapePluginInstanceProxy::setProperty):
2704         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2705         (WebKit::NetscapePluginInstanceProxy::hasProperty):
2706         (WebKit::NetscapePluginInstanceProxy::hasMethod):
2707         (WebKit::NetscapePluginInstanceProxy::enumerate):
2708         * WebView/WebView.mm:
2709         (aeDescFromJSValue):
2710
2711 2016-09-07  Youenn Fablet  <youenn@apple.com>
2712
2713         [Streams API] Separate compile flag for ReadableStream and WritableStream
2714         https://bugs.webkit.org/show_bug.cgi?id=161044
2715
2716         Reviewed by Alex Christensen.
2717
2718         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
2719
2720         * Configurations/FeatureDefines.xcconfig:
2721
2722 2016-09-06  Chris Dumez  <cdumez@apple.com>
2723
2724         Add support for input.minLength / textArea.minLength
2725         https://bugs.webkit.org/show_bug.cgi?id=161644
2726
2727         Reviewed by Darin Adler.
2728
2729         Update ObjC bindings to reflect method renaming.
2730
2731         * DOM/DOMHTMLInputElement.mm:
2732         (-[DOMHTMLInputElement maxLength]):
2733         (-[DOMHTMLInputElement setMaxLength:]):
2734         * DOM/DOMHTMLTextAreaElement.mm:
2735         (-[DOMHTMLTextAreaElement maxLength]):
2736         (-[DOMHTMLTextAreaElement setMaxLength:]):
2737
2738 2016-09-06  Dan Bernstein  <mitz@apple.com>
2739
2740         <rdar://problem/8064563> Ugly NSLog in DOMInternal.mm
2741
2742         Rubber-stamped by Anders Carlsson.
2743
2744         * DOM/DOMInternal.mm:
2745         (-[WebScriptObject _initializeScriptDOMNodeImp]): Removed useless call to NSLog.
2746
2747 2016-09-06  Ryan Haddad  <ryanhaddad@apple.com>
2748
2749         Unreviewed, rolling out r205407.
2750
2751         Not the correct way to implement this functionality
2752
2753         Reverted changeset:
2754
2755         "Consult with the FrameLoaderClient about whether or not
2756         content extensions should be enabled when loading this URL."
2757         https://bugs.webkit.org/show_bug.cgi?id=161441
2758         http://trac.webkit.org/changeset/205407
2759
2760 2016-09-05  Darin Adler  <darin@apple.com>
2761
2762         More bindings improvements, particularly things not needed for JavaScript bindings
2763         https://bugs.webkit.org/show_bug.cgi?id=161572
2764
2765         Reviewed by Sam Weinig.
2766
2767         * DOM/DOMDOMImplementation.mm:
2768         (-[DOMImplementation hasFeature:version:]): Call SVGTests::hasFeatureForLegacyBindings
2769         instead of DOMImplementation::hasFeature. Also removed JSMainThreadNullState
2770         since this does not do anything that can invoke JavaScript.
2771
2772         * DOM/DOMDocument.mm:
2773         (-[DOMDocument defaultCharset]): Call defaultCharsetForLegacyBindings. Also removed
2774         JSMainThreadNullState.
2775
2776         * DOM/DOMDocumentType.mm:
2777         (-[DOMDocumentType entities]): Changed to simply return nil; same behavior as before,
2778         but with no dependency on WebCore. Also removed JSMainThreadNullState.
2779         (-[DOMDocumentType notations]): Ditto.
2780         (-[DOMDocumentType internalSubset]): Ditto, except empty string rather than nil.
2781
2782         * DOM/DOMNode.mm:
2783         (-[DOMNode isSupported:version:]): Call SVGTests::hasFeatureForLegacyBindings
2784         instead of Node::isSupportedForBindings. Also removed JSMainThreadNullState.
2785
2786 2016-09-04  Joseph Pecoraro  <pecoraro@apple.com>
2787
2788         Remove unnecessary RetainPtr.
2789
2790         Review comments on earlier change.
2791
2792         * WebView/WebImmediateActionController.mm:
2793         (-[WebImmediateActionController _defaultAnimationController]):
2794
2795 2016-09-03  Darin Adler  <darin@apple.com>
2796
2797         Streamline DOMImplementation, and move it to our new DOM exception system
2798         https://bugs.webkit.org/show_bug.cgi?id=161295
2799
2800         Reviewed by Ryosuke Niwa.
2801
2802         * DOM/DOMDOMImplementation.mm:
2803         (unwrap): Added. Use this instead of the IMPL macro.
2804         (-[DOMImplementation dealloc]): Updated to use unwrap.
2805         (-[DOMImplementation hasFeature:version:]): Ditto.
2806         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated to work with
2807         ExceptionOr.
2808         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2809         (-[DOMImplementation createCSSStyleSheet:media:]): Removed exception logic since
2810         this function can no longer raise an exception.
2811         (-[DOMImplementation createHTMLDocument:]): Updated to use unwrap.
2812         (-[DOMImplementation hasFeature::]): Changed to call the non-deprecated version
2813         rather than duplicating its implementation. Also moved into the category as defined
2814         in the header.
2815         (-[DOMImplementation createDocumentType:::]): Ditto.
2816         (-[DOMImplementation createDocument:::]): Ditto.
2817         (-[DOMImplementation createCSSStyleSheet::]): Ditto.
2818
2819         * DOM/DOMDocument.mm: Removed unneeded include of DOMImplementation.h.
2820         (-[DOMDocument setXmlStandalone:]): Updated since setXMLStandalone no longer can
2821         raise an exception.
2822
2823         * WebView/WebFrame.mm:
2824         (-[WebFrame _canProvideDocumentSource]): Updated to use isTextMIMEType in its new
2825         location in MIMETypeRegistry instead of in DOMImplementation.
2826
2827 2016-09-03  Brian Weinstein  <bweinstein@apple.com>
2828
2829         Implement a stub version of FrameLoaderClient::shouldUseContentExtensionsForURL.
2830         https://bugs.webkit.org/show_bug.cgi?id=16144
2831
2832         Reviewed by Darin Adler.
2833
2834         * WebCoreSupport/WebFrameLoaderClient.h:
2835
2836 2016-09-02  Beth Dakin  <bdakin@apple.com>
2837
2838         Need to updateEditorState if an element change edit-ability without changing 
2839         selection
2840         https://bugs.webkit.org/show_bug.cgi?id=161546
2841         -and corresponding-
2842         rdar://problem/27806012
2843
2844         Reviewed by Ryosuke Niwa.
2845
2846         Every time WebEditorClient::respondToChangedSelection is called, we now save 
2847         whether the last state was contentEditable. That way in 
2848         updateEditorStateAfterLayoutIfNeeded() we can assess whether or not edit-ability 
2849         has changed. 
2850
2851         * WebCoreSupport/WebEditorClient.h:
2852         * WebCoreSupport/WebEditorClient.mm:
2853         (WebEditorClient::respondToChangedSelection):
2854         (WebEditorClient:: updateEditorStateAfterLayoutIfEditabilityChanged):
2855
2856 2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
2857
2858         [Mac] RetainPtr misuse, AnimationController leaks
2859         https://bugs.webkit.org/show_bug.cgi?id=161552
2860
2861         Reviewed by Tim Horton.
2862
2863         * WebView/WebImmediateActionController.mm:
2864         (-[WebImmediateActionController _defaultAnimationController]):
2865
2866 2016-07-08  Jer Noble  <jer.noble@apple.com>
2867
2868         Refactor WebPlaybackSessionModelMediaElement to be client based.
2869         https://bugs.webkit.org/show_bug.cgi?id=159580
2870
2871         Reviewed by Eric Carlson.
2872
2873         No longer necessary to tell the models and interfaces about each other.
2874
2875         * WebView/WebView.mm:
2876         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
2877         (-[WebView _clearPlaybackControlsManager]):
2878
2879 2016-09-01  Dan Bernstein  <mitz@apple.com>
2880
2881         Build fix.
2882
2883         * Configurations/FeatureDefines.xcconfig:
2884
2885 2016-09-01  Myles C. Maxfield  <mmaxfield@apple.com>
2886
2887         Clean up TextRun-related code
2888         https://bugs.webkit.org/show_bug.cgi?id=161473
2889
2890         Reviewed by Simon Fraser.
2891
2892         Remove unused #includes.
2893
2894         * WebCoreSupport/WebDragClient.mm:
2895         * WebView/WebView.mm:
2896
2897 2016-08-31  Keith Rollin  <krollin@apple.com>
2898
2899         WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
2900         https://bugs.webkit.org/show_bug.cgi?id=160969
2901         <rdar://problem/26068734>
2902
2903         Reviewed by Simon Fraser.
2904
2905         Enable subsystem- and channel-related data and functions when using
2906         RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
2907         and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
2908
2909         * Misc/WebKitLogging.h:
2910         * Misc/WebKitLogging.m:
2911         * WebView/WebView.mm:
2912         (-[WebView _commonInitializationWithFrameName:groupName:]):
2913
2914 2016-08-31  Brady Eidson  <beidson@apple.com>
2915
2916         WK2 Gamepad provider on iOS.
2917         https://bugs.webkit.org/show_bug.cgi?id=161412
2918
2919         Reviewed by Tim Horton.
2920
2921         * Configurations/FeatureDefines.xcconfig:
2922
2923         * WebView/WebView.mm:
2924         (WebKitInitializeGamepadProviderIfNecessary):
2925
2926 2016-08-30  Mark Lam  <mark.lam@apple.com>
2927
2928         Introduce the ThrowScope and force every throw site to instantiate a ThrowScope.
2929         https://bugs.webkit.org/show_bug.cgi?id=161171
2930
2931         Reviewed by Filip Pizlo and Geoffrey Garen.
2932
2933         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2934         (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
2935         * Plugins/Hosted/ProxyInstance.mm:
2936         (WebKit::ProxyInstance::invokeMethod):
2937
2938 2016-08-28  Andreas Kling  <akling@apple.com>
2939
2940         document.title setter can't throw.
2941         <https://webkit.org/b/161302>
2942
2943         Reviewed by Antti Koivisto.
2944
2945         * DOM/DOMDocument.mm:
2946         (-[DOMDocument setTitle:]):
2947
2948 2016-08-28  Andreas Kling  <akling@apple.com>
2949
2950         Clean up some .text attribute setters that don't throw.
2951         <https://webkit.org/b/161292>
2952
2953         Reviewed by Darin Adler.
2954
2955         * DOM/DOMHTMLTitleElement.mm:
2956         (-[DOMHTMLTitleElement setText:]):
2957
2958 2016-08-26  Sam Weinig  <sam@webkit.org>
2959
2960         Remove support for ENABLE_LEGACY_WEB_AUDIO
2961         https://bugs.webkit.org/show_bug.cgi?id=161262
2962
2963         Reviewed by Anders Carlsson.
2964
2965         * Configurations/FeatureDefines.xcconfig:
2966         Remove ENABLE_LEGACY_WEB_AUDIO
2967
2968 2016-08-25  Anders Carlsson  <andersca@apple.com>
2969
2970         Re-export DOMException NSStrings after r204717
2971         https://bugs.webkit.org/show_bug.cgi?id=161200
2972         <rdar://problem/27959937>
2973
2974         Reviewed by Alex Christensen.
2975
2976         * DOM/ExceptionHandlers.mm:
2977         (raiseDOMException):
2978         * WebKit.exp:
2979
2980 2016-08-22  Darin Adler  <darin@apple.com>
2981
2982         Move Objective-C DOM bindings from WebCore to legacy WebKit
2983         https://bugs.webkit.org/show_bug.cgi?id=160654
2984
2985         Reviewed by Alex Christensen.
2986
2987         * DOM: Added lots of files to the directory.
2988         The files are just as they were in bindings/objc except that the paths of includes
2989         have been updated as needed, and the code no longer is defined inside the WebCore
2990         namespace, requring changes to various functions and their call sites. Also removed
2991         all the WEBCORE_EXPORT since we export differently here in legacy WebKit.
2992
2993         * DOM/DOMInternal.h: Moved. Replaced createDOMWrapper with initializeDOMWrapperHooks.
2994         * DOM/DOMUtility.mm: Moved.
2995         (createDOMWrapper): Simplified to use toWrapped and not do unneeded namespace tricks.
2996         (disconnectWindowWrapper): Added.
2997         (initializeDOMWrapperHooks): Added.
2998
2999         * MigrateHeaders.make: Removed all the internal headers since they are now just
3000         normal project headers. Added the "DOM" directory to the VPATH. Some of the headers
3001         from WebCore are still being migrated, so we can't remove WebCorePrivateHeaders yet.
3002
3003         * WebCoreSupport/WebEditorClient.h: Updated to return RefPtr<DocumentFragment>.
3004
3005         * WebCoreSupport/WebEditorClient.mm:
3006         (WebEditorClient::documentFragmentFromDelegate): Use RefPtr.
3007
3008         * WebKit.exp: Added exports for all the classes that used to use WEBCORE_EXPORT to
3009         be exported from WebCore.
3010
3011         * WebView/WebFrame.mm:
3012         (-[WebFrame innerLineHeight:]): Moved code from WebCore::Frame::innerLineHeight here.
3013         No longer depend on whether this node happens to be in this frame. Also removed
3014         unneeded null check since a node's document can't be null.
3015
3016         * WebView/WebHTMLView.mm: Removed uneeded include of ExceptionHandlers.h, which
3017         is now here in WebKitLegacy instead of WebCore. But no need to include it at all.
3018
3019         * WebView/WebView.mm:
3020         (-[WebView _commonInitializationWithFrameName:groupName:]): Call
3021         initializeDOMWrapperHooks so WebScriptObject can create DOM binding wrappers when
3022         making a script object for a DOM object, rather than just a generic script object.
3023         (+[WebView enableWebThread]): Added a call to WebCoreObjCDeallocOnWebThread here for
3024         DOMObject along with the other classes. This was done in WebCore before, but DOMObject is now
3025         defined here in legacy WebKit.
3026         (-[WebView styleAtSelectionStart]): Moved code from WebCore::Frame::styleAtSelectionStart here.
3027         Replaced incorrect code that called "new PropertySetCSSStyleDeclaration" with a misleading comment
3028         about reference counting; that code was leaking all the style declarations. Instead use
3029         MutableStyleProperties::ensureCSSStyleDeclaration, which is designed for this purpose.
3030
3031 2016-08-22  Youenn Fablet  <youenn@apple.com>
3032
3033         [Fetch API] Activate fetch api runtime flag by default
3034         https://bugs.webkit.org/show_bug.cgi?id=160452
3035
3036         Reviewed by Alex Christensen.
3037
3038         * WebView/WebPreferences.mm:
3039         (+[WebPreferences initialize]):
3040
3041 2016-08-21  Alex Christensen  <achristensen@webkit.org>
3042
3043         Use Document& instead of Document* when getting cookies
3044         https://bugs.webkit.org/show_bug.cgi?id=161011
3045
3046         Reviewed by Darin Adler.
3047
3048         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3049         (WebKit::NetscapePluginInstanceProxy::getCookies):
3050         (WebKit::NetscapePluginInstanceProxy::setCookies):
3051         * Plugins/WebNetscapePluginView.mm:
3052         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3053         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
3054
3055 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
3056
3057         Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
3058         https://bugs.webkit.org/show_bug.cgi?id=160923
3059
3060         Reviewed by Tim Horton.
3061
3062         * WebCoreSupport/WebFrameLoaderClient.h:
3063         * WebCoreSupport/WebFrameLoaderClient.mm:
3064         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
3065         (WebFrameLoaderClient::dispatchDidLayout): Deleted.
3066
3067 2016-08-18  Daniel Bates  <dabates@apple.com>
3068
3069         Ld warns of non-existent PrivateFrameworks directory when building WebKit with the public iOS 9.3 SDK
3070         https://bugs.webkit.org/show_bug.cgi?id=160979
3071
3072         Rubber-stamped by Simon Fraser.
3073
3074         Only add the SDK PrivateFrameworks directory to the FRAMEWORK_SEARCH_PATH when building for
3075         iOS Simulator, building with an iOS SDK that does not support text-based stubs, or building
3076         an Apple-internal build.
3077
3078         * Configurations/WebKitLegacy.xcconfig:
3079
3080 2016-08-18  Anders Carlsson  <andersca@apple.com>
3081
3082         Move an NPAPI-only function from WebCore to WebKit
3083         https://bugs.webkit.org/show_bug.cgi?id=160967
3084
3085         Reviewed by Sam Weinig.
3086
3087         * Plugins/WebNetscapePluginView.h:
3088         * Plugins/WebNetscapePluginView.mm:
3089         (-[WebNetscapePluginView getVariable:value:]):
3090         (-[WebNetscapePluginView _destroyPlugin]):
3091
3092 2016-08-18  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
3093
3094         [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
3095         https://bugs.webkit.org/show_bug.cgi?id=156096
3096
3097         Reviewed by Dean Jackson.
3098
3099         Adds:
3100         - Setup interface for enabling runtime flag for Web animations through preferences.
3101
3102         * WebView/WebPreferenceKeysPrivate.h:
3103         * WebView/WebPreferences.mm:
3104         (+[WebPreferences initialize]):
3105         (-[WebPreferences webAnimationsEnabled]):
3106         (-[WebPreferences setWebAnimationsEnabled:]):
3107         * WebView/WebPreferencesPrivate.h:
3108         * WebView/WebView.mm:
3109         (-[WebView _preferencesChanged:]):
3110
3111 2016-08-17  Anders Carlsson  <andersca@apple.com>
3112
3113         Remove a couple of unused WKSI function pointers
3114         https://bugs.webkit.org/show_bug.cgi?id=160946
3115
3116         Reviewed by Dan Bernstein.
3117
3118         * WebCoreSupport/WebSystemInterface.mm:
3119         (InitWebCoreSystemInterface): Deleted.
3120
3121 2016-08-16  Daniel Bates  <dabates@apple.com>
3122
3123         WKSI static library should be named by major iOS revision, not individual updates
3124         https://bugs.webkit.org/show_bug.cgi?id=160727
3125         <rdar://problem/22274848>
3126
3127         Reviewed by Alexey Proskuryakov.
3128
3129         * Configurations/Base.xcconfig:
3130         * Configurations/DebugRelease.xcconfig:
3131         * Configurations/WebKitLegacy.xcconfig:
3132
3133 2016-08-16  Darin Adler  <darin@apple.com>
3134
3135         [Cocoa] Remove dependency on Objective-C bindings in WebKit2 editing code
3136         https://bugs.webkit.org/show_bug.cgi?id=160891
3137
3138         Reviewed by Anders Carlsson.
3139
3140         * WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
3141
3142         * WebCoreSupport/WebEditorClient.mm:
3143         (attributesForAttributedStringConversion): Replaced the
3144         createExcludedElementsForAttributedStringConversion function with this one.
3145         No good reason to keep the array around instead of the dictionary.
3146         (_WebCreateFragment): Renamed from documentFragmentFromAttributedString.
3147         This is now a global function exported so it can be called by WebCore with
3148         a different way of returning its value.
3149
3150         * WebKit.exp: Added _WebCreateFragment.
3151
3152         * WebView/WebHTMLView.mm:
3153         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3154         Removed long-ago-obsolete workaround for Radar bug 5052369.
3155
3156 2016-08-15  Anders Carlsson  <andersca@apple.com>
3157
3158         Another build fix.
3159
3160         * WebKit.exp:
3161
3162 2016-08-15  Anders Carlsson  <andersca@apple.com>
3163
3164         Fix build.
3165
3166         * Configurations/WebKitLegacy.xcconfig:
3167         * WebKit.mac.exp:
3168
3169 2016-08-15  Anders Carlsson  <andersca@apple.com>
3170
3171         Remove OldWebAssertions.c
3172         https://bugs.webkit.org/show_bug.cgi?id=160862
3173
3174         Reviewed by Dan Bernstein.
3175
3176         These functions were used by an old version of iWeb. The latest version of iWeb no longer uses them.
3177
3178         * Misc/OldWebAssertions.c: Removed.
3179         (WebReportAssertionFailure): Deleted.
3180         (WebReportError): Deleted.
3181
3182 2016-08-15  Anders Carlsson  <andersca@apple.com>
3183
3184         Remove WebKeyGenerator
3185         https://bugs.webkit.org/show_bug.cgi?id=160854
3186
3187         Reviewed by Dan Bernstein.
3188
3189         This SPI class is no longer used by Safari.
3190
3191         * WebCoreSupport/WebKeyGenerator.h: Removed.
3192         * WebCoreSupport/WebKeyGenerator.mm: Removed.
3193         (+[WebKeyGenerator sharedGenerator]): Deleted.
3194         (toWebCertificateParseResult): Deleted.
3195         (-[WebKeyGenerator addCertificatesToKeychainFromData:]): Deleted.
3196         * WebView/WebFrameView.mm:
3197
3198 2016-08-15  Daniel Bates  <dabates@apple.com>
3199
3200         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
3201         private frameworks and libraries
3202         https://bugs.webkit.org/show_bug.cgi?id=155931
3203         <rdar://problem/25807989>
3204
3205         Reviewed by Dan Bernstein.
3206
3207         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
3208         where X is the major version of the active iOS SDK.
3209
3210         * Configurations/WebKitLegacy.xcconfig:
3211
3212 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
3213
3214         Add a setting and preferences to enable visual viewport mode
3215         https://bugs.webkit.org/show_bug.cgi?id=160843
3216
3217         Reviewed by Sam Weinig.
3218
3219         Hook up the visualViewportEnabled setting for WebKit1.
3220
3221         * WebView/WebPreferenceKeysPrivate.h:
3222         * WebView/WebPreferences.mm:
3223         (+[WebPreferences initialize]):
3224         (-[WebPreferences visualViewportEnabled]):
3225         (-[WebPreferences setVisualViewportEnabled:]):
3226         * WebView/WebPreferencesPrivate.h:
3227
3228 2016-08-15  Joseph Pecoraro  <pecoraro@apple.com>
3229
3230         Remove unused includes of wtf headers
3231         https://bugs.webkit.org/show_bug.cgi?id=160839
3232
3233         Reviewed by Alex Christensen.
3234
3235         * History/BinaryPropertyList.cpp:
3236         * History/WebBackForwardList.mm:
3237         * History/WebHistoryItemInternal.h:
3238         * Misc/WebNSFileManagerExtras.mm:
3239         * Plugins/Hosted/NetscapePluginHostProxy.h:
3240         * WebCoreSupport/WebPlatformStrategies.mm:
3241         * WebCoreSupport/WebSelectionServiceController.mm:
3242         * WebCoreSupport/WebUserMediaClient.h:
3243
3244 2016-08-12  Anders Carlsson  <andersca@apple.com>
3245
3246         Move the plug-in and WebGL blacklist code to WebCore
3247         https://bugs.webkit.org/show_bug.cgi?id=160831
3248
3249         Reviewed by Sam Weinig.
3250
3251         Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.
3252
3253         * WebCoreSupport/WebFrameLoaderClient.mm:
3254         (shouldBlockPlugin):
3255         (WebFrameLoaderClient::createPlugin):
3256         (WebFrameLoaderClient::createJavaAppletWidget):
3257         (shouldBlockWebGL):
3258         (WebFrameLoaderClient::webGLPolicyForURL):
3259         (WebFrameLoaderClient::resolveWebGLPolicyForURL):
3260
3261 2016-08-14  Daniel Bates  <dabates@apple.com>
3262
3263         Fix compiler errors when building iOS WebKit using the iOS 10 beta SDK
3264         https://bugs.webkit.org/show_bug.cgi?id=160725
3265
3266         Reviewed by Sam Weinig.
3267
3268         OSAtomicCompareAndSwap32() has been deprecated as of the iOS 10 beta SDK. For now,
3269         silence the complier warning.
3270
3271         * WebView/WebView.mm:
3272         (-[WebView _dispatchTileDidDraw:]):
3273
3274 2016-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3275
3276         Remove always true JSC::Debugger::needPauseHandling virtual method
3277         https://bugs.webkit.org/show_bug.cgi?id=160822
3278
3279         Reviewed by Mark Lam.
3280
3281         * WebView/WebScriptDebugger.h:
3282
3283 2016-08-11  Chris Dumez  <cdumez@apple.com>
3284
3285         Regression(r204268): Mail crashes when trying to compose an email
3286         https://bugs.webkit.org/show_bug.cgi?id=160775
3287
3288         Reviewed by Anders Carlsson.
3289
3290         Properly initialize PageConfiguration.pluginInfoProvider in
3291         [WebView initSimpleHTMLDocumentWithStyle] to avoid a null
3292         dereference in Mail when trying to compose an email.
3293
3294         * WebView/WebView.mm:
3295         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3296
3297 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3298
3299         Sort the feature flags in the FEATURE_DEFINES lines
3300         https://bugs.webkit.org/show_bug.cgi?id=160742
3301
3302         Reviewed by Anders Carlsson.
3303
3304         * Configurations/FeatureDefines.xcconfig:
3305
3306 2016-08-09  Alex Christensen  <achristensen@webkit.org>
3307
3308         Move NetworkStorageSession management to WebCore
3309         https://bugs.webkit.org/show_bug.cgi?id=160173
3310
3311         Reviewed by Brady Eidson.
3312
3313         * WebCoreSupport/WebFrameNetworkingContext.mm:
3314         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3315         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3316         * WebCoreSupport/WebPlatformStrategies.mm:
3317         * WebView/WebView.mm:
3318
3319 2016-08-09  Anders Carlsson  <andersca@apple.com>
3320
3321         Instantiate WebKit plug-ins at layout time, instead of at style resolution time
3322         https://bugs.webkit.org/show_bug.cgi?id=160715
3323
3324         Reviewed by Tim Horton.
3325
3326         * WebCoreSupport/WebFrameLoaderClient.mm:
3327         (WebFrameLoaderClient::objectContentType):
3328
3329 2016-08-09  George Ruan  <gruan@apple.com>
3330
3331         Implement functionality of media capture on iOS
3332         https://bugs.webkit.org/show_bug.cgi?id=158945
3333         <rdar://problem/26893343>
3334
3335         Reviewed by Tim Horton.
3336
3337         * Configurations/FeatureDefines.xcconfig: Enable Media Capture feature
3338         for iOS.
3339
3340 2016-08-09  Anders Carlsson  <andersca@apple.com>
3341
3342         Get rid of PluginStrategy
3343         https://bugs.webkit.org/show_bug.cgi?id=160696
3344
3345         Reviewed by Dan Bernstein.
3346
3347         * WebCoreSupport/WebPlatformStrategies.h:
3348         * WebCoreSupport/WebPlatformStrategies.mm:
3349         (WebPlatformStrategies::createPluginStrategy): Deleted.
3350         * WebCoreSupport/WebPluginInfoProvider.h:
3351         * WebCoreSupport/WebPluginInfoProvider.mm:
3352         (WebPluginInfoProvider::setPluginLoadClientPolicy): Deleted.
3353         (WebPluginInfoProvider::clearPluginClientPolicies): Deleted.
3354
3355 2016-08-09  Anders Carlsson  <andersca@apple.com>
3356
3357         Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
3358         https://bugs.webkit.org/show_bug.cgi?id=160694
3359
3360         Reviewed by Dan Bernstein.
3361
3362         * WebCoreSupport/WebPlatformStrategies.h:
3363         * WebCoreSupport/WebPlatformStrategies.mm:
3364         (WebPlatformStrategies::createPluginStrategy):
3365         (WebPlatformStrategies::refreshPlugins): Deleted.
3366         (WebPlatformStrategies::getPluginInfo): Deleted.
3367         (WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
3368         (WebPlatformStrategies::setPluginLoadClientPolicy): Deleted.
3369         (WebPlatformStrategies::clearPluginClientPolicies): Deleted.
3370         * WebCoreSupport/WebPluginInfoProvider.mm:
3371         (WebPluginInfoProvider::refreshPlugins):
3372         (WebPluginInfoProvider::getPluginInfo):
3373         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3374
3375 2016-08-08  Anders Carlsson  <andersca@apple.com>
3376
3377         Add a new PluginInfoProvider class, to replace PluginStrategy
3378         https://bugs.webkit.org/show_bug.cgi?id=160670
3379
3380         Reviewed by Sam Weinig.
3381
3382         Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
3383
3384         * WebCoreSupport/WebPluginInfoProvider.h: Added.
3385         * WebCoreSupport/WebPluginInfoProvider.mm: Added.
3386         (WebPluginInfoProvider::singleton):
3387         (WebPluginInfoProvider::WebPluginInfoProvider):
3388         (WebPluginInfoProvider::~WebPluginInfoProvider):
3389         (WebPluginInfoProvider::refreshPlugins):
3390         (WebPluginInfoProvider::getPluginInfo):
3391         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3392         (WebPluginInfoProvider::setPluginLoadClientPolicy):
3393         (WebPluginInfoProvider::clearPluginClientPolicies):
3394         * WebView/WebView.mm:
3395         (-[WebView _commonInitializationWithFrameName:groupName:]):
3396
3397 2016-08-02  Enrica Casucci  <enrica@apple.com>
3398
3399         Allow building with content filtering disabled.
3400         https://bugs.webkit.org/show_bug.cgi?id=160454
3401
3402         Reviewed by Simon Fraser.
3403
3404         * Configurations/FeatureDefines.xcconfig:
3405         * WebCoreSupport/WebFrameLoaderClient.h:
3406         * WebCoreSupport/WebFrameLoaderClient.mm:
3407         (WebFrameLoaderClient::blockedByContentFilterError):
3408
3409 2016-08-02  Anders Carlsson  <andersca@apple.com>
3410
3411         Remove more unused/uninstalled Objective-C DOM bindings
3412         https://bugs.webkit.org/show_bug.cgi?id=160464
3413
3414         Reviewed by Darin Adler.
3415
3416         Stop installing unused headers.
3417
3418         * MigrateHeaders.make:
3419
3420 2016-08-01  Anders Carlsson  <andersca@apple.com>
3421
3422         Bring back a file - it needs to be copied by WebCore.
3423
3424         * MigrateHeaders.make:
3425
3426 2016-08-01  Anders Carlsson  <andersca@apple.com>
3427
3428         Remove another file.
3429
3430         * MigrateHeaders.make:
3431
3432 2016-08-01  Anders Carlsson  <andersca@apple.com>
3433
3434         Remove a file.
3435
3436         * MigrateHeaders.make:
3437
3438 2016-08-01  Anders Carlsson  <andersca@apple.com>
3439
3440         Freeze all the DOMHTML* Objective-C bindings
3441         https://bugs.webkit.org/show_bug.cgi?id=160424
3442
3443         Reviewed by Tim Horton.
3444
3445         Don't migrate DOMHTMLEmbedElementPrivate.h - it was just an empty header.
3446
3447         * MigrateHeaders.make:
3448
3449 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
3450
3451         Remove deprecated SPI for video inline / fullscreen controls
3452         https://bugs.webkit.org/show_bug.cgi?id=160318
3453
3454         Reviewed by Tim Horton.
3455
3456         * WebView/WebPreferenceKeysPrivate.h:
3457         * WebView/WebPreferences.mm:
3458         (+[WebPreferences initialize]): Deleted.
3459         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]): Deleted.
3460         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]): Deleted.
3461         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]): Deleted.
3462         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]): Deleted.
3463         * WebView/WebPreferencesPrivate.h:
3464         * WebView/WebView.mm:
3465         (-[WebView _preferencesChanged:]): Deleted.
3466
3467 2016-07-28  Anders Carlsson  <andersca@apple.com>
3468
3469         Move a Mail.app workaround closer to where it's actually needed
3470         https://bugs.webkit.org/show_bug.cgi?id=160317
3471
3472         Reviewed by Tim Horton.
3473
3474         * WebCoreSupport/WebFrameLoaderClient.mm:
3475         (WebFrameLoaderClient::dispatchWillSendRequest):
3476         * WebView/WebFrame.mm:
3477         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Deleted.
3478
3479 2016-07-28  Anders Carlsson  <andersca@apple.com>
3480
3481         Use a RetainPtr in WebFrameLoaderClient::assignIdentifierToInitialRequest
3482         https://bugs.webkit.org/show_bug.cgi?id=160315
3483
3484         Reviewed by Tim Horton.
3485
3486         * WebCoreSupport/WebFrameLoaderClient.mm:
3487         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3488
3489 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
3490
3491         Fix the Windows debug build.
3492         
3493         WebResourceLoadScheduler's logging was a holdover from it being in WebCore,
3494         and prior to r203749 WebKit was actually using a WebCore log channel.
3495         
3496         For some reason this doesn't build on Windows debug, so just remove
3497         this logging for now.
3498
3499         * Misc/WebKitLogging.h:
3500
3501 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
3502
3503         [iPhone] Playing a video on tudou.com plays only sound, no video
3504         https://bugs.webkit.org/show_bug.cgi?id=160178
3505         <rdar://problem/27535468>
3506
3507         Reviewed by Eric Carlson and Dan Bernstein.
3508
3509         * WebView/WebPreferenceKeysPrivate.h:
3510         * WebView/WebPreferences.mm:
3511         (+[WebPreferences initialize]):
3512         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]):
3513         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]):
3514         * WebView/WebPreferencesPrivate.h:
3515         * WebView/WebView.mm:
3516         (-[WebView _preferencesChanged:]):
3517
3518 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
3519
3520         Allow LOG macros to be used outside the namespace, and other logging cleanup
3521         https://bugs.webkit.org/show_bug.cgi?id=160216
3522
3523         Reviewed by Anders Carlsson.
3524
3525         Fix some issues with the LOG macros.
3526         
3527         First, they were not usable outside the WebKit namespace in WebKit2 code. Fix by moving
3528         its log channels outside of the namespace (they are protected by a unique prefix anyway).
3529         
3530         Second, allow LOG_WITH_STREAM to be used in WebKit2 by moving that and a helper macro
3531         into LogMacros.h, which is exported from WebCore as a private header.
3532         
3533         Third, split the Logging.h header into two. Logging.h remains for framework-internal
3534         log channels and log macros. Add LogInitialization.h which is external, and used to
3535         initialize the channels.
3536         
3537         Finally unify "initializeLogChannels" and "initializeLoggingChannels" terminology everywhere.
3538
3539         * Misc/WebKitLogging.h:
3540         * Misc/WebKitLogging.m:
3541         * WebView/WebView.mm:
3542         (-[WebView _commonInitializationWithFrameName:groupName:]):
3543
3544 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3545
3546         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
3547         https://bugs.webkit.org/show_bug.cgi?id=160066
3548
3549         Reviewed by Dean Jackson.
3550
3551         * WebView/WebPreferenceKeysPrivate.h:
3552         * WebView/WebPreferences.mm:
3553         (+[WebPreferences initialize]): Deleted.
3554         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]): Deleted.
3555         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): Deleted.
3556         * WebView/WebPreferencesPrivate.h:
3557         * WebView/WebView.mm:
3558         (-[WebView _preferencesChanged:]): Deleted.
3559
3560 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3561
3562         [iPhone] Playing a video on tudou.com plays only sound, no video
3563         https://bugs.webkit.org/show_bug.cgi?id=159967
3564         <rdar://problem/26964090>
3565
3566         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
3567
3568         Add the two preferences to WebPreferences.
3569
3570         * WebView/WebPreferenceKeysPrivate.h:
3571         * WebView/WebPreferences.mm:
3572         (+[WebPreferences initialize]):
3573         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
3574         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
3575         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
3576         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
3577         * WebView/WebPreferencesPrivate.h:
3578         * WebView/WebView.mm:
3579         (-[WebView _preferencesChanged:]):
3580
3581 2016-07-20  Commit Queue  <commit-queue@webkit.org>
3582
3583         Unreviewed, rolling out r203471.
3584         https://bugs.webkit.org/show_bug.cgi?id=160003
3585
3586         many iOS-simulator tests are failing (Requested by litherum on
3587         #webkit).
3588
3589         Reverted changeset:
3590
3591         "[iPhone] Playing a video on tudou.com plays only sound, no
3592         video"
3593         https://bugs.webkit.org/show_bug.cgi?id=159967
3594         http://trac.webkit.org/changeset/203471
3595
3596 2016-07-20  Myles C. Maxfield  <mmaxfield@apple.com>
3597
3598         [iPhone] Playing a video on tudou.com plays only sound, no video
3599         https://bugs.webkit.org/show_bug.cgi?id=159967
3600         <rdar://problem/26964090>
3601
3602         Reviewed by Jon Lee.
3603
3604         Add the two preferences to WebPreferences.
3605
3606         * WebView/WebPreferenceKeysPrivate.h:
3607         * WebView/WebPreferences.mm:
3608         (+[WebPreferences initialize]):
3609         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
3610         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
3611         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
3612         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
3613         * WebView/WebPreferencesPrivate.h:
3614         * WebView/WebView.mm:
3615         (-[WebView _preferencesChanged:]):
3616
3617 2016-07-19  Andy Estes  <aestes@apple.com>
3618
3619         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
3620         https://bugs.webkit.org/show_bug.cgi?id=159956
3621
3622         Reviewed by Dan Bernstein.
3623
3624         * Misc/WebKitErrors.h: Moved definition of WebKitErrorFrameLoadBlockedByContentFilter from here ...
3625         * Misc/WebKitErrorsPrivate.h: to here.
3626
3627 2016-07-18  Anders Carlsson  <andersca@apple.com>
3628
3629         WebKit nightly fails to build on macOS Sierra
3630         https://bugs.webkit.org/show_bug.cgi?id=159902
3631         rdar://problem/27365672
3632
3633         Reviewed by Tim Horton.
3634
3635         * icu/unicode/ucurr.h: Added.
3636         Add ucurr.h from ICU.
3637
3638 2016-07-17  Sam Weinig  <sam@webkit.org>
3639
3640         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3641         <rdar://problem/26554137>
3642         https://bugs.webkit.org/show_bug.cgi?id=159856
3643
3644         Reviewed by Dan Bernstein.
3645
3646         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3647         (WebKit::NetscapePluginInstanceProxy::evaluate):
3648         * Plugins/WebNetscapePluginView.mm:
3649         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
3650         Update for new UserGestureIndicator interface.
3651
3652 2016-07-16  Ryosuke Niwa  <rniwa@webkit.org>
3653
3654         Rename fastGetAttribute to attributeWithoutSynchronization
3655         https://bugs.webkit.org/show_bug.cgi?id=159852
3656
3657         Reviewed by Darin Adler.
3658
3659         * WebView/WebHTMLRepresentation.mm:
3660         (matchLabelsAgainstElement):
3661
3662 2016-07-15  Chris Dumez  <cdumez@apple.com>
3663
3664         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
3665         https://bugs.webkit.org/show_bug.cgi?id=159793
3666
3667         Reviewed by Ryosuke Niwa.
3668
3669         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.
3670
3671         * WebView/WebHTMLRepresentation.mm:
3672         (matchLabelsAgainstElement):
3673
3674 2016-07-14  Alex Christensen  <achristensen@webkit.org>
3675
3676         Use SocketProvider to create SocketStreamHandles
3677         https://bugs.webkit.org/show_bug.cgi?id=159774
3678
3679         Reviewed by Brady Eidson.
3680
3681         * Misc/WebSocketProvider.h: Removed.
3682         * Misc/WebSocketProvider.mm: Removed.
3683         * WebView/WebView.mm:
3684         (-[WebView _commonInitializationWithFrameName:groupName:]):
3685         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3686
3687 2016-07-14  Csaba Osztrogonác  <ossy@webkit.org>
3688
3689         Fix the !ENABLE(WEB_SOCKETS) build after r202930
3690         https://bugs.webkit.org/show_bug.cgi?id=159768
3691
3692         Reviewed by Alex Christensen.
3693
3694         * Misc/WebSocketProvider.h:
3695
3696 2016-07-13  Beth Dakin  <bdakin@apple.com>
3697
3698         Add more candidate tests
3699         https://bugs.webkit.org/show_bug.cgi?id=159730
3700
3701         Reviewed by Tim Horton.
3702
3703         Move shouldRequestCandidates from WebViewInternal to WebViewPrivate so that 
3704         we can use it in tests. 
3705         * WebView/WebViewInternal.h:
3706         * WebView/WebViewPrivate.h:
3707
3708 2016-07-13  Enrica Casucci  <enrica@apple.com>
3709
3710         Update supported platforms in xcconfig files to match the sdk names.
3711         https://bugs.webkit.org/show_bug.cgi?id=159728
3712
3713         Reviewed by Tim Horton.
3714
3715         * Configurations/Base.xcconfig:
3716
3717 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3718
3719         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3720         https://bugs.webkit.org/show_bug.cgi?id=159671
3721
3722         Reviewed by Csaba Osztrogonác.
3723
3724         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3725         https://bugs.webkit.org/show_bug.cgi?id=89235
3726
3727         So this guard can be removed in build scripts.
3728
3729         * Configurations/FeatureDefines.xcconfig:
3730
3731 2016-07-11  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3732
3733         Purge PassRefPtr in platform/efl and platform/mac 
3734         https://bugs.webkit.org/show_bug.cgi?id=159548
3735
3736         Reviewed by Alex Christensen.
3737
3738         Remove all use of PassRefPtr and clean up unnecessary tabs and spaces.
3739
3740         * WebCoreSupport/WebPlatformStrategies.h:
3741         * WebCoreSupport/WebPlatformStrategies.mm:
3742         (WebPlatformStrategies::setBufferForType):
3743
3744 2016-07-11  Enrica Casucci  <enrica@apple.com>
3745
3746         Add synthetic click origin to WKNavigationAction.
3747         https://bugs.webkit.org/show_bug.cgi?id=159584
3748         rdar://problem/25610422
3749
3750         Reviewed by Tim Horton.
3751
3752         * WebView/WebFrame.mm:
3753         (-[WebFrame _dragSourceEndedAt:operation:]):
3754         * WebView/WebPDFView.mm:
3755         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3756
3757 2016-07-11  Anders Carlsson  <andersca@apple.com>
3758
3759         Able to open multiple payment sheets in Safari at the same time
3760         https://bugs.webkit.org/show_bug.cgi?id=159637
3761         rdar://problem/26411339
3762
3763         Reviewed by Beth Dakin.
3764
3765         Update for WebCore changes.
3766
3767         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3768         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3769         (WebPaymentCoordinatorClient::showPaymentUI):
3770
3771 2016-07-08  Andy Estes  <aestes@apple.com>
3772
3773         [Content Filtering] Load blocked pages more like other error pages are loaded
3774         https://bugs.webkit.org/show_bug.cgi?id=159485
3775         <rdar://problem/26014076>
3776
3777         Reviewed by Brady Eidson.
3778
3779         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
3780         * Misc/WebKitErrors.m:
3781         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
3782         * WebCoreSupport/WebFrameLoaderClient.h:
3783         * WebCoreSupport/WebFrameLoaderClient.mm:
3784         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
3785
3786 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3787
3788         Unreviewed, rolling out r202944.
3789         https://bugs.webkit.org/show_bug.cgi?id=159570
3790
3791         caused some tests to crash under GuardMalloc (Requested by
3792         estes on #webkit).
3793
3794         Reverted changeset:
3795
3796         "[Content Filtering] Load blocked pages more like other error
3797         pages are loaded"
3798         https://bugs.webkit.org/show_bug.cgi?id=159485
3799         http://trac.webkit.org/changeset/202944
3800
3801 2016-07-08  Jiewen Tan  <jiewen_tan@apple.com>
3802
3803         Define DYLD_MACOSX_VERSION_10_12
3804         https://bugs.webkit.org/show_bug.cgi?id=159525
3805         <rdar://problem/26250296>
3806
3807         Reviewed by Brent Fulgham.
3808
3809         * WebView/WebView.mm:
3810         (shouldConvertInvalidURLsToBlank):
3811         Replace 0x000A0C00 with DYLD_MACOSX_VERSION_10_12.
3812
3813 2016-07-07  Beth Dakin  <bdakin@apple.com>
3814
3815         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3816         https://bugs.webkit.org/show_bug.cgi?id=159532
3817         -and corresponding-
3818         rdar://problem/27177179
3819
3820         Reviewed by Tim Horton.
3821
3822         * WebView/WebView.mm:
3823         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3824         (-[WebView forceRequestCandidatesForTesting]):
3825         (-[WebView shouldRequestCandidates]):
3826         * WebView/WebViewPrivate.h:
3827
3828 2016-07-07  Andy Estes  <aestes@apple.com>
3829
3830         [Content Filtering] Load blocked pages more like other error pages are loaded
3831         https://bugs.webkit.org/show_bug.cgi?id=159485
3832         <rdar://problem/26014076>
3833
3834         Reviewed by Brady Eidson.
3835
3836         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
3837         * Misc/WebKitErrors.m:
3838         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
3839         * WebCoreSupport/WebFrameLoaderClient.h:
3840         * WebCoreSupport/WebFrameLoaderClient.mm:
3841         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
3842
3843 2016-07-07  Alex Christensen  <achristensen@webkit.org>
3844
3845         Use SocketProvider to create WebSocketChannels
3846         https://bugs.webkit.org/show_bug.cgi?id=158776
3847
3848         Reviewed by Brent Fulgham.
3849
3850         * Misc/WebSocketProvider.mm: Copied from Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp.
3851         (WebSocketProvider::createWebSocketChannel):
3852         (WebCore::ThreadableWebSocketChannel::create): Deleted.
3853         * Misc/WebSocketProvider.h:
3854         * WebView/WebView.mm:
3855         (-[WebView _commonInitializationWithFrameName:groupName:]):
3856         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3857
3858 2016-07-06  Benjamin Poulain  <bpoulain@apple.com>
3859
3860         [JSC] Unify how we throw TypeError from C++
3861         https://bugs.webkit.org/show_bug.cgi?id=159500
3862
3863         Reviewed by Saam Barati.
3864
3865         * Plugins/Hosted/ProxyInstance.mm:
3866         (WebKit::ProxyInstance::invokeMethod):
3867
3868 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3869
3870         Add a runtime flag for DOM iterators
3871         https://bugs.webkit.org/show_bug.cgi?id=159300
3872
3873         Reviewed by Alex Christensen.
3874
3875         * WebView/WebPreferenceKeysPrivate.h:
3876         * WebView/WebPreferences.mm:
3877         (-[WebPreferences DOMIteratorEnabled]):
3878         (-[WebPreferences setDOMIteratorEnabled:]):
3879         * WebView/WebPreferencesPrivate.h:
3880         * WebView/WebView.mm:
3881         (-[WebView _preferencesChanged:]):
3882
3883 2016-06-30  Jiewen Tan  <jiewen_tan@apple.com>
3884
3885         Create a generic "linked-on-or-after" check for new CSP Rules
3886         https://bugs.webkit.org/show_bug.cgi?id=159322
3887         <rdar://problem/27117220>
3888
3889         Reviewed by Brent Fulgham.
3890
3891         * WebView/WebView.mm:
3892         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
3893
3894 2016-06-30  Anders Carlsson  <andersca@apple.com>
3895
3896         Mail crashes on launch at WebCore::PaymentCoordinator::~PaymentCoordinator() + 20
3897         https://bugs.webkit.org/show_bug.cgi?id=159306
3898         rdar://problem/27092107
3899
3900         Reviewed by Tim Horton.
3901
3902         * WebView/WebView.mm:
3903         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3904         Create a WebPaymentCoordinatorClient. Remove an unneeded #import.
3905
3906         (-[WebView _commonInitializationWithFrameName:groupName:]):
3907         Remove an unneeded #import.
3908
3909 2016-06-27  Anders Carlsson  <andersca@apple.com>
3910
3911         WebKit::WebPaymentCoordinator leak
3912         https://bugs.webkit.org/show_bug.cgi?id=159168
3913         rdar://problem/26929772
3914
3915         Reviewed by Beth Dakin.
3916
3917         Update for WebCore changes.
3918
3919         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3920         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3921         (WebPaymentCoordinatorClient::paymentCoordinatorDestroyed):
3922         (WebPaymentCoordinatorClient::mainFrameDestroyed): Deleted.
3923
3924 2016-06-27  Tim Horton  <timothy_horton@apple.com>
3925
3926         REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app
3927         https://bugs.webkit.org/show_bug.cgi?id=159184
3928         <rdar://problem/26370206>
3929
3930         Reviewed by Beth Dakin.
3931
3932         * WebView/WebHTMLView.mm:
3933         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3934         * WebView/WebImmediateActionController.h:
3935         * WebView/WebImmediateActionController.mm:
3936         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3937         (-[WebImmediateActionController _animationControllerForText]):
3938         (dictionaryPopupInfoForRange): Deleted.
3939         WebImmediateActionController's code to make a DictionaryPopupInfo and TextIndicator
3940         from a Range in WebKit1 is much better than WebHTMLView's; use it in both cases.
3941
3942 2016-06-24  Jer Noble  <jer.noble@apple.com>
3943
3944         Playback controls refer to wrong element when playing multiple items in a page.
3945         https://bugs.webkit.org/show_bug.cgi?id=159076
3946         <rdar://problem/26953532>
3947
3948         Reviewed by Beth Dakin.
3949
3950         clearPlaybackControlsManager() no longer takes a parameter.
3951
3952         * WebCoreSupport/WebChromeClient.h:
3953         * WebCoreSupport/WebChromeClient.mm:
3954         (WebChromeClient::clearPlaybackControlsManager):
3955         * WebView/WebView.mm:
3956         (-[WebView _clearPlaybackControlsManager]): Renamed from _clearPlaybackControlsManagerForMediaElement:.
3957         * WebView/WebViewInternal.h:
3958
3959 2016-06-23  Alex Christensen  <achristensen@webkit.org>
3960
3961         Remove unused didCancelAuthenticationChallenge
3962         https://bugs.webkit.org/show_bug.cgi?id=158819
3963
3964         Reviewed by David Kilzer.
3965
3966         * Misc/WebDownload.mm:
3967         (-[WebDownloadInternal download:didCancelAuthenticationChallenge:]): Deleted.
3968         * WebCoreSupport/WebFrameLoaderClient.h:
3969         * WebCoreSupport/WebFrameLoaderClient.mm:
3970         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.
3971         * WebView/WebDelegateImplementationCaching.h:
3972         * WebView/WebView.mm:
3973         (-[WebView _cacheResourceLoadDelegateImplementations]):
3974
3975 2016-06-23  John Wilander  <wilander@apple.com>
3976
3977         Enable window.open() for existing versions of Secret Society app
3978         https://bugs.webkit.org/show_bug.cgi?id=159049
3979         <rdar://problem/26528349>
3980
3981         Reviewed by Andy Estes.
3982
3983         The Secret Society Hidden Mystery app has a broken version check treating iOS 10
3984         as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
3985         handler. We should allow the existing versions of the app to do this to not break
3986         them.
3987
3988         * WebView/WebView.mm:
3989         (shouldAllowWindowOpenWithoutUserGesture):
3990             Added.
3991         (shouldConvertInvalidURLsToBlank):
3992             Changed hex number to constant DYLD_IOS_VERSION_10_0.
3993
3994 2016-06-22  Anders Carlsson  <andersca@apple.com>
3995
3996         Move the WebKitLegacy Apple Pay code to the open source repository
3997         https://bugs.webkit.org/show_bug.cgi?id=159035
3998
3999         Reviewed by Tim Horton.
4000
4001         * WebCoreSupport/WebPaymentCoordinatorClient.h: Added.
4002         * WebCoreSupport/WebPaymentCoordinatorClient.mm: Added.
4003         (WebPaymentCoordinatorClient::WebPaymentCoordinatorClient):
4004         (WebPaymentCoordinatorClient::~WebPaymentCoordinatorClient):
4005         (WebPaymentCoordinatorClient::supportsVersion):
4006         (WebPaymentCoordinatorClient::canMakePayments):
4007         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
4008         (WebPaymentCoordinatorClient::showPaymentUI):
4009         (WebPaymentCoordinatorClient::completeMerchantValidation):
4010         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
4011         (WebPaymentCoordinatorClient::completeShippingContactSelection):
4012         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
4013         (WebPaymentCoordinatorClient::completePaymentSession):
4014         (WebPaymentCoordinatorClient::abortPaymentSession):
4015         (WebPaymentCoordinatorClient::mainFrameDestroyed):
4016         * WebKitAdditions.mm: Removed.
4017         * WebView/WebView.mm:
4018         (-[WebView _commonInitializationWithFrameName:groupName:]):
4019
4020 2016-06-21  Anders Carlsson  <andersca@apple.com>
4021
4022         Fix build.
4023
4024         * Configurations/FeatureDefines.xcconfig:
4025
4026 2016-06-21  Anders Carlsson  <andersca@apple.com>
4027
4028         Begin moving the Apple Pay code to the open source repository
4029         https://bugs.webkit.org/show_bug.cgi?id=158998
4030
4031         Reviewed by Tim Horton.
4032
4033         * Configurations/FeatureDefines.xcconfig:
4034         Add ENABLE_APPLE_PAY.
4035
4036 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
4037
4038         Focus event dispatched in iframe causes parent document to scroll incorrectly
4039         https://bugs.webkit.org/show_bug.cgi?id=158629
4040         rdar://problem/26521616
4041
4042         Reviewed by Tim Horton.
4043         
4044         Pass SelectionRevealMode::Reveal in existing code.
4045
4046         * WebView/WebFrame.mm:
4047         (-[WebFrame _scrollDOMRangeToVisible:]):
4048         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
4049         (-[WebFrame revealSelectionAtExtent:]):
4050         * WebView/WebHTMLView.mm:
4051         (-[WebHTMLView jumpToSelection:]):
4052         (-[WebHTMLView centerSelectionInVisibleArea:]):
4053
4054 2016-06-21  Amir Alavi  <aalavi@apple.com>
4055
4056         Upstream WKHTTPCookiesForURL from WebKitSystemInterface to OpenSource
4057         https://bugs.webkit.org/show_bug.cgi?id=158967
4058
4059         Reviewed by Brent Fulgham.
4060
4061         * WebCoreSupport/WebSystemInterface.mm:
4062         (InitWebCoreSystemInterface): Deleted.
4063
4064 2016-06-20  Commit Queue  <commit-queue@webkit.org>
4065
4066         Unreviewed, rolling out r202243.
4067         https://bugs.webkit.org/show_bug.cgi?id=158972
4068
4069         Broke Windows build and iOS tests (Requested by ap on
4070         #webkit).
4071
4072         Reverted changeset:
4073
4074         "Focus event dispatched in iframe causes parent document to
4075         scroll incorrectly"
4076         https://bugs.webkit.org/show_bug.cgi?id=158629
4077         http://trac.webkit.org/changeset/202243
4078
4079 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
4080
4081         Focus event dispatched in iframe causes parent document to scroll incorrectly
4082         https://bugs.webkit.org/show_bug.cgi?id=158629
4083         rdar://problem/26521616
4084
4085         Reviewed by Tim Horton.
4086         
4087         Pass SelectionRevealMode::Reveal in existing code.
4088
4089         * WebView/WebFrame.mm:
4090         (-[WebFrame _scrollDOMRangeToVisible:]):
4091         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
4092         (-[WebFrame revealSelectionAtExtent:]):
4093         * WebView/WebHTMLView.mm:
4094         (-[WebHTMLView jumpToSelection:]):
4095         (-[WebHTMLView centerSelectionInVisibleArea:]):
4096
4097 2016-06-20  Keith Rollin  <krollin@apple.com>
4098
4099         Remove RefPtr::release() and change calls sites to use WTFMove()
4100         https://bugs.webkit.org/show_bug.cgi?id=158369
4101
4102         Reviewed by Chris Dumez.
4103
4104         RefPtr::release() releases its managed pointer awkwardly. It's more
4105         direct and clearer to use WTFMove to transfer ownership of the managed
4106         pointer.
4107
4108         As part of this cleanup, also change a lot of explicit data types to
4109         'auto'.
4110
4111         * Plugins/Hosted/NetscapePluginHostManager.mm:
4112         (WebKit::NetscapePluginHostManager::instantiatePlugin):
4113         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4114         (WebKit::NetscapePluginInstanceProxy::create):
4115         (WebKit::NetscapePluginInstanceProxy::loadRequest):
4116         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
4117         * WebCoreSupport/WebFrameLoaderClient.mm:
4118         (-[WebFramePolicyListener receivedPolicyDecision:]):
4119         * WebCoreSupport/WebSecurityOrigin.mm:
4120         (-[WebSecurityOrigin initWithURL:]):
4121         * WebView/WebArchive.mm:
4122         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
4123         (-[WebArchive initWithData:]):
4124         * WebView/WebDataSource.mm:
4125         (-[WebDataSource mainResource]):
4126         * WebView/WebFrame.mm:
4127         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
4128
4129 2016-06-15  Alexey Proskuryakov  <ap@apple.com>
4130
4131         +[WebHTMLRepresentation supportedMIMETypes] leaks
4132         https://bugs.webkit.org/show_bug.cgi?id=158683
4133
4134         Reviewed by Darin Adler.
4135
4136         The problem occurred when chaining newArrayByConcatenatingArrays calls.
4137
4138         Also refactored the code to avoid returning NSMutableArrays disguised as NSArrays,
4139         and removed __unsafe_unretained modifiers that were added in http://trac.webkit.org/r149453
4140         for no apparent reason.
4141
4142         * WebView/WebHTMLRepresentation.mm:
4143         (newArrayWithStrings):
4144         (+[WebHTMLRepresentation supportedMIMETypes]):
4145         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
4146         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
4147         (+[WebHTMLRepresentation supportedImageMIMETypes]):
4148         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
4149         (newArrayByConcatenatingArrays): Deleted.
4150
4151 2016-06-15  Dean Jackson  <dino@apple.com>
4152
4153         RTL <select> forms are misplaced
4154         https://bugs.webkit.org/show_bug.cgi?id=158810
4155         <rdar://problem/24847541>
4156
4157         Reviewed by Eric Carlson.
4158
4159         AppKit made a change in Sierra that causes popup menus
4160         to snap to a different point when the system language is RTL.
4161         We need to be more explicit about what directionality
4162         we want, and override the location of the popup based
4163         on the text direction.
4164
4165         I also made a small tweak to the fudge offsets we use
4166         in order to make button text and menu text to be
4167         more consistent.
4168
4169         Unfortunately since this is just about the location
4170         of the popup menu, it's unable to be tested in our
4171         current infrastructure.
4172
4173         * WebCoreSupport/PopupMenuMac.mm:
4174         (PopupMenuMac::show):
4175
4176 2016-06-15  Chris Dumez  <cdumez@apple.com>
4177
4178         Drop some unnecessary header includes
4179         https://bugs.webkit.org/show_bug.cgi?id=158788
4180
4181         Reviewed by Alexey Proskuryakov.
4182
4183         Drop some unnecessary header includes in headers to speed up build time.
4184
4185         * WebCoreSupport/WebFrameLoaderClient.mm:
4186
4187 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
4188
4189         Enabling Shadow DOM for all platforms
4190         https://bugs.webkit.org/show_bug.cgi?id=158738
4191
4192         Reviewed&nbs