There should only be one way to get the system memory size.
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-04-23  Andreas Kling  <akling@apple.com>
2
3         There should only be one way to get the system memory size.
4         <https://webkit.org/b/144081>
5
6         Reviewed by Antti Koivisto.
7
8         * Misc/WebKitSystemBits.h:
9         * Misc/WebKitSystemBits.m:
10         (WebMemorySize): Deleted.
11         * WebView/WebView.mm:
12         (+[WebView _setCacheModel:]):
13         (roundUpToPowerOf2): Deleted.
14
15 2015-04-22  Darin Adler  <darin@apple.com>
16
17         Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2
18         https://bugs.webkit.org/show_bug.cgi?id=143943
19
20         Reviewed by Anders Carlsson.
21
22         * Plugins/Hosted/ProxyInstance.h: Removed unneeded include.
23         * Plugins/WebBaseNetscapePluginView.h: Ditto.
24
25         * Plugins/WebNetscapePluginEventHandler.h: Use unique_ptr instead of
26         PassOwnPtr for the create function. Also tweaked formatting and removed
27         unneeded forward declaration of CGRect.
28         * Plugins/WebNetscapePluginEventHandler.mm:
29         (WebNetscapePluginEventHandler::create): Changed to use unique_ptr and
30         make_unique.
31
32         * Plugins/WebNetscapePluginView.h: Use unique_ptr instead of OwnPtr for
33         the _eventHandler field.
34         * Plugins/WebNetscapePluginView.mm:
35         (-[WebNetscapePluginView destroyPlugin]): Changed code to work with unique_ptr.
36
37         * WebCoreSupport/WebUserMediaClient.mm: Removed unneeded include.
38
39         * WebView/WebDeviceOrientationProviderMock.mm: Changed to use make_unique.
40         * WebView/WebDeviceOrientationProviderMockInternal.h: Changed to use unique_ptr.
41
42         * WebView/WebFrame.mm:
43         (vectorForDictationPhrasesArray): Changed to return Vector<Vector<String>> and
44         not a PassOwnPtr. Also rewrote to be much simpler, although there is still a
45         pre-existing problem here where this could put empty vectors into the result,
46         and I'm pretty sure the client never expects any of the Vector<String> to be empty.
47         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
48         Rewrote logic to involve WebCore types a bit less; old code was round tripping
49         things through WebCore::URL for no obvious reason.
50
51         * WebView/WebFrameInternal.h: Changed vectorForDictationPhrasesArray to return
52         a Vector<Vector<String>> and not a PassOwnPtr.
53
54         * WebView/WebFullScreenController.h: Removed unneeded include.
55
56         * WebView/WebViewData.h: Changed m_alternativeTextUIController to be a
57         m_alternativeTextUIController.
58         * WebView/WebViewData.mm:
59         (-[WebViewPrivate init]): Use make_unique to initialize m_alternativeTextUIController.
60
61 2015-04-22  Brent Fulgham  <bfulgham@apple.com>
62
63         VisibleSelection should only accept Range by reference
64         https://bugs.webkit.org/show_bug.cgi?id=144047
65
66         Reviewed by Tim Horton.
67
68         Update all uses of VisibleSelection to pass a Range reference instead
69         of a Range pointer.
70
71         * WebCoreSupport/WebContextMenuClient.mm:
72         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
73         * WebView/WebFrame.mm:
74         (-[WebFrame _selectNSRange:]):
75
76 2015-04-22  Eric Carlson  <eric.carlson@apple.com>
77
78         [Mac] Device picker menu is positioned incorrectly in WK1
79         https://bugs.webkit.org/show_bug.cgi?id=144049
80         <rdar://problem/20493101>
81
82         Reviewed by Dean Jackson.
83
84         * WebView/WebView.mm:
85         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]): Mouse location is already in
86             window coordinates so don't call convertRect:toView:nil.
87
88 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
89
90         Extend action menus to support PDF
91         https://bugs.webkit.org/show_bug.cgi?id=143895
92         <rdar://problem/19003333>
93
94         Reviewed by Tim Horton.
95
96         Prevent a crash when someone attempts to invoke an action menu on a PDF hosted
97         in a WK1 view.
98
99         * WebView/WebActionMenuController.mm:
100         (-[WebActionMenuController performHitTestAtPoint:]): Handle WebPDFView as well as
101         the WebHTMLView case.
102         * WebView/WebDocument.h:
103         * WebView/WebHTMLView.h:
104         * WebView/WebHTMLView.mm:
105         (-[WebHTMLView _frame]):
106         * WebView/WebHTMLViewInternal.h:
107         * WebView/WebPDFView.h:
108         * WebView/WebPDFView.mm:
109         (-[WebPDFView _frame]): Added.
110
111 2015-04-22  Eric Carlson  <eric.carlson@apple.com>
112
113         Unreviewed post-review clean up after r183096.
114
115         * WebView/WebMediaPlaybackTargetPicker.h:
116
117 2015-04-21  Eric Carlson  <eric.carlson@apple.com>
118
119         [Mac] Use one playback target for all web processes
120         https://bugs.webkit.org/show_bug.cgi?id=144009
121
122         Reviewed by Tim Horton.
123
124         Update to use WebMediaSessionManager for playback target management.
125
126         * WebCoreSupport/WebChromeClient.h:
127         * WebCoreSupport/WebChromeClient.mm:
128         (WebChromeClient::addPlaybackTargetPickerClient):
129         (WebChromeClient::removePlaybackTargetPickerClient):
130         (WebChromeClient::showPlaybackTargetPicker):
131         (WebChromeClient::playbackTargetPickerClientStateDidChange):
132         (WebChromeClient::startingMonitoringPlaybackTargets): Deleted.
133         (WebChromeClient::stopMonitoringPlaybackTargets): Deleted.
134         * WebView/WebMediaPlaybackTargetPicker.h:
135         * WebView/WebMediaPlaybackTargetPicker.mm:
136         (WebMediaPlaybackTargetPicker::addPlaybackTargetPickerClient):
137         (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
138         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
139         (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
140         (WebMediaPlaybackTargetPicker::setPlaybackTarget):
141         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange):
142         (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget):
143         (WebMediaPlaybackTargetPicker::invalidate):
144         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): Deleted.
145         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): Deleted.
146         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Deleted.
147         (WebMediaPlaybackTargetPicker::targetPicker): Deleted.
148         * WebView/WebView.mm:
149         (-[WebView _addPlaybackTargetPickerClient:]):
150         (-[WebView _removePlaybackTargetPickerClient:]):
151         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
152         (-[WebView _playbackTargetPickerClientStateDidChange:state:]):
153         (-[WebView _showPlaybackTargetPicker:hasVideo:]): Deleted.
154         (-[WebView _startingMonitoringPlaybackTargets]): Deleted.
155         (-[WebView _stopMonitoringPlaybackTargets]): Deleted.
156         * WebView/WebViewInternal.h:
157
158 2015-04-20  Alexey Proskuryakov  <ap@apple.com>
159
160         Disable mixed content blocking for existing WebKit1 clients
161         https://bugs.webkit.org/show_bug.cgi?id=143955
162         rdar://problem/20177186
163
164         Reviewed by Oliver Hunt.
165
166         * Misc/WebKitVersionChecks.h:
167         * WebView/WebView.mm:
168         (shouldAllowInsecureContent):
169         (-[WebView _preferencesChanged:]):
170
171 2015-04-20  Tim Horton  <timothy_horton@apple.com>
172
173         Implement immediate action support for tel: and mailto: URLs
174         https://bugs.webkit.org/show_bug.cgi?id=143916
175         <rdar://problem/19721711>
176
177         Reviewed by Darin Adler.
178
179         * WebView/WebImmediateActionController.mm:
180         (-[WebImmediateActionController _defaultAnimationController]):
181         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
182         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
183         (-[WebImmediateActionController _menuItemForDataDetectedText]): Deleted.
184         * WebView/WebUIDelegatePrivate.h:
185         Add _animationControllerForDataDetectedLink and use it when
186         building immediate actions for tel: and mailto: links.
187
188 2015-04-17  Daniel Bates  <dabates@apple.com>
189
190         REGRESSION: SVG does not support link dragging
191         https://bugs.webkit.org/show_bug.cgi?id=141597
192
193         Reviewed by Darin Adler.
194
195         Write -[WebElementDictionary _isLiveLink] in terms of WebCore::isDraggableLink().
196
197         * Misc/WebElementDictionary.mm:
198         (-[WebElementDictionary _isLiveLink]):
199
200 2015-04-16  Sam Weinig  <sam@webkit.org>
201
202         Expose JavaScriptMarkupEnabled preference for WebKit1
203         <rdar://problem/19939450>
204         https://bugs.webkit.org/show_bug.cgi?id=143855
205
206         Reviewed by Dan Bernstein.
207
208         * WebView/WebPreferenceKeysPrivate.h:
209         Add new key, WebKitJavaScriptMarkupEnabledPreferenceKey
210
211         * WebView/WebPreferences.mm:
212         (+[WebPreferences initialize]):
213         Initialize WebKitJavaScriptMarkupEnabledPreferenceKey to YES.
214
215         (-[WebPreferences isJavaScriptMarkupEnabled]):
216         (-[WebPreferences setJavaScriptMarkupEnabled:]):
217         Implement getter/setter.
218
219         * WebView/WebPreferencesPrivate.h:
220         Add new property, javaScriptMarkupEnabled.
221
222         * WebView/WebView.mm:
223         (-[WebView _preferencesChanged:]):
224         Map the new preference to WebCore's scriptMarkupEnabled setting.
225
226 2015-04-15  Brent Fulgham  <bfulgham@apple.com>
227
228         [Mac] Disable "Save to Downloads" option for local files
229         https://bugs.webkit.org/show_bug.cgi?id=143794
230
231         Reviewed by Tim Horton.
232
233         Disable the Image and Media download options if the download
234         target is a local file. We can only download web resources;
235         anything else is actually a no-op.
236
237         * WebView/WebActionMenuController.mm:
238         (-[WebActionMenuController _defaultMenuItemsForImage]):
239         (-[WebActionMenuController _defaultMenuItemsForVideo]):
240
241 2015-04-15  Alex Christensen  <achristensen@webkit.org>
242
243         Progress towards CMake on Mac.
244         https://bugs.webkit.org/show_bug.cgi?id=143785
245
246         Reviewed by Csaba Osztrogonác.
247
248         * WebView/WebPDFDocumentExtras.mm:
249         * WebView/WebPDFView.mm:
250
251 2015-04-13  Jer Noble  <jer.noble@apple.com>
252
253         [Fullscreen] ChromeClient::exitVideoFullscreen() should take a pointer to a HTMLVideoElement.
254         https://bugs.webkit.org/show_bug.cgi?id=143674
255
256         Reviewed by Darin Adler.
257
258         * WebCoreSupport/WebChromeClient.h:
259         * WebCoreSupport/WebChromeClient.mm:
260         (WebChromeClient::enterVideoFullscreenForVideoElement): Takes a reference.
261         (WebChromeClient::exitVideoFullscreenForVideoElement): Renamed from exitVideoFullscreen().
262         (WebChromeClient::exitVideoFullscreen): Deleted.
263
264 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
265
266         Re-enable custom dilation for antialiased fonts
267         https://bugs.webkit.org/show_bug.cgi?id=143738
268
269         Reviewed by Tim Horton.
270         
271         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
272         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
273         a private WebKit pref. This pref defaults to YES, enabling the feature by default
274         in WK1 as we do for WK2.
275
276         * WebView/WebPreferenceKeysPrivate.h:
277         * WebView/WebPreferences.mm:
278         (+[WebPreferences initialize]):
279         (-[WebPreferences setAntialiasedFontDilationEnabled:]):
280         (-[WebPreferences antialiasedFontDilationEnabled]):
281         * WebView/WebPreferencesPrivate.h:
282         * WebView/WebView.mm:
283         (-[WebView _preferencesChanged:]):
284
285 2015-04-13  Brady Eidson  <beidson@apple.com>
286
287         Share sheets from Share menus appear outside the browser window.
288         <rdar://problem/20455592> and https://bugs.webkit.org/show_bug.cgi?id=143620
289
290         Reviewed by Darin Adler.
291
292         Refactor existing Sharing Service Picker code to also be used for the Share menu NSMenuItem.
293
294         * Misc/WebSharingServicePickerController.h:
295         (WebSharingServicePickerClient::webView):
296         * Misc/WebSharingServicePickerController.mm:
297         (WebSharingServicePickerClient::WebSharingServicePickerClient):
298         (WebSharingServicePickerClient::sharingServicePickerWillBeDestroyed):
299         (WebSharingServicePickerClient::pageForSharingServicePicker):
300         (WebSharingServicePickerClient::windowForSharingServicePicker):
301         (WebSharingServicePickerClient::screenRectForCurrentSharingServicePickerItem):
302         (WebSharingServicePickerClient::imageForCurrentSharingServicePickerItem):
303         (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]):
304         (-[WebSharingServicePickerController initWithSharingServicePicker:client:]):
305         (-[WebSharingServicePickerController sharingService:didShareItems:]):
306
307         * WebCoreSupport/WebContextMenuClient.h:
308         (WebContextMenuClient::webView): Deleted.
309         * WebCoreSupport/WebContextMenuClient.mm:
310         (WebContextMenuClient::WebContextMenuClient):
311         (WebContextMenuClient::pageForSharingServicePicker): Deleted.
312         (WebContextMenuClient::windowForSharingServicePicker): Deleted.
313
314         * WebCoreSupport/WebSelectionServiceController.h:
315         * WebCoreSupport/WebSelectionServiceController.mm:
316         (WebSelectionServiceController::WebSelectionServiceController):
317         (WebSelectionServiceController::handleSelectionServiceClick):
318         (WebSelectionServiceController::pageForSharingServicePicker): Deleted.
319         (WebSelectionServiceController::windowForSharingServicePicker): Deleted.
320         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem): Deleted.
321         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem): Deleted.
322
323         * WebView/WebHTMLView.mm:
324         (-[WebHTMLView menuForEvent:]):
325         * WebView/WebViewData.h:
326
327 2015-04-13  Beth Dakin  <bdakin@apple.com>
328
329         Add force property to MouseEvents
330         https://bugs.webkit.org/show_bug.cgi?id=143569
331         -and corresponding-
332         rdar://problem/20472954
333
334         Reviewed by Darin Adler.
335
336         PlatformMouseEvent and MouseEvent now take force parameters.
337         * WebView/WebFrame.mm:
338         (-[WebFrame _dragSourceEndedAt:operation:]):
339         * WebView/WebPDFView.mm:
340         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
341
342 2015-04-12  Darin Adler  <darin@apple.com>
343
344         [Cocoa] Localizable strings are inconsistent and need to be regenerated
345         https://bugs.webkit.org/show_bug.cgi?id=143661
346         rdar://problem/19634388
347
348         Reviewed by Dan Bernstein.
349
350         * Misc/WebLocalizableStrings.mm:
351         (LoadWebLocalizedStringsTimerCallback): Moved the comment, useful for programmers but
352         not for localization, into a C++ source code comment, and made the localizer comment
353         consistent with the place this localizable string is used for actual localization.
354         * WebCoreSupport/WebEditorClient.mm:
355         (undoNameForEditAction): Changed the localizer comments for Delete and Dictation
356         to match the ones in WebKit2; no need to specify that these are iOS only, and if we do
357         want to specify that, we should not be using the term PLATFORM(IOS) since there is no
358         reason for us to expect localizers to understand that terminology. Also added a comment
359         about the fact that we have two copies of all the localizable strings.
360
361 2015-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
362
363         [ES6] Enable Symbol in web pages
364         https://bugs.webkit.org/show_bug.cgi?id=143375
365
366         Reviewed by Ryosuke Niwa.
367
368         * WebView/WebPreferencesPrivate.h:
369
370 2015-04-08  Sam Weinig  <sam@webkit.org>
371
372         Allow LaunchServices to handle URLs on link navigations
373         <rdar://problem/19446826>
374         https://bugs.webkit.org/show_bug.cgi?id=143544
375
376         Reviewed by Anders Carlsson.
377
378         * Configurations/WebKitLegacy.xcconfig:
379         Link MobileCoreServices.
380
381         * WebCoreSupport/WebFrameLoaderClient.h:
382         * WebCoreSupport/WebFrameLoaderClient.mm:
383         (shouldTryAppLink):
384         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
385         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
386         (WebFrameLoaderClient::setUpPolicyListener):
387         Only let LaunchServices have a crack at the URL if the navigation is:
388             1) a main frame navigation
389             2) a result of a user gesture
390
391 2015-04-10  Alexey Proskuryakov  <ap@apple.com>
392
393         Build fix.
394
395         * Misc/WebNSURLExtras.mm: (-[NSString _webkit_unescapedQueryValue]): Ignore a deprecation.
396
397 2015-04-10  Eric Carlson  <eric.carlson@apple.com>
398
399         [Mac] Refactor MediaPlaybackTarget
400         https://bugs.webkit.org/show_bug.cgi?id=143571
401
402         Reviewed by Jer Noble.
403
404         * WebView/WebMediaPlaybackTargetPicker.h:
405         * WebView/WebMediaPlaybackTargetPicker.mm:
406         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Take a Ref<MediaPlaybackTarget>&&.
407
408 2015-04-09  Andy Estes  <aestes@apple.com>
409
410         [Cocoa] Add a HAVE(AVKIT) and use it
411         https://bugs.webkit.org/show_bug.cgi?id=143593
412
413         Reviewed by David Kilzer.
414
415         * WebView/WebPreferences.mm:
416         (+[WebPreferences initialize]): Only set WebKitAVKitEnabled to YES if HAVE(AVKIT).
417         (-[WebPreferences setAVKitEnabled:]): Only set value for WebKitAVKitEnabled if HAVE(AVKIT).
418         * WebView/WebView.mm:
419         (-[WebView _preferencesChanged:]): Only called Settings::setAVKitEnabled() if HAVE(AVKIT).
420
421 2015-04-09  Chris Dumez  <cdumez@apple.com>
422
423         [WK2][iOS] editorState() should not cause a synchronous layout
424         https://bugs.webkit.org/show_bug.cgi?id=142536
425         <rdar://problem/20041506>
426
427         Reviewed by Enrica Casucci.
428
429         Provide implementation for EditorClient::didChangeSelectionAndUpdateLayout().
430
431         * WebCoreSupport/WebEditorClient.h:
432
433 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
434
435         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
436         https://bugs.webkit.org/show_bug.cgi?id=143452
437         <rdar://problem/20437483>
438
439         Reviewed by Tim Horton.
440
441         We were improperly intercepting contextual menu clicks and passing them through
442         the mouseDown handler, rather than processing via NSView's menu handling code.
443
444         * WebView/WebHTMLView.mm:
445         (-[WebHTMLView otherMouseDown:]): Treat context menu events the same as the action
446         menu case, and pass it to AppKit for normal menu processing. 
447
448 2015-04-08  Brady Eidson  <beidson@apple.com>
449
450         Expose the "Share" menu for links, images, and media.
451         <rdar://problem/20435340> and https://bugs.webkit.org/show_bug.cgi?id=143502
452
453         Reviewed by Tim Horton.
454
455         * WebCoreSupport/WebContextMenuClient.h:
456         * WebCoreSupport/WebContextMenuClient.mm:
457         (WebContextMenuClient::shareMenuItem): 
458
459 2015-04-08  Anders Carlsson  <andersca@apple.com>
460
461         Move some ApplicationCache static member functions to ApplicationCacheStorage
462         https://bugs.webkit.org/show_bug.cgi?id=143524
463
464         Reviewed by Antti Koivisto.
465
466         * WebCoreSupport/WebApplicationCache.mm:
467         (+[WebApplicationCache diskUsageForOrigin:]):
468         (+[WebApplicationCache deleteAllApplicationCaches]):
469         (+[WebApplicationCache deleteCacheForOrigin:]):
470
471 2015-04-08  Chris Dumez  <cdumez@apple.com>
472
473         Rename ActiveDOMObject::canSuspend() to canSuspendForPageCache() for clarity
474         https://bugs.webkit.org/show_bug.cgi?id=143513
475
476         Reviewed by Andreas Kling.
477
478         Update ScriptExecutionContext::canSuspendActiveDOMObjects() to
479         canSuspendActiveDOMObjectsForPageCache() as the method was renamed.
480
481         * WebView/WebFrame.mm:
482         (-[WebFrame _cacheabilityDictionary]):
483
484 2015-04-07  Anders Carlsson  <andersca@apple.com>
485
486         Get rid of uses of ApplicationCacheStorage::singleton() from WebKitLegacy
487         https://bugs.webkit.org/show_bug.cgi?id=143504
488
489         Reviewed by Sam Weinig.
490
491         Add a webApplicationCacheStorage() function and use it throughout WebKitLegacy.
492         In the future, webApplicationCacheStorage will return a custom singleton, but for now
493         it just returns ApplicationCacheStorage::singleton().
494
495         * Misc/WebCache.mm:
496         (+[WebCache empty]):
497         * WebCoreSupport/WebApplicationCache.mm:
498         (+[WebApplicationCache maximumSize]):
499         (+[WebApplicationCache setMaximumSize:]):
500         (+[WebApplicationCache defaultOriginQuota]):
501         (+[WebApplicationCache setDefaultOriginQuota:]):
502         (+[WebApplicationCache originsWithCache]):
503         (webApplicationCacheStorage):
504         * WebCoreSupport/WebApplicationCacheInternal.h: Added.
505         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
506         (-[WebApplicationCacheQuotaManager usage]):
507         (-[WebApplicationCacheQuotaManager quota]):
508         (-[WebApplicationCacheQuotaManager setQuota:]):
509         * WebView/WebView.mm:
510         (WebKitInitializeApplicationCachePathIfNecessary):
511
512 2015-04-07  Brady Eidson  <beidson@apple.com>
513
514         ContextMenuItem refactoring
515         https://bugs.webkit.org/show_bug.cgi?id=143485
516
517         Reviewed by Beth Dakin.
518
519         * WebCoreSupport/WebContextMenuClient.mm:
520         (WebContextMenuClient::contextMenuItemSelected):
521
522 2015-04-06  Chris Dumez  <cdumez@apple.com>
523
524         Bing video search result pages are not PageCacheable
525         https://bugs.webkit.org/show_bug.cgi?id=143463
526         <rdar://problem/20440916>
527
528         Reviewed by Alexey Proskuryakov.
529
530         Fix the iOS / WK1 build by using MemoryCache::resourceForRequest()
531         instead of resourceForUrl().
532
533         * Misc/WebCache.mm:
534         (+[WebCache imageForURL:]):
535
536 2015-04-05  Simon Fraser  <simon.fraser@apple.com>
537
538         Remove "go ahead and" from comments
539         https://bugs.webkit.org/show_bug.cgi?id=143421
540
541         Reviewed by Darin Adler, Benjamin Poulain.
542
543         Remove the phrase "go ahead and" from comments where it doesn't add
544         anything (which is almost all of them).
545
546         * WebView/WebDynamicScrollBarsView.mm:
547         (-[WebDynamicScrollBarsView updateScrollers]):
548         * WebView/WebHTMLView.mm:
549         (-[WebHTMLView insertText:]):
550
551 2015-04-02  Brady Eidson  <beidson@apple.com>
552
553         Unreviewed: Reland change after rollout.
554
555         Expose the "Share" menu for text selections on platforms where it's available.
556         rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
557
558         * WebView/WebImmediateActionController.mm: Update for required #include
559
560 2015-04-02  Commit Queue  <commit-queue@webkit.org>
561
562         Unreviewed, rolling out r182293.
563         https://bugs.webkit.org/show_bug.cgi?id=143355
564
565         Broke GTK and EFL builds. (Requested by bfulgham on #webkit).
566
567         Reverted changeset:
568
569         "Expose the "Share" menu for text selections on platforms
570         where it's available."
571         https://bugs.webkit.org/show_bug.cgi?id=143318
572         http://trac.webkit.org/changeset/182293
573
574 2015-04-02  Brady Eidson  <beidson@apple.com>
575
576         Expose the "Share" menu for text selections on platforms where it's available.
577         rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
578
579         Reviewed by Sam Weinig.
580
581         * WebView/WebImmediateActionController.mm: Update for required #include
582
583 2015-04-02  Yusuke Suzuki  <utatane.tea@gmail.com>
584
585         Clean up EnumerationMode to easily extend
586         https://bugs.webkit.org/show_bug.cgi?id=143276
587
588         Reviewed by Geoffrey Garen.
589
590         Use default EnumerationMode().
591
592         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
593         (WebKit::NetscapePluginInstanceProxy::enumerate):
594
595 2015-03-31  Simon Fraser  <simon.fraser@apple.com>
596
597         Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
598         https://bugs.webkit.org/show_bug.cgi?id=143288
599
600         Reviewed by Beth Dakin.
601
602         Remove the wheel event counting that Document does, and passes into the scrolling tree.
603         The ScrollingTree now just uses the non-fast scrollable region to determine when to
604         fast scroll on pages with wheel event handlers.
605
606         * WebCoreSupport/WebChromeClient.h:
607
608 2015-03-31  Timothy Horton  <timothy_horton@apple.com>
609
610         TextIndicator for <span> inside an <a> only highlights the <span>, should highlight the whole <a>
611         https://bugs.webkit.org/show_bug.cgi?id=143287
612         <rdar://problem/20318342>
613
614         Reviewed by Beth Dakin.
615
616         * WebView/WebImmediateActionController.mm:
617         (-[WebImmediateActionController _defaultAnimationController]):
618         Instead of just highlighting the hit element, highlight the whole
619         element that the link URL comes from.
620
621 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
622
623         Clean up Identifier factories to clarify the meaning of StringImpl*
624         https://bugs.webkit.org/show_bug.cgi?id=143146
625
626         Reviewed by Filip Pizlo.
627
628         Just change to Identifier::fromString.
629
630         * Plugins/Hosted/NetscapePluginHostProxy.mm:
631         (identifierFromIdentifierRep):
632         * Plugins/Hosted/ProxyInstance.mm:
633         (WebKit::ProxyInstance::getPropertyNames):
634
635 2015-03-28  Anders Carlsson  <andersca@apple.com>
636
637         Remove an unused SPI method from WebKitLegacy
638         https://bugs.webkit.org/show_bug.cgi?id=143185
639
640         Reviewed by Sam Weinig.
641
642         * WebView/WebDataSource.mm:
643         (-[WebDataSource _transferApplicationCache:]): Deleted.
644         * WebView/WebDataSourcePrivate.h:
645
646 2015-03-26  Alex Christensen  <achristensen@webkit.org>
647
648         Progress towards CMake on Mac.
649         https://bugs.webkit.org/show_bug.cgi?id=143112
650
651         Reviewed by Chris Dumez.
652
653         * WebCoreSupport/WebFrameLoaderClient.h:
654
655 2015-03-26  Ryosuke Niwa  <rniwa@webkit.org>
656
657         Cursor doesn't change back to pointer when leaving Mail
658         https://bugs.webkit.org/show_bug.cgi?id=132038
659
660         Reviewed by Anders Carlsson.
661
662         Fixed the bug by adding a cursor rect and making the primary tracking area update the cursor so that
663         AppKit will reset the cursor as it leaves the WebView.
664
665         We use nil cursor here since we manually update the cursor by calling [NSCursor set].
666
667         * WebView/WebHTMLView.mm:
668         (-[WebHTMLView setDataSource:]): Use NSTrackingCursorUpdate option in creating the primary tracking area.
669
670 2015-03-24  Anders Carlsson  <andersca@apple.com>
671
672         Fix designated initializer violations
673         https://bugs.webkit.org/show_bug.cgi?id=143016
674         rdar://problem/20268858
675
676         Reviewed by Dan Bernstein.
677
678         Move -[WebBackForwardList initWithBackForwardList:] to the implementation instead of a category since
679         nobody calls it outside of WebBackForwardList.mm.
680
681         * History/WebBackForwardList.mm:
682         * History/WebBackForwardListInternal.h:
683
684 2015-03-23  Alexey Proskuryakov  <ap@apple.com>
685
686         REGRESSION (Yosemite): WKView visibility notifications are messed up
687         https://bugs.webkit.org/show_bug.cgi?id=142945
688
689         Reviewed by Tim Horton.
690
691         As these notifications cannot be used by NSView subclasses, create a separate
692         object for observing them.
693
694         * WebView/WebView.mm:
695         (-[WebView _commonInitializationWithFrameName:groupName:]):
696         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
697         (-[WebView addWindowObserversForWindow:]):
698         (-[WebView removeWindowObservers]):
699         (-[WebView viewWillMoveToWindow:]): Make sure that observers are removed even
700         if -[WebView close] is called manually.
701         * WebView/WebViewData.h:
702         * WebView/WebViewData.mm:
703         (-[WebWindowVisibilityObserver initWithView:]):
704         (-[WebWindowVisibilityObserver startObserving:]):
705         (-[WebWindowVisibilityObserver stopObserving:]):
706         (-[WebWindowVisibilityObserver _windowVisibilityChanged:]):
707
708 2015-03-23  Tim Horton  <timothy_horton@apple.com>
709
710         Add a share item to the link action menu
711         https://bugs.webkit.org/show_bug.cgi?id=142961
712         <rdar://problem/19198374>
713
714         Reviewed by Beth Dakin.
715
716         * WebView/WebActionMenuController.mm:
717         (-[WebActionMenuController _defaultMenuItemsForImage]):
718         (-[WebActionMenuController _defaultMenuItemsForVideo]):
719         (-[WebActionMenuController _createActionMenuItemForTag:]):
720         (-[WebActionMenuController _createShareActionMenuItemForTag:withItems:]):
721         Adopt -[NSMenuItem standardShareMenuItemWithItems].
722         All of the null-checking is unnecessary as it's impossible to enter
723         these functions with a null image/etc.
724         Also, remove a duplicate isDownloadableMedia check for the 'save to downloads' item.
725
726         (-[WebActionMenuController _defaultMenuItemsForLink]):
727         * WebView/WebUIDelegatePrivate.h:
728         Add a 'Share' item to the link menu.
729
730 2015-03-22  Alexey Proskuryakov  <ap@apple.com>
731
732         Build fix.
733
734         * WebView/WebView.mm: (-[WebView _showPlaybackTargetPicker:hasVideo:]):
735
736 2015-03-22  Eric Carlson  <eric.carlson@apple.com>
737
738         [Mac] Enable WIRELESS_PLAYBACK_TARGET for WK1
739         https://bugs.webkit.org/show_bug.cgi?id=142940
740
741         Reviewed by Sam Weinig.
742
743         * WebCoreSupport/WebChromeClient.h:
744         * WebCoreSupport/WebChromeClient.mm:
745         (WebChromeClient::showPlaybackTargetPicker): New.
746         (WebChromeClient::startingMonitoringPlaybackTargets): New.
747         (WebChromeClient::stopMonitoringPlaybackTargets): New.
748
749         * WebView/WebView.mm:
750         (-[WebView _close]): Invalidate and free the target picker.
751         (-[WebView _devicePicker]): New.
752         (-[WebView _showPlaybackTargetPicker:hasVideo:]): New.
753         (-[WebView _startingMonitoringPlaybackTargets]): New.
754         (-[WebView _stopMonitoringPlaybackTargets]): New.
755
756         * WebView/WebMediaPlaybackTargetPicker.h:
757         * WebView/WebMediaPlaybackTargetPicker.mm:
758         (WebMediaPlaybackTargetPicker::create): New.
759         (WebMediaPlaybackTargetPicker::WebMediaPlaybackTargetPicker): New.
760         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): New.
761         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): New.
762         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): New.
763         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): New.
764         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange): New.
765         (WebMediaPlaybackTargetPicker::invalidate): New.
766         (WebMediaPlaybackTargetPicker::targetPicker): New.
767
768         * WebView/WebViewData.h:
769         (WebMediaPlaybackTargetPicker::~WebMediaPlaybackTargetPicker):
770         * WebView/WebViewData.mm:
771         * WebView/WebViewInternal.h:
772
773 2015-03-19  Andy Estes  <aestes@apple.com>
774
775         [Content Filtering] Add tests for unblock requests
776         https://bugs.webkit.org/show_bug.cgi?id=142900
777
778         Reviewed by Andreas Kling.
779
780         * WebCoreSupport/WebFrameLoaderClient.mm:
781         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): This now happens in PolicyChecker.
782         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
783         * WebView/WebFrame.mm:
784         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Deleted.
785         * WebView/WebFrameInternal.h: Removed contentFilterUnblockHandler from WebFramePrivate.
786
787 2015-03-19  Enrica Casucci  <enrica@apple.com>
788
789         <attachment> should put URLs on the pasteboard so that Finder can accept drops.
790         https://bugs.webkit.org/show_bug.cgi?id=142801
791         rdar://problem/19982527
792
793         Reviewed by Tim Horton.
794
795         This patch adds all the necessary support to write attachment elements into
796         the pasteboard, including the promised type in WK1.
797
798         * Misc/WebNSPasteboardExtras.mm:
799         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
800         * WebCoreSupport/WebDragClient.h:
801         * WebCoreSupport/WebDragClient.mm:
802         (WebDragClient::declareAndWriteAttachment):
803         * WebView/WebHTMLView.mm:
804         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
805         * WebView/WebUIDelegate.h:
806
807 2015-03-19  Chris Dumez  <cdumez@apple.com>
808
809         Clean up DOMTimer related settings
810         https://bugs.webkit.org/show_bug.cgi?id=142837
811
812         Reviewed by Darin Adler.
813
814         Stop setting the DOMTimers' default minimum interval to 4ms as this
815         is now the default.
816
817         * WebView/WebView.mm:
818         (-[WebView _commonInitializationWithFrameName:groupName:]):
819
820 2015-03-17  Conrad Shultz  <conrad_shultz@apple.com>
821
822         Ignore some deprecation warnings
823         https://bugs.webkit.org/show_bug.cgi?id=142813
824
825         Reviewed by Mark Rowe.
826
827         Fixing the deprecations is tracked by: <rdar://problem/20201450>
828
829         * WebCoreSupport/PopupMenuMac.mm:
830         (PopupMenuMac::populate):
831
832 2015-03-17  Tim Horton  <timothy_horton@apple.com>
833
834         Cannot invoke action menus anymore
835         https://bugs.webkit.org/show_bug.cgi?id=142797
836         <rdar://problem/20032670>
837
838         * WebView/WebHTMLView.mm:
839         (-[WebHTMLView otherMouseDown:]):
840         Need a respondsToSelector check.
841
842 2015-03-17  Tim Horton  <timothy_horton@apple.com>
843
844         Fix the iOS build
845
846         * WebView/WebHTMLView.mm:
847
848 2015-03-17  Tim Horton  <timothy_horton@apple.com>
849
850         Cannot invoke action menus anymore
851         https://bugs.webkit.org/show_bug.cgi?id=142797
852         <rdar://problem/20032670>
853
854         Reviewed by Beth Dakin.
855
856         * WebView/WebHTMLView.mm:
857         (-[WebHTMLView otherMouseDown:]):
858         Don't override otherMouseDown: if the event would make an action menu.
859
860 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
861
862         Enable ES6 classes by default
863         https://bugs.webkit.org/show_bug.cgi?id=142774
864
865         Reviewed by Gavin Barraclough.
866
867         * Configurations/FeatureDefines.xcconfig:
868
869 2015-03-16  Brent Fulgham  <bfulgham@apple.com>
870
871         WebKit1 Clients Are Not Reliably Repainted
872         https://bugs.webkit.org/show_bug.cgi?id=142750
873         <rdar://problem/20042453>
874
875         Reviewed by Simon Fraser.
876
877         Check with the FrameView to see if we are in an immediately paintable state. If we are not,
878         mark the view as dirty once the _immediateScrollToPoint operation is complete so that the
879         region will be painted properly.
880
881         * WebView/WebClipView.mm:
882         (-[WebClipView _immediateScrollToPoint:]): 
883
884 2015-03-16  Conrad Shultz  <conrad_shultz@apple.com>
885
886         Allow clients to selectively disable plug-ins
887         https://bugs.webkit.org/show_bug.cgi?id=142506
888
889         Reviewed by Anders Carlsson.
890
891         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
892         from the page). As part of this:
893
894         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
895            set of plug-ins.
896
897         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
898            down the stack.
899
900         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
901            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
902
903         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
904
905         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
906         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
907
908         * Plugins/WebBasePluginPackage.mm:
909         (-[WebBasePluginPackage getPluginInfoFromPLists]):
910         Set new members in PluginInfo.
911
912         * Plugins/WebNetscapePluginPackage.mm:
913         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
914         Set new members in PluginInfo.
915
916         * WebCoreSupport/WebPlatformStrategies.h:
917         * WebCoreSupport/WebPlatformStrategies.mm:
918         (WebPlatformStrategies::getWebVisiblePluginInfo):
919         Override to wrap getPluginInfo().
920         (WebPlatformStrategies::setPluginLoadClientPolicy):
921         Override to do nothing.
922         (WebPlatformStrategies::clearPluginClientPolicies):
923         Ditto.
924
925         * WebView/WebFrame.mm:
926         (-[WebFrame _canProvideDocumentSource]):
927         Update to reflect function rename.
928
929 2015-03-14  Dean Jackson  <dino@apple.com>
930
931         Feature flag for Animations Level 2
932         https://bugs.webkit.org/show_bug.cgi?id=142699
933         <rdar://problem/20165097>
934
935         Reviewed by Brent Fulgham.
936
937         Add ENABLE_CSS_ANIMATIONS_LEVEL_2 and a runtime flag animationTriggersEnabled.
938
939         * Configurations/FeatureDefines.xcconfig:
940
941 2015-03-13  Commit Queue  <commit-queue@webkit.org>
942
943         Unreviewed, rolling out r181483.
944         https://bugs.webkit.org/show_bug.cgi?id=142688
945
946         Caused use-after-free on many tests (Requested by ap on
947         #webkit).
948
949         Reverted changeset:
950
951         "Allow clients to selectively disable plug-ins"
952         https://bugs.webkit.org/show_bug.cgi?id=142506
953         http://trac.webkit.org/changeset/181483
954
955 2015-03-13  Eric Carlson  <eric.carlson@apple.com>
956
957         [Mac] Enable WIRELESS_PLAYBACK_TARGET
958         https://bugs.webkit.org/show_bug.cgi?id=142635
959
960         Reviewed by Darin Adler.
961
962         * Configurations/FeatureDefines.xcconfig:
963
964 2015-03-10  Conrad Shultz  <conrad_shultz@apple.com>
965
966         Allow clients to selectively disable plug-ins
967         https://bugs.webkit.org/show_bug.cgi?id=142506
968
969         Reviewed by Anders Carlsson.
970
971         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
972         from the page). As part of this:
973
974         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
975            set of plug-ins.
976
977         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
978            down the stack.
979
980         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
981            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
982
983         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
984
985         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
986         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
987
988         * Plugins/WebBasePluginPackage.mm:
989         (-[WebBasePluginPackage getPluginInfoFromPLists]):
990         Set new members in PluginInfo.
991
992         * Plugins/WebNetscapePluginPackage.mm:
993         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
994         Set new members in PluginInfo.
995
996         * WebCoreSupport/WebPlatformStrategies.h:
997         * WebCoreSupport/WebPlatformStrategies.mm:
998         (WebPlatformStrategies::getWebVisiblePluginInfo):
999         Override to wrap getPluginInfo().
1000         (WebPlatformStrategies::setPluginLoadClientPolicy):
1001         Override to do nothing.
1002         (WebPlatformStrategies::clearPluginClientPolicies):
1003         Ditto.
1004
1005         * WebView/WebFrame.mm:
1006         (-[WebFrame _canProvideDocumentSource]):
1007         Update to reflect function rename.
1008
1009 2015-03-10  Sam Weinig  <sam@webkit.org>
1010
1011         Allow adding a button in input elements for auto fill related functionality
1012         <rdar://problem/19782066>
1013         https://bugs.webkit.org/show_bug.cgi?id=142564
1014
1015         Reviewed by Anders Carlsson.
1016
1017         * DOM/WebDOMOperations.mm:
1018         (-[DOMHTMLInputElement _setAutofilled:]):
1019         Update for consistent spelling of AutoFill.
1020
1021 2015-03-10  Timothy Horton  <timothy_horton@apple.com>
1022
1023         Fix the build
1024
1025         * History/WebHistory.mm:
1026         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1027         * WebCoreSupport/WebFrameLoaderClient.mm:
1028         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1029
1030 2015-03-10  Tim Horton  <timothy_horton@apple.com>
1031
1032         Fix the Mac build with a newer compiler
1033
1034         * Plugins/WebPluginController.mm:
1035         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1036         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1037
1038 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1039
1040         [iOS] Fix build when compiling with dead code stripping disabled
1041         <http://webkit.org/b/142467>
1042
1043         Reviewed by Simon Fraser.
1044
1045         * Configurations/WebKitLegacy.xcconfig:
1046         (EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code
1047         generation and compilation for out-of-process plugin support.
1048         This was never used on iOS.
1049
1050 2015-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
1051
1052         [iOS] SVG fonts are garbled
1053         https://bugs.webkit.org/show_bug.cgi?id=142377
1054
1055         Reviewed by Simon Fraser.
1056
1057         * Configurations/FeatureDefines.xcconfig:
1058
1059 2015-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1060
1061         Hide Promise with runtime flags under Cocoa JSContext API
1062         https://bugs.webkit.org/show_bug.cgi?id=141965
1063
1064         Reviewed by Filip Pizlo.
1065
1066         Add new JSC runtime flag, PromiseDisabled.
1067
1068         * WebView/WebPreferencesPrivate.h:
1069
1070 2015-03-03  Andy Estes  <aestes@apple.com>
1071
1072         [Content Filtering] Separate unblock handling into its own class
1073         https://bugs.webkit.org/show_bug.cgi?id=142251
1074
1075         Reviewed by Andreas Kling.
1076         
1077         Adopted ContentFilterUnblockHandler.
1078
1079         * WebCoreSupport/WebFrameLoaderClient.h:
1080         * WebCoreSupport/WebFrameLoaderClient.mm:
1081         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1082         * WebView/WebFrame.mm:
1083         (-[WebFrame _contentFilterDidHandleNavigationAction:]):
1084         * WebView/WebFrameInternal.h:
1085
1086 2015-03-03  Chris Dumez  <cdumez@apple.com>
1087
1088         Access ApplicationCacheStorage global instance via singleton() static member function
1089         https://bugs.webkit.org/show_bug.cgi?id=142239
1090
1091         Reviewed by Anders Carlsson.
1092
1093         Access ApplicationCacheStorage global instance via singleton() static
1094         member function as per WebKit coding style.
1095
1096 2015-03-02  Jer Noble  <jer.noble@apple.com>
1097
1098         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1099         https://bugs.webkit.org/show_bug.cgi?id=142121
1100
1101         Reviewed by Simon Fraser.
1102
1103         Fullscreening a page with a non-1 scale would result in that scale being applied to the
1104         fullscreen content, breaking fullscreen mode. Set the page scale to 1 when entering
1105         fullscreen and reset it to the original value when exiting fullscreen.
1106
1107         * WebView/WebFullScreenController.h:
1108         * WebView/WebFullScreenController.mm:
1109         (-[WebFullScreenController enterFullScreen:]): Set the page scale to 1.
1110         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Reset the page
1111                 scale to the original value.
1112         * WebView/WebView.mm:
1113         (-[WebView _supportsFullScreenForElement:withKeyboard:]): Drive-by fix. Check the
1114                 WebView's own preferences to see if fullscreen mode is enabled, rather than
1115                 the global object's.
1116
1117 2015-03-01  Chris Dumez  <cdumez@apple.com>
1118
1119         Make NotificationCenter / Notification suspendable
1120         https://bugs.webkit.org/show_bug.cgi?id=142117
1121         <rdar://problem/19923085>
1122
1123         Reviewed by Andreas Kling.
1124
1125         Provide implementation for NotificationClient::hasPendingPermissionRequests().
1126         The implementation is very simplistic. it will only return false if no
1127         request for permission for ever made. This is because there is currently no
1128         easy way to figure out if a permission request is pending or not.
1129
1130         * WebCoreSupport/WebNotificationClient.h:
1131         * WebCoreSupport/WebNotificationClient.mm:
1132         (WebNotificationClient::requestPermission):
1133         (WebNotificationClient::hasPendingPermissionRequests):
1134
1135 2015-02-28  Simon Fraser  <simon.fraser@apple.com>
1136
1137         Viewport units should not dirty style just before we do layout
1138         https://bugs.webkit.org/show_bug.cgi?id=141682
1139
1140         Reviewed by Zalan Bujtas.
1141
1142         * WebView/WebFrameView.mm:
1143         (-[WebFrameView _frameSizeChanged]):
1144
1145 2015-02-26  Chris Dumez  <cdumez@apple.com>
1146
1147         Rename DatabaseManager::manager() to DatabaseManager::singleton()
1148         https://bugs.webkit.org/show_bug.cgi?id=142054
1149
1150         Reviewed by Ryosuke Niwa.
1151
1152         Rename DatabaseManager::manager() to DatabaseManager::singleton() as
1153         per coding style and use WTF::NeverDestroyed.
1154
1155         * Storage/WebDatabaseManager.mm:
1156         (-[WebDatabaseManager init]):
1157         (-[WebDatabaseManager origins]):
1158         (-[WebDatabaseManager databasesWithOrigin:]):
1159         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
1160         (-[WebDatabaseManager deleteAllDatabases]):
1161         (-[WebDatabaseManager deleteOrigin:]):
1162         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1163         * Storage/WebDatabaseQuotaManager.mm:
1164         (-[WebDatabaseQuotaManager usage]):
1165         (-[WebDatabaseQuotaManager quota]):
1166         (-[WebDatabaseQuotaManager setQuota:]):
1167         * WebCoreSupport/WebSecurityOrigin.mm:
1168         (-[WebSecurityOrigin usage]):
1169         (-[WebSecurityOrigin quota]):
1170         (-[WebSecurityOrigin setQuota:]):
1171         * WebView/WebFrame.mm:
1172         (-[WebFrame _cacheabilityDictionary]):
1173         * WebView/WebView.mm:
1174         (-[WebView _preferencesChanged:]):
1175
1176 2015-02-26  Myles C. Maxfield  <mmaxfield@apple.com>
1177
1178         [Mac] [iOS] Parsing support for -apple-trailing-word
1179         https://bugs.webkit.org/show_bug.cgi?id=141939
1180
1181         Reviewed by Andreas Kling.
1182
1183         * Configurations/FeatureDefines.xcconfig:
1184
1185 2015-02-24  Commit Queue  <commit-queue@webkit.org>
1186
1187         Unreviewed, rolling out r180599.
1188         https://bugs.webkit.org/show_bug.cgi?id=141998
1189
1190         Lots of new test failures (Requested by smfr on #webkit).
1191
1192         Reverted changeset:
1193
1194         "Parsing support for -webkit-trailing-word"
1195         https://bugs.webkit.org/show_bug.cgi?id=141939
1196         http://trac.webkit.org/changeset/180599
1197
1198 2015-02-24  Myles C. Maxfield  <mmaxfield@apple.com>
1199
1200         [Mac] [iOS] Parsing support for -apple-trailing-word
1201         https://bugs.webkit.org/show_bug.cgi?id=141939
1202
1203         Reviewed by Andreas Kling.
1204
1205         * Configurations/FeatureDefines.xcconfig:
1206
1207 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1208
1209         REGRESSION(r179429): Can't type comments in Facebook
1210         https://bugs.webkit.org/show_bug.cgi?id=141859
1211
1212         Reviewed by Brent Fulgham.
1213
1214         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1215         Private API, javaScriptExperimentsEnabled is dropped.
1216
1217         * Misc/WebNSDictionaryExtras.h:
1218         * Misc/WebNSDictionaryExtras.m:
1219         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1220         * WebKit.order:
1221         * WebView/WebPreferenceKeysPrivate.h:
1222         * WebView/WebPreferences.mm:
1223         (+[WebPreferences initialize]):
1224         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1225         (-[WebPreferences javaScriptRuntimeFlags]):
1226         (-[WebPreferences setJavaScriptRuntimeFlags:]):
1227         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1228         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1229         * WebView/WebPreferencesPrivate.h:
1230         * WebView/WebView.mm:
1231         (-[WebView _preferencesChanged:]):
1232
1233 2015-02-23  Commit Queue  <commit-queue@webkit.org>
1234
1235         Unreviewed, rolling out r180547 and r180550.
1236         https://bugs.webkit.org/show_bug.cgi?id=141957
1237
1238         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1239
1240         Reverted changesets:
1241
1242         "REGRESSION(r179429): Can't type comments in Facebook"
1243         https://bugs.webkit.org/show_bug.cgi?id=141859
1244         http://trac.webkit.org/changeset/180547
1245
1246         "Constructor returning null should construct an object instead
1247         of null"
1248         https://bugs.webkit.org/show_bug.cgi?id=141640
1249         http://trac.webkit.org/changeset/180550
1250
1251 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1252
1253         Disable font loading events until our implementation gets updated to match the latest spec
1254         https://bugs.webkit.org/show_bug.cgi?id=141938
1255
1256         Reviewed by Andreas Kling.
1257
1258         * Configurations/FeatureDefines.xcconfig:
1259
1260 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1261
1262         REGRESSION(r179429): Can't type comments in Facebook
1263         https://bugs.webkit.org/show_bug.cgi?id=141859
1264
1265         Reviewed by Geoffrey Garen.
1266
1267         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1268         Private API, javaScriptExperimentsEnabled is dropped.
1269
1270         * Misc/WebNSDictionaryExtras.h:
1271         * Misc/WebNSDictionaryExtras.m:
1272         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1273         * WebKit.order:
1274         * WebView/WebPreferenceKeysPrivate.h:
1275         * WebView/WebPreferences.mm:
1276         (+[WebPreferences initialize]):
1277         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1278         (-[WebPreferences javaScriptRuntimeFlags]):
1279         (-[WebPreferences setJavaScriptRuntimeFlags:]):
1280         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1281         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1282         * WebView/WebPreferencesPrivate.h:
1283         * WebView/WebView.mm:
1284         (-[WebView _preferencesChanged:]):
1285
1286 2015-02-20  Eric Carlson  <eric.carlson@apple.com>
1287
1288         [iOS] cleanup AirPlay code
1289         https://bugs.webkit.org/show_bug.cgi?id=141811
1290
1291         Reviewed by Jer Noble.
1292
1293         * Configurations/FeatureDefines.xcconfig: IOS_AIRPLAY -> WIRELESS_PLAYBACK_TARGET.
1294
1295 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
1296
1297         Adopt WebCore::IOSurface in ImageBuffer
1298         https://bugs.webkit.org/show_bug.cgi?id=141751
1299
1300         Reviewed by Simon Fraser.
1301
1302         * WebCoreSupport/WebSystemInterface.mm:
1303         (InitWebCoreSystemInterface):
1304         Remove old WKSI IOSurface-related functions.
1305
1306 2015-02-18  Commit Queue  <commit-queue@webkit.org>
1307
1308         Unreviewed, rolling out r180286.
1309         https://bugs.webkit.org/show_bug.cgi?id=141766
1310
1311         Caused >50 crashed LayoutTests (Requested by jernoble on
1312         #webkit).
1313
1314         Reverted changeset:
1315
1316         "Page::userContentController() should return a reference, not
1317         a pointer"
1318         https://bugs.webkit.org/show_bug.cgi?id=141764
1319         http://trac.webkit.org/changeset/180286
1320
1321 2015-02-18  Brady Eidson  <beidson@apple.com>
1322
1323         Page::userContentController() should return a reference, not a pointer
1324         https://bugs.webkit.org/show_bug.cgi?id=141764
1325
1326         Reviewed by Jer Noble.
1327
1328         * WebView/WebView.mm:
1329         (-[WebView setGroupName:]):
1330
1331 2015-02-18  Chris Dumez  <cdumez@apple.com>
1332
1333         Access FontCache global instance via singleton() static member function
1334         https://bugs.webkit.org/show_bug.cgi?id=141726
1335
1336         Reviewed by Daniel Bates.
1337
1338         Access FontCache global instance via singleton() static member function,
1339         as per coding style.
1340
1341 2015-02-17  Chris Dumez  <cdumez@apple.com>
1342
1343         Access MemoryPressureHandler global instance via a singleton() static member function
1344         https://bugs.webkit.org/show_bug.cgi?id=141691
1345
1346         Reviewed by Andreas Kling.
1347
1348         Access MemoryPressureHandler global instance via a singleton() static
1349         member function.
1350
1351         * WebView/WebView.mm:
1352         (-[WebView _commonInitializationWithFrameName:groupName:]):
1353         (+[WebView registerForMemoryNotifications]):
1354         (+[WebView _isUnderMemoryPressure]):
1355         (+[WebView _clearMemoryPressure]):
1356         (+[WebView _shouldWaitForMemoryClearMessage]):
1357         (WebInstallMemoryPressureHandler):
1358
1359 2015-02-15  Sam Weinig  <sam@webkit.org>
1360
1361         Add experimental <attachment> element support
1362         https://bugs.webkit.org/show_bug.cgi?id=141626
1363
1364         Reviewed by Tim Horton.
1365
1366         * Configurations/FeatureDefines.xcconfig:
1367
1368 2015-02-14  Joseph Pecoraro  <pecoraro@apple.com>
1369
1370         [Mac] Possible DDActionContext leaks, RetainPtr cleanup
1371         https://bugs.webkit.org/show_bug.cgi?id=141613
1372
1373         Reviewed by Tim Horton.
1374
1375         * WebCoreSupport/WebEditorClient.mm:
1376         (WebEditorClient::WebEditorClient):
1377         Avoid unnecessary retain/autorelease by adopting.
1378
1379         * WebView/WebActionMenuController.mm:
1380         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1381         Adopt the allocated object.
1382
1383 2015-02-09  Brian J. Burg  <burg@cs.washington.edu>
1384
1385         Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace
1386         https://bugs.webkit.org/show_bug.cgi?id=141372
1387
1388         Reviewed by Joseph Pecoraro.
1389
1390         * WebCoreSupport/WebInspectorClient.mm:
1391         (-[WebInspectorWindowController destroyInspectorView:]):
1392
1393 2015-02-14  Alexey Proskuryakov  <ap@apple.com>
1394
1395         rel="noreferrer" should make window.opener null
1396         https://bugs.webkit.org/show_bug.cgi?id=141579
1397
1398         Reviewed by Darin Adler.
1399
1400         * WebView/WebPDFView.mm:
1401         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore
1402         function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
1403
1404 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
1405
1406         [Streams API] Implement a barebone ReadableStream interface
1407         https://bugs.webkit.org/show_bug.cgi?id=141045
1408
1409         Reviewed by Benjamin Poulain.
1410
1411         * Configurations/FeatureDefines.xcconfig:
1412
1413 2015-02-03  Enrica Casucci  <enrica@apple.com>
1414
1415         [iOS] Add support for deleteFromInputWithFlags.
1416         https://bugs.webkit.org/show_bug.cgi?id=141216
1417         rdar://problem/19130081
1418
1419         Reviewed by Benjamin Poulain.
1420
1421         Adopts the new method as soon as it is available.
1422         The patch also removes some obsolete code used for staging.
1423
1424         * WebView/WebHTMLView.mm:
1425         (-[WebHTMLView _handleEditingKeyEvent:]):
1426
1427 2015-02-02  Chris Dumez  <cdumez@apple.com>
1428
1429         Access MemoryCache singleton using MemoryCache::singleton()
1430         https://bugs.webkit.org/show_bug.cgi?id=141104
1431
1432         Reviewed by Andreas Kling.
1433
1434         Access MemoryCache singleton using MemoryCache::singleton() static
1435         member function, instead of a free function, as per the recent
1436         coding style discussion on WebKit-dev.
1437
1438 2015-02-01  Chris Dumez  <cdumez@apple.com>
1439
1440         Use more references in HistoryItem
1441         https://bugs.webkit.org/show_bug.cgi?id=141133
1442
1443         Reviewed by Andreas Kling.
1444
1445         Use more references in HistoryItem instead of pointers.
1446
1447 2015-01-31  Sam Weinig  <sam@webkit.org>
1448
1449         Remove even more Mountain Lion support
1450         https://bugs.webkit.org/show_bug.cgi?id=141124
1451
1452         Reviewed by Alexey Proskuryakov.
1453
1454         * Configurations/Base.xcconfig:
1455         * Configurations/DebugRelease.xcconfig:
1456         * Configurations/FeatureDefines.xcconfig:
1457         * Configurations/Version.xcconfig:
1458         * Configurations/WebKitLegacy.xcconfig:
1459
1460 2015-01-30  Eric Carlson  <eric.carlson@apple.com>
1461
1462         Remove MediaPlayerProxy.h
1463         https://bugs.webkit.org/show_bug.cgi?id=141087
1464
1465         Reviewed by Sam Weinig.
1466
1467         * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h.
1468         * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h.
1469
1470 2015-01-30  Chris Dumez  <cdumez@apple.com>
1471
1472         Rename shared() static member functions to singleton() for singleton classes.
1473         https://bugs.webkit.org/show_bug.cgi?id=141088
1474
1475         Reviewed by Ryosuke Niwa and Benjamin Poulain.
1476
1477         Rename shared() static member functions to singleton() for singleton
1478         classes as per the recent coding style change.
1479
1480 2015-01-29  Beth Dakin  <bdakin@apple.com>
1481
1482         Remove more Mountain Lion code from WebKit
1483         https://bugs.webkit.org/show_bug.cgi?id=141050
1484
1485         Reviewed by Anders Carlsson.
1486
1487         * History/WebHistory.mm:
1488         (getDayBoundaries):
1489         * Panels/WebAuthenticationPanel.m:
1490         (-[WebAuthenticationPanel cancel:]):
1491         (-[WebAuthenticationPanel logIn:]):
1492         (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]):
1493         * WebCoreSupport/WebSystemInterface.mm:
1494         (InitWebCoreSystemInterface):
1495         * WebView/WebFrameView.mm:
1496         * WebView/WebPreferences.mm:
1497         (+[WebPreferences initialize]):
1498         (needsScreenFontsEnabledQuirk):
1499         * WebView/WebView.mm:
1500         (+[WebView registerForMemoryNotifications]):
1501         (-[WebView _preferencesChanged:]):
1502         (+[WebView initialize]):
1503         (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
1504         (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
1505         (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):
1506
1507 2015-01-29  Sam Weinig  <sam@webkit.org>
1508
1509         Remove support for screen font substitution
1510         https://bugs.webkit.org/show_bug.cgi?id=141038
1511
1512         Reviewed by Tim Horton.
1513
1514         * Misc/WebKitNSStringExtras.mm:
1515         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1516         (-[NSString _web_widthWithFont:]):
1517         * Misc/WebStringTruncator.mm:
1518         (fontFromNSFont):
1519         Update for new signature of the FontPlatformData constructor, which no longer cares about
1520         whether to use printer fonts.
1521
1522         * WebView/WebPreferenceKeysPrivate.h:
1523         Remove the WebKitScreenFontSubstitutionEnabledKey key.
1524
1525         * WebView/WebPreferences.mm:
1526         (+[WebPreferences initialize]):
1527         Remove support for WebKitScreenFontSubstitutionEnabledKey.
1528
1529         (needsScreenFontsEnabledQuirk): Deleted.
1530         Remove support for the Mountain Lion era 1-Password quirk.
1531
1532         (-[WebPreferences screenFontSubstitutionEnabled]): Deleted.
1533         (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted.
1534         * WebView/WebPreferencesPrivate.h:
1535         * WebView/WebView.mm:
1536         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1537         (-[WebView _preferencesChanged:]):
1538         Remove support for the screen font substitution setting.
1539
1540 2015-01-29  Chris Dumez  <cdumez@apple.com>
1541
1542         Clean up / modernize PageCache class
1543         https://bugs.webkit.org/show_bug.cgi?id=141009
1544
1545         Reviewed by Darin Adler.
1546
1547         Clean up / modernize PageCache class.
1548
1549         * History/WebBackForwardList.mm:
1550         (-[WebBackForwardList pageCacheSize]):
1551         * WebView/WebView.mm:
1552         (-[WebView _loadBackForwardListFromOtherView:]):
1553         (-[WebView goToBackForwardItem:]):
1554         (+[WebView _setCacheModel:]):
1555
1556 2015-01-28  Beth Dakin  <bdakin@apple.com>
1557
1558         Remove Mountain Lion code from WebKit and WebKit2
1559         https://bugs.webkit.org/show_bug.cgi?id=141010
1560
1561         Reviewed by Sam Weinig.
1562
1563         * DOM/WebDOMOperations.mm:
1564         (toNSEventPhase):
1565         * WebView/WebHTMLView.mm:
1566         (isQuickLookEvent):
1567
1568 2015-01-28  Dana Burkart  <dburkart@apple.com>
1569
1570         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1571         https://bugs.webkit.org/show_bug.cgi?id=136765
1572
1573         Reviewed by Alexey Proskuryakov.
1574
1575         * Configurations/Base.xcconfig:
1576         * Configurations/DebugRelease.xcconfig:
1577
1578 2015-01-28  Chris Dumez  <cdumez@apple.com>
1579
1580         Fix typo in markPagesForVistedLinkStyleRecalc()
1581         https://bugs.webkit.org/show_bug.cgi?id=140977
1582
1583         Reviewed by Darin Adler.
1584
1585         * WebCoreSupport/WebVisitedLinkStore.mm:
1586         (WebVisitedLinkStore::removeAllVisitedLinks):
1587         (WebVisitedLinkStore::removeVisitedLink):
1588         (WebVisitedLinkStore::addVisitedLinkHash):
1589
1590 2015-01-28  Chris Dumez  <cdumez@apple.com>
1591
1592         Rename pageCache() to PageCache::shared() and return a reference
1593         https://bugs.webkit.org/show_bug.cgi?id=140983
1594
1595         Reviewed by Andreas Kling.
1596
1597         Rename pageCache() to PageCache::shared() as this is a singleton class
1598         and have it return a reference instead of a pointer.
1599
1600         * History/WebBackForwardList.mm:
1601         (-[WebBackForwardList pageCacheSize]):
1602         * Misc/WebCoreStatistics.mm:
1603         (+[WebCoreStatistics cachedPageCount]):
1604         (+[WebCoreStatistics cachedFrameCount]):
1605         * WebCoreSupport/WebVisitedLinkStore.mm:
1606         (WebVisitedLinkStore::removeAllVisitedLinks):
1607         (WebVisitedLinkStore::removeVisitedLink):
1608         (WebVisitedLinkStore::addVisitedLinkHash):
1609         * WebView/WebView.mm:
1610         (+[WebView _setCacheModel:]):
1611
1612 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1613
1614         More build fixes for newer clang.
1615
1616         Rubber-stamped by Anders Carlsson.
1617
1618         Marked a deprecated accessibility method as such.
1619
1620         * WebView/WebFrame.mm:
1621         (-[WebFrame accessibilityRoot]):
1622
1623 2015-01-27  Beth Dakin  <bdakin@apple.com>
1624
1625         Immediate action gesture recognizer still doesn't work well with IB
1626         https://bugs.webkit.org/show_bug.cgi?id=140967
1627         -and corresponding-
1628         rdar://problem/19621509
1629
1630         Reviewed by Tim Horton.
1631
1632         We should add (or remove) the gesture recognizer in viewDidMoveToWindow because 
1633         initWithFrame it too early and IB might mess with it.
1634         * WebView/WebImmediateActionController.h:
1635         * WebView/WebImmediateActionController.mm:
1636         (-[WebImmediateActionController immediateActionRecognizer]):
1637         * WebView/WebView.mm:
1638         (-[WebView _commonInitializationWithFrameName:groupName:]):
1639         (-[WebView viewDidMoveToWindow]):
1640
1641 2015-01-27  Dan Bernstein  <mitz@apple.com>
1642
1643         Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
1644
1645         Rubber-stamped by Anders Carlsson.
1646
1647         * WebView/WebView.h: Added forward declarations of the protocols.
1648
1649 2015-01-26  Anders Carlsson  <andersca@apple.com>
1650
1651         Make it easy to test enabling formal delegate protocols
1652         https://bugs.webkit.org/show_bug.cgi?id=140892
1653
1654         Reviewed by Dan Bernstein.
1655
1656         Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
1657
1658         * Misc/WebDownload.h:
1659         * WebView/WebFrameLoadDelegate.h:
1660         * WebView/WebPolicyDelegate.h:
1661         * WebView/WebResourceLoadDelegate.h:
1662         * WebView/WebUIDelegate.h:
1663         * WebView/WebView.h:
1664
1665 2015-01-26  Chris Dumez  <cdumez@apple.com>
1666
1667         Rename Document::body() to Document::bodyOrFrameset() for clarity
1668         https://bugs.webkit.org/show_bug.cgi?id=140902
1669
1670         Reviewed by Andreas Kling.
1671
1672         Rename Document::body() to Document::bodyOrFrameset() for clarity. This
1673         method does not necessarily return an HTMLBodyElement, it can also
1674         return a frameset as per the specification:
1675         http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
1676
1677         This method is often misused internally (the caller is only interested
1678         in the <body> element). I will fix these instances in a follow-up patch,
1679         this patch is only renaming mechanically.
1680
1681 2015-01-26  Chris Dumez  <cdumez@apple.com>
1682
1683         First argument to DOM traversal functions should be a reference
1684         https://bugs.webkit.org/show_bug.cgi?id=140895
1685
1686         Reviewed by Antti Koivisto.
1687
1688         First argument to DOM traversal functions should be a reference instead
1689         of a pointer as it is dereferenced without null-check.
1690
1691 2015-01-26  Myles C. Maxfield  <mmaxfield@apple.com>
1692
1693         [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
1694         https://bugs.webkit.org/show_bug.cgi?id=140860
1695
1696         Reviewed by Darin Adler.
1697
1698         The fonts it makes are grotesque. (See what I did there? Typographic
1699         humor is the best humor.)
1700
1701         * Configurations/FeatureDefines.xcconfig:
1702
1703 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
1704
1705         QLPreviewMenuItem popovers don't close when the page scrolls
1706         https://bugs.webkit.org/show_bug.cgi?id=140806
1707         <rdar://problem/19555618>
1708
1709         Reviewed by Beth Dakin.
1710
1711         Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
1712
1713         * WebView/WebHTMLView.mm:
1714         (-[WebHTMLView scrollWheel:scrollWheel:]):
1715         Send scrollWheel along to WebImmediateActionController.
1716
1717         * WebView/WebImmediateActionController.h:
1718         * WebView/WebImmediateActionController.mm:
1719         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
1720         (-[WebImmediateActionController _clearImmediateActionState]):
1721         (-[WebImmediateActionController _defaultAnimationController]):
1722         Keep track of the active QLPreviewMenuItem, and close it upon scroll.
1723
1724 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
1725
1726         Infinite recursion in _clearImmediateActionState
1727         https://bugs.webkit.org/show_bug.cgi?id=140807
1728         <rdar://problem/19571601>
1729
1730         Reviewed by Anders Carlsson.
1731
1732         * WebView/WebImmediateActionController.mm:
1733         (-[WebImmediateActionController _clearImmediateActionState]):
1734         Use this opportunity to bring identical code to WebKit1, to avoid
1735         getting DataDetectors stuck when an immediate action is canceled.
1736
1737 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1738
1739         Add a build flag for ES6 class syntax
1740         https://bugs.webkit.org/show_bug.cgi?id=140760
1741
1742         Reviewed by Michael Saboff.
1743
1744         * Configurations/FeatureDefines.xcconfig:
1745
1746 2015-01-22  Beth Dakin  <bdakin@apple.com>
1747
1748         ibtoold crash below -[WebView close]
1749         https://bugs.webkit.org/show_bug.cgi?id=140782
1750         -and corresponding-
1751         rdar://problem/19558472
1752
1753         Reviewed by Tim Horton.
1754
1755         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
1756         it is because interface builder is messing with our views.
1757         * WebView/WebImmediateActionController.h:
1758         * WebView/WebImmediateActionController.mm:
1759         (-[WebImmediateActionController webViewClosed]):
1760         (-[WebImmediateActionController _cancelImmediateAction]):
1761         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1762         (-[WebImmediateActionController _updateImmediateActionItem]):
1763
1764 2015-01-21  Beth Dakin  <bdakin@apple.com>
1765
1766         Crash in QuickLook preview delegate method
1767         https://bugs.webkit.org/show_bug.cgi?id=140740
1768         -and corresponding-
1769         rdar://problem/19540806
1770
1771         Reviewed by Tim Horton.
1772
1773         Clear out the delegate.
1774         * WebView/WebImmediateActionController.mm:
1775         (-[WebImmediateActionController webViewClosed]):
1776
1777 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
1778
1779         Remove ENABLE(INSPECTOR) ifdef guards
1780         https://bugs.webkit.org/show_bug.cgi?id=140668
1781
1782         Reviewed by Darin Adler.
1783
1784         * Configurations/FeatureDefines.xcconfig:
1785         * WebCoreSupport/WebFrameLoaderClient.mm:
1786         (WebFrameLoaderClient::dispatchWillSendRequest):
1787
1788 2015-01-20  Anders Carlsson  <andersca@apple.com>
1789
1790         Remove USE(GLIB) code from WebKit1
1791         https://bugs.webkit.org/show_bug.cgi?id=140714
1792
1793         Reviewed by Andreas Kling.
1794
1795         * WebView/WebView.mm:
1796         (-[WebView _commonInitializationWithFrameName:groupName:]):
1797         (-[WebView _close]):
1798         (-[WebView _clearGlibLoopObserver]): Deleted.
1799         (glibContextIterationCallback): Deleted.
1800         (-[WebView _scheduleGlibContextIterations]): Deleted.
1801         * WebView/WebViewData.h:
1802         * WebView/WebViewInternal.h:
1803
1804 2015-01-20  David Kilzer  <ddkilzer@apple.com>
1805
1806         Switch to comparing PLATFORM_NAME in terms of macosx
1807         <http://webkit.org/b/139516>
1808
1809         Reviewed by Timothy Hatcher.
1810
1811         * MigrateHeaders.make:
1812         * postprocess-headers.sh:
1813
1814 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1815
1816         [SVG -> OTF Converter] Flip the switch on
1817         https://bugs.webkit.org/show_bug.cgi?id=140592
1818
1819         Reviewed by Antti Koivisto.
1820
1821         * Configurations/FeatureDefines.xcconfig:
1822
1823 2015-01-19  Beth Dakin  <bdakin@apple.com>
1824
1825         Speculative build fix.
1826
1827         * WebView/WebView.mm:
1828         (-[WebView _commonInitializationWithFrameName:groupName:]):
1829
1830 2015-01-19  Beth Dakin  <bdakin@apple.com>
1831
1832         Speculative build fix.
1833
1834         * WebView/WebView.mm:
1835         (-[WebView _convertRectFromRootView:]):
1836
1837 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
1838
1839         Adjust naming of action menu SPI
1840         https://bugs.webkit.org/show_bug.cgi?id=140644
1841         <rdar://problem/19448129>
1842
1843         Reviewed by Brian Weinstein.
1844
1845         * WebView/WebActionMenuController.mm:
1846         (-[WebActionMenuController prepareForMenu:withEvent:]):
1847         (-[WebActionMenuController willOpenMenu:withEvent:]):
1848         (-[WebActionMenuController didCloseMenu:withEvent:]):
1849         * WebView/WebView.mm:
1850         (-[WebView _commonInitializationWithFrameName:groupName:]):
1851         (-[WebView prepareForMenu:withEvent:]):
1852         (-[WebView willOpenMenu:withEvent:]):
1853         (-[WebView didCloseMenu:withEvent:]):
1854
1855 2015-01-19  Beth Dakin  <bdakin@apple.com>
1856
1857         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
1858         offset by flipped-ness
1859         https://bugs.webkit.org/show_bug.cgi?id=140643
1860         -and corresponding-
1861         rdar://problem/19489593
1862
1863         Reviewed by Tim Horton.
1864
1865         We universally flipped because we assumed that the root view was flipped and the 
1866         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
1867         fixes that assumption by checking the WebView’s flipped-ness.
1868         * WebView/WebView.mm:
1869         (-[WebView _convertRectFromRootView:]):
1870
1871 2015-01-19  Commit Queue  <commit-queue@webkit.org>
1872
1873         Unreviewed, rolling out r178653.
1874         https://bugs.webkit.org/show_bug.cgi?id=140634
1875
1876         Broke multiple SVG tests on Mountain Lion (Requested by ap on
1877         #webkit).
1878
1879         Reverted changeset:
1880
1881         "[SVG -> OTF Converter] Flip the switch on"
1882         https://bugs.webkit.org/show_bug.cgi?id=140592
1883         http://trac.webkit.org/changeset/178653
1884
1885 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1886
1887         [SVG -> OTF Converter] Flip the switch on
1888         https://bugs.webkit.org/show_bug.cgi?id=140592
1889
1890         Reviewed by Antti Koivisto.
1891
1892         * Configurations/FeatureDefines.xcconfig:
1893
1894 2015-01-18  Daniel Bates  <dabates@apple.com>
1895
1896         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
1897         (https://bugs.webkit.org/show_bug.cgi?id=129441)
1898
1899         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
1900         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
1901
1902         * WebInspector/WebNodeHighlightView.mm:
1903         (-[WebNodeHighlightView layoutSublayers:]):
1904
1905 2015-01-16  Beth Dakin  <bdakin@apple.com>
1906
1907         Make sure early cancellation of immediate action actually does that in WK1
1908         https://bugs.webkit.org/show_bug.cgi?id=140566
1909         -and corresponding-
1910         rdar://problem/19490114
1911
1912         Reviewed by Tim Horton.
1913
1914         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
1915         asynchronously.
1916         * WebView/WebImmediateActionController.mm:
1917         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1918
1919 2015-01-16  Daniel Bates  <dabates@apple.com>
1920
1921         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
1922         (https://bugs.webkit.org/show_bug.cgi?id=140360)
1923
1924         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
1925
1926         * Misc/WebDownload.h:
1927
1928 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
1929
1930         Remove ENABLE(SQL_DATABASE) guards
1931         https://bugs.webkit.org/show_bug.cgi?id=140434
1932
1933         Reviewed by Darin Adler.
1934
1935         * Configurations/FeatureDefines.xcconfig:
1936         * Storage/WebDatabaseManager.mm:
1937         (databasesDirectoryPath):
1938         * Storage/WebDatabaseManagerClient.h:
1939         * Storage/WebDatabaseManagerClient.mm:
1940         * Storage/WebDatabaseManagerInternal.h:
1941         * Storage/WebDatabaseManagerPrivate.h:
1942         * Storage/WebDatabaseQuotaManager.mm:
1943         (-[WebDatabaseQuotaManager usage]):
1944         (-[WebDatabaseQuotaManager quota]):
1945         (-[WebDatabaseQuotaManager setQuota:]):
1946         * WebCoreSupport/WebChromeClient.h:
1947         * WebCoreSupport/WebChromeClient.mm:
1948         * WebCoreSupport/WebSecurityOrigin.mm:
1949         (-[WebSecurityOrigin usage]):
1950         (-[WebSecurityOrigin quota]):
1951         (-[WebSecurityOrigin setQuota:]):
1952         * WebView/WebFrame.mm:
1953         (-[WebFrame _cacheabilityDictionary]):
1954         * WebView/WebView.mm:
1955         (-[WebView _commonInitializationWithFrameName:groupName:]):
1956         (-[WebView _preferencesChanged:]):
1957
1958 2015-01-14  Chris Dumez  <cdumez@apple.com>
1959
1960         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
1961         https://bugs.webkit.org/show_bug.cgi?id=140347
1962
1963         Reviewed by Darin Adler.
1964
1965         Call FontDescription::setIsItalic() instead of setItalic() as the
1966         call site passes a boolean.
1967
1968         * WebView/WebHTMLView.mm:
1969         (fontNameForDescription):
1970
1971 2015-01-13  Anders Carlsson  <andersca@apple.com>
1972
1973         Temporarily reintroduce the informal delegate protocols
1974         https://bugs.webkit.org/show_bug.cgi?id=140416
1975
1976         Reviewed by Dan Bernstein.
1977
1978         * WebView/WebEditingDelegate.h:
1979         * WebView/WebFrameLoadDelegate.h:
1980         * WebView/WebPolicyDelegate.h:
1981         * WebView/WebResourceLoadDelegate.h:
1982         * WebView/WebUIDelegate.h:
1983
1984 2015-01-13  Beth Dakin  <bdakin@apple.com>
1985
1986         Should disable immediate actions for iTunes
1987         https://bugs.webkit.org/show_bug.cgi?id=140405
1988         -and corresponding-
1989         rdar://problem/19461358
1990
1991         Reviewed by Tim Horton.
1992
1993         * WebView/WebImmediateActionController.mm:
1994         (-[WebImmediateActionController _updateImmediateActionItem]):
1995
1996 2015-01-11  Sam Weinig  <sam@webkit.org>
1997
1998         Remove support for SharedWorkers
1999         https://bugs.webkit.org/show_bug.cgi?id=140344
2000
2001         Reviewed by Anders Carlsson.
2002
2003         * Configurations/FeatureDefines.xcconfig:
2004         * WebCoreSupport/WebPlatformStrategies.h:
2005         * WebCoreSupport/WebPlatformStrategies.mm:
2006         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
2007
2008 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
2009
2010         Get rid of unnecessary reimplementations of CGFloor/Ceiling
2011         https://bugs.webkit.org/show_bug.cgi?id=140375
2012
2013         Reviewed by Simon Fraser.
2014
2015         * Misc/WebKitNSStringExtras.mm:
2016         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2017         (webkit_CGCeiling): Deleted.
2018         Delete unnecessary code, use the real CGFloor/Ceiling instead.
2019
2020 2015-01-12  Anders Carlsson  <andersca@apple.com>
2021
2022         Make delegates conform to formal delegate protocols
2023         https://bugs.webkit.org/show_bug.cgi?id=140370
2024
2025         Reviewed by Dan Bernstein.
2026
2027         * DefaultDelegates/WebDefaultPolicyDelegate.h:
2028         * WebCoreSupport/WebInspectorClient.mm:
2029         Add protocols to the interface declarations.
2030
2031         * WebView/WebActionMenuController.mm:
2032         (-[WebActionMenuController prepareForMenu:withEvent:]):
2033         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2034         * WebView/WebImmediateActionController.mm:
2035         (-[WebImmediateActionController _updateImmediateActionItem]):
2036         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2037         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
2038
2039 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
2040
2041         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
2042         https://bugs.webkit.org/show_bug.cgi?id=136769
2043
2044         Reviewed by Antti Koivisto.
2045
2046         * Configurations/FeatureDefines.xcconfig:
2047
2048 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
2049
2050         Multi-rect TextIndicators are vertically flipped in WebKit1
2051         https://bugs.webkit.org/show_bug.cgi?id=140350
2052         <rdar://problem/19441243>
2053
2054         Reviewed by Beth Dakin.
2055
2056         * WebView/WebView.mm:
2057         (-[WebView _setTextIndicator:fadeOut:]):
2058         Convert the textBoundingRect from root view to screen coordinates.
2059
2060 2015-01-12  Anders Carlsson  <andersca@apple.com>
2061
2062         Make WebResourceDelegate a formal protocol as well
2063         https://bugs.webkit.org/show_bug.cgi?id=140364
2064
2065         Reviewed by Dan Bernstein.
2066
2067         * WebView/WebResourceLoadDelegate.h:
2068
2069 2015-01-12  Anders Carlsson  <andersca@apple.com>
2070
2071         Delegates should be formal protocols
2072         https://bugs.webkit.org/show_bug.cgi?id=140360
2073         rdar://problem/17380856
2074
2075         Reviewed by Dan Bernstein.
2076
2077         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
2078
2079         * DefaultDelegates/WebDefaultUIDelegate.h:
2080         * Misc/WebDownload.h:
2081         * WebView/WebEditingDelegate.h:
2082         * WebView/WebFrameLoadDelegate.h:
2083         * WebView/WebPolicyDelegate.h:
2084         * WebView/WebUIDelegate.h:
2085
2086 2015-01-09  Anders Carlsson  <andersca@apple.com>
2087
2088         Get rid of the database strategy
2089         https://bugs.webkit.org/show_bug.cgi?id=140322
2090
2091         Reviewed by Sam Weinig.
2092
2093         * WebCoreSupport/WebPlatformStrategies.h:
2094         * WebCoreSupport/WebPlatformStrategies.mm:
2095         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
2096
2097 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
2098
2099         Can't use DataDetectors after immediate action preparation
2100         https://bugs.webkit.org/show_bug.cgi?id=140263
2101         <rdar://problem/19412705>
2102
2103         Reviewed by Beth Dakin.
2104
2105         * WebView/WebImmediateActionController.mm:
2106         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2107         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2108         To match WebKit2, only call shouldUseActions if the animation is actually
2109         going to begin, not when preparing for it. This way, we're guaranteed
2110         to get a didCancel or didComplete.
2111
2112 2015-01-08  Dean Jackson  <dino@apple.com>
2113
2114         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
2115         https://bugs.webkit.org/show_bug.cgi?id=140232
2116         <rdar://problem/19371010>
2117
2118         Reviewed by Anders Carlsson.
2119
2120         Remove the applicationChromeMode setting, but leave stubs in to make
2121         sure existing binaries don't break.
2122
2123         * WebCoreSupport/WebInspectorClient.mm:
2124         (-[WebInspectorWindowController init]):
2125         * WebView/WebPreferenceKeysPrivate.h:
2126         * WebView/WebPreferences.mm:
2127         (+[WebPreferences initialize]):
2128         (-[WebPreferences applicationChromeModeEnabled]):
2129         (-[WebPreferences setApplicationChromeModeEnabled:]):
2130         * WebView/WebView.mm:
2131         (-[WebView _preferencesChanged:]):
2132
2133 2015-01-07  Daniel Bates  <dabates@apple.com>
2134
2135         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2136         https://bugs.webkit.org/show_bug.cgi?id=137371
2137
2138         Reviewed by David Kilzer.
2139
2140         Use SPI wrapper headers instead of directly references private SPI headers.
2141
2142         * Plugins/Hosted/NetscapePluginHostManager.mm:
2143
2144 2015-01-07  Commit Queue  <commit-queue@webkit.org>
2145
2146         Unreviewed, rolling out r178068.
2147         https://bugs.webkit.org/show_bug.cgi?id=140235
2148
2149         Breaks the iOS build (Requested by enrica on #webkit).
2150
2151         Reverted changeset:
2152
2153         "[iOS] Make WebKit2 build with public iOS SDK and more build
2154         fixes for DRT"
2155         https://bugs.webkit.org/show_bug.cgi?id=137371
2156         http://trac.webkit.org/changeset/178068
2157
2158 2015-01-07  Daniel Bates  <dabates@apple.com>
2159
2160         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2161         https://bugs.webkit.org/show_bug.cgi?id=137371
2162
2163         Reviewed by David Kilzer.
2164
2165         Use SPI wrapper headers instead of directly references private SPI headers.
2166
2167         * Plugins/Hosted/NetscapePluginHostManager.mm:
2168
2169 2015-01-07  Beth Dakin  <bdakin@apple.com>
2170
2171         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
2172         link
2173         https://bugs.webkit.org/show_bug.cgi?id=140206
2174         -and corresponding-
2175         rdar://problem/19300492
2176
2177         Reviewed by Tim Horton.
2178
2179         Providing and item frame will ensure that the original link is not obscured.
2180         * WebView/WebImmediateActionController.mm:
2181         (elementBoundingBoxInWindowCoordinatesFromNode):
2182         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
2183
2184         For now use a max size that is smaller than the WebView, with the screen’s aspect 
2185         ratio, and scaled down.
2186         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
2187
2188 2015-01-07  Anders Carlsson  <andersca@apple.com>
2189
2190         Give simple HTML documents a database provider
2191         https://bugs.webkit.org/show_bug.cgi?id=140192
2192         rdar://problem/19398825
2193
2194         Reviewed by Tim Horton.
2195
2196         * WebView/WebView.mm:
2197         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2198
2199 2015-01-06  Anders Carlsson  <andersca@apple.com>
2200
2201         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
2202         https://bugs.webkit.org/show_bug.cgi?id=140140
2203
2204         Reviewed by Andreas Kling.
2205
2206         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
2207         out of WebCore since nobody else is using it.
2208
2209         * Plugins/WebNetscapePluginView.h:
2210         * Plugins/WebNetscapePluginView.mm:
2211         (-[WebNetscapePluginView _createPlugin]):
2212         (-[WebNetscapePluginView _destroyPlugin]):
2213         * Plugins/npapi.mm:
2214         (NPN_PluginThreadAsyncCall):
2215
2216 2015-01-06  Anders Carlsson  <andersca@apple.com>
2217
2218         Add a WebKit1 database provider
2219         https://bugs.webkit.org/show_bug.cgi?id=140126
2220
2221         Reviewed by Sam Weinig.
2222
2223         Set the database provider.
2224
2225         * WebView/WebView.mm:
2226         (-[WebView _commonInitializationWithFrameName:groupName:]):
2227
2228 2015-01-06  Commit Queue  <commit-queue@webkit.org>
2229
2230         Unreviewed, rolling out r177963.
2231         https://bugs.webkit.org/show_bug.cgi?id=140136
2232
2233         Caused lots of crashes (Requested by smfr on #webkit).
2234
2235         Reverted changeset:
2236
2237         "Add a WebKit1 database provider"
2238         https://bugs.webkit.org/show_bug.cgi?id=140126
2239         http://trac.webkit.org/changeset/177963
2240
2241 2015-01-06  Anders Carlsson  <andersca@apple.com>
2242
2243         Add a WebKit1 database provider
2244         https://bugs.webkit.org/show_bug.cgi?id=140126
2245
2246         Reviewed by Sam Weinig.
2247
2248         Set the database provider.
2249
2250         * WebView/WebView.mm:
2251         (-[WebView _commonInitializationWithFrameName:groupName:]):
2252
2253 2015-01-01  Jeff Miller  <jeffm@apple.com>
2254
2255         Update user-visible copyright strings to include 2015
2256         https://bugs.webkit.org/show_bug.cgi?id=139880
2257
2258         Reviewed by Darin Adler.
2259
2260         * Info.plist:
2261
2262 2014-12-30  Dan Bernstein  <mitz@apple.com>
2263
2264         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
2265         https://bugs.webkit.org/show_bug.cgi?id=140003
2266
2267         Reviewed by Darin Adler.
2268
2269         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
2270         that takes their "string" parameter as a "value" "parameter and has an attribute telling
2271         the compiler that if the "value" parameter is a format string then the function returns a
2272         modified version of it. The result is that if UI_STRING is used as a format string parameter
2273         to some function or method, the compiler will check the format specifiers in the string
2274         against the other parameters.
2275
2276 2014-12-29  Dan Bernstein  <mitz@apple.com>
2277
2278         Fixed the iOS build.
2279
2280         * Configurations/WebKitLegacy.xcconfig:
2281
2282 2014-12-29  Anders Carlsson  <andersca@apple.com>
2283
2284         Get rid of some PageGroup storage functions
2285         https://bugs.webkit.org/show_bug.cgi?id=139996
2286
2287         Reviewed by Sam Weinig.
2288
2289         Call WebStorageNamespaceProvider directly instead.
2290
2291         * Storage/WebStorageManager.mm:
2292         (-[WebStorageManager syncLocalStorage]):
2293         (+[WebStorageManager closeIdleLocalStorageDatabases]):
2294         * WebView/WebView.mm:
2295         (+[WebView _applicationWillTerminate]):
2296
2297 2014-12-29  Anders Carlsson  <andersca@apple.com>
2298
2299         Move storage code from WebCore to WebKit
2300         https://bugs.webkit.org/show_bug.cgi?id=139558
2301
2302         Reviewed by Darin Adler.
2303
2304         * Storage/WebStorageManager.mm:
2305         * Storage/WebStorageTrackerClient.h:
2306         * WebView/WebView.mm:
2307
2308 2014-12-26  Dan Bernstein  <mitz@apple.com>
2309
2310         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
2311         https://bugs.webkit.org/show_bug.cgi?id=139950
2312
2313         Reviewed by David Kilzer.
2314
2315         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
2316         in a manner that works with Xcode 5.1.1.
2317
2318 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
2319
2320         Install a TextIndicator for link immediate actions
2321         https://bugs.webkit.org/show_bug.cgi?id=139897
2322         <rdar://problem/19333076>
2323
2324         Reviewed by Anders Carlsson.
2325
2326         * WebView/WebImmediateActionController.h:
2327         * WebView/WebImmediateActionController.mm:
2328         (-[WebImmediateActionController _clearImmediateActionState]):
2329         Tear down the TextIndicator, just like WebKit2.
2330
2331         (-[WebImmediateActionController _defaultAnimationController]):
2332         Install a TextIndicator for links.
2333
2334         (-[WebImmediateActionController menuItemDidClose:]):
2335         Tear down the TextIndicator when the QL preview closes.
2336
2337         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2338         Directly install and uninstall the TextIndicator for DataDetectors.
2339
2340         (-[WebImmediateActionController _showTextIndicator]): Deleted.
2341         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
2342         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
2343
2344 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
2345
2346         [iOS] add optimized fullscreen API
2347         https://bugs.webkit.org/show_bug.cgi?id=139833
2348         <rdar://problem/18844486>
2349
2350         Reviewed by Simon Fraser.
2351
2352         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
2353
2354 2014-12-20  David Kilzer  <ddkilzer@apple.com>
2355
2356         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2357         <http://webkit.org/b/139463>
2358
2359         Reviewed by Mark Rowe.
2360
2361         * Configurations/Base.xcconfig:
2362         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2363           on OS X.
2364         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2365         * Configurations/DebugRelease.xcconfig:
2366         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2367         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2368         * Configurations/Version.xcconfig:
2369         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2370         * Configurations/WebKitLegacy.xcconfig:
2371         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2372           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2373           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2374           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2375           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2376           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2377           WEBCORE_PRIVATE_HEADERS_DIR_Production and
2378           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2379           based on SDK.
2380         - Fix PRODUCTION_ROOT to actually be set properly.
2381         - Simplify EXPORTED_SYMBOLS_FILE_i386.
2382
2383         * migrate-headers.sh:
2384         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2385         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
2386           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
2387           WebKitLegacy.xcconfig.
2388
2389 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
2390
2391         Fix pink background on CoreAnimation plug-ins in WebKit1
2392         https://bugs.webkit.org/show_bug.cgi?id=139845
2393         rdar://problem/19313075
2394
2395         Reviewed by Tim Horton.
2396         
2397         r154078 left in some debugging code that set a pink background on plug-in hosting
2398         layers. Remove it.
2399
2400         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2401         (-[WebHostedNetscapePluginView createPluginLayer]):
2402
2403 2014-12-19  Andreas Kling  <akling@apple.com>
2404
2405         Ref-ify TextIterator API.
2406         <https://webkit.org/b/139823>
2407
2408         Reviewed by Antti Koivisto.
2409
2410         * WebView/WebTextIterator.mm:
2411         (-[WebTextIterator currentRange]):
2412
2413 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
2414
2415         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
2416         https://bugs.webkit.org/show_bug.cgi?id=139797
2417
2418         Reviewed by Mark Lam.
2419
2420         * WebView/WebScriptDebugger.h:
2421         * WebView/WebScriptDebugger.mm:
2422         (WebScriptDebugger::handlePause):
2423         Standardize on passing JSGlobalObject parameter first.
2424
2425 2014-12-19  Commit Queue  <commit-queue@webkit.org>
2426
2427         Unreviewed, rolling out r177574.
2428         https://bugs.webkit.org/show_bug.cgi?id=139821
2429
2430         "Broke Production builds by installing
2431         libWebCoreTestSupport.dylib in the wrong directory" (Requested
2432         by ddkilzer on #webkit).
2433
2434         Reverted changeset:
2435
2436         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
2437         WebInspectorUI, WebKit, WebKit2"
2438         https://bugs.webkit.org/show_bug.cgi?id=139463
2439         http://trac.webkit.org/changeset/177574
2440
2441 2014-12-19  David Kilzer  <ddkilzer@apple.com>
2442
2443         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2444         <http://webkit.org/b/139463>
2445
2446         Reviewed by Mark Rowe.
2447
2448         * Configurations/Base.xcconfig:
2449         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2450           on OS X.
2451         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2452         * Configurations/DebugRelease.xcconfig:
2453         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2454         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2455         * Configurations/Version.xcconfig:
2456         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2457         * Configurations/WebKitLegacy.xcconfig:
2458         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2459           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2460           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2461           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2462           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2463           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2464           WEBCORE_PRIVATE_HEADERS_DIR_Production and
2465           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2466           based on SDK.
2467         - Fix PRODUCTION_ROOT to actually be set properly.
2468         - Simplify EXPORTED_SYMBOLS_FILE_i386.
2469
2470         * migrate-headers.sh:
2471         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2472         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
2473           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
2474           WebKitLegacy.xcconfig.
2475
2476 2014-12-18  Andreas Kling  <akling@apple.com>
2477
2478         Ref-ify various Document-related things.
2479         <https://webkit.org/b/139796>
2480
2481         Reviewed by Anders Carlsson.
2482
2483         * WebView/WebFrame.mm:
2484         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
2485
2486 2014-12-18  Beth Dakin  <bdakin@apple.com>
2487
2488         Need to re-enable action menus
2489         https://bugs.webkit.org/show_bug.cgi?id=139795
2490         -and corresponding-
2491         rdar://problem/19299367
2492
2493         Reviewed by Tim Horton.
2494
2495         Re-enable the menus by un-commenting the code to create the menu and controller.
2496         * WebView/WebView.mm:
2497         (-[WebView _commonInitializationWithFrameName:groupName:]):
2498
2499 2014-12-16  Sam Weinig  <sam@webkit.org>
2500
2501         Unify the Mac and iOS implementations of FontPlatformData a bit
2502         https://bugs.webkit.org/show_bug.cgi?id=139721
2503
2504         Reviewed by Anders Carlsson.
2505
2506         * WebView/WebHTMLView.mm:
2507         (fontNameForDescription):
2508         Update for new function name.
2509
2510 2014-12-18  Antti Koivisto  <antti@apple.com>
2511
2512         Remove alwaysUseBaselineOfPrimaryFont setting
2513         https://bugs.webkit.org/show_bug.cgi?id=139770
2514
2515         Reviewed by Anders Carlsson.
2516
2517         * WebView/WebPreferenceKeysPrivate.h:
2518         * WebView/WebPreferences.mm:
2519         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
2520         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
2521         * WebView/WebPreferencesPrivate.h:
2522         * WebView/WebView.mm:
2523         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2524         (-[WebView _preferencesChanged:]):
2525
2526 2014-12-17  Andreas Kling  <akling@apple.com>
2527
2528         Ref-ify Range::create().
2529         <https://webkit.org/b/139755>
2530
2531         Reviewed by Anders Carlsson.
2532
2533         * WebView/WebHTMLRepresentation.mm:
2534         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2535         * WebView/WebHTMLView.mm:
2536         (-[WebHTMLView attributedString]):
2537
2538 2014-12-17  Anders Carlsson  <andersca@apple.com>
2539
2540         Unify -[WebResource description]
2541         https://bugs.webkit.org/show_bug.cgi?id=139762
2542
2543         Reviewed by Dan Bernstein.
2544
2545         * WebView/WebResource.mm:
2546         (-[WebResource description]):
2547
2548 2014-12-17  Anders Carlsson  <andersca@apple.com>
2549
2550         Get rid of an ugly #define hack in WebFrameLoaderClient
2551         https://bugs.webkit.org/show_bug.cgi?id=139761
2552
2553         Reviewed by Dan Bernstein.
2554
2555         Also replace @private with @package in all public headers, for consistency.
2556
2557         * History/WebBackForwardList.h:
2558         * History/WebHistory.h:
2559         * Misc/WebDownload.h:
2560         * WebCoreSupport/WebFrameLoaderClient.mm:
2561         * WebView/WebArchive.h:
2562         * WebView/WebDataSource.h:
2563         * WebView/WebFrame.h:
2564         * WebView/WebFrameView.h:
2565         * WebView/WebPreferences.h:
2566         * WebView/WebResource.h:
2567
2568 2014-12-17  Dan Bernstein  <mitz@apple.com>
2569
2570         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
2571         https://bugs.webkit.org/show_bug.cgi?id=139760
2572
2573         Reviewed by Anders Carlsson.
2574
2575         * Configurations/WebKitLegacy.xcconfig:
2576
2577 2014-12-17  Andreas Kling  <akling@apple.com>
2578
2579         Purge PassRefPtr from Frame.
2580         <https://webkit.org/b/139731>
2581
2582         Reviewed by Anders Carlsson.
2583
2584         * WebCoreSupport/WebFrameLoaderClient.mm:
2585         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2586         * WebView/WebFrame.mm:
2587         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
2588         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
2589         * WebView/WebFrameInternal.h:
2590
2591 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
2592
2593         Implement and adopt two new TextIndicator presentation animations
2594         https://bugs.webkit.org/show_bug.cgi?id=139715
2595         <rdar://problem/19237945>
2596
2597         Reviewed by Anders Carlsson.
2598
2599         * WebView/WebActionMenuController.mm:
2600         (-[WebActionMenuController _showTextIndicator]):
2601         * WebView/WebHTMLView.mm:
2602         (-[WebHTMLView quickLookWithEvent:]):
2603         Remove the completionHandler from text indicator presentation.
2604
2605         * WebView/WebImmediateActionController.mm:
2606         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2607         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
2608         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2609         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2610         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2611         (-[WebImmediateActionController _animationControllerForText]):
2612         (-[WebImmediateActionController _showTextIndicator]):
2613         Forward immediate action gesture recognizer animation progress
2614         to TextIndicator. Force us to keep the selection when immediate
2615         action popovers steal first responder status from the WebView.
2616         If the Lookup range is equal to the selection range, use a Crossfade
2617         animation; otherwise, use a FadeIn animation.
2618
2619         * WebView/WebView.mm:
2620         (-[WebView _setMaintainsInactiveSelection:]):
2621         (-[WebView maintainsInactiveSelection]):
2622         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2623         (-[WebView _setTextIndicator:fadeOut:]):
2624         (-[WebView _clearTextIndicator]):
2625         (-[WebView _setTextIndicatorAnimationProgress:]):
2626         (-[WebView _showDictionaryLookupPopup:]):
2627         (-[WebView _dictionaryLookupPopoverWillClose:]):
2628         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2629         Remove the completionHandler from text indicator presentation.
2630         Add a _setMaintainsInactiveSelection, which allows WebKit internals
2631         to change the return value of -maintainsInactiveSelection, allowing
2632         us to keep the selection alive when the WebView loses first responder status.
2633
2634         * WebView/WebViewData.h:
2635         * WebView/WebViewInternal.h:
2636
2637 2014-12-16  Andreas Kling  <akling@apple.com>
2638
2639         Use Ref for SecurityOrigin.
2640         <https://webkit.org/b/139710>
2641
2642         Reviewed by Anders Carlsson.
2643
2644         * Storage/WebStorageTrackerClient.mm:
2645         (WebStorageTrackerClient::dispatchDidModifyOrigin):
2646         * WebView/WebView.mm:
2647         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
2648         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
2649
2650 2014-12-16  Beth Dakin  <bdakin@apple.com>
2651
2652         Crash getting default animation controller for some text
2653         https://bugs.webkit.org/show_bug.cgi?id=139712
2654         -and corresponding-
2655         rdar://problem/19271707
2656
2657         Reviewed by Tim Horton.
2658
2659         Must null-check the range.
2660         * WebView/WebImmediateActionController.mm:
2661         (-[WebImmediateActionController _animationControllerForText]):
2662
2663 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
2664
2665         Immediate action popovers can get stuck open
2666         https://bugs.webkit.org/show_bug.cgi?id=139709
2667         <rdar://problem/19270279>
2668
2669         Reviewed by Beth Dakin.
2670
2671         * WebView/WebImmediateActionController.mm:
2672         (-[WebImmediateActionController _clearImmediateActionState]):
2673         Don't clear the animation controller; it breaks things and was unnecessary.
2674
2675 2014-12-16  Tim Horton  <timothy_horton@apple.com>
2676
2677         Disable TextIndication for Lookup immediate actions
2678         https://bugs.webkit.org/show_bug.cgi?id=139684
2679
2680         Reviewed by Anders Carlsson.
2681
2682         * WebView/WebView.mm:
2683         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2684
2685 2014-12-15  Beth Dakin  <bdakin@apple.com>
2686
2687         Build fix.
2688
2689         * WebView/WebImmediateActionController.mm:
2690
2691 2014-12-15  Beth Dakin  <bdakin@apple.com>
2692
2693         Speculative build fix.
2694
2695         * WebView/WebView.mm:
2696         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2697         * WebView/WebViewInternal.h:
2698
2699 2014-12-15  Beth Dakin  <bdakin@apple.com>
2700
2701         Make lookup an immediate action instead of an action menu item
2702         https://bugs.webkit.org/show_bug.cgi?id=139661
2703         -and corresponding-
2704         rdar://problem/19198414
2705
2706         Reviewed by Tim Horton.
2707
2708         Remove the lookup menu items and non-unused static function associated with 
2709         lookup.
2710         * WebView/WebActionMenuController.mm:
2711         (-[WebActionMenuController _defaultMenuItemsForText]):
2712         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2713         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2714         (-[WebActionMenuController _createActionMenuItemForTag:]):
2715         (-[WebActionMenuController _lookupText:]): Deleted.
2716         (performDictionaryLookupForSelection): Deleted.
2717         (performDictionaryLookupForRange): Deleted.
2718
2719         Set the defaultAnimationController to the lookup-provided animation controller 
2720         when appropriate.
2721         * WebView/WebImmediateActionController.mm:
2722         (-[WebImmediateActionController _defaultAnimationController]):
2723         (dictionaryPopupInfoForRange):
2724         (-[WebImmediateActionController _animationControllerForText]):
2725
2726         New type.
2727         * WebView/WebUIDelegatePrivate.h:
2728
2729         New function to get the lookup animation controller.
2730         * WebView/WebView.mm:
2731         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2732         * WebView/WebViewInternal.h:
2733
2734 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2735
2736         Implement Data Detectors immediate actions for Legacy WebKit
2737         https://bugs.webkit.org/show_bug.cgi?id=139619
2738         <rdar://problem/19198539>
2739
2740         Reviewed by Beth Dakin.
2741
2742         * WebView/WebImmediateActionController.mm:
2743         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2744         Note that this action context is only for immediate actions.
2745
2746 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
2747
2748         Addressing post-review comments in r177035
2749         https://bugs.webkit.org/show_bug.cgi?id=139557
2750
2751         Reviewed by Darin Adler.
2752
2753         * WebView/WebActionMenuController.mm:
2754         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
2755
2756 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2757
2758         Implement Data Detectors immediate actions for Legacy WebKit
2759         https://bugs.webkit.org/show_bug.cgi?id=139619
2760         <rdar://problem/19198539>
2761
2762         Reviewed by Eric Carlson.
2763
2764         * WebView/WebHTMLView.mm:
2765         (-[WebHTMLView mouseDown:mouseDown:]):
2766         Send mouseDown along to the WebImmediateActionController too.
2767
2768         * WebView/WebImmediateActionController.h:
2769         * WebView/WebImmediateActionController.mm:
2770         (-[WebImmediateActionController webViewClosed]):
2771         (-[WebImmediateActionController webView:willHandleMouseDown:]):
2772         (-[WebImmediateActionController _cancelImmediateAction]):
2773         (-[WebImmediateActionController _clearImmediateActionState]):
2774         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2775         (-[WebImmediateActionController _defaultAnimationController]):
2776         (-[WebImmediateActionController _updateImmediateActionItem]):
2777         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2778         (-[WebImmediateActionController _showTextIndicator]):
2779         (-[WebImmediateActionController _hideTextIndicator]):
2780         Copy most of the DataDetectors implementation into WebImmediateActionController.
2781
2782         * WebView/WebUIDelegatePrivate.h:
2783         Add a new type.
2784
2785         * WebView/WebView.mm:
2786         (-[WebView _commonInitializationWithFrameName:groupName:]):
2787         Temporarily disable action menus.
2788
2789         (-[WebView _immediateActionController]):
2790         * WebView/WebViewInternal.h:
2791
2792 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
2793
2794         Delete Notation because we don't use it
2795         https://bugs.webkit.org/show_bug.cgi?id=139171
2796
2797         Reviewed by Kent Tamura.
2798
2799         * MigrateHeaders.make:
2800
2801 2014-12-14  Andreas Kling  <akling@apple.com>
2802
2803         Replace PassRef with Ref/Ref&& across the board.
2804         <https://webkit.org/b/139587>
2805
2806         Reviewed by Darin Adler.
2807
2808         * WebCoreSupport/WebEditorClient.mm:
2809         (WebEditorClient::shouldApplyStyle):
2810         * WebCoreSupport/WebVisitedLinkStore.h:
2811         * WebCoreSupport/WebVisitedLinkStore.mm:
2812         (WebVisitedLinkStore::create):
2813
2814 2014-12-11  Dan Bernstein  <mitz@apple.com>
2815
2816         Fix a leak introduced in r177199.
2817
2818         Reviewed by Anders Carlsson.
2819
2820         * WebView/WebImmediateActionController.mm:
2821         (-[WebImmediateActionController _updateImmediateActionItem]):
2822
2823 2014-12-11  Beth Dakin  <bdakin@apple.com>
2824
2825         WK1: Need new SPI for Webkit clients to override default immediate action
2826         https://bugs.webkit.org/show_bug.cgi?id=139568
2827         -and corresponding-
2828         rdar://problem/19225448
2829
2830         Reviewed by Dan Bernstein.
2831
2832         Call SPI giving clients a chance to override the default behavior.
2833         * WebView/WebImmediateActionController.mm:
2834         (-[WebImmediateActionController _updateImmediateActionItem]):
2835
2836         New SPI.
2837         * WebView/WebUIDelegatePrivate.h:
2838
2839 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
2840
2841         Move the preview popover to WebImmediateActionController
2842         https://bugs.webkit.org/show_bug.cgi?id=139563
2843         <rdar://problem/19208291>
2844
2845         Reviewed by Beth Dakin.
2846
2847         * WebView/WebActionMenuController.mm:
2848         (-[WebActionMenuController _defaultMenuItemsForLink]):
2849         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
2850         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
2851         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
2852         * WebView/WebImmediateActionController.h:
2853         * WebView/WebImmediateActionController.mm:
2854         (-[WebImmediateActionController webViewClosed]):
2855         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2856         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2857         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2858         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2859         (-[WebImmediateActionController _updateImmediateActionItem]):
2860         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
2861         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
2862         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
2863         Move page preview popover related code to WebImmediateActionController.
2864
2865         * WebView/WebUIDelegatePrivate.h:
2866         Add a link preview type.
2867
2868         * WebView/WebView.mm:
2869         (-[WebView _commonInitializationWithFrameName:groupName:]):
2870         Pass the gesture recognizer to the WebImmediateActionController.
2871
2872 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
2873
2874         Fix the build.
2875
2876         * WebView/WebImmediateActionController.h:
2877         * WebView/WebImmediateActionController.mm:
2878
2879 2014-12-11  Anders Carlsson  <andersca@apple.com>
2880
2881         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
2882         https://bugs.webkit.org/show_bug.cgi?id=139547
2883
2884         Reviewed by Sam Weinig.
2885
2886         * WebView/WebView.mm:
2887         (+[WebView _handleMemoryWarning]):
2888
2889 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
2890
2891         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
2892         https://bugs.webkit.org/show_bug.cgi?id=139504
2893         rdar://problem/19034674
2894
2895         Reviewed by Enrica Casucci.
2896
2897         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
2898
2899         * WebCoreSupport/WebEditorClient.h:
2900         * WebCoreSupport/WebEditorClient.mm:
2901         (WebEditorClient::discardedComposition):
2902
2903 2014-12-10  Anders Carlsson  <andersca@apple.com>
2904
2905         Get rid of the storage strategy
2906         https://bugs.webkit.org/show_bug.cgi?id=139519
2907
2908         Reviewed by Antti Koivisto.
2909
2910         * WebCoreSupport/WebPlatformStrategies.h:
2911         * WebCoreSupport/WebPlatformStrategies.mm:
2912         (WebPlatformStrategies::createStorageStrategy): Deleted.
2913
2914 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2915
2916         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
2917         https://bugs.webkit.org/show_bug.cgi?id=139529
2918         <rdar://problem/19213620>
2919
2920         Reviewed by Beth Dakin.
2921
2922         * WebView/WebActionMenuController.mm:
2923         (-[WebActionMenuController _copySelection:]):
2924         (-[WebActionMenuController _paste:]):
2925         Use the copy: and paste: methods on WebView so that we traverse subviews
2926         when trying to respond, otherwise these actions don't work in subframes.
2927
2928 2014-12-10  Beth Dakin  <bdakin@apple.com>
2929
2930         WK1: Add initial support for immediate actions
2931         https://bugs.webkit.org/show_bug.cgi?id=139522
2932
2933         Reviewed by Dan Bernstein.
2934
2935         This basic implementation of the controller will use the delegate methods to 
2936         perform and cache a HitTest when relevant. Future patches will patch 
2937         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
2938         immediate action that should be taken.
2939         * WebView/WebImmediateActionController.h: Added.
2940         * WebView/WebImmediateActionController.mm: Added.
2941         (-[WebImmediateActionController webViewClosed]):
2942         (-[WebImmediateActionController _clearImmediateActionState]):
2943         (-[WebImmediateActionController performHitTestAtPoint:]):
2944         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2945         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2946         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2947         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2948         (-[WebImmediateActionController _updateImmediateActionItem]):
2949
2950         New enum for immediate action types.
2951         * WebView/WebUIDelegatePrivate.h:
2952
2953         Create an NSImmediateActionGestureRecognizer if possible and a controller.
2954         * WebView/WebView.mm:
2955         (-[WebView _commonInitializationWithFrameName:groupName:]):
2956         (-[WebView _close]):
2957         * WebView/WebViewData.h:
2958         * WebView/WebViewData.mm:
2959         (-[WebViewPrivate dealloc]):
2960
2961 2014-12-08  Anders Carlsson  <andersca@apple.com>
2962
2963         Use the new storage namespace provider in WebKit1
2964         https://bugs.webkit.org/show_bug.cgi?id=139425
2965
2966         Reviewed by Tim Horton.
2967
2968         * WebView/WebView.mm:
2969         (-[WebView _commonInitializationWithFrameName:groupName:]):
2970         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2971         Set the storage namespace provider from the web page group.
2972
2973 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2974
2975         Should have copy and paste items in all text menus
2976         https://bugs.webkit.org/show_bug.cgi?id=139510
2977         <rdar://problem/19198388>
2978
2979         Reviewed by Beth Dakin.
2980
2981         * WebView/WebActionMenuController.mm:
2982         (-[WebActionMenuController _defaultMenuItemsForText]):
2983         Add a disabled paste menu item into the read-only text menu.
2984
2985         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2986         Add a disabled copy menu item into the editable whitespace text menu.
2987
2988 2014-12-10  Anders Carlsson  <andersca@apple.com>
2989
2990         Add WebStorageNamespaceProvider::closeLocalStorage
2991         https://bugs.webkit.org/show_bug.cgi?id=139502
2992
2993         Reviewed by Tim Horton.
2994
2995         * WebView/WebView.mm:
2996         (+[WebView _applicationWillTerminate]):
2997         Call WebStorageNamespaceProvider::closeLocalStorage.
2998
2999 2014-12-09  Commit Queue  <commit-queue@webkit.org>
3000
3001         Unreviewed, rolling out r177037.
3002         https://bugs.webkit.org/show_bug.cgi?id=139464
3003
3004         broke ~50 API tests (Requested by thorton on #webkit).
3005
3006         Reverted changeset:
3007
3008         "Use the new storage namespace provider in WebKit1"
3009         https://bugs.webkit.org/show_bug.cgi?id=139425
3010         http://trac.webkit.org/changeset/177037
3011
3012 2014-12-08  Anders Carlsson  <andersca@apple.com>
3013
3014         Use the new storage namespace provider in WebKit1
3015         https://bugs.webkit.org/show_bug.cgi?id=139425
3016
3017         Reviewed by Tim Horton.
3018
3019         * WebView/WebView.mm:
3020         (-[WebView _commonInitializationWithFrameName:groupName:]):
3021         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3022         Set the storage namespace provider from the web page group.
3023
3024 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
3025
3026         Delete Node::boundingBox()
3027         https://bugs.webkit.org/show_bug.cgi?id=139333
3028
3029         Reviewed by Zalan Bujtas.
3030
3031         * WebView/WebActionMenuController.mm:
3032         (elementBoundingBoxInWindowCoordinatesFromNode): Use
3033         RenderObject::absoluteBoundingBoxRect().
3034
3035 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
3036
3037         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
3038         https://bugs.webkit.org/show_bug.cgi?id=138843
3039         rdar://problem/18793695
3040
3041         Reviewed by Dan Bernstein.
3042
3043         * Panels/WebAuthenticationPanel.m:
3044         (-[WebAuthenticationPanel cancel:]):
3045         (-[WebAuthenticationPanel logIn:]):
3046         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
3047         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
3048         that only when using an old NSWindow API.
3049
3050 2014-12-08  Beth Dakin  <bdakin@apple.com>
3051
3052         Copy and Lookup menu items should be disabled when something is not copyable
3053         https://bugs.webkit.org/show_bug.cgi?id=139423
3054
3055         Reviewed by Tim Horton.
3056
3057         Disable both lookup and copy when a HitTestResult does not allow copy.
3058         * WebView/WebActionMenuController.mm:
3059
3060         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
3061         disable state otherwise.
3062         * WebView/WebView.mm:
3063         (-[WebView _commonInitializationWithFrameName:groupName:]):
3064
3065 2014-12-08  Anders Carlsson  <andersca@apple.com>
3066
3067         Adding user content to a group should force that group to be created
3068         https://bugs.webkit.org/show_bug.cgi?id=139421
3069         rdar://problem/19180108
3070
3071         Reviewed by Sam Weinig.
3072
3073         * WebCoreSupport/WebViewGroup.h:
3074         Store the local storage database path in the group.
3075
3076         * WebCoreSupport/WebViewGroup.mm:
3077         (WebViewGroup::getOrCreate):
3078         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
3079         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
3080
3081         (WebViewGroup::WebViewGroup):
3082         Initialize the new member variable.
3083
3084         (WebViewGroup::storageNamespaceProvider):
3085         Create the namespace provider lazily.
3086
3087         * WebView/WebView.mm:
3088         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
3089         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
3090         Use getOrCreate instead of get.
3091
3092 2014-12-08  Anders Carlsson  <andersca@apple.com>
3093
3094         WebStorageNamespaceProvider should know about its local storage database path
3095         https://bugs.webkit.org/show_bug.cgi?id=139413
3096
3097         Reviewed by Andreas Kling.
3098
3099         * WebCoreSupport/WebViewGroup.h:
3100         * WebCoreSupport/WebViewGroup.mm:
3101         (WebViewGroup::getOrCreate):
3102         (WebViewGroup::WebViewGroup):
3103         * WebView/WebView.mm:
3104         (-[WebView _commonInitializationWithFrameName:groupName:]):
3105         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3106         (-[WebView setGroupName:]):
3107         (-[WebView groupName]): Deleted.
3108
3109 2014-12-08  Daniel Bates  <dabates@apple.com>
3110
3111         [iOS] Fix the WebKit build with the public SDK
3112
3113         Include header NSURLDownloadSPI.h.
3114
3115         * WebCoreSupport/WebFrameLoaderClient.mm:
3116
3117 2014-12-07  Dan Bernstein  <mitz@apple.com>
3118
3119         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
3120         https://bugs.webkit.org/show_bug.cgi?id=139348
3121
3122         Reviewed by Anders Carlsson.
3123
3124         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
3125         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
3126         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
3127         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
3128         avoiding the ambiguity.
3129
3130         * WebView/WebActionMenuController.mm:
3131         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3132
3133 2014-12-06  Anders Carlsson  <andersca@apple.com>
3134
3135         Add a stubbed out version of WebStorageNamespaceProvider
3136         https://bugs.webkit.org/show_bug.cgi?id=139213
3137
3138         Reviewed by Sam Weinig.
3139
3140         * WebCoreSupport/WebViewGroup.h:
3141         (WebViewGroup::storageNamespaceProvider):
3142         * WebCoreSupport/WebViewGroup.mm:
3143         (WebViewGroup::getOrCreate):
3144         (WebViewGroup::WebViewGroup):
3145         Give WebViewGroup a storage namespace provider.
3146
3147 2014-12-06  Anders Carlsson  <andersca@apple.com>
3148
3149         Fix build with newer versions of clang.
3150         rdar://problem/18978687
3151
3152         Add missing overrides and missing casts.
3153
3154         * Storage/WebDatabaseManagerClient.h:
3155         * Storage/WebStorageTrackerClient.h:
3156         * WebCoreSupport/WebChromeClient.h:
3157         * WebCoreSupport/WebFrameLoaderClient.h:
3158         * WebCoreSupport/WebInspectorClient.h:
3159         * WebView/WebDataSource.mm:
3160         (-[WebDataSource _makeRepresentation]):
3161         * WebView/WebFrameView.mm:
3162         (-[WebFrameView _makeDocumentViewForDataSource:]):
3163
3164 2014-12-05  Tim Horton  <timothy_horton@apple.com>
3165
3166         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
3167         https://bugs.webkit.org/show_bug.cgi?id=139306
3168         <rdar://problem/19157955>
3169
3170         Reviewed by Beth Dakin.
3171
3172         * WebView/WebView.mm:
3173         (-[WebView _commonInitializationWithFrameName:groupName:]):
3174         (-[WebView _initWithFrame:frameName:groupName:]):
3175         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
3176
3177 2014-12-05  David Kilzer  <ddkilzer@apple.com>
3178
3179         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
3180         <http://webkit.org/b/139286>
3181
3182         Reviewed by Daniel Bates.
3183
3184         * Configurations/FeatureDefines.xcconfig: Switch back to using
3185         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
3186
3187 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
3188
3189         Fix the 32-bit build.
3190
3191         * WebView/WebView.mm:
3192         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3193
3194 2014-12-04  Tim Horton  <timothy_horton@apple.com>
3195
3196         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
3197         https://bugs.webkit.org/show_bug.cgi?id=139252
3198         <rdar://problem/19140827>
3199
3200         Reviewed by Anders Carlsson.
3201
3202         * WebView/WebView.mm:
3203         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3204         Adjust to the WebCore changes.
3205
3206 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
3207
3208         Implement action menus for tel: URLs
3209         https://bugs.webkit.org/show_bug.cgi?id=139240
3210         <rdar://problem/19115662>
3211
3212         Reviewed by Anders Carlsson.
3213
3214         * WebView/WebActionMenuController.mm:
3215         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3216         Make sure to use the newly created currentActionContext... everywhere.
3217
3218 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
3219
3220         Implement action menus for tel: URLs
3221         https://bugs.webkit.org/show_bug.cgi?id=139240
3222         <rdar://problem/19115662>
3223
3224         Reviewed by Anders Carlsson.
3225
3226         * WebView/WebActionMenuController.mm:
3227         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3228         Make sure to use the newly created currentActionContext.
3229
3230 2014-12-03  Beth Dakin  <bdakin@apple.com>
3231
3232         <input> elements get whitespace action menu instead of editable text menu
3233         https://bugs.webkit.org/show_bug.cgi?id=139241
3234         -and corresponding-
3235         rdar://problem/19072083
3236
3237         Reviewed by Sam Weinig.
3238
3239         We should disallow shadow content in the hit test. This is the default and it is 
3240         how context menus behave. We originally wanted to text inside shadow content so 
3241         that we could find the text, but the new function I added to HitTestResult will 
3242         allow that.
3243         * WebView/WebActionMenuController.mm:
3244         (-[WebActionMenuController performHitTestAtPoint:]):
3245
3246         Adjust to the fact that we don’t hit test shadow content any more.
3247         (-[WebActionMenuController focusAndSelectHitTestResult]):
3248
3249         Offer the text menus for text inside form controls.
3250         (-[WebActionMenuController _defaultMenuItems]):
3251
3252 2014-12-03  Tim Horton  <timothy_horton@apple.com>
3253
3254         Implement action menus for tel: URLs
3255         https://bugs.webkit.org/show_bug.cgi?id=139240
3256         <rdar://problem/19115662>
3257
3258         Reviewed by Anders Carlsson.
3259
3260         * WebView/WebActionMenuController.mm:
3261         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3262         Rename this function as it will work for both mailto and tel URLs.
3263         Adjust it to use contextForView:.
3264
3265         (-[WebActionMenuController webView:willHandleMouseDown:]):
3266         (-[WebActionMenuController prepareForMenu:withEvent:]):
3267         (-[WebActionMenuController didCloseMenu:withEvent:]):
3268         (-[WebActionMenuController _defaultMenuItems]):
3269         Don't check the menu type when going to interact with _currentActionContext.
3270         We'll only have a _currentActionContext if we have a data detected item,
3271         and there are multiple menu types that end up using DDActionContext.
3272
3273         * WebView/WebUIDelegatePrivate.h:
3274         Add a new type.
3275
3276 2014-12-03  Anders Carlsson  <andersca@apple.com>
3277
3278         Set a visited link store when creating a simple WebView
3279         https://bugs.webkit.org/show_bug.cgi?id=139234
3280         <rdar://problem/19132978>
3281
3282         Reviewed by Sam Weinig.
3283
3284         * WebView/WebView.mm:
3285         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3286
3287 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
3288
3289         Fix the build.
3290
3291         * WebCoreSupport/WebFrameLoaderClient.mm:
3292
3293 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
3294
3295         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
3296         https://bugs.webkit.org/show_bug.cgi?id=139149
3297
3298         Reviewed by Anders Carlsson.
3299
3300         This changes API behavior. I think that it's OK, because existing behavior made no sense.
3301         We used to delete caches from disk, but they were still active in memory. Now we also
3302         obsolete them in memory, so documents that use a cache still work, but new ones don't
3303         pick one up.
3304
3305         * WebCoreSupport/WebApplicationCache.mm:
3306         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
3307         need to delete in-momry caches too. Keep existing behavior.
3308         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
3309         that properly deletes caches.
3310
3311 2014-12-02  Tim Horton  <timothy_horton@apple.com>
3312
3313         Remove a SnowLeopard-era quirk for QuickLook
3314         https://bugs.webkit.org/show_bug.cgi?id=139208
3315         <rdar://problem/19121822>
3316
3317         Reviewed by Alexey Proskuryakov.
3318
3319         * WebCoreSupport/WebFrameLoaderClient.h:
3320         * WebCoreSupport/WebFrameLoaderClient.mm:
3321
3322 2014-12-02  Tim Horton  <timothy_horton@apple.com>
3323
3324         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
3325         https://bugs.webkit.org/show_bug.cgi?id=139204
3326
3327         Reviewed by Anders Carlsson.
3328
3329         * WebView/WebView.mm:
3330         (-[WebView _commonInitializationWithFrameName:groupName:]):
3331         (-[WebView _showDictionaryLookupPopup:]):
3332         * WebView/WebViewData.h:
3333         Work around this by delaying the softlinking (and setting up the notification
3334         observer) until we actually need it. There's still an underlying bug, but
3335         this will fix the test.
3336
3337 2014-12-02  Beth Dakin  <bdakin@apple.com>
3338
3339         Yet another build fix.
3340
3341         * WebView/WebActionMenuController.mm:
3342         (-[WebActionMenuController _defaultMenuItemsForLink]):
3343
3344 2014-12-02  Beth Dakin  <bdakin@apple.com>
3345
3346         Build fix.
3347
3348         * WebView/WebActionMenuController.mm:
3349         (-[WebActionMenuController _defaultMenuItemsForLink]):
3350
3351 2014-12-02  Beth Dakin  <bdakin@apple.com>
3352
3353         More build fixing.
3354
3355         * WebView/WebActionMenuController.mm:
3356         (-[WebActionMenuController _defaultMenuItemsForLink]):
3357
3358 2014-12-02  Beth Dakin  <bdakin@apple.com>
3359
3360         Should use standardQuickLookMenuItem for apps that don't implement customizations
3361         https://bugs.webkit.org/show_bug.cgi?id=139193
3362         -and corresponding-
3363         rdar://problem/18944696
3364
3365         Reviewed by Anders Carlsson.
3366
3367         Use [NSMenuItem standardQuickLookMenuItem].
3368         * WebView/WebActionMenuController.mm:
3369         (-[WebActionMenuController _defaultMenuItemsForLink]):
3370
3371         Delegate methods to set up the standardQuickLookMenuItem.
3372         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
3373         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
3374         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
3375
3376         Remove all of the old QLPreviewBubble code.
3377         (-[WebActionMenuController _createActionMenuItemForTag:]):
3378         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
3379
3380 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
3381
3382         Fix the build.
3383
3384         * WebView/WebViewData.h:
3385
3386 2014-12-02  Tim Horton  <timothy_horton@apple.com>
3387
3388         Implement Lookup transition from selection for Legacy WebKit
3389         https://bugs.webkit.org/show_bug.cgi?id=139180
3390         <rdar://problem/19067172>
3391
3392         Reviewed by Beth Dakin.
3393
3394         * WebView/DictionaryPopupInfo.h: Added.
3395         Split DictionaryPopupInfo out into its own file.
3396
3397         * WebView/WebActionMenuController.mm:
3398         (-[WebActionMenuController _lookupText:]):
3399         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
3400
3401         (performDictionaryLookupForSelection):
3402         (performDictionaryLookupForRange):
3403         Plumb the transition style through these helpers.
3404         Create a TextIndicator from the selection range.
3405
3406         * WebView/WebHTMLView.mm:
3407         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3408         Make use of TextIndicator (and DictionaryPopupInfo, and the new
3409         _showDictionaryLookupPopup on WebView) to add a transition from blue
3410         when performing Lookup from the context menu.
3411
3412         (-[WebHTMLView quickLookWithEvent:]):
3413         Remove our TextIndicator whenever a normal three-finger-tap event
3414         comes through, as it will have its own indication.
3415
3416         * WebView/WebView.mm:
3417         (-[WebView _commonInitializationWithFrameName:groupName:]):
3418         (-[WebView _dictionaryLookupPopoverWillClose:]):
3419         Register for the LUNotificationPopoverWillClose notification and remove
3420         our TextIndicator when it is called, just like in WebKit2.
3421         Deregistration is already handled in _close.
3422
3423         (-[WebView _showDictionaryLookupPopup:]):
3424         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
3425         if the relevant API is available.
3426
3427         * WebView/WebViewInternal.h:
3428
3429 2014-12-02  Anders Carlsson  <andersca@apple.com>
3430
3431         Remove visited link handling from PageGroup
3432         https://bugs.webkit.org/show_bug.cgi?id=139185
3433
3434         Reviewed by Sam Weinig.
3435
3436         * History/WebHistory.mm:
3437         (-[WebHistoryPrivate removeItemForURLString:]):
3438         (-[WebHistoryPrivate removeAllItems]):
3439         (+[WebHistory setOptionalSharedHistory:]):
3440         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
3441         (+[WebHistory _removeAllVisitedLinks]):
3442         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
3443         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
3444         * History/WebHistoryInternal.h:
3445         * WebCoreSupport/WebChromeClient.h:
3446         * WebCoreSupport/WebChromeClient.mm:
3447         (WebChromeClient::populateVisitedLinks): Deleted.
3448         * WebView/WebView.mm:
3449         (-[WebView addVisitedLinks:]):
3450         (-[WebView removeVisitedLink:]):
3451
3452 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
3453
3454         Try to fix the Mac build.
3455
3456         * WebView/WebView.mm:
3457         (-[WebView _commonInitializationWithFrameName:groupName:]):
3458         (-[WebView _close]):
3459
3460 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
3461
3462         Fix the iOS build.
3463
3464         * WebView/WebActionMenuController.h:
3465         * WebView/WebActionMenuController.mm:
3466         * WebView/WebHTMLView.mm:
3467         (-[WebHTMLView scrollWheel:scrollWheel:]):
3468         (-[WebHTMLView mouseDown:mouseDown:]):
3469         * WebView/WebView.mm:
3470         * WebView/WebViewData.h:
3471         * WebView/WebViewData.mm:
3472         (-[WebViewPrivate dealloc]):
3473         * WebView/WebViewInternal.h:
3474
3475 2014-12-01  Tim Horton  <timothy_horton@apple.com>
3476
3477         Implement yellow highlight for WebKit1 data detectors
3478         https://bugs.webkit.org/show_bug.cgi?id=138956
3479         <rdar://problem/18992185>
3480
3481         Reviewed by Beth Dakin.
3482
3483         * WebView/WebActionMenuController.h:
3484         * WebView/WebActionMenuController.mm:
3485         (-[WebActionMenuController webView:willHandleMouseDown:]):
3486         (-[WebActionMenuController webView:didHandleScrollWheel:]):
3487         (-[WebActionMenuController prepareForMenu:withEvent:]):
3488         (-[WebActionMenuController didCloseMenu:withEvent:]):
3489         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3490         (-[WebActionMenuController _showTextIndicator]):
3491         (-[WebActionMenuController _hideTextIndicator]):
3492         (-[WebActionMenuController _dismissActionMenuPopovers]):
3493         Copy the WebKit2 WKActionMenuController TextIndicator implementation
3494         into WebActionMenuController. The only significant difference is
3495         that we build the TextIndicator right at menu construction time
3496         instead of in the Web process.
3497
3498         * WebView/WebHTMLView.mm:
3499         (-[WebHTMLView scrollWheel:]):
3500         Let the WebActionMenuController know that we're handling a scroll.
3501
3502         (-[WebHTMLView mouseDown:]):
3503         Let the WebActionMenuController know that we're handling a mouseDown.
3504
3505         * WebView/WebView.mm:
3506         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3507         (-[WebView _clearTextIndicator]):
3508         (-[WebView _actionMenuController]):
3509         (-[WebView _convertRectFromRootView:]): Deleted.
3510         * WebView/WebViewData.h:
3511         * WebView/WebViewData.mm:
3512         * WebView/WebViewInternal.h:
3513         Keep a TextIndicatorWindow on WebView, just like WKView does.
3514         Expose the WebActionMenuController on WebView (internally).
3515
3516 2014-12-01  Anders Carlsson  <andersca@apple.com>
3517
3518         Remove old site specific quirks code that was added in 2009
3519         https://bugs.webkit.org/show_bug.cgi?id=139141
3520
3521         Reviewed by Antti Koivisto.
3522
3523         * WebCoreSupport/WebFrameNetworkingContext.h:
3524         * WebCoreSupport/WebFrameNetworkingContext.mm:
3525         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
3526
3527 2014-11-30  Anders Carlsson  <andersca@apple.com>
3528
3529         Fix a test failure.
3530
3531         * History/WebHistory.mm:
3532         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
3533         Call through to the visited link store.
3534
3535         (+[WebHistory _removeAllVisitedLinks]):
3536         Ditto.
3537
3538         * WebCoreSupport/WebVisitedLinkStore.mm:
3539         (WebVisitedLinkStore::isLinkVisited):
3540         Make sure to populate visited links.
3541
3542 2014-11-30  Anders Carlsson  <andersca@apple.com>
3543
3544         Switch over to the visited link store from the WebViewGroup
3545         https://bugs.webkit.org/show_bug.cgi?id=139112
3546
3547         Reviewed by Sam Weinig.
3548
3549         * WebView/WebView.mm:
3550         (-[WebView _commonInitializationWithFrameName:groupName:]):
3551         (-[WebView setGroupName:]):
3552
3553 2014-11-30  Anders Carlsson  <andersca@apple.com>
3554
3555         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
3556         https://bugs.webkit.org/show_bug.cgi?id=139111
3557
3558         Reviewed by Sam Weinig.
3559
3560         * WebCoreSupport/WebVisitedLinkStore.h:
3561         * WebCoreSupport/WebVisitedLinkStore.mm:
3562         (WebVisitedLinkStore::removeVisitedLink):
3563         * WebView/WebView.mm:
3564         (-[WebView removeVisitedLink:]):
3565
3566 2014-11-29  Anders Carlsson  <andersca@apple.com>
3567
3568         Populate visited links
3569         https://bugs.webkit.org/show_bug.cgi?id=139101
3570
3571         Reviewed by Sam Weinig.
3572
3573         * History/WebHistory.mm: