8444cce9e8a39ba717790b7170fd1e8962d4f30c
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-05-22  Youenn Fablet  <youenn@apple.com>
2
3         Remove AVAudioCaptureSource
4         https://bugs.webkit.org/show_bug.cgi?id=172360
5
6         Reviewed by Sam Weinig.
7
8         Removing the handling of AVAudio/CoreAudio capture source dynamic switch.
9
10         * WebView/WebPreferenceKeysPrivate.h:
11         * WebView/WebPreferences.mm:
12         (+[WebPreferences initialize]):
13         (-[WebPreferences useAVFoundationAudioCapture]): Deleted.
14         (-[WebPreferences setUseAVFoundationAudioCapture:]): Deleted.
15         * WebView/WebPreferencesPrivate.h:
16         * WebView/WebView.mm:
17         (-[WebView _preferencesChanged:]):
18
19 2017-05-22  Sam Weinig  <sam@webkit.org>
20
21         [WebIDL] Support callbacks with arbitrary return types
22         https://bugs.webkit.org/show_bug.cgi?id=172407
23
24         Reviewed by Chris Dumez.
25
26         * DOM/DOM.mm:
27         (-[DOMNodeFilter acceptNode:]):
28         Update for CallbackResult adoption in the base class.
29
30         * DOM/DOMNodeIterator.mm:
31         * DOM/DOMTreeWalker.mm:
32         Update to account for new WebCore implementation return types. We return nil
33         if there was an exception, since retains the existing behavior if a javascript
34         NodeFilter had been used (an exception would cause all nodes to be rejected,
35         thus returning nullptr).
36
37         * DOM/ObjCNodeFilterCondition.h:
38         * DOM/ObjCNodeFilterCondition.mm:
39         Update to match new interface of NodeFilterCondition.
40
41 2017-05-18  Sam Weinig  <sam@webkit.org>
42
43         [WebIDL] Remove the need for the generator to know about native type mapping
44         https://bugs.webkit.org/show_bug.cgi?id=172310
45
46         Reviewed by Darin Adler.
47
48         * DOM/DOM.mm:
49         (-[DOMNodeFilter acceptNode:]):
50         Update to pass Node by reference.
51
52 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
53
54         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
55         https://bugs.webkit.org/show_bug.cgi?id=172098
56
57         Reviewed by Saam Barati.
58
59         * Plugins/Hosted/ProxyInstance.mm:
60         * Plugins/Hosted/ProxyRuntimeObject.mm:
61
62 2017-05-18  Andy Estes  <aestes@apple.com>
63
64         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
65         https://bugs.webkit.org/show_bug.cgi?id=172305
66
67         Reviewed by Anders Carlsson.
68
69         * Configurations/FeatureDefines.xcconfig:
70
71 2017-05-18  Commit Queue  <commit-queue@webkit.org>
72
73         Unreviewed, rolling out r217031, r217032, and r217037.
74         https://bugs.webkit.org/show_bug.cgi?id=172293
75
76         cause linking errors in Windows (Requested by yusukesuzuki on
77         #webkit).
78
79         Reverted changesets:
80
81         "[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass"
82         https://bugs.webkit.org/show_bug.cgi?id=172098
83         http://trac.webkit.org/changeset/217031
84
85         "Unreviewed, rebaseline for newly added ClassInfo"
86         https://bugs.webkit.org/show_bug.cgi?id=172098
87         http://trac.webkit.org/changeset/217032
88
89         "Unreviewed, fix debug and non-JIT build"
90         https://bugs.webkit.org/show_bug.cgi?id=172098
91         http://trac.webkit.org/changeset/217037
92
93 2017-05-16  Yusuke Suzuki  <utatane.tea@gmail.com>
94
95         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
96         https://bugs.webkit.org/show_bug.cgi?id=172098
97
98         Reviewed by Saam Barati.
99
100         * Plugins/Hosted/ProxyInstance.mm:
101         * Plugins/Hosted/ProxyRuntimeObject.mm:
102
103 2017-05-17  Matt Lewis  <jlewis3@apple.com>
104
105         Unreviewed, rolling out r216974.
106
107         Revision caused consistent timeouts on all platforms.
108
109         Reverted changeset:
110
111         "Add a RuntimeEnabledFeature for display: contents, defaulted
112         to false."
113         https://bugs.webkit.org/show_bug.cgi?id=171984
114         http://trac.webkit.org/changeset/216974
115
116 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
117
118         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
119         https://bugs.webkit.org/show_bug.cgi?id=171984
120
121         Reviewed by Antti Koivisto.
122
123         * WebView/WebPreferenceKeysPrivate.h:
124         * WebView/WebPreferences.mm:
125         (+[WebPreferences initialize]):
126         (-[WebPreferences displayContentsEnabled]):
127         (-[WebPreferences setDisplayContentsEnabled:]):
128         * WebView/WebPreferencesPrivate.h:
129         * WebView/WebView.mm:
130         (-[WebView _preferencesChanged:]):
131
132 2017-05-16  Sam Weinig  <sam@webkit.org>
133
134         Bring Notification.idl up to spec
135         https://bugs.webkit.org/show_bug.cgi?id=172156
136
137         Reviewed by Chris Dumez.
138
139         * WebCoreSupport/WebNotificationClient.h:
140         * WebCoreSupport/WebNotificationClient.mm:
141         (generateNotificationID):
142         (WebNotificationClient::show):
143         (WebNotificationClient::cancel):
144         (WebNotificationClient::clearNotifications):
145         (WebNotificationClient::notificationObjectDestroyed):
146         (WebNotificationClient::requestPermission):
147         (WebNotificationClient::hasPendingPermissionRequests):
148         (WebNotificationClient::checkPermission):
149         (-[WebNotificationPolicyListener allow]):
150         (-[WebNotificationPolicyListener deny]):
151         * WebView/WebNotification.mm:
152         (-[WebNotification iconURL]):
153         (-[WebNotification dir]):
154         Simplify #ifdefs and update for enum vs String usage.
155
156 2017-05-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
157
158         Do not delete asynchronously decoded frames for large images if their clients are in the viewport
159         https://bugs.webkit.org/show_bug.cgi?id=170640
160
161         Reviewed by Simon Fraser.
162
163         Enable the async decoding for large images.
164
165         * WebView/WebView.mm:
166         (-[WebView _preferencesChanged:]):
167
168 2017-05-15  Jer Noble  <jer.noble@apple.com>
169
170         Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement
171         https://bugs.webkit.org/show_bug.cgi?id=172131
172
173         Reviewed by Eric Carlson.
174
175         * WebView/WebPreferenceKeysPrivate.h:
176         * WebView/WebPreferences.mm:
177         (+[WebPreferences initialize]):
178         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
179         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
180         * WebView/WebPreferencesPrivate.h:
181
182 2017-05-12  Chris Dumez  <cdumez@apple.com>
183
184         Drop uses of PassRefPtr in WebKit/mac
185         https://bugs.webkit.org/show_bug.cgi?id=172066
186
187         Reviewed by Sam Weinig.
188
189         * History/WebBackForwardListInternal.h:
190         * History/WebHistoryItem.mm:
191         (kit):
192         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
193         * History/WebHistoryItemInternal.h:
194         * Plugins/Hosted/HostedNetscapePluginStream.h:
195         (WebKit::HostedNetscapePluginStream::create):
196         * Plugins/Hosted/NetscapePluginHostManager.h:
197         * Plugins/Hosted/NetscapePluginHostManager.mm:
198         (WebKit::NetscapePluginHostManager::instantiatePlugin):
199         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
200         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
201         (WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
202         (WebKit::NetscapePluginInstanceProxy::create):
203         (WebKit::NetscapePluginInstanceProxy::setManualStream):
204         * Plugins/Hosted/ProxyInstance.h:
205         (WebKit::ProxyInstance::create):
206         * Plugins/Hosted/ProxyInstance.mm:
207         (WebKit::ProxyInstance::ProxyInstance):
208         (WebKit::ProxyInstance::newRuntimeObject):
209         * Plugins/Hosted/ProxyRuntimeObject.h:
210         (WebKit::ProxyRuntimeObject::create):
211         * Plugins/Hosted/ProxyRuntimeObject.mm:
212         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
213         * Plugins/Hosted/WebHostedNetscapePluginView.h:
214         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
215         (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
216         * Plugins/WebBaseNetscapePluginView.h:
217         * Plugins/WebBaseNetscapePluginView.mm:
218         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
219         * Plugins/WebNetscapePluginStream.h:
220         (WebNetscapePluginStream::create):
221         * Plugins/WebNetscapePluginView.h:
222         * Plugins/WebNetscapePluginView.mm:
223         (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
224         * WebCoreSupport/WebChromeClient.mm:
225         * WebCoreSupport/WebEditorClient.mm:
226         * WebCoreSupport/WebNotificationClient.mm:
227         (WebNotificationClient::requestPermission):
228         (-[WebNotificationPolicyListener initWithCallback:]):
229         * WebCoreSupport/WebOpenPanelResultListener.mm:
230         * WebCoreSupport/WebUserMediaClient.mm:
231         (WebUserMediaClient::requestUserMediaAccess):
232         (WebUserMediaClient::enumerateMediaDevices):
233         (-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
234         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
235         * WebView/WebArchive.mm:
236         (-[WebArchivePrivate initWithCoreArchive:]):
237         (-[WebArchivePrivate setCoreArchive:]):
238         (-[WebArchive initWithData:]):
239         (-[WebArchive subframeArchives]):
240         (-[WebArchive _initWithCoreLegacyWebArchive:]):
241         * WebView/WebArchiveInternal.h:
242         * WebView/WebDataSource.mm:
243         (WebDataSourcePrivate::WebDataSourcePrivate):
244         (WebDataSourcePrivate::~WebDataSourcePrivate):
245         (-[WebDataSource _initWithDocumentLoader:]):
246         * WebView/WebDataSourceInternal.h:
247         * WebView/WebDeviceOrientation.mm:
248         (-[WebDeviceOrientation initWithCoreDeviceOrientation:]):
249         * WebView/WebDeviceOrientationInternal.h:
250         * WebView/WebFrame.mm:
251         (-[WebFrame _convertToDOMRange:]):
252         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
253         * WebView/WebFrameInternal.h:
254         * WebView/WebFullScreenController.h:
255         * WebView/WebFullScreenController.mm:
256         (-[WebFullScreenController setElement:]):
257         * WebView/WebGeolocationPosition.mm:
258         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
259         (-[WebGeolocationPosition initWithGeolocationPosition:]):
260         * WebView/WebHTMLView.mm:
261         (currentKeyboardEvent):
262         * WebView/WebResource.mm:
263         * WebView/WebScriptWorld.mm:
264         (-[WebScriptWorld initWithWorld:]):
265         (+[WebScriptWorld standardWorld]):
266         (+[WebScriptWorld findOrCreateWorld:]):
267         * WebView/WebViewData.h:
268         (LayerFlushController::create):
269
270 2017-05-11  Chris Dumez  <cdumez@apple.com>
271
272         Drop remaining uses of PassRefPtr in WebCore
273         https://bugs.webkit.org/show_bug.cgi?id=172013
274
275         Reviewed by Yusuke Suzuki.
276
277         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
278         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
279         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
280         (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
281         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
282         (-[WebHostedNetscapePluginView createPluginBindingsInstance:]):
283
284 2017-05-11  Tim Horton  <timothy_horton@apple.com>
285
286         Mail spins launching spell checker when typing
287         https://bugs.webkit.org/show_bug.cgi?id=171986
288         <rdar://problem/26305327>
289
290         Reviewed by Beth Dakin.
291
292         * WebView/WebView.mm:
293         (-[WebView setEditable:]):
294         Asynchronously pre-warm the spell checker when a WebView becomes editable.
295
296 2017-05-09  Sam Weinig  <sam@webkit.org>
297
298         Remove support for legacy Notifications
299         https://bugs.webkit.org/show_bug.cgi?id=171487
300
301         Reviewed by Jon Lee.
302
303         * Configurations/FeatureDefines.xcconfig:
304         * WebCoreSupport/WebNotificationClient.h:
305         * WebCoreSupport/WebNotificationClient.mm:
306         * WebView/WebNotification.mm:
307         * WebView/WebNotificationInternal.h:
308         * WebView/WebView.mm:
309         (-[WebView _commonInitializationWithFrameName:groupName:]):
310         (-[WebView _notificationIDForTesting:]):
311         Remove legacy notification specific code.
312
313 2017-05-10  Chris Dumez  <cdumez@apple.com>
314
315         Simplify relationship between Attr and Element now that Attr is childless
316         https://bugs.webkit.org/show_bug.cgi?id=171909
317
318         Reviewed by Ryosuke Niwa.
319
320         Build fix.
321
322         * DOM/DOMAttr.mm:
323         (-[DOMAttr value]):
324         (-[DOMAttr setValue:]):
325
326 2017-05-08  Chris Dumez  <cdumez@apple.com>
327
328         Move 'style' from Element to HTMLElement / SVGElement and make it settable
329         https://bugs.webkit.org/show_bug.cgi?id=171795
330
331         Reviewed by Alex Christensen.
332
333         Build fix.
334
335         * DOM/DOMElement.mm:
336         (-[DOMElement style]):
337         * WebCoreSupport/WebEditorClient.mm:
338         (WebEditorClient::shouldApplyStyle):
339         * WebView/WebFrame.mm:
340         (-[WebFrame _typingStyle]):
341
342 2017-05-06  Chris Dumez  <cdumez@apple.com>
343
344         Align our IDL files with the latest DOM specification
345         https://bugs.webkit.org/show_bug.cgi?id=171777
346
347         Reviewed by Sam Weinig.
348
349         Build fix.
350
351         * DOM/DOMDocument.mm:
352         (-[DOMDocument readyState]):
353
354 2017-05-05  Jeremy Jones  <jeremyj@apple.com>
355
356         REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
357         https://bugs.webkit.org/show_bug.cgi?id=171610
358         <rdar://problem/31976820>
359
360         Reviewed by Eric Carlson.
361
362         Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
363
364         * WebCoreSupport/WebChromeClient.h:
365         * WebCoreSupport/WebChromeClient.mm:
366         (WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
367
368 2017-05-04  Commit Queue  <commit-queue@webkit.org>
369
370         Unreviewed, rolling out r216206.
371         https://bugs.webkit.org/show_bug.cgi?id=171714
372
373         Multiple LayoutTests crashing in Document::page() (Requested
374         by ap on #webkit).
375
376         Reverted changeset:
377
378         "Remove support for legacy Notifications"
379         https://bugs.webkit.org/show_bug.cgi?id=171487
380         http://trac.webkit.org/changeset/216206
381
382 2017-05-04  Jeremy Jones  <jeremyj@apple.com>
383
384         UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
385         https://bugs.webkit.org/show_bug.cgi?id=171704
386
387         Reviewed by Jer Noble.
388
389         Fix build by casting result of +whiteColor to UIColor.
390
391         * WebView/WebView.mm:
392         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
393
394 2017-05-04  Sam Weinig  <sam@webkit.org>
395
396         Remove support for legacy Notifications
397         https://bugs.webkit.org/show_bug.cgi?id=171487
398
399         Reviewed by Jon Lee.
400
401         * Configurations/FeatureDefines.xcconfig:
402         * WebCoreSupport/WebNotificationClient.h:
403         * WebCoreSupport/WebNotificationClient.mm:
404         * WebView/WebNotification.mm:
405         * WebView/WebNotificationInternal.h:
406         * WebView/WebView.mm:
407         (-[WebView _commonInitializationWithFrameName:groupName:]):
408         (-[WebView _notificationIDForTesting:]):
409         Remove legacy notification specific code.
410
411 2017-05-03  Joseph Pecoraro  <pecoraro@apple.com>
412
413         [Cocoa] Stop exporting symbols for ivars that were made private
414         https://bugs.webkit.org/show_bug.cgi?id=171631
415
416         Reviewed by Dan Bernstein.
417
418         * WebKit.exp:
419
420 2017-05-01  Chris Dumez  <cdumez@apple.com>
421
422         Remove some usage of PassRefPtr in editing code
423         https://bugs.webkit.org/show_bug.cgi?id=171490
424
425         Reviewed by Darin Adler.
426
427         * WebView/WebFrame.mm:
428         (-[WebFrame dictationResultMetadataForRange:]):
429         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
430
431 2017-05-01  Beth Dakin  <bdakin@apple.com>
432
433         On-screen panel for candidate bar is in the wrong place when the caret is at the 
434         start of a paragraph
435         https://bugs.webkit.org/show_bug.cgi?id=171453
436         -and corresponding-
437         rdar://problem/29779764
438
439         Reviewed by Tim Horton.
440
441         This bug only happens when the caret is at the beginning of the paragraph, and it 
442         is because Range::absoluteTextQuads() returns no quads in this case. I think it 
443         might be correct that absoluteTextQuads() returns no quads in this case, so this 
444         patch fixes the bug at the call site by using absoluteCaretBounds() in this case.
445
446         * WebCoreSupport/WebEditorClient.mm:
447         (WebEditorClient::handleRequestedCandidates):
448
449 2017-04-30  Dan Bernstein  <mitz@apple.com>
450
451         [Cocoa] Replaces uses of [get…() alloc] with alloc…Instance()
452         https://bugs.webkit.org/show_bug.cgi?id=171485
453
454         Reviewed by Geoffrey Garen.
455
456         * WebView/WebView.mm:
457         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
458         (-[WebUITextIndicatorData initWithImage:scale:]):
459
460 2017-04-28  Youenn Fablet  <youenn@apple.com>
461
462         Adding a runtime flag specific to MediaDevices
463         https://bugs.webkit.org/show_bug.cgi?id=171433
464
465         Reviewed by Geoffrey Garen.
466
467         Adding a preference for MediaDevices.
468         Setting media devices runtime flag to false by default.
469         Setting peer connection and media stream flags to true by default.
470
471         * WebView/WebPreferenceKeysPrivate.h:
472         * WebView/WebPreferences.mm:
473         (+[WebPreferences initialize]):
474         (-[WebPreferences mediaDevicesEnabled]):
475         (-[WebPreferences setMediaDevicesEnabled:]):
476         * WebView/WebPreferencesPrivate.h:
477         * WebView/WebView.mm:
478         (-[WebView _preferencesChanged:]):
479
480 2017-04-27  Chris Dumez  <cdumez@apple.com>
481
482         Align colspan/rowspan limits with the latest HTML specification
483         https://bugs.webkit.org/show_bug.cgi?id=171322
484
485         Reviewed by Darin Adler.
486
487         ObjC bindings build fix.
488
489         * DOM/DOMHTMLTableCellElement.mm:
490         (-[DOMHTMLTableCellElement colSpan]):
491         (-[DOMHTMLTableCellElement setColSpan:]):
492
493 2017-04-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
494
495         REGRESSION(r213764): Async decoding of animated images is disabled for ImageDocument
496         https://bugs.webkit.org/show_bug.cgi?id=170333
497
498         Reviewed by Simon Fraser.
499
500         Disbale the async decoding for large images for now.
501
502         * WebView/WebView.mm:
503         (-[WebView _preferencesChanged:]):
504
505 2017-04-27  Alex Christensen  <achristensen@webkit.org>
506
507         Modernize Frame.h
508         https://bugs.webkit.org/show_bug.cgi?id=171357
509
510         Reviewed by Andy Estes.
511
512         * WebCoreSupport/WebEditorClient.h:
513         * WebCoreSupport/WebEditorClient.mm:
514         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
515
516 2017-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
517
518         [WK1] Tweak the data interaction SPI to indicate whether or not a data interaction was handled
519         https://bugs.webkit.org/show_bug.cgi?id=171369
520         <rdar://problem/31858853>
521
522         Reviewed by Dan Bernstein.
523
524         Introduce a new SPI hook intended to replace performDataInteraction:client:global:operation: that
525         returns whether or not the data interaction was handled. Due to the difference only in return type
526         and some staging constraints, this version is prefixed with "_tryTo".
527
528         * WebView/WebView.mm:
529         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
530         * WebView/WebViewPrivate.h:
531
532 2017-04-26  Wenson Hsieh  <wenson_hsieh@apple.com>
533
534         WebItemProviderPasteboard should not synchronously load provided data
535         https://bugs.webkit.org/show_bug.cgi?id=171341
536         <rdar://problem/31614010>
537
538         Reviewed by Tim Horton.
539
540         Adds client-layer plumbing for updatePreferredTypeIdentifiers. See WebCore ChangeLog for more details.
541
542         * WebCoreSupport/WebPlatformStrategies.h:
543         * WebCoreSupport/WebPlatformStrategies.mm:
544         (WebPlatformStrategies::updatePreferredTypeIdentifiers):
545
546 2017-04-26  Zalan Bujtas  <zalan@apple.com>
547
548         RTL: recent searches popover is displayed in incorrect location
549         https://bugs.webkit.org/show_bug.cgi?id=171338
550         <rdar://problem/31377807>
551
552         Reviewed by Dean Jackson.
553
554         Add RTL support for the pop-under branch.
555
556         * WebCoreSupport/PopupMenuMac.mm:
557         (PopupMenuMac::show):
558
559 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
560
561         Limit allowed size of document.title to avoid locking WebKit clients
562         https://bugs.webkit.org/show_bug.cgi?id=165113
563         <rdar://problem/28324389>
564
565         Reviewed by Darin Adler.
566
567         When a web application attempts to set an extremely long title, truncate the
568         title to a more reasonable size.
569
570         We do this at at the presentation layer, rather than in the DOM, so that we do
571         not affect script function. Instead, we merely limit display to a level that is
572         reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
573         layer, so it is a waste of effort to send across IPC.
574
575         * WebCoreSupport/WebFrameLoaderClient.h:
576         * WebCoreSupport/WebFrameLoaderClient.mm:
577         (WebFrameLoaderClient::dispatchDidReceiveTitle):
578
579 2017-04-25  Daniel Bates  <dabates@apple.com>
580
581         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
582         https://bugs.webkit.org/show_bug.cgi?id=136452
583         <rdar://problem/23412620>
584
585         Reviewed by Brent Fulgham.
586
587         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
588
589         * Configurations/FeatureDefines.xcconfig:
590
591 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
592
593         Support reading NSURL titles from the pasteboard when performing data interaction
594         https://bugs.webkit.org/show_bug.cgi?id=171156
595         <rdar://problem/31356937>
596
597         Reviewed by Tim Horton.
598
599         Add a new WK1 SPI property, -[WebFrame hasRichlyEditableDragCaret].
600
601         * WebCoreSupport/WebPlatformStrategies.h:
602         * WebCoreSupport/WebPlatformStrategies.mm:
603         (WebPlatformStrategies::readURLFromPasteboard):
604         * WebView/WebFrame.mm:
605         (-[WebFrame hasRichlyEditableDragCaret]):
606         * WebView/WebFramePrivate.h:
607
608 2017-04-24  Andy VanWagoner  <thetalecrafter@gmail.com>
609
610         Clean up ICU headers
611         https://bugs.webkit.org/show_bug.cgi?id=170997
612
613         Reviewed by JF Bastien.
614
615         Update all icu headers to 55.1
616
617         * icu/README: Explain ICU headers for OS X better
618         * icu/unicode/localpointer.h:
619         (LocalPointer::LocalPointer):
620         (LocalPointer::adoptInsteadAndCheckErrorCode):
621         * icu/unicode/platform.h:
622         * icu/unicode/putil.h:
623         * icu/unicode/uchar.h:
624         * icu/unicode/uconfig.h:
625         * icu/unicode/ucurr.h:
626         * icu/unicode/uidna.h:
627         * icu/unicode/umachine.h:
628         * icu/unicode/urename.h:
629         * icu/unicode/uscript.h:
630         * icu/unicode/ustring.h:
631         * icu/unicode/utf8.h:
632         * icu/unicode/utypes.h:
633         * icu/unicode/uvernum.h:
634
635 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
636
637         Respect fidelity order when reading web content from item providers
638         https://bugs.webkit.org/show_bug.cgi?id=171155
639         <rdar://problem/31356937>
640
641         Reviewed by Tim Horton.
642
643         Adjusts for changes in WebCore (see WebCore/ChangeLog for more details).
644
645         * WebCoreSupport/WebPlatformStrategies.h:
646         * WebCoreSupport/WebPlatformStrategies.mm:
647         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex):
648
649 2017-04-24  Alex Christensen  <achristensen@webkit.org>
650
651         Reduce copies and allocations in SharedBuffer::append
652         https://bugs.webkit.org/show_bug.cgi?id=170956
653
654         Reviewed by Andreas Kling.
655
656         * WebView/WebArchive.mm:
657         (-[WebArchive initWithData:]):
658         * WebView/WebFrame.mm:
659         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
660         * WebView/WebResource.mm:
661         (-[WebResource initWithCoder:]):
662         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
663
664 2017-04-24  Dan Bernstein  <mitz@apple.com>
665
666         [Cocoa] Some ivars are needlessly @protected
667         https://bugs.webkit.org/show_bug.cgi?id=171208
668
669         Reviewed by Anders Carlsson
670
671         Made ivars @private where possible.
672
673         * Misc/WebUserContentURLPattern.h:
674         * Plugins/WebPluginDatabase.h:
675         * Storage/WebDatabaseQuotaManager.h:
676         * WebCoreSupport/WebSecurityOriginPrivate.h:
677         * WebInspector/WebInspector.h:
678         * WebView/WebDeviceOrientation.h:
679         * WebView/WebDeviceOrientationProviderMock.h:
680         * WebView/WebGeolocationPosition.h:
681         * WebView/WebHTMLRepresentation.h:
682         * WebView/WebNotification.h:
683
684 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
685
686         Support writing link titles to the pasteboard when beginning data interaction on a link
687         https://bugs.webkit.org/show_bug.cgi?id=171154
688         <rdar://problem/31356937>
689
690         Reviewed by Andy Estes.
691
692         Adjust for some changes in WebCore to introduce a separate codepath for writing PasteboardURLs. See WebCore
693         and WebKit2 ChangeLogs for more details.
694
695         * WebCoreSupport/WebPlatformStrategies.h:
696         * WebCoreSupport/WebPlatformStrategies.mm:
697         (WebPlatformStrategies::writeToPasteboard):
698
699 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
700
701         Unreviewed, rolling out r215608.
702
703         Hundreds of test failures on GTK bot
704
705         Reverted changeset:
706
707         "Reduce copies and allocations in SharedBuffer::append"
708         https://bugs.webkit.org/show_bug.cgi?id=170956
709         http://trac.webkit.org/changeset/215608
710
711 2017-04-21  Alex Christensen  <achristensen@webkit.org>
712
713         Reduce copies and allocations in SharedBuffer::append
714         https://bugs.webkit.org/show_bug.cgi?id=170956
715
716         Reviewed by Andreas Kling.
717
718         * WebView/WebArchive.mm:
719         (-[WebArchive initWithData:]):
720         * WebView/WebFrame.mm:
721         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
722         * WebView/WebResource.mm:
723         (-[WebResource initWithCoder:]):
724         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
725
726 2017-04-20  Dewei Zhu  <dewei_zhu@apple.com>
727
728         Build fix to start using C++14.
729         https://bugs.webkit.org/show_bug.cgi?id=171038
730
731         Reviewed by Alex Christensen.
732
733         Use 'c++14' instead of 'c++11' in order to use 'auto' in lambda.
734
735         * Configurations/WebKitLegacy.xcconfig:
736
737 2017-04-19  Youenn Fablet  <youenn@apple.com>
738
739         [Mac] Allow customizing H264 encoder
740         https://bugs.webkit.org/show_bug.cgi?id=170829
741
742         Reviewed by Alex Christensen.
743
744         * Configurations/FeatureDefines.xcconfig:
745
746 2017-04-19  Anders Carlsson  <andersca@apple.com>
747
748         Stop using deprecated APIs, part 3
749         https://bugs.webkit.org/show_bug.cgi?id=171003
750         rdar://problem/31589635
751
752         Reviewed by Tim Horton.
753
754         * WebCoreSupport/WebPaymentCoordinatorClient.h:
755         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
756         (WebPaymentCoordinatorClient::cancelPaymentSession):
757         Update for WebCore changes.
758
759 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
760
761         [WK2] Support DataTransfer::files() when performing a DHTML data interaction
762         https://bugs.webkit.org/show_bug.cgi?id=170880
763         <rdar://problem/31314689>
764
765         Reviewed by Tim Horton.
766
767         Adjust for a change in PasteboardStrategy. See WebCore ChangeLog for more details.
768
769         * WebCoreSupport/WebPlatformStrategies.h:
770         * WebCoreSupport/WebPlatformStrategies.mm:
771         (WebPlatformStrategies::getFilenamesForDataInteraction):
772
773 2017-04-17  Youenn Fablet  <youenn@apple.com>
774
775         Disable outdated WritableStream API
776         https://bugs.webkit.org/show_bug.cgi?id=170749
777         <rdar://problem/31446233>
778
779         Reviewed by Alex Christensen.
780
781         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
782         - A STREAMS_API compilation flag.
783         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
784
785         * Configurations/FeatureDefines.xcconfig:
786         * WebView/WebPreferenceKeysPrivate.h:
787         * WebView/WebPreferences.mm:
788         (+[WebPreferences initialize]):
789         (-[WebPreferences readableByteStreamAPIEnabled]):
790         (-[WebPreferences setReadableByteStreamAPIEnabled:]):
791         (-[WebPreferences writableStreamAPIEnabled]):
792         (-[WebPreferences setWritableStreamAPIEnabled:]):
793         * WebView/WebPreferencesPrivate.h:
794         * WebView/WebView.mm:
795         (-[WebView _preferencesChanged:]):
796
797 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
798
799         [WK2] Support data interaction of files into file inputs
800         https://bugs.webkit.org/show_bug.cgi?id=170803
801         <rdar://problem/31286130>
802
803         Reviewed by Tim Horton.
804
805         Add boilerplate plumbing for fetching the number of files in the pasteboard.
806
807         * WebCoreSupport/WebPlatformStrategies.h:
808         * WebCoreSupport/WebPlatformStrategies.mm:
809         (WebPlatformStrategies::getNumberOfFiles):
810
811 2017-04-14  Mark Lam  <mark.lam@apple.com>
812
813         Update architectures in xcconfig files.
814         https://bugs.webkit.org/show_bug.cgi?id=170867
815         <rdar://problem/31628104>
816
817         Reviewed by Joseph Pecoraro.
818
819         * Configurations/FeatureDefines.xcconfig:
820
821 2017-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
822
823         [WK2] Support Icon creation from file URLs on iOS
824         https://bugs.webkit.org/show_bug.cgi?id=170809
825         <rdar://problem/31286130>
826
827         Reviewed by Tim Horton.
828
829         Adjust for changes in the ChromeClient in WebCore.
830
831         * WebCoreSupport/WebChromeClient.h:
832         * WebCoreSupport/WebChromeClient.mm:
833         (WebChromeClient::loadIconForFiles):
834         (WebChromeClient::createIconForFiles):
835
836 2017-04-12  Dan Bernstein  <mitz@apple.com>
837
838         [Mac] Future-proof .xcconfig files
839         https://bugs.webkit.org/show_bug.cgi?id=170802
840
841         Reviewed by Tim Horton.
842
843         * Configurations/Base.xcconfig:
844         * Configurations/DebugRelease.xcconfig:
845         * Configurations/FeatureDefines.xcconfig:
846         * Configurations/Version.xcconfig:
847
848 2017-04-12  Beth Dakin  <bdakin@apple.com>
849
850         Build fix.
851
852         * WebView/WebViewData.h:
853
854 2017-04-12  Brian Weinstein  <bweinstein@apple.com>
855
856         Should always override -[WebStorageManager init].
857         https://bugs.webkit.org/show_bug.cgi?id=170787
858         -and corresponding-
859         rdar://problem/31371835
860
861         Reviewed by Anders Carlsson.
862
863         * Storage/WebStorageManager.mm:
864         (-[WebStorageManager init]):
865
866 2017-04-12  Beth Dakin  <bdakin@apple.com>
867
868         Speculative build fix. 
869
870         * WebView/WebViewData.h:
871
872 2017-04-12  Beth Dakin  <bdakin@apple.com>
873
874         Adopt AVKit name change from AVFunctionBar* to AVTouchBar*
875         https://bugs.webkit.org/show_bug.cgi?id=170693
876         -and corresponding-
877         rdar://problem/31230018
878
879         Reviewed by Sam Weinig.
880
881         Since the new names only apply to some versions of macOS, this patch uses typedefs 
882         for the older OS’s. SO:
883
884         AVFunctionBarScrubber is now AVTouchBarScrubber
885
886         AVFunctionBarPlaybackControlsProvider is now AVTouchBarPlaybackControlsProvider
887
888         AVFunctionBarMediaSelectionOption is now AVTouchBarMediaSelectionOption
889
890         And the protocol AVFunctionBarPlaybackControlsControlling is now 
891         AVTouchBarPlaybackControlsControlling
892
893         Soft links and allocations cannot use the typedefs.
894         * WebView/WebView.mm:
895         (-[WebView updateMediaTouchBar]):
896         * WebView/WebViewData.h:
897
898 2017-04-11  Dean Jackson  <dino@apple.com>
899
900         Disable outdated WritableStream API
901         https://bugs.webkit.org/show_bug.cgi?id=170749
902         <rdar://problem/31446233>
903
904         Reviewed by Tim Horton.
905
906         The API we implement is no longer accurate. Disable it until we
907         are compatible with the new specification
908
909         * Configurations/FeatureDefines.xcconfig:
910
911 2017-04-11  Dan Bernstein  <mitz@apple.com>
912
913         [iOS] Simple HTML documents should allow non-markup JavaScript
914         https://bugs.webkit.org/show_bug.cgi?id=170734
915
916         Reviewed by Sam Weinig.
917
918         * WebView/WebView.mm:
919         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Enabled scripting
920           but disabled scripting markup.
921
922 2017-04-10  Alex Christensen  <achristensen@webkit.org>
923
924         Revert r215217
925         https://bugs.webkit.org/show_bug.cgi?id=170703
926
927         * Configurations/FeatureDefines.xcconfig:
928
929 2017-04-10  Alex Christensen  <achristensen@webkit.org>
930
931         Continue enabling WebRTC
932         https://bugs.webkit.org/show_bug.cgi?id=170703
933
934         Reviewed by Youenn Fablet.
935
936         * Configurations/FeatureDefines.xcconfig:
937
938 2017-04-10  Anders Carlsson  <andersca@apple.com>
939
940         Remove call to WKShowKeyAndMain
941         https://bugs.webkit.org/show_bug.cgi?id=170691
942         rdar://problem/31050032
943
944         Reviewed by Beth Dakin.
945
946         * Carbon/CarbonWindowAdapter.mm:
947         (-[CarbonWindowAdapter makeKeyWindow]):
948
949 2017-04-10  Jeremy Jones  <jeremyj@apple.com>
950
951         Add CoreAudioCaptureSource.
952         https://bugs.webkit.org/show_bug.cgi?id=170112
953         rdar://problem/30293338
954
955         Reviewed by Eric Carlson.
956
957         Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.
958
959         * WebView/WebPreferenceKeysPrivate.h:
960         * WebView/WebPreferences.mm:
961         (+[WebPreferences initialize]):
962         (-[WebPreferences useAVFoundationAudioCapture]):
963         (-[WebPreferences setUseAVFoundationAudioCapture:]):
964         * WebView/WebPreferencesPrivate.h:
965         * WebView/WebView.mm:
966         (-[WebView _preferencesChanged:]):
967
968 2017-04-10  Chris Dumez  <cdumez@apple.com>
969
970         Drop Timer::startOneShot() overload taking a double
971         https://bugs.webkit.org/show_bug.cgi?id=170659
972
973         Reviewed by Yusuke Suzuki.
974
975         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
976
977         * Plugins/WebNetscapePluginView.mm:
978         (PluginTimer::start):
979         * Storage/WebStorageManager.mm:
980         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
981
982 2017-04-09  Chris Dumez  <cdumez@apple.com>
983
984         Drop Timer::startRepeating() overload taking a double
985         https://bugs.webkit.org/show_bug.cgi?id=170656
986
987         Reviewed by Yusuke Suzuki.
988
989         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
990
991         * Plugins/WebNetscapePluginView.mm:
992         (PluginTimer::start):
993
994 2017-04-09  Chris Dumez  <cdumez@apple.com>
995
996         Start dropping Timer API dealing with double
997         https://bugs.webkit.org/show_bug.cgi?id=170649
998
999         Reviewed by Yusuke Suzuki.
1000
1001         Start dropping Timer API dealing with double as people should use Seconds now.
1002
1003         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1004         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1005         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1006         * Plugins/WebNetscapePluginStream.mm:
1007         (WebNetscapePluginStream::deliverData):
1008
1009 2017-04-08  Chris Dumez  <cdumez@apple.com>
1010
1011         Drop std::chrono support from Timer class
1012         https://bugs.webkit.org/show_bug.cgi?id=170645
1013
1014         Reviewed by Sam Weinig.
1015
1016         Drop std::chrono support from Timer class now that we prefer using Seconds type.
1017
1018         * WebView/WebView.mm:
1019         (+[WebView _setCacheModel:]):
1020
1021 2017-04-08  Youenn Fablet  <youenn@apple.com>
1022
1023         WebRTC tests gardening
1024         https://bugs.webkit.org/show_bug.cgi?id=170508
1025
1026         Reviewed by Eric Carlson.
1027
1028         * Configurations/FeatureDefines.xcconfig:
1029
1030 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
1031
1032         Unreviewed, rolling out r215046.
1033
1034         This change broke internal builds.
1035
1036         Reverted changeset:
1037
1038         "WebRTC tests gardening"
1039         https://bugs.webkit.org/show_bug.cgi?id=170508
1040         http://trac.webkit.org/changeset/215046
1041
1042 2017-04-06  Tim Horton  <timothy_horton@apple.com>
1043
1044         Obj-C bindings build fails with CSS_DEVICE_ADAPTATION turned on
1045         https://bugs.webkit.org/show_bug.cgi?id=170566
1046
1047         Reviewed by Simon Fraser.
1048
1049         * DOM/DOMCSS.mm:
1050         (kitClass):
1051         Use the WebCore-side enum for this, since that's actually what we're switching over.
1052         This allows us to handle values here without adding them to the API header.
1053         All of the other kitClass() functions work the same way.
1054         Also, unindent for style purposes.
1055
1056 2017-04-06  Youenn Fablet  <youenn@apple.com>
1057
1058         WebRTC tests gardening
1059         https://bugs.webkit.org/show_bug.cgi?id=170508
1060
1061         Reviewed by Eric Carlson.
1062
1063         * Configurations/FeatureDefines.xcconfig:
1064
1065 2017-04-04  Megan Gardner  <megan_gardner@apple.com>
1066
1067         Fix leaks in WebUITextIndicatorData
1068         https://bugs.webkit.org/show_bug.cgi?id=170480
1069
1070         Reviewed by Wenson Hsieh.
1071
1072         Removes extraneous retains.
1073
1074         * WebView/WebView.mm:
1075         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1076
1077 2017-04-04  Tim Horton  <timothy_horton@apple.com>
1078
1079         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
1080         https://bugs.webkit.org/show_bug.cgi?id=165801
1081         <rdar://problem/29649535>
1082
1083         Reviewed by Wenson Hsieh.
1084
1085         * WebView/WebView.mm:
1086         (incrementFrame):
1087         Adjust to the new CanWrap enum.
1088
1089 2017-03-27  Joseph Pecoraro  <pecoraro@apple.com>
1090
1091         Web Inspector: Saving files should not suggest the top level directory
1092         https://bugs.webkit.org/show_bug.cgi?id=170085
1093         <rdar://problem/30197794>
1094
1095         Reviewed by Matt Baker.
1096
1097         * WebCoreSupport/WebInspectorClient.mm:
1098         (WebInspectorFrontendClient::save):
1099         Don't set panel.directoryURL unless we have a good suggestion.
1100
1101 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1102
1103         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
1104         https://bugs.webkit.org/show_bug.cgi?id=169168
1105         <rdar://problem/30688374>
1106
1107         Reviewed by Tim Horton.
1108
1109         Refactors WebDragClient::actionMaskForDrag to take platform data only, rather than the entire DragData. See the
1110         WebCore ChangeLog entry for more details. Also renames WebDefaultUIDelegate.m to WebDefaultUIDelegate.mm, since
1111         we need to import a C++ header for linkedOnOrAfter().
1112
1113         The default delegate implementation of webView:dragDestinationActionMaskForDraggingInfo: now checks if the current
1114         application is linking against 10.12 or earlier, and if so, will allow any drag destination action instead of
1115         the new default value of everything but DragDestinationActionLoad.
1116
1117         * DefaultDelegates/WebDefaultUIDelegate.mm: Renamed from Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.m.
1118         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
1119         * Misc/WebKitVersionChecks.h:
1120         * WebCoreSupport/WebDragClient.h:
1121         * WebCoreSupport/WebDragClient.mm:
1122         (WebDragClient::actionMaskForDrag): Deleted.
1123         * WebView/WebView.mm:
1124         (-[WebView draggingEntered:]):
1125         (-[WebView draggingUpdated:]):
1126
1127 2017-03-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1128
1129         Add support for showing the platform data interaction caret
1130         https://bugs.webkit.org/show_bug.cgi?id=169898
1131         <rdar://problem/31146295>
1132
1133         Reviewed by Beth Dakin.
1134
1135         Plumb the dataInteractionCaretRect through WebView SPI to WebKit1 clients.
1136
1137         * WebView/WebView.mm:
1138         (-[WebView _dataInteractionCaretRect]):
1139         * WebView/WebViewPrivate.h:
1140
1141 2017-03-22  Dan Bernstein  <mitz@apple.com>
1142
1143         [iOS] downloadableBinaryFontsEnabled is set to false in -initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:
1144         https://bugs.webkit.org/show_bug.cgi?id=169967
1145         <rdar://problem/30406898>
1146
1147         Reviewed by Anders Carlsson.
1148
1149         * WebView/WebView.mm:
1150         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Removed call to
1151           Settings::downloadableBinaryFontsEnabled. The default is true.
1152
1153 2017-03-22  Andy Estes  <aestes@apple.com>
1154
1155         [QuickLook] Rename QuickLookHandle to PreviewLoader
1156         https://bugs.webkit.org/show_bug.cgi?id=169961
1157
1158         Reviewed by Andreas Kling.
1159
1160         * WebCoreSupport/WebFrameLoaderClient.h:
1161         * WebCoreSupport/WebFrameLoaderClient.mm:
1162         (WebFrameLoaderClient::createPreviewLoaderClient):
1163         (WebFrameLoaderClient::createQuickLookHandleClient): Deleted.
1164
1165 2017-03-21  Anders Carlsson  <andersca@apple.com>
1166
1167         Remove bogus availability annotations from DOM SPI headers.
1168         rdar://problem/31015675
1169
1170         Rubber-stamped by Dan Bernstein.
1171
1172         * DOM/DOMHTMLMediaElement.h:
1173         * DOM/DOMHTMLVideoElement.h:
1174         * DOM/DOMMediaError.h:
1175         * DOM/DOMTextEvent.h:
1176         * DOM/DOMTimeRanges.h:
1177         * DOM/DOMTokenList.h:
1178
1179 2017-03-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1180
1181         Teach TextIndicator to estimate the background color of the given Range
1182         https://bugs.webkit.org/show_bug.cgi?id=169869
1183         <rdar://problem/31127272>
1184
1185         Reviewed by Anders Carlsson and Simon Fraser.
1186
1187         Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.
1188
1189         * WebView/WebView.mm:
1190         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1191         (-[WebUITextIndicatorData dealloc]):
1192         * WebView/WebViewPrivate.h:
1193
1194 2017-03-20  Dan Bernstein  <mitz@apple.com>
1195
1196         [Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
1197         https://bugs.webkit.org/show_bug.cgi?id=169861
1198
1199         Reviewed by Sam Weinig.
1200
1201         * MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
1202         * postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the
1203           timestamp file used by the Xcode project to determine whether to run the script.
1204
1205 2017-03-19  Alexey Proskuryakov  <ap@apple.com>
1206
1207         WebHTMLView is useless as WebResourceHandler
1208         https://bugs.webkit.org/show_bug.cgi?id=169857
1209
1210         Reviewed by Dan Bernstein.
1211
1212         * WebView/WebHTMLView.mm:
1213         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1214         WebHTMLView doesnt implement any of WebResourceHandler methods.
1215
1216 2017-03-17  Michael Saboff  <msaboff@apple.com>
1217
1218         Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
1219         https://bugs.webkit.org/show_bug.cgi?id=169817
1220
1221         Reviewed by Filip Pizlo.
1222
1223         * Configurations/FeatureDefines.xcconfig:
1224
1225 2017-03-17  Antti Koivisto  <antti@apple.com>
1226
1227         Add a reload policy where only expired subresources are revalidated
1228         https://bugs.webkit.org/show_bug.cgi?id=169756
1229
1230         Reviewed by Andreas Kling.
1231
1232         * WebView/WebFrame.mm:
1233         (toWebFrameLoadType):
1234         (-[WebFrame reload]):
1235         (-[WebFrame reloadFromOrigin]):
1236
1237 2017-03-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1238
1239         [WK1] Support animated transitions when performing a data interaction operation
1240         https://bugs.webkit.org/show_bug.cgi?id=169805
1241         <rdar://problem/31045767>
1242
1243         Reviewed by Beth Dakin and Megan Gardner.
1244
1245         Adds WebKit1 support for animated transitions when performing a data interaction operation. See per-method changes
1246         for more details.
1247
1248         * DOM/DOMElement.h:
1249         * DOM/DOMElement.mm:
1250         (-[DOMElement boundsInRootViewSpace]):
1251
1252         Introduce -[DOMElement boundsInRootViewSpace], which returns the bounds of the element in root view coordinates.
1253
1254         * WebCoreSupport/WebDragClient.h:
1255         (): Deleted.
1256         * WebCoreSupport/WebDragClient.mm:
1257         (WebDragClient::didConcludeEditDrag):
1258
1259         Add boilerplate plumbing.
1260
1261         * WebView/WebView.mm:
1262         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1263
1264         Add contentImageWithoutSelection and contentImageWithoutSelectionRectInRootViewCoordinates to WebUITextIndicatorData.
1265
1266         (floatRectsForCGRectArray):
1267         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
1268
1269         Introduces a SPI helper method in WebView that clients can use to generate an image of a text platter given an
1270         image of some text, as well as clipping rects to apply to the image.
1271
1272         (-[WebView _dataOperationTextIndicator]):
1273
1274         Add SPI to fetch the text indicator used to drive animations for the current data operation.
1275
1276         (-[WebView _didConcludeEditDataInteraction]):
1277         * WebView/WebViewData.h:
1278         * WebView/WebViewInternal.h:
1279         * WebView/WebViewPrivate.h:
1280
1281 2017-03-16  Simon Fraser  <simon.fraser@apple.com>
1282
1283         Improve the system tracing points
1284         https://bugs.webkit.org/show_bug.cgi?id=169790
1285
1286         Reviewed by Zalan Bujtas.
1287
1288         Use a more cohesive set of system trace points that give a good overview of what
1289         WebKit is doing. Added points for resource loading, render tree building, sync messages
1290         to the web process, async image decode, WASM and fetching cookies.
1291
1292         * WebView/WebHTMLView.mm:
1293         (-[WebHTMLView drawRect:]):
1294
1295 2017-03-16  Youenn Fablet  <youenn@apple.com>
1296
1297         Wrap legacy WebRTC API in runtime flag
1298         https://bugs.webkit.org/show_bug.cgi?id=169646
1299
1300         Reviewed by Alex Christensen.
1301
1302         * WebView/WebPreferenceKeysPrivate.h:
1303         * WebView/WebPreferences.mm:
1304         (+[WebPreferences initialize]):
1305         (-[WebPreferences webRTCLegacyAPIEnabled]):
1306         (-[WebPreferences setWebRTCLegacyAPIEnabled:]):
1307         * WebView/WebPreferencesPrivate.h:
1308         * WebView/WebView.mm:
1309         (-[WebView _preferencesChanged:]):
1310
1311 2017-03-14  Megan Gardner  <megan_gardner@apple.com>
1312
1313         Correctly export WebItemProviderPasteboard
1314         https://bugs.webkit.org/show_bug.cgi?id=169578
1315
1316         Reviewed by Tim Horton.
1317
1318         * MigrateHeaders.make:
1319
1320 2017-03-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1321
1322         [WK2] Data interaction tests occasionally hit assertions in debug builds
1323         https://bugs.webkit.org/show_bug.cgi?id=169002
1324         <rdar://problem/30994806>
1325
1326         Reviewed by Tim Horton.
1327
1328         Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.
1329
1330         * WebView/WebHTMLView.mm:
1331         (-[WebHTMLView _updateSelectionForInputManager]):
1332         * WebView/WebView.mm:
1333         (-[WebView updateTextTouchBar]):
1334
1335 2017-03-13  Anders Carlsson  <andersca@apple.com>
1336
1337         Fix build warnings.
1338
1339         * WebCoreSupport/WebInspectorClient.mm:
1340         (WebInspectorFrontendClient::save):
1341         (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1342
1343 2017-03-11  Brady Eidson  <beidson@apple.com>
1344
1345         Cleanup "addCookie" and its sole user.
1346         https://bugs.webkit.org/show_bug.cgi?id=169486
1347
1348         Reviewed by Brian Burg.
1349
1350         * WebCoreSupport/WebPlatformStrategies.h:
1351         * WebCoreSupport/WebPlatformStrategies.mm:
1352         (WebPlatformStrategies::addCookie): Deleted.
1353
1354 2017-03-10  Alex Christensen  <achristensen@webkit.org>
1355
1356         Fix watch and tv builds after r213294
1357         https://bugs.webkit.org/show_bug.cgi?id=169508
1358
1359         Reviewed by Dan Bernstein.
1360
1361         * Configurations/FeatureDefines.xcconfig:
1362
1363 2017-03-10  Alex Christensen  <achristensen@webkit.org>
1364
1365         Fix CMake build.
1366
1367         * WebView/WebNotification.h:
1368         Don't assume we have already included something that includes NSObject.h.
1369
1370 2017-03-09  Daniel Bates  <dabates@apple.com>
1371
1372         Guard Credential Management implementation behind a runtime enabled feature flag
1373         https://bugs.webkit.org/show_bug.cgi?id=169364
1374         <rdar://problem/30957425>
1375
1376         Reviewed by Brent Fulgham.
1377
1378         Add WebKit preference for Credential Management (disabled by default).
1379
1380         * WebView/WebPreferenceKeysPrivate.h:
1381         * WebView/WebPreferences.mm:
1382         (+[WebPreferences initialize]):
1383         (-[WebPreferences credentialManagementEnabled]): Added.
1384         (-[WebPreferences setCredentialManagementEnabled:]): Added.
1385         * WebView/WebPreferencesPrivate.h:
1386         * WebView/WebView.mm:
1387         (-[WebView _preferencesChanged:]):
1388
1389 2017-03-09  Anders Carlsson  <andersca@apple.com>
1390
1391         Add delegate support to WebCore
1392         https://bugs.webkit.org/show_bug.cgi?id=169427
1393         Part of rdar://problem/28880714.
1394
1395         Reviewed by Geoffrey Garen.
1396
1397         * Configurations/FeatureDefines.xcconfig:
1398         Add feature define.
1399
1400 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
1401
1402         Fix DataInteraction guards
1403         https://bugs.webkit.org/show_bug.cgi?id=169404
1404
1405         Reviewed by Wenson Hsieh.
1406
1407         * WebCoreSupport/WebDragClient.mm:
1408
1409 2017-03-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1410
1411         Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
1412         https://bugs.webkit.org/show_bug.cgi?id=169392
1413         <rdar://problem/30882974>
1414
1415         Reviewed by Tim Horton.
1416
1417         Add a stub implementation of WebDragClient::didConcludeEditDrag.
1418
1419         * WebCoreSupport/WebDragClient.h:
1420
1421 2017-03-08  Anders Carlsson  <andersca@apple.com>
1422
1423         Simplify the PaymentCoordinator interface
1424         https://bugs.webkit.org/show_bug.cgi?id=169382
1425         Part of rdar://problem/28880714.
1426
1427         Reviewed by Tim Horton.
1428
1429         Update for PaymentCoordinatorClient changes.
1430
1431         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1432         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1433         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
1434         (WebPaymentCoordinatorClient::completeShippingContactSelection):
1435         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
1436         (WebPaymentCoordinatorClient::completePaymentSession):
1437
1438 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
1439
1440         Fix for dependency fix
1441         https://bugs.webkit.org/show_bug.cgi?id=169369
1442
1443         Reviewed by Beth Dakin.
1444
1445         * WebView/WebViewPrivate.h:
1446
1447 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
1448
1449         Fix Project Dependency
1450         https://bugs.webkit.org/show_bug.cgi?id=169340
1451
1452         Unreviewed Dependency Fix.
1453
1454         * WebView/WebViewPrivate.h:
1455
1456 2017-03-07  Alexey Proskuryakov  <ap@apple.com>
1457
1458         WebKitLegacy should re-export symbols from WebCore on watchos and tvos
1459         https://bugs.webkit.org/show_bug.cgi?id=169341
1460         <rdar://problem/30913788>
1461
1462         Reviewed by Dan Bernstein.
1463
1464         * MigrateHeaders.make:
1465
1466 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
1467
1468         Have fixedPositionCreatesStackingContext be on by default everywhere
1469         https://bugs.webkit.org/show_bug.cgi?id=169334
1470
1471         Reviewed by Zalan Bujtas.
1472
1473         It makes no sense to have web-exposed CSS functionality be different based on setting,
1474         and other browser are now aligned with having position:fixed create stacking context.
1475
1476         So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
1477         always force stacking context for position:fixed.
1478
1479         * WebView/WebView.mm:
1480         (-[WebView _preferencesChanged:]):
1481
1482 2017-03-06  Simon Fraser  <simon.fraser@apple.com>
1483
1484         Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
1485         https://bugs.webkit.org/show_bug.cgi?id=169230
1486
1487         Reviewed by Tim Horton.
1488
1489         * WebView/WebView.mm:
1490         (-[WebView _preferencesChanged:]):
1491
1492 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
1493
1494         Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
1495         https://bugs.webkit.org/show_bug.cgi?id=169329
1496
1497         Reviewed by Tim Horton.
1498
1499         If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.
1500
1501         * WebView/WebPreferences.mm:
1502         (+[WebPreferences initialize]):
1503
1504 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
1505
1506         Additional DataInteraction Support
1507         https://bugs.webkit.org/show_bug.cgi?id=169316
1508         <rdar://problem/30884234>
1509
1510         Reviewed by Wenson Hsieh.
1511
1512         Add stub implementations to WebView for methods that handle data interaction
1513
1514         * WebView/WebView.mm:
1515         (-[WebView _enteredDataInteraction:client:global:operation:]):
1516         (-[WebView _updatedDataInteraction:client:global:operation:]):
1517         (-[WebView _exitedDataInteraction:client:global:operation:]):
1518         (-[WebView _performDataInteraction:client:global:operation:]):
1519         (-[WebView _endedDataInteraction:global:]):
1520         * WebView/WebViewPrivate.h:
1521
1522 2017-03-07  Dean Jackson  <dino@apple.com>
1523
1524         Some platforms won't be able to create a GPUDevice
1525         https://bugs.webkit.org/show_bug.cgi?id=169314
1526         <rdar://problems/30907521>
1527
1528         Reviewed by Jon Lee.
1529
1530         Disable WEB_GPU on the iOS Simulator.
1531
1532         * Configurations/FeatureDefines.xcconfig:
1533
1534 2017-03-07  Maureen Daum  <mdaum@apple.com>
1535
1536         Correctly check for an empty database file.
1537         <rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
1538         https://bugs.webkit.org/show_bug.cgi?id=169256
1539
1540         Reviewed by Brady Eidson.
1541
1542         Check if the folder for an origin's WebSQL databases is empty after trying to delete
1543         all of its files. Currently we check if the deletedDatabaseFileCount matches the number
1544         of files that were in the folder. However, when we delete the actual database file in
1545         DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
1546         the database file, but deletedDatabaseFileCount only gets incremented once.
1547
1548         * Storage/WebDatabaseManager.mm:
1549         (+[WebDatabaseManager removeEmptyDatabaseFiles]):
1550         Delete the folder if it is empty.
1551
1552 2017-03-06  Michael Saboff  <msaboff@apple.com>
1553
1554         Unreviewed build fix to add
1555         -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
1556         for objective C++ files.
1557
1558         * Configurations/WebKitLegacy.xcconfig:
1559
1560 2017-03-06  Michael Saboff  <msaboff@apple.com>
1561
1562         Take advantage of fast permissions switching of JIT memory for devices that support it
1563         https://bugs.webkit.org/show_bug.cgi?id=169155
1564
1565         Reviewed by Saam Barati.
1566
1567         Updated the Xcode config files to match what is in the JavaScriptCore ones.
1568
1569         * Configurations/FeatureDefines.xcconfig:
1570
1571 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
1572
1573         Expand font-weight and font-stretch to take any number
1574         https://bugs.webkit.org/show_bug.cgi?id=168889
1575
1576         Reviewed by Simon Fraser.
1577
1578         Migrate off old enum types.
1579
1580         * WebCoreSupport/PopupMenuMac.mm:
1581         (PopupMenuMac::populate):
1582         * WebView/WebHTMLView.mm:
1583         (fontNameForDescription):
1584         * WebView/WebView.mm:
1585         (-[WebView updateTextTouchBar]):
1586
1587 2017-03-03  Dean Jackson  <dino@apple.com>
1588
1589         Add WebGPU compile flag and experimental feature flag
1590         https://bugs.webkit.org/show_bug.cgi?id=169161
1591         <rdar://problem/30846689>
1592
1593         Reviewed by Tim Horton.
1594
1595         Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
1596         and an InternalSetting.
1597
1598         * Configurations/FeatureDefines.xcconfig:
1599         * WebView/WebPreferenceKeysPrivate.h:
1600         * WebView/WebPreferences.mm:
1601         (+[WebPreferences initialize]):
1602         (-[WebPreferences webGPUEnabled]):
1603         (-[WebPreferences setWebGPUEnabled:]):
1604         * WebView/WebPreferencesPrivate.h:
1605         * WebView/WebView.mm:
1606         (-[WebView _preferencesChanged:]):
1607
1608 2017-03-03  Alexey Proskuryakov  <ap@apple.com>
1609
1610         Build fix
1611         rdar://problem/30825660
1612
1613         Suggested by Dan Bernstein.
1614
1615         * Configurations/WebKitLegacy.xcconfig:
1616
1617 2017-03-02  Sam Weinig  <sam@webkit.org>
1618
1619         Rename htmlediting.h/cpp to Editing.h/cpp
1620         https://bugs.webkit.org/show_bug.cgi?id=169103
1621
1622         Reviewed by Alex Christensen.
1623
1624         * DOM/DOMUIKitExtensions.mm:
1625         * WebView/WebFrame.mm:
1626         * WebView/WebView.mm:
1627
1628 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
1629
1630         Fix 32-bit
1631         https://bugs.webkit.org/show_bug.cgi?id=169114
1632
1633         Reviewed by Alex Christensen.
1634
1635         * WebView/WebView.mm:
1636
1637 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
1638
1639         More guard fixing
1640         https://bugs.webkit.org/show_bug.cgi?id=169112
1641
1642         Reviewed by Alex Christensen.
1643
1644         Fixed an internal build.
1645
1646         * WebView/WebView.mm:
1647         * WebView/WebViewPrivate.h:
1648
1649 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
1650
1651         Data Interaction build fixes
1652         https://bugs.webkit.org/show_bug.cgi?id=169096
1653
1654         Reviewed by Tim Horton.
1655
1656         Guards weren't all correct, also missed a selector name change.
1657
1658         * WebView/WebView.mm:
1659         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
1660         * WebView/WebViewData.h:
1661         * WebView/WebViewData.mm:
1662         (-[WebViewPrivate dealloc]):
1663
1664 2017-03-02  Alex Christensen  <achristensen@webkit.org>
1665
1666         Continue enabling WebRTC
1667         https://bugs.webkit.org/show_bug.cgi?id=169056
1668
1669         Reviewed by Jon Lee.
1670
1671         * Configurations/FeatureDefines.xcconfig:
1672
1673 2017-03-01  Megan Gardner  <megan_gardner@apple.com>
1674
1675         Data interaction support for WK1
1676         https://bugs.webkit.org/show_bug.cgi?id=169062
1677
1678         Reviewed by Wenson Hsieh.
1679
1680         Support for data interaction in WebKit1
1681
1682         * WebCoreSupport/WebDragClient.mm:
1683         * WebView/WebView.mm:
1684         (-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
1685         (-[WebUITextIndicatorData initWithImage:scale:]):
1686         (-[WebUITextIndicatorData dealloc]):
1687         (-[WebView _requestStartDataInteraction:globalPosition:]):
1688         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
1689         (-[WebView _getDataInteractionData]):
1690         * WebView/WebViewData.h:
1691         * WebView/WebViewData.mm:
1692         (-[WebViewPrivate dealloc]):
1693         * WebView/WebViewInternal.h:
1694         * WebView/WebViewPrivate.h:
1695
1696 2017-03-02  Youenn Fablet  <youenn@apple.com>
1697
1698         [WebRTC] Activate ICE candidate privacy policy
1699         https://bugs.webkit.org/show_bug.cgi?id=168975
1700
1701         Reviewed by Alex Christensen.
1702
1703         * WebView/WebPreferenceKeysPrivate.h:
1704         * WebView/WebPreferences.mm:
1705         (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
1706         (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
1707         (-[WebPreferences iceCandidateFilteringEnabled]):
1708         (-[WebPreferences setIceCandidateFilteringEnabled:]):
1709         * WebView/WebPreferencesPrivate.h:
1710
1711 2017-03-01  Alex Christensen  <achristensen@webkit.org>
1712
1713         Unreviewed, rolling out r213259.
1714
1715         Broke an internal build
1716
1717         Reverted changeset:
1718
1719         "Continue enabling WebRTC"
1720         https://bugs.webkit.org/show_bug.cgi?id=169056
1721         http://trac.webkit.org/changeset/213259
1722
1723 2017-03-01  Alex Christensen  <achristensen@webkit.org>
1724
1725         Continue enabling WebRTC
1726         https://bugs.webkit.org/show_bug.cgi?id=169056
1727
1728         Reviewed by Jon Lee.
1729
1730         * Configurations/FeatureDefines.xcconfig:
1731
1732 2017-02-27  Alex Christensen  <achristensen@webkit.org>
1733
1734         Begin enabling WebRTC on 64-bit
1735         https://bugs.webkit.org/show_bug.cgi?id=168915
1736
1737         Reviewed by Eric Carlson.
1738
1739         * Configurations/FeatureDefines.xcconfig:
1740
1741 2017-02-27  Aakash Jain  <aakash_jain@apple.com>
1742
1743         Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
1744         https://bugs.webkit.org/show_bug.cgi?id=168919
1745
1746         Reviewed by Tim Horton.
1747
1748         * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
1749         * migrate-headers.sh: Run the migrate-headers script for installapi phase.
1750
1751 2017-02-27  Alex Christensen  <achristensen@webkit.org>
1752
1753         [libwebrtc] Enable WebRTC in some Production Builds
1754         https://bugs.webkit.org/show_bug.cgi?id=168858
1755
1756         * Configurations/FeatureDefines.xcconfig:
1757
1758 2017-02-26  Alexey Proskuryakov  <ap@apple.com>
1759
1760         Don't import RetainPtr in WebNotification.h
1761         https://bugs.webkit.org/show_bug.cgi?id=168876
1762
1763         Reviewed by Dan Bernstein.
1764
1765         This is an Objective-C SPI header.
1766
1767         * WebView/WebNotification.h:
1768         * WebView/WebNotification.mm:
1769         (-[WebNotification initWithCoreNotification:notificationID:]):
1770         (-[WebNotification dealloc]):
1771
1772 2017-02-26  Aakash Jain  <aakash_jain@apple.com>
1773
1774         Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
1775         https://bugs.webkit.org/show_bug.cgi?id=168819
1776
1777         Reviewed by Dan Bernstein.
1778
1779         * Configurations/WebKitLegacy.xcconfig:
1780
1781 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1782
1783         Export Objective-C symbols for variables in Webkit SPI
1784         https://bugs.webkit.org/show_bug.cgi?id=168758
1785
1786         Reviewed by Alexey Proskuryakov.
1787
1788         * Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
1789         * WebKit.exp: Added various Objective-C symbols.
1790
1791 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1792
1793         Move instance members from WKQuadObject to implementation file
1794         https://bugs.webkit.org/show_bug.cgi?id=168740
1795
1796         Reviewed by Tim Horton.
1797
1798         * DOM/DOM.mm: Moving instance member to implementation file.
1799         * DOM/DOMExtensions.h: Ditto.
1800
1801 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1802
1803         Move iOS specific symbols to WebKit.ios.exp
1804         https://bugs.webkit.org/show_bug.cgi?id=168726
1805
1806         Reviewed by Alexey Proskuryakov.
1807
1808         * WebKit.exp:
1809
1810 2017-02-21  Youenn Fablet  <youenn@apple.com>
1811
1812         [WebRTC][Mac] Activate libwebrtc
1813         https://bugs.webkit.org/show_bug.cgi?id=167293
1814         <rdar://problem/30401864>
1815
1816         Reviewed by Alex Christensen.
1817
1818         * Configurations/FeatureDefines.xcconfig:
1819
1820 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1821
1822         Export various NSString symbols from WebFramePrivate.h
1823         https://bugs.webkit.org/show_bug.cgi?id=168702
1824
1825         Reviewed by Alexey Proskuryakov.
1826
1827         * WebKit.exp:
1828
1829 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1830
1831         Export various NSString symbols from WebPreferencesPrivate.h
1832         https://bugs.webkit.org/show_bug.cgi?id=168701
1833
1834         Reviewed by Alexey Proskuryakov.
1835
1836         * WebKit.exp:
1837
1838 2017-02-21  Joseph Pecoraro  <pecoraro@apple.com>
1839
1840         Add missing WebConsoleMessage string key
1841         https://bugs.webkit.org/show_bug.cgi?id=168690
1842
1843         Reviewed by Alexey Proskuryakov.
1844
1845         * WebKit.exp:
1846         * WebView/WebUIDelegatePrivate.h:
1847         This key has an implementation but was not extern / exported like the others.
1848
1849 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1850
1851         Export various NSString symbols from WebViewPrivate.h
1852         https://bugs.webkit.org/show_bug.cgi?id=168689
1853
1854         Reviewed by Alexey Proskuryakov.
1855
1856         * WebKit.exp:
1857
1858 2017-02-21  Commit Queue  <commit-queue@webkit.org>
1859
1860         Unreviewed, rolling out r212768.
1861         https://bugs.webkit.org/show_bug.cgi?id=168698
1862
1863         Rolling out since this would break other projects. (Requested
1864         by aakashjain on #webkit).
1865
1866         Reverted changeset:
1867
1868         "[iOS] Remove old WebKit1 MemoryMeasure helper."
1869         https://bugs.webkit.org/show_bug.cgi?id=168675
1870         http://trac.webkit.org/changeset/212768
1871
1872 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
1873
1874         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
1875         https://bugs.webkit.org/show_bug.cgi?id=168620
1876         <rdar://problem/30617772>
1877
1878         Reviewed by Tim Horton.
1879
1880         * WebView/WebPreferenceKeysPrivate.h:
1881         * WebView/WebPreferences.mm:
1882         (+[WebPreferences initialize]):
1883         (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
1884         (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
1885         * WebView/WebPreferencesPrivate.h:
1886
1887 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1888
1889         Export various NSString symbols from WebUIDelegatePrivate.h
1890         https://bugs.webkit.org/show_bug.cgi?id=168679
1891
1892         Reviewed by Joseph Pecoraro.
1893
1894         * WebKit.exp:
1895
1896 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1897
1898         Export symbols for various classes present in webkit SPI
1899         https://bugs.webkit.org/show_bug.cgi?id=168674
1900
1901         Reviewed by Dan Bernstein.
1902
1903         * WebKit.exp:
1904
1905 2017-02-21  Andreas Kling  <akling@apple.com>
1906
1907         [iOS] Remove old WebKit1 MemoryMeasure helper.
1908         <https://webkit.org/b/168675>
1909
1910         Reviewed by Sam Weinig.
1911
1912         * Configurations/WebKitLegacy.xcconfig:
1913         * Misc/WebCache.mm:
1914         (+[WebCache emptyInMemoryResources]):
1915         * WebView/WebView.mm:
1916
1917 2017-02-21  Andreas Kling  <akling@apple.com>
1918
1919         [iOS] WebKit1 should use shared memory pressure handler code.
1920         <https://webkit.org/b/168653>
1921
1922         Reviewed by Antti Koivisto.
1923
1924         Register a WebThread-aware memory callback with the shared MemoryPressureHandler
1925         and get rid of the old iOS WebKit1 specific implementation. Some of it was even
1926         dead code since MobileSafari has been using WebKit2 for quite a while.
1927
1928         * WebView/WebView.h:
1929         * WebView/WebView.mm:
1930         (WebInstallMemoryPressureHandler):
1931         (+[WebView _handleMemoryWarning]): Deleted.
1932         (+[WebView registerForMemoryNotifications]): Deleted.
1933         (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
1934         (+[WebView garbageCollectNow]): Deleted.
1935         (+[WebView purgeInactiveFontData]): Deleted.
1936         (+[WebView drainLayerPool]): Deleted.
1937         (+[WebView discardAllCompiledCode]): Deleted.
1938         (+[WebView _clearMemoryPressure]): Deleted.
1939         (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
1940         * WebView/WebViewPrivate.h:
1941
1942 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
1943
1944         Stop exporting interface WebCoreScrollView on iOS
1945         https://bugs.webkit.org/show_bug.cgi?id=168536
1946
1947         Reviewed by Dan Bernstein.
1948
1949         * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
1950         * WebKit.mac.exp: Ditto.
1951         * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
1952
1953 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
1954
1955         Exclude various mac-specific header files from iOS build
1956         https://bugs.webkit.org/show_bug.cgi?id=168621
1957
1958         Reviewed by Dan Bernstein.
1959
1960         * Configurations/WebKitLegacy.xcconfig:
1961
1962 2017-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1963
1964         Add plumbing to the UI process for TextIndicatorData when computing the drag image
1965         https://bugs.webkit.org/show_bug.cgi?id=168583
1966         Work towards <rdar://problem/30313681>
1967
1968         Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
1969
1970         Reviewed by Tim Horton.
1971
1972         * WebView/WebHTMLView.mm:
1973         (-[WebHTMLView _selectionDraggingImage]):
1974         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1975
1976 2017-02-17  Anders Carlsson  <andersca@apple.com>
1977
1978         Add a new drag code path and use it for dragging plain text
1979         https://bugs.webkit.org/show_bug.cgi?id=168534
1980
1981         Reviewed by Geoffrey Garen.
1982
1983         * WebCoreSupport/WebDragClient.h:
1984         Add new members.
1985
1986         * WebCoreSupport/WebDragClient.mm:
1987         (WebDragClient::useLegacyDragClient):
1988         Return false here.
1989
1990         (WebDragClient::beginDrag):
1991         New client member function. Create an NSDraggingItem and use it to begin a dragging session.
1992
1993         * WebView/WebHTMLView.mm:
1994         (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
1995         Get the source operation mask from WebCore.
1996
1997         (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
1998         Send a fake mouse up event.
1999
2000         * WebView/WebHTMLViewInternal.h:
2001         Declare that WebHTMLView conforms to NSDraggingSource.
2002
2003 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
2004
2005         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
2006         https://bugs.webkit.org/show_bug.cgi?id=168342
2007         rdar://problem/26182266
2008
2009         Reviewed by Tim Horton.
2010
2011         * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
2012         symbols to re-export.
2013
2014 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
2015
2016         Stop exporting DOMTokenList from WebKit
2017         https://bugs.webkit.org/show_bug.cgi?id=168544
2018
2019         Reviewed by Alexey Proskuryakov.
2020
2021         * WebKit.exp:
2022
2023 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
2024
2025         Clean up how WebKit exports _WebCreateFragment
2026         https://bugs.webkit.org/show_bug.cgi?id=168579
2027
2028         Reviewed by Dan Bernstein.
2029
2030         * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
2031         * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
2032
2033 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
2034
2035         Stop exporting DOMNodeFilter
2036         https://bugs.webkit.org/show_bug.cgi?id=168542
2037
2038         Reviewed by Alexey Proskuryakov.
2039
2040         * WebKit.exp:
2041
2042 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
2043
2044         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
2045         https://bugs.webkit.org/show_bug.cgi?id=167693
2046
2047         Reviewed by Sergio Villar Senin.
2048
2049         * Configurations/FeatureDefines.xcconfig:
2050         * WebView/WebPreferences.mm:
2051         (+[WebPreferences initialize]):
2052         * WebView/WebView.mm:
2053         (-[WebView _preferencesChanged:]):
2054
2055 2017-02-15  Brady Eidson  <beidson@apple.com>
2056
2057         Stop backing up localStorage databases to iCloud by default.
2058         <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
2059
2060         Reviewed by Geoffrey Garen.
2061
2062         * Misc/WebKitVersionChecks.h:
2063         * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
2064         (WebKitLinkedOnOrAfter):
2065         (setWebKitLinkTimeVersion):
2066         (WebKitLinkTimeVersion):
2067         (linkedOnOrAfter):
2068
2069         * Storage/WebStorageManager.mm:
2070         (WebKitInitializeStorageIfNecessary):
2071
2072 2017-02-16  Daniel Bates  <dabates@apple.com>
2073
2074         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
2075         https://bugs.webkit.org/show_bug.cgi?id=168417
2076         <rdar://problem/30541748>
2077
2078         Reviewed by Brent Fulgham.
2079
2080         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
2081         Widget* as it is always called with a valid Widget.
2082
2083         * WebCoreSupport/WebFrameLoaderClient.h:
2084         * WebCoreSupport/WebFrameLoaderClient.mm:
2085         (WebFrameLoaderClient::redirectDataToPlugin):
2086         * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
2087         as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
2088         r180570 (2 years ago) though Xcode still references this ordering file (why?).
2089
2090 2017-02-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2091
2092         [JSC] Drop PassRefPtr in inspector/
2093         https://bugs.webkit.org/show_bug.cgi?id=168420
2094
2095         Reviewed by Alex Christensen.
2096
2097         * WebView/WebScriptDebugger.mm:
2098         (WebScriptDebugger::handlePause):
2099
2100 2017-02-16  Simon Fraser  <simon.fraser@apple.com>
2101
2102         Clean up use of some CALayer-related SPI
2103         https://bugs.webkit.org/show_bug.cgi?id=168401
2104
2105         Reviewed by Tim Horton.
2106
2107         Include CALayer.h not CATiledLayer.h.
2108
2109         * WebInspector/WebNodeHighlight.h:
2110
2111 2017-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2112
2113         Fix the build after r212379
2114
2115         Rubber-stamped by Anders Carlsson.
2116
2117         * WebCoreSupport/WebDragClient.mm:
2118         (WebDragClient::startDrag):
2119
2120 2017-02-15  Anders Carlsson  <andersca@apple.com>
2121
2122         Modernize DragClient::startDrag somewhat
2123         https://bugs.webkit.org/show_bug.cgi?id=168379
2124
2125         Reviewed by Tim Horton.
2126
2127         Update for WebCore changes.
2128
2129         * WebCoreSupport/WebDragClient.h:
2130         * WebCoreSupport/WebDragClient.mm:
2131         (WebDragClient::startDrag):
2132
2133 2017-02-14  Dean Jackson  <dino@apple.com>
2134
2135         Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
2136         https://bugs.webkit.org/show_bug.cgi?id=168339
2137
2138         Reviewed by Simon Fraser.
2139
2140         Use a better name.
2141
2142         * WebView/WebPreferenceKeysPrivate.h:
2143         * WebView/WebPreferences.mm:
2144         (+[WebPreferences initialize]):
2145         (-[WebPreferences forceLowPowerGPUForWebGL]):
2146         (-[WebPreferences setForceLowPowerGPUForWebGL:]):
2147         (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
2148         (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
2149         * WebView/WebPreferencesPrivate.h:
2150         * WebView/WebView.mm:
2151         (-[WebView _preferencesChanged:]):
2152
2153 2017-02-14  Chris Dumez  <cdumez@apple.com>
2154
2155         HTML Form Validation bubble should take minimum font size setting into consideration
2156         https://bugs.webkit.org/show_bug.cgi?id=168271
2157         <rdar://problem/29869869>
2158
2159         Reviewed by Simon Fraser.
2160
2161         * WebView/WebView.mm:
2162         (-[WebView _contentsOfUserInterfaceItem:]):
2163         Return font size used in the validation bubble.
2164
2165         (-[WebView showFormValidationMessage:withAnchorRect:]):
2166         Pass minimum font size setting when constructing the validation bubble.
2167
2168 2017-02-14  Anders Carlsson  <andersca@apple.com>
2169
2170         Remove an unused delegate method
2171         https://bugs.webkit.org/show_bug.cgi?id=168328
2172
2173         Reviewed by Wenson Hsieh.
2174
2175         * DefaultDelegates/WebDefaultUIDelegate.m:
2176         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
2177
2178 2017-02-14  Alexey Proskuryakov  <ap@apple.com>
2179
2180         WebCore shouldn't export SystemMemory.h
2181         https://bugs.webkit.org/show_bug.cgi?id=168285
2182
2183         Reviewed by Alex Christensen.
2184
2185         * MigrateHeaders.make: And WebKit shouldn't re-export it.
2186
2187 2017-02-13  Alexey Proskuryakov  <ap@apple.com>
2188
2189         WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
2190         https://bugs.webkit.org/show_bug.cgi?id=168282
2191
2192         Reviewed by Dan Bernstein.
2193
2194         * MigrateHeaders.make:
2195
2196 2017-02-12  Dan Bernstein  <mitz@apple.com>
2197
2198         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
2199
2200         * WebView/WebHTMLView.mm:
2201         (createShareMenuItem): Use non-deprecated method.
2202
2203 2017-02-12  Dan Bernstein  <mitz@apple.com>
2204
2205         [Cocoa] Some -respondsToSelector: checks are unnecessary
2206         https://bugs.webkit.org/show_bug.cgi?id=168183
2207
2208         Reviewed by Tim Horton.
2209
2210         * WebView/WebFullScreenController.mm:
2211         (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
2212           responds to -isOnActiveSpace.
2213         (-[WebFullScreenController exitFullScreen]): Ditto.
2214         (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
2215           NSApplication responds to -setPresentationOptions.
2216
2217         * WebView/WebHTMLView.mm:
2218         (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
2219         (-[WebHTMLView otherMouseDown:]): Ditto.
2220
2221         * WebView/WebImmediateActionController.mm:
2222         (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
2223         (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
2224
2225         * WebView/WebView.mm:
2226         (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
2227         (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
2228
2229 2017-02-10  Daniel Bates  <dabates@apple.com>
2230
2231         Detach frame from document when entering page cache
2232         https://bugs.webkit.org/show_bug.cgi?id=166774
2233         <rdar://problem/29904368>
2234
2235         Reviewed by Chris Dumez.
2236
2237         * WebView/WebPreferenceKeysPrivate.h:
2238         * WebView/WebPreferences.mm:
2239         (+[WebPreferences initialize]):
2240         (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
2241         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
2242         * WebView/WebPreferencesPrivate.h:
2243         * WebView/WebView.mm:
2244         (-[WebView _preferencesChanged:]):
2245
2246 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
2247
2248         [Resource Timing] Enable Resource Timing by default in Tests
2249         https://bugs.webkit.org/show_bug.cgi?id=168145
2250
2251         Reviewed by Ryosuke Niwa.
2252
2253         * WebView/WebPreferenceKeysPrivate.h:
2254         * WebView/WebPreferences.mm:
2255         (+[WebPreferences initialize]):
2256         (-[WebPreferences resourceTimingEnabled]):
2257         (-[WebPreferences setResourceTimingEnabled:]):
2258         * WebView/WebPreferencesPrivate.h:
2259         * WebView/WebView.mm:
2260         (-[WebView _preferencesChanged:]):
2261
2262 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
2263
2264         cleanup WebLocalizableStrings.
2265         https://bugs.webkit.org/show_bug.cgi?id=168078
2266
2267         Reviewed by Alexey Proskuryakov.
2268
2269         * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
2270         as it's for each framework's own consumption, and never needs to be exported.
2271
2272 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
2273
2274         WebResourceLoadDelegatePrivate.h cannot be imported standalone
2275         https://bugs.webkit.org/show_bug.cgi?id=168096
2276
2277         Reviewed by Alexey Proskuryakov.
2278
2279         * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
2280
2281 2017-02-09  Antti Koivisto  <antti@apple.com>
2282
2283         Remove most cases of #if ENABLE(CACHE_PARTITIONING)
2284         https://bugs.webkit.org/show_bug.cgi?id=167990
2285
2286         Reviewed by Sam Weinig.
2287
2288         * Misc/WebCache.mm:
2289         (+[WebCache addImageToCache:forURL:forFrame:]):
2290         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2291         * WebCoreSupport/WebSystemInterface.mm:
2292         (InitWebCoreSystemInterface):
2293
2294 2017-02-07  Alexey Proskuryakov  <ap@apple.com>
2295
2296         Don't migrate WebKit DOM headers in MigrateHeaders.make
2297         https://bugs.webkit.org/show_bug.cgi?id=167608
2298
2299         Reviewed by Darin Adler.
2300
2301         Stop migrating DOM headers that are now in WebKit.
2302
2303         * DOM/DOMDOMImplementation.h: Removed.
2304         * DOM/DOMDOMImplementation.mm: Removed.
2305         * DOM/DOMDOMImplementationInternal.h: Removed.
2306         * DOM/DOMDOMTokenList.h: Removed.
2307         * DOM/DOMDOMTokenList.mm: Removed.
2308         * DOM/DOMDOMTokenListInternal.h: Removed.
2309         * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
2310         * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
2311         * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
2312         * DOM/DOMTokenList.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.h.
2313         * DOM/DOMTokenList.mm: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.mm.
2314         * DOM/DOMTokenListInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenListInternal.h.
2315         As the files are not in WebCore any more, there is no need to differentiate from
2316         WebCore internal headers with the same name. This makes it possible to make these
2317         headers private using Xcode mechanisms, as opposed to copying with a shell script.
2318
2319         * DOM/DOMElement.mm: Removed "using namespace WebCore". Other DOM implementation
2320         files don't have it.
2321
2322         * DOM/DOMCore.h:
2323         * DOM/DOMDocument.mm:
2324         * DOM/DOMHTMLAnchorElement.mm:
2325         * DOM/DOMHTMLAreaElement.mm:
2326         * DOM/DOMHTMLLinkElement.mm:
2327         * DOM/DOMUtility.mm:
2328         No more "DOMDOM".
2329
2330         * WebKit.exp:
2331         No more "DOMDOM". DOMDOMTokenList was not directly exposed via an SPI header, so
2332         renaming it is likely to be safe.
2333
2334         * MigrateHeaders.make: Don't migrate WebKit headers.
2335
2336         * Configurations/WebKitLegacy.xcconfig: Don't include two iOS specific SPI headers
2337         on macOS.
2338
2339 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
2340
2341         Don't re-export PluginData.h from WebKit
2342         https://bugs.webkit.org/show_bug.cgi?id=168020
2343
2344         Reviewed by Alexey Proskuryakov.
2345
2346         * MigrateHeaders.make: Removed PluginData.h
2347
2348 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
2349
2350         Don't re-export WKUtilities.h from WebKit
2351         https://bugs.webkit.org/show_bug.cgi?id=167977
2352
2353         Reviewed by Alexey Proskuryakov.
2354
2355         * MigrateHeaders.make: Removed WKUtilities.h
2356
2357 2017-02-06  Alex Christensen  <achristensen@webkit.org>
2358
2359         credentials should be partitioned by main document domain
2360         https://bugs.webkit.org/show_bug.cgi?id=166998
2361         rdar://problem/22901123
2362
2363         Reviewed by Brady Eidson.
2364
2365         * Misc/WebDownload.mm:
2366         * Plugins/WebBaseNetscapePluginView.mm:
2367         (WebKit::getAuthenticationInfo):
2368         Don't use partitioned credentials for WebKit1 plugins or downloads.
2369         Downloads should be authenticated before becoming a download anyways.
2370
2371 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2372
2373         Rename AnimationController to CSSAnimationController
2374         https://bugs.webkit.org/show_bug.cgi?id=167829
2375
2376         Reviewed by Simon Fraser.
2377
2378         * WebView/WebFrame.mm:
2379         * WebView/WebView.mm:
2380
2381 2017-02-03  Chris Dumez  <cdumez@apple.com>
2382
2383         Dismiss HTML form validation popover when pressing Escape key
2384         https://bugs.webkit.org/show_bug.cgi?id=167716
2385         <rdar://problem/29872943>
2386
2387         Reviewed by Simon Fraser.
2388
2389         Override ValidationMessageClient::hideAnyValidationMessage().
2390
2391         * WebCoreSupport/WebValidationMessageClient.h:
2392         * WebCoreSupport/WebValidationMessageClient.mm:
2393         (WebValidationMessageClient::hideAnyValidationMessage):
2394
2395 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2396
2397         Drag images should be anchored to the mouse location
2398         https://bugs.webkit.org/show_bug.cgi?id=167690
2399         <rdar://problem/30295261>
2400
2401         Reviewed by Enrica Casucci.
2402
2403         Adds some plumbing for the anchor point in the WK1 client layer.
2404
2405         * WebCoreSupport/WebDragClient.h:
2406         * WebCoreSupport/WebDragClient.mm:
2407         (WebDragClient::startDrag):
2408
2409 2017-02-02  Chris Dumez  <cdumez@apple.com>
2410
2411         Rename Node::inDocument() to isConnected()
2412         https://bugs.webkit.org/show_bug.cgi?id=167743
2413
2414         Reviewed by Sam Weinig.
2415
2416         Rename Node::inDocument() to isConnected() to match the DOM specification more closely:
2417         - https://dom.spec.whatwg.org/#connected
2418
2419         * DOM/DOMNode.mm:
2420         (-[DOMNode isConnected]):
2421         * WebView/WebFrame.mm:
2422         (-[WebFrame selectNSRange:onElement:]):
2423
2424 2017-02-02  Chris Dumez  <cdumez@apple.com>
2425
2426         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
2427         https://bugs.webkit.org/show_bug.cgi?id=167738
2428         <rdar://problem/30229990>
2429
2430         Reviewed by Andreas Kling.
2431
2432         The BackForwardClient no longer needs to worry about removing HistoryItems
2433         from the PageCache now that WebCore takes care of it.
2434
2435         * History/BackForwardList.mm:
2436         (BackForwardList::close):
2437
2438 2017-02-02  Yongjun Zhang  <yongjun_zhang@apple.com>
2439
2440         In iOS, we should take background assertion when accessing localstorage databases.
2441         https://bugs.webkit.org/show_bug.cgi?id=165478
2442
2443         Move database transaction background task handling code from WebDatabaseManager to
2444         WebCore's WebSQLiteDatabaseTrackerClient.
2445
2446         Reviewed by Brady Eidson.
2447
2448         * Storage/WebDatabaseManager.mm:
2449         * Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.
2450         * WebCoreSupport/WebApplicationCache.mm:
2451         (+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.
2452         * WebView/WebView.mm:
2453         (-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.
2454
2455 2017-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2456
2457         [WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
2458         https://bugs.webkit.org/show_bug.cgi?id=167695
2459         <rdar://problem/30305390>
2460
2461         Reviewed by Sam Weinig.
2462
2463         Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
2464         exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
2465         is destroyed.
2466
2467         * WebView/WebView.mm:
2468         (-[WebView _commonInitializationWithFrameName:groupName:]):
2469
2470 2017-01-31  Joseph Pecoraro  <pecoraro@apple.com>
2471
2472         ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
2473         https://bugs.webkit.org/show_bug.cgi?id=167684
2474
2475         Reviewed by Dan Bernstein.
2476
2477         * DOM/DOMHTML.mm:
2478         (-[DOMHTMLInputElement _isAutofilled]): Deleted.
2479         (-[DOMHTMLInputElement _setAutofilled:]): Deleted.
2480         Consolidate in the WebDOMOperationsPrivate category.
2481
2482         * DOM/DOMPrivate.h:
2483         Include WebDOMOperationsPrivate header to get other DOM Private categories.
2484
2485         * DOM/WebDOMOperations.mm:
2486         (-[DOMHTMLInputElement _isAutofilled]):
2487         * DOM/WebDOMOperationsPrivate.h:
2488         Include getter alongside the setter.
2489
2490 2017-01-31  Jessie Berlin  <jberlin@webkit.org>
2491
2492         Build fix.
2493
2494         * Misc/WebNSPasteboardExtras.mm:
2495         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2496         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2497         * WebView/WebHTMLView.mm:
2498         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2499         (-[WebHTMLView copyFont:]):
2500
2501 2017-01-30  Andy Estes  <aestes@apple.com>
2502
2503         [QuickLook] FrameLoaderClient should return the new QuickLookHandleClient it creates
2504         https://bugs.webkit.org/show_bug.cgi?id=167625
2505
2506         Reviewed by Andreas Kling.
2507
2508         * WebCoreSupport/WebFrameLoaderClient.h: Declared createQuickLookHandleClient().
2509         * WebCoreSupport/WebFrameLoaderClient.mm:
2510         (WebFrameLoaderClient::createQuickLookHandleClient): Renamed from didCreateQuickLookHandle().
2511         (WebFrameLoaderClient::didCreateQuickLookHandle): Renamed to createQuickLookHandleClient().
2512
2513 2017-01-30  Chris Dumez  <cdumez@apple.com>
2514
2515         Drop legacy Attributes.isId attribute
2516         https://bugs.webkit.org/show_bug.cgi?id=167603
2517
2518         Reviewed by Ryosuke Niwa.
2519
2520         Keep Attr.isId in ObjC bindings.
2521
2522         * DOM/DOMAttr.mm:
2523         (-[DOMAttr isId]):
2524
2525 2017-01-30  Andreas Kling  <akling@apple.com>
2526
2527         [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.
2528         <https://webkit.org/b/167580>
2529
2530         Reviewed by Antti Koivisto.
2531
2532         Avoid the implicit strong capture of self by keeping it in a __block variable.
2533         Also add code to dealloc to unregister the event monitor, since it will otherwise leak.
2534         This fixes huge WebHTMLView leaks seen on the leaks bot.
2535
2536         * WebView/WebHTMLView.mm:
2537         (-[WebHTMLViewPrivate dealloc]):
2538         (-[WebHTMLView viewDidMoveToWindow]):
2539
2540 2017-01-29  Andy Estes  <aestes@apple.com>
2541
2542         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2543         https://bugs.webkit.org/show_bug.cgi?id=167563
2544         <rdar://problem/30253207>
2545
2546         Reviewed by Andreas Kling.
2547
2548         Instead of only saving QuickLook documents to a temporary file when the client is
2549         MobileSafari, base this decision on a WebPreference that clients can choose to enable.
2550
2551         This also changes the SPI for accessing the temporary file path and UTI. Instead of
2552         -[WebView quickLookContentForURL:], which requires the client to pass the response URL of
2553         the frame that saved the QuickLook document, the content dictionary is now stored as a
2554         property of WebDataSource.
2555
2556         This also removes the manual lifetime management of the QLPreviewConverter from
2557         QuickLookDocumentWriter. The QLPreviewConverter is kept alive by DocumentLoader these days,
2558         which ensures it lives long enough to respond to subresource requests.
2559
2560         New API test: QuickLook.LegacyQuickLookContent
2561
2562         * WebCoreSupport/WebFrameLoaderClient.mm:
2563         (WebFrameLoaderClient::didCreateQuickLookHandle): Moved the logic of deciding whether to
2564         write a temporary file to here from the QuickLookDocumentWriter constructor.
2565         * WebView/WebDataSource.mm: Declared _quickLookContent.
2566         (-[WebDataSource _quickLookContent]):
2567         (-[WebDataSource _setQuickLookContent:]):
2568         * WebView/WebDataSourceInternal.h: Overrode _quickLookContent as a read/write property.
2569         * WebView/WebDataSourcePrivate.h: Declared _quickLookContent as a readonly property.
2570         * WebView/WebPreferenceKeysPrivate.h: Defined WebKitQuickLookDocumentSavingPreferenceKey.
2571         * WebView/WebPreferences.mm:
2572         (-[WebPreferences quickLookDocumentSavingEnabled]):
2573         (-[WebPreferences setQuickLookDocumentSavingEnabled:]):
2574         * WebView/WebPreferencesPrivate.h: Declared property quickLookDocumentSavingEnabled.
2575         * WebView/WebView.mm:
2576         (-[WebView quickLookContentForURL:]): Changed to always return nil.
2577         * WebView/WebViewPrivate.h: Added a comment stating that clients should use
2578         -[WebDataSource _quickLookContent] instead.
2579
2580 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2581
2582         Add Link Preload as an off-by-default experimental feature menu item.
2583         https://bugs.webkit.org/show_bug.cgi?id=167201
2584
2585         Reviewed by Ryosuke Niwa.
2586
2587         * WebView/WebPreferenceKeysPrivate.h:
2588         * WebView/WebPreferences.mm:
2589         (-[WebPreferences linkPreloadEnabled]):
2590         (-[WebPreferences setLinkPreloadEnabled:]):
2591         * WebView/WebPreferencesPrivate.h:
2592         * WebView/WebView.mm:
2593         (-[WebView _preferencesChanged:]):
2594
2595 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2596
2597         Add User Timing Experimental Feature
2598         https://bugs.webkit.org/show_bug.cgi?id=167542
2599         <rdar://problem/22746307>
2600
2601         Reviewed by Ryosuke Niwa.
2602
2603         * WebView/WebPreferenceKeysPrivate.h:
2604         * WebView/WebPreferences.mm:
2605         (+[WebPreferences initialize]):
2606         (-[WebPreferences userTimingEnabled]):
2607         (-[WebPreferences setUserTimingEnabled:]):
2608         * WebView/WebPreferencesPrivate.h:
2609         * WebView/WebView.mm:
2610         (-[WebView _preferencesChanged:]):
2611         Add setting for User Timing runtime enabled feature.
2612
2613 2017-01-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2614
2615         [WK1] Do not prevent the drag client from initializing on Mac
2616         https://bugs.webkit.org/show_bug.cgi?id=167541
2617
2618         Reviewed by Dan Bernstein.
2619
2620         Fixes fallout from r211192. To ensure compability with WebKit clients, we need to ensure that WebDragClient is
2621         initialized everywhere when creating a WebView. Stub out method implementations as no-ops for non-Mac platforms.
2622         This caused certain clients, such as Mail, to crash when a webView closes due to  null dereference.
2623
2624         * WebCoreSupport/WebDragClient.mm:
2625         (WebDragClient::WebDragClient):
2626         (WebDragClient::actionMaskForDrag):
2627         (WebDragClient::willPerformDragDestinationAction):
2628         (WebDragClient::dragSourceActionMaskForPoint):
2629         (WebDragClient::willPerformDragSourceAction):
2630         (WebDragClient::startDrag):
2631         (WebDragClient::declareAndWriteDragImage):
2632         (WebDragClient::declareAndWriteAttachment):
2633         * WebView/WebView.mm:
2634         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2635
2636 2017-01-26  Chris Dumez  <cdumez@apple.com>
2637
2638         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2639         https://bugs.webkit.org/show_bug.cgi?id=167421
2640         <rdar://problem/30188490>
2641
2642         Reviewed by Darin Adler.
2643
2644         Add a new setting allowing layout tests to enable PageCache in a window
2645         that has an opener, for convenience.
2646
2647         * WebView/WebPreferenceKeysPrivate.h:
2648         * WebView/WebPreferences.mm:
2649         (+[WebPreferences initialize]):
2650         (-[WebPreferences allowsPageCacheWithWindowOpener]):
2651         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]):
2652         * WebView/WebPreferencesPrivate.h:
2653         * WebView/WebView.mm:
2654         (-[WebView _preferencesChanged:]):
2655
2656 2017-01-26  Keith Miller  <keith_miller@apple.com>
2657
2658         classInfo should take a VM so it is not materialized from the object on each call
2659         https://bugs.webkit.org/show_bug.cgi?id=167424
2660
2661         Rubber Stamped by Michael Saboff.
2662
2663         Previously, classInfo() would get the VM from the target's
2664         MarkedBlock.  Most callers already have a VM on hand, so it is
2665         wasteful to compute the VM from the marked block every time. This
2666         patch refactors some of the most common callers of classInfo(),
2667         jsDynamicCast and inherits to take a VM as well.
2668
2669         * DOM/DOM.mm:
2670         (+[DOMNode _nodeFromJSWrapper:]):
2671         * DOM/DOMUtility.mm:
2672         (createDOMWrapper):
2673         * DOM/WebDOMOperations.mm:
2674         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2675         (WebKit::getObjectID):
2676         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
2677         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
2678         * Plugins/Hosted/ProxyInstance.mm:
2679         (WebKit::ProxyRuntimeMethod::finishCreation):
2680         (WebKit::ProxyInstance::invokeMethod):
2681         * Plugins/Hosted/ProxyRuntimeObject.mm:
2682         (WebKit::ProxyRuntimeObject::finishCreation):
2683         * WebView/WebFrame.mm:
2684         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2685         * WebView/WebView.mm:
2686         (+[WebView _reportException:inContext:]):
2687         (aeDescFromJSValue):
2688         (-[WebView _notificationIDForTesting:]):
2689
2690 2017-01-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2691
2692         REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar in HTML Notes
2693         https://bugs.webkit.org/show_bug.cgi?id=167472
2694         <rdar://problem/30149809>
2695
2696         Reviewed by Beth Dakin.
2697
2698         Revision 207483 caused the touch bar to stop showing up in HTML Notes due to -updateTextTouchBar not
2699         initializing the text touch bar and causing -makeTouchBar to return nil while processing a mouse click. The
2700         purpose of bailing out of the update was to prevent the text touch bar from thrashing during a selection drag.
2701         If the text touch bar doesn't exist yet, we don't have to worry about its appearance flickering from a different
2702         previous state, so we should just allow the touch bar to update instead.
2703
2704         * WebView/WebView.mm:
2705         (-[WebView updateTextTouchBar]):
2706
2707 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2708
2709         Crash when setting custom scale factor.
2710         https://bugs.webkit.org/show_bug.cgi?id=167369
2711
2712         Reviewed by Sam Weinig.
2713
2714         Add null pointer check.
2715
2716         * WebView/WebView.mm:
2717         (-[WebView _setCustomBackingScaleFactor:]):
2718
2719 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2720
2721         Refactor drag and drop implementation on Mac
2722         https://bugs.webkit.org/show_bug.cgi?id=167427
2723
2724         Reviewed by Enrica Casucci.
2725
2726         Refactor some WebKit1 code on the Mac pertaining to drag and drop. See WebCore ChangeLog for more details.
2727
2728         * Misc/WebNSPasteboardExtras.h:
2729         * WebCoreSupport/WebDragClient.mm:
2730         * WebView/WebFrame.mm:
2731         * WebView/WebFrameInternal.h:
2732         * WebView/WebHTMLView.mm:
2733         * WebView/WebView.mm:
2734         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2735
2736 2017-01-24  Youenn Fablet  <youennf@gmail.com>
2737
2738         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
2739         https://bugs.webkit.org/show_bug.cgi?id=167294
2740
2741         Reviewed by Alex Christensen.
2742
2743         * WebView/WebView.mm:
2744         (-[WebView _commonInitializationWithFrameName:groupName:]):
2745
2746 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2747
2748         Add support for named pasteboards, pasteboard strategies and platform pasteboards
2749         https://bugs.webkit.org/show_bug.cgi?id=167404
2750
2751         Reviewed by Enrica Casucci.
2752
2753         Adds pasteboard name as an argument to pasteboard-related WebPlatformStrategy methods.
2754
2755         * WebCoreSupport/WebPlatformStrategies.h:
2756         * WebCoreSupport/WebPlatformStrategies.mm:
2757         (WebPlatformStrategies::writeToPasteboard):
2758         (WebPlatformStrategies::getPasteboardItemsCount):
2759         (WebPlatformStrategies::readBufferFromPasteboard):
2760         (WebPlatformStrategies::readURLFromPasteboard):
2761         (WebPlatformStrategies::readStringFromPasteboard):
2762
2763 2017-01-25  Aakash Jain  <aakash_jain@apple.com>
2764
2765         LoadWebLocalizedStrings method should be moved in correct file
2766         https://bugs.webkit.org/show_bug.cgi?id=167393
2767
2768         Reviewed by Alexey Proskuryakov.
2769
2770         * Misc/WebLocalizableStrings.h: Deleted LoadWebLocalizedStrings method.
2771         * Misc/WebLocalizableStrings.mm:
2772         (LoadWebLocalizedStringsTimerCallback): Deleted, moved to WebUIKitSupport.mm
2773         (LoadWebLocalizedStrings): Deleted, moved to WebUIKitSupport.mm
2774
2775 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2776
2777         Add simple line layout toggle to MiniBrowser
2778         https://bugs.webkit.org/show_bug.cgi?id=167405
2779
2780         Reviewed by Andreas Kling.
2781
2782         * WebView/WebPreferenceKeysPrivate.h:
2783         * WebView/WebPreferences.mm:
2784         (+[WebPreferences initialize]):
2785         (-[WebPreferences simpleLineLayoutEnabled]):
2786         (-[WebPreferences setSimpleLineLayoutEnabled:]):
2787         * WebView/WebPreferencesPrivate.h:
2788         * WebView/WebView.mm:
2789         (-[WebView _preferencesChanged:]):
2790
2791 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2792
2793         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2794         https://bugs.webkit.org/show_bug.cgi?id=167394
2795
2796         Reviewed by Ryosuke Niwa.
2797
2798         * Configurations/FeatureDefines.xcconfig:
2799
2800 2017-01-23  Chris Dumez  <cdumez@apple.com>
2801
2802         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
2803         https://bugs.webkit.org/show_bug.cgi?id=167308
2804         <rdar://problem/30144964>
2805
2806         Unreviewed, do a partial revert of r211033 to fix assertion.
2807
2808         * WebCoreSupport/WebChromeClient.h:
2809         * WebCoreSupport/WebChromeClient.mm:
2810         (WebChromeClient::exitFullScreenForElement):
2811
2812 2017-01-23  Joseph Pecoraro  <pecoraro@apple.com>
2813
2814         Remove allowWindowOpenWithoutUserGesture setting
2815         https://bugs.webkit.org/show_bug.cgi?id=167301
2816
2817         Reviewed by Darin Adler.
2818
2819         * WebView/WebView.mm:
2820         (-[WebView _preferencesChanged:]):
2821         Use the equivalent existing setting.
2822
2823 2017-01-20  Darin Adler  <darin@apple.com>
2824
2825         Remove PassRefPtr from "page" directory of WebCore, also deploy references
2826         https://bugs.webkit.org/show_bug.cgi?id=167224
2827
2828         Reviewed by Chris Dumez.
2829
2830         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
2831         (-[WebApplicationCacheQuotaManager quota]): Pass reference.
2832
2833         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
2834         * WebCoreSupport/WebChromeClient.mm:
2835         (WebChromeClient::focusedElementChanged): Ditto.
2836         (WebChromeClient::createWindow): Ditto.
2837         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
2838         (WebChromeClient::runJavaScriptAlert): Ditto.
2839         (WebChromeClient::runJavaScriptConfirm): Ditto.
2840         (WebChromeClient::runJavaScriptPrompt): Ditto.
2841         (WebChromeClient::contentsSizeChanged): Ditto.
2842         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
2843         (WebChromeClient::print): Ditto.
2844         (WebChromeClient::exceededDatabaseQuota): Ditto.
2845         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
2846         (WebChromeClient::createColorChooser): Ditto.
2847         (WebChromeClient::elementDidFocus): Ditto.
2848         (WebChromeClient::elementDidBlur): Ditto.
2849         (WebChromeClient::createPopupMenu): Ditto.
2850         (WebChromeClient::createSearchPopupMenu): Ditto.
2851         (WebChromeClient::attachRootGraphicsLayer): Ditto.
2852         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
2853         (WebChromeClient::supportsFullScreenForElement): Ditto.
2854         (WebChromeClient::enterFullScreenForElement): Ditto.
2855         (WebChromeClient::exitFullScreenForElement): Ditto.
2856
2857         * WebView/WebFrame.mm:
2858         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
2859         Updated for change to the appendChild function.
2860
2861 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
2862
2863         Remove -[WebFrame sendOrientationChangeEvent:] which is unused
2864         https://bugs.webkit.org/show_bug.cgi?id=167276
2865
2866         Reviewed by Alex Christensen.
2867         
2868         It was usurped by -deviceOrientationChanged in 2014.
2869
2870         * WebView/WebFrame.mm:
2871         (-[WebFrame sendOrientationChangeEvent:]): Deleted.
2872         * WebView/WebFramePrivate.h:
2873
2874 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
2875
2876         Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
2877         https://bugs.webkit.org/show_bug.cgi?id=167271
2878
2879         Reviewed by Alex Christensen.
2880         
2881         -_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
2882         overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),
2883
2884         * WebView/WebView.mm:
2885         (-[WebView _contentsSizeRespectingOverflow]): Deleted.
2886         * WebView/WebViewPrivate.h:
2887
2888 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2889
2890         Remove never changing IndexedDB RuntimeEnabledFeature
2891         https://bugs.webkit.org/show_bug.cgi?id=167278
2892
2893         Reviewed by Darin Adler.
2894
2895         * WebView/WebView.mm:
2896         (-[WebView _preferencesChanged:]):
2897
2898 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2899
2900         Cleanup RuntimeEnabledFeatures
2901         https://bugs.webkit.org/show_bug.cgi?id=167228
2902
2903         Reviewed by Simon Fraser.
2904
2905         * WebView/WebView.mm:
2906         (-[WebView _preferencesChanged:]):
2907
2908 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2909
2910         Remove outdated ENABLE(CSP_NEXT) build flag
2911         https://bugs.webkit.org/show_bug.cgi?id=167252
2912
2913         Reviewed by Brent Fulgham.
2914
2915         * Configurations/FeatureDefines.xcconfig:
2916
2917 2017-01-20  Antoine Quint  <graouts@apple.com>
2918
2919         [Modern Media Controls] Turn modern media controls on by default
2920         https://bugs.webkit.org/show_bug.cgi?id=165668
2921
2922         Reviewed by Dean Jackson.
2923
2924         Enabled modern media controls by default in WK1.
2925
2926         * WebView/WebPreferences.mm:
2927         (+[WebPreferences initialize]):
2928
2929 2017-01-19  Chris Dumez  <cdumez@apple.com>
2930
2931         iterable<> should be enabled on WK1
2932         https://bugs.webkit.org/show_bug.cgi?id=167221
2933         <rdar://problem/30108531>
2934
2935         Reviewed by Youenn Fablet.
2936
2937         * WebView/WebPreferenceKeysPrivate.h:
2938         * WebView/WebPreferences.mm:
2939         (-[WebPreferences setCustomElementsEnabled:]):
2940         (-[WebPreferences DOMIteratorEnabled]): Deleted.
2941         (-[WebPreferences setDOMIteratorEnabled:]): Deleted.
2942         * WebView/WebPreferencesPrivate.h:
2943         * WebView/WebView.mm:
2944         (-[WebView _preferencesChanged:]):
2945
2946 2017-01-19  Chris Dumez  <cdumez@apple.com>
2947
2948         Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
2949         https://bugs.webkit.org/show_bug.cgi?id=167215
2950         <rdar://problem/29885052>
2951
2952         Reviewed by Andreas Kling.
2953
2954         Make sure HTML validation bubble gets dismissed when its associated
2955         element's frame gets detached and that we do not crash.
2956
2957         * WebCoreSupport/WebValidationMessageClient.h:
2958         * WebCoreSupport/WebValidationMessageClient.mm:
2959         (WebValidationMessageClient::documentDetached):
2960
2961 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2962
2963         [Cocoa] Variation fonts are erroneously disabled on iOS
2964         https://bugs.webkit.org/show_bug.cgi?id=167172
2965
2966         Reviewed by Simon Fraser.
2967
2968         OpenSource builders don't seem to understand sdk=embedded*.
2969
2970         * Configurations/FeatureDefines.xcconfig:
2971
2972 2017-01-19  Andreas Kling  <akling@apple.com>
2973
2974         ScriptExecutionContext::topOrigin() should return a reference.
2975         <https://webkit.org/b/167190>
2976
2977         Reviewed by Sam Weinig.
2978
2979         * Misc/WebCache.mm:
2980         (+[WebCache addImageToCache:forURL:forFrame:]):
2981         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2982
2983 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2984
2985         Unreviewed fix for the macOS build.
2986
2987         * Carbon/CarbonWindowAdapter.mm:
2988         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2989
2990 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2991
2992         Unreviewed, rolling out r210848.
2993
2994         This change introduced media-related LayoutTest failures and
2995         crashes on macOS.
2996
2997         Reverted changeset:
2998
2999         "[Modern Media Controls] Turn modern media controls on by
3000         default"
3001         https://bugs.webkit.org/show_bug.cgi?id=165668
3002         http://trac.webkit.org/changeset/210848
3003
3004 2017-01-18  Andreas Kling  <akling@apple.com>
3005
3006         Document::securityOrigin() should return a reference.
3007         <https://webkit.org/b/167124>
3008
3009         Reviewed by Sam Weinig.
3010
3011         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3012         (WebKit::NetscapePluginInstanceProxy::loadRequest):
3013         * Plugins/WebNetscapePluginStream.mm:
3014         (WebNetscapePluginStream::WebNetscapePluginStream):
3015         * Plugins/WebNetscapePluginView.mm:
3016         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3017         * Plugins/WebPluginContainerCheck.mm:
3018         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3019         * WebCoreSupport/WebChromeClient.mm:
3020         (WebChromeClient::exceededDatabaseQuota):
3021         * WebCoreSupport/WebFrameLoaderClient.h:
3022         * WebCoreSupport/WebFrameLoaderClient.mm:
3023         (WebFrameLoaderClient::didRunInsecureContent):
3024         * WebCoreSupport/WebGeolocationClient.mm:
3025         (WebGeolocationClient::requestPermission):
3026         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
3027         * WebView/WebFrame.mm:
3028         (-[WebFrame _allowsFollowingLink:]):
3029
3030 2017-01-18  Antoine Quint  <graouts@apple.com>
3031
3032         [Modern Media Controls] Turn modern media controls on by default
3033         https://bugs.webkit.org/show_bug.cgi?id=165668
3034
3035         Reviewed by Dean Jackson.
3036
3037         Enabled modern media controls by default in WK1. 
3038
3039         * WebView/WebPreferences.mm:
3040         (+[WebPreferences initialize]):
3041
3042 2017-01-15  Darin Adler  <darin@apple.com>
3043
3044         Remove PassRefPtr from "loader" directory of WebCore
3045         https://bugs.webkit.org/show_bug.cgi?id=167055
3046
3047         Reviewed by Alex Christensen.
3048
3049         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
3050         Also made class final and most functions private and final.
3051         * WebCoreSupport/WebChromeClient.mm:
3052         (WebChromeClient::runOpenPanel): Updated to take references.
3053
3054         * WebCoreSupport/WebEditorClient.h: Updated for changes to EditorClient.
3055         * WebCoreSupport/WebEditorClient.mm:
3056         (-[WebUndoStep initWithUndoStep:]): Take reference instead of PassRefPtr.
3057         (+[WebUndoStep stepWithUndoStep:]): Ditto.
3058         (-[WebUndoStep step]): Return reference instead of pointer.
3059         (-[WebEditorUndoTarget undoEditing:]): Updated for the above.
3060         (-[WebEditorUndoTarget redoEditing:]): Ditto.
3061         (WebEditorClient::registerUndoOrRedoStep): Take reference instead of
3062         PassRefPtr.
3063         (WebEditorClient::registerUndoStep): Ditto.
3064         (WebEditorClient::registerRedoStep): Ditto.
3065
3066         * WebCoreSupport/WebFrameLoaderClient.h: Updated for changes to
3067         FrameLoaderClient, marked functions final instead of override.
3068         * WebCoreSupport/WebFrameLoaderClient.mm:
3069         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Take
3070         pointer instead of PassRefPtr.
3071         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
3072         (makeFormFieldValuesDictionary): Take a reference.
3073         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Take Ref&& instead
3074         of PassRefPtr.
3075         (WebFrameLoaderClient::dispatchWillSubmitForm): Take a reference instead
3076         of PassRefPtr.
3077         (WebFrameLoaderClient::actionDictionary): Take a pointer instead of PassRePtr.
3078         (WebFrameLoaderClient::createFrame): Take a reference instead of a pointer.
3079         (WebFrameLoaderClient::createPlugin): Ditto.
3080         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
3081         (WebFrameLoaderClient::createNetworkingContext): Ditto.
3082         (WebFrameLoaderClient::didCreateQuickLookHandle): Pass a reference.
3083
3084         * WebCoreSupport/WebFrameNetworkingContext.h: Use Ref instead of PassRefPtr.
3085         * WebCoreSupport/WebFrameNetworkingContext.mm: Tweak style a bit.
3086
3087         * WebCoreSupport/WebOpenPanelResultListener.h: Take a reference instead of
3088         PassRefPtr. Use RefPtr for class field.
3089         * WebCoreSupport/WebOpenPanelResultListener.mm:
3090         (-[WebOpenPanelResultListener dealloc]): Deleted. Compiler will now do it
3091         correctly without us declaring anything explicitly.
3092         (-[WebOpenPanelResultListener cancel]): Get rid of hand-written deref code,
3093         and let RefPtr do the work.
3094         (-[WebOpenPanelResultListener chooseFilename:]): Ditto.
3095         (-[WebOpenPanelResultListener chooseFilenames:]): Ditto.
3096         (-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]):
3097         Rewrote to use a modern Objective-C for loop, reserveInitialCapacity,
3098         and uncheckedAppend.
3099
3100         * WebView/WebArchive.mm:
3101         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
3102         Updated for changes to LegacyWebArchive.
3103         (-[WebArchive mainResource]): Ditto.
3104         (-[WebArchive subresources]): Ditto.
3105         (-[WebArchive subframeArchives]): Ditto.
3106
3107         * WebView/WebDataSource.mm:
3108         (-[WebDataSource _addSubframeArchives:]): Use a modern Objective-C for loop
3109         instead of NSEnumerator.
3110         (-[WebDataSource _fileWrapperForURL:]): Use auto.
3111         (-[WebDataSource _documentFragmentWithArchive:]): Pass a reference.
3112         (-[WebDataSource mainResource]): Ditto.
3113         (-[WebDataSource subresources]): Ditto.
3114         (-[WebDataSource subresourceForURL:]): Ditto.
3115         (-[WebDataSource addSubresource:]): Ditto.
3116
3117         * WebView/WebResource.mm:
3118         (-[WebResourcePrivate initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
3119         (-[WebResourcePrivate dealloc]): Remove explicit deref since RefPtr will now take
3120         care of it
3121         (-[WebResource initWithCoder:]): Pass a reference.
3122         (-[WebResource encodeWithCoder:]): Updated since coreResource is now RefPtr.
3123         (-[WebResource _initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
3124         (-[WebResource _coreResource]): Return reference rather than pointer.
3125         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
3126         Added code to handle the null case and pass a reference rather than a pointer.
3127         * WebView/WebResourceInternal.h: Updated for the above.
3128
3129 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3130
3131         Unreviewed, rolling out r210834
3132         https://bugs.webkit.org/show_bug.cgi?id=165668
3133
3134         It introduced dozens of test timeouts.
3135
3136         Reverted changeset:
3137         "[Modern Media Controls] Turn modern media controls on by default"
3138         https://bugs.webkit.org/show_bug.cgi?id=165668
3139         http://trac.webkit.org/changeset/210834
3140
3141 2017-01-17  Antoine Quint  <graouts@apple.com>
3142
3143         [Modern Media Controls] Turn modern media controls on by default
3144         https://bugs.webkit.org/show_bug.cgi?id=165668
3145
3146         Reviewed by Dean Jackson.
3147
3148         Enabled modern media controls by default in WK1. 
3149
3150         * WebView/WebPreferences.mm:
3151         (+[WebPreferences initialize]):
3152
3153 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
3154
3155         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
3156         https://bugs.webkit.org/show_bug.cgi?id=116551
3157         <rdar://problem/13949830>
3158
3159         Reviewed by Alex Christensen.
3160
3161         * Configurations/FeatureDefines.xcconfig:
3162
3163 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
3164
3165         Crash when closing tab with debugger paused
3166         https://bugs.webkit.org/show_bug.cgi?id=161746
3167         <rdar://problem/15607819>
3168
3169         Reviewed by Brian Burg and Brent Fulgham.
3170
3171         * WebView/WebView.mm:
3172         (WebKit::DeferredPageDestructor::createDeferredPageDestructor):
3173         (WebKit::DeferredPageDestructor::DeferredPageDestructor):
3174         (WebKit::DeferredPageDestructor::tryDestruction):
3175         (-[WebView _close]):
3176         Defer destruction of the Page if we are in a nested runloop.
3177
3178 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
3179
3180         Remove the REQUEST_ANIMATION_FRAME flag
3181         https://bugs.webkit.org/show_bug.cgi?id=156980
3182         <rdar://problem/25906849>
3183
3184         Reviewed by Simon Fraser.
3185
3186         * Configurations/FeatureDefines.xcconfig:
3187
3188 2017-01-16  Andy Estes  <aestes@apple.com>
3189
3190         [QuickLook] Do some cleanup in QuickLookHandle
3191         https://bugs.webkit.org/show_bug.cgi?id=166864
3192
3193         Reviewed by Darin Adler.
3194
3195         * WebCoreSupport/WebFrameLoaderClient.mm:
3196         (WebFrameLoaderClient::didCreateQuickLookHandle): Changed to pass a
3197         Ref<QuickLookHandleClient>&& to QuickLookHandle::setClient().
3198
3199 2017-01-15  Tim Horton  <timothy_horton@apple.com>
3200
3201         De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
3202         https://bugs.webkit.org/show_bug.cgi?id=167063
3203
3204         Reviewed by Dan Bernstein.
3205
3206         * WebView/WebHTMLView.mm:
3207         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3208         (-[WebHTMLView _updateFontPanel]):
3209         * WebView/WebView.mm:
3210         (-[WebView typingAttributes]):
3211         Adjust to fontAttributesForSelectionStart returning a RetainPtr.
3212
3213 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
3214
3215         Remove ENABLE(DETAILS_ELEMENT) guards
3216         https://bugs.webkit.org/show_bug.cgi?id=167042
3217
3218         Reviewed by Alex Christensen.
3219
3220         * Configurations/FeatureDefines.xcconfig:
3221
3222 2017-01-11  Darin Adler  <darin@apple.com>
3223
3224         Remove PassRefPtr from more of "platform"
3225         https://bugs.webkit.org/show_bug.cgi?id=166809
3226
3227         Reviewed by Sam Weinig.
3228
3229         * WebCoreSupport/WebFrameLoaderClient.mm:
3230         (NetscapePluginWidget::handleEvent): Pass a reference.
3231         * WebView/WebView.mm:
3232         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
3233         Updated since the children set now contains Ref instead of RefPtr.
3234
3235 2017-01-13  Sam Weinig  <sam@webkit.org>
3236
3237         [WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent
3238         https://bugs.webkit.org/show_bug.cgi?id=167006
3239
3240         Reviewed by Geoffrey Garen.
3241
3242         * WebView/WebDeviceOrientation.mm:
3243         (convert):
3244         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
3245         Update for new use of std::optional.
3246
3247 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
3248
3249         Remove unnecessary includes of Page.h
3250         https://bugs.webkit.org/show_bug.cgi?id=166996
3251
3252         Reviewed by Yusuke Suzuki.
3253
3254         * DOM/DOMHTML.mm:
3255         * History/WebBackForwardList.mm:
3256         * Plugins/WebPluginController.mm:
3257         * WebCoreSupport/WebNotificationClient.mm:
3258         * WebCoreSupport/WebPlatformStrategies.mm:
3259         * WebCoreSupport/WebUserMediaClient.mm:
3260         * WebView/WebFullScreenController.mm:
3261
3262 2017-01-12  Chris Dumez  <cdumez@apple.com>
3263
3264         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3265         https://bugs.webkit.org/show_bug.cgi?id=166995
3266
3267         Reviewed by Jer Noble.
3268
3269         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3270         as some people are having trouble building without it.
3271
3272         * Configurations/FeatureDefines.xcconfig:
3273
3274 2017-01-12  Chris Dumez  <cdumez@apple.com>
3275
3276         HTML form validation popover sometimes does not go away
3277         https://bugs.webkit.org/show_bug.cgi?id=166990
3278         <rdar://problem/29985957>
3279
3280         Reviewed by Tim Horton.
3281
3282         Update code using ValidationBubble now that it is RefCounted.
3283
3284         * WebView/WebView.mm:
3285         (-[WebView showFormValidationMessage:withAnchorRect:]):
3286
3287 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3288
3289         Remove pointerLockElement from DOMDocumentPrivate.h
3290         https://bugs.webkit.org/show_bug.cgi?id=166882
3291
3292         Reviewed by Simon Fraser.
3293
3294         Removed pointerLockElement declaration that was supposed to be removed in r209637.
3295
3296         * DOM/DOMDocumentPrivate.h:
3297
3298 2017-01-06  Darin Adler  <darin@apple.com>
3299
3300         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
3301         https://bugs.webkit.org/show_bug.cgi?id=166797
3302
3303         Reviewed by Alex Christensen.
3304
3305         * WebCoreSupport/WebEditorClient.h: Updated to take a reference.
3306         * WebCoreSupport/WebEditorClient.mm:
3307         (WebEditorClient::requestCheckingOfString): Take a reference
3308         instead of a PassRefPtr.
3309
3310 2017-01-05  Chris Dumez  <cdumez@apple.com>
3311
3312         Turn preferLowPowerWebGLRendering setting on by default
3313         https://bugs.webkit.org/show_bug.cgi?id=166737
3314         <rdar://problem/29870033>
3315
3316         Reviewed by Dean Jackson.
3317
3318         Temporarily turn preferLowPowerWebGLRendering setting on by default until
3319         we deal better with WebGL content in background tabs.
3320
3321         * WebView/WebPreferences.mm:
3322         (+[WebPreferences initialize]):
3323
3324 2017-01-05  Enrica Casucci  <enrica@apple.com>
3325
3326         Support File Promise during drag for macOS.
3327         https://bugs.webkit.org/show_bug.cgi?id=165204
3328         rdar://problem/19595567
3329
3330         Reviewed by Tim Horton.
3331
3332         Adds support for dropping a File Promise in a WebView.
3333         The implementation uses new File Promise API available in Sierra.
3334
3335         * Misc/WebNSPasteboardExtras.mm:
3336         (+[NSPasteboard _web_dragTypesForURL]):
3337         * WebView/WebView.mm:
3338         (-[WebView performDragOperation:]):
3339
3340 2017-01-05  Andreas Kling  <akling@apple.com>
3341
3342         Remove ChromeClient::needTouchEvents().
3343         <https://webkit.org/b/166723>
3344
3345         Rubber-stamped by Antti Koivisto.
3346
3347         * WebCoreSupport/WebChromeClient.h:
3348
3349 2017-01-04  Darin Adler  <darin@apple.com>
3350
3351         Remove PassRefPtr use from the "html" directory, other improvements
3352         https://bugs.webkit.org/show_bug.cgi?id=166635
3353
3354         Reviewed by Alex Christensen.
3355
3356         * WebCoreSupport/WebChromeClient.h:
3357         * WebCoreSupport/WebChromeClient.mm:
3358         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
3359
3360 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
3361
3362         Unreviewed, rolling out r210287.
3363
3364         This change caused editing test failures on macOS.
3365
3366         Reverted changeset:
3367
3368         "Support File Promise during drag for macOS."
3369         https://bugs.webkit.org/show_bug.cgi?id=165204
3370         http://trac.webkit.org/changeset/210287
3371
3372 2017-01-04  Enrica Casucci  <enrica@apple.com>
3373
3374         Support File Promise during drag for macOS.
3375         https://bugs.webkit.org/show_bug.cgi?id=165204
3376         rdar://problem/19595567
3377
3378         Reviewed by Tim Horton.
3379
3380         Adds support for dropping a File Promise in a WebView.
3381         The implementation uses new File Promise API available in Sierra.
3382
3383         * Misc/WebNSPasteboardExtras.mm:
3384         (+[NSPasteboard _web_dragTypesForURL]):
3385         * WebView/WebView.mm:
3386         (-[WebView performDragOperation:]):
3387
3388 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3389
3390         Provide a setting for clients to always prefer low-power WebGL
3391         https://bugs.webkit.org/show_bug.cgi?id=166675
3392         <rdar://problem/29834093>
3393
3394         Reviewed by Dan Bernstein.
3395
3396         * WebView/WebPreferenceKeysPrivate.h:
3397         * WebView/WebPreferences.mm:
3398         (+[WebPreferences initialize]):
3399         (-[WebPreferences preferLowPowerWebGLRendering]):
3400         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
3401         * WebView/WebPreferencesPrivate.h:
3402         * WebView/WebView.mm:
3403         (-[WebView _preferencesChanged:]):
3404         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
3405
3406 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3407
3408         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3409         https://bugs.webkit.org/show_bug.cgi?id=166450
3410         <rdar://problem/29447824>
3411
3412         Reviewed by Darin Adler.
3413
3414         * WebCoreSupport/CorrectionPanel.h:
3415         * WebCoreSupport/CorrectionPanel.mm:
3416         (CorrectionPanel::recordAutocorrectionResponse):
3417         (CorrectionPanel::handleAcceptedReplacement):
3418         * WebCoreSupport/WebAlternativeTextClient.mm:
3419         (toCorrectionResponse):
3420         (WebAlternativeTextClient::recordAutocorrectionResponse):
3421         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3422         through recordAutocorrectionResponse, for debugging's sake.
3423         Drop the NSView parameter because we don't need it, just the tag.
3424         Convert the new AutocorrectionResponseType value to its corresponding
3425         NSCorrectionResponse value.
3426
3427 2017-01-01  Jeff Miller  <jeffm@apple.com>
3428
3429         Update user-visible copyright strings to include 2017
3430         https://bugs.webkit.org/show_bug.cgi?id=166278
3431
3432         Reviewed by Dan Bernstein.
3433
3434         * Info.plist:
3435
3436 2016-12-30  Darin Adler  <darin@apple.com>
3437
3438         Remove PassRefPtr use from the "dom" directory, related cleanup
3439         https://bugs.webkit.org/show_bug.cgi?id=166569
3440
3441         Reviewed by Alex Christensen.
3442
3443         * WebCoreSupport/WebFrameLoaderClient.mm:
3444         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
3445         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
3446         (WebFrameLoaderClient::setTitle): Ditto.
3447         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
3448         * WebView/WebFrame.mm:
3449         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
3450         Not needed now, but useful later if we ever can get rid of the explicit constructors.
3451         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
3452         * WebView/WebHTMLRepresentation.mm:
3453         (-[WebHTMLRepresentation title]): Updated to use struct.
3454
3455 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
3456
3457         Propagate the source origin as much as possible
3458         https://bugs.webkit.org/show_bug.cgi?id=166348
3459
3460         Reviewed by Darin Adler.
3461
3462         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3463         (WebKit::NetscapePluginInstanceProxy::evaluate):
3464
3465 2016-12-23  Andy Estes  <aestes@apple.com>
3466
3467         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
3468         https://bugs.webkit.org/show_bug.cgi?id=166471
3469
3470         Reviewed by Andreas Kling.
3471
3472         When DumpRenderTree starts up, it calls
3473         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
3474         builds, this triggers the ASSERT(isMainThread()) in
3475         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
3476         started, we are on the main thread, and we are not holding the Web thread lock. This is
3477         causing all layout tests to crash in the iOS WK1 Debug configuration.
3478
3479         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
3480         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
3481
3482 2016-12-22  Andy Estes  <aestes@apple.com>
3483
3484         Make WebCore::EditorInsertAction an enum class
3485         https://bugs.webkit.org/show_bug.cgi?id=166424
3486
3487         Reviewed by Brent Fulgham.
3488
3489         * WebCoreSupport/WebEditorClient.mm:
3490         (kit):
3491
3492 2016-12-21  Beth Dakin  <bdakin@apple.com>
3493
3494         Holding down on candidates in the TouchBar should show panel on screen
3495         https://bugs.webkit.org/show_bug.cgi?id=166367
3496         -and corresponding-
3497         <rdar://problem/28479236>
3498
3499         Reviewed by Tim Horton.
3500
3501         Stray whitespace.
3502         * WebCoreSupport/WebEditorClient.mm:
3503         (WebEditorClient::handleRequestedCandidates):
3504
3505         Call the version of setCandidates: that takes a rect. We need to keep the helper 
3506         function in WK1 (unlike WK2) since we also use it for testing.
3507         * WebView/WebView.mm:
3508         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3509
3510 2016-12-20  Dean Jackson  <dino@apple.com>
3511
3512         Remove INDIE_UI
3513         https://bugs.webkit.org/show_bug.cgi?id=165881
3514         <rdar://problem/29672532>
3515
3516         Reviewed by Simon Fraser.
3517
3518         The Indie UI work has been discontinued.
3519
3520         * Configurations/FeatureDefines.xcconfig:
3521
3522 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3523
3524         [ES6] Enable ES6 Modules
3525         https://bugs.webkit.org/show_bug.cgi?id=165849
3526
3527         Reviewed by Geoffrey Garen.
3528
3529         * WebView/WebPreferenceKeysPrivate.h:
3530         * WebView/WebPreferences.mm:
3531         (+[WebPreferences initialize]):
3532         (-[WebPreferences es6ModulesEnabled]): Deleted.
3533         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
3534         * WebView/WebPreferencesPrivate.h:
3535         * WebView/WebView.mm:
3536         (-[WebView _preferencesChanged:]):
3537
3538 2016-12-16  Dave Hyatt  <hyatt@apple.com>
3539
3540         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
3541         https://bugs.webkit.org/show_bug.cgi?id=165968
3542
3543         Reviewed by Andreas Kling.
3544
3545         * DOM/DOMCSS.mm:
3546         (kitClass):
3547         * DOM/DOMCSSPrimitiveValue.mm:
3548         (-[DOMCSSPrimitiveValue getCounterValue]):
3549         (-[DOMCSSPrimitiveValue getRectValue]):
3550         (kit):
3551         * DOM/DOMCSSPrimitiveValueInternal.h:
3552         * DOM/DOMCSSStyleDeclaration.mm:
3553         * DOM/DOMCSSValue.mm:
3554         (kit):
3555         * DOM/DOMCSSValueInternal.h:
3556         * DOM/DOMCSSValueList.mm:
3557         * DOM/DOMCounter.mm:
3558         (kit):
3559         * DOM/DOMCounterInternal.h:
3560         * DOM/DOMRGBColor.mm:
3561         (kit):
3562         * DOM/DOMRGBColorInternal.h:
3563         * DOM/DOMRect.mm:
3564         (kit):
3565         * DOM/DOMRectInternal.h:
3566         * DOM/DOMUtility.mm:
3567         (createDOMWrapper):
3568
3569 2016-12-16  Chris Dumez  <cdumez@apple.com>
3570
3571         HTML form validation bubble should be dismissed on navigation
3572         https://bugs.webkit.org/show_bug.cgi?id=165960
3573         <rdar://problem/29668086>
3574
3575         Reviewed by Simon Fraser.
3576
3577         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
3578
3579         * WebView/WebView.mm:
3580         (-[WebView _didStartProvisionalLoadForFrame:]):
3581
3582 2016-12-15  Darin Adler  <darin@apple.com>
3583
3584         Use asString instead of toWTFString, toString, or getString when we already checked isString
3585         https://bugs.webkit.org/show_bug.cgi?id=165895
3586
3587         Reviewed by Yusuke Suzuki.
3588
3589         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3590         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
3591         toWTFString.
3592         * WebView/WebView.mm:
3593         (aeDescFromJSValue): Use asString/value instead of getString.
3594
3595 2016-12-15  Chris Dumez  <cdumez@apple.com>
3596
3597         Make sure HTML validation bubble's state is updated after layout
3598         https://bugs.webkit.org/show_bug.cgi?id=165922
3599         <rdar://problem/29694730>
3600
3601         Reviewed by Simon Fraser.
3602
3603         Make sure HTML validation bubble's state is updated after layout.
3604         In particular, if the validation bubble's associated element has
3605         moved or is no longer visible, we now hide the bubble.
3606
3607         * WebCoreSupport/WebValidationMessageClient.h:
3608         * WebCoreSupport/WebValidationMessageClient.mm:
3609         (WebValidationMessageClient::showValidationMessage):
3610         (WebValidationMessageClient::hideValidationMessage):
3611         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
3612
3613 2016-12-15  Chris Dumez  <cdumez@apple.com>
3614
3615         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
3616         https://bugs.webkit.org/show_bug.cgi?id=165904
3617
3618         Reviewed by Sam Weinig.
3619
3620         Update ObjC bindings so they keep building.
3621
3622         * DOM/DOMUIEvent.mm:
3623         (-[DOMUIEvent keyCode]):
3624         (-[DOMUIEvent charCode]):
3625
3626 2016-12-15  Andreas Kling  <akling@apple.com>
3627
3628         Always clear RenderLayer backing stores when going into page cache.
3629         <https://webkit.org/b/165901>
3630
3631         Reviewed by Simon Fraser.
3632
3633         * WebView/WebView.mm:
3634         (+[WebView _setCacheModel:]):
3635
3636 2016-12-12  Alex Christensen  <achristensen@webkit.org>
3637
3638         Remove unused workaround for Silverlight
3639         https://bugs.webkit.org/show_bug.cgi?id=165773
3640
3641         Reviewed by Dean Jackson.
3642
3643         * Plugins/WebNetscapePluginView.mm:
3644         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
3645         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
3646         Allowing 6 years for users to update Silverlight is more than enough.
3647         Safari doesn't even use WebKit1 for this any more.
3648         I need this to be removed because this is the only non-WebGL code that needs to link against
3649         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
3650
3651 2016-12-12  Chris Dumez  <cdumez@apple.com>
3652
3653         Document.visibilityState should use an IDL string enumeration
3654         https://bugs.webkit.org/show_bug.cgi?id=165774
3655
3656         Reviewed by Daniel Bates.
3657
3658         * DOM/DOMDocument.mm:
3659         (-[DOMDocument visibilityState]):
3660         * WebView/WebView.mm:
3661         (kit):
3662
3663 2016-12-12  Jer Noble  <jer.noble@apple.com>
3664
3665         Remove implementation of legacy Mozilla-based Fullscreen API.
3666         https://bugs.webkit.org/show_bug.cgi?id=165689
3667         <rdar://problem/29603053>
3668
3669         Reviewed by Eric Carlson.
3670
3671         * DOM/DOMElement.mm:
3672         (-[DOMElement webkitRequestFullScreen:]):
3673
3674 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
3675
3676         The DOM should have an advancing wavefront opaque root barrier
3677         https://bugs.webkit.org/show_bug.cgi?id=165712
3678
3679         Reviewed by Yusuke Suzuki.
3680         
3681         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
3682
3683         * Misc/WebCoreStatistics.mm:
3684         (+[WebCoreStatistics javaScriptObjectsCount]):
3685         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
3686         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
3687         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
3688         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
3689         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
3690         (+[WebCoreStatistics shouldPrintExceptions]):
3691         (+[WebCoreStatistics setShouldPrintExceptions:]):
3692         (+[WebCoreStatistics memoryStatistics]):
3693         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
3694         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3695         (identifierFromIdentifierRep):
3696         * Plugins/Hosted/ProxyInstance.mm:
3697         (WebKit::ProxyInstance::getPropertyNames):
3698         * Plugins/WebNetscapePluginStream.mm:
3699         (WebNetscapePluginStream::wantsAllStreams):
3700         * Plugins/WebNetscapePluginView.mm:
3701         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
3702         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
3703         (-[WebNetscapePluginView setWindowIfNecessary]):
3704         (-[WebNetscapePluginView createPluginScriptableObject]):
3705         (-[WebNetscapePluginView getFormValue:]):
3706         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
3707         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
3708         (-[WebNetscapePluginView loadPluginRequest:]):
3709         (-[WebNetscapePluginView _printedPluginBitmap]):
3710         * Plugins/WebPluginController.mm:
3711         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
3712         (-[WebPluginController stopOnePlugin:]):
3713         (-[WebPluginController stopOnePluginForPageCache:]):
3714         (-[WebPluginController destroyOnePlugin:]):
3715         (-[WebPluginController startAllPlugins]):
3716         (-[WebPluginController addPlugin:]):
3717
3718 2016-12-09  Dave Hyatt  <hyatt@apple.com>
3719
3720         [CSS Parser] Remove the old CSS Parser
3721         https://bugs.webkit.org/show_bug.cgi?id=165645
3722
3723         Reviewed by Daniel Bates.
3724
3725         * DOM/DOMCSS.mm:
3726         (kitClass):
3727         * DOM/DOMCSSRule.h:
3728
3729 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3730
3731         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3732         https://bugs.webkit.org/show_bug.cgi?id=165251
3733
3734         Reviewed by Dean Jackson.
3735
3736         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3737
3738         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
3739         * WebView/WebPreferences.mm:
3740         (+[WebPreferences initialize]):
3741         (-[WebPreferences mediaStreamEnabled]):
3742         (-[WebPreferences setMediaStreamEnabled:]):
3743         (-[WebPreferences peerConnectionEnabled]):
3744         (-[WebPreferences setPeerConnectionEnabled:]):
3745         * WebView/WebPreferencesPrivate.h:
3746         * WebView/WebView.mm:
3747         (-[WebView _preferencesChanged:]):
3748
3749 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
3750
3751         Don’t expose pointer lock in WebKit1 Objective-C API
3752         https://bugs.webkit.org/show_bug.cgi?id=165692
3753
3754         Reviewed by Simon Fraser.
3755
3756         * DOM/DOMDocument.mm:
3757         (-[DOMDocument pointerLockElement]): Deleted.
3758         (-[DOMDocument exitPointerLock]): Deleted.
3759         * DOM/DOMElement.mm:
3760         (-[DOMElement requestPointerLock]): Deleted.
3761         * DOM/DOMMouseEvent.mm:
3762         (-[DOMMouseEvent movementX]): Deleted.
3763         (-[DOMMouseEvent movementY]): Deleted.
3764
3765 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
3766
3767         document.webkitFullscreenElement leaks elements inside a shadow tree
3768         https://bugs.webkit.org/show_bug.cgi?id=158471
3769
3770         Reviewed by Chris Dumez.
3771
3772         Use the API for bindings to avoid exposing nodes inside a shadow tree.
3773
3774         * DOM/DOMDocument.mm:
3775         (-[DOMDocument webkitCurrentFullScreenElement]):
3776         (-[DOMDocument webkitFullscreenElement]):
3777
3778 2016-12-09  Beth Dakin  <bdakin@apple.com>
3779
3780         Password fields should not show the emoji button in TouchBar
3781         https://bugs.webkit.org/show_bug.cgi?id=165673
3782         -and corresponding-
3783         rdar://problem/29235739
3784
3785         Reviewed by Wenson Hsieh.
3786
3787         This patch adds a new ivar for the password touch bar and password 
3788         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
3789         of identifiers than the plain text TouchBar, it should just have its own variable.
3790
3791         The candidate list should be the only item for passwords.
3792         * WebView/WebView.mm:
3793         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
3794
3795         Account for _passwordTextTouchBar.
3796         (-[WebView didChangeAutomaticTextCompletion:]):
3797         (-[WebView setUpTextTouchBar:]):
3798         (-[WebView textTouchBar]):
3799
3800         The empty candidates array is not needed. We can just set @[ ] as the candidates 
3801         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
3802         other parts of the code to prevent us from requesting or setting other candidates 
3803         when in a password field. 
3804         (-[WebView updateTextTouchBar]):
3805
3806         Account for _passwordTextTouchBar.
3807         (-[WebView candidateList]):
3808         * WebView/WebViewData.h:
3809
3810 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3811
3812         Enable SharedArrayBuffer, remove the flag
3813         https://bugs.webkit.org/show_bug.cgi?id=165614
3814
3815         Rubber stamped by Geoffrey Garen.
3816
3817         * WebView/WebPreferencesPrivate.h:
3818
3819 2016-12-07  Dean Jackson  <dino@apple.com>
3820
3821         Remove runtime toggle for pointer-lock
3822         https://bugs.webkit.org/show_bug.cgi?id=165577
3823         <rdar://problems/29566996>
3824
3825         Reviewed by Jon Lee.
3826
3827         Remove any runtime calls to check if pointer-lock is enabled. It's
3828         either compiled in or out.
3829
3830         * WebView/WebPreferenceKeysPrivate.h:
3831         * WebView/WebPreferences.mm:
3832         (-[WebPreferences pointerLockEnabled]): Deleted.
3833         (-[WebPreferences setPointerLockEnabled:]): Deleted.
3834         * WebView/WebPreferencesPrivate.h:
3835         * WebView/WebView.mm:
3836         (-[WebView _preferencesChanged:]):
3837
3838 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
3839
3840         Correct SDKROOT values in xcconfig files
3841         https://bugs.webkit.org/show_bug.cgi?id=165487
3842         rdar://problem/29539209
3843
3844         Reviewed by Dan Bernstein.
3845
3846         Fix suggested by Dan Bernstein.
3847
3848         * Configurations/DebugRelease.xcconfig:
3849
3850 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
3851
3852         Improve the behavior of scroll-into-view when the target is inside position:fixed
3853         https://bugs.webkit.org/show_bug.cgi?id=165354
3854
3855         Reviewed by Zalan Bujtas.
3856
3857         Plumb through 'insideFixed'. We don't get compute it, so behavior from
3858         these call sites won't change.
3859
3860         * WebView/WebFrame.mm:
3861         (-[WebFrame _scrollDOMRangeToVisible:]):
3862         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
3863
3864 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
3865
3866         Enable visual viewports by default on Mac, and iOS Wk2
3867         https://bugs.webkit.org/show_bug.cgi?id=165452
3868
3869         Reviewed by Zalan Bujtas.
3870
3871         Turn visual viewports on by default for WK1 on Mac.
3872
3873         * WebView/WebPreferences.mm:
3874         (+[WebPreferences initialize]):
3875
3876 2016-12-05  Dean Jackson  <dino@apple.com>
3877
3878         pointer lock needs to be feature detectable
3879         https://bugs.webkit.org/show_bug.cgi?id=165426
3880         <rdar://problem/29486715>
3881
3882         Reviewed by Antoine Quint.
3883
3884         Set the RuntimeEnabledFeature as preferences
3885         change.
3886
3887         * WebView/WebView.mm:
3888         (-[WebView _preferencesChanged:]):
3889
3890 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
3891
3892         Unreviewed, rolling out r209299.
3893
3894         This change appears to have caused LayoutTest failures on
3895         Sierra WK1.
3896
3897         Reverted changeset:
3898
3899         "Improve the behavior of scroll-into-view when the target is
3900         inside position:fixed"
3901         https://bugs.webkit.org/show_bug.cgi?id=165354
3902         http://trac.webkit.org/changeset/209299
3903
3904 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
3905
3906         Improve the behavior of scroll-into-view when the target is inside position:fixed
3907         https://bugs.webkit.org/show_bug.cgi?id=165354
3908
3909         Reviewed by Zalan Bujtas.
3910
3911         Plumb through 'insideFixed'. We don't get compute it, so behavior from
3912         these call sites won't change.
3913
3914         * WebView/WebFrame.mm:
3915         (-[WebFrame _scrollDOMRangeToVisible:]):
3916         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
3917
3918 2016-12-02  Andy Estes  <aestes@apple.com>
3919
3920         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
3921         https://bugs.webkit.org/show_bug.cgi?id=164492
3922
3923         Reviewed by Dan Bernstein.
3924
3925         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
3926         com.apple.$(PRODUCT_NAME:rfc1034identifier).
3927         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
3928         ${PRODUCT_BUNDLE_IDENTIFIER}.
3929
3930 2016-12-02  Chris Dumez  <cdumez@apple.com>
3931
3932         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
3933         https://bugs.webkit.org/show_bug.cgi?id=165328
3934
3935         Reviewed by Simon Fraser.
3936
3937         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
3938
3939         * WebView/WebViewData.mm:
3940         (-[WebViewPrivate init]):
3941
3942 2016-12-02  Chris Dumez  <cdumez@apple.com>
3943
3944         [Mac][WK1] Implement new HTML interactive form validation user interface
3945         https://bugs.webkit.org/show_bug.cgi?id=164483
3946
3947         Reviewed by Simon Fraser.
3948
3949         Implement new HTML interactive form validation user interface on Mac
3950         WK1 and enable it by default.
3951
3952         * WebCoreSupport/WebValidationMessageClient.h: Added.
3953         * WebCoreSupport/WebValidationMessageClient.mm: Added.
3954         (WebValidationMessageClient::WebValidationMessageClient):
3955         (WebValidationMessageClient::~WebValidationMessageClient):
3956         (WebValidationMessageClient::showValidationMessage):
3957         (WebValidationMessageClient::hideValidationMessage):
3958         (WebValidationMessageClient::isValidationMessageVisible):
3959         * WebView/WebHTMLView.mm:
3960         (-[WebHTMLView _frameOrBoundsChanged]):
3961         * WebView/WebView.mm:
3962         (-[WebView _commonInitializationWithFrameName:groupName:]):
3963         (-[WebView _willStartScrollingOrZooming]):
3964         (-[WebView _contentsOfUserInterfaceItem:]):
3965         (-[WebView _scaleWebView:atOrigin:]):
3966         (-[WebView _didScrollDocumentInFrameView:]):
3967         (-[WebView _setZoomMultiplier:isTextOnly:]):
3968         (-[WebView showFormValidationMessage:withAnchorRect:]):
3969         (-[WebView hideFormValidationMessage]):
3970         * WebView/WebViewData.h:
3971         * WebView/WebViewData.mm:
3972         (-[WebViewPrivate init]):
3973         * WebView/WebViewInternal.h:
3974         * WebView/WebViewPrivate.h:
3975
3976 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
3977
3978         Add a runtime flag for SubtleCrypto
3979         https://bugs.webkit.org/show_bug.cgi?id=164982
3980
3981         Reviewed by Brent Fulgham.
3982
3983         * WebView/WebPreferenceKeysPrivate.h:
3984         * WebView/WebPreferences.mm:
3985         (+[WebPreferences initialize]):
3986         (-[WebPreferences subtleCryptoEnabled]):
3987         (-[WebPreferences setSubtleCryptoEnabled:]):
3988         * WebView/WebPreferencesPrivate.h:
3989         * WebView/WebView.mm:
3990         (-[WebView _preferencesChanged:]):
3991
3992 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
3993
3994         Add separate settings and preferences to enable/disable async decoding for large images and animated images
3995         https://bugs.webkit.org/show_bug.cgi?id=165177
3996
3997         Reviewed by Simon Fraser.
3998         
3999         Hook up the async image decoding settings for WebKit1.
4000
4001         * WebView/WebPreferenceKeysPrivate.h:
4002         * WebView/WebPreferences.mm:
4003         (+[WebPreferences initialize]):
4004         (-[WebPreferences largeImageAsyncDecodingEnabled]):
4005         (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
4006         (-[WebPreferences animatedImageAsyncDecodingEnabled]):
4007         (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
4008         (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
4009         (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
4010         * WebView/WebPreferencesPrivate.h:
4011         * WebView/WebView.mm:
4012         (-[WebView _preferencesChanged:]):
4013
4014 2016-11-29  Andy Estes  <aestes@apple.com>
4015
4016         [Cocoa] Enable two clang warnings recommended by Xcode
4017         https://bugs.webkit.org/show_bug.cgi?id=164498
4018
4019         Reviewed by Mark Lam.
4020
4021         * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
4022
4023 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
4024
4025         [WTF] Import std::optional reference implementation as WTF::Optional
4026         https://bugs.webkit.org/show_bug.cgi?id=164199
4027
4028         Reviewed by Saam Barati and Sam Weinig.
4029
4030         Use WTF::Optional::value_or.
4031
4032         * DOM/DOMHTMLOptionsCollection.mm:
4033         (-[DOMHTMLOptionsCollection add:index:]):
4034         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4035         (WebKit::NetscapePluginInstanceProxy::evaluate):
4036         * Plugins/WebNetscapePluginView.mm:
4037         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
4038         * WebCoreSupport/WebFrameLoaderClient.h:
4039         * WebCoreSupport/WebFrameLoaderClient.mm:
4040         (WebFrameLoaderClient::dispatchDidCommitLoad):
4041         * WebCoreSupport/WebPaymentCoordinatorClient.h:
4042         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
4043         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
4044         (WebPaymentCoordinatorClient::completeShippingContactSelection):
4045         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
4046         * WebCoreSupport/WebSecurityOrigin.mm:
4047         (-[WebSecurityOrigin port]):
4048         * WebView/WebHTMLView.mm:
4049         (toAction):
4050         (toTag):
4051
4052 2016-11-26  Sam Weinig  <sam@webkit.org>
4053
4054         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
4055         https://bugs.webkit.org/show_bug.cgi?id=164965
4056
4057         Reviewed by Simon Fraser.
4058
4059         * WebView/WebPreferenceKeysPrivate.h:
4060         * WebView/WebPreferences.mm:
4061         (-[WebPreferences intersectionObserverEnabled]):
4062         (-[WebPreferences setIntersectionObserverEnabled:]):
4063         * WebView/WebPreferencesPrivate.h:
4064         * WebView/WebView.mm:
4065         (-[WebView _preferencesChanged:]):
4066         Add a preference, defaulting to off, for enabling IntersectionObserver.
4067
4068 2016-11-22  Dan Bernstein  <mitz@apple.com>
4069
4070         [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
4071         https://bugs.webkit.org/show_bug.cgi?id=165036
4072         <rdar://problem/5708580>
4073
4074         Reviewed by Alexey Proskuryakov.
4075
4076         * WebView/WebHTMLView.mm:
4077         (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
4078           similarly to what we do in -keyDown: and to what WKWebView does with all key events.
4079
4080 2016-11-21  Alex Christensen  <achristensen@webkit.org>
4081
4082         Fix Sierra CMake build after r208452
4083         https://bugs.webkit.org/show_bug.cgi?id=164437
4084
4085         * WebView/WebView.mm:
4086         (-[WebView updateMediaTouchBar]):
4087         I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
4088         It's needed for playbackSessionInterface to exist.
4089
4090 2016-11-18  Enrica Casucci  <enrica@apple.com>
4091
4092         Refactor drag and drop for WebKit2 to encode DragData message exchange.
4093         https://bugs.webkit.org/show_bug.cgi?id=164945
4094
4095         Reviewed by Tim Horton.
4096
4097         * WebCoreSupport/WebDragClient.h:
4098         * WebCoreSupport/WebDragClient.mm:
4099         (WebDragClient::actionMaskForDrag):
4100         (WebDragClient::willPerformDragDestinationAction):
4101
4102 2016-11-18  Jeremy Jones  <jeremyj@apple.com>
4103
4104         Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
4105         https://bugs.webkit.org/show_bug.cgi?id=163801
4106
4107         Reviewed by Simon Fraser.
4108
4109         Plumb through PointerLockEnabled setting.
4110
4111         * Configurations/FeatureDefines.xcconfig:
4112         * WebCoreSupport/WebChromeClient.mm:
4113         (WebChromeClient::requestPointerUnlock):
4114         * WebView/WebPreferenceKeysPrivate.h:
4115         * WebView/WebPreferences.mm:
4116         (-[WebPreferences pointerLockEnabled]):
4117         (-[WebPreferences setPointerLockEnabled:]):
4118         * WebView/WebPreferencesPrivate.h:
4119         * WebView/WebView.mm:
4120         (-[WebView _preferencesChanged:]):
4121
4122 2016-11-17  Dan Bernstein  <mitz@apple.com>
4123
4124         Try to fix some non-macOS builds.
4125
4126         * WebView/WebView.mm:
4127
4128 2016-11-16  Dave Hyatt  <hyatt@apple.com>
4129
4130         [CSS Parser] Add @supports, @keyframe and media query parsing options
4131         https://bugs.webkit.org/show_bug.cgi?id=164821
4132
4133         Reviewed by Sam Weinig and Zalan Bujtas.
4134
4135         Fix up the create call now that fallback descriptor syntax is gone.
4136
4137         * DOM/DOM.mm:
4138         (-[DOMHTMLLinkElement _mediaQueryMatches]):
4139
4140 2016-11-17  Saam Barati  <sbarati@apple.com>
4141
4142         Remove async/await compile time flag and enable tests
4143         https://bugs.webkit.org/show_bug.cgi?id=164828
4144         <rdar://problem/28639334>
4145
4146         Reviewed by Yusuke Suzuki.
4147
4148         * Configurations/FeatureDefines.xcconfig:
4149
4150 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
4151
4152         [JSC] WTF::TemporaryChange with WTF::SetForScope
4153         https://bugs.webkit.org/show_bug.cgi?id=164761
4154
4155         Reviewed by Saam Barati.
4156
4157         * WebView/WebView.mm:
4158         (-[WebView updateTextTouchBar]):
4159
4160 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
4161
4162         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
4163         https://bugs.webkit.org/show_bug.cgi?id=164827
4164
4165         Reviewed by Ryosuke Niwa.
4166
4167         * Configurations/FeatureDefines.xcconfig:
4168         * WebView/WebPreferenceKeysPrivate.h:
4169         * WebView/WebPreferences.mm:
4170         (+[WebPreferences initialize]):
4171         (-[WebPreferences es6ModulesEnabled]):
4172         (-[WebPreferences setES6ModulesEnabled:]):
4173         * WebView/WebPreferencesPrivate.h:
4174         * WebView/WebView.mm:
4175         (-[WebView _preferencesChanged:]):
4176
4177 2016-11-14  Alex Christensen  <achristensen@webkit.org>
4178
4179         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
4180         https://bugs.webkit.org/show_bug.cgi?id=164720
4181
4182         Reviewed by Brady Eidson.
4183
4184         * Storage/WebDatabaseManager.mm:
4185         (-[WebDatabaseManager origins]):
4186         (-[WebDatabaseManager databasesWithOrigin:]):
4187         (-[WebDatabaseManager deleteOrigin:]):
4188         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
4189         * Storage/WebDatabaseManagerClient.h:
4190         * Storage/WebDatabaseManagerClient.mm:
4191         (DidModifyOriginData::dispatchToMainThread):
4192         (DidModifyOriginData::DidModifyOriginData):
4193         (WebDatabaseManagerClient::dispatchDidModifyOrigin):
4194         (WebDatabaseManagerClient::dispatchDidModifyDatabase):
4195         * Storage/WebDatabaseQuotaManager.mm:
4196         (-[WebDatabaseQuotaManager usage]):
4197         (-[WebDatabaseQuotaManager quota]):
4198         (-[WebDatabaseQuotaManager setQuota:]):
4199         * Storage/WebStorageManager.mm:
4200         (-[WebStorageManager origins]):
4201         (-[WebStorageManager deleteOrigin:]):
4202         * Storage/WebStorageTrackerClient.h:
4203         * Storage/WebStorageTrackerClient.mm:
4204         (WebStorageTrackerClient::dispatchDidModifyOrigin):
4205         * WebCoreSupport/WebSecurityOrigin.mm:
4206         (-[WebSecurityOrigin usage]):
4207         (-[WebSecurityOrigin quota]):
4208         (-[WebSecurityOrigin setQuota:]):
4209
4210 2016-11-13  Darin Adler  <darin@apple.com>
4211
4212         Fix exception handling in SQL database code, streamline and update code
4213         https://bugs.webkit.org/show_bug.cgi?id=164685
4214
4215         Reviewed by Sam Weinig.
4216
4217         * Storage/WebDatabaseManager.mm:
4218         (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
4219         a reference.
4220         (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
4221         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
4222         but continue to use DatabaseManager.
4223         (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
4224         reference.
4225         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
4226
4227         * Storage/WebDatabaseManagerClient.h: Updated to take references.
4228         * Storage/WebDatabaseManagerClient.mm:
4229         (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
4230         members in the class definition.
4231         (DidModifyOriginData::dispatchToMainThread): Take references.
4232         (DidModifyOriginData::DidModifyOriginData): Ditto.
4233         (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
4234         (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
4235         (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
4236         DatabaseTracker::singleton instead of tracker.
4237
4238         * Storage/WebDatabaseQuotaManager.mm:
4239         (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
4240         (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
4241         (-[WebDatabaseQuotaManager quota]): Ditto.
4242         (-[WebDatabaseQuotaManager setQuota:]): Ditto.
4243         * WebCoreSupport/WebSecurityOrigin.mm:
4244         (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
4245         (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
4246         (-[WebSecurityOrigin quota]): Ditto.