Fix the Mac build with a newer compiler
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-03-10  Tim Horton  <timothy_horton@apple.com>
2
3         Fix the Mac build with a newer compiler
4
5         * Plugins/WebPluginController.mm:
6         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
7         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
8
9 2015-03-09  David Kilzer  <ddkilzer@apple.com>
10
11         [iOS] Fix build when compiling with dead code stripping disabled
12         <http://webkit.org/b/142467>
13
14         Reviewed by Simon Fraser.
15
16         * Configurations/WebKitLegacy.xcconfig:
17         (EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code
18         generation and compilation for out-of-process plugin support.
19         This was never used on iOS.
20
21 2015-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
22
23         [iOS] SVG fonts are garbled
24         https://bugs.webkit.org/show_bug.cgi?id=142377
25
26         Reviewed by Simon Fraser.
27
28         * Configurations/FeatureDefines.xcconfig:
29
30 2015-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
31
32         Hide Promise with runtime flags under Cocoa JSContext API
33         https://bugs.webkit.org/show_bug.cgi?id=141965
34
35         Reviewed by Filip Pizlo.
36
37         Add new JSC runtime flag, PromiseDisabled.
38
39         * WebView/WebPreferencesPrivate.h:
40
41 2015-03-03  Andy Estes  <aestes@apple.com>
42
43         [Content Filtering] Separate unblock handling into its own class
44         https://bugs.webkit.org/show_bug.cgi?id=142251
45
46         Reviewed by Andreas Kling.
47         
48         Adopted ContentFilterUnblockHandler.
49
50         * WebCoreSupport/WebFrameLoaderClient.h:
51         * WebCoreSupport/WebFrameLoaderClient.mm:
52         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
53         * WebView/WebFrame.mm:
54         (-[WebFrame _contentFilterDidHandleNavigationAction:]):
55         * WebView/WebFrameInternal.h:
56
57 2015-03-03  Chris Dumez  <cdumez@apple.com>
58
59         Access ApplicationCacheStorage global instance via singleton() static member function
60         https://bugs.webkit.org/show_bug.cgi?id=142239
61
62         Reviewed by Anders Carlsson.
63
64         Access ApplicationCacheStorage global instance via singleton() static
65         member function as per WebKit coding style.
66
67 2015-03-02  Jer Noble  <jer.noble@apple.com>
68
69         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
70         https://bugs.webkit.org/show_bug.cgi?id=142121
71
72         Reviewed by Simon Fraser.
73
74         Fullscreening a page with a non-1 scale would result in that scale being applied to the
75         fullscreen content, breaking fullscreen mode. Set the page scale to 1 when entering
76         fullscreen and reset it to the original value when exiting fullscreen.
77
78         * WebView/WebFullScreenController.h:
79         * WebView/WebFullScreenController.mm:
80         (-[WebFullScreenController enterFullScreen:]): Set the page scale to 1.
81         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Reset the page
82                 scale to the original value.
83         * WebView/WebView.mm:
84         (-[WebView _supportsFullScreenForElement:withKeyboard:]): Drive-by fix. Check the
85                 WebView's own preferences to see if fullscreen mode is enabled, rather than
86                 the global object's.
87
88 2015-03-01  Chris Dumez  <cdumez@apple.com>
89
90         Make NotificationCenter / Notification suspendable
91         https://bugs.webkit.org/show_bug.cgi?id=142117
92         <rdar://problem/19923085>
93
94         Reviewed by Andreas Kling.
95
96         Provide implementation for NotificationClient::hasPendingPermissionRequests().
97         The implementation is very simplistic. it will only return false if no
98         request for permission for ever made. This is because there is currently no
99         easy way to figure out if a permission request is pending or not.
100
101         * WebCoreSupport/WebNotificationClient.h:
102         * WebCoreSupport/WebNotificationClient.mm:
103         (WebNotificationClient::requestPermission):
104         (WebNotificationClient::hasPendingPermissionRequests):
105
106 2015-02-28  Simon Fraser  <simon.fraser@apple.com>
107
108         Viewport units should not dirty style just before we do layout
109         https://bugs.webkit.org/show_bug.cgi?id=141682
110
111         Reviewed by Zalan Bujtas.
112
113         * WebView/WebFrameView.mm:
114         (-[WebFrameView _frameSizeChanged]):
115
116 2015-02-26  Chris Dumez  <cdumez@apple.com>
117
118         Rename DatabaseManager::manager() to DatabaseManager::singleton()
119         https://bugs.webkit.org/show_bug.cgi?id=142054
120
121         Reviewed by Ryosuke Niwa.
122
123         Rename DatabaseManager::manager() to DatabaseManager::singleton() as
124         per coding style and use WTF::NeverDestroyed.
125
126         * Storage/WebDatabaseManager.mm:
127         (-[WebDatabaseManager init]):
128         (-[WebDatabaseManager origins]):
129         (-[WebDatabaseManager databasesWithOrigin:]):
130         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
131         (-[WebDatabaseManager deleteAllDatabases]):
132         (-[WebDatabaseManager deleteOrigin:]):
133         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
134         * Storage/WebDatabaseQuotaManager.mm:
135         (-[WebDatabaseQuotaManager usage]):
136         (-[WebDatabaseQuotaManager quota]):
137         (-[WebDatabaseQuotaManager setQuota:]):
138         * WebCoreSupport/WebSecurityOrigin.mm:
139         (-[WebSecurityOrigin usage]):
140         (-[WebSecurityOrigin quota]):
141         (-[WebSecurityOrigin setQuota:]):
142         * WebView/WebFrame.mm:
143         (-[WebFrame _cacheabilityDictionary]):
144         * WebView/WebView.mm:
145         (-[WebView _preferencesChanged:]):
146
147 2015-02-26  Myles C. Maxfield  <mmaxfield@apple.com>
148
149         [Mac] [iOS] Parsing support for -apple-trailing-word
150         https://bugs.webkit.org/show_bug.cgi?id=141939
151
152         Reviewed by Andreas Kling.
153
154         * Configurations/FeatureDefines.xcconfig:
155
156 2015-02-24  Commit Queue  <commit-queue@webkit.org>
157
158         Unreviewed, rolling out r180599.
159         https://bugs.webkit.org/show_bug.cgi?id=141998
160
161         Lots of new test failures (Requested by smfr on #webkit).
162
163         Reverted changeset:
164
165         "Parsing support for -webkit-trailing-word"
166         https://bugs.webkit.org/show_bug.cgi?id=141939
167         http://trac.webkit.org/changeset/180599
168
169 2015-02-24  Myles C. Maxfield  <mmaxfield@apple.com>
170
171         [Mac] [iOS] Parsing support for -apple-trailing-word
172         https://bugs.webkit.org/show_bug.cgi?id=141939
173
174         Reviewed by Andreas Kling.
175
176         * Configurations/FeatureDefines.xcconfig:
177
178 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
179
180         REGRESSION(r179429): Can't type comments in Facebook
181         https://bugs.webkit.org/show_bug.cgi?id=141859
182
183         Reviewed by Brent Fulgham.
184
185         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
186         Private API, javaScriptExperimentsEnabled is dropped.
187
188         * Misc/WebNSDictionaryExtras.h:
189         * Misc/WebNSDictionaryExtras.m:
190         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
191         * WebKit.order:
192         * WebView/WebPreferenceKeysPrivate.h:
193         * WebView/WebPreferences.mm:
194         (+[WebPreferences initialize]):
195         (-[WebPreferences _setUnsignedIntValue:forKey:]):
196         (-[WebPreferences javaScriptRuntimeFlags]):
197         (-[WebPreferences setJavaScriptRuntimeFlags:]):
198         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
199         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
200         * WebView/WebPreferencesPrivate.h:
201         * WebView/WebView.mm:
202         (-[WebView _preferencesChanged:]):
203
204 2015-02-23  Commit Queue  <commit-queue@webkit.org>
205
206         Unreviewed, rolling out r180547 and r180550.
207         https://bugs.webkit.org/show_bug.cgi?id=141957
208
209         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
210
211         Reverted changesets:
212
213         "REGRESSION(r179429): Can't type comments in Facebook"
214         https://bugs.webkit.org/show_bug.cgi?id=141859
215         http://trac.webkit.org/changeset/180547
216
217         "Constructor returning null should construct an object instead
218         of null"
219         https://bugs.webkit.org/show_bug.cgi?id=141640
220         http://trac.webkit.org/changeset/180550
221
222 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
223
224         Disable font loading events until our implementation gets updated to match the latest spec
225         https://bugs.webkit.org/show_bug.cgi?id=141938
226
227         Reviewed by Andreas Kling.
228
229         * Configurations/FeatureDefines.xcconfig:
230
231 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
232
233         REGRESSION(r179429): Can't type comments in Facebook
234         https://bugs.webkit.org/show_bug.cgi?id=141859
235
236         Reviewed by Geoffrey Garen.
237
238         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
239         Private API, javaScriptExperimentsEnabled is dropped.
240
241         * Misc/WebNSDictionaryExtras.h:
242         * Misc/WebNSDictionaryExtras.m:
243         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
244         * WebKit.order:
245         * WebView/WebPreferenceKeysPrivate.h:
246         * WebView/WebPreferences.mm:
247         (+[WebPreferences initialize]):
248         (-[WebPreferences _setUnsignedIntValue:forKey:]):
249         (-[WebPreferences javaScriptRuntimeFlags]):
250         (-[WebPreferences setJavaScriptRuntimeFlags:]):
251         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
252         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
253         * WebView/WebPreferencesPrivate.h:
254         * WebView/WebView.mm:
255         (-[WebView _preferencesChanged:]):
256
257 2015-02-20  Eric Carlson  <eric.carlson@apple.com>
258
259         [iOS] cleanup AirPlay code
260         https://bugs.webkit.org/show_bug.cgi?id=141811
261
262         Reviewed by Jer Noble.
263
264         * Configurations/FeatureDefines.xcconfig: IOS_AIRPLAY -> WIRELESS_PLAYBACK_TARGET.
265
266 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
267
268         Adopt WebCore::IOSurface in ImageBuffer
269         https://bugs.webkit.org/show_bug.cgi?id=141751
270
271         Reviewed by Simon Fraser.
272
273         * WebCoreSupport/WebSystemInterface.mm:
274         (InitWebCoreSystemInterface):
275         Remove old WKSI IOSurface-related functions.
276
277 2015-02-18  Commit Queue  <commit-queue@webkit.org>
278
279         Unreviewed, rolling out r180286.
280         https://bugs.webkit.org/show_bug.cgi?id=141766
281
282         Caused >50 crashed LayoutTests (Requested by jernoble on
283         #webkit).
284
285         Reverted changeset:
286
287         "Page::userContentController() should return a reference, not
288         a pointer"
289         https://bugs.webkit.org/show_bug.cgi?id=141764
290         http://trac.webkit.org/changeset/180286
291
292 2015-02-18  Brady Eidson  <beidson@apple.com>
293
294         Page::userContentController() should return a reference, not a pointer
295         https://bugs.webkit.org/show_bug.cgi?id=141764
296
297         Reviewed by Jer Noble.
298
299         * WebView/WebView.mm:
300         (-[WebView setGroupName:]):
301
302 2015-02-18  Chris Dumez  <cdumez@apple.com>
303
304         Access FontCache global instance via singleton() static member function
305         https://bugs.webkit.org/show_bug.cgi?id=141726
306
307         Reviewed by Daniel Bates.
308
309         Access FontCache global instance via singleton() static member function,
310         as per coding style.
311
312 2015-02-17  Chris Dumez  <cdumez@apple.com>
313
314         Access MemoryPressureHandler global instance via a singleton() static member function
315         https://bugs.webkit.org/show_bug.cgi?id=141691
316
317         Reviewed by Andreas Kling.
318
319         Access MemoryPressureHandler global instance via a singleton() static
320         member function.
321
322         * WebView/WebView.mm:
323         (-[WebView _commonInitializationWithFrameName:groupName:]):
324         (+[WebView registerForMemoryNotifications]):
325         (+[WebView _isUnderMemoryPressure]):
326         (+[WebView _clearMemoryPressure]):
327         (+[WebView _shouldWaitForMemoryClearMessage]):
328         (WebInstallMemoryPressureHandler):
329
330 2015-02-15  Sam Weinig  <sam@webkit.org>
331
332         Add experimental <attachment> element support
333         https://bugs.webkit.org/show_bug.cgi?id=141626
334
335         Reviewed by Tim Horton.
336
337         * Configurations/FeatureDefines.xcconfig:
338
339 2015-02-14  Joseph Pecoraro  <pecoraro@apple.com>
340
341         [Mac] Possible DDActionContext leaks, RetainPtr cleanup
342         https://bugs.webkit.org/show_bug.cgi?id=141613
343
344         Reviewed by Tim Horton.
345
346         * WebCoreSupport/WebEditorClient.mm:
347         (WebEditorClient::WebEditorClient):
348         Avoid unnecessary retain/autorelease by adopting.
349
350         * WebView/WebActionMenuController.mm:
351         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
352         Adopt the allocated object.
353
354 2015-02-09  Brian J. Burg  <burg@cs.washington.edu>
355
356         Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace
357         https://bugs.webkit.org/show_bug.cgi?id=141372
358
359         Reviewed by Joseph Pecoraro.
360
361         * WebCoreSupport/WebInspectorClient.mm:
362         (-[WebInspectorWindowController destroyInspectorView:]):
363
364 2015-02-14  Alexey Proskuryakov  <ap@apple.com>
365
366         rel="noreferrer" should make window.opener null
367         https://bugs.webkit.org/show_bug.cgi?id=141579
368
369         Reviewed by Darin Adler.
370
371         * WebView/WebPDFView.mm:
372         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore
373         function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
374
375 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
376
377         [Streams API] Implement a barebone ReadableStream interface
378         https://bugs.webkit.org/show_bug.cgi?id=141045
379
380         Reviewed by Benjamin Poulain.
381
382         * Configurations/FeatureDefines.xcconfig:
383
384 2015-02-03  Enrica Casucci  <enrica@apple.com>
385
386         [iOS] Add support for deleteFromInputWithFlags.
387         https://bugs.webkit.org/show_bug.cgi?id=141216
388         rdar://problem/19130081
389
390         Reviewed by Benjamin Poulain.
391
392         Adopts the new method as soon as it is available.
393         The patch also removes some obsolete code used for staging.
394
395         * WebView/WebHTMLView.mm:
396         (-[WebHTMLView _handleEditingKeyEvent:]):
397
398 2015-02-02  Chris Dumez  <cdumez@apple.com>
399
400         Access MemoryCache singleton using MemoryCache::singleton()
401         https://bugs.webkit.org/show_bug.cgi?id=141104
402
403         Reviewed by Andreas Kling.
404
405         Access MemoryCache singleton using MemoryCache::singleton() static
406         member function, instead of a free function, as per the recent
407         coding style discussion on WebKit-dev.
408
409 2015-02-01  Chris Dumez  <cdumez@apple.com>
410
411         Use more references in HistoryItem
412         https://bugs.webkit.org/show_bug.cgi?id=141133
413
414         Reviewed by Andreas Kling.
415
416         Use more references in HistoryItem instead of pointers.
417
418 2015-01-31  Sam Weinig  <sam@webkit.org>
419
420         Remove even more Mountain Lion support
421         https://bugs.webkit.org/show_bug.cgi?id=141124
422
423         Reviewed by Alexey Proskuryakov.
424
425         * Configurations/Base.xcconfig:
426         * Configurations/DebugRelease.xcconfig:
427         * Configurations/FeatureDefines.xcconfig:
428         * Configurations/Version.xcconfig:
429         * Configurations/WebKitLegacy.xcconfig:
430
431 2015-01-30  Eric Carlson  <eric.carlson@apple.com>
432
433         Remove MediaPlayerProxy.h
434         https://bugs.webkit.org/show_bug.cgi?id=141087
435
436         Reviewed by Sam Weinig.
437
438         * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h.
439         * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h.
440
441 2015-01-30  Chris Dumez  <cdumez@apple.com>
442
443         Rename shared() static member functions to singleton() for singleton classes.
444         https://bugs.webkit.org/show_bug.cgi?id=141088
445
446         Reviewed by Ryosuke Niwa and Benjamin Poulain.
447
448         Rename shared() static member functions to singleton() for singleton
449         classes as per the recent coding style change.
450
451 2015-01-29  Beth Dakin  <bdakin@apple.com>
452
453         Remove more Mountain Lion code from WebKit
454         https://bugs.webkit.org/show_bug.cgi?id=141050
455
456         Reviewed by Anders Carlsson.
457
458         * History/WebHistory.mm:
459         (getDayBoundaries):
460         * Panels/WebAuthenticationPanel.m:
461         (-[WebAuthenticationPanel cancel:]):
462         (-[WebAuthenticationPanel logIn:]):
463         (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]):
464         * WebCoreSupport/WebSystemInterface.mm:
465         (InitWebCoreSystemInterface):
466         * WebView/WebFrameView.mm:
467         * WebView/WebPreferences.mm:
468         (+[WebPreferences initialize]):
469         (needsScreenFontsEnabledQuirk):
470         * WebView/WebView.mm:
471         (+[WebView registerForMemoryNotifications]):
472         (-[WebView _preferencesChanged:]):
473         (+[WebView initialize]):
474         (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
475         (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
476         (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):
477
478 2015-01-29  Sam Weinig  <sam@webkit.org>
479
480         Remove support for screen font substitution
481         https://bugs.webkit.org/show_bug.cgi?id=141038
482
483         Reviewed by Tim Horton.
484
485         * Misc/WebKitNSStringExtras.mm:
486         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
487         (-[NSString _web_widthWithFont:]):
488         * Misc/WebStringTruncator.mm:
489         (fontFromNSFont):
490         Update for new signature of the FontPlatformData constructor, which no longer cares about
491         whether to use printer fonts.
492
493         * WebView/WebPreferenceKeysPrivate.h:
494         Remove the WebKitScreenFontSubstitutionEnabledKey key.
495
496         * WebView/WebPreferences.mm:
497         (+[WebPreferences initialize]):
498         Remove support for WebKitScreenFontSubstitutionEnabledKey.
499
500         (needsScreenFontsEnabledQuirk): Deleted.
501         Remove support for the Mountain Lion era 1-Password quirk.
502
503         (-[WebPreferences screenFontSubstitutionEnabled]): Deleted.
504         (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted.
505         * WebView/WebPreferencesPrivate.h:
506         * WebView/WebView.mm:
507         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
508         (-[WebView _preferencesChanged:]):
509         Remove support for the screen font substitution setting.
510
511 2015-01-29  Chris Dumez  <cdumez@apple.com>
512
513         Clean up / modernize PageCache class
514         https://bugs.webkit.org/show_bug.cgi?id=141009
515
516         Reviewed by Darin Adler.
517
518         Clean up / modernize PageCache class.
519
520         * History/WebBackForwardList.mm:
521         (-[WebBackForwardList pageCacheSize]):
522         * WebView/WebView.mm:
523         (-[WebView _loadBackForwardListFromOtherView:]):
524         (-[WebView goToBackForwardItem:]):
525         (+[WebView _setCacheModel:]):
526
527 2015-01-28  Beth Dakin  <bdakin@apple.com>
528
529         Remove Mountain Lion code from WebKit and WebKit2
530         https://bugs.webkit.org/show_bug.cgi?id=141010
531
532         Reviewed by Sam Weinig.
533
534         * DOM/WebDOMOperations.mm:
535         (toNSEventPhase):
536         * WebView/WebHTMLView.mm:
537         (isQuickLookEvent):
538
539 2015-01-28  Dana Burkart  <dburkart@apple.com>
540
541         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
542         https://bugs.webkit.org/show_bug.cgi?id=136765
543
544         Reviewed by Alexey Proskuryakov.
545
546         * Configurations/Base.xcconfig:
547         * Configurations/DebugRelease.xcconfig:
548
549 2015-01-28  Chris Dumez  <cdumez@apple.com>
550
551         Fix typo in markPagesForVistedLinkStyleRecalc()
552         https://bugs.webkit.org/show_bug.cgi?id=140977
553
554         Reviewed by Darin Adler.
555
556         * WebCoreSupport/WebVisitedLinkStore.mm:
557         (WebVisitedLinkStore::removeAllVisitedLinks):
558         (WebVisitedLinkStore::removeVisitedLink):
559         (WebVisitedLinkStore::addVisitedLinkHash):
560
561 2015-01-28  Chris Dumez  <cdumez@apple.com>
562
563         Rename pageCache() to PageCache::shared() and return a reference
564         https://bugs.webkit.org/show_bug.cgi?id=140983
565
566         Reviewed by Andreas Kling.
567
568         Rename pageCache() to PageCache::shared() as this is a singleton class
569         and have it return a reference instead of a pointer.
570
571         * History/WebBackForwardList.mm:
572         (-[WebBackForwardList pageCacheSize]):
573         * Misc/WebCoreStatistics.mm:
574         (+[WebCoreStatistics cachedPageCount]):
575         (+[WebCoreStatistics cachedFrameCount]):
576         * WebCoreSupport/WebVisitedLinkStore.mm:
577         (WebVisitedLinkStore::removeAllVisitedLinks):
578         (WebVisitedLinkStore::removeVisitedLink):
579         (WebVisitedLinkStore::addVisitedLinkHash):
580         * WebView/WebView.mm:
581         (+[WebView _setCacheModel:]):
582
583 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
584
585         More build fixes for newer clang.
586
587         Rubber-stamped by Anders Carlsson.
588
589         Marked a deprecated accessibility method as such.
590
591         * WebView/WebFrame.mm:
592         (-[WebFrame accessibilityRoot]):
593
594 2015-01-27  Beth Dakin  <bdakin@apple.com>
595
596         Immediate action gesture recognizer still doesn't work well with IB
597         https://bugs.webkit.org/show_bug.cgi?id=140967
598         -and corresponding-
599         rdar://problem/19621509
600
601         Reviewed by Tim Horton.
602
603         We should add (or remove) the gesture recognizer in viewDidMoveToWindow because 
604         initWithFrame it too early and IB might mess with it.
605         * WebView/WebImmediateActionController.h:
606         * WebView/WebImmediateActionController.mm:
607         (-[WebImmediateActionController immediateActionRecognizer]):
608         * WebView/WebView.mm:
609         (-[WebView _commonInitializationWithFrameName:groupName:]):
610         (-[WebView viewDidMoveToWindow]):
611
612 2015-01-27  Dan Bernstein  <mitz@apple.com>
613
614         Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
615
616         Rubber-stamped by Anders Carlsson.
617
618         * WebView/WebView.h: Added forward declarations of the protocols.
619
620 2015-01-26  Anders Carlsson  <andersca@apple.com>
621
622         Make it easy to test enabling formal delegate protocols
623         https://bugs.webkit.org/show_bug.cgi?id=140892
624
625         Reviewed by Dan Bernstein.
626
627         Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
628
629         * Misc/WebDownload.h:
630         * WebView/WebFrameLoadDelegate.h:
631         * WebView/WebPolicyDelegate.h:
632         * WebView/WebResourceLoadDelegate.h:
633         * WebView/WebUIDelegate.h:
634         * WebView/WebView.h:
635
636 2015-01-26  Chris Dumez  <cdumez@apple.com>
637
638         Rename Document::body() to Document::bodyOrFrameset() for clarity
639         https://bugs.webkit.org/show_bug.cgi?id=140902
640
641         Reviewed by Andreas Kling.
642
643         Rename Document::body() to Document::bodyOrFrameset() for clarity. This
644         method does not necessarily return an HTMLBodyElement, it can also
645         return a frameset as per the specification:
646         http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
647
648         This method is often misused internally (the caller is only interested
649         in the <body> element). I will fix these instances in a follow-up patch,
650         this patch is only renaming mechanically.
651
652 2015-01-26  Chris Dumez  <cdumez@apple.com>
653
654         First argument to DOM traversal functions should be a reference
655         https://bugs.webkit.org/show_bug.cgi?id=140895
656
657         Reviewed by Antti Koivisto.
658
659         First argument to DOM traversal functions should be a reference instead
660         of a pointer as it is dereferenced without null-check.
661
662 2015-01-26  Myles C. Maxfield  <mmaxfield@apple.com>
663
664         [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
665         https://bugs.webkit.org/show_bug.cgi?id=140860
666
667         Reviewed by Darin Adler.
668
669         The fonts it makes are grotesque. (See what I did there? Typographic
670         humor is the best humor.)
671
672         * Configurations/FeatureDefines.xcconfig:
673
674 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
675
676         QLPreviewMenuItem popovers don't close when the page scrolls
677         https://bugs.webkit.org/show_bug.cgi?id=140806
678         <rdar://problem/19555618>
679
680         Reviewed by Beth Dakin.
681
682         Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
683
684         * WebView/WebHTMLView.mm:
685         (-[WebHTMLView scrollWheel:scrollWheel:]):
686         Send scrollWheel along to WebImmediateActionController.
687
688         * WebView/WebImmediateActionController.h:
689         * WebView/WebImmediateActionController.mm:
690         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
691         (-[WebImmediateActionController _clearImmediateActionState]):
692         (-[WebImmediateActionController _defaultAnimationController]):
693         Keep track of the active QLPreviewMenuItem, and close it upon scroll.
694
695 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
696
697         Infinite recursion in _clearImmediateActionState
698         https://bugs.webkit.org/show_bug.cgi?id=140807
699         <rdar://problem/19571601>
700
701         Reviewed by Anders Carlsson.
702
703         * WebView/WebImmediateActionController.mm:
704         (-[WebImmediateActionController _clearImmediateActionState]):
705         Use this opportunity to bring identical code to WebKit1, to avoid
706         getting DataDetectors stuck when an immediate action is canceled.
707
708 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
709
710         Add a build flag for ES6 class syntax
711         https://bugs.webkit.org/show_bug.cgi?id=140760
712
713         Reviewed by Michael Saboff.
714
715         * Configurations/FeatureDefines.xcconfig:
716
717 2015-01-22  Beth Dakin  <bdakin@apple.com>
718
719         ibtoold crash below -[WebView close]
720         https://bugs.webkit.org/show_bug.cgi?id=140782
721         -and corresponding-
722         rdar://problem/19558472
723
724         Reviewed by Tim Horton.
725
726         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
727         it is because interface builder is messing with our views.
728         * WebView/WebImmediateActionController.h:
729         * WebView/WebImmediateActionController.mm:
730         (-[WebImmediateActionController webViewClosed]):
731         (-[WebImmediateActionController _cancelImmediateAction]):
732         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
733         (-[WebImmediateActionController _updateImmediateActionItem]):
734
735 2015-01-21  Beth Dakin  <bdakin@apple.com>
736
737         Crash in QuickLook preview delegate method
738         https://bugs.webkit.org/show_bug.cgi?id=140740
739         -and corresponding-
740         rdar://problem/19540806
741
742         Reviewed by Tim Horton.
743
744         Clear out the delegate.
745         * WebView/WebImmediateActionController.mm:
746         (-[WebImmediateActionController webViewClosed]):
747
748 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
749
750         Remove ENABLE(INSPECTOR) ifdef guards
751         https://bugs.webkit.org/show_bug.cgi?id=140668
752
753         Reviewed by Darin Adler.
754
755         * Configurations/FeatureDefines.xcconfig:
756         * WebCoreSupport/WebFrameLoaderClient.mm:
757         (WebFrameLoaderClient::dispatchWillSendRequest):
758
759 2015-01-20  Anders Carlsson  <andersca@apple.com>
760
761         Remove USE(GLIB) code from WebKit1
762         https://bugs.webkit.org/show_bug.cgi?id=140714
763
764         Reviewed by Andreas Kling.
765
766         * WebView/WebView.mm:
767         (-[WebView _commonInitializationWithFrameName:groupName:]):
768         (-[WebView _close]):
769         (-[WebView _clearGlibLoopObserver]): Deleted.
770         (glibContextIterationCallback): Deleted.
771         (-[WebView _scheduleGlibContextIterations]): Deleted.
772         * WebView/WebViewData.h:
773         * WebView/WebViewInternal.h:
774
775 2015-01-20  David Kilzer  <ddkilzer@apple.com>
776
777         Switch to comparing PLATFORM_NAME in terms of macosx
778         <http://webkit.org/b/139516>
779
780         Reviewed by Timothy Hatcher.
781
782         * MigrateHeaders.make:
783         * postprocess-headers.sh:
784
785 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
786
787         [SVG -> OTF Converter] Flip the switch on
788         https://bugs.webkit.org/show_bug.cgi?id=140592
789
790         Reviewed by Antti Koivisto.
791
792         * Configurations/FeatureDefines.xcconfig:
793
794 2015-01-19  Beth Dakin  <bdakin@apple.com>
795
796         Speculative build fix.
797
798         * WebView/WebView.mm:
799         (-[WebView _commonInitializationWithFrameName:groupName:]):
800
801 2015-01-19  Beth Dakin  <bdakin@apple.com>
802
803         Speculative build fix.
804
805         * WebView/WebView.mm:
806         (-[WebView _convertRectFromRootView:]):
807
808 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
809
810         Adjust naming of action menu SPI
811         https://bugs.webkit.org/show_bug.cgi?id=140644
812         <rdar://problem/19448129>
813
814         Reviewed by Brian Weinstein.
815
816         * WebView/WebActionMenuController.mm:
817         (-[WebActionMenuController prepareForMenu:withEvent:]):
818         (-[WebActionMenuController willOpenMenu:withEvent:]):
819         (-[WebActionMenuController didCloseMenu:withEvent:]):
820         * WebView/WebView.mm:
821         (-[WebView _commonInitializationWithFrameName:groupName:]):
822         (-[WebView prepareForMenu:withEvent:]):
823         (-[WebView willOpenMenu:withEvent:]):
824         (-[WebView didCloseMenu:withEvent:]):
825
826 2015-01-19  Beth Dakin  <bdakin@apple.com>
827
828         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
829         offset by flipped-ness
830         https://bugs.webkit.org/show_bug.cgi?id=140643
831         -and corresponding-
832         rdar://problem/19489593
833
834         Reviewed by Tim Horton.
835
836         We universally flipped because we assumed that the root view was flipped and the 
837         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
838         fixes that assumption by checking the WebView’s flipped-ness.
839         * WebView/WebView.mm:
840         (-[WebView _convertRectFromRootView:]):
841
842 2015-01-19  Commit Queue  <commit-queue@webkit.org>
843
844         Unreviewed, rolling out r178653.
845         https://bugs.webkit.org/show_bug.cgi?id=140634
846
847         Broke multiple SVG tests on Mountain Lion (Requested by ap on
848         #webkit).
849
850         Reverted changeset:
851
852         "[SVG -> OTF Converter] Flip the switch on"
853         https://bugs.webkit.org/show_bug.cgi?id=140592
854         http://trac.webkit.org/changeset/178653
855
856 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
857
858         [SVG -> OTF Converter] Flip the switch on
859         https://bugs.webkit.org/show_bug.cgi?id=140592
860
861         Reviewed by Antti Koivisto.
862
863         * Configurations/FeatureDefines.xcconfig:
864
865 2015-01-18  Daniel Bates  <dabates@apple.com>
866
867         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
868         (https://bugs.webkit.org/show_bug.cgi?id=129441)
869
870         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
871         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
872
873         * WebInspector/WebNodeHighlightView.mm:
874         (-[WebNodeHighlightView layoutSublayers:]):
875
876 2015-01-16  Beth Dakin  <bdakin@apple.com>
877
878         Make sure early cancellation of immediate action actually does that in WK1
879         https://bugs.webkit.org/show_bug.cgi?id=140566
880         -and corresponding-
881         rdar://problem/19490114
882
883         Reviewed by Tim Horton.
884
885         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
886         asynchronously.
887         * WebView/WebImmediateActionController.mm:
888         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
889
890 2015-01-16  Daniel Bates  <dabates@apple.com>
891
892         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
893         (https://bugs.webkit.org/show_bug.cgi?id=140360)
894
895         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
896
897         * Misc/WebDownload.h:
898
899 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
900
901         Remove ENABLE(SQL_DATABASE) guards
902         https://bugs.webkit.org/show_bug.cgi?id=140434
903
904         Reviewed by Darin Adler.
905
906         * Configurations/FeatureDefines.xcconfig:
907         * Storage/WebDatabaseManager.mm:
908         (databasesDirectoryPath):
909         * Storage/WebDatabaseManagerClient.h:
910         * Storage/WebDatabaseManagerClient.mm:
911         * Storage/WebDatabaseManagerInternal.h:
912         * Storage/WebDatabaseManagerPrivate.h:
913         * Storage/WebDatabaseQuotaManager.mm:
914         (-[WebDatabaseQuotaManager usage]):
915         (-[WebDatabaseQuotaManager quota]):
916         (-[WebDatabaseQuotaManager setQuota:]):
917         * WebCoreSupport/WebChromeClient.h:
918         * WebCoreSupport/WebChromeClient.mm:
919         * WebCoreSupport/WebSecurityOrigin.mm:
920         (-[WebSecurityOrigin usage]):
921         (-[WebSecurityOrigin quota]):
922         (-[WebSecurityOrigin setQuota:]):
923         * WebView/WebFrame.mm:
924         (-[WebFrame _cacheabilityDictionary]):
925         * WebView/WebView.mm:
926         (-[WebView _commonInitializationWithFrameName:groupName:]):
927         (-[WebView _preferencesChanged:]):
928
929 2015-01-14  Chris Dumez  <cdumez@apple.com>
930
931         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
932         https://bugs.webkit.org/show_bug.cgi?id=140347
933
934         Reviewed by Darin Adler.
935
936         Call FontDescription::setIsItalic() instead of setItalic() as the
937         call site passes a boolean.
938
939         * WebView/WebHTMLView.mm:
940         (fontNameForDescription):
941
942 2015-01-13  Anders Carlsson  <andersca@apple.com>
943
944         Temporarily reintroduce the informal delegate protocols
945         https://bugs.webkit.org/show_bug.cgi?id=140416
946
947         Reviewed by Dan Bernstein.
948
949         * WebView/WebEditingDelegate.h:
950         * WebView/WebFrameLoadDelegate.h:
951         * WebView/WebPolicyDelegate.h:
952         * WebView/WebResourceLoadDelegate.h:
953         * WebView/WebUIDelegate.h:
954
955 2015-01-13  Beth Dakin  <bdakin@apple.com>
956
957         Should disable immediate actions for iTunes
958         https://bugs.webkit.org/show_bug.cgi?id=140405
959         -and corresponding-
960         rdar://problem/19461358
961
962         Reviewed by Tim Horton.
963
964         * WebView/WebImmediateActionController.mm:
965         (-[WebImmediateActionController _updateImmediateActionItem]):
966
967 2015-01-11  Sam Weinig  <sam@webkit.org>
968
969         Remove support for SharedWorkers
970         https://bugs.webkit.org/show_bug.cgi?id=140344
971
972         Reviewed by Anders Carlsson.
973
974         * Configurations/FeatureDefines.xcconfig:
975         * WebCoreSupport/WebPlatformStrategies.h:
976         * WebCoreSupport/WebPlatformStrategies.mm:
977         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
978
979 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
980
981         Get rid of unnecessary reimplementations of CGFloor/Ceiling
982         https://bugs.webkit.org/show_bug.cgi?id=140375
983
984         Reviewed by Simon Fraser.
985
986         * Misc/WebKitNSStringExtras.mm:
987         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
988         (webkit_CGCeiling): Deleted.
989         Delete unnecessary code, use the real CGFloor/Ceiling instead.
990
991 2015-01-12  Anders Carlsson  <andersca@apple.com>
992
993         Make delegates conform to formal delegate protocols
994         https://bugs.webkit.org/show_bug.cgi?id=140370
995
996         Reviewed by Dan Bernstein.
997
998         * DefaultDelegates/WebDefaultPolicyDelegate.h:
999         * WebCoreSupport/WebInspectorClient.mm:
1000         Add protocols to the interface declarations.
1001
1002         * WebView/WebActionMenuController.mm:
1003         (-[WebActionMenuController prepareForMenu:withEvent:]):
1004         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1005         * WebView/WebImmediateActionController.mm:
1006         (-[WebImmediateActionController _updateImmediateActionItem]):
1007         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1008         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
1009
1010 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
1011
1012         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
1013         https://bugs.webkit.org/show_bug.cgi?id=136769
1014
1015         Reviewed by Antti Koivisto.
1016
1017         * Configurations/FeatureDefines.xcconfig:
1018
1019 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
1020
1021         Multi-rect TextIndicators are vertically flipped in WebKit1
1022         https://bugs.webkit.org/show_bug.cgi?id=140350
1023         <rdar://problem/19441243>
1024
1025         Reviewed by Beth Dakin.
1026
1027         * WebView/WebView.mm:
1028         (-[WebView _setTextIndicator:fadeOut:]):
1029         Convert the textBoundingRect from root view to screen coordinates.
1030
1031 2015-01-12  Anders Carlsson  <andersca@apple.com>
1032
1033         Make WebResourceDelegate a formal protocol as well
1034         https://bugs.webkit.org/show_bug.cgi?id=140364
1035
1036         Reviewed by Dan Bernstein.
1037
1038         * WebView/WebResourceLoadDelegate.h:
1039
1040 2015-01-12  Anders Carlsson  <andersca@apple.com>
1041
1042         Delegates should be formal protocols
1043         https://bugs.webkit.org/show_bug.cgi?id=140360
1044         rdar://problem/17380856
1045
1046         Reviewed by Dan Bernstein.
1047
1048         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
1049
1050         * DefaultDelegates/WebDefaultUIDelegate.h:
1051         * Misc/WebDownload.h:
1052         * WebView/WebEditingDelegate.h:
1053         * WebView/WebFrameLoadDelegate.h:
1054         * WebView/WebPolicyDelegate.h:
1055         * WebView/WebUIDelegate.h:
1056
1057 2015-01-09  Anders Carlsson  <andersca@apple.com>
1058
1059         Get rid of the database strategy
1060         https://bugs.webkit.org/show_bug.cgi?id=140322
1061
1062         Reviewed by Sam Weinig.
1063
1064         * WebCoreSupport/WebPlatformStrategies.h:
1065         * WebCoreSupport/WebPlatformStrategies.mm:
1066         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
1067
1068 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
1069
1070         Can't use DataDetectors after immediate action preparation
1071         https://bugs.webkit.org/show_bug.cgi?id=140263
1072         <rdar://problem/19412705>
1073
1074         Reviewed by Beth Dakin.
1075
1076         * WebView/WebImmediateActionController.mm:
1077         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1078         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1079         To match WebKit2, only call shouldUseActions if the animation is actually
1080         going to begin, not when preparing for it. This way, we're guaranteed
1081         to get a didCancel or didComplete.
1082
1083 2015-01-08  Dean Jackson  <dino@apple.com>
1084
1085         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
1086         https://bugs.webkit.org/show_bug.cgi?id=140232
1087         <rdar://problem/19371010>
1088
1089         Reviewed by Anders Carlsson.
1090
1091         Remove the applicationChromeMode setting, but leave stubs in to make
1092         sure existing binaries don't break.
1093
1094         * WebCoreSupport/WebInspectorClient.mm:
1095         (-[WebInspectorWindowController init]):
1096         * WebView/WebPreferenceKeysPrivate.h:
1097         * WebView/WebPreferences.mm:
1098         (+[WebPreferences initialize]):
1099         (-[WebPreferences applicationChromeModeEnabled]):
1100         (-[WebPreferences setApplicationChromeModeEnabled:]):
1101         * WebView/WebView.mm:
1102         (-[WebView _preferencesChanged:]):
1103
1104 2015-01-07  Daniel Bates  <dabates@apple.com>
1105
1106         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1107         https://bugs.webkit.org/show_bug.cgi?id=137371
1108
1109         Reviewed by David Kilzer.
1110
1111         Use SPI wrapper headers instead of directly references private SPI headers.
1112
1113         * Plugins/Hosted/NetscapePluginHostManager.mm:
1114
1115 2015-01-07  Commit Queue  <commit-queue@webkit.org>
1116
1117         Unreviewed, rolling out r178068.
1118         https://bugs.webkit.org/show_bug.cgi?id=140235
1119
1120         Breaks the iOS build (Requested by enrica on #webkit).
1121
1122         Reverted changeset:
1123
1124         "[iOS] Make WebKit2 build with public iOS SDK and more build
1125         fixes for DRT"
1126         https://bugs.webkit.org/show_bug.cgi?id=137371
1127         http://trac.webkit.org/changeset/178068
1128
1129 2015-01-07  Daniel Bates  <dabates@apple.com>
1130
1131         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1132         https://bugs.webkit.org/show_bug.cgi?id=137371
1133
1134         Reviewed by David Kilzer.
1135
1136         Use SPI wrapper headers instead of directly references private SPI headers.
1137
1138         * Plugins/Hosted/NetscapePluginHostManager.mm:
1139
1140 2015-01-07  Beth Dakin  <bdakin@apple.com>
1141
1142         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
1143         link
1144         https://bugs.webkit.org/show_bug.cgi?id=140206
1145         -and corresponding-
1146         rdar://problem/19300492
1147
1148         Reviewed by Tim Horton.
1149
1150         Providing and item frame will ensure that the original link is not obscured.
1151         * WebView/WebImmediateActionController.mm:
1152         (elementBoundingBoxInWindowCoordinatesFromNode):
1153         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
1154
1155         For now use a max size that is smaller than the WebView, with the screen’s aspect 
1156         ratio, and scaled down.
1157         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
1158
1159 2015-01-07  Anders Carlsson  <andersca@apple.com>
1160
1161         Give simple HTML documents a database provider
1162         https://bugs.webkit.org/show_bug.cgi?id=140192
1163         rdar://problem/19398825
1164
1165         Reviewed by Tim Horton.
1166
1167         * WebView/WebView.mm:
1168         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1169
1170 2015-01-06  Anders Carlsson  <andersca@apple.com>
1171
1172         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
1173         https://bugs.webkit.org/show_bug.cgi?id=140140
1174
1175         Reviewed by Andreas Kling.
1176
1177         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
1178         out of WebCore since nobody else is using it.
1179
1180         * Plugins/WebNetscapePluginView.h:
1181         * Plugins/WebNetscapePluginView.mm:
1182         (-[WebNetscapePluginView _createPlugin]):
1183         (-[WebNetscapePluginView _destroyPlugin]):
1184         * Plugins/npapi.mm:
1185         (NPN_PluginThreadAsyncCall):
1186
1187 2015-01-06  Anders Carlsson  <andersca@apple.com>
1188
1189         Add a WebKit1 database provider
1190         https://bugs.webkit.org/show_bug.cgi?id=140126
1191
1192         Reviewed by Sam Weinig.
1193
1194         Set the database provider.
1195
1196         * WebView/WebView.mm:
1197         (-[WebView _commonInitializationWithFrameName:groupName:]):
1198
1199 2015-01-06  Commit Queue  <commit-queue@webkit.org>
1200
1201         Unreviewed, rolling out r177963.
1202         https://bugs.webkit.org/show_bug.cgi?id=140136
1203
1204         Caused lots of crashes (Requested by smfr on #webkit).
1205
1206         Reverted changeset:
1207
1208         "Add a WebKit1 database provider"
1209         https://bugs.webkit.org/show_bug.cgi?id=140126
1210         http://trac.webkit.org/changeset/177963
1211
1212 2015-01-06  Anders Carlsson  <andersca@apple.com>
1213
1214         Add a WebKit1 database provider
1215         https://bugs.webkit.org/show_bug.cgi?id=140126
1216
1217         Reviewed by Sam Weinig.
1218
1219         Set the database provider.
1220
1221         * WebView/WebView.mm:
1222         (-[WebView _commonInitializationWithFrameName:groupName:]):
1223
1224 2015-01-01  Jeff Miller  <jeffm@apple.com>
1225
1226         Update user-visible copyright strings to include 2015
1227         https://bugs.webkit.org/show_bug.cgi?id=139880
1228
1229         Reviewed by Darin Adler.
1230
1231         * Info.plist:
1232
1233 2014-12-30  Dan Bernstein  <mitz@apple.com>
1234
1235         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
1236         https://bugs.webkit.org/show_bug.cgi?id=140003
1237
1238         Reviewed by Darin Adler.
1239
1240         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
1241         that takes their "string" parameter as a "value" "parameter and has an attribute telling
1242         the compiler that if the "value" parameter is a format string then the function returns a
1243         modified version of it. The result is that if UI_STRING is used as a format string parameter
1244         to some function or method, the compiler will check the format specifiers in the string
1245         against the other parameters.
1246
1247 2014-12-29  Dan Bernstein  <mitz@apple.com>
1248
1249         Fixed the iOS build.
1250
1251         * Configurations/WebKitLegacy.xcconfig:
1252
1253 2014-12-29  Anders Carlsson  <andersca@apple.com>
1254
1255         Get rid of some PageGroup storage functions
1256         https://bugs.webkit.org/show_bug.cgi?id=139996
1257
1258         Reviewed by Sam Weinig.
1259
1260         Call WebStorageNamespaceProvider directly instead.
1261
1262         * Storage/WebStorageManager.mm:
1263         (-[WebStorageManager syncLocalStorage]):
1264         (+[WebStorageManager closeIdleLocalStorageDatabases]):
1265         * WebView/WebView.mm:
1266         (+[WebView _applicationWillTerminate]):
1267
1268 2014-12-29  Anders Carlsson  <andersca@apple.com>
1269
1270         Move storage code from WebCore to WebKit
1271         https://bugs.webkit.org/show_bug.cgi?id=139558
1272
1273         Reviewed by Darin Adler.
1274
1275         * Storage/WebStorageManager.mm:
1276         * Storage/WebStorageTrackerClient.h:
1277         * WebView/WebView.mm:
1278
1279 2014-12-26  Dan Bernstein  <mitz@apple.com>
1280
1281         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
1282         https://bugs.webkit.org/show_bug.cgi?id=139950
1283
1284         Reviewed by David Kilzer.
1285
1286         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
1287         in a manner that works with Xcode 5.1.1.
1288
1289 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
1290
1291         Install a TextIndicator for link immediate actions
1292         https://bugs.webkit.org/show_bug.cgi?id=139897
1293         <rdar://problem/19333076>
1294
1295         Reviewed by Anders Carlsson.
1296
1297         * WebView/WebImmediateActionController.h:
1298         * WebView/WebImmediateActionController.mm:
1299         (-[WebImmediateActionController _clearImmediateActionState]):
1300         Tear down the TextIndicator, just like WebKit2.
1301
1302         (-[WebImmediateActionController _defaultAnimationController]):
1303         Install a TextIndicator for links.
1304
1305         (-[WebImmediateActionController menuItemDidClose:]):
1306         Tear down the TextIndicator when the QL preview closes.
1307
1308         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1309         Directly install and uninstall the TextIndicator for DataDetectors.
1310
1311         (-[WebImmediateActionController _showTextIndicator]): Deleted.
1312         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
1313         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
1314
1315 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
1316
1317         [iOS] add optimized fullscreen API
1318         https://bugs.webkit.org/show_bug.cgi?id=139833
1319         <rdar://problem/18844486>
1320
1321         Reviewed by Simon Fraser.
1322
1323         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
1324
1325 2014-12-20  David Kilzer  <ddkilzer@apple.com>
1326
1327         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
1328         <http://webkit.org/b/139463>
1329
1330         Reviewed by Mark Rowe.
1331
1332         * Configurations/Base.xcconfig:
1333         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
1334           on OS X.
1335         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
1336         * Configurations/DebugRelease.xcconfig:
1337         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
1338         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
1339         * Configurations/Version.xcconfig:
1340         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
1341         * Configurations/WebKitLegacy.xcconfig:
1342         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
1343           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
1344           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
1345           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
1346           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
1347           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
1348           WEBCORE_PRIVATE_HEADERS_DIR_Production and
1349           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
1350           based on SDK.
1351         - Fix PRODUCTION_ROOT to actually be set properly.
1352         - Simplify EXPORTED_SYMBOLS_FILE_i386.
1353
1354         * migrate-headers.sh:
1355         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
1356         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
1357           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
1358           WebKitLegacy.xcconfig.
1359
1360 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
1361
1362         Fix pink background on CoreAnimation plug-ins in WebKit1
1363         https://bugs.webkit.org/show_bug.cgi?id=139845
1364         rdar://problem/19313075
1365
1366         Reviewed by Tim Horton.
1367         
1368         r154078 left in some debugging code that set a pink background on plug-in hosting
1369         layers. Remove it.
1370
1371         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1372         (-[WebHostedNetscapePluginView createPluginLayer]):
1373
1374 2014-12-19  Andreas Kling  <akling@apple.com>
1375
1376         Ref-ify TextIterator API.
1377         <https://webkit.org/b/139823>
1378
1379         Reviewed by Antti Koivisto.
1380
1381         * WebView/WebTextIterator.mm:
1382         (-[WebTextIterator currentRange]):
1383
1384 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
1385
1386         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
1387         https://bugs.webkit.org/show_bug.cgi?id=139797
1388
1389         Reviewed by Mark Lam.
1390
1391         * WebView/WebScriptDebugger.h:
1392         * WebView/WebScriptDebugger.mm:
1393         (WebScriptDebugger::handlePause):
1394         Standardize on passing JSGlobalObject parameter first.
1395
1396 2014-12-19  Commit Queue  <commit-queue@webkit.org>
1397
1398         Unreviewed, rolling out r177574.
1399         https://bugs.webkit.org/show_bug.cgi?id=139821
1400
1401         "Broke Production builds by installing
1402         libWebCoreTestSupport.dylib in the wrong directory" (Requested
1403         by ddkilzer on #webkit).
1404
1405         Reverted changeset:
1406
1407         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
1408         WebInspectorUI, WebKit, WebKit2"
1409         https://bugs.webkit.org/show_bug.cgi?id=139463
1410         http://trac.webkit.org/changeset/177574
1411
1412 2014-12-19  David Kilzer  <ddkilzer@apple.com>
1413
1414         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
1415         <http://webkit.org/b/139463>
1416
1417         Reviewed by Mark Rowe.
1418
1419         * Configurations/Base.xcconfig:
1420         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
1421           on OS X.
1422         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
1423         * Configurations/DebugRelease.xcconfig:
1424         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
1425         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
1426         * Configurations/Version.xcconfig:
1427         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
1428         * Configurations/WebKitLegacy.xcconfig:
1429         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
1430           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
1431           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
1432           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
1433           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
1434           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
1435           WEBCORE_PRIVATE_HEADERS_DIR_Production and
1436           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
1437           based on SDK.
1438         - Fix PRODUCTION_ROOT to actually be set properly.
1439         - Simplify EXPORTED_SYMBOLS_FILE_i386.
1440
1441         * migrate-headers.sh:
1442         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
1443         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
1444           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
1445           WebKitLegacy.xcconfig.
1446
1447 2014-12-18  Andreas Kling  <akling@apple.com>
1448
1449         Ref-ify various Document-related things.
1450         <https://webkit.org/b/139796>
1451
1452         Reviewed by Anders Carlsson.
1453
1454         * WebView/WebFrame.mm:
1455         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
1456
1457 2014-12-18  Beth Dakin  <bdakin@apple.com>
1458
1459         Need to re-enable action menus
1460         https://bugs.webkit.org/show_bug.cgi?id=139795
1461         -and corresponding-
1462         rdar://problem/19299367
1463
1464         Reviewed by Tim Horton.
1465
1466         Re-enable the menus by un-commenting the code to create the menu and controller.
1467         * WebView/WebView.mm:
1468         (-[WebView _commonInitializationWithFrameName:groupName:]):
1469
1470 2014-12-16  Sam Weinig  <sam@webkit.org>
1471
1472         Unify the Mac and iOS implementations of FontPlatformData a bit
1473         https://bugs.webkit.org/show_bug.cgi?id=139721
1474
1475         Reviewed by Anders Carlsson.
1476
1477         * WebView/WebHTMLView.mm:
1478         (fontNameForDescription):
1479         Update for new function name.
1480
1481 2014-12-18  Antti Koivisto  <antti@apple.com>
1482
1483         Remove alwaysUseBaselineOfPrimaryFont setting
1484         https://bugs.webkit.org/show_bug.cgi?id=139770
1485
1486         Reviewed by Anders Carlsson.
1487
1488         * WebView/WebPreferenceKeysPrivate.h:
1489         * WebView/WebPreferences.mm:
1490         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
1491         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
1492         * WebView/WebPreferencesPrivate.h:
1493         * WebView/WebView.mm:
1494         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1495         (-[WebView _preferencesChanged:]):
1496
1497 2014-12-17  Andreas Kling  <akling@apple.com>
1498
1499         Ref-ify Range::create().
1500         <https://webkit.org/b/139755>
1501
1502         Reviewed by Anders Carlsson.
1503
1504         * WebView/WebHTMLRepresentation.mm:
1505         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1506         * WebView/WebHTMLView.mm:
1507         (-[WebHTMLView attributedString]):
1508
1509 2014-12-17  Anders Carlsson  <andersca@apple.com>
1510
1511         Unify -[WebResource description]
1512         https://bugs.webkit.org/show_bug.cgi?id=139762
1513
1514         Reviewed by Dan Bernstein.
1515
1516         * WebView/WebResource.mm:
1517         (-[WebResource description]):
1518
1519 2014-12-17  Anders Carlsson  <andersca@apple.com>
1520
1521         Get rid of an ugly #define hack in WebFrameLoaderClient
1522         https://bugs.webkit.org/show_bug.cgi?id=139761
1523
1524         Reviewed by Dan Bernstein.
1525
1526         Also replace @private with @package in all public headers, for consistency.
1527
1528         * History/WebBackForwardList.h:
1529         * History/WebHistory.h:
1530         * Misc/WebDownload.h:
1531         * WebCoreSupport/WebFrameLoaderClient.mm:
1532         * WebView/WebArchive.h:
1533         * WebView/WebDataSource.h:
1534         * WebView/WebFrame.h:
1535         * WebView/WebFrameView.h:
1536         * WebView/WebPreferences.h:
1537         * WebView/WebResource.h:
1538
1539 2014-12-17  Dan Bernstein  <mitz@apple.com>
1540
1541         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
1542         https://bugs.webkit.org/show_bug.cgi?id=139760
1543
1544         Reviewed by Anders Carlsson.
1545
1546         * Configurations/WebKitLegacy.xcconfig:
1547
1548 2014-12-17  Andreas Kling  <akling@apple.com>
1549
1550         Purge PassRefPtr from Frame.
1551         <https://webkit.org/b/139731>
1552
1553         Reviewed by Anders Carlsson.
1554
1555         * WebCoreSupport/WebFrameLoaderClient.mm:
1556         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1557         * WebView/WebFrame.mm:
1558         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1559         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
1560         * WebView/WebFrameInternal.h:
1561
1562 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
1563
1564         Implement and adopt two new TextIndicator presentation animations
1565         https://bugs.webkit.org/show_bug.cgi?id=139715
1566         <rdar://problem/19237945>
1567
1568         Reviewed by Anders Carlsson.
1569
1570         * WebView/WebActionMenuController.mm:
1571         (-[WebActionMenuController _showTextIndicator]):
1572         * WebView/WebHTMLView.mm:
1573         (-[WebHTMLView quickLookWithEvent:]):
1574         Remove the completionHandler from text indicator presentation.
1575
1576         * WebView/WebImmediateActionController.mm:
1577         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1578         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
1579         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1580         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1581         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1582         (-[WebImmediateActionController _animationControllerForText]):
1583         (-[WebImmediateActionController _showTextIndicator]):
1584         Forward immediate action gesture recognizer animation progress
1585         to TextIndicator. Force us to keep the selection when immediate
1586         action popovers steal first responder status from the WebView.
1587         If the Lookup range is equal to the selection range, use a Crossfade
1588         animation; otherwise, use a FadeIn animation.
1589
1590         * WebView/WebView.mm:
1591         (-[WebView _setMaintainsInactiveSelection:]):
1592         (-[WebView maintainsInactiveSelection]):
1593         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1594         (-[WebView _setTextIndicator:fadeOut:]):
1595         (-[WebView _clearTextIndicator]):
1596         (-[WebView _setTextIndicatorAnimationProgress:]):
1597         (-[WebView _showDictionaryLookupPopup:]):
1598         (-[WebView _dictionaryLookupPopoverWillClose:]):
1599         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1600         Remove the completionHandler from text indicator presentation.
1601         Add a _setMaintainsInactiveSelection, which allows WebKit internals
1602         to change the return value of -maintainsInactiveSelection, allowing
1603         us to keep the selection alive when the WebView loses first responder status.
1604
1605         * WebView/WebViewData.h:
1606         * WebView/WebViewInternal.h:
1607
1608 2014-12-16  Andreas Kling  <akling@apple.com>
1609
1610         Use Ref for SecurityOrigin.
1611         <https://webkit.org/b/139710>
1612
1613         Reviewed by Anders Carlsson.
1614
1615         * Storage/WebStorageTrackerClient.mm:
1616         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1617         * WebView/WebView.mm:
1618         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
1619         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
1620
1621 2014-12-16  Beth Dakin  <bdakin@apple.com>
1622
1623         Crash getting default animation controller for some text
1624         https://bugs.webkit.org/show_bug.cgi?id=139712
1625         -and corresponding-
1626         rdar://problem/19271707
1627
1628         Reviewed by Tim Horton.
1629
1630         Must null-check the range.
1631         * WebView/WebImmediateActionController.mm:
1632         (-[WebImmediateActionController _animationControllerForText]):
1633
1634 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
1635
1636         Immediate action popovers can get stuck open
1637         https://bugs.webkit.org/show_bug.cgi?id=139709
1638         <rdar://problem/19270279>
1639
1640         Reviewed by Beth Dakin.
1641
1642         * WebView/WebImmediateActionController.mm:
1643         (-[WebImmediateActionController _clearImmediateActionState]):
1644         Don't clear the animation controller; it breaks things and was unnecessary.
1645
1646 2014-12-16  Tim Horton  <timothy_horton@apple.com>
1647
1648         Disable TextIndication for Lookup immediate actions
1649         https://bugs.webkit.org/show_bug.cgi?id=139684
1650
1651         Reviewed by Anders Carlsson.
1652
1653         * WebView/WebView.mm:
1654         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1655
1656 2014-12-15  Beth Dakin  <bdakin@apple.com>
1657
1658         Build fix.
1659
1660         * WebView/WebImmediateActionController.mm:
1661
1662 2014-12-15  Beth Dakin  <bdakin@apple.com>
1663
1664         Speculative build fix.
1665
1666         * WebView/WebView.mm:
1667         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1668         * WebView/WebViewInternal.h:
1669
1670 2014-12-15  Beth Dakin  <bdakin@apple.com>
1671
1672         Make lookup an immediate action instead of an action menu item
1673         https://bugs.webkit.org/show_bug.cgi?id=139661
1674         -and corresponding-
1675         rdar://problem/19198414
1676
1677         Reviewed by Tim Horton.
1678
1679         Remove the lookup menu items and non-unused static function associated with 
1680         lookup.
1681         * WebView/WebActionMenuController.mm:
1682         (-[WebActionMenuController _defaultMenuItemsForText]):
1683         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
1684         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
1685         (-[WebActionMenuController _createActionMenuItemForTag:]):
1686         (-[WebActionMenuController _lookupText:]): Deleted.
1687         (performDictionaryLookupForSelection): Deleted.
1688         (performDictionaryLookupForRange): Deleted.
1689
1690         Set the defaultAnimationController to the lookup-provided animation controller 
1691         when appropriate.
1692         * WebView/WebImmediateActionController.mm:
1693         (-[WebImmediateActionController _defaultAnimationController]):
1694         (dictionaryPopupInfoForRange):
1695         (-[WebImmediateActionController _animationControllerForText]):
1696
1697         New type.
1698         * WebView/WebUIDelegatePrivate.h:
1699
1700         New function to get the lookup animation controller.
1701         * WebView/WebView.mm:
1702         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1703         * WebView/WebViewInternal.h:
1704
1705 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1706
1707         Implement Data Detectors immediate actions for Legacy WebKit
1708         https://bugs.webkit.org/show_bug.cgi?id=139619
1709         <rdar://problem/19198539>
1710
1711         Reviewed by Beth Dakin.
1712
1713         * WebView/WebImmediateActionController.mm:
1714         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1715         Note that this action context is only for immediate actions.
1716
1717 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1718
1719         Addressing post-review comments in r177035
1720         https://bugs.webkit.org/show_bug.cgi?id=139557
1721
1722         Reviewed by Darin Adler.
1723
1724         * WebView/WebActionMenuController.mm:
1725         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
1726
1727 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1728
1729         Implement Data Detectors immediate actions for Legacy WebKit
1730         https://bugs.webkit.org/show_bug.cgi?id=139619
1731         <rdar://problem/19198539>
1732
1733         Reviewed by Eric Carlson.
1734
1735         * WebView/WebHTMLView.mm:
1736         (-[WebHTMLView mouseDown:mouseDown:]):
1737         Send mouseDown along to the WebImmediateActionController too.
1738
1739         * WebView/WebImmediateActionController.h:
1740         * WebView/WebImmediateActionController.mm:
1741         (-[WebImmediateActionController webViewClosed]):
1742         (-[WebImmediateActionController webView:willHandleMouseDown:]):
1743         (-[WebImmediateActionController _cancelImmediateAction]):
1744         (-[WebImmediateActionController _clearImmediateActionState]):
1745         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1746         (-[WebImmediateActionController _defaultAnimationController]):
1747         (-[WebImmediateActionController _updateImmediateActionItem]):
1748         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1749         (-[WebImmediateActionController _showTextIndicator]):
1750         (-[WebImmediateActionController _hideTextIndicator]):
1751         Copy most of the DataDetectors implementation into WebImmediateActionController.
1752
1753         * WebView/WebUIDelegatePrivate.h:
1754         Add a new type.
1755
1756         * WebView/WebView.mm:
1757         (-[WebView _commonInitializationWithFrameName:groupName:]):
1758         Temporarily disable action menus.
1759
1760         (-[WebView _immediateActionController]):
1761         * WebView/WebViewInternal.h:
1762
1763 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1764
1765         Delete Notation because we don't use it
1766         https://bugs.webkit.org/show_bug.cgi?id=139171
1767
1768         Reviewed by Kent Tamura.
1769
1770         * MigrateHeaders.make:
1771
1772 2014-12-14  Andreas Kling  <akling@apple.com>
1773
1774         Replace PassRef with Ref/Ref&& across the board.
1775         <https://webkit.org/b/139587>
1776
1777         Reviewed by Darin Adler.
1778
1779         * WebCoreSupport/WebEditorClient.mm:
1780         (WebEditorClient::shouldApplyStyle):
1781         * WebCoreSupport/WebVisitedLinkStore.h:
1782         * WebCoreSupport/WebVisitedLinkStore.mm:
1783         (WebVisitedLinkStore::create):
1784
1785 2014-12-11  Dan Bernstein  <mitz@apple.com>
1786
1787         Fix a leak introduced in r177199.
1788
1789         Reviewed by Anders Carlsson.
1790
1791         * WebView/WebImmediateActionController.mm:
1792         (-[WebImmediateActionController _updateImmediateActionItem]):
1793
1794 2014-12-11  Beth Dakin  <bdakin@apple.com>
1795
1796         WK1: Need new SPI for Webkit clients to override default immediate action
1797         https://bugs.webkit.org/show_bug.cgi?id=139568
1798         -and corresponding-
1799         rdar://problem/19225448
1800
1801         Reviewed by Dan Bernstein.
1802
1803         Call SPI giving clients a chance to override the default behavior.
1804         * WebView/WebImmediateActionController.mm:
1805         (-[WebImmediateActionController _updateImmediateActionItem]):
1806
1807         New SPI.
1808         * WebView/WebUIDelegatePrivate.h:
1809
1810 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1811
1812         Move the preview popover to WebImmediateActionController
1813         https://bugs.webkit.org/show_bug.cgi?id=139563
1814         <rdar://problem/19208291>
1815
1816         Reviewed by Beth Dakin.
1817
1818         * WebView/WebActionMenuController.mm:
1819         (-[WebActionMenuController _defaultMenuItemsForLink]):
1820         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
1821         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
1822         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
1823         * WebView/WebImmediateActionController.h:
1824         * WebView/WebImmediateActionController.mm:
1825         (-[WebImmediateActionController webViewClosed]):
1826         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1827         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1828         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1829         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1830         (-[WebImmediateActionController _updateImmediateActionItem]):
1831         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
1832         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
1833         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
1834         Move page preview popover related code to WebImmediateActionController.
1835
1836         * WebView/WebUIDelegatePrivate.h:
1837         Add a link preview type.
1838
1839         * WebView/WebView.mm:
1840         (-[WebView _commonInitializationWithFrameName:groupName:]):
1841         Pass the gesture recognizer to the WebImmediateActionController.
1842
1843 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1844
1845         Fix the build.
1846
1847         * WebView/WebImmediateActionController.h:
1848         * WebView/WebImmediateActionController.mm:
1849
1850 2014-12-11  Anders Carlsson  <andersca@apple.com>
1851
1852         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
1853         https://bugs.webkit.org/show_bug.cgi?id=139547
1854
1855         Reviewed by Sam Weinig.
1856
1857         * WebView/WebView.mm:
1858         (+[WebView _handleMemoryWarning]):
1859
1860 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
1861
1862         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
1863         https://bugs.webkit.org/show_bug.cgi?id=139504
1864         rdar://problem/19034674
1865
1866         Reviewed by Enrica Casucci.
1867
1868         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
1869
1870         * WebCoreSupport/WebEditorClient.h:
1871         * WebCoreSupport/WebEditorClient.mm:
1872         (WebEditorClient::discardedComposition):
1873
1874 2014-12-10  Anders Carlsson  <andersca@apple.com>
1875
1876         Get rid of the storage strategy
1877         https://bugs.webkit.org/show_bug.cgi?id=139519
1878
1879         Reviewed by Antti Koivisto.
1880
1881         * WebCoreSupport/WebPlatformStrategies.h:
1882         * WebCoreSupport/WebPlatformStrategies.mm:
1883         (WebPlatformStrategies::createStorageStrategy): Deleted.
1884
1885 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1886
1887         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
1888         https://bugs.webkit.org/show_bug.cgi?id=139529
1889         <rdar://problem/19213620>
1890
1891         Reviewed by Beth Dakin.
1892
1893         * WebView/WebActionMenuController.mm:
1894         (-[WebActionMenuController _copySelection:]):
1895         (-[WebActionMenuController _paste:]):
1896         Use the copy: and paste: methods on WebView so that we traverse subviews
1897         when trying to respond, otherwise these actions don't work in subframes.
1898
1899 2014-12-10  Beth Dakin  <bdakin@apple.com>
1900
1901         WK1: Add initial support for immediate actions
1902         https://bugs.webkit.org/show_bug.cgi?id=139522
1903
1904         Reviewed by Dan Bernstein.
1905
1906         This basic implementation of the controller will use the delegate methods to 
1907         perform and cache a HitTest when relevant. Future patches will patch 
1908         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
1909         immediate action that should be taken.
1910         * WebView/WebImmediateActionController.h: Added.
1911         * WebView/WebImmediateActionController.mm: Added.
1912         (-[WebImmediateActionController webViewClosed]):
1913         (-[WebImmediateActionController _clearImmediateActionState]):
1914         (-[WebImmediateActionController performHitTestAtPoint:]):
1915         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1916         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1917         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1918         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1919         (-[WebImmediateActionController _updateImmediateActionItem]):
1920
1921         New enum for immediate action types.
1922         * WebView/WebUIDelegatePrivate.h:
1923
1924         Create an NSImmediateActionGestureRecognizer if possible and a controller.
1925         * WebView/WebView.mm:
1926         (-[WebView _commonInitializationWithFrameName:groupName:]):
1927         (-[WebView _close]):
1928         * WebView/WebViewData.h:
1929         * WebView/WebViewData.mm:
1930         (-[WebViewPrivate dealloc]):
1931
1932 2014-12-08  Anders Carlsson  <andersca@apple.com>
1933
1934         Use the new storage namespace provider in WebKit1
1935         https://bugs.webkit.org/show_bug.cgi?id=139425
1936
1937         Reviewed by Tim Horton.
1938
1939         * WebView/WebView.mm:
1940         (-[WebView _commonInitializationWithFrameName:groupName:]):
1941         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1942         Set the storage namespace provider from the web page group.
1943
1944 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1945
1946         Should have copy and paste items in all text menus
1947         https://bugs.webkit.org/show_bug.cgi?id=139510
1948         <rdar://problem/19198388>
1949
1950         Reviewed by Beth Dakin.
1951
1952         * WebView/WebActionMenuController.mm:
1953         (-[WebActionMenuController _defaultMenuItemsForText]):
1954         Add a disabled paste menu item into the read-only text menu.
1955
1956         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1957         Add a disabled copy menu item into the editable whitespace text menu.
1958
1959 2014-12-10  Anders Carlsson  <andersca@apple.com>
1960
1961         Add WebStorageNamespaceProvider::closeLocalStorage
1962         https://bugs.webkit.org/show_bug.cgi?id=139502
1963
1964         Reviewed by Tim Horton.
1965
1966         * WebView/WebView.mm:
1967         (+[WebView _applicationWillTerminate]):
1968         Call WebStorageNamespaceProvider::closeLocalStorage.
1969
1970 2014-12-09  Commit Queue  <commit-queue@webkit.org>
1971
1972         Unreviewed, rolling out r177037.
1973         https://bugs.webkit.org/show_bug.cgi?id=139464
1974
1975         broke ~50 API tests (Requested by thorton on #webkit).
1976
1977         Reverted changeset:
1978
1979         "Use the new storage namespace provider in WebKit1"
1980         https://bugs.webkit.org/show_bug.cgi?id=139425
1981         http://trac.webkit.org/changeset/177037
1982
1983 2014-12-08  Anders Carlsson  <andersca@apple.com>
1984
1985         Use the new storage namespace provider in WebKit1
1986         https://bugs.webkit.org/show_bug.cgi?id=139425
1987
1988         Reviewed by Tim Horton.
1989
1990         * WebView/WebView.mm:
1991         (-[WebView _commonInitializationWithFrameName:groupName:]):
1992         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1993         Set the storage namespace provider from the web page group.
1994
1995 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
1996
1997         Delete Node::boundingBox()
1998         https://bugs.webkit.org/show_bug.cgi?id=139333
1999
2000         Reviewed by Zalan Bujtas.
2001
2002         * WebView/WebActionMenuController.mm:
2003         (elementBoundingBoxInWindowCoordinatesFromNode): Use
2004         RenderObject::absoluteBoundingBoxRect().
2005
2006 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
2007
2008         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
2009         https://bugs.webkit.org/show_bug.cgi?id=138843
2010         rdar://problem/18793695
2011
2012         Reviewed by Dan Bernstein.
2013
2014         * Panels/WebAuthenticationPanel.m:
2015         (-[WebAuthenticationPanel cancel:]):
2016         (-[WebAuthenticationPanel logIn:]):
2017         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
2018         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
2019         that only when using an old NSWindow API.
2020
2021 2014-12-08  Beth Dakin  <bdakin@apple.com>
2022
2023         Copy and Lookup menu items should be disabled when something is not copyable
2024         https://bugs.webkit.org/show_bug.cgi?id=139423
2025
2026         Reviewed by Tim Horton.
2027
2028         Disable both lookup and copy when a HitTestResult does not allow copy.
2029         * WebView/WebActionMenuController.mm:
2030
2031         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
2032         disable state otherwise.
2033         * WebView/WebView.mm:
2034         (-[WebView _commonInitializationWithFrameName:groupName:]):
2035
2036 2014-12-08  Anders Carlsson  <andersca@apple.com>
2037
2038         Adding user content to a group should force that group to be created
2039         https://bugs.webkit.org/show_bug.cgi?id=139421
2040         rdar://problem/19180108
2041
2042         Reviewed by Sam Weinig.
2043
2044         * WebCoreSupport/WebViewGroup.h:
2045         Store the local storage database path in the group.
2046
2047         * WebCoreSupport/WebViewGroup.mm:
2048         (WebViewGroup::getOrCreate):
2049         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
2050         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
2051
2052         (WebViewGroup::WebViewGroup):
2053         Initialize the new member variable.
2054
2055         (WebViewGroup::storageNamespaceProvider):
2056         Create the namespace provider lazily.
2057
2058         * WebView/WebView.mm:
2059         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
2060         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
2061         Use getOrCreate instead of get.
2062
2063 2014-12-08  Anders Carlsson  <andersca@apple.com>
2064
2065         WebStorageNamespaceProvider should know about its local storage database path
2066         https://bugs.webkit.org/show_bug.cgi?id=139413
2067
2068         Reviewed by Andreas Kling.
2069
2070         * WebCoreSupport/WebViewGroup.h:
2071         * WebCoreSupport/WebViewGroup.mm:
2072         (WebViewGroup::getOrCreate):
2073         (WebViewGroup::WebViewGroup):
2074         * WebView/WebView.mm:
2075         (-[WebView _commonInitializationWithFrameName:groupName:]):
2076         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2077         (-[WebView setGroupName:]):
2078         (-[WebView groupName]): Deleted.
2079
2080 2014-12-08  Daniel Bates  <dabates@apple.com>
2081
2082         [iOS] Fix the WebKit build with the public SDK
2083
2084         Include header NSURLDownloadSPI.h.
2085
2086         * WebCoreSupport/WebFrameLoaderClient.mm:
2087
2088 2014-12-07  Dan Bernstein  <mitz@apple.com>
2089
2090         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
2091         https://bugs.webkit.org/show_bug.cgi?id=139348
2092
2093         Reviewed by Anders Carlsson.
2094
2095         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
2096         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
2097         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
2098         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
2099         avoiding the ambiguity.
2100
2101         * WebView/WebActionMenuController.mm:
2102         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2103
2104 2014-12-06  Anders Carlsson  <andersca@apple.com>
2105
2106         Add a stubbed out version of WebStorageNamespaceProvider
2107         https://bugs.webkit.org/show_bug.cgi?id=139213
2108
2109         Reviewed by Sam Weinig.
2110
2111         * WebCoreSupport/WebViewGroup.h:
2112         (WebViewGroup::storageNamespaceProvider):
2113         * WebCoreSupport/WebViewGroup.mm:
2114         (WebViewGroup::getOrCreate):
2115         (WebViewGroup::WebViewGroup):
2116         Give WebViewGroup a storage namespace provider.
2117
2118 2014-12-06  Anders Carlsson  <andersca@apple.com>
2119
2120         Fix build with newer versions of clang.
2121         rdar://problem/18978687
2122
2123         Add missing overrides and missing casts.
2124
2125         * Storage/WebDatabaseManagerClient.h:
2126         * Storage/WebStorageTrackerClient.h:
2127         * WebCoreSupport/WebChromeClient.h:
2128         * WebCoreSupport/WebFrameLoaderClient.h:
2129         * WebCoreSupport/WebInspectorClient.h:
2130         * WebView/WebDataSource.mm:
2131         (-[WebDataSource _makeRepresentation]):
2132         * WebView/WebFrameView.mm:
2133         (-[WebFrameView _makeDocumentViewForDataSource:]):
2134
2135 2014-12-05  Tim Horton  <timothy_horton@apple.com>
2136
2137         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
2138         https://bugs.webkit.org/show_bug.cgi?id=139306
2139         <rdar://problem/19157955>
2140
2141         Reviewed by Beth Dakin.
2142
2143         * WebView/WebView.mm:
2144         (-[WebView _commonInitializationWithFrameName:groupName:]):
2145         (-[WebView _initWithFrame:frameName:groupName:]):
2146         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
2147
2148 2014-12-05  David Kilzer  <ddkilzer@apple.com>
2149
2150         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
2151         <http://webkit.org/b/139286>
2152
2153         Reviewed by Daniel Bates.
2154
2155         * Configurations/FeatureDefines.xcconfig: Switch back to using
2156         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
2157
2158 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
2159
2160         Fix the 32-bit build.
2161
2162         * WebView/WebView.mm:
2163         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2164
2165 2014-12-04  Tim Horton  <timothy_horton@apple.com>
2166
2167         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
2168         https://bugs.webkit.org/show_bug.cgi?id=139252
2169         <rdar://problem/19140827>
2170
2171         Reviewed by Anders Carlsson.
2172
2173         * WebView/WebView.mm:
2174         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2175         Adjust to the WebCore changes.
2176
2177 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
2178
2179         Implement action menus for tel: URLs
2180         https://bugs.webkit.org/show_bug.cgi?id=139240
2181         <rdar://problem/19115662>
2182
2183         Reviewed by Anders Carlsson.
2184
2185         * WebView/WebActionMenuController.mm:
2186         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2187         Make sure to use the newly created currentActionContext... everywhere.
2188
2189 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
2190
2191         Implement action menus for tel: URLs
2192         https://bugs.webkit.org/show_bug.cgi?id=139240
2193         <rdar://problem/19115662>
2194
2195         Reviewed by Anders Carlsson.
2196
2197         * WebView/WebActionMenuController.mm:
2198         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2199         Make sure to use the newly created currentActionContext.
2200
2201 2014-12-03  Beth Dakin  <bdakin@apple.com>
2202
2203         <input> elements get whitespace action menu instead of editable text menu
2204         https://bugs.webkit.org/show_bug.cgi?id=139241
2205         -and corresponding-
2206         rdar://problem/19072083
2207
2208         Reviewed by Sam Weinig.
2209
2210         We should disallow shadow content in the hit test. This is the default and it is 
2211         how context menus behave. We originally wanted to text inside shadow content so 
2212         that we could find the text, but the new function I added to HitTestResult will 
2213         allow that.
2214         * WebView/WebActionMenuController.mm:
2215         (-[WebActionMenuController performHitTestAtPoint:]):
2216
2217         Adjust to the fact that we don’t hit test shadow content any more.
2218         (-[WebActionMenuController focusAndSelectHitTestResult]):
2219
2220         Offer the text menus for text inside form controls.
2221         (-[WebActionMenuController _defaultMenuItems]):
2222
2223 2014-12-03  Tim Horton  <timothy_horton@apple.com>
2224
2225         Implement action menus for tel: URLs
2226         https://bugs.webkit.org/show_bug.cgi?id=139240
2227         <rdar://problem/19115662>
2228
2229         Reviewed by Anders Carlsson.
2230
2231         * WebView/WebActionMenuController.mm:
2232         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
2233         Rename this function as it will work for both mailto and tel URLs.
2234         Adjust it to use contextForView:.
2235
2236         (-[WebActionMenuController webView:willHandleMouseDown:]):
2237         (-[WebActionMenuController prepareForMenu:withEvent:]):
2238         (-[WebActionMenuController didCloseMenu:withEvent:]):
2239         (-[WebActionMenuController _defaultMenuItems]):
2240         Don't check the menu type when going to interact with _currentActionContext.
2241         We'll only have a _currentActionContext if we have a data detected item,
2242         and there are multiple menu types that end up using DDActionContext.
2243
2244         * WebView/WebUIDelegatePrivate.h:
2245         Add a new type.
2246
2247 2014-12-03  Anders Carlsson  <andersca@apple.com>
2248
2249         Set a visited link store when creating a simple WebView
2250         https://bugs.webkit.org/show_bug.cgi?id=139234
2251         <rdar://problem/19132978>
2252
2253         Reviewed by Sam Weinig.
2254
2255         * WebView/WebView.mm:
2256         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2257
2258 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
2259
2260         Fix the build.
2261
2262         * WebCoreSupport/WebFrameLoaderClient.mm:
2263
2264 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
2265
2266         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
2267         https://bugs.webkit.org/show_bug.cgi?id=139149
2268
2269         Reviewed by Anders Carlsson.
2270
2271         This changes API behavior. I think that it's OK, because existing behavior made no sense.
2272         We used to delete caches from disk, but they were still active in memory. Now we also
2273         obsolete them in memory, so documents that use a cache still work, but new ones don't
2274         pick one up.
2275
2276         * WebCoreSupport/WebApplicationCache.mm:
2277         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
2278         need to delete in-momry caches too. Keep existing behavior.
2279         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
2280         that properly deletes caches.
2281
2282 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2283
2284         Remove a SnowLeopard-era quirk for QuickLook
2285         https://bugs.webkit.org/show_bug.cgi?id=139208
2286         <rdar://problem/19121822>
2287
2288         Reviewed by Alexey Proskuryakov.
2289
2290         * WebCoreSupport/WebFrameLoaderClient.h:
2291         * WebCoreSupport/WebFrameLoaderClient.mm:
2292
2293 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2294
2295         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
2296         https://bugs.webkit.org/show_bug.cgi?id=139204
2297
2298         Reviewed by Anders Carlsson.
2299
2300         * WebView/WebView.mm:
2301         (-[WebView _commonInitializationWithFrameName:groupName:]):
2302         (-[WebView _showDictionaryLookupPopup:]):
2303         * WebView/WebViewData.h:
2304         Work around this by delaying the softlinking (and setting up the notification
2305         observer) until we actually need it. There's still an underlying bug, but
2306         this will fix the test.
2307
2308 2014-12-02  Beth Dakin  <bdakin@apple.com>
2309
2310         Yet another build fix.
2311
2312         * WebView/WebActionMenuController.mm:
2313         (-[WebActionMenuController _defaultMenuItemsForLink]):
2314
2315 2014-12-02  Beth Dakin  <bdakin@apple.com>
2316
2317         Build fix.
2318
2319         * WebView/WebActionMenuController.mm:
2320         (-[WebActionMenuController _defaultMenuItemsForLink]):
2321
2322 2014-12-02  Beth Dakin  <bdakin@apple.com>
2323
2324         More build fixing.
2325
2326         * WebView/WebActionMenuController.mm:
2327         (-[WebActionMenuController _defaultMenuItemsForLink]):
2328
2329 2014-12-02  Beth Dakin  <bdakin@apple.com>
2330
2331         Should use standardQuickLookMenuItem for apps that don't implement customizations
2332         https://bugs.webkit.org/show_bug.cgi?id=139193
2333         -and corresponding-
2334         rdar://problem/18944696
2335
2336         Reviewed by Anders Carlsson.
2337
2338         Use [NSMenuItem standardQuickLookMenuItem].
2339         * WebView/WebActionMenuController.mm:
2340         (-[WebActionMenuController _defaultMenuItemsForLink]):
2341
2342         Delegate methods to set up the standardQuickLookMenuItem.
2343         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
2344         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
2345         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
2346
2347         Remove all of the old QLPreviewBubble code.
2348         (-[WebActionMenuController _createActionMenuItemForTag:]):
2349         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
2350
2351 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
2352
2353         Fix the build.
2354
2355         * WebView/WebViewData.h:
2356
2357 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2358
2359         Implement Lookup transition from selection for Legacy WebKit
2360         https://bugs.webkit.org/show_bug.cgi?id=139180
2361         <rdar://problem/19067172>
2362
2363         Reviewed by Beth Dakin.
2364
2365         * WebView/DictionaryPopupInfo.h: Added.
2366         Split DictionaryPopupInfo out into its own file.
2367
2368         * WebView/WebActionMenuController.mm:
2369         (-[WebActionMenuController _lookupText:]):
2370         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
2371
2372         (performDictionaryLookupForSelection):
2373         (performDictionaryLookupForRange):
2374         Plumb the transition style through these helpers.
2375         Create a TextIndicator from the selection range.
2376
2377         * WebView/WebHTMLView.mm:
2378         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2379         Make use of TextIndicator (and DictionaryPopupInfo, and the new
2380         _showDictionaryLookupPopup on WebView) to add a transition from blue
2381         when performing Lookup from the context menu.
2382
2383         (-[WebHTMLView quickLookWithEvent:]):
2384         Remove our TextIndicator whenever a normal three-finger-tap event
2385         comes through, as it will have its own indication.
2386
2387         * WebView/WebView.mm:
2388         (-[WebView _commonInitializationWithFrameName:groupName:]):
2389         (-[WebView _dictionaryLookupPopoverWillClose:]):
2390         Register for the LUNotificationPopoverWillClose notification and remove
2391         our TextIndicator when it is called, just like in WebKit2.
2392         Deregistration is already handled in _close.
2393
2394         (-[WebView _showDictionaryLookupPopup:]):
2395         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
2396         if the relevant API is available.
2397
2398         * WebView/WebViewInternal.h:
2399
2400 2014-12-02  Anders Carlsson  <andersca@apple.com>
2401
2402         Remove visited link handling from PageGroup
2403         https://bugs.webkit.org/show_bug.cgi?id=139185
2404
2405         Reviewed by Sam Weinig.
2406
2407         * History/WebHistory.mm:
2408         (-[WebHistoryPrivate removeItemForURLString:]):
2409         (-[WebHistoryPrivate removeAllItems]):
2410         (+[WebHistory setOptionalSharedHistory:]):
2411         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
2412         (+[WebHistory _removeAllVisitedLinks]):
2413         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
2414         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
2415         * History/WebHistoryInternal.h:
2416         * WebCoreSupport/WebChromeClient.h:
2417         * WebCoreSupport/WebChromeClient.mm:
2418         (WebChromeClient::populateVisitedLinks): Deleted.
2419         * WebView/WebView.mm:
2420         (-[WebView addVisitedLinks:]):
2421         (-[WebView removeVisitedLink:]):
2422
2423 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
2424
2425         Try to fix the Mac build.
2426
2427         * WebView/WebView.mm:
2428         (-[WebView _commonInitializationWithFrameName:groupName:]):
2429         (-[WebView _close]):
2430
2431 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
2432
2433         Fix the iOS build.
2434
2435         * WebView/WebActionMenuController.h:
2436         * WebView/WebActionMenuController.mm:
2437         * WebView/WebHTMLView.mm:
2438         (-[WebHTMLView scrollWheel:scrollWheel:]):
2439         (-[WebHTMLView mouseDown:mouseDown:]):
2440         * WebView/WebView.mm:
2441         * WebView/WebViewData.h:
2442         * WebView/WebViewData.mm:
2443         (-[WebViewPrivate dealloc]):
2444         * WebView/WebViewInternal.h:
2445
2446 2014-12-01  Tim Horton  <timothy_horton@apple.com>
2447
2448         Implement yellow highlight for WebKit1 data detectors
2449         https://bugs.webkit.org/show_bug.cgi?id=138956
2450         <rdar://problem/18992185>
2451
2452         Reviewed by Beth Dakin.
2453
2454         * WebView/WebActionMenuController.h:
2455         * WebView/WebActionMenuController.mm:
2456         (-[WebActionMenuController webView:willHandleMouseDown:]):
2457         (-[WebActionMenuController webView:didHandleScrollWheel:]):
2458         (-[WebActionMenuController prepareForMenu:withEvent:]):
2459         (-[WebActionMenuController didCloseMenu:withEvent:]):
2460         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2461         (-[WebActionMenuController _showTextIndicator]):
2462         (-[WebActionMenuController _hideTextIndicator]):
2463         (-[WebActionMenuController _dismissActionMenuPopovers]):
2464         Copy the WebKit2 WKActionMenuController TextIndicator implementation
2465         into WebActionMenuController. The only significant difference is
2466         that we build the TextIndicator right at menu construction time
2467         instead of in the Web process.
2468
2469         * WebView/WebHTMLView.mm:
2470         (-[WebHTMLView scrollWheel:]):
2471         Let the WebActionMenuController know that we're handling a scroll.
2472
2473         (-[WebHTMLView mouseDown:]):
2474         Let the WebActionMenuController know that we're handling a mouseDown.
2475
2476         * WebView/WebView.mm:
2477         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2478         (-[WebView _clearTextIndicator]):
2479         (-[WebView _actionMenuController]):
2480         (-[WebView _convertRectFromRootView:]): Deleted.
2481         * WebView/WebViewData.h:
2482         * WebView/WebViewData.mm:
2483         * WebView/WebViewInternal.h:
2484         Keep a TextIndicatorWindow on WebView, just like WKView does.
2485         Expose the WebActionMenuController on WebView (internally).
2486
2487 2014-12-01  Anders Carlsson  <andersca@apple.com>
2488
2489         Remove old site specific quirks code that was added in 2009
2490         https://bugs.webkit.org/show_bug.cgi?id=139141
2491
2492         Reviewed by Antti Koivisto.
2493
2494         * WebCoreSupport/WebFrameNetworkingContext.h:
2495         * WebCoreSupport/WebFrameNetworkingContext.mm:
2496         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
2497
2498 2014-11-30  Anders Carlsson  <andersca@apple.com>
2499
2500         Fix a test failure.
2501
2502         * History/WebHistory.mm:
2503         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
2504         Call through to the visited link store.
2505
2506         (+[WebHistory _removeAllVisitedLinks]):
2507         Ditto.
2508
2509         * WebCoreSupport/WebVisitedLinkStore.mm:
2510         (WebVisitedLinkStore::isLinkVisited):
2511         Make sure to populate visited links.
2512
2513 2014-11-30  Anders Carlsson  <andersca@apple.com>
2514
2515         Switch over to the visited link store from the WebViewGroup
2516         https://bugs.webkit.org/show_bug.cgi?id=139112
2517
2518         Reviewed by Sam Weinig.
2519
2520         * WebView/WebView.mm:
2521         (-[WebView _commonInitializationWithFrameName:groupName:]):
2522         (-[WebView setGroupName:]):
2523
2524 2014-11-30  Anders Carlsson  <andersca@apple.com>
2525
2526         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
2527         https://bugs.webkit.org/show_bug.cgi?id=139111
2528
2529         Reviewed by Sam Weinig.
2530
2531         * WebCoreSupport/WebVisitedLinkStore.h:
2532         * WebCoreSupport/WebVisitedLinkStore.mm:
2533         (WebVisitedLinkStore::removeVisitedLink):
2534         * WebView/WebView.mm:
2535         (-[WebView removeVisitedLink:]):
2536
2537 2014-11-29  Anders Carlsson  <andersca@apple.com>
2538
2539         Populate visited links
2540         https://bugs.webkit.org/show_bug.cgi?id=139101
2541
2542         Reviewed by Sam Weinig.
2543
2544         * History/WebHistory.mm:
2545         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
2546         Helper function that adds all visited link to the given store.
2547
2548         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
2549         Call the private method.
2550
2551         * History/WebHistoryInternal.h:
2552         * WebCoreSupport/WebVisitedLinkStore.h:
2553         Add new members.
2554
2555         * WebCoreSupport/WebVisitedLinkStore.mm:
2556         (WebVisitedLinkStore::addVisitedLink):
2557         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
2558
2559         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
2560         Implement this. First try the delegate, then try the shared history.
2561
2562         (WebVisitedLinkStore::addVisitedLinkHash):
2563         Factor code that adds the link to the hash table into a separate function.
2564
2565         * WebView/WebView.mm:
2566         (-[WebView addVisitedLinks:]):
2567         Add the visited links to the store.
2568
2569 2014-11-29  Anders Carlsson  <andersca@apple.com>
2570
2571         More work on the legacy WebKit visited link store
2572         https://bugs.webkit.org/show_bug.cgi?id=139100
2573
2574         Reviewed by Sam Weinig.
2575
2576         * History/WebHistory.mm:
2577         (+[WebHistory setOptionalSharedHistory:]):
2578         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
2579
2580         * WebCoreSupport/WebVisitedLinkStore.h:
2581         * WebCoreSupport/WebVisitedLinkStore.mm:
2582         (visitedLinkStores):
2583         (WebVisitedLinkStore::WebVisitedLinkStore):
2584         (WebVisitedLinkStore::~WebVisitedLinkStore):
2585         Keep track of live visited link stores.
2586
2587         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
2588         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
2589
2590         (WebVisitedLinkStore::removeAllVisitedLinks):
2591         Iterate over all live link stores and remove their links.
2592
2593         (WebVisitedLinkStore::isLinkVisited):
2594         Populate visited links and check if our hash table contains the link.
2595
2596         (WebVisitedLinkStore::addVisitedLink):
2597         Add the link hash to the table.
2598
2599         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
2600         Add stub.
2601
2602         (WebVisitedLinkStore::removeVisitedLinkHashes):
2603         Clear out the hash table.
2604
2605 2014-11-27  Anders Carlsson  <andersca@apple.com>
2606
2607         Add a stubbed out WebVisitedLinkStore to WebViewGroup
2608         https://bugs.webkit.org/show_bug.cgi?id=139066
2609
2610         Reviewed by Antti Koivisto.
2611
2612         * WebCoreSupport/WebViewGroup.h:
2613         (WebViewGroup::visitedLinkStore):
2614         * WebCoreSupport/WebViewGroup.mm:
2615         (WebViewGroup::WebViewGroup):
2616         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
2617         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
2618         (WebVisitedLinkStore::create):
2619         (WebVisitedLinkStore::WebVisitedLinkStore):
2620         (WebVisitedLinkStore::~WebVisitedLinkStore):
2621         (WebVisitedLinkStore::isLinkVisited):
2622         (WebVisitedLinkStore::addVisitedLink):
2623
2624 2014-11-25  Anders Carlsson  <andersca@apple.com>
2625
2626         Remove user content handling from PageGroup
2627         https://bugs.webkit.org/show_bug.cgi?id=139051
2628
2629         Reviewed by Antti Koivisto.
2630
2631         Use the user content controller in the web view group.
2632
2633         * WebView/WebView.mm:
2634         (-[WebView _injectOutlookQuirksScript]):
2635
2636 2014-11-25  Anders Carlsson  <andersca@apple.com>
2637
2638         Add a user content controller to WebViewGroup and use it for user content
2639         https://bugs.webkit.org/show_bug.cgi?id=139043
2640
2641         Reviewed by Antti Koivisto.
2642
2643         This is another tiny step towards getting rid of user content handling inside PageGroup.
2644
2645         * WebCoreSupport/WebViewGroup.h:
2646         (WebViewGroup::userContentController):
2647         Add a UserContentController member and getter.
2648
2649         * WebCoreSupport/WebViewGroup.mm:
2650         (WebViewGroup::get):
2651         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
2652
2653         (WebViewGroup::WebViewGroup):
2654         Create a user content controller.
2655
2656         * WebView/WebView.mm:
2657         (-[WebView _commonInitializationWithFrameName:groupName:]):
2658         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
2659         set its user content controller in the PageConfiguration.
2660
2661         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2662         Ditto.
2663
2664         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
2665         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
2666         (+[WebView _removeUserScriptFromGroup:world:url:]):
2667         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
2668         (+[WebView _removeUserScriptsFromGroup:world:]):
2669         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
2670         (+[WebView _removeAllUserContentFromGroup:]):
2671         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
2672
2673         (-[WebView setGroupName:]):
2674         Set the user content controller to the new WebViewGroup's user content controller.
2675
2676 2014-11-21  Jer Noble  <jer.noble@apple.com>
2677
2678         Support multiple signatures of diagnostic logging.
2679         https://bugs.webkit.org/show_bug.cgi?id=138690
2680
2681         Reviewed by Anders Carlsson.
2682
2683         Page::PageClients has been renamed PageConfiguration.
2684
2685         * WebView/WebView.mm:
2686         (-[WebView _commonInitializationWithFrameName:groupName:]):
2687         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2688
2689 2014-11-21  Zalan Bujtas  <zalan@apple.com>
2690
2691         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
2692         https://bugs.webkit.org/show_bug.cgi?id=138981
2693
2694         Reviewed by Simon Fraser.
2695
2696         * WebView/WebPreferenceKeysPrivate.h:
2697         * WebView/WebPreferences.mm:
2698         (+[WebPreferences initialize]):
2699         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
2700         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
2701         * WebView/WebPreferencesPrivate.h:
2702         * WebView/WebView.mm:
2703         (-[WebView _preferencesChanged:]):
2704
2705 2014-11-21  Tim Horton  <timothy_horton@apple.com>
2706
2707         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2708         ​https://bugs.webkit.org/show_bug.cgi?id=138960
2709         <rdar://problem/19056715>
2710
2711         Reviewed by Anders Carlsson.
2712
2713         * WebView/WebActionMenuController.mm:
2714         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2715         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2716         Use DataDetectors SPI instead of an explicit blacklist.
2717
2718 2014-11-21  Tim Horton  <timothy_horton@apple.com>
2719
2720         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2721         https://bugs.webkit.org/show_bug.cgi?id=138960
2722         <rdar://problem/19056715>
2723
2724         Reviewed by Beth Dakin.
2725
2726         * WebView/WebActionMenuController.mm:
2727         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2728         Blacklist contact results, because they don't have useful menus. If we
2729         bail before setting up _currentActionContext, we'll still allow fallthrough
2730         to ordinary text actions, avoiding mysterious failure when a contact is detected.
2731
2732         This doesn't break the case that r176351 was intended to fix,
2733         because in that case we were detecting e.g. addresses.
2734
2735 2014-11-21  Anders Carlsson  <andersca@apple.com>
2736
2737         Remove the Timer parameters from timer callbacks
2738         https://bugs.webkit.org/show_bug.cgi?id=138974
2739
2740         Reviewed by Antti Koivisto.
2741
2742         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2743         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2744         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
2745         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2746         * Plugins/WebNetscapePluginStream.h:
2747         * Plugins/WebNetscapePluginStream.mm:
2748         (WebNetscapePluginStream::WebNetscapePluginStream):
2749         (WebNetscapePluginStream::deliverDataTimerFired):
2750
2751 2014-11-21  Anders Carlsson  <andersca@apple.com>
2752
2753         Make memoryCache() return a reference
2754         https://bugs.webkit.org/show_bug.cgi?id=138939
2755
2756         Reviewed by Antti Koivisto.
2757
2758         * Misc/WebCache.mm:
2759         (+[WebCache statistics]):
2760         (+[WebCache emptyInMemoryResources]):
2761         (+[WebCache sizeOfDeadResources:]):
2762         (+[WebCache addImageToCache:forURL:forFrame:]):
2763         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2764         (+[WebCache imageForURL:]):
2765         (+[WebCache setDisabled:]):
2766         (+[WebCache isDisabled]):
2767         * WebView/WebView.mm:
2768         (+[WebView _setCacheModel:]):
2769
2770 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
2771
2772         Remove the remaining vestiges of minimal-ui
2773         https://bugs.webkit.org/show_bug.cgi?id=138890
2774
2775         Reviewed by Sam Weinig.
2776
2777         * History/WebHistoryItem.mm:
2778         * History/WebHistoryItemPrivate.h:
2779
2780 2014-11-20  Tim Horton  <timothy_horton@apple.com>
2781
2782         Cancel DataDetectors menu earlier if we know it can't be presented
2783         https://bugs.webkit.org/show_bug.cgi?id=138922
2784         <rdar://problem/18950441>
2785
2786         Reviewed by Beth Dakin.
2787
2788         * WebView/WebActionMenuController.mm:
2789         (-[WebActionMenuController prepareForMenu:withEvent:]):
2790         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
2791         and use a bigger hammer (removeAllItems).
2792
2793         (-[WebActionMenuController willOpenMenu:withEvent:]):
2794         If we end up with a menu with no items, don't change selection or anything.
2795
2796 2014-11-20  Beth Dakin  <bdakin@apple.com>
2797
2798         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
2799         https://bugs.webkit.org/show_bug.cgi?id=138568
2800         -and corresponding-
2801         rdar://problem/18904600
2802
2803         Reviewed by Tim Horton.
2804
2805         Skip images for lookup.
2806         * WebView/WebActionMenuController.mm:
2807         (performDictionaryLookupForRange):
2808
2809 2014-11-19  Beth Dakin  <bdakin@apple.com>
2810
2811         Invoking an action menu on a selection should result in the text menu
2812         https://bugs.webkit.org/show_bug.cgi?id=138892
2813         -and corresponding-
2814         rdar://problem/18996776
2815
2816         Reviewed by Tim Horton.
2817
2818         * WebView/WebActionMenuController.mm:
2819         (-[WebActionMenuController _defaultMenuItems]):
2820
2821 2014-11-19  Beth Dakin  <bdakin@apple.com>
2822
2823         Data detected results with no menu items should not fall through to regular text 
2824         action menus
2825         https://bugs.webkit.org/show_bug.cgi?id=138887
2826         -and corresponding-
2827         rdar://problem/18971616
2828
2829         Reviewed by Tim Horton.
2830
2831         * WebView/WebActionMenuController.mm:
2832         (-[WebActionMenuController _defaultMenuItems]):
2833
2834 2014-11-19  Daniel Bates  <dabates@apple.com>
2835
2836         [iOS] Make WebKit build with public iOS SDK
2837         https://bugs.webkit.org/show_bug.cgi?id=136863
2838
2839         Reviewed by David Kilzer.
2840
2841         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
2842         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
2843         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
2844         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
2845         may be used by Apple internal clients that do not include wtf/Platform.h.
2846         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
2847         private Foundation headers directly.
2848         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
2849         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
2850         instead of including private CFNetwork headers directly. Also fixed up style and
2851         ordering of header include directives.
2852         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
2853         CFNetwork headers directly. Also sort the #import directives.
2854         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
2855         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
2856
2857 2014-11-18  David Kilzer  <ddkilzer@apple.com>
2858
2859         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
2860         <http://webkit.org/b/138813>
2861
2862         Reviewed by Mark Rowe.
2863
2864         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
2865         selectors.
2866
2867 2014-11-18  Chris Dumez  <cdumez@apple.com>
2868
2869         Add a setting to toggle DOMTimer throttling support
2870         https://bugs.webkit.org/show_bug.cgi?id=138844
2871         <rdar://problem/19020874>
2872
2873         Reviewed by Andreas Kling.
2874
2875         Add a setting to disable DOM timers throttling, in order to help
2876         developers determine if a specific issue is caused by timer
2877         throttling.
2878
2879         * WebView/WebPreferenceKeysPrivate.h:
2880         * WebView/WebPreferences.mm:
2881         (+[WebPreferences initialize]):
2882         (-[WebPreferences domTimersThrottlingEnabled]):
2883         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
2884         * WebView/WebPreferencesPrivate.h:
2885         * WebView/WebView.mm:
2886         (-[WebView _preferencesChanged:]):
2887
2888 2014-11-18  Tim Horton  <timothy_horton@apple.com>
2889
2890         Avoid re-encoding action menu image data
2891         https://bugs.webkit.org/show_bug.cgi?id=138817
2892         <rdar://problem/18840382>
2893
2894         Reviewed by Anders Carlsson.
2895
2896         * WebView/WebActionMenuController.mm:
2897         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2898         (-[WebActionMenuController _addImageToPhotos:]):
2899         Build a temporary filename from a UUID and the image's desired extension.
2900         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
2901         Build an image menu only if we have an image, URL, data, and extension.
2902
2903 2014-11-18  Daniel Bates  <dabates@apple.com>
2904
2905         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2906         SPI are not available in public SDK
2907         https://bugs.webkit.org/show_bug.cgi?id=138802
2908
2909         Reviewed by David Kilzer.
2910
2911         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2912         libdispatch and MobileGestalt headers directly.
2913
2914         * WebView/WebView.mm:
2915
2916 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
2917
2918         Remove calls to deprecated NSMenu methods
2919         https://bugs.webkit.org/show_bug.cgi?id=138808.
2920
2921         Reviewed by Anders Carlsson.
2922
2923         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
2924
2925         * WebCoreSupport/PopupMenuMac.mm:
2926         (PopupMenuMac::populate):
2927
2928 2014-11-17  Daniel Bates  <dabates@apple.com>
2929
2930         Unreviewed, rolling out r176232.
2931
2932         Broke the Mac build. Will investigate offline.
2933
2934         Reverted changeset:
2935
2936         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2937         MobileGestalt"
2938         https://bugs.webkit.org/show_bug.cgi?id=138802
2939         http://trac.webkit.org/changeset/176232
2940
2941 2014-11-17  Daniel Bates  <dabates@apple.com>
2942
2943         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2944         SPI are not available in public SDK
2945         https://bugs.webkit.org/show_bug.cgi?id=138802
2946
2947         Reviewed by David Kilzer.
2948
2949         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2950         libdispatch and MobileGestalt headers directly.
2951
2952         * WebView/WebView.mm:
2953
2954 2014-11-17  Beth Dakin  <bdakin@apple.com>
2955
2956         Whitespace action menus should focus the HitTestResult and create an insertion 
2957         point
2958         https://bugs.webkit.org/show_bug.cgi?id=138786
2959         -and corresponding-
2960         rdar://problem/18944893
2961
2962         Reviewed by Tim Horton.
2963
2964         Whitespace menus should cause the HitTestResult to be focused, and they should set 
2965         the selection based on the HitTest location.
2966
2967         * WebView/WebActionMenuController.mm:
2968         (-[WebActionMenuController isMenuForTextContent]):
2969         (-[WebActionMenuController focusAndSelectHitTestResult]):
2970         (-[WebActionMenuController willOpenMenu:withEvent:]):
2971
2972 2014-11-17  Daniel Bates  <dabates@apple.com>
2973
2974         [iOS] QuartzCore SPI not available in public SDK
2975         https://bugs.webkit.org/show_bug.cgi?id=138751
2976
2977         Reviewed by David Kilzer.
2978
2979         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
2980
2981         * WebInspector/WebNodeHighlight.mm:
2982         * WebView/WebIndicateLayer.mm:
2983
2984 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
2985
2986         [iOS] allow host application to opt-out of alternate fullscreen
2987         https://bugs.webkit.org/show_bug.cgi?id=138787
2988
2989         Reviewed by Darin Adler.
2990
2991         * WebView/WebPreferenceKeysPrivate.h:
2992         * WebView/WebPreferences.mm:
2993         (+[WebPreferences initialize]):
2994         (-[WebPreferences allowsAlternateFullscreen]):
2995         (-[WebPreferences setAllowsAlternateFullscreen:]):
2996         * WebView/WebPreferencesPrivate.h:
2997         * WebView/WebView.mm:
2998         (-[WebView _preferencesChanged:]):
2999
3000 2014-11-16  Tim Horton  <timothy_horton@apple.com>
3001
3002         Use TextIndicator instead of the built in Lookup highlight
3003         https://bugs.webkit.org/show_bug.cgi?id=138775
3004         <rdar://problem/18953982>
3005
3006         Reviewed by Anders Carlsson.
3007
3008         * WebCoreSupport/WebSystemInterface.mm:
3009         (InitWebCoreSystemInterface):
3010         Remove a WKSI import.
3011
3012         * WebView/WebActionMenuController.mm:
3013         (-[WebActionMenuController _lookupText:]):
3014         (-[WebActionMenuController _createActionMenuItemForTag:]):
3015         Make use of the new Lookup SPI header.
3016         Disable the Lookup item if lookup is not available.
3017
3018 2014-11-15  Tim Horton  <timothy_horton@apple.com>
3019
3020         Implement data detectors and mailto action menus for WebKit1
3021         https://bugs.webkit.org/show_bug.cgi?id=138765
3022         <rdar://problem/18877535>
3023
3024         Reviewed by Beth Dakin.
3025
3026         * WebView/WebActionMenuController.h:
3027         * WebView/WebActionMenuController.mm:
3028         (-[WebActionMenuController willOpenMenu:withEvent:]):
3029         Tell DataDetectors that the menu is going to open.
3030         Select the text (or not) based on the number of items in the menu, just like WebKit2.
3031
3032         (-[WebActionMenuController didCloseMenu:withEvent:]):
3033         Tell DataDetectors that the menu closed.
3034
3035         (-[WebActionMenuController _defaultMenuItemsForLink]):
3036         Move these checks out of _defaultMenuItemsForLink, because we expect this
3037         to always return a complete link menu.
3038
3039         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
3040         Implement. More or less copied from WebKit2.
3041
3042         (-[WebActionMenuController _selectDataDetectedText]):
3043         Select the stashed range.
3044
3045         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3046         Implement. More or less copied from WebKit2.
3047         The yellow highlight isn't hooked up yet.
3048         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
3049
3050         (-[WebActionMenuController _selectLookupText]):
3051         Remove an unnecessary return.
3052
3053         (-[WebActionMenuController _defaultMenuItems]):
3054         Call into the two new menu types.
3055
3056         * WebView/WebUIDelegatePrivate.h:
3057
3058 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
3059
3060         Get rid of WebFontCache
3061         https://bugs.webkit.org/show_bug.cgi?id=134752
3062
3063         Reviewed by Dave Hyatt.
3064
3065         * WebView/WebHTMLView.mm:
3066
3067 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
3068
3069         Update some artwork for the legacy WebKit action menu
3070         https://bugs.webkit.org/show_bug.cgi?id=138758
3071         <rdar://problem/18989840>
3072
3073         * WebView/WebActionMenuController.mm:
3074         (webKitBundleImageNamed): Deleted.
3075         Fix the build.
3076
3077 2014-11-14  Tim Horton  <timothy_horton@apple.com>
3078
3079         Update some artwork for the legacy WebKit action menu
3080         https://bugs.webkit.org/show_bug.cgi?id=138758
3081         <rdar://problem/18989840>
3082
3083         Reviewed by Simon Fraser.
3084
3085         * WebView/WebActionMenuController.mm:
3086         (-[WebActionMenuController _createActionMenuItemForTag:]):
3087
3088 2014-11-14  Daniel Bates  <dabates@apple.com>
3089
3090         [iOS] NSFileManager and QuickLook SPI not available in public SDK
3091         https://bugs.webkit.org/show_bug.cgi?id=138742
3092
3093         Reviewed by Pratik Solanki.
3094
3095         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
3096
3097         * WebCoreSupport/WebFrameLoaderClient.mm:
3098
3099 2014-11-14  Beth Dakin  <bdakin@apple.com>
3100
3101         WK1: Webpage preview can come up in wrong location
3102         https://bugs.webkit.org/show_bug.cgi?id=138747
3103         -and corresponding-
3104         rdar://problem/18979004
3105
3106         Reviewed by Tim Horton.
3107
3108         Converting to window twice is bad.
3109         * WebView/WebActionMenuController.mm:
3110         (elementBoundingBoxInWindowCoordinatesFromNode):
3111         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3112         (elementBoundingBoxFromNode): Deleted.
3113
3114 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
3115
3116         Move FontMac and FontCacheMac off of WKSI
3117         https://bugs.webkit.org/show_bug.cgi?id=138633
3118
3119         Reviewed by Simon Fraser.
3120
3121         * WebCoreSupport/WebSystemInterface.mm:
3122         (InitWebCoreSystemInterface):
3123         * WebKit.order:
3124
3125 2014-11-13  Beth Dakin  <bdakin@apple.com>
3126
3127         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
3128         https://bugs.webkit.org/show_bug.cgi?id=138716
3129         -and corresponding-
3130         rdar://problem/18977222
3131
3132         Reviewed by Tim Horton.
3133
3134         It’s not necessary to use the WebElementDictionary for so many things now that we 
3135         are caching the HitTestResult. We should just use the HitTestResult.
3136
3137         * WebView/WebActionMenuController.mm:
3138         (-[WebActionMenuController prepareForMenu:withEvent:]):
3139         (-[WebActionMenuController _openURLFromActionMenu:]):
3140         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3141         (elementBoundingBoxFromNode):
3142         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3143         (-[WebActionMenuController _defaultMenuItemsForLink]):
3144         (-[WebActionMenuController _defaultMenuItemsForImage]):
3145         (-[WebActionMenuController _defaultMenuItemsForVideo]):
3146         (-[WebActionMenuController _defaultMenuItemsForText]):
3147         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
3148         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
3149         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
3150         (-[WebActionMenuController _createActionMenuItemForTag:]):
3151         (-[WebActionMenuController _defaultMenuItems]):
3152         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
3153         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
3154         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
3155         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
3156         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
3157         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
3158         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
3159         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
3160         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
3161         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
3162
3163 2014-11-13  Daniel Bates  <dabates@apple.com>
3164
3165         [iOS] NSGeometry data types are not available in the public SDK
3166         https://bugs.webkit.org/show_bug.cgi?id=137536
3167
3168         Reviewed by David Kilzer.
3169
3170         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
3171         private header.
3172
3173         * DOM/WebDOMOperationsPrivate.h:
3174
3175 2014-11-13  Beth Dakin  <bdakin@apple.com>
3176
3177         WK1: Support default actions for video
3178         https://bugs.webkit.org/show_bug.cgi?id=138713
3179         -and corresponding-
3180         rdar://problem/18877520
3181
3182         Reviewed by Tim Horton.
3183
3184         Call setToNonShadowAncestor() for media HitTestResults.
3185         * WebView/WebActionMenuController.mm:
3186         (-[WebActionMenuController performHitTestAtPoint:]):
3187
3188         Default items and actions.
3189         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
3190         (-[WebActionMenuController _copyVideoURL:]):
3191         (-[WebActionMenuController _saveVideoToDownloads:]):
3192         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3193         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3194         * WebView/WebUIDelegatePrivate.h:
3195
3196 2014-11-13  Tim Horton  <timothy_horton@apple.com>
3197
3198         WK1: Update icon for Add to Reading List
3199         https://bugs.webkit.org/show_bug.cgi?id=138710
3200         <rdar://problem/18975774>
3201
3202         Reviewed by Beth Dakin.
3203
3204         * WebView/WebActionMenuController.mm:
3205         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3206         Use the right icon, matching WebKit2.
3207
3208 2014-11-12  Beth Dakin  <bdakin@apple.com>
3209
3210         WK1: Support default actions for images
3211         https://bugs.webkit.org/show_bug.cgi?id=138668
3212         -and corresponding-
3213         rdar://problem/18785434
3214
3215         Reviewed by Tim Horton.
3216
3217         * WebView/WebActionMenuController.h:
3218         * WebView/WebActionMenuController.mm:
3219         (-[WebActionMenuController didCloseMenu:withEvent:]):
3220         (-[WebActionMenuController _defaultMenuItemsForImage:]):
3221         (-[WebActionMenuController _copyImage:]):
3222         (temporaryPhotosDirectoryPath):
3223         (pathToPhotoOnDisk):
3224         (-[WebActionMenuController _canAddMediaToPhotos]):
3225         (-[WebActionMenuController _addImageToPhotos:]):
3226         (-[WebActionMenuController _saveImageToDownloads:]):
3227         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
3228         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
3229         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3230         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3231         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3232         * WebView/WebUIDelegatePrivate.h:
3233
3234 2014-11-11  Beth Dakin  <bdakin@apple.com>
3235
3236         Action menu hit testing is not working properly with all WK1 apps
3237         https://bugs.webkit.org/show_bug.cgi?id=138643
3238         -and corresponding-
3239         rdar://problem/18949376
3240
3241         Reviewed by Tim Horton.
3242
3243         * WebView/WebActionMenuController.mm:
3244         (-[WebActionMenuController prepareForMenu:withEvent:]):
3245         (-[WebActionMenuController _lookupText:]):
3246
3247 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
3248
3249         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
3250         https://bugs.webkit.org/show_bug.cgi?id=138623
3251
3252         Reviewed by Geoff Garen.
3253
3254         * WebCoreSupport/WebSystemInterface.mm:
3255         (InitWebCoreSystemInterface):
3256         * WebKit.order:
3257
3258 2014-11-11  Tim Horton  <timothy_horton@apple.com>
3259
3260         Localize strings for action menus
3261         https://bugs.webkit.org/show_bug.cgi?id=138591
3262         <rdar://problem/18815343>
3263
3264         Reviewed by Dan Bates.
3265
3266         * WebView/WebActionMenuController.mm:
3267         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3268         Make use of the new strings.
3269
3270 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
3271
3272         Cleanup from r175379
3273         https://bugs.webkit.org/show_bug.cgi?id=138616
3274
3275         Reviewed by Simon Fraser.
3276
3277         * WebCoreSupport/WebSystemInterface.mm:
3278         (InitWebCoreSystemInterface):
3279         * WebKit.order:
3280
3281 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
3282
3283         Move CTFontTransformGlyphs out from WKSI
3284         https://bugs.webkit.org/show_bug.cgi?id=138599
3285
3286         Reviewed by Simon Fraser.
3287
3288         * WebCoreSupport/WebSystemInterface.mm:
3289         (InitWebCoreSystemInterface):
3290         * WebKit.order:
3291
3292 2014-11-11  Dan Bernstein  <mitz@apple.com>
3293
3294         More iOS build fix.
3295
3296         * WebView/WebHTMLViewInternal.h:
3297
3298 2014-11-11  Dan Bernstein  <mitz@apple.com>
3299
3300         iOS build fix.
3301
3302         * WebView/WebHTMLView.mm:
3303
3304 2014-11-10  Beth Dakin  <bdakin@apple.com>
3305
3306         WK1: Support default actions for editable text with misspelled word
3307         https://bugs.webkit.org/show_bug.cgi?id=138590
3308         -and corresponding-
3309         rdar://problem/18877506
3310
3311         Reviewed by Tim Horton.
3312
3313         If there are misspelled word suggestions for editable text, create a new type of 
3314         menu with a spelling suggestion sub-menu.
3315
3316         * WebView/WebActionMenuController.mm:
3317         (-[WebActionMenuController isMenuForTextContent]):
3318         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
3319         (-[WebActionMenuController _changeSelectionToSuggestion:]):
3320         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3321         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3322         * WebView/WebHTMLView.mm:
3323         (-[WebHTMLView _changeSpellingToWord:]):
3324         * WebView/WebHTMLViewInternal.h:
3325         * WebView/WebUIDelegatePrivate.h:
3326
3327 2014-11-10  Beth Dakin  <bdakin@apple.com>
3328
3329         WK1: Support default actions for editable whitespace
3330         https://bugs.webkit.org/show_bug.cgi?id=138586
3331         -and corresponding-
3332         rdar://problem/18932048
3333
3334         Reviewed by Tim Horton.
3335
3336         New menu type. Just wants paste.
3337
3338         * WebView/WebActionMenuController.mm:
3339         (-[WebActionMenuController isMenuForTextContent]):
3340         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
3341         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3342         * WebView/WebUIDelegatePrivate.h:
3343
3344 2014-11-10  Beth Dakin  <bdakin@apple.com>
3345
3346         WK1: Support default actions for editable text
3347         https://bugs.webkit.org/show_bug.cgi?id=138580
3348         -and corresponding-
3349         rdar://problem/18877497
3350
3351         Reviewed by Tim Horton.
3352
3353         New menu type, and new action type for paste. 
3354
3355         * WebView/WebActionMenuController.mm:
3356         (-[WebActionMenuController isMenuForTextContent]):
3357         (-[WebActionMenuController willOpenMenu:withEvent:]):
3358         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
3359         (-[WebActionMenuController _paste:]):
3360         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3361         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3362         * WebView/WebUIDelegatePrivate.h:
3363
3364 2014-11-10  Beth Dakin  <bdakin@apple.com>
3365
3366         WK1: Text is getting selected even when an action menu fails to invoke
3367         https://bugs.webkit.org/show_bug.cgi?id=138576
3368         -and corresponding-
3369         rdar://problem/18931330
3370
3371         Reviewed by Tim Horton.
3372
3373         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
3374         * WebView/WebActionMenuController.h:
3375         * WebView/WebActionMenuController.mm:
3376         (-[WebActionMenuController prepareForMenu:withEvent:]):
3377         (-[WebActionMenuController willOpenMenu:withEvent:]):
3378
3379         _selectLookupText no longer needs to return a BOOL indicating success or failure.
3380         (-[WebActionMenuController _selectLookupText]):
3381         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3382
3383         Pass willOpenMenu: on to the controller.
3384         * WebView/WebView.mm:
3385         (-[WebView willOpenMenu:withEvent:]):
3386
3387 2014-11-10  Beth Dakin  <bdakin@apple.com>
3388
3389         Speculative build fix.
3390
3391         * WebView/WebActionMenuController.mm:
3392
3393 2014-11-10  Beth Dakin  <bdakin@apple.com>
3394
3395         Action menu initialization should be moved to _commonInitializationWithFrameName
3396         https://bugs.webkit.org/show_bug.cgi?id=138572
3397         -and corresponding-
3398         rdar://problem/18929733
3399
3400         Reviewed by Tim Horton.
3401
3402         * WebView/WebView.mm:
3403         (-[WebView _commonInitializationWithFrameName:groupName:]):
3404         (-[WebView _initWithFrame:frameName:groupName:]):
3405
3406 2014-11-10  Beth Dakin  <bdakin@apple.com>
3407
3408         WK1: Support default actions for read-only text
3409         https://bugs.webkit.org/show_bug.cgi?id=138552
3410         -and corresponding-
3411         rdar://problem/18877483
3412
3413         Reviewed by Tim Horton.
3414
3415         New WKSystemInterface functions that WebCore needs to use.
3416         * WebCoreSupport/WebSystemInterface.mm:
3417         (InitWebCoreSystemInterface):
3418
3419         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
3420         makes a lot of things easier.
3421         * WebView/WebActionMenuController.h:
3422         * WebView/WebActionMenuController.mm:
3423
3424         Perform the hit test ourselves instead of calling into WebView so that we can more 
3425         easily save the WebCore::HitTestResult for ourselves.
3426         (-[WebActionMenuController performHitTestAtPoint:]):
3427
3428         Clear selection for non-text menus.
3429         (-[WebActionMenuController prepareForMenu:withEvent:]):
3430
3431         Re-set the _type here just to be safe.
3432         (-[WebActionMenuController didCloseMenu:withEvent:]):
3433
3434         Moving this method to be next to the link actions so they can be within a pragma 
3435         mark.
3436         (-[WebActionMenuController _defaultMenuItemsForLink:]):
3437
3438         New method for default text actions — lookup and copy.
3439         (-[WebActionMenuController _defaultMenuItemsForText:]):
3440         (-[WebActionMenuController _copySelection:]):
3441         (-[WebActionMenuController _lookupText:]):
3442
3443         If there is not already a selection, invoking the action menu on text should 
3444         select the lookup text.
3445         (-[WebActionMenuController _selectLookupText]):
3446         (performDictionaryLookupForSelection):
3447         (performDictionaryLookupForRange):
3448
3449         Handle text now.
3450         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3451         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3452
3453         New enum values.
3454         * WebView/WebUIDelegatePrivate.h:
3455
3456         Pass didCloseMenu on to the controller.
3457         * WebView/WebView.mm:
3458         (-[WebView didCloseMenu:withEvent:]):
3459
3460 2014-11-09  Chris Dumez  <cdumez@apple.com>
3461
3462         Add a more correct way to compare floating point numbers and use it
3463         https://bugs.webkit.org/show_bug.cgi?id=138527
3464
3465         Reviewed by Darin Adler.
3466
3467         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
3468         to compare floating-point numbers.
3469
3470         * WebView/WebHTMLView.mm:
3471         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
3472
3473 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
3474
3475         Delete cookies between tests
3476         https://bugs.webkit.org/show_bug.cgi?id=138528
3477
3478         Reviewed by Sam Weinig.
3479
3480         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
3481         * WebView/WebPreferencesPrivate.h:
3482         Added an SPI for DumpRenderTree.
3483
3484 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
3485
3486         [iOS] Update optimized fullscreen media controls
3487         https://bugs.webkit.org/show_bug.cgi?id=138493
3488
3489         Reviewed by Brent Fulgham.
3490
3491         * WebCoreSupport/WebSystemInterface.mm:
3492         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
3493
3494 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
3495
3496         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
3497         https://bugs.webkit.org/show_bug.cgi?id=138443
3498
3499         Reviewed by Anders Carlsson.
3500
3501         Wrapping the dealloc method in its own autorelease pool avoids the problem of
3502         complex tear-downs leading to the WebView itself being added to an autorelease
3503         pool that is not drained until after the instance has been dealloc'd.
3504  
3505         * WebView/WebView.mm:
3506         (-[WebView dealloc]):
3507
3508 2014-11-05  Jer Noble  <jer.noble@apple.com>
3509
3510         De-templatize Timer
3511         https://bugs.webkit.org/show_bug.cgi?id=138450
3512
3513         Reviewed by Anders Carlsson.
3514
3515         Remove template specifiers from Timer.
3516
3517         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3518         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3519         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
3520         * Plugins/WebNetscapePluginStream.h:
3521         * Plugins/WebNetscapePluginStream.mm:
3522         (WebNetscapePluginStream::deliverDataTimerFired):
3523
3524 2014-11-05  Dan Bernstein  <mitz@apple.com>
3525
3526         Remove the unused deletion UI feature
3527         https://bugs.webkit.org/show_bug.cgi?id=138442
3528
3529         Rubber-stamped by Alexey Proskuryakov.
3530
3531         * DefaultDelegates/WebDefaultEditingDelegate.m:
3532         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
3533         * WebCoreSupport/WebEditorClient.h:
3534         * WebCoreSupport/WebEditorClient.mm:
3535         (WebEditorClient::shouldShowDeleteInterface): Deleted.
3536         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
3537         -webView:shouldShowDeleteInterfaceForElement:.
3538
3539 2014-11-03  Dean Jackson  <dino@apple.com>
3540
3541         Add ENABLE_FILTERS_LEVEL_2 feature guard.
3542         https://bugs.webkit.org/show_bug.cgi?id=138362
3543
3544         Reviewed by Tim Horton.
3545
3546         Add a new feature define for Level 2 of CSS Filters.
3547         http://dev.w3.org/fxtf/filters-2/
3548
3549         * Configurations/FeatureDefines.xcconfig:
3550
3551 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
3552
3553         Add button and enable optimized fullscreen.
3554         https://bugs.webkit.org/show_bug.cgi?id=138351
3555
3556         Reviewed by Eric Carlson.
3557
3558         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
3559
3560         * WebCoreSupport/WebSystemInterface.mm:
3561         (InitWebCoreSystemInterface): added
3562
3563 2014-11-04  Chris Dumez  <cdumez@apple.com>
3564
3565         Add ptr() method to Ref class
3566         https://bugs.webkit.org/show_bug.cgi?id=138361
3567
3568         Reviewed by Darin Adler.
3569
3570         Use the new Ref::ptr() method.
3571
3572         * WebView/WebFrame.mm:
3573         (-[WebFrame _setTypingStyle:withUndoAction:]):
3574         * WebView/WebHTMLView.mm:
3575         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
3576         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
3577         * WebView/WebView.mm:
3578         (-[WebView applyStyle:]):
3579
3580 2014-11-04  Darin Adler  <darin@apple.com>
3581
3582         Eliminate ResourceBuffer and use SharedBuffer directly instead
3583         https://bugs.webkit.org/show_bug.cgi?id=138174