1 2015-04-27 Dan Bernstein <mitz@apple.com>
3 <rdar://problem/20721931> REGRESSION (r178753): All legacy framework headers are missing availability annotations
4 https://bugs.webkit.org/show_bug.cgi?id=144311
6 Reviewed by Adele Peterson.
8 * postprocess-headers.sh: Changed “macsox” to “macosx”.
10 2015-04-27 Brady Eidson <beidson@apple.com>
12 Make 'enum NavigationType' be an enum class
13 https://bugs.webkit.org/show_bug.cgi?id=144270
15 Reviewed by Alex Christensen.
17 * WebCoreSupport/WebFrameLoaderClient.mm:
18 (WebFrameLoaderClient::actionDictionary):
20 2015-04-27 Brent Fulgham <bfulgham@apple.com>
22 REGRESSION(r182879): Images and video can no longer be downloaded
23 https://bugs.webkit.org/show_bug.cgi?id=144267
24 <rdar://problem/20702844>
26 Reviewed by Simon Fraser.
28 * WebView/WebActionMenuController.mm:
29 (-[WebActionMenuController _createActionMenuItemForTag:]): Check for
30 "!WebCore::protocolIs(..., "file")" for image and media downloads.
32 2015-04-26 Yusuke Suzuki <utatane.tea@gmail.com>
34 [ES6] Implement ES6 template literals
35 https://bugs.webkit.org/show_bug.cgi?id=142691
37 Reviewed by Darin Adler.
39 Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
41 * Configurations/FeatureDefines.xcconfig:
43 2015-04-26 Doug Russell <d_russell@apple.com>
45 AX: richer text change notifications (142719)
46 https://bugs.webkit.org/show_bug.cgi?id=142719
48 Reviewed by Darin Adler.
50 Richer accessibility value change notifications. Introduce AXTextEditType,
51 postTextStateChangeNotification and postTextReplacementNotification to give assistive
52 tech apps more reliable context for responding to changes in web content. Also implement
53 a mechanism to post value changes in password form fields in coalesced ticks to thwart
54 analyzing the cadence of changes.
56 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
57 and an overload of postTextReplacementNotification to give assistive tech apps more
58 reliable context for responding to changes in web content selection. Also block posting
59 selection changes on password fields.
61 * WebCoreSupport/WebEditorClient.mm:
62 (undoNameForEditAction):
64 2015-04-24 Timothy Hatcher <timothy@apple.com>
66 Web Inspector: Remove native window dock controls
67 https://bugs.webkit.org/show_bug.cgi?id=144184
69 Reviewed by Joseph Pecoraro.
71 * Resources/Dock.pdf: Removed.
72 * Resources/DockLegacy.pdf: Removed.
73 * WebCoreSupport/WebInspectorClient.mm:
74 (-[WebInspectorWindowController window]):
75 (-[WebInspectorWindowController setDockingUnavailable:]):
77 2015-04-25 Martin Robinson <mrobinson@igalia.com>
79 Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
80 https://bugs.webkit.org/show_bug.cgi?id=144182
82 Reviewed by Simon Fraser.
84 * Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
86 2015-04-24 Commit Queue <commit-queue@webkit.org>
88 Unreviewed, rolling out r183266.
89 https://bugs.webkit.org/show_bug.cgi?id=144164
91 Broke 32-bit build and a test. (Requested by ap on #webkit).
95 "AX: richer text change notifications (142719)"
96 https://bugs.webkit.org/show_bug.cgi?id=142719
97 http://trac.webkit.org/changeset/183266
99 2015-04-24 Myles C. Maxfield <mmaxfield@apple.com>
101 [Cocoa] Start cleaning up FontPlatformData
102 https://bugs.webkit.org/show_bug.cgi?id=144133
104 Reviewed by Enrica Casucci.
106 Receive casts which have been hoisted from the deleted FontPlatformData constructor.
108 * Misc/WebKitNSStringExtras.mm:
109 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Receive cast which has
110 been hoisted from the deleted FontPlatformData constructor.
111 (-[NSString _web_widthWithFont:]): Ditto.
112 * Misc/WebStringTruncator.mm:
113 (fontFromNSFont): Ditto.
115 2015-04-24 Doug Russell <d_russell@apple.com>
117 AX: richer text change notifications (142719)
118 https://bugs.webkit.org/show_bug.cgi?id=142719
120 Reviewed by Darin Adler.
122 Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
124 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
126 * WebCoreSupport/WebEditorClient.mm:
127 (undoNameForEditAction):
129 2015-04-23 Jer Noble <jer.noble@apple.com>
131 [Mac] Disable QTKit by default on future OS X.
132 https://bugs.webkit.org/show_bug.cgi?id=144082
134 Reviewed by Darin Adler.
136 Default WebKitQTKitEnabledPreferenceKey to NO.
138 * WebView/WebPreferences.mm:
139 (+[WebPreferences initialize]):
141 2015-04-23 Andreas Kling <akling@apple.com>
143 There should only be one way to get the system memory size.
144 <https://webkit.org/b/144081>
146 Reviewed by Antti Koivisto.
148 * Misc/WebKitSystemBits.h:
149 * Misc/WebKitSystemBits.m:
150 (WebMemorySize): Deleted.
151 * WebView/WebView.mm:
152 (+[WebView _setCacheModel:]):
153 (roundUpToPowerOf2): Deleted.
155 2015-04-22 Darin Adler <darin@apple.com>
157 Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2
158 https://bugs.webkit.org/show_bug.cgi?id=143943
160 Reviewed by Anders Carlsson.
162 * Plugins/Hosted/ProxyInstance.h: Removed unneeded include.
163 * Plugins/WebBaseNetscapePluginView.h: Ditto.
165 * Plugins/WebNetscapePluginEventHandler.h: Use unique_ptr instead of
166 PassOwnPtr for the create function. Also tweaked formatting and removed
167 unneeded forward declaration of CGRect.
168 * Plugins/WebNetscapePluginEventHandler.mm:
169 (WebNetscapePluginEventHandler::create): Changed to use unique_ptr and
172 * Plugins/WebNetscapePluginView.h: Use unique_ptr instead of OwnPtr for
173 the _eventHandler field.
174 * Plugins/WebNetscapePluginView.mm:
175 (-[WebNetscapePluginView destroyPlugin]): Changed code to work with unique_ptr.
177 * WebCoreSupport/WebUserMediaClient.mm: Removed unneeded include.
179 * WebView/WebDeviceOrientationProviderMock.mm: Changed to use make_unique.
180 * WebView/WebDeviceOrientationProviderMockInternal.h: Changed to use unique_ptr.
182 * WebView/WebFrame.mm:
183 (vectorForDictationPhrasesArray): Changed to return Vector<Vector<String>> and
184 not a PassOwnPtr. Also rewrote to be much simpler, although there is still a
185 pre-existing problem here where this could put empty vectors into the result,
186 and I'm pretty sure the client never expects any of the Vector<String> to be empty.
187 (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
188 Rewrote logic to involve WebCore types a bit less; old code was round tripping
189 things through WebCore::URL for no obvious reason.
191 * WebView/WebFrameInternal.h: Changed vectorForDictationPhrasesArray to return
192 a Vector<Vector<String>> and not a PassOwnPtr.
194 * WebView/WebFullScreenController.h: Removed unneeded include.
196 * WebView/WebViewData.h: Changed m_alternativeTextUIController to be a
197 m_alternativeTextUIController.
198 * WebView/WebViewData.mm:
199 (-[WebViewPrivate init]): Use make_unique to initialize m_alternativeTextUIController.
201 2015-04-22 Brent Fulgham <bfulgham@apple.com>
203 VisibleSelection should only accept Range by reference
204 https://bugs.webkit.org/show_bug.cgi?id=144047
206 Reviewed by Tim Horton.
208 Update all uses of VisibleSelection to pass a Range reference instead
211 * WebCoreSupport/WebContextMenuClient.mm:
212 (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
213 * WebView/WebFrame.mm:
214 (-[WebFrame _selectNSRange:]):
216 2015-04-22 Eric Carlson <eric.carlson@apple.com>
218 [Mac] Device picker menu is positioned incorrectly in WK1
219 https://bugs.webkit.org/show_bug.cgi?id=144049
220 <rdar://problem/20493101>
222 Reviewed by Dean Jackson.
224 * WebView/WebView.mm:
225 (-[WebView _showPlaybackTargetPicker:location:hasVideo:]): Mouse location is already in
226 window coordinates so don't call convertRect:toView:nil.
228 2015-04-21 Brent Fulgham <bfulgham@apple.com>
230 Extend action menus to support PDF
231 https://bugs.webkit.org/show_bug.cgi?id=143895
232 <rdar://problem/19003333>
234 Reviewed by Tim Horton.
236 Prevent a crash when someone attempts to invoke an action menu on a PDF hosted
239 * WebView/WebActionMenuController.mm:
240 (-[WebActionMenuController performHitTestAtPoint:]): Handle WebPDFView as well as
241 the WebHTMLView case.
242 * WebView/WebDocument.h:
243 * WebView/WebHTMLView.h:
244 * WebView/WebHTMLView.mm:
245 (-[WebHTMLView _frame]):
246 * WebView/WebHTMLViewInternal.h:
247 * WebView/WebPDFView.h:
248 * WebView/WebPDFView.mm:
249 (-[WebPDFView _frame]): Added.
251 2015-04-22 Eric Carlson <eric.carlson@apple.com>
253 Unreviewed post-review clean up after r183096.
255 * WebView/WebMediaPlaybackTargetPicker.h:
257 2015-04-21 Eric Carlson <eric.carlson@apple.com>
259 [Mac] Use one playback target for all web processes
260 https://bugs.webkit.org/show_bug.cgi?id=144009
262 Reviewed by Tim Horton.
264 Update to use WebMediaSessionManager for playback target management.
266 * WebCoreSupport/WebChromeClient.h:
267 * WebCoreSupport/WebChromeClient.mm:
268 (WebChromeClient::addPlaybackTargetPickerClient):
269 (WebChromeClient::removePlaybackTargetPickerClient):
270 (WebChromeClient::showPlaybackTargetPicker):
271 (WebChromeClient::playbackTargetPickerClientStateDidChange):
272 (WebChromeClient::startingMonitoringPlaybackTargets): Deleted.
273 (WebChromeClient::stopMonitoringPlaybackTargets): Deleted.
274 * WebView/WebMediaPlaybackTargetPicker.h:
275 * WebView/WebMediaPlaybackTargetPicker.mm:
276 (WebMediaPlaybackTargetPicker::addPlaybackTargetPickerClient):
277 (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
278 (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
279 (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
280 (WebMediaPlaybackTargetPicker::setPlaybackTarget):
281 (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange):
282 (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget):
283 (WebMediaPlaybackTargetPicker::invalidate):
284 (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): Deleted.
285 (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): Deleted.
286 (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Deleted.
287 (WebMediaPlaybackTargetPicker::targetPicker): Deleted.
288 * WebView/WebView.mm:
289 (-[WebView _addPlaybackTargetPickerClient:]):
290 (-[WebView _removePlaybackTargetPickerClient:]):
291 (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
292 (-[WebView _playbackTargetPickerClientStateDidChange:state:]):
293 (-[WebView _showPlaybackTargetPicker:hasVideo:]): Deleted.
294 (-[WebView _startingMonitoringPlaybackTargets]): Deleted.
295 (-[WebView _stopMonitoringPlaybackTargets]): Deleted.
296 * WebView/WebViewInternal.h:
298 2015-04-20 Alexey Proskuryakov <ap@apple.com>
300 Disable mixed content blocking for existing WebKit1 clients
301 https://bugs.webkit.org/show_bug.cgi?id=143955
302 rdar://problem/20177186
304 Reviewed by Oliver Hunt.
306 * Misc/WebKitVersionChecks.h:
307 * WebView/WebView.mm:
308 (shouldAllowInsecureContent):
309 (-[WebView _preferencesChanged:]):
311 2015-04-20 Tim Horton <timothy_horton@apple.com>
313 Implement immediate action support for tel: and mailto: URLs
314 https://bugs.webkit.org/show_bug.cgi?id=143916
315 <rdar://problem/19721711>
317 Reviewed by Darin Adler.
319 * WebView/WebImmediateActionController.mm:
320 (-[WebImmediateActionController _defaultAnimationController]):
321 (-[WebImmediateActionController _animationControllerForDataDetectedText]):
322 (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
323 (-[WebImmediateActionController _menuItemForDataDetectedText]): Deleted.
324 * WebView/WebUIDelegatePrivate.h:
325 Add _animationControllerForDataDetectedLink and use it when
326 building immediate actions for tel: and mailto: links.
328 2015-04-17 Daniel Bates <dabates@apple.com>
330 REGRESSION: SVG does not support link dragging
331 https://bugs.webkit.org/show_bug.cgi?id=141597
333 Reviewed by Darin Adler.
335 Write -[WebElementDictionary _isLiveLink] in terms of WebCore::isDraggableLink().
337 * Misc/WebElementDictionary.mm:
338 (-[WebElementDictionary _isLiveLink]):
340 2015-04-16 Sam Weinig <sam@webkit.org>
342 Expose JavaScriptMarkupEnabled preference for WebKit1
343 <rdar://problem/19939450>
344 https://bugs.webkit.org/show_bug.cgi?id=143855
346 Reviewed by Dan Bernstein.
348 * WebView/WebPreferenceKeysPrivate.h:
349 Add new key, WebKitJavaScriptMarkupEnabledPreferenceKey
351 * WebView/WebPreferences.mm:
352 (+[WebPreferences initialize]):
353 Initialize WebKitJavaScriptMarkupEnabledPreferenceKey to YES.
355 (-[WebPreferences isJavaScriptMarkupEnabled]):
356 (-[WebPreferences setJavaScriptMarkupEnabled:]):
357 Implement getter/setter.
359 * WebView/WebPreferencesPrivate.h:
360 Add new property, javaScriptMarkupEnabled.
362 * WebView/WebView.mm:
363 (-[WebView _preferencesChanged:]):
364 Map the new preference to WebCore's scriptMarkupEnabled setting.
366 2015-04-15 Brent Fulgham <bfulgham@apple.com>
368 [Mac] Disable "Save to Downloads" option for local files
369 https://bugs.webkit.org/show_bug.cgi?id=143794
371 Reviewed by Tim Horton.
373 Disable the Image and Media download options if the download
374 target is a local file. We can only download web resources;
375 anything else is actually a no-op.
377 * WebView/WebActionMenuController.mm:
378 (-[WebActionMenuController _defaultMenuItemsForImage]):
379 (-[WebActionMenuController _defaultMenuItemsForVideo]):
381 2015-04-15 Alex Christensen <achristensen@webkit.org>
383 Progress towards CMake on Mac.
384 https://bugs.webkit.org/show_bug.cgi?id=143785
386 Reviewed by Csaba Osztrogonác.
388 * WebView/WebPDFDocumentExtras.mm:
389 * WebView/WebPDFView.mm:
391 2015-04-13 Jer Noble <jer.noble@apple.com>
393 [Fullscreen] ChromeClient::exitVideoFullscreen() should take a pointer to a HTMLVideoElement.
394 https://bugs.webkit.org/show_bug.cgi?id=143674
396 Reviewed by Darin Adler.
398 * WebCoreSupport/WebChromeClient.h:
399 * WebCoreSupport/WebChromeClient.mm:
400 (WebChromeClient::enterVideoFullscreenForVideoElement): Takes a reference.
401 (WebChromeClient::exitVideoFullscreenForVideoElement): Renamed from exitVideoFullscreen().
402 (WebChromeClient::exitVideoFullscreen): Deleted.
404 2015-04-14 Simon Fraser <simon.fraser@apple.com>
406 Re-enable custom dilation for antialiased fonts
407 https://bugs.webkit.org/show_bug.cgi?id=143738
409 Reviewed by Tim Horton.
411 Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
412 but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
413 a private WebKit pref. This pref defaults to YES, enabling the feature by default
414 in WK1 as we do for WK2.
416 * WebView/WebPreferenceKeysPrivate.h:
417 * WebView/WebPreferences.mm:
418 (+[WebPreferences initialize]):
419 (-[WebPreferences setAntialiasedFontDilationEnabled:]):
420 (-[WebPreferences antialiasedFontDilationEnabled]):
421 * WebView/WebPreferencesPrivate.h:
422 * WebView/WebView.mm:
423 (-[WebView _preferencesChanged:]):
425 2015-04-13 Brady Eidson <beidson@apple.com>
427 Share sheets from Share menus appear outside the browser window.
428 <rdar://problem/20455592> and https://bugs.webkit.org/show_bug.cgi?id=143620
430 Reviewed by Darin Adler.
432 Refactor existing Sharing Service Picker code to also be used for the Share menu NSMenuItem.
434 * Misc/WebSharingServicePickerController.h:
435 (WebSharingServicePickerClient::webView):
436 * Misc/WebSharingServicePickerController.mm:
437 (WebSharingServicePickerClient::WebSharingServicePickerClient):
438 (WebSharingServicePickerClient::sharingServicePickerWillBeDestroyed):
439 (WebSharingServicePickerClient::pageForSharingServicePicker):
440 (WebSharingServicePickerClient::windowForSharingServicePicker):
441 (WebSharingServicePickerClient::screenRectForCurrentSharingServicePickerItem):
442 (WebSharingServicePickerClient::imageForCurrentSharingServicePickerItem):
443 (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]):
444 (-[WebSharingServicePickerController initWithSharingServicePicker:client:]):
445 (-[WebSharingServicePickerController sharingService:didShareItems:]):
447 * WebCoreSupport/WebContextMenuClient.h:
448 (WebContextMenuClient::webView): Deleted.
449 * WebCoreSupport/WebContextMenuClient.mm:
450 (WebContextMenuClient::WebContextMenuClient):
451 (WebContextMenuClient::pageForSharingServicePicker): Deleted.
452 (WebContextMenuClient::windowForSharingServicePicker): Deleted.
454 * WebCoreSupport/WebSelectionServiceController.h:
455 * WebCoreSupport/WebSelectionServiceController.mm:
456 (WebSelectionServiceController::WebSelectionServiceController):
457 (WebSelectionServiceController::handleSelectionServiceClick):
458 (WebSelectionServiceController::pageForSharingServicePicker): Deleted.
459 (WebSelectionServiceController::windowForSharingServicePicker): Deleted.
460 (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem): Deleted.
461 (WebSelectionServiceController::imageForCurrentSharingServicePickerItem): Deleted.
463 * WebView/WebHTMLView.mm:
464 (-[WebHTMLView menuForEvent:]):
465 * WebView/WebViewData.h:
467 2015-04-13 Beth Dakin <bdakin@apple.com>
469 Add force property to MouseEvents
470 https://bugs.webkit.org/show_bug.cgi?id=143569
472 rdar://problem/20472954
474 Reviewed by Darin Adler.
476 PlatformMouseEvent and MouseEvent now take force parameters.
477 * WebView/WebFrame.mm:
478 (-[WebFrame _dragSourceEndedAt:operation:]):
479 * WebView/WebPDFView.mm:
480 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
482 2015-04-12 Darin Adler <darin@apple.com>
484 [Cocoa] Localizable strings are inconsistent and need to be regenerated
485 https://bugs.webkit.org/show_bug.cgi?id=143661
486 rdar://problem/19634388
488 Reviewed by Dan Bernstein.
490 * Misc/WebLocalizableStrings.mm:
491 (LoadWebLocalizedStringsTimerCallback): Moved the comment, useful for programmers but
492 not for localization, into a C++ source code comment, and made the localizer comment
493 consistent with the place this localizable string is used for actual localization.
494 * WebCoreSupport/WebEditorClient.mm:
495 (undoNameForEditAction): Changed the localizer comments for Delete and Dictation
496 to match the ones in WebKit2; no need to specify that these are iOS only, and if we do
497 want to specify that, we should not be using the term PLATFORM(IOS) since there is no
498 reason for us to expect localizers to understand that terminology. Also added a comment
499 about the fact that we have two copies of all the localizable strings.
501 2015-04-11 Yusuke Suzuki <utatane.tea@gmail.com>
503 [ES6] Enable Symbol in web pages
504 https://bugs.webkit.org/show_bug.cgi?id=143375
506 Reviewed by Ryosuke Niwa.
508 * WebView/WebPreferencesPrivate.h:
510 2015-04-08 Sam Weinig <sam@webkit.org>
512 Allow LaunchServices to handle URLs on link navigations
513 <rdar://problem/19446826>
514 https://bugs.webkit.org/show_bug.cgi?id=143544
516 Reviewed by Anders Carlsson.
518 * Configurations/WebKitLegacy.xcconfig:
519 Link MobileCoreServices.
521 * WebCoreSupport/WebFrameLoaderClient.h:
522 * WebCoreSupport/WebFrameLoaderClient.mm:
524 (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
525 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
526 (WebFrameLoaderClient::setUpPolicyListener):
527 Only let LaunchServices have a crack at the URL if the navigation is:
528 1) a main frame navigation
529 2) a result of a user gesture
531 2015-04-10 Alexey Proskuryakov <ap@apple.com>
535 * Misc/WebNSURLExtras.mm: (-[NSString _webkit_unescapedQueryValue]): Ignore a deprecation.
537 2015-04-10 Eric Carlson <eric.carlson@apple.com>
539 [Mac] Refactor MediaPlaybackTarget
540 https://bugs.webkit.org/show_bug.cgi?id=143571
542 Reviewed by Jer Noble.
544 * WebView/WebMediaPlaybackTargetPicker.h:
545 * WebView/WebMediaPlaybackTargetPicker.mm:
546 (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Take a Ref<MediaPlaybackTarget>&&.
548 2015-04-09 Andy Estes <aestes@apple.com>
550 [Cocoa] Add a HAVE(AVKIT) and use it
551 https://bugs.webkit.org/show_bug.cgi?id=143593
553 Reviewed by David Kilzer.
555 * WebView/WebPreferences.mm:
556 (+[WebPreferences initialize]): Only set WebKitAVKitEnabled to YES if HAVE(AVKIT).
557 (-[WebPreferences setAVKitEnabled:]): Only set value for WebKitAVKitEnabled if HAVE(AVKIT).
558 * WebView/WebView.mm:
559 (-[WebView _preferencesChanged:]): Only called Settings::setAVKitEnabled() if HAVE(AVKIT).
561 2015-04-09 Chris Dumez <cdumez@apple.com>
563 [WK2][iOS] editorState() should not cause a synchronous layout
564 https://bugs.webkit.org/show_bug.cgi?id=142536
565 <rdar://problem/20041506>
567 Reviewed by Enrica Casucci.
569 Provide implementation for EditorClient::didChangeSelectionAndUpdateLayout().
571 * WebCoreSupport/WebEditorClient.h:
573 2015-04-08 Brent Fulgham <bfulgham@apple.com>
575 [Mac] WebKit is not honoring OS preferences for secondary click behaviors
576 https://bugs.webkit.org/show_bug.cgi?id=143452
577 <rdar://problem/20437483>
579 Reviewed by Tim Horton.
581 We were improperly intercepting contextual menu clicks and passing them through
582 the mouseDown handler, rather than processing via NSView's menu handling code.
584 * WebView/WebHTMLView.mm:
585 (-[WebHTMLView otherMouseDown:]): Treat context menu events the same as the action
586 menu case, and pass it to AppKit for normal menu processing.
588 2015-04-08 Brady Eidson <beidson@apple.com>
590 Expose the "Share" menu for links, images, and media.
591 <rdar://problem/20435340> and https://bugs.webkit.org/show_bug.cgi?id=143502
593 Reviewed by Tim Horton.
595 * WebCoreSupport/WebContextMenuClient.h:
596 * WebCoreSupport/WebContextMenuClient.mm:
597 (WebContextMenuClient::shareMenuItem):
599 2015-04-08 Anders Carlsson <andersca@apple.com>
601 Move some ApplicationCache static member functions to ApplicationCacheStorage
602 https://bugs.webkit.org/show_bug.cgi?id=143524
604 Reviewed by Antti Koivisto.
606 * WebCoreSupport/WebApplicationCache.mm:
607 (+[WebApplicationCache diskUsageForOrigin:]):
608 (+[WebApplicationCache deleteAllApplicationCaches]):
609 (+[WebApplicationCache deleteCacheForOrigin:]):
611 2015-04-08 Chris Dumez <cdumez@apple.com>
613 Rename ActiveDOMObject::canSuspend() to canSuspendForPageCache() for clarity
614 https://bugs.webkit.org/show_bug.cgi?id=143513
616 Reviewed by Andreas Kling.
618 Update ScriptExecutionContext::canSuspendActiveDOMObjects() to
619 canSuspendActiveDOMObjectsForPageCache() as the method was renamed.
621 * WebView/WebFrame.mm:
622 (-[WebFrame _cacheabilityDictionary]):
624 2015-04-07 Anders Carlsson <andersca@apple.com>
626 Get rid of uses of ApplicationCacheStorage::singleton() from WebKitLegacy
627 https://bugs.webkit.org/show_bug.cgi?id=143504
629 Reviewed by Sam Weinig.
631 Add a webApplicationCacheStorage() function and use it throughout WebKitLegacy.
632 In the future, webApplicationCacheStorage will return a custom singleton, but for now
633 it just returns ApplicationCacheStorage::singleton().
637 * WebCoreSupport/WebApplicationCache.mm:
638 (+[WebApplicationCache maximumSize]):
639 (+[WebApplicationCache setMaximumSize:]):
640 (+[WebApplicationCache defaultOriginQuota]):
641 (+[WebApplicationCache setDefaultOriginQuota:]):
642 (+[WebApplicationCache originsWithCache]):
643 (webApplicationCacheStorage):
644 * WebCoreSupport/WebApplicationCacheInternal.h: Added.
645 * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
646 (-[WebApplicationCacheQuotaManager usage]):
647 (-[WebApplicationCacheQuotaManager quota]):
648 (-[WebApplicationCacheQuotaManager setQuota:]):
649 * WebView/WebView.mm:
650 (WebKitInitializeApplicationCachePathIfNecessary):
652 2015-04-07 Brady Eidson <beidson@apple.com>
654 ContextMenuItem refactoring
655 https://bugs.webkit.org/show_bug.cgi?id=143485
657 Reviewed by Beth Dakin.
659 * WebCoreSupport/WebContextMenuClient.mm:
660 (WebContextMenuClient::contextMenuItemSelected):
662 2015-04-06 Chris Dumez <cdumez@apple.com>
664 Bing video search result pages are not PageCacheable
665 https://bugs.webkit.org/show_bug.cgi?id=143463
666 <rdar://problem/20440916>
668 Reviewed by Alexey Proskuryakov.
670 Fix the iOS / WK1 build by using MemoryCache::resourceForRequest()
671 instead of resourceForUrl().
674 (+[WebCache imageForURL:]):
676 2015-04-05 Simon Fraser <simon.fraser@apple.com>
678 Remove "go ahead and" from comments
679 https://bugs.webkit.org/show_bug.cgi?id=143421
681 Reviewed by Darin Adler, Benjamin Poulain.
683 Remove the phrase "go ahead and" from comments where it doesn't add
684 anything (which is almost all of them).
686 * WebView/WebDynamicScrollBarsView.mm:
687 (-[WebDynamicScrollBarsView updateScrollers]):
688 * WebView/WebHTMLView.mm:
689 (-[WebHTMLView insertText:]):
691 2015-04-02 Brady Eidson <beidson@apple.com>
693 Unreviewed: Reland change after rollout.
695 Expose the "Share" menu for text selections on platforms where it's available.
696 rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
698 * WebView/WebImmediateActionController.mm: Update for required #include
700 2015-04-02 Commit Queue <commit-queue@webkit.org>
702 Unreviewed, rolling out r182293.
703 https://bugs.webkit.org/show_bug.cgi?id=143355
705 Broke GTK and EFL builds. (Requested by bfulgham on #webkit).
709 "Expose the "Share" menu for text selections on platforms
710 where it's available."
711 https://bugs.webkit.org/show_bug.cgi?id=143318
712 http://trac.webkit.org/changeset/182293
714 2015-04-02 Brady Eidson <beidson@apple.com>
716 Expose the "Share" menu for text selections on platforms where it's available.
717 rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
719 Reviewed by Sam Weinig.
721 * WebView/WebImmediateActionController.mm: Update for required #include
723 2015-04-02 Yusuke Suzuki <utatane.tea@gmail.com>
725 Clean up EnumerationMode to easily extend
726 https://bugs.webkit.org/show_bug.cgi?id=143276
728 Reviewed by Geoffrey Garen.
730 Use default EnumerationMode().
732 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
733 (WebKit::NetscapePluginInstanceProxy::enumerate):
735 2015-03-31 Simon Fraser <simon.fraser@apple.com>
737 Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
738 https://bugs.webkit.org/show_bug.cgi?id=143288
740 Reviewed by Beth Dakin.
742 Remove the wheel event counting that Document does, and passes into the scrolling tree.
743 The ScrollingTree now just uses the non-fast scrollable region to determine when to
744 fast scroll on pages with wheel event handlers.
746 * WebCoreSupport/WebChromeClient.h:
748 2015-03-31 Timothy Horton <timothy_horton@apple.com>
750 TextIndicator for <span> inside an <a> only highlights the <span>, should highlight the whole <a>
751 https://bugs.webkit.org/show_bug.cgi?id=143287
752 <rdar://problem/20318342>
754 Reviewed by Beth Dakin.
756 * WebView/WebImmediateActionController.mm:
757 (-[WebImmediateActionController _defaultAnimationController]):
758 Instead of just highlighting the hit element, highlight the whole
759 element that the link URL comes from.
761 2015-03-31 Yusuke Suzuki <utatane.tea@gmail.com>
763 Clean up Identifier factories to clarify the meaning of StringImpl*
764 https://bugs.webkit.org/show_bug.cgi?id=143146
766 Reviewed by Filip Pizlo.
768 Just change to Identifier::fromString.
770 * Plugins/Hosted/NetscapePluginHostProxy.mm:
771 (identifierFromIdentifierRep):
772 * Plugins/Hosted/ProxyInstance.mm:
773 (WebKit::ProxyInstance::getPropertyNames):
775 2015-03-28 Anders Carlsson <andersca@apple.com>
777 Remove an unused SPI method from WebKitLegacy
778 https://bugs.webkit.org/show_bug.cgi?id=143185
780 Reviewed by Sam Weinig.
782 * WebView/WebDataSource.mm:
783 (-[WebDataSource _transferApplicationCache:]): Deleted.
784 * WebView/WebDataSourcePrivate.h:
786 2015-03-26 Alex Christensen <achristensen@webkit.org>
788 Progress towards CMake on Mac.
789 https://bugs.webkit.org/show_bug.cgi?id=143112
791 Reviewed by Chris Dumez.
793 * WebCoreSupport/WebFrameLoaderClient.h:
795 2015-03-26 Ryosuke Niwa <rniwa@webkit.org>
797 Cursor doesn't change back to pointer when leaving Mail
798 https://bugs.webkit.org/show_bug.cgi?id=132038
800 Reviewed by Anders Carlsson.
802 Fixed the bug by adding a cursor rect and making the primary tracking area update the cursor so that
803 AppKit will reset the cursor as it leaves the WebView.
805 We use nil cursor here since we manually update the cursor by calling [NSCursor set].
807 * WebView/WebHTMLView.mm:
808 (-[WebHTMLView setDataSource:]): Use NSTrackingCursorUpdate option in creating the primary tracking area.
810 2015-03-24 Anders Carlsson <andersca@apple.com>
812 Fix designated initializer violations
813 https://bugs.webkit.org/show_bug.cgi?id=143016
814 rdar://problem/20268858
816 Reviewed by Dan Bernstein.
818 Move -[WebBackForwardList initWithBackForwardList:] to the implementation instead of a category since
819 nobody calls it outside of WebBackForwardList.mm.
821 * History/WebBackForwardList.mm:
822 * History/WebBackForwardListInternal.h:
824 2015-03-23 Alexey Proskuryakov <ap@apple.com>
826 REGRESSION (Yosemite): WKView visibility notifications are messed up
827 https://bugs.webkit.org/show_bug.cgi?id=142945
829 Reviewed by Tim Horton.
831 As these notifications cannot be used by NSView subclasses, create a separate
832 object for observing them.
834 * WebView/WebView.mm:
835 (-[WebView _commonInitializationWithFrameName:groupName:]):
836 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
837 (-[WebView addWindowObserversForWindow:]):
838 (-[WebView removeWindowObservers]):
839 (-[WebView viewWillMoveToWindow:]): Make sure that observers are removed even
840 if -[WebView close] is called manually.
841 * WebView/WebViewData.h:
842 * WebView/WebViewData.mm:
843 (-[WebWindowVisibilityObserver initWithView:]):
844 (-[WebWindowVisibilityObserver startObserving:]):
845 (-[WebWindowVisibilityObserver stopObserving:]):
846 (-[WebWindowVisibilityObserver _windowVisibilityChanged:]):
848 2015-03-23 Tim Horton <timothy_horton@apple.com>
850 Add a share item to the link action menu
851 https://bugs.webkit.org/show_bug.cgi?id=142961
852 <rdar://problem/19198374>
854 Reviewed by Beth Dakin.
856 * WebView/WebActionMenuController.mm:
857 (-[WebActionMenuController _defaultMenuItemsForImage]):
858 (-[WebActionMenuController _defaultMenuItemsForVideo]):
859 (-[WebActionMenuController _createActionMenuItemForTag:]):
860 (-[WebActionMenuController _createShareActionMenuItemForTag:withItems:]):
861 Adopt -[NSMenuItem standardShareMenuItemWithItems].
862 All of the null-checking is unnecessary as it's impossible to enter
863 these functions with a null image/etc.
864 Also, remove a duplicate isDownloadableMedia check for the 'save to downloads' item.
866 (-[WebActionMenuController _defaultMenuItemsForLink]):
867 * WebView/WebUIDelegatePrivate.h:
868 Add a 'Share' item to the link menu.
870 2015-03-22 Alexey Proskuryakov <ap@apple.com>
874 * WebView/WebView.mm: (-[WebView _showPlaybackTargetPicker:hasVideo:]):
876 2015-03-22 Eric Carlson <eric.carlson@apple.com>
878 [Mac] Enable WIRELESS_PLAYBACK_TARGET for WK1
879 https://bugs.webkit.org/show_bug.cgi?id=142940
881 Reviewed by Sam Weinig.
883 * WebCoreSupport/WebChromeClient.h:
884 * WebCoreSupport/WebChromeClient.mm:
885 (WebChromeClient::showPlaybackTargetPicker): New.
886 (WebChromeClient::startingMonitoringPlaybackTargets): New.
887 (WebChromeClient::stopMonitoringPlaybackTargets): New.
889 * WebView/WebView.mm:
890 (-[WebView _close]): Invalidate and free the target picker.
891 (-[WebView _devicePicker]): New.
892 (-[WebView _showPlaybackTargetPicker:hasVideo:]): New.
893 (-[WebView _startingMonitoringPlaybackTargets]): New.
894 (-[WebView _stopMonitoringPlaybackTargets]): New.
896 * WebView/WebMediaPlaybackTargetPicker.h:
897 * WebView/WebMediaPlaybackTargetPicker.mm:
898 (WebMediaPlaybackTargetPicker::create): New.
899 (WebMediaPlaybackTargetPicker::WebMediaPlaybackTargetPicker): New.
900 (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): New.
901 (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): New.
902 (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): New.
903 (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): New.
904 (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange): New.
905 (WebMediaPlaybackTargetPicker::invalidate): New.
906 (WebMediaPlaybackTargetPicker::targetPicker): New.
908 * WebView/WebViewData.h:
909 (WebMediaPlaybackTargetPicker::~WebMediaPlaybackTargetPicker):
910 * WebView/WebViewData.mm:
911 * WebView/WebViewInternal.h:
913 2015-03-19 Andy Estes <aestes@apple.com>
915 [Content Filtering] Add tests for unblock requests
916 https://bugs.webkit.org/show_bug.cgi?id=142900
918 Reviewed by Andreas Kling.
920 * WebCoreSupport/WebFrameLoaderClient.mm:
921 (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): This now happens in PolicyChecker.
922 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
923 * WebView/WebFrame.mm:
924 (-[WebFrame _contentFilterDidHandleNavigationAction:]): Deleted.
925 * WebView/WebFrameInternal.h: Removed contentFilterUnblockHandler from WebFramePrivate.
927 2015-03-19 Enrica Casucci <enrica@apple.com>
929 <attachment> should put URLs on the pasteboard so that Finder can accept drops.
930 https://bugs.webkit.org/show_bug.cgi?id=142801
931 rdar://problem/19982527
933 Reviewed by Tim Horton.
935 This patch adds all the necessary support to write attachment elements into
936 the pasteboard, including the promised type in WK1.
938 * Misc/WebNSPasteboardExtras.mm:
939 (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
940 * WebCoreSupport/WebDragClient.h:
941 * WebCoreSupport/WebDragClient.mm:
942 (WebDragClient::declareAndWriteAttachment):
943 * WebView/WebHTMLView.mm:
944 (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
945 * WebView/WebUIDelegate.h:
947 2015-03-19 Chris Dumez <cdumez@apple.com>
949 Clean up DOMTimer related settings
950 https://bugs.webkit.org/show_bug.cgi?id=142837
952 Reviewed by Darin Adler.
954 Stop setting the DOMTimers' default minimum interval to 4ms as this
957 * WebView/WebView.mm:
958 (-[WebView _commonInitializationWithFrameName:groupName:]):
960 2015-03-17 Conrad Shultz <conrad_shultz@apple.com>
962 Ignore some deprecation warnings
963 https://bugs.webkit.org/show_bug.cgi?id=142813
965 Reviewed by Mark Rowe.
967 Fixing the deprecations is tracked by: <rdar://problem/20201450>
969 * WebCoreSupport/PopupMenuMac.mm:
970 (PopupMenuMac::populate):
972 2015-03-17 Tim Horton <timothy_horton@apple.com>
974 Cannot invoke action menus anymore
975 https://bugs.webkit.org/show_bug.cgi?id=142797
976 <rdar://problem/20032670>
978 * WebView/WebHTMLView.mm:
979 (-[WebHTMLView otherMouseDown:]):
980 Need a respondsToSelector check.
982 2015-03-17 Tim Horton <timothy_horton@apple.com>
986 * WebView/WebHTMLView.mm:
988 2015-03-17 Tim Horton <timothy_horton@apple.com>
990 Cannot invoke action menus anymore
991 https://bugs.webkit.org/show_bug.cgi?id=142797
992 <rdar://problem/20032670>
994 Reviewed by Beth Dakin.
996 * WebView/WebHTMLView.mm:
997 (-[WebHTMLView otherMouseDown:]):
998 Don't override otherMouseDown: if the event would make an action menu.
1000 2015-03-16 Ryosuke Niwa <rniwa@webkit.org>
1002 Enable ES6 classes by default
1003 https://bugs.webkit.org/show_bug.cgi?id=142774
1005 Reviewed by Gavin Barraclough.
1007 * Configurations/FeatureDefines.xcconfig:
1009 2015-03-16 Brent Fulgham <bfulgham@apple.com>
1011 WebKit1 Clients Are Not Reliably Repainted
1012 https://bugs.webkit.org/show_bug.cgi?id=142750
1013 <rdar://problem/20042453>
1015 Reviewed by Simon Fraser.
1017 Check with the FrameView to see if we are in an immediately paintable state. If we are not,
1018 mark the view as dirty once the _immediateScrollToPoint operation is complete so that the
1019 region will be painted properly.
1021 * WebView/WebClipView.mm:
1022 (-[WebClipView _immediateScrollToPoint:]):
1024 2015-03-16 Conrad Shultz <conrad_shultz@apple.com>
1026 Allow clients to selectively disable plug-ins
1027 https://bugs.webkit.org/show_bug.cgi?id=142506
1029 Reviewed by Anders Carlsson.
1031 Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
1032 from the page). As part of this:
1034 1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
1037 2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
1040 3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
1041 a concrete implementation thereof in WebPlatformStrategies in WebKit2.
1043 4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
1045 While currently only used in a very limited manner, the new declarative plug-in policies are written generically
1046 so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
1048 * Plugins/WebBasePluginPackage.mm:
1049 (-[WebBasePluginPackage getPluginInfoFromPLists]):
1050 Set new members in PluginInfo.
1052 * Plugins/WebNetscapePluginPackage.mm:
1053 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
1054 Set new members in PluginInfo.
1056 * WebCoreSupport/WebPlatformStrategies.h:
1057 * WebCoreSupport/WebPlatformStrategies.mm:
1058 (WebPlatformStrategies::getWebVisiblePluginInfo):
1059 Override to wrap getPluginInfo().
1060 (WebPlatformStrategies::setPluginLoadClientPolicy):
1061 Override to do nothing.
1062 (WebPlatformStrategies::clearPluginClientPolicies):
1065 * WebView/WebFrame.mm:
1066 (-[WebFrame _canProvideDocumentSource]):
1067 Update to reflect function rename.
1069 2015-03-14 Dean Jackson <dino@apple.com>
1071 Feature flag for Animations Level 2
1072 https://bugs.webkit.org/show_bug.cgi?id=142699
1073 <rdar://problem/20165097>
1075 Reviewed by Brent Fulgham.
1077 Add ENABLE_CSS_ANIMATIONS_LEVEL_2 and a runtime flag animationTriggersEnabled.
1079 * Configurations/FeatureDefines.xcconfig:
1081 2015-03-13 Commit Queue <commit-queue@webkit.org>
1083 Unreviewed, rolling out r181483.
1084 https://bugs.webkit.org/show_bug.cgi?id=142688
1086 Caused use-after-free on many tests (Requested by ap on
1091 "Allow clients to selectively disable plug-ins"
1092 https://bugs.webkit.org/show_bug.cgi?id=142506
1093 http://trac.webkit.org/changeset/181483
1095 2015-03-13 Eric Carlson <eric.carlson@apple.com>
1097 [Mac] Enable WIRELESS_PLAYBACK_TARGET
1098 https://bugs.webkit.org/show_bug.cgi?id=142635
1100 Reviewed by Darin Adler.
1102 * Configurations/FeatureDefines.xcconfig:
1104 2015-03-10 Conrad Shultz <conrad_shultz@apple.com>
1106 Allow clients to selectively disable plug-ins
1107 https://bugs.webkit.org/show_bug.cgi?id=142506
1109 Reviewed by Anders Carlsson.
1111 Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
1112 from the page). As part of this:
1114 1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
1117 2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
1120 3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
1121 a concrete implementation thereof in WebPlatformStrategies in WebKit2.
1123 4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
1125 While currently only used in a very limited manner, the new declarative plug-in policies are written generically
1126 so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
1128 * Plugins/WebBasePluginPackage.mm:
1129 (-[WebBasePluginPackage getPluginInfoFromPLists]):
1130 Set new members in PluginInfo.
1132 * Plugins/WebNetscapePluginPackage.mm:
1133 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
1134 Set new members in PluginInfo.
1136 * WebCoreSupport/WebPlatformStrategies.h:
1137 * WebCoreSupport/WebPlatformStrategies.mm:
1138 (WebPlatformStrategies::getWebVisiblePluginInfo):
1139 Override to wrap getPluginInfo().
1140 (WebPlatformStrategies::setPluginLoadClientPolicy):
1141 Override to do nothing.
1142 (WebPlatformStrategies::clearPluginClientPolicies):
1145 * WebView/WebFrame.mm:
1146 (-[WebFrame _canProvideDocumentSource]):
1147 Update to reflect function rename.
1149 2015-03-10 Sam Weinig <sam@webkit.org>
1151 Allow adding a button in input elements for auto fill related functionality
1152 <rdar://problem/19782066>
1153 https://bugs.webkit.org/show_bug.cgi?id=142564
1155 Reviewed by Anders Carlsson.
1157 * DOM/WebDOMOperations.mm:
1158 (-[DOMHTMLInputElement _setAutofilled:]):
1159 Update for consistent spelling of AutoFill.
1161 2015-03-10 Timothy Horton <timothy_horton@apple.com>
1165 * History/WebHistory.mm:
1166 (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1167 * WebCoreSupport/WebFrameLoaderClient.mm:
1168 (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1170 2015-03-10 Tim Horton <timothy_horton@apple.com>
1172 Fix the Mac build with a newer compiler
1174 * Plugins/WebPluginController.mm:
1175 (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1176 (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1178 2015-03-09 David Kilzer <ddkilzer@apple.com>
1180 [iOS] Fix build when compiling with dead code stripping disabled
1181 <http://webkit.org/b/142467>
1183 Reviewed by Simon Fraser.
1185 * Configurations/WebKitLegacy.xcconfig:
1186 (EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code
1187 generation and compilation for out-of-process plugin support.
1188 This was never used on iOS.
1190 2015-03-06 Myles C. Maxfield <mmaxfield@apple.com>
1192 [iOS] SVG fonts are garbled
1193 https://bugs.webkit.org/show_bug.cgi?id=142377
1195 Reviewed by Simon Fraser.
1197 * Configurations/FeatureDefines.xcconfig:
1199 2015-03-04 Yusuke Suzuki <utatane.tea@gmail.com>
1201 Hide Promise with runtime flags under Cocoa JSContext API
1202 https://bugs.webkit.org/show_bug.cgi?id=141965
1204 Reviewed by Filip Pizlo.
1206 Add new JSC runtime flag, PromiseDisabled.
1208 * WebView/WebPreferencesPrivate.h:
1210 2015-03-03 Andy Estes <aestes@apple.com>
1212 [Content Filtering] Separate unblock handling into its own class
1213 https://bugs.webkit.org/show_bug.cgi?id=142251
1215 Reviewed by Andreas Kling.
1217 Adopted ContentFilterUnblockHandler.
1219 * WebCoreSupport/WebFrameLoaderClient.h:
1220 * WebCoreSupport/WebFrameLoaderClient.mm:
1221 (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1222 * WebView/WebFrame.mm:
1223 (-[WebFrame _contentFilterDidHandleNavigationAction:]):
1224 * WebView/WebFrameInternal.h:
1226 2015-03-03 Chris Dumez <cdumez@apple.com>
1228 Access ApplicationCacheStorage global instance via singleton() static member function
1229 https://bugs.webkit.org/show_bug.cgi?id=142239
1231 Reviewed by Anders Carlsson.
1233 Access ApplicationCacheStorage global instance via singleton() static
1234 member function as per WebKit coding style.
1236 2015-03-02 Jer Noble <jer.noble@apple.com>
1238 [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1239 https://bugs.webkit.org/show_bug.cgi?id=142121
1241 Reviewed by Simon Fraser.
1243 Fullscreening a page with a non-1 scale would result in that scale being applied to the
1244 fullscreen content, breaking fullscreen mode. Set the page scale to 1 when entering
1245 fullscreen and reset it to the original value when exiting fullscreen.
1247 * WebView/WebFullScreenController.h:
1248 * WebView/WebFullScreenController.mm:
1249 (-[WebFullScreenController enterFullScreen:]): Set the page scale to 1.
1250 (-[WebFullScreenController finishedExitFullScreenAnimation:]): Reset the page
1251 scale to the original value.
1252 * WebView/WebView.mm:
1253 (-[WebView _supportsFullScreenForElement:withKeyboard:]): Drive-by fix. Check the
1254 WebView's own preferences to see if fullscreen mode is enabled, rather than
1255 the global object's.
1257 2015-03-01 Chris Dumez <cdumez@apple.com>
1259 Make NotificationCenter / Notification suspendable
1260 https://bugs.webkit.org/show_bug.cgi?id=142117
1261 <rdar://problem/19923085>
1263 Reviewed by Andreas Kling.
1265 Provide implementation for NotificationClient::hasPendingPermissionRequests().
1266 The implementation is very simplistic. it will only return false if no
1267 request for permission for ever made. This is because there is currently no
1268 easy way to figure out if a permission request is pending or not.
1270 * WebCoreSupport/WebNotificationClient.h:
1271 * WebCoreSupport/WebNotificationClient.mm:
1272 (WebNotificationClient::requestPermission):
1273 (WebNotificationClient::hasPendingPermissionRequests):
1275 2015-02-28 Simon Fraser <simon.fraser@apple.com>
1277 Viewport units should not dirty style just before we do layout
1278 https://bugs.webkit.org/show_bug.cgi?id=141682
1280 Reviewed by Zalan Bujtas.
1282 * WebView/WebFrameView.mm:
1283 (-[WebFrameView _frameSizeChanged]):
1285 2015-02-26 Chris Dumez <cdumez@apple.com>
1287 Rename DatabaseManager::manager() to DatabaseManager::singleton()
1288 https://bugs.webkit.org/show_bug.cgi?id=142054
1290 Reviewed by Ryosuke Niwa.
1292 Rename DatabaseManager::manager() to DatabaseManager::singleton() as
1293 per coding style and use WTF::NeverDestroyed.
1295 * Storage/WebDatabaseManager.mm:
1296 (-[WebDatabaseManager init]):
1297 (-[WebDatabaseManager origins]):
1298 (-[WebDatabaseManager databasesWithOrigin:]):
1299 (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
1300 (-[WebDatabaseManager deleteAllDatabases]):
1301 (-[WebDatabaseManager deleteOrigin:]):
1302 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1303 * Storage/WebDatabaseQuotaManager.mm:
1304 (-[WebDatabaseQuotaManager usage]):
1305 (-[WebDatabaseQuotaManager quota]):
1306 (-[WebDatabaseQuotaManager setQuota:]):
1307 * WebCoreSupport/WebSecurityOrigin.mm:
1308 (-[WebSecurityOrigin usage]):
1309 (-[WebSecurityOrigin quota]):
1310 (-[WebSecurityOrigin setQuota:]):
1311 * WebView/WebFrame.mm:
1312 (-[WebFrame _cacheabilityDictionary]):
1313 * WebView/WebView.mm:
1314 (-[WebView _preferencesChanged:]):
1316 2015-02-26 Myles C. Maxfield <mmaxfield@apple.com>
1318 [Mac] [iOS] Parsing support for -apple-trailing-word
1319 https://bugs.webkit.org/show_bug.cgi?id=141939
1321 Reviewed by Andreas Kling.
1323 * Configurations/FeatureDefines.xcconfig:
1325 2015-02-24 Commit Queue <commit-queue@webkit.org>
1327 Unreviewed, rolling out r180599.
1328 https://bugs.webkit.org/show_bug.cgi?id=141998
1330 Lots of new test failures (Requested by smfr on #webkit).
1334 "Parsing support for -webkit-trailing-word"
1335 https://bugs.webkit.org/show_bug.cgi?id=141939
1336 http://trac.webkit.org/changeset/180599
1338 2015-02-24 Myles C. Maxfield <mmaxfield@apple.com>
1340 [Mac] [iOS] Parsing support for -apple-trailing-word
1341 https://bugs.webkit.org/show_bug.cgi?id=141939
1343 Reviewed by Andreas Kling.
1345 * Configurations/FeatureDefines.xcconfig:
1347 2015-02-24 Yusuke Suzuki <utatane.tea@gmail.com>
1349 REGRESSION(r179429): Can't type comments in Facebook
1350 https://bugs.webkit.org/show_bug.cgi?id=141859
1352 Reviewed by Brent Fulgham.
1354 Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1355 Private API, javaScriptExperimentsEnabled is dropped.
1357 * Misc/WebNSDictionaryExtras.h:
1358 * Misc/WebNSDictionaryExtras.m:
1359 (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1361 * WebView/WebPreferenceKeysPrivate.h:
1362 * WebView/WebPreferences.mm:
1363 (+[WebPreferences initialize]):
1364 (-[WebPreferences _setUnsignedIntValue:forKey:]):
1365 (-[WebPreferences javaScriptRuntimeFlags]):
1366 (-[WebPreferences setJavaScriptRuntimeFlags:]):
1367 (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1368 (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1369 * WebView/WebPreferencesPrivate.h:
1370 * WebView/WebView.mm:
1371 (-[WebView _preferencesChanged:]):
1373 2015-02-23 Commit Queue <commit-queue@webkit.org>
1375 Unreviewed, rolling out r180547 and r180550.
1376 https://bugs.webkit.org/show_bug.cgi?id=141957
1378 Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1380 Reverted changesets:
1382 "REGRESSION(r179429): Can't type comments in Facebook"
1383 https://bugs.webkit.org/show_bug.cgi?id=141859
1384 http://trac.webkit.org/changeset/180547
1386 "Constructor returning null should construct an object instead
1388 https://bugs.webkit.org/show_bug.cgi?id=141640
1389 http://trac.webkit.org/changeset/180550
1391 2015-02-23 Ryosuke Niwa <rniwa@webkit.org>
1393 Disable font loading events until our implementation gets updated to match the latest spec
1394 https://bugs.webkit.org/show_bug.cgi?id=141938
1396 Reviewed by Andreas Kling.
1398 * Configurations/FeatureDefines.xcconfig:
1400 2015-02-23 Yusuke Suzuki <utatane.tea@gmail.com>
1402 REGRESSION(r179429): Can't type comments in Facebook
1403 https://bugs.webkit.org/show_bug.cgi?id=141859
1405 Reviewed by Geoffrey Garen.
1407 Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1408 Private API, javaScriptExperimentsEnabled is dropped.
1410 * Misc/WebNSDictionaryExtras.h:
1411 * Misc/WebNSDictionaryExtras.m:
1412 (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1414 * WebView/WebPreferenceKeysPrivate.h:
1415 * WebView/WebPreferences.mm:
1416 (+[WebPreferences initialize]):
1417 (-[WebPreferences _setUnsignedIntValue:forKey:]):
1418 (-[WebPreferences javaScriptRuntimeFlags]):
1419 (-[WebPreferences setJavaScriptRuntimeFlags:]):
1420 (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1421 (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1422 * WebView/WebPreferencesPrivate.h:
1423 * WebView/WebView.mm:
1424 (-[WebView _preferencesChanged:]):
1426 2015-02-20 Eric Carlson <eric.carlson@apple.com>
1428 [iOS] cleanup AirPlay code
1429 https://bugs.webkit.org/show_bug.cgi?id=141811
1431 Reviewed by Jer Noble.
1433 * Configurations/FeatureDefines.xcconfig: IOS_AIRPLAY -> WIRELESS_PLAYBACK_TARGET.
1435 2015-02-18 Timothy Horton <timothy_horton@apple.com>
1437 Adopt WebCore::IOSurface in ImageBuffer
1438 https://bugs.webkit.org/show_bug.cgi?id=141751
1440 Reviewed by Simon Fraser.
1442 * WebCoreSupport/WebSystemInterface.mm:
1443 (InitWebCoreSystemInterface):
1444 Remove old WKSI IOSurface-related functions.
1446 2015-02-18 Commit Queue <commit-queue@webkit.org>
1448 Unreviewed, rolling out r180286.
1449 https://bugs.webkit.org/show_bug.cgi?id=141766
1451 Caused >50 crashed LayoutTests (Requested by jernoble on
1456 "Page::userContentController() should return a reference, not
1458 https://bugs.webkit.org/show_bug.cgi?id=141764
1459 http://trac.webkit.org/changeset/180286
1461 2015-02-18 Brady Eidson <beidson@apple.com>
1463 Page::userContentController() should return a reference, not a pointer
1464 https://bugs.webkit.org/show_bug.cgi?id=141764
1466 Reviewed by Jer Noble.
1468 * WebView/WebView.mm:
1469 (-[WebView setGroupName:]):
1471 2015-02-18 Chris Dumez <cdumez@apple.com>
1473 Access FontCache global instance via singleton() static member function
1474 https://bugs.webkit.org/show_bug.cgi?id=141726
1476 Reviewed by Daniel Bates.
1478 Access FontCache global instance via singleton() static member function,
1479 as per coding style.
1481 2015-02-17 Chris Dumez <cdumez@apple.com>
1483 Access MemoryPressureHandler global instance via a singleton() static member function
1484 https://bugs.webkit.org/show_bug.cgi?id=141691
1486 Reviewed by Andreas Kling.
1488 Access MemoryPressureHandler global instance via a singleton() static
1491 * WebView/WebView.mm:
1492 (-[WebView _commonInitializationWithFrameName:groupName:]):
1493 (+[WebView registerForMemoryNotifications]):
1494 (+[WebView _isUnderMemoryPressure]):
1495 (+[WebView _clearMemoryPressure]):
1496 (+[WebView _shouldWaitForMemoryClearMessage]):
1497 (WebInstallMemoryPressureHandler):
1499 2015-02-15 Sam Weinig <sam@webkit.org>
1501 Add experimental <attachment> element support
1502 https://bugs.webkit.org/show_bug.cgi?id=141626
1504 Reviewed by Tim Horton.
1506 * Configurations/FeatureDefines.xcconfig:
1508 2015-02-14 Joseph Pecoraro <pecoraro@apple.com>
1510 [Mac] Possible DDActionContext leaks, RetainPtr cleanup
1511 https://bugs.webkit.org/show_bug.cgi?id=141613
1513 Reviewed by Tim Horton.
1515 * WebCoreSupport/WebEditorClient.mm:
1516 (WebEditorClient::WebEditorClient):
1517 Avoid unnecessary retain/autorelease by adopting.
1519 * WebView/WebActionMenuController.mm:
1520 (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1521 Adopt the allocated object.
1523 2015-02-09 Brian J. Burg <burg@cs.washington.edu>
1525 Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace
1526 https://bugs.webkit.org/show_bug.cgi?id=141372
1528 Reviewed by Joseph Pecoraro.
1530 * WebCoreSupport/WebInspectorClient.mm:
1531 (-[WebInspectorWindowController destroyInspectorView:]):
1533 2015-02-14 Alexey Proskuryakov <ap@apple.com>
1535 rel="noreferrer" should make window.opener null
1536 https://bugs.webkit.org/show_bug.cgi?id=141579
1538 Reviewed by Darin Adler.
1540 * WebView/WebPDFView.mm:
1541 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore
1542 function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
1544 2015-02-05 Youenn Fablet <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
1546 [Streams API] Implement a barebone ReadableStream interface
1547 https://bugs.webkit.org/show_bug.cgi?id=141045
1549 Reviewed by Benjamin Poulain.
1551 * Configurations/FeatureDefines.xcconfig:
1553 2015-02-03 Enrica Casucci <enrica@apple.com>
1555 [iOS] Add support for deleteFromInputWithFlags.
1556 https://bugs.webkit.org/show_bug.cgi?id=141216
1557 rdar://problem/19130081
1559 Reviewed by Benjamin Poulain.
1561 Adopts the new method as soon as it is available.
1562 The patch also removes some obsolete code used for staging.
1564 * WebView/WebHTMLView.mm:
1565 (-[WebHTMLView _handleEditingKeyEvent:]):
1567 2015-02-02 Chris Dumez <cdumez@apple.com>
1569 Access MemoryCache singleton using MemoryCache::singleton()
1570 https://bugs.webkit.org/show_bug.cgi?id=141104
1572 Reviewed by Andreas Kling.
1574 Access MemoryCache singleton using MemoryCache::singleton() static
1575 member function, instead of a free function, as per the recent
1576 coding style discussion on WebKit-dev.
1578 2015-02-01 Chris Dumez <cdumez@apple.com>
1580 Use more references in HistoryItem
1581 https://bugs.webkit.org/show_bug.cgi?id=141133
1583 Reviewed by Andreas Kling.
1585 Use more references in HistoryItem instead of pointers.
1587 2015-01-31 Sam Weinig <sam@webkit.org>
1589 Remove even more Mountain Lion support
1590 https://bugs.webkit.org/show_bug.cgi?id=141124
1592 Reviewed by Alexey Proskuryakov.
1594 * Configurations/Base.xcconfig:
1595 * Configurations/DebugRelease.xcconfig:
1596 * Configurations/FeatureDefines.xcconfig:
1597 * Configurations/Version.xcconfig:
1598 * Configurations/WebKitLegacy.xcconfig:
1600 2015-01-30 Eric Carlson <eric.carlson@apple.com>
1602 Remove MediaPlayerProxy.h
1603 https://bugs.webkit.org/show_bug.cgi?id=141087
1605 Reviewed by Sam Weinig.
1607 * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h.
1608 * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h.
1610 2015-01-30 Chris Dumez <cdumez@apple.com>
1612 Rename shared() static member functions to singleton() for singleton classes.
1613 https://bugs.webkit.org/show_bug.cgi?id=141088
1615 Reviewed by Ryosuke Niwa and Benjamin Poulain.
1617 Rename shared() static member functions to singleton() for singleton
1618 classes as per the recent coding style change.
1620 2015-01-29 Beth Dakin <bdakin@apple.com>
1622 Remove more Mountain Lion code from WebKit
1623 https://bugs.webkit.org/show_bug.cgi?id=141050
1625 Reviewed by Anders Carlsson.
1627 * History/WebHistory.mm:
1629 * Panels/WebAuthenticationPanel.m:
1630 (-[WebAuthenticationPanel cancel:]):
1631 (-[WebAuthenticationPanel logIn:]):
1632 (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]):
1633 * WebCoreSupport/WebSystemInterface.mm:
1634 (InitWebCoreSystemInterface):
1635 * WebView/WebFrameView.mm:
1636 * WebView/WebPreferences.mm:
1637 (+[WebPreferences initialize]):
1638 (needsScreenFontsEnabledQuirk):
1639 * WebView/WebView.mm:
1640 (+[WebView registerForMemoryNotifications]):
1641 (-[WebView _preferencesChanged:]):
1642 (+[WebView initialize]):
1643 (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
1644 (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
1645 (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):
1647 2015-01-29 Sam Weinig <sam@webkit.org>
1649 Remove support for screen font substitution
1650 https://bugs.webkit.org/show_bug.cgi?id=141038
1652 Reviewed by Tim Horton.
1654 * Misc/WebKitNSStringExtras.mm:
1655 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1656 (-[NSString _web_widthWithFont:]):
1657 * Misc/WebStringTruncator.mm:
1659 Update for new signature of the FontPlatformData constructor, which no longer cares about
1660 whether to use printer fonts.
1662 * WebView/WebPreferenceKeysPrivate.h:
1663 Remove the WebKitScreenFontSubstitutionEnabledKey key.
1665 * WebView/WebPreferences.mm:
1666 (+[WebPreferences initialize]):
1667 Remove support for WebKitScreenFontSubstitutionEnabledKey.
1669 (needsScreenFontsEnabledQuirk): Deleted.
1670 Remove support for the Mountain Lion era 1-Password quirk.
1672 (-[WebPreferences screenFontSubstitutionEnabled]): Deleted.
1673 (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted.
1674 * WebView/WebPreferencesPrivate.h:
1675 * WebView/WebView.mm:
1676 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1677 (-[WebView _preferencesChanged:]):
1678 Remove support for the screen font substitution setting.
1680 2015-01-29 Chris Dumez <cdumez@apple.com>
1682 Clean up / modernize PageCache class
1683 https://bugs.webkit.org/show_bug.cgi?id=141009
1685 Reviewed by Darin Adler.
1687 Clean up / modernize PageCache class.
1689 * History/WebBackForwardList.mm:
1690 (-[WebBackForwardList pageCacheSize]):
1691 * WebView/WebView.mm:
1692 (-[WebView _loadBackForwardListFromOtherView:]):
1693 (-[WebView goToBackForwardItem:]):
1694 (+[WebView _setCacheModel:]):
1696 2015-01-28 Beth Dakin <bdakin@apple.com>
1698 Remove Mountain Lion code from WebKit and WebKit2
1699 https://bugs.webkit.org/show_bug.cgi?id=141010
1701 Reviewed by Sam Weinig.
1703 * DOM/WebDOMOperations.mm:
1705 * WebView/WebHTMLView.mm:
1708 2015-01-28 Dana Burkart <dburkart@apple.com>
1710 Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1711 https://bugs.webkit.org/show_bug.cgi?id=136765
1713 Reviewed by Alexey Proskuryakov.
1715 * Configurations/Base.xcconfig:
1716 * Configurations/DebugRelease.xcconfig:
1718 2015-01-28 Chris Dumez <cdumez@apple.com>
1720 Fix typo in markPagesForVistedLinkStyleRecalc()
1721 https://bugs.webkit.org/show_bug.cgi?id=140977
1723 Reviewed by Darin Adler.
1725 * WebCoreSupport/WebVisitedLinkStore.mm:
1726 (WebVisitedLinkStore::removeAllVisitedLinks):
1727 (WebVisitedLinkStore::removeVisitedLink):
1728 (WebVisitedLinkStore::addVisitedLinkHash):
1730 2015-01-28 Chris Dumez <cdumez@apple.com>
1732 Rename pageCache() to PageCache::shared() and return a reference
1733 https://bugs.webkit.org/show_bug.cgi?id=140983
1735 Reviewed by Andreas Kling.
1737 Rename pageCache() to PageCache::shared() as this is a singleton class
1738 and have it return a reference instead of a pointer.
1740 * History/WebBackForwardList.mm:
1741 (-[WebBackForwardList pageCacheSize]):
1742 * Misc/WebCoreStatistics.mm:
1743 (+[WebCoreStatistics cachedPageCount]):
1744 (+[WebCoreStatistics cachedFrameCount]):
1745 * WebCoreSupport/WebVisitedLinkStore.mm:
1746 (WebVisitedLinkStore::removeAllVisitedLinks):
1747 (WebVisitedLinkStore::removeVisitedLink):
1748 (WebVisitedLinkStore::addVisitedLinkHash):
1749 * WebView/WebView.mm:
1750 (+[WebView _setCacheModel:]):
1752 2015-01-27 Alexey Proskuryakov <ap@apple.com>
1754 More build fixes for newer clang.
1756 Rubber-stamped by Anders Carlsson.
1758 Marked a deprecated accessibility method as such.
1760 * WebView/WebFrame.mm:
1761 (-[WebFrame accessibilityRoot]):
1763 2015-01-27 Beth Dakin <bdakin@apple.com>
1765 Immediate action gesture recognizer still doesn't work well with IB
1766 https://bugs.webkit.org/show_bug.cgi?id=140967
1768 rdar://problem/19621509
1770 Reviewed by Tim Horton.
1772 We should add (or remove) the gesture recognizer in viewDidMoveToWindow because
1773 initWithFrame it too early and IB might mess with it.
1774 * WebView/WebImmediateActionController.h:
1775 * WebView/WebImmediateActionController.mm:
1776 (-[WebImmediateActionController immediateActionRecognizer]):
1777 * WebView/WebView.mm:
1778 (-[WebView _commonInitializationWithFrameName:groupName:]):
1779 (-[WebView viewDidMoveToWindow]):
1781 2015-01-27 Dan Bernstein <mitz@apple.com>
1783 Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
1785 Rubber-stamped by Anders Carlsson.
1787 * WebView/WebView.h: Added forward declarations of the protocols.
1789 2015-01-26 Anders Carlsson <andersca@apple.com>
1791 Make it easy to test enabling formal delegate protocols
1792 https://bugs.webkit.org/show_bug.cgi?id=140892
1794 Reviewed by Dan Bernstein.
1796 Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
1798 * Misc/WebDownload.h:
1799 * WebView/WebFrameLoadDelegate.h:
1800 * WebView/WebPolicyDelegate.h:
1801 * WebView/WebResourceLoadDelegate.h:
1802 * WebView/WebUIDelegate.h:
1803 * WebView/WebView.h:
1805 2015-01-26 Chris Dumez <cdumez@apple.com>
1807 Rename Document::body() to Document::bodyOrFrameset() for clarity
1808 https://bugs.webkit.org/show_bug.cgi?id=140902
1810 Reviewed by Andreas Kling.
1812 Rename Document::body() to Document::bodyOrFrameset() for clarity. This
1813 method does not necessarily return an HTMLBodyElement, it can also
1814 return a frameset as per the specification:
1815 http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
1817 This method is often misused internally (the caller is only interested
1818 in the <body> element). I will fix these instances in a follow-up patch,
1819 this patch is only renaming mechanically.
1821 2015-01-26 Chris Dumez <cdumez@apple.com>
1823 First argument to DOM traversal functions should be a reference
1824 https://bugs.webkit.org/show_bug.cgi?id=140895
1826 Reviewed by Antti Koivisto.
1828 First argument to DOM traversal functions should be a reference instead
1829 of a pointer as it is dereferenced without null-check.
1831 2015-01-26 Myles C. Maxfield <mmaxfield@apple.com>
1833 [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
1834 https://bugs.webkit.org/show_bug.cgi?id=140860
1836 Reviewed by Darin Adler.
1838 The fonts it makes are grotesque. (See what I did there? Typographic
1839 humor is the best humor.)
1841 * Configurations/FeatureDefines.xcconfig:
1843 2015-01-23 Timothy Horton <timothy_horton@apple.com>
1845 QLPreviewMenuItem popovers don't close when the page scrolls
1846 https://bugs.webkit.org/show_bug.cgi?id=140806
1847 <rdar://problem/19555618>
1849 Reviewed by Beth Dakin.
1851 Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
1853 * WebView/WebHTMLView.mm:
1854 (-[WebHTMLView scrollWheel:scrollWheel:]):
1855 Send scrollWheel along to WebImmediateActionController.
1857 * WebView/WebImmediateActionController.h:
1858 * WebView/WebImmediateActionController.mm:
1859 (-[WebImmediateActionController webView:didHandleScrollWheel:]):
1860 (-[WebImmediateActionController _clearImmediateActionState]):
1861 (-[WebImmediateActionController _defaultAnimationController]):
1862 Keep track of the active QLPreviewMenuItem, and close it upon scroll.
1864 2015-01-23 Timothy Horton <timothy_horton@apple.com>
1866 Infinite recursion in _clearImmediateActionState
1867 https://bugs.webkit.org/show_bug.cgi?id=140807
1868 <rdar://problem/19571601>
1870 Reviewed by Anders Carlsson.
1872 * WebView/WebImmediateActionController.mm:
1873 (-[WebImmediateActionController _clearImmediateActionState]):
1874 Use this opportunity to bring identical code to WebKit1, to avoid
1875 getting DataDetectors stuck when an immediate action is canceled.
1877 2015-01-22 Ryosuke Niwa <rniwa@webkit.org>
1879 Add a build flag for ES6 class syntax
1880 https://bugs.webkit.org/show_bug.cgi?id=140760
1882 Reviewed by Michael Saboff.
1884 * Configurations/FeatureDefines.xcconfig:
1886 2015-01-22 Beth Dakin <bdakin@apple.com>
1888 ibtoold crash below -[WebView close]
1889 https://bugs.webkit.org/show_bug.cgi?id=140782
1891 rdar://problem/19558472
1893 Reviewed by Tim Horton.
1895 Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but
1896 it is because interface builder is messing with our views.
1897 * WebView/WebImmediateActionController.h:
1898 * WebView/WebImmediateActionController.mm:
1899 (-[WebImmediateActionController webViewClosed]):
1900 (-[WebImmediateActionController _cancelImmediateAction]):
1901 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1902 (-[WebImmediateActionController _updateImmediateActionItem]):
1904 2015-01-21 Beth Dakin <bdakin@apple.com>
1906 Crash in QuickLook preview delegate method
1907 https://bugs.webkit.org/show_bug.cgi?id=140740
1909 rdar://problem/19540806
1911 Reviewed by Tim Horton.
1913 Clear out the delegate.
1914 * WebView/WebImmediateActionController.mm:
1915 (-[WebImmediateActionController webViewClosed]):
1917 2015-01-21 Csaba Osztrogonác <ossy@webkit.org>
1919 Remove ENABLE(INSPECTOR) ifdef guards
1920 https://bugs.webkit.org/show_bug.cgi?id=140668
1922 Reviewed by Darin Adler.
1924 * Configurations/FeatureDefines.xcconfig:
1925 * WebCoreSupport/WebFrameLoaderClient.mm:
1926 (WebFrameLoaderClient::dispatchWillSendRequest):
1928 2015-01-20 Anders Carlsson <andersca@apple.com>
1930 Remove USE(GLIB) code from WebKit1
1931 https://bugs.webkit.org/show_bug.cgi?id=140714
1933 Reviewed by Andreas Kling.
1935 * WebView/WebView.mm:
1936 (-[WebView _commonInitializationWithFrameName:groupName:]):
1937 (-[WebView _close]):
1938 (-[WebView _clearGlibLoopObserver]): Deleted.
1939 (glibContextIterationCallback): Deleted.
1940 (-[WebView _scheduleGlibContextIterations]): Deleted.
1941 * WebView/WebViewData.h:
1942 * WebView/WebViewInternal.h:
1944 2015-01-20 David Kilzer <ddkilzer@apple.com>
1946 Switch to comparing PLATFORM_NAME in terms of macosx
1947 <http://webkit.org/b/139516>
1949 Reviewed by Timothy Hatcher.
1951 * MigrateHeaders.make:
1952 * postprocess-headers.sh:
1954 2015-01-19 Myles C. Maxfield <mmaxfield@apple.com>
1956 [SVG -> OTF Converter] Flip the switch on
1957 https://bugs.webkit.org/show_bug.cgi?id=140592
1959 Reviewed by Antti Koivisto.
1961 * Configurations/FeatureDefines.xcconfig:
1963 2015-01-19 Beth Dakin <bdakin@apple.com>
1965 Speculative build fix.
1967 * WebView/WebView.mm:
1968 (-[WebView _commonInitializationWithFrameName:groupName:]):
1970 2015-01-19 Beth Dakin <bdakin@apple.com>
1972 Speculative build fix.
1974 * WebView/WebView.mm:
1975 (-[WebView _convertRectFromRootView:]):
1977 2015-01-19 Timothy Horton <timothy_horton@apple.com>
1979 Adjust naming of action menu SPI
1980 https://bugs.webkit.org/show_bug.cgi?id=140644
1981 <rdar://problem/19448129>
1983 Reviewed by Brian Weinstein.
1985 * WebView/WebActionMenuController.mm:
1986 (-[WebActionMenuController prepareForMenu:withEvent:]):
1987 (-[WebActionMenuController willOpenMenu:withEvent:]):
1988 (-[WebActionMenuController didCloseMenu:withEvent:]):
1989 * WebView/WebView.mm:
1990 (-[WebView _commonInitializationWithFrameName:groupName:]):
1991 (-[WebView prepareForMenu:withEvent:]):
1992 (-[WebView willOpenMenu:withEvent:]):
1993 (-[WebView didCloseMenu:withEvent:]):
1995 2015-01-19 Beth Dakin <bdakin@apple.com>
1997 REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is
1998 offset by flipped-ness
1999 https://bugs.webkit.org/show_bug.cgi?id=140643
2001 rdar://problem/19489593
2003 Reviewed by Tim Horton.
2005 We universally flipped because we assumed that the root view was flipped and the
2006 WebView was not. However, in Dictionary, the WebView is flipped! So this patch
2007 fixes that assumption by checking the WebView’s flipped-ness.
2008 * WebView/WebView.mm:
2009 (-[WebView _convertRectFromRootView:]):
2011 2015-01-19 Commit Queue <commit-queue@webkit.org>
2013 Unreviewed, rolling out r178653.
2014 https://bugs.webkit.org/show_bug.cgi?id=140634
2016 Broke multiple SVG tests on Mountain Lion (Requested by ap on
2021 "[SVG -> OTF Converter] Flip the switch on"
2022 https://bugs.webkit.org/show_bug.cgi?id=140592
2023 http://trac.webkit.org/changeset/178653
2025 2015-01-19 Myles C. Maxfield <mmaxfield@apple.com>
2027 [SVG -> OTF Converter] Flip the switch on
2028 https://bugs.webkit.org/show_bug.cgi?id=140592
2030 Reviewed by Antti Koivisto.
2032 * Configurations/FeatureDefines.xcconfig:
2034 2015-01-18 Daniel Bates <dabates@apple.com>
2036 Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
2037 (https://bugs.webkit.org/show_bug.cgi?id=129441)
2039 Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
2040 Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
2042 * WebInspector/WebNodeHighlightView.mm:
2043 (-[WebNodeHighlightView layoutSublayers:]):
2045 2015-01-16 Beth Dakin <bdakin@apple.com>
2047 Make sure early cancellation of immediate action actually does that in WK1
2048 https://bugs.webkit.org/show_bug.cgi?id=140566
2050 rdar://problem/19490114
2052 Reviewed by Tim Horton.
2054 Work around an AppKit bug by dispatching the call to _cancelImmediateAction
2056 * WebView/WebImmediateActionController.mm:
2057 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2059 2015-01-16 Daniel Bates <dabates@apple.com>
2061 Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
2062 (https://bugs.webkit.org/show_bug.cgi?id=140360)
2064 Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
2066 * Misc/WebDownload.h:
2068 2015-01-15 Csaba Osztrogonác <ossy@webkit.org>
2070 Remove ENABLE(SQL_DATABASE) guards
2071 https://bugs.webkit.org/show_bug.cgi?id=140434
2073 Reviewed by Darin Adler.
2075 * Configurations/FeatureDefines.xcconfig:
2076 * Storage/WebDatabaseManager.mm:
2077 (databasesDirectoryPath):
2078 * Storage/WebDatabaseManagerClient.h:
2079 * Storage/WebDatabaseManagerClient.mm:
2080 * Storage/WebDatabaseManagerInternal.h:
2081 * Storage/WebDatabaseManagerPrivate.h:
2082 * Storage/WebDatabaseQuotaManager.mm:
2083 (-[WebDatabaseQuotaManager usage]):
2084 (-[WebDatabaseQuotaManager quota]):
2085 (-[WebDatabaseQuotaManager setQuota:]):
2086 * WebCoreSupport/WebChromeClient.h:
2087 * WebCoreSupport/WebChromeClient.mm:
2088 * WebCoreSupport/WebSecurityOrigin.mm:
2089 (-[WebSecurityOrigin usage]):
2090 (-[WebSecurityOrigin quota]):
2091 (-[WebSecurityOrigin setQuota:]):
2092 * WebView/WebFrame.mm:
2093 (-[WebFrame _cacheabilityDictionary]):
2094 * WebView/WebView.mm:
2095 (-[WebView _commonInitializationWithFrameName:groupName:]):
2096 (-[WebView _preferencesChanged:]):
2098 2015-01-14 Chris Dumez <cdumez@apple.com>
2100 Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
2101 https://bugs.webkit.org/show_bug.cgi?id=140347
2103 Reviewed by Darin Adler.
2105 Call FontDescription::setIsItalic() instead of setItalic() as the
2106 call site passes a boolean.
2108 * WebView/WebHTMLView.mm:
2109 (fontNameForDescription):
2111 2015-01-13 Anders Carlsson <andersca@apple.com>
2113 Temporarily reintroduce the informal delegate protocols
2114 https://bugs.webkit.org/show_bug.cgi?id=140416
2116 Reviewed by Dan Bernstein.
2118 * WebView/WebEditingDelegate.h:
2119 * WebView/WebFrameLoadDelegate.h:
2120 * WebView/WebPolicyDelegate.h:
2121 * WebView/WebResourceLoadDelegate.h:
2122 * WebView/WebUIDelegate.h:
2124 2015-01-13 Beth Dakin <bdakin@apple.com>
2126 Should disable immediate actions for iTunes
2127 https://bugs.webkit.org/show_bug.cgi?id=140405
2129 rdar://problem/19461358
2131 Reviewed by Tim Horton.
2133 * WebView/WebImmediateActionController.mm:
2134 (-[WebImmediateActionController _updateImmediateActionItem]):
2136 2015-01-11 Sam Weinig <sam@webkit.org>
2138 Remove support for SharedWorkers
2139 https://bugs.webkit.org/show_bug.cgi?id=140344
2141 Reviewed by Anders Carlsson.
2143 * Configurations/FeatureDefines.xcconfig:
2144 * WebCoreSupport/WebPlatformStrategies.h:
2145 * WebCoreSupport/WebPlatformStrategies.mm:
2146 (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
2148 2015-01-12 Timothy Horton <timothy_horton@apple.com>
2150 Get rid of unnecessary reimplementations of CGFloor/Ceiling
2151 https://bugs.webkit.org/show_bug.cgi?id=140375
2153 Reviewed by Simon Fraser.
2155 * Misc/WebKitNSStringExtras.mm:
2156 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2157 (webkit_CGCeiling): Deleted.
2158 Delete unnecessary code, use the real CGFloor/Ceiling instead.
2160 2015-01-12 Anders Carlsson <andersca@apple.com>
2162 Make delegates conform to formal delegate protocols
2163 https://bugs.webkit.org/show_bug.cgi?id=140370
2165 Reviewed by Dan Bernstein.
2167 * DefaultDelegates/WebDefaultPolicyDelegate.h:
2168 * WebCoreSupport/WebInspectorClient.mm:
2169 Add protocols to the interface declarations.
2171 * WebView/WebActionMenuController.mm:
2172 (-[WebActionMenuController prepareForMenu:withEvent:]):
2173 (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2174 * WebView/WebImmediateActionController.mm:
2175 (-[WebImmediateActionController _updateImmediateActionItem]):
2176 (-[WebImmediateActionController _menuItemForDataDetectedText]):
2177 Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
2179 2015-01-12 Myles C. Maxfield <mmaxfield@apple.com>
2181 Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
2182 https://bugs.webkit.org/show_bug.cgi?id=136769
2184 Reviewed by Antti Koivisto.
2186 * Configurations/FeatureDefines.xcconfig:
2188 2015-01-12 Timothy Horton <timothy_horton@apple.com>
2190 Multi-rect TextIndicators are vertically flipped in WebKit1
2191 https://bugs.webkit.org/show_bug.cgi?id=140350
2192 <rdar://problem/19441243>
2194 Reviewed by Beth Dakin.
2196 * WebView/WebView.mm:
2197 (-[WebView _setTextIndicator:fadeOut:]):
2198 Convert the textBoundingRect from root view to screen coordinates.
2200 2015-01-12 Anders Carlsson <andersca@apple.com>
2202 Make WebResourceDelegate a formal protocol as well
2203 https://bugs.webkit.org/show_bug.cgi?id=140364
2205 Reviewed by Dan Bernstein.
2207 * WebView/WebResourceLoadDelegate.h:
2209 2015-01-12 Anders Carlsson <andersca@apple.com>
2211 Delegates should be formal protocols
2212 https://bugs.webkit.org/show_bug.cgi?id=140360
2213 rdar://problem/17380856
2215 Reviewed by Dan Bernstein.
2217 This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
2219 * DefaultDelegates/WebDefaultUIDelegate.h:
2220 * Misc/WebDownload.h:
2221 * WebView/WebEditingDelegate.h:
2222 * WebView/WebFrameLoadDelegate.h:
2223 * WebView/WebPolicyDelegate.h:
2224 * WebView/WebUIDelegate.h:
2226 2015-01-09 Anders Carlsson <andersca@apple.com>
2228 Get rid of the database strategy
2229 https://bugs.webkit.org/show_bug.cgi?id=140322
2231 Reviewed by Sam Weinig.
2233 * WebCoreSupport/WebPlatformStrategies.h:
2234 * WebCoreSupport/WebPlatformStrategies.mm:
2235 (WebPlatformStrategies::createDatabaseStrategy): Deleted.
2237 2015-01-08 Timothy Horton <timothy_horton@apple.com>
2239 Can't use DataDetectors after immediate action preparation
2240 https://bugs.webkit.org/show_bug.cgi?id=140263
2241 <rdar://problem/19412705>
2243 Reviewed by Beth Dakin.
2245 * WebView/WebImmediateActionController.mm:
2246 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2247 (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2248 To match WebKit2, only call shouldUseActions if the animation is actually
2249 going to begin, not when preparing for it. This way, we're guaranteed
2250 to get a didCancel or didComplete.
2252 2015-01-08 Dean Jackson <dino@apple.com>
2254 Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
2255 https://bugs.webkit.org/show_bug.cgi?id=140232
2256 <rdar://problem/19371010>
2258 Reviewed by Anders Carlsson.
2260 Remove the applicationChromeMode setting, but leave stubs in to make
2261 sure existing binaries don't break.
2263 * WebCoreSupport/WebInspectorClient.mm:
2264 (-[WebInspectorWindowController init]):
2265 * WebView/WebPreferenceKeysPrivate.h:
2266 * WebView/WebPreferences.mm:
2267 (+[WebPreferences initialize]):
2268 (-[WebPreferences applicationChromeModeEnabled]):
2269 (-[WebPreferences setApplicationChromeModeEnabled:]):
2270 * WebView/WebView.mm:
2271 (-[WebView _preferencesChanged:]):
2273 2015-01-07 Daniel Bates <dabates@apple.com>
2275 [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2276 https://bugs.webkit.org/show_bug.cgi?id=137371
2278 Reviewed by David Kilzer.
2280 Use SPI wrapper headers instead of directly references private SPI headers.
2282 * Plugins/Hosted/NetscapePluginHostManager.mm:
2284 2015-01-07 Commit Queue <commit-queue@webkit.org>
2286 Unreviewed, rolling out r178068.
2287 https://bugs.webkit.org/show_bug.cgi?id=140235
2289 Breaks the iOS build (Requested by enrica on #webkit).
2293 "[iOS] Make WebKit2 build with public iOS SDK and more build
2295 https://bugs.webkit.org/show_bug.cgi?id=137371
2296 http://trac.webkit.org/changeset/178068
2298 2015-01-07 Daniel Bates <dabates@apple.com>
2300 [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2301 https://bugs.webkit.org/show_bug.cgi?id=137371
2303 Reviewed by David Kilzer.
2305 Use SPI wrapper headers instead of directly references private SPI headers.
2307 * Plugins/Hosted/NetscapePluginHostManager.mm:
2309 2015-01-07 Beth Dakin <bdakin@apple.com>
2311 Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the
2313 https://bugs.webkit.org/show_bug.cgi?id=140206
2315 rdar://problem/19300492
2317 Reviewed by Tim Horton.
2319 Providing and item frame will ensure that the original link is not obscured.
2320 * WebView/WebImmediateActionController.mm:
2321 (elementBoundingBoxInWindowCoordinatesFromNode):
2322 (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
2324 For now use a max size that is smaller than the WebView, with the screen’s aspect
2325 ratio, and scaled down.
2326 (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
2328 2015-01-07 Anders Carlsson <andersca@apple.com>
2330 Give simple HTML documents a database provider
2331 https://bugs.webkit.org/show_bug.cgi?id=140192
2332 rdar://problem/19398825
2334 Reviewed by Tim Horton.
2336 * WebView/WebView.mm:
2337 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2339 2015-01-06 Anders Carlsson <andersca@apple.com>
2341 Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
2342 https://bugs.webkit.org/show_bug.cgi?id=140140
2344 Reviewed by Andreas Kling.
2346 Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
2347 out of WebCore since nobody else is using it.
2349 * Plugins/WebNetscapePluginView.h:
2350 * Plugins/WebNetscapePluginView.mm:
2351 (-[WebNetscapePluginView _createPlugin]):
2352 (-[WebNetscapePluginView _destroyPlugin]):
2354 (NPN_PluginThreadAsyncCall):
2356 2015-01-06 Anders Carlsson <andersca@apple.com>
2358 Add a WebKit1 database provider
2359 https://bugs.webkit.org/show_bug.cgi?id=140126
2361 Reviewed by Sam Weinig.
2363 Set the database provider.
2365 * WebView/WebView.mm:
2366 (-[WebView _commonInitializationWithFrameName:groupName:]):
2368 2015-01-06 Commit Queue <commit-queue@webkit.org>
2370 Unreviewed, rolling out r177963.
2371 https://bugs.webkit.org/show_bug.cgi?id=140136
2373 Caused lots of crashes (Requested by smfr on #webkit).
2377 "Add a WebKit1 database provider"
2378 https://bugs.webkit.org/show_bug.cgi?id=140126
2379 http://trac.webkit.org/changeset/177963
2381 2015-01-06 Anders Carlsson <andersca@apple.com>
2383 Add a WebKit1 database provider
2384 https://bugs.webkit.org/show_bug.cgi?id=140126
2386 Reviewed by Sam Weinig.
2388 Set the database provider.
2390 * WebView/WebView.mm:
2391 (-[WebView _commonInitializationWithFrameName:groupName:]):
2393 2015-01-01 Jeff Miller <jeffm@apple.com>
2395 Update user-visible copyright strings to include 2015
2396 https://bugs.webkit.org/show_bug.cgi?id=139880
2398 Reviewed by Darin Adler.
2402 2014-12-30 Dan Bernstein <mitz@apple.com>
2404 [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
2405 https://bugs.webkit.org/show_bug.cgi?id=140003
2407 Reviewed by Darin Adler.
2409 * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
2410 that takes their "string" parameter as a "value" "parameter and has an attribute telling
2411 the compiler that if the "value" parameter is a format string then the function returns a
2412 modified version of it. The result is that if UI_STRING is used as a format string parameter
2413 to some function or method, the compiler will check the format specifiers in the string
2414 against the other parameters.
2416 2014-12-29 Dan Bernstein <mitz@apple.com>
2418 Fixed the iOS build.
2420 * Configurations/WebKitLegacy.xcconfig:
2422 2014-12-29 Anders Carlsson <andersca@apple.com>
2424 Get rid of some PageGroup storage functions
2425 https://bugs.webkit.org/show_bug.cgi?id=139996
2427 Reviewed by Sam Weinig.
2429 Call WebStorageNamespaceProvider directly instead.
2431 * Storage/WebStorageManager.mm:
2432 (-[WebStorageManager syncLocalStorage]):
2433 (+[WebStorageManager closeIdleLocalStorageDatabases]):
2434 * WebView/WebView.mm:
2435 (+[WebView _applicationWillTerminate]):
2437 2014-12-29 Anders Carlsson <andersca@apple.com>
2439 Move storage code from WebCore to WebKit
2440 https://bugs.webkit.org/show_bug.cgi?id=139558
2442 Reviewed by Darin Adler.
2444 * Storage/WebStorageManager.mm:
2445 * Storage/WebStorageTrackerClient.h:
2446 * WebView/WebView.mm:
2448 2014-12-26 Dan Bernstein <mitz@apple.com>
2450 <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
2451 https://bugs.webkit.org/show_bug.cgi?id=139950
2453 Reviewed by David Kilzer.
2455 * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
2456 in a manner that works with Xcode 5.1.1.
2458 2014-12-23 Timothy Horton <timothy_horton@apple.com>
2460 Install a TextIndicator for link immediate actions
2461 https://bugs.webkit.org/show_bug.cgi?id=139897
2462 <rdar://problem/19333076>
2464 Reviewed by Anders Carlsson.
2466 * WebView/WebImmediateActionController.h:
2467 * WebView/WebImmediateActionController.mm:
2468 (-[WebImmediateActionController _clearImmediateActionState]):
2469 Tear down the TextIndicator, just like WebKit2.
2471 (-[WebImmediateActionController _defaultAnimationController]):
2472 Install a TextIndicator for links.
2474 (-[WebImmediateActionController menuItemDidClose:]):
2475 Tear down the TextIndicator when the QL preview closes.
2477 (-[WebImmediateActionController _menuItemForDataDetectedText]):
2478 Directly install and uninstall the TextIndicator for DataDetectors.
2480 (-[WebImmediateActionController _showTextIndicator]): Deleted.
2481 (-[WebImmediateActionController _hideTextIndicator]): Deleted.
2482 Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
2484 2014-12-20 Eric Carlson <eric.carlson@apple.com>
2486 [iOS] add optimized fullscreen API
2487 https://bugs.webkit.org/show_bug.cgi?id=139833
2488 <rdar://problem/18844486>
2490 Reviewed by Simon Fraser.
2492 * Configurations/FeatureDefines.xcconfig: Add ENABLE_VIDEO_PRESENTATION_MODE.
2494 2014-12-20 David Kilzer <ddkilzer@apple.com>
2496 Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2497 <http://webkit.org/b/139463>
2499 Reviewed by Mark Rowe.
2501 * Configurations/Base.xcconfig:
2502 - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2504 - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2505 * Configurations/DebugRelease.xcconfig:
2506 - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2507 - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2508 * Configurations/Version.xcconfig:
2509 - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2510 * Configurations/WebKitLegacy.xcconfig:
2511 - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2512 FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2513 DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2514 NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2515 WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2516 PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2517 WEBCORE_PRIVATE_HEADERS_DIR_Production and
2518 WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2520 - Fix PRODUCTION_ROOT to actually be set properly.
2521 - Simplify EXPORTED_SYMBOLS_FILE_i386.
2523 * migrate-headers.sh:
2524 - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2525 - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
2526 WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
2527 WebKitLegacy.xcconfig.
2529 2014-12-19 Simon Fraser <simon.fraser@apple.com>
2531 Fix pink background on CoreAnimation plug-ins in WebKit1
2532 https://bugs.webkit.org/show_bug.cgi?id=139845
2533 rdar://problem/19313075
2535 Reviewed by Tim Horton.
2537 r154078 left in some debugging code that set a pink background on plug-in hosting
2540 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2541 (-[WebHostedNetscapePluginView createPluginLayer]):
2543 2014-12-19 Andreas Kling <akling@apple.com>
2545 Ref-ify TextIterator API.
2546 <https://webkit.org/b/139823>
2548 Reviewed by Antti Koivisto.
2550 * WebView/WebTextIterator.mm:
2551 (-[WebTextIterator currentRange]):
2553 2014-12-19 Joseph Pecoraro <pecoraro@apple.com>
2555 Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
2556 https://bugs.webkit.org/show_bug.cgi?id=139797
2558 Reviewed by Mark Lam.
2560 * WebView/WebScriptDebugger.h:
2561 * WebView/WebScriptDebugger.mm:
2562 (WebScriptDebugger::handlePause):
2563 Standardize on passing JSGlobalObject parameter first.
2565 2014-12-19 Commit Queue <commit-queue@webkit.org>
2567 Unreviewed, rolling out r177574.
2568 https://bugs.webkit.org/show_bug.cgi?id=139821
2570 "Broke Production builds by installing
2571 libWebCoreTestSupport.dylib in the wrong directory" (Requested
2572 by ddkilzer on #webkit).
2576 "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
2577 WebInspectorUI, WebKit, WebKit2"
2578 https://bugs.webkit.org/show_bug.cgi?id=139463
2579 http://trac.webkit.org/changeset/177574
2581 2014-12-19 David Kilzer <ddkilzer@apple.com>
2583 Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2584 <http://webkit.org/b/139463>
2586 Reviewed by Mark Rowe.
2588 * Configurations/Base.xcconfig:
2589 - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2591 - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2592 * Configurations/DebugRelease.xcconfig:
2593 - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2594 - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2595 * Configurations/Version.xcconfig:
2596 - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2597 * Configurations/WebKitLegacy.xcconfig:
2598 - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2599 FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2600 DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2601 NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2602 WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2603 PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2604 WEBCORE_PRIVATE_HEADERS_DIR_Production and
2605 WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2607 - Fix PRODUCTION_ROOT to actually be set properly.
2608 - Simplify EXPORTED_SYMBOLS_FILE_i386.
2610 * migrate-headers.sh:
2611 - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2612 - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
2613 WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
2614 WebKitLegacy.xcconfig.
2616 2014-12-18 Andreas Kling <akling@apple.com>
2618 Ref-ify various Document-related things.
2619 <https://webkit.org/b/139796>
2621 Reviewed by Anders Carlsson.
2623 * WebView/WebFrame.mm:
2624 (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
2626 2014-12-18 Beth Dakin <bdakin@apple.com>
2628 Need to re-enable action menus
2629 https://bugs.webkit.org/show_bug.cgi?id=139795
2631 rdar://problem/19299367
2633 Reviewed by Tim Horton.
2635 Re-enable the menus by un-commenting the code to create the menu and controller.
2636 * WebView/WebView.mm:
2637 (-[WebView _commonInitializationWithFrameName:groupName:]):
2639 2014-12-16 Sam Weinig <sam@webkit.org>
2641 Unify the Mac and iOS implementations of FontPlatformData a bit
2642 https://bugs.webkit.org/show_bug.cgi?id=139721
2644 Reviewed by Anders Carlsson.
2646 * WebView/WebHTMLView.mm:
2647 (fontNameForDescription):
2648 Update for new function name.
2650 2014-12-18 Antti Koivisto <antti@apple.com>
2652 Remove alwaysUseBaselineOfPrimaryFont setting
2653 https://bugs.webkit.org/show_bug.cgi?id=139770
2655 Reviewed by Anders Carlsson.
2657 * WebView/WebPreferenceKeysPrivate.h:
2658 * WebView/WebPreferences.mm:
2659 (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
2660 (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
2661 * WebView/WebPreferencesPrivate.h:
2662 * WebView/WebView.mm:
2663 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2664 (-[WebView _preferencesChanged:]):
2666 2014-12-17 Andreas Kling <akling@apple.com>
2668 Ref-ify Range::create().
2669 <https://webkit.org/b/139755>
2671 Reviewed by Anders Carlsson.
2673 * WebView/WebHTMLRepresentation.mm:
2674 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2675 * WebView/WebHTMLView.mm:
2676 (-[WebHTMLView attributedString]):
2678 2014-12-17 Anders Carlsson <andersca@apple.com>
2680 Unify -[WebResource description]
2681 https://bugs.webkit.org/show_bug.cgi?id=139762
2683 Reviewed by Dan Bernstein.
2685 * WebView/WebResource.mm:
2686 (-[WebResource description]):
2688 2014-12-17 Anders Carlsson <andersca@apple.com>
2690 Get rid of an ugly #define hack in WebFrameLoaderClient
2691 https://bugs.webkit.org/show_bug.cgi?id=139761
2693 Reviewed by Dan Bernstein.
2695 Also replace @private with @package in all public headers, for consistency.
2697 * History/WebBackForwardList.h:
2698 * History/WebHistory.h:
2699 * Misc/WebDownload.h:
2700 * WebCoreSupport/WebFrameLoaderClient.mm:
2701 * WebView/WebArchive.h:
2702 * WebView/WebDataSource.h:
2703 * WebView/WebFrame.h:
2704 * WebView/WebFrameView.h:
2705 * WebView/WebPreferences.h:
2706 * WebView/WebResource.h:
2708 2014-12-17 Dan Bernstein <mitz@apple.com>
2710 <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
2711 https://bugs.webkit.org/show_bug.cgi?id=139760
2713 Reviewed by Anders Carlsson.
2715 * Configurations/WebKitLegacy.xcconfig:
2717 2014-12-17 Andreas Kling <akling@apple.com>
2719 Purge PassRefPtr from Frame.
2720 <https://webkit.org/b/139731>
2722 Reviewed by Anders Carlsson.
2724 * WebCoreSupport/WebFrameLoaderClient.mm:
2725 (WebFrameLoaderClient::transitionToCommittedForNewPage):
2726 * WebView/WebFrame.mm:
2727 (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
2728 (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
2729 * WebView/WebFrameInternal.h:
2731 2014-12-16 Timothy Horton <timothy_horton@apple.com>
2733 Implement and adopt two new TextIndicator presentation animations
2734 https://bugs.webkit.org/show_bug.cgi?id=139715
2735 <rdar://problem/19237945>
2737 Reviewed by Anders Carlsson.
2739 * WebView/WebActionMenuController.mm:
2740 (-[WebActionMenuController _showTextIndicator]):
2741 * WebView/WebHTMLView.mm:
2742 (-[WebHTMLView quickLookWithEvent:]):
2743 Remove the completionHandler from text indicator presentation.
2745 * WebView/WebImmediateActionController.mm:
2746 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2747 (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
2748 (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2749 (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2750 (-[WebImmediateActionController _menuItemForDataDetectedText]):
2751 (-[WebImmediateActionController _animationControllerForText]):
2752 (-[WebImmediateActionController _showTextIndicator]):
2753 Forward immediate action gesture recognizer animation progress
2754 to TextIndicator. Force us to keep the selection when immediate
2755 action popovers steal first responder status from the WebView.
2756 If the Lookup range is equal to the selection range, use a Crossfade
2757 animation; otherwise, use a FadeIn animation.
2759 * WebView/WebView.mm:
2760 (-[WebView _setMaintainsInactiveSelection:]):
2761 (-[WebView maintainsInactiveSelection]):
2762 (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2763 (-[WebView _setTextIndicator:fadeOut:]):
2764 (-[WebView _clearTextIndicator]):
2765 (-[WebView _setTextIndicatorAnimationProgress:]):
2766 (-[WebView _showDictionaryLookupPopup:]):
2767 (-[WebView _dictionaryLookupPopoverWillClose:]):
2768 (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2769 Remove the completionHandler from text indicator presentation.
2770 Add a _setMaintainsInactiveSelection, which allows WebKit internals
2771 to change the return value of -maintainsInactiveSelection, allowing
2772 us to keep the selection alive when the WebView loses first responder status.
2774 * WebView/WebViewData.h:
2775 * WebView/WebViewInternal.h:
2777 2014-12-16 Andreas Kling <akling@apple.com>
2779 Use Ref for SecurityOrigin.
2780 <https://webkit.org/b/139710>
2782 Reviewed by Anders Carlsson.
2784 * Storage/WebStorageTrackerClient.mm:
2785 (WebStorageTrackerClient::dispatchDidModifyOrigin):
2786 * WebView/WebView.mm:
2787 (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
2788 (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
2790 2014-12-16 Beth Dakin <bdakin@apple.com>
2792 Crash getting default animation controller for some text
2793 https://bugs.webkit.org/show_bug.cgi?id=139712
2795 rdar://problem/19271707
2797 Reviewed by Tim Horton.
2799 Must null-check the range.
2800 * WebView/WebImmediateActionController.mm:
2801 (-[WebImmediateActionController _animationControllerForText]):
2803 2014-12-16 Timothy Horton <timothy_horton@apple.com>
2805 Immediate action popovers can get stuck open
2806 https://bugs.webkit.org/show_bug.cgi?id=139709
2807 <rdar://problem/19270279>
2809 Reviewed by Beth Dakin.
2811 * WebView/WebImmediateActionController.mm:
2812 (-[WebImmediateActionController _clearImmediateActionState]):
2813 Don't clear the animation controller; it breaks things and was unnecessary.
2815 2014-12-16 Tim Horton <timothy_horton@apple.com>
2817 Disable TextIndication for Lookup immediate actions
2818 https://bugs.webkit.org/show_bug.cgi?id=139684
2820 Reviewed by Anders Carlsson.
2822 * WebView/WebView.mm:
2823 (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2825 2014-12-15 Beth Dakin <bdakin@apple.com>
2829 * WebView/WebImmediateActionController.mm:
2831 2014-12-15 Beth Dakin <bdakin@apple.com>
2833 Speculative build fix.
2835 * WebView/WebView.mm:
2836 (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2837 * WebView/WebViewInternal.h:
2839 2014-12-15 Beth Dakin <bdakin@apple.com>
2841 Make lookup an immediate action instead of an action menu item
2842 https://bugs.webkit.org/show_bug.cgi?id=139661
2844 rdar://problem/19198414
2846 Reviewed by Tim Horton.
2848 Remove the lookup menu items and non-unused static function associated with
2850 * WebView/WebActionMenuController.mm:
2851 (-[WebActionMenuController _defaultMenuItemsForText]):
2852 (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2853 (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2854 (-[WebActionMenuController _createActionMenuItemForTag:]):
2855 (-[WebActionMenuController _lookupText:]): Deleted.
2856 (performDictionaryLookupForSelection): Deleted.
2857 (performDictionaryLookupForRange): Deleted.
2859 Set the defaultAnimationController to the lookup-provided animation controller
2861 * WebView/WebImmediateActionController.mm:
2862 (-[WebImmediateActionController _defaultAnimationController]):
2863 (dictionaryPopupInfoForRange):
2864 (-[WebImmediateActionController _animationControllerForText]):
2867 * WebView/WebUIDelegatePrivate.h:
2869 New function to get the lookup animation controller.
2870 * WebView/WebView.mm:
2871 (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2872 * WebView/WebViewInternal.h:
2874 2014-12-15 Timothy Horton <timothy_horton@apple.com>
2876 Implement Data Detectors immediate actions for Legacy WebKit
2877 https://bugs.webkit.org/show_bug.cgi?id=139619
2878 <rdar://problem/19198539>
2880 Reviewed by Beth Dakin.
2882 * WebView/WebImmediateActionController.mm:
2883 (-[WebImmediateActionController _menuItemForDataDetectedText]):
2884 Note that this action context is only for immediate actions.
2886 2014-12-15 Myles C. Maxfield <mmaxfield@apple.com>
2888 Addressing post-review comments in r177035
2889 https://bugs.webkit.org/show_bug.cgi?id=139557
2891 Reviewed by Darin Adler.
2893 * WebView/WebActionMenuController.mm:
2894 (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
2896 2014-12-15 Timothy Horton <timothy_horton@apple.com>
2898 Implement Data Detectors immediate actions for Legacy WebKit
2899 https://bugs.webkit.org/show_bug.cgi?id=139619
2900 <rdar://problem/19198539>
2902 Reviewed by Eric Carlson.
2904 * WebView/WebHTMLView.mm:
2905 (-[WebHTMLView mouseDown:mouseDown:]):
2906 Send mouseDown along to the WebImmediateActionController too.
2908 * WebView/WebImmediateActionController.h:
2909 * WebView/WebImmediateActionController.mm:
2910 (-[WebImmediateActionController webViewClosed]):
2911 (-[WebImmediateActionController webView:willHandleMouseDown:]):
2912 (-[WebImmediateActionController _cancelImmediateAction]):
2913 (-[WebImmediateActionController _clearImmediateActionState]):
2914 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2915 (-[WebImmediateActionController _defaultAnimationController]):
2916 (-[WebImmediateActionController _updateImmediateActionItem]):
2917 (-[WebImmediateActionController _menuItemForDataDetectedText]):
2918 (-[WebImmediateActionController _showTextIndicator]):
2919 (-[WebImmediateActionController _hideTextIndicator]):
2920 Copy most of the DataDetectors implementation into WebImmediateActionController.
2922 * WebView/WebUIDelegatePrivate.h:
2925 * WebView/WebView.mm:
2926 (-[WebView _commonInitializationWithFrameName:groupName:]):
2927 Temporarily disable action menus.
2929 (-[WebView _immediateActionController]):
2930 * WebView/WebViewInternal.h:
2932 2014-12-15 Myles C. Maxfield <mmaxfield@apple.com>
2934 Delete Notation because we don't use it
2935 https://bugs.webkit.org/show_bug.cgi?id=139171
2937 Reviewed by Kent Tamura.
2939 * MigrateHeaders.make:
2941 2014-12-14 Andreas Kling <akling@apple.com>
2943 Replace PassRef with Ref/Ref&& across the board.
2944 <https://webkit.org/b/139587>
2946 Reviewed by Darin Adler.
2948 * WebCoreSupport/WebEditorClient.mm:
2949 (WebEditorClient::shouldApplyStyle):
2950 * WebCoreSupport/WebVisitedLinkStore.h:
2951 * WebCoreSupport/WebVisitedLinkStore.mm:
2952 (WebVisitedLinkStore::create):
2954 2014-12-11 Dan Bernstein <mitz@apple.com>
2956 Fix a leak introduced in r177199.
2958 Reviewed by Anders Carlsson.
2960 * WebView/WebImmediateActionController.mm:
2961 (-[WebImmediateActionController _updateImmediateActionItem]):
2963 2014-12-11 Beth Dakin <bdakin@apple.com>
2965 WK1: Need new SPI for Webkit clients to override default immediate action
2966 https://bugs.webkit.org/show_bug.cgi?id=139568
2968 rdar://problem/19225448
2970 Reviewed by Dan Bernstein.
2972 Call SPI giving clients a chance to override the default behavior.
2973 * WebView/WebImmediateActionController.mm:
2974 (-[WebImmediateActionController _updateImmediateActionItem]):
2977 * WebView/WebUIDelegatePrivate.h:
2979 2014-12-11 Timothy Horton <timothy_horton@apple.com>
2981 Move the preview popover to WebImmediateActionController
2982 https://bugs.webkit.org/show_bug.cgi?id=139563
2983 <rdar://problem/19208291>
2985 Reviewed by Beth Dakin.
2987 * WebView/WebActionMenuController.mm:
2988 (-[WebActionMenuController _defaultMenuItemsForLink]):
2989 (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
2990 (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
2991 (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
2992 * WebView/WebImmediateActionController.h:
2993 * WebView/WebImmediateActionController.mm:
2994 (-[WebImmediateActionController webViewClosed]):
2995 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2996 (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2997 (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2998 (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2999 (-[WebImmediateActionController _updateImmediateActionItem]):
3000 (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
3001 (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
3002 (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
3003 Move page preview popover related code to WebImmediateActionController.
3005 * WebView/WebUIDelegatePrivate.h:
3006 Add a link preview type.
3008 * WebView/WebView.mm:
3009 (-[WebView _commonInitializationWithFrameName:groupName:]):
3010 Pass the gesture recognizer to the WebImmediateActionController.
3012 2014-12-11 Timothy Horton <timothy_horton@apple.com>
3016 * WebView/WebImmediateActionController.h:
3017 * WebView/WebImmediateActionController.mm:
3019 2014-12-11 Anders Carlsson <andersca@apple.com>
3021 Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
3022 https://bugs.webkit.org/show_bug.cgi?id=139547
3024 Reviewed by Sam Weinig.
3026 * WebView/WebView.mm:
3027 (+[WebView _handleMemoryWarning]):
3029 2014-12-11 Alexey Proskuryakov <ap@apple.com>
3031 REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
3032 https://bugs.webkit.org/show_bug.cgi?id=139504
3033 rdar://problem/19034674
3035 Reviewed by Enrica Casucci.
3037 Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
3039 * WebCoreSupport/WebEditorClient.h:
3040 * WebCoreSupport/WebEditorClient.mm:
3041 (WebEditorClient::discardedComposition):
3043 2014-12-10 Anders Carlsson <andersca@apple.com>
3045 Get rid of the storage strategy
3046 https://bugs.webkit.org/show_bug.cgi?id=139519
3048 Reviewed by Antti Koivisto.
3050 * WebCoreSupport/WebPlatformStrategies.h:
3051 * WebCoreSupport/WebPlatformStrategies.mm:
3052 (WebPlatformStrategies::createStorageStrategy): Deleted.
3054 2014-12-10 Timothy Horton <timothy_horton@apple.com>
3056 Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
3057 https://bugs.webkit.org/show_bug.cgi?id=139529
3058 <rdar://problem/19213620>
3060 Reviewed by Beth Dakin.
3062 * WebView/WebActionMenuController.mm:
3063 (-[WebActionMenuController _copySelection:]):
3064 (-[WebActionMenuController _paste:]):
3065 Use the copy: and paste: methods on WebView so that we traverse subviews
3066 when trying to respond, otherwise these actions don't work in subframes.
3068 2014-12-10 Beth Dakin <bdakin@apple.com>
3070 WK1: Add initial support for immediate actions
3071 https://bugs.webkit.org/show_bug.cgi?id=139522
3073 Reviewed by Dan Bernstein.
3075 This basic implementation of the controller will use the delegate methods to
3076 perform and cache a HitTest when relevant. Future patches will patch
3077 _updateImmediateActionItem to use the HitTestResult to determine if there is any
3078 immediate action that should be taken.
3079 * WebView/WebImmediateActionController.h: Added.
3080 * WebView/WebImmediateActionController.mm: Added.
3081 (-[WebImmediateActionController webViewClosed]):
3082 (-[WebImmediateActionController _clearImmediateActionState]):
3083 (-[WebImmediateActionController performHitTestAtPoint:]):
3084 (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
3085 (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
3086 (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
3087 (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
3088 (-[WebImmediateActionController _updateImmediateActionItem]):
3090 New enum for immediate action types.
3091 * WebView/WebUIDelegatePrivate.h:
3093 Create an NSImmediateActionGestureRecognizer if possible and a controller.
3094 * WebView/WebView.mm:
3095 (-[WebView _commonInitializationWithFrameName:groupName:]):
3096 (-[WebView _close]):
3097 * WebView/WebViewData.h:
3098 * WebView/WebViewData.mm:
3099 (-[WebViewPrivate dealloc]):
3101 2014-12-08 Anders Carlsson <andersca@apple.com>
3103 Use the new storage namespace provider in WebKit1
3104 https://bugs.webkit.org/show_bug.cgi?id=139425
3106 Reviewed by Tim Horton.
3108 * WebView/WebView.mm:
3109 (-[WebView _commonInitializationWithFrameName:groupName:]):
3110 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3111 Set the storage namespace provider from the web page group.
3113 2014-12-10 Timothy Horton <timothy_horton@apple.com>
3115 Should have copy and paste items in all text menus
3116 https://bugs.webkit.org/show_bug.cgi?id=139510
3117 <rdar://problem/19198388>
3119 Reviewed by Beth Dakin.
3121 * WebView/WebActionMenuController.mm:
3122 (-[WebActionMenuController _defaultMenuItemsForText]):
3123 Add a disabled paste menu item into the read-only text menu.
3125 (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
3126 Add a disabled copy menu item into the editable whitespace text menu.
3128 2014-12-10 Anders Carlsson <andersca@apple.com>
3130 Add WebStorageNamespaceProvider::closeLocalStorage
3131 https://bugs.webkit.org/show_bug.cgi?id=139502
3133 Reviewed by Tim Horton.
3135 * WebView/WebView.mm:
3136 (+[WebView _applicationWillTerminate]):
3137 Call WebStorageNamespaceProvider::closeLocalStorage.
3139 2014-12-09 Commit Queue <commit-queue@webkit.org>
3141 Unreviewed, rolling out r177037.
3142 https://bugs.webkit.org/show_bug.cgi?id=139464
3144 broke ~50 API tests (Requested by thorton on #webkit).
3148 "Use the new storage namespace provider in WebKit1"
3149 https://bugs.webkit.org/show_bug.cgi?id=139425
3150 http://trac.webkit.org/changeset/177037
3152 2014-12-08 Anders Carlsson <andersca@apple.com>
3154 Use the new storage namespace provider in WebKit1
3155 https://bugs.webkit.org/show_bug.cgi?id=139425
3157 Reviewed by Tim Horton.
3159 * WebView/WebView.mm:
3160 (-[WebView _commonInitializationWithFrameName:groupName:]):
3161 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3162 Set the storage namespace provider from the web page group.
3164 2014-12-09 Myles C. Maxfield <mmaxfield@apple.com>
3166 Delete Node::boundingBox()
3167 https://bugs.webkit.org/show_bug.cgi?id=139333
3169 Reviewed by Zalan Bujtas.
3171 * WebView/WebActionMenuController.mm:
3172 (elementBoundingBoxInWindowCoordinatesFromNode): Use
3173 RenderObject::absoluteBoundingBoxRect().
3175 2014-12-08 Alexey Proskuryakov <ap@apple.com>
3177 REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
3178 https://bugs.webkit.org/show_bug.cgi?id=138843
3179 rdar://problem/18793695
3181 Reviewed by Dan Bernstein.
3183 * Panels/WebAuthenticationPanel.m:
3184 (-[WebAuthenticationPanel cancel:]):
3185 (-[WebAuthenticationPanel logIn:]):
3186 Don't close the panel before using panel.sheetParent, because the parent becomes nil.
3187 In fact, we don't need to close it at all, it's enough to call orderOut:, and even
3188 that only when using an old NSWindow API.
3190 2014-12-08 Beth Dakin <bdakin@apple.com>
3192 Copy and Lookup menu items should be disabled when something is not copyable
3193 https://bugs.webkit.org/show_bug.cgi?id=139423
3195 Reviewed by Tim Horton.
3197 Disable both lookup and copy when a HitTestResult does not allow copy.
3198 * WebView/WebActionMenuController.mm:
3200 Set autoenablesItems to NO. It’s messing with our ability to control the enable/
3201 disable state otherwise.
3202 * WebView/WebView.mm:
3203 (-[WebView _commonInitializationWithFrameName:groupName:]):
3205 2014-12-08 Anders Carlsson <andersca@apple.com>
3207 Adding user content to a group should force that group to be created
3208 https://bugs.webkit.org/show_bug.cgi?id=139421
3209 rdar://problem/19180108
3211 Reviewed by Sam Weinig.
3213 * WebCoreSupport/WebViewGroup.h:
3214 Store the local storage database path in the group.
3216 * WebCoreSupport/WebViewGroup.mm:
3217 (WebViewGroup::getOrCreate):
3218 If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
3219 set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
3221 (WebViewGroup::WebViewGroup):
3222 Initialize the new member variable.
3224 (WebViewGroup::storageNamespaceProvider):
3225 Create the namespace provider lazily.
3227 * WebView/WebView.mm:
3228 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
3229 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
3230 Use getOrCreate instead of get.
3232 2014-12-08 Anders Carlsson <andersca@apple.com>
3234 WebStorageNamespaceProvider should know about its local storage database path
3235 https://bugs.webkit.org/show_bug.cgi?id=139413
3237 Reviewed by Andreas Kling.
3239 * WebCoreSupport/WebViewGroup.h:
3240 * WebCoreSupport/WebViewGroup.mm:
3241 (WebViewGroup::getOrCreate):
3242 (WebViewGroup::WebViewGroup):
3243 * WebView/WebView.mm:
3244 (-[WebView _commonInitializationWithFrameName:groupName:]):
3245 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3246 (-[WebView setGroupName:]):
3247 (-[WebView groupName]): Deleted.
3249 2014-12-08 Daniel Bates <dabates@apple.com>
3251 [iOS] Fix the WebKit build with the public SDK
3253 Include header NSURLDownloadSPI.h.
3255 * WebCoreSupport/WebFrameLoaderClient.mm:
3257 2014-12-07 Dan Bernstein <mitz@apple.com>
3259 Introduce and deploy a function that allocates and returns an instance of a soft-linked class
3260 https://bugs.webkit.org/show_bug.cgi?id=139348
3262 Reviewed by Anders Carlsson.
3264 In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
3265 picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
3266 to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
3267 doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
3268 avoiding the ambiguity.
3270 * WebView/WebActionMenuController.mm:
3271 (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3273 2014-12-06 Anders Carlsson <andersca@apple.com>
3275 Add a stubbed out version of WebStorageNamespaceProvider
3276 https://bugs.webkit.org/show_bug.cgi?id=139213
3278 Reviewed by Sam Weinig.
3280 * WebCoreSupport/WebViewGroup.h:
3281 (WebViewGroup::storageNamespaceProvider):
3282 * WebCoreSupport/WebViewGroup.mm:
3283 (WebViewGroup::getOrCreate):
3284 (WebViewGroup::WebViewGroup):
3285 Give WebViewGroup a storage namespace provider.
3287 2014-12-06 Anders Carlsson <andersca@apple.com>
3289 Fix build with newer versions of clang.
3290 rdar://problem/18978687
3292 Add missing overrides and missing casts.
3294 * Storage/WebDatabaseManagerClient.h:
3295 * Storage/WebStorageTrackerClient.h:
3296 * WebCoreSupport/WebChromeClient.h:
3297 * WebCoreSupport/WebFrameLoaderClient.h:
3298 * WebCoreSupport/WebInspectorClient.h:
3299 * WebView/WebDataSource.mm:
3300 (-[WebDataSource _makeRepresentation]):
3301 * WebView/WebFrameView.mm:
3302 (-[WebFrameView _makeDocumentViewForDataSource:]):
3304 2014-12-05 Tim Horton <timothy_horton@apple.com>
3306 Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
3307 https://bugs.webkit.org/show_bug.cgi?id=139306
3308 <rdar://problem/19157955>
3310 Reviewed by Beth Dakin.
3312 * WebView/WebView.mm:
3313 (-[WebView _commonInitializationWithFrameName:groupName:]):
3314 (-[WebView _initWithFrame:frameName:groupName:]):
3315 Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
3317 2014-12-05 David Kilzer <ddkilzer@apple.com>
3319 FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
3320 <http://webkit.org/b/139286>
3322 Reviewed by Daniel Bates.
3324 * Configurations/FeatureDefines.xcconfig: Switch back to using
3325 PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
3327 2014-12-04 Timothy Horton <timothy_horton@apple.com>
3329 Fix the 32-bit build.
3331 * WebView/WebView.mm:
3332 (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3334 2014-12-04 Tim Horton <timothy_horton@apple.com>
3336 TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
3337 https://bugs.webkit.org/show_bug.cgi?id=139252
3338 <rdar://problem/19140827>
3340 Reviewed by Anders Carlsson.
3342 * WebView/WebView.mm:
3343 (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3344 Adjust to the WebCore changes.
3346 2014-12-03 Timothy Horton <timothy_horton@apple.com>
3348 Implement action menus for tel: URLs
3349 https://bugs.webkit.org/show_bug.cgi?id=139240
3350 <rdar://problem/19115662>
3352 Reviewed by Anders Carlsson.
3354 * WebView/WebActionMenuController.mm:
3355 (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3356 Make sure to use the newly created currentActionContext... everywhere.
3358 2014-12-03 Timothy Horton <timothy_horton@apple.com>
3360 Implement action menus for tel: URLs
3361 https://bugs.webkit.org/show_bug.cgi?id=139240
3362 <rdar://problem/19115662>
3364 Reviewed by Anders Carlsson.
3366 * WebView/WebActionMenuController.mm:
3367 (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3368 Make sure to use the newly created currentActionContext.
3370 2014-12-03 Beth Dakin <bdakin@apple.com>
3372 <input> elements get whitespace action menu instead of editable text menu
3373 https://bugs.webkit.org/show_bug.cgi?id=139241
3375 rdar://problem/19072083
3377 Reviewed by Sam Weinig.
3379 We should disallow shadow content in the hit test. This is the default and it is
3380 how context menus behave. We originally wanted to text inside shadow content so
3381 that we could find the text, but the new function I added to HitTestResult will
3383 * WebView/WebActionMenuController.mm:
3384 (-[WebActionMenuController performHitTestAtPoint:]):
3386 Adjust to the fact that we don’t hit test shadow content any more.
3387 (-[WebActionMenuController focusAndSelectHitTestResult]):
3389 Offer the text menus for text inside form controls.
3390 (-[WebActionMenuController _defaultMenuItems]):
3392 2014-12-03 Tim Horton <timothy_horton@apple.com>
3394 Implement action menus for tel: URLs
3395 https://bugs.webkit.org/show_bug.cgi?id=139240
3396 <rdar://problem/19115662>
3398 Reviewed by Anders Carlsson.
3400 * WebView/WebActionMenuController.mm:
3401 (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3402 Rename this function as it will work for both mailto and tel URLs.
3403 Adjust it to use contextForView:.
3405 (-[WebActionMenuController webView:willHandleMouseDown:]):
3406 (-[WebActionMenuController prepareForMenu:withEvent:]):
3407 (-[WebActionMenuController didCloseMenu:withEvent:]):
3408 (-[WebActionMenuController _defaultMenuItems]):
3409 Don't check the menu type when going to interact with _currentActionContext.
3410 We'll only have a _currentActionContext if we have a data detected item,
3411 and there are multiple menu types that end up using DDActionContext.
3413 * WebView/WebUIDelegatePrivate.h:
3416 2014-12-03 Anders Carlsson <andersca@apple.com>
3418 Set a visited link store when creating a simple WebView
3419 https://bugs.webkit.org/show_bug.cgi?id=139234
3420 <rdar://problem/19132978>
3422 Reviewed by Sam Weinig.
3424 * WebView/WebView.mm:
3425 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3427 2014-12-02 Timothy Horton <timothy_horton@apple.com>
3431 * WebCoreSupport/WebFrameLoaderClient.mm:
3433 2014-12-02 Alexey Proskuryakov <ap@apple.com>
3435 http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
3436 https://bugs.webkit.org/show_bug.cgi?id=139149
3438 Reviewed by Anders Carlsson.
3440 This changes API behavior. I think that it's OK, because existing behavior made no sense.
3441 We used to delete caches from disk, but they were still active in memory. Now we also
3442 obsolete them in memory, so documents that use a cache still work, but new ones don't
3445 * WebCoreSupport/WebApplicationCache.mm:
3446 (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
3447 need to delete in-momry caches too. Keep existing behavior.
3448 (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
3449 that properly deletes caches.
3451 2014-12-02 Tim Horton <timothy_horton@apple.com>
3453 Remove a SnowLeopard-era quirk for QuickLook
3454 https://bugs.webkit.org/show_bug.cgi?id=139208
3455 <rdar://problem/19121822>
3457 Reviewed by Alexey Proskuryakov.
3459 * WebCoreSupport/WebFrameLoaderClient.h:
3460 * WebCoreSupport/WebFrameLoaderClient.mm:
3462 2014-12-02 Tim Horton <timothy_horton@apple.com>
3464 Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
3465 https://bugs.webkit.org/show_bug.cgi?id=139204
3467 Reviewed by Anders Carlsson.
3469 * WebView/WebView.mm:
3470 (-[WebView _commonInitializationWithFrameName:groupName:]):
3471 (-[WebView _showDictionaryLookupPopup:]):
3472 * WebView/WebViewData.h:
3473 Work around this by delaying the softlinking (and setting up the notification
3474 observer) until we actually need it. There's still an underlying bug, but
3475 this will fix the test.
3477 2014-12-02 Beth Dakin <bdakin@apple.com>
3479 Yet another build fix.
3481 * WebView/WebActionMenuController.mm:
3482 (-[WebActionMenuController _defaultMenuItemsForLink]):
3484 2014-12-02 Beth Dakin <bdakin@apple.com>
3488 * WebView/WebActionMenuController.mm:
3489 (-[WebActionMenuController _defaultMenuItemsForLink]):
3491 2014-12-02 Beth Dakin <bdakin@apple.com>
3495 * WebView/WebActionMenuController.mm:
3496 (-[WebActionMenuController _defaultMenuItemsForLink]):
3498 2014-12-02 Beth Dakin <bdakin@apple.com>
3500 Should use standardQuickLookMenuItem for apps that don't implement customizations
3501 https://bugs.webkit.org/show_bug.cgi?id=139193
3503 rdar://problem/18944696
3505 Reviewed by Anders Carlsson.
3507 Use [NSMenuItem standardQuickLookMenuItem].
3508 * WebView/WebActionMenuController.mm:
3509 (-[WebActionMenuController _defaultMenuItemsForLink]):
3511 Delegate methods to set up the standardQuickLookMenuItem.
3512 (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
3513 (-[WebActionMenuController menuItem:previewItemAtPoint:]):
3514 (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
3516 Remove all of the old QLPreviewBubble code.
3517 (-[WebActionMenuController _createActionMenuItemForTag:]):
3518 (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
3520 2014-12-02 Timothy Horton <timothy_horton@apple.com>
3524 * WebView/WebViewData.h:
3526 2014-12-02 Tim Horton <timothy_horton@apple.com>
3528 Implement Lookup transition from selection for Legacy WebKit
3529 https://bugs.webkit.org/show_bug.cgi?id=139180
3530 <rdar://problem/19067172>
3532 Reviewed by Beth Dakin.
3534 * WebView/DictionaryPopupInfo.h: Added.
3535 Split DictionaryPopupInfo out into its own file.
3537 * WebView/WebActionMenuController.mm:
3538 (-[WebActionMenuController _lookupText:]):
3539 Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
3541 (performDictionaryLookupForSelection):
3542 (performDictionaryLookupForRange):
3543 Plumb the transition style through these helpers.
3544 Create a TextIndicator from the selection range.
3546 * WebView/WebHTMLView.mm:
3547 (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3548 Make use of TextIndicator (and DictionaryPopupInfo, and the new
3549 _showDictionaryLookupPopup on WebView) to add a transition from blue
3550 when performing Lookup from the context menu.
3552 (-[WebHTMLView quickLookWithEvent:]):
3553 Remove our TextIndicator whenever a normal three-finger-tap event
3554 comes through, as it will have its own indication.
3556 * WebView/WebView.mm:
3557 (-[WebView _commonInitializationWithFrameName:groupName:]):
3558 (-[WebView _dictionaryLookupPopoverWillClose:]):
3559 Register for the LUNotificationPopoverWillClose notification and remove
3560 our TextIndicator when it is called, just like in WebKit2.
3561 Deregistration is already handled in _close.
3563 (-[WebView _showDictionaryLookupPopup:]):
3564 Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
3565 if the relevant API is available.
3567 * WebView/WebViewInternal.h:
3569 2014-12-02 Anders Carlsson <andersca@apple.com>
3571 Remove visited link handling from PageGroup