Add a build flag for ES6 class syntax
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Add a build flag for ES6 class syntax
4         https://bugs.webkit.org/show_bug.cgi?id=140760
5
6         Reviewed by Michael Saboff.
7
8         * Configurations/FeatureDefines.xcconfig:
9
10 2015-01-22  Beth Dakin  <bdakin@apple.com>
11
12         ibtoold crash below -[WebView close]
13         https://bugs.webkit.org/show_bug.cgi?id=140782
14         -and corresponding-
15         rdar://problem/19558472
16
17         Reviewed by Tim Horton.
18
19         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
20         it is because interface builder is messing with our views.
21         * WebView/WebImmediateActionController.h:
22         * WebView/WebImmediateActionController.mm:
23         (-[WebImmediateActionController webViewClosed]):
24         (-[WebImmediateActionController _cancelImmediateAction]):
25         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
26         (-[WebImmediateActionController _updateImmediateActionItem]):
27
28 2015-01-21  Beth Dakin  <bdakin@apple.com>
29
30         Crash in QuickLook preview delegate method
31         https://bugs.webkit.org/show_bug.cgi?id=140740
32         -and corresponding-
33         rdar://problem/19540806
34
35         Reviewed by Tim Horton.
36
37         Clear out the delegate.
38         * WebView/WebImmediateActionController.mm:
39         (-[WebImmediateActionController webViewClosed]):
40
41 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
42
43         Remove ENABLE(INSPECTOR) ifdef guards
44         https://bugs.webkit.org/show_bug.cgi?id=140668
45
46         Reviewed by Darin Adler.
47
48         * Configurations/FeatureDefines.xcconfig:
49         * WebCoreSupport/WebFrameLoaderClient.mm:
50         (WebFrameLoaderClient::dispatchWillSendRequest):
51
52 2015-01-20  Anders Carlsson  <andersca@apple.com>
53
54         Remove USE(GLIB) code from WebKit1
55         https://bugs.webkit.org/show_bug.cgi?id=140714
56
57         Reviewed by Andreas Kling.
58
59         * WebView/WebView.mm:
60         (-[WebView _commonInitializationWithFrameName:groupName:]):
61         (-[WebView _close]):
62         (-[WebView _clearGlibLoopObserver]): Deleted.
63         (glibContextIterationCallback): Deleted.
64         (-[WebView _scheduleGlibContextIterations]): Deleted.
65         * WebView/WebViewData.h:
66         * WebView/WebViewInternal.h:
67
68 2015-01-20  David Kilzer  <ddkilzer@apple.com>
69
70         Switch to comparing PLATFORM_NAME in terms of macosx
71         <http://webkit.org/b/139516>
72
73         Reviewed by Timothy Hatcher.
74
75         * MigrateHeaders.make:
76         * postprocess-headers.sh:
77
78 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
79
80         [SVG -> OTF Converter] Flip the switch on
81         https://bugs.webkit.org/show_bug.cgi?id=140592
82
83         Reviewed by Antti Koivisto.
84
85         * Configurations/FeatureDefines.xcconfig:
86
87 2015-01-19  Beth Dakin  <bdakin@apple.com>
88
89         Speculative build fix.
90
91         * WebView/WebView.mm:
92         (-[WebView _commonInitializationWithFrameName:groupName:]):
93
94 2015-01-19  Beth Dakin  <bdakin@apple.com>
95
96         Speculative build fix.
97
98         * WebView/WebView.mm:
99         (-[WebView _convertRectFromRootView:]):
100
101 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
102
103         Adjust naming of action menu SPI
104         https://bugs.webkit.org/show_bug.cgi?id=140644
105         <rdar://problem/19448129>
106
107         Reviewed by Brian Weinstein.
108
109         * WebView/WebActionMenuController.mm:
110         (-[WebActionMenuController prepareForMenu:withEvent:]):
111         (-[WebActionMenuController willOpenMenu:withEvent:]):
112         (-[WebActionMenuController didCloseMenu:withEvent:]):
113         * WebView/WebView.mm:
114         (-[WebView _commonInitializationWithFrameName:groupName:]):
115         (-[WebView prepareForMenu:withEvent:]):
116         (-[WebView willOpenMenu:withEvent:]):
117         (-[WebView didCloseMenu:withEvent:]):
118
119 2015-01-19  Beth Dakin  <bdakin@apple.com>
120
121         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
122         offset by flipped-ness
123         https://bugs.webkit.org/show_bug.cgi?id=140643
124         -and corresponding-
125         rdar://problem/19489593
126
127         Reviewed by Tim Horton.
128
129         We universally flipped because we assumed that the root view was flipped and the 
130         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
131         fixes that assumption by checking the WebView’s flipped-ness.
132         * WebView/WebView.mm:
133         (-[WebView _convertRectFromRootView:]):
134
135 2015-01-19  Commit Queue  <commit-queue@webkit.org>
136
137         Unreviewed, rolling out r178653.
138         https://bugs.webkit.org/show_bug.cgi?id=140634
139
140         Broke multiple SVG tests on Mountain Lion (Requested by ap on
141         #webkit).
142
143         Reverted changeset:
144
145         "[SVG -> OTF Converter] Flip the switch on"
146         https://bugs.webkit.org/show_bug.cgi?id=140592
147         http://trac.webkit.org/changeset/178653
148
149 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
150
151         [SVG -> OTF Converter] Flip the switch on
152         https://bugs.webkit.org/show_bug.cgi?id=140592
153
154         Reviewed by Antti Koivisto.
155
156         * Configurations/FeatureDefines.xcconfig:
157
158 2015-01-18  Daniel Bates  <dabates@apple.com>
159
160         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
161         (https://bugs.webkit.org/show_bug.cgi?id=129441)
162
163         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
164         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
165
166         * WebInspector/WebNodeHighlightView.mm:
167         (-[WebNodeHighlightView layoutSublayers:]):
168
169 2015-01-16  Beth Dakin  <bdakin@apple.com>
170
171         Make sure early cancellation of immediate action actually does that in WK1
172         https://bugs.webkit.org/show_bug.cgi?id=140566
173         -and corresponding-
174         rdar://problem/19490114
175
176         Reviewed by Tim Horton.
177
178         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
179         asynchronously.
180         * WebView/WebImmediateActionController.mm:
181         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
182
183 2015-01-16  Daniel Bates  <dabates@apple.com>
184
185         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
186         (https://bugs.webkit.org/show_bug.cgi?id=140360)
187
188         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
189
190         * Misc/WebDownload.h:
191
192 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
193
194         Remove ENABLE(SQL_DATABASE) guards
195         https://bugs.webkit.org/show_bug.cgi?id=140434
196
197         Reviewed by Darin Adler.
198
199         * Configurations/FeatureDefines.xcconfig:
200         * Storage/WebDatabaseManager.mm:
201         (databasesDirectoryPath):
202         * Storage/WebDatabaseManagerClient.h:
203         * Storage/WebDatabaseManagerClient.mm:
204         * Storage/WebDatabaseManagerInternal.h:
205         * Storage/WebDatabaseManagerPrivate.h:
206         * Storage/WebDatabaseQuotaManager.mm:
207         (-[WebDatabaseQuotaManager usage]):
208         (-[WebDatabaseQuotaManager quota]):
209         (-[WebDatabaseQuotaManager setQuota:]):
210         * WebCoreSupport/WebChromeClient.h:
211         * WebCoreSupport/WebChromeClient.mm:
212         * WebCoreSupport/WebSecurityOrigin.mm:
213         (-[WebSecurityOrigin usage]):
214         (-[WebSecurityOrigin quota]):
215         (-[WebSecurityOrigin setQuota:]):
216         * WebView/WebFrame.mm:
217         (-[WebFrame _cacheabilityDictionary]):
218         * WebView/WebView.mm:
219         (-[WebView _commonInitializationWithFrameName:groupName:]):
220         (-[WebView _preferencesChanged:]):
221
222 2015-01-14  Chris Dumez  <cdumez@apple.com>
223
224         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
225         https://bugs.webkit.org/show_bug.cgi?id=140347
226
227         Reviewed by Darin Adler.
228
229         Call FontDescription::setIsItalic() instead of setItalic() as the
230         call site passes a boolean.
231
232         * WebView/WebHTMLView.mm:
233         (fontNameForDescription):
234
235 2015-01-13  Anders Carlsson  <andersca@apple.com>
236
237         Temporarily reintroduce the informal delegate protocols
238         https://bugs.webkit.org/show_bug.cgi?id=140416
239
240         Reviewed by Dan Bernstein.
241
242         * WebView/WebEditingDelegate.h:
243         * WebView/WebFrameLoadDelegate.h:
244         * WebView/WebPolicyDelegate.h:
245         * WebView/WebResourceLoadDelegate.h:
246         * WebView/WebUIDelegate.h:
247
248 2015-01-13  Beth Dakin  <bdakin@apple.com>
249
250         Should disable immediate actions for iTunes
251         https://bugs.webkit.org/show_bug.cgi?id=140405
252         -and corresponding-
253         rdar://problem/19461358
254
255         Reviewed by Tim Horton.
256
257         * WebView/WebImmediateActionController.mm:
258         (-[WebImmediateActionController _updateImmediateActionItem]):
259
260 2015-01-11  Sam Weinig  <sam@webkit.org>
261
262         Remove support for SharedWorkers
263         https://bugs.webkit.org/show_bug.cgi?id=140344
264
265         Reviewed by Anders Carlsson.
266
267         * Configurations/FeatureDefines.xcconfig:
268         * WebCoreSupport/WebPlatformStrategies.h:
269         * WebCoreSupport/WebPlatformStrategies.mm:
270         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
271
272 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
273
274         Get rid of unnecessary reimplementations of CGFloor/Ceiling
275         https://bugs.webkit.org/show_bug.cgi?id=140375
276
277         Reviewed by Simon Fraser.
278
279         * Misc/WebKitNSStringExtras.mm:
280         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
281         (webkit_CGCeiling): Deleted.
282         Delete unnecessary code, use the real CGFloor/Ceiling instead.
283
284 2015-01-12  Anders Carlsson  <andersca@apple.com>
285
286         Make delegates conform to formal delegate protocols
287         https://bugs.webkit.org/show_bug.cgi?id=140370
288
289         Reviewed by Dan Bernstein.
290
291         * DefaultDelegates/WebDefaultPolicyDelegate.h:
292         * WebCoreSupport/WebInspectorClient.mm:
293         Add protocols to the interface declarations.
294
295         * WebView/WebActionMenuController.mm:
296         (-[WebActionMenuController prepareForMenu:withEvent:]):
297         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
298         * WebView/WebImmediateActionController.mm:
299         (-[WebImmediateActionController _updateImmediateActionItem]):
300         (-[WebImmediateActionController _menuItemForDataDetectedText]):
301         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
302
303 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
304
305         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
306         https://bugs.webkit.org/show_bug.cgi?id=136769
307
308         Reviewed by Antti Koivisto.
309
310         * Configurations/FeatureDefines.xcconfig:
311
312 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
313
314         Multi-rect TextIndicators are vertically flipped in WebKit1
315         https://bugs.webkit.org/show_bug.cgi?id=140350
316         <rdar://problem/19441243>
317
318         Reviewed by Beth Dakin.
319
320         * WebView/WebView.mm:
321         (-[WebView _setTextIndicator:fadeOut:]):
322         Convert the textBoundingRect from root view to screen coordinates.
323
324 2015-01-12  Anders Carlsson  <andersca@apple.com>
325
326         Make WebResourceDelegate a formal protocol as well
327         https://bugs.webkit.org/show_bug.cgi?id=140364
328
329         Reviewed by Dan Bernstein.
330
331         * WebView/WebResourceLoadDelegate.h:
332
333 2015-01-12  Anders Carlsson  <andersca@apple.com>
334
335         Delegates should be formal protocols
336         https://bugs.webkit.org/show_bug.cgi?id=140360
337         rdar://problem/17380856
338
339         Reviewed by Dan Bernstein.
340
341         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
342
343         * DefaultDelegates/WebDefaultUIDelegate.h:
344         * Misc/WebDownload.h:
345         * WebView/WebEditingDelegate.h:
346         * WebView/WebFrameLoadDelegate.h:
347         * WebView/WebPolicyDelegate.h:
348         * WebView/WebUIDelegate.h:
349
350 2015-01-09  Anders Carlsson  <andersca@apple.com>
351
352         Get rid of the database strategy
353         https://bugs.webkit.org/show_bug.cgi?id=140322
354
355         Reviewed by Sam Weinig.
356
357         * WebCoreSupport/WebPlatformStrategies.h:
358         * WebCoreSupport/WebPlatformStrategies.mm:
359         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
360
361 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
362
363         Can't use DataDetectors after immediate action preparation
364         https://bugs.webkit.org/show_bug.cgi?id=140263
365         <rdar://problem/19412705>
366
367         Reviewed by Beth Dakin.
368
369         * WebView/WebImmediateActionController.mm:
370         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
371         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
372         To match WebKit2, only call shouldUseActions if the animation is actually
373         going to begin, not when preparing for it. This way, we're guaranteed
374         to get a didCancel or didComplete.
375
376 2015-01-08  Dean Jackson  <dino@apple.com>
377
378         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
379         https://bugs.webkit.org/show_bug.cgi?id=140232
380         <rdar://problem/19371010>
381
382         Reviewed by Anders Carlsson.
383
384         Remove the applicationChromeMode setting, but leave stubs in to make
385         sure existing binaries don't break.
386
387         * WebCoreSupport/WebInspectorClient.mm:
388         (-[WebInspectorWindowController init]):
389         * WebView/WebPreferenceKeysPrivate.h:
390         * WebView/WebPreferences.mm:
391         (+[WebPreferences initialize]):
392         (-[WebPreferences applicationChromeModeEnabled]):
393         (-[WebPreferences setApplicationChromeModeEnabled:]):
394         * WebView/WebView.mm:
395         (-[WebView _preferencesChanged:]):
396
397 2015-01-07  Daniel Bates  <dabates@apple.com>
398
399         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
400         https://bugs.webkit.org/show_bug.cgi?id=137371
401
402         Reviewed by David Kilzer.
403
404         Use SPI wrapper headers instead of directly references private SPI headers.
405
406         * Plugins/Hosted/NetscapePluginHostManager.mm:
407
408 2015-01-07  Commit Queue  <commit-queue@webkit.org>
409
410         Unreviewed, rolling out r178068.
411         https://bugs.webkit.org/show_bug.cgi?id=140235
412
413         Breaks the iOS build (Requested by enrica on #webkit).
414
415         Reverted changeset:
416
417         "[iOS] Make WebKit2 build with public iOS SDK and more build
418         fixes for DRT"
419         https://bugs.webkit.org/show_bug.cgi?id=137371
420         http://trac.webkit.org/changeset/178068
421
422 2015-01-07  Daniel Bates  <dabates@apple.com>
423
424         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
425         https://bugs.webkit.org/show_bug.cgi?id=137371
426
427         Reviewed by David Kilzer.
428
429         Use SPI wrapper headers instead of directly references private SPI headers.
430
431         * Plugins/Hosted/NetscapePluginHostManager.mm:
432
433 2015-01-07  Beth Dakin  <bdakin@apple.com>
434
435         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
436         link
437         https://bugs.webkit.org/show_bug.cgi?id=140206
438         -and corresponding-
439         rdar://problem/19300492
440
441         Reviewed by Tim Horton.
442
443         Providing and item frame will ensure that the original link is not obscured.
444         * WebView/WebImmediateActionController.mm:
445         (elementBoundingBoxInWindowCoordinatesFromNode):
446         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
447
448         For now use a max size that is smaller than the WebView, with the screen’s aspect 
449         ratio, and scaled down.
450         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
451
452 2015-01-07  Anders Carlsson  <andersca@apple.com>
453
454         Give simple HTML documents a database provider
455         https://bugs.webkit.org/show_bug.cgi?id=140192
456         rdar://problem/19398825
457
458         Reviewed by Tim Horton.
459
460         * WebView/WebView.mm:
461         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
462
463 2015-01-06  Anders Carlsson  <andersca@apple.com>
464
465         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
466         https://bugs.webkit.org/show_bug.cgi?id=140140
467
468         Reviewed by Andreas Kling.
469
470         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
471         out of WebCore since nobody else is using it.
472
473         * Plugins/WebNetscapePluginView.h:
474         * Plugins/WebNetscapePluginView.mm:
475         (-[WebNetscapePluginView _createPlugin]):
476         (-[WebNetscapePluginView _destroyPlugin]):
477         * Plugins/npapi.mm:
478         (NPN_PluginThreadAsyncCall):
479
480 2015-01-06  Anders Carlsson  <andersca@apple.com>
481
482         Add a WebKit1 database provider
483         https://bugs.webkit.org/show_bug.cgi?id=140126
484
485         Reviewed by Sam Weinig.
486
487         Set the database provider.
488
489         * WebView/WebView.mm:
490         (-[WebView _commonInitializationWithFrameName:groupName:]):
491
492 2015-01-06  Commit Queue  <commit-queue@webkit.org>
493
494         Unreviewed, rolling out r177963.
495         https://bugs.webkit.org/show_bug.cgi?id=140136
496
497         Caused lots of crashes (Requested by smfr on #webkit).
498
499         Reverted changeset:
500
501         "Add a WebKit1 database provider"
502         https://bugs.webkit.org/show_bug.cgi?id=140126
503         http://trac.webkit.org/changeset/177963
504
505 2015-01-06  Anders Carlsson  <andersca@apple.com>
506
507         Add a WebKit1 database provider
508         https://bugs.webkit.org/show_bug.cgi?id=140126
509
510         Reviewed by Sam Weinig.
511
512         Set the database provider.
513
514         * WebView/WebView.mm:
515         (-[WebView _commonInitializationWithFrameName:groupName:]):
516
517 2015-01-01  Jeff Miller  <jeffm@apple.com>
518
519         Update user-visible copyright strings to include 2015
520         https://bugs.webkit.org/show_bug.cgi?id=139880
521
522         Reviewed by Darin Adler.
523
524         * Info.plist:
525
526 2014-12-30  Dan Bernstein  <mitz@apple.com>
527
528         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
529         https://bugs.webkit.org/show_bug.cgi?id=140003
530
531         Reviewed by Darin Adler.
532
533         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
534         that takes their "string" parameter as a "value" "parameter and has an attribute telling
535         the compiler that if the "value" parameter is a format string then the function returns a
536         modified version of it. The result is that if UI_STRING is used as a format string parameter
537         to some function or method, the compiler will check the format specifiers in the string
538         against the other parameters.
539
540 2014-12-29  Dan Bernstein  <mitz@apple.com>
541
542         Fixed the iOS build.
543
544         * Configurations/WebKitLegacy.xcconfig:
545
546 2014-12-29  Anders Carlsson  <andersca@apple.com>
547
548         Get rid of some PageGroup storage functions
549         https://bugs.webkit.org/show_bug.cgi?id=139996
550
551         Reviewed by Sam Weinig.
552
553         Call WebStorageNamespaceProvider directly instead.
554
555         * Storage/WebStorageManager.mm:
556         (-[WebStorageManager syncLocalStorage]):
557         (+[WebStorageManager closeIdleLocalStorageDatabases]):
558         * WebView/WebView.mm:
559         (+[WebView _applicationWillTerminate]):
560
561 2014-12-29  Anders Carlsson  <andersca@apple.com>
562
563         Move storage code from WebCore to WebKit
564         https://bugs.webkit.org/show_bug.cgi?id=139558
565
566         Reviewed by Darin Adler.
567
568         * Storage/WebStorageManager.mm:
569         * Storage/WebStorageTrackerClient.h:
570         * WebView/WebView.mm:
571
572 2014-12-26  Dan Bernstein  <mitz@apple.com>
573
574         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
575         https://bugs.webkit.org/show_bug.cgi?id=139950
576
577         Reviewed by David Kilzer.
578
579         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
580         in a manner that works with Xcode 5.1.1.
581
582 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
583
584         Install a TextIndicator for link immediate actions
585         https://bugs.webkit.org/show_bug.cgi?id=139897
586         <rdar://problem/19333076>
587
588         Reviewed by Anders Carlsson.
589
590         * WebView/WebImmediateActionController.h:
591         * WebView/WebImmediateActionController.mm:
592         (-[WebImmediateActionController _clearImmediateActionState]):
593         Tear down the TextIndicator, just like WebKit2.
594
595         (-[WebImmediateActionController _defaultAnimationController]):
596         Install a TextIndicator for links.
597
598         (-[WebImmediateActionController menuItemDidClose:]):
599         Tear down the TextIndicator when the QL preview closes.
600
601         (-[WebImmediateActionController _menuItemForDataDetectedText]):
602         Directly install and uninstall the TextIndicator for DataDetectors.
603
604         (-[WebImmediateActionController _showTextIndicator]): Deleted.
605         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
606         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
607
608 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
609
610         [iOS] add optimized fullscreen API
611         https://bugs.webkit.org/show_bug.cgi?id=139833
612         <rdar://problem/18844486>
613
614         Reviewed by Simon Fraser.
615
616         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
617
618 2014-12-20  David Kilzer  <ddkilzer@apple.com>
619
620         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
621         <http://webkit.org/b/139463>
622
623         Reviewed by Mark Rowe.
624
625         * Configurations/Base.xcconfig:
626         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
627           on OS X.
628         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
629         * Configurations/DebugRelease.xcconfig:
630         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
631         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
632         * Configurations/Version.xcconfig:
633         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
634         * Configurations/WebKitLegacy.xcconfig:
635         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
636           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
637           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
638           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
639           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
640           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
641           WEBCORE_PRIVATE_HEADERS_DIR_Production and
642           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
643           based on SDK.
644         - Fix PRODUCTION_ROOT to actually be set properly.
645         - Simplify EXPORTED_SYMBOLS_FILE_i386.
646
647         * migrate-headers.sh:
648         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
649         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
650           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
651           WebKitLegacy.xcconfig.
652
653 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
654
655         Fix pink background on CoreAnimation plug-ins in WebKit1
656         https://bugs.webkit.org/show_bug.cgi?id=139845
657         rdar://problem/19313075
658
659         Reviewed by Tim Horton.
660         
661         r154078 left in some debugging code that set a pink background on plug-in hosting
662         layers. Remove it.
663
664         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
665         (-[WebHostedNetscapePluginView createPluginLayer]):
666
667 2014-12-19  Andreas Kling  <akling@apple.com>
668
669         Ref-ify TextIterator API.
670         <https://webkit.org/b/139823>
671
672         Reviewed by Antti Koivisto.
673
674         * WebView/WebTextIterator.mm:
675         (-[WebTextIterator currentRange]):
676
677 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
678
679         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
680         https://bugs.webkit.org/show_bug.cgi?id=139797
681
682         Reviewed by Mark Lam.
683
684         * WebView/WebScriptDebugger.h:
685         * WebView/WebScriptDebugger.mm:
686         (WebScriptDebugger::handlePause):
687         Standardize on passing JSGlobalObject parameter first.
688
689 2014-12-19  Commit Queue  <commit-queue@webkit.org>
690
691         Unreviewed, rolling out r177574.
692         https://bugs.webkit.org/show_bug.cgi?id=139821
693
694         "Broke Production builds by installing
695         libWebCoreTestSupport.dylib in the wrong directory" (Requested
696         by ddkilzer on #webkit).
697
698         Reverted changeset:
699
700         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
701         WebInspectorUI, WebKit, WebKit2"
702         https://bugs.webkit.org/show_bug.cgi?id=139463
703         http://trac.webkit.org/changeset/177574
704
705 2014-12-19  David Kilzer  <ddkilzer@apple.com>
706
707         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
708         <http://webkit.org/b/139463>
709
710         Reviewed by Mark Rowe.
711
712         * Configurations/Base.xcconfig:
713         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
714           on OS X.
715         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
716         * Configurations/DebugRelease.xcconfig:
717         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
718         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
719         * Configurations/Version.xcconfig:
720         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
721         * Configurations/WebKitLegacy.xcconfig:
722         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
723           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
724           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
725           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
726           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
727           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
728           WEBCORE_PRIVATE_HEADERS_DIR_Production and
729           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
730           based on SDK.
731         - Fix PRODUCTION_ROOT to actually be set properly.
732         - Simplify EXPORTED_SYMBOLS_FILE_i386.
733
734         * migrate-headers.sh:
735         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
736         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
737           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
738           WebKitLegacy.xcconfig.
739
740 2014-12-18  Andreas Kling  <akling@apple.com>
741
742         Ref-ify various Document-related things.
743         <https://webkit.org/b/139796>
744
745         Reviewed by Anders Carlsson.
746
747         * WebView/WebFrame.mm:
748         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
749
750 2014-12-18  Beth Dakin  <bdakin@apple.com>
751
752         Need to re-enable action menus
753         https://bugs.webkit.org/show_bug.cgi?id=139795
754         -and corresponding-
755         rdar://problem/19299367
756
757         Reviewed by Tim Horton.
758
759         Re-enable the menus by un-commenting the code to create the menu and controller.
760         * WebView/WebView.mm:
761         (-[WebView _commonInitializationWithFrameName:groupName:]):
762
763 2014-12-16  Sam Weinig  <sam@webkit.org>
764
765         Unify the Mac and iOS implementations of FontPlatformData a bit
766         https://bugs.webkit.org/show_bug.cgi?id=139721
767
768         Reviewed by Anders Carlsson.
769
770         * WebView/WebHTMLView.mm:
771         (fontNameForDescription):
772         Update for new function name.
773
774 2014-12-18  Antti Koivisto  <antti@apple.com>
775
776         Remove alwaysUseBaselineOfPrimaryFont setting
777         https://bugs.webkit.org/show_bug.cgi?id=139770
778
779         Reviewed by Anders Carlsson.
780
781         * WebView/WebPreferenceKeysPrivate.h:
782         * WebView/WebPreferences.mm:
783         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
784         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
785         * WebView/WebPreferencesPrivate.h:
786         * WebView/WebView.mm:
787         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
788         (-[WebView _preferencesChanged:]):
789
790 2014-12-17  Andreas Kling  <akling@apple.com>
791
792         Ref-ify Range::create().
793         <https://webkit.org/b/139755>
794
795         Reviewed by Anders Carlsson.
796
797         * WebView/WebHTMLRepresentation.mm:
798         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
799         * WebView/WebHTMLView.mm:
800         (-[WebHTMLView attributedString]):
801
802 2014-12-17  Anders Carlsson  <andersca@apple.com>
803
804         Unify -[WebResource description]
805         https://bugs.webkit.org/show_bug.cgi?id=139762
806
807         Reviewed by Dan Bernstein.
808
809         * WebView/WebResource.mm:
810         (-[WebResource description]):
811
812 2014-12-17  Anders Carlsson  <andersca@apple.com>
813
814         Get rid of an ugly #define hack in WebFrameLoaderClient
815         https://bugs.webkit.org/show_bug.cgi?id=139761
816
817         Reviewed by Dan Bernstein.
818
819         Also replace @private with @package in all public headers, for consistency.
820
821         * History/WebBackForwardList.h:
822         * History/WebHistory.h:
823         * Misc/WebDownload.h:
824         * WebCoreSupport/WebFrameLoaderClient.mm:
825         * WebView/WebArchive.h:
826         * WebView/WebDataSource.h:
827         * WebView/WebFrame.h:
828         * WebView/WebFrameView.h:
829         * WebView/WebPreferences.h:
830         * WebView/WebResource.h:
831
832 2014-12-17  Dan Bernstein  <mitz@apple.com>
833
834         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
835         https://bugs.webkit.org/show_bug.cgi?id=139760
836
837         Reviewed by Anders Carlsson.
838
839         * Configurations/WebKitLegacy.xcconfig:
840
841 2014-12-17  Andreas Kling  <akling@apple.com>
842
843         Purge PassRefPtr from Frame.
844         <https://webkit.org/b/139731>
845
846         Reviewed by Anders Carlsson.
847
848         * WebCoreSupport/WebFrameLoaderClient.mm:
849         (WebFrameLoaderClient::transitionToCommittedForNewPage):
850         * WebView/WebFrame.mm:
851         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
852         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
853         * WebView/WebFrameInternal.h:
854
855 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
856
857         Implement and adopt two new TextIndicator presentation animations
858         https://bugs.webkit.org/show_bug.cgi?id=139715
859         <rdar://problem/19237945>
860
861         Reviewed by Anders Carlsson.
862
863         * WebView/WebActionMenuController.mm:
864         (-[WebActionMenuController _showTextIndicator]):
865         * WebView/WebHTMLView.mm:
866         (-[WebHTMLView quickLookWithEvent:]):
867         Remove the completionHandler from text indicator presentation.
868
869         * WebView/WebImmediateActionController.mm:
870         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
871         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
872         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
873         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
874         (-[WebImmediateActionController _menuItemForDataDetectedText]):
875         (-[WebImmediateActionController _animationControllerForText]):
876         (-[WebImmediateActionController _showTextIndicator]):
877         Forward immediate action gesture recognizer animation progress
878         to TextIndicator. Force us to keep the selection when immediate
879         action popovers steal first responder status from the WebView.
880         If the Lookup range is equal to the selection range, use a Crossfade
881         animation; otherwise, use a FadeIn animation.
882
883         * WebView/WebView.mm:
884         (-[WebView _setMaintainsInactiveSelection:]):
885         (-[WebView maintainsInactiveSelection]):
886         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
887         (-[WebView _setTextIndicator:fadeOut:]):
888         (-[WebView _clearTextIndicator]):
889         (-[WebView _setTextIndicatorAnimationProgress:]):
890         (-[WebView _showDictionaryLookupPopup:]):
891         (-[WebView _dictionaryLookupPopoverWillClose:]):
892         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
893         Remove the completionHandler from text indicator presentation.
894         Add a _setMaintainsInactiveSelection, which allows WebKit internals
895         to change the return value of -maintainsInactiveSelection, allowing
896         us to keep the selection alive when the WebView loses first responder status.
897
898         * WebView/WebViewData.h:
899         * WebView/WebViewInternal.h:
900
901 2014-12-16  Andreas Kling  <akling@apple.com>
902
903         Use Ref for SecurityOrigin.
904         <https://webkit.org/b/139710>
905
906         Reviewed by Anders Carlsson.
907
908         * Storage/WebStorageTrackerClient.mm:
909         (WebStorageTrackerClient::dispatchDidModifyOrigin):
910         * WebView/WebView.mm:
911         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
912         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
913
914 2014-12-16  Beth Dakin  <bdakin@apple.com>
915
916         Crash getting default animation controller for some text
917         https://bugs.webkit.org/show_bug.cgi?id=139712
918         -and corresponding-
919         rdar://problem/19271707
920
921         Reviewed by Tim Horton.
922
923         Must null-check the range.
924         * WebView/WebImmediateActionController.mm:
925         (-[WebImmediateActionController _animationControllerForText]):
926
927 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
928
929         Immediate action popovers can get stuck open
930         https://bugs.webkit.org/show_bug.cgi?id=139709
931         <rdar://problem/19270279>
932
933         Reviewed by Beth Dakin.
934
935         * WebView/WebImmediateActionController.mm:
936         (-[WebImmediateActionController _clearImmediateActionState]):
937         Don't clear the animation controller; it breaks things and was unnecessary.
938
939 2014-12-16  Tim Horton  <timothy_horton@apple.com>
940
941         Disable TextIndication for Lookup immediate actions
942         https://bugs.webkit.org/show_bug.cgi?id=139684
943
944         Reviewed by Anders Carlsson.
945
946         * WebView/WebView.mm:
947         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
948
949 2014-12-15  Beth Dakin  <bdakin@apple.com>
950
951         Build fix.
952
953         * WebView/WebImmediateActionController.mm:
954
955 2014-12-15  Beth Dakin  <bdakin@apple.com>
956
957         Speculative build fix.
958
959         * WebView/WebView.mm:
960         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
961         * WebView/WebViewInternal.h:
962
963 2014-12-15  Beth Dakin  <bdakin@apple.com>
964
965         Make lookup an immediate action instead of an action menu item
966         https://bugs.webkit.org/show_bug.cgi?id=139661
967         -and corresponding-
968         rdar://problem/19198414
969
970         Reviewed by Tim Horton.
971
972         Remove the lookup menu items and non-unused static function associated with 
973         lookup.
974         * WebView/WebActionMenuController.mm:
975         (-[WebActionMenuController _defaultMenuItemsForText]):
976         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
977         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
978         (-[WebActionMenuController _createActionMenuItemForTag:]):
979         (-[WebActionMenuController _lookupText:]): Deleted.
980         (performDictionaryLookupForSelection): Deleted.
981         (performDictionaryLookupForRange): Deleted.
982
983         Set the defaultAnimationController to the lookup-provided animation controller 
984         when appropriate.
985         * WebView/WebImmediateActionController.mm:
986         (-[WebImmediateActionController _defaultAnimationController]):
987         (dictionaryPopupInfoForRange):
988         (-[WebImmediateActionController _animationControllerForText]):
989
990         New type.
991         * WebView/WebUIDelegatePrivate.h:
992
993         New function to get the lookup animation controller.
994         * WebView/WebView.mm:
995         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
996         * WebView/WebViewInternal.h:
997
998 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
999
1000         Implement Data Detectors immediate actions for Legacy WebKit
1001         https://bugs.webkit.org/show_bug.cgi?id=139619
1002         <rdar://problem/19198539>
1003
1004         Reviewed by Beth Dakin.
1005
1006         * WebView/WebImmediateActionController.mm:
1007         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1008         Note that this action context is only for immediate actions.
1009
1010 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1011
1012         Addressing post-review comments in r177035
1013         https://bugs.webkit.org/show_bug.cgi?id=139557
1014
1015         Reviewed by Darin Adler.
1016
1017         * WebView/WebActionMenuController.mm:
1018         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
1019
1020 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1021
1022         Implement Data Detectors immediate actions for Legacy WebKit
1023         https://bugs.webkit.org/show_bug.cgi?id=139619
1024         <rdar://problem/19198539>
1025
1026         Reviewed by Eric Carlson.
1027
1028         * WebView/WebHTMLView.mm:
1029         (-[WebHTMLView mouseDown:mouseDown:]):
1030         Send mouseDown along to the WebImmediateActionController too.
1031
1032         * WebView/WebImmediateActionController.h:
1033         * WebView/WebImmediateActionController.mm:
1034         (-[WebImmediateActionController webViewClosed]):
1035         (-[WebImmediateActionController webView:willHandleMouseDown:]):
1036         (-[WebImmediateActionController _cancelImmediateAction]):
1037         (-[WebImmediateActionController _clearImmediateActionState]):
1038         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1039         (-[WebImmediateActionController _defaultAnimationController]):
1040         (-[WebImmediateActionController _updateImmediateActionItem]):
1041         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1042         (-[WebImmediateActionController _showTextIndicator]):
1043         (-[WebImmediateActionController _hideTextIndicator]):
1044         Copy most of the DataDetectors implementation into WebImmediateActionController.
1045
1046         * WebView/WebUIDelegatePrivate.h:
1047         Add a new type.
1048
1049         * WebView/WebView.mm:
1050         (-[WebView _commonInitializationWithFrameName:groupName:]):
1051         Temporarily disable action menus.
1052
1053         (-[WebView _immediateActionController]):
1054         * WebView/WebViewInternal.h:
1055
1056 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1057
1058         Delete Notation because we don't use it
1059         https://bugs.webkit.org/show_bug.cgi?id=139171
1060
1061         Reviewed by Kent Tamura.
1062
1063         * MigrateHeaders.make:
1064
1065 2014-12-14  Andreas Kling  <akling@apple.com>
1066
1067         Replace PassRef with Ref/Ref&& across the board.
1068         <https://webkit.org/b/139587>
1069
1070         Reviewed by Darin Adler.
1071
1072         * WebCoreSupport/WebEditorClient.mm:
1073         (WebEditorClient::shouldApplyStyle):
1074         * WebCoreSupport/WebVisitedLinkStore.h:
1075         * WebCoreSupport/WebVisitedLinkStore.mm:
1076         (WebVisitedLinkStore::create):
1077
1078 2014-12-11  Dan Bernstein  <mitz@apple.com>
1079
1080         Fix a leak introduced in r177199.
1081
1082         Reviewed by Anders Carlsson.
1083
1084         * WebView/WebImmediateActionController.mm:
1085         (-[WebImmediateActionController _updateImmediateActionItem]):
1086
1087 2014-12-11  Beth Dakin  <bdakin@apple.com>
1088
1089         WK1: Need new SPI for Webkit clients to override default immediate action
1090         https://bugs.webkit.org/show_bug.cgi?id=139568
1091         -and corresponding-
1092         rdar://problem/19225448
1093
1094         Reviewed by Dan Bernstein.
1095
1096         Call SPI giving clients a chance to override the default behavior.
1097         * WebView/WebImmediateActionController.mm:
1098         (-[WebImmediateActionController _updateImmediateActionItem]):
1099
1100         New SPI.
1101         * WebView/WebUIDelegatePrivate.h:
1102
1103 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1104
1105         Move the preview popover to WebImmediateActionController
1106         https://bugs.webkit.org/show_bug.cgi?id=139563
1107         <rdar://problem/19208291>
1108
1109         Reviewed by Beth Dakin.
1110
1111         * WebView/WebActionMenuController.mm:
1112         (-[WebActionMenuController _defaultMenuItemsForLink]):
1113         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
1114         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
1115         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
1116         * WebView/WebImmediateActionController.h:
1117         * WebView/WebImmediateActionController.mm:
1118         (-[WebImmediateActionController webViewClosed]):
1119         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1120         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1121         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1122         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1123         (-[WebImmediateActionController _updateImmediateActionItem]):
1124         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
1125         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
1126         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
1127         Move page preview popover related code to WebImmediateActionController.
1128
1129         * WebView/WebUIDelegatePrivate.h:
1130         Add a link preview type.
1131
1132         * WebView/WebView.mm:
1133         (-[WebView _commonInitializationWithFrameName:groupName:]):
1134         Pass the gesture recognizer to the WebImmediateActionController.
1135
1136 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1137
1138         Fix the build.
1139
1140         * WebView/WebImmediateActionController.h:
1141         * WebView/WebImmediateActionController.mm:
1142
1143 2014-12-11  Anders Carlsson  <andersca@apple.com>
1144
1145         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
1146         https://bugs.webkit.org/show_bug.cgi?id=139547
1147
1148         Reviewed by Sam Weinig.
1149
1150         * WebView/WebView.mm:
1151         (+[WebView _handleMemoryWarning]):
1152
1153 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
1154
1155         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
1156         https://bugs.webkit.org/show_bug.cgi?id=139504
1157         rdar://problem/19034674
1158
1159         Reviewed by Enrica Casucci.
1160
1161         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
1162
1163         * WebCoreSupport/WebEditorClient.h:
1164         * WebCoreSupport/WebEditorClient.mm:
1165         (WebEditorClient::discardedComposition):
1166
1167 2014-12-10  Anders Carlsson  <andersca@apple.com>
1168
1169         Get rid of the storage strategy
1170         https://bugs.webkit.org/show_bug.cgi?id=139519
1171
1172         Reviewed by Antti Koivisto.
1173
1174         * WebCoreSupport/WebPlatformStrategies.h:
1175         * WebCoreSupport/WebPlatformStrategies.mm:
1176         (WebPlatformStrategies::createStorageStrategy): Deleted.
1177
1178 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1179
1180         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
1181         https://bugs.webkit.org/show_bug.cgi?id=139529
1182         <rdar://problem/19213620>
1183
1184         Reviewed by Beth Dakin.
1185
1186         * WebView/WebActionMenuController.mm:
1187         (-[WebActionMenuController _copySelection:]):
1188         (-[WebActionMenuController _paste:]):
1189         Use the copy: and paste: methods on WebView so that we traverse subviews
1190         when trying to respond, otherwise these actions don't work in subframes.
1191
1192 2014-12-10  Beth Dakin  <bdakin@apple.com>
1193
1194         WK1: Add initial support for immediate actions
1195         https://bugs.webkit.org/show_bug.cgi?id=139522
1196
1197         Reviewed by Dan Bernstein.
1198
1199         This basic implementation of the controller will use the delegate methods to 
1200         perform and cache a HitTest when relevant. Future patches will patch 
1201         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
1202         immediate action that should be taken.
1203         * WebView/WebImmediateActionController.h: Added.
1204         * WebView/WebImmediateActionController.mm: Added.
1205         (-[WebImmediateActionController webViewClosed]):
1206         (-[WebImmediateActionController _clearImmediateActionState]):
1207         (-[WebImmediateActionController performHitTestAtPoint:]):
1208         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1209         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1210         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1211         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1212         (-[WebImmediateActionController _updateImmediateActionItem]):
1213
1214         New enum for immediate action types.
1215         * WebView/WebUIDelegatePrivate.h:
1216
1217         Create an NSImmediateActionGestureRecognizer if possible and a controller.
1218         * WebView/WebView.mm:
1219         (-[WebView _commonInitializationWithFrameName:groupName:]):
1220         (-[WebView _close]):
1221         * WebView/WebViewData.h:
1222         * WebView/WebViewData.mm:
1223         (-[WebViewPrivate dealloc]):
1224
1225 2014-12-08  Anders Carlsson  <andersca@apple.com>
1226
1227         Use the new storage namespace provider in WebKit1
1228         https://bugs.webkit.org/show_bug.cgi?id=139425
1229
1230         Reviewed by Tim Horton.
1231
1232         * WebView/WebView.mm:
1233         (-[WebView _commonInitializationWithFrameName:groupName:]):
1234         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1235         Set the storage namespace provider from the web page group.
1236
1237 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1238
1239         Should have copy and paste items in all text menus
1240         https://bugs.webkit.org/show_bug.cgi?id=139510
1241         <rdar://problem/19198388>
1242
1243         Reviewed by Beth Dakin.
1244
1245         * WebView/WebActionMenuController.mm:
1246         (-[WebActionMenuController _defaultMenuItemsForText]):
1247         Add a disabled paste menu item into the read-only text menu.
1248
1249         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1250         Add a disabled copy menu item into the editable whitespace text menu.
1251
1252 2014-12-10  Anders Carlsson  <andersca@apple.com>
1253
1254         Add WebStorageNamespaceProvider::closeLocalStorage
1255         https://bugs.webkit.org/show_bug.cgi?id=139502
1256
1257         Reviewed by Tim Horton.
1258
1259         * WebView/WebView.mm:
1260         (+[WebView _applicationWillTerminate]):
1261         Call WebStorageNamespaceProvider::closeLocalStorage.
1262
1263 2014-12-09  Commit Queue  <commit-queue@webkit.org>
1264
1265         Unreviewed, rolling out r177037.
1266         https://bugs.webkit.org/show_bug.cgi?id=139464
1267
1268         broke ~50 API tests (Requested by thorton on #webkit).
1269
1270         Reverted changeset:
1271
1272         "Use the new storage namespace provider in WebKit1"
1273         https://bugs.webkit.org/show_bug.cgi?id=139425
1274         http://trac.webkit.org/changeset/177037
1275
1276 2014-12-08  Anders Carlsson  <andersca@apple.com>
1277
1278         Use the new storage namespace provider in WebKit1
1279         https://bugs.webkit.org/show_bug.cgi?id=139425
1280
1281         Reviewed by Tim Horton.
1282
1283         * WebView/WebView.mm:
1284         (-[WebView _commonInitializationWithFrameName:groupName:]):
1285         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1286         Set the storage namespace provider from the web page group.
1287
1288 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
1289
1290         Delete Node::boundingBox()
1291         https://bugs.webkit.org/show_bug.cgi?id=139333
1292
1293         Reviewed by Zalan Bujtas.
1294
1295         * WebView/WebActionMenuController.mm:
1296         (elementBoundingBoxInWindowCoordinatesFromNode): Use
1297         RenderObject::absoluteBoundingBoxRect().
1298
1299 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
1300
1301         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
1302         https://bugs.webkit.org/show_bug.cgi?id=138843
1303         rdar://problem/18793695
1304
1305         Reviewed by Dan Bernstein.
1306
1307         * Panels/WebAuthenticationPanel.m:
1308         (-[WebAuthenticationPanel cancel:]):
1309         (-[WebAuthenticationPanel logIn:]):
1310         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
1311         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
1312         that only when using an old NSWindow API.
1313
1314 2014-12-08  Beth Dakin  <bdakin@apple.com>
1315
1316         Copy and Lookup menu items should be disabled when something is not copyable
1317         https://bugs.webkit.org/show_bug.cgi?id=139423
1318
1319         Reviewed by Tim Horton.
1320
1321         Disable both lookup and copy when a HitTestResult does not allow copy.
1322         * WebView/WebActionMenuController.mm:
1323
1324         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
1325         disable state otherwise.
1326         * WebView/WebView.mm:
1327         (-[WebView _commonInitializationWithFrameName:groupName:]):
1328
1329 2014-12-08  Anders Carlsson  <andersca@apple.com>
1330
1331         Adding user content to a group should force that group to be created
1332         https://bugs.webkit.org/show_bug.cgi?id=139421
1333         rdar://problem/19180108
1334
1335         Reviewed by Sam Weinig.
1336
1337         * WebCoreSupport/WebViewGroup.h:
1338         Store the local storage database path in the group.
1339
1340         * WebCoreSupport/WebViewGroup.mm:
1341         (WebViewGroup::getOrCreate):
1342         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
1343         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
1344
1345         (WebViewGroup::WebViewGroup):
1346         Initialize the new member variable.
1347
1348         (WebViewGroup::storageNamespaceProvider):
1349         Create the namespace provider lazily.
1350
1351         * WebView/WebView.mm:
1352         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1353         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1354         Use getOrCreate instead of get.
1355
1356 2014-12-08  Anders Carlsson  <andersca@apple.com>
1357
1358         WebStorageNamespaceProvider should know about its local storage database path
1359         https://bugs.webkit.org/show_bug.cgi?id=139413
1360
1361         Reviewed by Andreas Kling.
1362
1363         * WebCoreSupport/WebViewGroup.h:
1364         * WebCoreSupport/WebViewGroup.mm:
1365         (WebViewGroup::getOrCreate):
1366         (WebViewGroup::WebViewGroup):
1367         * WebView/WebView.mm:
1368         (-[WebView _commonInitializationWithFrameName:groupName:]):
1369         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1370         (-[WebView setGroupName:]):
1371         (-[WebView groupName]): Deleted.
1372
1373 2014-12-08  Daniel Bates  <dabates@apple.com>
1374
1375         [iOS] Fix the WebKit build with the public SDK
1376
1377         Include header NSURLDownloadSPI.h.
1378
1379         * WebCoreSupport/WebFrameLoaderClient.mm:
1380
1381 2014-12-07  Dan Bernstein  <mitz@apple.com>
1382
1383         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
1384         https://bugs.webkit.org/show_bug.cgi?id=139348
1385
1386         Reviewed by Anders Carlsson.
1387
1388         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
1389         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
1390         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
1391         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
1392         avoiding the ambiguity.
1393
1394         * WebView/WebActionMenuController.mm:
1395         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1396
1397 2014-12-06  Anders Carlsson  <andersca@apple.com>
1398
1399         Add a stubbed out version of WebStorageNamespaceProvider
1400         https://bugs.webkit.org/show_bug.cgi?id=139213
1401
1402         Reviewed by Sam Weinig.
1403
1404         * WebCoreSupport/WebViewGroup.h:
1405         (WebViewGroup::storageNamespaceProvider):
1406         * WebCoreSupport/WebViewGroup.mm:
1407         (WebViewGroup::getOrCreate):
1408         (WebViewGroup::WebViewGroup):
1409         Give WebViewGroup a storage namespace provider.
1410
1411 2014-12-06  Anders Carlsson  <andersca@apple.com>
1412
1413         Fix build with newer versions of clang.
1414         rdar://problem/18978687
1415
1416         Add missing overrides and missing casts.
1417
1418         * Storage/WebDatabaseManagerClient.h:
1419         * Storage/WebStorageTrackerClient.h:
1420         * WebCoreSupport/WebChromeClient.h:
1421         * WebCoreSupport/WebFrameLoaderClient.h:
1422         * WebCoreSupport/WebInspectorClient.h:
1423         * WebView/WebDataSource.mm:
1424         (-[WebDataSource _makeRepresentation]):
1425         * WebView/WebFrameView.mm:
1426         (-[WebFrameView _makeDocumentViewForDataSource:]):
1427
1428 2014-12-05  Tim Horton  <timothy_horton@apple.com>
1429
1430         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
1431         https://bugs.webkit.org/show_bug.cgi?id=139306
1432         <rdar://problem/19157955>
1433
1434         Reviewed by Beth Dakin.
1435
1436         * WebView/WebView.mm:
1437         (-[WebView _commonInitializationWithFrameName:groupName:]):
1438         (-[WebView _initWithFrame:frameName:groupName:]):
1439         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
1440
1441 2014-12-05  David Kilzer  <ddkilzer@apple.com>
1442
1443         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
1444         <http://webkit.org/b/139286>
1445
1446         Reviewed by Daniel Bates.
1447
1448         * Configurations/FeatureDefines.xcconfig: Switch back to using
1449         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
1450
1451 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
1452
1453         Fix the 32-bit build.
1454
1455         * WebView/WebView.mm:
1456         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1457
1458 2014-12-04  Tim Horton  <timothy_horton@apple.com>
1459
1460         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
1461         https://bugs.webkit.org/show_bug.cgi?id=139252
1462         <rdar://problem/19140827>
1463
1464         Reviewed by Anders Carlsson.
1465
1466         * WebView/WebView.mm:
1467         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1468         Adjust to the WebCore changes.
1469
1470 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1471
1472         Implement action menus for tel: URLs
1473         https://bugs.webkit.org/show_bug.cgi?id=139240
1474         <rdar://problem/19115662>
1475
1476         Reviewed by Anders Carlsson.
1477
1478         * WebView/WebActionMenuController.mm:
1479         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1480         Make sure to use the newly created currentActionContext... everywhere.
1481
1482 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1483
1484         Implement action menus for tel: URLs
1485         https://bugs.webkit.org/show_bug.cgi?id=139240
1486         <rdar://problem/19115662>
1487
1488         Reviewed by Anders Carlsson.
1489
1490         * WebView/WebActionMenuController.mm:
1491         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1492         Make sure to use the newly created currentActionContext.
1493
1494 2014-12-03  Beth Dakin  <bdakin@apple.com>
1495
1496         <input> elements get whitespace action menu instead of editable text menu
1497         https://bugs.webkit.org/show_bug.cgi?id=139241
1498         -and corresponding-
1499         rdar://problem/19072083
1500
1501         Reviewed by Sam Weinig.
1502
1503         We should disallow shadow content in the hit test. This is the default and it is 
1504         how context menus behave. We originally wanted to text inside shadow content so 
1505         that we could find the text, but the new function I added to HitTestResult will 
1506         allow that.
1507         * WebView/WebActionMenuController.mm:
1508         (-[WebActionMenuController performHitTestAtPoint:]):
1509
1510         Adjust to the fact that we don’t hit test shadow content any more.
1511         (-[WebActionMenuController focusAndSelectHitTestResult]):
1512
1513         Offer the text menus for text inside form controls.
1514         (-[WebActionMenuController _defaultMenuItems]):
1515
1516 2014-12-03  Tim Horton  <timothy_horton@apple.com>
1517
1518         Implement action menus for tel: URLs
1519         https://bugs.webkit.org/show_bug.cgi?id=139240
1520         <rdar://problem/19115662>
1521
1522         Reviewed by Anders Carlsson.
1523
1524         * WebView/WebActionMenuController.mm:
1525         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1526         Rename this function as it will work for both mailto and tel URLs.
1527         Adjust it to use contextForView:.
1528
1529         (-[WebActionMenuController webView:willHandleMouseDown:]):
1530         (-[WebActionMenuController prepareForMenu:withEvent:]):
1531         (-[WebActionMenuController didCloseMenu:withEvent:]):
1532         (-[WebActionMenuController _defaultMenuItems]):
1533         Don't check the menu type when going to interact with _currentActionContext.
1534         We'll only have a _currentActionContext if we have a data detected item,
1535         and there are multiple menu types that end up using DDActionContext.
1536
1537         * WebView/WebUIDelegatePrivate.h:
1538         Add a new type.
1539
1540 2014-12-03  Anders Carlsson  <andersca@apple.com>
1541
1542         Set a visited link store when creating a simple WebView
1543         https://bugs.webkit.org/show_bug.cgi?id=139234
1544         <rdar://problem/19132978>
1545
1546         Reviewed by Sam Weinig.
1547
1548         * WebView/WebView.mm:
1549         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1550
1551 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1552
1553         Fix the build.
1554
1555         * WebCoreSupport/WebFrameLoaderClient.mm:
1556
1557 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1558
1559         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1560         https://bugs.webkit.org/show_bug.cgi?id=139149
1561
1562         Reviewed by Anders Carlsson.
1563
1564         This changes API behavior. I think that it's OK, because existing behavior made no sense.
1565         We used to delete caches from disk, but they were still active in memory. Now we also
1566         obsolete them in memory, so documents that use a cache still work, but new ones don't
1567         pick one up.
1568
1569         * WebCoreSupport/WebApplicationCache.mm:
1570         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
1571         need to delete in-momry caches too. Keep existing behavior.
1572         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
1573         that properly deletes caches.
1574
1575 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1576
1577         Remove a SnowLeopard-era quirk for QuickLook
1578         https://bugs.webkit.org/show_bug.cgi?id=139208
1579         <rdar://problem/19121822>
1580
1581         Reviewed by Alexey Proskuryakov.
1582
1583         * WebCoreSupport/WebFrameLoaderClient.h:
1584         * WebCoreSupport/WebFrameLoaderClient.mm:
1585
1586 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1587
1588         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
1589         https://bugs.webkit.org/show_bug.cgi?id=139204
1590
1591         Reviewed by Anders Carlsson.
1592
1593         * WebView/WebView.mm:
1594         (-[WebView _commonInitializationWithFrameName:groupName:]):
1595         (-[WebView _showDictionaryLookupPopup:]):
1596         * WebView/WebViewData.h:
1597         Work around this by delaying the softlinking (and setting up the notification
1598         observer) until we actually need it. There's still an underlying bug, but
1599         this will fix the test.
1600
1601 2014-12-02  Beth Dakin  <bdakin@apple.com>
1602
1603         Yet another build fix.
1604
1605         * WebView/WebActionMenuController.mm:
1606         (-[WebActionMenuController _defaultMenuItemsForLink]):
1607
1608 2014-12-02  Beth Dakin  <bdakin@apple.com>
1609
1610         Build fix.
1611
1612         * WebView/WebActionMenuController.mm:
1613         (-[WebActionMenuController _defaultMenuItemsForLink]):
1614
1615 2014-12-02  Beth Dakin  <bdakin@apple.com>
1616
1617         More build fixing.
1618
1619         * WebView/WebActionMenuController.mm:
1620         (-[WebActionMenuController _defaultMenuItemsForLink]):
1621
1622 2014-12-02  Beth Dakin  <bdakin@apple.com>
1623
1624         Should use standardQuickLookMenuItem for apps that don't implement customizations
1625         https://bugs.webkit.org/show_bug.cgi?id=139193
1626         -and corresponding-
1627         rdar://problem/18944696
1628
1629         Reviewed by Anders Carlsson.
1630
1631         Use [NSMenuItem standardQuickLookMenuItem].
1632         * WebView/WebActionMenuController.mm:
1633         (-[WebActionMenuController _defaultMenuItemsForLink]):
1634
1635         Delegate methods to set up the standardQuickLookMenuItem.
1636         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
1637         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
1638         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
1639
1640         Remove all of the old QLPreviewBubble code.
1641         (-[WebActionMenuController _createActionMenuItemForTag:]):
1642         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
1643
1644 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1645
1646         Fix the build.
1647
1648         * WebView/WebViewData.h:
1649
1650 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1651
1652         Implement Lookup transition from selection for Legacy WebKit
1653         https://bugs.webkit.org/show_bug.cgi?id=139180
1654         <rdar://problem/19067172>
1655
1656         Reviewed by Beth Dakin.
1657
1658         * WebView/DictionaryPopupInfo.h: Added.
1659         Split DictionaryPopupInfo out into its own file.
1660
1661         * WebView/WebActionMenuController.mm:
1662         (-[WebActionMenuController _lookupText:]):
1663         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
1664
1665         (performDictionaryLookupForSelection):
1666         (performDictionaryLookupForRange):
1667         Plumb the transition style through these helpers.
1668         Create a TextIndicator from the selection range.
1669
1670         * WebView/WebHTMLView.mm:
1671         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1672         Make use of TextIndicator (and DictionaryPopupInfo, and the new
1673         _showDictionaryLookupPopup on WebView) to add a transition from blue
1674         when performing Lookup from the context menu.
1675
1676         (-[WebHTMLView quickLookWithEvent:]):
1677         Remove our TextIndicator whenever a normal three-finger-tap event
1678         comes through, as it will have its own indication.
1679
1680         * WebView/WebView.mm:
1681         (-[WebView _commonInitializationWithFrameName:groupName:]):
1682         (-[WebView _dictionaryLookupPopoverWillClose:]):
1683         Register for the LUNotificationPopoverWillClose notification and remove
1684         our TextIndicator when it is called, just like in WebKit2.
1685         Deregistration is already handled in _close.
1686
1687         (-[WebView _showDictionaryLookupPopup:]):
1688         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
1689         if the relevant API is available.
1690
1691         * WebView/WebViewInternal.h:
1692
1693 2014-12-02  Anders Carlsson  <andersca@apple.com>
1694
1695         Remove visited link handling from PageGroup
1696         https://bugs.webkit.org/show_bug.cgi?id=139185
1697
1698         Reviewed by Sam Weinig.
1699
1700         * History/WebHistory.mm:
1701         (-[WebHistoryPrivate removeItemForURLString:]):
1702         (-[WebHistoryPrivate removeAllItems]):
1703         (+[WebHistory setOptionalSharedHistory:]):
1704         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1705         (+[WebHistory _removeAllVisitedLinks]):
1706         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
1707         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
1708         * History/WebHistoryInternal.h:
1709         * WebCoreSupport/WebChromeClient.h:
1710         * WebCoreSupport/WebChromeClient.mm:
1711         (WebChromeClient::populateVisitedLinks): Deleted.
1712         * WebView/WebView.mm:
1713         (-[WebView addVisitedLinks:]):
1714         (-[WebView removeVisitedLink:]):
1715
1716 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1717
1718         Try to fix the Mac build.
1719
1720         * WebView/WebView.mm:
1721         (-[WebView _commonInitializationWithFrameName:groupName:]):
1722         (-[WebView _close]):
1723
1724 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1725
1726         Fix the iOS build.
1727
1728         * WebView/WebActionMenuController.h:
1729         * WebView/WebActionMenuController.mm:
1730         * WebView/WebHTMLView.mm:
1731         (-[WebHTMLView scrollWheel:scrollWheel:]):
1732         (-[WebHTMLView mouseDown:mouseDown:]):
1733         * WebView/WebView.mm:
1734         * WebView/WebViewData.h:
1735         * WebView/WebViewData.mm:
1736         (-[WebViewPrivate dealloc]):
1737         * WebView/WebViewInternal.h:
1738
1739 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1740
1741         Implement yellow highlight for WebKit1 data detectors
1742         https://bugs.webkit.org/show_bug.cgi?id=138956
1743         <rdar://problem/18992185>
1744
1745         Reviewed by Beth Dakin.
1746
1747         * WebView/WebActionMenuController.h:
1748         * WebView/WebActionMenuController.mm:
1749         (-[WebActionMenuController webView:willHandleMouseDown:]):
1750         (-[WebActionMenuController webView:didHandleScrollWheel:]):
1751         (-[WebActionMenuController prepareForMenu:withEvent:]):
1752         (-[WebActionMenuController didCloseMenu:withEvent:]):
1753         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1754         (-[WebActionMenuController _showTextIndicator]):
1755         (-[WebActionMenuController _hideTextIndicator]):
1756         (-[WebActionMenuController _dismissActionMenuPopovers]):
1757         Copy the WebKit2 WKActionMenuController TextIndicator implementation
1758         into WebActionMenuController. The only significant difference is
1759         that we build the TextIndicator right at menu construction time
1760         instead of in the Web process.
1761
1762         * WebView/WebHTMLView.mm:
1763         (-[WebHTMLView scrollWheel:]):
1764         Let the WebActionMenuController know that we're handling a scroll.
1765
1766         (-[WebHTMLView mouseDown:]):
1767         Let the WebActionMenuController know that we're handling a mouseDown.
1768
1769         * WebView/WebView.mm:
1770         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1771         (-[WebView _clearTextIndicator]):
1772         (-[WebView _actionMenuController]):
1773         (-[WebView _convertRectFromRootView:]): Deleted.
1774         * WebView/WebViewData.h:
1775         * WebView/WebViewData.mm:
1776         * WebView/WebViewInternal.h:
1777         Keep a TextIndicatorWindow on WebView, just like WKView does.
1778         Expose the WebActionMenuController on WebView (internally).
1779
1780 2014-12-01  Anders Carlsson  <andersca@apple.com>
1781
1782         Remove old site specific quirks code that was added in 2009
1783         https://bugs.webkit.org/show_bug.cgi?id=139141
1784
1785         Reviewed by Antti Koivisto.
1786
1787         * WebCoreSupport/WebFrameNetworkingContext.h:
1788         * WebCoreSupport/WebFrameNetworkingContext.mm:
1789         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
1790
1791 2014-11-30  Anders Carlsson  <andersca@apple.com>
1792
1793         Fix a test failure.
1794
1795         * History/WebHistory.mm:
1796         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1797         Call through to the visited link store.
1798
1799         (+[WebHistory _removeAllVisitedLinks]):
1800         Ditto.
1801
1802         * WebCoreSupport/WebVisitedLinkStore.mm:
1803         (WebVisitedLinkStore::isLinkVisited):
1804         Make sure to populate visited links.
1805
1806 2014-11-30  Anders Carlsson  <andersca@apple.com>
1807
1808         Switch over to the visited link store from the WebViewGroup
1809         https://bugs.webkit.org/show_bug.cgi?id=139112
1810
1811         Reviewed by Sam Weinig.
1812
1813         * WebView/WebView.mm:
1814         (-[WebView _commonInitializationWithFrameName:groupName:]):
1815         (-[WebView setGroupName:]):
1816
1817 2014-11-30  Anders Carlsson  <andersca@apple.com>
1818
1819         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
1820         https://bugs.webkit.org/show_bug.cgi?id=139111
1821
1822         Reviewed by Sam Weinig.
1823
1824         * WebCoreSupport/WebVisitedLinkStore.h:
1825         * WebCoreSupport/WebVisitedLinkStore.mm:
1826         (WebVisitedLinkStore::removeVisitedLink):
1827         * WebView/WebView.mm:
1828         (-[WebView removeVisitedLink:]):
1829
1830 2014-11-29  Anders Carlsson  <andersca@apple.com>
1831
1832         Populate visited links
1833         https://bugs.webkit.org/show_bug.cgi?id=139101
1834
1835         Reviewed by Sam Weinig.
1836
1837         * History/WebHistory.mm:
1838         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
1839         Helper function that adds all visited link to the given store.
1840
1841         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
1842         Call the private method.
1843
1844         * History/WebHistoryInternal.h:
1845         * WebCoreSupport/WebVisitedLinkStore.h:
1846         Add new members.
1847
1848         * WebCoreSupport/WebVisitedLinkStore.mm:
1849         (WebVisitedLinkStore::addVisitedLink):
1850         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
1851
1852         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1853         Implement this. First try the delegate, then try the shared history.
1854
1855         (WebVisitedLinkStore::addVisitedLinkHash):
1856         Factor code that adds the link to the hash table into a separate function.
1857
1858         * WebView/WebView.mm:
1859         (-[WebView addVisitedLinks:]):
1860         Add the visited links to the store.
1861
1862 2014-11-29  Anders Carlsson  <andersca@apple.com>
1863
1864         More work on the legacy WebKit visited link store
1865         https://bugs.webkit.org/show_bug.cgi?id=139100
1866
1867         Reviewed by Sam Weinig.
1868
1869         * History/WebHistory.mm:
1870         (+[WebHistory setOptionalSharedHistory:]):
1871         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
1872
1873         * WebCoreSupport/WebVisitedLinkStore.h:
1874         * WebCoreSupport/WebVisitedLinkStore.mm:
1875         (visitedLinkStores):
1876         (WebVisitedLinkStore::WebVisitedLinkStore):
1877         (WebVisitedLinkStore::~WebVisitedLinkStore):
1878         Keep track of live visited link stores.
1879
1880         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
1881         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
1882
1883         (WebVisitedLinkStore::removeAllVisitedLinks):
1884         Iterate over all live link stores and remove their links.
1885
1886         (WebVisitedLinkStore::isLinkVisited):
1887         Populate visited links and check if our hash table contains the link.
1888
1889         (WebVisitedLinkStore::addVisitedLink):
1890         Add the link hash to the table.
1891
1892         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1893         Add stub.
1894
1895         (WebVisitedLinkStore::removeVisitedLinkHashes):
1896         Clear out the hash table.
1897
1898 2014-11-27  Anders Carlsson  <andersca@apple.com>
1899
1900         Add a stubbed out WebVisitedLinkStore to WebViewGroup
1901         https://bugs.webkit.org/show_bug.cgi?id=139066
1902
1903         Reviewed by Antti Koivisto.
1904
1905         * WebCoreSupport/WebViewGroup.h:
1906         (WebViewGroup::visitedLinkStore):
1907         * WebCoreSupport/WebViewGroup.mm:
1908         (WebViewGroup::WebViewGroup):
1909         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1910         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1911         (WebVisitedLinkStore::create):
1912         (WebVisitedLinkStore::WebVisitedLinkStore):
1913         (WebVisitedLinkStore::~WebVisitedLinkStore):
1914         (WebVisitedLinkStore::isLinkVisited):
1915         (WebVisitedLinkStore::addVisitedLink):
1916
1917 2014-11-25  Anders Carlsson  <andersca@apple.com>
1918
1919         Remove user content handling from PageGroup
1920         https://bugs.webkit.org/show_bug.cgi?id=139051
1921
1922         Reviewed by Antti Koivisto.
1923
1924         Use the user content controller in the web view group.
1925
1926         * WebView/WebView.mm:
1927         (-[WebView _injectOutlookQuirksScript]):
1928
1929 2014-11-25  Anders Carlsson  <andersca@apple.com>
1930
1931         Add a user content controller to WebViewGroup and use it for user content
1932         https://bugs.webkit.org/show_bug.cgi?id=139043
1933
1934         Reviewed by Antti Koivisto.
1935
1936         This is another tiny step towards getting rid of user content handling inside PageGroup.
1937
1938         * WebCoreSupport/WebViewGroup.h:
1939         (WebViewGroup::userContentController):
1940         Add a UserContentController member and getter.
1941
1942         * WebCoreSupport/WebViewGroup.mm:
1943         (WebViewGroup::get):
1944         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
1945
1946         (WebViewGroup::WebViewGroup):
1947         Create a user content controller.
1948
1949         * WebView/WebView.mm:
1950         (-[WebView _commonInitializationWithFrameName:groupName:]):
1951         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
1952         set its user content controller in the PageConfiguration.
1953
1954         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1955         Ditto.
1956
1957         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1958         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1959         (+[WebView _removeUserScriptFromGroup:world:url:]):
1960         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
1961         (+[WebView _removeUserScriptsFromGroup:world:]):
1962         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
1963         (+[WebView _removeAllUserContentFromGroup:]):
1964         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
1965
1966         (-[WebView setGroupName:]):
1967         Set the user content controller to the new WebViewGroup's user content controller.
1968
1969 2014-11-21  Jer Noble  <jer.noble@apple.com>
1970
1971         Support multiple signatures of diagnostic logging.
1972         https://bugs.webkit.org/show_bug.cgi?id=138690
1973
1974         Reviewed by Anders Carlsson.
1975
1976         Page::PageClients has been renamed PageConfiguration.
1977
1978         * WebView/WebView.mm:
1979         (-[WebView _commonInitializationWithFrameName:groupName:]):
1980         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1981
1982 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1983
1984         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1985         https://bugs.webkit.org/show_bug.cgi?id=138981
1986
1987         Reviewed by Simon Fraser.
1988
1989         * WebView/WebPreferenceKeysPrivate.h:
1990         * WebView/WebPreferences.mm:
1991         (+[WebPreferences initialize]):
1992         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
1993         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
1994         * WebView/WebPreferencesPrivate.h:
1995         * WebView/WebView.mm:
1996         (-[WebView _preferencesChanged:]):
1997
1998 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1999
2000         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2001         ​https://bugs.webkit.org/show_bug.cgi?id=138960
2002         <rdar://problem/19056715>
2003
2004         Reviewed by Anders Carlsson.
2005
2006         * WebView/WebActionMenuController.mm:
2007         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2008         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2009         Use DataDetectors SPI instead of an explicit blacklist.
2010
2011 2014-11-21  Tim Horton  <timothy_horton@apple.com>
2012
2013         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2014         https://bugs.webkit.org/show_bug.cgi?id=138960
2015         <rdar://problem/19056715>
2016
2017         Reviewed by Beth Dakin.
2018
2019         * WebView/WebActionMenuController.mm:
2020         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2021         Blacklist contact results, because they don't have useful menus. If we
2022         bail before setting up _currentActionContext, we'll still allow fallthrough
2023         to ordinary text actions, avoiding mysterious failure when a contact is detected.
2024
2025         This doesn't break the case that r176351 was intended to fix,
2026         because in that case we were detecting e.g. addresses.
2027
2028 2014-11-21  Anders Carlsson  <andersca@apple.com>
2029
2030         Remove the Timer parameters from timer callbacks
2031         https://bugs.webkit.org/show_bug.cgi?id=138974
2032
2033         Reviewed by Antti Koivisto.
2034
2035         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2036         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2037         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
2038         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2039         * Plugins/WebNetscapePluginStream.h:
2040         * Plugins/WebNetscapePluginStream.mm:
2041         (WebNetscapePluginStream::WebNetscapePluginStream):
2042         (WebNetscapePluginStream::deliverDataTimerFired):
2043
2044 2014-11-21  Anders Carlsson  <andersca@apple.com>
2045
2046         Make memoryCache() return a reference
2047         https://bugs.webkit.org/show_bug.cgi?id=138939
2048
2049         Reviewed by Antti Koivisto.
2050
2051         * Misc/WebCache.mm:
2052         (+[WebCache statistics]):
2053         (+[WebCache emptyInMemoryResources]):
2054         (+[WebCache sizeOfDeadResources:]):
2055         (+[WebCache addImageToCache:forURL:forFrame:]):
2056         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2057         (+[WebCache imageForURL:]):
2058         (+[WebCache setDisabled:]):
2059         (+[WebCache isDisabled]):
2060         * WebView/WebView.mm:
2061         (+[WebView _setCacheModel:]):
2062
2063 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
2064
2065         Remove the remaining vestiges of minimal-ui
2066         https://bugs.webkit.org/show_bug.cgi?id=138890
2067
2068         Reviewed by Sam Weinig.
2069
2070         * History/WebHistoryItem.mm:
2071         * History/WebHistoryItemPrivate.h:
2072
2073 2014-11-20  Tim Horton  <timothy_horton@apple.com>
2074
2075         Cancel DataDetectors menu earlier if we know it can't be presented
2076         https://bugs.webkit.org/show_bug.cgi?id=138922
2077         <rdar://problem/18950441>
2078
2079         Reviewed by Beth Dakin.
2080
2081         * WebView/WebActionMenuController.mm:
2082         (-[WebActionMenuController prepareForMenu:withEvent:]):
2083         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
2084         and use a bigger hammer (removeAllItems).
2085
2086         (-[WebActionMenuController willOpenMenu:withEvent:]):
2087         If we end up with a menu with no items, don't change selection or anything.
2088
2089 2014-11-20  Beth Dakin  <bdakin@apple.com>
2090
2091         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
2092         https://bugs.webkit.org/show_bug.cgi?id=138568
2093         -and corresponding-
2094         rdar://problem/18904600
2095
2096         Reviewed by Tim Horton.
2097
2098         Skip images for lookup.
2099         * WebView/WebActionMenuController.mm:
2100         (performDictionaryLookupForRange):
2101
2102 2014-11-19  Beth Dakin  <bdakin@apple.com>
2103
2104         Invoking an action menu on a selection should result in the text menu
2105         https://bugs.webkit.org/show_bug.cgi?id=138892
2106         -and corresponding-
2107         rdar://problem/18996776
2108
2109         Reviewed by Tim Horton.
2110
2111         * WebView/WebActionMenuController.mm:
2112         (-[WebActionMenuController _defaultMenuItems]):
2113
2114 2014-11-19  Beth Dakin  <bdakin@apple.com>
2115
2116         Data detected results with no menu items should not fall through to regular text 
2117         action menus
2118         https://bugs.webkit.org/show_bug.cgi?id=138887
2119         -and corresponding-
2120         rdar://problem/18971616
2121
2122         Reviewed by Tim Horton.
2123
2124         * WebView/WebActionMenuController.mm:
2125         (-[WebActionMenuController _defaultMenuItems]):
2126
2127 2014-11-19  Daniel Bates  <dabates@apple.com>
2128
2129         [iOS] Make WebKit build with public iOS SDK
2130         https://bugs.webkit.org/show_bug.cgi?id=136863
2131
2132         Reviewed by David Kilzer.
2133
2134         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
2135         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
2136         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
2137         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
2138         may be used by Apple internal clients that do not include wtf/Platform.h.
2139         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
2140         private Foundation headers directly.
2141         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
2142         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
2143         instead of including private CFNetwork headers directly. Also fixed up style and
2144         ordering of header include directives.
2145         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
2146         CFNetwork headers directly. Also sort the #import directives.
2147         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
2148         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
2149
2150 2014-11-18  David Kilzer  <ddkilzer@apple.com>
2151
2152         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
2153         <http://webkit.org/b/138813>
2154
2155         Reviewed by Mark Rowe.
2156
2157         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
2158         selectors.
2159
2160 2014-11-18  Chris Dumez  <cdumez@apple.com>
2161
2162         Add a setting to toggle DOMTimer throttling support
2163         https://bugs.webkit.org/show_bug.cgi?id=138844
2164         <rdar://problem/19020874>
2165
2166         Reviewed by Andreas Kling.
2167
2168         Add a setting to disable DOM timers throttling, in order to help
2169         developers determine if a specific issue is caused by timer
2170         throttling.
2171
2172         * WebView/WebPreferenceKeysPrivate.h:
2173         * WebView/WebPreferences.mm:
2174         (+[WebPreferences initialize]):
2175         (-[WebPreferences domTimersThrottlingEnabled]):
2176         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
2177         * WebView/WebPreferencesPrivate.h:
2178         * WebView/WebView.mm:
2179         (-[WebView _preferencesChanged:]):
2180
2181 2014-11-18  Tim Horton  <timothy_horton@apple.com>
2182
2183         Avoid re-encoding action menu image data
2184         https://bugs.webkit.org/show_bug.cgi?id=138817
2185         <rdar://problem/18840382>
2186
2187         Reviewed by Anders Carlsson.
2188
2189         * WebView/WebActionMenuController.mm:
2190         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2191         (-[WebActionMenuController _addImageToPhotos:]):
2192         Build a temporary filename from a UUID and the image's desired extension.
2193         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
2194         Build an image menu only if we have an image, URL, data, and extension.
2195
2196 2014-11-18  Daniel Bates  <dabates@apple.com>
2197
2198         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2199         SPI are not available in public SDK
2200         https://bugs.webkit.org/show_bug.cgi?id=138802
2201
2202         Reviewed by David Kilzer.
2203
2204         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2205         libdispatch and MobileGestalt headers directly.
2206
2207         * WebView/WebView.mm:
2208
2209 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
2210
2211         Remove calls to deprecated NSMenu methods
2212         https://bugs.webkit.org/show_bug.cgi?id=138808.
2213
2214         Reviewed by Anders Carlsson.
2215
2216         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
2217
2218         * WebCoreSupport/PopupMenuMac.mm:
2219         (PopupMenuMac::populate):
2220
2221 2014-11-17  Daniel Bates  <dabates@apple.com>
2222
2223         Unreviewed, rolling out r176232.
2224
2225         Broke the Mac build. Will investigate offline.
2226
2227         Reverted changeset:
2228
2229         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2230         MobileGestalt"
2231         https://bugs.webkit.org/show_bug.cgi?id=138802
2232         http://trac.webkit.org/changeset/176232
2233
2234 2014-11-17  Daniel Bates  <dabates@apple.com>
2235
2236         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2237         SPI are not available in public SDK
2238         https://bugs.webkit.org/show_bug.cgi?id=138802
2239
2240         Reviewed by David Kilzer.
2241
2242         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2243         libdispatch and MobileGestalt headers directly.
2244
2245         * WebView/WebView.mm:
2246
2247 2014-11-17  Beth Dakin  <bdakin@apple.com>
2248
2249         Whitespace action menus should focus the HitTestResult and create an insertion 
2250         point
2251         https://bugs.webkit.org/show_bug.cgi?id=138786
2252         -and corresponding-
2253         rdar://problem/18944893
2254
2255         Reviewed by Tim Horton.
2256
2257         Whitespace menus should cause the HitTestResult to be focused, and they should set 
2258         the selection based on the HitTest location.
2259
2260         * WebView/WebActionMenuController.mm:
2261         (-[WebActionMenuController isMenuForTextContent]):
2262         (-[WebActionMenuController focusAndSelectHitTestResult]):
2263         (-[WebActionMenuController willOpenMenu:withEvent:]):
2264
2265 2014-11-17  Daniel Bates  <dabates@apple.com>
2266
2267         [iOS] QuartzCore SPI not available in public SDK
2268         https://bugs.webkit.org/show_bug.cgi?id=138751
2269
2270         Reviewed by David Kilzer.
2271
2272         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
2273
2274         * WebInspector/WebNodeHighlight.mm:
2275         * WebView/WebIndicateLayer.mm:
2276
2277 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
2278
2279         [iOS] allow host application to opt-out of alternate fullscreen
2280         https://bugs.webkit.org/show_bug.cgi?id=138787
2281
2282         Reviewed by Darin Adler.
2283
2284         * WebView/WebPreferenceKeysPrivate.h:
2285         * WebView/WebPreferences.mm:
2286         (+[WebPreferences initialize]):
2287         (-[WebPreferences allowsAlternateFullscreen]):
2288         (-[WebPreferences setAllowsAlternateFullscreen:]):
2289         * WebView/WebPreferencesPrivate.h:
2290         * WebView/WebView.mm:
2291         (-[WebView _preferencesChanged:]):
2292
2293 2014-11-16  Tim Horton  <timothy_horton@apple.com>
2294
2295         Use TextIndicator instead of the built in Lookup highlight
2296         https://bugs.webkit.org/show_bug.cgi?id=138775
2297         <rdar://problem/18953982>
2298
2299         Reviewed by Anders Carlsson.
2300
2301         * WebCoreSupport/WebSystemInterface.mm:
2302         (InitWebCoreSystemInterface):
2303         Remove a WKSI import.
2304
2305         * WebView/WebActionMenuController.mm:
2306         (-[WebActionMenuController _lookupText:]):
2307         (-[WebActionMenuController _createActionMenuItemForTag:]):
2308         Make use of the new Lookup SPI header.
2309         Disable the Lookup item if lookup is not available.
2310
2311 2014-11-15  Tim Horton  <timothy_horton@apple.com>
2312
2313         Implement data detectors and mailto action menus for WebKit1
2314         https://bugs.webkit.org/show_bug.cgi?id=138765
2315         <rdar://problem/18877535>
2316
2317         Reviewed by Beth Dakin.
2318
2319         * WebView/WebActionMenuController.h:
2320         * WebView/WebActionMenuController.mm:
2321         (-[WebActionMenuController willOpenMenu:withEvent:]):
2322         Tell DataDetectors that the menu is going to open.
2323         Select the text (or not) based on the number of items in the menu, just like WebKit2.
2324
2325         (-[WebActionMenuController didCloseMenu:withEvent:]):
2326         Tell DataDetectors that the menu closed.
2327
2328         (-[WebActionMenuController _defaultMenuItemsForLink]):
2329         Move these checks out of _defaultMenuItemsForLink, because we expect this
2330         to always return a complete link menu.
2331
2332         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2333         Implement. More or less copied from WebKit2.
2334
2335         (-[WebActionMenuController _selectDataDetectedText]):
2336         Select the stashed range.
2337
2338         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2339         Implement. More or less copied from WebKit2.
2340         The yellow highlight isn't hooked up yet.
2341         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
2342
2343         (-[WebActionMenuController _selectLookupText]):
2344         Remove an unnecessary return.
2345
2346         (-[WebActionMenuController _defaultMenuItems]):
2347         Call into the two new menu types.
2348
2349         * WebView/WebUIDelegatePrivate.h:
2350
2351 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
2352
2353         Get rid of WebFontCache
2354         https://bugs.webkit.org/show_bug.cgi?id=134752
2355
2356         Reviewed by Dave Hyatt.
2357
2358         * WebView/WebHTMLView.mm:
2359
2360 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
2361
2362         Update some artwork for the legacy WebKit action menu
2363         https://bugs.webkit.org/show_bug.cgi?id=138758
2364         <rdar://problem/18989840>
2365
2366         * WebView/WebActionMenuController.mm:
2367         (webKitBundleImageNamed): Deleted.
2368         Fix the build.
2369
2370 2014-11-14  Tim Horton  <timothy_horton@apple.com>
2371
2372         Update some artwork for the legacy WebKit action menu
2373         https://bugs.webkit.org/show_bug.cgi?id=138758
2374         <rdar://problem/18989840>
2375
2376         Reviewed by Simon Fraser.
2377
2378         * WebView/WebActionMenuController.mm:
2379         (-[WebActionMenuController _createActionMenuItemForTag:]):
2380
2381 2014-11-14  Daniel Bates  <dabates@apple.com>
2382
2383         [iOS] NSFileManager and QuickLook SPI not available in public SDK
2384         https://bugs.webkit.org/show_bug.cgi?id=138742
2385
2386         Reviewed by Pratik Solanki.
2387
2388         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
2389
2390         * WebCoreSupport/WebFrameLoaderClient.mm:
2391
2392 2014-11-14  Beth Dakin  <bdakin@apple.com>
2393
2394         WK1: Webpage preview can come up in wrong location
2395         https://bugs.webkit.org/show_bug.cgi?id=138747
2396         -and corresponding-
2397         rdar://problem/18979004
2398
2399         Reviewed by Tim Horton.
2400
2401         Converting to window twice is bad.
2402         * WebView/WebActionMenuController.mm:
2403         (elementBoundingBoxInWindowCoordinatesFromNode):
2404         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2405         (elementBoundingBoxFromNode): Deleted.
2406
2407 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2408
2409         Move FontMac and FontCacheMac off of WKSI
2410         https://bugs.webkit.org/show_bug.cgi?id=138633
2411
2412         Reviewed by Simon Fraser.
2413
2414         * WebCoreSupport/WebSystemInterface.mm:
2415         (InitWebCoreSystemInterface):
2416         * WebKit.order:
2417
2418 2014-11-13  Beth Dakin  <bdakin@apple.com>
2419
2420         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
2421         https://bugs.webkit.org/show_bug.cgi?id=138716
2422         -and corresponding-
2423         rdar://problem/18977222
2424
2425         Reviewed by Tim Horton.
2426
2427         It’s not necessary to use the WebElementDictionary for so many things now that we 
2428         are caching the HitTestResult. We should just use the HitTestResult.
2429
2430         * WebView/WebActionMenuController.mm:
2431         (-[WebActionMenuController prepareForMenu:withEvent:]):
2432         (-[WebActionMenuController _openURLFromActionMenu:]):
2433         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2434         (elementBoundingBoxFromNode):
2435         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2436         (-[WebActionMenuController _defaultMenuItemsForLink]):
2437         (-[WebActionMenuController _defaultMenuItemsForImage]):
2438         (-[WebActionMenuController _defaultMenuItemsForVideo]):
2439         (-[WebActionMenuController _defaultMenuItemsForText]):
2440         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2441         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2442         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2443         (-[WebActionMenuController _createActionMenuItemForTag:]):
2444         (-[WebActionMenuController _defaultMenuItems]):
2445         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
2446         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
2447         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
2448         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
2449         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
2450         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
2451         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
2452         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
2453         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
2454         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
2455
2456 2014-11-13  Daniel Bates  <dabates@apple.com>
2457
2458         [iOS] NSGeometry data types are not available in the public SDK
2459         https://bugs.webkit.org/show_bug.cgi?id=137536
2460
2461         Reviewed by David Kilzer.
2462
2463         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
2464         private header.
2465
2466         * DOM/WebDOMOperationsPrivate.h:
2467
2468 2014-11-13  Beth Dakin  <bdakin@apple.com>
2469
2470         WK1: Support default actions for video
2471         https://bugs.webkit.org/show_bug.cgi?id=138713
2472         -and corresponding-
2473         rdar://problem/18877520
2474
2475         Reviewed by Tim Horton.
2476
2477         Call setToNonShadowAncestor() for media HitTestResults.
2478         * WebView/WebActionMenuController.mm:
2479         (-[WebActionMenuController performHitTestAtPoint:]):
2480
2481         Default items and actions.
2482         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
2483         (-[WebActionMenuController _copyVideoURL:]):
2484         (-[WebActionMenuController _saveVideoToDownloads:]):
2485         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2486         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2487         * WebView/WebUIDelegatePrivate.h:
2488
2489 2014-11-13  Tim Horton  <timothy_horton@apple.com>
2490
2491         WK1: Update icon for Add to Reading List
2492         https://bugs.webkit.org/show_bug.cgi?id=138710
2493         <rdar://problem/18975774>
2494
2495         Reviewed by Beth Dakin.
2496
2497         * WebView/WebActionMenuController.mm:
2498         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2499         Use the right icon, matching WebKit2.
2500
2501 2014-11-12  Beth Dakin  <bdakin@apple.com>
2502
2503         WK1: Support default actions for images
2504         https://bugs.webkit.org/show_bug.cgi?id=138668
2505         -and corresponding-
2506         rdar://problem/18785434
2507
2508         Reviewed by Tim Horton.
2509
2510         * WebView/WebActionMenuController.h:
2511         * WebView/WebActionMenuController.mm:
2512         (-[WebActionMenuController didCloseMenu:withEvent:]):
2513         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2514         (-[WebActionMenuController _copyImage:]):
2515         (temporaryPhotosDirectoryPath):
2516         (pathToPhotoOnDisk):
2517         (-[WebActionMenuController _canAddMediaToPhotos]):
2518         (-[WebActionMenuController _addImageToPhotos:]):
2519         (-[WebActionMenuController _saveImageToDownloads:]):
2520         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2521         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
2522         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2523         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2524         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2525         * WebView/WebUIDelegatePrivate.h:
2526
2527 2014-11-11  Beth Dakin  <bdakin@apple.com>
2528
2529         Action menu hit testing is not working properly with all WK1 apps
2530         https://bugs.webkit.org/show_bug.cgi?id=138643
2531         -and corresponding-
2532         rdar://problem/18949376
2533
2534         Reviewed by Tim Horton.
2535
2536         * WebView/WebActionMenuController.mm:
2537         (-[WebActionMenuController prepareForMenu:withEvent:]):
2538         (-[WebActionMenuController _lookupText:]):
2539
2540 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2541
2542         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
2543         https://bugs.webkit.org/show_bug.cgi?id=138623
2544
2545         Reviewed by Geoff Garen.
2546
2547         * WebCoreSupport/WebSystemInterface.mm:
2548         (InitWebCoreSystemInterface):
2549         * WebKit.order:
2550
2551 2014-11-11  Tim Horton  <timothy_horton@apple.com>
2552
2553         Localize strings for action menus
2554         https://bugs.webkit.org/show_bug.cgi?id=138591
2555         <rdar://problem/18815343>
2556
2557         Reviewed by Dan Bates.
2558
2559         * WebView/WebActionMenuController.mm:
2560         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2561         Make use of the new strings.
2562
2563 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2564
2565         Cleanup from r175379
2566         https://bugs.webkit.org/show_bug.cgi?id=138616
2567
2568         Reviewed by Simon Fraser.
2569
2570         * WebCoreSupport/WebSystemInterface.mm:
2571         (InitWebCoreSystemInterface):
2572         * WebKit.order:
2573
2574 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2575
2576         Move CTFontTransformGlyphs out from WKSI
2577         https://bugs.webkit.org/show_bug.cgi?id=138599
2578
2579         Reviewed by Simon Fraser.
2580
2581         * WebCoreSupport/WebSystemInterface.mm:
2582         (InitWebCoreSystemInterface):
2583         * WebKit.order:
2584
2585 2014-11-11  Dan Bernstein  <mitz@apple.com>
2586
2587         More iOS build fix.
2588
2589         * WebView/WebHTMLViewInternal.h:
2590
2591 2014-11-11  Dan Bernstein  <mitz@apple.com>
2592
2593         iOS build fix.
2594
2595         * WebView/WebHTMLView.mm:
2596
2597 2014-11-10  Beth Dakin  <bdakin@apple.com>
2598
2599         WK1: Support default actions for editable text with misspelled word
2600         https://bugs.webkit.org/show_bug.cgi?id=138590
2601         -and corresponding-
2602         rdar://problem/18877506
2603
2604         Reviewed by Tim Horton.
2605
2606         If there are misspelled word suggestions for editable text, create a new type of 
2607         menu with a spelling suggestion sub-menu.
2608
2609         * WebView/WebActionMenuController.mm:
2610         (-[WebActionMenuController isMenuForTextContent]):
2611         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
2612         (-[WebActionMenuController _changeSelectionToSuggestion:]):
2613         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2614         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2615         * WebView/WebHTMLView.mm:
2616         (-[WebHTMLView _changeSpellingToWord:]):
2617         * WebView/WebHTMLViewInternal.h:
2618         * WebView/WebUIDelegatePrivate.h:
2619
2620 2014-11-10  Beth Dakin  <bdakin@apple.com>
2621
2622         WK1: Support default actions for editable whitespace
2623         https://bugs.webkit.org/show_bug.cgi?id=138586
2624         -and corresponding-
2625         rdar://problem/18932048
2626
2627         Reviewed by Tim Horton.
2628
2629         New menu type. Just wants paste.
2630
2631         * WebView/WebActionMenuController.mm:
2632         (-[WebActionMenuController isMenuForTextContent]):
2633         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
2634         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2635         * WebView/WebUIDelegatePrivate.h:
2636
2637 2014-11-10  Beth Dakin  <bdakin@apple.com>
2638
2639         WK1: Support default actions for editable text
2640         https://bugs.webkit.org/show_bug.cgi?id=138580
2641         -and corresponding-
2642         rdar://problem/18877497
2643
2644         Reviewed by Tim Horton.
2645
2646         New menu type, and new action type for paste. 
2647
2648         * WebView/WebActionMenuController.mm:
2649         (-[WebActionMenuController isMenuForTextContent]):
2650         (-[WebActionMenuController willOpenMenu:withEvent:]):
2651         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
2652         (-[WebActionMenuController _paste:]):
2653         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2654         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2655         * WebView/WebUIDelegatePrivate.h:
2656
2657 2014-11-10  Beth Dakin  <bdakin@apple.com>
2658
2659         WK1: Text is getting selected even when an action menu fails to invoke
2660         https://bugs.webkit.org/show_bug.cgi?id=138576
2661         -and corresponding-
2662         rdar://problem/18931330
2663
2664         Reviewed by Tim Horton.
2665
2666         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
2667         * WebView/WebActionMenuController.h:
2668         * WebView/WebActionMenuController.mm:
2669         (-[WebActionMenuController prepareForMenu:withEvent:]):
2670         (-[WebActionMenuController willOpenMenu:withEvent:]):
2671
2672         _selectLookupText no longer needs to return a BOOL indicating success or failure.
2673         (-[WebActionMenuController _selectLookupText]):
2674         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2675
2676         Pass willOpenMenu: on to the controller.
2677         * WebView/WebView.mm:
2678         (-[WebView willOpenMenu:withEvent:]):
2679
2680 2014-11-10  Beth Dakin  <bdakin@apple.com>
2681
2682         Speculative build fix.
2683
2684         * WebView/WebActionMenuController.mm:
2685
2686 2014-11-10  Beth Dakin  <bdakin@apple.com>
2687
2688         Action menu initialization should be moved to _commonInitializationWithFrameName
2689         https://bugs.webkit.org/show_bug.cgi?id=138572
2690         -and corresponding-
2691         rdar://problem/18929733
2692
2693         Reviewed by Tim Horton.
2694
2695         * WebView/WebView.mm:
2696         (-[WebView _commonInitializationWithFrameName:groupName:]):
2697         (-[WebView _initWithFrame:frameName:groupName:]):
2698
2699 2014-11-10  Beth Dakin  <bdakin@apple.com>
2700
2701         WK1: Support default actions for read-only text
2702         https://bugs.webkit.org/show_bug.cgi?id=138552
2703         -and corresponding-
2704         rdar://problem/18877483
2705
2706         Reviewed by Tim Horton.
2707
2708         New WKSystemInterface functions that WebCore needs to use.
2709         * WebCoreSupport/WebSystemInterface.mm:
2710         (InitWebCoreSystemInterface):
2711
2712         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
2713         makes a lot of things easier.
2714         * WebView/WebActionMenuController.h:
2715         * WebView/WebActionMenuController.mm:
2716
2717         Perform the hit test ourselves instead of calling into WebView so that we can more 
2718         easily save the WebCore::HitTestResult for ourselves.
2719         (-[WebActionMenuController performHitTestAtPoint:]):
2720
2721         Clear selection for non-text menus.
2722         (-[WebActionMenuController prepareForMenu:withEvent:]):
2723
2724         Re-set the _type here just to be safe.
2725         (-[WebActionMenuController didCloseMenu:withEvent:]):
2726
2727         Moving this method to be next to the link actions so they can be within a pragma 
2728         mark.
2729         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2730
2731         New method for default text actions — lookup and copy.
2732         (-[WebActionMenuController _defaultMenuItemsForText:]):
2733         (-[WebActionMenuController _copySelection:]):
2734         (-[WebActionMenuController _lookupText:]):
2735
2736         If there is not already a selection, invoking the action menu on text should 
2737         select the lookup text.
2738         (-[WebActionMenuController _selectLookupText]):
2739         (performDictionaryLookupForSelection):
2740         (performDictionaryLookupForRange):
2741
2742         Handle text now.
2743         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2744         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2745
2746         New enum values.
2747         * WebView/WebUIDelegatePrivate.h:
2748
2749         Pass didCloseMenu on to the controller.
2750         * WebView/WebView.mm:
2751         (-[WebView didCloseMenu:withEvent:]):
2752
2753 2014-11-09  Chris Dumez  <cdumez@apple.com>
2754
2755         Add a more correct way to compare floating point numbers and use it
2756         https://bugs.webkit.org/show_bug.cgi?id=138527
2757
2758         Reviewed by Darin Adler.
2759
2760         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
2761         to compare floating-point numbers.
2762
2763         * WebView/WebHTMLView.mm:
2764         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2765
2766 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2767
2768         Delete cookies between tests
2769         https://bugs.webkit.org/show_bug.cgi?id=138528
2770
2771         Reviewed by Sam Weinig.
2772
2773         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
2774         * WebView/WebPreferencesPrivate.h:
2775         Added an SPI for DumpRenderTree.
2776
2777 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
2778
2779         [iOS] Update optimized fullscreen media controls
2780         https://bugs.webkit.org/show_bug.cgi?id=138493
2781
2782         Reviewed by Brent Fulgham.
2783
2784         * WebCoreSupport/WebSystemInterface.mm:
2785         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
2786
2787 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
2788
2789         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
2790         https://bugs.webkit.org/show_bug.cgi?id=138443
2791
2792         Reviewed by Anders Carlsson.
2793
2794         Wrapping the dealloc method in its own autorelease pool avoids the problem of
2795         complex tear-downs leading to the WebView itself being added to an autorelease
2796         pool that is not drained until after the instance has been dealloc'd.
2797  
2798         * WebView/WebView.mm:
2799         (-[WebView dealloc]):
2800
2801 2014-11-05  Jer Noble  <jer.noble@apple.com>
2802
2803         De-templatize Timer
2804         https://bugs.webkit.org/show_bug.cgi?id=138450
2805
2806         Reviewed by Anders Carlsson.
2807
2808         Remove template specifiers from Timer.
2809
2810         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2811         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2812         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2813         * Plugins/WebNetscapePluginStream.h:
2814         * Plugins/WebNetscapePluginStream.mm:
2815         (WebNetscapePluginStream::deliverDataTimerFired):
2816
2817 2014-11-05  Dan Bernstein  <mitz@apple.com>
2818
2819         Remove the unused deletion UI feature
2820         https://bugs.webkit.org/show_bug.cgi?id=138442
2821
2822         Rubber-stamped by Alexey Proskuryakov.
2823
2824         * DefaultDelegates/WebDefaultEditingDelegate.m:
2825         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
2826         * WebCoreSupport/WebEditorClient.h:
2827         * WebCoreSupport/WebEditorClient.mm:
2828         (WebEditorClient::shouldShowDeleteInterface): Deleted.
2829         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
2830         -webView:shouldShowDeleteInterfaceForElement:.
2831
2832 2014-11-03  Dean Jackson  <dino@apple.com>
2833
2834         Add ENABLE_FILTERS_LEVEL_2 feature guard.
2835         https://bugs.webkit.org/show_bug.cgi?id=138362
2836
2837         Reviewed by Tim Horton.
2838
2839         Add a new feature define for Level 2 of CSS Filters.
2840         http://dev.w3.org/fxtf/filters-2/
2841
2842         * Configurations/FeatureDefines.xcconfig:
2843
2844 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
2845
2846         Add button and enable optimized fullscreen.
2847         https://bugs.webkit.org/show_bug.cgi?id=138351
2848
2849         Reviewed by Eric Carlson.
2850
2851         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
2852
2853         * WebCoreSupport/WebSystemInterface.mm:
2854         (InitWebCoreSystemInterface): added
2855
2856 2014-11-04  Chris Dumez  <cdumez@apple.com>
2857
2858         Add ptr() method to Ref class
2859         https://bugs.webkit.org/show_bug.cgi?id=138361
2860
2861         Reviewed by Darin Adler.
2862
2863         Use the new Ref::ptr() method.
2864
2865         * WebView/WebFrame.mm:
2866         (-[WebFrame _setTypingStyle:withUndoAction:]):
2867         * WebView/WebHTMLView.mm:
2868         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2869         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2870         * WebView/WebView.mm:
2871         (-[WebView applyStyle:]):
2872
2873 2014-11-04  Darin Adler  <darin@apple.com>
2874
2875         Eliminate ResourceBuffer and use SharedBuffer directly instead
2876         https://bugs.webkit.org/show_bug.cgi?id=138174
2877
2878         Reviewed by Antti Koivisto.
2879
2880         * WebView/WebDataSource.mm:
2881         (-[WebDataSource data]): Use SharedBuffer directly.
2882         * WebView/WebHTMLView.mm:
2883         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2884
2885 2014-11-03  Commit Queue  <commit-queue@webkit.org>
2886
2887         Unreviewed, rolling out r175406, r175413, and r175423.
2888         https://bugs.webkit.org/show_bug.cgi?id=138327
2889
2890         Multipart tests are still broken (Requested by ap on #webkit).
2891
2892         Reverted changesets:
2893
2894         "Eliminate ResourceBuffer and use SharedBuffer directly
2895         instead"
2896         https://bugs.webkit.org/show_bug.cgi?id=138174
2897         http://trac.webkit.org/changeset/175406
2898
2899         "Unreviewed, iOS build fix since 175406."
2900         http://trac.webkit.org/changeset/175413
2901
2902         "Fix assertion in CachedResource::addDataBuffer"
2903         http://trac.webkit.org/changeset/175423
2904
2905 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2906
2907         Use std::unique_ptr for TypeCountSet
2908         https://bugs.webkit.org/show_bug.cgi?id=138242
2909
2910         Reviewed by Andreas Kling.
2911
2912         * Misc/WebCoreStatistics.mm:
2913         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
2914         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
2915
2916 2014-10-31  Beth Dakin  <bdakin@apple.com>
2917
2918         Use system art for action menus when possible
2919         https://bugs.webkit.org/show_bug.cgi?id=138260
2920
2921         Reviewed by Tim Horton.
2922
2923         * WebView/WebActionMenuController.mm:
2924         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2925
2926 2014-10-30  Darin Adler  <darin@apple.com>
2927
2928         Eliminate ResourceBuffer and use SharedBuffer directly instead
2929         https://bugs.webkit.org/show_bug.cgi?id=138174
2930
2931         Reviewed by Antti Koivisto.
2932
2933         * WebView/WebDataSource.mm:
2934         (-[WebDataSource data]): Use SharedBuffer directly.
2935         * WebView/WebHTMLView.mm:
2936         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2937
2938 2014-10-30  Jer Noble  <jer.noble@apple.com>
2939
2940         [EME] Add Setting for accessing storage location for MediaKeys data
2941         https://bugs.webkit.org/show_bug.cgi?id=138147
2942
2943         Reviewed by Brady Eidson.
2944
2945         * WebView/WebPreferenceKeysPrivate.h:
2946         * WebView/WebPreferences.mm:
2947         (+[WebPreferences initialize]): Set default location.
2948         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
2949         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
2950         * WebView/WebPreferencesPrivate.h:
2951         * WebView/WebView.mm:
2952         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
2953
2954 2014-10-30  Dana Burkart  <dburkart@apple.com>
2955
2956         <rdar://problem/18821260> Prepare for the mysterious future
2957
2958         Reviewed by Lucas Forschler.
2959
2960         * Configurations/Base.xcconfig:
2961         * Configurations/DebugRelease.xcconfig:
2962         * Configurations/FeatureDefines.xcconfig:
2963         * Configurations/Version.xcconfig:
2964
2965 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
2966
2967         Add optimized fullscreen mode.
2968         https://bugs.webkit.org/show_bug.cgi?id=138044
2969
2970         Reviewed by Jer Noble.
2971
2972         Enable different types of fullscreen video behavior.
2973         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
2974
2975         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
2976         * WebCoreSupport/WebChromeClient.mm:
2977         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
2978         * WebView/WebView.mm:
2979         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
2980         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
2981         * WebView/WebViewInternal.h: ditto
2982
2983 2014-10-27  Beth Dakin  <bdakin@apple.com>
2984
2985         Provide a way for WebKit1 clients to override default action menu items
2986         https://bugs.webkit.org/show_bug.cgi?id=138066
2987         -and corresponding-
2988         rdar://problem/18451638
2989
2990         Reviewed by Anders Carlsson.
2991
2992         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
2993         send that along to clients customizing the menu.
2994         * WebView/WebActionMenuController.h:
2995         * WebView/WebActionMenuController.mm:
2996         (-[WebActionMenuController prepareForMenu:withEvent:]):
2997         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2998
2999         New enum and new SPI to customize menus.
3000         * WebView/WebUIDelegatePrivate.h:
3001
3002 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
3003
3004         Fix the iOS build
3005
3006         * Configurations/WebKitLegacy.xcconfig:
3007         * WebView/WebView.mm:
3008
3009 2014-10-24  Beth Dakin  <bdakin@apple.com>
3010
3011         Build fix.
3012
3013         * WebView/WebActionMenuController.mm:
3014         (-[WebActionMenuController _openURLFromActionMenu:]):
3015         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3016         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3017
3018 2014-10-24  Beth Dakin  <bdakin@apple.com>
3019
3020         WebKit1 should support action menus
3021         https://bugs.webkit.org/show_bug.cgi?id=138032
3022
3023         Reviewed by Tim Horton.
3024
3025         This patch adds basic support for action menus and adds actions for links.
3026
3027         Helper class takes care of all of the action menu work. WebView will forward the 
3028         prepareForMenu: message, and then the helper class takes it from there.
3029         * WebView/WebActionMenuController.h: Added.
3030         * WebView/WebActionMenuController.mm: Added.
3031         (-[WebActionMenuController webViewClosed]):
3032         (-[WebActionMenuController prepareForMenu:withEvent:]):
3033
3034         Selectors for link actions.
3035         (-[WebActionMenuController _openURLFromActionMenu:]):
3036         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3037         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
3038         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3039         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3040         (webKitBundleImageNamed):
3041         (-[WebActionMenuController _defaultMenuItemsForLink:]):
3042         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3043
3044         Tags for the action menu items.
3045         * WebView/WebUIDelegatePrivate.h:
3046         * WebView/WebView.mm:
3047
3048         Set the action menu if possible and create the controller.
3049         (-[WebView _initWithFrame:frameName:groupName:]):
3050         (-[WebView _close]):
3051         (-[WebView prepareForMenu:withEvent:]):
3052
3053         WebViewData stores the WebActionMenuHelper
3054         * WebView/WebViewData.h:
3055         * WebView/WebViewData.mm:
3056         (-[WebViewPrivate dealloc]):
3057
3058 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
3059
3060         Web Inspector: Provide a way to have alternate inspector agents
3061         https://bugs.webkit.org/show_bug.cgi?id=137901
3062
3063         Reviewed by Brian Burg.
3064
3065         * Configurations/FeatureDefines.xcconfig:
3066
3067 2014-10-23  Tim Horton  <timothy_horton@apple.com>
3068
3069         Add some SPI headers for NSExtension and NSSharingService{Picker}
3070         https://bugs.webkit.org/show_bug.cgi?id=138027
3071
3072         Reviewed by Anders Carlsson.
3073
3074         * Misc/WebSharingServicePickerController.h:
3075         * Misc/WebSharingServicePickerController.mm:
3076         * WebCoreSupport/WebSelectionServiceController.mm:
3077         * WebCoreSupport/WebContextMenuClient.mm:
3078         Fix a sorting issue.
3079         Replace redefinitions with SPI header #imports.
3080
3081 2014-10-23  Tim Horton  <timothy_horton@apple.com>
3082
3083         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
3084         https://bugs.webkit.org/show_bug.cgi?id=138013
3085
3086         Reviewed by Dan Bernstein.
3087
3088         * WebCoreSupport/WebSelectionServiceController.mm:
3089         (WebSelectionServiceController::hasRelevantSelectionServices):
3090         Don't adopt this autoreleased object.
3091
3092 2014-10-22  Chris Dumez  <cdumez@apple.com>
3093
3094         [Mac][WK2] Fix applicationIsSafari() detection
3095         https://bugs.webkit.org/show_bug.cgi?id=137893
3096
3097         Reviewed by Alexey Proskuryakov.
3098
3099         Provide an implementation for FrameLoaderClient's new
3100         needsQuickLookResourceCachingQuirks() that returns
3101         a static flag initialized using
3102         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
3103
3104         * WebCoreSupport/WebFrameLoaderClient.h:
3105         * WebCoreSupport/WebFrameLoaderClient.mm:
3106
3107 2014-10-20  Chris Dumez  <cdumez@apple.com>
3108
3109         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
3110         https://bugs.webkit.org/show_bug.cgi?id=137797
3111
3112         Reviewed by Darin Adler.
3113
3114         Call ResourceRequest::setDomainForPartitionName() instead of
3115         setPartitionName() as the argument is a domain, not a valid
3116         partition name.
3117
3118         * Misc/WebCache.mm:
3119         (+[WebCache addImageToCache:forURL:forFrame:]):
3120         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3121
3122 2014-10-20  Andy Estes  <aestes@apple.com>
3123
3124         Fix the iOS build.
3125
3126         * WebView/WebFrame.mm:
3127         (-[WebFrame getDictationResultRanges:andMetadatas:]):
3128         (-[WebFrame dictationResultMetadataForRange:]):
3129
3130 2014-10-19  Chris Dumez  <cdumez@apple.com>
3131
3132         Use is<>() / downcast<>() for all remaining RenderObject subclasses
3133         https://bugs.webkit.org/show_bug.cgi?id=137845
3134
3135         Reviewed by Darin Adler.
3136
3137         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
3138         clean up the surrounding code.
3139
3140         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3141         (-[WebHostedNetscapePluginView pluginHostDied]):
3142         * Plugins/WebBaseNetscapePluginView.mm:
3143         (-[WebBaseNetscapePluginView _windowClipRect]):
3144         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
3145         * WebCoreSupport/WebFrameLoaderClient.mm:
3146         (WebFrameLoaderClient::createPlugin):
3147         (WebFrameLoaderClient::createJavaAppletWidget):
3148
3149 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3150
3151         Build fix for 32-bit Yosemite
3152
3153         * WebCoreSupport/WebContextMenuClient.mm:
3154         (WebContextMenuClient::contextMenuForEvent):
3155         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
3156
3157 2014-10-17  Chris Dumez  <cdumez@apple.com>
3158
3159         Use is<>() / downcast<>() for RenderBox
3160         https://bugs.webkit.org/show_bug.cgi?id=137804
3161
3162         Reviewed by Andreas Kling.
3163
3164         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
3165         code.
3166
3167         * WebCoreSupport/WebContextMenuClient.mm:
3168         (WebContextMenuClient::clientFloatRectForNode):
3169         * WebView/WebFrame.mm:
3170         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
3171
3172 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3173
3174         Fix the build with the public SDK.
3175
3176         * WebCoreSupport/WebSelectionServiceController.mm:
3177         We should transition all this SPI to real SPI headers as soon as possible.
3178
3179 2014-10-16  Tim Horton  <timothy_horton@apple.com>
3180
3181         Implement selection services menu for Legacy WebKit
3182         https://bugs.webkit.org/show_bug.cgi?id=137582
3183         <rdar://problem/18604241>
3184
3185         Reviewed by Brady Eidson.
3186
3187         * Misc/WebSharingServicePickerController.h:
3188         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
3189         Add WebSharingServicePickerClient, which other classes can implement
3190         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
3191         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
3192
3193         * Misc/WebSharingServicePickerController.mm:
3194         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
3195
3196         (-[WebSharingServicePickerController clear]):
3197         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
3198         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
3199         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
3200         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
3201         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3202         Make use of WebSharingServicePickerClient.
3203
3204         (-[WebSharingServicePickerController sharingService:didShareItems:]):
3205         If we're returned a NSAttributedString, paste it on top of the current selection,
3206         similar to what the WebKit2 implementation currently does.
3207         
3208         * WebCoreSupport/WebChromeClient.h:
3209         * WebCoreSupport/WebChromeClient.mm:
3210         (WebChromeClient::handleTelephoneNumberClick):
3211         (WebChromeClient::handleSelectionServiceClick):
3212         (WebChromeClient::hasRelevantSelectionServices):
3213         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
3214
3215         * WebCoreSupport/WebContextMenuClient.h:
3216         * WebCoreSupport/WebContextMenuClient.mm:
3217         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
3218         (WebContextMenuClient::pageForSharingServicePicker):
3219         (WebContextMenuClient::windowForSharingServicePicker):
3220         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
3221         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3222         (WebContextMenuClient::contextMenuForEvent):
3223         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
3224         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
3225         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
3226         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
3227         having WebSharingServicePickerController tightly bound to it.
3228         Make an NSItemProvider array when instantiating WebSharingServicePickerController
3229         instead of handing it data directly.
3230
3231         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
3232         * WebCoreSupport/WebSelectionServiceController.mm: Added.
3233         (WebSelectionServiceController::WebSelectionServiceController):
3234         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
3235         for selection services.
3236
3237         (WebSelectionServiceController::handleSelectionServiceClick):
3238         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
3239
3240         (hasCompatibleServicesForItems):
3241         (WebSelectionServiceController::hasRelevantSelectionServices):
3242         Determine whether or not services are available.
3243
3244         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
3245         (WebSelectionServiceController::pageForSharingServicePicker):
3246         (WebSelectionServiceController::windowForSharingServicePicker):
3247         Implement the rest of the WebSharingServicePickerClient overrides.
3248
3249         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
3250         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
3251         These are only useful for image sharing services, so we don't need to
3252         implement them (WebContextMenuClient does, on the other hand).
3253
3254         * WebView/WebView.mm:
3255         (-[WebView _selectionServiceController]):
3256         * WebView/WebViewData.h:
3257         * WebView/WebViewData.mm:
3258         * WebView/WebViewInternal.h:
3259         Keep a WebSelectionServiceController.
3260
3261 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3262
3263         Improve debug description of WAKViews
3264         https://bugs.webkit.org/show_bug.cgi?id=137716
3265
3266         Reviewed by Simon Fraser.
3267
3268         * WebView/WebView.mm:
3269         (-[WebView _touchEventRegions]): Adding a comment.
3270
3271 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3272
3273         Addressing post-review comment.
3274         https://bugs.webkit.org/show_bug.cgi?id=137550
3275
3276         Unreviewed.
3277
3278         * WebView/WebHTMLView.mm:
3279         (fontNameForDescription):
3280         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3281
3282 2014-10-14  Chris Dumez  <cdumez@apple.com>
3283
3284         Use is<>() / downcast<>() for RenderImage
3285         https://bugs.webkit.org/show_bug.cgi?id=137683
3286
3287         Reviewed by Mihnea Ovidenie.
3288
3289         Use is<>() / downcast<>() for RenderImage.
3290
3291         * Misc/WebNSPasteboardExtras.mm:
3292         (imageFromElement):
3293         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3294
3295 2014-10-10  Daniel Bates  <dabates@apple.com>
3296
3297         Remove unused classes WebRender{Node, Layer}
3298         https://bugs.webkit.org/show_bug.cgi?id=137628
3299
3300         Reviewed by Simon Fraser.
3301
3302         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
3303         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
3304
3305         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
3306         of excluded source files when building for iOS.
3307         * WebKit.exp: Remove symbol for WebRenderLayer.
3308         * WebKit.mac.exp: Remove symbol for WebRenderNode.
3309         * WebView/WebRenderLayer.h: Removed.
3310         * WebView/WebRenderLayer.mm: Removed.
3311         * WebView/WebRenderNode.h: Removed.
3312         * WebView/WebRenderNode.mm: Removed.
3313
3314 2014-10-10  Chris Dumez  <cdumez@apple.com>
3315
3316         Use is<>() / downcast<>() for RenderBoxModelObject
3317         https://bugs.webkit.org/show_bug.cgi?id=137587
3318
3319         Reviewed by Mihnea Ovidenie.
3320
3321         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
3322         surrounding code.
3323
3324         * Plugins/WebBaseNetscapePluginView.mm:
3325         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
3326         * WebView/WebRenderLayer.mm:
3327         (-[WebRenderLayer initWithWebFrame:]):
3328
3329 2014-10-09  Dean Jackson  <dino@apple.com>
3330
3331         Remove ENABLE_CSS3_CONDITIONAL_RULES
3332         https://bugs.webkit.org/show_bug.cgi?id=137571
3333
3334         Reviewed by Simon Fraser.
3335
3336         * Configurations/FeatureDefines.xcconfig:
3337
3338 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3339
3340         Add a WebKit1 preference for selection services
3341         https://bugs.webkit.org/show_bug.cgi?id=137498
3342         <rdar://problem/18572699>
3343
3344         Reviewed by Simon Fraser.
3345
3346         * WebView/WebPreferenceKeysPrivate.h:
3347         * WebView/WebPreferences.mm:
3348         (+[WebPreferences initialize]):
3349         (-[WebPreferences serviceControlsEnabled]):
3350         (-[WebPreferences setServiceControlsEnabled:]):
3351         * WebView/WebPreferencesPrivate.h:
3352         * WebView/WebView.mm:
3353         (-[WebView _preferencesChanged:]):
3354         Add and plumb the preference.
3355
3356 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
3357
3358         Remove second-to-last client of WebFontCache
3359         https://bugs.webkit.org/show_bug.cgi?id=137550
3360
3361         Reviewed by Darin Adler.
3362
3363         Use FontCache::getCachedFontData() instead of WebFontCache.
3364
3365         * WebView/WebHTMLView.mm:
3366         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3367
3368 2014-10-09  Chris Dumez  <cdumez@apple.com>
3369
3370         Use is<>() / downcast<>() for Widget subclasses
3371         https://bugs.webkit.org/show_bug.cgi?id=137549
3372
3373         Reviewed by Darin Adler.
3374
3375         Use is<>() / downcast<>() for Widget subclasses and clean up the
3376         surrounding code.
3377
3378         * WebView/WebRenderNode.mm:
3379         (copyRenderNode):
3380         * WebView/WebView.mm:
3381         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
3382
3383 2014-10-07  Christophe Dumez  <cdumez@apple.com>
3384
3385         Use is<>() / downcast<>() for RenderText / RenderTextFragment
3386         https://bugs.webkit.org/show_bug.cgi?id=137476
3387
3388         Reviewed by Darin Adler.
3389
3390         * WebView/WebRenderNode.mm:
3391         (copyRenderNode):
3392
3393 2014-10-06  Dan Bernstein  <mitz@apple.com>
3394
3395         Build fix.
3396
3397         * Misc/WebCache.mm:
3398         (+[WebCache imageForURL:]):
3399
3400 2014-10-06  Chris Dumez  <cdumez@apple.com>
3401
3402         Unreviewed build fix after r174333.
3403
3404         Forgot explicit WebCore:: namespace.
3405
3406         * Misc/WebCache.mm:
3407         (+[WebCache imageForURL:]):
3408
3409 2014-10-05  Christophe Dumez  <cdumez@apple.com>
3410
3411         Use is<>() / downcast<>() for CachedResource subclasses
3412         https://bugs.webkit.org/show_bug.cgi?id=137431
3413
3414         Reviewed by Benjamin Poulain.
3415
3416         Use is<>() / downcast<>() for CachedResource subclasses.
3417
3418         * Misc/WebCache.mm:
3419         (+[WebCache imageForURL:]):
3420
3421 2014-10-02  Daniel Bates  <dabates@apple.com>
3422
3423         Use version number 101000 instead of 10100 for OS X Yosemite
3424         https://bugs.webkit.org/show_bug.cgi?id=137372
3425
3426         Reviewed by Mark Rowe.
3427
3428         The version number for OS X Yosemite is 101000.
3429
3430         * WebView/WebView.mm:
3431         (-[WebView _preferencesChanged:]):
3432
3433 2014-10-02  Tim Horton  <timothy_horton@apple.com>
3434
3435         Move PageOverlay[Controller] to WebCore
3436         https://bugs.webkit.org/show_bug.cgi?id=137164
3437         <rdar://problem/18508258>
3438
3439         Reviewed by Anders Carlsson.
3440
3441         * WebCoreSupport/WebChromeClient.h:
3442         * WebCoreSupport/WebChromeClient.mm:
3443         (WebChromeClient::attachViewOverlayGraphicsLayer):
3444         Add an empty ChromeClient override.
3445
3446 2014-10-01  Christophe Dumez  <cdumez@apple.com>
3447
3448         Have is<>(T*) function do a null check on the pointer argument
3449         https://bugs.webkit.org/show_bug.cgi?id=137333
3450
3451         Reviewed by Gavin Barraclough.
3452
3453         Have is<>(T*) function do a null check on the argument instead of a
3454         simple assertion. This makes sense for 2 reasons:
3455         1. It is more consistent with downcast<>(T*), which will succeed even
3456            if the argument is a nullptr.
3457         2. It simplifies the code a bit as it gets rid of a lot of explicit
3458            null checks.
3459
3460         * WebCoreSupport/WebChromeClient.mm:
3461         (WebChromeClient::focusedElementChanged):
3462         * WebCoreSupport/WebEditorClient.mm:
3463         (WebEditorClient::textFieldDidBeginEditing):
3464         (WebEditorClient::textFieldDidEndEditing):
3465         (WebEditorClient::textDidChangeInTextField):
3466         (WebEditorClient::doTextFieldCommandFromEvent):
3467         (WebEditorClient::textWillBeDeletedInTextField):
3468         (WebEditorClient::textDidChangeInTextArea):
3469         * WebView/WebHTMLRepresentation.mm:
3470         (inputElementFromDOMElement):
3471         (searchForLabelsBeforeElement):
3472         * WebView/WebRenderLayer.mm:
3473         (+[WebRenderLayer nameForLayer:]):
3474
3475 2014-10-01  Mark Rowe  <mrowe@apple.com>
3476
3477         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3478
3479         Reviewed by Dan Bernstein.
3480
3481         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
3482
3483 2014-09-30  Chris Dumez  <cdumez@apple.com>
3484
3485         Use is<>() / downcast<>() for Element
3486         https://bugs.webkit.org/show_bug.cgi?id=137241
3487
3488         Reviewed by Andreas Kling.
3489
3490         Use is<>() / downcast<>() for Element instead of isElementNode() /
3491         toElement().
3492
3493         * WebView/WebRenderLayer.mm:
3494         (+[WebRenderLayer nameForLayer:]):
3495
3496 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3497
3498         Move ColorInputType class to std::unique_ptr
3499         https://bugs.webkit.org/show_bug.cgi?id=137173
3500
3501         Reviewed by Darin Adler.
3502
3503         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
3504         Child classes follow this change as well.
3505
3506         * WebCoreSupport/WebChromeClient.h:
3507         * WebCoreSupport/WebChromeClient.mm:
3508         (WebChromeClient::createColorChooser):
3509
3510 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3511
3512         Add initial is<>() / downcast<>() support for any type of Nodes
3513         https://bugs.webkit.org/show_bug.cgi?id=137056
3514
3515         Reviewed by Benjamin Poulain.
3516
3517         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
3518         instead of isFormControlElement() / toHTMLFormControlElement().
3519
3520         * WebView/WebHTMLRepresentation.mm:
3521         (searchForLabelsBeforeElement):
3522
3523 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3524
3525         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
3526         https://bugs.webkit.org/show_bug.cgi?id=137068
3527
3528         Reviewed by Ryosuke Niwa.
3529
3530         Start using is<HTML*Element>() instead of isHTML*Element().
3531         Remaining usages will be updated in a follow-up patch to
3532         reduce the size of the change.
3533
3534         * WebCoreSupport/WebChromeClient.mm:
3535         (WebChromeClient::focusedElementChanged):
3536         * WebCoreSupport/WebEditorClient.mm:
3537         (WebEditorClient::textFieldDidBeginEditing):
3538         (WebEditorClient::textFieldDidEndEditing):
3539         (WebEditorClient::textDidChangeInTextField):
3540         (WebEditorClient::doTextFieldCommandFromEvent):
3541         (WebEditorClient::textWillBeDeletedInTextField):
3542         (WebEditorClient::textDidChangeInTextArea):
3543         * WebView/WebHTMLRepresentation.mm:
3544         (inputElementFromDOMElement):
3545
3546 2014-09-21  Timothy Hatcher  <timothy@apple.com>
3547
3548         Make the Web Inspector use a separate web process.
3549
3550         https://bugs.webkit.org/show_bug.cgi?id=135120
3551
3552         Reviewed by Anders Carlsson.
3553
3554         * WebCoreSupport/WebInspectorClient.h:
3555         * WebCoreSupport/WebInspectorClient.mm:
3556         (WebInspectorClient::WebInspectorClient):
3557         (WebInspectorClient::openInspectorFrontend):
3558         (WebInspectorClient::releaseFrontend):
3559         Own WebInspectorFrontendClient instead of moving it.
3560
3561 2014-09-23  Chris Dumez  <cdumez@apple.com>
3562
3563         Use downcast<HTML*Element>() instead of toHTML*Element()
3564         https://bugs.webkit.org/show_bug.cgi?id=137007
3565
3566         Reviewed by Benjamin Poulain.
3567
3568         Use downcast<HTML*Element>() instead of toHTML*Element().
3569
3570         * DOM/WebDOMOperations.mm:
3571         (-[DOMHTMLInputElement _setAutofilled:]):
3572         * WebCoreSupport/WebChromeClient.mm:
3573         (WebChromeClient::focusedElementChanged):
3574         * WebCoreSupport/WebEditorClient.mm:
3575         (WebEditorClient::textFieldDidBeginEditing):
3576         (WebEditorClient::textFieldDidEndEditing):
3577         (WebEditorClient::textDidChangeInTextField):
3578         (WebEditorClient::doTextFieldCommandFromEvent):