1 2014-01-06 Mark Rowe <mrowe@apple.com>
3 <https://webkit.org/b/126499> Move WebKit off the legacy WebKit availability macros
5 The legacy WebKit availability macros are verbose, confusing, and provide no benefit
6 over using the system availability macros directly. The original vision was that
7 they'd serve a cross-platform purpose but that never came to be.
9 Since WebKit1 is API on OS X but SPI on iOS, some indirection is still needed in the
10 availability macros to allow the headers to advertise the API as unavailable on OS X
11 without interfering with the ability to build on iOS. This is achieved by defining
12 WEBKIT-prefixed versions of the Foundation availability macros that are defined to
13 their NS-prefixed equivalents. The installed headers are post-processed to map these
14 macros back to their Foundation equivalents.
16 Part of <rdar://problem/15512304>.
18 The OS X version used in the new availability macros is based on the mapping in
19 JavaScriptCore/WebKitAvailability.h.
21 Reviewed by Sam Weinig.
23 * Carbon/CarbonUtils.h:
25 * MigrateHeaders.make: Migrate WebKitAvailability.h from WebCore as an API header.
26 * Plugins/WebPlugin.h:
27 * Plugins/WebPluginViewFactory.h:
28 * WebView/WebFrameLoadDelegate.h:
29 * WebView/WebResourceLoadDelegatePrivate.h:
30 * WebView/WebUIDelegate.h:
31 * postprocess-headers.sh: Added. Extracted from the Xcode project. Extended to map the
32 WEBKIT-prefixed macros to their NS-prefixed equivalents on OS X and to remove them on iOS.
34 2014-01-04 Zan Dobersek <zdobersek@igalia.com>
36 Explicitly use the std:: nested name specifier when using std::pair, std::make_pair
37 https://bugs.webkit.org/show_bug.cgi?id=126439
39 Reviewed by Andreas Kling.
41 Instead of relying on std::pair and std::make_pair symbols being present in the current scope
42 through the pair and make_pair symbols, the std:: specifier should be used explicitly.
44 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
45 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
46 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
47 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
48 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
49 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
51 2014-01-02 Gavin Barraclough <barraclough@apple.com>
53 Remove WindowIsVisible
54 https://bugs.webkit.org/show_bug.cgi?id=126270
56 Reviewed by Tim Horton.
58 We currently track visibility in two ways - ViewState::IsVisible and ViewState::WindowIsVisible.
59 The latter detects that the content is hidden in fewer cases than the former, and as such, the
60 former is always preferable.
62 This affects the hidden state provided to FocusController::contentAreaDidShowOrHide and to
63 Plugin::windowVisibilityChanged.
66 (-[WebView _windowWillOrderOnScreen:]):
67 (-[WebView _windowWillOrderOffScreen:]):
68 - rename ContainingWindowIsVisible -> ContentIsVisible.
70 2014-01-02 Gavin Barraclough <barraclough@apple.com>
72 Merge didMoveOnscreen / page visibility to isVisible
73 https://bugs.webkit.org/show_bug.cgi?id=126268
75 Reviewed by Tim Horton.
77 The onscreen state most closely tracks view visibility (though currently
78 also tracks a mix of in-window state). Make more consistent, simplify,
79 and move all animation suspension logic to Page, so it can be controlled
83 (-[WebView _commonInitializationWithFrameName:groupName:]):
84 (-[WebView _updateVisibilityState]):
85 - _setVisibilityState:isInitialState: -> _setIsVisibile:isInitialState:.
86 (-[WebView _setIsVisible:isInitialState:]):
88 (-[WebView _setVisibilityState:isInitialState:]):
89 - setVisibilityState -> setIsVisible/setIsPrerender.
90 (-[WebView viewWillMoveToWindow:]):
91 (-[WebView viewDidMoveToWindow]):
92 - remove redundant calls to willMoveOffscreen/didMoveOnscreen
93 (this is handled by _updateVisibilityState).
95 2013-12-23 Oliver Hunt <oliver@apple.com>
97 Refactor PutPropertySlot to be aware of custom properties
98 https://bugs.webkit.org/show_bug.cgi?id=126187
100 Reviewed by Antti Koivisto.
102 Update for new method signatures.
104 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
105 (WebKit::NetscapePluginInstanceProxy::setProperty):
107 2013-12-31 Andy Estes <aestes@apple.com>
109 [iOS] Upstream PLATFORM(IOS) changes to Source/WebKit/
110 https://bugs.webkit.org/show_bug.cgi?id=125746
112 Reviewed by David Kilzer.
114 This is a straight upstreaming of the various PLATFORM(IOS) changes
115 made to Source/WebKit/ with the following modifications:
117 - Includes of <Cocoa/Cocoa.h> were generally replaced with an include
118 of <Foundation/Foundation.h> followed by an include of
119 <AppKit/AppKit.h> on non-iOS platforms. This assumes that nobody was
120 relying on <Cocoa/Cocoa.h>'s inclusion of <CoreData/CoreData.h>.
122 - Includes of <Cocoa/Cocoa.h> and <Foundation/Foundation.h> were
123 removed from files that include WebKitPrefix.h.
125 - Instances of 'iPhone (OS)' in comments were replaced with 'iOS', and
126 other sensitive terms were elided.
128 - Various PLATFORM(IOS) blocks were simplified. For instance:
145 * Configurations/Base.xcconfig:
146 * Configurations/DebugRelease.xcconfig:
147 * Configurations/Version.xcconfig:
148 * Configurations/WebKit.xcconfig:
149 * Configurations/iOS.xcconfig: Added.
150 * DOM/WebDOMOperations.mm:
151 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
152 * DefaultDelegates/WebDefaultEditingDelegate.m:
153 * DefaultDelegates/WebDefaultPolicyDelegate.m:
154 * DefaultDelegates/WebDefaultUIDelegate.h:
155 * DefaultDelegates/WebDefaultUIDelegate.m:
156 * History/WebBackForwardList.mm:
157 * History/WebHistory.mm:
158 * History/WebHistoryItem.mm:
159 * History/WebURLsWithTitles.m:
161 * Misc/WebDownload.mm:
162 * Misc/WebElementDictionary.mm:
163 * Misc/WebIconDatabase.mm:
164 * Misc/WebIconDatabaseInternal.h:
165 * Misc/WebKitNSStringExtras.mm:
166 * Misc/WebKitSystemBits.m:
167 * Misc/WebKitVersionChecks.h:
168 * Misc/WebKitVersionChecks.m:
169 * Misc/WebLocalizableStrings.mm:
170 * Misc/WebNSArrayExtras.h:
171 * Misc/WebNSArrayExtras.m:
172 * Misc/WebNSControlExtras.h:
173 * Misc/WebNSControlExtras.m:
174 * Misc/WebNSDictionaryExtras.h:
175 * Misc/WebNSDictionaryExtras.m:
176 * Misc/WebNSEventExtras.m:
177 * Misc/WebNSFileManagerExtras.mm:
178 * Misc/WebNSImageExtras.h:
179 * Misc/WebNSImageExtras.m:
180 * Misc/WebNSPasteboardExtras.mm:
181 * Misc/WebNSPrintOperationExtras.h:
182 * Misc/WebNSPrintOperationExtras.m:
183 * Misc/WebNSURLExtras.mm:
184 * Misc/WebNSViewExtras.m:
185 * Misc/WebNSWindowExtras.m:
186 * Panels/WebAuthenticationPanel.h:
187 * Panels/WebAuthenticationPanel.m:
188 * Panels/WebPanelAuthenticationHandler.m:
189 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
190 * Plugins/WebBasePluginPackage.h:
191 * Plugins/WebBasePluginPackage.mm:
192 * Plugins/WebJavaPlugIn.h:
193 * Plugins/WebPluginContainerCheck.mm:
194 * Plugins/WebPluginController.h:
195 * Plugins/WebPluginController.mm:
196 * Plugins/WebPluginDatabase.mm:
197 * Plugins/WebPluginPackage.mm:
198 * Plugins/WebPluginsPrivate.m:
199 * Storage/WebDatabaseManager.mm:
200 * Storage/WebDatabaseManagerClient.h:
201 * Storage/WebDatabaseManagerClient.mm:
202 * Storage/WebDatabaseManagerInternal.h: Added.
203 * Storage/WebStorageManager.mm:
204 * WebCoreSupport/CorrectionPanel.h:
205 * WebCoreSupport/WebAlternativeTextClient.h:
206 * WebCoreSupport/WebApplicationCache.mm:
207 * WebCoreSupport/WebChromeClient.h:
208 * WebCoreSupport/WebChromeClient.mm:
209 * WebCoreSupport/WebContextMenuClient.mm:
210 * WebCoreSupport/WebEditorClient.h:
211 * WebCoreSupport/WebEditorClient.mm:
212 * WebCoreSupport/WebFrameLoaderClient.h:
213 * WebCoreSupport/WebFrameLoaderClient.mm:
214 * WebCoreSupport/WebFrameNetworkingContext.h:
215 * WebCoreSupport/WebFrameNetworkingContext.mm:
216 * WebCoreSupport/WebGeolocationClient.h:
217 * WebCoreSupport/WebGeolocationClient.mm:
218 * WebCoreSupport/WebJavaScriptTextInputPanel.m:
219 * WebCoreSupport/WebKeyGenerator.mm:
220 * WebCoreSupport/WebNotificationClient.mm:
221 * WebCoreSupport/WebOpenPanelResultListener.mm:
222 * WebCoreSupport/WebSecurityOrigin.mm:
223 * WebCoreSupport/WebSystemInterface.mm:
225 * WebView/WebArchive.mm:
226 * WebView/WebClipView.h:
227 * WebView/WebDataSource.mm:
228 * WebView/WebDelegateImplementationCaching.h:
229 * WebView/WebDelegateImplementationCaching.mm:
230 * WebView/WebDeviceOrientation.mm:
231 * WebView/WebDocumentInternal.h:
232 * WebView/WebDocumentLoaderMac.mm:
233 * WebView/WebDynamicScrollBarsViewInternal.h:
234 * WebView/WebFormDelegate.m:
235 * WebView/WebFrame.mm:
236 * WebView/WebFrameInternal.h:
237 * WebView/WebFrameView.mm:
238 * WebView/WebFullScreenController.h:
239 * WebView/WebFullScreenController.mm:
240 * WebView/WebHTMLRepresentation.mm:
241 * WebView/WebHTMLView.mm:
242 * WebView/WebHTMLViewInternal.h:
243 * WebView/WebPDFDocumentExtras.h:
244 * WebView/WebPDFDocumentExtras.mm:
245 * WebView/WebPDFRepresentation.h:
246 * WebView/WebPDFRepresentation.mm:
247 * WebView/WebPDFView.h:
248 * WebView/WebPDFView.mm:
249 * WebView/WebPreferences.mm:
250 * WebView/WebResource.mm:
251 * WebView/WebTextCompletionController.h:
252 * WebView/WebTextIterator.mm:
253 * WebView/WebView.mm:
254 * WebView/WebViewData.h:
255 * WebView/WebViewData.mm:
256 * WebView/WebViewInternal.h:
258 2013-12-25 Commit Queue <commit-queue@webkit.org>
260 Unreviewed, rolling out r161033 and r161074.
261 http://trac.webkit.org/changeset/161033
262 http://trac.webkit.org/changeset/161074
263 https://bugs.webkit.org/show_bug.cgi?id=126240
265 Oliver says that a rollout would be better (Requested by ap on
268 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
269 (WebKit::NetscapePluginInstanceProxy::setProperty):
271 2013-12-23 Oliver Hunt <oliver@apple.com>
273 Refactor PutPropertySlot to be aware of custom properties
274 https://bugs.webkit.org/show_bug.cgi?id=126187
278 Update for new method signatures.
280 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
281 (WebKit::NetscapePluginInstanceProxy::setProperty):
283 2013-12-23 Lucas Forschler <lforschler@apple.com>
285 <rdar://problem/15682948> Update copyright strings
287 Reviewed by Dan Bernstein.
291 2013-12-19 Andy Estes <aestes@apple.com>
293 Remove WebFilterEvaluator wrappers from WebKitSystemInterface
294 https://bugs.webkit.org/show_bug.cgi?id=126028
296 Reviewed by Anders Carlsson.
298 * WebCoreSupport/WebSystemInterface.mm:
299 (InitWebCoreSystemInterface): Don't INIT() removed function pointers.
301 2013-12-17 Gavin Barraclough <barraclough@apple.com>
303 Remove PageVisibilityStateUnloaded
304 https://bugs.webkit.org/show_bug.cgi?id=125869
306 Reviewed by Anders Carlsson.
308 This is not currently supported by WebKit, remove this enum value.
309 We can always add this back later if/when we add support for this state.
311 * WebView/WebView.mm:
314 * WebView/WebViewPrivate.h:
315 - removed PageVisibilityStateUnloaded/WebPageVisibilityStateUnloade
317 2013-12-14 Andy Estes <aestes@apple.com>
319 [iOS] Upstream changes to WebKit Public and Private headers
320 https://bugs.webkit.org/show_bug.cgi?id=125745
322 Reviewed by Dan Bernstein.
324 * Configurations/WebKit.xcconfig: Ignore headers that are completely
325 excluded on iOS. This prevents empty headers from being installed into
327 * DOM/WebDOMOperationsPrivate.h: Upstream iOS changes.
328 * History/WebBackForwardListPrivate.h: Ditto.
329 * History/WebHistoryItem.h: Ditto.
330 * History/WebHistoryItemPrivate.h: Ditto.
331 * Misc/WebCache.h: Ditto.
332 * Misc/WebIconDatabase.h: Ditto.
333 * Misc/WebIconDatabasePrivate.h: Ditto.
334 * Misc/WebKitNSStringExtras.h: Ditto.
335 * Misc/WebLocalizableStrings.h: Ditto.
336 * Misc/WebNSEventExtras.h: Ditto.
337 * Misc/WebNSFileManagerExtras.h: Ditto.
338 * Misc/WebNSPasteboardExtras.h: Ditto.
339 * Misc/WebNSURLExtras.h: Ditto.
340 * Misc/WebNSViewExtras.h: Ditto.
341 * Misc/WebNSWindowExtras.h: Ditto.
342 * Panels/WebPanelAuthenticationHandler.h: Ditto.
343 * Plugins/WebPlugin.h: Ditto.
344 * Plugins/WebPluginContainer.h: Ditto.
345 * Plugins/WebPluginContainerPrivate.h: Ditto.
346 * Plugins/WebPluginDatabase.h: Ditto.
347 * Plugins/WebPluginPrivate.h: Ditto.
348 * Plugins/WebPluginViewFactory.h: Ditto.
349 * Plugins/WebPluginsPrivate.h: Ditto.
350 * Storage/WebDatabaseManagerPrivate.h: Ditto.
351 * WebCoreSupport/WebApplicationCache.h: Ditto.
352 * WebCoreSupport/WebJavaScriptTextInputPanel.h: Ditto.
353 * WebCoreSupport/WebKeyGenerator.h: Ditto.
354 * WebCoreSupport/WebSecurityOriginPrivate.h: Ditto.
355 * WebView/WebDashboardRegion.h: Ditto.
356 * WebView/WebDataSource.h: Ditto.
357 * WebView/WebDataSourcePrivate.h: Ditto.
358 * WebView/WebDocument.h: Ditto.
359 * WebView/WebDocumentPrivate.h: Ditto.
360 * WebView/WebDynamicScrollBarsView.h: Ditto.
361 * WebView/WebEditingDelegate.h: Ditto.
362 * WebView/WebEditingDelegatePrivate.h: Ditto.
363 * WebView/WebFormDelegate.h: Ditto.
364 * WebView/WebFrameLoadDelegate.h: Ditto.
365 * WebView/WebFramePrivate.h: Ditto.
366 * WebView/WebFrameView.h: Ditto.
367 * WebView/WebFrameViewPrivate.h: Ditto.
368 * WebView/WebHTMLRepresentation.h: Ditto.
369 * WebView/WebHTMLView.h: Ditto.
370 * WebView/WebHTMLViewPrivate.h: Ditto.
371 * WebView/WebPolicyDelegate.h: Ditto.
372 * WebView/WebPreferenceKeysPrivate.h: Ditto.
373 * WebView/WebPreferences.h: Ditto.
374 * WebView/WebPreferencesPrivate.h: Ditto.
375 * WebView/WebRenderLayer.h: Ditto.
376 * WebView/WebResourceLoadDelegatePrivate.h: Ditto.
377 * WebView/WebResourcePrivate.h: Ditto.
378 * WebView/WebUIDelegate.h: Ditto.
379 * WebView/WebUIDelegatePrivate.h: Ditto.
380 * WebView/WebView.h: Ditto.
381 * WebView/WebViewPrivate.h: Ditto.
383 2013-12-15 Andy Estes <aestes@apple.com>
385 [iOS] Upstream changes to FeatureDefines.xcconfig
386 https://bugs.webkit.org/show_bug.cgi?id=125742
388 Reviewed by Dan Bernstein.
390 * Configurations/FeatureDefines.xcconfig:
392 2013-12-14 Andy Estes <aestes@apple.com>
394 Unify FeatureDefines.xcconfig
395 https://bugs.webkit.org/show_bug.cgi?id=125741
397 Rubber-stamped by Dan Bernstein.
399 * Configurations/FeatureDefines.xcconfig: Remove a stray space in
402 2013-12-11 Joseph Pecoraro <pecoraro@apple.com>
404 Web Inspector: Push More Inspector Required Classes Down into JavaScriptCore
405 https://bugs.webkit.org/show_bug.cgi?id=125324
407 Reviewed by Timothy Hatcher.
409 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
410 * WebCoreSupport/WebInspectorClient.mm:
411 * WebView/WebFrame.mm:
412 * WebView/WebView.mm:
414 2013-12-03 Mark Rowe <mrowe@apple.com>
416 <https://webkit.org/b/125139> Modernize the WebKit API headers
417 <rdar://problem/15540175>
419 This consists of three main changes:
420 1) Converting the return type of initializer methods to instancetype.
421 2) Declaring properties rather than getters and setters.
422 3) Declaring explicitly sized enums.
424 Changing the declarations from getters and setters to properties also required
425 updating the headerdoc in a number of places.
427 Reviewed by Anders Carlsson.
429 * DOM/WebDOMOperations.h:
430 * History/WebBackForwardList.h:
431 * History/WebHistory.h:
432 * History/WebHistoryItem.h:
433 * History/WebHistoryItem.mm:
434 * Plugins/WebPlugin.h:
435 * Plugins/WebPluginContainer.h:
436 * WebView/WebArchive.h:
437 * WebView/WebArchive.mm:
438 * WebView/WebDataSource.h:
439 * WebView/WebDataSource.mm:
440 * WebView/WebEditingDelegate.h:
441 * WebView/WebFrame.h:
442 * WebView/WebFrame.mm:
443 * WebView/WebFrameView.h:
444 * WebView/WebPolicyDelegate.h:
445 * WebView/WebPreferences.h:
446 * WebView/WebPreferences.mm:
447 (-[WebPreferences cacheModel]): Cast to the enum.
448 * WebView/WebResource.h:
449 * WebView/WebResource.mm:
450 * WebView/WebUIDelegate.h:
452 * WebView/WebView.mm:
453 (+[WebView _didSetCacheModel]): Fix the return type.
455 2013-12-10 Mark Rowe <mrowe@apple.com>
457 <http://webkit.org/b/125556> WebKit doesn't deal with longer bundle versions correctly
458 <rdar://problem/15634192>
460 Reviewed by Dan Bernstein.
462 * WebView/WebView.mm:
463 (createUserVisibleWebKitVersionString): Strip as many leading digits as is necessary to
464 bring the major component of the version down to 3 digits.
466 2013-12-09 Sam Weinig <sam@webkit.org>
468 Fix the build of projects including <WebKit/WebUIDelegatePrivate.h>
470 Rubber-stamped by Dan Bernstein.
472 * WebView/WebAllowDenyPolicyListener.h:
473 Use TARGET_OS_IPHONE rather than PLATFORM(IOS) in an exposed header.
475 2013-12-05 Jer Noble <jer.noble@apple.com>
477 [MSE] Add a runtime-setting for the MediaSource constructor.
478 https://bugs.webkit.org/show_bug.cgi?id=125336
480 Reviewed by Eric Carlson.
482 Add a private WebPreference which controls the WebCore mediaSourceEnabled setting.
484 * WebView/WebPreferenceKeysPrivate.h:
485 * WebView/WebPreferences.mm:
486 (+[WebPreferences initialize]):
487 (-[WebPreferences mediaSourceEnabled]):
488 (-[WebPreferences setMediaSourceEnabled:]):
489 * WebView/WebPreferencesPrivate.h:
490 * WebView/WebView.mm:
491 (-[WebView _preferencesChanged:]):
493 2013-12-05 Mark Lam <mark.lam@apple.com>
495 C Loop LLINT layout test regressions.
496 https://bugs.webkit.org/show_bug.cgi?id=125314.
498 Reviewed by Geoffrey Garen.
500 The regression was due to the ENABLE_LLINT_C_LOOP flag not being included
501 in the build of the WebKit and WebKit2 components. As a result, some fields
502 in JSC::VM were ifdef'ed out in WebCore and JSC, but not in WebKit and
503 WebKit2. This resulted in VM::m_initializingObjectClass having 2 different
504 offsets depending on whether it is accessed from WebCore and JSC or from
505 WebKit and WebKit2, and chaos ensued.
507 This issue will manifest when we pass --cloop to build-webkit.
508 The fix is simply to add ENABLE_LLINT_C_LOOP to FEATURE_DEFINES for WebKit
511 * Configurations/FeatureDefines.xcconfig:
513 2013-12-04 Brian J. Burg <burg@cs.washington.edu>
515 Consolidate various frame snapshot capabilities.
516 https://bugs.webkit.org/show_bug.cgi?id=124325
518 Reviewed by Darin Adler.
520 Use new platform-independent methods instead of Mac methods.
522 * WebView/WebHTMLView.mm:
523 (-[WebHTMLView _selectionDraggingImage]):
524 (-[WebHTMLView selectionImageForcingBlackText:]):
526 2013-12-04 Andy Estes <aestes@apple.com>
528 [iOS] Build projects with $(ARCHS_STANDARD_32_64_BIT)
529 https://bugs.webkit.org/show_bug.cgi?id=125236
531 Reviewed by Sam Weinig.
533 $(ARCHS_STANDARD_32_64_BIT) is what we want for both device and simulator builds.
535 * Configurations/DebugRelease.xcconfig:
537 2013-12-03 Joseph Pecoraro <pecoraro@apple.com>
539 Web Inspector: Push Remote Inspector debugging connection management into JavaScriptCore
540 https://bugs.webkit.org/show_bug.cgi?id=124613
542 Reviewed by Timothy Hatcher.
544 Remove the old ENABLE(REMOTE_INSPECTOR) connection management implementation.
546 * WebCoreSupport/WebInspectorClient.h:
547 * WebCoreSupport/WebInspectorClient.mm:
548 (WebInspectorClient::indicate):
549 (WebInspectorClient::hideIndicate):
550 Hook up WebView indication through this new path.
552 * WebCoreSupport/WebFrameLoaderClient.mm:
553 (WebFrameLoaderClient::dispatchDidReceiveTitle):
554 * WebCoreSupport/WebInspectorClient.h:
555 * WebCoreSupport/WebInspectorClient.mm:
556 (WebInspectorClient::WebInspectorClient):
557 (WebInspectorClient::inspectorDestroyed):
558 * WebInspector/remote/WebInspectorClientRegistry.h: Removed.
559 * WebInspector/remote/WebInspectorClientRegistry.mm: Removed.
560 * WebInspector/remote/WebInspectorRelayDefinitions.h: Removed.
561 * WebInspector/remote/WebInspectorRemoteChannel.h: Removed.
562 * WebInspector/remote/WebInspectorRemoteChannel.mm: Removed.
563 * WebInspector/remote/WebInspectorServer.h: Removed.
564 * WebInspector/remote/WebInspectorServer.mm: Removed.
565 * WebInspector/remote/WebInspectorServerWebViewConnection.h: Removed.
566 * WebInspector/remote/WebInspectorServerWebViewConnection.mm: Removed.
567 * WebInspector/remote/WebInspectorServerWebViewConnectionController.h: Removed.
568 * WebInspector/remote/WebInspectorServerWebViewConnectionController.mm: Removed.
569 * WebInspector/remote/WebInspectorXPCWrapper.h: Removed.
570 * WebInspector/remote/WebInspectorXPCWrapper.m: Removed.
572 * WebView/WebView.mm:
573 (-[WebView _commonInitializationWithFrameName:groupName:]):
574 (+[WebView _enableRemoteInspector]):
575 (+[WebView _disableRemoteInspector]):
576 (+[WebView _disableAutoStartRemoteInspector]):
577 (+[WebView _isRemoteInspectorEnabled]):
578 (+[WebView _hasRemoteInspectorSession]):
579 (-[WebView allowsRemoteInspection]):
580 (-[WebView setAllowsRemoteInspection:]):
581 (-[WebView setIndicatingForRemoteInspector:]):
582 (-[WebView setHostApplicationBundleId:name:]):
583 (-[WebView _didCommitLoadForFrame:]):
584 * WebView/WebViewData.h:
585 * WebView/WebViewData.mm:
586 (-[WebViewPrivate init]):
587 (-[WebViewPrivate dealloc]):
588 * WebView/WebViewInternal.h:
589 * WebView/WebViewPrivate.h:
590 Remove old REMOTE_INSPECTOR.
592 2013-12-02 Chris Fleizach <cfleizach@apple.com>
594 AX: Crash in accessibilityRoot when Document goes away
595 https://bugs.webkit.org/show_bug.cgi?id=125113
597 Reviewed by Tim Horton.
599 The AXObjectCache can sometimes be null if the render tree has been detached from the document.
601 * WebView/WebFrame.mm:
602 (-[WebFrame accessibilityRoot]):
604 2013-11-28 Antti Koivisto <antti@apple.com>
606 Remove feature: CSS variables
607 https://bugs.webkit.org/show_bug.cgi?id=114119
609 Reviewed by Andreas Kling.
611 * Configurations/FeatureDefines.xcconfig:
613 2013-11-27 Sam Weinig <sam@webkit.org>
617 * WebView/WebAllowDenyPolicyListener.h: Added.
618 * WebView/WebUIDelegatePrivate.h:
619 Move the WebAllowDenyPolicyListener protocol to its own file.
621 2013-11-21 Mark Rowe <mrowe@apple.com>
623 <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
625 All modern versions of Xcode set it appropriately for our needs.
627 Reviewed by Alexey Proskuryakov.
629 * Configurations/Base.xcconfig:
631 2013-11-21 Mark Rowe <mrowe@apple.com>
633 <https://webkit.org/b/124701> Fix an error in a few Xcode configuration setting files.
635 Reviewed by Alexey Proskuryakov.
637 * Configurations/Base.xcconfig:
639 2013-11-21 Mark Rowe <mrowe@apple.com>
641 <https://webkit.org/b/124700> Fix some deprecation warnings.
643 Reviewed by Anders Carlsson.
645 * Plugins/WebNetscapePluginStream.mm:
646 (WebNetscapePluginStream::startStream): Move off a deprecated NSData method.
647 * WebView/WebDataSource.mm:
648 (-[WebDataSource _fileWrapperForURL:]): Move off a deprecated NSFileWrapper method.
649 * WebView/WebHTMLView.mm:
650 (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
652 2013-11-20 Mark Lam <mark.lam@apple.com>
654 Introducing VMEntryScope to update the VM stack limit.
655 https://bugs.webkit.org/show_bug.cgi?id=124634.
657 Reviewed by Geoffrey Garen.
659 * WebView/WebScriptDebugger.mm:
660 (WebScriptDebugger::sourceParsed):
662 2013-11-19 Ryosuke Niwa <rniwa@webkit.org>
664 Enable HTMLTemplateElement on Mac port
665 https://bugs.webkit.org/show_bug.cgi?id=124637
667 Reviewed by Tim Horton.
669 * Configurations/FeatureDefines.xcconfig:
671 2013-11-18 Commit Queue <commit-queue@webkit.org>
673 Unreviewed, rolling out r159455.
674 http://trac.webkit.org/changeset/159455
675 https://bugs.webkit.org/show_bug.cgi?id=124568
677 broke two api tests (see bug 124564) (Requested by thorton on
680 * WebView/WebHTMLView.mm:
681 (-[WebHTMLView _selectionDraggingImage]):
682 (-[WebHTMLView selectionImageForcingBlackText:]):
684 2013-11-18 Mark Rowe <mrowe@apple.com>
686 Disable deprecation warnings related to NSCalendarDate in WebHistory.
688 Reviewed by Anders Carlsson.
690 * History/WebHistory.h: Use a #pragma to have the compiler treat this header as
691 a system header, even when not included from a system location. This has the effect
692 of suppressing warnings when including this header. It's a more general effect than
693 we're after but is also less invasive than disabling deprecation warnings around
694 the APIs that are defined in terms of NSCalendarDate. We'll hopefully revisit this
696 * History/WebHistory.mm: Disable deprecation warnings around uses of NSCalendarDate.
698 2013-11-18 David Hyatt <hyatt@apple.com>
700 Add a quirk to not respect center text-align when positioning
702 <rdar://problem/15427571>
703 https://bugs.webkit.org/show_bug.cgi?id=124522
705 Reviewed by Simon Fraser.
707 Added fast/block/legacy-text-align-position-quirk.html
709 * WebView/WebPreferenceKeysPrivate.h:
710 * WebView/WebPreferences.mm:
711 (+[WebPreferences initialize]):
712 (-[WebPreferences useLegacyTextAlignPositionedElementBehavior]):
713 (-[WebPreferences setUseLegacyTextAlignPositionedElementBehavior:]):
714 * WebView/WebPreferencesPrivate.h:
715 * WebView/WebView.mm:
716 (-[WebView _preferencesChanged:]):
718 2013-11-18 Brian J. Burg <burg@cs.washington.edu>
720 Consolidate various frame snapshot capabilities.
721 https://bugs.webkit.org/show_bug.cgi?id=124325
723 Reviewed by Timothy Hatcher.
725 Use new platform-independent methods instead of Mac methods.
727 * WebView/WebHTMLView.mm:
728 (-[WebHTMLView _selectionDraggingImage]):
729 (-[WebHTMLView selectionImageForcingBlackText:]):
731 2013-11-18 Anders Carlsson <andersca@apple.com>
733 Remove unnecessary COMPILER(CLANG) #ifdefs in Mac-only code
734 https://bugs.webkit.org/show_bug.cgi?id=124523
736 Reviewed by Dan Bernstein.
738 * Plugins/Hosted/NetscapePluginHostManager.mm:
739 (WebKit::NetscapePluginHostManager::spawnPluginHost):
740 (WebKit::NetscapePluginHostManager::didCreateWindow):
741 * Plugins/Hosted/NetscapePluginHostProxy.mm:
742 (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
743 (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess):
744 (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess):
746 2013-11-18 Anders Carlsson <andersca@apple.com>
748 Ignore deprecation warnings for now.
750 * History/WebHistory.h:
752 2013-11-14 Anders Carlsson <andersca@apple.com>
754 Reimplement getDayBoundaries using NSCalendar on 10.9
755 https://bugs.webkit.org/show_bug.cgi?id=124379
757 Reviewed by Dan Bernstein.
759 * History/WebHistory.mm:
762 2013-11-14 Anders Carlsson <andersca@apple.com>
764 Stop using deprecated NSPropertyListSerialization methods
765 https://bugs.webkit.org/show_bug.cgi?id=124377
767 Reviewed by Mark Rowe.
769 * History/WebHistory.mm:
770 (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
771 * Plugins/Hosted/NetscapePluginHostManager.mm:
772 (WebKit::NetscapePluginHostManager::spawnPluginHost):
773 (WebKit::NetscapePluginHostManager::instantiatePlugin):
774 * Plugins/Hosted/NetscapePluginHostProxy.mm:
775 (WKPCIdentifierInfo):
776 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
777 (WebKit::NetscapePluginInstanceProxy::enumerate):
778 (WebKit::NetscapePluginInstanceProxy::marshalValue):
779 (WebKit::NetscapePluginInstanceProxy::marshalValues):
780 (WebKit::NetscapePluginInstanceProxy::demarshalValue):
781 (WebKit::NetscapePluginInstanceProxy::demarshalValues):
782 * Plugins/Hosted/ProxyInstance.mm:
783 (WebKit::ProxyInstance::getPropertyNames):
785 2013-11-13 Joseph Pecoraro <pecoraro@apple.com>
787 Unreviewed rollout of r159271, broke Mountain Lion build.
789 * History/WebHistory.h:
790 * History/WebHistory.mm:
792 2013-11-13 Anders Carlsson <andersca@apple.com>
794 Deprecate WebHistory methods that use NSCalendarDate
795 https://bugs.webkit.org/show_bug.cgi?id=124329
796 <rdar://problem/15441122>
798 Reviewed by Mark Rowe.
800 * History/WebHistory.h:
801 Add NS_DEPRECATED_MAC to orderedLastVisitedDays and orderedItemsLastVisitedOnDay:.
802 In order to not break the Mountain Lion build, define __NSd_10_9 if necessary.
804 * History/WebHistory.mm:
805 Ignore deprecation warnings in methods where NSCalendarDate is used.
807 2013-11-13 Gordon Sheridan <gordon_sheridan@apple.com>
809 Removed deprecated download delegates.
810 https://bugs.webkit.org/show_bug.cgi?id=124309
811 <rdar://problem/13570414>
813 Reviewed by Anders Carlsson.
815 * Misc/WebDownload.mm:
816 (-[WebDownloadInternal respondsToSelector:]):
817 Removed download:shouldBeginChildDownloadOfSource:delegate and
818 download:didBeginChildDownload.
820 2013-11-12 Alexey Proskuryakov <ap@apple.com>
822 Disable WebCrypto on Mountain Lion
823 https://bugs.webkit.org/show_bug.cgi?id=124261
825 Rubber-stamped by Sam Weinig.
827 * Configurations/FeatureDefines.xcconfig:
829 2013-11-12 Andy Estes <aestes@apple.com>
831 [Mac] Fix some deprecation warnings
832 https://bugs.webkit.org/show_bug.cgi?id=124252
834 Reviewed by Mark Rowe.
836 * Plugins/WebBasePluginPackage.mm:
837 (-[WebBasePluginPackage pListForPath:createFile:]): Use +[NSPropertyListSerialization propertyListWithData:options:format:error:] instead of +[NSPropertyListSerialization propertyListFromData:mutabilityOption:format:errorDescription:].
839 2013-11-12 Anders Carlsson <andersca@apple.com>
841 Remove -[WebHistoryItem _lastVisitedDate]
842 https://bugs.webkit.org/show_bug.cgi?id=124250
844 Reviewed by Mark Rowe.
846 This method is not called by anyone and NSCalendarDate is deprecated so get rid of it.
848 * History/WebHistoryItem.mm:
849 * History/WebHistoryItemPrivate.h:
851 2013-11-11 Anders Carlsson <andersca@apple.com>
853 FrameFilter can just be an std::function instead
854 https://bugs.webkit.org/show_bug.cgi?id=124176
856 Reviewed by Tim Horton.
858 * DOM/WebDOMOperations.mm:
859 (-[DOMNode webArchiveByFilteringSubframes:]):
861 2013-11-11 Dan Bernstein <mitz@apple.com>
863 [Mac] .exp files are not source code
864 https://bugs.webkit.org/show_bug.cgi?id=124154
866 Reviewed by Andy Estes.
868 * Configurations/WebKit.xcconfig: Removed WebKit.iOS.exp from
869 EXCLUDED_SOURCE_FILE_NAMES_macosx.
871 2013-11-09 Patrick Gansterer <paroga@webkit.org>
873 Move RunLoop from WebCore to WTF
874 https://bugs.webkit.org/show_bug.cgi?id=116606
876 Reviewed by Anders Carlsson.
878 * Carbon/CarbonWindowAdapter.mm:
879 (+[CarbonWindowAdapter initialize]):
880 * History/WebBackForwardList.mm:
881 (+[WebBackForwardList initialize]):
882 * History/WebHistoryItem.mm:
883 (+[WebHistoryItem initialize]):
885 (+[WebCache initialize]):
886 * Misc/WebElementDictionary.mm:
887 (+[WebElementDictionary initialize]):
888 * Misc/WebIconDatabase.mm:
889 (+[WebIconDatabase initialize]):
890 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
891 (+[WebHostedNetscapePluginView initialize]):
892 * Plugins/WebBaseNetscapePluginView.mm:
893 * Plugins/WebBasePluginPackage.mm:
894 * Plugins/WebNetscapePluginView.mm:
895 (+[WebNetscapePluginView initialize]):
896 * WebCoreSupport/WebEditorClient.mm:
897 (+[WebUndoStep initialize]):
898 * WebCoreSupport/WebFrameLoaderClient.mm:
899 * WebView/WebArchive.mm:
900 (+[WebArchivePrivate initialize]):
901 * WebView/WebDataSource.mm:
902 (+[WebDataSource initialize]):
903 * WebView/WebHTMLView.mm:
904 (+[WebHTMLViewPrivate initialize]):
905 (+[WebHTMLView initialize]):
906 * WebView/WebPreferences.mm:
907 (+[WebPreferences initialize]):
908 * WebView/WebResource.mm:
909 (+[WebResourcePrivate initialize]):
910 * WebView/WebTextIterator.mm:
911 (+[WebTextIteratorPrivate initialize]):
912 * WebView/WebView.mm:
913 (+[WebView initialize]):
914 * WebView/WebViewData.mm:
915 (+[WebViewPrivate initialize]):
917 2013-11-08 Mark Lam <mark.lam@apple.com>
919 Move breakpoint (and exception break) functionality into JSC::Debugger.
920 https://bugs.webkit.org/show_bug.cgi?id=121796.
922 Reviewed by Geoffrey Garen.
924 * WebView/WebScriptDebugger.h:
925 * WebView/WebScriptDebugger.mm:
926 (WebScriptDebugger::WebScriptDebugger):
927 (WebScriptDebugger::handlePause):
929 2013-11-07 Joseph Pecoraro <pecoraro@apple.com>
931 Remove a PLATFORM(IOS) from WebKit Private Header
932 https://bugs.webkit.org/show_bug.cgi?id=124014
934 Reviewed by Timothy Hatcher.
936 Make the previously iOS only WebInspectorDidStartSearchingForNode
937 and WebInspectorDidStopSearchingForNode notifications non iOS specific.
939 * WebCoreSupport/WebInspectorClient.h:
940 * WebCoreSupport/WebInspectorClient.mm:
941 (WebInspectorClient::didSetSearchingForNode):
942 * WebInspector/WebInspector.h:
943 * WebInspector/WebInspector.mm:
946 2013-11-07 Mark Lam <mark.lam@apple.com>
948 Cosmetic: rename xxxId to xxxID for ScriptId, SourceId, and BreakpointId.
949 https://bugs.webkit.org/show_bug.cgi?id=123945.
951 Reviewed by Geoffrey Garen.
953 * WebView/WebScriptDebugger.mm:
954 (WebScriptDebugger::exception):
956 2013-11-06 Daniel Bates <dabates@apple.com>
958 [iOS] Upstream Letterpress effect
959 https://bugs.webkit.org/show_bug.cgi?id=123932
961 Reviewed by Sam Weinig.
963 Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
966 * Configurations/FeatureDefines.xcconfig:
968 2013-11-04 Alexey Proskuryakov <ap@apple.com>
970 DumpRenderTree should reset its preferences file on launch
971 https://bugs.webkit.org/show_bug.cgi?id=29751
973 Reviewed by Dan Bernstein.
975 * WebView/WebView.mm:
976 (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
977 Further fix reading of AppleKeyboardUIMode - reading it from kCFPreferencesAnyApplication
978 domain meant that current application's domain was explcitly ignored, and the only
979 way to override the setting in DRT was through argument domain.
981 2013-11-01 Jer Noble <jer.noble@apple.com>
983 [PluginProxy] Add a setting to disable video plugin proxy support in HTMLMediaElement.
984 https://bugs.webkit.org/show_bug.cgi?id=123621
986 Reviewed by Eric Carlson.
988 Add a new isVideoPluginProxyEnabled setting.
990 * WebView/WebPreferenceKeysPrivate.h:
991 * WebView/WebPreferences.mm:
992 (+[WebPreferences initialize]): Set isVideoPluginProxyEnabled preference.
993 (-[WebPreferences isVideoPluginProxyEnabled]): Pass through to Settings.
994 * WebView/WebPreferencesPrivate.h:
995 * WebView/WebView.mm:
996 (-[WebView _preferencesChanged:]): Set isVideoPluginProxyEnabled preference.
998 2013-11-01 Andy Estes <aestes@apple.com>
1000 [iOS] Make some headers Private
1001 https://bugs.webkit.org/show_bug.cgi?id=123626
1003 Reviewed by Andreas Kling.
1005 * Configurations/WebKit.xcconfig: Exclude iOS Private headers from the Mac build.
1007 2013-10-31 Alexey Proskuryakov <ap@apple.com>
1009 Enable WebCrypto on Mac
1010 https://bugs.webkit.org/show_bug.cgi?id=123587
1012 Reviewed by Anders Carlsson.
1014 * Configurations/FeatureDefines.xcconfig: Do it.
1016 2013-10-30 Ryosuke Niwa <rniwa@webkit.org>
1018 Remove code for Mac Lion
1019 https://bugs.webkit.org/show_bug.cgi?id=123542
1021 Reviewed by Anders Carlsson.
1023 * WebView/WebHTMLView.mm:
1024 (-[WebHTMLView attachRootLayer:]):
1025 * WebView/WebView.mm:
1027 2013-10-29 Andy Estes <aestes@apple.com>
1029 [iOS] Upstream Source/WebKit/ios/
1030 https://bugs.webkit.org/show_bug.cgi?id=123470
1032 Reviewed by Sam Weinig.
1034 * Configurations/WebKit.xcconfig: Excluded some iOS files from the Mac build.
1036 2013-10-29 Alexey Proskuryakov <ap@apple.com>
1038 Result of focus-option-control-on-page.html depends on system preferences
1039 https://bugs.webkit.org/show_bug.cgi?id=123304
1041 Reviewed by Simon Fraser.
1043 * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1044 Read the preference from its correct domain. This doesn't affect behavior in practice
1045 and isn't part of the fix, but it's a good opportunity to correct this code.
1047 2013-10-29 Jer Noble <jer.noble@apple.com>
1049 [MSE] [Mac] Enable MediaSource on the Mac
1050 https://bugs.webkit.org/show_bug.cgi?id=122484
1052 Reviewed by Darin Adler.
1054 Enable ENABLE_MEDIA_SOURCE.
1056 * Configurations/FeatureDefines.xcconfig:
1058 2013-10-28 Joseph Pecoraro <pecoraro@apple.com>
1060 Upstream remaining PLATFORM(IOS) and ENABLE(REMOTE_INSPECTOR) pieces
1061 https://bugs.webkit.org/show_bug.cgi?id=123411
1063 Reviewed by Timothy Hatcher.
1065 Upstream iOS node highlighting and view indication.
1067 * WebCoreSupport/WebInspectorClient.h:
1068 * WebInspector/WebInspector.h:
1069 * WebInspector/WebInspector.mm:
1070 * WebInspector/WebNodeHighlight.h:
1071 * WebInspector/WebNodeHighlight.mm:
1072 (-[WebHighlightLayer initWithHighlightView:webView:]):
1073 (-[WebHighlightLayer layoutSublayers]):
1074 (-[WebHighlightLayer actionForKey:]):
1075 (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1076 (-[WebNodeHighlight dealloc]):
1077 (-[WebNodeHighlight attach]):
1078 * WebInspector/WebNodeHighlightView.h:
1079 * WebInspector/WebNodeHighlightView.mm:
1080 (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1081 (-[WebNodeHighlightView dealloc]):
1082 (-[WebNodeHighlightView _attach:numLayers:]):
1083 (findIntersectionOnLineBetweenPoints):
1085 (layerPathWithHole):
1087 (-[WebNodeHighlightView _layoutForNodeHighlight:parent:]):
1088 (-[WebNodeHighlightView _layoutForRectsHighlight:parent:]):
1089 (-[WebNodeHighlightView layoutSublayers:]):
1090 * WebInspector/WebNodeHighlighter.mm:
1091 (-[WebNodeHighlighter highlight]):
1092 * WebView/WebIndicateLayer.h: Added.
1093 * WebView/WebIndicateLayer.mm: Added.
1094 (-[WebIndicateLayer layoutSublayers]):
1095 (-[WebIndicateLayer actionForKey:]):
1096 * WebView/WebView.mm:
1097 (-[WebView setIndicatingForRemoteInspector:]):
1098 (-[WebView setHostApplicationBundleId:name:]):
1099 (-[WebView hostApplicationBundleId]):
1100 (-[WebView hostApplicationName]):
1101 * WebView/WebViewData.h:
1102 * WebView/WebViewData.mm:
1103 (-[WebViewPrivate dealloc]):
1105 2013-10-28 Myles C. Maxfield <mmaxfield@apple.com>
1107 Parsing support for -webkit-text-decoration-skip: ink
1108 https://bugs.webkit.org/show_bug.cgi?id=123358
1110 Reviewed by Dean Jackson.
1112 Adding ENABLE(CSS3_TEXT_DECORATION)
1114 * Configurations/FeatureDefines.xcconfig:
1116 2013-10-25 Joseph Pecoraro <pecoraro@apple.com>
1118 Upstream ENABLE(REMOTE_INSPECTOR) and enable on iOS and Mac
1119 https://bugs.webkit.org/show_bug.cgi?id=123111
1121 Reviewed by Timothy Hatcher.
1123 The actual implementation at the WebCoreSupport/WebInspectorClient level
1124 is the same as INSPECTOR_SERVER. Give debuggable pages a pageIdentifer.
1126 * Configurations/FeatureDefines.xcconfig:
1127 * Misc/WebKitLogging.h:
1130 * WebCoreSupport/WebInspectorClient.h:
1131 (WebInspectorClient::pageId):
1132 (WebInspectorClient::setPageId):
1133 Give WebInspectorClient's a page identifier.
1135 * WebCoreSupport/WebInspectorClient.mm:
1136 (WebInspectorClient::WebInspectorClient):
1137 (WebInspectorClient::inspectorDestroyed):
1138 (WebInspectorClient::sendMessageToFrontend):
1139 (WebInspectorClient::sendMessageToBackend):
1140 (WebInspectorClient::setupRemoteConnection):
1141 (WebInspectorClient::teardownRemoteConnection):
1142 (WebInspectorClient::hasLocalSession):
1143 (WebInspectorClient::canBeRemotelyInspected):
1144 (WebInspectorClient::inspectedWebView):
1145 A WebInspectorClient can be either local or remote. Add handling
1146 for remote connections.
1148 * WebInspector/remote/WebInspectorClientRegistry.h: Added.
1149 * WebInspector/remote/WebInspectorClientRegistry.mm: Added.
1150 (+[WebInspectorClientRegistry sharedRegistry]):
1151 (-[WebInspectorClientRegistry init]):
1152 (-[WebInspectorClientRegistry _getNextAvailablePageId]):
1153 (-[WebInspectorClientRegistry registerClient:]):
1154 (-[WebInspectorClientRegistry unregisterClient:]):
1155 (-[WebInspectorClientRegistry clientForPageId:]):
1156 (-[WebInspectorClientRegistry inspectableWebViews]):
1157 Registry for all potentially debuggable pages. All WebInspectorClient instances.
1159 * WebInspector/remote/WebInspectorRelayDefinitions.h: Added.
1160 Constants (message keys) shared between WebKit and the XPC process.
1162 * WebInspector/remote/WebInspectorServer.h: Added.
1163 * WebInspector/remote/WebInspectorServer.mm: Added.
1164 (-[WebInspectorServer init]):
1165 (-[WebInspectorServer dealloc]):
1166 (-[WebInspectorServer start]):
1167 (-[WebInspectorServer stop]):
1168 (-[WebInspectorServer isEnabled]):
1169 (-[WebInspectorServer xpcConnection]):
1170 (-[WebInspectorServer setupXPCConnectionIfNeeded]):
1171 (-[WebInspectorServer pushListing]):
1172 (-[WebInspectorServer hasActiveDebugSession]):
1173 (-[WebInspectorServer setHasActiveDebugSession:]):
1174 (-[WebInspectorServer xpcConnection:receivedMessage:userInfo:]):
1175 (-[WebInspectorServer xpcConnectionFailed:]):
1176 (-[WebInspectorServer didRegisterClient:]):
1177 (-[WebInspectorServer didUnregisterClient:]):
1178 Singleton to start/stop remote inspection. Handles the connection to the XPC
1179 and hands off connections to the connection controller.
1181 * WebInspector/remote/WebInspectorServerWebViewConnection.h: Added.
1182 * WebInspector/remote/WebInspectorServerWebViewConnection.mm: Added.
1183 (-[WebInspectorServerWebViewConnection initWithController:connectionIdentifier:destination:identifier:]):
1184 (-[WebInspectorServerWebViewConnection setupChannel]):
1185 (-[WebInspectorServerWebViewConnection dealloc]):
1186 (-[WebInspectorServerWebViewConnection connectionIdentifier]):
1187 (-[WebInspectorServerWebViewConnection identifier]):
1188 (-[WebInspectorServerWebViewConnection clearChannel]):
1189 (-[WebInspectorServerWebViewConnection sendMessageToFrontend:]):
1190 (-[WebInspectorServerWebViewConnection sendMessageToBackend:]):
1191 (-[WebInspectorServerWebViewConnection receivedData:]):
1192 (-[WebInspectorServerWebViewConnection receivedDidClose:]):
1193 An individual remote debug session connection.
1195 * WebInspector/remote/WebInspectorServerWebViewConnectionController.h: Added.
1196 * WebInspector/remote/WebInspectorServerWebViewConnectionController.mm: Added.
1197 (-[WebInspectorServerWebViewConnectionController initWithServer:]):
1198 (-[WebInspectorServerWebViewConnectionController dealloc]):
1199 (-[WebInspectorServerWebViewConnectionController closeAllConnections]):
1200 (-[WebInspectorServerWebViewConnectionController _listingForWebView:pageId:registry:]):
1201 (-[WebInspectorServerWebViewConnectionController _pushListing:]):
1202 (-[WebInspectorServerWebViewConnectionController pushListing:]):
1203 (-[WebInspectorServerWebViewConnectionController pushListing]):
1204 (-[WebInspectorServerWebViewConnectionController _receivedSetup:]):
1205 (-[WebInspectorServerWebViewConnectionController _receivedData:]):
1206 (-[WebInspectorServerWebViewConnectionController _receivedDidClose:]):
1207 (-[WebInspectorServerWebViewConnectionController _receivedGetListing:]):
1208 (-[WebInspectorServerWebViewConnectionController _receivedIndicate:]):
1209 (-[WebInspectorServerWebViewConnectionController _receivedConnectionDied:]):
1210 (-[WebInspectorServerWebViewConnectionController receivedMessage:userInfo:]):
1211 (-[WebInspectorServerWebViewConnectionController connectionClosing:]):
1212 (-[WebInspectorServerWebViewConnectionController sendMessageToFrontend:userInfo:]):
1213 ConnectionController:
1214 - Holds all the current ongoing remote debug connections.
1215 - Simplifies multi-threaded work on iOS.
1216 - Dispatches incoming messages from the remote connection.
1218 * WebInspector/remote/WebInspectorRemoteChannel.h: Added.
1219 * WebInspector/remote/WebInspectorRemoteChannel.mm: Added.
1220 (+[WebInspectorRemoteChannel createChannelForPageId:connection:]):
1221 (-[WebInspectorRemoteChannel initWithRemote:local:]):
1222 (-[WebInspectorRemoteChannel closeFromLocalSide]):
1223 (-[WebInspectorRemoteChannel closeFromRemoteSide]):
1224 (-[WebInspectorRemoteChannel sendMessageToFrontend:]):
1225 (-[WebInspectorRemoteChannel sendMessageToBackend:]):
1226 Thin interface between the remote connection and web inspector client.
1227 This simplifies breaking the connection from either side, e.g. the
1228 page closing, or the remote connection disconnecting.
1230 * WebInspector/remote/WebInspectorXPCWrapper.h: Added.
1231 * WebInspector/remote/WebInspectorXPCWrapper.m: Added.
1232 (-[WebInspectorXPCWrapper initWithConnection:]):
1233 (-[WebInspectorXPCWrapper close]):
1234 (-[WebInspectorXPCWrapper dealloc]):
1235 (-[WebInspectorXPCWrapper _deserializeMessage:]):
1236 (-[WebInspectorXPCWrapper _handleEvent:]):
1237 (-[WebInspectorXPCWrapper sendMessage:userInfo:]):
1238 (-[WebInspectorXPCWrapper available]):
1240 XPC Connection wrapper handling a simple message format.
1242 * WebView/WebViewData.h:
1243 * WebView/WebViewData.mm:
1244 (-[WebViewPrivate init]):
1245 (-[WebViewPrivate dealloc]):
1246 * WebView/WebViewInternal.h:
1247 * WebView/WebViewPrivate.h:
1248 * WebView/WebView.mm:
1249 (-[WebView _commonInitializationWithFrameName:groupName:]):
1250 (+[WebView sharedWebInspectorServer]):
1251 (+[WebView _enableRemoteInspector]):
1252 (+[WebView _disableRemoteInspector]):
1253 (+[WebView _disableAutoStartRemoteInspector]):
1254 (+[WebView _isRemoteInspectorEnabled]):
1255 (+[WebView _hasRemoteInspectorSession]):
1256 (-[WebView canBeRemotelyInspected]):
1257 (-[WebView allowsRemoteInspection]):
1258 (-[WebView setAllowsRemoteInspection:]):
1259 (-[WebView setIndicatingForRemoteInspector:]):
1260 (-[WebView setRemoteInspectorUserInfo:]):
1261 (-[WebView remoteInspectorUserInfo]):
1262 Remote inspector private API.
1263 - Enable / disable globally
1264 - Allow / disallow per webview
1265 - Optionally attach a userInfo dictionary on the WebView that is published with listing.
1266 - Indicate a WebView (implementation to land later)
1268 (-[WebView _didCommitLoadForFrame:]):
1269 * WebCoreSupport/WebFrameLoaderClient.mm:
1270 (WebFrameLoaderClient::dispatchDidReceiveTitle):
1271 Pages changed, pushed page listing.
1273 2013-10-25 Mark Rowe <mrowe@apple.com>
1275 Fix or disable some deprecation warnings.
1277 Reviewed by Darin Adler.
1279 * Panels/WebAuthenticationPanel.m:
1280 (-[WebAuthenticationPanel cancel:]): On newer OS versions, use the modern API.
1281 (-[WebAuthenticationPanel logIn:]): Ditto.
1282 (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]): Ditto. Translate the
1283 response code in to the form that -sheetDidEnd:responseCode:contextInfo: expects.
1284 * WebView/WebClipView.mm:
1285 (-[WebClipView initWithFrame:]): Disable deprecation warnings since it's not obvious
1286 how to avoid calling -releaseGState here.
1288 2013-10-24 Mark Rowe <mrowe@apple.com>
1290 Remove references to OS X 10.7 from Xcode configuration settings.
1292 Now that we're not building for OS X 10.7 they're no longer needed.
1294 Reviewed by Anders Carlsson.
1296 * Configurations/Base.xcconfig:
1297 * Configurations/DebugRelease.xcconfig:
1298 * Configurations/FeatureDefines.xcconfig:
1299 * Configurations/Version.xcconfig:
1301 2013-10-24 Mark Rowe <mrowe@apple.com>
1303 <rdar://problem/15312643> Prepare for the mysterious future.
1305 Reviewed by David Kilzer.
1307 * Configurations/Base.xcconfig:
1308 * Configurations/DebugRelease.xcconfig:
1309 * Configurations/FeatureDefines.xcconfig:
1310 * Configurations/Version.xcconfig:
1312 2013-10-24 Anders Carlsson <andersca@apple.com>
1314 Stop bringing in the std namespace
1315 https://bugs.webkit.org/show_bug.cgi?id=123273
1317 Reviewed by Andreas Kling.
1319 * WebView/WebFrameView.mm:
1320 (-[WebFrameView _verticalPageScrollDistance]):
1321 (-[WebFrameView _horizontalPageScrollDistance]):
1322 * WebView/WebHTMLView.mm:
1323 (-[WebHTMLView _scaleFactorForPrintOperation:]):
1324 * WebView/WebView.mm:
1325 (+[WebView _setCacheModel:]):
1326 (+[WebView _maxCacheModelInAnyInstance]):
1327 (+[WebView _cacheModelChangedNotification:]):
1328 (+[WebView _preferencesRemovedNotification:]):
1330 2013-10-22 Dean Jackson <dino@apple.com>
1332 [WebGL] Implement a software rendering option on Mac
1333 https://bugs.webkit.org/show_bug.cgi?id=123177
1335 Reviewed by Tim Horton.
1337 Implement a way to force software OpenGL rendering
1338 for WebGL, via a Setting/Preference.
1340 * WebView/WebPreferenceKeysPrivate.h: New WebKitForceSoftwareWebGLRendering key.
1341 * WebView/WebPreferences.mm:
1342 (+[WebPreferences initialize]):
1343 (-[WebPreferences forceSoftwareWebGLRendering]):
1344 (-[WebPreferences setForceSoftwareWebGLRendering:]):
1345 * WebView/WebPreferencesPrivate.h:
1346 * WebView/WebView.mm:
1347 (-[WebView _preferencesChanged:]):
1349 2013-10-21 Mark Rowe <mrowe@apple.com>
1351 Add a version of WebKitSystemInterface for Mavericks.
1353 Reviewed by Ryosuke Niwa.
1355 * Configurations/DebugRelease.xcconfig:
1357 2013-10-21 Daniel Bates <dabates@apple.com>
1359 Remove platform #ifdefs from WebDataSourcePrivate.h
1360 https://bugs.webkit.org/show_bug.cgi?id=123120
1361 <rdar://problem/15275533>
1363 Reviewed by Anders Carlsson.
1365 * WebView/WebDataSource.mm:
1366 (-[WebDataSource _setAllowToBeMemoryMapped]): Define empty implementation when building without
1367 disk image cache enabled.
1368 (-[WebDataSource setDataSourceDelegate:]): Ditto.
1369 (-[WebDataSource dataSourceDelegate]): Return nullptr when building without disk image cache
1371 * WebView/WebDataSourcePrivate.h: Removed platform #ifdefs added in
1372 <http://trac.webkit.org/changeset/156918> (https://bugs.webkit.org/show_bug.cgi?id=121985)
1374 2013-10-20 Mark Lam <mark.lam@apple.com>
1376 Avoid JSC debugger overhead unless needed.
1377 https://bugs.webkit.org/show_bug.cgi?id=123084.
1379 Reviewed by Geoffrey Garen.
1381 * WebView/WebScriptDebugger.mm:
1382 (WebScriptDebugger::WebScriptDebugger):
1384 2013-10-19 Jer Noble <jer.noble@apple.com>
1386 Unreviewed roll out of r157695; broke Mac builds.
1388 * Configurations/FeatureDefines.xcconfig:
1390 2013-10-07 Jer Noble <jer.noble@apple.com>
1392 [MSE] [Mac] Enable MediaSource on the Mac
1393 https://bugs.webkit.org/show_bug.cgi?id=122484
1395 Reviewed by Darin Adler.
1397 Enable ENABLE_MEDIA_SOURCE.
1399 * Configurations/FeatureDefines.xcconfig:
1401 2013-10-19 Andreas Kling <akling@apple.com>
1403 Attempt to get Lion building.
1405 * WebView/WebDataSource.mm:
1407 2013-10-18 Anders Carlsson <andersca@apple.com>
1409 Remove spaces between template angle brackets
1410 https://bugs.webkit.org/show_bug.cgi?id=123040
1412 Reviewed by Andreas Kling.
1414 * History/WebHistory.mm:
1415 (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1416 * History/WebHistoryItem.mm:
1417 (-[WebHistoryItem initFromDictionaryRepresentation:]):
1418 * Plugins/Hosted/NetscapePluginHostProxy.h:
1419 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1420 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1421 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
1422 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
1423 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
1424 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
1425 (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1426 * Plugins/WebNetscapePluginView.h:
1427 * Plugins/WebNetscapePluginView.mm:
1428 (-[WebNetscapePluginView destroyPlugin]):
1429 * Storage/WebDatabaseManager.mm:
1430 (-[WebDatabaseManager origins]):
1431 * Storage/WebStorageManager.mm:
1432 (-[WebStorageManager origins]):
1433 * WebCoreSupport/WebApplicationCache.mm:
1434 (+[WebApplicationCache originsWithCache]):
1435 * WebCoreSupport/WebEditorClient.h:
1436 * WebCoreSupport/WebEditorClient.mm:
1437 (WebEditorClient::getClientPasteboardDataForRange):
1438 (WebEditorClient::documentFragmentFromAttributedString):
1439 * WebCoreSupport/WebFrameLoaderClient.h:
1440 * WebCoreSupport/WebNotificationClient.h:
1441 * WebCoreSupport/WebNotificationClient.mm:
1442 (WebNotificationClient::show):
1443 (WebNotificationClient::clearNotifications):
1444 * WebView/WebArchive.mm:
1445 (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
1446 (-[WebArchive subresources]):
1447 (-[WebArchive subframeArchives]):
1448 * WebView/WebDataSource.mm:
1449 (-[WebDataSource subresources]):
1450 * WebView/WebViewData.h:
1452 2013-10-16 Jochen Eisinger <jochen@chromium.org>
1454 A page should exit fullscreen mode if it opens a new popup
1455 https://bugs.webkit.org/show_bug.cgi?id=122865
1457 Reviewed by Jer Noble.
1459 If a fullscreen page opens a popup, the popup would be hidden and
1460 therefore invisible to the user. To avoid this, exit fullscreen mode
1461 before opening a new window.
1463 * WebCoreSupport/WebChromeClient.mm:
1464 (WebChromeClient::createWindow):
1466 2013-10-15 Dean Jackson <dino@apple.com>
1468 Add ENABLE_WEB_ANIMATIONS flag
1469 https://bugs.webkit.org/show_bug.cgi?id=122871
1471 Reviewed by Tim Horton.
1473 Eventually might be http://dev.w3.org/fxtf/web-animations/
1474 but this is just engine-internal work at the moment.
1476 * Configurations/FeatureDefines.xcconfig:
1478 2013-10-15 Andy Estes <aestes@apple.com>
1480 Expose -[WebPluginPackage bundle] as SPI
1481 https://bugs.webkit.org/show_bug.cgi?id=122814
1483 Reviewed by Anders Carlsson.
1485 * Plugins/WebPluginPackage.mm:
1486 (-[WebPluginPackage bundle]): Defined.
1487 * Plugins/WebPluginPackagePrivate.h: Declared bundle as a method in a
1488 category on NSObject.
1490 2013-10-12 Darin Adler <darin@apple.com>
1492 Get rid of the toHTMLElement helper for casting FormAssociatedElement to HTMLElement
1493 https://bugs.webkit.org/show_bug.cgi?id=122713
1495 Reviewed by Sam Weinig.
1497 * WebView/WebHTMLRepresentation.mm:
1498 (-[WebHTMLRepresentation elementWithName:inForm:]): Use asHTMLElement.
1499 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1501 2013-10-12 Adam Roben <aroben@webkit.org>
1503 WebViews inside OS X screen savers have large caches, but should not
1504 https://bugs.webkit.org/show_bug.cgi?id=122604
1506 We use WebCacheModelDocumentViewer by default for apps linked against
1507 modern WebKit, and WebCacheModelDocumentBrowser for apps linked
1508 against legacy WebKit. ScreenSaverEngine.app doesn't link against
1509 WebKit at all, and thus falls into the legacy case by accident because
1510 NSVersionOfLinkTimeLibrary("WebKit") returns -1.
1512 But WebViews inside screen savers are almost certainly not being used
1513 as browsers, so this large-ish cache specified by
1514 WebCacheModelDocumentBrowser is wasteful. This is likely true for all
1515 apps that don't directly link against WebKit, so now we use
1516 WebCacheModelDocumentViewer by default for those apps.
1518 Reviewed by Darin Adler.
1520 * WebView/WebPreferences.mm:
1521 (cacheModelForMainBundle): Use WebCacheModelDocumentViewer by default
1522 for apps that don't link against WebKit directly. Also converted to
1523 use @autoreleasepool {} and early returns while I was in here.
1525 2013-10-12 Alexey Proskuryakov <ap@apple.com>
1527 Add a feature define for SubtleCrypto
1528 https://bugs.webkit.org/show_bug.cgi?id=122683
1530 Reviewed by Anders Carlsson.
1532 * Configurations/FeatureDefines.xcconfig:
1534 2013-10-12 Darin Adler <darin@apple.com>
1536 Use unique_ptr instead of delete in a few places
1537 https://bugs.webkit.org/show_bug.cgi?id=122639
1539 Reviewed by Anders Carlsson.
1541 * History/WebHistory.mm:
1542 (-[WebHistoryPrivate init]): Use make_unique.
1543 (-[WebHistoryPrivate dealloc]): Don't delete.
1544 (-[WebHistoryPrivate finalize]): Don't delete.
1545 (-[WebHistoryPrivate data]): Use get.
1547 * WebCoreSupport/WebFrameNetworkingContext.mm:
1548 (privateSession): Use NeverDestroyed here instead of a raw pointer.
1549 (WebFrameNetworkingContext::ensurePrivateBrowsingSession): Use the
1550 new function instead of direct global variable access.
1551 (WebFrameNetworkingContext::destroyPrivateBrowsingSession): Ditto.
1552 (WebFrameNetworkingContext::storageSession): Ditto.
1554 * WebView/WebFrame.mm:
1555 (-[WebFramePrivate dealloc]): Don't delete.
1556 (-[WebFramePrivate finalize]): Don't delete.
1557 (-[WebFrame _attachScriptDebugger]): Use make_unique.
1558 (-[WebFrame _detachScriptDebugger]): Don't delete.
1559 * WebView/WebFrameInternal.h: Use unique_ptr.
1561 2013-10-11 Timothy Hatcher <timothy@apple.com>
1563 Remove preference support for picking the old Web Inspector.
1564 https://bugs.webkit.org/show_bug.cgi?id=122655
1566 Reviewed by Alexey Proskuryakov.
1568 * WebCoreSupport/WebInspectorClient.mm:
1569 (WebInspectorFrontendClient::localizedStringsURL):
1570 (-[WebInspectorWindowController inspectorPagePath]):
1572 2013-10-10 Simon Fraser <simon.fraser@apple.com>
1574 Always force layout before flushing compositing layers
1575 https://bugs.webkit.org/show_bug.cgi?id=122626
1577 Reviewed by Tim Horton.
1579 [m_webView _flushCompositingChanges] only actually flushes compositing
1580 layers if the FrameView does not need layout (FrameView::flushCompositingStateForThisFrame()
1581 returns in this case). In this situation, flushLayers() does actually try
1582 to force a layout, but on some platforms it's possible for something else
1583 to dirty layout before the runloop observer fires again. This can result
1584 in flushLayers() never actually managing to flush, which stalls visual
1587 Fix by always calling -viewWillDraw (which updates layout) before flushing
1588 layers. This now matches WebKit2 behavior.
1590 * WebView/WebView.mm:
1591 (LayerFlushController::flushLayers):
1593 2013-10-10 Andy Estes <aestes@apple.com>
1595 Add SPI for telling WebKit to prefer pictograph glyphs over monochrome ones
1596 https://bugs.webkit.org/show_bug.cgi?id=122608
1598 Reviewed by Dan Bernstein.
1600 Based on patches by Dan Bernstein.
1602 * WebView/WebView.mm:
1603 (-[WebView _setFontFallbackPrefersPictographs:]): Called
1604 WebCore::Settings::setFontFallbackPrefersPictographs().
1605 * WebView/WebViewPrivate.h:
1607 2013-10-10 Mark Rowe <mrowe@apple.com>
1609 <rdar://problem/13341666> WebKit should always build against an SDK.
1611 Have all projects default to building against the OS X Internal SDK for the Production
1612 configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
1613 to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
1615 Reviewed by Dan Bernstein.
1617 * Configurations/Base.xcconfig:
1618 * Configurations/DebugRelease.xcconfig:
1620 2013-10-08 Darin Adler <darin@apple.com>
1622 WebNetscapePluginView should no longer use deleteAllValues
1623 https://bugs.webkit.org/show_bug.cgi?id=122495
1625 Reviewed by Anders Carlsson.
1627 * Plugins/WebNetscapePluginView.h: Use unique_ptr for both the pointer to
1628 the timers hash table, and for the values in the hash table.
1630 * Plugins/WebNetscapePluginView.mm:
1631 (-[WebNetscapePluginView stopTimers]): Rewrote loop so it works with unique_ptr.
1632 (-[WebNetscapePluginView startTimers]): Ditto.
1633 (-[WebNetscapePluginView fini]): Removed unneeded code to delete timers.
1634 (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): Make
1635 the timers hash table with make-unique. Fixed the loop that chooses the timer
1636 ID so it won't ever try to use a deleted value, although that never happens
1637 in practice. Use HashMap::add instead of using both contains and set.
1638 Rearranged code so we don't need to make a raw pointer for the timer.
1639 (-[WebNetscapePluginView unscheduleTimer:]): Use remove instead of take/delete,
1640 since remove takes care of the deletion automatically since we are using the
1643 2013-10-08 Darin Adler <darin@apple.com>
1645 Eliminate use of deleteAllValues in ProxyInstance
1646 https://bugs.webkit.org/show_bug.cgi?id=122499
1648 Reviewed by Anders Carlsson.
1650 * Plugins/Hosted/ProxyInstance.h: Use unique_ptr for map values in m_fields and m_methods.
1652 * Plugins/Hosted/ProxyInstance.mm:
1653 (WebKit::ProxyInstance::~ProxyInstance): Removed calls to deleteAllValues.
1654 (WebKit::ProxyInstance::methodNamed): Use make_unique and get to deal with map entries
1655 that are unique_ptr. Also fixed a bug where this would do an expensive no-op if the map
1656 already had an entry with a null in it. We would call the plug-in, but eventually
1657 isNewEntry would be false so we would return null.
1658 (WebKit::ProxyInstance::fieldNamed): Use make_unique and get to deal with map entries
1659 that are unique_ptr.
1661 2013-10-08 Darin Adler <darin@apple.com>
1663 Change NetscapePluginInstanceProxy::m_replies to use unique_ptr instead of deleteAllValues
1664 https://bugs.webkit.org/show_bug.cgi?id=122492
1666 Reviewed by Andreas Kling.
1668 * Plugins/Hosted/NetscapePluginHostManager.mm:
1669 (WebKit::NetscapePluginHostManager::instantiatePlugin): Use auto so this works with
1670 unique_ptr instead of auto_ptr.
1671 * Plugins/Hosted/NetscapePluginHostProxy.mm:
1672 (WKPCGetScriptableNPObjectReply): Use make_unique instead of using new directly.
1673 (WKPCBooleanReply): Ditto.
1674 (WKPCBooleanAndDataReply): Ditto.
1675 (WKPCInstantiatePluginReply): Ditto.
1676 * Plugins/Hosted/NetscapePluginInstanceProxy.h: Changed m_replies to map to unique_ptr
1677 instead of to a raw pointer.
1678 (WebKit::NetscapePluginInstanceProxy::setCurrentReply): Changed to take a unique_ptr
1679 instead of a raw pointer since this takes ownership of the pointer.
1680 (WebKit::NetscapePluginInstanceProxy::waitForReply): Changed to return a unique_ptr
1681 instead of a auto_ptr because that's better. Use unique_ptr inside the function
1682 too to avoid the need for an explicit delete.
1683 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1684 (WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy): Removed the call to
1686 (WebKit::NetscapePluginInstanceProxy::cancelStreamLoad): Removed unneeded initialization
1687 of a local variable that was already set in all code paths.
1688 (WebKit::NetscapePluginInstanceProxy::wheelEvent): Use auto so this works with unique_ptr
1689 instead of auto_ptr.
1690 (WebKit::NetscapePluginInstanceProxy::print): Ditto.
1691 (WebKit::NetscapePluginInstanceProxy::snapshot): Ditto. Ditto.
1692 (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Changed to return
1693 a unique_ptr. Also removed an unneeded assertion.
1694 (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Use auto so this works
1695 with unique_ptr instead of auto_ptr.
1697 * Plugins/Hosted/ProxyInstance.h: Changed return type of waitForReply to unique_ptr.
1699 * Plugins/Hosted/ProxyInstance.mm:
1700 (WebKit::ProxyInstance::invoke): Use auto so this works with unique_ptr instead of auto_ptr.
1701 (WebKit::ProxyInstance::supportsInvokeDefaultMethod): Ditto.
1702 (WebKit::ProxyInstance::supportsConstruct): Ditto.
1703 (WebKit::ProxyInstance::getPropertyNames): Ditto.
1704 (WebKit::ProxyInstance::methodNamed): Ditto.
1705 (WebKit::ProxyInstance::fieldNamed): Ditto.
1706 (WebKit::ProxyInstance::fieldValue): Ditto.
1707 (WebKit::ProxyInstance::setFieldValue): Ditto.
1709 2013-10-07 Sam Weinig <sam@webkit.org>
1711 CTTE: Use references in and around DragController
1712 https://bugs.webkit.org/show_bug.cgi?id=122427
1714 Reviewed by Andreas Kling.
1716 * WebCoreSupport/WebDragClient.h:
1717 * WebCoreSupport/WebDragClient.mm:
1718 (WebDragClient::actionMaskForDrag):
1719 (WebDragClient::willPerformDragDestinationAction):
1720 (WebDragClient::willPerformDragSourceAction):
1721 (WebDragClient::startDrag):
1722 (WebDragClient::declareAndWriteDragImage):
1723 * WebView/WebFrame.mm:
1724 (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
1725 * WebView/WebHTMLView.mm:
1726 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1727 * WebView/WebView.mm:
1728 (-[WebView draggingEntered:]):
1729 (-[WebView draggingUpdated:]):
1730 (-[WebView draggingExited:]):
1731 (-[WebView performDragOperation:]):
1733 2013-10-05 Sam Weinig <sam@webkit.org>
1735 CTTE: Thread references through markup.h
1736 https://bugs.webkit.org/show_bug.cgi?id=122403
1738 Reviewed by Darin Adler and Andreas Kling.
1740 * DOM/WebDOMOperations.mm:
1741 (-[DOMNode markupString]):
1742 (-[DOMRange markupString]):
1743 * WebView/WebFrame.mm:
1744 (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]):
1745 (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
1747 2013-10-05 Sam Weinig <sam@webkit.org>
1749 CTTE: Pass DocumentWriter around as a reference
1750 https://bugs.webkit.org/show_bug.cgi?id=122396
1752 Reviewed by Andreas Kling.
1754 * WebView/WebFrame.mm:
1755 (-[WebFrame _canProvideDocumentSource]):
1757 2013-10-04 Alexey Proskuryakov <ap@apple.com>
1759 Don't preflight spell checker when calling -setContinuousSpellCheckingEnabled repeatedly
1760 https://bugs.webkit.org/show_bug.cgi?id=122329
1762 Reviewed by Darin Adler.
1764 * WebView/WebView.mm: (-[WebView setContinuousSpellCheckingEnabled:]): Don't do any
1765 work if preference didn't change (continuousSpellCheckingEnabled is a static that
1768 2013-10-04 Anders Carlsson <andersca@apple.com>
1770 FramePolicyFunction should be an std::function
1771 https://bugs.webkit.org/show_bug.cgi?id=122362
1773 Reviewed by Darin Adler.
1775 * WebCoreSupport/WebFrameLoaderClient.h:
1776 * WebCoreSupport/WebFrameLoaderClient.mm:
1777 (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1778 (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1779 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1780 (WebFrameLoaderClient::dispatchWillSubmitForm):
1782 2013-10-04 Mark Lam <mark.lam@apple.com>
1784 Change ScriptDebugServer to use DebuggerCallFrame instead of JavaScriptCallFrame.
1785 https://bugs.webkit.org/show_bug.cgi?id=121969.
1787 Reviewed by Geoffrey Garen.
1789 1. Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame.
1790 DebuggerCallFrame now tracks whether it is valid instead of needing
1791 JavaScriptCallFrame do it.
1792 2. ScriptDebugServer now only instantiates an DebuggerCallFrame when needed
1793 just before it pauses and calls back to its client, and then invalidates
1794 it immediately when the callback returns. Every subsequent callback to
1795 the client will use a new instance of the DebuggerCallFrame.
1796 3. Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when
1798 4. DebuggerCallFrame only creates its caller DebuggerCallFrame when
1799 it is needed i.e. when the client calls callerFrame(). Similarly,
1800 JavaScriptCallFrame only creates its caller when it's requested.
1801 5. DebuggerCallFrame's line() and column() now returns a base-zero int.
1802 6. WebScriptDebugDelegate now only caches the functionName of the frame
1803 instead of the entire DebuggerCallFrame because that is all that is
1805 7. Also removed evaluateInGlobalCallFrame() which is not used anywhere.
1807 * WebView/WebScriptDebugDelegate.mm:
1808 (-[WebScriptCallFramePrivate dealloc]):
1809 (-[WebScriptCallFrame _initWithGlobalObject:functionName:exceptionValue:JSC::]):
1810 (-[WebScriptCallFrame functionName]):
1811 (-[WebScriptCallFrame exception]):
1812 * WebView/WebScriptDebugger.mm:
1813 (WebScriptDebugger::exception):
1815 2013-10-04 Anders Carlsson <andersca@apple.com>
1817 Remove some unneeded code from WidgetMac
1818 https://bugs.webkit.org/show_bug.cgi?id=122355
1820 Reviewed by Dan Bernstein.
1822 Remove code to handle the visible rect changing, it's not needed anymore since we always put Netscape plug-ins into their own layers now.
1824 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1825 * Plugins/WebBaseNetscapePluginView.h:
1826 * Plugins/WebBaseNetscapePluginView.mm:
1828 2013-10-04 Daniel Bates <dabates@apple.com>
1830 [iOS] Upstream disk image cache
1831 https://bugs.webkit.org/show_bug.cgi?id=121985
1833 Reviewed by Joseph Pecoraro.
1836 (+[WebCache statistics]):
1837 * WebView/WebDataSource.mm:
1838 (BufferMemoryMapped): Added.
1839 (-[WebDataSource _setAllowToBeMemoryMapped]): Added.
1840 (-[WebDataSource setDataSourceDelegate:]): Added.
1841 (-[WebDataSource dataSourceDelegate]): Added.
1842 (-[WebDataSource dealloc]):
1843 * WebView/WebDataSourcePrivate.h: Declared private delegate
1844 protocol, WebDataSourcePrivateDelegate.
1845 * WebView/WebPreferenceKeysPrivate.h:
1846 * WebView/WebPreferences.mm:
1847 (+[WebPreferences initialize]):
1848 (-[WebPreferences diskImageCacheEnabled]): Added.
1849 (-[WebPreferences setDiskImageCacheEnabled:]): Added.
1850 (-[WebPreferences diskImageCacheMinimumImageSize]): Added.
1851 (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Added.
1852 (-[WebPreferences diskImageCacheMaximumCacheSize]): Added.
1853 (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Added.
1854 (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Added.
1855 (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Added.
1856 * WebView/WebView.mm:
1857 (-[WebView _commonInitializationWithFrameName:groupName:]):
1858 (-[WebView _preferencesChanged:]):
1860 2013-10-04 Anders Carlsson <andersca@apple.com>
1862 Remove WebAssertions.h
1863 https://bugs.webkit.org/show_bug.cgi?id=122328
1865 Reviewed by Jessie Berlin.
1867 * Misc/WebAssertions.h: Removed.
1869 2013-10-03 Anders Carlsson <andersca@apple.com>
1871 Remove WebNSNotificationCenterExtras
1872 https://bugs.webkit.org/show_bug.cgi?id=122316
1874 Reviewed by Dan Bernstein.
1876 Use dispatch_async to ensure that notifications are posted on the main thread.
1878 * Misc/WebIconDatabase.mm:
1879 (-[WebIconDatabase _sendNotificationForURL:]):
1880 (-[WebIconDatabase _sendDidRemoveAllIconsNotification]):
1881 * Misc/WebNSNotificationCenterExtras.h: Removed.
1882 * Misc/WebNSNotificationCenterExtras.m: Removed.
1884 2013-10-03 Sam Weinig <sam@webkit.org>
1886 Remove shouldRubberBandInDirection from the WKBundlePageUIClient
1887 https://bugs.webkit.org/show_bug.cgi?id=122309
1889 Reviewed by Andreas Kling.
1891 * WebCoreSupport/WebChromeClient.h:
1893 2013-10-03 Anders Carlsson <andersca@apple.com>
1895 Ignore deprecation warnings
1896 https://bugs.webkit.org/show_bug.cgi?id=122302
1898 Reviewed by Mark Rowe.
1900 * Misc/WebIconDatabase.mm:
1901 (-[WebIconDatabase _scaleIcon:toSize:]):
1903 * Misc/WebNSImageExtras.m:
1904 (-[NSImage _web_scaleToMaxSize:]):
1905 (-[NSImage _web_dissolveToFraction:]):
1906 * Misc/WebNSViewExtras.m:
1907 (-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]):
1908 (-[NSView _web_convertRect:toView:]):
1909 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1910 (WebKit::NetscapePluginInstanceProxy::mouseEvent):
1911 * Plugins/Hosted/WebTextInputWindowController.m:
1912 (-[WebTextInputPanel _interpretKeyEvent:string:]):
1913 * Plugins/WebBaseNetscapePluginView.mm:
1914 (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
1915 * WebCoreSupport/WebDragClient.mm:
1916 (WebDragClient::startDrag):
1917 * WebInspector/WebNodeHighlight.mm:
1918 (-[WebNodeHighlight _computeHighlightWindowFrame]):
1919 * WebView/WebFullScreenController.mm:
1920 (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1921 (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1922 * WebView/WebHTMLView.mm:
1923 (+[WebHTMLView _postFlagsChangedEvent:]):
1924 (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1925 (-[WebHTMLView _autoscroll]):
1926 (-[WebHTMLView mouseDown:]):
1927 (-[WebHTMLView mouseDragged:]):
1928 (-[WebHTMLView mouseUp:]):
1929 (-[WebHTMLView accessibilityHitTest:]):
1930 (-[WebHTMLView _executeSavedKeypressCommands]):
1931 (-[WebHTMLView attachRootLayer:]):
1932 (-[WebHTMLView textStorage]):
1933 (-[WebHTMLView _updateSelectionForInputManager]):
1934 * WebView/WebTextCompletionController.mm:
1935 (-[WebTextCompletionController _buildUI]):
1936 (-[WebTextCompletionController _placePopupWindow:]):
1938 2013-10-01 Sam Weinig <sam@webkit.org>
1940 CTTE: DOMWrapperWorlds should be passed around by reference
1941 https://bugs.webkit.org/show_bug.cgi?id=122206
1943 Reviewed by Andreas Kling.
1945 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1946 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
1947 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
1948 (WebKit::NetscapePluginInstanceProxy::evaluate):
1949 * WebCoreSupport/WebFrameLoaderClient.h:
1950 * WebCoreSupport/WebFrameLoaderClient.mm:
1951 * WebView/WebFrame.mm:
1952 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
1953 (-[WebFrame _globalContextForScriptWorld:]):
1954 (-[WebFrame jsWrapperForNode:inScriptWorld:]):
1955 * WebView/WebScriptWorld.mm:
1956 (+[WebScriptWorld standardWorld]):
1957 (+[WebScriptWorld findOrCreateWorld:]):
1958 * WebView/WebScriptWorldInternal.h:
1959 * WebView/WebView.mm:
1960 (-[WebView _injectOutlookQuirksScript]):
1961 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1962 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1963 (+[WebView _removeUserScriptFromGroup:world:url:]):
1964 (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
1965 (+[WebView _removeUserScriptsFromGroup:world:]):
1966 (+[WebView _removeUserStyleSheetsFromGroup:world:]):
1968 2013-09-30 Sam Weinig <sam@webkit.org>
1970 Remove support for DOMFileSystem
1971 https://bugs.webkit.org/show_bug.cgi?id=122137
1973 Reviewed by Anders Carlsson.
1975 * Configurations/FeatureDefines.xcconfig:
1977 2013-09-30 Benjamin Poulain <benjamin@webkit.org>
1979 Remove the code guarded by STYLE_SCOPED
1980 https://bugs.webkit.org/show_bug.cgi?id=122123
1982 Reviewed by Anders Carlsson.
1984 * Configurations/FeatureDefines.xcconfig:
1986 2013-09-30 Mark Rowe <mrowe@apple.com>
1988 Fix the build when building against an SDK.
1990 Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
1991 the compiler command lines. It can't know to do this for the system framework search paths
1992 we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
1994 * Configurations/WebKit.xcconfig:
1996 2013-09-29 Mark Rowe <mrowe@apple.com>
2000 Ensure that C++ and Objective-C++ files build with the right compiler flags.
2002 * Configurations/WebKit.xcconfig:
2004 2013-09-28 Mark Rowe <mrowe@apple.com>
2006 Fix some failures with newer versions of clang.
2008 Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
2009 usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
2010 as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
2011 flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
2012 in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
2014 Reviewed by Dan Bernstein.
2016 * Configurations/DebugRelease.xcconfig:
2017 * Configurations/WebKit.xcconfig:
2019 2013-09-28 Mark Rowe <mrowe@apple.com>
2021 Take Xcode's advice and enable some extra warnings.
2023 Reviewed by Sam Weinig.
2025 * Configurations/Base.xcconfig:
2027 2013-09-28 Darin Adler <darin@apple.com>
2029 Add Frame::mainFrame and Frame::isMainFrame
2030 https://bugs.webkit.org/show_bug.cgi?id=122064
2032 Reviewed by Andreas Kling.
2034 * WebCoreSupport/WebFrameLoaderClient.mm:
2035 (WebFrameLoaderClient::canHandleRequest):
2036 (WebFrameLoaderClient::transitionToCommittedForNewPage):
2037 * WebView/WebFrameView.mm:
2038 (-[WebFrameView _install]):
2041 2013-09-28 Mark Rowe <mrowe@apple.com>
2043 WebKit fails to build with newer versions of clang.
2045 Reviewed by Sam Weinig.
2047 * Carbon/HIWebView.mm: Remove an unused function.
2048 * History/BinaryPropertyList.cpp: #if a constant that's only used in 64-bit.
2049 * Misc/WebIconDatabase.mm: Remove two unused constants.
2050 * Plugins/WebBaseNetscapePluginView.mm: Remove an unused constant.
2051 * WebCoreSupport/WebEditorClient.mm: Ditto.
2053 2013-09-27 Enrica Casucci <enrica@apple.com>
2055 Upstream changes to Pasteboard implementation for iOS.
2056 https://bugs.webkit.org/show_bug.cgi?id=121818
2058 Reviewed by Benjamin Poulain.
2060 * WebCoreSupport/WebPlatformStrategies.h:
2061 * WebCoreSupport/WebPlatformStrategies.mm:
2062 (WebPlatformStrategies::writeToPasteboard):
2063 (WebPlatformStrategies::getPasteboardItemsCount):
2064 (WebPlatformStrategies::readBufferFromPasteboard):
2065 (WebPlatformStrategies::readURLFromPasteboard):
2066 (WebPlatformStrategies::readStringFromPasteboard):
2067 (WebPlatformStrategies::changeCount):
2069 2013-09-26 Darin Adler <darin@apple.com>
2072 https://bugs.webkit.org/show_bug.cgi?id=16214
2074 Reviewed by Andreas Kling.
2076 * many files: Renamed, using script.
2078 2013-09-06 Jer Noble <jer.noble@apple.com>
2080 [Mac] Implement the media controls in JavaScript.
2081 https://bugs.webkit.org/show_bug.cgi?id=120895
2083 Reviewed by Dean Jackson.
2085 Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.
2087 * Configurations/FeatureDefines.xcconfig:
2089 2013-09-27 Darin Adler <darin@apple.com>
2091 Add empty MainFrame class
2092 https://bugs.webkit.org/show_bug.cgi?id=121770
2094 Reviewed by Andreas Kling.
2096 * WebCoreSupport/WebDragClient.mm:
2097 * WebCoreSupport/WebInspectorClient.mm:
2098 * WebCoreSupport/WebPlatformStrategies.mm:
2099 * WebView/WebFrame.mm:
2100 * WebView/WebHTMLView.mm:
2101 * WebView/WebView.mm:
2102 Include MainFrame.h instead of Frame.h as needed.
2104 2013-09-26 Eric Carlson <eric.carlson@apple.com>
2106 [MediaStream] make MediaStream testable
2107 https://bugs.webkit.org/show_bug.cgi?id=121967
2109 Reviewed by Dean Jackson.
2111 * WebCoreSupport/WebUserMediaClient.h: Added.
2112 * WebCoreSupport/WebUserMediaClient.mm: Added.
2114 * WebView/WebUIDelegatePrivate.h: Declare decidePolicyForUserMediaRequestFromOrigin:listener:
2116 * WebView/WebView.mm:
2117 (-[WebView _commonInitializationWithFrameName:groupName:]): Register WebUserMediaClient.
2118 (-[WebView _setUserMediaClient:]): New.
2119 (-[WebView _userMediaClient]): New.
2120 * WebView/WebViewData.h:
2121 * WebView/WebViewPrivate.h:
2123 2013-09-25 Sam Weinig <sam@webkit.org>
2125 Pass a JSC::VM& to JS bindings object creation functions, rather than a JSC::ExecState*
2126 https://bugs.webkit.org/show_bug.cgi?id=121934
2128 Reviewed by Geoffrey Garen.
2130 * Plugins/Hosted/ProxyInstance.mm:
2131 (WebKit::ProxyInstance::newRuntimeObject):
2132 * Plugins/Hosted/ProxyRuntimeObject.h:
2133 (WebKit::ProxyRuntimeObject::create):
2134 * Plugins/Hosted/ProxyRuntimeObject.mm:
2135 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2136 (WebKit::ProxyRuntimeObject::finishCreation):
2138 2013-09-25 Brady Eidson <beidson@apple.com>
2140 Enable the IndexedDB build on Mac, but leave the feature non-functional
2141 https://bugs.webkit.org/show_bug.cgi?id=121918
2143 Reviewed by Alexey Proskuryakov.
2145 * Configurations/FeatureDefines.xcconfig:
2147 2013-09-25 Commit Queue <commit-queue@webkit.org>
2149 Unreviewed, rolling out r156432.
2150 http://trac.webkit.org/changeset/156432
2151 https://bugs.webkit.org/show_bug.cgi?id=121932
2153 some integer conversion things that need brady to fix
2154 (Requested by thorton on #webkit).
2156 * Configurations/FeatureDefines.xcconfig:
2158 2013-09-25 Brady Eidson <beidson@apple.com>
2160 Enable the IndexedDB build on Mac, but leave the feature non-functional
2161 https://bugs.webkit.org/show_bug.cgi?id=121918
2163 Reviewed by Alexey Proskuryakov.
2165 * Configurations/FeatureDefines.xcconfig:
2167 2013-09-25 Brent Fulgham <bfulgham@apple.com>
2169 Refactor RuntimeEnabledFeatures as a Singleton.
2170 https://bugs.webkit.org/show_bug.cgi?id=121883.
2172 Reviewed by Jer Noble.
2174 * WebView/WebView.mm:
2175 (-[WebView _preferencesChanged:]): Use singleton accessor.
2176 (-[WebView _setDashboardBehavior:to:]): Ditto.
2178 2013-09-25 Brady Eidson <beidson@apple.com>
2180 FeatureDefine.xcconfig cleanup (They should all be identical).
2181 https://bugs.webkit.org/show_bug.cgi?id=121921
2183 Reviewed by Mark Rowe.
2185 * Configurations/FeatureDefines.xcconfig:
2187 2013-09-24 Mark Lam <mark.lam@apple.com>
2189 Change JSC debug hooks to pass a CallFrame* instead of a DebuggerCallFrame.
2190 https://bugs.webkit.org/show_bug.cgi?id=121867.
2192 Reviewed by Geoffrey Garen.
2194 * WebView/WebScriptDebugDelegate.mm:
2195 (-[WebScriptCallFrame _initWithGlobalObject:debuggerCallFrame:exceptionValue:JSC::]):
2196 (-[WebScriptCallFrame exception]):
2197 * WebView/WebScriptDebugger.h:
2198 * WebView/WebScriptDebugger.mm:
2199 (WebScriptDebugger::exception):
2201 2013-09-24 Enrica Casucci <enrica@apple.com>
2203 Upstream changes to Pasteboard implementation for iOS.
2204 https://bugs.webkit.org/show_bug.cgi?id=121818
2206 Reviewed by Darin Adler.
2208 * WebCoreSupport/WebPlatformStrategies.h:
2209 * WebCoreSupport/WebPlatformStrategies.mm:
2210 (WebPlatformStrategies::writeToPasteboard):
2212 2013-09-24 Mark Rowe <mrowe@apple.com>
2214 <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
2216 Reviewed by Dan Bernstein.
2218 * Configurations/Base.xcconfig:
2220 2013-09-21 Mark Lam <mark.lam@apple.com>
2222 Remove unused code in WebKit/mac's WebScriptDebugDelegate.
2223 https://bugs.webkit.org/show_bug.cgi?id=121706.
2225 Reviewed by Timothy Hatcher.
2227 WebScriptDebugDelegate's didEnterCallFrame, willExecuteStatement,
2228 and willLeaveCallFrame are not in use. Removed them and all methods
2229 and fields used for supporting them.
2231 * WebView/WebDelegateImplementationCaching.h:
2232 * WebView/WebScriptDebugDelegate.h:
2233 * WebView/WebScriptDebugDelegate.mm:
2234 (-[WebScriptCallFramePrivate dealloc]):
2235 (-[WebScriptCallFrame _initWithGlobalObject:debuggerCallFrame:]):
2236 * WebView/WebScriptDebugger.h:
2237 (WebScriptDebugger::globalObject):
2238 (WebScriptDebugger::callEvent):
2239 (WebScriptDebugger::atStatement):
2240 (WebScriptDebugger::returnEvent):
2241 (WebScriptDebugger::willExecuteProgram):
2242 (WebScriptDebugger::didExecuteProgram):
2243 (WebScriptDebugger::didReachBreakpoint):
2244 * WebView/WebScriptDebugger.mm:
2245 (WebScriptDebugger::WebScriptDebugger):
2246 (WebScriptDebugger::exception):
2247 * WebView/WebView.mm:
2248 (-[WebView _cacheScriptDebugDelegateImplementations]):
2250 2013-09-18 Anders Carlsson <andersca@apple.com>
2252 RefPtrHashMap should work with move only types
2253 https://bugs.webkit.org/show_bug.cgi?id=121564
2255 Reviewed by Andreas Kling.
2257 * Plugins/Hosted/ProxyInstance.mm:
2258 (WebKit::ProxyInstance::methodNamed):
2259 (WebKit::ProxyInstance::fieldNamed):
2261 2013-09-16 Enrica Casucci <enrica@apple.com>
2263 Remove unused function didSetSelectionTypesForPasteboard from EditorClient.
2264 https://bugs.webkit.org/show_bug.cgi?id=121464
2266 Reviewed by Darin Adler.
2268 This method was only implemented in WebEditorClient.mm for Mac where it was
2269 calling a private delegate that is no longer in use.
2271 * DefaultDelegates/WebDefaultEditingDelegate.m:
2272 * WebCoreSupport/WebEditorClient.h:
2273 * WebCoreSupport/WebEditorClient.mm:
2274 * WebView/WebEditingDelegatePrivate.h:
2276 2013-09-13 Anders Carlsson <andersca@apple.com>
2278 Use nullptr instead of 0 in calls to HashMap::add
2279 https://bugs.webkit.org/show_bug.cgi?id=121322
2281 Reviewed by Sam Weinig.
2283 * Plugins/Hosted/NetscapePluginHostManager.mm:
2284 (WebKit::NetscapePluginHostManager::hostForPlugin):
2286 2013-09-13 Dan Bernstein <mitz@apple.com>
2288 [mac WK1] Introduce WebViewWillCloseNotification
2289 https://bugs.webkit.org/show_bug.cgi?id=121321
2291 Reviewed by Sam Weinig.
2293 * WebKit.exp: Exported WebViewWillCloseNotification.
2294 * WebView/WebView.mm:
2295 (-[WebView _close]): Send WebViewWillCloseNotification before closing the WebView.
2296 * WebView/WebViewPrivate.h: Declared WebViewWillCloseNotification.
2298 2013-09-13 Tim Horton <timothy_horton@apple.com>
2300 REGRESSION (r155615): Lots of reftests fail with single line or single pixel differences
2301 https://bugs.webkit.org/show_bug.cgi?id=121245
2303 Reviewed by Darin Adler.
2305 Similar to https://bugs.webkit.org/show_bug.cgi?id=120963,
2306 we need to manually ensure that some pieces of persistent
2307 CoreGraphics state are restored after PDFKit changes them.
2309 In this case, we bookend our restoration around the various
2310 _recursiveDisplay... functions that we also use in WebHTMLView.
2312 * WebView/WebPDFView.mm:
2313 (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2314 (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2315 (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2316 (-[WebPDFView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2318 2013-09-12 Anders Carlsson <andersca@apple.com>
2320 SharedBuffer::createNSData should return a RetainPtr<NSData>
2321 https://bugs.webkit.org/show_bug.cgi?id=121237
2323 Reviewed by Darin Adler.
2325 Update for WebCore changes. This also fixes a leak where we'd create an NSFileWrapper from NSData but never release the data.
2327 * WebView/WebDataSource.mm:
2328 (-[WebDataSource data]):
2329 * WebView/WebHTMLRepresentation.mm:
2330 (-[WebHTMLRepresentation documentSource]):
2331 * WebView/WebHTMLView.mm:
2332 (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
2333 * WebView/WebResource.mm:
2334 (-[WebResource encodeWithCoder:]):
2335 (-[WebResource data]):
2337 2013-09-12 Mark Lam <mark.lam@apple.com>
2339 Change debug hooks to pass sourceID and position info via the DebuggerCallFrame.
2340 https://bugs.webkit.org/show_bug.cgi?id=121214.
2342 Reviewed by Geoffrey Garen.
2344 * webview/WebScriptDebugger.h:
2345 * WebView/WebScriptDebugger.mm:
2346 (WebScriptDebugger::WebScriptDebugger):
2347 (WebScriptDebugger::callEvent):
2348 (WebScriptDebugger::atStatement):
2349 (WebScriptDebugger::returnEvent):
2350 (WebScriptDebugger::exception):
2351 (WebScriptDebugger::willExecuteProgram):
2352 (WebScriptDebugger::didExecuteProgram):
2353 (WebScriptDebugger::didReachBreakpoint):
2355 2013-09-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2357 Generate more HTML type checks and casting
2358 https://bugs.webkit.org/show_bug.cgi?id=121080
2360 Reviewed by Andreas Kling.
2362 Clean-up remained functions of HTML elements using auto-generated isFooElement(),
2363 and replace toFooElement() with ELEMENT_TYPE_CASTS() macro.
2365 Besides this patch clean-up unnecessary checks which are being supported by
2366 auto-generated isFooElement().
2368 No new tests, no behavior change.
2370 * Plugins/WebPluginController.mm:
2371 * WebCoreSupport/WebChromeClient.mm:
2372 (WebChromeClient::supportsFullscreenForNode):
2373 * WebView/WebView.mm:
2374 (-[WebView _enterFullscreenForNode:WebCore::]):
2376 2013-09-10 Daniel Bates <dabates@apple.com>
2378 [iOS] Upstream text autosizing
2379 https://bugs.webkit.org/show_bug.cgi?id=121111
2381 Reviewed by Andy Estes and Sam Weinig.
2383 * WebView/WebFrame.mm:
2384 (-[WebFrame resetTextAutosizingBeforeLayout]): Added.
2385 (-[WebFrame _setVisibleSize:]): Added.
2386 (-[WebFrame _setTextAutosizingWidth:]): Added.
2387 * WebView/WebFramePrivate.h:
2388 * WebView/WebPreferenceKeysPrivate.h:
2389 * WebView/WebPreferences.mm:
2390 (+[WebPreferences initialize]):
2391 (-[WebPreferences _setMinimumZoomFontSize:]): Added.
2392 (-[WebPreferences _minimumZoomFontSize]): Added.
2394 2013-09-09 Dean Jackson <dino@apple.com>
2396 [WebGL] Allow multithreaded OpenGL contexts
2397 https://bugs.webkit.org/show_bug.cgi?id=121062
2399 Reviewed by Simon Fraser.
2401 Expose a new preference "multithreadedWebGLEnabled".
2403 * WebView/WebPreferenceKeysPrivate.h:
2404 * WebView/WebPreferences.mm:
2405 (+[WebPreferences initialize]):
2406 (-[WebPreferences multithreadedWebGLEnabled]):
2407 (-[WebPreferences setMultithreadedWebGLEnabled:]):
2408 * WebView/WebPreferencesPrivate.h:
2409 * WebView/WebView.mm:
2410 (-[WebView _preferencesChanged:]):
2412 2013-09-09 Dean Jackson <dino@apple.com>
2414 Enable WebGL for OS X nightlies
2415 https://bugs.webkit.org/show_bug.cgi?id=121040
2417 Reviewed by Beth Dakin.
2419 * WebView/WebPreferences.mm:
2420 (+[WebPreferences initialize]): Set WebPreference to YES.
2422 2013-09-06 Ryosuke Niwa <rniwa@webkit.org>
2424 Range::ownerDocument should return Document&
2425 https://bugs.webkit.org/show_bug.cgi?id=120908
2427 Reviewed by Andreas Kling.
2429 * WebView/WebPDFView.mm:
2432 2013-09-05 Andreas Kling <akling@apple.com>
2434 ScrollView::children() should return a reference.
2435 <https://webkit.org/b/120795>
2437 Reviewed by Anders Carlsson.
2439 * WebView/WebView.mm:
2440 (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
2442 2013-09-04 Mark Rowe <mrowe@apple.com>
2444 <https://webkit.org/b/120707> Make WebKit's localizable strings mechanism usable under ARC
2446 WebKit's localizable strings mechanism is also used outside of WebKit so it needs to work
2447 both with and without ARC.
2449 Reviewed by Anders Carlsson.
2451 * Misc/WebLocalizableStrings.h: Mark the bundle member as unretained. This matches how the
2452 member is used within WebLocalizableStrings.mm.
2454 2013-09-02 Darin Adler <darin@apple.com>
2456 [Mac] No need for HardAutorelease, which is same as CFBridgingRelease
2457 https://bugs.webkit.org/show_bug.cgi?id=120569
2459 Reviewed by Andy Estes.
2461 * Misc/WebNSFileManagerExtras.mm:
2462 (-[NSFileManager _webkit_startupVolumeName]): Removed some unneeded locals.
2463 Got rid of the pointless ref/leakRef/HardAutorelease dance, and replaced it
2464 with a [[x copy] autorelease].
2466 * Misc/WebNSURLExtras.mm:
2467 (-[NSURL _web_URLWithLowercasedScheme]): Use CFBridgingRelease, and got rid
2468 of unneeded type casts.
2470 * Plugins/WebBasePluginPackage.mm:
2471 (+[WebBasePluginPackage preferredLocalizationName]): Use CFBridgingRelease.
2472 * WebView/WebPDFRepresentation.mm:
2473 (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Ditto.
2475 * WebView/WebView.mm:
2476 (+[WebView _setCacheModel:]): Use CFBridgingRelease and got rid of unneeded
2479 2013-08-30 Antti Koivisto <antti@apple.com>
2481 Remove code behind ENABLE(DIALOG_ELEMENT)
2482 https://bugs.webkit.org/show_bug.cgi?id=120467
2484 Reviewed by Darin Adler.
2486 * Configurations/FeatureDefines.xcconfig:
2488 2013-08-29 Sam Weinig <sam@webkit.org>
2490 Add ENABLE gaurds for Promises
2491 https://bugs.webkit.org/show_bug.cgi?id=120488
2493 Reviewed by Andreas Kling.
2495 * Configurations/FeatureDefines.xcconfig:
2497 2013-08-29 Joseph Pecoraro <pecoraro@apple.com>
2499 Web Inspector: Download Web Archive of Inspected Page
2500 https://bugs.webkit.org/show_bug.cgi?id=119774
2502 Reviewed by Timothy Hatcher.
2504 Update to support InspectorFrontendHost.save's new base64Encoded
2505 parameter. It means the incoming content is binary data, not a string.
2507 * WebCoreSupport/WebInspectorClient.h:
2508 * WebCoreSupport/WebInspectorClient.mm:
2509 (WebInspectorFrontendClient::save):
2511 2013-08-28 Chris Curtis <chris_curtis@apple.com>
2513 https://bugs.webkit.org/show_bug.cgi?id=119548
2514 Refactoring Exception throws.
2516 Reviewed by Geoffrey Garen.
2518 Moved setting an exception into the vm, These functions changed to use the new functionality.
2520 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2521 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
2522 * Plugins/Hosted/ProxyInstance.mm:
2523 (WebKit::ProxyInstance::invokeMethod):
2525 2013-08-27 Anders Carlsson <andersca@apple.com>
2529 * Plugins/Hosted/ProxyInstance.h:
2530 * Plugins/Hosted/ProxyInstance.mm:
2531 (WebKit::ProxyInstance::methodNamed):
2532 (WebKit::ProxyInstance::fieldNamed):
2534 2013-08-23 Andy Estes <aestes@apple.com>
2536 Fix issues found by the Clang Static Analyzer
2537 https://bugs.webkit.org/show_bug.cgi?id=120230
2539 Reviewed by Darin Adler.
2541 * Misc/WebNSFileManagerExtras.mm:
2542 (-[NSFileManager _webkit_startupVolumeName]): Used HardAutorelease()
2543 instead of WebCFAutorelease().
2544 * Misc/WebNSObjectExtras.h: Removed definition of WebCFAutorelease().
2545 * Misc/WebNSURLExtras.mm:
2546 (-[NSURL _web_URLWithLowercasedScheme]): Used HardAutorelease()
2547 instead of WebCFAutorelease().
2548 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2549 (-[WebHostedNetscapePluginView createPluginLayer]): Stop leaking
2550 CGColors (CALayer retains its backgroundColor property despite the
2551 property attributes claiming otherwise).
2552 * Plugins/WebBasePluginPackage.mm:
2553 (+[WebBasePluginPackage preferredLocalizationName]): Used
2554 HardAutorelease() instead of WebCFAutorelease().
2555 * WebView/WebDeviceOrientationProviderMock.mm:
2556 (-[WebDeviceOrientationProviderMockInternal lastOrientation]): Stop
2557 leaking WebDeviceOrientations.
2558 * WebView/WebPDFRepresentation.mm:
2559 (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Used
2560 HardAutorelease() instead of WebCFAutorelease().
2561 * WebView/WebView.mm:
2562 (+[WebView _setCacheModel:]): Ditto.
2563 (-[WebView _removeObjectForIdentifier:]): Ditto.
2565 2013-08-26 Alexey Proskuryakov <ap@apple.com>
2567 [Mac] can-read-in-dragstart-event.html and can-read-in-copy-and-cut-events.html fail
2568 https://bugs.webkit.org/show_bug.cgi?id=113094
2570 Reviewed by Darin Adler.
2572 Return new pasteboard change count from all functions that change it.
2574 * WebCoreSupport/WebPlatformStrategies.h:
2575 * WebCoreSupport/WebPlatformStrategies.mm:
2576 (WebPlatformStrategies::copy):
2577 (WebPlatformStrategies::changeCount):
2578 (WebPlatformStrategies::addTypes):
2579 (WebPlatformStrategies::setTypes):
2580 (WebPlatformStrategies::setBufferForType):
2581 (WebPlatformStrategies::setPathnamesForType):
2582 (WebPlatformStrategies::setStringForType):
2584 2013-08-26 Andreas Kling <akling@apple.com>
2586 Unreviewed build fix.
2588 * WebView/WebFrame.mm:
2589 (+[WebFrame _createMainFrameWithPage:frameName:frameView:]):
2591 2013-08-26 Andreas Kling <akling@apple.com>
2593 WebCore: Let Page create the main Frame.
2594 <https://webkit.org/b/119964>
2596 Reviewed by Anders Carlsson.
2598 * WebCoreSupport/WebFrameLoaderClient.h:
2599 (WebFrameLoaderClient::setWebFrame):
2601 Make it possible to construct a WebFrameLoaderClient with a null WebFrame*.
2602 A WebFrame* is later hooked up with a call to setWebFrame().
2604 * WebView/WebFrame.mm:
2605 (+[WebFrame _createMainFrameWithPage:frameName:frameView:]):
2607 Customized this method to wrap the Page::mainFrame() instead of creating a
2610 * WebView/WebView.mm:
2611 (-[WebView _commonInitializationWithFrameName:groupName:]):
2613 Add a WebFrameLoaderClient to the PageClients passed to Page().
2615 2013-08-25 Darin Adler <darin@apple.com>
2617 Frame should not have a documentTypeString member function
2618 https://bugs.webkit.org/show_bug.cgi?id=120262
2620 Reviewed by Andreas Kling.
2622 * WebView/WebFrame.mm: Removed _stringWithDocumentTypeStringAndMarkupString:
2623 internal method, which was not used anywhere in WebKit. Internal methods are
2624 only for use within WebKit, as opposed to public and private methods that can
2626 * WebView/WebFrameInternal.h: Ditto.
2628 2013-08-24 Darin Adler <darin@apple.com>
2630 Frame::tree should return a reference instead of a pointer
2631 https://bugs.webkit.org/show_bug.cgi?id=120259
2633 Reviewed by Andreas Kling.
2635 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2636 (WebKit::NetscapePluginInstanceProxy::performRequest):
2637 * Plugins/WebBaseNetscapePluginView.mm:
2638 (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):
2639 * Plugins/WebNetscapePluginView.mm:
2640 (-[WebNetscapePluginView loadPluginRequest:]):
2641 * WebCoreSupport/WebFrameLoaderClient.mm:
2642 (applyAppleDictionaryApplicationQuirkNonInlinePart):
2643 (WebFrameLoaderClient::prepareForDataSourceReplacement):
2644 (WebFrameLoaderClient::createFrame):
2645 * WebView/WebFrame.mm:
2646 (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
2647 (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2648 (-[WebFrame _unmarkAllBadGrammar]):
2649 (-[WebFrame _unmarkAllMisspellings]):
2650 (-[WebFrame _atMostOneFrameHasSelection]):
2651 (-[WebFrame _findFrameWithSelection]):
2652 (-[WebFrame _drawRect:contentsOnly:]):
2653 (-[WebFrame _isDescendantOfFrame:]):
2654 (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
2655 (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
2657 (-[WebFrame findFrameNamed:]):
2658 (-[WebFrame parentFrame]):
2659 (-[WebFrame childFrames]):
2660 * WebView/WebView.mm:
2661 (-[WebView _attachScriptDebuggerToAllFrames]):
2662 (-[WebView _detachScriptDebuggerFromAllFrames]):
2663 (-[WebView _clearMainFrameName]):
2664 (-[WebView _isUsingAcceleratedCompositing]):
2665 (-[WebView _isSoftwareRenderable]):
2666 (-[WebView setHostWindow:]):
2668 Use tree(). instead of tree()->.
2670 2013-08-23 Beth Dakin <bdakin@apple.com>
2672 REGRESSION (r132545): Some PDFs generated by WebKit are blank when viewed in
2674 https://bugs.webkit.org/show_bug.cgi?id=120240
2676 <rdar://problem/14634453>
2678 Reviewed by Anders Carlsson.
2680 Hook up new WebSystemInterface API to find out if the current context is the PDF
2683 * WebCoreSupport/WebSystemInterface.mm:
2684 (InitWebCoreSystemInterface):
2686 2013-08-20 Pratik Solanki <psolanki@apple.com>
2688 <https://webkit.org/b/120029> Document::markers() should return a reference
2690 Reviewed by Andreas Kling.
2692 Document::m_markers is never NULL so return a reference from Document::markers(). Also mark
2693 m_markers as const and initialize it in member initialization.
2695 * WebView/WebFrame.mm:
2696 (-[WebFrame _unmarkAllBadGrammar]):
2697 (-[WebFrame _unmarkAllMisspellings]):
2698 * WebView/WebHTMLView.mm:
2699 (-[WebHTMLView unmarkAllTextMatches]):
2700 (-[WebHTMLView rectsForTextMatches]):
2702 2013-08-19 Ryosuke Niwa <rniwa@webkit.org>
2704 <https://webkit.org/b/120049> Delete code for Snow Leopard
2706 Reviewed by Benjamin Poulain.
2708 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2709 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2710 (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
2711 * Misc/WebNSControlExtras.m:
2712 (-[NSControl sizeToFitAndAdjustWindowHeight]):
2713 * Misc/WebNSFileManagerExtras.mm:
2714 * WebCoreSupport/WebEditorClient.mm:
2715 (WebEditorClient::shouldEraseMarkersAfterChangeSelection):
2716 (WebEditorClient::getGuessesForWord):
2717 * WebCoreSupport/WebFrameLoaderClient.mm:
2718 (WebFrameLoaderClient::dispatchDidLayout):
2719 (WebFrameLoaderClient::provisionalLoadStarted):
2720 * WebCoreSupport/WebSystemInterface.mm:
2721 (InitWebCoreSystemInterface):
2723 * WebView/WebDynamicScrollBarsView.mm:
2724 (-[WebDynamicScrollBarsView scrollWheel:]):
2725 * WebView/WebFullScreenController.mm:
2726 (convertRectToScreen):
2727 (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2728 (-[WebFullScreenController exitFullScreen]):
2729 * WebView/WebHTMLView.mm:
2730 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
2731 (-[WebHTMLView removeMouseMovedObserver]):
2732 (-[WebHTMLView windowDidBecomeKey:]):
2733 (-[WebHTMLView windowDidResignKey:]):
2734 * WebView/WebView.mm:
2735 (-[WebView _deviceScaleFactor]):
2737 2013-08-19 Ryosuke Niwa <rniwa@webkit.org>
2739 <https://webkit.org/b/120051> Remove the Mail thread workaround
2741 Reviewed by Sam Weinig.
2743 Remove the workaround for a very old version of Mail added in r39455.
2745 * WebView/WebArchive.mm:
2746 (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
2747 (-[WebArchive mainResource]):
2748 (-[WebArchive subresources]):
2749 (-[WebArchive subframeArchives]):
2750 * WebView/WebFrameView.mm:
2751 (-[WebFrameView initWithFrame:]):
2752 * WebView/WebResource.mm:
2753 (-[WebResource data]):
2754 (-[WebResource URL]):
2755 (-[WebResource MIMEType]):
2756 (-[WebResource textEncodingName]):
2757 (-[WebResource frameName]):
2758 (-[WebResource _ignoreWhenUnarchiving]):
2759 (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
2760 (-[WebResource _suggestedFilename]):
2761 (-[WebResource _response]):
2762 (-[WebResource _stringValue]):
2764 2013-08-19 Pratik Solanki <psolanki@apple.com>
2766 <https://webkit.org/b/119918> Frame::selection() should return a reference
2768 Reviewed by Darin Adler.
2770 m_selection is never NULL so return a reference from Frame::selection(). Also removed some
2771 unnecessary null checks and assert diff ts exposed as a result.
2773 * Plugins/WebPluginController.mm:
2774 * WebView/WebFrame.mm:
2775 (-[WebFrame _hasSelection]):
2776 (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
2777 (-[WebFrame _selectionGranularity]):
2778 (-[WebFrame _convertToNSRange:]):
2779 (-[WebFrame _convertToDOMRange:]):
2780 (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
2781 (-[WebFrame _typingStyle]):
2782 (-[WebFrame _selectedNSRange]):
2783 (-[WebFrame _selectNSRange:]):
2784 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2785 (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
2786 * WebView/WebHTMLRepresentation.mm:
2787 (-[WebHTMLRepresentation currentForm]):
2788 * WebView/WebHTMLView.mm:
2789 (-[WebHTMLView readSelectionFromPasteboard:]):
2790 (-[WebHTMLView _selectedRange]):
2791 (-[WebHTMLView _hasSelection]):
2792 (-[WebHTMLView _hasSelectionOrInsertionPoint]):
2793 (-[WebHTMLView _hasInsertionPoint]):
2794 (-[WebHTMLView _isEditable]):
2795 (-[WebHTMLView jumpToSelection:]):
2796 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
2797 (-[WebHTMLView maintainsInactiveSelection]):
2799 (isInPasswordField):
2800 (-[WebHTMLView centerSelectionInVisibleArea:]):
2801 (-[WebHTMLView _canSmartCopyOrDelete]):
2802 (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2803 (-[WebHTMLView _updateSelectionForInputManager]):
2804 (-[WebHTMLView selectionRect]):
2805 (-[WebHTMLView selectionTextRects]):
2806 (-[WebHTMLView selectionImageRect]):
2807 (-[WebHTMLView selectAll]):
2808 (-[WebHTMLView deselectAll]):
2809 (-[WebHTMLView selectedAttributedString]):
2810 * WebView/WebTextCompletionController.mm:
2811 (-[WebTextCompletionController doCompletion]):
2812 * WebView/WebView.mm:
2813 (-[WebView setSelectedDOMRange:affinity:]):
2814 (-[WebView selectedDOMRange]):
2815 (-[WebView selectionAffinity]):
2816 (-[WebView setEditable:]):
2817 (-[WebView _selectionIsCaret]):
2818 (-[WebView _selectionIsAll]):
2820 2013-08-17 Darin Adler <darin@apple.com>
2822 <https://webkit.org/b/119941> Make Page::dragController return a reference
2824 Reviewed by Andreas Kling.
2826 * WebView/WebFrameView.mm:
2827 (-[WebFrameView _setDocumentView:]):
2828 * WebView/WebHTMLView.mm:
2829 (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
2830 (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
2831 * WebView/WebView.mm:
2832 (-[WebView _setInitiatedDrag:]):
2833 (-[WebView draggingEntered:]):
2834 (-[WebView draggingUpdated:]):
2835 (-[WebView draggingExited:]):
2836 (-[WebView performDragOperation:]):
2837 (-[WebView moveDragCaretToPoint:]):
2838 (-[WebView removeDragCaret]):
2841 2013-08-16 Pratik Solanki <psolanki@apple.com>
2843 <https://webkit.org/b/119852> Frame::scriptController() should return a reference
2845 Reviewed by Andreas Kling.
2847 m_script is never NULL so we can just return a reference. Also remove some pointless null
2848 checks as a result of doing this.
2850 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2851 (WebKit::NetscapePluginInstanceProxy::cleanup):
2852 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2853 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
2854 (WebKit::NetscapePluginInstanceProxy::evaluate):
2855 (WebKit::NetscapePluginInstanceProxy::invoke):
2856 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2857 (WebKit::NetscapePluginInstanceProxy::construct):
2858 (WebKit::NetscapePluginInstanceProxy::getProperty):
2859 (WebKit::NetscapePluginInstanceProxy::setProperty):
2860 (WebKit::NetscapePluginInstanceProxy::removeProperty):
2861 (WebKit::NetscapePluginInstanceProxy::hasProperty):
2862 (WebKit::NetscapePluginInstanceProxy::hasMethod):
2863 (WebKit::NetscapePluginInstanceProxy::enumerate):
2864 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
2865 * Plugins/WebNetscapePluginView.mm:
2866 (-[WebNetscapePluginView getVariable:value:]):
2867 (-[WebNetscapePluginView _destroyPlugin]):
2868 * Plugins/WebPluginController.mm:
2869 * WebCoreSupport/WebFrameLoaderClient.mm:
2870 * WebCoreSupport/WebInspectorClient.mm:
2871 (WebInspectorFrontendClient::save):
2872 (WebInspectorFrontendClient::append):
2873 * WebView/WebFrame.mm:
2874 (-[WebFrame _attachScriptDebugger]):
2875 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2876 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2877 (-[WebFrame _globalContextForScriptWorld:]):
2878 (-[WebFrame jsWrapperForNode:inScriptWorld:]):
2879 (-[WebFrame windowObject]):
2880 (-[WebFrame globalContext]):
2881 (-[WebFrame javaScriptContext]):
2882 * WebView/WebScriptDebugger.mm:
2883 (WebScriptDebugger::initGlobalCallFrame):
2884 (WebScriptDebugger::callEvent):
2885 * WebView/WebView.mm:
2886 (-[WebView windowScriptObject]):
2887 (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
2889 2013-08-15 Anders Carlsson <andersca@apple.com>
2891 <https://webkit.org/b/119859> Frame::loader() should return a reference
2893 Reviewed by Andreas Kling.
2895 * Plugins/Hosted/HostedNetscapePluginStream.mm:
2896 (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
2897 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2898 (WebKit::NetscapePluginInstanceProxy::performRequest):
2899 (WebKit::NetscapePluginInstanceProxy::loadRequest):
2900 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2901 (-[WebHostedNetscapePluginView pluginView:receivedResponse:]):
2902 * Plugins/WebBaseNetscapePluginView.mm:
2903 (-[WebBaseNetscapePluginView requestWithURLCString:]):
2904 * Plugins/WebNetscapePluginStream.mm:
2905 (WebNetscapePluginStream::WebNetscapePluginStream):
2906 * Plugins/WebNetscapePluginView.mm:
2907 (-[WebNetscapePluginView loadStream]):
2908 (-[WebNetscapePluginView pluginView:receivedResponse:]):
2909 (-[WebNetscapePluginView loadPluginRequest:]):
2910 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2911 * Plugins/WebPluginController.mm:
2912 * WebCoreSupport/WebFrameLoaderClient.mm:
2913 (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
2914 (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2915 (WebFrameLoaderClient::dispatchWillSubmitForm):
2916 (WebFrameLoaderClient::updateGlobalHistory):
2917 (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
2918 (WebFrameLoaderClient::restoreViewState):
2919 (WebFrameLoaderClient::transitionToCommittedForNewPage):
2920 (WebFrameLoaderClient::createFrame):
2921 * WebCoreSupport/WebFrameNetworkingContext.mm:
2922 (WebFrameNetworkingContext::blockedError):
2923 * WebCoreSupport/WebPlatformStrategies.mm:
2924 (WebPlatformStrategies::getPluginInfo):
2925 * WebView/WebFrame.mm:
2927 (-[WebFrame _dataSource]):
2928 (-[WebFrame _canProvideDocumentSource]):
2929 (-[WebFrame _commitData:]):
2930 (-[WebFrame _firstLayoutDone]):
2931 (-[WebFrame _loadType]):
2932 (-[WebFrame _cacheabilityDictionary]):
2933 (-[WebFrame _clearOpener]):
2934 (-[WebFrame provisionalDataSource]):
2935 (-[WebFrame dataSource]):
2936 (-[WebFrame loadRequest:]):
2937 (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2938 (-[WebFrame loadArchive:]):
2939 (-[WebFrame stopLoading]):
2940 (-[WebFrame reload]):
2941 (-[WebFrame reloadFromOrigin]):
2942 * WebView/WebHTMLRepresentation.mm:
2943 (-[WebHTMLRepresentation receivedData:withDataSource:]):
2944 * WebView/WebHTMLView.mm:
2945 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
2946 * WebView/WebPDFView.mm:
2947 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2948 * WebView/WebRenderLayer.mm:
2949 (-[WebRenderLayer initWithWebFrame:]):
2950 * WebView/WebRenderNode.mm:
2951 (-[WebRenderNode _initWithCoreFrame:]):
2952 * WebView/WebView.mm:
2953 (-[WebView _close]):
2954 (-[WebView _loadBackForwardListFromOtherView:]):
2955 (-[WebView _cachedResponseForURL:]):
2956 (-[WebView setCustomTextEncodingName:]):
2957 (-[WebView shouldClose]):
2959 2013-08-15 Anders Carlsson <andersca@apple.com>
2961 <https://webkit.org/b/119854> REGRESSION (r153379): Serious drawing issues with WebViews
2962 <rdar://problem/14698870>
2964 Reviewed by Simon Fraser.
2966 Don't set aside subviews if they have already been set aside.
2968 * WebView/WebHTMLView.mm:
2969 (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2971 2013-08-15 Eric Carlson <eric.carlson@apple.com>
2973 [Mac] Remove "legacy" media UI
2974 https://bugs.webkit.org/show_bug.cgi?id=119752
2976 Reviewed by Jer Noble.
2978 * WebCoreSupport/WebSystemInterface.mm:
2979 (InitWebCoreSystemInterface): Remove MediaControllerThemeAvailable.
2981 2013-08-14 Tim Horton <timothy_horton@apple.com>
2983 Remotely hosted plugins don’t work in window-server-hosted WebKit1 views
2984 https://bugs.webkit.org/show_bug.cgi?id=119709
2985 <rdar://problem/14717572>
2987 Reviewed by Anders Carlsson.
2989 * Plugins/Hosted/NetscapePluginHostManager.h:
2990 Add hostLayersInWindowServer argument to instantiatePlugin.
2992 * Plugins/Hosted/NetscapePluginHostManager.mm:
2993 (WebKit::NetscapePluginHostManager::instantiatePlugin):
2994 Add hostLayersInWindowServer argument to instantiatePlugin, and pass it through to WebKitPluginHost.
2996 * Plugins/Hosted/NetscapePluginHostProxy.mm:
2997 (WKPCLayerHostingModeChanged):
2998 Forward the notification that the plugin host changed its layer hosting mode
2999 to the instance proxy.
3001 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3002 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3003 (WebKit::NetscapePluginInstanceProxy::setShouldHostLayersInWindowServer):
3004 Ask the plugin host to re-host its layers when the layer hosting mode changes.
3006 (WebKit::NetscapePluginInstanceProxy::layerHostingModeChanged):
3007 Inform the WebHostedNetscapePluginView of the new layer hosting mode
3008 when it changes. Also, store the new CAContext ID.
3010 * Plugins/Hosted/WebHostedNetscapePluginView.h:
3011 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3012 (-[WebHostedNetscapePluginView windowHostsLayersInWindowServer]):
3013 Determine whether the WebView's current window uses window-server hosting for its layers.
3015 (-[WebHostedNetscapePluginView createPlugin]):
3016 Drive-by spelling fix.
3017 Factor _pluginLayer initialization out into createPluginLayer.
3018 Instantiate the plugin with the appropriate layer hosting mode.
3020 (-[WebHostedNetscapePluginView createPluginLayer]):
3022 (-[WebHostedNetscapePluginView setHostsLayersInWindowServer:]):
3023 Create a new _pluginLayer if the layer hosting mode changes.
3024 Attach the new _pluginLayer to our parent layer.
3026 (-[WebHostedNetscapePluginView updateAndSetWindow]):
3027 Inform the NetscapePluginInstanceProxy if the layer hosting mode changes,
3028 so it can inform the plugin host. We will asynchronously receive a reply
3029 with the new hosting mode and renderContextID and switch to the new CAContext,
3030 in setHostsLayersInWindowServer:.
3032 * Plugins/Hosted/WebKitPluginClient.defs:
3033 * Plugins/Hosted/WebKitPluginHost.defs:
3035 2013-08-14 Tim Horton <timothy_horton@apple.com>
3037 REGRESSION (r153877): Plugin scanning slows creation of WebViews
3038 https://bugs.webkit.org/show_bug.cgi?id=119665
3039 <rdar://problem/14716549>
3041 Reviewed by Darin Adler.
3043 * Plugins/WebPluginDatabase.h:
3044 * Plugins/WebPluginDatabase.mm:
3045 (+[WebPluginDatabase sharedDatabaseIfExists]): Added.
3047 * WebCoreSupport/WebPlatformStrategies.mm:
3048 (WebPlatformStrategies::refreshPlugins):
3049 Only refresh the plugin database if it's already been loaded.
3051 2013-08-14 Jer Noble <jer.noble@apple.com>
3053 Revert r154019; causes >50 tests to fail on WebKit1 bots.
3055 * Plugins/Hosted/NetscapePluginHostManager.h:
3056 * Plugins/Hosted/NetscapePluginHostManager.mm:
3057 (WebKit::NetscapePluginHostManager::instantiatePlugin):
3058 * Plugins/Hosted/NetscapePluginHostProxy.mm:
3059 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3060 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3061 * Plugins/Hosted/WebHostedNetscapePluginView.h:
3062 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3063 (-[WebHostedNetscapePluginView setAttributeKeys:andValues:]):
3064 (-[WebHostedNetscapePluginView createPlugin]):
3065 (-[WebHostedNetscapePluginView updateAndSetWindow]):
3066 * Plugins/Hosted/WebKitPluginClient.defs:
3067 * Plugins/Hosted/WebKitPluginHost.defs:
3069 2013-08-13 Filip Pizlo <fpizlo@apple.com>
3071 Foo::s_info should be Foo::info(), so that you can change how the s_info is actually linked
3072 https://bugs.webkit.org/show_bug.cgi?id=119770
3074 Reviewed by Mark Hahnenberg.
3076 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3077 (WebKit::getObjectID):
3078 (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
3079 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
3080 * Plugins/Hosted/ProxyInstance.mm:
3081 (WebKit::ProxyRuntimeMethod::finishCreation):
3082 (WebKit::ProxyInstance::invokeMethod):
3083 * Plugins/Hosted/ProxyRuntimeObject.h:
3084 (WebKit::ProxyRuntimeObject::createStructure):
3085 * WebView/WebView.mm:
3086 (aeDescFromJSValue):
3088 2013-08-13 Anders Carlsson <andersca@apple.com>
3090 <https://webkit.org/b/119777> Get rid of two gotos
3092 Reviewed by Tim Horton.
3094 * WebView/WebHTMLView.mm:
3095 (-[WebHTMLView mouseDown:]):
3096 (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
3098 2013-08-13 Tim Horton <timothy_horton@apple.com>
3100 Remotely hosted plugins don’t work in window-server-hosted WebKit1 views
3101 https://bugs.webkit.org/show_bug.cgi?id=119709
3102 <rdar://problem/14717572>
3104 Reviewed by Anders Carlsson.
3106 * Plugins/Hosted/NetscapePluginHostManager.h:
3107 Add hostLayersInWindowServer argument to instantiatePlugin.
3109 * Plugins/Hosted/NetscapePluginHostManager.mm:
3110 (WebKit::NetscapePluginHostManager::instantiatePlugin):
3111 Add hostLayersInWindowServer argument to instantiatePlugin, and pass it through to WebKitPluginHost.
3113 * Plugins/Hosted/NetscapePluginHostProxy.mm:
3114 (WKPCLayerHostingModeChanged):
3115 Forward the notification that the plugin host changed its layer hosting mode
3116 to the instance proxy.
3118 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3119 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3120 (WebKit::NetscapePluginInstanceProxy::setShouldHostLayersInWindowServer):
3121 Ask the plugin host to re-host its layers when the layer hosting mode changes.
3123 (WebKit::NetscapePluginInstanceProxy::layerHostingModeChanged):
3124 Inform the WebHostedNetscapePluginView of the new layer hosting mode
3125 when it changes. Also, store the new CAContext ID.
3127 * Plugins/Hosted/WebHostedNetscapePluginView.h:
3128 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3129 (-[WebHostedNetscapePluginView windowHostsLayersInWindowServer]):
3130 Determine whether the WebView's current window uses window-server hosting for its layers.
3132 (-[WebHostedNetscapePluginView createPlugin]):
3133 Drive-by spelling fix.
3134 Factor _pluginLayer initialization out into createPluginLayer.
3135 Instantiate the plugin with the appropriate layer hosting mode.
3137 (-[WebHostedNetscapePluginView createPluginLayer]):
3139 (-[WebHostedNetscapePluginView setHostsLayersInWindowServer:]):
3140 Create a new _pluginLayer if the layer hosting mode changes.
3141 Attach the new _pluginLayer to our parent layer.
3143 (-[WebHostedNetscapePluginView updateAndSetWindow]):
3144 Inform the NetscapePluginInstanceProxy if the layer hosting mode changes,
3145 so it can inform the plugin host. We will asynchronously receive a reply
3146 with the new hosting mode and renderContextID and switch to the new CAContext,
3147 in setHostsLayersInWindowServer:.
3149 * Plugins/Hosted/WebKitPluginClient.defs:
3150 * Plugins/Hosted/WebKitPluginHost.defs:
3152 2013-08-08 Tim Horton <timothy_horton@apple.com>
3154 navigator.plugins has plugins in it when plugins are disabled
3155 https://bugs.webkit.org/show_bug.cgi?id=119607
3156 <rdar://problem/14678030>
3158 Reviewed by Anders Carlsson.
3160 * WebCoreSupport/WebPlatformStrategies.mm:
3161 (WebPlatformStrategies::getPluginInfo):
3162 If plugins are disabled for the given page, give WebCore an empty list of
3163 plugins. If WebKit1 had any application plugins, we'd return just them
3166 2013-08-06 Stephanie Lewis <slewis@apple.com>
3168 Update Order Files for Safari
3169 <rdar://problem/14517392>
3175 2013-08-04 Sam Weinig <sam@webkit.org>
3177 Remove support for HTML5 MicroData
3178 https://bugs.webkit.org/show_bug.cgi?id=119480
3180 Reviewed by Anders Carlsson.
3182 * Configurations/FeatureDefines.xcconfig:
3184 2013-07-23 David Farler <dfarler@apple.com>
3186 Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
3187 https://bugs.webkit.org/show_bug.cgi?id=117762
3189 Reviewed by Mark Rowe.
3191 * Configurations/DebugRelease.xcconfig:
3192 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
3193 * Configurations/WebKit.xcconfig:
3194 Add ASAN_OTHER_LDFLAGS.
3196 2013-07-26 Mark Rowe <mrowe@apple.com>
3198 Logging should be configurable using human-readable channel names rather than crazy bitmasks
3199 <http://webkit.org/b/119031>
3201 Implement shared logic for initializing logging channels based on human-readable channel names in WTF,
3202 and rework the WebCore, WebKit and WebKit2 logging initialization on top of it.
3204 Logging channels may now be enabled by providing a comma-separated list of channel names, with the special
3205 "all" name enabling all channels. Channel names prefixed with a leading "-" will result in the named channel
3206 being disabled. For instance, specifying "all,-history,-loading" will result in all logging channels except
3207 for history and loading being enabled.
3209 For OS X developers, this also changes the name of the user defaults used to enable logging. This is done to allow
3210 the old user defaults to remain set for those people that need to switch between version of WebKit before and
3211 after this change. Where the old user default keys were WebCoreLogLevel, WebKitLogLevel and WebKit2LogLevel,
3212 the new user default keys are WebCoreLogging, WebKitLogging and WebKit2Logging.
3214 For GTK developers, this changes the separator used in the WEBKIT_DEBUG environment variable to a comma for
3215 consistency with the other platforms and to enable more code sharing.
3217 While doing this work I've also taken the opportunity to eliminate the need to touch multiple files when
3218 adding a new logging channel. Now only the header in the relevant project needs to be updated.
3220 Reviewed by Sam Weinig.
3222 * Misc/WebKitLogging.h: Declare a WEBKIT_LOG_CHANNELS macro that can be used to apply a preprocessor macro
3223 across the set of all logging channels. Use this macro to declare the logging channels.
3224 * Misc/WebKitLogging.m: Use WEBKIT_LOG_CHANNELS to define all of the channels. Pass the channels and the
3225 preference value to the new WTF function that handles the initialization.
3226 * WebView/WebPreferenceKeysPrivate.h: Remove a key that does not need to be here.
3227 * WebView/WebView.mm: Switch from WebCore's InitializeLogging.h to Logging.h.
3229 2013-08-01 Ruth Fong <ruth_fong@apple.com>
3231 [Forms: color] <input type='color'> popover color well implementation
3232 <rdar://problem/14411008> and https://bugs.webkit.org/show_bug.cgi?id=119356
3234 Reviewed by Benjamin Poulain.
3236 * Configurations/FeatureDefines.xcconfig: Added and enabled INPUT_TYPE_COLOR_POPOVER.
3238 2013-07-31 Tim Horton <timothy_horton@apple.com>
3240 Remove didFinishLoad order quirk
3241 https://bugs.webkit.org/show_bug.cgi?id=119354
3242 <rdar://problem/11510686>
3244 Reviewed by Alexey Proskuryakov.
3246 * Misc/WebKitVersionChecks.h:
3247 * WebView/WebView.mm:
3248 (-[WebView _preferencesChanged:]):
3249 Don't set the now-removed preference.
3251 2013-07-31 Kwang Yul Seo <skyul@company100.net>
3253 Use emptyString instead of String("")
3254 https://bugs.webkit.org/show_bug.cgi?id=119335
3256 Reviewed by Darin Adler.
3258 Use emptyString() instead of String("") because it is better style and
3259 faster. This is a followup to r116908, removing all occurrences of
3260 String("") from WebKit.
3262 * WebCoreSupport/WebFrameLoaderClient.mm:
3263 (WebFrameLoaderClient::userAgent):
3265 2013-07-31 Ruth Fong <ruth_fong@apple.com>
3267 <input type=color> Mac UI behaviour
3268 <rdar://problem/10269922> and https://bugs.webkit.org/show_bug.cgi?id=61276
3270 Reviewed by Brady Eidson.
3272 * Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
3273 * WebCoreSupport/WebChromeClient.h:
3274 * WebCoreSupport/WebChromeClient.mm:
3275 (WebChromeClient::createColorPicker): Added stub implementation.
3277 2013-07-26 Dean Jackson <dino@apple.com>
3279 Allow new transitions to run even when controller is suspended
3280 https://bugs.webkit.org/show_bug.cgi?id=119171
3281 <rdar://problem/14511404>
3283 Reviewed by Simon Fraser.
3285 Expose a new SPI on WebView that triggers the (buggy) old behaviour
3286 for animations, such that any newly created animations will start even
3287 when the document is supposedly suspended. It turns out that client content was
3288 unknowingly relying on this behaviour - e.g. suspending a view, loading a
3289 bunch of new content, bringing the view on screen and then unsuspending. In this
3290 situation, we were not running CSS transitions, because the page was suspended.
3291 However, JS was still triggering them, and content was expecting a transitionEnd event.
3293 * WebView/WebView.mm:
3294 (-[WebView allowsNewCSSAnimationsWhileSuspended]): Calls into AnimationController.
3295 (-[WebView setAllowsNewCSSAnimationsWhileSuspended:]): Ditto.
3296 * WebView/WebViewPrivate.h: New methods listed above.
3298 2013-07-26 Anders Carlsson <andersca@apple.com>
3300 Add another method that we need to set aside subviews for
3301 https://bugs.webkit.org/show_bug.cgi?id=119157
3302 <rdar://problem/14554723>
3304 Reviewed by Beth Dakin.
3306 * WebView/WebHTMLView.mm:
3307 (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3308 (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
3310 2013-07-25 Andreas Kling <akling@apple.com>
3312 ChromeClient::focusedNodeChanged() should be focusedElementChanged().
3313 <http://webkit.org/b/119110>
3315 Reviewed by Anders Carlsson.
3317 * WebCoreSupport/WebChromeClient.h:
3318 * WebCoreSupport/WebChromeClient.mm:
3319 (WebChromeClient::focusedElementChanged):
3321 2013-05-05 Geoffrey Garen <ggaren@apple.com>
3323 Rolled back in r149527 with crash fixed.
3325 Reviewed by Oliver Hunt.
3327 Rationalized 'this' value conversion
3328 https://bugs.webkit.org/show_bug.cgi?id=115542
3330 2013-07-17 Commit Queue <commit-queue@webkit.org>
3332 Unreviewed, rolling out r152701, r152703, r152739, r152754,
3334 http://trac.webkit.org/changeset/152701
3335 http://trac.webkit.org/changeset/152703
3336 http://trac.webkit.org/changeset/152739
3337 http://trac.webkit.org/changeset/152754
3338 http://trac.webkit.org/changeset/152756
3339 https://bugs.webkit.org/show_bug.cgi?id=118821
3341 this was a buggy fix and we're going to try something
3342 different (Requested by thorton on #webkit).
3344 * WebCoreSupport/WebChromeClient.h:
3345 * WebCoreSupport/WebChromeClient.mm:
3346 (WebChromeClient::shouldUnavailablePluginMessageBeButton):
3348 2013-07-17 Kangil Han <kangil.han@samsung.com>
3350 Use toHTMLMediaElement
3351 https://bugs.webkit.org/show_bug.cgi?id=118727
3353 Reviewed by Ryosuke Niwa.
3355 To avoid direct use of static_cast, this patch uses toHTMLMediaElement for code cleanup.
3357 * WebView/WebView.mm:
3358 (-[WebView _enterFullscreenForNode:WebCore::]):
3360 2013-07-16 Simon Fraser <simon.fraser@apple.com>
3362 Protect against the LayerFlushController being deleted inside its flushLayers() callback
3363 https://bugs.webkit.org/show_bug.cgi?id=118741
3364 <rdar://problem/14402651>
3366 Reviewed by Tim Horton.
3368 It's possible (especially on iOS) for the LayerFlushController to be destroyed
3369 inside its callback, via -[WebView _close]. Protect against this by making
3370 it refcounted, and holding a ref across the callback.
3372 Due to the odd relationship in which LayerFlushController owns its LayerFlushScheduler
3373 by value, we achieve this by allowing subclasses of LayerFlushScheduler
3374 to override runLoopObserverCallback(). WebViewLayerFlushScheduler uses the
3375 override to protect the owner of the LayerFlushScheduler, which is the
3376 LayerFlushController, when the callback is firing.
3378 * WebView/WebView.mm:
3379 (-[WebView _close]):
3380 * WebView/WebViewData.h:
3381 (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
3382 (LayerFlushController::create):
3383 * WebView/WebViewData.mm:
3384 (LayerFlushController::invalidate):
3385 (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
3387 2013-07-16 Jessie Berlin <jberlin@apple.com>
3389 Fix some NSDictionary misuse pointed out by the clang static analyzer
3390 https://bugs.webkit.org/show_bug.cgi?id=118736
3392 Reviewed by Anders Carlsson.
3394 * Plugins/Hosted/NetscapePluginHostManager.mm:
3395 (WebKit::NetscapePluginHostManager::spawnPluginHost):
3396 Explicitly cast the CFStringRef to an NSString *.
3397 * WebCoreSupport/WebEditorClient.mm:
3398 (WebEditorClient::documentFragmentFromAttributedString):
3399 Do not put a key with a nil value pair into the NSDictionary.
3401 2013-07-15 Tim Horton <timothy_horton@apple.com>
3403 Update blocked/missing plug-in UI
3404 https://bugs.webkit.org/show_bug.cgi?id=118347
3405 <rdar://problem/14209318>
3407 Reviewed by Sam Weinig.
3408 Patch by Antoine Quint, Anders Carlsson, Sam Weinig, and myself.
3410 * WebCoreSupport/WebChromeClient.h:
3411 * WebCoreSupport/WebChromeClient.mm:
3412 (WebChromeClient::shouldUnavailablePluginMessageIncludeButton):
3413 Rename from shouldUnavailablePluginMessageBeButton to
3414 shouldUnavailablePluginMessageIncludeButton for accuracy.
3416 2013-07-14 Jon Lee <jonlee@apple.com>
3418 [WK2] Calling Notification.requestPermission() without a callback crashes
3419 https://bugs.webkit.org/show_bug.cgi?id=118654
3420 <rdar://problem/14293352>
3422 Reviewed by Alexey Proskuryakov.
3424 * WebCoreSupport/WebNotificationClient.mm:
3425 (-[WebNotificationPolicyListener initWithCallback:]): The callback can be NULL, so remove the ASSERT.
3426 (-[WebNotificationPolicyListener allow]): Check for the callback before asking it to handle the event.
3427 (-[WebNotificationPolicyListener deny]): Ditto.
3429 2013-07-12 Jessie Berlin <jberlin@apple.com>
3431 Remove some dead stores pointed out by the clang static analyzer.
3432 https://bugs.webkit.org/show_bug.cgi?id=118608
3434 Reviewed by Anders Carlsson.
3436 * Plugins/Hosted/NetscapePluginHostManager.mm:
3437 (WebKit::NetscapePluginHostManager::instantiatePlugin):
3438 kr is never read after this point, so there is no reason to assign to it.
3440 * Plugins/WebBasePluginPackage.mm:
3441 (-[WebBasePluginPackage getPluginInfoFromPLists]):
3442 The extensions array is only used in the while loop. Move the declaration to the first place
3443 it is used in the while loop. Since it is always reassigned at that location, and since it
3444 is never read after the subsequent for loop, the assignment to an array containing the empty
3445 string is never used. Remove it.
3446 Similarly, the value of the description is always overwritten before used to assign to
3447 mimeClassInfo.desc or to pluginInfo.desc, so the code to assign it to the empty string is
3448 never used. Remove it.
3450 * WebView/WebTextCompletionController.mm:
3451 (-[WebTextCompletionController _placePopupWindow:]):
3452 maxWidth is never read (and never was since it was added in r7311) after it is used on the
3453 line above to set windowFrame.size.width.
3455 2013-07-11 Dan Bernstein <mitz@apple.com>
3457 [mac] No API for getting the page visibility state of a WebView
3458 https://bugs.webkit.org/show_bug.cgi?id=118578
3460 Reviewed by Simon Fraser.
3462 * WebView/WebView.mm:
3463 (kit): Added. Converts from WebCore::PageVisibilityState to WebPageVisibilityState.
3464 (-[WebView _visibilityState]): Added.
3465 * WebView/WebViewPrivate.h: Declared -_visibilityState.
3467 2013-07-11 Timothy Hatcher <timothy@apple.com>
3469 Revert r152267 and soft link WebInspectorUI.framework again.
3471 https://bugs.webkit.org/show_bug.cgi?id=118544
3473 Reviewed by David Kilzer.
3475 * Configurations/WebKit.xcconfig:
3476 * WebCoreSupport/WebInspectorClient.mm:
3477 (useWebKitWebInspector):
3479 2013-07-10 Jessie Berlin <jberlin@apple.com>
3481 Remove some dead code from WebNSURLExtras _web_hostString
3482 https://bugs.webkit.org/show_bug.cgi?id=118519
3484 Reviewed by Anders Carlsson.
3486 * Misc/WebNSURLExtras.mm:
3487 (-[NSURL _web_hostString]):
3488 NSString initWithData:encoding: does not throw an exception when passing nil for the data, so
3489 just delete the code that wasn't being run.
3491 2013-07-09 Jeremy Noble <jer.noble@apple.com>
3493 Reviewed by Simon Fraser.
3495 Remember the scroll position and restore after exiting full-screen mode.
3496 https://bugs.webkit.org/show_bug.cgi?id=61956
3497 <rdar://problem/9544461>
3499 Call into the main FrameView to save the scroll position before swapping the
3500 WebView into the full-screen window, and restore the scroll position after
3501 swapping the WebView back into the browser window.
3503 * WebView/WebFullScreenController.h:
3504 * WebView/WebFullScreenController.mm:
3505 (-[WebFullScreenController windowDidEnterFullscreen:]): Save the scroll position.
3506 (-[WebFullScreenController exitFullscreen]): Restore the scroll position.
3508 2013-07-04 Yongjun Zhang <yongjun_zhang@apple.com>