Source/WebKit/mac/ChangeLog

   1 2011-01-27  Oliver Hunt  <oliver@apple.com>
   2
   3         Reviewed by Geoffrey Garen.
   4
   5         Convert markstack to a slot visitor API
   6         https://bugs.webkit.org/show_bug.cgi?id=53219
   7
   8         Update to new marking api
   9
  10         * WebView/WebScriptDebugDelegate.mm:
  11         (-[WebScriptCallFrame scopeChain]):
  12
  13 2011-01-28  Dan Bernstein  <mitz@apple.com>
  14
  15         Reviewed by Sam Weinig.
  16
  17         <select> can't display right-to-left (rtl) languages
  18         https://bugs.webkit.org/show_bug.cgi?id=19785
  19
  20         * WebCoreSupport/WebChromeClient.h:
  21         * WebCoreSupport/WebChromeClient.mm:
  22         (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
  23         (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
  24
  25 2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
  26
  27         Unreviewed, rolling out r76891.
  28         http://trac.webkit.org/changeset/76891
  29         https://bugs.webkit.org/show_bug.cgi?id=53280
  30
  31         Makes every layout test crash (Requested by othermaciej on
  32         #webkit).
  33
  34         * Misc/WebIconDatabase.mm:
  35         (-[ThreadEnabler threadEnablingSelector:]):
  36         (importToWebCoreFormat):
  37
  38 2011-01-27  Nate Chapin  <japhet@chromium.org>
  39
  40         Reviewed by Adam Barth.
  41
  42         Use Document::url() instead of FrameLoader::url().
  43         https://bugs.webkit.org/show_bug.cgi?id=41165
  44
  45         * WebView/WebView.mm:
  46         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
  47
  48 2011-01-27  Dan Bernstein  <mitz@apple.com>
  49
  50         Rubber-stamped by Anders Carlsson.
  51
  52         Reverted an accidental change in r76561.
  53
  54         * WebView/WebHTMLView.mm:
  55
  56 2011-01-26  David Kilzer  <ddkilzer@apple.com>
  57
  58         <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
  59         <rdar://problem/8821760>
  60
  61         Reviewed by Antti Koivisto.
  62
  63         * WebCoreSupport/WebSystemInterface.mm:
  64         (InitWebCoreSystemInterface): Added initialization for
  65         GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
  66
  67 2011-01-26  Beth Dakin  <bdakin@apple.com>
  68
  69         Reviewed by Darin Adler.
  70
  71         Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
  72         when using WKScrollbars.
  73
  74         * WebCoreSupport/WebSystemInterface.mm:
  75         (InitWebCoreSystemInterface):
  76
  77 2011-01-25  Darin Adler  <darin@apple.com>
  78
  79         Reviewed by Anders Carlsson.
  80
  81         WebKit is using CSBackupSetItemExcluded incorrectly
  82         https://bugs.webkit.org/show_bug.cgi?id=53095
  83         rdar://problem/8790540
  84
  85         * Misc/WebIconDatabase.mm:
  86         (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
  87         It was incorrect, and this responsibility has been moved to WebCore.
  88
  89 2011-01-24  Chris Marrin  <cmarrin@apple.com>
  90
  91         Reviewed by Eric Seidel.
  92
  93         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
  94         https://bugs.webkit.org/show_bug.cgi?id=53041
  95
  96         * Configurations/FeatureDefines.xcconfig:
  97
  98 2011-01-25  Yury Semikhatsky  <yurys@chromium.org>
  99
 100         Reviewed by Pavel Feldman.
 101
 102         Web Inspector: remove "attached" state related methods from InspectorAgent
 103         https://bugs.webkit.org/show_bug.cgi?id=53086
 104
 105         * WebCoreSupport/WebInspectorClient.h:
 106         * WebCoreSupport/WebInspectorClient.mm:
 107         (-[WebInspectorWindowController showWindow:]):
 108         (-[WebInspectorWindowController attach]):
 109         (-[WebInspectorWindowController detach]):
 110
 111 2011-01-23  Dan Bernstein  <mitz@apple.com>
 112
 113         Reviewed by John Sullivan.
 114
 115         <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
 116
 117         * WebCoreSupport/WebChromeClient.mm:
 118         (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
 119
 120 2011-01-22  Alexey Proskuryakov  <ap@apple.com>
 121
 122         Reviewed by Darin Adler.
 123
 124         https://bugs.webkit.org/show_bug.cgi?id=52473
 125         Auto-scaling to avoid orphans is broken, remove dysfunctional code
 126
 127         * WebView/WebHTMLView.mm:
 128         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
 129         (-[WebHTMLView _scaleFactorForPrintOperation:]):
 130         (-[WebHTMLView knowsPageRange:]):
 131
 132 2011-01-21  Mark Rowe  <mrowe@apple.com>
 133
 134         Rubber-stamped by Jon Honeycutt.
 135
 136         Fix the build when using Clang by removing some unused variables.
 137
 138         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
 139         (-[WebHostedNetscapePluginView updateAndSetWindow]):
 140         * WebView/WebFullScreenController.mm:
 141         (-[WebFullScreenController enterFullscreen:]):
 142         (-[WebFullScreenController exitFullscreen]):
 143
 144 2011-01-21  Chris Rogers  <crogers@google.com>
 145
 146         Reviewed by Darin Fisher.
 147
 148         Add run-time enable support for the web audio API
 149         https://bugs.webkit.org/show_bug.cgi?id=52741
 150
 151         * WebView/WebPreferenceKeysPrivate.h:
 152         * WebView/WebPreferences.mm:
 153         (-[WebPreferences webAudioEnabled]):
 154         (-[WebPreferences setWebAudioEnabled:]):
 155         * WebView/WebPreferencesPrivate.h:
 156         * WebView/WebView.mm:
 157         (-[WebView _preferencesChangedNotification:]):
 158
 159 2011-01-20  John Sullivan  <sullivan@apple.com>
 160
 161         Reviewed by Mark Rowe.
 162
 163         Shift-tab doesn't cycle through fields in http authentication panel
 164         https://bugs.webkit.org/show_bug.cgi?id=52850
 165
 166         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
 167         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
 168         Re-wired the key loop so that there aren't two views with the same nextKeyView.
 169
 170 2011-01-20  Beth Dakin  <bdakin@apple.com>
 171
 172         Reviewed by Geoffrey Garen.
 173
 174         Fix for <rdar://problem/8890255>
 175
 176         Allow WebKitSystemInterface to draw scrollbars
 177         when appropriate.
 178         * WebCoreSupport/WebSystemInterface.mm:
 179         (InitWebCoreSystemInterface):
 180
 181 2011-01-19  Simon Fraser  <simon.fraser@apple.com>
 182
 183         Reviewed by Sam Weinig.
 184
 185         GraphicsLayers in subframes can get sync'd multiple times
 186         https://bugs.webkit.org/show_bug.cgi?id=52489
 187
 188         * WebView/WebView.mm:
 189         (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
 190         was renamed to syncCompositingStateIncludingSubframes().
 191
 192 2011-01-19  Darin Adler  <darin@apple.com>
 193
 194         Reviewed by Sam Weinig.
 195
 196         Would like script debugging protocol method to differentiate between caught and uncaught exceptions
 197         https://bugs.webkit.org/show_bug.cgi?id=52104
 198         rdar://problem/8704226
 199
 200         * WebView/WebDelegateImplementationCaching.h:
 201         Fix type of second integer in CallScriptDebugDelegate function overload
 202         to be int to match the actual Objective-C method. Added a new overload
 203         that includes a BOOL in the right place. Added a boolean named
 204         exceptionWasRaisedExpectsHasHandlerFlag.
 205
 206         * WebView/WebDelegateImplementationCaching.mm:
 207         (CallDelegate): Added overloads as above.
 208         (CallScriptDebugDelegate): Ditto.
 209
 210         * WebView/WebScriptDebugDelegate.h: Added new method with the additional
 211         boolean argument. Marked the old method informally deprecated.
 212
 213         * WebView/WebScriptDebugger.mm:
 214         (WebScriptDebugger::exception): Added code to call with or without the
 215         boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
 216
 217         * WebView/WebView.mm:
 218         (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
 219         exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
 220         guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
 221
 222 2011-01-19  Tony Gentilcore  <tonyg@chromium.org>
 223
 224         Reviewed by Mihai Parparita.
 225
 226         Perform some forward declaration
 227         https://bugs.webkit.org/show_bug.cgi?id=52522
 228
 229         * Misc/WebKitNSStringExtras.mm:
 230
 231 2011-01-19  Pavel Podivilov  <podivilov@chromium.org>
 232
 233         Reviewed by Yury Semikhatsky.
 234
 235         Web Inspector: [JSC] scripts have incorrect starting line (always 1).
 236         https://bugs.webkit.org/show_bug.cgi?id=52721
 237
 238         * WebView/WebScriptDebugger.h:
 239         * WebView/WebScriptDebugger.mm:
 240         (toNSString):
 241         (WebScriptDebugger::sourceParsed):
 242
 243 2011-01-19  Levi Weintraub  <leviw@google.com>
 244
 245         Reviewed by Ryosuke Niwa.
 246
 247         Updating to use Position::parentAnchoredEquivalent instead of
 248         the old htmlediting rangeCompliantEquivalent.
 249
 250         remove rangeCompliantEquivalent and replace it with Position methods
 251         https://bugs.webkit.org/show_bug.cgi?id=25057
 252
 253         * WebView/WebFrame.mm:
 254         (-[WebFrame _smartDeleteRangeForProposedRange:]):
 255
 256 2011-01-18  Chris Fleizach  <cfleizach@apple.com>
 257
 258         Reviewed by Darin Adler.
 259
 260         REGRESSION: A problem with Voiceover and finding links
 261         https://bugs.webkit.org/show_bug.cgi?id=52324
 262
 263         * WebView/WebDynamicScrollBarsView.mm:
 264         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
 265
 266 2011-01-17  David Kilzer  <ddkilzer@apple.com>
 267
 268         <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
 269
 270         Reviewed by Dan Bernstein.
 271
 272         * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
 273         DOMDocumentPrivate.h to the PrivateHeaders directory.
 274
 275 2011-01-17  Enrica Casucci  <enrica@apple.com>
 276
 277         Reviewed by Alexey Proskuryakov.
 278
 279         Drag and drop support: refactoring of image from link and image from selection
 280         https://bugs.webkit.org/show_bug.cgi?id=52496
 281
 282         This work cleans up the Mac code and makes it more similar to the Windows implementation,
 283         avoiding the use of an NSView when the FrameView can be used.
 284         The refactoring is a necessary step towards the complete support of drag and drop
 285         in WebKit2.
 286
 287         * WebCoreSupport/WebDragClient.mm:
 288         (WebDragClient::createDragImageForLink): Added.
 289         * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
 290         * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
 291
 292 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
 293
 294         Reviewed by Yury Semikhatsky.
 295
 296         Web Inspector: simplify debugger enabling routine.
 297         https://bugs.webkit.org/show_bug.cgi?id=52472
 298
 299         * WebInspector/WebInspector.mm:
 300         (-[WebInspector startDebuggingJavaScript:]):
 301
 302 2011-01-16  Dan Bernstein  <mitz@apple.com>
 303
 304         Reviewed by Simon Fraser.
 305
 306         Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
 307         https://bugs.webkit.org/show_bug.cgi?id=52550
 308
 309         * Plugins/WebNetscapePluginView.mm:
 310         (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
 311         that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
 312
 313 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
 314
 315         Reviewed by Dan Bernstein.
 316
 317         Issues with iframes and plugins when the WebView is scaled.
 318         <rdar://problem/6213380>
 319
 320         When _scaleWebView has been called on a WebView, iframes
 321         in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
 322         This is caused by AppKit NSViews not playing nicely with the scale
 323         applied through style.
 324
 325         Work around most of these issues by adjusting the bounds size
 326         of widgets to allow iframe contents to paint with the correct scale,
 327         and fix various places in the code where we relied on coordinate
 328         transforms via NSViews (which ignore CSS transforms).
 329
 330         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
 331         (-[WebHostedNetscapePluginView updateAndSetWindow]):
 332         * WebView/WebFrameView.mm:
 333         (-[WebFrameView setBoundsSize:]):
 334
 335 2011-01-16  Beth Dakin  <bdakin@apple.com>
 336
 337         Reviewed by Kevin Decker.
 338
 339         Fix for <rdar://problem/8871204>
 340
 341         Don't try to save elasticity state. Just rely on
 342         NSScrollElasticityAutomatic to restore the correct state.
 343         * WebCoreSupport/WebFrameLoaderClient.h:
 344         * WebCoreSupport/WebFrameLoaderClient.mm:
 345         (WebFrameLoaderClient::WebFrameLoaderClient):
 346         (WebFrameLoaderClient::dispatchDidFirstLayout):
 347         (WebFrameLoaderClient::provisionalLoadStarted):
 348
 349 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
 350
 351         Reviewed by Dan Bernstein.
 352
 353         Plugins render incorrectly with transformed ancestors
 354         https://bugs.webkit.org/show_bug.cgi?id=52507
 355
 356         -[NSView visibleRect] gives the wrong answer if there are CSS transforms
 357         in the ancestor chain of a plugin.
 358
 359         So use of this method with calls to -actualVisibleRectInWindow, which
 360         maps rects through the render tree to compute the correct rect,
 361         clipping via windowClipRect() if necessary.
 362
 363         Not testable, because doing so relies on the behavior of some
 364         plugins, which stop rendering if setWindow passes an empty rect.
 365
 366         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
 367         (-[WebHostedNetscapePluginView updateAndSetWindow]):
 368         * Plugins/WebBaseNetscapePluginView.h:
 369         * Plugins/WebBaseNetscapePluginView.mm:
 370         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
 371         * Plugins/WebNetscapePluginView.mm:
 372         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
 373
 374 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
 375
 376         Reviewed by Antti Koivisto.
 377
 378         Rename cache() to memoryCache()
 379         https://bugs.webkit.org/show_bug.cgi?id=52433
 380
 381         * Misc/WebCache.mm:
 382         (+[WebCache statistics]):
 383         (+[WebCache setDisabled:]):
 384         (+[WebCache isDisabled]):
 385         * WebView/WebView.mm:
 386         (+[WebView _setCacheModel:]):
 387
 388 2011-01-13  Geoffrey Garen  <ggaren@apple.com>
 389
 390         Reviewed by Oliver Hunt.
 391
 392         Split out a MarkedSpace strategy object from Heap.
 393         https://bugs.webkit.org/show_bug.cgi?id=52421
 394
 395         * Misc/WebCoreStatistics.mm:
 396         (+[WebCoreStatistics memoryStatistics]): Updated for class move.
 397
 398 2011-01-14  Dan Bernstein  <mitz@apple.com>
 399
 400         Reviewed by Simon Fraser.
 401
 402         WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
 403
 404         * WebView/WebHTMLView.mm:
 405         (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
 406         to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
 407         that the NSView tree doesn’t change from under AppKit as it traverses it.
 408
 409 2011-01-14  Beth Dakin  <bdakin@apple.com>
 410
 411         Reviewed by Mark Rowe.
 412
 413         Fix for <rdar://problem/7793902> Artifacts when scrolling
 414         page in Safari while page is loading
 415
 416         Call setDrawsBackground:YES on the scrollView in
 417         dispatchDidFirstLayout() rather than waiting until
 418         frameLoadCompleted(). Also suspend scrolling elasticity
 419         between provisionalLoadStarted() and dispatchDidFirstLayout()
 420         * WebCoreSupport/WebFrameLoaderClient.h:
 421         * WebCoreSupport/WebFrameLoaderClient.mm:
 422         (WebFrameLoaderClient::WebFrameLoaderClient):
 423         (WebFrameLoaderClient::dispatchDidFirstLayout):
 424         (WebFrameLoaderClient::provisionalLoadStarted):
 425
 426 2011-01-12  Enrica Casucci  <enrica@apple.com>
 427
 428         Reviewed by Darin Adler.
 429
 430         WebKit2: Add support for drag and drop
 431         https://bugs.webkit.org/show_bug.cgi?id=52343
 432         <rdar://problem/7660558>
 433
 434         The DragData class has been extended to provide
 435         additional context from the application (keyboard state, modal windows, etc.)
 436         as well as information of the drag pasteboard being used.
 437         These are the changes to align the behavior for WebKit.
 438
 439         * WebView/WebView.mm:
 440         (-[WebView applicationFlags:]): Added.
 441         (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
 442         (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
 443         (-[WebView draggingExited:]): Added parameter to the DragData constructor.
 444         (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
 445
 446 2011-01-12  Beth Dakin  <bdakin@apple.com>
 447
 448         Reviewed by Anders Carlsson.
 449
 450         Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
 451         Expose fixed layout through WebKit SPI
 452         -and corresponding-
 453         <rdar://problem/8844464>
 454
 455         And now with getters!
 456         * WebView/WebView.mm:
 457         (-[WebView _useFixedLayout]):
 458         (-[WebView _fixedLayoutSize]):
 459         * WebView/WebViewPrivate.h:
 460
 461 2011-01-12  Beth Dakin  <bdakin@apple.com>
 462
 463         Reviewed by Anders Carlsson.
 464
 465         Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
 466         fixed layout through WebKit SPI
 467         -and corresponding-
 468         <rdar://problem/8844464>
 469
 470         * WebView/WebView.mm:
 471         (-[WebView _setUseFixedLayout:]):
 472         (-[WebView _setFixedLayoutSize:]):
 473         * WebView/WebViewPrivate.h:
 474
 475 2011-01-07  Enrica Casucci  <enrica@apple.com>
 476
 477         Reviewed by Alexey Proskuryakov.
 478
 479         Paste and drag and drop use different code paths to interact with the pasteboard.
 480         https://bugs.webkit.org/show_bug.cgi?id=52093
 481         The change consists in a refactoring of the code to have only one class that
 482         deals with the pasteboard on Mac.
 483
 484         * WebCoreSupport/WebEditorClient.h:
 485         * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
 486         exposed by NSURLExtras.
 487         (WebEditorClient::canonicalizeURL):
 488         (WebEditorClient::canonicalizeURLString):
 489         * WebCoreSupport/WebPasteboardHelper.h: Removed.
 490         * WebCoreSupport/WebPasteboardHelper.mm: Removed.
 491         * WebView/WebHTMLView.mm: Removed comment.
 492         * WebView/WebView.mm: The following methods have been changed to use the new DragData
 493         constructor that doesn't use the WebPasteboardHelper reference.
 494         (-[WebView draggingEntered:]):
 495         (-[WebView draggingUpdated:]):
 496         (-[WebView draggingExited:]):
 497         (-[WebView performDragOperation:]):
 498
 499 2011-01-09  Tony Gentilcore  <tonyg@chromium.org>
 500
 501         Reviewed by Alexey Proskuryakov.
 502
 503         Forward declare some headers where possible
 504         https://bugs.webkit.org/show_bug.cgi?id=52133
 505
 506         * WebView/WebFrame.mm:
 507
 508 2011-01-09  Xianzhu Wang <phnixwxz@gmail.com>
 509
 510         Reviewed by Darin Fisher.
 511
 512         https://bugs.webkit.org/show_bug.cgi?id=41441
 513         createWindow method should only do window-creating without URL navigation
 514
 515         * WebCoreSupport/WebChromeClient.mm:
 516         (WebChromeClient::createWindow):
 517
 518 2011-01-08  Dan Bernstein  <mitz@apple.com>
 519
 520         Try to fix the Leopard build.
 521
 522         * WebView/WebFullScreenController.mm:
 523
 524 2011-01-07  Jer Noble  <jer.noble@apple.com>
 525
 526         Yet another Leopard build fix: NSRect and CGRect are not inter-
 527         changable in 32-bit.
 528
 529         * WebView/WebFullScreenController.mm:
 530         (-[WebFullScreenController exitFullscreen]):
 531
 532 2011-01-07  Jer Noble  <jer.noble@apple.com>
 533
 534         Fix the Leopard build: Replace CoreAnimation SL-only functions
 535         with Leopard equivalents.
 536
 537         * WebView/WebFullScreenController.mm:
 538         (+[CATransaction setDisableActions:]):
 539         (+[CATransaction setAnimationDuration:]):
 540         (-[WebFullScreenController _animationDuration]):
 541         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
 542
 543 2010-12-21  Jer Noble  <jer.noble@apple.com>
 544
 545         Reviewed by Simon Fraser.
 546
 547         Implement WebKit Full Screen support.
 548         https://bugs.webkit.org/show_bug.cgi?id=49481
 549         rdar://problem/8247444
 550
 551         Support the new fullscreen Chrome client requests.  WebView will pass
 552         through these requests to a WebFullscreenController.
 553
 554         * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
 555         * WebView/WebView.mm:
 556         (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
 557         (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
 558         (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
 559         (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
 560         * WebView/WebViewData.h: Add ivar newFullscreenController.
 561
 562 2010-12-17  Jer Noble  <jer@kokode.apple.com>
 563
 564         Reviewed by Simon Fraser.
 565
 566         Implement WebKit Full Screen support.
 567         https://bugs.webkit.org/show_bug.cgi?id=49481
 568         rdar://problem/8247444
 569
 570         This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
 571         Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
 572         window, and a custom CAAnimation animates that layer between the initial screen rect of the
 573         full screen element, to its final value. WebFullscreenController will swap the WebView out of
 574         its original window, and into the fullscreen window. The controller will replace the WebView
 575         with a placeholder view, so that if the placeholder moves or resized while the WebView is
 576         absent, the WebView will move back to the correct location when exiting fullscreen.
 577
 578         * WebView/WebFullscreenController.h: Added.
 579         * WebView/WebFullscreenController.mm: Added.
 580         (-[WebFullscreenController windowDidExitFullscreen:]):  Close the fullscreen window.
 581         (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
 582         (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
 583         (-[WebFullscreenController applicationDidResignActive:]):
 584         (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
 585             the new screen parameters.
 586         (-[WebFullscreenController enterFullscreen:]):  Set up the animation that will take the fullscreen element
 587             from its original screen rect into fullscreen.
 588         (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
 589             Set up the animation that will take the fullscreen element back into its original screen
 590             rect.
 591         (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine
 592             whether to disable screensaver and sleep.
 593         (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
 594             looking for HTMLVideoElements; returns whether any are found to be playing.
 595         (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
 596             and shift keys.
 597         (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
 598         (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
 599         (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
 600         (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
 601         (-[WebFullscreenWindow setRendererLayer:]): Ditto.
 602         (-[WebFullscreenWindow backgroundLayer]): Ditto.
 603         (-[WebFullscreenWindow animationView]): Ditto.
 604         (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
 605         (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
 606
 607 2011-01-07  James Robinson  <jamesr@chromium.org>
 608
 609         Revert "Implement mozilla's animationTime property"
 610         https://bugs.webkit.org/show_bug.cgi?id=51952
 611
 612         This approach isn't quite right.
 613
 614         * WebView/WebHTMLView.mm:
 615         (-[WebHTMLView drawRect:]):
 616         * WebView/WebView.mm:
 617         (layerSyncRunLoopObserverCallBack):
 618
 619 2011-01-06  Gavin Barraclough  <barraclough@apple.com>
 620
 621         Reviewed by Geoff Garen.
 622
 623         Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
 624
 625         The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
 626         destructor early, in order to release wrappers once we know we no longer intend to use them.
 627         Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
 628         lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
 629         A sequence of events that triggers the bug would look like this:
 630
 631         (1) Create a DOMWrapperWorld.
 632         (2) Register a timer in the world.
 633         (3) Call unregisterWorld() on the world.
 634         (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
 635         (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
 636             called forgetWorld() none exists.
 637         (6) Attempt to add a wrapper to a NULL map.
 638
 639         Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
 640
 641         * WebView/WebScriptWorld.mm:
 642         (-[WebScriptWorld unregisterWorld]):
 643
 644 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
 645
 646         Reviewed by Sam Weinig.
 647
 648         WK2: Support Accessibility
 649         https://bugs.webkit.org/show_bug.cgi?id=51859
 650
 651         Use rootObject() method to get top of AX tree.
 652
 653         * WebCoreSupport/WebFrameLoaderClient.h:
 654         (WebFrameLoaderClient::accessibilityRemoteObject):
 655         * WebView/WebFrame.mm:
 656         (-[WebFrame setAccessibleName:]):
 657         (-[WebFrame accessibilityRoot]):
 658         * WebView/WebFrameInternal.h:
 659         * WebView/WebFramePrivate.h:
 660         * WebView/WebHTMLView.mm:
 661         (-[WebHTMLView accessibilityAttributeValue:]):
 662         (-[WebHTMLView accessibilityFocusedUIElement]):
 663         (-[WebHTMLView accessibilityHitTest:]):
 664         (-[WebHTMLView _accessibilityParentForSubview:]):
 665
 666 2011-01-04  David Kilzer  <ddkilzer@apple.com>
 667
 668         <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
 669
 670         Reviewed by Eric Carlson.
 671
 672         This originally broke in r61581.  It is inside an
 673         ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
 674         build then.
 675
 676         * WebCoreSupport/WebFrameLoaderClient.mm: Call
 677         (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
 678         use WebCore::PluginInfo.name instead of
 679         -[WebBasePluginPackage name].
 680
 681 2011-01-02  Dan Bernstein  <mitz@apple.com>
 682
 683         Rubber-stamped by Simon Fraser.
 684
 685         <rdar://problem/8812159> Update copyright strings
 686
 687         * Info.plist:
 688
 689 2010-12-29  Dan Bernstein  <mitz@apple.com>
 690
 691         Reviewed by Ada Chan.
 692
 693         <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
 694         https://bugs.webkit.org/show_bug.cgi?id=51717
 695
 696         Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
 697         protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
 698
 699         * WebView/WebDocumentInternal.h:
 700         * WebView/WebHTMLView.mm:
 701         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
 702         (-[WebHTMLView _findString:options:]):
 703         * WebView/WebView.mm:
 704         (findString):
 705
 706 2010-12-28  Daniel Bates  <dbates@rim.com>
 707
 708         Reviewed by Sam Weinig.
 709
 710         Substitute // MARK: for compiler-specific #pragma mark
 711         https://bugs.webkit.org/show_bug.cgi?id=51657
 712
 713         For consistency, we should substitute "// MARK:" for compiler-
 714         specific "#pragma mark" in the source files for the Mac port.
 715
 716         * History/WebHistory.mm:
 717         * Plugins/WebBaseNetscapePluginView.mm:
 718         * Plugins/WebNetscapePluginView.mm:
 719         * WebCoreSupport/WebInspectorClient.mm:
 720         * WebCoreSupport/WebSecurityOrigin.mm:
 721         * WebView/WebPDFView.mm:
 722         * WebView/WebVideoFullscreenController.mm:
 723         * WebView/WebVideoFullscreenHUDWindowController.mm:
 724
 725 2010-12-23  Yongjun Zhang  <yongjun_zhang@apple.com>
 726
 727         Reviewed by Darin Adler.
 728
 729         WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
 730         https://bugs.webkit.org/show_bug.cgi?id=38535
 731
 732         WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram.  As a result,
 733         if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
 734         WebScriptDebugger's callframe stack is wrong from this point.  That could cause crash if we trying to access the top
 735         call frame from this stack when an exception throws because the saved top frame could be invalid.
 736
 737         To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
 738         callEvent and returnEvent.
 739
 740         * WebView/WebScriptDebugger.mm:
 741         (WebScriptDebugger::willExecuteProgram):
 742         (WebScriptDebugger::didExecuteProgram):
 743
 744 2010-12-22  Sam Weinig  <sam@webkit.org>
 745
 746         Reviewed by Darin Adler.
 747
 748         WebKit2 needs to mirror the frame tree in the UIProcess
 749         https://bugs.webkit.org/show_bug.cgi?id=51546
 750
 751         - Add client functions to notify that a frame has been added or
 752           removed from the page cache.
 753
 754         * WebCoreSupport/WebFrameLoaderClient.h:
 755         * WebCoreSupport/WebFrameLoaderClient.mm:
 756         (WebFrameLoaderClient::didSaveToPageCache):
 757         (WebFrameLoaderClient::didRestoreFromPageCache):
 758
 759 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
 760
 761         Reviewed by Eric Seidel.
 762
 763         Editor.h doesn't need to include SelectionController.h
 764         https://bugs.webkit.org/show_bug.cgi?id=51441
 765
 766         Renamed SelectionController::EDirection to SelectionDirection.
 767
 768         * WebView/WebFrame.mm:
 769         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
 770         Takes SelectionDirection instead of SelectionController::EDirection.
 771         * WebView/WebFrameInternal.h:
 772         * WebView/WebTextCompletionController.mm:
 773         (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
 774
 775 2010-12-22  Simon Fraser  <simon.fraser@apple.com>
 776
 777         Reviewed by Darin Adler.
 778
 779         Cache snapshots of plug-ins before painting, to avoid script running during painting
 780         https://bugs.webkit.org/show_bug.cgi?id=51493
 781
 782         When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
 783         or when printing), plug-ins which otherwise use the CA rendering model
 784         are sent a paint event. Some plug-ins may run script while handling this event,
 785         or out of process plug-ins may process queued requests at this time. Running
 786         script while inside layout or painting can have bad consequences, because it
 787         can result in arbitrary changes to the render tree.
 788
 789         This patch avoids sending plug-ins paint events inside of painting. Instead,
 790         we ask the plug-ins to cache a snapshot before we paint, and then the software
 791         paint simply draws that snapshot.
 792
 793         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
 794         (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
 795         draw it. Also only send the snapshot message to the plugin proxy if we
 796         know we're snapshotting, since even if creating the snapshot image failed,
 797         we still don't want to call to the plug-in.
 798
 799         * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
 800         * Plugins/WebBaseNetscapePluginView.mm:
 801         (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
 802         (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
 803
 804         * Plugins/WebNetscapePluginView.mm:
 805         (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
 806         * WebCoreSupport/WebFrameLoaderClient.mm:
 807         (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
 808         to cache and clear the snapshots.
 809
 810 2010-12-21  Cameron Zwarich  <zwarich@apple.com>
 811
 812         Reviewed by Darin Adler.
 813
 814         -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
 815         https://bugs.webkit.org/show_bug.cgi?id=51431
 816         <rdar://problem/8791757>
 817
 818         * Plugins/WebBasePluginPackage.mm:
 819         (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
 820         it doesn't underflow.
 821
 822 2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>
 823
 824         Reviewed by Cameron Zwarich.
 825
 826         REGRESSION(r74172): 125 java tests fail on Mac
 827         https://bugs.webkit.org/show_bug.cgi?id=51214
 828
 829         The regression was caused by an incorrectly adding sizeof(struct fat_header)
 830         to a pointer for uint32_t as supposed to uint8_t.
 831
 832         Fixed the bug by explicitly casting it to uint8_t* before the addition.
 833
 834         * Plugins/WebBasePluginPackage.mm:
 835         (-[WebBasePluginPackage isNativeLibraryData:]):
 836
 837 2010-12-15  Cameron Zwarich  <zwarich@apple.com>
 838
 839         Reviewed by Darin Adler.
 840
 841         Clang -Wcast-align gives an error in WebBasePluginPackage.mm
 842         https://bugs.webkit.org/show_bug.cgi?id=51144
 843
 844         Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
 845         we were calling it on a byte array 32 bits at a time. While this is okay in practice,
 846         since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
 847         inline storage is at the beginning of the Vector, it is still better to fix this
 848         and silence the warning.
 849
 850         * Plugins/WebBasePluginPackage.mm:
 851         (swapIntsInHeader):
 852         (-[WebBasePluginPackage isNativeLibraryData:]):
 853
 854 2010-12-14  Mark Rowe  <mrowe@apple.com>
 855
 856         Reviewed by Sam Weinig.
 857
 858         <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
 859
 860         * History/WebHistoryItem.mm:
 861         (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
 862         always including the target in the output.
 863
 864 2010-12-13  Alexey Proskuryakov  <ap@apple.com>
 865
 866         Reviewed by Adam Barth.
 867
 868         https://bugs.webkit.org/show_bug.cgi?id=50953
 869         DNS Prefetch should be an opt-in feature
 870
 871         * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
 872
 873 2010-12-13  Mike Thole  <mthole@apple.com>
 874
 875         Rubber-stamped by John Sullivan.
 876
 877         https://bugs.webkit.org/show_bug.cgi?id=50956
 878         WebAuthenticationPanel.nib appears to have a cut-off sentence
 879
 880         Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
 881         The contents of this text field are updated dynamically before the sheet is displayed.
 882
 883         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
 884         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
 885
 886 2010-12-13  Antti Koivisto  <antti@apple.com>
 887
 888         Reviewed by Alexey Proskuryakov.
 889
 890         https://bugs.webkit.org/show_bug.cgi?id=50758
 891         <rdar://problem/8722094>
 892         Defer loading print stylesheets
 893
 894         Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
 895
 896         * WebView/WebView.mm:
 897         (+[WebView _setLoadResourcesSerially:forHost:]):
 898         * WebView/WebViewPrivate.h:
 899
 900 2010-12-09  Matthew Delaney  <mdelaney@apple.com>
 901
 902         Reviewed by Simon Fraser.
 903
 904         Adopt new CG API for canvas
 905         https://bugs.webkit.org/show_bug.cgi?id=50591
 906
 907         * WebCoreSupport/WebSystemInterface.mm:
 908
 909 2010-10-28  MORITA Hajime  <morrita@google.com>
 910
 911         Reviewed by Ojan Vafai.
 912
 913         spellcheck does not check pasted text
 914         https://bugs.webkit.org/show_bug.cgi?id=40092
 915
 916         Added asynchronous spell checking API to WebEditorClient using
 917         -[NSSpellChecker requestCheckingOfString].
 918         Note that WebEditorSpellCheckResponder is a small class to receive
 919         requested spell-checking result. Note that this feature is
 920         disabled at default.
 921
 922         Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
 923         enable the feature from LayoutTestController.
 924
 925         * WebCoreSupport/WebEditorClient.h:
 926         * WebCoreSupport/WebEditorClient.mm:
 927         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
 928         (-[WebEditorSpellCheckResponder perform]):
 929         (toCoreSpellingResult):
 930         (-[WebEditorSpellCheckResponder WTF::WebCore::]):
 931         (WebEditorClient::requestCheckingOfString):
 932         * WebView/WebPreferenceKeysPrivate.h:
 933         * WebView/WebPreferences.mm:
 934         (+[WebPreferences initialize]):
 935         (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
 936         (-[WebPreferences asynchronousSpellCheckingEnabled]):
 937         * WebView/WebPreferencesPrivate.h:
 938         * WebView/WebView.mm:
 939         (-[WebView _preferencesChangedNotification:]):
 940
 941 2010-12-09  Anders Carlsson  <andersca@apple.com>
 942
 943         Fix a bug uncovered by clang++.
 944
 945         * WebView/WebHTMLView.mm:
 946         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
 947
 948 2010-12-09  Anders Carlsson  <andersca@apple.com>
 949
 950         Clang++ build fixes.
 951
 952         Silence a couple of warnings.
 953
 954         * WebView/WebFrame.mm:
 955         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
 956         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
 957         * WebView/WebTextCompletionController.mm:
 958         (-[WebTextCompletionController filterKeyDown:]):
 959
 960 2010-12-09  David Hyatt  <hyatt@apple.com>
 961
 962         Reviewed by Dan Bernstein.
 963
 964         https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
 965         writing-mode.  This first part of the patch just patches Mac WebKit 1 views.
 966
 967         * WebView/WebFrameView.mm:
 968         (-[WebFrameView _isVerticalDocument]):
 969         (-[WebFrameView _isFlippedDocument]):
 970         (-[WebFrameView _scrollToEndOfDocument]):
 971         (-[WebFrameView _pageInBlockProgressionDirection:]):
 972         (-[WebFrameView scrollPageUp:]):
 973         (-[WebFrameView scrollPageDown:]):
 974
 975 2010-12-08  Andy Estes  <aestes@apple.com>
 976
 977         Reviewed by Darin Adler.
 978
 979         Enable pre-HTML5 parser quirks for Apple Mail.app
 980         https://bugs.webkit.org/show_bug.cgi?id=50727
 981
 982         * WebView/WebView.mm:
 983         (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
 984         application is Mail.app.
 985
 986 2010-12-08  Brian Weinstein  <bweinstein@apple.com>
 987
 988         Reviewed by John Sullivan.
 989
 990         REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
 991         https://bugs.webkit.org/show_bug.cgi?id=50683
 992
 993         If our context menu item already has an action, don't overwrite the action with the context menu
 994         forwarder.
 995
 996         * WebView/WebHTMLView.mm:
 997         (setMenuItemTarget):
 998
 999 2010-12-08  Anders Carlsson  <andersca@apple.com>
1000
1001         Remove an unused variable.
1002
1003         * WebView/WebDynamicScrollBarsView.mm:
1004         (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
1005
1006 2010-12-07  Brian Weinstein  <bweinstein@apple.com>
1007
1008         Reviewed by John Sullivan.
1009
1010         Layering Violation in ContextMenu - member variable of type HitTestResult
1011         https://bugs.webkit.org/show_bug.cgi?id=50586
1012
1013         Update users of ContextMenu and ContextMenuController to match where the new functions
1014         are located.
1015
1016         * WebCoreSupport/WebContextMenuClient.mm:
1017         (WebContextMenuClient::getCustomMenuFromDefaultItems):
1018         (WebContextMenuClient::contextMenuItemSelected):
1019         * WebView/WebHTMLView.mm:
1020         (-[WebMenuTarget validateMenuItem:]):
1021
1022 2010-12-07  Brian Weinstein  <bweinstein@apple.com>
1023
1024         Reviewed by John Sullivan.
1025
1026         Part of Layering Violation in ContextMenu
1027         https://bugs.webkit.org/show_bug.cgi?id=50586
1028
1029         Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
1030         was a layering violation. Also, make sure we set the menu item targets for all menu
1031         items before showing them, because the ContextMenu constructor doesn't do that anymore.
1032
1033         * WebView/WebHTMLView.mm:
1034         (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
1035         (-[WebMenuTarget WebCore::]): Ditto.
1036         (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
1037         (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
1038         (-[WebMenuTarget validateMenuItem:]): Ditto.
1039
1040         (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
1041         (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
1042             submenus), and calls setMenuItemTarget on them.
1043         (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
1044             them to the menu.
1045
1046 2010-12-06  Darin Adler  <darin@apple.com>
1047
1048         Reviewed by Sam Weinig.
1049
1050         Pass security origin to make local file decision correctly
1051         https://bugs.webkit.org/show_bug.cgi?id=48603
1052
1053         * WebView/WebPDFView.mm:
1054         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
1055
1056 2010-12-07  Martin Robinson  <mrobinson@igalia.com>
1057
1058         Unreviewed, rolling out r73392.
1059         http://trac.webkit.org/changeset/73392
1060         https://bugs.webkit.org/show_bug.cgi?id=50489
1061
1062         This commit caused crashes on the GTK+ bots
1063
1064         * WebView/WebFrame.mm:
1065         (-[WebFrame _canProvideDocumentSource]):
1066
1067 2010-12-07  Kenichi Ishibashi  <bashi@google.com>
1068
1069         Reviewed by Kent Tamura.
1070
1071         Let HTMLObjectElement be a form associated element
1072         https://bugs.webkit.org/show_bug.cgi?id=48821
1073
1074         Modified to use FormAssociatedElement instead of HTMLFormControlElement.
1075
1076         * WebView/WebHTMLRepresentation.mm:
1077         (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
1078         FormAssociatedElement instead of HTMLFormControlElement.
1079         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1080
1081 2010-12-06  Nate Chapin  <japhet@chromium.org>
1082
1083         Reviewed by Adam Barth.
1084
1085         Update calls to DocumentWriter.
1086         https://bugs.webkit.org/show_bug.cgi?id=50489
1087
1088         * WebView/WebFrame.mm:
1089         (-[WebFrame _canProvideDocumentSource]):
1090
1091 2010-12-06  Chris Marrin  <cmarrin@apple.com>
1092
1093         Reviewed by Simon Fraser.
1094
1095         Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
1096         https://bugs.webkit.org/show_bug.cgi?id=49388
1097
1098         Got rid of GraphicsLayer::nativeLayer() call, replacing it with
1099         GraphicsLayer::platformLayer().
1100
1101         * WebCoreSupport/WebChromeClient.mm:
1102         (WebChromeClient::attachRootGraphicsLayer):
1103
1104 2010-12-04  Dan Bernstein  <mitz@apple.com>
1105
1106         Reviewed by Sam Weinig.
1107
1108         WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
1109         https://bugs.webkit.org/show_bug.cgi?id=50530
1110
1111         * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
1112         * WebView/WebHTMLView.mm:
1113         (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
1114         which is passed through to WebCore.
1115         * WebView/WebPDFView.mm:
1116         (isFrameInRange): Added this helper function.
1117         (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
1118         a check if the frame is in the range.
1119         * WebView/WebView.mm:
1120         (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
1121         (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
1122         parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
1123         * WebView/WebViewPrivate.h:
1124
1125 2010-12-03  Sam Weinig  <sam@webkit.org>
1126
1127         Reviewed by Maciej Stachowiak.
1128
1129         Enable <a ping> for Mac/Windows/WebKit2 builds
1130         <rdar://problem/8504473>
1131         https://bugs.webkit.org/show_bug.cgi?id=50488
1132
1133         * WebView/WebPreferences.mm:
1134         (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
1135
1136 2010-12-03  Jia Pu  <jpu@apple.com>
1137
1138         Reviewed by Darin Adler.
1139
1140         Need to move all code that applies correction into correction panel callback.
1141         https://bugs.webkit.org/show_bug.cgi?id=50426
1142         <rdar://problem/8720832>
1143
1144         * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
1145
1146         * WebCoreSupport/WebEditorClient.mm:
1147         (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
1148         (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
1149         (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.
1150
1151 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
1152
1153         Revert r73217 and r73227 because of continued bustage.
1154
1155         * WebCoreSupport/WebChromeClient.mm:
1156         (WebChromeClient::attachRootGraphicsLayer):
1157
1158 2010-12-02  Chris Marrin  <cmarrin@apple.com>
1159
1160         Reviewed by Simon Fraser.
1161
1162         Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
1163         https://bugs.webkit.org/show_bug.cgi?id=49388
1164
1165         Got rid of GraphicsLayer::nativeLayer() call, replacing it with
1166         GraphicsLayer::platformLayer().
1167
1168         * WebCoreSupport/WebChromeClient.mm:
1169         (WebChromeClient::attachRootGraphicsLayer):
1170
1171 2010-12-02  Mark Rowe  <mrowe@apple.com>
1172
1173         Reviewed by Beth Dakin.
1174
1175         <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool
1176
1177         * Misc/WebNSFileManagerExtras.m:
1178         (setMetaData): Create an autorelease pool for the duration of the thread body.
1179
1180 2010-12-02  John Knottenbelt  <jknotten@chromium.org>
1181
1182         Reviewed by Steve Block.
1183
1184         Move requestGeolocationPermissionForFrame to GeolocationClient
1185         https://bugs.webkit.org/show_bug.cgi?id=50061
1186
1187         This change facilitates client-based geolocation implementation by
1188         bringing together permission control into the geolocation client
1189         interface.
1190
1191         Move method ChromeClient::requestGeolocationPermissionForFrame to
1192         GeolocationClient::requestPermission, and supporting class
1193         WebGeolocationPolicyListener. The moved code is unchanged except
1194         that requestPermission now takes only one argument (Geolocation*)
1195         and the Frame parameter is retrieved from the Geolocation object.
1196
1197         * WebCoreSupport/WebChromeClient.h:
1198         * WebCoreSupport/WebChromeClient.mm:
1199         * WebCoreSupport/WebGeolocationClient.h:
1200         (WebGeolocationClient::cancelPermissionRequest):
1201         * WebCoreSupport/WebGeolocationClient.mm:
1202         (WebGeolocationClient::requestPermission):
1203         (-[WebGeolocationPolicyListener initWithGeolocation:]):
1204         (-[WebGeolocationPolicyListener allow]):
1205         (-[WebGeolocationPolicyListener deny]):
1206
1207 2010-12-02  Joseph Pecoraro  <joepeck@webkit.org>
1208
1209         Reviewed by Eric Carlson.
1210
1211         Style Fixes in WebPluginController
1212         https://bugs.webkit.org/show_bug.cgi?id=50397
1213
1214         * Plugins/WebPluginController.mm:
1215         (-[WebPluginController startAllPlugins]):
1216         (-[WebPluginController stopAllPlugins]):
1217
1218 2010-12-02  John Sullivan  <sullivan@apple.com>
1219
1220         Reviewed by Adam Roben.
1221
1222         Slightly speculative fix for:
1223
1224         <rdar://problem/8712674>
1225         <https://bugs.webkit.org/show_bug.cgi?id=50393>
1226         setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]
1227
1228         * Panels/WebAuthenticationPanel.m:
1229         (-[WebAuthenticationPanel setUpForChallenge:]):
1230         If the realm is nil, use @"" instead.
1231
1232 2010-12-01  Jia Pu  <jpu@apple.com>
1233
1234         Reviewed by Darin Adler.
1235
1236         Support multiple correction candidates panel for misspelled word on Mac OS X.
1237         https://bugs.webkit.org/show_bug.cgi?id=50137
1238         <rdar://problem/8568059>
1239
1240         This patch is for supporting multiple correction suggestion panel on Mac OS X.
1241         The behavior and implementation is similar to that of reversion candiate panel.
1242
1243         * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
1244
1245         * WebCoreSupport/WebEditorClient.mm:  Adopted new signatures defined in base class.
1246           Added code to handle new multiple suggestion canidate panel type.
1247         (WebEditorClient::showCorrectionPanel):
1248         (WebEditorClient::getGuessesForWord):
1249
1250 2010-12-01  David Hyatt  <hyatt@apple.com>
1251
1252         Reviewed by Darin Adler.
1253
1254         https://bugs.webkit.org/show_bug.cgi?id=46645
1255
1256         Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
1257         recently added for horizontal RTL documents and applies it to writing modes as well.  Now the
1258         scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
1259
1260         This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
1261         makes them behave the same as the cross-platform code (allowing for cross-platform results to be
1262         landed).
1263
1264         * WebView/WebDynamicScrollBarsView.mm:
1265         (-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
1266         (-[WebDynamicScrollBarsView updateScrollers]):
1267         (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
1268         (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
1269         (-[WebDynamicScrollBarsView scrollOrigin]):
1270         * WebView/WebFrameView.mm:
1271         (-[WebFrameView _scrollToBeginningOfDocument]):
1272         (-[WebFrameView _scrollToEndOfDocument]):
1273
1274 2010-11-29  Dan Bernstein  <mitz@apple.com>
1275
1276         Reviewed by Darin Adler.
1277
1278         WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
1279         https://bugs.webkit.org/show_bug.cgi?id=50038
1280         Based on a patch from Darin Adler.
1281
1282         * WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and
1283         replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
1284         method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
1285         method. Made WebHTMLView conform to the new protocol.
1286         * WebView/WebHTMLView.mm:
1287         (coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
1288         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
1289         -findString:options:.
1290         (-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
1291         (-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().
1292         * WebView/WebPDFView.mm:
1293         (-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
1294         * WebView/WebView.mm:
1295         (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
1296         -countMatchesForText:options:highlight:limit:markMatches.
1297         (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
1298         (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
1299         -findString:options:.
1300         (incrementFrame): Changed to use WebFindOptions.
1301         (findString): Added this helper method that performs the search using the best supported
1302         method for the document view.
1303         (-[WebView findString:options:]): Changed -searchFor::::: into this.
1304         (-[WebView canMarkAllTextMatches]):
1305         (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
1306         WebFindOptions.
1307         (-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
1308         (-[WebView rectsForTextMatches]): Ditto.
1309         * WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version
1310         of countMatchesForText:.
1311
1312 2010-11-29  Jeremy Moskovich  <jeremy@chromium.org>
1313
1314         Reviewed by David Hyatt.
1315
1316         Right-to-left pages should be scrollable to reveal left overflow.
1317         https://bugs.webkit.org/show_bug.cgi?id=23556
1318
1319         Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
1320         Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
1321         pages with a left overflow.
1322
1323         * WebView/WebDynamicScrollBarsView.h:
1324         * WebView/WebDynamicScrollBarsView.mm:
1325         (-[WebDynamicScrollBarsView inProgramaticScroll]):
1326         (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]):
1327         (-[WebDynamicScrollBarsView updateScrollers]):
1328         (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
1329         (-[WebDynamicScrollBarsView setScrollOriginX:]):
1330         (-[WebDynamicScrollBarsView scrollOriginX]):
1331         * WebView/WebFrameView.mm:
1332         (-[WebFrameView _scrollToBeginningOfDocument]):
1333         (-[WebFrameView _scrollToEndOfDocument]):
1334         * WebView/WebHTMLView.mm:
1335         (-[WebHTMLView _frameOrBoundsChanged]):
1336
1337 2010-11-22  Ryosuke Niwa  <rniwa@webkit.org>
1338
1339         Reviewed by Tony Chang.
1340
1341         SelectionController::typingStyle() should return EditingStyle*
1342         https://bugs.webkit.org/show_bug.cgi?id=49813
1343
1344         Changed the return value of SelectionController::typingStyle() to EditingStyle*.
1345         Also added SelectionController::copyTypingStyle() to copy the typing style
1346         as an instance of CSSMutableStyleDeclaration.
1347
1348         No tests are added since this is no behavioral change.
1349
1350         * WebView/WebFrame.mm:
1351         (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
1352
1353 2010-11-19  Michael Saboff  <msaboff@apple.com>
1354
1355         Reviewed by Sam Weinig
1356
1357         Remove DOMSVGAnimatedPathData.h from all: target to fix build.
1358
1359         * MigrateHeaders.make:
1360
1361 2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>
1362
1363         Reviewed by Dirk Schulze.
1364
1365         Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
1366         https://bugs.webkit.org/show_bug.cgi?id=49580
1367
1368         * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
1369
1370 2010-11-18  Mark Rowe  <mrowe@apple.com>
1371
1372         Rubber-stamped by Adam Roben.
1373
1374         <rdar://problem/8602509&8602717&8602724> Enable compaction support.
1375
1376         * Configurations/WebKit.xcconfig:
1377
1378 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1379
1380         Unreviewed, rolling out r72288.
1381         http://trac.webkit.org/changeset/72288
1382         https://bugs.webkit.org/show_bug.cgi?id=49730
1383
1384         'krit attempted to do that, but revert got stuck' (Requested
1385         by antonm on #webkit).
1386
1387         * WebView/WebRenderLayer.mm:
1388
1389 2010-11-17  Nikolas Zimmermann  <nzimmermann@rim.com>
1390
1391         Reviewed by Dirk Schulze.
1392
1393         Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
1394         https://bugs.webkit.org/show_bug.cgi?id=49580
1395
1396         * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
1397
1398 2010-11-16  Stephanie Lewis  <slewis@apple.com>
1399
1400         Reviewed by Geoff Garen.
1401
1402         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
1403
1404         Make a static provider for WebDeviceOrientationProviderMock.  The old code allocated a new WebDeviceOrientationProviderMock for
1405         every WebView, and the WebKit API doesn't support that ownership model.
1406
1407         * WebView/WebDeviceOrientationProviderMock.h:
1408         * WebView/WebDeviceOrientationProviderMock.mm:
1409         (+[WebDeviceOrientationProviderMock shared]):
1410
1411 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1412
1413         Reviewed by Dan Bernstein.
1414
1415         https://bugs.webkit.org/show_bug.cgi?id=11004
1416
1417         font-size:0 is ignored.  Remove the minimum font size of 1 in CSSStyleSelector.
1418         Change the pref value for minimum font size from 1 to 0.  Make sure to never use the NSFont's size,
1419         since it doesn't honor a size of 0.  Instead pass the size in to the FontPlatformData(NSFont*) version
1420         of the constructor rather than using [NSFont pointSize].
1421
1422         https://bugs.webkit.org/show_bug.cgi?id=49582
1423
1424         Negative leading is not handled correctly.  There are two bugs here.  The first is that
1425         maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
1426         set them before so that we can allow them to be < 0.
1427
1428         The second issue is that we should understand where fonts will end up relative to
1429         our baseline (excluding line height), and only allow those boxes to impact ascent and
1430         descent if the actual font box (without factoring in line height) is above or below the
1431         root line box baseline.
1432
1433         Added fast/css/negative-leading.html
1434
1435         These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
1436
1437         * Misc/WebKitNSStringExtras.mm:
1438         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1439         (-[NSString _web_widthWithFont:]):
1440         * Misc/WebStringTruncator.mm:
1441         (fontFromNSFont):
1442         * WebView/WebPreferences.mm:
1443         (+[WebPreferences initialize]):
1444
1445 2010-11-16  Anders Carlsson  <andersca@apple.com>
1446
1447         Fix clang++ build.
1448
1449         * WebCoreSupport/WebFrameLoaderClient.mm:
1450
1451 2010-11-14  Kent Tamura  <tkent@chromium.org>
1452
1453         Reviewed by Andreas Kling.
1454
1455         KeyboardEvent::keyIdentifier() should return "const String&"
1456         https://bugs.webkit.org/show_bug.cgi?id=49426
1457
1458         * WebCoreSupport/WebEditorClient.mm:
1459         (selectorForKeyEvent):
1460           Change the type of a variable to have keyIdentifier(); String -> const String&
1461
1462 2010-11-12  John Knottenbelt  <jknotten@chromium.org>
1463
1464         Reviewed by Steve Block.
1465
1466         Rename GeolocationControllerClient to GeolocationClient.
1467         https://bugs.webkit.org/show_bug.cgi?id=49259
1468
1469         * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h.
1470         (WebGeolocationClient::webView):
1471         (WebGeolocationClient::setEnableHighAccuracy):
1472         * WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm.
1473         (WebGeolocationClient::WebGeolocationClient):
1474         (WebGeolocationClient::geolocationDestroyed):
1475         (WebGeolocationClient::startUpdating):
1476         (WebGeolocationClient::stopUpdating):
1477         (WebGeolocationClient::lastPosition):
1478         * WebKit.order:
1479         * WebView/WebView.mm:
1480         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1481
1482 2010-11-10  Beth Dakin  <bdakin@apple.com>
1483
1484         Reviewed by Simon Fraser.
1485
1486         Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
1487         -[WebView _scaleWebView:] should take and origin and scroll the
1488         document
1489         -and corresponding-
1490         <rdar://problem/8643921>
1491
1492         * WebView/WebView.mm:
1493         (-[WebView _scaleWebView:atOrigin:]):
1494         * WebView/WebViewPrivate.h:
1495
1496 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1497
1498         Reviewed by David Hyatt.
1499
1500         HTML5 Ruby support should be mandatory feature
1501         https://bugs.webkit.org/show_bug.cgi?id=49272
1502
1503         Remove Ruby as optional feature.
1504
1505         * Configurations/FeatureDefines.xcconfig:
1506
1507 2010-11-08  Ned Holbrook  <nholbrook@apple.com>
1508
1509         Reviewed by Adam Barth.
1510
1511         Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
1512         https://bugs.webkit.org/show_bug.cgi?id=48886
1513
1514         * WebCoreSupport/WebSystemInterface.mm:
1515         (InitWebCoreSystemInterface):
1516
1517 2010-11-08  Nate Chapin  <japhet@chromium.org>
1518
1519         Unreviewed, build fix.
1520
1521         Clumsy typo in r71562.
1522
1523         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1524         (WebKit::HostedNetscapePluginStream::start):
1525
1526 2010-11-08  Nate Chapin  <japhet@chromium.org>
1527
1528         Reviewed by Alexey Proskuryakov.
1529
1530         Interface changes in https://bugs.webkit.org/show_bug.cgi?id=27165
1531
1532         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1533         (WebKit::HostedNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
1534         * Plugins/WebNetscapePluginStream.mm:
1535         (WebNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
1536         * WebView/WebView.mm:
1537         (-[WebView _dispatchPendingLoadRequests]): Use resourceLoadScheduler() instead of cache()->loader().
1538
1539 2010-11-08  Anders Carlsson  <andersca@apple.com>
1540
1541         Reviewed by Dan Bernstein.
1542
1543         Plug-in views should not assume that plugins are RenderEmbeddedObjects
1544         https://bugs.webkit.org/show_bug.cgi?id=49196
1545         <rdar://problem/8638467>
1546
1547         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1548         (-[WebHostedNetscapePluginView pluginHostDied]):
1549
1550 2010-11-08  Alexey Proskuryakov  <ap@apple.com>
1551
1552         Reviewed by Darin Adler.
1553
1554         https://bugs.webkit.org/show_bug.cgi?id=48685
1555         Notify UI process about focused frame
1556
1557         Added an empty implementation of the new ChromeClient method.
1558
1559         * WebCoreSupport/WebChromeClient.h:
1560         * WebCoreSupport/WebChromeClient.mm:
1561         (WebChromeClient::focusedFrameChanged):
1562
1563 2010-11-08  Anders Carlsson  <andersca@apple.com>
1564
1565         Build fix.
1566
1567         * MigrateHeaders.make:
1568
1569 2010-11-08  Anders Carlsson  <andersca@apple.com>
1570
1571         Reviewed by Adam Roben.
1572
1573         Remove use of HIGetScaleFactor
1574         https://bugs.webkit.org/show_bug.cgi?id=49186
1575         <rdar://problem/8618410>
1576
1577         Scale factors can vary on a display-by-display basis and it doesn't make sense
1578         to compute scale factor event coordinates like this.
1579
1580         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1581         (getCarbonEvent):
1582
1583 2010-11-08  Simon Fraser  <simon.fraser@apple.com>
1584
1585         Reviewed by Sam Weinig.
1586
1587         Allow applets to participate in accelerated compositing
1588         https://bugs.webkit.org/show_bug.cgi?id=49117
1589         <rdar://problem/8625819>
1590
1591         If Java is being loaded via the Netscape Plugin API, create a
1592         NetscapePluginWidget so that it has an implementation of platformLayer().
1593
1594         Also clean up by using early returns.
1595
1596         * WebCoreSupport/WebFrameLoaderClient.mm:
1597
1598 2010-11-07  Adam Barth  <abarth@webkit.org>
1599
1600         Reviewed by Eric Seidel.
1601
1602         Rename Cache to MemoryCache
1603         https://bugs.webkit.org/show_bug.cgi?id=49159
1604
1605         * Misc/WebCache.mm:
1606         (+[WebCache statistics]):
1607         * WebCoreSupport/WebDeviceOrientationClient.mm:
1608         (WebDeviceOrientationClient::setController):
1609         * WebView/WebView.mm:
1610
1611 2010-11-05  Alexey Proskuryakov  <ap@apple.com>
1612
1613         Reviewed by Darin Adler.
1614
1615         https://bugs.webkit.org/show_bug.cgi?id=49100
1616         ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]
1617
1618         * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]):
1619         Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive
1620         (see bug comments), and there seems to be no harm in executing this function in that case.
1621
1622 2010-11-05  Chris Marrin  <cmarrin@apple.com>
1623
1624         Reviewed by Simon Fraser.
1625
1626         Move resumeAnimations/suspendAnimations from Frame to AnimationController.
1627         https://bugs.webkit.org/show_bug.cgi?id=49073
1628
1629         * WebView/WebFrame.mm:
1630         (-[WebFrame _suspendAnimations]):
1631         (-[WebFrame _resumeAnimations]):
1632
1633 2010-11-04  Alexey Proskuryakov  <ap@apple.com>
1634
1635         Reviewed by Darin Adler.
1636
1637         https://bugs.webkit.org/show_bug.cgi?id=49008
1638         <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp
1639
1640         Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
1641         the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
1642         deleted during wait:
1643         - plugin crashed;
1644         - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in
1645         while waiting).
1646
1647         We didn't recognize the latter.
1648
1649         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1650         (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
1651         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1652         (WebKit::NetscapePluginInstanceProxy::waitForReply):
1653         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1654         (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
1655
1656 2010-11-05  Chris Marrin  <cmarrin@apple.com>
1657
1658         Reviewed by Simon Fraser.
1659
1660         Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
1661         https://bugs.webkit.org/show_bug.cgi?id=46945
1662
1663         * WebView/WebFrame.mm:
1664         (-[WebFrame _suspendAnimations]):
1665         (-[WebFrame _resumeAnimations]):
1666
1667 2010-11-04  Jia Pu  <jpu@apple.com>
1668
1669         Reviewed by Dan Bernstein.
1670
1671         reversion bubble in WebViews
1672         https://bugs.webkit.org/show_bug.cgi?id=47630
1673         <rdar://problem/8530960>
1674
1675         This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.
1676
1677         * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
1678         * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
1679           change to use new reversion API in AppKit.
1680         (WebEditorClient::WebEditorClient):
1681         (WebEditorClient::~WebEditorClient):
1682         (WebEditorClient::respondToChangedSelection):
1683         (WebEditorClient::showCorrectionPanel):
1684         (WebEditorClient::dismissCorrectionPanel):
1685         (WebEditorClient::isShowingCorrectionPanel):
1686
1687 2010-11-04  Mike Thole  <mthole@apple.com>
1688
1689         Reviewed by Dan Bernstein.
1690
1691         Title for images should use localized numerals
1692         https://bugs.webkit.org/show_bug.cgi?id=49017
1693
1694         * WebCoreSupport/WebPlatformStrategies.mm:
1695         (WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.
1696
1697 2010-11-02  Daniel Bates  <dbates@rim.com>
1698
1699         Reviewed by Adam Barth.
1700
1701         For unnamed frames, window.name returns a generated name
1702         https://bugs.webkit.org/show_bug.cgi?id=6751
1703
1704         Part 1 of 2.
1705
1706         Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port.
1707
1708         * WebView/WebFrame.mm:
1709         (-[WebFrame name]):
1710
1711 2010-11-01  Brady Eidson  <beidson@apple.com>
1712
1713         Reviewed by Anders Carlsson.
1714
1715         <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
1716         Context menu support for WebKit 2.
1717
1718         * WebCoreSupport/WebChromeClient.h:
1719         (WebChromeClient::showContextMenu):
1720
1721 2010-10-29  Daniel Bates  <dbates@rim.com>
1722
1723         No review, rolling out 70971.
1724         http://trac.webkit.org/changeset/70971
1725         https://bugs.webkit.org/show_bug.cgi?id=6751
1726
1727         Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
1728         it caused layout test failures on all bots. In particular, the
1729         child count in a generated frame name differs after this patch. We need
1730         to look into this further.
1731
1732         * WebView/WebFrame.mm:
1733         (-[WebFrame name]):
1734
1735 2010-10-28  Antonio Gomes  <agomes@rim.com>
1736
1737         Reviewed by Ojan Vafai.
1738
1739         Needs a "LinuxEditingBehavior", perhaps with a better name
1740         https://bugs.webkit.org/show_bug.cgi?id=36627
1741
1742         Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
1743
1744         * WebView/WebFrame.mm:
1745         (core):
1746         * WebView/WebPreferencesPrivate.h:
1747
1748 2010-10-29  Daniel Bates  <dbates@rim.com>
1749
1750         Reviewed by Adam Barth.
1751
1752         For unnamed frames, window.name returns a generated name
1753         https://bugs.webkit.org/show_bug.cgi?id=6751
1754
1755         Modified Mac-port to use FrameTree::uniqueName().
1756
1757         * WebView/WebFrame.mm:
1758         (-[WebFrame name]):
1759
1760 2010-10-29  Darin Adler  <darin@apple.com>
1761
1762         Reviewed by Sam Weinig.
1763
1764         Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
1765         https://bugs.webkit.org/show_bug.cgi?id=48574
1766
1767         * History/WebBackForwardList.mm:
1768         Use BackForwardListImpl.
1769
1770 2010-10-29  Alexey Proskuryakov  <ap@apple.com>
1771
1772         Rubber-stamped by Sam Weinig.
1773
1774         Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
1775         create views for subframes.
1776
1777         * WebView/WebViewData.h: Double negation is better than a lie.
1778
1779 2010-10-27  Jer Noble  <jer.noble@apple.com>
1780
1781         Reviewed by Darin Adler.
1782
1783         Full screen video in Safari (still) exits full-screen if you switch to another
1784         app on a multi-display system.
1785         https://bugs.webkit.org/show_bug.cgi?id=47364
1786         <rdar://problem/8382299>
1787
1788         The FullScreen window does not technically close when it deactivates, but the
1789         two NSWindows that make up the FullScreen feature should not hide when deactivated.
1790
1791         * WebView/WebVideoFullscreenController.mm:
1792         (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
1793         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
1794         * WebView/WebVideoFullscreenHUDWindowController.mm:
1795         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
1796
1797 2010-10-29  Alexey Proskuryakov  <ap@apple.com>
1798
1799         Reviewed by Darin Adler.
1800
1801         https://bugs.webkit.org/show_bug.cgi?id=48576
1802         Let WebKit2 client know when a frame is a frameset
1803
1804         Added a blank implementation of the new FrameLoaderClient method.
1805
1806         * WebCoreSupport/WebFrameLoaderClient.h:
1807         * WebCoreSupport/WebFrameLoaderClient.mm:
1808         (WebFrameLoaderClient::dispatchDidBecomeFrameset):
1809
1810 2010-10-29  Csaba Osztrogonác  <ossy@webkit.org>
1811
1812         Reviewed by Adam Roben and David Kilzer.
1813
1814         Fix and cleanup of build systems
1815         https://bugs.webkit.org/show_bug.cgi?id=48342
1816
1817         * Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.
1818
1819 2010-10-28  Dan Bernstein  <mitz@apple.com>
1820
1821         Reviewed by Mark Rowe.
1822
1823         LLVM compiler build fix
1824
1825         * Misc/WebDownload.mm:
1826         (-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
1827         id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.
1828
1829 2010-10-28  Ivan Krstić  <ike@apple.com>
1830
1831         Reviewed by Mark Rowe.
1832
1833         Remove unused experimental proxied panel interface.
1834         <rdar://problem/7237059>
1835
1836         * Plugins/Hosted/NetscapePluginHostManager.h:
1837         * Plugins/Hosted/NetscapePluginHostManager.mm:
1838         (WebKit::NetscapePluginHostManager::hostForPlugin):
1839         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1840         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1841         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1842         * Plugins/Hosted/WebKitPluginClient.defs:
1843         * Plugins/Hosted/WebKitPluginHost.defs:
1844         * WebCoreSupport/WebSystemInterface.mm:
1845         (InitWebCoreSystemInterface):
1846         * WebView/WebPreferenceKeysPrivate.h:
1847         * WebView/WebPreferences.mm:
1848         (+[WebPreferences initialize]):
1849         * WebView/WebPreferencesPrivate.h:
1850
1851 2010-10-27  Pratik Solanki  <psolanki@apple.com>
1852
1853         Reviewed by Darin Adler.
1854
1855         Improve memSize calculation in [WebView _setCacheModel]
1856         https://bugs.webkit.org/show_bug.cgi?id=48484
1857
1858         * WebView/WebView.mm:
1859         (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2.
1860         (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next
1861         bigger power of 2. Also update WebCore cache settings.
1862
1863 2010-10-26  Darin Adler  <darin@apple.com>
1864
1865         Reviewed by Sam Weinig.
1866
1867         WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
1868         https://bugs.webkit.org/show_bug.cgi?id=42322
1869         rdar://problem/8193631
1870
1871         WebKitTestRunner needs to support layoutTestController.clearBackForwardList
1872         https://bugs.webkit.org/show_bug.cgi?id=42333
1873         rdar://problem/8193643
1874
1875         * History/WebBackForwardList.mm:
1876         (core): Return BackForwardListImpl.
1877         (kit): Take BackForwardListImpl.
1878         (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
1879         (-[WebBackForwardList dealloc]): Ditto.
1880         (-[WebBackForwardList finalize]): Ditto.
1881         (-[WebBackForwardList description]): Ditto.
1882         (-[WebBackForwardList setPageCacheSize:]): Ditto.
1883         (-[WebBackForwardList pageCacheSize]): Ditto.
1884         * History/WebBackForwardListInternal.h: Ditto.
1885         * WebView/WebFrameView.mm:
1886         (-[WebFrameView keyDown:]): Ditto.
1887         * WebView/WebView.mm:
1888         (-[WebView initWithCoder:]): Ditto.
1889         (-[WebView encodeWithCoder:]): Ditto.
1890         (-[WebView backForwardList]): Ditto.
1891         (-[WebView setMaintainsBackForwardList:]): Ditto.
1892
1893 2010-10-27  Chris Rogers  <crogers@google.com>
1894
1895         Reviewed by Chris Marrin.
1896
1897         Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
1898         https://bugs.webkit.org/show_bug.cgi?id=48279
1899
1900         * Configurations/FeatureDefines.xcconfig:
1901
1902 2010-10-27  Beth Dakin  <bdakin@apple.com>
1903
1904         Reviewed by Darin Adler.
1905
1906         Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit
1907         SPI to scale a WebView
1908         -and corresponding-
1909         <rdar://problem/8107667>
1910
1911         This patch adds SPI to Mac WebKit that scales the page by the given
1912         scale factor.
1913
1914         * WebView/WebView.mm:
1915         (-[WebView _scaleWebView:]):
1916         (-[WebView _viewScaleFactor]):
1917         * WebView/WebViewPrivate.h:
1918
1919 2010-10-27  Dan Bernstein  <mitz@apple.com>
1920
1921         Reviewed by Darin Adler.
1922
1923         REGRESSION (r70335): Incorrect article layout in Safari Reader
1924         https://bugs.webkit.org/show_bug.cgi?id=48436
1925
1926         * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
1927         * WebView/WebView.mm:
1928         (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
1929         versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
1930         (-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
1931         based on the above.
1932
1933 2010-10-18  Jer Noble  <jer.noble@apple.com>
1934
1935         Reviewed by Eric Carlson.
1936
1937         Safari fullscreen media element tickles when it should not.
1938
1939         https://bugs.webkit.org/show_bug.cgi?id=47861
1940
1941         * WebView/WebVideoFullscreenController.mm:
1942         (-[WebVideoFullscreenController updatePowerAssertions]):
1943
1944 2010-10-26  Jenn Braithwaite  <jennb@chromium.org>
1945
1946         Reviewed by Dmitry Titov.
1947
1948         Resource tracking failure when trying to move a frame between documents
1949         https://bugs.webkit.org/show_bug.cgi?id=44713
1950
1951         * WebCoreSupport/WebFrameLoaderClient.h:
1952         * WebCoreSupport/WebFrameLoaderClient.mm:
1953         (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
1954         Empty method.
1955         (WebFrameLoaderClient::transferLoadingResourceFromPage):
1956         Update resource tracking for a resource load that has been transferred
1957         to a new page.
1958
1959 2010-10-25  Oliver Hunt  <oliver@apple.com>
1960
1961         Reviewed by Gavin Barraclough.
1962
1963         Remove exec and globalData arguments from jsNumber
1964         https://bugs.webkit.org/show_bug.cgi?id=48270
1965
1966         Mechanical removal of exec parameter to jsNumber
1967
1968         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1969         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
1970         * Plugins/Hosted/ProxyInstance.mm:
1971         (WebKit::ProxyInstance::numberValue):
1972
1973 2010-10-24  Dan Bernstein  <mitz@apple.com>
1974
1975         Reviewed by Anders Carlsson.
1976
1977         Expose HitTestResult::absoluteMediaURL() via WebKit API
1978         https://bugs.webkit.org/show_bug.cgi?id=48219
1979
1980         * Misc/WebElementDictionary.mm:
1981         (+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
1982         _absoluteMediaURL.
1983         (-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().
1984         * WebKit.exp: Export WebElementMediaURLKey.
1985         * WebView/WebView.mm: Define WebElementMediaURLKey.
1986         * WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.
1987
1988 2010-10-24  Dan Bernstein  <mitz@apple.com>
1989
1990         Reviewed by Simon Fraser.
1991
1992         Removed deprecated methods from the WebHTMLHighlighter private protocol.
1993
1994         * WebCoreSupport/WebChromeClient.mm:
1995         (WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
1996         unconditionally.
1997         (WebChromeClient::paintCustomHighlight): Call
1998         -paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.
1999         * WebView/WebHTMLViewPrivate.h:
2000
2001 2010-10-23  Xan Lopez  <xlopez@igalia.com>
2002
2003         Reviewed by Sam Weinig.
2004
2005         Unify globalData APIs
2006         https://bugs.webkit.org/show_bug.cgi?id=47969
2007
2008         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2009         (WebKit::NetscapePluginInstanceProxy::evaluate):
2010         (WebKit::NetscapePluginInstanceProxy::invoke):
2011         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2012         (WebKit::NetscapePluginInstanceProxy::construct):
2013         * WebView/WebScriptDebugDelegate.mm:
2014         (-[WebScriptCallFrame evaluateWebScript:]):
2015
2016 2010-10-23  David Kilzer  <ddkilzer@apple.com>
2017
2018         <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
2019
2020         Reviewed by Sam Weinig.
2021
2022         The only method defined in WebHTMLRepresentationInternal.h is
2023         also defined in WebHTMLRepresentation.h, so use that instead.
2024
2025         * WebView/WebHTMLRepresentationInternal.h: Removed.
2026
2027 2010-10-23  Alexey Proskuryakov  <ap@apple.com>
2028
2029         Reviewed by Anders Carlsson.
2030
2031         https://bugs.webkit.org/show_bug.cgi?id=48083
2032         <rdar://problem/8489082> Need WebKit2 API for private browsing (48083)
2033
2034         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize the new method.
2035
2036 2010-10-22  Sam Weinig  <sam@webkit.org>
2037
2038         Reviewed by Anders Carlsson.
2039
2040         WebKit2 needs to pass the current event modifier flags when requesting a new window
2041         https://bugs.webkit.org/show_bug.cgi?id=48140
2042
2043         * WebCoreSupport/WebChromeClient.h:
2044         * WebCoreSupport/WebChromeClient.mm:
2045         (WebChromeClient::createWindow):
2046         * WebCoreSupport/WebFrameLoaderClient.h:
2047         * WebCoreSupport/WebFrameLoaderClient.mm:
2048         (WebFrameLoaderClient::dispatchCreatePage):
2049         Add NavigationAction parameter.
2050
2051 2010-10-21  Andy Estes  <aestes@apple.com>
2052
2053         Reviewed by Eric Carlson.
2054
2055         WebKit shouldn't load a plug-in based on file extension if a MIME type
2056         is specified.
2057         https://bugs.webkit.org/show_bug.cgi?id=48046
2058
2059         If a MIME type is specified in an object or embed element, and that MIME
2060         type isn't supported by an installed plug-in, WebKit shouldn't attempt
2061         to find a plug-in based on the file extension of the url attribute.
2062         Doing so can lead to cases where a plug-in is loaded that can't handle
2063         resources of the MIME type specified by the author.
2064
2065         * WebCoreSupport/WebFrameLoaderClient.mm:
2066         (WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by
2067         extension if MIME type is the empty string.
2068
2069 2010-10-20  Simon Fraser  <simon.fraser@apple.com>
2070
2071         Reviewed by Dan Bernstein.
2072
2073         Composited elements drawn twice when WebView is layer-backed
2074         https://bugs.webkit.org/show_bug.cgi?id=48024
2075         <rdar://problem/7916580>
2076
2077         When drawing content in a layer-backed WebView, WebFrame's test
2078         for drawing to a bitmap succeeded, causing us to paint flattened
2079         compositing layers into the view. They would also be rendered
2080         by the normal compositing path, resulting in double rendering.
2081
2082         Fix this by detecting when the WebHTMLView is being drawn into
2083         a layer, and avoiding flattening in that case.
2084
2085         * WebView/WebFrame.mm:
2086         (-[WebFrame _showFlattenedCompositingLayers:]):
2087         (-[WebFrame _drawRect:contentsOnly:]):
2088         * WebView/WebHTMLView.mm:
2089         (-[WebHTMLView drawLayer:inContext:]):
2090         (-[WebHTMLView _web_isDrawingIntoLayer]):
2091         * WebView/WebHTMLViewInternal.h:
2092
2093 2010-10-20  Dumitru Daniliuc  <dumi@chromium.org>
2094
2095         Reviewed by David Levin.
2096
2097         Repost the DatabaseTracker notifications to the main thread, if needed.
2098         https://bugs.webkit.org/show_bug.cgi?id=40655
2099
2100         * Storage/WebDatabaseTrackerClient.mm:
2101         (DidModifyOriginData::dispatchToMainThread):
2102         (DidModifyOriginData::DidModifyOriginData):
2103         (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
2104         (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
2105         (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
2106
2107 2010-10-20  Simon Fraser  <simon.fraser@apple.com>
2108
2109         Reviewed by Darin Adler.
2110
2111         REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard
2112         https://bugs.webkit.org/show_bug.cgi?id=47369
2113
2114         r46947 added code that limits the size of the layer-backed view on Leopard when
2115         the page height exceeds 4096px (later adjusted to 2048px in r48401).
2116
2117         Later, r67576 altered the geometry flipping behavior to push the geometry flipping
2118         down into WebKit. However, the code that adjusts the hosting layer's sublayer transform
2119         to account for layer-backed view size-limiting was not fixed at the same time.
2120         This change corrects that.
2121
2122         * WebView/WebHTMLView.mm:
2123         (-[WebHTMLView _updateLayerHostingViewPosition]):
2124
2125 2010-10-19  Simon Fraser  <simon.fraser@apple.com>
2126
2127         Reviewed by Dan Bernstein.
2128
2129         <rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews
2130
2131         AppKit has some special code to prevent it meddling with view's layers
2132         under layer-backed WebViews. When a layer-backed WebView became composited,
2133         this caused our layer to remain zero-sized. Fix this by manually
2134         setting the geometry for our layer, if the WebHTMLView has a layer.
2135
2136         This does not seem to be a problem if the WebView becomes layer-backed, or
2137         stops being layer-backed after the WebView starts using compositing.
2138
2139         * WebView/WebHTMLView.mm:
2140         (-[WebHTMLView attachRootLayer:]):
2141
2142 2010-10-20  Dirk Schulze  <krit@webkit.org>
2143
2144         Reviewed by Nikolas Zimmermann.
2145
2146         Merge ColorSpace and ImageColorSpace enums
2147         https://bugs.webkit.org/show_bug.cgi?id=47922
2148
2149         Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
2150         to follow webkit style rules.
2151
2152         * Misc/WebKitNSStringExtras.mm:
2153         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2154
2155 2010-10-19  Alexey Proskuryakov  <ap@apple.com>
2156
2157         Reviewed by Anders Carlsson.
2158
2159         https://bugs.webkit.org/show_bug.cgi?id=47933
2160         <rdar://problem/8494337> navigator.language doesn't work in WebKit2
2161
2162         * Misc/WebNSUserDefaultsExtras.mm: Moved code for computing default language to WebCore.
2163         We need to keep _webkit_preferredLanguageCode for Safari.
2164
2165         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
2166         Initialize wkCopyCFLocalizationPreferredName.
2167
2168         * WebCoreSupport/WebViewFactory.mm: Removed defaultLanguage. WebCore was the only caller.
2169
2170 2010-10-18  Alexey Proskuryakov  <ap@apple.com>
2171
2172         Reviewed by David Kilzer.
2173
2174         https://bugs.webkit.org/show_bug.cgi?id=47864
2175         Convert WebNSUserDefaultsExtras.m to .mm
2176
2177         Also, fixed some issues in the process:
2178         - removed locking, which was only necessary when this code was in Foundation;
2179         - fixed notification center observer to actually work (previously, it picked up changes
2180         when application preferences changed, not when system language did);
2181         - removed unused NSString category;
2182         - updated style.
2183
2184         * Misc/WebNSUserDefaultsExtras.m: Removed.
2185         * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m.
2186         (createHTTPStyleLanguageCode):
2187         (+[NSUserDefaults _webkit_defaultsDidChange]):
2188         (addLanguageChangeObserver):
2189         (+[NSUserDefaults _webkit_preferredLanguageCode]):
2190
2191 2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>
2192
2193         Reviewed by Eric Seidel.
2194
2195         Switch to using the new Carbon NPAPI event declarations, and remove
2196         the old ones.
2197
2198         https://bugs.webkit.org/show_bug.cgi?id=40784
2199
2200         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2201         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
2202         (WebNetscapePluginEventHandlerCarbon::mouseExited):
2203         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
2204         (WebNetscapePluginEventHandlerCarbon::focusChanged):
2205
2206 2010-10-18  Pavel Podivilov  <podivilov@chromium.org>
2207
2208         Reviewed by Timothy Hatcher.
2209
2210         Web Inspector: disable private browsing for inspector
2211         https://bugs.webkit.org/show_bug.cgi?id=47827
2212
2213         * WebCoreSupport/WebInspectorClient.mm:
2214         (-[WebInspectorWindowController init]):
2215
2216 2010-10-14  Ilya Tikhonovsky  <loislo@chromium.org>
2217
2218         Reviewed by Pavel Feldman.
2219
2220         Web Inspector: inspector settings/properties/states management
2221         should be extracted into separate class.
2222
2223         We have a lot of flags/values in InspectorController.
2224         Some flags are persisting into profile.
2225         Others are part of inspector state for frontend.
2226         All these flags should keep their values after navigation.
2227         It'd be better to extract these flags/values into separate
2228         class which will care about theirs lifetime.
2229
2230         https://bugs.webkit.org/show_bug.cgi?id=47275
2231
2232         * WebCoreSupport/WebInspectorClient.mm:
2233         (-[WebInspectorWindowController showWindow:]):
2234         (-[WebInspectorWindowController attach]):
2235         (-[WebInspectorWindowController detach]):
2236
2237 2010-10-13  Gavin Barraclough  <barraclough@apple.com>
2238
2239         Reviewed by Oliver Hunt.
2240
2241         https://bugs.webkit.org/show_bug.cgi?id=43987
2242         Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
2243         to construct their internal result string.  Remove ScriptString (this is now
2244         redundant).
2245
2246         * WebCoreSupport/WebFrameLoaderClient.mm:
2247
2248 2010-10-12  Andy Estes  <aestes@apple.com>
2249
2250         Rubber-stamped by Darin Adler.
2251
2252         Check in some cleanup from the previous commit.
2253
2254         * WebView/WebView.mm:
2255         (leakMailQuirksUserScriptPath): Renamed to indicate that this function
2256         leaks an NSString.
2257         (-[WebView _injectMailQuirksScript]): Moved a static initialization from
2258         a separate class method into the only method that used it and removed
2259         the now-unnecessary class method.
2260
2261 2010-10-12  Eric Seidel  <eric@webkit.org>
2262
2263         Reviewed by Darin Adler.
2264
2265         REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
2266         https://bugs.webkit.org/show_bug.cgi?id=45693
2267
2268         Re-implement this former WebCore parser quirk as a
2269         Mac-only userscript-based quirk.  As far as I can tell
2270         from Darin's description this should satisfy Mail's needs.
2271
2272         * Misc/MailQuirksUserScript.js: Added.
2273         * WebView/WebView.mm:
2274         (+[WebView _mailQuirksUserScript]):
2275         (-[WebView _injectMailQuirksScript]):
2276         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2277
2278 2010-10-12  Simon Fraser  <simon.fraser@apple.com>
2279
2280         Reviewed by Sam Weinig.
2281
2282         Add 'didDraw' callback for framerate tracking
2283         https://bugs.webkit.org/show_bug.cgi?id=47478
2284
2285         Add a callback at the end of -[WebHTMLView drawRect:] so
2286         a delegate can get notified when a draw happens.
2287
2288         * WebView/WebHTMLView.mm:
2289         (-[WebHTMLView drawRect:]):
2290         * WebView/WebUIDelegatePrivate.h:
2291
2292 2010-10-11  Anders Carlsson  <andersca@apple.com>
2293
2294         Reviewed by Darin Adler.
2295
2296         Remove WebIconFetcher from WebKit and IconFetcher from WebCore
2297         https://bugs.webkit.org/show_bug.cgi?id=47523
2298
2299         Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
2300
2301         * Misc/WebIconFetcher.h: Removed.
2302         * Misc/WebIconFetcher.mm: Removed.
2303         * Misc/WebIconFetcherInternal.h: Removed.
2304         * WebView/WebFrame.mm:
2305         * WebView/WebFramePrivate.h:
2306
2307 2010-10-11  Jessie Berlin  <jberlin@apple.com>
2308
2309         Reviewed by Darin Adler.
2310
2311         Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
2312         representation of a WebKit1 WebSerializedJSValue.
2313         https://bugs.webkit.org/show_bug.cgi?id=47439
2314
2315         * WebView/WebSerializedJSValue.mm:
2316         (-[WebSerializedJSValue internalRepresentation]):
2317         * WebView/WebSerializedJSValuePrivate.h:
2318
2319 2010-10-07  Jessie Berlin  <jberlin@apple.com>
2320
2321         Reviewed by Sam Weinig.
2322
2323         Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
2324         representation of a WebKit2 WebSerializedScriptValue.
2325         https://bugs.webkit.org/show_bug.cgi?id=47390
2326
2327         * WebView/WebSerializedJSValue.mm:
2328         (-[WebSerializedJSValue initWithInternalRepresentation:]):
2329         Set the WebSerializedJSValuePrivate's WebCore::SerializedScriptValue to be the passed in
2330         internal representation.
2331         * WebView/WebSerializedJSValuePrivate.h: Added.
2332
2333 2010-10-07  Antonio Gomes  <agomes@rim.com>
2334
2335         Reviewed by Simon Fraser.
2336
2337         [Mac] [DRT] implement setSpatialNavigationEnabled
2338         https://bugs.webkit.org/show_bug.cgi?id=47291
2339
2340         Added the needed bits to make it possible to enabled spatial navigation
2341         for the Mac port. For now it is being only used by DRT.
2342
2343         * WebView/WebPreferenceKeysPrivate.h:
2344         * WebView/WebPreferences.mm:
2345         (+[WebPreferences initialize]):
2346         (-[WebPreferences isSpatialNavigationEnabled]):
2347         (-[WebPreferences setSpatialNavigationEnabled:]):
2348         * WebView/WebPreferencesPrivate.h:
2349         * WebView/WebView.mm:
2350         (-[WebView _preferencesChangedNotification:]):
2351
2352 2010-10-07  Jer Noble  <jer.noble@apple.com>
2353
2354         Fix the Leopard 64-bit build.
2355
2356         * Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the
2357             framework search path.
2358         * WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.
2359
2360 2010-10-06  Jer Noble  <jer.noble@apple.com>
2361
2362         Reviewed by Darin Adler.
2363
2364         Screensaver starts while watching fullscreen playback.
2365         https://bugs.webkit.org/show_bug.cgi?id=47299
2366         <rdar://problem/8478956>
2367
2368         To disable the Screen Saver, we need to periodically call UpdateSystemActivity().
2369
2370         * WebView/WebVideoFullscreenController.h: Added _tickleTimer.
2371         * WebView/WebVideoFullscreenController.mm:
2372         (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer.
2373         (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer.
2374         (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer.
2375         (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity().
2376         (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer
2377             or _disableTickleTimer.
2378
2379 2010-10-05  Philippe Normand  <pnormand@igalia.com>
2380
2381         Reviewed by Martin Robinson.
2382
2383         check for ENABLE(GLIB_SUPPORT) in WebView
2384         https://bugs.webkit.org/show_bug.cgi?id=46788
2385
2386         Use ENABLE(GLIB_SUPPORT) in WebView to guard the glib runloop observer.
2387
2388         * WebView/WebView.mm:
2389         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2390         (-[WebView _close]):
2391         * WebView/WebViewData.h:
2392         * WebView/WebViewInternal.h:
2393
2394 2010-10-01  Anders Carlsson  <andersca@apple.com>
2395
2396         Fix Snow Leopard build.
2397
2398         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2399         (WebKit::NetscapePluginInstanceProxy::getProxy):
2400
2401 2010-10-01  Anders Carlsson  <andersca@apple.com>
2402
2403         Reviewed by Dan Bernstein.
2404
2405         Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
2406         https://bugs.webkit.org/show_bug.cgi?id=47022
2407         <rdar://problem/8504712>
2408
2409         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2410         (WebKit::NetscapePluginInstanceProxy::getProxy):
2411         * Plugins/WebBaseNetscapePluginView.h:
2412         * Plugins/WebBaseNetscapePluginView.mm:
2413         * Plugins/WebNetscapePluginView.mm:
2414         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
2415
2416 2010-09-30  Darin Adler  <darin@apple.com>
2417
2418         Reviewed by Sam Weinig.
2419
2420         Remove remaining calls to deprecatedParseURL
2421         https://bugs.webkit.org/show_bug.cgi?id=26599
2422
2423         * DOM/WebDOMOperations.mm:
2424         (-[DOMDocument URLWithAttributeString:]):
2425         * WebCoreSupport/WebFrameLoaderClient.mm:
2426         (WebFrameLoaderClient::createPlugin):
2427         Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
2428
2429 2010-09-30  Anders Carlsson  <andersca@apple.com>
2430
2431         Reviewed by Darin Adler.
2432
2433         -[DOMDocument _documentRange] throws an exception if there is no document element
2434         https://bugs.webkit.org/show_bug.cgi?id=46934
2435         <rdar://problem/8169260>
2436
2437         If there is no document element, just return an empty range. Otherwise we'll try to call
2438         Range::selectNode with a null Node which will throw a NOT_FOUND exception.
2439
2440         * DOM/WebDOMOperations.mm:
2441         (-[DOMDocument _documentRange]):
2442
2443 2010-09-30  Chris Marrin  <cmarrin@apple.com>
2444
2445         Reviewed by Simon Fraser.
2446
2447         Make 2D accelerated canvas rendering build on Mac
2448         https://bugs.webkit.org/show_bug.cgi?id=46007
2449
2450         Added ACCELERATED_2D_CANVAS to FeatureDefines
2451
2452         * Configurations/FeatureDefines.xcconfig:
2453
2454 2010-09-30  Dan Bernstein  <mitz@apple.com>
2455
2456         Reviewed by John Sullivan.
2457
2458         Add printing SPI allowing full control over shrink-to-fit
2459         https://bugs.webkit.org/show_bug.cgi?id=46877
2460
2461         * WebView/WebHTMLView.mm:
2462         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.
2463         * WebView/WebHTMLViewPrivate.h:
2464
2465 2010-09-28  Johnny Ding  <jnd@chromium.org>
2466
2467         Reviewed by Adam Barth.
2468
2469         https://bugs.webkit.org/show_bug.cgi?id=41292
2470         Some windowed plugins did not handle events through EventHandler, so we
2471         never set right gesture state for those events.
2472         This change is to set right allowPopupsFromPlugin flag to current
2473         execution frame, so WeKit can always get right gesture state on Mac.
2474         From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
2475         process, that process passes the allowPopupsFromPlugin flag to
2476         WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
2477         NetscapePluginInstanceProxy::evaluate.
2478
2479         * Plugins/WebNetscapePluginView.mm:
2480         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2481
2482 2010-09-28  Jenn Braithwaite  <jennb@chromium.org>
2483
2484         Reviewed by Dmitry Titov.
2485
2486         Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
2487         https://bugs.webkit.org/show_bug.cgi?id=46663
2488
2489         * WebCoreSupport/WebFrameLoaderClient.h:
2490         * WebCoreSupport/WebFrameLoaderClient.mm:
2491         (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
2492
2493 2010-09-26  Antonio Gomes  <agomes@rim.com>
2494
2495         Reviewed by Kenneth Rohde Christiansen.
2496
2497         DRT/Mac nodesFromRect support
2498
2499         [Mac][DRT] Implement LayoutTestController::nodesFromRect
2500         https://bugs.webkit.org/show_bug.cgi?id=46580
2501
2502         Implement nodesFromRect as a private method to access non-exposed Document
2503         methods, similarly to computedStyleIncludingVisitedInfo.
2504
2505         * WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.
2506         These headers makes it possible to:
2507         1) Get a Document off of a JSDocument;
2508         2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
2509         gotten from Document::nodesFromRect to JS bindings.
2510         (-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):
2511         * WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the
2512         Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.
2513
2514 2010-09-24  Jia Pu  <jpu@apple.com>
2515
2516         Reviewed by Dan Bernstein.
2517
2518         automaticSpellingCorrectionEnabled isn't updated.
2519         https://bugs.webkit.org/show_bug.cgi?id=46486
2520         <rdar://problem/8475212>
2521
2522         * WebView/WebView.mm:
2523         (+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"
2524           instead of "automaticTextReplacementEnabled".
2525
2526 2010-09-23  Alexey Proskuryakov  <ap@apple.com>
2527
2528         Reviewed by Darin Adler.
2529
2530         https://bugs.webkit.org/show_bug.cgi?id=46380
2531         REGRESSION: Crash when downloading a file
2532
2533         Downloading cannot be tested in DRT.
2534
2535         * Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2536         Don't copy null strings.
2537
2538 2010-09-24  Ilya Tikhonovsky  <loislo@chromium.org>
2539
2540         Reviewed by Yury Semikhatsky.
2541
2542         Web Inspector: CRASH at node highlight on MAC Safari.
2543         1) run-safari --debug
2544         2) open inspector
2545         3) open elements panel
2546         4) hover mouse over elements panel items multiple times
2547         5) CRASH
2548         Looks like it is a race condition. WebNodeHighlightView doesn't check
2549         the pointer to WebNodeHighligh object and it can be nil.
2550
2551         https://bugs.webkit.org/show_bug.cgi?id=46261
2552
2553         * WebInspector/WebNodeHighlightView.mm:
2554         (-[WebNodeHighlightView drawRect:]):
2555
2556 2010-09-23  Andy Estes  <aestes@apple.com>
2557
2558         Reviewed by Darin Adler.
2559
2560         REGRESSION (r61285): some Dashboard widgets are always invisible due to
2561         HTML parser changes.
2562         https://bugs.webkit.org/show_bug.cgi?id=46435
2563
2564         Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility
2565         mode.
2566
2567         * WebView/WebView.mm:
2568         (-[WebView _needsPreHTML5ParserQuirks]): Renamed from
2569         shouldUsePreHTML5ParserQuirks(). Return true if
2570         WebCore::Settings::usesDashboardCompatibilityMode() is true.
2571         (-[WebView _preferencesChangedNotification:]):
2572         (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks
2573         if Dashboard behavior is set to backward compatibility mode.
2574
2575 2010-09-23  Matthew Delaney  <mdelaney@apple.com>
2576
2577         Reviewed by Simon Fraser.
2578
2579         Reduce minimum DOMTimer interval
2580         https://bugs.webkit.org/show_bug.cgi?id=45362
2581
2582         * WebView/WebView.mm:
2583         Updating set interval call to use Settings' static version inside
2584         one time init block.
2585
2586 2010-09-22  Andy Estes  <aestes@apple.com>
2587
2588         Reviewed by Darin Adler.
2589
2590         REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window
2591         https://bugs.webkit.org/show_bug.cgi?id=46334
2592
2593         Microsoft My Day loads scripts using self-closing script tags, markup
2594         which is incompatible with the HTML5 parser. Enable parser quirks for
2595         this application.
2596
2597         * WebView/WebView.mm:
2598         (shouldUsePreHTML5ParserQuirks): Return true if the application is
2599         Microsoft My Day and was linked against a version of WebKit prior to the
2600         introduction of the HTML5 parser.
2601
2602 2010-09-23  Nate Chapin  <japhet@chromium.org>
2603
2604         Reviewed by Darin Fisher.
2605
2606         Add hyperlink auditing settings (i.e., <a ping>).
2607         https://bugs.webkit.org/show_bug.cgi?id=30458
2608
2609         * WebView/WebPreferenceKeysPrivate.h:
2610         * WebView/WebPreferences.mm:
2611         (+[WebPreferences initialize]):
2612         (-[WebPreferences setMemoryInfoEnabled:]):
2613         (-[WebPreferences hyperlinkAuditingEnabled]):
2614         (-[WebPreferences setHyperlinkAuditingEnabled:]):
2615         * WebView/WebPreferencesPrivate.h:
2616         * WebView/WebView.mm:
2617         (-[WebView _preferencesChangedNotification:]):
2618
2619 2010-09-22  Alexey Proskuryakov  <ap@apple.com>
2620
2621         Reviewed by Anders Carlsson.
2622
2623         https://bugs.webkit.org/show_bug.cgi?id=43667
2624         ASSERT failure in NetscapePluginInstanceProxy::disconnectStream
2625
2626         Test: plugins/get-javascript-url.html
2627
2628         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2629         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just
2630         like any other one.
2631
2632 2010-09-21  Darin Adler  <darin@apple.com>
2633
2634         Reviewed by Anders Carlsson.
2635
2636         Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
2637         https://bugs.webkit.org/show_bug.cgi?id=46220
2638
2639         * Misc/WebNSFileManagerExtras.m:
2640         (setMetaData): Use CFRelease instead of HardRelease.
2641         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Use CFStringCreateCopy
2642         instead of -[NSObject copy] combined with HardRetainWithNSRelease.
2643
2644 2010-09-22  Balazs Kelemen  <kb@inf.u-szeged.hu>
2645
2646         Reviewed by Kenneth Rohde Christiansen.
2647
2648         PluginStrategy should satisfy the needs of Qt
2649         https://bugs.webkit.org/show_bug.cgi?id=45857
2650         No new functionality so no new tests.
2651
2652         * WebCoreSupport/WebPlatformStrategies.h:
2653         * WebCoreSupport/WebPlatformStrategies.mm:
2654         (WebPlatformStrategies::getPluginInfo):
2655
2656 2010-09-22  Paul Knight  <pknight@apple.com>
2657
2658         Reviewed by Simon Fraser.
2659
2660         -[WebView _scheduleCompositingLayerSync] should wake the run loop
2661         https://bugs.webkit.org/show_bug.cgi?id=46226
2662
2663         Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting.
2664
2665         * WebView/WebView.mm:
2666         (-[WebView _scheduleCompositingLayerSync]):
2667
2668 2010-09-21  Andy Estes  <aestes@apple.com>
2669
2670         Reviewed by Darin Adler.
2671
2672         REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
2673         https://bugs.webkit.org/show_bug.cgi?id=46134
2674
2675         AIM clients linked against versions of WebKit prior to the introduction
2676         of the HTML5 parser contain markup incompatible with the new parser.
2677         Enable parser quirks in this case to remain compatible with these
2678         clients.
2679
2680         * WebView/WebView.mm:
2681         (shouldUsePreHTML5ParserQuirks): Returns true if the embedding
2682         application is AIM and was linked against a version of WebKit prior to
2683         the introduction of the HTML5 parser, or if the
2684         WebKitPreHTML5ParserQuirks WebPreference is enabled.
2685         (-[WebView _preferencesChangedNotification:]): Call
2686         WebCore::Settings::setUsePreHTML5ParserQuirks().
2687
2688 2010-09-21  Steve Block  <steveblock@google.com>
2689
2690         Reviewed by Jeremy Orlow.
2691
2692         DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
2693         https://bugs.webkit.org/show_bug.cgi?id=45891
2694
2695         Implements WebDeviceOrientationClient::deviceOrientationControllerDestroyed to delete the client.
2696
2697         * WebCoreSupport/WebDeviceOrientationClient.h:
2698         * WebCoreSupport/WebDeviceOrientationClient.mm:
2699         (WebDeviceOrientationClient::deviceOrientationControllerDestroyed):
2700
2701 2010-09-20  Philippe Normand  <pnormand@igalia.com>
2702
2703         Reviewed by Eric Carlson.
2704
2705         [GTK] enhanced context menu for media elements
2706         https://bugs.webkit.org/show_bug.cgi?id=45021
2707
2708         New localized strings for the media element context-menu.
2709
2710         * WebCoreSupport/WebPlatformStrategies.h:
2711         * WebCoreSupport/WebPlatformStrategies.mm:
2712         (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
2713         (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
2714         (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
2715         (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
2716         (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
2717         (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
2718         (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
2719         (WebPlatformStrategies::contextMenuItemTagMediaPlay):
2720         (WebPlatformStrategies::contextMenuItemTagMediaPause):
2721         (WebPlatformStrategies::contextMenuItemTagMediaMute):
2722
2723 2010-09-20  Andy Estes  <aestes@apple.com>
2724
2725         Reviewed by Adam Barth.
2726
2727         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
2728         https://bugs.webkit.org/show_bug.cgi?id=40961
2729
2730         Implement WebKitUsePreHTML5ParserQuirks preference.
2731
2732         * WebView/WebPreferenceKeysPrivate.h:
2733         * WebView/WebPreferences.mm:
2734         (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to
2735         false.
2736         (-[WebPreferences usePreHTML5ParserQuirks]):
2737         (-[WebPreferences setUsePreHTML5ParserQuirks:]):
2738         * WebView/WebPreferencesPrivate.h:
2739         * WebView/WebView.mm:
2740         (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings
2741         with the value of WebKitUsePreHTML5ParserQuirks when a preference
2742         changes.
2743
2744 2010-09-20  Enrica Casucci  <enrica@apple.com>
2745
2746         Reviewed by Sam Weinig.
2747
2748         Pasteboard doesn't work in WebKit2.
2749         https://bugs.webkit.org/show_bug.cgi?id=42317
2750         <rdar://problem/7660537>
2751
2752         Some changes to fix style inconsistencies.
2753         Added OBJC 2.0 style enumeration.
2754
2755         * WebCoreSupport/WebEditorClient.h:
2756         * WebCoreSupport/WebEditorClient.mm:
2757         (WebEditorClient::userVisibleString):
2758         (createExcludedElementsForAttributedStringConversion):
2759         (WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
2760         a Vector of RefPtr.
2761         (WebEditorClient::setInsertionPasteboard):
2762         (WebEditorClient::pasteboardTypesForSelection):
2763
2764 2010-09-17  David Hyatt  <hyatt@apple.com>
2765
2766         Reviewed by Simon Fraser.
2767
2768         https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.
2769
2770         Make printing store the page height in the RenderView and push that into the layout state to
2771         use the new pagination model.  The old pagination model is retained because it is still used
2772         for embedded WebViews.
2773
2774         * WebView/WebHTMLView.mm:
2775         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2776
2777 2010-09-17  Darin Adler  <darin@apple.com>
2778
2779         Reviewed by Sam Weinig.
2780
2781         REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
2782         https://bugs.webkit.org/show_bug.cgi?id=42863
2783
2784         * WebView/WebView.mm:
2785         (-[WebView _setZoomMultiplier:isTextOnly:]):
2786         Call functions on Frame instead of FrameView.
2787
2788 2010-09-17  Matthew Delaney  <mdelaney@apple.com>
2789
2790         Reviewed by Simon Fraser.
2791
2792         Reduce minimum DOMTimer interval
2793         https://bugs.webkit.org/show_bug.cgi?id=45362
2794
2795         * WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.
2796
2797 2010-09-17  Chris Marrin  <cmarrin@apple.com>
2798
2799         Reviewed by Simon Fraser.
2800
2801         Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
2802         https://bugs.webkit.org/show_bug.cgi?id=45911
2803
2804         * WebView/WebPreferenceKeysPrivate.h:
2805         * WebView/WebPreferences.mm:
2806         (+[WebPreferences initialize]):
2807         (-[WebPreferences accelerated2dCanvasEnabled]):
2808         (-[WebPreferences setAccelerated2dCanvasEnabled:]):
2809         * WebView/WebPreferencesPrivate.h:
2810         * WebView/WebView.mm:
2811         (-[WebView _preferencesChangedNotification:]):
2812
2813 2010-09-17  Jia Pu  <jpu@apple.com>
2814
2815         Reviewed by Dan Bernstein.
2816
2817         WebKit should use system wide spell checking preference when application specific one isn't set.
2818         https://bugs.webkit.org/show_bug.cgi?id=45789
2819         <rdar://problem/8416041>
2820
2821         * WebView/WebView.mm:
2822         (+[WebView initialize]): Use system wide autocorrection and text substitution preferences
2823           when the application level preferences are not set.
2824
2825 2010-09-16  John Sullivan  <sullivan@apple.com>
2826
2827         Reviewed by Darin Adler.
2828
2829         <rdar://problem/8395558>
2830         https://bugs.webkit.org/show_bug.cgi?id=45938
2831         _web_makePluginViewsPerformSelector:: mutates subviews array while iterating it
2832
2833         * WebView/WebHTMLView.mm:
2834         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
2835         Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
2836         was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
2837         this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
2838         before enumerating it, to ensure that the selector can't mutate the array being enumerated.
2839         (-[WebHTMLView viewWillMoveToHostWindow:]):
2840         Updated for _web_makePluginSubviewsPerformSelector:: signature change.
2841         (-[WebHTMLView viewDidMoveToHostWindow]):
2842         Ditto.
2843
2844 2010-09-16  Darin Adler  <darin@apple.com>
2845
2846         Reviewed by Andreas Kling.
2847
2848         Reduce use of HTMLInputElement::inputType so we can remove it later
2849         https://bugs.webkit.org/show_bug.cgi?id=45903
2850
2851         * WebView/WebHTMLRepresentation.mm:
2852         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField.
2853         (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.
2854
2855 2010-09-16  Patrick Gansterer  <paroga@paroga.com>
2856
2857         Reviewed by Darin Adler.
2858
2859         Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
2860         https://bugs.webkit.org/show_bug.cgi?id=41510
2861
2862         This prevents usage of nil value, which would cause an uncaught exception.
2863
2864         * WebView/WebPreferences.mm:
2865         (-[WebPreferences setUserStyleSheetLocation:]):
2866
2867 2010-09-16  Dan Bernstein  <mitz@apple.com>
2868
2869         Reverted the previous change because r67628 has been reverted.
2870
2871         * WebCoreSupport/WebPlatformStrategies.h:
2872         * WebCoreSupport/WebPlatformStrategies.mm:
2873
2874 2010-09-16  Dan Bernstein  <mitz@apple.com>
2875
2876         Build fix after r67628. Added context menu item localizable strings for the items
2877         added in r67628, following equivalent menu items in Mac OS X when possible. However,
2878         this set of menu items does not make much sense for Mac OS X, and this should be
2879         addressed separately.
2880
2881         * WebCoreSupport/WebPlatformStrategies.h:
2882         * WebCoreSupport/WebPlatformStrategies.mm:
2883         (WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
2884         (WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
2885         (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
2886         (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
2887         (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
2888         (WebPlatformStrategies::contextMenuItemTagMediaPlay):
2889         (WebPlatformStrategies::contextMenuItemTagMediaPause):
2890         (WebPlatformStrategies::contextMenuItemTagMediaMute):
2891         (WebPlatformStrategies::contextMenuItemTagMediaUnMute):
2892
2893 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
2894
2895         Reviewed by Jian Li.
2896
2897         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
2898         https://bugs.webkit.org/show_bug.cgi?id=45798
2899
2900         * Configurations/FeatureDefines.xcconfig:
2901
2902 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
2903
2904         Reviewed by Adam Roben.
2905
2906         https://bugs.webkit.org/show_bug.cgi?id=44715
2907         maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
2908
2909         Move geometry flipping to platform-specific code.
2910
2911         * WebView/WebHTMLView.mm:
2912         (-[WebHTMLView attachRootLayer:]):
2913
2914 2010-09-14  Jia Pu  <jpu@apple.com>
2915
2916         Reviewed by Dan Bernstein.
2917
2918         Only intercept ESC key press when autocorrection UI is visible.
2919         https://bugs.webkit.org/show_bug.cgi?id=45071
2920
2921         * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
2922           which provides an inteface to query whether autocorrection panel is shown.
2923
2924         * WebCoreSupport/WebEditorClient.mm:
2925         (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
2926           for invalid correction panel tag. Replaced -1 with this constant.
2927         (WebEditorClient::dismissCorrectionPanel): Ditto
2928         (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
2929
2930 2010-09-14  Mark Rowe  <mrowe@apple.com>
2931
2932         Reviewed by John Sullivan.
2933
2934         Part of <rdar://problem/8420003>.  Make it possible to override the version number used in linked-in-or-after checks.
2935
2936         * Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
2937         * Misc/WebKitVersionChecks.m:
2938         (WebKitLinkedOnOrAfter):
2939         (setWebKitLinkTimeVersion): Set the overridden version.
2940         (WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.
2941         * WebView/WebPreferences.mm:
2942         (+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.
2943         * WebView/WebPreferencesPrivate.h:
2944
2945 2010-09-14  Eric Seidel  <eric@webkit.org>
2946
2947         Unreviewed, reverting changes r67451 and r67451.
2948         Broke lots of builders.
2949
2950         Only intercept ESC key press when autocorrection UI is visible.
2951         https://bugs.webkit.org/show_bug.cgi?id=45071
2952
2953         * WebCoreSupport/WebEditorClient.h:
2954         * WebCoreSupport/WebEditorClient.mm:
2955         (WebEditorClient::WebEditorClient):
2956         (WebEditorClient::dismissCorrectionPanel):
2957
2958 2010-09-14  Jia Pu  <jpu@apple.com>
2959
2960         Reviewed by Dan Bernstein.
2961
2962         Only intercept ESC key press when autocorrection UI is visible.
2963         https://bugs.webkit.org/show_bug.cgi?id=45071
2964
2965         * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
2966           which provides an inteface to query whether autocorrection panel is shown.
2967
2968         * WebCoreSupport/WebEditorClient.mm:
2969         (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
2970           for invalid correction panel tag. Replaced -1 with this constant.
2971         (WebEditorClient::dismissCorrectionPanel): Ditto
2972         (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
2973
2974 2010-09-13  Darin Adler  <darin@apple.com>
2975
2976         Reviewed by Adam Barth.
2977
2978         Preparation for eliminating deprecatedParseURL
2979         https://bugs.webkit.org/show_bug.cgi?id=45695
2980
2981         * DOM/WebDOMOperations.mm:
2982         (-[DOMDocument webFrame]): Get rid of unneeded local variable.
2983         (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.
2984
2985 2010-09-13  Enrica Casucci  <enrica@apple.com>
2986
2987         Reviewed by Sam Weinig.
2988
2989         Paste should be implemented in WebCore like Copy and Cut for Mac also.
2990         https://bugs.webkit.org/show_bug.cgi?id=45494
2991         <rdar://problem/7660537>
2992
2993         On the Mac platform, the implementation of the paste operation is all done
2994         at the WebKit level. In order to support it on WebKit2 it is necessary to
2995         refactor the code and move this functionality at the level of WebCore like
2996         we already have on Windows.
2997         The original code relies on some in AppKit functions that call back into
2998         WebKit causing problems in WebKit2. All this functionality has been moved
2999         at the level of the editor client where it can be dealt with appropriately.
3000
3001         * WebCoreSupport/WebEditorClient.h:
3002         * WebCoreSupport/WebEditorClient.mm:
3003         (excludedElementsForAttributedStringConversion):
3004         (WebEditorClient::documentFragmentFromAttributedString): Added.
3005         (WebEditorClient::setInsertionPasteboard):
3006         * WebCoreSupport/WebFrameLoaderClient.h:
3007         * WebCoreSupport/WebFrameLoaderClient.mm:
3008         (WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
3009         of the editor client.
3010         * WebView/WebHTMLView.mm: Removed paste method.
3011
3012 2010-09-13  John Sullivan  <sullivan@apple.com>
3013
3014         Reviewed by Adam Roben.
3015
3016         https://bugs.webkit.org/show_bug.cgi?id=45677
3017         [WebView canMarkAllTextMatches] can crash if called after [WebView close]
3018
3019         <rdar://problem/8404890>
3020
3021         * WebView/WebView.mm:
3022         (-[WebView canMarkAllTextMatches]):
3023         Return NO immediately if the webview has already been closed. This was an overlooked
3024         case from the fix for 45175.
3025
3026 2010-09-10  MORITA Hajime  <morrita@google.com>
3027
3028         Reviewed by Tony Chang.
3029
3030         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
3031         https://bugs.webkit.org/show_bug.cgi?id=45441
3032
3033         Moved the actual logic of hasSpellingMarker into WebCore to share
3034         it with other ports.
3035
3036         * WebView/WebFrame.mm:
3037         (-[WebFrame hasSpellingMarker:length:]):
3038
3039 2010-09-11  Adam Barth  <abarth@webkit.org>
3040
3041         Reviewed by Sam Weinig.
3042
3043         Make SecurityOrigin::canDisplay an instance function
3044         https://bugs.webkit.org/show_bug.cgi?id=45219
3045
3046         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3047         (WebKit::NetscapePluginInstanceProxy::loadRequest):
3048         * Plugins/WebNetscapePluginStream.mm:
3049         (WebNetscapePluginStream::WebNetscapePluginStream):
3050         * Plugins/WebNetscapePluginView.mm:
3051         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3052         * Plugins/WebPluginContainerCheck.mm:
3053         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3054         * WebView/WebFrame.mm:
3055         (-[WebFrame _allowsFollowingLink:]):
3056
3057 2010-09-10  Sam Weinig  <sam@webkit.org>
3058
3059         Reviewed by Darin Adler.
3060
3061         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
3062         Precursor to <rdar://problem/7660657>
3063         https://bugs.webkit.org/show_bug.cgi?id=45522
3064
3065         * WebView/WebView.mm:
3066         (-[WebView _preferencesChangedNotification:]):
3067         (-[WebView _setZoomMultiplier:isTextOnly:]):
3068         (-[WebView _realZoomMultiplierIsTextOnly]):
3069         * WebView/WebViewData.h:
3070         * WebView/WebViewData.mm:
3071         (-[WebViewPrivate init]):
3072         Move tracking of text only zoom here from WebCore.
3073
3074 2010-09-10  Stephanie Lewis  <slewis@apple.com>
3075
3076         Reviewed by Alexey Proskuryakov.
3077
3078         Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and
3079         other implementation details of JavaScriptCore.  Necessary to fix PPC build.
3080
3081         https://bugs.webkit.org/show_bug.cgi?id=45528
3082
3083         * Misc/WebCoreStatistics.mm:
3084         (+[WebCoreStatistics memoryStatistics]):
3085
3086 2010-09-10  Darin Adler  <darin@apple.com>
3087
3088         Reviewed by Sam Weinig.
3089
3090         Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
3091         https://bugs.webkit.org/show_bug.cgi?id=45582
3092
3093         * MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy.
3094
3095         * WebCoreSupport/WebChromeClient.mm:
3096         (WebChromeClient::dashboardRegionsChanged): Changed this to call
3097         -[WebView _dashboardRegions] so we don't have two copies of that code.
3098
3099         * WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h.
3100         * WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m.
3101
3102         * WebView/WebView.mm:
3103         (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here.
3104
3105 2010-09-10  Adam Barth  <abarth@webkit.org>
3106
3107         Reviewed by Darin Fisher.
3108
3109         Move code from WebKit-layer to DocumentLoader
3110         https://bugs.webkit.org/show_bug.cgi?id=45569
3111
3112         This code is the most confused, but now should be a bit cleaner.
3113         There's still a magical fake-setting for creating renderers that needs
3114         to be cleaned up, but we can do that in a separate patch.
3115
3116         * WebView/WebFrame.mm:
3117         (-[WebFrame _commitData:]):
3118         * WebView/WebFrameInternal.h:
3119         * WebView/WebHTMLRepresentation.mm:
3120         (-[WebHTMLRepresentation receivedData:withDataSource:]):
3121         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
3122
3123 2010-09-09  Darin Adler  <darin@apple.com>
3124
3125         Reviewed by Adam Barth.
3126
3127         Move functions from Frame to SelectionController as planned
3128         https://bugs.webkit.org/show_bug.cgi?id=45508
3129
3130         * WebView/WebFrame.mm:
3131         (-[WebFrame _selectionGranularity]):
3132         (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
3133         (-[WebFrame _typingStyle]):
3134         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3135         * WebView/WebHTMLRepresentation.mm:
3136         (-[WebHTMLRepresentation currentForm]):
3137         * WebView/WebHTMLView.mm:
3138         (-[WebHTMLView jumpToSelection:]):
3139         (-[WebHTMLView centerSelectionInVisibleArea:]):
3140         (-[WebHTMLView _canSmartCopyOrDelete]):
3141         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3142         (-[WebHTMLView selectionRect]):
3143         (-[WebHTMLView selectionTextRects]):
3144         (-[WebHTMLView selectionImageRect]):
3145         * WebView/WebView.mm:
3146         (-[WebView setEditable:]):
3147         Call functions on selection().
3148
3149 2010-09-10  Adam Barth  <abarth@webkit.org>
3150
3151         Reviewed by Eric Seidel.
3152
3153         Main resource bytes shouldn't bounce through FrameLoader
3154         https://bugs.webkit.org/show_bug.cgi?id=45496
3155
3156         Now return the bytes to the DocumentLoader.
3157
3158         Previously, we were checking the document for null.  However, Frame can
3159         never have a null document, so this check is no longer needed.
3160
3161         * WebView/WebFrame.mm:
3162         (-[WebFrame _addData:]):
3163
3164 2010-09-09  John Therrell  <jtherrell@apple.com>
3165
3166         Reviewed by Alexey Proskuryakov.
3167
3168         Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes
3169         https://bugs.webkit.org/show_bug.cgi?id=45134
3170
3171         Added ability to enable new JavaScriptCore statistics sampling and reporting for RegisterFile
3172         and ExecutableAllocator classes. Added reporting of JavaScriptCore's stack committed memory
3173         and JIT code committed memory statistics to WebCoreStatistics memoryStatistics.
3174
3175         * Misc/WebCoreStatistics.mm:
3176         (+[WebCoreStatistics memoryStatistics]):
3177         Added statistics reporting for JSC RegisterFile and ExecutableAllocator.
3178
3179 2010-09-09  Jer Noble  <jer.noble@apple.com>
3180
3181         Reviewed by Mark Rowe.
3182
3183         Use of ENABLE macro in WebUIDelegatePrivate.h breaks use from outside WebKit
3184         <rdar://problem/8412657>
3185
3186         * WebView/WebUIDelegatePrivate.h: Use ENABLE_FULLSCREEN_API instead of ENABLE(FULLSCREEN_API)
3187
3188 2010-09-08  Darin Adler  <darin@apple.com>
3189
3190         Reviewed by Adam Barth.
3191
3192         Move functions from Frame to Editor as planned
3193         https://bugs.webkit.org/show_bug.cgi?id=45218
3194
3195         * WebView/WebFrame.mm:
3196         (-[WebFrame _selectedString]):
3197         (-[WebFrame _firstRectForDOMRange:]):
3198         (-[WebFrame _markDOMRange]):
3199         (-[WebFrame _setTypingStyle:withUndoAction:]):
3200         * WebView/WebHTMLRepresentation.mm:
3201         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
3202         * WebView/WebHTMLView.mm:
3203         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3204         (-[WebHTMLView toggleBaseWritingDirection:]):
3205         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3206         (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
3207         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
3208         (-[WebHTMLView markedTextMatchesAreHighlighted]):
3209         * WebView/WebView.mm:
3210         (-[WebView setEditable:]):
3211         Changed call sites to use editor().
3212
3213 2010-09-08  MORITA Hajime  <morrita@google.com>
3214
3215         Reviewed by Ojan Vafai.
3216
3217         spellcheck does not check pasted text
3218         https://bugs.webkit.org/show_bug.cgi?id=40092
3219
3220         Implemented async spell-check APIs on WebEditorClient.
3221         The implementations are using [NSSpellChecker requestCheckingOfString]
3222         which is available only on Mac OS 10.6 or later.
3223
3224         Note that [NSSpellChecker requestCheckingOfString] could invoke
3225         the callback block on on of their worker thread, so we need to
3226         return the result to the main thread where WebCore is running.
3227         For that purpose, we made WebEditorSpellCheckResponder class.
3228
3229         Test: editing/spelling/spellcheck-pasted-text-001.html
3230
3231         * WebCoreSupport/WebEditorClient.h:
3232         * WebCoreSupport/WebEditorClient.mm:
3233         (WebEditorClient::isAsynchronousSpellCheckingEnabled): Added.
3234         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]): Added.
3235         (-[WebEditorSpellCheckResponder perform]): Added.
3236         (WebEditorClient::requestCheckingOfString): Added.
3237         * WebView/WebFramePrivate.h:
3238
3239 2010-09-08  MORITA Hajime  <morrita@google.com>
3240
3241         Reviewed by Tony Chang.
3242
3243         spelling underline gets lost on backspace
3244         https://bugs.webkit.org/show_bug.cgi?id=41423
3245
3246         Switched to use a anchorNode of the selection instead of a focused
3247         node for finer control of node selection in spellingNode():
3248         With the focused node, we cannot select other nodes but the first
3249         child of that node. In some case, we need to inspect these.
3250
3251         The API is only for LayoutTests, and the change is compatible for
3252         existing test cases.
3253
3254         * WebView/WebFrame.mm:
3255         (spellingNode):
3256
3257 2010-09-08  Adam Barth  <abarth@webkit.org>
3258
3259         Rubber-stamped by Eric Seidel.
3260
3261         Rename DocLoader to CachedResourceLoader because that's what it does.
3262
3263         * WebView/WebFrame.mm:
3264
3265 2010-09-07  Anders Carlsson  <andersca@apple.com>
3266
3267         Reviewed by Oliver Hunt.
3268
3269         Fix clang++ build.
3270
3271         * Misc/WebLocalizableStrings.h:
3272         Fix a struct/tag mismatch.
3273
3274         * WebView/WebDeviceOrientationProviderMock.mm:
3275         (-[WebDeviceOrientationProviderMock init]):
3276         Remove stray semicolon.
3277
3278         * WebView/WebViewData.h:
3279         Remove unused class forward declaration.
3280
3281 2010-09-07  Anders Carlsson  <andersca@apple.com>
3282
3283         Reviewed by Darin Adler.
3284
3285         <rdar://problem/8381749> -Wcast-align warning emitted when building with clang
3286
3287         Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
3288
3289         * Configurations/Base.xcconfig:
3290
3291 2010-09-06  Adam Barth  <abarth@webkit.org>
3292
3293         Reviewed by Darin Adler.
3294
3295         Rename SecurityOrigin::canLoad to canDisplay
3296         https://bugs.webkit.org/show_bug.cgi?id=45214
3297
3298         Propagate name change.
3299
3300         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3301         (WebKit::NetscapePluginInstanceProxy::loadRequest):
3302         * Plugins/WebNetscapePluginStream.mm:
3303         (WebNetscapePluginStream::WebNetscapePluginStream):
3304         * Plugins/WebNetscapePluginView.mm:
3305         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3306         * Plugins/WebPluginContainerCheck.mm:
3307         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3308         * WebView/WebFrame.mm:
3309         (-[WebFrame _allowsFollowingLink:]):
3310
3311 2010-09-03  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3312
3313         Reviewed by Darin Adler.
3314
3315         Add NetworkingContext to avoid layer violations
3316         https://bugs.webkit.org/show_bug.cgi?id=42292
3317
3318         Add Mac's specific implementation of FrameNetworkingContext.
3319
3320         * WebCoreSupport/WebFrameLoaderClient.h:
3321         * WebCoreSupport/WebFrameLoaderClient.mm:
3322         * WebCoreSupport/WebFrameNetworkingContext.mm:
3323         (WebFrameNetworkingContext::needsSiteSpecificQuirks):
3324         (WebFrameNetworkingContext::localFileContentSniffingEnabled):
3325         (WebFrameNetworkingContext::scheduledRunLoopPairs):
3326         (WebFrameNetworkingContext::blockedError):
3327
3328 2010-09-03  John Sullivan  <sullivan@apple.com>
3329
3330         Reviewed by Dan Bernstein.
3331
3332         https://bugs.webkit.org/show_bug.cgi?id=45175
3333         [WebView unmarkAllTextMatches] will crash if the webview is already closed
3334
3335         Made this and related methods robust against being called when the WebView is closed.
3336
3337         * WebView/WebView.mm:
3338         (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
3339         Bail out if the WebView is closed.
3340         (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
3341         Ditto.
3342         (-[WebView unmarkAllTextMatches]):
3343         Ditto.
3344         (-[WebView rectsForTextMatches]):
3345         Ditto.
3346
3347 2010-09-03  Hironori Bono  <hbono@chromium.org>
3348
3349         Reviewed by Kent Tamura.
3350
3351         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
3352         and implements it for Mac.
3353         https://bugs.webkit.org/show_bug.cgi?id=41832
3354
3355         * WebView/WebFrame.mm: Implemented [WebFrame hasSpellingMarker:length:].
3356         (spellingNode):
3357         (-[WebFrame hasSpellingMarker:length:]):
3358         * WebView/WebFramePrivate.h: Added [WebFrame hasSpellingMarker:length:] so TextInputController can use it.
3359
3360 2010-09-02  Yury Semikhatsky  <yurys@chromium.org>
3361
3362         Reviewed by Pavel Feldman.
3363
3364         REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
3365         https://bugs.webkit.org/show_bug.cgi?id=44230
3366
3367         * WebCoreSupport/WebInspectorClient.h:
3368         * WebCoreSupport/WebInspectorClient.mm:
3369         (WebInspectorFrontendClient::closeWindow):
3370         (WebInspectorFrontendClient::disconnectFromBackend):
3371         (-[WebInspectorWindowController windowShouldClose:]):
3372         (-[WebInspectorWindowController destroyInspectorView:]):
3373
3374 2010-09-02  Steve Block  <steveblock@google.com>
3375
3376         Reviewed by Adam Barth.
3377
3378         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
3379         https://bugs.webkit.org/show_bug.cgi?id=43181
3380
3381         This patch hooks up the mock device orientation client on Mac for use
3382         in DumpRenderTree.
3383
3384         The patch adds a new WebDeviceOrientationClient for Mac. This client acts
3385         as a proxy to either a real or mock device orientation provider, both of
3386         which implement a new WebDeviceOrientationProvider interface.
3387
3388         The provider is created by the embedder and passed to the WebView, from
3389         where WebDeviceOrientationClient can access it.
3390
3391         The mock provider, WebDeviceOrientationProviderMock, is a wrapper around
3392         the existing WebCore mock.
3393
3394         * WebCoreSupport/WebDeviceOrientationClient.h: Added.
3395         * WebCoreSupport/WebDeviceOrientationClient.mm: Added.
3396         (WebDeviceOrientationClient::WebDeviceOrientationClient):
3397         (WebDeviceOrientationClient::setController):
3398         (WebDeviceOrientationClient::startUpdating):
3399         (WebDeviceOrientationClient::stopUpdating):
3400         (WebDeviceOrientationClient::lastOrientation):
3401         * WebKit.exp:
3402         * WebView/WebDeviceOrientation.h: Added.
3403         * WebView/WebDeviceOrientation.mm: Added.
3404         (-[WebDeviceOrientation initWithCoreDeviceOrientation:WebCore::]):
3405         (core):
3406         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
3407         (-[WebDeviceOrientation dealloc]):
3408         * WebView/WebDeviceOrientationInternal.h: Added.
3409         * WebView/WebDeviceOrientationProvider.h: Added.
3410         * WebView/WebDeviceOrientationProviderMock.h: Added.
3411         * WebView/WebDeviceOrientationProviderMock.mm: Added.
3412         (-[WebDeviceOrientationProviderMockInternal setOrientation:]):
3413         (-[WebDeviceOrientationProviderMockInternal setController:]):
3414         (-[WebDeviceOrientationProviderMockInternal startUpdating]):
3415         (-[WebDeviceOrientationProviderMockInternal stopUpdating]):
3416         (-[WebDeviceOrientationProviderMockInternal lastOrientation]):
3417         (-[WebDeviceOrientationProviderMock init]):
3418         (-[WebDeviceOrientationProviderMock dealloc]):
3419         (-[WebDeviceOrientationProviderMock setOrientation:]):
3420         (-[WebDeviceOrientationProviderMock setController:]):
3421         (-[WebDeviceOrientationProviderMock startUpdating]):
3422         (-[WebDeviceOrientationProviderMock stopUpdating]):
3423         (-[WebDeviceOrientationProviderMock lastOrientation]):
3424         * WebView/WebDeviceOrientationProviderMockInternal.h: Added.
3425         * WebView/WebView.mm:
3426         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3427         (-[WebView _setDeviceOrientationProvider:]):
3428         (-[WebView _deviceOrientationProvider]):
3429         * WebView/WebViewData.h:
3430         * WebView/WebViewPrivate.h:
3431
3432 2010-09-01  Jia Pu  <jpu@apple.com>
3433
3434         Reviewed by Dan Bernstein.
3435
3436         Add support for autocorrection UI on Mac OS X.
3437         https://bugs.webkit.org/show_bug.cgi?id=44958
3438         <rdar://problem/7326847>
3439
3440         See detailed high level description in WebCore/ChangeLog.
3441
3442         * WebCoreSupport/WebEditorClient.h: Added new member methods declared in
3443           EditorClient. Added m_correctionPanelTag to store the ID of current autocorrection UI object.
3444
3445         * WebCoreSupport/WebEditorClient.mm:
3446         (WebEditorClient::WebEditorClient): Initialize m_correctionPanelTag.
3447         (WebEditorClient::~WebEditorClient): Make sure the autocorrection UI is
3448           dismissed before destroying the object.
3449         (WebEditorClient::respondToChangedSelection): Dismiss autocorrection UI whenever the selection changes.
3450         (WebEditorClient::showCorrectionPanel): Show autocorrection UI.
3451         (WebEditorClient::dismissCorrectionPanel): Dismiss autocorrection UI.
3452
3453 2010-09-01  Mark Rowe  <mrowe@apple.com>
3454
3455         Reviewed by Adam Roben.
3456
3457         <rdar://problem/8374711> WebKit needs to compile without access to QuickDraw private headers.
3458
3459         * Carbon/HIViewAdapter.m:
3460         * Carbon/HIWebView.mm:
3461         * Misc/QuickDrawCompatibility.h: Added.
3462         * Plugins/WebNetscapePluginView.mm:
3463
3464 2010-08-31  Dave Hyatt  <hyatt@apple.com>
3465
3466         Reviewed by Sam Weinig.
3467
3468         https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
3469         the former can occur in more places without having to do the latter.
3470
3471         Eliminate Mac-specific code for style re-application and recursive layout/style updating in
3472         favor of the cross-platform code that all the other ports use.
3473
3474         * Carbon/HIWebView.mm:
3475         (Draw):
3476         * WebCoreSupport/WebFrameLoaderClient.mm:
3477         (WebFrameLoaderClient::forceLayout):
3478         * WebView/WebHTMLView.mm:
3479         (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]):
3480         (-[WebHTMLView viewWillDraw]):
3481         (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3482         (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3483         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3484         (-[WebHTMLView reapplyStyles]):
3485         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
3486         (-[WebHTMLView setNeedsToApplyStyles:]):
3487         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
3488         (-[WebHTMLView _layoutIfNeeded]):
3489         (-[WebHTMLView _web_updateLayoutAndStyleIfNeededRecursive]):
3490         * WebView/WebHTMLViewInternal.h:
3491         * WebView/WebView.mm:
3492         (-[WebView _viewWillDrawInternal]):
3493
3494 2010-08-31  Sam Weinig  <sam@webkit.org>
3495
3496         Reviewed by Darin Adler.
3497
3498         Add ability to count text matches without marking
3499         https://bugs.webkit.org/show_bug.cgi?id=43996
3500
3501         Safari needs to be able to count text matches without triggering lots of repainting.
3502         Rename markAllMatchesForText: to countMatchesForText: and add a markMatches:
3503         parameter.  For backwards compatibility markAllMatchesForText: calls
3504         countMatchesForText: and passes YES for markMatches:.
3505
3506         * WebView/WebDocumentInternal.h:
3507         * WebView/WebHTMLView.mm:
3508         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
3509         (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
3510         * WebView/WebPDFView.mm:
3511         (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]):
3512         (-[WebPDFView countMatchesForText:caseSensitive:limit:markMatches:]):
3513         * WebView/WebView.mm:
3514         (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
3515         (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
3516         * WebView/WebViewPrivate.h:
3517
3518 2010-08-31  Darin Adler  <darin@apple.com>
3519
3520         Reviewed by Anders Carlsson.
3521