[Mac] Disable QTKit by default on future OS X.
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-04-23  Jer Noble  <jer.noble@apple.com>
2
3         [Mac] Disable QTKit by default on future OS X.
4         https://bugs.webkit.org/show_bug.cgi?id=144082
5
6         Reviewed by Darin Adler.
7
8         Default WebKitQTKitEnabledPreferenceKey to NO.
9
10         * WebView/WebPreferences.mm:
11         (+[WebPreferences initialize]):
12
13 2015-04-23  Andreas Kling  <akling@apple.com>
14
15         There should only be one way to get the system memory size.
16         <https://webkit.org/b/144081>
17
18         Reviewed by Antti Koivisto.
19
20         * Misc/WebKitSystemBits.h:
21         * Misc/WebKitSystemBits.m:
22         (WebMemorySize): Deleted.
23         * WebView/WebView.mm:
24         (+[WebView _setCacheModel:]):
25         (roundUpToPowerOf2): Deleted.
26
27 2015-04-22  Darin Adler  <darin@apple.com>
28
29         Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2
30         https://bugs.webkit.org/show_bug.cgi?id=143943
31
32         Reviewed by Anders Carlsson.
33
34         * Plugins/Hosted/ProxyInstance.h: Removed unneeded include.
35         * Plugins/WebBaseNetscapePluginView.h: Ditto.
36
37         * Plugins/WebNetscapePluginEventHandler.h: Use unique_ptr instead of
38         PassOwnPtr for the create function. Also tweaked formatting and removed
39         unneeded forward declaration of CGRect.
40         * Plugins/WebNetscapePluginEventHandler.mm:
41         (WebNetscapePluginEventHandler::create): Changed to use unique_ptr and
42         make_unique.
43
44         * Plugins/WebNetscapePluginView.h: Use unique_ptr instead of OwnPtr for
45         the _eventHandler field.
46         * Plugins/WebNetscapePluginView.mm:
47         (-[WebNetscapePluginView destroyPlugin]): Changed code to work with unique_ptr.
48
49         * WebCoreSupport/WebUserMediaClient.mm: Removed unneeded include.
50
51         * WebView/WebDeviceOrientationProviderMock.mm: Changed to use make_unique.
52         * WebView/WebDeviceOrientationProviderMockInternal.h: Changed to use unique_ptr.
53
54         * WebView/WebFrame.mm:
55         (vectorForDictationPhrasesArray): Changed to return Vector<Vector<String>> and
56         not a PassOwnPtr. Also rewrote to be much simpler, although there is still a
57         pre-existing problem here where this could put empty vectors into the result,
58         and I'm pretty sure the client never expects any of the Vector<String> to be empty.
59         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
60         Rewrote logic to involve WebCore types a bit less; old code was round tripping
61         things through WebCore::URL for no obvious reason.
62
63         * WebView/WebFrameInternal.h: Changed vectorForDictationPhrasesArray to return
64         a Vector<Vector<String>> and not a PassOwnPtr.
65
66         * WebView/WebFullScreenController.h: Removed unneeded include.
67
68         * WebView/WebViewData.h: Changed m_alternativeTextUIController to be a
69         m_alternativeTextUIController.
70         * WebView/WebViewData.mm:
71         (-[WebViewPrivate init]): Use make_unique to initialize m_alternativeTextUIController.
72
73 2015-04-22  Brent Fulgham  <bfulgham@apple.com>
74
75         VisibleSelection should only accept Range by reference
76         https://bugs.webkit.org/show_bug.cgi?id=144047
77
78         Reviewed by Tim Horton.
79
80         Update all uses of VisibleSelection to pass a Range reference instead
81         of a Range pointer.
82
83         * WebCoreSupport/WebContextMenuClient.mm:
84         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
85         * WebView/WebFrame.mm:
86         (-[WebFrame _selectNSRange:]):
87
88 2015-04-22  Eric Carlson  <eric.carlson@apple.com>
89
90         [Mac] Device picker menu is positioned incorrectly in WK1
91         https://bugs.webkit.org/show_bug.cgi?id=144049
92         <rdar://problem/20493101>
93
94         Reviewed by Dean Jackson.
95
96         * WebView/WebView.mm:
97         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]): Mouse location is already in
98             window coordinates so don't call convertRect:toView:nil.
99
100 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
101
102         Extend action menus to support PDF
103         https://bugs.webkit.org/show_bug.cgi?id=143895
104         <rdar://problem/19003333>
105
106         Reviewed by Tim Horton.
107
108         Prevent a crash when someone attempts to invoke an action menu on a PDF hosted
109         in a WK1 view.
110
111         * WebView/WebActionMenuController.mm:
112         (-[WebActionMenuController performHitTestAtPoint:]): Handle WebPDFView as well as
113         the WebHTMLView case.
114         * WebView/WebDocument.h:
115         * WebView/WebHTMLView.h:
116         * WebView/WebHTMLView.mm:
117         (-[WebHTMLView _frame]):
118         * WebView/WebHTMLViewInternal.h:
119         * WebView/WebPDFView.h:
120         * WebView/WebPDFView.mm:
121         (-[WebPDFView _frame]): Added.
122
123 2015-04-22  Eric Carlson  <eric.carlson@apple.com>
124
125         Unreviewed post-review clean up after r183096.
126
127         * WebView/WebMediaPlaybackTargetPicker.h:
128
129 2015-04-21  Eric Carlson  <eric.carlson@apple.com>
130
131         [Mac] Use one playback target for all web processes
132         https://bugs.webkit.org/show_bug.cgi?id=144009
133
134         Reviewed by Tim Horton.
135
136         Update to use WebMediaSessionManager for playback target management.
137
138         * WebCoreSupport/WebChromeClient.h:
139         * WebCoreSupport/WebChromeClient.mm:
140         (WebChromeClient::addPlaybackTargetPickerClient):
141         (WebChromeClient::removePlaybackTargetPickerClient):
142         (WebChromeClient::showPlaybackTargetPicker):
143         (WebChromeClient::playbackTargetPickerClientStateDidChange):
144         (WebChromeClient::startingMonitoringPlaybackTargets): Deleted.
145         (WebChromeClient::stopMonitoringPlaybackTargets): Deleted.
146         * WebView/WebMediaPlaybackTargetPicker.h:
147         * WebView/WebMediaPlaybackTargetPicker.mm:
148         (WebMediaPlaybackTargetPicker::addPlaybackTargetPickerClient):
149         (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
150         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
151         (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
152         (WebMediaPlaybackTargetPicker::setPlaybackTarget):
153         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange):
154         (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget):
155         (WebMediaPlaybackTargetPicker::invalidate):
156         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): Deleted.
157         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): Deleted.
158         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Deleted.
159         (WebMediaPlaybackTargetPicker::targetPicker): Deleted.
160         * WebView/WebView.mm:
161         (-[WebView _addPlaybackTargetPickerClient:]):
162         (-[WebView _removePlaybackTargetPickerClient:]):
163         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
164         (-[WebView _playbackTargetPickerClientStateDidChange:state:]):
165         (-[WebView _showPlaybackTargetPicker:hasVideo:]): Deleted.
166         (-[WebView _startingMonitoringPlaybackTargets]): Deleted.
167         (-[WebView _stopMonitoringPlaybackTargets]): Deleted.
168         * WebView/WebViewInternal.h:
169
170 2015-04-20  Alexey Proskuryakov  <ap@apple.com>
171
172         Disable mixed content blocking for existing WebKit1 clients
173         https://bugs.webkit.org/show_bug.cgi?id=143955
174         rdar://problem/20177186
175
176         Reviewed by Oliver Hunt.
177
178         * Misc/WebKitVersionChecks.h:
179         * WebView/WebView.mm:
180         (shouldAllowInsecureContent):
181         (-[WebView _preferencesChanged:]):
182
183 2015-04-20  Tim Horton  <timothy_horton@apple.com>
184
185         Implement immediate action support for tel: and mailto: URLs
186         https://bugs.webkit.org/show_bug.cgi?id=143916
187         <rdar://problem/19721711>
188
189         Reviewed by Darin Adler.
190
191         * WebView/WebImmediateActionController.mm:
192         (-[WebImmediateActionController _defaultAnimationController]):
193         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
194         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
195         (-[WebImmediateActionController _menuItemForDataDetectedText]): Deleted.
196         * WebView/WebUIDelegatePrivate.h:
197         Add _animationControllerForDataDetectedLink and use it when
198         building immediate actions for tel: and mailto: links.
199
200 2015-04-17  Daniel Bates  <dabates@apple.com>
201
202         REGRESSION: SVG does not support link dragging
203         https://bugs.webkit.org/show_bug.cgi?id=141597
204
205         Reviewed by Darin Adler.
206
207         Write -[WebElementDictionary _isLiveLink] in terms of WebCore::isDraggableLink().
208
209         * Misc/WebElementDictionary.mm:
210         (-[WebElementDictionary _isLiveLink]):
211
212 2015-04-16  Sam Weinig  <sam@webkit.org>
213
214         Expose JavaScriptMarkupEnabled preference for WebKit1
215         <rdar://problem/19939450>
216         https://bugs.webkit.org/show_bug.cgi?id=143855
217
218         Reviewed by Dan Bernstein.
219
220         * WebView/WebPreferenceKeysPrivate.h:
221         Add new key, WebKitJavaScriptMarkupEnabledPreferenceKey
222
223         * WebView/WebPreferences.mm:
224         (+[WebPreferences initialize]):
225         Initialize WebKitJavaScriptMarkupEnabledPreferenceKey to YES.
226
227         (-[WebPreferences isJavaScriptMarkupEnabled]):
228         (-[WebPreferences setJavaScriptMarkupEnabled:]):
229         Implement getter/setter.
230
231         * WebView/WebPreferencesPrivate.h:
232         Add new property, javaScriptMarkupEnabled.
233
234         * WebView/WebView.mm:
235         (-[WebView _preferencesChanged:]):
236         Map the new preference to WebCore's scriptMarkupEnabled setting.
237
238 2015-04-15  Brent Fulgham  <bfulgham@apple.com>
239
240         [Mac] Disable "Save to Downloads" option for local files
241         https://bugs.webkit.org/show_bug.cgi?id=143794
242
243         Reviewed by Tim Horton.
244
245         Disable the Image and Media download options if the download
246         target is a local file. We can only download web resources;
247         anything else is actually a no-op.
248
249         * WebView/WebActionMenuController.mm:
250         (-[WebActionMenuController _defaultMenuItemsForImage]):
251         (-[WebActionMenuController _defaultMenuItemsForVideo]):
252
253 2015-04-15  Alex Christensen  <achristensen@webkit.org>
254
255         Progress towards CMake on Mac.
256         https://bugs.webkit.org/show_bug.cgi?id=143785
257
258         Reviewed by Csaba Osztrogonác.
259
260         * WebView/WebPDFDocumentExtras.mm:
261         * WebView/WebPDFView.mm:
262
263 2015-04-13  Jer Noble  <jer.noble@apple.com>
264
265         [Fullscreen] ChromeClient::exitVideoFullscreen() should take a pointer to a HTMLVideoElement.
266         https://bugs.webkit.org/show_bug.cgi?id=143674
267
268         Reviewed by Darin Adler.
269
270         * WebCoreSupport/WebChromeClient.h:
271         * WebCoreSupport/WebChromeClient.mm:
272         (WebChromeClient::enterVideoFullscreenForVideoElement): Takes a reference.
273         (WebChromeClient::exitVideoFullscreenForVideoElement): Renamed from exitVideoFullscreen().
274         (WebChromeClient::exitVideoFullscreen): Deleted.
275
276 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
277
278         Re-enable custom dilation for antialiased fonts
279         https://bugs.webkit.org/show_bug.cgi?id=143738
280
281         Reviewed by Tim Horton.
282         
283         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
284         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
285         a private WebKit pref. This pref defaults to YES, enabling the feature by default
286         in WK1 as we do for WK2.
287
288         * WebView/WebPreferenceKeysPrivate.h:
289         * WebView/WebPreferences.mm:
290         (+[WebPreferences initialize]):
291         (-[WebPreferences setAntialiasedFontDilationEnabled:]):
292         (-[WebPreferences antialiasedFontDilationEnabled]):
293         * WebView/WebPreferencesPrivate.h:
294         * WebView/WebView.mm:
295         (-[WebView _preferencesChanged:]):
296
297 2015-04-13  Brady Eidson  <beidson@apple.com>
298
299         Share sheets from Share menus appear outside the browser window.
300         <rdar://problem/20455592> and https://bugs.webkit.org/show_bug.cgi?id=143620
301
302         Reviewed by Darin Adler.
303
304         Refactor existing Sharing Service Picker code to also be used for the Share menu NSMenuItem.
305
306         * Misc/WebSharingServicePickerController.h:
307         (WebSharingServicePickerClient::webView):
308         * Misc/WebSharingServicePickerController.mm:
309         (WebSharingServicePickerClient::WebSharingServicePickerClient):
310         (WebSharingServicePickerClient::sharingServicePickerWillBeDestroyed):
311         (WebSharingServicePickerClient::pageForSharingServicePicker):
312         (WebSharingServicePickerClient::windowForSharingServicePicker):
313         (WebSharingServicePickerClient::screenRectForCurrentSharingServicePickerItem):
314         (WebSharingServicePickerClient::imageForCurrentSharingServicePickerItem):
315         (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]):
316         (-[WebSharingServicePickerController initWithSharingServicePicker:client:]):
317         (-[WebSharingServicePickerController sharingService:didShareItems:]):
318
319         * WebCoreSupport/WebContextMenuClient.h:
320         (WebContextMenuClient::webView): Deleted.
321         * WebCoreSupport/WebContextMenuClient.mm:
322         (WebContextMenuClient::WebContextMenuClient):
323         (WebContextMenuClient::pageForSharingServicePicker): Deleted.
324         (WebContextMenuClient::windowForSharingServicePicker): Deleted.
325
326         * WebCoreSupport/WebSelectionServiceController.h:
327         * WebCoreSupport/WebSelectionServiceController.mm:
328         (WebSelectionServiceController::WebSelectionServiceController):
329         (WebSelectionServiceController::handleSelectionServiceClick):
330         (WebSelectionServiceController::pageForSharingServicePicker): Deleted.
331         (WebSelectionServiceController::windowForSharingServicePicker): Deleted.
332         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem): Deleted.
333         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem): Deleted.
334
335         * WebView/WebHTMLView.mm:
336         (-[WebHTMLView menuForEvent:]):
337         * WebView/WebViewData.h:
338
339 2015-04-13  Beth Dakin  <bdakin@apple.com>
340
341         Add force property to MouseEvents
342         https://bugs.webkit.org/show_bug.cgi?id=143569
343         -and corresponding-
344         rdar://problem/20472954
345
346         Reviewed by Darin Adler.
347
348         PlatformMouseEvent and MouseEvent now take force parameters.
349         * WebView/WebFrame.mm:
350         (-[WebFrame _dragSourceEndedAt:operation:]):
351         * WebView/WebPDFView.mm:
352         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
353
354 2015-04-12  Darin Adler  <darin@apple.com>
355
356         [Cocoa] Localizable strings are inconsistent and need to be regenerated
357         https://bugs.webkit.org/show_bug.cgi?id=143661
358         rdar://problem/19634388
359
360         Reviewed by Dan Bernstein.
361
362         * Misc/WebLocalizableStrings.mm:
363         (LoadWebLocalizedStringsTimerCallback): Moved the comment, useful for programmers but
364         not for localization, into a C++ source code comment, and made the localizer comment
365         consistent with the place this localizable string is used for actual localization.
366         * WebCoreSupport/WebEditorClient.mm:
367         (undoNameForEditAction): Changed the localizer comments for Delete and Dictation
368         to match the ones in WebKit2; no need to specify that these are iOS only, and if we do
369         want to specify that, we should not be using the term PLATFORM(IOS) since there is no
370         reason for us to expect localizers to understand that terminology. Also added a comment
371         about the fact that we have two copies of all the localizable strings.
372
373 2015-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
374
375         [ES6] Enable Symbol in web pages
376         https://bugs.webkit.org/show_bug.cgi?id=143375
377
378         Reviewed by Ryosuke Niwa.
379
380         * WebView/WebPreferencesPrivate.h:
381
382 2015-04-08  Sam Weinig  <sam@webkit.org>
383
384         Allow LaunchServices to handle URLs on link navigations
385         <rdar://problem/19446826>
386         https://bugs.webkit.org/show_bug.cgi?id=143544
387
388         Reviewed by Anders Carlsson.
389
390         * Configurations/WebKitLegacy.xcconfig:
391         Link MobileCoreServices.
392
393         * WebCoreSupport/WebFrameLoaderClient.h:
394         * WebCoreSupport/WebFrameLoaderClient.mm:
395         (shouldTryAppLink):
396         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
397         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
398         (WebFrameLoaderClient::setUpPolicyListener):
399         Only let LaunchServices have a crack at the URL if the navigation is:
400             1) a main frame navigation
401             2) a result of a user gesture
402
403 2015-04-10  Alexey Proskuryakov  <ap@apple.com>
404
405         Build fix.
406
407         * Misc/WebNSURLExtras.mm: (-[NSString _webkit_unescapedQueryValue]): Ignore a deprecation.
408
409 2015-04-10  Eric Carlson  <eric.carlson@apple.com>
410
411         [Mac] Refactor MediaPlaybackTarget
412         https://bugs.webkit.org/show_bug.cgi?id=143571
413
414         Reviewed by Jer Noble.
415
416         * WebView/WebMediaPlaybackTargetPicker.h:
417         * WebView/WebMediaPlaybackTargetPicker.mm:
418         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Take a Ref<MediaPlaybackTarget>&&.
419
420 2015-04-09  Andy Estes  <aestes@apple.com>
421
422         [Cocoa] Add a HAVE(AVKIT) and use it
423         https://bugs.webkit.org/show_bug.cgi?id=143593
424
425         Reviewed by David Kilzer.
426
427         * WebView/WebPreferences.mm:
428         (+[WebPreferences initialize]): Only set WebKitAVKitEnabled to YES if HAVE(AVKIT).
429         (-[WebPreferences setAVKitEnabled:]): Only set value for WebKitAVKitEnabled if HAVE(AVKIT).
430         * WebView/WebView.mm:
431         (-[WebView _preferencesChanged:]): Only called Settings::setAVKitEnabled() if HAVE(AVKIT).
432
433 2015-04-09  Chris Dumez  <cdumez@apple.com>
434
435         [WK2][iOS] editorState() should not cause a synchronous layout
436         https://bugs.webkit.org/show_bug.cgi?id=142536
437         <rdar://problem/20041506>
438
439         Reviewed by Enrica Casucci.
440
441         Provide implementation for EditorClient::didChangeSelectionAndUpdateLayout().
442
443         * WebCoreSupport/WebEditorClient.h:
444
445 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
446
447         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
448         https://bugs.webkit.org/show_bug.cgi?id=143452
449         <rdar://problem/20437483>
450
451         Reviewed by Tim Horton.
452
453         We were improperly intercepting contextual menu clicks and passing them through
454         the mouseDown handler, rather than processing via NSView's menu handling code.
455
456         * WebView/WebHTMLView.mm:
457         (-[WebHTMLView otherMouseDown:]): Treat context menu events the same as the action
458         menu case, and pass it to AppKit for normal menu processing. 
459
460 2015-04-08  Brady Eidson  <beidson@apple.com>
461
462         Expose the "Share" menu for links, images, and media.
463         <rdar://problem/20435340> and https://bugs.webkit.org/show_bug.cgi?id=143502
464
465         Reviewed by Tim Horton.
466
467         * WebCoreSupport/WebContextMenuClient.h:
468         * WebCoreSupport/WebContextMenuClient.mm:
469         (WebContextMenuClient::shareMenuItem): 
470
471 2015-04-08  Anders Carlsson  <andersca@apple.com>
472
473         Move some ApplicationCache static member functions to ApplicationCacheStorage
474         https://bugs.webkit.org/show_bug.cgi?id=143524
475
476         Reviewed by Antti Koivisto.
477
478         * WebCoreSupport/WebApplicationCache.mm:
479         (+[WebApplicationCache diskUsageForOrigin:]):
480         (+[WebApplicationCache deleteAllApplicationCaches]):
481         (+[WebApplicationCache deleteCacheForOrigin:]):
482
483 2015-04-08  Chris Dumez  <cdumez@apple.com>
484
485         Rename ActiveDOMObject::canSuspend() to canSuspendForPageCache() for clarity
486         https://bugs.webkit.org/show_bug.cgi?id=143513
487
488         Reviewed by Andreas Kling.
489
490         Update ScriptExecutionContext::canSuspendActiveDOMObjects() to
491         canSuspendActiveDOMObjectsForPageCache() as the method was renamed.
492
493         * WebView/WebFrame.mm:
494         (-[WebFrame _cacheabilityDictionary]):
495
496 2015-04-07  Anders Carlsson  <andersca@apple.com>
497
498         Get rid of uses of ApplicationCacheStorage::singleton() from WebKitLegacy
499         https://bugs.webkit.org/show_bug.cgi?id=143504
500
501         Reviewed by Sam Weinig.
502
503         Add a webApplicationCacheStorage() function and use it throughout WebKitLegacy.
504         In the future, webApplicationCacheStorage will return a custom singleton, but for now
505         it just returns ApplicationCacheStorage::singleton().
506
507         * Misc/WebCache.mm:
508         (+[WebCache empty]):
509         * WebCoreSupport/WebApplicationCache.mm:
510         (+[WebApplicationCache maximumSize]):
511         (+[WebApplicationCache setMaximumSize:]):
512         (+[WebApplicationCache defaultOriginQuota]):
513         (+[WebApplicationCache setDefaultOriginQuota:]):
514         (+[WebApplicationCache originsWithCache]):
515         (webApplicationCacheStorage):
516         * WebCoreSupport/WebApplicationCacheInternal.h: Added.
517         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
518         (-[WebApplicationCacheQuotaManager usage]):
519         (-[WebApplicationCacheQuotaManager quota]):
520         (-[WebApplicationCacheQuotaManager setQuota:]):
521         * WebView/WebView.mm:
522         (WebKitInitializeApplicationCachePathIfNecessary):
523
524 2015-04-07  Brady Eidson  <beidson@apple.com>
525
526         ContextMenuItem refactoring
527         https://bugs.webkit.org/show_bug.cgi?id=143485
528
529         Reviewed by Beth Dakin.
530
531         * WebCoreSupport/WebContextMenuClient.mm:
532         (WebContextMenuClient::contextMenuItemSelected):
533
534 2015-04-06  Chris Dumez  <cdumez@apple.com>
535
536         Bing video search result pages are not PageCacheable
537         https://bugs.webkit.org/show_bug.cgi?id=143463
538         <rdar://problem/20440916>
539
540         Reviewed by Alexey Proskuryakov.
541
542         Fix the iOS / WK1 build by using MemoryCache::resourceForRequest()
543         instead of resourceForUrl().
544
545         * Misc/WebCache.mm:
546         (+[WebCache imageForURL:]):
547
548 2015-04-05  Simon Fraser  <simon.fraser@apple.com>
549
550         Remove "go ahead and" from comments
551         https://bugs.webkit.org/show_bug.cgi?id=143421
552
553         Reviewed by Darin Adler, Benjamin Poulain.
554
555         Remove the phrase "go ahead and" from comments where it doesn't add
556         anything (which is almost all of them).
557
558         * WebView/WebDynamicScrollBarsView.mm:
559         (-[WebDynamicScrollBarsView updateScrollers]):
560         * WebView/WebHTMLView.mm:
561         (-[WebHTMLView insertText:]):
562
563 2015-04-02  Brady Eidson  <beidson@apple.com>
564
565         Unreviewed: Reland change after rollout.
566
567         Expose the "Share" menu for text selections on platforms where it's available.
568         rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
569
570         * WebView/WebImmediateActionController.mm: Update for required #include
571
572 2015-04-02  Commit Queue  <commit-queue@webkit.org>
573
574         Unreviewed, rolling out r182293.
575         https://bugs.webkit.org/show_bug.cgi?id=143355
576
577         Broke GTK and EFL builds. (Requested by bfulgham on #webkit).
578
579         Reverted changeset:
580
581         "Expose the "Share" menu for text selections on platforms
582         where it's available."
583         https://bugs.webkit.org/show_bug.cgi?id=143318
584         http://trac.webkit.org/changeset/182293
585
586 2015-04-02  Brady Eidson  <beidson@apple.com>
587
588         Expose the "Share" menu for text selections on platforms where it's available.
589         rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
590
591         Reviewed by Sam Weinig.
592
593         * WebView/WebImmediateActionController.mm: Update for required #include
594
595 2015-04-02  Yusuke Suzuki  <utatane.tea@gmail.com>
596
597         Clean up EnumerationMode to easily extend
598         https://bugs.webkit.org/show_bug.cgi?id=143276
599
600         Reviewed by Geoffrey Garen.
601
602         Use default EnumerationMode().
603
604         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
605         (WebKit::NetscapePluginInstanceProxy::enumerate):
606
607 2015-03-31  Simon Fraser  <simon.fraser@apple.com>
608
609         Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
610         https://bugs.webkit.org/show_bug.cgi?id=143288
611
612         Reviewed by Beth Dakin.
613
614         Remove the wheel event counting that Document does, and passes into the scrolling tree.
615         The ScrollingTree now just uses the non-fast scrollable region to determine when to
616         fast scroll on pages with wheel event handlers.
617
618         * WebCoreSupport/WebChromeClient.h:
619
620 2015-03-31  Timothy Horton  <timothy_horton@apple.com>
621
622         TextIndicator for <span> inside an <a> only highlights the <span>, should highlight the whole <a>
623         https://bugs.webkit.org/show_bug.cgi?id=143287
624         <rdar://problem/20318342>
625
626         Reviewed by Beth Dakin.
627
628         * WebView/WebImmediateActionController.mm:
629         (-[WebImmediateActionController _defaultAnimationController]):
630         Instead of just highlighting the hit element, highlight the whole
631         element that the link URL comes from.
632
633 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
634
635         Clean up Identifier factories to clarify the meaning of StringImpl*
636         https://bugs.webkit.org/show_bug.cgi?id=143146
637
638         Reviewed by Filip Pizlo.
639
640         Just change to Identifier::fromString.
641
642         * Plugins/Hosted/NetscapePluginHostProxy.mm:
643         (identifierFromIdentifierRep):
644         * Plugins/Hosted/ProxyInstance.mm:
645         (WebKit::ProxyInstance::getPropertyNames):
646
647 2015-03-28  Anders Carlsson  <andersca@apple.com>
648
649         Remove an unused SPI method from WebKitLegacy
650         https://bugs.webkit.org/show_bug.cgi?id=143185
651
652         Reviewed by Sam Weinig.
653
654         * WebView/WebDataSource.mm:
655         (-[WebDataSource _transferApplicationCache:]): Deleted.
656         * WebView/WebDataSourcePrivate.h:
657
658 2015-03-26  Alex Christensen  <achristensen@webkit.org>
659
660         Progress towards CMake on Mac.
661         https://bugs.webkit.org/show_bug.cgi?id=143112
662
663         Reviewed by Chris Dumez.
664
665         * WebCoreSupport/WebFrameLoaderClient.h:
666
667 2015-03-26  Ryosuke Niwa  <rniwa@webkit.org>
668
669         Cursor doesn't change back to pointer when leaving Mail
670         https://bugs.webkit.org/show_bug.cgi?id=132038
671
672         Reviewed by Anders Carlsson.
673
674         Fixed the bug by adding a cursor rect and making the primary tracking area update the cursor so that
675         AppKit will reset the cursor as it leaves the WebView.
676
677         We use nil cursor here since we manually update the cursor by calling [NSCursor set].
678
679         * WebView/WebHTMLView.mm:
680         (-[WebHTMLView setDataSource:]): Use NSTrackingCursorUpdate option in creating the primary tracking area.
681
682 2015-03-24  Anders Carlsson  <andersca@apple.com>
683
684         Fix designated initializer violations
685         https://bugs.webkit.org/show_bug.cgi?id=143016
686         rdar://problem/20268858
687
688         Reviewed by Dan Bernstein.
689
690         Move -[WebBackForwardList initWithBackForwardList:] to the implementation instead of a category since
691         nobody calls it outside of WebBackForwardList.mm.
692
693         * History/WebBackForwardList.mm:
694         * History/WebBackForwardListInternal.h:
695
696 2015-03-23  Alexey Proskuryakov  <ap@apple.com>
697
698         REGRESSION (Yosemite): WKView visibility notifications are messed up
699         https://bugs.webkit.org/show_bug.cgi?id=142945
700
701         Reviewed by Tim Horton.
702
703         As these notifications cannot be used by NSView subclasses, create a separate
704         object for observing them.
705
706         * WebView/WebView.mm:
707         (-[WebView _commonInitializationWithFrameName:groupName:]):
708         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
709         (-[WebView addWindowObserversForWindow:]):
710         (-[WebView removeWindowObservers]):
711         (-[WebView viewWillMoveToWindow:]): Make sure that observers are removed even
712         if -[WebView close] is called manually.
713         * WebView/WebViewData.h:
714         * WebView/WebViewData.mm:
715         (-[WebWindowVisibilityObserver initWithView:]):
716         (-[WebWindowVisibilityObserver startObserving:]):
717         (-[WebWindowVisibilityObserver stopObserving:]):
718         (-[WebWindowVisibilityObserver _windowVisibilityChanged:]):
719
720 2015-03-23  Tim Horton  <timothy_horton@apple.com>
721
722         Add a share item to the link action menu
723         https://bugs.webkit.org/show_bug.cgi?id=142961
724         <rdar://problem/19198374>
725
726         Reviewed by Beth Dakin.
727
728         * WebView/WebActionMenuController.mm:
729         (-[WebActionMenuController _defaultMenuItemsForImage]):
730         (-[WebActionMenuController _defaultMenuItemsForVideo]):
731         (-[WebActionMenuController _createActionMenuItemForTag:]):
732         (-[WebActionMenuController _createShareActionMenuItemForTag:withItems:]):
733         Adopt -[NSMenuItem standardShareMenuItemWithItems].
734         All of the null-checking is unnecessary as it's impossible to enter
735         these functions with a null image/etc.
736         Also, remove a duplicate isDownloadableMedia check for the 'save to downloads' item.
737
738         (-[WebActionMenuController _defaultMenuItemsForLink]):
739         * WebView/WebUIDelegatePrivate.h:
740         Add a 'Share' item to the link menu.
741
742 2015-03-22  Alexey Proskuryakov  <ap@apple.com>
743
744         Build fix.
745
746         * WebView/WebView.mm: (-[WebView _showPlaybackTargetPicker:hasVideo:]):
747
748 2015-03-22  Eric Carlson  <eric.carlson@apple.com>
749
750         [Mac] Enable WIRELESS_PLAYBACK_TARGET for WK1
751         https://bugs.webkit.org/show_bug.cgi?id=142940
752
753         Reviewed by Sam Weinig.
754
755         * WebCoreSupport/WebChromeClient.h:
756         * WebCoreSupport/WebChromeClient.mm:
757         (WebChromeClient::showPlaybackTargetPicker): New.
758         (WebChromeClient::startingMonitoringPlaybackTargets): New.
759         (WebChromeClient::stopMonitoringPlaybackTargets): New.
760
761         * WebView/WebView.mm:
762         (-[WebView _close]): Invalidate and free the target picker.
763         (-[WebView _devicePicker]): New.
764         (-[WebView _showPlaybackTargetPicker:hasVideo:]): New.
765         (-[WebView _startingMonitoringPlaybackTargets]): New.
766         (-[WebView _stopMonitoringPlaybackTargets]): New.
767
768         * WebView/WebMediaPlaybackTargetPicker.h:
769         * WebView/WebMediaPlaybackTargetPicker.mm:
770         (WebMediaPlaybackTargetPicker::create): New.
771         (WebMediaPlaybackTargetPicker::WebMediaPlaybackTargetPicker): New.
772         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): New.
773         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): New.
774         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): New.
775         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): New.
776         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange): New.
777         (WebMediaPlaybackTargetPicker::invalidate): New.
778         (WebMediaPlaybackTargetPicker::targetPicker): New.
779
780         * WebView/WebViewData.h:
781         (WebMediaPlaybackTargetPicker::~WebMediaPlaybackTargetPicker):
782         * WebView/WebViewData.mm:
783         * WebView/WebViewInternal.h:
784
785 2015-03-19  Andy Estes  <aestes@apple.com>
786
787         [Content Filtering] Add tests for unblock requests
788         https://bugs.webkit.org/show_bug.cgi?id=142900
789
790         Reviewed by Andreas Kling.
791
792         * WebCoreSupport/WebFrameLoaderClient.mm:
793         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): This now happens in PolicyChecker.
794         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
795         * WebView/WebFrame.mm:
796         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Deleted.
797         * WebView/WebFrameInternal.h: Removed contentFilterUnblockHandler from WebFramePrivate.
798
799 2015-03-19  Enrica Casucci  <enrica@apple.com>
800
801         <attachment> should put URLs on the pasteboard so that Finder can accept drops.
802         https://bugs.webkit.org/show_bug.cgi?id=142801
803         rdar://problem/19982527
804
805         Reviewed by Tim Horton.
806
807         This patch adds all the necessary support to write attachment elements into
808         the pasteboard, including the promised type in WK1.
809
810         * Misc/WebNSPasteboardExtras.mm:
811         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
812         * WebCoreSupport/WebDragClient.h:
813         * WebCoreSupport/WebDragClient.mm:
814         (WebDragClient::declareAndWriteAttachment):
815         * WebView/WebHTMLView.mm:
816         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
817         * WebView/WebUIDelegate.h:
818
819 2015-03-19  Chris Dumez  <cdumez@apple.com>
820
821         Clean up DOMTimer related settings
822         https://bugs.webkit.org/show_bug.cgi?id=142837
823
824         Reviewed by Darin Adler.
825
826         Stop setting the DOMTimers' default minimum interval to 4ms as this
827         is now the default.
828
829         * WebView/WebView.mm:
830         (-[WebView _commonInitializationWithFrameName:groupName:]):
831
832 2015-03-17  Conrad Shultz  <conrad_shultz@apple.com>
833
834         Ignore some deprecation warnings
835         https://bugs.webkit.org/show_bug.cgi?id=142813
836
837         Reviewed by Mark Rowe.
838
839         Fixing the deprecations is tracked by: <rdar://problem/20201450>
840
841         * WebCoreSupport/PopupMenuMac.mm:
842         (PopupMenuMac::populate):
843
844 2015-03-17  Tim Horton  <timothy_horton@apple.com>
845
846         Cannot invoke action menus anymore
847         https://bugs.webkit.org/show_bug.cgi?id=142797
848         <rdar://problem/20032670>
849
850         * WebView/WebHTMLView.mm:
851         (-[WebHTMLView otherMouseDown:]):
852         Need a respondsToSelector check.
853
854 2015-03-17  Tim Horton  <timothy_horton@apple.com>
855
856         Fix the iOS build
857
858         * WebView/WebHTMLView.mm:
859
860 2015-03-17  Tim Horton  <timothy_horton@apple.com>
861
862         Cannot invoke action menus anymore
863         https://bugs.webkit.org/show_bug.cgi?id=142797
864         <rdar://problem/20032670>
865
866         Reviewed by Beth Dakin.
867
868         * WebView/WebHTMLView.mm:
869         (-[WebHTMLView otherMouseDown:]):
870         Don't override otherMouseDown: if the event would make an action menu.
871
872 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
873
874         Enable ES6 classes by default
875         https://bugs.webkit.org/show_bug.cgi?id=142774
876
877         Reviewed by Gavin Barraclough.
878
879         * Configurations/FeatureDefines.xcconfig:
880
881 2015-03-16  Brent Fulgham  <bfulgham@apple.com>
882
883         WebKit1 Clients Are Not Reliably Repainted
884         https://bugs.webkit.org/show_bug.cgi?id=142750
885         <rdar://problem/20042453>
886
887         Reviewed by Simon Fraser.
888
889         Check with the FrameView to see if we are in an immediately paintable state. If we are not,
890         mark the view as dirty once the _immediateScrollToPoint operation is complete so that the
891         region will be painted properly.
892
893         * WebView/WebClipView.mm:
894         (-[WebClipView _immediateScrollToPoint:]): 
895
896 2015-03-16  Conrad Shultz  <conrad_shultz@apple.com>
897
898         Allow clients to selectively disable plug-ins
899         https://bugs.webkit.org/show_bug.cgi?id=142506
900
901         Reviewed by Anders Carlsson.
902
903         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
904         from the page). As part of this:
905
906         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
907            set of plug-ins.
908
909         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
910            down the stack.
911
912         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
913            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
914
915         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
916
917         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
918         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
919
920         * Plugins/WebBasePluginPackage.mm:
921         (-[WebBasePluginPackage getPluginInfoFromPLists]):
922         Set new members in PluginInfo.
923
924         * Plugins/WebNetscapePluginPackage.mm:
925         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
926         Set new members in PluginInfo.
927
928         * WebCoreSupport/WebPlatformStrategies.h:
929         * WebCoreSupport/WebPlatformStrategies.mm:
930         (WebPlatformStrategies::getWebVisiblePluginInfo):
931         Override to wrap getPluginInfo().
932         (WebPlatformStrategies::setPluginLoadClientPolicy):
933         Override to do nothing.
934         (WebPlatformStrategies::clearPluginClientPolicies):
935         Ditto.
936
937         * WebView/WebFrame.mm:
938         (-[WebFrame _canProvideDocumentSource]):
939         Update to reflect function rename.
940
941 2015-03-14  Dean Jackson  <dino@apple.com>
942
943         Feature flag for Animations Level 2
944         https://bugs.webkit.org/show_bug.cgi?id=142699
945         <rdar://problem/20165097>
946
947         Reviewed by Brent Fulgham.
948
949         Add ENABLE_CSS_ANIMATIONS_LEVEL_2 and a runtime flag animationTriggersEnabled.
950
951         * Configurations/FeatureDefines.xcconfig:
952
953 2015-03-13  Commit Queue  <commit-queue@webkit.org>
954
955         Unreviewed, rolling out r181483.
956         https://bugs.webkit.org/show_bug.cgi?id=142688
957
958         Caused use-after-free on many tests (Requested by ap on
959         #webkit).
960
961         Reverted changeset:
962
963         "Allow clients to selectively disable plug-ins"
964         https://bugs.webkit.org/show_bug.cgi?id=142506
965         http://trac.webkit.org/changeset/181483
966
967 2015-03-13  Eric Carlson  <eric.carlson@apple.com>
968
969         [Mac] Enable WIRELESS_PLAYBACK_TARGET
970         https://bugs.webkit.org/show_bug.cgi?id=142635
971
972         Reviewed by Darin Adler.
973
974         * Configurations/FeatureDefines.xcconfig:
975
976 2015-03-10  Conrad Shultz  <conrad_shultz@apple.com>
977
978         Allow clients to selectively disable plug-ins
979         https://bugs.webkit.org/show_bug.cgi?id=142506
980
981         Reviewed by Anders Carlsson.
982
983         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
984         from the page). As part of this:
985
986         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
987            set of plug-ins.
988
989         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
990            down the stack.
991
992         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
993            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
994
995         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
996
997         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
998         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
999
1000         * Plugins/WebBasePluginPackage.mm:
1001         (-[WebBasePluginPackage getPluginInfoFromPLists]):
1002         Set new members in PluginInfo.
1003
1004         * Plugins/WebNetscapePluginPackage.mm:
1005         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
1006         Set new members in PluginInfo.
1007
1008         * WebCoreSupport/WebPlatformStrategies.h:
1009         * WebCoreSupport/WebPlatformStrategies.mm:
1010         (WebPlatformStrategies::getWebVisiblePluginInfo):
1011         Override to wrap getPluginInfo().
1012         (WebPlatformStrategies::setPluginLoadClientPolicy):
1013         Override to do nothing.
1014         (WebPlatformStrategies::clearPluginClientPolicies):
1015         Ditto.
1016
1017         * WebView/WebFrame.mm:
1018         (-[WebFrame _canProvideDocumentSource]):
1019         Update to reflect function rename.
1020
1021 2015-03-10  Sam Weinig  <sam@webkit.org>
1022
1023         Allow adding a button in input elements for auto fill related functionality
1024         <rdar://problem/19782066>
1025         https://bugs.webkit.org/show_bug.cgi?id=142564
1026
1027         Reviewed by Anders Carlsson.
1028
1029         * DOM/WebDOMOperations.mm:
1030         (-[DOMHTMLInputElement _setAutofilled:]):
1031         Update for consistent spelling of AutoFill.
1032
1033 2015-03-10  Timothy Horton  <timothy_horton@apple.com>
1034
1035         Fix the build
1036
1037         * History/WebHistory.mm:
1038         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1039         * WebCoreSupport/WebFrameLoaderClient.mm:
1040         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1041
1042 2015-03-10  Tim Horton  <timothy_horton@apple.com>
1043
1044         Fix the Mac build with a newer compiler
1045
1046         * Plugins/WebPluginController.mm:
1047         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1048         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1049
1050 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1051
1052         [iOS] Fix build when compiling with dead code stripping disabled
1053         <http://webkit.org/b/142467>
1054
1055         Reviewed by Simon Fraser.
1056
1057         * Configurations/WebKitLegacy.xcconfig:
1058         (EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code
1059         generation and compilation for out-of-process plugin support.
1060         This was never used on iOS.
1061
1062 2015-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
1063
1064         [iOS] SVG fonts are garbled
1065         https://bugs.webkit.org/show_bug.cgi?id=142377
1066
1067         Reviewed by Simon Fraser.
1068
1069         * Configurations/FeatureDefines.xcconfig:
1070
1071 2015-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1072
1073         Hide Promise with runtime flags under Cocoa JSContext API
1074         https://bugs.webkit.org/show_bug.cgi?id=141965
1075
1076         Reviewed by Filip Pizlo.
1077
1078         Add new JSC runtime flag, PromiseDisabled.
1079
1080         * WebView/WebPreferencesPrivate.h:
1081
1082 2015-03-03  Andy Estes  <aestes@apple.com>
1083
1084         [Content Filtering] Separate unblock handling into its own class
1085         https://bugs.webkit.org/show_bug.cgi?id=142251
1086
1087         Reviewed by Andreas Kling.
1088         
1089         Adopted ContentFilterUnblockHandler.
1090
1091         * WebCoreSupport/WebFrameLoaderClient.h:
1092         * WebCoreSupport/WebFrameLoaderClient.mm:
1093         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1094         * WebView/WebFrame.mm:
1095         (-[WebFrame _contentFilterDidHandleNavigationAction:]):
1096         * WebView/WebFrameInternal.h:
1097
1098 2015-03-03  Chris Dumez  <cdumez@apple.com>
1099
1100         Access ApplicationCacheStorage global instance via singleton() static member function
1101         https://bugs.webkit.org/show_bug.cgi?id=142239
1102
1103         Reviewed by Anders Carlsson.
1104
1105         Access ApplicationCacheStorage global instance via singleton() static
1106         member function as per WebKit coding style.
1107
1108 2015-03-02  Jer Noble  <jer.noble@apple.com>
1109
1110         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1111         https://bugs.webkit.org/show_bug.cgi?id=142121
1112
1113         Reviewed by Simon Fraser.
1114
1115         Fullscreening a page with a non-1 scale would result in that scale being applied to the
1116         fullscreen content, breaking fullscreen mode. Set the page scale to 1 when entering
1117         fullscreen and reset it to the original value when exiting fullscreen.
1118
1119         * WebView/WebFullScreenController.h:
1120         * WebView/WebFullScreenController.mm:
1121         (-[WebFullScreenController enterFullScreen:]): Set the page scale to 1.
1122         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Reset the page
1123                 scale to the original value.
1124         * WebView/WebView.mm:
1125         (-[WebView _supportsFullScreenForElement:withKeyboard:]): Drive-by fix. Check the
1126                 WebView's own preferences to see if fullscreen mode is enabled, rather than
1127                 the global object's.
1128
1129 2015-03-01  Chris Dumez  <cdumez@apple.com>
1130
1131         Make NotificationCenter / Notification suspendable
1132         https://bugs.webkit.org/show_bug.cgi?id=142117
1133         <rdar://problem/19923085>
1134
1135         Reviewed by Andreas Kling.
1136
1137         Provide implementation for NotificationClient::hasPendingPermissionRequests().
1138         The implementation is very simplistic. it will only return false if no
1139         request for permission for ever made. This is because there is currently no
1140         easy way to figure out if a permission request is pending or not.
1141
1142         * WebCoreSupport/WebNotificationClient.h:
1143         * WebCoreSupport/WebNotificationClient.mm:
1144         (WebNotificationClient::requestPermission):
1145         (WebNotificationClient::hasPendingPermissionRequests):
1146
1147 2015-02-28  Simon Fraser  <simon.fraser@apple.com>
1148
1149         Viewport units should not dirty style just before we do layout
1150         https://bugs.webkit.org/show_bug.cgi?id=141682
1151
1152         Reviewed by Zalan Bujtas.
1153
1154         * WebView/WebFrameView.mm:
1155         (-[WebFrameView _frameSizeChanged]):
1156
1157 2015-02-26  Chris Dumez  <cdumez@apple.com>
1158
1159         Rename DatabaseManager::manager() to DatabaseManager::singleton()
1160         https://bugs.webkit.org/show_bug.cgi?id=142054
1161
1162         Reviewed by Ryosuke Niwa.
1163
1164         Rename DatabaseManager::manager() to DatabaseManager::singleton() as
1165         per coding style and use WTF::NeverDestroyed.
1166
1167         * Storage/WebDatabaseManager.mm:
1168         (-[WebDatabaseManager init]):
1169         (-[WebDatabaseManager origins]):
1170         (-[WebDatabaseManager databasesWithOrigin:]):
1171         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
1172         (-[WebDatabaseManager deleteAllDatabases]):
1173         (-[WebDatabaseManager deleteOrigin:]):
1174         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1175         * Storage/WebDatabaseQuotaManager.mm:
1176         (-[WebDatabaseQuotaManager usage]):
1177         (-[WebDatabaseQuotaManager quota]):
1178         (-[WebDatabaseQuotaManager setQuota:]):
1179         * WebCoreSupport/WebSecurityOrigin.mm:
1180         (-[WebSecurityOrigin usage]):
1181         (-[WebSecurityOrigin quota]):
1182         (-[WebSecurityOrigin setQuota:]):
1183         * WebView/WebFrame.mm:
1184         (-[WebFrame _cacheabilityDictionary]):
1185         * WebView/WebView.mm:
1186         (-[WebView _preferencesChanged:]):
1187
1188 2015-02-26  Myles C. Maxfield  <mmaxfield@apple.com>
1189
1190         [Mac] [iOS] Parsing support for -apple-trailing-word
1191         https://bugs.webkit.org/show_bug.cgi?id=141939
1192
1193         Reviewed by Andreas Kling.
1194
1195         * Configurations/FeatureDefines.xcconfig:
1196
1197 2015-02-24  Commit Queue  <commit-queue@webkit.org>
1198
1199         Unreviewed, rolling out r180599.
1200         https://bugs.webkit.org/show_bug.cgi?id=141998
1201
1202         Lots of new test failures (Requested by smfr on #webkit).
1203
1204         Reverted changeset:
1205
1206         "Parsing support for -webkit-trailing-word"
1207         https://bugs.webkit.org/show_bug.cgi?id=141939
1208         http://trac.webkit.org/changeset/180599
1209
1210 2015-02-24  Myles C. Maxfield  <mmaxfield@apple.com>
1211
1212         [Mac] [iOS] Parsing support for -apple-trailing-word
1213         https://bugs.webkit.org/show_bug.cgi?id=141939
1214
1215         Reviewed by Andreas Kling.
1216
1217         * Configurations/FeatureDefines.xcconfig:
1218
1219 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1220
1221         REGRESSION(r179429): Can't type comments in Facebook
1222         https://bugs.webkit.org/show_bug.cgi?id=141859
1223
1224         Reviewed by Brent Fulgham.
1225
1226         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1227         Private API, javaScriptExperimentsEnabled is dropped.
1228
1229         * Misc/WebNSDictionaryExtras.h:
1230         * Misc/WebNSDictionaryExtras.m:
1231         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1232         * WebKit.order:
1233         * WebView/WebPreferenceKeysPrivate.h:
1234         * WebView/WebPreferences.mm:
1235         (+[WebPreferences initialize]):
1236         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1237         (-[WebPreferences javaScriptRuntimeFlags]):
1238         (-[WebPreferences setJavaScriptRuntimeFlags:]):
1239         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1240         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1241         * WebView/WebPreferencesPrivate.h:
1242         * WebView/WebView.mm:
1243         (-[WebView _preferencesChanged:]):
1244
1245 2015-02-23  Commit Queue  <commit-queue@webkit.org>
1246
1247         Unreviewed, rolling out r180547 and r180550.
1248         https://bugs.webkit.org/show_bug.cgi?id=141957
1249
1250         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1251
1252         Reverted changesets:
1253
1254         "REGRESSION(r179429): Can't type comments in Facebook"
1255         https://bugs.webkit.org/show_bug.cgi?id=141859
1256         http://trac.webkit.org/changeset/180547
1257
1258         "Constructor returning null should construct an object instead
1259         of null"
1260         https://bugs.webkit.org/show_bug.cgi?id=141640
1261         http://trac.webkit.org/changeset/180550
1262
1263 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1264
1265         Disable font loading events until our implementation gets updated to match the latest spec
1266         https://bugs.webkit.org/show_bug.cgi?id=141938
1267
1268         Reviewed by Andreas Kling.
1269
1270         * Configurations/FeatureDefines.xcconfig:
1271
1272 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1273
1274         REGRESSION(r179429): Can't type comments in Facebook
1275         https://bugs.webkit.org/show_bug.cgi?id=141859
1276
1277         Reviewed by Geoffrey Garen.
1278
1279         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1280         Private API, javaScriptExperimentsEnabled is dropped.
1281
1282         * Misc/WebNSDictionaryExtras.h:
1283         * Misc/WebNSDictionaryExtras.m:
1284         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1285         * WebKit.order:
1286         * WebView/WebPreferenceKeysPrivate.h:
1287         * WebView/WebPreferences.mm:
1288         (+[WebPreferences initialize]):
1289         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1290         (-[WebPreferences javaScriptRuntimeFlags]):
1291         (-[WebPreferences setJavaScriptRuntimeFlags:]):
1292         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1293         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1294         * WebView/WebPreferencesPrivate.h:
1295         * WebView/WebView.mm:
1296         (-[WebView _preferencesChanged:]):
1297
1298 2015-02-20  Eric Carlson  <eric.carlson@apple.com>
1299
1300         [iOS] cleanup AirPlay code
1301         https://bugs.webkit.org/show_bug.cgi?id=141811
1302
1303         Reviewed by Jer Noble.
1304
1305         * Configurations/FeatureDefines.xcconfig: IOS_AIRPLAY -> WIRELESS_PLAYBACK_TARGET.
1306
1307 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
1308
1309         Adopt WebCore::IOSurface in ImageBuffer
1310         https://bugs.webkit.org/show_bug.cgi?id=141751
1311
1312         Reviewed by Simon Fraser.
1313
1314         * WebCoreSupport/WebSystemInterface.mm:
1315         (InitWebCoreSystemInterface):
1316         Remove old WKSI IOSurface-related functions.
1317
1318 2015-02-18  Commit Queue  <commit-queue@webkit.org>
1319
1320         Unreviewed, rolling out r180286.
1321         https://bugs.webkit.org/show_bug.cgi?id=141766
1322
1323         Caused >50 crashed LayoutTests (Requested by jernoble on
1324         #webkit).
1325
1326         Reverted changeset:
1327
1328         "Page::userContentController() should return a reference, not
1329         a pointer"
1330         https://bugs.webkit.org/show_bug.cgi?id=141764
1331         http://trac.webkit.org/changeset/180286
1332
1333 2015-02-18  Brady Eidson  <beidson@apple.com>
1334
1335         Page::userContentController() should return a reference, not a pointer
1336         https://bugs.webkit.org/show_bug.cgi?id=141764
1337
1338         Reviewed by Jer Noble.
1339
1340         * WebView/WebView.mm:
1341         (-[WebView setGroupName:]):
1342
1343 2015-02-18  Chris Dumez  <cdumez@apple.com>
1344
1345         Access FontCache global instance via singleton() static member function
1346         https://bugs.webkit.org/show_bug.cgi?id=141726
1347
1348         Reviewed by Daniel Bates.
1349
1350         Access FontCache global instance via singleton() static member function,
1351         as per coding style.
1352
1353 2015-02-17  Chris Dumez  <cdumez@apple.com>
1354
1355         Access MemoryPressureHandler global instance via a singleton() static member function
1356         https://bugs.webkit.org/show_bug.cgi?id=141691
1357
1358         Reviewed by Andreas Kling.
1359
1360         Access MemoryPressureHandler global instance via a singleton() static
1361         member function.
1362
1363         * WebView/WebView.mm:
1364         (-[WebView _commonInitializationWithFrameName:groupName:]):
1365         (+[WebView registerForMemoryNotifications]):
1366         (+[WebView _isUnderMemoryPressure]):
1367         (+[WebView _clearMemoryPressure]):
1368         (+[WebView _shouldWaitForMemoryClearMessage]):
1369         (WebInstallMemoryPressureHandler):
1370
1371 2015-02-15  Sam Weinig  <sam@webkit.org>
1372
1373         Add experimental <attachment> element support
1374         https://bugs.webkit.org/show_bug.cgi?id=141626
1375
1376         Reviewed by Tim Horton.
1377
1378         * Configurations/FeatureDefines.xcconfig:
1379
1380 2015-02-14  Joseph Pecoraro  <pecoraro@apple.com>
1381
1382         [Mac] Possible DDActionContext leaks, RetainPtr cleanup
1383         https://bugs.webkit.org/show_bug.cgi?id=141613
1384
1385         Reviewed by Tim Horton.
1386
1387         * WebCoreSupport/WebEditorClient.mm:
1388         (WebEditorClient::WebEditorClient):
1389         Avoid unnecessary retain/autorelease by adopting.
1390
1391         * WebView/WebActionMenuController.mm:
1392         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1393         Adopt the allocated object.
1394
1395 2015-02-09  Brian J. Burg  <burg@cs.washington.edu>
1396
1397         Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace
1398         https://bugs.webkit.org/show_bug.cgi?id=141372
1399
1400         Reviewed by Joseph Pecoraro.
1401
1402         * WebCoreSupport/WebInspectorClient.mm:
1403         (-[WebInspectorWindowController destroyInspectorView:]):
1404
1405 2015-02-14  Alexey Proskuryakov  <ap@apple.com>
1406
1407         rel="noreferrer" should make window.opener null
1408         https://bugs.webkit.org/show_bug.cgi?id=141579
1409
1410         Reviewed by Darin Adler.
1411
1412         * WebView/WebPDFView.mm:
1413         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore
1414         function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
1415
1416 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
1417
1418         [Streams API] Implement a barebone ReadableStream interface
1419         https://bugs.webkit.org/show_bug.cgi?id=141045
1420
1421         Reviewed by Benjamin Poulain.
1422
1423         * Configurations/FeatureDefines.xcconfig:
1424
1425 2015-02-03  Enrica Casucci  <enrica@apple.com>
1426
1427         [iOS] Add support for deleteFromInputWithFlags.
1428         https://bugs.webkit.org/show_bug.cgi?id=141216
1429         rdar://problem/19130081
1430
1431         Reviewed by Benjamin Poulain.
1432
1433         Adopts the new method as soon as it is available.
1434         The patch also removes some obsolete code used for staging.
1435
1436         * WebView/WebHTMLView.mm:
1437         (-[WebHTMLView _handleEditingKeyEvent:]):
1438
1439 2015-02-02  Chris Dumez  <cdumez@apple.com>
1440
1441         Access MemoryCache singleton using MemoryCache::singleton()
1442         https://bugs.webkit.org/show_bug.cgi?id=141104
1443
1444         Reviewed by Andreas Kling.
1445
1446         Access MemoryCache singleton using MemoryCache::singleton() static
1447         member function, instead of a free function, as per the recent
1448         coding style discussion on WebKit-dev.
1449
1450 2015-02-01  Chris Dumez  <cdumez@apple.com>
1451
1452         Use more references in HistoryItem
1453         https://bugs.webkit.org/show_bug.cgi?id=141133
1454
1455         Reviewed by Andreas Kling.
1456
1457         Use more references in HistoryItem instead of pointers.
1458
1459 2015-01-31  Sam Weinig  <sam@webkit.org>
1460
1461         Remove even more Mountain Lion support
1462         https://bugs.webkit.org/show_bug.cgi?id=141124
1463
1464         Reviewed by Alexey Proskuryakov.
1465
1466         * Configurations/Base.xcconfig:
1467         * Configurations/DebugRelease.xcconfig:
1468         * Configurations/FeatureDefines.xcconfig:
1469         * Configurations/Version.xcconfig:
1470         * Configurations/WebKitLegacy.xcconfig:
1471
1472 2015-01-30  Eric Carlson  <eric.carlson@apple.com>
1473
1474         Remove MediaPlayerProxy.h
1475         https://bugs.webkit.org/show_bug.cgi?id=141087
1476
1477         Reviewed by Sam Weinig.
1478
1479         * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h.
1480         * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h.
1481
1482 2015-01-30  Chris Dumez  <cdumez@apple.com>
1483
1484         Rename shared() static member functions to singleton() for singleton classes.
1485         https://bugs.webkit.org/show_bug.cgi?id=141088
1486
1487         Reviewed by Ryosuke Niwa and Benjamin Poulain.
1488
1489         Rename shared() static member functions to singleton() for singleton
1490         classes as per the recent coding style change.
1491
1492 2015-01-29  Beth Dakin  <bdakin@apple.com>
1493
1494         Remove more Mountain Lion code from WebKit
1495         https://bugs.webkit.org/show_bug.cgi?id=141050
1496
1497         Reviewed by Anders Carlsson.
1498
1499         * History/WebHistory.mm:
1500         (getDayBoundaries):
1501         * Panels/WebAuthenticationPanel.m:
1502         (-[WebAuthenticationPanel cancel:]):
1503         (-[WebAuthenticationPanel logIn:]):
1504         (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]):
1505         * WebCoreSupport/WebSystemInterface.mm:
1506         (InitWebCoreSystemInterface):
1507         * WebView/WebFrameView.mm:
1508         * WebView/WebPreferences.mm:
1509         (+[WebPreferences initialize]):
1510         (needsScreenFontsEnabledQuirk):
1511         * WebView/WebView.mm:
1512         (+[WebView registerForMemoryNotifications]):
1513         (-[WebView _preferencesChanged:]):
1514         (+[WebView initialize]):
1515         (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
1516         (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
1517         (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):
1518
1519 2015-01-29  Sam Weinig  <sam@webkit.org>
1520
1521         Remove support for screen font substitution
1522         https://bugs.webkit.org/show_bug.cgi?id=141038
1523
1524         Reviewed by Tim Horton.
1525
1526         * Misc/WebKitNSStringExtras.mm:
1527         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1528         (-[NSString _web_widthWithFont:]):
1529         * Misc/WebStringTruncator.mm:
1530         (fontFromNSFont):
1531         Update for new signature of the FontPlatformData constructor, which no longer cares about
1532         whether to use printer fonts.
1533
1534         * WebView/WebPreferenceKeysPrivate.h:
1535         Remove the WebKitScreenFontSubstitutionEnabledKey key.
1536
1537         * WebView/WebPreferences.mm:
1538         (+[WebPreferences initialize]):
1539         Remove support for WebKitScreenFontSubstitutionEnabledKey.
1540
1541         (needsScreenFontsEnabledQuirk): Deleted.
1542         Remove support for the Mountain Lion era 1-Password quirk.
1543
1544         (-[WebPreferences screenFontSubstitutionEnabled]): Deleted.
1545         (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted.
1546         * WebView/WebPreferencesPrivate.h:
1547         * WebView/WebView.mm:
1548         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1549         (-[WebView _preferencesChanged:]):
1550         Remove support for the screen font substitution setting.
1551
1552 2015-01-29  Chris Dumez  <cdumez@apple.com>
1553
1554         Clean up / modernize PageCache class
1555         https://bugs.webkit.org/show_bug.cgi?id=141009
1556
1557         Reviewed by Darin Adler.
1558
1559         Clean up / modernize PageCache class.
1560
1561         * History/WebBackForwardList.mm:
1562         (-[WebBackForwardList pageCacheSize]):
1563         * WebView/WebView.mm:
1564         (-[WebView _loadBackForwardListFromOtherView:]):
1565         (-[WebView goToBackForwardItem:]):
1566         (+[WebView _setCacheModel:]):
1567
1568 2015-01-28  Beth Dakin  <bdakin@apple.com>
1569
1570         Remove Mountain Lion code from WebKit and WebKit2
1571         https://bugs.webkit.org/show_bug.cgi?id=141010
1572
1573         Reviewed by Sam Weinig.
1574
1575         * DOM/WebDOMOperations.mm:
1576         (toNSEventPhase):
1577         * WebView/WebHTMLView.mm:
1578         (isQuickLookEvent):
1579
1580 2015-01-28  Dana Burkart  <dburkart@apple.com>
1581
1582         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1583         https://bugs.webkit.org/show_bug.cgi?id=136765
1584
1585         Reviewed by Alexey Proskuryakov.
1586
1587         * Configurations/Base.xcconfig:
1588         * Configurations/DebugRelease.xcconfig:
1589
1590 2015-01-28  Chris Dumez  <cdumez@apple.com>
1591
1592         Fix typo in markPagesForVistedLinkStyleRecalc()
1593         https://bugs.webkit.org/show_bug.cgi?id=140977
1594
1595         Reviewed by Darin Adler.
1596
1597         * WebCoreSupport/WebVisitedLinkStore.mm:
1598         (WebVisitedLinkStore::removeAllVisitedLinks):
1599         (WebVisitedLinkStore::removeVisitedLink):
1600         (WebVisitedLinkStore::addVisitedLinkHash):
1601
1602 2015-01-28  Chris Dumez  <cdumez@apple.com>
1603
1604         Rename pageCache() to PageCache::shared() and return a reference
1605         https://bugs.webkit.org/show_bug.cgi?id=140983
1606
1607         Reviewed by Andreas Kling.
1608
1609         Rename pageCache() to PageCache::shared() as this is a singleton class
1610         and have it return a reference instead of a pointer.
1611
1612         * History/WebBackForwardList.mm:
1613         (-[WebBackForwardList pageCacheSize]):
1614         * Misc/WebCoreStatistics.mm:
1615         (+[WebCoreStatistics cachedPageCount]):
1616         (+[WebCoreStatistics cachedFrameCount]):
1617         * WebCoreSupport/WebVisitedLinkStore.mm:
1618         (WebVisitedLinkStore::removeAllVisitedLinks):
1619         (WebVisitedLinkStore::removeVisitedLink):
1620         (WebVisitedLinkStore::addVisitedLinkHash):
1621         * WebView/WebView.mm:
1622         (+[WebView _setCacheModel:]):
1623
1624 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1625
1626         More build fixes for newer clang.
1627
1628         Rubber-stamped by Anders Carlsson.
1629
1630         Marked a deprecated accessibility method as such.
1631
1632         * WebView/WebFrame.mm:
1633         (-[WebFrame accessibilityRoot]):
1634
1635 2015-01-27  Beth Dakin  <bdakin@apple.com>
1636
1637         Immediate action gesture recognizer still doesn't work well with IB
1638         https://bugs.webkit.org/show_bug.cgi?id=140967
1639         -and corresponding-
1640         rdar://problem/19621509
1641
1642         Reviewed by Tim Horton.
1643
1644         We should add (or remove) the gesture recognizer in viewDidMoveToWindow because 
1645         initWithFrame it too early and IB might mess with it.
1646         * WebView/WebImmediateActionController.h:
1647         * WebView/WebImmediateActionController.mm:
1648         (-[WebImmediateActionController immediateActionRecognizer]):
1649         * WebView/WebView.mm:
1650         (-[WebView _commonInitializationWithFrameName:groupName:]):
1651         (-[WebView viewDidMoveToWindow]):
1652
1653 2015-01-27  Dan Bernstein  <mitz@apple.com>
1654
1655         Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
1656
1657         Rubber-stamped by Anders Carlsson.
1658
1659         * WebView/WebView.h: Added forward declarations of the protocols.
1660
1661 2015-01-26  Anders Carlsson  <andersca@apple.com>
1662
1663         Make it easy to test enabling formal delegate protocols
1664         https://bugs.webkit.org/show_bug.cgi?id=140892
1665
1666         Reviewed by Dan Bernstein.
1667
1668         Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
1669
1670         * Misc/WebDownload.h:
1671         * WebView/WebFrameLoadDelegate.h:
1672         * WebView/WebPolicyDelegate.h:
1673         * WebView/WebResourceLoadDelegate.h:
1674         * WebView/WebUIDelegate.h:
1675         * WebView/WebView.h:
1676
1677 2015-01-26  Chris Dumez  <cdumez@apple.com>
1678
1679         Rename Document::body() to Document::bodyOrFrameset() for clarity
1680         https://bugs.webkit.org/show_bug.cgi?id=140902
1681
1682         Reviewed by Andreas Kling.
1683
1684         Rename Document::body() to Document::bodyOrFrameset() for clarity. This
1685         method does not necessarily return an HTMLBodyElement, it can also
1686         return a frameset as per the specification:
1687         http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
1688
1689         This method is often misused internally (the caller is only interested
1690         in the <body> element). I will fix these instances in a follow-up patch,
1691         this patch is only renaming mechanically.
1692
1693 2015-01-26  Chris Dumez  <cdumez@apple.com>
1694
1695         First argument to DOM traversal functions should be a reference
1696         https://bugs.webkit.org/show_bug.cgi?id=140895
1697
1698         Reviewed by Antti Koivisto.
1699
1700         First argument to DOM traversal functions should be a reference instead
1701         of a pointer as it is dereferenced without null-check.
1702
1703 2015-01-26  Myles C. Maxfield  <mmaxfield@apple.com>
1704
1705         [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
1706         https://bugs.webkit.org/show_bug.cgi?id=140860
1707
1708         Reviewed by Darin Adler.
1709
1710         The fonts it makes are grotesque. (See what I did there? Typographic
1711         humor is the best humor.)
1712
1713         * Configurations/FeatureDefines.xcconfig:
1714
1715 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
1716
1717         QLPreviewMenuItem popovers don't close when the page scrolls
1718         https://bugs.webkit.org/show_bug.cgi?id=140806
1719         <rdar://problem/19555618>
1720
1721         Reviewed by Beth Dakin.
1722
1723         Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
1724
1725         * WebView/WebHTMLView.mm:
1726         (-[WebHTMLView scrollWheel:scrollWheel:]):
1727         Send scrollWheel along to WebImmediateActionController.
1728
1729         * WebView/WebImmediateActionController.h:
1730         * WebView/WebImmediateActionController.mm:
1731         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
1732         (-[WebImmediateActionController _clearImmediateActionState]):
1733         (-[WebImmediateActionController _defaultAnimationController]):
1734         Keep track of the active QLPreviewMenuItem, and close it upon scroll.
1735
1736 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
1737
1738         Infinite recursion in _clearImmediateActionState
1739         https://bugs.webkit.org/show_bug.cgi?id=140807
1740         <rdar://problem/19571601>
1741
1742         Reviewed by Anders Carlsson.
1743
1744         * WebView/WebImmediateActionController.mm:
1745         (-[WebImmediateActionController _clearImmediateActionState]):
1746         Use this opportunity to bring identical code to WebKit1, to avoid
1747         getting DataDetectors stuck when an immediate action is canceled.
1748
1749 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1750
1751         Add a build flag for ES6 class syntax
1752         https://bugs.webkit.org/show_bug.cgi?id=140760
1753
1754         Reviewed by Michael Saboff.
1755
1756         * Configurations/FeatureDefines.xcconfig:
1757
1758 2015-01-22  Beth Dakin  <bdakin@apple.com>
1759
1760         ibtoold crash below -[WebView close]
1761         https://bugs.webkit.org/show_bug.cgi?id=140782
1762         -and corresponding-
1763         rdar://problem/19558472
1764
1765         Reviewed by Tim Horton.
1766
1767         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
1768         it is because interface builder is messing with our views.
1769         * WebView/WebImmediateActionController.h:
1770         * WebView/WebImmediateActionController.mm:
1771         (-[WebImmediateActionController webViewClosed]):
1772         (-[WebImmediateActionController _cancelImmediateAction]):
1773         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1774         (-[WebImmediateActionController _updateImmediateActionItem]):
1775
1776 2015-01-21  Beth Dakin  <bdakin@apple.com>
1777
1778         Crash in QuickLook preview delegate method
1779         https://bugs.webkit.org/show_bug.cgi?id=140740
1780         -and corresponding-
1781         rdar://problem/19540806
1782
1783         Reviewed by Tim Horton.
1784
1785         Clear out the delegate.
1786         * WebView/WebImmediateActionController.mm:
1787         (-[WebImmediateActionController webViewClosed]):
1788
1789 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
1790
1791         Remove ENABLE(INSPECTOR) ifdef guards
1792         https://bugs.webkit.org/show_bug.cgi?id=140668
1793
1794         Reviewed by Darin Adler.
1795
1796         * Configurations/FeatureDefines.xcconfig:
1797         * WebCoreSupport/WebFrameLoaderClient.mm:
1798         (WebFrameLoaderClient::dispatchWillSendRequest):
1799
1800 2015-01-20  Anders Carlsson  <andersca@apple.com>
1801
1802         Remove USE(GLIB) code from WebKit1
1803         https://bugs.webkit.org/show_bug.cgi?id=140714
1804
1805         Reviewed by Andreas Kling.
1806
1807         * WebView/WebView.mm:
1808         (-[WebView _commonInitializationWithFrameName:groupName:]):
1809         (-[WebView _close]):
1810         (-[WebView _clearGlibLoopObserver]): Deleted.
1811         (glibContextIterationCallback): Deleted.
1812         (-[WebView _scheduleGlibContextIterations]): Deleted.
1813         * WebView/WebViewData.h:
1814         * WebView/WebViewInternal.h:
1815
1816 2015-01-20  David Kilzer  <ddkilzer@apple.com>
1817
1818         Switch to comparing PLATFORM_NAME in terms of macosx
1819         <http://webkit.org/b/139516>
1820
1821         Reviewed by Timothy Hatcher.
1822
1823         * MigrateHeaders.make:
1824         * postprocess-headers.sh:
1825
1826 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1827
1828         [SVG -> OTF Converter] Flip the switch on
1829         https://bugs.webkit.org/show_bug.cgi?id=140592
1830
1831         Reviewed by Antti Koivisto.
1832
1833         * Configurations/FeatureDefines.xcconfig:
1834
1835 2015-01-19  Beth Dakin  <bdakin@apple.com>
1836
1837         Speculative build fix.
1838
1839         * WebView/WebView.mm:
1840         (-[WebView _commonInitializationWithFrameName:groupName:]):
1841
1842 2015-01-19  Beth Dakin  <bdakin@apple.com>
1843
1844         Speculative build fix.
1845
1846         * WebView/WebView.mm:
1847         (-[WebView _convertRectFromRootView:]):
1848
1849 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
1850
1851         Adjust naming of action menu SPI
1852         https://bugs.webkit.org/show_bug.cgi?id=140644
1853         <rdar://problem/19448129>
1854
1855         Reviewed by Brian Weinstein.
1856
1857         * WebView/WebActionMenuController.mm:
1858         (-[WebActionMenuController prepareForMenu:withEvent:]):
1859         (-[WebActionMenuController willOpenMenu:withEvent:]):
1860         (-[WebActionMenuController didCloseMenu:withEvent:]):
1861         * WebView/WebView.mm:
1862         (-[WebView _commonInitializationWithFrameName:groupName:]):
1863         (-[WebView prepareForMenu:withEvent:]):
1864         (-[WebView willOpenMenu:withEvent:]):
1865         (-[WebView didCloseMenu:withEvent:]):
1866
1867 2015-01-19  Beth Dakin  <bdakin@apple.com>
1868
1869         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
1870         offset by flipped-ness
1871         https://bugs.webkit.org/show_bug.cgi?id=140643
1872         -and corresponding-
1873         rdar://problem/19489593
1874
1875         Reviewed by Tim Horton.
1876
1877         We universally flipped because we assumed that the root view was flipped and the 
1878         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
1879         fixes that assumption by checking the WebView’s flipped-ness.
1880         * WebView/WebView.mm:
1881         (-[WebView _convertRectFromRootView:]):
1882
1883 2015-01-19  Commit Queue  <commit-queue@webkit.org>
1884
1885         Unreviewed, rolling out r178653.
1886         https://bugs.webkit.org/show_bug.cgi?id=140634
1887
1888         Broke multiple SVG tests on Mountain Lion (Requested by ap on
1889         #webkit).
1890
1891         Reverted changeset:
1892
1893         "[SVG -> OTF Converter] Flip the switch on"
1894         https://bugs.webkit.org/show_bug.cgi?id=140592
1895         http://trac.webkit.org/changeset/178653
1896
1897 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1898
1899         [SVG -> OTF Converter] Flip the switch on
1900         https://bugs.webkit.org/show_bug.cgi?id=140592
1901
1902         Reviewed by Antti Koivisto.
1903
1904         * Configurations/FeatureDefines.xcconfig:
1905
1906 2015-01-18  Daniel Bates  <dabates@apple.com>
1907
1908         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
1909         (https://bugs.webkit.org/show_bug.cgi?id=129441)
1910
1911         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
1912         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
1913
1914         * WebInspector/WebNodeHighlightView.mm:
1915         (-[WebNodeHighlightView layoutSublayers:]):
1916
1917 2015-01-16  Beth Dakin  <bdakin@apple.com>
1918
1919         Make sure early cancellation of immediate action actually does that in WK1
1920         https://bugs.webkit.org/show_bug.cgi?id=140566
1921         -and corresponding-
1922         rdar://problem/19490114
1923
1924         Reviewed by Tim Horton.
1925
1926         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
1927         asynchronously.
1928         * WebView/WebImmediateActionController.mm:
1929         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1930
1931 2015-01-16  Daniel Bates  <dabates@apple.com>
1932
1933         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
1934         (https://bugs.webkit.org/show_bug.cgi?id=140360)
1935
1936         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
1937
1938         * Misc/WebDownload.h:
1939
1940 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
1941
1942         Remove ENABLE(SQL_DATABASE) guards
1943         https://bugs.webkit.org/show_bug.cgi?id=140434
1944
1945         Reviewed by Darin Adler.
1946
1947         * Configurations/FeatureDefines.xcconfig:
1948         * Storage/WebDatabaseManager.mm:
1949         (databasesDirectoryPath):
1950         * Storage/WebDatabaseManagerClient.h:
1951         * Storage/WebDatabaseManagerClient.mm:
1952         * Storage/WebDatabaseManagerInternal.h:
1953         * Storage/WebDatabaseManagerPrivate.h:
1954         * Storage/WebDatabaseQuotaManager.mm:
1955         (-[WebDatabaseQuotaManager usage]):
1956         (-[WebDatabaseQuotaManager quota]):
1957         (-[WebDatabaseQuotaManager setQuota:]):
1958         * WebCoreSupport/WebChromeClient.h:
1959         * WebCoreSupport/WebChromeClient.mm:
1960         * WebCoreSupport/WebSecurityOrigin.mm:
1961         (-[WebSecurityOrigin usage]):
1962         (-[WebSecurityOrigin quota]):
1963         (-[WebSecurityOrigin setQuota:]):
1964         * WebView/WebFrame.mm:
1965         (-[WebFrame _cacheabilityDictionary]):
1966         * WebView/WebView.mm:
1967         (-[WebView _commonInitializationWithFrameName:groupName:]):
1968         (-[WebView _preferencesChanged:]):
1969
1970 2015-01-14  Chris Dumez  <cdumez@apple.com>
1971
1972         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
1973         https://bugs.webkit.org/show_bug.cgi?id=140347
1974
1975         Reviewed by Darin Adler.
1976
1977         Call FontDescription::setIsItalic() instead of setItalic() as the
1978         call site passes a boolean.
1979
1980         * WebView/WebHTMLView.mm:
1981         (fontNameForDescription):
1982
1983 2015-01-13  Anders Carlsson  <andersca@apple.com>
1984
1985         Temporarily reintroduce the informal delegate protocols
1986         https://bugs.webkit.org/show_bug.cgi?id=140416
1987
1988         Reviewed by Dan Bernstein.
1989
1990         * WebView/WebEditingDelegate.h:
1991         * WebView/WebFrameLoadDelegate.h:
1992         * WebView/WebPolicyDelegate.h:
1993         * WebView/WebResourceLoadDelegate.h:
1994         * WebView/WebUIDelegate.h:
1995
1996 2015-01-13  Beth Dakin  <bdakin@apple.com>
1997
1998         Should disable immediate actions for iTunes
1999         https://bugs.webkit.org/show_bug.cgi?id=140405
2000         -and corresponding-
2001         rdar://problem/19461358
2002
2003         Reviewed by Tim Horton.
2004
2005         * WebView/WebImmediateActionController.mm:
2006         (-[WebImmediateActionController _updateImmediateActionItem]):
2007
2008 2015-01-11  Sam Weinig  <sam@webkit.org>
2009
2010         Remove support for SharedWorkers
2011         https://bugs.webkit.org/show_bug.cgi?id=140344
2012
2013         Reviewed by Anders Carlsson.
2014
2015         * Configurations/FeatureDefines.xcconfig:
2016         * WebCoreSupport/WebPlatformStrategies.h:
2017         * WebCoreSupport/WebPlatformStrategies.mm:
2018         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
2019
2020 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
2021
2022         Get rid of unnecessary reimplementations of CGFloor/Ceiling
2023         https://bugs.webkit.org/show_bug.cgi?id=140375
2024
2025         Reviewed by Simon Fraser.
2026
2027         * Misc/WebKitNSStringExtras.mm:
2028         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2029         (webkit_CGCeiling): Deleted.
2030         Delete unnecessary code, use the real CGFloor/Ceiling instead.
2031
2032 2015-01-12  Anders Carlsson  <andersca@apple.com>
2033
2034         Make delegates conform to formal delegate protocols
2035         https://bugs.webkit.org/show_bug.cgi?id=140370
2036
2037         Reviewed by Dan Bernstein.
2038
2039         * DefaultDelegates/WebDefaultPolicyDelegate.h:
2040         * WebCoreSupport/WebInspectorClient.mm:
2041         Add protocols to the interface declarations.
2042
2043         * WebView/WebActionMenuController.mm:
2044         (-[WebActionMenuController prepareForMenu:withEvent:]):
2045         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2046         * WebView/WebImmediateActionController.mm:
2047         (-[WebImmediateActionController _updateImmediateActionItem]):
2048         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2049         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
2050
2051 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
2052
2053         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
2054         https://bugs.webkit.org/show_bug.cgi?id=136769
2055
2056         Reviewed by Antti Koivisto.
2057
2058         * Configurations/FeatureDefines.xcconfig:
2059
2060 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
2061
2062         Multi-rect TextIndicators are vertically flipped in WebKit1
2063         https://bugs.webkit.org/show_bug.cgi?id=140350
2064         <rdar://problem/19441243>
2065
2066         Reviewed by Beth Dakin.
2067
2068         * WebView/WebView.mm:
2069         (-[WebView _setTextIndicator:fadeOut:]):
2070         Convert the textBoundingRect from root view to screen coordinates.
2071
2072 2015-01-12  Anders Carlsson  <andersca@apple.com>
2073
2074         Make WebResourceDelegate a formal protocol as well
2075         https://bugs.webkit.org/show_bug.cgi?id=140364
2076
2077         Reviewed by Dan Bernstein.
2078
2079         * WebView/WebResourceLoadDelegate.h:
2080
2081 2015-01-12  Anders Carlsson  <andersca@apple.com>
2082
2083         Delegates should be formal protocols
2084         https://bugs.webkit.org/show_bug.cgi?id=140360
2085         rdar://problem/17380856
2086
2087         Reviewed by Dan Bernstein.
2088
2089         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
2090
2091         * DefaultDelegates/WebDefaultUIDelegate.h:
2092         * Misc/WebDownload.h:
2093         * WebView/WebEditingDelegate.h:
2094         * WebView/WebFrameLoadDelegate.h:
2095         * WebView/WebPolicyDelegate.h:
2096         * WebView/WebUIDelegate.h:
2097
2098 2015-01-09  Anders Carlsson  <andersca@apple.com>
2099
2100         Get rid of the database strategy
2101         https://bugs.webkit.org/show_bug.cgi?id=140322
2102
2103         Reviewed by Sam Weinig.
2104
2105         * WebCoreSupport/WebPlatformStrategies.h:
2106         * WebCoreSupport/WebPlatformStrategies.mm:
2107         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
2108
2109 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
2110
2111         Can't use DataDetectors after immediate action preparation
2112         https://bugs.webkit.org/show_bug.cgi?id=140263
2113         <rdar://problem/19412705>
2114
2115         Reviewed by Beth Dakin.
2116
2117         * WebView/WebImmediateActionController.mm:
2118         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2119         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2120         To match WebKit2, only call shouldUseActions if the animation is actually
2121         going to begin, not when preparing for it. This way, we're guaranteed
2122         to get a didCancel or didComplete.
2123
2124 2015-01-08  Dean Jackson  <dino@apple.com>
2125
2126         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
2127         https://bugs.webkit.org/show_bug.cgi?id=140232
2128         <rdar://problem/19371010>
2129
2130         Reviewed by Anders Carlsson.
2131
2132         Remove the applicationChromeMode setting, but leave stubs in to make
2133         sure existing binaries don't break.
2134
2135         * WebCoreSupport/WebInspectorClient.mm:
2136         (-[WebInspectorWindowController init]):
2137         * WebView/WebPreferenceKeysPrivate.h:
2138         * WebView/WebPreferences.mm:
2139         (+[WebPreferences initialize]):
2140         (-[WebPreferences applicationChromeModeEnabled]):
2141         (-[WebPreferences setApplicationChromeModeEnabled:]):
2142         * WebView/WebView.mm:
2143         (-[WebView _preferencesChanged:]):
2144
2145 2015-01-07  Daniel Bates  <dabates@apple.com>
2146
2147         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2148         https://bugs.webkit.org/show_bug.cgi?id=137371
2149
2150         Reviewed by David Kilzer.
2151
2152         Use SPI wrapper headers instead of directly references private SPI headers.
2153
2154         * Plugins/Hosted/NetscapePluginHostManager.mm:
2155
2156 2015-01-07  Commit Queue  <commit-queue@webkit.org>
2157
2158         Unreviewed, rolling out r178068.
2159         https://bugs.webkit.org/show_bug.cgi?id=140235
2160
2161         Breaks the iOS build (Requested by enrica on #webkit).
2162
2163         Reverted changeset:
2164
2165         "[iOS] Make WebKit2 build with public iOS SDK and more build
2166         fixes for DRT"
2167         https://bugs.webkit.org/show_bug.cgi?id=137371
2168         http://trac.webkit.org/changeset/178068
2169
2170 2015-01-07  Daniel Bates  <dabates@apple.com>
2171
2172         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2173         https://bugs.webkit.org/show_bug.cgi?id=137371
2174
2175         Reviewed by David Kilzer.
2176
2177         Use SPI wrapper headers instead of directly references private SPI headers.
2178
2179         * Plugins/Hosted/NetscapePluginHostManager.mm:
2180
2181 2015-01-07  Beth Dakin  <bdakin@apple.com>
2182
2183         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
2184         link
2185         https://bugs.webkit.org/show_bug.cgi?id=140206
2186         -and corresponding-
2187         rdar://problem/19300492
2188
2189         Reviewed by Tim Horton.
2190
2191         Providing and item frame will ensure that the original link is not obscured.
2192         * WebView/WebImmediateActionController.mm:
2193         (elementBoundingBoxInWindowCoordinatesFromNode):
2194         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
2195
2196         For now use a max size that is smaller than the WebView, with the screen’s aspect 
2197         ratio, and scaled down.
2198         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
2199
2200 2015-01-07  Anders Carlsson  <andersca@apple.com>
2201
2202         Give simple HTML documents a database provider
2203         https://bugs.webkit.org/show_bug.cgi?id=140192
2204         rdar://problem/19398825
2205
2206         Reviewed by Tim Horton.
2207
2208         * WebView/WebView.mm:
2209         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2210
2211 2015-01-06  Anders Carlsson  <andersca@apple.com>
2212
2213         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
2214         https://bugs.webkit.org/show_bug.cgi?id=140140
2215
2216         Reviewed by Andreas Kling.
2217
2218         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
2219         out of WebCore since nobody else is using it.
2220
2221         * Plugins/WebNetscapePluginView.h:
2222         * Plugins/WebNetscapePluginView.mm:
2223         (-[WebNetscapePluginView _createPlugin]):
2224         (-[WebNetscapePluginView _destroyPlugin]):
2225         * Plugins/npapi.mm:
2226         (NPN_PluginThreadAsyncCall):
2227
2228 2015-01-06  Anders Carlsson  <andersca@apple.com>
2229
2230         Add a WebKit1 database provider
2231         https://bugs.webkit.org/show_bug.cgi?id=140126
2232
2233         Reviewed by Sam Weinig.
2234
2235         Set the database provider.
2236
2237         * WebView/WebView.mm:
2238         (-[WebView _commonInitializationWithFrameName:groupName:]):
2239
2240 2015-01-06  Commit Queue  <commit-queue@webkit.org>
2241
2242         Unreviewed, rolling out r177963.
2243         https://bugs.webkit.org/show_bug.cgi?id=140136
2244
2245         Caused lots of crashes (Requested by smfr on #webkit).
2246
2247         Reverted changeset:
2248
2249         "Add a WebKit1 database provider"
2250         https://bugs.webkit.org/show_bug.cgi?id=140126
2251         http://trac.webkit.org/changeset/177963
2252
2253 2015-01-06  Anders Carlsson  <andersca@apple.com>
2254
2255         Add a WebKit1 database provider
2256         https://bugs.webkit.org/show_bug.cgi?id=140126
2257
2258         Reviewed by Sam Weinig.
2259
2260         Set the database provider.
2261
2262         * WebView/WebView.mm:
2263         (-[WebView _commonInitializationWithFrameName:groupName:]):
2264
2265 2015-01-01  Jeff Miller  <jeffm@apple.com>
2266
2267         Update user-visible copyright strings to include 2015
2268         https://bugs.webkit.org/show_bug.cgi?id=139880
2269
2270         Reviewed by Darin Adler.
2271
2272         * Info.plist:
2273
2274 2014-12-30  Dan Bernstein  <mitz@apple.com>
2275
2276         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
2277         https://bugs.webkit.org/show_bug.cgi?id=140003
2278
2279         Reviewed by Darin Adler.
2280
2281         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
2282         that takes their "string" parameter as a "value" "parameter and has an attribute telling
2283         the compiler that if the "value" parameter is a format string then the function returns a
2284         modified version of it. The result is that if UI_STRING is used as a format string parameter
2285         to some function or method, the compiler will check the format specifiers in the string
2286         against the other parameters.
2287
2288 2014-12-29  Dan Bernstein  <mitz@apple.com>
2289
2290         Fixed the iOS build.
2291
2292         * Configurations/WebKitLegacy.xcconfig:
2293
2294 2014-12-29  Anders Carlsson  <andersca@apple.com>
2295
2296         Get rid of some PageGroup storage functions
2297         https://bugs.webkit.org/show_bug.cgi?id=139996
2298
2299         Reviewed by Sam Weinig.
2300
2301         Call WebStorageNamespaceProvider directly instead.
2302
2303         * Storage/WebStorageManager.mm:
2304         (-[WebStorageManager syncLocalStorage]):
2305         (+[WebStorageManager closeIdleLocalStorageDatabases]):
2306         * WebView/WebView.mm:
2307         (+[WebView _applicationWillTerminate]):
2308
2309 2014-12-29  Anders Carlsson  <andersca@apple.com>
2310
2311         Move storage code from WebCore to WebKit
2312         https://bugs.webkit.org/show_bug.cgi?id=139558
2313
2314         Reviewed by Darin Adler.
2315
2316         * Storage/WebStorageManager.mm:
2317         * Storage/WebStorageTrackerClient.h:
2318         * WebView/WebView.mm:
2319
2320 2014-12-26  Dan Bernstein  <mitz@apple.com>
2321
2322         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
2323         https://bugs.webkit.org/show_bug.cgi?id=139950
2324
2325         Reviewed by David Kilzer.
2326
2327         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
2328         in a manner that works with Xcode 5.1.1.
2329
2330 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
2331
2332         Install a TextIndicator for link immediate actions
2333         https://bugs.webkit.org/show_bug.cgi?id=139897
2334         <rdar://problem/19333076>
2335
2336         Reviewed by Anders Carlsson.
2337
2338         * WebView/WebImmediateActionController.h:
2339         * WebView/WebImmediateActionController.mm:
2340         (-[WebImmediateActionController _clearImmediateActionState]):
2341         Tear down the TextIndicator, just like WebKit2.
2342
2343         (-[WebImmediateActionController _defaultAnimationController]):
2344         Install a TextIndicator for links.
2345
2346         (-[WebImmediateActionController menuItemDidClose:]):
2347         Tear down the TextIndicator when the QL preview closes.
2348
2349         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2350         Directly install and uninstall the TextIndicator for DataDetectors.
2351
2352         (-[WebImmediateActionController _showTextIndicator]): Deleted.
2353         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
2354         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
2355
2356 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
2357
2358         [iOS] add optimized fullscreen API
2359         https://bugs.webkit.org/show_bug.cgi?id=139833
2360         <rdar://problem/18844486>
2361
2362         Reviewed by Simon Fraser.
2363
2364         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
2365
2366 2014-12-20  David Kilzer  <ddkilzer@apple.com>
2367
2368         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2369         <http://webkit.org/b/139463>
2370
2371         Reviewed by Mark Rowe.
2372
2373         * Configurations/Base.xcconfig:
2374         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2375           on OS X.
2376         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2377         * Configurations/DebugRelease.xcconfig:
2378         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2379         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2380         * Configurations/Version.xcconfig:
2381         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2382         * Configurations/WebKitLegacy.xcconfig:
2383         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2384           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2385           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2386           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2387           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2388           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2389           WEBCORE_PRIVATE_HEADERS_DIR_Production and
2390           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2391           based on SDK.
2392         - Fix PRODUCTION_ROOT to actually be set properly.
2393         - Simplify EXPORTED_SYMBOLS_FILE_i386.
2394
2395         * migrate-headers.sh:
2396         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2397         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
2398           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
2399           WebKitLegacy.xcconfig.
2400
2401 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
2402
2403         Fix pink background on CoreAnimation plug-ins in WebKit1
2404         https://bugs.webkit.org/show_bug.cgi?id=139845
2405         rdar://problem/19313075
2406
2407         Reviewed by Tim Horton.
2408         
2409         r154078 left in some debugging code that set a pink background on plug-in hosting
2410         layers. Remove it.
2411
2412         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2413         (-[WebHostedNetscapePluginView createPluginLayer]):
2414
2415 2014-12-19  Andreas Kling  <akling@apple.com>
2416
2417         Ref-ify TextIterator API.
2418         <https://webkit.org/b/139823>
2419
2420         Reviewed by Antti Koivisto.
2421
2422         * WebView/WebTextIterator.mm:
2423         (-[WebTextIterator currentRange]):
2424
2425 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
2426
2427         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
2428         https://bugs.webkit.org/show_bug.cgi?id=139797
2429
2430         Reviewed by Mark Lam.
2431
2432         * WebView/WebScriptDebugger.h:
2433         * WebView/WebScriptDebugger.mm:
2434         (WebScriptDebugger::handlePause):
2435         Standardize on passing JSGlobalObject parameter first.
2436
2437 2014-12-19  Commit Queue  <commit-queue@webkit.org>
2438
2439         Unreviewed, rolling out r177574.
2440         https://bugs.webkit.org/show_bug.cgi?id=139821
2441
2442         "Broke Production builds by installing
2443         libWebCoreTestSupport.dylib in the wrong directory" (Requested
2444         by ddkilzer on #webkit).
2445
2446         Reverted changeset:
2447
2448         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
2449         WebInspectorUI, WebKit, WebKit2"
2450         https://bugs.webkit.org/show_bug.cgi?id=139463
2451         http://trac.webkit.org/changeset/177574
2452
2453 2014-12-19  David Kilzer  <ddkilzer@apple.com>
2454
2455         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2456         <http://webkit.org/b/139463>
2457
2458         Reviewed by Mark Rowe.
2459
2460         * Configurations/Base.xcconfig:
2461         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2462           on OS X.
2463         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2464         * Configurations/DebugRelease.xcconfig:
2465         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2466         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2467         * Configurations/Version.xcconfig:
2468         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2469         * Configurations/WebKitLegacy.xcconfig:
2470         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2471           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2472           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2473           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2474           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2475           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2476           WEBCORE_PRIVATE_HEADERS_DIR_Production and
2477           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2478           based on SDK.
2479         - Fix PRODUCTION_ROOT to actually be set properly.
2480         - Simplify EXPORTED_SYMBOLS_FILE_i386.
2481
2482         * migrate-headers.sh:
2483         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2484         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
2485           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
2486           WebKitLegacy.xcconfig.
2487
2488 2014-12-18  Andreas Kling  <akling@apple.com>
2489
2490         Ref-ify various Document-related things.
2491         <https://webkit.org/b/139796>
2492
2493         Reviewed by Anders Carlsson.
2494
2495         * WebView/WebFrame.mm:
2496         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
2497
2498 2014-12-18  Beth Dakin  <bdakin@apple.com>
2499
2500         Need to re-enable action menus
2501         https://bugs.webkit.org/show_bug.cgi?id=139795
2502         -and corresponding-
2503         rdar://problem/19299367
2504
2505         Reviewed by Tim Horton.
2506
2507         Re-enable the menus by un-commenting the code to create the menu and controller.
2508         * WebView/WebView.mm:
2509         (-[WebView _commonInitializationWithFrameName:groupName:]):
2510
2511 2014-12-16  Sam Weinig  <sam@webkit.org>
2512
2513         Unify the Mac and iOS implementations of FontPlatformData a bit
2514         https://bugs.webkit.org/show_bug.cgi?id=139721
2515
2516         Reviewed by Anders Carlsson.
2517
2518         * WebView/WebHTMLView.mm:
2519         (fontNameForDescription):
2520         Update for new function name.
2521
2522 2014-12-18  Antti Koivisto  <antti@apple.com>
2523
2524         Remove alwaysUseBaselineOfPrimaryFont setting
2525         https://bugs.webkit.org/show_bug.cgi?id=139770
2526
2527         Reviewed by Anders Carlsson.
2528
2529         * WebView/WebPreferenceKeysPrivate.h:
2530         * WebView/WebPreferences.mm:
2531         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
2532         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
2533         * WebView/WebPreferencesPrivate.h:
2534         * WebView/WebView.mm:
2535         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2536         (-[WebView _preferencesChanged:]):
2537
2538 2014-12-17  Andreas Kling  <akling@apple.com>
2539
2540         Ref-ify Range::create().
2541         <https://webkit.org/b/139755>
2542
2543         Reviewed by Anders Carlsson.
2544
2545         * WebView/WebHTMLRepresentation.mm:
2546         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2547         * WebView/WebHTMLView.mm:
2548         (-[WebHTMLView attributedString]):
2549
2550 2014-12-17  Anders Carlsson  <andersca@apple.com>
2551
2552         Unify -[WebResource description]
2553         https://bugs.webkit.org/show_bug.cgi?id=139762
2554
2555         Reviewed by Dan Bernstein.
2556
2557         * WebView/WebResource.mm:
2558         (-[WebResource description]):
2559
2560 2014-12-17  Anders Carlsson  <andersca@apple.com>
2561
2562         Get rid of an ugly #define hack in WebFrameLoaderClient
2563         https://bugs.webkit.org/show_bug.cgi?id=139761
2564
2565         Reviewed by Dan Bernstein.
2566
2567         Also replace @private with @package in all public headers, for consistency.
2568
2569         * History/WebBackForwardList.h:
2570         * History/WebHistory.h:
2571         * Misc/WebDownload.h:
2572         * WebCoreSupport/WebFrameLoaderClient.mm:
2573         * WebView/WebArchive.h:
2574         * WebView/WebDataSource.h:
2575         * WebView/WebFrame.h:
2576         * WebView/WebFrameView.h:
2577         * WebView/WebPreferences.h:
2578         * WebView/WebResource.h:
2579
2580 2014-12-17  Dan Bernstein  <mitz@apple.com>
2581
2582         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
2583         https://bugs.webkit.org/show_bug.cgi?id=139760
2584
2585         Reviewed by Anders Carlsson.
2586
2587         * Configurations/WebKitLegacy.xcconfig:
2588
2589 2014-12-17  Andreas Kling  <akling@apple.com>
2590
2591         Purge PassRefPtr from Frame.
2592         <https://webkit.org/b/139731>
2593
2594         Reviewed by Anders Carlsson.
2595
2596         * WebCoreSupport/WebFrameLoaderClient.mm:
2597         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2598         * WebView/WebFrame.mm:
2599         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
2600         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
2601         * WebView/WebFrameInternal.h:
2602
2603 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
2604
2605         Implement and adopt two new TextIndicator presentation animations
2606         https://bugs.webkit.org/show_bug.cgi?id=139715
2607         <rdar://problem/19237945>
2608
2609         Reviewed by Anders Carlsson.
2610
2611         * WebView/WebActionMenuController.mm:
2612         (-[WebActionMenuController _showTextIndicator]):
2613         * WebView/WebHTMLView.mm:
2614         (-[WebHTMLView quickLookWithEvent:]):
2615         Remove the completionHandler from text indicator presentation.
2616
2617         * WebView/WebImmediateActionController.mm:
2618         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2619         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
2620         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2621         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2622         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2623         (-[WebImmediateActionController _animationControllerForText]):
2624         (-[WebImmediateActionController _showTextIndicator]):
2625         Forward immediate action gesture recognizer animation progress
2626         to TextIndicator. Force us to keep the selection when immediate
2627         action popovers steal first responder status from the WebView.
2628         If the Lookup range is equal to the selection range, use a Crossfade
2629         animation; otherwise, use a FadeIn animation.
2630
2631         * WebView/WebView.mm:
2632         (-[WebView _setMaintainsInactiveSelection:]):
2633         (-[WebView maintainsInactiveSelection]):
2634         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2635         (-[WebView _setTextIndicator:fadeOut:]):
2636         (-[WebView _clearTextIndicator]):
2637         (-[WebView _setTextIndicatorAnimationProgress:]):
2638         (-[WebView _showDictionaryLookupPopup:]):
2639         (-[WebView _dictionaryLookupPopoverWillClose:]):
2640         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2641         Remove the completionHandler from text indicator presentation.
2642         Add a _setMaintainsInactiveSelection, which allows WebKit internals
2643         to change the return value of -maintainsInactiveSelection, allowing
2644         us to keep the selection alive when the WebView loses first responder status.
2645
2646         * WebView/WebViewData.h:
2647         * WebView/WebViewInternal.h:
2648
2649 2014-12-16  Andreas Kling  <akling@apple.com>
2650
2651         Use Ref for SecurityOrigin.
2652         <https://webkit.org/b/139710>
2653
2654         Reviewed by Anders Carlsson.
2655
2656         * Storage/WebStorageTrackerClient.mm:
2657         (WebStorageTrackerClient::dispatchDidModifyOrigin):
2658         * WebView/WebView.mm:
2659         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
2660         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
2661
2662 2014-12-16  Beth Dakin  <bdakin@apple.com>
2663
2664         Crash getting default animation controller for some text
2665         https://bugs.webkit.org/show_bug.cgi?id=139712
2666         -and corresponding-
2667         rdar://problem/19271707
2668
2669         Reviewed by Tim Horton.
2670
2671         Must null-check the range.
2672         * WebView/WebImmediateActionController.mm:
2673         (-[WebImmediateActionController _animationControllerForText]):
2674
2675 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
2676
2677         Immediate action popovers can get stuck open
2678         https://bugs.webkit.org/show_bug.cgi?id=139709
2679         <rdar://problem/19270279>
2680
2681         Reviewed by Beth Dakin.
2682
2683         * WebView/WebImmediateActionController.mm:
2684         (-[WebImmediateActionController _clearImmediateActionState]):
2685         Don't clear the animation controller; it breaks things and was unnecessary.
2686
2687 2014-12-16  Tim Horton  <timothy_horton@apple.com>
2688
2689         Disable TextIndication for Lookup immediate actions
2690         https://bugs.webkit.org/show_bug.cgi?id=139684
2691
2692         Reviewed by Anders Carlsson.
2693
2694         * WebView/WebView.mm:
2695         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2696
2697 2014-12-15  Beth Dakin  <bdakin@apple.com>
2698
2699         Build fix.
2700
2701         * WebView/WebImmediateActionController.mm:
2702
2703 2014-12-15  Beth Dakin  <bdakin@apple.com>
2704
2705         Speculative build fix.
2706
2707         * WebView/WebView.mm:
2708         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2709         * WebView/WebViewInternal.h:
2710
2711 2014-12-15  Beth Dakin  <bdakin@apple.com>
2712
2713         Make lookup an immediate action instead of an action menu item
2714         https://bugs.webkit.org/show_bug.cgi?id=139661
2715         -and corresponding-
2716         rdar://problem/19198414
2717
2718         Reviewed by Tim Horton.
2719
2720         Remove the lookup menu items and non-unused static function associated with 
2721         lookup.
2722         * WebView/WebActionMenuController.mm:
2723         (-[WebActionMenuController _defaultMenuItemsForText]):
2724         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2725         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2726         (-[WebActionMenuController _createActionMenuItemForTag:]):
2727         (-[WebActionMenuController _lookupText:]): Deleted.
2728         (performDictionaryLookupForSelection): Deleted.
2729         (performDictionaryLookupForRange): Deleted.
2730
2731         Set the defaultAnimationController to the lookup-provided animation controller 
2732         when appropriate.
2733         * WebView/WebImmediateActionController.mm:
2734         (-[WebImmediateActionController _defaultAnimationController]):
2735         (dictionaryPopupInfoForRange):
2736         (-[WebImmediateActionController _animationControllerForText]):
2737
2738         New type.
2739         * WebView/WebUIDelegatePrivate.h:
2740
2741         New function to get the lookup animation controller.
2742         * WebView/WebView.mm:
2743         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2744         * WebView/WebViewInternal.h:
2745
2746 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2747
2748         Implement Data Detectors immediate actions for Legacy WebKit
2749         https://bugs.webkit.org/show_bug.cgi?id=139619
2750         <rdar://problem/19198539>
2751
2752         Reviewed by Beth Dakin.
2753
2754         * WebView/WebImmediateActionController.mm:
2755         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2756         Note that this action context is only for immediate actions.
2757
2758 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
2759
2760         Addressing post-review comments in r177035
2761         https://bugs.webkit.org/show_bug.cgi?id=139557
2762
2763         Reviewed by Darin Adler.
2764
2765         * WebView/WebActionMenuController.mm:
2766         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
2767
2768 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2769
2770         Implement Data Detectors immediate actions for Legacy WebKit
2771         https://bugs.webkit.org/show_bug.cgi?id=139619
2772         <rdar://problem/19198539>
2773
2774         Reviewed by Eric Carlson.
2775
2776         * WebView/WebHTMLView.mm:
2777         (-[WebHTMLView mouseDown:mouseDown:]):
2778         Send mouseDown along to the WebImmediateActionController too.
2779
2780         * WebView/WebImmediateActionController.h:
2781         * WebView/WebImmediateActionController.mm:
2782         (-[WebImmediateActionController webViewClosed]):
2783         (-[WebImmediateActionController webView:willHandleMouseDown:]):
2784         (-[WebImmediateActionController _cancelImmediateAction]):
2785         (-[WebImmediateActionController _clearImmediateActionState]):
2786         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2787         (-[WebImmediateActionController _defaultAnimationController]):
2788         (-[WebImmediateActionController _updateImmediateActionItem]):
2789         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2790         (-[WebImmediateActionController _showTextIndicator]):
2791         (-[WebImmediateActionController _hideTextIndicator]):
2792         Copy most of the DataDetectors implementation into WebImmediateActionController.
2793
2794         * WebView/WebUIDelegatePrivate.h:
2795         Add a new type.
2796
2797         * WebView/WebView.mm:
2798         (-[WebView _commonInitializationWithFrameName:groupName:]):
2799         Temporarily disable action menus.
2800
2801         (-[WebView _immediateActionController]):
2802         * WebView/WebViewInternal.h:
2803
2804 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
2805
2806         Delete Notation because we don't use it
2807         https://bugs.webkit.org/show_bug.cgi?id=139171
2808
2809         Reviewed by Kent Tamura.
2810
2811         * MigrateHeaders.make:
2812
2813 2014-12-14  Andreas Kling  <akling@apple.com>
2814
2815         Replace PassRef with Ref/Ref&& across the board.
2816         <https://webkit.org/b/139587>
2817
2818         Reviewed by Darin Adler.
2819
2820         * WebCoreSupport/WebEditorClient.mm:
2821         (WebEditorClient::shouldApplyStyle):
2822         * WebCoreSupport/WebVisitedLinkStore.h:
2823         * WebCoreSupport/WebVisitedLinkStore.mm:
2824         (WebVisitedLinkStore::create):
2825
2826 2014-12-11  Dan Bernstein  <mitz@apple.com>
2827
2828         Fix a leak introduced in r177199.
2829
2830         Reviewed by Anders Carlsson.
2831
2832         * WebView/WebImmediateActionController.mm:
2833         (-[WebImmediateActionController _updateImmediateActionItem]):
2834
2835 2014-12-11  Beth Dakin  <bdakin@apple.com>
2836
2837         WK1: Need new SPI for Webkit clients to override default immediate action
2838         https://bugs.webkit.org/show_bug.cgi?id=139568
2839         -and corresponding-
2840         rdar://problem/19225448
2841
2842         Reviewed by Dan Bernstein.
2843
2844         Call SPI giving clients a chance to override the default behavior.
2845         * WebView/WebImmediateActionController.mm:
2846         (-[WebImmediateActionController _updateImmediateActionItem]):
2847
2848         New SPI.
2849         * WebView/WebUIDelegatePrivate.h:
2850
2851 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
2852
2853         Move the preview popover to WebImmediateActionController
2854         https://bugs.webkit.org/show_bug.cgi?id=139563
2855         <rdar://problem/19208291>
2856
2857         Reviewed by Beth Dakin.
2858
2859         * WebView/WebActionMenuController.mm:
2860         (-[WebActionMenuController _defaultMenuItemsForLink]):
2861         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
2862         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
2863         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
2864         * WebView/WebImmediateActionController.h:
2865         * WebView/WebImmediateActionController.mm:
2866         (-[WebImmediateActionController webViewClosed]):
2867         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2868         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2869         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2870         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2871         (-[WebImmediateActionController _updateImmediateActionItem]):
2872         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
2873         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
2874         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
2875         Move page preview popover related code to WebImmediateActionController.
2876
2877         * WebView/WebUIDelegatePrivate.h:
2878         Add a link preview type.
2879
2880         * WebView/WebView.mm:
2881         (-[WebView _commonInitializationWithFrameName:groupName:]):
2882         Pass the gesture recognizer to the WebImmediateActionController.
2883
2884 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
2885
2886         Fix the build.
2887
2888         * WebView/WebImmediateActionController.h:
2889         * WebView/WebImmediateActionController.mm:
2890
2891 2014-12-11  Anders Carlsson  <andersca@apple.com>
2892
2893         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
2894         https://bugs.webkit.org/show_bug.cgi?id=139547
2895
2896         Reviewed by Sam Weinig.
2897
2898         * WebView/WebView.mm:
2899         (+[WebView _handleMemoryWarning]):
2900
2901 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
2902
2903         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
2904         https://bugs.webkit.org/show_bug.cgi?id=139504
2905         rdar://problem/19034674
2906
2907         Reviewed by Enrica Casucci.
2908
2909         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
2910
2911         * WebCoreSupport/WebEditorClient.h:
2912         * WebCoreSupport/WebEditorClient.mm:
2913         (WebEditorClient::discardedComposition):
2914
2915 2014-12-10  Anders Carlsson  <andersca@apple.com>
2916
2917         Get rid of the storage strategy
2918         https://bugs.webkit.org/show_bug.cgi?id=139519
2919
2920         Reviewed by Antti Koivisto.
2921
2922         * WebCoreSupport/WebPlatformStrategies.h:
2923         * WebCoreSupport/WebPlatformStrategies.mm:
2924         (WebPlatformStrategies::createStorageStrategy): Deleted.
2925
2926 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2927
2928         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
2929         https://bugs.webkit.org/show_bug.cgi?id=139529
2930         <rdar://problem/19213620>
2931
2932         Reviewed by Beth Dakin.
2933
2934         * WebView/WebActionMenuController.mm:
2935         (-[WebActionMenuController _copySelection:]):
2936         (-[WebActionMenuController _paste:]):
2937         Use the copy: and paste: methods on WebView so that we traverse subviews
2938         when trying to respond, otherwise these actions don't work in subframes.
2939
2940 2014-12-10  Beth Dakin  <bdakin@apple.com>
2941
2942         WK1: Add initial support for immediate actions
2943         https://bugs.webkit.org/show_bug.cgi?id=139522
2944
2945         Reviewed by Dan Bernstein.
2946
2947         This basic implementation of the controller will use the delegate methods to 
2948         perform and cache a HitTest when relevant. Future patches will patch 
2949         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
2950         immediate action that should be taken.
2951         * WebView/WebImmediateActionController.h: Added.
2952         * WebView/WebImmediateActionController.mm: Added.
2953         (-[WebImmediateActionController webViewClosed]):
2954         (-[WebImmediateActionController _clearImmediateActionState]):
2955         (-[WebImmediateActionController performHitTestAtPoint:]):
2956         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2957         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2958         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
2959         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
2960         (-[WebImmediateActionController _updateImmediateActionItem]):
2961
2962         New enum for immediate action types.
2963         * WebView/WebUIDelegatePrivate.h:
2964
2965         Create an NSImmediateActionGestureRecognizer if possible and a controller.
2966         * WebView/WebView.mm:
2967         (-[WebView _commonInitializationWithFrameName:groupName:]):
2968         (-[WebView _close]):
2969         * WebView/WebViewData.h:
2970         * WebView/WebViewData.mm:
2971         (-[WebViewPrivate dealloc]):
2972
2973 2014-12-08  Anders Carlsson  <andersca@apple.com>
2974
2975         Use the new storage namespace provider in WebKit1
2976         https://bugs.webkit.org/show_bug.cgi?id=139425
2977
2978         Reviewed by Tim Horton.
2979
2980         * WebView/WebView.mm:
2981         (-[WebView _commonInitializationWithFrameName:groupName:]):
2982         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2983         Set the storage namespace provider from the web page group.
2984
2985 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
2986
2987         Should have copy and paste items in all text menus
2988         https://bugs.webkit.org/show_bug.cgi?id=139510
2989         <rdar://problem/19198388>
2990
2991         Reviewed by Beth Dakin.
2992
2993         * WebView/WebActionMenuController.mm:
2994         (-[WebActionMenuController _defaultMenuItemsForText]):
2995         Add a disabled paste menu item into the read-only text menu.
2996
2997         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2998         Add a disabled copy menu item into the editable whitespace text menu.
2999
3000 2014-12-10  Anders Carlsson  <andersca@apple.com>
3001
3002         Add WebStorageNamespaceProvider::closeLocalStorage
3003         https://bugs.webkit.org/show_bug.cgi?id=139502
3004
3005         Reviewed by Tim Horton.
3006
3007         * WebView/WebView.mm:
3008         (+[WebView _applicationWillTerminate]):
3009         Call WebStorageNamespaceProvider::closeLocalStorage.
3010
3011 2014-12-09  Commit Queue  <commit-queue@webkit.org>
3012
3013         Unreviewed, rolling out r177037.
3014         https://bugs.webkit.org/show_bug.cgi?id=139464
3015
3016         broke ~50 API tests (Requested by thorton on #webkit).
3017
3018         Reverted changeset:
3019
3020         "Use the new storage namespace provider in WebKit1"
3021         https://bugs.webkit.org/show_bug.cgi?id=139425
3022         http://trac.webkit.org/changeset/177037
3023
3024 2014-12-08  Anders Carlsson  <andersca@apple.com>
3025
3026         Use the new storage namespace provider in WebKit1
3027         https://bugs.webkit.org/show_bug.cgi?id=139425
3028
3029         Reviewed by Tim Horton.
3030
3031         * WebView/WebView.mm:
3032         (-[WebView _commonInitializationWithFrameName:groupName:]):
3033         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3034         Set the storage namespace provider from the web page group.
3035
3036 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
3037
3038         Delete Node::boundingBox()
3039         https://bugs.webkit.org/show_bug.cgi?id=139333
3040
3041         Reviewed by Zalan Bujtas.
3042
3043         * WebView/WebActionMenuController.mm:
3044         (elementBoundingBoxInWindowCoordinatesFromNode): Use
3045         RenderObject::absoluteBoundingBoxRect().
3046
3047 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
3048
3049         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
3050         https://bugs.webkit.org/show_bug.cgi?id=138843
3051         rdar://problem/18793695
3052
3053         Reviewed by Dan Bernstein.
3054
3055         * Panels/WebAuthenticationPanel.m:
3056         (-[WebAuthenticationPanel cancel:]):
3057         (-[WebAuthenticationPanel logIn:]):
3058         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
3059         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
3060         that only when using an old NSWindow API.
3061
3062 2014-12-08  Beth Dakin  <bdakin@apple.com>
3063
3064         Copy and Lookup menu items should be disabled when something is not copyable
3065         https://bugs.webkit.org/show_bug.cgi?id=139423
3066
3067         Reviewed by Tim Horton.
3068
3069         Disable both lookup and copy when a HitTestResult does not allow copy.
3070         * WebView/WebActionMenuController.mm:
3071
3072         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
3073         disable state otherwise.
3074         * WebView/WebView.mm:
3075         (-[WebView _commonInitializationWithFrameName:groupName:]):
3076
3077 2014-12-08  Anders Carlsson  <andersca@apple.com>
3078
3079         Adding user content to a group should force that group to be created
3080         https://bugs.webkit.org/show_bug.cgi?id=139421
3081         rdar://problem/19180108
3082
3083         Reviewed by Sam Weinig.
3084
3085         * WebCoreSupport/WebViewGroup.h:
3086         Store the local storage database path in the group.
3087
3088         * WebCoreSupport/WebViewGroup.mm:
3089         (WebViewGroup::getOrCreate):
3090         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
3091         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
3092
3093         (WebViewGroup::WebViewGroup):
3094         Initialize the new member variable.
3095
3096         (WebViewGroup::storageNamespaceProvider):
3097         Create the namespace provider lazily.
3098
3099         * WebView/WebView.mm:
3100         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
3101         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
3102         Use getOrCreate instead of get.
3103
3104 2014-12-08  Anders Carlsson  <andersca@apple.com>
3105
3106         WebStorageNamespaceProvider should know about its local storage database path
3107         https://bugs.webkit.org/show_bug.cgi?id=139413
3108
3109         Reviewed by Andreas Kling.
3110
3111         * WebCoreSupport/WebViewGroup.h:
3112         * WebCoreSupport/WebViewGroup.mm:
3113         (WebViewGroup::getOrCreate):
3114         (WebViewGroup::WebViewGroup):
3115         * WebView/WebView.mm:
3116         (-[WebView _commonInitializationWithFrameName:groupName:]):
3117         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3118         (-[WebView setGroupName:]):
3119         (-[WebView groupName]): Deleted.
3120
3121 2014-12-08  Daniel Bates  <dabates@apple.com>
3122
3123         [iOS] Fix the WebKit build with the public SDK
3124
3125         Include header NSURLDownloadSPI.h.
3126
3127         * WebCoreSupport/WebFrameLoaderClient.mm:
3128
3129 2014-12-07  Dan Bernstein  <mitz@apple.com>
3130
3131         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
3132         https://bugs.webkit.org/show_bug.cgi?id=139348
3133
3134         Reviewed by Anders Carlsson.
3135
3136         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
3137         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
3138         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
3139         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
3140         avoiding the ambiguity.
3141
3142         * WebView/WebActionMenuController.mm:
3143         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3144
3145 2014-12-06  Anders Carlsson  <andersca@apple.com>
3146
3147         Add a stubbed out version of WebStorageNamespaceProvider
3148         https://bugs.webkit.org/show_bug.cgi?id=139213
3149
3150         Reviewed by Sam Weinig.
3151
3152         * WebCoreSupport/WebViewGroup.h:
3153         (WebViewGroup::storageNamespaceProvider):
3154         * WebCoreSupport/WebViewGroup.mm:
3155         (WebViewGroup::getOrCreate):
3156         (WebViewGroup::WebViewGroup):
3157         Give WebViewGroup a storage namespace provider.
3158
3159 2014-12-06  Anders Carlsson  <andersca@apple.com>
3160
3161         Fix build with newer versions of clang.
3162         rdar://problem/18978687
3163
3164         Add missing overrides and missing casts.
3165
3166         * Storage/WebDatabaseManagerClient.h:
3167         * Storage/WebStorageTrackerClient.h:
3168         * WebCoreSupport/WebChromeClient.h:
3169         * WebCoreSupport/WebFrameLoaderClient.h:
3170         * WebCoreSupport/WebInspectorClient.h:
3171         * WebView/WebDataSource.mm:
3172         (-[WebDataSource _makeRepresentation]):
3173         * WebView/WebFrameView.mm:
3174         (-[WebFrameView _makeDocumentViewForDataSource:]):
3175
3176 2014-12-05  Tim Horton  <timothy_horton@apple.com>
3177
3178         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
3179         https://bugs.webkit.org/show_bug.cgi?id=139306
3180         <rdar://problem/19157955>
3181
3182         Reviewed by Beth Dakin.
3183
3184         * WebView/WebView.mm:
3185         (-[WebView _commonInitializationWithFrameName:groupName:]):
3186         (-[WebView _initWithFrame:frameName:groupName:]):
3187         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
3188
3189 2014-12-05  David Kilzer  <ddkilzer@apple.com>
3190
3191         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
3192         <http://webkit.org/b/139286>
3193
3194         Reviewed by Daniel Bates.
3195
3196         * Configurations/FeatureDefines.xcconfig: Switch back to using
3197         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
3198
3199 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
3200
3201         Fix the 32-bit build.
3202
3203         * WebView/WebView.mm:
3204         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3205
3206 2014-12-04  Tim Horton  <timothy_horton@apple.com>
3207
3208         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
3209         https://bugs.webkit.org/show_bug.cgi?id=139252
3210         <rdar://problem/19140827>
3211
3212         Reviewed by Anders Carlsson.
3213
3214         * WebView/WebView.mm:
3215         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3216         Adjust to the WebCore changes.
3217
3218 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
3219
3220         Implement action menus for tel: URLs
3221         https://bugs.webkit.org/show_bug.cgi?id=139240
3222         <rdar://problem/19115662>
3223
3224         Reviewed by Anders Carlsson.
3225
3226         * WebView/WebActionMenuController.mm:
3227         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3228         Make sure to use the newly created currentActionContext... everywhere.
3229
3230 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
3231
3232         Implement action menus for tel: URLs
3233         https://bugs.webkit.org/show_bug.cgi?id=139240
3234         <rdar://problem/19115662>
3235
3236         Reviewed by Anders Carlsson.
3237
3238         * WebView/WebActionMenuController.mm:
3239         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3240         Make sure to use the newly created currentActionContext.
3241
3242 2014-12-03  Beth Dakin  <bdakin@apple.com>
3243
3244         <input> elements get whitespace action menu instead of editable text menu
3245         https://bugs.webkit.org/show_bug.cgi?id=139241
3246         -and corresponding-
3247         rdar://problem/19072083
3248
3249         Reviewed by Sam Weinig.
3250
3251         We should disallow shadow content in the hit test. This is the default and it is 
3252         how context menus behave. We originally wanted to text inside shadow content so 
3253         that we could find the text, but the new function I added to HitTestResult will 
3254         allow that.
3255         * WebView/WebActionMenuController.mm:
3256         (-[WebActionMenuController performHitTestAtPoint:]):
3257
3258         Adjust to the fact that we don’t hit test shadow content any more.
3259         (-[WebActionMenuController focusAndSelectHitTestResult]):
3260
3261         Offer the text menus for text inside form controls.
3262         (-[WebActionMenuController _defaultMenuItems]):
3263
3264 2014-12-03  Tim Horton  <timothy_horton@apple.com>
3265
3266         Implement action menus for tel: URLs
3267         https://bugs.webkit.org/show_bug.cgi?id=139240
3268         <rdar://problem/19115662>
3269
3270         Reviewed by Anders Carlsson.
3271
3272         * WebView/WebActionMenuController.mm:
3273         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3274         Rename this function as it will work for both mailto and tel URLs.
3275         Adjust it to use contextForView:.
3276
3277         (-[WebActionMenuController webView:willHandleMouseDown:]):
3278         (-[WebActionMenuController prepareForMenu:withEvent:]):
3279         (-[WebActionMenuController didCloseMenu:withEvent:]):
3280         (-[WebActionMenuController _defaultMenuItems]):
3281         Don't check the menu type when going to interact with _currentActionContext.
3282         We'll only have a _currentActionContext if we have a data detected item,
3283         and there are multiple menu types that end up using DDActionContext.
3284
3285         * WebView/WebUIDelegatePrivate.h:
3286         Add a new type.
3287
3288 2014-12-03  Anders Carlsson  <andersca@apple.com>
3289
3290         Set a visited link store when creating a simple WebView
3291         https://bugs.webkit.org/show_bug.cgi?id=139234
3292         <rdar://problem/19132978>
3293
3294         Reviewed by Sam Weinig.
3295
3296         * WebView/WebView.mm:
3297         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3298
3299 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
3300
3301         Fix the build.
3302
3303         * WebCoreSupport/WebFrameLoaderClient.mm:
3304
3305 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
3306
3307         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
3308         https://bugs.webkit.org/show_bug.cgi?id=139149
3309
3310         Reviewed by Anders Carlsson.
3311
3312         This changes API behavior. I think that it's OK, because existing behavior made no sense.
3313         We used to delete caches from disk, but they were still active in memory. Now we also
3314         obsolete them in memory, so documents that use a cache still work, but new ones don't
3315         pick one up.
3316
3317         * WebCoreSupport/WebApplicationCache.mm:
3318         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
3319         need to delete in-momry caches too. Keep existing behavior.
3320         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
3321         that properly deletes caches.
3322
3323 2014-12-02  Tim Horton  <timothy_horton@apple.com>
3324
3325         Remove a SnowLeopard-era quirk for QuickLook
3326         https://bugs.webkit.org/show_bug.cgi?id=139208
3327         <rdar://problem/19121822>
3328
3329         Reviewed by Alexey Proskuryakov.
3330
3331         * WebCoreSupport/WebFrameLoaderClient.h:
3332         * WebCoreSupport/WebFrameLoaderClient.mm:
3333
3334 2014-12-02  Tim Horton  <timothy_horton@apple.com>
3335
3336         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
3337         https://bugs.webkit.org/show_bug.cgi?id=139204
3338
3339         Reviewed by Anders Carlsson.
3340
3341         * WebView/WebView.mm:
3342         (-[WebView _commonInitializationWithFrameName:groupName:]):
3343         (-[WebView _showDictionaryLookupPopup:]):
3344         * WebView/WebViewData.h:
3345         Work around this by delaying the softlinking (and setting up the notification
3346         observer) until we actually need it. There's still an underlying bug, but
3347         this will fix the test.
3348
3349 2014-12-02  Beth Dakin  <bdakin@apple.com>
3350
3351         Yet another build fix.
3352
3353         * WebView/WebActionMenuController.mm:
3354         (-[WebActionMenuController _defaultMenuItemsForLink]):
3355
3356 2014-12-02  Beth Dakin  <bdakin@apple.com>
3357
3358         Build fix.
3359
3360         * WebView/WebActionMenuController.mm:
3361         (-[WebActionMenuController _defaultMenuItemsForLink]):
3362
3363 2014-12-02  Beth Dakin  <bdakin@apple.com>
3364
3365         More build fixing.
3366
3367         * WebView/WebActionMenuController.mm:
3368         (-[WebActionMenuController _defaultMenuItemsForLink]):
3369
3370 2014-12-02  Beth Dakin  <bdakin@apple.com>
3371
3372         Should use standardQuickLookMenuItem for apps that don't implement customizations
3373         https://bugs.webkit.org/show_bug.cgi?id=139193
3374         -and corresponding-
3375         rdar://problem/18944696
3376
3377         Reviewed by Anders Carlsson.
3378
3379         Use [NSMenuItem standardQuickLookMenuItem].
3380         * WebView/WebActionMenuController.mm:
3381         (-[WebActionMenuController _defaultMenuItemsForLink]):
3382
3383         Delegate methods to set up the standardQuickLookMenuItem.
3384         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
3385         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
3386         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
3387
3388         Remove all of the old QLPreviewBubble code.
3389         (-[WebActionMenuController _createActionMenuItemForTag:]):
3390         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
3391
3392 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
3393
3394         Fix the build.
3395
3396         * WebView/WebViewData.h:
3397
3398 2014-12-02  Tim Horton  <timothy_horton@apple.com>
3399
3400         Implement Lookup transition from selection for Legacy WebKit
3401         https://bugs.webkit.org/show_bug.cgi?id=139180
3402         <rdar://problem/19067172>
3403
3404         Reviewed by Beth Dakin.
3405
3406         * WebView/DictionaryPopupInfo.h: Added.
3407         Split DictionaryPopupInfo out into its own file.
3408
3409         * WebView/WebActionMenuController.mm:
3410         (-[WebActionMenuController _lookupText:]):
3411         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
3412
3413         (performDictionaryLookupForSelection):
3414         (performDictionaryLookupForRange):
3415         Plumb the transition style through these helpers.
3416         Create a TextIndicator from the selection range.
3417
3418         * WebView/WebHTMLView.mm:
3419         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3420         Make use of TextIndicator (and DictionaryPopupInfo, and the new
3421         _showDictionaryLookupPopup on WebView) to add a transition from blue
3422         when performing Lookup from the context menu.
3423
3424         (-[WebHTMLView quickLookWithEvent:]):
3425         Remove our TextIndicator whenever a normal three-finger-tap event
3426         comes through, as it will have its own indication.
3427
3428         * WebView/WebView.mm:
3429         (-[WebView _commonInitializationWithFrameName:groupName:]):
3430         (-[WebView _dictionaryLookupPopoverWillClose:]):
3431         Register for the LUNotificationPopoverWillClose notification and remove
3432         our TextIndicator when it is called, just like in WebKit2.
3433         Deregistration is already handled in _close.
3434
3435         (-[WebView _showDictionaryLookupPopup:]):
3436         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
3437         if the relevant API is available.
3438
3439         * WebView/WebViewInternal.h:
3440
3441 2014-12-02  Anders Carlsson  <andersca@apple.com>
3442
3443         Remove visited link handling from PageGroup
3444         https://bugs.webkit.org/show_bug.cgi?id=139185
3445
3446         Reviewed by Sam Weinig.
3447
3448         * History/WebHistory.mm:
3449         (-[WebHistoryPrivate removeItemForURLString:]):
3450         (-[WebHistoryPrivate removeAllItems]):
3451         (+[WebHistory setOptionalSharedHistory:]):
3452         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
3453         (+[WebHistory _removeAllVisitedLinks]):
3454         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
3455         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
3456         * History/WebHistoryInternal.h:
3457         * WebCoreSupport/WebChromeClient.h:
3458         * WebCoreSupport/WebChromeClient.mm:
3459         (WebChromeClient::populateVisitedLinks): Deleted.
3460         * WebView/WebView.mm:
3461         (-[WebView addVisitedLinks:]):
3462         (-[WebView removeVisitedLink:]):
3463
3464 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
3465
3466         Try to fix the Mac build.
3467
3468         * WebView/WebView.mm:
3469         (-[WebView _commonInitializationWithFrameName:groupName:]):
3470         (-[WebView _close]):
3471
3472 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
3473
3474         Fix the iOS build.
3475
3476         * WebView/WebActionMenuController.h:
3477         * WebView/WebActionMenuController.mm:
3478         * WebView/WebHTMLView.mm:
3479         (-[WebHTMLView scrollWheel:scrollWheel:]):
3480         (-[WebHTMLView mouseDown:mouseDown:]):
3481         * WebView/WebView.mm:
3482         * WebView/WebViewData.h:
3483         * WebView/WebViewData.mm:
3484         (-[WebViewPrivate dealloc]):
3485         * WebView/WebViewInternal.h:
3486
3487 2014-12-01  Tim Horton  <timothy_horton@apple.com>
3488
3489         Implement yellow highlight for WebKit1 data detectors
3490         https://bugs.webkit.org/show_bug.cgi?id=138956
3491         <rdar://problem/18992185>
3492
3493         Reviewed by Beth Dakin.
3494
3495         * WebView/WebActionMenuController.h:
3496         * WebView/WebActionMenuController.mm:
3497         (-[WebActionMenuController webView:willHandleMouseDown:]):
3498         (-[WebActionMenuController webView:didHandleScrollWheel:]):
3499         (-[WebActionMenuController prepareForMenu:withEvent:]):
3500         (-[WebActionMenuController didCloseMenu:withEvent:]):
3501         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
3502         (-[WebActionMenuController _showTextIndicator]):
3503         (-[WebActionMenuController _hideTextIndicator]):
3504         (-[WebActionMenuController _dismissActionMenuPopovers]):
3505         Copy the WebKit2 WKActionMenuController TextIndicator implementation
3506         into WebActionMenuController. The only significant difference is
3507         that we build the TextIndicator right at menu construction time
3508         instead of in the Web process.
3509
3510         * WebView/WebHTMLView.mm:
3511         (-[WebHTMLView scrollWheel:]):
3512         Let the WebActionMenuController know that we're handling a scroll.
3513
3514         (-[WebHTMLView mouseDown:]):
3515         Let the WebActionMenuController know that we're handling a mouseDown.
3516
3517         * WebView/WebView.mm:
3518         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3519         (-[WebView _clearTextIndicator]):
3520         (-[WebView _actionMenuController]):
3521         (-[WebView _convertRectFromRootView:]): Deleted.
3522         * WebView/WebViewData.h:
3523         * WebView/WebViewData.mm:
3524         * WebView/WebViewInternal.h:
3525         Keep a TextIndicatorWindow on WebView, just like WKView does.
3526         Expose the WebActionMenuController on WebView (internally).
3527
3528 2014-12-01  Anders Carlsson  <andersca@apple.com>
3529
3530         Remove old site specific quirks code that was added in 2009
3531         https://bugs.webkit.org/show_bug.cgi?id=139141
3532
3533         Reviewed by Antti Koivisto.
3534
3535         * WebCoreSupport/WebFrameNetworkingContext.h:
3536         * WebCoreSupport/WebFrameNetworkingContext.mm:
3537         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
3538
3539 2014-11-30  Anders Carlsson  <andersca@apple.com>
3540
3541         Fix a test failure.
3542
3543         * History/WebHistory.mm:
3544         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
3545         Call through to the visited link store.
3546
3547         (+[WebHistory _removeAllVisitedLinks]):
3548         Ditto.
3549
3550         * WebCoreSupport/WebVisitedLinkStore.mm:
3551         (WebVisitedLinkStore::isLinkVisited):
3552         Make sure to populate visited links.
3553
3554 2014-11-30  Anders Carlsson  <andersca@apple.com>
3555
3556         Switch over to the visited link store from the WebViewGroup
3557         https://bugs.webkit.org/show_bug.cgi?id=139112
3558
3559         Reviewed by Sam Weinig.
3560
3561         * WebView/WebView.mm:
3562         (-[WebView _commonInitializationWithFrameName:groupName:]):
3563         (-[WebView setGroupName:]):
3564
3565 2014-11-30  Anders Carlsson  <andersca@apple.com>
3566
3567         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
3568         https://bugs.webkit.org/show_bug.cgi?id=139111
3569
3570         Reviewed by Sam Weinig.
3571
3572         * WebCoreSupport/WebVisitedLinkStore.h:
3573         * WebCoreSupport/WebVisitedLinkStore.mm: