62ce81801afe7f4f1f911866ee1f87174d47667d
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2016-11-09  Darin Adler  <darin@apple.com>
2
3         Move Range from ExceptionCode to ExceptionOr
4         https://bugs.webkit.org/show_bug.cgi?id=164457
5
6         Reviewed by Alex Christensen.
7
8         * DOM/DOMRange.mm:
9         (-[DOMRange setStart:offset:]): Updated exception handling.
10         (-[DOMRange setEnd:offset:]): Ditto.
11         (-[DOMRange setStartBefore:]): Ditto.
12         (-[DOMRange setStartAfter:]): Ditto.
13         (-[DOMRange setEndBefore:]): Ditto.
14         (-[DOMRange setEndAfter:]): Ditto.
15         (-[DOMRange selectNode:]): Ditto.
16         (-[DOMRange selectNodeContents:]): Ditto.
17         (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
18         (-[DOMRange deleteContents]): Ditto.
19         (-[DOMRange extractContents]): Ditto.
20         (-[DOMRange cloneContents]): Ditto.
21         (-[DOMRange insertNode:]): Ditto.
22         (-[DOMRange surroundContents:]): Ditto.
23         (-[DOMRange createContextualFragment:]): Ditto.
24         (-[DOMRange compareNode:]): Ditto.
25         (-[DOMRange intersectsNode:]): Ditto.
26         (-[DOMRange comparePoint:offset:]): Ditto.
27         (-[DOMRange isPointInRange:offset:]): Ditto.
28         (-[DOMRange expand:]): Ditto.
29         * WebView/WebFrame.mm:
30         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
31         (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
32         This function was incorrectly implemented (set both start and end of
33         the range to the computed start), not declared in any header file,
34         not used anywhere inside WebKit, and I also could not find a use of it
35         in outside-WebKit Apple code.
36         * mac/DOM/DOMUIKitExtensions.mm:
37         (-[DOMRange move:inDirection:]): Ditto.
38         (-[DOMRange extend:inDirection:]): Ditto.
39
40 2016-11-09  Darin Adler  <darin@apple.com>
41
42         Move EventTarget from ExceptionCode to ExceptionOr
43         https://bugs.webkit.org/show_bug.cgi?id=164465
44
45         Reviewed by Youenn Fablet.
46
47         * DOM/DOMNode.mm:
48         (-[DOMNode dispatchEvent:]): Updated exception handling.
49
50 2016-11-09  Chris Dumez  <cdumez@apple.com>
51
52         [Mac] Stop using deprecated AppKit enumeration values
53         https://bugs.webkit.org/show_bug.cgi?id=164494
54
55         Reviewed by Darin Adler.
56
57         Stop using deprecated AppKit enumeration values.
58
59         * Carbon/CarbonWindowAdapter.mm:
60         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
61         (-[CarbonWindowAdapter sendSuperEvent:]):
62         * Plugins/Hosted/NetscapePluginHostProxy.mm:
63         (WebKit::NetscapePluginHostProxy::beginModal):
64         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
65         (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
66         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
67         (-[WebHostedNetscapePluginView drawRect:]):
68         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
69         (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
70         * WebCoreSupport/PopupMenuMac.mm:
71         (PopupMenuMac::populate):
72         (PopupMenuMac::show):
73         * WebCoreSupport/WebContextMenuClient.mm:
74         (WebContextMenuClient::showContextMenu):
75         * WebCoreSupport/WebFrameLoaderClient.mm:
76         (WebFrameLoaderClient::actionDictionary):
77         * WebCoreSupport/WebInspectorClient.mm:
78         (WebInspectorFrontendClient::canAttach):
79         (-[WebInspectorWindowController window]):
80         * WebInspector/WebNodeHighlight.mm:
81         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
82         * WebView/WebFrameView.mm:
83         (-[WebFrameView keyDown:keyDown:]):
84         * WebView/WebFullScreenController.mm:
85         (-[WebFullScreenController init]):
86         (createBackgroundFullscreenWindow):
87         * WebView/WebHTMLView.mm:
88         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
89         (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
90         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
91         (isQuickLookEvent):
92         (-[WebHTMLView hitTest:]):
93         (-[WebHTMLView _sendToolTipMouseExited]):
94         (-[WebHTMLView _sendToolTipMouseEntered]):
95         (mouseEventIsPartOfClickOrDrag):
96         (-[WebHTMLView _updateMouseoverWithEvent:]):
97         (-[WebHTMLView _autoscroll]):
98         (-[WebHTMLView acceptsFirstResponder]):
99         (-[WebHTMLView viewDidMoveToWindow]):
100         (-[WebHTMLView mouseDown:mouseDown:]):
101         (currentKeyboardEvent):
102         (-[WebHTMLView _handleStyleKeyEquivalent:]):
103         (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
104         * WebView/WebPDFView.mm:
105         (-[WebPDFView hitTest:]):
106         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
107         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
108         * WebView/WebTextCompletionController.mm:
109         (-[WebTextCompletionController _buildUI]):
110         (-[WebTextCompletionController _placePopupWindow:]):
111         * WebView/WebView.mm:
112         (-[WebView applicationFlags:]):
113
114 2016-11-09  Beth Dakin  <bdakin@apple.com>
115
116         Support TouchBar in WebKit
117         https://bugs.webkit.org/show_bug.cgi?id=164437
118         -and corresponding-
119         rdar://problem/28876524
120
121         Reviewed by Darin Adler.
122
123         * WebCoreSupport/WebEditorClient.mm:
124         (WebEditorClient::respondToChangedSelection):
125         (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
126         * WebView/WebHTMLView.mm:
127         (-[WebHTMLView candidateListTouchBarItem]):
128         * WebView/WebView.mm:
129         (-[_WebTextListTouchBarViewController initWithWebView:]):
130         (-[_WebTextListTouchBarViewController _selectList:]):
131         (-[_WebTextListTouchBarViewController setCurrentListType:]):
132         (-[WebTextTouchBarItemController initWithWebView:]):
133         (-[WebTextTouchBarItemController itemForIdentifier:]):
134         (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
135         (-[WebTextTouchBarItemController setTextIsBold:]):
136         (-[WebTextTouchBarItemController setTextIsItalic:]):
137         (-[WebTextTouchBarItemController setTextIsUnderlined:]):
138         (-[WebTextTouchBarItemController _webChangeTextStyle:]):
139         (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
140         (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
141         (-[WebTextTouchBarItemController textColor]):
142         (-[WebTextTouchBarItemController setTextColor:]):
143         (-[WebTextTouchBarItemController _webChangeColor:]):
144         (-[WebTextTouchBarItemController textListViewController]):
145         (-[WebView _commonInitializationWithFrameName:groupName:]):
146         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
147         (-[WebView shouldRequestCandidates]):
148         (-[WebView forceRequestCandidatesForTesting]):
149         (-[WebView makeTouchBar]):
150         (-[WebView touchBar:makeItemForIdentifier:]):
151         (textCheckingResultFromNSTextCheckingResult):
152         (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
153         (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
154         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
155         (-[WebView _clearPlaybackControlsManager]):
156         (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
157         (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
158         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
159         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
160         (-[WebView touchBarDidExitCustomization:]):
161         (-[WebView touchBarWillEnterCustomization:]):
162         (-[WebView didChangeAutomaticTextCompletion:]):
163         (-[WebView setUpTextTouchBar:]):
164         (-[WebView _isRichlyEditable]):
165         (-[WebView textTouchBar]):
166         (-[WebView updateTextTouchBar]):
167         (-[WebView updateMediaTouchBar]):
168         (-[WebView updateTouchBar]):
169         (-[WebView prepareForMouseDown]):
170         (-[WebView prepareForMouseUp]):
171         (-[WebView webViewAdditionsWillDestroyView]):
172         (-[WebView candidateList]):
173         (-[WebView updateWebViewAdditions]): Deleted.
174         * WebView/WebViewData.h:
175         * WebView/WebViewInternal.h:
176         * WebView/WebViewPrivate.h:
177
178 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
179
180         Safari does not emit composition end if blurred for dead key / Japanese IME
181         https://bugs.webkit.org/show_bug.cgi?id=164369
182         <rdar://problem/29050439>
183
184         Reviewed by Ryosuke Niwa.
185
186         When canceling a composition, make sure that we clear the system IME state.
187
188         * WebCoreSupport/WebEditorClient.h:
189         * WebCoreSupport/WebEditorClient.mm:
190         (WebEditorClient::canceledComposition):
191
192 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
193
194         Add a setting and preferences to enable/disable async image decoding
195         https://bugs.webkit.org/show_bug.cgi?id=164417
196
197         Reviewed by Simon Fraser.
198
199         Hook up the asyncImageDecodingEnabled setting for WebKit1.
200
201         * WebView/WebPreferenceKeysPrivate.h:
202         * WebView/WebPreferences.mm:
203         (+[WebPreferences initialize]):
204         (-[WebPreferences asyncImageDecodingEnabled]):
205         (-[WebPreferences setAsyncImageDecodingEnabled:]):
206         * WebView/WebPreferencesPrivate.h:
207         * WebView/WebView.mm:
208         (-[WebView _preferencesChanged:]):
209
210 2016-11-01  Alex Christensen  <achristensen@webkit.org>
211
212         Remove PassRefPtr from DumpRenderTree
213         https://bugs.webkit.org/show_bug.cgi?id=164307
214
215         Reviewed by Sam Weinig.
216
217         * WebView/WebGeolocationPosition.mm:
218         (-[WebGeolocationPosition initWithGeolocationPosition:]):
219
220 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
221
222         [Readable Streams API] Enable creation of ReadableByteStreamController
223         https://bugs.webkit.org/show_bug.cgi?id=164014
224
225         Reviewed by Youenn Fablet.
226
227         Added flag for the byte stream part of Readable Streams API.
228
229         * Configurations/FeatureDefines.xcconfig:
230
231 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
232
233         Remove CUSTOM_ELEMENTS build flag
234         https://bugs.webkit.org/show_bug.cgi?id=164267
235
236         Reviewed by Antti Koivisto.
237
238         Removed the build flag.
239
240         * Configurations/FeatureDefines.xcconfig:
241         * WebView/WebPreferences.mm:
242         (+[WebPreferences initialize]):
243         * WebView/WebView.mm:
244         (-[WebView _preferencesChanged:]):
245
246 2016-11-01  Eric Carlson  <eric.carlson@apple.com>
247
248         [MediaStream] restrict media capture secure connections
249         https://bugs.webkit.org/show_bug.cgi?id=164234
250         <rdar://problem/28944906>
251
252         Reviewed by Alex Christensen.
253
254         * WebView/WebPreferenceKeysPrivate.h:
255         * WebView/WebPreferences.mm:
256         (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
257         (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
258         (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
259         * WebView/WebPreferencesPrivate.h:
260
261         * WebView/WebView.mm:
262         (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
263
264 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
265
266         JSC should support SharedArrayBuffer
267         https://bugs.webkit.org/show_bug.cgi?id=163986
268
269         Reviewed by Keith Miller.
270         
271         Support the RuntimeFlag.
272
273         * WebView/WebPreferencesPrivate.h:
274
275 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
276
277         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
278         https://bugs.webkit.org/show_bug.cgi?id=164236
279         <rdar://problem/28747712>
280
281         Reviewed by Beth Dakin.
282
283         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
284         dictionary lookup.
285
286         * WebCoreSupport/WebEditorClient.mm:
287         (WebEditorClient::respondToChangedSelection):
288         * WebView/WebImmediateActionController.mm:
289         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
290
291 2016-10-31  Darin Adler  <darin@apple.com>
292
293         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
294         https://bugs.webkit.org/show_bug.cgi?id=164214
295
296         Reviewed by Alex Christensen.
297
298         * DOM/DOMCSSPrimitiveValue.mm:
299         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
300         is a reference now.
301         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
302
303         * DOM/DOMDocument.mm:
304         (-[DOMDocument querySelector:]): Updated exception handling.
305         (-[DOMDocument querySelectorAll:]): Ditto.
306         * DOM/DOMDocumentFragment.mm:
307         (-[DOMDocumentFragment querySelector:]): Ditto.
308         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
309         * DOM/DOMElement.mm:
310         (-[DOMElement querySelector:]): Ditto.
311         (-[DOMElement querySelectorAll:]): Ditto.
312
313 2016-10-31  Darin Adler  <darin@apple.com>
314
315         Convert Document from ExceptionCode to Exception
316         https://bugs.webkit.org/show_bug.cgi?id=164212
317
318         Reviewed by Alex Christensen.
319
320         * DOM/DOMDocument.mm:
321         (-[DOMDocument setXmlVersion:]): Updated exception handling.
322         (-[DOMDocument cookie]): Ditto.
323         (-[DOMDocument setCookie:]): Ditto.
324         (-[DOMDocument setBody:]): Ditto.
325         (-[DOMDocument createElement:]): Ditto.
326         (-[DOMDocument createCDATASection:]): Ditto.
327         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
328         (-[DOMDocument createAttribute:]): Ditto.
329         (-[DOMDocument createEntityReference:]): Ditto.
330         (-[DOMDocument importNode:deep:]): Ditto.
331         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
332         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
333         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
334         (-[DOMDocument adoptNode:]): Ditto.
335         (-[DOMDocument createEvent:]): Ditto.
336
337 2016-10-30  Darin Adler  <darin@apple.com>
338
339         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
340         https://bugs.webkit.org/show_bug.cgi?id=164206
341
342         Reviewed by Chris Dumez.
343
344         * DOM/DOMElement.mm:
345         (-[DOMElement setInnerHTML:]): Updated exception handling.
346         (-[DOMElement setOuterHTML:]): Ditto.
347         (-[DOMElement setAttribute:value:]): Ditto.
348         (-[DOMElement setAttributeNode:]): Ditto.
349         (-[DOMElement removeAttributeNode:]): Ditto.
350         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
351         (-[DOMElement setAttributeNodeNS:]): Ditto.
352         (-[DOMElement matches:]): Ditto.
353         (-[DOMElement closest:]): Ditto.
354         (-[DOMElement webkitMatchesSelector:]): Ditto.
355         * DOM/DOMHTMLElement.mm:
356         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
357         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
358         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
359         * DOM/DOMNamedNodeMap.mm:
360         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
361         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
362         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
363         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
364
365 2016-10-29  Darin Adler  <darin@apple.com>
366
367         Convert more of DOM from ExceptionCode to Exception
368         https://bugs.webkit.org/show_bug.cgi?id=164173
369
370         Reviewed by Ryosuke Niwa.
371
372         * DOM/DOMCharacterData.mm:
373         (-[DOMCharacterData substringData:length:]): Updated since this
374         now uses ExceptionOr.
375         (-[DOMCharacterData insertData:data:]): Ditto.
376         (-[DOMCharacterData deleteData:length:]): Ditto.
377         (-[DOMCharacterData replaceData:length:data:]): Ditto.
378         * DOM/DOMText.mm:
379         (-[DOMText splitText:]): Ditto.
380         (-[DOMText replaceWholeText:]): Removed unneeded exception code
381         handling from function that does not throw an exception.
382
383 2016-10-28  Darin Adler  <darin@apple.com>
384
385         Move all classes in the HTML directory from ExceptionCode to Exception
386         https://bugs.webkit.org/show_bug.cgi?id=163876
387
388         Reviewed by Sam Weinig.
389
390         * DOM/DOMCharacterData.mm:
391         (-[DOMCharacterData remove]): Updated exception handling.
392         * DOM/DOMDOMTokenList.mm:
393         (-[DOMDOMTokenList toggle:force:]): Ditto.
394         * DOM/DOMDocumentType.mm:
395         (-[DOMDocumentType remove]): Ditto.
396         * DOM/DOMElement.mm:
397         (-[DOMElement remove]): Ditto.
398         * DOM/DOMHTML.mm:
399         (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
400         * DOM/DOMHTMLCanvasElement.mm:
401         (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
402         * DOM/DOMHTMLElement.mm:
403         (-[DOMHTMLElement setInnerText:]): Ditto.
404         (-[DOMHTMLElement setOuterText:]): Ditto.
405         (-[DOMHTMLElement setContentEditable:]): Ditto.
406         * DOM/DOMHTMLInputElement.mm:
407         (-[DOMHTMLInputElement setMaxLength:]): Ditto.
408         (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
409         (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
410         (-[DOMHTMLInputElement stepUp:]): Ditto.
411         (-[DOMHTMLInputElement stepDown:]): Ditto.
412         (-[DOMHTMLInputElement setRangeText:]): Ditto.
413         (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
414         * DOM/DOMHTMLMarqueeElement.mm:
415         (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
416         * DOM/DOMHTMLMediaElement.mm:
417         (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
418         (-[DOMHTMLMediaElement setVolume:]): Ditto.
419         * DOM/DOMHTMLOptionsCollection.mm:
420         (-[DOMHTMLOptionsCollection setLength:]): Ditto.
421         * DOM/DOMHTMLTableElement.mm:
422         (-[DOMHTMLTableElement setCaption:]): Ditto.
423         (-[DOMHTMLTableElement setTHead:]): Ditto.
424         (-[DOMHTMLTableElement setTFoot:]): Ditto.
425         (-[DOMHTMLTableElement insertRow:]): Ditto.
426         (-[DOMHTMLTableElement deleteRow:]): Ditto.
427         * DOM/DOMHTMLTableRowElement.mm:
428         (-[DOMHTMLTableRowElement insertCell:]): Ditto.
429         (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
430         * DOM/DOMHTMLTableSectionElement.mm:
431         (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
432         (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
433         * DOM/DOMHTMLTextAreaElement.mm:
434         (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
435         (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
436         (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
437         * DOM/DOMHTMLVideoElement.mm:
438         (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
439         (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
440         version (lowercase S) instead of repeating the logic from that method.
441         (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
442         * DOM/DOMTimeRanges.mm:
443         (-[DOMTimeRanges start:]): Updated exception handling.
444         (-[DOMTimeRanges end:]): Ditto.
445
446 2016-10-27  Chris Dumez  <cdumez@apple.com>
447
448         Regression(r203601): Caused crashes in iBooks
449         https://bugs.webkit.org/show_bug.cgi?id=164093
450         <rdar://problem/28745634>
451
452         Reviewed by Darin Adler.
453
454         Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
455         which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
456
457         * DOM/DOMNode.mm:
458         (-[DOMNode compareDocumentPosition:]):
459
460 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
461
462         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
463         https://bugs.webkit.org/show_bug.cgi?id=163948
464         <rdar://problem/28921433>
465
466         Reviewed by Darin Adler.
467
468         Add support for new drag and drop-related EditAction enum values.
469
470         * WebCoreSupport/WebEditorClient.mm:
471         (undoNameForEditAction):
472
473 2016-10-27  Dan Bernstein  <mitz@apple.com>
474
475         Reapplied the configuration changes from r207934 without breaking iOS builds.
476
477         * Configurations/Base.xcconfig:
478         * Configurations/WebKitLegacy.xcconfig:
479
480 2016-10-27  Dan Bernstein  <mitz@apple.com>
481
482         Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
483
484         * Configurations/Base.xcconfig:
485         * Configurations/WebKitLegacy.xcconfig:
486
487 2016-10-26  Dan Bernstein  <mitz@apple.com>
488
489         [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
490         https://bugs.webkit.org/show_bug.cgi?id=164048
491
492         Reviewed by Tim Horton.
493
494         * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
495         * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
496           headers.
497
498         * History/WebBackForwardList.h: Fixed parameter name in @param entry.
499         * Misc/WebDownload.h: Removed empty entries.
500         * Misc/WebIconDatabase.h: Remove incorrect @param entries.
501         * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
502         * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
503         * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
504         * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
505         * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
506         * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
507         * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
508           Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
509         * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
510         * WebView/WebView.h: Changed @method to @property in a couple of places.
511         * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
512
513 2016-10-26  Brian Burg  <bburg@apple.com>
514
515         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
516         https://bugs.webkit.org/show_bug.cgi?id=164046
517
518         Reviewed by Joseph Pecoraro.
519
520         * WebCoreSupport/WebInspectorClient.h:
521
522 2016-10-21  Alex Christensen  <achristensen@webkit.org>
523
524         URL::port should return Optional<uint16_t>
525         https://bugs.webkit.org/show_bug.cgi?id=163806
526
527         Reviewed by Darin Adler.
528
529         * WebCoreSupport/WebSecurityOrigin.mm:
530         (-[WebSecurityOrigin port]):
531
532 2016-10-24  Dave Hyatt  <hyatt@apple.com>
533
534         Remove CSSCharsetRule from the CSS OM
535         https://bugs.webkit.org/show_bug.cgi?id=163891
536
537         Reviewed by Darin Adler.
538
539         * DOM/DOMCSSCharsetRule.mm:
540         (-[DOMCSSCharsetRule encoding]):
541
542 2016-10-24  Youenn Fablet  <youenn@apple.com>
543
544         Activate WEB_RTC compilation flags for Mac bots
545         https://bugs.webkit.org/show_bug.cgi?id=163886
546
547         Reviewed by Eric Carlson.
548
549         * Configurations/FeatureDefines.xcconfig:
550
551 2016-10-23  Chris Dumez  <cdumez@apple.com>
552
553         addEventListener() / removeEventListener() should use a union for last parameter
554         https://bugs.webkit.org/show_bug.cgi?id=163863
555
556         Reviewed by Darin Adler.
557
558         Cast BOOL to bool to help to compiler construct the new variant-type parameter.
559
560         * DOM/DOMNode.mm:
561         (-[DOMNode addEventListener:listener:useCapture:]):
562         (-[DOMNode addEventListener:::]):
563         (-[DOMNode removeEventListener:listener:useCapture:]):
564         (-[DOMNode removeEventListener:::]):
565
566 2016-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
567
568         Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
569         https://bugs.webkit.org/show_bug.cgi?id=163460
570         <rdar://problem/28784142>
571
572         Reviewed by Darin Adler.
573
574         Handle new EditAction types for inserting/deleting pending/final compositions.
575
576         * WebCoreSupport/WebEditorClient.mm:
577         (undoNameForEditAction):
578
579 2016-10-21  Jeremy Jones  <jeremyj@apple.com>
580
581         Implement basic pointer lock behavior for WebKit and WebKit2.
582         https://bugs.webkit.org/show_bug.cgi?id=162745
583
584         Reviewed by Simon Fraser.
585
586         Add basic pointer lock functionality. User permission is not yet implemented.
587
588         * WebCoreSupport/WebChromeClient.h:
589         * WebCoreSupport/WebChromeClient.mm:
590         (WebChromeClient::requestPointerLock):
591         (WebChromeClient::requestPointerUnlock):
592
593 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
594
595         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
596         https://bugs.webkit.org/show_bug.cgi?id=163374
597
598         Reviewed by Darin Adler.
599
600         * Configurations/FeatureDefines.xcconfig:
601
602 2016-10-19  Alex Christensen  <achristensen@webkit.org>
603
604         Revert r207151
605         https://bugs.webkit.org/show_bug.cgi?id=163675
606
607         Reviewed by Brent Fulgham.
608
609         * Misc/WebDownload.mm:
610         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
611         * Misc/WebDownloadInternal.h:
612         * WebCoreSupport/WebFrameLoaderClient.mm:
613         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
614         * WebView/WebPreferences.mm:
615         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
616         * WebView/WebView.mm:
617         (-[WebView scheduleInRunLoop:forMode:]):
618         (-[WebView unscheduleFromRunLoop:forMode:]):
619
620 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
621
622         Unreviewed, rolling out r207557.
623
624         This change caused animations/font-variations tests to time
625         out on pre-Sierra Macs.
626
627         Reverted changeset:
628
629         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
630         iOS 9"
631         https://bugs.webkit.org/show_bug.cgi?id=163374
632         http://trac.webkit.org/changeset/207557
633
634 2016-10-19  Chris Dumez  <cdumez@apple.com>
635
636         Move HTML Interactive Form Validation behind an experimental flag
637         https://bugs.webkit.org/show_bug.cgi?id=163673
638
639         Reviewed by Daniel Bates.
640
641         Re-disable HTML Interactive Form Validation by default on Mac WK1.
642
643         * WebView/WebViewData.mm:
644         (-[WebViewPrivate init]):
645
646 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
647
648         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
649         https://bugs.webkit.org/show_bug.cgi?id=163374
650
651         Reviewed by Darin Adler.
652
653         * Configurations/FeatureDefines.xcconfig:
654
655 2016-10-19  Simon Fraser  <simon.fraser@apple.com>
656
657         WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
658         https://bugs.webkit.org/show_bug.cgi?id=163680
659
660         Reviewed by Dean Jackson.
661
662         Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
663
664         * WebView/WebView.mm:
665         (-[WebView _preferencesChanged:]):
666
667 2016-10-19  Darin Adler  <darin@apple.com>
668
669         Move XPath from ExceptionCode to Exception
670         https://bugs.webkit.org/show_bug.cgi?id=163656
671
672         Reviewed by Chris Dumez.
673
674         * DOM/DOMDocument.mm:
675         (wrap): Added. Helper function for wrapping a resolver.
676         (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
677         (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
678         * DOM/DOMXPathExpression.mm:
679         (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
680         * DOM/DOMXPathResult.mm:
681         (-[DOMXPathResult numberValue]): Ditto.
682         (-[DOMXPathResult stringValue]): Ditto.
683         (-[DOMXPathResult booleanValue]): Ditto.
684         (-[DOMXPathResult singleNodeValue]): Ditto.
685         (-[DOMXPathResult snapshotLength]): Ditto.
686         (-[DOMXPathResult iterateNext]): Ditto.
687         (-[DOMXPathResult snapshotItem:]): Ditto.
688
689 2016-10-18  Sam Weinig  <sam@webkit.org>
690
691         Replace std::experimental::variant with WTF::Variant (or similar)
692         https://bugs.webkit.org/show_bug.cgi?id=163626
693
694         Reviewed by Chris Dumez.
695
696         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
697         into the WTF namespace.
698
699         * DOM/DOMHTMLSelectElement.mm:
700         (-[DOMHTMLSelectElement add:before:]):
701
702 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
703
704         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
705         https://bugs.webkit.org/show_bug.cgi?id=163627
706
707         Reviewed by Dean Jackson.
708
709         Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
710
711         * WebView/WebViewPrivate.h:
712
713 2016-10-18  Dean Jackson  <dino@apple.com>
714
715         Remove CSS_SHAPES feature definition. This should always be on.
716         https://bugs.webkit.org/show_bug.cgi?id=163628
717         <rdar://problem/28834613>
718
719         Reviewed by Tim Horton.
720
721         * Configurations/FeatureDefines.xcconfig:
722
723 2016-10-18  Chris Dumez  <cdumez@apple.com>
724
725         Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
726         https://bugs.webkit.org/show_bug.cgi?id=163608
727
728         Reviewed by Ryosuke Niwa.
729
730         Update add() call sites now that it takes std::variant types in.
731
732         * DOM/DOMHTMLOptionsCollection.mm:
733         (-[DOMHTMLOptionsCollection add:index:]):
734         * DOM/DOMHTMLSelectElement.mm:
735         (-[DOMHTMLSelectElement add:before:]):
736
737 2016-10-18  Anders Carlsson  <andersca@apple.com>
738
739         Get rid of more WebHistoryItem cruft
740         https://bugs.webkit.org/show_bug.cgi?id=163623
741
742         Reviewed by Tim Horton.
743
744         * History/WebHistoryItem.mm:
745         (-[WebHistoryItem initFromDictionaryRepresentation:]):
746         * History/WebHistoryItemPrivate.h:
747
748 2016-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
749
750         Showing and hiding candidates list is very distracting after selecting word
751         https://bugs.webkit.org/show_bug.cgi?id=163609
752         <rdar://problem/28747712>
753
754         Reviewed by Tim Horton.
755
756         Introduce WebView hooks for mousedown and mouseup. See radar for more details.
757
758         * WebView/WebHTMLView.mm:
759         (-[WebHTMLView mouseDown:mouseDown:]):
760         (-[WebHTMLView mouseUp:mouseUp:]):
761         * WebView/WebView.mm:
762         (-[WebView prepareForMouseDown]):
763         (-[WebView prepareForMouseUp]):
764         * WebView/WebViewInternal.h:
765
766 2016-10-17  Anders Carlsson  <andersca@apple.com>
767
768         Move some history specific HistoryItem code to WebHistoryItem
769         https://bugs.webkit.org/show_bug.cgi?id=163567
770
771         Reviewed by Tim Horton.
772
773         * History/HistoryPropertyList.mm:
774         (HistoryPropertyListWriter::writeHistoryItem):
775         * History/WebHistory.mm:
776         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
777         * History/WebHistoryItem.mm:
778         (-[WebHistoryItem initFromDictionaryRepresentation:]):
779         * History/WebHistoryItemInternal.h:
780         * WebCoreSupport/WebFrameLoaderClient.mm:
781         (addRedirectURL):
782         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
783
784 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
785
786         [MediaStream] Resolve constraints and enumerate devices in the UI process
787         https://bugs.webkit.org/show_bug.cgi?id=162147
788         <rdar://problem/28803569>
789
790         Reviewed by Darin Adler.
791
792         * WebCoreSupport/WebUserMediaClient.h:
793         * WebCoreSupport/WebUserMediaClient.mm:
794         (AddPermissionCheckToMap):
795         (RemovePermissionCheckFromMap):
796         (WebUserMediaClient::pageDestroyed):
797         (WebUserMediaClient::requestUserMediaAccess):
798         (WebUserMediaClient::enumerateMediaDevices):
799         (WebUserMediaClient::cancelMediaDevicesEnumerationRequest):
800         (-[WebUserMediaPolicyListener allow]):
801         (-[WebUserMediaPolicyListener deny]):
802         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
803         (-[WebUserMediaPolicyCheckerListener cancelMediaDevicesEnumerationRequest]):
804         (-[WebUserMediaPolicyCheckerListener allow]):
805         (-[WebUserMediaPolicyCheckerListener deny]):
806         (WebUserMediaClient::checkUserMediaPermission): Deleted.
807         (WebUserMediaClient::cancelUserMediaPermissionCheck): Deleted.
808         (-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]): Deleted.
809         (-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]): Deleted.
810
811 2016-10-17  Antti Koivisto  <antti@apple.com>
812
813         Rename setNeedsStyleRecalc to invalidateStyle
814         https://bugs.webkit.org/show_bug.cgi?id=163542
815
816         Reviewed by Darin Adler.
817
818         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
819         (-[WebHostedNetscapePluginView createPluginLayer]):
820         * Plugins/WebNetscapePluginView.mm:
821         (-[WebNetscapePluginView createPlugin]):
822
823 2016-10-17  Jeremy Jones  <jeremyj@apple.com>
824
825         Enable keyboard in fullscreen.
826         https://bugs.webkit.org/show_bug.cgi?id=163146
827
828         Reviewed by Jer Noble.
829
830         Allow keyboard in fullscreen.
831
832         * WebView/WebView.mm:
833         (-[WebView _supportsFullScreenForElement:withKeyboard:]):
834
835 2016-10-17  Chris Dumez  <cdumez@apple.com>
836
837         Move form.reportValidity() behind InteractiveFormValidation setting
838         https://bugs.webkit.org/show_bug.cgi?id=163550
839
840         Reviewed by Darin Adler.
841
842         Enable InteractiveFormValidation setting by default and link it to
843         RuntimeEnabledFeatures so we can use it in the IDL.
844
845         * WebView/WebView.mm:
846         (-[WebView _preferencesChanged:]):
847         * WebView/WebViewData.mm:
848         (-[WebViewPrivate init]):
849
850 2016-10-17  Anders Carlsson  <andersca@apple.com>
851
852         Fix iOS build.
853
854         * History/WebBackForwardList.mm:
855         (-[WebBackForwardList dictionaryRepresentation]):
856
857 2016-10-17  Anders Carlsson  <andersca@apple.com>
858
859         CTTE some of the BackForwardList member functions
860         https://bugs.webkit.org/show_bug.cgi?id=163555
861
862         Reviewed by Dan Bernstein.
863
864         * History/BackForwardList.h:
865         (BackForwardList::entries):
866         * History/BackForwardList.mm:
867         (BackForwardList::removeItem):
868         (BackForwardList::containsItem):
869         (BackForwardList::entries): Deleted.
870         * History/WebBackForwardList.mm:
871         (-[WebBackForwardList removeItem:]):
872         (-[WebBackForwardList containsItem:]):
873         (-[WebBackForwardList description]):
874
875 2016-10-17  Anders Carlsson  <andersca@apple.com>
876
877         Remove WEBCORE_EXPORT from BackForwardList, it lives in WebKit now
878         https://bugs.webkit.org/show_bug.cgi?id=163551
879
880         Reviewed by Tim Horton.
881
882         * History/BackForwardList.h:
883
884 2016-10-16  Darin Adler  <darin@apple.com>
885
886         Move CSS classes from ExceptionCode to Exception
887         https://bugs.webkit.org/show_bug.cgi?id=163494
888
889         Reviewed by Sam Weinig.
890
891         * DOM/DOMCSSMediaRule.mm:
892         (-[DOMCSSMediaRule insertRule:index:]): Use raiseOnDOMError
893         the new way to handle ExceptionOr instead of ExceptionCode.
894         (-[DOMCSSMediaRule deleteRule:]): Ditto.
895         * DOM/DOMCSSPrimitiveValue.mm:
896         (-[DOMCSSPrimitiveValue setFloatValue:floatValue:]): Ditto.
897         (-[DOMCSSPrimitiveValue getFloatValue:]): Ditto.
898         (-[DOMCSSPrimitiveValue setStringValue:stringValue:]): Ditto.
899         (-[DOMCSSPrimitiveValue getStringValue]): Ditto.
900         (-[DOMCSSPrimitiveValue getCounterValue]): Ditto.
901         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
902         (-[DOMCSSPrimitiveValue getRGBColorValue]): Ditto.
903         * DOM/DOMCSSRule.mm:
904         (-[DOMCSSRule setCssText:]): Ditto.
905         * DOM/DOMCSSStyleDeclaration.mm:
906         (-[DOMCSSStyleDeclaration setCssText:]): Ditto.
907         (-[DOMCSSStyleDeclaration removeProperty:]): Ditto.
908         (-[DOMCSSStyleDeclaration setProperty:value:priority:]): Ditto.
909         * DOM/DOMCSSStyleSheet.mm:
910         (-[DOMCSSStyleSheet insertRule:index:]): Ditto.
911         (-[DOMCSSStyleSheet deleteRule:]): Ditto.
912         (-[DOMCSSStyleSheet addRule:style:index:]): Ditto.
913         (-[DOMCSSStyleSheet removeRule:]): Ditto.
914         * DOM/DOMCSSValue.mm:
915         (-[DOMCSSValue setCssText:]): Ditto.
916         * DOM/DOMMediaList.mm:
917         (-[DOMMediaList setMediaText:]): Ditto.
918         (-[DOMMediaList deleteMedium:]): Ditto.
919         (-[DOMMediaList appendMedium:]): Ditto.
920
921         * DOM/ExceptionHandlers.h: Added an overload of raiseDOMException
922         that works with a WebCore::Exception&& and overloads of
923         raiseOnDOMError that work with WebCore::ExceptionOr&&.
924         * DOM/ExceptionHandlers.mm:
925         (raiseDOMException): Implemented the new version.
926
927 2016-10-15  Dan Bernstein  <mitz@apple.com>
928
929         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
930         https://bugs.webkit.org/show_bug.cgi?id=163492
931         <rdar://problem/28654799>
932
933         Reviewed by Darin Adler.
934
935         Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm
936
937         * WebView/WebHTMLView.mm:
938         (createMenuItem): Set the tag for items that have submenus as well.
939
940 2016-10-14  Anders Carlsson  <andersca@apple.com>
941
942         Clean up BackForwardClient
943         https://bugs.webkit.org/show_bug.cgi?id=163454
944
945         Reviewed by Sam Weinig.
946
947         * History/BackForwardList.h:
948         Remove override keywords.
949
950         * History/BackForwardList.mm:
951         (BackForwardList::clearAllPageCaches): Deleted.
952         Remove this, it's no longer used.
953
954         * WebView/WebView.mm:
955         (-[WebView _clearBackForwardCache]): Deleted.
956         * WebView/WebViewPrivate.h:
957         Remove SPI that's no longer used by anyone.
958
959 2016-10-13  Anders Carlsson  <andersca@apple.com>
960
961         Move BackForwardList from WebCore to WebKitLegacy
962         https://bugs.webkit.org/show_bug.cgi?id=163418
963
964         Reviewed by Tim Horton.
965
966         * History/BackForwardList.h: Renamed from Source/WebCore/history/BackForwardList.h.
967         (BackForwardList::create):
968         (BackForwardList::webView):
969         * History/BackForwardList.mm: Renamed from Source/WebCore/history/BackForwardList.cpp.
970         (BackForwardList::BackForwardList):
971         (BackForwardList::close):
972         (BackForwardList::containsItem):
973         * History/WebBackForwardList.mm:
974         (kit):
975         (-[WebBackForwardList initWithBackForwardList:]):
976         (-[WebBackForwardList setPageCacheSize:]):
977         (-[WebBackForwardList pageCacheSize]):
978         * History/WebBackForwardListInternal.h:
979         * WebCoreSupport/WebFrameLoaderClient.mm:
980         * WebView/WebFrameView.mm:
981         * WebView/WebView.mm:
982         (-[WebView _commonInitializationWithFrameName:groupName:]):
983         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
984
985 2016-10-13  Anders Carlsson  <andersca@apple.com>
986
987         Get rid of the HistoryItemVector typedef
988         https://bugs.webkit.org/show_bug.cgi?id=163398
989
990         Reviewed by Beth Dakin.
991
992         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
993
994         * History/WebBackForwardList.mm:
995         (-[WebBackForwardList dictionaryRepresentation]):
996         (vectorToNSArray):
997         (-[WebBackForwardList backListWithLimit:]):
998         (-[WebBackForwardList forwardListWithLimit:]):
999         (-[WebBackForwardList description]):
1000         * History/WebHistoryItem.mm:
1001         (-[WebHistoryItem description]):
1002
1003 2016-10-12  Chris Dumez  <cdumez@apple.com>
1004
1005         [Web IDL] Drop support for legacy [ConstructorConditional=*]
1006         https://bugs.webkit.org/show_bug.cgi?id=163368
1007
1008         Reviewed by Ryosuke Niwa.
1009
1010         Drop ENABLE_DOM4_EVENTS_CONSTRUCTOR compiler flag.
1011
1012         * Configurations/FeatureDefines.xcconfig:
1013
1014 2016-10-12  Beth Dakin  <bdakin@apple.com>
1015
1016         Adobe Contribute CS 6.5 Trial crashes on launch
1017         https://bugs.webkit.org/show_bug.cgi?id=163365
1018         -and corresponding-
1019         <rdar://problem/28732731>
1020
1021         Reviewed by Tim Horton.
1022
1023         * Carbon/CarbonWindowFrame.m:
1024         (-[CarbonWindowFrame contentFill]):
1025
1026 2016-10-11  Daniel Bates  <dabates@apple.com>
1027
1028         Attempt to fix the Apple Internal Mac build following r207159
1029         (https://bugs.webkit.org/show_bug.cgi?id=163244)
1030
1031         * WebView/WebView.mm:
1032         (shouldRequireUserGestureToLoadVideo):
1033
1034 2016-10-11  Daniel Bates  <dabates@apple.com>
1035
1036         REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
1037         https://bugs.webkit.org/show_bug.cgi?id=163259
1038         <rdar://problem/28680515>
1039
1040         Reviewed by Jer Noble.
1041
1042         In WebKit1 on iOS we want to require user action to load and play videos by default and
1043         allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
1044         Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
1045         can load and play without being initiated by a user action.
1046
1047         * WebView/WebPreferences.mm:
1048         (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
1049         WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
1050         preference takes precedence over the values of its replacement preferences
1051         WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
1052
1053 2016-10-11  Daniel Bates  <dabates@apple.com>
1054
1055         [iOS] REGRESSION (r197953): User gesture required to load video in iOS 9-built apps
1056         https://bugs.webkit.org/show_bug.cgi?id=163244
1057         <rdar://problem/27250015>
1058
1059         Reviewed by Jer Noble.
1060
1061         Enable or disable the Setting::requiresUserGestureToLoadVideo() in legacy WebKit depending
1062         on the version of iOS SDK that the app was linked against. We require a user gesture to
1063         begin loading a video as of iOS 10.
1064
1065         * WebView/WebView.mm:
1066         (shouldRequireUserGestureToLoadVideo):
1067         (-[WebView _preferencesChanged:]): Modified to pass the WebKit requiresUserGestureToLoadVideo
1068         preference to WebCore.
1069
1070 2016-10-11  Alex Christensen  <achristensen@webkit.org>
1071
1072         Remove dead networking code
1073         https://bugs.webkit.org/show_bug.cgi?id=163263
1074
1075         Reviewed by Daniel Bates.
1076
1077         * Misc/WebDownload.mm:
1078         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1079         * Misc/WebDownloadInternal.h:
1080         * WebCoreSupport/WebFrameLoaderClient.mm:
1081         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1082         * WebView/WebPreferences.mm:
1083         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
1084         * WebView/WebView.mm:
1085         (-[WebView scheduleInRunLoop:forMode:]):
1086         (-[WebView unscheduleFromRunLoop:forMode:]):
1087
1088 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
1089
1090         Add ENABLE_ENCRYPTED_MEDIA configuration option
1091         https://bugs.webkit.org/show_bug.cgi?id=163219
1092
1093         Reviewed by Darin Adler.
1094
1095         * Configurations/FeatureDefines.xcconfig:
1096         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
1097         to enable or disable the new EME implementation at build-time.
1098
1099 2016-10-10  Darin Adler  <darin@apple.com>
1100
1101         Move NotificationCenter from legacy to new DOM exceptions
1102         https://bugs.webkit.org/show_bug.cgi?id=163217
1103
1104         Reviewed by Chris Dumez.
1105
1106         * WebView/WebView.mm:
1107         (-[WebView _notificationIDForTesting:]): Pass reference to page rather than pointer.
1108
1109 2016-10-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1110
1111         Support InputEvent.inputType for the new InputEvent spec
1112         https://bugs.webkit.org/show_bug.cgi?id=163025
1113         <rdar://problem/28658092>
1114
1115         Reviewed by Darin Adler.
1116
1117         Accounts for some changes to the EditAction enum in nameForEditAction. See WebCore ChangeLog
1118         entry for more details.
1119
1120         * WebCoreSupport/WebEditorClient.mm:
1121         (undoNameForEditAction):
1122
1123 2016-10-06  Darin Adler  <darin@apple.com>
1124
1125         Next step on moving to modern way to return DOM exceptions
1126         https://bugs.webkit.org/show_bug.cgi?id=163016
1127
1128         Reviewed by Ryosuke Niwa.
1129
1130         * DOM/DOMDOMImplementation.mm:
1131         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated for
1132         name change from takeReturnValue to releaseReturnValue.
1133         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
1134
1135 2016-10-07  Simon Fraser  <simon.fraser@apple.com>
1136
1137         [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
1138         https://bugs.webkit.org/show_bug.cgi?id=163154
1139         rdar://problem/28674216
1140
1141         Reviewed by Tim Horton.
1142         
1143         r55159 added code to counteract AppKit's adjustment of dirty regions during scrolling,
1144         by offsetting the dirty rect in -setNeedsDisplayInRect: if the call happens during
1145         the NSViewBoundsDidChangeNotification handling.
1146         
1147         However, AppKit only does dirty region adjustment in the code path that blits ("copy
1148         on scroll"), so r55159 produces incorrect behavior in, for example, layer-backed views.
1149         
1150         Fix by overriding -[NSClipView _canCopyOnScrollForDeltaX:deltaY:] to know if a single
1151         scroll is going to blit, and only do adjustments in -setNeedsDisplayInRect: if it is.
1152
1153         * WebView/WebClipView.h:
1154         * WebView/WebClipView.mm:
1155         (-[WebClipView _immediateScrollToPoint:]):
1156         (-[WebClipView _canCopyOnScrollForDeltaX:deltaY:]):
1157         (-[WebClipView currentScrollIsBlit]):
1158         * WebView/WebHTMLView.mm:
1159         (-[WebHTMLView setNeedsDisplayInRect:]):
1160         (-[WebHTMLView drawRect:]):
1161
1162 2016-10-06  Youenn Fablet  <youenn@apple.com>
1163
1164         CachedResource client handling methods should take reference
1165         https://bugs.webkit.org/show_bug.cgi?id=163014
1166
1167         Reviewed by Alex Christensen.
1168
1169         * WebView/WebHTMLView.mm:
1170         (promisedDataClient):
1171
1172 2016-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1173
1174         Put variation fonts work behind a compile-time flag
1175         https://bugs.webkit.org/show_bug.cgi?id=162949
1176
1177         Reviewed by Simon Fraser.
1178
1179         * Configurations/FeatureDefines.xcconfig:
1180
1181 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
1182
1183         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
1184         https://bugs.webkit.org/show_bug.cgi?id=162903
1185
1186         Reviewed by Alex Christensen.
1187
1188         Rename build guards for the remaining implementation of the legacy EME API
1189         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
1190         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
1191
1192         * Configurations/FeatureDefines.xcconfig:
1193         * WebView/WebPreferences.mm:
1194         (+[WebPreferences initialize]):
1195         * WebView/WebView.mm:
1196         (-[WebView _preferencesChanged:]):
1197
1198 2016-10-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1199
1200         The dragged image should be the current frame only of the animated image
1201         https://bugs.webkit.org/show_bug.cgi?id=162109
1202
1203         Reviewed by Tim Horton.
1204
1205         * DOM/DOM.mm:
1206         (-[DOMElement image]): Call the Image function with its new name.
1207         (-[DOMElement _imageTIFFRepresentation]): Ditto.
1208         * Misc/WebElementDictionary.mm:
1209         (-[WebElementDictionary _image]): Call the Image function with its new name.
1210         * Misc/WebIconDatabase.mm:
1211         (-[WebIconDatabase defaultIconWithSize:]): Call snapshotNSImage() to create the icon image.
1212         (webGetNSImage): Call the Image function with its new name.
1213         * WebCoreSupport/WebContextMenuClient.mm:
1214         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call snapshotNSImage() instead of nsImage()..
1215         (WebContextMenuClient::contextMenuForEvent): Ditto.
1216         * WebView/WebHTMLView.mm:
1217         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
1218
1219 2016-10-02  Ryan Haddad  <ryanhaddad@apple.com>
1220
1221         Unreviewed, rolling out r206683.
1222
1223         This change caused API test WebKit2.FindMatches to fail on
1224         Mac.
1225
1226         Reverted changeset:
1227
1228         "The dragged image should be the current frame only of the
1229         animated image"
1230         https://bugs.webkit.org/show_bug.cgi?id=162109
1231         http://trac.webkit.org/changeset/206683
1232
1233 2016-09-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
1234
1235         The dragged image should be the current frame only of the animated image
1236         https://bugs.webkit.org/show_bug.cgi?id=162109
1237
1238         Reviewed by Tim Horton.
1239
1240         * DOM/DOM.mm:
1241         (-[DOMElement image]): Call the Image function with its new name.
1242         (-[DOMElement _imageTIFFRepresentation]): Ditto.
1243         * Misc/WebElementDictionary.mm:
1244         (-[WebElementDictionary _image]): Call the Image function with its new name.
1245         * Misc/WebIconDatabase.mm:
1246         (-[WebIconDatabase defaultIconWithSize:]): Call currentFrameNSImage() to create the icon image.
1247         (webGetNSImage): Call the Image function with its new name.
1248         * WebCoreSupport/WebContextMenuClient.mm:
1249         (WebContextMenuClient::imageForCurrentSharingServicePickerItem): Call currentFrameNSImage() instead of nsImage()..
1250         (WebContextMenuClient::contextMenuForEvent): Ditto.
1251         * WebView/WebHTMLView.mm:
1252         (-[WebHTMLView pasteboard:provideDataForType:]): Call the Image function with its new name.
1253
1254 2016-09-27  Jer Noble  <jer.noble@apple.com>
1255
1256         Remove deprecated ENCRYPTED_MEDIA implementation.
1257         https://bugs.webkit.org/show_bug.cgi?id=161010
1258
1259         Remove ENABLE_ENCRYPTED_MEDIA.
1260
1261         Reviewed by Eric Carlson.
1262
1263         * Configurations/FeatureDefines.xcconfig:
1264
1265 2016-09-26  Daniel Bates  <dabates@apple.com>
1266
1267         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
1268         https://bugs.webkit.org/show_bug.cgi?id=162365
1269
1270         Reviewed by Simon Fraser.
1271
1272         * Configurations/FeatureDefines.xcconfig:
1273         * WebView/WebFrame.mm:
1274         * WebView/WebPreferences.mm:
1275         (+[WebPreferences initialize]):
1276         * WebView/WebView.mm:
1277         (-[WebView _preferencesChanged:]):
1278
1279 2016-09-25  Antti Koivisto  <antti@apple.com>
1280
1281         AuthorStyleSheets shouldn't trigger synchronous style resolutions
1282         https://bugs.webkit.org/show_bug.cgi?id=162532
1283
1284         Reviewed by Darin Adler.
1285
1286         * WebView/WebHTMLView.mm:
1287         (-[WebHTMLView reapplyStyles]):
1288         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1289
1290 2016-09-24  Antti Koivisto  <antti@apple.com>
1291
1292         Move stylesheet change logic from Document to AuthorStyleSheets
1293         https://bugs.webkit.org/show_bug.cgi?id=162488
1294
1295         Reviewed by Andreas Kling.
1296
1297         * WebView/WebHTMLView.mm:
1298         (-[WebHTMLView reapplyStyles]):
1299         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1300
1301 2016-09-23  Caitlin Potter  <caitp@igalia.com>
1302
1303         [JSC] Implement parsing of Async Functions
1304         https://bugs.webkit.org/show_bug.cgi?id=161409
1305
1306         Reviewed by Yusuke Suzuki.
1307
1308         * Configurations/FeatureDefines.xcconfig:
1309
1310 2016-09-23  Commit Queue  <commit-queue@webkit.org>
1311
1312         Unreviewed, rolling out r206311.
1313         https://bugs.webkit.org/show_bug.cgi?id=162495
1314
1315         Broke internal iOS build (Requested by anttik on #webkit).
1316
1317         Reverted changeset:
1318
1319         "Move stylesheet change logic from Document to
1320         AuthorStyleSheets"
1321         https://bugs.webkit.org/show_bug.cgi?id=162488
1322         http://trac.webkit.org/changeset/206311
1323
1324 2016-09-23  Antoine Quint  <graouts@apple.com>
1325
1326         Add a new runtime flag for work on modern media controls (off by default)
1327         https://bugs.webkit.org/show_bug.cgi?id=162420
1328         <rdar://problem/27989489>
1329
1330         Reviewed by Eric Carlson.
1331
1332         * WebView/WebPreferenceKeysPrivate.h:
1333         * WebView/WebPreferences.mm:
1334         (-[WebPreferences modernMediaControlsEnabled]):
1335         (-[WebPreferences setModernMediaControlsEnabled:]):
1336         * WebView/WebPreferencesPrivate.h:
1337         * WebView/WebView.mm:
1338         (-[WebView _preferencesChanged:]):
1339
1340 2016-09-21  Anders Carlsson  <andersca@apple.com>
1341
1342         Support openPaymentSetup API on ApplePaySession object
1343         https://bugs.webkit.org/show_bug.cgi?id=162357
1344         rdar://problem/26776939
1345
1346         Reviewed by Tim Horton.
1347
1348         Add openPaymentSetup stub.
1349
1350         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1351         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1352         (WebPaymentCoordinatorClient::openPaymentSetup):
1353
1354 2016-09-19  Daniel Bates  <dabates@apple.com>
1355
1356         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
1357         https://bugs.webkit.org/show_bug.cgi?id=162167
1358
1359         Reviewed by Simon Fraser.
1360
1361         * Configurations/FeatureDefines.xcconfig:
1362
1363 2016-09-19  Joseph Pecoraro  <pecoraro@apple.com>
1364
1365         Web Inspector: Bring the inspected page's window forward when activating element search
1366         https://bugs.webkit.org/show_bug.cgi?id=162114
1367         <rdar://problem/28349357>
1368
1369         Reviewed by Brian Burg.
1370
1371         * WebCoreSupport/WebInspectorClient.mm:
1372         (WebInspectorClient::didSetSearchingForNode):
1373         When element search is activated bring the window
1374         containing the inspected page to the foreground.
1375
1376 2016-09-15  Brady Eidson  <beidson@apple.com>
1377
1378         WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
1379         <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
1380
1381         Reviewed by Brent Fulgham. 
1382
1383         * WebCoreSupport/WebFrameLoaderClient.h:
1384         * WebCoreSupport/WebFrameLoaderClient.mm:
1385         (WebFrameLoaderClient::dispatchDidCommitLoad):
1386
1387 2016-09-15  Anders Carlsson  <andersca@apple.com>
1388
1389         This was supposed to be committed with the previous patch!
1390
1391         * Plugins/WebBasePluginPackage.mm:
1392         (pathByResolvingSymlinksAndAliases): Deleted.
1393
1394 2016-09-15  Anders Carlsson  <andersca@apple.com>
1395
1396         Replace use of Carbon file system APIs in plug-in loading
1397         https://bugs.webkit.org/show_bug.cgi?id=162040
1398         rdar://problem/6017896
1399
1400         Reviewed by Sam Weinig.
1401
1402         * Plugins/WebBasePluginPackage.mm:
1403         (-[WebBasePluginPackage initWithPath:]):
1404         Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
1405         to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).
1406
1407 2016-09-15  Beth Dakin  <bdakin@apple.com>
1408
1409         Need hasMarkedText on Mac
1410         https://bugs.webkit.org/show_bug.cgi?id=162026
1411         -and corresponding-
1412         rdar://problem/28272353
1413
1414         Reviewed by Anders Carlsson.
1415
1416         * WebView/WebHTMLViewInternal.h:
1417
1418 2016-09-12  Dean Jackson  <dino@apple.com>
1419
1420         Replace RGBA32 with Color in member variables
1421         https://bugs.webkit.org/show_bug.cgi?id=161856
1422         <rdar://problem/28254324>
1423
1424         Reviewed by Simon Fraser.
1425
1426         In preparation for the Color class to become more than
1427         just a 4-byte RGBA value, I went through a few places
1428         that were using the RGBA32 type directly, and replaced
1429         them with Color. This will make some objects a little
1430         bigger e.g. BorderValue and its friends.
1431
1432         I mostly looked at the places that were using RGBA32 as
1433         a member variable. There is still a lot of RGBA32 use
1434         around the project, in particular the CSS parser.
1435
1436         There should be no behaviour change.
1437
1438         * Misc/WebKitNSStringExtras.mm:
1439         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Explicitly
1440         call a Color constructor, rather than passing an RGBA32.
1441
1442 2016-09-13  Chris Dumez  <cdumez@apple.com>
1443
1444         Drop support for <isindex>
1445         https://bugs.webkit.org/show_bug.cgi?id=7139
1446
1447         Reviewed by Ryosuke Niwa.
1448
1449         Drop references to isindex.
1450
1451         * WebCoreSupport/WebEditorClient.mm:
1452         (attributesForAttributedStringConversion):
1453         * WebView/WebHTMLView.mm:
1454         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1455
1456 2016-09-12  Chris Dumez  <cdumez@apple.com>
1457
1458         Switch remaining users of Document::inPageCache() to pageCacheState()
1459         https://bugs.webkit.org/show_bug.cgi?id=161865
1460
1461         Reviewed by Darin Adler.
1462
1463         Switch remaining users of Document::inPageCache() to pageCacheState() as
1464         the former one is confusing (given that it returns true while the
1465         pagehide event is being fired).
1466
1467         * WebView/WebHTMLView.mm:
1468         (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]):
1469         (-[WebHTMLView setNeedsLayout:]):
1470         (-[WebHTMLView setNeedsToApplyStyles:]):
1471
1472 2016-09-09  Tim Horton  <timothy_horton@apple.com>
1473
1474         Text replacement candidates don't always overwrite the entire original string
1475         https://bugs.webkit.org/show_bug.cgi?id=161779
1476         <rdar://problem/28033492>
1477
1478         Reviewed by Simon Fraser.
1479
1480         * WebCoreSupport/WebEditorClient.mm:
1481         (WebEditorClient::requestCandidatesForSelection):
1482         Make use of the shared implementation of contextRangeForCandidateRequest.
1483
1484 2016-09-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
1485
1486         Move the BitmapImage platform dependent code to a new file named NativeImage[CG|Cairo].cpp
1487         https://bugs.webkit.org/show_bug.cgi?id=158684
1488
1489         Reviewed by Simon Fraser.
1490
1491         * DOM/DOM.mm:
1492         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1493         * Misc/WebCache.mm:
1494         (+[WebCache imageForURL:]):
1495         Replace BitmapImage::getCGImageRef() with BitmapImage::nativeImage().
1496
1497 2016-09-07  Joseph Pecoraro  <pecoraro@apple.com>
1498
1499         [Mac] Address some clang static analyzer warnings in WebKit
1500         https://bugs.webkit.org/show_bug.cgi?id=161597
1501
1502         Reviewed by Darin Adler.
1503
1504         * Misc/WebIconDatabase.h:
1505         Remove unused instance variable. It has not been used since r16005 (2006)!
1506
1507         * Misc/WebSharingServicePickerController.mm:
1508         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1509         Address array leak.
1510
1511         * WebCoreSupport/WebSelectionServiceController.mm:
1512         (WebSelectionServiceController::hasRelevantSelectionServices):
1513         Address attachment and cell leak.
1514
1515         * WebView/WebFullScreenController.h:
1516         * WebView/WebImmediateActionController.h:
1517         Remove unused instance variables.
1518
1519 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
1520
1521         Enable the <meter> element on iOS
1522         https://bugs.webkit.org/show_bug.cgi?id=161714
1523         rdar://problem/8978410
1524
1525         Reviewed by Tim Horton.
1526
1527         Define ENABLE_METER_ELEMENT unconditionally now.
1528
1529         * Configurations/FeatureDefines.xcconfig:
1530
1531 2016-09-07  Mark Lam  <mark.lam@apple.com>
1532
1533         Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
1534         https://bugs.webkit.org/show_bug.cgi?id=161498
1535
1536         Reviewed by Geoffrey Garen.
1537
1538         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1539         (WebKit::NetscapePluginInstanceProxy::evaluate):
1540         (WebKit::NetscapePluginInstanceProxy::invoke):
1541         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1542         (WebKit::NetscapePluginInstanceProxy::construct):
1543         (WebKit::NetscapePluginInstanceProxy::getProperty):
1544         (WebKit::NetscapePluginInstanceProxy::setProperty):
1545         (WebKit::NetscapePluginInstanceProxy::removeProperty):
1546         (WebKit::NetscapePluginInstanceProxy::hasProperty):
1547         (WebKit::NetscapePluginInstanceProxy::hasMethod):
1548         (WebKit::NetscapePluginInstanceProxy::enumerate):
1549         * WebView/WebView.mm:
1550         (aeDescFromJSValue):
1551
1552 2016-09-07  Youenn Fablet  <youenn@apple.com>
1553
1554         [Streams API] Separate compile flag for ReadableStream and WritableStream
1555         https://bugs.webkit.org/show_bug.cgi?id=161044
1556
1557         Reviewed by Alex Christensen.
1558
1559         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
1560
1561         * Configurations/FeatureDefines.xcconfig:
1562
1563 2016-09-06  Chris Dumez  <cdumez@apple.com>
1564
1565         Add support for input.minLength / textArea.minLength
1566         https://bugs.webkit.org/show_bug.cgi?id=161644
1567
1568         Reviewed by Darin Adler.
1569
1570         Update ObjC bindings to reflect method renaming.
1571
1572         * DOM/DOMHTMLInputElement.mm:
1573         (-[DOMHTMLInputElement maxLength]):
1574         (-[DOMHTMLInputElement setMaxLength:]):
1575         * DOM/DOMHTMLTextAreaElement.mm:
1576         (-[DOMHTMLTextAreaElement maxLength]):
1577         (-[DOMHTMLTextAreaElement setMaxLength:]):
1578
1579 2016-09-06  Dan Bernstein  <mitz@apple.com>
1580
1581         <rdar://problem/8064563> Ugly NSLog in DOMInternal.mm
1582
1583         Rubber-stamped by Anders Carlsson.
1584
1585         * DOM/DOMInternal.mm:
1586         (-[WebScriptObject _initializeScriptDOMNodeImp]): Removed useless call to NSLog.
1587
1588 2016-09-06  Ryan Haddad  <ryanhaddad@apple.com>
1589
1590         Unreviewed, rolling out r205407.
1591
1592         Not the correct way to implement this functionality
1593
1594         Reverted changeset:
1595
1596         "Consult with the FrameLoaderClient about whether or not
1597         content extensions should be enabled when loading this URL."
1598         https://bugs.webkit.org/show_bug.cgi?id=161441
1599         http://trac.webkit.org/changeset/205407
1600
1601 2016-09-05  Darin Adler  <darin@apple.com>
1602
1603         More bindings improvements, particularly things not needed for JavaScript bindings
1604         https://bugs.webkit.org/show_bug.cgi?id=161572
1605
1606         Reviewed by Sam Weinig.
1607
1608         * DOM/DOMDOMImplementation.mm:
1609         (-[DOMImplementation hasFeature:version:]): Call SVGTests::hasFeatureForLegacyBindings
1610         instead of DOMImplementation::hasFeature. Also removed JSMainThreadNullState
1611         since this does not do anything that can invoke JavaScript.
1612
1613         * DOM/DOMDocument.mm:
1614         (-[DOMDocument defaultCharset]): Call defaultCharsetForLegacyBindings. Also removed
1615         JSMainThreadNullState.
1616
1617         * DOM/DOMDocumentType.mm:
1618         (-[DOMDocumentType entities]): Changed to simply return nil; same behavior as before,
1619         but with no dependency on WebCore. Also removed JSMainThreadNullState.
1620         (-[DOMDocumentType notations]): Ditto.
1621         (-[DOMDocumentType internalSubset]): Ditto, except empty string rather than nil.
1622
1623         * DOM/DOMNode.mm:
1624         (-[DOMNode isSupported:version:]): Call SVGTests::hasFeatureForLegacyBindings
1625         instead of Node::isSupportedForBindings. Also removed JSMainThreadNullState.
1626
1627 2016-09-04  Joseph Pecoraro  <pecoraro@apple.com>
1628
1629         Remove unnecessary RetainPtr.
1630
1631         Review comments on earlier change.
1632
1633         * WebView/WebImmediateActionController.mm:
1634         (-[WebImmediateActionController _defaultAnimationController]):
1635
1636 2016-09-03  Darin Adler  <darin@apple.com>
1637
1638         Streamline DOMImplementation, and move it to our new DOM exception system
1639         https://bugs.webkit.org/show_bug.cgi?id=161295
1640
1641         Reviewed by Ryosuke Niwa.
1642
1643         * DOM/DOMDOMImplementation.mm:
1644         (unwrap): Added. Use this instead of the IMPL macro.
1645         (-[DOMImplementation dealloc]): Updated to use unwrap.
1646         (-[DOMImplementation hasFeature:version:]): Ditto.
1647         (-[DOMImplementation createDocumentType:publicId:systemId:]): Updated to work with
1648         ExceptionOr.
1649         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
1650         (-[DOMImplementation createCSSStyleSheet:media:]): Removed exception logic since
1651         this function can no longer raise an exception.
1652         (-[DOMImplementation createHTMLDocument:]): Updated to use unwrap.
1653         (-[DOMImplementation hasFeature::]): Changed to call the non-deprecated version
1654         rather than duplicating its implementation. Also moved into the category as defined
1655         in the header.
1656         (-[DOMImplementation createDocumentType:::]): Ditto.
1657         (-[DOMImplementation createDocument:::]): Ditto.
1658         (-[DOMImplementation createCSSStyleSheet::]): Ditto.
1659
1660         * DOM/DOMDocument.mm: Removed unneeded include of DOMImplementation.h.
1661         (-[DOMDocument setXmlStandalone:]): Updated since setXMLStandalone no longer can
1662         raise an exception.
1663
1664         * WebView/WebFrame.mm:
1665         (-[WebFrame _canProvideDocumentSource]): Updated to use isTextMIMEType in its new
1666         location in MIMETypeRegistry instead of in DOMImplementation.
1667
1668 2016-09-03  Brian Weinstein  <bweinstein@apple.com>
1669
1670         Implement a stub version of FrameLoaderClient::shouldUseContentExtensionsForURL.
1671         https://bugs.webkit.org/show_bug.cgi?id=16144
1672
1673         Reviewed by Darin Adler.
1674
1675         * WebCoreSupport/WebFrameLoaderClient.h:
1676
1677 2016-09-02  Beth Dakin  <bdakin@apple.com>
1678
1679         Need to updateEditorState if an element change edit-ability without changing 
1680         selection
1681         https://bugs.webkit.org/show_bug.cgi?id=161546
1682         -and corresponding-
1683         rdar://problem/27806012
1684
1685         Reviewed by Ryosuke Niwa.
1686
1687         Every time WebEditorClient::respondToChangedSelection is called, we now save 
1688         whether the last state was contentEditable. That way in 
1689         updateEditorStateAfterLayoutIfNeeded() we can assess whether or not edit-ability 
1690         has changed. 
1691
1692         * WebCoreSupport/WebEditorClient.h:
1693         * WebCoreSupport/WebEditorClient.mm:
1694         (WebEditorClient::respondToChangedSelection):
1695         (WebEditorClient:: updateEditorStateAfterLayoutIfEditabilityChanged):
1696
1697 2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
1698
1699         [Mac] RetainPtr misuse, AnimationController leaks
1700         https://bugs.webkit.org/show_bug.cgi?id=161552
1701
1702         Reviewed by Tim Horton.
1703
1704         * WebView/WebImmediateActionController.mm:
1705         (-[WebImmediateActionController _defaultAnimationController]):
1706
1707 2016-07-08  Jer Noble  <jer.noble@apple.com>
1708
1709         Refactor WebPlaybackSessionModelMediaElement to be client based.
1710         https://bugs.webkit.org/show_bug.cgi?id=159580
1711
1712         Reviewed by Eric Carlson.
1713
1714         No longer necessary to tell the models and interfaces about each other.
1715
1716         * WebView/WebView.mm:
1717         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1718         (-[WebView _clearPlaybackControlsManager]):
1719
1720 2016-09-01  Dan Bernstein  <mitz@apple.com>
1721
1722         Build fix.
1723
1724         * Configurations/FeatureDefines.xcconfig:
1725
1726 2016-09-01  Myles C. Maxfield  <mmaxfield@apple.com>
1727
1728         Clean up TextRun-related code
1729         https://bugs.webkit.org/show_bug.cgi?id=161473
1730
1731         Reviewed by Simon Fraser.
1732
1733         Remove unused #includes.
1734
1735         * WebCoreSupport/WebDragClient.mm:
1736         * WebView/WebView.mm:
1737
1738 2016-08-31  Keith Rollin  <krollin@apple.com>
1739
1740         WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
1741         https://bugs.webkit.org/show_bug.cgi?id=160969
1742         <rdar://problem/26068734>
1743
1744         Reviewed by Simon Fraser.
1745
1746         Enable subsystem- and channel-related data and functions when using
1747         RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
1748         and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
1749
1750         * Misc/WebKitLogging.h:
1751         * Misc/WebKitLogging.m:
1752         * WebView/WebView.mm:
1753         (-[WebView _commonInitializationWithFrameName:groupName:]):
1754
1755 2016-08-31  Brady Eidson  <beidson@apple.com>
1756
1757         WK2 Gamepad provider on iOS.
1758         https://bugs.webkit.org/show_bug.cgi?id=161412
1759
1760         Reviewed by Tim Horton.
1761
1762         * Configurations/FeatureDefines.xcconfig:
1763
1764         * WebView/WebView.mm:
1765         (WebKitInitializeGamepadProviderIfNecessary):
1766
1767 2016-08-30  Mark Lam  <mark.lam@apple.com>
1768
1769         Introduce the ThrowScope and force every throw site to instantiate a ThrowScope.
1770         https://bugs.webkit.org/show_bug.cgi?id=161171
1771
1772         Reviewed by Filip Pizlo and Geoffrey Garen.
1773
1774         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1775         (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
1776         * Plugins/Hosted/ProxyInstance.mm:
1777         (WebKit::ProxyInstance::invokeMethod):
1778
1779 2016-08-28  Andreas Kling  <akling@apple.com>
1780
1781         document.title setter can't throw.
1782         <https://webkit.org/b/161302>
1783
1784         Reviewed by Antti Koivisto.
1785
1786         * DOM/DOMDocument.mm:
1787         (-[DOMDocument setTitle:]):
1788
1789 2016-08-28  Andreas Kling  <akling@apple.com>
1790
1791         Clean up some .text attribute setters that don't throw.
1792         <https://webkit.org/b/161292>
1793
1794         Reviewed by Darin Adler.
1795
1796         * DOM/DOMHTMLTitleElement.mm:
1797         (-[DOMHTMLTitleElement setText:]):
1798
1799 2016-08-26  Sam Weinig  <sam@webkit.org>
1800
1801         Remove support for ENABLE_LEGACY_WEB_AUDIO
1802         https://bugs.webkit.org/show_bug.cgi?id=161262
1803
1804         Reviewed by Anders Carlsson.
1805
1806         * Configurations/FeatureDefines.xcconfig:
1807         Remove ENABLE_LEGACY_WEB_AUDIO
1808
1809 2016-08-25  Anders Carlsson  <andersca@apple.com>
1810
1811         Re-export DOMException NSStrings after r204717
1812         https://bugs.webkit.org/show_bug.cgi?id=161200
1813         <rdar://problem/27959937>
1814
1815         Reviewed by Alex Christensen.
1816
1817         * DOM/ExceptionHandlers.mm:
1818         (raiseDOMException):
1819         * WebKit.exp:
1820
1821 2016-08-22  Darin Adler  <darin@apple.com>
1822
1823         Move Objective-C DOM bindings from WebCore to legacy WebKit
1824         https://bugs.webkit.org/show_bug.cgi?id=160654
1825
1826         Reviewed by Alex Christensen.
1827
1828         * DOM: Added lots of files to the directory.
1829         The files are just as they were in bindings/objc except that the paths of includes
1830         have been updated as needed, and the code no longer is defined inside the WebCore
1831         namespace, requring changes to various functions and their call sites. Also removed
1832         all the WEBCORE_EXPORT since we export differently here in legacy WebKit.
1833
1834         * DOM/DOMInternal.h: Moved. Replaced createDOMWrapper with initializeDOMWrapperHooks.
1835         * DOM/DOMUtility.mm: Moved.
1836         (createDOMWrapper): Simplified to use toWrapped and not do unneeded namespace tricks.
1837         (disconnectWindowWrapper): Added.
1838         (initializeDOMWrapperHooks): Added.
1839
1840         * MigrateHeaders.make: Removed all the internal headers since they are now just
1841         normal project headers. Added the "DOM" directory to the VPATH. Some of the headers
1842         from WebCore are still being migrated, so we can't remove WebCorePrivateHeaders yet.
1843
1844         * WebCoreSupport/WebEditorClient.h: Updated to return RefPtr<DocumentFragment>.
1845
1846         * WebCoreSupport/WebEditorClient.mm:
1847         (WebEditorClient::documentFragmentFromDelegate): Use RefPtr.
1848
1849         * WebKit.exp: Added exports for all the classes that used to use WEBCORE_EXPORT to
1850         be exported from WebCore.
1851
1852         * WebView/WebFrame.mm:
1853         (-[WebFrame innerLineHeight:]): Moved code from WebCore::Frame::innerLineHeight here.
1854         No longer depend on whether this node happens to be in this frame. Also removed
1855         unneeded null check since a node's document can't be null.
1856
1857         * WebView/WebHTMLView.mm: Removed uneeded include of ExceptionHandlers.h, which
1858         is now here in WebKitLegacy instead of WebCore. But no need to include it at all.
1859
1860         * WebView/WebView.mm:
1861         (-[WebView _commonInitializationWithFrameName:groupName:]): Call
1862         initializeDOMWrapperHooks so WebScriptObject can create DOM binding wrappers when
1863         making a script object for a DOM object, rather than just a generic script object.
1864         (+[WebView enableWebThread]): Added a call to WebCoreObjCDeallocOnWebThread here for
1865         DOMObject along with the other classes. This was done in WebCore before, but DOMObject is now
1866         defined here in legacy WebKit.
1867         (-[WebView styleAtSelectionStart]): Moved code from WebCore::Frame::styleAtSelectionStart here.
1868         Replaced incorrect code that called "new PropertySetCSSStyleDeclaration" with a misleading comment
1869         about reference counting; that code was leaking all the style declarations. Instead use
1870         MutableStyleProperties::ensureCSSStyleDeclaration, which is designed for this purpose.
1871
1872 2016-08-22  Youenn Fablet  <youenn@apple.com>
1873
1874         [Fetch API] Activate fetch api runtime flag by default
1875         https://bugs.webkit.org/show_bug.cgi?id=160452
1876
1877         Reviewed by Alex Christensen.
1878
1879         * WebView/WebPreferences.mm:
1880         (+[WebPreferences initialize]):
1881
1882 2016-08-21  Alex Christensen  <achristensen@webkit.org>
1883
1884         Use Document& instead of Document* when getting cookies
1885         https://bugs.webkit.org/show_bug.cgi?id=161011
1886
1887         Reviewed by Darin Adler.
1888
1889         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1890         (WebKit::NetscapePluginInstanceProxy::getCookies):
1891         (WebKit::NetscapePluginInstanceProxy::setCookies):
1892         * Plugins/WebNetscapePluginView.mm:
1893         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1894         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1895
1896 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
1897
1898         Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
1899         https://bugs.webkit.org/show_bug.cgi?id=160923
1900
1901         Reviewed by Tim Horton.
1902
1903         * WebCoreSupport/WebFrameLoaderClient.h:
1904         * WebCoreSupport/WebFrameLoaderClient.mm:
1905         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1906         (WebFrameLoaderClient::dispatchDidLayout): Deleted.
1907
1908 2016-08-18  Daniel Bates  <dabates@apple.com>
1909
1910         Ld warns of non-existent PrivateFrameworks directory when building WebKit with the public iOS 9.3 SDK
1911         https://bugs.webkit.org/show_bug.cgi?id=160979
1912
1913         Rubber-stamped by Simon Fraser.
1914
1915         Only add the SDK PrivateFrameworks directory to the FRAMEWORK_SEARCH_PATH when building for
1916         iOS Simulator, building with an iOS SDK that does not support text-based stubs, or building
1917         an Apple-internal build.
1918
1919         * Configurations/WebKitLegacy.xcconfig:
1920
1921 2016-08-18  Anders Carlsson  <andersca@apple.com>
1922
1923         Move an NPAPI-only function from WebCore to WebKit
1924         https://bugs.webkit.org/show_bug.cgi?id=160967
1925
1926         Reviewed by Sam Weinig.
1927
1928         * Plugins/WebNetscapePluginView.h:
1929         * Plugins/WebNetscapePluginView.mm:
1930         (-[WebNetscapePluginView getVariable:value:]):
1931         (-[WebNetscapePluginView _destroyPlugin]):
1932
1933 2016-08-18  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
1934
1935         [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
1936         https://bugs.webkit.org/show_bug.cgi?id=156096
1937
1938         Reviewed by Dean Jackson.
1939
1940         Adds:
1941         - Setup interface for enabling runtime flag for Web animations through preferences.
1942
1943         * WebView/WebPreferenceKeysPrivate.h:
1944         * WebView/WebPreferences.mm:
1945         (+[WebPreferences initialize]):
1946         (-[WebPreferences webAnimationsEnabled]):
1947         (-[WebPreferences setWebAnimationsEnabled:]):
1948         * WebView/WebPreferencesPrivate.h:
1949         * WebView/WebView.mm:
1950         (-[WebView _preferencesChanged:]):
1951
1952 2016-08-17  Anders Carlsson  <andersca@apple.com>
1953
1954         Remove a couple of unused WKSI function pointers
1955         https://bugs.webkit.org/show_bug.cgi?id=160946
1956
1957         Reviewed by Dan Bernstein.
1958
1959         * WebCoreSupport/WebSystemInterface.mm:
1960         (InitWebCoreSystemInterface): Deleted.
1961
1962 2016-08-16  Daniel Bates  <dabates@apple.com>
1963
1964         WKSI static library should be named by major iOS revision, not individual updates
1965         https://bugs.webkit.org/show_bug.cgi?id=160727
1966         <rdar://problem/22274848>
1967
1968         Reviewed by Alexey Proskuryakov.
1969
1970         * Configurations/Base.xcconfig:
1971         * Configurations/DebugRelease.xcconfig:
1972         * Configurations/WebKitLegacy.xcconfig:
1973
1974 2016-08-16  Darin Adler  <darin@apple.com>
1975
1976         [Cocoa] Remove dependency on Objective-C bindings in WebKit2 editing code
1977         https://bugs.webkit.org/show_bug.cgi?id=160891
1978
1979         Reviewed by Anders Carlsson.
1980
1981         * WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
1982
1983         * WebCoreSupport/WebEditorClient.mm:
1984         (attributesForAttributedStringConversion): Replaced the
1985         createExcludedElementsForAttributedStringConversion function with this one.
1986         No good reason to keep the array around instead of the dictionary.
1987         (_WebCreateFragment): Renamed from documentFragmentFromAttributedString.
1988         This is now a global function exported so it can be called by WebCore with
1989         a different way of returning its value.
1990
1991         * WebKit.exp: Added _WebCreateFragment.
1992
1993         * WebView/WebHTMLView.mm:
1994         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1995         Removed long-ago-obsolete workaround for Radar bug 5052369.
1996
1997 2016-08-15  Anders Carlsson  <andersca@apple.com>
1998
1999         Another build fix.
2000
2001         * WebKit.exp:
2002
2003 2016-08-15  Anders Carlsson  <andersca@apple.com>
2004
2005         Fix build.
2006
2007         * Configurations/WebKitLegacy.xcconfig:
2008         * WebKit.mac.exp:
2009
2010 2016-08-15  Anders Carlsson  <andersca@apple.com>
2011
2012         Remove OldWebAssertions.c
2013         https://bugs.webkit.org/show_bug.cgi?id=160862
2014
2015         Reviewed by Dan Bernstein.
2016
2017         These functions were used by an old version of iWeb. The latest version of iWeb no longer uses them.
2018
2019         * Misc/OldWebAssertions.c: Removed.
2020         (WebReportAssertionFailure): Deleted.
2021         (WebReportError): Deleted.
2022
2023 2016-08-15  Anders Carlsson  <andersca@apple.com>
2024
2025         Remove WebKeyGenerator
2026         https://bugs.webkit.org/show_bug.cgi?id=160854
2027
2028         Reviewed by Dan Bernstein.
2029
2030         This SPI class is no longer used by Safari.
2031
2032         * WebCoreSupport/WebKeyGenerator.h: Removed.
2033         * WebCoreSupport/WebKeyGenerator.mm: Removed.
2034         (+[WebKeyGenerator sharedGenerator]): Deleted.
2035         (toWebCertificateParseResult): Deleted.
2036         (-[WebKeyGenerator addCertificatesToKeychainFromData:]): Deleted.
2037         * WebView/WebFrameView.mm:
2038
2039 2016-08-15  Daniel Bates  <dabates@apple.com>
2040
2041         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
2042         private frameworks and libraries
2043         https://bugs.webkit.org/show_bug.cgi?id=155931
2044         <rdar://problem/25807989>
2045
2046         Reviewed by Dan Bernstein.
2047
2048         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
2049         where X is the major version of the active iOS SDK.
2050
2051         * Configurations/WebKitLegacy.xcconfig:
2052
2053 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2054
2055         Add a setting and preferences to enable visual viewport mode
2056         https://bugs.webkit.org/show_bug.cgi?id=160843
2057
2058         Reviewed by Sam Weinig.
2059
2060         Hook up the visualViewportEnabled setting for WebKit1.
2061
2062         * WebView/WebPreferenceKeysPrivate.h:
2063         * WebView/WebPreferences.mm:
2064         (+[WebPreferences initialize]):
2065         (-[WebPreferences visualViewportEnabled]):
2066         (-[WebPreferences setVisualViewportEnabled:]):
2067         * WebView/WebPreferencesPrivate.h:
2068
2069 2016-08-15  Joseph Pecoraro  <pecoraro@apple.com>
2070
2071         Remove unused includes of wtf headers
2072         https://bugs.webkit.org/show_bug.cgi?id=160839
2073
2074         Reviewed by Alex Christensen.
2075
2076         * History/BinaryPropertyList.cpp:
2077         * History/WebBackForwardList.mm:
2078         * History/WebHistoryItemInternal.h:
2079         * Misc/WebNSFileManagerExtras.mm:
2080         * Plugins/Hosted/NetscapePluginHostProxy.h:
2081         * WebCoreSupport/WebPlatformStrategies.mm:
2082         * WebCoreSupport/WebSelectionServiceController.mm:
2083         * WebCoreSupport/WebUserMediaClient.h:
2084
2085 2016-08-12  Anders Carlsson  <andersca@apple.com>
2086
2087         Move the plug-in and WebGL blacklist code to WebCore
2088         https://bugs.webkit.org/show_bug.cgi?id=160831
2089
2090         Reviewed by Sam Weinig.
2091
2092         Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.
2093
2094         * WebCoreSupport/WebFrameLoaderClient.mm:
2095         (shouldBlockPlugin):
2096         (WebFrameLoaderClient::createPlugin):
2097         (WebFrameLoaderClient::createJavaAppletWidget):
2098         (shouldBlockWebGL):
2099         (WebFrameLoaderClient::webGLPolicyForURL):
2100         (WebFrameLoaderClient::resolveWebGLPolicyForURL):
2101
2102 2016-08-14  Daniel Bates  <dabates@apple.com>
2103
2104         Fix compiler errors when building iOS WebKit using the iOS 10 beta SDK
2105         https://bugs.webkit.org/show_bug.cgi?id=160725
2106
2107         Reviewed by Sam Weinig.
2108
2109         OSAtomicCompareAndSwap32() has been deprecated as of the iOS 10 beta SDK. For now,
2110         silence the complier warning.
2111
2112         * WebView/WebView.mm:
2113         (-[WebView _dispatchTileDidDraw:]):
2114
2115 2016-08-12  Joseph Pecoraro  <pecoraro@apple.com>
2116
2117         Remove always true JSC::Debugger::needPauseHandling virtual method
2118         https://bugs.webkit.org/show_bug.cgi?id=160822
2119
2120         Reviewed by Mark Lam.
2121
2122         * WebView/WebScriptDebugger.h:
2123
2124 2016-08-11  Chris Dumez  <cdumez@apple.com>
2125
2126         Regression(r204268): Mail crashes when trying to compose an email
2127         https://bugs.webkit.org/show_bug.cgi?id=160775
2128
2129         Reviewed by Anders Carlsson.
2130
2131         Properly initialize PageConfiguration.pluginInfoProvider in
2132         [WebView initSimpleHTMLDocumentWithStyle] to avoid a null
2133         dereference in Mail when trying to compose an email.
2134
2135         * WebView/WebView.mm:
2136         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2137
2138 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2139
2140         Sort the feature flags in the FEATURE_DEFINES lines
2141         https://bugs.webkit.org/show_bug.cgi?id=160742
2142
2143         Reviewed by Anders Carlsson.
2144
2145         * Configurations/FeatureDefines.xcconfig:
2146
2147 2016-08-09  Alex Christensen  <achristensen@webkit.org>
2148
2149         Move NetworkStorageSession management to WebCore
2150         https://bugs.webkit.org/show_bug.cgi?id=160173
2151
2152         Reviewed by Brady Eidson.
2153
2154         * WebCoreSupport/WebFrameNetworkingContext.mm:
2155         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2156         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2157         * WebCoreSupport/WebPlatformStrategies.mm:
2158         * WebView/WebView.mm:
2159
2160 2016-08-09  Anders Carlsson  <andersca@apple.com>
2161
2162         Instantiate WebKit plug-ins at layout time, instead of at style resolution time
2163         https://bugs.webkit.org/show_bug.cgi?id=160715
2164
2165         Reviewed by Tim Horton.
2166
2167         * WebCoreSupport/WebFrameLoaderClient.mm:
2168         (WebFrameLoaderClient::objectContentType):
2169
2170 2016-08-09  George Ruan  <gruan@apple.com>
2171
2172         Implement functionality of media capture on iOS
2173         https://bugs.webkit.org/show_bug.cgi?id=158945
2174         <rdar://problem/26893343>
2175
2176         Reviewed by Tim Horton.
2177
2178         * Configurations/FeatureDefines.xcconfig: Enable Media Capture feature
2179         for iOS.
2180
2181 2016-08-09  Anders Carlsson  <andersca@apple.com>
2182
2183         Get rid of PluginStrategy
2184         https://bugs.webkit.org/show_bug.cgi?id=160696
2185
2186         Reviewed by Dan Bernstein.
2187
2188         * WebCoreSupport/WebPlatformStrategies.h:
2189         * WebCoreSupport/WebPlatformStrategies.mm:
2190         (WebPlatformStrategies::createPluginStrategy): Deleted.
2191         * WebCoreSupport/WebPluginInfoProvider.h:
2192         * WebCoreSupport/WebPluginInfoProvider.mm:
2193         (WebPluginInfoProvider::setPluginLoadClientPolicy): Deleted.
2194         (WebPluginInfoProvider::clearPluginClientPolicies): Deleted.
2195
2196 2016-08-09  Anders Carlsson  <andersca@apple.com>
2197
2198         Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
2199         https://bugs.webkit.org/show_bug.cgi?id=160694
2200
2201         Reviewed by Dan Bernstein.
2202
2203         * WebCoreSupport/WebPlatformStrategies.h:
2204         * WebCoreSupport/WebPlatformStrategies.mm:
2205         (WebPlatformStrategies::createPluginStrategy):
2206         (WebPlatformStrategies::refreshPlugins): Deleted.
2207         (WebPlatformStrategies::getPluginInfo): Deleted.
2208         (WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
2209         (WebPlatformStrategies::setPluginLoadClientPolicy): Deleted.
2210         (WebPlatformStrategies::clearPluginClientPolicies): Deleted.
2211         * WebCoreSupport/WebPluginInfoProvider.mm:
2212         (WebPluginInfoProvider::refreshPlugins):
2213         (WebPluginInfoProvider::getPluginInfo):
2214         (WebPluginInfoProvider::getWebVisiblePluginInfo):
2215
2216 2016-08-08  Anders Carlsson  <andersca@apple.com>
2217
2218         Add a new PluginInfoProvider class, to replace PluginStrategy
2219         https://bugs.webkit.org/show_bug.cgi?id=160670
2220
2221         Reviewed by Sam Weinig.
2222
2223         Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
2224
2225         * WebCoreSupport/WebPluginInfoProvider.h: Added.
2226         * WebCoreSupport/WebPluginInfoProvider.mm: Added.
2227         (WebPluginInfoProvider::singleton):
2228         (WebPluginInfoProvider::WebPluginInfoProvider):
2229         (WebPluginInfoProvider::~WebPluginInfoProvider):
2230         (WebPluginInfoProvider::refreshPlugins):
2231         (WebPluginInfoProvider::getPluginInfo):
2232         (WebPluginInfoProvider::getWebVisiblePluginInfo):
2233         (WebPluginInfoProvider::setPluginLoadClientPolicy):
2234         (WebPluginInfoProvider::clearPluginClientPolicies):
2235         * WebView/WebView.mm:
2236         (-[WebView _commonInitializationWithFrameName:groupName:]):
2237
2238 2016-08-02  Enrica Casucci  <enrica@apple.com>
2239
2240         Allow building with content filtering disabled.
2241         https://bugs.webkit.org/show_bug.cgi?id=160454
2242
2243         Reviewed by Simon Fraser.
2244
2245         * Configurations/FeatureDefines.xcconfig:
2246         * WebCoreSupport/WebFrameLoaderClient.h:
2247         * WebCoreSupport/WebFrameLoaderClient.mm:
2248         (WebFrameLoaderClient::blockedByContentFilterError):
2249
2250 2016-08-02  Anders Carlsson  <andersca@apple.com>
2251
2252         Remove more unused/uninstalled Objective-C DOM bindings
2253         https://bugs.webkit.org/show_bug.cgi?id=160464
2254
2255         Reviewed by Darin Adler.
2256
2257         Stop installing unused headers.
2258
2259         * MigrateHeaders.make:
2260
2261 2016-08-01  Anders Carlsson  <andersca@apple.com>
2262
2263         Bring back a file - it needs to be copied by WebCore.
2264
2265         * MigrateHeaders.make:
2266
2267 2016-08-01  Anders Carlsson  <andersca@apple.com>
2268
2269         Remove another file.
2270
2271         * MigrateHeaders.make:
2272
2273 2016-08-01  Anders Carlsson  <andersca@apple.com>
2274
2275         Remove a file.
2276
2277         * MigrateHeaders.make:
2278
2279 2016-08-01  Anders Carlsson  <andersca@apple.com>
2280
2281         Freeze all the DOMHTML* Objective-C bindings
2282         https://bugs.webkit.org/show_bug.cgi?id=160424
2283
2284         Reviewed by Tim Horton.
2285
2286         Don't migrate DOMHTMLEmbedElementPrivate.h - it was just an empty header.
2287
2288         * MigrateHeaders.make:
2289
2290 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
2291
2292         Remove deprecated SPI for video inline / fullscreen controls
2293         https://bugs.webkit.org/show_bug.cgi?id=160318
2294
2295         Reviewed by Tim Horton.
2296
2297         * WebView/WebPreferenceKeysPrivate.h:
2298         * WebView/WebPreferences.mm:
2299         (+[WebPreferences initialize]): Deleted.
2300         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]): Deleted.
2301         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]): Deleted.
2302         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]): Deleted.
2303         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]): Deleted.
2304         * WebView/WebPreferencesPrivate.h:
2305         * WebView/WebView.mm:
2306         (-[WebView _preferencesChanged:]): Deleted.
2307
2308 2016-07-28  Anders Carlsson  <andersca@apple.com>
2309
2310         Move a Mail.app workaround closer to where it's actually needed
2311         https://bugs.webkit.org/show_bug.cgi?id=160317
2312
2313         Reviewed by Tim Horton.
2314
2315         * WebCoreSupport/WebFrameLoaderClient.mm:
2316         (WebFrameLoaderClient::dispatchWillSendRequest):
2317         * WebView/WebFrame.mm:
2318         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Deleted.
2319
2320 2016-07-28  Anders Carlsson  <andersca@apple.com>
2321
2322         Use a RetainPtr in WebFrameLoaderClient::assignIdentifierToInitialRequest
2323         https://bugs.webkit.org/show_bug.cgi?id=160315
2324
2325         Reviewed by Tim Horton.
2326
2327         * WebCoreSupport/WebFrameLoaderClient.mm:
2328         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2329
2330 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2331
2332         Fix the Windows debug build.
2333         
2334         WebResourceLoadScheduler's logging was a holdover from it being in WebCore,
2335         and prior to r203749 WebKit was actually using a WebCore log channel.
2336         
2337         For some reason this doesn't build on Windows debug, so just remove
2338         this logging for now.
2339
2340         * Misc/WebKitLogging.h:
2341
2342 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2343
2344         [iPhone] Playing a video on tudou.com plays only sound, no video
2345         https://bugs.webkit.org/show_bug.cgi?id=160178
2346         <rdar://problem/27535468>
2347
2348         Reviewed by Eric Carlson and Dan Bernstein.
2349
2350         * WebView/WebPreferenceKeysPrivate.h:
2351         * WebView/WebPreferences.mm:
2352         (+[WebPreferences initialize]):
2353         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]):
2354         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]):
2355         * WebView/WebPreferencesPrivate.h:
2356         * WebView/WebView.mm:
2357         (-[WebView _preferencesChanged:]):
2358
2359 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2360
2361         Allow LOG macros to be used outside the namespace, and other logging cleanup
2362         https://bugs.webkit.org/show_bug.cgi?id=160216
2363
2364         Reviewed by Anders Carlsson.
2365
2366         Fix some issues with the LOG macros.
2367         
2368         First, they were not usable outside the WebKit namespace in WebKit2 code. Fix by moving
2369         its log channels outside of the namespace (they are protected by a unique prefix anyway).
2370         
2371         Second, allow LOG_WITH_STREAM to be used in WebKit2 by moving that and a helper macro
2372         into LogMacros.h, which is exported from WebCore as a private header.
2373         
2374         Third, split the Logging.h header into two. Logging.h remains for framework-internal
2375         log channels and log macros. Add LogInitialization.h which is external, and used to
2376         initialize the channels.
2377         
2378         Finally unify "initializeLogChannels" and "initializeLoggingChannels" terminology everywhere.
2379
2380         * Misc/WebKitLogging.h:
2381         * Misc/WebKitLogging.m:
2382         * WebView/WebView.mm:
2383         (-[WebView _commonInitializationWithFrameName:groupName:]):
2384
2385 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2386
2387         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2388         https://bugs.webkit.org/show_bug.cgi?id=160066
2389
2390         Reviewed by Dean Jackson.
2391
2392         * WebView/WebPreferenceKeysPrivate.h:
2393         * WebView/WebPreferences.mm:
2394         (+[WebPreferences initialize]): Deleted.
2395         (-[WebPreferences inlineMediaPlaybackRequiresPlaysInlineAttribute]): Deleted.
2396         (-[WebPreferences setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): Deleted.
2397         * WebView/WebPreferencesPrivate.h:
2398         * WebView/WebView.mm:
2399         (-[WebView _preferencesChanged:]): Deleted.
2400
2401 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2402
2403         [iPhone] Playing a video on tudou.com plays only sound, no video
2404         https://bugs.webkit.org/show_bug.cgi?id=159967
2405         <rdar://problem/26964090>
2406
2407         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2408
2409         Add the two preferences to WebPreferences.
2410
2411         * WebView/WebPreferenceKeysPrivate.h:
2412         * WebView/WebPreferences.mm:
2413         (+[WebPreferences initialize]):
2414         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
2415         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
2416         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
2417         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
2418         * WebView/WebPreferencesPrivate.h:
2419         * WebView/WebView.mm:
2420         (-[WebView _preferencesChanged:]):
2421
2422 2016-07-20  Commit Queue  <commit-queue@webkit.org>
2423
2424         Unreviewed, rolling out r203471.
2425         https://bugs.webkit.org/show_bug.cgi?id=160003
2426
2427         many iOS-simulator tests are failing (Requested by litherum on
2428         #webkit).
2429
2430         Reverted changeset:
2431
2432         "[iPhone] Playing a video on tudou.com plays only sound, no
2433         video"
2434         https://bugs.webkit.org/show_bug.cgi?id=159967
2435         http://trac.webkit.org/changeset/203471
2436
2437 2016-07-20  Myles C. Maxfield  <mmaxfield@apple.com>
2438
2439         [iPhone] Playing a video on tudou.com plays only sound, no video
2440         https://bugs.webkit.org/show_bug.cgi?id=159967
2441         <rdar://problem/26964090>
2442
2443         Reviewed by Jon Lee.
2444
2445         Add the two preferences to WebPreferences.
2446
2447         * WebView/WebPreferenceKeysPrivate.h:
2448         * WebView/WebPreferences.mm:
2449         (+[WebPreferences initialize]):
2450         (-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]):
2451         (-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]):
2452         (-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]):
2453         (-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]):
2454         * WebView/WebPreferencesPrivate.h:
2455         * WebView/WebView.mm:
2456         (-[WebView _preferencesChanged:]):
2457
2458 2016-07-19  Andy Estes  <aestes@apple.com>
2459
2460         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2461         https://bugs.webkit.org/show_bug.cgi?id=159956
2462
2463         Reviewed by Dan Bernstein.
2464
2465         * Misc/WebKitErrors.h: Moved definition of WebKitErrorFrameLoadBlockedByContentFilter from here ...
2466         * Misc/WebKitErrorsPrivate.h: to here.
2467
2468 2016-07-18  Anders Carlsson  <andersca@apple.com>
2469
2470         WebKit nightly fails to build on macOS Sierra
2471         https://bugs.webkit.org/show_bug.cgi?id=159902
2472         rdar://problem/27365672
2473
2474         Reviewed by Tim Horton.
2475
2476         * icu/unicode/ucurr.h: Added.
2477         Add ucurr.h from ICU.
2478
2479 2016-07-17  Sam Weinig  <sam@webkit.org>
2480
2481         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2482         <rdar://problem/26554137>
2483         https://bugs.webkit.org/show_bug.cgi?id=159856
2484
2485         Reviewed by Dan Bernstein.
2486
2487         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2488         (WebKit::NetscapePluginInstanceProxy::evaluate):
2489         * Plugins/WebNetscapePluginView.mm:
2490         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2491         Update for new UserGestureIndicator interface.
2492
2493 2016-07-16  Ryosuke Niwa  <rniwa@webkit.org>
2494
2495         Rename fastGetAttribute to attributeWithoutSynchronization
2496         https://bugs.webkit.org/show_bug.cgi?id=159852
2497
2498         Reviewed by Darin Adler.
2499
2500         * WebView/WebHTMLRepresentation.mm:
2501         (matchLabelsAgainstElement):
2502
2503 2016-07-15  Chris Dumez  <cdumez@apple.com>
2504
2505         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
2506         https://bugs.webkit.org/show_bug.cgi?id=159793
2507
2508         Reviewed by Ryosuke Niwa.
2509
2510         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.
2511
2512         * WebView/WebHTMLRepresentation.mm:
2513         (matchLabelsAgainstElement):
2514
2515 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2516
2517         Use SocketProvider to create SocketStreamHandles
2518         https://bugs.webkit.org/show_bug.cgi?id=159774
2519
2520         Reviewed by Brady Eidson.
2521
2522         * Misc/WebSocketProvider.h: Removed.
2523         * Misc/WebSocketProvider.mm: Removed.
2524         * WebView/WebView.mm:
2525         (-[WebView _commonInitializationWithFrameName:groupName:]):
2526         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2527
2528 2016-07-14  Csaba Osztrogonác  <ossy@webkit.org>
2529
2530         Fix the !ENABLE(WEB_SOCKETS) build after r202930
2531         https://bugs.webkit.org/show_bug.cgi?id=159768
2532
2533         Reviewed by Alex Christensen.
2534
2535         * Misc/WebSocketProvider.h:
2536
2537 2016-07-13  Beth Dakin  <bdakin@apple.com>
2538
2539         Add more candidate tests
2540         https://bugs.webkit.org/show_bug.cgi?id=159730
2541
2542         Reviewed by Tim Horton.
2543
2544         Move shouldRequestCandidates from WebViewInternal to WebViewPrivate so that 
2545         we can use it in tests. 
2546         * WebView/WebViewInternal.h:
2547         * WebView/WebViewPrivate.h:
2548
2549 2016-07-13  Enrica Casucci  <enrica@apple.com>
2550
2551         Update supported platforms in xcconfig files to match the sdk names.
2552         https://bugs.webkit.org/show_bug.cgi?id=159728
2553
2554         Reviewed by Tim Horton.
2555
2556         * Configurations/Base.xcconfig:
2557
2558 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2559
2560         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2561         https://bugs.webkit.org/show_bug.cgi?id=159671
2562
2563         Reviewed by Csaba Osztrogonác.
2564
2565         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2566         https://bugs.webkit.org/show_bug.cgi?id=89235
2567
2568         So this guard can be removed in build scripts.
2569
2570         * Configurations/FeatureDefines.xcconfig:
2571
2572 2016-07-11  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2573
2574         Purge PassRefPtr in platform/efl and platform/mac 
2575         https://bugs.webkit.org/show_bug.cgi?id=159548
2576
2577         Reviewed by Alex Christensen.
2578
2579         Remove all use of PassRefPtr and clean up unnecessary tabs and spaces.
2580
2581         * WebCoreSupport/WebPlatformStrategies.h:
2582         * WebCoreSupport/WebPlatformStrategies.mm:
2583         (WebPlatformStrategies::setBufferForType):
2584
2585 2016-07-11  Enrica Casucci  <enrica@apple.com>
2586
2587         Add synthetic click origin to WKNavigationAction.
2588         https://bugs.webkit.org/show_bug.cgi?id=159584
2589         rdar://problem/25610422
2590
2591         Reviewed by Tim Horton.
2592
2593         * WebView/WebFrame.mm:
2594         (-[WebFrame _dragSourceEndedAt:operation:]):
2595         * WebView/WebPDFView.mm:
2596         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2597
2598 2016-07-11  Anders Carlsson  <andersca@apple.com>
2599
2600         Able to open multiple payment sheets in Safari at the same time
2601         https://bugs.webkit.org/show_bug.cgi?id=159637
2602         rdar://problem/26411339
2603
2604         Reviewed by Beth Dakin.
2605
2606         Update for WebCore changes.
2607
2608         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2609         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2610         (WebPaymentCoordinatorClient::showPaymentUI):
2611
2612 2016-07-08  Andy Estes  <aestes@apple.com>
2613
2614         [Content Filtering] Load blocked pages more like other error pages are loaded
2615         https://bugs.webkit.org/show_bug.cgi?id=159485
2616         <rdar://problem/26014076>
2617
2618         Reviewed by Brady Eidson.
2619
2620         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
2621         * Misc/WebKitErrors.m:
2622         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
2623         * WebCoreSupport/WebFrameLoaderClient.h:
2624         * WebCoreSupport/WebFrameLoaderClient.mm:
2625         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
2626
2627 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2628
2629         Unreviewed, rolling out r202944.
2630         https://bugs.webkit.org/show_bug.cgi?id=159570
2631
2632         caused some tests to crash under GuardMalloc (Requested by
2633         estes on #webkit).
2634
2635         Reverted changeset:
2636
2637         "[Content Filtering] Load blocked pages more like other error
2638         pages are loaded"
2639         https://bugs.webkit.org/show_bug.cgi?id=159485
2640         http://trac.webkit.org/changeset/202944
2641
2642 2016-07-08  Jiewen Tan  <jiewen_tan@apple.com>
2643
2644         Define DYLD_MACOSX_VERSION_10_12
2645         https://bugs.webkit.org/show_bug.cgi?id=159525
2646         <rdar://problem/26250296>
2647
2648         Reviewed by Brent Fulgham.
2649
2650         * WebView/WebView.mm:
2651         (shouldConvertInvalidURLsToBlank):
2652         Replace 0x000A0C00 with DYLD_MACOSX_VERSION_10_12.
2653
2654 2016-07-07  Beth Dakin  <bdakin@apple.com>
2655
2656         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
2657         https://bugs.webkit.org/show_bug.cgi?id=159532
2658         -and corresponding-
2659         rdar://problem/27177179
2660
2661         Reviewed by Tim Horton.
2662
2663         * WebView/WebView.mm:
2664         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
2665         (-[WebView forceRequestCandidatesForTesting]):
2666         (-[WebView shouldRequestCandidates]):
2667         * WebView/WebViewPrivate.h:
2668
2669 2016-07-07  Andy Estes  <aestes@apple.com>
2670
2671         [Content Filtering] Load blocked pages more like other error pages are loaded
2672         https://bugs.webkit.org/show_bug.cgi?id=159485
2673         <rdar://problem/26014076>
2674
2675         Reviewed by Brady Eidson.
2676
2677         * Misc/WebKitErrors.h: Defined WebKitErrorFrameLoadBlockedByContentFilter.
2678         * Misc/WebKitErrors.m:
2679         (registerErrors): Registered WebKitErrorDescriptionFrameLoadBlockedByContentFilter.
2680         * WebCoreSupport/WebFrameLoaderClient.h:
2681         * WebCoreSupport/WebFrameLoaderClient.mm:
2682         (WebFrameLoaderClient::blockedByContentFilterError): Returned a ResourceError for WebKitErrorFrameLoadBlockedByContentFilter.
2683
2684 2016-07-07  Alex Christensen  <achristensen@webkit.org>
2685
2686         Use SocketProvider to create WebSocketChannels
2687         https://bugs.webkit.org/show_bug.cgi?id=158776
2688
2689         Reviewed by Brent Fulgham.
2690
2691         * Misc/WebSocketProvider.mm: Copied from Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp.
2692         (WebSocketProvider::createWebSocketChannel):
2693         (WebCore::ThreadableWebSocketChannel::create): Deleted.
2694         * Misc/WebSocketProvider.h:
2695         * WebView/WebView.mm:
2696         (-[WebView _commonInitializationWithFrameName:groupName:]):
2697         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2698
2699 2016-07-06  Benjamin Poulain  <bpoulain@apple.com>
2700
2701         [JSC] Unify how we throw TypeError from C++
2702         https://bugs.webkit.org/show_bug.cgi?id=159500
2703
2704         Reviewed by Saam Barati.
2705
2706         * Plugins/Hosted/ProxyInstance.mm:
2707         (WebKit::ProxyInstance::invokeMethod):
2708
2709 2016-07-01  Youenn Fablet  <youennf@gmail.com>
2710
2711         Add a runtime flag for DOM iterators
2712         https://bugs.webkit.org/show_bug.cgi?id=159300
2713
2714         Reviewed by Alex Christensen.
2715
2716         * WebView/WebPreferenceKeysPrivate.h:
2717         * WebView/WebPreferences.mm:
2718         (-[WebPreferences DOMIteratorEnabled]):
2719         (-[WebPreferences setDOMIteratorEnabled:]):
2720         * WebView/WebPreferencesPrivate.h:
2721         * WebView/WebView.mm:
2722         (-[WebView _preferencesChanged:]):
2723
2724 2016-06-30  Jiewen Tan  <jiewen_tan@apple.com>
2725
2726         Create a generic "linked-on-or-after" check for new CSP Rules
2727         https://bugs.webkit.org/show_bug.cgi?id=159322
2728         <rdar://problem/27117220>
2729
2730         Reviewed by Brent Fulgham.
2731
2732         * WebView/WebView.mm:
2733         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2734
2735 2016-06-30  Anders Carlsson  <andersca@apple.com>
2736
2737         Mail crashes on launch at WebCore::PaymentCoordinator::~PaymentCoordinator() + 20
2738         https://bugs.webkit.org/show_bug.cgi?id=159306
2739         rdar://problem/27092107
2740
2741         Reviewed by Tim Horton.
2742
2743         * WebView/WebView.mm:
2744         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2745         Create a WebPaymentCoordinatorClient. Remove an unneeded #import.
2746
2747         (-[WebView _commonInitializationWithFrameName:groupName:]):
2748         Remove an unneeded #import.
2749
2750 2016-06-27  Anders Carlsson  <andersca@apple.com>
2751
2752         WebKit::WebPaymentCoordinator leak
2753         https://bugs.webkit.org/show_bug.cgi?id=159168
2754         rdar://problem/26929772
2755
2756         Reviewed by Beth Dakin.
2757
2758         Update for WebCore changes.
2759
2760         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2761         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2762         (WebPaymentCoordinatorClient::paymentCoordinatorDestroyed):
2763         (WebPaymentCoordinatorClient::mainFrameDestroyed): Deleted.
2764
2765 2016-06-27  Tim Horton  <timothy_horton@apple.com>
2766
2767         REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app
2768         https://bugs.webkit.org/show_bug.cgi?id=159184
2769         <rdar://problem/26370206>
2770
2771         Reviewed by Beth Dakin.
2772
2773         * WebView/WebHTMLView.mm:
2774         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2775         * WebView/WebImmediateActionController.h:
2776         * WebView/WebImmediateActionController.mm:
2777         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2778         (-[WebImmediateActionController _animationControllerForText]):
2779         (dictionaryPopupInfoForRange): Deleted.
2780         WebImmediateActionController's code to make a DictionaryPopupInfo and TextIndicator
2781         from a Range in WebKit1 is much better than WebHTMLView's; use it in both cases.
2782
2783 2016-06-24  Jer Noble  <jer.noble@apple.com>
2784
2785         Playback controls refer to wrong element when playing multiple items in a page.
2786         https://bugs.webkit.org/show_bug.cgi?id=159076
2787         <rdar://problem/26953532>
2788
2789         Reviewed by Beth Dakin.
2790
2791         clearPlaybackControlsManager() no longer takes a parameter.
2792
2793         * WebCoreSupport/WebChromeClient.h:
2794         * WebCoreSupport/WebChromeClient.mm:
2795         (WebChromeClient::clearPlaybackControlsManager):
2796         * WebView/WebView.mm:
2797         (-[WebView _clearPlaybackControlsManager]): Renamed from _clearPlaybackControlsManagerForMediaElement:.
2798         * WebView/WebViewInternal.h:
2799
2800 2016-06-23  Alex Christensen  <achristensen@webkit.org>
2801
2802         Remove unused didCancelAuthenticationChallenge
2803         https://bugs.webkit.org/show_bug.cgi?id=158819
2804
2805         Reviewed by David Kilzer.
2806
2807         * Misc/WebDownload.mm:
2808         (-[WebDownloadInternal download:didCancelAuthenticationChallenge:]): Deleted.
2809         * WebCoreSupport/WebFrameLoaderClient.h:
2810         * WebCoreSupport/WebFrameLoaderClient.mm:
2811         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.
2812         * WebView/WebDelegateImplementationCaching.h:
2813         * WebView/WebView.mm:
2814         (-[WebView _cacheResourceLoadDelegateImplementations]):
2815
2816 2016-06-23  John Wilander  <wilander@apple.com>
2817
2818         Enable window.open() for existing versions of Secret Society app
2819         https://bugs.webkit.org/show_bug.cgi?id=159049
2820         <rdar://problem/26528349>
2821
2822         Reviewed by Andy Estes.
2823
2824         The Secret Society Hidden Mystery app has a broken version check treating iOS 10
2825         as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
2826         handler. We should allow the existing versions of the app to do this to not break
2827         them.
2828
2829         * WebView/WebView.mm:
2830         (shouldAllowWindowOpenWithoutUserGesture):
2831             Added.
2832         (shouldConvertInvalidURLsToBlank):
2833             Changed hex number to constant DYLD_IOS_VERSION_10_0.
2834
2835 2016-06-22  Anders Carlsson  <andersca@apple.com>
2836
2837         Move the WebKitLegacy Apple Pay code to the open source repository
2838         https://bugs.webkit.org/show_bug.cgi?id=159035
2839
2840         Reviewed by Tim Horton.
2841
2842         * WebCoreSupport/WebPaymentCoordinatorClient.h: Added.
2843         * WebCoreSupport/WebPaymentCoordinatorClient.mm: Added.
2844         (WebPaymentCoordinatorClient::WebPaymentCoordinatorClient):
2845         (WebPaymentCoordinatorClient::~WebPaymentCoordinatorClient):
2846         (WebPaymentCoordinatorClient::supportsVersion):
2847         (WebPaymentCoordinatorClient::canMakePayments):
2848         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
2849         (WebPaymentCoordinatorClient::showPaymentUI):
2850         (WebPaymentCoordinatorClient::completeMerchantValidation):
2851         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
2852         (WebPaymentCoordinatorClient::completeShippingContactSelection):
2853         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
2854         (WebPaymentCoordinatorClient::completePaymentSession):
2855         (WebPaymentCoordinatorClient::abortPaymentSession):
2856         (WebPaymentCoordinatorClient::mainFrameDestroyed):
2857         * WebKitAdditions.mm: Removed.
2858         * WebView/WebView.mm:
2859         (-[WebView _commonInitializationWithFrameName:groupName:]):
2860
2861 2016-06-21  Anders Carlsson  <andersca@apple.com>
2862
2863         Fix build.
2864
2865         * Configurations/FeatureDefines.xcconfig:
2866
2867 2016-06-21  Anders Carlsson  <andersca@apple.com>
2868
2869         Begin moving the Apple Pay code to the open source repository
2870         https://bugs.webkit.org/show_bug.cgi?id=158998
2871
2872         Reviewed by Tim Horton.
2873
2874         * Configurations/FeatureDefines.xcconfig:
2875         Add ENABLE_APPLE_PAY.
2876
2877 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
2878
2879         Focus event dispatched in iframe causes parent document to scroll incorrectly
2880         https://bugs.webkit.org/show_bug.cgi?id=158629
2881         rdar://problem/26521616
2882
2883         Reviewed by Tim Horton.
2884         
2885         Pass SelectionRevealMode::Reveal in existing code.
2886
2887         * WebView/WebFrame.mm:
2888         (-[WebFrame _scrollDOMRangeToVisible:]):
2889         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2890         (-[WebFrame revealSelectionAtExtent:]):
2891         * WebView/WebHTMLView.mm:
2892         (-[WebHTMLView jumpToSelection:]):
2893         (-[WebHTMLView centerSelectionInVisibleArea:]):
2894
2895 2016-06-21  Amir Alavi  <aalavi@apple.com>
2896
2897         Upstream WKHTTPCookiesForURL from WebKitSystemInterface to OpenSource
2898         https://bugs.webkit.org/show_bug.cgi?id=158967
2899
2900         Reviewed by Brent Fulgham.
2901
2902         * WebCoreSupport/WebSystemInterface.mm:
2903         (InitWebCoreSystemInterface): Deleted.
2904
2905 2016-06-20  Commit Queue  <commit-queue@webkit.org>
2906
2907         Unreviewed, rolling out r202243.
2908         https://bugs.webkit.org/show_bug.cgi?id=158972
2909
2910         Broke Windows build and iOS tests (Requested by ap on
2911         #webkit).
2912
2913         Reverted changeset:
2914
2915         "Focus event dispatched in iframe causes parent document to
2916         scroll incorrectly"
2917         https://bugs.webkit.org/show_bug.cgi?id=158629
2918         http://trac.webkit.org/changeset/202243
2919
2920 2016-06-20  Simon Fraser  <simon.fraser@apple.com>
2921
2922         Focus event dispatched in iframe causes parent document to scroll incorrectly
2923         https://bugs.webkit.org/show_bug.cgi?id=158629
2924         rdar://problem/26521616
2925
2926         Reviewed by Tim Horton.
2927         
2928         Pass SelectionRevealMode::Reveal in existing code.
2929
2930         * WebView/WebFrame.mm:
2931         (-[WebFrame _scrollDOMRangeToVisible:]):
2932         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2933         (-[WebFrame revealSelectionAtExtent:]):
2934         * WebView/WebHTMLView.mm:
2935         (-[WebHTMLView jumpToSelection:]):
2936         (-[WebHTMLView centerSelectionInVisibleArea:]):
2937
2938 2016-06-20  Keith Rollin  <krollin@apple.com>
2939
2940         Remove RefPtr::release() and change calls sites to use WTFMove()
2941         https://bugs.webkit.org/show_bug.cgi?id=158369
2942
2943         Reviewed by Chris Dumez.
2944
2945         RefPtr::release() releases its managed pointer awkwardly. It's more
2946         direct and clearer to use WTFMove to transfer ownership of the managed
2947         pointer.
2948
2949         As part of this cleanup, also change a lot of explicit data types to
2950         'auto'.
2951
2952         * Plugins/Hosted/NetscapePluginHostManager.mm:
2953         (WebKit::NetscapePluginHostManager::instantiatePlugin):
2954         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2955         (WebKit::NetscapePluginInstanceProxy::create):
2956         (WebKit::NetscapePluginInstanceProxy::loadRequest):
2957         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
2958         * WebCoreSupport/WebFrameLoaderClient.mm:
2959         (-[WebFramePolicyListener receivedPolicyDecision:]):
2960         * WebCoreSupport/WebSecurityOrigin.mm:
2961         (-[WebSecurityOrigin initWithURL:]):
2962         * WebView/WebArchive.mm:
2963         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
2964         (-[WebArchive initWithData:]):
2965         * WebView/WebDataSource.mm:
2966         (-[WebDataSource mainResource]):
2967         * WebView/WebFrame.mm:
2968         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
2969
2970 2016-06-15  Alexey Proskuryakov  <ap@apple.com>
2971
2972         +[WebHTMLRepresentation supportedMIMETypes] leaks
2973         https://bugs.webkit.org/show_bug.cgi?id=158683
2974
2975         Reviewed by Darin Adler.
2976
2977         The problem occurred when chaining newArrayByConcatenatingArrays calls.
2978
2979         Also refactored the code to avoid returning NSMutableArrays disguised as NSArrays,
2980         and removed __unsafe_unretained modifiers that were added in http://trac.webkit.org/r149453
2981         for no apparent reason.
2982
2983         * WebView/WebHTMLRepresentation.mm:
2984         (newArrayWithStrings):
2985         (+[WebHTMLRepresentation supportedMIMETypes]):
2986         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2987         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2988         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2989         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2990         (newArrayByConcatenatingArrays): Deleted.
2991
2992 2016-06-15  Dean Jackson  <dino@apple.com>
2993
2994         RTL <select> forms are misplaced
2995         https://bugs.webkit.org/show_bug.cgi?id=158810
2996         <rdar://problem/24847541>
2997
2998         Reviewed by Eric Carlson.
2999
3000         AppKit made a change in Sierra that causes popup menus
3001         to snap to a different point when the system language is RTL.
3002         We need to be more explicit about what directionality
3003         we want, and override the location of the popup based
3004         on the text direction.
3005
3006         I also made a small tweak to the fudge offsets we use
3007         in order to make button text and menu text to be
3008         more consistent.
3009
3010         Unfortunately since this is just about the location
3011         of the popup menu, it's unable to be tested in our
3012         current infrastructure.
3013
3014         * WebCoreSupport/PopupMenuMac.mm:
3015         (PopupMenuMac::show):
3016
3017 2016-06-15  Chris Dumez  <cdumez@apple.com>
3018
3019         Drop some unnecessary header includes
3020         https://bugs.webkit.org/show_bug.cgi?id=158788
3021
3022         Reviewed by Alexey Proskuryakov.
3023
3024         Drop some unnecessary header includes in headers to speed up build time.
3025
3026         * WebCoreSupport/WebFrameLoaderClient.mm:
3027
3028 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
3029
3030         Enabling Shadow DOM for all platforms
3031         https://bugs.webkit.org/show_bug.cgi?id=158738
3032
3033         Reviewed by Ryosuke Niwa.
3034
3035         Removed Shadow DOM from options (enabled by default)
3036
3037         * Configurations/FeatureDefines.xcconfig:
3038         * WebView/WebPreferences.mm:
3039         * WebView/WebView.mm:
3040
3041 2016-06-15  Antti Koivisto  <antti@apple.com>
3042
3043         Vary:Cookie validation doesn't work in private browsing
3044         https://bugs.webkit.org/show_bug.cgi?id=158616
3045         <rdar://problem/26755067>
3046
3047         Reviewed by Andreas Kling.
3048
3049         * WebCoreSupport/WebFrameNetworkingContext.h:
3050         (WebFrameNetworkingContext::create):
3051         * WebCoreSupport/WebFrameNetworkingContext.mm:
3052         (privateSession):
3053         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3054
3055             Expose the private browsing session.
3056
3057         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3058         * WebCoreSupport/WebPlatformStrategies.h:
3059         * WebCoreSupport/WebPlatformStrategies.mm:
3060         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3061
3062             Implement SessionID version of the function.
3063
3064         (WebPlatformStrategies::getRawCookies):
3065
3066 2016-06-13  Alex Christensen  <achristensen@webkit.org>
3067
3068         Add WebSocketProvider stub
3069         https://bugs.webkit.org/show_bug.cgi?id=158702
3070
3071         Reviewed by Brady Eidson.
3072
3073         * Misc/WebSocketProvider.h: Added.
3074         * WebView/WebView.mm:
3075         (-[WebView _commonInitializationWithFrameName:groupName:]):
3076         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3077
3078 2016-06-10  Alex Christensen  <achristensen@webkit.org>
3079
3080         Introduce WTF::UniqueRef
3081         https://bugs.webkit.org/show_bug.cgi?id=158596
3082
3083         Reviewed by Brady Eidson.
3084
3085         * WebView/WebView.mm:
3086         (-[WebView _commonInitializationWithFrameName:groupName:]):
3087         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3088
3089 2016-06-09  Alex Christensen  <achristensen@webkit.org>
3090
3091         Clean up EditorClient lifetime
3092         https://bugs.webkit.org/show_bug.cgi?id=158588
3093
3094         Reviewed by Anders Carlsson.
3095
3096         * WebCoreSupport/WebEditorClient.h:
3097         * WebCoreSupport/WebEditorClient.mm:
3098         (WebEditorClient::WebEditorClient):
3099         (WebEditorClient::pageDestroyed): Deleted.
3100         * WebView/WebView.mm:
3101         (-[WebView _commonInitializationWithFrameName:groupName:]):
3102         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3103
3104 2016-06-09  Andy Estes  <aestes@apple.com>
3105
3106         Define printing{Minimum,Maximum}ShrinkFactor in only one place
3107         https://bugs.webkit.org/show_bug.cgi?id=158580
3108
3109         Reviewed by Tim Horton.
3110
3111         * WebView/WebHTMLView.mm: Initialized _WebHTMLViewPrintingMinimumShrinkFactor and
3112         _WebHTMLViewPrintingMaximumShrinkFactor with PrintContext::minimumShrinkFactor() and
3113         PrintContext::maximumShrinkFactor() instead of with duplicated float literals.
3114
3115 2016-06-09  Commit Queue  <commit-queue@webkit.org>
3116
3117         Unreviewed, rolling out r201810.
3118         https://bugs.webkit.org/show_bug.cgi?id=158563
3119
3120         breaks build without ENABLE_WEB_ANIMATION (Requested by
3121         mcatanzaro on #webkit).
3122
3123         Reverted changeset:
3124
3125         "[web-animations] Add Animatable, AnimationEffect,
3126         KeyframeEffect and Animation interface"
3127         https://bugs.webkit.org/show_bug.cgi?id=156096
3128         http://trac.webkit.org/changeset/201810
3129
3130 2016-06-08  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
3131
3132         [web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
3133         https://bugs.webkit.org/show_bug.cgi?id=156096
3134
3135         Reviewed by Dean Jackson.
3136
3137         Adds:
3138         - Setup interface for enabling runtime flag for Web animations through preferences.
3139
3140         * WebView/WebPreferenceKeysPrivate.h:
3141         * WebView/WebPreferences.mm:
3142         (+[WebPreferences initialize]):
3143         (-[WebPreferences webAnimationsEnabled]):
3144         (-[WebPreferences setWebAnimationsEnabled:]):
3145         * WebView/WebPreferencesPrivate.h:
3146         * WebView/WebView.mm:
3147         (-[WebView _preferencesChanged:]):
3148
3149 2016-06-07  David Kilzer  <ddkilzer@apple.com>
3150
3151         [iOS WK1] Remove unused -_webkit_unescapedQueryValue and -_webkit_queryKeysAndValues NSString category methods
3152         <https://webkit.org/b/158485>
3153         <rdar://problem/16960445>
3154
3155         Reviewed by Dan Bernstein.
3156
3157         * Misc/WebNSURLExtras.h:
3158         (-[NSString _webkit_unescapedQueryValue]): Deleted declaration.
3159         (-[NSString _webkit_queryKeysAndValues]): Deleted declaration.
3160         * Misc/WebNSURLExtras.mm:
3161         (-[NSString _webkit_unescapedQueryValue]): Deleted.
3162         (-[NSString _webkit_queryKeysAndValues]): Deleted.
3163
3164 2016-06-07  Alex Christensen  <achristensen@webkit.org>
3165
3166         Adopt [PDFView documentScrollView]
3167         https://bugs.webkit.org/show_bug.cgi?id=158454
3168         rdar://problem/25875390
3169
3170         Reviewed by Tim Horton.
3171
3172         * WebView/PDFViewSPI.h: Added.
3173         * WebView/WebPDFView.mm:
3174         (-[WebPDFView _clipViewForPDFDocumentView]):
3175
3176 2016-06-05  Anders Carlsson  <andersca@apple.com>
3177
3178         Attempt to fix plug-in hangs by adding back empty slots for the removed messages.
3179
3180         * Plugins/Hosted/WebKitPluginClient.defs:
3181         * Plugins/Hosted/WebKitPluginHost.defs:
3182
3183 2016-06-04  Anders Carlsson  <andersca@apple.com>
3184
3185         Remove NPSPI that is no longer used
3186         https://bugs.webkit.org/show_bug.cgi?id=158384
3187
3188         Reviewed by Sam Weinig.
3189
3190         * Configurations/WebKitLegacy.xcconfig:
3191         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3192         (WKPCCheckIfAllowedToLoadURL): Deleted.
3193         (WKPCCancelCheckIfAllowedToLoadURL): Deleted.
3194         (WKPCResolveURL): Deleted.
3195         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3196         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3197         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Deleted.
3198         (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURL): Deleted.
3199         (WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL): Deleted.
3200         (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult): Deleted.
3201         (WebKit::NetscapePluginInstanceProxy::resolveURL): Deleted.
3202         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3203         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3204         (-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Deleted.
3205         (-[WebHostedNetscapePluginView _containerCheckResult:contextInfo:]): Deleted.
3206         * Plugins/Hosted/WebKitPluginClient.defs:
3207         * Plugins/WebBaseNetscapePluginView.h:
3208         * Plugins/WebBaseNetscapePluginView.mm:
3209         (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]): Deleted.
3210         * Plugins/WebNetscapeContainerCheckContextInfo.h: Removed.
3211         * Plugins/WebNetscapeContainerCheckContextInfo.mm: Removed.
3212         (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]): Deleted.
3213         (-[WebNetscapeContainerCheckContextInfo checkRequestID]): Deleted.
3214         (-[WebNetscapeContainerCheckContextInfo callback]): Deleted.
3215         (-[WebNetscapeContainerCheckContextInfo context]): Deleted.
3216         * Plugins/WebNetscapeContainerCheckPrivate.h: Removed.
3217         * Plugins/WebNetscapeContainerCheckPrivate.mm: Removed.
3218         (browserContainerCheckFuncs): Deleted.
3219         * Plugins/WebNetscapePluginView.h:
3220         * Plugins/WebNetscapePluginView.mm:
3221         (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]): Deleted.
3222         (-[WebNetscapePluginView _containerCheckResult:contextInfo:]): Deleted.
3223         (-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Deleted.
3224         (-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Deleted.
3225         (-[WebNetscapePluginView fini]): Deleted.
3226         (-[WebNetscapePluginView getVariable:value:]): Deleted.
3227         (-[WebNetscapePluginView resolveURL:forTarget:]): Deleted.
3228         * Plugins/npapi.mm:
3229         (WKN_CheckIfAllowedToLoadURL): Deleted.
3230         (WKN_CancelCheckIfAllowedToLoadURL): Deleted.
3231         (WKN_ResolveURL): Deleted.
3232
3233 2016-06-04  Anders Carlsson  <andersca@apple.com>
3234
3235         Temporary build fix. (This function is going away).
3236
3237         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3238         (WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult): Deleted.
3239         * Plugins/Hosted/WebKitPluginHost.defs:
3240
3241 2016-06-03  Chris Dumez  <cdumez@apple.com>
3242
3243         Unreviewed, roll out r196633 as it broke PageCache on iOS for WebKit.org
3244         <rdar://problem/26521101>
3245
3246         * WebCoreSupport/WebVisitedLinkStore.mm:
3247         (WebVisitedLinkStore::removeAllVisitedLinks):
3248         (WebVisitedLinkStore::removeVisitedLink):
3249         (WebVisitedLinkStore::addVisitedLinkHash):
3250
3251 2016-06-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3252
3253         Add WebIDL special operation support: serializer
3254         https://bugs.webkit.org/show_bug.cgi?id=156293
3255
3256         Reviewed by Darin Adler.
3257
3258         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3259         (WebKit::HostedNetscapePluginStream::start):
3260         * Plugins/WebNetscapePluginStream.mm:
3261         (WebNetscapePluginStream::start):
3262
3263 2016-05-31  Darin Adler  <darin@apple.com>
3264
3265         Audit RenderObject casts and fix problems and style issues found
3266         https://bugs.webkit.org/show_bug.cgi?id=158221
3267
3268         Reviewed by Chris Dumez.
3269
3270         * Misc/WebNSPasteboardExtras.mm:
3271         (imageFromElement): Use auto and tighten the logic a bit.
3272         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3273         Use auto and added a comment about this not using imageFromElement.
3274
3275         * Plugins/WebBaseNetscapePluginView.mm:
3276         (-[WebBaseNetscapePluginView _windowClipRect]): Consistently cast to
3277         RenderEmbeddedObject, which is the class used for renderers for plug-ins.
3278         (-[WebBaseNetscapePluginView inFlatteningPaint]): Ditto.
3279         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]): Ditto.
3280         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]): Ditto.
3281
3282         * WebCoreSupport/WebFrameLoaderClient.mm:
3283         (WebFrameLoaderClient::createPlugin): Changed code so it does a null check
3284         rather than assuming the renderer is non-null.
3285         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
3286
3287 2016-05-31  Yusuke Suzuki  <utatane.tea@gmail.com>
3288
3289         Unreviewed, roll out r201481, r201523: 0.3% regression in Octane code-load
3290         https://bugs.webkit.org/show_bug.cgi?id=158249
3291
3292         * WebView/WebPreferencesPrivate.h:
3293
3294 2016-05-27  Chris Dumez  <cdumez@apple.com>
3295
3296         callOnMainThread() should not copy captured lambda variables
3297         https://bugs.webkit.org/show_bug.cgi?id=158166
3298
3299         Reviewed by Brady Eidson.
3300
3301         callOnMainThread() should not copy captured lambda variables. This 
3302         function is usually called cross-thread with a lambda and copying
3303         the lambda (and its captured variables) can lead to thread-safety
3304         issues.
3305
3306         This patch updates callOnMainThread() to take a NoncopyableFunction&&
3307         in parameter instead of a std::function. The call sites of
3308         callOnMainThread() have also been updated to use C++14's lambda
3309         capture with initializer.
3310
3311         * Storage/WebDatabaseManagerClient.mm:
3312         (DidModifyOriginData::dispatchToMainThread):
3313         (DidModifyOriginData::DidModifyOriginData): Deleted.
3314         * Storage/WebStorageTrackerClient.mm:
3315         (WebStorageTrackerClient::dispatchDidModifyOrigin):
3316
3317 2016-05-27  Caitlin Potter  <caitp@igalia.com>
3318
3319         [JSC] implement async functions proposal
3320         https://bugs.webkit.org/show_bug.cgi?id=156147
3321
3322         Reviewed by Yusuke Suzuki.
3323
3324         * WebView/WebPreferencesPrivate.h:
3325
3326 2016-05-26  Darin Adler  <darin@apple.com>
3327
3328         Media queries and platform screen modernization and streamlining
3329         https://bugs.webkit.org/show_bug.cgi?id=158067
3330
3331         Reviewed by Alex Christensen.
3332
3333         * WebView/WebFrame.mm:
3334         (-[WebFrame _dragSourceEndedAt:operation:]): Updated to use the new version of
3335         globalPoint, which returns an NSPoint.
3336
3337 2016-05-26  Myles C. Maxfield  <mmaxfield@apple.com>
3338
3339         Build fix
3340
3341         Rubber stamped by Lucas Forschler.
3342
3343         * Configurations/DebugRelease.xcconfig:
3344
3345 2016-05-24  Beth Dakin  <bdakin@apple.com>
3346
3347         Candidates should work with input methods
3348         https://bugs.webkit.org/show_bug.cgi?id=158042
3349         -and corresponding-
3350         rdar://problem/26205228
3351
3352         Reviewed by Tim Horton.
3353
3354         * WebView/WebHTMLView.mm:
3355         * WebView/WebView.mm:
3356         (-[WebView candidateList]):
3357         * WebView/WebViewInternal.h:
3358
3359 2016-05-22  Brady Eidson  <beidson@apple.com>
3360
3361         Move to C++14.
3362         https://bugs.webkit.org/show_bug.cgi?id=157948
3363
3364         Reviewed by Michael Catanzaro.
3365
3366         * Configurations/Base.xcconfig:
3367
3368 2016-05-20  Enrica Casucci  <enrica@apple.com>
3369
3370         Drag cannot start if no drag data or custom data is available in the Pasteboard.
3371         https://bugs.webkit.org/show_bug.cgi?id=157911
3372         rdar://problem/24577706
3373
3374         Reviewed by Tim Horton.
3375
3376         We need to make sure there is always one item in common between source and target
3377         of the drag and drop operation.
3378
3379         * WebView/WebHTMLView.mm:
3380         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3381
3382 2016-05-19  Enrica Casucci  <enrica@apple.com>
3383
3384         Drag cannot start if no drag data is available in the Pasteboard.
3385         https://bugs.webkit.org/show_bug.cgi?id=157911
3386         rdar://problem/24577706
3387
3388         Reviewed by Tim Horton.
3389
3390         * WebView/WebHTMLView.mm:
3391         (+[WebHTMLView _dummyPasteboardType]):
3392         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3393         * WebView/WebHTMLViewPrivate.h:
3394         * WebView/WebView.mm:
3395         (-[WebView _registerDraggedTypes]):
3396
3397 2016-05-19  Jer Noble  <jer.noble@apple.com>
3398
3399         [IOS] Add setting to allow playback to continue inline after exiting fullscreen.
3400         https://bugs.webkit.org/show_bug.cgi?id=157912
3401
3402         Reviewed by Eric Carlson.
3403
3404         Add a preference to control whether media should be allowed to continue playing inline when
3405         exiting fullscreen.
3406
3407         * WebView/WebPreferenceKeysPrivate.h:
3408         * WebView/WebPreferences.mm:
3409         (+[WebPreferences initialize]):
3410         (-[WebPreferences allowsInlineMediaPlaybackAfterFullscreen]):
3411         (-[WebPreferences setAllowsInlineMediaPlaybackAfterFullscreen:]):
3412         * WebView/WebPreferencesPrivate.h:
3413         * WebView/WebView.mm:
3414         (-[WebView _preferencesChanged:]):
3415
3416 2016-05-18  Brady Eidson  <beidson@apple.com>
3417
3418         Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
3419         https://bugs.webkit.org/show_bug.cgi?id=157823
3420
3421         Reviewed by Alex Christensen.
3422
3423         * Storage/WebDatabaseManager.mm:
3424         (-[WebDatabaseManager deleteAllIndexedDatabases]):
3425         * Storage/WebDatabaseManagerPrivate.h:
3426
3427 2016-05-17  Beth Dakin  <bdakin@apple.com>
3428
3429         Make handleAcceptedCandidate a public function
3430         https://bugs.webkit.org/show_bug.cgi?id=157763
3431         -and corresponding-
3432         rdar://problem/26206397
3433
3434         Reviewed by Tim Horton.
3435
3436         This patch re-names handleAcceptedCandidate to 
3437         handleAcceptedCandidateWithSoftSpaces. The function now takes a 
3438         WebCore::TextCheckingResult instead of an NSTextCheckingResult and it can be 
3439         called from outside of WebEditorClient.
3440
3441         * WebCoreSupport/WebEditorClient.h:
3442         * WebCoreSupport/WebEditorClient.mm:
3443         (WebEditorClient::handleRequestedCandidates):
3444         (WebEditorClient::handleAcceptedCandidateWithSoftSpaces):
3445         (textCheckingResultFromNSTextCheckingResult): Deleted.
3446         (WebEditorClient::handleAcceptedCandidate): Deleted.
3447
3448         Move showCandidates to WebViewPrivate so that it can be overridden by a test.
3449         * WebView/WebViewInternal.h:
3450         * WebView/WebViewPrivate.h:
3451
3452 2016-05-17  Dean Jackson  <dino@apple.com>
3453
3454         Remove ES6_GENERATORS flag
3455         https://bugs.webkit.org/show_bug.cgi?id=157815
3456         <rdar://problem/26332894>
3457
3458         Reviewed by Geoffrey Garen.
3459
3460         This flag isn't needed. Generators are enabled everywhere and
3461         part of a stable specification.
3462
3463         * Configurations/FeatureDefines.xcconfig:
3464
3465 2016-05-17  Filip Pizlo  <fpizlo@apple.com>
3466
3467         WTF should know about Language
3468         https://bugs.webkit.org/show_bug.cgi?id=157756
3469
3470         Reviewed by Geoffrey Garen.
3471
3472         Rewires a bunch of includes/imports.
3473
3474         * WebCoreSupport/PopupMenuMac.mm:
3475         * WebCoreSupport/WebChromeClient.mm:
3476         * WebCoreSupport/WebFrameLoaderClient.mm:
3477         * WebCoreSupport/WebGeolocationClient.mm:
3478         * WebCoreSupport/WebNotificationClient.mm:
3479         * WebCoreSupport/WebPlatformStrategies.mm:
3480         * WebCoreSupport/WebUserMediaClient.mm:
3481         * WebCoreSupport/WebVisitedLinkStore.mm:
3482         * WebView/WebHTMLView.mm:
3483
3484 2016-05-13  Enrica Casucci  <enrica@apple.com>
3485
3486         Remove unused initializer for WebEvent on iOS.
3487         https://bugs.webkit.org/show_bug.cgi?id=157689
3488
3489         Reviewed by Anders Carlsson.
3490
3491         Removing use of characterSet property.
3492
3493         * WebView/WebHTMLView.mm:
3494         (-[WebHTMLView _handleEditingKeyEvent:]):
3495
3496
3497 2016-05-13  Commit Queue  <commit-queue@webkit.org>
3498
3499         Unreviewed, rolling out r200894.
3500         https://bugs.webkit.org/show_bug.cgi?id=157695
3501
3502         This change broke the iOS build (Requested by ryanhaddad on
3503         #webkit).
3504
3505         Reverted changeset:
3506
3507         "Remove unused initializer for WebEvent on iOS."
3508         https://bugs.webkit.org/show_bug.cgi?id=157689
3509         http://trac.webkit.org/changeset/200894
3510
3511 2016-05-13  Enrica Casucci  <enrica@apple.com>
3512
3513         Remove unused initializer for WebEvent on iOS.
3514         https://bugs.webkit.org/show_bug.cgi?id=157689
3515
3516         Reviewed by Anders Carlsson.
3517
3518         Removing use of characterSet property.
3519
3520         * WebView/WebHTMLView.mm:
3521         (-[WebHTMLView _handleEditingKeyEvent:]):
3522
3523 2016-05-13  Beth Dakin  <bdakin@apple.com>
3524
3525         Build fix.
3526
3527         * WebView/WebView.mm:
3528
3529 2016-05-13  Beth Dakin  <bdakin@apple.com>
3530
3531         Add dyldSPI.h for linked on or after checks, and add one for link preview
3532         https://bugs.webkit.org/show_bug.cgi?id=157401
3533         -and corresponding-
3534         rdar://problem/26253396
3535
3536         Reviewed by Darin Adler.
3537
3538         This patch removes DynamicLinkerSPI.h and replaces it with 
3539         wtf/spi/darwin/dyldSPI.h
3540
3541         * WebView/WebView.mm:
3542
3543 2016-05-13  Tina Liu  <iting_liu@apple.com>
3544
3545         Revert r199691.
3546         https://bugs.webkit.org/show_bug.cgi?id=157645
3547         <rdar://problem/26235373>
3548
3549         Reviewed by Darin Adler.
3550
3551         * WebCoreSupport/WebPlatformStrategies.h:
3552         * WebCoreSupport/WebPlatformStrategies.mm:
3553         (WebPlatformStrategies::setPrivateBrowsingPluginLoadClientPolicy): Deleted.
3554
3555 2016-05-12  Jiewen Tan  <jiewen_tan@apple.com>
3556
3557         Unreviewed build fix for r200799.
3558
3559         * WebView/WebView.mm:
3560
3561 2016-05-12  Jiewen Tan  <jiewen_tan@apple.com>
3562
3563         REGRESSION (r199313): ICBC app: text field In the webview is not tappable
3564         https://bugs.webkit.org/show_bug.cgi?id=157396
3565         <rdar://problem/25931513>
3566
3567         Reviewed by David Kilzer.
3568
3569         Add a quirk for WebKit1 apps.
3570
3571         * WebView/WebView.mm:
3572         (shouldConvertInvalidURLsToBlank):
3573         (-[WebView _preferencesChanged:]):
3574
3575 2016-05-12  Beth Dakin  <bdakin@apple.com>
3576
3577         WebKitAdditions needs to be notified before the WebView is dealloc'd
3578         https://bugs.webkit.org/show_bug.cgi?id=157633
3579         -and corresponding-
3580         rdar://problem/26134539
3581
3582         Reviewed by Anders Carlsson.
3583
3584         * WebView/WebView.mm:
3585         (-[WebView dealloc]):
3586         * WebView/WebViewInternal.h:
3587
3588 2016-05-12  Konstantin Tokarev  <annulen@yandex.ru>
3589
3590         Use reference instead of pointer in FrameLoaderClient::saveViewStateToItem.
3591         https://bugs.webkit.org/show_bug.cgi?id=157624
3592
3593         Reviewed by Darin Adler.
3594
3595         * WebCoreSupport/WebFrameLoaderClient.h:
3596         * WebCoreSupport/WebFrameLoaderClient.mm:
3597         (WebFrameLoaderClient::saveViewStateToItem):
3598         * WebView/WebFrame.mm:
3599         (-[WebFrame _saveViewState]):
3600
3601 2016-05-12  Csaba Osztrogonác  <ossy@webkit.org>
3602
3603         Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
3604         https://bugs.webkit.org/show_bug.cgi?id=157564
3605
3606         Reviewed by Darin Adler.
3607
3608         * Configurations/FeatureDefines.xcconfig:
3609
3610 2016-05-11  Chris Dumez  <cdumez@apple.com>
3611
3612         Update Node::appendChild() / replaceChild() / removeChild() / insertBefore() to take references instead of pointers
3613         https://bugs.webkit.org/show_bug.cgi?id=157556
3614
3615         Reviewed by Darin Adler.
3616
3617         * WebView/WebFrame.mm:
3618         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
3619
3620 2016-05-10  Shaw rich  <richshaw@126.com>
3621
3622         [OS X] Compatible with gnu sed grammar due to compile error with gnu sed
3623         https://bugs.webkit.org/show_bug.cgi?id=157526
3624
3625         Reviewed by Darin Adler.
3626
3627         * MigrateHeaders.make:
3628
3629 2016-05-10  Simon Fraser  <simon.fraser@apple.com>
3630
3631         [iOS WK1] text autosizing was on for all layout tests
3632         https://bugs.webkit.org/show_bug.cgi?id=157541
3633
3634         Reviewed by Tim Horton.
3635
3636         Make sure that we transfer the WK1 text autosizing preference to Settings.
3637
3638         * WebView/WebView.mm:
3639         (-[WebView _preferencesChanged:]):
3640
3641 2016-05-09  Tim Horton  <timothy_horton@apple.com>
3642
3643         [WebKit1] Invoking a link preview on a complex link (e.g. an image) results in an empty TextIndicator
3644         https://bugs.webkit.org/show_bug.cgi?id=157497
3645         <rdar://problem/25872773>
3646
3647         Reviewed by Anders Carlsson.
3648
3649         * WebView/WebImmediateActionController.mm:
3650         (-[WebImmediateActionController _defaultAnimationController]):
3651         r198578 fixed this for WebKit2, but forgot about WebKit1.
3652
3653 2016-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3654
3655         [OS X] Migrate our Font classes entirely off of NSFont
3656         https://bugs.webkit.org/show_bug.cgi?id=157464
3657
3658         Reviewed by Darin Adler.
3659
3660         * WebCoreSupport/PopupMenuMac.mm:
3661         (PopupMenuMac::populate):
3662         (PopupMenuMac::show):
3663         * WebView/WebHTMLView.mm:
3664         (fontNameForDescription):
3665         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3666
3667 2016-05-06  Joseph Pecoraro  <pecoraro@apple.com>
3668
3669         Rename HitTestRequest DisallowShadowContent to DisallowUserAgentShadowContent
3670         https://bugs.webkit.org/show_bug.cgi?id=157447
3671
3672         Reviewed by Ryosuke Niwa.
3673
3674         * WebView/WebFrame.mm:
3675         (-[WebFrame elementAtPoint:]):
3676         * WebView/WebHTMLView.mm:
3677         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
3678
3679 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
3680
3681         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
3682         https://bugs.webkit.org/show_bug.cgi?id=157432
3683         rdar://problem/16406720
3684
3685         Reviewed by Dean Jackson.
3686
3687         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
3688
3689         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
3690         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
3691         These two settings are shared with TEXT_AUTOSIZING.
3692
3693         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
3694
3695         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
3696         without changes.
3697
3698         An implication of this set of changes is that the way clients enable text autosizing
3699         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
3700         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
3701         on iPhone only, not iPad.
3702
3703         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
3704         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
3705
3706         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
3707         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
3708         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
3709
3710         * Configurations/FeatureDefines.xcconfig:
3711         * WebView/WebPreferenceKeysPrivate.h:
3712         * WebView/WebPreferences.mm:
3713         (+[WebPreferences initialize]):
3714         (-[WebPreferences _setTextAutosizingEnabled:]):
3715         (-[WebPreferences _textAutosizingEnabled]):
3716         * WebView/WebPreferencesPrivate.h:
3717
3718 2016-05-06  Dean Jackson  <dino@apple.com>
3719
3720         Regions, Shapes and Tracks don't need runtime features
3721         https://bugs.webkit.org/show_bug.cgi?id=157426
3722         <rdar://problem/26146262>
3723
3724         Reviewed by Simon Fraser.
3725
3726         The following RuntimeEnabledFeatures can be removed since
3727         we have no need to disable them (they are stable and have
3728         shipped for a while):
3729         - CSS Regions
3730         - CSS Shapes
3731         - Media tracks
3732
3733         * WebView/WebPreferenceKeysPrivate.h:
3734         * WebView/WebPreferences.mm:
3735         (+[WebPreferences initialize]): Deleted.
3736         (-[WebPreferences cssRegionsEnabled]): Deleted.
3737         (-[WebPreferences setCSSRegionsEnabled:]): Deleted.
3738         (-[WebPreferences cssCompositingEnabled]): Deleted.
3739         (-[WebPreferences setCSSCompositingEnabled:]): Deleted.
3740         * WebView/WebPreferencesPrivate.h:
3741         * WebView/WebView.mm:
3742         (-[WebView _preferencesChanged:]): Deleted.
3743
3744 2016-05-06  Daniel Bates  <dabates@apple.com>
3745
3746         Remove workaround for Apple Internal bots
3747         <rdar://problem/25989808>
3748
3749         Reverts the workaround added in r200211 as it is no longer needed.
3750
3751         * WebView/WebPDFView.h:
3752
3753 2016-05-02  Daniel Bates  <dabates@apple.com>
3754
3755         CSP: Add workaround for XtraMath
3756         https://bugs.webkit.org/show_bug.cgi?id=157252
3757
3758         Reviewed by Andy Estes.
3759
3760         * WebView/WebView.mm:
3761         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol): Allow * to match any protocol for
3762         applicable versions of app XtraMath.
3763
3764 2016-05-02  Daniel Bates  <dabates@apple.com>
3765
3766         DatabaseTracker::closeAllDatabases calls Database::close from the wrong thread
3767         https://bugs.webkit.org/show_bug.cgi?id=147672
3768         <rdar://problem/22357464>
3769
3770         Reviewed by Brady Eidson.
3771
3772         Update the background assertion expiration callback to call DatabaseTracker::closeAllDatabases()
3773         with CurrentQueryBehavior::Interrupt so that we abort a long running query and close the database
3774         immediately to avoid holding a locked file when the process is suspended.
3775
3776         * Storage/WebDatabaseManager.mm:
3777         (+[WebDatabaseManager startBackgroundTask]):
3778
3779 2016-04-29  Dean Jackson  <dino@apple.com>
3780
3781         RTL <select> popup menu is in the wrong location
3782         https://bugs.webkit.org/show_bug.cgi?id=157159
3783         <rdar://problem/25894451>
3784
3785         Reapply http://trac.webkit.org/changeset/200217
3786         but with changes that will allow it to build on Yosemite.
3787
3788         * WebCoreSupport/PopupMenuMac.mm:
3789         (PopupMenuMac::show):
3790
3791 2016-04-29  Commit Queue  <commit-queue@webkit.org>
3792
3793         Unreviewed, rolling out r200217.
3794         https://bugs.webkit.org/show_bug.cgi?id=157183
3795
3796         This change broke the Yosemite build. (Requested by ryanhaddad
3797         on #webkit).
3798
3799         Reverted changeset:
3800
3801         "RTL <select> popup menu is in the wrong location"
3802         https://bugs.webkit.org/show_bug.cgi?id=157159
3803         http://trac.webkit.org/changeset/200217
3804
3805 2016-04-28  Dean Jackson  <dino@apple.com>
3806
3807         RTL <select> popup menu is in the wrong location
3808         https://bugs.webkit.org/show_bug.cgi?id=157159
3809         <rdar://problem/25894451>
3810
3811         Reviewed by Simon Fraser.
3812
3813         Make sure both the NSPopupMenuCell and the NSPopupMenu take
3814         the text direction into account, and offset the position
3815         of the menu slightly if we're in RTL mode.
3816
3817         Unfortunately our test infrastructure is unable to exercise
3818         this because it runs without a window, and the popup menu
3819         is not captured in the screenshot.
3820
3821         * WebCoreSupport/PopupMenuMac.mm:
3822         (PopupMenuMac::show):
3823
3824 2016-04-28  Manuel Rego Casasnovas  <rego@igalia.com>
3825
3826         [css-grid] Add CSS Grid Layout runtime flag
3827         https://bugs.webkit.org/show_bug.cgi?id=157134
3828
3829         Reviewed by Simon Fraser.
3830
3831         Add CSS Grid Layout runtime flag based on preferences,
3832         enabled by default.
3833
3834         * WebView/WebPreferenceKeysPrivate.h:
3835         * WebView/WebPreferences.mm:
3836         (+[WebPreferences initialize]):
3837         (-[WebPreferences isCSSGridLayoutEnabled]):
3838         (-[WebPreferences setCSSGridLayoutEnabled:]):
3839         * WebView/WebPreferencesPrivate.h:
3840         * WebView/WebView.mm:
3841         (-[WebView _preferencesChanged:]):
3842
3843 2016-04-28  Daniel Bates  <dabates@apple.com>
3844
3845         Another fix for the Apple Internal OS X build
3846         <rdar://problem/25989808>
3847
3848         Reviewed by Anders Carlsson.
3849
3850         * WebView/WebPDFView.h:
3851
3852 2016-04-28  Daniel Bates  <dabates@apple.com>
3853
3854         Fix the Apple Internal OS X build
3855
3856         * WebView/WebPDFView.h: Import PDFKit for definition of protocol PDFViewDelegate.
3857         Forward declare protocol PDFViewDelegate as appropriate. Mark WebPDFView as implementing
3858         protocol PDFViewDelegate.
3859         * WebView/WebPDFView.mm: Move import of PDFKit from here to the header.
3860
3861 2016-04-27  Daniel Bates  <dabates@apple.com>
3862
3863         CSP: Add app-specific workaround for Ecobee and Quora
3864         https://bugs.webkit.org/show_bug.cgi?id=157005
3865         <rdar://problem/25560776>
3866
3867         Reviewed by Brent Fulgham.
3868
3869         * Misc/WebKitVersionChecks.h:
3870         * WebView/WebView.mm:
3871         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol): Added.
3872         (-[WebView _preferencesChanged:]): Enable setting allowContentSecurityPolicySourceStarToMatchAnyProtocol
3873         if applicable.
3874
3875 2016-04-26  Joseph Pecoraro  <pecoraro@apple.com>
3876
3877         Uncaught Exception: SecurityError: DOM Exception 18: An attempt was made to break through the security policy of the user agent.
3878         https://bugs.webkit.org/show_bug.cgi?id=156991
3879         <rdar://problem/25913475>
3880
3881         Reviewed by Timothy Hatcher.
3882
3883         * WebCoreSupport/WebInspectorClient.mm:
3884         (-[WebInspectorWindowController init]):
3885         Apply the same universal file access to WebKit1 Web Inspector views that
3886         we apply to WebKit2 views. Explicitly always allow access to storage
3887         for Web Inspector content just in case as we already allow universal
3888         file access.
3889
3890 2016-04-26  Beth Dakin  <bdakin@apple.com>
3891
3892         Check to make sure shouldRequestCandidates() before requesting candidates
3893         https://bugs.webkit.org/show_bug.cgi?id=157038
3894         -and corresponding-
3895         rdar://problem/25910418
3896
3897         Reviewed by Tim Horton.
3898
3899         This patch limits requesting and showing candidates to cases where 
3900         shouldRequestCandidates() is true. This patch also caches the sequence number 
3901         returned by [NSSpellChecker requestCandidatesForSelectedRange:] to make sure 
3902         it is equal to the sequence number sent to the callback handler so that we do 
3903         not show candidates for old requests.
3904
3905         * WebCoreSupport/WebEditorClient.h:
3906         * WebCoreSupport/WebEditorClient.mm:
3907         (WebEditorClient::requestCandidatesForSelection):
3908         (WebEditorClient::handleRequestedCandidates):
3909         * WebView/WebView.mm:
3910         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3911         (-[WebView shouldRequestCandidates]):
3912         * WebView/WebViewInternal.h:
3913
3914 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3915
3916         Remove the build flag for template elements
3917         https://bugs.webkit.org/show_bug.cgi?id=157022
3918
3919         Reviewed by Daniel Bates.
3920
3921         * Configurations/FeatureDefines.xcconfig:
3922
3923 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
3924
3925         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
3926         https://bugs.webkit.org/show_bug.cgi?id=156929
3927
3928         Reviewed by Darin Adler.
3929
3930         * Misc/WebKitNSStringExtras.mm:
3931         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Drawing
3932         a string with a null font shouldn't do anything.
3933         * Misc/WebStringTruncator.mm: We can't truncate a string if we don't have a font
3934         to use.
3935         (+[WebStringTruncator centerTruncateString:toWidth:]):
3936         (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
3937         (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
3938         (+[WebStringTruncator widthOfString:font:]):
3939
3940 2016-04-25  Beth Dakin  <bdakin@apple.com>
3941
3942         WebEditorClient should properly write to m_rangeForCandidates
3943         https://bugs.webkit.org/show_bug.cgi?id=157003
3944         -and corresponding-
3945         rdar://problem/25910418
3946
3947         Reviewed by Tim Horton.
3948
3949         Actually write to m_rangeForCandidates instead of declaring a local variable 
3950         of the same name. :-/
3951         * WebCoreSupport/WebEditorClient.mm:
3952         (WebEditorClient::requestCandidatesForSelection):
3953
3954 2016-04-23  Andy Estes  <aestes@apple.com>
3955
3956         Fix issues found by the clang static analyzer
3957         https://bugs.webkit.org/show_bug.cgi?id=156956
3958
3959         Reviewed by Alexey Proskuryakov.
3960
3961         * WebView/WebDeviceOrientationProviderMock.mm:
3962         (-[WebDeviceOrientationProviderMock dealloc]): [super dealloc] should be called last.
3963
3964 2016-04-21  Tim Horton  <timothy_horton@apple.com>
3965
3966         Fix the iOS build: WAKView may not respond to drawLayer:inContext:
3967         https://bugs.webkit.org/show_bug.cgi?id=156879
3968         <rdar://problem/25772661>
3969
3970         Reviewed by Beth Dakin.
3971
3972         * WebView/WebHTMLView.mm:
3973         WebHTMLView on iOS never uses drawLayer:inContext:, and WAKView
3974         doesn't implement it, so this would have thrown an exception
3975         if called, anyway. Fix the build with stricter CA protocols.
3976
3977 2016-04-21  Jer Noble  <jer.noble@apple.com>
3978
3979         [WK1] Add WebPlaybackSession support to WebKit
3980         https://bugs.webkit.org/show_bug.cgi?id=156854
3981
3982         Reviewed by Beth Dakin.
3983
3984         Add support for WebPlaybackSession and the ChromeClient methods setUpPlaybackControlsManager() and
3985         clearPlaybackControlsManager() to WebKit.
3986
3987         * WebCoreSupport/WebChromeClient.h:
3988         * WebCoreSupport/WebChromeClient.mm:
3989         (WebChromeClient::setUpPlaybackControlsManager):
3990         (WebChromeClient::clearPlaybackControlsManager):
3991         * WebView/WebView.mm:
3992         (-[WebView _hasActiveVideoForControlsInterface]):
3993         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3994         (-[WebView _clearPlaybackControlsManagerForMediaElement:]):
3995         * WebView/WebViewData.h:
3996         * WebView/WebViewData.mm:
3997         * WebView/WebViewInternal.h:
3998
3999 2016-04-21  Anders Carlsson  <andersca@apple.com>
4000
4001         Stop using ApplicationCacheStorage::singleton() in WebKitLegacy
4002         https://bugs.webkit.org/show_bug.cgi?id=156859
4003
4004         Reviewed by Tim Horton.
4005
4006         * WebCoreSupport/WebApplicationCache.mm:
4007         (+[WebApplicationCache initializeWithBundleIdentifier:]):
4008         Change this to just store the bundle identifier.
4009
4010         (applicationCacheBundleIdentifier):
4011         Helper function that returns the bundle identifier for the app cache.
4012
4013         (applicationCachePath):
4014         Return the application cache path.
4015
4016         (webApplicationCacheStorage):
4017         Create a new ApplicationCacheStorage object.
4018
4019         * WebView/WebView.mm:
4020         (-[WebView _commonInitializationWithFrameName:groupName:]):
4021         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
4022         Set pageConfiguration.applicationCacheStorage to webApplicationCacheStorage().
4023
4024         (WebKitInitializeApplicationCachePathIfNecessary): Deleted.
4025
4026 2016-04-21  Beth Dakin  <bdakin@apple.com>
4027
4028         showCandidates() should take a range and the string should be the whole 
4029         paragraph
4030         https://bugs.webkit.org/show_bug.cgi?id=156813
4031         -and corresponding-
4032         rdar://problem/25760533
4033
4034         Reviewed by Tim Horton.
4035
4036         Cache the range and the paragraph since we compute them in 
4037         requestCandidatesForSelection, and then we can use them again in 
4038         handleRequestedCandidates.
4039         * WebCoreSupport/WebEditorClient.h:
4040         * WebCoreSupport/WebEditorClient.mm:
4041         (WebEditorClient::requestCandidatesForSelection):
4042         (WebEditorClient::handleRequestedCandidates):
4043         * WebView/WebView.mm:
4044         (-[WebView updateWebViewAdditions]):
4045         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
4046         (-[WebView showCandidates:forString:inRect:view:completionHandler:]): Deleted.
4047         * WebView/WebViewInternal.h:
4048
4049 2016-04-21  Chris Dumez  <cdumez@apple.com>
4050
4051         Drop [UsePointersEvenForNonNullableObjectArguments] from Range
4052         https://bugs.webkit.org/show_bug.cgi?id=156805
4053
4054         Reviewed by Youenn Fablet.
4055
4056         * WebView/WebFrame.mm:
4057         (-[WebFrame _smartDeleteRangeForProposedRange:]):
4058
4059 2016-04-20  Brady Eidson  <beidson@apple.com>
4060
4061         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
4062         https://bugs.webkit.org/show_bug.cgi?id=156782
4063
4064         Reviewed by Alex Christensen.
4065
4066         * Configurations/FeatureDefines.xcconfig:
4067
4068 2016-04-18  Anders Carlsson  <andersca@apple.com>
4069
4070         Fix build with newer versions of clang.
4071         rdar://problem/25749769
4072
4073         * WebCoreSupport/WebContextMenuClient.mm:
4074         * WebView/WebHTMLView.mm:
4075         Forward declare some AppKit IPI.
4076
4077 2016-04-18  Tina Liu  <iting_liu@apple.com>
4078
4079         Overrode a virtual function of WebCore::PluginStrategy
4080         https://bugs.webkit.org/show_bug.cgi?id=156540
4081
4082         Reviewed by Anders Carlsson.
4083
4084         * WebCoreSupport/WebPlatformStrategies.h:
4085         * WebCoreSupport/WebPlatformStrategies.mm:
4086         (WebPlatformStrategies::setPrivateBrowsingPluginLoadClientPolicy):
4087
4088 2016-04-18  Brent Fulgham  <bfulgham@apple.com>
4089
4090         CSP: Remove stubs for dynamically-added favicons (via link rel="icon")
4091         https://bugs.webkit.org/show_bug.cgi?id=153151
4092         <rdar://problem/24383176>
4093
4094         Reviewed by Darin Adler.
4095
4096         Remove the unused dynamic favicon code and tests.
4097
4098         * WebCoreSupport/WebFrameLoaderClient.h:
4099         * WebCoreSupport/WebFrameLoaderClient.mm:
4100         (WebFrameLoaderClient::dispatchDidChangeIcons): Deleted.
4101
4102 2016-04-15  Darin Adler  <darin@apple.com>
4103
4104         Reduce use of Deprecated::ScriptXXX classes
4105         https://bugs.webkit.org/show_bug.cgi?id=156632
4106
4107         Reviewed by Alex Christensen.
4108
4109         * WebView/WebFrame.mm:
4110         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Use references instead
4111         of pointers.
4112         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Updated
4113         since return value is a JSValue.
4114         * WebView/WebView.mm:
4115         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
4116
4117 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
4118
4119         Make <a download> a runtime enabled option
4120         https://bugs.webkit.org/show_bug.cgi?id=156583
4121         <rdar://problem/25733449>
4122
4123         Reviewed by Alex Christensen.
4124
4125         Add a download attribute runtime flag based on preferences.
4126         Disable the download attribute by default.
4127
4128         * WebView/WebPreferenceKeysPrivate.h:
4129         * WebView/WebPreferences.mm:
4130         (+[WebPreferences initialize]):
4131         (-[WebPreferences setFetchAPIEnabled:]):
4132         (-[WebPreferences downloadAttributeEnabled]):
4133         (-[WebPreferences setDownloadAttributeEnabled:]):
4134         * WebView/WebPreferencesPrivate.h:
4135         * WebView/WebView.mm:
4136         (-[WebView _preferencesChanged]): Set the runtime flag properly
4137         based on the user preferences.
4138
4139 2016-04-09  Gavin Barraclough  <barraclough@apple.com>
4140
4141         WebKit should adopt journal_mode=wal for all SQLite databases.
4142         https://bugs.webkit.org/show_bug.cgi?id=133496
4143
4144         Reviewed by Darin Adler.
4145
4146         * Storage/WebDatabaseManagerPrivate.h:
4147             - renamed deleteAllDatabases -> deleteAllDatabasesImmediately.
4148
4149 2016-04-05  Oliver Hunt  <oliver@apple.com>
4150
4151         Remove compile time define for SEPARATED_HEAP
4152         https://bugs.webkit.org/show_bug.cgi?id=155508
4153
4154         Reviewed by Mark Lam.
4155
4156         * Configurations/FeatureDefines.xcconfig:
4157
4158 2016-04-08  Sam Weinig  <sam@webkit.org>
4159
4160         Remove support for custom target picker actions
4161         <rdar://problem/24987783>
4162         https://bugs.webkit.org/show_bug.cgi?id=156434
4163
4164         Reviewed by Eric Carlson.
4165
4166         This mostly entailed rolling out r197429 and r197569.
4167
4168         * WebCoreSupport/WebChromeClient.h:
4169         * WebCoreSupport/WebChromeClient.mm:
4170         (WebChromeClient::removePlaybackTargetPickerClient):
4171         (WebChromeClient::showPlaybackTargetPicker):
4172         * WebView/WebMediaPlaybackTargetPicker.h:
4173         * WebView/WebMediaPlaybackTargetPicker.mm:
4174         (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
4175         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
4176         (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
4177         (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget):
4178         (WebMediaPlaybackTargetPicker::invalidate):
4179         (WebMediaPlaybackTargetPicker::customPlaybackActionSelected): Deleted.
4180         * WebView/WebView.mm:
4181         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
4182         (-[WebView _playbackTargetPickerClientStateDidChange:state:]):
4183
4184 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
4185
4186         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
4187         https://bugs.webkit.org/show_bug.cgi?id=156384
4188
4189         Reviewed by Ryosuke Niwa.
4190
4191         * Configurations/FeatureDefines.xcconfig:
4192
4193 2016-04-07  Brian Burg  <bburg@apple.com>
4194
4195         CookieJar should support adding synthetic cookies for developer tools
4196         https://bugs.webkit.org/show_bug.cgi?id=156091
4197         <rdar://problem/25581340>
4198
4199         Reviewed by Timothy Hatcher.
4200
4201         * WebCoreSupport/WebPlatformStrategies.h:
4202         * WebCoreSupport/WebPlatformStrategies.mm:
4203         (WebPlatformStrategies::addCookie):
4204         Add new method override.
4205
4206 2016-04-06  Alex Christensen  <achristensen@webkit.org>
4207
4208         Fix CMake DumpRenderTree
4209         https://bugs.webkit.org/show_bug.cgi?id=156305